WebKitTools/ChangeLog

   1 2010-12-02  Hayato Ito  <hayato@chromium.org>
   2
   3         Reviewed by Eric Seidel.
   4
   5         Refactor test_types's compare_output() method so that it takes a
   6         TestInput object.
   7
   8         compare_output() will need additional information included in a TestInput
   9         object to support reftests. This change is a pre-requirement of that.
  10
  11         https://bugs.webkit.org/show_bug.cgi?id=50362
  12
  13         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  14         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  15         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  16         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
  17         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  18
  19 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
  20
  21         Reviewed by Anders Carlsson.
  22
  23         Add the ability to run script on 'new' and 'paint' in the test plugin
  24         https://bugs.webkit.org/show_bug.cgi?id=50425
  25
  26         Add "onnew" and "onpaintevent" attributes to the test plugin,
  27         so that tests can run JS at these times.
  28
  29         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  30         (pluginAllocate):
  31         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  32         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  33         (NPP_New):
  34         (NPP_Destroy):
  35         (handleEventCarbon):
  36         (handleEventCocoa):
  37         (NPP_HandleEvent):
  38
  39 2010-12-02  Sam Weinig  <sam@webkit.org>
  40
  41         Fix Qt build.
  42
  43         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  44         (WTR::PlatformWebView::PlatformWebView):
  45
  46 2010-12-02  Sam Weinig  <sam@webkit.org>
  47
  48         Reviewed by Anders Carlsson.
  49
  50         WebKit2 Preferences should be held off the PageGroup, not the Context
  51         https://bugs.webkit.org/show_bug.cgi?id=50414
  52
  53         Update for API changes.
  54
  55         * WebKitTestRunner/PlatformWebView.h:
  56         * WebKitTestRunner/TestController.cpp:
  57         (WTR::createOtherPage):
  58         (WTR::TestController::initialize):
  59         (WTR::TestController::resetStateToConsistentValues):
  60         * WebKitTestRunner/TestController.h:
  61         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  62         (WTR::PlatformWebView::PlatformWebView):
  63         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
  64         (WTR::PlatformWebView::PlatformWebView):
  65
  66 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
  67
  68         Reviewed by Tony Chang.
  69
  70         new-run-webkit-tests: minor cleanup for multiprocessing work
  71
  72         This change:
  73         * moves worker naming into TestShellThread, eliminating a
  74           parameter to the constructor and putting the responsibility in
  75           the correct place.
  76         * eliminates the _WorkerState() class in message_broker, because
  77           it turns out that state really needs to be in run_webkit_tests
  78         * renames the Broker classes to be module-private.
  79         * fixes a bunch of minor commenting and whitespace issues to
  80           make subsequent patches a bit clearer.
  81         * Adds a Port hook for default_worker_model() so that we can
  82           accomodate the potential for different worker models on
  83           different ports.
  84         * merge in the fix from 50420 for the brokenness introduced in
  85           bug 50367.
  86
  87         This patch depends on bug 50367.
  88
  89         https://bugs.webkit.org/show_bug.cgi?id=50372
  90
  91         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  92         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  93         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
  94         * Scripts/webkitpy/layout_tests/port/base.py:
  95         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  96         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  97
  98 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
  99
 100         Reviewed by Tony Chang.
 101
 102         This change is a bunch of cleanup / refactoring of the file
 103         below. It moves a bunch of free functions to methods on the
 104         TestShellThread class, and restructures other methods to be
 105         closer to the structure we'll need for the multiprocessing
 106         rewrite.
 107
 108         It also makes the logic of --run-singly a *lot* easier to follow
 109         by nestling all of the separate-thread logic into a single
 110         routine.
 111
 112         There should be no semantic changes in this patch, just cleanup.
 113
 114         https://bugs.webkit.org/show_bug.cgi?id=50367
 115
 116         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 117
 118 2010-12-02  Tony Chang  <tony@chromium.org>
 119
 120         Unreviewed, rolling out r73164.
 121         http://trac.webkit.org/changeset/73164
 122         https://bugs.webkit.org/show_bug.cgi?id=50359
 123
 124         broke debugger tests on win
 125
 126         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 127
 128 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
 129
 130         Reviewed by Tony Chang.
 131
 132         Rebaseline server: add updating of baselines
 133         https://bugs.webkit.org/show_bug.cgi?id=50305
 134
 135         Implements updating of baselines, where we copy -actual.* files over
 136         the current -expected.* files. To do this, we need a
 137         _get_actual_result_files method to get test results files and a
 138         _rebaseline_test method to actually do the file copy and SCM operation.
 139         _rebaseline_test logs output into a buffer, this is useful for both
 140         showing result in the UI and for unit tests.
 141
 142         To make passing around of the various test environment properties
 143         (results directory, filesystem, SCM, etc) easier, add a TestConfig
 144         class for them.
 145
 146         Moving of existing baselines is not implemented yet, this patch is big
 147         enough as it is.
 148
 149         * Scripts/webkitpy/common/system/filesystem.py:
 150         * Scripts/webkitpy/common/system/filesystem_mock.py:
 151         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
 152         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
 153         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
 154         * Scripts/webkitpy/tool/mocktool.py:
 155
 156 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
 157
 158         Unreviewed build fix after vcproj updates.
 159
 160         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
 161         that WIN_CAIRO is defined for this build.
 162         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
 163         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
 164         (these were previously 'Debug_Cairo' and 'Release_Cairo'
 165
 166 2010-12-02  Sam Weinig  <sam@webkit.org>
 167
 168         Reviewed by Anders Carlsson.
 169
 170         WebKit2 needs API to turn on popup blocking
 171         https://bugs.webkit.org/show_bug.cgi?id=50407
 172
 173         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
 174         (TestWebKitAPI::TEST):
 175         * WebKitTestRunner/TestController.cpp:
 176         (WTR::TestController::resetStateToConsistentValues):
 177
 178 2010-12-01  Tony Chang  <tony@chromium.org>
 179
 180         Reviewed by Ojan Vafai.
 181
 182         [chromium] force NRWT to use DRT
 183         https://bugs.webkit.org/show_bug.cgi?id=50359
 184
 185         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 186
 187 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
 188
 189         Reviewed by Xan Lopez.
 190
 191         [GTK] DumpRenderTree has two copies of JavaScriptCore
 192         https://bugs.webkit.org/show_bug.cgi?id=49877
 193
 194         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
 195         LDADD list for DumpRenderTree.
 196
 197 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
 198
 199         Unreviewed: Added myself to list of Committers.
 200
 201         * Scripts/webkitpy/common/config/committers.py:
 202
 203 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
 204
 205         Reviewed by Adam Barth.
 206
 207         build-webkit --chromium always updates DEPS and re-generates project files
 208         https://bugs.webkit.org/show_bug.cgi?id=50340
 209
 210         Make build-webkit --chromium invoke update-webkit-chromium only when
 211         --update-chromium is passed in, so that we don't add 20 seconds to all
 212         builds.
 213
 214         Making all invocations update was added with r61883, with the goal of
 215         making EWS bots always update. The bots will switch to using this flag
 216         (as will all other webkit-patch build steps) so nothing should change
 217         for them.
 218
 219         * Scripts/webkitdirs.pm:
 220         * Scripts/webkitpy/common/config/ports.py:
 221         * Scripts/webkitpy/common/config/ports_unittest.py:
 222
 223 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
 224
 225         Reviewed by Tony Chang.
 226
 227         new-run-webkit-tests: add a --dry-run / -n flag
 228         https://bugs.webkit.org/show_bug.cgi?id=50045
 229
 230         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 231         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 232
 233 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
 234
 235         Reviewed by Adam Roben.
 236
 237         WinCairo build should not use link-time code generation (LTCG)
 238         https://bugs.webkit.org/show_bug.cgi?id=50353
 239
 240         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 241         * DumpRenderTree/win/DumpRenderTree.vcproj:
 242         * DumpRenderTree/win/ImageDiff.vcproj:
 243         * FindSafari/FindSafari.vcproj:
 244         * MiniBrowser/MiniBrowser.vcproj:
 245         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
 246         * WebKitAPITest/WebKitAPITest.vcproj:
 247         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
 248         * WebKitTestRunner/win/InjectedBundle.vcproj:
 249         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
 250         * WinLauncher/WinLauncher.vcproj:
 251         * record-memory-win/record-memory-win.vcproj:
 252
 253 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
 254
 255         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
 256         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
 257         adding the file to the sources list was not enough to force the rebuild.
 258
 259         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
 260         Remove an empty line at the end of this file to force a rebuild.
 261
 262 2010-12-01  Sam Weinig  <sam@webkit.org>
 263
 264         Fix windows build.
 265
 266         * MiniBrowser/win/BrowserView.cpp:
 267         (BrowserView::create):
 268
 269 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
 270
 271         Add missing file to the TestNetscapePlugin sources list after r73057.
 272
 273         * GNUmakefile.am: Add missing file.
 274
 275 2010-12-01  Sam Weinig  <sam@webkit.org>
 276
 277         Reviewed by Anders Carlsson.
 278
 279         Add PageGrouping to WebKit2 API
 280         https://bugs.webkit.org/show_bug.cgi?id=50332
 281
 282         - Update testing harnesses to deal with new PageGroup API.
 283
 284         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
 285         (WKBundleInitialize):
 286         * TestWebKitAPI/InjectedBundleController.cpp:
 287         (TestWebKitAPI::InjectedBundleController::initialize):
 288         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
 289         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
 290         * TestWebKitAPI/InjectedBundleController.h:
 291         * TestWebKitAPI/InjectedBundleTest.h:
 292         (TestWebKitAPI::InjectedBundleTest::initialize):
 293         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
 294         * TestWebKitAPI/PlatformUtilities.cpp:
 295         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
 296         * TestWebKitAPI/PlatformUtilities.h:
 297         * TestWebKitAPI/PlatformWebView.h:
 298         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
 299         (TestWebKitAPI::TEST):
 300         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
 301         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
 302         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 303         (TestWebKitAPI::PlatformWebView::PlatformWebView):
 304         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
 305         (TestWebKitAPI::PlatformWebView::PlatformWebView):
 306         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 307         (WTR::InjectedBundle::didInitializePageGroup):
 308         (WTR::InjectedBundle::initialize):
 309         (WTR::InjectedBundle::beginTesting):
 310         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 311         (WTR::InjectedBundle::pageGroup):
 312         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 313         (WTR::LayoutTestController::addUserScript):
 314         (WTR::LayoutTestController::addUserStyleSheet):
 315         (WTR::LayoutTestController::setXSSAuditorEnabled):
 316         * WebKitTestRunner/TestController.cpp:
 317         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
 318         (WTR::PlatformWebView::PlatformWebView):
 319
 320 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
 321
 322         Reviewed by Adam Roben.
 323
 324         vcproj changes can't be applied cleanly by the Windows EWS bot
 325         https://bugs.webkit.org/show_bug.cgi?id=50328
 326
 327         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
 328         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
 329         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
 330         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
 331         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
 332         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
 333         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
 334         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
 335         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
 336         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
 337         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
 338         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
 339         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
 340         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
 341         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
 342         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
 343         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
 344         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
 345         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
 346         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
 347         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
 348         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
 349         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
 350         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
 351         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
 352         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
 353         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
 354         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
 355         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
 356         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
 357         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
 358         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
 359         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
 360         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
 361         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
 362         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
 363         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
 364         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
 365         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
 366         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
 367         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
 368         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
 369         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
 370         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
 371         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
 372
 373 2010-12-01  Anders Carlsson  <andersca@apple.com>
 374
 375         Reviewed by Darin Adler.
 376
 377         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
 378         https://bugs.webkit.org/show_bug.cgi?id=50336
 379
 380         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 381         Add new test.
 382
 383         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
 384         (PluginTest::NPP_New):
 385         Add default implementation/
 386
 387         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
 388         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
 389         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
 390         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
 391         Get the user agent.
 392
 393         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 394         (NPP_New):
 395         Call PluginTest::NPP_New.
 396
 397         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 398         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 399         Add new files.
 400
 401         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 402         (webkit_test_plugin_new_instance):
 403         Call PluginTest::NPP_New.
 404
 405 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
 406
 407         [wx] Build fixes after recent trunk changes.
 408
 409         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 410         (LayoutTestController::findString):
 411         * wx/build/settings.py:
 412
 413 2010-12-01  Dan Bernstein  <mitz@apple.com>
 414
 415         Reviewed by Darin Adler.
 416
 417         WebKitTestRunner needs layoutTestController.findString
 418         https://bugs.webkit.org/show_bug.cgi?id=50238
 419
 420         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
 421         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 422         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
 423         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
 424
 425 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
 426
 427         Try using svn:eol-style native on a vcproj file.
 428
 429         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
 430
 431 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
 432
 433         Reviewed by Adam Roben.
 434
 435         [WINCE] Add WinCELauncher
 436         https://bugs.webkit.org/show_bug.cgi?id=50217
 437
 438         * WinCELauncher/main.cpp: Added.
 439
 440 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
 441
 442         Reviewed by Kenneth Rohde Christiansen.
 443
 444         [Qt] Implement layoutTestController.findString
 445         https://bugs.webkit.org/show_bug.cgi?id=50236
 446
 447         Add the missing function to the LayoutTestController.
 448
 449         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 450         (LayoutTestController::findString):
 451         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 452
 453 2010-11-30  Tony Chang  <tony@chromium.org>
 454
 455         Reviewed by Adam Barth.
 456
 457         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
 458         https://bugs.webkit.org/show_bug.cgi?id=49036
 459
 460         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
 461             for CppVariants.
 462         (LayoutTestController::cppVariantToBool):
 463         (LayoutTestController::cppVariantToInt32):
 464         (LayoutTestController::setDatabaseQuota):
 465         (LayoutTestController::evaluateInWebInspector):
 466         (LayoutTestController::setMockGeolocationError):
 467
 468 2010-11-30  Eric Seidel  <eric@webkit.org>
 469
 470         Reviewed by Tony Chang.
 471
 472         update-webkit should call git fetch before git svn rebase
 473         https://bugs.webkit.org/show_bug.cgi?id=50273
 474
 475         After discussion on webkit-dev, we've decided to move the "default"
 476         git setup to pulling updates from git.webkit.org in preference
 477         to rebuilding the local svn index using git svn fetch every time.
 478
 479         This change should have no effect on people using the "old" git setup
 480         and should dramatically increase the speed of updates for those using
 481         the "new" git setup along with update-webkit.  I'm about to move the
 482         EWS and other queues over to this setup once this lands.
 483
 484         * Scripts/update-webkit:
 485
 486 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
 487
 488         Reviewed by Xan Lopez.
 489
 490         GTK: AX: implement press in DRT
 491         https://bugs.webkit.org/show_bug.cgi?id=36146
 492
 493         Implement AccessibilityUIElement::press() for GTK.
 494
 495         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 496         (AccessibilityUIElement::press): Implemented.
 497
 498 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
 499
 500         Reviewed by Tony Chang.
 501
 502         config.webkit_base_dir returns a path with a trailing slash
 503         https://bugs.webkit.org/show_bug.cgi?id=50197
 504
 505         config.webkit_base_dir() should return a path without a trailing slash,
 506         like all the other methods that return paths.
 507
 508         Undoes MockFileSytem changes by r72640, since they're no longer
 509         necessary for GetBaselinesTest to pass.
 510
 511         * Scripts/webkitpy/common/system/filesystem_mock.py:
 512         * Scripts/webkitpy/layout_tests/port/base.py:
 513         * Scripts/webkitpy/layout_tests/port/config.py:
 514         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
 515
 516 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
 517
 518         Reviewed by Tony Chang.
 519
 520         Rebaseline server: baseline display tweaks
 521         https://bugs.webkit.org/show_bug.cgi?id=50207
 522
 523         Determine which baselines were used when running the tests and highlight
 524         them in the UI. Sort platform names alphabetically.
 525
 526         Also makes the server URL be launched in the user's browser
 527         automatically.
 528
 529         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
 530         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
 531         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
 532         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
 533         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
 534
 535 2010-11-30  Dan Bernstein  <mitz@apple.com>
 536
 537         Reviewed by Anders Carlsson.
 538
 539         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
 540         https://bugs.webkit.org/show_bug.cgi?id=50238
 541
 542         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 543         (WTR::LayoutTestController::findString): Added.
 544         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 545
 546 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
 547
 548         Reviewed by Adam Roben.
 549
 550         All projects on Windows should use cmd files for build events
 551         https://bugs.webkit.org/show_bug.cgi?id=50213
 552
 553         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
 554         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
 555         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
 556         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
 557         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
 558         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
 559         * DumpRenderTree/win/ImageDiffCommon.vsprops:
 560         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
 561         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
 562         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
 563         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
 564         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
 565         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
 566         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
 567         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
 568         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
 569         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
 570         * WebKitAPITest/WebKitAPITestCommon.vsprops:
 571         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
 572         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
 573         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
 574         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
 575         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
 576         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
 577         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
 578         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
 579         * WinLauncher/WinLauncherCommon.vsprops:
 580         * WinLauncher/WinLauncherPostBuild.cmd: Added.
 581         * WinLauncher/WinLauncherPreBuild.cmd: Added.
 582
 583 2010-11-29  Dan Bernstein  <mitz@apple.com>
 584
 585         GTK DumpRenderTree build fix after r72887.
 586
 587         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 588         (LayoutTestController::findString):
 589
 590 2010-11-29  Dan Bernstein  <mitz@apple.com>
 591
 592         Windows DumpRenderTree build fix after r72887.
 593
 594         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 595         (LayoutTestController::findString): Added empty implementation.
 596
 597 2010-11-29  Dan Bernstein  <mitz@apple.com>
 598
 599         Reviewed by Darin Adler.
 600
 601         DumpRenderTree changes for testing the text search API.
 602         https://bugs.webkit.org/show_bug.cgi?id=50038
 603
 604         * DumpRenderTree/LayoutTestController.cpp:
 605         (findStringCallback):
 606         (LayoutTestController::staticFunctions):
 607         * DumpRenderTree/LayoutTestController.h:
 608         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 609         (LayoutTestController::findString):
 610         * MiniBrowser/mac/BrowserWindowController.m:
 611         (-[BrowserWindowController find:]):
 612
 613 2010-11-29  Johnny Ding  <jnd@chromium.org>
 614
 615         Unreviewed: Add myself to the list of Committers.
 616
 617         * Scripts/webkitpy/common/config/committers.py:
 618
 619 2010-11-29  Mark Rowe  <mrowe@apple.com>
 620
 621         Reviewed by Adele Peterson.
 622
 623         <rdar://problem/8694997> DumpRenderTree fails to build.
 624
 625         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
 626
 627 2010-11-29  Mark Rowe  <mrowe@apple.com>
 628
 629         Reviewed by Adele Peterson.
 630
 631         <rdar://problem/8694997> DumpRenderTree fails to build.
 632
 633         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
 634         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
 635         * DumpRenderTree/mac/PerlSupport/Makefile:
 636
 637 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
 638
 639         Reviewed by Martin Robinson.
 640
 641         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
 642         https://bugs.webkit.org/show_bug.cgi?id=50154
 643
 644         Added missing checks to allAttributes().
 645
 646         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 647         (AccessibilityUIElement::allAttributes): Added missing checks.
 648
 649 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 650
 651         Reviewed by Kenneth Rohde Christiansen.
 652
 653         [Qt] Allow pre-generation for package builds for WebKit2
 654         https://bugs.webkit.org/show_bug.cgi?id=50139
 655
 656         Use a build variable for the generated directory path and set the
 657         value based on CONFIG just like for WebKit1.
 658
 659         For non-package builds use a relative base path for the
 660         genrated directory just like for WebKit1.
 661
 662         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 663         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 664
 665 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 666
 667         Reviewed by Kenneth Rohde Christiansen.
 668
 669         [Qt] Move some build logic from Qt to platform independent code
 670         https://bugs.webkit.org/show_bug.cgi?id=50134
 671
 672         Create target directories inside generate-forwarding-headers.pl.
 673
 674         * Scripts/generate-forwarding-headers.pl:
 675
 676 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
 677
 678         Reviewed by Martin Robinson.
 679
 680         [GTK] Windowless plugins gets broken key input
 681         https://bugs.webkit.org/show_bug.cgi?id=49927
 682
 683         Convert the XEvent::keycode to ASCII before printing it. Not
 684         doing this was causing false positive in
 685         plugins/keyboard-events.html.
 686
 687         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 688         (keycode_to_char):
 689         (webkit_test_plugin_handle_event):
 690
 691 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
 692
 693         Reviewed by Antonio Gomes.
 694
 695         [Qt] Html autofocus not working with QGraphicsWebView
 696         https://bugs.webkit.org/show_bug.cgi?id=43169
 697
 698         Tell the scene to set the webview item as the currently
 699         focused item. This makes the input field with autofocus get
 700         focus as it should.
 701
 702         * QtTestBrowser/webview.cpp:
 703         (WebViewGraphicsBased::WebViewGraphicsBased):
 704
 705 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
 706
 707         Reviewed by Tony Chang.
 708
 709         nrwt - clean up create_driver interface and print out the
 710         command line used for DumpRenderTree/TestShell.
 711
 712         This patch adds a driver_cmd_line() call to the Port class in
 713         order to retrive the command line to print it out (as part of
 714         --print config).
 715
 716         In addition, this patch cleans up the Port.create_driver()
 717         signature and the Driver constructor interface to take a worker
 718         number and no longer require the image_path argument (Chromium's
 719         drivers now synthesize the image_path from the worker number
 720         internally).
 721
 722         https://bugs.webkit.org/show_bug.cgi?id=49934
 723
 724         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 725         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 726         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 727         * Scripts/webkitpy/layout_tests/port/base.py:
 728         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 729         * Scripts/webkitpy/layout_tests/port/chromium.py:
 730         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 731         * Scripts/webkitpy/layout_tests/port/dryrun.py:
 732         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 733         * Scripts/webkitpy/layout_tests/port/test.py:
 734         * Scripts/webkitpy/layout_tests/port/webkit.py:
 735         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 736         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 737
 738 2010-11-24  Ojan Vafai  <ojan@chromium.org>
 739
 740         Reviewed by Tony Chang.
 741
 742         [chromium] improve memory usage for test results server and store fewer runs
 743         https://bugs.webkit.org/show_bug.cgi?id=50035
 744
 745         Store fewer runs and don't pass full files around when we only need bools.
 746         Greatly improves error rates on test-results.appspot.com.
 747
 748         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
 749         * TestResultServer/handlers/testfilehandler.py:
 750         * TestResultServer/model/dashboardfile.py:
 751         * TestResultServer/model/jsonresults.py:
 752
 753 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
 754
 755         Reviewed by Tony Chang.
 756
 757         This patch implements the first part of the manager side of the
 758         Broker objects - it handles creating threads, waiting for them
 759         to complete, and running a single-threaded loop as well.
 760
 761         https://bugs.webkit.org/show_bug.cgi?id=49779
 762
 763         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 764         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
 765         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 766         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 767
 768 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
 769
 770         Reviewed by David Levin.
 771
 772         DRT should not generate pixel output for text/plain tests
 773         https://bugs.webkit.org/show_bug.cgi?id=50002
 774
 775         Modify Mac, Windows and GTK DRT implementations to disable pixel output
 776         when encountering a text/plain response (the Chromium one already does
 777         this, and none of the other ports special-case text/plain output in
 778         the first place).
 779
 780         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 781         (dump):
 782         * DumpRenderTree/mac/DumpRenderTree.mm:
 783         (dump):
 784         * DumpRenderTree/win/DumpRenderTree.cpp:
 785         (dump):
 786
 787 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
 788
 789         Unreviewed.
 790
 791         Add my other email address to committers.py.
 792
 793         * Scripts/webkitpy/common/config/committers.py:
 794
 795 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
 796
 797         Reviewed by Csaba Osztrogonác.
 798
 799         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
 800         https://bugs.webkit.org/show_bug.cgi?id=49975
 801
 802         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
 803         to enable the script to define it 0 in case of a minimal build.
 804
 805 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
 806
 807         Reviewed by Xan Lopez.
 808
 809         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
 810         https://bugs.webkit.org/show_bug.cgi?id=49143
 811
 812         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 813         (createWebView): Call the new connectEditingCallbacks function.
 814         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
 815         (dumpNodePath):
 816         (dumpRange):
 817         (insertActionString):
 818         (selectionAffinityString):
 819         (shouldBeginEditing):
 820         (shouldEndEditing):
 821         (shouldInsertNode):
 822         (shouldInsertText):
 823         (shouldDeleteRange):
 824         (shouldShowDeleteInterfaceForElement):
 825         (shouldChangeSelectedRange):
 826         (shouldApplyStyle):
 827         (editingBegan):
 828         (userChangedContents):
 829         (editingEnded):
 830         (selectionChanged):
 831         (connectEditingCallbacks):
 832         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
 833         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
 834
 835 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
 836
 837         Reviewed by Andreas Kling.
 838
 839         [Qt] Make QtTestBrowser remember the selected user agent
 840         https://bugs.webkit.org/show_bug.cgi?id=50021
 841
 842         Set user agent for a new page by using the old page's
 843
 844         * QtTestBrowser/mainwindow.cpp:
 845         (MainWindow::setPage):
 846
 847 2010-11-24 Patrick Gansterer <paroga@webkit.org>
 848
 849         Reviewed by Csaba Osztrogonác.
 850
 851         Remove Bakefile build system files
 852         https://bugs.webkit.org/show_bug.cgi?id=49983
 853
 854         r53757 only removed the content, but not the files.
 855         This patch removes that empty files.
 856
 857         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
 858         * wx/browser/browser.bkl: Removed.
 859         * wx/build-wxwebkit: Removed.
 860
 861 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
 862
 863         Reviewed by Tony Chang.
 864
 865         This patch cleans up the logic used to shard tests into groups a
 866         bit and adds the --worker-model flag to NRWT. The flag is only
 867         used at the moment to control whether to run single-threaded or
 868         not, but eventually will also allow toggling between threads and
 869         processes.
 870
 871         Also add a minor cleanup with _test_is_slow(), which just
 872         eliminates some repetition and gives slightly better encapsulation.
 873
 874         https://bugs.webkit.org/show_bug.cgi?id=49773
 875
 876         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 877         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 878
 879 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
 880
 881         Reviewed by Tony Chang.
 882
 883         Rebaseline server: list current baselines and platforms
 884         https://bugs.webkit.org/show_bug.cgi?id=49991
 885
 886         List existing baselines (with Trac links) for tests.
 887
 888         Add dropdowns for choosing with platform baselines to target (and what
 889         to do with existing ones).
 890
 891         Also fix MockFileSystem.join to behave more like os.path.join (unit
 892         test was ending up with two consecutive slashes in a layout test
 893         path).
 894
 895         * Scripts/webkitpy/common/system/filesystem_mock.py:
 896         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
 897         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
 898         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
 899         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
 900         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
 901         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
 902         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
 903
 904 2010-11-23  Ojan Vafai  <ojan@chromium.org>
 905
 906         Reviewed by Tony Chang.
 907
 908         remove timeout argument to urlopen
 909         https://bugs.webkit.org/show_bug.cgi?id=49995
 910
 911         Apparently the version of python we have on the bots doesn't accept a timeout argument.
 912
 913         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
 914
 915 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
 916
 917         Unreviewed, rolling out r72628.
 918         http://trac.webkit.org/changeset/72628
 919         https://bugs.webkit.org/show_bug.cgi?id=49994
 920
 921         This patch is causing layout-test failtures on GTK Linux
 922         64-bit Debug (Requested by ctguil on #webkit).
 923
 924         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
 925         (AccessibilityUIElement::AccessibilityUIElement):
 926         (AccessibilityUIElement::parentElementCallback):
 927         * DumpRenderTree/chromium/AccessibilityUIElement.h:
 928         * DumpRenderTree/chromium/CppBoundClass.cpp:
 929         * DumpRenderTree/chromium/CppBoundClass.h:
 930
 931 2010-11-22  Ojan Vafai  <ojan@chromium.org>
 932
 933         Reviewed by Tony Chang.
 934
 935         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
 936         https://bugs.webkit.org/show_bug.cgi?id=49944
 937
 938         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
 939
 940 2010-11-23  Chris Guillory  <chris.guillory@google.com>
 941
 942         Reviewed by Dimitri Glazkov.
 943
 944         Include the FrameView widget of a RenderWidget in the accessibility tree.
 945         https://bugs.webkit.org/show_bug.cgi?id=49106
 946
 947         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
 948         (AccessibilityUIElement::AccessibilityUIElement):
 949         (AccessibilityUIElement::parentElementCallback):
 950         (AccessibilityUIElement::isEqualCallback):
 951         * DumpRenderTree/chromium/AccessibilityUIElement.h:
 952         * DumpRenderTree/chromium/CppBoundClass.cpp:
 953         (CppBoundClass::getFromCppVariant):
 954         * DumpRenderTree/chromium/CppBoundClass.h:
 955
 956 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
 957
 958         Reviewed by Kenneth Rohde Christiansen.
 959
 960         [EFL] Add tiled backing store to EWebLauncher
 961         https://bugs.webkit.org/show_bug.cgi?id=45777
 962
 963         Allow EWebLauncher to choose between single and tiled backing store
 964
 965         * EWebLauncher/main.c:
 966         (on_key_down):
 967         (browserCreate):
 968         (main):
 969
 970 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
 971
 972         Reviewed by Tor Arne Vestbø.
 973
 974         [Qt] Review the setUserPermission & friends API
 975         https://bugs.webkit.org/show_bug.cgi?id=46810
 976
 977         Renamed requestPermissionFromUser to featurePermissionRequested
 978         and cancelRequestsForPermission to featurePermissionRequestCanceled.
 979
 980         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 981         (WebCore::WebPage::WebPage):
 982         * QtTestBrowser/webpage.cpp:
 983         (WebPage::WebPage):
 984         (WebPage::featurePermissionRequestCanceled):
 985         * QtTestBrowser/webpage.h:
 986
 987 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
 988
 989         Reviewed by Tor Arne Vestbø.
 990
 991         [Qt] Review the setUserPermission & friends API
 992         https://bugs.webkit.org/show_bug.cgi?id=46810
 993
 994         Rename setUserPermission to setFeaturePermission
 995
 996         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 997         (WebCore::WebPage::requestPermission):
 998         (WebCore::WebPage::permissionSet):
 999         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1000         (LayoutTestController::grantDesktopNotificationPermission):
1001         * QtTestBrowser/webpage.cpp:
1002         (WebPage::requestPermission):
1003
1004 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1005
1006         Reviewed by Tor Arne Vestbø.
1007
1008         [Qt] Review the setUserPermission & friends API
1009         https://bugs.webkit.org/show_bug.cgi?id=46810
1010
1011         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
1012         and GeolocationPermissionDomain to Geolocation.
1013
1014         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1015         (WebCore::WebPage::WebPage):
1016         (WebCore::WebPage::requestPermission):
1017         (WebCore::WebPage::cancelPermission):
1018         (WebCore::WebPage::permissionSet):
1019         (WebCore::DumpRenderTree::geolocationPermissionSet):
1020         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1021         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1022         (LayoutTestController::grantDesktopNotificationPermission):
1023         * QtTestBrowser/webpage.cpp:
1024         (WebPage::WebPage):
1025         (WebPage::requestPermission):
1026         (WebPage::cancelRequestsForPermission):
1027         * QtTestBrowser/webpage.h:
1028
1029 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1030
1031         Reviewed by Tor Arne Vestbø.
1032
1033         [Qt] Review the setUserPermission & friends API
1034         https://bugs.webkit.org/show_bug.cgi?id=46810
1035
1036         Add a ByUser suffix to PermissionGranted/Denied. In the future
1037         we can add PermissionGrantedByDefault.
1038
1039
1040         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1041         (WebCore::WebPage::requestPermission):
1042         (WebCore::WebPage::permissionSet):
1043         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1044         (LayoutTestController::grantDesktopNotificationPermission):
1045         * QtTestBrowser/webpage.cpp:
1046         (WebPage::requestPermission):
1047
1048 2010-11-18  Satish Sampath  <satish@chromium.org>
1049
1050         Reviewed by Jeremy Orlow.
1051
1052         For speech input event, send an event object containing all the recognition results and metadata.
1053         https://bugs.webkit.org/show_bug.cgi?id=49736
1054
1055         Updated DRT by renaming the mock result method on all platforms to the new signature.
1056
1057         * DumpRenderTree/LayoutTestController.cpp:
1058         (addMockSpeechInputResultCallback):
1059         (LayoutTestController::staticFunctions):
1060         * DumpRenderTree/LayoutTestController.h:
1061         * DumpRenderTree/chromium/LayoutTestController.cpp:
1062         (LayoutTestController::LayoutTestController):
1063         (LayoutTestController::addMockSpeechInputResult):
1064         * DumpRenderTree/chromium/LayoutTestController.h:
1065         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1066         (LayoutTestController::addMockSpeechInputResult):
1067         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1068         (LayoutTestController::addMockSpeechInputResult):
1069         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1070         (LayoutTestController::addMockSpeechInputResult):
1071         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1072         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1073         (LayoutTestController::addMockSpeechInputResult):
1074         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1075         (LayoutTestController::addMockSpeechInputResult):
1076
1077 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1078
1079         Reviewed by Tony Chang.
1080
1081         Fix some spacing issues with log messages with
1082         new-run-webkit-tests --verbose.
1083
1084         https://bugs.webkit.org/show_bug.cgi?id=49936
1085
1086         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1087
1088 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1089
1090         Reviewed by Adam Barth.
1091
1092         update scm to work with different remote branches
1093         https://bugs.webkit.org/show_bug.cgi?id=49949
1094
1095         This works if there are multiple svn tracking branches
1096         and/or if the tracking branch is refs/remots/origin/master
1097         instead of refs/remotes/trunk which is the direction we're trying
1098         to head since that makes fetches faster.
1099
1100         * Scripts/webkitpy/common/checkout/scm.py:
1101         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1102
1103 2010-11-22  Hayato Ito  <hayato@chromium.org>
1104
1105         Reviewed by Shinichiro Hamaji.
1106
1107         Ignore reference files which will be used by reftests when collecting
1108         test cases.
1109         https://bugs.webkit.org/show_bug.cgi?id=49835
1110
1111         * Scripts/webkitpy/layout_tests/port/test_files.py:
1112         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1113
1114 2010-11-22  Adam Roben  <aroben@apple.com>
1115
1116         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1117
1118         Apple's Windows build allows placing header files and import libraries for WebKit's
1119         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1120         $WebKitLibrariesDir environment variable. This is both required for production builds and
1121         convenient for Apple-internal developer builds. Apple's production builds also require that
1122         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1123         builds, the files are copied into that directory tree by the
1124         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1125         copying is done by
1126         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1127
1128         This .vsprops copying is problematic in one very important case: when a developer updates
1129         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1130         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1131         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1132         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1133         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1134         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1135
1136         To fix this, we now use normal relative paths to access the .vsprops files in the source
1137         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1138         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1139         unset, so the normal relative paths are used to read the .vsprops files out of the source
1140         tree directly. In production builds, this environment variable is set to a fake directory
1141         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1142         is resolved.
1143
1144         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1145
1146         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1147
1148         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1149         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1150         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1151         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1152         FeatureDefines.vsprops becomes:
1153
1154         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1155
1156         which resolves to:
1157
1158         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1159
1160         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1161         actually exist since they are matched by an equal number of ".." path components.)
1162
1163         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1164         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1165
1166         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1167         updated
1168
1169         Reviewed by Dave Hyatt.
1170
1171         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1172         * DumpRenderTree/win/DumpRenderTree.vcproj:
1173         * DumpRenderTree/win/ImageDiff.vcproj:
1174         * FindSafari/FindSafari.vcproj:
1175         * MiniBrowser/MiniBrowser.vcproj:
1176         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1177         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1178         * WebKitAPITest/WebKitAPITest.vcproj:
1179         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1180         * WebKitTestRunner/win/InjectedBundle.vcproj:
1181         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1182         * WinLauncher/WinLauncher.vcproj:
1183         * record-memory-win/record-memory-win.vcproj:
1184         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1185         files.
1186
1187 2010-11-22  Adam Roben  <aroben@apple.com>
1188
1189         Make it possible to run tests on Windows without Visual Studio or VC++
1190         Express installed
1191
1192         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1193         are not installed. But this function doesn't need to be called when we
1194         already have a build available and are just trying to run the tests.
1195
1196         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1197         because Visual Studio/VC++ Express aren't installed
1198
1199         Reviewed by Dave Hyatt.
1200
1201         * Scripts/webkitdirs.pm:
1202         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1203         it is not needed by this function. Also added a FIXME.
1204
1205         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1206         relying on determineConfigurationForVisualStudio doing it.
1207
1208 2010-11-19  Hayato Ito  <hayato@chromium.org>
1209
1210         Reviewed by Shinichiro Hamaji.
1211
1212         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1213
1214         https://bugs.webkit.org/show_bug.cgi?id=49812
1215
1216         * Scripts/webkitpy/layout_tests/driver_test.py:
1217         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1218         * Scripts/webkitpy/layout_tests/port/base.py:
1219         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1220         * Scripts/webkitpy/layout_tests/port/chromium.py:
1221         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1222         * Scripts/webkitpy/layout_tests/port/test.py:
1223         * Scripts/webkitpy/layout_tests/port/webkit.py:
1224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1225         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1226
1227 2010-11-22  Hayato Ito  <hayato@chromium.org>
1228
1229         Reviewed by Tony Chang.
1230
1231         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1232
1233         https://bugs.webkit.org/show_bug.cgi?id=49924
1234
1235         * Scripts/webkitpy/layout_tests/port/chromium.py:
1236
1237 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1238
1239         Reviewed by Kenneth Rohde Christiansen.
1240
1241         Fix EWebLauncher zoom discretization
1242         https://bugs.webkit.org/show_bug.cgi?id=49810
1243
1244         * EWebLauncher/main.c:
1245         (nearest_zoom_level_get):
1246         (zoom_level_set):
1247         (on_load_finished):
1248         (on_key_down):
1249
1250 2010-11-21  Sam Weinig  <sam@webkit.org>
1251
1252         Rubber-stamped by Dan Bernstein.
1253
1254         Fix ~300 WebKit2 tests by enabling developer extras preference.
1255
1256         * WebKitTestRunner/TestController.cpp:
1257         (WTR::TestController::resetStateToConsistentValues):
1258
1259 2010-11-21  Sam Weinig  <sam@webkit.org>
1260
1261         Reviewed by Dan Bernstein.
1262
1263         Textareas should be resizable by default
1264         https://bugs.webkit.org/show_bug.cgi?id=49892
1265
1266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1267         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1268         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1269         Add preferences test.
1270
1271 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1272
1273         Reviewed by Tony Chang.
1274
1275         Rebaseline server: checksum-only differences and prefetching
1276         https://bugs.webkit.org/show_bug.cgi?id=49841
1277
1278         Add support for image test results where the only difference is in the
1279         checksum.
1280
1281         Add prefetching of the image results from the next test.
1282
1283         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1284         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1285         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1286
1287 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1288
1289         Reviewed by Tony Chang.
1290
1291         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1292
1293         Add the 'worker number' and 'worker name' concepts to the
1294         TestShellThread objects, and move test_types and test_args from
1295         the TestRunner to the TestShellThread.
1296
1297         https://bugs.webkit.org/show_bug.cgi?id=49768
1298
1299         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1300         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1301
1302 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1303
1304         Reviewed by Ojan Vafai.
1305
1306         Do some minor cleanup and bug fixing.
1307
1308         https://bugs.webkit.org/show_bug.cgi?id=49777
1309
1310         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1311         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1312
1313 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1314
1315         Reviewed by Ojan Vafai.
1316
1317         nrwt - config.build_directory() is busted
1318
1319         Fixes a typo that was causing us to usually return the top level
1320         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1321         bug was hidden by test stubs that were too simplistic :(.
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=49815
1324
1325         * Scripts/webkitpy/common/system/executive_mock.py:
1326         * Scripts/webkitpy/layout_tests/port/config.py:
1327         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1328
1329 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1330
1331         Reviewed by Adam Roben.
1332
1333         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1334         https://bugs.webkit.org/show_bug.cgi?id=49819
1335
1336         * DumpRenderTree/DumpRenderTree.sln:
1337         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1338         * DumpRenderTree/win/DumpRenderTree.vcproj:
1339         * DumpRenderTree/win/ImageDiff.vcproj:
1340         * FindSafari/FindSafari.vcproj:
1341         * MiniBrowser/MiniBrowser.vcproj:
1342         * TestWebKitAPI/win/TestWebKitAPI.sln:
1343         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1344         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1345         * WebKitAPITest/WebKitAPITest.vcproj:
1346         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1347         * WebKitTestRunner/win/InjectedBundle.vcproj:
1348         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1349         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1350         * WinLauncher/WinLauncher.vcproj:
1351         * record-memory-win/record-memory-win.vcproj:
1352
1353 2010-11-19  Adam Roben  <aroben@apple.com>
1354
1355         Add some more Windows slaves
1356
1357         This is probably more than we will be using in the immediate future,
1358         but having some extra slave names makes experimenting with different
1359         configurations easier.
1360
1361         Reviewed by Jon Honeycutt.
1362
1363         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1364         Windows slaves and distributed them among the three different Test
1365         builders.
1366
1367 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1368
1369         Reviewed by Ojan Vafai.
1370
1371         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1372         https://bugs.webkit.org/show_bug.cgi?id=49702
1373
1374         Re-landing r72357 with a test fix.
1375
1376         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1377         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1378         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1379
1380 2010-11-19  Avi Drissman  <avi@google.com>
1381
1382         Reviewed by Antonio Gomes.
1383
1384         Complete support for Unix editing mode
1385         https://bugs.webkit.org/show_bug.cgi?id=49757
1386
1387         * DumpRenderTree/LayoutTestController.cpp:
1388         (setEditingBehaviorCallback):
1389         * DumpRenderTree/chromium/LayoutTestController.cpp:
1390         (LayoutTestController::setEditingBehavior):
1391
1392 2010-11-19  Adam Roben  <aroben@apple.com>
1393
1394         Fix run-javascriptcore-tests when there's a space in the path to
1395         testapi
1396
1397         Reviewed by Sam Weinig.
1398
1399         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1400         system() to force it to interpret spaces in the path correctly.
1401
1402 2010-11-19  Adam Roben  <aroben@apple.com>
1403
1404         Update scripts for .exe name changes after r72327
1405
1406         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1407
1408         Reviewed by Sam Weinig.
1409
1410         * Scripts/run-javascriptcore-tests:
1411         (testapiPath):
1412
1413         * Scripts/sunspider-compare-results:
1414         (pathToBuiltJSC):
1415
1416         * Scripts/webkitdirs.pm:
1417         (jscPath):
1418         (safariPath):
1419
1420 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1421
1422         Reviewed by Darin Adler.
1423
1424         Normalize Cairo/CFLite project/solution configuration names
1425         https://bugs.webkit.org/show_bug.cgi?id=49818
1426
1427         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1428         * DumpRenderTree/win/DumpRenderTree.vcproj:
1429         * DumpRenderTree/win/ImageDiff.vcproj:
1430         * MiniBrowser/MiniBrowser.vcproj:
1431         * TestWebKitAPI/win/TestWebKitAPI.sln:
1432         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1433         * WebKitAPITest/WebKitAPITest.vcproj:
1434         * WebKitTestRunner/win/InjectedBundle.vcproj:
1435         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1436         * WinLauncher/WinLauncher.vcproj:
1437         * Scripts/webkitdirs.pm: Updated cairo build configs.
1438
1439 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1440
1441         Reviewed by Adam Roben.
1442
1443         Windows vcproj configuration names should be normalized across projects
1444         https://bugs.webkit.org/show_bug.cgi?id=49776
1445
1446         * DumpRenderTree/DumpRenderTree.sln:
1447         * FindSafari/FindSafari.vcproj:
1448         * TestWebKitAPI/win/TestWebKitAPI.sln:
1449         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1450         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1451         * WebKitAPITest/WebKitAPITest.vcproj:
1452         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1453         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1454         * WebKitTestRunner/WebKitTestRunner.sln:
1455         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1456         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1457         * record-memory-win/record-memory-win.vcproj:
1458
1459 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1460
1461         Build fix - as per DRT-mac, always enabled developer extras,
1462         in win/qt/gtk DRT.
1463
1464         This is necessary to enable rich exception messages to be generated
1465         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1466
1467         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1468         (shouldEnableDeveloperExtras):
1469         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1470         (WebCore::shouldEnableDeveloperExtras):
1471         * DumpRenderTree/win/DumpRenderTree.cpp:
1472         (shouldEnableDeveloperExtras):
1473
1474 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1475
1476         Unreviewed, rolling out r72357.
1477         http://trac.webkit.org/changeset/72357
1478         https://bugs.webkit.org/show_bug.cgi?id=49784
1479
1480         It broke test-webkitpy tests since the patch didn't have the
1481         corresponding test update (Requested by kinuko on #webkit).
1482
1483         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1484         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1485
1486 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
1487
1488         Reviewed by Tony Chang.
1489
1490         Rebaseline server: add rebaseline queue
1491         https://bugs.webkit.org/show_bug.cgi?id=49763
1492
1493         Add a UI queue (a multi-item <select>) where tests to be baselined
1494         can be enqueued (also supports basic removal). A queue is used instead
1495         of immediately doing rebaselines since SCM operations can take a while.
1496         It's better to go through lots of tests quickly to mark them as
1497         needing rebaselining and then batch the SCM operations.
1498
1499         Also adds a simple log where results can be displayed.
1500
1501         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1502         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1503         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1504         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
1505         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1506         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1507
1508 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1509
1510         Reviewed by Oliver Hunt.
1511
1512         Bug 49708 - Stop recompiling functions to regenerate exception info.
1513
1514         Instead only hold info as necessary – keep divot info is the inspector
1515         is enabled, line number info is debugging or profiling, and handler
1516         info for functions with try/catch.
1517
1518         * DumpRenderTree/mac/DumpRenderTree.mm:
1519         (shouldEnableDeveloperExtras):
1520             - always enable the developer tools from DRT, to ensure we
1521               produce rich error messages on JavaScript exceptions.
1522
1523 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1524
1525         Reviewed by Ojan Vafai.
1526
1527         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1528         https://bugs.webkit.org/show_bug.cgi?id=49702
1529
1530         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1531         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1532
1533 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1534
1535         Reviewed by Tony Chang.
1536
1537         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1538
1539         Create the first version of the 'message_broker' package. This
1540         class will encapsulate all of the threading/multiprocessing and
1541         message-sending details for the communication between the
1542         'manager' object and the 'worker' objects. For the moment, it
1543         just holds some routines and tests for logging thread stacks.
1544
1545         There should be no functional changes in this patch, just moving stuff
1546         around.
1547
1548         https://bugs.webkit.org/show_bug.cgi?id=49707
1549
1550         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1551         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1552         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1553         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1554         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1555         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1556
1557 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1558
1559         Reviewed by Adam Roben.
1560
1561         Remove leftover Windows Debug_Internal configurations
1562         https://bugs.webkit.org/show_bug.cgi?id=49758
1563
1564         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1565         * DumpRenderTree/win/DumpRenderTree.vcproj:
1566         * DumpRenderTree/win/ImageDiff.vcproj:
1567         * MiniBrowser/MiniBrowser.vcproj:
1568         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1569         * WebKitAPITest/WebKitAPITest.vcproj:
1570         * WebKitTestRunner/win/InjectedBundle.vcproj:
1571         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1572         * WinLauncher/WinLauncher.vcproj:
1573
1574 2010-11-18  Adam Roben  <aroben@apple.com>
1575
1576         Add three new Windows XP build slaves
1577
1578         Reviewed by Steve Falkenburg.
1579
1580         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1581         new slaves, and added them to the Windows XP Debug (Tests) builder.
1582
1583 2010-11-18  Daniel Bates  <dbates@rim.com>
1584
1585         Reviewed by Adam Roben.
1586
1587         update-webkit-support-libs should fall back to existing
1588         WebKitSupportLibrary version if there is no internet connectivity
1589         https://bugs.webkit.org/show_bug.cgi?id=49503
1590
1591         Fall back to existing support libraries (if present) when there is
1592         no internet connection.
1593
1594         Currently, update-webkit-support-libs dies with an "out-of-date"
1595         error when there is no internet connection because it cannot
1596         retrieve versioning information from developer.apple.com. Because
1597         update-webkit-support-libs fails, build-webkit fails. Instead,
1598         if there is no internet connection and the support libraries are
1599         present then we should warn the user and exit() with success so
1600         that build-webkit can work without an internet connection.
1601
1602         * Scripts/update-webkit-support-libs:
1603
1604 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1605
1606         Reviewed by Adam Roben.
1607
1608         Debug_Internal Windows configuration is unnecessary, should be removed
1609         https://bugs.webkit.org/show_bug.cgi?id=49753
1610
1611         * DumpRenderTree/win/DumpRenderTree.cpp:
1612         * MiniBrowser/win/stdafx.h:
1613         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1614         * WebKitTestRunner/win/TestControllerWin.cpp:
1615
1616 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1617
1618         Reviewed by Adam Roben.
1619
1620         Clean up vcproj errors
1621         https://bugs.webkit.org/show_bug.cgi?id=49741
1622
1623         * MiniBrowser/MiniBrowser.vcproj:
1624         * WebKitAPITest/WebKitAPITest.vcproj:
1625         * WebKitTestRunner/win/InjectedBundle.vcproj:
1626         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1627
1628 2010-11-18  Hayato Ito  <hayato@chromium.org>
1629
1630         Reviewed by Shinichiro Hamaji.
1631
1632         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1633         which is caused by r72249.
1634
1635         https://bugs.webkit.org/show_bug.cgi?id=49751
1636
1637         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1638
1639 2010-11-18  Adam Roben  <aroben@apple.com>
1640
1641         Implement layoutTestController.waitForPolicyDelegate on Windows
1642
1643         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1644
1645         Reviewed by Simon Fraser.
1646
1647         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1648         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1649         code from LayoutTestControllerMac.mm.
1650
1651 2010-11-18  Hayato Ito  <hayato@chromium.org>
1652
1653         Reviewed by Shinichiro Hamaji.
1654
1655         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1656
1657         https://bugs.webkit.org/show_bug.cgi?id=49740
1658
1659         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1660
1661 2010-11-18  Tony Chang  <tony@chromium.org>
1662
1663         Reviewed by Adam Barth.
1664
1665         run platform/chromium/plugins/refcount-leaks.html on all platforms
1666         https://bugs.webkit.org/show_bug.cgi?id=49485
1667
1668         Add PluginObject.testObjectCount which returns the number of allocated
1669         TestObjects. Add PluginObject.testCreateTestObject which allocates
1670         and returns a TestObject.
1671
1672         Add TestObject.refCount which returns the number of refs on the
1673         TestObject.
1674
1675         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1676         (pluginGetProperty):
1677         (pluginInvoke):
1678         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1679         (getTestObjectCount):
1680         (testAllocate):
1681         (testDeallocate):
1682         (testGetProperty):
1683         (testScriptObjectInvoke): Release a ref to a plugin object that was
1684             previously leaked.
1685         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1686
1687 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1688
1689         Reviewed by Adam Roben.
1690
1691         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1692         https://bugs.webkit.org/show_bug.cgi?id=49711
1693
1694         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1695         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1696         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1697         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1698         * record-memory-win/record-memory-win-common.vsprops: Added.
1699         * record-memory-win/record-memory-win.vcproj:
1700
1701 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1702
1703         Reviewed by Csaba Osztrogonác.
1704
1705         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1706
1707         * MiniBrowser/qt/BrowserWindow.cpp:
1708         (BrowserWindow::updateUserAgentList):
1709
1710 2010-11-17  Adam Roben  <aroben@apple.com>
1711
1712         Don't trigger Windows builds when chromium-win test results change
1713
1714         Reviewed by Mark Rowe.
1715
1716         * Scripts/webkitpy/common/config/build.py:
1717         (_should_file_trigger_build): Changed the regular expression used to
1718         search for directory names to only consider full directory names,
1719         rather than matching directory names where the string we care about is
1720         a suffix of the name.
1721
1722         * Scripts/webkitpy/common/config/build_unittest.py:
1723         (ShouldBuildTest): Added a test.
1724
1725 2010-11-17  Hayato Ito  <hayato@chromium.org>
1726
1727         Reviewed by Shinichiro Hamaji.
1728
1729         Remove a uri member from TestInput class.
1730
1731         https://bugs.webkit.org/show_bug.cgi?id=49691
1732
1733         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1734         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1735
1736 2010-11-17  Adam Roben  <aroben@apple.com>
1737
1738         Move FindSafari's settings into a vsprops file
1739
1740         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1741
1742         Reviewed by Steve Falkenburg.
1743
1744         * FindSafari/FindSafari.vcproj:
1745         * FindSafari/FindSafariCommon.vsprops: Added.
1746
1747 2010-11-17  Adam Roben  <aroben@apple.com>
1748
1749         Use a minimum font size of 0 in DRT on Windows
1750
1751         This is the Windows equivalent of r72164.
1752
1753         Rubber-stamped by Dave Hyatt.
1754
1755         * DumpRenderTree/win/DumpRenderTree.cpp:
1756         (resetDefaultsToConsistentValues):
1757
1758 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1759
1760         Reviewed by Andreas Kling.
1761
1762         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1763         https://bugs.webkit.org/show_bug.cgi?id=49639
1764
1765         * Scripts/webkitpy/common/checkout/scm.py:
1766
1767 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1768
1769         Reviewed by Tony Chang.
1770
1771         Rebaseline server: add loupe for image diffs
1772         https://bugs.webkit.org/show_bug.cgi?id=49692
1773
1774         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1775         enlarged area of the expected, actual and diff images side by side.
1776
1777         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1778         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1779         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1780         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1781
1782 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1783
1784         Reviewed by Adam Roben.
1785
1786         WebKitLauncherWin should use vsprops for shared build settings
1787         https://bugs.webkit.org/show_bug.cgi?id=49696
1788
1789         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1790         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1791
1792 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1793
1794         Reviewed by Adam Roben.
1795
1796         WinLauncher should use vsprops for shared build settings
1797         https://bugs.webkit.org/show_bug.cgi?id=49695
1798
1799         * WinLauncher/WinLauncher.cpp:
1800         (_tWinMain):
1801         (PrintView):
1802         (WndProc):
1803         (MyEditProc):
1804         * WinLauncher/WinLauncher.vcproj:
1805         * WinLauncher/WinLauncherCommon.vsprops: Added.
1806
1807 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1808
1809         Delete unused file unintentionally added in last change.
1810
1811         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1812
1813 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1814
1815         Reviewed by Adam Roben.
1816
1817         DumpRenderTree on Windows should use a vsprops file for shared project settings
1818         https://bugs.webkit.org/show_bug.cgi?id=49690
1819
1820         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1821         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1822         * DumpRenderTree/win/DumpRenderTree.vcproj:
1823         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1824         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1825         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1826         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1827         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1828         * DumpRenderTree/win/ImageDiff.vcproj:
1829         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1830
1831 2010-11-17  Hayato Ito  <hayato@chromium.org>
1832
1833         Refactor TestTypeBase.compare_output().
1834
1835         Introduce a TestOutput class and update compare_output() of each test
1836         types so that they can take both actual and expected TestOutput objects.
1837
1838         https://bugs.webkit.org/show_bug.cgi?id=49431
1839
1840         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1841         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1842         * Scripts/webkitpy/layout_tests/port/base.py:
1843         * Scripts/webkitpy/layout_tests/port/chromium.py:
1844         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1845         * Scripts/webkitpy/layout_tests/port/test.py:
1846         * Scripts/webkitpy/layout_tests/port/webkit.py:
1847         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1848         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1849         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1850         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1851
1852 2010-11-17  Adam Roben  <aroben@apple.com>
1853
1854         Make each Windows Test builder use the same OS for all its slaves
1855
1856         Currently each WebKit1 Windows Test builder has one Windows XP slave
1857         and one Windows 7 slave. Having different OSes in a single builder
1858         meant that the builders would alternate between red and green when
1859         there were OS-specific failures.
1860
1861         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1862         between red and green because of multiple OS versions
1863
1864         Reviewed by Mark Rowe.
1865
1866         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1867         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1868         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1869         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1870         builders for the two WebKit1 builders so that they would all use the
1871         appropriate OS.
1872
1873 2010-11-17  James Robinson  <jamesr@chromium.org>
1874
1875         Reviewed by Dan Bernstein.
1876
1877         [chromium] Set minimum font size to 0 for DRT
1878         https://bugs.webkit.org/show_bug.cgi?id=49677
1879
1880         Followup for http://trac.webkit.org/changeset/72141.
1881
1882         Test: http/tests/misc/acid3.html
1883
1884         * DumpRenderTree/chromium/WebPreferences.cpp:
1885         (WebPreferences::reset):
1886
1887 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1888
1889         Unreviewed build fix.
1890
1891         [Qt] Add missing file I forgot in r72220.
1892
1893         * MiniBrowser/MiniBrowser.qrc: Added.
1894
1895 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1896
1897         Reviewed by Andreas Kling.
1898
1899         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1900         https://bugs.webkit.org/show_bug.cgi?id=49627
1901
1902         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1903
1904         * MiniBrowser/MiniBrowser.qrc: Added.
1905         Add it here to prevent qmake from detecting it
1906         since it needs to be copied to the build directory.
1907         * MiniBrowser/qt/BrowserWindow.cpp:
1908         (BrowserWindow::BrowserWindow):
1909         (BrowserWindow::updateUserAgentList):
1910         (BrowserWindow::showUserAgentDialog):
1911         * MiniBrowser/qt/BrowserWindow.h:
1912         * MiniBrowser/qt/MiniBrowser.pro:
1913
1914 2010-11-17  Adam Roben  <aroben@apple.com>
1915
1916         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1917
1918         We use that file on Windows!
1919
1920         Fixes <http://webkit.org/b/49643> Changes to
1921         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1922
1923         Reviewed by Steve Falkenburg.
1924
1925         * Scripts/webkitpy/common/config/build.py:
1926         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1927         trigger builds on SnowLeopard and Windows.
1928
1929         * Scripts/webkitpy/common/config/build_unittest.py:
1930         (ShouldBuildTest.test_should_build): Added a test.
1931
1932 2010-11-17  Satish Sampath  <satish@chromium.org>
1933
1934         Reviewed by Jeremy Orlow.
1935
1936         Clear the speech input mock explicitly before each test.
1937         https://bugs.webkit.org/show_bug.cgi?id=49660
1938
1939         * DumpRenderTree/chromium/LayoutTestController.cpp:
1940         (LayoutTestController::setMockSpeechInputResult):
1941         * DumpRenderTree/chromium/LayoutTestController.h:
1942         * DumpRenderTree/chromium/WebViewHost.cpp:
1943         (WebViewHost::speechInputController):
1944         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1945         * DumpRenderTree/chromium/WebViewHost.h:
1946         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1947
1948 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1949
1950         Unreviewed, specify IRC nickname in committers.py.
1951
1952         * Scripts/webkitpy/common/config/committers.py:
1953
1954 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1955
1956         Reviewed by Tony Chang.
1957
1958         [NRWT] Make http locking similar to perl implementation
1959         https://bugs.webkit.org/show_bug.cgi?id=49187
1960
1961         * Scripts/webkitpy/common/system/file_lock.py: Added.
1962         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1963         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1964
1965 2010-11-17  MORITA Hajime  <morrita@google.com>
1966
1967         Reviewed by Kent Tamura.
1968
1969         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1970         https://bugs.webkit.org/show_bug.cgi?id=49366
1971
1972         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1973           according to the spellchecker suggestion
1974         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1975
1976         test_expectations.txt will be changed after this change is ported to test_shell.
1977
1978         * DumpRenderTree/chromium/EventSender.cpp:
1979         (makeMenuItemStringsFor):
1980         (EventSender::contextClick):
1981         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1982         (MockSpellCheck::fillSuggestionList):
1983         (MockSpellCheck::initializeIfNeeded):
1984         * DumpRenderTree/chromium/MockSpellCheck.h:
1985         * DumpRenderTree/chromium/WebViewHost.cpp:
1986         (WebViewHost::mockSpellCheck):
1987         * DumpRenderTree/chromium/WebViewHost.h:
1988
1989 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1990
1991         Reviewed by Sam Weinig.
1992
1993         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1994         since the bots have 1 stuck in their plist otherwise.
1995
1996         * DumpRenderTree/mac/DumpRenderTree.mm:
1997         (resetDefaultsToConsistentValues):
1998
1999 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2000
2001         Reviewed by Tony Chang.
2002
2003         Rebaseline server: compute diffs client-side
2004         https://bugs.webkit.org/show_bug.cgi?id=49640
2005
2006         The image diff output from the DRT is pretty bad on some ports (at
2007         least the Mac one), so it's better to compute diffs on the client by
2008         using <canvas>.
2009
2010         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2011         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2012         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2013
2014 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2015
2016         Reviewed by Tony Chang.
2017
2018         Rebaseline server: display test results
2019         https://bugs.webkit.org/show_bug.cgi?id=49626
2020
2021         Adds basic result display to the rebaseline server. On the Python side
2022         this involves:
2023         - Parsing the unexpected_results.json into a dictionary.
2024         - Serving it as JSON under /results.json.
2025         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
2026         but I'll need to have access to the parsed results on the Python side
2027         for follow-up changes).
2028
2029         On the web UI side this adds:
2030         - Markup for display image and text results (expected, actual, diff),
2031           and JS for populating it.
2032         - Markup for breaking down test results by failure type and directory,
2033           and JS for populating it.
2034
2035         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2036         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2037         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2038         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
2039         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2040
2041 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2042
2043         Reviewed by Ojan Vafai.
2044
2045         See Chromium issue http://codereview.chromium.org/5133001/ - we
2046         are modifying the build bots to pass in the builder name with
2047         the "GPU" string appended instead of appending it in the code.
2048
2049         https://bugs.webkit.org/show_bug.cgi?id=49636
2050
2051         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2052
2053 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
2054
2055         Reviewed by Adam Roben.
2056
2057         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2058         https://bugs.webkit.org/show_bug.cgi?id=49632
2059
2060         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2061         * DumpRenderTree/win/DumpRenderTree.vcproj:
2062         * DumpRenderTree/win/ImageDiff.vcproj:
2063         * MiniBrowser/MiniBrowser.vcproj:
2064         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2065         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2066         * WebKitTestRunner/win/InjectedBundle.vcproj:
2067         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2068         * WinLauncher/WinLauncher.vcproj:
2069         * record-memory-win/record-memory-win.vcproj:
2070
2071 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2072
2073         Reviewed by Ojan Vafai.
2074
2075         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2076
2077         Rename the TestInfo class to TestInput to be clearer about its
2078         function, and move the checksum-reading code into dump_render_tree_thread
2079         to avoid cross-thread access.
2080
2081         https://bugs.webkit.org/show_bug.cgi?id=49573
2082
2083         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2084         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2085         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2086
2087 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2088
2089         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2090
2091         * DumpRenderTree/mac/DumpRenderTree.mm:
2092         (resetDefaultsToConsistentValues):
2093
2094 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2095
2096         Reviewed by Geoff Garen.
2097
2098         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2099
2100         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock
2101         for every WebView, and the WebKit API doesn't support that ownership model.
2102
2103         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2104
2105         * DumpRenderTree/mac/DumpRenderTree.mm:
2106         (createWebViewAndOffscreenWindow):
2107         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2108         (LayoutTestController::setMockDeviceOrientation):
2109
2110 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2111
2112         Reviewed by Ojan Vafai.
2113
2114         new-run-webkit-tests: log the process id in --verbose mode
2115
2116         As part of the switch to multi-process mode, we should log the
2117         process id when running w/ --verbose.
2118
2119         https://bugs.webkit.org/show_bug.cgi?id=49571
2120
2121         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2122
2123 2010-11-16  Adam Roben  <aroben@apple.com>
2124
2125         Only trigger Windows builds when files that we actually use on Windows
2126         are changed
2127
2128         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2129         It uses the new webkitpy.common.config.build module to determine
2130         whether a particular change should trigger a build on a particular
2131         platform. The Windows builders have been switched to use a
2132         PlatformSpecificScheduler.
2133
2134         The logic to determine whether or not a particular change should
2135         trigger a build on a given platform has only been implemented/tested
2136         for Windows. I tried to make it easy to add more platforms in the
2137         future, but I don't have enough familiarity with all platforms to be
2138         able to implement it for them.
2139
2140         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2141         lots irrelevant changes (e.g., rebaselining Chromium test results)
2142
2143         Reviewed by Eric Seidel.
2144
2145         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2146         PlatformSpecificScheduler for the Windows builders.
2147
2148         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2149         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2150         up a ChangeFilter that filters to our branch and will call through to
2151         our filter method, and calls up to our base class.
2152         (PlatformSpecificScheduler.filter): Calls through to
2153         build.should_build to find out whether we should trigger a build for
2154         this change.
2155
2156         * Scripts/webkitpy/common/net/build.py: Added.
2157         (_should_file_trigger_build): Uses a set of directories and regexp
2158         patterns to determine whether the given file should trigger a build on
2159         the given platform. As mentioned earlier, this has only been
2160         implemented for Windows, though I did try to make some guesses about
2161         other platforms.
2162         (should_build): Returns true if any of the files should trigger a
2163         build on the given platform.
2164
2165         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2166         (ShouldBuildTest.test_should_build): Does some basic testing to make
2167         sure we're triggering builds for the right files. It only tests
2168         Windows for now, though I tried to make some guesses about other
2169         platforms.
2170
2171 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2172
2173         Reviewed by Andreas Kling.
2174
2175         [Qt] Remove synchronous QWebPage::checkPermissions signal
2176         https://bugs.webkit.org/show_bug.cgi?id=46810
2177
2178         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2179         (WebCore::WebPage::WebPage):
2180         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2181         (LayoutTestController::grantDesktopNotificationPermission): When granting
2182         permission, grant it directly on the QWebPage/Frame, that will remember it.
2183         * QtTestBrowser/webpage.cpp:
2184         (WebPage::WebPage):
2185         * QtTestBrowser/webpage.h:
2186
2187
2188 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2189
2190         Reviewed by Csaba Osztrogonác.
2191
2192         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2193
2194         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2195         (LayoutTestController::reset):
2196         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2197         (LayoutTestController::isPrinting):
2198         (LayoutTestController::setPrinting):
2199
2200 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2201
2202         Reviewed by Andreas Kling.
2203
2204         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2205         https://bugs.webkit.org/show_bug.cgi?id=49587
2206
2207         * MiniBrowser/qt/BrowserView.cpp:
2208         (BrowserView::BrowserView): Added BackingStoreType
2209         argument to ctor. Propagating it to the QGraphicsWKView.
2210         * MiniBrowser/qt/BrowserView.h:
2211         * MiniBrowser/qt/BrowserWindow.cpp:
2212         (BrowserWindow::BrowserWindow):
2213         (BrowserWindow::newWindow): Create the new BrowserWindow
2214         with the same BackingStoreType that this instance has.
2215         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2216         * MiniBrowser/qt/main.cpp:
2217         (main): Use tiled backing store if got -tiled command line argument.
2218         Avoid redundant copy of command line args.
2219
2220 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2221
2222         Reviewed by Jeremy Orlow.
2223
2224         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2225         https://bugs.webkit.org/show_bug.cgi?id=48506
2226
2227         This ensures that there is one mock per page WebView / WebViewHost. This is a
2228         design constraint of the DeviceOrientationClientMock because the m_controller
2229         field can only store a pointer to a single instance of the corresponding
2230         DeviceOrientationController.
2231
2232         Test: fast/dom/DeviceOrientation/no-page-cache.html
2233
2234         * DumpRenderTree/chromium/LayoutTestController.cpp:
2235         (LayoutTestController::setMockDeviceOrientation):
2236         (LayoutTestController::deviceOrientationClientMock):
2237         * DumpRenderTree/chromium/LayoutTestController.h:
2238         * DumpRenderTree/chromium/WebViewHost.cpp:
2239         (WebViewHost::deviceOrientationClientMock):
2240         (WebViewHost::deviceOrientationClient):
2241         (WebViewHost::reset):
2242         * DumpRenderTree/chromium/WebViewHost.h:
2243
2244 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2245
2246         Reviewed by Andreas Kling.
2247
2248         [Qt][WK2] Avoid polling in WebKitTestRunner.
2249         https://bugs.webkit.org/show_bug.cgi?id=49542
2250
2251         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2252         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2253
2254         * WebKitTestRunner/TestController.cpp:
2255         (WTR::TestController::didFinishLoadForFrame):
2256         * WebKitTestRunner/TestController.h:
2257         * WebKitTestRunner/TestInvocation.cpp:
2258         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2259         * WebKitTestRunner/mac/TestControllerMac.mm:
2260         (WTR::TestController::notifyDone): Add method stub.
2261         * WebKitTestRunner/qt/TestControllerQt.cpp:
2262         (WTR::TestControllerRunLoop::instance):
2263         (WTR::TestControllerRunLoop::start):
2264         (WTR::TestControllerRunLoop::stop):
2265         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2266         (WTR::TestControllerRunLoop::timerEvent):
2267         (WTR::TestController::notifyDone):
2268         (WTR::TestController::platformRunUntil):
2269         * WebKitTestRunner/win/TestControllerWin.cpp:
2270         (WTR::TestController::notifyDone): Add method stub.
2271
2272 2010-11-15  Darin Adler  <darin@apple.com>
2273
2274         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2275
2276 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2277
2278         Reviewed by Andreas Kling.
2279
2280         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2281         https://bugs.webkit.org/show_bug.cgi?id=49544
2282
2283         Add the shortcut to BrowserWindow.
2284
2285         * MiniBrowser/qt/BrowserWindow.cpp:
2286         (BrowserWindow::BrowserWindow):
2287         (BrowserWindow::openLocation):
2288         * MiniBrowser/qt/BrowserWindow.h:
2289
2290 2010-11-14  David Levin  <levin@chromium.org>
2291
2292         Reviewed by Daniel Bates.
2293
2294         check-webkit-style should detect PassRefPtr usage in functions.
2295         https://bugs.webkit.org/show_bug.cgi?id=49513
2296
2297         * Scripts/webkitpy/style/checkers/cpp.py:
2298         (check_for_function_lengths): Revert a comment change that I
2299          accidentally made in r71986.
2300         (check_pass_ptr_usage): Added the code to do the check.
2301         (process_line): Added the call to check_pass_ptr_usage.
2302         (CppChecker): Added the new error category.
2303         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2304         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2305          testing purposes.
2306         (PassPtrTest::*): The class/functions to unit test the new
2307          functionality.
2308
2309 2010-11-14  David Levin  <levin@chromium.org>
2310
2311         Reviewed by Shinichiro Hamaji.
2312
2313         check-webkit-style function detection and the line count style checks should be separate.
2314         https://bugs.webkit.org/show_bug.cgi?id=49512
2315
2316         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2317         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2318           call the detection function and fix line counts in two places now that
2319           the code really only counts the lines in the body of the function.
2320
2321 2010-11-14  Andreas Kling  <kling@webkit.org>
2322
2323         Reviewed by Antonio Gomes.
2324
2325         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2326         https://bugs.webkit.org/show_bug.cgi?id=33438
2327
2328         Stifle "Unhandled variable" warning to match what the other
2329         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2330         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2331
2332         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2333         (webkit_test_plugin_get_value):
2334
2335 2010-11-13  David Levin  <levin@chromium.org>
2336
2337         Reviewed by Eric Seidel.
2338
2339         check-webkit-style function detection crashes on functions in templates.
2340         https://bugs.webkit.org/show_bug.cgi?id=49504
2341
2342         For example "template <bool shouldClose(const Element*)>".
2343
2344         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2345         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2346           function detection test to expose this issue.
2347
2348 2010-11-12  David Levin  <levin@chromium.org>
2349
2350         Reviewed by Shinichiro Hamaji.
2351
2352         check-webkit-style function detection doesn't detect indented functions declaractions.
2353         https://bugs.webkit.org/show_bug.cgi?id=49446
2354
2355         Indented function declarations occur inside class definitions, so
2356         they are a pretty common (and worth detecting).
2357
2358         * Scripts/webkitpy/style/checkers/cpp.py:
2359           Changed regex to allow indentation.
2360           Changed the function start detection to only happen when not in a
2361           function.
2362           Changed function end detection to work based on matching braces
2363           instead of finding a close brace at the beginning of the line.
2364           Fixed close_expression to do what it says when it doesn't find
2365           the close.
2366         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2367
2368 2010-11-12  Daniel Bates  <dbates@rim.com>
2369
2370         Rubber-stamped by Nikolas Zimmermann.
2371
2372         Make do-file-rename rename files in the directory WebKit2.
2373
2374         This also makes the list of searched directories in do-file-rename
2375         consistent with the list of searched directories in the script do-webcore-rename.
2376
2377         * Scripts/do-file-rename:
2378
2379 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2380
2381         Reviewed by James Robinson.
2382
2383         Attempt yet again to land the fix for bug 49360 (respecting
2384         set-webkit-configuration). We need to handle the cases where
2385         trying to run webkit-build-directory to find out where the
2386         default configuration might be fails (that shows up on some
2387         Chromium bots that apparently don't have perl installed).
2388
2389         https://bugs.webkit.org/show_bug.cgi?id=49360
2390
2391         * Scripts/webkitpy/layout_tests/port/config.py:
2392         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2393         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2394
2395 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2396
2397         Reviewed by Adam Barth.
2398
2399         webkit-patch land logs commit message twice
2400         https://bugs.webkit.org/show_bug.cgi?id=49482
2401
2402         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2403         that's just the commit message, which we now output following the
2404         actual commit.
2405
2406         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2407
2408 2010-11-12  Tony Chang  <tony@chromium.org>
2409
2410         Reviewed by Adam Barth.
2411
2412         run platform/chromium/plugins/script-object-invoke.html on all platforms
2413         https://bugs.webkit.org/show_bug.cgi?id=49280
2414
2415         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2416         (testScriptObjectInvoke):
2417         (pluginInvoke):
2418
2419 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2420
2421         Reviewed by Adam Barth.
2422
2423         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2424         https://bugs.webkit.org/show_bug.cgi?id=49471
2425
2426         Right now there's no indication of a successful commit.
2427
2428         * Scripts/webkitpy/tool/commands/download_unittest.py:
2429         * Scripts/webkitpy/tool/steps/commit.py:
2430
2431 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2432
2433         Reviewed by Ojan Vafai.
2434
2435         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2436         https://bugs.webkit.org/show_bug.cgi?id=49354
2437
2438         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2439
2440         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2441         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2442         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2443         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2444
2445 2010-11-12  Tony Chang  <tony@chromium.org>
2446
2447         Reviewed by Kent Tamura.
2448
2449         [chromium] Load a blank page when closing DRT WebViewHosts
2450         https://bugs.webkit.org/show_bug.cgi?id=49417
2451
2452         In test_shell, when we close a window, we first load about:blank
2453         and run GC to fire the destruction logic of the page.  In test_shell,
2454         this happens in ~TestShell.  In DRT, we manage virtual windows as
2455         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2456
2457         Managing focus is a bit trickier, since normally you would get window
2458         events to reset the focus to the right window.  We do it manually
2459         instead.
2460
2461         This fixes 2 plugin tests on DRT.
2462
2463         * DumpRenderTree/chromium/TestShell.cpp:
2464         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2465         (TestShell::closeWindow): Move widget close() to WVH destructor and
2466             manage focus manually.
2467         (TestShell::closeRemainingWindows): Comment typo.
2468         * DumpRenderTree/chromium/WebViewHost.cpp:
2469         (WebViewHost::closeWidget):
2470         (invokeCloseWidget):
2471         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2472             test_shell).
2473         (WebViewHost::~WebViewHost):
2474         * DumpRenderTree/chromium/WebViewHost.h:
2475
2476 2010-11-12  David Levin  <levin@chromium.org>
2477
2478         Reviewed by Adam Barth.
2479
2480         cpp.py needs some tidying.
2481         https://bugs.webkit.org/show_bug.cgi?id=49443
2482
2483         * Scripts/webkitpy/style/checkers/cpp.py:
2484           Fix parameter ordering for iteratively_replace_matches_with_char
2485           to mirror other similar functions (and improved comments, etc.)
2486           Also, use a python-ism (for/else) to get rid of a variable that
2487           was there to determine if something had been found in the loop.
2488
2489 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
2490
2491         Reviewed by James Robinson.
2492
2493         [Chromium/DRT] Make EventSendingController send complete touch events.
2494         https://bugs.webkit.org/show_bug.cgi?id=49285
2495
2496         * DumpRenderTree/chromium/EventSender.cpp:
2497         (EventSender::addTouchPoint):
2498         (EventSender::updateTouchPoint):
2499         (EventSender::sendCurrentTouchEvent):
2500
2501 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2502
2503         Unreviewed rollout of r71858.
2504
2505         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
2506         NaCl tests.
2507
2508         * Scripts/webkitpy/layout_tests/port/config.py:
2509         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
2510         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2511
2512 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
2513
2514         Reviewed by Kenneth Rohde Christiansen.
2515
2516         [Qt] TestController::runUntil doesn't honor the timeout parameter
2517         https://bugs.webkit.org/show_bug.cgi?id=48941
2518
2519         Implement the missing timeout of WebKitTestRunner for Qt.
2520
2521         A QElapsedTimer has been added to RunUntilConditionLoop in order
2522         to measure how long the loop has been running. When the timer
2523         is bigger or equal than the timeout, the loop ends even if the
2524         condition is not met.
2525
2526         * WebKitTestRunner/qt/TestControllerQt.cpp:
2527         (WTR::RunUntilConditionLoop::start):
2528         (WTR::RunUntilConditionLoop::run):
2529         (WTR::RunUntilConditionLoop::timerEvent):
2530         (WTR::TestController::platformRunUntil):
2531
2532 2010-11-11  David Levin  <levin@chromium.org>
2533
2534         Reviewed by Shinichiro Hamaji.
2535
2536         check-webkit-style function detection doesn't handle templates with spaces.
2537         https://bugs.webkit.org/show_bug.cgi?id=49427
2538
2539         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2540           finding the function name.
2541         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2542           template with a space.
2543
2544 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2545
2546         Reviewed by Shinichiro Hamaji.
2547
2548         Enable check-webkit-style on Qt files
2549         https://bugs.webkit.org/show_bug.cgi?id=48322
2550
2551         Adding exception for _q_... private slots and
2552         ..._data() methods in tests
2553
2554         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2555         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2556
2557 2010-11-11  David Levin  <levin@chromium.org>
2558
2559         Reviewed by Shinichiro Hamaji.
2560
2561         check-webkit-style function detection doesn't work for templates and destructors.
2562         https://bugs.webkit.org/show_bug.cgi?id=49425
2563
2564         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2565         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2566
2567 2010-11-11  Joone Hur  <joone@kldp.org>
2568
2569         Reviewed by Antonio Gomes.
2570
2571         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2572         https://bugs.webkit.org/show_bug.cgi?id=46598
2573
2574         Support nodesFromRect in DRT
2575
2576         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2577         (LayoutTestController::nodesFromRect):
2578
2579 2010-11-11  MORITA Hajime  <morrita@google.com>
2580
2581         Reviewed by Kent Tamura.
2582
2583         editing/selection/context-menu-on-text.html fails on chromium
2584         https://bugs.webkit.org/show_bug.cgi?id=45898
2585
2586         Enhance Chromium's EventSender::contextClick() to return
2587         array of menu strings. The implementation incomplete because
2588         Although actual context menu is implemented by the browser,
2589         it reflects editability of underlying context thus makes
2590         context-menu-on-text.html passed.
2591
2592         * DumpRenderTree/chromium/EventSender.cpp:
2593         (makeMenuItemStringsFor): Added.
2594         (EventSender::contextClick): Now returns array of menu strings.
2595         * DumpRenderTree/chromium/WebViewHost.cpp:
2596         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2597         (WebViewHost::clearContextMenuData): Added.
2598         (WebViewHost::lastContextMenuData): Added.
2599         * DumpRenderTree/chromium/WebViewHost.h:
2600
2601 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2602
2603         Unreviewed, build fix.
2604
2605         fix build breakage caused by fix for bug 49380 (r71858).
2606
2607         config_standalone needs to ensure that the packages it needs are
2608         in sys.path.
2609
2610         https://bugs.webkit.org/show_bug.cgi?id=49419
2611
2612         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2613
2614 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2615
2616         Reviewed by Adam Roben.
2617
2618         Fix NRWT to respect set-webkit-configuration again :(
2619
2620         This change fixes a typo in config.py that was causing the wrong
2621         value to be read initially and us never actually looking into
2622         the filesystem to get the default configuration.
2623
2624         * Scripts/webkitpy/layout_tests/port/config.py:
2625         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2626         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2627
2628 2010-11-11  Eric Seidel  <eric@webkit.org>
2629
2630         Reviewed by Adam Barth.
2631
2632         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2633         https://bugs.webkit.org/show_bug.cgi?id=49403
2634
2635         CommitterValidator really had nothing to do with bugzilla.py.
2636         I've put it next to committers.py for now since its rather tied to that file.
2637
2638         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2639         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2640         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2641         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2642         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2643         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2644         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2645         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2646         * Scripts/webkitpy/tool/bot/feeders.py:
2647         * Scripts/webkitpy/tool/commands/queues.py:
2648
2649 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2650
2651         Reviewed by Eric Seidel.
2652
2653         fix missing 'pid' argument for http lockfile checking on win32
2654         https://bugs.webkit.org/show_bug.cgi?id=49363
2655
2656         * Scripts/webkitpy/common/system/executive.py:
2657
2658 2010-11-11  Eric Seidel  <eric@webkit.org>
2659
2660         Rubber-stamped by Adam Barth.
2661
2662         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2663         https://bugs.webkit.org/show_bug.cgi?id=49402
2664
2665         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2666         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2667         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2668
2669 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2670
2671         Reviewed by Chris Fleizach.
2672
2673         Use IAccessibleComparable to compare accessibility objects.
2674         https://bugs.webkit.org/show_bug.cgi?id=49118
2675
2676         * DumpRenderTree/AccessibilityUIElement.cpp:
2677         (AccessibilityUIElement::isEqual):
2678         * DumpRenderTree/AccessibilityUIElement.h:
2679         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2680         (comparableObject):
2681         (AccessibilityUIElement::isEqual):
2682
2683 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2684
2685         Reviewed by David Hyatt.
2686
2687         HTML5 Ruby support should be mandatory feature
2688         https://bugs.webkit.org/show_bug.cgi?id=49272
2689
2690         Remove Ruby as optional feature.
2691
2692         * Scripts/build-webkit:
2693
2694 2010-11-10  Adam Roben  <aroben@apple.com>
2695
2696         Print VC++ Express build logs in the same order that the projects are
2697         built
2698
2699         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2700         in an unhelpful order
2701
2702         Reviewed by Eric Seidel.
2703
2704         * Scripts/print-vse-failure-logs:
2705         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2706         print-msvc-project-dependencies to figure out the order in which
2707         projects are built.
2708         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2709         based on their build order and project name.
2710         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2711         scripts directory from here...
2712         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2713         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2714         them.
2715
2716 2010-11-10  Adam Roben  <aroben@apple.com>
2717
2718         Only print the interesting text from VC++ Express build logs
2719
2720         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2721         output from print-vse-failure-logs
2722
2723         Reviewed by Eric Seidel.
2724
2725         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2726         added newly-required imports. Removed a comment that was essentially a
2727         FIXME, and is now fixed.
2728         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2729         BeautifulSoup to extract the relevant text from the build log.
2730         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2731
2732 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2733
2734         Reviewed by Tony Chang.
2735
2736         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2737         https://bugs.webkit.org/show_bug.cgi?id=49286
2738
2739         The tests in http/tests/security/XFrameOptions started to fail after
2740         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2741         logic to always assign identifiers to requests, even if we're not going
2742         to be dumping resource load callbacks at that point. These tests
2743         only call LayoutTestController.dumpResourceLoadCallbacks after the
2744         request is started, thus their expectations have "<unknown>" as the
2745         identifier. Change WebViewHost to the previous behavior, which also
2746         match the other ports'.
2747
2748         * DumpRenderTree/chromium/WebViewHost.cpp:
2749         (WebViewHost::assignIdentifierToRequest):
2750         (WebViewHost::removeIdentifierForRequest):
2751
2752 2010-11-08  Tony Chang  <tony@chromium.org>
2753
2754         Reviewed by Adam Barth.
2755
2756         run platform/chromium/plugins/return-npobject.html on all platforms
2757         https://bugs.webkit.org/show_bug.cgi?id=49103
2758
2759         This tests that we can get an NPObject returned through a method on
2760         an NPAPI Object.
2761
2762         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2763         (testCallbackReturn):
2764         (pluginInvoke):
2765
2766 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2767
2768         Unreviewed, rolling out r71672.
2769         http://trac.webkit.org/changeset/71672
2770         https://bugs.webkit.org/show_bug.cgi?id=49276
2771
2772         It doesn't work on Chromium Windows bot (Requested by Ossy on
2773         #webkit).
2774
2775         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2776         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2777         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2778
2779 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2780
2781         Reviewed by Tony Chang.
2782
2783         [NRWT] Make http locking similar to perl implementation
2784         https://bugs.webkit.org/show_bug.cgi?id=49187
2785
2786         * Scripts/webkitpy/common/system/file_lock.py: Added.
2787         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2788         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2789
2790 2010-11-09  James Kozianski  <koz@chromium.org>
2791
2792         Reviewed by Eric Seidel.
2793
2794         Clean up imports for webkit-patch.
2795         https://bugs.webkit.org/show_bug.cgi?id=49083
2796
2797         Move some imports from commands into main.py where they are used.
2798         Move command imports into the __init__ of the commands module.
2799
2800         * Scripts/webkitpy/tool/commands/__init__.py:
2801         * Scripts/webkitpy/tool/commands/download.py:
2802         * Scripts/webkitpy/tool/commands/queues.py:
2803         * Scripts/webkitpy/tool/main.py:
2804
2805 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2806
2807         Reviewed by Andreas Kling.
2808
2809         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2810         https://bugs.webkit.org/show_bug.cgi?id=49047
2811
2812         * QtTestBrowser/mainwindow.cpp:
2813         (MainWindow::setAddressUrl):
2814
2815 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2816
2817         Reviewed by Csaba Osztrogonác.
2818
2819         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2820         https://bugs.webkit.org/show_bug.cgi?id=49252
2821
2822         * Scripts/old-run-webkit-tests:
2823
2824 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2825
2826         Reviewed by Tor Arne Vestbø.
2827
2828         Output of old-run-webkit-tests is buggy in verbose mode
2829         https://bugs.webkit.org/show_bug.cgi?id=49249
2830
2831         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2832
2833 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2834
2835         Reviewed by Martin Robinson.
2836
2837         [GTK] Link with target name set does not work
2838         https://bugs.webkit.org/show_bug.cgi?id=48865
2839
2840         When a new page is created with a name (target=myFrame), the new
2841         mainFrame could not be found because they where not stored in the
2842         same PageGroup. As PageGroup are not exposed externally so the
2843         simpliest solution is to use a global page group name. This also fixes
2844         issue with visited link coloration across pages. After this change the
2845         private function webkit_web_view_set_group_name() was no longer used
2846         so it was removed completly.
2847
2848         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2849         (createWebView):
2850
2851 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2852
2853         Reviewed by Kent Tamura.
2854
2855         WebViewHost::reset() uses placement new.
2856         https://bugs.webkit.org/show_bug.cgi?id=49069
2857
2858         WebViewHost is using placement destruction / new to simulate a fresh
2859         WebViewHost object at the same address. This is because the WebView remains
2860         open across tests and maintains a pointer to the WebViewHost.
2861         This change resets member variables explictly instead of the placement new dance.
2862
2863         * DumpRenderTree/chromium/WebViewHost.cpp:
2864         (WebViewHost::WebViewHost):
2865         (WebViewHost::reset):
2866
2867 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2868
2869         Reviewed by Eric Seidel.
2870
2871         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
2872         It turns out that NRWT can't use the code in scm.find_checkout_root()
2873         because the Chromium bots don't do full checkouts of the WebKit
2874         tree; they only check out subdirectories like WebKitTools/Scripts.
2875         Until we can figure out a better approach for this, I've
2876         restored the base_dir-detecting code from NRWT, which works in
2877         any directory tree, scm or no.
2878
2879         This also restores the files modified in r71475 and r71474.
2880
2881         https://bugs.webkit.org/show_bug.cgi?id=49151
2882
2883         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2884         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2885
2886 2010-11-08  Eric Seidel  <eric@webkit.org>
2887
2888         Reviewed by Adam Barth.
2889
2890         webkit-patch failure-reason explodes if a build is missing
2891         https://bugs.webkit.org/show_bug.cgi?id=49195
2892
2893         This is likely a recent regression.  Adding a unit test for this case.
2894
2895         * Scripts/webkitpy/common/net/buildbot.py:
2896         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2897
2898 2010-11-08  Dan Bernstein  <mitz@apple.com>
2899
2900         Reviewed by Darin Adler.
2901
2902         Ignore the system scrollbar setting.
2903
2904         * DumpRenderTree/mac/DumpRenderTree.mm:
2905         (resetDefaultsToConsistentValues): Set the scrollbar default.
2906
2907 2010-11-05  Adam Roben  <aroben@apple.com>
2908
2909         Make webkitpy.common.system.executive_unittest pass when running under
2910         Win32 Python
2911
2912         Fixes <http://webkit.org/b/49033>.
2913
2914         Reviewed by Dave Levin and Eric Seidel.
2915
2916         * Scripts/webkitpy/common/system/executive.py:
2917         (Executive._run_command_with_teed_output): Pass the arguments through
2918         encode_argument_if_needed rather than using Cygwin-specific code here.
2919         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2920         the output.
2921         (Executive.run_command): Use encode_argument_if_needed to encode the
2922         arguments and child_process_encoding to decode the output.
2923         (Executive._child_process_encoding): Returns the encoding that should be
2924         used when communicating with child processes. On Windows we use mbcs,
2925         which maps to the current code page. On all other platforms we use
2926         UTF-8.
2927         (Executive._should_encode_child_process_arguments): Returns True if
2928         arguments to child processes need to be encoded. This is currently
2929         only needed on Cygwin and Win32 Python 2.x.
2930         (Executive._encode_argument_if_needed): Encode the argument using
2931         child_process_encoding if we need to encode arguments to child
2932         processes on this platform.
2933
2934         * Scripts/webkitpy/common/system/executive_unittest.py:
2935         (never_ending_command): Added. Returns arguments to run a command that
2936         will not quit until we kill it. On Windows we use wmic, on other
2937         platforms we use yes.
2938         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2939         mbcs encoding to be used and for output from the child processes to
2940         have been roundtripped through encode/decode on Win32 Python. When
2941         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2942         it's possible that some characters will not be able to be converted
2943         and will be replaced by question marks; the round-tripping allows us
2944         to expect this result.
2945
2946         (ExecutiveTest.test_kill_process):
2947         (ExecutiveTest.test_kill_all):
2948         Use never_ending_command instead of invoking "yes" directly. Expect an
2949         exit code of 1 when using Win32 Python, as that's what seems to happen.
2950
2951 2010-11-08  Adam Roben  <aroben@apple.com>
2952
2953         Roll out r71532
2954
2955         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2956         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2957
2958         * Scripts/webkitdirs.pm:
2959
2960 2010-11-08  Tony Chang  <tony@chromium.org>
2961
2962         Reviewed by Adam Barth.
2963
2964         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2965         https://bugs.webkit.org/show_bug.cgi?id=49094
2966
2967         This tests that objects created by plugins are proplery cleaned up.
2968
2969         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2970         (testPassTestObject):
2971         (pluginInvoke):
2972         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2973         (testAllocate):
2974         (testDeallocate):
2975         (testGetProperty):
2976         (testConstruct):
2977
2978 2010-11-08  Adam Roben  <aroben@apple.com>
2979
2980         Mark Windows builds triggered from Perl as being non-interactive
2981
2982         This affects whether some of our scripts will show alerts vs. printing
2983         to the build log.
2984
2985         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2986         .vsprops files are updated
2987
2988         Reviewed by Steve Falkenburg.
2989
2990         * Scripts/webkitdirs.pm:
2991         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2992
2993 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2994
2995         Reviewed by Ojan Vafai.
2996
2997         Make http locking default in NRWT.
2998         https://bugs.webkit.org/show_bug.cgi?id=48053
2999
3000         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3001         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3002
3003 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3004
3005         Reviewed by Csaba Osztrogonác.
3006
3007         [NRWT] If the http lock fails we shouldn't do any locking
3008         https://bugs.webkit.org/show_bug.cgi?id=49164
3009
3010         If something goes wrong with the locking, the test should keep going.
3011
3012         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3013
3014 2010-11-08  Adam Roben  <aroben@apple.com>
3015
3016         Switch back to using kCGImageAlphaPremultipliedFirst when generating
3017         pixel dumps on Windows
3018
3019         I changed this behavior in r71418 thinking that it was required for
3020         getting plugins to show up in pixel dumps. But it doesn't seem to be
3021         necessary, and was making it impossible to compare new Windows pixel
3022         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
3023         compare an image with alpha to an image without alpha).
3024
3025         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
3026         new Windows pixel results to existing Windows or Mac results
3027
3028         Reviewed by Antti Koivisto.
3029
3030         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3031         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
3032         with kCGImageAlphaPremultipliedFirst.
3033
3034 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
3035
3036         Unreviewed, rolling out r71466.
3037         http://trac.webkit.org/changeset/71466
3038         https://bugs.webkit.org/show_bug.cgi?id=48865
3039
3040         It broke layout tests on GTK bots.
3041
3042         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3043         (createWebView):
3044
3045 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3046
3047         Reviewed by Csaba Osztrogonác.
3048
3049         Enable running of Qt API tests on BuildBot
3050         https://bugs.webkit.org/show_bug.cgi?id=49004
3051
3052         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3053
3054 2010-11-08  Eric Seidel  <eric@webkit.org>
3055
3056         Reviewed by Adam Barth.
3057
3058         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
3059         https://bugs.webkit.org/show_bug.cgi?id=49160
3060
3061         Bugzilla doesn't automatically remove r? when a bug gets closed.
3062         This script takes care of that for webkit.org.
3063
3064         * Scripts/webkitpy/common/net/bugzilla.py:
3065         * Scripts/webkitpy/tool/commands/upload.py:
3066
3067 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3068
3069         Unreviewed, rolling out r71474.
3070         http://trac.webkit.org/changeset/71474
3071         https://bugs.webkit.org/show_bug.cgi?id=48280
3072
3073         breaks chromium webkit tests
3074         https://bugs.webkit.org/show_bug.cgi?id=49151
3075
3076         * Scripts/webkitpy/layout_tests/port/base.py:
3077         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3078         * Scripts/webkitpy/layout_tests/port/config.py:
3079         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3080         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3081         * Scripts/webkitpy/layout_tests/port/webkit.py:
3082         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3083         * Scripts/webkitpy/tool/mocktool.py:
3084
3085 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3086
3087         Unreviewed, rolling out r71475.
3088         http://trac.webkit.org/changeset/71475
3089
3090         breaks chromium webkit tests
3091         https://bugs.webkit.org/show_bug.cgi?id=49151
3092
3093         * Scripts/webkitpy/common/newstringio.py: Removed.
3094         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
3095         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
3096         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
3097         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
3098
3099 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3100
3101         Unreviewed, build fix.
3102
3103         Add files inexplicably not committed in r71474 as part of the
3104         fix for bug 48280.
3105
3106         * Scripts/webkitpy/common/newstringio.py: Added.
3107         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3108         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3109         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3110         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
3111
3112 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3113
3114         Reviewed by Eric Siedel.
3115
3116         new-run-webkit-tests: update port/base and port/webkit to use the
3117         new FileSystem and Config abstractions, pulling more logic out of
3118         the base Port classes into separate, mockable objects.
3119
3120         Also create a MockFileSystem object, a MockConfig object, move
3121         MockExecutive into common/system to be next to executive, and
3122         update the config object to use a FileSystem.
3123
3124         https://bugs.webkit.org/show_bug.cgi?id=48280
3125
3126         * Scripts/webkitpy/common/newstringio.py: Added.
3127         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3128         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3129         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3130         * Scripts/webkitpy/layout_tests/port/base.py:
3131         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3132         * Scripts/webkitpy/layout_tests/port/config.py:
3133         * Scripts/webkitpy/layout_tests/port/config_mock.py:
3134         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3135         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3136         * Scripts/webkitpy/layout_tests/port/webkit.py:
3137         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3138         * Scripts/webkitpy/tool/mocktool.py:
3139
3140 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3141
3142         Unreviewed, build breakage.
3143
3144         Apparently I uploaded the wrong version of the file to fix 49122
3145         and neither Eric or I noticed - it was missing a dirname() call.
3146         Fixing ...
3147
3148         https://bugs.webkit.org/show_bug.cgi?id=49122
3149
3150         * Scripts/webkitpy/common/checkout/scm.py:
3151
3152 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3153
3154         Reviewed by Eric Seidel.
3155
3156         webkitpy/tool/* unittests change cwd and don't clean up properly
3157
3158         https://bugs.webkit.org/show_bug.cgi?id=49122
3159
3160         * Scripts/webkitpy/common/checkout/scm.py:
3161
3162 2010-11-05  Chris Marrin  <cmarrin@apple.com>
3163
3164         Reviewed by Simon Fraser.
3165
3166         suspendAnimations/resumeAnimations not present in WebKit2
3167         https://bugs.webkit.org/show_bug.cgi?id=49109
3168
3169         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3170         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3171         (WTR::LayoutTestController::suspendAnimations):
3172         (WTR::LayoutTestController::resumeAnimations):
3173         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3174
3175 2010-11-05  Tony Chang  <tony@chromium.org>
3176
3177         Reviewed by David Levin.
3178
3179         cleanup style in TestNetscapePlugIn/PluginObject.cpp
3180         https://bugs.webkit.org/show_bug.cgi?id=49044
3181
3182         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3183         (getPluginClass):
3184         (pluginGetProperty):
3185         (pluginSetProperty):
3186         (variantToIdentifier):
3187         (testCallback):
3188         (getURL):
3189         (getURLNotify):
3190         (testInvokeDefault):
3191         (testGetProperty):
3192         (testDocumentOpen):
3193         (testWindowOpen):
3194         (pluginInvoke):
3195         (handleCallback):
3196         (notifyStream):
3197         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3198
3199 2010-11-05  Eric Seidel  <eric@webkit.org>
3200
3201         Reviewed by David Levin.
3202
3203         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
3204         https://bugs.webkit.org/show_bug.cgi?id=49032
3205
3206         I wrote this file as part of bug 47847, but I forgot to commit it.
3207         No one else noticed it missing because test-webkitpy knows how
3208         to recover in the case where it can't import QueueStatusServer
3209         (which generally occurs due to not having installed the AppEngine SDK).
3210
3211         * QueueStatusServer/__init__.py: Added.
3212         * QueueStatusServer/model/workitems_unittest.py:
3213          - Remove a test which fails.  This was probably landed (by me)
3214            from my other machine, which since this __init__.py was missing
3215            I never noticed the failure and landed this invalid test.
3216            Sadly we can't really test remove_work_item as it depends
3217            on .key() working.  .key() will throw unless the object
3218            has already been saved it seems.
3219            This may be a mis-design in our remove_work_item implementation,
3220            but for now, just removing the test.
3221
3222 2010-11-04  Adam Roben  <aroben@apple.com>
3223
3224         Teach check-webkit-style about TestNetscapePlugIn
3225
3226         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
3227         TestNetscapePlugIn's coding conventions
3228
3229         Reviewed by John Sullivan.
3230
3231         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3232         WebKitAPITest and TestWebKitAPI in having different include order and
3233         naming conventions than WebCore. Added some comments about why the
3234         exceptions exist.
3235
3236 2010-11-04  Adam Roben  <aroben@apple.com>
3237
3238         Add a test that shows that windowed plugins are able to paint
3239
3240         Somehow we never had a test for this before.
3241
3242         Fixes <http://webkit.org/b/49029> Should add a test that shows
3243         windowed plugins can paint
3244
3245         Reviewed by Jon Honeycutt.
3246
3247         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3248         (DrawsGradient::DrawsGradient):
3249         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3250
3251         (DrawsGradient::onPaint):
3252         (DrawsGradient::onPrintClient):
3253         These both just call through to paint.
3254
3255         (DrawsGradient::paint): Fills our client area with some gradients.
3256
3257         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3258         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3259
3260         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3261         (createBitmapContextFromWebView): Use WM_PRINT instead of
3262         WM_PRINTCLIENT so that ::DefWindowProc will send
3263         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3264         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3265         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3266         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3267         will run on a big-endian platform.
3268
3269 2010-11-04  Adam Roben  <aroben@apple.com>
3270
3271         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3272         WindowedPluginTest base class
3273
3274         The base class takes care of subclassing the plugin's window so that a
3275         custom WNDPROC is called. This will make it easier to write tests that
3276         need to handle window messages.
3277
3278         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3279         a custom WNDPROC
3280
3281         Reviewed by Jon Honeycutt.
3282
3283         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3284         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3285         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3286         (NPNInvalidateRectInvalidatesWindow::wndProc):
3287         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3288         Moved code from here to WindowedPluginTest. Changed to use window()
3289         instead of m_window.
3290
3291         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3292         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3293         include path. Also reordered the include path to make a little more
3294         sense and simplified the entry that added TestNetscapePlugIn itself to
3295         the include path.
3296
3297         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3298         (WindowedPluginTest::WindowedPluginTest):
3299         (WindowedPluginTest::NPP_SetWindow):
3300         (WindowedPluginTest::staticWndProc):
3301         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3302         (WindowedPluginTest::window):
3303         Code came from NPNInvalidateRectInvalidatesWindow.
3304
3305 2010-11-04  Adam Roben  <aroben@apple.com>
3306
3307         Add a plugin test to show that windowed plugins are clipped correctly
3308
3309         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3310         plugins aren't clipped in WebKit2 on Windows
3311
3312         Reviewed by Jon Honeycutt.
3313
3314         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3315         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3316         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3317         region matches the clip rect we know we should have based on
3318         window-region-is-set-to-clip-rect.html, and check that our window class
3319         doesn't have the CS_PARENTDC style.
3320
3321         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3322         Added WindowRegionIsSetToClipRect.
3323
3324 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3325
3326         Reviewed by Martin Robinson.
3327
3328         [GTK] Avoid font hinting in the DRT
3329         https://bugs.webkit.org/show_bug.cgi?id=48548
3330
3331         Change the settings to avoid font hinting, it was causing
3332         different results depending on the distribution.
3333
3334         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3335         (initializeGtkFontSettings):
3336         * DumpRenderTree/gtk/fonts/fonts.conf:
3337
3338 2010-11-05  Eric Seidel  <eric@webkit.org>
3339
3340         Reviewed by Adam Barth.
3341
3342         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3343         https://bugs.webkit.org/show_bug.cgi?id=49051
3344
3345         This is a speculative fix.  The unit tests cover these methods, however
3346         I don't know if this will fully stop the system.log spam.
3347
3348         * Scripts/webkitpy/layout_tests/port/base.py:
3349         * Scripts/webkitpy/layout_tests/port/webkit.py:
3350
3351 2010-11-05  Eric Seidel  <eric@webkit.org>
3352
3353         Reviewed by Adam Barth.
3354
3355         Add basic support for showing bot id on /queue-status/ pages
3356         https://bugs.webkit.org/show_bug.cgi?id=49037
3357
3358         This support is really simple.  Eventually we'll want to
3359         show the bot id in the lock table too, but we don't have
3360         that information stored in the server yet.
3361
3362         * QueueStatusServer/handlers/queuestatus.py:
3363         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3364         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3365
3366 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3367
3368         Reviewed by Adam Barth.
3369
3370         Create a filesystem wrapper that we can use to enforce
3371         particular conventions and use for mocking and dependency
3372         injection down the line.
3373
3374         https://bugs.webkit.org/show_bug.cgi?id=48144
3375
3376         * Scripts/webkitpy/common/system/filesystem.py: Added.
3377         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3378
3379 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3380
3381         Reviewed by Tony Chang.
3382
3383         run_webkit_tests_unittest fails under Python 2.5
3384         https://bugs.webkit.org/show_bug.cgi?id=49043
3385
3386         Switch from itertools.chain.from_iterable (which was added in 2.6)
3387         to using itertools.chain directly.
3388
3389         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3390
3391 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3392
3393         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3394         Python 2.5 (it needs an import to use the with statement).
3395
3396         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3397
3398 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3399
3400         Reviewed by Adam Barth.
3401
3402         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3403
3404         The current NRWT code has webkit-specific configuration code (like
3405         _script_path, default configuration, etc.) mixed in with
3406         layout-test-specific stuff in port/base. The configuration code
3407         should be split out into a separate module for easier mocking,
3408         testing, and isolation.
3409
3410         https://bugs.webkit.org/show_bug.cgi?id=48264
3411
3412         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3413         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3414
3415 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3416
3417         Reviewed by Tony Chang.
3418
3419         Rebaseline server: initial framework
3420         https://bugs.webkit.org/show_bug.cgi?id=48892
3421
3422         Adds the basic framework for the rebaseline server (details at
3423         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
3424         command, which starts an HTTP server that can serve static files or
3425         invoke handler methods on a class.
3426
3427         * Scripts/webkitpy/tool/commands/__init__.py:
3428         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
3429         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
3430         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
3431         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
3432
3433 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3434
3435         Reviewed by James Robinson.
3436
3437         new-run-webkit-tests wasn't using DRT by default for
3438         --platform chromium-gpu
3439
3440         The default value was set to False instead of None, which meant
3441         that the platform specific logic wasn't firing to change the
3442         value to True (b/c we were afraid we'd be overriding the user
3443         preference).
3444
3445         https://bugs.webkit.org/show_bug.cgi?id=49038
3446
3447         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3448
3449 2010-11-04  Tony Chang  <tony@chromium.org>
3450
3451         Reviewed by Adam Barth.
3452
3453         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
3454         https://bugs.webkit.org/show_bug.cgi?id=49026
3455
3456         Have the testObject.bar property return the string "bar".  This lets
3457         us run and pass platform/chromium/plugins/multiple-plugins.html on all
3458         platforms.
3459
3460         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3461         (testGetProperty):
3462
3463 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3464
3465         Reviewed by Tony Chang.
3466
3467         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
3468         https://bugs.webkit.org/show_bug.cgi?id=48878
3469
3470         Add get_tests_run so that it's easy to see which tests get run (and with
3471         what batching) for a given flag combination. Flesh out the various
3472         test cases that have FIXMEs.
3473
3474         Also fixes an off-by-one error (batch sizes were one larger than
3475         expected) and makes --run-part also have wraparound behavior, like
3476         --run-chunk.
3477
3478         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3479         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3480         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3481
3482 2010-11-04  Erik Arvidsson  <arv@chromium.org>
3483
3484         Reviewed by Dimitri Glazkov.
3485
3486         Support box-sizing without the vendor prefix
3487         https://bugs.webkit.org/show_bug.cgi?id=36713
3488
3489         Based on patch by Peter Beverloo <peter@lvp-media.com>
3490
3491         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
3492
3493 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3494
3495         Unreviewed rollout r71340, because it broke Chromium Windows bot.
3496
3497         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3498         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3499
3500 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3501
3502         Reviewed by Ojan Vafai.
3503
3504         Make http locking default in NRWT.
3505         https://bugs.webkit.org/show_bug.cgi?id=48053
3506
3507         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3508         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3509
3510 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3511
3512         Reviewed by Eric Seidel.
3513
3514         [NRWT] Clear invalid http locks on Windows platform as well
3515         https://bugs.webkit.org/show_bug.cgi?id=48515
3516
3517         * Scripts/webkitpy/common/system/executive.py:
3518         * Scripts/webkitpy/common/system/executive_unittest.py:
3519         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3520
3521 2010-11-02  Adam Roben  <aroben@apple.com>
3522
3523         Reduce our dependence on coreutils when running Python tests
3524
3525         This patch introduces versions of the standard echo and cat utilities
3526         implemented in Python. They are probably missing features of their
3527         coreutils equivalents, but they can do what's necessary for our Python
3528         tests. This is useful on Windows, where these utilities typically
3529         aren't available.
3530
3531         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3532         and cat utilities from coreutils, which are not present on Windows
3533
3534         Reviewed by Eric Seidel.
3535
3536         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3537         our Python-based echo and cat.
3538
3539         * Scripts/webkitpy/common/system/fileutils.py: Added.
3540         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3541         that \n won't be translated into \r\n. I couldn't think of a good way
3542         to test this directly without touching the filesystem, but it is tested
3543         indirectly by echo_unittest.
3544
3545         * Scripts/webkitpy/test/cat.py: Added.
3546         (command_arguments): Returns a list for invoking cat with the given arguments.
3547         (main): Acts like a simplified version of the coreutils cat utility.
3548
3549         * Scripts/webkitpy/test/cat_unittest.py: Added.
3550         (CatTest.assert_cat): Runs cat with the given input and ensures the
3551         output matches the input.
3552         (CatTest.test_basic): Performs a simple test of cat.
3553         (CatTest.test_no_newline): Tests what happens when the input string
3554         doesn't have a trailing newline.
3555         (CatTest.test_unicode): Tests passing a unicode string to cat.
3556         (CatTest.test_as_command): Tests running cat as a separate command.
3557
3558         * Scripts/webkitpy/test/echo.py: Added.
3559         (command_arguments): Returns a list for invoking echo with the given arguments.
3560         (main): Acts like a simplified version of the coreutils echo utility.
3561
3562         * Scripts/webkitpy/test/echo_unittest.py: Added.
3563         (EchoTest.test_basic): Performs a simple test of echo.
3564         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3565         trailing newline.
3566         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3567         to echo.
3568         (EchoTest.test_argument_order): Tests what happens when -n is not the
3569         first argument.
3570         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3571         echo.main.
3572         (EchoTest.test_no_arguments): Tests what happens when you call
3573         echo.main with no arguments.
3574         (EchoTest.test_as_command): Tests running echo as a separate command.
3575
3576 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3577
3578         Unreviewed: Add myself to the list of Committers.
3579
3580         * Scripts/webkitpy/common/config/committers.py:
3581
3582 2010-11-04  Andreas Kling  <kling@webkit.org>
3583
3584         Reviewed by Kenneth Rohde Christiansen.
3585
3586         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3587
3588         In RTC mode the QGraphicsWebView item is the size of the contents,
3589         scrolling works a bit differently  (we need to react to scrollRequested.)
3590
3591         Normally QGraphicsView will replay the last mouse event when scrolling,
3592         so to prevent WebKit from getting confused by this we temporarily make
3593         the QGraphicsView non-interactive.
3594
3595         * QtTestBrowser/webview.cpp:
3596         (WebViewGraphicsBased::setPage):
3597         (WebViewGraphicsBased::scrollRequested):
3598         * QtTestBrowser/webview.h:
3599
3600 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3601
3602         Reviewed by Andreas Kling.
3603
3604         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3605
3606         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3607         the Mac-port, not the Mac OS X operating system.
3608
3609         * WebKitTestRunner/qt/TestControllerQt.cpp:
3610         (WTR::isExistingLibrary):
3611
3612 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3613
3614         Reviewed by Andreas Kling.
3615
3616         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3617         https://bugs.webkit.org/show_bug.cgi?id=48869
3618
3619         * QtTestBrowser/useragentlist.txt:
3620
3621 2010-11-03  Adam Roben  <aroben@apple.com>
3622
3623         Always use uppercase drive names in strings returned by abspath_to_uri
3624
3625         Some versions of cygpath use lowercase drive letters while others use
3626         uppercase, which makes it hard to test the output of code that uses
3627         cygpath.
3628
3629         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
3630         fails with Cygwin 1.5
3631
3632         Reviewed by Eric Seidel.
3633
3634         * Scripts/webkitpy/common/system/path.py:
3635         (cygpath): Updated the docstring to indicate that only absolute paths
3636         should be passed for now (though relative paths will work fine).
3637         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
3638
3639 2010-11-03  George Guo  <George.Guo@Nokia.com>
3640
3641         Reviewed by Andreas Kling.
3642
3643         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
3644         https://bugs.webkit.org/show_bug.cgi?id=48767
3645
3646         Paging is needd on Symbian devices to support benchmarks tests like
3647         dromaeo.com and Celtic Kane that need a lot of memory to run
3648
3649         * QtTestBrowser/QtTestBrowser.pro:
3650
3651 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
3652
3653         Reviewed by Dmitry Titov.
3654
3655         Chromium: Update resource tracking when moving a frame between documents
3656         https://bugs.webkit.org/show_bug.cgi?id=48363
3657
3658         * DumpRenderTree/chromium/WebViewHost.cpp:
3659         (WebViewHost::assignIdentifierToRequest):
3660         Always put resource id in map so we can make assumptions about its
3661         presence.
3662         (WebViewHost::removeIdentifierForRequest):
3663         Added.
3664         (WebViewHost::didFinishResourceLoad):
3665         (WebViewHost::didFailResourceLoad):
3666         Check existence of resource id before removing from map.
3667         * DumpRenderTree/chromium/WebViewHost.h:
3668
3669 2010-11-03  Victor Wang  <victorw@chromium.org>
3670
3671         Reviewed by Adam Barth.
3672
3673         [Chromium] update buildbot names in chromium rebaseline tool.
3674
3675         https://bugs.webkit.org/show_bug.cgi?id=48881
3676
3677         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3678
3679 2010-11-03  Darin Adler  <darin@apple.com>
3680
3681         Updated Xcode projects by opening them with Xcode 3.2.4.
3682         Updated svn:ignore for Xcode projects.
3683
3684         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
3685         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
3686         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3687         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
3688
3689 2010-11-03  Adam Roben  <aroben@apple.com>
3690
3691         Stop waiting for messages from the web process after a timeout elapses
3692
3693         TestController::runUntil now takes a timeout parameter that specifies
3694         how long to wait for the condition to become true. WebKitTestRunner
3695         takes a --timeout flag that specifies how long the timeout should be.
3696         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
3697         will be similar to run-webkit-tests.
3698
3699         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
3700         WebKitTestRunner waits forever if the web process crashes
3701
3702         Reviewed by Darin Adler and Anders Carlsson.
3703
3704         * Scripts/old-run-webkit-tests:
3705         (top level): Moved the GuardMalloc timeout adjustment here from
3706         readFromDumpToolWithTimer.
3707         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
3708         than the one that was specified on the command line.
3709
3710         * WebKitTestRunner/TestController.cpp:
3711         (WTR::TestController::TestController): Initialize our timeout values.
3712         (WTR::TestController::initialize): Parse the --timeout flag and use it
3713         to modify our timeout values.
3714         (WTR::TestController::resetStateToConsistentValues): Changed to use a
3715         short timeout while waiting for the web process to reset and to return
3716         a boolean indicating whether we were able to reset the web process.
3717         Uses a 5-second timeout while waiting for the process to be reset.
3718         (WTR::TestController::runTest): Changed to return a boolean indicating
3719         whether we were able to reset the web process (and thus run the test).
3720         (WTR::TestController::runUntil): Call through to platformRunUntil.
3721
3722         (WTR::TestController::runTestingServerLoop):
3723         (WTR::TestController::run):
3724         Changed to bail if any test can't be run. This will cause the process
3725         to exit. (Unfortunately this will make run-webkit-tests think we
3726         crashed; see <http://webkit.org/b/48943>.)
3727
3728         * WebKitTestRunner/TestController.h: Added platformRunUntil,
3729         m_longTimeout, and m_shortTimeout.
3730
3731         * WebKitTestRunner/TestInvocation.cpp:
3732         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
3733         initial response and a long timeout when waiting for the test to
3734         complete. Check whether runUntil timed out and print an error message
3735         if so.
3736
3737         * WebKitTestRunner/mac/TestControllerMac.mm:
3738         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
3739         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
3740         won't block waiting for the run loop. Only loop until the timeout
3741         elapses.
3742
3743         * WebKitTestRunner/qt/TestControllerQt.cpp:
3744         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
3745         FIXME about honoring the timeout.
3746
3747         * WebKitTestRunner/win/TestControllerWin.cpp:
3748         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
3749         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
3750         ::PeekMessageW so that we don't block waiting for messages to become
3751         available.
3752
3753 2010-11-03  Adam Roben  <aroben@apple.com>
3754
3755         Add a plugin test that evaluates JS after removing the plugin element
3756         from the document
3757
3758         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
3759         That test was made to prevent a crash very similar to this one, but
3760         unfortunately tested only the mechanism that prevented the crash and
3761         not whether the crash itself was prevented. Since WebKit2 uses a
3762         different mechanism to prevent the crash, the test was failing even
3763         though WebKit2 was not vulnerable to the crash. This new test crashes
3764         if there is no mechanism in place to prevent it and passes in both
3765         WebKit1 and WebKit2.
3766
3767         Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
3768         platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2
3769
3770         Reviewed by Anders Carlsson.
3771
3772         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3773         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3774         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3775         * GNUmakefile.am:
3776         Added new file.
3777
3778         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3779         (pluginDeallocate): Make sure we delete the PluginTest object. This
3780         prevents a leak and also allows us to test the crash.
3781
3782         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3783         (PluginTest::executeScript): Made this into a non-static member
3784         function.
3785
3786         (PluginTest::waitUntilDone):
3787         (PluginTest::notifyDone):
3788         Updated for changes to executeScript.
3789
3790         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
3791
3792         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.
3793         (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
3794         Initialize ourselves and tell the test harness to wait.
3795         (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
3796         plugin element from the document, then execute some JavaScript. If
3797         WebKit does not have appropriate mechanisms in place, we'll be
3798         destroyed inside the first call to executeScript and crash on the
3799         second call.
3800
3801 2010-11-02  Stephen White  <senorblanco@chromium.org>
3802
3803         Reviewed by Tony Chang.
3804
3805         [chromium] Fix LayoutTestController UMRs.
3806         https://bugs.webkit.org/show_bug.cgi?id=48872
3807
3808         * DumpRenderTree/chromium/LayoutTestController.cpp:
3809         (LayoutTestController::LayoutTestController):
3810
3811 2010-11-03  Kent Tamura  <tkent@chromium.org>
3812
3813         Reviewed by Dimitri Glazkov.
3814
3815         REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
3816         image dup detection
3817         https://bugs.webkit.org/show_bug.cgi?id=48744
3818
3819         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3820          - Make a function for option parsing for ease of test
3821          - Set 0 to options.tolerance
3822         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3823          - Add a test for this change
3824
3825 2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3826
3827         Unreviewed: Add myself to the list of Committers.
3828
3829         * Scripts/webkitpy/common/config/committers.py:
3830
3831 2010-11-02  Anders Carlsson  <andersca@apple.com>
3832
3833         Fix build.
3834
3835         * TestWebKitAPI/PlatformUtilities.cpp:
3836         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3837
3838 2010-11-02  Sam Weinig  <sam@webkit.org>
3839
3840         Reviewed by Anders Carlsson.
3841
3842         Add a way to send startup messages on the context which can be posted when a process launches
3843         <rdar://problem/8617928>
3844         https://bugs.webkit.org/show_bug.cgi?id=48838
3845
3846         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3847         (WKBundleInitialize):
3848         * TestWebKitAPI/InjectedBundleController.cpp:
3849         (TestWebKitAPI::InjectedBundleController::initialize):
3850         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
3851         * TestWebKitAPI/InjectedBundleController.h:
3852         * TestWebKitAPI/InjectedBundleMain.cpp:
3853         (WKBundleInitialize):
3854         * TestWebKitAPI/PlatformUtilities.cpp:
3855         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3856         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3857         (WKBundleInitialize):
3858         Update implementations of WKBundleInitialize to take an initial userData
3859         argument.  Change TestWebKitAPI to use the new initial userData to initialize
3860         each test's bundle.
3861
3862 2010-11-02  Benjamin Kalman  <kalman@google.com>
3863
3864         Reviewed by Ojan Vafai.
3865
3866         new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
3867         https://bugs.webkit.org/show_bug.cgi?id=48794
3868
3869         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
3870
3871 2010-11-02  Adam Roben  <aroben@apple.com>
3872
3873         Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin
3874         Python 2.5.x
3875
3876         It is known to hang on that version of Python. See
3877         <http://webkit.org/b/48614>.
3878
3879         Reviewed by Adam Barth.
3880
3881         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use
3882         skip_if to skip MainTest on Cygwin Python 2.5.x.
3883
3884         * Scripts/webkitpy/test/skip.py: Added.
3885         (skip_if): If the passed-in condition is false, find all the test_*
3886         methods of the given class and replace them with a function that just
3887         logs that we're skipping these tests. This is loosely based on the
3888         unittest.skip_if decorator added in Python 3.1.
3889         (_skipped_method): Returns a function that just logs that the tests are
3890         being skipped. This is used in place of the actual test_* functions.
3891
3892         * Scripts/webkitpy/test/skip_unittest.py: Added.
3893         (SkipTest.setUp): Create a logger for ourselves and give it a handler
3894         that logs to a private stream.
3895         (SkipTest.tearDown): Reset the logger.
3896         (SkipTest.create_fixture_class): Returns a class that we use to test
3897         skip_if. It has a single test_* method, test_foo, that just calls
3898         through to a callback.
3899         (SkipTest.foo_callback): Record that test_foo was called.
3900         (SkipTest.test_skip_if_false): Pass skip_if a False condition and test
3901         that test_foo does get called.
3902         (SkipTest.test_skip_if_true): Pass skip_if a True condition and test
3903         that test_foo does not get called and the appropriate message gets
3904         logged.
3905
3906 2010-11-02  Adam Barth  <abarth@webkit.org>
3907
3908         Reviewed by Eric Seidel.
3909
3910         webkit-patch should tell check-webkit-style which files were changed so
3911         check-webkit-style doesn't have to stat the whole working copy again
3912         https://bugs.webkit.org/show_bug.cgi?id=48792
3913
3914         * Scripts/webkitpy/tool/mocktool.py:
3915         * Scripts/webkitpy/tool/steps/checkstyle.py:
3916
3917 2010-11-02  Robert Kroeger  <rjkroege@chromium.org>
3918
3919         Reviewed by James Robinson.
3920
3921         [Chromium/DRT] Make EventSendingController honour leapForward for touch events.
3922         https://bugs.webkit.org/show_bug.cgi?id=48777
3923
3924         * DumpRenderTree/chromium/EventSender.cpp:
3925         (EventSender::sendCurrentTouchEvent):
3926
3927 2010-11-02  Adam Roben  <aroben@apple.com>
3928
3929         Only track resource identifiers in DRT when dumpResourceLoadCallbacks
3930         is on
3931
3932         This reverts Windows to our pre-r71097 behavior. That patch made us
3933         track all resource identifiers, including the main resource, so the
3934         main resource's URL started appearing in test output instead of
3935         "<unknown>". Arguably having the main resource's URL is better, but all
3936         other platforms print "<unknown>" and we want to match.
3937
3938         Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
3939         (r71097): Many http tests failing on Windows
3940
3941         Reviewed by Anders Carlsson.
3942
3943         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3944         (ResourceLoadDelegate::identifierForInitialRequest): Don't add the
3945         identifier to the URL map if we're not supposed to dump resource load
3946         callbacks.
3947         (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
3948         identifier from the URL map even if we're already "done". There's no
3949         point in keeping out-of-date identifiers around.
3950
3951 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
3952
3953         Reviewed by Adam Roben.
3954
3955         Windows: Update resource tracking when moving a frame between documents
3956         https://bugs.webkit.org/show_bug.cgi?id=48364
3957
3958         * DumpRenderTree/win/DumpRenderTree.cpp:
3959         (createWebViewAndOffscreenWindow):
3960         (main):
3961         Give each WebView its own ResourceLoadDelegate instance in order to
3962         make assertions about resource ids on a particular WebView.
3963         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3964         (ResourceLoadDelegate::identifierForInitialRequest):
3965         Always add id to the map.
3966         (ResourceLoadDelegate::removeIdentifierForRequest):
3967         Added.
3968         (ResourceLoadDelegate::willSendRequest):
3969         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3970         (ResourceLoadDelegate::didReceiveResponse):
3971         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3972         (ResourceLoadDelegate::didFailLoadingWithError):
3973         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3974         Replace static descriptionSuitableForTestResult with static member function to access identifier map.
3975         * DumpRenderTree/win/ResourceLoadDelegate.h:
3976         (ResourceLoadDelegate::urlMap):
3977         Moved within class so that each WebView has its own id map.
3978
3979 2010-11-01  Ojan Vafai  <ojan@chromium.org>
3980
3981         Reviewed by Dimitri Glazkov.
3982
3983         remove debug code from run_webkit_tests.py
3984         https://bugs.webkit.org/show_bug.cgi?id=48800
3985
3986         Remove temporary debug code and make --master-name required
3987         if --test-results-server is set now that all clients set
3988         --master-name.
3989
3990         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3991
3992 2010-11-01  Tony Chang  <tony@chromium.org>
3993
3994         Reviewed by Kent Tamura.
3995
3996         add plugin event logging for linux
3997         https://bugs.webkit.org/show_bug.cgi?id=48779
3998
3999         This is taken from Chromium's fork of the layout test plugin:
4000         http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
4001
4002         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4003         (handleEventX11):
4004         (NPP_HandleEvent):
4005
4006 2010-11-01  Dirk Pranke  <dpranke@chromium.org>
4007
4008         Reviewed by James Robinson.
4009
4010         new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
4011         https://bugs.webkit.org/show_bug.cgi?id=48790
4012
4013         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4014         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4015
4016 2010-11-01  Adam Barth  <abarth@webkit.org>
4017
4018         Reviewed by Eric Seidel.
4019
4020         Teach check-webkit-style how to accept a list of files to diff on the
4021         command line
4022         https://bugs.webkit.org/show_bug.cgi?id=48784
4023
4024         In a future patch, webkit-patch will use this option to improve
4025         performance.  I'm landing this in two pieces to avoid causing a version
4026         skew problem for the style-bot.
4027
4028         * Scripts/check-webkit-style:
4029         * Scripts/webkitpy/style/optparser.py:
4030         * Scripts/webkitpy/style/optparser_unittest.py:
4031         * Scripts/webkitpy/style_references.py:
4032
4033 2010-11-01  Anders Carlsson  <andersca@apple.com>
4034
4035         Reviewed by John Sullivan.
4036
4037         Tear down the related WebProcessProxy when a WebContext is deallocated
4038         https://bugs.webkit.org/show_bug.cgi?id=48769
4039
4040         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
4041         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
4042         We don't support empty URLs anymore, update test to expect a null URL instead.
4043
4044 2010-11-01  Søren Gjesse  <sgjesse@chromium.org>
4045
4046         Reviewed by Andreas Kling.
4047
4048         Fix warning when compiling the chromium port of DumpRenderShell
4049         with clang.
4050         https://bugs.webkit.org/show_bug.cgi?id=48414
4051
4052         * DumpRenderTree/chromium/TestShell.h:
4053         (TestShell::javaScriptFlagsForLoad):
4054
4055 2010-11-01  Adam Roben  <aroben@apple.com>
4056
4057         Fix typo from r71022
4058
4059         * BuildSlaveSupport/build.webkit.org-config/config.json:
4060
4061 2010-11-01  Adam Roben  <aroben@apple.com>
4062
4063         Trigger the Windows Release WebKit2 tests when a Release build
4064         finishes, not when a Debug build finishes
4065
4066         Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
4067         triggered at the wrong time
4068
4069         Reviewed by Sam Weinig.
4070
4071         * BuildSlaveSupport/build.webkit.org-config/config.json: Fixed
4072         triggerable name and trigger.
4073
4074 2010-11-01  Mario Sanchez Prada  <msanchez@igalia.com>
4075
4076         Unreviewed. Adding my IRC nickname to the list of committers.
4077
4078         * Scripts/webkitpy/common/config/committers.py:
4079
4080 2010-10-31  Robert Hogan  <robert@webkit.org>
4081
4082         Reviewed by Antonio Gomes.
4083
4084         [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
4085
4086         Qt and Gtk are case-sensitive when storing the declared mime-type
4087         of plugins. Since plugin mime-types are lowercased prior to searching
4088         for them in the plugin database, ensure they are loaded with the
4089         mime-type in lower case too.
4090
4091         Change the test netscape plugin to declare its mimetype in sentence
4092         case so that the correct behaviour is enforced.
4093
4094         https://bugs.webkit.org/show_bug.cgi?id=36815
4095
4096         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4097         (NP_GetMIMEDescription):
4098
4099 2010-10-31  Robert Hogan  <robert@webkit.org>
4100
4101         Reviewed by Antonio Gomes.
4102
4103         [Qt] Support nodesFromRect in DRT
4104
4105         https://bugs.webkit.org/show_bug.cgi?id=48716
4106
4107         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4108         (LayoutTestController::nodesFromRect):
4109         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4110
4111 2010-10-30  Andreas Kling  <kling@webkit.org>
4112
4113         Reviewed by Antonio Gomes.
4114
4115         [Qt] QtTestBrowser: Switching view type moves the embedded inspector
4116         https://bugs.webkit.org/show_bug.cgi?id=48705
4117
4118         Reinsert the embedded inspector into the splitter after changing
4119         between QWebView/QGraphicsWebView.
4120
4121         * QtTestBrowser/launcherwindow.cpp:
4122         (LauncherWindow::init):
4123         (LauncherWindow::initializeView):
4124         * QtTestBrowser/webinspector.h:
4125         (WebInspector::WebInspector):
4126
4127 2010-10-28  Antonio Gomes  <agomes@rim.com>
4128
4129         Reviewed by Ojan Vafai.
4130
4131         Needs a "LinuxEditingBehavior", perhaps with a better name
4132         https://bugs.webkit.org/show_bug.cgi?id=36627
4133
4134         Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
4135
4136         * DumpRenderTree/chromium/LayoutTestController.cpp:
4137         (LayoutTestController::setEditingBehavior):
4138         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4139         (LayoutTestController::setEditingBehavior):
4140         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4141         (LayoutTestController::setEditingBehavior):
4142         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4143         (LayoutTestController::setEditingBehavior):
4144
4145 2010-10-29  Andreas Kling  <kling@webkit.org>
4146
4147         Reviewed by Kenneth Rohde Christiansen.
4148
4149         [Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
4150         https://bugs.webkit.org/show_bug.cgi?id=48695
4151
4152         * QtTestBrowser/launcherwindow.cpp:
4153         (LauncherWindow::createChrome):
4154
4155 2010-10-29  Andreas Kling  <kling@webkit.org>
4156
4157         Reviewed by Kenneth Rohde Christiansen.
4158
4159         [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
4160         https://bugs.webkit.org/show_bug.cgi?id=48675
4161
4162         FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
4163         on startup with in -graphicsbased mode.
4164
4165         * QtTestBrowser/fpstimer.cpp:
4166         (FpsTimer::FpsTimer):
4167         (FpsTimer::numFrames):
4168         (FpsTimer::stop):
4169         (FpsTimer::timerEvent):
4170         * QtTestBrowser/fpstimer.h:
4171
4172 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
4173
4174         Reviewed by Tony Chang.
4175
4176         new-run-webkit-tests: change TestResults to be serializable
4177
4178         In preparation for changing new-run-webkit-tests from
4179         multithreaded to multiprocess, we need to make sure the data
4180         going between the threads is easily serialized over a socket.
4181
4182         This change adds serialization/pickling for the TestResults and
4183         TestFailure objects (using cPickle).
4184
4185         The TestFailure objects included a "has_wdiff" flag for Text
4186         results, but the flag wasn't being used, so I've removed it,
4187         simplifying the state to basically a set of enum objects with
4188         associated methods.
4189
4190         https://bugs.webkit.org/show_bug.cgi?id=48616
4191
4192         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4193         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4194         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4195         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
4196         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
4197         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added.
4198         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4199         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4200
4201 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
4202
4203         Reviewed by Ojan Vafai.
4204
4205         new-run-webkit-tests: need to provide separate dashboard results for GPU tests
4206         https://bugs.webkit.org/show_bug.cgi?id=48687
4207
4208         Modify the steps to upload the JSON files to the dashboards so
4209         that the GPU tests don't conflict with the regular tests on a
4210         port. We do this by modifying the --builder-name parameter to
4211         append " - GPU", which should cause the app to treat the results
4212         as a completely new builder. This is a little non-obvious, but
4213         keeps us from having to restructure the app.
4214
4215         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4216         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4217         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4218
4219 2010-10-29  Ojan Vafai  <ojan@chromium.org>
4220
4221         Reviewed by Tony Chang.
4222
4223         [chromium] add debug logging to help diagnose flakiness dashboard issues
4224         https://bugs.webkit.org/show_bug.cgi?id=48657
4225
4226         The appengine app thinks it's getting empty files uploaded. Add some logging
4227         to see if new-run-webkit-tests agrees.
4228         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4229
4230 2010-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
4231
4232         Reviewed by Ojan Vafai.
4233
4234         [Chromium/DRT] Add master-name flag to new-run-webkit-tests.
4235         https://bugs.webkit.org/show_bug.cgi?id=48649
4236
4237         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag.
4238
4239 2010-10-29  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
4240
4241         Reviewed by Martin Robinson.
4242
4243         Enable popup window in GtkLauncher
4244         https://bugs.webkit.org/show_bug.cgi?id=48335
4245
4246         The GtkLauncher application does not support opening new window when
4247         a link with "target=_blank" is clicked or similar call to
4248         window.open(). Instead, GtkLauncher does nothing which breaks
4249         navigation of some websites.
4250
4251         * GtkLauncher/main.c:
4252         (activate_uri_entry_cb):
4253         (update_title):
4254         (link_hover_cb):
4255         (notify_title_cb):
4256         (notify_load_status_cb):
4257         (notify_progress_cb):
4258         (destroy_cb):
4259         (go_back_cb):
4260         (go_forward_cb):
4261         (create_web_view_cb):
4262         (web_view_ready_cb):
4263         (close_web_view_cb):
4264         (create_browser):
4265         (create_statusbar):
4266         (create_toolbar):
4267         (create_window):
4268         (main):
4269
4270 2010-10-29  Adam Roben  <aroben@apple.com>
4271
4272         Teach check-webkit-style about WebKit2's idiosyncracies
4273
4274         Fixes <http://webkit.org/b/48638> Style bot complains about a number
4275         of WebKit2 conventions
4276
4277         Reviewed by Anders Carlsson.
4278
4279         * Scripts/webkitpy/style/checker.py: Excluded some rules for various
4280         WebKit2-related files. Also updated the excluded rules for
4281         WebKitAPITest to match the current code.
4282
4283 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
4284
4285         Reviewed by Adam Roben and David Kilzer.
4286
4287         Fix and cleanup of build systems
4288         https://bugs.webkit.org/show_bug.cgi?id=48342
4289
4290         * Scripts/build-webkit:
4291          - Remove unnecessary ENABLE_SANDBOX option.
4292          - Add ENABLE_FULLSCREEN_API option.
4293
4294 2010-10-28  Adam Roben  <aroben@apple.com>
4295
4296         Switch the Windows WebKit2 bot to the Release configuration
4297
4298         We only have one machine testing WebKit2 on Windows right now, and
4299         Debug is just too slow for it to keep up.
4300
4301         Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is
4302         always way behind
4303
4304         Reviewed by Jon Honeycutt.
4305
4306         * BuildSlaveSupport/build.webkit.org-config/config.json:
4307
4308 2010-10-29  Leandro Gracia Gil  <leandrogracia@google.com>
4309
4310         Reviewed by Jeremy Orlow.
4311
4312         Added a second parameter to setMockSpeechInputResult for
4313         the language used in speech input.
4314         https://bugs.webkit.org/show_bug.cgi?id=47089
4315
4316         * DumpRenderTree/LayoutTestController.cpp:
4317         (setMockSpeechInputResultCallback):
4318         * DumpRenderTree/LayoutTestController.h:
4319         * DumpRenderTree/chromium/LayoutTestController.cpp:
4320         (LayoutTestController::setMockSpeechInputResult):
4321         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4322         (LayoutTestController::setMockSpeechInputResult):
4323         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4324         (LayoutTestController::setMockSpeechInputResult):
4325         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4326         (LayoutTestController::setMockSpeechInputResult):