ccdff3ef3de8d6dec2833d8ba538c28e68abc2b7
[WebKit.git] / WebKitTools / ChangeLog
1 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Eric Seidel.
4
5         new-run-webkit-tests: revise unit testing strategy for test failures
6     
7         This change revamps the way we store test data for new-run-webkit-tests.
8         Previously we had a few copies of test files from the main test tree.
9         Now we have a bunch of completely fake test data and use the test
10         data to generate different kinds of test failures, getting
11         much better coverage.
12
13         https://bugs.webkit.org/show_bug.cgi?id=44556
14
15         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
16         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
17         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
18         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
19         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
20         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
21         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
22         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
23         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
24         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
25         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
26         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
27         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
28         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
29         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
30         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
31         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
32         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
33         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
34         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
35         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
36         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
37         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
38         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
39         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
40         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
41         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
42         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
43         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
44         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
45         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
46         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
47         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
48         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
49         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
50         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
51         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
52         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
53         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
54         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
55         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
56         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
57         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
58         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
59         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
60         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
61         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
62         * Scripts/webkitpy/layout_tests/port/test.py:
63         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
64         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
65
66 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
67
68         Reviewed by Eric Seidel.
69
70         speed up new-run-webkit-tests unit tests
71
72         Add a --no-record-results flag that turns off generating the JSON
73         results file on every test run. Generating the file requires us to
74         fetch the old results down from the bots, which can be slow. This
75         flag is off by default.
76     
77         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
78     
79         These changes together shorten the test cycle from ~4.5s to ~1.5s
80         - a 3x speedup.
81
82         https://bugs.webkit.org/show_bug.cgi?id=44553
83
84         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
85         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
86
87 2010-08-24  Tony Chang  <tony@chromium.org>
88
89         Reviewed by Eric Seidel.
90
91         [chromium] fix the platform result fallback order on mac/win
92         https://bugs.webkit.org/show_bug.cgi?id=44483
93
94         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
95
96 2010-08-24  Xan Lopez  <xlopez@igalia.com>
97
98         Reviewed by Martin Robinson.
99
100         Set a device to the event struct when building with GTK+ 3.x, it's
101         mandatory.
102
103         * DumpRenderTree/gtk/EventSender.cpp:
104         (keyDownCallback):
105
106 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
107
108         Reviewed by Xan Lopez.
109
110         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
111         https://bugs.webkit.org/show_bug.cgi?id=44534
112
113         Fix two double-frees introduced in my previous commit.
114
115         * DumpRenderTree/gtk/EventSender.cpp:
116         (contextClickCallback): Copy the event before using it again.
117         (keyDownCallback): Ditto.
118
119 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
120
121         Reviewed by Xan Lopez.
122
123         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
124         https://bugs.webkit.org/show_bug.cgi?id=44534
125
126         * DumpRenderTree/gtk/EventSender.cpp:
127         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
128         when setting it on the event. It is dereferenced by gdk_event_free(...).
129         (contextClickCallback): Ditto.
130         (mouseDownCallback): Ditto.
131         (mouseUpCallback): Ditto.
132         (mouseMoveToCallback): Ditto.
133         (mouseWheelToCallback): Ditto.
134         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
135         (dispatchEvent): Ditto. Also free the event when we are done with it.
136         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
137
138 2010-08-24  Andras Becsi  <abecsi@webkit.org>
139
140         [Qt] WebKit2 build fix.
141
142         * Scripts/enumerate-included-framework-headers:
143         Remove stray global option form sed.
144
145 2010-08-24  Kent Tamura  <tkent@chromium.org>
146
147         Reviewed by Jeremy Orlow.
148
149         [DRT/Chromium] Support for IndexedDB tests
150         https://bugs.webkit.org/show_bug.cgi?id=44490
151
152         * DumpRenderTree/chromium/TestShell.cpp:
153         (TestShell::TestShell): Enable IndexedDB.
154
155 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
156
157         Reviewed by Gustavo Noronha Silva.
158
159         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
160         https://bugs.webkit.org/show_bug.cgi?id=44465
161
162         Initialize the axes field of mouse button and motion events to null.
163         This is the value that should be used for events originating from the
164         mouse device.
165
166         * DumpRenderTree/gtk/EventSender.cpp:
167         (prepareMouseButtonEvent): Initalize button event axes field to null.
168         (mouseMoveToCallback): Initialize motion event axes field to null.
169
170 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
171
172         Unreviewed, rolling out r65703.
173         http://trac.webkit.org/changeset/65703
174         https://bugs.webkit.org/show_bug.cgi?id=44460
175
176         "Causing lots of crashes on Snow Leopard when running the
177         layout tests" (Requested by eseidel2 on #webkit).
178
179         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
180         (NP_Initialize):
181         (NP_GetEntryPoints):
182
183 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
184
185         Layout tests do not run when using WebKitTestRunner in a Debug build.
186         https://bugs.webkit.org/show_bug.cgi?id=44409
187
188         Reviewed by Dan Bernstein.
189
190         * WebKitTestRunner/win/TestControllerWin.cpp:
191         (WTR::TestController::initializeInjectedBundlePath):
192         Use InjectedBundle_debug.dll when building Debug.
193
194 2010-08-23  Xan Lopez  <xlopez@igalia.com>
195
196         Reviewed by Martin Robinson.
197
198         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
199         https://bugs.webkit.org/show_bug.cgi?id=42026
200
201         If a GTK+ 3.x build is present return that as the library to use,
202         otherwise fallback to the GTK+ 2.x build.
203
204         * Scripts/webkitdirs.pm:
205
206 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
207
208         Reviewed by Ariya Hidayat.
209
210         [Qt] Find needed forwarding headers for WebKit2 automatically
211         https://bugs.webkit.org/show_bug.cgi?id=44336
212
213         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
214         The new script does not satisfy the needs of this file however using normal includes
215         is generally better here.
216         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
217         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
218         given frameworks by files in the current directory (and subdirectories).
219         In the future this needs to be rewritten in perl for being able to use on Windows.
220
221 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
222
223         Reviewed by Ariya Hidayat.
224
225         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
226         https://bugs.webkit.org/show_bug.cgi?id=43010
227
228         * QtTestBrowser/launcherwindow.cpp:
229         (LauncherWindow::applyPrefs):
230         * QtTestBrowser/main.cpp:
231         (LauncherApplication::handleUserOptions):
232
233 2010-08-21  Sam Weinig  <sam@webkit.org>
234
235         Reviewed by Dan Bernstein.
236
237         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
238         https://bugs.webkit.org/show_bug.cgi?id=44386
239
240         * MiniBrowser/mac/AppDelegate.m:
241         (didRecieveMessageFromInjectedBundle):
242         (didNavigateWithNavigationData):
243         (-[BrowserAppDelegate init]):
244         (-[BrowserAppDelegate applicationWillTerminate:]):
245         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
246         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
247         (-[BrowserStatisticsWindowController dealloc]):
248         * MiniBrowser/mac/BrowserWindowController.m:
249         (-[BrowserWindowController initWithPageNamespace:]):
250         (-[BrowserWindowController fetch:]):
251         (-[BrowserWindowController windowWillClose:]):
252         (-[BrowserWindowController applicationTerminating]):
253         (closePage):
254         (runJavaScriptAlert):
255         (runJavaScriptConfirm):
256         (runJavaScriptPrompt):
257         (-[BrowserWindowController updateProvisionalURLForFrame:]):
258         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
259         (didClearWindowObjectForFrame):
260         * MiniBrowser/win/BrowserView.cpp:
261         (BrowserView::goToURL):
262         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
263         (WTR::PlatformWebView::~PlatformWebView):
264
265 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
266
267         Reviewed by Kenneth Rohde Christiansen.
268
269         WebKit does not build with Python 2.3
270         https://bugs.webkit.org/show_bug.cgi?id=44373
271
272         Replaced the function sorted() by a call to sort()
273         on the entry list.
274         The function sorted() has been added to Python 2.4.
275         The function method sort() of List works with older
276         versions of Python.
277
278         * Scripts/create-html-entity-table:
279
280 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
281
282         Reviewed by Pavel Feldman.
283
284         Web Inspector: Inspector tests were disabled for GTK.
285         https://bugs.webkit.org/show_bug.cgi?id=43977
286
287         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
288         path before running tests.
289
290 2010-08-20  Daniel Bates  <dbates@rim.com>
291
292         Reviewed by Eric Seidel.
293
294         svn-apply doesn't detect empty line with Windows line endings
295         after property value
296         https://bugs.webkit.org/show_bug.cgi?id=43981
297
298         Part 2 of 2
299
300         Add unit tests that were not landed in the first commit.
301
302         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
303           - Added the following test cases:
304             "SVN: binary file (isBinary true) using Windows line endings"
305             "SVN: property diff, followed by file change diff using Windows line endings"
306             "SVN: two consecutive property diffs using Windows line endings"
307             "SVN: binary file with executable bit change usng Windows line endings"
308             "SVN: binary file followed by property change on different file using Windows line endings"
309             "SVN: binary file followed by file change on different file using Windows line endings"
310             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
311             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
312         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
313           - Added the following test cases:
314             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
315             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
316             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
317             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
318             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
319             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
320             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
321             "single-line '+' with trailing new line using Windows line endings"
322             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
323             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
324             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
325         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
326           - Added the following test cases:
327             "single-line '-' change followed by empty line with Windows line endings"
328             "multi-line '+' change and start of binary patch with Windows line endings"
329
330 2010-08-20  Daniel Bates  <dbates@rim.com>
331
332         Reviewed by Eric Seidel.
333
334         svn-apply doesn't detect empty line with Windows line endings
335         after property value
336         https://bugs.webkit.org/show_bug.cgi?id=43981
337
338         Fixes an issue where an empty line following the property value
339         in an SVN property change diff would not be detected if it had
340         Windows line endings (i.e. ended in CRLF). Hence it was consumed
341         as if it was part of a multi-line property value. 
342
343         * Scripts/VCSUtils.pm:
344           - Modified parseSvnPropertyValue() to detect empty line
345             with Windows line endings.
346           - Added toWindowsLineEndings().
347         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
348           - Added the following test cases:
349             "SVN: binary file (isBinary true) using Windows line endings"
350             "SVN: property diff, followed by file change diff using Windows line endings"
351             "SVN: two consecutive property diffs using Windows line endings"
352             "SVN: binary file with executable bit change usng Windows line endings"
353             "SVN: binary file followed by property change on different file using Windows line endings"
354             "SVN: binary file followed by file change on different file using Windows line endings"
355             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
356             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
357         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
358           - Added the following test cases:
359             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
360             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
361             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
362             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
363             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
364             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
365             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
366             "single-line '+' with trailing new line using Windows line endings"
367             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
368             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
369             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
370         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
371           - Added the following test cases:
372             "single-line '-' change followed by empty line with Windows line endings"
373             "multi-line '+' change and start of binary patch with Windows line endings"
374
375 2010-08-19  David Kilzer  <ddkilzer@apple.com>
376
377         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
378
379         * MiniBrowser/mac/BrowserWindowController.m:
380         (decidePolicyForNavigationAction): Updated method signature.
381         (decidePolicyForNewWindowAction): Updated method signature.
382
383 2010-08-19  Adam Roben  <aroben@apple.com>
384
385         Test that NP_Initialize and NP_GetEntryPoints are called in the
386         correct order
387
388         The order differs between Mac and Windows (see r38858).
389
390         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
391         NP_Initialize when loading QuickTime when running
392         plugins/embed-attributes-setting.html in WebKit2 on Windows
393
394         Reviewed by Sam Weinig.
395
396         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
397         a boolean to record whether NP_GetEntryPoints has been called.
398         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
399         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
400         if NP_GetEntryPoints has been called already. This matches
401         Silverlight's behavior.
402
403 2010-08-19  Adam Roben  <aroben@apple.com>
404
405         Make build-webkittestrunner build TestNetscapePlugIn on Windows
406
407         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
408
409         Reviewed by Sam Weinig.
410
411         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
412         Threaded it in between ImageDiff and InjectedBundleGenerated.
413
414 2010-08-19  Ojan Vafai  <ojan@chromium.org>
415
416         Reviewed by Adam Barth.
417
418         install rietveld's upload script from a versioned url
419         https://bugs.webkit.org/show_bug.cgi?id=44291
420
421         autoinstall expects the file at a given URL to never change.
422         In order to be able to update the file, we need to be able to
423         change the path.
424
425         * Scripts/webkitpy/thirdparty/__init__.py:
426
427 2010-08-19  Ojan Vafai  <ojan@chromium.org>
428
429         Reviewed by Adam Barth.
430
431         add --webkit_patch_id to reitveld uploads
432         https://bugs.webkit.org/show_bug.cgi?id=44289
433
434         This is the first step in having rietveld store which
435         patches have been uploaded and getting rid of the
436         in-rietveld flag.
437
438         * Scripts/webkitpy/common/net/rietveld.py:
439         * Scripts/webkitpy/tool/mocktool.py:
440         * Scripts/webkitpy/tool/steps/postcodereview.py:
441
442 2010-08-19  Kenneth Russell  <kbr@google.com>
443
444         Reviewed by David Levin.
445
446         Adjust my status from committer to reviewer
447         https://bugs.webkit.org/show_bug.cgi?id=44277
448
449         * Scripts/webkitpy/common/config/committers.py:
450
451 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
452
453         Reviewed by Yury Semikhatsky.
454
455         Chromium DevTools: remove injected script fetcher from test harness.
456         https://bugs.webkit.org/show_bug.cgi?id=44266
457
458         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
459         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
460
461 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
462
463         Reviewed by Yury Semikhatsky.
464
465         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
466         Now that we populate front-end after its onload handler, we don't need
467         to install injected script early. Exposing injected script source on the WebCore
468         level here.
469         https://bugs.webkit.org/show_bug.cgi?id=44029
470
471         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
472         (DRTDevToolsAgent::runtimePropertyChanged):
473         (DRTDevToolsAgent::delayedFrontendLoaded):
474         (DRTDevToolsAgent::frontendLoaded):
475         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
476
477 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
478
479         Reviewed by Kenneth Rohde Christiansen.
480
481         [Gtk] Enable view mode media feature layout test
482         https://bugs.webkit.org/show_bug.cgi?id=43278
483
484         Add view mode media feature testing infrastructure, and add
485         placeholder methods for the other platforms'
486         LayoutTestControllers.
487
488         * DumpRenderTree/LayoutTestController.cpp:
489         (setViewModeMediaFeatureCallback):
490         (LayoutTestController::staticFunctions):
491         * DumpRenderTree/LayoutTestController.h:
492         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
493         (LayoutTestController::setViewModeMediaFeature):
494         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
495         (LayoutTestController::setViewModeMediaFeature):
496         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
497         (LayoutTestController::setViewModeMediaFeature):
498         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
499         (LayoutTestController::setViewModeMediaFeature):
500
501 2010-08-18  Mark Rowe  <mrowe@apple.com>
502
503         Reviewed by Sam Weinig.
504
505         Make it so the WebKit2 test slave runs the WebKit2 tests
506
507         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
508
509 2010-08-18  Sam Weinig  <sam@webkit.org>
510
511         Reviewed by Mark Rowe.
512
513         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
514         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
515         module and the TestNetscapePlugin.
516
517         * Scripts/old-run-webkit-tests:
518
519 2010-08-18  Adam Roben  <aroben@apple.com>
520
521         Fix hang when saving crash logs on Windows
522
523         * Scripts/old-run-webkit-tests:
524         (setUpWindowsCrashLogSaving):
525         (END):
526         Pass -s to regtool so it will write the Auto value as a string instead
527         of as a number. This was causing a "do you want to debug?" dialog to
528         appear.
529
530 2010-08-17  Victor Wang  <victorw@chromium.org>
531
532         Unreviewed. Fixed chromium incremental test json upload.
533         Quote builder name and test results server in url.
534
535         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
536
537 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
538
539         Reviewed by Ariya Hidayat.
540
541         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
542         https://bugs.webkit.org/show_bug.cgi?id=44124
543
544         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
545         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
546         Symbian dependencies.
547
548         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
549         (WebCore::DumpRenderTree::open):
550         * QtTestBrowser/launcherwindow.cpp:
551         (LauncherWindow::init):
552         (LauncherWindow::toggleFullScreenMode):
553         (LauncherWindow::showFPS):
554         (LauncherWindow::updateFPS):
555         * QtTestBrowser/launcherwindow.h:
556         (WindowOptions::WindowOptions):
557         * QtTestBrowser/mainwindow.cpp:
558         (MainWindow::buildUI):
559
560 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
561
562         Reviewed by David Levin.
563
564         new-run-webkit-tests: remove --show-sources option
565
566         --show-sources is pretty much obsolete with --trace everything, so
567         I'm removing it.
568
569         Also rename a couple of methods in the TestTextDiff class to make their
570         intended visibility (private) more obvious.
571
572         https://bugs.webkit.org/show_bug.cgi?id=44143
573
574         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
575         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
576         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
577         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
578         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
579
580 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
581
582         Reviewed by David Levin.
583
584         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
585
586         This code bit-rotted at some point more than a year ago, and nobody seems
587         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
588         should support instead, making this flag unnecessary anyway.
589
590         https://bugs.webkit.org/show_bug.cgi?id=44141
591
592         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
593         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
594         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
595
596 2010-08-17  Victor Wang  <victorw@chromium.org>
597
598         Reviewed by Ojan Vafai.
599
600         Update json results generator to have incremental json including
601         results for tests that pass in current run but failed before.
602
603         https://bugs.webkit.org/show_bug.cgi?id=44119
604
605         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
606         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
607         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
608
609 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
610
611         Reviewed by Eric Seidel.
612
613         fix test-webkitpy, add easy way to find a checkout root
614
615         test-webkitpy currently doesn't work right if run from someplace other
616         than the checkout root, and it spews a bunch of debug logging because
617         the deduplicate_tests tests contaminates the test environment.
618
619         This patch cleans up the deduplicate_tests unit tests, and creates
620         two new methods in scm.py: find_checkout_root() and default_scm(),
621         both of which use a single algorithm for guessing what checkout root
622         to use if you aren't explicitly told one from a path.
623
624         https://bugs.webkit.org/show_bug.cgi?id=44001
625
626         * Scripts/deduplicate-tests:
627         * Scripts/webkitpy/common/checkout/scm.py:
628         * Scripts/webkitpy/common/checkout/scm_unittest.py:
629         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
630         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
631         * Scripts/webkitpy/layout_tests/port/test.py:
632         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
633         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
634         * Scripts/webkitpy/tool/main.py:
635
636 2010-08-17  Victor Wang  <victorw@chromium.org>
637
638         Reviewed by Ojan Vafai.
639
640         Add support to the test results server for downloading json that
641         contains test list only.
642
643         This is for json results generator to generate incremental json
644         results so that it includes results not only for tests failed in
645         current run, but also tests failed before.
646
647         Also set the results type to "N" (no data) instead of "P" (pass)
648         if test results cannot be found in incremental json file.
649
650         https://bugs.webkit.org/show_bug.cgi?id=44117
651
652         * TestResultServer/handlers/testfilehandler.py:
653         * TestResultServer/model/jsonresults.py:
654         * TestResultServer/model/jsonresults_unittest.py:
655
656 2010-08-17  Adam Roben  <aroben@apple.com>
657
658         Use the right path style
659
660         * Scripts/old-run-webkit-tests:
661
662 2010-08-17  Adam Roben  <aroben@apple.com>
663
664         Fix typo
665
666         * Scripts/old-run-webkit-tests:
667
668 2010-08-17  Adam Roben  <aroben@apple.com>
669
670         Don't hang when running run-webkit-tests as a non-Administrator on
671         Vista/7
672
673         * Scripts/old-run-webkit-tests:
674         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
675         post-mortem debugger, rather than using NTSD itself. The latter waits
676         for user input when it fails to set the registry values; the former
677         does not.
678
679 2010-08-17  Adam Roben  <aroben@apple.com>
680
681         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
682         save crash logs on Windows
683
684         The crash logs are saved to /tmp/layout-test-results and have names
685         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
686
687         Unfortunately, crashes in the WebKit2 web process are recorded as
688         time-outs by run-webkit-tests. Fixing this is covered by
689         <http://webkit.org/b/44121>.
690
691         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
692         DumpRenderTree should save a stack trace and/or dump file when it
693         crashes
694
695         Reviewed by Sam Weinig.
696
697         * DumpRenderTree/win/DumpRenderTree.cpp:
698         (exceptionFilter):
699         (main):
700         * WebKitTestRunner/win/TestControllerWin.cpp:
701         (WTR::exceptionFilter):
702         (WTR::TestController::platformInitialize):
703         These changes set up an exception filter that prints #CRASHED to
704         stderr, then lets the exception propagate normally. This allows
705         run-webkit-tests to detect when we've crashed even when a post-mortem
706         debugger attaches to the process.
707
708         * Scripts/old-run-webkit-tests:
709         (top level): Declared some variables used by the crash-log-saving
710         code.
711         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
712         that the post-mortem debugger has access to it.
713         (toCygwinPath): Added. This is the opposite of toWindowsPath.
714         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
715         stderr, consider it a crash.
716         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
717         debugger, then sets ntsd as the post-mortem debugger. ntsd is
718         configured to save a crash log and then quit automatically.
719         (END): Added. Restores the previous post-mortem debugger when the
720         script exits.
721
722 2010-08-17  Victor Wang  <victorw@chromium.org>
723
724         Reviewed by ojan@chromium.org.
725
726         Update test results server:
727         1. Normalize test results and times after merging (prune tests where
728            all runs pass or do not have data, truncate all test items to max
729            number of builds)
730         2. times should be int not string.
731         3. when inserting a new test item, should keep old data regardless
732            whether or not they have same item type with new one.
733
734         https://bugs.webkit.org/show_bug.cgi?id=43861
735
736         * TestResultServer/model/jsonresults.py:
737         * TestResultServer/model/jsonresults_unittest.py:
738
739 2010-08-16  Sam Weinig  <sam@webkit.org>
740
741         Reviewed by Mark Rowe.
742
743         Add WebKit2 Mac tester to buildbot.
744
745         * BuildSlaveSupport/build.webkit.org-config/config.json:
746         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
747
748 2010-08-16  Paul Sawaya  <psawaya@apple.com>
749
750         Reviewed by Chris Marrin.
751
752         Added shader validation via ANGLE
753         https://bugs.webkit.org/show_bug.cgi?id=42405
754
755         Added ANGLE to webkit build
756
757         * Scripts/build-webkit:
758
759 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
760
761         [wx] Build fix, do not build WebCore as a convenience library as this leads to
762         errors in the Win build w/export symbols and causes problems with DOM bindings
763         debugging in gdb.
764
765         * DumpRenderTree/wscript:
766         * Scripts/build-webkit:
767         * wx/browser/wscript:
768         * wx/build/settings.py:
769         * wx/build/waf_extensions.py:
770
771 2010-08-16  Dan Bernstein  <mitz@apple.com>
772
773         Build fix.
774
775         * WebKitTestRunner/TestController.cpp:
776         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
777         (WTR::TestController::initialize): Ditto.
778
779 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
780
781         Reviewed by Kenneth Rohde Christiansen.
782
783         Handle content size change in WebKit2
784         Re-landing after fix.
785
786         https://bugs.webkit.org/show_bug.cgi?id=43198
787
788         * MiniBrowser/mac/BrowserWindowController.m:
789         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
790         * MiniBrowser/win/BrowserView.cpp:
791         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
792
793 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
794
795         Unreviewed, rolling out r65419.
796         http://trac.webkit.org/changeset/65419
797         https://bugs.webkit.org/show_bug.cgi?id=44053
798
799         Broke the Windows build (Requested by bbandix on #webkit).
800
801         * MiniBrowser/mac/BrowserWindowController.m:
802         (-[BrowserWindowController awakeFromNib]):
803         * MiniBrowser/win/BrowserView.cpp:
804         (BrowserView::create):
805
806 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
807
808         Reviewed by Kenneth Rohde Christiansen.
809
810         Handle content size change in WebKit2
811
812         https://bugs.webkit.org/show_bug.cgi?id=43198
813
814         * MiniBrowser/mac/BrowserWindowController.m:
815         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
816         * MiniBrowser/win/BrowserView.cpp:
817         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
818
819 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
820
821         Add my new email address to committers.py.
822
823         * Scripts/webkitpy/common/config/committers.py:
824
825 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
826
827         Add my old e-mail addresses to committers.py.
828
829         * Scripts/webkitpy/common/config/committers.py:
830
831 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
832
833         WebEditorClient::didBeginEditing is never called in WebKit2
834         https://bugs.webkit.org/show_bug.cgi?id=42939
835
836         Reviewed by Sam Weinig.
837
838         * WebKitTestRunner/PlatformWebView.h:
839         Declare focus().
840
841         * WebKitTestRunner/TestController.cpp:
842         (WTR::TestController::resetStateToConsistentValues):
843         Focus the PlatformWebView.
844
845         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
846         (WTR::PlatformWebView::focus):
847         Stubbed.
848
849         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
850         (WTR::PlatformWebView::focus):
851         Focus the view.
852
853 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
854
855         run-webkit-tests should not strip editing callbacks when using
856         WebKitTestRunner on Windows
857         https://bugs.webkit.org/show_bug.cgi?id=44000
858
859         Reviewed by Mark Rowe.
860
861         * Scripts/old-run-webkit-tests:
862         Leave $stripEditingCallbacks undefined until we look for command-line
863         arguments. If using WebKit2, set it to 0 if not explicity set on the
864         command line. Later, set it to isCygwin() to match old behavior if it is
865         not yet defined.
866
867 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
868
869         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
870
871         * wx/build/settings.py:
872
873 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
874
875         Reviewed by Kenneth Rohde Christiansen.
876
877         [GTK] autogen.sh not executed if build-webkit options change
878         https://bugs.webkit.org/show_bug.cgi?id=42266
879
880         Rerun autogen.sh in situations where the arguments to build-webkit have
881         changed since the previous build. This will fix some issues on the bots
882         where the build does not notice changes to default build-webkit arguments.
883
884         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
885
886 2010-08-14  Eric Seidel  <eric@webkit.org>
887
888         Unreviewed.  Another fix to support python 2.3.
889
890         Add support for MathML entities
891         https://bugs.webkit.org/show_bug.cgi?id=43949
892
893         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
894          - It looks like our simplejson is version 1.7.3 which
895            should be python 2.3 compatible.  But someone modified
896            our copy slightly from the original source.
897            I've removed the relative import in hopes this fixes
898            the problem.
899
900 2010-08-13  Eric Seidel  <eric@webkit.org>
901
902         Unreviewed.  Build fix only.
903
904         Add support for MathML entities
905         https://bugs.webkit.org/show_bug.cgi?id=43949
906
907         * Scripts/create-html-entity-table:
908          - Hack sys.path to avoid executing 2.5 dependent python
909            on systems (like chromium-win and Tiger) which do not have 2.5 python.
910
911 2010-08-13  Adam Barth  <abarth@webkit.org>
912
913         Reviewed by Eric Seidel.
914
915         Rename some concepts in HTML entity search to be more self-documenting
916         https://bugs.webkit.org/show_bug.cgi?id=44004
917
918         Reflect name change in generator script.
919
920         * Scripts/create-html-entity-table:
921
922 2010-08-12  Adam Barth  <abarth@webkit.org>
923
924         Reviewed by Eric Seidel.
925
926         Add support for MathML entities
927         https://bugs.webkit.org/show_bug.cgi?id=43949
928
929         A script for generating the C++ state data structure describing all the
930         entities from a JSON description.
931
932         * Scripts/create-html-entity-table: Added.
933
934 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
935
936         Reviewed by Eric Seidel.
937
938         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
939         check for exceptions on all threads, not just the first thread.
940         
941         This change also changes the logging behavior for wedged threads
942         to only dump the stacks of threads that are actually wedged.
943
944         Refactor the thread classes in the dump_render_tree_thread module
945         to make the contract between TestRunner and TestShellThread clearer.
946
947         Added a bunch of unit tests.
948         https://bugs.webkit.org/show_bug.cgi?id=38561
949
950         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
951         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
952         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
953
954 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
955
956         Reviewed by Shinichiro Hamaji.
957
958         Add test_expectations.txt syntax checker to check-webkit-style.
959         https://bugs.webkit.org/show_bug.cgi?id=43899
960
961         Just utilizing layout_tests/layout_package/test_expectations.py for checking
962         the syntax of test_expectations.txt.
963         This change also moves tab checking class from style/checkers/text.py to
964         style/checkers/common.py for sharing code.
965
966         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
967         * Scripts/webkitpy/style/checker.py:
968         * Scripts/webkitpy/style/checkers/common.py:
969         * Scripts/webkitpy/style/checkers/common_unittest.py:
970         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
971         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
972         * Scripts/webkitpy/style/checkers/text.py:
973         * Scripts/webkitpy/style_references.py:
974
975 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
976
977         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
978         https://bugs.webkit.org/show_bug.cgi?id=43945
979
980         Reviewed by Sam Weinig.
981
982         * WebKitTestRunner/TestInvocation.cpp:
983         (WTR::sizeWebViewForCurrentTest):
984         Allow for a Windows-style path.
985
986         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
987         (WTR::PlatformWebView::resizeTo):
988         Call SetWindowPos to resize the view window.
989
990 2010-08-12  David Levin  <levin@chromium.org>
991
992         Build break fix.
993
994         * WebKitTestRunner/TestController.cpp:
995         (WTR::TestController::resetStateToConsistentValues): Removed usage
996         of a variable that doesn't exist in the class.
997
998 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
999
1000         WebKitTestRunner needs to run tests without using native controls
1001         https://bugs.webkit.org/show_bug.cgi?id=43772
1002
1003         Reviewed by Sam Weinig.
1004
1005         * WebKitTestRunner/TestController.cpp:
1006         (WTR::TestController::initialize):
1007         Call platformInitializeContext().
1008
1009         * WebKitTestRunner/TestController.h:
1010         Declare platformInitializeContext().
1011
1012         * WebKitTestRunner/mac/TestControllerMac.mm:
1013         (WTR::TestController::platformInitializeContext):
1014         Stubbed.
1015
1016         * WebKitTestRunner/win/TestControllerWin.cpp:
1017         (WTR::TestController::platformInitializeContext):
1018         Call WKContextSetShouldPaintNativeControls() to disable native control
1019         drawing.
1020
1021 2010-08-12  Sam Weinig  <sam@webkit.org>
1022
1023         Reviewed by Alexey Proskuryakov.
1024
1025         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
1026         https://bugs.webkit.org/show_bug.cgi?id=43653
1027
1028         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1029         (WTR::InjectedBundle::InjectedBundle):
1030         (WTR::InjectedBundle::didReceiveMessage):
1031         (WTR::InjectedBundle::beginTesting):
1032         (WTR::InjectedBundle::done):
1033         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1034         (WTR::InjectedBundle::isTestRunning):
1035         (WTR::InjectedBundle::):
1036         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1037         (WTR::InjectedBundlePage::stopLoading):
1038         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1039         (WTR::InjectedBundlePage::dump):
1040         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1041         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1042         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1043         (WTR::InjectedBundlePage::didClearWindowForFrame):
1044         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1045         (WTR::InjectedBundlePage::willAddMessageToConsole):
1046         (WTR::InjectedBundlePage::willSetStatusbarText):
1047         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1048         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1049         (WTR::InjectedBundlePage::shouldBeginEditing):
1050         (WTR::InjectedBundlePage::shouldEndEditing):
1051         (WTR::InjectedBundlePage::shouldInsertNode):
1052         (WTR::InjectedBundlePage::shouldInsertText):
1053         (WTR::InjectedBundlePage::shouldDeleteRange):
1054         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1055         (WTR::InjectedBundlePage::shouldApplyStyle):
1056         (WTR::InjectedBundlePage::didBeginEditing):
1057         (WTR::InjectedBundlePage::didEndEditing):
1058         (WTR::InjectedBundlePage::didChange):
1059         (WTR::InjectedBundlePage::didChangeSelection):
1060         Don't do any work if we are not currently running a test.
1061
1062         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1063         * WebKitTestRunner/StringFunctions.h:
1064         (WTR::toCF):
1065         Add conversion function for WKURLRef -> CFURLRef
1066
1067         * WebKitTestRunner/TestController.cpp:
1068         (WTR::TestController::TestController):
1069         (WTR::TestController::initialize):
1070         (WTR::TestController::resetStateToConsistentValues):
1071         (WTR::TestController::runTest):
1072         (WTR::TestController::didFinishLoadForFrame):
1073         * WebKitTestRunner/TestController.h:
1074         (WTR::TestController::):
1075         * WebKitTestRunner/TestInvocation.cpp:
1076         (WTR::TestInvocation::invoke):
1077         * WebKitTestRunner/TestInvocation.h:
1078         Move resetting code to TestController.
1079
1080         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1081         * WebKitTestRunner/mac/TestControllerMac.mm:
1082         (WTR::TestController::runUntil):
1083         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1084         * WebKitTestRunner/win/TestControllerWin.cpp:
1085         (WTR::TestController::runUntil):
1086         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
1087         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1088         Move runUntil to TestController.
1089
1090 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1091
1092         Unreviewed.
1093
1094         Adding myself to the committers list.
1095
1096         * Scripts/webkitpy/common/config/committers.py:
1097
1098 2010-08-12  Hayato Ito  <hayato@chromium.org>
1099
1100         Reviewed by Tony Chang.
1101
1102         Merge pretty printers for gdb.
1103         https://bugs.webkit.org/show_bug.cgi?id=43850
1104
1105         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
1106         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
1107         webcore.py is left for backward compatibility.
1108
1109         * gdb/webcore.py:
1110         * gdb/webkit.py: Added.
1111         * gdb/wtf.py: Removed.
1112
1113 2010-08-11  Tony Chang  <tony@chromium.org>
1114
1115         Reviewed by David Levin.
1116
1117         [chromium] add google-chrome layout test result directories
1118         https://bugs.webkit.org/show_bug.cgi?id=43889
1119
1120         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1121         * Scripts/webkitpy/layout_tests/port/factory.py:
1122         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
1123         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1124
1125 2010-08-11  Kent Tamura  <tkent@chromium.org>
1126
1127         Reviewed by Dimitri Glazkov.
1128
1129         [DRT/Chromium] Disable accelerated compositing
1130         https://bugs.webkit.org/show_bug.cgi?id=43894
1131
1132         Disable accelerated compositing because DRT is not ready for
1133         it. This change fixes hundreds of test crashes on Windows and
1134         Linux.
1135
1136         * DumpRenderTree/chromium/TestShell.cpp:
1137         (TestShell::resetWebSettings):
1138
1139 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1140
1141         Unreviewed. Adding my Collabora personality to the list.
1142
1143         * Scripts/webkitpy/common/config/committers.py:
1144
1145 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
1146
1147         Adding myself as a reviewer.
1148
1149         * Scripts/webkitpy/common/config/committers.py:
1150
1151 2010-08-11  Daniel Bates  <dbates@rim.com>
1152
1153         Reviewed by Darin Adler.
1154
1155         Perl warnings when running commit-log-editor
1156         https://bugs.webkit.org/show_bug.cgi?id=43856
1157
1158         Fixes Perl warnings introduced by the patch for Bug #40548.
1159
1160         Perl doesn't have symbolic names for True/False. Instead, we
1161         should use boolean values. Moreover, the variable installedEditorApplication
1162         is not be used and should be renamed builtEditorApplication so that it
1163         uses the existing machinery to set the commit log editor application.
1164
1165         * Scripts/commit-log-editor:
1166
1167 2010-08-11  Adam Barth  <abarth@webkit.org>
1168
1169         Reviewed by Eric Seidel.
1170
1171         Trying waiting for httpd lock in the EWS
1172         https://bugs.webkit.org/show_bug.cgi?id=43833
1173
1174         If this works, we can probably run the tests on the mac-ews, which
1175         would be very exciting.  :)
1176
1177         * Scripts/webkitpy/tool/steps/runtests.py:
1178
1179 2010-08-11  Marcus Bulach  <bulach@chromium.org>
1180
1181         Reviewed by Eric Seidel.
1182
1183         Check in a script to list redundant test outputs.
1184         https://bugs.webkit.org/show_bug.cgi?id=37630
1185
1186         If e.g. platform/mac-leopard is missing an expected test output, we
1187         fall back on platform/mac.  This means it's possible to grow redundant
1188         test outputs, where we have the same expected data in both a platform
1189         directory and another platform it falls back on.
1190         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
1191
1192         * Scripts/deduplicate-tests: Added.
1193         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
1194         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
1195
1196 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1197
1198         Reviewed by Ariya Hidayat.
1199
1200         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
1201         https://bugs.webkit.org/show_bug.cgi?id=43853
1202
1203         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
1204         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
1205         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
1206         to slots at all.
1207
1208         * QtTestBrowser/launcherwindow.cpp:
1209         (LauncherWindow::createChrome):
1210         (LauncherWindow::animatedFlip):
1211         (LauncherWindow::animatedYFlip):
1212         * QtTestBrowser/launcherwindow.h:
1213
1214 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1215
1216         Reviewed by Simon Hausmann.
1217
1218         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
1219         https://bugs.webkit.org/show_bug.cgi?id=43851
1220
1221         All window options data (including the bool holding if the view is either QWebView or
1222         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
1223         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
1224         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
1225         getting broken.
1226
1227         Patch addresses this issue.
1228
1229         * QtTestBrowser/launcherwindow.cpp:
1230         (LauncherWindow::createChrome):
1231         (LauncherWindow::toggleWebView):
1232         (LauncherWindow::toggleAcceleratedCompositing):
1233
1234 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
1235
1236         Reviewed by Ariya Hidayat.
1237
1238         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
1239         https://bugs.webkit.org/show_bug.cgi?id=43831
1240
1241         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
1242
1243         * QtTestBrowser/webview.cpp:
1244         (WebViewGraphicsBased::WebViewGraphicsBased):
1245         (WebViewGraphicsBased::animatedYFlip):
1246
1247 2010-08-11  Darin Adler  <darin@apple.com>
1248
1249         Reviewed by John Sullivan.
1250
1251         Improved editor options for prepare-ChangeLog and commit-log-editor
1252         https://bugs.webkit.org/show_bug.cgi?id=40548
1253
1254         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
1255         values like "xed --launch --wait" work properly.
1256
1257         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
1258         use a command line tool with the $openChangeLogs feature.
1259
1260 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
1261
1262         Reviewed by Pavel Feldman.
1263
1264         Web Inspector: remove InjectDispatch.js
1265         https://bugs.webkit.org/show_bug.cgi?id=43835
1266
1267         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1268         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1269
1270 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
1271
1272         Reviewed by Eric Seidel.
1273
1274         webkit-patch should refuse to run under Win32 Python
1275         https://bugs.webkit.org/show_bug.cgi?id=40962
1276
1277         Given that there are lots of places in webkit-patch's code that
1278         assume unix-style filenames (forward slashes), webkit-patch fails
1279         with weird file-not-found errors when run under a native windows
1280         Python. It would be nice if we just trapped this and errored out
1281         at the beginning, rather than producing unpredictable errors.
1282
1283         * Scripts/webkit-patch:
1284
1285 2010-08-10  Kent Tamura  <tkent@chromium.org>
1286
1287         Unreviewed, build fix.
1288         
1289         Chromium build fix for r65107.
1290
1291         * DumpRenderTree/chromium/LayoutTestController.cpp:
1292         (LayoutTestController::suspendAnimations):
1293         (LayoutTestController::resumeAnimations):
1294
1295 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
1296
1297         Reviewed by Xan Lopez.
1298
1299         [GTK] http/tests/media/video-cookie.html fails
1300         https://bugs.webkit.org/show_bug.cgi?id=42240
1301
1302         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1303         (LayoutTestController::setAlwaysAcceptCookies): create the
1304         SoupCookieJar if it does not exist. Otherwise the accept policy
1305         won't be set.
1306
1307 2010-08-10  Chris Marrin  <cmarrin@apple.com>
1308
1309         Reviewed by Oliver Hunt.
1310
1311         Add suspendAnimations/resumeAnimation API to DRT
1312         https://bugs.webkit.org/show_bug.cgi?id=43733
1313         
1314         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
1315         Calls functions with the same names on AnimationController for the 
1316         mainFrame.
1317
1318         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1319         * DumpRenderTree/LayoutTestController.cpp:
1320         (suspendAnimationsCallback):
1321         (resumeAnimationsCallback):
1322         (LayoutTestController::staticFunctions):
1323         * DumpRenderTree/LayoutTestController.h:
1324         * DumpRenderTree/chromium/LayoutTestController.cpp:
1325         (LayoutTestController::LayoutTestController):
1326         (LayoutTestController::suspendAnimations):
1327         (LayoutTestController::resumeAnimations):
1328         * DumpRenderTree/chromium/LayoutTestController.h:
1329         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1330         (LayoutTestController::suspendAnimations):
1331         (LayoutTestController::resumeAnimations):
1332         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1333         (LayoutTestController::suspendAnimations):
1334         (LayoutTestController::resumeAnimations):
1335         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1336         (LayoutTestController::suspendAnimations):
1337         (LayoutTestController::resumeAnimations):
1338         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1339         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1340         (LayoutTestController::suspendAnimations):
1341         (LayoutTestController::resumeAnimations):
1342         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1343         (LayoutTestController::suspendAnimations):
1344         (LayoutTestController::resumeAnimations):
1345
1346 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1347
1348         Reviewed by Ojan Vafai.
1349
1350         [Chromium/DRT] Enable saving layout test results.
1351         https://bugs.webkit.org/show_bug.cgi?id=43796
1352
1353         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
1354             parameters to the new-run-webkit-tests, including the name
1355             of the test results server.
1356
1357 2010-08-10  Jian Li  <jianli@chromium.org>
1358
1359         More chromium build fix.
1360
1361         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1362         (MockSpellCheck::spellCheckWord):
1363         (MockSpellCheck::initializeIfNeeded):
1364         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1365         (NotificationPresenter::grantPermission):
1366         (NotificationPresenter::show):
1367         (NotificationPresenter::checkPermission):
1368
1369 2010-08-10  Jian Li  <jianli@chromium.org>
1370
1371         Chromium build fix.
1372
1373         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1374         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1375
1376 2010-08-10  Victor Wang  <victorw@chromium.org>
1377
1378         Reviewed by Ojan Vafai.
1379
1380         Update test results server merge logic so the aggregated
1381         results and times are updated for tests that are
1382         in aggragated json but not in incremental json.
1383
1384         Also update unittest to test this case.
1385
1386         https://bugs.webkit.org/show_bug.cgi?id=43769
1387
1388         * TestResultServer/model/jsonresults.py:
1389         * TestResultServer/model/jsonresults_unittest.py:
1390
1391 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1392
1393         Reviewed by Ariya Hidayat.
1394
1395         [Qt] QtTestBrowser: proper set scene rect
1396
1397         When resizesToContents is ON scene's rect is set to the boundary of
1398         the mainFrame. However, navigating to other web page should keep resizing
1399         scene's rect according to the new document loaded. Patch addresses this issue.
1400
1401         Now resizesToContents and scrolling properly work on QtTestBrowser.
1402
1403         * QtTestBrowser/webview.cpp:
1404         (WebViewGraphicsBased::setPage):
1405         (WebViewGraphicsBased::contentsSizeChanged):
1406         (WebViewGraphicsBased::setResizesToContents):
1407         (WebViewGraphicsBased::resizeEvent):
1408         * QtTestBrowser/webview.h:
1409
1410 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1411
1412         Reviewed by Ariya Hidayat.
1413
1414         [Qt] QtTestBrowser: Clean up LauncherWindow code.
1415
1416         * QtTestBrowser/launcherwindow.cpp:
1417         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
1418         (LauncherWindow::init): Fixed comments.
1419         (LauncherWindow::applyPrefs): Move the method around.
1420         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
1421
1422 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1423
1424         Reviewed by Ariya Hidayat.
1425
1426         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
1427
1428         It gets control+0 the same visual effect as control++ or control-.
1429
1430         * QtTestBrowser/launcherwindow.cpp:
1431         (LauncherWindow::toggleZoomTextOnly):
1432
1433 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1434
1435         Reviewed by Ariya Hidayat.
1436
1437         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
1438
1439         Not all instances of LauncherWindow need its own m_zoomLevel.
1440
1441         * QtTestBrowser/launcherwindow.cpp:
1442         * QtTestBrowser/launcherwindow.h:
1443
1444 2010-08-09  Sam Weinig  <sam@webkit.org>
1445
1446         Reviewed by Geoffrey Garen.
1447
1448         Add zoom support for injected bundle
1449         https://bugs.webkit.org/show_bug.cgi?id=43759
1450
1451         Use zoom factor SPI to implement zoom related eventSender functions.
1452
1453         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1454         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1455         (WTR::EventSendingController::textZoomIn):
1456         (WTR::EventSendingController::textZoomOut):
1457         (WTR::EventSendingController::zoomPageIn):
1458         (WTR::EventSendingController::zoomPageOut):
1459         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1460         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1461         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
1462
1463 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
1464
1465         Speculative chromium build fix III.
1466
1467         * DumpRenderTree/chromium/MockSpellCheck.h:
1468         * DumpRenderTree/chromium/NotificationPresenter.h:
1469         * DumpRenderTree/chromium/WebViewHost.h:
1470         (WebViewHost::addClearHeader):
1471         (WebViewHost::clearHeaders):
1472
1473 2010-08-09  Ojan Vafai  <ojan@chromium.org>
1474
1475         Reviewed by Tony Chang.
1476
1477         increase the number of test results that we save
1478         https://bugs.webkit.org/show_bug.cgi?id=43763
1479
1480         Now that we do incremental uploads, we can increase the number of
1481         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
1482
1483         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1484
1485 2010-08-09  Evan Martin  <evan@chromium.org>
1486
1487         Reviewed by Tony Chang.
1488
1489         [chromium] DRT error print statement incorrectly tries to print a FILE*
1490         https://bugs.webkit.org/show_bug.cgi?id=43747
1491
1492         * DumpRenderTree/chromium/ImageDiff.cpp:
1493         (writeFile): pass the correct pointer.
1494
1495 2010-08-09  Victor Wang  <victorw@chromium.org>
1496
1497         Reviewed by Ojan Vafai.
1498
1499         Upload incremental test results json to server by default.
1500
1501         https://bugs.webkit.org/show_bug.cgi?id=43743
1502
1503         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1504
1505 2010-08-09  Eric Seidel  <eric@webkit.org>
1506
1507         Reviewed by Adam Barth.
1508
1509         EWS bots wait 2 minutes between patches
1510         https://bugs.webkit.org/show_bug.cgi?id=43731
1511
1512         * Scripts/webkitpy/tool/bot/queueengine.py:
1513          - Don't sleep after failures.  This was a hold-over from
1514            an earlier design.
1515         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1516          - EWS bots were not properly reporting true/false from process_work_item.
1517            They were always returning None, thus false, thus always logging
1518            as a failure and sleeping 2 minutes after each patch.
1519
1520 2010-08-09  Sam Weinig  <sam@webkit.org>
1521
1522         Reviewed by Anders Carlsson.
1523
1524         Stub out EventSender for WebKitTestRunner
1525         https://bugs.webkit.org/show_bug.cgi?id=43703
1526
1527         * WebKitTestRunner/DerivedSources.make:
1528         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1529         Add ability to pass javascript arguments to the wrapped object.
1530
1531         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
1532         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
1533         (WTR::EventSendingController::create):
1534         (WTR::EventSendingController::EventSendingController):
1535         (WTR::EventSendingController::~EventSendingController):
1536         (WTR::EventSendingController::wrapperClass):
1537         (WTR::setExceptionForString):
1538         (WTR::EventSendingController::mouseDown):
1539         (WTR::EventSendingController::mouseUp):
1540         (WTR::EventSendingController::mouseMoveTo):
1541         (WTR::EventSendingController::keyDown):
1542         (WTR::EventSendingController::contextClick):
1543         (WTR::EventSendingController::leapForward):
1544         (WTR::EventSendingController::textZoomIn):
1545         (WTR::EventSendingController::textZoomOut):
1546         (WTR::EventSendingController::zoomPageIn):
1547         (WTR::EventSendingController::zoomPageOut):
1548         (WTR::EventSendingController::makeWindowObject):
1549         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
1550         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1551         (WTR::InjectedBundle::reset):
1552         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1553         (WTR::InjectedBundle::eventSendingController):
1554         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1555         (WTR::InjectedBundlePage::didClearWindowForFrame):
1556         Add stubbed out EventSenderController.
1557
1558         * WebKitTestRunner/InjectedBundle/GCController.h:
1559         Remove incorrect comment.
1560
1561         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1562         * WebKitTestRunner/win/InjectedBundle.vcproj:
1563         Add new files.
1564
1565 2010-08-08  Kent Tamura  <tkent@chromium.org>
1566
1567         Unreviewed, trivial fix.
1568
1569         Fix "WindowsError: [Error 32] The process cannot access the file
1570         because it is being used by another process" introduced by r64959.
1571
1572         * BuildSlaveSupport/test-result-archive:
1573
1574 2010-08-08  Kent Tamura  <tkent@chromium.org>
1575
1576         Reviewed by Tony Chang.
1577
1578         Chromium buildbot: Avoid "zip" command dependency
1579         https://bugs.webkit.org/show_bug.cgi?id=43470
1580
1581         * BuildSlaveSupport/test-result-archive:
1582          For Chromium port, creates a zip archive with zipfile package of Python
1583          instead of external "zip" command. We'd like to avoid additional
1584          command installation.
1585
1586 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
1587
1588         WebKitTestRunner should add the QuickTime dir to the PATH environment
1589         variable
1590         https://bugs.webkit.org/show_bug.cgi?id=43686
1591
1592         Reviewed by Dan Bernstein.
1593
1594         * WebKitTestRunner/win/TestControllerWin.cpp:
1595         (WTR::addQTDirToPATH):
1596         Copied from DRT.
1597         (WTR::TestController::platformInitialize):
1598         Call addQTDirToPath().
1599         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1600         Link to shlwapi.lib for SHGetValue.
1601
1602 2010-08-07  Sam Weinig  <sam@webkit.org>
1603
1604         Reviewed by Maciej Stachowiak.
1605
1606         WebKitTestRunner needs layoutTestController.dumpTitleChanges
1607         <rdar://problem/8213861>
1608         https://bugs.webkit.org/show_bug.cgi?id=42683
1609
1610         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1611         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1612         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1613         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1614         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1615         (WTR::LayoutTestController::LayoutTestController):
1616         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1617         (WTR::LayoutTestController::dumpTitleChanges):
1618         (WTR::LayoutTestController::shouldDumpTitleChanges):
1619
1620 2010-08-07  Sam Weinig  <sam@webkit.org>
1621
1622         Reviewed by Anders Carlsson.
1623
1624         WebKitTestRunner needs to print onunload handler information
1625         <rdar://problem/8213831>
1626         https://bugs.webkit.org/show_bug.cgi?id=42703
1627
1628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1629         (WTR::operator<<):
1630         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1631
1632 2010-08-07  Sam Weinig  <sam@webkit.org>
1633
1634         Reviewed by Anders Carlsson.
1635
1636         Add additional loader client functions need to complete WebKitTestRunner
1637         https://bugs.webkit.org/show_bug.cgi?id=43684
1638
1639         Remove unnecessary and jarring underscores as well.
1640
1641         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1642         (didClearWindowObjectForFrame):
1643         (didCreatePage):
1644         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1645         (WTR::InjectedBundlePage::InjectedBundlePage):
1646         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1647         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1648         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1649         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1650         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1651         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1652         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1653         (WTR::InjectedBundlePage::didClearWindowForFrame):
1654         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1655         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1656         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1657         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1658         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1659         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1660         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1661         (WTR::InjectedBundlePage::willAddMessageToConsole):
1662         (WTR::InjectedBundlePage::willSetStatusbarText):
1663         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1664         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1665         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1666         (WTR::InjectedBundlePage::shouldBeginEditing):
1667         (WTR::InjectedBundlePage::shouldEndEditing):
1668         (WTR::InjectedBundlePage::shouldInsertNode):
1669         (WTR::InjectedBundlePage::shouldInsertText):
1670         (WTR::InjectedBundlePage::shouldDeleteRange):
1671         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1672         (WTR::InjectedBundlePage::shouldApplyStyle):
1673         (WTR::InjectedBundlePage::didBeginEditing):
1674         (WTR::InjectedBundlePage::didEndEditing):
1675         (WTR::InjectedBundlePage::didChange):
1676         (WTR::InjectedBundlePage::didChangeSelection):
1677         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1678
1679 2010-08-07  Dan Bernstein  <mitz@apple.com>
1680
1681         Build fix.
1682
1683         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
1684         to JSGCController.{cpp,h} relative to the build root.
1685
1686 2010-08-07  Sam Weinig  <sam@webkit.org>
1687
1688         Reviewed by Anders Carlsson.
1689
1690         WebKitTestRunner needs GCController
1691         <rdar://problem/8213834>
1692         https://bugs.webkit.org/show_bug.cgi?id=42701
1693
1694         * WebKitTestRunner/DerivedSources.make:
1695         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
1696         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
1697         (WTR::setProperty):
1698         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
1699         (WTR::GCController::create):
1700         (WTR::GCController::GCController):
1701         (WTR::GCController::~GCController):
1702         (WTR::GCController::wrapperClass):
1703         (WTR::GCController::collect):
1704         (WTR::GCController::collectOnAlternateThread):
1705         (WTR::GCController::getJSObjectCount):
1706         (WTR::GCController::makeWindowObject):
1707         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
1708         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1709         (WTR::InjectedBundle::reset):
1710         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1711         (WTR::InjectedBundle::bundle):
1712         (WTR::InjectedBundle::gcController):
1713         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1714         (WTR::InjectedBundlePage::didClearWindowForFrame):
1715         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1716         (WTR::LayoutTestController::keepWebHistory):
1717         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1718         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1719         * WebKitTestRunner/win/InjectedBundle.vcproj:
1720
1721 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
1722
1723         WebKitTestRunner needs to be able to set the font smoothing type
1724         https://bugs.webkit.org/show_bug.cgi?id=43406
1725
1726         Reviewed by Adam Roben.
1727
1728         * WebKitTestRunner/TestInvocation.cpp:
1729         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1730         Set the font smoothing level to
1731         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
1732
1733 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
1734
1735         Fix a missed variable rename.
1736
1737         Unreviewed.
1738
1739         * Scripts/old-run-webkit-tests:
1740
1741 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
1742
1743         mac-wk2/Skipped should be used on Windows when running regression tests
1744         https://bugs.webkit.org/show_bug.cgi?id=43494
1745
1746         Reviewed by Adam Roben.
1747
1748         * Scripts/old-run-webkit-tests:
1749         If the platform is win-wk2, also read the mac-wk2 skipped list.
1750
1751 2010-08-06  Kent Tamura  <tkent@chromium.org>
1752
1753         Reviewed by Dimitri Glazkov.
1754
1755         [DRT/Chromium] Should revoke scheduled tasks
1756         https://bugs.webkit.org/show_bug.cgi?id=43560
1757
1758         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1759         (DRTDevToolsAgent::reset): Calls RevokeAll().
1760         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1761         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1762         (DRTDevToolsClient::reset): Calls RevokeAll().
1763         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1764         * DumpRenderTree/chromium/EventSender.cpp:
1765         (EventSender::reset): Calls RevokeAll().
1766         * DumpRenderTree/chromium/LayoutTestController.cpp:
1767         (LayoutTestController::reset): Calls RevokeAll().
1768         * DumpRenderTree/chromium/TestShell.cpp:
1769         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
1770
1771 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1772
1773         Reviewed by Antonio Gomes.
1774
1775         [Qt] Fix the DRT build on Mac OS X
1776
1777         * DumpRenderTree/qt/DumpRenderTree.pro:
1778
1779 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
1780
1781         Reviewed by Pavel Feldman.
1782
1783         Rietvield's upload.py moved to a different location.
1784         https://bugs.webkit.org/show_bug.cgi?id=43613
1785
1786         * Scripts/webkitpy/thirdparty/__init__.py:
1787
1788 2010-05-23  Eric Seidel  <eric@webkit.org>
1789
1790         Reviewed by Adam Barth.
1791
1792         QueueStatusServer needs better queue-status pages
1793         https://bugs.webkit.org/show_bug.cgi?id=39562
1794
1795         The primary goal of this patch is to display queue
1796         positions somewhere on the site so that it's easier
1797         for commit-queue users to know when their pach will
1798         be landed.  I also tried to improve the root page
1799         to be more useful than the previous wall of status text.
1800
1801         * QueueStatusServer/handlers/recentstatus.py:
1802         * QueueStatusServer/main.py:
1803         * QueueStatusServer/model/queues.py:
1804         * QueueStatusServer/templates/recentstatus.html:
1805
1806 2010-08-05  Victor Wang  <victorw@chromium.org>
1807
1808         Reviewed by Ojan Vafai.
1809
1810         Add option to generate/upload incremental json results to test result server.
1811         Also refactor the json results generator unittest code to test
1812         incremental and aggregated json results.
1813
1814         https://bugs.webkit.org/show_bug.cgi?id=43519
1815
1816         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1817         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1818         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1819         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1820
1821 2010-08-05  Jian Li  <jianli@chromium.org>
1822
1823         Reviewed by David Levin.
1824
1825         Unify blob related feature defines to ENABLE(BLOB).
1826         https://bugs.webkit.org/show_bug.cgi?id=43081
1827
1828         * Scripts/build-webkit:
1829
1830 2010-08-05  Satish Sampath  <satish@chromium.org>
1831
1832         Reviewed by Jeremy Orlow.
1833
1834         Add speech input controller mock in WebKit and a layout test.
1835         https://bugs.webkit.org/show_bug.cgi?id=43477
1836
1837         Added LayoutTestController::setMockSpeechInputResultCallback method.
1838
1839         * DumpRenderTree/LayoutTestController.cpp:
1840         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
1841         (LayoutTestController::staticFunctions):
1842         * DumpRenderTree/LayoutTestController.h:
1843         * DumpRenderTree/chromium/LayoutTestController.cpp:
1844         (LayoutTestController::LayoutTestController):
1845         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
1846         (LayoutTestController::speechInputController): Creates the mock controller.
1847         * DumpRenderTree/chromium/LayoutTestController.h:
1848         * DumpRenderTree/chromium/WebViewHost.cpp:
1849         (WebViewHost::speechInputController): Creates the mock controller.
1850         * DumpRenderTree/chromium/WebViewHost.h:
1851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1852         (LayoutTestController::setMockSpeechInputResult): dummy method.
1853         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1854         (LayoutTestController::setMockSpeechInputResult): dummy method.
1855         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1856         (LayoutTestController::setMockSpeechInputResult): dummy method.
1857         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1858         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
1859         (LayoutTestController::setMockSpeechInputResult):
1860         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
1861         (LayoutTestController::setMockSpeechInputResult):
1862
1863 2010-08-04  Adam Roben  <aroben@apple.com>
1864
1865         Fix the path to TestNetscapePlugin's directory on Windows
1866
1867         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
1868         load TestNetscapePlugin
1869
1870         Reviewed by Jon Honeycutt.
1871
1872         * WebKitTestRunner/win/TestControllerWin.cpp:
1873         (WTR::TestController::initializeTestPluginDirectory):
1874         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
1875         next to WebKitTestRunner.exe. Previously we were passing the directory
1876         that contains WebKitTestRunner.exe. Also fixed some leaks.
1877
1878 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
1879
1880         Reviewed by Shinichiro Hamaji.
1881
1882         check-webkit-style returns non-zero when patch is entirely minus lines.
1883         https://bugs.webkit.org/show_bug.cgi?id=38169
1884
1885         * Scripts/check-webkit-style:
1886         Check whether a patch contains modified files that are entirely minus lines.
1887         * Scripts/webkitpy/style/filereader.py:
1888         Add a variable that holds number of files that contain only deleted lines.
1889         * Scripts/webkitpy/style/patchreader.py:
1890         Count up modified files that contain only deleted lines.
1891
1892 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
1893
1894         Reviewed by Yury Semikhatsky.
1895
1896         DevTools: get rid of delayed command dispatching on front-end side.
1897
1898         https://bugs.webkit.org/show_bug.cgi?id=43479
1899
1900         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1901         (DRTDevToolsAgent::detach):
1902         (DRTDevToolsAgent::frontendLoaded):
1903         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1904         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1905         (DRTDevToolsClient::~DRTDevToolsClient):
1906         (DRTDevToolsClient::sendFrontendLoaded):
1907         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1908
1909 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
1910
1911         Reviewed by Shinichiro Hamaji.
1912
1913         Fixes check-webkit-style false positive on "new uint32_t."
1914         https://bugs.webkit.org/show_bug.cgi?id=43077
1915
1916         * Scripts/webkitpy/style/checkers/cpp.py:
1917         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1918
1919 2010-08-04  Kent Tamura  <tkent@chromium.org>
1920
1921         Reviewed by Dimitri Glazkov.
1922
1923         [DRT/Chromium] Remove base/linked_ptr.h dependency
1924         https://bugs.webkit.org/show_bug.cgi?id=43472
1925
1926         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
1927         We need to use RefPtr<> because m_pendingEntry points an object in
1928         m_entries or not in m_entries.
1929
1930         * DumpRenderTree/chromium/TestNavigationController.cpp:
1931         (TestNavigationEntry::create): Added.
1932         (TestNavigationController::activeEntry):
1933         (TestNavigationController::didNavigateToEntry):
1934         (TestNavigationController::discardPendingEntry):
1935         (TestNavigationController::insertEntry):
1936         (TestNavigationController::navigateToPendingEntry):
1937         * DumpRenderTree/chromium/TestNavigationController.h:
1938         * DumpRenderTree/chromium/WebViewHost.cpp:
1939         (WebViewHost::loadURLForFrame):
1940          Use TestNavigationEntry::create().
1941         (WebViewHost::updateURL):
1942          Use RefPtr<>.
1943         (WebViewHost::updateSessionHistory):
1944          Remove unnecessary static_cast<>.
1945
1946 2010-08-04  Kent Tamura  <tkent@chromium.org>
1947
1948         Reviewed by Dimitri Glazkov.
1949
1950         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
1951         https://bugs.webkit.org/show_bug.cgi?id=43333
1952
1953         * BuildSlaveSupport/test-result-archive:
1954           - Make layoutTestResultsDir local and pass it to archiveTestResults()
1955           - Adjust layoutTestResultsDir for Chromium
1956
1957 2010-08-04  Kent Tamura  <tkent@chromium.org>
1958
1959         Reviewed by Dimitri Glazkov.
1960
1961         NRWT: websocket_server startup detection failure
1962         https://bugs.webkit.org/show_bug.cgi?id=43466
1963
1964         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1965          Increase timeout value: 5 second -> 10 second
1966
1967 2010-08-04  Victor Wang  <victorw@chromium.org>
1968
1969         Reviewed by Ojan Vafai.
1970
1971         -. Add result.json incremental merging functionality to test results app engine.
1972         -. blobstore is not suitable for AE data merging and there is no API to
1973            programatically edit existing blob or write a new one yet, so replace blobstore
1974            with datastore. If file is oversize (>1000*1000 bytes), store file data in
1975            multiple datastore entries.
1976         -. Fix styles.
1977
1978         Test: jsonresults_unittest to test merging logics.
1979
1980         https://bugs.webkit.org/show_bug.cgi?id=38599
1981
1982         * TestResultServer/handlers/dashboardhandler.py:
1983         * TestResultServer/handlers/menu.py:
1984         * TestResultServer/handlers/testfilehandler.py:
1985         * TestResultServer/main.py:
1986         * TestResultServer/model/dashboardfile.py:
1987         * TestResultServer/model/datastorefile.py: Added.
1988         * TestResultServer/model/jsonresults.py: Added.
1989         * TestResultServer/model/jsonresults_unittest.py: Added.
1990         * TestResultServer/model/testfile.py:
1991         * TestResultServer/templates/uploadform.html:
1992
1993 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
1994
1995         Reviewed by Kenneth Christiansen.
1996
1997         [Qt] [QtTestBrowser] Remove unneeded QAction class members
1998         https://bugs.webkit.org/show_bug.cgi?id=43518
1999
2000         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
2001         m_flipYAnimated. Also, in initializeView method there are some dead code block
2002         trying to connect them at the wrong time, when they have not been instanciated.
2003
2004         This patch:
2005
2006         - removes the two cited class members in favor of local variables in createChrome method;
2007         - removes the dead code block.
2008
2009         * QtTestBrowser/launcherwindow.cpp:
2010         (LauncherWindow::LauncherWindow):
2011         (LauncherWindow::initializeView):
2012         (LauncherWindow::createChrome):
2013         * QtTestBrowser/launcherwindow.h:
2014
2015 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2016
2017         Reviewed by Simon Hausmann and Kenneth Christiansen.
2018
2019         [Qt] [QtTestBrowser] Clean up static and global menu state controls
2020         https://bugs.webkit.org/show_bug.cgi?id=43448
2021
2022         After LauncherWindow class was refactored out of from main.cpp, all global variables that
2023         were hanging in main.cpp became temporarily public static class members of newly added
2024         LauncherWindow class. This design was not properly handling the initial purpose of the
2025         global variables: newly created launcher windows should inherit the settings of the originating
2026         one.
2027
2028         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
2029         comprises all data needed to handling the goal described above.
2030
2031         * QtTestBrowser/launcherwindow.cpp:
2032         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
2033                                           holding all user settings configured in the menus and command line.
2034                                           It also receices an optional QGraphicsScene points in case we are doing
2035                                           a "Clone Window".
2036         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
2037                                 value.
2038         (LauncherWindow::initializeView): Ditto.
2039         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
2040         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
2041                                       apply the preferences is provided by m_userData.
2042         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
2043         (LauncherWindow::toggleResizesToContents): Ditto.
2044         (LauncherWindow::toggleWebGL): Ditto.
2045         (LauncherWindow::toggleFrameFlattening): Ditto.
2046         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
2047         (LauncherWindow::changeViewportUpdateMode): Ditto.
2048         (LauncherWindow::showFPS): Ditto.
2049         (LauncherWindow::newWindow): Changed to pass the userData.
2050         (LauncherWindow::cloneWindow): Ditto.
2051         * QtTestBrowser/launcherwindow.h:
2052         (WindowOptions::WindowOptions):
2053         * QtTestBrowser/main.cpp:
2054         (requiresGraphicsView):
2055         (LauncherApplication::handleUserOptions):
2056         (main):
2057
2058 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
2059
2060         [wx] Build fix for gcc not importing all symbols from convenience libraries.
2061         Works on 10.6 only for Mac until the build system is reworked. 
2062
2063         * wx/build/settings.py:
2064
2065 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
2066
2067         Reviewed by Simon Hausmann.
2068
2069         [Qt] Change wording in QtTestBrowser
2070         https://bugs.webkit.org/show_bug.cgi?id=43241
2071
2072         * QtTestBrowser/launcherwindow.cpp:
2073         (LauncherWindow::createChrome):
2074
2075 2010-08-04  Aaron Boodman  <aa@chromium.org>
2076
2077         Reviewed by Eric Seidel.
2078
2079         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
2080         https://bugs.webkit.org/show_bug.cgi?id=43460
2081
2082         * Scripts/prepare-ChangeLog:
2083
2084 2010-08-03  MORITA Hajime  <morrita@google.com>
2085
2086         Reviewed by Tony Chang.
2087
2088         [DRT] Assertion failed when drag and move a draggable element.
2089         https://bugs.webkit.org/show_bug.cgi?id=41695
2090
2091         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
2092         But Cocoa doesn't call mouseDragged() until dragging is done.
2093         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
2094         on UIDelegate failed when mouseDragged() is called during dragging.
2095         This change eliminated the mouseDragged() call when dragging begins,
2096         which is implicated by draggingInfo instance.
2097         
2098         * DumpRenderTree/mac/EventSendingController.mm:
2099         (-[EventSendingController mouseMoveToX:Y:]):
2100
2101         Test: fast/events/dragging-mouse-moves.html
2102         
2103 2010-08-02  Steve Block  <steveblock@google.com>
2104
2105         Reviewed by Alexey Proskuryakov.
2106
2107         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
2108         https://bugs.webkit.org/show_bug.cgi?id=40002
2109
2110         The code in LayoutTestController::setGeolocationPermission() was moved to
2111         setGeolocationPermissionCommon() to allow each port to provide its own
2112         implementation of setGeolocationPermission().
2113
2114         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
2115         new permission, so it can call back to WebCore if permission requests are in
2116         progress and are waiting for a response. A minor fix to the Mac
2117         MockGeolocationProvider was also required to make sure that the mock provider
2118         calls back to WebCore when it is first started.
2119
2120         For other ports, LayoutTestController::setGeolocationPermission() is not
2121         implemented.
2122
2123         * DumpRenderTree/LayoutTestController.cpp:
2124         (LayoutTestController::setGeolocationPermissionCommon):
2125         * DumpRenderTree/LayoutTestController.h:
2126         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2127         (LayoutTestController::setGeolocationPermission):
2128         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2129         (LayoutTestController::setGeolocationPermission):
2130         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2131         (-[MockGeolocationProvider registerWebView:]):
2132         * DumpRenderTree/mac/UIDelegate.h:
2133         * DumpRenderTree/mac/UIDelegate.mm:
2134         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2135         (-[UIDelegate setGeolocationPermission:]):
2136         (-[UIDelegate dealloc]):
2137         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2138         (LayoutTestController::setGeolocationPermission):
2139         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2140         (LayoutTestController::setGeolocationPermission):
2141
2142 2010-08-03  Kent Tamura  <tkent@chromium.org>
2143
2144         Reviewed by Dimitri Glazkov.
2145
2146         [DRT/Chromium] Implement --testshell-startup-dialog
2147         https://bugs.webkit.org/show_bug.cgi?id=40616
2148
2149         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2150         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
2151         if it is specfied.
2152         * DumpRenderTree/chromium/TestShell.h:
2153           Declare openStartUpDialog().
2154         * DumpRenderTree/chromium/TestShellGtk.cpp:
2155         (openStartupDialog):
2156         * DumpRenderTree/chromium/TestShellMac.mm:
2157         (openStartupDialog):
2158         * DumpRenderTree/chromium/TestShellWin.cpp:
2159         (openStartupDialog):
2160
2161 2010-08-03  Kent Tamura  <tkent@chromium.org>
2162
2163         Reviewed by Dimitri Glazkov.
2164
2165         [DRT/Chromium] Remove dependency of base/md5.h
2166         https://bugs.webkit.org/show_bug.cgi?id=43403
2167
2168         * DumpRenderTree/chromium/TestShell.cpp:
2169         (TestShell::dumpImage): Use wtf/MD5.h
2170
2171 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2172
2173         Reviewed by David Kilzer.
2174
2175         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2176         https://bugs.webkit.org/show_bug.cgi?id=40627
2177
2178         Part 6 - LayoutTest and Cleanup
2179
2180           Allow tests to delete application caches and set application cache
2181           origin quotas, so they can be tested.
2182
2183         * DumpRenderTree/LayoutTestController.cpp:
2184         (LayoutTestController::LayoutTestController):
2185         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
2186         (clearAllApplicationCachesCallback): should delete all application caches.
2187         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
2188         (LayoutTestController::staticFunctions):
2189         * DumpRenderTree/LayoutTestController.h:
2190         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
2191         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
2192
2193           Mac implementation.
2194
2195         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2196         (LayoutTestController::clearAllApplicationCaches): delete application caches.
2197         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
2198         * DumpRenderTree/mac/UIDelegate.mm:
2199         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
2200         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
2201
2202           Stub implementations for other platforms.
2203
2204         * DumpRenderTree/chromium/LayoutTestController.cpp:
2205         (LayoutTestController::LayoutTestController):
2206         (LayoutTestController::clearAllApplicationCaches):
2207         (LayoutTestController::setApplicationCacheOriginQuota):
2208         * DumpRenderTree/chromium/LayoutTestController.h:
2209         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2210         (LayoutTestController::clearAllApplicationCaches):
2211         (LayoutTestController::setApplicationCacheOriginQuota):
2212         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2213         (LayoutTestController::clearAllApplicationCaches):
2214         (LayoutTestController::setApplicationCacheOriginQuota):
2215         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2216         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2217         (LayoutTestController::clearAllApplicationCaches):
2218         (LayoutTestController::setApplicationCacheOriginQuota):
2219         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2220         (LayoutTestController::clearAllApplicationCaches):
2221         (LayoutTestController::setApplicationCacheOriginQuota):
2222
2223 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2224
2225         Reviewed by David Kilzer.
2226
2227         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2228         https://bugs.webkit.org/show_bug.cgi?id=40627
2229
2230         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
2231
2232           Change old style calls to make use of the managers.
2233
2234         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2235         (LayoutTestController::setDatabaseQuota):
2236         * DumpRenderTree/mac/UIDelegate.mm:
2237         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2238
2239 2010-08-03  Mark Rowe  <mrowe@apple.com>
2240
2241         Add a new Leopard build slave to run the release tests.
2242
2243         * BuildSlaveSupport/build.webkit.org-config/config.json:
2244
2245 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
2246
2247         WebKitTestRunner needs to activate the Mac font ascent hack
2248         https://bugs.webkit.org/show_bug.cgi?id=43404
2249
2250         Reviewed by Darin Adler.
2251
2252         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2253         (WTR::InjectedBundle::initialize):
2254         Call WKBundleActivateMacFontAscentHack().
2255
2256 2010-08-03  Alex Milowski  <alex@milowski.com>
2257
2258         Reviewed by Beth Dakin.
2259
2260         Changed the default for MathML support so that is is enabled by default.
2261
2262         * Scripts/build-webkit:
2263
2264 2010-08-03  Sam Weinig  <sam@webkit.org>
2265
2266         Roll r64566 back in this time with all the overloads in place..
2267
2268         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2269         (WTR::InjectedBundlePage::shouldInsertNode):
2270         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2271         * WebKitTestRunner/StringFunctions.h:
2272         * WebKitTestRunner/TestInvocation.cpp:
2273         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2274         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2275         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2276
2277 2010-08-03  Sam Weinig  <sam@webkit.org>
2278
2279         Rollout r64566. It broke all the WebKit2 tests.
2280
2281         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2282         (WTR::operator<<):
2283         (WTR::InjectedBundlePage::shouldInsertNode):
2284         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2285         * WebKitTestRunner/StringFunctions.h: Removed.
2286         * WebKitTestRunner/TestInvocation.cpp:
2287         (WTR::createWKURL):
2288         (WTR::WKStringToUTF8):
2289         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2290         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2291         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2292
2293 2010-08-03  Sam Weinig  <sam@webkit.org>
2294
2295         Reviewed by Anders Carlsson.
2296
2297         WTR: Move all the utility functions for working with strings to a shared header.
2298         https://bugs.webkit.org/show_bug.cgi?id=43386
2299
2300         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2301         (WTR::InjectedBundlePage::shouldInsertNode):
2302         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2303         * WebKitTestRunner/StringFunctions.h: Added.
2304         * WebKitTestRunner/TestInvocation.cpp:
2305         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2306         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2307         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2308
2309 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
2310
2311         Reviewed by Kenneth Christiansen.
2312
2313         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
2314         https://bugs.webkit.org/show_bug.cgi?id=43168
2315
2316         QGraphicsWebView resizesToContents property has to work together with QWebPage's
2317         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
2318
2319         * QtTestBrowser/launcherwindow.cpp:
2320         (LauncherWindow::applyPrefs):
2321         * QtTestBrowser/webview.cpp:
2322         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
2323                                                       needed when toggle resizesToContents on/off.
2324         (WebViewGraphicsBased::resizeEvent):
2325         * QtTestBrowser/webview.h:
2326         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
2327         (WebViewGraphicsBased::customLayoutSize): Getter helper.
2328
2329 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
2330
2331         Unreviewed. Adding myself as committer.
2332
2333         * Scripts/webkitpy/common/config/committers.py:
2334
2335 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
2336
2337         Reviewed by Yury Semikhatsky.
2338
2339         Chromium DevTools: Get rid of DevTools RPC.
2340
2341         https://bugs.webkit.org/show_bug.cgi?id=43335
2342
2343         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2344         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
2345         (DRTDevToolsAgent::call):
2346         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2347         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
2348         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
2349         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2350         (DRTDevToolsClient::sendMessageToBackend):
2351         (DRTDevToolsClient::call):
2352         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2353
2354 2010-08-02  Kent Tamura  <tkent@chromium.org>
2355
2356         Reviewed by Dimitri Glazkov.
2357
2358         [DRT/Chromium] Remove dependencies to some Chromium headers
2359         https://bugs.webkit.org/show_bug.cgi?id=43396
2360
2361         * DumpRenderTree/chromium/CppVariant.h:
2362          Remove base/basictypes.h because webkit_support.h contains it.
2363         * DumpRenderTree/chromium/EventSender.cpp:
2364         (getCurrentEventTimeSec): Use new wrapper function.
2365         * DumpRenderTree/chromium/TestNavigationController.h:
2366          Remove base/basictypes.h because webkit_support.h contains it.
2367         * DumpRenderTree/chromium/TestShell.cpp:
2368         (dumpHistoryItem): Use new wrapper function.
2369         * DumpRenderTree/chromium/WebViewHost.cpp:
2370         (WebViewHost::cancelledError): Use new wrapper function.
2371         (WebViewHost::didFailResourceLoad): Use new wrapper function.
2372
2373 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2374
2375         Reviewed by Xan Lopez.
2376
2377         [GTK] DRT implement execCommand()
2378         https://bugs.webkit.org/show_bug.cgi?id=35351
2379
2380         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2381         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
2382         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
2383         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
2384
2385 2010-08-02  Sam Weinig  <sam@webkit.org>
2386
2387         Reviewed by Anders Carlsson.
2388
2389         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
2390
2391         * Scripts/old-run-webkit-tests:
2392
2393 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2394
2395         WebKitTestRunner needs to support loading custom fonts (via the
2396         WEBKIT_TESTFONTS environment variable)
2397         https://bugs.webkit.org/show_bug.cgi?id=42782
2398
2399         Reviewed by Adam Roben.
2400
2401         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2402         (WTR::fontsPath):
2403         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
2404         as this directory doesn't appear to be created anymore.
2405         (WTR::activateFonts):
2406         Loop through the fonts, and call AddFontResourceExW() for each.
2407
2408 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2409
2410         Restore the WebKitTestRunner.sln that was removed, and remove the
2411         correct one.
2412
2413         Rubber-stamped by Sam Weinig.
2414
2415         * WebKitTestRunner/WebKitTestRunner.sln: Added.
2416         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
2417
2418 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2419
2420         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
2421
2422         Remove the unused WebKitTestRunner.sln.
2423
2424         Reviewed by Sam Weinig.
2425
2426         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2427         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
2428         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
2429         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
2430         * WebKitTestRunner/win/WebKitTestRunner.sln:
2431
2432 2010-08-02  Sam Weinig  <sam@webkit.org>
2433
2434         Fix the windows build.
2435
2436         * WebKitTestRunner/win/main.cpp:
2437
2438 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
2439
2440         Add a Skipped list on Windows, and have run-webkit-tests respect it.
2441
2442         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
2443         there are zero tests failing
2444         https://bugs.webkit.org/show_bug.cgi?id=43374
2445
2446         Reviewed by Adam Roben.
2447
2448         * Scripts/old-run-webkit-tests:
2449         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
2450         win-wk2. When building the result hierarchy, if the platform is win-wk2,
2451         add it first to the list of platforms.
2452
2453 2010-08-02  Darin Adler  <darin@apple.com>
2454
2455         Reviewed by Sam Weinig.
2456
2457         WebKitTestRunner needs layoutTestController.setCanOpenWindows
2458         https://bugs.webkit.org/show_bug.cgi?id=42321
2459
2460         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
2461         https://bugs.webkit.org/show_bug.cgi?id=42779
2462
2463         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
2464         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
2465
2466         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2467         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
2468         waiting for the first call to didCreatePage.
2469         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
2470         is created. Put other pages into a map.
2471         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
2472         of the main page.
2473         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
2474         the main page.
2475         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
2476         closeOtherPages functions.
2477
2478         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2479         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
2480         the main page affect dumping.
2481         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
2482
2483         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2484         (WTR::LayoutTestController::LayoutTestController): Initialize the new
2485         m_shouldCloseExtraWindows member.
2486         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
2487         (WTR::LayoutTestController::windowCount): Added.
2488
2489         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2490         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
2491         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
2492         m_shouldCloseExtraWindows.
2493
2494         * WebKitTestRunner/TestController.cpp:
2495         (WTR::TestController::shared): Return a pointer to the shared copy, but
2496         don't allocate and leak it. This seemed cleaner than adding an explicit
2497         finalize call to go along with the explicit initialize call.
2498         (WTR::TestController::TestController): Added calls to the initialize and
2499         run function, which are now done automatically.
2500         (WTR::TestController::~TestController): Added, since it's called now.
2501         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
2502         (WTR::createOtherPage): Added. Used to create pages other than the main page.
2503         (WTR::TestController::initialize): Added code to set up createOtherPage.
2504         (WTR::TestController::run): Removed unused return value.
2505         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
2506         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
2507
2508         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2509         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
2510         to avoid releasing the window twice. Another way to handle it would be to
2511         remove the release, but this approach is slightly more robust because it works
2512         even if some other code calls the close method an extra time.
2513
2514         * WebKitTestRunner/mac/main.mm:
2515         (main): Use a stack-allocated TestController object instead of calling
2516         initalize and run on a globally allocated one.
2517
2518 2010-08-02  Tony Chang  <tony@chromium.org>
2519
2520         Reviewed by David Levin.
2521
2522         add myself to the reviewers list
2523         https://bugs.webkit.org/show_bug.cgi?id=43366
2524
2525         * Scripts/webkitpy/common/config/committers.py:
2526
2527 2010-08-02  Anders Carlsson  <andersca@apple.com>
2528
2529         Reviewed by Sam Weinig.
2530
2531         Cache JSNPObjects and fix bugs in the object map
2532         https://bugs.webkit.org/show_bug.cgi?id=43368
2533
2534         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
2535         wrap an NPObject that came from a plug-in that is now destroyed.
2536
2537         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2538         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2539         (PluginTest::Object::getProperty):
2540         (PluginTest::Object::NP_GetProperty):
2541         (PluginTest::Object::npClass):
2542         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
2543         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
2544         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2545         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
2546         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
2547         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2548         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2549         * GNUmakefile.am:
2550
2551 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2552
2553         Reviewed by Xan Lopez.
2554
2555         [Gtk] DOM listeners get wrong keycodes for some keys
2556         https://bugs.webkit.org/show_bug.cgi?id=35170
2557
2558         Add support to all event senders for simulating keypad insert
2559         and print screen keys.
2560
2561         * DumpRenderTree/chromium/EventSender.cpp:
2562         (EventSender::keyDown): Add support for generating keypad insert and print screen.
2563         * DumpRenderTree/gtk/EventSender.cpp:
2564         (keyDownCallback): Ditto.
2565         * DumpRenderTree/mac/EventSendingController.mm:
2566         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
2567         * DumpRenderTree/qt/EventSenderQt.cpp:
2568         (EventSender::keyDown): Ditto.
2569         * DumpRenderTree/win/EventSender.cpp:
2570         (keyDownCallback): Ditto.
2571
2572 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2573
2574         Build fix for building against development versions of GTK+. GTK 2.22
2575         has not yet been released, so these function definitions must be conditionalized
2576         on the development version.
2577
2578         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
2579
2580 2010-08-02  Tony Chang  <tony@chromium.org>
2581
2582         Reviewed by Kent Tamura.
2583
2584         [chromium] use ChromiumDriver on Linux when running webkit tests
2585         https://bugs.webkit.org/show_bug.cgi?id=43273
2586
2587         * Scripts/webkitpy/layout_tests/port/chromium.py:
2588
2589 2010-08-02  Kent Tamura  <tkent@chromium.org>
2590
2591         Reviewed by Dimitri Glazkov.
2592
2593         [DRT/Chromium] Always initialize GTK
2594         https://bugs.webkit.org/show_bug.cgi?id=43327
2595
2596         Call gtk_init() in order to fix plugin test crash.
2597
2598         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2599         (main): Pass argc/argv to platformInit().
2600         * DumpRenderTree/chromium/TestShell.h:
2601         * DumpRenderTree/chromium/TestShellGtk.cpp:
2602         (platformInit): Update parameters, call gtk_init().
2603         * DumpRenderTree/chromium/TestShellMac.mm:
2604         (platformInit): Update parameters.
2605         * DumpRenderTree/chromium/TestShellWin.cpp:
2606         (platformInit): Update parameters.
2607
2608 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
2609
2610         Reviewed by Simon Hausmann.
2611
2612         [Qt] Generate forwarding headers for WebKit2
2613
2614         https://bugs.webkit.org/show_bug.cgi?id=43336
2615
2616         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
2617
2618 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
2619
2620         Reviewed by Kent Tamura.
2621
2622         WebSocket server should start with SO_REUSEADDR
2623         https://bugs.webkit.org/show_bug.cgi?id=43329
2624
2625         Pulls in pywebsocket-0.5.2.
2626         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
2627         http://code.google.com/p/pywebsocket/source/detail?r=273
2628
2629         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
2630
2631 2010-08-01  Kent Tamura  <tkent@chromium.org>
2632
2633         Reviewed by Dimitri Glazkov.
2634
2635         [DRT/Chromium] Remove string_util.h dependency
2636         https://bugs.webkit.org/show_bug.cgi?id=43312
2637
2638         * DumpRenderTree/chromium/LayoutTestController.cpp:
2639         (LayoutTestController::pathToLocalResource):
2640          Use string::find() instead of StartsWithASCII().
2641         (LayoutTestController::cppVariantToInt32):
2642          Use strtol() instead of StringToNumber().
2643
2644 2010-08-01  Sam Weinig  <sam@webkit.org>
2645
2646         Reviewed by Anders Carlsson.
2647
2648         Add ability to reset frame names for WebKitTestRunner
2649         https://bugs.webkit.org/show_bug.cgi?id=43316
2650
2651         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2652         (WTR::InjectedBundle::reset):
2653         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2654         (WTR::InjectedBundlePage::reset):
2655         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2656
2657 2010-08-01  Anders Carlsson  <andersca@apple.com>
2658
2659         Reviewed by Sam Weinig.
2660
2661         Implement NPN_RemoveProperty
2662         https://bugs.webkit.org/show_bug.cgi?id=43315
2663
2664         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2665         Add NPRuntimeRemoveProperty.cpp
2666         
2667         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2668         (PluginTest::NPN_GetStringIdentifier):
2669         (PluginTest::NPN_GetIntIdentifier):
2670         (PluginTest::NPN_RemoveProperty):
2671         Add NPN_ helpers.
2672
2673         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2674         Support more NPClass functions.
2675
2676         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
2677         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
2678         Test for NPN_RemoveProperty.
2679
2680         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
2681         (NPRuntimeRemoveProperty::TestObject::invoke):
2682         Add a testRemoveProperty method.
2683
2684         (NPRuntimeRemoveProperty::NPP_GetValue):
2685         Return the test object.
2686
2687         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2688         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2689         * GNUmakefile.am:
2690         Add NPRuntimeRemoveProperty.cpp
2691
2692 2010-07-30  Anders Carlsson  <andersca@apple.com>
2693
2694         Reviewed by Sam Weinig.
2695
2696         Add an NPObject class template helper to TestNetscapePlugin
2697         https://bugs.webkit.org/show_bug.cgi?id=43288
2698
2699         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2700         Add some template magic to be able to figure out if a class has a member function of a given type.
2701
2702         (PluginTest::Object::create):
2703         Create an object.
2704
2705         (PluginTest::Object::invokeDefault):
2706         Add dummy function, this should never be called.
2707
2708         (PluginTest::Object::Object):
2709         Initialize m_pluginTest to 0.
2710
2711         (PluginTest::Object::~Object):
2712         Add virtual destructor.
2713
2714         (PluginTest::Object::NP_Allocate):
2715         Create a new object.
2716
2717         (PluginTest::Object::NP_Deallocate):
2718         Delete the object.
2719
2720         (PluginTest::Object::NP_InvokeDefault):
2721         Call invokeDefault.
2722
2723         (PluginTest::Object::npClass):
2724         Initialize the NPClass struct.
2725
2726         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
2727         (DocumentOpenInDestroyStream::NPP_DestroyStream):
2728         Move this inline.
2729
2730         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
2731         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
2732         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
2733         Use the PluginTest::Object class template.
2734
2735 2010-07-31  Sam Weinig  <sam@webkit.org>
2736
2737         Reviewed by Dan Bernstein.
2738
2739         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
2740         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
2741         due to SVGElements not having the innerText function.
2742
2743         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2744         (WTR::dumpFrameText):
2745
2746 2010-07-30  Sam Weinig  <sam@webkit.org>
2747
2748         Reviewed by Maciej Stachowiak.
2749
2750         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
2751         Add structured message passing from the injected bundle to UIProcess
2752
2753         * MiniBrowser/mac/AppDelegate.m:
2754         (didRecieveMessageFromInjectedBundle):
2755         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2756         (didClearWindowForFrame):
2757         (didRecieveMessage):
2758         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2759         (WTR::InjectedBundle::done):
2760         (WTR::InjectedBundle::didReceiveMessage):
2761         * WebKitTestRunner/TestController.cpp:
2762         (WTR::TestController::initialize):
2763         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2764         * WebKitTestRunner/TestController.h:
2765         * WebKitTestRunner/TestInvocation.cpp:
2766         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2767         * WebKitTestRunner/TestInvocation.h:
2768         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2769
2770 2010-07-30  Sam Weinig  <sam@webkit.org>
2771
2772         Reviewed by Anders Carlsson.
2773
2774         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
2775         Make WKArrayRef more usable.
2776
2777         Remove now unnecessary const_casts.
2778
2779         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2780         (WTR::dumpDescendantFrameScrollPositions):
2781         (WTR::dumpDescendantFramesText):
2782
2783 2010-07-30  Sam Weinig  <sam@webkit.org>
2784
2785         Reviewed by Anders Carlsson.
2786
2787         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
2788         Add first pass of structured message passing.
2789
2790         Update Minibrowser and WebKitTestRunner to work with the new post message
2791         function.
2792
2793         * MiniBrowser/mac/AppDelegate.m:
2794         (didRecieveMessageFromInjectedBundle):
2795         (-[BrowserAppDelegate init]):
2796         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2797         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2798         (didStartProvisionalLoadForFrame):
2799         (didReceiveServerRedirectForProvisionalLoadForFrame):
2800         (didFailProvisionalLoadWithErrorForFrame):
2801         (didCommitLoadForFrame):
2802         (didFinishLoadForFrame):
2803         (didFailLoadWithErrorForFrame):
2804         (didReceiveTitleForFrame):
2805         (didClearWindowForFrame):
2806         (didCreatePage):
2807         (willDestroyPage):
2808         (didRecieveMessage):
2809         (WKBundleInitialize):
2810         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2811         (WTR::InjectedBundle::_didReceiveMessage):
2812         (WTR::InjectedBundle::didReceiveMessage):
2813         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2814         * WebKitTestRunner/TestInvocation.cpp:
2815         (WTR::TestInvocation::invoke):
2816         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2817
2818 2010-07-30  Anders Carlsson  <andersca@apple.com>
2819
2820         Try to fix the layout test failures.
2821
2822         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2823         (webkit_test_plugin_get_value):
2824
2825 2010-07-29  Anders Carlsson  <andersca@apple.com>
2826
2827         Reviewed by Adam Roben.
2828
2829         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
2830         https://bugs.webkit.org/show_bug.cgi?id=43232
2831
2832         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2833         Add PluginScriptableNPObjectInvokeDefault.cpp.
2834
2835         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2836         Remove invokeDefault callback function.
2837
2838         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2839         (PluginTest::create):
2840         Move this to the top of the file.
2841
2842         (PluginTest::NPP_GetValue):
2843         Add default implementation.
2844
2845         (PluginTest::NPN_CreateObject):
2846         Add NPN_ wrapper.
2847
2848         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2849         (PluginTest::identifier):
2850         Add identifier getter.
2851
2852         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
2853         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
2854         Add "using namespace std".
2855
2856         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2857         (NPP_GetValue):
2858         Give PluginTest a chance to return a value.
2859
2860         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2861         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2862         * GNUmakefile.am:
2863         Add PluginScriptableNPObjectInvokeDefault.cpp.
2864         
2865         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2866         (webkit_test_plugin_get_value):
2867         Give PluginTest a chance to return a value.
2868
2869 2010-07-30  Steve Block  <steveblock@google.com>
2870
2871         Reviewed by Steve Block.
2872
2873         Add LayoutTestController methods to test DeviceOrientation
2874         https://bugs.webkit.org/show_bug.cgi?id=39589
2875
2876         * DumpRenderTree/LayoutTestController.cpp:
2877         (setMockDeviceOrientationCallback):
2878         (LayoutTestController::staticFunctions):
2879         * DumpRenderTree/LayoutTestController.h:
2880         * DumpRenderTree/chromium/LayoutTestController.cpp:
2881         (LayoutTestController::LayoutTestController):
2882         (LayoutTestController::setMockDeviceOrientation):
2883         * DumpRenderTree/chromium/LayoutTestController.h:
2884         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2885         (LayoutTestController::setMockDeviceOrientation):
2886         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2887         (LayoutTestController::setMockDeviceOrientation):
2888         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2889         (LayoutTestController::setMockDeviceOrientation):
2890         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2891         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2892         (LayoutTestController::setMockDeviceOrientation):
2893         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2894         (LayoutTestController::setMockDeviceOrientation):
2895         * Scripts/build-webkit:
2896
2897 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2898
2899         Reviewed by Kenneth Christiansen.
2900
2901         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
2902         https://bugs.webkit.org/show_bug.cgi?id=43209
2903
2904         When -resizes-to-content was being passed as a command line parameter it was simply
2905         not being set (although the corresponding menu item was marked as ON).
2906         User had to toggle the menu OFF and then ON again for it to take place.
2907
2908         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
2909         the command line, but not resizesToContents. Patch addresses that.
2910
2911         * QtTestBrowser/launcherwindow.cpp:
2912         (LauncherWindow::createChrome):
2913         (LauncherWindow::applyPrefs):
2914         (LauncherWindow::toggleResizesToContents):
2915         * QtTestBrowser/webview.h:
2916         (WebViewGraphicsBased::resizesToContents):
2917
2918 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2919
2920         Rubber-stamped by Simon Fraser.
2921
2922         [Qt] QtTestBrowser: more method grouping and clean ups.
2923
2924         Moving blocks of code around. Basically grouping related methods close to each.
2925
2926         * QtTestBrowser/launcherwindow.cpp:
2927         (LauncherWindow::initializeView):
2928         (LauncherWindow::createChrome):
2929         (LauncherWindow::changeViewportUpdateMode):
2930         (LauncherWindow::showFPS):
2931         (LauncherWindow::newWindow):
2932         (LauncherWindow::cloneWindow):
2933         * QtTestBrowser/launcherwindow.h:
2934
2935 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2936
2937         Reviewed by Tor Arne Vestbø.
2938
2939         [QT][Symbian] QtTestBrowser missing location capabilities
2940         https://bugs.webkit.org/show_bug.cgi?id=43235
2941
2942         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
2943
2944         * QtTestBrowser/QtTestBrowser.pro:
2945
2946 2010-07-29  Anders Carlsson  <andersca@apple.com>
2947
2948         Add PluginTest.cpp
2949
2950         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2951
2952 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
2953
2954         Reviewed by Eric Seidel.
2955
2956         Update download URLs for python irclib package; the old URLs 
2957         pointed at a specific mirror host and not the general sourceforge
2958         URLs.
2959
2960         https://bugs.webkit.org/show_bug.cgi?id=43228
2961
2962         * Scripts/webkitpy/thirdparty/__init__.py:
2963
2964 2010-07-29  Anders Carlsson  <andersca@apple.com>
2965
2966         Fix typo.
2967
2968         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2969
2970 2010-07-29  Anders Carlsson  <andersca@apple.com>
2971
2972         Another attempt at fixing the Qt and GTK+ build.
2973
2974         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2975         (webkit_test_plugin_new_instance):
2976         (webkit_test_plugin_destroy_stream):
2977
2978 2010-07-29  Anders Carlsson  <andersca@apple.com>
2979
2980         Another build fix attempt.
2981
2982         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2983         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2984         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2985         (webkit_test_plugin_new_instance):
2986         * GNUmakefile.am:
2987
2988 2010-07-29  Anders Carlsson  <andersca@apple.com>
2989
2990         Try to fix Windows and Unix builds.
2991
2992         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2993         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2994         (webkit_test_plugin_new_instance):
2995         (webkit_test_plugin_destroy_stream):
2996
2997 2010-07-29  Anders Carlsson  <andersca@apple.com>
2998
2999         Reviewed by Sam Weinig.
3000
3001         Refactor TestNetscapePlugin so tests can be split in separate files
3002         https://bugs.webkit.org/show_bug.cgi?id=43220
3003
3004         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3005         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3006
3007         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3008         (pluginAllocate):
3009         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
3010
3011         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3012         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
3013         (PluginTest::PluginTest):
3014         Initialize m_npp and the test identifier.
3015         
3016         (PluginTest::createTestFunctions):
3017         Return the map from identifiers to createTest functions.
3018
3019         (PluginTest::registerCreateTestFunction):
3020         Insert the identifier and create function pair in the map.
3021
3022         (PluginTest::create):
3023         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
3024
3025         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
3026         (PluginTest::Register::Register):
3027         Helper class template for registering plug-in tests.
3028         
3029         (PluginTest::Register::create):
3030         Create a new test of the given type.
3031
3032         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
3033         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3034         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
3035
3036         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3037         (NPP_New):
3038         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
3039
3040         (NPP_DestroyStream):
3041         Call the plug-in test NPP_DestroyStream member function.
3042
3043         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3044         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3045
3046 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3047
3048         Unreviewed build fix.
3049
3050         Add missing second argument to assert_lint in new style checker tests.
3051
3052         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3053
3054 2010-07-29  Anders Carlsson  <andersca@apple.com>
3055
3056         Reviewed by Adam Roben.
3057
3058         check-webkit-style shouldn't complain about NPAPI functions
3059         https://bugs.webkit.org/show_bug.cgi?id=43211
3060
3061         Allow underscores in functions that start with NPN_, NPP_ or NP_.
3062
3063         * Scripts/webkitpy/style/checkers/cpp.py:
3064         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3065
3066 2010-07-29  Victor Wang  <victorw@chromium.org>
3067
3068         Unreviewed, rolling out r64270.
3069         http://trac.webkit.org/changeset/64270
3070         https://bugs.webkit.org/show_bug.cgi?id=39589
3071
3072         The patch breaks chromium webkit unittest
3073
3074         * DumpRenderTree/LayoutTestController.cpp:
3075         (LayoutTestController::staticFunctions):
3076         * DumpRenderTree/LayoutTestController.h:
3077         * DumpRenderTree/chromium/LayoutTestController.cpp:
3078         (LayoutTestController::LayoutTestController):
3079         * DumpRenderTree/chromium/LayoutTestController.h:
3080         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3081         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3082         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3083         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3084         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3085         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3086         * Scripts/build-webkit:
3087
3088 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3089
3090         Reviewed by Kenneth Christiansen.
3091
3092         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
3093         https://bugs.webkit.org/show_bug.cgi?id=43199
3094
3095         There is no sense in keeping WebPage method definitions in main.cpp once
3096         webpage.cpp already exists.
3097
3098         No behavior change.
3099
3100         * QtTestBrowser/main.cpp:
3101         * QtTestBrowser/webpage.cpp:
3102         (WebPage::createWindow):
3103         (WebPage::createPlugin):
3104
3105 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3106
3107         Reviewed by Kenneth Christiansen.
3108
3109         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
3110         https://bugs.webkit.org/show_bug.cgi?id=43170
3111
3112         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
3113         launcherwindow.{cpp|h}
3114
3115         No behavior change.
3116
3117         Also changed all global static variables (named "gXXX") from main.cpp to
3118         static public variables of the LauncherWindow class.
3119
3120         * QtTestBrowser/QtTestBrowser.pro:
3121         * QtTestBrowser/launcherwindow.cpp: Added.
3122         * QtTestBrowser/launcherwindow.h: Added.
3123         * QtTestBrowser/main.cpp:
3124         (LauncherApplication::handleUserOptions):
3125         (main):
3126
3127 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3128
3129         Reviewed by Xan Lopez.
3130
3131         Build fix for building against GTK+ 3.x. GSEAL requires that we
3132         access internals of the GdkDragContext via methods. For older versions
3133         of GTK+, define those methods.
3134
3135         * DumpRenderTree/gtk/EventSender.cpp:
3136         (gdk_drag_context_get_selected_action): Added.
3137         (gdk_drag_context_get_actions): Added.
3138         (dispatchEvent): Use the two new accessor methods.
3139
3140 2010-07-29  Adam Roben  <aroben@apple.com>
3141
3142         Always say "plugins directory" when referring to a directory
3143         containing one or more plugins
3144
3145         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
3146         directory" when it means "plugins directory"
3147
3148         Reviewed by John Sullivan.
3149
3150         * WebKitTestRunner/TestController.cpp:
3151         (WTR::TestController::initialize): Updated for rename.
3152
3153 2010-07-29  Adam Roben  <aroben@apple.com>
3154
3155         Always say "directory" when referring to a plugin directory
3156
3157         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
3158         when it means "plugin directory"
3159
3160         Reviewed by John Sullivan.
3161
3162         * WebKitTestRunner/TestController.cpp:
3163         (WTR::TestController::initialize): Updated for renames.
3164
3165         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
3166         m_testPluginDirectory.
3167         (WTR::TestController::testPluginDirectory): Renamed from
3168         testPluginPath.
3169
3170         * WebKitTestRunner/mac/TestControllerMac.mm:
3171         (WTR::TestController::initializeTestPluginDirectory):
3172         * WebKitTestRunner/win/TestControllerWin.cpp:
3173         (WTR::TestController::initializeTestPluginDirectory):
3174         Renamed from initializeTestPluginPath and updated for rename.
3175
3176 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3177
3178          Reviewed by Antonio Gomes.
3179
3180          Initialize all members of NPClass struct.
3181          https://bugs.webkit.org/show_bug.cgi?id=43193
3182
3183          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3184
3185 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3186
3187         Reviewed by Antonio Gomes.
3188
3189         Warning fix on platforms where XP_MACOSX is undefined.
3190         https://bugs.webkit.org/show_bug.cgi?id=43192
3191
3192         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3193         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
3194
3195 2010-07-29  Adam Roben  <aroben@apple.com>
3196
3197         Give find-included-framework-headers our standard license
3198
3199         * Scripts/find-included-framework-headers: Used the license from
3200         WebCore/LICENSE-APPLE.
3201
3202 2010-07-29  Adam Roben  <aroben@apple.com>
3203
3204         Speed up find-included-framework-headers
3205
3206         We only do one invocation of find now, no longer pipe to grep, and
3207         replace uniq with sort -u.
3208
3209         Also added a license header.
3210
3211         * Scripts/find-included-framework-headers:
3212
3213 2010-07-29  Steve Block  <steveblock@google.com>
3214
3215         Reviewed by Jeremy Orlow.
3216
3217         Add LayoutTestController methods to test DeviceOrientation
3218         https://bugs.webkit.org/show_bug.cgi?id=39589
3219
3220         * DumpRenderTree/LayoutTestController.cpp:
3221         (setMockDeviceOrientationCallback):
3222         (LayoutTestController::staticFunctions):
3223         * DumpRenderTree/LayoutTestController.h:
3224         * DumpRenderTree/chromium/LayoutTestController.cpp:
3225         * DumpRenderTree/chromium/LayoutTestController.h:
3226         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3227         (LayoutTestController::setMockDeviceOrientation):
3228         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3229         (LayoutTestController::setMockDeviceOrientation):
3230         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3231         (LayoutTestController::setMockDeviceOrientation):
3232         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3233         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3234         (LayoutTestController::setMockDeviceOrientation):
3235         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3236         (LayoutTestController::setMockDeviceOrientation):
3237         * Scripts/build-webkit:
3238
3239 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
3240
3241         Reviewed by Shinichiro Hamaji.
3242
3243         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
3244         check-webkit-style gives false positives in single-line functions.
3245
3246         * Scripts/webkitpy/style/checkers/cpp.py:
3247         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3248
3249 2010-07-28  Darin Adler  <darin@apple.com>
3250
3251         Reviewed by Sam Weinig.
3252
3253         WebKitTestRunner needs to support layoutTestController.execCommand
3254         <https://bugs.webkit.org/show_bug.cgi?id=42538>
3255
3256         WebKitTestRunner needs layoutTestController.isCommandEnabled
3257         <https://bugs.webkit.org/show_bug.cgi?id=42671>
3258
3259         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3260         Added execCommand and isCommandEnabled.
3261         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3262         (WTR::LayoutTestController::execCommand): Added.
3263         (WTR::LayoutTestController::isCommandEnabled): Added.
3264         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3265
3266 2010-07-28  Kent Tamura  <tkent@chromium.org>
3267
3268         Reviewed by Dimitri Glazkov.
3269
3270         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
3271         https://bugs.webkit.org/show_bug.cgi?id=43123
3272
3273         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
3274         which overrides test expectations only for DumpRenderTree, in
3275         order to manage what problems are investigated.
3276         This change will be reverted when we switch to DRT completely.
3277
3278         * Scripts/webkitpy/layout_tests/port/chromium.py:
3279          Add drt_expectations.txt content to the result of
3280          test_expectations_overrides() if --use-drt is specified.
3281
3282 2010-07-28  Brady Eidson  <beidson@apple.com>
3283
3284         Reviewed by Darin Adler.
3285
3286         First pass at visited link support for WK2
3287         https://bugs.webkit.org/show_bug.cgi?id=43157
3288
3289         * MiniBrowser/mac/AppDelegate.m:
3290         (didNavigateWithNavigationData):
3291         (didPerformClientRedirect):
3292         (didPerformServerRedirect):
3293         (didUpdateHistoryTitle):
3294         (populateVisitedLinks): Added for the new version of the HistoryClient.
3295         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
3296         
3297         * MiniBrowser/mac/BrowserWindowController.m:
3298         (-[BrowserWindowController awakeFromNib]):
3299
3300 2010-07-28  Robin Dunn  <robin@alldunn.com>
3301
3302         Reviewed by Kevin Ollivier.
3303
3304         Add DOM bindings support for wx port.
3305
3306         * DumpRenderTree/wscript:
3307         * wx/browser/wscript:
3308         * wx/build/settings.py:
3309
3310 2010-07-28  Tony Chang  <tony@chromium.org>
3311
3312         Reviewed by Kent Tamura.
3313
3314         [chromium] cleanup temp files left by Linux DRT
3315         https://bugs.webkit.org/show_bug.cgi?id=43062
3316
3317         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
3318         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
3319             by crashed DRTs
3320
3321 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
3322
3323         Rubber-stamped by Kenneth Christiansen.
3324
3325         More Developer menu items reordering.
3326
3327         Grouping related menu items together, visually and logically (in the code).
3328
3329         No behavior change.
3330
3331         * QtTestBrowser/main.cpp:
3332         (LauncherWindow::createChrome):
3333
3334 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
3335
3336         Reviewed by Ojan Vafai.
3337
3338         Add FILE_SYSTEM build flag for FileSystem API
3339         https://bugs.webkit.org/show_bug.cgi?id=42915
3340
3341         * Scripts/build-webkit:
3342
3343 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
3344
3345         Reviewed by David Levin.
3346
3347         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
3348         https://bugs.webkit.org/show_bug.cgi?id=43090
3349
3350         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
3351         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
3352
3353 2010-07-27  Kent Tamura  <tkent@chromium.org>
3354
3355         Unreviewed, trivial typo fix.
3356
3357         * Scripts/webkitpy/layout_tests/port/chromium.py:
3358           Fix a wrong method name committed by r64109.
3359
3360 2010-07-27  Sam Weinig  <sam@webkit.org>
3361
3362         Reviewed by Anders Carlsson.
3363
3364         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
3365         Clean up handling of strings at the WebKit2 API layer.
3366
3367         * MiniBrowser/mac/BrowserWindowController.m:
3368         (runJavaScriptAlert):
3369         (runJavaScriptConfirm):
3370         (runJavaScriptPrompt):
3371         (didNavigateWithNavigationData):
3372         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3373         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3374         (_didClearWindowForFrame):
3375
3376 2010-07-27  Ojan Vafai  <ojan@chromium.org>
3377
3378         Reviewed by Eric Seidel.
3379
3380         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
3381         https://bugs.webkit.org/show_bug.cgi?id=42984
3382
3383         squash and no_squash have been intentionally erroring for a couple weeks now.
3384         But post-commits was just broken. Just remove squash/no_squash.
3385
3386         * Scripts/webkitpy/tool/steps/abstractstep.py:
3387         * Scripts/webkitpy/tool/steps/options.py:
3388
3389 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
3390
3391         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
3392
3393         * wx/build/settings.py:
3394
3395 2010-07-27  Adam Roben  <aroben@apple.com>
3396
3397         Mac build fix
3398
3399         * MiniBrowser/mac/BrowserWindowController.m:
3400         (processDidExit):
3401         (-[BrowserWindowController awakeFromNib]):
3402         Added processDidExit support.
3403
3404 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
3405
3406         Rubber-stamped by Simon Hausmann.
3407
3408         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
3409
3410         Move some less useful menu items on Developers menu from the top to the bottom, so
3411         QGraphicsView menu goes to the top, and becomes more quickly accessible.
3412
3413         * QtTestBrowser/main.cpp:
3414         (LauncherWindow::createChrome):
3415
3416 2010-07-26  Adam Roben  <aroben@apple.com>
3417
3418         Fix the path to InjectedBundle.dll in Debug_Internal builds
3419
3420         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
3421         InjectedBundle.dll in the Debug_Internal configuration
3422
3423         Reviewed by Anders Carlsson.
3424
3425         * WebKitTestRunner/win/TestControllerWin.cpp:
3426         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
3427         suffix only in Debug_All builds.
3428
3429 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3430
3431         Reviewed by Darin Adler.
3432
3433         https://bugs.webkit.org/show_bug.cgi?id=42947
3434         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
3435         error. Without which dumpRenderTree crashes.
3436
3437         * Scripts/old-run-webkit-tests:
3438
3439 2010-07-27  Kent Tamura  <tkent@chromium.org>
3440
3441         Reviewed by Dimitri Glazkov.
3442
3443         https://bugs.webkit.org/show_bug.cgi?id=42956
3444         [DRT/Chromium] Fix "out of sync" assertion error
3445
3446         Fix an assertion error on Windows like the following:
3447         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
3448         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3449         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3450
3451         * Scripts/webkitpy/layout_tests/port/chromium.py:
3452         If the url matches with "file:///[a-z]:", does case-ignore comparison.
3453         GURL capitalize the driver letter of a file: URL.
3454
3455 2010-07-26  Darin Adler  <darin@apple.com>
3456
3457         Reviewed by Sam Weinig.
3458
3459         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
3460         https://bugs.webkit.org/show_bug.cgi?id=42537
3461
3462         WebKitTestRunner needs layoutTestController.markerTextForListItem
3463         https://bugs.webkit.org/show_bug.cgi?id=42549
3464
3465         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3466         Fixed _paramterExpression typo. Improved support for string type as a
3467         return value, so we don't try to include DOMString.h and we can convert
3468         the string to a JSValue by calling JSValueMakeStringOrNull.
3469
3470         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
3471         Added JSValueMakeStringOrNull, used by the code generator.
3472
3473         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3474         Added counterValueForElementById and markerTextForListItem.
3475
3476         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3477         Moved constant to the top of the file.
3478         (WTR::toCF): Added. Converts strings to CFStringRef.
3479         (WTR::toWK): Added. Converts strings to WKStringRef.
3480         (WTR::toJS): Added. Converts strings to JSStringRef.
3481         (WTR::setProperty): Moved this function to the top of the file
3482         rather than having it down where it's used inside the class. Also
3483         renamed it so it's a separate function rather than an overload of
3484         JSObjectSetProperty.
3485         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
3486         Should move it somewhere we can share it.
3487         (WTR::propertyObject): Ditto.
3488         (WTR::getElementById): Added. Calls getElementById through the magic
3489         of JavaScript.
3490         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3491         Chagned to use toWK instead of four local variables.
3492         (WTR::LayoutTestController::counterValueForElementById): Added.
3493         Calls WKBundleFrameCopyCounterValue.
3494         (WTR::LayoutTestController::markerTextForListItem): Added.
3495         Calls WKBundleFrameCopyMarkerText.
3496
3497         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3498         Added counterValueForElementById and markerTextForListItem.
3499
3500 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
3501
3502         Reviewed by Gustavo Noronha Silva.
3503
3504         [GTK] The EventSender should support simulating drop events
3505         https://bugs.webkit.org/show_bug.cgi?id=39844
3506
3507         Add initial dropping support to the GTK+ EventSender.
3508
3509         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3510         (createWebView): Listen for some new drag-and-drop signals.
3511         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
3512         (dispatchEvent):
3513         Detect situations where a drag is either starting or ending and massage
3514         GTK+ into sending the appropriate signals to the WebView.
3515         (replaySavedEvents): Remove comment.
3516         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
3517         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
3518         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
3519         (dragFailedCallback): Disable the GTK+ drag failed animation.
3520         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
3521
3522 2010-07-26  Daniel Bates  <dbates@rim.com>
3523
3524         Reviewed by Darin Adler.
3525
3526         svn-unapply warns of uninitialized variable when unapplying
3527         a patch that describes an svn move operation
3528         https://bugs.webkit.org/show_bug.cgi?id=42036
3529
3530         Fixes Perl uninitialized variable warnings when un-applying
3531         a patch that moves a file.
3532
3533         * Scripts/svn-unapply:
3534           - Modified patch() so that it initializes $patch to the empty
3535             string when we don't have svnConvertedText (such as when
3536             reversing a diff that represents a svn copy/move operation).
3537
3538 2010-07-26  Sam Weinig  <sam@webkit.org>
3539
3540         Reviewed by Anders Carlsson.
3541
3542         Move some non-APIish functions into private headers.
3543
3544         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3545         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3546
3547 2010-07-26  Sam Weinig  <sam@webkit.org>
3548
3549         Reviewed by Anders Carlsson.
3550
3551         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
3552         Add prompt and confirm client functions to WebKit2
3553
3554         * MiniBrowser/mac/BrowserWindowController.m:
3555         (-[BrowserWindowController awakeFromNib]):
3556
3557 2010-07-26  Adam Roben  <aroben@apple.com>
3558
3559         Windows build fix
3560
3561         * MiniBrowser/MiniBrowser.vcproj:
3562         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3563         Removed empty attributes so the values will be picked up from the
3564         vsprops files. (Also removed a couple of attributes that accidentally
3565         duplicated values from the vsprops files.)
3566
3567 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
3568
3569         Rubber-stamped by Adam Roben.
3570         
3571         Touch MiniBrowser's stdafx to fix the build.
3572
3573         * MiniBrowser/win/stdafx.h:
3574
3575 2010-07-26  Hayato Ito  <hayato@chromium.org>
3576
3577         Reviewed by Shinichiro Hamaji.
3578
3579         Add pretty printer of WTF::Vector for GDB 7.
3580
3581         https://bugs.webkit.org/show_bug.cgi?id=40909
3582
3583         * gdb/wtf.py: Added.
3584
3585 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3586
3587         Reviewed by Simon Hausmann.
3588
3589         [Qt] Fix feature detection regexp
3590
3591         We were missing the last feature
3592
3593         * Scripts/webkitdirs.pm:
3594
3595 2010-07-25  Darin Adler  <darin@apple.com>
3596
3597         Reviewed by Dan Bernstein.
3598
3599         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
3600         https://bugs.webkit.org/show_bug.cgi?id=42326
3601
3602         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3603         Added dumpSelectionRect.
3604
3605         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3606         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
3607         does nothing because its purpose is to change pixel test output and
3608         we do not have pixel tests implemented yet.
3609
3610 2010-07-25  Darin Adler  <darin@apple.com>
3611
3612         Reviewed by Maciej Stachowiak.
3613
3614         WebKitTestRunner needs to support layoutTestController.keepWebHistory
3615         https://bugs.webkit.org/show_bug.cgi?id=42323
3616
3617         Added keepWebHistory and computedStyleIncludingVisitedInfo.
3618
3619         Also fixed misspellings of the word "receive".
3620
3621         Also tweaked the names of some of the LayoutTestController members.
3622
3623         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3624         Added support for a type named "object" that is passed and returns as
3625         a JSValueRef.
3626
3627         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3628         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
3629         put setAcceptsEditing up nearer the top.
3630
3631         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3632         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
3633         (WTR::InjectedBundle::initialize): Ditto.
3634         (WTR::InjectedBundle::didReceiveMessage): Ditto.
3635         (WTR::InjectedBundle::reset): Reset the state of visited links between
3636         tests. Also eliminated the unused argument to the LayoutTestController
3637         create function.
3638         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
3639         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
3640
3641         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3642         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
3643         instead of acceptsEditing.
3644         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
3645         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
3646         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
3647         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
3648         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
3649         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
3650
3651         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3652         (WTR::LayoutTestController::create): Removed uneeded argument.
3653         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
3654         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
3655         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
3656         about the fact that this works on the main frame.
3657         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
3658         (WTR::LayoutTestController::keepWebHistory): Added.
3659         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
3660         (WTR::JSObjectSetProperty): Added. Helper to make the function below
3661         cleaner.
3662         (WTR::LayoutTestController::makeWindowObject): Changed to use the
3663         overload of JSObjectSetProperty above.
3664
3665         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
3666         match above.
3667
3668         * WebKitTestRunner/TestController.cpp:
3669         (WTR::TestController::initialize): Fixed mispellings of receive.
3670         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
3671         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
3672         * WebKitTestRunner/TestController.h: Ditto.
3673         * WebKitTestRunner/TestInvocation.cpp:
3674         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
3675         * WebKitTestRunner/TestInvocation.h: Ditto.
3676
3677 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
3678
3679         Reviewed by Sam Weinig.
3680
3681         https://bugs.webkit.org/show_bug.cgi?id=42193
3682         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
3683
3684         Step 2 - add the rest of editing delegates.
3685
3686         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3687         (WTR::operator<<): Fixed to not crash when range is null.
3688         (WTR::InjectedBundlePage::InjectedBundlePage):
3689         (WTR::InjectedBundlePage::_shouldEndEditing):
3690         (WTR::InjectedBundlePage::_shouldInsertNode):
3691         (WTR::InjectedBundlePage::_shouldInsertText):
3692         (WTR::InjectedBundlePage::_shouldDeleteRange):
3693         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
3694         (WTR::InjectedBundlePage::_shouldApplyStyle):
3695         (WTR::InjectedBundlePage::_didBeginEditing):
3696         (WTR::InjectedBundlePage::_didEndEditing):
3697         (WTR::InjectedBundlePage::_didChange):
3698         (WTR::InjectedBundlePage::_didChangeSelection):
3699         (WTR::InjectedBundlePage::shouldEndEditing):
3700         (WTR::InjectedBundlePage::shouldInsertNode):
3701         (WTR::InjectedBundlePage::shouldInsertText):
3702         (WTR::InjectedBundlePage::shouldDeleteRange):
3703         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3704         (WTR::InjectedBundlePage::shouldApplyStyle):
3705         (WTR::InjectedBundlePage::didBeginEditing):
3706         (WTR::InjectedBundlePage::didEndEditing):
3707         (WTR::InjectedBundlePage::didChange):
3708         (WTR::InjectedBundlePage::didChangeSelection):
3709         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3710
3711 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
3712
3713         Reviewed by David Kilzer.
3714
3715         AX: need a layout test testing misspelled words in attributed strings
3716         https://bugs.webkit.org/show_bug.cgi?id=42899
3717
3718         * DumpRenderTree/AccessibilityUIElement.cpp:
3719         (attributedStringForRangeCallback):
3720         (attributedStringRangeIsMisspelledCallback):
3721         (AccessibilityUIElement::getJSClass):
3722         * DumpRenderTree/AccessibilityUIElement.h:
3723         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3724         (AccessibilityUIElement::attributedStringForRange):
3725         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3726         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3727         (AccessibilityUIElement::attributedStringForRange):
3728         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3729         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3730         (AccessibilityUIElement::attributedStringForRange):
3731         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3732
3733 2010-07-23  David Kilzer  <ddkilzer@apple.com>
3734
3735         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
3736
3737         Reviewed by Mark Rowe.
3738
3739         * Scripts/check-for-inappropriate-files-in-framework: Added
3740         check for the SHALLOW_BUNDLE environment variable so that the
3741         script will work with iOS WebKit builds.
3742         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
3743
3744 2010-07-22  Darin Adler  <darin@apple.com>
3745
3746         Reviewed by Sam Weinig.
3747
3748         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
3749         https://bugs.webkit.org/show_bug.cgi?id=42847
3750
3751         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3752         (WTR::operator<<): Replaced the WKStringToUTF8 function with
3753         a set of overloaded stream operators.
3754         (WTR::dumpPath): Changed to use ostringstream and return a string.
3755         (WTR::propertyValue): Added.
3756         (WTR::propertyObject): Added.
3757         (WTR::propertyString): Added.
3758         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
3759         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
3760         since we now have suitable streaming functions.
3761         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
3762         WKBundleFrameCopyInnerText.
3763         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
3764         since we now have suitable streaming functions.
3765         (WTR::InjectedBundlePage::dump): Ditto.
3766         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
3767         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
3768         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
3769         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
3770         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
3771
3772 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
3773
3774         Reviewed by Sam Weinig and Darin Adler.
3775
3776         https://bugs.webkit.org/show_bug.cgi?id=42193
3777         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
3778
3779         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
3780         fixed, but this makes difference one line smaller on many editing tests.
3781
3782         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3783         Added dumpEditingCallbacks() and setAcceptsEditing().
3784
3785         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3786         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
3787         (WTR::operator<<): Print a range.
3788         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
3789         clients.
3790         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
3791         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
3792         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
3793         calls.
3794
3795         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3796         (WTR::LayoutTestController::LayoutTestController):
3797         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3798         (WTR::LayoutTestController::dumpEditingCallbacks):
3799         (WTR::LayoutTestController::setAcceptsEditing):
3800         (WTR::LayoutTestController::acceptsEditing):
3801         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
3802         Store m_acceptsEditing and m_dumpEditingCallbacks.
3803
3804 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
3805
3806         Reviewed by Laszlo Gombos.
3807
3808         [Qt] QtWebKit needs public API for Notifications.
3809         https://bugs.webkit.org/show_bug.cgi?id=41413
3810
3811         Update DumpRenderTree and QtTestBrowser to use the new API.
3812         Add new DRT API to flag that notifications permission requests should be ignored.
3813
3814         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3815         (WebCore::WebPage::WebPage):
3816         (WebCore::WebPage::requestPermission):
3817         (WebCore::WebPage::checkPermission):
3818         (WebCore::WebPage::cancelRequestsForPermission):
3819         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3820         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3821         (LayoutTestController::reset):
3822         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
3823         (LayoutTestController::checkDesktopNotificationPermission):
3824         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3825         (LayoutTestController::ignoreReqestForPermission):
3826         * QtTestBrowser/main.cpp:
3827         (LauncherWindow::LauncherWindow):
3828         * QtTestBrowser/webpage.cpp:
3829         (WebPage::WebPage):
3830         (WebPage::requestPermission):
3831         (WebPage::checkPermission):
3832         (WebPage::cancelRequestsForPermission):
3833         * QtTestBrowser/webpage.h:
3834
3835 2010-07-22  Darin Adler  <darin@apple.com>
3836
3837         Reviewed by Sam Weinig.
3838
3839         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
3840         https://bugs.webkit.org/show_bug.cgi?id=42325
3841
3842         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3843         Added dumpChildFramesAsText.
3844
3845         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3846         (WTR::dumpFrameText): Added.
3847         (WTR::dumpDescendantFramesText): Added.
3848         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
3849         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
3850         instead of the shouldDumpAsText function, and added a case for AllFramesText.
3851
3852         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
3853
3854         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3855         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
3856         m_whatToDump.
3857
3858         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
3859         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
3860         and shouldDumpSourceAsWebArchive. Added whatToDump.
3861
3862 2010-07-22  Adam Roben  <aroben@apple.com>
3863
3864         Windows build fix
3865
3866         Inspired by r63881.
3867
3868         * MiniBrowser/MiniBrowser.vcproj:
3869         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3870         Removed pre- and post-build events so they will be inherited from the
3871         vsprops files.
3872
3873 2010-07-21  Darin Adler  <darin@apple.com>
3874
3875         Reviewed by Sam Weinig.
3876
3877         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
3878         https://bugs.webkit.org/show_bug.cgi?id=42548
3879
3880         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3881         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3882         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
3883         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
3884         Changed to a file-internal function instead of a member function.
3885         (WTR::dumpDescendantFrameScrollPositions): Added.
3886         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
3887         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
3888         appropriate. Also streamlined all the WKStringToUTF8 call sites.
3889         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
3890         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
3891         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
3892         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
3893         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
3894
3895         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
3896
3897         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3898         (WTR::LayoutTestController::LayoutTestController): Initialize
3899         m_shouldDumpAllFrameScrollPositions.
3900         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
3901         shouldDumpFrameScrollPositions.
3902
3903         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
3904         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
3905         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
3906
3907 2010-07-21  Darin Adler  <darin@apple.com>
3908
3909         Reviewed by Sam Weinig.
3910
3911         WebKitTestRunner needs to support dumping of scroll position
3912         https://bugs.webkit.org/show_bug.cgi?id=42514
3913
3914         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3915         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
3916
3917         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3918         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
3919         instead of JSContextRef.
3920         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
3921         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
3922         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
3923         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
3924         instead of JSContextRef.
3925
3926         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
3927         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
3928
3929         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3930         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
3931         returns false.
3932         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
3933         returns false.
3934         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
3935         the logic in DumpRenderTree.
3936
3937         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
3938
3939         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
3940
3941 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
3942
3943         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
3944
3945         * wx/build/settings.py:
3946
3947 2010-07-21  Sam Weinig  <sam@webkit.org>
3948
3949         Reviewed by Anders Carlsson.
3950
3951         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
3952         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
3953
3954         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3955         (WTR::InjectedBundlePage::InjectedBundlePage):
3956         (WTR::InjectedBundlePage::_willAddMessageToConsole):
3957         (WTR::InjectedBundlePage::_willSetStatusbarText):
3958         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
3959         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
3960         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
3961         (WTR::InjectedBundlePage::willAddMessageToConsole):
3962         (WTR::InjectedBundlePage::willSetStatusbarText):
3963         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3964         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3965         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3966         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3967
3968 2010-07-21  Adam Roben  <aroben@apple.com>
3969
3970         Give InjectedBundle our standard set of configurations (minus the
3971         *_Cairo variants)
3972
3973         InjectedBundle's Debug_All configuration was the same as is Debug
3974         configuration, and it was missing a Debug_Internal configuration.
3975
3976         Fixes <http://webkit.org/b/42749> InjectedBundle's build
3977         configurations are screwy
3978
3979         Reviewed by Darin Adler.
3980
3981         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
3982         debug_internal.vsprops and debug_all.vsprops to the Debug_All
3983         configuration. Added a Debug_Internal configuration.
3984
3985         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
3986         variant of InjectedBundle when we're using the Debug_Internal solution
3987         configuration.
3988
3989 2010-07-21  Adam Roben  <aroben@apple.com>
3990
3991         Move InjectedBundle's settings to a vsprops file
3992
3993         This will make it easier to change settings for all configurations,
3994         and to add new configurations.
3995
3996         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
3997         files
3998
3999         Reviewed by Darin Adler.
4000
4001         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
4002         Moved settings here...
4003         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
4004         here.
4005
4006 2010-07-21  Adam Roben  <aroben@apple.com>
4007
4008         Give MiniBrowser our standard set of configurations (minus the *_Cairo
4009         variants)
4010
4011         MiniBrowser already had a configuration called "Release", but it was
4012         using mostly the same settings as Debug. And its Debug configuration
4013         was using the settings that Debug_Internal should be using.
4014
4015         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
4016         are screwy
4017
4018         Reviewed by Darin Adler.
4019
4020         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
4021         the Debug configuration. Remove debug.vsprops and
4022         debug_internal.vsprops from the Release configuration and replace them
4023         with release.vsprops. Added Debug_Internal and Debug_All
4024         configurations.
4025
4026 2010-07-21  Adam Roben  <aroben@apple.com>
4027
4028         Move MiniBrowser's settings to a vsprops file
4029
4030         This will make it easier to change settings for all configurations,
4031         and to add new configurations.
4032
4033         MiniBrowser should use vsprops files
4034         https://bugs.webkit.org/show_bug.cgi?id=42745
4035
4036         Reviewed by Darin Adler.
4037
4038         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
4039         settings here...
4040         * MiniBrowser/MiniBrowser.vcproj: ...from here.
4041
4042 2010-07-21  Adam Roben  <aroben@apple.com>
4043
4044         Fix compiler warnings when building MiniBrowser
4045
4046         Also cleaned up the .vcproj a bit.
4047
4048         Fixes <http://webkit.org/b/42743>.
4049
4050         Reviewed by Darin Adler.
4051
4052         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
4053         already defined in .vsprops files. This also fixes a warning about
4054         /EDITANDCONTINUE being incompatible with /SAFESEH.
4055
4056         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
4057         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
4058         being redefined. (I think this will also get us closer to building
4059         with VC++ Express.)
4060
4061 2010-07-20  Sam Weinig  <sam@webkit.org>
4062
4063         Reviewed by Jon Honeycutt.
4064
4065         Fix obvious typo.
4066
4067         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4068         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
4069
4070 2010-07-20  Tony Chang  <tony@chromium.org>
4071
4072         Reviewed by Kent Tamura.
4073
4074         [chromium] by default, dumpAsText should disable pixel results
4075         https://bugs.webkit.org/show_bug.cgi?id=42715
4076
4077         * DumpRenderTree/chromium/LayoutTestController.cpp:
4078         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
4079
4080 2010-07-20  Adam Roben  <aroben@apple.com>
4081
4082         Windows build fix
4083
4084         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
4085         WebKit.lib instead of the old, dusty WebKit2.lib.
4086
4087 2010-07-20  Adam Roben  <aroben@apple.com>
4088
4089         Stop linking WebKitTestRunner against getopt
4090
4091         Use of getopt was removed in r63700.
4092
4093         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
4094         getopt, but doesn't need to
4095
4096         Reviewed by Sam Weinig.
4097
4098         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
4099         from all configurations.
4100
4101 2010-07-20  Adam Roben  <aroben@apple.com>
4102
4103         Make run-webkit-tests --webkit-test-runner "work" on Windows
4104
4105         WebKitTestRunner crashes on launch, but at least the scripts build and
4106         launch it!
4107
4108         Fixes <http://webkit.org/b/42709> run-webkit-tests
4109         --webkit-test-runner bails with an error on Windows
4110
4111         Reviewed by Anders Carlsson.
4112
4113         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
4114         Windows.
4115         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
4116         projects (from first-built to last-built): FindSafari, ImageDiff,
4117         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
4118
4119 2010-07-20  Adam Roben  <aroben@apple.com>
4120
4121         Change build-webkit back to building WebKit.sln on Windows
4122
4123         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
4124         is being removed.
4125
4126         Rubber-stamped in advance by Steve Falkenburg.
4127
4128         * Scripts/build-webkit:
4129
4130 2010-07-20  Adam Roben  <aroben@apple.com>
4131
4132         Windows build fix
4133
4134         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
4135
4136 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
4137
4138         Reviewed by Geoffrey Garen.
4139
4140         WebScriptObject Should Allow Safely Checking For Key Existence
4141         https://bugs.webkit.org/show_bug.cgi?id=42613
4142
4143         Normal ObjCController workflow for a WebScriptObject test.
4144
4145         * DumpRenderTree/mac/ObjCController.m:
4146         (+[ObjCController isSelectorExcludedFromWebScript:]):
4147         (+[ObjCController webScriptNameForSelector:]):
4148         (-[ObjCController testHasWebScriptKey:]):
4149
4150 2010-07-20  Chris Marrin  <cmarrin@apple.com>
4151
4152         Reviewed by Simon Fraser.
4153
4154         https://bugs.webkit.org/show_bug.cgi?id=42118
4155         Disable compositing/webgl tests if WebGL is not enabled
4156
4157         * Scripts/old-run-webkit-tests:
4158
4159 2010-07-20  Anton Muhin  <antonm@chromium.org>
4160
4161         Reviewed by Darin Adler.
4162
4163         Print additional information about exception if failed to connect to apache (in verbose mode).
4164         https://bugs.webkit.org/show_bug.cgi?id=42627
4165
4166         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
4167
4168 2010-07-20  Tony Chang  <tony@chromium.org>
4169
4170         Reviewed by David Levin.
4171
4172         [chromium] only pass --force to gclient sync if explicitly stated
4173         https://bugs.webkit.org/show_bug.cgi?id=42581
4174
4175         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
4176               always pass --force since it's hard to do manual cleanups
4177         * Scripts/update-webkit-chromium: only pass --force if --force is
4178               passed in
4179
4180 2010-07-19  Anders Carlsson  <andersca@apple.com>
4181
4182         Fix build.
4183
4184         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4185         Paths of generated files should be relative to the build product.
4186
4187 2010-07-19  Daniel Bates  <dbates@rim.com>
4188
4189         Reviewed by Adam Roben.
4190
4191         [Win] Implement LayoutTestController::markerTextForListItem()
4192         https://bugs.webkit.org/show_bug.cgi?id=37930
4193
4194         Implements DRT support for markerTextForListItem in the Windows port.
4195
4196         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4197         (LayoutTestController::markerTextForListItem): Implemented.
4198
4199 2010-07-19  Jessie Berlin  <jberlin@apple.com>
4200
4201         Windows build fix. Unreviewed.
4202
4203         * WebKitTestRunner/win/TestControllerWin.cpp:
4204         (WTR::TestController::initializeTestPluginPath):
4205
4206 2010-07-19  Sam Weinig  <sam@webkit.org>
4207
4208         Reviewed by Jon Honeycutt.
4209
4210         Remove dependency on getopt from WebKitTestRunner.
4211
4212         - Simplify options parsing and eliminate unused options.
4213
4214         * WebKitTestRunner/TestController.cpp:
4215         (WTR::TestController::TestController):
4216         (WTR::TestController::initialize):
4217         * WebKitTestRunner/TestController.h:
4218         (WTR::TestController::testPluginPath):
4219         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4220         * WebKitTestRunner/mac/TestControllerMac.mm:
4221         (WTR::TestController::platformInitialize):
4222         (WTR::TestController::initializeTestPluginPath):
4223         * WebKitTestRunner/win/TestControllerWin.cpp:
4224         (WTR::TestController::platformInitialize):
4225         (WTR::TestController::initializeTestPluginPath):
4226
4227 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
4228
4229         Reviewed by Antonio Gomes.
4230
4231         [Qt] MiniBrowser: Progress indication at address bar
4232         https://bugs.webkit.org/show_bug.cgi?id=42565
4233
4234         Make possible to see load progress at address bar based on
4235         QtTestBrowser solution
4236
4237         * MiniBrowser/qt/BrowserWindow.cpp:
4238         (BrowserWindow::BrowserWindow):
4239         (BrowserWindow::loadProgress):
4240         * MiniBrowser/qt/BrowserWindow.h:
4241
4242 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
4243
4244         Reviewed by Antonio Gomes.
4245
4246         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
4247         https://bugs.webkit.org/show_bug.cgi?id=42564
4248
4249         * MiniBrowser/qt/BrowserWindow.cpp:
4250         (BrowserView::load):
4251         (BrowserWindow::BrowserWindow):
4252         (BrowserWindow::titleChanged):
4253         (BrowserWindow::urlChanged):
4254         * MiniBrowser/qt/BrowserWindow.h:
4255
4256 2010-07-19  Sam Weinig  <weinig@apple.com>
4257
4258         Reviewed by Adam Roben.
4259
4260         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
4261         Auto-generate the JS bindings for WebKitTestRunner's script objects.
4262
4263         * WebKitTestRunner/Configurations/Base.xcconfig:
4264         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4265         * WebKitTestRunner/DerivedSources.make: Added.
4266         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
4267         * WebKitTestRunner/InjectedBundle/Bindings: Added.
4268         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
4269         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
4270         (WTR::JSWrappable::~JSWrappable):
4271         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
4272         (WTR::JSWrapper::wrap):
4273         (WTR::JSWrapper::unwrap):
4274         (WTR::unwrapObject):
4275         (WTR::JSWrapper::initialize):
4276         (WTR::JSWrapper::finalize):
4277         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
4278         (WTR::toJS):
4279         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
4280         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4281         (WTR::InjectedBundlePage::dump):
4282         (WTR::InjectedBundlePage::setStatusbarText):
4283         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4284         (WTR::LayoutTestController::wrapperClass):
4285         (WTR::LayoutTestController::waitUntilDone):
4286         (WTR::LayoutTestController::makeWindowObject):
4287         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4288         (WTR::LayoutTestController::shouldDumpAsText):
4289         (WTR::LayoutTestController::dumpAsText):
4290         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
4291         (WTR::LayoutTestController::dumpStatusCallbacks):
4292         (WTR::LayoutTestController::waitToDump):
4293         (WTR::LayoutTestController::testRepaint):
4294         (WTR::LayoutTestController::repaintSweepHorizontally):
4295         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
4296         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4297         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
4298         * WebKitTestRunner/win/build-generated-files.sh: Added.
4299
4300 2010-07-19  Mark Rowe  <mrowe@apple.com>
4301
4302         Clean up the buildbot configuration a little.
4303
4304         * BuildSlaveSupport/build.webkit.org-config/config.json:
4305
4306 2010-07-19  Chris Marrin  <cmarrin@apple.com>
4307
4308         Reviewed by Darin Adler.
4309
4310         https://bugs.webkit.org/show_bug.cgi?id=42118
4311         Disable WebGL on Leopard for now. 
4312
4313         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
4314         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
4315         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
4316         software OpenGL driver on machines without this support.
4317
4318         * Scripts/build-webkit:
4319
4320 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
4321
4322         Reviewed by Brady Eidson.
4323