ccd6868a645a657bb8e674398d0ab69284149599
[WebKit.git] / WebKitTools / ChangeLog
1 2010-09-11  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Maciej Stachowiak.
4
5         Fix zoom related tests when testing WebKit2.
6
7         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
8         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
9
10 2010-09-11  Sam Weinig  <sam@webkit.org>
11
12         Reviewed by Dan Bernstein.
13
14         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
15         <rdar://problem/8359252>
16         https://bugs.webkit.org/show_bug.cgi?id=45605
17
18         * MiniBrowser/mac/BrowserWindowController.m:
19         (setStatusText):
20         (contentsSizeChanged):
21         (-[BrowserWindowController awakeFromNib]):
22         * MiniBrowser/win/BrowserView.cpp:
23         (runJavaScriptConfirm):
24         (runJavaScriptPrompt):
25         (setStatusText):
26         (contentsSizeChanged):
27         (BrowserView::create):
28         * WebKitTestRunner/TestController.cpp:
29         (WTR::createOtherPage):
30         (WTR::TestController::initialize):
31
32 2010-09-11  Sam Weinig  <sam@webkit.org>
33
34         Reviewed by Dan Bernstein.
35
36         Add callback mechanism for the getting the source of a frame
37         <rdar://problem/8364681>
38         https://bugs.webkit.org/show_bug.cgi?id=45604
39
40         Add ability to dump the main frame's source to the console.
41
42         * MiniBrowser/mac/BrowserWindowController.h:
43         * MiniBrowser/mac/BrowserWindowController.m:
44         (-[BrowserWindowController dumpSourceToConsole:]):
45         * MiniBrowser/mac/MainMenu.xib:
46
47 2010-09-11  Eric Seidel  <eric@webkit.org>
48
49         Reviewed by Adam Barth.
50
51         Remove unneeded Empty Queue messages
52         https://bugs.webkit.org/show_bug.cgi?id=45602
53
54         We already have a /gc job to delete these.
55         recentstatus.py is already smart enough to use the
56         most recent of the workitems last update or the most recent status,
57         so removing these should not change the _last_status_date() return
58         value more than a few milliseconds.
59
60         These messages just spam the recent status log.
61
62         * Scripts/webkitpy/tool/commands/queues.py:
63
64 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
65
66         Reviewed by Adam Barth.
67
68         Fix Python exception when generating synthetic patch IDs
69         https://bugs.webkit.org/show_bug.cgi?id=45592
70
71         Can't concatenate strings and numbers directly.
72
73         * QueueStatusServer/handlers/queuestatus.py:
74
75 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
76
77         Reviewed by Adam Barth.
78
79         Group statuses in queue status by patch ID
80         https://bugs.webkit.org/show_bug.cgi?id=45588
81
82         Group statuses by patch ID so that the status page is easier
83         to scan.
84
85         * QueueStatusServer/handlers/queuestatus.py:
86         * QueueStatusServer/stylesheets/dashboard.css:
87         (.status-group):
88         (.status-bug):
89         (.status-group ul):
90         (.status-group ul li):
91         (.status-group ul li:hover):
92         (.status-cell):
93         (.status-cell:hover):
94         (.status-cell.pass):
95         (.status-cell.fail):
96         (.status-cell.pending):
97         (.status-cell.error):
98         * QueueStatusServer/templates/dashboard.html:
99         * QueueStatusServer/templates/queuestatus.html:
100
101 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
102
103         Reviewed by Tony Chang.
104
105         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
106         https://bugs.webkit.org/show_bug.cgi?id=45479
107
108         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
109         implementation in ResourceLoadDelegate in the Mac port).
110
111         * DumpRenderTree/chromium/LayoutTestController.cpp:
112         (LayoutTestController::LayoutTestController):
113         (LayoutTestController::dumpResourceResponseMIMETypes):
114         (LayoutTestController::reset):
115         * DumpRenderTree/chromium/LayoutTestController.h:
116         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
117         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
118         * DumpRenderTree/chromium/TestShell.h:
119         (TestShell::shouldDumpResourceResponseMIMETypes):
120         * DumpRenderTree/chromium/WebViewHost.cpp:
121         (WebViewHost::didReceiveResponse):
122
123 2010-09-11  Eric Seidel  <eric@webkit.org>
124
125         Reviewed by Adam Barth.
126
127         queues.webkit.org should expose /remote_api for data upload/download
128         https://bugs.webkit.org/show_bug.cgi?id=45559
129
130         * QueueStatusServer/app.yaml:
131          - /remote_api is a standard app-engine service which allows use of
132            the bulk uploader for data upload/download.  Exposing this
133            (for admin access only) allows us to use 
134
135 2010-09-10  Sam Weinig  <sam@webkit.org>
136
137         Reviewed by Dan Bernstein.
138
139         Add zoom support to WebKit2 API
140         <rdar://problem/7660657>
141         https://bugs.webkit.org/show_bug.cgi?id=45585
142
143         - Add zoom options to MiniBrowser that mimic Safari's options using
144           the new WebKit2 zoom APIs.
145         - Switch uses of float for the zoom APIs to use double.
146
147         * MiniBrowser/mac/BrowserWindowController.h:
148         * MiniBrowser/mac/BrowserWindowController.m:
149         (-[BrowserWindowController initWithPageNamespace:]):
150         (-[BrowserWindowController validateMenuItem:]):
151         (-[BrowserWindowController validateUserInterfaceItem:]):
152         (-[BrowserWindowController currentZoomFactor]):
153         (-[BrowserWindowController setCurrentZoomFactor:]):
154         (-[BrowserWindowController canZoomIn]):
155         (-[BrowserWindowController zoomIn:]):
156         (-[BrowserWindowController canZoomOut]):
157         (-[BrowserWindowController zoomOut:]):
158         (-[BrowserWindowController canResetZoom]):
159         (-[BrowserWindowController resetZoom:]):
160         (-[BrowserWindowController toggleZoomMode:]):
161         * MiniBrowser/mac/MainMenu.xib:
162         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
163         (WTR::EventSendingController::textZoomIn):
164         (WTR::EventSendingController::textZoomOut):
165         (WTR::EventSendingController::zoomPageIn):
166         (WTR::EventSendingController::zoomPageOut):
167
168 2010-09-10  Robert Hogan  <robert@webkit.org>
169
170         Reviewed by Andreas Kling.
171
172         [Qt] Fix crash in DRT in standalone mode
173
174         https://bugs.webkit.org/show_bug.cgi?id=45454
175
176         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
177         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
178
179 2010-09-10  Sam Weinig  <sam@webkit.org>
180
181         Reviewed by Darin Adler.
182
183         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
184         Precursor to <rdar://problem/7660657>
185         https://bugs.webkit.org/show_bug.cgi?id=45522
186
187         Update for changes to the Bundle API to allow separate control of page and text zoom
188         levels.
189
190         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
191         (WTR::EventSendingController::textZoomIn):
192         (WTR::EventSendingController::textZoomOut):
193         (WTR::EventSendingController::zoomPageIn):
194         (WTR::EventSendingController::zoomPageOut):
195         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
196         (WTR::InjectedBundlePage::reset):
197
198 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
199
200         Reviewed by Andreas Kling.
201
202         [Qt] Support click event for notifications
203         https://bugs.webkit.org/show_bug.cgi?id=44836
204
205         Add support for simulateDesktopNotificationClick by calling
206         back to DumpRenderTreeSupportQt.cpp.
207
208         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
209         (LayoutTestController::simulateDesktopNotificationClick):
210         * DumpRenderTree/qt/LayoutTestControllerQt.h:
211
212 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
213
214         Reviewed by Eric Seidel.
215
216         Update queue status when patches fail their first land attempt
217         https://bugs.webkit.org/show_bug.cgi?id=45583
218
219         Add a few more _update_status calls to make it more obvious if a patch is 
220         being retried because tests failed.
221
222         * Scripts/webkitpy/tool/commands/queues.py:
223
224 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
225
226         Reviewed by Andreas Kling.
227
228         [Qt] MiniBrowser crashes with multiply windows when closing one of them
229         https://bugs.webkit.org/show_bug.cgi?id=45536
230
231         * MiniBrowser/qt/BrowserView.cpp:
232         (BrowserView::BrowserView): Reference the context instead of adopting it
233         because it can be shared across different views.
234
235 2010-09-10  Tony Chang  <tony@chromium.org>
236
237         Unreviewed, rolling out r67241.
238         http://trac.webkit.org/changeset/67241
239         https://bugs.webkit.org/show_bug.cgi?id=44709
240
241         Accidentally committed.
242
243         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
244         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
245
246 2010-09-10  Tony Chang  <tony@chromium.org>
247
248         Reviewed by Ojan Vafai.
249
250         deduplicate-tests should be runnable from any WebKit directory
251         https://bugs.webkit.org/show_bug.cgi?id=44709
252
253         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
254         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
255
256 2010-09-10  Tony Chang  <tony@chromium.org>
257
258         Unreviewed, rolling out r67216.
259         http://trac.webkit.org/changeset/67216
260         https://bugs.webkit.org/show_bug.cgi?id=44709
261
262         Broke
263
264         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
265         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
266
267 2010-09-10  Tony Chang  <tony@chromium.org>
268
269         Reviewed by Ojan Vafai.
270
271         deduplicate-tests should be runnable from any WebKit directory
272         https://bugs.webkit.org/show_bug.cgi?id=44709
273
274         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
275         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
276
277 2010-09-09  Hans Wennborg  <hans@chromium.org>
278
279         Reviewed by Jeremy Orlow.
280
281         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
282         https://bugs.webkit.org/show_bug.cgi?id=45460
283
284         This enables DumpRenderTree to run layout tests for DeviceOrientation.
285
286         Also declare the LayoutTestController destructor out-of-line.
287         Otherwise the implicit destructor would cause compiler errors because
288         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
289
290         * DumpRenderTree/chromium/LayoutTestController.cpp:
291         (LayoutTestController::~LayoutTestController):
292         (LayoutTestController::setMockDeviceOrientation):
293         (LayoutTestController::deviceOrientationClient):
294         * DumpRenderTree/chromium/LayoutTestController.h:
295         * DumpRenderTree/chromium/WebViewHost.cpp:
296         (WebViewHost::deviceOrientationClient):
297         * DumpRenderTree/chromium/WebViewHost.h:
298
299 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
300
301         Unreviewed, rolling out r67119.
302         http://trac.webkit.org/changeset/67119
303         https://bugs.webkit.org/show_bug.cgi?id=45505
304
305         Extra newlines in results (Requested by tony^work on #webkit).
306
307         * DumpRenderTree/chromium/LayoutTestController.cpp:
308         (LayoutTestController::LayoutTestController):
309         (LayoutTestController::reset):
310         * DumpRenderTree/chromium/LayoutTestController.h:
311         * DumpRenderTree/chromium/TestShell.h:
312         * DumpRenderTree/chromium/WebViewHost.cpp:
313         (printResponseDescription):
314         (printNodeDescription):
315         (printRangeDescription):
316         (WebViewHost::shouldBeginEditing):
317         (WebViewHost::shouldEndEditing):
318         (WebViewHost::shouldInsertNode):
319         (WebViewHost::shouldChangeSelectedRange):
320         (WebViewHost::shouldDeleteRange):
321         (WebViewHost::shouldApplyStyle):
322         (WebViewHost::didBeginEditing):
323         (WebViewHost::didChangeSelection):
324         (WebViewHost::didChangeContents):
325         (WebViewHost::didEndEditing):
326         (WebViewHost::decidePolicyForNavigation):
327         (WebViewHost::didCancelClientRedirect):
328         (WebViewHost::didStartProvisionalLoad):
329         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
330         (WebViewHost::didFailProvisionalLoad):
331         (WebViewHost::didCommitProvisionalLoad):
332         (WebViewHost::didFinishDocumentLoad):
333         (WebViewHost::didHandleOnloadEvents):
334         (WebViewHost::didFailLoad):
335         (WebViewHost::didFinishLoad):
336         (WebViewHost::didChangeLocationWithinPage):
337         (WebViewHost::willSendRequest):
338         (WebViewHost::didReceiveResponse):
339         (WebViewHost::didFinishResourceLoad):
340         (WebViewHost::didFailResourceLoad):
341         (WebViewHost::didDisplayInsecureContent):
342         (WebViewHost::didRunInsecureContent):
343         (WebViewHost::printFrameDescription):
344
345 2010-09-09  Michael Saboff  <msaboff@apple.com>
346
347         Unreviewed, adding myself to committers list.
348
349         * Scripts/webkitpy/common/config/committers.py:
350
351 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
352
353         Reviewed by Tony Chang.
354
355         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
356         https://bugs.webkit.org/show_bug.cgi?id=45479
357
358         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
359         implementation in ResourceLoadDelegate in the Mac port).
360
361         * DumpRenderTree/chromium/LayoutTestController.cpp:
362         (LayoutTestController::LayoutTestController):
363         (LayoutTestController::dumpResourceResponseMIMETypes):
364         (LayoutTestController::reset):
365         * DumpRenderTree/chromium/LayoutTestController.h:
366         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
367         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
368         * DumpRenderTree/chromium/TestShell.h:
369         (TestShell::shouldDumpResourceResponseMIMETypes):
370         * DumpRenderTree/chromium/WebViewHost.cpp:
371         (WebViewHost::didReceiveResponse):
372
373 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
374
375         Reviewed by Daniel Bates.
376
377         svn-apply tries to delete directories it shouldn't
378         https://bugs.webkit.org/show_bug.cgi?id=45424
379
380         isDirectoryEmptyForRemoval had the wrong check. If an item in the
381         directory is itself a directory, then the directory is definitely
382         not empty.
383
384         * Scripts/svn-apply:
385
386 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
387
388         Fixing GTK and windows build failure.
389
390         AX: Support AccessibilityTextMarkers in DRT
391         https://bugs.webkit.org/show_bug.cgi?id=44778
392
393         * DumpRenderTree/AccessibilityTextMarker.h:
394         (AccessibilityTextMarker::platformTextMarker):
395         (AccessibilityTextMarkerRange::platformTextMarkerRange):
396         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
397         (AccessibilityTextMarker::platformTextMarker):
398         (AccessibilityTextMarkerRange::platformTextMarkerRange):
399
400 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
401
402         Reviewed by David Kilzer.
403
404         AX: Support AccessibilityTextMarkers in DRT
405         https://bugs.webkit.org/show_bug.cgi?id=44778
406
407         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
408         that WebCore uses when vending information about its VisiblePositions through AX.
409
410         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
411         methods for encapsulating and checking equality.
412
413         This will allow future bug fixes in the text marker system to be adequately tested.
414
415         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
416         (toTextMarker):
417         (isMarkerEqualCallback):
418         (markerFinalize):
419         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
420         (AccessibilityTextMarker::getJSClass):
421         (toTextMarkerRange):
422         (isMarkerRangeEqualCallback):
423         (markerRangeFinalize):
424         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
425         (AccessibilityTextMarkerRange::getJSClass):
426         * DumpRenderTree/AccessibilityTextMarker.h: Added.
427         (AccessibilityTextMarker::platformTextMarker):
428         (AccessibilityTextMarkerRange::platformTextMarkerRange):
429         (AccessibilityTextMarker::AccessibilityTextMarker):
430         (AccessibilityTextMarker::~AccessibilityTextMarker):
431         (AccessibilityTextMarker::isEqual):
432         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
433         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
434         (AccessibilityTextMarkerRange::isEqual):
435         * DumpRenderTree/AccessibilityUIElement.cpp:
436         (textMarkerRangeForElementCallback):
437         (textMarkerRangeLengthCallback):
438         (textMarkerRangeForMarkersCallback):
439         (startTextMarkerForTextMarkerRangeCallback):
440         (endTextMarkerForTextMarkerRangeCallback):
441         (accessibilityElementForTextMarkerCallback):
442         (AccessibilityUIElement::textMarkerRangeForElement):
443         (AccessibilityUIElement::textMarkerRangeLength):
444         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
445         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
446         (AccessibilityUIElement::accessibilityElementForTextMarker):
447         (AccessibilityUIElement::getJSClass):
448         * DumpRenderTree/AccessibilityUIElement.h:
449         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
450         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
451         (AccessibilityTextMarker::AccessibilityTextMarker):
452         (AccessibilityTextMarker::~AccessibilityTextMarker):
453         (AccessibilityTextMarker::isEqual):
454         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
455         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
456         (AccessibilityTextMarkerRange::isEqual):
457         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
458         (AccessibilityUIElement::textMarkerRangeForElement):
459         (AccessibilityUIElement::textMarkerRangeLength):
460         (AccessibilityUIElement::textMarkerRangeForMarkers):
461         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
462         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
463         (AccessibilityUIElement::accessibilityElementForTextMarker):
464         * DumpRenderTree/win/DumpRenderTree.vcproj:
465
466 2010-08-25  Tony Chang  <tony@chromium.org>
467
468         Reviewed by Ojan Vafai.
469
470         don't delete duplicates needed because of intermediate results
471         https://bugs.webkit.org/show_bug.cgi?id=44653
472
473         Also, output the full path so we can pipe the output to rm.
474
475         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
476         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
477
478 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
479
480         Reviewed by Andreas Kling.
481
482         [Qt] MiniBrowser does not starts properly
483         https://bugs.webkit.org/show_bug.cgi?id=45459
484
485         Do not try set up the first window by calling newWindow on a
486         newly created BrowserWindow since it creates a new object.
487         * MiniBrowser/qt/BrowserWindow.cpp:
488         (BrowserWindow::BrowserWindow):
489         * MiniBrowser/qt/main.cpp:
490         (main):
491
492 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
493
494         Reviewed by Xan Lopez.
495
496         [GTK] Get ImageDiff building on Win32
497         https://bugs.webkit.org/show_bug.cgi?id=45353
498
499         * DumpRenderTree/gtk/ImageDiff.cpp:
500         (main): Switch from using strtok to g_strsplit.
501
502 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
503
504         Reviewed by Andreas Kling.
505
506         [Qt] Modify load method of MiniBrowser's BrowserView class
507         https://bugs.webkit.org/show_bug.cgi?id=45442
508
509         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
510
511         * MiniBrowser/qt/BrowserView.cpp:
512         (BrowserView::load):
513         * MiniBrowser/qt/BrowserView.h:
514         * MiniBrowser/qt/BrowserWindow.cpp:
515         (BrowserWindow::load):
516
517 2010-09-09  Tony Chang  <tony@chromium.org>
518
519         Reviewed by Ojan Vafai.
520
521         fix show_results in new-run-webkit-tests
522         https://bugs.webkit.org/show_bug.cgi?id=45413
523
524         * Scripts/webkitpy/layout_tests/port/chromium.py:
525
526 2010-09-08  Victor Wang  <victorw@chromium.org>
527
528         Reviewed by Ojan Vafai.
529
530         [Chromium] Fix test results server to make sure
531         it does not have corrupted data.
532
533         results.json file size coulbe be >1M and we split
534         the data into multiple data store entries in this
535         case. This patch fixes the issue that the data may
536         be corrupted if data store error happens in the middle
537         of saving multiple entries.
538
539         https://bugs.webkit.org/show_bug.cgi?id=45063
540
541         * TestResultServer/model/datastorefile.py:
542
543 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
544
545         Reviewed by Kenneth Rohde Christiansen.
546
547         Fix ignoring return value warning in case of gcc 4.4.4
548         https://bugs.webkit.org/show_bug.cgi?id=45384
549
550         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
551         (testPostURLFile):
552         If fwrite have written zero byte then the testPostURLFile function
553         returns with false as tempFile can't be opened.
554         * DumpRenderTree/qt/ImageDiff.cpp:
555         (main):
556         Put fwrite function into an if condition without body to avoid
557         warning. It is safe because this function writes to the stdout.
558
559 2010-09-08  Satish Sampath  <satish@chromium.org>
560
561         Unreviewed, adding myself to committers list.
562
563         * Scripts/webkitpy/common/config/committers.py:
564
565 2010-09-08  Hans Wennborg  <hans@chromium.org>
566
567         Unreviewed.
568
569         Adding myself as a committer in committers.py.
570
571         * Scripts/webkitpy/common/config/committers.py:
572
573 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
574
575         Reviewed by Simon Hausmann.
576
577         [Qt] Refactor MiniBrowser 
578         https://bugs.webkit.org/show_bug.cgi?id=45173
579
580         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
581
582         * MiniBrowser/qt/BrowserView.cpp: Added.
583         (createNewPage):
584         (BrowserView::BrowserView):
585         (BrowserView::resizeEvent):
586         (BrowserView::load):
587         (BrowserView::view):
588         * MiniBrowser/qt/BrowserView.h: Added.
589         (BrowserView::~BrowserView):
590         * MiniBrowser/qt/BrowserWindow.cpp:
591         * MiniBrowser/qt/BrowserWindow.h:
592         * MiniBrowser/qt/MiniBrowser.pro:
593
594 2010-09-08  Adam Barth  <abarth@webkit.org>
595
596         Rubber-stamped by Eric Seidel.
597
598         Rename DocLoader to CachedResourceLoader because that's what it does.
599
600         * Scripts/do-webcore-rename:
601
602 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
603
604         Reviewed by Ojan Vafai.
605
606         Enable incremental results.json generation for non-layout tests.
607         https://bugs.webkit.org/show_bug.cgi?id=45315
608
609         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
610
611         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
612
613
614 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
615
616         Unreviewed, build fix
617
618         Missed one test in mac_unittest.py in previous change; for some
619         reason the method is listed twice. I will fix both for now, but will
620         figure this out in a later, not-time-sensitive patch.
621
622         https://bugs.webkit.org/show_bug.cgi?id=45357
623
624         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
625
626 2010-09-07  Kent Tamura  <tkent@chromium.org>
627
628         Reviewed by Tony Chang.
629
630         test-webkitpy: Fix load error of
631         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
632         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
633
634         * Scripts/webkitpy/layout_tests/port/server_process.py:
635           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
636           and we don't use server_process.py on Win32 Python. However
637           unittest.py tries to load everything in a module.
638
639 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
640
641         Reviewed by Kent Tamura.
642
643         Fix regression introduced in previous change to new-run-webkit-tests
644         (bug 45090) to not try to run unittests for the Mac implementation
645         of the Port interface if we aren't running on a Mac.
646
647         Also fix the overrides implementation mock in the chromium unittests
648         to fix the case where there are overrides checked in that cause
649         problems.
650
651         https://bugs.webkit.org/show_bug.cgi?id=45357
652
653         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
654         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
655         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
656
657 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
658
659         Reviewed by Ojan Vafai.
660
661         new-run-webkit-tests: still more unit tests
662
663         Clean up and remove unnecessary code. Biggest notable change is
664         moving the chromium-specific imagediff code from port/base to
665         port/chromium.
666
667         Add more unit tests for run_webkit_tests.py, port/base.py,
668         port/factory.py, port/dryrun.py, and
669         layout_package/dump_render_tree_thread.py
670
671         This covers almost all of the generic and test code paths except for
672         a few error paths involving invalid or port-specific command line
673         arguments, and the code path for uploading results files to the
674         buildbots.
675         
676         https://bugs.webkit.org/show_bug.cgi?id=45090
677
678         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
679         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
680         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
681         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
682         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
683         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
684         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
685         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
686         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
687         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
688         * Scripts/webkitpy/layout_tests/port/base.py:
689         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
690         * Scripts/webkitpy/layout_tests/port/chromium.py:
691         * Scripts/webkitpy/layout_tests/port/dryrun.py:
692         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
693         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
694         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
695         * Scripts/webkitpy/layout_tests/port/server_process.py:
696         * Scripts/webkitpy/layout_tests/port/test.py:
697         * Scripts/webkitpy/layout_tests/port/webkit.py:
698         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
699         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
700
701 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
702
703         Reviewed by Darin Adler.
704
705         Provide a way to trigger a <select multiple> onchange event on changes
706         https://bugs.webkit.org/show_bug.cgi?id=45192
707
708         Adds a selector on ObjCController for testing
709         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
710         its different uses.
711
712         * DumpRenderTree/mac/ObjCController.m:
713         (+[ObjCController isSelectorExcludedFromWebScript:]):
714         (+[ObjCController webScriptNameForSelector:]):
715         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
716
717 2010-09-07  James Robinson  <jamesr@chromium.org>
718
719         Rubber-stamped by Dimitri Glazkov.
720
721         Move myself from the committer to the reviewer list.
722
723         * Scripts/webkitpy/common/config/committers.py:
724
725 2010-09-07  Tony Chang  <tony@chromium.org>
726
727         Reviewed by Darin Fisher.
728
729         [chromium] Make a public flag for how DRT generates bitmaps on Linux
730         https://bugs.webkit.org/show_bug.cgi?id=45133
731
732         * DumpRenderTree/chromium/TestShell.cpp:
733         (TestShell::dumpImage):
734
735 2010-09-07  Kent Tamura  <tkent@chromium.org>
736
737         Reviewed by Dimitri Glazkov.
738
739         [DRT/Chromium] Implement --check-layout-test-sys-deps
740         https://bugs.webkit.org/show_bug.cgi?id=45283
741
742         * DumpRenderTree/chromium/DumpRenderTree.cpp:
743         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
744         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
745         * DumpRenderTree/chromium/TestShellGtk.cpp:
746         (checkLayoutTestSystemDependencies): Add an empty implementation.
747         * DumpRenderTree/chromium/TestShellMac.mm:
748         (checkLayoutTestSystemDependencies): Add an empty implementation.
749         * DumpRenderTree/chromium/TestShellWin.cpp:
750         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
751
752 2010-09-07  Jessie Berlin  <jberlin@apple.com>
753
754         Unreviewed. Mac build fix.
755
756         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
757         (didClearWindowObjectForFrame):
758
759 2010-09-07  Jessie Berlin  <jberlin@apple.com>
760
761         Reviewed by Darin Adler.
762
763         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
764         https://bugs.webkit.org/show_bug.cgi?id=45217
765         
766         Make WebKitTestRunner work with this change.
767
768         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
769         (WTR::InjectedBundlePage::didClearWindowForFrame):
770         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
771         WebFrameLoaderClient.
772         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
773
774 2010-09-07  Philippe Normand  <pnormand@igalia.com>
775
776         Unreviewed, build fix.
777
778         webkit-patch command to find the ports covering a specific layout test
779         https://bugs.webkit.org/show_bug.cgi?id=42832
780
781         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
782         tests are present when building the expectations. This is needed
783         for the unittests.
784
785 2010-09-06  Philippe Normand  <pnormand@igalia.com>
786
787         Reviewed by Adam Barth.
788
789         webkit-patch command to find the ports covering a specific layout test
790         https://bugs.webkit.org/show_bug.cgi?id=42832
791
792         To use it: webkit-patch skipped-ports some/layout/test.html
793
794         * Scripts/webkitpy/layout_tests/port/base.py:
795         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
796         * Scripts/webkitpy/layout_tests/port/chromium.py:
797         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
798         * Scripts/webkitpy/layout_tests/port/factory.py:
799         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
800         * Scripts/webkitpy/layout_tests/port/test.py:
801         * Scripts/webkitpy/layout_tests/port/webkit.py:
802         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
803         * Scripts/webkitpy/tool/commands/queries.py:
804         * Scripts/webkitpy/tool/commands/queries_unittest.py:
805         * Scripts/webkitpy/tool/main.py:
806         * Scripts/webkitpy/tool/mocktool.py:
807
808 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
809
810         Reviewed by Eric Seidel.
811
812         [NRWT] Add temp directory to all running drivers.
813         https://bugs.webkit.org/show_bug.cgi?id=45261
814
815         * Scripts/webkitpy/layout_tests/port/webkit.py:
816
817 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
818
819         Reviewed by Kent Tamura.
820
821         [Chromium/DRT] Empty out user stylesheet after each test run.
822         https://bugs.webkit.org/show_bug.cgi?id=45282
823
824         This should significantly cut down on the number of the mysterious flaky tests
825         whose diffs looked like the page was blown up to a very lage size. This
826         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
827         which set the base body font to 100px.
828
829         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
830         the same thread failed.
831
832         * DumpRenderTree/chromium/TestShell.cpp:
833         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
834
835 2010-09-06  Kent Tamura  <tkent@chromium.org>
836
837         Reviewed by Dimitri Glazkov.
838
839         [DRT/Chromium] Do not generate pixel results for text/plain resources
840         https://bugs.webkit.org/show_bug.cgi?id=45253
841
842         * DumpRenderTree/chromium/TestShell.cpp:
843         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
844
845 2010-09-06  Ojan Vafai  <ojan@chromium.org>
846
847         Reviewed by Kent Tamura.
848
849         print out correct error when a DRT thread dies in NRWT
850         https://bugs.webkit.org/show_bug.cgi?id=45281
851
852         Not sure why, but with the parens, python 2.6.5 on Linux
853         gives an error that raise takes 5 arguments and 0 were given.
854         Didn't test other platforms or python versions, but putting it
855         all on one line fixes it and correctly prints the exception
856         from the DRT thread.
857
858         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
859
860 2010-09-06  Eric Seidel  <eric@webkit.org>
861
862         Unreviewed, just adding some emails from lists.webkit.org.
863
864         Update committers.py to include emails from lists.webkit.org
865         as found by the validate-committer-lists script.
866
867         * Scripts/webkitpy/common/config/committers.py:
868
869 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
870
871         Reviewed by Xan Lopez.
872
873         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
874         https://bugs.webkit.org/show_bug.cgi?id=45213
875
876         * DumpRenderTree/gtk/DumpRenderTree.cpp:
877         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
878         have to surround the invocation with #ifdefs.
879         (useLongRunningServerMode): Added.
880         (runTestingServerLoop): Added.
881         (initializeGlobalsFromCommandLineOptions): Added.
882         (runTest): Removed ifdefs.
883         (main): Use new helper functions.
884
885 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
886
887         Reviewed by Xan Lopez.
888
889         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
890         https://bugs.webkit.org/show_bug.cgi?id=45235
891
892         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
893         methods of the EventSender.
894
895         * DumpRenderTree/gtk/EventSender.cpp:
896         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
897         with the current modifiers.
898         (contextClickCallback): Always send no modifiers when preparing the mouse event.
899         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
900         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
901         (mouseUpCallback): Ditto.
902
903 2010-09-05  Peter Kasting  <pkasting@google.com>
904
905         Reviewed by Adam Barth.
906
907         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
908         https://bugs.webkit.org/show_bug.cgi?id=45155
909
910         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
911         (EventSender::handleMouseWheel):
912
913 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
914
915         Reviewed by Joseph Pecoraro.
916
917         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
918         https://bugs.webkit.org/show_bug.cgi?id=45179
919
920         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
921         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
922
923 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
924
925         Rubber-stamped by Daniel Bates.
926
927         Adding myself as reviewer.
928
929         * Scripts/webkitpy/common/config/committers.py:
930
931 2010-09-04  Daniel Bates  <dbates@rim.com>
932
933         Reviewed by Martin Robinson.
934
935         Teach svn-apply/unapply about svn:mergeinfo
936         https://bugs.webkit.org/show_bug.cgi?id=45236
937
938         Recognize the svn:mergeinfo property and ignore it for now.
939
940         Currently, svn-apply/unapply recognize only '+' and '-'
941         property changes within a diff. We should add support
942         to recognize "Merged" and "Reverse-merged" changes as well.
943         Because svn:mergeinfo is metadata that is used only by SVN
944         and tends to be error-prone and/or nuisance (*), we will ignore
945         it for now.
946         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
947
948         * Scripts/VCSUtils.pm:
949           - Modified parseSvnProperty() to recognize "Merged" and
950             "Reverse-merged" as the start of a property value.
951         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
952           - Added the following unit tests:
953             "simple: add svn:mergeinfo"
954             "simple: delete svn:mergeinfo"
955             "simple: modified svn:mergeinfo"
956         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
957           - Added the following unit tests:
958             "simple: add svn:mergeinfo"
959             "simple: delete svn:mergeinfo"
960             "simple: modified svn:mergeinfo"
961             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
962             "'Merged' change followed by 'Merged' change"
963             "'Reverse-merged' change followed by 'Reverse-merged' change"
964         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
965           - Added the following unit tests:
966             "'Merged' change"
967             "'Reverse-merged' change"
968             "'Reverse-merged' change followed by 'Merge' change"
969             "'Merged' change followed by 'Merge' change"
970             "'Reverse-merged' change followed by 'Reverse-merged' change"
971             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
972
973 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
974
975         Reviewed by Kenneth Rohde Christiansen.
976
977         [EFL] Move test browser to WebKitTools directory
978         https://bugs.webkit.org/show_bug.cgi?id=45212
979
980         Follow other ports like QT and GTK which moved the test browser to
981         WebKitTools directory.
982
983         * CMakeListsEfl.txt: Added.
984         * EWebLauncher/main.c: Added.
985         (print_history):
986         (zoom_level_set):
987         (on_ecore_evas_resize):
988         (title_set):
989         (viewport_set):
990         (on_title_changed):
991         (on_progress):
992         (on_load_finished):
993         (on_toolbars_visible_set):
994         (on_toolbars_visible_get):
995         (on_statusbar_visible_set):
996         (on_statusbar_visible_get):
997         (on_scrollbars_visible_set):
998         (on_scrollbars_visible_get):
999         (on_menubar_visible_set):
1000         (on_menubar_visible_get):
1001         (on_tooltip_text_set):
1002         (on_inputmethod_changed):
1003         (on_viewport_changed):
1004         (on_mouse_down):
1005         (on_focus_out):
1006         (on_focus_in):
1007         (on_resized):
1008         (on_key_down):
1009         (on_browser_del):
1010         (on_closeWindow):
1011         (quit):
1012         (browserCreate):
1013         (browserDestroy):
1014         (closeWindow):
1015         (main_signal_exit):
1016         (findThemePath):
1017         (main):
1018
1019 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
1020
1021         Reviewed by Adam Roben.
1022
1023         Set project dependencies so that they build serially. This fixes
1024         issues when running run-webkit-tests if DRT is not built yet.
1025
1026         * DumpRenderTree/DumpRenderTree.sln:
1027
1028 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
1029
1030         Reviewed by Adam Barth.
1031
1032         Fix reading configuraiton in NWRT to work on Windows.
1033         https://bugs.webkit.org/show_bug.cgi?id=45180
1034
1035         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
1036             with the file otherwise.
1037
1038 2010-09-03  Chris Rogers  <crogers@google.com>
1039
1040         Unreviewed
1041
1042         Add myself to the committers list
1043         https://bugs.webkit.org/show_bug.cgi?id=45189
1044
1045         * Scripts/webkitpy/common/config/committers.py:
1046
1047 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
1048
1049         Reviewed by Yury Semikhatsky.
1050
1051         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
1052         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
1053         https://bugs.webkit.org/show_bug.cgi?id=45137
1054
1055         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
1056
1057 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1058
1059         Reviewed by Eric Seidel.
1060
1061         Add feature detection support to NRWT.
1062         https://bugs.webkit.org/show_bug.cgi?id=41842
1063
1064         * Scripts/webkitpy/layout_tests/port/base.py:
1065         * Scripts/webkitpy/layout_tests/port/qt.py:
1066         * Scripts/webkitpy/layout_tests/port/webkit.py:
1067         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
1068
1069 2010-09-03  Hironori Bono  <hbono@chromium.org>
1070
1071         Reviewed by Kent Tamura.
1072
1073         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
1074         and implements it for Mac.
1075         https://bugs.webkit.org/show_bug.cgi?id=41832
1076
1077         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
1078         and bind it so we can call it from JavaScript.
1079         (+[TextInputController isSelectorExcludedFromWebScript:]):
1080         (+[TextInputController webScriptNameForSelector:]):
1081         (-[TextInputController hasSpellingMarker:length:]):
1082
1083 2010-09-02  Eric Seidel  <eric@webkit.org>
1084
1085         Reviewed by Adam Barth.
1086
1087         Add a unit test for commit-queue retries
1088         https://bugs.webkit.org/show_bug.cgi?id=45162
1089
1090         I think commit-queue retries are not correctly avoiding
1091         build and test on retries.  So I started testing the code.
1092         Unfortunately this test did not find the bug.  But now
1093         that we have the test we might as well keep it.
1094         I also fixed a broken import in validate-committer-lists.
1095
1096         * Scripts/validate-committer-lists:
1097         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1098
1099 2010-09-02  Kent Tamura  <tkent@chromium.org>
1100
1101         Reviewed by Dimitri Glazkov.
1102
1103         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
1104         https://bugs.webkit.org/show_bug.cgi?id=45091
1105
1106         Task.{cpp,h} introduces a simpler version of Chromium
1107         base/task.h. It doesn't have TupleN and Method.
1108
1109         * DumpRenderTree/DumpRenderTree.gypi:
1110          Add Task.cpp and Task.h
1111         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1112         (DRTDevToolsAgent::DRTDevToolsAgent):
1113         (DRTDevToolsAgent::reset):
1114         (DRTDevToolsAgent::asyncCall):
1115         (DRTDevToolsAgent::frontendLoaded):
1116         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1117         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
1118         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1119         (DRTDevToolsClient::DRTDevToolsClient):
1120         (DRTDevToolsClient::~DRTDevToolsClient):
1121         (DRTDevToolsClient::reset):
1122         (DRTDevToolsClient::asyncCall):
1123         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1124         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
1125         * DumpRenderTree/chromium/EventSender.cpp:
1126         (EventSender::EventSender):
1127         (EventSender::reset):
1128         (EventSender::scheduleAsynchronousClick):
1129         * DumpRenderTree/chromium/EventSender.h:
1130         (EventSender::taskList): Added to use MethodTask<T>.
1131         * DumpRenderTree/chromium/LayoutTestController.cpp:
1132         (LayoutTestController::LayoutTestController):
1133         (LayoutTestController::WorkQueue::processWorkSoon):
1134         (LayoutTestController::waitUntilDone):
1135         (LayoutTestController::notifyDone):
1136         (LayoutTestController::reset):
1137         * DumpRenderTree/chromium/LayoutTestController.h:
1138         (LayoutTestController::taskList): Added to use MethodTask<T>.
1139         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
1140         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1141         (deferredDisplayDispatch):
1142         (NotificationPresenter::show):
1143         * DumpRenderTree/chromium/Task.cpp: Added.
1144         * DumpRenderTree/chromium/Task.h: Added.
1145
1146 2010-09-02  Steve Block  <steveblock@google.com>
1147
1148         Reviewed by Adam Barth.
1149
1150         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
1151         https://bugs.webkit.org/show_bug.cgi?id=43181
1152
1153         * DumpRenderTree/mac/DumpRenderTree.mm:
1154         (createWebViewAndOffscreenWindow):
1155         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1156         (LayoutTestController::setMockDeviceOrientation):
1157
1158 2010-08-31  Adam Roben  <aroben@apple.com>
1159
1160         Fix flashiness when resizing the browser window on Windows
1161
1162         Reviewed by Sam Weinig.
1163
1164         * MiniBrowser/win/BrowserWindow.cpp:
1165         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
1166         periodically fill the window with white.
1167
1168 2010-09-02  Peter Kasting  <pkasting@google.com>
1169
1170         Reviewed by Dimitri Glazkov.
1171
1172         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
1173         https://bugs.webkit.org/show_bug.cgi?id=45073
1174
1175         * DumpRenderTree/chromium/EventSender.cpp:
1176         (EventSender::EventSender):
1177         (EventSender::mouseScrollBy):
1178         (EventSender::continuousMouseScrollBy):
1179         (EventSender::sendCurrentTouchEvent):
1180         (EventSender::handleMouseWheel):
1181         * DumpRenderTree/chromium/EventSender.h:
1182         * DumpRenderTree/gtk/EventSender.cpp:
1183         (mouseScrollByCallback):
1184         (continuousMouseScrollByCallback):
1185
1186 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1187
1188         Reviewed by Tony Chang.
1189
1190         Land a patched version of r66542 - change TestRunner to have an
1191         separate cleanup method and fix the ordering of cleanup between
1192         TestRunner and the printing module, and then wrap everything in a
1193         try/finally block to ensure reliable cleanup without needing to
1194         rely on stuff happening in the destructor of the TestRunner.
1195
1196         Also refactor run_webkit_tests.run() to be much smaller and cleaner
1197         by creating a bunch of helper methods and moving more stuff into
1198         the TestRunner class.
1199
1200         This fixes the crash at the end of the linux test run of
1201         new-run-webkit-tests (and undoes the rollout in 66547).
1202
1203         https://bugs.webkit.org/show_bug.cgi?id=44902
1204
1205         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1206         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1207         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1208         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1209         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1210         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1211         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1212         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1213         * Scripts/webkitpy/layout_tests/port/base.py:
1214         * Scripts/webkitpy/layout_tests/port/test.py:
1215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1216         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1217
1218 2010-09-01  Mark Rowe  <mrowe@apple.com>
1219
1220         Reviewed by Adam Roben.
1221
1222         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
1223
1224         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1225
1226 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
1227
1228         Reviewed by Adam Roben.
1229
1230         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
1231         and WebKitTestRunner.
1232
1233         * BuildSlaveSupport/win/kill-old-processes:
1234
1235 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1236
1237         Reviewed by Antonio Gomes.
1238
1239         [Qt] Remove obsolete include path from DumpRenderTree.pro
1240
1241         * DumpRenderTree/qt/DumpRenderTree.pro:
1242
1243 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1244
1245         Reviewed by Laszlo Gombos.
1246
1247         [Qt] QWebPage::allowGeolocationRequest should be async API
1248         https://bugs.webkit.org/show_bug.cgi?id=41364
1249
1250         Implements new async API for geolocation permission similar to
1251         Notification. WebPage maintains list of geolocation permission request
1252         QtWebkit and set's when LayoutTestController gets the access from test JS
1253
1254         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1255         (WebCore::WebPage::WebPage):
1256         (WebCore::WebPage::resetSettings):
1257         (WebCore::WebPage::requestPermission):
1258         (WebCore::WebPage::cancelPermission):
1259         (WebCore::WebPage::permissionSet):
1260         (WebCore::DumpRenderTree::DumpRenderTree):
1261         (WebCore::DumpRenderTree::processLine):
1262         (WebCore::DumpRenderTree::geolocationPermissionSet):
1263         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1264         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1265         (LayoutTestController::reset):
1266         (LayoutTestController::setGeolocationPermission):
1267         (LayoutTestController::setGeolocationPermissionCommon):
1268         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1269
1270 2010-09-01  Andras Becsi  <abecsi@webkit.org>
1271
1272         Reviewed by Antti Koivisto.
1273
1274         [Qt] Auto-generate WebKit2 forwarding headers
1275         https://bugs.webkit.org/show_bug.cgi?id=44692
1276
1277         * MiniBrowser/qt/BrowserWindow.h: use source style includes
1278         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
1279         * Scripts/enumerate-included-framework-headers: Removed.
1280
1281 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1282
1283         Reviewed by Adam Barth.
1284
1285         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
1286         https://bugs.webkit.org/show_bug.cgi?id=44789
1287
1288         * Scripts/webkitpy/common/net/bugzilla.py:
1289
1290 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
1291
1292         Reviewed by Adam Barth.
1293
1294         ews: Add support for EFL-EWS
1295         https://bugs.webkit.org/show_bug.cgi?id=44982
1296
1297         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
1298         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
1299         and add it to the ports dict.
1300         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
1301         EflEWS class.
1302         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
1303         a test case for the EFL EWS.
1304
1305 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
1306
1307         Reviewed by Sam Weinig.
1308
1309         https://bugs.webkit.org/show_bug.cgi?id=42195
1310         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
1311
1312         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1313         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
1314         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1315         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
1316         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
1317
1318         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1319         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
1320         which forgets its override.
1321
1322 2010-08-31  Sam Weinig  <sam@webkit.org>
1323
1324         Reviewed by Gavin Barraclough.
1325
1326         WebKitTestRunner needs layoutTestController.addUserStyleSheet
1327         https://bugs.webkit.org/show_bug.cgi?id=42680
1328
1329         WebKitTestRunner needs layoutTestController.addUserScript
1330         https://bugs.webkit.org/show_bug.cgi?id=42681
1331
1332         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1333         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1334         (WTR::InjectedBundle::beginTesting):
1335         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1336         (WTR::LayoutTestController::addUserScript):
1337         (WTR::LayoutTestController::addUserStyleSheet):
1338         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1339
1340 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1341
1342         Unreviewed, rolling out r66542.
1343         http://trac.webkit.org/changeset/66542
1344         https://bugs.webkit.org/show_bug.cgi?id=44902
1345
1346         r66542 - the weird logging dependencies in Python stuck again ...
1347
1348         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
1349         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
1350         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
1351         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
1352         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1353         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1354         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1355         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1356         * Scripts/webkitpy/layout_tests/port/base.py:
1357         * Scripts/webkitpy/layout_tests/port/test.py:
1358         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1359         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1360
1361 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
1362
1363         Reviewed by Tony Chang.
1364
1365         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
1366
1367         * DumpRenderTree/chromium/LayoutTestController.cpp:
1368         (LayoutTestController::LayoutTestController):
1369         (LayoutTestController::markerTextForListItem):
1370         * DumpRenderTree/chromium/LayoutTestController.h:
1371
1372 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1373
1374         Reviewed by Ojan Vafai.
1375
1376         new-run-webkit-tests: add more unit tests
1377
1378         Add more unit tests for new-run-webkit-tests; we now cover all but
1379         the most obscure code paths in the generic code. We still need to
1380         add coverage for the http server and web socket paths, and add better
1381         coverage of the platform-specific logic. Note that the rebaselining
1382         tool is still not well tested.
1383
1384         Also clean up some of the configuration logic for the printing
1385         module and the way it interacts with the Python logging module; that
1386         is a crufty interface, to be certain.
1387         
1388         https://bugs.webkit.org/show_bug.cgi?id=44902
1389
1390         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1391         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1392         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1393         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1394         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1395         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1396         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1397         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1398         * Scripts/webkitpy/layout_tests/port/base.py:
1399         * Scripts/webkitpy/layout_tests/port/test.py:
1400         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1401         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1402
1403 2010-08-31  Darin Adler  <darin@apple.com>
1404
1405         Reviewed by Anders Carlsson.
1406
1407         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
1408         in a debug build when built with certain compilers.
1409
1410 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
1411
1412         Reviewed by Gustavo Noronha Silva.
1413
1414         [GTK] Isolate all GTK+ typedefs into one file
1415         https://bugs.webkit.org/show_bug.cgi?id=44900
1416
1417         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
1418
1419 2010-08-31  Eric Seidel  <eric@webkit.org>
1420
1421         Reviewed by Adam Barth.
1422
1423         Show more status on queue status pages
1424         https://bugs.webkit.org/show_bug.cgi?id=44938
1425
1426         I upped the number of status lines from 6 to 15 --
1427         this has been bugging me for a while...
1428
1429         I also disabled showing the chromium-win EWS queue
1430         since it's been down for almost 5 months now.
1431
1432         * QueueStatusServer/handlers/dashboard.py:
1433         * QueueStatusServer/handlers/queuestatus.py:
1434         * QueueStatusServer/model/queues.py:
1435
1436 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
1437
1438         Reviewed by Antonio Gomes.
1439
1440         [Qt] Read command line arguments and open them as URLs in new windows
1441         https://bugs.webkit.org/show_bug.cgi?id=44944
1442
1443         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
1444
1445         * MiniBrowser/qt/main.cpp:
1446         (main):
1447
1448 2010-08-31  Adrian Perez  <aperez@igalia.com>
1449
1450         Reviewed by Martin Robinson.
1451
1452         Support scripts to run Buildbot slaves under daemontools (gtk related)
1453         https://bugs.webkit.org/show_bug.cgi?id=40053
1454
1455         * BuildSlaveSupport/gtk: Added.
1456         * BuildSlaveSupport/gtk/README: Added.
1457         * BuildSlaveSupport/gtk/buildbot: Added.
1458         * BuildSlaveSupport/gtk/buildbot/log: Added.
1459         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
1460         * BuildSlaveSupport/gtk/buildbot/run: Added.
1461         * BuildSlaveSupport/gtk/crashmon: Added.
1462         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
1463         * BuildSlaveSupport/gtk/crashmon/log: Added.
1464         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
1465         * BuildSlaveSupport/gtk/crashmon/run: Added.
1466         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
1467         * BuildSlaveSupport/gtk/pulseaudio: Added.
1468         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
1469         * BuildSlaveSupport/gtk/xvfb: Added.
1470         * BuildSlaveSupport/gtk/xvfb/log: Added.
1471         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
1472         * BuildSlaveSupport/gtk/xvfb/run: Added.
1473
1474 2010-08-27  John Gregg  <johnnyg@google.com>
1475
1476         Reviewed by David Levin.
1477
1478         Notifications should support a click event.
1479         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
1480         can be simulated during a layout test.  Requires storing a list of active
1481         notifications so that they can be referred to later for clicking.
1482         https://bugs.webkit.org/show_bug.cgi?id=44800
1483
1484         * DumpRenderTree/chromium/LayoutTestController.cpp:
1485         (LayoutTestController::LayoutTestController):
1486         (LayoutTestController::simulateDesktopNotificationClick):
1487         * DumpRenderTree/chromium/LayoutTestController.h:
1488         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1489         (NotificationPresenter::simulateClick):
1490         (NotificationPresenter::show):
1491         (NotificationPresenter::cancel):
1492         (NotificationPresenter::objectDestroyed):
1493         * DumpRenderTree/chromium/NotificationPresenter.h:
1494
1495 2010-08-30  Alice Liu  <alice.liu@apple.com>
1496
1497         Reviewed by Darin Adler.
1498
1499         Add missing parts of didFinishDocumentLoadForFrame
1500         https://bugs.webkit.org/show_bug.cgi?id=44913
1501
1502         * MiniBrowser/mac/BrowserWindowController.m:
1503         (didFinishDocumentLoadForFrame): Added
1504         (-[BrowserWindowController awakeFromNib]): Updated struct
1505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1506         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
1507         * WebKitTestRunner/TestController.cpp:
1508         (WTR::TestController::initialize): Updated struct
1509
1510 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
1511
1512         Unreviewed: Add myself to the list of Committers.
1513
1514         * Scripts/webkitpy/common/config/committers.py:
1515
1516 2010-08-30  Kent Tamura  <tkent@chromium.org>
1517
1518         Reviewed by Adam Barth.
1519
1520         Fix fast/notifications/notifications-display-close-events.html failure
1521         https://bugs.webkit.org/show_bug.cgi?id=44585
1522
1523         Apply http://crrev.com/48893. We should dispatch display events
1524         asynchronously.
1525
1526         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1527         (deferredDisplayDispatch):
1528         (NotificationPresenter::show):
1529
1530 2010-08-30  Robert Hogan  <robert@webkit.org>
1531
1532         Reviewed by Simon Hausmann.
1533
1534         allow ports with windowed plugins to support windowless plugin tests
1535
1536         https://bugs.webkit.org/show_bug.cgi?id=40730
1537
1538         Ports that implement plugins windowed by default need to have a way of
1539         supporting plugin tests that assume the plugin is windowless. Add this
1540         feature to the tests and support it in the webkit test plugin. Also
1541         add mouse and keyboard event logging to the webkit-test plugin on Unix.
1542
1543         Unskip the following tests on Qt:
1544
1545         plugins/mouse-events.html
1546         plugins/keyboard-events.html
1547         plugins/mouse-events-fixedpos.html
1548
1549         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1550         (pluginSetProperty):
1551         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1552         (NPP_New):
1553         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1554         (webkit_test_plugin_handle_event):
1555
1556 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
1557
1558         [wx] Build fix after addition of fileapi directory in WebCore.
1559
1560         * wx/build/settings.py:
1561
1562 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1563
1564         Reviewed by Xan Lopez.
1565
1566         Fixed compilation error, now that we have included the
1567         GtkVersioning.h we have to remove some version dependent code from
1568         EventSender.
1569
1570         * DumpRenderTree/gtk/EventSender.cpp:
1571
1572 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1573
1574         Reviewed by Martin Robinson.
1575
1576         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
1577         are deprecated
1578         https://bugs.webkit.org/show_bug.cgi?id=44787
1579
1580         We have replaced GtkVersioning.cpp with GtkVersioning.c and
1581         created a function (getDefaultGDKPointerDevice) to get the pointer
1582         of the window with the new APIs. We added that function to DRT and
1583         copyandpaste unit test.
1584
1585         * DumpRenderTree/gtk/EventSender.cpp:
1586         (prepareMouseButtonEvent):
1587         (mouseMoveToCallback):
1588         (keyDownCallback):
1589         * GNUmakefile.am:
1590
1591 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
1592
1593         Reviewed by Kenneth Rohde Christiansen.
1594
1595         [Qt] Add new window menu to MiniBrowser
1596
1597         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
1598
1599         * MiniBrowser/qt/BrowserWindow.cpp:
1600         (BrowserWindow::BrowserWindow):
1601         (BrowserWindow::newWindow):
1602         * MiniBrowser/qt/BrowserWindow.h:
1603         * MiniBrowser/qt/main.cpp:
1604         (main):
1605
1606 2010-08-29  James Robinson  <jamesr@chromium.org>
1607
1608         Reviewed by David Levin.
1609
1610         Make failing the download step fail the build
1611         https://bugs.webkit.org/show_bug.cgi?id=44298
1612
1613         If the download step fails on a test bot, this ensures that
1614         the build goes red instead of only the download step going red
1615         and the overall build staying green.
1616
1617         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1618
1619 2010-08-29  Kent Tamura  <tkent@chromium.org>
1620
1621         Reviewed by Dimitri Glazkov.
1622
1623         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
1624         https://bugs.webkit.org/show_bug.cgi?id=44847
1625
1626         * DumpRenderTree/chromium/EventSender.cpp:
1627          Use webkit_support::VKEY_* instead of base::VKEY_*.
1628
1629 2010-08-29  Darin Adler  <darin@apple.com>
1630
1631         https://bugs.webkit.org/show_bug.cgi?id=40589
1632
1633         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
1634         function names.
1635
1636 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1637
1638         Reviewed by Darin Adler.
1639
1640         [iExploder] Add new CSS Properties and HTML Attributes
1641         https://bugs.webkit.org/show_bug.cgi?id=44746
1642
1643         Updated the files with the update-iexploder-cssproperties script
1644         and manually readded the -webkit-binding CSS Property to the list.
1645
1646         * iExploder/htdocs/cssproperties.in:
1647         * iExploder/htdocs/htmlattrs.in:
1648         * iExploder/htdocs/htmltags.in:
1649
1650 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1651
1652         Reviewed by Darin Adler.
1653
1654         Fix Coverage build after the addition of ANGLE
1655         https://bugs.webkit.org/show_bug.cgi?id=44744
1656
1657         ANGLE is using libtool to build a static library and the version of
1658         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
1659         parameters. The easiest way to handle this is to not build ANGLE with
1660         coverage information.
1661
1662         This is achieved by applying the XCode options for each project
1663         separately and exclude ANGLE.
1664
1665         * Scripts/build-webkit: Remove -framework AppKit due link errors.
1666         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
1667
1668 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
1669
1670         [wx] Build fix after directory addition.
1671
1672         * wx/build/settings.py:
1673
1674 2010-08-28  Chris Guillory   <chris.guillory@google.com>
1675
1676         Reviewed by Chris Fleizach.
1677
1678         Add AX notification for childrenChanged
1679         https://bugs.webkit.org/show_bug.cgi?id=44472
1680
1681         * DumpRenderTree/chromium/AccessibilityController.cpp:
1682         (AccessibilityController::AccessibilityController):
1683         (AccessibilityController::reset):
1684         (AccessibilityController::getRootElement):
1685         (AccessibilityController::dumpAccessibilityNotifications):
1686         * DumpRenderTree/chromium/AccessibilityController.h:
1687         (AccessibilityController::shouldDumpAccessibilityNotifications):
1688         * DumpRenderTree/chromium/WebViewHost.cpp:
1689         (WebViewHost::didChangeAccessibilityObjectChildren):
1690         * DumpRenderTree/chromium/WebViewHost.h:
1691
1692 2010-08-28  Eric Seidel  <eric@webkit.org>
1693
1694         Reviewed by Adam Barth.
1695
1696         Update commit-queue failure message
1697         https://bugs.webkit.org/show_bug.cgi?id=44798
1698
1699         The commit-queue auto-restarts itself and has for a very long time.
1700         No need for people to email me to request a restart anymore.
1701
1702         * Scripts/webkitpy/common/net/bugzilla.py:
1703         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1704         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1705
1706 2010-07-27  Jer Noble  <jer.noble@apple.com>
1707
1708         Reviewed by Eric Carlson.
1709
1710         Add JavaScript API to allow a page to go fullscreen.
1711         rdar://problem/6867795
1712         
1713         Added basic full screen support to DumpRenderTree: when a webView requests
1714         that DumpRenderTree go "full screen", just call the provided callback listener object's
1715         will/did Enter/Exit full screen methods.  Also, register a new user default which 
1716         enables full screen support.
1717
1718         * DumpRenderTree/mac/DumpRenderTree.mm:
1719         (resetDefaultsToConsistentValues):
1720         * DumpRenderTree/mac/UIDelegate.mm:
1721         (-[UIDelegate webView:supportsFullscreenForElement:]):
1722         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
1723         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
1724
1725 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1726
1727         Unreviewed. Add myself to the committers list.
1728
1729         * Scripts/webkitpy/common/config/committers.py:
1730
1731 2010-08-27  Kent Tamura  <tkent@chromium.org>
1732
1733         Reviewed by Pavel Feldman.
1734
1735         [DRT/Chromium] Fix inspector test failures
1736         https://bugs.webkit.org/show_bug.cgi?id=44748
1737
1738         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1739         (DRTDevToolsAgent::createClientMessageLoop):
1740           Returns a valid WebKitClientMessageLoop instance
1741         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1742
1743 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
1744
1745         Add Windows WebKit2 Tester to buildbot
1746         <rdar://problem/7887703>
1747
1748         Reviewed by Dan Bernstein.
1749
1750         * BuildSlaveSupport/build.webkit.org-config/config.json:
1751
1752 2010-08-26  Philippe Normand  <pnormand@igalia.com>
1753
1754         Reviewed by Martin Robinson.
1755
1756         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1757         https://bugs.webkit.org/show_bug.cgi?id=42152
1758
1759         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1760         (LoadHTMLStringItem::invoke): Implementation using
1761         webkit_web_frame_load_string().
1762
1763 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
1764
1765         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
1766         WebKitTestRunner (44331)
1767
1768         Reviewed by Darin Adler.
1769
1770         * WebKitTestRunner/TestController.cpp:
1771         (WTR::TestController::initialize):
1772         The hang occurs when WebKitTestRunner begins launching the WebKit2
1773         web process then exits before it finishes launching. Work around this by
1774         looking for the --print-supported-features argument and exiting without
1775         creating the web process.
1776
1777 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
1778
1779         Reviewed by Tony Chang.
1780
1781         new-run-webkit-tests: add rebaselining tests for test_expectations
1782         
1783         This patch adds more unit tests for the rebaselining code in the
1784         test_expectations module. It doesn't add any tests for
1785         rebaseline_chromium_webkit_tests itself; that will come some other
1786         time.
1787
1788         https://bugs.webkit.org/show_bug.cgi?id=44648
1789
1790         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1791         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1792
1793 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1794
1795         Reviewed by Martin Robinson.
1796
1797         [GTK] Add HTTP caching support
1798         https://bugs.webkit.org/show_bug.cgi?id=44261
1799
1800         Ignore new soup API that we decided to merge into the soup backend
1801         while it is being cooked. It follows the libsoup style, and will
1802         be removed from WebKit as soon as it is merged into libsoup.
1803
1804         * Scripts/webkitpy/style/checker.py:
1805
1806 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1807
1808         Reviewed by Kenneth Rohde Christiansen.
1809
1810         [Qt] DumpRenderTree runs only one test from command mode
1811         https://bugs.webkit.org/show_bug.cgi?id=44012
1812
1813         Enables support to run multiple test files and single
1814         folder containing html files in stand alone mode
1815
1816         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1817         (WebCore::DumpRenderTree::DumpRenderTree):
1818         (WebCore::DumpRenderTree::processArgsLine):
1819         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1820         (WebCore::DumpRenderTree::processLine):
1821         (WebCore::DumpRenderTree::dump):
1822         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1823         (WebCore::DumpRenderTree::setStandAloneMode):
1824         (WebCore::DumpRenderTree::isStandAloneMode):
1825         * DumpRenderTree/qt/main.cpp:
1826         (main):
1827
1828 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1829
1830         Updating webkitpy test expectations.
1831
1832         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1833
1834 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1835
1836         Reviewed by Eric Seidel.
1837
1838         fix the always squash git config
1839         https://bugs.webkit.org/show_bug.cgi?id=44651
1840
1841         Fix help text and apparently underscores are not allowed
1842         in git config keys.
1843
1844         * Scripts/webkitpy/common/checkout/scm.py:
1845         * Scripts/webkitpy/tool/steps/commit.py:
1846
1847 2010-08-25  Darin Adler  <darin@apple.com>
1848
1849         Reviewed by John Sullivan.
1850
1851         * Scripts/commit-log-editor: Fix perl warning for people who have no
1852         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
1853
1854 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1855
1856         Reviewed by Eric Seidel.
1857
1858         stop blocking commits when the bots are red
1859         https://bugs.webkit.org/show_bug.cgi?id=44644
1860
1861         This check currently is just annoying. It doesn't actually
1862         help keep the tree green. We can always add it back later
1863         if we decide the tree is generally more green.
1864
1865         * Scripts/webkitpy/tool/commands/download_unittest.py:
1866         * Scripts/webkitpy/tool/mocktool.py:
1867         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1868
1869 2010-08-25  Eric Seidel  <eric@webkit.org>
1870
1871         Reviewed by Simon Fraser.
1872
1873         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
1874         https://bugs.webkit.org/show_bug.cgi?id=38912
1875
1876         I know of nothing else to do but skip all media tests for the cq.
1877
1878         * Scripts/webkitpy/tool/steps/runtests.py:
1879
1880 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1881
1882         Reviewed by Ojan Vafai.
1883
1884         new-run-webkit-tests: add more unit tests for test_expectations
1885         This adds unit tests to cover (almost?) all of the non-rebaselining
1886         functionality.
1887
1888         https://bugs.webkit.org/show_bug.cgi?id=44579
1889
1890         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1891         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1892
1893 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1894
1895         Reviewed by Ojan Vafai.
1896
1897         new-run-webkit-tests: add more unit tests
1898
1899         This change adds more unit tests for the image_diff, test_failures,
1900         and test_files modules, bringing them to 100% coverage (and adds a
1901         couple tests to run_webkit_tests while we're at it).
1902
1903         This test also turns on the "dryrun" port for testing when run on
1904         the mac, increasing coverage in a few other places.
1905
1906         https://bugs.webkit.org/show_bug.cgi?id=44578
1907
1908         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
1909         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
1910         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
1911         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
1912         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
1913         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
1914         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
1915         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
1916         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1917         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
1918         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1919         * Scripts/webkitpy/layout_tests/port/test.py:
1920         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1921
1922 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1923
1924         Reviewed by Ojan Vafai.
1925
1926         new-run-webkit-tests: add more unit tests for layout_package/printing.py
1927
1928         This change adds more unit tests to get the test coverage to 100%
1929         for the printing module. This code is actually pretty crufty and
1930         has some layering violations that need to be cleaned up but I'll
1931         save that for another CL after we get all the unit tests written and
1932         we fix the multithreading issues. At least now we'll be able to tell
1933         if we break things.
1934
1935         https://bugs.webkit.org/show_bug.cgi?id=44576
1936
1937         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1938         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1939
1940 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1941
1942         Reviewed by Adam Barth.
1943
1944         new-run-webkit-tests should respect set-webkit-configuration
1945         https://bugs.webkit.org/show_bug.cgi?id=44633
1946
1947         Moves the getting of the configuration into the base Port so that
1948         chromium ports use it as well. In the downstream chromium port,
1949         this should still just return Release.
1950
1951         * Scripts/webkitpy/layout_tests/port/base.py:
1952         * Scripts/webkitpy/layout_tests/port/webkit.py:
1953
1954 2010-08-25  Tony Chang  <tony@chromium.org>
1955
1956         Not reviewed, changing svn props for a script.
1957
1958         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
1959
1960 2010-08-25  Adam Barth  <abarth@webkit.org>
1961
1962         Reviewed by Eric Seidel.
1963
1964         Remove WebKit2 from core builders
1965         https://bugs.webkit.org/show_bug.cgi?id=44625
1966
1967         This builder was added to the core builders by accident.  It doesn't
1968         appear to be green enough to be a core builder yet.
1969
1970         * Scripts/webkitpy/common/net/buildbot.py:
1971         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1972
1973 2010-08-19  Adam Roben  <aroben@apple.com>
1974
1975         Test that NP_Initialize and NP_GetEntryPoints are called in the
1976         correct order
1977
1978         The order differs between Mac and Windows (see r38858).
1979
1980         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1981         NP_Initialize when loading QuickTime when running
1982         plugins/embed-attributes-setting.html in WebKit2 on Windows
1983
1984         Reviewed by John Sullivan.
1985
1986         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1987         a boolean to record whether NP_GetEntryPoints has been called.
1988         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1989         called yet. This matches Flash and QuickTime's behavior.
1990         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
1991         yet. This matches Silverlight's behavior.
1992
1993 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1994
1995         Reviewed by Gustavo Noronha Silva.
1996
1997         Cairo and EFL port shouldn't depend on glib.
1998         https://bugs.webkit.org/show_bug.cgi?id=44354
1999
2000         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
2001         adoptPlatformRef.
2002
2003         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2004         (AccessibilityUIElement::isSelected):
2005
2006 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2007
2008         Fix order of Timothy's email address. The script, and
2009         other tools all assume that the first email is the bugzilla address.
2010
2011         * Scripts/webkitpy/common/config/committers.py:
2012
2013 2010-08-24  Kent Tamura  <tkent@chromium.org>
2014
2015         Reviewed by Pavel Feldman.
2016
2017         [DRT/Chromium] Fix 26 inspector test crashes
2018         https://bugs.webkit.org/show_bug.cgi?id=44580
2019
2020         - DRTDevToolsAgent has a reference to the main WebView. So we
2021           should not clear it in closeDevTools() and should clear it in
2022           ~TestShell().
2023         - DRTDevToolsClient has a reference to a DevTools WebView and no
2024           way to update it. So we should delete DRTDevToolsClient instances
2025           in closeDevTools().
2026
2027         * DumpRenderTree/chromium/TestShell.cpp:
2028         (TestShell::~TestShell):
2029         (TestShell::closeDevTools):
2030
2031 2010-08-24  Eric Seidel  <eric@webkit.org>
2032
2033         Reviewed by Adam Barth.
2034
2035         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
2036         https://bugs.webkit.org/show_bug.cgi?id=44584
2037
2038         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2039
2040 2010-08-24  Eric Seidel  <eric@webkit.org>
2041
2042         Reviewed by Adam Barth.
2043
2044         commit-queue and EWS bots should report all failures
2045         https://bugs.webkit.org/show_bug.cgi?id=41820
2046
2047         Right now commit-queue/EWS only report failures when the
2048         patch under testing fails.  We should report all failures
2049         to the status server so that we can diagnose when the bots
2050         are wedged w/o needing to log into the machines.
2051
2052         I also reduced the amount of data we upload since we've seen
2053         timeouts during status upload.
2054
2055         * Scripts/webkitpy/common/system/executive.py:
2056         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2057         * Scripts/webkitpy/tool/commands/queues.py:
2058         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2059
2060 2010-08-24  Eric Seidel  <eric@webkit.org>
2061
2062         Reviewed by Adam Barth.
2063
2064         Remove HTML5 parser testing infrastructure now that we don't need it
2065         https://bugs.webkit.org/show_bug.cgi?id=44581
2066
2067         * DumpRenderTree/mac/DumpRenderTree.mm:
2068         (resetDefaultsToConsistentValues):
2069         (initializeGlobalsFromCommandLineOptions):
2070         * Scripts/old-run-webkit-tests:
2071         * Scripts/test-html5-parser: Removed.
2072
2073 2010-08-24  Kent Tamura  <tkent@chromium.org>
2074
2075         Reviewed by Dimitri Glazkov.
2076
2077         [DRT/Chromium] Fix 28 inspector test crashes
2078         https://bugs.webkit.org/show_bug.cgi?id=44574
2079
2080         Reset DevToolsClient and DevToolsAgent before closing a DevTools
2081         WebView in order to avoid accessing to a deleted WebView instance.
2082
2083         * DumpRenderTree/chromium/TestShell.cpp:
2084         (TestShell::closeDevTools):
2085
2086 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2087
2088         Reviewed by Ojan Vafai.
2089
2090         new-run-webkit-tests: clean up code for test_types, test_failures
2091
2092         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
2093         webkitpy.layout_tests.layout_package.test_failures, and remove
2094         some dead code and otherwise clean up things.
2095
2096         https://bugs.webkit.org/show_bug.cgi?id=44559
2097
2098         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2099         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
2100         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2101         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2102         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2103         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
2104         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2105
2106 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2107
2108         Reviewed by Eric Seidel.
2109
2110         new-run-webkit-tests: revise unit testing strategy for test failures
2111     
2112         This change revamps the way we store test data for new-run-webkit-tests.
2113         Previously we had a few copies of test files from the main test tree.
2114         Now we have a bunch of completely fake test data and use the test
2115         data to generate different kinds of test failures, getting
2116         much better coverage.
2117
2118         https://bugs.webkit.org/show_bug.cgi?id=44556
2119
2120         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
2121         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
2122         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
2123         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
2124         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
2125         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
2126         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
2127         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
2128         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
2129         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
2130         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
2131         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
2132         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
2133         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
2134         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
2135         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
2136         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
2137         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
2138         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
2139         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
2140         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
2141         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
2142         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
2143         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
2144         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
2145         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
2146         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
2147         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
2148         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
2149         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
2150         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
2151         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
2152         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
2153         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
2154         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
2155         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
2156         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
2157         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
2158         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
2159         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
2160         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
2161         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
2162         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
2163         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2164         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
2165         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
2166         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2167         * Scripts/webkitpy/layout_tests/port/test.py:
2168         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2169         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2170
2171 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2172
2173         Reviewed by Eric Seidel.
2174
2175         speed up new-run-webkit-tests unit tests
2176
2177         Add a --no-record-results flag that turns off generating the JSON
2178         results file on every test run. Generating the file requires us to
2179         fetch the old results down from the bots, which can be slow. This
2180         flag is off by default.
2181     
2182         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
2183     
2184         These changes together shorten the test cycle from ~4.5s to ~1.5s
2185         - a 3x speedup.
2186
2187         https://bugs.webkit.org/show_bug.cgi?id=44553
2188
2189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2190         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2191
2192 2010-08-24  Tony Chang  <tony@chromium.org>
2193
2194         Reviewed by Eric Seidel.
2195
2196         [chromium] fix the platform result fallback order on mac/win
2197         https://bugs.webkit.org/show_bug.cgi?id=44483
2198
2199         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2200
2201 2010-08-24  Xan Lopez  <xlopez@igalia.com>
2202
2203         Reviewed by Martin Robinson.
2204
2205         Set a device to the event struct when building with GTK+ 3.x, it's
2206         mandatory.
2207
2208         * DumpRenderTree/gtk/EventSender.cpp:
2209         (keyDownCallback):
2210
2211 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2212
2213         Reviewed by Xan Lopez.
2214
2215         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2216         https://bugs.webkit.org/show_bug.cgi?id=44534
2217
2218         Fix two double-frees introduced in my previous commit.
2219
2220         * DumpRenderTree/gtk/EventSender.cpp:
2221         (contextClickCallback): Copy the event before using it again.
2222         (keyDownCallback): Ditto.
2223
2224 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2225
2226         Reviewed by Xan Lopez.
2227
2228         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2229         https://bugs.webkit.org/show_bug.cgi?id=44534
2230
2231         * DumpRenderTree/gtk/EventSender.cpp:
2232         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
2233         when setting it on the event. It is dereferenced by gdk_event_free(...).
2234         (contextClickCallback): Ditto.
2235         (mouseDownCallback): Ditto.
2236         (mouseUpCallback): Ditto.
2237         (mouseMoveToCallback): Ditto.
2238         (mouseWheelToCallback): Ditto.
2239         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
2240         (dispatchEvent): Ditto. Also free the event when we are done with it.
2241         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
2242
2243 2010-08-24  Andras Becsi  <abecsi@webkit.org>
2244
2245         [Qt] WebKit2 build fix.
2246
2247         * Scripts/enumerate-included-framework-headers:
2248         Remove stray global option form sed.
2249
2250 2010-08-24  Kent Tamura  <tkent@chromium.org>
2251
2252         Reviewed by Jeremy Orlow.
2253
2254         [DRT/Chromium] Support for IndexedDB tests
2255         https://bugs.webkit.org/show_bug.cgi?id=44490
2256
2257         * DumpRenderTree/chromium/TestShell.cpp:
2258         (TestShell::TestShell): Enable IndexedDB.
2259
2260 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
2261
2262         Reviewed by Gustavo Noronha Silva.
2263
2264         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
2265         https://bugs.webkit.org/show_bug.cgi?id=44465
2266
2267         Initialize the axes field of mouse button and motion events to null.
2268         This is the value that should be used for events originating from the
2269         mouse device.
2270
2271         * DumpRenderTree/gtk/EventSender.cpp:
2272         (prepareMouseButtonEvent): Initalize button event axes field to null.
2273         (mouseMoveToCallback): Initialize motion event axes field to null.
2274
2275 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2276
2277         Unreviewed, rolling out r65703.
2278         http://trac.webkit.org/changeset/65703
2279         https://bugs.webkit.org/show_bug.cgi?id=44460
2280
2281         "Causing lots of crashes on Snow Leopard when running the
2282         layout tests" (Requested by eseidel2 on #webkit).
2283
2284         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2285         (NP_Initialize):
2286         (NP_GetEntryPoints):
2287
2288 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
2289
2290         Layout tests do not run when using WebKitTestRunner in a Debug build.
2291         https://bugs.webkit.org/show_bug.cgi?id=44409
2292
2293         Reviewed by Dan Bernstein.
2294
2295         * WebKitTestRunner/win/TestControllerWin.cpp:
2296         (WTR::TestController::initializeInjectedBundlePath):
2297         Use InjectedBundle_debug.dll when building Debug.
2298
2299 2010-08-23  Xan Lopez  <xlopez@igalia.com>
2300
2301         Reviewed by Martin Robinson.
2302
2303         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
2304         https://bugs.webkit.org/show_bug.cgi?id=42026
2305
2306         If a GTK+ 3.x build is present return that as the library to use,
2307         otherwise fallback to the GTK+ 2.x build.
2308
2309         * Scripts/webkitdirs.pm:
2310
2311 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
2312
2313         Reviewed by Ariya Hidayat.
2314
2315         [Qt] Find needed forwarding headers for WebKit2 automatically
2316         https://bugs.webkit.org/show_bug.cgi?id=44336
2317
2318         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
2319         The new script does not satisfy the needs of this file however using normal includes
2320         is generally better here.
2321         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
2322         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
2323         given frameworks by files in the current directory (and subdirectories).
2324         In the future this needs to be rewritten in perl for being able to use on Windows.
2325
2326 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
2327
2328         Reviewed by Ariya Hidayat.
2329
2330         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
2331         https://bugs.webkit.org/show_bug.cgi?id=43010
2332
2333         * QtTestBrowser/launcherwindow.cpp:
2334         (LauncherWindow::applyPrefs):
2335         * QtTestBrowser/main.cpp:
2336         (LauncherApplication::handleUserOptions):
2337
2338 2010-08-21  Sam Weinig  <sam@webkit.org>
2339
2340         Reviewed by Dan Bernstein.
2341
2342         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
2343         https://bugs.webkit.org/show_bug.cgi?id=44386
2344
2345         * MiniBrowser/mac/AppDelegate.m:
2346         (didRecieveMessageFromInjectedBundle):
2347         (didNavigateWithNavigationData):
2348         (-[BrowserAppDelegate init]):
2349         (-[BrowserAppDelegate applicationWillTerminate:]):
2350         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2351         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
2352         (-[BrowserStatisticsWindowController dealloc]):
2353         * MiniBrowser/mac/BrowserWindowController.m:
2354         (-[BrowserWindowController initWithPageNamespace:]):
2355         (-[BrowserWindowController fetch:]):
2356         (-[BrowserWindowController windowWillClose:]):
2357         (-[BrowserWindowController applicationTerminating]):
2358         (closePage):
2359         (runJavaScriptAlert):
2360         (runJavaScriptConfirm):
2361         (runJavaScriptPrompt):
2362         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2363         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2364         (didClearWindowObjectForFrame):
2365         * MiniBrowser/win/BrowserView.cpp:
2366         (BrowserView::goToURL):
2367         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2368         (WTR::PlatformWebView::~PlatformWebView):
2369
2370 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
2371
2372         Reviewed by Kenneth Rohde Christiansen.
2373
2374         WebKit does not build with Python 2.3
2375         https://bugs.webkit.org/show_bug.cgi?id=44373
2376
2377         Replaced the function sorted() by a call to sort()
2378         on the entry list.
2379         The function sorted() has been added to Python 2.4.
2380         The function method sort() of List works with older
2381         versions of Python.
2382
2383         * Scripts/create-html-entity-table:
2384
2385 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
2386
2387         Reviewed by Pavel Feldman.
2388
2389         Web Inspector: Inspector tests were disabled for GTK.
2390         https://bugs.webkit.org/show_bug.cgi?id=43977
2391
2392         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
2393         path before running tests.
2394
2395 2010-08-20  Daniel Bates  <dbates@rim.com>
2396
2397         Reviewed by Eric Seidel.
2398
2399         svn-apply doesn't detect empty line with Windows line endings
2400         after property value
2401         https://bugs.webkit.org/show_bug.cgi?id=43981
2402
2403         Part 2 of 2
2404
2405         Add unit tests that were not landed in the first commit.
2406
2407         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2408           - Added the following test cases:
2409             "SVN: binary file (isBinary true) using Windows line endings"
2410             "SVN: property diff, followed by file change diff using Windows line endings"
2411             "SVN: two consecutive property diffs using Windows line endings"
2412             "SVN: binary file with executable bit change usng Windows line endings"
2413             "SVN: binary file followed by property change on different file using Windows line endings"
2414             "SVN: binary file followed by file change on different file using Windows line endings"
2415             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2416             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2417         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2418           - Added the following test cases:
2419             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2420             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2421             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2422             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2423             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2424             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2425             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2426             "single-line '+' with trailing new line using Windows line endings"
2427             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2428             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2429             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2430         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2431           - Added the following test cases:
2432             "single-line '-' change followed by empty line with Windows line endings"
2433             "multi-line '+' change and start of binary patch with Windows line endings"
2434
2435 2010-08-20  Daniel Bates  <dbates@rim.com>
2436
2437         Reviewed by Eric Seidel.
2438
2439         svn-apply doesn't detect empty line with Windows line endings
2440         after property value
2441         https://bugs.webkit.org/show_bug.cgi?id=43981
2442
2443         Fixes an issue where an empty line following the property value
2444         in an SVN property change diff would not be detected if it had
2445         Windows line endings (i.e. ended in CRLF). Hence it was consumed
2446         as if it was part of a multi-line property value. 
2447
2448         * Scripts/VCSUtils.pm:
2449           - Modified parseSvnPropertyValue() to detect empty line
2450             with Windows line endings.
2451           - Added toWindowsLineEndings().
2452         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2453           - Added the following test cases:
2454             "SVN: binary file (isBinary true) using Windows line endings"
2455             "SVN: property diff, followed by file change diff using Windows line endings"
2456             "SVN: two consecutive property diffs using Windows line endings"
2457             "SVN: binary file with executable bit change usng Windows line endings"
2458             "SVN: binary file followed by property change on different file using Windows line endings"
2459             "SVN: binary file followed by file change on different file using Windows line endings"
2460             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2461             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2462         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2463           - Added the following test cases:
2464             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2465             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2466             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2467             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2468             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2469             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2470             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2471             "single-line '+' with trailing new line using Windows line endings"
2472             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2473             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2474             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2475         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2476           - Added the following test cases:
2477             "single-line '-' change followed by empty line with Windows line endings"
2478             "multi-line '+' change and start of binary patch with Windows line endings"
2479
2480 2010-08-19  David Kilzer  <ddkilzer@apple.com>
2481
2482         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
2483
2484         * MiniBrowser/mac/BrowserWindowController.m:
2485         (decidePolicyForNavigationAction): Updated method signature.
2486         (decidePolicyForNewWindowAction): Updated method signature.
2487
2488 2010-08-19  Adam Roben  <aroben@apple.com>
2489
2490         Test that NP_Initialize and NP_GetEntryPoints are called in the
2491         correct order
2492
2493         The order differs between Mac and Windows (see r38858).
2494
2495         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
2496         NP_Initialize when loading QuickTime when running
2497         plugins/embed-attributes-setting.html in WebKit2 on Windows
2498
2499         Reviewed by Sam Weinig.
2500
2501         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
2502         a boolean to record whether NP_GetEntryPoints has been called.
2503         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
2504         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
2505         if NP_GetEntryPoints has been called already. This matches
2506         Silverlight's behavior.
2507
2508 2010-08-19  Adam Roben  <aroben@apple.com>
2509
2510         Make build-webkittestrunner build TestNetscapePlugIn on Windows
2511
2512         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
2513
2514         Reviewed by Sam Weinig.
2515
2516         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
2517         Threaded it in between ImageDiff and InjectedBundleGenerated.
2518
2519 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2520
2521         Reviewed by Adam Barth.
2522
2523         install rietveld's upload script from a versioned url
2524         https://bugs.webkit.org/show_bug.cgi?id=44291
2525
2526         autoinstall expects the file at a given URL to never change.
2527         In order to be able to update the file, we need to be able to
2528         change the path.
2529
2530         * Scripts/webkitpy/thirdparty/__init__.py:
2531
2532 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2533
2534         Reviewed by Adam Barth.
2535
2536         add --webkit_patch_id to reitveld uploads
2537         https://bugs.webkit.org/show_bug.cgi?id=44289
2538
2539         This is the first step in having rietveld store which
2540         patches have been uploaded and getting rid of the
2541         in-rietveld flag.
2542
2543         * Scripts/webkitpy/common/net/rietveld.py:
2544         * Scripts/webkitpy/tool/mocktool.py:
2545         * Scripts/webkitpy/tool/steps/postcodereview.py:
2546
2547 2010-08-19  Kenneth Russell  <kbr@google.com>
2548
2549         Reviewed by David Levin.
2550
2551         Adjust my status from committer to reviewer
2552         https://bugs.webkit.org/show_bug.cgi?id=44277
2553
2554         * Scripts/webkitpy/common/config/committers.py:
2555
2556 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2557
2558         Reviewed by Yury Semikhatsky.
2559
2560         Chromium DevTools: remove injected script fetcher from test harness.
2561         https://bugs.webkit.org/show_bug.cgi?id=44266
2562
2563         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2564         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2565
2566 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2567
2568         Reviewed by Yury Semikhatsky.
2569
2570         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
2571         Now that we populate front-end after its onload handler, we don't need
2572         to install injected script early. Exposing injected script source on the WebCore
2573         level here.
2574         https://bugs.webkit.org/show_bug.cgi?id=44029
2575
2576         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2577         (DRTDevToolsAgent::runtimePropertyChanged):
2578         (DRTDevToolsAgent::delayedFrontendLoaded):
2579         (DRTDevToolsAgent::frontendLoaded):
2580         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2581
2582 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2583
2584         Reviewed by Kenneth Rohde Christiansen.
2585
2586         [Gtk] Enable view mode media feature layout test
2587         https://bugs.webkit.org/show_bug.cgi?id=43278
2588
2589         Add view mode media feature testing infrastructure, and add
2590         placeholder methods for the other platforms'
2591         LayoutTestControllers.
2592
2593         * DumpRenderTree/LayoutTestController.cpp:
2594         (setViewModeMediaFeatureCallback):
2595         (LayoutTestController::staticFunctions):
2596         * DumpRenderTree/LayoutTestController.h:
2597         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2598         (LayoutTestController::setViewModeMediaFeature):
2599         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2600         (LayoutTestController::setViewModeMediaFeature):
2601         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2602         (LayoutTestController::setViewModeMediaFeature):
2603         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2604         (LayoutTestController::setViewModeMediaFeature):
2605
2606 2010-08-18  Mark Rowe  <mrowe@apple.com>
2607
2608         Reviewed by Sam Weinig.
2609
2610         Make it so the WebKit2 test slave runs the WebKit2 tests
2611
2612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2613
2614 2010-08-18  Sam Weinig  <sam@webkit.org>
2615
2616         Reviewed by Mark Rowe.
2617
2618         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
2619         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
2620         module and the TestNetscapePlugin.
2621
2622         * Scripts/old-run-webkit-tests:
2623
2624 2010-08-18  Adam Roben  <aroben@apple.com>
2625
2626         Fix hang when saving crash logs on Windows
2627
2628         * Scripts/old-run-webkit-tests:
2629         (setUpWindowsCrashLogSaving):
2630         (END):
2631         Pass -s to regtool so it will write the Auto value as a string instead
2632         of as a number. This was causing a "do you want to debug?" dialog to
2633         appear.
2634
2635 2010-08-17  Victor Wang  <victorw@chromium.org>
2636
2637         Unreviewed. Fixed chromium incremental test json upload.
2638         Quote builder name and test results server in url.
2639
2640         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2641
2642 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2643
2644         Reviewed by Ariya Hidayat.
2645
2646         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
2647         https://bugs.webkit.org/show_bug.cgi?id=44124
2648
2649         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
2650         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
2651         Symbian dependencies.
2652
2653         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2654         (WebCore::DumpRenderTree::open):
2655         * QtTestBrowser/launcherwindow.cpp:
2656         (LauncherWindow::init):
2657         (LauncherWindow::toggleFullScreenMode):
2658         (LauncherWindow::showFPS):
2659         (LauncherWindow::updateFPS):
2660         * QtTestBrowser/launcherwindow.h:
2661         (WindowOptions::WindowOptions):
2662         * QtTestBrowser/mainwindow.cpp:
2663         (MainWindow::buildUI):
2664
2665 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2666
2667         Reviewed by David Levin.
2668
2669         new-run-webkit-tests: remove --show-sources option
2670
2671         --show-sources is pretty much obsolete with --trace everything, so
2672         I'm removing it.
2673
2674         Also rename a couple of methods in the TestTextDiff class to make their
2675         intended visibility (private) more obvious.
2676
2677         https://bugs.webkit.org/show_bug.cgi?id=44143
2678
2679         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2680         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2681         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2682         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2683         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2684
2685 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2686
2687         Reviewed by David Levin.
2688
2689         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
2690
2691         This code bit-rotted at some point more than a year ago, and nobody seems
2692         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
2693         should support instead, making this flag unnecessary anyway.
2694
2695         https://bugs.webkit.org/show_bug.cgi?id=44141
2696
2697         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2698         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2699         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
2700
2701 2010-08-17  Victor Wang  <victorw@chromium.org>
2702
2703         Reviewed by Ojan Vafai.
2704
2705         Update json results generator to have incremental json including
2706         results for tests that pass in current run but failed before.
2707
2708         https://bugs.webkit.org/show_bug.cgi?id=44119
2709
2710         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2711         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2712         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2713
2714 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2715
2716         Reviewed by Eric Seidel.
2717
2718         fix test-webkitpy, add easy way to find a checkout root
2719
2720         test-webkitpy currently doesn't work right if run from someplace other
2721         than the checkout root, and it spews a bunch of debug logging because
2722         the deduplicate_tests tests contaminates the test environment.
2723
2724         This patch cleans up the deduplicate_tests unit tests, and creates
2725         two new methods in scm.py: find_checkout_root() and default_scm(),
2726         both of which use a single algorithm for guessing what checkout root
2727         to use if you aren't explicitly told one from a path.
2728
2729         https://bugs.webkit.org/show_bug.cgi?id=44001
2730
2731         * Scripts/deduplicate-tests:
2732         * Scripts/webkitpy/common/checkout/scm.py:
2733         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2734         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2735         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2736         * Scripts/webkitpy/layout_tests/port/test.py:
2737         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2738         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2739         * Scripts/webkitpy/tool/main.py:
2740
2741 2010-08-17  Victor Wang  <victorw@chromium.org>
2742
2743         Reviewed by Ojan Vafai.
2744
2745         Add support to the test results server for downloading json that
2746         contains test list only.
2747
2748         This is for json results generator to generate incremental json
2749         results so that it includes results not only for tests failed in
2750         current run, but also tests failed before.
2751
2752         Also set the results type to "N" (no data) instead of "P" (pass)
2753         if test results cannot be found in incremental json file.
2754
2755         https://bugs.webkit.org/show_bug.cgi?id=44117
2756
2757         * TestResultServer/handlers/testfilehandler.py:
2758         * TestResultServer/model/jsonresults.py:
2759         * TestResultServer/model/jsonresults_unittest.py:
2760
2761 2010-08-17  Adam Roben  <aroben@apple.com>
2762
2763         Use the right path style
2764
2765         * Scripts/old-run-webkit-tests:
2766
2767 2010-08-17  Adam Roben  <aroben@apple.com>
2768
2769         Fix typo
2770
2771         * Scripts/old-run-webkit-tests:
2772
2773 2010-08-17  Adam Roben  <aroben@apple.com>
2774
2775         Don't hang when running run-webkit-tests as a non-Administrator on
2776         Vista/7
2777
2778         * Scripts/old-run-webkit-tests:
2779         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
2780         post-mortem debugger, rather than using NTSD itself. The latter waits
2781         for user input when it fails to set the registry values; the former
2782         does not.
2783
2784 2010-08-17  Adam Roben  <aroben@apple.com>
2785
2786         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
2787         save crash logs on Windows
2788
2789         The crash logs are saved to /tmp/layout-test-results and have names
2790         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
2791
2792         Unfortunately, crashes in the WebKit2 web process are recorded as
2793         time-outs by run-webkit-tests. Fixing this is covered by
2794         <http://webkit.org/b/44121>.
2795
2796         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
2797         DumpRenderTree should save a stack trace and/or dump file when it
2798         crashes
2799
2800         Reviewed by Sam Weinig.
2801
2802         * DumpRenderTree/win/DumpRenderTree.cpp:
2803         (exceptionFilter):
2804         (main):
2805         * WebKitTestRunner/win/TestControllerWin.cpp:
2806         (WTR::exceptionFilter):
2807         (WTR::TestController::platformInitialize):
2808         These changes set up an exception filter that prints #CRASHED to
2809         stderr, then lets the exception propagate normally. This allows
2810         run-webkit-tests to detect when we've crashed even when a post-mortem
2811         debugger attaches to the process.
2812
2813         * Scripts/old-run-webkit-tests:
2814         (top level): Declared some variables used by the crash-log-saving
2815         code.
2816         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
2817         that the post-mortem debugger has access to it.
2818         (toCygwinPath): Added. This is the opposite of toWindowsPath.
2819         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
2820         stderr, consider it a crash.
2821         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
2822         debugger, then sets ntsd as the post-mortem debugger. ntsd is
2823         configured to save a crash log and then quit automatically.
2824         (END): Added. Restores the previous post-mortem debugger when the
2825         script exits.
2826
2827 2010-08-17  Victor Wang  <victorw@chromium.org>
2828
2829         Reviewed by ojan@chromium.org.
2830
2831         Update test results server:
2832         1. Normalize test results and times after merging (prune tests where
2833            all runs pass or do not have data, truncate all test items to max
2834            number of builds)
2835         2. times should be int not string.
2836         3. when inserting a new test item, should keep old data regardless
2837            whether or not they have same item type with new one.
2838
2839         https://bugs.webkit.org/show_bug.cgi?id=43861
2840
2841         * TestResultServer/model/jsonresults.py:
2842         * TestResultServer/model/jsonresults_unittest.py:
2843
2844 2010-08-16  Sam Weinig  <sam@webkit.org>
2845
2846         Reviewed by Mark Rowe.
2847
2848         Add WebKit2 Mac tester to buildbot.
2849
2850         * BuildSlaveSupport/build.webkit.org-config/config.json:
2851         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2852
2853 2010-08-16  Paul Sawaya  <psawaya@apple.com>
2854
2855         Reviewed by Chris Marrin.
2856
2857         Added shader validation via ANGLE
2858         https://bugs.webkit.org/show_bug.cgi?id=42405
2859
2860         Added ANGLE to webkit build
2861
2862         * Scripts/build-webkit:
2863
2864 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
2865
2866         [wx] Build fix, do not build WebCore as a convenience library as this leads to
2867         errors in the Win build w/export symbols and causes problems with DOM bindings
2868         debugging in gdb.
2869
2870         * DumpRenderTree/wscript:
2871         * Scripts/build-webkit:
2872         * wx/browser/wscript:
2873         * wx/build/settings.py:
2874         * wx/build/waf_extensions.py:
2875
2876 2010-08-16  Dan Bernstein  <mitz@apple.com>
2877
2878         Build fix.
2879
2880         * WebKitTestRunner/TestController.cpp:
2881         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
2882         (WTR::TestController::initialize): Ditto.
2883
2884 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2885
2886         Reviewed by Kenneth Rohde Christiansen.
2887
2888         Handle content size change in WebKit2
2889         Re-landing after fix.
2890
2891         https://bugs.webkit.org/show_bug.cgi?id=43198
2892
2893         * MiniBrowser/mac/BrowserWindowController.m:
2894         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2895         * MiniBrowser/win/BrowserView.cpp:
2896         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2897
2898 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2899
2900         Unreviewed, rolling out r65419.
2901         http://trac.webkit.org/changeset/65419
2902         https://bugs.webkit.org/show_bug.cgi?id=44053
2903
2904         Broke the Windows build (Requested by bbandix on #webkit).
2905
2906         * MiniBrowser/mac/BrowserWindowController.m:
2907         (-[BrowserWindowController awakeFromNib]):
2908         * MiniBrowser/win/BrowserView.cpp:
2909         (BrowserView::create):
2910
2911 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2912
2913         Reviewed by Kenneth Rohde Christiansen.
2914
2915         Handle content size change in WebKit2
2916
2917         https://bugs.webkit.org/show_bug.cgi?id=43198
2918
2919         * MiniBrowser/mac/BrowserWindowController.m:
2920         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2921         * MiniBrowser/win/BrowserView.cpp:
2922         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2923
2924 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
2925
2926         Add my new email address to committers.py.
2927
2928         * Scripts/webkitpy/common/config/committers.py:
2929
2930 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
2931
2932         Add my old e-mail addresses to committers.py.
2933
2934         * Scripts/webkitpy/common/config/committers.py:
2935
2936 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2937
2938         WebEditorClient::didBeginEditing is never called in WebKit2
2939         https://bugs.webkit.org/show_bug.cgi?id=42939
2940
2941         Reviewed by Sam Weinig.
2942
2943         * WebKitTestRunner/PlatformWebView.h:
2944         Declare focus().
2945
2946         * WebKitTestRunner/TestController.cpp:
2947         (WTR::TestController::resetStateToConsistentValues):
2948         Focus the PlatformWebView.
2949
2950         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2951         (WTR::PlatformWebView::focus):
2952         Stubbed.
2953
2954         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2955         (WTR::PlatformWebView::focus):
2956         Focus the view.
2957
2958 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2959
2960         run-webkit-tests should not strip editing callbacks when using
2961         WebKitTestRunner on Windows
2962         https://bugs.webkit.org/show_bug.cgi?id=44000
2963
2964         Reviewed by Mark Rowe.
2965
2966         * Scripts/old-run-webkit-tests:
2967         Leave $stripEditingCallbacks undefined until we look for command-line
2968         arguments. If using WebKit2, set it to 0 if not explicity set on the
2969         command line. Later, set it to isCygwin() to match old behavior if it is
2970         not yet defined.
2971
2972 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
2973
2974         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
2975
2976         * wx/build/settings.py:
2977
2978 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
2979
2980         Reviewed by Kenneth Rohde Christiansen.
2981
2982         [GTK] autogen.sh not executed if build-webkit options change
2983         https://bugs.webkit.org/show_bug.cgi?id=42266
2984
2985         Rerun autogen.sh in situations where the arguments to build-webkit have
2986         changed since the previous build. This will fix some issues on the bots
2987         where the build does not notice changes to default build-webkit arguments.
2988
2989         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
2990
2991 2010-08-14  Eric Seidel  <eric@webkit.org>
2992
2993         Unreviewed.  Another fix to support python 2.3.
2994
2995         Add support for MathML entities
2996         https://bugs.webkit.org/show_bug.cgi?id=43949
2997
2998         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
2999          - It looks like our simplejson is version 1.7.3 which
3000            should be python 2.3 compatible.  But someone modified
3001            our copy slightly from the original source.
3002            I've removed the relative import in hopes this fixes
3003            the problem.
3004
3005 2010-08-13  Eric Seidel  <eric@webkit.org>
3006
3007         Unreviewed.  Build fix only.
3008
3009         Add support for MathML entities
3010         https://bugs.webkit.org/show_bug.cgi?id=43949
3011
3012         * Scripts/create-html-entity-table:
3013          - Hack sys.path to avoid executing 2.5 dependent python
3014            on systems (like chromium-win and Tiger) which do not have 2.5 python.
3015
3016 2010-08-13  Adam Barth  <abarth@webkit.org>
3017
3018         Reviewed by Eric Seidel.
3019
3020         Rename some concepts in HTML entity search to be more self-documenting
3021         https://bugs.webkit.org/show_bug.cgi?id=44004
3022
3023         Reflect name change in generator script.
3024
3025         * Scripts/create-html-entity-table:
3026
3027 2010-08-12  Adam Barth  <abarth@webkit.org>
3028
3029         Reviewed by Eric Seidel.
3030
3031         Add support for MathML entities
3032         https://bugs.webkit.org/show_bug.cgi?id=43949
3033
3034         A script for generating the C++ state data structure describing all the
3035         entities from a JSON description.
3036
3037         * Scripts/create-html-entity-table: Added.
3038
3039 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
3040
3041         Reviewed by Eric Seidel.
3042
3043         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
3044         check for exceptions on all threads, not just the first thread.
3045         
3046         This change also changes the logging behavior for wedged threads
3047         to only dump the stacks of threads that are actually wedged.
3048
3049         Refactor the thread classes in the dump_render_tree_thread module
3050         to make the contract between TestRunner and TestShellThread clearer.
3051
3052         Added a bunch of unit tests.
3053         https://bugs.webkit.org/show_bug.cgi?id=38561
3054
3055         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3056         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3057         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3058
3059 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
3060
3061         Reviewed by Shinichiro Hamaji.
3062
3063         Add test_expectations.txt syntax checker to check-webkit-style.
3064         https://bugs.webkit.org/show_bug.cgi?id=43899
3065
3066         Just utilizing layout_tests/layout_package/test_expectations.py for checking
3067         the syntax of test_expectations.txt.
3068         This change also moves tab checking class from style/checkers/text.py to
3069         style/checkers/common.py for sharing code.
3070
3071         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3072         * Scripts/webkitpy/style/checker.py:
3073         * Scripts/webkitpy/style/checkers/common.py:
3074         * Scripts/webkitpy/style/checkers/common_unittest.py:
3075         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
3076         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
3077         * Scripts/webkitpy/style/checkers/text.py:
3078         * Scripts/webkitpy/style_references.py:
3079
3080 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3081
3082         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
3083         https://bugs.webkit.org/show_bug.cgi?id=43945
3084
3085         Reviewed by Sam Weinig.
3086
3087         * WebKitTestRunner/TestInvocation.cpp:
3088         (WTR::sizeWebViewForCurrentTest):
3089         Allow for a Windows-style path.
3090
3091         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3092         (WTR::PlatformWebView::resizeTo):
3093         Call SetWindowPos to resize the view window.
3094
3095 2010-08-12  David Levin  <levin@chromium.org>
3096
3097         Build break fix.
3098
3099         * WebKitTestRunner/TestController.cpp:
3100         (WTR::TestController::resetStateToConsistentValues): Removed usage
3101         of a variable that doesn't exist in the class.
3102
3103 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3104
3105         WebKitTestRunner needs to run tests without using native controls
3106         https://bugs.webkit.org/show_bug.cgi?id=43772
3107
3108         Reviewed by Sam Weinig.
3109
3110         * WebKitTestRunner/TestController.cpp:
3111         (WTR::TestController::initialize):
3112         Call platformInitializeContext().
3113
3114         * WebKitTestRunner/TestController.h:
3115         Declare platformInitializeContext().
3116
3117         * WebKitTestRunner/mac/TestControllerMac.mm:
3118         (WTR::TestController::platformInitializeContext):
3119         Stubbed.
3120
3121         * WebKitTestRunner/win/TestControllerWin.cpp:
3122         (WTR::TestController::platformInitializeContext):
3123         Call WKContextSetShouldPaintNativeControls() to disable native control
3124         drawing.
3125
3126 2010-08-12  Sam Weinig  <sam@webkit.org>
3127
3128         Reviewed by Alexey Proskuryakov.
3129
3130         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
3131         https://bugs.webkit.org/show_bug.cgi?id=43653
3132
3133         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3134         (WTR::InjectedBundle::InjectedBundle):
3135         (WTR::InjectedBundle::didReceiveMessage):
3136         (WTR::InjectedBundle::beginTesting):
3137         (WTR::InjectedBundle::done):
3138         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3139         (WTR::InjectedBundle::isTestRunning):
3140         (WTR::InjectedBundle::):
3141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3142         (WTR::InjectedBundlePage::stopLoading):
3143         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3144         (WTR::InjectedBundlePage::dump):
3145         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3146         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3147         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3148         (WTR::InjectedBundlePage::didClearWindowForFrame):
3149         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3150         (WTR::InjectedBundlePage::willAddMessageToConsole):
3151         (WTR::InjectedBundlePage::willSetStatusbarText):
3152         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3153         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3154         (WTR::InjectedBundlePage::shouldBeginEditing):
3155         (WTR::InjectedBundlePage::shouldEndEditing):
3156         (WTR::InjectedBundlePage::shouldInsertNode):
3157         (WTR::InjectedBundlePage::shouldInsertText):
3158         (WTR::InjectedBundlePage::shouldDeleteRange):
3159         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3160         (WTR::InjectedBundlePage::shouldApplyStyle):
3161         (WTR::InjectedBundlePage::didBeginEditing):
3162         (WTR::InjectedBundlePage::didEndEditing):
3163         (WTR::InjectedBundlePage::didChange):
3164         (WTR::InjectedBundlePage::didChangeSelection):
3165         Don't do any work if we are not currently running a test.
3166
3167         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3168         * WebKitTestRunner/StringFunctions.h:
3169         (WTR::toCF):
3170         Add conversion function for WKURLRef -> CFURLRef
3171
3172         * WebKitTestRunner/TestController.cpp:
3173         (WTR::TestController::TestController):
3174         (WTR::TestController::initialize):
3175         (WTR::TestController::resetStateToConsistentValues):
3176         (WTR::TestController::runTest):
3177         (WTR::TestController::didFinishLoadForFrame):
3178         * WebKitTestRunner/TestController.h:
3179         (WTR::TestController::):
3180         * WebKitTestRunner/TestInvocation.cpp:
3181         (WTR::TestInvocation::invoke):
3182         * WebKitTestRunner/TestInvocation.h:
3183         Move resetting code to TestController.
3184
3185         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3186         * WebKitTestRunner/mac/TestControllerMac.mm:
3187         (WTR::TestController::runUntil):
3188         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3189         * WebKitTestRunner/win/TestControllerWin.cpp:
3190         (WTR::TestController::runUntil):
3191         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
3192         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3193         Move runUntil to TestController.
3194
3195 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3196
3197         Unreviewed.
3198
3199         Adding myself to the committers list.
3200
3201         * Scripts/webkitpy/common/config/committers.py:
3202
3203 2010-08-12  Hayato Ito  <hayato@chromium.org>
3204
3205         Reviewed by Tony Chang.
3206
3207         Merge pretty printers for gdb.
3208         https://bugs.webkit.org/show_bug.cgi?id=43850
3209
3210         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
3211         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
3212         webcore.py is left for backward compatibility.
3213
3214         * gdb/webcore.py:
3215         * gdb/webkit.py: Added.
3216         * gdb/wtf.py: Removed.
3217
3218 2010-08-11  Tony Chang  <tony@chromium.org>
3219
3220         Reviewed by David Levin.
3221
3222         [chromium] add google-chrome layout test result directories
3223         https://bugs.webkit.org/show_bug.cgi?id=43889
3224
3225         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3226         * Scripts/webkitpy/layout_tests/port/factory.py:
3227         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
3228         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3229
3230 2010-08-11  Kent Tamura  <tkent@chromium.org>
3231
3232         Reviewed by Dimitri Glazkov.
3233
3234         [DRT/Chromium] Disable accelerated compositing
3235         https://bugs.webkit.org/show_bug.cgi?id=43894
3236
3237         Disable accelerated compositing because DRT is not ready for
3238         it. This change fixes hundreds of test crashes on Windows and
3239         Linux.
3240
3241         * DumpRenderTree/chromium/TestShell.cpp:
3242         (TestShell::resetWebSettings):
3243
3244 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3245
3246         Unreviewed. Adding my Collabora personality to the list.
3247
3248         * Scripts/webkitpy/common/config/committers.py:
3249
3250 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
3251
3252         Adding myself as a reviewer.
3253
3254         * Scripts/webkitpy/common/config/committers.py:
3255
3256 2010-08-11  Daniel Bates  <dbates@rim.com>
3257
3258         Reviewed by Darin Adler.
3259
3260         Perl warnings when running commit-log-editor
3261         https://bugs.webkit.org/show_bug.cgi?id=43856
3262
3263         Fixes Perl warnings introduced by the patch for Bug #40548.
3264
3265         Perl doesn't have symbolic names for True/False. Instead, we
3266         should use boolean values. Moreover, the variable installedEditorApplication
3267         is not be used and should be renamed builtEditorApplication so that it
3268         uses the existing machinery to set the commit log editor application.
3269
3270         * Scripts/commit-log-editor:
3271
3272 2010-08-11  Adam Barth  <abarth@webkit.org>
3273
3274         Reviewed by Eric Seidel.
3275
3276         Trying waiting for httpd lock in the EWS
3277         https://bugs.webkit.org/show_bug.cgi?id=43833
3278
3279         If this works, we can probably run the tests on the mac-ews, which
3280         would be very exciting.  :)
3281
3282         * Scripts/webkitpy/tool/steps/runtests.py:
3283
3284 2010-08-11  Marcus Bulach  <bulach@chromium.org>
3285
3286         Reviewed by Eric Seidel.
3287
3288         Check in a script to list redundant test outputs.
3289         https://bugs.webkit.org/show_bug.cgi?id=37630
3290
3291         If e.g. platform/mac-leopard is missing an expected test output, we
3292         fall back on platform/mac.  This means it's possible to grow redundant
3293         test outputs, where we have the same expected data in both a platform
3294         directory and another platform it falls back on.
3295         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
3296
3297         * Scripts/deduplicate-tests: Added.
3298         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
3299         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
3300
3301 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3302
3303         Reviewed by Ariya Hidayat.
3304
3305         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
3306         https://bugs.webkit.org/show_bug.cgi?id=43853
3307
3308         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
3309         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
3310         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
3311         to slots at all.
3312
3313         * QtTestBrowser/launcherwindow.cpp:
3314         (LauncherWindow::createChrome):
3315         (LauncherWindow::animatedFlip):
3316         (LauncherWindow::animatedYFlip):
3317         * QtTestBrowser/launcherwindow.h:
3318
3319 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3320
3321         Reviewed by Simon Hausmann.
3322
3323         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
3324         https://bugs.webkit.org/show_bug.cgi?id=43851
3325
3326         All window options data (including the bool holding if the view is either QWebView or
3327         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
3328         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
3329         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
3330         getting broken.
3331
3332         Patch addresses this issue.
3333
3334         * QtTestBrowser/launcherwindow.cpp:
3335         (LauncherWindow::createChrome):
3336         (LauncherWindow::toggleWebView):
3337         (LauncherWindow::toggleAcceleratedCompositing):
3338
3339 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
3340
3341         Reviewed by Ariya Hidayat.
3342
3343         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
3344         https://bugs.webkit.org/show_bug.cgi?id=43831
3345
3346         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
3347
3348         * QtTestBrowser/webview.cpp:
3349         (WebViewGraphicsBased::WebViewGraphicsBased):
3350         (WebViewGraphicsBased::animatedYFlip):
3351
3352 2010-08-11  Darin Adler  <darin@apple.com>
3353
3354         Reviewed by John Sullivan.
3355
3356         Improved editor options for prepare-ChangeLog and commit-log-editor
3357         https://bugs.webkit.org/show_bug.cgi?id=40548
3358
3359         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
3360         values like "xed --launch --wait" work properly.
3361
3362         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
3363         use a command line tool with the $openChangeLogs feature.
3364
3365 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
3366
3367         Reviewed by Pavel Feldman.
3368
3369         Web Inspector: remove InjectDispatch.js
3370         https://bugs.webkit.org/show_bug.cgi?id=43835
3371
3372         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3373         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3374
3375 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
3376
3377         Reviewed by Eric Seidel.
3378
3379         webkit-patch should refuse to run under Win32 Python
3380         https://bugs.webkit.org/show_bug.cgi?id=40962
3381
3382         Given that there are lots of places in webkit-patch's code that
3383         assume unix-style filenames (forward slashes), webkit-patch fails
3384         with weird file-not-found errors when run under a native windows
3385         Python. It would be nice if we just trapped this and errored out
3386         at the beginning, rather than producing unpredictable errors.
3387
3388         * Scripts/webkit-patch:
3389
3390 2010-08-10  Kent Tamura  <tkent@chromium.org>
3391
3392         Unreviewed, build fix.
3393         
3394         Chromium build fix for r65107.
3395
3396         * DumpRenderTree/chromium/LayoutTestController.cpp:
3397         (LayoutTestController::suspendAnimations):
3398         (LayoutTestController::resumeAnimations):
3399
3400 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
3401
3402         Reviewed by Xan Lopez.
3403
3404         [GTK] http/tests/media/video-cookie.html fails
3405         https://bugs.webkit.org/show_bug.cgi?id=42240
3406
3407         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3408         (LayoutTestController::setAlwaysAcceptCookies): create the
3409         SoupCookieJar if it does not exist. Otherwise the accept policy
3410         won't be set.
3411
3412 2010-08-10  Chris Marrin  <cmarrin@apple.com>
3413
3414         Reviewed by Oliver Hunt.
3415
3416         Add suspendAnimations/resumeAnimation API to DRT
3417         https://bugs.webkit.org/show_bug.cgi?id=43733
3418         
3419         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
3420         Calls functions with the same names on AnimationController for the 
3421         mainFrame.
3422
3423         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3424         * DumpRenderTree/LayoutTestController.cpp:
3425         (suspendAnimationsCallback):
3426         (resumeAnimationsCallback):
3427         (LayoutTestController::staticFunctions):
3428         * DumpRenderTree/LayoutTestController.h:
3429         * DumpRenderTree/chromium/LayoutTestController.cpp:
3430         (LayoutTestController::LayoutTestController):
3431         (LayoutTestController::suspendAnimations):
3432         (LayoutTestController::resumeAnimations):
3433         * DumpRenderTree/chromium/LayoutTestController.h:
3434         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3435         (LayoutTestController::suspendAnimations):
3436         (LayoutTestController::resumeAnimations):
3437         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3438         (LayoutTestController::suspendAnimations):
3439         (LayoutTestController::resumeAnimations):
3440         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3441         (LayoutTestController::suspendAnimations):
3442         (LayoutTestController::resumeAnimations):
3443         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3444         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3445         (LayoutTestController::suspendAnimations):
3446         (LayoutTestController::resumeAnimations):
3447         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3448         (LayoutTestController::suspendAnimations):
3449         (LayoutTestController::resumeAnimations):
3450
3451 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3452
3453         Reviewed by Ojan Vafai.
3454
3455         [Chromium/DRT] Enable saving layout test results.
3456         https://bugs.webkit.org/show_bug.cgi?id=43796
3457
3458         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
3459             parameters to the new-run-webkit-tests, including the name
3460             of the test results server.
3461
3462 2010-08-10  Jian Li  <jianli@chromium.org>
3463
3464         More chromium build fix.
3465
3466         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3467         (MockSpellCheck::spellCheckWord):
3468         (MockSpellCheck::initializeIfNeeded):
3469         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3470         (NotificationPresenter::grantPermission):
3471         (NotificationPresenter::show):
3472         (NotificationPresenter::checkPermission):
3473
3474 2010-08-10  Jian Li  <jianli@chromium.org>
3475
3476         Chromium build fix.
3477
3478         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3479         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3480
3481 2010-08-10  Victor Wang  <victorw@chromium.org>
3482
3483         Reviewed by Ojan Vafai.
3484
3485         Update test results server merge logic so the aggregated
3486         results and times are updated for tests that are
3487         in aggragated json but not in incremental json.
3488
3489         Also update unittest to test this case.
3490
3491         https://bugs.webkit.org/show_bug.cgi?id=43769
3492
3493         * TestResultServer/model/jsonresults.py:
3494         * TestResultServer/model/jsonresults_unittest.py:
3495
3496 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3497
3498         Reviewed by Ariya Hidayat.
3499
3500         [Qt] QtTestBrowser: proper set scene rect
3501
3502         When resizesToContents is ON scene's rect is set to the boundary of
3503         the mainFrame. However, navigating to other web page should keep resizing
3504         scene's rect according to the new document loaded. Patch addresses this issue.
3505
3506         Now resizesToContents and scrolling properly work on QtTestBrowser.
3507
3508         * QtTestBrowser/webview.cpp:
3509         (WebViewGraphicsBased::setPage):
3510         (WebViewGraphicsBased::contentsSizeChanged):
3511         (WebViewGraphicsBased::setResizesToContents):
3512         (WebViewGraphicsBased::resizeEvent):
3513         * QtTestBrowser/webview.h:
3514
3515 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3516
3517         Reviewed by Ariya Hidayat.
3518
3519         [Qt] QtTestBrowser: Clean up LauncherWindow code.
3520
3521         * QtTestBrowser/launcherwindow.cpp:
3522         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
3523         (LauncherWindow::init): Fixed comments.
3524         (LauncherWindow::applyPrefs): Move the method around.
3525         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
3526
3527 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3528
3529         Reviewed by Ariya Hidayat.
3530
3531         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
3532
3533         It gets control+0 the same visual effect as control++ or control-.
3534
3535         * QtTestBrowser/launcherwindow.cpp:
3536         (LauncherWindow::toggleZoomTextOnly):
3537
3538 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3539
3540         Reviewed by Ariya Hidayat.
3541
3542         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
3543
3544         Not all instances of LauncherWindow need its own m_zoomLevel.
3545
3546         * QtTestBrowser/launcherwindow.cpp:
3547         * QtTestBrowser/launcherwindow.h:
3548
3549 2010-08-09  Sam Weinig  <sam@webkit.org>
3550
3551         Reviewed by Geoffrey Garen.
3552
3553         Add zoom support for injected bundle
3554         https://bugs.webkit.org/show_bug.cgi?id=43759
3555
3556         Use zoom factor SPI to implement zoom related eventSender functions.
3557
3558         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3559         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3560         (WTR::EventSendingController::textZoomIn):
3561         (WTR::EventSendingController::textZoomOut):
3562         (WTR::EventSendingController::zoomPageIn):
3563         (WTR::EventSendingController::zoomPageOut):
3564         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3565         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3566         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
3567
3568 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
3569
3570         Speculative chromium build fix III.
3571
3572         * DumpRenderTree/chromium/MockSpellCheck.h:
3573         * DumpRenderTree/chromium/NotificationPresenter.h:
3574         * DumpRenderTree/chromium/WebViewHost.h:
3575         (WebViewHost::addClearHeader):
3576         (WebViewHost::clearHeaders):
3577
3578 2010-08-09  Ojan Vafai  <ojan@chromium.org>
3579
3580         Reviewed by Tony Chang.
3581
3582         increase the number of test results that we save
3583         https://bugs.webkit.org/show_bug.cgi?id=43763
3584
3585         Now that we do incremental uploads, we can increase the number of
3586         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
3587
3588         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3589
3590 2010-08-09  Evan Martin  <evan@chromium.org>
3591
3592         Reviewed by Tony Chang.
3593
3594         [chromium] DRT error print statement incorrectly tries to print a FILE*
3595         https://bugs.webkit.org/show_bug.cgi?id=43747
3596
3597         * DumpRenderTree/chromium/ImageDiff.cpp:
3598         (writeFile): pass the correct pointer.
3599
3600 2010-08-09  Victor Wang  <victorw@chromium.org>
3601
3602         Reviewed by Ojan Vafai.
3603
3604         Upload incremental test results json to server by default.
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=43743
3607
3608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3609
3610 2010-08-09  Eric Seidel  <eric@webkit.org>
3611
3612         Reviewed by Adam Barth.
3613
3614         EWS bots wait 2 minutes between patches
3615         https://bugs.webkit.org/show_bug.cgi?id=43731
3616
3617         * Scripts/webkitpy/tool/bot/queueengine.py:
3618          - Don't sleep after failures.  This was a hold-over from
3619            an earlier design.
3620         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3621          - EWS bots were not properly reporting true/false from process_work_item.
3622            They were always returning None, thus false, thus always logging
3623            as a failure and sleeping 2 minutes after each patch.
3624
3625 2010-08-09  Sam Weinig  <sam@webkit.org>
3626
3627         Reviewed by Anders Carlsson.
3628
3629         Stub out EventSender for WebKitTestRunner
3630         https://bugs.webkit.org/show_bug.cgi?id=43703
3631
3632         * WebKitTestRunner/DerivedSources.make:
3633         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3634         Add ability to pass javascript arguments to the wrapped object.
3635
3636         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
3637         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
3638         (WTR::EventSendingController::create):
3639         (WTR::EventSendingController::EventSendingController):
3640         (WTR::EventSendingController::~EventSendingController):
3641         (WTR::EventSendingController::wrapperClass):
3642         (WTR::setExceptionForString):
3643         (WTR::EventSendingController::mouseDown):
3644         (WTR::EventSendingController::mouseUp):
3645         (WTR::EventSendingController::mouseMoveTo):
3646         (WTR::EventSendingController::keyDown):
3647         (WTR::EventSendingController::contextClick):
3648         (WTR::EventSendingController::leapForward):
3649         (WTR::EventSendingController::textZoomIn):
3650         (WTR::EventSendingController::textZoomOut):
3651         (WTR::EventSendingController::zoomPageIn):
3652         (WTR::EventSendingController::zoomPageOut):
3653         (WTR::EventSendingController::makeWindowObject):
3654         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
3655         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3656         (WTR::InjectedBundle::reset):
3657         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3658         (WTR::InjectedBundle::eventSendingController):
3659         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3660         (WTR::InjectedBundlePage::didClearWindowForFrame):
3661         Add stubbed out EventSenderController.
3662