c73c4e54b1911849a55fdf7b478b5bfc69eae8ca
[WebKit.git] / WebKitTools / ChangeLog
1 2010-07-11  Daniel Bates  <dbates@rim.com>
2
3         Reviewed by David Kilzer.
4
5         Enable executable support for svn-apply and svn-unapply
6         https://bugs.webkit.org/show_bug.cgi?id=39409
7
8         Connect up the Git and SVN executable bit support in parseDiff() so that
9         executable bit changes are propagated via the returned diff hash to the
10         patch function in svn-apply and svn-unapply.
11
12         * Scripts/VCSUtils.pm:
13           - Modified parseDiff() to call parseSvnDiffProperties when
14             it finds the start of an SVN property change diff.
15           - Removed FIXME comment above parseSvnDiffProperties() since
16             it is now being used by parseDiff().
17           - Export method scmToggleExecutableBit() now that we added the
18             executableBitDelta hash key. (This should have been exported
19             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
20         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
21           - Updated results for:
22             "rename (with executable bit change)"
23               - Test value of executableBitDelta (now that we have support).
24             "SVN: binary file (isBinary true)"
25               - Remove the property change diff from svnConvertedText. We plan
26                 to remove svnConvertedText in the future. So, we decided
27                 against adding such support to any new code, such as the
28                 property parsing routines. Therefore, we do not keep SVN
29                 converted text for property change diffs.
30           - Added unit tests:
31             "SVN: file change diff with property change diff"
32             "SVN: file change diff, followed by property change diff on different file"
33             "SVN: property diff, followed by file change diff"
34             "SVN: copied file with property change"
35             "SVN: two consecutive property diffs"
36             "SVN: binary file with executable bit change"
37             "SVN: binary file followed by property change on different file"
38             "SVN: binary file followed by file change on different file"
39             "SVN: file change diff with property change, followed by property change diff"
40             "SVN: file change diff with property change, followed by file change diff"
41
42 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
43
44         Reviewed by Dan Bernstein.
45
46         Implement waitUntilDone and notifyDone for WebKitTestRunner
47         https://bugs.webkit.org/show_bug.cgi?id=42049
48
49         With this fix, most of the DOM tests pass.
50         
51         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
52         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
53         a great way to do it in the future case where we may get multiple
54         pages - we really need a way to send it over from the ui process.
55         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
56         (WTR::InjectedBundle::page): A way to get the main page.
57         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
58         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
59         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
60         are loading.
61         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
62         called by the layout test controller. Also, cancel any pending watchdogs.
63         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
64         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
65         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
66         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
67         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
68         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
69         to false.
70         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
71         the watchdog.
72         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
73         (WTR::LayoutTestController::setWaitToDump): Set the flag.
74         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
75         where waitUntilDone times out.
76         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
77         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
78         (WTR::notifyDoneCallback): JS glue for notifyDone.
79         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
80         to the layoutController.
81         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
82         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
83
84 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
85
86         Rubber-stamped by Dan Bernstein.
87
88         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
89         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
90         slow down the tests).
91
92         * Scripts/webkitpy/common/system/executive.py:
93
94 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
95
96         Reviewed by Kenneth Rohde Christiansen.
97
98         [Qt] Mac build fix
99         https://bugs.webkit.org/show_bug.cgi?id=41967
100
101         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
102
103         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
104
105 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
106
107         Reviewed by Antonio Gomes.
108
109         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
110         https://bugs.webkit.org/show_bug.cgi?id=41966
111
112         * MiniBrowser/qt/BrowserWindow.cpp:
113         (BrowserWindow::BrowserWindow):
114
115 2010-07-09  Leon Clarke  <leonclarke@google.com>
116
117         Reviewed by Adam Barth.
118
119         add support for link prefetching
120         https://bugs.webkit.org/show_bug.cgi?id=3652
121
122         * Scripts/build-webkit:
123
124 2010-07-09  Ojan Vafai  <ojan@chromium.org>
125
126         Reviewed by Adam Barth.
127
128         r63004 broke some python tests
129         https://bugs.webkit.org/show_bug.cgi?id=42007
130
131         AbstractStep now checks options.no_squash and options.squash, so
132         they needed to have real values. Mock would return an object for those,
133         which would then act as if the values were True.
134
135         * Scripts/webkitpy/tool/commands/commandtest.py:
136         * Scripts/webkitpy/tool/commands/download_unittest.py:
137         * Scripts/webkitpy/tool/commands/stepsequence.py:
138         * Scripts/webkitpy/tool/commands/upload_unittest.py:
139         * Scripts/webkitpy/tool/mocktool.py:
140         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
141         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
142         * Scripts/webkitpy/tool/steps/steps_unittest.py:
143         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
144         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
145
146 2010-07-09  Ojan Vafai  <ojan@chromium.org>
147
148         Reviewed by Adam Barth.
149
150         --squash should go away and become the default
151         https://bugs.webkit.org/show_bug.cgi?id=39624
152
153         If there are local commits and working copy changes, then prompt the user
154         whether to continue. Setting git config webkit-patch.commit_should_always_squash
155         true bypasses the prompt.
156
157         --git-commit=HEAD.. operates on working copy changes only.
158         --git-commit=committish operates on a range of commits as a single commit.
159             e.g. --git-commit=HEAD only operates on the HEAD commit.
160             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
161
162         --no-squash and --squash are left in with descriptive error messages if used.
163
164         * Scripts/check-webkit-style:
165         * Scripts/webkitpy/common/checkout/api.py:
166         * Scripts/webkitpy/common/checkout/api_unittest.py:
167         * Scripts/webkitpy/common/checkout/scm.py:
168         * Scripts/webkitpy/common/checkout/scm_unittest.py:
169         * Scripts/webkitpy/common/net/rietveld.py:
170         * Scripts/webkitpy/common/system/user.py:
171         * Scripts/webkitpy/style/optparser.py:
172         * Scripts/webkitpy/style_references.py:
173         * Scripts/webkitpy/tool/commands/download.py:
174         * Scripts/webkitpy/tool/commands/upload.py:
175         * Scripts/webkitpy/tool/mocktool.py:
176         * Scripts/webkitpy/tool/steps/abstractstep.py:
177         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
178         * Scripts/webkitpy/tool/steps/checkstyle.py:
179         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
180         * Scripts/webkitpy/tool/steps/commit.py:
181         * Scripts/webkitpy/tool/steps/options.py:
182         * Scripts/webkitpy/tool/steps/preparechangelog.py:
183         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
184         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
185         * Scripts/webkitpy/tool/steps/validatereviewer.py:
186
187 2010-07-09  Mark Rowe  <mrowe@apple.com>
188
189         Add two new Windows test build slaves.
190
191         * BuildSlaveSupport/build.webkit.org-config/config.json:
192
193 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
194
195         Reviewed by David Levin.
196
197         rebaseline_chromium_webkit_tests missing --use_drt option on linux
198         https://bugs.webkit.org/show_bug.cgi?id=41985
199
200         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
201         so that it works on linux. This is essentially a "compile-fix" for the
202         script.
203
204         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
205
206 2010-07-09  Nico Weber  <thakis@chromium.org>
207
208         Unreviewed. Adding myself as committer.
209
210         * Scripts/webkitpy/common/config/committers.py:
211
212 2010-07-09  David Kilzer  <ddkilzer@apple.com>
213
214         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
215
216         This reverts commit r62692.
217
218         * Scripts/commit-log-editor:
219
220 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
221
222         Reviewed by Ojan Vafai.
223
224         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
225         https://bugs.webkit.org/show_bug.cgi?id=38693
226
227         Introduced a new base class JSONResultsGeneratorBase that doesn't
228         have any dependency on layout_tests packages.
229         Turned JSONResultsGenerator into a wrapper class of the base class
230         so that the old code can work with it during the cleanup.
231
232         Added json_results_generator_unittest.py.
233
234         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
235         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
236         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
237
238 2010-07-09  Abhishek Arya  <inferno@chromium.org>
239
240         Unreviewed.
241
242         Marking myself as a committer.
243
244         * Scripts/webkitpy/common/config/committers.py:
245
246 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
247
248         Reviewed by Antti Koivisto.
249
250         Implement MiniBrowser for Qt.
251         https://bugs.webkit.org/show_bug.cgi?id=40233
252
253         * MiniBrowser/qt/BrowserWindow.cpp: Added.
254         (createNewPage):
255         (BrowserView::BrowserView):
256         (BrowserView::resizeEvent):
257         (BrowserView::load):
258         (BrowserView::view):
259         (BrowserWindow::BrowserWindow):
260         (BrowserWindow::load):
261         (BrowserWindow::changeLocation):
262         (BrowserWindow::~BrowserWindow):
263         * MiniBrowser/qt/BrowserWindow.h: Added.
264         (BrowserView::~BrowserView):
265         * MiniBrowser/qt/MiniBrowser.pro: Added.
266         * MiniBrowser/qt/main.cpp: Added.
267         (main):
268
269 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
270
271         Reviewed by Simon Hausmann.
272
273         Introduce the Qt autotest launcher.
274
275         Qt autotests should be executed more frequently, ideally by the Qt
276         build bot. This is the first step to provide the tests more accessible.
277
278         [Qt] It should be easier to run all Qt's autotests.
279         https://bugs.webkit.org/show_bug.cgi?id=31625
280
281         * Scripts/run-qtwebkit-tests: Added.
282
283 2010-07-09  Adam Barth  <abarth@webkit.org>
284
285         Reviewed by Eric Seidel.
286
287         commit-queue should merge to TOT when checkout needs update
288         https://bugs.webkit.org/show_bug.cgi?id=41944
289
290         There are a bunch of different designs that are possible here.  This
291         one merges to top of tree by cleaning out the working copy and
292         re-applying the patch.  Once you decide to merge that way, you need to
293         decide who's going to retry.  In this patch, we retry in the child
294         process instead of plumbing the failure reason to the master process.
295
296         This patch is difficult to test end-to-end, but hopefully it will work.
297         :)
298
299         * Scripts/webkitpy/tool/commands/queues.py:
300         * Scripts/webkitpy/tool/commands/stepsequence.py:
301         * Scripts/webkitpy/tool/multicommandtool.py:
302         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
303
304 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
305
306         Reviewed by Darin Adler.
307
308         Add a script to check for unnecessary includes in header files.
309         https://bugs.webkit.org/show_bug.cgi?id=41894
310
311         * Scripts/check-header-includes: Added.
312
313 2010-07-09  Adam Barth  <abarth@webkit.org>
314
315         Reviewed by Eric Seidel.
316
317         Add --html5-treebuilder option to run-webkit-tests
318         https://bugs.webkit.org/show_bug.cgi?id=41922
319
320         We're down to one or two regressions in the HTML5lib test suite.  It's
321         getting to be time to look at fixing LayoutTests.
322
323         * Scripts/old-run-webkit-tests:
324
325 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
326
327         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
328         in the drawing model never getting set on Tiger.
329
330         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
331         (NPP_New):
332
333 2010-07-08  Aaron Boodman  <aa@chromium.org>
334
335         Reviewed by Timothy Hatcher.
336
337         Add the ability for user scripts and user styles to affect just the top frame.
338
339         https://bugs.webkit.org/show_bug.cgi?id=41529
340
341         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
342         * DumpRenderTree/LayoutTestController.cpp: Ditto.
343         (addUserScriptCallback):
344         (addUserStyleSheetCallback):
345         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
346         (LayoutTestController::addUserScript):
347         (LayoutTestController::addUserStyleSheet):
348         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
349         (LayoutTestController::addUserScript):
350         (LayoutTestController::addUserStyleSheet):
351         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
352         (LayoutTestController::addUserScript):
353         (LayoutTestController::addUserStyleSheet):
354         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
355         (LayoutTestController::addUserScript):
356         (LayoutTestController::addUserStyleSheet):
357         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
358         (LayoutTestController::addUserScript):
359         (LayoutTestController::addUserStyleSheet):
360
361 2010-07-08  Adele Peterson  <adele@apple.com>
362
363         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
364
365         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
366         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
367
368         Log when the missing plugin button is pressed.
369
370         * DumpRenderTree/mac/UIDelegate.mm:
371         (-[UIDelegate webView:didPressMissingPluginButton:]):
372         * DumpRenderTree/win/UIDelegate.cpp:
373         (UIDelegate::QueryInterface):
374         (UIDelegate::createWebViewWithRequest):
375         (UIDelegate::drawBackground):
376         (UIDelegate::decidePolicyForGeolocationRequest):
377         (UIDelegate::didPressMissingPluginButton):
378         * DumpRenderTree/win/UIDelegate.h:
379
380 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
381
382         Fix the Tiger build.
383
384         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
385         (NPP_New):
386
387 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
388
389         Fix windows build.
390
391         #ifdef code for Mac.
392
393         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
394         (NPP_New):
395
396 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
397
398         Reviewed by Anders Carlsson.
399
400         Allow the TestPlugin to use Core Animation rendering for testing
401         https://bugs.webkit.org/show_bug.cgi?id=41872
402         
403         Add the ability for the TestPlugin to use the CoreAnimation rendering model
404         when available, based on the "drawingmodel" attribute of the embed tag:
405             drawingmodel="coreanimation"
406
407         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
408         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
409         when building on Tiger. Add a void* coreAnimationLayer member.
410         
411         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
412         (createCoreAnimationLayer): Obj-C method to create the CALayer.
413         
414         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
415         (NPP_New): Look for the drawingmodel attribute to decide which drawing
416         model to use.
417         (NPP_Destroy): Release the CALayer if we have one.
418         (NPP_GetValue): Return the retained CALayer.
419
420 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
421
422         Reviewed by Xan Lopez.
423
424         [GTK] Support pixel tests
425         https://bugs.webkit.org/show_bug.cgi?id=31518
426
427         Convert this file from CRLF to NL line endings. It will soon
428         be used on more than just the WinCairo platform.
429
430         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
431         (writeFunction):
432         (printPNG):
433         (computeMD5HashStringForBitmapContext):
434         (dumpBitmap):
435
436 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
437
438         Reviewed by Darin Adler.
439
440         Enable Data Execution Prevention for our test harnesses on Windows
441         https://bugs.webkit.org/show_bug.cgi?id=41882
442
443         * DumpRenderTree/win/DumpRenderTree.vcproj:
444         * DumpRenderTree/win/ImageDiff.vcproj:
445         * WebKitAPITest/WebKitAPITest.vcproj:
446         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
447
448 2010-07-07  Robert Hogan  <robert@webkit.org>
449
450         Reviewed by Kenneth Rohde Christiansen.
451
452         [Qt] Add DRT support for pageProperty etc.
453
454         https://bugs.webkit.org/show_bug.cgi?id=41584
455
456         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
457         (LayoutTestController::isPageBoxVisible):
458         (LayoutTestController::pageSizeAndMarginsInPixels):
459         (LayoutTestController::pageProperty):
460         (LayoutTestController::addUserStyleSheet):
461         * DumpRenderTree/qt/LayoutTestControllerQt.h:
462
463 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
464
465         Reviewed by Xan Lopez.
466
467         Remove a warnings from the ImageDiff build by using the proper
468         printf format string for the gsize data type.
469
470         * DumpRenderTree/gtk/ImageDiff.cpp:
471         (printImage): Use the proper printf format string for the gsize data type.
472
473 2010-07-08  Alice Liu  <alice.liu@apple.com>
474
475         Reviewed by Sam Weinig.
476
477         https://bugs.webkit.org/show_bug.cgi?id=41653
478         Add new WebKitTestRunner project for Windows
479
480         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
481         Similar to how it's done in DumpRenderTree, define max and min early
482         on so that they don't get replaced by a macro requiring 2 arguments.
483
484         * WebKitTestRunner/win: Added.
485         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
486         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
487         * WebKitTestRunner/win/main.cpp: Added.
488         (main): Implemented
489
490         Added these files with stubbed out functions:
491         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
492         (WTR::PlatformWebView::PlatformWebView):
493         (WTR::PlatformWebView::~PlatformWebView):
494         (WTR::PlatformWebView::page):
495         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
496         (WTR::TestController::initializeInjectedBundlePath):
497         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
498         (WTR::TestInvocation::runUntil):
499
500 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
501
502         Reviewed by Gustavo Noronha Silva.
503
504         [GTK] Implement ImageDiff and add it to the build system
505         https://bugs.webkit.org/show_bug.cgi?id=41779
506
507         Add the initial implementation of the ImageDiff tool for the GTK+
508         port. This is an essential tool for doing pixel tests. The implementation
509         is based on the Mac and Chromium ports.
510
511         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
512         (readPixbufFromStdin): Added.
513         (differenceImageFromDifferenceBuffer): Ditto.
514         (calculateDifference): Ditto.
515         (printImage): Ditto.
516         (printImageDifferences): Ditto.
517         (main): Ditto.
518         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
519
520 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
521
522         Unreviewed. Adding myself as a committer.
523
524         * Scripts/webkitpy/common/config/committers.py:
525
526 2010-07-08  Adam Roben  <aroben@apple.com>
527
528         Make Windows stop running tests from platform/mac
529
530         r62742 made a change (at my suggestion!) that caused us to start
531         looking for tests in platform/mac, rather than just looking for
532         expected results in platform/mac. This patch just undoes that part of
533         r62742.
534
535         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
536         tests from platform/mac, but shouldn't
537
538         Reviewed by Antti Koivisto and Anders Carlsson.
539
540         * Scripts/old-run-webkit-tests:
541         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
542         so we won't look in those directories for tests to run.
543         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
544         platform/mac-snowleopard and platform/mac for expected results.
545
546 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
547
548         Unreviewed. Adding myself as a reviewer.
549
550         * Scripts/webkitpy/common/config/committers.py:
551
552 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
553
554         Update my e-mail in committers.py
555
556         * Scripts/webkitpy/common/config/committers.py:
557
558 2010-07-07  Daniel Bates  <dbates@rim.com>
559
560         Reviewed by Dumitru Daniliuc.
561
562         VCSUtils.pm complains about uninitialized value $newLine
563         https://bugs.webkit.org/show_bug.cgi?id=41333
564
565         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
566         an array when fixing a change log entry that overlaps with an earlier
567         entry. In particular, when a patch contains a change log entry inserted
568         earlier in the change log file, but after an entry with the same author
569         and date.
570
571         * Scripts/VCSUtils.pm:
572             - Added for-loop constraint to fixChangeLogPatch() so that it does not
573               read off the end of the @overlappingLines array.
574         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
575
576 2010-07-07  Anders Carlsson  <andersca@apple.com>
577
578         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
579
580         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
581         (NPP_New):
582
583 2010-07-07  Kent Tamura  <tkent@chromium.org>
584
585         Reviewed by Adam Barth.
586
587         [DRT/Chromium] Support for indeterminate checkbox
588         https://bugs.webkit.org/show_bug.cgi?id=41747
589
590         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
591
592         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
593         (WebThemeControlDRT::draw):
594         * DumpRenderTree/chromium/WebThemeControlDRT.h:
595         (WebThemeControlDRT::):
596         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
597         (WebThemeEngineDRT::paintButton):
598
599 2010-07-07  Sam Weinig  <sam@webkit.org>
600
601         Reviewed by Mark Rowe.
602
603         Clean up MiniBrowser Xcode project.
604
605         - Use xcconfig files.
606         - Rename plists to canonical Info.plist
607         - Remove localizations.
608
609         * MiniBrowser/Configurations: Added.
610         * MiniBrowser/Configurations/Base.xcconfig: Added.
611         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
612         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
613         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
614         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
615         * MiniBrowser/WebBundle-Info.plist: Removed.
616         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
617         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
618         * MiniBrowser/mac/BrowserWindow.xib: Added.
619         * MiniBrowser/mac/BrowserWindowController.m:
620         (-[BrowserWindowController initWithPageNamespace:]):
621         * MiniBrowser/mac/English.lproj: Removed.
622         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
623         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
624         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
625         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
626         * MiniBrowser/mac/MainMenu.xib: Added.
627         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
628         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
629
630 2010-07-07  Kent Tamura  <tkent@chromium.org>
631
632         Reviewed by Dimitri Glazkov.
633
634         [DRT/Chromium] Fix two regressions
635         https://bugs.webkit.org/show_bug.cgi?id=41745
636
637         * DumpRenderTree/chromium/WebViewHost.cpp:
638         (WebViewHost::paintInvalidatedRegion):
639          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
640          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
641          though test_shell does it twice. Probably DRT needs it because
642          DRT delays painting as possible.
643
644 2010-07-07  Anders Carlsson  <andersca@apple.com>
645
646         Try to fix build.
647
648         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
649         (webkit_test_plugin_destroy_stream):
650
651 2010-07-07  Anders Carlsson  <andersca@apple.com>
652
653         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
654
655         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
656         (webkit_test_plugin_new_stream):
657         (webkit_test_plugin_destroy_stream):
658         (webkit_test_plugin_write_ready):
659         (webkit_test_plugin_write):
660
661 2010-07-07  Sam Weinig  <sam@webkit.org>
662
663         Reviewed by Mark Rowe.
664
665         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
666
667         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
668
669 2010-07-07  Anders Carlsson  <andersca@apple.com>
670
671         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
672
673         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
674         (NPP_New):
675         (NPP_HandleEvent):
676
677 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
678
679         Reviewed by Adam Roben.
680
681         Need to have a way to specify different results for Windows XP and 7
682         https://bugs.webkit.org/show_bug.cgi?id=41776
683         
684         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
685         subdirectories, so we can have different results for tests on Windows XP, Windows
686         Vista, and Windows 7.
687
688         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
689         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
690         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
691
692         This matches the behavior of the mac.
693
694         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
695             or Vista, try looking in other win-* subdirectories before win.
696         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
697             we are running.
698
699 2010-07-07  Kent Tamura  <tkent@chromium.org>
700
701         Reviewed by Dimitri Glazkov.
702
703         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
704         https://bugs.webkit.org/show_bug.cgi?id=41753
705
706         The original code of the following functions in
707         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
708         ASSERT_NOT_REACHED(). The program shouldn't stop at these
709         functions.
710
711         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
712         (DRTDevToolsClient::activateWindow):
713         (DRTDevToolsClient::closeWindow):
714         (DRTDevToolsClient::dockWindow):
715         (DRTDevToolsClient::undockWindow):
716
717 2010-07-07  Anders Carlsson  <andersca@apple.com>
718
719         Reviewed by Sam Weinig.
720
721         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
722         https://bugs.webkit.org/show_bug.cgi?id=41821
723
724         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
725         (pluginGetProperty):
726         (pluginSetProperty):
727         (pluginAllocate):
728         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
729         Add and initialize the returnNegativeOneFromWrite property.
730
731         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
732         (NPP_NewStream):
733         Set the stream type to NP_NORMAL so we'll get write callbacks.
734
735         (NPP_DestroyStream):
736         Treat the onstreamdestroy attribute as a function name and not a string.
737
738         (NPP_WriteReady):
739         Have this return a nonzero value.
740
741         (NPP_Write):
742         If returnNegativeOneFromWrite is true return -1.
743
744 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
745
746         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
747         latest version is selected by default, and allows the version to be specified.
748
749         * wx/build/settings.py:
750
751 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
752
753         Reviewed by Darin Adler.
754
755         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
756         https://bugs.webkit.org/show_bug.cgi?id=41810
757
758         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
759         (AccessibilityUIElement::selectedTextRange):
760
761 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
762
763         Unreviewed.
764
765         Build fix after r62700.
766
767         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
768         source file locations.
769
770 2010-07-07  Ojan Vafai  <ojan@chromium.org>
771
772         Reviewed by David Levin.
773
774         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
775         https://bugs.webkit.org/show_bug.cgi?id=41814
776
777         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
778         * Scripts/old-run-webkit-tests:
779
780 2010-07-07  Ojan Vafai  <ojan@chromium.org>
781
782         Reviewed by David Levin.
783
784         add --exit-after-n-crashes to run-webkit-tests
785         https://bugs.webkit.org/show_bug.cgi?id=41811
786
787         Change the bots at build.webkit.org to use --exit-after-n-crashes
788         instead of --exit-after-n-failures since we want to be able to have
789         more than 20 failures on those bots, but more than 20 crashes means
790         something should be rolled out.
791
792         * Scripts/old-run-webkit-tests:
793         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
794
795 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
796
797         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
798         TestNetscapePlugin project, because this was removed from the tree.
799
800         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
801
802 2010-07-07  Anders Carlsson  <andersca@apple.com>
803
804         Reviewed by Simon Fraser.
805
806         Unify Mac and Windows TestNetscapePlugin main.cpp files
807         https://bugs.webkit.org/show_bug.cgi?id=41798
808         
809         * DumpRenderTree/DumpRenderTree.sln:
810         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
811         (strcasecmp):
812         (NP_Initialize):
813         (NP_GetEntryPoints):
814         (NP_Shutdown):
815         (NPP_New):
816         (NPP_Destroy):
817         (NPP_HandleEvent):
818         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
819         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
820
821 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
822
823         [wx] Build fix. pageProperty needs to return a value.
824
825         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
826         (LayoutTestController::pageProperty):
827
828 2010-07-07  David Kilzer  <ddkilzer@apple.com>
829
830         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
831
832         Reviewed by Anders Carlsson.
833
834         For both svn and git, commit-log-editor is invoked from the root
835         of the working directory.  Unlike svn, git returns a list of
836         changed files that are relative to the directory where the
837         command was invoked.  This caused the ChangeLog file in the root
838         directory to be read instead of the ChangeLog in the current
839         directory.
840
841         The fix is to use $ENV{PWD} as the base directory when fixing
842         the path to the ChangeLog files.  With svn, this has no net
843         effect since $ENV{PWD} is the root of the working directory and
844         the ChangeLog paths are already relative to that directory.
845         With git, $ENV{PWD} is the directory that the commit was invoked
846         from, which fixes the ChangeLog paths so that the correct files
847         are read when creating the commit log entry.
848
849         Note that the call to makeFilePathRelative() was supposed to
850         address this issue, but it doesn't because (a) it does nothing
851         with svn working directories by design, and (b) it does nothing
852         with git working directories because it's invoked when the
853         current directory is the root of the working directory, thus
854         giving no relative path.
855
856         * Scripts/commit-log-editor: Removed call to
857         makeFilePathRelative() since since it does nothing.  Moved code
858         to fix up $changeLog path so that it's fixed before trying to
859         open the file, and use $ENV{PWD} as the base path.  Also use
860         canonicalizePath() to clean up paths with "../" in them.
861
862 2010-07-07  Anders Carlsson  <andersca@apple.com>
863
864         Another attempt at fixing the Qt build.
865
866         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
867
868 2010-07-07  Anders Carlsson  <andersca@apple.com>
869
870         Try to fix Qt build.
871
872         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
873
874 2010-07-07  Anders Carlsson  <andersca@apple.com>
875
876         Reviewed by Simon Fraser.
877
878         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
879         https://bugs.webkit.org/show_bug.cgi?id=41781
880
881         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
882         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
883         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
884         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
885         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
886         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
887         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
888         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
889         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
890         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
891         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
892         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
893         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
894
895 2010-07-07  Andras Becsi  <abecsi@webkit.org>
896
897         Unreviewed trivial fix.
898
899         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
900         which was checked in accidentally in r62635.
901
902         * Scripts/webkitpy/layout_tests/port/webkit.py:
903
904 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
905
906         Reviewed by Eric Seidel.
907
908         Pass port specific environment to server process.
909         https://bugs.webkit.org/show_bug.cgi?id=41593
910
911         * Scripts/webkitpy/layout_tests/port/qt.py:
912         * Scripts/webkitpy/layout_tests/port/webkit.py:
913
914 2010-07-06  Kent Tamura  <tkent@chromium.org>
915
916         Reviewed by Shinichiro Hamaji.
917
918         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
919         https://bugs.webkit.org/show_bug.cgi?id=41644
920
921         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
922         tolerance. We don't need tolerance for rebaseline.
923
924         * Scripts/webkitpy/layout_tests/port/base.py:
925           Add optional tolerance parameter to diff_image().
926         * Scripts/webkitpy/layout_tests/port/test.py:
927           Add optional tolerance parameter to diff_image().
928         * Scripts/webkitpy/layout_tests/port/webkit.py:
929           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
930         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
931           diff_files() always calls diff_image() with tolerance=0.
932           diff_files() is used only by rebaseline-chromium-webkit-tests.
933
934 2010-07-06  Sam Weinig  <sam@webkit.org>
935
936         Fix MiniBrowser build.
937
938         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
939
940 2010-07-06  Sam Weinig  <sam@webkit.org>
941
942         Reviewed by Anders Carlsson.
943
944         Add support for dumping the contents of messages to the console to WebKitTestRunner
945
946         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
947         (WTR::InjectedBundlePage::InjectedBundlePage):
948         (WTR::InjectedBundlePage::_addMessageToConsole):
949         (WTR::InjectedBundlePage::addMessageToConsole):
950         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
951
952 2010-07-06  Sam Weinig  <sam@webkit.org>
953
954         Reviewed by Anders Carlsson.
955
956         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
957         Add dumpAsText support for WebKitTestRunner
958
959         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
960         (WTR::InjectedBundle::InjectedBundle):
961         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
962         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
963         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
964         API to dump the main frames text.
965
966 2010-07-06  Darin Adler  <darin@apple.com>
967
968         Fix Chromium build.
969
970         * DumpRenderTree/chromium/WebViewHost.cpp:
971         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
972         (WebViewHost::didNavigateWithinPage): Ditto.
973         (WebViewHost::updateURL): Ditto.
974
975 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
976
977         Reviewed by Xan Lopez.
978
979         [GTK] build-webkit should not run autogen.sh unconditionally
980         https://bugs.webkit.org/show_bug.cgi?id=41704
981
982         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
983         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
984         some very minor cleanup.
985
986 2010-07-06  Darin Adler  <darin@apple.com>
987
988         Try to fix Chromium build.
989
990         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
991
992 2010-07-06  Darin Adler  <darin@apple.com>
993
994         Fix build.
995
996         * WebKitAPITest/TestsController.cpp:
997         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
998
999 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1000
1001         Reviewed by Kent Tamura.
1002
1003         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1004         https://bugs.webkit.org/show_bug.cgi?id=40558
1005
1006         Upstream DevTools for Chromium DRT.
1007         (original Chromium files rev. 51287)
1008
1009         * DumpRenderTree/DumpRenderTree.gypi:
1010         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1011         (DRTDevToolsAgent::DRTDevToolsAgent):
1012         (DRTDevToolsAgent::setWebView):
1013         (DRTDevToolsAgent::sendMessageToFrontend):
1014         (DRTDevToolsAgent::forceRepaint):
1015         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1016         (DRTDevToolsAgent::injectedScriptSource):
1017         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1018         (DRTDevToolsAgent::debuggerScriptSource):
1019         (DRTDevToolsAgent::asyncCall):
1020         (DRTDevToolsAgent::call):
1021         (DRTDevToolsAgent::webDevToolsAgent):
1022         (DRTDevToolsAgent::attach):
1023         (DRTDevToolsAgent::detach):
1024         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1025         (DRTDevToolsAgent::evaluateInWebInspector):
1026         (DRTDevToolsAgent::dispatchMessageLoop):
1027         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1028         (DRTDevToolsAgent::~DRTDevToolsAgent):
1029         (DRTDevToolsAgent::hostIdentifier):
1030         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1031         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1032         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1033         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1034         (DRTDevToolsCallArgs::callsCount):
1035         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1036         (DRTDevToolsClient::DRTDevToolsClient):
1037         (DRTDevToolsClient::~DRTDevToolsClient):
1038         (DRTDevToolsClient::sendMessageToAgent):
1039         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1040         (DRTDevToolsClient::activateWindow):
1041         (DRTDevToolsClient::closeWindow):
1042         (DRTDevToolsClient::dockWindow):
1043         (DRTDevToolsClient::undockWindow):
1044         (DRTDevToolsClient::asyncCall):
1045         (DRTDevToolsClient::call):
1046         (DRTDevToolsClient::allMessagesProcessed):
1047         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1048         * DumpRenderTree/chromium/EventSender.cpp:
1049         * DumpRenderTree/chromium/LayoutTestController.cpp:
1050         (LayoutTestController::LayoutTestController):
1051         (LayoutTestController::closeWebInspector):
1052         (LayoutTestController::setTimelineProfilingEnabled):
1053         (LayoutTestController::evaluateInWebInspector):
1054         * DumpRenderTree/chromium/LayoutTestController.h:
1055         * DumpRenderTree/chromium/TestShell.cpp:
1056         (TestShell::TestShell):
1057         (TestShell::~TestShell):
1058         (TestShell::createDRTDevToolsClient):
1059         (TestShell::showDevTools):
1060         (TestShell::closeDevTools):
1061         (TestShell::runFileTest):
1062         (TestShell::createNewWindow):
1063         * DumpRenderTree/chromium/TestShell.h:
1064         (TestShell::drtDevToolsAgent):
1065         (TestShell::drtDevToolsClient):
1066         * DumpRenderTree/chromium/config.h:
1067
1068 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1069
1070         Reviewed by Eric Seidel.
1071
1072         Don't pass image hash to DRT when pixel tests are disabled.
1073         https://bugs.webkit.org/show_bug.cgi?id=41597
1074
1075         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1076
1077 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1078
1079         Reviewed by Eric Seidel.
1080
1081         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1082         https://bugs.webkit.org/show_bug.cgi?id=41612
1083
1084         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1085
1086 2010-07-05  Adam Barth  <abarth@webkit.org>
1087
1088         Reviewed by Eric Seidel.
1089
1090         We should be able to specify a bug to block for webkit-patch upload
1091         https://bugs.webkit.org/show_bug.cgi?id=41648
1092
1093         This will be useful for working on the HTML5 parser.
1094
1095         * Scripts/webkitpy/tool/steps/createbug.py:
1096         * Scripts/webkitpy/tool/steps/options.py:
1097
1098 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1099
1100         Reviewed by Oliver Hunt.
1101
1102         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1103         https://bugs.webkit.org/show_bug.cgi?id=41017
1104
1105         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1106         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1107
1108 2010-07-04  MORITA Hajime  <morrita@google.com>
1109
1110         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1111         https://bugs.webkit.org/show_bug.cgi?id=41589
1112
1113         * run() method can result non-utf-8 bytes, that causes utf-8
1114           decoding fail.  Fixed to disable decoding.
1115         * Fixed Git.find_checkout_root() to make a test pass.
1116
1117         * Scripts/webkitpy/common/checkout/scm.py:
1118         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1119
1120 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1121
1122         Reviewed by Simon Hausmann.
1123
1124         [Qt] Fix DumpRenderTree userStyleSheet handling.
1125         https://bugs.webkit.org/show_bug.cgi?id=41570
1126
1127         DumpRenderTree did only set the userStyleSheet at
1128         layoutTestController.setUserStyleSheetEnabled().
1129
1130         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1131         (LayoutTestController::reset):
1132         (LayoutTestController::setUserStyleSheetLocation):
1133         (LayoutTestController::setUserStyleSheetEnabled):
1134         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1135
1136 2010-07-03  Robert Hogan  <robert@webkit.org>
1137
1138         Reviewed by Kenneth Rohde Christiansen.
1139
1140         [Qt] support dumpChildFrameScrollPositions
1141
1142         https://bugs.webkit.org/show_bug.cgi?id=41088
1143
1144         Unskip:
1145
1146         http/tests/navigation/anchor-subframeload.html
1147         http/tests/navigation/relativeanchor-frames.html
1148
1149         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1150         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1151         (WebCore::DumpRenderTree::dump):
1152         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1153         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1154         (LayoutTestController::reset):
1155         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1156         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1157         (LayoutTestController::dumpChildFrameScrollPositions):
1158
1159 2010-07-02  Sam Weinig  <sam@webkit.org>
1160
1161         Reviewed by Anders Carlsson.
1162
1163         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1164
1165         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1166         * Scripts/debug-webkittestrunner: Removed.
1167         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1168         * Scripts/run-webkittestrunner: Removed.
1169
1170 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1171
1172         Reviewed by Steve Falkenburg.
1173
1174         Some http tests fail on Windows with Cygwin 1.7
1175         https://bugs.webkit.org/show_bug.cgi?id=41537
1176         
1177         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1178         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1179         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1180
1181         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1182         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1183             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1184
1185 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1186
1187         Reviewed by Gustavo Noronha Silva.
1188
1189         [GTK] Separate DerivedSources per-project
1190         https://bugs.webkit.org/show_bug.cgi?id=41109
1191
1192         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1193         allowing the tools to build as a side-effect. Now that the top-level directory
1194         is no longer in the list of JavaScriptCore includes, include it explicitly.
1195
1196         * GNUmakefile.am:
1197
1198 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1199
1200         Reviewed by Kenneth Rohde Christiansen.
1201
1202         [Qt] Make context menus show up in the right place in QTestBrowser
1203
1204         Context menus were shown at scene-relative coordinates for
1205         QGraphicsWebView while QMenu expects them to be global. The
1206         change to the QWidget case was to get rid of the mapToGlobal.
1207
1208         * QtTestBrowser/webview.cpp:
1209
1210 2010-07-01  Robert Hogan <robert@webkit.org>
1211
1212         Reviewed by Kenneth Rohde Christiansen.
1213
1214         [Qt] dump frames in ascending alphabetical order of title
1215
1216         https://bugs.webkit.org/show_bug.cgi?id=41261
1217
1218         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1219         (WebCore::dumpHistoryItem):
1220
1221 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1222
1223         Unreviewed. 
1224
1225         Fix the GTK+ build after r62278.
1226
1227         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1228         let them override the automatic CPU detection for autotools builds.
1229
1230 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1231
1232         Unreviewed.
1233
1234         Fix the Windows build after r62278.
1235
1236         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1237
1238 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1239
1240         Reviewed by Gustavo Noronha Silva.
1241
1242         [GTK] build-webkit does not detect the number of CPUs
1243         https://bugs.webkit.org/show_bug.cgi?id=41469
1244
1245         Pass the appropriate -j<#> flag to make when building autotools builds.
1246         This causes make to spawn that many number of child processes for doing
1247         parallel builds.
1248
1249         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1250         of CPUs. This makes the script work across more platforms.
1251         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1252         number of CPUs across several platforms. Use this new function to determine the appropriate
1253         arguments to pass to make for doing parallel builds with autotools build files.
1254
1255 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1256
1257         Rubber-stamped by Laszlo Gombos.
1258
1259         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1260
1261         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1262         and use the one from WebKit.pri instead.
1263
1264 2010-07-01  Adam Barth  <abarth@webkit.org>
1265
1266         Reviewed by Eric Seidel.
1267
1268         Promote webkit-patch land-safely to main help
1269         https://bugs.webkit.org/show_bug.cgi?id=41446
1270
1271         I've been using this command a bunch and recommending it to folks.  We
1272         should show it in main help as it's past the experimental phase.
1273
1274         * Scripts/webkitpy/tool/commands/upload.py:
1275
1276 2010-06-28  MORITA Hajime  <morrita@google.com>
1277
1278         Reviewed by Shinichiro Hamaji.
1279
1280         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1281         https://bugs.webkit.org/show_bug.cgi?id=38775
1282
1283         - Introduced SCM.show_head() and SCM.diff_for_file().
1284         - Replaced direct svn invocations with newly implement SCM methods.
1285
1286         * Scripts/webkitpy/common/checkout/scm.py:
1287         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1288         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1289
1290 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1291
1292         Reviewed by Sam Weinig.
1293
1294         Allow MiniBrowser to open local files
1295         https://bugs.webkit.org/show_bug.cgi?id=41104
1296
1297         Wire up the openDocument: message with an NSOpenPanel, so we can open
1298         local files.
1299         
1300         Also change the xib so that the window remembers its size.
1301         
1302         * MiniBrowser/mac/AppDelegate.m:
1303         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1304         (-[BrowserAppDelegate openDocument:]):
1305         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1306         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1307
1308 2010-06-30  Sam Weinig  <sam@webkit.org>
1309
1310         Rubber-stamped by Anders Carlsson.
1311
1312         Add debug-webkittestrunner and cleanup related scripts.
1313
1314         * Scripts/debug-webkittestrunner: Added.
1315         * Scripts/run-webkittestrunner:
1316         * Scripts/webkitdirs.pm:
1317
1318 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1319
1320         [wx] Build fix after recent changes to LayoutTestController.
1321
1322         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1323         (LayoutTestController::pageSizeAndMarginsInPixels):
1324
1325 2010-06-29  Sam Weinig  <sam@webkit.org>
1326
1327         Reviewed by Anders Carlsson.
1328
1329         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1330         Make WebKitTestRunner work with more than one test at a time.
1331
1332         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1333         where there is a single WKView and each test is run it, rather than
1334         the design I was using where each test got its own WKView.
1335
1336         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1337         (WTR::InjectedBundle::didRecieveMessage):
1338         (WTR::InjectedBundle::reset):
1339         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1340         * WebKitTestRunner/TestController.cpp:
1341         (WTR::TestController::initialize):
1342         (WTR::TestController::runTest):
1343         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1344         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1345         * WebKitTestRunner/TestController.h:
1346         (WTR::TestController::mainWebView):
1347         (WTR::TestController::pageNamespace):
1348         (WTR::TestController::context):
1349         * WebKitTestRunner/TestInvocation.cpp:
1350         (WTR::TestInvocation::TestInvocation):
1351         (WTR::TestInvocation::~TestInvocation):
1352         (WTR::TestInvocation::invoke):
1353         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1354         * WebKitTestRunner/TestInvocation.h:
1355
1356 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1357
1358         Reviewed by Laszlo Gombos.
1359
1360         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1361         https://bugs.webkit.org/show_bug.cgi?id=40446
1362
1363         We quickly run out of memory on Symbian when loading web pages. This is
1364         caused by the default heap size, which is not suited for a web browser.
1365
1366         This change bumps the max heap size to 32MB.
1367
1368         * QtTestBrowser/QtTestBrowser.pro:
1369
1370 2010-06-30  Eric Seidel  <eric@webkit.org>
1371
1372         Reviewed by Adam Barth.
1373
1374         webkit-patch land allow the user to continue even if the builders are red
1375         https://bugs.webkit.org/show_bug.cgi?id=41395
1376
1377         I don't think it's good that we've been teaching people
1378         to always pass --ignore-builders.  At least land is now
1379         useable w/o --ignore-builders.
1380
1381         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1382
1383 2010-06-29  Robert Hogan  <robert@webkit.org>
1384
1385         Reviewed by Kenneth Rohde Christiansen.
1386
1387         [Qt] support dumpResourceResponseMIMETypes
1388         https://bugs.webkit.org/show_bug.cgi?id=41260
1389
1390         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1391         (LayoutTestController::reset):
1392         (LayoutTestController::dumpResourceResponseMIMETypes):
1393         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1394
1395 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1396
1397         Reviewed by Kenneth Rohde Christiansen.
1398
1399         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1400         https://bugs.webkit.org/show_bug.cgi?id=41173
1401
1402         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1403         (WebCore::WebPage::setViewGeometry):
1404         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1405
1406 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1407
1408         Reviewed by Simon Hausmann.
1409
1410         [Qt] Deal with postEvent in case of graphics based DRT
1411         https://bugs.webkit.org/show_bug.cgi?id=41174
1412
1413         QGraphicsScene does not have a postEvent method, so make scene
1414         send the event, in case of graphics based DRT, and delete it after that.
1415
1416         * DumpRenderTree/qt/EventSenderQt.cpp:
1417         (EventSender::scheduleAsynchronousClick):
1418         (EventSender::replaySavedEvents):
1419         (EventSender::postEvent):
1420         * DumpRenderTree/qt/EventSenderQt.h:
1421
1422 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1423
1424         Reviewed by Kenneth Rohde Christiansen.
1425
1426         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1427         https://bugs.webkit.org/show_bug.cgi?id=41172
1428
1429         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1430         (WebCore::DumpRenderTree::switchFocus):
1431
1432 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1433
1434         Reviewed by Xan Lopez.
1435
1436         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1437         https://bugs.webkit.org/show_bug.cgi?id=40009
1438
1439         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1440         are used when returning those values, for coherency with other ports.
1441
1442         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1443         (AccessibilityUIElement::role):
1444         (AccessibilityUIElement::title):
1445         (AccessibilityUIElement::description):
1446
1447 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1448
1449         Unreviewed, rolling out r62106.
1450         http://trac.webkit.org/changeset/62106
1451         https://bugs.webkit.org/show_bug.cgi?id=41346
1452
1453         "Broke editing tests" (Requested by xan_ on #webkit).
1454
1455         * Scripts/old-run-webkit-tests:
1456
1457 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1458
1459         Reviewed by Xan Lopez.
1460
1461         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1462         https://bugs.webkit.org/show_bug.cgi?id=38648
1463
1464         Add the GTK_MODULES envvar (set to "gail") to the clean
1465         environment when running DRT for the Gtk+ port
1466
1467         * Scripts/old-run-webkit-tests:
1468
1469 2010-06-28  Adam Barth  <abarth@webkit.org>
1470
1471         Unreviewed.
1472
1473         Switch test-html5-parser back to using runner.html.
1474
1475         * Scripts/test-html5-parser:
1476
1477 2010-06-28  Adam Barth  <abarth@webkit.org>
1478
1479         Reviewed by Eric Seidel.
1480
1481         Restore webkit-runner.html for use with new tree builder
1482         https://bugs.webkit.org/show_bug.cgi?id=41317
1483
1484         For now, we just want to run webkit-runner when we test-html5-parser.
1485
1486         * Scripts/test-html5-parser:
1487
1488 2010-06-23  John Gregg  <johnnyg@google.com>
1489
1490         Reviewed by Kent Tamura.
1491
1492         add ENABLE_DIRECTORY_UPLOAD build support
1493         https://bugs.webkit.org/show_bug.cgi?id=41100
1494
1495         * Scripts/build-webkit:
1496
1497 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1498
1499         Rubber-stamped by Xan Lopez.
1500
1501         Update webkitdirs's knowledge of our library's name.
1502
1503         * Scripts/webkitdirs.pm:
1504
1505 2010-06-28  Sam Weinig  <sam@webkit.org>
1506
1507         Reviewed by Anders Carlsson.
1508
1509         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1510         Build up WebKitTestRunner output in the InjectedBundle
1511
1512         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1513         and sending it over postMessage when done, instead of using the async
1514         WKPageRenderTreeExternalRepresentation.
1515
1516         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1517         (WTR::InjectedBundle::done):
1518         (WTR::InjectedBundle::didRecieveMessage):
1519         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1520         (WTR::InjectedBundle::os):
1521         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1522         (WTR::WKStringToUTF8):
1523         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1524         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1525         * WebKitTestRunner/TestInvocation.cpp:
1526         (WTR::WKStringToUTF8):
1527         (WTR::TestInvocation::TestInvocation):
1528         (WTR::TestInvocation::invoke):
1529         (WTR::TestInvocation::initializeMainWebView):
1530         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1531         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1532         * WebKitTestRunner/TestInvocation.h:
1533
1534 2010-06-28  Robert Hogan  <robert@webkit.org>
1535
1536         Unreviewed, rolling out r62021.
1537         http://trac.webkit.org/changeset/62021
1538         https://bugs.webkit.org/show_bug.cgi?id=41261
1539
1540         Broke http/navigation tests among other
1541
1542         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1543         (WebCore::DumpRenderTree::dumpFramesAsText):
1544
1545 2010-06-28  Sam Weinig  <sam@webkit.org>
1546
1547         Reviewed by Anders Carlsson.
1548
1549         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1550         environment.
1551
1552         * Scripts/run-webkittestrunner: Added.
1553         * Scripts/webkitdirs.pm:
1554
1555 2010-06-28  Robert Hogan  <robert@webkit.org>
1556
1557         Reviewed by Kenneth Rohde Christiansen.
1558
1559         [Qt] dump frames in ascending alphabetical order of title
1560
1561         https://bugs.webkit.org/show_bug.cgi?id=41261
1562
1563         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1564         (WebCore::DumpRenderTree::dumpFramesAsText):
1565
1566 2010-06-28  Robert Hogan  <robert@webkit.org>
1567
1568         Reviewed by Kenneth Rohde Christiansen.
1569
1570         [Qt] dump bf history of child windows
1571
1572         https://bugs.webkit.org/show_bug.cgi?id=41266
1573
1574         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1575         (WebCore::DumpRenderTree::dumpBackForwardList):
1576         (WebCore::DumpRenderTree::dump):
1577         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1578
1579 2010-06-28  Sam Weinig  <sam@webkit.org>
1580
1581         Reviewed by Anders Carlsson.
1582
1583         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1584         WebKit2: Add frame API for InjectedBundle code
1585
1586         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1587         (_didClearWindowForFrame):
1588
1589 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1590
1591         Reviewed by Kenneth Rohde Christiansen.
1592
1593         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1594         https://bugs.webkit.org/show_bug.cgi?id=38597
1595
1596         Fix behavior so reload button really acts as a load and a reload button.
1597
1598         * QtTestBrowser/mainwindow.cpp:
1599         (MainWindow::changeLocation):
1600
1601 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1602
1603         Reviewed by Gustavo Noronha.
1604
1605         [GTK] Does not compile with -DGSEAL_ENABLE
1606         https://bugs.webkit.org/show_bug.cgi?id=37851
1607
1608         Fix build with GSEAL enabled.
1609
1610         * DumpRenderTree/gtk/EventSender.cpp:
1611         (gtk_widget_get_window):
1612         (prepareMouseButtonEvent):
1613         (mouseMoveToCallback):
1614         (mouseWheelToCallback):
1615         (keyDownCallback):
1616
1617 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1618
1619         Reviewed by Gustavo Noronha.
1620
1621         [GTK] Add support for GTK+3
1622         https://bugs.webkit.org/show_bug.cgi?id=41253
1623
1624         Adapt build system for 3.x support.
1625
1626         * GNUmakefile.am:
1627
1628 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1629
1630         Reviewed by Simon Hausmann.
1631
1632         [QT][S60] build-webkit scripts picks wrong make spec for windows build
1633         https://bugs.webkit.org/show_bug.cgi?id=41198
1634
1635         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
1636
1637         * Scripts/webkitdirs.pm:
1638         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
1639
1640 2010-06-28  Eric Seidel  <eric@webkit.org>
1641
1642         Reviewed by Adam Barth.
1643
1644         Make it possible to test the new HTML5 TreeBuilder
1645         https://bugs.webkit.org/show_bug.cgi?id=41276
1646
1647         Adam was concerned that someone might make their port
1648         depend on this setting (I guess we had some trouble with that
1649         with the HTML5Parser setting), so I littered the code with warnings.
1650
1651         test-html5-parser now tests this code path.
1652
1653         * DumpRenderTree/mac/DumpRenderTree.mm:
1654         (resetDefaultsToConsistentValues):
1655         (initializeGlobalsFromCommandLineOptions):
1656         * Scripts/test-html5-parser:
1657
1658 2010-06-27  MORITA Hajime  <morrita@google.com>
1659
1660         Unreviewed. 
1661         
1662         Some never-called @staticmethods touched self. 
1663         Fixed it to replace these self with a class.
1664
1665         * Scripts/webkitpy/common/checkout/scm.py:
1666
1667 2010-06-27  MORITA Hajime  <morrita@google.com>
1668
1669         Unreviewed.
1670         
1671         Fixed exception raising syntax that is pointed out at
1672         https://bugs.webkit.org/show_bug.cgi?id=41153
1673
1674         * Scripts/webkitpy/common/checkout/scm.py:
1675         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
1676           Removed a bad line that I accidentally checked-in at last revision.
1677
1678 2010-06-24  MORITA Hajime  <morrita@google.com>
1679
1680         Reviewed by Eric Seidel.
1681
1682         rebaseline-chromium-webkit-tests should add or remove files to local git repository
1683         https://bugs.webkit.org/show_bug.cgi?id=41153
1684
1685         - Added SCM.add() and SCM.remove()
1686         - Replaced "svn add" and "svn remove"
1687           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
1688         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
1689           for debugging purpose.
1690
1691         * Scripts/webkitpy/common/checkout/scm.py:
1692         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1693         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1694
1695 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
1696
1697         Reviewed by Shinichiro Hamaji.
1698
1699         Improve default value handling for page format properties.
1700         https://bugs.webkit.org/show_bug.cgi?id=41150
1701
1702         * DumpRenderTree/LayoutTestController.cpp:
1703         (parsePageNumber):
1704         (parsePageNumberSizeMarings):
1705         (pageSizeAndMarginsInPixelsCallback):
1706         (LayoutTestController::staticFunctions):
1707         * DumpRenderTree/LayoutTestController.h:
1708         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1709         (LayoutTestController::pageSizeAndMarginsInPixels):
1710         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1711         (LayoutTestController::pageSizeAndMarginsInPixels):
1712         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1713         (LayoutTestController::pageSizeAndMarginsInPixels):
1714
1715 2010-06-21  Robert Hogan  <robert@webkit.org>
1716
1717         Reviewed by Kenneth Rohde Christiansen.
1718
1719         [Qt] DRT Support for setCustomPolicyDelegate
1720
1721         https://bugs.webkit.org/show_bug.cgi?id=39564
1722
1723         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1724         (LayoutTestController::setCustomPolicyDelegate):
1725         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1726
1727 2010-06-26  Robert Hogan  <robert@webkit.org>
1728
1729         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
1730         
1731         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
1732         exported.
1733
1734         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1735
1736 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
1737
1738         Reviewed by Dimitri Glazkov.
1739
1740         Add a build-webkit option for enabling Web Timing support.
1741         https://bugs.webkit.org/show_bug.cgi?id=38924
1742
1743         * Scripts/build-webkit:
1744
1745 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1746
1747         Reviewed by Kenneth Rohde Christiansen.
1748
1749         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1750         https://bugs.webkit.org/show_bug.cgi?id=38597
1751
1752         Make the reload button act as a load button as well.
1753
1754         * QtTestBrowser/mainwindow.cpp:
1755         (MainWindow::buildUI):
1756         (MainWindow::changeLocation):
1757
1758 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
1759
1760         Reviewed by Dmitry Titov.
1761
1762         Add empty abortModal() method to all platforms.
1763         https://bugs.webkit.org/show_bug.cgi?id=40864
1764
1765         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
1766         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
1767         that use abortModal will become mac specific which is not desirable.
1768
1769         * DumpRenderTree/LayoutTestController.cpp:
1770         (abortModalCallback):
1771         (LayoutTestController::staticFunctions):
1772         * DumpRenderTree/LayoutTestController.h:
1773         * DumpRenderTree/chromium/LayoutTestController.cpp:
1774         (LayoutTestController::LayoutTestController):
1775         (LayoutTestController::abortModal):
1776         * DumpRenderTree/chromium/LayoutTestController.h:
1777         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1778         (LayoutTestController::abortModal):
1779         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1780         (LayoutTestController::abortModal):
1781         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1782         (LayoutTestController::abortModal):
1783         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1784         (LayoutTestController::abortModal):
1785
1786 2010-06-25  Sam Weinig  <sam@webkit.org>
1787
1788         Reviewed by Anders Carlsson.
1789
1790         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
1791         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
1792
1793         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
1794         (WTR::InjectedBundle::shared):
1795         (WTR::InjectedBundle::InjectedBundle):
1796         (WTR::InjectedBundle::_didCreatePage):
1797         (WTR::InjectedBundle::_willDestroyPage):
1798         (WTR::InjectedBundle::_didRecieveMessage):
1799         (WTR::InjectedBundle::initialize):
1800         (WTR::InjectedBundle::didCreatePage):
1801         (WTR::InjectedBundle::willDestroyPage):
1802         (WTR::InjectedBundle::didRecieveMessage):
1803         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
1804         (WTR::InjectedBundle::layoutTestController):
1805         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1806         (WKBundleInitialize):
1807         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
1808         (WTR::InjectedBundlePage::InjectedBundlePage):
1809         (WTR::InjectedBundlePage::~InjectedBundlePage):
1810         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
1811         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
1812         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
1813         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
1814         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
1815         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
1816         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
1817         (WTR::InjectedBundlePage::_didClearWindowForFrame):
1818         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1819         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1820         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1821         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1822         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1823         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1824         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1825         (WTR::InjectedBundlePage::didClearWindowForFrame):
1826         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
1827         (WTR::InjectedBundlePage::page):
1828         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
1829         (WTR::LayoutTestController::create):
1830         (WTR::LayoutTestController::LayoutTestController):
1831         (WTR::LayoutTestController::~LayoutTestController):
1832         (WTR::dumpAsTextCallback):
1833         (WTR::layoutTestControllerObjectFinalize):
1834         (WTR::LayoutTestController::makeWindowObject):
1835         (WTR::LayoutTestController::getJSClass):
1836         (WTR::LayoutTestController::staticFunctions):
1837         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
1838         (WTR::LayoutTestController::dumpAsText):
1839         (WTR::LayoutTestController::setDumpAsText):
1840         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1841
1842 2010-06-25  Sam Weinig  <sam@webkit.org>
1843
1844         Reviewed by Anders Carlsson.
1845
1846         Make WebKitTestRunner really work with run-webkit-tests. 
1847
1848         - Add Forwarding headers to allow some cleanup.
1849
1850         * WebKitTestRunner/ForwardingHeaders: Added.
1851         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
1852         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
1853         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
1854         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
1855         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
1856         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
1857         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
1858         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
1859         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
1860         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
1861         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
1862         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
1863         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
1864         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
1865         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
1866         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
1867         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
1868         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
1869         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
1870         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
1871         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
1872         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
1873         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
1874         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
1875         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
1876         * WebKitTestRunner/TestInvocation.cpp:
1877         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
1878         * WebKitTestRunner/TestInvocation.h:
1879
1880 2010-06-25  Sam Weinig  <sam@webkit.org>
1881
1882         Reviewed by Mark Rowe.
1883
1884         Add support for WebKitTestRunner to old-run-webkit-tests
1885
1886         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
1887
1888         * Scripts/build-webkittestrunner: Added.
1889         * Scripts/old-run-webkit-tests:
1890
1891 2010-06-25  Adam Barth  <abarth@webkit.org>
1892
1893         Reviewed by David Levin.
1894
1895         Incremental build failed on Chromium ews
1896         https://bugs.webkit.org/show_bug.cgi?id=41011
1897
1898         The division of responsibility between update-webkit --chromium and
1899         build-webkit --chromium is slightly unclear.  In this patch, we make
1900         build-webkit --chromium also update DEPS and re-run GYP in case the
1901         developer has changed either since they updated.
1902
1903         This change is also helpful for the EWS, which wants to update DEPS and
1904         re-run GYP after applying patches, but the EWS doesn't want to run
1905         update-webkit --chromium because it has a dirty working copy.
1906
1907         * Scripts/webkitdirs.pm:
1908
1909 2010-06-25  Robert Hogan  <robert@webkit.org>
1910
1911         Reviewed by Simon Hausmann.
1912
1913         [Qt] Support evaluateScriptInIsolatedWorld()
1914
1915         https://bugs.webkit.org/show_bug.cgi?id=40079
1916
1917         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
1918         Remove QWebScriptWorld from exported headers.
1919         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
1920
1921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1922         (LayoutTestController::reset):
1923         (LayoutTestController::evaluateScriptInIsolatedWorld):
1924         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1925
1926 2010-06-25  Anders Carlsson  <andersca@apple.com>
1927
1928         Revert accidental part and add a newline.
1929
1930         * MiniBrowser/mac/AppDelegate.m:
1931         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1932
1933 2010-06-25  Anders Carlsson  <andersca@apple.com>
1934
1935         Rubber-stamped by Dan Bernstein.
1936
1937         Add a LOG macro that expands to a no-op by default.
1938
1939         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1940         * MiniBrowser/mac/AppDelegate.m:
1941         (_didRecieveMessageFromInjectedBundle):
1942         * MiniBrowser/mac/BrowserWindowController.m:
1943         (-[BrowserWindowController windowShouldClose:]):
1944         (_didStartProvisionalLoadForFrame):
1945         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1946         (_didFailProvisionalLoadWithErrorForFrame):
1947         (_didCommitLoadForFrame):
1948         (_didFinishLoadForFrame):
1949         (_didFailLoadWithErrorForFrame):
1950         (_didReceiveTitleForFrame):
1951         (_didFirstLayoutForFrame):
1952         (_didFirstVisuallyNonEmptyLayoutForFrame):
1953         (_didBecomeUnresponsive):
1954         (_didBecomeResponsive):
1955         (_decidePolicyForNavigationAction):
1956         (_decidePolicyForNewWindowAction):
1957         (_createNewPage):
1958         (_showPage):
1959         (_closePage):
1960         (_didNavigateWithNavigationData):
1961         (_didPerformClientRedirect):
1962         (_didPerformServerRedirect):
1963         (_didUpdateHistoryTitle):
1964         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1965         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1966         (_didClearWindowForFrame):
1967         (_didCreatePage):
1968         (_willDestroyPage):
1969         (_didRecieveMessage):
1970
1971 2010-06-24  Adam Barth  <abarth@webkit.org>
1972
1973         Reviewed by Eric Seidel.
1974
1975         commit-queue is taking too long to land patches because of red trees
1976         https://bugs.webkit.org/show_bug.cgi?id=41194
1977
1978         Instead of checking for the tree to be green, we'll just spin hot
1979         trying to land patches.  This is probably too extreme in ignoring the
1980         tree, but I think we should try it for a while to see if we have
1981         trouble.  That will help us find the right balance.
1982
1983         * Scripts/webkitpy/tool/commands/queues.py:
1984         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1985
1986 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
1987
1988         Reviewed by Xan Lopez.
1989
1990         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
1991         https://bugs.webkit.org/show_bug.cgi?id=40843
1992
1993         Define the version for old GTK+s in a way that is forward-compatible
1994         and clean up the logic a bit.
1995
1996         * DumpRenderTree/gtk/EventSender.cpp:
1997         (gdk_window_get_root_coords): Renamed and cleaned up.
1998         (prepareMouseButtonEvent): Remove #ifdefs.
1999         (mouseMoveToCallback): Remove #ifdefs.
2000
2001 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2002
2003         Reviewed by Eric Seidel.
2004
2005         Fix NewRunWebKitTests to work on Windows.
2006         https://bugs.webkit.org/show_bug.cgi?id=41180
2007
2008         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2009             because Windows fails to understand what we're asking of it.
2010
2011 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2012
2013         Reviewed by Xan Lopez.
2014
2015         [GTK] The url passed to the WebView during layout tests is invalid
2016         https://bugs.webkit.org/show_bug.cgi?id=40832
2017
2018         Set the test URL to the full real file URL and do a small cleanup.
2019         Previously a URL like file://relative/path/to/test.html was passed
2020         to the WebView. This malformed file URL would be returned by
2021         webkit_web_view_get_url and webkit_web_frame_get_url.
2022
2023         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2024         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2025         (shouldOpenWebInspector): Change to take a const string& as the argument.
2026         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2027         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2028
2029 2010-06-24  Sam Weinig  <sam@webkit.org>
2030
2031         Reviewed by Anders Carlsson.
2032
2033         Fix WebKitTestRunner Makefile typos.
2034
2035         * WebKitTestRunner/Makefile:
2036
2037 2010-06-24  Adele Peterson  <adele@apple.com>
2038
2039         Reviewed by Eric Carlson.
2040
2041         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2042         https://bugs.webkit.org/show_bug.cgi?id=41085
2043
2044         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2045         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2046
2047 2010-06-23  Sam Weinig  <sam@webkit.org>
2048
2049         Reviewed by Anders Carlsson.
2050
2051         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2052         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2053
2054         - Mac only.
2055         - run-webkit-tests has not been modified to call it yet.
2056         - Only dumps the render tree at this time. 
2057
2058         * WebKitTestRunner: Added.
2059         * WebKitTestRunner/Configurations: Added.
2060         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2061         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2062         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2063         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2064         * WebKitTestRunner/InjectedBundle: Added.
2065         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2066         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2067         (_didStartProvisionalLoadForFrame):
2068         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2069         (_didFailProvisionalLoadWithErrorForFrame):
2070         (_didCommitLoadForFrame):
2071         (_didFinishLoadForFrame):
2072         (_didFailLoadWithErrorForFrame):
2073         (_didReceiveTitleForFrame):
2074         (_didClearWindow):
2075         (_didCreatePage):
2076         (_willDestroyPage):
2077         (_didRecieveMessage):
2078         (WKBundleInitialize):
2079         * WebKitTestRunner/Makefile: Added.
2080         * WebKitTestRunner/PlatformWebView.h: Added.
2081         (WTR::PlatformWebView::platformView):
2082         * WebKitTestRunner/TestController.cpp: Added.
2083         (WTR::TestController::shared):
2084         (WTR::TestController::TestController):
2085         (WTR::TestController::initialize):
2086         (WTR::TestController::runTest):
2087         (WTR::TestController::runTestingServerLoop):
2088         (WTR::TestController::run):
2089         * WebKitTestRunner/TestController.h: Added.
2090         (WTR::TestController::verbose):
2091         (WTR::TestController::injectedBundlePath):
2092         * WebKitTestRunner/TestInvocation.cpp: Added.
2093         (WTR::createWKURL):
2094         (WTR::TestInvocation::TestInvocation):
2095         (WTR::TestInvocation::~TestInvocation):
2096         (WTR::TestInvocation::invoke):
2097         (WTR::TestInvocation::dump):
2098         (WTR::TestInvocation::initializeMainWebView):
2099         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2100         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2101         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2102         (WTR::TestInvocation::didCommitLoadForFrame):
2103         (WTR::TestInvocation::didFinishLoadForFrame):
2104         (WTR::TestInvocation::didFailLoadForFrame):
2105         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2106         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2107         * WebKitTestRunner/TestInvocation.h: Added.
2108         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2109         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2110         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2111         * WebKitTestRunner/mac: Added.
2112         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2113         (WTR::PlatformWebView::PlatformWebView):
2114         (WTR::PlatformWebView::~PlatformWebView):
2115         (WTR::PlatformWebView::page):
2116         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2117         (WTR::TestInvocation::runUntil):
2118         * WebKitTestRunner/mac/main.mm: Added.
2119         (main):
2120
2121 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2122
2123         Unreviewed. Adding myself to the committers list.
2124
2125         * Scripts/webkitpy/common/config/committers.py:
2126
2127 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2128
2129         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2130
2131         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2132         (LayoutTestController::isPageBoxVisible):
2133         (LayoutTestController::pageAreaRectInPixels):
2134         (LayoutTestController::preferredPageSizeInPixels):
2135         * wx/build/settings.py:
2136
2137 2010-06-23  James Robinson  <jamesr@chromium.org>
2138
2139         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2140
2141         * Scripts/webkitpy/common/config/committers.py:
2142
2143 2010-06-23  Kent Tamura  <tkent@chromium.org>
2144
2145         Reviewed by Dimitri Glazkov.
2146
2147         Correct Chromium test configuration
2148         https://bugs.webkit.org/show_bug.cgi?id=41057
2149
2150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2151          - Add "--use-drt" option for NRWT. It is required for Chromium and
2152            ignored for other platforms.
2153          - Skip JSC test on Chromium
2154         * BuildSlaveSupport/test-result-archive:
2155           Add Chromium support.
2156
2157 2010-06-23  Sam Weinig  <sam@webkit.org>
2158
2159         Reviewed by Anders Carlsson.
2160
2161         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2162         WebKit2: Flesh out more of the InjectedBundle client API
2163
2164         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2165         (_didStartProvisionalLoadForFrame):
2166         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2167         (_didFailProvisionalLoadWithErrorForFrame):
2168         (_didCommitLoadForFrame):
2169         (_didFinishLoadForFrame):
2170         (_didFailLoadWithErrorForFrame):
2171         (_didReceiveTitleForFrame):
2172         (_didClearWindowForFrame):
2173         (_didCreatePage):
2174         (_willDestroyPage):
2175         (WKBundleInitialize):
2176
2177 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2178
2179         Reviewed by Shinichiro Hamaji.
2180
2181         Implement page format data programming interface.
2182         Add methods for testing.
2183         https://bugs.webkit.org/show_bug.cgi?id=37538
2184
2185         * DumpRenderTree/LayoutTestController.cpp:
2186         (parsePageNumber):
2187         (isPageBoxVisibleCallback):
2188         (pageAreaRectInPixelsCallback):
2189         (preferredPageSizeInPixelsCallback):
2190         (LayoutTestController::staticFunctions):
2191         * DumpRenderTree/LayoutTestController.h:
2192         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2193         (LayoutTestController::isPageBoxVisible):
2194         (LayoutTestController::pageAreaRectInPixels):
2195         (LayoutTestController::preferredPageSizeInPixels):
2196         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2197         (LayoutTestController::isPageBoxVisible):
2198         (LayoutTestController::pageAreaRectInPixels):
2199         (LayoutTestController::preferredPageSizeInPixels):
2200         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2201         (LayoutTestController::isPageBoxVisible):
2202         (LayoutTestController::pageAreaRectInPixels):
2203         (LayoutTestController::preferredPageSizeInPixels):
2204
2205 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2206
2207         Reviewed by Shinichiro Hamaji.
2208
2209         Follow proper convention for if/switch/while as I've discovered
2210         them to be through my review processes.
2211         https://bugs.webkit.org/show_bug.cgi?id=40723
2212
2213         Modified test so that if( foo ) is not allowed as it appears not
2214         to be the accepted convention.
2215
2216         * Scripts/webkitpy/style/checkers/cpp.py:
2217         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2218
2219 2010-06-22  Eric Seidel  <eric@webkit.org>
2220
2221         Reviewed by Adam Barth.
2222
2223         Run clean-header-guards to fix some header guards
2224         https://bugs.webkit.org/show_bug.cgi?id=41044
2225
2226         No functional changes, thus no tests.
2227
2228         This entire change was generated by running
2229         clean-header-guards, and then reverting changes
2230         to files which shouldn't be changed.  Those which
2231         are left all should be updated.
2232
2233         Some of these changes are just fixing 755 permissions
2234         to be 644, since it seems various files have the wrong
2235         execute bit which don't need it.  clean-header-guards
2236         made those (welcome) permission fixes unintentionally.
2237
2238         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2239         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2240         * QtTestBrowser/fpstimer.h:
2241
2242 2010-06-22  Adam Barth  <abarth@webkit.org>
2243
2244         Reviewed by Eric Seidel.
2245
2246         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2247         https://bugs.webkit.org/show_bug.cgi?id=41043
2248
2249         Update the hash.
2250
2251         * Scripts/do-webcore-rename:
2252
2253 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2254
2255         Reviewed by Shinichiro Hamaji.
2256
2257         Follow proper convention for variable declaration spacing.
2258         https://bugs.webkit.org/show_bug.cgi?id=40724
2259
2260         Modified test so that 'int   a;' is not allowed.
2261
2262         * Scripts/webkitpy/style/checkers/cpp.py:
2263         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2264
2265 2010-06-22  Eric Seidel  <eric@webkit.org>
2266
2267         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2268
2269         * Scripts/webkitpy/common/config/committers.py:
2270
2271 2010-06-22  Eric Seidel  <eric@webkit.org>
2272
2273         Reviewed by Adam Barth.
2274
2275         Remove Gtk 64-Release bot from core since it's broken
2276         https://bugs.webkit.org/show_bug.cgi?id=41022
2277
2278         This bot alone has been responsible for more than 72 hours of
2279         commit-queue blockage in the last week.  The bot is broken -- keeps
2280         losing its display server or similar.  Until the Gtk folks can fix the
2281         bot, we need to remove it from core.  The WebKit community can't keep
2282         it green as is.
2283
2284         * Scripts/webkitpy/common/net/buildbot.py:
2285         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2286
2287 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2288
2289         Reviewed by Eric Seidel.
2290
2291         Fix the Windows build.
2292         https://bugs.webkit.org/show_bug.cgi?id=40972
2293
2294         * DumpRenderTree/win/ImageDiff.vcproj:
2295
2296 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2297
2298         Reviewed by Darin Adler, Dmitry Titov.
2299
2300         DumpRenderTree should allow tests with modal dialogs
2301         https://bugs.webkit.org/show_bug.cgi?id=35350
2302
2303         * DumpRenderTree/LayoutTestController.cpp:
2304         (abortModalCallback):
2305         (LayoutTestController::staticFunctions):
2306         * DumpRenderTree/LayoutTestController.h:
2307         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2308         (LayoutTestController::abortModal):
2309         Add abortModal method to LayoutTestController and make it available from script.
2310
2311         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2312         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2313         abortModal from when modal window closes.
2314         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2315
2316 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2317
2318         Reviewed by Anders Carlsson.
2319         
2320         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2321         https://bugs.webkit.org/show_bug.cgi?id=40948
2322         
2323         Have the script look in WebKit2.
2324
2325         * Scripts/do-webcore-rename:
2326
2327 2010-06-21  Robert Hogan  <robert@webkit.org>
2328
2329         Reviewed by Kenneth Rohde Christiansen.
2330
2331         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2332
2333         It's a Mac-specific test so just add the required LayoutTestController
2334         function as a no-op to avoid failing. Similar approach adopted by other
2335         ports.
2336
2337         https://bugs.webkit.org/show_bug.cgi?id=33344
2338
2339         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2340         (LayoutTestController::addDisallowedURL):
2341
2342 2010-06-21  Sam Weinig  <sam@webkit.org>
2343
2344         Reviewed by Anders Carlsson.
2345
2346         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2347         Add message passing support to the WebKit2 API.
2348
2349         - Add some test messages.
2350
2351         * MiniBrowser/mac/AppDelegate.m:
2352         (_didRecieveMessageFromInjectedBundle):
2353         (-[BrowserAppDelegate init]):
2354         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2355         (_didClearWindow):
2356         (_didCreatePage):
2357         (_didRecieveMessage):
2358         (WKBundleInitialize):
2359
2360 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2361
2362         Unreviewed.
2363
2364         Rolling back 61551 and 61555 due to test failures.
2365
2366         * DumpRenderTree/LayoutTestController.cpp:
2367         (LayoutTestController::staticFunctions):
2368         * DumpRenderTree/LayoutTestController.h:
2369         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2370         (LayoutTestController::setEditingBehavior):
2371         * DumpRenderTree/mac/UIDelegate.mm:
2372
2373 2010-06-21  Anders Carlsson  <andersca@apple.com>
2374
2375         Reviewed by Sam Weinig.
2376
2377         Make DumpRenderTree build with clang++
2378
2379         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2380         (-[LocalPasteboard setPropertyList:forType:]):
2381         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2382         (-[DumpRenderTreeWindow keyDown:]):
2383         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2384         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2385         (LayoutTestController::isCommandEnabled):
2386
2387 2010-06-21  Satish Sampath  <satish@chromium.org>
2388
2389         Reviewed by Steve Block.
2390
2391         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2392         https://bugs.webkit.org/show_bug.cgi?id=40878
2393
2394         * Scripts/build-webkit:
2395
2396 2010-06-21  Kent Tamura  <tkent@chromium.org>
2397
2398         Reviewed by Dimitri Glazkov.
2399
2400         [DRT/Chromium] Initialization for http/tests/loading/
2401         https://bugs.webkit.org/show_bug.cgi?id=40902
2402
2403         * DumpRenderTree/chromium/TestShell.cpp:
2404         (TestShell::runFileTest):
2405
2406 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2407
2408         Unreviewed.
2409
2410         Adding myself to the committers list.
2411
2412         * Scripts/webkitpy/common/config/committers.py:
2413
2414 2010-06-20  Kent Tamura  <tkent@chromium.org>
2415
2416         Reviewed by Dimitri Glazkov.
2417
2418         [DRT/Chromium] Add --allow-external-pages option
2419         https://bugs.webkit.org/show_bug.cgi?id=40762
2420
2421         Add --allow-external-pages introduced by Chromium r45403.
2422         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2423
2424         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2425         (main):
2426         * DumpRenderTree/chromium/TestShell.cpp:
2427         (TestShell::TestShell):
2428         * DumpRenderTree/chromium/TestShell.h:
2429         (TestShell::allowExternalPages):
2430         (TestShell::setAllowExternalPages):
2431         * DumpRenderTree/chromium/WebViewHost.cpp:
2432         (WebViewHost::willSendRequest):
2433
2434 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2435
2436         Reviewed by Adam Barth.
2437
2438         Sheriffbot: Should allow "r" in SVN_REVISION
2439         https://bugs.webkit.org/show_bug.cgi?id=40889
2440
2441         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2442         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2443
2444 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2445
2446         Reviewed by Dimitri Glazkov.
2447
2448         Python Tests Fail after r61508
2449         https://bugs.webkit.org/show_bug.cgi?id=40891
2450
2451         Test's regex list needed to be updated to match the new
2452         regex list in the source code. Added new bots to the
2453         example_buildbots list.
2454
2455         Regex list fixed in r61512. Updated bot list.
2456
2457         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2458
2459 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2460
2461         Unreviewed, build fix.
2462
2463         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2464
2465         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2466
2467 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2468
2469         Unreviewed.
2470
2471         Adding myself to the committers list.
2472
2473         * Scripts/webkitpy/common/config/committers.py:
2474
2475 2010-06-19  Sam Weinig  <sam@webkit.org>
2476
2477         Reviewed by Anders Carlsson.
2478
2479         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2480         Add ability to have a WebProcess per WebContext.
2481
2482         Move to use new shared contexts API.
2483
2484         * MiniBrowser/mac/AppDelegate.h:
2485         * MiniBrowser/mac/AppDelegate.m:
2486         (-[BrowserAppDelegate init]):
2487         (-[BrowserAppDelegate getCurrentPageNamespace]):
2488         (-[BrowserAppDelegate validateMenuItem:]):
2489         (-[BrowserAppDelegate _setProcessModel:]):
2490         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2491         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2492         * MiniBrowser/win/BrowserView.cpp:
2493         (BrowserView::create):
2494
2495 2010-06-02  Robert Hogan  <robert@webkit.org>
2496
2497         Reviewed by Adam Barth.
2498
2499         [Qt] Support evaluateScriptInIsolatedWorld()
2500
2501         https://bugs.webkit.org/show_bug.cgi?id=40079
2502
2503         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2504         (LayoutTestController::evaluateScriptInIsolatedWorld):
2505         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2506
2507 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2508
2509         Reviewed by Darin Adler.
2510
2511         Add three more non-core Chromium builders to start testing DumpRenderTree.
2512         https://bugs.webkit.org/show_bug.cgi?id=40335
2513
2514         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2515
2516 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2517
2518         Reviewed by Darin Fisher.
2519
2520         [Chromium] Plumbing for top-level frame names
2521         https://bugs.webkit.org/show_bug.cgi?id=40430
2522
2523         * DumpRenderTree/chromium/WebViewHost.cpp:
2524         (WebViewHost::reset):
2525         Changed obsolete call to clearName() to use setName(WebString()) instead.
2526
2527 2010-06-18  Sam Weinig  <weinig@apple.com>
2528
2529         Rolling http://trac.webkit.org/changeset/61297 back in.
2530
2531         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2532         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2533         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2534         (_didClearWindow):
2535         (_didCreatePage):
2536         (WKBundleInitialize):
2537
2538 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2539
2540         Reviewed by Darin Adler.
2541
2542         https://bugs.webkit.org/show_bug.cgi?id=40803
2543         TestNetscapePlugin has an incorrect implementation of "property" property
2544
2545         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2546         pass a static string back, it's going to be released by NPAPI implementation.
2547
2548 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2549
2550         Unreviewed.
2551
2552         Adding myself to the committers list.
2553
2554         * Scripts/webkitpy/common/config/committers.py:
2555
2556 2010-06-17  Tony Chang  <tony@chromium.org>
2557
2558         Reviewed by Kent Tamura.
2559
2560         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2561         https://bugs.webkit.org/show_bug.cgi?id=40615
2562
2563         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2564
2565 2010-06-17  Ada Chan  <adachan@apple.com>
2566
2567         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2568
2569         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2570         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2571         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2572
2573 2010-06-17  Darin Adler  <darin@apple.com>
2574
2575         One more try at fix for Chromium build.
2576
2577         * DumpRenderTree/chromium/TestShell.cpp:
2578         (TestShell::TestShell): Use set again instead of =.
2579
2580 2010-06-17  Darin Adler  <darin@apple.com>
2581
2582         Fix Chromium build.
2583
2584         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2585         code with all the other platforms! Wow, that should be fixed at some point.
2586
2587         * DumpRenderTree/chromium/TestShell.cpp:
2588         (TestShell::TestShell): Changed back to using "new".
2589         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2590
2591 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2592
2593         Unreviewed Qt build fix.
2594
2595         LayoutTestController in the Qt DRT is not using refs :)
2596
2597         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2598         (WebCore::DumpRenderTree::DumpRenderTree):
2599
2600 2010-06-17  Darin Adler  <darin@apple.com>
2601
2602         Reviewed by Sam Weinig.
2603
2604         Use adoptRef and create functions in more code paths
2605         https://bugs.webkit.org/show_bug.cgi?id=40760
2606
2607         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2608
2609         * DumpRenderTree/LayoutTestController.cpp:
2610         (LayoutTestController::create): Added.
2611         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2612
2613         * DumpRenderTree/chromium/TestShell.cpp:
2614         (TestShell::TestShell): Use create instead of new.
2615         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2616
2617         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2618         (runTest): Use RefPtr and create instead of OwnPtr and new.
2619
2620         * DumpRenderTree/mac/DumpRenderTree.mm:
2621         (runTest): Use RefPtr and create instead of OwnPtr and new.
2622
2623         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2624         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
2625         instead of new.
2626
2627         * DumpRenderTree/win/DumpRenderTree.cpp:
2628         (runTest): Use RefPtr and create instead of OwnPtr and new.
2629
2630         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2631         (runTest): Use RefPtr and create instead of OwnPtr and new.
2632         (MyApp::OnInit): Removed unneeded code to delete the layout
2633         test controller. This is done during each test.
2634
2635 2010-06-17  Kent Tamura  <tkent@chromium.org>
2636
2637         Reviewed by Shinichiro Hamaji.
2638
2639         [DRT/Chromium] Fix a bug of Windows pixel tests
2640         https://bugs.webkit.org/show_bug.cgi?id=40763
2641
2642         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2643         (TestShellPrinter::handleImage):
2644
2645 2010-06-16  Kent Tamura  <tkent@chromium.org>
2646
2647         Reviewed by Shinichiro Hamaji.
2648
2649         [DRT/Chromium] Fix crash on Mac Release
2650         https://bugs.webkit.org/show_bug.cgi?id=40759
2651
2652         * DumpRenderTree/chromium/WebViewHost.cpp:
2653         (WebViewHost::paintRect): We should not use m_canvas directly because
2654           it is created lazily in canvas().
2655
2656 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2657
2658         [wx] Build fix after new method addition.
2659
2660         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2661         (LayoutTestController::pageProperty):
2662
2663 2010-06-16  Kent Tamura  <tkent@chromium.org>
2664
2665         Reviewed by Dimitri Glazkov.
2666
2667         [DRT/Chromium] Set current working directory for each of tests
2668         https://bugs.webkit.org/show_bug.cgi?id=40668
2669
2670         This change fixes tests with eventSender.beginDragWithFiles().
2671
2672         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2673         (runTest):
2674
2675 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2676
2677         Reviewed by Gustavo Noronha Silva.
2678
2679         [GTK] r60803 broke media/controls-drag-timebar.html
2680         https://bugs.webkit.org/show_bug.cgi?id=40269
2681
2682         Only queue events while the mouse button is down, if drag mode is enabled. Some
2683         tests may disable drag mode, to prevent the queuing of events in this situation.
2684
2685         * DumpRenderTree/gtk/EventSender.cpp:
2686         (sendOrQueueEvent): Only queue events here if dragMode is true.
2687
2688 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2689
2690         Reviewed by Gustavo Noronha Silva.
2691
2692         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
2693         https://bugs.webkit.org/show_bug.cgi?id=40600
2694
2695         * DumpRenderTree/gtk/EventSender.cpp:
2696         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
2697
2698 2010-06-16  Adam Barth  <abarth@webkit.org>
2699
2700         Reviewed by Dimitri Glazkov.
2701
2702         Add a hidden land-cowboy command to webkit-patch to help land quick
2703         build fixes.
2704
2705         * Scripts/webkitpy/tool/commands/download.py:
2706         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2707
2708 2010-06-16  Adam Roben  <aroben@apple.com>
2709
2710         Convert console messages to UTF-8 before printing them
2711
2712         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
2713         http/tests/security/xssAuditor/embed-tag-null-char.html and
2714         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
2715         Windows. (I can't test the fix because Apache is crashing on my
2716         computer.)
2717
2718         Reviewed by Alexey Proskuryakov.
2719
2720         * DumpRenderTree/win/DumpRenderTree.cpp:
2721         (toUTF8): Extracted the code into an overload that takes a wide string
2722         and a length, then added an overload that takes a wstring.
2723
2724         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
2725         overload.
2726
2727         * DumpRenderTree/win/UIDelegate.cpp:
2728         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
2729         UTF-8 instead of letting printf convert to the current code page.
2730
2731 2010-06-16  Drew Wilson  <atwilson@chromium.org>
2732
2733         Reviewed by Kent Tamura.
2734
2735         [Chromium] Plumbing for top-level frame names
2736         https://bugs.webkit.org/show_bug.cgi?id=40430
2737
2738         * DumpRenderTree/chromium/WebViewHost.cpp:
2739         (WebViewHost::createView):
2740         Migrate to new createView() API.
2741         * DumpRenderTree/chromium/WebViewHost.h:
2742         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
2743
2744 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
2745
2746         Reviewed by Kenneth Rohde Christiansen.
2747
2748         [Qt] Scroll wheel event support to graphics based DRT
2749         https://bugs.webkit.org/show_bug.cgi?id=40577
2750
2751         * DumpRenderTree/qt/EventSenderQt.cpp:
2752         (EventSender::continuousMouseScrollBy):
2753         (EventSender::createGraphicsSceneWheelEvent):
2754         * DumpRenderTree/qt/EventSenderQt.h:
2755
2756 2010-06-16  Adam Roben  <aroben@apple.com>
2757
2758         Remove a stray newline from the Windows version of TestNetscapePlugin
2759
2760         Reviewed by Alexey Proskuryakov.
2761
2762         Fixes <http://webkit.org/b/40728>
2763         plugins/geturlnotify-during-document-teardown.html fails on Windows
2764
2765         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2766         (NPP_Destroy): Removed extra newline that the Mac version doesn't
2767         have.
2768
2769 2010-06-16  Adam Roben  <aroben@apple.com>
2770
2771         Respect LayoutTestController::isPrinting on Windows
2772
2773         This gets some printing tests closer to passing (like
2774         printing/page-rule-in-media-query.html).
2775
2776         Fixes <http://webkit.org/b/40727>.
2777
2778         Reviewed by Dan Bernstein.
2779
2780         * DumpRenderTree/win/DumpRenderTree.cpp:
2781         (dump): Pass LayoutTestController::isPrinting to
2782         IWebFramePrivate::renderTreeAsExternalRepresentation.
2783
2784 2010-06-15  Adam Barth  <abarth@webkit.org>
2785
2786         Reviewed by Eric Seidel.
2787
2788         Enable HTML5 lexer
2789         https://bugs.webkit.org/show_bug.cgi?id=40650
2790
2791         * DumpRenderTree/mac/DumpRenderTree.mm:
2792         (initializeGlobalsFromCommandLineOptions):
2793
2794 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
2795
2796         Reviewed by Shinichiro Hamaji.
2797
2798         Implement render style selection for pages to support CSS3 Paged Media.
2799         https://bugs.webkit.org/show_bug.cgi?id=35961
2800
2801         * DumpRenderTree/LayoutTestController.cpp:
2802         (parsePagePropertyParameters):
2803         (pagePropertyCallback):
2804         (LayoutTestController::staticFunctions):
2805         * DumpRenderTree/LayoutTestController.h:
2806         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2807         (LayoutTestController::pageProperty):
2808         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2809         (LayoutTestController::pageProperty):
2810         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2811         (LayoutTestController::pageProperty):
2812
2813 2010-06-15  Sam Weinig  <sam@webkit.org>
2814
2815         Reviewed by Anders Carlsson.
2816
2817         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
2818         WebKit2: Add mechanism to inject code into the WebProcess on startup
2819
2820         Add initial InjectedBundle support.
2821
2822         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2823         * MiniBrowser/WebBundle-Info.plist: Added.
2824         Add test InjectedBundle to the project.
2825
2826         * MiniBrowser/mac/AppDelegate.m:
2827         (-[BrowserAppDelegate init]):
2828         Get the path to the WebBundle from the the main bundle and pass it to the new
2829         WKContextCreateWithInjectedBundlePath function.
2830
2831         * MiniBrowser/mac/BrowserWindowController.m:
2832         (_didChangeProgress):
2833         Fix the build.  This has been broken for a while.
2834
2835         * MiniBrowser/mac/WebBundle: Added.
2836         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
2837         (_didCreatePage):
2838         (WKBundleInitialize):
2839         Add really basic InjectedBundle.
2840
2841         * MiniBrowser/win/BrowserView.cpp:
2842         (BrowserView::create):
2843         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
2844
2845 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
2846
2847         Reviewed by Darin Adler.
2848
2849         Adding myself to the reviewers list.
2850         https://bugs.webkit.org/show_bug.cgi?id=40693
2851
2852         * Scripts/webkitpy/common/config/committers.py:
2853
2854 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
2855
2856         Reviewed by Xan Lopez.
2857
2858         Switch to using GIO methods instead of realpath in GtkLauncher to determine
2859         the file URI. This should remove warnings about realpath being undefined
2860         when compiling with '-ansi'.
2861
2862         * GtkLauncher/main.c:
2863         (filenameToURL): Use GIO instead of realpath to determine file URI.
2864
2865 2010-06-15  Adam Roben  <aroben@apple.com>
2866
2867         Remove the redundant set-apple-windows-environment-variables script
2868
2869         Apparently update-webkit does this for you these days.
2870
2871         Rubber-stamped by Steve Falkenburg.
2872
2873         * Scripts/set-apple-windows-environment-variables: Removed.
2874
2875 2010-06-14  Adam Roben  <aroben@apple.com>
2876
2877         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
2878         environment variables
2879
2880         Fixes <http://webkit.org/b/40595>.
2881
2882         Reviewed by Steve Falkenburg.
2883
2884         * Scripts/set-apple-windows-environment-variables: Added.
2885         (to_windows_path): Passes the passed-in path through cygpath to
2886         generate a Windows-style path.
2887         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
2888         variables to their defaults, if they aren't already set.
2889
2890 2010-06-14  Adam Roben  <aroben@apple.com>
2891
2892         Speed up run-safari/debug-safari on Windows
2893
2894         Fixes <http://webkit.org/b/40586>.
2895
2896         Reviewed by Steve Falkenburg.
2897
2898         * Scripts/webkitdirs.pm:
2899         (runSafari): When debugging, set up the environment to run Safari
2900         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
2901         actually launch the debugger. When not debugging, just run WebKit.exe
2902         and it will do the rest for us.
2903
2904 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
2905
2906         Reviewed by Kenneth Rohde Christiansen.
2907
2908         [Qt] DRT EventSender support to graphics context events
2909         https://bugs.webkit.org/show_bug.cgi?id=40324
2910
2911         * DumpRenderTree/qt/EventSenderQt.cpp:
2912         (EventSender::contextClick):
2913
2914 2010-06-14  Tony Chang  <tony@chromium.org>
2915
2916         Reviewed by Darin Fisher.
2917
2918         [chromium] checkout chromium third_party directly
2919         https://bugs.webkit.org/show_bug.cgi?id=40556
2920
2921         * Scripts/update-webkit-chromium: some migration code for the bots
2922
2923 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2924
2925         Chromium build fix.
2926
2927         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
2928         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
2929
2930 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2931
2932         Reviewed by Darin Adler.
2933
2934         https://bugs.webkit.org/show_bug.cgi?id=40529
2935         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
2936
2937         * DumpRenderTree/mac/EventSendingController.mm:
2938         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
2939         event for "delete" - it had virtual key code from forward delete, and text from backspace.
2940         Fixed "delete" to mean forward delete.
2941
2942         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
2943         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
2944         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2945         Mac DRT confusion has propagated to other platforms, fixing those.
2946
2947 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
2948
2949         Reviewed by Xan Lopez.
2950
2951         Small GtkLauncher build fix for some systems.
2952
2953         * GtkLauncher/main.c: Add <limit.h> include.
2954
2955 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2956
2957         Reviewed by Laszlo Gombos.
2958
2959         [Qt] navigator.geolocation support for Qt port
2960         https://bugs.webkit.org/show_bug.cgi?id=39724
2961
2962         Implementation for geolocation cases to DumpRenderTreeQt
2963
2964         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2965         (WebCore::WebPage::allowGeolocationRequest):
2966         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2967         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2968         (LayoutTestController::setGeolocationPermission):
2969         (LayoutTestController::setMockGeolocationError):
2970         (LayoutTestController::setMockGeolocationPosition):
2971         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2972         (LayoutTestController::isGeolocationPermissionSet):
2973         (LayoutTestController::geolocationPermission):
2974
2975 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
2976
2977         Reviewed by Darin Adler.
2978
2979         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
2980         be a way of overwriting the Xcode system path.  Making
2981         $WEBKITOUTPUTDIR take precedence over the system default would make
2982         this possible.
2983
2984         * Scripts/webkitdirs.pm:
2985
2986 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
2987
2988         Reviewed by Darin Adler.
2989
2990         AX: link won't return linked element if URL contains #
2991         https://bugs.webkit.org/show_bug.cgi?id=40192
2992
2993         * DumpRenderTree/AccessibilityUIElement.cpp:
2994         (linkedUIElementAtIndexCallback):
2995         (AccessibilityUIElement::getJSClass):
2996         * DumpRenderTree/AccessibilityUIElement.h:
2997         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2998         (AccessibilityUIElement::linkedUIElementAtIndex):
2999         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3000         (AccessibilityUIElement::linkedUIElementAtIndex):
3001         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3002         (AccessibilityUIElement::linkedUIElementAtIndex):
3003
3004 2010-06-13  Adam Barth  <abarth@webkit.org>
3005
3006         Reviewed by Darin Adler.
3007
3008         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3009         https://bugs.webkit.org/show_bug.cgi?id=39550
3010
3011         This can cause an extra request to bugs.webkit.org durig upload, but it
3012         shouldn't be too bad.  Also, this won't work if you remove the
3013         boilerplate created by prepare-ChangeLog.
3014
3015         * Scripts/webkitpy/common/checkout/changelog.py:
3016         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3017         * Scripts/webkitpy/common/net/bugzilla.py:
3018         * Scripts/webkitpy/tool/steps/abstractstep.py:
3019         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3020         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3021
3022 2010-06-08  Robert Hogan  <robert@webkit.org>
3023
3024         Reviewed by Eric Seidel.
3025
3026         [Qt] Add support for callShouldCloseOnWebView() to DRT
3027         https://bugs.webkit.org/show_bug.cgi?id=40330
3028
3029         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3030         (LayoutTestController::callShouldCloseOnWebView):
3031         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3032         (LayoutTestController::setCallCloseOnWebViews):
3033
3034 2010-06-12  Eric Seidel  <eric@webkit.org>
3035
3036         Reviewed by Daniel Bates.
3037
3038         do-webcore-rename should have a --verbose option
3039         https://bugs.webkit.org/show_bug.cgi?id=40497
3040
3041         * Scripts/do-webcore-rename:
3042          - Unified how we handle skipping files/directories
3043            this will allow us to "black list" certain files and
3044            directories when performing renames.
3045          - Made do-webcore-rename log what it's skipping when passed --verbose.
3046
3047 2010-06-12  Darin Adler  <darin@apple.com>
3048
3049         * Scripts/run-bindings-tests: Fixed a typo in a message.
3050
3051 2010-06-12  Kent Tamura  <tkent@chromium.org>
3052
3053         Reviewed by Dimitri Glazkov.
3054
3055         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3056         https://bugs.webkit.org/show_bug.cgi?id=40402
3057
3058         _build_path() of each Chromium port check existence of build path
3059         of Chromium checkout first, then check existence of build path of
3060         WebKit-only checkout.
3061
3062         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3063         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3064         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3065
3066 2010-06-12  Robert Hogan  <robert@webkit.org>
3067
3068         Reviewed by Kenneth Rohde Christiansen.
3069
3070         [Qt] Back-forward list dumping is incorrect
3071
3072         https://bugs.webkit.org/show_bug.cgi?id=36392
3073
3074         Support dumping child history items in DRT.
3075
3076         Unskip:
3077
3078         fast/loader/frame-src-change-added-to-history.html
3079         fast/loader/frame-src-change-not-added-to-history.html
3080         fast/loader/frame-location-change-not-added-to-history.html
3081
3082         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3083         (WebCore::dumpHistoryItem):
3084
3085 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3086
3087         Reviewed by Eric Seidel.
3088
3089         upload all patches that lack in-rietveld to rietveld
3090         https://bugs.webkit.org/show_bug.cgi?id=40444
3091
3092         If it's a patch, then we'll try to upload it as long as it
3093         doesn't have in-rietveld set. No longer set in-rietveld? since
3094         it's not needed.
3095
3096         * Scripts/webkitpy/common/net/bugzilla.py:
3097
3098 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3099
3100         Reviewed by Darin Fisher.
3101
3102         Fix rietveld upload when message length > 100 characters
3103         https://bugs.webkit.org/show_bug.cgi?id=40457
3104
3105         * Scripts/webkitpy/common/net/rietveld.py:
3106
3107 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3108
3109         Reviewed by Laszlo Gombos.
3110
3111         [Qt] There should be a way to enable popups in QtTestBrowser
3112         https://bugs.webkit.org/show_bug.cgi?id=40427
3113
3114         * QtTestBrowser/main.cpp:
3115         (LauncherWindow::toggleJavascriptCanOpenWindows):
3116         (LauncherWindow::createChrome):
3117
3118 2010-06-10  Adam Barth  <abarth@webkit.org>
3119
3120         Reviewed by Daniel Bates.
3121
3122         Make SheriffBot more chatty
3123         https://bugs.webkit.org/show_bug.cgi?id=40463
3124
3125         People seem to like to talk to SheriffBot, so let's make him chat back.
3126
3127         * Scripts/webkitpy/thirdparty/__init__.py:
3128         * Scripts/webkitpy/tool/bot/irc_command.py:
3129         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3130         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3131         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3132
3133 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3134
3135         Reviewed by Darin Adler.
3136
3137         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3138         
3139         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3140         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3141         WEXITSTATUS on $result instead of just comparing $result to 0.
3142
3143         * Scripts/update-webkit-auxiliary-libs:
3144
3145 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3146
3147         Reviewed by Alexey Proskuryakov.
3148
3149         don't use Exception.message as it's deprecated in python 2.6+
3150         https://bugs.webkit.org/show_bug.cgi?id=40449
3151
3152         * Scripts/webkitpy/tool/commands/queues.py:
3153
3154 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3155
3156         Reviewed by Adam Barth.
3157
3158         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3159         https://bugs.webkit.org/show_bug.cgi?id=40436
3160
3161         * Scripts/webkitpy/common/system/outputcapture.py:
3162         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3163         * Scripts/webkitpy/tool/commands/queues.py:
3164         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3165         * Scripts/webkitpy/tool/commands/queuestest.py:
3166         * Scripts/webkitpy/tool/mocktool.py:
3167
3168 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3169
3170         Reviewed by Simon Hausmann.
3171
3172         [Qt] *All* WebGL layout tests fail!
3173         https://bugs.webkit.org/show_bug.cgi?id=40296
3174
3175         Added test for WebKitWebGLEnabled to
3176         LayoutTestController::overridePreference().
3177
3178         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3179         (LayoutTestController::overridePreference):
3180
3181 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3182
3183         Reviewed by Kenneth Rohde Christiansen.
3184
3185         [Qt] DRT EventSender support to graphics mouse events activation
3186         https://bugs.webkit.org/show_bug.cgi?id=40017
3187
3188         * DumpRenderTree/qt/EventSenderQt.cpp:
3189         (EventSender::mouseDown):
3190         (EventSender::mouseUp):
3191         (EventSender::mouseMoveTo):
3192         (EventSender::keyDown):
3193         (EventSender::contextClick):
3194         (EventSender::sendTouchEvent):
3195         (EventSender::sendOrQueueEvent):
3196         (EventSender::eventFilter):
3197         (EventSender::createGraphicsSceneMouseEvent):
3198         (EventSender::sendEvent):
3199         * DumpRenderTree/qt/EventSenderQt.h:
3200         (EventSender::isGraphicsBased):
3201
3202 2010-06-09  Adam Barth  <abarth@webkit.org>
3203
3204         Reviewed by Ojan Vafai.
3205
3206         webkit-patch upload fails for security bugs because there's no rietveld flag
3207         https://bugs.webkit.org/show_bug.cgi?id=40309
3208
3209         There's probably a more elegant way of seeing whether the form control
3210         exists, but this seems to work.
3211
3212         * Scripts/webkitpy/common/net/bugzilla.py:
3213
3214 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3215
3216         Reviewed by Adam Barth.
3217
3218         make rietveld upload faster and avoid posting to bug on errors
3219         https://bugs.webkit.org/show_bug.cgi?id=40389
3220
3221         Only grab the first item of the upload queue instead of trying
3222         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3223
3224         Also, don't post comments to the bug when uploading fails.
3225
3226         * Scripts/webkitpy/common/net/bugzilla.py:
3227         * Scripts/webkitpy/tool/commands/queues.py:
3228         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3229         * Scripts/webkitpy/tool/commands/stepsequence.py:
3230         * Scripts/webkitpy/tool/mocktool.py:
3231
3232 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3233
3234         Reviewed by Adam Barth.
3235
3236         Rietveld upload queue fails when setting in-rietveld flag
3237         https://bugs.webkit.org/show_bug.cgi?id=40371
3238
3239         Make the comment arguments to set_flag_on_attachment optional
3240         and add it to the MockBugzilla.
3241
3242         * Scripts/webkitpy/common/net/bugzilla.py:
3243         * Scripts/webkitpy/tool/bot/queueengine.py:
3244         * Scripts/webkitpy/tool/commands/download_unittest.py:
3245         * Scripts/webkitpy/tool/commands/queues.py:
3246         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3247         * Scripts/webkitpy/tool/mocktool.py:
3248
3249 2010-06-09  Kenneth Russell  <kbr@google.com>
3250
3251         Reviewed by Dimitri Glazkov.
3252
3253         Rename FloatArray to Float32Array
3254         https://bugs.webkit.org/show_bug.cgi?id=40323
3255
3256         Used do-webcore-rename to perform renaming. Manually undid
3257         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3258         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3259         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3260         all layout tests on Safari; built Chromium and ran selected WebGL
3261         tests.
3262
3263         * Scripts/do-webcore-rename:
3264
3265 2010-06-08  Tony Chang  <tony@chromium.org>
3266
3267         Reviewed by David Levin.
3268
3269         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3270         https://bugs.webkit.org/show_bug.cgi?id=40285
3271
3272         * Scripts/webkitdirs.pm:
3273         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3274
3275 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3276
3277         Reviewed by Tamura Kent.
3278
3279         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3280         https://bugs.webkit.org/show_bug.cgi?id=40052
3281         
3282         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3283
3284         * DumpRenderTree/DumpRenderTree.gypi:
3285         * DumpRenderTree/chromium/TestShellWin.cpp:
3286         (platformInit):
3287         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3288         (WebKit::):
3289         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3290         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3291         (WebKit::WebThemeControlDRT::box):
3292         (WebKit::WebThemeControlDRT::line):
3293         (WebKit::WebThemeControlDRT::triangle):
3294         (WebKit::WebThemeControlDRT::roundRect):
3295         (WebKit::WebThemeControlDRT::oval):
3296         (WebKit::WebThemeControlDRT::circle):
3297         (WebKit::WebThemeControlDRT::nestedBoxes):
3298         (WebKit::WebThemeControlDRT::markState):
3299         (WebKit::WebThemeControlDRT::draw):
3300         (WebKit::WebThemeControlDRT::drawTextField):
3301         (WebKit::WebThemeControlDRT::drawProgressBar):
3302         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3303         (WebKit::WebThemeControlDRT::):
3304         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3305         (WebKit::):
3306         (WebKit::WebThemeEngineDRT::paintButton):
3307         (WebKit::WebThemeEngineDRT::paintMenuList):
3308         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3309         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3310         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3311         (WebKit::WebThemeEngineDRT::paintTextField):
3312         (WebKit::WebThemeEngineDRT::paintTrackbar):
3313         (WebKit::WebThemeEngineDRT::paintProgressBar):
3314         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3315         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3316
3317 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3318
3319         Unreviewed, rolling out r60878.
3320         http://trac.webkit.org/changeset/60878
3321         https://bugs.webkit.org/show_bug.cgi?id=40349
3322
3323         broke linux build (Requested by tony^work on #webkit).
3324
3325         * Scripts/webkitdirs.pm:
3326         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3327
3328 2010-06-08  Tony Chang  <tony@chromium.org>
3329
3330         Reviewed by David Levin.
3331
3332         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3333         https://bugs.webkit.org/show_bug.cgi?id=40285
3334
3335         * Scripts/webkitdirs.pm:
3336         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3337
3338 2010-06-08  Kenneth Russell  <kbr@google.com>
3339
3340         Unreviewed, build fix.
3341
3342         Fix build breakage from 38145
3343         https://bugs.webkit.org/show_bug.cgi?id=40346
3344
3345         The fix for bug 38145 broke the Chromium Win build because
3346         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3347         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3348         tests in Safari on Mac OS X. Changed download mirrors for
3349         python-irclib to working ones.
3350
3351         * Scripts/webkitpy/thirdparty/__init__.py:
3352
3353 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3354
3355         Reviewed by Eric Seidel.
3356
3357         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3358         https://bugs.webkit.org/show_bug.cgi?id=39058
3359
3360         * Scripts/old-run-webkit-tests:
3361          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3362
3363 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3364
3365         Unreviewed buildfix after r60479.
3366
3367         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3368         versions other than 2.17.3.
3369
3370         * DumpRenderTree/gtk/EventSender.cpp:
3371         (getRootCoords):
3372
3373 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3374
3375         Reviewed by Oliver Hunt.
3376
3377         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3378         https://bugs.webkit.org/show_bug.cgi?id=40267
3379
3380         When a mouse button is down, automatically queue mouse motion events and
3381         do not play them back until the mouse button is released. This matches the
3382         behavior of other ports' EventSenders.
3383
3384         * DumpRenderTree/gtk/EventSender.cpp:
3385         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3386         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3387
3388 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3389
3390         Reviewed by Sam Weinig.
3391
3392         Add CPP bindings generator
3393         https://bugs.webkit.org/show_bug.cgi?id=38279
3394
3395         Integrate CPP bindings in run-bindings-tests.
3396
3397         * Scripts/run-bindings-tests:
3398
3399 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3400
3401         Reviewed by Ojan Vafai.
3402
3403         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3404         https://bugs.webkit.org/show_bug.cgi?id=40183
3405
3406         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3407
3408 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3409
3410         Unreviewed.
3411
3412         Add my new email and IRC nick to committers.py.
3413
3414         * Scripts/webkitpy/common/config/committers.py:
3415
3416 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
3417
3418         Unreviewed.
3419
3420         Revert changes in json_results_generator.py's _get_svn_revision.
3421
3422         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3423
3424 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3425
3426         Reviewed by Xan Lopez.
3427
3428         [GTK] GtkLauncher should support relative file paths
3429         https://bugs.webkit.org/show_bug.cgi?id=39944
3430
3431         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
3432
3433         * GtkLauncher/main.c:
3434         (filename_to_url): Added.
3435         (main): Try to resolve arguments as relative file URLs first.
3436
3437 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3438
3439         Reviewed by Xan Lopez.
3440
3441         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
3442         https://bugs.webkit.org/show_bug.cgi?id=40182
3443
3444         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
3445         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
3446         without breaking DRT.
3447
3448         * DumpRenderTree/gtk/EventSender.cpp:
3449         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
3450         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
3451
3452 2010-06-04  Anders Carlsson  <andersca@apple.com>
3453
3454         Reviewed by David Hyatt.
3455
3456         Make the editing/spelling/context-menu-suggestions.html test more robust
3457         https://bugs.webkit.org/show_bug.cgi?id=40178
3458
3459         Change the contextClick method to return an array of strings describing the context menu items.
3460
3461         * DumpRenderTree/mac/EventSendingController.mm:
3462         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3463         (+[EventSendingController webScriptNameForSelector:]):
3464         (-[EventSendingController contextClick]):
3465
3466 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
3467
3468         Reviewed by Shinichiro Hamaji.
3469
3470         Clean up chromium-specific code from json_results_generator.py.
3471         https://bugs.webkit.org/show_bug.cgi?id=39665
3472
3473         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3474         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3475         * Scripts/webkitpy/layout_tests/port/base.py:
3476         * Scripts/webkitpy/layout_tests/port/chromium.py:
3477
3478 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3479
3480         Reviewed by Adam Barth.
3481
3482         Utilize new takeFirst() method where appropriate.
3483         https://bugs.webkit.org/show_bug.cgi?id=40089
3484
3485         * DumpRenderTree/chromium/EventSender.cpp:
3486         (EventSender::replaySavedEvents):
3487         * DumpRenderTree/chromium/LayoutTestController.cpp:
3488         (LayoutTestController::WorkQueue::processWork):
3489         (LayoutTestController::WorkQueue::reset):
3490
3491 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
3492
3493         Reviewed by Simon Hausmann.
3494
3495         [Qt] QtTestLauncher should allow notifications by default.
3496         https://bugs.webkit.org/show_bug.cgi?id=40078
3497
3498         * QtTestBrowser/main.cpp:
3499         (NotificationsPermissionController::NotificationsPermissionController):
3500         (NotificationsPermissionController::checkPermission):
3501         (NotificationsPermissionController::requestPermission):
3502         (LauncherWindow::LauncherWindow):
3503
3504 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3505
3506         Reviewed by Adam Barth.
3507
3508         Detect whether the user's environment can open a browser.
3509         https://bugs.webkit.org/show_bug.cgi?id=40136
3510
3511         Some environments like cygwin silently fail webbrowser.open() causing
3512         webkit-patch upload not to display any diff. This detects environments
3513         where webbrowser.open() would fail by testing if webbrowser.get()
3514         raises an exception.
3515
3516         * Scripts/webkitpy/common/system/user.py:
3517         * Scripts/webkitpy/tool/mocktool.py:
3518         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3519
3520 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
3521
3522         Reviewed by David Levin.
3523
3524         Add dependencies required to link with VS Express 2005.
3525         https://bugs.webkit.org/show_bug.cgi?id=40038
3526
3527         Visual Studio implicitly links against these libs.
3528         VC++ Express does not.
3529
3530         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3531         * WinLauncher/WinLauncher.vcproj:
3532
3533 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3534
3535         Reviewed by David Levin.
3536
3537         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
3538         https://bugs.webkit.org/show_bug.cgi?id=40105
3539
3540         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3541         - kill pywebsocket process when url is not alive and the process is not
3542           terminated, not to leave pywebsocket server running.
3543         - fix codecs.open parameters.
3544
3545 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3546
3547         Reviewed by Alexey Proskuryakov.
3548
3549         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3550         https://bugs.webkit.org/show_bug.cgi?id=39058
3551
3552         * Scripts/ensure-valid-python:
3553           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
3554           - Add --check-only and --help option.
3555           - --check-only option only checks python version and don't try to install Python 2.5.
3556           - Set executable bit.
3557         * Scripts/old-run-webkit-tests:
3558           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
3559
3560 2010-05-14  Ojan Vafai  <ojan@chromium.org>
3561
3562         Reviewed by Adam Barth.
3563
3564         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
3565         https://bugs.webkit.org/show_bug.cgi?id=38918
3566
3567         Patches with in-rietveld? get uploaded to rietveld and get marked
3568         in-rietveld+. If the upload fails, they are marked in-rietveld-
3569         and an error is logged to the bug, like the commit-queue.
3570
3571         Also, get rid of --fancy-review and the ability to upload to rietveld
3572         using webkit-patch upload/post.
3573
3574         * Scripts/webkitpy/common/net/bugzilla.py:
3575         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3576         * Scripts/webkitpy/tool/commands/download.py:
3577         * Scripts/webkitpy/tool/commands/download_unittest.py:
3578         * Scripts/webkitpy/tool/commands/queues.py:
3579         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3580         * Scripts/webkitpy/tool/commands/upload.py:
3581         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3582         * Scripts/webkitpy/tool/mocktool.py:
3583         * Scripts/webkitpy/tool/steps/options.py:
3584         * Scripts/webkitpy/tool/steps/postcodereview.py:
3585
3586 2010-05-24  Ojan Vafai  <ojan@chromium.org>
3587
3588         Reviewed by Chris Jerdonek.
3589
3590         many webkit-patch commands fail in a non-svn tracking git checkout
3591         https://bugs.webkit.org/show_bug.cgi?id=38156
3592
3593         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
3594         If neither exists, then error out. This makes webkit-patch work
3595         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
3596         to checkout webkit. The fallback to master is for people who don't
3597         do the steps on that page for tracking svn.
3598
3599         * Scripts/webkitpy/common/checkout/scm.py:
3600         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3601
3602 2010-06-03  Mike Fenton  <mifenton@rim.com>
3603
3604         Unreviewed.
3605
3606         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
3607
3608         * Scripts/webkitpy/common/config/committers.py:
3609
3610 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
3611
3612         Reviewed by Yury Semikhatsky.
3613
3614         Web Inspector: a number of fixes that make InspectorController
3615         happy with null redirects.
3616
3617         https://bugs.webkit.org/show_bug.cgi?id=40109
3618
3619         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3620         (runTest):
3621         * DumpRenderTree/mac/DumpRenderTree.mm:
3622         (runTest):
3623         * DumpRenderTree/win/DumpRenderTree.cpp:
3624         (runTest):
3625
3626 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
3627
3628         Reviewed by Shinichiro Hamaji.
3629
3630         [Qt] Fix compilation with QT_NO_PROPERTIES
3631         https://bugs.webkit.org/show_bug.cgi?id=38324
3632
3633         * QtTestBrowser/main.cpp:
3634         (LauncherWindow::init):
3635
3636 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
3637
3638         Reviewed by Kenneth Rohde Christiansen.
3639
3640         [Qt] Make possible run DRT with QGraphicsWebView
3641         https://bugs.webkit.org/show_bug.cgi?id=40016
3642
3643         Make possible to use a environment variable for switching backend.
3644         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
3645
3646         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3647         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
3648         (WebCore::DumpRenderTree::DumpRenderTree):
3649         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3650         (WebCore::DumpRenderTree::setGraphicsBased):
3651         (WebCore::DumpRenderTree::isGraphicsBased):
3652         (WebCore::WebViewGraphicsBased::graphicsView):
3653         (WebCore::WebViewGraphicsBased::setPage):
3654         * Scripts/old-run-webkit-tests:
3655
3656 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
3657
3658         Reviewed by Eric Seidel.
3659
3660         Slave lost shouldn't be recognized as build failed.
3661         https://bugs.webkit.org/show_bug.cgi?id=39282
3662
3663         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
3664         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
3665
3666 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
3667
3668         Reviewed by Kenneth Rohde Christiansen.
3669
3670         [Qt] Fix the lifecycle of notification objects
3671         https://bugs.webkit.org/show_bug.cgi?id=40003
3672
3673         Remove the dependency of notifications on QWebPage.
3674
3675         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3676         (WebCore::requestPermissionCallback):
3677         (WebCore::WebPage::WebPage):
3678         (WebCore::DumpRenderTree::requestPermission):
3679         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3680
3681 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3682
3683         Unreviewed, rolling out r60559.
3684         http://trac.webkit.org/changeset/60559
3685         https://bugs.webkit.org/show_bug.cgi?id=40055
3686
3687         It broke python unit test (Requested by Ossy on #webkit).
3688
3689         * Scripts/webkitpy/common/net/buildbot.py:
3690
3691 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
3692
3693         Reviewed by Eric Seidel.
3694
3695         Slave lost shouldn't be recognized as build failed.
3696         https://bugs.webkit.org/show_bug.cgi?id=39282
3697
3698         * Scripts/webkitpy/common/net/buildbot.py:
3699
3700 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
3701
3702         Reviewed by Eric Seidel.
3703
3704         Fix crash caused when assigned_to is disabled
3705         https://bugs.webkit.org/show_bug.cgi?id=40039
3706
3707         * Scripts/webkitpy/common/net/bugzilla.py:
3708
3709 2010-06-02  Sterling Swigart  <sswigart@google.com>
3710
3711         Reviewed by David Levin.
3712
3713         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
3714         https://bugs.webkit.org/show_bug.cgi?id=39906
3715
3716         * Scripts/build-webkit:
3717
3718 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
3719
3720         Reviewed by Simon Hausmann.
3721
3722         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
3723
3724         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3725         (WebCore::WebPage::WebPage):
3726         (WebCore::WebPage::resetSettings):
3727         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3728         (LayoutTestController::setJavaScriptCanAccessClipboard):
3729
3730 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3731
3732         Reviewed by Mark Rowe.
3733
3734         A nicer Tiger build fix.
3735
3736         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3737         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3738         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
3739
3740 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3741
3742         A real Tiger build fix.
3743
3744         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
3745         for all configurations, not just debug.
3746
3747 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3748
3749         Tiger build fix.
3750
3751         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
3752
3753 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3754
3755         Reviewed by Xan Lopez.
3756
3757         [GTK] Get more mouse tests passing
3758         https://bugs.webkit.org/show_bug.cgi?id=39040
3759
3760         Reproduce the logic from the Windows EventSender for mapping
3761         button numbers to GDK button numbers. Move this logic to the
3762         prepareMouseButtonEvent helper.
3763
3764         * DumpRenderTree/gtk/EventSender.cpp:
3765         (prepareMouseButtonEvent): Reproduce Windows logic.
3766         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
3767         (mouseDownCallback): Ditto.
3768         (mouseUpCallback): Ditto.
3769
3770 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3771
3772         Reviewed by Sam Weinig.
3773
3774         https://bugs.webkit.org/show_bug.cgi?id=39434
3775         REGRESSION (r59811): Geolocation callbacks cannot be created
3776
3777         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
3778
3779         * DumpRenderTree/mac/DumpRenderTree.mm:
3780         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
3781         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
3782         into subsequent tests.
3783
3784         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3785         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
3786         (LayoutTestController::setMockGeolocationError): Ditto.
3787
3788         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
3789         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
3790         (+[MockGeolocationProvider shared]):
3791         (-[MockGeolocationProvider dealloc]):
3792         (-[MockGeolocationProvider setPosition:]):
3793         (-[MockGeolocationProvider setError:]):
3794         (-[MockGeolocationProvider registerWebView:]):
3795         (-[MockGeolocationProvider unregisterWebView:]):
3796         (-[MockGeolocationProvider lastPosition]):
3797         (-[MockGeolocationProvider stopTimer]):
3798         (-[MockGeolocationProvider timerFired]):
3799
3800         * DumpRenderTree/mac/UIDelegate.mm:
3801         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3802         This delegate method must send a response. I'm not sure what the two-stage check is supposed
3803         to achieve, it seems unnecessary.
3804
3805 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
3806
3807         Reviewed by Xan Lopez.
3808
3809         [GTK] Double clicks cause three button press events
3810         https://bugs.webkit.org/show_bug.cgi?id=38853
3811
3812         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
3813         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
3814         the GDK event queue entirely, we simply do not send the extra event.
3815
3816         * DumpRenderTree/gtk/EventSender.cpp:
3817         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
3818         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
3819
3820 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3821
3822         Not reviewed. Build fix.
3823
3824         Fix GTK+ build caused by a bad merge.
3825
3826         * DumpRenderTree/gtk/EventSender.cpp: 
3827         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
3828
3829 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
3830
3831         Reviewed by Xan Lopez.
3832
3833         [GTK] Double clicks cause three button press events
3834         https://bugs.webkit.org/show_bug.cgi?id=38853
3835
3836         Small EventSender cleanups. Consolidate some common code. Style fixes.
3837
3838         * DumpRenderTree/gtk/EventSender.cpp:
3839         (prepareMouseButtonEvent): Added.
3840         (contextClickCallback): Use prepareMouseButtonEvent.
3841         (mouseDownCallback): Use prepareMouseButtonEvent.
3842         (mouseUpCallback): Use prepareMouseButtonEvent.
3843         (mouseMoveToCallback): Small style fix.
3844
3845 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3846
3847         Reviewed by Xan Lopez.
3848
3849         [GTK] Double clicks cause three button press events
3850         https://bugs.webkit.org/show_bug.cgi?id=38853
3851
3852         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
3853         to pause for a specified amount of time. It is used in the processing of drag-
3854         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
3855         This patch enables tests that rely on the latter behavior to pass.
3856
3857         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3858         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
3859         * DumpRenderTree/gtk/EventSender.cpp:
3860         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
3861         (contextClickCallback): Use sendOrQueueEvent.
3862         (updateClickCount): Take the time offset into account when counting clicks.
3863         (mouseDownCallback): Use sendOrQueueEvent.
3864         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
3865         (mouseUpCallback): Use sendOrQueueEvent.
3866         (mouseMoveToCallback): Ditto.
3867         (mouseWheelToCallback): Ditto.
3868         (sendOrQueueEvent): Added.
3869         (dispatchEvent): Added.
3870         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
3871         (makeEventSender): Only initialize the EventSender when loading the top frame.
3872         * DumpRenderTree/gtk/EventSender.h: Ditto.
3873
3874 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3875
3876         Reviewed by Xan Lopez.
3877
3878         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
3879         https://bugs.webkit.org/show_bug.cgi?id=39101
3880
3881         Work around timing issues for render tree dumps by pumping the
3882         main loop before doing the dump. Resize events are asynchronous
3883         in GTK+, so sometimes resize requests are still pending when DRT
3884         dumps the tree.
3885
3886         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3887         (dump): Pump the main loop before dumping the render tree.
3888
3889 2010-05-31  Kent Tamura  <tkent@chromium.org>
3890
3891         Reviewed by Dimitri Glazkov.
3892
3893         [DRT/Chromium] Fix crash of a test after another test with multiple windows
3894         https://bugs.webkit.org/show_bug.cgi?id=39942
3895
3896         If a test opens multiple windows, focuses on non-main window, and
3897         the focused window is closed, TestShell::m_focusedWidget points a
3898         deleted object.
3899
3900         * DumpRenderTree/chromium/TestShell.cpp:
3901         (TestShell::closeWindow): Clear m_focusedWidget.
3902
3903 2010-05-30  Kent Tamura  <tkent@chromium.org>
3904
3905         Reviewed by Dimitri Glazkov.
3906
3907         new-run-webkit-tests: Support DRT on Chromium-win
3908         https://bugs.webkit.org/show_bug.cgi?id=39810
3909
3910         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
3911         it behaves like test_shell about command analysis, printing
3912         format, pixel dumping, and timeout handling.
3913
3914         chromium.py and chromium_win.py supports the --test-shell flag and
3915         DRT/Chromium-win binary names.
3916         
3917         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
3918         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3919         (runTest): Support for test_shell-style command.
3920         (main): Introduce --test-shell.
3921         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
3922         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
3923           TestEventPrinter class manages stdio output and image output.
3924           TestEventPrinter.cpp has two implementations; DRTPrinter and
3925           TestShellPrinter.
3926         * DumpRenderTree/chromium/TestShell.cpp:
3927           Some changes for TestEventPrinter.
3928         (TestShell::TestShell):
3929         (TestShell::runFileTest):
3930         (TestShell::testTimedOut):
3931         (TestShell::dump):
3932         (TestShell::dumpImage):
3933         * DumpRenderTree/chromium/TestShell.h:
3934         (TestShell::printer):
3935         (TestShell::layoutTestTimeout):
3936         (TestShell::layoutTestTimeoutForWatchDog):
3937         (TestShell::setLayoutTestTimeout):
3938         * DumpRenderTree/chromium/TestShellWin.cpp:
3939         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
3940         * Scripts/webkitpy/layout_tests/port/chromium.py:
3941         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3942
3943 2010-05-30  Robert Hogan  <robert@webkit.org>
3944
3945         Reviewed by Kenneth Rohde Christiansen.
3946
3947         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
3948
3949         https://bugs.webkit.org/show_bug.cgi?id=36004
3950
3951         * DumpRenderTree/qt/EventSenderQt.cpp:
3952         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
3953                                     Scrollbar::pixelsPerLineStep() for DRT testing.
3954         (EventSender::mouseScrollBy): Added
3955         (EventSender::continuousMouseScrollBy): Added
3956         * DumpRenderTree/qt/EventSenderQt.h:
3957
3958 2010-05-28  Adam Barth  <abarth@webkit.org>
3959
3960         Reviewed by David Levin.
3961
3962         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
3963         https://bugs.webkit.org/show_bug.cgi?id=39546
3964
3965         One sublty is that we want to wait for the user to finish editing the
3966         ChangeLog before moving on to the next step.  That means we want to pass
3967         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
3968         we don't want them to have to exit the Xcode application.  For this reason,
3969         we create a new instance of the application with -n.
3970         
3971         Overall, xed seems like a better solution, so we recommend that too.
3972
3973         * Scripts/webkitpy/common/system/user.py:
3974         * Scripts/webkitpy/tool/mocktool.py:
3975         * Scripts/webkitpy/tool/steps/editchangelog.py:
3976
3977 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
3978
3979         Reviewed by Ojan Vafai.
3980
3981         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
3982         threads are wedged. Also, the script will print the results of the
3983         tests completed when the interrupt occurs.
3984
3985         https://bugs.webkit.org/show_bug.cgi?id=33238
3986
3987         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3988         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3989         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3990         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3991
3992 2010-05-28  Darin Adler  <darin@apple.com>
3993
3994         Ignore more Python messiness.
3995
3996         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
3997         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
3998         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
3999         * Scripts/webkitpy/test: Added property svn:ignore.
4000         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
4001
4002 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
4003
4004         Reviewed by Beth Dakin.
4005
4006         Adding myself as a reviewer.
4007
4008         * Scripts/webkitpy/common/config/committers.py:
4009
4010 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
4011
4012         Build fix. No review.
4013
4014         AX: need to catch NSAccessibilityExceptions in DRT
4015         https://bugs.webkit.org/show_bug.cgi?id=39881
4016
4017         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
4018
4019         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4020         (AccessibilityUIElement::rowIndexRange):
4021         (AccessibilityUIElement::columnIndexRange):
4022         (AccessibilityUIElement::selectedTextRange):
4023
4024 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
4025
4026         Reviewed by Darin Adler.
4027
4028         AX: need to catch NSAccessibilityExceptions in DRT
4029         https://bugs.webkit.org/show_bug.cgi?id=39881
4030
4031         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
4032         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
4033   
4034         So DRT should wrap exception handlers around its AX related calls.
4035
4036         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4037         (attributesOfElement):
4038         (AccessibilityUIElement::getLinkedUIElements):
4039         (AccessibilityUIElement::getDocumentLinks):
4040         (AccessibilityUIElement::getChildren):
4041         (AccessibilityUIElement::getChildrenWithRange):
4042         (AccessibilityUIElement::ariaOwnsElementAtIndex):
4043         (AccessibilityUIElement::ariaFlowToElementAtIndex):
4044         (AccessibilityUIElement::disclosedRowAtIndex):
4045         (AccessibilityUIElement::selectedRowAtIndex):
4046         (AccessibilityUIElement::titleUIElement):
4047         (AccessibilityUIElement::parentElement):
4048         (AccessibilityUIElement::disclosedByRow):
4049         (AccessibilityUIElement::stringAttributeValue):
4050         (AccessibilityUIElement::boolAttributeValue):
4051         (AccessibilityUIElement::isAttributeSettable):
4052         (AccessibilityUIElement::isAttributeSupported):
4053         (AccessibilityUIElement::role):
4054         (AccessibilityUIElement::subrole):
4055         (AccessibilityUIElement::roleDescription):
4056         (AccessibilityUIElement::title):
4057         (AccessibilityUIElement::description):
4058         (AccessibilityUIElement::orientation):
4059         (AccessibilityUIElement::stringValue):
4060         (AccessibilityUIElement::language):
4061         (AccessibilityUIElement::helpText):
4062         (AccessibilityUIElement::x):
4063         (AccessibilityUIElement::y):
4064         (AccessibilityUIElement::width):
4065         (AccessibilityUIElement::height):
4066         (AccessibilityUIElement::clickPointX):
4067         (AccessibilityUIElement::clickPointY):
4068         (AccessibilityUIElement::intValue):
4069         (AccessibilityUIElement::minValue):
4070         (AccessibilityUIElement::maxValue):
4071         (AccessibilityUIElement::valueDescription):
4072         (AccessibilityUIElement::insertionPointLineNumber):
4073         (AccessibilityUIElement::isActionSupported):
4074         (AccessibilityUIElement::isEnabled):
4075         (AccessibilityUIElement::isRequired):
4076         (AccessibilityUIElement::isSelected):
4077         (AccessibilityUIElement::isExpanded):
4078         (AccessibilityUIElement::hierarchicalLevel):
4079         (AccessibilityUIElement::ariaIsGrabbed):
4080         (AccessibilityUIElement::ariaDropEffects):
4081         (AccessibilityUIElement::lineForIndex):
4082         (AccessibilityUIElement::boundsForRange):
4083         (AccessibilityUIElement::stringForRange):
4084         (AccessibilityUIElement::attributesOfColumnHeaders):
4085         (AccessibilityUIElement::attributesOfRowHeaders):
4086         (AccessibilityUIElement::attributesOfColumns):
4087         (AccessibilityUIElement::attributesOfRows):
4088         (AccessibilityUIElement::attributesOfVisibleCells):
4089         (AccessibilityUIElement::attributesOfHeader):
4090         (AccessibilityUIElement::rowCount):
4091         (AccessibilityUIElement::columnCount):
4092         (AccessibilityUIElement::indexInTable):
4093         (AccessibilityUIElement::rowIndexRange):
4094         (AccessibilityUIElement::columnIndexRange):
4095         (AccessibilityUIElement::cellForColumnAndRow):
4096         (AccessibilityUIElement::selectedTextRange):
4097         (AccessibilityUIElement::setSelectedTextRange):
4098         (AccessibilityUIElement::increment):
4099         (AccessibilityUIElement::decrement):
4100         (AccessibilityUIElement::showMenu):
4101         (AccessibilityUIElement::press):
4102         (AccessibilityUIElement::url):
4103         (AccessibilityUIElement::hasPopup):
4104
4105 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
4106
4107         Reviewed by Laszlo Gombos.
4108
4109         [Qt] Pass all web notification layout tests
4110         https://bugs.webkit.org/show_bug.cgi?id=39146
4111
4112         Mimic Chromium's test_shell security model in Qt's DRT.
4113         It makes a list of origins which were granted permission to display
4114         notifications, and only those origins can display notifications.
4115
4116         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4117         (WebCore::checkPermissionCallback):
4118         (WebCore::requestPermissionCallback):
4119         (WebCore::WebPage::WebPage):
4120         (WebCore::DumpRenderTree::checkPermission):
4121         (WebCore::DumpRenderTree::requestPermission):
4122         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4123         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4124         (LayoutTestController::reset):
4125         (LayoutTestController::grantDesktopNotificationPermission):
4126         (LayoutTestController::checkDesktopNotificationPermission):
4127         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4128
4129 2010-05-27  Philippe Normand  <pnormand@igalia.com>
4130
4131         Reviewed by Shinichiro Hamaji.
4132
4133         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
4134         https://bugs.webkit.org/show_bug.cgi?id=39372
4135
4136         Don't warn about NULL in g_*() calls. Zero can't be used instead
4137         for calls like g_build_filename and g_object_get/set.
4138
4139         * Scripts/webkitpy/style/checkers/cpp.py:
4140         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4141
4142 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
4143
4144         Reviewed by Kenneth Rohde Christiansen.
4145
4146         [Qt] Platform plugin example
4147         https://bugs.webkit.org/show_bug.cgi?id=39489
4148
4149         Exempting directory WebKit/qt/examples/ from style guide.
4150
4151         * Scripts/webkitpy/style/checker.py:
4152
4153 2010-05-26  Philippe Normand  <pnormand@igalia.com>
4154
4155         Reviewed by David Levin.
4156
4157         [style] Allow usage of NULL in gst_*_many()
4158         https://bugs.webkit.org/show_bug.cgi?id=39740
4159
4160         Don't warn if NULL is used by gst_*_many() functions. Zero can't
4161         be used for the reason explained in Bug 32858.
4162
4163         * Scripts/webkitpy/style/checkers/cpp.py:
4164         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4165
4166 2010-05-27  Adam Barth  <abarth@webkit.org>
4167
4168         Reviewed by Eric Seidel.
4169
4170         Update script to run the normal version of the parser tests.
4171
4172         * Scripts/test-html5-parser:
4173
4174 2010-05-27  Adam Barth  <abarth@webkit.org>
4175
4176         Reviewed by Eric Seidel.
4177
4178         Add HTML5 parser support to run-webkit-tests
4179         https://bugs.webkit.org/show_bug.cgi?id=39815
4180
4181         * Scripts/old-run-webkit-tests:
4182
4183 2010-05-26  Adam Barth  <abarth@webkit.org>
4184
4185         Reviewed by Eric Seidel.
4186
4187         Make HTML5 lexer not ASSERT when resuming partial parses
4188         https://bugs.webkit.org/show_bug.cgi?id=39755
4189
4190         Add webkit-resumer.html to the HTML5 parser test suite.
4191
4192         * Scripts/test-html5-parser:
4193
4194 2010-05-24  Tony Chang  <tony@chromium.org>
4195
4196         Reviewed by Kent Tamura.
4197
4198         [chromium] setup fonts on chromium linux DRT
4199         https://bugs.webkit.org/show_bug.cgi?id=39644
4200
4201         * DumpRenderTree/chromium/TestShellGtk.cpp:
4202         (setupFontconfig):
4203         (platformInit):
4204         * DumpRenderTree/chromium/WebViewHost.cpp:
4205         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
4206         * DumpRenderTree/chromium/fonts.conf: Added.
4207
4208 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
4209
4210         Reviewed by Dimitri Glazkov.
4211
4212         Re-commit r58765 - it had been rolled out to see if it was causing
4213         a perf regression (in r59787 and r59789), but that does not seem to
4214         have been the case.
4215
4216         https://bugs.webkit.org/show_bug.cgi?id=39605
4217
4218         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4219         (NotificationPresenter::show):
4220
4221 2010-05-25  Ojan Vafai  <ojan@chromium.org>
4222
4223         Reviewed by Chris Jerdonek.
4224
4225         remove suppression of rietveld logging
4226         https://bugs.webkit.org/show_bug.cgi?id=39693
4227
4228         Now that we only upload to rietveld explicitly, e.g. on the bot
4229         or via webkit-patch post-attachment-to-rietveld, we should print
4230         all the rietveld logging. It was suppressed before to avoid making
4231         webkit-patch upload too noisy.
4232
4233         * Scripts/webkitpy/common/net/rietveld.py:
4234
4235 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
4236
4237         Reviewed by Ojan Vafai.
4238
4239         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
4240         https://bugs.webkit.org/show_bug.cgi?id=39680
4241
4242         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
4243
4244         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4245         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4246         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4247         (LayoutTestController::setEditingBehavior):
4248
4249 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
4250
4251         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
4252
4253         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4254         (LayoutTestController::setEditingBehavior):
4255         * wx/build/settings.py:
4256
4257 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
4258
4259         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
4260
4261         editingBehavior settings needs to be set back to a reasonable default between tests
4262         https://bugs.webkit.org/show_bug.cgi?id=39433
4263
4264         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
4265         so that the serialized version of the setting stays in sync with expectations.
4266
4267         * DumpRenderTree/chromium/TestShell.cpp:
4268         (TestShell::resetWebSettings):
4269         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4270         (resetDefaultsToConsistentValues):
4271
4272 2010-05-24  Eric Seidel  <eric@webkit.org>
4273
4274         Reviewed by Adam Barth.
4275
4276         webkit-patch land calls scm.changed_files 4 times!
4277         https://bugs.webkit.org/show_bug.cgi?id=39584
4278
4279         * Scripts/webkitpy/tool/commands/download_unittest.py:
4280          - Assert that we don't call modified_changelogs too often.
4281         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4282          - Use cached changelogs list instead of calling modified_changelogs directly.
4283         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4284          - ditto.
4285
4286 2010-05-24  Kent Tamura  <tkent@chromium.org>
4287
4288         Reviewed by Dimitri Glazkov.
4289
4290         [DRT/Chromium] Import layout_test_helper for Windows
4291         https://bugs.webkit.org/show_bug.cgi?id=39581
4292
4293         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
4294         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
4295
4296         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
4297
4298 2010-05-24  Kent Tamura  <tkent@chromium.org>
4299
4300         Reviewed by Dimitri Glazkov.
4301
4302         [DRT/Chromium] Reset frame name
4303         https://bugs.webkit.org/show_bug.cgi?id=39586
4304
4305         This change fixes about 70 unexpected results.
4306
4307         * DumpRenderTree/chromium/WebViewHost.cpp:
4308         (WebViewHost::reset):
4309
4310 2010-05-24  Marcus Bulach  <bulach@chromium.org>
4311
4312         Reviewed by Kent Tamura.
4313
4314         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
4315         https://bugs.webkit.org/show_bug.cgi?id=39587
4316
4317         * DumpRenderTree/chromium/WebViewHost.cpp:
4318         (WebViewHost::geolocationService):
4319
4320 2010-05-24  Robert Hogan  <robert@webkit.org>
4321
4322         Reviewed by Laszlo Gombos.
4323
4324         [Qt] DRT Support for removeOriginAccessWhitelistEntry
4325
4326         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
4327
4328         [Qt] DRT Support for removeOriginAccessWhitelistEntry
4329         https://bugs.webkit.org/show_bug.cgi?id=39565
4330
4331         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4332         (LayoutTestController::removeOriginAccessWhitelistEntry):
4333
4334 2010-05-24  Marcus Bulach  <bulach@google.com>
4335
4336         Reviewed by Ojan Vafai.
4337
4338         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
4339         https://bugs.webkit.org/show_bug.cgi?id=39603
4340
4341         * Scripts/webkitpy/common/checkout/scm.py:
4342
4343 == Rolled over to ChangeLog-2010-05-24 ==