2010-04-05 Chris Jerdonek <cjerdonek@webkit.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>
2
3         Reviewed by Shinichiro Hamaji.
4
5         Fixed check-webkit-style issue where the script was prematurely
6         exiting when encountering deleted files in patches.
7
8         https://bugs.webkit.org/show_bug.cgi?id=37122
9
10         * Scripts/webkitpy/style/checker.py:
11           - Changed non-existent file message from ERROR to WARN.
12           - StyleChecker.check_file() no longer raises an exception when
13             a file is not found.
14
15         * Scripts/webkitpy/style/checker_unittest.py:
16           - Updated unit tests as necessary.
17
18 2010-04-05  Adam Barth  <abarth@webkit.org>
19
20         Reviewed by Eric Seidel.
21
22         SheriffBot should include blamelist when posting to bugs
23         https://bugs.webkit.org/show_bug.cgi?id=37113
24
25         When posting on bugs, we should include the full list of SVN revisions
26         that caused the regression to folks have a better sense of whether they
27         are to blame.
28
29         * Scripts/webkitpy/tool/bot/sheriff.py:
30         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
31         * Scripts/webkitpy/tool/commands/sheriffbot.py:
32         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
33         * Scripts/webkitpy/tool/commands/upload_unittest.py:
34         * Scripts/webkitpy/tool/mocktool.py:
35
36 2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>
37
38         Unreviewed after discussion with Adam, Darin, and Eric.
39
40         Deleted the auto-install directory since it is no longer needed in
41         source control (it is auto-generated).
42
43         Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
44         svn:ignore property.
45
46         * Scripts/webkitpy/thirdparty/autoinstalled: Removed.
47
48 2010-04-05  Mark Rowe  <mrowe@apple.com>
49
50         Reviewed by Adele Peterson.
51
52         Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
53         REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
54
55         Add a JavaScript hook in DRT to call through to WebView's -setEditable:.  This is required in order to reproduce
56         the crash.
57
58         * DumpRenderTree/LayoutTestController.cpp:
59         (setWebViewEditableCallback):
60         (LayoutTestController::staticFunctions):
61         * DumpRenderTree/LayoutTestController.h:
62         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
63         (LayoutTestController::setWebViewEditable):
64         * DumpRenderTree/mac/DumpRenderTree.mm:
65         (resetWebViewToConsistentStateBeforeTesting):
66         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
67         (LayoutTestController::setWebViewEditable):
68         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
69         (LayoutTestController::setWebViewEditable):
70         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
71         (LayoutTestController::setWebViewEditable):
72         (LayoutTestController::layerTreeAsText):
73
74 2010-04-05  Darin Adler  <darin@apple.com>
75
76         Ignore more files the Python tools strew about the working directory.
77
78         * Scripts/webkitpy: Added property svn:ignore.
79         * Scripts/webkitpy/common: Added property svn:ignore.
80         * Scripts/webkitpy/common/checkout: Added property svn:ignore.
81         * Scripts/webkitpy/common/config: Added property svn:ignore.
82         * Scripts/webkitpy/common/net: Added property svn:ignore.
83         * Scripts/webkitpy/common/thread: Added property svn:ignore.
84         * Scripts/webkitpy/python24: Added property svn:ignore.
85         * Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
86         * Scripts/webkitpy/tool/bot: Added property svn:ignore.
87
88 2010-04-05  Adam Barth  <abarth@webkit.org>
89
90         Unreviewed.  Add Vitaly Repeshko as a committer.
91
92         * Scripts/webkitpy/common/config/committers.py:
93
94 2010-04-05  Adam Barth  <abarth@webkit.org>
95
96         Unreviewed.  Update kenne's IRC nick to his registered nick.
97
98         * Scripts/webkitpy/common/config/committers.py:
99
100 2010-04-05  Ojan Vafai  <ojan@chromium.org>
101
102         Reviewed by Eric Seidel.
103
104         assorted helper functions and cleanup of git utilities
105         https://bugs.webkit.org/show_bug.cgi?id=37103
106
107         * Scripts/webkitpy/common/checkout/scm.py:
108         No code currently uses the optional dry_run argument. So removing it.
109         Change all uses of "trunk" to read the correct value out of the git config.
110         Made the dcommit call actually get called when dry_run==true.
111         * Scripts/webkitpy/common/checkout/scm_unittest.py:
112         * Scripts/webkitpy/common/net/credentials.py:
113         Move the git config call into scm.
114         * Scripts/webkitpy/common/net/credentials_unittest.py:
115         * Scripts/webkitpy/common/system/executive.py:
116         If return_exit_code==true, don't error out, just return the exit_code.
117
118 2010-04-05  Ojan Vafai  <ojan@chromium.org>
119
120         Reviewed by Eric Seidel.
121
122         prepare-ChangeLog should take a merge-base for which git branch to diff against.
123         https://bugs.webkit.org/show_bug.cgi?id=36394
124
125         * Scripts/prepare-ChangeLog:
126
127 2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>
128
129         Reviewed by Shinichiro Hamaji.
130
131         Removed the PatchStyleErrorHandler class and incorporated its
132         functionality into the DefaultStyleErrorHandler class.
133
134         https://bugs.webkit.org/show_bug.cgi?id=37067
135
136         * Scripts/webkitpy/style/checker.py:
137           - In the StyleChecker class:
138             - Added a line_number parameter to the check_file() method.
139             - Renamed the handle_style_error parameter to
140               mock_handle_style_error to be consistent with the other mock_*
141               parameter names.
142             - Added a mock_check_file parameter to the check_patch() method
143               to facilitate unit testing the changes in this patch.
144             - Rewrote the check_patch() method with the patch-parsing logic
145               taken from the PatchStyleErrorHandler class.
146
147         * Scripts/webkitpy/style/checker_unittest.py:
148           - Added a StyleCheckerCheckFileBase class and sub-classed the
149             existing StyleCheckerCheckFileTest class from it.
150           - Added a StyleCheckerCheckPatchTest class to unit-test the
151             rewritten check_patch() method.
152           - Removed the vestigial __main__ code at the bottom of the file.
153             This is left over from when check-webkit-style was implemented
154             as a module and a wrapper module.
155
156         * Scripts/webkitpy/style/error_handlers.py:
157           - Added an optional line_numbers parameter to the
158             DefaultStyleErrorHandler class constructor and adjusted the
159             __call__() method as necessary.
160           - Removed the PatchStyleErrorHandler class.
161
162         * Scripts/webkitpy/style/error_handlers_unittest.py:
163           - Removed the PatchStyleErrorHandlerTest class which unit-tested
164             the PatchStyleErrorHandler class which is being removed in this
165             patch.
166           - Added a test_line_numbers() test method to the
167             DefaultStyleErrorHandlerTest class to test use of the
168             DefaultStyleErrorHandler's new line_numbers attribute.
169
170 2010-04-05  Adam Barth  <abarth@webkit.org>
171
172         Unreviewed.
173
174         Tighten SheriffBot's flaky test detector
175         https://bugs.webkit.org/show_bug.cgi?id=37063
176
177         Instead of just looking for two sequential red builds, look for two
178         sequential failures of the same test.  This should reduce sheriffbot
179         false positive substantially.
180
181         I'm landing this change unreviewed because I've noticed SheriffBot
182         triggering a lot more false positives now that we've expanded the set
183         of core builders.  I've tried to take Eric's comments on Bug 37063 into
184         account.  I'm happy to iterate on this patch tomorrow once Eric wakes
185         up.
186
187         * Scripts/webkitpy/common/net/buildbot.py:
188         * Scripts/webkitpy/common/net/buildbot_unittest.py:
189         * Scripts/webkitpy/tool/commands/queries.py:
190
191 2010-04-04  John Gregg  <johnnyg@google.com>
192
193         Unreviewed, add myself to the committers list.
194
195         * Scripts/webkitpy/common/config/committers.py:
196
197 2010-04-04  Robert Hogan  <robert@webkit.org>
198
199         Unreviewed, add myself to the committers list.
200
201         * Scripts/webkitpy/common/config/committers.py:
202
203 2010-04-04  Dumitru Daniliuc  <dumi@chromium.org>
204
205         Unreviewed, adding my IRC nickname to committers.py
206
207         * Scripts/webkitpy/common/config/committers.py:
208
209 2010-04-04  Chris Jerdonek  <cjerdonek@webkit.org>
210
211         Reviewed by Shinichiro Hamaji.
212
213         Refactored check-webkit-style's option-parsing code.
214
215         https://bugs.webkit.org/show_bug.cgi?id=37064
216
217         * Scripts/check-webkit-style:
218           - Moved the "WebKit checkout not found" check from
219             ArgumentParser.parse() to the calling code.
220           - Moved the --git-commit argument validation from the calling
221             code to ArgumentParser.parse().
222
223         * Scripts/webkitpy/style/checker_unittest.py:
224           - Updated a unit test as necessary.
225
226         * Scripts/webkitpy/style/optparser.py:
227           - Renamed ArgumentParser._exit_with_help() to _parse_error()
228             and made its error_message parameter required.
229           - Removed the found_checkout parameter from ArgumentParser.parse().
230           - Removed the "WebKit checkout not found" check and moved it
231             to the calling code.
232           - Added --git-commit argument checking.
233
234         * Scripts/webkitpy/style/optparser_unittest.py:
235           - Adjusted the import statements to be fully qualified.
236           - Changed the ArgumentParserTest class to inherit from
237             LoggingTestCase, and updated the class as necessary.
238           - Added a unit-test for the --git-commit validation.
239           - Added unit tests for the --git-diff and --git-since variants
240             of --git-commit.
241
242 2010-04-03  Chris Jerdonek  <cjerdonek@webkit.org>
243
244         Reviewed by Shinichiro Hamaji.
245
246         The check-webkit-style script now logs an ERROR and exits when
247         encountering a file path that does not exist.  Previously, it failed
248         silently on such paths.
249
250         https://bugs.webkit.org/show_bug.cgi?id=36957
251
252         * Scripts/webkitpy/common/system/logtesting.py:
253           - Added a FIXME to rename the LoggingTestCase class to
254             LoggingTestCaseBase.
255
256         * Scripts/webkitpy/style/checker.py:
257           - In the StyleChecker.check_file() method:
258             - Added a mock_os_path_exists parameter.
259             - Renamed the process_file parameter to mock_process_file.
260             - Added logic to log an error and exist if the given path does
261               not exist.
262
263         * Scripts/webkitpy/style/checker_unittest.py:
264           - Refactored the StyleCheckerCheckFileTest class slightly to
265             inherit from LoggingTestCase.
266           - Added a test method to unit-test the case of a file that
267             does not exist.
268           - Adjusted the other test methods as necessary.
269
270 2010-04-03  Adam Barth  <abarth@webkit.org>
271
272         Reviewed by Eric Seidel.
273
274         Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
275         https://bugs.webkit.org/show_bug.cgi?id=33289
276
277         Add Tiger and SnowLeopard Tests to the core builders.  This is a bit of
278         an experiment now that the bots are green.  Hopefully we can keep them
279         on the list and have the tree stay greener.
280
281         * Scripts/webkitpy/common/net/buildbot.py:
282
283 2010-04-02  Adam Barth  <abarth@webkit.org>
284
285         Unreviewed.
286
287         Have Eric and Adam watch the SheriffBot
288         https://bugs.webkit.org/show_bug.cgi?id=37054
289
290         * Scripts/webkitpy/tool/bot/sheriff.py:
291         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
292         * Scripts/webkitpy/tool/commands/sheriffbot.py:
293
294 2010-04-02  Adam Barth  <abarth@webkit.org>
295
296         Reviewed by Darin Adler.
297
298         commit-queue should ignore builders when landing rollouts
299         https://bugs.webkit.org/show_bug.cgi?id=37051
300
301         When we moved the "builders are red" check into the master process, we
302         forgot about rollouts.  I thought we had a test covering this case, but
303         looking at the test, it was a bit too loose.  I added a new test and
304         introduced some new logging technology into MockTool to make the test
305         tighter.
306
307         * Scripts/webkitpy/tool/commands/queues.py:
308         * Scripts/webkitpy/tool/commands/queues_unittest.py:
309         * Scripts/webkitpy/tool/mocktool.py:
310
311 2010-04-02  David Levin  <levin@chromium.org>
312
313         Reviewed by Adam Barth.
314
315         sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
316         https://bugs.webkit.org/show_bug.cgi?id=37030
317
318         * Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't
319           start with -.
320         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout
321           reason which starts with -.
322         * Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.
323
324 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
325
326         Unreviewed.
327
328         Fixed check-webkit-style to recognize the short form of the
329         --verbose option, as stated in --help.
330
331         * Scripts/check-webkit-style:
332           - Tweaked one line.
333
334 2010-04-02  Kevin Ollivier  <kevino@theolliviers.com>
335
336         [wx] Build fix for DumpRenderTree after addition of layerTreeAsText.
337
338         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
339         (LayoutTestController::layerTreeAsText):
340
341 2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
342
343         Reviewed by Eric Seidel.
344
345         Accept XHTML-MP content type as XHTML content
346         https://bugs.webkit.org/show_bug.cgi?id=34262
347
348         Register xhtmlmp file extension as the new type
349         for XHTML-MP test content.
350
351         * Scripts/run-webkit-tests:
352         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
353         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
354
355 2010-04-02  Adam Barth  <abarth@webkit.org>
356
357         Reviewed by Eric Seidel.
358
359         create-rollout doesn't fill out ChangeLog
360         https://bugs.webkit.org/show_bug.cgi?id=37010
361
362         The contract between apply_reverse_diff and PrepareChangeLogForRevert
363         was unclear.  I broke filling out the ChangeLog during rollout earlier
364         when I changed apply_reverse_diff to revert the ChangeLogs because
365         PrepareChangeLogForRevert thought that it was supposed to do that.
366         I've now taught PrepareChangeLogsForRevert the new contract.
367
368         It's unclear to me how to test this change because it's essentially an
369         integration issue that requires the file system.  At some point we
370         should think about a testing strategy for integration.  As the system
371         becomes larger, we're running into more of these issues.
372
373         * Scripts/webkitpy/common/checkout/api.py:
374         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
375
376 2010-04-02  Adam Barth  <abarth@webkit.org>
377
378         Reviewed by Eric Seidel.
379
380         Add cr-win-ews to QueueStatusServer
381         https://bugs.webkit.org/show_bug.cgi?id=37004
382
383         * QueueStatusServer/model/queues.py:
384         * QueueStatusServer/templates/dashboard.html:
385         * QueueStatusServer/templates/statusbubble.html:
386
387 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
388
389         Reviewed by Adam Barth.
390
391         Unit-test networktransaction.py's log messages, and add a base
392         class to make unit-testing log messages even easier.
393         
394         https://bugs.webkit.org/show_bug.cgi?id=36958
395
396         The purpose of this patch is also to provide a mini-tutorial on
397         how to unit-test Python logging.py messages.
398
399         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
400           - Unit-tested the log messages in test_retry().
401
402         * Scripts/webkitpy/common/system/logtesting.py:
403           - Adjusted the LogTesting class by moving the code that clears
404             the array of log messages into a finally block.  This prevents
405             redundant AssertionErrors from getting rendered to the screen
406             while running unit tests.
407           - Added a LoggingTestCase class so the setUp() and tearDown()
408             methods do not need to be implemented in order to test logging.
409             Rather, TestCase classes can simply inherit from this class.
410
411 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
412
413         Reviewed by Shinichiro Hamaji.
414
415         Re-wrote check-webkit-style's argument parsing code to use
416         Python's optparser module and more uniform error-handling logic.
417
418         https://bugs.webkit.org/show_bug.cgi?id=34676
419
420         * Scripts/webkitpy/style/optparser.py:
421           - Removed "option help" from check-webkit-style's usage string
422             since that is provided separately by the OptionParser class.
423           - Also changed the usage string from a function to a constant
424             string _USAGE.
425           - Added an _EPILOG string which renders after OptionParser's
426             usage string and option help.
427           - In the ArgumentParser class:
428             - Changed the constructor's stderr_write parameter to a
429               mock_stderr since the OptionParser accepts a sys.stderr
430               substitute rather than a sys.stderr.write substitute.
431             - Changed the constructor to set a _parser data attribute with
432               an OptionParser instance.
433             - Added a _create_option_parser() method which instantiates
434               the OptionParser.
435             - Updated _exit_with_help() to interact with the OptionParser's
436               help method.
437             - Updated the parse() method as necessary.  Also changed the
438               raising of ValueErrors to calls to _exit_with_help().
439
440         * Scripts/webkitpy/style/optparser_unittest.py:
441           - Removed the CreateUsageTest class since the create_usage method
442             was replaced by a constant string.
443           - Added a _MockStdErr class to the ArgumentParserTest class.
444           - Updated the unit tests as necessary.
445
446
447 2010-04-02  Adam Barth  <abarth@webkit.org>
448
449         Reviewed by Eric Seidel.
450
451         The master commit-queue process should take responsibility for checking that the builders are green
452         https://bugs.webkit.org/show_bug.cgi?id=37009
453
454         We had a failure where the child process noticed that the builders were
455         red.  We've always had this race condition, but the new optimistic
456         design made it easier to trigger.
457
458         * Scripts/webkitpy/tool/commands/queues.py:
459
460 2010-04-02  Adam Barth  <abarth@webkit.org>
461
462         Reviewed by Eric Seidel.
463
464         Tweak rollout changelog to pass ValidateReviewer check
465         https://bugs.webkit.org/show_bug.cgi?id=37019
466
467         We need to use the magic word "unreviewed" to make the commit-queue
468         happy when landing rollouts.
469
470         * Scripts/webkitpy/common/checkout/changelog.py:
471         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
472
473 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
474
475         Unreviewed.
476
477         Removed duplicate ChangeLog entry.
478
479 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
480
481         Rubber-stamped by Eric Seidel.
482
483         To the Python 2.4 error message, added a link to the wiki page
484         that contains instructions on how to upgrade.
485
486         * Scripts/test-webkitpy:
487           - Eliminated a use of the ternary operator in configure_logging()
488             to let the version warning display in case of Python 2.4.
489
490         * Scripts/webkitpy/python24/versioning.py:
491           - Added this link to the error text:
492             http://trac.webkit.org/wiki/PythonGuidelines
493
494         * Scripts/webkitpy/python24/versioning_unittest.py:
495           - Updated unit test text.
496
497 2010-04-02  Adam Barth  <abarth@webkit.org>
498
499         Reviewed by Eric Seidel.
500
501         Record the IRC nick of folks who request rollouts
502         https://bugs.webkit.org/show_bug.cgi?id=36999
503
504         * Scripts/webkitpy/common/net/irc/ircbot.py:
505         * Scripts/webkitpy/tool/bot/irc_command.py:
506         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
507         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
508
509 2010-04-01  Adam Barth  <abarth@webkit.org>
510
511         Reviewed by Eric Seidel.
512
513         Add cr-win-ews
514         https://bugs.webkit.org/show_bug.cgi?id=36974
515
516         Adds support for an Early Warning System for Chromium on Linux.  The
517         interface to the Chromium port is the same on every platform, so we
518         don't need to create a new Port object for this queue.
519
520         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
521         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
522
523 2010-04-01  Adam Barth  <abarth@webkit.org>
524
525         Reviewed by Eric Seidel.
526
527         Using a failure exit code when failing to load a required import
528         https://bugs.webkit.org/show_bug.cgi?id=37000
529
530         Well spotted by Mark Rowe.
531
532         * Scripts/webkitpy/common/system/user.py:
533
534 2010-04-01  Chris Jerdonek  <cjerdonek@webkit.org>
535
536         Reviewed by Eric Seidel.
537
538         Rewrote the revision (r56942) to disable the 79 character line
539         length limit Python/PEP8 style check.
540
541         https://bugs.webkit.org/show_bug.cgi?id=33639#c39
542
543         This rewrite puts the disabling not in the PythonProcessor but
544         in the calling code's default filter rule configuration.  This
545         allows the user to check line-length style from the command-line
546         if desired.
547
548         * Scripts/webkitpy/style/checker.py:
549           - Added "-pep8/E501" to the _BASE_FILTER_RULES configuration
550             variable to disable the line-length check.
551           - Added "-pep8/E501" to the list of recognized style categories
552             to permit the category to be checked from the command line.
553
554         * Scripts/webkitpy/style/processors/python.py:
555           - Reverted r56942: http://trac.webkit.org/changeset/56942
556
557 2010-04-01  Kinuko Yasuda  <kinuko@chromium.org>
558
559         Reviewed by Dmitry Titov.
560
561         Add FileThread for async file operation support in FileReader and FileWriter
562         https://bugs.webkit.org/show_bug.cgi?id=36896
563
564         Add options to enable FILE_READER and FILE_WRITER support.
565
566         * Scripts/build-webkit:
567
568 2010-04-01  Kent Tamura  <tkent@chromium.org>
569
570         Unreviewed. Add missing license header.
571
572         * DumpRenderTree/chromium/TestShellMac.mm:
573
574 2010-04-01  Adam Barth  <abarth@webkit.org>
575
576         Reviewed by Eric Seidel.
577
578         Improve the error handling in rollout a bit
579         https://bugs.webkit.org/show_bug.cgi?id=36995
580
581         This patch does a few things to make the error handling in rollout a
582         bit more robust.
583
584         * Scripts/webkitpy/common/checkout/api.py:
585             The old logic here was wrong.  We don't want to resolve the
586             ChangeLogs (that would remove the old ChangeLog entry).  Instead,
587             we want to revert the ChangeLogs so we can fill them with the new
588             message.
589         * Scripts/webkitpy/tool/commands/download_unittest.py:
590             Update test expectations because we're using a different mock object.
591         * Scripts/webkitpy/tool/commands/download.py:
592             - Added an update command to make updating from the SheriffBot more
593               robust.
594             - Now that we have CommitInfo, we can automatically CC the
595               responsible parties on the bug we create.
596             - Re-ordered the steps in create-rollout.  Our original thinking
597               was that we always wanted to create the bug, but that's not
598               really true given how things appear to be playing out.  If we
599               fail to apply the reverse diff, we don't want to create the bug.
600         * Scripts/webkitpy/tool/commands/sheriffbot.py:
601             - Use the new, more robust update command.
602         * Scripts/webkitpy/tool/steps/createbug.py:
603             Allow commands to pre-load who they want to be CCed on a new bug.
604
605 2010-04-01  Kent Tamura  <tkent@chromium.org>
606
607         Reviewed by Dimitri Glazkov.
608
609         [DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
610         https://bugs.webkit.org/show_bug.cgi?id=36814
611
612         This change introduces:
613         - WebViewHost class
614           It's an implementation of some delegates required by Chromium
615           WebKit API, and manages painting of a WebView. It's base on
616           src/webkit/tools/test_shell/test_webview_delegate.{cc,h} of
617           Chromium rev.40492.
618         - TestShell class
619           The TestShell instance holds global states of DumpRenderTree process.
620           Unlike TestShell class of Chromium test_shell, TestShell instance is
621           created just once.
622         - DumpRenderTree.cpp
623           The program entry.
624
625         * DumpRenderTree/chromium/DumpRenderTree.cpp: Added.
626         * DumpRenderTree/chromium/TestShell.cpp: Added.
627         * DumpRenderTree/chromium/TestShell.h: Added.
628         * DumpRenderTree/chromium/TestShellMac.mm: Added.
629         * DumpRenderTree/chromium/WebViewHost.cpp: Added.
630         * DumpRenderTree/chromium/WebViewHost.h: Added.
631         * DumpRenderTree/chromium/config.h: Added.
632
633 2010-04-01  David Levin  <levin@chromium.org>
634
635         Reviewed by Adam Barth.
636
637         sheriffbot rollout should verify that the svn revision is a number.
638         https://bugs.webkit.org/show_bug.cgi?id=37001
639
640         * Scripts/webkitpy/common/net/bugzilla.py: Allow for the message to be None.
641         * Scripts/webkitpy/tool/bot/sheriff.py: Did verification that svn revision
642          is a number. Fixed the imports (since the files uses ScriptError and log)
643          and a typo.
644         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added a test to verify
645          the behavior.
646
647 2010-04-01  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Eric Seidel.
650
651         Print an error message for readline bogosity in MacPorts
652         https://bugs.webkit.org/show_bug.cgi?id=36979
653
654         * Scripts/webkitpy/common/system/user.py:
655
656 2010-04-01  Adam Barth  <abarth@webkit.org>
657
658         Reviewed by Eric Seidel.
659
660         Don't pass --non-interactive to create-rollout
661         https://bugs.webkit.org/show_bug.cgi?id=36989
662
663         It turns out you can't pass --non-interactive to create-rollout.  Also,
664         improve our error reporting slighly to catch the case where we error
665         out after creating the rollout bug.
666
667         * Scripts/webkitpy/tool/bot/irc_command.py:
668         * Scripts/webkitpy/tool/bot/sheriff.py:
669
670 2010-04-01  Ojan Vafai  <ojan@chromium.org>
671
672         Reviewed by Eric Seidel.
673
674         webkit-patch can incorrectly think the working directory is modified
675         https://bugs.webkit.org/show_bug.cgi?id=36985
676
677         If a file's modification time is modified, but the contents are not,
678         then diff-index will think the file has been modified unless you do
679         some crazy update-index call. Instead, call diff --name-only, which
680         has the index update builtin.
681
682         Tried to write a test, but could not reproduce this in a unittest.
683         To test manually:
684             touch file-in-repo
685             git diff-index HEAD
686             git diff HEAD --name-only
687
688         The diff-index call incorrectly shows file-in-repo as modified.
689
690         * Scripts/webkitpy/common/checkout/scm.py:
691
692 2010-04-01  Adam Barth  <abarth@webkit.org>
693
694         Reviewed by Eric Seidel.
695
696         Add rollout command to sheriffbot
697         https://bugs.webkit.org/show_bug.cgi?id=36986
698
699         This IRC command creates a new bug an attaches a rollout patch.  To
700         actually commit the rollout, a committer needs to mark the patch
701         commit-queue+ in bugs.webkit.org.
702
703         Also, factored out some of the logic from the queue into a separate
704         object for easier testing.
705
706         * Scripts/webkitpy/common/system/executive.py:
707         * Scripts/webkitpy/tool/bot/irc_command.py:
708         * Scripts/webkitpy/tool/bot/sheriff.py: Added.
709         * Scripts/webkitpy/tool/bot/sheriff_unittest.py: Added.
710         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
711         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
712         * Scripts/webkitpy/tool/commands/queues.py:
713         * Scripts/webkitpy/tool/commands/sheriffbot.py:
714         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
715
716 2010-04-01  Eric Seidel  <eric@webkit.org>
717
718         Unreviewed, only ignoring chatty style errors.
719
720         check-webkit-style: WebKit needs a python style checker
721         https://bugs.webkit.org/show_bug.cgi?id=33639
722
723         Remove the 79 char line limit by ignoring 
724         pep8/E501.  Because we have our own report_error
725         implementation we have to ignore E501 by hand
726         instead of passing --ignore=E501.
727
728         Right now over 1400 lines of our existing python
729         fail E501 so this rule just generates needless noise.
730         The rest of WebKit has no wrapping rule so it makes
731         little sense for our Python to differ here.
732
733         * Scripts/webkitpy/style/processors/python.py:
734
735 2010-04-01  Adam Barth  <abarth@webkit.org>
736
737         Unreviewed.  Add cmarrin's IRC nickname.
738
739         * Scripts/webkitpy/common/config/committers.py:
740
741 2010-04-01  Adam Barth  <abarth@webkit.org>
742
743         Unreviewed.
744
745         EWS spins hot when unable to build
746         https://bugs.webkit.org/show_bug.cgi?id=36981
747
748         The problem is that the queue engine things we have more work to do,
749         but the bot isn't actually able to do anything.  After this change, we
750         back off the usual amount.
751
752         * Scripts/webkitpy/tool/bot/queueengine.py:
753         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
754         * Scripts/webkitpy/tool/commands/queues.py:
755         * Scripts/webkitpy/tool/commands/sheriffbot.py:
756
757 2010-04-01  Chris Marrin  <cmarrin@apple.com>
758
759         Reviewed by Simon Fraser.
760
761         Added layerTreeAsText function to DRT (for Mac)
762         https://bugs.webkit.org/show_bug.cgi?id=36782
763
764         This is the DRT side. It exposes the call to JavaScript
765         through the LayoutTestController.
766
767         * DumpRenderTree/LayoutTestController.cpp:Platform independent JavaScript shim
768         (layerTreeAsTextCallback):
769         (LayoutTestController::staticFunctions):
770         * DumpRenderTree/LayoutTestController.h:
771         * DumpRenderTree/mac/LayoutTestControllerMac.mm:Mac specific plumbing to WebKit
772         (LayoutTestController::layerTreeAsText):
773         * DumpRenderTree/win/LayoutTestControllerWin.cpp:Windows specific plumbing to WebKit
774         (LayoutTestController::layerTreeAsText):
775
776 2010-04-01  Kevin Ollivier  <kevino@theolliviers.com>
777
778         [wx] Build fix after addition of JavaScriptCore/wtf/text directory.
779
780         * wx/build/settings.py:
781
782 2010-04-01  Jian Li  <jianli@chromium.org>
783
784         Rubber-stamped by David Levin.
785
786         Add myself to the reviewers list.
787
788         * Scripts/webkitpy/common/config/committers.py:
789
790 2010-04-01  Adam Barth  <abarth@webkit.org>
791
792         Unreviewed.
793
794         Turns out the Chromium Windows bots don't have pdevenv installed.
795
796         * Scripts/webkitdirs.pm:
797
798 2010-04-01  Adam Barth  <abarth@webkit.org>
799
800         Reviewed by Dimitri Glazkov.
801
802         Let Chromium Windows build with Visual Studio Express
803         https://bugs.webkit.org/show_bug.cgi?id=36919
804
805         This is horrible, horrible copy/paste code, but that seems to be the
806         way of webkitdirs.pm.  :(
807
808         Someone needs to go through an cleanup this code, but I don't have the
809         heart to do it in this patch.
810
811         * Scripts/webkitdirs.pm:
812
813 2010-04-01  Ilya Tikhonovsky  <loislo@chromium.org>
814
815         Reviewed by Yury Semikhatsky.
816
817         Add myself to the committers list.
818         https://bugs.webkit.org/show_bug.cgi?id=36953
819
820         * Scripts/webkitpy/common/config/committers.py:
821
822 2010-04-01  Eric Seidel  <eric@webkit.org>
823
824         Rubber-stamped by Adam Barth.
825
826         Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red)
827         https://bugs.webkit.org/show_bug.cgi?id=33292
828
829         Just adding the "Build" builder for now.
830         We'll add the "Test" builders when the tests
831         are less flaky.
832
833         * Scripts/webkitpy/common/net/buildbot.py:
834         * Scripts/webkitpy/common/net/buildbot_unittest.py:
835
836 2010-04-01  Yury Semikhatsky  <yurys@chromium.org>
837
838         Reviewed by David Levin.
839
840         Add myself to the reviewers list.
841
842         https://bugs.webkit.org/show_bug.cgi?id=36935
843
844         * Scripts/webkitpy/common/config/committers.py:
845
846 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
847
848         Reviewed by Dave Levin.
849
850         Added Python style checking to check-webkit-style using
851         the third-party pep8 module (via autoinstall).
852
853         https://bugs.webkit.org/show_bug.cgi?id=33639
854
855         * Scripts/webkitpy/style/checker.py:
856           - Added PYTHON to FileType.
857           - Updated ProcessorDispatcher to return a PythonProcessor
858             for *.py files.
859
860         * Scripts/webkitpy/style/checker_unittest.py:
861           - Updated the ProcessorDispatcher unit tests for *.py files.
862
863         * Scripts/webkitpy/style/processors/python.py: Added.
864           - Added PythonProcessor class.
865
866         * Scripts/webkitpy/style/processors/python_unittest.py: Added.
867           - Added PythonProcessor unit tests.
868
869         * Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
870           - Added a sample Python file to test the PythonProcessor.process()
871             code path (since pep8 accepts a file path).
872
873         * Scripts/webkitpy/style/unittests.py:
874           - Updated the style unit test file to import python_unittest.py.
875
876         * Scripts/webkitpy/style_references.py:
877           - Adjusted style references to import pep8.
878
879 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
880
881         Reviewed by Dave Levin.
882
883         Rewrote autoinstall.py to support unzipping *.zip files after
884         download, unzipping and extracting *.tar.gz files after download,
885         and copying installed files to a given destination directory.
886
887         https://bugs.webkit.org/show_bug.cgi?id=35163
888
889         These changes will let us autoinstall pep8.py from the web and put
890         our third-party autoinstalled code in an explicit directory like
891         webkitpy/thirdparty/autoinstalled. These changes should also speed
892         up the execution of autoinstalled *.zip packages slightly since
893         *.pyc files cannot be generated when importing from zipped
894         packages using the current autoinstall.
895
896         * Scripts/test-webkitpy:
897           - Addressed the FIXME to enable auto-install logging once
898             autoinstall was rewritten not to log as verbosely.
899
900         * Scripts/webkitpy/common/net/bugzilla.py:
901           - Updated mechanize import statement.
902
903         * Scripts/webkitpy/common/net/buildbot.py:
904           - Updated mechanize import statement.
905
906         * Scripts/webkitpy/common/net/irc/ircbot.py:
907           - Updated ircbot and irclib import statements.
908
909         * Scripts/webkitpy/common/net/networktransaction.py:
910           - Updated mechanize import statement.
911
912         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
913           - Updated mechanize import statement.
914
915         * Scripts/webkitpy/common/net/statusserver.py:
916           - Updated mechanize import statement.
917
918         * Scripts/webkitpy/common/system/autoinstall.py: Added.
919           - Added AutoInstaller class.
920           - Added sample/testing usage to the __main__ block.
921
922         * Scripts/webkitpy/thirdparty/__init__.py:
923           - Updated the autoinstall lines to use the new autoinstall methods.
924           - Added pep8.py to the list of auto-installed packages.
925           - Added a README file to the target autoinstallation directory
926             so users know that the directory is safe to delete.
927
928         * Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
929           - This is replaced by the rewritten autoinstall
930             webkitpy/common/system/autoinstall.py.
931
932         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Removed.
933           - The target autoinstallation directory is now auto-generated.
934
935 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
936
937         Reviewed by Shinichiro Hamaji.
938
939         Tweak webkitpy's logtesting.LogTesting class to get more mileage out
940         of our unit tests that test log messages.
941
942         https://bugs.webkit.org/show_bug.cgi?id=36886
943
944         This patch adds to the LogTesting class's tearDown() method a line
945         asserting that the array of remaining log messages is empty.  This
946         ensures that no extra log messages are getting logged that the caller
947         might not be aware of or may have forgotten to check for.
948
949         * Scripts/webkitpy/common/system/logtesting.py:
950           - Modified the tearDown() method as described above.
951           - Also modified the assertMessages() method to clear the array
952             of log messages after asserting.
953
954 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
955
956         Reviewed by Adam Barth.
957
958         Added support for a --verbose-logging flag to test-webkitpy.
959
960         https://bugs.webkit.org/show_bug.cgi?id=36429
961
962         Verbose logging is useful for debugging test-webkitpy code that
963         runs before the actual unit tests -- things like autoinstalling and
964         unit-test auto-detection logic.  This is different from verbose
965         logging of the unit tests themselves (which corresponds to the
966         unittest module's --verbose flag).
967
968         * Scripts/test-webkitpy:
969           - In the configure_logging() method--
970             - Added an is_verbose_logging parameter that sets the logging
971               level to logging.DEBUG instead of logging.INFO.
972             - Changed the method to throttle the logging level on the
973               root logger's handler instead of directly on the root logger
974               itself.
975             - Enabled logging of the autoinstall module when the flag is set.
976
977         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
978           - Added a work-around for a bug in Python 2.6's logging module
979             that was discovered while working on this patch.
980
981 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
982
983         Reviewed by Adam Barth.
984
985         Enabled Python's logging module for webkit-patch, and replaced
986         deprecated_logging with Python logging in networktransaction.py.
987         This eliminates some spurious output when running test-webkitpy.
988
989         https://bugs.webkit.org/show_bug.cgi?id=36725
990
991         * Scripts/webkit-patch:
992           - Replaced the configure_logging() function with a call to
993             the new logutils.configure_logging() function.
994
995         * Scripts/webkitpy/common/net/networktransaction.py:
996           - Replaced the use of deprecated_logging with Python logging.
997
998         * Scripts/webkitpy/common/system/logutils.py:
999           - Added _default_handlers() which creates the default logging
1000             handler for webkitpy.
1001           - Added configure_logging() which configures default logging
1002             for webkitpy.
1003
1004         * Scripts/webkitpy/common/system/logutils_unittest.py:
1005           - Added unit tests for logutils.configure_logging().
1006
1007         * Scripts/webkitpy/style/checker.py:
1008           - Refactored check-webkit-style's configure_logging() method
1009             to call the new logutils.configure_logging().
1010
1011         * Scripts/webkitpy/style_references.py:
1012           - Updated references as necessary.
1013
1014 2010-03-31  Eric Seidel  <eric@webkit.org>
1015
1016         Reviewed by Adam Barth.
1017
1018         webkit-patch land fails if not run from the root directory
1019         https://bugs.webkit.org/show_bug.cgi?id=35822
1020
1021         The root of the problem was that ChangeLog.__init__ expects a path
1022         relative to the current working directory, and SCM expects to
1023         return paths relative to the SCM root.  Fix it by converting from
1024         SCM-relative to absolute paths in Checkout.modified_changelogs
1025
1026         * Scripts/webkitpy/common/checkout/api.py:
1027         * Scripts/webkitpy/common/checkout/api_unittest.py:
1028
1029 2010-03-31  Adam Barth  <abarth@webkit.org>
1030
1031         Reviewed by Eric Seidel.
1032
1033         Add more tests for webkitpy.common.checkout
1034         https://bugs.webkit.org/show_bug.cgi?id=36926
1035
1036         We don't have a great way of testing checkout, sadly.
1037
1038         * Scripts/webkitpy/common/checkout/api_unittest.py:
1039
1040 2010-03-31  Adam Barth  <abarth@webkit.org>
1041
1042         Reviewed by Eric Seidel.
1043
1044         REGRESSION: EWS crashes on failure
1045         https://bugs.webkit.org/show_bug.cgi?id=36924
1046
1047         Turns out we need to pass one more argument.  My test is kind of lame,
1048         but at least it's there.
1049
1050         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1051         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1052
1053 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
1054
1055         Unreviewed.
1056
1057         Fixed typo in WebKitTools/ChangeLog: opsys -> ospath.
1058
1059 2010-03-31  Adam Barth  <abarth@webkit.org>
1060
1061         Reviewed by Eric Seidel.
1062
1063         Make the EWS go faster by being optimistic
1064         https://bugs.webkit.org/show_bug.cgi?id=36916
1065
1066         Have the EWS be optimistic that a patch will correctly build.  This
1067         should speed up the common case by not requiring two builds for every
1068         patch.
1069
1070         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1071         * Scripts/webkitpy/tool/commands/queues.py:
1072
1073 2010-03-31  Adam Barth  <abarth@webkit.org>
1074
1075         Reviewed by Eric Seidel.
1076
1077         Add the ability to restart sheriffbot from IRC
1078         https://bugs.webkit.org/show_bug.cgi?id=36909
1079
1080         * Scripts/webkitpy/tool/bot/irc_command.py:
1081         * Scripts/webkitpy/tool/bot/queueengine.py:
1082         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1083         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1084
1085 2010-03-31  Adam Barth  <abarth@webkit.org>
1086
1087         Reviewed by Eric Seidel.
1088
1089         Add win-ews to QueueStatusServer
1090         https://bugs.webkit.org/show_bug.cgi?id=36876
1091
1092         The win-ews is still experimental, but it seems to be more or less
1093         running.  We should show its results to the people.
1094
1095         * QueueStatusServer/model/queues.py:
1096         * QueueStatusServer/templates/dashboard.html:
1097         * QueueStatusServer/templates/statusbubble.html:
1098
1099 2010-03-30  Victor Wang  <victorw@chromium.org>
1100
1101         Reviewed by Eric Seidel.
1102
1103         Update rebaseline tool to check the release image diff binary and
1104         fallback to debug if the release version does not exist.
1105
1106         https://bugs.webkit.org/show_bug.cgi?id=36245
1107
1108         * Scripts/webkitpy/layout_tests/port/base.py:
1109         * Scripts/webkitpy/layout_tests/port/chromium.py:
1110         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1111
1112 2010-03-31  Eric Seidel  <eric@webkit.org>
1113
1114         Reviewed by Adam Barth.
1115
1116         Teach buildbot.py how to parse builder activity from /one_box_per_builder
1117         https://bugs.webkit.org/show_bug.cgi?id=36898
1118
1119         I also removed some obsolete FIXMEs and
1120         refactored one_box_per_builder parsing into multiple
1121         methods for easier reading.
1122
1123         * Scripts/webkitpy/common/net/buildbot.py:
1124         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1125
1126 2010-03-31  Dirk Pranke  <dpranke@chromium.org>
1127
1128         Reviewed by Eric Seidel.
1129
1130         Fix logging in new-run-webkit-tests so that we don't report IMAGE
1131         expected failures as unexpected passes when we run with pixel tests
1132         disabled.
1133
1134         This change splits some of the logic embedded into the TestExpectations
1135         classes out into separate pure functions (result_was_expected,
1136         remove_image_failures) to make them easier to test. This also adds
1137         a parameter to matches_an_expected_result() to indicate whether or
1138         not pixel test results should be included in the expectations.
1139
1140         https://bugs.webkit.org/show_bug.cgi?id=36771
1141
1142         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1143         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
1144         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1145
1146 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
1147
1148         Reviewed by Eric Seidel.
1149
1150         In webkitpy, refactored two calls to os.path.relpath() replacements
1151         to use a common method.
1152
1153         https://bugs.webkit.org/show_bug.cgi?id=36891
1154
1155         * Scripts/webkitpy/common/net/bugzilla.py:
1156           - Replaced the relpath implementation with a call to
1157             webkitpy.common.system.ospath.relpath().
1158
1159         * Scripts/webkitpy/common/system/ospath.py: Added.
1160           - Moved the relpath() implementation from style/main.py.
1161
1162         * Scripts/webkitpy/common/system/ospath_unittest.py: Added.
1163           - Moved the relpath() unit tests from style/main_unittest.py.
1164
1165         * Scripts/webkitpy/style/main.py:
1166           - Replaced the relpath implementation with a call to
1167             webkitpy.common.system.ospath.relpath().
1168
1169         * Scripts/webkitpy/style/main_unittest.py:
1170           - Moved the relpath unit tests to ospath_unittest.py.
1171
1172 2010-03-31  Adam Barth  <abarth@webkit.org>
1173
1174         Reviewed by Eric Seidel.
1175
1176         Add a Builder.force_build method
1177         https://bugs.webkit.org/show_bug.cgi?id=36875
1178
1179         We plan to eventually use this in SheriffBot to break deadlocks created
1180         by flaky tests.
1181
1182         * Scripts/webkitpy/common/net/buildbot.py:
1183
1184 2010-03-31  Adam Barth  <abarth@webkit.org>
1185
1186         Reviewed by Eric Seidel.
1187
1188         webkit-patch reads wrong bug url from unified diff context
1189         https://bugs.webkit.org/show_bug.cgi?id=36477
1190
1191         Instead of trying to figure out the bug_id from the diff, we should
1192         just get the information from the Checkout object, which understands
1193         these concepts.
1194
1195         * Scripts/webkitpy/common/checkout/api.py:
1196         * Scripts/webkitpy/common/checkout/commitinfo.py:
1197         * Scripts/webkitpy/tool/commands/download.py:
1198         * Scripts/webkitpy/tool/commands/upload.py:
1199         * Scripts/webkitpy/tool/mocktool.py:
1200
1201 2010-03-31  Adam Barth  <abarth@webkit.org>
1202
1203         Reviewed by Eric Seidel.
1204
1205         webkit-patch commit-queue should land patches optimistically
1206         https://bugs.webkit.org/show_bug.cgi?id=34187
1207
1208         This patch adds an optimistic path to commit-queue and a "fail twice"
1209         requirement for rejecting patches.  That means we'll land good patches
1210         faster (via the optmistic first run) and we'll reject many fewer
1211         patches due to flaky tests.
1212
1213         * Scripts/webkitpy/tool/commands/queues.py:
1214
1215 2010-03-31  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1216
1217         Reviewed by Kenneth Rohde Christiansen.
1218
1219         [Qt] Custom user agent for user agent switcher
1220         https://bugs.webkit.org/show_bug.cgi?id=36757
1221
1222         * QtLauncher/main.cpp:
1223         (LauncherWindow::showUserAgentDialog):
1224
1225 2010-03-31  Eric Seidel  <eric@webkit.org>
1226
1227         Reviewed by Adam Barth.
1228
1229         path to committers.py in commit-queue rejection message is wrong
1230         https://bugs.webkit.org/show_bug.cgi?id=36865
1231
1232         This fix would have only been 3 lines long if we had
1233         1. Had access to an SCM object or tool to give us the checkout root
1234         2. Been able to depend on Python 2.6
1235         Instead I've added a bunch of hack code, but at least now
1236         we should never have to update this string again as the location
1237         of committers.py is fully dynamically discovered. :p
1238
1239         * Scripts/webkitpy/common/net/bugzilla.py:
1240         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1241
1242 2010-03-31  Shinichiro Hamaji  <hamaji@chromium.org>
1243
1244         Unreviewed test fix for r56809.
1245
1246         webkit-patch what-broke throws exception
1247         https://bugs.webkit.org/show_bug.cgi?id=36852
1248
1249         * Scripts/webkitpy/common/checkout/api_unittest.py:
1250
1251 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
1252
1253         Rubber stamped by Dave Levin.
1254
1255         Made check-webkit-style less chatty.
1256
1257         Examples include:
1258          - https://bugs.webkit.org/show_bug.cgi?id=36866#c4
1259          - https://bugs.webkit.org/show_bug.cgi?id=36472#c9
1260
1261         * Scripts/webkitpy/style/checker.py:
1262           - Changed unrecognized file type log message from info to debug.
1263
1264 2010-03-30  Kevin Ollivier  <kevino@theolliviers.com>
1265
1266         [wx] Build fix after new method added.
1267
1268         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1269         (LayoutTestController::callShouldCloseOnWebView):
1270
1271 2010-03-30  Eric Seidel  <eric@webkit.org>
1272
1273         Reviewed by Adam Barth.
1274
1275         webkit-patch what-broke throws exception
1276         https://bugs.webkit.org/show_bug.cgi?id=36852
1277
1278         * Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO.
1279         * Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception.
1280
1281 2010-03-30  Alexey Proskuryakov  <ap@apple.com>
1282
1283         Reviewed by Darin Adler.
1284
1285         https://bugs.webkit.org/show_bug.cgi?id=36616
1286         Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown
1287
1288         https://bugs.webkit.org/show_bug.cgi?id=36797
1289         For non-Roman layouts, keydown Event.keyCode is always 0
1290
1291         * DumpRenderTree/mac/EventSendingController.mm:
1292         (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode
1293         for keys used in tests (we used to always pass 0 for 'A').
1294
1295 2010-03-30  Adam Barth  <abarth@webkit.org>
1296
1297         Reviewed by Eric Seidel.
1298
1299         Implement win-ews
1300         https://bugs.webkit.org/show_bug.cgi?id=36809
1301
1302         * Scripts/webkitpy/common/config/ports.py:
1303         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1304
1305 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
1306
1307         Reviewed by Eric Seidel.
1308
1309         Adjusted test-webkitpy to delete all orphaned *.pyc files
1310         from webkitpy/ prior to importing any modules from webkitpy.
1311         This ensures that no import statements in webkitpy falsely
1312         succeed because of leftover *.pyc files.
1313
1314         https://bugs.webkit.org/show_bug.cgi?id=36599
1315
1316         * Scripts/test-webkitpy:
1317           - Added _clean_pyc_files() to delete orphaned *.pyc files
1318             from a directory.
1319           - Added _clean_webkitpy_with_test() to call and test
1320             _clean_pyc_files().
1321           - Moved the "import webkitpy.python24.versioning" statement
1322             from the top of the module to the init() method -- immediately
1323             after the call to _clean_webkitpy_with_test().
1324
1325 2010-03-30  Fumitoshi Ukai  <ukai@chromium.org>
1326
1327         Reviewed by Shinichiro Hamaji.
1328
1329         [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
1330         https://bugs.webkit.org/show_bug.cgi?id=36811
1331
1332         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
1333         We don't need stdin, so use devnull as stdin.
1334         Same as https://bugs.webkit.org/show_bug.cgi?id=36586
1335
1336         * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
1337
1338 2010-03-29  Eric Seidel  <eric@webkit.org>
1339
1340         Unreviewed, build fix only.
1341
1342         * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
1343
1344 2010-03-29  Hayato Ito  <hayato@chromium.org>
1345
1346         Reviewed by Shinichiro Hamaji.
1347
1348         Remove '_flymake' suffix from base part of file name so that
1349         check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.
1350
1351         https://bugs.webkit.org/show_bug.cgi?id=36573
1352
1353         * Scripts/webkitpy/style/processors/cpp.py:
1354         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1355
1356 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
1357
1358         Reviewed by Eric Seidel.
1359
1360         Get the following test-webkitpy unit test working again:
1361         scm_unittest.SVNTest.test_svn_apply().
1362
1363         https://bugs.webkit.org/show_bug.cgi?id=36696
1364
1365         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1366           - Add leading spaces to the empty lines of the ChangeLog strings.
1367           - Manually set the _reviewer attribute on the Attachment object
1368             to get the tests to pass.
1369
1370 2010-03-29  Martin Robinson  <mrobinson@webkit.org>
1371
1372         Reviewed by Holger Freyther.
1373
1374         [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
1375         https://bugs.webkit.org/show_bug.cgi?id=36390
1376
1377         Suppress debugging messages sent to the GLib logger during DRT runs.
1378
1379         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1380         (logHandler): Added.
1381         (main): Use logHandler as the default GLib log message handler.
1382
1383 2010-03-29  Eric Seidel  <eric@webkit.org>
1384
1385         Reviewed by Adam Barth.
1386
1387         sheriff-bot should comment on bugs when builders break
1388         https://bugs.webkit.org/show_bug.cgi?id=36786
1389
1390         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1391          - Add a new _post_blame_comment_to_bug and all it from process_work_item
1392          - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
1393         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1394          - Test the new _post_blame_comment_to_bug call
1395
1396 2010-03-29  Eric Seidel  <eric@webkit.org>
1397
1398         Reviewed by Adam Barth.
1399
1400         sheriff-bot fails to get information about certain builds
1401         https://bugs.webkit.org/show_bug.cgi?id=36768
1402
1403         This seems to be caused by:
1404         http://buildbot.net/trac/ticket/753
1405         I have no work-around, but for now at least we're logging
1406         the error better.  I also added allow_none to our ServerProxy
1407         creation in case that fixes things for other versions of python.
1408
1409         * Scripts/webkitpy/common/net/buildbot.py:
1410
1411 2010-03-29  Victor Wang  <victorw@chromium.org>
1412
1413         Reviewed by Adam Barth.
1414
1415         Add sign in/out link to TestResults appengine
1416
1417         Add a link to main menu for sign in/out to this appengine.
1418         People signed in with admin privilege could perform
1419         actions that are only allowed to admins like deleting files.
1420
1421         https://bugs.webkit.org/show_bug.cgi?id=36767
1422
1423         * TestResultServer/handlers/menu.py:
1424         * TestResultServer/stylesheets/menu.css:
1425         (.sign):
1426         * TestResultServer/templates/menu.html:
1427
1428 2010-03-29  Eric Seidel  <eric@webkit.org>
1429
1430         Reviewed by Adam Barth.
1431
1432         ValidateReviewer step is draconian and un-tested
1433         https://bugs.webkit.org/show_bug.cgi?id=36792
1434
1435         ValidateReviewer logic was commented out in
1436         http://trac.webkit.org/changeset/56744
1437         That was a symptom of the fact that validatereviewer.py
1438         is too inflexible to be used when real humans are driving webkit-patch.
1439         For now we just disable ValidateReviewer when humans are at the keyboard.
1440
1441         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1442          - Only run when in non-interactive mode.
1443         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
1444          - Test our validation logic to make sure it's sane.
1445
1446 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
1447
1448         Reviewed by Shinichiro Hamaji.
1449
1450         Eliminate explicit slash characters from check-webkit-style's
1451         _rel_path() method to make its implementation more platform
1452         independent.
1453
1454         https://bugs.webkit.org/show_bug.cgi?id=36759
1455
1456         * Scripts/webkitpy/style/main.py:
1457           - Changed to use os.sep instead of slash_chars "/\\".  This can
1458             be done since os.path.abspath() converts slashes to os.sep.
1459
1460 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
1461
1462         Reviewed by Dimitri Glazkov.
1463
1464         Change new-run-webkit-tests to not use more than four threads by
1465         default on the mac port until
1466         https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=36687
1469
1470         * Scripts/webkitpy/layout_tests/port/mac.py:
1471
1472 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
1473
1474         Reviewed by Dimitri Glazkov.
1475
1476         Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=36691
1479
1480         * Scripts/webkitpy/layout_tests/port/mac.py:
1481
1482 2010-03-29  Eric Seidel  <eric@webkit.org>
1483
1484         Reviewed by Adam Barth.
1485
1486         new-run-webkit-tests fails java/lc3 on a clean checkout
1487         https://bugs.webkit.org/show_bug.cgi?id=36078
1488
1489         * Scripts/webkitpy/layout_tests/port/mac.py:
1490          - Build the java support files in check_build
1491          - Unwrap a line which would still fit under 80col
1492
1493 2010-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1494
1495         Reviewed by Simon Fraser.
1496
1497         Add support for Widgets 1.0: View Mode Media Feature
1498         https://bugs.webkit.org/show_bug.cgi?id=35446
1499
1500         Add hooks to the Qt DRT for testing the view mode media feature.
1501
1502         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1503         (LayoutTestController::setViewModeMediaFeature):
1504         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1505
1506 2010-03-29  Adam Barth  <abarth@webkit.org>
1507
1508         Unreviewed.  Update expected results for unit tests.
1509
1510         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1511         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1512
1513 2010-03-29  Adam Barth  <abarth@webkit.org>
1514
1515         Unreviewed.  I think Eric meant svn_revision.
1516
1517         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1518
1519 2010-03-26  Eric Seidel  <eric@webkit.org>
1520
1521         Reviewed by Adam Barth.
1522
1523         webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
1524         https://bugs.webkit.org/show_bug.cgi?id=29311
1525
1526         Now that we have sheriff-bot watching the tree, it can post
1527         rollout patches on behalf of the commit queue.
1528
1529         * Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
1530         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
1531         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1532          - Break IRC logic out into _post_irc_warning for easier testing.
1533          - Add _post_rollout_patch for posting rollout patches to bugzilla.
1534         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1535          - Test _rollout_reason
1536         * Scripts/webkitpy/tool/grammar.py:
1537          - Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
1538         * Scripts/webkitpy/tool/grammar_unittest.py:
1539          - Test join_with_separators
1540
1541 2010-03-29  Adam Barth  <abarth@webkit.org>
1542
1543         Reviewed by Eric Seidel.
1544
1545         Sheriffbot should actually run commands
1546         https://bugs.webkit.org/show_bug.cgi?id=36776
1547
1548         Some minor changes to Sheriffbot:
1549
1550         1) We should actually run commands (by giving control back to the
1551         command processing object.
1552
1553         2) Use URLs instead of just numbers to represent SVN revisions (making
1554         it easier to folks in IRC ot followup).
1555
1556         * Scripts/webkitpy/tool/bot/irc_command.py:
1557         * Scripts/webkitpy/tool/bot/queueengine.py:
1558         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1559
1560 2010-03-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1561
1562         Reviewed by Antti Koivisto.
1563
1564         Renaming of frame flattening LayoutTestController method
1565         to setFrameFlatteningEnabled(bool)
1566
1567         * DumpRenderTree/LayoutTestController.cpp:
1568         (setFrameFlatteningEnabledCallback):
1569         (LayoutTestController::staticFunctions):
1570         * DumpRenderTree/LayoutTestController.h:
1571         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1572         (LayoutTestController::setFrameFlatteningEnabled):
1573         * DumpRenderTree/mac/DumpRenderTree.mm:
1574         (resetDefaultsToConsistentValues):
1575         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1576         (LayoutTestController::setFrameFlatteningEnabled):
1577         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1578         (WebCore::WebPage::resetSettings):
1579         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1580         (LayoutTestController::setFrameFlatteningEnabled):
1581         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1582         * DumpRenderTree/win/DumpRenderTree.cpp:
1583         (resetDefaultsToConsistentValues):
1584         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1585         (LayoutTestController::setFrameFlatteningEnabled):
1586         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1587         (LayoutTestController::setFrameFlatteningEnabled):
1588
1589 2010-03-28  Gustavo Noronha Silva  <gns@gnome.org>
1590
1591         No review, rolling out r56679.
1592         http://trac.webkit.org/changeset/56679
1593         https://bugs.webkit.org/show_bug.cgi?id=36454
1594
1595         Lots of tests broken.
1596
1597         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1598         (createWebView):
1599
1600 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1601
1602         Unreviewed.
1603
1604         Fixed typo in deprecated_logging_unittest.py, which is masking
1605         sys.stderr while running test-webkitpy.
1606
1607         See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3
1608
1609         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
1610
1611 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1612
1613         Reviewed by Shinichiro Hamaji.
1614
1615         Renamed check-webkit-style's --debug flag to --verbose to be more
1616         in line with other WebKit scripts.  Also renamed the current
1617         --verbose flag to --min-confidence to allow the --debug rename.
1618
1619         https://bugs.webkit.org/show_bug.cgi?id=36521
1620
1621         We also renamed the internal "verbose" variables to "confidence" or
1622         "min_confidence," as appropriate, to avoid confusion with the
1623         --verbose flag, and because the new names are more accurate.
1624
1625         * Scripts/check-webkit-style:
1626           - Renamed is_debug to is_verbose.
1627
1628         * Scripts/webkitpy/style/checker.py:
1629           - Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE.
1630           - Renamed "verbosity" parameters to "min_confidence" throughout.
1631           - Renamed configure_logging()'s is_debug parameter to is_verbose.
1632
1633         * Scripts/webkitpy/style/checker_unittest.py:
1634           - Updated the unit tests as necessary.
1635
1636         * Scripts/webkitpy/style/error_handlers.py:
1637           - Updated the call to StyleCheckerConfiguration.write_style_error().
1638
1639         * Scripts/webkitpy/style/error_handlers_unittest.py:
1640           - Updated the unit tests as necessary.
1641
1642         * Scripts/webkitpy/style/optparser.py:
1643           - Updated the usage string with the new flag names.
1644           - Renamed the verbosity parameter to min_confidence throughout.
1645           - Renamed the is_debug parameter to is_verbose throughout.
1646
1647         * Scripts/webkitpy/style/optparser_unittest.py:
1648           - Updated the unit tests as necessary.
1649
1650         * Scripts/webkitpy/style/processors/cpp.py:
1651           - Renamed the verbosity parameter to min_confidence throughout.
1652
1653         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1654           - Updated the unit tests as necessary.
1655
1656 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1657
1658         Unreviewed.
1659
1660         Added back a line that accidentally got deleted in r56690.
1661
1662         * Scripts/check-webkit-style:
1663
1664 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1665
1666         Reviewed by Shinichiro Hamaji.
1667
1668         Add to check-webkit-style support for checking directories.
1669
1670         https://bugs.webkit.org/show_bug.cgi?id=35234
1671
1672         * Scripts/check-webkit-style:
1673           - Replaced the call to check_file() with a call to check_paths().
1674
1675         * Scripts/webkitpy/style/checker.py:
1676           - In the StyleChecker class:
1677             - Added a check_paths() method that accepts a list of paths
1678               to files and directories.
1679             - Added a _check_directory() method that checks the files
1680               in a directory.
1681
1682         * Scripts/webkitpy/style/checker_unittest.py:
1683           - Added a StyleCheckerCheckPathsTest to unit-test the new
1684             check_paths() method.
1685
1686         * Scripts/webkitpy/style/optparser.py:
1687           - Updated the usage string.
1688
1689 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1690
1691         Reviewed by Shinichiro Hamaji.
1692
1693         Changed check-webkit-style to convert paths to paths relative to
1694         the checkout root when invoking check-webkit-style with path
1695         arguments.  Also added warning messages where appropriate.
1696
1697         https://bugs.webkit.org/show_bug.cgi?id=35498
1698
1699         Converting paths to paths relative to the checkout root ensures
1700         that style checking will behave as expected (since path-specific
1701         rules assume input paths are relative to a source root).
1702
1703         * Scripts/check-webkit-style:
1704           - Added debug logging of whether the current directory was found
1705             to be in a WebKit checkout.
1706           - Added the found_checkout parameter to the call to parser.parse().
1707           - Renamed the files variable to paths.
1708           - Added a call to change_directory() prior to checking style.
1709
1710         * Scripts/webkitpy/style/checker.py:
1711           - For StyleChecker.check_file():
1712             - Updated the docstring.
1713             - Added two log messages.
1714
1715         * Scripts/webkitpy/style/checker_unittest.py:
1716           - Updated a call to parser.parse() with the found_checkout parameter.
1717
1718         * Scripts/webkitpy/style/main.py: Added.
1719           - Added a new file so the code in this patch could be unit-tested,
1720             as opposed to adding new code to check-webkit-style.
1721           - Added the method _rel_path() as a substitute for os.path.relpath(),
1722             which is available only in Python 2.6.
1723           - Added the method change_directory(), which contains most of the
1724             new functionality in this patch.
1725
1726         * Scripts/webkitpy/style/main_unittest.py: Added.
1727           - Added RelPathTest to test main._rel_path().
1728           - Added ChangeDirectoryTest to test main.change_directory().
1729
1730         * Scripts/webkitpy/style/optparser.py:
1731           - Updated check-webkit-style's usage string.
1732           - For the ArgumentParser.parse() method:
1733             - Added a found_checkout parameter.
1734             - Renamed filenames to paths.
1735             - Added logic so that an error is raised if no paths are passed
1736               if found_checkout is False.
1737
1738         * Scripts/webkitpy/style/optparser_unittest.py:
1739           - Updated the ArgumentParser.parse() unit tests to include
1740             coverage for the new found_checkout parameter.
1741
1742         * Scripts/webkitpy/style/unittests.py:
1743           - Added an import statement for main_unittest.
1744
1745         * Scripts/webkitpy/style_references.py:
1746           - Renamed SimpleScm to WebKitCheckout.
1747           - Added a detect_checkout() function to allow returning None
1748             instead of a WebKitCheckout instance if no checkout is found.
1749           - Renamed checkout_root to root_path.
1750
1751 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1752
1753         Reviewed by Eric Seidel.
1754
1755         Print didHandleOnloadEventsForFrame in the callback of
1756         onload-event signal comming from frame loader
1757
1758         [GTK] Improve reporting of frame loader callbacks in DRT
1759         https://bugs.webkit.org/show_bug.cgi?id=36454
1760
1761         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1762         (webViewOnloadEvent):
1763         (createWebView): added connection to signal::onload-event and
1764         signal callback
1765
1766 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1767
1768         Reviewed by Eric Seidel.
1769
1770         Print didCommitLoadForFrame in the callback of signal::load-committed
1771
1772         [GTK] Improve reporting of frame loader callbacks in DRT
1773         https://bugs.webkit.org/show_bug.cgi?id=36454
1774
1775         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1776         (webViewLoadCommitted):
1777         (createWebView): added connection to sinal::load-committed and
1778         signal callback
1779
1780 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1781
1782         Reviewed by Eric Seidel.
1783
1784         Print didStartProvisionalLoadForFrame in the callback of
1785         notify::load-status property change notification
1786
1787         [GTK] Improve reporting of frame loader callbacks in DRT
1788         https://bugs.webkit.org/show_bug.cgi?id=36454
1789
1790         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1791         (webInspectorCloseWindow):
1792         (webInspectorInspectWebView):
1793         (createWebView): added connection to notify::load-status and
1794         signal callback
1795
1796 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
1797
1798         Reviewed by Adam Barth.
1799
1800         In webkitpy/, deleted the /unittests.py files since test-webkitpy
1801         now auto-detects all *_unittest.py files.
1802
1803         https://bugs.webkit.org/show_bug.cgi?id=36712
1804
1805         * Scripts/webkitpy/common/net/irc/unittests.py: Removed.
1806         * Scripts/webkitpy/common/system/unittests.py: Removed.
1807         * Scripts/webkitpy/common/thread/unittests.py: Removed.
1808         * Scripts/webkitpy/common/unittests.py: Removed.
1809         * Scripts/webkitpy/python24/unittests.py: Removed.
1810         * Scripts/webkitpy/style/unittests.py: Removed.
1811         * Scripts/webkitpy/tool/unittests.py: Removed.
1812         * Scripts/webkitpy/unittests.py: Removed.
1813
1814 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1815
1816         Reviewed by Eric Seidel.
1817
1818         Add a CR after printing didFinishDocumentLoadForFrame
1819
1820         [GTK] Improve reporting of frame loader callbacks in DRT
1821         https://bugs.webkit.org/show_bug.cgi?id=36454
1822
1823         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1824         (webViewLoadFinished):
1825
1826 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
1827
1828         Rubber-stamped by Adam Barth.
1829
1830         Fixed the name of a unit test file in webkitpy.
1831
1832         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
1833         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.
1834
1835 2010-03-26  Chris Jerdonek  <cjerdonek@webkit.org>
1836
1837         Reviewed by Adam Barth.
1838
1839         The test-webkitpy script now automatically detects all unit-test
1840         files in webkitpy/.  This lets us eliminate the need to have and
1841         maintain all of the unittests.py files.
1842
1843         https://bugs.webkit.org/show_bug.cgi?id=36591
1844
1845         * Scripts/test-webkitpy:
1846           - Replaced the "from webkitpy.unittests import *" with a call
1847             to webkitpy.test.main.Tester().run_tests().
1848
1849         * Scripts/webkitpy/test/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1850           - Required file for the new webkitpy/test/ directory.
1851
1852         * Scripts/webkitpy/test/main.py: Added.
1853           - Added a Tester class that contains the following methods:
1854             - _find_unittest_files() to detect all the unit-test files.
1855             - _modules_from_paths() to convert the paths to the unit-test
1856               files to fully-qualified module names.
1857             - run_tests() which calls the above two methods and then passes
1858               the module names to Python's unittest module.
1859
1860 2010-03-27  Robert Hogan  <robert@webkit.org>
1861
1862         Reviewed by Simon Fraser.
1863
1864         [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.
1865
1866         https://bugs.webkit.org/show_bug.cgi?id=36701
1867
1868         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1869         (webkit_test_plugin_new_instance): Add onSetWindow.
1870         (webkit_test_plugin_destroy_instance): Add onSetWindow.
1871         (webkit_test_plugin_set_window): Add onSetWindow.
1872         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1873         (NPP_New): Add onSetWindow.
1874         (NPP_Destroy): Add onSetWindow.
1875         (NPP_SetWindow): Add onSetWindow.
1876
1877 2010-03-26  Robert Hogan  <robert@roberthogan.net>
1878
1879         Reviewed by Simon Hausmann.
1880
1881         Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',
1882          when pluginsEnabled is false.
1883
1884         Add support for LayoutTestController.WebKitPluginsEnabled
1885
1886         https://bugs.webkit.org/show_bug.cgi?id=32196
1887
1888         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1889         (resetDefaultsToConsistentValues):
1890         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1891         (copyWebSettingKey):
1892         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1893         (WebCore::WebPage::resetSettings):
1894         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1895         (LayoutTestController::overridePreference):
1896
1897 2010-03-26  Adam Barth  <abarth@webkit.org>
1898
1899         Reviewed by Eric Seidel.
1900
1901         Add some basic IRC commands to sheriffbot
1902         https://bugs.webkit.org/show_bug.cgi?id=36684
1903
1904         Adds support for sheriffbot to respond to a "hi" command and a
1905         "last-green-revision" command.  It's lame that we're rebuilding
1906         MultiCommandTool, but as discussed in person we'll intergrate the two
1907         once we see what the requirements are.
1908
1909         * Scripts/webkitpy/tool/bot/irc_command.py: Added.
1910         * Scripts/webkitpy/tool/bot/queueengine.py:
1911         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1912         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1913         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added.
1914         * Scripts/webkitpy/tool/commands/queues.py:
1915         * Scripts/webkitpy/tool/commands/queuestest.py:
1916         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1917         * Scripts/webkitpy/tool/main.py:
1918         * Scripts/webkitpy/tool/mocktool.py:
1919         * Scripts/webkitpy/tool/unittests.py:
1920
1921 2010-03-26  Adam Barth  <abarth@webkit.org>
1922
1923         Unreviewed.  More errors in the IRC module.  I have no idea how to test
1924         ircbot.py, which is too bad.  Hopefully we've abstracted it away enough
1925         that we don't have to touch it very much after this patch.
1926
1927         * Scripts/webkitpy/common/net/irc/ircbot.py:
1928
1929 2010-03-26  Adam Barth  <abarth@webkit.org>
1930
1931         Unreviewed.  Add a missing "_".
1932
1933         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1934         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added.
1935         * Scripts/webkitpy/common/net/irc/unittests.py:
1936
1937 2010-03-26  Adam Barth  <abarth@webkit.org>
1938
1939         Unreviewed.  Fix a the commit queue after my recent change.
1940
1941         * Scripts/webkitpy/tool/bot/queueengine.py:
1942
1943 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1944
1945         Unreviewed fix.
1946
1947         Fix the return value for port/base.diff_image (changed from 1/0 to
1948         True/False in bug 34826.
1949
1950         * Scripts/webkitpy/layout_tests/port/base.py:
1951
1952 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1953
1954         Reviewed by Eric Seidel.
1955
1956         Change the Mac port of new-run-webkit-tests to look for a
1957         test_expectations.txt file in addition to the Skipped files, so we
1958         can track pixel failures.
1959
1960         https://bugs.webkit.org/show_bug.cgi?id=36619
1961
1962         * Scripts/webkitpy/layout_tests/port/mac.py:
1963
1964 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1965
1966         Reviewed by Eric Seidel.
1967
1968         Implement pixel tests (image diff) properly on the Mac port.
1969
1970         This change introduces a new "ServerPocess" class that can be used
1971         to manage processes that the run-webkit-tests harness forks off and
1972         expects to stay up for longer than a single request/response session.
1973         Both DumpRenderTree and ImageDiff use this style of communication,
1974         although the current code forks off a new ImageDiff for each diff
1975         (We need to restructure other parts of the code to be able to do this
1976         safely in a multi-threaded environment).
1977
1978         Also, now that the ServerProcess abstraction exists, we can probably
1979         clean up and simplify some of the thread management logic in
1980         test_shell_thread as well.
1981
1982         https://bugs.webkit.org/show_bug.cgi?id=34826
1983
1984         * Scripts/webkitpy/layout_tests/port/mac.py:
1985         * Scripts/webkitpy/layout_tests/port/server_process.py:
1986         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1987
1988 2010-03-26  Sergio Villar Senin  <svillar@igalia.com>
1989
1990         Reviewed by Eric Seidel.
1991
1992         Print didFinishLoadForFrame outcome in DRT
1993
1994         [GTK] Improve reporting of frame loader callbacks in DRT
1995         https://bugs.webkit.org/show_bug.cgi?id=36454
1996
1997         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1998         (webViewLoadCommitted):
1999
2000 2010-03-26  Eric Seidel  <eric@webkit.org>
2001
2002         Unreviewed test fix.
2003         My change conflicted with one of Adam's causing test-webkitpy to fail.
2004
2005         Move commit_message_for_this_commit from scm to checkout
2006         https://bugs.webkit.org/show_bug.cgi?id=36629
2007
2008         * Scripts/webkitpy/common/checkout/api_unittest.py:
2009          - modified_changelogs is now on Checkout instead of scm.
2010
2011 2010-03-26  Adam Barth  <abarth@webkit.org>
2012
2013         Reviewed by Eric Seidel.
2014
2015         Refactor IRCBot controller logic to allow for commands
2016         https://bugs.webkit.org/show_bug.cgi?id=36676
2017
2018         We need to move the controller logic into the tool package so it can
2019         know about commands.  The changes to queueengine could go in a
2020         different patch, but we're going to need it anyway.
2021
2022         * Scripts/webkitpy/common/config/irc.py: Added.
2023         * Scripts/webkitpy/common/net/irc/ircbot.py:
2024         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2025         * Scripts/webkitpy/tool/bot/queueengine.py:
2026         * Scripts/webkitpy/tool/bot/sheriffircbot.py: Added.
2027         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2028         * Scripts/webkitpy/tool/main.py:
2029         * Scripts/webkitpy/tool/mocktool.py:
2030
2031 2010-03-26  Adam Barth  <abarth@webkit.org>
2032
2033         Rubber stamped by Eric Seidel.
2034
2035         Move the threading code into its own module.  (It has nothing to do with IRC.)
2036
2037         * Scripts/webkitpy/common/net/irc/ircbot.py:
2038         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2039         * Scripts/webkitpy/common/net/irc/messagepump.py: Removed.
2040         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed.
2041         * Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed.
2042         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed.
2043         * Scripts/webkitpy/common/net/irc/unittests.py:
2044         * Scripts/webkitpy/common/thread: Added.
2045         * Scripts/webkitpy/common/thread/__init__.py: Added.
2046         * Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py.
2047         * Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py.
2048         * Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py.
2049         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py.
2050         * Scripts/webkitpy/common/thread/unittests.py: Added.
2051         * Scripts/webkitpy/common/unittests.py:
2052
2053 2010-03-26  Eric Seidel  <eric@webkit.org>
2054
2055         Reviewed by Adam Barth.
2056
2057         Move commit_message_for_this_commit from scm to checkout
2058         https://bugs.webkit.org/show_bug.cgi?id=36629
2059
2060         Finally add some basic unit testing for Checkout.commit_message_for_this_commit
2061
2062         * Scripts/webkitpy/common/checkout/api.py:
2063         * Scripts/webkitpy/common/checkout/api_unittest.py: Added.
2064         * Scripts/webkitpy/common/unittests.py:
2065
2066 2010-03-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2067
2068         [Qt] User Agent Switcher on QtLauncher
2069         https://bugs.webkit.org/show_bug.cgi?id=36451
2070
2071         Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26
2072         Reviewed by Simon Hausmann.
2073
2074         Make possible to change the QtLauncher user agent via
2075         a predefined list.
2076
2077         * QtLauncher/QtLauncher.pro:
2078         * QtLauncher/QtLauncher.qrc: Added.
2079         * QtLauncher/main.cpp:
2080         (LauncherWindow::showUserAgentDialog):
2081         (LauncherWindow::createChrome):
2082         * QtLauncher/useragentlist.txt: Added.
2083         * QtLauncher/webpage.cpp:
2084         (WebPage::userAgentForUrl):
2085         * QtLauncher/webpage.h:
2086         (WebPage::setUserAgent):
2087
2088 2010-03-26  Victor Wang  <victorw@chromium.org>
2089
2090         Reviewed by Adam Barth.
2091
2092         Host layout test flakiness dashboard in TestResultServer appengine.
2093
2094         Flakiness dashboard is a tool to monitor layout test status and
2095         help layout test regression diagnostics.
2096
2097         https://bugs.webkit.org/show_bug.cgi?id=36195
2098
2099         * TestResultServer/handlers/dashboardhandler.py: Added.
2100          - New handler to handle dashboard request
2101         * TestResultServer/handlers/menu.py:
2102          - Add new dashboard links
2103         * TestResultServer/handlers/testfilehandler.py:
2104          - Request routes refactory
2105         * TestResultServer/index.yaml:
2106         * TestResultServer/main.py:
2107          - Add new dashboard request routes and refactor test result file rountes.
2108         * TestResultServer/model/dashboardfile.py: Added.
2109          - Model to access datastore for dashboard files
2110         * TestResultServer/model/testfile.py:
2111         * TestResultServer/stylesheets/dashboardfile.css: Added.
2112         * TestResultServer/templates/dashboardfilelist.html: Added.
2113         * TestResultServer/templates/showfilelist.html:
2114
2115 2010-03-26  Adam Barth  <abarth@webkit.org>
2116
2117         Reviewed by Eric Seidel.
2118
2119         Remove some evil statics from CommitInfo
2120         https://bugs.webkit.org/show_bug.cgi?id=36637
2121
2122         These methods should really be on checkout.  You can tell because they
2123         know about ChangeLogs and take an SCM as an argument.  :)
2124
2125         * Scripts/webkitpy/common/checkout/api.py:
2126         * Scripts/webkitpy/common/checkout/changelog.py:
2127         * Scripts/webkitpy/common/checkout/commitinfo.py:
2128         * Scripts/webkitpy/tool/commands/queries.py:
2129
2130 2010-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2131
2132         Reviewed by Simon Hausmann.
2133
2134         Add an option to QtLauncher to enable/disable a QGLWidget as Viewport
2135         of the QGraphicsView when the launcher is running on graphicsview mode.
2136
2137         [Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport
2138         https://bugs.webkit.org/show_bug.cgi?id=36270
2139
2140         * QtLauncher/QtLauncher.pro:
2141         * QtLauncher/main.cpp:
2142         (LauncherWindow::toggleQGLWidgetViewport):
2143         (LauncherWindow::createChrome):
2144
2145 2010-03-26  Fumitoshi Ukai  <ukai@chromium.org>
2146
2147         Reviewed by Shinichiro Hamaji.
2148
2149         [Chromium-Win] websocket_server.py failed to start
2150         https://bugs.webkit.org/show_bug.cgi?id=36586
2151         
2152         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
2153         We don't need stdin, so use devnull as stdin.
2154
2155         * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin
2156
2157 2010-03-26  Kent Tamura  <tkent@chromium.org>
2158
2159         Reviewed by Dimitri Glazkov.
2160
2161         [DRT/Chromium] Add TestNavigationController and TestWebWorker
2162         https://bugs.webkit.org/show_bug.cgi?id=36520
2163
2164         Add LayoutTestController class, which is going to be used by
2165         DumpRenderTree Chromium port. These files are based on:
2166         - src/webkit/tools/test_shell/layout_test_controller.cc
2167         - src/webkit/tools/test_shell/layout_test_controller.h
2168         of Chromium rev.40492.
2169
2170         * DumpRenderTree/chromium/LayoutTestController.cpp: Added.
2171         * DumpRenderTree/chromium/LayoutTestController.h: Added.
2172
2173 2010-03-25  Charlie Reis  <creis@chromium.org>
2174
2175         Reviewed by Adam Barth.
2176
2177         onbeforeunload not called at window close + frame or iframe focused
2178         https://bugs.webkit.org/show_bug.cgi?id=27481
2179
2180         Adds a callShouldCloseOnWebView method to LayoutTestController,
2181         to allow automated testing for bug 27481.
2182
2183         * DumpRenderTree/LayoutTestController.cpp:
2184         (callShouldCloseOnWebViewCallback):
2185         (LayoutTestController::staticFunctions):
2186         * DumpRenderTree/LayoutTestController.h:
2187         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2188         (LayoutTestController::callShouldCloseOnWebView):
2189         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2190         (LayoutTestController::callShouldCloseOnWebView):
2191         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2192         (LayoutTestController::callShouldCloseOnWebView):
2193         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2194         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2195         (LayoutTestController::callShouldCloseOnWebView):
2196
2197 2010-03-25  Eric Seidel  <eric@webkit.org>
2198
2199         Reviewed by Adam Barth.
2200
2201         Add webkit-patch lkgr for finding last known good revision
2202         https://bugs.webkit.org/show_bug.cgi?id=36626
2203
2204         This is rather slow for now because the command
2205         has to compute this information from the buildbot.
2206         A better long-term solution would be to have a server
2207         somewhere store a pre-computed LKGR and then any
2208         script (like webkit-patch) could just fetch it.
2209
2210         * Scripts/webkitpy/common/net/buildbot.py:
2211         * Scripts/webkitpy/tool/commands/queries.py:
2212
2213 2010-03-25  Adam Barth  <abarth@webkit.org>
2214
2215         Reviewed by Eric Seidel.
2216
2217         Move modified_changelogs (and friends) from scm to checkout
2218         https://bugs.webkit.org/show_bug.cgi?id=36636
2219
2220         These functions know about ChangeLogs, which is forbidden knowledge in
2221         scm.py.
2222
2223         * Scripts/webkitpy/common/checkout/api.py:
2224         * Scripts/webkitpy/common/checkout/changelog.py:
2225         * Scripts/webkitpy/common/checkout/scm.py:
2226         * Scripts/webkitpy/tool/mocktool.py:
2227         * Scripts/webkitpy/tool/steps/abstractstep.py:
2228         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2229         * Scripts/webkitpy/tool/steps/revertrevision.py:
2230         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2231         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2232
2233 2010-03-25  Adam Barth  <abarth@webkit.org>
2234
2235         Reviewed by Eric Seidel.
2236
2237         Move apply_patch from scm to checkout
2238         https://bugs.webkit.org/show_bug.cgi?id=36635
2239
2240         SCM shouldn't have any knowledge of WebKit scripts.
2241
2242         * Scripts/webkitpy/common/checkout/api.py:
2243         * Scripts/webkitpy/common/checkout/scm.py:
2244         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2245         * Scripts/webkitpy/tool/mocktool.py:
2246         * Scripts/webkitpy/tool/steps/applypatch.py:
2247
2248 2010-03-25  Eric Seidel  <eric@webkit.org>
2249
2250         Unreviewed build fix to un-break webkit-patch land.
2251         Test-case coming in follow-up commit.
2252
2253         Move commit_message_for_this_commit from scm to checkout
2254         https://bugs.webkit.org/show_bug.cgi?id=36629
2255
2256         * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
2257
2258 2010-03-25  Dan Bernstein  <mitz@apple.com>
2259
2260         Reviewed by Darin Adler.
2261
2262         <rdar://problem/7728903> Support color bitmap fonts
2263
2264         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
2265         and ColorBits-A.png.
2266         * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
2267         * DumpRenderTree/fonts/ColorBits.ttf: Added.
2268         * DumpRenderTree/mac/DumpRenderTree.mm:
2269         (activateFonts): Activate ColorBits.ttf.
2270
2271 2010-03-25  Mark Rowe  <mrowe@apple.com>
2272
2273         Remove a printf that was causing commit-log-editor to spew the name of the editor
2274         to the terminal many times during a commit.
2275
2276         * Scripts/commit-log-editor:
2277
2278 2010-03-25  Adam Barth  <abarth@webkit.org>
2279
2280         Reviewed by Eric Seidel.
2281
2282         Move commit_message_for_this_commit from scm to checkout
2283         https://bugs.webkit.org/show_bug.cgi?id=36629
2284
2285         This function requires knowledge of ChangeLogs, but scm shouldn't know
2286         about ChangeLogs.
2287
2288         * Scripts/webkitpy/common/checkout/api.py:
2289         * Scripts/webkitpy/common/checkout/scm.py:
2290         * Scripts/webkitpy/tool/commands/upload.py:
2291         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2292         * Scripts/webkitpy/tool/mocktool.py:
2293         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
2294         * Scripts/webkitpy/tool/steps/commit.py:
2295
2296 2010-03-25  Adam Barth  <abarth@webkit.org>
2297
2298         Reviewed by Eric Seidel.
2299
2300         REGRESSION: webkit-patch land can't land "rubber-stamped" patches
2301         https://bugs.webkit.org/show_bug.cgi?id=36582
2302
2303         Allow a "-" in rubber stamped.
2304
2305         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2306
2307 2010-03-25  Adam Barth  <abarth@webkit.org>
2308
2309         Unreviewed.  Fix some copyright lines to remove extraneous comma and
2310         python directive.
2311
2312         * Scripts/webkitpy/tool/bot/patchcollection.py:
2313         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
2314         * Scripts/webkitpy/tool/bot/queueengine.py:
2315         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2316         * Scripts/webkitpy/tool/commands/download.py:
2317         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2318         * Scripts/webkitpy/tool/commands/queries.py:
2319         * Scripts/webkitpy/tool/commands/queues.py:
2320         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2321         * Scripts/webkitpy/tool/comments.py:
2322         * Scripts/webkitpy/tool/grammar.py:
2323         * Scripts/webkitpy/tool/multicommandtool.py:
2324         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2325
2326 2010-03-25  Simon Fraser  <simon.fraser@apple.com>
2327
2328         Reviewed by Darin Adler, Alexey Proskuryakov.
2329
2330         https://bugs.webkit.org/show_bug.cgi?id=36631
2331         Allow the test plugin to run scripts in response to NPP_SetWindow calls
2332         
2333         Hook up the ability for the TestNetscapePlugIn to run JavaScript in
2334         response to NPP_SetWindow.
2335         
2336         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2337         (pluginAllocate):
2338         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2339         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2340         (NPP_New):
2341         (NPP_Destroy):
2342         (NPP_SetWindow):
2343
2344 2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2345
2346         Unreviewed, build fix.
2347
2348         [Qt] Fix QtLauncher guards.
2349
2350         * QtLauncher/main.cpp:
2351         (LauncherWindow::showFPS):
2352         (LauncherWindow::updateFPS):
2353
2354 2010-03-25  Yury Semikhatsky  <yurys@chromium.org>
2355
2356         Reviewed by Pavel Feldman.
2357
2358         Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.
2359
2360         https://bugs.webkit.org/show_bug.cgi?id=36610
2361
2362         * DumpRenderTree/LayoutTestController.h:
2363         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2364         (shouldEnableDeveloperExtras):
2365         (runTest):
2366         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2367         (LayoutTestController::setJavaScriptProfilingEnabled):
2368         (LayoutTestController::setDeveloperExtrasEnabled):
2369         (LayoutTestController::showWebInspector):
2370         (LayoutTestController::closeWebInspector):
2371         * DumpRenderTree/mac/DumpRenderTree.mm:
2372         (shouldEnableDeveloperExtras):
2373         (runTest):
2374         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2375         (LayoutTestController::setJavaScriptProfilingEnabled):
2376         (LayoutTestController::setDeveloperExtrasEnabled):
2377         (LayoutTestController::showWebInspector):
2378         (LayoutTestController::closeWebInspector):
2379         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2380         (WebCore::shouldEnableDeveloperExtras):
2381         (WebCore::DumpRenderTree::open):
2382         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2383         (LayoutTestController::closeWebInspector):
2384         (LayoutTestController::setDeveloperExtrasEnabled):
2385         (LayoutTestController::showWebInspector):
2386         (LayoutTestController::setJavaScriptProfilingEnabled):
2387         * DumpRenderTree/win/DumpRenderTree.cpp:
2388         (shouldEnableDeveloperExtras):
2389         (runTest):
2390         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2391         (LayoutTestController::setJavaScriptProfilingEnabled):
2392         (LayoutTestController::setDeveloperExtrasEnabled):
2393         (LayoutTestController::showWebInspector):
2394         (LayoutTestController::closeWebInspector):
2395
2396 2010-03-25  Adam Barth  <abarth@webkit.org>
2397
2398         Rubber stamped by Eric Seidel.
2399
2400         Tweaks to sheriffbot to improve latency by keeping the working copy up
2401         to date even when there's no build break.  Also, officially move
2402         sheriffbot to #webkit.
2403
2404         (Also teach ValidateReviewer to understand rubber stamps.)
2405
2406         * Scripts/webkitpy/common/net/irc/ircbot.py:
2407         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2408         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2409
2410 2010-03-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2411
2412         Reviewed by Simon Hausmann.
2413
2414         Not displaying FPS info on the terminal. On S60 and Maemo the
2415         Window title will be used and Status bar will used on desktop.
2416
2417         [Qt] QtLauncher's FPS info should not be displayed on the terminal
2418         https://bugs.webkit.org/show_bug.cgi?id=36244
2419
2420         * QtLauncher/main.cpp:
2421         (LauncherWindow::initializeView):
2422         (LauncherWindow::showFPS):
2423         (LauncherWindow::updateFPS):
2424         * QtLauncher/webview.cpp:
2425         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
2426         (WebViewGraphicsBased::updateFrameRate):
2427         * QtLauncher/webview.h:
2428         (WebViewGraphicsBased::frameRateMeasurementEnabled):
2429
2430 2010-03-25  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2431
2432         Reviewed by Kenneth Christiansen.
2433
2434         Added missing frame flattening activation on
2435         fast/frames/flattening/frameset-flattening-grid.html;
2436         removed unnecessary CONSOLE MESSAGE from the expected file;
2437         reset the setFrameSetFlatteningEnabled for each test.
2438
2439         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2440         (WebCore::WebPage::resetSettings):
2441
2442 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2443
2444         Reviewed by Adam Barth.
2445
2446         Moved deprecated_logging unit test import statement from
2447         webkitpy/unittests.py to webkitpy/common/system/unittests.py.
2448
2449         https://bugs.webkit.org/show_bug.cgi?id=36093
2450
2451         This is part of the master bug to reorganize webkitpy.
2452
2453         * Scripts/webkitpy/common/system/unittests.py:
2454         * Scripts/webkitpy/unittests.py:
2455
2456 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2457
2458         Reviewed by Adam Barth.
2459
2460         Moved webkit_logging.py to common/system/deprecated_logging.py
2461         inside webkitpy.
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=36093
2464
2465         This is part of the master bug to reorganize webkitpy.
2466
2467         * Scripts/validate-committer-lists:
2468         * Scripts/webkitpy/common/checkout/changelog.py:
2469         * Scripts/webkitpy/common/checkout/scm.py:
2470         * Scripts/webkitpy/common/net/bugzilla.py:
2471         * Scripts/webkitpy/common/net/buildbot.py:
2472         * Scripts/webkitpy/common/net/credentials.py:
2473         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2474         * Scripts/webkitpy/common/net/networktransaction.py:
2475         * Scripts/webkitpy/common/net/statusserver.py:
2476         * Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
2477         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
2478         * Scripts/webkitpy/common/system/executive.py:
2479         * Scripts/webkitpy/tool/bot/queueengine.py:
2480         * Scripts/webkitpy/tool/commands/download.py:
2481         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2482         * Scripts/webkitpy/tool/commands/openbugs.py:
2483         * Scripts/webkitpy/tool/commands/queries.py:
2484         * Scripts/webkitpy/tool/commands/queues.py:
2485         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2486         * Scripts/webkitpy/tool/commands/stepsequence.py:
2487         * Scripts/webkitpy/tool/commands/upload.py:
2488         * Scripts/webkitpy/tool/main.py:
2489         * Scripts/webkitpy/tool/mocktool.py:
2490         * Scripts/webkitpy/tool/multicommandtool.py:
2491         * Scripts/webkitpy/tool/steps/abstractstep.py:
2492         * Scripts/webkitpy/tool/steps/applypatch.py:
2493         * Scripts/webkitpy/tool/steps/build.py:
2494         * Scripts/webkitpy/tool/steps/checkstyle.py:
2495         * Scripts/webkitpy/tool/steps/closebug.py:
2496         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2497         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2498         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2499         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
2500         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2501         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2502         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2503         * Scripts/webkitpy/tool/steps/runtests.py:
2504         * Scripts/webkitpy/tool/steps/update.py:
2505         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2506         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2507         * Scripts/webkitpy/unittests.py:
2508         * Scripts/webkitpy/webkit_logging.py: Removed.
2509         * Scripts/webkitpy/webkit_logging_unittest.py: Removed.
2510
2511 2010-03-25  Julien Chaffraix  <jchaffraix@webkit.org>
2512
2513         Reviewed by Kenneth Rohde Christiansen.
2514
2515         commit-log-editor can call itself in an infinite loop
2516         https://bugs.webkit.org/show_bug.cgi?id=35291
2517
2518         if $editor ends up being commit-log-editor, the script will exec itself
2519         in an infinite loop.
2520
2521         To avoid this, we now check that the $editor variable is not
2522         commit-log-editor to avoid this case.
2523
2524         * Scripts/commit-log-editor: Added an isCommitLogEditor method and
2525         reworked the $editor setting to add this check.
2526
2527 2010-03-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2528
2529         Reviewed by Kenneth Rohde Christiansen.
2530
2531         Add a Toggle Frame Flattening option to QtLauncher.
2532         It will be enabled by default on Maemo5 and S60 platforms.
2533
2534         [Qt] Add enable/disable Frame Flattening option to QtLauncher
2535         https://bugs.webkit.org/show_bug.cgi?id=36558
2536
2537         * QtLauncher/main.cpp:
2538         (LauncherWindow::applyPrefs):
2539         (LauncherWindow::toggleFrameFlattening):
2540         (LauncherWindow::createChrome):
2541
2542 2010-03-25  Zoltan Horvath  <zoltan@webkit.org>
2543
2544         Reviewed by Eric Seidel.
2545
2546         svn-create-patch prints a warning for large patches
2547         https://bugs.webkit.org/show_bug.cgi?id=32582
2548
2549         svn-create-patch prints a warning message for larger patches than 20k.
2550
2551         * Scripts/svn-create-patch:
2552
2553 2010-03-25  Adam Barth  <abarth@webkit.org>
2554
2555         Unreviewed.  Renamed early_warning_system.py to earlywarningsystem.py.
2556         https://bugs.webkit.org/show_bug.cgi?id=36093
2557
2558         * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
2559         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
2560         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
2561         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
2562         * Scripts/webkitpy/tool/main.py:
2563         * Scripts/webkitpy/tool/unittests.py:
2564
2565 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2566
2567         Reviewed by Adam Barth.
2568
2569         In webkitpy, pushed the unit test import statements in
2570         webkitpy/unittests.py into appropriate unittests.py files in the
2571         new root-level packages beneath webkitpy.
2572
2573         https://bugs.webkit.org/show_bug.cgi?id=36093
2574
2575         This is part of the master bug to reorganize webkitpy.
2576
2577         * Scripts/webkitpy/common/system/unittests.py:
2578         * Scripts/webkitpy/common/unittests.py: Added.
2579         * Scripts/webkitpy/python24/unittests.py: Added.
2580         * Scripts/webkitpy/tool/unittests.py: Added.
2581         * Scripts/webkitpy/unittests.py:
2582
2583 2010-03-25  Adam Barth  <abarth@webkit.org>
2584
2585         Unreviewed.  Move WebKitCheckout into the webkitpy.common.checkout
2586         package.
2587         https://bugs.webkit.org/show_bug.cgi?id=36093
2588
2589         * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
2590         * Scripts/webkitpy/tool/main.py:
2591         * Scripts/webkitpy/tool/mocktool.py:
2592         * Scripts/webkitpy/webkitcheckout.py: Removed.
2593
2594 2010-03-25  Adam Barth  <abarth@webkit.org>
2595
2596         Unreviewed.  Move OutputCapture to webkitpy.common.system.
2597         https://bugs.webkit.org/show_bug.cgi?id=36093
2598
2599         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2600         * Scripts/webkitpy/common/net/credentials_unittest.py:
2601         * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
2602         * Scripts/webkitpy/outputcapture.py: Removed.
2603         * Scripts/webkitpy/tool/commands/commandtest.py:
2604         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2605         * Scripts/webkitpy/tool/commands/queuestest.py:
2606         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2607         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2608         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2609         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2610
2611 2010-03-25  Adam Barth  <abarth@webkit.org>
2612
2613         Unreviewed.  Move user.py to webkitpy.common.system.
2614
2615         * Scripts/webkitpy/common/checkout/scm.py:
2616         * Scripts/webkitpy/common/net/bugzilla.py:
2617         * Scripts/webkitpy/common/net/credentials.py:
2618         * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
2619         * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
2620         * Scripts/webkitpy/tool/commands/upload.py:
2621         * Scripts/webkitpy/tool/main.py:
2622         * Scripts/webkitpy/unittests.py:
2623         * Scripts/webkitpy/user.py: Removed.
2624         * Scripts/webkitpy/user_unittest.py: Removed.
2625
2626 2010-03-25  Adam Barth  <abarth@webkit.org>
2627
2628         Unreviewed.  Move executive.py to webkitpy.common.system.
2629         https://bugs.webkit.org/show_bug.cgi?id=36093
2630
2631         * Scripts/webkitpy/common/checkout/scm.py:
2632         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2633         * Scripts/webkitpy/common/config/ports.py:
2634         * Scripts/webkitpy/common/config/ports_unittest.py:
2635         * Scripts/webkitpy/common/net/credentials.py:
2636         * Scripts/webkitpy/common/net/credentials_unittest.py:
2637         * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
2638         * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
2639         * Scripts/webkitpy/executive.py: Removed.
2640         * Scripts/webkitpy/executive_unittest.py: Removed.
2641         * Scripts/webkitpy/layout_tests/port/mac.py:
2642         * Scripts/webkitpy/tool/bot/queueengine.py:
2643         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2644         * Scripts/webkitpy/tool/commands/download.py:
2645         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2646         * Scripts/webkitpy/tool/commands/queues.py:
2647         * Scripts/webkitpy/tool/commands/stepsequence.py:
2648         * Scripts/webkitpy/tool/main.py:
2649         * Scripts/webkitpy/tool/steps/checkstyle.py:
2650         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2651         * Scripts/webkitpy/unittests.py:
2652         * Scripts/webkitpy/webkit_logging_unittest.py:
2653
2654 2010-03-25  Adam Barth  <abarth@webkit.org>
2655
2656         Unreviewed.  Move grammary.py into webkitpy.tool.
2657         https://bugs.webkit.org/show_bug.cgi?id=36093
2658
2659         * Scripts/webkitpy/grammar.py: Removed.
2660         * Scripts/webkitpy/grammar_unittest.py: Removed.
2661         * Scripts/webkitpy/tool/commands/download.py:
2662         * Scripts/webkitpy/tool/commands/queries.py:
2663         * Scripts/webkitpy/tool/commands/queues.py:
2664         * Scripts/webkitpy/tool/commands/upload.py:
2665         * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
2666         * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
2667         * Scripts/webkitpy/tool/multicommandtool.py:
2668         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2669         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2670         * Scripts/webkitpy/unittests.py:
2671
2672 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2673
2674         Reviewed by Adam Barth.
2675
2676         In webkitpy, moved init/ to common/system/.
2677
2678         https://bugs.webkit.org/show_bug.cgi?id=36093
2679
2680         This is part of the master bug to reorganize webkitpy.
2681
2682         * Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
2683         * Scripts/webkitpy/common/system/logutils.py:
2684         * Scripts/webkitpy/common/system/logutils_unittest.py:
2685         * Scripts/webkitpy/init: Removed.
2686         * Scripts/webkitpy/init/__init__.py: Removed.
2687         * Scripts/webkitpy/init/logtesting.py: Removed.
2688         * Scripts/webkitpy/init/logutils.py: Removed.
2689         * Scripts/webkitpy/init/logutils_unittest.py: Removed.
2690         * Scripts/webkitpy/init/unittests.py: Removed.
2691         * Scripts/webkitpy/python24/versioning_unittest.py:
2692         * Scripts/webkitpy/style_references.py:
2693         * Scripts/webkitpy/unittests.py:
2694
2695 2010-03-25  Adam Barth  <abarth@webkit.org>
2696
2697         Unreviewed.  Move stepsequence to webkitpy.tool.commands.
2698         https://bugs.webkit.org/show_bug.cgi?id=36093
2699
2700         * Scripts/webkitpy/stepsequence.py: Removed.
2701         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2702         * Scripts/webkitpy/tool/commands/download.py:
2703         * Scripts/webkitpy/tool/commands/queues.py:
2704         * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
2705
2706 2010-03-25  Adam Barth  <abarth@webkit.org>
2707
2708         Unreviewed.  Create webkitpy.common.checkout as described in
2709         https://bugs.webkit.org/show_bug.cgi?id=36093
2710
2711         * Scripts/webkitpy/changelogs.py: Removed.
2712         * Scripts/webkitpy/changelogs_unittest.py: Removed.
2713         * Scripts/webkitpy/commitinfo.py: Removed.
2714         * Scripts/webkitpy/commitinfo_unittest.py: Removed.
2715         * Scripts/webkitpy/common/checkout: Added.
2716         * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py.
2717         * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
2718         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
2719         * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
2720         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
2721         * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
2722         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
2723         * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
2724         * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
2725         * Scripts/webkitpy/common/net/credentials.py:
2726         * Scripts/webkitpy/diff_parser.py: Removed.
2727         * Scripts/webkitpy/diff_parser_unittest.py: Removed.
2728         * Scripts/webkitpy/layout_tests/port/base.py:
2729         * Scripts/webkitpy/scm.py: Removed.
2730         * Scripts/webkitpy/scm_unittest.py: Removed.
2731         * Scripts/webkitpy/stepsequence.py:
2732         * Scripts/webkitpy/style_references.py:
2733         * Scripts/webkitpy/tool/commands/download.py:
2734         * Scripts/webkitpy/tool/commands/queries.py:
2735         * Scripts/webkitpy/tool/comments.py:
2736         * Scripts/webkitpy/tool/main.py:
2737         * Scripts/webkitpy/tool/mocktool.py:
2738         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2739         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2740         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2741         * Scripts/webkitpy/unittests.py:
2742         * Scripts/webkitpy/webkitcheckout.py:
2743
2744 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2745
2746         Reviewed by Adam Barth.
2747
2748         In webkitpy, moved init/versioning.py to python24/.
2749
2750         https://bugs.webkit.org/show_bug.cgi?id=36093
2751
2752         This is part of the master bug to reorganize webkitpy.
2753
2754         * Scripts/test-webkitpy:
2755         * Scripts/webkit-patch:
2756         * Scripts/webkitpy/init/unittests.py:
2757         * Scripts/webkitpy/init/versioning.py: Removed.
2758         * Scripts/webkitpy/init/versioning_unittest.py: Removed.
2759         * Scripts/webkitpy/python24: Added.
2760         * Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py.
2761         * Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
2762         * Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
2763         * Scripts/webkitpy/unittests.py:
2764
2765 2010-03-25  Adam Barth  <abarth@webkit.org>
2766
2767         Unreviewed.
2768
2769         Create webkitpy.common.net as described in
2770         https://bugs.webkit.org/show_bug.cgi?id=36093
2771
2772         * Scripts/webkitpy/bugzilla.py: Removed.
2773         * Scripts/webkitpy/bugzilla_unittest.py: Removed.
2774         * Scripts/webkitpy/buildbot.py: Removed.
2775         * Scripts/webkitpy/buildbot_unittest.py: Removed.
2776         * Scripts/webkitpy/commitinfo.py:
2777         * Scripts/webkitpy/common/net: Added.
2778         * Scripts/webkitpy/common/net/__init__.py: Added.
2779         * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
2780         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
2781         * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
2782         * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
2783         * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
2784         * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
2785         * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
2786         * Scripts/webkitpy/common/net/irc/ircbot.py:
2787         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2788         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
2789         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
2790         * Scripts/webkitpy/common/net/irc/unittests.py:
2791         * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
2792         * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
2793         * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
2794         * Scripts/webkitpy/credentials.py: Removed.
2795         * Scripts/webkitpy/credentials_unittest.py: Removed.
2796         * Scripts/webkitpy/irc: Removed.
2797         * Scripts/webkitpy/irc/__init__.py: Removed.
2798         * Scripts/webkitpy/irc/ircbot.py: Removed.
2799         * Scripts/webkitpy/irc/ircproxy.py: Removed.
2800         * Scripts/webkitpy/irc/messagepump.py: Removed.
2801         * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
2802         * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
2803         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
2804         * Scripts/webkitpy/irc/unittests.py: Removed.
2805         * Scripts/webkitpy/networktransaction.py: Removed.
2806         * Scripts/webkitpy/networktransaction_unittest.py: Removed.
2807         * Scripts/webkitpy/scm_unittest.py:
2808         * Scripts/webkitpy/statusserver.py: Removed.
2809         * Scripts/webkitpy/tool/bot/queueengine.py:
2810         * Scripts/webkitpy/tool/commands/download.py:
2811         * Scripts/webkitpy/tool/commands/queries.py:
2812         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2813         * Scripts/webkitpy/tool/commands/queues.py:
2814         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2815         * Scripts/webkitpy/tool/commands/queuestest.py:
2816         * Scripts/webkitpy/tool/commands/upload.py:
2817         * Scripts/webkitpy/tool/main.py:
2818         * Scripts/webkitpy/tool/mocktool.py:
2819         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2820         * Scripts/webkitpy/unittests.py:
2821
2822 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2823
2824         Reviewed by Adam Barth.
2825
2826         In webkitpy, renamed MockBugzillaTool to MockTool.
2827
2828         * Scripts/webkitpy/tool/commands/commandtest.py:
2829         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2830         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2831         * Scripts/webkitpy/tool/commands/queuestest.py:
2832         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2833         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2834         * Scripts/webkitpy/tool/mocktool.py:
2835         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2836         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2837         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2838
2839 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2840
2841         Reviewed by Adam Barth.
2842
2843         In Scripts/webkitpy, moved webkitport.py and committers.py into
2844         common/config/ (also creating common/config/).
2845
2846         https://bugs.webkit.org/show_bug.cgi?id=36093
2847
2848         This is part of the master bug to reorganize webkitpy.
2849
2850         * Scripts/validate-committer-lists:
2851         * Scripts/webkitpy/bugzilla.py:
2852         * Scripts/webkitpy/bugzilla_unittest.py:
2853         * Scripts/webkitpy/changelogs.py:
2854         * Scripts/webkitpy/commitinfo.py:
2855         * Scripts/webkitpy/commitinfo_unittest.py:
2856         * Scripts/webkitpy/committers.py: Removed.
2857         * Scripts/webkitpy/committers_unittest.py: Removed.
2858         * Scripts/webkitpy/common: Added.
2859         * Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
2860         * Scripts/webkitpy/common/config: Added.
2861         * Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
2862         * Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
2863         * Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
2864         * Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
2865         * Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
2866         * Scripts/webkitpy/mock_bugzillatool.py:
2867         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2868         * Scripts/webkitpy/tool/commands/queries.py:
2869         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2870         * Scripts/webkitpy/tool/commands/upload.py:
2871         * Scripts/webkitpy/tool/steps/abstractstep.py:
2872         * Scripts/webkitpy/unittests.py:
2873         * Scripts/webkitpy/webkitport.py: Removed.
2874         * Scripts/webkitpy/webkitport_unittest.py: Removed.
2875
2876 2010-03-25  Adam Barth  <abarth@webkit.org>
2877
2878         Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.
2879
2880         * Scripts/webkitpy/mock_bugzillatool.py: Removed.
2881         * Scripts/webkitpy/tool/commands/commandtest.py:
2882         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2883         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2884         * Scripts/webkitpy/tool/commands/queuestest.py:
2885         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2886         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2887         * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
2888         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2889         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2890         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2891
2892 2010-03-24  Adam Barth  <abarth@webkit.org>
2893
2894         Unreviewed.  Move comments.py and multicommandtool.py to their new
2895         home.
2896
2897         * Scripts/webkitpy/comments.py: Removed.
2898         * Scripts/webkitpy/multicommandtool.py: Removed.
2899         * Scripts/webkitpy/multicommandtool_unittest.py: Removed.
2900         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2901         * Scripts/webkitpy/tool/commands/download.py:
2902         * Scripts/webkitpy/tool/commands/openbugs.py:
2903         * Scripts/webkitpy/tool/commands/queries.py:
2904         * Scripts/webkitpy/tool/commands/queues.py:
2905         * Scripts/webkitpy/tool/commands/upload.py:
2906         * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
2907         * Scripts/webkitpy/tool/main.py:
2908         * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
2909         * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
2910         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2911         * Scripts/webkitpy/tool/steps/closepatch.py:
2912         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2913         * Scripts/webkitpy/unittests.py:
2914
2915 2010-03-24  Adam Barth  <abarth@webkit.org>
2916
2917         Unreviewed.  Fixup one import statement I didn't find because the .pyc
2918         masked the error.
2919
2920         * Scripts/webkitpy/stepsequence.py:
2921
2922 2010-03-24  Adam Barth  <abarth@webkit.org>
2923
2924         Unreviewed.  Move queueengine.py to its new home.
2925
2926         * Scripts/webkitpy/queueengine.py: Removed.
2927         * Scripts/webkitpy/queueengine_unittest.py: Removed.
2928         * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
2929         * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
2930         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2931         * Scripts/webkitpy/tool/commands/queues.py:
2932         * Scripts/webkitpy/unittests.py:
2933
2934 2010-03-24  Adam Barth  <abarth@webkit.org>
2935
2936         Unreviewed.  Move patchcollection.py to its new home.
2937
2938         * Scripts/webkitpy/patchcollection.py: Removed.
2939         * Scripts/webkitpy/patchcollection_unittest.py: Removed.
2940         * Scripts/webkitpy/tool/bot: Added.
2941         * Scripts/webkitpy/tool/bot/__init__.py: Added.
2942         * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
2943         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
2944         * Scripts/webkitpy/tool/commands/queues.py:
2945         * Scripts/webkitpy/unittests.py:
2946
2947 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
2948
2949         Reviewed by Adam Barth.
2950
2951         In Scripts/webkitpy, moved steps_references.py and the steps
2952         folder into webkitpy/patch.
2953
2954         https://bugs.webkit.org/show_bug.cgi?id=36093
2955
2956         * Scripts/webkitpy/steps: Removed.
2957         * Scripts/webkitpy/steps/__init__.py: Removed.
2958         * Scripts/webkitpy/steps/abstractstep.py: Removed.
2959         * Scripts/webkitpy/steps/applypatch.py: Removed.
2960         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
2961         * Scripts/webkitpy/steps/build.py: Removed.
2962         * Scripts/webkitpy/steps/checkstyle.py: Removed.
2963         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
2964         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
2965         * Scripts/webkitpy/steps/closebug.py: Removed.
2966         * Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
2967         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
2968         * Scripts/webkitpy/steps/closepatch.py: Removed.
2969         * Scripts/webkitpy/steps/commit.py: Removed.
2970         * Scripts/webkitpy/steps/confirmdiff.py: Removed.
2971         * Scripts/webkitpy/steps/createbug.py: Removed.
2972         * Scripts/webkitpy/steps/editchangelog.py: Removed.
2973         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
2974         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
2975         * Scripts/webkitpy/steps/metastep.py: Removed.
2976         * Scripts/webkitpy/steps/obsoletepatches.py: Removed.
2977         * Scripts/webkitpy/steps/options.py: Removed.
2978         * Scripts/webkitpy/steps/postdiff.py: Removed.
2979         * Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
2980         * Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
2981         * Scripts/webkitpy/steps/preparechangelog.py: Removed.
2982         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
2983         * Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
2984         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
2985         * Scripts/webkitpy/steps/revertrevision.py: Removed.
2986         * Scripts/webkitpy/steps/runtests.py: Removed.
2987         * Scripts/webkitpy/steps/steps_unittest.py: Removed.
2988         * Scripts/webkitpy/steps/update.py: Removed.
2989         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
2990         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
2991         * Scripts/webkitpy/steps/validatereviewer.py: Removed.
2992         * Scripts/webkitpy/steps_references.py: Removed.
2993         * Scripts/webkitpy/stepsequence.py:
2994         * Scripts/webkitpy/tool/commands/download.py:
2995         * Scripts/webkitpy/tool/commands/upload.py:
2996         * Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
2997         * Scripts/webkitpy/tool/steps/__init__.py:
2998         * Scripts/webkitpy/tool/steps/applypatch.py:
2999         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
3000         * Scripts/webkitpy/tool/steps/build.py:
3001         * Scripts/webkitpy/tool/steps/checkstyle.py:
3002         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3003         * Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
3004         * Scripts/webkitpy/tool/steps/closebug.py:
3005         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3006         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3007         * Scripts/webkitpy/tool/steps/closepatch.py:
3008         * Scripts/webkitpy/tool/steps/commit.py:
3009         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3010         * Scripts/webkitpy/tool/steps/createbug.py:
3011         * Scripts/webkitpy/tool/steps/editchangelog.py:
3012         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
3013         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3014         * Scripts/webkitpy/tool/steps/metastep.py:
3015         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3016         * Scripts/webkitpy/tool/steps/postdiff.py:
3017         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3018         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3019         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3020         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3021         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
3022         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3023         * Scripts/webkitpy/tool/steps/revertrevision.py:
3024         * Scripts/webkitpy/tool/steps/runtests.py:
3025         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3026         * Scripts/webkitpy/tool/steps/update.py:
3027         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
3028         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3029         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3030         * Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
3031         * Scripts/webkitpy/unittests.py:
3032
3033 2010-03-24  Eric Seidel  <eric@webkit.org>
3034
3035         Unreviewed, build fix only.
3036
3037         Abstract LayoutTestResults logic for easier reuse
3038         https://bugs.webkit.org/show_bug.cgi?id=36579
3039
3040         * Scripts/webkitpy/buildbot_unittest.py: Add a missing import.
3041
3042 2010-03-24  Adam Barth  <abarth@webkit.org>
3043
3044         Unreviewed.  Fix a stray comma to test landing an patch without review.
3045
3046         * Scripts/webkitpy/commitinfo.py:
3047
3048 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
3049
3050         Reviewed by Adam Barth.
3051
3052         In Scripts/webkitpy, moved commands_references.py and the commands
3053         folder into webkitpy/patch.
3054
3055         https://bugs.webkit.org/show_bug.cgi?id=36483
3056
3057         This is part of master bug 36093 to organize webkitpy.
3058
3059         * Scripts/webkitpy/commands: Removed.
3060         * Scripts/webkitpy/commands/__init__.py: Removed.
3061         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
3062         * Scripts/webkitpy/commands/commandtest.py: Removed.
3063         * Scripts/webkitpy/commands/download.py: Removed.
3064         * Scripts/webkitpy/commands/download_unittest.py: Removed.
3065         * Scripts/webkitpy/commands/early_warning_system.py: Removed.
3066         * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
3067         * Scripts/webkitpy/commands/openbugs.py: Removed.
3068         * Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
3069         * Scripts/webkitpy/commands/queries.py: Removed.
3070         * Scripts/webkitpy/commands/queries_unittest.py: Removed.
3071         * Scripts/webkitpy/commands/queues.py: Removed.
3072         * Scripts/webkitpy/commands/queues_unittest.py: Removed.
3073         * Scripts/webkitpy/commands/queuestest.py: Removed.
3074         * Scripts/webkitpy/commands/sheriffbot.py: Removed.
3075         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
3076         * Scripts/webkitpy/commands/upload.py: Removed.
3077         * Scripts/webkitpy/commands/upload_unittest.py: Removed.
3078         * Scripts/webkitpy/commands_references.py: Removed.
3079         * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
3080         * Scripts/webkitpy/tool/commands/commandtest.py:
3081         * Scripts/webkitpy/tool/commands/download.py:
3082         * Scripts/webkitpy/tool/commands/download_unittest.py:
3083         * Scripts/webkitpy/tool/commands/early_warning_system.py:
3084         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
3085         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3086         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3087         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3088         * Scripts/webkitpy/tool/commands/queuestest.py:
3089         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3090         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3091         * Scripts/webkitpy/tool/commands/upload.py:
3092         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3093         * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
3094         * Scripts/webkitpy/tool/main.py:
3095         * Scripts/webkitpy/unittests.py:
3096
3097 2010-03-24  Adam Barth  <abarth@webkit.org>
3098
3099         Reviewed by Eric Seidel.
3100
3101         Rename webkitpy.patch to webkitpy.tool
3102         https://bugs.webkit.org/show_bug.cgi?id=36580
3103
3104         This is in preparation for the great webkitpy naming cleanup.
3105
3106         * Scripts/webkit-patch:
3107         * Scripts/webkitpy/patch: Removed.
3108         * Scripts/webkitpy/patch/__init__.py: Removed.
3109         * Scripts/webkitpy/patch/patcher.py: Removed.
3110         * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
3111         * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
3112         * Scripts/webkitpy/tool/patcher.py: Removed.
3113
3114 2010-03-24  Eric Seidel  <eric@webkit.org>
3115
3116         Reviewed by Adam Barth.
3117
3118         Abstract LayoutTestResults logic for easier reuse
3119         https://bugs.webkit.org/show_bug.cgi?id=36579
3120
3121         * Scripts/webkitpy/buildbot.py:
3122          - Split out logic into new LayoutTestResults class.
3123         * Scripts/webkitpy/buildbot_unittest.py:
3124          - Rename the testing class to match.
3125         * Scripts/webkitpy/commands/queries.py:
3126          - Use the new LayoutTestResults class.
3127
3128 2010-03-24  Eric Seidel  <eric@webkit.org>
3129
3130         Reviewed by Eric Seidel.
3131
3132         Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
3133         https://bugs.webkit.org/show_bug.cgi?id=36577
3134
3135         * Scripts/webkitpy/bugzilla.py:
3136          - Move prompt_for_component to User
3137         * Scripts/webkitpy/commands/queries.py:
3138          - Add a missing argument_names declaration.
3139         * Scripts/webkitpy/user.py:
3140          - Add prompt_with_list
3141          - Make staticmethods classmethods for easier mocking
3142
3143 2010-03-24  David Kilzer  <ddkilzer@apple.com>
3144
3145         <http://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file
3146
3147         Reviewed by Eric Seidel.
3148
3149         Fixes the following error when committing a file with
3150         "ChangeLog" in the name that isn't a ChangeLog (like
3151         mergeChangeLogs.pl from r56471 and r56472):
3152
3153             $ git commit .
3154             Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
3155             error: There was a problem with the editor 'commit-log-editor'.
3156             Please supply the message using either -m or -F option.
3157
3158         * Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
3159         the end of the file name when searching for ChangeLog files in a
3160         commit.
3161
3162 2010-03-24  David Kilzer  <ddkilzer@apple.com>
3163
3164         <http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged
3165
3166         Reviewed by Eric Seidel.
3167
3168         * Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
3169         the merge attempt fails.
3170
3171 2010-03-24  Adam Barth  <abarth@webkit.org>
3172
3173         Reviewed by Eric Seidel.
3174
3175         webkit-patch or pre-commit hook should validate reviewer lines before committing
3176         https://bugs.webkit.org/show_bug.cgi?id=26927
3177
3178         Validate that patches have valid reivewers listed in their ChangeLogs
3179         before landing.  For patches without reviewers can be landed if their
3180         ChangeLogs state that they are unreviewed.
3181
3182         * Scripts/webkitpy/changelogs.py:
3183         * Scripts/webkitpy/commands/download.py:
3184         * Scripts/webkitpy/commitinfo.py:
3185         * Scripts/webkitpy/commitinfo_unittest.py:
3186         * Scripts/webkitpy/mock_bugzillatool.py:
3187         * Scripts/webkitpy/steps/__init__.py:
3188         * Scripts/webkitpy/steps/validatereviewer.py: Added.
3189
3190 2010-03-19  Holger Hans Peter Freyther  <zecke@selfish.org>
3191
3192         Reviewed by David Levin.
3193
3194         Undefined names reported by pyflakes in python scripts
3195         https://bugs.webkit.org/show_bug.cgi?id=36403
3196
3197         Attempt to use names that exist or can exist in the lexical
3198         scope instead of not being available at all.
3199
3200         * Scripts/webkitpy/changelogs.py: Use self._content.
3201         * Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
3202         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
3203         * Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re
3204
3205 2010-03-24  David Kilzer  <ddkilzer@apple.com>
3206
3207         <http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge
3208
3209         Reviewed by Eric Seidel.
3210
3211         When resolve-ChangeLogs fails to merge a patch while running as
3212         a git merge driver, it deletes the original file, which causes
3213         an internal failure and stops git mid-merge:
3214
3215             fatal: Failed to execute internal merge
3216
3217         The fix is to use the --force switch with patch so that it will
3218         always attempt to apply the patch.  (The change in
3219         mergeChangeLogs() for the previous commit also fixed this, but
3220         adding --force also prevents any potential user interaction that
3221         patch may want to display.)
3222
3223         * Scripts/VCSUtils.pm:
3224         (mergeChangeLogs): Added --force switch to patch command.  Also
3225         changed to use the exit status from the patch command to
3226         determine the return value for this method.
3227         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
3228         test to cover this bug.
3229
3230 2010-03-24  David Kilzer  <ddkilzer@apple.com>
3231
3232         <http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package
3233
3234         Reviewed by Eric Seidel.
3235
3236         * Scripts/VCSUtils.pm:
3237         (mergeChangeLogs): Copied from mergeChanges() in
3238         resolve-ChangeLogs and renamed.  Added method documentation.
3239         Fixed bug found by new tests where the original file to be
3240         patched was deleted when cleaning up after a traditinal rejected
3241         patch failed to apply.
3242         * Scripts/resolve-ChangeLogs: Switched to using
3243         mergeChangeLogs().
3244         (mergeChanges): Moved to VCSUtils.pm and renamed to
3245         mergeChangeLogs().
3246         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.
3247
3248 2010-03-24  Eric Seidel  <eric@webkit.org>
3249
3250         Reviewed by Adam Barth.
3251
3252         Add support for qt's unassigned list to webkit-patch assign-to-committer
3253         https://bugs.webkit.org/show_bug.cgi?id=36559
3254
3255         * Scripts/webkitpy/bugzilla.py:
3256          - Move Bugzilla.unassigned_email into Bug and make it a set.
3257         * Scripts/webkitpy/bugzilla_unittest.py:
3258          - Test the new Bug.is_unassigned method
3259         * Scripts/webkitpy/commands/upload.py:
3260          - Use the new Bug.is_unassigned method instead of an explicit ==
3261         * Scripts/webkitpy/mock_bugzillatool.py:
3262          - Bugzilla.unassigned_email no longer needs mocking
3263
3264 2010-03-24  Kent Hansen  <kent.hansen@nokia.com>
3265
3266         Reviewed by Simon Hausmann.
3267
3268         [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
3269         https://bugs.webkit.org/show_bug.cgi?id=36522
3270
3271         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3272         (LayoutTestController::setXSSAuditorEnabled): Use the new name.
3273
3274 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
3275
3276         Reviewed by Shinichiro Hamaji.
3277
3278         Added to check-webkit-style support for a --debug flag.
3279
3280         https://bugs.webkit.org/show_bug.cgi?id=36100
3281
3282         The --debug flag adjusts the logging level to DEBUG and
3283         includes the logger name and level in each log message.
3284
3285         * Scripts/check-webkit-style:
3286           - Changed the code to check for the --debug flag and pass
3287             the result to the configure_logging() method.
3288         * Scripts/webkitpy/style/checker.py:
3289           - Added an is_debug parameter to configure_logging().
3290           - Refactored configure_logging() by adding calls to
3291             the following two methods: _create_log_handlers() and
3292             _create_debug_log_handlers().
3293         * Scripts/webkitpy/style/checker_unittest.py:
3294           - Added unit tests for configure_logging() with is_debug True
3295             by splitting the ConfigureLoggingTest class into
3296             ConfigureLoggingTest and ConfigureLoggingTestBase, and
3297             adding ConfigureLoggingDebugTest.
3298         * Scripts/webkitpy/style/optparser.py:
3299           - Updated the usage string.
3300           - Added an is_debug data attribute to the CommandOptionValues
3301             class.
3302           - Added support for the --debug flag to the ArgumentParser.parse()
3303             method.
3304           - Also added extra error information to the parse() method in
3305             the case of an invalid flag.
3306         * Scripts/webkitpy/style/optparser_unittest.py:
3307           - Updated the unit tests as necessary.
3308           - Also fixed an issue with the CommandOptionValuesTest.test_eq()
3309             unit test.
3310
3311 2010-03-23  Kent Tamura  <tkent@chromium.org>
3312
3313         Reviewed by Dimitri Glazkov.
3314
3315         [DRT/Chromium] Add TestNavigationController and TestWebWorker
3316         https://bugs.webkit.org/show_bug.cgi?id=36489
3317
3318         Add TestNavigationController and TestWebWorker classes, which are
3319         going to be used by DumpRenderTree Chromium port. These files are
3320         based on:
3321         - src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
3322         - src/webkit/tools/test_shell/test_web_worker.h
3323         of Chromium rev.40492.
3324
3325         TestNavigationController has non-style changes.
3326         - Change ContentState type: binary string -> WebHistoryItem
3327         - Remove TestShell dependency by introducing NavigationHost interface.
3328
3329         * DumpRenderTree/chromium/TestNavigationController.cpp: Added.
3330         * DumpRenderTree/chromium/TestNavigationController.h: Added.
3331         * DumpRenderTree/chromium/TestWebWorker.h: Added.
3332
3333 2010-03-23  Eric Seidel  <eric@webkit.org>
3334
3335         Reviewed by Adam Barth.
3336
3337         Add support for revision -> build lookup in buildbot.py and layout test result parsing
3338         https://bugs.webkit.org/show_bug.cgi?id=36474
3339
3340         * Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
3341         * Scripts/webkitpy/buildbot.py: 
3342          - Add support for looking up builds by revision number.
3343          - Add support for fetching and parsing results.html files from buildbot.
3344          - build_for_revision has an allow_failed_lookups option to work around the fact that
3345            our buildbot's xmlrpc calls return failure on old revision numbers.
3346          - Add parsing support for twisted directory listings.
3347         * Scripts/webkitpy/buildbot_unittest.py:
3348          - Unit test all the new code.
3349         * Scripts/webkitpy/commands/queries.py:
3350          - Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
3351
3352 2010-03-23  Daniel Bates  <dbates@rim.com>
3353
3354         Reviewed by Adam Roben.
3355
3356         https://bugs.webkit.org/show_bug.cgi?id=36048
3357
3358         Detect if the Windows Platform SDK is missing when building with
3359         Visual C++ Express Edition and inform the user to download it.
3360
3361         * Scripts/webkitdirs.pm:
3362
3363 2010-03-23  Darin Adler  <darin@apple.com>
3364
3365         Tell Subversion about more directories that expect to have .pyc files.
3366
3367         * Scripts/webkitpy: Modified property svn:ignore.
3368         * Scripts/webkitpy/irc: Added property svn:ignore.
3369
3370 2010-03-23  Daniel Bates  <dbates@rim.com>
3371
3372         Reviewed by Adam Barth.
3373
3374         https://bugs.webkit.org/show_bug.cgi?id=36149
3375
3376         Import the GNU readline interface to modify the behavior
3377         of raw_input so as to provide line editing support. In
3378         particular this will prevent "delete" characters from
3379         appearing in the returned value for function raw_input.
3380
3381         * Scripts/webkitpy/user.py:
3382
3383 2010-03-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3384
3385         Reviewed by Kenneth Rohde Christiansen.
3386
3387         [Qt] Remove support for Qt v4.4
3388         https://bugs.webkit.org/show_bug.cgi?id=36389
3389
3390         * DumpRenderTree/qt/main.cpp:
3391         (main):
3392         * QtLauncher/mainwindow.cpp:
3393         (MainWindow::MainWindow):
3394
3395 2010-03-22  Csaba Osztrogon√°c  <ossy@webkit.org>
3396
3397         Reviewed by Adam Barth.
3398
3399         Make build_webkit_command() pass MAKEFLAGS environment variable to make.
3400         https://bugs.webkit.org/show_bug.cgi?id=36440
3401
3402         * Scripts/webkitpy/webkitport.py:
3403         * Scripts/webkitpy/webkitport_unittest.py:
3404
3405 2010-03-22  Dirk Pranke  <dpranke@chromium.org>
3406
3407         Reviewed by Dimitri Glazkov.
3408
3409         Change baseline_path() to point to the upstream locations for the
3410         Chromium ports. Also change the reabselining scripts to use the
3411         correct functions to get the baseline directories, and fix the
3412         script's sys.path to pull in simplejson correctly.
3413
3414         https://bugs.webkit.org/show_bug.cgi?id=36417
3415
3416         * Scripts/rebaseline-chromium-webkit-tests:
3417           - fix sys.path to pick up simplejson properly
3418         * Scripts/webkitpy/layout_tests/port/chromium.py:
3419           - change baseline_path() to use webkit_baseline_path()
3420           - error out correctly if we can't find the chromium base dir
3421         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3422           - call baseline_path(), not chromium_baseline_path()
3423
3424 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
3425
3426         Reviewed by Adam Barth.
3427
3428         Refactored the cpu_count() code in executive.py.
3429
3430         https://bugs.webkit.org/show_bug.cgi?id=36437
3431
3432         * Scripts/webkitpy/executive.py:
3433           - Moved the import of the multiprocessing module to the top
3434             of the file rather than importing from within a function.
3435
3436 2010-03-22 Antonio Gomes <tonikitoo@webkit.org>
3437
3438         Unreviewed.
3439
3440         Rolling out r56183: http://trac.webkit.org/changeset/56183
3441
3442         https://bugs.webkit.org/show_bug.cgi?id=36244
3443
3444         Need to roll out because this patch will be re-worked by the author
3445         and other reviewers agreed on it.
3446
3447 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
3448
3449         Reviewed by Adam Barth.
3450
3451         Created a function for getting a module-specific logging.logger
3452         based on the __file__ value of the module.
3453
3454         https://bugs.webkit.org/show_bug.cgi?id=35821
3455
3456         This function allows us to get the module-specific logger for
3457         a module without having to hard-code the fully-qualified name
3458         of the module in the module itself.  The code can be the same
3459         in every case: "_log = logutils.get_logger(__file__)".
3460
3461         * Scripts/webkitpy/init/logutils.py: Added.
3462           - Added a module with a get_logger() function to return
3463             a module-specific logger based on the module's __file__
3464             variable.
3465
3466         * Scripts/webkitpy/init/logutils_unittest.py: Added.
3467           - Added unit tests for logutils.py.
3468
3469         * Scripts/webkitpy/init/unittests.py:
3470           - Added logutils_unittest to the list of imports.
3471
3472 2010-03-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3473
3474         Reviewed by Simon Hausmann.
3475
3476         [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
3477         https://bugs.webkit.org/show_bug.cgi?id=36386
3478
3479         Fix the regression by implementing a null printer for Qt DRT.
3480
3481         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3482         (WebCore::NullPrinter::NullPaintEngine::begin):
3483         (WebCore::NullPrinter::NullPaintEngine::end):
3484         (WebCore::NullPrinter::NullPaintEngine::type):
3485         (WebCore::NullPrinter::NullPaintEngine::drawPixmap):
3486         (WebCore::NullPrinter::NullPaintEngine::updateState):
3487         (WebCore::NullPrinter::paintEngine):
3488         (WebCore::DumpRenderTree::dryRunPrint):
3489
3490 2010-03-20  Martin Robinson  <mrobinson@webkit.org>
3491
3492         Reviewed by Xan Lopez.
3493
3494         [GTK] eventSender.zoomPageOut() bug?
3495         https://bugs.webkit.org/show_bug.cgi?id=30575
3496
3497         Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.
3498
3499         * DumpRenderTree/gtk/EventSender.cpp:
3500         (zoomIn): Added.
3501         (zoomOut): Added.
3502         (textZoomInCallback): Use zoomIn helper function.
3503         (textZoomOutCallback): Use zoomOut helper function.
3504         (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor.
3505         (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
3506
3507 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
3508
3509         [wx] Build fix after recent database API change.
3510
3511         * wx/browser/browser.cpp:
3512         (MyApp::OnInit):
3513
3514 2010-03-20  Chris Jerdonek  <cjerdonek@webkit.org>
3515
3516         Reviewed by Adam Barth.
3517
3518         Renamed UnitTestLogStream to TestLogStream in webkitpy.
3519
3520         https://bugs.webkit.org/show_bug.cgi?id=36099
3521
3522         TestLogStream is more concise and more consistent with the name of
3523         the module (logtesting rather than logunittesting) and its main
3524         class (LogTesting rather than LogUnitTesting).
3525
3526         * Scripts/webkitpy/init/logtesting.py:
3527           - Renamings.
3528
3529         * Scripts/webkitpy/style/checker_unittest.py:
3530           - Renamings.
3531
3532         * Scripts/webkitpy/style_references.py:
3533           - Renamings.
3534
3535 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
3536
3537         [wx] Build fixes for new method in LayoutTestController.
3538
3539         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3540         (LayoutTestController::setSpatialNavigationEnabled):
3541         * wx/build/settings.py:
3542
3543 2010-03-20  Dimitri Glazkov  <dglazkov@chromium.org>
3544
3545         Unreviewed, tool fix.
3546
3547         Remove vestiges of downstream directory names to unbreak rebaselining tool.
3548
3549         * Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
3550
3551 2010-03-20  Dirk Pranke  <dpranke@chromium.org>
3552
3553         Reviewed by Dimitri Glazkov.
3554
3555         Re-enable the downstream test_expectations overrides file that was
3556         disabled in bug 36396 / r56287.
3557
3558         https://bugs.chromium.org/show_bug.cgi?id=36401
3559
3560         * Scripts/webkitpy/layout_tests/port/chromium.py:
3561
3562 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
3563
3564         Reviewed by Dimitri Glazkov.
3565
3566         Disable the downstream override expectations temporarily to allow
3567         us to test that we've upstreamed everything correctly. Also, stop
3568         looking at the downstream baselines at all (now you will only be
3569         able to update baselines upstream). In theory this should work, but
3570         if we need to we can always add the downstream dirs back in.
3571
3572         https://bugs.webkit.org/show_bug.cgi?id=36396
3573
3574         * Scripts/webkitpy/layout_tests/port/chromium.py:
3575         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3576         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3577         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3578
3579 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
3580
3581         Reviewed by Dimitri Glazkov.
3582
3583         fix typo in chromium test expectations overrides routine
3584         https://bugs.webkit.org/show_bug.cgi?id=36397
3585
3586         * Scripts/webkitpy/layout_tests/port/chromium.py:
3587
3588 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
3589
3590         Reviewed by Dimitri Glazkov.
3591
3592         Flip the Chromium ports to look first for the test expectations
3593         in LayoutTests/platform/chromium and only afterwards look in the
3594         Chromium repo downstream for overrides.
3595
3596         https://bugs.webkit.org/show_bug.cgi?id=36326
3597
3598         * Scripts/webkitpy/layout_tests/port/chromium.py:
3599
3600 2010-03-19  James Hawkins  <jhawkins@chromium.org>
3601
3602         Unreviewed.
3603
3604         Add myself to the committers list.
3605
3606         * Scripts/webkitpy/committers.py:
3607
3608 2010-03-19  Adam Barth  <abarth@webkit.org>
3609
3610         Unreviewed.
3611
3612         Fix SheriffBot exception lock when we can't retrieve the first build
3613         from buildbot.  (I'll ask Eric to review this change after the fact,
3614         but he's at lunch and I want to get the bot unlocked.)
3615
3616         * Scripts/webkitpy/buildbot.py:
3617         * Scripts/webkitpy/buildbot_unittest.py:
3618
3619 2010-03-19  Alexey Proskuryakov  <ap@apple.com>
3620
3621         Reviewed by Darin Adler.
3622
3623         https://bugs.webkit.org/show_bug.cgi?id=36380
3624         websocket/tests/frame-lengths.html times out on Tiger bot
3625
3626         https://bugs.webkit.org/show_bug.cgi?id=35041
3627</