2010-08-25 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Ojan Vafai.
4
5         new-run-webkit-tests: add more unit tests for layout_package/printing.py
6
7         This change adds more unit tests to get the test coverage to 100%
8         for the printing module. This code is actually pretty crufty and
9         has some layering violations that need to be cleaned up but I'll
10         save that for another CL after we get all the unit tests written and
11         we fix the multithreading issues. At least now we'll be able to tell
12         if we break things.
13
14         https://bugs.webkit.org/show_bug.cgi?id=44576
15
16         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
17         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
18
19 2010-08-25  Ojan Vafai  <ojan@chromium.org>
20
21         Reviewed by Adam Barth.
22
23         new-run-webkit-tests should respect set-webkit-configuration
24         https://bugs.webkit.org/show_bug.cgi?id=44633
25
26         Moves the getting of the configuration into the base Port so that
27         chromium ports use it as well. In the downstream chromium port,
28         this should still just return Release.
29
30         * Scripts/webkitpy/layout_tests/port/base.py:
31         * Scripts/webkitpy/layout_tests/port/webkit.py:
32
33 2010-08-25  Tony Chang  <tony@chromium.org>
34
35         Not reviewed, changing svn props for a script.
36
37         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
38
39 2010-08-25  Adam Barth  <abarth@webkit.org>
40
41         Reviewed by Eric Seidel.
42
43         Remove WebKit2 from core builders
44         https://bugs.webkit.org/show_bug.cgi?id=44625
45
46         This builder was added to the core builders by accident.  It doesn't
47         appear to be green enough to be a core builder yet.
48
49         * Scripts/webkitpy/common/net/buildbot.py:
50         * Scripts/webkitpy/common/net/buildbot_unittest.py:
51
52 2010-08-19  Adam Roben  <aroben@apple.com>
53
54         Test that NP_Initialize and NP_GetEntryPoints are called in the
55         correct order
56
57         The order differs between Mac and Windows (see r38858).
58
59         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
60         NP_Initialize when loading QuickTime when running
61         plugins/embed-attributes-setting.html in WebKit2 on Windows
62
63         Reviewed by John Sullivan.
64
65         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
66         a boolean to record whether NP_GetEntryPoints has been called.
67         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
68         called yet. This matches Flash and QuickTime's behavior.
69         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
70         yet. This matches Silverlight's behavior.
71
72 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
73
74         Reviewed by Gustavo Noronha Silva.
75
76         Cairo and EFL port shouldn't depend on glib.
77         https://bugs.webkit.org/show_bug.cgi?id=44354
78
79         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
80         adoptPlatformRef.
81
82         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
83         (AccessibilityUIElement::isSelected):
84
85 2010-08-25  Ojan Vafai  <ojan@chromium.org>
86
87         Fix order of Timothy's email address. The script, and
88         other tools all assume that the first email is the bugzilla address.
89
90         * Scripts/webkitpy/common/config/committers.py:
91
92 2010-08-24  Kent Tamura  <tkent@chromium.org>
93
94         Reviewed by Pavel Feldman.
95
96         [DRT/Chromium] Fix 26 inspector test crashes
97         https://bugs.webkit.org/show_bug.cgi?id=44580
98
99         - DRTDevToolsAgent has a reference to the main WebView. So we
100           should not clear it in closeDevTools() and should clear it in
101           ~TestShell().
102         - DRTDevToolsClient has a reference to a DevTools WebView and no
103           way to update it. So we should delete DRTDevToolsClient instances
104           in closeDevTools().
105
106         * DumpRenderTree/chromium/TestShell.cpp:
107         (TestShell::~TestShell):
108         (TestShell::closeDevTools):
109
110 2010-08-24  Eric Seidel  <eric@webkit.org>
111
112         Reviewed by Adam Barth.
113
114         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
115         https://bugs.webkit.org/show_bug.cgi?id=44584
116
117         * Scripts/webkitpy/tool/commands/queues_unittest.py:
118
119 2010-08-24  Eric Seidel  <eric@webkit.org>
120
121         Reviewed by Adam Barth.
122
123         commit-queue and EWS bots should report all failures
124         https://bugs.webkit.org/show_bug.cgi?id=41820
125
126         Right now commit-queue/EWS only report failures when the
127         patch under testing fails.  We should report all failures
128         to the status server so that we can diagnose when the bots
129         are wedged w/o needing to log into the machines.
130
131         I also reduced the amount of data we upload since we've seen
132         timeouts during status upload.
133
134         * Scripts/webkitpy/common/system/executive.py:
135         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
136         * Scripts/webkitpy/tool/commands/queues.py:
137         * Scripts/webkitpy/tool/commands/queues_unittest.py:
138
139 2010-08-24  Eric Seidel  <eric@webkit.org>
140
141         Reviewed by Adam Barth.
142
143         Remove HTML5 parser testing infrastructure now that we don't need it
144         https://bugs.webkit.org/show_bug.cgi?id=44581
145
146         * DumpRenderTree/mac/DumpRenderTree.mm:
147         (resetDefaultsToConsistentValues):
148         (initializeGlobalsFromCommandLineOptions):
149         * Scripts/old-run-webkit-tests:
150         * Scripts/test-html5-parser: Removed.
151
152 2010-08-24  Kent Tamura  <tkent@chromium.org>
153
154         Reviewed by Dimitri Glazkov.
155
156         [DRT/Chromium] Fix 28 inspector test crashes
157         https://bugs.webkit.org/show_bug.cgi?id=44574
158
159         Reset DevToolsClient and DevToolsAgent before closing a DevTools
160         WebView in order to avoid accessing to a deleted WebView instance.
161
162         * DumpRenderTree/chromium/TestShell.cpp:
163         (TestShell::closeDevTools):
164
165 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
166
167         Reviewed by Ojan Vafai.
168
169         new-run-webkit-tests: clean up code for test_types, test_failures
170
171         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
172         webkitpy.layout_tests.layout_package.test_failures, and remove
173         some dead code and otherwise clean up things.
174
175         https://bugs.webkit.org/show_bug.cgi?id=44559
176
177         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
178         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
179         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
180         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
181         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
182         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
183         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
184
185 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
186
187         Reviewed by Eric Seidel.
188
189         new-run-webkit-tests: revise unit testing strategy for test failures
190     
191         This change revamps the way we store test data for new-run-webkit-tests.
192         Previously we had a few copies of test files from the main test tree.
193         Now we have a bunch of completely fake test data and use the test
194         data to generate different kinds of test failures, getting
195         much better coverage.
196
197         https://bugs.webkit.org/show_bug.cgi?id=44556
198
199         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
200         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
201         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
202         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
203         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
204         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
205         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
206         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
207         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
208         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
209         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
210         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
211         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
212         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
213         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
214         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
215         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
216         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
217         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
218         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
219         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
220         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
221         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
222         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
223         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
224         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
225         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
226         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
227         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
228         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
229         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
230         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
231         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
232         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
233         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
234         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
235         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
236         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
237         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
238         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
239         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
240         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
241         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
242         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
243         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
244         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
245         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
246         * Scripts/webkitpy/layout_tests/port/test.py:
247         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
248         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
249
250 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
251
252         Reviewed by Eric Seidel.
253
254         speed up new-run-webkit-tests unit tests
255
256         Add a --no-record-results flag that turns off generating the JSON
257         results file on every test run. Generating the file requires us to
258         fetch the old results down from the bots, which can be slow. This
259         flag is off by default.
260     
261         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
262     
263         These changes together shorten the test cycle from ~4.5s to ~1.5s
264         - a 3x speedup.
265
266         https://bugs.webkit.org/show_bug.cgi?id=44553
267
268         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
269         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
270
271 2010-08-24  Tony Chang  <tony@chromium.org>
272
273         Reviewed by Eric Seidel.
274
275         [chromium] fix the platform result fallback order on mac/win
276         https://bugs.webkit.org/show_bug.cgi?id=44483
277
278         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
279
280 2010-08-24  Xan Lopez  <xlopez@igalia.com>
281
282         Reviewed by Martin Robinson.
283
284         Set a device to the event struct when building with GTK+ 3.x, it's
285         mandatory.
286
287         * DumpRenderTree/gtk/EventSender.cpp:
288         (keyDownCallback):
289
290 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
291
292         Reviewed by Xan Lopez.
293
294         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
295         https://bugs.webkit.org/show_bug.cgi?id=44534
296
297         Fix two double-frees introduced in my previous commit.
298
299         * DumpRenderTree/gtk/EventSender.cpp:
300         (contextClickCallback): Copy the event before using it again.
301         (keyDownCallback): Ditto.
302
303 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
304
305         Reviewed by Xan Lopez.
306
307         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
308         https://bugs.webkit.org/show_bug.cgi?id=44534
309
310         * DumpRenderTree/gtk/EventSender.cpp:
311         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
312         when setting it on the event. It is dereferenced by gdk_event_free(...).
313         (contextClickCallback): Ditto.
314         (mouseDownCallback): Ditto.
315         (mouseUpCallback): Ditto.
316         (mouseMoveToCallback): Ditto.
317         (mouseWheelToCallback): Ditto.
318         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
319         (dispatchEvent): Ditto. Also free the event when we are done with it.
320         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
321
322 2010-08-24  Andras Becsi  <abecsi@webkit.org>
323
324         [Qt] WebKit2 build fix.
325
326         * Scripts/enumerate-included-framework-headers:
327         Remove stray global option form sed.
328
329 2010-08-24  Kent Tamura  <tkent@chromium.org>
330
331         Reviewed by Jeremy Orlow.
332
333         [DRT/Chromium] Support for IndexedDB tests
334         https://bugs.webkit.org/show_bug.cgi?id=44490
335
336         * DumpRenderTree/chromium/TestShell.cpp:
337         (TestShell::TestShell): Enable IndexedDB.
338
339 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
340
341         Reviewed by Gustavo Noronha Silva.
342
343         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
344         https://bugs.webkit.org/show_bug.cgi?id=44465
345
346         Initialize the axes field of mouse button and motion events to null.
347         This is the value that should be used for events originating from the
348         mouse device.
349
350         * DumpRenderTree/gtk/EventSender.cpp:
351         (prepareMouseButtonEvent): Initalize button event axes field to null.
352         (mouseMoveToCallback): Initialize motion event axes field to null.
353
354 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
355
356         Unreviewed, rolling out r65703.
357         http://trac.webkit.org/changeset/65703
358         https://bugs.webkit.org/show_bug.cgi?id=44460
359
360         "Causing lots of crashes on Snow Leopard when running the
361         layout tests" (Requested by eseidel2 on #webkit).
362
363         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
364         (NP_Initialize):
365         (NP_GetEntryPoints):
366
367 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
368
369         Layout tests do not run when using WebKitTestRunner in a Debug build.
370         https://bugs.webkit.org/show_bug.cgi?id=44409
371
372         Reviewed by Dan Bernstein.
373
374         * WebKitTestRunner/win/TestControllerWin.cpp:
375         (WTR::TestController::initializeInjectedBundlePath):
376         Use InjectedBundle_debug.dll when building Debug.
377
378 2010-08-23  Xan Lopez  <xlopez@igalia.com>
379
380         Reviewed by Martin Robinson.
381
382         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
383         https://bugs.webkit.org/show_bug.cgi?id=42026
384
385         If a GTK+ 3.x build is present return that as the library to use,
386         otherwise fallback to the GTK+ 2.x build.
387
388         * Scripts/webkitdirs.pm:
389
390 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
391
392         Reviewed by Ariya Hidayat.
393
394         [Qt] Find needed forwarding headers for WebKit2 automatically
395         https://bugs.webkit.org/show_bug.cgi?id=44336
396
397         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
398         The new script does not satisfy the needs of this file however using normal includes
399         is generally better here.
400         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
401         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
402         given frameworks by files in the current directory (and subdirectories).
403         In the future this needs to be rewritten in perl for being able to use on Windows.
404
405 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
406
407         Reviewed by Ariya Hidayat.
408
409         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
410         https://bugs.webkit.org/show_bug.cgi?id=43010
411
412         * QtTestBrowser/launcherwindow.cpp:
413         (LauncherWindow::applyPrefs):
414         * QtTestBrowser/main.cpp:
415         (LauncherApplication::handleUserOptions):
416
417 2010-08-21  Sam Weinig  <sam@webkit.org>
418
419         Reviewed by Dan Bernstein.
420
421         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
422         https://bugs.webkit.org/show_bug.cgi?id=44386
423
424         * MiniBrowser/mac/AppDelegate.m:
425         (didRecieveMessageFromInjectedBundle):
426         (didNavigateWithNavigationData):
427         (-[BrowserAppDelegate init]):
428         (-[BrowserAppDelegate applicationWillTerminate:]):
429         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
430         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
431         (-[BrowserStatisticsWindowController dealloc]):
432         * MiniBrowser/mac/BrowserWindowController.m:
433         (-[BrowserWindowController initWithPageNamespace:]):
434         (-[BrowserWindowController fetch:]):
435         (-[BrowserWindowController windowWillClose:]):
436         (-[BrowserWindowController applicationTerminating]):
437         (closePage):
438         (runJavaScriptAlert):
439         (runJavaScriptConfirm):
440         (runJavaScriptPrompt):
441         (-[BrowserWindowController updateProvisionalURLForFrame:]):
442         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
443         (didClearWindowObjectForFrame):
444         * MiniBrowser/win/BrowserView.cpp:
445         (BrowserView::goToURL):
446         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
447         (WTR::PlatformWebView::~PlatformWebView):
448
449 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
450
451         Reviewed by Kenneth Rohde Christiansen.
452
453         WebKit does not build with Python 2.3
454         https://bugs.webkit.org/show_bug.cgi?id=44373
455
456         Replaced the function sorted() by a call to sort()
457         on the entry list.
458         The function sorted() has been added to Python 2.4.
459         The function method sort() of List works with older
460         versions of Python.
461
462         * Scripts/create-html-entity-table:
463
464 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
465
466         Reviewed by Pavel Feldman.
467
468         Web Inspector: Inspector tests were disabled for GTK.
469         https://bugs.webkit.org/show_bug.cgi?id=43977
470
471         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
472         path before running tests.
473
474 2010-08-20  Daniel Bates  <dbates@rim.com>
475
476         Reviewed by Eric Seidel.
477
478         svn-apply doesn't detect empty line with Windows line endings
479         after property value
480         https://bugs.webkit.org/show_bug.cgi?id=43981
481
482         Part 2 of 2
483
484         Add unit tests that were not landed in the first commit.
485
486         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
487           - Added the following test cases:
488             "SVN: binary file (isBinary true) using Windows line endings"
489             "SVN: property diff, followed by file change diff using Windows line endings"
490             "SVN: two consecutive property diffs using Windows line endings"
491             "SVN: binary file with executable bit change usng Windows line endings"
492             "SVN: binary file followed by property change on different file using Windows line endings"
493             "SVN: binary file followed by file change on different file using Windows line endings"
494             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
495             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
496         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
497           - Added the following test cases:
498             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
499             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
500             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
501             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
502             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
503             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
504             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
505             "single-line '+' with trailing new line using Windows line endings"
506             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
507             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
508             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
509         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
510           - Added the following test cases:
511             "single-line '-' change followed by empty line with Windows line endings"
512             "multi-line '+' change and start of binary patch with Windows line endings"
513
514 2010-08-20  Daniel Bates  <dbates@rim.com>
515
516         Reviewed by Eric Seidel.
517
518         svn-apply doesn't detect empty line with Windows line endings
519         after property value
520         https://bugs.webkit.org/show_bug.cgi?id=43981
521
522         Fixes an issue where an empty line following the property value
523         in an SVN property change diff would not be detected if it had
524         Windows line endings (i.e. ended in CRLF). Hence it was consumed
525         as if it was part of a multi-line property value. 
526
527         * Scripts/VCSUtils.pm:
528           - Modified parseSvnPropertyValue() to detect empty line
529             with Windows line endings.
530           - Added toWindowsLineEndings().
531         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
532           - Added the following test cases:
533             "SVN: binary file (isBinary true) using Windows line endings"
534             "SVN: property diff, followed by file change diff using Windows line endings"
535             "SVN: two consecutive property diffs using Windows line endings"
536             "SVN: binary file with executable bit change usng Windows line endings"
537             "SVN: binary file followed by property change on different file using Windows line endings"
538             "SVN: binary file followed by file change on different file using Windows line endings"
539             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
540             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
541         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
542           - Added the following test cases:
543             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
544             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
545             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
546             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
547             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
548             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
549             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
550             "single-line '+' with trailing new line using Windows line endings"
551             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
552             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
553             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
554         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
555           - Added the following test cases:
556             "single-line '-' change followed by empty line with Windows line endings"
557             "multi-line '+' change and start of binary patch with Windows line endings"
558
559 2010-08-19  David Kilzer  <ddkilzer@apple.com>
560
561         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
562
563         * MiniBrowser/mac/BrowserWindowController.m:
564         (decidePolicyForNavigationAction): Updated method signature.
565         (decidePolicyForNewWindowAction): Updated method signature.
566
567 2010-08-19  Adam Roben  <aroben@apple.com>
568
569         Test that NP_Initialize and NP_GetEntryPoints are called in the
570         correct order
571
572         The order differs between Mac and Windows (see r38858).
573
574         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
575         NP_Initialize when loading QuickTime when running
576         plugins/embed-attributes-setting.html in WebKit2 on Windows
577
578         Reviewed by Sam Weinig.
579
580         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
581         a boolean to record whether NP_GetEntryPoints has been called.
582         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
583         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
584         if NP_GetEntryPoints has been called already. This matches
585         Silverlight's behavior.
586
587 2010-08-19  Adam Roben  <aroben@apple.com>
588
589         Make build-webkittestrunner build TestNetscapePlugIn on Windows
590
591         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
592
593         Reviewed by Sam Weinig.
594
595         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
596         Threaded it in between ImageDiff and InjectedBundleGenerated.
597
598 2010-08-19  Ojan Vafai  <ojan@chromium.org>
599
600         Reviewed by Adam Barth.
601
602         install rietveld's upload script from a versioned url
603         https://bugs.webkit.org/show_bug.cgi?id=44291
604
605         autoinstall expects the file at a given URL to never change.
606         In order to be able to update the file, we need to be able to
607         change the path.
608
609         * Scripts/webkitpy/thirdparty/__init__.py:
610
611 2010-08-19  Ojan Vafai  <ojan@chromium.org>
612
613         Reviewed by Adam Barth.
614
615         add --webkit_patch_id to reitveld uploads
616         https://bugs.webkit.org/show_bug.cgi?id=44289
617
618         This is the first step in having rietveld store which
619         patches have been uploaded and getting rid of the
620         in-rietveld flag.
621
622         * Scripts/webkitpy/common/net/rietveld.py:
623         * Scripts/webkitpy/tool/mocktool.py:
624         * Scripts/webkitpy/tool/steps/postcodereview.py:
625
626 2010-08-19  Kenneth Russell  <kbr@google.com>
627
628         Reviewed by David Levin.
629
630         Adjust my status from committer to reviewer
631         https://bugs.webkit.org/show_bug.cgi?id=44277
632
633         * Scripts/webkitpy/common/config/committers.py:
634
635 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
636
637         Reviewed by Yury Semikhatsky.
638
639         Chromium DevTools: remove injected script fetcher from test harness.
640         https://bugs.webkit.org/show_bug.cgi?id=44266
641
642         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
643         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
644
645 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
646
647         Reviewed by Yury Semikhatsky.
648
649         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
650         Now that we populate front-end after its onload handler, we don't need
651         to install injected script early. Exposing injected script source on the WebCore
652         level here.
653         https://bugs.webkit.org/show_bug.cgi?id=44029
654
655         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
656         (DRTDevToolsAgent::runtimePropertyChanged):
657         (DRTDevToolsAgent::delayedFrontendLoaded):
658         (DRTDevToolsAgent::frontendLoaded):
659         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
660
661 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
662
663         Reviewed by Kenneth Rohde Christiansen.
664
665         [Gtk] Enable view mode media feature layout test
666         https://bugs.webkit.org/show_bug.cgi?id=43278
667
668         Add view mode media feature testing infrastructure, and add
669         placeholder methods for the other platforms'
670         LayoutTestControllers.
671
672         * DumpRenderTree/LayoutTestController.cpp:
673         (setViewModeMediaFeatureCallback):
674         (LayoutTestController::staticFunctions):
675         * DumpRenderTree/LayoutTestController.h:
676         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
677         (LayoutTestController::setViewModeMediaFeature):
678         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
679         (LayoutTestController::setViewModeMediaFeature):
680         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
681         (LayoutTestController::setViewModeMediaFeature):
682         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
683         (LayoutTestController::setViewModeMediaFeature):
684
685 2010-08-18  Mark Rowe  <mrowe@apple.com>
686
687         Reviewed by Sam Weinig.
688
689         Make it so the WebKit2 test slave runs the WebKit2 tests
690
691         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
692
693 2010-08-18  Sam Weinig  <sam@webkit.org>
694
695         Reviewed by Mark Rowe.
696
697         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
698         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
699         module and the TestNetscapePlugin.
700
701         * Scripts/old-run-webkit-tests:
702
703 2010-08-18  Adam Roben  <aroben@apple.com>
704
705         Fix hang when saving crash logs on Windows
706
707         * Scripts/old-run-webkit-tests:
708         (setUpWindowsCrashLogSaving):
709         (END):
710         Pass -s to regtool so it will write the Auto value as a string instead
711         of as a number. This was causing a "do you want to debug?" dialog to
712         appear.
713
714 2010-08-17  Victor Wang  <victorw@chromium.org>
715
716         Unreviewed. Fixed chromium incremental test json upload.
717         Quote builder name and test results server in url.
718
719         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
720
721 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
722
723         Reviewed by Ariya Hidayat.
724
725         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
726         https://bugs.webkit.org/show_bug.cgi?id=44124
727
728         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
729         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
730         Symbian dependencies.
731
732         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
733         (WebCore::DumpRenderTree::open):
734         * QtTestBrowser/launcherwindow.cpp:
735         (LauncherWindow::init):
736         (LauncherWindow::toggleFullScreenMode):
737         (LauncherWindow::showFPS):
738         (LauncherWindow::updateFPS):
739         * QtTestBrowser/launcherwindow.h:
740         (WindowOptions::WindowOptions):
741         * QtTestBrowser/mainwindow.cpp:
742         (MainWindow::buildUI):
743
744 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
745
746         Reviewed by David Levin.
747
748         new-run-webkit-tests: remove --show-sources option
749
750         --show-sources is pretty much obsolete with --trace everything, so
751         I'm removing it.
752
753         Also rename a couple of methods in the TestTextDiff class to make their
754         intended visibility (private) more obvious.
755
756         https://bugs.webkit.org/show_bug.cgi?id=44143
757
758         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
759         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
760         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
761         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
762         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
763
764 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
765
766         Reviewed by David Levin.
767
768         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
769
770         This code bit-rotted at some point more than a year ago, and nobody seems
771         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
772         should support instead, making this flag unnecessary anyway.
773
774         https://bugs.webkit.org/show_bug.cgi?id=44141
775
776         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
777         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
778         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
779
780 2010-08-17  Victor Wang  <victorw@chromium.org>
781
782         Reviewed by Ojan Vafai.
783
784         Update json results generator to have incremental json including
785         results for tests that pass in current run but failed before.
786
787         https://bugs.webkit.org/show_bug.cgi?id=44119
788
789         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
790         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
791         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
792
793 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
794
795         Reviewed by Eric Seidel.
796
797         fix test-webkitpy, add easy way to find a checkout root
798
799         test-webkitpy currently doesn't work right if run from someplace other
800         than the checkout root, and it spews a bunch of debug logging because
801         the deduplicate_tests tests contaminates the test environment.
802
803         This patch cleans up the deduplicate_tests unit tests, and creates
804         two new methods in scm.py: find_checkout_root() and default_scm(),
805         both of which use a single algorithm for guessing what checkout root
806         to use if you aren't explicitly told one from a path.
807
808         https://bugs.webkit.org/show_bug.cgi?id=44001
809
810         * Scripts/deduplicate-tests:
811         * Scripts/webkitpy/common/checkout/scm.py:
812         * Scripts/webkitpy/common/checkout/scm_unittest.py:
813         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
814         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
815         * Scripts/webkitpy/layout_tests/port/test.py:
816         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
817         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
818         * Scripts/webkitpy/tool/main.py:
819
820 2010-08-17  Victor Wang  <victorw@chromium.org>
821
822         Reviewed by Ojan Vafai.
823
824         Add support to the test results server for downloading json that
825         contains test list only.
826
827         This is for json results generator to generate incremental json
828         results so that it includes results not only for tests failed in
829         current run, but also tests failed before.
830
831         Also set the results type to "N" (no data) instead of "P" (pass)
832         if test results cannot be found in incremental json file.
833
834         https://bugs.webkit.org/show_bug.cgi?id=44117
835
836         * TestResultServer/handlers/testfilehandler.py:
837         * TestResultServer/model/jsonresults.py:
838         * TestResultServer/model/jsonresults_unittest.py:
839
840 2010-08-17  Adam Roben  <aroben@apple.com>
841
842         Use the right path style
843
844         * Scripts/old-run-webkit-tests:
845
846 2010-08-17  Adam Roben  <aroben@apple.com>
847
848         Fix typo
849
850         * Scripts/old-run-webkit-tests:
851
852 2010-08-17  Adam Roben  <aroben@apple.com>
853
854         Don't hang when running run-webkit-tests as a non-Administrator on
855         Vista/7
856
857         * Scripts/old-run-webkit-tests:
858         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
859         post-mortem debugger, rather than using NTSD itself. The latter waits
860         for user input when it fails to set the registry values; the former
861         does not.
862
863 2010-08-17  Adam Roben  <aroben@apple.com>
864
865         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
866         save crash logs on Windows
867
868         The crash logs are saved to /tmp/layout-test-results and have names
869         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
870
871         Unfortunately, crashes in the WebKit2 web process are recorded as
872         time-outs by run-webkit-tests. Fixing this is covered by
873         <http://webkit.org/b/44121>.
874
875         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
876         DumpRenderTree should save a stack trace and/or dump file when it
877         crashes
878
879         Reviewed by Sam Weinig.
880
881         * DumpRenderTree/win/DumpRenderTree.cpp:
882         (exceptionFilter):
883         (main):
884         * WebKitTestRunner/win/TestControllerWin.cpp:
885         (WTR::exceptionFilter):
886         (WTR::TestController::platformInitialize):
887         These changes set up an exception filter that prints #CRASHED to
888         stderr, then lets the exception propagate normally. This allows
889         run-webkit-tests to detect when we've crashed even when a post-mortem
890         debugger attaches to the process.
891
892         * Scripts/old-run-webkit-tests:
893         (top level): Declared some variables used by the crash-log-saving
894         code.
895         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
896         that the post-mortem debugger has access to it.
897         (toCygwinPath): Added. This is the opposite of toWindowsPath.
898         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
899         stderr, consider it a crash.
900         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
901         debugger, then sets ntsd as the post-mortem debugger. ntsd is
902         configured to save a crash log and then quit automatically.
903         (END): Added. Restores the previous post-mortem debugger when the
904         script exits.
905
906 2010-08-17  Victor Wang  <victorw@chromium.org>
907
908         Reviewed by ojan@chromium.org.
909
910         Update test results server:
911         1. Normalize test results and times after merging (prune tests where
912            all runs pass or do not have data, truncate all test items to max
913            number of builds)
914         2. times should be int not string.
915         3. when inserting a new test item, should keep old data regardless
916            whether or not they have same item type with new one.
917
918         https://bugs.webkit.org/show_bug.cgi?id=43861
919
920         * TestResultServer/model/jsonresults.py:
921         * TestResultServer/model/jsonresults_unittest.py:
922
923 2010-08-16  Sam Weinig  <sam@webkit.org>
924
925         Reviewed by Mark Rowe.
926
927         Add WebKit2 Mac tester to buildbot.
928
929         * BuildSlaveSupport/build.webkit.org-config/config.json:
930         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
931
932 2010-08-16  Paul Sawaya  <psawaya@apple.com>
933
934         Reviewed by Chris Marrin.
935
936         Added shader validation via ANGLE
937         https://bugs.webkit.org/show_bug.cgi?id=42405
938
939         Added ANGLE to webkit build
940
941         * Scripts/build-webkit:
942
943 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
944
945         [wx] Build fix, do not build WebCore as a convenience library as this leads to
946         errors in the Win build w/export symbols and causes problems with DOM bindings
947         debugging in gdb.
948
949         * DumpRenderTree/wscript:
950         * Scripts/build-webkit:
951         * wx/browser/wscript:
952         * wx/build/settings.py:
953         * wx/build/waf_extensions.py:
954
955 2010-08-16  Dan Bernstein  <mitz@apple.com>
956
957         Build fix.
958
959         * WebKitTestRunner/TestController.cpp:
960         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
961         (WTR::TestController::initialize): Ditto.
962
963 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
964
965         Reviewed by Kenneth Rohde Christiansen.
966
967         Handle content size change in WebKit2
968         Re-landing after fix.
969
970         https://bugs.webkit.org/show_bug.cgi?id=43198
971
972         * MiniBrowser/mac/BrowserWindowController.m:
973         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
974         * MiniBrowser/win/BrowserView.cpp:
975         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
976
977 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
978
979         Unreviewed, rolling out r65419.
980         http://trac.webkit.org/changeset/65419
981         https://bugs.webkit.org/show_bug.cgi?id=44053
982
983         Broke the Windows build (Requested by bbandix on #webkit).
984
985         * MiniBrowser/mac/BrowserWindowController.m:
986         (-[BrowserWindowController awakeFromNib]):
987         * MiniBrowser/win/BrowserView.cpp:
988         (BrowserView::create):
989
990 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
991
992         Reviewed by Kenneth Rohde Christiansen.
993
994         Handle content size change in WebKit2
995
996         https://bugs.webkit.org/show_bug.cgi?id=43198
997
998         * MiniBrowser/mac/BrowserWindowController.m:
999         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1000         * MiniBrowser/win/BrowserView.cpp:
1001         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1002
1003 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
1004
1005         Add my new email address to committers.py.
1006
1007         * Scripts/webkitpy/common/config/committers.py:
1008
1009 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
1010
1011         Add my old e-mail addresses to committers.py.
1012
1013         * Scripts/webkitpy/common/config/committers.py:
1014
1015 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1016
1017         WebEditorClient::didBeginEditing is never called in WebKit2
1018         https://bugs.webkit.org/show_bug.cgi?id=42939
1019
1020         Reviewed by Sam Weinig.
1021
1022         * WebKitTestRunner/PlatformWebView.h:
1023         Declare focus().
1024
1025         * WebKitTestRunner/TestController.cpp:
1026         (WTR::TestController::resetStateToConsistentValues):
1027         Focus the PlatformWebView.
1028
1029         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1030         (WTR::PlatformWebView::focus):
1031         Stubbed.
1032
1033         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1034         (WTR::PlatformWebView::focus):
1035         Focus the view.
1036
1037 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1038
1039         run-webkit-tests should not strip editing callbacks when using
1040         WebKitTestRunner on Windows
1041         https://bugs.webkit.org/show_bug.cgi?id=44000
1042
1043         Reviewed by Mark Rowe.
1044
1045         * Scripts/old-run-webkit-tests:
1046         Leave $stripEditingCallbacks undefined until we look for command-line
1047         arguments. If using WebKit2, set it to 0 if not explicity set on the
1048         command line. Later, set it to isCygwin() to match old behavior if it is
1049         not yet defined.
1050
1051 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
1052
1053         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
1054
1055         * wx/build/settings.py:
1056
1057 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
1058
1059         Reviewed by Kenneth Rohde Christiansen.
1060
1061         [GTK] autogen.sh not executed if build-webkit options change
1062         https://bugs.webkit.org/show_bug.cgi?id=42266
1063
1064         Rerun autogen.sh in situations where the arguments to build-webkit have
1065         changed since the previous build. This will fix some issues on the bots
1066         where the build does not notice changes to default build-webkit arguments.
1067
1068         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
1069
1070 2010-08-14  Eric Seidel  <eric@webkit.org>
1071
1072         Unreviewed.  Another fix to support python 2.3.
1073
1074         Add support for MathML entities
1075         https://bugs.webkit.org/show_bug.cgi?id=43949
1076
1077         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
1078          - It looks like our simplejson is version 1.7.3 which
1079            should be python 2.3 compatible.  But someone modified
1080            our copy slightly from the original source.
1081            I've removed the relative import in hopes this fixes
1082            the problem.
1083
1084 2010-08-13  Eric Seidel  <eric@webkit.org>
1085
1086         Unreviewed.  Build fix only.
1087
1088         Add support for MathML entities
1089         https://bugs.webkit.org/show_bug.cgi?id=43949
1090
1091         * Scripts/create-html-entity-table:
1092          - Hack sys.path to avoid executing 2.5 dependent python
1093            on systems (like chromium-win and Tiger) which do not have 2.5 python.
1094
1095 2010-08-13  Adam Barth  <abarth@webkit.org>
1096
1097         Reviewed by Eric Seidel.
1098
1099         Rename some concepts in HTML entity search to be more self-documenting
1100         https://bugs.webkit.org/show_bug.cgi?id=44004
1101
1102         Reflect name change in generator script.
1103
1104         * Scripts/create-html-entity-table:
1105
1106 2010-08-12  Adam Barth  <abarth@webkit.org>
1107
1108         Reviewed by Eric Seidel.
1109
1110         Add support for MathML entities
1111         https://bugs.webkit.org/show_bug.cgi?id=43949
1112
1113         A script for generating the C++ state data structure describing all the
1114         entities from a JSON description.
1115
1116         * Scripts/create-html-entity-table: Added.
1117
1118 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
1119
1120         Reviewed by Eric Seidel.
1121
1122         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
1123         check for exceptions on all threads, not just the first thread.
1124         
1125         This change also changes the logging behavior for wedged threads
1126         to only dump the stacks of threads that are actually wedged.
1127
1128         Refactor the thread classes in the dump_render_tree_thread module
1129         to make the contract between TestRunner and TestShellThread clearer.
1130
1131         Added a bunch of unit tests.
1132         https://bugs.webkit.org/show_bug.cgi?id=38561
1133
1134         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1135         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1136         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1137
1138 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
1139
1140         Reviewed by Shinichiro Hamaji.
1141
1142         Add test_expectations.txt syntax checker to check-webkit-style.
1143         https://bugs.webkit.org/show_bug.cgi?id=43899
1144
1145         Just utilizing layout_tests/layout_package/test_expectations.py for checking
1146         the syntax of test_expectations.txt.
1147         This change also moves tab checking class from style/checkers/text.py to
1148         style/checkers/common.py for sharing code.
1149
1150         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1151         * Scripts/webkitpy/style/checker.py:
1152         * Scripts/webkitpy/style/checkers/common.py:
1153         * Scripts/webkitpy/style/checkers/common_unittest.py:
1154         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
1155         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
1156         * Scripts/webkitpy/style/checkers/text.py:
1157         * Scripts/webkitpy/style_references.py:
1158
1159 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1160
1161         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
1162         https://bugs.webkit.org/show_bug.cgi?id=43945
1163
1164         Reviewed by Sam Weinig.
1165
1166         * WebKitTestRunner/TestInvocation.cpp:
1167         (WTR::sizeWebViewForCurrentTest):
1168         Allow for a Windows-style path.
1169
1170         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1171         (WTR::PlatformWebView::resizeTo):
1172         Call SetWindowPos to resize the view window.
1173
1174 2010-08-12  David Levin  <levin@chromium.org>
1175
1176         Build break fix.
1177
1178         * WebKitTestRunner/TestController.cpp:
1179         (WTR::TestController::resetStateToConsistentValues): Removed usage
1180         of a variable that doesn't exist in the class.
1181
1182 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1183
1184         WebKitTestRunner needs to run tests without using native controls
1185         https://bugs.webkit.org/show_bug.cgi?id=43772
1186
1187         Reviewed by Sam Weinig.
1188
1189         * WebKitTestRunner/TestController.cpp:
1190         (WTR::TestController::initialize):
1191         Call platformInitializeContext().
1192
1193         * WebKitTestRunner/TestController.h:
1194         Declare platformInitializeContext().
1195
1196         * WebKitTestRunner/mac/TestControllerMac.mm:
1197         (WTR::TestController::platformInitializeContext):
1198         Stubbed.
1199
1200         * WebKitTestRunner/win/TestControllerWin.cpp:
1201         (WTR::TestController::platformInitializeContext):
1202         Call WKContextSetShouldPaintNativeControls() to disable native control
1203         drawing.
1204
1205 2010-08-12  Sam Weinig  <sam@webkit.org>
1206
1207         Reviewed by Alexey Proskuryakov.
1208
1209         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
1210         https://bugs.webkit.org/show_bug.cgi?id=43653
1211
1212         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1213         (WTR::InjectedBundle::InjectedBundle):
1214         (WTR::InjectedBundle::didReceiveMessage):
1215         (WTR::InjectedBundle::beginTesting):
1216         (WTR::InjectedBundle::done):
1217         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1218         (WTR::InjectedBundle::isTestRunning):
1219         (WTR::InjectedBundle::):
1220         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1221         (WTR::InjectedBundlePage::stopLoading):
1222         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1223         (WTR::InjectedBundlePage::dump):
1224         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1225         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1226         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1227         (WTR::InjectedBundlePage::didClearWindowForFrame):
1228         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1229         (WTR::InjectedBundlePage::willAddMessageToConsole):
1230         (WTR::InjectedBundlePage::willSetStatusbarText):
1231         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1232         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1233         (WTR::InjectedBundlePage::shouldBeginEditing):
1234         (WTR::InjectedBundlePage::shouldEndEditing):
1235         (WTR::InjectedBundlePage::shouldInsertNode):
1236         (WTR::InjectedBundlePage::shouldInsertText):
1237         (WTR::InjectedBundlePage::shouldDeleteRange):
1238         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1239         (WTR::InjectedBundlePage::shouldApplyStyle):
1240         (WTR::InjectedBundlePage::didBeginEditing):
1241         (WTR::InjectedBundlePage::didEndEditing):
1242         (WTR::InjectedBundlePage::didChange):
1243         (WTR::InjectedBundlePage::didChangeSelection):
1244         Don't do any work if we are not currently running a test.
1245
1246         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1247         * WebKitTestRunner/StringFunctions.h:
1248         (WTR::toCF):
1249         Add conversion function for WKURLRef -> CFURLRef
1250
1251         * WebKitTestRunner/TestController.cpp:
1252         (WTR::TestController::TestController):
1253         (WTR::TestController::initialize):
1254         (WTR::TestController::resetStateToConsistentValues):
1255         (WTR::TestController::runTest):
1256         (WTR::TestController::didFinishLoadForFrame):
1257         * WebKitTestRunner/TestController.h:
1258         (WTR::TestController::):
1259         * WebKitTestRunner/TestInvocation.cpp:
1260         (WTR::TestInvocation::invoke):
1261         * WebKitTestRunner/TestInvocation.h:
1262         Move resetting code to TestController.
1263
1264         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1265         * WebKitTestRunner/mac/TestControllerMac.mm:
1266         (WTR::TestController::runUntil):
1267         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1268         * WebKitTestRunner/win/TestControllerWin.cpp:
1269         (WTR::TestController::runUntil):
1270         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
1271         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1272         Move runUntil to TestController.
1273
1274 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1275
1276         Unreviewed.
1277
1278         Adding myself to the committers list.
1279
1280         * Scripts/webkitpy/common/config/committers.py:
1281
1282 2010-08-12  Hayato Ito  <hayato@chromium.org>
1283
1284         Reviewed by Tony Chang.
1285
1286         Merge pretty printers for gdb.
1287         https://bugs.webkit.org/show_bug.cgi?id=43850
1288
1289         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
1290         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
1291         webcore.py is left for backward compatibility.
1292
1293         * gdb/webcore.py:
1294         * gdb/webkit.py: Added.
1295         * gdb/wtf.py: Removed.
1296
1297 2010-08-11  Tony Chang  <tony@chromium.org>
1298
1299         Reviewed by David Levin.
1300
1301         [chromium] add google-chrome layout test result directories
1302         https://bugs.webkit.org/show_bug.cgi?id=43889
1303
1304         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1305         * Scripts/webkitpy/layout_tests/port/factory.py:
1306         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
1307         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1308
1309 2010-08-11  Kent Tamura  <tkent@chromium.org>
1310
1311         Reviewed by Dimitri Glazkov.
1312
1313         [DRT/Chromium] Disable accelerated compositing
1314         https://bugs.webkit.org/show_bug.cgi?id=43894
1315
1316         Disable accelerated compositing because DRT is not ready for
1317         it. This change fixes hundreds of test crashes on Windows and
1318         Linux.
1319
1320         * DumpRenderTree/chromium/TestShell.cpp:
1321         (TestShell::resetWebSettings):
1322
1323 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1324
1325         Unreviewed. Adding my Collabora personality to the list.
1326
1327         * Scripts/webkitpy/common/config/committers.py:
1328
1329 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
1330
1331         Adding myself as a reviewer.
1332
1333         * Scripts/webkitpy/common/config/committers.py:
1334
1335 2010-08-11  Daniel Bates  <dbates@rim.com>
1336
1337         Reviewed by Darin Adler.
1338
1339         Perl warnings when running commit-log-editor
1340         https://bugs.webkit.org/show_bug.cgi?id=43856
1341
1342         Fixes Perl warnings introduced by the patch for Bug #40548.
1343
1344         Perl doesn't have symbolic names for True/False. Instead, we
1345         should use boolean values. Moreover, the variable installedEditorApplication
1346         is not be used and should be renamed builtEditorApplication so that it
1347         uses the existing machinery to set the commit log editor application.
1348
1349         * Scripts/commit-log-editor:
1350
1351 2010-08-11  Adam Barth  <abarth@webkit.org>
1352
1353         Reviewed by Eric Seidel.
1354
1355         Trying waiting for httpd lock in the EWS
1356         https://bugs.webkit.org/show_bug.cgi?id=43833
1357
1358         If this works, we can probably run the tests on the mac-ews, which
1359         would be very exciting.  :)
1360
1361         * Scripts/webkitpy/tool/steps/runtests.py:
1362
1363 2010-08-11  Marcus Bulach  <bulach@chromium.org>
1364
1365         Reviewed by Eric Seidel.
1366
1367         Check in a script to list redundant test outputs.
1368         https://bugs.webkit.org/show_bug.cgi?id=37630
1369
1370         If e.g. platform/mac-leopard is missing an expected test output, we
1371         fall back on platform/mac.  This means it's possible to grow redundant
1372         test outputs, where we have the same expected data in both a platform
1373         directory and another platform it falls back on.
1374         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
1375
1376         * Scripts/deduplicate-tests: Added.
1377         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
1378         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
1379
1380 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1381
1382         Reviewed by Ariya Hidayat.
1383
1384         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
1385         https://bugs.webkit.org/show_bug.cgi?id=43853
1386
1387         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
1388         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
1389         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
1390         to slots at all.
1391
1392         * QtTestBrowser/launcherwindow.cpp:
1393         (LauncherWindow::createChrome):
1394         (LauncherWindow::animatedFlip):
1395         (LauncherWindow::animatedYFlip):
1396         * QtTestBrowser/launcherwindow.h:
1397
1398 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1399
1400         Reviewed by Simon Hausmann.
1401
1402         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
1403         https://bugs.webkit.org/show_bug.cgi?id=43851
1404
1405         All window options data (including the bool holding if the view is either QWebView or
1406         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
1407         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
1408         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
1409         getting broken.
1410
1411         Patch addresses this issue.
1412
1413         * QtTestBrowser/launcherwindow.cpp:
1414         (LauncherWindow::createChrome):
1415         (LauncherWindow::toggleWebView):
1416         (LauncherWindow::toggleAcceleratedCompositing):
1417
1418 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
1419
1420         Reviewed by Ariya Hidayat.
1421
1422         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
1423         https://bugs.webkit.org/show_bug.cgi?id=43831
1424
1425         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
1426
1427         * QtTestBrowser/webview.cpp:
1428         (WebViewGraphicsBased::WebViewGraphicsBased):
1429         (WebViewGraphicsBased::animatedYFlip):
1430
1431 2010-08-11  Darin Adler  <darin@apple.com>
1432
1433         Reviewed by John Sullivan.
1434
1435         Improved editor options for prepare-ChangeLog and commit-log-editor
1436         https://bugs.webkit.org/show_bug.cgi?id=40548
1437
1438         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
1439         values like "xed --launch --wait" work properly.
1440
1441         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
1442         use a command line tool with the $openChangeLogs feature.
1443
1444 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
1445
1446         Reviewed by Pavel Feldman.
1447
1448         Web Inspector: remove InjectDispatch.js
1449         https://bugs.webkit.org/show_bug.cgi?id=43835
1450
1451         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1452         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1453
1454 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
1455
1456         Reviewed by Eric Seidel.
1457
1458         webkit-patch should refuse to run under Win32 Python
1459         https://bugs.webkit.org/show_bug.cgi?id=40962
1460
1461         Given that there are lots of places in webkit-patch's code that
1462         assume unix-style filenames (forward slashes), webkit-patch fails
1463         with weird file-not-found errors when run under a native windows
1464         Python. It would be nice if we just trapped this and errored out
1465         at the beginning, rather than producing unpredictable errors.
1466
1467         * Scripts/webkit-patch:
1468
1469 2010-08-10  Kent Tamura  <tkent@chromium.org>
1470
1471         Unreviewed, build fix.
1472         
1473         Chromium build fix for r65107.
1474
1475         * DumpRenderTree/chromium/LayoutTestController.cpp:
1476         (LayoutTestController::suspendAnimations):
1477         (LayoutTestController::resumeAnimations):
1478
1479 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
1480
1481         Reviewed by Xan Lopez.
1482
1483         [GTK] http/tests/media/video-cookie.html fails
1484         https://bugs.webkit.org/show_bug.cgi?id=42240
1485
1486         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1487         (LayoutTestController::setAlwaysAcceptCookies): create the
1488         SoupCookieJar if it does not exist. Otherwise the accept policy
1489         won't be set.
1490
1491 2010-08-10  Chris Marrin  <cmarrin@apple.com>
1492
1493         Reviewed by Oliver Hunt.
1494
1495         Add suspendAnimations/resumeAnimation API to DRT
1496         https://bugs.webkit.org/show_bug.cgi?id=43733
1497         
1498         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
1499         Calls functions with the same names on AnimationController for the 
1500         mainFrame.
1501
1502         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1503         * DumpRenderTree/LayoutTestController.cpp:
1504         (suspendAnimationsCallback):
1505         (resumeAnimationsCallback):
1506         (LayoutTestController::staticFunctions):
1507         * DumpRenderTree/LayoutTestController.h:
1508         * DumpRenderTree/chromium/LayoutTestController.cpp:
1509         (LayoutTestController::LayoutTestController):
1510         (LayoutTestController::suspendAnimations):
1511         (LayoutTestController::resumeAnimations):
1512         * DumpRenderTree/chromium/LayoutTestController.h:
1513         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1514         (LayoutTestController::suspendAnimations):
1515         (LayoutTestController::resumeAnimations):
1516         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1517         (LayoutTestController::suspendAnimations):
1518         (LayoutTestController::resumeAnimations):
1519         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1520         (LayoutTestController::suspendAnimations):
1521         (LayoutTestController::resumeAnimations):
1522         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1523         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1524         (LayoutTestController::suspendAnimations):
1525         (LayoutTestController::resumeAnimations):
1526         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1527         (LayoutTestController::suspendAnimations):
1528         (LayoutTestController::resumeAnimations):
1529
1530 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1531
1532         Reviewed by Ojan Vafai.
1533
1534         [Chromium/DRT] Enable saving layout test results.
1535         https://bugs.webkit.org/show_bug.cgi?id=43796
1536
1537         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
1538             parameters to the new-run-webkit-tests, including the name
1539             of the test results server.
1540
1541 2010-08-10  Jian Li  <jianli@chromium.org>
1542
1543         More chromium build fix.
1544
1545         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1546         (MockSpellCheck::spellCheckWord):
1547         (MockSpellCheck::initializeIfNeeded):
1548         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1549         (NotificationPresenter::grantPermission):
1550         (NotificationPresenter::show):
1551         (NotificationPresenter::checkPermission):
1552
1553 2010-08-10  Jian Li  <jianli@chromium.org>
1554
1555         Chromium build fix.
1556
1557         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1558         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1559
1560 2010-08-10  Victor Wang  <victorw@chromium.org>
1561
1562         Reviewed by Ojan Vafai.
1563
1564         Update test results server merge logic so the aggregated
1565         results and times are updated for tests that are
1566         in aggragated json but not in incremental json.
1567
1568         Also update unittest to test this case.
1569
1570         https://bugs.webkit.org/show_bug.cgi?id=43769
1571
1572         * TestResultServer/model/jsonresults.py:
1573         * TestResultServer/model/jsonresults_unittest.py:
1574
1575 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1576
1577         Reviewed by Ariya Hidayat.
1578
1579         [Qt] QtTestBrowser: proper set scene rect
1580
1581         When resizesToContents is ON scene's rect is set to the boundary of
1582         the mainFrame. However, navigating to other web page should keep resizing
1583         scene's rect according to the new document loaded. Patch addresses this issue.
1584
1585         Now resizesToContents and scrolling properly work on QtTestBrowser.
1586
1587         * QtTestBrowser/webview.cpp:
1588         (WebViewGraphicsBased::setPage):
1589         (WebViewGraphicsBased::contentsSizeChanged):
1590         (WebViewGraphicsBased::setResizesToContents):
1591         (WebViewGraphicsBased::resizeEvent):
1592         * QtTestBrowser/webview.h:
1593
1594 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1595
1596         Reviewed by Ariya Hidayat.
1597
1598         [Qt] QtTestBrowser: Clean up LauncherWindow code.
1599
1600         * QtTestBrowser/launcherwindow.cpp:
1601         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
1602         (LauncherWindow::init): Fixed comments.
1603         (LauncherWindow::applyPrefs): Move the method around.
1604         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
1605
1606 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1607
1608         Reviewed by Ariya Hidayat.
1609
1610         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
1611
1612         It gets control+0 the same visual effect as control++ or control-.
1613
1614         * QtTestBrowser/launcherwindow.cpp:
1615         (LauncherWindow::toggleZoomTextOnly):
1616
1617 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1618
1619         Reviewed by Ariya Hidayat.
1620
1621         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
1622
1623         Not all instances of LauncherWindow need its own m_zoomLevel.
1624
1625         * QtTestBrowser/launcherwindow.cpp:
1626         * QtTestBrowser/launcherwindow.h:
1627
1628 2010-08-09  Sam Weinig  <sam@webkit.org>
1629
1630         Reviewed by Geoffrey Garen.
1631
1632         Add zoom support for injected bundle
1633         https://bugs.webkit.org/show_bug.cgi?id=43759
1634
1635         Use zoom factor SPI to implement zoom related eventSender functions.
1636
1637         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1638         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1639         (WTR::EventSendingController::textZoomIn):
1640         (WTR::EventSendingController::textZoomOut):
1641         (WTR::EventSendingController::zoomPageIn):
1642         (WTR::EventSendingController::zoomPageOut):
1643         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1644         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1645         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
1646
1647 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
1648
1649         Speculative chromium build fix III.
1650
1651         * DumpRenderTree/chromium/MockSpellCheck.h:
1652         * DumpRenderTree/chromium/NotificationPresenter.h:
1653         * DumpRenderTree/chromium/WebViewHost.h:
1654         (WebViewHost::addClearHeader):
1655         (WebViewHost::clearHeaders):
1656
1657 2010-08-09  Ojan Vafai  <ojan@chromium.org>
1658
1659         Reviewed by Tony Chang.
1660
1661         increase the number of test results that we save
1662         https://bugs.webkit.org/show_bug.cgi?id=43763
1663
1664         Now that we do incremental uploads, we can increase the number of
1665         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
1666
1667         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1668
1669 2010-08-09  Evan Martin  <evan@chromium.org>
1670
1671         Reviewed by Tony Chang.
1672
1673         [chromium] DRT error print statement incorrectly tries to print a FILE*
1674         https://bugs.webkit.org/show_bug.cgi?id=43747
1675
1676         * DumpRenderTree/chromium/ImageDiff.cpp:
1677         (writeFile): pass the correct pointer.
1678
1679 2010-08-09  Victor Wang  <victorw@chromium.org>
1680
1681         Reviewed by Ojan Vafai.
1682
1683         Upload incremental test results json to server by default.
1684
1685         https://bugs.webkit.org/show_bug.cgi?id=43743
1686
1687         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1688
1689 2010-08-09  Eric Seidel  <eric@webkit.org>
1690
1691         Reviewed by Adam Barth.
1692
1693         EWS bots wait 2 minutes between patches
1694         https://bugs.webkit.org/show_bug.cgi?id=43731
1695
1696         * Scripts/webkitpy/tool/bot/queueengine.py:
1697          - Don't sleep after failures.  This was a hold-over from
1698            an earlier design.
1699         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1700          - EWS bots were not properly reporting true/false from process_work_item.
1701            They were always returning None, thus false, thus always logging
1702            as a failure and sleeping 2 minutes after each patch.
1703
1704 2010-08-09  Sam Weinig  <sam@webkit.org>
1705
1706         Reviewed by Anders Carlsson.
1707
1708         Stub out EventSender for WebKitTestRunner
1709         https://bugs.webkit.org/show_bug.cgi?id=43703
1710
1711         * WebKitTestRunner/DerivedSources.make:
1712         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1713         Add ability to pass javascript arguments to the wrapped object.
1714
1715         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
1716         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
1717         (WTR::EventSendingController::create):
1718         (WTR::EventSendingController::EventSendingController):
1719         (WTR::EventSendingController::~EventSendingController):
1720         (WTR::EventSendingController::wrapperClass):
1721         (WTR::setExceptionForString):
1722         (WTR::EventSendingController::mouseDown):
1723         (WTR::EventSendingController::mouseUp):
1724         (WTR::EventSendingController::mouseMoveTo):
1725         (WTR::EventSendingController::keyDown):
1726         (WTR::EventSendingController::contextClick):
1727         (WTR::EventSendingController::leapForward):
1728         (WTR::EventSendingController::textZoomIn):
1729         (WTR::EventSendingController::textZoomOut):
1730         (WTR::EventSendingController::zoomPageIn):
1731         (WTR::EventSendingController::zoomPageOut):
1732         (WTR::EventSendingController::makeWindowObject):
1733         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
1734         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1735         (WTR::InjectedBundle::reset):
1736         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1737         (WTR::InjectedBundle::eventSendingController):
1738         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1739         (WTR::InjectedBundlePage::didClearWindowForFrame):
1740         Add stubbed out EventSenderController.
1741
1742         * WebKitTestRunner/InjectedBundle/GCController.h:
1743         Remove incorrect comment.
1744
1745         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1746         * WebKitTestRunner/win/InjectedBundle.vcproj:
1747         Add new files.
1748
1749 2010-08-08  Kent Tamura  <tkent@chromium.org>
1750
1751         Unreviewed, trivial fix.
1752
1753         Fix "WindowsError: [Error 32] The process cannot access the file
1754         because it is being used by another process" introduced by r64959.
1755
1756         * BuildSlaveSupport/test-result-archive:
1757
1758 2010-08-08  Kent Tamura  <tkent@chromium.org>
1759
1760         Reviewed by Tony Chang.
1761
1762         Chromium buildbot: Avoid "zip" command dependency
1763         https://bugs.webkit.org/show_bug.cgi?id=43470
1764
1765         * BuildSlaveSupport/test-result-archive:
1766          For Chromium port, creates a zip archive with zipfile package of Python
1767          instead of external "zip" command. We'd like to avoid additional
1768          command installation.
1769
1770 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
1771
1772         WebKitTestRunner should add the QuickTime dir to the PATH environment
1773         variable
1774         https://bugs.webkit.org/show_bug.cgi?id=43686
1775
1776         Reviewed by Dan Bernstein.
1777
1778         * WebKitTestRunner/win/TestControllerWin.cpp:
1779         (WTR::addQTDirToPATH):
1780         Copied from DRT.
1781         (WTR::TestController::platformInitialize):
1782         Call addQTDirToPath().
1783         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1784         Link to shlwapi.lib for SHGetValue.
1785
1786 2010-08-07  Sam Weinig  <sam@webkit.org>
1787
1788         Reviewed by Maciej Stachowiak.
1789
1790         WebKitTestRunner needs layoutTestController.dumpTitleChanges
1791         <rdar://problem/8213861>
1792         https://bugs.webkit.org/show_bug.cgi?id=42683
1793
1794         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1795         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1796         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1797         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1798         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1799         (WTR::LayoutTestController::LayoutTestController):
1800         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1801         (WTR::LayoutTestController::dumpTitleChanges):
1802         (WTR::LayoutTestController::shouldDumpTitleChanges):
1803
1804 2010-08-07  Sam Weinig  <sam@webkit.org>
1805
1806         Reviewed by Anders Carlsson.
1807
1808         WebKitTestRunner needs to print onunload handler information
1809         <rdar://problem/8213831>
1810         https://bugs.webkit.org/show_bug.cgi?id=42703
1811
1812         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1813         (WTR::operator<<):
1814         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1815
1816 2010-08-07  Sam Weinig  <sam@webkit.org>
1817
1818         Reviewed by Anders Carlsson.
1819
1820         Add additional loader client functions need to complete WebKitTestRunner
1821         https://bugs.webkit.org/show_bug.cgi?id=43684
1822
1823         Remove unnecessary and jarring underscores as well.
1824
1825         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1826         (didClearWindowObjectForFrame):
1827         (didCreatePage):
1828         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1829         (WTR::InjectedBundlePage::InjectedBundlePage):
1830         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1831         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1832         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1833         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1834         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1835         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1836         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1837         (WTR::InjectedBundlePage::didClearWindowForFrame):
1838         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1839         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1840         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1841         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1842         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1843         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1844         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1845         (WTR::InjectedBundlePage::willAddMessageToConsole):
1846         (WTR::InjectedBundlePage::willSetStatusbarText):
1847         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1848         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1849         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1850         (WTR::InjectedBundlePage::shouldBeginEditing):
1851         (WTR::InjectedBundlePage::shouldEndEditing):
1852         (WTR::InjectedBundlePage::shouldInsertNode):
1853         (WTR::InjectedBundlePage::shouldInsertText):
1854         (WTR::InjectedBundlePage::shouldDeleteRange):
1855         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1856         (WTR::InjectedBundlePage::shouldApplyStyle):
1857         (WTR::InjectedBundlePage::didBeginEditing):
1858         (WTR::InjectedBundlePage::didEndEditing):
1859         (WTR::InjectedBundlePage::didChange):
1860         (WTR::InjectedBundlePage::didChangeSelection):
1861         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1862
1863 2010-08-07  Dan Bernstein  <mitz@apple.com>
1864
1865         Build fix.
1866
1867         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
1868         to JSGCController.{cpp,h} relative to the build root.
1869
1870 2010-08-07  Sam Weinig  <sam@webkit.org>
1871
1872         Reviewed by Anders Carlsson.
1873
1874         WebKitTestRunner needs GCController
1875         <rdar://problem/8213834>
1876         https://bugs.webkit.org/show_bug.cgi?id=42701
1877
1878         * WebKitTestRunner/DerivedSources.make:
1879         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
1880         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
1881         (WTR::setProperty):
1882         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
1883         (WTR::GCController::create):
1884         (WTR::GCController::GCController):
1885         (WTR::GCController::~GCController):
1886         (WTR::GCController::wrapperClass):
1887         (WTR::GCController::collect):
1888         (WTR::GCController::collectOnAlternateThread):
1889         (WTR::GCController::getJSObjectCount):
1890         (WTR::GCController::makeWindowObject):
1891         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
1892         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1893         (WTR::InjectedBundle::reset):
1894         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1895         (WTR::InjectedBundle::bundle):
1896         (WTR::InjectedBundle::gcController):
1897         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1898         (WTR::InjectedBundlePage::didClearWindowForFrame):
1899         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1900         (WTR::LayoutTestController::keepWebHistory):
1901         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1902         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1903         * WebKitTestRunner/win/InjectedBundle.vcproj:
1904
1905 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
1906
1907         WebKitTestRunner needs to be able to set the font smoothing type
1908         https://bugs.webkit.org/show_bug.cgi?id=43406
1909
1910         Reviewed by Adam Roben.
1911
1912         * WebKitTestRunner/TestInvocation.cpp:
1913         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1914         Set the font smoothing level to
1915         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
1916
1917 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
1918
1919         Fix a missed variable rename.
1920
1921         Unreviewed.
1922
1923         * Scripts/old-run-webkit-tests:
1924
1925 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
1926
1927         mac-wk2/Skipped should be used on Windows when running regression tests
1928         https://bugs.webkit.org/show_bug.cgi?id=43494
1929
1930         Reviewed by Adam Roben.
1931
1932         * Scripts/old-run-webkit-tests:
1933         If the platform is win-wk2, also read the mac-wk2 skipped list.
1934
1935 2010-08-06  Kent Tamura  <tkent@chromium.org>
1936
1937         Reviewed by Dimitri Glazkov.
1938
1939         [DRT/Chromium] Should revoke scheduled tasks
1940         https://bugs.webkit.org/show_bug.cgi?id=43560
1941
1942         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1943         (DRTDevToolsAgent::reset): Calls RevokeAll().
1944         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1945         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1946         (DRTDevToolsClient::reset): Calls RevokeAll().
1947         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1948         * DumpRenderTree/chromium/EventSender.cpp:
1949         (EventSender::reset): Calls RevokeAll().
1950         * DumpRenderTree/chromium/LayoutTestController.cpp:
1951         (LayoutTestController::reset): Calls RevokeAll().
1952         * DumpRenderTree/chromium/TestShell.cpp:
1953         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
1954
1955 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1956
1957         Reviewed by Antonio Gomes.
1958
1959         [Qt] Fix the DRT build on Mac OS X
1960
1961         * DumpRenderTree/qt/DumpRenderTree.pro:
1962
1963 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
1964
1965         Reviewed by Pavel Feldman.
1966
1967         Rietvield's upload.py moved to a different location.
1968         https://bugs.webkit.org/show_bug.cgi?id=43613
1969
1970         * Scripts/webkitpy/thirdparty/__init__.py:
1971
1972 2010-05-23  Eric Seidel  <eric@webkit.org>
1973
1974         Reviewed by Adam Barth.
1975
1976         QueueStatusServer needs better queue-status pages
1977         https://bugs.webkit.org/show_bug.cgi?id=39562
1978
1979         The primary goal of this patch is to display queue
1980         positions somewhere on the site so that it's easier
1981         for commit-queue users to know when their pach will
1982         be landed.  I also tried to improve the root page
1983         to be more useful than the previous wall of status text.
1984
1985         * QueueStatusServer/handlers/recentstatus.py:
1986         * QueueStatusServer/main.py:
1987         * QueueStatusServer/model/queues.py:
1988         * QueueStatusServer/templates/recentstatus.html:
1989
1990 2010-08-05  Victor Wang  <victorw@chromium.org>
1991
1992         Reviewed by Ojan Vafai.
1993
1994         Add option to generate/upload incremental json results to test result server.
1995         Also refactor the json results generator unittest code to test
1996         incremental and aggregated json results.
1997
1998         https://bugs.webkit.org/show_bug.cgi?id=43519
1999
2000         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2001         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2002         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2003         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2004
2005 2010-08-05  Jian Li  <jianli@chromium.org>
2006
2007         Reviewed by David Levin.
2008
2009         Unify blob related feature defines to ENABLE(BLOB).
2010         https://bugs.webkit.org/show_bug.cgi?id=43081
2011
2012         * Scripts/build-webkit:
2013
2014 2010-08-05  Satish Sampath  <satish@chromium.org>
2015
2016         Reviewed by Jeremy Orlow.
2017
2018         Add speech input controller mock in WebKit and a layout test.
2019         https://bugs.webkit.org/show_bug.cgi?id=43477
2020
2021         Added LayoutTestController::setMockSpeechInputResultCallback method.
2022
2023         * DumpRenderTree/LayoutTestController.cpp:
2024         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
2025         (LayoutTestController::staticFunctions):
2026         * DumpRenderTree/LayoutTestController.h:
2027         * DumpRenderTree/chromium/LayoutTestController.cpp:
2028         (LayoutTestController::LayoutTestController):
2029         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
2030         (LayoutTestController::speechInputController): Creates the mock controller.
2031         * DumpRenderTree/chromium/LayoutTestController.h:
2032         * DumpRenderTree/chromium/WebViewHost.cpp:
2033         (WebViewHost::speechInputController): Creates the mock controller.
2034         * DumpRenderTree/chromium/WebViewHost.h:
2035         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2036         (LayoutTestController::setMockSpeechInputResult): dummy method.
2037         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2038         (LayoutTestController::setMockSpeechInputResult): dummy method.
2039         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2040         (LayoutTestController::setMockSpeechInputResult): dummy method.
2041         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2042         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
2043         (LayoutTestController::setMockSpeechInputResult):
2044         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
2045         (LayoutTestController::setMockSpeechInputResult):
2046
2047 2010-08-04  Adam Roben  <aroben@apple.com>
2048
2049         Fix the path to TestNetscapePlugin's directory on Windows
2050
2051         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
2052         load TestNetscapePlugin
2053
2054         Reviewed by Jon Honeycutt.
2055
2056         * WebKitTestRunner/win/TestControllerWin.cpp:
2057         (WTR::TestController::initializeTestPluginDirectory):
2058         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
2059         next to WebKitTestRunner.exe. Previously we were passing the directory
2060         that contains WebKitTestRunner.exe. Also fixed some leaks.
2061
2062 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
2063
2064         Reviewed by Shinichiro Hamaji.
2065
2066         check-webkit-style returns non-zero when patch is entirely minus lines.
2067         https://bugs.webkit.org/show_bug.cgi?id=38169
2068
2069         * Scripts/check-webkit-style:
2070         Check whether a patch contains modified files that are entirely minus lines.
2071         * Scripts/webkitpy/style/filereader.py:
2072         Add a variable that holds number of files that contain only deleted lines.
2073         * Scripts/webkitpy/style/patchreader.py:
2074         Count up modified files that contain only deleted lines.
2075
2076 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
2077
2078         Reviewed by Yury Semikhatsky.
2079
2080         DevTools: get rid of delayed command dispatching on front-end side.
2081
2082         https://bugs.webkit.org/show_bug.cgi?id=43479
2083
2084         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2085         (DRTDevToolsAgent::detach):
2086         (DRTDevToolsAgent::frontendLoaded):
2087         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2088         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2089         (DRTDevToolsClient::~DRTDevToolsClient):
2090         (DRTDevToolsClient::sendFrontendLoaded):
2091         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2092
2093 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
2094
2095         Reviewed by Shinichiro Hamaji.
2096
2097         Fixes check-webkit-style false positive on "new uint32_t."
2098         https://bugs.webkit.org/show_bug.cgi?id=43077
2099
2100         * Scripts/webkitpy/style/checkers/cpp.py:
2101         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2102
2103 2010-08-04  Kent Tamura  <tkent@chromium.org>
2104
2105         Reviewed by Dimitri Glazkov.
2106
2107         [DRT/Chromium] Remove base/linked_ptr.h dependency
2108         https://bugs.webkit.org/show_bug.cgi?id=43472
2109
2110         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
2111         We need to use RefPtr<> because m_pendingEntry points an object in
2112         m_entries or not in m_entries.
2113
2114         * DumpRenderTree/chromium/TestNavigationController.cpp:
2115         (TestNavigationEntry::create): Added.
2116         (TestNavigationController::activeEntry):
2117         (TestNavigationController::didNavigateToEntry):
2118         (TestNavigationController::discardPendingEntry):
2119         (TestNavigationController::insertEntry):
2120         (TestNavigationController::navigateToPendingEntry):
2121         * DumpRenderTree/chromium/TestNavigationController.h:
2122         * DumpRenderTree/chromium/WebViewHost.cpp:
2123         (WebViewHost::loadURLForFrame):
2124          Use TestNavigationEntry::create().
2125         (WebViewHost::updateURL):
2126          Use RefPtr<>.
2127         (WebViewHost::updateSessionHistory):
2128          Remove unnecessary static_cast<>.
2129
2130 2010-08-04  Kent Tamura  <tkent@chromium.org>
2131
2132         Reviewed by Dimitri Glazkov.
2133
2134         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
2135         https://bugs.webkit.org/show_bug.cgi?id=43333
2136
2137         * BuildSlaveSupport/test-result-archive:
2138           - Make layoutTestResultsDir local and pass it to archiveTestResults()
2139           - Adjust layoutTestResultsDir for Chromium
2140
2141 2010-08-04  Kent Tamura  <tkent@chromium.org>
2142
2143         Reviewed by Dimitri Glazkov.
2144
2145         NRWT: websocket_server startup detection failure
2146         https://bugs.webkit.org/show_bug.cgi?id=43466
2147
2148         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2149          Increase timeout value: 5 second -> 10 second
2150
2151 2010-08-04  Victor Wang  <victorw@chromium.org>
2152
2153         Reviewed by Ojan Vafai.
2154
2155         -. Add result.json incremental merging functionality to test results app engine.
2156         -. blobstore is not suitable for AE data merging and there is no API to
2157            programatically edit existing blob or write a new one yet, so replace blobstore
2158            with datastore. If file is oversize (>1000*1000 bytes), store file data in
2159            multiple datastore entries.
2160         -. Fix styles.
2161
2162         Test: jsonresults_unittest to test merging logics.
2163
2164         https://bugs.webkit.org/show_bug.cgi?id=38599
2165
2166         * TestResultServer/handlers/dashboardhandler.py:
2167         * TestResultServer/handlers/menu.py:
2168         * TestResultServer/handlers/testfilehandler.py:
2169         * TestResultServer/main.py:
2170         * TestResultServer/model/dashboardfile.py:
2171         * TestResultServer/model/datastorefile.py: Added.
2172         * TestResultServer/model/jsonresults.py: Added.
2173         * TestResultServer/model/jsonresults_unittest.py: Added.
2174         * TestResultServer/model/testfile.py:
2175         * TestResultServer/templates/uploadform.html:
2176
2177 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2178
2179         Reviewed by Kenneth Christiansen.
2180
2181         [Qt] [QtTestBrowser] Remove unneeded QAction class members
2182         https://bugs.webkit.org/show_bug.cgi?id=43518
2183
2184         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
2185         m_flipYAnimated. Also, in initializeView method there are some dead code block
2186         trying to connect them at the wrong time, when they have not been instanciated.
2187
2188         This patch:
2189
2190         - removes the two cited class members in favor of local variables in createChrome method;
2191         - removes the dead code block.
2192
2193         * QtTestBrowser/launcherwindow.cpp:
2194         (LauncherWindow::LauncherWindow):
2195         (LauncherWindow::initializeView):
2196         (LauncherWindow::createChrome):
2197         * QtTestBrowser/launcherwindow.h:
2198
2199 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2200
2201         Reviewed by Simon Hausmann and Kenneth Christiansen.
2202
2203         [Qt] [QtTestBrowser] Clean up static and global menu state controls
2204         https://bugs.webkit.org/show_bug.cgi?id=43448
2205
2206         After LauncherWindow class was refactored out of from main.cpp, all global variables that
2207         were hanging in main.cpp became temporarily public static class members of newly added
2208         LauncherWindow class. This design was not properly handling the initial purpose of the
2209         global variables: newly created launcher windows should inherit the settings of the originating
2210         one.
2211
2212         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
2213         comprises all data needed to handling the goal described above.
2214
2215         * QtTestBrowser/launcherwindow.cpp:
2216         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
2217                                           holding all user settings configured in the menus and command line.
2218                                           It also receices an optional QGraphicsScene points in case we are doing
2219                                           a "Clone Window".
2220         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
2221                                 value.
2222         (LauncherWindow::initializeView): Ditto.
2223         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
2224         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
2225                                       apply the preferences is provided by m_userData.
2226         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
2227         (LauncherWindow::toggleResizesToContents): Ditto.
2228         (LauncherWindow::toggleWebGL): Ditto.
2229         (LauncherWindow::toggleFrameFlattening): Ditto.
2230         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
2231         (LauncherWindow::changeViewportUpdateMode): Ditto.
2232         (LauncherWindow::showFPS): Ditto.
2233         (LauncherWindow::newWindow): Changed to pass the userData.
2234         (LauncherWindow::cloneWindow): Ditto.
2235         * QtTestBrowser/launcherwindow.h:
2236         (WindowOptions::WindowOptions):
2237         * QtTestBrowser/main.cpp:
2238         (requiresGraphicsView):
2239         (LauncherApplication::handleUserOptions):
2240         (main):
2241
2242 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
2243
2244         [wx] Build fix for gcc not importing all symbols from convenience libraries.
2245         Works on 10.6 only for Mac until the build system is reworked. 
2246
2247         * wx/build/settings.py:
2248
2249 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
2250
2251         Reviewed by Simon Hausmann.
2252
2253         [Qt] Change wording in QtTestBrowser
2254         https://bugs.webkit.org/show_bug.cgi?id=43241
2255
2256         * QtTestBrowser/launcherwindow.cpp:
2257         (LauncherWindow::createChrome):
2258
2259 2010-08-04  Aaron Boodman  <aa@chromium.org>
2260
2261         Reviewed by Eric Seidel.
2262
2263         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
2264         https://bugs.webkit.org/show_bug.cgi?id=43460
2265
2266         * Scripts/prepare-ChangeLog:
2267
2268 2010-08-03  MORITA Hajime  <morrita@google.com>
2269
2270         Reviewed by Tony Chang.
2271
2272         [DRT] Assertion failed when drag and move a draggable element.
2273         https://bugs.webkit.org/show_bug.cgi?id=41695
2274
2275         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
2276         But Cocoa doesn't call mouseDragged() until dragging is done.
2277         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
2278         on UIDelegate failed when mouseDragged() is called during dragging.
2279         This change eliminated the mouseDragged() call when dragging begins,
2280         which is implicated by draggingInfo instance.
2281         
2282         * DumpRenderTree/mac/EventSendingController.mm:
2283         (-[EventSendingController mouseMoveToX:Y:]):
2284
2285         Test: fast/events/dragging-mouse-moves.html
2286         
2287 2010-08-02  Steve Block  <steveblock@google.com>
2288
2289         Reviewed by Alexey Proskuryakov.
2290
2291         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
2292         https://bugs.webkit.org/show_bug.cgi?id=40002
2293
2294         The code in LayoutTestController::setGeolocationPermission() was moved to
2295         setGeolocationPermissionCommon() to allow each port to provide its own
2296         implementation of setGeolocationPermission().
2297
2298         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
2299         new permission, so it can call back to WebCore if permission requests are in
2300         progress and are waiting for a response. A minor fix to the Mac
2301         MockGeolocationProvider was also required to make sure that the mock provider
2302         calls back to WebCore when it is first started.
2303
2304         For other ports, LayoutTestController::setGeolocationPermission() is not
2305         implemented.
2306
2307         * DumpRenderTree/LayoutTestController.cpp:
2308         (LayoutTestController::setGeolocationPermissionCommon):
2309         * DumpRenderTree/LayoutTestController.h:
2310         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2311         (LayoutTestController::setGeolocationPermission):
2312         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2313         (LayoutTestController::setGeolocationPermission):
2314         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2315         (-[MockGeolocationProvider registerWebView:]):
2316         * DumpRenderTree/mac/UIDelegate.h:
2317         * DumpRenderTree/mac/UIDelegate.mm:
2318         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2319         (-[UIDelegate setGeolocationPermission:]):
2320         (-[UIDelegate dealloc]):
2321         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2322         (LayoutTestController::setGeolocationPermission):
2323         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2324         (LayoutTestController::setGeolocationPermission):
2325
2326 2010-08-03  Kent Tamura  <tkent@chromium.org>
2327
2328         Reviewed by Dimitri Glazkov.
2329
2330         [DRT/Chromium] Implement --testshell-startup-dialog
2331         https://bugs.webkit.org/show_bug.cgi?id=40616
2332
2333         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2334         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
2335         if it is specfied.
2336         * DumpRenderTree/chromium/TestShell.h:
2337           Declare openStartUpDialog().
2338         * DumpRenderTree/chromium/TestShellGtk.cpp:
2339         (openStartupDialog):
2340         * DumpRenderTree/chromium/TestShellMac.mm:
2341         (openStartupDialog):
2342         * DumpRenderTree/chromium/TestShellWin.cpp:
2343         (openStartupDialog):
2344
2345 2010-08-03  Kent Tamura  <tkent@chromium.org>
2346
2347         Reviewed by Dimitri Glazkov.
2348
2349         [DRT/Chromium] Remove dependency of base/md5.h
2350         https://bugs.webkit.org/show_bug.cgi?id=43403
2351
2352         * DumpRenderTree/chromium/TestShell.cpp:
2353         (TestShell::dumpImage): Use wtf/MD5.h
2354
2355 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2356
2357         Reviewed by David Kilzer.
2358
2359         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2360         https://bugs.webkit.org/show_bug.cgi?id=40627
2361
2362         Part 6 - LayoutTest and Cleanup
2363
2364           Allow tests to delete application caches and set application cache
2365           origin quotas, so they can be tested.
2366
2367         * DumpRenderTree/LayoutTestController.cpp:
2368         (LayoutTestController::LayoutTestController):
2369         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
2370         (clearAllApplicationCachesCallback): should delete all application caches.
2371         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
2372         (LayoutTestController::staticFunctions):
2373         * DumpRenderTree/LayoutTestController.h:
2374         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
2375         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
2376
2377           Mac implementation.
2378
2379         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2380         (LayoutTestController::clearAllApplicationCaches): delete application caches.
2381         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
2382         * DumpRenderTree/mac/UIDelegate.mm:
2383         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
2384         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
2385
2386           Stub implementations for other platforms.
2387
2388         * DumpRenderTree/chromium/LayoutTestController.cpp:
2389         (LayoutTestController::LayoutTestController):
2390         (LayoutTestController::clearAllApplicationCaches):
2391         (LayoutTestController::setApplicationCacheOriginQuota):
2392         * DumpRenderTree/chromium/LayoutTestController.h:
2393         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2394         (LayoutTestController::clearAllApplicationCaches):
2395         (LayoutTestController::setApplicationCacheOriginQuota):
2396         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2397         (LayoutTestController::clearAllApplicationCaches):
2398         (LayoutTestController::setApplicationCacheOriginQuota):
2399         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2400         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2401         (LayoutTestController::clearAllApplicationCaches):
2402         (LayoutTestController::setApplicationCacheOriginQuota):
2403         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2404         (LayoutTestController::clearAllApplicationCaches):
2405         (LayoutTestController::setApplicationCacheOriginQuota):
2406
2407 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2408
2409         Reviewed by David Kilzer.
2410
2411         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2412         https://bugs.webkit.org/show_bug.cgi?id=40627
2413
2414         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
2415
2416           Change old style calls to make use of the managers.
2417
2418         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2419         (LayoutTestController::setDatabaseQuota):
2420         * DumpRenderTree/mac/UIDelegate.mm:
2421         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2422
2423 2010-08-03  Mark Rowe  <mrowe@apple.com>
2424
2425         Add a new Leopard build slave to run the release tests.
2426
2427         * BuildSlaveSupport/build.webkit.org-config/config.json:
2428
2429 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
2430
2431         WebKitTestRunner needs to activate the Mac font ascent hack
2432         https://bugs.webkit.org/show_bug.cgi?id=43404
2433
2434         Reviewed by Darin Adler.
2435
2436         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2437         (WTR::InjectedBundle::initialize):
2438         Call WKBundleActivateMacFontAscentHack().
2439
2440 2010-08-03  Alex Milowski  <alex@milowski.com>
2441
2442         Reviewed by Beth Dakin.
2443
2444         Changed the default for MathML support so that is is enabled by default.
2445
2446         * Scripts/build-webkit:
2447
2448 2010-08-03  Sam Weinig  <sam@webkit.org>
2449
2450         Roll r64566 back in this time with all the overloads in place..
2451
2452         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2453         (WTR::InjectedBundlePage::shouldInsertNode):
2454         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2455         * WebKitTestRunner/StringFunctions.h:
2456         * WebKitTestRunner/TestInvocation.cpp:
2457         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2458         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2459         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2460
2461 2010-08-03  Sam Weinig  <sam@webkit.org>
2462
2463         Rollout r64566. It broke all the WebKit2 tests.
2464
2465         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2466         (WTR::operator<<):
2467         (WTR::InjectedBundlePage::shouldInsertNode):
2468         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2469         * WebKitTestRunner/StringFunctions.h: Removed.
2470         * WebKitTestRunner/TestInvocation.cpp:
2471         (WTR::createWKURL):
2472         (WTR::WKStringToUTF8):
2473         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2474         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2475         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2476
2477 2010-08-03  Sam Weinig  <sam@webkit.org>
2478
2479         Reviewed by Anders Carlsson.
2480
2481         WTR: Move all the utility functions for working with strings to a shared header.
2482         https://bugs.webkit.org/show_bug.cgi?id=43386
2483
2484         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2485         (WTR::InjectedBundlePage::shouldInsertNode):
2486         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2487         * WebKitTestRunner/StringFunctions.h: Added.
2488         * WebKitTestRunner/TestInvocation.cpp:
2489         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2490         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2491         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2492
2493 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
2494
2495         Reviewed by Kenneth Christiansen.
2496
2497         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
2498         https://bugs.webkit.org/show_bug.cgi?id=43168
2499
2500         QGraphicsWebView resizesToContents property has to work together with QWebPage's
2501         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
2502
2503         * QtTestBrowser/launcherwindow.cpp:
2504         (LauncherWindow::applyPrefs):
2505         * QtTestBrowser/webview.cpp:
2506         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
2507                                                       needed when toggle resizesToContents on/off.
2508         (WebViewGraphicsBased::resizeEvent):
2509         * QtTestBrowser/webview.h:
2510         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
2511         (WebViewGraphicsBased::customLayoutSize): Getter helper.
2512
2513 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
2514
2515         Unreviewed. Adding myself as committer.
2516
2517         * Scripts/webkitpy/common/config/committers.py:
2518
2519 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
2520
2521         Reviewed by Yury Semikhatsky.
2522
2523         Chromium DevTools: Get rid of DevTools RPC.
2524
2525         https://bugs.webkit.org/show_bug.cgi?id=43335
2526
2527         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2528         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
2529         (DRTDevToolsAgent::call):
2530         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2531         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
2532         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
2533         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2534         (DRTDevToolsClient::sendMessageToBackend):
2535         (DRTDevToolsClient::call):
2536         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2537
2538 2010-08-02  Kent Tamura  <tkent@chromium.org>
2539
2540         Reviewed by Dimitri Glazkov.
2541
2542         [DRT/Chromium] Remove dependencies to some Chromium headers
2543         https://bugs.webkit.org/show_bug.cgi?id=43396
2544
2545         * DumpRenderTree/chromium/CppVariant.h:
2546          Remove base/basictypes.h because webkit_support.h contains it.
2547         * DumpRenderTree/chromium/EventSender.cpp:
2548         (getCurrentEventTimeSec): Use new wrapper function.
2549         * DumpRenderTree/chromium/TestNavigationController.h:
2550          Remove base/basictypes.h because webkit_support.h contains it.
2551         * DumpRenderTree/chromium/TestShell.cpp:
2552         (dumpHistoryItem): Use new wrapper function.
2553         * DumpRenderTree/chromium/WebViewHost.cpp:
2554         (WebViewHost::cancelledError): Use new wrapper function.
2555         (WebViewHost::didFailResourceLoad): Use new wrapper function.
2556
2557 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2558
2559         Reviewed by Xan Lopez.
2560
2561         [GTK] DRT implement execCommand()
2562         https://bugs.webkit.org/show_bug.cgi?id=35351
2563
2564         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2565         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
2566         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
2567         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
2568
2569 2010-08-02  Sam Weinig  <sam@webkit.org>
2570
2571         Reviewed by Anders Carlsson.
2572
2573         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
2574
2575         * Scripts/old-run-webkit-tests:
2576
2577 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2578
2579         WebKitTestRunner needs to support loading custom fonts (via the
2580         WEBKIT_TESTFONTS environment variable)
2581         https://bugs.webkit.org/show_bug.cgi?id=42782
2582
2583         Reviewed by Adam Roben.
2584
2585         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2586         (WTR::fontsPath):
2587         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
2588         as this directory doesn't appear to be created anymore.
2589         (WTR::activateFonts):
2590         Loop through the fonts, and call AddFontResourceExW() for each.
2591
2592 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2593
2594         Restore the WebKitTestRunner.sln that was removed, and remove the
2595         correct one.
2596
2597         Rubber-stamped by Sam Weinig.
2598
2599         * WebKitTestRunner/WebKitTestRunner.sln: Added.
2600         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
2601
2602 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2603
2604         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
2605
2606         Remove the unused WebKitTestRunner.sln.
2607
2608         Reviewed by Sam Weinig.
2609
2610         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2611         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
2612         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
2613         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
2614         * WebKitTestRunner/win/WebKitTestRunner.sln:
2615
2616 2010-08-02  Sam Weinig  <sam@webkit.org>
2617
2618         Fix the windows build.
2619
2620         * WebKitTestRunner/win/main.cpp:
2621
2622 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
2623
2624         Add a Skipped list on Windows, and have run-webkit-tests respect it.
2625
2626         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
2627         there are zero tests failing
2628         https://bugs.webkit.org/show_bug.cgi?id=43374
2629
2630         Reviewed by Adam Roben.
2631
2632         * Scripts/old-run-webkit-tests:
2633         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
2634         win-wk2. When building the result hierarchy, if the platform is win-wk2,
2635         add it first to the list of platforms.
2636
2637 2010-08-02  Darin Adler  <darin@apple.com>
2638
2639         Reviewed by Sam Weinig.
2640
2641         WebKitTestRunner needs layoutTestController.setCanOpenWindows
2642         https://bugs.webkit.org/show_bug.cgi?id=42321
2643
2644         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
2645         https://bugs.webkit.org/show_bug.cgi?id=42779
2646
2647         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
2648         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
2649
2650         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2651         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
2652         waiting for the first call to didCreatePage.
2653         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
2654         is created. Put other pages into a map.
2655         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
2656         of the main page.
2657         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
2658         the main page.
2659         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
2660         closeOtherPages functions.
2661
2662         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2663         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
2664         the main page affect dumping.
2665         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
2666
2667         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2668         (WTR::LayoutTestController::LayoutTestController): Initialize the new
2669         m_shouldCloseExtraWindows member.
2670         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
2671         (WTR::LayoutTestController::windowCount): Added.
2672
2673         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2674         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
2675         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
2676         m_shouldCloseExtraWindows.
2677
2678         * WebKitTestRunner/TestController.cpp:
2679         (WTR::TestController::shared): Return a pointer to the shared copy, but
2680         don't allocate and leak it. This seemed cleaner than adding an explicit
2681         finalize call to go along with the explicit initialize call.
2682         (WTR::TestController::TestController): Added calls to the initialize and
2683         run function, which are now done automatically.
2684         (WTR::TestController::~TestController): Added, since it's called now.
2685         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
2686         (WTR::createOtherPage): Added. Used to create pages other than the main page.
2687         (WTR::TestController::initialize): Added code to set up createOtherPage.
2688         (WTR::TestController::run): Removed unused return value.
2689         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
2690         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
2691
2692         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2693         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
2694         to avoid releasing the window twice. Another way to handle it would be to
2695         remove the release, but this approach is slightly more robust because it works
2696         even if some other code calls the close method an extra time.
2697
2698         * WebKitTestRunner/mac/main.mm:
2699         (main): Use a stack-allocated TestController object instead of calling
2700         initalize and run on a globally allocated one.
2701
2702 2010-08-02  Tony Chang  <tony@chromium.org>
2703
2704         Reviewed by David Levin.
2705
2706         add myself to the reviewers list
2707         https://bugs.webkit.org/show_bug.cgi?id=43366
2708
2709         * Scripts/webkitpy/common/config/committers.py:
2710
2711 2010-08-02  Anders Carlsson  <andersca@apple.com>
2712
2713         Reviewed by Sam Weinig.
2714
2715         Cache JSNPObjects and fix bugs in the object map
2716         https://bugs.webkit.org/show_bug.cgi?id=43368
2717
2718         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
2719         wrap an NPObject that came from a plug-in that is now destroyed.
2720
2721         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2722         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2723         (PluginTest::Object::getProperty):
2724         (PluginTest::Object::NP_GetProperty):
2725         (PluginTest::Object::npClass):
2726         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
2727         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
2728         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2729         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
2730         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
2731         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2732         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2733         * GNUmakefile.am:
2734
2735 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2736
2737         Reviewed by Xan Lopez.
2738
2739         [Gtk] DOM listeners get wrong keycodes for some keys
2740         https://bugs.webkit.org/show_bug.cgi?id=35170
2741
2742         Add support to all event senders for simulating keypad insert
2743         and print screen keys.
2744
2745         * DumpRenderTree/chromium/EventSender.cpp:
2746         (EventSender::keyDown): Add support for generating keypad insert and print screen.
2747         * DumpRenderTree/gtk/EventSender.cpp:
2748         (keyDownCallback): Ditto.
2749         * DumpRenderTree/mac/EventSendingController.mm:
2750         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
2751         * DumpRenderTree/qt/EventSenderQt.cpp:
2752         (EventSender::keyDown): Ditto.
2753         * DumpRenderTree/win/EventSender.cpp:
2754         (keyDownCallback): Ditto.
2755
2756 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2757
2758         Build fix for building against development versions of GTK+. GTK 2.22
2759         has not yet been released, so these function definitions must be conditionalized
2760         on the development version.
2761
2762         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
2763
2764 2010-08-02  Tony Chang  <tony@chromium.org>
2765
2766         Reviewed by Kent Tamura.
2767
2768         [chromium] use ChromiumDriver on Linux when running webkit tests
2769         https://bugs.webkit.org/show_bug.cgi?id=43273
2770
2771         * Scripts/webkitpy/layout_tests/port/chromium.py:
2772
2773 2010-08-02  Kent Tamura  <tkent@chromium.org>
2774
2775         Reviewed by Dimitri Glazkov.
2776
2777         [DRT/Chromium] Always initialize GTK
2778         https://bugs.webkit.org/show_bug.cgi?id=43327
2779
2780         Call gtk_init() in order to fix plugin test crash.
2781
2782         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2783         (main): Pass argc/argv to platformInit().
2784         * DumpRenderTree/chromium/TestShell.h:
2785         * DumpRenderTree/chromium/TestShellGtk.cpp:
2786         (platformInit): Update parameters, call gtk_init().
2787         * DumpRenderTree/chromium/TestShellMac.mm:
2788         (platformInit): Update parameters.
2789         * DumpRenderTree/chromium/TestShellWin.cpp:
2790         (platformInit): Update parameters.
2791
2792 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
2793
2794         Reviewed by Simon Hausmann.
2795
2796         [Qt] Generate forwarding headers for WebKit2
2797
2798         https://bugs.webkit.org/show_bug.cgi?id=43336
2799
2800         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
2801
2802 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
2803
2804         Reviewed by Kent Tamura.
2805
2806         WebSocket server should start with SO_REUSEADDR
2807         https://bugs.webkit.org/show_bug.cgi?id=43329
2808
2809         Pulls in pywebsocket-0.5.2.
2810         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
2811         http://code.google.com/p/pywebsocket/source/detail?r=273
2812
2813         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
2814
2815 2010-08-01  Kent Tamura  <tkent@chromium.org>
2816
2817         Reviewed by Dimitri Glazkov.
2818
2819         [DRT/Chromium] Remove string_util.h dependency
2820         https://bugs.webkit.org/show_bug.cgi?id=43312
2821
2822         * DumpRenderTree/chromium/LayoutTestController.cpp:
2823         (LayoutTestController::pathToLocalResource):
2824          Use string::find() instead of StartsWithASCII().
2825         (LayoutTestController::cppVariantToInt32):
2826          Use strtol() instead of StringToNumber().
2827
2828 2010-08-01  Sam Weinig  <sam@webkit.org>
2829
2830         Reviewed by Anders Carlsson.
2831
2832         Add ability to reset frame names for WebKitTestRunner
2833         https://bugs.webkit.org/show_bug.cgi?id=43316
2834
2835         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2836         (WTR::InjectedBundle::reset):
2837         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2838         (WTR::InjectedBundlePage::reset):
2839         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2840
2841 2010-08-01  Anders Carlsson  <andersca@apple.com>
2842
2843         Reviewed by Sam Weinig.
2844
2845         Implement NPN_RemoveProperty
2846         https://bugs.webkit.org/show_bug.cgi?id=43315
2847
2848         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2849         Add NPRuntimeRemoveProperty.cpp
2850         
2851         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2852         (PluginTest::NPN_GetStringIdentifier):
2853         (PluginTest::NPN_GetIntIdentifier):
2854         (PluginTest::NPN_RemoveProperty):
2855         Add NPN_ helpers.
2856
2857         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2858         Support more NPClass functions.
2859
2860         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
2861         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
2862         Test for NPN_RemoveProperty.
2863
2864         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
2865         (NPRuntimeRemoveProperty::TestObject::invoke):
2866         Add a testRemoveProperty method.
2867
2868         (NPRuntimeRemoveProperty::NPP_GetValue):
2869         Return the test object.
2870
2871         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2872         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2873         * GNUmakefile.am:
2874         Add NPRuntimeRemoveProperty.cpp
2875
2876 2010-07-30  Anders Carlsson  <andersca@apple.com>
2877
2878         Reviewed by Sam Weinig.
2879
2880         Add an NPObject class template helper to TestNetscapePlugin
2881         https://bugs.webkit.org/show_bug.cgi?id=43288
2882
2883         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2884         Add some template magic to be able to figure out if a class has a member function of a given type.
2885
2886         (PluginTest::Object::create):
2887         Create an object.
2888
2889         (PluginTest::Object::invokeDefault):
2890         Add dummy function, this should never be called.
2891
2892         (PluginTest::Object::Object):
2893         Initialize m_pluginTest to 0.
2894
2895         (PluginTest::Object::~Object):
2896         Add virtual destructor.
2897
2898         (PluginTest::Object::NP_Allocate):
2899         Create a new object.
2900
2901         (PluginTest::Object::NP_Deallocate):
2902         Delete the object.
2903
2904         (PluginTest::Object::NP_InvokeDefault):
2905         Call invokeDefault.
2906
2907         (PluginTest::Object::npClass):
2908         Initialize the NPClass struct.
2909
2910         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
2911         (DocumentOpenInDestroyStream::NPP_DestroyStream):
2912         Move this inline.
2913
2914         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
2915         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
2916         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
2917         Use the PluginTest::Object class template.
2918
2919 2010-07-31  Sam Weinig  <sam@webkit.org>
2920
2921         Reviewed by Dan Bernstein.
2922
2923         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
2924         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
2925         due to SVGElements not having the innerText function.
2926
2927         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2928         (WTR::dumpFrameText):
2929
2930 2010-07-30  Sam Weinig  <sam@webkit.org>
2931
2932         Reviewed by Maciej Stachowiak.
2933
2934         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
2935         Add structured message passing from the injected bundle to UIProcess
2936
2937         * MiniBrowser/mac/AppDelegate.m:
2938         (didRecieveMessageFromInjectedBundle):
2939         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2940         (didClearWindowForFrame):
2941         (didRecieveMessage):
2942         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2943         (WTR::InjectedBundle::done):
2944         (WTR::InjectedBundle::didReceiveMessage):
2945         * WebKitTestRunner/TestController.cpp:
2946         (WTR::TestController::initialize):
2947         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2948         * WebKitTestRunner/TestController.h:
2949         * WebKitTestRunner/TestInvocation.cpp:
2950         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2951         * WebKitTestRunner/TestInvocation.h:
2952         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2953
2954 2010-07-30  Sam Weinig  <sam@webkit.org>
2955
2956         Reviewed by Anders Carlsson.
2957
2958         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
2959         Make WKArrayRef more usable.
2960
2961         Remove now unnecessary const_casts.
2962
2963         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2964         (WTR::dumpDescendantFrameScrollPositions):
2965         (WTR::dumpDescendantFramesText):
2966
2967 2010-07-30  Sam Weinig  <sam@webkit.org>
2968
2969         Reviewed by Anders Carlsson.
2970
2971         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
2972         Add first pass of structured message passing.
2973
2974         Update Minibrowser and WebKitTestRunner to work with the new post message
2975         function.
2976
2977         * MiniBrowser/mac/AppDelegate.m:
2978         (didRecieveMessageFromInjectedBundle):
2979         (-[BrowserAppDelegate init]):
2980         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2981         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2982         (didStartProvisionalLoadForFrame):
2983         (didReceiveServerRedirectForProvisionalLoadForFrame):
2984         (didFailProvisionalLoadWithErrorForFrame):
2985         (didCommitLoadForFrame):
2986         (didFinishLoadForFrame):
2987         (didFailLoadWithErrorForFrame):
2988         (didReceiveTitleForFrame):
2989         (didClearWindowForFrame):
2990         (didCreatePage):
2991         (willDestroyPage):
2992         (didRecieveMessage):
2993         (WKBundleInitialize):
2994         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2995         (WTR::InjectedBundle::_didReceiveMessage):
2996         (WTR::InjectedBundle::didReceiveMessage):
2997         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2998         * WebKitTestRunner/TestInvocation.cpp:
2999         (WTR::TestInvocation::invoke):
3000         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3001
3002 2010-07-30  Anders Carlsson  <andersca@apple.com>
3003
3004         Try to fix the layout test failures.
3005
3006         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3007         (webkit_test_plugin_get_value):
3008
3009 2010-07-29  Anders Carlsson  <andersca@apple.com>
3010
3011         Reviewed by Adam Roben.
3012
3013         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
3014         https://bugs.webkit.org/show_bug.cgi?id=43232
3015
3016         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3017         Add PluginScriptableNPObjectInvokeDefault.cpp.
3018
3019         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3020         Remove invokeDefault callback function.
3021
3022         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3023         (PluginTest::create):
3024         Move this to the top of the file.
3025
3026         (PluginTest::NPP_GetValue):
3027         Add default implementation.
3028
3029         (PluginTest::NPN_CreateObject):
3030         Add NPN_ wrapper.
3031
3032         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3033         (PluginTest::identifier):
3034         Add identifier getter.
3035
3036         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3037         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3038         Add "using namespace std".
3039
3040         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3041         (NPP_GetValue):
3042         Give PluginTest a chance to return a value.
3043
3044         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3045         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3046         * GNUmakefile.am:
3047         Add PluginScriptableNPObjectInvokeDefault.cpp.
3048         
3049         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3050         (webkit_test_plugin_get_value):
3051         Give PluginTest a chance to return a value.
3052
3053 2010-07-30  Steve Block  <steveblock@google.com>
3054
3055         Reviewed by Steve Block.
3056
3057         Add LayoutTestController methods to test DeviceOrientation
3058         https://bugs.webkit.org/show_bug.cgi?id=39589
3059
3060         * DumpRenderTree/LayoutTestController.cpp:
3061         (setMockDeviceOrientationCallback):
3062         (LayoutTestController::staticFunctions):
3063         * DumpRenderTree/LayoutTestController.h:
3064         * DumpRenderTree/chromium/LayoutTestController.cpp:
3065         (LayoutTestController::LayoutTestController):
3066         (LayoutTestController::setMockDeviceOrientation):
3067         * DumpRenderTree/chromium/LayoutTestController.h:
3068         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3069         (LayoutTestController::setMockDeviceOrientation):
3070         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3071         (LayoutTestController::setMockDeviceOrientation):
3072         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3073         (LayoutTestController::setMockDeviceOrientation):
3074         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3075         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3076         (LayoutTestController::setMockDeviceOrientation):
3077         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3078         (LayoutTestController::setMockDeviceOrientation):
3079         * Scripts/build-webkit:
3080
3081 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3082
3083         Reviewed by Kenneth Christiansen.
3084
3085         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
3086         https://bugs.webkit.org/show_bug.cgi?id=43209
3087
3088         When -resizes-to-content was being passed as a command line parameter it was simply
3089         not being set (although the corresponding menu item was marked as ON).
3090         User had to toggle the menu OFF and then ON again for it to take place.
3091
3092         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
3093         the command line, but not resizesToContents. Patch addresses that.
3094
3095         * QtTestBrowser/launcherwindow.cpp:
3096         (LauncherWindow::createChrome):
3097         (LauncherWindow::applyPrefs):
3098         (LauncherWindow::toggleResizesToContents):
3099         * QtTestBrowser/webview.h:
3100         (WebViewGraphicsBased::resizesToContents):
3101
3102 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3103
3104         Rubber-stamped by Simon Fraser.
3105
3106         [Qt] QtTestBrowser: more method grouping and clean ups.
3107
3108         Moving blocks of code around. Basically grouping related methods close to each.
3109
3110         * QtTestBrowser/launcherwindow.cpp:
3111         (LauncherWindow::initializeView):
3112         (LauncherWindow::createChrome):
3113         (LauncherWindow::changeViewportUpdateMode):
3114         (LauncherWindow::showFPS):
3115         (LauncherWindow::newWindow):
3116         (LauncherWindow::cloneWindow):
3117         * QtTestBrowser/launcherwindow.h:
3118
3119 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3120
3121         Reviewed by Tor Arne Vestbø.
3122
3123         [QT][Symbian] QtTestBrowser missing location capabilities
3124         https://bugs.webkit.org/show_bug.cgi?id=43235
3125
3126         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
3127
3128         * QtTestBrowser/QtTestBrowser.pro:
3129
3130 2010-07-29  Anders Carlsson  <andersca@apple.com>
3131
3132         Add PluginTest.cpp
3133
3134         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3135
3136 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
3137
3138         Reviewed by Eric Seidel.
3139
3140         Update download URLs for python irclib package; the old URLs 
3141         pointed at a specific mirror host and not the general sourceforge
3142         URLs.
3143
3144         https://bugs.webkit.org/show_bug.cgi?id=43228
3145
3146         * Scripts/webkitpy/thirdparty/__init__.py:
3147
3148 2010-07-29  Anders Carlsson  <andersca@apple.com>
3149
3150         Fix typo.
3151
3152         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3153
3154 2010-07-29  Anders Carlsson  <andersca@apple.com>
3155
3156         Another attempt at fixing the Qt and GTK+ build.
3157
3158         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3159         (webkit_test_plugin_new_instance):
3160         (webkit_test_plugin_destroy_stream):
3161
3162 2010-07-29  Anders Carlsson  <andersca@apple.com>
3163
3164         Another build fix attempt.
3165
3166         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3167         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3168         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3169         (webkit_test_plugin_new_instance):
3170         * GNUmakefile.am:
3171
3172 2010-07-29  Anders Carlsson  <andersca@apple.com>
3173
3174         Try to fix Windows and Unix builds.
3175
3176         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3177         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3178         (webkit_test_plugin_new_instance):
3179         (webkit_test_plugin_destroy_stream):
3180
3181 2010-07-29  Anders Carlsson  <andersca@apple.com>
3182
3183         Reviewed by Sam Weinig.
3184
3185         Refactor TestNetscapePlugin so tests can be split in separate files
3186         https://bugs.webkit.org/show_bug.cgi?id=43220
3187
3188         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3189         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3190
3191         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3192         (pluginAllocate):
3193         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
3194
3195         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3196         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
3197         (PluginTest::PluginTest):
3198         Initialize m_npp and the test identifier.
3199         
3200         (PluginTest::createTestFunctions):
3201         Return the map from identifiers to createTest functions.
3202
3203         (PluginTest::registerCreateTestFunction):
3204         Insert the identifier and create function pair in the map.
3205
3206         (PluginTest::create):
3207         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
3208
3209         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
3210         (PluginTest::Register::Register):
3211         Helper class template for registering plug-in tests.
3212         
3213         (PluginTest::Register::create):
3214         Create a new test of the given type.
3215
3216         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
3217         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3218         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
3219
3220         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3221         (NPP_New):
3222         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
3223
3224         (NPP_DestroyStream):
3225         Call the plug-in test NPP_DestroyStream member function.
3226
3227         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3228         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3229
3230 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3231
3232         Unreviewed build fix.
3233
3234         Add missing second argument to assert_lint in new style checker tests.
3235
3236         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3237
3238 2010-07-29  Anders Carlsson  <andersca@apple.com>
3239
3240         Reviewed by Adam Roben.
3241
3242         check-webkit-style shouldn't complain about NPAPI functions
3243         https://bugs.webkit.org/show_bug.cgi?id=43211
3244
3245         Allow underscores in functions that start with NPN_, NPP_ or NP_.
3246
3247         * Scripts/webkitpy/style/checkers/cpp.py:
3248         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3249
3250 2010-07-29  Victor Wang  <victorw@chromium.org>
3251
3252         Unreviewed, rolling out r64270.
3253         http://trac.webkit.org/changeset/64270
3254         https://bugs.webkit.org/show_bug.cgi?id=39589
3255
3256         The patch breaks chromium webkit unittest
3257
3258         * DumpRenderTree/LayoutTestController.cpp:
3259         (LayoutTestController::staticFunctions):
3260         * DumpRenderTree/LayoutTestController.h:
3261         * DumpRenderTree/chromium/LayoutTestController.cpp:
3262         (LayoutTestController::LayoutTestController):
3263         * DumpRenderTree/chromium/LayoutTestController.h:
3264         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3265         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3266         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3267         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3268         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3269         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3270         * Scripts/build-webkit:
3271
3272 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3273
3274         Reviewed by Kenneth Christiansen.
3275
3276         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
3277         https://bugs.webkit.org/show_bug.cgi?id=43199
3278
3279         There is no sense in keeping WebPage method definitions in main.cpp once
3280         webpage.cpp already exists.
3281
3282         No behavior change.
3283
3284         * QtTestBrowser/main.cpp:
3285         * QtTestBrowser/webpage.cpp:
3286         (WebPage::createWindow):
3287         (WebPage::createPlugin):
3288
3289 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3290
3291         Reviewed by Kenneth Christiansen.
3292
3293         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
3294         https://bugs.webkit.org/show_bug.cgi?id=43170
3295
3296         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
3297         launcherwindow.{cpp|h}
3298
3299         No behavior change.
3300
3301         Also changed all global static variables (named "gXXX") from main.cpp to
3302         static public variables of the LauncherWindow class.
3303
3304         * QtTestBrowser/QtTestBrowser.pro:
3305         * QtTestBrowser/launcherwindow.cpp: Added.
3306         * QtTestBrowser/launcherwindow.h: Added.
3307         * QtTestBrowser/main.cpp:
3308         (LauncherApplication::handleUserOptions):
3309         (main):
3310
3311 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3312
3313         Reviewed by Xan Lopez.
3314
3315         Build fix for building against GTK+ 3.x. GSEAL requires that we
3316         access internals of the GdkDragContext via methods. For older versions
3317         of GTK+, define those methods.
3318
3319         * DumpRenderTree/gtk/EventSender.cpp:
3320         (gdk_drag_context_get_selected_action): Added.
3321         (gdk_drag_context_get_actions): Added.
3322         (dispatchEvent): Use the two new accessor methods.
3323
3324 2010-07-29  Adam Roben  <aroben@apple.com>
3325
3326         Always say "plugins directory" when referring to a directory
3327         containing one or more plugins
3328
3329         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
3330         directory" when it means "plugins directory"
3331
3332         Reviewed by John Sullivan.
3333
3334         * WebKitTestRunner/TestController.cpp:
3335         (WTR::TestController::initialize): Updated for rename.
3336
3337 2010-07-29  Adam Roben  <aroben@apple.com>
3338
3339         Always say "directory" when referring to a plugin directory
3340
3341         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
3342         when it means "plugin directory"
3343
3344         Reviewed by John Sullivan.
3345
3346         * WebKitTestRunner/TestController.cpp:
3347         (WTR::TestController::initialize): Updated for renames.
3348
3349         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
3350         m_testPluginDirectory.
3351         (WTR::TestController::testPluginDirectory): Renamed from
3352         testPluginPath.
3353
3354         * WebKitTestRunner/mac/TestControllerMac.mm:
3355         (WTR::TestController::initializeTestPluginDirectory):
3356         * WebKitTestRunner/win/TestControllerWin.cpp:
3357         (WTR::TestController::initializeTestPluginDirectory):
3358         Renamed from initializeTestPluginPath and updated for rename.
3359
3360 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3361
3362          Reviewed by Antonio Gomes.
3363
3364          Initialize all members of NPClass struct.
3365          https://bugs.webkit.org/show_bug.cgi?id=43193
3366
3367          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3368
3369 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3370
3371         Reviewed by Antonio Gomes.
3372
3373         Warning fix on platforms where XP_MACOSX is undefined.
3374         https://bugs.webkit.org/show_bug.cgi?id=43192
3375
3376         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3377         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
3378
3379 2010-07-29  Adam Roben  <aroben@apple.com>
3380
3381         Give find-included-framework-headers our standard license
3382
3383         * Scripts/find-included-framework-headers: Used the license from
3384         WebCore/LICENSE-APPLE.
3385
3386 2010-07-29  Adam Roben  <aroben@apple.com>
3387
3388         Speed up find-included-framework-headers
3389
3390         We only do one invocation of find now, no longer pipe to grep, and
3391         replace uniq with sort -u.
3392
3393         Also added a license header.
3394
3395         * Scripts/find-included-framework-headers:
3396
3397 2010-07-29  Steve Block  <steveblock@google.com>
3398
3399         Reviewed by Jeremy Orlow.
3400
3401         Add LayoutTestController methods to test DeviceOrientation
3402         https://bugs.webkit.org/show_bug.cgi?id=39589
3403
3404         * DumpRenderTree/LayoutTestController.cpp:
3405         (setMockDeviceOrientationCallback):
3406         (LayoutTestController::staticFunctions):
3407         * DumpRenderTree/LayoutTestController.h:
3408         * DumpRenderTree/chromium/LayoutTestController.cpp:
3409         * DumpRenderTree/chromium/LayoutTestController.h:
3410         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3411         (LayoutTestController::setMockDeviceOrientation):
3412         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3413         (LayoutTestController::setMockDeviceOrientation):
3414         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3415         (LayoutTestController::setMockDeviceOrientation):
3416         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3417         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3418         (LayoutTestController::setMockDeviceOrientation):
3419         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3420         (LayoutTestController::setMockDeviceOrientation):
3421         * Scripts/build-webkit:
3422
3423 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
3424
3425         Reviewed by Shinichiro Hamaji.
3426
3427         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
3428         check-webkit-style gives false positives in single-line functions.
3429
3430         * Scripts/webkitpy/style/checkers/cpp.py:
3431         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3432
3433 2010-07-28  Darin Adler  <darin@apple.com>
3434
3435         Reviewed by Sam Weinig.
3436
3437         WebKitTestRunner needs to support layoutTestController.execCommand
3438         <https://bugs.webkit.org/show_bug.cgi?id=42538>
3439
3440         WebKitTestRunner needs layoutTestController.isCommandEnabled
3441         <https://bugs.webkit.org/show_bug.cgi?id=42671>
3442
3443         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3444         Added execCommand and isCommandEnabled.
3445         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3446         (WTR::LayoutTestController::execCommand): Added.
3447         (WTR::LayoutTestController::isCommandEnabled): Added.
3448         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3449
3450 2010-07-28  Kent Tamura  <tkent@chromium.org>
3451
3452         Reviewed by Dimitri Glazkov.
3453
3454         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
3455         https://bugs.webkit.org/show_bug.cgi?id=43123
3456
3457         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
3458         which overrides test expectations only for DumpRenderTree, in
3459         order to manage what problems are investigated.
3460         This change will be reverted when we switch to DRT completely.
3461
3462         * Scripts/webkitpy/layout_tests/port/chromium.py:
3463          Add drt_expectations.txt content to the result of
3464          test_expectations_overrides() if --use-drt is specified.
3465
3466 2010-07-28  Brady Eidson  <beidson@apple.com>
3467
3468         Reviewed by Darin Adler.
3469
3470         First pass at visited link support for WK2
3471         https://bugs.webkit.org/show_bug.cgi?id=43157
3472
3473         * MiniBrowser/mac/AppDelegate.m:
3474         (didNavigateWithNavigationData):
3475         (didPerformClientRedirect):
3476         (didPerformServerRedirect):
3477         (didUpdateHistoryTitle):
3478         (populateVisitedLinks): Added for the new version of the HistoryClient.
3479         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
3480         
3481         * MiniBrowser/mac/BrowserWindowController.m:
3482         (-[BrowserWindowController awakeFromNib]):
3483
3484 2010-07-28  Robin Dunn  <robin@alldunn.com>
3485
3486         Reviewed by Kevin Ollivier.
3487
3488         Add DOM bindings support for wx port.
3489
3490         * DumpRenderTree/wscript:
3491         * wx/browser/wscript:
3492         * wx/build/settings.py:
3493
3494 2010-07-28  Tony Chang  <tony@chromium.org>
3495
3496         Reviewed by Kent Tamura.
3497
3498         [chromium] cleanup temp files left by Linux DRT
3499         https://bugs.webkit.org/show_bug.cgi?id=43062
3500
3501         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
3502         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
3503             by crashed DRTs
3504
3505 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
3506
3507         Rubber-stamped by Kenneth Christiansen.
3508
3509         More Developer menu items reordering.
3510
3511         Grouping related menu items together, visually and logically (in the code).
3512
3513         No behavior change.
3514
3515         * QtTestBrowser/main.cpp:
3516         (LauncherWindow::createChrome):
3517
3518 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
3519
3520         Reviewed by Ojan Vafai.
3521
3522         Add FILE_SYSTEM build flag for FileSystem API
3523         https://bugs.webkit.org/show_bug.cgi?id=42915
3524
3525         * Scripts/build-webkit:
3526
3527 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
3528
3529         Reviewed by David Levin.
3530
3531         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
3532         https://bugs.webkit.org/show_bug.cgi?id=43090
3533
3534         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
3535         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
3536
3537 2010-07-27  Kent Tamura  <tkent@chromium.org>
3538
3539         Unreviewed, trivial typo fix.
3540
3541         * Scripts/webkitpy/layout_tests/port/chromium.py:
3542           Fix a wrong method name committed by r64109.
3543
3544 2010-07-27  Sam Weinig  <sam@webkit.org>
3545
3546         Reviewed by Anders Carlsson.
3547
3548         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
3549         Clean up handling of strings at the WebKit2 API layer.
3550
3551         * MiniBrowser/mac/BrowserWindowController.m:
3552         (runJavaScriptAlert):
3553         (runJavaScriptConfirm):
3554         (runJavaScriptPrompt):
3555         (didNavigateWithNavigationData):
3556         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3557         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3558         (_didClearWindowForFrame):
3559
3560 2010-07-27  Ojan Vafai  <ojan@chromium.org>
3561
3562         Reviewed by Eric Seidel.
3563
3564         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
3565         https://bugs.webkit.org/show_bug.cgi?id=42984
3566
3567         squash and no_squash have been intentionally erroring for a couple weeks now.
3568         But post-commits was just broken. Just remove squash/no_squash.
3569
3570         * Scripts/webkitpy/tool/steps/abstractstep.py:
3571         * Scripts/webkitpy/tool/steps/options.py:
3572
3573 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
3574
3575         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
3576
3577         * wx/build/settings.py:
3578
3579 2010-07-27  Adam Roben  <aroben@apple.com>
3580
3581         Mac build fix
3582
3583         * MiniBrowser/mac/BrowserWindowController.m:
3584         (processDidExit):
3585         (-[BrowserWindowController awakeFromNib]):
3586         Added processDidExit support.
3587
3588 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
3589
3590         Rubber-stamped by Simon Hausmann.
3591
3592         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
3593
3594         Move some less useful menu items on Developers menu from the top to the bottom, so
3595         QGraphicsView menu goes to the top, and becomes more quickly accessible.
3596
3597         * QtTestBrowser/main.cpp:
3598         (LauncherWindow::createChrome):
3599
3600 2010-07-26  Adam Roben  <aroben@apple.com>
3601
3602         Fix the path to InjectedBundle.dll in Debug_Internal builds
3603
3604         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
3605         InjectedBundle.dll in the Debug_Internal configuration
3606
3607         Reviewed by Anders Carlsson.
3608
3609         * WebKitTestRunner/win/TestControllerWin.cpp:
3610         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
3611         suffix only in Debug_All builds.
3612
3613 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3614
3615         Reviewed by Darin Adler.
3616
3617         https://bugs.webkit.org/show_bug.cgi?id=42947
3618         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
3619         error. Without which dumpRenderTree crashes.
3620
3621         * Scripts/old-run-webkit-tests:
3622
3623 2010-07-27  Kent Tamura  <tkent@chromium.org>
3624
3625         Reviewed by Dimitri Glazkov.
3626
3627         https://bugs.webkit.org/show_bug.cgi?id=42956
3628         [DRT/Chromium] Fix "out of sync" assertion error
3629
3630         Fix an assertion error on Windows like the following:
3631         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
3632         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3633         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3634
3635         * Scripts/webkitpy/layout_tests/port/chromium.py:
3636         If the url matches with "file:///[a-z]:", does case-ignore comparison.
3637         GURL capitalize the driver letter of a file: URL.
3638
3639 2010-07-26  Darin Adler  <darin@apple.com>
3640
3641         Reviewed by Sam Weinig.
3642
3643         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
3644         https://bugs.webkit.org/show_bug.cgi?id=42537
3645
3646         WebKitTestRunner needs layoutTestController.markerTextForListItem
3647         https://bugs.webkit.org/show_bug.cgi?id=42549
3648
3649         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3650         Fixed _paramterExpression typo. Improved support for string type as a
3651         return value, so we don't try to include DOMString.h and we can convert
3652         the string to a JSValue by calling JSValueMakeStringOrNull.
3653
3654         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
3655         Added JSValueMakeStringOrNull, used by the code generator.
3656
3657         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3658         Added counterValueForElementById and markerTextForListItem.