[wx] Build fix, do not build WebCore as a convenience library as this leads to
[WebKit.git] / WebKitTools / ChangeLog
1 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
2
3         [wx] Build fix, do not build WebCore as a convenience library as this leads to
4         errors in the Win build w/export symbols and causes problems with DOM bindings
5         debugging in gdb.
6
7         * DumpRenderTree/wscript:
8         * Scripts/build-webkit:
9         * wx/browser/wscript:
10         * wx/build/settings.py:
11         * wx/build/waf_extensions.py:
12
13 2010-08-16  Dan Bernstein  <mitz@apple.com>
14
15         Build fix.
16
17         * WebKitTestRunner/TestController.cpp:
18         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
19         (WTR::TestController::initialize): Ditto.
20
21 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
22
23         Reviewed by Kenneth Rohde Christiansen.
24
25         Handle content size change in WebKit2
26         Re-landing after fix.
27
28         https://bugs.webkit.org/show_bug.cgi?id=43198
29
30         * MiniBrowser/mac/BrowserWindowController.m:
31         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
32         * MiniBrowser/win/BrowserView.cpp:
33         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
34
35 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
36
37         Unreviewed, rolling out r65419.
38         http://trac.webkit.org/changeset/65419
39         https://bugs.webkit.org/show_bug.cgi?id=44053
40
41         Broke the Windows build (Requested by bbandix on #webkit).
42
43         * MiniBrowser/mac/BrowserWindowController.m:
44         (-[BrowserWindowController awakeFromNib]):
45         * MiniBrowser/win/BrowserView.cpp:
46         (BrowserView::create):
47
48 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
49
50         Reviewed by Kenneth Rohde Christiansen.
51
52         Handle content size change in WebKit2
53
54         https://bugs.webkit.org/show_bug.cgi?id=43198
55
56         * MiniBrowser/mac/BrowserWindowController.m:
57         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
58         * MiniBrowser/win/BrowserView.cpp:
59         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
60
61 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
62
63         Add my new email address to committers.py.
64
65         * Scripts/webkitpy/common/config/committers.py:
66
67 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
68
69         Add my old e-mail addresses to committers.py.
70
71         * Scripts/webkitpy/common/config/committers.py:
72
73 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
74
75         WebEditorClient::didBeginEditing is never called in WebKit2
76         https://bugs.webkit.org/show_bug.cgi?id=42939
77
78         Reviewed by Sam Weinig.
79
80         * WebKitTestRunner/PlatformWebView.h:
81         Declare focus().
82
83         * WebKitTestRunner/TestController.cpp:
84         (WTR::TestController::resetStateToConsistentValues):
85         Focus the PlatformWebView.
86
87         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
88         (WTR::PlatformWebView::focus):
89         Stubbed.
90
91         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
92         (WTR::PlatformWebView::focus):
93         Focus the view.
94
95 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
96
97         run-webkit-tests should not strip editing callbacks when using
98         WebKitTestRunner on Windows
99         https://bugs.webkit.org/show_bug.cgi?id=44000
100
101         Reviewed by Mark Rowe.
102
103         * Scripts/old-run-webkit-tests:
104         Leave $stripEditingCallbacks undefined until we look for command-line
105         arguments. If using WebKit2, set it to 0 if not explicity set on the
106         command line. Later, set it to isCygwin() to match old behavior if it is
107         not yet defined.
108
109 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
110
111         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
112
113         * wx/build/settings.py:
114
115 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
116
117         Reviewed by Kenneth Rohde Christiansen.
118
119         [GTK] autogen.sh not executed if build-webkit options change
120         https://bugs.webkit.org/show_bug.cgi?id=42266
121
122         Rerun autogen.sh in situations where the arguments to build-webkit have
123         changed since the previous build. This will fix some issues on the bots
124         where the build does not notice changes to default build-webkit arguments.
125
126         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
127
128 2010-08-14  Eric Seidel  <eric@webkit.org>
129
130         Unreviewed.  Another fix to support python 2.3.
131
132         Add support for MathML entities
133         https://bugs.webkit.org/show_bug.cgi?id=43949
134
135         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
136          - It looks like our simplejson is version 1.7.3 which
137            should be python 2.3 compatible.  But someone modified
138            our copy slightly from the original source.
139            I've removed the relative import in hopes this fixes
140            the problem.
141
142 2010-08-13  Eric Seidel  <eric@webkit.org>
143
144         Unreviewed.  Build fix only.
145
146         Add support for MathML entities
147         https://bugs.webkit.org/show_bug.cgi?id=43949
148
149         * Scripts/create-html-entity-table:
150          - Hack sys.path to avoid executing 2.5 dependent python
151            on systems (like chromium-win and Tiger) which do not have 2.5 python.
152
153 2010-08-13  Adam Barth  <abarth@webkit.org>
154
155         Reviewed by Eric Seidel.
156
157         Rename some concepts in HTML entity search to be more self-documenting
158         https://bugs.webkit.org/show_bug.cgi?id=44004
159
160         Reflect name change in generator script.
161
162         * Scripts/create-html-entity-table:
163
164 2010-08-12  Adam Barth  <abarth@webkit.org>
165
166         Reviewed by Eric Seidel.
167
168         Add support for MathML entities
169         https://bugs.webkit.org/show_bug.cgi?id=43949
170
171         A script for generating the C++ state data structure describing all the
172         entities from a JSON description.
173
174         * Scripts/create-html-entity-table: Added.
175
176 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
177
178         Reviewed by Eric Seidel.
179
180         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
181         check for exceptions on all threads, not just the first thread.
182         
183         This change also changes the logging behavior for wedged threads
184         to only dump the stacks of threads that are actually wedged.
185
186         Refactor the thread classes in the dump_render_tree_thread module
187         to make the contract between TestRunner and TestShellThread clearer.
188
189         Added a bunch of unit tests.
190         https://bugs.webkit.org/show_bug.cgi?id=38561
191
192         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
193         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
194         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
195
196 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
197
198         Reviewed by Shinichiro Hamaji.
199
200         Add test_expectations.txt syntax checker to check-webkit-style.
201         https://bugs.webkit.org/show_bug.cgi?id=43899
202
203         Just utilizing layout_tests/layout_package/test_expectations.py for checking
204         the syntax of test_expectations.txt.
205         This change also moves tab checking class from style/checkers/text.py to
206         style/checkers/common.py for sharing code.
207
208         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
209         * Scripts/webkitpy/style/checker.py:
210         * Scripts/webkitpy/style/checkers/common.py:
211         * Scripts/webkitpy/style/checkers/common_unittest.py:
212         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
213         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
214         * Scripts/webkitpy/style/checkers/text.py:
215         * Scripts/webkitpy/style_references.py:
216
217 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
218
219         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
220         https://bugs.webkit.org/show_bug.cgi?id=43945
221
222         Reviewed by Sam Weinig.
223
224         * WebKitTestRunner/TestInvocation.cpp:
225         (WTR::sizeWebViewForCurrentTest):
226         Allow for a Windows-style path.
227
228         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
229         (WTR::PlatformWebView::resizeTo):
230         Call SetWindowPos to resize the view window.
231
232 2010-08-12  David Levin  <levin@chromium.org>
233
234         Build break fix.
235
236         * WebKitTestRunner/TestController.cpp:
237         (WTR::TestController::resetStateToConsistentValues): Removed usage
238         of a variable that doesn't exist in the class.
239
240 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
241
242         WebKitTestRunner needs to run tests without using native controls
243         https://bugs.webkit.org/show_bug.cgi?id=43772
244
245         Reviewed by Sam Weinig.
246
247         * WebKitTestRunner/TestController.cpp:
248         (WTR::TestController::initialize):
249         Call platformInitializeContext().
250
251         * WebKitTestRunner/TestController.h:
252         Declare platformInitializeContext().
253
254         * WebKitTestRunner/mac/TestControllerMac.mm:
255         (WTR::TestController::platformInitializeContext):
256         Stubbed.
257
258         * WebKitTestRunner/win/TestControllerWin.cpp:
259         (WTR::TestController::platformInitializeContext):
260         Call WKContextSetShouldPaintNativeControls() to disable native control
261         drawing.
262
263 2010-08-12  Sam Weinig  <sam@webkit.org>
264
265         Reviewed by Alexey Proskuryakov.
266
267         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
268         https://bugs.webkit.org/show_bug.cgi?id=43653
269
270         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
271         (WTR::InjectedBundle::InjectedBundle):
272         (WTR::InjectedBundle::didReceiveMessage):
273         (WTR::InjectedBundle::beginTesting):
274         (WTR::InjectedBundle::done):
275         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
276         (WTR::InjectedBundle::isTestRunning):
277         (WTR::InjectedBundle::):
278         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
279         (WTR::InjectedBundlePage::stopLoading):
280         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
281         (WTR::InjectedBundlePage::dump):
282         (WTR::InjectedBundlePage::didFinishLoadForFrame):
283         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
284         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
285         (WTR::InjectedBundlePage::didClearWindowForFrame):
286         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
287         (WTR::InjectedBundlePage::willAddMessageToConsole):
288         (WTR::InjectedBundlePage::willSetStatusbarText):
289         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
290         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
291         (WTR::InjectedBundlePage::shouldBeginEditing):
292         (WTR::InjectedBundlePage::shouldEndEditing):
293         (WTR::InjectedBundlePage::shouldInsertNode):
294         (WTR::InjectedBundlePage::shouldInsertText):
295         (WTR::InjectedBundlePage::shouldDeleteRange):
296         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
297         (WTR::InjectedBundlePage::shouldApplyStyle):
298         (WTR::InjectedBundlePage::didBeginEditing):
299         (WTR::InjectedBundlePage::didEndEditing):
300         (WTR::InjectedBundlePage::didChange):
301         (WTR::InjectedBundlePage::didChangeSelection):
302         Don't do any work if we are not currently running a test.
303
304         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
305         * WebKitTestRunner/StringFunctions.h:
306         (WTR::toCF):
307         Add conversion function for WKURLRef -> CFURLRef
308
309         * WebKitTestRunner/TestController.cpp:
310         (WTR::TestController::TestController):
311         (WTR::TestController::initialize):
312         (WTR::TestController::resetStateToConsistentValues):
313         (WTR::TestController::runTest):
314         (WTR::TestController::didFinishLoadForFrame):
315         * WebKitTestRunner/TestController.h:
316         (WTR::TestController::):
317         * WebKitTestRunner/TestInvocation.cpp:
318         (WTR::TestInvocation::invoke):
319         * WebKitTestRunner/TestInvocation.h:
320         Move resetting code to TestController.
321
322         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
323         * WebKitTestRunner/mac/TestControllerMac.mm:
324         (WTR::TestController::runUntil):
325         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
326         * WebKitTestRunner/win/TestControllerWin.cpp:
327         (WTR::TestController::runUntil):
328         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
329         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
330         Move runUntil to TestController.
331
332 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
333
334         Unreviewed.
335
336         Adding myself to the committers list.
337
338         * Scripts/webkitpy/common/config/committers.py:
339
340 2010-08-12  Hayato Ito  <hayato@chromium.org>
341
342         Reviewed by Tony Chang.
343
344         Merge pretty printers for gdb.
345         https://bugs.webkit.org/show_bug.cgi?id=43850
346
347         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
348         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
349         webcore.py is left for backward compatibility.
350
351         * gdb/webcore.py:
352         * gdb/webkit.py: Added.
353         * gdb/wtf.py: Removed.
354
355 2010-08-11  Tony Chang  <tony@chromium.org>
356
357         Reviewed by David Levin.
358
359         [chromium] add google-chrome layout test result directories
360         https://bugs.webkit.org/show_bug.cgi?id=43889
361
362         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
363         * Scripts/webkitpy/layout_tests/port/factory.py:
364         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
365         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
366
367 2010-08-11  Kent Tamura  <tkent@chromium.org>
368
369         Reviewed by Dimitri Glazkov.
370
371         [DRT/Chromium] Disable accelerated compositing
372         https://bugs.webkit.org/show_bug.cgi?id=43894
373
374         Disable accelerated compositing because DRT is not ready for
375         it. This change fixes hundreds of test crashes on Windows and
376         Linux.
377
378         * DumpRenderTree/chromium/TestShell.cpp:
379         (TestShell::resetWebSettings):
380
381 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
382
383         Unreviewed. Adding my Collabora personality to the list.
384
385         * Scripts/webkitpy/common/config/committers.py:
386
387 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
388
389         Adding myself as a reviewer.
390
391         * Scripts/webkitpy/common/config/committers.py:
392
393 2010-08-11  Daniel Bates  <dbates@rim.com>
394
395         Reviewed by Darin Adler.
396
397         Perl warnings when running commit-log-editor
398         https://bugs.webkit.org/show_bug.cgi?id=43856
399
400         Fixes Perl warnings introduced by the patch for Bug #40548.
401
402         Perl doesn't have symbolic names for True/False. Instead, we
403         should use boolean values. Moreover, the variable installedEditorApplication
404         is not be used and should be renamed builtEditorApplication so that it
405         uses the existing machinery to set the commit log editor application.
406
407         * Scripts/commit-log-editor:
408
409 2010-08-11  Adam Barth  <abarth@webkit.org>
410
411         Reviewed by Eric Seidel.
412
413         Trying waiting for httpd lock in the EWS
414         https://bugs.webkit.org/show_bug.cgi?id=43833
415
416         If this works, we can probably run the tests on the mac-ews, which
417         would be very exciting.  :)
418
419         * Scripts/webkitpy/tool/steps/runtests.py:
420
421 2010-08-11  Marcus Bulach  <bulach@chromium.org>
422
423         Reviewed by Eric Seidel.
424
425         Check in a script to list redundant test outputs.
426         https://bugs.webkit.org/show_bug.cgi?id=37630
427
428         If e.g. platform/mac-leopard is missing an expected test output, we
429         fall back on platform/mac.  This means it's possible to grow redundant
430         test outputs, where we have the same expected data in both a platform
431         directory and another platform it falls back on.
432         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
433
434         * Scripts/deduplicate-tests: Added.
435         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
436         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
437
438 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
439
440         Reviewed by Ariya Hidayat.
441
442         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
443         https://bugs.webkit.org/show_bug.cgi?id=43853
444
445         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
446         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
447         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
448         to slots at all.
449
450         * QtTestBrowser/launcherwindow.cpp:
451         (LauncherWindow::createChrome):
452         (LauncherWindow::animatedFlip):
453         (LauncherWindow::animatedYFlip):
454         * QtTestBrowser/launcherwindow.h:
455
456 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
457
458         Reviewed by Simon Hausmann.
459
460         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
461         https://bugs.webkit.org/show_bug.cgi?id=43851
462
463         All window options data (including the bool holding if the view is either QWebView or
464         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
465         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
466         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
467         getting broken.
468
469         Patch addresses this issue.
470
471         * QtTestBrowser/launcherwindow.cpp:
472         (LauncherWindow::createChrome):
473         (LauncherWindow::toggleWebView):
474         (LauncherWindow::toggleAcceleratedCompositing):
475
476 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
477
478         Reviewed by Ariya Hidayat.
479
480         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
481         https://bugs.webkit.org/show_bug.cgi?id=43831
482
483         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
484
485         * QtTestBrowser/webview.cpp:
486         (WebViewGraphicsBased::WebViewGraphicsBased):
487         (WebViewGraphicsBased::animatedYFlip):
488
489 2010-08-11  Darin Adler  <darin@apple.com>
490
491         Reviewed by John Sullivan.
492
493         Improved editor options for prepare-ChangeLog and commit-log-editor
494         https://bugs.webkit.org/show_bug.cgi?id=40548
495
496         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
497         values like "xed --launch --wait" work properly.
498
499         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
500         use a command line tool with the $openChangeLogs feature.
501
502 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
503
504         Reviewed by Pavel Feldman.
505
506         Web Inspector: remove InjectDispatch.js
507         https://bugs.webkit.org/show_bug.cgi?id=43835
508
509         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
510         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
511
512 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
513
514         Reviewed by Eric Seidel.
515
516         webkit-patch should refuse to run under Win32 Python
517         https://bugs.webkit.org/show_bug.cgi?id=40962
518
519         Given that there are lots of places in webkit-patch's code that
520         assume unix-style filenames (forward slashes), webkit-patch fails
521         with weird file-not-found errors when run under a native windows
522         Python. It would be nice if we just trapped this and errored out
523         at the beginning, rather than producing unpredictable errors.
524
525         * Scripts/webkit-patch:
526
527 2010-08-10  Kent Tamura  <tkent@chromium.org>
528
529         Unreviewed, build fix.
530         
531         Chromium build fix for r65107.
532
533         * DumpRenderTree/chromium/LayoutTestController.cpp:
534         (LayoutTestController::suspendAnimations):
535         (LayoutTestController::resumeAnimations):
536
537 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
538
539         Reviewed by Xan Lopez.
540
541         [GTK] http/tests/media/video-cookie.html fails
542         https://bugs.webkit.org/show_bug.cgi?id=42240
543
544         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
545         (LayoutTestController::setAlwaysAcceptCookies): create the
546         SoupCookieJar if it does not exist. Otherwise the accept policy
547         won't be set.
548
549 2010-08-10  Chris Marrin  <cmarrin@apple.com>
550
551         Reviewed by Oliver Hunt.
552
553         Add suspendAnimations/resumeAnimation API to DRT
554         https://bugs.webkit.org/show_bug.cgi?id=43733
555         
556         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
557         Calls functions with the same names on AnimationController for the 
558         mainFrame.
559
560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
561         * DumpRenderTree/LayoutTestController.cpp:
562         (suspendAnimationsCallback):
563         (resumeAnimationsCallback):
564         (LayoutTestController::staticFunctions):
565         * DumpRenderTree/LayoutTestController.h:
566         * DumpRenderTree/chromium/LayoutTestController.cpp:
567         (LayoutTestController::LayoutTestController):
568         (LayoutTestController::suspendAnimations):
569         (LayoutTestController::resumeAnimations):
570         * DumpRenderTree/chromium/LayoutTestController.h:
571         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
572         (LayoutTestController::suspendAnimations):
573         (LayoutTestController::resumeAnimations):
574         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
575         (LayoutTestController::suspendAnimations):
576         (LayoutTestController::resumeAnimations):
577         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
578         (LayoutTestController::suspendAnimations):
579         (LayoutTestController::resumeAnimations):
580         * DumpRenderTree/qt/LayoutTestControllerQt.h:
581         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
582         (LayoutTestController::suspendAnimations):
583         (LayoutTestController::resumeAnimations):
584         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
585         (LayoutTestController::suspendAnimations):
586         (LayoutTestController::resumeAnimations):
587
588 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
589
590         Reviewed by Ojan Vafai.
591
592         [Chromium/DRT] Enable saving layout test results.
593         https://bugs.webkit.org/show_bug.cgi?id=43796
594
595         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
596             parameters to the new-run-webkit-tests, including the name
597             of the test results server.
598
599 2010-08-10  Jian Li  <jianli@chromium.org>
600
601         More chromium build fix.
602
603         * DumpRenderTree/chromium/MockSpellCheck.cpp:
604         (MockSpellCheck::spellCheckWord):
605         (MockSpellCheck::initializeIfNeeded):
606         * DumpRenderTree/chromium/NotificationPresenter.cpp:
607         (NotificationPresenter::grantPermission):
608         (NotificationPresenter::show):
609         (NotificationPresenter::checkPermission):
610
611 2010-08-10  Jian Li  <jianli@chromium.org>
612
613         Chromium build fix.
614
615         * DumpRenderTree/chromium/MockSpellCheck.cpp:
616         * DumpRenderTree/chromium/NotificationPresenter.cpp:
617
618 2010-08-10  Victor Wang  <victorw@chromium.org>
619
620         Reviewed by Ojan Vafai.
621
622         Update test results server merge logic so the aggregated
623         results and times are updated for tests that are
624         in aggragated json but not in incremental json.
625
626         Also update unittest to test this case.
627
628         https://bugs.webkit.org/show_bug.cgi?id=43769
629
630         * TestResultServer/model/jsonresults.py:
631         * TestResultServer/model/jsonresults_unittest.py:
632
633 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
634
635         Reviewed by Ariya Hidayat.
636
637         [Qt] QtTestBrowser: proper set scene rect
638
639         When resizesToContents is ON scene's rect is set to the boundary of
640         the mainFrame. However, navigating to other web page should keep resizing
641         scene's rect according to the new document loaded. Patch addresses this issue.
642
643         Now resizesToContents and scrolling properly work on QtTestBrowser.
644
645         * QtTestBrowser/webview.cpp:
646         (WebViewGraphicsBased::setPage):
647         (WebViewGraphicsBased::contentsSizeChanged):
648         (WebViewGraphicsBased::setResizesToContents):
649         (WebViewGraphicsBased::resizeEvent):
650         * QtTestBrowser/webview.h:
651
652 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
653
654         Reviewed by Ariya Hidayat.
655
656         [Qt] QtTestBrowser: Clean up LauncherWindow code.
657
658         * QtTestBrowser/launcherwindow.cpp:
659         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
660         (LauncherWindow::init): Fixed comments.
661         (LauncherWindow::applyPrefs): Move the method around.
662         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
663
664 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
665
666         Reviewed by Ariya Hidayat.
667
668         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
669
670         It gets control+0 the same visual effect as control++ or control-.
671
672         * QtTestBrowser/launcherwindow.cpp:
673         (LauncherWindow::toggleZoomTextOnly):
674
675 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
676
677         Reviewed by Ariya Hidayat.
678
679         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
680
681         Not all instances of LauncherWindow need its own m_zoomLevel.
682
683         * QtTestBrowser/launcherwindow.cpp:
684         * QtTestBrowser/launcherwindow.h:
685
686 2010-08-09  Sam Weinig  <sam@webkit.org>
687
688         Reviewed by Geoffrey Garen.
689
690         Add zoom support for injected bundle
691         https://bugs.webkit.org/show_bug.cgi?id=43759
692
693         Use zoom factor SPI to implement zoom related eventSender functions.
694
695         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
696         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
697         (WTR::EventSendingController::textZoomIn):
698         (WTR::EventSendingController::textZoomOut):
699         (WTR::EventSendingController::zoomPageIn):
700         (WTR::EventSendingController::zoomPageOut):
701         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
702         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
703         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
704
705 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
706
707         Speculative chromium build fix III.
708
709         * DumpRenderTree/chromium/MockSpellCheck.h:
710         * DumpRenderTree/chromium/NotificationPresenter.h:
711         * DumpRenderTree/chromium/WebViewHost.h:
712         (WebViewHost::addClearHeader):
713         (WebViewHost::clearHeaders):
714
715 2010-08-09  Ojan Vafai  <ojan@chromium.org>
716
717         Reviewed by Tony Chang.
718
719         increase the number of test results that we save
720         https://bugs.webkit.org/show_bug.cgi?id=43763
721
722         Now that we do incremental uploads, we can increase the number of
723         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
724
725         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
726
727 2010-08-09  Evan Martin  <evan@chromium.org>
728
729         Reviewed by Tony Chang.
730
731         [chromium] DRT error print statement incorrectly tries to print a FILE*
732         https://bugs.webkit.org/show_bug.cgi?id=43747
733
734         * DumpRenderTree/chromium/ImageDiff.cpp:
735         (writeFile): pass the correct pointer.
736
737 2010-08-09  Victor Wang  <victorw@chromium.org>
738
739         Reviewed by Ojan Vafai.
740
741         Upload incremental test results json to server by default.
742
743         https://bugs.webkit.org/show_bug.cgi?id=43743
744
745         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
746
747 2010-08-09  Eric Seidel  <eric@webkit.org>
748
749         Reviewed by Adam Barth.
750
751         EWS bots wait 2 minutes between patches
752         https://bugs.webkit.org/show_bug.cgi?id=43731
753
754         * Scripts/webkitpy/tool/bot/queueengine.py:
755          - Don't sleep after failures.  This was a hold-over from
756            an earlier design.
757         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
758          - EWS bots were not properly reporting true/false from process_work_item.
759            They were always returning None, thus false, thus always logging
760            as a failure and sleeping 2 minutes after each patch.
761
762 2010-08-09  Sam Weinig  <sam@webkit.org>
763
764         Reviewed by Anders Carlsson.
765
766         Stub out EventSender for WebKitTestRunner
767         https://bugs.webkit.org/show_bug.cgi?id=43703
768
769         * WebKitTestRunner/DerivedSources.make:
770         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
771         Add ability to pass javascript arguments to the wrapped object.
772
773         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
774         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
775         (WTR::EventSendingController::create):
776         (WTR::EventSendingController::EventSendingController):
777         (WTR::EventSendingController::~EventSendingController):
778         (WTR::EventSendingController::wrapperClass):
779         (WTR::setExceptionForString):
780         (WTR::EventSendingController::mouseDown):
781         (WTR::EventSendingController::mouseUp):
782         (WTR::EventSendingController::mouseMoveTo):
783         (WTR::EventSendingController::keyDown):
784         (WTR::EventSendingController::contextClick):
785         (WTR::EventSendingController::leapForward):
786         (WTR::EventSendingController::textZoomIn):
787         (WTR::EventSendingController::textZoomOut):
788         (WTR::EventSendingController::zoomPageIn):
789         (WTR::EventSendingController::zoomPageOut):
790         (WTR::EventSendingController::makeWindowObject):
791         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
792         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
793         (WTR::InjectedBundle::reset):
794         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
795         (WTR::InjectedBundle::eventSendingController):
796         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
797         (WTR::InjectedBundlePage::didClearWindowForFrame):
798         Add stubbed out EventSenderController.
799
800         * WebKitTestRunner/InjectedBundle/GCController.h:
801         Remove incorrect comment.
802
803         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
804         * WebKitTestRunner/win/InjectedBundle.vcproj:
805         Add new files.
806
807 2010-08-08  Kent Tamura  <tkent@chromium.org>
808
809         Unreviewed, trivial fix.
810
811         Fix "WindowsError: [Error 32] The process cannot access the file
812         because it is being used by another process" introduced by r64959.
813
814         * BuildSlaveSupport/test-result-archive:
815
816 2010-08-08  Kent Tamura  <tkent@chromium.org>
817
818         Reviewed by Tony Chang.
819
820         Chromium buildbot: Avoid "zip" command dependency
821         https://bugs.webkit.org/show_bug.cgi?id=43470
822
823         * BuildSlaveSupport/test-result-archive:
824          For Chromium port, creates a zip archive with zipfile package of Python
825          instead of external "zip" command. We'd like to avoid additional
826          command installation.
827
828 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
829
830         WebKitTestRunner should add the QuickTime dir to the PATH environment
831         variable
832         https://bugs.webkit.org/show_bug.cgi?id=43686
833
834         Reviewed by Dan Bernstein.
835
836         * WebKitTestRunner/win/TestControllerWin.cpp:
837         (WTR::addQTDirToPATH):
838         Copied from DRT.
839         (WTR::TestController::platformInitialize):
840         Call addQTDirToPath().
841         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
842         Link to shlwapi.lib for SHGetValue.
843
844 2010-08-07  Sam Weinig  <sam@webkit.org>
845
846         Reviewed by Maciej Stachowiak.
847
848         WebKitTestRunner needs layoutTestController.dumpTitleChanges
849         <rdar://problem/8213861>
850         https://bugs.webkit.org/show_bug.cgi?id=42683
851
852         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
853         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
854         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
855         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
856         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
857         (WTR::LayoutTestController::LayoutTestController):
858         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
859         (WTR::LayoutTestController::dumpTitleChanges):
860         (WTR::LayoutTestController::shouldDumpTitleChanges):
861
862 2010-08-07  Sam Weinig  <sam@webkit.org>
863
864         Reviewed by Anders Carlsson.
865
866         WebKitTestRunner needs to print onunload handler information
867         <rdar://problem/8213831>
868         https://bugs.webkit.org/show_bug.cgi?id=42703
869
870         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
871         (WTR::operator<<):
872         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
873
874 2010-08-07  Sam Weinig  <sam@webkit.org>
875
876         Reviewed by Anders Carlsson.
877
878         Add additional loader client functions need to complete WebKitTestRunner
879         https://bugs.webkit.org/show_bug.cgi?id=43684
880
881         Remove unnecessary and jarring underscores as well.
882
883         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
884         (didClearWindowObjectForFrame):
885         (didCreatePage):
886         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
887         (WTR::InjectedBundlePage::InjectedBundlePage):
888         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
889         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
890         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
891         (WTR::InjectedBundlePage::didCommitLoadForFrame):
892         (WTR::InjectedBundlePage::didFinishLoadForFrame):
893         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
894         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
895         (WTR::InjectedBundlePage::didClearWindowForFrame):
896         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
897         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
898         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
899         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
900         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
901         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
902         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
903         (WTR::InjectedBundlePage::willAddMessageToConsole):
904         (WTR::InjectedBundlePage::willSetStatusbarText):
905         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
906         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
907         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
908         (WTR::InjectedBundlePage::shouldBeginEditing):
909         (WTR::InjectedBundlePage::shouldEndEditing):
910         (WTR::InjectedBundlePage::shouldInsertNode):
911         (WTR::InjectedBundlePage::shouldInsertText):
912         (WTR::InjectedBundlePage::shouldDeleteRange):
913         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
914         (WTR::InjectedBundlePage::shouldApplyStyle):
915         (WTR::InjectedBundlePage::didBeginEditing):
916         (WTR::InjectedBundlePage::didEndEditing):
917         (WTR::InjectedBundlePage::didChange):
918         (WTR::InjectedBundlePage::didChangeSelection):
919         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
920
921 2010-08-07  Dan Bernstein  <mitz@apple.com>
922
923         Build fix.
924
925         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
926         to JSGCController.{cpp,h} relative to the build root.
927
928 2010-08-07  Sam Weinig  <sam@webkit.org>
929
930         Reviewed by Anders Carlsson.
931
932         WebKitTestRunner needs GCController
933         <rdar://problem/8213834>
934         https://bugs.webkit.org/show_bug.cgi?id=42701
935
936         * WebKitTestRunner/DerivedSources.make:
937         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
938         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
939         (WTR::setProperty):
940         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
941         (WTR::GCController::create):
942         (WTR::GCController::GCController):
943         (WTR::GCController::~GCController):
944         (WTR::GCController::wrapperClass):
945         (WTR::GCController::collect):
946         (WTR::GCController::collectOnAlternateThread):
947         (WTR::GCController::getJSObjectCount):
948         (WTR::GCController::makeWindowObject):
949         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
950         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
951         (WTR::InjectedBundle::reset):
952         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
953         (WTR::InjectedBundle::bundle):
954         (WTR::InjectedBundle::gcController):
955         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
956         (WTR::InjectedBundlePage::didClearWindowForFrame):
957         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
958         (WTR::LayoutTestController::keepWebHistory):
959         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
960         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
961         * WebKitTestRunner/win/InjectedBundle.vcproj:
962
963 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
964
965         WebKitTestRunner needs to be able to set the font smoothing type
966         https://bugs.webkit.org/show_bug.cgi?id=43406
967
968         Reviewed by Adam Roben.
969
970         * WebKitTestRunner/TestInvocation.cpp:
971         (WTR::TestInvocation::resetPreferencesToConsistentValues):
972         Set the font smoothing level to
973         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
974
975 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
976
977         Fix a missed variable rename.
978
979         Unreviewed.
980
981         * Scripts/old-run-webkit-tests:
982
983 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
984
985         mac-wk2/Skipped should be used on Windows when running regression tests
986         https://bugs.webkit.org/show_bug.cgi?id=43494
987
988         Reviewed by Adam Roben.
989
990         * Scripts/old-run-webkit-tests:
991         If the platform is win-wk2, also read the mac-wk2 skipped list.
992
993 2010-08-06  Kent Tamura  <tkent@chromium.org>
994
995         Reviewed by Dimitri Glazkov.
996
997         [DRT/Chromium] Should revoke scheduled tasks
998         https://bugs.webkit.org/show_bug.cgi?id=43560
999
1000         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1001         (DRTDevToolsAgent::reset): Calls RevokeAll().
1002         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1003         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1004         (DRTDevToolsClient::reset): Calls RevokeAll().
1005         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1006         * DumpRenderTree/chromium/EventSender.cpp:
1007         (EventSender::reset): Calls RevokeAll().
1008         * DumpRenderTree/chromium/LayoutTestController.cpp:
1009         (LayoutTestController::reset): Calls RevokeAll().
1010         * DumpRenderTree/chromium/TestShell.cpp:
1011         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
1012
1013 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1014
1015         Reviewed by Antonio Gomes.
1016
1017         [Qt] Fix the DRT build on Mac OS X
1018
1019         * DumpRenderTree/qt/DumpRenderTree.pro:
1020
1021 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
1022
1023         Reviewed by Pavel Feldman.
1024
1025         Rietvield's upload.py moved to a different location.
1026         https://bugs.webkit.org/show_bug.cgi?id=43613
1027
1028         * Scripts/webkitpy/thirdparty/__init__.py:
1029
1030 2010-05-23  Eric Seidel  <eric@webkit.org>
1031
1032         Reviewed by Adam Barth.
1033
1034         QueueStatusServer needs better queue-status pages
1035         https://bugs.webkit.org/show_bug.cgi?id=39562
1036
1037         The primary goal of this patch is to display queue
1038         positions somewhere on the site so that it's easier
1039         for commit-queue users to know when their pach will
1040         be landed.  I also tried to improve the root page
1041         to be more useful than the previous wall of status text.
1042
1043         * QueueStatusServer/handlers/recentstatus.py:
1044         * QueueStatusServer/main.py:
1045         * QueueStatusServer/model/queues.py:
1046         * QueueStatusServer/templates/recentstatus.html:
1047
1048 2010-08-05  Victor Wang  <victorw@chromium.org>
1049
1050         Reviewed by Ojan Vafai.
1051
1052         Add option to generate/upload incremental json results to test result server.
1053         Also refactor the json results generator unittest code to test
1054         incremental and aggregated json results.
1055
1056         https://bugs.webkit.org/show_bug.cgi?id=43519
1057
1058         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1059         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1060         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1061         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1062
1063 2010-08-05  Jian Li  <jianli@chromium.org>
1064
1065         Reviewed by David Levin.
1066
1067         Unify blob related feature defines to ENABLE(BLOB).
1068         https://bugs.webkit.org/show_bug.cgi?id=43081
1069
1070         * Scripts/build-webkit:
1071
1072 2010-08-05  Satish Sampath  <satish@chromium.org>
1073
1074         Reviewed by Jeremy Orlow.
1075
1076         Add speech input controller mock in WebKit and a layout test.
1077         https://bugs.webkit.org/show_bug.cgi?id=43477
1078
1079         Added LayoutTestController::setMockSpeechInputResultCallback method.
1080
1081         * DumpRenderTree/LayoutTestController.cpp:
1082         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
1083         (LayoutTestController::staticFunctions):
1084         * DumpRenderTree/LayoutTestController.h:
1085         * DumpRenderTree/chromium/LayoutTestController.cpp:
1086         (LayoutTestController::LayoutTestController):
1087         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
1088         (LayoutTestController::speechInputController): Creates the mock controller.
1089         * DumpRenderTree/chromium/LayoutTestController.h:
1090         * DumpRenderTree/chromium/WebViewHost.cpp:
1091         (WebViewHost::speechInputController): Creates the mock controller.
1092         * DumpRenderTree/chromium/WebViewHost.h:
1093         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1094         (LayoutTestController::setMockSpeechInputResult): dummy method.
1095         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1096         (LayoutTestController::setMockSpeechInputResult): dummy method.
1097         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1098         (LayoutTestController::setMockSpeechInputResult): dummy method.
1099         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1100         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
1101         (LayoutTestController::setMockSpeechInputResult):
1102         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
1103         (LayoutTestController::setMockSpeechInputResult):
1104
1105 2010-08-04  Adam Roben  <aroben@apple.com>
1106
1107         Fix the path to TestNetscapePlugin's directory on Windows
1108
1109         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
1110         load TestNetscapePlugin
1111
1112         Reviewed by Jon Honeycutt.
1113
1114         * WebKitTestRunner/win/TestControllerWin.cpp:
1115         (WTR::TestController::initializeTestPluginDirectory):
1116         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
1117         next to WebKitTestRunner.exe. Previously we were passing the directory
1118         that contains WebKitTestRunner.exe. Also fixed some leaks.
1119
1120 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
1121
1122         Reviewed by Shinichiro Hamaji.
1123
1124         check-webkit-style returns non-zero when patch is entirely minus lines.
1125         https://bugs.webkit.org/show_bug.cgi?id=38169
1126
1127         * Scripts/check-webkit-style:
1128         Check whether a patch contains modified files that are entirely minus lines.
1129         * Scripts/webkitpy/style/filereader.py:
1130         Add a variable that holds number of files that contain only deleted lines.
1131         * Scripts/webkitpy/style/patchreader.py:
1132         Count up modified files that contain only deleted lines.
1133
1134 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
1135
1136         Reviewed by Yury Semikhatsky.
1137
1138         DevTools: get rid of delayed command dispatching on front-end side.
1139
1140         https://bugs.webkit.org/show_bug.cgi?id=43479
1141
1142         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1143         (DRTDevToolsAgent::detach):
1144         (DRTDevToolsAgent::frontendLoaded):
1145         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1146         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1147         (DRTDevToolsClient::~DRTDevToolsClient):
1148         (DRTDevToolsClient::sendFrontendLoaded):
1149         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1150
1151 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
1152
1153         Reviewed by Shinichiro Hamaji.
1154
1155         Fixes check-webkit-style false positive on "new uint32_t."
1156         https://bugs.webkit.org/show_bug.cgi?id=43077
1157
1158         * Scripts/webkitpy/style/checkers/cpp.py:
1159         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1160
1161 2010-08-04  Kent Tamura  <tkent@chromium.org>
1162
1163         Reviewed by Dimitri Glazkov.
1164
1165         [DRT/Chromium] Remove base/linked_ptr.h dependency
1166         https://bugs.webkit.org/show_bug.cgi?id=43472
1167
1168         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
1169         We need to use RefPtr<> because m_pendingEntry points an object in
1170         m_entries or not in m_entries.
1171
1172         * DumpRenderTree/chromium/TestNavigationController.cpp:
1173         (TestNavigationEntry::create): Added.
1174         (TestNavigationController::activeEntry):
1175         (TestNavigationController::didNavigateToEntry):
1176         (TestNavigationController::discardPendingEntry):
1177         (TestNavigationController::insertEntry):
1178         (TestNavigationController::navigateToPendingEntry):
1179         * DumpRenderTree/chromium/TestNavigationController.h:
1180         * DumpRenderTree/chromium/WebViewHost.cpp:
1181         (WebViewHost::loadURLForFrame):
1182          Use TestNavigationEntry::create().
1183         (WebViewHost::updateURL):
1184          Use RefPtr<>.
1185         (WebViewHost::updateSessionHistory):
1186          Remove unnecessary static_cast<>.
1187
1188 2010-08-04  Kent Tamura  <tkent@chromium.org>
1189
1190         Reviewed by Dimitri Glazkov.
1191
1192         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
1193         https://bugs.webkit.org/show_bug.cgi?id=43333
1194
1195         * BuildSlaveSupport/test-result-archive:
1196           - Make layoutTestResultsDir local and pass it to archiveTestResults()
1197           - Adjust layoutTestResultsDir for Chromium
1198
1199 2010-08-04  Kent Tamura  <tkent@chromium.org>
1200
1201         Reviewed by Dimitri Glazkov.
1202
1203         NRWT: websocket_server startup detection failure
1204         https://bugs.webkit.org/show_bug.cgi?id=43466
1205
1206         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1207          Increase timeout value: 5 second -> 10 second
1208
1209 2010-08-04  Victor Wang  <victorw@chromium.org>
1210
1211         Reviewed by Ojan Vafai.
1212
1213         -. Add result.json incremental merging functionality to test results app engine.
1214         -. blobstore is not suitable for AE data merging and there is no API to
1215            programatically edit existing blob or write a new one yet, so replace blobstore
1216            with datastore. If file is oversize (>1000*1000 bytes), store file data in
1217            multiple datastore entries.
1218         -. Fix styles.
1219
1220         Test: jsonresults_unittest to test merging logics.
1221
1222         https://bugs.webkit.org/show_bug.cgi?id=38599
1223
1224         * TestResultServer/handlers/dashboardhandler.py:
1225         * TestResultServer/handlers/menu.py:
1226         * TestResultServer/handlers/testfilehandler.py:
1227         * TestResultServer/main.py:
1228         * TestResultServer/model/dashboardfile.py:
1229         * TestResultServer/model/datastorefile.py: Added.
1230         * TestResultServer/model/jsonresults.py: Added.
1231         * TestResultServer/model/jsonresults_unittest.py: Added.
1232         * TestResultServer/model/testfile.py:
1233         * TestResultServer/templates/uploadform.html:
1234
1235 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
1236
1237         Reviewed by Kenneth Christiansen.
1238
1239         [Qt] [QtTestBrowser] Remove unneeded QAction class members
1240         https://bugs.webkit.org/show_bug.cgi?id=43518
1241
1242         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
1243         m_flipYAnimated. Also, in initializeView method there are some dead code block
1244         trying to connect them at the wrong time, when they have not been instanciated.
1245
1246         This patch:
1247
1248         - removes the two cited class members in favor of local variables in createChrome method;
1249         - removes the dead code block.
1250
1251         * QtTestBrowser/launcherwindow.cpp:
1252         (LauncherWindow::LauncherWindow):
1253         (LauncherWindow::initializeView):
1254         (LauncherWindow::createChrome):
1255         * QtTestBrowser/launcherwindow.h:
1256
1257 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
1258
1259         Reviewed by Simon Hausmann and Kenneth Christiansen.
1260
1261         [Qt] [QtTestBrowser] Clean up static and global menu state controls
1262         https://bugs.webkit.org/show_bug.cgi?id=43448
1263
1264         After LauncherWindow class was refactored out of from main.cpp, all global variables that
1265         were hanging in main.cpp became temporarily public static class members of newly added
1266         LauncherWindow class. This design was not properly handling the initial purpose of the
1267         global variables: newly created launcher windows should inherit the settings of the originating
1268         one.
1269
1270         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
1271         comprises all data needed to handling the goal described above.
1272
1273         * QtTestBrowser/launcherwindow.cpp:
1274         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
1275                                           holding all user settings configured in the menus and command line.
1276                                           It also receices an optional QGraphicsScene points in case we are doing
1277                                           a "Clone Window".
1278         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
1279                                 value.
1280         (LauncherWindow::initializeView): Ditto.
1281         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
1282         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
1283                                       apply the preferences is provided by m_userData.
1284         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
1285         (LauncherWindow::toggleResizesToContents): Ditto.
1286         (LauncherWindow::toggleWebGL): Ditto.
1287         (LauncherWindow::toggleFrameFlattening): Ditto.
1288         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
1289         (LauncherWindow::changeViewportUpdateMode): Ditto.
1290         (LauncherWindow::showFPS): Ditto.
1291         (LauncherWindow::newWindow): Changed to pass the userData.
1292         (LauncherWindow::cloneWindow): Ditto.
1293         * QtTestBrowser/launcherwindow.h:
1294         (WindowOptions::WindowOptions):
1295         * QtTestBrowser/main.cpp:
1296         (requiresGraphicsView):
1297         (LauncherApplication::handleUserOptions):
1298         (main):
1299
1300 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
1301
1302         [wx] Build fix for gcc not importing all symbols from convenience libraries.
1303         Works on 10.6 only for Mac until the build system is reworked. 
1304
1305         * wx/build/settings.py:
1306
1307 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
1308
1309         Reviewed by Simon Hausmann.
1310
1311         [Qt] Change wording in QtTestBrowser
1312         https://bugs.webkit.org/show_bug.cgi?id=43241
1313
1314         * QtTestBrowser/launcherwindow.cpp:
1315         (LauncherWindow::createChrome):
1316
1317 2010-08-04  Aaron Boodman  <aa@chromium.org>
1318
1319         Reviewed by Eric Seidel.
1320
1321         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
1322         https://bugs.webkit.org/show_bug.cgi?id=43460
1323
1324         * Scripts/prepare-ChangeLog:
1325
1326 2010-08-03  MORITA Hajime  <morrita@google.com>
1327
1328         Reviewed by Tony Chang.
1329
1330         [DRT] Assertion failed when drag and move a draggable element.
1331         https://bugs.webkit.org/show_bug.cgi?id=41695
1332
1333         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
1334         But Cocoa doesn't call mouseDragged() until dragging is done.
1335         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
1336         on UIDelegate failed when mouseDragged() is called during dragging.
1337         This change eliminated the mouseDragged() call when dragging begins,
1338         which is implicated by draggingInfo instance.
1339         
1340         * DumpRenderTree/mac/EventSendingController.mm:
1341         (-[EventSendingController mouseMoveToX:Y:]):
1342
1343         Test: fast/events/dragging-mouse-moves.html
1344         
1345 2010-08-02  Steve Block  <steveblock@google.com>
1346
1347         Reviewed by Alexey Proskuryakov.
1348
1349         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
1350         https://bugs.webkit.org/show_bug.cgi?id=40002
1351
1352         The code in LayoutTestController::setGeolocationPermission() was moved to
1353         setGeolocationPermissionCommon() to allow each port to provide its own
1354         implementation of setGeolocationPermission().
1355
1356         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
1357         new permission, so it can call back to WebCore if permission requests are in
1358         progress and are waiting for a response. A minor fix to the Mac
1359         MockGeolocationProvider was also required to make sure that the mock provider
1360         calls back to WebCore when it is first started.
1361
1362         For other ports, LayoutTestController::setGeolocationPermission() is not
1363         implemented.
1364
1365         * DumpRenderTree/LayoutTestController.cpp:
1366         (LayoutTestController::setGeolocationPermissionCommon):
1367         * DumpRenderTree/LayoutTestController.h:
1368         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1369         (LayoutTestController::setGeolocationPermission):
1370         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1371         (LayoutTestController::setGeolocationPermission):
1372         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1373         (-[MockGeolocationProvider registerWebView:]):
1374         * DumpRenderTree/mac/UIDelegate.h:
1375         * DumpRenderTree/mac/UIDelegate.mm:
1376         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1377         (-[UIDelegate setGeolocationPermission:]):
1378         (-[UIDelegate dealloc]):
1379         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1380         (LayoutTestController::setGeolocationPermission):
1381         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1382         (LayoutTestController::setGeolocationPermission):
1383
1384 2010-08-03  Kent Tamura  <tkent@chromium.org>
1385
1386         Reviewed by Dimitri Glazkov.
1387
1388         [DRT/Chromium] Implement --testshell-startup-dialog
1389         https://bugs.webkit.org/show_bug.cgi?id=40616
1390
1391         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1392         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
1393         if it is specfied.
1394         * DumpRenderTree/chromium/TestShell.h:
1395           Declare openStartUpDialog().
1396         * DumpRenderTree/chromium/TestShellGtk.cpp:
1397         (openStartupDialog):
1398         * DumpRenderTree/chromium/TestShellMac.mm:
1399         (openStartupDialog):
1400         * DumpRenderTree/chromium/TestShellWin.cpp:
1401         (openStartupDialog):
1402
1403 2010-08-03  Kent Tamura  <tkent@chromium.org>
1404
1405         Reviewed by Dimitri Glazkov.
1406
1407         [DRT/Chromium] Remove dependency of base/md5.h
1408         https://bugs.webkit.org/show_bug.cgi?id=43403
1409
1410         * DumpRenderTree/chromium/TestShell.cpp:
1411         (TestShell::dumpImage): Use wtf/MD5.h
1412
1413 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
1414
1415         Reviewed by David Kilzer.
1416
1417         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
1418         https://bugs.webkit.org/show_bug.cgi?id=40627
1419
1420         Part 6 - LayoutTest and Cleanup
1421
1422           Allow tests to delete application caches and set application cache
1423           origin quotas, so they can be tested.
1424
1425         * DumpRenderTree/LayoutTestController.cpp:
1426         (LayoutTestController::LayoutTestController):
1427         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
1428         (clearAllApplicationCachesCallback): should delete all application caches.
1429         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
1430         (LayoutTestController::staticFunctions):
1431         * DumpRenderTree/LayoutTestController.h:
1432         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
1433         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
1434
1435           Mac implementation.
1436
1437         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1438         (LayoutTestController::clearAllApplicationCaches): delete application caches.
1439         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
1440         * DumpRenderTree/mac/UIDelegate.mm:
1441         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
1442         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
1443
1444           Stub implementations for other platforms.
1445
1446         * DumpRenderTree/chromium/LayoutTestController.cpp:
1447         (LayoutTestController::LayoutTestController):
1448         (LayoutTestController::clearAllApplicationCaches):
1449         (LayoutTestController::setApplicationCacheOriginQuota):
1450         * DumpRenderTree/chromium/LayoutTestController.h:
1451         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1452         (LayoutTestController::clearAllApplicationCaches):
1453         (LayoutTestController::setApplicationCacheOriginQuota):
1454         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1455         (LayoutTestController::clearAllApplicationCaches):
1456         (LayoutTestController::setApplicationCacheOriginQuota):
1457         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1458         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1459         (LayoutTestController::clearAllApplicationCaches):
1460         (LayoutTestController::setApplicationCacheOriginQuota):
1461         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1462         (LayoutTestController::clearAllApplicationCaches):
1463         (LayoutTestController::setApplicationCacheOriginQuota):
1464
1465 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
1466
1467         Reviewed by David Kilzer.
1468
1469         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
1470         https://bugs.webkit.org/show_bug.cgi?id=40627
1471
1472         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
1473
1474           Change old style calls to make use of the managers.
1475
1476         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1477         (LayoutTestController::setDatabaseQuota):
1478         * DumpRenderTree/mac/UIDelegate.mm:
1479         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
1480
1481 2010-08-03  Mark Rowe  <mrowe@apple.com>
1482
1483         Add a new Leopard build slave to run the release tests.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/config.json:
1486
1487 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
1488
1489         WebKitTestRunner needs to activate the Mac font ascent hack
1490         https://bugs.webkit.org/show_bug.cgi?id=43404
1491
1492         Reviewed by Darin Adler.
1493
1494         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1495         (WTR::InjectedBundle::initialize):
1496         Call WKBundleActivateMacFontAscentHack().
1497
1498 2010-08-03  Alex Milowski  <alex@milowski.com>
1499
1500         Reviewed by Beth Dakin.
1501
1502         Changed the default for MathML support so that is is enabled by default.
1503
1504         * Scripts/build-webkit:
1505
1506 2010-08-03  Sam Weinig  <sam@webkit.org>
1507
1508         Roll r64566 back in this time with all the overloads in place..
1509
1510         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1511         (WTR::InjectedBundlePage::shouldInsertNode):
1512         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1513         * WebKitTestRunner/StringFunctions.h:
1514         * WebKitTestRunner/TestInvocation.cpp:
1515         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1516         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1517         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1518
1519 2010-08-03  Sam Weinig  <sam@webkit.org>
1520
1521         Rollout r64566. It broke all the WebKit2 tests.
1522
1523         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1524         (WTR::operator<<):
1525         (WTR::InjectedBundlePage::shouldInsertNode):
1526         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1527         * WebKitTestRunner/StringFunctions.h: Removed.
1528         * WebKitTestRunner/TestInvocation.cpp:
1529         (WTR::createWKURL):
1530         (WTR::WKStringToUTF8):
1531         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1532         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1533         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1534
1535 2010-08-03  Sam Weinig  <sam@webkit.org>
1536
1537         Reviewed by Anders Carlsson.
1538
1539         WTR: Move all the utility functions for working with strings to a shared header.
1540         https://bugs.webkit.org/show_bug.cgi?id=43386
1541
1542         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1543         (WTR::InjectedBundlePage::shouldInsertNode):
1544         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1545         * WebKitTestRunner/StringFunctions.h: Added.
1546         * WebKitTestRunner/TestInvocation.cpp:
1547         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1548         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1549         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1550
1551 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
1552
1553         Reviewed by Kenneth Christiansen.
1554
1555         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
1556         https://bugs.webkit.org/show_bug.cgi?id=43168
1557
1558         QGraphicsWebView resizesToContents property has to work together with QWebPage's
1559         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
1560
1561         * QtTestBrowser/launcherwindow.cpp:
1562         (LauncherWindow::applyPrefs):
1563         * QtTestBrowser/webview.cpp:
1564         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
1565                                                       needed when toggle resizesToContents on/off.
1566         (WebViewGraphicsBased::resizeEvent):
1567         * QtTestBrowser/webview.h:
1568         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
1569         (WebViewGraphicsBased::customLayoutSize): Getter helper.
1570
1571 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
1572
1573         Unreviewed. Adding myself as committer.
1574
1575         * Scripts/webkitpy/common/config/committers.py:
1576
1577 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
1578
1579         Reviewed by Yury Semikhatsky.
1580
1581         Chromium DevTools: Get rid of DevTools RPC.
1582
1583         https://bugs.webkit.org/show_bug.cgi?id=43335
1584
1585         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1586         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
1587         (DRTDevToolsAgent::call):
1588         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1589         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1590         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1591         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1592         (DRTDevToolsClient::sendMessageToBackend):
1593         (DRTDevToolsClient::call):
1594         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1595
1596 2010-08-02  Kent Tamura  <tkent@chromium.org>
1597
1598         Reviewed by Dimitri Glazkov.
1599
1600         [DRT/Chromium] Remove dependencies to some Chromium headers
1601         https://bugs.webkit.org/show_bug.cgi?id=43396
1602
1603         * DumpRenderTree/chromium/CppVariant.h:
1604          Remove base/basictypes.h because webkit_support.h contains it.
1605         * DumpRenderTree/chromium/EventSender.cpp:
1606         (getCurrentEventTimeSec): Use new wrapper function.
1607         * DumpRenderTree/chromium/TestNavigationController.h:
1608          Remove base/basictypes.h because webkit_support.h contains it.
1609         * DumpRenderTree/chromium/TestShell.cpp:
1610         (dumpHistoryItem): Use new wrapper function.
1611         * DumpRenderTree/chromium/WebViewHost.cpp:
1612         (WebViewHost::cancelledError): Use new wrapper function.
1613         (WebViewHost::didFailResourceLoad): Use new wrapper function.
1614
1615 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1616
1617         Reviewed by Xan Lopez.
1618
1619         [GTK] DRT implement execCommand()
1620         https://bugs.webkit.org/show_bug.cgi?id=35351
1621
1622         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1623         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
1624         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
1625         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
1626
1627 2010-08-02  Sam Weinig  <sam@webkit.org>
1628
1629         Reviewed by Anders Carlsson.
1630
1631         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
1632
1633         * Scripts/old-run-webkit-tests:
1634
1635 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1636
1637         WebKitTestRunner needs to support loading custom fonts (via the
1638         WEBKIT_TESTFONTS environment variable)
1639         https://bugs.webkit.org/show_bug.cgi?id=42782
1640
1641         Reviewed by Adam Roben.
1642
1643         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1644         (WTR::fontsPath):
1645         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
1646         as this directory doesn't appear to be created anymore.
1647         (WTR::activateFonts):
1648         Loop through the fonts, and call AddFontResourceExW() for each.
1649
1650 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1651
1652         Restore the WebKitTestRunner.sln that was removed, and remove the
1653         correct one.
1654
1655         Rubber-stamped by Sam Weinig.
1656
1657         * WebKitTestRunner/WebKitTestRunner.sln: Added.
1658         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
1659
1660 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1661
1662         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
1663
1664         Remove the unused WebKitTestRunner.sln.
1665
1666         Reviewed by Sam Weinig.
1667
1668         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1669         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
1670         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
1671         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
1672         * WebKitTestRunner/win/WebKitTestRunner.sln:
1673
1674 2010-08-02  Sam Weinig  <sam@webkit.org>
1675
1676         Fix the windows build.
1677
1678         * WebKitTestRunner/win/main.cpp:
1679
1680 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
1681
1682         Add a Skipped list on Windows, and have run-webkit-tests respect it.
1683
1684         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
1685         there are zero tests failing
1686         https://bugs.webkit.org/show_bug.cgi?id=43374
1687
1688         Reviewed by Adam Roben.
1689
1690         * Scripts/old-run-webkit-tests:
1691         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
1692         win-wk2. When building the result hierarchy, if the platform is win-wk2,
1693         add it first to the list of platforms.
1694
1695 2010-08-02  Darin Adler  <darin@apple.com>
1696
1697         Reviewed by Sam Weinig.
1698
1699         WebKitTestRunner needs layoutTestController.setCanOpenWindows
1700         https://bugs.webkit.org/show_bug.cgi?id=42321
1701
1702         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
1703         https://bugs.webkit.org/show_bug.cgi?id=42779
1704
1705         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
1706         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
1707
1708         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1709         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
1710         waiting for the first call to didCreatePage.
1711         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
1712         is created. Put other pages into a map.
1713         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
1714         of the main page.
1715         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
1716         the main page.
1717         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
1718         closeOtherPages functions.
1719
1720         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1721         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
1722         the main page affect dumping.
1723         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
1724
1725         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1726         (WTR::LayoutTestController::LayoutTestController): Initialize the new
1727         m_shouldCloseExtraWindows member.
1728         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
1729         (WTR::LayoutTestController::windowCount): Added.
1730
1731         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1732         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
1733         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
1734         m_shouldCloseExtraWindows.
1735
1736         * WebKitTestRunner/TestController.cpp:
1737         (WTR::TestController::shared): Return a pointer to the shared copy, but
1738         don't allocate and leak it. This seemed cleaner than adding an explicit
1739         finalize call to go along with the explicit initialize call.
1740         (WTR::TestController::TestController): Added calls to the initialize and
1741         run function, which are now done automatically.
1742         (WTR::TestController::~TestController): Added, since it's called now.
1743         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
1744         (WTR::createOtherPage): Added. Used to create pages other than the main page.
1745         (WTR::TestController::initialize): Added code to set up createOtherPage.
1746         (WTR::TestController::run): Removed unused return value.
1747         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
1748         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
1749
1750         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1751         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
1752         to avoid releasing the window twice. Another way to handle it would be to
1753         remove the release, but this approach is slightly more robust because it works
1754         even if some other code calls the close method an extra time.
1755
1756         * WebKitTestRunner/mac/main.mm:
1757         (main): Use a stack-allocated TestController object instead of calling
1758         initalize and run on a globally allocated one.
1759
1760 2010-08-02  Tony Chang  <tony@chromium.org>
1761
1762         Reviewed by David Levin.
1763
1764         add myself to the reviewers list
1765         https://bugs.webkit.org/show_bug.cgi?id=43366
1766
1767         * Scripts/webkitpy/common/config/committers.py:
1768
1769 2010-08-02  Anders Carlsson  <andersca@apple.com>
1770
1771         Reviewed by Sam Weinig.
1772
1773         Cache JSNPObjects and fix bugs in the object map
1774         https://bugs.webkit.org/show_bug.cgi?id=43368
1775
1776         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
1777         wrap an NPObject that came from a plug-in that is now destroyed.
1778
1779         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1780         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1781         (PluginTest::Object::getProperty):
1782         (PluginTest::Object::NP_GetProperty):
1783         (PluginTest::Object::npClass):
1784         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
1785         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
1786         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1787         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
1788         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
1789         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1790         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1791         * GNUmakefile.am:
1792
1793 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1794
1795         Reviewed by Xan Lopez.
1796
1797         [Gtk] DOM listeners get wrong keycodes for some keys
1798         https://bugs.webkit.org/show_bug.cgi?id=35170
1799
1800         Add support to all event senders for simulating keypad insert
1801         and print screen keys.
1802
1803         * DumpRenderTree/chromium/EventSender.cpp:
1804         (EventSender::keyDown): Add support for generating keypad insert and print screen.
1805         * DumpRenderTree/gtk/EventSender.cpp:
1806         (keyDownCallback): Ditto.
1807         * DumpRenderTree/mac/EventSendingController.mm:
1808         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
1809         * DumpRenderTree/qt/EventSenderQt.cpp:
1810         (EventSender::keyDown): Ditto.
1811         * DumpRenderTree/win/EventSender.cpp:
1812         (keyDownCallback): Ditto.
1813
1814 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1815
1816         Build fix for building against development versions of GTK+. GTK 2.22
1817         has not yet been released, so these function definitions must be conditionalized
1818         on the development version.
1819
1820         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
1821
1822 2010-08-02  Tony Chang  <tony@chromium.org>
1823
1824         Reviewed by Kent Tamura.
1825
1826         [chromium] use ChromiumDriver on Linux when running webkit tests
1827         https://bugs.webkit.org/show_bug.cgi?id=43273
1828
1829         * Scripts/webkitpy/layout_tests/port/chromium.py:
1830
1831 2010-08-02  Kent Tamura  <tkent@chromium.org>
1832
1833         Reviewed by Dimitri Glazkov.
1834
1835         [DRT/Chromium] Always initialize GTK
1836         https://bugs.webkit.org/show_bug.cgi?id=43327
1837
1838         Call gtk_init() in order to fix plugin test crash.
1839
1840         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1841         (main): Pass argc/argv to platformInit().
1842         * DumpRenderTree/chromium/TestShell.h:
1843         * DumpRenderTree/chromium/TestShellGtk.cpp:
1844         (platformInit): Update parameters, call gtk_init().
1845         * DumpRenderTree/chromium/TestShellMac.mm:
1846         (platformInit): Update parameters.
1847         * DumpRenderTree/chromium/TestShellWin.cpp:
1848         (platformInit): Update parameters.
1849
1850 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
1851
1852         Reviewed by Simon Hausmann.
1853
1854         [Qt] Generate forwarding headers for WebKit2
1855
1856         https://bugs.webkit.org/show_bug.cgi?id=43336
1857
1858         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
1859
1860 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
1861
1862         Reviewed by Kent Tamura.
1863
1864         WebSocket server should start with SO_REUSEADDR
1865         https://bugs.webkit.org/show_bug.cgi?id=43329
1866
1867         Pulls in pywebsocket-0.5.2.
1868         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
1869         http://code.google.com/p/pywebsocket/source/detail?r=273
1870
1871         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
1872
1873 2010-08-01  Kent Tamura  <tkent@chromium.org>
1874
1875         Reviewed by Dimitri Glazkov.
1876
1877         [DRT/Chromium] Remove string_util.h dependency
1878         https://bugs.webkit.org/show_bug.cgi?id=43312
1879
1880         * DumpRenderTree/chromium/LayoutTestController.cpp:
1881         (LayoutTestController::pathToLocalResource):
1882          Use string::find() instead of StartsWithASCII().
1883         (LayoutTestController::cppVariantToInt32):
1884          Use strtol() instead of StringToNumber().
1885
1886 2010-08-01  Sam Weinig  <sam@webkit.org>
1887
1888         Reviewed by Anders Carlsson.
1889
1890         Add ability to reset frame names for WebKitTestRunner
1891         https://bugs.webkit.org/show_bug.cgi?id=43316
1892
1893         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1894         (WTR::InjectedBundle::reset):
1895         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1896         (WTR::InjectedBundlePage::reset):
1897         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1898
1899 2010-08-01  Anders Carlsson  <andersca@apple.com>
1900
1901         Reviewed by Sam Weinig.
1902
1903         Implement NPN_RemoveProperty
1904         https://bugs.webkit.org/show_bug.cgi?id=43315
1905
1906         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1907         Add NPRuntimeRemoveProperty.cpp
1908         
1909         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1910         (PluginTest::NPN_GetStringIdentifier):
1911         (PluginTest::NPN_GetIntIdentifier):
1912         (PluginTest::NPN_RemoveProperty):
1913         Add NPN_ helpers.
1914
1915         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1916         Support more NPClass functions.
1917
1918         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
1919         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
1920         Test for NPN_RemoveProperty.
1921
1922         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
1923         (NPRuntimeRemoveProperty::TestObject::invoke):
1924         Add a testRemoveProperty method.
1925
1926         (NPRuntimeRemoveProperty::NPP_GetValue):
1927         Return the test object.
1928
1929         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1930         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1931         * GNUmakefile.am:
1932         Add NPRuntimeRemoveProperty.cpp
1933
1934 2010-07-30  Anders Carlsson  <andersca@apple.com>
1935
1936         Reviewed by Sam Weinig.
1937
1938         Add an NPObject class template helper to TestNetscapePlugin
1939         https://bugs.webkit.org/show_bug.cgi?id=43288
1940
1941         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1942         Add some template magic to be able to figure out if a class has a member function of a given type.
1943
1944         (PluginTest::Object::create):
1945         Create an object.
1946
1947         (PluginTest::Object::invokeDefault):
1948         Add dummy function, this should never be called.
1949
1950         (PluginTest::Object::Object):
1951         Initialize m_pluginTest to 0.
1952
1953         (PluginTest::Object::~Object):
1954         Add virtual destructor.
1955
1956         (PluginTest::Object::NP_Allocate):
1957         Create a new object.
1958
1959         (PluginTest::Object::NP_Deallocate):
1960         Delete the object.
1961
1962         (PluginTest::Object::NP_InvokeDefault):
1963         Call invokeDefault.
1964
1965         (PluginTest::Object::npClass):
1966         Initialize the NPClass struct.
1967
1968         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1969         (DocumentOpenInDestroyStream::NPP_DestroyStream):
1970         Move this inline.
1971
1972         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1973         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
1974         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
1975         Use the PluginTest::Object class template.
1976
1977 2010-07-31  Sam Weinig  <sam@webkit.org>
1978
1979         Reviewed by Dan Bernstein.
1980
1981         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
1982         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
1983         due to SVGElements not having the innerText function.
1984
1985         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1986         (WTR::dumpFrameText):
1987
1988 2010-07-30  Sam Weinig  <sam@webkit.org>
1989
1990         Reviewed by Maciej Stachowiak.
1991
1992         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
1993         Add structured message passing from the injected bundle to UIProcess
1994
1995         * MiniBrowser/mac/AppDelegate.m:
1996         (didRecieveMessageFromInjectedBundle):
1997         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1998         (didClearWindowForFrame):
1999         (didRecieveMessage):
2000         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2001         (WTR::InjectedBundle::done):
2002         (WTR::InjectedBundle::didReceiveMessage):
2003         * WebKitTestRunner/TestController.cpp:
2004         (WTR::TestController::initialize):
2005         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2006         * WebKitTestRunner/TestController.h:
2007         * WebKitTestRunner/TestInvocation.cpp:
2008         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2009         * WebKitTestRunner/TestInvocation.h:
2010         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2011
2012 2010-07-30  Sam Weinig  <sam@webkit.org>
2013
2014         Reviewed by Anders Carlsson.
2015
2016         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
2017         Make WKArrayRef more usable.
2018
2019         Remove now unnecessary const_casts.
2020
2021         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2022         (WTR::dumpDescendantFrameScrollPositions):
2023         (WTR::dumpDescendantFramesText):
2024
2025 2010-07-30  Sam Weinig  <sam@webkit.org>
2026
2027         Reviewed by Anders Carlsson.
2028
2029         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
2030         Add first pass of structured message passing.
2031
2032         Update Minibrowser and WebKitTestRunner to work with the new post message
2033         function.
2034
2035         * MiniBrowser/mac/AppDelegate.m:
2036         (didRecieveMessageFromInjectedBundle):
2037         (-[BrowserAppDelegate init]):
2038         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2039         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2040         (didStartProvisionalLoadForFrame):
2041         (didReceiveServerRedirectForProvisionalLoadForFrame):
2042         (didFailProvisionalLoadWithErrorForFrame):
2043         (didCommitLoadForFrame):
2044         (didFinishLoadForFrame):
2045         (didFailLoadWithErrorForFrame):
2046         (didReceiveTitleForFrame):
2047         (didClearWindowForFrame):
2048         (didCreatePage):
2049         (willDestroyPage):
2050         (didRecieveMessage):
2051         (WKBundleInitialize):
2052         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2053         (WTR::InjectedBundle::_didReceiveMessage):
2054         (WTR::InjectedBundle::didReceiveMessage):
2055         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2056         * WebKitTestRunner/TestInvocation.cpp:
2057         (WTR::TestInvocation::invoke):
2058         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2059
2060 2010-07-30  Anders Carlsson  <andersca@apple.com>
2061
2062         Try to fix the layout test failures.
2063
2064         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2065         (webkit_test_plugin_get_value):
2066
2067 2010-07-29  Anders Carlsson  <andersca@apple.com>
2068
2069         Reviewed by Adam Roben.
2070
2071         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
2072         https://bugs.webkit.org/show_bug.cgi?id=43232
2073
2074         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2075         Add PluginScriptableNPObjectInvokeDefault.cpp.
2076
2077         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2078         Remove invokeDefault callback function.
2079
2080         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2081         (PluginTest::create):
2082         Move this to the top of the file.
2083
2084         (PluginTest::NPP_GetValue):
2085         Add default implementation.
2086
2087         (PluginTest::NPN_CreateObject):
2088         Add NPN_ wrapper.
2089
2090         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2091         (PluginTest::identifier):
2092         Add identifier getter.
2093
2094         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
2095         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
2096         Add "using namespace std".
2097
2098         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2099         (NPP_GetValue):
2100         Give PluginTest a chance to return a value.
2101
2102         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2103         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2104         * GNUmakefile.am:
2105         Add PluginScriptableNPObjectInvokeDefault.cpp.
2106         
2107         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2108         (webkit_test_plugin_get_value):
2109         Give PluginTest a chance to return a value.
2110
2111 2010-07-30  Steve Block  <steveblock@google.com>
2112
2113         Reviewed by Steve Block.
2114
2115         Add LayoutTestController methods to test DeviceOrientation
2116         https://bugs.webkit.org/show_bug.cgi?id=39589
2117
2118         * DumpRenderTree/LayoutTestController.cpp:
2119         (setMockDeviceOrientationCallback):
2120         (LayoutTestController::staticFunctions):
2121         * DumpRenderTree/LayoutTestController.h:
2122         * DumpRenderTree/chromium/LayoutTestController.cpp:
2123         (LayoutTestController::LayoutTestController):
2124         (LayoutTestController::setMockDeviceOrientation):
2125         * DumpRenderTree/chromium/LayoutTestController.h:
2126         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2127         (LayoutTestController::setMockDeviceOrientation):
2128         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2129         (LayoutTestController::setMockDeviceOrientation):
2130         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2131         (LayoutTestController::setMockDeviceOrientation):
2132         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2133         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2134         (LayoutTestController::setMockDeviceOrientation):
2135         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2136         (LayoutTestController::setMockDeviceOrientation):
2137         * Scripts/build-webkit:
2138
2139 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2140
2141         Reviewed by Kenneth Christiansen.
2142
2143         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
2144         https://bugs.webkit.org/show_bug.cgi?id=43209
2145
2146         When -resizes-to-content was being passed as a command line parameter it was simply
2147         not being set (although the corresponding menu item was marked as ON).
2148         User had to toggle the menu OFF and then ON again for it to take place.
2149
2150         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
2151         the command line, but not resizesToContents. Patch addresses that.
2152
2153         * QtTestBrowser/launcherwindow.cpp:
2154         (LauncherWindow::createChrome):
2155         (LauncherWindow::applyPrefs):
2156         (LauncherWindow::toggleResizesToContents):
2157         * QtTestBrowser/webview.h:
2158         (WebViewGraphicsBased::resizesToContents):
2159
2160 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2161
2162         Rubber-stamped by Simon Fraser.
2163
2164         [Qt] QtTestBrowser: more method grouping and clean ups.
2165
2166         Moving blocks of code around. Basically grouping related methods close to each.
2167
2168         * QtTestBrowser/launcherwindow.cpp:
2169         (LauncherWindow::initializeView):
2170         (LauncherWindow::createChrome):
2171         (LauncherWindow::changeViewportUpdateMode):
2172         (LauncherWindow::showFPS):
2173         (LauncherWindow::newWindow):
2174         (LauncherWindow::cloneWindow):
2175         * QtTestBrowser/launcherwindow.h:
2176
2177 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2178
2179         Reviewed by Tor Arne Vestbø.
2180
2181         [QT][Symbian] QtTestBrowser missing location capabilities
2182         https://bugs.webkit.org/show_bug.cgi?id=43235
2183
2184         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
2185
2186         * QtTestBrowser/QtTestBrowser.pro:
2187
2188 2010-07-29  Anders Carlsson  <andersca@apple.com>
2189
2190         Add PluginTest.cpp
2191
2192         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2193
2194 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
2195
2196         Reviewed by Eric Seidel.
2197
2198         Update download URLs for python irclib package; the old URLs 
2199         pointed at a specific mirror host and not the general sourceforge
2200         URLs.
2201
2202         https://bugs.webkit.org/show_bug.cgi?id=43228
2203
2204         * Scripts/webkitpy/thirdparty/__init__.py:
2205
2206 2010-07-29  Anders Carlsson  <andersca@apple.com>
2207
2208         Fix typo.
2209
2210         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2211
2212 2010-07-29  Anders Carlsson  <andersca@apple.com>
2213
2214         Another attempt at fixing the Qt and GTK+ build.
2215
2216         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2217         (webkit_test_plugin_new_instance):
2218         (webkit_test_plugin_destroy_stream):
2219
2220 2010-07-29  Anders Carlsson  <andersca@apple.com>
2221
2222         Another build fix attempt.
2223
2224         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2225         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2226         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2227         (webkit_test_plugin_new_instance):
2228         * GNUmakefile.am:
2229
2230 2010-07-29  Anders Carlsson  <andersca@apple.com>
2231
2232         Try to fix Windows and Unix builds.
2233
2234         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2235         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2236         (webkit_test_plugin_new_instance):
2237         (webkit_test_plugin_destroy_stream):
2238
2239 2010-07-29  Anders Carlsson  <andersca@apple.com>
2240
2241         Reviewed by Sam Weinig.
2242
2243         Refactor TestNetscapePlugin so tests can be split in separate files
2244         https://bugs.webkit.org/show_bug.cgi?id=43220
2245
2246         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2247         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
2248
2249         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2250         (pluginAllocate):
2251         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
2252
2253         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2254         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
2255         (PluginTest::PluginTest):
2256         Initialize m_npp and the test identifier.
2257         
2258         (PluginTest::createTestFunctions):
2259         Return the map from identifiers to createTest functions.
2260
2261         (PluginTest::registerCreateTestFunction):
2262         Insert the identifier and create function pair in the map.
2263
2264         (PluginTest::create):
2265         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
2266
2267         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
2268         (PluginTest::Register::Register):
2269         Helper class template for registering plug-in tests.
2270         
2271         (PluginTest::Register::create):
2272         Create a new test of the given type.
2273
2274         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
2275         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
2276         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
2277
2278         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2279         (NPP_New):
2280         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
2281
2282         (NPP_DestroyStream):
2283         Call the plug-in test NPP_DestroyStream member function.
2284
2285         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2286         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
2287
2288 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
2289
2290         Unreviewed build fix.
2291
2292         Add missing second argument to assert_lint in new style checker tests.
2293
2294         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2295
2296 2010-07-29  Anders Carlsson  <andersca@apple.com>
2297
2298         Reviewed by Adam Roben.
2299
2300         check-webkit-style shouldn't complain about NPAPI functions
2301         https://bugs.webkit.org/show_bug.cgi?id=43211
2302
2303         Allow underscores in functions that start with NPN_, NPP_ or NP_.
2304
2305         * Scripts/webkitpy/style/checkers/cpp.py:
2306         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2307
2308 2010-07-29  Victor Wang  <victorw@chromium.org>
2309
2310         Unreviewed, rolling out r64270.
2311         http://trac.webkit.org/changeset/64270
2312         https://bugs.webkit.org/show_bug.cgi?id=39589
2313
2314         The patch breaks chromium webkit unittest
2315
2316         * DumpRenderTree/LayoutTestController.cpp:
2317         (LayoutTestController::staticFunctions):
2318         * DumpRenderTree/LayoutTestController.h:
2319         * DumpRenderTree/chromium/LayoutTestController.cpp:
2320         (LayoutTestController::LayoutTestController):
2321         * DumpRenderTree/chromium/LayoutTestController.h:
2322         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2323         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2324         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2325         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2326         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2327         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2328         * Scripts/build-webkit:
2329
2330 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2331
2332         Reviewed by Kenneth Christiansen.
2333
2334         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
2335         https://bugs.webkit.org/show_bug.cgi?id=43199
2336
2337         There is no sense in keeping WebPage method definitions in main.cpp once
2338         webpage.cpp already exists.
2339
2340         No behavior change.
2341
2342         * QtTestBrowser/main.cpp:
2343         * QtTestBrowser/webpage.cpp:
2344         (WebPage::createWindow):
2345         (WebPage::createPlugin):
2346
2347 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2348
2349         Reviewed by Kenneth Christiansen.
2350
2351         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
2352         https://bugs.webkit.org/show_bug.cgi?id=43170
2353
2354         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
2355         launcherwindow.{cpp|h}
2356
2357         No behavior change.
2358
2359         Also changed all global static variables (named "gXXX") from main.cpp to
2360         static public variables of the LauncherWindow class.
2361
2362         * QtTestBrowser/QtTestBrowser.pro:
2363         * QtTestBrowser/launcherwindow.cpp: Added.
2364         * QtTestBrowser/launcherwindow.h: Added.
2365         * QtTestBrowser/main.cpp:
2366         (LauncherApplication::handleUserOptions):
2367         (main):
2368
2369 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
2370
2371         Reviewed by Xan Lopez.
2372
2373         Build fix for building against GTK+ 3.x. GSEAL requires that we
2374         access internals of the GdkDragContext via methods. For older versions
2375         of GTK+, define those methods.
2376
2377         * DumpRenderTree/gtk/EventSender.cpp:
2378         (gdk_drag_context_get_selected_action): Added.
2379         (gdk_drag_context_get_actions): Added.
2380         (dispatchEvent): Use the two new accessor methods.
2381
2382 2010-07-29  Adam Roben  <aroben@apple.com>
2383
2384         Always say "plugins directory" when referring to a directory
2385         containing one or more plugins
2386
2387         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
2388         directory" when it means "plugins directory"
2389
2390         Reviewed by John Sullivan.
2391
2392         * WebKitTestRunner/TestController.cpp:
2393         (WTR::TestController::initialize): Updated for rename.
2394
2395 2010-07-29  Adam Roben  <aroben@apple.com>
2396
2397         Always say "directory" when referring to a plugin directory
2398
2399         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
2400         when it means "plugin directory"
2401
2402         Reviewed by John Sullivan.
2403
2404         * WebKitTestRunner/TestController.cpp:
2405         (WTR::TestController::initialize): Updated for renames.
2406
2407         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
2408         m_testPluginDirectory.
2409         (WTR::TestController::testPluginDirectory): Renamed from
2410         testPluginPath.
2411
2412         * WebKitTestRunner/mac/TestControllerMac.mm:
2413         (WTR::TestController::initializeTestPluginDirectory):
2414         * WebKitTestRunner/win/TestControllerWin.cpp:
2415         (WTR::TestController::initializeTestPluginDirectory):
2416         Renamed from initializeTestPluginPath and updated for rename.
2417
2418 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
2419
2420          Reviewed by Antonio Gomes.
2421
2422          Initialize all members of NPClass struct.
2423          https://bugs.webkit.org/show_bug.cgi?id=43193
2424
2425          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2426
2427 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
2428
2429         Reviewed by Antonio Gomes.
2430
2431         Warning fix on platforms where XP_MACOSX is undefined.
2432         https://bugs.webkit.org/show_bug.cgi?id=43192
2433
2434         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2435         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
2436
2437 2010-07-29  Adam Roben  <aroben@apple.com>
2438
2439         Give find-included-framework-headers our standard license
2440
2441         * Scripts/find-included-framework-headers: Used the license from
2442         WebCore/LICENSE-APPLE.
2443
2444 2010-07-29  Adam Roben  <aroben@apple.com>
2445
2446         Speed up find-included-framework-headers
2447
2448         We only do one invocation of find now, no longer pipe to grep, and
2449         replace uniq with sort -u.
2450
2451         Also added a license header.
2452
2453         * Scripts/find-included-framework-headers:
2454
2455 2010-07-29  Steve Block  <steveblock@google.com>
2456
2457         Reviewed by Jeremy Orlow.
2458
2459         Add LayoutTestController methods to test DeviceOrientation
2460         https://bugs.webkit.org/show_bug.cgi?id=39589
2461
2462         * DumpRenderTree/LayoutTestController.cpp:
2463         (setMockDeviceOrientationCallback):
2464         (LayoutTestController::staticFunctions):
2465         * DumpRenderTree/LayoutTestController.h:
2466         * DumpRenderTree/chromium/LayoutTestController.cpp:
2467         * DumpRenderTree/chromium/LayoutTestController.h:
2468         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2469         (LayoutTestController::setMockDeviceOrientation):
2470         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2471         (LayoutTestController::setMockDeviceOrientation):
2472         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2473         (LayoutTestController::setMockDeviceOrientation):
2474         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2475         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2476         (LayoutTestController::setMockDeviceOrientation):
2477         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2478         (LayoutTestController::setMockDeviceOrientation):
2479         * Scripts/build-webkit:
2480
2481 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
2482
2483         Reviewed by Shinichiro Hamaji.
2484
2485         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
2486         check-webkit-style gives false positives in single-line functions.
2487
2488         * Scripts/webkitpy/style/checkers/cpp.py:
2489         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2490
2491 2010-07-28  Darin Adler  <darin@apple.com>
2492
2493         Reviewed by Sam Weinig.
2494
2495         WebKitTestRunner needs to support layoutTestController.execCommand
2496         <https://bugs.webkit.org/show_bug.cgi?id=42538>
2497
2498         WebKitTestRunner needs layoutTestController.isCommandEnabled
2499         <https://bugs.webkit.org/show_bug.cgi?id=42671>
2500
2501         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2502         Added execCommand and isCommandEnabled.
2503         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2504         (WTR::LayoutTestController::execCommand): Added.
2505         (WTR::LayoutTestController::isCommandEnabled): Added.
2506         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2507
2508 2010-07-28  Kent Tamura  <tkent@chromium.org>
2509
2510         Reviewed by Dimitri Glazkov.
2511
2512         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
2513         https://bugs.webkit.org/show_bug.cgi?id=43123
2514
2515         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
2516         which overrides test expectations only for DumpRenderTree, in
2517         order to manage what problems are investigated.
2518         This change will be reverted when we switch to DRT completely.
2519
2520         * Scripts/webkitpy/layout_tests/port/chromium.py:
2521          Add drt_expectations.txt content to the result of
2522          test_expectations_overrides() if --use-drt is specified.
2523
2524 2010-07-28  Brady Eidson  <beidson@apple.com>
2525
2526         Reviewed by Darin Adler.
2527
2528         First pass at visited link support for WK2
2529         https://bugs.webkit.org/show_bug.cgi?id=43157
2530
2531         * MiniBrowser/mac/AppDelegate.m:
2532         (didNavigateWithNavigationData):
2533         (didPerformClientRedirect):
2534         (didPerformServerRedirect):
2535         (didUpdateHistoryTitle):
2536         (populateVisitedLinks): Added for the new version of the HistoryClient.
2537         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
2538         
2539         * MiniBrowser/mac/BrowserWindowController.m:
2540         (-[BrowserWindowController awakeFromNib]):
2541
2542 2010-07-28  Robin Dunn  <robin@alldunn.com>
2543
2544         Reviewed by Kevin Ollivier.
2545
2546         Add DOM bindings support for wx port.
2547
2548         * DumpRenderTree/wscript:
2549         * wx/browser/wscript:
2550         * wx/build/settings.py:
2551
2552 2010-07-28  Tony Chang  <tony@chromium.org>
2553
2554         Reviewed by Kent Tamura.
2555
2556         [chromium] cleanup temp files left by Linux DRT
2557         https://bugs.webkit.org/show_bug.cgi?id=43062
2558
2559         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
2560         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
2561             by crashed DRTs
2562
2563 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
2564
2565         Rubber-stamped by Kenneth Christiansen.
2566
2567         More Developer menu items reordering.
2568
2569         Grouping related menu items together, visually and logically (in the code).
2570
2571         No behavior change.
2572
2573         * QtTestBrowser/main.cpp:
2574         (LauncherWindow::createChrome):
2575
2576 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
2577
2578         Reviewed by Ojan Vafai.
2579
2580         Add FILE_SYSTEM build flag for FileSystem API
2581         https://bugs.webkit.org/show_bug.cgi?id=42915
2582
2583         * Scripts/build-webkit:
2584
2585 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
2586
2587         Reviewed by David Levin.
2588
2589         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
2590         https://bugs.webkit.org/show_bug.cgi?id=43090
2591
2592         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
2593         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
2594
2595 2010-07-27  Kent Tamura  <tkent@chromium.org>
2596
2597         Unreviewed, trivial typo fix.
2598
2599         * Scripts/webkitpy/layout_tests/port/chromium.py:
2600           Fix a wrong method name committed by r64109.
2601
2602 2010-07-27  Sam Weinig  <sam@webkit.org>
2603
2604         Reviewed by Anders Carlsson.
2605
2606         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
2607         Clean up handling of strings at the WebKit2 API layer.
2608
2609         * MiniBrowser/mac/BrowserWindowController.m:
2610         (runJavaScriptAlert):
2611         (runJavaScriptConfirm):
2612         (runJavaScriptPrompt):
2613         (didNavigateWithNavigationData):
2614         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2615         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2616         (_didClearWindowForFrame):
2617
2618 2010-07-27  Ojan Vafai  <ojan@chromium.org>
2619
2620         Reviewed by Eric Seidel.
2621
2622         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
2623         https://bugs.webkit.org/show_bug.cgi?id=42984
2624
2625         squash and no_squash have been intentionally erroring for a couple weeks now.
2626         But post-commits was just broken. Just remove squash/no_squash.
2627
2628         * Scripts/webkitpy/tool/steps/abstractstep.py:
2629         * Scripts/webkitpy/tool/steps/options.py:
2630
2631 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
2632
2633         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
2634
2635         * wx/build/settings.py:
2636
2637 2010-07-27  Adam Roben  <aroben@apple.com>
2638
2639         Mac build fix
2640
2641         * MiniBrowser/mac/BrowserWindowController.m:
2642         (processDidExit):
2643         (-[BrowserWindowController awakeFromNib]):
2644         Added processDidExit support.
2645
2646 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
2647
2648         Rubber-stamped by Simon Hausmann.
2649
2650         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
2651
2652         Move some less useful menu items on Developers menu from the top to the bottom, so
2653         QGraphicsView menu goes to the top, and becomes more quickly accessible.
2654
2655         * QtTestBrowser/main.cpp:
2656         (LauncherWindow::createChrome):
2657
2658 2010-07-26  Adam Roben  <aroben@apple.com>
2659
2660         Fix the path to InjectedBundle.dll in Debug_Internal builds
2661
2662         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
2663         InjectedBundle.dll in the Debug_Internal configuration
2664
2665         Reviewed by Anders Carlsson.
2666
2667         * WebKitTestRunner/win/TestControllerWin.cpp:
2668         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
2669         suffix only in Debug_All builds.
2670
2671 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2672
2673         Reviewed by Darin Adler.
2674
2675         https://bugs.webkit.org/show_bug.cgi?id=42947
2676         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
2677         error. Without which dumpRenderTree crashes.
2678
2679         * Scripts/old-run-webkit-tests:
2680
2681 2010-07-27  Kent Tamura  <tkent@chromium.org>
2682
2683         Reviewed by Dimitri Glazkov.
2684
2685         https://bugs.webkit.org/show_bug.cgi?id=42956
2686         [DRT/Chromium] Fix "out of sync" assertion error
2687
2688         Fix an assertion error on Windows like the following:
2689         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
2690         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2691         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2692
2693         * Scripts/webkitpy/layout_tests/port/chromium.py:
2694         If the url matches with "file:///[a-z]:", does case-ignore comparison.
2695         GURL capitalize the driver letter of a file: URL.
2696
2697 2010-07-26  Darin Adler  <darin@apple.com>
2698
2699         Reviewed by Sam Weinig.
2700
2701         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
2702         https://bugs.webkit.org/show_bug.cgi?id=42537
2703
2704         WebKitTestRunner needs layoutTestController.markerTextForListItem
2705         https://bugs.webkit.org/show_bug.cgi?id=42549
2706
2707         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2708         Fixed _paramterExpression typo. Improved support for string type as a
2709         return value, so we don't try to include DOMString.h and we can convert
2710         the string to a JSValue by calling JSValueMakeStringOrNull.
2711
2712         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2713         Added JSValueMakeStringOrNull, used by the code generator.
2714
2715         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2716         Added counterValueForElementById and markerTextForListItem.
2717
2718         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2719         Moved constant to the top of the file.
2720         (WTR::toCF): Added. Converts strings to CFStringRef.
2721         (WTR::toWK): Added. Converts strings to WKStringRef.
2722         (WTR::toJS): Added. Converts strings to JSStringRef.
2723         (WTR::setProperty): Moved this function to the top of the file
2724         rather than having it down where it's used inside the class. Also
2725         renamed it so it's a separate function rather than an overload of
2726         JSObjectSetProperty.
2727         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
2728         Should move it somewhere we can share it.
2729         (WTR::propertyObject): Ditto.
2730         (WTR::getElementById): Added. Calls getElementById through the magic
2731         of JavaScript.
2732         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2733         Chagned to use toWK instead of four local variables.
2734         (WTR::LayoutTestController::counterValueForElementById): Added.
2735         Calls WKBundleFrameCopyCounterValue.
2736         (WTR::LayoutTestController::markerTextForListItem): Added.
2737         Calls WKBundleFrameCopyMarkerText.
2738
2739         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2740         Added counterValueForElementById and markerTextForListItem.
2741
2742 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
2743
2744         Reviewed by Gustavo Noronha Silva.
2745
2746         [GTK] The EventSender should support simulating drop events
2747         https://bugs.webkit.org/show_bug.cgi?id=39844
2748
2749         Add initial dropping support to the GTK+ EventSender.
2750
2751         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2752         (createWebView): Listen for some new drag-and-drop signals.
2753         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
2754         (dispatchEvent):
2755         Detect situations where a drag is either starting or ending and massage
2756         GTK+ into sending the appropriate signals to the WebView.
2757         (replaySavedEvents): Remove comment.
2758         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
2759         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
2760         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
2761         (dragFailedCallback): Disable the GTK+ drag failed animation.
2762         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
2763
2764 2010-07-26  Daniel Bates  <dbates@rim.com>
2765
2766         Reviewed by Darin Adler.
2767
2768         svn-unapply warns of uninitialized variable when unapplying
2769         a patch that describes an svn move operation
2770         https://bugs.webkit.org/show_bug.cgi?id=42036
2771
2772         Fixes Perl uninitialized variable warnings when un-applying
2773         a patch that moves a file.
2774
2775         * Scripts/svn-unapply:
2776           - Modified patch() so that it initializes $patch to the empty
2777             string when we don't have svnConvertedText (such as when
2778             reversing a diff that represents a svn copy/move operation).
2779
2780 2010-07-26  Sam Weinig  <sam@webkit.org>
2781
2782         Reviewed by Anders Carlsson.
2783
2784         Move some non-APIish functions into private headers.
2785
2786         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2787         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2788
2789 2010-07-26  Sam Weinig  <sam@webkit.org>
2790
2791         Reviewed by Anders Carlsson.
2792
2793         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
2794         Add prompt and confirm client functions to WebKit2
2795
2796         * MiniBrowser/mac/BrowserWindowController.m:
2797         (-[BrowserWindowController awakeFromNib]):
2798
2799 2010-07-26  Adam Roben  <aroben@apple.com>
2800
2801         Windows build fix
2802
2803         * MiniBrowser/MiniBrowser.vcproj:
2804         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2805         Removed empty attributes so the values will be picked up from the
2806         vsprops files. (Also removed a couple of attributes that accidentally
2807         duplicated values from the vsprops files.)
2808
2809 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
2810
2811         Rubber-stamped by Adam Roben.
2812         
2813         Touch MiniBrowser's stdafx to fix the build.
2814
2815         * MiniBrowser/win/stdafx.h:
2816
2817 2010-07-26  Hayato Ito  <hayato@chromium.org>
2818
2819         Reviewed by Shinichiro Hamaji.
2820
2821         Add pretty printer of WTF::Vector for GDB 7.
2822
2823         https://bugs.webkit.org/show_bug.cgi?id=40909
2824
2825         * gdb/wtf.py: Added.
2826
2827 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2828
2829         Reviewed by Simon Hausmann.
2830
2831         [Qt] Fix feature detection regexp
2832
2833         We were missing the last feature
2834
2835         * Scripts/webkitdirs.pm:
2836
2837 2010-07-25  Darin Adler  <darin@apple.com>
2838
2839         Reviewed by Dan Bernstein.
2840
2841         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
2842         https://bugs.webkit.org/show_bug.cgi?id=42326
2843
2844         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2845         Added dumpSelectionRect.
2846
2847         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2848         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
2849         does nothing because its purpose is to change pixel test output and
2850         we do not have pixel tests implemented yet.
2851
2852 2010-07-25  Darin Adler  <darin@apple.com>
2853
2854         Reviewed by Maciej Stachowiak.
2855
2856         WebKitTestRunner needs to support layoutTestController.keepWebHistory
2857         https://bugs.webkit.org/show_bug.cgi?id=42323
2858
2859         Added keepWebHistory and computedStyleIncludingVisitedInfo.
2860
2861         Also fixed misspellings of the word "receive".
2862
2863         Also tweaked the names of some of the LayoutTestController members.
2864
2865         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2866         Added support for a type named "object" that is passed and returns as
2867         a JSValueRef.
2868
2869         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2870         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
2871         put setAcceptsEditing up nearer the top.
2872
2873         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2874         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
2875         (WTR::InjectedBundle::initialize): Ditto.
2876         (WTR::InjectedBundle::didReceiveMessage): Ditto.
2877         (WTR::InjectedBundle::reset): Reset the state of visited links between
2878         tests. Also eliminated the unused argument to the LayoutTestController
2879         create function.
2880         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
2881         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2882
2883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2884         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
2885         instead of acceptsEditing.
2886         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
2887         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
2888         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
2889         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
2890         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
2891         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
2892
2893         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2894         (WTR::LayoutTestController::create): Removed uneeded argument.
2895         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
2896         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
2897         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
2898         about the fact that this works on the main frame.
2899         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
2900         (WTR::LayoutTestController::keepWebHistory): Added.
2901         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
2902         (WTR::JSObjectSetProperty): Added. Helper to make the function below
2903         cleaner.
2904         (WTR::LayoutTestController::makeWindowObject): Changed to use the
2905         overload of JSObjectSetProperty above.
2906
2907         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
2908         match above.
2909
2910         * WebKitTestRunner/TestController.cpp:
2911         (WTR::TestController::initialize): Fixed mispellings of receive.
2912         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
2913         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
2914         * WebKitTestRunner/TestController.h: Ditto.
2915         * WebKitTestRunner/TestInvocation.cpp:
2916         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
2917         * WebKitTestRunner/TestInvocation.h: Ditto.
2918
2919 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
2920
2921         Reviewed by Sam Weinig.
2922
2923         https://bugs.webkit.org/show_bug.cgi?id=42193
2924         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
2925
2926         Step 2 - add the rest of editing delegates.
2927
2928         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2929         (WTR::operator<<): Fixed to not crash when range is null.
2930         (WTR::InjectedBundlePage::InjectedBundlePage):
2931         (WTR::InjectedBundlePage::_shouldEndEditing):
2932         (WTR::InjectedBundlePage::_shouldInsertNode):
2933         (WTR::InjectedBundlePage::_shouldInsertText):
2934         (WTR::InjectedBundlePage::_shouldDeleteRange):
2935         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
2936         (WTR::InjectedBundlePage::_shouldApplyStyle):
2937         (WTR::InjectedBundlePage::_didBeginEditing):
2938         (WTR::InjectedBundlePage::_didEndEditing):
2939         (WTR::InjectedBundlePage::_didChange):
2940         (WTR::InjectedBundlePage::_didChangeSelection):
2941         (WTR::InjectedBundlePage::shouldEndEditing):
2942         (WTR::InjectedBundlePage::shouldInsertNode):
2943         (WTR::InjectedBundlePage::shouldInsertText):
2944         (WTR::InjectedBundlePage::shouldDeleteRange):
2945         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2946         (WTR::InjectedBundlePage::shouldApplyStyle):
2947         (WTR::InjectedBundlePage::didBeginEditing):
2948         (WTR::InjectedBundlePage::didEndEditing):
2949         (WTR::InjectedBundlePage::didChange):
2950         (WTR::InjectedBundlePage::didChangeSelection):
2951         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2952
2953 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
2954
2955         Reviewed by David Kilzer.
2956
2957         AX: need a layout test testing misspelled words in attributed strings
2958         https://bugs.webkit.org/show_bug.cgi?id=42899
2959
2960         * DumpRenderTree/AccessibilityUIElement.cpp:
2961         (attributedStringForRangeCallback):
2962         (attributedStringRangeIsMisspelledCallback):
2963         (AccessibilityUIElement::getJSClass):
2964         * DumpRenderTree/AccessibilityUIElement.h:
2965         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2966         (AccessibilityUIElement::attributedStringForRange):
2967         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2968         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2969         (AccessibilityUIElement::attributedStringForRange):
2970         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2971         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2972         (AccessibilityUIElement::attributedStringForRange):
2973         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2974
2975 2010-07-23  David Kilzer  <ddkilzer@apple.com>
2976
2977         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
2978
2979         Reviewed by Mark Rowe.
2980
2981         * Scripts/check-for-inappropriate-files-in-framework: Added
2982         check for the SHALLOW_BUNDLE environment variable so that the
2983         script will work with iOS WebKit builds.
2984         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
2985
2986 2010-07-22  Darin Adler  <darin@apple.com>
2987
2988         Reviewed by Sam Weinig.
2989
2990         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
2991         https://bugs.webkit.org/show_bug.cgi?id=42847
2992
2993         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2994         (WTR::operator<<): Replaced the WKStringToUTF8 function with
2995         a set of overloaded stream operators.
2996         (WTR::dumpPath): Changed to use ostringstream and return a string.
2997         (WTR::propertyValue): Added.
2998         (WTR::propertyObject): Added.
2999         (WTR::propertyString): Added.
3000         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
3001         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
3002         since we now have suitable streaming functions.
3003         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
3004         WKBundleFrameCopyInnerText.
3005         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
3006         since we now have suitable streaming functions.
3007         (WTR::InjectedBundlePage::dump): Ditto.
3008         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
3009         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
3010         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
3011         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
3012         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
3013
3014 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
3015
3016         Reviewed by Sam Weinig and Darin Adler.
3017
3018         https://bugs.webkit.org/show_bug.cgi?id=42193
3019         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
3020
3021         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
3022         fixed, but this makes difference one line smaller on many editing tests.
3023
3024         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3025         Added dumpEditingCallbacks() and setAcceptsEditing().
3026
3027         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3028         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
3029         (WTR::operator<<): Print a range.
3030         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
3031         clients.
3032         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
3033         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
3034         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
3035         calls.
3036
3037         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3038         (WTR::LayoutTestController::LayoutTestController):
3039         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3040         (WTR::LayoutTestController::dumpEditingCallbacks):
3041         (WTR::LayoutTestController::setAcceptsEditing):
3042         (WTR::LayoutTestController::acceptsEditing):
3043         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
3044         Store m_acceptsEditing and m_dumpEditingCallbacks.
3045
3046 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
3047
3048         Reviewed by Laszlo Gombos.
3049
3050         [Qt] QtWebKit needs public API for Notifications.
3051         https://bugs.webkit.org/show_bug.cgi?id=41413
3052
3053         Update DumpRenderTree and QtTestBrowser to use the new API.
3054         Add new DRT API to flag that notifications permission requests should be ignored.
3055
3056         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3057         (WebCore::WebPage::WebPage):
3058         (WebCore::WebPage::requestPermission):
3059         (WebCore::WebPage::checkPermission):
3060         (WebCore::WebPage::cancelRequestsForPermission):
3061         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3062         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3063         (LayoutTestController::reset):
3064         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
3065         (LayoutTestController::checkDesktopNotificationPermission):
3066         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3067         (LayoutTestController::ignoreReqestForPermission):
3068         * QtTestBrowser/main.cpp:
3069         (LauncherWindow::LauncherWindow):
3070         * QtTestBrowser/webpage.cpp:
3071         (WebPage::WebPage):
3072         (WebPage::requestPermission):
3073         (WebPage::checkPermission):
3074         (WebPage::cancelRequestsForPermission):
3075         * QtTestBrowser/webpage.h:
3076
3077 2010-07-22  Darin Adler  <darin@apple.com>
3078
3079         Reviewed by Sam Weinig.
3080
3081         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
3082         https://bugs.webkit.org/show_bug.cgi?id=42325
3083
3084         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3085         Added dumpChildFramesAsText.
3086
3087         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3088         (WTR::dumpFrameText): Added.
3089         (WTR::dumpDescendantFramesText): Added.
3090         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
3091         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
3092         instead of the shouldDumpAsText function, and added a case for AllFramesText.
3093
3094         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
3095
3096         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3097         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
3098         m_whatToDump.
3099
3100         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
3101         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
3102         and shouldDumpSourceAsWebArchive. Added whatToDump.
3103
3104 2010-07-22  Adam Roben  <aroben@apple.com>
3105
3106         Windows build fix
3107
3108         Inspired by r63881.
3109
3110         * MiniBrowser/MiniBrowser.vcproj:
3111         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3112         Removed pre- and post-build events so they will be inherited from the
3113         vsprops files.
3114
3115 2010-07-21  Darin Adler  <darin@apple.com>
3116
3117         Reviewed by Sam Weinig.
3118
3119         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
3120         https://bugs.webkit.org/show_bug.cgi?id=42548
3121
3122         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3123         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3124         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
3125         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
3126         Changed to a file-internal function instead of a member function.
3127         (WTR::dumpDescendantFrameScrollPositions): Added.
3128         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
3129         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
3130         appropriate. Also streamlined all the WKStringToUTF8 call sites.
3131         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
3132         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
3133         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
3134         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
3135         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
3136
3137         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
3138
3139         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3140         (WTR::LayoutTestController::LayoutTestController): Initialize
3141         m_shouldDumpAllFrameScrollPositions.
3142         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
3143         shouldDumpFrameScrollPositions.
3144
3145         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
3146         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
3147         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
3148
3149 2010-07-21  Darin Adler  <darin@apple.com>
3150
3151         Reviewed by Sam Weinig.
3152
3153         WebKitTestRunner needs to support dumping of scroll position
3154         https://bugs.webkit.org/show_bug.cgi?id=42514
3155
3156         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3157         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
3158
3159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3160         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
3161         instead of JSContextRef.
3162         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
3163         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
3164         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
3165         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
3166         instead of JSContextRef.
3167
3168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
3169         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
3170
3171         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3172         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
3173         returns false.
3174         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
3175         returns false.
3176         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
3177         the logic in DumpRenderTree.
3178
3179         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
3180
3181         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
3182
3183 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
3184
3185         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
3186
3187         * wx/build/settings.py:
3188
3189 2010-07-21  Sam Weinig  <sam@webkit.org>
3190
3191         Reviewed by Anders Carlsson.
3192
3193         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
3194         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
3195
3196         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3197         (WTR::InjectedBundlePage::InjectedBundlePage):
3198         (WTR::InjectedBundlePage::_willAddMessageToConsole):
3199         (WTR::InjectedBundlePage::_willSetStatusbarText):
3200         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
3201         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
3202         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
3203         (WTR::InjectedBundlePage::willAddMessageToConsole):
3204         (WTR::InjectedBundlePage::willSetStatusbarText):
3205         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3206         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3207         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3208         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3209
3210 2010-07-21  Adam Roben  <aroben@apple.com>
3211
3212         Give InjectedBundle our standard set of configurations (minus the
3213         *_Cairo variants)
3214
3215         InjectedBundle's Debug_All configuration was the same as is Debug
3216         configuration, and it was missing a Debug_Internal configuration.
3217
3218         Fixes <http://webkit.org/b/42749> InjectedBundle's build
3219         configurations are screwy
3220
3221         Reviewed by Darin Adler.
3222
3223         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
3224         debug_internal.vsprops and debug_all.vsprops to the Debug_All
3225         configuration. Added a Debug_Internal configuration.
3226
3227         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
3228         variant of InjectedBundle when we're using the Debug_Internal solution
3229         configuration.
3230
3231 2010-07-21  Adam Roben  <aroben@apple.com>
3232
3233         Move InjectedBundle's settings to a vsprops file
3234
3235         This will make it easier to change settings for all configurations,
3236         and to add new configurations.
3237
3238         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
3239         files
3240
3241         Reviewed by Darin Adler.
3242
3243         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
3244         Moved settings here...
3245         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
3246         here.
3247
3248 2010-07-21  Adam Roben  <aroben@apple.com>
3249
3250         Give MiniBrowser our standard set of configurations (minus the *_Cairo
3251         variants)
3252
3253         MiniBrowser already had a configuration called "Release", but it was
3254         using mostly the same settings as Debug. And its Debug configuration
3255         was using the settings that Debug_Internal should be using.
3256
3257         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
3258         are screwy
3259
3260         Reviewed by Darin Adler.
3261
3262         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
3263         the Debug configuration. Remove debug.vsprops and
3264         debug_internal.vsprops from the Release configuration and replace them
3265         with release.vsprops. Added Debug_Internal and Debug_All
3266         configurations.
3267
3268 2010-07-21  Adam Roben  <aroben@apple.com>
3269
3270         Move MiniBrowser's settings to a vsprops file
3271
3272         This will make it easier to change settings for all configurations,
3273         and to add new configurations.
3274
3275         MiniBrowser should use vsprops files
3276         https://bugs.webkit.org/show_bug.cgi?id=42745
3277
3278         Reviewed by Darin Adler.
3279
3280         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
3281         settings here...
3282         * MiniBrowser/MiniBrowser.vcproj: ...from here.
3283
3284 2010-07-21  Adam Roben  <aroben@apple.com>
3285
3286         Fix compiler warnings when building MiniBrowser
3287
3288         Also cleaned up the .vcproj a bit.
3289
3290         Fixes <http://webkit.org/b/42743>.
3291
3292         Reviewed by Darin Adler.
3293
3294         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
3295         already defined in .vsprops files. This also fixes a warning about
3296         /EDITANDCONTINUE being incompatible with /SAFESEH.
3297
3298         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
3299         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
3300         being redefined. (I think this will also get us closer to building
3301         with VC++ Express.)
3302
3303 2010-07-20  Sam Weinig  <sam@webkit.org>
3304
3305         Reviewed by Jon Honeycutt.
3306
3307         Fix obvious typo.
3308
3309         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3310         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
3311
3312 2010-07-20  Tony Chang  <tony@chromium.org>
3313
3314         Reviewed by Kent Tamura.
3315
3316         [chromium] by default, dumpAsText should disable pixel results
3317         https://bugs.webkit.org/show_bug.cgi?id=42715
3318
3319         * DumpRenderTree/chromium/LayoutTestController.cpp:
3320         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
3321
3322 2010-07-20  Adam Roben  <aroben@apple.com>
3323
3324         Windows build fix
3325
3326         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
3327         WebKit.lib instead of the old, dusty WebKit2.lib.
3328
3329 2010-07-20  Adam Roben  <aroben@apple.com>
3330
3331         Stop linking WebKitTestRunner against getopt
3332
3333         Use of getopt was removed in r63700.
3334
3335         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
3336         getopt, but doesn't need to
3337
3338         Reviewed by Sam Weinig.
3339
3340         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
3341         from all configurations.
3342
3343 2010-07-20  Adam Roben  <aroben@apple.com>
3344
3345         Make run-webkit-tests --webkit-test-runner "work" on Windows
3346
3347         WebKitTestRunner crashes on launch, but at least the scripts build and
3348         launch it!
3349
3350         Fixes <http://webkit.org/b/42709> run-webkit-tests
3351         --webkit-test-runner bails with an error on Windows
3352
3353         Reviewed by Anders Carlsson.
3354
3355         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
3356         Windows.
3357         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
3358         projects (from first-built to last-built): FindSafari, ImageDiff,
3359         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
3360
3361 2010-07-20  Adam Roben  <aroben@apple.com>
3362
3363         Change build-webkit back to building WebKit.sln on Windows
3364
3365         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
3366         is being removed.
3367
3368         Rubber-stamped in advance by Steve Falkenburg.
3369
3370         * Scripts/build-webkit:
3371
3372 2010-07-20  Adam Roben  <aroben@apple.com>
3373
3374         Windows build fix
3375
3376         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
3377
3378 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
3379
3380         Reviewed by Geoffrey Garen.
3381
3382         WebScriptObject Should Allow Safely Checking For Key Existence
3383         https://bugs.webkit.org/show_bug.cgi?id=42613
3384
3385         Normal ObjCController workflow for a WebScriptObject test.
3386
3387         * DumpRenderTree/mac/ObjCController.m:
3388         (+[ObjCController isSelectorExcludedFromWebScript:]):
3389         (+[ObjCController webScriptNameForSelector:]):
3390         (-[ObjCController testHasWebScriptKey:]):
3391
3392 2010-07-20  Chris Marrin  <cmarrin@apple.com>
3393
3394         Reviewed by Simon Fraser.
3395
3396         https://bugs.webkit.org/show_bug.cgi?id=42118
3397         Disable compositing/webgl tests if WebGL is not enabled
3398
3399         * Scripts/old-run-webkit-tests:
3400
3401 2010-07-20  Anton Muhin  <antonm@chromium.org>
3402
3403         Reviewed by Darin Adler.
3404
3405         Print additional information about exception if failed to connect to apache (in verbose mode).
3406         https://bugs.webkit.org/show_bug.cgi?id=42627
3407
3408         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3409
3410 2010-07-20  Tony Chang  <tony@chromium.org>
3411
3412         Reviewed by David Levin.
3413
3414         [chromium] only pass --force to gclient sync if explicitly stated
3415         https://bugs.webkit.org/show_bug.cgi?id=42581
3416
3417         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
3418               always pass --force since it's hard to do manual cleanups
3419         * Scripts/update-webkit-chromium: only pass --force if --force is
3420               passed in
3421
3422 2010-07-19  Anders Carlsson  <andersca@apple.com>
3423
3424         Fix build.
3425
3426         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3427         Paths of generated files should be relative to the build product.
3428
3429 2010-07-19  Daniel Bates  <dbates@rim.com>
3430
3431         Reviewed by Adam Roben.
3432
3433         [Win] Implement LayoutTestController::markerTextForListItem()
3434         https://bugs.webkit.org/show_bug.cgi?id=37930
3435
3436         Implements DRT support for markerTextForListItem in the Windows port.
3437
3438         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3439         (LayoutTestController::markerTextForListItem): Implemented.
3440
3441 2010-07-19  Jessie Berlin  <jberlin@apple.com>
3442
3443         Windows build fix. Unreviewed.
3444
3445         * WebKitTestRunner/win/TestControllerWin.cpp:
3446         (WTR::TestController::initializeTestPluginPath):
3447
3448 2010-07-19  Sam Weinig  <sam@webkit.org>
3449
3450         Reviewed by Jon Honeycutt.
3451
3452         Remove dependency on getopt from WebKitTestRunner.
3453
3454         - Simplify options parsing and eliminate unused options.
3455
3456         * WebKitTestRunner/TestController.cpp:
3457         (WTR::TestController::TestController):
3458         (WTR::TestController::initialize):
3459         * WebKitTestRunner/TestController.h:
3460         (WTR::TestController::testPluginPath):
3461         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3462         * WebKitTestRunner/mac/TestControllerMac.mm:
3463         (WTR::TestController::platformInitialize):
3464         (WTR::TestController::initializeTestPluginPath):
3465         * WebKitTestRunner/win/TestControllerWin.cpp:
3466         (WTR::TestController::platformInitialize):
3467         (WTR::TestController::initializeTestPluginPath):
3468
3469 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
3470
3471         Reviewed by Antonio Gomes.
3472
3473         [Qt] MiniBrowser: Progress indication at address bar
3474         https://bugs.webkit.org/show_bug.cgi?id=42565
3475
3476         Make possible to see load progress at address bar based on
3477         QtTestBrowser solution
3478
3479         * MiniBrowser/qt/BrowserWindow.cpp:
3480         (BrowserWindow::BrowserWindow):
3481         (BrowserWindow::loadProgress):
3482         * MiniBrowser/qt/BrowserWindow.h:
3483
3484 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
3485
3486         Reviewed by Antonio Gomes.
3487
3488         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
3489         https://bugs.webkit.org/show_bug.cgi?id=42564
3490
3491         * MiniBrowser/qt/BrowserWindow.cpp:
3492         (BrowserView::load):
3493         (BrowserWindow::BrowserWindow):
3494         (BrowserWindow::titleChanged):
3495         (BrowserWindow::urlChanged):
3496         * MiniBrowser/qt/BrowserWindow.h:
3497
3498 2010-07-19  Sam Weinig  <weinig@apple.com>
3499
3500         Reviewed by Adam Roben.
3501
3502         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
3503         Auto-generate the JS bindings for WebKitTestRunner's script objects.
3504
3505         * WebKitTestRunner/Configurations/Base.xcconfig:
3506         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3507         * WebKitTestRunner/DerivedSources.make: Added.
3508         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
3509         * WebKitTestRunner/InjectedBundle/Bindings: Added.
3510         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
3511         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
3512         (WTR::JSWrappable::~JSWrappable):
3513         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
3514         (WTR::JSWrapper::wrap):
3515         (WTR::JSWrapper::unwrap):
3516         (WTR::unwrapObject):
3517         (WTR::JSWrapper::initialize):
3518         (WTR::JSWrapper::finalize):
3519         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
3520         (WTR::toJS):
3521         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
3522         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3523         (WTR::InjectedBundlePage::dump):
3524         (WTR::InjectedBundlePage::setStatusbarText):
3525         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3526         (WTR::LayoutTestController::wrapperClass):
3527         (WTR::LayoutTestController::waitUntilDone):
3528         (WTR::LayoutTestController::makeWindowObject):
3529         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3530         (WTR::LayoutTestController::shouldDumpAsText):
3531         (WTR::LayoutTestController::dumpAsText):
3532         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
3533         (WTR::LayoutTestController::dumpStatusCallbacks):
3534         (WTR::LayoutTestController::waitToDump):
3535         (WTR::LayoutTestController::testRepaint):
3536         (WTR::LayoutTestController::repaintSweepHorizontally):
3537         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3538         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3539         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
3540         * WebKitTestRunner/win/build-generated-files.sh: Added.
3541
3542 2010-07-19  Mark Rowe  <mrowe@apple.com>
3543
3544         Clean up the buildbot configuration a little.
3545
3546         * BuildSlaveSupport/build.webkit.org-config/config.json:
3547
3548 2010-07-19  Chris Marrin  <cmarrin@apple.com>
3549
3550         Reviewed by Darin Adler.
3551
3552         https://bugs.webkit.org/show_bug.cgi?id=42118
3553         Disable WebGL on Leopard for now. 
3554
3555         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
3556         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
3557         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
3558         software OpenGL driver on machines without this support.
3559
3560         * Scripts/build-webkit:
3561
3562 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
3563
3564         Reviewed by Brady Eidson.
3565
3566         Fix MiniBrowser to update URL as you browse
3567         https://bugs.webkit.org/show_bug.cgi?id=42591
3568         
3569         Hook up various loading notifications to update the URL bar in MiniBrowser.
3570
3571         * MiniBrowser/mac/BrowserWindowController.m:
3572         (_didStartProvisionalLoadForFrame):
3573         (_didReceiveServerRedirectForProvisionalLoadForFrame):
3574         (_didFailProvisionalLoadWithErrorForFrame):
3575         (_didCommitLoadForFrame):
3576         (_didFailLoadWithErrorForFrame):
3577         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3578         (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
3579         (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
3580         (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
3581         (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
3582         (-[BrowserWindowController didCommitLoadForFrame:]):
3583
3584 2010-07-19  Alexey Proskuryakov  <ap@apple.com>
3585
3586         Reviewed by Darin Adler.
3587
3588         https://bugs.webkit.org/show_bug.cgi?id=42586
3589         Log all canceled authentication attempts in DumpRenderTree
3590
3591         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3592         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3593         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3594         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3595         It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
3596         case.
3597
3598 2010-07-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3599
3600         Unreviewed, rolling out r63671.
3601         http://trac.webkit.org/changeset/63671
3602         https://bugs.webkit.org/show_bug.cgi?id=42575
3603
3604         broke windows (Requested by weinig on #webkit).
3605
3606         * WebKitTestRunner/Configurations/Base.xcconfig:
3607         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3608         * WebKitTestRunner/DerivedSources.make: Removed.
3609         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
3610         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
3611         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
3612         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
3613         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
3614         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
3615         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3616         (WTR::InjectedBundlePage::dump):
3617         (WTR::InjectedBundlePage::setStatusbarText):
3618         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3619         (WTR::LayoutTestController::setWaitToDump):
3620         (WTR::displayCallback):
3621         (WTR::dumpAsTextCallback):
3622         (WTR::dumpStatusCallbacksCallback):
3623         (WTR::waitUntilDoneCallback):
3624         (WTR::notifyDoneCallback):
3625         (WTR::numberOfActiveAnimationsCallback):
3626         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
3627         (WTR::repaintSweepHorizontallyCallback):
3628         (WTR::testRepaintCallback):
3629         (WTR::layoutTestControllerObjectFinalize):
3630         (WTR::LayoutTestController::makeWindowObject):
3631         (WTR::LayoutTestController::getJSClass):
3632         (WTR::LayoutTestController::staticFunctions):
3633         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3634         (WTR::LayoutTestController::dumpAsText):
3635         (WTR::LayoutTestController::setDumpAsText):
3636         (WTR::LayoutTestController::dumpStatusCallbacks):
3637         (WTR::LayoutTestController::setDumpStatusCallbacks):
3638         (WTR::LayoutTestController::setTestRepaint):
3639         (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
3640         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3641
3642 2010-07-19  Sam Weinig  <sam@webkit.org>
3643
3644         Reviewed by Adam Roben.
3645
3646         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
3647         Auto-generate the JS bindings for WebKitTestRunner's script objects.
3648
3649         * WebKitTestRunner/Configurations/Base.xcconfig:
3650         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3651         * WebKitTestRunner/DerivedSources.make: Added.
3652         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
3653         * WebKitTestRunner/InjectedBundle/Bindings: Added.
3654         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
3655         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
3656         (WTR::JSWrappable::~JSWrappable):
3657         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
3658         (WTR::JSWrapper::wrap):
3659         (WTR::JSWrapper::unwrap):
3660         (WTR::unwrapObject):
3661         (WTR::JSWrapper::initialize):
3662         (WTR::JSWrapper::finalize):
3663         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
3664         (WTR::toJS):
3665         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
3666         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3667         (WTR::InjectedBundlePage::dump):
3668         (WTR::InjectedBundlePage::setStatusbarText):
3669         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3670         (WTR::LayoutTestController::wrapperClass):
3671         (WTR::LayoutTestController::waitUntilDone):
3672         (WTR::LayoutTestController::makeWindowObject):
3673         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3674         (WTR::LayoutTestController::shouldDumpAsText):
3675         (WTR::LayoutTestController::dumpAsText):
3676         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
3677         (WTR::LayoutTestController::dumpStatusCallbacks):