bbc2693813c3f3a7338ebacf6f4966f51cdceadb
[WebKit.git] / WebKitTools / ChangeLog
1 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2
3         Reviewed by Martin Robinson.
4
5         [GTK] Add HTTP caching support
6         https://bugs.webkit.org/show_bug.cgi?id=44261
7
8         Ignore new soup API that we decided to merge into the soup backend
9         while it is being cooked. It follows the libsoup style, and will
10         be removed from WebKit as soon as it is merged into libsoup.
11
12         * Scripts/webkitpy/style/checker.py:
13
14 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
15
16         Reviewed by Kenneth Rohde Christiansen.
17
18         [Qt] DumpRenderTree runs only one test from command mode
19         https://bugs.webkit.org/show_bug.cgi?id=44012
20
21         Enables support to run multiple test files and single
22         folder containing html files in stand alone mode
23
24         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
25         (WebCore::DumpRenderTree::DumpRenderTree):
26         (WebCore::DumpRenderTree::processArgsLine):
27         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
28         (WebCore::DumpRenderTree::processLine):
29         (WebCore::DumpRenderTree::dump):
30         * DumpRenderTree/qt/DumpRenderTreeQt.h:
31         (WebCore::DumpRenderTree::setStandAloneMode):
32         (WebCore::DumpRenderTree::isStandAloneMode):
33         * DumpRenderTree/qt/main.cpp:
34         (main):
35
36 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
37
38         Updating webkitpy test expectations.
39
40         * Scripts/webkitpy/tool/steps/steps_unittest.py:
41
42 2010-08-25  Ojan Vafai  <ojan@chromium.org>
43
44         Reviewed by Eric Seidel.
45
46         fix the always squash git config
47         https://bugs.webkit.org/show_bug.cgi?id=44651
48
49         Fix help text and apparently underscores are not allowed
50         in git config keys.
51
52         * Scripts/webkitpy/common/checkout/scm.py:
53         * Scripts/webkitpy/tool/steps/commit.py:
54
55 2010-08-25  Darin Adler  <darin@apple.com>
56
57         Reviewed by John Sullivan.
58
59         * Scripts/commit-log-editor: Fix perl warning for people who have no
60         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
61
62 2010-08-25  Ojan Vafai  <ojan@chromium.org>
63
64         Reviewed by Eric Seidel.
65
66         stop blocking commits when the bots are red
67         https://bugs.webkit.org/show_bug.cgi?id=44644
68
69         This check currently is just annoying. It doesn't actually
70         help keep the tree green. We can always add it back later
71         if we decide the tree is generally more green.
72
73         * Scripts/webkitpy/tool/commands/download_unittest.py:
74         * Scripts/webkitpy/tool/mocktool.py:
75         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
76
77 2010-08-25  Eric Seidel  <eric@webkit.org>
78
79         Reviewed by Simon Fraser.
80
81         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
82         https://bugs.webkit.org/show_bug.cgi?id=38912
83
84         I know of nothing else to do but skip all media tests for the cq.
85
86         * Scripts/webkitpy/tool/steps/runtests.py:
87
88 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
89
90         Reviewed by Ojan Vafai.
91
92         new-run-webkit-tests: add more unit tests for test_expectations
93         This adds unit tests to cover (almost?) all of the non-rebaselining
94         functionality.
95
96         https://bugs.webkit.org/show_bug.cgi?id=44579
97
98         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
99         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
100
101 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
102
103         Reviewed by Ojan Vafai.
104
105         new-run-webkit-tests: add more unit tests
106
107         This change adds more unit tests for the image_diff, test_failures,
108         and test_files modules, bringing them to 100% coverage (and adds a
109         couple tests to run_webkit_tests while we're at it).
110
111         This test also turns on the "dryrun" port for testing when run on
112         the mac, increasing coverage in a few other places.
113
114         https://bugs.webkit.org/show_bug.cgi?id=44578
115
116         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
117         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
118         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
119         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
120         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
121         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
122         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
123         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
124         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
125         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
126         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
127         * Scripts/webkitpy/layout_tests/port/test.py:
128         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
129
130 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
131
132         Reviewed by Ojan Vafai.
133
134         new-run-webkit-tests: add more unit tests for layout_package/printing.py
135
136         This change adds more unit tests to get the test coverage to 100%
137         for the printing module. This code is actually pretty crufty and
138         has some layering violations that need to be cleaned up but I'll
139         save that for another CL after we get all the unit tests written and
140         we fix the multithreading issues. At least now we'll be able to tell
141         if we break things.
142
143         https://bugs.webkit.org/show_bug.cgi?id=44576
144
145         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
146         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
147
148 2010-08-25  Ojan Vafai  <ojan@chromium.org>
149
150         Reviewed by Adam Barth.
151
152         new-run-webkit-tests should respect set-webkit-configuration
153         https://bugs.webkit.org/show_bug.cgi?id=44633
154
155         Moves the getting of the configuration into the base Port so that
156         chromium ports use it as well. In the downstream chromium port,
157         this should still just return Release.
158
159         * Scripts/webkitpy/layout_tests/port/base.py:
160         * Scripts/webkitpy/layout_tests/port/webkit.py:
161
162 2010-08-25  Tony Chang  <tony@chromium.org>
163
164         Not reviewed, changing svn props for a script.
165
166         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
167
168 2010-08-25  Adam Barth  <abarth@webkit.org>
169
170         Reviewed by Eric Seidel.
171
172         Remove WebKit2 from core builders
173         https://bugs.webkit.org/show_bug.cgi?id=44625
174
175         This builder was added to the core builders by accident.  It doesn't
176         appear to be green enough to be a core builder yet.
177
178         * Scripts/webkitpy/common/net/buildbot.py:
179         * Scripts/webkitpy/common/net/buildbot_unittest.py:
180
181 2010-08-19  Adam Roben  <aroben@apple.com>
182
183         Test that NP_Initialize and NP_GetEntryPoints are called in the
184         correct order
185
186         The order differs between Mac and Windows (see r38858).
187
188         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
189         NP_Initialize when loading QuickTime when running
190         plugins/embed-attributes-setting.html in WebKit2 on Windows
191
192         Reviewed by John Sullivan.
193
194         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
195         a boolean to record whether NP_GetEntryPoints has been called.
196         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
197         called yet. This matches Flash and QuickTime's behavior.
198         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
199         yet. This matches Silverlight's behavior.
200
201 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
202
203         Reviewed by Gustavo Noronha Silva.
204
205         Cairo and EFL port shouldn't depend on glib.
206         https://bugs.webkit.org/show_bug.cgi?id=44354
207
208         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
209         adoptPlatformRef.
210
211         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
212         (AccessibilityUIElement::isSelected):
213
214 2010-08-25  Ojan Vafai  <ojan@chromium.org>
215
216         Fix order of Timothy's email address. The script, and
217         other tools all assume that the first email is the bugzilla address.
218
219         * Scripts/webkitpy/common/config/committers.py:
220
221 2010-08-24  Kent Tamura  <tkent@chromium.org>
222
223         Reviewed by Pavel Feldman.
224
225         [DRT/Chromium] Fix 26 inspector test crashes
226         https://bugs.webkit.org/show_bug.cgi?id=44580
227
228         - DRTDevToolsAgent has a reference to the main WebView. So we
229           should not clear it in closeDevTools() and should clear it in
230           ~TestShell().
231         - DRTDevToolsClient has a reference to a DevTools WebView and no
232           way to update it. So we should delete DRTDevToolsClient instances
233           in closeDevTools().
234
235         * DumpRenderTree/chromium/TestShell.cpp:
236         (TestShell::~TestShell):
237         (TestShell::closeDevTools):
238
239 2010-08-24  Eric Seidel  <eric@webkit.org>
240
241         Reviewed by Adam Barth.
242
243         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
244         https://bugs.webkit.org/show_bug.cgi?id=44584
245
246         * Scripts/webkitpy/tool/commands/queues_unittest.py:
247
248 2010-08-24  Eric Seidel  <eric@webkit.org>
249
250         Reviewed by Adam Barth.
251
252         commit-queue and EWS bots should report all failures
253         https://bugs.webkit.org/show_bug.cgi?id=41820
254
255         Right now commit-queue/EWS only report failures when the
256         patch under testing fails.  We should report all failures
257         to the status server so that we can diagnose when the bots
258         are wedged w/o needing to log into the machines.
259
260         I also reduced the amount of data we upload since we've seen
261         timeouts during status upload.
262
263         * Scripts/webkitpy/common/system/executive.py:
264         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
265         * Scripts/webkitpy/tool/commands/queues.py:
266         * Scripts/webkitpy/tool/commands/queues_unittest.py:
267
268 2010-08-24  Eric Seidel  <eric@webkit.org>
269
270         Reviewed by Adam Barth.
271
272         Remove HTML5 parser testing infrastructure now that we don't need it
273         https://bugs.webkit.org/show_bug.cgi?id=44581
274
275         * DumpRenderTree/mac/DumpRenderTree.mm:
276         (resetDefaultsToConsistentValues):
277         (initializeGlobalsFromCommandLineOptions):
278         * Scripts/old-run-webkit-tests:
279         * Scripts/test-html5-parser: Removed.
280
281 2010-08-24  Kent Tamura  <tkent@chromium.org>
282
283         Reviewed by Dimitri Glazkov.
284
285         [DRT/Chromium] Fix 28 inspector test crashes
286         https://bugs.webkit.org/show_bug.cgi?id=44574
287
288         Reset DevToolsClient and DevToolsAgent before closing a DevTools
289         WebView in order to avoid accessing to a deleted WebView instance.
290
291         * DumpRenderTree/chromium/TestShell.cpp:
292         (TestShell::closeDevTools):
293
294 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
295
296         Reviewed by Ojan Vafai.
297
298         new-run-webkit-tests: clean up code for test_types, test_failures
299
300         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
301         webkitpy.layout_tests.layout_package.test_failures, and remove
302         some dead code and otherwise clean up things.
303
304         https://bugs.webkit.org/show_bug.cgi?id=44559
305
306         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
307         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
308         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
309         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
310         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
311         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
312         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
313
314 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
315
316         Reviewed by Eric Seidel.
317
318         new-run-webkit-tests: revise unit testing strategy for test failures
319     
320         This change revamps the way we store test data for new-run-webkit-tests.
321         Previously we had a few copies of test files from the main test tree.
322         Now we have a bunch of completely fake test data and use the test
323         data to generate different kinds of test failures, getting
324         much better coverage.
325
326         https://bugs.webkit.org/show_bug.cgi?id=44556
327
328         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
329         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
330         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
331         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
332         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
333         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
334         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
335         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
336         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
337         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
338         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
339         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
340         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
341         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
342         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
343         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
344         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
345         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
346         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
347         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
348         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
349         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
350         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
351         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
352         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
353         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
354         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
355         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
356         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
357         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
358         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
359         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
360         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
361         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
362         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
363         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
364         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
365         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
366         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
367         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
368         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
369         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
370         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
371         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
372         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
373         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
374         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
375         * Scripts/webkitpy/layout_tests/port/test.py:
376         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
377         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
378
379 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
380
381         Reviewed by Eric Seidel.
382
383         speed up new-run-webkit-tests unit tests
384
385         Add a --no-record-results flag that turns off generating the JSON
386         results file on every test run. Generating the file requires us to
387         fetch the old results down from the bots, which can be slow. This
388         flag is off by default.
389     
390         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
391     
392         These changes together shorten the test cycle from ~4.5s to ~1.5s
393         - a 3x speedup.
394
395         https://bugs.webkit.org/show_bug.cgi?id=44553
396
397         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
398         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
399
400 2010-08-24  Tony Chang  <tony@chromium.org>
401
402         Reviewed by Eric Seidel.
403
404         [chromium] fix the platform result fallback order on mac/win
405         https://bugs.webkit.org/show_bug.cgi?id=44483
406
407         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
408
409 2010-08-24  Xan Lopez  <xlopez@igalia.com>
410
411         Reviewed by Martin Robinson.
412
413         Set a device to the event struct when building with GTK+ 3.x, it's
414         mandatory.
415
416         * DumpRenderTree/gtk/EventSender.cpp:
417         (keyDownCallback):
418
419 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
420
421         Reviewed by Xan Lopez.
422
423         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
424         https://bugs.webkit.org/show_bug.cgi?id=44534
425
426         Fix two double-frees introduced in my previous commit.
427
428         * DumpRenderTree/gtk/EventSender.cpp:
429         (contextClickCallback): Copy the event before using it again.
430         (keyDownCallback): Ditto.
431
432 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
433
434         Reviewed by Xan Lopez.
435
436         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
437         https://bugs.webkit.org/show_bug.cgi?id=44534
438
439         * DumpRenderTree/gtk/EventSender.cpp:
440         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
441         when setting it on the event. It is dereferenced by gdk_event_free(...).
442         (contextClickCallback): Ditto.
443         (mouseDownCallback): Ditto.
444         (mouseUpCallback): Ditto.
445         (mouseMoveToCallback): Ditto.
446         (mouseWheelToCallback): Ditto.
447         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
448         (dispatchEvent): Ditto. Also free the event when we are done with it.
449         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
450
451 2010-08-24  Andras Becsi  <abecsi@webkit.org>
452
453         [Qt] WebKit2 build fix.
454
455         * Scripts/enumerate-included-framework-headers:
456         Remove stray global option form sed.
457
458 2010-08-24  Kent Tamura  <tkent@chromium.org>
459
460         Reviewed by Jeremy Orlow.
461
462         [DRT/Chromium] Support for IndexedDB tests
463         https://bugs.webkit.org/show_bug.cgi?id=44490
464
465         * DumpRenderTree/chromium/TestShell.cpp:
466         (TestShell::TestShell): Enable IndexedDB.
467
468 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
469
470         Reviewed by Gustavo Noronha Silva.
471
472         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
473         https://bugs.webkit.org/show_bug.cgi?id=44465
474
475         Initialize the axes field of mouse button and motion events to null.
476         This is the value that should be used for events originating from the
477         mouse device.
478
479         * DumpRenderTree/gtk/EventSender.cpp:
480         (prepareMouseButtonEvent): Initalize button event axes field to null.
481         (mouseMoveToCallback): Initialize motion event axes field to null.
482
483 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
484
485         Unreviewed, rolling out r65703.
486         http://trac.webkit.org/changeset/65703
487         https://bugs.webkit.org/show_bug.cgi?id=44460
488
489         "Causing lots of crashes on Snow Leopard when running the
490         layout tests" (Requested by eseidel2 on #webkit).
491
492         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
493         (NP_Initialize):
494         (NP_GetEntryPoints):
495
496 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
497
498         Layout tests do not run when using WebKitTestRunner in a Debug build.
499         https://bugs.webkit.org/show_bug.cgi?id=44409
500
501         Reviewed by Dan Bernstein.
502
503         * WebKitTestRunner/win/TestControllerWin.cpp:
504         (WTR::TestController::initializeInjectedBundlePath):
505         Use InjectedBundle_debug.dll when building Debug.
506
507 2010-08-23  Xan Lopez  <xlopez@igalia.com>
508
509         Reviewed by Martin Robinson.
510
511         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
512         https://bugs.webkit.org/show_bug.cgi?id=42026
513
514         If a GTK+ 3.x build is present return that as the library to use,
515         otherwise fallback to the GTK+ 2.x build.
516
517         * Scripts/webkitdirs.pm:
518
519 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
520
521         Reviewed by Ariya Hidayat.
522
523         [Qt] Find needed forwarding headers for WebKit2 automatically
524         https://bugs.webkit.org/show_bug.cgi?id=44336
525
526         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
527         The new script does not satisfy the needs of this file however using normal includes
528         is generally better here.
529         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
530         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
531         given frameworks by files in the current directory (and subdirectories).
532         In the future this needs to be rewritten in perl for being able to use on Windows.
533
534 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
535
536         Reviewed by Ariya Hidayat.
537
538         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
539         https://bugs.webkit.org/show_bug.cgi?id=43010
540
541         * QtTestBrowser/launcherwindow.cpp:
542         (LauncherWindow::applyPrefs):
543         * QtTestBrowser/main.cpp:
544         (LauncherApplication::handleUserOptions):
545
546 2010-08-21  Sam Weinig  <sam@webkit.org>
547
548         Reviewed by Dan Bernstein.
549
550         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
551         https://bugs.webkit.org/show_bug.cgi?id=44386
552
553         * MiniBrowser/mac/AppDelegate.m:
554         (didRecieveMessageFromInjectedBundle):
555         (didNavigateWithNavigationData):
556         (-[BrowserAppDelegate init]):
557         (-[BrowserAppDelegate applicationWillTerminate:]):
558         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
559         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
560         (-[BrowserStatisticsWindowController dealloc]):
561         * MiniBrowser/mac/BrowserWindowController.m:
562         (-[BrowserWindowController initWithPageNamespace:]):
563         (-[BrowserWindowController fetch:]):
564         (-[BrowserWindowController windowWillClose:]):
565         (-[BrowserWindowController applicationTerminating]):
566         (closePage):
567         (runJavaScriptAlert):
568         (runJavaScriptConfirm):
569         (runJavaScriptPrompt):
570         (-[BrowserWindowController updateProvisionalURLForFrame:]):
571         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
572         (didClearWindowObjectForFrame):
573         * MiniBrowser/win/BrowserView.cpp:
574         (BrowserView::goToURL):
575         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
576         (WTR::PlatformWebView::~PlatformWebView):
577
578 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
579
580         Reviewed by Kenneth Rohde Christiansen.
581
582         WebKit does not build with Python 2.3
583         https://bugs.webkit.org/show_bug.cgi?id=44373
584
585         Replaced the function sorted() by a call to sort()
586         on the entry list.
587         The function sorted() has been added to Python 2.4.
588         The function method sort() of List works with older
589         versions of Python.
590
591         * Scripts/create-html-entity-table:
592
593 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
594
595         Reviewed by Pavel Feldman.
596
597         Web Inspector: Inspector tests were disabled for GTK.
598         https://bugs.webkit.org/show_bug.cgi?id=43977
599
600         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
601         path before running tests.
602
603 2010-08-20  Daniel Bates  <dbates@rim.com>
604
605         Reviewed by Eric Seidel.
606
607         svn-apply doesn't detect empty line with Windows line endings
608         after property value
609         https://bugs.webkit.org/show_bug.cgi?id=43981
610
611         Part 2 of 2
612
613         Add unit tests that were not landed in the first commit.
614
615         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
616           - Added the following test cases:
617             "SVN: binary file (isBinary true) using Windows line endings"
618             "SVN: property diff, followed by file change diff using Windows line endings"
619             "SVN: two consecutive property diffs using Windows line endings"
620             "SVN: binary file with executable bit change usng Windows line endings"
621             "SVN: binary file followed by property change on different file using Windows line endings"
622             "SVN: binary file followed by file change on different file using Windows line endings"
623             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
624             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
625         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
626           - Added the following test cases:
627             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
628             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
629             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
630             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
631             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
632             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
633             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
634             "single-line '+' with trailing new line using Windows line endings"
635             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
636             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
637             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
638         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
639           - Added the following test cases:
640             "single-line '-' change followed by empty line with Windows line endings"
641             "multi-line '+' change and start of binary patch with Windows line endings"
642
643 2010-08-20  Daniel Bates  <dbates@rim.com>
644
645         Reviewed by Eric Seidel.
646
647         svn-apply doesn't detect empty line with Windows line endings
648         after property value
649         https://bugs.webkit.org/show_bug.cgi?id=43981
650
651         Fixes an issue where an empty line following the property value
652         in an SVN property change diff would not be detected if it had
653         Windows line endings (i.e. ended in CRLF). Hence it was consumed
654         as if it was part of a multi-line property value. 
655
656         * Scripts/VCSUtils.pm:
657           - Modified parseSvnPropertyValue() to detect empty line
658             with Windows line endings.
659           - Added toWindowsLineEndings().
660         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
661           - Added the following test cases:
662             "SVN: binary file (isBinary true) using Windows line endings"
663             "SVN: property diff, followed by file change diff using Windows line endings"
664             "SVN: two consecutive property diffs using Windows line endings"
665             "SVN: binary file with executable bit change usng Windows line endings"
666             "SVN: binary file followed by property change on different file using Windows line endings"
667             "SVN: binary file followed by file change on different file using Windows line endings"
668             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
669             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
670         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
671           - Added the following test cases:
672             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
673             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
674             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
675             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
676             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
677             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
678             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
679             "single-line '+' with trailing new line using Windows line endings"
680             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
681             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
682             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
683         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
684           - Added the following test cases:
685             "single-line '-' change followed by empty line with Windows line endings"
686             "multi-line '+' change and start of binary patch with Windows line endings"
687
688 2010-08-19  David Kilzer  <ddkilzer@apple.com>
689
690         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
691
692         * MiniBrowser/mac/BrowserWindowController.m:
693         (decidePolicyForNavigationAction): Updated method signature.
694         (decidePolicyForNewWindowAction): Updated method signature.
695
696 2010-08-19  Adam Roben  <aroben@apple.com>
697
698         Test that NP_Initialize and NP_GetEntryPoints are called in the
699         correct order
700
701         The order differs between Mac and Windows (see r38858).
702
703         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
704         NP_Initialize when loading QuickTime when running
705         plugins/embed-attributes-setting.html in WebKit2 on Windows
706
707         Reviewed by Sam Weinig.
708
709         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
710         a boolean to record whether NP_GetEntryPoints has been called.
711         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
712         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
713         if NP_GetEntryPoints has been called already. This matches
714         Silverlight's behavior.
715
716 2010-08-19  Adam Roben  <aroben@apple.com>
717
718         Make build-webkittestrunner build TestNetscapePlugIn on Windows
719
720         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
721
722         Reviewed by Sam Weinig.
723
724         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
725         Threaded it in between ImageDiff and InjectedBundleGenerated.
726
727 2010-08-19  Ojan Vafai  <ojan@chromium.org>
728
729         Reviewed by Adam Barth.
730
731         install rietveld's upload script from a versioned url
732         https://bugs.webkit.org/show_bug.cgi?id=44291
733
734         autoinstall expects the file at a given URL to never change.
735         In order to be able to update the file, we need to be able to
736         change the path.
737
738         * Scripts/webkitpy/thirdparty/__init__.py:
739
740 2010-08-19  Ojan Vafai  <ojan@chromium.org>
741
742         Reviewed by Adam Barth.
743
744         add --webkit_patch_id to reitveld uploads
745         https://bugs.webkit.org/show_bug.cgi?id=44289
746
747         This is the first step in having rietveld store which
748         patches have been uploaded and getting rid of the
749         in-rietveld flag.
750
751         * Scripts/webkitpy/common/net/rietveld.py:
752         * Scripts/webkitpy/tool/mocktool.py:
753         * Scripts/webkitpy/tool/steps/postcodereview.py:
754
755 2010-08-19  Kenneth Russell  <kbr@google.com>
756
757         Reviewed by David Levin.
758
759         Adjust my status from committer to reviewer
760         https://bugs.webkit.org/show_bug.cgi?id=44277
761
762         * Scripts/webkitpy/common/config/committers.py:
763
764 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
765
766         Reviewed by Yury Semikhatsky.
767
768         Chromium DevTools: remove injected script fetcher from test harness.
769         https://bugs.webkit.org/show_bug.cgi?id=44266
770
771         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
772         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
773
774 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
775
776         Reviewed by Yury Semikhatsky.
777
778         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
779         Now that we populate front-end after its onload handler, we don't need
780         to install injected script early. Exposing injected script source on the WebCore
781         level here.
782         https://bugs.webkit.org/show_bug.cgi?id=44029
783
784         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
785         (DRTDevToolsAgent::runtimePropertyChanged):
786         (DRTDevToolsAgent::delayedFrontendLoaded):
787         (DRTDevToolsAgent::frontendLoaded):
788         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
789
790 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
791
792         Reviewed by Kenneth Rohde Christiansen.
793
794         [Gtk] Enable view mode media feature layout test
795         https://bugs.webkit.org/show_bug.cgi?id=43278
796
797         Add view mode media feature testing infrastructure, and add
798         placeholder methods for the other platforms'
799         LayoutTestControllers.
800
801         * DumpRenderTree/LayoutTestController.cpp:
802         (setViewModeMediaFeatureCallback):
803         (LayoutTestController::staticFunctions):
804         * DumpRenderTree/LayoutTestController.h:
805         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
806         (LayoutTestController::setViewModeMediaFeature):
807         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
808         (LayoutTestController::setViewModeMediaFeature):
809         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
810         (LayoutTestController::setViewModeMediaFeature):
811         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
812         (LayoutTestController::setViewModeMediaFeature):
813
814 2010-08-18  Mark Rowe  <mrowe@apple.com>
815
816         Reviewed by Sam Weinig.
817
818         Make it so the WebKit2 test slave runs the WebKit2 tests
819
820         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
821
822 2010-08-18  Sam Weinig  <sam@webkit.org>
823
824         Reviewed by Mark Rowe.
825
826         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
827         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
828         module and the TestNetscapePlugin.
829
830         * Scripts/old-run-webkit-tests:
831
832 2010-08-18  Adam Roben  <aroben@apple.com>
833
834         Fix hang when saving crash logs on Windows
835
836         * Scripts/old-run-webkit-tests:
837         (setUpWindowsCrashLogSaving):
838         (END):
839         Pass -s to regtool so it will write the Auto value as a string instead
840         of as a number. This was causing a "do you want to debug?" dialog to
841         appear.
842
843 2010-08-17  Victor Wang  <victorw@chromium.org>
844
845         Unreviewed. Fixed chromium incremental test json upload.
846         Quote builder name and test results server in url.
847
848         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
849
850 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
851
852         Reviewed by Ariya Hidayat.
853
854         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
855         https://bugs.webkit.org/show_bug.cgi?id=44124
856
857         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
858         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
859         Symbian dependencies.
860
861         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
862         (WebCore::DumpRenderTree::open):
863         * QtTestBrowser/launcherwindow.cpp:
864         (LauncherWindow::init):
865         (LauncherWindow::toggleFullScreenMode):
866         (LauncherWindow::showFPS):
867         (LauncherWindow::updateFPS):
868         * QtTestBrowser/launcherwindow.h:
869         (WindowOptions::WindowOptions):
870         * QtTestBrowser/mainwindow.cpp:
871         (MainWindow::buildUI):
872
873 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
874
875         Reviewed by David Levin.
876
877         new-run-webkit-tests: remove --show-sources option
878
879         --show-sources is pretty much obsolete with --trace everything, so
880         I'm removing it.
881
882         Also rename a couple of methods in the TestTextDiff class to make their
883         intended visibility (private) more obvious.
884
885         https://bugs.webkit.org/show_bug.cgi?id=44143
886
887         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
888         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
889         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
890         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
891         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
892
893 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
894
895         Reviewed by David Levin.
896
897         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
898
899         This code bit-rotted at some point more than a year ago, and nobody seems
900         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
901         should support instead, making this flag unnecessary anyway.
902
903         https://bugs.webkit.org/show_bug.cgi?id=44141
904
905         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
906         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
907         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
908
909 2010-08-17  Victor Wang  <victorw@chromium.org>
910
911         Reviewed by Ojan Vafai.
912
913         Update json results generator to have incremental json including
914         results for tests that pass in current run but failed before.
915
916         https://bugs.webkit.org/show_bug.cgi?id=44119
917
918         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
919         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
920         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
921
922 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
923
924         Reviewed by Eric Seidel.
925
926         fix test-webkitpy, add easy way to find a checkout root
927
928         test-webkitpy currently doesn't work right if run from someplace other
929         than the checkout root, and it spews a bunch of debug logging because
930         the deduplicate_tests tests contaminates the test environment.
931
932         This patch cleans up the deduplicate_tests unit tests, and creates
933         two new methods in scm.py: find_checkout_root() and default_scm(),
934         both of which use a single algorithm for guessing what checkout root
935         to use if you aren't explicitly told one from a path.
936
937         https://bugs.webkit.org/show_bug.cgi?id=44001
938
939         * Scripts/deduplicate-tests:
940         * Scripts/webkitpy/common/checkout/scm.py:
941         * Scripts/webkitpy/common/checkout/scm_unittest.py:
942         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
943         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
944         * Scripts/webkitpy/layout_tests/port/test.py:
945         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
946         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
947         * Scripts/webkitpy/tool/main.py:
948
949 2010-08-17  Victor Wang  <victorw@chromium.org>
950
951         Reviewed by Ojan Vafai.
952
953         Add support to the test results server for downloading json that
954         contains test list only.
955
956         This is for json results generator to generate incremental json
957         results so that it includes results not only for tests failed in
958         current run, but also tests failed before.
959
960         Also set the results type to "N" (no data) instead of "P" (pass)
961         if test results cannot be found in incremental json file.
962
963         https://bugs.webkit.org/show_bug.cgi?id=44117
964
965         * TestResultServer/handlers/testfilehandler.py:
966         * TestResultServer/model/jsonresults.py:
967         * TestResultServer/model/jsonresults_unittest.py:
968
969 2010-08-17  Adam Roben  <aroben@apple.com>
970
971         Use the right path style
972
973         * Scripts/old-run-webkit-tests:
974
975 2010-08-17  Adam Roben  <aroben@apple.com>
976
977         Fix typo
978
979         * Scripts/old-run-webkit-tests:
980
981 2010-08-17  Adam Roben  <aroben@apple.com>
982
983         Don't hang when running run-webkit-tests as a non-Administrator on
984         Vista/7
985
986         * Scripts/old-run-webkit-tests:
987         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
988         post-mortem debugger, rather than using NTSD itself. The latter waits
989         for user input when it fails to set the registry values; the former
990         does not.
991
992 2010-08-17  Adam Roben  <aroben@apple.com>
993
994         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
995         save crash logs on Windows
996
997         The crash logs are saved to /tmp/layout-test-results and have names
998         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
999
1000         Unfortunately, crashes in the WebKit2 web process are recorded as
1001         time-outs by run-webkit-tests. Fixing this is covered by
1002         <http://webkit.org/b/44121>.
1003
1004         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
1005         DumpRenderTree should save a stack trace and/or dump file when it
1006         crashes
1007
1008         Reviewed by Sam Weinig.
1009
1010         * DumpRenderTree/win/DumpRenderTree.cpp:
1011         (exceptionFilter):
1012         (main):
1013         * WebKitTestRunner/win/TestControllerWin.cpp:
1014         (WTR::exceptionFilter):
1015         (WTR::TestController::platformInitialize):
1016         These changes set up an exception filter that prints #CRASHED to
1017         stderr, then lets the exception propagate normally. This allows
1018         run-webkit-tests to detect when we've crashed even when a post-mortem
1019         debugger attaches to the process.
1020
1021         * Scripts/old-run-webkit-tests:
1022         (top level): Declared some variables used by the crash-log-saving
1023         code.
1024         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
1025         that the post-mortem debugger has access to it.
1026         (toCygwinPath): Added. This is the opposite of toWindowsPath.
1027         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
1028         stderr, consider it a crash.
1029         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
1030         debugger, then sets ntsd as the post-mortem debugger. ntsd is
1031         configured to save a crash log and then quit automatically.
1032         (END): Added. Restores the previous post-mortem debugger when the
1033         script exits.
1034
1035 2010-08-17  Victor Wang  <victorw@chromium.org>
1036
1037         Reviewed by ojan@chromium.org.
1038
1039         Update test results server:
1040         1. Normalize test results and times after merging (prune tests where
1041            all runs pass or do not have data, truncate all test items to max
1042            number of builds)
1043         2. times should be int not string.
1044         3. when inserting a new test item, should keep old data regardless
1045            whether or not they have same item type with new one.
1046
1047         https://bugs.webkit.org/show_bug.cgi?id=43861
1048
1049         * TestResultServer/model/jsonresults.py:
1050         * TestResultServer/model/jsonresults_unittest.py:
1051
1052 2010-08-16  Sam Weinig  <sam@webkit.org>
1053
1054         Reviewed by Mark Rowe.
1055
1056         Add WebKit2 Mac tester to buildbot.
1057
1058         * BuildSlaveSupport/build.webkit.org-config/config.json:
1059         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1060
1061 2010-08-16  Paul Sawaya  <psawaya@apple.com>
1062
1063         Reviewed by Chris Marrin.
1064
1065         Added shader validation via ANGLE
1066         https://bugs.webkit.org/show_bug.cgi?id=42405
1067
1068         Added ANGLE to webkit build
1069
1070         * Scripts/build-webkit:
1071
1072 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
1073
1074         [wx] Build fix, do not build WebCore as a convenience library as this leads to
1075         errors in the Win build w/export symbols and causes problems with DOM bindings
1076         debugging in gdb.
1077
1078         * DumpRenderTree/wscript:
1079         * Scripts/build-webkit:
1080         * wx/browser/wscript:
1081         * wx/build/settings.py:
1082         * wx/build/waf_extensions.py:
1083
1084 2010-08-16  Dan Bernstein  <mitz@apple.com>
1085
1086         Build fix.
1087
1088         * WebKitTestRunner/TestController.cpp:
1089         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
1090         (WTR::TestController::initialize): Ditto.
1091
1092 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1093
1094         Reviewed by Kenneth Rohde Christiansen.
1095
1096         Handle content size change in WebKit2
1097         Re-landing after fix.
1098
1099         https://bugs.webkit.org/show_bug.cgi?id=43198
1100
1101         * MiniBrowser/mac/BrowserWindowController.m:
1102         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1103         * MiniBrowser/win/BrowserView.cpp:
1104         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1105
1106 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1107
1108         Unreviewed, rolling out r65419.
1109         http://trac.webkit.org/changeset/65419
1110         https://bugs.webkit.org/show_bug.cgi?id=44053
1111
1112         Broke the Windows build (Requested by bbandix on #webkit).
1113
1114         * MiniBrowser/mac/BrowserWindowController.m:
1115         (-[BrowserWindowController awakeFromNib]):
1116         * MiniBrowser/win/BrowserView.cpp:
1117         (BrowserView::create):
1118
1119 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1120
1121         Reviewed by Kenneth Rohde Christiansen.
1122
1123         Handle content size change in WebKit2
1124
1125         https://bugs.webkit.org/show_bug.cgi?id=43198
1126
1127         * MiniBrowser/mac/BrowserWindowController.m:
1128         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1129         * MiniBrowser/win/BrowserView.cpp:
1130         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1131
1132 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
1133
1134         Add my new email address to committers.py.
1135
1136         * Scripts/webkitpy/common/config/committers.py:
1137
1138 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
1139
1140         Add my old e-mail addresses to committers.py.
1141
1142         * Scripts/webkitpy/common/config/committers.py:
1143
1144 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1145
1146         WebEditorClient::didBeginEditing is never called in WebKit2
1147         https://bugs.webkit.org/show_bug.cgi?id=42939
1148
1149         Reviewed by Sam Weinig.
1150
1151         * WebKitTestRunner/PlatformWebView.h:
1152         Declare focus().
1153
1154         * WebKitTestRunner/TestController.cpp:
1155         (WTR::TestController::resetStateToConsistentValues):
1156         Focus the PlatformWebView.
1157
1158         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1159         (WTR::PlatformWebView::focus):
1160         Stubbed.
1161
1162         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1163         (WTR::PlatformWebView::focus):
1164         Focus the view.
1165
1166 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1167
1168         run-webkit-tests should not strip editing callbacks when using
1169         WebKitTestRunner on Windows
1170         https://bugs.webkit.org/show_bug.cgi?id=44000
1171
1172         Reviewed by Mark Rowe.
1173
1174         * Scripts/old-run-webkit-tests:
1175         Leave $stripEditingCallbacks undefined until we look for command-line
1176         arguments. If using WebKit2, set it to 0 if not explicity set on the
1177         command line. Later, set it to isCygwin() to match old behavior if it is
1178         not yet defined.
1179
1180 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
1181
1182         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
1183
1184         * wx/build/settings.py:
1185
1186 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
1187
1188         Reviewed by Kenneth Rohde Christiansen.
1189
1190         [GTK] autogen.sh not executed if build-webkit options change
1191         https://bugs.webkit.org/show_bug.cgi?id=42266
1192
1193         Rerun autogen.sh in situations where the arguments to build-webkit have
1194         changed since the previous build. This will fix some issues on the bots
1195         where the build does not notice changes to default build-webkit arguments.
1196
1197         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
1198
1199 2010-08-14  Eric Seidel  <eric@webkit.org>
1200
1201         Unreviewed.  Another fix to support python 2.3.
1202
1203         Add support for MathML entities
1204         https://bugs.webkit.org/show_bug.cgi?id=43949
1205
1206         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
1207          - It looks like our simplejson is version 1.7.3 which
1208            should be python 2.3 compatible.  But someone modified
1209            our copy slightly from the original source.
1210            I've removed the relative import in hopes this fixes
1211            the problem.
1212
1213 2010-08-13  Eric Seidel  <eric@webkit.org>
1214
1215         Unreviewed.  Build fix only.
1216
1217         Add support for MathML entities
1218         https://bugs.webkit.org/show_bug.cgi?id=43949
1219
1220         * Scripts/create-html-entity-table:
1221          - Hack sys.path to avoid executing 2.5 dependent python
1222            on systems (like chromium-win and Tiger) which do not have 2.5 python.
1223
1224 2010-08-13  Adam Barth  <abarth@webkit.org>
1225
1226         Reviewed by Eric Seidel.
1227
1228         Rename some concepts in HTML entity search to be more self-documenting
1229         https://bugs.webkit.org/show_bug.cgi?id=44004
1230
1231         Reflect name change in generator script.
1232
1233         * Scripts/create-html-entity-table:
1234
1235 2010-08-12  Adam Barth  <abarth@webkit.org>
1236
1237         Reviewed by Eric Seidel.
1238
1239         Add support for MathML entities
1240         https://bugs.webkit.org/show_bug.cgi?id=43949
1241
1242         A script for generating the C++ state data structure describing all the
1243         entities from a JSON description.
1244
1245         * Scripts/create-html-entity-table: Added.
1246
1247 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
1248
1249         Reviewed by Eric Seidel.
1250
1251         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
1252         check for exceptions on all threads, not just the first thread.
1253         
1254         This change also changes the logging behavior for wedged threads
1255         to only dump the stacks of threads that are actually wedged.
1256
1257         Refactor the thread classes in the dump_render_tree_thread module
1258         to make the contract between TestRunner and TestShellThread clearer.
1259
1260         Added a bunch of unit tests.
1261         https://bugs.webkit.org/show_bug.cgi?id=38561
1262
1263         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1264         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1265         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1266
1267 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
1268
1269         Reviewed by Shinichiro Hamaji.
1270
1271         Add test_expectations.txt syntax checker to check-webkit-style.
1272         https://bugs.webkit.org/show_bug.cgi?id=43899
1273
1274         Just utilizing layout_tests/layout_package/test_expectations.py for checking
1275         the syntax of test_expectations.txt.
1276         This change also moves tab checking class from style/checkers/text.py to
1277         style/checkers/common.py for sharing code.
1278
1279         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1280         * Scripts/webkitpy/style/checker.py:
1281         * Scripts/webkitpy/style/checkers/common.py:
1282         * Scripts/webkitpy/style/checkers/common_unittest.py:
1283         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
1284         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
1285         * Scripts/webkitpy/style/checkers/text.py:
1286         * Scripts/webkitpy/style_references.py:
1287
1288 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1289
1290         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
1291         https://bugs.webkit.org/show_bug.cgi?id=43945
1292
1293         Reviewed by Sam Weinig.
1294
1295         * WebKitTestRunner/TestInvocation.cpp:
1296         (WTR::sizeWebViewForCurrentTest):
1297         Allow for a Windows-style path.
1298
1299         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1300         (WTR::PlatformWebView::resizeTo):
1301         Call SetWindowPos to resize the view window.
1302
1303 2010-08-12  David Levin  <levin@chromium.org>
1304
1305         Build break fix.
1306
1307         * WebKitTestRunner/TestController.cpp:
1308         (WTR::TestController::resetStateToConsistentValues): Removed usage
1309         of a variable that doesn't exist in the class.
1310
1311 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1312
1313         WebKitTestRunner needs to run tests without using native controls
1314         https://bugs.webkit.org/show_bug.cgi?id=43772
1315
1316         Reviewed by Sam Weinig.
1317
1318         * WebKitTestRunner/TestController.cpp:
1319         (WTR::TestController::initialize):
1320         Call platformInitializeContext().
1321
1322         * WebKitTestRunner/TestController.h:
1323         Declare platformInitializeContext().
1324
1325         * WebKitTestRunner/mac/TestControllerMac.mm:
1326         (WTR::TestController::platformInitializeContext):
1327         Stubbed.
1328
1329         * WebKitTestRunner/win/TestControllerWin.cpp:
1330         (WTR::TestController::platformInitializeContext):
1331         Call WKContextSetShouldPaintNativeControls() to disable native control
1332         drawing.
1333
1334 2010-08-12  Sam Weinig  <sam@webkit.org>
1335
1336         Reviewed by Alexey Proskuryakov.
1337
1338         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
1339         https://bugs.webkit.org/show_bug.cgi?id=43653
1340
1341         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1342         (WTR::InjectedBundle::InjectedBundle):
1343         (WTR::InjectedBundle::didReceiveMessage):
1344         (WTR::InjectedBundle::beginTesting):
1345         (WTR::InjectedBundle::done):
1346         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1347         (WTR::InjectedBundle::isTestRunning):
1348         (WTR::InjectedBundle::):
1349         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1350         (WTR::InjectedBundlePage::stopLoading):
1351         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1352         (WTR::InjectedBundlePage::dump):
1353         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1354         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1355         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1356         (WTR::InjectedBundlePage::didClearWindowForFrame):
1357         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1358         (WTR::InjectedBundlePage::willAddMessageToConsole):
1359         (WTR::InjectedBundlePage::willSetStatusbarText):
1360         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1361         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1362         (WTR::InjectedBundlePage::shouldBeginEditing):
1363         (WTR::InjectedBundlePage::shouldEndEditing):
1364         (WTR::InjectedBundlePage::shouldInsertNode):
1365         (WTR::InjectedBundlePage::shouldInsertText):
1366         (WTR::InjectedBundlePage::shouldDeleteRange):
1367         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1368         (WTR::InjectedBundlePage::shouldApplyStyle):
1369         (WTR::InjectedBundlePage::didBeginEditing):
1370         (WTR::InjectedBundlePage::didEndEditing):
1371         (WTR::InjectedBundlePage::didChange):
1372         (WTR::InjectedBundlePage::didChangeSelection):
1373         Don't do any work if we are not currently running a test.
1374
1375         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1376         * WebKitTestRunner/StringFunctions.h:
1377         (WTR::toCF):
1378         Add conversion function for WKURLRef -> CFURLRef
1379
1380         * WebKitTestRunner/TestController.cpp:
1381         (WTR::TestController::TestController):
1382         (WTR::TestController::initialize):
1383         (WTR::TestController::resetStateToConsistentValues):
1384         (WTR::TestController::runTest):
1385         (WTR::TestController::didFinishLoadForFrame):
1386         * WebKitTestRunner/TestController.h:
1387         (WTR::TestController::):
1388         * WebKitTestRunner/TestInvocation.cpp:
1389         (WTR::TestInvocation::invoke):
1390         * WebKitTestRunner/TestInvocation.h:
1391         Move resetting code to TestController.
1392
1393         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1394         * WebKitTestRunner/mac/TestControllerMac.mm:
1395         (WTR::TestController::runUntil):
1396         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1397         * WebKitTestRunner/win/TestControllerWin.cpp:
1398         (WTR::TestController::runUntil):
1399         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
1400         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1401         Move runUntil to TestController.
1402
1403 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1404
1405         Unreviewed.
1406
1407         Adding myself to the committers list.
1408
1409         * Scripts/webkitpy/common/config/committers.py:
1410
1411 2010-08-12  Hayato Ito  <hayato@chromium.org>
1412
1413         Reviewed by Tony Chang.
1414
1415         Merge pretty printers for gdb.
1416         https://bugs.webkit.org/show_bug.cgi?id=43850
1417
1418         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
1419         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
1420         webcore.py is left for backward compatibility.
1421
1422         * gdb/webcore.py:
1423         * gdb/webkit.py: Added.
1424         * gdb/wtf.py: Removed.
1425
1426 2010-08-11  Tony Chang  <tony@chromium.org>
1427
1428         Reviewed by David Levin.
1429
1430         [chromium] add google-chrome layout test result directories
1431         https://bugs.webkit.org/show_bug.cgi?id=43889
1432
1433         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1434         * Scripts/webkitpy/layout_tests/port/factory.py:
1435         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
1436         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1437
1438 2010-08-11  Kent Tamura  <tkent@chromium.org>
1439
1440         Reviewed by Dimitri Glazkov.
1441
1442         [DRT/Chromium] Disable accelerated compositing
1443         https://bugs.webkit.org/show_bug.cgi?id=43894
1444
1445         Disable accelerated compositing because DRT is not ready for
1446         it. This change fixes hundreds of test crashes on Windows and
1447         Linux.
1448
1449         * DumpRenderTree/chromium/TestShell.cpp:
1450         (TestShell::resetWebSettings):
1451
1452 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1453
1454         Unreviewed. Adding my Collabora personality to the list.
1455
1456         * Scripts/webkitpy/common/config/committers.py:
1457
1458 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
1459
1460         Adding myself as a reviewer.
1461
1462         * Scripts/webkitpy/common/config/committers.py:
1463
1464 2010-08-11  Daniel Bates  <dbates@rim.com>
1465
1466         Reviewed by Darin Adler.
1467
1468         Perl warnings when running commit-log-editor
1469         https://bugs.webkit.org/show_bug.cgi?id=43856
1470
1471         Fixes Perl warnings introduced by the patch for Bug #40548.
1472
1473         Perl doesn't have symbolic names for True/False. Instead, we
1474         should use boolean values. Moreover, the variable installedEditorApplication
1475         is not be used and should be renamed builtEditorApplication so that it
1476         uses the existing machinery to set the commit log editor application.
1477
1478         * Scripts/commit-log-editor:
1479
1480 2010-08-11  Adam Barth  <abarth@webkit.org>
1481
1482         Reviewed by Eric Seidel.
1483
1484         Trying waiting for httpd lock in the EWS
1485         https://bugs.webkit.org/show_bug.cgi?id=43833
1486
1487         If this works, we can probably run the tests on the mac-ews, which
1488         would be very exciting.  :)
1489
1490         * Scripts/webkitpy/tool/steps/runtests.py:
1491
1492 2010-08-11  Marcus Bulach  <bulach@chromium.org>
1493
1494         Reviewed by Eric Seidel.
1495
1496         Check in a script to list redundant test outputs.
1497         https://bugs.webkit.org/show_bug.cgi?id=37630
1498
1499         If e.g. platform/mac-leopard is missing an expected test output, we
1500         fall back on platform/mac.  This means it's possible to grow redundant
1501         test outputs, where we have the same expected data in both a platform
1502         directory and another platform it falls back on.
1503         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
1504
1505         * Scripts/deduplicate-tests: Added.
1506         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
1507         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
1508
1509 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1510
1511         Reviewed by Ariya Hidayat.
1512
1513         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
1514         https://bugs.webkit.org/show_bug.cgi?id=43853
1515
1516         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
1517         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
1518         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
1519         to slots at all.
1520
1521         * QtTestBrowser/launcherwindow.cpp:
1522         (LauncherWindow::createChrome):
1523         (LauncherWindow::animatedFlip):
1524         (LauncherWindow::animatedYFlip):
1525         * QtTestBrowser/launcherwindow.h:
1526
1527 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1528
1529         Reviewed by Simon Hausmann.
1530
1531         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
1532         https://bugs.webkit.org/show_bug.cgi?id=43851
1533
1534         All window options data (including the bool holding if the view is either QWebView or
1535         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
1536         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
1537         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
1538         getting broken.
1539
1540         Patch addresses this issue.
1541
1542         * QtTestBrowser/launcherwindow.cpp:
1543         (LauncherWindow::createChrome):
1544         (LauncherWindow::toggleWebView):
1545         (LauncherWindow::toggleAcceleratedCompositing):
1546
1547 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
1548
1549         Reviewed by Ariya Hidayat.
1550
1551         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
1552         https://bugs.webkit.org/show_bug.cgi?id=43831
1553
1554         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
1555
1556         * QtTestBrowser/webview.cpp:
1557         (WebViewGraphicsBased::WebViewGraphicsBased):
1558         (WebViewGraphicsBased::animatedYFlip):
1559
1560 2010-08-11  Darin Adler  <darin@apple.com>
1561
1562         Reviewed by John Sullivan.
1563
1564         Improved editor options for prepare-ChangeLog and commit-log-editor
1565         https://bugs.webkit.org/show_bug.cgi?id=40548
1566
1567         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
1568         values like "xed --launch --wait" work properly.
1569
1570         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
1571         use a command line tool with the $openChangeLogs feature.
1572
1573 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
1574
1575         Reviewed by Pavel Feldman.
1576
1577         Web Inspector: remove InjectDispatch.js
1578         https://bugs.webkit.org/show_bug.cgi?id=43835
1579
1580         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1581         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1582
1583 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
1584
1585         Reviewed by Eric Seidel.
1586
1587         webkit-patch should refuse to run under Win32 Python
1588         https://bugs.webkit.org/show_bug.cgi?id=40962
1589
1590         Given that there are lots of places in webkit-patch's code that
1591         assume unix-style filenames (forward slashes), webkit-patch fails
1592         with weird file-not-found errors when run under a native windows
1593         Python. It would be nice if we just trapped this and errored out
1594         at the beginning, rather than producing unpredictable errors.
1595
1596         * Scripts/webkit-patch:
1597
1598 2010-08-10  Kent Tamura  <tkent@chromium.org>
1599
1600         Unreviewed, build fix.
1601         
1602         Chromium build fix for r65107.
1603
1604         * DumpRenderTree/chromium/LayoutTestController.cpp:
1605         (LayoutTestController::suspendAnimations):
1606         (LayoutTestController::resumeAnimations):
1607
1608 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
1609
1610         Reviewed by Xan Lopez.
1611
1612         [GTK] http/tests/media/video-cookie.html fails
1613         https://bugs.webkit.org/show_bug.cgi?id=42240
1614
1615         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1616         (LayoutTestController::setAlwaysAcceptCookies): create the
1617         SoupCookieJar if it does not exist. Otherwise the accept policy
1618         won't be set.
1619
1620 2010-08-10  Chris Marrin  <cmarrin@apple.com>
1621
1622         Reviewed by Oliver Hunt.
1623
1624         Add suspendAnimations/resumeAnimation API to DRT
1625         https://bugs.webkit.org/show_bug.cgi?id=43733
1626         
1627         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
1628         Calls functions with the same names on AnimationController for the 
1629         mainFrame.
1630
1631         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1632         * DumpRenderTree/LayoutTestController.cpp:
1633         (suspendAnimationsCallback):
1634         (resumeAnimationsCallback):
1635         (LayoutTestController::staticFunctions):
1636         * DumpRenderTree/LayoutTestController.h:
1637         * DumpRenderTree/chromium/LayoutTestController.cpp:
1638         (LayoutTestController::LayoutTestController):
1639         (LayoutTestController::suspendAnimations):
1640         (LayoutTestController::resumeAnimations):
1641         * DumpRenderTree/chromium/LayoutTestController.h:
1642         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1643         (LayoutTestController::suspendAnimations):
1644         (LayoutTestController::resumeAnimations):
1645         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1646         (LayoutTestController::suspendAnimations):
1647         (LayoutTestController::resumeAnimations):
1648         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1649         (LayoutTestController::suspendAnimations):
1650         (LayoutTestController::resumeAnimations):
1651         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1652         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1653         (LayoutTestController::suspendAnimations):
1654         (LayoutTestController::resumeAnimations):
1655         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1656         (LayoutTestController::suspendAnimations):
1657         (LayoutTestController::resumeAnimations):
1658
1659 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1660
1661         Reviewed by Ojan Vafai.
1662
1663         [Chromium/DRT] Enable saving layout test results.
1664         https://bugs.webkit.org/show_bug.cgi?id=43796
1665
1666         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
1667             parameters to the new-run-webkit-tests, including the name
1668             of the test results server.
1669
1670 2010-08-10  Jian Li  <jianli@chromium.org>
1671
1672         More chromium build fix.
1673
1674         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1675         (MockSpellCheck::spellCheckWord):
1676         (MockSpellCheck::initializeIfNeeded):
1677         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1678         (NotificationPresenter::grantPermission):
1679         (NotificationPresenter::show):
1680         (NotificationPresenter::checkPermission):
1681
1682 2010-08-10  Jian Li  <jianli@chromium.org>
1683
1684         Chromium build fix.
1685
1686         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1687         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1688
1689 2010-08-10  Victor Wang  <victorw@chromium.org>
1690
1691         Reviewed by Ojan Vafai.
1692
1693         Update test results server merge logic so the aggregated
1694         results and times are updated for tests that are
1695         in aggragated json but not in incremental json.
1696
1697         Also update unittest to test this case.
1698
1699         https://bugs.webkit.org/show_bug.cgi?id=43769
1700
1701         * TestResultServer/model/jsonresults.py:
1702         * TestResultServer/model/jsonresults_unittest.py:
1703
1704 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1705
1706         Reviewed by Ariya Hidayat.
1707
1708         [Qt] QtTestBrowser: proper set scene rect
1709
1710         When resizesToContents is ON scene's rect is set to the boundary of
1711         the mainFrame. However, navigating to other web page should keep resizing
1712         scene's rect according to the new document loaded. Patch addresses this issue.
1713
1714         Now resizesToContents and scrolling properly work on QtTestBrowser.
1715
1716         * QtTestBrowser/webview.cpp:
1717         (WebViewGraphicsBased::setPage):
1718         (WebViewGraphicsBased::contentsSizeChanged):
1719         (WebViewGraphicsBased::setResizesToContents):
1720         (WebViewGraphicsBased::resizeEvent):
1721         * QtTestBrowser/webview.h:
1722
1723 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1724
1725         Reviewed by Ariya Hidayat.
1726
1727         [Qt] QtTestBrowser: Clean up LauncherWindow code.
1728
1729         * QtTestBrowser/launcherwindow.cpp:
1730         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
1731         (LauncherWindow::init): Fixed comments.
1732         (LauncherWindow::applyPrefs): Move the method around.
1733         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
1734
1735 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1736
1737         Reviewed by Ariya Hidayat.
1738
1739         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
1740
1741         It gets control+0 the same visual effect as control++ or control-.
1742
1743         * QtTestBrowser/launcherwindow.cpp:
1744         (LauncherWindow::toggleZoomTextOnly):
1745
1746 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1747
1748         Reviewed by Ariya Hidayat.
1749
1750         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
1751
1752         Not all instances of LauncherWindow need its own m_zoomLevel.
1753
1754         * QtTestBrowser/launcherwindow.cpp:
1755         * QtTestBrowser/launcherwindow.h:
1756
1757 2010-08-09  Sam Weinig  <sam@webkit.org>
1758
1759         Reviewed by Geoffrey Garen.
1760
1761         Add zoom support for injected bundle
1762         https://bugs.webkit.org/show_bug.cgi?id=43759
1763
1764         Use zoom factor SPI to implement zoom related eventSender functions.
1765
1766         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1767         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1768         (WTR::EventSendingController::textZoomIn):
1769         (WTR::EventSendingController::textZoomOut):
1770         (WTR::EventSendingController::zoomPageIn):
1771         (WTR::EventSendingController::zoomPageOut):
1772         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1773         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1774         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
1775
1776 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
1777
1778         Speculative chromium build fix III.
1779
1780         * DumpRenderTree/chromium/MockSpellCheck.h:
1781         * DumpRenderTree/chromium/NotificationPresenter.h:
1782         * DumpRenderTree/chromium/WebViewHost.h:
1783         (WebViewHost::addClearHeader):
1784         (WebViewHost::clearHeaders):
1785
1786 2010-08-09  Ojan Vafai  <ojan@chromium.org>
1787
1788         Reviewed by Tony Chang.
1789
1790         increase the number of test results that we save
1791         https://bugs.webkit.org/show_bug.cgi?id=43763
1792
1793         Now that we do incremental uploads, we can increase the number of
1794         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
1795
1796         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1797
1798 2010-08-09  Evan Martin  <evan@chromium.org>
1799
1800         Reviewed by Tony Chang.
1801
1802         [chromium] DRT error print statement incorrectly tries to print a FILE*
1803         https://bugs.webkit.org/show_bug.cgi?id=43747
1804
1805         * DumpRenderTree/chromium/ImageDiff.cpp:
1806         (writeFile): pass the correct pointer.
1807
1808 2010-08-09  Victor Wang  <victorw@chromium.org>
1809
1810         Reviewed by Ojan Vafai.
1811
1812         Upload incremental test results json to server by default.
1813
1814         https://bugs.webkit.org/show_bug.cgi?id=43743
1815
1816         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1817
1818 2010-08-09  Eric Seidel  <eric@webkit.org>
1819
1820         Reviewed by Adam Barth.
1821
1822         EWS bots wait 2 minutes between patches
1823         https://bugs.webkit.org/show_bug.cgi?id=43731
1824
1825         * Scripts/webkitpy/tool/bot/queueengine.py:
1826          - Don't sleep after failures.  This was a hold-over from
1827            an earlier design.
1828         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1829          - EWS bots were not properly reporting true/false from process_work_item.
1830            They were always returning None, thus false, thus always logging
1831            as a failure and sleeping 2 minutes after each patch.
1832
1833 2010-08-09  Sam Weinig  <sam@webkit.org>
1834
1835         Reviewed by Anders Carlsson.
1836
1837         Stub out EventSender for WebKitTestRunner
1838         https://bugs.webkit.org/show_bug.cgi?id=43703
1839
1840         * WebKitTestRunner/DerivedSources.make:
1841         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1842         Add ability to pass javascript arguments to the wrapped object.
1843
1844         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
1845         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
1846         (WTR::EventSendingController::create):
1847         (WTR::EventSendingController::EventSendingController):
1848         (WTR::EventSendingController::~EventSendingController):
1849         (WTR::EventSendingController::wrapperClass):
1850         (WTR::setExceptionForString):
1851         (WTR::EventSendingController::mouseDown):
1852         (WTR::EventSendingController::mouseUp):
1853         (WTR::EventSendingController::mouseMoveTo):
1854         (WTR::EventSendingController::keyDown):
1855         (WTR::EventSendingController::contextClick):
1856         (WTR::EventSendingController::leapForward):
1857         (WTR::EventSendingController::textZoomIn):
1858         (WTR::EventSendingController::textZoomOut):
1859         (WTR::EventSendingController::zoomPageIn):
1860         (WTR::EventSendingController::zoomPageOut):
1861         (WTR::EventSendingController::makeWindowObject):
1862         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
1863         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1864         (WTR::InjectedBundle::reset):
1865         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1866         (WTR::InjectedBundle::eventSendingController):
1867         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1868         (WTR::InjectedBundlePage::didClearWindowForFrame):
1869         Add stubbed out EventSenderController.
1870
1871         * WebKitTestRunner/InjectedBundle/GCController.h:
1872         Remove incorrect comment.
1873
1874         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1875         * WebKitTestRunner/win/InjectedBundle.vcproj:
1876         Add new files.
1877
1878 2010-08-08  Kent Tamura  <tkent@chromium.org>
1879
1880         Unreviewed, trivial fix.
1881
1882         Fix "WindowsError: [Error 32] The process cannot access the file
1883         because it is being used by another process" introduced by r64959.
1884
1885         * BuildSlaveSupport/test-result-archive:
1886
1887 2010-08-08  Kent Tamura  <tkent@chromium.org>
1888
1889         Reviewed by Tony Chang.
1890
1891         Chromium buildbot: Avoid "zip" command dependency
1892         https://bugs.webkit.org/show_bug.cgi?id=43470
1893
1894         * BuildSlaveSupport/test-result-archive:
1895          For Chromium port, creates a zip archive with zipfile package of Python
1896          instead of external "zip" command. We'd like to avoid additional
1897          command installation.
1898
1899 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
1900
1901         WebKitTestRunner should add the QuickTime dir to the PATH environment
1902         variable
1903         https://bugs.webkit.org/show_bug.cgi?id=43686
1904
1905         Reviewed by Dan Bernstein.
1906
1907         * WebKitTestRunner/win/TestControllerWin.cpp:
1908         (WTR::addQTDirToPATH):
1909         Copied from DRT.
1910         (WTR::TestController::platformInitialize):
1911         Call addQTDirToPath().
1912         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1913         Link to shlwapi.lib for SHGetValue.
1914
1915 2010-08-07  Sam Weinig  <sam@webkit.org>
1916
1917         Reviewed by Maciej Stachowiak.
1918
1919         WebKitTestRunner needs layoutTestController.dumpTitleChanges
1920         <rdar://problem/8213861>
1921         https://bugs.webkit.org/show_bug.cgi?id=42683
1922
1923         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1924         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1925         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1926         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1927         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1928         (WTR::LayoutTestController::LayoutTestController):
1929         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1930         (WTR::LayoutTestController::dumpTitleChanges):
1931         (WTR::LayoutTestController::shouldDumpTitleChanges):
1932
1933 2010-08-07  Sam Weinig  <sam@webkit.org>
1934
1935         Reviewed by Anders Carlsson.
1936
1937         WebKitTestRunner needs to print onunload handler information
1938         <rdar://problem/8213831>
1939         https://bugs.webkit.org/show_bug.cgi?id=42703
1940
1941         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1942         (WTR::operator<<):
1943         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1944
1945 2010-08-07  Sam Weinig  <sam@webkit.org>
1946
1947         Reviewed by Anders Carlsson.
1948
1949         Add additional loader client functions need to complete WebKitTestRunner
1950         https://bugs.webkit.org/show_bug.cgi?id=43684
1951
1952         Remove unnecessary and jarring underscores as well.
1953
1954         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1955         (didClearWindowObjectForFrame):
1956         (didCreatePage):
1957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1958         (WTR::InjectedBundlePage::InjectedBundlePage):
1959         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1960         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1961         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1962         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1963         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1964         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1965         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1966         (WTR::InjectedBundlePage::didClearWindowForFrame):
1967         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1968         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1969         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1970         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1971         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1972         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1973         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1974         (WTR::InjectedBundlePage::willAddMessageToConsole):
1975         (WTR::InjectedBundlePage::willSetStatusbarText):
1976         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1977         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1978         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1979         (WTR::InjectedBundlePage::shouldBeginEditing):
1980         (WTR::InjectedBundlePage::shouldEndEditing):
1981         (WTR::InjectedBundlePage::shouldInsertNode):
1982         (WTR::InjectedBundlePage::shouldInsertText):
1983         (WTR::InjectedBundlePage::shouldDeleteRange):
1984         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1985         (WTR::InjectedBundlePage::shouldApplyStyle):
1986         (WTR::InjectedBundlePage::didBeginEditing):
1987         (WTR::InjectedBundlePage::didEndEditing):
1988         (WTR::InjectedBundlePage::didChange):
1989         (WTR::InjectedBundlePage::didChangeSelection):
1990         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1991
1992 2010-08-07  Dan Bernstein  <mitz@apple.com>
1993
1994         Build fix.
1995
1996         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
1997         to JSGCController.{cpp,h} relative to the build root.
1998
1999 2010-08-07  Sam Weinig  <sam@webkit.org>
2000
2001         Reviewed by Anders Carlsson.
2002
2003         WebKitTestRunner needs GCController
2004         <rdar://problem/8213834>
2005         https://bugs.webkit.org/show_bug.cgi?id=42701
2006
2007         * WebKitTestRunner/DerivedSources.make:
2008         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
2009         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2010         (WTR::setProperty):
2011         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
2012         (WTR::GCController::create):
2013         (WTR::GCController::GCController):
2014         (WTR::GCController::~GCController):
2015         (WTR::GCController::wrapperClass):
2016         (WTR::GCController::collect):
2017         (WTR::GCController::collectOnAlternateThread):
2018         (WTR::GCController::getJSObjectCount):
2019         (WTR::GCController::makeWindowObject):
2020         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
2021         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2022         (WTR::InjectedBundle::reset):
2023         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2024         (WTR::InjectedBundle::bundle):
2025         (WTR::InjectedBundle::gcController):
2026         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2027         (WTR::InjectedBundlePage::didClearWindowForFrame):
2028         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2029         (WTR::LayoutTestController::keepWebHistory):
2030         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2031         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2032         * WebKitTestRunner/win/InjectedBundle.vcproj:
2033
2034 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
2035
2036         WebKitTestRunner needs to be able to set the font smoothing type
2037         https://bugs.webkit.org/show_bug.cgi?id=43406
2038
2039         Reviewed by Adam Roben.
2040
2041         * WebKitTestRunner/TestInvocation.cpp:
2042         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2043         Set the font smoothing level to
2044         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
2045
2046 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2047
2048         Fix a missed variable rename.
2049
2050         Unreviewed.
2051
2052         * Scripts/old-run-webkit-tests:
2053
2054 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2055
2056         mac-wk2/Skipped should be used on Windows when running regression tests
2057         https://bugs.webkit.org/show_bug.cgi?id=43494
2058
2059         Reviewed by Adam Roben.
2060
2061         * Scripts/old-run-webkit-tests:
2062         If the platform is win-wk2, also read the mac-wk2 skipped list.
2063
2064 2010-08-06  Kent Tamura  <tkent@chromium.org>
2065
2066         Reviewed by Dimitri Glazkov.
2067
2068         [DRT/Chromium] Should revoke scheduled tasks
2069         https://bugs.webkit.org/show_bug.cgi?id=43560
2070
2071         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2072         (DRTDevToolsAgent::reset): Calls RevokeAll().
2073         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2074         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2075         (DRTDevToolsClient::reset): Calls RevokeAll().
2076         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2077         * DumpRenderTree/chromium/EventSender.cpp:
2078         (EventSender::reset): Calls RevokeAll().
2079         * DumpRenderTree/chromium/LayoutTestController.cpp:
2080         (LayoutTestController::reset): Calls RevokeAll().
2081         * DumpRenderTree/chromium/TestShell.cpp:
2082         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
2083
2084 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2085
2086         Reviewed by Antonio Gomes.
2087
2088         [Qt] Fix the DRT build on Mac OS X
2089
2090         * DumpRenderTree/qt/DumpRenderTree.pro:
2091
2092 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
2093
2094         Reviewed by Pavel Feldman.
2095
2096         Rietvield's upload.py moved to a different location.
2097         https://bugs.webkit.org/show_bug.cgi?id=43613
2098
2099         * Scripts/webkitpy/thirdparty/__init__.py:
2100
2101 2010-05-23  Eric Seidel  <eric@webkit.org>
2102
2103         Reviewed by Adam Barth.
2104
2105         QueueStatusServer needs better queue-status pages
2106         https://bugs.webkit.org/show_bug.cgi?id=39562
2107
2108         The primary goal of this patch is to display queue
2109         positions somewhere on the site so that it's easier
2110         for commit-queue users to know when their pach will
2111         be landed.  I also tried to improve the root page
2112         to be more useful than the previous wall of status text.
2113
2114         * QueueStatusServer/handlers/recentstatus.py:
2115         * QueueStatusServer/main.py:
2116         * QueueStatusServer/model/queues.py:
2117         * QueueStatusServer/templates/recentstatus.html:
2118
2119 2010-08-05  Victor Wang  <victorw@chromium.org>
2120
2121         Reviewed by Ojan Vafai.
2122
2123         Add option to generate/upload incremental json results to test result server.
2124         Also refactor the json results generator unittest code to test
2125         incremental and aggregated json results.
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=43519
2128
2129         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2130         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2131         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2132         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2133
2134 2010-08-05  Jian Li  <jianli@chromium.org>
2135
2136         Reviewed by David Levin.
2137
2138         Unify blob related feature defines to ENABLE(BLOB).
2139         https://bugs.webkit.org/show_bug.cgi?id=43081
2140
2141         * Scripts/build-webkit:
2142
2143 2010-08-05  Satish Sampath  <satish@chromium.org>
2144
2145         Reviewed by Jeremy Orlow.
2146
2147         Add speech input controller mock in WebKit and a layout test.
2148         https://bugs.webkit.org/show_bug.cgi?id=43477
2149
2150         Added LayoutTestController::setMockSpeechInputResultCallback method.
2151
2152         * DumpRenderTree/LayoutTestController.cpp:
2153         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
2154         (LayoutTestController::staticFunctions):
2155         * DumpRenderTree/LayoutTestController.h:
2156         * DumpRenderTree/chromium/LayoutTestController.cpp:
2157         (LayoutTestController::LayoutTestController):
2158         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
2159         (LayoutTestController::speechInputController): Creates the mock controller.
2160         * DumpRenderTree/chromium/LayoutTestController.h:
2161         * DumpRenderTree/chromium/WebViewHost.cpp:
2162         (WebViewHost::speechInputController): Creates the mock controller.
2163         * DumpRenderTree/chromium/WebViewHost.h:
2164         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2165         (LayoutTestController::setMockSpeechInputResult): dummy method.
2166         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2167         (LayoutTestController::setMockSpeechInputResult): dummy method.
2168         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2169         (LayoutTestController::setMockSpeechInputResult): dummy method.
2170         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2171         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
2172         (LayoutTestController::setMockSpeechInputResult):
2173         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
2174         (LayoutTestController::setMockSpeechInputResult):
2175
2176 2010-08-04  Adam Roben  <aroben@apple.com>
2177
2178         Fix the path to TestNetscapePlugin's directory on Windows
2179
2180         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
2181         load TestNetscapePlugin
2182
2183         Reviewed by Jon Honeycutt.
2184
2185         * WebKitTestRunner/win/TestControllerWin.cpp:
2186         (WTR::TestController::initializeTestPluginDirectory):
2187         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
2188         next to WebKitTestRunner.exe. Previously we were passing the directory
2189         that contains WebKitTestRunner.exe. Also fixed some leaks.
2190
2191 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
2192
2193         Reviewed by Shinichiro Hamaji.
2194
2195         check-webkit-style returns non-zero when patch is entirely minus lines.
2196         https://bugs.webkit.org/show_bug.cgi?id=38169
2197
2198         * Scripts/check-webkit-style:
2199         Check whether a patch contains modified files that are entirely minus lines.
2200         * Scripts/webkitpy/style/filereader.py:
2201         Add a variable that holds number of files that contain only deleted lines.
2202         * Scripts/webkitpy/style/patchreader.py:
2203         Count up modified files that contain only deleted lines.
2204
2205 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
2206
2207         Reviewed by Yury Semikhatsky.
2208
2209         DevTools: get rid of delayed command dispatching on front-end side.
2210
2211         https://bugs.webkit.org/show_bug.cgi?id=43479
2212
2213         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2214         (DRTDevToolsAgent::detach):
2215         (DRTDevToolsAgent::frontendLoaded):
2216         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2217         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2218         (DRTDevToolsClient::~DRTDevToolsClient):
2219         (DRTDevToolsClient::sendFrontendLoaded):
2220         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2221
2222 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
2223
2224         Reviewed by Shinichiro Hamaji.
2225
2226         Fixes check-webkit-style false positive on "new uint32_t."
2227         https://bugs.webkit.org/show_bug.cgi?id=43077
2228
2229         * Scripts/webkitpy/style/checkers/cpp.py:
2230         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2231
2232 2010-08-04  Kent Tamura  <tkent@chromium.org>
2233
2234         Reviewed by Dimitri Glazkov.
2235
2236         [DRT/Chromium] Remove base/linked_ptr.h dependency
2237         https://bugs.webkit.org/show_bug.cgi?id=43472
2238
2239         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
2240         We need to use RefPtr<> because m_pendingEntry points an object in
2241         m_entries or not in m_entries.
2242
2243         * DumpRenderTree/chromium/TestNavigationController.cpp:
2244         (TestNavigationEntry::create): Added.
2245         (TestNavigationController::activeEntry):
2246         (TestNavigationController::didNavigateToEntry):
2247         (TestNavigationController::discardPendingEntry):
2248         (TestNavigationController::insertEntry):
2249         (TestNavigationController::navigateToPendingEntry):
2250         * DumpRenderTree/chromium/TestNavigationController.h:
2251         * DumpRenderTree/chromium/WebViewHost.cpp:
2252         (WebViewHost::loadURLForFrame):
2253          Use TestNavigationEntry::create().
2254         (WebViewHost::updateURL):
2255          Use RefPtr<>.
2256         (WebViewHost::updateSessionHistory):
2257          Remove unnecessary static_cast<>.
2258
2259 2010-08-04  Kent Tamura  <tkent@chromium.org>
2260
2261         Reviewed by Dimitri Glazkov.
2262
2263         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
2264         https://bugs.webkit.org/show_bug.cgi?id=43333
2265
2266         * BuildSlaveSupport/test-result-archive:
2267           - Make layoutTestResultsDir local and pass it to archiveTestResults()
2268           - Adjust layoutTestResultsDir for Chromium
2269
2270 2010-08-04  Kent Tamura  <tkent@chromium.org>
2271
2272         Reviewed by Dimitri Glazkov.
2273
2274         NRWT: websocket_server startup detection failure
2275         https://bugs.webkit.org/show_bug.cgi?id=43466
2276
2277         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2278          Increase timeout value: 5 second -> 10 second
2279
2280 2010-08-04  Victor Wang  <victorw@chromium.org>
2281
2282         Reviewed by Ojan Vafai.
2283
2284         -. Add result.json incremental merging functionality to test results app engine.
2285         -. blobstore is not suitable for AE data merging and there is no API to
2286            programatically edit existing blob or write a new one yet, so replace blobstore
2287            with datastore. If file is oversize (>1000*1000 bytes), store file data in
2288            multiple datastore entries.
2289         -. Fix styles.
2290
2291         Test: jsonresults_unittest to test merging logics.
2292
2293         https://bugs.webkit.org/show_bug.cgi?id=38599
2294
2295         * TestResultServer/handlers/dashboardhandler.py:
2296         * TestResultServer/handlers/menu.py:
2297         * TestResultServer/handlers/testfilehandler.py:
2298         * TestResultServer/main.py:
2299         * TestResultServer/model/dashboardfile.py:
2300         * TestResultServer/model/datastorefile.py: Added.
2301         * TestResultServer/model/jsonresults.py: Added.
2302         * TestResultServer/model/jsonresults_unittest.py: Added.
2303         * TestResultServer/model/testfile.py:
2304         * TestResultServer/templates/uploadform.html:
2305
2306 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2307
2308         Reviewed by Kenneth Christiansen.
2309
2310         [Qt] [QtTestBrowser] Remove unneeded QAction class members
2311         https://bugs.webkit.org/show_bug.cgi?id=43518
2312
2313         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
2314         m_flipYAnimated. Also, in initializeView method there are some dead code block
2315         trying to connect them at the wrong time, when they have not been instanciated.
2316
2317         This patch:
2318
2319         - removes the two cited class members in favor of local variables in createChrome method;
2320         - removes the dead code block.
2321
2322         * QtTestBrowser/launcherwindow.cpp:
2323         (LauncherWindow::LauncherWindow):
2324         (LauncherWindow::initializeView):
2325         (LauncherWindow::createChrome):
2326         * QtTestBrowser/launcherwindow.h:
2327
2328 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2329
2330         Reviewed by Simon Hausmann and Kenneth Christiansen.
2331
2332         [Qt] [QtTestBrowser] Clean up static and global menu state controls
2333         https://bugs.webkit.org/show_bug.cgi?id=43448
2334
2335         After LauncherWindow class was refactored out of from main.cpp, all global variables that
2336         were hanging in main.cpp became temporarily public static class members of newly added
2337         LauncherWindow class. This design was not properly handling the initial purpose of the
2338         global variables: newly created launcher windows should inherit the settings of the originating
2339         one.
2340
2341         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
2342         comprises all data needed to handling the goal described above.
2343
2344         * QtTestBrowser/launcherwindow.cpp:
2345         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
2346                                           holding all user settings configured in the menus and command line.
2347                                           It also receices an optional QGraphicsScene points in case we are doing
2348                                           a "Clone Window".
2349         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
2350                                 value.
2351         (LauncherWindow::initializeView): Ditto.
2352         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
2353         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
2354                                       apply the preferences is provided by m_userData.
2355         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
2356         (LauncherWindow::toggleResizesToContents): Ditto.
2357         (LauncherWindow::toggleWebGL): Ditto.
2358         (LauncherWindow::toggleFrameFlattening): Ditto.
2359         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
2360         (LauncherWindow::changeViewportUpdateMode): Ditto.
2361         (LauncherWindow::showFPS): Ditto.
2362         (LauncherWindow::newWindow): Changed to pass the userData.
2363         (LauncherWindow::cloneWindow): Ditto.
2364         * QtTestBrowser/launcherwindow.h:
2365         (WindowOptions::WindowOptions):
2366         * QtTestBrowser/main.cpp:
2367         (requiresGraphicsView):
2368         (LauncherApplication::handleUserOptions):
2369         (main):
2370
2371 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
2372
2373         [wx] Build fix for gcc not importing all symbols from convenience libraries.
2374         Works on 10.6 only for Mac until the build system is reworked. 
2375
2376         * wx/build/settings.py:
2377
2378 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
2379
2380         Reviewed by Simon Hausmann.
2381
2382         [Qt] Change wording in QtTestBrowser
2383         https://bugs.webkit.org/show_bug.cgi?id=43241
2384
2385         * QtTestBrowser/launcherwindow.cpp:
2386         (LauncherWindow::createChrome):
2387
2388 2010-08-04  Aaron Boodman  <aa@chromium.org>
2389
2390         Reviewed by Eric Seidel.
2391
2392         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
2393         https://bugs.webkit.org/show_bug.cgi?id=43460
2394
2395         * Scripts/prepare-ChangeLog:
2396
2397 2010-08-03  MORITA Hajime  <morrita@google.com>
2398
2399         Reviewed by Tony Chang.
2400
2401         [DRT] Assertion failed when drag and move a draggable element.
2402         https://bugs.webkit.org/show_bug.cgi?id=41695
2403
2404         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
2405         But Cocoa doesn't call mouseDragged() until dragging is done.
2406         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
2407         on UIDelegate failed when mouseDragged() is called during dragging.
2408         This change eliminated the mouseDragged() call when dragging begins,
2409         which is implicated by draggingInfo instance.
2410         
2411         * DumpRenderTree/mac/EventSendingController.mm:
2412         (-[EventSendingController mouseMoveToX:Y:]):
2413
2414         Test: fast/events/dragging-mouse-moves.html
2415         
2416 2010-08-02  Steve Block  <steveblock@google.com>
2417
2418         Reviewed by Alexey Proskuryakov.
2419
2420         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
2421         https://bugs.webkit.org/show_bug.cgi?id=40002
2422
2423         The code in LayoutTestController::setGeolocationPermission() was moved to
2424         setGeolocationPermissionCommon() to allow each port to provide its own
2425         implementation of setGeolocationPermission().
2426
2427         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
2428         new permission, so it can call back to WebCore if permission requests are in
2429         progress and are waiting for a response. A minor fix to the Mac
2430         MockGeolocationProvider was also required to make sure that the mock provider
2431         calls back to WebCore when it is first started.
2432
2433         For other ports, LayoutTestController::setGeolocationPermission() is not
2434         implemented.
2435
2436         * DumpRenderTree/LayoutTestController.cpp:
2437         (LayoutTestController::setGeolocationPermissionCommon):
2438         * DumpRenderTree/LayoutTestController.h:
2439         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2440         (LayoutTestController::setGeolocationPermission):
2441         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2442         (LayoutTestController::setGeolocationPermission):
2443         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2444         (-[MockGeolocationProvider registerWebView:]):
2445         * DumpRenderTree/mac/UIDelegate.h:
2446         * DumpRenderTree/mac/UIDelegate.mm:
2447         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2448         (-[UIDelegate setGeolocationPermission:]):
2449         (-[UIDelegate dealloc]):
2450         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2451         (LayoutTestController::setGeolocationPermission):
2452         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2453         (LayoutTestController::setGeolocationPermission):
2454
2455 2010-08-03  Kent Tamura  <tkent@chromium.org>
2456
2457         Reviewed by Dimitri Glazkov.
2458
2459         [DRT/Chromium] Implement --testshell-startup-dialog
2460         https://bugs.webkit.org/show_bug.cgi?id=40616
2461
2462         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2463         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
2464         if it is specfied.
2465         * DumpRenderTree/chromium/TestShell.h:
2466           Declare openStartUpDialog().
2467         * DumpRenderTree/chromium/TestShellGtk.cpp:
2468         (openStartupDialog):
2469         * DumpRenderTree/chromium/TestShellMac.mm:
2470         (openStartupDialog):
2471         * DumpRenderTree/chromium/TestShellWin.cpp:
2472         (openStartupDialog):
2473
2474 2010-08-03  Kent Tamura  <tkent@chromium.org>
2475
2476         Reviewed by Dimitri Glazkov.
2477
2478         [DRT/Chromium] Remove dependency of base/md5.h
2479         https://bugs.webkit.org/show_bug.cgi?id=43403
2480
2481         * DumpRenderTree/chromium/TestShell.cpp:
2482         (TestShell::dumpImage): Use wtf/MD5.h
2483
2484 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2485
2486         Reviewed by David Kilzer.
2487
2488         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2489         https://bugs.webkit.org/show_bug.cgi?id=40627
2490
2491         Part 6 - LayoutTest and Cleanup
2492
2493           Allow tests to delete application caches and set application cache
2494           origin quotas, so they can be tested.
2495
2496         * DumpRenderTree/LayoutTestController.cpp:
2497         (LayoutTestController::LayoutTestController):
2498         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
2499         (clearAllApplicationCachesCallback): should delete all application caches.
2500         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
2501         (LayoutTestController::staticFunctions):
2502         * DumpRenderTree/LayoutTestController.h:
2503         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
2504         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
2505
2506           Mac implementation.
2507
2508         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2509         (LayoutTestController::clearAllApplicationCaches): delete application caches.
2510         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
2511         * DumpRenderTree/mac/UIDelegate.mm:
2512         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
2513         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
2514
2515           Stub implementations for other platforms.
2516
2517         * DumpRenderTree/chromium/LayoutTestController.cpp:
2518         (LayoutTestController::LayoutTestController):
2519         (LayoutTestController::clearAllApplicationCaches):
2520         (LayoutTestController::setApplicationCacheOriginQuota):
2521         * DumpRenderTree/chromium/LayoutTestController.h:
2522         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2523         (LayoutTestController::clearAllApplicationCaches):
2524         (LayoutTestController::setApplicationCacheOriginQuota):
2525         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2526         (LayoutTestController::clearAllApplicationCaches):
2527         (LayoutTestController::setApplicationCacheOriginQuota):
2528         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2529         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2530         (LayoutTestController::clearAllApplicationCaches):
2531         (LayoutTestController::setApplicationCacheOriginQuota):
2532         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2533         (LayoutTestController::clearAllApplicationCaches):
2534         (LayoutTestController::setApplicationCacheOriginQuota):
2535
2536 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2537
2538         Reviewed by David Kilzer.
2539
2540         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2541         https://bugs.webkit.org/show_bug.cgi?id=40627
2542
2543         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
2544
2545           Change old style calls to make use of the managers.
2546
2547         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2548         (LayoutTestController::setDatabaseQuota):
2549         * DumpRenderTree/mac/UIDelegate.mm:
2550         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2551
2552 2010-08-03  Mark Rowe  <mrowe@apple.com>
2553
2554         Add a new Leopard build slave to run the release tests.
2555
2556         * BuildSlaveSupport/build.webkit.org-config/config.json:
2557
2558 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
2559
2560         WebKitTestRunner needs to activate the Mac font ascent hack
2561         https://bugs.webkit.org/show_bug.cgi?id=43404
2562
2563         Reviewed by Darin Adler.
2564
2565         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2566         (WTR::InjectedBundle::initialize):
2567         Call WKBundleActivateMacFontAscentHack().
2568
2569 2010-08-03  Alex Milowski  <alex@milowski.com>
2570
2571         Reviewed by Beth Dakin.
2572
2573         Changed the default for MathML support so that is is enabled by default.
2574
2575         * Scripts/build-webkit:
2576
2577 2010-08-03  Sam Weinig  <sam@webkit.org>
2578
2579         Roll r64566 back in this time with all the overloads in place..
2580
2581         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2582         (WTR::InjectedBundlePage::shouldInsertNode):
2583         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2584         * WebKitTestRunner/StringFunctions.h:
2585         * WebKitTestRunner/TestInvocation.cpp:
2586         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2587         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2588         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2589
2590 2010-08-03  Sam Weinig  <sam@webkit.org>
2591
2592         Rollout r64566. It broke all the WebKit2 tests.
2593
2594         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2595         (WTR::operator<<):
2596         (WTR::InjectedBundlePage::shouldInsertNode):
2597         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2598         * WebKitTestRunner/StringFunctions.h: Removed.
2599         * WebKitTestRunner/TestInvocation.cpp:
2600         (WTR::createWKURL):
2601         (WTR::WKStringToUTF8):
2602         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2603         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2604         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2605
2606 2010-08-03  Sam Weinig  <sam@webkit.org>
2607
2608         Reviewed by Anders Carlsson.
2609
2610         WTR: Move all the utility functions for working with strings to a shared header.
2611         https://bugs.webkit.org/show_bug.cgi?id=43386
2612
2613         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2614         (WTR::InjectedBundlePage::shouldInsertNode):
2615         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2616         * WebKitTestRunner/StringFunctions.h: Added.
2617         * WebKitTestRunner/TestInvocation.cpp:
2618         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2619         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2620         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2621
2622 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
2623
2624         Reviewed by Kenneth Christiansen.
2625
2626         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
2627         https://bugs.webkit.org/show_bug.cgi?id=43168
2628
2629         QGraphicsWebView resizesToContents property has to work together with QWebPage's
2630         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
2631
2632         * QtTestBrowser/launcherwindow.cpp:
2633         (LauncherWindow::applyPrefs):
2634         * QtTestBrowser/webview.cpp:
2635         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
2636                                                       needed when toggle resizesToContents on/off.
2637         (WebViewGraphicsBased::resizeEvent):
2638         * QtTestBrowser/webview.h:
2639         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
2640         (WebViewGraphicsBased::customLayoutSize): Getter helper.
2641
2642 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
2643
2644         Unreviewed. Adding myself as committer.
2645
2646         * Scripts/webkitpy/common/config/committers.py:
2647
2648 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
2649
2650         Reviewed by Yury Semikhatsky.
2651
2652         Chromium DevTools: Get rid of DevTools RPC.
2653
2654         https://bugs.webkit.org/show_bug.cgi?id=43335
2655
2656         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2657         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
2658         (DRTDevToolsAgent::call):
2659         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2660         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
2661         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
2662         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2663         (DRTDevToolsClient::sendMessageToBackend):
2664         (DRTDevToolsClient::call):
2665         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2666
2667 2010-08-02  Kent Tamura  <tkent@chromium.org>
2668
2669         Reviewed by Dimitri Glazkov.
2670
2671         [DRT/Chromium] Remove dependencies to some Chromium headers
2672         https://bugs.webkit.org/show_bug.cgi?id=43396
2673
2674         * DumpRenderTree/chromium/CppVariant.h:
2675          Remove base/basictypes.h because webkit_support.h contains it.
2676         * DumpRenderTree/chromium/EventSender.cpp:
2677         (getCurrentEventTimeSec): Use new wrapper function.
2678         * DumpRenderTree/chromium/TestNavigationController.h:
2679          Remove base/basictypes.h because webkit_support.h contains it.
2680         * DumpRenderTree/chromium/TestShell.cpp:
2681         (dumpHistoryItem): Use new wrapper function.
2682         * DumpRenderTree/chromium/WebViewHost.cpp:
2683         (WebViewHost::cancelledError): Use new wrapper function.
2684         (WebViewHost::didFailResourceLoad): Use new wrapper function.
2685
2686 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2687
2688         Reviewed by Xan Lopez.
2689
2690         [GTK] DRT implement execCommand()
2691         https://bugs.webkit.org/show_bug.cgi?id=35351
2692
2693         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2694         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
2695         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
2696         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
2697
2698 2010-08-02  Sam Weinig  <sam@webkit.org>
2699
2700         Reviewed by Anders Carlsson.
2701
2702         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
2703
2704         * Scripts/old-run-webkit-tests:
2705
2706 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2707
2708         WebKitTestRunner needs to support loading custom fonts (via the
2709         WEBKIT_TESTFONTS environment variable)
2710         https://bugs.webkit.org/show_bug.cgi?id=42782
2711
2712         Reviewed by Adam Roben.
2713
2714         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2715         (WTR::fontsPath):
2716         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
2717         as this directory doesn't appear to be created anymore.
2718         (WTR::activateFonts):
2719         Loop through the fonts, and call AddFontResourceExW() for each.
2720
2721 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2722
2723         Restore the WebKitTestRunner.sln that was removed, and remove the
2724         correct one.
2725
2726         Rubber-stamped by Sam Weinig.
2727
2728         * WebKitTestRunner/WebKitTestRunner.sln: Added.
2729         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
2730
2731 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2732
2733         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
2734
2735         Remove the unused WebKitTestRunner.sln.
2736
2737         Reviewed by Sam Weinig.
2738
2739         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2740         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
2741         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
2742         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
2743         * WebKitTestRunner/win/WebKitTestRunner.sln:
2744
2745 2010-08-02  Sam Weinig  <sam@webkit.org>
2746
2747         Fix the windows build.
2748
2749         * WebKitTestRunner/win/main.cpp:
2750
2751 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
2752
2753         Add a Skipped list on Windows, and have run-webkit-tests respect it.
2754
2755         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
2756         there are zero tests failing
2757         https://bugs.webkit.org/show_bug.cgi?id=43374
2758
2759         Reviewed by Adam Roben.
2760
2761         * Scripts/old-run-webkit-tests:
2762         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
2763         win-wk2. When building the result hierarchy, if the platform is win-wk2,
2764         add it first to the list of platforms.
2765
2766 2010-08-02  Darin Adler  <darin@apple.com>
2767
2768         Reviewed by Sam Weinig.
2769
2770         WebKitTestRunner needs layoutTestController.setCanOpenWindows
2771         https://bugs.webkit.org/show_bug.cgi?id=42321
2772
2773         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
2774         https://bugs.webkit.org/show_bug.cgi?id=42779
2775
2776         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
2777         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
2778
2779         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2780         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
2781         waiting for the first call to didCreatePage.
2782         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
2783         is created. Put other pages into a map.
2784         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
2785         of the main page.
2786         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
2787         the main page.
2788         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
2789         closeOtherPages functions.
2790
2791         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2792         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
2793         the main page affect dumping.
2794         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
2795
2796         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2797         (WTR::LayoutTestController::LayoutTestController): Initialize the new
2798         m_shouldCloseExtraWindows member.
2799         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
2800         (WTR::LayoutTestController::windowCount): Added.
2801
2802         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2803         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
2804         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
2805         m_shouldCloseExtraWindows.
2806
2807         * WebKitTestRunner/TestController.cpp:
2808         (WTR::TestController::shared): Return a pointer to the shared copy, but
2809         don't allocate and leak it. This seemed cleaner than adding an explicit
2810         finalize call to go along with the explicit initialize call.
2811         (WTR::TestController::TestController): Added calls to the initialize and
2812         run function, which are now done automatically.
2813         (WTR::TestController::~TestController): Added, since it's called now.
2814         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
2815         (WTR::createOtherPage): Added. Used to create pages other than the main page.
2816         (WTR::TestController::initialize): Added code to set up createOtherPage.
2817         (WTR::TestController::run): Removed unused return value.
2818         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
2819         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
2820
2821         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2822         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
2823         to avoid releasing the window twice. Another way to handle it would be to
2824         remove the release, but this approach is slightly more robust because it works
2825         even if some other code calls the close method an extra time.
2826
2827         * WebKitTestRunner/mac/main.mm:
2828         (main): Use a stack-allocated TestController object instead of calling
2829         initalize and run on a globally allocated one.
2830
2831 2010-08-02  Tony Chang  <tony@chromium.org>
2832
2833         Reviewed by David Levin.
2834
2835         add myself to the reviewers list
2836         https://bugs.webkit.org/show_bug.cgi?id=43366
2837
2838         * Scripts/webkitpy/common/config/committers.py:
2839
2840 2010-08-02  Anders Carlsson  <andersca@apple.com>
2841
2842         Reviewed by Sam Weinig.
2843
2844         Cache JSNPObjects and fix bugs in the object map
2845         https://bugs.webkit.org/show_bug.cgi?id=43368
2846
2847         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
2848         wrap an NPObject that came from a plug-in that is now destroyed.
2849
2850         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2851         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2852         (PluginTest::Object::getProperty):
2853         (PluginTest::Object::NP_GetProperty):
2854         (PluginTest::Object::npClass):
2855         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
2856         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
2857         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2858         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
2859         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
2860         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2861         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2862         * GNUmakefile.am:
2863
2864 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2865
2866         Reviewed by Xan Lopez.
2867
2868         [Gtk] DOM listeners get wrong keycodes for some keys
2869         https://bugs.webkit.org/show_bug.cgi?id=35170
2870
2871         Add support to all event senders for simulating keypad insert
2872         and print screen keys.
2873
2874         * DumpRenderTree/chromium/EventSender.cpp:
2875         (EventSender::keyDown): Add support for generating keypad insert and print screen.
2876         * DumpRenderTree/gtk/EventSender.cpp:
2877         (keyDownCallback): Ditto.
2878         * DumpRenderTree/mac/EventSendingController.mm:
2879         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
2880         * DumpRenderTree/qt/EventSenderQt.cpp:
2881         (EventSender::keyDown): Ditto.
2882         * DumpRenderTree/win/EventSender.cpp:
2883         (keyDownCallback): Ditto.
2884
2885 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2886
2887         Build fix for building against development versions of GTK+. GTK 2.22
2888         has not yet been released, so these function definitions must be conditionalized
2889         on the development version.
2890
2891         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
2892
2893 2010-08-02  Tony Chang  <tony@chromium.org>
2894
2895         Reviewed by Kent Tamura.
2896
2897         [chromium] use ChromiumDriver on Linux when running webkit tests
2898         https://bugs.webkit.org/show_bug.cgi?id=43273
2899
2900         * Scripts/webkitpy/layout_tests/port/chromium.py:
2901
2902 2010-08-02  Kent Tamura  <tkent@chromium.org>
2903
2904         Reviewed by Dimitri Glazkov.
2905
2906         [DRT/Chromium] Always initialize GTK
2907         https://bugs.webkit.org/show_bug.cgi?id=43327
2908
2909         Call gtk_init() in order to fix plugin test crash.
2910
2911         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2912         (main): Pass argc/argv to platformInit().
2913         * DumpRenderTree/chromium/TestShell.h:
2914         * DumpRenderTree/chromium/TestShellGtk.cpp:
2915         (platformInit): Update parameters, call gtk_init().
2916         * DumpRenderTree/chromium/TestShellMac.mm:
2917         (platformInit): Update parameters.
2918         * DumpRenderTree/chromium/TestShellWin.cpp:
2919         (platformInit): Update parameters.
2920
2921 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
2922
2923         Reviewed by Simon Hausmann.
2924
2925         [Qt] Generate forwarding headers for WebKit2
2926
2927         https://bugs.webkit.org/show_bug.cgi?id=43336
2928
2929         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
2930
2931 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
2932
2933         Reviewed by Kent Tamura.
2934
2935         WebSocket server should start with SO_REUSEADDR
2936         https://bugs.webkit.org/show_bug.cgi?id=43329
2937
2938         Pulls in pywebsocket-0.5.2.
2939         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
2940         http://code.google.com/p/pywebsocket/source/detail?r=273
2941
2942         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
2943
2944 2010-08-01  Kent Tamura  <tkent@chromium.org>
2945
2946         Reviewed by Dimitri Glazkov.
2947
2948         [DRT/Chromium] Remove string_util.h dependency
2949         https://bugs.webkit.org/show_bug.cgi?id=43312
2950
2951         * DumpRenderTree/chromium/LayoutTestController.cpp:
2952         (LayoutTestController::pathToLocalResource):
2953          Use string::find() instead of StartsWithASCII().
2954         (LayoutTestController::cppVariantToInt32):
2955          Use strtol() instead of StringToNumber().
2956
2957 2010-08-01  Sam Weinig  <sam@webkit.org>
2958
2959         Reviewed by Anders Carlsson.
2960
2961         Add ability to reset frame names for WebKitTestRunner
2962         https://bugs.webkit.org/show_bug.cgi?id=43316
2963
2964         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2965         (WTR::InjectedBundle::reset):
2966         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2967         (WTR::InjectedBundlePage::reset):
2968         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2969
2970 2010-08-01  Anders Carlsson  <andersca@apple.com>
2971
2972         Reviewed by Sam Weinig.
2973
2974         Implement NPN_RemoveProperty
2975         https://bugs.webkit.org/show_bug.cgi?id=43315
2976
2977         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2978         Add NPRuntimeRemoveProperty.cpp
2979         
2980         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2981         (PluginTest::NPN_GetStringIdentifier):
2982         (PluginTest::NPN_GetIntIdentifier):
2983         (PluginTest::NPN_RemoveProperty):
2984         Add NPN_ helpers.
2985
2986         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2987         Support more NPClass functions.
2988
2989         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
2990         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
2991         Test for NPN_RemoveProperty.
2992
2993         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
2994         (NPRuntimeRemoveProperty::TestObject::invoke):
2995         Add a testRemoveProperty method.
2996
2997         (NPRuntimeRemoveProperty::NPP_GetValue):
2998         Return the test object.
2999
3000         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3001         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3002         * GNUmakefile.am:
3003         Add NPRuntimeRemoveProperty.cpp
3004
3005 2010-07-30  Anders Carlsson  <andersca@apple.com>
3006
3007         Reviewed by Sam Weinig.
3008
3009         Add an NPObject class template helper to TestNetscapePlugin
3010         https://bugs.webkit.org/show_bug.cgi?id=43288
3011
3012         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3013         Add some template magic to be able to figure out if a class has a member function of a given type.
3014
3015         (PluginTest::Object::create):
3016         Create an object.
3017
3018         (PluginTest::Object::invokeDefault):
3019         Add dummy function, this should never be called.
3020
3021         (PluginTest::Object::Object):
3022         Initialize m_pluginTest to 0.
3023
3024         (PluginTest::Object::~Object):
3025         Add virtual destructor.
3026
3027         (PluginTest::Object::NP_Allocate):
3028         Create a new object.
3029
3030         (PluginTest::Object::NP_Deallocate):
3031         Delete the object.
3032
3033         (PluginTest::Object::NP_InvokeDefault):
3034         Call invokeDefault.
3035
3036         (PluginTest::Object::npClass):
3037         Initialize the NPClass struct.
3038
3039         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3040         (DocumentOpenInDestroyStream::NPP_DestroyStream):
3041         Move this inline.
3042
3043         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
3044         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
3045         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
3046         Use the PluginTest::Object class template.
3047
3048 2010-07-31  Sam Weinig  <sam@webkit.org>
3049
3050         Reviewed by Dan Bernstein.
3051
3052         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
3053         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
3054         due to SVGElements not having the innerText function.
3055
3056         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3057         (WTR::dumpFrameText):
3058
3059 2010-07-30  Sam Weinig  <sam@webkit.org>
3060
3061         Reviewed by Maciej Stachowiak.
3062
3063         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
3064         Add structured message passing from the injected bundle to UIProcess
3065
3066         * MiniBrowser/mac/AppDelegate.m:
3067         (didRecieveMessageFromInjectedBundle):
3068         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3069         (didClearWindowForFrame):
3070         (didRecieveMessage):
3071         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3072         (WTR::InjectedBundle::done):
3073         (WTR::InjectedBundle::didReceiveMessage):
3074         * WebKitTestRunner/TestController.cpp:
3075         (WTR::TestController::initialize):
3076         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3077         * WebKitTestRunner/TestController.h:
3078         * WebKitTestRunner/TestInvocation.cpp:
3079         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3080         * WebKitTestRunner/TestInvocation.h:
3081         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3082
3083 2010-07-30  Sam Weinig  <sam@webkit.org>
3084
3085         Reviewed by Anders Carlsson.
3086
3087         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
3088         Make WKArrayRef more usable.
3089
3090         Remove now unnecessary const_casts.
3091
3092         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3093         (WTR::dumpDescendantFrameScrollPositions):
3094         (WTR::dumpDescendantFramesText):
3095
3096 2010-07-30  Sam Weinig  <sam@webkit.org>
3097
3098         Reviewed by Anders Carlsson.
3099
3100         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
3101         Add first pass of structured message passing.
3102
3103         Update Minibrowser and WebKitTestRunner to work with the new post message
3104         function.
3105
3106         * MiniBrowser/mac/AppDelegate.m:
3107         (didRecieveMessageFromInjectedBundle):
3108         (-[BrowserAppDelegate init]):
3109         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3110         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3111         (didStartProvisionalLoadForFrame):
3112         (didReceiveServerRedirectForProvisionalLoadForFrame):
3113         (didFailProvisionalLoadWithErrorForFrame):
3114         (didCommitLoadForFrame):
3115         (didFinishLoadForFrame):
3116         (didFailLoadWithErrorForFrame):
3117         (didReceiveTitleForFrame):
3118         (didClearWindowForFrame):
3119         (didCreatePage):
3120         (willDestroyPage):
3121         (didRecieveMessage):
3122         (WKBundleInitialize):
3123         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3124         (WTR::InjectedBundle::_didReceiveMessage):
3125         (WTR::InjectedBundle::didReceiveMessage):
3126         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3127         * WebKitTestRunner/TestInvocation.cpp:
3128         (WTR::TestInvocation::invoke):
3129         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3130
3131 2010-07-30  Anders Carlsson  <andersca@apple.com>
3132
3133         Try to fix the layout test failures.
3134
3135         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3136         (webkit_test_plugin_get_value):
3137
3138 2010-07-29  Anders Carlsson  <andersca@apple.com>
3139
3140         Reviewed by Adam Roben.
3141
3142         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
3143         https://bugs.webkit.org/show_bug.cgi?id=43232
3144
3145         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3146         Add PluginScriptableNPObjectInvokeDefault.cpp.
3147
3148         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3149         Remove invokeDefault callback function.
3150
3151         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3152         (PluginTest::create):
3153         Move this to the top of the file.
3154
3155         (PluginTest::NPP_GetValue):
3156         Add default implementation.
3157
3158         (PluginTest::NPN_CreateObject):
3159         Add NPN_ wrapper.
3160
3161         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3162         (PluginTest::identifier):
3163         Add identifier getter.
3164
3165         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3166         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3167         Add "using namespace std".
3168
3169         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3170         (NPP_GetValue):
3171         Give PluginTest a chance to return a value.
3172
3173         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3174         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3175         * GNUmakefile.am:
3176         Add PluginScriptableNPObjectInvokeDefault.cpp.
3177         
3178         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3179         (webkit_test_plugin_get_value):
3180         Give PluginTest a chance to return a value.
3181
3182 2010-07-30  Steve Block  <steveblock@google.com>
3183
3184         Reviewed by Steve Block.
3185
3186         Add LayoutTestController methods to test DeviceOrientation
3187         https://bugs.webkit.org/show_bug.cgi?id=39589
3188
3189         * DumpRenderTree/LayoutTestController.cpp:
3190         (setMockDeviceOrientationCallback):
3191         (LayoutTestController::staticFunctions):
3192         * DumpRenderTree/LayoutTestController.h:
3193         * DumpRenderTree/chromium/LayoutTestController.cpp:
3194         (LayoutTestController::LayoutTestController):
3195         (LayoutTestController::setMockDeviceOrientation):
3196         * DumpRenderTree/chromium/LayoutTestController.h:
3197         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3198         (LayoutTestController::setMockDeviceOrientation):
3199         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3200         (LayoutTestController::setMockDeviceOrientation):
3201         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3202         (LayoutTestController::setMockDeviceOrientation):
3203         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3204         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3205         (LayoutTestController::setMockDeviceOrientation):
3206         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3207         (LayoutTestController::setMockDeviceOrientation):
3208         * Scripts/build-webkit:
3209
3210 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3211
3212         Reviewed by Kenneth Christiansen.
3213
3214         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
3215         https://bugs.webkit.org/show_bug.cgi?id=43209
3216
3217         When -resizes-to-content was being passed as a command line parameter it was simply
3218         not being set (although the corresponding menu item was marked as ON).
3219         User had to toggle the menu OFF and then ON again for it to take place.
3220
3221         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
3222         the command line, but not resizesToContents. Patch addresses that.
3223
3224         * QtTestBrowser/launcherwindow.cpp:
3225         (LauncherWindow::createChrome):
3226         (LauncherWindow::applyPrefs):
3227         (LauncherWindow::toggleResizesToContents):
3228         * QtTestBrowser/webview.h:
3229         (WebViewGraphicsBased::resizesToContents):
3230
3231 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3232
3233         Rubber-stamped by Simon Fraser.
3234
3235         [Qt] QtTestBrowser: more method grouping and clean ups.
3236
3237         Moving blocks of code around. Basically grouping related methods close to each.
3238
3239         * QtTestBrowser/launcherwindow.cpp:
3240         (LauncherWindow::initializeView):
3241         (LauncherWindow::createChrome):
3242         (LauncherWindow::changeViewportUpdateMode):
3243         (LauncherWindow::showFPS):
3244         (LauncherWindow::newWindow):
3245         (LauncherWindow::cloneWindow):
3246         * QtTestBrowser/launcherwindow.h:
3247
3248 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3249
3250         Reviewed by Tor Arne Vestbø.
3251
3252         [QT][Symbian] QtTestBrowser missing location capabilities
3253         https://bugs.webkit.org/show_bug.cgi?id=43235
3254
3255         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
3256
3257         * QtTestBrowser/QtTestBrowser.pro:
3258
3259 2010-07-29  Anders Carlsson  <andersca@apple.com>
3260
3261         Add PluginTest.cpp
3262
3263         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3264
3265 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
3266
3267         Reviewed by Eric Seidel.
3268
3269         Update download URLs for python irclib package; the old URLs 
3270         pointed at a specific mirror host and not the general sourceforge
3271         URLs.
3272
3273         https://bugs.webkit.org/show_bug.cgi?id=43228
3274
3275         * Scripts/webkitpy/thirdparty/__init__.py:
3276
3277 2010-07-29  Anders Carlsson  <andersca@apple.com>
3278
3279         Fix typo.
3280
3281         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3282
3283 2010-07-29  Anders Carlsson  <andersca@apple.com>
3284
3285         Another attempt at fixing the Qt and GTK+ build.
3286
3287         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3288         (webkit_test_plugin_new_instance):
3289         (webkit_test_plugin_destroy_stream):
3290
3291 2010-07-29  Anders Carlsson  <andersca@apple.com>
3292
3293         Another build fix attempt.
3294
3295         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3296         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3297         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3298         (webkit_test_plugin_new_instance):
3299         * GNUmakefile.am:
3300
3301 2010-07-29  Anders Carlsson  <andersca@apple.com>
3302
3303         Try to fix Windows and Unix builds.
3304
3305         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3306         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3307         (webkit_test_plugin_new_instance):
3308         (webkit_test_plugin_destroy_stream):
3309
3310 2010-07-29  Anders Carlsson  <andersca@apple.com>
3311
3312         Reviewed by Sam Weinig.
3313
3314         Refactor TestNetscapePlugin so tests can be split in separate files
3315         https://bugs.webkit.org/show_bug.cgi?id=43220
3316
3317         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3318         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3319
3320         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3321         (pluginAllocate):
3322         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
3323
3324         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3325         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
3326         (PluginTest::PluginTest):
3327         Initialize m_npp and the test identifier.
3328         
3329         (PluginTest::createTestFunctions):
3330         Return the map from identifiers to createTest functions.
3331
3332         (PluginTest::registerCreateTestFunction):
3333         Insert the identifier and create function pair in the map.
3334
3335         (PluginTest::create):
3336         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
3337
3338         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
3339         (PluginTest::Register::Register):
3340         Helper class template for registering plug-in tests.
3341         
3342         (PluginTest::Register::create):
3343         Create a new test of the given type.
3344
3345         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
3346         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3347         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
3348
3349         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3350         (NPP_New):
3351         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
3352
3353         (NPP_DestroyStream):
3354         Call the plug-in test NPP_DestroyStream member function.
3355
3356         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3357         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3358
3359 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3360
3361         Unreviewed build fix.
3362
3363         Add missing second argument to assert_lint in new style checker tests.
3364
3365         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3366
3367 2010-07-29  Anders Carlsson  <andersca@apple.com>
3368
3369         Reviewed by Adam Roben.
3370
3371         check-webkit-style shouldn't complain about NPAPI functions
3372         https://bugs.webkit.org/show_bug.cgi?id=43211
3373
3374         Allow underscores in functions that start with NPN_, NPP_ or NP_.
3375
3376         * Scripts/webkitpy/style/checkers/cpp.py:
3377         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3378
3379 2010-07-29  Victor Wang  <victorw@chromium.org>
3380
3381         Unreviewed, rolling out r64270.
3382         http://trac.webkit.org/changeset/64270
3383         https://bugs.webkit.org/show_bug.cgi?id=39589
3384
3385         The patch breaks chromium webkit unittest
3386
3387         * DumpRenderTree/LayoutTestController.cpp:
3388         (LayoutTestController::staticFunctions):
3389         * DumpRenderTree/LayoutTestController.h:
3390         * DumpRenderTree/chromium/LayoutTestController.cpp:
3391         (LayoutTestController::LayoutTestController):
3392         * DumpRenderTree/chromium/LayoutTestController.h:
3393         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3394         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3395         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3396         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3397         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3398         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3399         * Scripts/build-webkit:
3400
3401 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3402
3403         Reviewed by Kenneth Christiansen.
3404
3405         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
3406         https://bugs.webkit.org/show_bug.cgi?id=43199
3407
3408         There is no sense in keeping WebPage method definitions in main.cpp once
3409         webpage.cpp already exists.
3410
3411         No behavior change.
3412
3413         * QtTestBrowser/main.cpp:
3414         * QtTestBrowser/webpage.cpp:
3415         (WebPage::createWindow):
3416         (WebPage::createPlugin):
3417
3418 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3419
3420         Reviewed by Kenneth Christiansen.
3421
3422         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
3423         https://bugs.webkit.org/show_bug.cgi?id=43170
3424
3425         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
3426         launcherwindow.{cpp|h}
3427
3428         No behavior change.
3429
3430         Also changed all global static variables (named "gXXX") from main.cpp to
3431         static public variables of the LauncherWindow class.
3432
3433         * QtTestBrowser/QtTestBrowser.pro:
3434         * QtTestBrowser/launcherwindow.cpp: Added.
3435         * QtTestBrowser/launcherwindow.h: Added.
3436         * QtTestBrowser/main.cpp:
3437         (LauncherApplication::handleUserOptions):
3438         (main):
3439
3440 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3441
3442         Reviewed by Xan Lopez.
3443
3444         Build fix for building against GTK+ 3.x. GSEAL requires that we
3445         access internals of the GdkDragContext via methods. For older versions
3446         of GTK+, define those methods.
3447
3448         * DumpRenderTree/gtk/EventSender.cpp:
3449         (gdk_drag_context_get_selected_action): Added.
3450         (gdk_drag_context_get_actions): Added.
3451         (dispatchEvent): Use the two new accessor methods.
3452
3453 2010-07-29  Adam Roben  <aroben@apple.com>
3454
3455         Always say "plugins directory" when referring to a directory
3456         containing one or more plugins
3457
3458         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
3459         directory" when it means "plugins directory"
3460
3461         Reviewed by John Sullivan.
3462
3463         * WebKitTestRunner/TestController.cpp:
3464         (WTR::TestController::initialize): Updated for rename.
3465
3466 2010-07-29  Adam Roben  <aroben@apple.com>
3467
3468         Always say "directory" when referring to a plugin directory
3469
3470         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
3471         when it means "plugin directory"
3472
3473         Reviewed by John Sullivan.
3474
3475         * WebKitTestRunner/TestController.cpp:
3476         (WTR::TestController::initialize): Updated for renames.
3477
3478         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
3479         m_testPluginDirectory.
3480         (WTR::TestController::testPluginDirectory): Renamed from
3481         testPluginPath.
3482
3483         * WebKitTestRunner/mac/TestControllerMac.mm:
3484         (WTR::TestController::initializeTestPluginDirectory):
3485         * WebKitTestRunner/win/TestControllerWin.cpp:
3486         (WTR::TestController::initializeTestPluginDirectory):
3487         Renamed from initializeTestPluginPath and updated for rename.
3488
3489 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3490
3491          Reviewed by Antonio Gomes.
3492
3493          Initialize all members of NPClass struct.
3494          https://bugs.webkit.org/show_bug.cgi?id=43193
3495
3496          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3497
3498 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3499
3500         Reviewed by Antonio Gomes.
3501
3502         Warning fix on platforms where XP_MACOSX is undefined.
3503         https://bugs.webkit.org/show_bug.cgi?id=43192
3504
3505         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3506         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
3507
3508 2010-07-29  Adam Roben  <aroben@apple.com>
3509
3510         Give find-included-framework-headers our standard license
3511
3512         * Scripts/find-included-framework-headers: Used the license from
3513         WebCore/LICENSE-APPLE.
3514
3515 2010-07-29  Adam Roben  <aroben@apple.com>
3516
3517         Speed up find-included-framework-headers
3518
3519         We only do one invocation of find now, no longer pipe to grep, and
3520         replace uniq with sort -u.
3521
3522         Also added a license header.
3523
3524         * Scripts/find-included-framework-headers:
3525
3526 2010-07-29  Steve Block  <steveblock@google.com>
3527
3528         Reviewed by Jeremy Orlow.
3529
3530         Add LayoutTestController methods to test DeviceOrientation
3531         https://bugs.webkit.org/show_bug.cgi?id=39589
3532
3533         * DumpRenderTree/LayoutTestController.cpp:
3534         (setMockDeviceOrientationCallback):
3535         (LayoutTestController::staticFunctions):
3536         * DumpRenderTree/LayoutTestController.h:
3537         * DumpRenderTree/chromium/LayoutTestController.cpp:
3538         * DumpRenderTree/chromium/LayoutTestController.h:
3539         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3540         (LayoutTestController::setMockDeviceOrientation):
3541         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3542         (LayoutTestController::setMockDeviceOrientation):
3543         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3544         (LayoutTestController::setMockDeviceOrientation):
3545         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3546         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3547         (LayoutTestController::setMockDeviceOrientation):
3548         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3549         (LayoutTestController::setMockDeviceOrientation):
3550         * Scripts/build-webkit:
3551
3552 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
3553
3554         Reviewed by Shinichiro Hamaji.
3555
3556         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
3557         check-webkit-style gives false positives in single-line functions.
3558
3559         * Scripts/webkitpy/style/checkers/cpp.py:
3560         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3561
3562 2010-07-28  Darin Adler  <darin@apple.com>
3563
3564         Reviewed by Sam Weinig.
3565
3566         WebKitTestRunner needs to support layoutTestController.execCommand
3567         <https://bugs.webkit.org/show_bug.cgi?id=42538>
3568
3569         WebKitTestRunner needs layoutTestController.isCommandEnabled
3570         <https://bugs.webkit.org/show_bug.cgi?id=42671>
3571
3572         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3573         Added execCommand and isCommandEnabled.
3574         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3575         (WTR::LayoutTestController::execCommand): Added.
3576         (WTR::LayoutTestController::isCommandEnabled): Added.
3577         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3578
3579 2010-07-28  Kent Tamura  <tkent@chromium.org>
3580
3581         Reviewed by Dimitri Glazkov.
3582
3583         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
3584         https://bugs.webkit.org/show_bug.cgi?id=43123
3585
3586         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
3587         which overrides test expectations only for DumpRenderTree, in
3588         order to manage what problems are investigated.
3589         This change will be reverted when we switch to DRT completely.
3590
3591         * Scripts/webkitpy/layout_tests/port/chromium.py:
3592          Add drt_expectations.txt content to the result of
3593          test_expectations_overrides() if --use-drt is specified.
3594
3595 2010-07-28  Brady Eidson  <beidson@apple.com>
3596
3597         Reviewed by Darin Adler.
3598
3599         First pass at visited link support for WK2
3600         https://bugs.webkit.org/show_bug.cgi?id=43157
3601
3602         * MiniBrowser/mac/AppDelegate.m:
3603         (didNavigateWithNavigationData):
3604         (didPerformClientRedirect):
3605         (didPerformServerRedirect):
3606         (didUpdateHistoryTitle):
3607         (populateVisitedLinks): Added for the new version of the HistoryClient.
3608         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
3609         
3610         * MiniBrowser/mac/BrowserWindowController.m:
3611         (-[BrowserWindowController awakeFromNib]):
3612
3613 2010-07-28  Robin Dunn  <robin@alldunn.com>
3614
3615         Reviewed by Kevin Ollivier.
3616
3617         Add DOM bindings support for wx port.
3618
3619         * DumpRenderTree/wscript:
3620         * wx/browser/wscript:
3621         * wx/build/settings.py:
3622
3623 2010-07-28  Tony Chang  <tony@chromium.org>
3624
3625         Reviewed by Kent Tamura.
3626
3627         [chromium] cleanup temp files left by Linux DRT
3628         https://bugs.webkit.org/show_bug.cgi?id=43062
3629
3630         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
3631         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
3632             by crashed DRTs
3633
3634 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
3635
3636         Rubber-stamped by Kenneth Christiansen.
3637
3638         More Developer menu items reordering.
3639
3640         Grouping related menu items together, visually and logically (in the code).
3641
3642         No behavior change.
3643
3644         * QtTestBrowser/main.cpp:
3645         (LauncherWindow::createChrome):
3646
3647 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
3648
3649         Reviewed by Ojan Vafai.
3650
3651         Add FILE_SYSTEM build flag for FileSystem API
3652         https://bugs.webkit.org/show_bug.cgi?id=42915
3653
3654         * Scripts/build-webkit:
3655
3656 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
3657
3658         Reviewed by David Levin.
3659
3660         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
3661         https://bugs.webkit.org/show_bug.cgi?id=43090
3662
3663         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
3664         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
3665
3666 2010-07-27  Kent Tamura  <tkent@chromium.org>
3667
3668         Unreviewed, trivial typo fix.
3669
3670         * Scripts/webkitpy/layout_tests/port/chromium.py:
3671           Fix a wrong method name committed by r64109.
3672
3673 2010-07-27  Sam Weinig  <sam@webkit.org>
3674
3675         Reviewed by Anders Carlsson.
3676
3677         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
3678         Clean up handling of strings at the WebKit2 API layer.
3679
3680         * MiniBrowser/mac/BrowserWindowController.m:
3681         (runJavaScriptAlert):
3682         (runJavaScriptConfirm):
3683         (runJavaScriptPrompt):
3684         (didNavigateWithNavigationData):
3685         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3686         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3687         (_didClearWindowForFrame):
3688
3689 2010-07-27  Ojan Vafai  <ojan@chromium.org>
3690
3691         Reviewed by Eric Seidel.
3692
3693         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
3694         https://bugs.webkit.org/show_bug.cgi?id=42984
3695
3696         squash and no_squash have been intentionally erroring for a couple weeks now.
3697         But post-commits was just broken. Just remove squash/no_squash.
3698
3699         * Scripts/webkitpy/tool/steps/abstractstep.py:
3700         * Scripts/webkitpy/tool/steps/options.py:
3701
3702 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
3703
3704         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
3705
3706         * wx/build/settings.py:
3707
3708 2010-07-27  Adam Roben  <aroben@apple.com>
3709
3710         Mac build fix
3711
3712         * MiniBrowser/mac/BrowserWindowController.m:
3713         (processDidExit):
3714         (-[BrowserWindowController awakeFromNib]):
3715         Added processDidExit support.
3716
3717 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
3718
3719         Rubber-stamped by Simon Hausmann.
3720
3721         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
3722
3723         Move some less useful menu items on Developers menu from the top to the bottom, so
3724         QGraphicsView menu goes to the top, and becomes more quickly accessible.
3725
3726         * QtTestBrowser/main.cpp:
3727         (LauncherWindow::createChrome):
3728
3729 2010-07-26  Adam Roben  <aroben@apple.com>
3730
3731         Fix the path to InjectedBundle.dll in Debug_Internal builds
3732
3733         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
3734         InjectedBundle.dll in the Debug_Internal configuration
3735
3736         Reviewed by Anders Carlsson.
3737
3738         * WebKitTestRunner/win/TestControllerWin.cpp:
3739         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
3740         suffix only in Debug_All builds.
3741
3742 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3743
3744         Reviewed by Darin Adler.
3745
3746         https://bugs.webkit.org/show_bug.cgi?id=42947
3747         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
3748         error. Without which dumpRenderTree crashes.
3749
3750         * Scripts/old-run-webkit-tests:
3751
3752 2010-07-27  Kent Tamura  <tkent@chromium.org>
3753
3754         Reviewed by Dimitri Glazkov.
3755
3756         https://bugs.webkit.org/show_bug.cgi?id=42956
3757         [DRT/Chromium] Fix "out of sync" assertion error
3758
3759         Fix an assertion error on Windows like the following:
3760         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
3761         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3762         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3763
3764         * Scripts/webkitpy/layout_tests/port/chromium.py:
3765         If the url matches with "file:///[a-z]:", does case-ignore comparison.
3766         GURL capitalize the driver letter of a file: URL.
3767
3768 2010-07-26  Darin Adler  <darin@apple.com>
3769
3770         Reviewed by Sam Weinig.
3771
3772         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
3773         https://bugs.webkit.org/show_bug.cgi?id=42537
3774
3775         WebKitTestRunner needs layoutTestController.markerTextForListItem
3776         https://bugs.webkit.org/show_bug.cgi?id=42549
3777
3778         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3779         Fixed _paramterExpression typo. Improved support for string type as a
3780         return value, so we don't try to include DOMString.h and we can convert
3781         the string to a JSValue by calling JSValueMakeStringOrNull.
3782
3783         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
3784         Added JSValueMakeStringOrNull, used by the code generator.
3785
3786         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3787         Added counterValueForElementById and markerTextForListItem.
3788
3789         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3790         Moved constant to the top of the file.
3791         (WTR::toCF): Added. Converts strings to CFStringRef.
3792         (WTR::toWK): Added. Converts strings to WKStringRef.
3793         (WTR::toJS): Added. Converts strings to JSStringRef.
3794         (WTR::setProperty): Moved this function to the top of the file
3795         rather than having it down where it's used inside the class. Also
3796         renamed it so it's a separate function rather than an overload of
3797         JSObjectSetProperty.
3798         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
3799         Should move it somewhere we can share it.
3800         (WTR::propertyObject): Ditto.
3801         (WTR::getElementById): Added. Calls getElementById through the magic
3802         of JavaScript.
3803         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3804         Chagned to use toWK instead of four local variables.
3805         (WTR::LayoutTestController::counterValueForElementById): Added.
3806         Calls WKBundleFrameCopyCounterValue.
3807         (WTR::LayoutTestController::markerTextForListItem): Added.
3808         Calls WKBundleFrameCopyMarkerText.
3809
3810         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3811         Added counterValueForElementById and markerTextForListItem.
3812
3813 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
3814
3815         Reviewed by Gustavo Noronha Silva.
3816
3817         [GTK] The EventSender should support simulating drop events
3818         https://bugs.webkit.org/show_bug.cgi?id=39844
3819
3820         Add initial dropping support to the GTK+ EventSender.
3821
3822         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3823         (createWebView): Listen for some new drag-and-drop signals.
3824         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
3825         (dispatchEvent):
3826         Detect situations where a drag is either starting or ending and massage
3827         GTK+ into sending the appropriate signals to the WebView.
3828         (replaySavedEvents): Remove comment.
3829         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
3830         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
3831         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
3832         (dragFailedCallback): Disable the GTK+ drag failed animation.
3833         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
3834
3835 2010-07-26  Daniel Bates  <dbates@rim.com>
3836
3837         Reviewed by Darin Adler.
3838
3839         svn-unapply warns of uninitialized variable when unapplying
3840         a patch that describes an svn move operation
3841         https://bugs.webkit.org/show_bug.cgi?id=42036
3842
3843         Fixes Perl uninitialized variable warnings when un-applying
3844         a patch that moves a file.
3845
3846         * Scripts/svn-unapply:
3847           - Modified patch() so that it initializes $patch to the empty
3848             string when we don't have svnConvertedText (such as when
3849             reversing a diff that represents a svn copy/move operation).
3850
3851 2010-07-26  Sam Weinig  <sam@webkit.org>
3852
3853         Reviewed by Anders Carlsson.
3854
3855         Move some non-APIish functions into private headers.
3856
3857         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3858         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3859
3860 2010-07-26  Sam Weinig  <sam@webkit.org>
3861
3862         Reviewed by Anders Carlsson.
3863
3864         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
3865         Add prompt and confirm client functions to WebKit2
3866
3867         * MiniBrowser/mac/BrowserWindowController.m:
3868         (-[BrowserWindowController awakeFromNib]):
3869
3870 2010-07-26  Adam Roben  <aroben@apple.com>
3871
3872         Windows build fix
3873
3874         * MiniBrowser/MiniBrowser.vcproj:
3875         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3876         Removed empty attributes so the values will be picked up from the
3877         vsprops files. (Also removed a couple of attributes that accidentally
3878         duplicated values from the vsprops files.)
3879
3880 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
3881
3882         Rubber-stamped by Adam Roben.
3883         
3884         Touch MiniBrowser's stdafx to fix the build.
3885
3886         * MiniBrowser/win/stdafx.h:
3887
3888 2010-07-26  Hayato Ito  <hayato@chromium.org>
3889
3890         Reviewed by Shinichiro Hamaji.
3891
3892         Add pretty printer of WTF::Vector for GDB 7.
3893
3894         https://bugs.webkit.org/show_bug.cgi?id=40909
3895
3896         * gdb/wtf.py: Added.
3897
3898 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3899
3900         Reviewed by Simon Hausmann.
3901
3902         [Qt] Fix feature detection regexp
3903
3904         We were missing the last feature
3905
3906         * Scripts/webkitdirs.pm:
3907
3908 2010-07-25  Darin Adler  <darin@apple.com>
3909
3910         Reviewed by Dan Bernstein.
3911
3912         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
3913         https://bugs.webkit.org/show_bug.cgi?id=42326
3914
3915         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3916         Added dumpSelectionRect.
3917
3918         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3919         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
3920         does nothing because its purpose is to change pixel test output and
3921         we do not have pixel tests implemented yet.
3922
3923 2010-07-25  Darin Adler  <darin@apple.com>
3924
3925         Reviewed by Maciej Stachowiak.
3926
3927         WebKitTestRunner needs to support layoutTestController.keepWebHistory
3928         https://bugs.webkit.org/show_bug.cgi?id=42323
3929
3930         Added keepWebHistory and computedStyleIncludingVisitedInfo.
3931
3932         Also fixed misspellings of the word "receive".
3933
3934         Also tweaked the names of some of the LayoutTestController members.
3935
3936         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3937         Added support for a type named "object" that is passed and returns as
3938         a JSValueRef.
3939
3940         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3941         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
3942         put setAcceptsEditing up nearer the top.
3943
3944         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3945         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
3946         (WTR::InjectedBundle::initialize): Ditto.
3947         (WTR::InjectedBundle::didReceiveMessage): Ditto.
3948         (WTR::InjectedBundle::reset): Reset the state of visited links between
3949         tests. Also eliminated the unused argument to the LayoutTestController
3950         create function.
3951         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
3952         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
3953
3954         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3955         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
3956         instead of acceptsEditing.
3957         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
3958         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
3959         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
3960         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
3961         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
3962         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
3963
3964         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3965         (WTR::LayoutTestController::create): Removed uneeded argument.
3966         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
3967         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
3968         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
3969         about the fact that this works on the main frame.
3970         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
3971         (WTR::LayoutTestController::keepWebHistory): Added.
3972         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
3973         (WTR::JSObjectSetProperty): Added. Helper to make the function below
3974         cleaner.
3975         (WTR::LayoutTestController::makeWindowObject): Changed to use the
3976         overload of JSObjectSetProperty above.
3977
3978         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
3979         match above.
3980
3981         * WebKitTestRunner/TestController.cpp:
3982         (WTR::TestController::initialize): Fixed mispellings of receive.
3983         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
3984         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
3985         * WebKitTestRunner/TestController.h: Ditto.
3986         * WebKitTestRunner/TestInvocation.cpp:
3987         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
3988         * WebKitTestRunner/TestInvocation.h: Ditto.
3989
3990 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
3991
3992         Reviewed by Sam Weinig.
3993
3994         https://bugs.webkit.org/show_bug.cgi?id=42193
3995         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
3996
3997         Step 2 - add the rest of editing delegates.
3998
3999         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4000         (WTR::operator<<): Fixed to not crash when range is null.
4001         (WTR::InjectedBundlePage::InjectedBundlePage):
4002         (WTR::InjectedBundlePage::_shouldEndEditing):
4003         (WTR::InjectedBundlePage::_shouldInsertNode):
4004         (WTR::InjectedBundlePage::_shouldInsertText):
4005         (WTR::InjectedBundlePage::_shouldDeleteRange):
4006         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
4007         (WTR::InjectedBundlePage::_shouldApplyStyle):
4008         (WTR::InjectedBundlePage::_didBeginEditing):
4009         (WTR::InjectedBundlePage::_didEndEditing):
4010         (WTR::InjectedBundlePage::_didChange):
4011         (WTR::InjectedBundlePage::_didChangeSelection):
4012         (WTR::InjectedBundlePage::shouldEndEditing):
4013         (WTR::InjectedBundlePage::shouldInsertNode):
4014         (WTR::InjectedBundlePage::shouldInsertText):
4015         (WTR::InjectedBundlePage::shouldDeleteRange):
4016         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
4017         (WTR::InjectedBundlePage::shouldApplyStyle):
4018         (WTR::InjectedBundlePage::didBeginEditing):
4019         (WTR::InjectedBundlePage::didEndEditing):
4020         (WTR::InjectedBundlePage::didChange):
4021         (WTR::InjectedBundlePage::didChangeSelection):
4022         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4023
4024 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
4025
4026         Reviewed by David Kilzer.
4027
4028         AX: need a layout test testing misspelled words in attributed strings
4029         https://bugs.webkit.org/show_bug.cgi?id=42899
4030
4031         * DumpRenderTree/AccessibilityUIElement.cpp:
4032         (attributedStringForRangeCallback):
4033         (attributedStringRangeIsMisspelledCallback):
4034         (AccessibilityUIElement::getJSClass):
4035         * DumpRenderTree/AccessibilityUIElement.h:
4036         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4037         (AccessibilityUIElement::attributedStringForRange):
4038         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
4039         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4040         (AccessibilityUIElement::attributedStringForRange):
4041         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
4042         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4043         (AccessibilityUIElement::attributedStringForRange):
4044         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
4045
4046 2010-07-23  David Kilzer  <ddkilzer@apple.com>
4047
4048         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
4049
4050         Reviewed by Mark Rowe.
4051
4052         * Scripts/check-for-inappropriate-files-in-framework: Added
4053         check for the SHALLOW_BUNDLE environment variable so that the
4054         script will work with iOS WebKit builds.
4055         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
4056
4057 2010-07-22  Darin Adler  <darin@apple.com>
4058
4059         Reviewed by Sam Weinig.
4060
4061         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
4062         https://bugs.webkit.org/show_bug.cgi?id=42847
4063
4064         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4065         (WTR::operator<<): Replaced the WKStringToUTF8 function with
4066         a set of overloaded stream operators.
4067         (WTR::dumpPath): Changed to use ostringstream and return a string.
4068         (WTR::propertyValue): Added.
4069         (WTR::propertyObject): Added.
4070         (WTR::propertyString): Added.
4071         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
4072         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
4073         since we now have suitable streaming functions.
4074         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
4075         WKBundleFrameCopyInnerText.
4076         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
4077         since we now have suitable streaming functions.
4078         (WTR::InjectedBundlePage::dump): Ditto.
4079         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
4080         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
4081         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
4082         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
4083         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
4084
4085 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
4086
4087         Reviewed by Sam Weinig and Darin Adler.
4088
4089         https://bugs.webkit.org/show_bug.cgi?id=42193
4090         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
4091
4092         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
4093         fixed, but this makes difference one line smaller on many editing tests.
4094
4095         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4096         Added dumpEditingCallbacks() and setAcceptsEditing().
4097
4098         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4099         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
4100         (WTR::operator<<): Print a range.
4101         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
4102         clients.
4103         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
4104         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
4105         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
4106         calls.
4107
4108         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4109         (WTR::LayoutTestController::LayoutTestController):
4110         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4111         (WTR::LayoutTestController::dumpEditingCallbacks):
4112         (WTR::LayoutTestController::setAcceptsEditing):
4113         (WTR::LayoutTestController::acceptsEditing):
4114         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
4115         Store m_acceptsEditing and m_dumpEditingCallbacks.
4116
4117 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
4118
4119         Reviewed by Laszlo Gombos.
4120
4121         [Qt] QtWebKit needs public API for Notifications.
4122         https://bugs.webkit.org/show_bug.cgi?id=41413
4123
4124         Update DumpRenderTree and QtTestBrowser to use the new API.
4125         Add new DRT API to flag that notifications permission requests should be ignored.
4126
4127         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4128         (WebCore::WebPage::WebPage):
4129         (WebCore::WebPage::requestPermission):
4130         (WebCore::WebPage::checkPermission):
4131         (WebCore::WebPage::cancelRequestsForPermission):
4132         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4133         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4134         (LayoutTestController::reset):
4135         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
4136         (LayoutTestController::checkDesktopNotificationPermission):
4137         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4138         (LayoutTestController::ignoreReqestForPermission):
4139         * QtTestBrowser/main.cpp:
4140         (LauncherWindow::LauncherWindow):
4141         * QtTestBrowser/webpage.cpp:
4142         (WebPage::WebPage):
4143         (WebPage::requestPermission):
4144         (WebPage::checkPermission):
4145         (WebPage::cancelRequestsForPermission):
4146         * QtTestBrowser/webpage.h:
4147
4148 2010-07-22  Darin Adler  <darin@apple.com>
4149
4150         Reviewed by Sam Weinig.
4151
4152         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
4153         https://bugs.webkit.org/show_bug.cgi?id=42325
4154
4155         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4156         Added dumpChildFramesAsText.
4157
4158         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4159         (WTR::dumpFrameText): Added.
4160         (WTR::dumpDescendantFramesText): Added.
4161         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
4162         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
4163         instead of the shouldDumpAsText function, and added a case for AllFramesText.
4164
4165         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
4166
4167         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4168         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
4169         m_whatToDump.
4170
4171         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
4172         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
4173         and shouldDumpSourceAsWebArchive. Added whatToDump.
4174
4175 2010-07-22  Adam Roben  <aroben@apple.com>
4176
4177         Windows build fix
4178
4179         Inspired by r63881.
4180
4181         * MiniBrowser/MiniBrowser.vcproj:
4182         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
4183         Removed pre- and post-build events so they will be inherited from the
4184         vsprops files.
4185
4186 2010-07-21  Darin Adler  <darin@apple.com>
4187
4188         Reviewed by Sam Weinig.
4189
4190         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
4191         https://bugs.webkit.org/show_bug.cgi?id=42548
4192
4193         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4194         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4195         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
4196         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
4197         Changed to a file-internal function instead of a member function.
4198         (WTR::dumpDescendantFrameScrollPositions): Added.
4199         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
4200         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
4201         appropriate. Also streamlined all the WKStringToUTF8 call sites.
4202         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
4203         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
4204         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
4205         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
4206         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
4207
4208         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
4209
4210         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4211         (WTR::LayoutTestController::LayoutTestController): Initialize
4212         m_shouldDumpAllFrameScrollPositions.
4213         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
4214         shouldDumpFrameScrollPositions.
4215
4216         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
4217         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
4218         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
4219
4220 2010-07-21  Darin Adler  <darin@apple.com>
4221
4222         Reviewed by Sam Weinig.
4223
4224         WebKitTestRunner needs to support dumping of scroll position
4225         https://bugs.webkit.org/show_bug.cgi?id=42514
4226
4227         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
4228         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
4229
4230         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4231         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
4232         instead of JSContextRef.
4233         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
4234         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
4235         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
4236         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
4237         instead of JSContextRef.
4238
4239         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
4240         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
4241
4242         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4243         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
4244         returns false.
4245         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
4246         returns false.
4247         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
4248         the logic in DumpRenderTree.
4249
4250         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
4251
4252         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
4253
4254 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
4255
4256         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
4257
4258         * wx/build/settings.py:
4259
4260 2010-07-21  Sam Weinig  <sam@webkit.org>
4261
4262         Reviewed by Anders Carlsson.
4263
4264         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
4265         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
4266
4267         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4268         (WTR::InjectedBundlePage::InjectedBundlePage):
4269         (WTR::InjectedBundlePage::_willAddMessageToConsole):
4270         (WTR::InjectedBundlePage::_willSetStatusbarText):
4271         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
4272         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
4273         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
4274         (WTR::InjectedBundlePage::willAddMessageToConsole):
4275         (WTR::InjectedBundlePage::willSetStatusbarText):
4276         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
4277         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
4278         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
4279         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4280
4281 2010-07-21  Adam Roben  <aroben@apple.com>
4282
4283         Give InjectedBundle our standard set of configurations (minus the
4284         *_Cairo variants)
4285
4286         InjectedBundle's Debug_All configuration was the same as is Debug
4287         configuration, and it was missing a Debug_Internal configuration.
4288
4289         Fixes <http://webkit.org/b/42749> InjectedBundle's build
4290         configurations are screwy
4291
4292         Reviewed by Darin Adler.
4293
4294         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
4295         debug_internal.vsprops and debug_all.vsprops to the Debug_All
4296         configuration. Added a Debug_Internal configuration.
4297
4298         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
4299         variant of InjectedBundle when we're using the Debug_Internal solution
4300         configuration.
4301
4302 2010-07-21  Adam Roben  <aroben@apple.com>
4303
4304         Move InjectedBundle's settings to a vsprops file
4305
4306         This will make it easier to change settings for all configurations,
4307         and to add new configurations.
4308
4309         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
4310         files
4311
4312         Reviewed by Darin Adler.
4313
4314         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
4315         Moved settings here...
4316         * WebKitTestR