2010-09-22 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2
3         Unreviewed, build fix.
4
5         Fix bustage of rebaseline-chromium-webkit-tests resulting from
6         r67974. Really need better unit tests for this tool :(
7
8         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
9
10 2010-09-22  Adam Roben  <aroben@apple.com>
11
12         Unbreak test-webkitpy
13
14         * Scripts/webkitpy/test/main.py:
15         (Tester.run_tests): Add a line that mysteriously got deleted.
16
17 2010-09-22  Adam Roben  <aroben@apple.com>
18
19         Make test-webkitpy test WebKit2's scripts
20
21         These scripts can't be in WebKitTools due to limitations of Apple's
22         build process. But that doesn't mean we can't test them!
23
24         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
25         WebKit2/Scripts
26
27         Reviewed by Adam Barth.
28
29         * Scripts/test-webkitpy:
30         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
31         Now takes an external_package_paths parameter and cleans both webkitpy
32         and any external packages.
33         (init): Added an external_package_paths parameter which we pass along
34         to _clean_packages_with_test.
35         (top level): Add WebKit2/Scripts/webkit2 as our only external package
36         and pass it along to init and Tester.run_tests.
37
38         * Scripts/webkitpy/test/main.py:
39         (Tester.run_tests): Added an optional external_package_paths
40         parameter. We modify sys.path so that the external packages can be
41         imported, and search for unittest files inside all external packages
42         in addition to inside webkitpy.
43
44 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
45
46         Reviewed by Tony Chang.
47
48         new-run-webkit-tests: r68063 broke linux python tests
49
50         Add a missing "from __future__ import with_statement" to this
51         new file; the perils of testing only on the Mac and by review :(
52
53         https://bugs.webkit.org/show_bug.cgi?id=46293
54
55         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
56
57 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
58
59         Reviewed by Tony Chang.
60
61         Add a 'chromium-gpu' set of ports that will test the accelerated
62         GPU paths. This patch adds:
63
64         - support for the '--accelerated-compositing' and
65           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
66           'no-' flags)
67         - adds a new set of Ports that will look under
68           platform/chromium-gpu-$OS/ for baselines before looking in the
69           regular chromium search path
70         - adds a new test_expectations.txt file in platform/chromium-gpu
71           that skips all but the tests we actually want to run with
72           acceleration.
73
74         This patch will allow us to run both with and without acceleration
75         and to change the defaults for both the regular and -gpu options
76         as the code evolves.
77
78         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
79         each test bot.
80
81         https://bugs.webkit.org/show_bug.cgi?id=46225
82
83         * Scripts/webkitpy/layout_tests/port/chromium.py:
84         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
85         * Scripts/webkitpy/layout_tests/port/factory.py:
86         * Scripts/webkitpy/layout_tests/port/webkit.py:
87
88 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
89
90         Reviewed by Kenneth Rohde Christiansen.
91
92         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
93         https://bugs.webkit.org/show_bug.cgi?id=43988
94
95         Runs a web debug server on port specified by QtTestBrowser
96         argument -remote-inspector-port. Property
97         _q_webInspectorServerPort of the QWebPage instance will be set
98         according to the argument. All pages with that property set will
99         be remotely inspectable.
100
101         URL for remote inspection of first QWebPage is
102             http://localhost:9222/webkit/inspector/inspector.html?page=1
103         where 1 is the number of the QWebPage instance.
104
105         The base URL yields an index page with links to the individual inspectors:
106             http://localhost:9222/
107
108         * QtTestBrowser/launcherwindow.cpp:
109         (LauncherWindow::init):
110         * QtTestBrowser/launcherwindow.h:
111         * QtTestBrowser/main.cpp:
112         (LauncherApplication::handleUserOptions):
113
114 2010-09-22  Adam Roben  <aroben@apple.com>
115
116         Fix webkit-patch failure-reason now that build.webkit.org has been
117         updated
118
119         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
120         every time
121
122         Reviewed by Eric Seidel.
123
124         * Scripts/webkitpy/common/net/buildbot.py:
125         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
126         looking for an element that contains text, then returns it.
127         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
128         text out of the cells. This way it doesn't matter whether the cells
129         have <b> children (as for cells in directory rows) or not (as for
130         cells in file rows)
131         (BuildBot._parse_twisted_directory_listing): Look for rows that have
132         the "directory" or "file" class, rather than rows with any class,
133         since header rows now have a class attribute.
134
135         * Scripts/webkitpy/common/net/buildbot_unittest.py:
136         (BuildBotTest._example_directory_listing): Updated to more closely
137         match the markup that build.webkit.org is producing now.
138
139 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
140
141         Unreviewed, build fix.
142
143         new-run-webkit-tests: fix bug introduced in r68008 where if you
144         specify --chromium and no --platform, and you're running on
145         windows, you use the 'chromium-win' port by default instead of the
146         version-specific port. This breaks the buildbots.
147
148         It will be good for this refactoring to settle down so I can
149         rewrite the logic for default ports and the unit tests to be
150         clearer (and the testing more comprehensive).
151
152         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
153
154 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
155
156         Reviewed by Adam Barth.
157
158         Modify the Port interface to take only a series of keyword arguments
159         in the constructor, and modify Port/factory.get() to accomodate that,
160         and to accept user=XXX as an argument so we can pass
161         webkitpy.common.system.user.User objects in.
162
163         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
164         to use the common routine in webkitpy.common.system.user.open_url()
165         to display HTML files.
166
167         There was a routine in the Port interface to do the same thing,
168         but I see no need for a port-specific hook for this, since it is
169         something that will always be executed by the host environment
170         and displaying web pages has nothing to do with running layout tests.
171
172         Note that new-run-webkit-tests used to use test_shell to display
173         the page; this is potentially useful so that you can actually click
174         from a result to the broken page; however, since DumpRenderTree
175         doesn't support this functionality, it will be going away eventually.
176
177         https://bugs.webkit.org/show_bug.cgi?id=46128
178
179         * Scripts/webkitpy/layout_tests/port/base.py:
180         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
181         * Scripts/webkitpy/layout_tests/port/chromium.py:
182         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
183         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
184         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
185         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
186         * Scripts/webkitpy/layout_tests/port/dryrun.py:
187         * Scripts/webkitpy/layout_tests/port/factory.py:
188         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
189         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
190         * Scripts/webkitpy/layout_tests/port/gtk.py:
191         * Scripts/webkitpy/layout_tests/port/mac.py:
192         * Scripts/webkitpy/layout_tests/port/qt.py:
193         * Scripts/webkitpy/layout_tests/port/test.py:
194         * Scripts/webkitpy/layout_tests/port/webkit.py:
195         * Scripts/webkitpy/layout_tests/port/win.py:
196         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
198         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
199
200 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
201
202         Reviewed by Kenneth Rohde Christiansen.
203
204         [EFL] Get fresh theme when running EWebLauncher
205         https://bugs.webkit.org/show_bug.cgi?id=46210
206
207         If user tried to run EWebLauncher outside of the build tree, it would
208         not find the theme and fallback to the installed one. However, since
209         EWebLauncher is not installed, we always want to take the theme from
210         the just compiled source code. If user had never installed WebKit's
211         EFL port it could even receive a segv since no theme would be found.
212
213         Now EWebLauncher does not fallback to the installed theme and CMake
214         gives as DATA_DIR the directory of the theme it has just built.
215
216         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
217         EWebLauncher.
218         * EWebLauncher/main.c: Use only the theme from build director. Do not
219         fallback to others as this could hide real bugs.
220         (quit):
221         (browserCreate):
222         (findThemePath):
223         (main):
224
225 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
226
227         Unreviewed, build fix.
228
229         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
230         it just confuses it.
231
232         https://bugs.webkit.org/show_bug.cgi?id=46230
233
234         * Scripts/webkitpy/layout_tests/port/webkit.py:
235
236 2010-09-21  Lucas Forschler  <lforschler@apple.com>
237
238         Reviewed by Stephanie Lewis.
239
240         Make a new buildbot for Leopard Debug Test
241
242         * BuildSlaveSupport/build.webkit.org-config/config.json:
243
244 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
245
246         Unreviewed, build fix.
247
248         Fix breakage of Chromium Mac DRT port caused by r67905.
249
250         https://bugs.webkit.org/show_bug.cgi?id=46230
251
252         * Scripts/webkitpy/layout_tests/port/webkit.py:
253
254 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
255
256         Unreviewed, build fix.
257
258         Add missing import of 'tempfile'.
259
260         * Scripts/webkitpy/layout_tests/port/chromium.py:
261
262 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
263
264         Reviewed by Ojan Vafai.
265
266         new-run-webkit-tests: pull the list of tests from the Port, and
267            make it possible to run with no actual test files in the filesystem.
268
269         This set of changes allows us to delete the special
270         webkitpy/layout_tests/data directory and test the generic code without
271         touching the filesystem (except to write results). This speeds up
272         test-webkitpy substantially.
273
274         This also cleans up and removes several code paths in the generic
275         code and fixes some minor bugs, notably in the test_expectations
276         parsing, which was previously fragile if the tests weren't present.
277
278         We also change the way we diff image results to be able to do so
279         in memory, without relying on files. This slows down chromium
280         test_shell, which always writes images to files, but should speed
281         up DRT and ImageDiff-based implementations slightly.
282
283         Note that pulling the list of tests to run from the Port will allow
284         ports to specify what tests to run as an inclusive list; previously
285         you could only do this as an exclusive list by using a 
286         test_expectations file or Skipped files; nothing actually uses this
287         feature yet and it's unclear if it should be used.
288
289         Note that there are no functional changes -- apart from now 
290         always printing out the location of the checksum file when we are
291         tracing test runs -- and the total number of lines of non-test code
292         actually drops by two.
293
294         There is some more cleanup that can be done in the Port/Driver 
295         interface and in some handling of filenames, but I'll save that
296         for another change.
297
298         https://bugs.webkit.org/show_bug.cgi?id=45801
299
300         * Scripts/webkitpy/layout_tests/data/*: Removed.
301             - no longer need special mock layout_tests_directory in the
302               repository.
303         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
304             - add code to display missing text files, checksums when tracing
305             - update to not look at the filesystem directly.
306         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
307             - add more unit tests
308         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
309             - remove tests_are_present flag
310             - update with changes in Port interface - no longer access
311               the filesystem directly, although we still use os.path for
312               filename manipulation.
313         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
314             - add more unit tests
315         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
316             - renamed to port/test_files.py
317         * Scripts/webkitpy/layout_tests/port/base.py:
318             - change diff_image() to expect actual image data, not filenames
319             - add expected_checksum(), expected_image(), expected_text() to
320               return the content of the files so that we don't need a filesystem
321             - add path_exists(), path_isdir() for filesystem-like access.
322             - add test_dirs() to keep clobber-test-results from needing to
323               actually look at a real layout tests dir
324             - add tests() to return the list of tests to run on the port
325               (calls port/test_files to do the work).
326             - add update_baseline() to be able to save new baselines
327             - add uri_to_test_name() from port/dryrun.py so we can easily check
328               filename_to_uri()
329         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
330             - add more unit tests
331         * Scripts/webkitpy/layout_tests/port/chromium.py:
332             - change diff_image() to accept image content, not filenames.
333               This will be slower for test_shell/image_diff, but faster
334               for DRT/ImageDiff.
335         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
336             - add more unit tests
337         * Scripts/webkitpy/layout_tests/port/dryrun.py:
338             - simplify greatly
339         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
340             - add more unit tests
341         * Scripts/webkitpy/layout_tests/port/test.py:
342             - massive rewrite to use in-script list of tests and expectations
343         * Scripts/webkitpy/layout_tests/port/test_files.py:
344             - rename from layout_package/test_files.
345         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
346             - add unit tests
347         * Scripts/webkitpy/layout_tests/port/webkit.py:
348             - update diff_image() to take image contents, not files. Should
349               make things slightly faster.
350         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
351             - update with changes to diff_image()
352         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
353             - update with changes to diff_image()
354         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
355             - remove tests_are_present from test_expectations
356             - pull the list of tests from port.tests() instead
357               of calling test_files.py directly.
358         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
359             - update unit tests
360         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
361             - update with changes to 
362         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
363             - update with change in Port interface
364         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
365             - update with change in Port interface
366         * Scripts/webkitpy/style/checkers/test_expectations.py:
367             - remove the tests_are_present flag
368
369 2010-09-21  Anders Carlsson  <andersca@apple.com>
370
371         Disable logging.
372
373         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
374
375 2010-09-21  Tony Chang  <tony@chromium.org>
376
377         Reviewed by Kent Tamura.
378
379         add a script for running webkit_unit_tests
380         https://bugs.webkit.org/show_bug.cgi?id=46014
381
382         * Scripts/run-chromium-webkit-unit-tests: Added.
383
384 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
385
386         Reviewed by Martin Robinson.
387
388         Fix linking problems on Windows.
389         https://bugs.webkit.org/show_bug.cgi?id=45844
390
391         * GNUmakefile.am: link the executables with winmm.dll
392
393 2010-09-21  Adam Barth  <abarth@webkit.org>
394
395         Reviewed by Eric Seidel.
396
397         feeder-queue svn updates more often than needed
398         https://bugs.webkit.org/show_bug.cgi?id=46171
399
400         We don't need to poll SVN every time we feed the feeders.  Rather, we
401         can count on the wrapper shell script to auto-update the queue.
402
403         * Scripts/webkitpy/tool/commands/queues.py:
404         * Scripts/webkitpy/tool/commands/queues_unittest.py:
405
406 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
407
408         Reviewed by Andreas Kling.
409
410         [Qt] Add robot loader timeout and extra time options.
411         https://bugs.webkit.org/show_bug.cgi?id=46172
412
413         [-robot-timeout <s>]: Load the next page after s seconds if the current
414         page didn't finish loading.
415         [-robot-extra-time <s>]: Wait s seconds after the current page finished
416         loading before loading the next one. This should allow some time for the
417         page's JavaScript to execute.
418
419         * QtTestBrowser/launcherwindow.cpp:
420         (LauncherWindow::applyPrefs):
421         * QtTestBrowser/main.cpp:
422         (LauncherApplication::robotTimeout):
423         (LauncherApplication::robotExtraTime):
424         (LauncherApplication::LauncherApplication):
425         (LauncherApplication::handleUserOptions):
426         (main):
427         * QtTestBrowser/urlloader.cpp:
428         (UrlLoader::UrlLoader):
429         (UrlLoader::loadNext):
430         (UrlLoader::loadUrlList):
431         * QtTestBrowser/urlloader.h:
432
433 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
434
435         Unreviewed.
436
437         Adding myself to the committers list.
438
439         * Scripts/webkitpy/common/config/committers.py:
440
441 2010-09-20  Philippe Normand  <pnormand@igalia.com>
442
443         Reviewed by Eric Carlson.
444
445         [GTK] enhanced context menu for media elements
446         https://bugs.webkit.org/show_bug.cgi?id=45021
447
448         EventSender::contextClick() now returns an array of js
449         objects. Each object has a title property and a click() method.
450
451         * DumpRenderTree/gtk/EventSender.cpp:
452         (getMenuItemTitleCallback):
453         (setMenuItemTitleCallback):
454         (menuItemClickCallback):
455         (getMenuItemClass):
456         (contextClickCallback):
457
458 2010-09-20  Hayato Ito  <hayato@chromium.org>
459
460         Unreviewed.
461         Adding myself to the committers list.
462
463         * Scripts/webkitpy/common/config/committers.py:
464
465 2010-09-20  Adam Barth  <abarth@webkit.org>
466
467         Reviewed by Eric Seidel.
468
469         The tool member variable should be called _tool
470         https://bugs.webkit.org/show_bug.cgi?id=46160
471
472         Created by find-and-replace.
473
474         * Scripts/webkitpy/tool/commands/download.py:
475         * Scripts/webkitpy/tool/commands/openbugs.py:
476         * Scripts/webkitpy/tool/commands/queries.py:
477         * Scripts/webkitpy/tool/commands/queues.py:
478         * Scripts/webkitpy/tool/commands/queues_unittest.py:
479         * Scripts/webkitpy/tool/commands/rebaseline.py:
480         * Scripts/webkitpy/tool/commands/sheriffbot.py:
481         * Scripts/webkitpy/tool/commands/upload.py:
482         * Scripts/webkitpy/tool/multicommandtool.py:
483
484 2010-09-20  Adam Barth  <abarth@webkit.org>
485
486         I ran the tests before landing but ignored the fact that they failed.  :(
487
488         * Scripts/webkitpy/tool/commands/queues.py:
489
490 2010-09-20  Adam Barth  <abarth@webkit.org>
491
492         Reviewed by Eric Seidel.
493
494         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
495         https://bugs.webkit.org/show_bug.cgi?id=46141
496
497         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
498         list of work items on the status server.  The individual commit-cluster
499         nodes then grab the patches from the server and process them.
500
501         * Scripts/webkitpy/tool/bot/feeders.py: Added.
502         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
503         * Scripts/webkitpy/tool/commands/queues.py:
504         * Scripts/webkitpy/tool/commands/queues_unittest.py:
505         * Scripts/webkitpy/tool/commands/queuestest.py:
506
507 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
508
509         Reviewed by Darin Adler.
510
511         build-webkit: Add support for CMake build system
512         https://bugs.webkit.org/show_bug.cgi?id=44979
513
514         * Scripts/build-webkit: Add "--efl" command-line option to build the
515         EFL port of WebKit.
516         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
517         buildEflCMakeProject() subroutines.
518
519 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
520
521         Reviewed by Ojan Vafai.
522
523         new-run-webkit-tests: refactor command line args getting passed to DRT
524
525         This change cleans up some argument parsing between functions to get
526         rid of some overlapping data structures. There should be no functional
527         changes in this patch; it is pure refactoring in preparation for
528         landing the Chrome GPU port and adding a generic way to pass
529         args to DRT/TestShell.
530
531         https://bugs.webkit.org/show_bug.cgi?id=46135
532
533         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
534           - pass the options argument explicitly to the threads and drivers,
535             also consolidate the passing of options to the driver.
536           - pass options directly to process_output() to remove a couple
537             parameters (minor cleanup).
538         * Scripts/webkitpy/layout_tests/port/base.py:
539           - pass the options argument to Port.create_driver().
540         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
541           - update Port.create_driver() test
542         * Scripts/webkitpy/layout_tests/port/chromium.py:
543           - pass the options argument to Port.create_driver(), and clean up
544             building of the cmd line for DRT.
545         * Scripts/webkitpy/layout_tests/port/dryrun.py:
546           - pass the options argument to Port.create_driver()
547         * Scripts/webkitpy/layout_tests/port/test.py:
548           - pass the options argument to Port.create_driver()
549         * Scripts/webkitpy/layout_tests/port/webkit.py:
550           - pass the options argument to Port.create_driver(), and clean up
551             building of the cmd line for DRT.
552         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
553           - consolidate args in _get_dump_render_tree_args and rename to
554             _get_test_args(); move all of the command-line args to the
555             Port implementations.
556
557 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
558
559         Revert change which was accidentally committed along with some expectation changes.
560
561         * Scripts/webkitpy/layout_tests/port/base.py:
562
563 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
564
565         Reviewed by Adam Barth.
566
567         Add explicit --force-patch flag to webkitpy tools
568         https://bugs.webkit.org/show_bug.cgi?id=46103
569         
570         It wasn't obvious until I read the applypatch.py source code that
571         --non-interfactive implies passing --force to patch. Add --force-patch
572         as an alias to the flag, so that this behavior is more discoverable.
573
574         * Scripts/webkitpy/tool/steps/applypatch.py:
575         * Scripts/webkitpy/tool/steps/options.py:
576
577 2010-09-20  Eric Seidel  <eric@webkit.org>
578
579         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
580
581         commit-queue can't land patches
582         https://bugs.webkit.org/show_bug.cgi?id=46138
583
584         Add a line of code I forgot in my last commit.
585
586         * Scripts/webkitpy/common/net/bugzilla.py:
587         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
588
589 2010-09-20  Adam Barth  <abarth@webkit.org>
590
591         Reviewed by Eric Seidel.
592
593         The commit-cluster bots still race to lock patch_ids
594         https://bugs.webkit.org/show_bug.cgi?id=46130
595
596         It turns out we need to use a transaction object to make the
597         read/modify/write lock operation atomic.  From reading the AppEngine
598         documentation, I think this patch should do what we want.  It's hard to
599         test locally because the test instance isn't distributed in the same
600         way the production instance is.
601
602         * QueueStatusServer/handlers/nextpatch.py:
603         * QueueStatusServer/model/activeworkitems.py: Added.
604
605 2010-09-20  Andy Estes  <aestes@apple.com>
606
607         Reviewed by Adam Barth.
608
609         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
610         https://bugs.webkit.org/show_bug.cgi?id=40961
611
612         Implement WebKitUsePreHTML5ParserQuirks preference.
613
614         * DumpRenderTree/mac/DumpRenderTree.mm:
615         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
616         to false after a test finishes.
617
618 2010-09-20  Adam Roben  <aroben@apple.com>
619
620         Windows build fix
621
622         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
623         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
624         we'll pick up the most recent versions of the headers.
625
626 2010-09-20  Eric Seidel  <eric@webkit.org>
627
628         Reviewed by Adam Barth.
629
630         commit-queue should check commit-queue+ again just before committing
631         https://bugs.webkit.org/show_bug.cgi?id=32679
632
633         Added a _revalidate_patch check, right before landing.
634
635         Since _revalidate_patch passes the patch_id from the work item
636         back to bugzilla, I had to fix all of the previous queue tests to
637         use valid attachment ids (that's the majority of this change).
638
639         In order to validate that the bug was still open, I had to teach
640         bugzilla.Bug about open/closed states.
641
642         * Scripts/webkitpy/common/net/bugzilla.py:
643         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
644         * Scripts/webkitpy/tool/commands/queues.py:
645         * Scripts/webkitpy/tool/commands/queues_unittest.py:
646         * Scripts/webkitpy/tool/commands/queuestest.py:
647         * Scripts/webkitpy/tool/mocktool.py:
648
649 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
650
651         Unreviewed.
652
653         Adding myself as a comitter.
654
655         * Scripts/webkitpy/common/config/committers.py:
656
657 2010-09-20  Adam Barth  <abarth@webkit.org>
658
659         Reviewed by Eric Seidel.
660
661         Two instances of commit-queue try to process the same patch
662         https://bugs.webkit.org/show_bug.cgi?id=46113
663
664         This patch makes next-patch atomic so that the server won't vend the
665         same patch twice in the same hour.
666
667         * QueueStatusServer/handlers/nextpatch.py:
668
669 2010-09-20  Adam Roben  <aroben@apple.com>
670
671         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
672
673         We were previously trying to use a CFRunLoopTimer, but since Windows
674         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
675         Windows-style timer on Windows.
676
677         I also replaced all uses of "watchdog" with "watchdog timer".
678
679         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
680         watchdog timer doesn't work on Windows
681
682         Reviewed by Anders Carlsson.
683
684         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
685         (WTR::InjectedBundlePage::dump): Updated for rename.
686
687         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
688         platform-specific functions.
689         (WTR::LayoutTestController::LayoutTestController): Added call to
690         platformInitialize.
691         (WTR::LayoutTestController::waitUntilDone): Changed to call
692         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
693         right in this function.
694         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
695         rename.
696
697         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
698         members needed to support the watchdog timer abstraction. Replaced
699         some "watchdog"s with "watchdog timer".
700
701         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
702         Added.
703         (WTR::LayoutTestController::platformInitialize): Does nothing on this
704         platform.
705         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
706         from LayoutTestController.cpp and changed to use an early return.
707         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
708         LayoutTestController.cpp.
709         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
710         Moved code here from LayoutTestController::waitUntilDone and changed
711         to use an early return.
712
713         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
714         Added.
715         (WTR::LayoutTestController::platformInitialize): Initialize our
716         watchdog timer.
717         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
718         Kills and clears the watchdog timer.
719         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
720         LayoutTestController member function of the same name.
721         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
722         Added. Sets up the timer if it isn't already set.
723
724         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
725         LayoutTestControllerMac.mm.
726
727         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
728         LayoutTestControllerWin.cpp.
729
730 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
731
732         Reviewed by Daniel Bates.
733
734         [GTK] fast/forms/listbox-selection.html fails
735         https://bugs.webkit.org/show_bug.cgi?id=45942
736
737         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
738         strings in keyDownCallback.
739
740         * DumpRenderTree/gtk/EventSender.cpp:
741         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
742         modifier parsing logic.
743
744 2010-09-19  Sam Weinig  <sam@webkit.org>
745
746         Reviewed by Anders Carlsson.
747
748         WebKit2 decidePolicyForNavigationAction should include mouse button information
749         <rdar://problem/8413165>
750         https://bugs.webkit.org/show_bug.cgi?id=46060
751
752         * MiniBrowser/mac/BrowserWindowController.m:
753         (decidePolicyForNavigationAction):
754         (decidePolicyForNewWindowAction):
755
756 2010-09-19  Daniel Bates  <dbates@rim.com>
757
758         Reviewed by Martin Robinson.
759
760         Add unit tests for diffs that delete or modify a change log entry
761         or describe changes that are far apart
762         https://bugs.webkit.org/show_bug.cgi?id=46046
763
764         Add additional unit tests to test change log diffs that contain
765         deletions or changes that are far apart from each other in the
766         ChangeLog file.
767
768         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
769           - Added the following unit tests:
770           "fixChangeLogPatch: [no change] In-place change."
771           "fixChangeLogPatch: [no change] Remove first entry."
772           "fixChangeLogPatch: [no change] Remove entry in the middle."
773           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
774
775 2010-09-19  Sam Weinig  <sam@webkit.org>
776
777         Reviewed by Anders Carlsson.
778
779         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
780         https://bugs.webkit.org/show_bug.cgi?id=46054
781
782         The new one acts like WKBundleNodeHandleRef and allows for getting a
783         wrapper in a specific world for the handle.
784
785         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
786         (WTR::propertyValue):
787         (WTR::propertyValueDouble):
788         (WTR::propertyValueInt):
789         (WTR::numericWindowPropertyValue):
790         (WTR::toStr):
791         (WTR::InjectedBundlePage::shouldBeginEditing):
792         (WTR::InjectedBundlePage::shouldEndEditing):
793         (WTR::InjectedBundlePage::shouldInsertNode):
794         (WTR::InjectedBundlePage::shouldInsertText):
795         (WTR::InjectedBundlePage::shouldDeleteRange):
796         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
797         (WTR::InjectedBundlePage::shouldApplyStyle):
798         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
799
800 2010-09-19  Kent Tamura  <tkent@chromium.org>
801
802         Unreviewed. Fix WebGL test regressions by r67809.
803
804         * DumpRenderTree/chromium/WebPreferences.cpp:
805         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
806
807 2010-09-19  Kent Tamura  <tkent@chromium.org>
808
809         Reviewed by Adam Barth.
810
811         [DRT/Chromium] Fix a WebSettings handling bug
812         https://bugs.webkit.org/show_bug.cgi?id=45945
813
814         Before this change, Chromium DRT reset WebSettings for every new
815         window. It was wrong.
816         If new window is not the first one, we have to apply the same
817         settings as the first window.  So, we introduce WebPreference to
818         store the current settings, and apply it to new windows. It's same
819         as test_shell's behavior.
820
821         * DumpRenderTree/DumpRenderTree.gypi:
822         * DumpRenderTree/chromium/LayoutTestController.cpp:
823           Use WebPreferences instead of WebSettings.
824         (LayoutTestController::setUserStyleSheetEnabled):
825         (LayoutTestController::setUserStyleSheetLocation):
826         (LayoutTestController::setAuthorAndUserStylesEnabled):
827         (LayoutTestController::setPopupBlockingEnabled):
828         (LayoutTestController::disableImageLoading):
829         (LayoutTestController::setJavaScriptCanAccessClipboard):
830         (LayoutTestController::setXSSAuditorEnabled):
831         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
832         (LayoutTestController::setAllowFileAccessFromFileURLs):
833         (LayoutTestController::overridePreference):
834         (LayoutTestController::setEditingBehavior):
835         * DumpRenderTree/chromium/TestShell.cpp:
836         (TestShell::resetWebSettings): Use WebPreferences.
837         (TestShell::runFileTest): ditto.
838         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
839         * DumpRenderTree/chromium/TestShell.h:
840         (TestShell::preferences):
841         (TestShell::applyPreferences):
842         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
843         * DumpRenderTree/chromium/WebPreferences.h: Added.
844
845 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
846
847         Reviewed by David Levin.
848
849         update-webkit --chromium spitting out a spurious error
850         https://bugs.webkit.org/show_bug.cgi?id=45868
851
852         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
853
854 2010-09-18  Sam Weinig  <sam@webkit.org>
855
856         Reviewed by Dan Bernstein.
857
858         Improve/unify the PageLoadClient interfaces
859         https://bugs.webkit.org/show_bug.cgi?id=46043
860
861         * MiniBrowser/mac/BrowserWindowController.m:
862         (didStartProvisionalLoadForFrame):
863         (didReceiveServerRedirectForProvisionalLoadForFrame):
864         (didFailProvisionalLoadWithErrorForFrame):
865         (didCommitLoadForFrame):
866         (didFinishDocumentLoadForFrame):
867         (didFinishLoadForFrame):
868         (didFailLoadWithErrorForFrame):
869         (didReceiveTitleForFrame):
870         (didFirstLayoutForFrame):
871         (didFirstVisuallyNonEmptyLayoutForFrame):
872         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
873         (WTR::InjectedBundlePage::InjectedBundlePage):
874         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
875         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
876         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
877         (WTR::InjectedBundlePage::didCommitLoadForFrame):
878         (WTR::InjectedBundlePage::didFinishLoadForFrame):
879         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
880         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
881         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
882         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
883         * WebKitTestRunner/TestController.cpp:
884         (WTR::TestController::didReceiveMessageFromInjectedBundle):
885         (WTR::TestController::didFinishLoadForFrame):
886         * WebKitTestRunner/TestController.h:
887
888 2010-09-17  Eric Seidel  <eric@webkit.org>
889
890         Unreviewed.  Adding a shell script I use to run the
891         commit-queue. Now that multiple machines run the cq,
892         it makes sense to share the script between them.
893
894         * EWSTools/start-commit-queue.sh: Added.
895
896 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
897
898         Reviewed by Jon Honeycutt.
899
900         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
901         slightly harder to read, so this reverts the previous background colors for various
902         states, making it easier to read.
903
904         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
905         (.success):
906         (.failure):
907         (.warnings):
908         (.exception):
909         (.start,.running,td.building):
910         (.offline,td.offline):
911
912 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
913
914         Unreviewed, rolling out r67692.
915         http://trac.webkit.org/changeset/67692
916         https://bugs.webkit.org/show_bug.cgi?id=46011
917
918         broke layout test dashboard (Requested by johnny_g on
919         #webkit).
920
921         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
922         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
923         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
924
925 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
926
927         Reviewed by Oliver Hunt.
928
929         Style bot complains about cairo forward declaration naming
930         https://bugs.webkit.org/show_bug.cgi?id=45867
931
932         Exclude Cairo forward declarations from indentifiers with underscores checks.
933
934         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
935         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
936
937 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
938
939         Reviewed by Ojan Vafai.
940
941         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
942         https://bugs.webkit.org/show_bug.cgi?id=45408
943
944         This change also tries to remove duplicated upload_results_json methods
945         in run_webkit_tests.py and json_results_generator.py.
946
947         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
948         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
949         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
950
951 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
952
953         Reviewed by Andreas Kling.
954
955         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
956
957         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
958         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
959         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
960         all page specific stuff to the UI.
961
962         * QtTestBrowser/launcherwindow.cpp:
963         (LauncherWindow::initializeView):
964         * QtTestBrowser/mainwindow.cpp:
965         (MainWindow::MainWindow):
966         (MainWindow::buildUI):
967         (MainWindow::setPage):
968         * QtTestBrowser/mainwindow.h:
969
970 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
971
972         Reviewed by Andreas Kling.
973
974         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
975
976         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
977         object will move to the qgraphicsscene instead of the qgraphicsview.
978
979         * QtTestBrowser/webview.cpp:
980         (WebViewGraphicsBased::setPage):
981         (WebViewGraphicsBased::setResizesToContents):
982         (WebViewGraphicsBased::resizeEvent):
983         (WebViewGraphicsBased::animatedFlip):
984         * QtTestBrowser/webview.h:
985         (WebViewGraphicsBased::setItemCacheMode):
986         (WebViewGraphicsBased::itemCacheMode):
987
988 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
989
990         Reviewed by Andreas Kling.
991
992         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
993
994         We usually separate methods whose body are larger than a few lines from the class definition.
995
996         * QtTestBrowser/webview.h:
997         (WebViewGraphicsBased::yRotation):
998         (WebViewGraphicsBased::setYRotation):
999
1000 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1001
1002         Reviewed by Andreas Kling.
1003
1004         Make initializeView method of LauncherWindow private.
1005
1006         No one else needs to be able to call it but LauncherWindow.
1007         Also moving the declation of isGraphicsBased method down in the same file, in order
1008         to better group related methods.
1009
1010         * QtTestBrowser/launcherwindow.h:
1011
1012 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1013
1014         Reviewed by Andreas Kling.
1015
1016         Make the getter 'page' method of MainWindow const.
1017
1018         * QtTestBrowser/mainwindow.cpp:
1019         (MainWindow::page):
1020         * QtTestBrowser/mainwindow.h:
1021
1022 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1023
1024         Reviewed by Andreas Kling.
1025
1026         Remove useless parameter from MainWindow class' constructor.
1027
1028         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
1029         not referred in the constructor body and does not make much sense.
1030
1031         * QtTestBrowser/mainwindow.cpp:
1032         (MainWindow::MainWindow):
1033         * QtTestBrowser/mainwindow.h:
1034
1035 2010-09-15  Tony Chang  <tony@chromium.org>
1036
1037         Reviewed by Kent Tamura.
1038
1039         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1040         https://bugs.webkit.org/show_bug.cgi?id=42151
1041
1042         * DumpRenderTree/chromium/LayoutTestController.cpp:
1043         (LayoutTestController::LayoutTestController):
1044         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1045         (WorkItemLoadHTMLString::run):
1046         (LayoutTestController::queueLoadHTMLString):
1047         (LayoutTestController::reset):
1048         (LayoutTestController::setDeferMainResourceDataLoad):
1049         * DumpRenderTree/chromium/LayoutTestController.h:
1050         (LayoutTestController::deferMainResourceDataLoad):
1051         * DumpRenderTree/chromium/WebViewHost.cpp:
1052         (WebViewHost::didCreateDataSource):
1053
1054 2010-09-16  Adrienne Walker  <enne@google.com>
1055
1056         Reviewed by Kenneth Russell.
1057
1058         Add script to synchronize WebKit and Khronos WebGL tests
1059         https://bugs.webkit.org/show_bug.cgi?id=42336
1060
1061         * Scripts/update-webgl-conformance-tests: Added.
1062         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
1063         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
1064
1065 2010-09-16  Sam Weinig  <sam@webkit.org>
1066
1067         Reviewed by Anders Carlsson.
1068
1069         Add support for sending synchronous messages from the InjectedBundle to the WKContext
1070         <rdar://problem/8365320>
1071         https://bugs.webkit.org/show_bug.cgi?id=44785
1072
1073         * MiniBrowser/mac/AppDelegate.m:
1074         (didReceiveSynchronousMessageFromInjectedBundle):
1075         (-[BrowserAppDelegate init]):
1076         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1077         (didCreatePage):
1078         * WebKitTestRunner/TestController.cpp:
1079         (WTR::TestController::initialize):
1080
1081 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
1082
1083         Reviewed by Andreas Kling.
1084
1085         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
1086         https://bugs.webkit.org/show_bug.cgi?id=45885
1087
1088         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
1089
1090         * QtTestBrowser/launcherwindow.cpp:
1091         (LauncherWindow::screenshot):
1092
1093 2010-09-16  Anders Carlsson  <andersca@apple.com>
1094
1095         Fix clang++ build.
1096
1097         * MiniBrowser/mac/BrowserWindowController.m:
1098         (-[BrowserWindowController zoomIn:]):
1099         (-[BrowserWindowController zoomOut:]):
1100         (-[BrowserWindowController resetZoom:]):
1101         Remove trailing semicolons.
1102
1103 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1104
1105         Unreviewed, rolling out r67628.
1106         http://trac.webkit.org/changeset/67628
1107         https://bugs.webkit.org/show_bug.cgi?id=45904
1108
1109         broke the build (Requested by eric_carlson on #webkit).
1110
1111         * DumpRenderTree/gtk/EventSender.cpp:
1112         (contextClickCallback):
1113
1114 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
1115
1116         Unreviewed.
1117
1118         Adding myself as a comitter.
1119
1120         * Scripts/webkitpy/common/config/committers.py:
1121
1122 2010-09-15  Philippe Normand  <pnormand@igalia.com>
1123
1124         Reviewed by Eric Carlson.
1125
1126         [GTK] enhanced context menu for media elements
1127         https://bugs.webkit.org/show_bug.cgi?id=45021
1128
1129         EventSender::contextClick() now returns an array of js
1130         objects. Each object has a title property and a click() method.
1131
1132         * DumpRenderTree/gtk/EventSender.cpp:
1133         (getMenuItemTitleCallback):
1134         (setMenuItemTitleCallback):
1135         (menuItemClickCallback):
1136         (getMenuItemClass):
1137         (contextClickCallback):
1138
1139 2010-09-14  Philippe Normand  <pnormand@igalia.com>
1140
1141         Reviewed by Eric Carlson and Martin Robinson.
1142
1143         [GTK] eventSender.contextClick() should return the contents of the context menu
1144         https://bugs.webkit.org/show_bug.cgi?id=39102
1145
1146         Make the eventSender use the new private WebKitGtk+ API to
1147         retrieve the context-menu item titles and store them in an array.
1148
1149         * DumpRenderTree/gtk/EventSender.cpp:
1150         (contextClickCallback):
1151
1152 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
1153
1154         Reviewed by Jian Li.
1155
1156         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
1157         https://bugs.webkit.org/show_bug.cgi?id=45798
1158
1159         * Scripts/build-webkit:
1160
1161 2010-09-16  Robert Hogan  <robert@webkit.org>
1162
1163         Reviewed by Antonio Gomes.
1164
1165         [Qt] Support globalhistory tests
1166         https://bugs.webkit.org/show_bug.cgi?id=45774
1167
1168         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1169         (WebCore::isGlobalHistoryTest):
1170         (WebCore::DumpRenderTree::open):
1171         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1172         (LayoutTestController::reset):
1173         (LayoutTestController::dumpHistoryCallbacks):
1174         (LayoutTestController::removeAllVisitedLinks):
1175         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1176
1177 2010-09-10  Tony Chang  <tony@chromium.org>
1178
1179         Reviewed by Eric Seidel.
1180
1181         deduplicate-tests should be runnable from any WebKit directory
1182         https://bugs.webkit.org/show_bug.cgi?id=44709
1183
1184         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1185         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1186
1187 2010-09-15  Tony Chang  <tony@chromium.org>
1188
1189         Reviewed by Kent Tamura.
1190
1191         [chromium] sort testing methods in DRT
1192         https://bugs.webkit.org/show_bug.cgi?id=45850
1193
1194         * DumpRenderTree/chromium/EventSender.cpp:
1195         (EventSender::EventSender):
1196         * DumpRenderTree/chromium/LayoutTestController.cpp:
1197         (LayoutTestController::LayoutTestController):
1198         * DumpRenderTree/chromium/TextInputController.cpp:
1199         (TextInputController::TextInputController):
1200
1201 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
1202
1203         Reviewed by Adam Barth.
1204
1205         CQ status shows items out of order
1206         https://bugs.webkit.org/show_bug.cgi?id=45846
1207         
1208         Only group consecutive status items with the same patch ID into the same
1209         group, so that overall item ordering is preserved.
1210         
1211         Also don't indent status items that only have a single item in their
1212         group.
1213
1214         * QueueStatusServer/handlers/queuestatus.py:
1215         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
1216         * QueueStatusServer/templates/queuestatus.html:
1217
1218 2010-09-15  Eric Seidel  <eric@webkit.org>
1219
1220         Reviewed by Adam Barth.
1221
1222         Add queue start/stop messages
1223         https://bugs.webkit.org/show_bug.cgi?id=45853
1224
1225         I ended up needing to clean up a bunch of our unit testing
1226         in order to test this new code path nicely.
1227
1228         There are also a few PEP8 changes needed to pass check-webkit-style.
1229
1230         * Scripts/webkitpy/tool/bot/queueengine.py:
1231         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1232         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1233         * Scripts/webkitpy/tool/commands/queues.py:
1234         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1235         * Scripts/webkitpy/tool/commands/queuestest.py:
1236         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1237
1238 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
1239
1240         https://bugs.webkit.org/show_bug.cgi?id=45849
1241         WKURLCreateWithCFURL crashes with null url
1242         
1243         Fix MiniBrowser crash when the url is not parseable.
1244
1245         * MiniBrowser/mac/BrowserWindowController.m:
1246         (-[BrowserWindowController fetch:]):
1247
1248 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
1249
1250         Unreviewed.
1251
1252         Adding myself to the committers list.
1253
1254         * Scripts/webkitpy/common/config/committers.py:
1255
1256 2010-09-14  Eric Seidel  <eric@webkit.org>
1257
1258         Reviewed by Adam Barth.
1259
1260         Make it possible to run more than one commit-queue instance
1261         https://bugs.webkit.org/show_bug.cgi?id=45786
1262
1263         Mostly we need to make sure the two (or more) instances get
1264         different patches to work on.  To do this, I re-worked
1265         the code responsible for getting the next work item to
1266         round trip through the status server.  The status server only
1267         vends patches from the work items list, only if those patches
1268         have not had status reported for them in the last hour.
1269
1270         This is another step towards making all queues go through the
1271         status server, thus making it possible to run more than one
1272         instance of various EWS bots (as requested in bug 44292).
1273
1274         The webkitpy changes are already covered by existing unit tests.
1275         The QueueStatusSever sadly has no testing infrastructure yet. :(
1276
1277         * QueueStatusServer/handlers/nextpatch.py: Added.
1278         * QueueStatusServer/index.yaml:
1279         * QueueStatusServer/main.py:
1280         * Scripts/webkitpy/tool/commands/queues.py:
1281
1282 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
1283
1284         Reviewed by Tony Chang.
1285
1286         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
1287         https://bugs.webkit.org/show_bug.cgi?id=45791
1288
1289         Force filenames to be raw bytes before running difflib.unified_diff.
1290
1291         * Scripts/webkitpy/layout_tests/port/base.py:
1292         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1293
1294 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
1295
1296         Reviewed by Tor Arne Vestbø.
1297
1298         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
1299         https://bugs.webkit.org/show_bug.cgi?id=35247
1300
1301         The main issue when changing the views is that the plugins and any other components that
1302         depend on view specific attributes such as the native window id are not teared down.
1303         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
1304         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
1305         we decided to work around this in QtTestBrowser by making toggling between QWebView
1306         and QGraphicsWebView also re-create the page.
1307
1308         * QtTestBrowser/launcherwindow.cpp:
1309         (LauncherWindow::initializeView):
1310         * QtTestBrowser/mainwindow.h:
1311
1312 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
1313
1314         Reviewed by Adam Barth.
1315
1316         Send webkit accessibility notifications to Chromium
1317         https://bugs.webkit.org/show_bug.cgi?id=45156
1318
1319         Move printf inside shouldDumpAccessibilityNotifications check.
1320
1321         * DumpRenderTree/chromium/WebViewHost.cpp:
1322         (WebViewHost::postAccessibilityNotification):
1323
1324 2010-09-14  Tony Chang  <tony@chromium.org>
1325
1326         Reviewed by Kent Tamura.
1327
1328         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
1329         https://bugs.webkit.org/show_bug.cgi?id=45788
1330
1331         * DumpRenderTree/chromium/LayoutTestController.cpp:
1332         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
1333
1334 2010-09-14  Tony Chang  <tony@chromium.org>
1335
1336         Reviewed by Ojan Vafai.
1337
1338         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
1339         https://bugs.webkit.org/show_bug.cgi?id=45768
1340
1341         * DumpRenderTree/chromium/TestShell.cpp:
1342         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
1343
1344 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1345
1346         [wx] Build fix, add newly added directories to the directory list.
1347
1348         * wx/build/settings.py:
1349
1350 2010-09-14  Sam Weinig  <sam@webkit.org>
1351
1352         Reviewed by Anders Carlsson.
1353
1354         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
1355         https://bugs.webkit.org/show_bug.cgi?id=45785
1356
1357         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1358         (WTR::propertyValue):
1359         (WTR::numericWindowPropertyValue):
1360         (WTR::dumpPath):
1361         (WTR::toStr):
1362         (WTR::operator<<):
1363         (WTR::InjectedBundlePage::InjectedBundlePage):
1364         (WTR::InjectedBundlePage::shouldInsertNode):
1365         (WTR::InjectedBundlePage::shouldBeginEditing):
1366         (WTR::InjectedBundlePage::shouldEndEditing):
1367         (WTR::InjectedBundlePage::shouldInsertText):
1368         (WTR::InjectedBundlePage::shouldDeleteRange):
1369         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1370         (WTR::InjectedBundlePage::shouldApplyStyle):
1371         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1372
1373 2010-09-14  Adam Barth  <abarth@webkit.org>
1374
1375         Fix two typos in commit-queue.  The first is harmless.  The second
1376         causes the queue to reject patches when the build is broken.  :(
1377
1378         * Scripts/webkitpy/tool/commands/queues.py:
1379         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1380
1381 2010-09-14  Chris Guillory   <chris.guillory@google.com>
1382
1383         Reviewed by Chris Fleizach.
1384
1385         Send all accessibility notifications to Chromium.
1386         https://bugs.webkit.org/show_bug.cgi?id=45156
1387
1388         * DumpRenderTree/chromium/WebViewHost.cpp:
1389         (WebViewHost::postAccessibilityNotification):
1390         * DumpRenderTree/chromium/WebViewHost.h:
1391
1392 2010-09-14  Adam Barth  <abarth@webkit.org>
1393
1394         Reviewed by Eric Seidel.
1395
1396         commit-queue is slow during the day
1397         https://bugs.webkit.org/show_bug.cgi?id=45780
1398
1399         Thanks to the new logging, we've noticed that checkout-is-out-of-date
1400         errors in the first pass of landing don't retry the land.  Instead,
1401         they're treated as failures and cause the commit-queue to do two more
1402         builds before really trying to land the patch.  Worse, in the second
1403         build, we can get bitten by a flaky test.
1404
1405         This patch takes a slightly different approach to the commit-queue's
1406         main control logic.  We now use a separate subprocess for building and
1407         testing and for landing.  This means we should very rarely see the
1408         checkout-is-out-of-date error, and when we do see it, we should retry
1409         more quickly.  If my understanding is correct, this should be a big
1410         speed win for the commit-queue.
1411
1412         * Scripts/webkitpy/tool/commands/download.py:
1413         * Scripts/webkitpy/tool/commands/queues.py:
1414         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1415
1416 2010-09-14  Tony Chang  <tony@chromium.org>
1417
1418         Reviewed by Dimitri Glazkov.
1419
1420         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
1421         https://bugs.webkit.org/show_bug.cgi?id=45762
1422
1423         * DumpRenderTree/chromium/LayoutTestController.cpp:
1424         (LayoutTestController::LayoutTestController):
1425         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1426         * DumpRenderTree/chromium/LayoutTestController.h:
1427
1428 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
1429
1430         Adding myself as a reviewer.
1431
1432         * Scripts/webkitpy/common/config/committers.py:
1433
1434 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
1435
1436         Reviewed by Kenneth Rohde Christiansen.
1437
1438         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
1439         https://bugs.webkit.org/show_bug.cgi?id=45736
1440
1441         Build-webkit has showed a warning when WebKitBuild didn't exist, add
1442         an additional condition to avoid it.
1443
1444         * Scripts/build-webkit:
1445
1446 2010-09-13  Eric Seidel  <eric@webkit.org>
1447
1448         Reviewed by Adam Barth.
1449
1450         commit-queue should log when it's retrying due to checkout out of date error
1451         https://bugs.webkit.org/show_bug.cgi?id=45725
1452
1453         This will allow us to better track how often we see these errors
1454         and how long it takes the queue to recover from them.
1455
1456         In order to pass the tests, I had to correct an error
1457         from a previous change.  The UnitTestPort should not have
1458         ever been using the base port method as that will read
1459         a file from disk.  If the unit tests haven't passed the contents
1460         it should raise an IOError as though the file doesn't exist.
1461
1462         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1463         * Scripts/webkitpy/tool/commands/queues.py:
1464         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1465
1466 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
1467
1468         Reviewed by Adam Barth.
1469
1470         Upload results when cq patch landing fails
1471         https://bugs.webkit.org/show_bug.cgi?id=45683
1472         
1473         Include script errors when CommitQueue._land fails.
1474
1475         * Scripts/webkitpy/tool/commands/queues.py:
1476
1477 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1478
1479         Reviewed by David Kilzer.
1480
1481         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
1482         https://bugs.webkit.org/show_bug.cgi?id=45548
1483
1484         * DumpRenderTree/AccessibilityUIElement.cpp:
1485         (isIgnoredCallback):
1486         (AccessibilityUIElement::getJSClass):
1487         * DumpRenderTree/AccessibilityUIElement.h:
1488         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1489         (AccessibilityUIElement::isIgnored):
1490         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1491         (AccessibilityUIElement::isIgnored):
1492         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1493         (AccessibilityUIElement::isIgnored):
1494
1495 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1496
1497         Reviewed by Andreas Kling.
1498
1499         jscPath() is incorrect in Windows' cmd.exe shell
1500         https://bugs.webkit.org/show_bug.cgi?id=45651
1501
1502         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
1503
1504 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1505
1506         Reviewed by Darin Adler.
1507
1508         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
1509         https://bugs.webkit.org/show_bug.cgi?id=43807
1510
1511         * DumpRenderTree/AccessibilityUIElement.cpp:
1512         (textMarkerForPointCallback):
1513         (AccessibilityUIElement::textMarkerForPoint):
1514         (AccessibilityUIElement::getJSClass):
1515         * DumpRenderTree/AccessibilityUIElement.h:
1516         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1517         (AccessibilityUIElement::textMarkerForPoint):
1518
1519 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
1520
1521         Reviewed by Kenneth Rohde Christiansen.
1522
1523         [Qt] build-webkit: Add --v8 option to build against V8
1524
1525         Note that V8 is picked up from QtScript, so this currently requires building
1526         against the experimental qt-script-v8 branch.
1527
1528         * Scripts/build-webkit:
1529
1530 2010-09-13  Hans Wennborg  <hans@chromium.org>
1531
1532         Reviewed by Jeremy Orlow.
1533
1534         Add WebDeviceOrientationClientMock::create() and use it from DRT.
1535         https://bugs.webkit.org/show_bug.cgi?id=45650
1536
1537         Do not use the WebDeviceOrientationClientMock constructor directly,
1538         but use the create() member function.
1539
1540         This should fix the linker errors for the multi-DLL Chromium DRT build.
1541
1542         * DumpRenderTree/chromium/LayoutTestController.cpp:
1543         (LayoutTestController::setMockDeviceOrientation):
1544         (LayoutTestController::deviceOrientationClient):
1545
1546 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1547
1548         Reviewed by Antti Koivisto.
1549
1550         Add support for testing the viewport meta tag algorithm,
1551         based on the following draft spec:
1552
1553         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
1554
1555         Add common handling of viewport meta tag based on new Opera spec
1556         https://bugs.webkit.org/show_bug.cgi?id=44201
1557
1558         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1559         (LayoutTestController::dumpConfigurationForViewport):
1560         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1561
1562 2010-09-12  Kent Tamura  <tkent@chromium.org>
1563
1564         Reviewed by Tony Chang.
1565
1566         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
1567         https://bugs.webkit.org/show_bug.cgi?id=45517
1568
1569         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
1570
1571         * DumpRenderTree/chromium/ImageDiff.cpp:
1572         (Image::craeteFromStdin):
1573         (Image::createFromFilename):
1574         (diffImages):
1575         * DumpRenderTree/chromium/TestShell.cpp:
1576         (TestShell::dumpImage):
1577
1578 2010-09-10  MORITA Hajime  <morrita@google.com>
1579
1580         Reviewed by Tony Chang.
1581
1582         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
1583         https://bugs.webkit.org/show_bug.cgi?id=45441
1584
1585         Added TextInputController::hasSpellingMarker().
1586         
1587         * DumpRenderTree/chromium/TextInputController.cpp:
1588         (TextInputController::TextInputController):
1589         (TextInputController::hasSpellingMarker):
1590         * DumpRenderTree/chromium/TextInputController.h:
1591
1592 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
1593
1594         Unreviewed, build fix.
1595
1596         My last change accidentally contained a local change to the
1597         rebaselinig script; webkit-patch land picked it up without telling
1598         me and committed it :(
1599
1600         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1601
1602 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
1603
1604         Reviewed by Anders Carlsson.
1605
1606         Attempt to fix Windows MiniBrowser build (untested)
1607         https://bugs.webkit.org/show_bug.cgi?id=45609
1608
1609         * MiniBrowser/win/BrowserView.cpp:
1610         (runJavaScriptConfirm):
1611         (runJavaScriptPrompt):
1612
1613 2010-09-11  Sam Weinig  <sam@webkit.org>
1614
1615         Reviewed by Maciej Stachowiak.
1616
1617         Fix zoom related tests when testing WebKit2.
1618
1619         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1620         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
1621
1622 2010-09-11  Sam Weinig  <sam@webkit.org>
1623
1624         Reviewed by Dan Bernstein.
1625
1626         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
1627         <rdar://problem/8359252>
1628         https://bugs.webkit.org/show_bug.cgi?id=45605
1629
1630         * MiniBrowser/mac/BrowserWindowController.m:
1631         (setStatusText):
1632         (contentsSizeChanged):
1633         (-[BrowserWindowController awakeFromNib]):
1634         * MiniBrowser/win/BrowserView.cpp:
1635         (runJavaScriptConfirm):
1636         (runJavaScriptPrompt):
1637         (setStatusText):
1638         (contentsSizeChanged):
1639         (BrowserView::create):
1640         * WebKitTestRunner/TestController.cpp:
1641         (WTR::createOtherPage):
1642         (WTR::TestController::initialize):
1643
1644 2010-09-11  Sam Weinig  <sam@webkit.org>
1645
1646         Reviewed by Dan Bernstein.
1647
1648         Add callback mechanism for the getting the source of a frame
1649         <rdar://problem/8364681>
1650         https://bugs.webkit.org/show_bug.cgi?id=45604
1651
1652         Add ability to dump the main frame's source to the console.
1653
1654         * MiniBrowser/mac/BrowserWindowController.h:
1655         * MiniBrowser/mac/BrowserWindowController.m:
1656         (-[BrowserWindowController dumpSourceToConsole:]):
1657         * MiniBrowser/mac/MainMenu.xib:
1658
1659 2010-09-11  Eric Seidel  <eric@webkit.org>
1660
1661         Reviewed by Adam Barth.
1662
1663         Remove unneeded Empty Queue messages
1664         https://bugs.webkit.org/show_bug.cgi?id=45602
1665
1666         We already have a /gc job to delete these.
1667         recentstatus.py is already smart enough to use the
1668         most recent of the workitems last update or the most recent status,
1669         so removing these should not change the _last_status_date() return
1670         value more than a few milliseconds.
1671
1672         These messages just spam the recent status log.
1673
1674         * Scripts/webkitpy/tool/commands/queues.py:
1675
1676 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1677
1678         Reviewed by Adam Barth.
1679
1680         Fix Python exception when generating synthetic patch IDs
1681         https://bugs.webkit.org/show_bug.cgi?id=45592
1682
1683         Can't concatenate strings and numbers directly.
1684
1685         * QueueStatusServer/handlers/queuestatus.py:
1686
1687 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1688
1689         Reviewed by Adam Barth.
1690
1691         Group statuses in queue status by patch ID
1692         https://bugs.webkit.org/show_bug.cgi?id=45588
1693
1694         Group statuses by patch ID so that the status page is easier
1695         to scan.
1696
1697         * QueueStatusServer/handlers/queuestatus.py:
1698         * QueueStatusServer/stylesheets/dashboard.css:
1699         (.status-group):
1700         (.status-bug):
1701         (.status-group ul):
1702         (.status-group ul li):
1703         (.status-group ul li:hover):
1704         (.status-cell):
1705         (.status-cell:hover):
1706         (.status-cell.pass):
1707         (.status-cell.fail):
1708         (.status-cell.pending):
1709         (.status-cell.error):
1710         * QueueStatusServer/templates/dashboard.html:
1711         * QueueStatusServer/templates/queuestatus.html:
1712
1713 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1714
1715         Reviewed by Tony Chang.
1716
1717         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1718         https://bugs.webkit.org/show_bug.cgi?id=45479
1719
1720         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1721         implementation in ResourceLoadDelegate in the Mac port).
1722
1723         * DumpRenderTree/chromium/LayoutTestController.cpp:
1724         (LayoutTestController::LayoutTestController):
1725         (LayoutTestController::dumpResourceResponseMIMETypes):
1726         (LayoutTestController::reset):
1727         * DumpRenderTree/chromium/LayoutTestController.h:
1728         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1729         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1730         * DumpRenderTree/chromium/TestShell.h:
1731         (TestShell::shouldDumpResourceResponseMIMETypes):
1732         * DumpRenderTree/chromium/WebViewHost.cpp:
1733         (WebViewHost::didReceiveResponse):
1734
1735 2010-09-11  Eric Seidel  <eric@webkit.org>
1736
1737         Reviewed by Adam Barth.
1738
1739         queues.webkit.org should expose /remote_api for data upload/download
1740         https://bugs.webkit.org/show_bug.cgi?id=45559
1741
1742         * QueueStatusServer/app.yaml:
1743          - /remote_api is a standard app-engine service which allows use of
1744            the bulk uploader for data upload/download.  Exposing this
1745            (for admin access only) allows us to use 
1746
1747 2010-09-10  Sam Weinig  <sam@webkit.org>
1748
1749         Reviewed by Dan Bernstein.
1750
1751         Add zoom support to WebKit2 API
1752         <rdar://problem/7660657>
1753         https://bugs.webkit.org/show_bug.cgi?id=45585
1754
1755         - Add zoom options to MiniBrowser that mimic Safari's options using
1756           the new WebKit2 zoom APIs.
1757         - Switch uses of float for the zoom APIs to use double.
1758
1759         * MiniBrowser/mac/BrowserWindowController.h:
1760         * MiniBrowser/mac/BrowserWindowController.m:
1761         (-[BrowserWindowController initWithPageNamespace:]):
1762         (-[BrowserWindowController validateMenuItem:]):
1763         (-[BrowserWindowController validateUserInterfaceItem:]):
1764         (-[BrowserWindowController currentZoomFactor]):
1765         (-[BrowserWindowController setCurrentZoomFactor:]):
1766         (-[BrowserWindowController canZoomIn]):
1767         (-[BrowserWindowController zoomIn:]):
1768         (-[BrowserWindowController canZoomOut]):
1769         (-[BrowserWindowController zoomOut:]):
1770         (-[BrowserWindowController canResetZoom]):
1771         (-[BrowserWindowController resetZoom:]):
1772         (-[BrowserWindowController toggleZoomMode:]):
1773         * MiniBrowser/mac/MainMenu.xib:
1774         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1775         (WTR::EventSendingController::textZoomIn):
1776         (WTR::EventSendingController::textZoomOut):
1777         (WTR::EventSendingController::zoomPageIn):
1778         (WTR::EventSendingController::zoomPageOut):
1779
1780 2010-09-10  Robert Hogan  <robert@webkit.org>
1781
1782         Reviewed by Andreas Kling.
1783
1784         [Qt] Fix crash in DRT in standalone mode
1785
1786         https://bugs.webkit.org/show_bug.cgi?id=45454
1787
1788         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1789         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1790
1791 2010-09-10  Sam Weinig  <sam@webkit.org>
1792
1793         Reviewed by Darin Adler.
1794
1795         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
1796         Precursor to <rdar://problem/7660657>
1797         https://bugs.webkit.org/show_bug.cgi?id=45522
1798
1799         Update for changes to the Bundle API to allow separate control of page and text zoom
1800         levels.
1801
1802         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1803         (WTR::EventSendingController::textZoomIn):
1804         (WTR::EventSendingController::textZoomOut):
1805         (WTR::EventSendingController::zoomPageIn):
1806         (WTR::EventSendingController::zoomPageOut):
1807         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1808         (WTR::InjectedBundlePage::reset):
1809
1810 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
1811
1812         Reviewed by Andreas Kling.
1813
1814         [Qt] Support click event for notifications
1815         https://bugs.webkit.org/show_bug.cgi?id=44836
1816
1817         Add support for simulateDesktopNotificationClick by calling
1818         back to DumpRenderTreeSupportQt.cpp.
1819
1820         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1821         (LayoutTestController::simulateDesktopNotificationClick):
1822         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1823
1824 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
1825
1826         Reviewed by Eric Seidel.
1827
1828         Update queue status when patches fail their first land attempt
1829         https://bugs.webkit.org/show_bug.cgi?id=45583
1830
1831         Add a few more _update_status calls to make it more obvious if a patch is 
1832         being retried because tests failed.
1833
1834         * Scripts/webkitpy/tool/commands/queues.py:
1835
1836 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
1837
1838         Reviewed by Andreas Kling.
1839
1840         [Qt] MiniBrowser crashes with multiply windows when closing one of them
1841         https://bugs.webkit.org/show_bug.cgi?id=45536
1842
1843         * MiniBrowser/qt/BrowserView.cpp:
1844         (BrowserView::BrowserView): Reference the context instead of adopting it
1845         because it can be shared across different views.
1846
1847 2010-09-10  Tony Chang  <tony@chromium.org>
1848
1849         Unreviewed, rolling out r67241.
1850         http://trac.webkit.org/changeset/67241
1851         https://bugs.webkit.org/show_bug.cgi?id=44709
1852
1853         Accidentally committed.
1854
1855         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1856         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1857
1858 2010-09-10  Tony Chang  <tony@chromium.org>
1859
1860         Reviewed by Ojan Vafai.
1861
1862         deduplicate-tests should be runnable from any WebKit directory
1863         https://bugs.webkit.org/show_bug.cgi?id=44709
1864
1865         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1866         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1867
1868 2010-09-10  Tony Chang  <tony@chromium.org>
1869
1870         Unreviewed, rolling out r67216.
1871         http://trac.webkit.org/changeset/67216
1872         https://bugs.webkit.org/show_bug.cgi?id=44709
1873
1874         Broke
1875
1876         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1877         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1878
1879 2010-09-10  Tony Chang  <tony@chromium.org>
1880
1881         Reviewed by Ojan Vafai.
1882
1883         deduplicate-tests should be runnable from any WebKit directory
1884         https://bugs.webkit.org/show_bug.cgi?id=44709
1885
1886         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1887         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1888
1889 2010-09-09  Hans Wennborg  <hans@chromium.org>
1890
1891         Reviewed by Jeremy Orlow.
1892
1893         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
1894         https://bugs.webkit.org/show_bug.cgi?id=45460
1895
1896         This enables DumpRenderTree to run layout tests for DeviceOrientation.
1897
1898         Also declare the LayoutTestController destructor out-of-line.
1899         Otherwise the implicit destructor would cause compiler errors because
1900         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
1901
1902         * DumpRenderTree/chromium/LayoutTestController.cpp:
1903         (LayoutTestController::~LayoutTestController):
1904         (LayoutTestController::setMockDeviceOrientation):
1905         (LayoutTestController::deviceOrientationClient):
1906         * DumpRenderTree/chromium/LayoutTestController.h:
1907         * DumpRenderTree/chromium/WebViewHost.cpp:
1908         (WebViewHost::deviceOrientationClient):
1909         * DumpRenderTree/chromium/WebViewHost.h:
1910
1911 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1912
1913         Unreviewed, rolling out r67119.
1914         http://trac.webkit.org/changeset/67119
1915         https://bugs.webkit.org/show_bug.cgi?id=45505
1916
1917         Extra newlines in results (Requested by tony^work on #webkit).
1918
1919         * DumpRenderTree/chromium/LayoutTestController.cpp:
1920         (LayoutTestController::LayoutTestController):
1921         (LayoutTestController::reset):
1922         * DumpRenderTree/chromium/LayoutTestController.h:
1923         * DumpRenderTree/chromium/TestShell.h:
1924         * DumpRenderTree/chromium/WebViewHost.cpp:
1925         (printResponseDescription):
1926         (printNodeDescription):
1927         (printRangeDescription):
1928         (WebViewHost::shouldBeginEditing):
1929         (WebViewHost::shouldEndEditing):
1930         (WebViewHost::shouldInsertNode):
1931         (WebViewHost::shouldChangeSelectedRange):
1932         (WebViewHost::shouldDeleteRange):
1933         (WebViewHost::shouldApplyStyle):
1934         (WebViewHost::didBeginEditing):
1935         (WebViewHost::didChangeSelection):
1936         (WebViewHost::didChangeContents):
1937         (WebViewHost::didEndEditing):
1938         (WebViewHost::decidePolicyForNavigation):
1939         (WebViewHost::didCancelClientRedirect):
1940         (WebViewHost::didStartProvisionalLoad):
1941         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1942         (WebViewHost::didFailProvisionalLoad):
1943         (WebViewHost::didCommitProvisionalLoad):
1944         (WebViewHost::didFinishDocumentLoad):
1945         (WebViewHost::didHandleOnloadEvents):
1946         (WebViewHost::didFailLoad):
1947         (WebViewHost::didFinishLoad):
1948         (WebViewHost::didChangeLocationWithinPage):
1949         (WebViewHost::willSendRequest):
1950         (WebViewHost::didReceiveResponse):
1951         (WebViewHost::didFinishResourceLoad):
1952         (WebViewHost::didFailResourceLoad):
1953         (WebViewHost::didDisplayInsecureContent):
1954         (WebViewHost::didRunInsecureContent):
1955         (WebViewHost::printFrameDescription):
1956
1957 2010-09-09  Michael Saboff  <msaboff@apple.com>
1958
1959         Unreviewed, adding myself to committers list.
1960
1961         * Scripts/webkitpy/common/config/committers.py:
1962
1963 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1964
1965         Reviewed by Tony Chang.
1966
1967         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1968         https://bugs.webkit.org/show_bug.cgi?id=45479
1969
1970         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1971         implementation in ResourceLoadDelegate in the Mac port).
1972
1973         * DumpRenderTree/chromium/LayoutTestController.cpp:
1974         (LayoutTestController::LayoutTestController):
1975         (LayoutTestController::dumpResourceResponseMIMETypes):
1976         (LayoutTestController::reset):
1977         * DumpRenderTree/chromium/LayoutTestController.h:
1978         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1979         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1980         * DumpRenderTree/chromium/TestShell.h:
1981         (TestShell::shouldDumpResourceResponseMIMETypes):
1982         * DumpRenderTree/chromium/WebViewHost.cpp:
1983         (WebViewHost::didReceiveResponse):
1984
1985 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1986
1987         Reviewed by Daniel Bates.
1988
1989         svn-apply tries to delete directories it shouldn't
1990         https://bugs.webkit.org/show_bug.cgi?id=45424
1991
1992         isDirectoryEmptyForRemoval had the wrong check. If an item in the
1993         directory is itself a directory, then the directory is definitely
1994         not empty.
1995
1996         * Scripts/svn-apply:
1997
1998 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
1999
2000         Fixing GTK and windows build failure.
2001
2002         AX: Support AccessibilityTextMarkers in DRT
2003         https://bugs.webkit.org/show_bug.cgi?id=44778
2004
2005         * DumpRenderTree/AccessibilityTextMarker.h:
2006         (AccessibilityTextMarker::platformTextMarker):
2007         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2008         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2009         (AccessibilityTextMarker::platformTextMarker):
2010         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2011
2012 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
2013
2014         Reviewed by David Kilzer.
2015
2016         AX: Support AccessibilityTextMarkers in DRT
2017         https://bugs.webkit.org/show_bug.cgi?id=44778
2018
2019         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
2020         that WebCore uses when vending information about its VisiblePositions through AX.
2021
2022         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
2023         methods for encapsulating and checking equality.
2024
2025         This will allow future bug fixes in the text marker system to be adequately tested.
2026
2027         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
2028         (toTextMarker):
2029         (isMarkerEqualCallback):
2030         (markerFinalize):
2031         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
2032         (AccessibilityTextMarker::getJSClass):
2033         (toTextMarkerRange):
2034         (isMarkerRangeEqualCallback):
2035         (markerRangeFinalize):
2036         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
2037         (AccessibilityTextMarkerRange::getJSClass):
2038         * DumpRenderTree/AccessibilityTextMarker.h: Added.
2039         (AccessibilityTextMarker::platformTextMarker):
2040         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2041         (AccessibilityTextMarker::AccessibilityTextMarker):
2042         (AccessibilityTextMarker::~AccessibilityTextMarker):
2043         (AccessibilityTextMarker::isEqual):
2044         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2045         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2046         (AccessibilityTextMarkerRange::isEqual):
2047         * DumpRenderTree/AccessibilityUIElement.cpp:
2048         (textMarkerRangeForElementCallback):
2049         (textMarkerRangeLengthCallback):
2050         (textMarkerRangeForMarkersCallback):
2051         (startTextMarkerForTextMarkerRangeCallback):
2052         (endTextMarkerForTextMarkerRangeCallback):
2053         (accessibilityElementForTextMarkerCallback):
2054         (AccessibilityUIElement::textMarkerRangeForElement):
2055         (AccessibilityUIElement::textMarkerRangeLength):
2056         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2057         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2058         (AccessibilityUIElement::accessibilityElementForTextMarker):
2059         (AccessibilityUIElement::getJSClass):
2060         * DumpRenderTree/AccessibilityUIElement.h:
2061         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2062         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
2063         (AccessibilityTextMarker::AccessibilityTextMarker):
2064         (AccessibilityTextMarker::~AccessibilityTextMarker):
2065         (AccessibilityTextMarker::isEqual):
2066         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2067         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2068         (AccessibilityTextMarkerRange::isEqual):
2069         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2070         (AccessibilityUIElement::textMarkerRangeForElement):
2071         (AccessibilityUIElement::textMarkerRangeLength):
2072         (AccessibilityUIElement::textMarkerRangeForMarkers):
2073         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2074         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2075         (AccessibilityUIElement::accessibilityElementForTextMarker):
2076         * DumpRenderTree/win/DumpRenderTree.vcproj:
2077
2078 2010-08-25  Tony Chang  <tony@chromium.org>
2079
2080         Reviewed by Ojan Vafai.
2081
2082         don't delete duplicates needed because of intermediate results
2083         https://bugs.webkit.org/show_bug.cgi?id=44653
2084
2085         Also, output the full path so we can pipe the output to rm.
2086
2087         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2088         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2089
2090 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
2091
2092         Reviewed by Andreas Kling.
2093
2094         [Qt] MiniBrowser does not starts properly
2095         https://bugs.webkit.org/show_bug.cgi?id=45459
2096
2097         Do not try set up the first window by calling newWindow on a
2098         newly created BrowserWindow since it creates a new object.
2099         * MiniBrowser/qt/BrowserWindow.cpp:
2100         (BrowserWindow::BrowserWindow):
2101         * MiniBrowser/qt/main.cpp:
2102         (main):
2103
2104 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
2105
2106         Reviewed by Xan Lopez.
2107
2108         [GTK] Get ImageDiff building on Win32
2109         https://bugs.webkit.org/show_bug.cgi?id=45353
2110
2111         * DumpRenderTree/gtk/ImageDiff.cpp:
2112         (main): Switch from using strtok to g_strsplit.
2113
2114 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
2115
2116         Reviewed by Andreas Kling.
2117
2118         [Qt] Modify load method of MiniBrowser's BrowserView class
2119         https://bugs.webkit.org/show_bug.cgi?id=45442
2120
2121         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
2122
2123         * MiniBrowser/qt/BrowserView.cpp:
2124         (BrowserView::load):
2125         * MiniBrowser/qt/BrowserView.h:
2126         * MiniBrowser/qt/BrowserWindow.cpp:
2127         (BrowserWindow::load):
2128
2129 2010-09-09  Tony Chang  <tony@chromium.org>
2130
2131         Reviewed by Ojan Vafai.
2132
2133         fix show_results in new-run-webkit-tests
2134         https://bugs.webkit.org/show_bug.cgi?id=45413
2135
2136         * Scripts/webkitpy/layout_tests/port/chromium.py:
2137
2138 2010-09-08  Victor Wang  <victorw@chromium.org>
2139
2140         Reviewed by Ojan Vafai.
2141
2142         [Chromium] Fix test results server to make sure
2143         it does not have corrupted data.
2144
2145         results.json file size coulbe be >1M and we split
2146         the data into multiple data store entries in this
2147         case. This patch fixes the issue that the data may
2148         be corrupted if data store error happens in the middle
2149         of saving multiple entries.
2150
2151         https://bugs.webkit.org/show_bug.cgi?id=45063
2152
2153         * TestResultServer/model/datastorefile.py:
2154
2155 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
2156
2157         Reviewed by Kenneth Rohde Christiansen.
2158
2159         Fix ignoring return value warning in case of gcc 4.4.4
2160         https://bugs.webkit.org/show_bug.cgi?id=45384
2161
2162         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2163         (testPostURLFile):
2164         If fwrite have written zero byte then the testPostURLFile function
2165         returns with false as tempFile can't be opened.
2166         * DumpRenderTree/qt/ImageDiff.cpp:
2167         (main):
2168         Put fwrite function into an if condition without body to avoid
2169         warning. It is safe because this function writes to the stdout.
2170
2171 2010-09-08  Satish Sampath  <satish@chromium.org>
2172
2173         Unreviewed, adding myself to committers list.
2174
2175         * Scripts/webkitpy/common/config/committers.py:
2176
2177 2010-09-08  Hans Wennborg  <hans@chromium.org>
2178
2179         Unreviewed.
2180
2181         Adding myself as a committer in committers.py.
2182
2183         * Scripts/webkitpy/common/config/committers.py:
2184
2185 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
2186
2187         Reviewed by Simon Hausmann.
2188
2189         [Qt] Refactor MiniBrowser 
2190         https://bugs.webkit.org/show_bug.cgi?id=45173
2191
2192         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
2193
2194         * MiniBrowser/qt/BrowserView.cpp: Added.
2195         (createNewPage):
2196         (BrowserView::BrowserView):
2197         (BrowserView::resizeEvent):
2198         (BrowserView::load):
2199         (BrowserView::view):
2200         * MiniBrowser/qt/BrowserView.h: Added.
2201         (BrowserView::~BrowserView):
2202         * MiniBrowser/qt/BrowserWindow.cpp:
2203         * MiniBrowser/qt/BrowserWindow.h:
2204         * MiniBrowser/qt/MiniBrowser.pro:
2205
2206 2010-09-08  Adam Barth  <abarth@webkit.org>
2207
2208         Rubber-stamped by Eric Seidel.
2209
2210         Rename DocLoader to CachedResourceLoader because that's what it does.
2211
2212         * Scripts/do-webcore-rename:
2213
2214 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
2215
2216         Reviewed by Ojan Vafai.
2217
2218         Enable incremental results.json generation for non-layout tests.
2219         https://bugs.webkit.org/show_bug.cgi?id=45315
2220
2221         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
2222
2223         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
2224
2225
2226 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
2227
2228         Unreviewed, build fix
2229
2230         Missed one test in mac_unittest.py in previous change; for some
2231         reason the method is listed twice. I will fix both for now, but will
2232         figure this out in a later, not-time-sensitive patch.
2233
2234         https://bugs.webkit.org/show_bug.cgi?id=45357
2235
2236         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2237
2238 2010-09-07  Kent Tamura  <tkent@chromium.org>
2239
2240         Reviewed by Tony Chang.
2241
2242         test-webkitpy: Fix load error of
2243         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
2244         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
2245
2246         * Scripts/webkitpy/layout_tests/port/server_process.py:
2247           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
2248           and we don't use server_process.py on Win32 Python. However
2249           unittest.py tries to load everything in a module.
2250
2251 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
2252
2253         Reviewed by Kent Tamura.
2254
2255         Fix regression introduced in previous change to new-run-webkit-tests
2256         (bug 45090) to not try to run unittests for the Mac implementation
2257         of the Port interface if we aren't running on a Mac.
2258
2259         Also fix the overrides implementation mock in the chromium unittests
2260         to fix the case where there are overrides checked in that cause
2261         problems.
2262
2263         https://bugs.webkit.org/show_bug.cgi?id=45357
2264
2265         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2266         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2267         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2268
2269 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
2270
2271         Reviewed by Ojan Vafai.
2272
2273         new-run-webkit-tests: still more unit tests
2274
2275         Clean up and remove unnecessary code. Biggest notable change is
2276         moving the chromium-specific imagediff code from port/base to
2277         port/chromium.
2278
2279         Add more unit tests for run_webkit_tests.py, port/base.py,
2280         port/factory.py, port/dryrun.py, and
2281         layout_package/dump_render_tree_thread.py
2282
2283         This covers almost all of the generic and test code paths except for
2284         a few error paths involving invalid or port-specific command line
2285         arguments, and the code path for uploading results files to the
2286         buildbots.
2287         
2288         https://bugs.webkit.org/show_bug.cgi?id=45090
2289
2290         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
2291         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2292         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2293         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2294         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2295         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2296         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2297         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2298         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2299         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
2300         * Scripts/webkitpy/layout_tests/port/base.py:
2301         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2302         * Scripts/webkitpy/layout_tests/port/chromium.py:
2303         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2304         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2305         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2306         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
2307         * Scripts/webkitpy/layout_tests/port/server_process.py:
2308         * Scripts/webkitpy/layout_tests/port/test.py:
2309         * Scripts/webkitpy/layout_tests/port/webkit.py:
2310         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2311         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2312
2313 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
2314
2315         Reviewed by Darin Adler.
2316
2317         Provide a way to trigger a <select multiple> onchange event on changes
2318         https://bugs.webkit.org/show_bug.cgi?id=45192
2319
2320         Adds a selector on ObjCController for testing
2321         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
2322         its different uses.
2323
2324         * DumpRenderTree/mac/ObjCController.m:
2325         (+[ObjCController isSelectorExcludedFromWebScript:]):
2326         (+[ObjCController webScriptNameForSelector:]):
2327         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
2328
2329 2010-09-07  James Robinson  <jamesr@chromium.org>
2330
2331         Rubber-stamped by Dimitri Glazkov.
2332
2333         Move myself from the committer to the reviewer list.
2334
2335         * Scripts/webkitpy/common/config/committers.py:
2336
2337 2010-09-07  Tony Chang  <tony@chromium.org>
2338
2339         Reviewed by Darin Fisher.
2340
2341         [chromium] Make a public flag for how DRT generates bitmaps on Linux
2342         https://bugs.webkit.org/show_bug.cgi?id=45133
2343
2344         * DumpRenderTree/chromium/TestShell.cpp:
2345         (TestShell::dumpImage):
2346
2347 2010-09-07  Kent Tamura  <tkent@chromium.org>
2348
2349         Reviewed by Dimitri Glazkov.
2350
2351         [DRT/Chromium] Implement --check-layout-test-sys-deps
2352         https://bugs.webkit.org/show_bug.cgi?id=45283
2353
2354         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2355         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
2356         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
2357         * DumpRenderTree/chromium/TestShellGtk.cpp:
2358         (checkLayoutTestSystemDependencies): Add an empty implementation.
2359         * DumpRenderTree/chromium/TestShellMac.mm:
2360         (checkLayoutTestSystemDependencies): Add an empty implementation.
2361         * DumpRenderTree/chromium/TestShellWin.cpp:
2362         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
2363
2364 2010-09-07  Jessie Berlin  <jberlin@apple.com>
2365
2366         Unreviewed. Mac build fix.
2367
2368         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2369         (didClearWindowObjectForFrame):
2370
2371 2010-09-07  Jessie Berlin  <jberlin@apple.com>
2372
2373         Reviewed by Darin Adler.
2374
2375         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
2376         https://bugs.webkit.org/show_bug.cgi?id=45217
2377         
2378         Make WebKitTestRunner work with this change.
2379
2380         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2381         (WTR::InjectedBundlePage::didClearWindowForFrame):
2382         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
2383         WebFrameLoaderClient.
2384         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2385
2386 2010-09-07  Philippe Normand  <pnormand@igalia.com>
2387
2388         Unreviewed, build fix.
2389
2390         webkit-patch command to find the ports covering a specific layout test
2391         https://bugs.webkit.org/show_bug.cgi?id=42832
2392
2393         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
2394         tests are present when building the expectations. This is needed
2395         for the unittests.
2396
2397 2010-09-06  Philippe Normand  <pnormand@igalia.com>
2398
2399         Reviewed by Adam Barth.
2400
2401         webkit-patch command to find the ports covering a specific layout test
2402         https://bugs.webkit.org/show_bug.cgi?id=42832
2403
2404         To use it: webkit-patch skipped-ports some/layout/test.html
2405
2406         * Scripts/webkitpy/layout_tests/port/base.py:
2407         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2408         * Scripts/webkitpy/layout_tests/port/chromium.py:
2409         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2410         * Scripts/webkitpy/layout_tests/port/factory.py:
2411         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2412         * Scripts/webkitpy/layout_tests/port/test.py:
2413         * Scripts/webkitpy/layout_tests/port/webkit.py:
2414         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2415         * Scripts/webkitpy/tool/commands/queries.py:
2416         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2417         * Scripts/webkitpy/tool/main.py:
2418         * Scripts/webkitpy/tool/mocktool.py:
2419
2420 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2421
2422         Reviewed by Eric Seidel.
2423
2424         [NRWT] Add temp directory to all running drivers.
2425         https://bugs.webkit.org/show_bug.cgi?id=45261
2426
2427         * Scripts/webkitpy/layout_tests/port/webkit.py:
2428
2429 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
2430
2431         Reviewed by Kent Tamura.
2432
2433         [Chromium/DRT] Empty out user stylesheet after each test run.
2434         https://bugs.webkit.org/show_bug.cgi?id=45282
2435
2436         This should significantly cut down on the number of the mysterious flaky tests
2437         whose diffs looked like the page was blown up to a very lage size. This
2438         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
2439         which set the base body font to 100px.
2440
2441         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
2442         the same thread failed.
2443
2444         * DumpRenderTree/chromium/TestShell.cpp:
2445         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
2446
2447 2010-09-06  Kent Tamura  <tkent@chromium.org>
2448
2449         Reviewed by Dimitri Glazkov.
2450
2451         [DRT/Chromium] Do not generate pixel results for text/plain resources
2452         https://bugs.webkit.org/show_bug.cgi?id=45253
2453
2454         * DumpRenderTree/chromium/TestShell.cpp:
2455         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
2456
2457 2010-09-06  Ojan Vafai  <ojan@chromium.org>
2458
2459         Reviewed by Kent Tamura.
2460
2461         print out correct error when a DRT thread dies in NRWT
2462         https://bugs.webkit.org/show_bug.cgi?id=45281
2463
2464         Not sure why, but with the parens, python 2.6.5 on Linux
2465         gives an error that raise takes 5 arguments and 0 were given.
2466         Didn't test other platforms or python versions, but putting it
2467         all on one line fixes it and correctly prints the exception
2468         from the DRT thread.
2469
2470         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2471
2472 2010-09-06  Eric Seidel  <eric@webkit.org>
2473
2474         Unreviewed, just adding some emails from lists.webkit.org.
2475
2476         Update committers.py to include emails from lists.webkit.org
2477         as found by the validate-committer-lists script.
2478
2479         * Scripts/webkitpy/common/config/committers.py:
2480
2481 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2482
2483         Reviewed by Xan Lopez.
2484
2485         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
2486         https://bugs.webkit.org/show_bug.cgi?id=45213
2487
2488         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2489         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
2490         have to surround the invocation with #ifdefs.
2491         (useLongRunningServerMode): Added.
2492         (runTestingServerLoop): Added.
2493         (initializeGlobalsFromCommandLineOptions): Added.
2494         (runTest): Removed ifdefs.
2495         (main): Use new helper functions.
2496
2497 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2498
2499         Reviewed by Xan Lopez.
2500
2501         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
2502         https://bugs.webkit.org/show_bug.cgi?id=45235
2503
2504         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
2505         methods of the EventSender.
2506
2507         * DumpRenderTree/gtk/EventSender.cpp:
2508         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
2509         with the current modifiers.
2510         (contextClickCallback): Always send no modifiers when preparing the mouse event.
2511         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
2512         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
2513         (mouseUpCallback): Ditto.
2514
2515 2010-09-05  Peter Kasting  <pkasting@google.com>
2516
2517         Reviewed by Adam Barth.
2518
2519         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
2520         https://bugs.webkit.org/show_bug.cgi?id=45155
2521
2522         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
2523         (EventSender::handleMouseWheel):
2524
2525 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
2526
2527         Reviewed by Joseph Pecoraro.
2528
2529         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
2530         https://bugs.webkit.org/show_bug.cgi?id=45179
2531
2532         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2533         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2534
2535 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
2536
2537         Rubber-stamped by Daniel Bates.
2538
2539         Adding myself as reviewer.
2540
2541         * Scripts/webkitpy/common/config/committers.py:
2542
2543 2010-09-04  Daniel Bates  <dbates@rim.com>
2544
2545         Reviewed by Martin Robinson.
2546
2547         Teach svn-apply/unapply about svn:mergeinfo
2548         https://bugs.webkit.org/show_bug.cgi?id=45236
2549
2550         Recognize the svn:mergeinfo property and ignore it for now.
2551
2552         Currently, svn-apply/unapply recognize only '+' and '-'
2553         property changes within a diff. We should add support
2554         to recognize "Merged" and "Reverse-merged" changes as well.
2555         Because svn:mergeinfo is metadata that is used only by SVN
2556         and tends to be error-prone and/or nuisance (*), we will ignore
2557         it for now.
2558         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
2559
2560         * Scripts/VCSUtils.pm:
2561           - Modified parseSvnProperty() to recognize "Merged" and
2562             "Reverse-merged" as the start of a property value.
2563         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2564           - Added the following unit tests:
2565             "simple: add svn:mergeinfo"
2566             "simple: delete svn:mergeinfo"
2567             "simple: modified svn:mergeinfo"
2568         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2569           - Added the following unit tests:
2570             "simple: add svn:mergeinfo"
2571             "simple: delete svn:mergeinfo"
2572             "simple: modified svn:mergeinfo"
2573             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
2574             "'Merged' change followed by 'Merged' change"
2575             "'Reverse-merged' change followed by 'Reverse-merged' change"
2576         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2577           - Added the following unit tests:
2578             "'Merged' change"
2579             "'Reverse-merged' change"
2580             "'Reverse-merged' change followed by 'Merge' change"
2581             "'Merged' change followed by 'Merge' change"
2582             "'Reverse-merged' change followed by 'Reverse-merged' change"
2583             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
2584
2585 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2586
2587         Reviewed by Kenneth Rohde Christiansen.
2588
2589         [EFL] Move test browser to WebKitTools directory
2590         https://bugs.webkit.org/show_bug.cgi?id=45212
2591
2592         Follow other ports like QT and GTK which moved the test browser to
2593         WebKitTools directory.
2594
2595         * CMakeListsEfl.txt: Added.
2596         * EWebLauncher/main.c: Added.
2597         (print_history):
2598         (zoom_level_set):
2599         (on_ecore_evas_resize):
2600         (title_set):
2601         (viewport_set):
2602         (on_title_changed):
2603         (on_progress):
2604         (on_load_finished):
2605         (on_toolbars_visible_set):
2606         (on_toolbars_visible_get):
2607         (on_statusbar_visible_set):
2608         (on_statusbar_visible_get):
2609         (on_scrollbars_visible_set):
2610         (on_scrollbars_visible_get):
2611         (on_menubar_visible_set):
2612         (on_menubar_visible_get):
2613         (on_tooltip_text_set):
2614         (on_inputmethod_changed):
2615         (on_viewport_changed):
2616         (on_mouse_down):
2617         (on_focus_out):
2618         (on_focus_in):
2619         (on_resized):
2620         (on_key_down):
2621         (on_browser_del):
2622         (on_closeWindow):
2623         (quit):
2624         (browserCreate):
2625         (browserDestroy):
2626         (closeWindow):
2627         (main_signal_exit):
2628         (findThemePath):
2629         (main):
2630
2631 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
2632
2633         Reviewed by Adam Roben.
2634
2635         Set project dependencies so that they build serially. This fixes
2636         issues when running run-webkit-tests if DRT is not built yet.
2637
2638         * DumpRenderTree/DumpRenderTree.sln:
2639
2640 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
2641
2642         Reviewed by Adam Barth.
2643
2644         Fix reading configuraiton in NWRT to work on Windows.
2645         https://bugs.webkit.org/show_bug.cgi?id=45180
2646
2647         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
2648             with the file otherwise.
2649
2650 2010-09-03  Chris Rogers  <crogers@google.com>
2651
2652         Unreviewed
2653
2654         Add myself to the committers list
2655         https://bugs.webkit.org/show_bug.cgi?id=45189
2656
2657         * Scripts/webkitpy/common/config/committers.py:
2658
2659 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
2660
2661         Reviewed by Yury Semikhatsky.
2662
2663         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
2664         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
2665         https://bugs.webkit.org/show_bug.cgi?id=45137
2666
2667         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2668
2669 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2670
2671         Reviewed by Eric Seidel.
2672
2673         Add feature detection support to NRWT.
2674         https://bugs.webkit.org/show_bug.cgi?id=41842
2675
2676         * Scripts/webkitpy/layout_tests/port/base.py:
2677         * Scripts/webkitpy/layout_tests/port/qt.py:
2678         * Scripts/webkitpy/layout_tests/port/webkit.py:
2679         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
2680
2681 2010-09-03  Hironori Bono  <hbono@chromium.org>
2682
2683         Reviewed by Kent Tamura.
2684
2685         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
2686         and implements it for Mac.
2687         https://bugs.webkit.org/show_bug.cgi?id=41832
2688
2689         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
2690         and bind it so we can call it from JavaScript.
2691         (+[TextInputController isSelectorExcludedFromWebScript:]):
2692         (+[TextInputController webScriptNameForSelector:]):
2693         (-[TextInputController hasSpellingMarker:length:]):
2694
2695 2010-09-02  Eric Seidel  <eric@webkit.org>
2696
2697         Reviewed by Adam Barth.
2698
2699         Add a unit test for commit-queue retries
2700         https://bugs.webkit.org/show_bug.cgi?id=45162
2701
2702         I think commit-queue retries are not correctly avoiding
2703         build and test on retries.  So I started testing the code.
2704         Unfortunately this test did not find the bug.  But now
2705         that we have the test we might as well keep it.
2706         I also fixed a broken import in validate-committer-lists.
2707
2708         * Scripts/validate-committer-lists:
2709         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2710
2711 2010-09-02  Kent Tamura  <tkent@chromium.org>
2712
2713         Reviewed by Dimitri Glazkov.
2714
2715         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
2716         https://bugs.webkit.org/show_bug.cgi?id=45091
2717
2718         Task.{cpp,h} introduces a simpler version of Chromium
2719         base/task.h. It doesn't have TupleN and Method.
2720
2721         * DumpRenderTree/DumpRenderTree.gypi:
2722          Add Task.cpp and Task.h
2723         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2724         (DRTDevToolsAgent::DRTDevToolsAgent):
2725         (DRTDevToolsAgent::reset):
2726         (DRTDevToolsAgent::asyncCall):
2727         (DRTDevToolsAgent::frontendLoaded):
2728         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2729         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
2730         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2731         (DRTDevToolsClient::DRTDevToolsClient):
2732         (DRTDevToolsClient::~DRTDevToolsClient):
2733         (DRTDevToolsClient::reset):
2734         (DRTDevToolsClient::asyncCall):
2735         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2736         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
2737         * DumpRenderTree/chromium/EventSender.cpp:
2738         (EventSender::EventSender):
2739         (EventSender::reset):
2740         (EventSender::scheduleAsynchronousClick):
2741         * DumpRenderTree/chromium/EventSender.h:
2742         (EventSender::taskList): Added to use MethodTask<T>.
2743         * DumpRenderTree/chromium/LayoutTestController.cpp:
2744         (LayoutTestController::LayoutTestController):
2745         (LayoutTestController::WorkQueue::processWorkSoon):
2746         (LayoutTestController::waitUntilDone):
2747         (LayoutTestController::notifyDone):
2748         (LayoutTestController::reset):
2749         * DumpRenderTree/chromium/LayoutTestController.h:
2750         (LayoutTestController::taskList): Added to use MethodTask<T>.
2751         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
2752         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2753         (deferredDisplayDispatch):
2754         (NotificationPresenter::show):
2755         * DumpRenderTree/chromium/Task.cpp: Added.
2756         * DumpRenderTree/chromium/Task.h: Added.
2757
2758 2010-09-02  Steve Block  <steveblock@google.com>
2759
2760         Reviewed by Adam Barth.
2761
2762         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
2763         https://bugs.webkit.org/show_bug.cgi?id=43181
2764
2765         * DumpRenderTree/mac/DumpRenderTree.mm:
2766         (createWebViewAndOffscreenWindow):
2767         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2768         (LayoutTestController::setMockDeviceOrientation):
2769
2770 2010-08-31  Adam Roben  <aroben@apple.com>
2771
2772         Fix flashiness when resizing the browser window on Windows
2773
2774         Reviewed by Sam Weinig.
2775
2776         * MiniBrowser/win/BrowserWindow.cpp:
2777         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
2778         periodically fill the window with white.
2779
2780 2010-09-02  Peter Kasting  <pkasting@google.com>
2781
2782         Reviewed by Dimitri Glazkov.
2783
2784         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
2785         https://bugs.webkit.org/show_bug.cgi?id=45073
2786
2787         * DumpRenderTree/chromium/EventSender.cpp:
2788         (EventSender::EventSender):
2789         (EventSender::mouseScrollBy):
2790         (EventSender::continuousMouseScrollBy):
2791         (EventSender::sendCurrentTouchEvent):
2792         (EventSender::handleMouseWheel):
2793         * DumpRenderTree/chromium/EventSender.h:
2794         * DumpRenderTree/gtk/EventSender.cpp:
2795         (mouseScrollByCallback):
2796         (continuousMouseScrollByCallback):
2797
2798 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
2799
2800         Reviewed by Tony Chang.
2801
2802         Land a patched version of r66542 - change TestRunner to have an
2803         separate cleanup method and fix the ordering of cleanup between
2804         TestRunner and the printing module, and then wrap everything in a
2805         try/finally block to ensure reliable cleanup without needing to
2806         rely on stuff happening in the destructor of the TestRunner.
2807
2808         Also refactor run_webkit_tests.run() to be much smaller and cleaner
2809         by creating a bunch of helper methods and moving more stuff into
2810         the TestRunner class.
2811
2812         This fixes the crash at the end of the linux test run of
2813         new-run-webkit-tests (and undoes the rollout in 66547).
2814
2815         https://bugs.webkit.org/show_bug.cgi?id=44902
2816
2817         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2818         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2819         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2820         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2821         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2822         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2823         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2824         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2825         * Scripts/webkitpy/layout_tests/port/base.py:
2826         * Scripts/webkitpy/layout_tests/port/test.py:
2827         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2828         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2829
2830 2010-09-01  Mark Rowe  <mrowe@apple.com>
2831
2832         Reviewed by Adam Roben.
2833
2834         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
2835
2836         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2837
2838 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
2839
2840         Reviewed by Adam Roben.
2841
2842         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
2843         and WebKitTestRunner.
2844
2845         * BuildSlaveSupport/win/kill-old-processes:
2846
2847 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2848
2849         Reviewed by Antonio Gomes.
2850
2851         [Qt] Remove obsolete include path from DumpRenderTree.pro
2852
2853         * DumpRenderTree/qt/DumpRenderTree.pro:
2854
2855 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2856
2857         Reviewed by Laszlo Gombos.
2858
2859         [Qt] QWebPage::allowGeolocationRequest should be async API
2860         https://bugs.webkit.org/show_bug.cgi?id=41364
2861
2862         Implements new async API for geolocation permission similar to
2863         Notification. WebPage maintains list of geolocation permission request
2864         QtWebkit and set's when LayoutTestController gets the access from test JS
2865
2866         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2867         (WebCore::WebPage::WebPage):
2868         (WebCore::WebPage::resetSettings):
2869         (WebCore::WebPage::requestPermission):
2870         (WebCore::WebPage::cancelPermission):
2871         (WebCore::WebPage::permissionSet):
2872         (WebCore::DumpRenderTree::DumpRenderTree):
2873         (WebCore::DumpRenderTree::processLine):
2874         (WebCore::DumpRenderTree::geolocationPermissionSet):
2875         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2876         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2877         (LayoutTestController::reset):
2878         (LayoutTestController::setGeolocationPermission):
2879         (LayoutTestController::setGeolocationPermissionCommon):
2880         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2881
2882 2010-09-01  Andras Becsi  <abecsi@webkit.org>
2883
2884         Reviewed by Antti Koivisto.
2885
2886         [Qt] Auto-generate WebKit2 forwarding headers
2887         https://bugs.webkit.org/show_bug.cgi?id=44692
2888
2889         * MiniBrowser/qt/BrowserWindow.h: use source style includes
2890         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
2891         * Scripts/enumerate-included-framework-headers: Removed.
2892
2893 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2894
2895         Reviewed by Adam Barth.
2896
2897         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
2898         https://bugs.webkit.org/show_bug.cgi?id=44789
2899
2900         * Scripts/webkitpy/common/net/bugzilla.py:
2901
2902 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
2903
2904         Reviewed by Adam Barth.
2905
2906         ews: Add support for EFL-EWS
2907         https://bugs.webkit.org/show_bug.cgi?id=44982
2908
2909         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
2910         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
2911         and add it to the ports dict.
2912         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
2913         EflEWS class.
2914         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
2915         a test case for the EFL EWS.
2916
2917 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
2918
2919         Reviewed by Sam Weinig.
2920
2921         https://bugs.webkit.org/show_bug.cgi?id=42195
2922         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
2923
2924         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2925         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
2926         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2927         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
2928         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
2929
2930         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2931         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
2932         which forgets its override.
2933
2934 2010-08-31  Sam Weinig  <sam@webkit.org>
2935
2936         Reviewed by Gavin Barraclough.
2937
2938         WebKitTestRunner needs layoutTestController.addUserStyleSheet
2939         https://bugs.webkit.org/show_bug.cgi?id=42680
2940
2941         WebKitTestRunner needs layoutTestController.addUserScript
2942         https://bugs.webkit.org/show_bug.cgi?id=42681
2943
2944         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2945         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2946         (WTR::InjectedBundle::beginTesting):
2947         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2948         (WTR::LayoutTestController::addUserScript):
2949         (WTR::LayoutTestController::addUserStyleSheet):
2950         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2951
2952 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2953
2954         Unreviewed, rolling out r66542.
2955         http://trac.webkit.org/changeset/66542
2956         https://bugs.webkit.org/show_bug.cgi?id=44902
2957
2958         r66542 - the weird logging dependencies in Python stuck again ...
2959
2960         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
2961         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
2962         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
2963         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
2964         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2965         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2966         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2967         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2968         * Scripts/webkitpy/layout_tests/port/base.py:
2969         * Scripts/webkitpy/layout_tests/port/test.py:
2970         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2971         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2972
2973 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
2974
2975         Reviewed by Tony Chang.
2976
2977         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
2978
2979         * DumpRenderTree/chromium/LayoutTestController.cpp:
2980         (LayoutTestController::LayoutTestController):
2981         (LayoutTestController::markerTextForListItem):
2982         * DumpRenderTree/chromium/LayoutTestController.h:
2983
2984 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2985
2986         Reviewed by Ojan Vafai.
2987
2988         new-run-webkit-tests: add more unit tests
2989
2990         Add more unit tests for new-run-webkit-tests; we now cover all but
2991         the most obscure code paths in the generic code. We still need to
2992         add coverage for the http server and web socket paths, and add better
2993         coverage of the platform-specific logic. Note that the rebaselining
2994         tool is still not well tested.
2995
2996         Also clean up some of the configuration logic for the printing
2997         module and the way it interacts with the Python logging module; that
2998         is a crufty interface, to be certain.
2999         
3000         https://bugs.webkit.org/show_bug.cgi?id=44902
3001
3002         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
3003         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
3004         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
3005         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
3006         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3007         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3008         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3009         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3010         * Scripts/webkitpy/layout_tests/port/base.py:
3011         * Scripts/webkitpy/layout_tests/port/test.py:
3012         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3013         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3014
3015 2010-08-31  Darin Adler  <darin@apple.com>
3016
3017         Reviewed by Anders Carlsson.
3018
3019         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
3020         in a debug build when built with certain compilers.
3021
3022 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
3023
3024         Reviewed by Gustavo Noronha Silva.
3025
3026         [GTK] Isolate all GTK+ typedefs into one file
3027         https://bugs.webkit.org/show_bug.cgi?id=44900
3028
3029         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
3030
3031 2010-08-31  Eric Seidel  <eric@webkit.org>
3032
3033         Reviewed by Adam Barth.
3034
3035         Show more status on queue status pages
3036         https://bugs.webkit.org/show_bug.cgi?id=44938
3037
3038         I upped the number of status lines from 6 to 15 --
3039         this has been bugging me for a while...
3040
3041         I also disabled showing the chromium-win EWS queue
3042         since it's been down for almost 5 months now.
3043
3044         * QueueStatusServer/handlers/dashboard.py:
3045         * QueueStatusServer/handlers/queuestatus.py:
3046         * QueueStatusServer/model/queues.py:
3047
3048 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
3049
3050         Reviewed by Antonio Gomes.
3051
3052         [Qt] Read command line arguments and open them as URLs in new windows
3053         https://bugs.webkit.org/show_bug.cgi?id=44944
3054
3055         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
3056
3057         * MiniBrowser/qt/main.cpp:
3058         (main):
3059
3060 2010-08-31  Adrian Perez  <aperez@igalia.com>
3061
3062         Reviewed by Martin Robinson.
3063
3064         Support scripts to run Buildbot slaves under daemontools (gtk related)
3065         https://bugs.webkit.org/show_bug.cgi?id=40053
3066
3067         * BuildSlaveSupport/gtk: Added.
3068         * BuildSlaveSupport/gtk/README: Added.
3069         * BuildSlaveSupport/gtk/buildbot: Added.
3070         * BuildSlaveSupport/gtk/buildbot/log: Added.
3071         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
3072         * BuildSlaveSupport/gtk/buildbot/run: Added.
3073         * BuildSlaveSupport/gtk/crashmon: Added.
3074         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
3075         * BuildSlaveSupport/gtk/crashmon/log: Added.
3076         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
3077         * BuildSlaveSupport/gtk/crashmon/run: Added.
3078         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
3079         * BuildSlaveSupport/gtk/pulseaudio: Added.
3080         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
3081         * BuildSlaveSupport/gtk/xvfb: Added.
3082         * BuildSlaveSupport/gtk/xvfb/log: Added.
3083         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
3084         * BuildSlaveSupport/gtk/xvfb/run: Added.
3085
3086 2010-08-27  John Gregg  <johnnyg@google.com>
3087
3088         Reviewed by David Levin.
3089
3090         Notifications should support a click event.
3091         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
3092         can be simulated during a layout test.  Requires storing a list of active
3093         notifications so that they can be referred to later for clicking.
3094         https://bugs.webkit.org/show_bug.cgi?id=44800
3095
3096         * DumpRenderTree/chromium/LayoutTestController.cpp:
3097         (LayoutTestController::LayoutTestController):
3098         (LayoutTestController::simulateDesktopNotificationClick):
3099         * DumpRenderTree/chromium/LayoutTestController.h:
3100         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3101         (NotificationPresenter::simulateClick):
3102         (NotificationPresenter::show):
3103         (NotificationPresenter::cancel):
3104         (NotificationPresenter::objectDestroyed):
3105         * DumpRenderTree/chromium/NotificationPresenter.h:
3106
3107 2010-08-30  Alice Liu  <alice.liu@apple.com>
3108
3109         Reviewed by Darin Adler.
3110
3111         Add missing parts of didFinishDocumentLoadForFrame
3112         https://bugs.webkit.org/show_bug.cgi?id=44913
3113
3114         * MiniBrowser/mac/BrowserWindowController.m:
3115         (didFinishDocumentLoadForFrame): Added
3116         (-[BrowserWindowController awakeFromNib]): Updated struct
3117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3118         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
3119         * WebKitTestRunner/TestController.cpp:
3120         (WTR::TestController::initialize): Updated struct
3121
3122 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
3123
3124         Unreviewed: Add myself to the list of Committers.
3125
3126         * Scripts/webkitpy/common/config/committers.py:
3127
3128 2010-08-30  Kent Tamura  <tkent@chromium.org>
3129
3130         Reviewed by Adam Barth.
3131
3132         Fix fast/notifications/notifications-display-close-events.html failure
3133         https://bugs.webkit.org/show_bug.cgi?id=44585
3134
3135         Apply http://crrev.com/48893. We should dispatch display events
3136         asynchronously.
3137
3138         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3139         (deferredDisplayDispatch):
3140         (NotificationPresenter::show):
3141
3142 2010-08-30  Robert Hogan  <robert@webkit.org>
3143
3144         Reviewed by Simon Hausmann.
3145
3146         allow ports with windowed plugins to support windowless plugin tests
3147
3148         https://bugs.webkit.org/show_bug.cgi?id=40730
3149
3150         Ports that implement plugins windowed by default need to have a way of
3151         supporting plugin tests that assume the plugin is windowless. Add this
3152         feature to the tests and support it in the webkit test plugin. Also
3153         add mouse and keyboard event logging to the webkit-test plugin on Unix.
3154
3155         Unskip the following tests on Qt:
3156
3157         plugins/mouse-events.html
3158         plugins/keyboard-events.html
3159         plugins/mouse-events-fixedpos.html
3160
3161         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3162         (pluginSetProperty):
3163         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3164         (NPP_New):
3165         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3166         (webkit_test_plugin_handle_event):
3167
3168 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
3169
3170         [wx] Build fix after addition of fileapi directory in WebCore.
3171
3172         * wx/build/settings.py:
3173
3174 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
3175
3176         Reviewed by Xan Lopez.
3177
3178         Fixed compilation error, now that we have included the
3179         GtkVersioning.h we have to remove some version dependent code from
3180         EventSender.
3181
3182         * DumpRenderTree/gtk/EventSender.cpp:
3183
3184 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
3185
3186         Reviewed by Martin Robinson.
3187
3188         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
3189         are deprecated
3190         https://bugs.webkit.org/show_bug.cgi?id=44787
3191
3192         We have replaced GtkVersioning.cpp with GtkVersioning.c and
3193         created a function (getDefaultGDKPointerDevice) to get the pointer
3194         of the window with the new APIs. We added that function to DRT and
3195         copyandpaste unit test.
3196
3197         * DumpRenderTree/gtk/EventSender.cpp:
3198         (prepareMouseButtonEvent):
3199         (mouseMoveToCallback):
3200         (keyDownCallback):
3201         * GNUmakefile.am:
3202
3203 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
3204
3205         Reviewed by Kenneth Rohde Christiansen.
3206
3207         [Qt] Add new window menu to MiniBrowser
3208
3209         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
3210
3211         * MiniBrowser/qt/BrowserWindow.cpp:
3212         (BrowserWindow::BrowserWindow):
3213         (BrowserWindow::newWindow):
3214         * MiniBrowser/qt/BrowserWindow.h:
3215         * MiniBrowser/qt/main.cpp:
3216         (main):
3217
3218 2010-08-29  James Robinson  <jamesr@chromium.org>
3219
3220         Reviewed by David Levin.
3221
3222         Make failing the download step fail the build
3223         https://bugs.webkit.org/show_bug.cgi?id=44298
3224
3225         If the download step fails on a test bot, this ensures that
3226         the build goes red instead of only the download step going red
3227         and the overall build staying green.
3228
3229         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3230
3231 2010-08-29  Kent Tamura  <tkent@chromium.org>
3232
3233         Reviewed by Dimitri Glazkov.
3234
3235         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
3236         https://bugs.webkit.org/show_bug.cgi?id=44847
3237
3238         * DumpRenderTree/chromium/EventSender.cpp:
3239          Use webkit_support::VKEY_* instead of base::VKEY_*.
3240
3241 2010-08-29  Darin Adler  <darin@apple.com>
3242
3243         https://bugs.webkit.org/show_bug.cgi?id=40589
3244
3245         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
3246         function names.
3247
3248 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3249
3250         Reviewed by Darin Adler.
3251
3252         [iExploder] Add new CSS Properties and HTML Attributes
3253         https://bugs.webkit.org/show_bug.cgi?id=44746
3254
3255         Updated the files with the update-iexploder-cssproperties script
3256         and manually readded the -webkit-binding CSS Property to the list.
3257
3258         * iExploder/htdocs/cssproperties.in:
3259         * iExploder/htdocs/htmlattrs.in:
3260         * iExploder/htdocs/htmltags.in:
3261
3262 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3263
3264         Reviewed by Darin Adler.
3265
3266         Fix Coverage build after the addition of ANGLE
3267         https://bugs.webkit.org/show_bug.cgi?id=44744
3268
3269         ANGLE is using libtool to build a static library and the version of
3270         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
3271         parameters. The easiest way to handle this is to not build ANGLE with
3272         coverage information.
3273
3274         This is achieved by applying the XCode options for each project
3275         separately and exclude ANGLE.
3276
3277         * Scripts/build-webkit: Remove -framework AppKit due link errors.
3278         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
3279
3280 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
3281
3282         [wx] Build fix after directory addition.
3283
3284         * wx/build/settings.py:
3285
3286 2010-08-28  Chris Guillory   <chris.guillory@google.com>
3287
3288         Reviewed by Chris Fleizach.
3289
3290         Add AX notification for childrenChanged
3291         https://bugs.webkit.org/show_bug.cgi?id=44472
3292
3293         * DumpRenderTree/chromium/AccessibilityController.cpp:
3294         (AccessibilityController::AccessibilityController):
3295         (AccessibilityController::reset):
3296         (AccessibilityController::getRootElement):
3297         (AccessibilityController::dumpAccessibilityNotifications):
3298         * DumpRenderTree/chromium/AccessibilityController.h:
3299         (AccessibilityController::shouldDumpAccessibilityNotifications):
3300         * DumpRenderTree/chromium/WebViewHost.cpp:
3301         (WebViewHost::didChangeAccessibilityObjectChildren):
3302         * DumpRenderTree/chromium/WebViewHost.h:
3303
3304 2010-08-28  Eric Seidel  <eric@webkit.org>
3305
3306         Reviewed by Adam Barth.
3307
3308         Update commit-queue failure message
3309         https://bugs.webkit.org/show_bug.cgi?id=44798
3310
3311         The commit-queue auto-restarts itself and has for a very long time.
3312         No need for people to email me to request a restart anymore.
3313
3314         * Scripts/webkitpy/common/net/bugzilla.py:
3315         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3316         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3317
3318 2010-07-27  Jer Noble  <jer.noble@apple.com>
3319
3320         Reviewed by Eric Carlson.
3321
3322         Add JavaScript API to allow a page to go fullscreen.
3323         rdar://problem/6867795
3324         
3325         Added basic full screen support to DumpRenderTree: when a webView requests
3326         that DumpRenderTree go "full screen", just call the provided callback listener object's
3327         will/did Enter/Exit full screen methods.  Also, register a new user default which 
3328         enables full screen support.
3329
3330         * DumpRenderTree/mac/DumpRenderTree.mm:
3331         (resetDefaultsToConsistentValues):
3332         * DumpRenderTree/mac/UIDelegate.mm:
3333         (-[UIDelegate webView:supportsFullscreenForElement:]):
3334         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
3335         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
3336
3337 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
3338
3339         Unreviewed. Add myself to the committers list.
3340
3341         * Scripts/webkitpy/common/config/committers.py:
3342
3343 2010-08-27  Kent Tamura  <tkent@chromium.org>
3344
3345         Reviewed by Pavel Feldman.
3346
3347         [DRT/Chromium] Fix inspector test failures
3348         https://bugs.webkit.org/show_bug.cgi?id=44748
3349
3350         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3351         (DRTDevToolsAgent::createClientMessageLoop):
3352           Returns a valid WebKitClientMessageLoop instance
3353         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3354
3355 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
3356
3357         Add Windows WebKit2 Tester to buildbot
3358         <rdar://problem/7887703>
3359
3360         Reviewed by Dan Bernstein.
3361
3362         * BuildSlaveSupport/build.webkit.org-config/config.json:
3363
3364 2010-08-26  Philippe Normand  <pnormand@igalia.com>
3365
3366         Reviewed by Martin Robinson.
3367
3368         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3369         https://bugs.webkit.org/show_bug.cgi?id=42152
3370
3371         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3372         (LoadHTMLStringItem::invoke): Implementation using
3373         webkit_web_frame_load_string().
3374
3375 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
3376
3377         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
3378         WebKitTestRunner (44331)
3379
3380         Reviewed by Darin Adler.
3381
3382         * WebKitTestRunner/TestController.cpp:
3383         (WTR::TestController::initialize):
3384         The hang occurs when WebKitTestRunner begins launching the WebKit2
3385         web process then exits before it finishes launching. Work around this by
3386         looking for the --print-supported-features argument and exiting without
3387         creating the web process.
3388
3389 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
3390
3391         Reviewed by Tony Chang.
3392
3393         new-run-webkit-tests: add rebaselining tests for test_expectations
3394         
3395         This patch adds more unit tests for the rebaselining code in the
3396         test_expectations module. It doesn't add any tests for
3397         rebaseline_chromium_webkit_tests itself; that will come some other
3398         time.
3399
3400         https://bugs.webkit.org/show_bug.cgi?id=44648
3401
3402         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3403         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3404
3405 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3406
3407         Reviewed by Martin Robinson.
3408
3409         [GTK] Add HTTP caching support
3410         https://bugs.webkit.org/show_bug.cgi?id=44261
3411
3412         Ignore new soup API that we decided to merge into the soup backend
3413         while it is being cooked. It follows the libsoup style, and will
3414         be removed from WebKit as soon as it is merged into libsoup.
3415
3416         * Scripts/webkitpy/style/checker.py:
3417
3418 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3419
3420         Reviewed by Kenneth Rohde Christiansen.
3421
3422         [Qt] DumpRenderTree runs only one test from command mode
3423         https://bugs.webkit.org/show_bug.cgi?id=44012
3424
3425         Enables support to run multiple test files and single
3426         folder containing html files in stand alone mode
3427
3428         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3429         (WebCore::DumpRenderTree::DumpRenderTree):
3430         (WebCore::DumpRenderTree::processArgsLine):
3431         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3432         (WebCore::DumpRenderTree::processLine):
3433         (WebCore::DumpRenderTree::dump):
3434         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3435         (WebCore::DumpRenderTree::setStandAloneMode):
3436         (WebCore::DumpRenderTree::isStandAloneMode):
3437         * DumpRenderTree/qt/main.cpp:
3438         (main):
3439
3440 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
3441
3442         Updating webkitpy test expectations.
3443
3444         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3445
3446 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3447
3448         Reviewed by Eric Seidel.
3449
3450         fix the always squash git config
3451         https://bugs.webkit.org/show_bug.cgi?id=44651
3452
3453         Fix help text and apparently underscores are not allowed
3454         in git config keys.
3455
3456         * Scripts/webkitpy/common/checkout/scm.py:
3457         * Scripts/webkitpy/tool/steps/commit.py:
3458
3459 2010-08-25  Darin Adler  <darin@apple.com>
3460
3461         Reviewed by John Sullivan.
3462
3463         * Scripts/commit-log-editor: Fix perl warning for people who have no
3464         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
3465
3466 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3467
3468         Reviewed by Eric Seidel.
3469
3470         stop blocking commits when the bots are red
3471         https://bugs.webkit.org/show_bug.cgi?id=44644
3472
3473         This check currently is just annoying. It doesn't actually
3474         help keep the tree green. We can always add it back later
3475         if we decide the tree is generally more green.
3476
3477         * Scripts/webkitpy/tool/commands/download_unittest.py:
3478         * Scripts/webkitpy/tool/mocktool.py:
3479         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
3480
3481 2010-08-25  Eric Seidel  <eric@webkit.org>
3482
3483         Reviewed by Simon Fraser.
3484
3485         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
3486         https://bugs.webkit.org/show_bug.cgi?id=38912
3487
3488         I know of nothing else to do but skip all media tests for the cq.
3489
3490         * Scripts/webkitpy/tool/steps/runtests.py:
3491
3492 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3493
3494         Reviewed by Ojan Vafai.
3495
3496         new-run-webkit-tests: add more unit tests for test_expectations
3497         This adds unit tests to cover (almost?) all of the non-rebaselining
3498         functionality.
3499
3500         https://bugs.webkit.org/show_bug.cgi?id=44579
3501
3502         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3503         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3504
3505 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3506
3507         Reviewed by Ojan Vafai.
3508
3509         new-run-webkit-tests: add more unit tests
3510
3511         This change adds more unit tests for the image_diff, test_failures,
3512         and test_files modules, bringing them to 100% coverage (and adds a
3513         couple tests to run_webkit_tests while we're at it).
3514
3515         This test also turns on the "dryrun" port for testing when run on
3516         the mac, increasing coverage in a few other places.
3517
3518         https://bugs.webkit.org/show_bug.cgi?id=44578
3519
3520         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
3521         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
3522         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
3523         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
3524         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
3525         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
3526         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
3527         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
3528         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3529         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
3530         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3531         * Scripts/webkitpy/layout_tests/port/test.py:
3532         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3533
3534 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3535
3536         Reviewed by Ojan Vafai.
3537
3538         new-run-webkit-tests: add more unit tests for layout_package/printing.py
3539
3540         This change adds more unit tests to get the test coverage to 100%
3541         for the printing module. This code is actually pretty crufty and
3542         has some layering violations that need to be cleaned up but I'll
3543         save that for another CL after we get all the unit tests written and
3544         we fix the multithreading issues. At least now we'll be able to tell
3545         if we break things.
3546
3547         https://bugs.webkit.org/show_bug.cgi?id=44576
3548
3549         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3550         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3551
3552 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3553
3554         Reviewed by Adam Barth.
3555
3556         new-run-webkit-tests should respect set-webkit-configuration
3557         https://bugs.webkit.org/show_bug.cgi?id=44633
3558
3559         Moves the getting of the configuration into the base Port so that
3560         chromium ports use it as well. In the downstream chromium port,
3561         this should still just return Release.
3562
3563         * Scripts/webkitpy/layout_tests/port/base.py:
3564         * Scripts/webkitpy/layout_tests/port/webkit.py:
3565
3566 2010-08-25  Tony Chang  <tony@chromium.org>
3567
3568         Not reviewed, changing svn props for a script.
3569
3570         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
3571
3572 2010-08-25  Adam Barth  <abarth@webkit.org>
3573
3574         Reviewed by Eric Seidel.
3575
3576         Remove WebKit2 from core builders
3577         https://bugs.webkit.org/show_bug.cgi?id=44625
3578
3579         This builder was added to the core builders by accident.  It doesn't
3580         appear to be green enough to be a core builder yet.
3581
3582         * Scripts/webkitpy/common/net/buildbot.py:
3583         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3584
3585 2010-08-19  Adam Roben  <aroben@apple.com>
3586
3587         Test that NP_Initialize and NP_GetEntryPoints are called in the
3588         correct order
3589
3590         The order differs between Mac and Windows (see r38858).
3591
3592         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
3593         NP_Initialize when loading QuickTime when running
3594         plugins/embed-attributes-setting.html in WebKit2 on Windows
3595
3596         Reviewed by John Sullivan.
3597
3598         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
3599         a boolean to record whether NP_GetEntryPoints has been called.
3600         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
3601         called yet. This matches Flash and QuickTime's behavior.
3602         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
3603         yet. This matches Silverlight's behavior.
3604
3605 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
3606
3607         Reviewed by Gustavo Noronha Silva.
3608
3609         Cairo and EFL port shouldn't depend on glib.
3610         https://bugs.webkit.org/show_bug.cgi?id=44354
3611
3612         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
3613         adoptPlatformRef.
3614
3615         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3616         (AccessibilityUIElement::isSelected):
3617
3618 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3619
3620         Fix order of Timothy's email address. The script, and
3621         other tools all assume that the first email is the bugzilla address.
3622
3623         * Scripts/webkitpy/common/config/committers.py:
3624
3625 2010-08-24  Kent Tamura  <tkent@chromium.org>
3626
3627         Reviewed by Pavel Feldman.
3628
3629         [DRT/Chromium] Fix 26 inspector test crashes
3630         https://bugs.webkit.org/show_bug.cgi?id=44580
3631
3632         - DRTDevToolsAgent has a reference to the main WebView. So we
3633           should not clear it in closeDevTools() and should clear it in
3634           ~TestShell().
3635         - DRTDevToolsClient has a reference to a DevTools WebView and no
3636           way to update it. So we should delete DRTDevToolsClient instances
3637           in closeDevTools().
3638
3639         * DumpRenderTree/chromium/TestShell.cpp:
3640         (TestShell::~TestShell):
3641         (TestShell::closeDevTools):
3642
3643 2010-08-24  Eric Seidel  <eric@webkit.org>
3644
3645         Reviewed by Adam Barth.
3646
3647         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
3648         https://bugs.webkit.org/show_bug.cgi?id=44584
3649
3650         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3651
3652 2010-08-24  Eric Seidel  <eric@webkit.org>
3653
3654         Reviewed by Adam Barth.
3655
3656         commit-queue and EWS bots should report all failures
3657         https://bugs.webkit.org/show_bug.cgi?id=41820
3658
3659         Right now commit-queue/EWS only report failures when the
3660         patch under testing fails.  We should report all failures
3661         to the status server so that we can diagnose when the bots
3662         are wedged w/o needing to log into the machines.
3663
3664         I also reduced the amount of data we upload since we've seen
3665         timeouts during status upload.
3666
3667         * Scripts/webkitpy/common/system/executive.py:
3668         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: