a423f367e33f15852e09046357919837c02ef003
[WebKit.git] / WebKitTools / ChangeLog
1 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Oliver Hunt.
4
5         Give command-line sunspider the ability to handle multiple suites and versions
6         https://bugs.webkit.org/show_bug.cgi?id=32477
7
8         * Scripts/run-sunspider: Updated for changes to command-line parameters.
9         * Scripts/sunspider-compare-results: ditto
10
11 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
12
13         Not reviewed, fixing previous comment.
14
15         Remove accidental change to sunspider-compare-results
16
17         * Scripts/sunspider-compare-results:
18
19 2009-12-11  Yael Aharon  <yael.aharon@nokia.com>
20
21         Unreviewed build fix for Qt versions < 4.6. 
22         Guard every slot individually with #ifdef.
23
24         * DumpRenderTree/qt/EventSenderQt.cpp:
25         (EventSender::addTouchPoint):
26         (EventSender::updateTouchPoint):
27         (EventSender::touchStart):
28         (EventSender::touchMove):
29         (EventSender::touchEnd):
30         (EventSender::clearTouchPoints):
31         (EventSender::releaseTouchPoint):
32         (EventSender::sendTouchEvent):
33         * DumpRenderTree/qt/EventSenderQt.h:
34
35 2009-12-11  Eric Seidel  <eric@webkit.org>
36
37         Reviewed by Adam Barth.
38
39         CommandsTest.assert_execute_outputs doesn't check stderr
40         https://bugs.webkit.org/show_bug.cgi?id=32352
41
42         Fix assert_execute_outputs to check stderr
43         and then fix all the unit tests which needed to
44         pass stderr output.
45
46         * Scripts/modules/commands/commandtest.py:
47         * Scripts/modules/commands/download_unittest.py:
48         * Scripts/modules/commands/upload_unittest.py:
49
50 2009-12-11  Adam Barth  <abarth@webkit.org>
51
52         Reviewed by Eric Seidel.
53
54         [check-webkit-style] False positive for tst_QWebFrame
55         https://bugs.webkit.org/show_bug.cgi?id=32436
56
57         Add an exception for function names that start with "tst_".  These are
58         used by the Qt unit testing framework.
59
60         * Scripts/modules/cpp_style.py:
61         * Scripts/modules/cpp_style_unittest.py:
62
63 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
64
65         Reviewed by Antti Koivisto.
66
67         Added support for creating synthetic touch events with EventSender
68         in Qt's DumpRenderTree.
69
70         https://bugs.webkit.org/show_bug.cgi?id=32114
71
72         * DumpRenderTree/qt/EventSenderQt.cpp:
73         (EventSender::addTouchPoint):
74         (EventSender::updateTouchPoint):
75         (EventSender::touchStart):
76         (EventSender::touchMove):
77         (EventSender::touchEnd):
78         (EventSender::clearTouchPoints):
79         (EventSender::releaseTouchPoint):
80         (EventSender::sendTouchEvent):
81         * DumpRenderTree/qt/EventSenderQt.h:
82
83 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
84
85         Reviewed by Darin Adler.
86
87         The values of RuntimeArray are not enumerable
88         https://bugs.webkit.org/show_bug.cgi?id=29005
89
90         * DumpRenderTree/mac/ObjCController.m:
91         (+[ObjCController isSelectorExcludedFromWebScript:]):
92         (+[ObjCController webScriptNameForSelector:]):
93         (-[ObjCController arrayOfString]):
94
95 2009-12-10  Eric Seidel  <eric@webkit.org>
96
97         No review, just updating unit tests to match recent checkins.
98
99         * Scripts/modules/mock_bugzillatool.py:
100          - Add missing red_core_builders_names method causing exception.
101         * Scripts/modules/workqueue_unittest.py:
102          - processutils is dead, use executive.py instead.
103
104 2009-12-10  Eric Seidel  <eric@webkit.org>
105
106         Reviewed by Adam Barth.
107
108         Move run_command onto Executive to make code which uses run_command testable
109         https://bugs.webkit.org/show_bug.cgi?id=32396
110
111         * Scripts/modules/executive.py:
112          - Move run_command and error handlers onto Executive.
113         * Scripts/modules/scm.py:
114         * Scripts/modules/scm_unittest.py:
115
116 2009-12-09  Eric Seidel  <eric@webkit.org>
117
118         Reviewed by Adam Barth.
119
120         bugzilla-tool needs a command to list patches needing cq+
121         https://bugs.webkit.org/show_bug.cgi?id=32351
122
123         * Scripts/modules/bugzilla.py:
124          - Parse attacher_email from attachment xml.
125         * Scripts/modules/bugzilla_unittest.py:
126          - Test new attacher_email parsing.
127         * Scripts/modules/commands/queries.py:
128          - Add PatchesToCommitQueue
129         * Scripts/modules/commands/queries_unittest.py:
130          - Tests for PatchesToCommitQueue
131         * Scripts/modules/mock_bugzillatool.py:
132          - Add necessary mock methods for running PatchesToCommitQueue
133
134 2009-12-10  Adam Barth  <abarth@webkit.org>
135
136         Unreviewed.  Turns out every StepSequence command needs a --quiet
137         option.
138
139         * Scripts/modules/stepsequence.py:
140
141 2009-12-10  Eric Z. Ayers  <zundel@google.com>
142
143         Reviewed by Pavel Feldman.
144
145         Implements displayWebView() to force an invalidation and repaint.
146         This fixes a problem running the timeline-paint.html unit test.
147
148         https://bugs.webkit.org/show_bug.cgi?id=31729
149
150         * DumpRenderTree/gtk/DumpRenderTree.cpp:
151         (displayWebView):
152
153 2009-12-10  Adam Barth  <abarth@webkit.org>
154
155         Reviewed by Eric Seidel.
156
157         [bzt] Convert more commands to StepSequences
158         https://bugs.webkit.org/show_bug.cgi?id=32362
159
160         We should eventually convert all the commands, but I'm starting with
161         the easy ones.
162
163         * Scripts/modules/commands/download.py:
164
165 2009-12-10  Xan Lopez  <xlopez@igalia.com>
166
167         Reviewed by Jan Alonzo.
168
169         [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
170         https://bugs.webkit.org/show_bug.cgi?id=31103
171
172         Give focus to the webviews when we create them, since some tests expect this.
173
174         * DumpRenderTree/gtk/DumpRenderTree.cpp:
175         (main):
176
177 2009-12-10  Eric Seidel  <eric@webkit.org>
178
179         Reviewed by Adam Barth.
180
181         bugzilla-tool "builders are red" error should tell you which builders
182         https://bugs.webkit.org/show_bug.cgi?id=32211
183
184         * Scripts/modules/buildsteps.py:
185
186 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
187
188         Reviewed by Adam Roben.
189
190         Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
191         Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
192         in Windows as part of running update_webkit.
193
194         * Scripts/update-webkit:
195          - Run setupAppleWinEnv() on Apple's Windows port.
196         * Scripts/webkitdirs.pm:
197          - Added functions that return the source directory, libraries directory and default build directory on Windows.
198          - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
199          - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir
200            and Cygwin to their desired values.
201
202 2009-12-09  Adam Barth  <abarth@webkit.org>
203
204         Reviewed by Eric Seidel.
205
206         exception thrown when running apply-patches
207         https://bugs.webkit.org/show_bug.cgi?id=32344
208
209         The update step now takes a port option.  Once we finish the Steps
210         refactoring, we won't have to worry about this kind of bug again.
211
212         * Scripts/modules/commands/download.py:
213
214 2009-12-09  Adam Barth  <abarth@webkit.org>
215
216         Unreviewed.  Fix ScriptError includes.  I don't understand why these
217         didn't throw during unit testing...
218
219         * Scripts/modules/commands/download.py:
220         * Scripts/modules/logging_unittest.py:
221         * Scripts/modules/workqueue.py:
222
223 2009-12-09  Adam Barth  <abarth@webkit.org>
224
225         Reviewed by Eric Seidel.
226
227         [bzt] Remove unused PatchCollection class
228         https://bugs.webkit.org/show_bug.cgi?id=32312
229
230         It's dead code.
231
232         * Scripts/modules/patchcollection.py:
233         * Scripts/modules/patchcollection_unittest.py: Removed.
234
235 2009-12-09  Adam Barth  <abarth@webkit.org>
236
237         Unreviewed "build" fix.  CheckStyle needs a --no-upate option.
238
239         * Scripts/modules/commands/download.py:
240
241 2009-12-09  Adam Barth  <abarth@webkit.org>
242
243         Reviewed by Eric Seidel.
244
245         [bzt] Convert Build to use Sequence
246         https://bugs.webkit.org/show_bug.cgi?id=32310
247
248         So much prettier.
249
250         * Scripts/modules/buildsteps.py:
251         * Scripts/modules/commands/download.py:
252         * Scripts/modules/landingsequence.py:
253         * Scripts/modules/stepsequence.py: Added.
254
255 2009-12-09  Adam Barth  <abarth@webkit.org>
256
257         Add missing file.
258
259         * Scripts/modules/executive.py: Added.
260
261 2009-12-09  Adam Barth  <abarth@webkit.org>
262
263         Unreviewed "build" fix.
264
265         * Scripts/modules/landingsequence.py:
266
267 2009-12-09  Adam Barth  <abarth@webkit.org>
268
269         Reviewed by Eric Seidel.
270
271         [bzt] Implement abstract Steps
272         https://bugs.webkit.org/show_bug.cgi?id=32212
273
274         This is a fairly disruptive change that refactors how we build
275         commands.  Instead of using a landing sequence, we can now assemble a
276         sequence of steps directly.  We still use the landing sequence in the
277         interim, but this will be removed soon.
278
279         * Scripts/bugzilla-tool:
280         * Scripts/modules/buildsteps.py:
281         * Scripts/modules/commands/download.py:
282         * Scripts/modules/commands/early_warning_system.py:
283         * Scripts/modules/commands/queues.py:
284         * Scripts/modules/commands/queues_unittest.py:
285         * Scripts/modules/landingsequence.py:
286         * Scripts/modules/mock_bugzillatool.py:
287         * Scripts/modules/processutils.py: Removed.
288         * Scripts/modules/scm.py:
289         * Scripts/modules/scm_unittest.py:
290         * Scripts/modules/webkitport.py:
291
292 2009-12-08  Eric Seidel  <eric@webkit.org>
293
294         Reviewed by Adam Barth.
295
296         run_command and ScriptError should move into processutils.py
297         https://bugs.webkit.org/show_bug.cgi?id=32305
298
299         Turns out there are a zillion callers to run_command.
300
301         * Scripts/modules/commands/download.py:
302         * Scripts/modules/commands/early_warning_system.py:
303         * Scripts/modules/commands/queues.py:
304         * Scripts/modules/landingsequence.py:
305         * Scripts/modules/logging_unittest.py:
306         * Scripts/modules/processutils.py:
307         * Scripts/modules/scm.py:
308         * Scripts/modules/scm_unittest.py:
309         * Scripts/modules/workqueue.py:
310         * Scripts/modules/workqueue_unittest.py:
311
312 2009-12-08  Kevin Watters  <kevinwatters@gmail.com>
313
314         Reviewed by Kevin Ollivier.
315
316         [wx] Mac plugins support.
317         
318         https://bugs.webkit.org/show_bug.cgi?id=32236
319
320         * wx/browser/wscript:
321
322 2009-12-08  David Levin  <levin@chromium.org>
323
324         Reviewed by Adam Barth.
325
326         [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
327         https://bugs.webkit.org/show_bug.cgi?id=32193
328
329         * Scripts/modules/cpp_style.py: For the function { rule, if there is space
330           at the beginning of line, ignore lines which then have a macro.
331         * Scripts/modules/cpp_style_unittest.py: Add tests to verify the
332           new behavior.
333
334 2009-12-08  Dmitry Titov  <dimich@chromium.org>
335
336         Rubber-stamped by David Levin.
337
338         Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
339         It may have caused massive increase of reported leaks on the bots.
340         https://bugs.webkit.org/show_bug.cgi?id=31639
341
342         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
343
344 2009-12-08  Dmitry Titov  <dimich@chromium.org>
345
346         Reviewed by Darin Adler.
347
348         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
349         https://bugs.webkit.org/show_bug.cgi?id=31639
350
351         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
352
353 2009-12-08  David Levin  <levin@chromium.org>
354
355         Reviewed by Adam Barth.
356
357         [check-webkit-style] False positive for camel case of JSC op codes
358         https://bugs.webkit.org/show_bug.cgi?id=32192
359
360         * Scripts/modules/cpp_style.py: Added an exception for the JSC op
361           code functions and const_iterator as well since I noticed a false
362           positive there when testing the fix.
363         * Scripts/modules/cpp_style_unittest.py: Added tests for these
364           changes.
365
366 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
367
368         Rubber-stamped by Maciej Stachowiak.
369
370         Turn on (SVG) Filters for Win.
371         https://bugs.webkit.org/show_bug.cgi?id=32224
372
373         * Scripts/webkitdirs.pm:
374
375 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
376
377         Rubber-stamped by Maciej Stachowiak.
378
379         Turn on (SVG) Filters for Gtk.
380         https://bugs.webkit.org/show_bug.cgi?id=32224
381
382         * Scripts/build-webkit:
383
384 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
385
386         Reviewed by David Levin.
387
388         [check-webkit-style] S_OK is a fine identifier
389         https://bugs.webkit.org/show_bug.cgi?id=32225
390
391         * Scripts/modules/cpp_style.py:
392         * Scripts/modules/cpp_style_unittest.py:
393
394 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
395
396         Rubber-stamped by Maciej Stachowiak.
397
398         Turn on (SVG) Filters for Qt.
399         https://bugs.webkit.org/show_bug.cgi?id=32224
400
401         * Scripts/build-webkit:
402
403 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
404
405         Reviewed by Alexey Proskuryakov.
406
407         Make run-webkit-websocketserver log to stderr rather than to a file.
408         https://bugs.webkit.org/show_bug.cgi?id=32234
409
410         * Scripts/run-webkit-websocketserver:
411
412 2009-12-07  Dmitry Titov  <dimich@chromium.org>
413
414         Rubber-stamped by Darin Adler.
415
416         Remove ENABLE_SHARED_SCRIPT flags
417         https://bugs.webkit.org/show_bug.cgi?id=32245
418         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
419
420         * Scripts/build-webkit:
421
422 2009-12-07  Simon Fraser  <simon.fraser@apple.com>
423
424         Reviewed by Darin Adler.
425
426         <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
427
428         The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
429         accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
430         This caused one compositing test make DumpRenderTree think that all subsequent tests
431         were compositing too.
432
433         Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
434         notification informs the client that a WebHTMLView entered compositing mode (or an already-
435         compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
436         compositing subviews were removed, since this is tricky to get right.
437         
438         DumpRenderTreeWindow listens for this notification, and uses it to turn on window
439         autodisplay, which is necessary to kick-start Core Animation rendering and animations.
440         We ensure that window autodisplay is turned off before every test.
441
442         * DumpRenderTree/mac/DumpRenderTree.mm:
443         (createWebViewAndOffscreenWindow):
444         (resetWebViewToConsistentStateBeforeTesting):
445         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
446         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
447         (-[DumpRenderTreeWindow close]):
448         (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]):
449         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
450
451 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
452
453         Reviewed by Holger Hans Peter Freyther.
454
455         Turn on (SVG) Filters support, by default.
456         https://bugs.webkit.org/show_bug.cgi?id=32224
457
458         For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon.
459
460         * Scripts/build-webkit:
461
462 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
463
464         Reviewed by Darin Fisher.
465
466         Chromium buildbots are not red when they fail
467         https://bugs.webkit.org/show_bug.cgi?id=32235
468
469         * Scripts/build-webkit:
470
471 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
472
473         Reviewed by Darin Fisher.
474
475         Typo in chromium linux builder
476         https://bugs.webkit.org/show_bug.cgi?id=32238
477
478         * Scripts/webkitdirs.pm:
479
480 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
481
482         Reviewed by Darin Fisher.
483
484         fixes to build-webkit --chromium
485         https://bugs.webkit.org/show_bug.cgi?id=32179
486
487         * Scripts/webkitdirs.pm:
488
489 2009-12-07  Eric Seidel  <eric@webkit.org>
490
491         No review, just adding two recently approved committers.
492
493         * Scripts/modules/committers.py:
494
495 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
496
497         * Scripts/run-webkit-websocketserver: Added property svn:executable.
498
499 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
500
501         Reviewed by Alexey Proskuryakov.
502
503         Add run-webkit-websocketserver
504
505         https://bugs.webkit.org/show_bug.cgi?id=31390
506
507         * Scripts/run-webkit-websocketserver: Added.
508
509 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
510
511         Build fix. Be flexible about which version of ICU is used on Windows.
512
513         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
514
515 2009-12-07  Dirk Schulze  <krit@webkit.org>
516
517         Not reviewed, adding myself to the reviewers list.
518
519         * Scripts/modules/committers.py:
520
521 2009-12-06  Eric Seidel  <eric@webkit.org>
522
523         Reviewed by Adam Barth.
524
525         Add an API for uploading results files to StatusBot
526         https://bugs.webkit.org/show_bug.cgi?id=32210
527
528         Add Content-Type: plain/text which was forgotten
529         from the previous commit when I landed with land-patches
530         instead of land-diff.
531
532         * QueueStatusServer/queue_status.py:
533
534 2009-12-06  Eric Seidel  <eric@webkit.org>
535
536         Reviewed by Adam Barth.
537
538         Status Server needs a way to handle uploaded results
539         https://bugs.webkit.org/show_bug.cgi?id=32209
540
541         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
542         * QueueStatusServer/update_status.html: Add file upload.
543
544 2009-12-06  Eric Seidel  <eric@webkit.org>
545
546         Reviewed by Adam Barth.
547
548         Add an API for uploading results files to StatusBot
549         https://bugs.webkit.org/show_bug.cgi?id=32210
550
551         * Scripts/modules/statusbot.py:
552
553 2009-12-06  Eric Seidel  <eric@webkit.org>
554
555         Reviewed by Adam Barth.
556
557         Status Server needs a way to handle uploaded results
558         https://bugs.webkit.org/show_bug.cgi?id=32209
559
560         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
561         * QueueStatusServer/update_status.html: Add file upload.
562
563 2009-12-06  Adam Barth  <abarth@webkit.org>
564
565         Reviewed by Eric Seidel.
566
567         [bzt] BuildAttachment should not check the builders
568         https://bugs.webkit.org/show_bug.cgi?id=32207
569
570         This is code that got copied here by accident when the class was created.
571
572         * Scripts/modules/commands/download.py:
573
574 2009-12-06  Adam Barth  <abarth@webkit.org>
575
576         Reviewed by Eric Seidel.
577
578         [bzt] Make LandingSequence.update aware of ports
579         https://bugs.webkit.org/show_bug.cgi?id=32208
580
581         This is required to make build work on the Chromium port because
582         Chromium has a custom update-webkit.
583
584         * Scripts/modules/landingsequence.py:
585
586 2009-12-06  Adam Barth  <abarth@webkit.org>
587
588         Reviewed by Eric Seidel.
589
590         Add early warning system commands to bugzilla-tool.
591
592         * Scripts/bugzilla-tool:
593         * Scripts/modules/landingsequence.py:
594         * Scripts/modules/webkitport.py:
595
596 2009-12-06  Adam Barth  <abarth@webkit.org>
597
598         Reviewed by Eric Seidel.
599
600         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
601         https://bugs.webkit.org/show_bug.cgi?id=32205
602
603         * Scripts/modules/commands/early_warning_system.py: Added.
604         * Scripts/modules/commands/queues.py:
605
606 2009-12-06  Dan Bernstein  <mitz@apple.com>
607
608         Reviewed by Adele Peterson.
609
610         REGRESSION (r51728): update-webkit fails when the current directory is
611         not inside a Subversion working copy
612         https://bugs.webkit.org/show_bug.cgi?id=32204
613
614         * Scripts/update-webkit: Invoke isSVN() in the correct working
615         directory.
616
617 2009-12-06  Adam Barth  <abarth@webkit.org>
618
619         Reviewed by Eric Seidel.
620
621         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
622         https://bugs.webkit.org/show_bug.cgi?id=32202
623
624         * Scripts/modules/commands/queues.py:
625
626 2009-12-05  Adam Barth  <abarth@webkit.org>
627
628         Reviewed by Eric Seidel.
629
630         [bzt] Implement ChromiumPort
631         https://bugs.webkit.org/show_bug.cgi?id=32182
632
633         * Scripts/modules/webkitport.py:
634         * Scripts/modules/webkitport_unittest.py:
635
636 2009-12-05  Adam Barth  <abarth@webkit.org>
637
638         Reviewed by Eric Seidel.
639
640         Move update-webkit into BuildSteps
641         https://bugs.webkit.org/show_bug.cgi?id=32181
642
643         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
644         that WebKit exists.  The proper place for the knowledge of the existence of
645         update-webkit is in WebKitPort because some ports have specialized update
646         scripts (analogous to build-webkit).
647
648         * Scripts/modules/buildsteps.py:
649         * Scripts/modules/commands/download.py:
650         * Scripts/modules/landingsequence.py:
651         * Scripts/modules/scm.py:
652         * Scripts/modules/webkitport.py:
653
654 2009-12-05  Adam Barth  <abarth@webkit.org>
655
656         Reviewed by Eric Seidel.
657
658         update-webkit should call git svn rebase and resolve-ChangeLogs -f
659         https://bugs.webkit.org/show_bug.cgi?id=27162
660
661         Teach update-webkit about Git.  I didn't add the call to
662         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
663         can iterate from here, however.
664
665         * Scripts/update-webkit:
666
667 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
668
669         Unreviewed build fix.
670
671         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
672
673         * DumpRenderTree/qt/DumpRenderTree.cpp:
674
675 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
676
677         Reviewed by Adam Treat.
678
679         Add some missing methods for showing and hiding the
680         Web Inspector.
681
682         * DumpRenderTree/qt/DumpRenderTree.cpp:
683         (WebCore::WebPage::WebPage):
684         (WebCore::WebPage::~WebPage):
685         (WebCore::WebPage::webInspector):
686         * DumpRenderTree/qt/DumpRenderTree.h:
687         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
688         (LayoutTestController::showWebInspector):
689         (LayoutTestController::hideWebInspector):
690         * DumpRenderTree/qt/LayoutTestControllerQt.h:
691
692 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
693
694         Reviewed by Adam Treat.
695
696         Implement the setAllowUniversalAccessFromFileURLs method
697         for the Qt LayoutTestController.
698
699         * DumpRenderTree/qt/DumpRenderTree.cpp:
700         (WebCore::WebPage::resetSettings):
701         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
702         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
703         * DumpRenderTree/qt/LayoutTestControllerQt.h:
704
705 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
706
707         Reviewed by Darin Adler.
708
709         REGRESSION: AX: buttons now extremely repetitive
710         https://bugs.webkit.org/show_bug.cgi?id=32164
711
712         * DumpRenderTree/AccessibilityUIElement.cpp:
713         (isAttributeSupportedCallback):
714         (AccessibilityUIElement::getJSClass):
715         * DumpRenderTree/AccessibilityUIElement.h:
716         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
717         (AccessibilityUIElement::isAttributeSupported):
718         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
719         (AccessibilityUIElement::isAttributeSupported):
720         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
721         (AccessibilityUIElement::isAttributeSupported):
722
723 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
724
725         Reviewed by David Levin.
726
727         check-webkit-style should check for camelCase variable names
728         https://bugs.webkit.org/show_bug.cgi?id=32051
729
730         * Scripts/modules/cpp_style.py:
731         * Scripts/modules/cpp_style_unittest.py:
732
733 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
734
735         Reviewed by Eric Seidel.
736
737         AX: VO just says "term" on many web sites
738         https://bugs.webkit.org/show_bug.cgi?id=32139
739
740         * DumpRenderTree/AccessibilityUIElement.cpp:
741         (getRoleDescriptionCallback):
742         (AccessibilityUIElement::getJSClass):
743         * DumpRenderTree/AccessibilityUIElement.h:
744         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
745         (AccessibilityUIElement::roleDescription):
746         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
747         (AccessibilityUIElement::roleDescription):
748         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
749         (AccessibilityUIElement::roleDescription):
750
751 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
752
753         Reviewed by Beth Dakin.
754
755         Implement WAI-ARIA scrollbar role and related property aria-orientation
756         https://bugs.webkit.org/show_bug.cgi?id=32126
757
758         * DumpRenderTree/AccessibilityUIElement.cpp:
759         (getOrientationCallback):
760         (AccessibilityUIElement::getJSClass):
761         * DumpRenderTree/AccessibilityUIElement.h:
762         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
763         (AccessibilityUIElement::orientation):
764         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
765         (AccessibilityUIElement::orientation):
766         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
767         (AccessibilityUIElement::orientation):
768
769 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
770
771         Reviewed by Adam Roben.
772
773         Minor correction to r51663.
774
775         * DumpRenderTree/win/DumpRenderTree.cpp:
776         (addQTDirToPATH):
777             GetEnvironmentVariable -> GetEnvironmentVariableW.
778
779 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
780
781         Reviewed by Adam Roben.
782
783         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
784         https://bugs.webkit.org/show_bug.cgi?id=30256
785
786         Add the QuickTime dll directory to the PATH environment variable so
787         inialization can succeed.
788
789         * DumpRenderTree/win/DumpRenderTree.cpp:
790         (addQTDirToPATH):
791         (initialize):
792
793 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
794
795         Reviewed by Kenneth Rohde Christiansen.
796
797         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
798
799         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
800         (LayoutTestController::maybeDump):
801
802 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
803
804         Reviewed by Eric Seidel.
805
806         Update pywebsocket to 0.4.3
807         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
808         Stack trace is logged now in INFO level.
809         https://bugs.webkit.org/show_bug.cgi?id=32097
810
811         * pywebsocket/mod_pywebsocket/dispatch.py:
812         * pywebsocket/mod_pywebsocket/msgutil.py:
813         * pywebsocket/mod_pywebsocket/standalone.py:
814         * pywebsocket/mod_pywebsocket/util.py:
815         * pywebsocket/setup.py:
816         * pywebsocket/test/test_dispatch.py:
817         * pywebsocket/test/test_util.py:
818
819 2009-12-03  Sam Weinig  <sam@webkit.org>
820
821         Reviewed by Gavin Barraclough.
822
823         Fix JSClassRef leak.
824
825         * DumpRenderTree/AccessibilityController.cpp:
826         (AccessibilityController::makeWindowObject):
827         * DumpRenderTree/GCController.cpp:
828         (GCController::makeWindowObject):
829         * DumpRenderTree/LayoutTestController.cpp:
830         (LayoutTestController::makeWindowObject):
831
832 2009-12-03  Brady Eidson  <beidson@apple.com>
833
834         Reviewed by Sam Weinig.
835
836         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
837
838         Keep DRT-win building...
839
840         * DumpRenderTree/win/FrameLoadDelegate.h:
841         (FrameLoadDelegate::didPushStateWithinPageForFrame):
842         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
843         (FrameLoadDelegate::didPopStateWithinPageForFrame):
844
845 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
846
847         Unreviewed build fix.
848
849         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
850
851         * DumpRenderTree/qt/DumpRenderTree.cpp:
852
853 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
854
855         Reviewed by Kenneth Rohde Christiansen.
856
857         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
858         Prevent DRT from showing the main view if these childs get deleted.
859         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
860
861         * DumpRenderTree/qt/DumpRenderTree.cpp:
862         (WebCore::WebPage::WebPage):
863         (WebCore::DumpRenderTree::DumpRenderTree):
864         (WebCore::DumpRenderTree::~DumpRenderTree):
865         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
866         (WebCore::DumpRenderTree::open):
867         (WebCore::DumpRenderTree::closeRemainingWindows):
868         (WebCore::DumpRenderTree::createWindow):
869         (WebCore::DumpRenderTree::windowCount):
870         * DumpRenderTree/qt/DumpRenderTree.h:
871
872 2009-12-02  Eric Seidel  <eric@webkit.org>
873
874         Reviewed by Adam Barth.
875
876         REGRESSION(51595): commit-queue is throwing exceptions
877         https://bugs.webkit.org/show_bug.cgi?id=32083
878
879         * Scripts/modules/commands/queues.py:
880          - Don't use default value of [] as it ends up getting shared.
881          - Make log_progress accept arrays of ints as well as strings.
882          - Return an exit code from execute()
883         * Scripts/modules/commands/queues_unittest.py: Added.
884          - Test to make sure log_progress will accept ints.
885          - Test to make sure run_bugzilla_tool will accept ints.
886         * Scripts/modules/workqueue.py:
887          - Print the stack trace on unexpected exceptions for easier debugging.
888         * Scripts/run-webkit-unittests:
889          - Add queues_unittest.
890
891         * Scripts/modules/commands/queues.py:
892         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
893         * Scripts/modules/mock_bugzillatool.py:
894         * Scripts/modules/workqueue.py:
895         * Scripts/run-webkit-unittests:
896
897 2009-12-02  David Levin  <levin@chromium.org>
898
899         Reviewed by Adam Barth.
900
901         check-webkit-style is too noisy about namespace indenting issues.
902         https://bugs.webkit.org/show_bug.cgi?id=32096
903
904         * Scripts/modules/cpp_style.py:
905         Added a _FileState object to be able to track file level information. In this
906         case, it simply tracks whether the error has already been given, so that it isn't
907         done again.
908         * Scripts/modules/cpp_style_unittest.py:
909         Modified test cases to pass in the _FileState object and fix a test that expected
910         to see the namespace error twice (now it only occurs once). No new tests because
911         existing tests cover the change in functionality.
912
913 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
914
915         Reviewed by Eric Seidel.
916
917         [wx] Get DumpRenderTree building after waf switch.
918         
919         https://bugs.webkit.org/show_bug.cgi?id=32041
920
921         * DumpRenderTree/wscript: Added.
922         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
923         (LayoutTestController::setTimelineProfilingEnabled):
924         (LayoutTestController::evaluateScriptInIsolatedWorld):
925         (LayoutTestController::disableImageLoading):
926         (LayoutTestController::whiteListAccessFromOrigin):
927         (LayoutTestController::counterValueForElementById):
928         * Scripts/build-webkit:
929
930 2009-12-02  Adam Barth  <abarth@webkit.org>
931
932         Reviewed by Eric Seidel.
933
934         [bzt] build-attachment shouldn't check whether the builders are red
935         https://bugs.webkit.org/show_bug.cgi?id=32062
936
937         build-attachment doesn't touch the remote repository, so there isn't a
938         need to hold off when the builders are red.
939
940         * Scripts/modules/commands/download.py:
941         * Scripts/modules/landingsequence.py:
942
943 2009-12-02  Eric Seidel  <eric@webkit.org>
944
945         Reviewed by Adam Barth.
946
947         REGRESSION(51590): style-queue and build-queue think their empty when they are not
948         https://bugs.webkit.org/show_bug.cgi?id=32061
949
950         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
951         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
952
953 2009-12-02  Eric Seidel  <eric@webkit.org>
954
955         Reviewed by Adam Barth.
956
957         build-queue is throwing exceptions and complaining about
958         lack of --no-update on build-attachment.  Make it stop.
959
960         * Scripts/modules/buildsteps.py:
961         * Scripts/modules/commands/download.py:
962
963 2009-12-02  Adam Barth  <abarth@webkit.org>
964
965         Unreviewed "build" fix.  Forgot to declare my variables.  :(
966
967         * QueueStatusServer/queue_status.py:
968
969 2009-12-02  Adam Barth  <abarth@webkit.org>
970
971         Reviewed by Eric Seidel.
972
973         [bzt] Implement status bubble view
974         https://bugs.webkit.org/show_bug.cgi?id=32057
975
976         The status bubble is a compact representation of the queue status for a
977         given patch.  This will eventually help us reduce the comment spam from
978         the queues.
979
980         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
981         * QueueStatusServer/queue_status.py:
982         * QueueStatusServer/status_bubble.html: Added.
983
984 2009-12-02  Eric Seidel  <eric@webkit.org>
985
986         Reviewed by Adam Barth.
987
988         trim commands/*.py includes now that commands are unit tested
989         https://bugs.webkit.org/show_bug.cgi?id=32056
990
991         In the course of ensuring that the unit tests still
992         passed after this change, I had to actually make them
993         pass in the first place.
994
995         * Scripts/modules/bugzilla.py:
996          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
997         * Scripts/modules/commands/download.py: Remove unneeded imports.
998         * Scripts/modules/commands/queries.py: Ditto.
999         * Scripts/modules/commands/queues.py: Ditto.
1000         * Scripts/modules/commands/upload.py: Ditto.
1001         * Scripts/modules/scm_unittest.py:
1002          - Fix to expect the \n after the path since echo adds an \n.
1003
1004 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
1005
1006         build-webkit: Remove flex,bison,gperf check for chromium
1007         https://bugs.webkit.org/show_bug.cgi?id=32043
1008
1009         * Scripts/webkitdirs.pm:
1010
1011 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1012
1013         Build fixage for Windows/GTK for DumpRenderTree.
1014
1015         WAI-ARIA: implement support for ARIA drag and drop
1016         https://bugs.webkit.org/show_bug.cgi?id=32007
1017
1018         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1019         (AccessibilityUIElement::ariaIsGrabbed):
1020         (AccessibilityUIElement::ariaDropEffects):
1021         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1022         (AccessibilityUIElement::ariaIsGrabbed):
1023         (AccessibilityUIElement::ariaDropEffects):
1024
1025 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1026
1027         Reviewed by Darin Adler.
1028
1029         WAI-ARIA: implement support for ARIA drag and drop
1030         https://bugs.webkit.org/show_bug.cgi?id=32007
1031
1032         * DumpRenderTree/AccessibilityUIElement.cpp:
1033         (getARIADropEffectsCallback):
1034         (getARIAIsGrabbedCallback):
1035         (AccessibilityUIElement::getJSClass):
1036         * DumpRenderTree/AccessibilityUIElement.h:
1037         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1038         (AccessibilityUIElement::ariaIsGrabbed):
1039         (AccessibilityUIElement::ariaDropEffects):
1040
1041 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1042
1043         Not reviewed. GTK DRT try 2.
1044
1045         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1046         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1047
1048 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1049
1050         Not reviewed. Try to fix gtk DRT build.
1051
1052         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1053
1054 2009-12-01  David Levin  <levin@chromium.org>
1055
1056         Reviewed by Eric Seidel.
1057
1058         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
1059         https://bugs.webkit.org/show_bug.cgi?id=32033
1060
1061         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
1062                                         instead of startswith.
1063         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
1064
1065 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1066
1067         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
1068
1069         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
1070
1071 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1072
1073         Reviewed by Simon Fraser.
1074
1075         Add SVG animation test framework with 'snapshot' functionality
1076         https://bugs.webkit.org/show_bug.cgi?id=31897
1077
1078         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
1079         used by the new SVG animation testing framework, implemented
1080         for qt/gtk/win/mac.
1081
1082         * DumpRenderTree/LayoutTestController.cpp:
1083         (sampleSVGAnimationForElementAtTimeCallback):
1084         (LayoutTestController::staticFunctions):
1085         * DumpRenderTree/LayoutTestController.h:
1086         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1087         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1088         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1089         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1090         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1091         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1092         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1093         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1094         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1095         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1096         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1097
1098 2009-12-01  Adam Roben  <aroben@apple.com>
1099
1100         Remove user content before running each test on Windows
1101
1102         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
1103
1104         Reviewed by Alexey Proskuryakov.
1105
1106         * DumpRenderTree/win/DumpRenderTree.cpp:
1107         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
1108         before each test, which matches Mac.
1109
1110 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
1111
1112         Reviewed by Alexey Proskuryakov.
1113
1114         Make pywebsocket log errors to a file
1115         https://bugs.webkit.org/show_bug.cgi?id=31604
1116
1117         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
1118         (by passing the path to the server via a recently added -l option).
1119
1120 2009-12-01  Adam Roben  <aroben@apple.com>
1121
1122         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
1123
1124         Reviewed by Ada Chan.
1125
1126         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
1127         TestNetscapePlugin fail in Debug_Internal builds
1128
1129         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
1130         directory in Debug and Debug_All builds, but not in Debug_Internal
1131         builds.
1132
1133 2009-12-01  Adam Roben  <aroben@apple.com>
1134
1135         Re-enable DRT's watchdog timer on Windows
1136
1137         It was accidentally disabled in r50907.
1138
1139         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1140         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
1141         into an if condition.
1142
1143 2009-12-01  Adam Barth  <abarth@webkit.org>
1144
1145         Reviewed by Eric Seidel.
1146
1147         check-webkit-style complains about #imports with / in them
1148         https://bugs.webkit.org/show_bug.cgi?id=32022
1149
1150         We need to exclude #import directives in addition to #include from the
1151         binary operator whitespace checks.
1152
1153         * Scripts/modules/cpp_style.py:
1154         * Scripts/modules/cpp_style_unittest.py:
1155
1156 2009-11-30  Adam Barth  <abarth@webkit.org>
1157
1158         Reviewed by Eric Seidel.
1159
1160         check-webkit-style is slightly too verbose
1161         https://bugs.webkit.org/show_bug.cgi?id=32010
1162
1163         check-webkit-style prints out a bunch of "done" lines that seem redundant,
1164         especially for the style-queue.
1165
1166         * Scripts/modules/cpp_style.py:
1167
1168 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
1169
1170         Reviewed by Eric Seidel.
1171
1172         [GTK] Moved the functions that are closing the result log of the
1173         tests to the last line of the runTest function, this avoids
1174         reporting crashes in the wrong test if there is a problem when
1175         reseting the state after the test.
1176
1177         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1178         (dump):
1179         (runTest):
1180
1181 2009-11-30  Sam Weinig  <sam@webkit.org>
1182
1183         Reviewed by Geoffrey Garen.
1184
1185         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
1186         fast/js/date-proto-generic-invocation breaks another test
1187
1188         Don't cache JSClassRefs, a change to the prototype chain will
1189         last between tests.
1190
1191         * DumpRenderTree/AccessibilityController.cpp:
1192         (AccessibilityController::getJSClass):
1193         * DumpRenderTree/GCController.cpp:
1194         (GCController::getJSClass):
1195         * DumpRenderTree/GCController.h:
1196         * DumpRenderTree/LayoutTestController.cpp:
1197         (LayoutTestController::getJSClass):
1198
1199 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
1200
1201         Reviewed by Alexey Proskuryakov.
1202
1203         Update pywebsocket to 0.4.2.1.
1204         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
1205         https://bugs.webkit.org/show_bug.cgi?id=31976
1206
1207         * pywebsocket/mod_pywebsocket/standalone.py:
1208         * pywebsocket/setup.py:
1209
1210 2009-11-30  Adam Barth  <abarth@webkit.org>
1211
1212         Reviewed by Eric Seidel.
1213
1214         [bzt] Generate pass messages for style-queue
1215         https://bugs.webkit.org/show_bug.cgi?id=31995
1216
1217         With this change, the style-queue posts "pass" messages to bugs as
1218         well.  Also, added more information to the state store w.r.t. passing
1219         and failing.
1220
1221         * Scripts/modules/commands/queues.py:
1222         * Scripts/modules/patchcollection.py:
1223
1224 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1225
1226         Reviewed by Simon Fraser.
1227
1228         Check for WEBKIT_TESTFONTS environment variable in
1229         run-webkit-tests, for GTK+, to have a more prominent error
1230         message.
1231
1232         * Scripts/run-webkit-tests:
1233
1234 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
1235
1236         Reviewed by Dimitri Glazkov.
1237
1238         update-webkit --chromium forces gclient sync
1239
1240         https://bugs.webkit.org/show_bug.cgi?id=31967
1241
1242         * Scripts/update-webkit-chromium:
1243
1244 2009-11-29  Eric Seidel  <eric@webkit.org>
1245
1246         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
1247
1248         * Scripts/modules/committers.py:
1249
1250 2009-11-29  Eric Seidel  <eric@webkit.org>
1251
1252         No review, just adding missing svn property.
1253
1254         Set svn:executable property on new scripts.
1255         These were added by commit-queue commits, but the executable
1256         property was lost due to a bug in svn-apply:
1257         https://bugs.webkit.org/show_bug.cgi?id=27204
1258
1259         * Scripts/update-webkit-chromium: Added property svn:executable.
1260         * Scripts/validate-committer-lists: Added property svn:executable.
1261
1262 2009-11-29  Eric Seidel  <eric@webkit.org>
1263
1264         Reviewed by Adam Barth.
1265
1266         Need a way to validate that committers.py includes all committers/reviewers
1267         https://bugs.webkit.org/show_bug.cgi?id=30970
1268
1269         Add a script which knows how to compare our public committer/reviewer
1270         lists and show discrepancies between them.
1271
1272         Validates mailing lists vs. committers.py:
1273         - committers.py committers missing from webkit-committers@lists
1274         - webkit-committers@lists members missing from committers.py
1275         - committers.py reviewers missing from webkit-reviewers@lists
1276         - webkit-reviewers@lists members missing from committers.py
1277         - webkit-reviewers@lists members missing from committers.py reviewer list
1278
1279         Validates committers.py vs. trunk/ SVN history:
1280         - committers who have not committed in over a year
1281         - SVN committers missing from committers.py
1282         - committers.py members who have no record in SVN.
1283
1284         All of these lists still show "false positives" until a few more committers.py updates are made, like:
1285         https://bugs.webkit.org/show_bug.cgi?id=31366
1286
1287         * Scripts/validate-committer-lists: Added.
1288
1289 2009-11-28  Adam Barth  <abarth@webkit.org>
1290
1291         Reviewed by Eric Seidel.
1292
1293         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
1294         https://bugs.webkit.org/show_bug.cgi?id=31950
1295
1296         Now we cache the last status that we get back from QueueStatusServer.
1297         Eventually we'll have to do something more fancy if we want to support
1298         a "try again" button on QueueStatusServer, but we can cross that bridge
1299         when we come to it.
1300
1301         * Scripts/modules/patchcollection.py:
1302
1303 2009-11-28  Adam Barth  <abarth@webkit.org>
1304
1305         Reviewed by Eric Seidel.
1306
1307         StyleQueue scans ~100 bug pages every 5 minutes
1308         https://bugs.webkit.org/show_bug.cgi?id=31947
1309
1310         Instead of getting the pending-review attachment ids by scanning each
1311         bug (which results in a network request), we should just get them all
1312         from webkit.org/pending-review in one shot.
1313
1314         * Scripts/modules/bugzilla.py:
1315         * Scripts/modules/bugzilla_unittest.py:
1316         * Scripts/modules/commands/queries.py:
1317         * Scripts/modules/commands/queries_unittest.py:
1318         * Scripts/modules/commands/queues.py:
1319         * Scripts/modules/mock_bugzillatool.py:
1320         * Scripts/modules/patchcollection.py:
1321
1322 2009-11-28  Adam Barth  <abarth@webkit.org>
1323
1324         Reviewed by Eric Seidel.
1325
1326         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
1327         https://bugs.webkit.org/show_bug.cgi?id=31952
1328
1329         The mailing list is open for anyone to subscribe.
1330
1331         * Scripts/modules/bugzilla.py:
1332         * Scripts/modules/commands/queues.py:
1333
1334 2009-11-28  Adam Barth  <abarth@webkit.org>
1335
1336         Reviewed by Eric Seidel.
1337
1338         [bzt] style-queue should report style errors to bugzilla
1339         https://bugs.webkit.org/show_bug.cgi?id=31945
1340
1341         Currently, we're just logging the style errors locally.  With this
1342         patch we'll actually log the errors to bugzilla.  Note: I plan to run
1343         with the "local-only" logging during development.
1344
1345         * Scripts/modules/commands/queues.py:
1346         * Scripts/modules/scm.py:
1347
1348 2009-11-28  Adam Barth  <abarth@webkit.org>
1349
1350         Reviewed by Eric Seidel.
1351
1352         [bzt] style-queue shouldn't reject patches from the commit-queue
1353         https://bugs.webkit.org/show_bug.cgi?id=31944
1354
1355         Currently the style-queue subprocess gets confused and thinks its the
1356         commit-queue.  If the patch has an error, it rejects it from the
1357         commit-queue.  Instead, we should have style-queue specific logic.
1358         This patch doesn't add that logic, but it gives us a callback we can
1359         use to add that logic.
1360
1361         * Scripts/modules/buildsteps.py:
1362         * Scripts/modules/commands/queues.py:
1363         * Scripts/modules/landingsequence.py:
1364
1365 2009-11-27  Adam Barth  <abarth@webkit.org>
1366
1367         Rubber stamped by Eric Seidel.
1368
1369         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
1370
1371         * CommitQueueStatus: Removed.
1372         * CommitQueueStatus/app.yaml: Removed.
1373         * CommitQueueStatus/filters: Removed.
1374         * CommitQueueStatus/filters/__init__.py: Removed.
1375         * CommitQueueStatus/filters/webkit_extras.py: Removed.
1376         * CommitQueueStatus/index.html: Removed.
1377         * CommitQueueStatus/index.yaml: Removed.
1378         * CommitQueueStatus/queue_status.py: Removed.
1379         * CommitQueueStatus/stylesheets: Removed.
1380         * CommitQueueStatus/stylesheets/main.css: Removed.
1381         * CommitQueueStatus/update_status.html: Removed.
1382         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
1383
1384 2009-11-27  Adam Barth  <abarth@webkit.org>
1385
1386         Reviewed by Eric Seidel.
1387
1388         style-queue should only process each patch once
1389         https://bugs.webkit.org/show_bug.cgi?id=31939
1390
1391         Actually address reviewer comments!
1392
1393         * Scripts/bugzilla-tool:
1394
1395 2009-11-27  Adam Barth  <abarth@webkit.org>
1396
1397         Reviewed by Eric Seidel.
1398
1399         [bzt] style-queue fails to apply a bunch of patches for no reason
1400         https://bugs.webkit.org/show_bug.cgi?id=31942
1401
1402         By passing --non-interactive to check-style, we convince check-style
1403         to pass --force to svn-apply, which lets it apply more patches.
1404
1405         * Scripts/modules/commands/queues.py:
1406
1407 2009-11-27  Adam Barth  <abarth@webkit.org>
1408
1409         Reviewed by Eric Seidel.
1410
1411         [bzt] Support --status-host in style-queue
1412         https://bugs.webkit.org/show_bug.cgi?id=31941
1413
1414         * Scripts/modules/commands/queues.py:
1415         * Scripts/modules/statusbot.py:
1416
1417 2009-11-27  Adam Barth  <abarth@webkit.org>
1418
1419         Reviewed by Eric Seidel.
1420
1421         style-queue should only process each patch once
1422         https://bugs.webkit.org/show_bug.cgi?id=31939
1423
1424         Before processing a patch, the try-queues now ask the web service
1425         whether they have already processed the patch.  This is an initial cut
1426         of this functionality.  I expect we're make it richer over time.
1427
1428         * Scripts/bugzilla-tool:
1429         * Scripts/modules/commands/queues.py:
1430         * Scripts/modules/patchcollection.py:
1431
1432 2009-11-27  Adam Barth  <abarth@webkit.org>
1433
1434         Reviewed by Eric Seidel.
1435
1436         PatchStatus does not return status
1437         https://bugs.webkit.org/show_bug.cgi?id=31938
1438
1439         We need to parse attachment_id as an int.  Otherwise, we can't find
1440         anything in the datastore.
1441
1442         * CommitQueueStatus/queue_status.py:
1443
1444 2009-11-27  Adam Barth  <abarth@webkit.org>
1445
1446         Reviewed by Eric Seidel.
1447
1448         Make commit-queue status not throw an exception where there is not
1449         status
1450         https://bugs.webkit.org/show_bug.cgi?id=31936
1451
1452         We need to actually fetch the results of the query to see what's in the
1453         datastore.
1454
1455         * CommitQueueStatus/queue_status.py:
1456
1457 2009-11-27  Adam Barth  <abarth@webkit.org>
1458
1459         Reviewed by Eric Seidel.
1460
1461         [bzt] unit test ApplyPatches and ApplyAttachment
1462         https://bugs.webkit.org/show_bug.cgi?id=31935
1463
1464         * Scripts/modules/commands/download.py:
1465         * Scripts/modules/commands/download_unittest.py:
1466
1467 2009-11-27  Adam Barth  <abarth@webkit.org>
1468
1469         Reviewed by Eric Seidel.
1470
1471         [bzt] Unit test download commands
1472         https://bugs.webkit.org/show_bug.cgi?id=31923
1473
1474         Adds download_unittest and fixes a bug found while testing.
1475
1476         * Scripts/modules/commands/commandtest.py:
1477         * Scripts/modules/commands/download.py:
1478             Fixed a bug where we'd throw an error because [].append returns
1479             None.
1480         * Scripts/modules/commands/download_unittest.py: Added.
1481         * Scripts/modules/mock_bugzillatool.py:
1482         * Scripts/run-webkit-unittests:
1483
1484 2009-11-27  Adam Barth  <abarth@webkit.org>
1485
1486         Unreviewed "build" fix found while writing unit tests.
1487
1488         * Scripts/modules/commands/download.py:
1489
1490 2009-11-27  Adam Barth  <abarth@webkit.org>
1491
1492         Reviewed by Eric Seidel.
1493
1494         [bzt] Kill WebKitLandingScripts
1495         https://bugs.webkit.org/show_bug.cgi?id=31904
1496
1497         Step 6: Kill the rest.
1498
1499         * Scripts/modules/buildsteps.py:
1500         * Scripts/modules/commands/download.py:
1501         * Scripts/modules/commands/queries.py:
1502         * Scripts/modules/commands/upload.py:
1503         * Scripts/modules/landingsequence.py:
1504         * Scripts/modules/scm.py:
1505         * Scripts/modules/webkitlandingscripts.py: Removed.
1506
1507 2009-11-27  Adam Barth  <abarth@webkit.org>
1508
1509         Reviewed by Eric Seidel.
1510
1511         [bzt] Unit test upload commands
1512         https://bugs.webkit.org/show_bug.cgi?id=31903
1513
1514         Adds unit tests for all but two of the upload commands.  The two
1515         remaining ones are more difficult.  I'll return to them later.  The
1516         goal of these tests is just to run the commands.  We can test more
1517         detailed behavior later.
1518
1519         * Scripts/modules/commands/commandtest.py:
1520         * Scripts/modules/commands/upload.py:
1521         * Scripts/modules/commands/upload_unittest.py:
1522         * Scripts/modules/mock.py: Added.
1523         * Scripts/modules/mock_bugzillatool.py:
1524
1525 2009-11-26  Adam Barth  <abarth@webkit.org>
1526
1527         Reviewed by Eric Seidel.
1528
1529         [bzt] Kill WebKitLandingScripts
1530         https://bugs.webkit.org/show_bug.cgi?id=31904
1531
1532         Step 5: Kill run_and_throw_if_fail.
1533
1534         * Scripts/modules/buildsteps.py:
1535         * Scripts/modules/processutils.py: Added.
1536         * Scripts/modules/webkitlandingscripts.py:
1537
1538 2009-11-26  Adam Barth  <abarth@webkit.org>
1539
1540         Reviewed by Eric Seidel.
1541
1542         [bzt] Kill WebKitLandingScripts
1543         https://bugs.webkit.org/show_bug.cgi?id=31904
1544
1545         Step 4: Kill run_webkit_script.
1546
1547         * Scripts/modules/buildsteps.py:
1548         * Scripts/modules/commands/download.py:
1549         * Scripts/modules/webkitlandingscripts.py:
1550
1551 2009-11-26  Adam Barth  <abarth@webkit.org>
1552
1553         Reviewed by Eric Seidel.
1554
1555         [bzt] Kill WebKitLandingScripts
1556         https://bugs.webkit.org/show_bug.cgi?id=31904
1557
1558         Step 3: Kill build_webkit.
1559
1560         * Scripts/modules/buildsteps.py:
1561         * Scripts/modules/landingsequence.py:
1562         * Scripts/modules/webkitlandingscripts.py:
1563
1564 2009-11-26  Adam Barth  <abarth@webkit.org>
1565
1566         Reviewed by Eric Seidel.
1567
1568         [bzt] Kill WebKitLandingScripts
1569         https://bugs.webkit.org/show_bug.cgi?id=31904
1570
1571         Step 2: Kill ensure_builders_are_green.
1572
1573         * Scripts/modules/buildsteps.py:
1574         * Scripts/modules/commands/download.py:
1575         * Scripts/modules/landingsequence.py:
1576         * Scripts/modules/webkitlandingscripts.py:
1577
1578 2009-11-26  Adam Barth  <abarth@webkit.org>
1579
1580         Reviewed by Eric Seidel.
1581
1582         [bzt] Kill WebKitLandingScripts
1583         https://bugs.webkit.org/show_bug.cgi?id=31904
1584
1585         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
1586
1587         * Scripts/bugzilla-tool:
1588         * Scripts/modules/buildsteps.py: Added.
1589         * Scripts/modules/commands/download.py:
1590         * Scripts/modules/landingsequence.py:
1591         * Scripts/modules/webkitlandingscripts.py:
1592
1593 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
1594
1595         Reviewed by Adam Barth.
1596
1597         Remove directory prefixes from linux commands
1598
1599         SCM unittests can cause errors on some systems if we use absolute reference to
1600         the commands, so directory prefixes have been removed.
1601
1602         * Scripts/modules/scm_unittest.py:
1603
1604 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
1605
1606         Reviewed by Kenneth Rohde Christiansen.
1607
1608         Link DumpRenderTree to the Qt Ui Tools
1609         https://bugs.webkit.org/show_bug.cgi?id=31203
1610
1611         Implement QWebPage::createPlugin using the Qt Ui Tools
1612         to be able to create classes like QProgressBar from within
1613         the <object></object> tags This is required for the
1614         new automatic test of Qt Plugins.
1615
1616         * DumpRenderTree/qt/DumpRenderTree.cpp:
1617         (WebCore::WebPage::createPlugin):
1618         * DumpRenderTree/qt/DumpRenderTree.h:
1619         * DumpRenderTree/qt/DumpRenderTree.pro:
1620
1621 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
1622
1623         Reviewed by Eric Seidel.
1624
1625         Update pywebsocket to 0.4.2
1626
1627         Update pywebsocket to 0.4.2
1628         https://bugs.webkit.org/show_bug.cgi?id=31861
1629
1630         * pywebsocket/example/echo_client.py:
1631         * pywebsocket/example/echo_wsh.py:
1632         * pywebsocket/mod_pywebsocket/__init__.py:
1633         * pywebsocket/mod_pywebsocket/dispatch.py:
1634         * pywebsocket/mod_pywebsocket/msgutil.py:
1635         * pywebsocket/mod_pywebsocket/standalone.py:
1636         * pywebsocket/setup.py:
1637         * pywebsocket/test/test_dispatch.py:
1638         * pywebsocket/test/test_msgutil.py:
1639
1640 2009-11-25  Adam Barth  <abarth@webkit.org>
1641
1642         Reviewed by Eric Seidel.
1643
1644         Add unit test for mark-fixed
1645         https://bugs.webkit.org/show_bug.cgi?id=31896
1646
1647         * Scripts/modules/commands/commandtest.py: Added.
1648         * Scripts/modules/commands/queries_unittest.py:
1649         * Scripts/modules/commands/upload_unittest.py: Added.
1650         * Scripts/modules/mock_bugzillatool.py:
1651         * Scripts/run-webkit-unittests:
1652
1653 2009-11-25  Adam Barth  <abarth@webkit.org>
1654
1655         Reviewed by Eric Seidel.
1656
1657         bugzilla-tool should have a mark-fixed command
1658         https://bugs.webkit.org/show_bug.cgi?id=31853
1659
1660         Pretty simple stuff.
1661
1662         * Scripts/modules/commands/upload.py:
1663
1664 2009-11-25  Eric Seidel  <eric@webkit.org>
1665
1666         Reviewed by Adam Barth.
1667
1668         'bugzilla-tool help' should only show common commands like how 'git help' does
1669         https://bugs.webkit.org/show_bug.cgi?id=31772
1670
1671         I also took this opportunity to make 'help' a real Command.
1672         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
1673
1674         * Scripts/bugzilla-tool:
1675          - change should_show_command_help to should_show_in_main_help
1676         * Scripts/modules/commands/download.py:
1677          - Mark commands as being shown in main help or not.
1678          - show_in_main_help = False is not required (default is false),
1679            but it seemed to make the commands more self-documenting.
1680         * Scripts/modules/commands/queries.py: ditto
1681         * Scripts/modules/commands/queues.py: ditto
1682         * Scripts/modules/commands/upload.py: ditto
1683         * Scripts/modules/multicommandtool.py:
1684          - Make Command hold a pointer to tool in self.tool.  Most Command
1685            subclasses do not take advantage of this yet, but it was required
1686            for HelpCommand to be able to reach the tool from _help_epilog().
1687          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
1688          - Move MultiCommandTool._help_epilog to Command._help_epilog
1689          - Move "help" logic into HelpCommand.execute()
1690          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
1691         * Scripts/modules/multicommandtool_unittest.py:
1692          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
1693
1694 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
1695
1696         Reviewed by Dan Bernstein.
1697         
1698         Patch by Mark Rowe.
1699
1700         The buildbots are failing on Windows because when they were upgraded
1701         to 4.0.4, Apple Application Support was not in their path. Add it to
1702         the path to fix the buildots.
1703
1704         * Scripts/webkitdirs.pm:
1705
1706 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1707
1708         Reviewed by David Kilzer.
1709
1710         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1711         https://bugs.webkit.org/show_bug.cgi?id=31799
1712
1713         * Scripts/run-webkit-tests: Fixed.
1714
1715 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1716
1717         Reviewed by Eric Seidel.
1718
1719         Change run_command to give back stderr by default
1720         https://bugs.webkit.org/show_bug.cgi?id=31734
1721
1722         Change run_command to give back stderr by default.
1723         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1724         Change the related unittest call.
1725
1726         * Scripts/modules/scm.py:
1727         * Scripts/modules/scm_unittest.py:
1728
1729 2009-11-25  Eric Seidel  <eric@webkit.org>
1730
1731         Reviewed by Adam Barth.
1732
1733         Centralize required argument parsing in Command
1734         https://bugs.webkit.org/show_bug.cgi?id=31872
1735
1736         * Scripts/modules/commands/download.py: remove custom required arg message.
1737         * Scripts/modules/commands/upload.py: ditto.
1738         * Scripts/modules/multicommandtool.py:
1739          - Add _parse_required_arguments.
1740          - Pass program name off to OptionParser.
1741          - Add name() for access to tool name.
1742          - Add check_arguments_and_execute and make it return a return code.
1743          - Replace a couple uses of + with %.
1744         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1745
1746 2009-11-25  Eric Seidel  <eric@webkit.org>
1747
1748         Reviewed by Adam Barth.
1749
1750         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1751         https://bugs.webkit.org/show_bug.cgi?id=31870
1752
1753         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1754         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1755         * Scripts/modules/outputcapture.py: Added.
1756
1757 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1758
1759         Reviewed by Eric Seidel.
1760
1761         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1762         https://bugs.webkit.org/show_bug.cgi?id=31444
1763
1764         * Scripts/build-webkit:
1765
1766 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1767
1768         Reviewed by Simon Fraser.
1769
1770         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1771         https://bugs.webkit.org/show_bug.cgi?id=27314
1772         
1773         Now the script allows the directories with these tests to be included on all
1774         platforms but Mac, where they behave the same as always. For all other platforms
1775         the tests need to be excluded using the Skipped files, which is currently done
1776         for all platforms (including win since we're not turned on yet)
1777
1778         * Scripts/webkitdirs.pm:
1779
1780 2009-11-24  Eric Seidel  <eric@webkit.org>
1781
1782         Reviewed by Adam Barth.
1783
1784         queries_unittest.py should test command output
1785         https://bugs.webkit.org/show_bug.cgi?id=31845
1786
1787         * Scripts/modules/commands/queries_unittest.py:
1788          - Capture stdout and stderr and compare with expected strings.
1789
1790 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1791
1792         No Review.
1793
1794         Fix spelling error ("depenedencies").
1795
1796         * Scripts/build-webkit:
1797
1798 2009-11-24  Mark Rowe  <mrowe@apple.com>
1799
1800         Land the configuration that includes the two debug GTK Linux builders.
1801
1802         * BuildSlaveSupport/build.webkit.org-config/config.json:
1803
1804 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1805
1806         <http://webkit.org/b/31840> bisect-builds broke after r50080
1807
1808         Reviewed by Dan Bernstein.
1809
1810         * Scripts/bisect-builds:
1811         (mountAndRunNightly): Switched back to using backticks to run
1812         the hdiutil command since exec() will terminate the existing
1813         script, which is not what we want.  Store the output of
1814         File::Spec->devnull() in a variable for use in the hdiutil
1815         detach commands.
1816
1817 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1818
1819         Reviewed by Kenneth Rohde Christiansen.
1820
1821         Include "config.h" to meet Coding Style Guidelines
1822         https://bugs.webkit.org/show_bug.cgi?id=31792
1823
1824         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1825         * DumpRenderTree/qt/jsobjects.cpp:
1826         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1827
1828 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1829
1830         Reviewed by Oliver Hunt.
1831
1832         Implement new required function to pass test we used to pass. This
1833         change is required since r51294.
1834
1835         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1836         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1837
1838 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1839
1840         Reviewed by Kenneth Rohde Christiansen.
1841
1842         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1843         https://bugs.webkit.org/show_bug.cgi?id=31775
1844
1845         LayoutTestController::dumpBackForwardList() should work with local URLs
1846         as well as with normal URLs (in http tests for instance).
1847         Currently it does not output the latter properly.
1848
1849         Unskip a bunch of passing http/navigation tests.
1850
1851         * DumpRenderTree/qt/DumpRenderTree.cpp:
1852         (WebCore::dumpHistoryItem):
1853
1854 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1855
1856         Reviewed by Oliver Hunt.
1857
1858         ARIA: support aria-flowto
1859         https://bugs.webkit.org/show_bug.cgi?id=31762
1860
1861         * DumpRenderTree/AccessibilityUIElement.cpp:
1862         (ariaFlowToElementAtIndexCallback):
1863         (AccessibilityUIElement::getJSClass):
1864         * DumpRenderTree/AccessibilityUIElement.h:
1865         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1866         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1867         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1868         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1869         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1870         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1871
1872 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1873
1874         Reviewed by Kenneth Christiansen.
1875
1876         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1877         https://bugs.webkit.org/show_bug.cgi?id=31638
1878
1879         Unfreeze WorkQueue after each test execution.
1880
1881         * DumpRenderTree/qt/DumpRenderTree.cpp:
1882         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1883
1884 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1885
1886         Reviewed by Adam Barth.
1887
1888         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1889         for localhost and 127.0.0.1.
1890         https://bugs.webkit.org/show_bug.cgi?id=31783
1891
1892         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1893
1894         * DumpRenderTree/qt/DumpRenderTree.cpp:
1895         (WebCore::NetworkAccessManager::NetworkAccessManager):
1896         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1897         (WebCore::WebPage::WebPage):
1898         * DumpRenderTree/qt/DumpRenderTree.h:
1899
1900 2009-11-22  Chris Evans  <cevans@chromium.org>
1901
1902         Reviewed by Adam Barth.
1903
1904         Disable access to file:/// directory listings
1905         https://bugs.webkit.org/show_bug.cgi?id=31329
1906
1907         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1908         file URL security.
1909
1910         * DumpRenderTree/LayoutTestController.cpp:
1911         (setAllowUniversalAccessFromFileURLsCallback):
1912         (LayoutTestController::staticFunctions):
1913         * DumpRenderTree/LayoutTestController.h:
1914         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1915         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1917         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1918         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1919         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1920         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1921         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1922
1923 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1924
1925         Reviewed by Kenneth Rohde Christiansen.
1926
1927         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1928         https://bugs.webkit.org/show_bug.cgi?id=31638
1929
1930         The test is timeouting, because it uses the WorkQueue to load a document in one
1931         of the child frames and once the loading is finished, the DRT does not dump the
1932         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1933         the main frame, while it should connect to QWebPage::loadFinished().
1934
1935         * DumpRenderTree/qt/DumpRenderTree.cpp:
1936         (WebCore::DumpRenderTree::DumpRenderTree):
1937
1938 2009-11-21  Eric Seidel  <eric@webkit.org>
1939
1940         Reviewed by Adam Barth.
1941
1942         bugzilla-tool --help spews way too much text
1943         https://bugs.webkit.org/show_bug.cgi?id=31771
1944
1945         * Scripts/bugzilla-tool:
1946          - Remove self.cached_scm initialization hack.
1947         * Scripts/modules/buildbot.py:
1948          - Make default_host accessible to callers.
1949         * Scripts/modules/commands/download.py:
1950          - Phrase help for all commands consistently and remove spurious help text punctuation.
1951         * Scripts/modules/commands/queries.py: Ditto.
1952         * Scripts/modules/commands/queues.py: Ditto.
1953         * Scripts/modules/commands/upload.py: Ditto.
1954         * Scripts/modules/multicommandtool.py:
1955          - Add HelpPrintingOptionParser.format_epilog to replace
1956            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
1957            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
1958          - Make --help only show a list of commands like "svn help" and "git help" do --
1959            previously --help was listing all commands and options.
1960          - Sort list of commands alphabetically.
1961
1962 2009-11-21  Eric Seidel  <eric@webkit.org>
1963
1964         No review.  Fixing a typo from the previous patch for bug 31767.
1965
1966         AbstractQueue.run_bugzilla_tool throws an exception
1967         https://bugs.webkit.org/show_bug.cgi?id=31769
1968
1969         * Scripts/modules/commands/queues.py:
1970
1971 2009-11-21  Eric Seidel  <eric@webkit.org>
1972
1973         Reviewed by Adam Barth.
1974
1975         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
1976         https://bugs.webkit.org/show_bug.cgi?id=31767
1977
1978         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
1979         Since we don't have a good way to test BugzillaTool pieces, I've
1980         left out a test for now.
1981
1982         * Scripts/bugzilla-tool:
1983          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1984         * Scripts/modules/commands/queues.py:
1985          - Use tool.path() instead of __file__.
1986         * Scripts/modules/multicommandtool.py:
1987          - Add a new path() method to MultiComandTool.
1988         * Scripts/modules/multicommandtool_unittest.py:
1989          - Provide a path() method.  Little point in testing this mock implementation.
1990
1991 2009-11-21  Adam Barth  <abarth@webkit.org>
1992
1993         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
1994         WebKitTools.
1995
1996         * Scripts/modules/commands/download.py:
1997
1998 2009-11-21  Adam Barth  <abarth@webkit.org>
1999
2000         Reviewed by Eric Seidel.
2001
2002         Convert check-style to use LandingSequence
2003         https://bugs.webkit.org/show_bug.cgi?id=31763
2004
2005         Instead of manipulating the working copy by hand, we should use the
2006         LandingSequence in CheckStyle.  This will make this code eaiser to
2007         test.
2008
2009         * Scripts/modules/commands/download.py:
2010
2011 2009-11-20  Adam Barth  <abarth@webkit.org>
2012
2013         Reviewed by Eric Seidel.
2014
2015         Unit test query commands
2016         https://bugs.webkit.org/show_bug.cgi?id=31755
2017
2018         These tests are pretty rough, but hopefully they'll grow.
2019
2020         * Scripts/modules/commands/queries_unittest.py: Added.
2021         * Scripts/modules/mock_bugzillatool.py: Added.
2022         * Scripts/run-webkit-unittests:
2023
2024 2009-11-20  Eric Seidel  <eric@webkit.org>
2025
2026         Reviewed by Adam Barth.
2027
2028         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
2029         https://bugs.webkit.org/show_bug.cgi?id=31758
2030
2031         * Scripts/modules/multicommandtool.py:
2032          - Allow passing of explicit commands to MultiCommandTool.__init__
2033         * Scripts/modules/multicommandtool_unittest.py:
2034          - Use new Command.name naming system.
2035          - Test Command auto-discovery.
2036         * Scripts/modules/workqueue.py:
2037          - bug_id no longer exists, use patch['bug_id'] instead.
2038         * Scripts/modules/workqueue_unittest.py:
2039          - WorkQueues require names now.
2040          - should_proceed_with_work_item must return a patch object.
2041
2042 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
2043
2044         Reviewed by Beth Dakin.
2045
2046         WAI-ARIA: add support for aria-owns
2047         https://bugs.webkit.org/show_bug.cgi?id=31702
2048
2049         * DumpRenderTree/AccessibilityUIElement.cpp:
2050         (ariaOwnsElementAtIndexCallback):
2051         (AccessibilityUIElement::getJSClass):
2052         * DumpRenderTree/AccessibilityUIElement.h:
2053         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2054         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2055         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2056         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2057         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2058         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2059
2060 2009-11-20  Eric Seidel  <eric@webkit.org>
2061
2062         Reviewed by Adam Barth.
2063
2064         Fix exception thrown when running the commit-queue.
2065
2066         * Scripts/modules/statusbot.py: patch is optional.
2067         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
2068
2069 2009-11-20  Eric Seidel  <eric@webkit.org>
2070
2071         Reviewed by Adam Barth.
2072
2073         Teach the StatusBot how to support more than just the commit-queue
2074         https://bugs.webkit.org/show_bug.cgi?id=31754
2075
2076         * Scripts/modules/workqueue.py: Another typo.
2077
2078 2009-11-20  Eric Seidel  <eric@webkit.org>
2079
2080         Reviewed by Adam Barth.
2081
2082         Teach the StatusBot how to support more than just the commit-queue
2083         https://bugs.webkit.org/show_bug.cgi?id=31754
2084
2085         * Scripts/modules/commands/queues.py: Fix silly typo.
2086
2087 2009-11-20  Eric Seidel  <eric@webkit.org>
2088
2089         Reviewed by Adam Barth.
2090
2091         Teach the StatusBot how to support more than just the commit-queue
2092         https://bugs.webkit.org/show_bug.cgi?id=31754
2093
2094         * CommitQueueStatus/index.yaml:
2095          - Add indices required for the new queries.
2096         * CommitQueueStatus/queue_status.py:
2097          - Add a patch-status page and move update_status to update-status.
2098          - Only display "commit-queue" status records for the commit-queue.
2099          - Add support for a queue_name property on status records.
2100          - Fix _int_from_request to actually work.
2101         * CommitQueueStatus/update_status.html:
2102          - Add support for a queue_name on status records.
2103          - Remove unused list of bug ids.
2104          * Scripts/modules/commands/queues.py
2105           - Make the queues pass the patch instead of the bug_id to StatusBot.
2106         * Scripts/modules/statusbot.py:
2107          - Support passing the queue_name to the status updates.
2108          - Support fetching patch status with patch_status().
2109         * Scripts/modules/workqueue.py:
2110          - Pass the patch to the StatusBot instead of the bug_id.
2111          - Let WorkQueues have a name.
2112
2113 2009-11-20  Adam Barth  <abarth@webkit.org>
2114
2115         Reviewed by Eric Seidel.
2116
2117         Move bugzilla-tool commands into their own file
2118         https://bugs.webkit.org/show_bug.cgi?id=31752
2119
2120         This will let us write unit tests.
2121
2122         * Scripts/bugzilla-tool:
2123         * Scripts/modules/commands/__init__.py: Added.
2124         * Scripts/modules/commands/download.py: Added.
2125         * Scripts/modules/commands/queries.py: Added.
2126         * Scripts/modules/commands/queues.py: Added.
2127         * Scripts/modules/commands/upload.py: Added.
2128         * Scripts/modules/grammar.py: Added.
2129
2130 2009-11-20  Adam Barth  <abarth@webkit.org>
2131
2132         Reviewed by Eric Seidel.
2133
2134         BuildQueue should check if the tree is currently buildable
2135         https://bugs.webkit.org/show_bug.cgi?id=31744
2136
2137         * Scripts/bugzilla-tool:
2138         * Scripts/modules/landingsequence.py:
2139         * Scripts/modules/webkitlandingscripts.py:
2140
2141 2009-11-20  Adam Barth  <abarth@webkit.org>
2142
2143         Reviewed by Eric Seidel.
2144
2145         Move prepare_clean_working_directory into the LandingSequence
2146         https://bugs.webkit.org/show_bug.cgi?id=31743
2147
2148         * Scripts/bugzilla-tool:
2149         * Scripts/modules/landingsequence.py:
2150
2151 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
2152
2153         Reviewed by Kenneth Rohde Christiansen.
2154
2155         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
2156         https://bugs.webkit.org/show_bug.cgi?id=30460
2157
2158         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
2159
2160         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2161         (pluginInvoke):
2162
2163 2009-11-20  Adam Barth  <abarth@webkit.org>
2164
2165         Reviewed by Eric Seidel.
2166
2167         Pass the port information to the child process
2168         https://bugs.webkit.org/show_bug.cgi?id=31736
2169
2170         We need to do this so the child process knows what to build!
2171
2172         * Scripts/bugzilla-tool:
2173         * Scripts/modules/landingsequence.py:
2174         * Scripts/modules/webkitport.py:
2175         * Scripts/modules/webkitport_unittest.py:
2176
2177 2009-11-20  Adam Barth  <abarth@webkit.org>
2178
2179         Reviewed by Eric Seidel.
2180
2181         Support Qt port in build-queue
2182         https://bugs.webkit.org/show_bug.cgi?id=31733
2183
2184         * Scripts/bugzilla-tool:
2185
2186 2009-11-20  Adam Barth  <abarth@webkit.org>
2187
2188         Reviewed by Eric Seidel.
2189
2190         Implement a build-queue
2191         https://bugs.webkit.org/show_bug.cgi?id=31725
2192
2193         Currently this just builds the first 10 patches in the review queue.
2194         We'll want to do something smarter soon.
2195
2196         * Scripts/bugzilla-tool:
2197
2198 2009-11-20  Adam Barth  <abarth@webkit.org>
2199
2200         Reviewed by Eric Seidel.
2201
2202         Make commit-queue and style-queue show up in help
2203         https://bugs.webkit.org/show_bug.cgi?id=31724
2204
2205         We need to store their names on their class to make these commands
2206         properly register themselves with MultiCommandTool.
2207
2208         * Scripts/bugzilla-tool:
2209
2210 2009-11-20  Adam Barth  <abarth@webkit.org>
2211
2212         Reviewed by Eric Seidel.
2213
2214         Implement bugzilla-tool build-attachment
2215         https://bugs.webkit.org/show_bug.cgi?id=31722
2216
2217         This command builds an attachment from bugzilla.  It leaves the built
2218         patch in the working copy.
2219
2220         * Scripts/bugzilla-tool:
2221         * Scripts/modules/landingsequence.py:
2222         * Scripts/modules/webkitlandingscripts.py:
2223
2224 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
2225
2226         Reviewed by Xan Lopez.
2227
2228         [GTK] DRT release event does not create the state correctly
2229         https://bugs.webkit.org/show_bug.cgi?id=31717
2230
2231         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2232
2233 2009-11-20  Eric Seidel  <eric@webkit.org>
2234
2235         Reviewed by Adam Barth.
2236
2237         MultiCommandTool should find Command objects automatically instead of with a manual list
2238         https://bugs.webkit.org/show_bug.cgi?id=31710
2239
2240         * Scripts/bugzilla-tool:
2241         * Scripts/modules/multicommandtool.py:
2242          - Use some wild python-fu to crawl all the known subclasses of Command.
2243
2244 2009-11-20  Adam Barth  <abarth@webkit.org>
2245
2246         Unreviewed "build" fix.  Added missing import.
2247
2248         * Scripts/bugzilla-tool:
2249
2250 2009-11-20  Adam Barth  <abarth@webkit.org>
2251
2252         Unreviewed "build" fix.  I failed to update LandingSequence.test
2253         properly.
2254
2255         * Scripts/modules/landingsequence.py:
2256
2257 2009-11-20  Adam Barth  <abarth@webkit.org>
2258
2259         Reviewed by Eric Seidel.
2260
2261         Create LandingSequence as the all-sing, all-dance landing class
2262         https://bugs.webkit.org/show_bug.cgi?id=31709
2263
2264         Client can inherit from this class to carefully control exactly which
2265         steps they wish to have happen in the landing sequence.
2266
2267         * Scripts/bugzilla-tool:
2268         * Scripts/modules/landingsequence.py: Added.
2269         * Scripts/modules/webkitlandingscripts.py: Added.
2270
2271 2009-11-19  Adam Barth  <abarth@webkit.org>
2272
2273         Reviewed by Eric Seidel.
2274
2275         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
2276         https://bugs.webkit.org/show_bug.cgi?id=31707
2277
2278         This is to help when we implement build-attachment.
2279
2280         * Scripts/bugzilla-tool:
2281
2282 2009-11-19  Adam Barth  <abarth@webkit.org>
2283
2284         Reviewed by Eric Seidel.
2285
2286         Support Qt port in bugzilla-tool
2287         https://bugs.webkit.org/show_bug.cgi?id=31701
2288
2289         Now we support building with Qt!
2290
2291         * Scripts/bugzilla-tool:
2292         * Scripts/modules/webkitport.py: Added.
2293         * Scripts/modules/webkitport_unittest.py: Added.
2294         * Scripts/run-webkit-unittests:
2295
2296 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
2297
2298         Reviewed by Adam Barth.
2299
2300         Remove inserting stderr into patch in bugzilla-tool
2301         https://bugs.webkit.org/show_bug.cgi?id=29914
2302
2303         Modify SCM python module's run_command function to avoid return of stderr
2304         by default, so stderr won't be inserted into the patches.
2305         Modify the related unit test.
2306
2307         * Scripts/modules/scm.py:
2308         * Scripts/modules/scm_unittest.py:
2309
2310 2009-11-19  Eric Seidel  <eric@webkit.org>
2311
2312         Reviewed by Adam Barth.
2313
2314         bugzilla-tool needs per-command help
2315         https://bugs.webkit.org/show_bug.cgi?id=31697
2316
2317         Added support for "bugzilla-tool help command-name"
2318         and a unit test to make sure it works.
2319
2320         * Scripts/modules/multicommandtool.py:
2321         * Scripts/modules/multicommandtool_unittest.py:
2322
2323 2009-11-19  Eric Seidel  <eric@webkit.org>
2324
2325         Reviewed by Adam Barth.
2326
2327         Move MultiCommandTool and Command into a separate file and add some basic unit tests
2328         https://bugs.webkit.org/show_bug.cgi?id=31695
2329
2330         * Scripts/bugzilla-tool:
2331         * Scripts/modules/multicommandtool.py: Added.
2332         * Scripts/modules/multicommandtool_unittest.py: Added.
2333         * Scripts/run-webkit-unittests:
2334
2335 2009-11-19  Eric Seidel  <eric@webkit.org>
2336
2337         No review, just adding a FIXME.
2338
2339         Split out command parsing and help printing from BugzillaTool
2340         https://bugs.webkit.org/show_bug.cgi?id=31688
2341
2342         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
2343
2344 2009-11-19  Eric Seidel  <eric@webkit.org>
2345
2346         Reviewed by Adam Barth.
2347
2348         Split out command parsing and help printing from BugzillaTool
2349         https://bugs.webkit.org/show_bug.cgi?id=31688
2350
2351         * Scripts/bugzilla-tool:
2352          - Add new MultiCommandTool class to contain option parsing and help printing logic.
2353          - Rename private methods to use _ pattern.
2354          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
2355          - 
2356
2357 2009-11-19  Eric Seidel  <eric@webkit.org>
2358
2359         Reviewed by Adam Barth.
2360
2361         Re-factor help printing to use modern python idioms
2362         https://bugs.webkit.org/show_bug.cgi?id=31685
2363
2364         * Scripts/bugzilla-tool:
2365
2366 2009-11-19  Eric Seidel  <eric@webkit.org>
2367
2368         Reviewed by Darin Adler.
2369
2370         commit-queue empty queue logs twice
2371         https://bugs.webkit.org/show_bug.cgi?id=31679
2372
2373         * Scripts/bugzilla-tool:
2374
2375 2009-11-19  Eric Seidel  <eric@webkit.org>
2376
2377         Reviewed by Darin Adler.
2378
2379         bugzilla-tool's reviewer/committer rejection message should be clearer
2380         https://bugs.webkit.org/show_bug.cgi?id=31126
2381
2382         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
2383
2384         * Scripts/modules/bugzilla.py:
2385
2386 2009-11-19  Eric Z. Ayers  <zundel@google.com>
2387
2388         Reviewed by Pavel Feldman.
2389
2390         Forces a WM_PAINT event on calling layoutTestController.display()
2391         in order to enable the timeline-paint.html test on Windows.
2392         ::UpdateWindow() does not force an event becaue the window is 
2393         not visible.
2394
2395         https://bugs.webkit.org/show_bug.cgi?id=31402
2396
2397         * DumpRenderTree/win/DumpRenderTree.cpp:
2398         (displayWebView):
2399
2400 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
2401
2402         No review needed.
2403
2404         Added myself to committers list.
2405
2406         * Scripts/modules/committers.py:
2407
2408 2009-11-19  Adam Barth  <abarth@webkit.org>
2409
2410         Reviewed by Eric Seidel.
2411
2412         Bugzilla-tool command classes should match command names
2413         https://bugs.webkit.org/show_bug.cgi?id=31666
2414
2415         I renamed all the commands except CommitMessageForCurrentDiff because
2416         the new name would conflict with an existing class.
2417
2418         * Scripts/bugzilla-tool:
2419
2420 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
2421
2422         Reviewed by Gustavo Noronha Silva.
2423
2424         Web Inspector: Implement "show inspector" in WebKit GTK
2425         API and enable console tests.
2426
2427         https://bugs.webkit.org/show_bug.cgi?id=31669
2428
2429         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2430         (LayoutTestController::showWebInspector):
2431
2432 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2433
2434         Reviewed by Simon Hausmann.
2435
2436         Minor refactoring + more documentation.
2437
2438         * DumpRenderTree/qt/DumpRenderTree.cpp:
2439         (WebCore::clearHistory):
2440         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2441
2442 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
2443
2444         Reviewed by Eric Seidel.
2445
2446         Ignore websocket tests when --no-http is specified.
2447         https://bugs.webkit.org/show_bug.cgi?id=31662
2448
2449         * Scripts/run-webkit-tests:
2450
2451 2009-11-18  Adam Barth  <abarth@webkit.org>
2452
2453         Reviewed by Eric Seidel.
2454
2455         Normalize ' and " in bugzilla-tool
2456         https://bugs.webkit.org/show_bug.cgi?id=31655
2457
2458         We decided " is better than ' and we should be consistent.
2459
2460         * Scripts/bugzilla-tool:
2461
2462 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2463
2464         Reviewed by Kenneth Rohde Christiansen.
2465
2466         [Qt] Remove support for Qt v4.3 or older versions
2467         https://bugs.webkit.org/show_bug.cgi?id=29469
2468
2469         * DumpRenderTree/qt/DumpRenderTree.pro:
2470         * DumpRenderTree/qt/ImageDiff.pro:
2471
2472 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
2473
2474         Reviewed by Eric Seidel.
2475
2476         GitTest.test_create_binary_patch fails if /tmp is symlink
2477         https://bugs.webkit.org/show_bug.cgi?id=31536
2478
2479         * Scripts/modules/scm_unittest.py:
2480
2481 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
2482
2483         Reviewed by Darin Adler.
2484
2485         Configuration for Chromium Build Slaves.
2486
2487         https://bugs.webkit.org/show_bug.cgi?id=31442
2488
2489         * BuildSlaveSupport/build.webkit.org-config/config.json:
2490         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2491
2492 2009-11-18  Eric Seidel  <eric@webkit.org>
2493
2494         Reviewed by Darin Adler.
2495
2496         workqueue.py results in totally broken commit-queue UI
2497         https://bugs.webkit.org/show_bug.cgi?id=31645
2498
2499         * Scripts/bugzilla-tool:
2500          - Remove unneeded use of PatchCollection.
2501          - Grab a new copy of the cq'd patches every run of the queue.
2502
2503 2009-11-18  Sam Weinig  <sam@webkit.org>
2504
2505         Reviewed by Anders Carlsson.
2506
2507         Make the Mac Geolocation API async.
2508
2509         Update DRT to use the new async Mac Geolocation API.
2510
2511         * DumpRenderTree/mac/UIDelegate.mm:
2512         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2513
2514 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2515
2516         Reviewed by Kenneth Rohde Christiansen.
2517
2518         Add and option to toggle HTML5 datalist support to build-webkit
2519         https://bugs.webkit.org/show_bug.cgi?id=31599
2520
2521         * Scripts/build-webkit:
2522
2523 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
2524
2525         Reviewed by Kevin Ollivier.
2526
2527         Enable wx plugin support using the Windows implementation as a base.
2528         
2529         https://bugs.webkit.org/show_bug.cgi?id=31636
2530
2531         * wx/build/settings.py:
2532
2533 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2534
2535         Reviewed by Simon Hausmann.
2536
2537         Change the initialization order so that the controllers
2538         will be created before exporting them to the JS DOM window.
2539
2540         * DumpRenderTree/qt/DumpRenderTree.cpp:
2541         (WebCore::DumpRenderTree::DumpRenderTree):
2542
2543 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2544
2545         Reviewed by Simon Hausmann.
2546
2547         Fix a code copy and paste error. m_page should be page.
2548
2549         * DumpRenderTree/qt/DumpRenderTree.cpp:
2550         (WebCore::DumpRenderTree::createWindow):
2551
2552 2009-11-17  Mark Rowe  <mrowe@apple.com>
2553
2554         Reviewed by Alexey Proskuryakov.
2555
2556         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
2557
2558         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
2559         This prevents symlinks from confusing the descendant check.
2560
2561 2009-11-17  Mark Rowe  <mrowe@apple.com>
2562
2563         Reviewed by Alexey Proskuryakov.
2564
2565         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
2566
2567         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
2568         server to be up rather than having run-webkit-tests abort immediately.
2569
2570         * Scripts/run-webkit-tests:
2571
2572 2009-11-17  Eric Seidel  <eric@webkit.org>
2573
2574         Reviewed by Darin Adler.
2575
2576         commit-queue is failing to set reviewer in ChangeLogs
2577         https://bugs.webkit.org/show_bug.cgi?id=31592
2578
2579         * Scripts/bugzilla-tool: Clarify the "applying" log message.
2580         * Scripts/modules/bugzilla.py:
2581          - Add a new _validate_committer_and_reviewer function as a
2582            temporary solution until we can make a real Attachment object
2583            which knows how to fill in its committer/reviewer fields automatically.
2584
2585 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2586
2587         Unreviewed buildbot fix.
2588
2589         Revert part of earlier patch and add comment, as it
2590         was causing timeouts on the buildbot.
2591
2592         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2593         (LayoutTestController::notifyDone):
2594
2595 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2596
2597         Reviewed by Oliver Hunt.
2598
2599         Make the timeout 15 sec as for the other DRT's and make
2600         it print out the same output when a test timeout.
2601
2602         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2603         (LayoutTestController::waitUntilDone):
2604         (LayoutTestController::notifyDone):
2605         (LayoutTestController::timerEvent):
2606
2607 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
2608
2609         Reviewed by Timothy Hatcher.
2610
2611         Fixed typos in comments.
2612
2613         * Scripts/modules/committers.py:
2614
2615 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2616
2617         Reviewed by Timothy Hatcher.
2618
2619         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2620         - Updated DRT to show/close inspector for all tests under /inspector
2621         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2622           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2623         - Removed reload on each inspector test
2624         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2625         inspector for those.
2626         - Reimplemented timeline tests in order to get rid of reload there.
2627         - Moved tests that don't require harness into the fast group.
2628
2629         https://bugs.webkit.org/show_bug.cgi?id=31472
2630
2631         * DumpRenderTree/LayoutTestController.cpp:
2632         (setTimelineProfilingEnabledCallback):
2633         (closeWebInspectorCallback):
2634         (LayoutTestController::staticFunctions):
2635         * DumpRenderTree/LayoutTestController.h:
2636         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2637         (shouldOpenWebInspector):
2638         (runTest):
2639         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2640         (LayoutTestController::setTimelineProfilingEnabled):
2641         * DumpRenderTree/mac/DumpRenderTree.mm:
2642         (shouldOpenWebInspector):
2643         (runTest):
2644         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2645         (LayoutTestController::setTimelineProfilingEnabled):
2646         * DumpRenderTree/win/DumpRenderTree.cpp:
2647         (shouldOpenWebInspector):
2648         (runTest):
2649         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2650         (LayoutTestController::setTimelineProfilingEnabled):
2651
2652 2009-11-17  Oliver Hunt  <oliver@apple.com>
2653
2654         Reviewed by Maciej Stachowiak.
2655
2656         Incorrect use of JavaScriptCore API in DumpRenderTree
2657         https://bugs.webkit.org/show_bug.cgi?id=31577
2658
2659         Return undefined rather than a literal null.
2660
2661         * DumpRenderTree/AccessibilityUIElement.cpp:
2662         (setSelectedTextRangeCallback):
2663         (incrementCallback):
2664         (decrementCallback):
2665         (showMenuCallback):
2666
2667 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2668
2669         Reviewed by Beth Dakin.
2670
2671         AX: aria-labelledby duplicates some of its WAI-ARIA label
2672         https://bugs.webkit.org/show_bug.cgi?id=31565
2673
2674         * DumpRenderTree/AccessibilityUIElement.cpp:
2675         (titleUIElementCallback):
2676         (getIsValidCallback):
2677         (AccessibilityUIElement::getJSClass):
2678
2679 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2680
2681         Reviewed by Simon Hausmann.
2682
2683         r50942 broke output from created windows. Make the
2684         m_enableTextOutput a member of the DRT and not the
2685         WebPage.
2686
2687         * DumpRenderTree/qt/DumpRenderTree.cpp:
2688         (WebCore::WebPage::WebPage):
2689         (WebCore::WebPage::javaScriptAlert):
2690         (WebCore::WebPage::javaScriptConsoleMessage):
2691         (WebCore::WebPage::javaScriptConfirm):
2692         (WebCore::WebPage::javaScriptPrompt):
2693         (WebCore::WebPage::acceptNavigationRequest):
2694         (WebCore::DumpRenderTree::DumpRenderTree):
2695         (WebCore::DumpRenderTree::open):
2696         (WebCore::DumpRenderTree::createWindow):
2697         * DumpRenderTree/qt/DumpRenderTree.h:
2698         (WebCore::DumpRenderTree::setTextOutputEnabled):
2699         (WebCore::DumpRenderTree::isTextOutputEnabled):
2700         (WebCore::WebPage::shouldInterruptJavaScript):
2701         (WebCore::WebPage::isTextOutputEnabled):
2702         (WebCore::WebPage::setViewGeometry):
2703
2704 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2705
2706         Reviewed by Gustavo Noronha Silva.
2707
2708         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2709         as the implementation is being used by at least Qt and Gtk+.
2710
2711         Update buildsystems as well.
2712
2713         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2714         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2715         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2716         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2717         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2718         * GNUmakefile.am:
2719
2720 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2721
2722         Reviewed by Alexey Proskuryakov.
2723
2724         Disable wss until all platforms support pyOpenSSL
2725
2726         https://bugs.webkit.org/show_bug.cgi?id=31479
2727
2728         * Scripts/run-webkit-tests:
2729
2730 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2731
2732         Reviewed by Kenneth Christiansen.
2733
2734         [Qt] Implement load error pages support for Qt's DRT.
2735         https://bugs.webkit.org/show_bug.cgi?id=31509
2736
2737         For now, it will not be a default feature, and layout tests
2738         that want to make use of this have to explicitily call
2739         'handleErrorPages();' for the test source.
2740
2741         Any of the other DumpRenderTree's (mac, win and gtk)
2742         support handling error pages. Qt's will be the first.
2743
2744         * DumpRenderTree/qt/DumpRenderTree.cpp:
2745         (WebCore::WebPage::supportsExtension):
2746         (WebCore::WebPage::extension):
2747         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2748         (LayoutTestController::reset):
2749         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2750         (LayoutTestController::shouldHandleErrorPages):
2751         (LayoutTestController::handleErrorPages):
2752
2753 2009-11-16  Eric Seidel  <eric@webkit.org>
2754
2755         Reviewed by Adam Barth.
2756
2757         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2758         https://bugs.webkit.org/show_bug.cgi?id=31549
2759
2760         Renamed --commit-queue to --non-interactive in most places
2761         and remove the code in land-patches which is no longer needed.
2762
2763         * Scripts/bugzilla-tool:
2764
2765 2009-11-16  Eric Seidel  <eric@webkit.org>
2766
2767         Reviewed by Adam Barth.
2768
2769         The commit-queue should use land-attachment
2770         https://bugs.webkit.org/show_bug.cgi?id=31548
2771
2772         * Scripts/bugzilla-tool:
2773
2774 2009-11-16  Adam Barth  <abarth@webkit.org>
2775
2776         Reviewed by Eric Seidel.
2777
2778         Convert CommitQueue over to PatchCollection
2779         https://bugs.webkit.org/show_bug.cgi?id=31547
2780
2781         Also fixes a bug in workqueue and adds a test!
2782
2783         * Scripts/bugzilla-tool:
2784         * Scripts/modules/workqueue.py:
2785         * Scripts/modules/workqueue_unittest.py:
2786
2787 2009-11-16  Adam Barth  <abarth@webkit.org>
2788
2789         Reviewed by Eric Seidel.
2790
2791         Move StyleQueue over to using PatchCollection
2792         https://bugs.webkit.org/show_bug.cgi?id=31544
2793
2794         That's what the class it's for.
2795
2796         * Scripts/bugzilla-tool:
2797         * Scripts/modules/patchcollection.py:
2798         * Scripts/modules/patchcollection_unittest.py:
2799
2800 2009-11-16  Eric Seidel  <eric@webkit.org>
2801
2802         Reviewed by Adam Barth.
2803
2804         bugzilla-tool needs a land-attachment command
2805         https://bugs.webkit.org/show_bug.cgi?id=31546
2806
2807         * Scripts/bugzilla-tool:
2808          - Move all the logic into AbstractLandingCommand and
2809            add a new LandAttachment command subclass.
2810          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2811
2812 2009-11-16  Eric Seidel  <eric@webkit.org>
2813
2814         Reviewed by Adam Barth.
2815
2816         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2817         https://bugs.webkit.org/show_bug.cgi?id=31543
2818
2819         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2820
2821         * Scripts/bugzilla-tool:
2822
2823 2009-11-16  Eric Seidel  <eric@webkit.org>
2824
2825         Reviewed by Adam Barth.
2826
2827         Disable the style queue from posting to the commit queue status page.
2828
2829         * Scripts/bugzilla-tool:
2830
2831 2009-11-16  Adam Barth  <abarth@webkit.org>
2832
2833         Reviewed by Eric Seidel.
2834
2835         Implement PatchCollection
2836         https://bugs.webkit.org/show_bug.cgi?id=31541
2837
2838         This class holds a set of patches and lets clients iterate through
2839         them.  Optionally, clients can install a filter.
2840
2841         * Scripts/modules/patchcollection.py: Added.
2842         * Scripts/modules/patchcollection_unittest.py: Added.
2843         * Scripts/run-webkit-unittests:
2844
2845 2009-11-16  Eric Seidel  <eric@webkit.org>
2846
2847         Reviewed by Adam Barth.
2848
2849         bugzilla-tool land-patches will close bugs with patches r=?
2850         https://bugs.webkit.org/show_bug.cgi?id=28230
2851
2852         The commit-queue shouldn't close patches with outstanding reviews on them,
2853         even if many reviewers seem to be against multi-patch bugs.
2854
2855         * Scripts/bugzilla-tool:
2856
2857 2009-11-16  Eric Seidel  <eric@webkit.org>
2858
2859         Reviewed by Adam Barth.
2860
2861         bugzilla-tool check-style should work with attachment ids instead of bug ids
2862         https://bugs.webkit.org/show_bug.cgi?id=31540
2863
2864         * Scripts/bugzilla-tool:
2865
2866 2009-11-16  Eric Seidel  <eric@webkit.org>
2867
2868         Reviewed by Adam Barth.
2869
2870         WorkQueue is the only place that should know about special exit codes
2871         https://bugs.webkit.org/show_bug.cgi?id=31534
2872
2873         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2874         and add tests for handling exit codes.
2875         I also cleaned up workqueue_unittest.py more.
2876
2877         * Scripts/bugzilla-tool:
2878         * Scripts/modules/workqueue.py:
2879         * Scripts/modules/workqueue_unittest.py:
2880
2881 2009-11-16  Eric Seidel  <eric@webkit.org>
2882
2883         Reviewed by Adam Barth.
2884
2885         Re-factor workqueue_unittest to allow for more than one test.
2886         https://bugs.webkit.org/show_bug.cgi?id=31535
2887
2888         * Scripts/modules/workqueue_unittest.py:
2889
2890 2009-11-16  Eric Seidel  <eric@webkit.org>
2891
2892         Reviewed by Adam Barth.
2893
2894         land-patches needs to be re-factored into smaller chunks
2895         https://bugs.webkit.org/show_bug.cgi?id=31532
2896
2897         * Scripts/bugzilla-tool: fix a couple obvious typos.
2898
2899 2009-11-16  Eric Seidel  <eric@webkit.org>
2900
2901         Reviewed by Adam Barth.
2902
2903         land-patches needs to be re-factored into smaller chunks
2904         https://bugs.webkit.org/show_bug.cgi?id=31532
2905
2906         The next patch will move these methods into WebKitLandingScripts.
2907
2908         * Scripts/bugzilla-tool:
2909          - Split out _land_patch and _close_bug_if_no_active_patches.
2910
2911 2009-11-16  Adam Barth  <abarth@webkit.org>
2912
2913         Reviewed by Eric Seidel.
2914
2915         Fix silly copy-and-paste code.  I am a terrible coder.
2916
2917         * Scripts/modules/bugzilla.py:
2918
2919 2009-11-16  Adam Barth  <abarth@webkit.org>
2920
2921         Reviewed by Eric Seidel.
2922
2923         Implement a StyleQueue
2924         https://bugs.webkit.org/show_bug.cgi?id=31537
2925
2926         The first iteration of the style queue only produces output locally.
2927         There is also a limit of 10 patches because it's not that useful to
2928         iterate through the entire review queue at this point.  We can remove
2929         the limit later.
2930
2931         * Scripts/bugzilla-tool:
2932         * Scripts/modules/bugzilla.py:
2933
2934 2009-11-16  Adam Barth  <abarth@webkit.org>
2935
2936         Reviewed by Eric Seidel.
2937
2938         Unit test WorkQueue
2939         https://bugs.webkit.org/show_bug.cgi?id=31531
2940
2941         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
2942
2943         * Scripts/bugzilla-tool:
2944         * Scripts/modules/statusbot.py:
2945         * Scripts/modules/workqueue.py:
2946         * Scripts/modules/workqueue_unittest.py: Added.
2947         * Scripts/run-webkit-unittests:
2948
2949 2009-11-16  Eric Seidel  <eric@webkit.org>
2950
2951         Reviewed by Adam Barth.
2952
2953         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
2954         https://bugs.webkit.org/show_bug.cgi?id=31530
2955
2956         * Scripts/bugzilla-tool:
2957
2958 2009-11-16  Eric Seidel  <eric@webkit.org>
2959
2960         Reviewed by Adam Barth.
2961
2962         bugzilla-tool needs apply-attachment
2963         https://bugs.webkit.org/show_bug.cgi?id=31528
2964
2965         * Scripts/bugzilla-tool:
2966          - Add ApplyAttachment command.
2967          - Abstract applying code into WebKitApplyingScripts.
2968          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
2969         * Scripts/modules/bugzilla.py:
2970          - Add fetch_attachment and bug_id_for_attachment_id.
2971         * Scripts/modules/bugzilla_unittest.py:
2972          - Add test for new parsing.
2973          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
2974
2975 2009-11-16  Eric Seidel  <eric@webkit.org>
2976
2977         Reviewed by Adam Barth.
2978
2979         Document check-style's use of force_clean.
2980
2981         * Scripts/bugzilla-tool:
2982         * Scripts/modules/scm.py:
2983
2984 2009-11-16  Adam Barth  <abarth@webkit.org>
2985
2986         Reviewed by Eric Seidel.
2987
2988         Move WorkQueue to its own file
2989         https://bugs.webkit.org/show_bug.cgi?id=31529
2990
2991         WorkQueue and WorkQueueDelegate are separate concerns from
2992         bugzilla-tool.  Also added a missing include to logging.py.
2993
2994         * Scripts/bugzilla-tool:
2995         * Scripts/modules/logging.py:
2996         * Scripts/modules/workqueue.py:
2997
2998 2009-11-16  Adam Barth  <abarth@webkit.org>
2999
3000         Reviewed by Eric Seidel.
3001
3002         Move OutputTee to logging.py.
3003
3004         * Scripts/bugzilla-tool:
3005         * Scripts/modules/logging.py:
3006
3007 2009-11-15  Adam Barth  <abarth@webkit.org>
3008
3009         Reviewed by Eric Seidel.
3010
3011         Refactor bugzilla-tool to allow for multiple queues
3012         https://bugs.webkit.org/show_bug.cgi?id=31513
3013
3014         Divide the commit queue class into three class to make creating
3015         additional queues easier.
3016
3017         * Scripts/bugzilla-tool:
3018
3019 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3020
3021         Reviewed by Eric Seidel.
3022
3023         svn-apply may not handle git patches created by bugzilla-tool
3024         https://bugs.webkit.org/show_bug.cgi?id=31457
3025
3026         * Scripts/modules/scm.py:
3027         * Scripts/modules/scm_unittest.py:
3028
3029 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3030
3031         Reviewed by Eric Seidel.
3032
3033         bugzilla-tool should post git binary diff
3034         https://bugs.webkit.org/show_bug.cgi?id=31458
3035
3036         Add --binary option to Git.create_patch.
3037
3038         * Scripts/modules/scm.py:
3039         * Scripts/modules/scm_unittest.py:
3040
3041 2009-11-15  Adam Barth  <abarth@webkit.org>
3042
3043         Reviewed by Darin Adler.
3044
3045         Add bugzilla-tool check-style
3046         https://bugs.webkit.org/show_bug.cgi?id=31515
3047
3048         * Scripts/bugzilla-tool:
3049         * Scripts/modules/bugzilla.py:
3050
3051 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3052
3053         Reviewed by Simon Hausmann.
3054
3055         Make the Qt Linux only --valgrind feature, suppress errors
3056         defined in the SuppressedValgrindErrors file.
3057
3058         * Scripts/run-webkit-tests:
3059
3060 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3061
3062         Reviewed by Simon Hausmann.
3063
3064         Set the locale to C and not to the current one in use on the system.
3065
3066         * DumpRenderTree/qt/DumpRenderTree.cpp:
3067         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3068
3069 2009-11-13  Adam Roben  <aroben@apple.com>
3070
3071         Add support for
3072         http/tests/security/isolatedWorld/didClearWindowObject.html
3073
3074         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
3075         window objects in isolated worlds are cleared
3076
3077         Reviewed by Dave Hyatt.
3078
3079         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
3080
3081         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3082         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3083         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
3084         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
3085         Added. Sets a __worldID property on the global object whose value is
3086         the ID of this world.
3087         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
3088         Respond to this new delegate callback by calling through to one of the
3089         above new methods.
3090         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3091         (worldMap): Added. Returns a HashMap containing all the worlds we've
3092         created.
3093         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
3094         haven't kept track of this world.
3095         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
3096         instead of declaring our own.
3097
3098         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
3099
3100         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3101         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
3102         didClearWindowObjectForFrameInStandardWorld.
3103         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
3104         Respond to this new delegate callback by calling through to one of the
3105         below new methods.
3106         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
3107         Added. Sets a __worldID property on the gobal object whose value is
3108         the ID of this world.
3109         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
3110         Added. Moved code here from didClearWindowObject.
3111
3112         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
3113         didClearWindowObjectForFrame* functions.
3114
3115         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3116         (worldMap): Added. Returns a HashMap containing all the worlds we've
3117         created.
3118         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
3119         haven't kept track of this world.
3120         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
3121         instead of declaring our own.
3122
3123 2009-11-13  Adam Roben  <aroben@apple.com>
3124
3125         Finish replacing worldIDs with world objects
3126
3127         The only remaining use of worldIDs was in a method only used by DRT
3128         for the isolated worlds tests.
3129
3130         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
3131
3132         Reviewed by Mark Rowe.
3133
3134         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3135         (LayoutTestController::evaluateScriptInIsolatedWorld):
3136         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3137         (LayoutTestController::evaluateScriptInIsolatedWorld):
3138         Updated for changes to WebFrame. Now holds the map of worldID -> world
3139         at this level instead of making WebKit do it.
3140
3141 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3142
3143         Reviewed by Simon Hausmann.
3144
3145         [Qt] Ensure the DRT does not output anything until first test is run
3146
3147         * DumpRenderTree/qt/DumpRenderTree.cpp:
3148         * DumpRenderTree/qt/DumpRenderTree.h:
3149
3150 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3151
3152         Reviewed by Tor Arne Vestbø.
3153
3154         Clear the undo stack in before each new test run.
3155
3156         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
3157
3158         * DumpRenderTree/qt/DumpRenderTree.cpp:
3159         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3160
3161 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3162
3163         Reviewed by Kenneth Rohde Christiansen.
3164
3165         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
3166
3167         * DumpRenderTree/qt/DumpRenderTree.cpp:
3168         (WebCore::WebPage::resetSettings):
3169         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3170         (LayoutTestController::overridePreference):
3171
3172 2009-11-13  Eric Seidel  <eric@webkit.org>
3173
3174         Reviewed by Adam Barth.
3175
3176         Update committers.py based on svn records
3177         https://bugs.webkit.org/show_bug.cgi?id=31366
3178
3179         This list was generated using validate-committer-lists from
3180         https://bugs.webkit.org/show_bug.cgi?id=30970
3181         and makes committers.py current for committers who have
3182         committed in the last 3 years.
3183
3184         * Scripts/modules/committers.py:
3185
3186 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
3187
3188         Reviewed by Adam Barth.
3189
3190         The document-open.html test was flaky at times. The test invokes the layout test plugin
3191         which in its destroy stream handler opens a new document. This basically tears down the
3192         stream and the associated plugin instance. The pluginLog function in the layout test
3193         plugin attempts to retrieve the window script object on a torn down plugin instance
3194         which crashed consistently on windows in the debugger. The functions which issue
3195         these logs already have a valid window script object. We now have variants of the pluginLog
3196         function which take in a window script object with and without variable arguments. 
3197
3198         https://bugs.webkit.org/show_bug.cgi?id=31067
3199
3200         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3201         (pluginLogWithWindowObject):
3202         (pluginLogWithWindowObjectVariableArgs):
3203         (pluginLog):
3204         (notifyTestCompletion):
3205         (testDocumentOpen):
3206         (testWindowOpen):
3207
3208 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3209
3210         Reviewed by Gustavo Noronha Silva.
3211
3212         https://bugs.webkit.org/show_bug.cgi?id=30997
3213         [Gtk] Implemment AtkDocument
3214
3215         Added testing support.
3216
3217         * DumpRenderTree/AccessibilityUIElement.cpp:
3218         * DumpRenderTree/AccessibilityUIElement.h:
3219         (getDocumentEncodingCallback):
3220         (getDocumentURICallback):
3221         (AccessibilityUIElement::getJSClass):
3222         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3223         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3224         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3225         (AccessibilityUIElement::documentEncoding):
3226         (AccessibilityUIElement::documentURI):
3227
3228 2009-11-12  Adam Roben  <aroben@apple.com>
3229
3230         Replace worldIDs with world objects
3231
3232         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
3233         user scripts/stylesheets and isolated worlds
3234
3235         Reviewed by Sam Weinig.
3236
3237         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3238         (LayoutTestController::addUserScript):
3239         (LayoutTestController::addUserStyleSheet):
3240         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3241         (LayoutTestController::addUserScript):
3242         (LayoutTestController::addUserStyleSheet):
3243         Changed these functions to create a new WebJSWorld each time they're
3244         called and to pass that world to WebKit.
3245
3246 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
3247
3248         Reviewed by Oliver Hunt.
3249
3250         need to implement aria tree roles
3251         https://bugs.webkit.org/show_bug.cgi?id=31284
3252
3253         * DumpRenderTree/AccessibilityUIElement.cpp:
3254         (disclosedRowAtIndexCallback):
3255         (selectedRowAtIndexCallback):
3256         (isEqualCallback):
3257         (isAttributeSettableCallback):
3258         (isActionSupportedCallback):
3259         (disclosedByRowCallback):
3260         (hierarchicalLevelCallback):
3261         (AccessibilityUIElement::getJSClass):
3262         * DumpRenderTree/AccessibilityUIElement.h:
3263         (AccessibilityUIElement::isEqual):
3264         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3265         (AccessibilityUIElement::hierarchicalLevel):
3266         (AccessibilityUIElement::disclosedRowAtIndex):
3267         (AccessibilityUIElement::selectedRowAtIndex):
3268         (AccessibilityUIElement::disclosedByRow):
3269         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3270         (AccessibilityUIElement::getChildAtIndex):
3271         (AccessibilityUIElement::disclosedRowAtIndex):
3272         (AccessibilityUIElement::selectedRowAtIndex):
3273         (AccessibilityUIElement::titleUIElement):
3274         (AccessibilityUIElement::parentElement):
3275         (AccessibilityUIElement::disclosedByRow):
3276         (AccessibilityUIElement::hierarchicalLevel):
3277         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3278         (AccessibilityUIElement::hierarchicalLevel):
3279         (AccessibilityUIElement::disclosedRowAtIndex):
3280         (AccessibilityUIElement::selectedRowAtIndex):
3281         (AccessibilityUIElement::disclosedByRow):
3282
3283 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
3284
3285         Reviewed by Darin Adler.
3286
3287         svn-apply can not handle git binary diffs
3288         https://bugs.webkit.org/show_bug.cgi?id=26830
3289
3290         Support "literal" type git binary diffs.
3291
3292         * Scripts/VCSUtils.pm:
3293         * Scripts/modules/scm_unittest.py:
3294         * Scripts/svn-apply:
3295
3296 2009-11-11  Dmitry Titov  <dimich@chromium.org>
3297
3298         Not reviewed, removing duplicate entry for myself in committers.py.
3299
3300         * Scripts/modules/committers.py:
3301
3302 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
3303
3304         Reviewed by Darin Adler and Mark Rowe.
3305
3306         https://bugs.webkit.org/show_bug.cgi?id=31200
3307         Tests in http/tests/security/mixedContent start to fail when new tests are added
3308
3309         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
3310
3311 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3312
3313         Reviewed by Jan Alonzo.
3314
3315         Create, and display a window for the inspector, for inspector
3316         tests.
3317
3318         Need to also show/hide the inspector window to avoid having
3319         problems with code assuming it is realized
3320         https://bugs.webkit.org/show_bug.cgi?id=31347
3321
3322         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3323         (webInspectorShowWindow):
3324         (webInspectorCloseWindow):
3325         (webInspectorInspectWebView):
3326         (createWebView):
3327
3328 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3329
3330         Unreviewed Qt buildbot fix.
3331
3332         My previous fix was wrong, so revert that change and fix it by
3333         returning when the document of the frame has no document element.
3334         Idea is borrowed from mac and win DRT.
3335
3336         * DumpRenderTree/qt/DumpRenderTree.cpp:
3337         (WebCore::DumpRenderTree::dumpFramesAsText):
3338
3339 2009-11-11  Eric Seidel  <eric@webkit.org>
3340
3341         Reviewed byg Kenneth Rohde Christiansen.
3342
3343         Update Kenneth's committer record to include the email he
3344         uses on lists.webkit.org.
3345
3346         * Scripts/modules/committers.py:
3347
3348 2009-11-11  Eric Seidel  <eric@webkit.org>
3349
3350         Reviewed by Gustavo Noronha Silva.
3351
3352         Several committers use separate email addresses for bugzilla and svn.webkit.org
3353         https://bugs.webkit.org/show_bug.cgi?id=31364
3354
3355         Update records for existing committers to include email addresses
3356         used in svn.webkit.org and lists.webkit.org.
3357         Most committers use the same email address in all 3 places, but some use
3358         separate addresses.  committers.py needs record of each of these addresses.
3359
3360         * Scripts/modules/committers.py:
3361
3362 2009-11-11  Eric Seidel  <eric@webkit.org>
3363
3364         No review, adding second email address for an existing committer.
3365
3366         Add Yong Li's second bugzilla account to his committer record.
3367         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
3368
3369         * Scripts/modules/committers.py:
3370
3371 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3372
3373         Reviewed by Simon Hausmann.
3374
3375         If the frame has no innerText don't append it, and
3376         do not add a newline which breaks some cross platform
3377         results.
3378
3379         * DumpRenderTree/qt/DumpRenderTree.cpp:
3380         (WebCore::DumpRenderTree::dumpFramesAsText):
3381
3382 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3383
3384         Reviewed by Simon Hausmann.
3385
3386         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
3387
3388         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
3389         (webkit_test_plugin_new_instance):
3390         (webkit_test_plugin_destroy_instance):
3391         (webkit_test_plugin_destroy_stream):
3392
3393 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3394
3395         Reviewed by Mark Rowe.
3396
3397         Implement the functionality needed by plugins/window-open.html
3398
3399         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
3400         (webkit_test_plugin_new_instance):
3401         (webkit_test_plugin_set_window):
3402
3403 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3404
3405         Reviewed by Simon Hausmann.
3406
3407         [Qt] Force -graphicssystem raster and -style windows when running DRT
3408
3409         * DumpRenderTree/qt/main.cpp:
3410         * Scripts/run-webkit-tests:
3411
3412 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3413
3414         Reviewed by Simon Hausmann.
3415
3416         Compute correct library paths for Qt
3417
3418         * Scripts/webkitdirs.pm:
3419
3420 2009-11-10  Mark Rowe  <mrowe@apple.com>
3421
3422         Reviewed by Sam Weinig.
3423
3424         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
3425
3426         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
3427         about the validity of the self-signed certificates used in the regression tests.  We would then add the
3428         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
3429         that had enabled frame load delegate logging this would result in extra log messages being generated,
3430         causing the test to fail.
3431
3432         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
3433         tests.
3434
3435         * DumpRenderTree/mac/DumpRenderTree.mm:
3436         (dumpRenderTree):
3437         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3438         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3439
3440 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3441
3442         Reviewed by Kenneth Rohde Christiansen.
3443
3444         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
3445
3446         * DumpRenderTree/qt/DumpRenderTree.cpp:
3447         (WebCore::DumpRenderTree::DumpRenderTree):
3448
3449 2009-11-10  Philippe Normand  <pnormand@igalia.com>
3450
3451         Reviewed by Jan Alonzo.
3452
3453         [GTK] Remove WebSocket configuration from WebKitWebSettings
3454         https://bugs.webkit.org/show_bug.cgi?id=31244
3455
3456         Follow-up of r50724. Don't set the enable-web-socket property
3457         anymore.
3458
3459         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3460         (resetDefaultsToConsistentValues):
3461
3462 2009-11-10  Oliver Hunt  <oliver@apple.com>
3463
3464         Reviewed by Maciej Stachowiak.
3465
3466         Rename 3D Canvas related classes to use WebGL prefix
3467         https://bugs.webkit.org/show_bug.cgi?id=29095
3468
3469         Checkin new version of do-webcore-rename used to do the WebGL type rename,
3470         and upate webkitdirs script to new method of testing for WebGL.
3471
3472         * Scripts/do-webcore-rename:
3473         * Scripts/webkitdirs.pm:
3474
3475 2009-11-09  Oliver Hunt  <oliver@apple.com>
3476
3477         Reviewed by Geoff Garen.
3478
3479         Make do-webcore-rename work with git.
3480
3481         * Scripts/do-webcore-rename:
3482
3483 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3484
3485         Adding Kenneth to the reviewers list.
3486
3487         * Scripts/modules/committers.py:
3488
3489 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
3490
3491         Reviewed by Jan Alonzo.
3492
3493         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
3494         https://bugs.webkit.org/show_bug.cgi?id=30482
3495
3496         LayoutTestControllerGtk now uses the exposed
3497         Page::tabKeyCyclesThroughElements API
3498
3499         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3500         (LayoutTestController::setTabKeyCyclesThroughElements):
3501
3502 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
3503
3504         Reviewed by Holger Freyther.
3505
3506         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
3507         This helps to pass the test case below. Also replaced hardcoded
3508         code numbers with defined constants.
3509         https://bugs.webkit.org/show_bug.cgi?id=31185
3510         
3511         Test: editing/undo/undo-deleteWord.html
3512
3513         * DumpRenderTree/qt/EventSenderQt.cpp:
3514         (EventSender::keyDown):
3515
3516 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
3517
3518         Reviewed by Holger Freyther.
3519
3520         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
3521         https://bugs.webkit.org/show_bug.cgi?id=31164
3522
3523         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
3524
3525         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3526         (LayoutTestController::processWork):
3527
3528 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
3529
3530         Reviewed by Holger Freyther.
3531
3532         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
3533         https://bugs.webkit.org/show_bug.cgi?id=31158
3534
3535         By invoking a script queue'd by queueScript(), 'true' was beeing returned
3536         always, which from WorkQueue prospective means that a load has been started
3537         and the queue processing should stop and wait for the load to finish.
3538         Spinning it off into a loading and a non-loading variants was the solution
3539         adopted by Mac's DRT to work around this problem. The former keeps returning
3540         'true' while the later executes the script synchronously and returns 'false'
3541         making it possible to the WorkQueue to proceed right away.
3542
3543         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3544         (LayoutTestController::processWork):
3545         (LayoutTestController::queueLoadingScript):
3546         (LayoutTestController::queueNonLoadingScript):
3547         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3548         * DumpRenderTree/qt/WorkQueueItem.h:
3549         (LoadingScriptItem::LoadingScriptItem):
3550         (LoadingScriptItem::invoke):
3551         (NonLoadingScriptItem::NonLoadingScriptItem):
3552         (NonLoadingScriptItem::invoke):
3553
3554 2009-11-07  Mark Rowe  <mrowe@apple.com>
3555
3556         Rubber-stamped by Cameron Zwarich.
3557
3558         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
3559
3560         * Scripts/commit-log-editor:
3561
3562 2009-11-07  Mark Rowe  <mrowe@apple.com>
3563
3564         Reviewed by Darin Adler.
3565
3566         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
3567         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
3568
3569         Move logic for determining the name and email address to use in a ChangeLog entry from
3570         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
3571         whether the author of the patch matches committer, and therefore needs access to the
3572         email address that would be used in a ChangeLog entry.
3573
3574         Based on a patch by Pierre d'Herbemont.
3575
3576         * Scripts/VCSUtils.pm:
3577         * Scripts/commit-log-editor:
3578         * Scripts/prepare-ChangeLog:
3579         * Scripts/webkitdirs.pm:
3580
3581 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3582
3583         Reviewed by Adam Barth.
3584
3585         Added functionality to the layout test plugin to invoke document.open and
3586         window.open with default arguments. The associated webkit bug is
3587         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
3588         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
3589         work in Chromium (V8) if there is no calling javascript context. To achieve this
3590         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
3591         for the window.open test case and in NPP_DestroyStream for the document.open test case.
3592
3593         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3594         (testDocumentOpen):
3595         (testWindowOpen):
3596         (pluginAllocate):
3597         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3598         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3599         (NPP_New):
3600         (NPP_SetWindow):
3601         (NPP_DestroyStream):
3602         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3603         (NPP_New):
3604         (NPP_SetWindow):
3605         (NPP_NewStream):
3606         (NPP_DestroyStream):
3607
3608 2009-11-06  Eric Seidel  <eric@webkit.org>
3609
3610         Reviewed by Adam Barth.
3611
3612         bugzilla-tool crashed with exception
3613         https://bugs.webkit.org/show_bug.cgi?id=31092
3614
3615         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
3616
3617 2009-11-04  Eric Seidel  <eric@webkit.org>
3618
3619         No review, just add a line which got left out of the patch uploaded for commit.
3620
3621         commit-queue is crashing when trying to reject patches after unknown failures
3622         https://bugs.webkit.org/show_bug.cgi?id=31091
3623
3624         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
3625
3626 2009-11-04  Adam Roben  <aroben@apple.com>
3627
3628         Remove bogus else clause in bugzilla-tool
3629
3630         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
3631         create-bug raises exception after entering bug description
3632
3633         Reviewed by David Kilzer.
3634
3635         * Scripts/bugzilla-tool:
3636         (CreateBug): else clauses are only hit if no exception is raised, so
3637         it makes no sense to try to re-raise the exception in an else clause.
3638         The exception will automatically be re-raised if it doesn't match any
3639         of the except clauses, so we don't have to do anything special here at
3640         all to get the desired behavior.
3641
3642 2009-11-04  Eric Seidel  <eric@webkit.org>
3643
3644         Reviewed by David Kilzer.
3645
3646         svn-apply's fixChangeLogPatch function seems broken
3647         https://bugs.webkit.org/show_bug.cgi?id=30683
3648
3649         Update fixChangeLogPatch to be able to handle patches which
3650         don't start at line 1.
3651         Add unit tests for svn-apply to scm_unittest.py.
3652
3653         * Scripts/VCSUtils.pm:
3654         * Scripts/modules/scm_unittest.py:
3655
3656 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3657
3658         Reviewed by Beth Dakin.
3659
3660         Need to implement ARIA role="combobox"
3661         https://bugs.webkit.org/show_bug.cgi?id=31096
3662
3663         * DumpRenderTree/AccessibilityUIElement.cpp:
3664         (showMenuCallback):
3665         (getIsExpandedCallback):
3666         (AccessibilityUIElement::getJSClass):
3667         * DumpRenderTree/AccessibilityUIElement.h:
3668         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3669         (AccessibilityUIElement::isExpanded):
3670         (AccessibilityUIElement::showMenu):
3671         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3672         (AccessibilityUIElement::isExpanded):
3673         (AccessibilityUIElement::showMenu):
3674         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3675         (AccessibilityUIElement::isSelected):
3676         (AccessibilityUIElement::isExpanded):
3677         (AccessibilityUIElement::showMenu):
3678
3679 2009-11-04  Eric Seidel  <eric@webkit.org>
3680
3681         Reviewed by Adam Barth.
3682
3683         commit-queue is crashing when trying to reject patches after unknown failures
3684         https://bugs.webkit.org/show_bug.cgi?id=31091
3685
3686         * Scripts/bugzilla-tool:
3687          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
3688            so we have to find out what the current patch is by asking bugzilla again.
3689          - Discovered that this code was also leaking file descriptors, so fixed that.
3690
3691 2009-11-04  Adam Roben  <aroben@apple.com>
3692
3693         Make run-webkit-tests work for the Debug_Internal Windows
3694         configuration
3695
3696         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
3697         suffix.
3698
3699         Fixes <http://webkit.org/b/31123>.
3700
3701         Reviewed by Sam Weinig.
3702
3703         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3704         Debug_Internal, either.
3705
3706 2009-11-04  Eric Seidel  <eric@webkit.org>
3707
3708         Reviewed by Adam Barth.
3709
3710         committers.py needs a way to store non-bugzilla email addresses
3711         https://bugs.webkit.org/show_bug.cgi?id=31037
3712
3713         Make Committer and Reviewer constructors take a single email or a list of emails.
3714         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3715         Expose reviewers(), used by validate-committer-lists on bug 30970.
3716
3717         * Scripts/modules/committers.py:
3718         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3719
3720 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3721
3722         Reviewed by David Levin.
3723
3724         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3725         https://bugs.webkit.org/show_bug.cgi?id=27491
3726
3727         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3728         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3729
3730         Functions to start or stop Web Socket servers are added.
3731
3732         * Scripts/run-webkit-tests:
3733
3734 2009-11-03  Eric Seidel  <eric@webkit.org>
3735
3736         No review, just changing wording of log message.
3737
3738         Change log string to say "failed" instead of "rejected"
3739         when a commit fails due to an out of date checkout.
3740         This makes grepping the commit-queue log for rejected patches easier.
3741
3742         * Scripts/bugzilla-tool:
3743
3744 2009-11-03  Eric Seidel  <eric@webkit.org>
3745
3746         No review, adding commonly known committers missing from the file.
3747
3748         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3749
3750 2009-11-03  Eric Seidel  <eric@webkit.org>
3751
3752         No review, just sort-order cleanup.
3753
3754         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3755
3756 2009-11-03  Stephen White  <senorblanco@chromium.org>
3757
3758         (Unreviewed).
3759
3760         Add myself to committers.py.
3761
3762         * Scripts/modules/committers.py:
3763
3764 2009-11-03  Robin Dunn  <robin@alldunn.com>
3765
3766         Reviewed by Kevin Ollviier.
3767
3768         Add packaging scripts for Debian-based Linux distros.
3769         
3770         https://bugs.webkit.org/show_bug.cgi?id=31075
3771
3772         * wx/packaging/build-debian-installer.py: Added.
3773         * wx/packaging/debian: Added.
3774
3775 2009-11-03  Dan Bernstein  <mitz@apple.com>
3776
3777         Reviewed by Anders Carlsson and Beth Dakin.
3778
3779         https://bugs.webkit.org/show_bug.cgi?id=31070
3780
3781         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
3782         destroyed, it executes the value of the 'ondestroy' parameter as a
3783         script.
3784
3785         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3786         (pluginAllocate): Initialize onDestroy.
3787         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
3788         onDestroy.
3789         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3790         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
3791         specified.
3792         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
3793
3794 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3795
3796         Reviewed by Xan Lopez.
3797
3798         https://bugs.webkit.org/show_bug.cgi?id=31035
3799         [GTK] some accessibility tests hitting assertion in debug builds
3800
3801         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
3802
3803         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3804         (AccessibilityController::rootElement):
3805
3806 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3807
3808         Reviewed by Beth Dakin.
3809
3810         Support ARIA "tab" roles
3811         https://bugs.webkit.org/show_bug.cgi?id=30842
3812
3813         * DumpRenderTree/AccessibilityUIElement.cpp:
3814         * DumpRenderTree/AccessibilityUIElement.h:
3815         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3816         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3817         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3818
3819 2009-11-01  Eric Seidel  <eric@webkit.org>
3820
3821         Reviewed by David Levin.
3822
3823         buildbots should use --exit-after-N-failures
3824         https://bugs.webkit.org/show_bug.cgi?id=30809
3825
3826         Make the bots exit after 20 failures to prevent never-ending
3827         test runs where every test spends a minute crashing.
3828
3829         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3830
3831 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3832
3833         Reviewed by Eric Seidel.
3834
3835         Turn on warnings for QtWebKit for gcc
3836         https://bugs.webkit.org/show_bug.cgi?id=30958
3837
3838         * DumpRenderTree/qt/main.cpp: 
3839         (crashHandler): Mark function NO_RETURN
3840
3841 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
3842
3843         Adding myself to the committers list.
3844
3845         * Scripts/modules/committers.py:
3846
3847 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
3848
3849         Fix an issue that Adam noticed in DRT.
3850
3851         Reviewed by Darin Adler.
3852
3853         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3854         (AccessibilityUIElement::role):
3855         Get the length of the role text, and create a buffer dynamically.
3856
3857 2009-10-30  Eric Seidel  <eric@webkit.org>
3858
3859         No review, rolling out r50105.
3860         http://trac.webkit.org/changeset/50105
3861
3862         This commit was causing:
3863         https://bugs.webkit.org/show_bug.cgi?id=30869
3864         We'll re-implement the feature a different way.
3865
3866         * Scripts/bugzilla-tool:
3867
3868 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3869
3870         Test for MSAA: Accessibility of headings is not correct
3871
3872         https://bugs.webkit.org/show_bug.cgi?id=30937
3873
3874         Reviewed by Adam Roben.
3875
3876         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3877         (AccessibilityUIElement::role):
3878         Allow the role returned to be a BSTR.
3879         (AccessibilityUIElement::description):
3880         Fix a copy/paste error.
3881
3882 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3883
3884         Test for MSAA: Accessibility of links is wrong
3885
3886         https://bugs.webkit.org/show_bug.cgi?id=30928
3887
3888         Reviewed by Darin Adler.
3889
3890         * DumpRenderTree/AccessibilityUIElement.cpp:
3891         (getAccessibilityValueCallback):
3892         Return the accessibility value.
3893         (AccessibilityUIElement::getJSClass):
3894         Added "accessibilityValue" value.
3895
3896         * DumpRenderTree/AccessibilityUIElement.h:
3897
3898         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3899         (AccessibilityUIElement::accessibilityValue):
3900         Stubbed.
3901
3902         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3903         (AccessibilityUIElement::accessibilityValue):
3904         Stubbed.
3905
3906         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3907         (AccessibilityUIElement::accessibilityValue):
3908         Get the object's value, and return it as a JS string.
3909
3910 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
3911
3912         Fix typo in command name used by wx build system.
3913
3914         * wx/build/build_utils.py:
3915
3916 2009-10-30  Adam Barth  <abarth@webkit.org>
3917
3918         Reviewed by Darin Adler.
3919
3920         Patch v1 is a dumb default name for patches
3921         https://bugs.webkit.org/show_bug.cgi?id=30952
3922
3923         Let's use "Patch" instead.
3924
3925         * Scripts/bugzilla-tool:
3926
3927 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3928
3929         Unreviewed trivial buildfix.
3930
3931         [Qt] Buildfix for r50333.
3932
3933         * DumpRenderTree/qt/DumpRenderTree.pro:
3934
3935 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
3936
3937         Reviewed by Holger Freyther.
3938
3939         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
3940         https://bugs.webkit.org/show_bug.cgi?id=30953
3941
3942         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
3943         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
3944         makes qt DRT to share this implementation (as gtk and mac ports do).
3945
3946         * DumpRenderTree/qt/DumpRenderTree.pro:
3947         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
3948         * DumpRenderTree/qt/WorkQueue.h: Removed.
3949
3950 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3951
3952         Unreviewed potential buildbot fix.
3953
3954         Second try: Reset page history before running each test.
3955
3956         Apparently the QWebHistory::clear() keeps the current page
3957         in history which is not what we want, so we not additionally
3958         sets the history capacity to 0 (forces removing everything)
3959         and then sets it back to its original value.
3960
3961         * DumpRenderTree/qt/DumpRenderTree.cpp:
3962         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3963
3964 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3965
3966         Unreviewed potential buildbot fix.
3967
3968         Reset page history before running each test.
3969
3970         * DumpRenderTree/qt/DumpRenderTree.cpp:
3971         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3972
3973 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
3974
3975         Reviewed by Eric Seidel.
3976
3977         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
3978
3979         Bug 28420 -  Implement HTML5 <ruby> rendering
3980         (https://bugs.webkit.org/show_bug.cgi?id=28420)
3981
3982         No new tests (no functional change).
3983
3984         * Scripts/build-webkit:
3985
3986 2009-10-29  Dan Bernstein  <mitz@apple.com>
3987
3988         Reviewed by Mark Rowe.
3989
3990         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
3991         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
3992         define it.
3993
3994         * Scripts/VCSUtils.pm:
3995         * Scripts/svn-apply:
3996         * Scripts/svn-unapply:
3997
3998 2009-10-29  Xan Lopez  <xlopez@igalia.com>
3999
4000         Reviewed by Gustavo Noronha.
4001
4002         Use the GTK+ main loop instead of rolling our own mini-version of
4003         it.
4004
4005         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4006         (dump):
4007         (runTest):
4008         (webViewLoadFinished):
4009
4010 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4011
4012         Reviewed by Oliver Hunt.
4013
4014         Implement the Qt version of DRT dumpBackForwardList().
4015
4016         * DumpRenderTree/qt/DumpRenderTree.cpp:
4017         (WebCore::dumpHistoryItem):
4018         (WebCore::DumpRenderTree::dumpBackForwardList):
4019
4020 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4021
4022         Reviewed by Adam Roben.
4023
4024         Implement DRT functionality for Qt introduced in
4025         r28690 and r28705.
4026
4027         - Implemented pathToLocalResource which exposes the functionality of
4028         converting a given unix path to the correct location on Windows.
4029         - Implemented a way to remove machine-dependent information from paths
4030         in layout test results.
4031
4032         * DumpRenderTree/qt/DumpRenderTree.cpp:
4033         (WebCore::urlSuitableForTestResult):
4034         (WebCore::WebPage::javaScriptConsoleMessage):
4035         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4036         (LayoutTestController::pathToLocalResource):
4037         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4038
4039 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
4040
4041         Adding myself to the committers list.
4042
4043         * Scripts/modules/committers.py:
4044
4045 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
4046
4047         Adding myself to the committers list.
4048
4049         * Scripts/modules/committers.py:
4050
4051 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4052
4053         Reviewed by Jan Alonzo.
4054
4055         [GTK] API to start inspector for a WebView
4056         https://bugs.webkit.org/show_bug.cgi?id=22551
4057
4058         Use the new inspector API to implement the LayoutTestController
4059         interfaces used to test the inspector.
4060
4061         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4062         (webInspectorInspectWebView):
4063         (createWebView):
4064         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4065         (LayoutTestController::showWebInspector):
4066         (LayoutTestController::closeWebInspector):
4067         (LayoutTestController::evaluateInWebInspector):
4068
4069 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
4070
4071         Reviewed by Eric Seidel.
4072
4073         [Qt] WebFrame::counterValueForElementById must not be exposed
4074         https://bugs.webkit.org/show_bug.cgi?id=30882
4075
4076         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4077         (LayoutTestController::counterValueForElementById):
4078
4079 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4080
4081         Rubberstamped by Oliver Hunt.
4082
4083         Fix the warning:
4084
4085         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
4086         declared with attribute warn_unused_result".
4087
4088         by actually checking the result. In the case it is null, an
4089         error has occoured, so treat it as the other fatal errors.
4090
4091         * DumpRenderTree/qt/DumpRenderTree.cpp:
4092         (WebCore::DumpRenderTree::initializeFonts):
4093
4094 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
4095
4096         Reviewed by Darin Adler.
4097
4098         Provide a way to get counter values with layoutTestContoller
4099         https://bugs.webkit.org/show_bug.cgi?id=30555
4100
4101         Define layoutTestContoller.counterValueForElementById.
4102
4103         * DumpRenderTree/LayoutTestController.cpp:
4104         (counterValueForElementByIdCallback):
4105         (LayoutTestController::staticFunctions):
4106         * DumpRenderTree/LayoutTestController.h:
4107         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4108         (LayoutTestController::counterValueForElementById):
4109
4110 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4111
4112         Rubberstamped by Oliver Hunt.
4113
4114         Change two methods to be internal for DRT use only.
4115
4116         Part of [Qt] Review all new API in Qt 4.6
4117         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
4118
4119         * DumpRenderTree/qt/DumpRenderTree.cpp:
4120         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4121         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4122         (LayoutTestController::whiteListAccessFromOrigin):
4123
4124 2009-10-27  Eric Seidel  <eric@webkit.org>
4125
4126         Reviewed by Adam Barth.
4127
4128         REGRESSION: svn-apply exits(1) when applying a patch with a file add
4129         https://bugs.webkit.org/show_bug.cgi?id=30826
4130
4131         * Scripts/svn-apply:
4132          - Add () around all system() calls.
4133          - Use the correct system() == 0 or die instead of system() or die
4134          - Add descriptive messages to all die statements.
4135
4136 2009-10-27  Steve Block  <steveblock@google.com>
4137
4138         Reviewed by NOBODY.
4139
4140         Adds steveblock@google.com to list of committers.
4141
4142         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
4143
4144 2009-10-27  Eric Seidel  <eric@webkit.org>
4145
4146         Reviewed by Adam Barth.
4147
4148         svn-apply can exit(0) even on patch failure
4149         https://bugs.webkit.org/show_bug.cgi?id=29622
4150
4151         * Scripts/svn-apply:
4152          - Add a bunch of "or die" statements, hopefully catching all
4153            possible cases where failure could still exit(0).
4154
4155 2009-10-27  Eric Seidel  <eric@webkit.org>
4156
4157         Reviewed by Adam Barth.
4158
4159         svn-* scripts should share code through VCSUtils.pm
4160         https://bugs.webkit.org/show_bug.cgi?id=30791
4161
4162         Just moving code into a shared location.
4163
4164         * Scripts/VCSUtils.pm:
4165         * Scripts/prepare-ChangeLog:
4166         * Scripts/resolve-ChangeLogs:
4167         * Scripts/svn-apply:
4168         * Scripts/svn-create-patch:
4169         * Scripts/svn-unapply:
4170         * Scripts/update-webkit:
4171
4172 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
4173
4174         Suppress a huge number of MSVC warnings when building wxWebKit.
4175
4176         * wx/build/settings.py:
4177
4178 2009-10-26  Eric Seidel  <eric@webkit.org>
4179
4180         No review, just adding Mike Belshe to the committers list.
4181
4182         * Scripts/modules/committers.py:
4183
4184 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4185
4186         Reviewed by Darin Adler.
4187
4188         Make .rc files compile on Windows without depending on MFC headers
4189         https://bugs.webkit.org/show_bug.cgi?id=30750
4190
4191         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
4192         windows.h instead of afxres.h because it exists even when MFC is not 
4193         installed, and is all that's needed here.
4194
4195         * FindSafari/FindSafari.rc: Ditto
4196
4197 2009-10-24  Eric Seidel  <eric@webkit.org>
4198
4199         Reviewed by Adam Barth.
4200
4201         bugzilla-tool post-diff should know how to mark commit-queue=?
4202         https://bugs.webkit.org/show_bug.cgi?id=29202
4203
4204         * Scripts/bugzilla-tool:
4205          - Add --commit-queue option to post-diff, post-commits and create-bug.
4206         * Scripts/modules/bugzilla.py:
4207          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
4208          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
4209
4210 2009-10-23  Eric Seidel  <eric@webkit.org>
4211
4212         Reviewed by Adam Barth.
4213
4214         bugzilla-tool commit-queue does not notice modifications to committers.py
4215         https://bugs.webkit.org/show_bug.cgi?id=30084
4216
4217         * Scripts/bugzilla-tool:
4218          - Make commit-queue re-exec itself instead of using while(1).
4219          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
4220          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
4221
4222 2009-10-22  Eric Seidel  <eric@webkit.org>
4223
4224         Reviewed by Adam Barth.
4225
4226         commit-queue will get stuck on patches if land-patches terminates unexpectedly
4227         https://bugs.webkit.org/show_bug.cgi?id=30634
4228
4229         * Scripts/bugzilla-tool:
4230          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
4231          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
4232
4233 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
4234
4235         Reviewed by Eric Seidel.
4236
4237         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
4238
4239         https://bugs.webkit.org/show_bug.cgi?id=30763
4240
4241         * pywebsocket/mod_pywebsocket/__init__.py:
4242         * pywebsocket/mod_pywebsocket/dispatch.py:
4243         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
4244         * pywebsocket/mod_pywebsocket/standalone.py:
4245         * pywebsocket/setup.py:
4246         * pywebsocket/test/test_dispatch.py:
4247
4248 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
4249
4250         Reviewed by David Levin.
4251
4252         REGRESSION: 2 failures in run-webkit-unittests
4253         https://bugs.webkit.org/show_bug.cgi?id=30645
4254
4255         * Scripts/modules/cpp_style_unittest.py:
4256         Fixed a few test scenarios which apparently lost some spaces from 
4257         text literals.
4258
4259 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
4260
4261         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
4262
4263         * Scripts/webkitdirs.pm:
4264
4265 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
4266
4267         Reviewed by Darin Adler.
4268
4269         Unification of using null device in perl scripts.
4270         https://bugs.webkit.org/show_bug.cgi?id=30572
4271
4272         * Scripts/VCSUtils.pm:
4273         * Scripts/bisect-builds:
4274         * Scripts/resolve-ChangeLogs:
4275         * Scripts/run-iexploder-tests:
4276         * Scripts/run-jsc:
4277         * Scripts/run-mangleme-tests:
4278         * Scripts/run-webkit-tests:
4279         * Scripts/webkitdirs.pm:
4280         Using File::Spec->devnull() instead of hard coded /dev/null.
4281
4282 2009-10-26  Eric Seidel  <eric@webkit.org>
4283
4284         Reviewed by Holger Freyther.
4285
4286         Reviewers are missing from committers.py
4287         https://bugs.webkit.org/show_bug.cgi?id=30733
4288
4289         * Scripts/modules/committers.py:
4290
4291 2009-10-23  Eric Seidel  <eric@webkit.org>
4292
4293         No review, only adding Alice to the list of reviewers.
4294
4295         * Scripts/modules/committers.py:
4296
4297 2009-10-23  Eric Seidel  <eric@webkit.org>
4298
4299         Reviewed by Eric Carlson.
4300
4301         fast/media/mq-transform-02.html failed on Leopard Commit Bot
4302         https://bugs.webkit.org/show_bug.cgi?id=30700
4303
4304         * DumpRenderTree/mac/DumpRenderTree.mm:
4305         (resetDefaultsToConsistentValues): Update QuickTime version check.
4306
4307 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
4308
4309         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
4310         character measurement APIs that are private on Tiger.
4311
4312         * wx/build/settings.py:
4313
4314 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
4315
4316         Reviewed by NOBODY (build fix).
4317         Build fix following bug #30696.
4318
4319         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4320         (LayoutTestController::evaluateScriptInIsolatedWorld):
4321
4322 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
4323
4324         Reviewed by Sam Weinig & Geoff Garen.
4325
4326         https://bugs.webkit.org/show_bug.cgi?id=30696
4327         Enable isolated-worlds tests on mac.
4328
4329         Add private interface for DRT to invoke execution in a given world.
4330
4331         * DumpRenderTree/LayoutTestController.cpp:
4332         (evaluateScriptInIsolatedWorldCallback):
4333         (LayoutTestController::staticFunctions):
4334         * DumpRenderTree/LayoutTestController.h:
4335         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4336         (LayoutTestController::evaluateScriptInIsolatedWorld):
4337         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4338         (LayoutTestController::evaluateScriptInIsolatedWorld):
4339
4340 2009-10-21  Eric Seidel  <eric@webkit.org>
4341
4342         Reviewed by Adam Barth.
4343
4344         bugzilla-tool's "patch failed to download an apply" error should give more information
4345         https://bugs.webkit.org/show_bug.cgi?id=30632
4346
4347         * Scripts/modules/scm.py:
4348          - Use the common run_command method instead of custom POpen code.
4349          - Make run_command know how to take pipes as input.
4350         * Scripts/modules/scm_unittest.py:
4351          - Add new tests to cover change.
4352          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
4353
4354 2009-10-21  Kent Tamura  <tkent@chromium.org>
4355
4356         Unreviewed.  Adding myself to the committers list.
4357
4358         * Scripts/modules/committers.py:
4359
4360 2009-10-21  Robin Dunn  <robin@alldunn.com>
4361
4362         Reviewed by Kevin Ollivier.
4363
4364         Update the Windows installer builder to work with Vista / Win 7 and with git.
4365         
4366         https://bugs.webkit.org/show_bug.cgi?id=30649
4367
4368         * wx/build/build_utils.py:
4369         * wx/packaging/build-mac-installer.py:
4370         * wx/packaging/build-win-installer.py:
4371         * wx/packaging/wxWebKitInstaller.iss.in:
4372
4373 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
4374
4375         Reviewed by Gustavo Noronha.
4376
4377         [GTK] Added conditional code to avoid using
4378         gdk_window_get_root_coords if we do not have a gtk+ release newer
4379         than 2.17.3.
4380         https://bugs.webkit.org/show_bug.cgi?id=30636
4381
4382         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4383
4384 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
4385
4386         Reviewed by Eric Seidel.
4387
4388         [Qt] Added dummy implementation for keepWebHistory()
4389         https://bugs.webkit.org/show_bug.cgi?id=30592
4390
4391         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4392         (LayoutTestController::keepWebHistory):
4393         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4394
4395 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
4396
4397         Reviewed by Xan Lopez.
4398
4399         [GTK] Fixed the double click condition, it is not double click if
4400         we move in just in one direction.
4401         https://bugs.webkit.org/show_bug.cgi?id=30636
4402
4403         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4404
4405 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
4406
4407         Reviewed by Xan Lopez.
4408
4409         [GTK] Initialize the events completly before emitting them.
4410         https://bugs.webkit.org/show_bug.cgi?id=30633
4411
4412         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4413
4414 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
4415
4416         wx build fix. Fix for when linking using --as-needed with gcc.
4417
4418         * wx/browser/wscript:
4419
4420 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
4421
4422         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
4423         to support all the features used by CURL backend.
4424         
4425         * wx/build/settings.py:
4426         * wx/install-unix-extras:
4427
4428 2009-10-20  Anton Muhin  <antonm@chromium.org>
4429
4430         Reviewed by Adam Barth.
4431
4432         Add {ager,antonm,yurys}@chromium.org into committers.py
4433         https://bugs.webkit.org/show_bug.cgi?id=30560
4434
4435         * Scripts/modules/committers.py:
4436
4437 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4438
4439         Reviewed by Tor Arne Vestbø.
4440
4441         Make the Netscape Test plugin available to the Qt launcher.
4442
4443         * Scripts/run-launcher:
4444
4445 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
4446
4447         Reviewed by David Levin.
4448
4449         Removed WebSocket runtime settings.
4450         https://bugs.webkit.org/show_bug.cgi?id=29896
4451
4452         WebSocket runtime configuration is supported by chromium/v8 only.
4453
4454         * DumpRenderTree/mac/DumpRenderTree.mm:
4455         (resetDefaultsToConsistentValues):
4456         * DumpRenderTree/win/DumpRenderTree.cpp:
4457         (resetDefaultsToConsistentValues):
4458
4459 2009-10-19  Nate Chapin  <japhet@chromium.org>
4460
4461         Reviewed by Adam Barth.
4462
4463         Add testFail() to test plugin so we can test our handling of a
4464         plugin invoke call returning false.
4465
4466         https://bugs.webkit.org/show_bug.cgi?id=30239
4467
4468         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
4469         (pluginInvoke):
4470         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
4471
4472 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
4473
4474         Reviewed by Gustavo Noronha.
4475
4476         Enable DOM pasting when running layout tests.
4477
4478         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4479         (resetDefaultsToConsistentValues):
4480
4481 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4482
4483         Reviewed by Simon Hausmann.
4484
4485         Use the setPreferredContentsSize method instead
4486         of setFixedContentsSize, as the method has been renamed.
4487
4488         * DumpRenderTree/qt/DumpRenderTree.cpp:
4489         (WebCore::DumpRenderTree::open):
4490         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4491         (LayoutTestController::setFixedContentsSize):
4492
4493 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
4494
4495         Reviewed by Dan Bernstein.