2010-07-11 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         Implement animation-related methods for WebKitTestRunner
6         https://bugs.webkit.org/show_bug.cgi?id=42053
7         
8         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
9         animation tests were hanging otherwise.
10
11         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
12         (WTR::LayoutTestController::numberOfActiveAnimations):
13         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
14         (WTR::numberOfActiveAnimationsCallback):
15         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
16         (WTR::LayoutTestController::staticFunctions):
17         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
18
19 2010-07-11  Daniel Bates  <dbates@rim.com>
20
21         Reviewed by David Kilzer.
22
23         Enable executable support for svn-apply and svn-unapply
24         https://bugs.webkit.org/show_bug.cgi?id=39409
25
26         Connect up the Git and SVN executable bit support in parseDiff() so that
27         executable bit changes are propagated via the returned diff hash to the
28         patch function in svn-apply and svn-unapply.
29
30         * Scripts/VCSUtils.pm:
31           - Modified parseDiff() to call parseSvnDiffProperties when
32             it finds the start of an SVN property change diff.
33           - Removed FIXME comment above parseSvnDiffProperties() since
34             it is now being used by parseDiff().
35           - Export method scmToggleExecutableBit() now that we added the
36             executableBitDelta hash key. (This should have been exported
37             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
38         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
39           - Updated results for:
40             "rename (with executable bit change)"
41               - Test value of executableBitDelta (now that we have support).
42             "SVN: binary file (isBinary true)"
43               - Remove the property change diff from svnConvertedText. We plan
44                 to remove svnConvertedText in the future. So, we decided
45                 against adding such support to any new code, such as the
46                 property parsing routines. Therefore, we do not keep SVN
47                 converted text for property change diffs.
48           - Added unit tests:
49             "SVN: file change diff with property change diff"
50             "SVN: file change diff, followed by property change diff on different file"
51             "SVN: property diff, followed by file change diff"
52             "SVN: copied file with property change"
53             "SVN: two consecutive property diffs"
54             "SVN: binary file with executable bit change"
55             "SVN: binary file followed by property change on different file"
56             "SVN: binary file followed by file change on different file"
57             "SVN: file change diff with property change, followed by property change diff"
58             "SVN: file change diff with property change, followed by file change diff"
59
60 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
61
62         Reviewed by Dan Bernstein.
63
64         Implement waitUntilDone and notifyDone for WebKitTestRunner
65         https://bugs.webkit.org/show_bug.cgi?id=42049
66
67         With this fix, most of the DOM tests pass.
68         
69         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
70         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
71         a great way to do it in the future case where we may get multiple
72         pages - we really need a way to send it over from the ui process.
73         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
74         (WTR::InjectedBundle::page): A way to get the main page.
75         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
76         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
77         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
78         are loading.
79         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
80         called by the layout test controller. Also, cancel any pending watchdogs.
81         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
82         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
83         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
84         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
85         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
86         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
87         to false.
88         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
89         the watchdog.
90         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
91         (WTR::LayoutTestController::setWaitToDump): Set the flag.
92         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
93         where waitUntilDone times out.
94         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
95         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
96         (WTR::notifyDoneCallback): JS glue for notifyDone.
97         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
98         to the layoutController.
99         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
100         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
101
102 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
103
104         Rubber-stamped by Dan Bernstein.
105
106         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
107         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
108         slow down the tests).
109
110         * Scripts/webkitpy/common/system/executive.py:
111
112 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
113
114         Reviewed by Kenneth Rohde Christiansen.
115
116         [Qt] Mac build fix
117         https://bugs.webkit.org/show_bug.cgi?id=41967
118
119         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
120
121         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
122
123 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
124
125         Reviewed by Antonio Gomes.
126
127         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
128         https://bugs.webkit.org/show_bug.cgi?id=41966
129
130         * MiniBrowser/qt/BrowserWindow.cpp:
131         (BrowserWindow::BrowserWindow):
132
133 2010-07-09  Leon Clarke  <leonclarke@google.com>
134
135         Reviewed by Adam Barth.
136
137         add support for link prefetching
138         https://bugs.webkit.org/show_bug.cgi?id=3652
139
140         * Scripts/build-webkit:
141
142 2010-07-09  Ojan Vafai  <ojan@chromium.org>
143
144         Reviewed by Adam Barth.
145
146         r63004 broke some python tests
147         https://bugs.webkit.org/show_bug.cgi?id=42007
148
149         AbstractStep now checks options.no_squash and options.squash, so
150         they needed to have real values. Mock would return an object for those,
151         which would then act as if the values were True.
152
153         * Scripts/webkitpy/tool/commands/commandtest.py:
154         * Scripts/webkitpy/tool/commands/download_unittest.py:
155         * Scripts/webkitpy/tool/commands/stepsequence.py:
156         * Scripts/webkitpy/tool/commands/upload_unittest.py:
157         * Scripts/webkitpy/tool/mocktool.py:
158         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
159         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
160         * Scripts/webkitpy/tool/steps/steps_unittest.py:
161         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
162         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
163
164 2010-07-09  Ojan Vafai  <ojan@chromium.org>
165
166         Reviewed by Adam Barth.
167
168         --squash should go away and become the default
169         https://bugs.webkit.org/show_bug.cgi?id=39624
170
171         If there are local commits and working copy changes, then prompt the user
172         whether to continue. Setting git config webkit-patch.commit_should_always_squash
173         true bypasses the prompt.
174
175         --git-commit=HEAD.. operates on working copy changes only.
176         --git-commit=committish operates on a range of commits as a single commit.
177             e.g. --git-commit=HEAD only operates on the HEAD commit.
178             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
179
180         --no-squash and --squash are left in with descriptive error messages if used.
181
182         * Scripts/check-webkit-style:
183         * Scripts/webkitpy/common/checkout/api.py:
184         * Scripts/webkitpy/common/checkout/api_unittest.py:
185         * Scripts/webkitpy/common/checkout/scm.py:
186         * Scripts/webkitpy/common/checkout/scm_unittest.py:
187         * Scripts/webkitpy/common/net/rietveld.py:
188         * Scripts/webkitpy/common/system/user.py:
189         * Scripts/webkitpy/style/optparser.py:
190         * Scripts/webkitpy/style_references.py:
191         * Scripts/webkitpy/tool/commands/download.py:
192         * Scripts/webkitpy/tool/commands/upload.py:
193         * Scripts/webkitpy/tool/mocktool.py:
194         * Scripts/webkitpy/tool/steps/abstractstep.py:
195         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
196         * Scripts/webkitpy/tool/steps/checkstyle.py:
197         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
198         * Scripts/webkitpy/tool/steps/commit.py:
199         * Scripts/webkitpy/tool/steps/options.py:
200         * Scripts/webkitpy/tool/steps/preparechangelog.py:
201         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
202         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
203         * Scripts/webkitpy/tool/steps/validatereviewer.py:
204
205 2010-07-09  Mark Rowe  <mrowe@apple.com>
206
207         Add two new Windows test build slaves.
208
209         * BuildSlaveSupport/build.webkit.org-config/config.json:
210
211 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
212
213         Reviewed by David Levin.
214
215         rebaseline_chromium_webkit_tests missing --use_drt option on linux
216         https://bugs.webkit.org/show_bug.cgi?id=41985
217
218         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
219         so that it works on linux. This is essentially a "compile-fix" for the
220         script.
221
222         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
223
224 2010-07-09  Nico Weber  <thakis@chromium.org>
225
226         Unreviewed. Adding myself as committer.
227
228         * Scripts/webkitpy/common/config/committers.py:
229
230 2010-07-09  David Kilzer  <ddkilzer@apple.com>
231
232         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
233
234         This reverts commit r62692.
235
236         * Scripts/commit-log-editor:
237
238 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
239
240         Reviewed by Ojan Vafai.
241
242         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
243         https://bugs.webkit.org/show_bug.cgi?id=38693
244
245         Introduced a new base class JSONResultsGeneratorBase that doesn't
246         have any dependency on layout_tests packages.
247         Turned JSONResultsGenerator into a wrapper class of the base class
248         so that the old code can work with it during the cleanup.
249
250         Added json_results_generator_unittest.py.
251
252         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
253         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
254         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
255
256 2010-07-09  Abhishek Arya  <inferno@chromium.org>
257
258         Unreviewed.
259
260         Marking myself as a committer.
261
262         * Scripts/webkitpy/common/config/committers.py:
263
264 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
265
266         Reviewed by Antti Koivisto.
267
268         Implement MiniBrowser for Qt.
269         https://bugs.webkit.org/show_bug.cgi?id=40233
270
271         * MiniBrowser/qt/BrowserWindow.cpp: Added.
272         (createNewPage):
273         (BrowserView::BrowserView):
274         (BrowserView::resizeEvent):
275         (BrowserView::load):
276         (BrowserView::view):
277         (BrowserWindow::BrowserWindow):
278         (BrowserWindow::load):
279         (BrowserWindow::changeLocation):
280         (BrowserWindow::~BrowserWindow):
281         * MiniBrowser/qt/BrowserWindow.h: Added.
282         (BrowserView::~BrowserView):
283         * MiniBrowser/qt/MiniBrowser.pro: Added.
284         * MiniBrowser/qt/main.cpp: Added.
285         (main):
286
287 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
288
289         Reviewed by Simon Hausmann.
290
291         Introduce the Qt autotest launcher.
292
293         Qt autotests should be executed more frequently, ideally by the Qt
294         build bot. This is the first step to provide the tests more accessible.
295
296         [Qt] It should be easier to run all Qt's autotests.
297         https://bugs.webkit.org/show_bug.cgi?id=31625
298
299         * Scripts/run-qtwebkit-tests: Added.
300
301 2010-07-09  Adam Barth  <abarth@webkit.org>
302
303         Reviewed by Eric Seidel.
304
305         commit-queue should merge to TOT when checkout needs update
306         https://bugs.webkit.org/show_bug.cgi?id=41944
307
308         There are a bunch of different designs that are possible here.  This
309         one merges to top of tree by cleaning out the working copy and
310         re-applying the patch.  Once you decide to merge that way, you need to
311         decide who's going to retry.  In this patch, we retry in the child
312         process instead of plumbing the failure reason to the master process.
313
314         This patch is difficult to test end-to-end, but hopefully it will work.
315         :)
316
317         * Scripts/webkitpy/tool/commands/queues.py:
318         * Scripts/webkitpy/tool/commands/stepsequence.py:
319         * Scripts/webkitpy/tool/multicommandtool.py:
320         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
321
322 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
323
324         Reviewed by Darin Adler.
325
326         Add a script to check for unnecessary includes in header files.
327         https://bugs.webkit.org/show_bug.cgi?id=41894
328
329         * Scripts/check-header-includes: Added.
330
331 2010-07-09  Adam Barth  <abarth@webkit.org>
332
333         Reviewed by Eric Seidel.
334
335         Add --html5-treebuilder option to run-webkit-tests
336         https://bugs.webkit.org/show_bug.cgi?id=41922
337
338         We're down to one or two regressions in the HTML5lib test suite.  It's
339         getting to be time to look at fixing LayoutTests.
340
341         * Scripts/old-run-webkit-tests:
342
343 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
344
345         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
346         in the drawing model never getting set on Tiger.
347
348         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
349         (NPP_New):
350
351 2010-07-08  Aaron Boodman  <aa@chromium.org>
352
353         Reviewed by Timothy Hatcher.
354
355         Add the ability for user scripts and user styles to affect just the top frame.
356
357         https://bugs.webkit.org/show_bug.cgi?id=41529
358
359         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
360         * DumpRenderTree/LayoutTestController.cpp: Ditto.
361         (addUserScriptCallback):
362         (addUserStyleSheetCallback):
363         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
364         (LayoutTestController::addUserScript):
365         (LayoutTestController::addUserStyleSheet):
366         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
367         (LayoutTestController::addUserScript):
368         (LayoutTestController::addUserStyleSheet):
369         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
370         (LayoutTestController::addUserScript):
371         (LayoutTestController::addUserStyleSheet):
372         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
373         (LayoutTestController::addUserScript):
374         (LayoutTestController::addUserStyleSheet):
375         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
376         (LayoutTestController::addUserScript):
377         (LayoutTestController::addUserStyleSheet):
378
379 2010-07-08  Adele Peterson  <adele@apple.com>
380
381         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
382
383         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
384         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
385
386         Log when the missing plugin button is pressed.
387
388         * DumpRenderTree/mac/UIDelegate.mm:
389         (-[UIDelegate webView:didPressMissingPluginButton:]):
390         * DumpRenderTree/win/UIDelegate.cpp:
391         (UIDelegate::QueryInterface):
392         (UIDelegate::createWebViewWithRequest):
393         (UIDelegate::drawBackground):
394         (UIDelegate::decidePolicyForGeolocationRequest):
395         (UIDelegate::didPressMissingPluginButton):
396         * DumpRenderTree/win/UIDelegate.h:
397
398 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
399
400         Fix the Tiger build.
401
402         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
403         (NPP_New):
404
405 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
406
407         Fix windows build.
408
409         #ifdef code for Mac.
410
411         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
412         (NPP_New):
413
414 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
415
416         Reviewed by Anders Carlsson.
417
418         Allow the TestPlugin to use Core Animation rendering for testing
419         https://bugs.webkit.org/show_bug.cgi?id=41872
420         
421         Add the ability for the TestPlugin to use the CoreAnimation rendering model
422         when available, based on the "drawingmodel" attribute of the embed tag:
423             drawingmodel="coreanimation"
424
425         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
426         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
427         when building on Tiger. Add a void* coreAnimationLayer member.
428         
429         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
430         (createCoreAnimationLayer): Obj-C method to create the CALayer.
431         
432         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
433         (NPP_New): Look for the drawingmodel attribute to decide which drawing
434         model to use.
435         (NPP_Destroy): Release the CALayer if we have one.
436         (NPP_GetValue): Return the retained CALayer.
437
438 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
439
440         Reviewed by Xan Lopez.
441
442         [GTK] Support pixel tests
443         https://bugs.webkit.org/show_bug.cgi?id=31518
444
445         Convert this file from CRLF to NL line endings. It will soon
446         be used on more than just the WinCairo platform.
447
448         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
449         (writeFunction):
450         (printPNG):
451         (computeMD5HashStringForBitmapContext):
452         (dumpBitmap):
453
454 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
455
456         Reviewed by Darin Adler.
457
458         Enable Data Execution Prevention for our test harnesses on Windows
459         https://bugs.webkit.org/show_bug.cgi?id=41882
460
461         * DumpRenderTree/win/DumpRenderTree.vcproj:
462         * DumpRenderTree/win/ImageDiff.vcproj:
463         * WebKitAPITest/WebKitAPITest.vcproj:
464         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
465
466 2010-07-07  Robert Hogan  <robert@webkit.org>
467
468         Reviewed by Kenneth Rohde Christiansen.
469
470         [Qt] Add DRT support for pageProperty etc.
471
472         https://bugs.webkit.org/show_bug.cgi?id=41584
473
474         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
475         (LayoutTestController::isPageBoxVisible):
476         (LayoutTestController::pageSizeAndMarginsInPixels):
477         (LayoutTestController::pageProperty):
478         (LayoutTestController::addUserStyleSheet):
479         * DumpRenderTree/qt/LayoutTestControllerQt.h:
480
481 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
482
483         Reviewed by Xan Lopez.
484
485         Remove a warnings from the ImageDiff build by using the proper
486         printf format string for the gsize data type.
487
488         * DumpRenderTree/gtk/ImageDiff.cpp:
489         (printImage): Use the proper printf format string for the gsize data type.
490
491 2010-07-08  Alice Liu  <alice.liu@apple.com>
492
493         Reviewed by Sam Weinig.
494
495         https://bugs.webkit.org/show_bug.cgi?id=41653
496         Add new WebKitTestRunner project for Windows
497
498         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
499         Similar to how it's done in DumpRenderTree, define max and min early
500         on so that they don't get replaced by a macro requiring 2 arguments.
501
502         * WebKitTestRunner/win: Added.
503         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
504         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
505         * WebKitTestRunner/win/main.cpp: Added.
506         (main): Implemented
507
508         Added these files with stubbed out functions:
509         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
510         (WTR::PlatformWebView::PlatformWebView):
511         (WTR::PlatformWebView::~PlatformWebView):
512         (WTR::PlatformWebView::page):
513         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
514         (WTR::TestController::initializeInjectedBundlePath):
515         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
516         (WTR::TestInvocation::runUntil):
517
518 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
519
520         Reviewed by Gustavo Noronha Silva.
521
522         [GTK] Implement ImageDiff and add it to the build system
523         https://bugs.webkit.org/show_bug.cgi?id=41779
524
525         Add the initial implementation of the ImageDiff tool for the GTK+
526         port. This is an essential tool for doing pixel tests. The implementation
527         is based on the Mac and Chromium ports.
528
529         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
530         (readPixbufFromStdin): Added.
531         (differenceImageFromDifferenceBuffer): Ditto.
532         (calculateDifference): Ditto.
533         (printImage): Ditto.
534         (printImageDifferences): Ditto.
535         (main): Ditto.
536         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
537
538 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
539
540         Unreviewed. Adding myself as a committer.
541
542         * Scripts/webkitpy/common/config/committers.py:
543
544 2010-07-08  Adam Roben  <aroben@apple.com>
545
546         Make Windows stop running tests from platform/mac
547
548         r62742 made a change (at my suggestion!) that caused us to start
549         looking for tests in platform/mac, rather than just looking for
550         expected results in platform/mac. This patch just undoes that part of
551         r62742.
552
553         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
554         tests from platform/mac, but shouldn't
555
556         Reviewed by Antti Koivisto and Anders Carlsson.
557
558         * Scripts/old-run-webkit-tests:
559         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
560         so we won't look in those directories for tests to run.
561         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
562         platform/mac-snowleopard and platform/mac for expected results.
563
564 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
565
566         Unreviewed. Adding myself as a reviewer.
567
568         * Scripts/webkitpy/common/config/committers.py:
569
570 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
571
572         Update my e-mail in committers.py
573
574         * Scripts/webkitpy/common/config/committers.py:
575
576 2010-07-07  Daniel Bates  <dbates@rim.com>
577
578         Reviewed by Dumitru Daniliuc.
579
580         VCSUtils.pm complains about uninitialized value $newLine
581         https://bugs.webkit.org/show_bug.cgi?id=41333
582
583         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
584         an array when fixing a change log entry that overlaps with an earlier
585         entry. In particular, when a patch contains a change log entry inserted
586         earlier in the change log file, but after an entry with the same author
587         and date.
588
589         * Scripts/VCSUtils.pm:
590             - Added for-loop constraint to fixChangeLogPatch() so that it does not
591               read off the end of the @overlappingLines array.
592         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
593
594 2010-07-07  Anders Carlsson  <andersca@apple.com>
595
596         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
597
598         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
599         (NPP_New):
600
601 2010-07-07  Kent Tamura  <tkent@chromium.org>
602
603         Reviewed by Adam Barth.
604
605         [DRT/Chromium] Support for indeterminate checkbox
606         https://bugs.webkit.org/show_bug.cgi?id=41747
607
608         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
609
610         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
611         (WebThemeControlDRT::draw):
612         * DumpRenderTree/chromium/WebThemeControlDRT.h:
613         (WebThemeControlDRT::):
614         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
615         (WebThemeEngineDRT::paintButton):
616
617 2010-07-07  Sam Weinig  <sam@webkit.org>
618
619         Reviewed by Mark Rowe.
620
621         Clean up MiniBrowser Xcode project.
622
623         - Use xcconfig files.
624         - Rename plists to canonical Info.plist
625         - Remove localizations.
626
627         * MiniBrowser/Configurations: Added.
628         * MiniBrowser/Configurations/Base.xcconfig: Added.
629         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
630         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
631         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
632         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
633         * MiniBrowser/WebBundle-Info.plist: Removed.
634         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
635         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
636         * MiniBrowser/mac/BrowserWindow.xib: Added.
637         * MiniBrowser/mac/BrowserWindowController.m:
638         (-[BrowserWindowController initWithPageNamespace:]):
639         * MiniBrowser/mac/English.lproj: Removed.
640         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
641         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
642         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
643         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
644         * MiniBrowser/mac/MainMenu.xib: Added.
645         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
646         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
647
648 2010-07-07  Kent Tamura  <tkent@chromium.org>
649
650         Reviewed by Dimitri Glazkov.
651
652         [DRT/Chromium] Fix two regressions
653         https://bugs.webkit.org/show_bug.cgi?id=41745
654
655         * DumpRenderTree/chromium/WebViewHost.cpp:
656         (WebViewHost::paintInvalidatedRegion):
657          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
658          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
659          though test_shell does it twice. Probably DRT needs it because
660          DRT delays painting as possible.
661
662 2010-07-07  Anders Carlsson  <andersca@apple.com>
663
664         Try to fix build.
665
666         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
667         (webkit_test_plugin_destroy_stream):
668
669 2010-07-07  Anders Carlsson  <andersca@apple.com>
670
671         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
672
673         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
674         (webkit_test_plugin_new_stream):
675         (webkit_test_plugin_destroy_stream):
676         (webkit_test_plugin_write_ready):
677         (webkit_test_plugin_write):
678
679 2010-07-07  Sam Weinig  <sam@webkit.org>
680
681         Reviewed by Mark Rowe.
682
683         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
684
685         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
686
687 2010-07-07  Anders Carlsson  <andersca@apple.com>
688
689         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
690
691         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
692         (NPP_New):
693         (NPP_HandleEvent):
694
695 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
696
697         Reviewed by Adam Roben.
698
699         Need to have a way to specify different results for Windows XP and 7
700         https://bugs.webkit.org/show_bug.cgi?id=41776
701         
702         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
703         subdirectories, so we can have different results for tests on Windows XP, Windows
704         Vista, and Windows 7.
705
706         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
707         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
708         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
709
710         This matches the behavior of the mac.
711
712         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
713             or Vista, try looking in other win-* subdirectories before win.
714         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
715             we are running.
716
717 2010-07-07  Kent Tamura  <tkent@chromium.org>
718
719         Reviewed by Dimitri Glazkov.
720
721         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
722         https://bugs.webkit.org/show_bug.cgi?id=41753
723
724         The original code of the following functions in
725         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
726         ASSERT_NOT_REACHED(). The program shouldn't stop at these
727         functions.
728
729         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
730         (DRTDevToolsClient::activateWindow):
731         (DRTDevToolsClient::closeWindow):
732         (DRTDevToolsClient::dockWindow):
733         (DRTDevToolsClient::undockWindow):
734
735 2010-07-07  Anders Carlsson  <andersca@apple.com>
736
737         Reviewed by Sam Weinig.
738
739         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
740         https://bugs.webkit.org/show_bug.cgi?id=41821
741
742         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
743         (pluginGetProperty):
744         (pluginSetProperty):
745         (pluginAllocate):
746         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
747         Add and initialize the returnNegativeOneFromWrite property.
748
749         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
750         (NPP_NewStream):
751         Set the stream type to NP_NORMAL so we'll get write callbacks.
752
753         (NPP_DestroyStream):
754         Treat the onstreamdestroy attribute as a function name and not a string.
755
756         (NPP_WriteReady):
757         Have this return a nonzero value.
758
759         (NPP_Write):
760         If returnNegativeOneFromWrite is true return -1.
761
762 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
763
764         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
765         latest version is selected by default, and allows the version to be specified.
766
767         * wx/build/settings.py:
768
769 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
770
771         Reviewed by Darin Adler.
772
773         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
774         https://bugs.webkit.org/show_bug.cgi?id=41810
775
776         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
777         (AccessibilityUIElement::selectedTextRange):
778
779 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
780
781         Unreviewed.
782
783         Build fix after r62700.
784
785         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
786         source file locations.
787
788 2010-07-07  Ojan Vafai  <ojan@chromium.org>
789
790         Reviewed by David Levin.
791
792         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
793         https://bugs.webkit.org/show_bug.cgi?id=41814
794
795         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
796         * Scripts/old-run-webkit-tests:
797
798 2010-07-07  Ojan Vafai  <ojan@chromium.org>
799
800         Reviewed by David Levin.
801
802         add --exit-after-n-crashes to run-webkit-tests
803         https://bugs.webkit.org/show_bug.cgi?id=41811
804
805         Change the bots at build.webkit.org to use --exit-after-n-crashes
806         instead of --exit-after-n-failures since we want to be able to have
807         more than 20 failures on those bots, but more than 20 crashes means
808         something should be rolled out.
809
810         * Scripts/old-run-webkit-tests:
811         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
812
813 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
814
815         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
816         TestNetscapePlugin project, because this was removed from the tree.
817
818         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
819
820 2010-07-07  Anders Carlsson  <andersca@apple.com>
821
822         Reviewed by Simon Fraser.
823
824         Unify Mac and Windows TestNetscapePlugin main.cpp files
825         https://bugs.webkit.org/show_bug.cgi?id=41798
826         
827         * DumpRenderTree/DumpRenderTree.sln:
828         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
829         (strcasecmp):
830         (NP_Initialize):
831         (NP_GetEntryPoints):
832         (NP_Shutdown):
833         (NPP_New):
834         (NPP_Destroy):
835         (NPP_HandleEvent):
836         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
837         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
838
839 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
840
841         [wx] Build fix. pageProperty needs to return a value.
842
843         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
844         (LayoutTestController::pageProperty):
845
846 2010-07-07  David Kilzer  <ddkilzer@apple.com>
847
848         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
849
850         Reviewed by Anders Carlsson.
851
852         For both svn and git, commit-log-editor is invoked from the root
853         of the working directory.  Unlike svn, git returns a list of
854         changed files that are relative to the directory where the
855         command was invoked.  This caused the ChangeLog file in the root
856         directory to be read instead of the ChangeLog in the current
857         directory.
858
859         The fix is to use $ENV{PWD} as the base directory when fixing
860         the path to the ChangeLog files.  With svn, this has no net
861         effect since $ENV{PWD} is the root of the working directory and
862         the ChangeLog paths are already relative to that directory.
863         With git, $ENV{PWD} is the directory that the commit was invoked
864         from, which fixes the ChangeLog paths so that the correct files
865         are read when creating the commit log entry.
866
867         Note that the call to makeFilePathRelative() was supposed to
868         address this issue, but it doesn't because (a) it does nothing
869         with svn working directories by design, and (b) it does nothing
870         with git working directories because it's invoked when the
871         current directory is the root of the working directory, thus
872         giving no relative path.
873
874         * Scripts/commit-log-editor: Removed call to
875         makeFilePathRelative() since since it does nothing.  Moved code
876         to fix up $changeLog path so that it's fixed before trying to
877         open the file, and use $ENV{PWD} as the base path.  Also use
878         canonicalizePath() to clean up paths with "../" in them.
879
880 2010-07-07  Anders Carlsson  <andersca@apple.com>
881
882         Another attempt at fixing the Qt build.
883
884         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
885
886 2010-07-07  Anders Carlsson  <andersca@apple.com>
887
888         Try to fix Qt build.
889
890         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
891
892 2010-07-07  Anders Carlsson  <andersca@apple.com>
893
894         Reviewed by Simon Fraser.
895
896         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
897         https://bugs.webkit.org/show_bug.cgi?id=41781
898
899         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
900         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
901         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
902         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
903         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
904         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
905         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
906         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
907         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
908         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
909         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
910         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
911         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
912
913 2010-07-07  Andras Becsi  <abecsi@webkit.org>
914
915         Unreviewed trivial fix.
916
917         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
918         which was checked in accidentally in r62635.
919
920         * Scripts/webkitpy/layout_tests/port/webkit.py:
921
922 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
923
924         Reviewed by Eric Seidel.
925
926         Pass port specific environment to server process.
927         https://bugs.webkit.org/show_bug.cgi?id=41593
928
929         * Scripts/webkitpy/layout_tests/port/qt.py:
930         * Scripts/webkitpy/layout_tests/port/webkit.py:
931
932 2010-07-06  Kent Tamura  <tkent@chromium.org>
933
934         Reviewed by Shinichiro Hamaji.
935
936         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
937         https://bugs.webkit.org/show_bug.cgi?id=41644
938
939         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
940         tolerance. We don't need tolerance for rebaseline.
941
942         * Scripts/webkitpy/layout_tests/port/base.py:
943           Add optional tolerance parameter to diff_image().
944         * Scripts/webkitpy/layout_tests/port/test.py:
945           Add optional tolerance parameter to diff_image().
946         * Scripts/webkitpy/layout_tests/port/webkit.py:
947           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
948         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
949           diff_files() always calls diff_image() with tolerance=0.
950           diff_files() is used only by rebaseline-chromium-webkit-tests.
951
952 2010-07-06  Sam Weinig  <sam@webkit.org>
953
954         Fix MiniBrowser build.
955
956         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
957
958 2010-07-06  Sam Weinig  <sam@webkit.org>
959
960         Reviewed by Anders Carlsson.
961
962         Add support for dumping the contents of messages to the console to WebKitTestRunner
963
964         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
965         (WTR::InjectedBundlePage::InjectedBundlePage):
966         (WTR::InjectedBundlePage::_addMessageToConsole):
967         (WTR::InjectedBundlePage::addMessageToConsole):
968         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
969
970 2010-07-06  Sam Weinig  <sam@webkit.org>
971
972         Reviewed by Anders Carlsson.
973
974         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
975         Add dumpAsText support for WebKitTestRunner
976
977         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
978         (WTR::InjectedBundle::InjectedBundle):
979         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
980         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
981         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
982         API to dump the main frames text.
983
984 2010-07-06  Darin Adler  <darin@apple.com>
985
986         Fix Chromium build.
987
988         * DumpRenderTree/chromium/WebViewHost.cpp:
989         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
990         (WebViewHost::didNavigateWithinPage): Ditto.
991         (WebViewHost::updateURL): Ditto.
992
993 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
994
995         Reviewed by Xan Lopez.
996
997         [GTK] build-webkit should not run autogen.sh unconditionally
998         https://bugs.webkit.org/show_bug.cgi?id=41704
999
1000         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
1001         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
1002         some very minor cleanup.
1003
1004 2010-07-06  Darin Adler  <darin@apple.com>
1005
1006         Try to fix Chromium build.
1007
1008         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
1009
1010 2010-07-06  Darin Adler  <darin@apple.com>
1011
1012         Fix build.
1013
1014         * WebKitAPITest/TestsController.cpp:
1015         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
1016
1017 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1018
1019         Reviewed by Kent Tamura.
1020
1021         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1022         https://bugs.webkit.org/show_bug.cgi?id=40558
1023
1024         Upstream DevTools for Chromium DRT.
1025         (original Chromium files rev. 51287)
1026
1027         * DumpRenderTree/DumpRenderTree.gypi:
1028         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1029         (DRTDevToolsAgent::DRTDevToolsAgent):
1030         (DRTDevToolsAgent::setWebView):
1031         (DRTDevToolsAgent::sendMessageToFrontend):
1032         (DRTDevToolsAgent::forceRepaint):
1033         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1034         (DRTDevToolsAgent::injectedScriptSource):
1035         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1036         (DRTDevToolsAgent::debuggerScriptSource):
1037         (DRTDevToolsAgent::asyncCall):
1038         (DRTDevToolsAgent::call):
1039         (DRTDevToolsAgent::webDevToolsAgent):
1040         (DRTDevToolsAgent::attach):
1041         (DRTDevToolsAgent::detach):
1042         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1043         (DRTDevToolsAgent::evaluateInWebInspector):
1044         (DRTDevToolsAgent::dispatchMessageLoop):
1045         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1046         (DRTDevToolsAgent::~DRTDevToolsAgent):
1047         (DRTDevToolsAgent::hostIdentifier):
1048         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1049         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1050         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1051         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1052         (DRTDevToolsCallArgs::callsCount):
1053         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1054         (DRTDevToolsClient::DRTDevToolsClient):
1055         (DRTDevToolsClient::~DRTDevToolsClient):
1056         (DRTDevToolsClient::sendMessageToAgent):
1057         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1058         (DRTDevToolsClient::activateWindow):
1059         (DRTDevToolsClient::closeWindow):
1060         (DRTDevToolsClient::dockWindow):
1061         (DRTDevToolsClient::undockWindow):
1062         (DRTDevToolsClient::asyncCall):
1063         (DRTDevToolsClient::call):
1064         (DRTDevToolsClient::allMessagesProcessed):
1065         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1066         * DumpRenderTree/chromium/EventSender.cpp:
1067         * DumpRenderTree/chromium/LayoutTestController.cpp:
1068         (LayoutTestController::LayoutTestController):
1069         (LayoutTestController::closeWebInspector):
1070         (LayoutTestController::setTimelineProfilingEnabled):
1071         (LayoutTestController::evaluateInWebInspector):
1072         * DumpRenderTree/chromium/LayoutTestController.h:
1073         * DumpRenderTree/chromium/TestShell.cpp:
1074         (TestShell::TestShell):
1075         (TestShell::~TestShell):
1076         (TestShell::createDRTDevToolsClient):
1077         (TestShell::showDevTools):
1078         (TestShell::closeDevTools):
1079         (TestShell::runFileTest):
1080         (TestShell::createNewWindow):
1081         * DumpRenderTree/chromium/TestShell.h:
1082         (TestShell::drtDevToolsAgent):
1083         (TestShell::drtDevToolsClient):
1084         * DumpRenderTree/chromium/config.h:
1085
1086 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1087
1088         Reviewed by Eric Seidel.
1089
1090         Don't pass image hash to DRT when pixel tests are disabled.
1091         https://bugs.webkit.org/show_bug.cgi?id=41597
1092
1093         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1094
1095 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1096
1097         Reviewed by Eric Seidel.
1098
1099         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1100         https://bugs.webkit.org/show_bug.cgi?id=41612
1101
1102         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1103
1104 2010-07-05  Adam Barth  <abarth@webkit.org>
1105
1106         Reviewed by Eric Seidel.
1107
1108         We should be able to specify a bug to block for webkit-patch upload
1109         https://bugs.webkit.org/show_bug.cgi?id=41648
1110
1111         This will be useful for working on the HTML5 parser.
1112
1113         * Scripts/webkitpy/tool/steps/createbug.py:
1114         * Scripts/webkitpy/tool/steps/options.py:
1115
1116 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1117
1118         Reviewed by Oliver Hunt.
1119
1120         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1121         https://bugs.webkit.org/show_bug.cgi?id=41017
1122
1123         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1124         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1125
1126 2010-07-04  MORITA Hajime  <morrita@google.com>
1127
1128         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1129         https://bugs.webkit.org/show_bug.cgi?id=41589
1130
1131         * run() method can result non-utf-8 bytes, that causes utf-8
1132           decoding fail.  Fixed to disable decoding.
1133         * Fixed Git.find_checkout_root() to make a test pass.
1134
1135         * Scripts/webkitpy/common/checkout/scm.py:
1136         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1137
1138 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1139
1140         Reviewed by Simon Hausmann.
1141
1142         [Qt] Fix DumpRenderTree userStyleSheet handling.
1143         https://bugs.webkit.org/show_bug.cgi?id=41570
1144
1145         DumpRenderTree did only set the userStyleSheet at
1146         layoutTestController.setUserStyleSheetEnabled().
1147
1148         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1149         (LayoutTestController::reset):
1150         (LayoutTestController::setUserStyleSheetLocation):
1151         (LayoutTestController::setUserStyleSheetEnabled):
1152         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1153
1154 2010-07-03  Robert Hogan  <robert@webkit.org>
1155
1156         Reviewed by Kenneth Rohde Christiansen.
1157
1158         [Qt] support dumpChildFrameScrollPositions
1159
1160         https://bugs.webkit.org/show_bug.cgi?id=41088
1161
1162         Unskip:
1163
1164         http/tests/navigation/anchor-subframeload.html
1165         http/tests/navigation/relativeanchor-frames.html
1166
1167         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1168         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1169         (WebCore::DumpRenderTree::dump):
1170         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1171         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1172         (LayoutTestController::reset):
1173         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1174         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1175         (LayoutTestController::dumpChildFrameScrollPositions):
1176
1177 2010-07-02  Sam Weinig  <sam@webkit.org>
1178
1179         Reviewed by Anders Carlsson.
1180
1181         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1182
1183         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1184         * Scripts/debug-webkittestrunner: Removed.
1185         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1186         * Scripts/run-webkittestrunner: Removed.
1187
1188 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1189
1190         Reviewed by Steve Falkenburg.
1191
1192         Some http tests fail on Windows with Cygwin 1.7
1193         https://bugs.webkit.org/show_bug.cgi?id=41537
1194         
1195         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1196         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1197         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1198
1199         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1200         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1201             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1202
1203 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1204
1205         Reviewed by Gustavo Noronha Silva.
1206
1207         [GTK] Separate DerivedSources per-project
1208         https://bugs.webkit.org/show_bug.cgi?id=41109
1209
1210         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1211         allowing the tools to build as a side-effect. Now that the top-level directory
1212         is no longer in the list of JavaScriptCore includes, include it explicitly.
1213
1214         * GNUmakefile.am:
1215
1216 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1217
1218         Reviewed by Kenneth Rohde Christiansen.
1219
1220         [Qt] Make context menus show up in the right place in QTestBrowser
1221
1222         Context menus were shown at scene-relative coordinates for
1223         QGraphicsWebView while QMenu expects them to be global. The
1224         change to the QWidget case was to get rid of the mapToGlobal.
1225
1226         * QtTestBrowser/webview.cpp:
1227
1228 2010-07-01  Robert Hogan <robert@webkit.org>
1229
1230         Reviewed by Kenneth Rohde Christiansen.
1231
1232         [Qt] dump frames in ascending alphabetical order of title
1233
1234         https://bugs.webkit.org/show_bug.cgi?id=41261
1235
1236         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1237         (WebCore::dumpHistoryItem):
1238
1239 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1240
1241         Unreviewed. 
1242
1243         Fix the GTK+ build after r62278.
1244
1245         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1246         let them override the automatic CPU detection for autotools builds.
1247
1248 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1249
1250         Unreviewed.
1251
1252         Fix the Windows build after r62278.
1253
1254         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1255
1256 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1257
1258         Reviewed by Gustavo Noronha Silva.
1259
1260         [GTK] build-webkit does not detect the number of CPUs
1261         https://bugs.webkit.org/show_bug.cgi?id=41469
1262
1263         Pass the appropriate -j<#> flag to make when building autotools builds.
1264         This causes make to spawn that many number of child processes for doing
1265         parallel builds.
1266
1267         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1268         of CPUs. This makes the script work across more platforms.
1269         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1270         number of CPUs across several platforms. Use this new function to determine the appropriate
1271         arguments to pass to make for doing parallel builds with autotools build files.
1272
1273 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1274
1275         Rubber-stamped by Laszlo Gombos.
1276
1277         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1278
1279         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1280         and use the one from WebKit.pri instead.
1281
1282 2010-07-01  Adam Barth  <abarth@webkit.org>
1283
1284         Reviewed by Eric Seidel.
1285
1286         Promote webkit-patch land-safely to main help
1287         https://bugs.webkit.org/show_bug.cgi?id=41446
1288
1289         I've been using this command a bunch and recommending it to folks.  We
1290         should show it in main help as it's past the experimental phase.
1291
1292         * Scripts/webkitpy/tool/commands/upload.py:
1293
1294 2010-06-28  MORITA Hajime  <morrita@google.com>
1295
1296         Reviewed by Shinichiro Hamaji.
1297
1298         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1299         https://bugs.webkit.org/show_bug.cgi?id=38775
1300
1301         - Introduced SCM.show_head() and SCM.diff_for_file().
1302         - Replaced direct svn invocations with newly implement SCM methods.
1303
1304         * Scripts/webkitpy/common/checkout/scm.py:
1305         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1306         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1307
1308 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1309
1310         Reviewed by Sam Weinig.
1311
1312         Allow MiniBrowser to open local files
1313         https://bugs.webkit.org/show_bug.cgi?id=41104
1314
1315         Wire up the openDocument: message with an NSOpenPanel, so we can open
1316         local files.
1317         
1318         Also change the xib so that the window remembers its size.
1319         
1320         * MiniBrowser/mac/AppDelegate.m:
1321         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1322         (-[BrowserAppDelegate openDocument:]):
1323         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1324         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1325
1326 2010-06-30  Sam Weinig  <sam@webkit.org>
1327
1328         Rubber-stamped by Anders Carlsson.
1329
1330         Add debug-webkittestrunner and cleanup related scripts.
1331
1332         * Scripts/debug-webkittestrunner: Added.
1333         * Scripts/run-webkittestrunner:
1334         * Scripts/webkitdirs.pm:
1335
1336 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1337
1338         [wx] Build fix after recent changes to LayoutTestController.
1339
1340         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1341         (LayoutTestController::pageSizeAndMarginsInPixels):
1342
1343 2010-06-29  Sam Weinig  <sam@webkit.org>
1344
1345         Reviewed by Anders Carlsson.
1346
1347         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1348         Make WebKitTestRunner work with more than one test at a time.
1349
1350         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1351         where there is a single WKView and each test is run it, rather than
1352         the design I was using where each test got its own WKView.
1353
1354         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1355         (WTR::InjectedBundle::didRecieveMessage):
1356         (WTR::InjectedBundle::reset):
1357         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1358         * WebKitTestRunner/TestController.cpp:
1359         (WTR::TestController::initialize):
1360         (WTR::TestController::runTest):
1361         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1362         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1363         * WebKitTestRunner/TestController.h:
1364         (WTR::TestController::mainWebView):
1365         (WTR::TestController::pageNamespace):
1366         (WTR::TestController::context):
1367         * WebKitTestRunner/TestInvocation.cpp:
1368         (WTR::TestInvocation::TestInvocation):
1369         (WTR::TestInvocation::~TestInvocation):
1370         (WTR::TestInvocation::invoke):
1371         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1372         * WebKitTestRunner/TestInvocation.h:
1373
1374 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1375
1376         Reviewed by Laszlo Gombos.
1377
1378         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1379         https://bugs.webkit.org/show_bug.cgi?id=40446
1380
1381         We quickly run out of memory on Symbian when loading web pages. This is
1382         caused by the default heap size, which is not suited for a web browser.
1383
1384         This change bumps the max heap size to 32MB.
1385
1386         * QtTestBrowser/QtTestBrowser.pro:
1387
1388 2010-06-30  Eric Seidel  <eric@webkit.org>
1389
1390         Reviewed by Adam Barth.
1391
1392         webkit-patch land allow the user to continue even if the builders are red
1393         https://bugs.webkit.org/show_bug.cgi?id=41395
1394
1395         I don't think it's good that we've been teaching people
1396         to always pass --ignore-builders.  At least land is now
1397         useable w/o --ignore-builders.
1398
1399         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1400
1401 2010-06-29  Robert Hogan  <robert@webkit.org>
1402
1403         Reviewed by Kenneth Rohde Christiansen.
1404
1405         [Qt] support dumpResourceResponseMIMETypes
1406         https://bugs.webkit.org/show_bug.cgi?id=41260
1407
1408         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1409         (LayoutTestController::reset):
1410         (LayoutTestController::dumpResourceResponseMIMETypes):
1411         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1412
1413 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1414
1415         Reviewed by Kenneth Rohde Christiansen.
1416
1417         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1418         https://bugs.webkit.org/show_bug.cgi?id=41173
1419
1420         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1421         (WebCore::WebPage::setViewGeometry):
1422         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1423
1424 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1425
1426         Reviewed by Simon Hausmann.
1427
1428         [Qt] Deal with postEvent in case of graphics based DRT
1429         https://bugs.webkit.org/show_bug.cgi?id=41174
1430
1431         QGraphicsScene does not have a postEvent method, so make scene
1432         send the event, in case of graphics based DRT, and delete it after that.
1433
1434         * DumpRenderTree/qt/EventSenderQt.cpp:
1435         (EventSender::scheduleAsynchronousClick):
1436         (EventSender::replaySavedEvents):
1437         (EventSender::postEvent):
1438         * DumpRenderTree/qt/EventSenderQt.h:
1439
1440 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1441
1442         Reviewed by Kenneth Rohde Christiansen.
1443
1444         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1445         https://bugs.webkit.org/show_bug.cgi?id=41172
1446
1447         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1448         (WebCore::DumpRenderTree::switchFocus):
1449
1450 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1451
1452         Reviewed by Xan Lopez.
1453
1454         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1455         https://bugs.webkit.org/show_bug.cgi?id=40009
1456
1457         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1458         are used when returning those values, for coherency with other ports.
1459
1460         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1461         (AccessibilityUIElement::role):
1462         (AccessibilityUIElement::title):
1463         (AccessibilityUIElement::description):
1464
1465 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1466
1467         Unreviewed, rolling out r62106.
1468         http://trac.webkit.org/changeset/62106
1469         https://bugs.webkit.org/show_bug.cgi?id=41346
1470
1471         "Broke editing tests" (Requested by xan_ on #webkit).
1472
1473         * Scripts/old-run-webkit-tests:
1474
1475 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1476
1477         Reviewed by Xan Lopez.
1478
1479         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1480         https://bugs.webkit.org/show_bug.cgi?id=38648
1481
1482         Add the GTK_MODULES envvar (set to "gail") to the clean
1483         environment when running DRT for the Gtk+ port
1484
1485         * Scripts/old-run-webkit-tests:
1486
1487 2010-06-28  Adam Barth  <abarth@webkit.org>
1488
1489         Unreviewed.
1490
1491         Switch test-html5-parser back to using runner.html.
1492
1493         * Scripts/test-html5-parser:
1494
1495 2010-06-28  Adam Barth  <abarth@webkit.org>
1496
1497         Reviewed by Eric Seidel.
1498
1499         Restore webkit-runner.html for use with new tree builder
1500         https://bugs.webkit.org/show_bug.cgi?id=41317
1501
1502         For now, we just want to run webkit-runner when we test-html5-parser.
1503
1504         * Scripts/test-html5-parser:
1505
1506 2010-06-23  John Gregg  <johnnyg@google.com>
1507
1508         Reviewed by Kent Tamura.
1509
1510         add ENABLE_DIRECTORY_UPLOAD build support
1511         https://bugs.webkit.org/show_bug.cgi?id=41100
1512
1513         * Scripts/build-webkit:
1514
1515 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1516
1517         Rubber-stamped by Xan Lopez.
1518
1519         Update webkitdirs's knowledge of our library's name.
1520
1521         * Scripts/webkitdirs.pm:
1522
1523 2010-06-28  Sam Weinig  <sam@webkit.org>
1524
1525         Reviewed by Anders Carlsson.
1526
1527         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1528         Build up WebKitTestRunner output in the InjectedBundle
1529
1530         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1531         and sending it over postMessage when done, instead of using the async
1532         WKPageRenderTreeExternalRepresentation.
1533
1534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1535         (WTR::InjectedBundle::done):
1536         (WTR::InjectedBundle::didRecieveMessage):
1537         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1538         (WTR::InjectedBundle::os):
1539         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1540         (WTR::WKStringToUTF8):
1541         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1542         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1543         * WebKitTestRunner/TestInvocation.cpp:
1544         (WTR::WKStringToUTF8):
1545         (WTR::TestInvocation::TestInvocation):
1546         (WTR::TestInvocation::invoke):
1547         (WTR::TestInvocation::initializeMainWebView):
1548         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1549         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1550         * WebKitTestRunner/TestInvocation.h:
1551
1552 2010-06-28  Robert Hogan  <robert@webkit.org>
1553
1554         Unreviewed, rolling out r62021.
1555         http://trac.webkit.org/changeset/62021
1556         https://bugs.webkit.org/show_bug.cgi?id=41261
1557
1558         Broke http/navigation tests among other
1559
1560         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1561         (WebCore::DumpRenderTree::dumpFramesAsText):
1562
1563 2010-06-28  Sam Weinig  <sam@webkit.org>
1564
1565         Reviewed by Anders Carlsson.
1566
1567         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1568         environment.
1569
1570         * Scripts/run-webkittestrunner: Added.
1571         * Scripts/webkitdirs.pm:
1572
1573 2010-06-28  Robert Hogan  <robert@webkit.org>
1574
1575         Reviewed by Kenneth Rohde Christiansen.
1576
1577         [Qt] dump frames in ascending alphabetical order of title
1578
1579         https://bugs.webkit.org/show_bug.cgi?id=41261
1580
1581         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1582         (WebCore::DumpRenderTree::dumpFramesAsText):
1583
1584 2010-06-28  Robert Hogan  <robert@webkit.org>
1585
1586         Reviewed by Kenneth Rohde Christiansen.
1587
1588         [Qt] dump bf history of child windows
1589
1590         https://bugs.webkit.org/show_bug.cgi?id=41266
1591
1592         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1593         (WebCore::DumpRenderTree::dumpBackForwardList):
1594         (WebCore::DumpRenderTree::dump):
1595         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1596
1597 2010-06-28  Sam Weinig  <sam@webkit.org>
1598
1599         Reviewed by Anders Carlsson.
1600
1601         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1602         WebKit2: Add frame API for InjectedBundle code
1603
1604         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1605         (_didClearWindowForFrame):
1606
1607 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1608
1609         Reviewed by Kenneth Rohde Christiansen.
1610
1611         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1612         https://bugs.webkit.org/show_bug.cgi?id=38597
1613
1614         Fix behavior so reload button really acts as a load and a reload button.
1615
1616         * QtTestBrowser/mainwindow.cpp:
1617         (MainWindow::changeLocation):
1618
1619 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1620
1621         Reviewed by Gustavo Noronha.
1622
1623         [GTK] Does not compile with -DGSEAL_ENABLE
1624         https://bugs.webkit.org/show_bug.cgi?id=37851
1625
1626         Fix build with GSEAL enabled.
1627
1628         * DumpRenderTree/gtk/EventSender.cpp:
1629         (gtk_widget_get_window):
1630         (prepareMouseButtonEvent):
1631         (mouseMoveToCallback):
1632         (mouseWheelToCallback):
1633         (keyDownCallback):
1634
1635 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1636
1637         Reviewed by Gustavo Noronha.
1638
1639         [GTK] Add support for GTK+3
1640         https://bugs.webkit.org/show_bug.cgi?id=41253
1641
1642         Adapt build system for 3.x support.
1643
1644         * GNUmakefile.am:
1645
1646 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1647
1648         Reviewed by Simon Hausmann.
1649
1650         [QT][S60] build-webkit scripts picks wrong make spec for windows build
1651         https://bugs.webkit.org/show_bug.cgi?id=41198
1652
1653         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
1654
1655         * Scripts/webkitdirs.pm:
1656         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
1657
1658 2010-06-28  Eric Seidel  <eric@webkit.org>
1659
1660         Reviewed by Adam Barth.
1661
1662         Make it possible to test the new HTML5 TreeBuilder
1663         https://bugs.webkit.org/show_bug.cgi?id=41276
1664
1665         Adam was concerned that someone might make their port
1666         depend on this setting (I guess we had some trouble with that
1667         with the HTML5Parser setting), so I littered the code with warnings.
1668
1669         test-html5-parser now tests this code path.
1670
1671         * DumpRenderTree/mac/DumpRenderTree.mm:
1672         (resetDefaultsToConsistentValues):
1673         (initializeGlobalsFromCommandLineOptions):
1674         * Scripts/test-html5-parser:
1675
1676 2010-06-27  MORITA Hajime  <morrita@google.com>
1677
1678         Unreviewed. 
1679         
1680         Some never-called @staticmethods touched self. 
1681         Fixed it to replace these self with a class.
1682
1683         * Scripts/webkitpy/common/checkout/scm.py:
1684
1685 2010-06-27  MORITA Hajime  <morrita@google.com>
1686
1687         Unreviewed.
1688         
1689         Fixed exception raising syntax that is pointed out at
1690         https://bugs.webkit.org/show_bug.cgi?id=41153
1691
1692         * Scripts/webkitpy/common/checkout/scm.py:
1693         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
1694           Removed a bad line that I accidentally checked-in at last revision.
1695
1696 2010-06-24  MORITA Hajime  <morrita@google.com>
1697
1698         Reviewed by Eric Seidel.
1699
1700         rebaseline-chromium-webkit-tests should add or remove files to local git repository
1701         https://bugs.webkit.org/show_bug.cgi?id=41153
1702
1703         - Added SCM.add() and SCM.remove()
1704         - Replaced "svn add" and "svn remove"
1705           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
1706         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
1707           for debugging purpose.
1708
1709         * Scripts/webkitpy/common/checkout/scm.py:
1710         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1711         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1712
1713 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
1714
1715         Reviewed by Shinichiro Hamaji.
1716
1717         Improve default value handling for page format properties.
1718         https://bugs.webkit.org/show_bug.cgi?id=41150
1719
1720         * DumpRenderTree/LayoutTestController.cpp:
1721         (parsePageNumber):
1722         (parsePageNumberSizeMarings):
1723         (pageSizeAndMarginsInPixelsCallback):
1724         (LayoutTestController::staticFunctions):
1725         * DumpRenderTree/LayoutTestController.h:
1726         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1727         (LayoutTestController::pageSizeAndMarginsInPixels):
1728         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1729         (LayoutTestController::pageSizeAndMarginsInPixels):
1730         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1731         (LayoutTestController::pageSizeAndMarginsInPixels):
1732
1733 2010-06-21  Robert Hogan  <robert@webkit.org>
1734
1735         Reviewed by Kenneth Rohde Christiansen.
1736
1737         [Qt] DRT Support for setCustomPolicyDelegate
1738
1739         https://bugs.webkit.org/show_bug.cgi?id=39564
1740
1741         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1742         (LayoutTestController::setCustomPolicyDelegate):
1743         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1744
1745 2010-06-26  Robert Hogan  <robert@webkit.org>
1746
1747         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
1748         
1749         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
1750         exported.
1751
1752         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1753
1754 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
1755
1756         Reviewed by Dimitri Glazkov.
1757
1758         Add a build-webkit option for enabling Web Timing support.
1759         https://bugs.webkit.org/show_bug.cgi?id=38924
1760
1761         * Scripts/build-webkit:
1762
1763 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1764
1765         Reviewed by Kenneth Rohde Christiansen.
1766
1767         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1768         https://bugs.webkit.org/show_bug.cgi?id=38597
1769
1770         Make the reload button act as a load button as well.
1771
1772         * QtTestBrowser/mainwindow.cpp:
1773         (MainWindow::buildUI):
1774         (MainWindow::changeLocation):
1775
1776 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
1777
1778         Reviewed by Dmitry Titov.
1779
1780         Add empty abortModal() method to all platforms.
1781         https://bugs.webkit.org/show_bug.cgi?id=40864
1782
1783         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
1784         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
1785         that use abortModal will become mac specific which is not desirable.
1786
1787         * DumpRenderTree/LayoutTestController.cpp:
1788         (abortModalCallback):
1789         (LayoutTestController::staticFunctions):
1790         * DumpRenderTree/LayoutTestController.h:
1791         * DumpRenderTree/chromium/LayoutTestController.cpp:
1792         (LayoutTestController::LayoutTestController):
1793         (LayoutTestController::abortModal):
1794         * DumpRenderTree/chromium/LayoutTestController.h:
1795         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1796         (LayoutTestController::abortModal):
1797         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1798         (LayoutTestController::abortModal):
1799         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1800         (LayoutTestController::abortModal):
1801         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1802         (LayoutTestController::abortModal):
1803
1804 2010-06-25  Sam Weinig  <sam@webkit.org>
1805
1806         Reviewed by Anders Carlsson.
1807
1808         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
1809         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
1810
1811         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
1812         (WTR::InjectedBundle::shared):
1813         (WTR::InjectedBundle::InjectedBundle):
1814         (WTR::InjectedBundle::_didCreatePage):
1815         (WTR::InjectedBundle::_willDestroyPage):
1816         (WTR::InjectedBundle::_didRecieveMessage):
1817         (WTR::InjectedBundle::initialize):
1818         (WTR::InjectedBundle::didCreatePage):
1819         (WTR::InjectedBundle::willDestroyPage):
1820         (WTR::InjectedBundle::didRecieveMessage):
1821         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
1822         (WTR::InjectedBundle::layoutTestController):
1823         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1824         (WKBundleInitialize):
1825         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
1826         (WTR::InjectedBundlePage::InjectedBundlePage):
1827         (WTR::InjectedBundlePage::~InjectedBundlePage):
1828         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
1829         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
1830         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
1831         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
1832         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
1833         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
1834         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
1835         (WTR::InjectedBundlePage::_didClearWindowForFrame):
1836         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1837         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1838         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1839         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1840         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1841         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1842         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1843         (WTR::InjectedBundlePage::didClearWindowForFrame):
1844         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
1845         (WTR::InjectedBundlePage::page):
1846         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
1847         (WTR::LayoutTestController::create):
1848         (WTR::LayoutTestController::LayoutTestController):
1849         (WTR::LayoutTestController::~LayoutTestController):
1850         (WTR::dumpAsTextCallback):
1851         (WTR::layoutTestControllerObjectFinalize):
1852         (WTR::LayoutTestController::makeWindowObject):
1853         (WTR::LayoutTestController::getJSClass):
1854         (WTR::LayoutTestController::staticFunctions):
1855         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
1856         (WTR::LayoutTestController::dumpAsText):
1857         (WTR::LayoutTestController::setDumpAsText):
1858         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1859
1860 2010-06-25  Sam Weinig  <sam@webkit.org>
1861
1862         Reviewed by Anders Carlsson.
1863
1864         Make WebKitTestRunner really work with run-webkit-tests. 
1865
1866         - Add Forwarding headers to allow some cleanup.
1867
1868         * WebKitTestRunner/ForwardingHeaders: Added.
1869         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
1870         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
1871         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
1872         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
1873         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
1874         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
1875         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
1876         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
1877         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
1878         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
1879         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
1880         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
1881         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
1882         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
1883         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
1884         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
1885         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
1886         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
1887         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
1888         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
1889         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
1890         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
1891         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
1892         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
1893         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
1894         * WebKitTestRunner/TestInvocation.cpp:
1895         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
1896         * WebKitTestRunner/TestInvocation.h:
1897
1898 2010-06-25  Sam Weinig  <sam@webkit.org>
1899
1900         Reviewed by Mark Rowe.
1901
1902         Add support for WebKitTestRunner to old-run-webkit-tests
1903
1904         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
1905
1906         * Scripts/build-webkittestrunner: Added.
1907         * Scripts/old-run-webkit-tests:
1908
1909 2010-06-25  Adam Barth  <abarth@webkit.org>
1910
1911         Reviewed by David Levin.
1912
1913         Incremental build failed on Chromium ews
1914         https://bugs.webkit.org/show_bug.cgi?id=41011
1915
1916         The division of responsibility between update-webkit --chromium and
1917         build-webkit --chromium is slightly unclear.  In this patch, we make
1918         build-webkit --chromium also update DEPS and re-run GYP in case the
1919         developer has changed either since they updated.
1920
1921         This change is also helpful for the EWS, which wants to update DEPS and
1922         re-run GYP after applying patches, but the EWS doesn't want to run
1923         update-webkit --chromium because it has a dirty working copy.
1924
1925         * Scripts/webkitdirs.pm:
1926
1927 2010-06-25  Robert Hogan  <robert@webkit.org>
1928
1929         Reviewed by Simon Hausmann.
1930
1931         [Qt] Support evaluateScriptInIsolatedWorld()
1932
1933         https://bugs.webkit.org/show_bug.cgi?id=40079
1934
1935         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
1936         Remove QWebScriptWorld from exported headers.
1937         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
1938
1939         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1940         (LayoutTestController::reset):
1941         (LayoutTestController::evaluateScriptInIsolatedWorld):
1942         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1943
1944 2010-06-25  Anders Carlsson  <andersca@apple.com>
1945
1946         Revert accidental part and add a newline.
1947
1948         * MiniBrowser/mac/AppDelegate.m:
1949         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1950
1951 2010-06-25  Anders Carlsson  <andersca@apple.com>
1952
1953         Rubber-stamped by Dan Bernstein.
1954
1955         Add a LOG macro that expands to a no-op by default.
1956
1957         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1958         * MiniBrowser/mac/AppDelegate.m:
1959         (_didRecieveMessageFromInjectedBundle):
1960         * MiniBrowser/mac/BrowserWindowController.m:
1961         (-[BrowserWindowController windowShouldClose:]):
1962         (_didStartProvisionalLoadForFrame):
1963         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1964         (_didFailProvisionalLoadWithErrorForFrame):
1965         (_didCommitLoadForFrame):
1966         (_didFinishLoadForFrame):
1967         (_didFailLoadWithErrorForFrame):
1968         (_didReceiveTitleForFrame):
1969         (_didFirstLayoutForFrame):
1970         (_didFirstVisuallyNonEmptyLayoutForFrame):
1971         (_didBecomeUnresponsive):
1972         (_didBecomeResponsive):
1973         (_decidePolicyForNavigationAction):
1974         (_decidePolicyForNewWindowAction):
1975         (_createNewPage):
1976         (_showPage):
1977         (_closePage):
1978         (_didNavigateWithNavigationData):
1979         (_didPerformClientRedirect):
1980         (_didPerformServerRedirect):
1981         (_didUpdateHistoryTitle):
1982         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1983         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1984         (_didClearWindowForFrame):
1985         (_didCreatePage):
1986         (_willDestroyPage):
1987         (_didRecieveMessage):
1988
1989 2010-06-24  Adam Barth  <abarth@webkit.org>
1990
1991         Reviewed by Eric Seidel.
1992
1993         commit-queue is taking too long to land patches because of red trees
1994         https://bugs.webkit.org/show_bug.cgi?id=41194
1995
1996         Instead of checking for the tree to be green, we'll just spin hot
1997         trying to land patches.  This is probably too extreme in ignoring the
1998         tree, but I think we should try it for a while to see if we have
1999         trouble.  That will help us find the right balance.
2000
2001         * Scripts/webkitpy/tool/commands/queues.py:
2002         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2003
2004 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2005
2006         Reviewed by Xan Lopez.
2007
2008         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
2009         https://bugs.webkit.org/show_bug.cgi?id=40843
2010
2011         Define the version for old GTK+s in a way that is forward-compatible
2012         and clean up the logic a bit.
2013
2014         * DumpRenderTree/gtk/EventSender.cpp:
2015         (gdk_window_get_root_coords): Renamed and cleaned up.
2016         (prepareMouseButtonEvent): Remove #ifdefs.
2017         (mouseMoveToCallback): Remove #ifdefs.
2018
2019 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2020
2021         Reviewed by Eric Seidel.
2022
2023         Fix NewRunWebKitTests to work on Windows.
2024         https://bugs.webkit.org/show_bug.cgi?id=41180
2025
2026         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2027             because Windows fails to understand what we're asking of it.
2028
2029 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2030
2031         Reviewed by Xan Lopez.
2032
2033         [GTK] The url passed to the WebView during layout tests is invalid
2034         https://bugs.webkit.org/show_bug.cgi?id=40832
2035
2036         Set the test URL to the full real file URL and do a small cleanup.
2037         Previously a URL like file://relative/path/to/test.html was passed
2038         to the WebView. This malformed file URL would be returned by
2039         webkit_web_view_get_url and webkit_web_frame_get_url.
2040
2041         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2042         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2043         (shouldOpenWebInspector): Change to take a const string& as the argument.
2044         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2045         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2046
2047 2010-06-24  Sam Weinig  <sam@webkit.org>
2048
2049         Reviewed by Anders Carlsson.
2050
2051         Fix WebKitTestRunner Makefile typos.
2052
2053         * WebKitTestRunner/Makefile:
2054
2055 2010-06-24  Adele Peterson  <adele@apple.com>
2056
2057         Reviewed by Eric Carlson.
2058
2059         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2060         https://bugs.webkit.org/show_bug.cgi?id=41085
2061
2062         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2063         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2064
2065 2010-06-23  Sam Weinig  <sam@webkit.org>
2066
2067         Reviewed by Anders Carlsson.
2068
2069         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2070         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2071
2072         - Mac only.
2073         - run-webkit-tests has not been modified to call it yet.
2074         - Only dumps the render tree at this time. 
2075
2076         * WebKitTestRunner: Added.
2077         * WebKitTestRunner/Configurations: Added.
2078         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2079         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2080         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2081         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2082         * WebKitTestRunner/InjectedBundle: Added.
2083         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2084         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2085         (_didStartProvisionalLoadForFrame):
2086         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2087         (_didFailProvisionalLoadWithErrorForFrame):
2088         (_didCommitLoadForFrame):
2089         (_didFinishLoadForFrame):
2090         (_didFailLoadWithErrorForFrame):
2091         (_didReceiveTitleForFrame):
2092         (_didClearWindow):
2093         (_didCreatePage):
2094         (_willDestroyPage):
2095         (_didRecieveMessage):
2096         (WKBundleInitialize):
2097         * WebKitTestRunner/Makefile: Added.
2098         * WebKitTestRunner/PlatformWebView.h: Added.
2099         (WTR::PlatformWebView::platformView):
2100         * WebKitTestRunner/TestController.cpp: Added.
2101         (WTR::TestController::shared):
2102         (WTR::TestController::TestController):
2103         (WTR::TestController::initialize):
2104         (WTR::TestController::runTest):
2105         (WTR::TestController::runTestingServerLoop):
2106         (WTR::TestController::run):
2107         * WebKitTestRunner/TestController.h: Added.
2108         (WTR::TestController::verbose):
2109         (WTR::TestController::injectedBundlePath):
2110         * WebKitTestRunner/TestInvocation.cpp: Added.
2111         (WTR::createWKURL):
2112         (WTR::TestInvocation::TestInvocation):
2113         (WTR::TestInvocation::~TestInvocation):
2114         (WTR::TestInvocation::invoke):
2115         (WTR::TestInvocation::dump):
2116         (WTR::TestInvocation::initializeMainWebView):
2117         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2118         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2119         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2120         (WTR::TestInvocation::didCommitLoadForFrame):
2121         (WTR::TestInvocation::didFinishLoadForFrame):
2122         (WTR::TestInvocation::didFailLoadForFrame):
2123         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2124         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2125         * WebKitTestRunner/TestInvocation.h: Added.
2126         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2127         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2128         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2129         * WebKitTestRunner/mac: Added.
2130         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2131         (WTR::PlatformWebView::PlatformWebView):
2132         (WTR::PlatformWebView::~PlatformWebView):
2133         (WTR::PlatformWebView::page):
2134         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2135         (WTR::TestInvocation::runUntil):
2136         * WebKitTestRunner/mac/main.mm: Added.
2137         (main):
2138
2139 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2140
2141         Unreviewed. Adding myself to the committers list.
2142
2143         * Scripts/webkitpy/common/config/committers.py:
2144
2145 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2146
2147         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2148
2149         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2150         (LayoutTestController::isPageBoxVisible):
2151         (LayoutTestController::pageAreaRectInPixels):
2152         (LayoutTestController::preferredPageSizeInPixels):
2153         * wx/build/settings.py:
2154
2155 2010-06-23  James Robinson  <jamesr@chromium.org>
2156
2157         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2158
2159         * Scripts/webkitpy/common/config/committers.py:
2160
2161 2010-06-23  Kent Tamura  <tkent@chromium.org>
2162
2163         Reviewed by Dimitri Glazkov.
2164
2165         Correct Chromium test configuration
2166         https://bugs.webkit.org/show_bug.cgi?id=41057
2167
2168         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2169          - Add "--use-drt" option for NRWT. It is required for Chromium and
2170            ignored for other platforms.
2171          - Skip JSC test on Chromium
2172         * BuildSlaveSupport/test-result-archive:
2173           Add Chromium support.
2174
2175 2010-06-23  Sam Weinig  <sam@webkit.org>
2176
2177         Reviewed by Anders Carlsson.
2178
2179         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2180         WebKit2: Flesh out more of the InjectedBundle client API
2181
2182         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2183         (_didStartProvisionalLoadForFrame):
2184         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2185         (_didFailProvisionalLoadWithErrorForFrame):
2186         (_didCommitLoadForFrame):
2187         (_didFinishLoadForFrame):
2188         (_didFailLoadWithErrorForFrame):
2189         (_didReceiveTitleForFrame):
2190         (_didClearWindowForFrame):
2191         (_didCreatePage):
2192         (_willDestroyPage):
2193         (WKBundleInitialize):
2194
2195 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2196
2197         Reviewed by Shinichiro Hamaji.
2198
2199         Implement page format data programming interface.
2200         Add methods for testing.
2201         https://bugs.webkit.org/show_bug.cgi?id=37538
2202
2203         * DumpRenderTree/LayoutTestController.cpp:
2204         (parsePageNumber):
2205         (isPageBoxVisibleCallback):
2206         (pageAreaRectInPixelsCallback):
2207         (preferredPageSizeInPixelsCallback):
2208         (LayoutTestController::staticFunctions):
2209         * DumpRenderTree/LayoutTestController.h:
2210         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2211         (LayoutTestController::isPageBoxVisible):
2212         (LayoutTestController::pageAreaRectInPixels):
2213         (LayoutTestController::preferredPageSizeInPixels):
2214         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2215         (LayoutTestController::isPageBoxVisible):
2216         (LayoutTestController::pageAreaRectInPixels):
2217         (LayoutTestController::preferredPageSizeInPixels):
2218         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2219         (LayoutTestController::isPageBoxVisible):
2220         (LayoutTestController::pageAreaRectInPixels):
2221         (LayoutTestController::preferredPageSizeInPixels):
2222
2223 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2224
2225         Reviewed by Shinichiro Hamaji.
2226
2227         Follow proper convention for if/switch/while as I've discovered
2228         them to be through my review processes.
2229         https://bugs.webkit.org/show_bug.cgi?id=40723
2230
2231         Modified test so that if( foo ) is not allowed as it appears not
2232         to be the accepted convention.
2233
2234         * Scripts/webkitpy/style/checkers/cpp.py:
2235         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2236
2237 2010-06-22  Eric Seidel  <eric@webkit.org>
2238
2239         Reviewed by Adam Barth.
2240
2241         Run clean-header-guards to fix some header guards
2242         https://bugs.webkit.org/show_bug.cgi?id=41044
2243
2244         No functional changes, thus no tests.
2245
2246         This entire change was generated by running
2247         clean-header-guards, and then reverting changes
2248         to files which shouldn't be changed.  Those which
2249         are left all should be updated.
2250
2251         Some of these changes are just fixing 755 permissions
2252         to be 644, since it seems various files have the wrong
2253         execute bit which don't need it.  clean-header-guards
2254         made those (welcome) permission fixes unintentionally.
2255
2256         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2257         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2258         * QtTestBrowser/fpstimer.h:
2259
2260 2010-06-22  Adam Barth  <abarth@webkit.org>
2261
2262         Reviewed by Eric Seidel.
2263
2264         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2265         https://bugs.webkit.org/show_bug.cgi?id=41043
2266
2267         Update the hash.
2268
2269         * Scripts/do-webcore-rename:
2270
2271 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2272
2273         Reviewed by Shinichiro Hamaji.
2274
2275         Follow proper convention for variable declaration spacing.
2276         https://bugs.webkit.org/show_bug.cgi?id=40724
2277
2278         Modified test so that 'int   a;' is not allowed.
2279
2280         * Scripts/webkitpy/style/checkers/cpp.py:
2281         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2282
2283 2010-06-22  Eric Seidel  <eric@webkit.org>
2284
2285         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2286
2287         * Scripts/webkitpy/common/config/committers.py:
2288
2289 2010-06-22  Eric Seidel  <eric@webkit.org>
2290
2291         Reviewed by Adam Barth.
2292
2293         Remove Gtk 64-Release bot from core since it's broken
2294         https://bugs.webkit.org/show_bug.cgi?id=41022
2295
2296         This bot alone has been responsible for more than 72 hours of
2297         commit-queue blockage in the last week.  The bot is broken -- keeps
2298         losing its display server or similar.  Until the Gtk folks can fix the
2299         bot, we need to remove it from core.  The WebKit community can't keep
2300         it green as is.
2301
2302         * Scripts/webkitpy/common/net/buildbot.py:
2303         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2304
2305 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2306
2307         Reviewed by Eric Seidel.
2308
2309         Fix the Windows build.
2310         https://bugs.webkit.org/show_bug.cgi?id=40972
2311
2312         * DumpRenderTree/win/ImageDiff.vcproj:
2313
2314 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2315
2316         Reviewed by Darin Adler, Dmitry Titov.
2317
2318         DumpRenderTree should allow tests with modal dialogs
2319         https://bugs.webkit.org/show_bug.cgi?id=35350
2320
2321         * DumpRenderTree/LayoutTestController.cpp:
2322         (abortModalCallback):
2323         (LayoutTestController::staticFunctions):
2324         * DumpRenderTree/LayoutTestController.h:
2325         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2326         (LayoutTestController::abortModal):
2327         Add abortModal method to LayoutTestController and make it available from script.
2328
2329         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2330         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2331         abortModal from when modal window closes.
2332         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2333
2334 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2335
2336         Reviewed by Anders Carlsson.
2337         
2338         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2339         https://bugs.webkit.org/show_bug.cgi?id=40948
2340         
2341         Have the script look in WebKit2.
2342
2343         * Scripts/do-webcore-rename:
2344
2345 2010-06-21  Robert Hogan  <robert@webkit.org>
2346
2347         Reviewed by Kenneth Rohde Christiansen.
2348
2349         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2350
2351         It's a Mac-specific test so just add the required LayoutTestController
2352         function as a no-op to avoid failing. Similar approach adopted by other
2353         ports.
2354
2355         https://bugs.webkit.org/show_bug.cgi?id=33344
2356
2357         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2358         (LayoutTestController::addDisallowedURL):
2359
2360 2010-06-21  Sam Weinig  <sam@webkit.org>
2361
2362         Reviewed by Anders Carlsson.
2363
2364         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2365         Add message passing support to the WebKit2 API.
2366
2367         - Add some test messages.
2368
2369         * MiniBrowser/mac/AppDelegate.m:
2370         (_didRecieveMessageFromInjectedBundle):
2371         (-[BrowserAppDelegate init]):
2372         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2373         (_didClearWindow):
2374         (_didCreatePage):
2375         (_didRecieveMessage):
2376         (WKBundleInitialize):
2377
2378 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2379
2380         Unreviewed.
2381
2382         Rolling back 61551 and 61555 due to test failures.
2383
2384         * DumpRenderTree/LayoutTestController.cpp:
2385         (LayoutTestController::staticFunctions):
2386         * DumpRenderTree/LayoutTestController.h:
2387         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2388         (LayoutTestController::setEditingBehavior):
2389         * DumpRenderTree/mac/UIDelegate.mm:
2390
2391 2010-06-21  Anders Carlsson  <andersca@apple.com>
2392
2393         Reviewed by Sam Weinig.
2394
2395         Make DumpRenderTree build with clang++
2396
2397         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2398         (-[LocalPasteboard setPropertyList:forType:]):
2399         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2400         (-[DumpRenderTreeWindow keyDown:]):
2401         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2402         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2403         (LayoutTestController::isCommandEnabled):
2404
2405 2010-06-21  Satish Sampath  <satish@chromium.org>
2406
2407         Reviewed by Steve Block.
2408
2409         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2410         https://bugs.webkit.org/show_bug.cgi?id=40878
2411
2412         * Scripts/build-webkit:
2413
2414 2010-06-21  Kent Tamura  <tkent@chromium.org>
2415
2416         Reviewed by Dimitri Glazkov.
2417
2418         [DRT/Chromium] Initialization for http/tests/loading/
2419         https://bugs.webkit.org/show_bug.cgi?id=40902
2420
2421         * DumpRenderTree/chromium/TestShell.cpp:
2422         (TestShell::runFileTest):
2423
2424 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2425
2426         Unreviewed.
2427
2428         Adding myself to the committers list.
2429
2430         * Scripts/webkitpy/common/config/committers.py:
2431
2432 2010-06-20  Kent Tamura  <tkent@chromium.org>
2433
2434         Reviewed by Dimitri Glazkov.
2435
2436         [DRT/Chromium] Add --allow-external-pages option
2437         https://bugs.webkit.org/show_bug.cgi?id=40762
2438
2439         Add --allow-external-pages introduced by Chromium r45403.
2440         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2441
2442         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2443         (main):
2444         * DumpRenderTree/chromium/TestShell.cpp:
2445         (TestShell::TestShell):
2446         * DumpRenderTree/chromium/TestShell.h:
2447         (TestShell::allowExternalPages):
2448         (TestShell::setAllowExternalPages):
2449         * DumpRenderTree/chromium/WebViewHost.cpp:
2450         (WebViewHost::willSendRequest):
2451
2452 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2453
2454         Reviewed by Adam Barth.
2455
2456         Sheriffbot: Should allow "r" in SVN_REVISION
2457         https://bugs.webkit.org/show_bug.cgi?id=40889
2458
2459         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2460         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2461
2462 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2463
2464         Reviewed by Dimitri Glazkov.
2465
2466         Python Tests Fail after r61508
2467         https://bugs.webkit.org/show_bug.cgi?id=40891
2468
2469         Test's regex list needed to be updated to match the new
2470         regex list in the source code. Added new bots to the
2471         example_buildbots list.
2472
2473         Regex list fixed in r61512. Updated bot list.
2474
2475         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2476
2477 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2478
2479         Unreviewed, build fix.
2480
2481         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2482
2483         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2484
2485 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2486
2487         Unreviewed.
2488
2489         Adding myself to the committers list.
2490
2491         * Scripts/webkitpy/common/config/committers.py:
2492
2493 2010-06-19  Sam Weinig  <sam@webkit.org>
2494
2495         Reviewed by Anders Carlsson.
2496
2497         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2498         Add ability to have a WebProcess per WebContext.
2499
2500         Move to use new shared contexts API.
2501
2502         * MiniBrowser/mac/AppDelegate.h:
2503         * MiniBrowser/mac/AppDelegate.m:
2504         (-[BrowserAppDelegate init]):
2505         (-[BrowserAppDelegate getCurrentPageNamespace]):
2506         (-[BrowserAppDelegate validateMenuItem:]):
2507         (-[BrowserAppDelegate _setProcessModel:]):
2508         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2509         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2510         * MiniBrowser/win/BrowserView.cpp:
2511         (BrowserView::create):
2512
2513 2010-06-02  Robert Hogan  <robert@webkit.org>
2514
2515         Reviewed by Adam Barth.
2516
2517         [Qt] Support evaluateScriptInIsolatedWorld()
2518
2519         https://bugs.webkit.org/show_bug.cgi?id=40079
2520
2521         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2522         (LayoutTestController::evaluateScriptInIsolatedWorld):
2523         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2524
2525 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2526
2527         Reviewed by Darin Adler.
2528
2529         Add three more non-core Chromium builders to start testing DumpRenderTree.
2530         https://bugs.webkit.org/show_bug.cgi?id=40335
2531
2532         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2533
2534 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2535
2536         Reviewed by Darin Fisher.
2537
2538         [Chromium] Plumbing for top-level frame names
2539         https://bugs.webkit.org/show_bug.cgi?id=40430
2540
2541         * DumpRenderTree/chromium/WebViewHost.cpp:
2542         (WebViewHost::reset):
2543         Changed obsolete call to clearName() to use setName(WebString()) instead.
2544
2545 2010-06-18  Sam Weinig  <weinig@apple.com>
2546
2547         Rolling http://trac.webkit.org/changeset/61297 back in.
2548
2549         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2550         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2551         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2552         (_didClearWindow):
2553         (_didCreatePage):
2554         (WKBundleInitialize):
2555
2556 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2557
2558         Reviewed by Darin Adler.
2559
2560         https://bugs.webkit.org/show_bug.cgi?id=40803
2561         TestNetscapePlugin has an incorrect implementation of "property" property
2562
2563         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2564         pass a static string back, it's going to be released by NPAPI implementation.
2565
2566 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2567
2568         Unreviewed.
2569
2570         Adding myself to the committers list.
2571
2572         * Scripts/webkitpy/common/config/committers.py:
2573
2574 2010-06-17  Tony Chang  <tony@chromium.org>
2575
2576         Reviewed by Kent Tamura.
2577
2578         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2579         https://bugs.webkit.org/show_bug.cgi?id=40615
2580
2581         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2582
2583 2010-06-17  Ada Chan  <adachan@apple.com>
2584
2585         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2586
2587         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2588         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2589         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2590
2591 2010-06-17  Darin Adler  <darin@apple.com>
2592
2593         One more try at fix for Chromium build.
2594
2595         * DumpRenderTree/chromium/TestShell.cpp:
2596         (TestShell::TestShell): Use set again instead of =.
2597
2598 2010-06-17  Darin Adler  <darin@apple.com>
2599
2600         Fix Chromium build.
2601
2602         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2603         code with all the other platforms! Wow, that should be fixed at some point.
2604
2605         * DumpRenderTree/chromium/TestShell.cpp:
2606         (TestShell::TestShell): Changed back to using "new".
2607         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2608
2609 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2610
2611         Unreviewed Qt build fix.
2612
2613         LayoutTestController in the Qt DRT is not using refs :)
2614
2615         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2616         (WebCore::DumpRenderTree::DumpRenderTree):
2617
2618 2010-06-17  Darin Adler  <darin@apple.com>
2619
2620         Reviewed by Sam Weinig.
2621
2622         Use adoptRef and create functions in more code paths
2623         https://bugs.webkit.org/show_bug.cgi?id=40760
2624
2625         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2626
2627         * DumpRenderTree/LayoutTestController.cpp:
2628         (LayoutTestController::create): Added.
2629         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2630
2631         * DumpRenderTree/chromium/TestShell.cpp:
2632         (TestShell::TestShell): Use create instead of new.
2633         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2634
2635         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2636         (runTest): Use RefPtr and create instead of OwnPtr and new.
2637
2638         * DumpRenderTree/mac/DumpRenderTree.mm:
2639         (runTest): Use RefPtr and create instead of OwnPtr and new.
2640
2641         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2642         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
2643         instead of new.
2644
2645         * DumpRenderTree/win/DumpRenderTree.cpp:
2646         (runTest): Use RefPtr and create instead of OwnPtr and new.
2647
2648         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2649         (runTest): Use RefPtr and create instead of OwnPtr and new.
2650         (MyApp::OnInit): Removed unneeded code to delete the layout
2651         test controller. This is done during each test.
2652
2653 2010-06-17  Kent Tamura  <tkent@chromium.org>
2654
2655         Reviewed by Shinichiro Hamaji.
2656
2657         [DRT/Chromium] Fix a bug of Windows pixel tests
2658         https://bugs.webkit.org/show_bug.cgi?id=40763
2659
2660         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2661         (TestShellPrinter::handleImage):
2662
2663 2010-06-16  Kent Tamura  <tkent@chromium.org>
2664
2665         Reviewed by Shinichiro Hamaji.
2666
2667         [DRT/Chromium] Fix crash on Mac Release
2668         https://bugs.webkit.org/show_bug.cgi?id=40759
2669
2670         * DumpRenderTree/chromium/WebViewHost.cpp:
2671         (WebViewHost::paintRect): We should not use m_canvas directly because
2672           it is created lazily in canvas().
2673
2674 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2675
2676         [wx] Build fix after new method addition.
2677
2678         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2679         (LayoutTestController::pageProperty):
2680
2681 2010-06-16  Kent Tamura  <tkent@chromium.org>
2682
2683         Reviewed by Dimitri Glazkov.
2684
2685         [DRT/Chromium] Set current working directory for each of tests
2686         https://bugs.webkit.org/show_bug.cgi?id=40668
2687
2688         This change fixes tests with eventSender.beginDragWithFiles().
2689
2690         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2691         (runTest):
2692
2693 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2694
2695         Reviewed by Gustavo Noronha Silva.
2696
2697         [GTK] r60803 broke media/controls-drag-timebar.html
2698         https://bugs.webkit.org/show_bug.cgi?id=40269
2699
2700         Only queue events while the mouse button is down, if drag mode is enabled. Some
2701         tests may disable drag mode, to prevent the queuing of events in this situation.
2702
2703         * DumpRenderTree/gtk/EventSender.cpp:
2704         (sendOrQueueEvent): Only queue events here if dragMode is true.
2705
2706 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2707
2708         Reviewed by Gustavo Noronha Silva.
2709
2710         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
2711         https://bugs.webkit.org/show_bug.cgi?id=40600
2712
2713         * DumpRenderTree/gtk/EventSender.cpp:
2714         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
2715
2716 2010-06-16  Adam Barth  <abarth@webkit.org>
2717
2718         Reviewed by Dimitri Glazkov.
2719
2720         Add a hidden land-cowboy command to webkit-patch to help land quick
2721         build fixes.
2722
2723         * Scripts/webkitpy/tool/commands/download.py:
2724         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2725
2726 2010-06-16  Adam Roben  <aroben@apple.com>
2727
2728         Convert console messages to UTF-8 before printing them
2729
2730         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
2731         http/tests/security/xssAuditor/embed-tag-null-char.html and
2732         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
2733         Windows. (I can't test the fix because Apache is crashing on my
2734         computer.)
2735
2736         Reviewed by Alexey Proskuryakov.
2737
2738         * DumpRenderTree/win/DumpRenderTree.cpp:
2739         (toUTF8): Extracted the code into an overload that takes a wide string
2740         and a length, then added an overload that takes a wstring.
2741
2742         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
2743         overload.
2744
2745         * DumpRenderTree/win/UIDelegate.cpp:
2746         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
2747         UTF-8 instead of letting printf convert to the current code page.
2748
2749 2010-06-16  Drew Wilson  <atwilson@chromium.org>
2750
2751         Reviewed by Kent Tamura.
2752
2753         [Chromium] Plumbing for top-level frame names
2754         https://bugs.webkit.org/show_bug.cgi?id=40430
2755
2756         * DumpRenderTree/chromium/WebViewHost.cpp:
2757         (WebViewHost::createView):
2758         Migrate to new createView() API.
2759         * DumpRenderTree/chromium/WebViewHost.h:
2760         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
2761
2762 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
2763
2764         Reviewed by Kenneth Rohde Christiansen.
2765
2766         [Qt] Scroll wheel event support to graphics based DRT
2767         https://bugs.webkit.org/show_bug.cgi?id=40577
2768
2769         * DumpRenderTree/qt/EventSenderQt.cpp:
2770         (EventSender::continuousMouseScrollBy):
2771         (EventSender::createGraphicsSceneWheelEvent):
2772         * DumpRenderTree/qt/EventSenderQt.h:
2773
2774 2010-06-16  Adam Roben  <aroben@apple.com>
2775
2776         Remove a stray newline from the Windows version of TestNetscapePlugin
2777
2778         Reviewed by Alexey Proskuryakov.
2779
2780         Fixes <http://webkit.org/b/40728>
2781         plugins/geturlnotify-during-document-teardown.html fails on Windows
2782
2783         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2784         (NPP_Destroy): Removed extra newline that the Mac version doesn't
2785         have.
2786
2787 2010-06-16  Adam Roben  <aroben@apple.com>
2788
2789         Respect LayoutTestController::isPrinting on Windows
2790
2791         This gets some printing tests closer to passing (like
2792         printing/page-rule-in-media-query.html).
2793
2794         Fixes <http://webkit.org/b/40727>.
2795
2796         Reviewed by Dan Bernstein.
2797
2798         * DumpRenderTree/win/DumpRenderTree.cpp:
2799         (dump): Pass LayoutTestController::isPrinting to
2800         IWebFramePrivate::renderTreeAsExternalRepresentation.
2801
2802 2010-06-15  Adam Barth  <abarth@webkit.org>
2803
2804         Reviewed by Eric Seidel.
2805
2806         Enable HTML5 lexer
2807         https://bugs.webkit.org/show_bug.cgi?id=40650
2808
2809         * DumpRenderTree/mac/DumpRenderTree.mm:
2810         (initializeGlobalsFromCommandLineOptions):
2811
2812 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
2813
2814         Reviewed by Shinichiro Hamaji.
2815
2816         Implement render style selection for pages to support CSS3 Paged Media.
2817         https://bugs.webkit.org/show_bug.cgi?id=35961
2818
2819         * DumpRenderTree/LayoutTestController.cpp:
2820         (parsePagePropertyParameters):
2821         (pagePropertyCallback):
2822         (LayoutTestController::staticFunctions):
2823         * DumpRenderTree/LayoutTestController.h:
2824         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2825         (LayoutTestController::pageProperty):
2826         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2827         (LayoutTestController::pageProperty):
2828         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2829         (LayoutTestController::pageProperty):
2830
2831 2010-06-15  Sam Weinig  <sam@webkit.org>
2832
2833         Reviewed by Anders Carlsson.
2834
2835         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
2836         WebKit2: Add mechanism to inject code into the WebProcess on startup
2837
2838         Add initial InjectedBundle support.
2839
2840         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2841         * MiniBrowser/WebBundle-Info.plist: Added.
2842         Add test InjectedBundle to the project.
2843
2844         * MiniBrowser/mac/AppDelegate.m:
2845         (-[BrowserAppDelegate init]):
2846         Get the path to the WebBundle from the the main bundle and pass it to the new
2847         WKContextCreateWithInjectedBundlePath function.
2848
2849         * MiniBrowser/mac/BrowserWindowController.m:
2850         (_didChangeProgress):
2851         Fix the build.  This has been broken for a while.
2852
2853         * MiniBrowser/mac/WebBundle: Added.
2854         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
2855         (_didCreatePage):
2856         (WKBundleInitialize):
2857         Add really basic InjectedBundle.
2858
2859         * MiniBrowser/win/BrowserView.cpp:
2860         (BrowserView::create):
2861         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
2862
2863 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
2864
2865         Reviewed by Darin Adler.
2866
2867         Adding myself to the reviewers list.
2868         https://bugs.webkit.org/show_bug.cgi?id=40693
2869
2870         * Scripts/webkitpy/common/config/committers.py:
2871
2872 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
2873
2874         Reviewed by Xan Lopez.
2875
2876         Switch to using GIO methods instead of realpath in GtkLauncher to determine
2877         the file URI. This should remove warnings about realpath being undefined
2878         when compiling with '-ansi'.
2879
2880         * GtkLauncher/main.c:
2881         (filenameToURL): Use GIO instead of realpath to determine file URI.
2882
2883 2010-06-15  Adam Roben  <aroben@apple.com>
2884
2885         Remove the redundant set-apple-windows-environment-variables script
2886
2887         Apparently update-webkit does this for you these days.
2888
2889         Rubber-stamped by Steve Falkenburg.
2890
2891         * Scripts/set-apple-windows-environment-variables: Removed.
2892
2893 2010-06-14  Adam Roben  <aroben@apple.com>
2894
2895         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
2896         environment variables
2897
2898         Fixes <http://webkit.org/b/40595>.
2899
2900         Reviewed by Steve Falkenburg.
2901
2902         * Scripts/set-apple-windows-environment-variables: Added.
2903         (to_windows_path): Passes the passed-in path through cygpath to
2904         generate a Windows-style path.
2905         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
2906         variables to their defaults, if they aren't already set.
2907
2908 2010-06-14  Adam Roben  <aroben@apple.com>
2909
2910         Speed up run-safari/debug-safari on Windows
2911
2912         Fixes <http://webkit.org/b/40586>.
2913
2914         Reviewed by Steve Falkenburg.
2915
2916         * Scripts/webkitdirs.pm:
2917         (runSafari): When debugging, set up the environment to run Safari
2918         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
2919         actually launch the debugger. When not debugging, just run WebKit.exe
2920         and it will do the rest for us.
2921
2922 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
2923
2924         Reviewed by Kenneth Rohde Christiansen.
2925
2926         [Qt] DRT EventSender support to graphics context events
2927         https://bugs.webkit.org/show_bug.cgi?id=40324
2928
2929         * DumpRenderTree/qt/EventSenderQt.cpp:
2930         (EventSender::contextClick):
2931
2932 2010-06-14  Tony Chang  <tony@chromium.org>
2933
2934         Reviewed by Darin Fisher.
2935
2936         [chromium] checkout chromium third_party directly
2937         https://bugs.webkit.org/show_bug.cgi?id=40556
2938
2939         * Scripts/update-webkit-chromium: some migration code for the bots
2940
2941 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2942
2943         Chromium build fix.
2944
2945         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
2946         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
2947
2948 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2949
2950         Reviewed by Darin Adler.
2951
2952         https://bugs.webkit.org/show_bug.cgi?id=40529
2953         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
2954
2955         * DumpRenderTree/mac/EventSendingController.mm:
2956         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
2957         event for "delete" - it had virtual key code from forward delete, and text from backspace.
2958         Fixed "delete" to mean forward delete.
2959
2960         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
2961         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
2962         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2963         Mac DRT confusion has propagated to other platforms, fixing those.
2964
2965 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
2966
2967         Reviewed by Xan Lopez.
2968
2969         Small GtkLauncher build fix for some systems.
2970
2971         * GtkLauncher/main.c: Add <limit.h> include.
2972
2973 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2974
2975         Reviewed by Laszlo Gombos.
2976
2977         [Qt] navigator.geolocation support for Qt port
2978         https://bugs.webkit.org/show_bug.cgi?id=39724
2979
2980         Implementation for geolocation cases to DumpRenderTreeQt
2981
2982         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2983         (WebCore::WebPage::allowGeolocationRequest):
2984         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2985         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2986         (LayoutTestController::setGeolocationPermission):
2987         (LayoutTestController::setMockGeolocationError):
2988         (LayoutTestController::setMockGeolocationPosition):
2989         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2990         (LayoutTestController::isGeolocationPermissionSet):
2991         (LayoutTestController::geolocationPermission):
2992
2993 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
2994
2995         Reviewed by Darin Adler.
2996
2997         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
2998         be a way of overwriting the Xcode system path.  Making
2999         $WEBKITOUTPUTDIR take precedence over the system default would make
3000         this possible.
3001
3002         * Scripts/webkitdirs.pm:
3003
3004 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
3005
3006         Reviewed by Darin Adler.
3007
3008         AX: link won't return linked element if URL contains #
3009         https://bugs.webkit.org/show_bug.cgi?id=40192
3010
3011         * DumpRenderTree/AccessibilityUIElement.cpp:
3012         (linkedUIElementAtIndexCallback):
3013         (AccessibilityUIElement::getJSClass):
3014         * DumpRenderTree/AccessibilityUIElement.h:
3015         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3016         (AccessibilityUIElement::linkedUIElementAtIndex):
3017         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3018         (AccessibilityUIElement::linkedUIElementAtIndex):
3019         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3020         (AccessibilityUIElement::linkedUIElementAtIndex):
3021
3022 2010-06-13  Adam Barth  <abarth@webkit.org>
3023
3024         Reviewed by Darin Adler.
3025
3026         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3027         https://bugs.webkit.org/show_bug.cgi?id=39550
3028
3029         This can cause an extra request to bugs.webkit.org durig upload, but it
3030         shouldn't be too bad.  Also, this won't work if you remove the
3031         boilerplate created by prepare-ChangeLog.
3032
3033         * Scripts/webkitpy/common/checkout/changelog.py:
3034         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3035         * Scripts/webkitpy/common/net/bugzilla.py:
3036         * Scripts/webkitpy/tool/steps/abstractstep.py:
3037         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3038         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3039
3040 2010-06-08  Robert Hogan  <robert@webkit.org>
3041
3042         Reviewed by Eric Seidel.
3043
3044         [Qt] Add support for callShouldCloseOnWebView() to DRT
3045         https://bugs.webkit.org/show_bug.cgi?id=40330
3046
3047         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3048         (LayoutTestController::callShouldCloseOnWebView):
3049         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3050         (LayoutTestController::setCallCloseOnWebViews):
3051
3052 2010-06-12  Eric Seidel  <eric@webkit.org>
3053
3054         Reviewed by Daniel Bates.
3055
3056         do-webcore-rename should have a --verbose option
3057         https://bugs.webkit.org/show_bug.cgi?id=40497
3058
3059         * Scripts/do-webcore-rename:
3060          - Unified how we handle skipping files/directories
3061            this will allow us to "black list" certain files and
3062            directories when performing renames.
3063          - Made do-webcore-rename log what it's skipping when passed --verbose.
3064
3065 2010-06-12  Darin Adler  <darin@apple.com>
3066
3067         * Scripts/run-bindings-tests: Fixed a typo in a message.
3068
3069 2010-06-12  Kent Tamura  <tkent@chromium.org>
3070
3071         Reviewed by Dimitri Glazkov.
3072
3073         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3074         https://bugs.webkit.org/show_bug.cgi?id=40402
3075
3076         _build_path() of each Chromium port check existence of build path
3077         of Chromium checkout first, then check existence of build path of
3078         WebKit-only checkout.
3079
3080         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3081         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3082         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3083
3084 2010-06-12  Robert Hogan  <robert@webkit.org>
3085
3086         Reviewed by Kenneth Rohde Christiansen.
3087
3088         [Qt] Back-forward list dumping is incorrect
3089
3090         https://bugs.webkit.org/show_bug.cgi?id=36392
3091
3092         Support dumping child history items in DRT.
3093
3094         Unskip:
3095
3096         fast/loader/frame-src-change-added-to-history.html
3097         fast/loader/frame-src-change-not-added-to-history.html
3098         fast/loader/frame-location-change-not-added-to-history.html
3099
3100         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3101         (WebCore::dumpHistoryItem):
3102
3103 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3104
3105         Reviewed by Eric Seidel.
3106
3107         upload all patches that lack in-rietveld to rietveld
3108         https://bugs.webkit.org/show_bug.cgi?id=40444
3109
3110         If it's a patch, then we'll try to upload it as long as it
3111         doesn't have in-rietveld set. No longer set in-rietveld? since
3112         it's not needed.
3113
3114         * Scripts/webkitpy/common/net/bugzilla.py:
3115
3116 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3117
3118         Reviewed by Darin Fisher.
3119
3120         Fix rietveld upload when message length > 100 characters
3121         https://bugs.webkit.org/show_bug.cgi?id=40457
3122
3123         * Scripts/webkitpy/common/net/rietveld.py:
3124
3125 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3126
3127         Reviewed by Laszlo Gombos.
3128
3129         [Qt] There should be a way to enable popups in QtTestBrowser
3130         https://bugs.webkit.org/show_bug.cgi?id=40427
3131
3132         * QtTestBrowser/main.cpp:
3133         (LauncherWindow::toggleJavascriptCanOpenWindows):
3134         (LauncherWindow::createChrome):
3135
3136 2010-06-10  Adam Barth  <abarth@webkit.org>
3137
3138         Reviewed by Daniel Bates.
3139
3140         Make SheriffBot more chatty
3141         https://bugs.webkit.org/show_bug.cgi?id=40463
3142
3143         People seem to like to talk to SheriffBot, so let's make him chat back.
3144
3145         * Scripts/webkitpy/thirdparty/__init__.py:
3146         * Scripts/webkitpy/tool/bot/irc_command.py:
3147         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3148         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3149         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3150
3151 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3152
3153         Reviewed by Darin Adler.
3154
3155         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3156         
3157         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3158         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3159         WEXITSTATUS on $result instead of just comparing $result to 0.
3160
3161         * Scripts/update-webkit-auxiliary-libs:
3162
3163 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3164
3165         Reviewed by Alexey Proskuryakov.
3166
3167         don't use Exception.message as it's deprecated in python 2.6+
3168         https://bugs.webkit.org/show_bug.cgi?id=40449
3169
3170         * Scripts/webkitpy/tool/commands/queues.py:
3171
3172 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3173
3174         Reviewed by Adam Barth.
3175
3176         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3177         https://bugs.webkit.org/show_bug.cgi?id=40436
3178
3179         * Scripts/webkitpy/common/system/outputcapture.py:
3180         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3181         * Scripts/webkitpy/tool/commands/queues.py:
3182         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3183         * Scripts/webkitpy/tool/commands/queuestest.py:
3184         * Scripts/webkitpy/tool/mocktool.py:
3185
3186 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3187
3188         Reviewed by Simon Hausmann.
3189
3190         [Qt] *All* WebGL layout tests fail!
3191         https://bugs.webkit.org/show_bug.cgi?id=40296
3192
3193         Added test for WebKitWebGLEnabled to
3194         LayoutTestController::overridePreference().
3195
3196         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3197         (LayoutTestController::overridePreference):
3198
3199 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3200
3201         Reviewed by Kenneth Rohde Christiansen.
3202
3203         [Qt] DRT EventSender support to graphics mouse events activation
3204         https://bugs.webkit.org/show_bug.cgi?id=40017
3205
3206         * DumpRenderTree/qt/EventSenderQt.cpp:
3207         (EventSender::mouseDown):
3208         (EventSender::mouseUp):
3209         (EventSender::mouseMoveTo):
3210         (EventSender::keyDown):
3211         (EventSender::contextClick):
3212         (EventSender::sendTouchEvent):
3213         (EventSender::sendOrQueueEvent):
3214         (EventSender::eventFilter):
3215         (EventSender::createGraphicsSceneMouseEvent):
3216         (EventSender::sendEvent):
3217         * DumpRenderTree/qt/EventSenderQt.h:
3218         (EventSender::isGraphicsBased):
3219
3220 2010-06-09  Adam Barth  <abarth@webkit.org>
3221
3222         Reviewed by Ojan Vafai.
3223
3224         webkit-patch upload fails for security bugs because there's no rietveld flag
3225         https://bugs.webkit.org/show_bug.cgi?id=40309
3226
3227         There's probably a more elegant way of seeing whether the form control
3228         exists, but this seems to work.
3229
3230         * Scripts/webkitpy/common/net/bugzilla.py:
3231
3232 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3233
3234         Reviewed by Adam Barth.
3235
3236         make rietveld upload faster and avoid posting to bug on errors
3237         https://bugs.webkit.org/show_bug.cgi?id=40389
3238
3239         Only grab the first item of the upload queue instead of trying
3240         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3241
3242         Also, don't post comments to the bug when uploading fails.
3243
3244         * Scripts/webkitpy/common/net/bugzilla.py:
3245         * Scripts/webkitpy/tool/commands/queues.py:
3246         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3247         * Scripts/webkitpy/tool/commands/stepsequence.py:
3248         * Scripts/webkitpy/tool/mocktool.py:
3249
3250 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3251
3252         Reviewed by Adam Barth.
3253
3254         Rietveld upload queue fails when setting in-rietveld flag
3255         https://bugs.webkit.org/show_bug.cgi?id=40371
3256
3257         Make the comment arguments to set_flag_on_attachment optional
3258         and add it to the MockBugzilla.
3259
3260         * Scripts/webkitpy/common/net/bugzilla.py:
3261         * Scripts/webkitpy/tool/bot/queueengine.py:
3262         * Scripts/webkitpy/tool/commands/download_unittest.py:
3263         * Scripts/webkitpy/tool/commands/queues.py:
3264         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3265         * Scripts/webkitpy/tool/mocktool.py:
3266
3267 2010-06-09  Kenneth Russell  <kbr@google.com>
3268
3269         Reviewed by Dimitri Glazkov.
3270
3271         Rename FloatArray to Float32Array
3272         https://bugs.webkit.org/show_bug.cgi?id=40323
3273
3274         Used do-webcore-rename to perform renaming. Manually undid
3275         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3276         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3277         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3278         all layout tests on Safari; built Chromium and ran selected WebGL
3279         tests.
3280
3281         * Scripts/do-webcore-rename:
3282
3283 2010-06-08  Tony Chang  <tony@chromium.org>
3284
3285         Reviewed by David Levin.
3286
3287         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3288         https://bugs.webkit.org/show_bug.cgi?id=40285
3289
3290         * Scripts/webkitdirs.pm:
3291         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3292
3293 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3294
3295         Reviewed by Tamura Kent.
3296
3297         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3298         https://bugs.webkit.org/show_bug.cgi?id=40052
3299         
3300         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3301
3302         * DumpRenderTree/DumpRenderTree.gypi:
3303         * DumpRenderTree/chromium/TestShellWin.cpp:
3304         (platformInit):
3305         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3306         (WebKit::):
3307         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3308         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3309         (WebKit::WebThemeControlDRT::box):
3310         (WebKit::WebThemeControlDRT::line):
3311         (WebKit::WebThemeControlDRT::triangle):
3312         (WebKit::WebThemeControlDRT::roundRect):
3313         (WebKit::WebThemeControlDRT::oval):
3314         (WebKit::WebThemeControlDRT::circle):
3315         (WebKit::WebThemeControlDRT::nestedBoxes):
3316         (WebKit::WebThemeControlDRT::markState):
3317         (WebKit::WebThemeControlDRT::draw):
3318         (WebKit::WebThemeControlDRT::drawTextField):
3319         (WebKit::WebThemeControlDRT::drawProgressBar):
3320         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3321         (WebKit::WebThemeControlDRT::):
3322         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3323         (WebKit::):
3324         (WebKit::WebThemeEngineDRT::paintButton):
3325         (WebKit::WebThemeEngineDRT::paintMenuList):
3326         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3327         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3328         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3329         (WebKit::WebThemeEngineDRT::paintTextField):
3330         (WebKit::WebThemeEngineDRT::paintTrackbar):
3331         (WebKit::WebThemeEngineDRT::paintProgressBar):
3332         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3333         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3334
3335 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3336
3337         Unreviewed, rolling out r60878.
3338         http://trac.webkit.org/changeset/60878
3339         https://bugs.webkit.org/show_bug.cgi?id=40349
3340
3341         broke linux build (Requested by tony^work on #webkit).
3342
3343         * Scripts/webkitdirs.pm:
3344         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3345
3346 2010-06-08  Tony Chang  <tony@chromium.org>
3347
3348         Reviewed by David Levin.
3349
3350         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3351         https://bugs.webkit.org/show_bug.cgi?id=40285
3352
3353         * Scripts/webkitdirs.pm:
3354         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3355
3356 2010-06-08  Kenneth Russell  <kbr@google.com>
3357
3358         Unreviewed, build fix.
3359
3360         Fix build breakage from 38145
3361         https://bugs.webkit.org/show_bug.cgi?id=40346
3362
3363         The fix for bug 38145 broke the Chromium Win build because
3364         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3365         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3366         tests in Safari on Mac OS X. Changed download mirrors for
3367         python-irclib to working ones.
3368
3369         * Scripts/webkitpy/thirdparty/__init__.py:
3370
3371 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3372
3373         Reviewed by Eric Seidel.
3374
3375         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3376         https://bugs.webkit.org/show_bug.cgi?id=39058
3377
3378         * Scripts/old-run-webkit-tests:
3379          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3380
3381 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3382
3383         Unreviewed buildfix after r60479.
3384
3385         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3386         versions other than 2.17.3.
3387
3388         * DumpRenderTree/gtk/EventSender.cpp:
3389         (getRootCoords):
3390
3391 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3392
3393         Reviewed by Oliver Hunt.
3394
3395         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3396         https://bugs.webkit.org/show_bug.cgi?id=40267
3397
3398         When a mouse button is down, automatically queue mouse motion events and
3399         do not play them back until the mouse button is released. This matches the
3400         behavior of other ports' EventSenders.
3401
3402         * DumpRenderTree/gtk/EventSender.cpp:
3403         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3404         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3405
3406 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3407
3408         Reviewed by Sam Weinig.
3409
3410         Add CPP bindings generator
3411         https://bugs.webkit.org/show_bug.cgi?id=38279
3412
3413         Integrate CPP bindings in run-bindings-tests.
3414
3415         * Scripts/run-bindings-tests:
3416
3417 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3418
3419         Reviewed by Ojan Vafai.
3420
3421         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3422         https://bugs.webkit.org/show_bug.cgi?id=40183
3423
3424         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3425
3426 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3427
3428         Unreviewed.
3429
3430         Add my new email and IRC nick to committers.py.
3431
3432         * Scripts/webkitpy/common/config/committers.py:
3433
3434 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
3435
3436         Unreviewed.
3437
3438         Revert changes in json_results_generator.py's _get_svn_revision.
3439
3440         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3441
3442 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3443
3444         Reviewed by Xan Lopez.
3445
3446         [GTK] GtkLauncher should support relative file paths
3447         https://bugs.webkit.org/show_bug.cgi?id=39944
3448
3449         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
3450
3451         * GtkLauncher/main.c:
3452         (filename_to_url): Added.
3453         (main): Try to resolve arguments as relative file URLs first.
3454
3455 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3456
3457         Reviewed by Xan Lopez.
3458
3459         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
3460         https://bugs.webkit.org/show_bug.cgi?id=40182
3461
3462         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
3463         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
3464         without breaking DRT.
3465
3466         * DumpRenderTree/gtk/EventSender.cpp:
3467         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
3468         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
3469
3470 2010-06-04  Anders Carlsson  <andersca@apple.com>
3471
3472         Reviewed by David Hyatt.
3473
3474         Make the editing/spelling/context-menu-suggestions.html test more robust
3475         https://bugs.webkit.org/show_bug.cgi?id=40178
3476
3477         Change the contextClick method to return an array of strings describing the context menu items.
3478
3479         * DumpRenderTree/mac/EventSendingController.mm:
3480         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3481         (+[EventSendingController webScriptNameForSelector:]):
3482         (-[EventSendingController contextClick]):
3483
3484 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
3485
3486         Reviewed by Shinichiro Hamaji.
3487
3488         Clean up chromium-specific code from json_results_generator.py.
3489         https://bugs.webkit.org/show_bug.cgi?id=39665
3490
3491         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3492         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3493         * Scripts/webkitpy/layout_tests/port/base.py:
3494         * Scripts/webkitpy/layout_tests/port/chromium.py:
3495
3496 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3497
3498         Reviewed by Adam Barth.
3499
3500         Utilize new takeFirst() method where appropriate.
3501         https://bugs.webkit.org/show_bug.cgi?id=40089
3502
3503         * DumpRenderTree/chromium/EventSender.cpp:
3504         (EventSender::replaySavedEvents):
3505         * DumpRenderTree/chromium/LayoutTestController.cpp:
3506         (LayoutTestController::WorkQueue::processWork):
3507         (LayoutTestController::WorkQueue::reset):
3508
3509 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
3510
3511         Reviewed by Simon Hausmann.
3512
3513         [Qt] QtTestLauncher should allow notifications by default.
3514         https://bugs.webkit.org/show_bug.cgi?id=40078
3515
3516         * QtTestBrowser/main.cpp:
3517         (NotificationsPermissionController::NotificationsPermissionController):
3518         (NotificationsPermissionController::checkPermission):
3519         (NotificationsPermissionController::requestPermission):
3520         (LauncherWindow::LauncherWindow):
3521
3522 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3523
3524         Reviewed by Adam Barth.
3525
3526         Detect whether the user's environment can open a browser.
3527         https://bugs.webkit.org/show_bug.cgi?id=40136
3528
3529         Some environments like cygwin silently fail webbrowser.open() causing
3530         webkit-patch upload not to display any diff. This detects environments
3531         where webbrowser.open() would fail by testing if webbrowser.get()
3532         raises an exception.
3533
3534         * Scripts/webkitpy/common/system/user.py:
3535         * Scripts/webkitpy/tool/mocktool.py:
3536         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3537
3538 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
3539
3540         Reviewed by David Levin.
3541
3542         Add dependencies required to link with VS Express 2005.
3543         https://bugs.webkit.org/show_bug.cgi?id=40038
3544
3545         Visual Studio implicitly links against these libs.
3546         VC++ Express does not.
3547
3548         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3549         * WinLauncher/WinLauncher.vcproj:
3550
3551 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3552
3553         Reviewed by David Levin.
3554
3555         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
3556         https://bugs.webkit.org/show_bug.cgi?id=40105
3557
3558         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3559         - kill pywebsocket process when url is not alive and the process is not
3560           terminated, not to leave pywebsocket server running.
3561         - fix codecs.open parameters.
3562
3563 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3564
3565         Reviewed by Alexey Proskuryakov.
3566
3567         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3568         https://bugs.webkit.org/show_bug.cgi?id=39058
3569
3570         * Scripts/ensure-valid-python:
3571           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
3572           - Add --check-only and --help option.
3573           - --check-only option only checks python version and don't try to install Python 2.5.
3574           - Set executable bit.
3575         * Scripts/old-run-webkit-tests:
3576           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
3577
3578 2010-05-14  Ojan Vafai  <ojan@chromium.org>
3579
3580         Reviewed by Adam Barth.
3581
3582         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
3583         https://bugs.webkit.org/show_bug.cgi?id=38918
3584
3585         Patches with in-rietveld? get uploaded to rietveld and get marked
3586         in-rietveld+. If the upload fails, they are marked in-rietveld-
3587         and an error is logged to the bug, like the commit-queue.
3588
3589         Also, get rid of --fancy-review and the ability to upload to rietveld
3590         using webkit-patch upload/post.
3591
3592         * Scripts/webkitpy/common/net/bugzilla.py:
3593         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3594         * Scripts/webkitpy/tool/commands/download.py:
3595         * Scripts/webkitpy/tool/commands/download_unittest.py:
3596         * Scripts/webkitpy/tool/commands/queues.py:
3597         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3598         * Scripts/webkitpy/tool/commands/upload.py:
3599         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3600         * Scripts/webkitpy/tool/mocktool.py:
3601         * Scripts/webkitpy/tool/steps/options.py:
3602         * Scripts/webkitpy/tool/steps/postcodereview.py:
3603
3604 2010-05-24  Ojan Vafai  <ojan@chromium.org>
3605
3606         Reviewed by Chris Jerdonek.
3607
3608         many webkit-patch commands fail in a non-svn tracking git checkout
3609         https://bugs.webkit.org/show_bug.cgi?id=38156
3610
3611         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
3612         If neither exists, then error out. This makes webkit-patch work
3613         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
3614         to checkout webkit. The fallback to master is for people who don't
3615         do the steps on that page for tracking svn.
3616
3617         * Scripts/webkitpy/common/checkout/scm.py:
3618         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3619
3620 2010-06-03  Mike Fenton  <mifenton@rim.com>
3621
3622         Unreviewed.
3623
3624         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
3625
3626         * Scripts/webkitpy/common/config/committers.py:
3627
3628 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
3629
3630         Reviewed by Yury Semikhatsky.
3631
3632         Web Inspector: a number of fixes that make InspectorController
3633         happy with null redirects.
3634
3635         https://bugs.webkit.org/show_bug.cgi?id=40109
3636
3637         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3638         (runTest):
3639         * DumpRenderTree/mac/DumpRenderTree.mm:
3640         (runTest):
3641         * DumpRenderTree/win/DumpRenderTree.cpp:
3642         (runTest):
3643
3644 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
3645
3646         Reviewed by Shinichiro Hamaji.
3647
3648         [Qt] Fix compilation with QT_NO_PROPERTIES
3649         https://bugs.webkit.org/show_bug.cgi?id=38324
3650
3651         * QtTestBrowser/main.cpp:
3652         (LauncherWindow::init):
3653
3654 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
3655
3656         Reviewed by Kenneth Rohde Christiansen.
3657
3658         [Qt] Make possible run DRT with QGraphicsWebView
3659         https://bugs.webkit.org/show_bug.cgi?id=40016
3660
3661         Make possible to use a environment variable for switching backend.
3662         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
3663
3664         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3665         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
3666         (WebCore::DumpRenderTree::DumpRenderTree):
3667         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3668         (WebCore::DumpRenderTree::setGraphicsBased):
3669         (WebCore::DumpRenderTree::isGraphicsBased):
3670         (WebCore::WebViewGraphicsBased::graphicsView):
3671         (WebCore::WebViewGraphicsBased::setPage):
3672         * Scripts/old-run-webkit-tests:
3673
3674 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
3675
3676         Reviewed by Eric Seidel.
3677
3678         Slave lost shouldn't be recognized as build failed.
3679         https://bugs.webkit.org/show_bug.cgi?id=39282
3680
3681         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
3682         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
3683
3684 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
3685
3686         Reviewed by Kenneth Rohde Christiansen.
3687
3688         [Qt] Fix the lifecycle of notification objects
3689         https://bugs.webkit.org/show_bug.cgi?id=40003
3690
3691         Remove the dependency of notifications on QWebPage.
3692
3693         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3694         (WebCore::requestPermissionCallback):
3695         (WebCore::WebPage::WebPage):
3696         (WebCore::DumpRenderTree::requestPermission):
3697         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3698
3699 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3700
3701         Unreviewed, rolling out r60559.
3702         http://trac.webkit.org/changeset/60559
3703         https://bugs.webkit.org/show_bug.cgi?id=40055
3704
3705         It broke python unit test (Requested by Ossy on #webkit).
3706
3707         * Scripts/webkitpy/common/net/buildbot.py:
3708
3709 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>