2010-06-28 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
6         https://bugs.webkit.org/show_bug.cgi?id=38597
7
8         Fix behavior so reload button really acts as a load and a reload button.
9
10         * QtTestBrowser/mainwindow.cpp:
11         (MainWindow::changeLocation):
12
13 2010-06-28  Xan Lopez  <xlopez@igalia.com>
14
15         Reviewed by Gustavo Noronha.
16
17         [GTK] Does not compile with -DGSEAL_ENABLE
18         https://bugs.webkit.org/show_bug.cgi?id=37851
19
20         Fix build with GSEAL enabled.
21
22         * DumpRenderTree/gtk/EventSender.cpp:
23         (gtk_widget_get_window):
24         (prepareMouseButtonEvent):
25         (mouseMoveToCallback):
26         (mouseWheelToCallback):
27         (keyDownCallback):
28
29 2010-06-28  Xan Lopez  <xlopez@igalia.com>
30
31         Reviewed by Gustavo Noronha.
32
33         [GTK] Add support for GTK+3
34         https://bugs.webkit.org/show_bug.cgi?id=41253
35
36         Adapt build system for 3.x support.
37
38         * GNUmakefile.am:
39
40 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
41
42         Reviewed by Simon Hausmann.
43
44         [QT][S60] build-webkit scripts picks wrong make spec for windows build
45         https://bugs.webkit.org/show_bug.cgi?id=41198
46
47         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
48
49         * Scripts/webkitdirs.pm:
50         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
51
52 2010-06-28  Eric Seidel  <eric@webkit.org>
53
54         Reviewed by Adam Barth.
55
56         Make it possible to test the new HTML5 TreeBuilder
57         https://bugs.webkit.org/show_bug.cgi?id=41276
58
59         Adam was concerned that someone might make their port
60         depend on this setting (I guess we had some trouble with that
61         with the HTML5Parser setting), so I littered the code with warnings.
62
63         test-html5-parser now tests this code path.
64
65         * DumpRenderTree/mac/DumpRenderTree.mm:
66         (resetDefaultsToConsistentValues):
67         (initializeGlobalsFromCommandLineOptions):
68         * Scripts/test-html5-parser:
69
70 2010-06-27  MORITA Hajime  <morrita@google.com>
71
72         Unreviewed. 
73         
74         Some never-called @staticmethods touched self. 
75         Fixed it to replace these self with a class.
76
77         * Scripts/webkitpy/common/checkout/scm.py:
78
79 2010-06-27  MORITA Hajime  <morrita@google.com>
80
81         Unreviewed.
82         
83         Fixed exception raising syntax that is pointed out at
84         https://bugs.webkit.org/show_bug.cgi?id=41153
85
86         * Scripts/webkitpy/common/checkout/scm.py:
87         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
88           Removed a bad line that I accidentally checked-in at last revision.
89
90 2010-06-24  MORITA Hajime  <morrita@google.com>
91
92         Reviewed by Eric Seidel.
93
94         rebaseline-chromium-webkit-tests should add or remove files to local git repository
95         https://bugs.webkit.org/show_bug.cgi?id=41153
96
97         - Added SCM.add() and SCM.remove()
98         - Replaced "svn add" and "svn remove"
99           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
100         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
101           for debugging purpose.
102
103         * Scripts/webkitpy/common/checkout/scm.py:
104         * Scripts/webkitpy/common/checkout/scm_unittest.py:
105         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
106
107 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
108
109         Reviewed by Shinichiro Hamaji.
110
111         Improve default value handling for page format properties.
112         https://bugs.webkit.org/show_bug.cgi?id=41150
113
114         * DumpRenderTree/LayoutTestController.cpp:
115         (parsePageNumber):
116         (parsePageNumberSizeMarings):
117         (pageSizeAndMarginsInPixelsCallback):
118         (LayoutTestController::staticFunctions):
119         * DumpRenderTree/LayoutTestController.h:
120         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
121         (LayoutTestController::pageSizeAndMarginsInPixels):
122         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
123         (LayoutTestController::pageSizeAndMarginsInPixels):
124         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
125         (LayoutTestController::pageSizeAndMarginsInPixels):
126
127 2010-06-21  Robert Hogan  <robert@webkit.org>
128
129         Reviewed by Kenneth Rohde Christiansen.
130
131         [Qt] DRT Support for setCustomPolicyDelegate
132
133         https://bugs.webkit.org/show_bug.cgi?id=39564
134
135         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
136         (LayoutTestController::setCustomPolicyDelegate):
137         * DumpRenderTree/qt/LayoutTestControllerQt.h:
138
139 2010-06-26  Robert Hogan  <robert@webkit.org>
140
141         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
142         
143         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
144         exported.
145
146         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
147
148 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
149
150         Reviewed by Dimitri Glazkov.
151
152         Add a build-webkit option for enabling Web Timing support.
153         https://bugs.webkit.org/show_bug.cgi?id=38924
154
155         * Scripts/build-webkit:
156
157 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
158
159         Reviewed by Kenneth Rohde Christiansen.
160
161         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
162         https://bugs.webkit.org/show_bug.cgi?id=38597
163
164         Make the reload button act as a load button as well.
165
166         * QtTestBrowser/mainwindow.cpp:
167         (MainWindow::buildUI):
168         (MainWindow::changeLocation):
169
170 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
171
172         Reviewed by Dmitry Titov.
173
174         Add empty abortModal() method to all platforms.
175         https://bugs.webkit.org/show_bug.cgi?id=40864
176
177         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
178         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
179         that use abortModal will become mac specific which is not desirable.
180
181         * DumpRenderTree/LayoutTestController.cpp:
182         (abortModalCallback):
183         (LayoutTestController::staticFunctions):
184         * DumpRenderTree/LayoutTestController.h:
185         * DumpRenderTree/chromium/LayoutTestController.cpp:
186         (LayoutTestController::LayoutTestController):
187         (LayoutTestController::abortModal):
188         * DumpRenderTree/chromium/LayoutTestController.h:
189         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
190         (LayoutTestController::abortModal):
191         * DumpRenderTree/qt/LayoutTestControllerQt.h:
192         (LayoutTestController::abortModal):
193         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
194         (LayoutTestController::abortModal):
195         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
196         (LayoutTestController::abortModal):
197
198 2010-06-25  Sam Weinig  <sam@webkit.org>
199
200         Reviewed by Anders Carlsson.
201
202         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
203         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
204
205         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
206         (WTR::InjectedBundle::shared):
207         (WTR::InjectedBundle::InjectedBundle):
208         (WTR::InjectedBundle::_didCreatePage):
209         (WTR::InjectedBundle::_willDestroyPage):
210         (WTR::InjectedBundle::_didRecieveMessage):
211         (WTR::InjectedBundle::initialize):
212         (WTR::InjectedBundle::didCreatePage):
213         (WTR::InjectedBundle::willDestroyPage):
214         (WTR::InjectedBundle::didRecieveMessage):
215         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
216         (WTR::InjectedBundle::layoutTestController):
217         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
218         (WKBundleInitialize):
219         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
220         (WTR::InjectedBundlePage::InjectedBundlePage):
221         (WTR::InjectedBundlePage::~InjectedBundlePage):
222         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
223         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
224         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
225         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
226         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
227         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
228         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
229         (WTR::InjectedBundlePage::_didClearWindowForFrame):
230         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
231         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
232         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
233         (WTR::InjectedBundlePage::didCommitLoadForFrame):
234         (WTR::InjectedBundlePage::didFinishLoadForFrame):
235         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
236         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
237         (WTR::InjectedBundlePage::didClearWindowForFrame):
238         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
239         (WTR::InjectedBundlePage::page):
240         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
241         (WTR::LayoutTestController::create):
242         (WTR::LayoutTestController::LayoutTestController):
243         (WTR::LayoutTestController::~LayoutTestController):
244         (WTR::dumpAsTextCallback):
245         (WTR::layoutTestControllerObjectFinalize):
246         (WTR::LayoutTestController::makeWindowObject):
247         (WTR::LayoutTestController::getJSClass):
248         (WTR::LayoutTestController::staticFunctions):
249         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
250         (WTR::LayoutTestController::dumpAsText):
251         (WTR::LayoutTestController::setDumpAsText):
252         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
253
254 2010-06-25  Sam Weinig  <sam@webkit.org>
255
256         Reviewed by Anders Carlsson.
257
258         Make WebKitTestRunner really work with run-webkit-tests. 
259
260         - Add Forwarding headers to allow some cleanup.
261
262         * WebKitTestRunner/ForwardingHeaders: Added.
263         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
264         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
265         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
266         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
267         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
268         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
269         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
270         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
271         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
272         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
273         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
274         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
275         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
276         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
277         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
278         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
279         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
280         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
281         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
282         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
283         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
284         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
285         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
286         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
287         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
288         * WebKitTestRunner/TestInvocation.cpp:
289         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
290         * WebKitTestRunner/TestInvocation.h:
291
292 2010-06-25  Sam Weinig  <sam@webkit.org>
293
294         Reviewed by Mark Rowe.
295
296         Add support for WebKitTestRunner to old-run-webkit-tests
297
298         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
299
300         * Scripts/build-webkittestrunner: Added.
301         * Scripts/old-run-webkit-tests:
302
303 2010-06-25  Adam Barth  <abarth@webkit.org>
304
305         Reviewed by David Levin.
306
307         Incremental build failed on Chromium ews
308         https://bugs.webkit.org/show_bug.cgi?id=41011
309
310         The division of responsibility between update-webkit --chromium and
311         build-webkit --chromium is slightly unclear.  In this patch, we make
312         build-webkit --chromium also update DEPS and re-run GYP in case the
313         developer has changed either since they updated.
314
315         This change is also helpful for the EWS, which wants to update DEPS and
316         re-run GYP after applying patches, but the EWS doesn't want to run
317         update-webkit --chromium because it has a dirty working copy.
318
319         * Scripts/webkitdirs.pm:
320
321 2010-06-25  Robert Hogan  <robert@webkit.org>
322
323         Reviewed by Simon Hausmann.
324
325         [Qt] Support evaluateScriptInIsolatedWorld()
326
327         https://bugs.webkit.org/show_bug.cgi?id=40079
328
329         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
330         Remove QWebScriptWorld from exported headers.
331         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
332
333         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
334         (LayoutTestController::reset):
335         (LayoutTestController::evaluateScriptInIsolatedWorld):
336         * DumpRenderTree/qt/LayoutTestControllerQt.h:
337
338 2010-06-25  Anders Carlsson  <andersca@apple.com>
339
340         Revert accidental part and add a newline.
341
342         * MiniBrowser/mac/AppDelegate.m:
343         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
344
345 2010-06-25  Anders Carlsson  <andersca@apple.com>
346
347         Rubber-stamped by Dan Bernstein.
348
349         Add a LOG macro that expands to a no-op by default.
350
351         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
352         * MiniBrowser/mac/AppDelegate.m:
353         (_didRecieveMessageFromInjectedBundle):
354         * MiniBrowser/mac/BrowserWindowController.m:
355         (-[BrowserWindowController windowShouldClose:]):
356         (_didStartProvisionalLoadForFrame):
357         (_didReceiveServerRedirectForProvisionalLoadForFrame):
358         (_didFailProvisionalLoadWithErrorForFrame):
359         (_didCommitLoadForFrame):
360         (_didFinishLoadForFrame):
361         (_didFailLoadWithErrorForFrame):
362         (_didReceiveTitleForFrame):
363         (_didFirstLayoutForFrame):
364         (_didFirstVisuallyNonEmptyLayoutForFrame):
365         (_didBecomeUnresponsive):
366         (_didBecomeResponsive):
367         (_decidePolicyForNavigationAction):
368         (_decidePolicyForNewWindowAction):
369         (_createNewPage):
370         (_showPage):
371         (_closePage):
372         (_didNavigateWithNavigationData):
373         (_didPerformClientRedirect):
374         (_didPerformServerRedirect):
375         (_didUpdateHistoryTitle):
376         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
377         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
378         (_didClearWindowForFrame):
379         (_didCreatePage):
380         (_willDestroyPage):
381         (_didRecieveMessage):
382
383 2010-06-24  Adam Barth  <abarth@webkit.org>
384
385         Reviewed by Eric Seidel.
386
387         commit-queue is taking too long to land patches because of red trees
388         https://bugs.webkit.org/show_bug.cgi?id=41194
389
390         Instead of checking for the tree to be green, we'll just spin hot
391         trying to land patches.  This is probably too extreme in ignoring the
392         tree, but I think we should try it for a while to see if we have
393         trouble.  That will help us find the right balance.
394
395         * Scripts/webkitpy/tool/commands/queues.py:
396         * Scripts/webkitpy/tool/commands/queues_unittest.py:
397
398 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
399
400         Reviewed by Xan Lopez.
401
402         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
403         https://bugs.webkit.org/show_bug.cgi?id=40843
404
405         Define the version for old GTK+s in a way that is forward-compatible
406         and clean up the logic a bit.
407
408         * DumpRenderTree/gtk/EventSender.cpp:
409         (gdk_window_get_root_coords): Renamed and cleaned up.
410         (prepareMouseButtonEvent): Remove #ifdefs.
411         (mouseMoveToCallback): Remove #ifdefs.
412
413 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
414
415         Reviewed by Eric Seidel.
416
417         Fix NewRunWebKitTests to work on Windows.
418         https://bugs.webkit.org/show_bug.cgi?id=41180
419
420         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
421             because Windows fails to understand what we're asking of it.
422
423 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
424
425         Reviewed by Xan Lopez.
426
427         [GTK] The url passed to the WebView during layout tests is invalid
428         https://bugs.webkit.org/show_bug.cgi?id=40832
429
430         Set the test URL to the full real file URL and do a small cleanup.
431         Previously a URL like file://relative/path/to/test.html was passed
432         to the WebView. This malformed file URL would be returned by
433         webkit_web_view_get_url and webkit_web_frame_get_url.
434
435         * DumpRenderTree/gtk/DumpRenderTree.cpp:
436         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
437         (shouldOpenWebInspector): Change to take a const string& as the argument.
438         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
439         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
440
441 2010-06-24  Sam Weinig  <sam@webkit.org>
442
443         Reviewed by Anders Carlsson.
444
445         Fix WebKitTestRunner Makefile typos.
446
447         * WebKitTestRunner/Makefile:
448
449 2010-06-24  Adele Peterson  <adele@apple.com>
450
451         Reviewed by Eric Carlson.
452
453         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
454         https://bugs.webkit.org/show_bug.cgi?id=41085
455
456         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
457         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
458
459 2010-06-23  Sam Weinig  <sam@webkit.org>
460
461         Reviewed by Anders Carlsson.
462
463         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
464         Add new WebKitTestRunner project (ie. DRT for WebKit2).
465
466         - Mac only.
467         - run-webkit-tests has not been modified to call it yet.
468         - Only dumps the render tree at this time. 
469
470         * WebKitTestRunner: Added.
471         * WebKitTestRunner/Configurations: Added.
472         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
473         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
474         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
475         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
476         * WebKitTestRunner/InjectedBundle: Added.
477         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
478         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
479         (_didStartProvisionalLoadForFrame):
480         (_didReceiveServerRedirectForProvisionalLoadForFrame):
481         (_didFailProvisionalLoadWithErrorForFrame):
482         (_didCommitLoadForFrame):
483         (_didFinishLoadForFrame):
484         (_didFailLoadWithErrorForFrame):
485         (_didReceiveTitleForFrame):
486         (_didClearWindow):
487         (_didCreatePage):
488         (_willDestroyPage):
489         (_didRecieveMessage):
490         (WKBundleInitialize):
491         * WebKitTestRunner/Makefile: Added.
492         * WebKitTestRunner/PlatformWebView.h: Added.
493         (WTR::PlatformWebView::platformView):
494         * WebKitTestRunner/TestController.cpp: Added.
495         (WTR::TestController::shared):
496         (WTR::TestController::TestController):
497         (WTR::TestController::initialize):
498         (WTR::TestController::runTest):
499         (WTR::TestController::runTestingServerLoop):
500         (WTR::TestController::run):
501         * WebKitTestRunner/TestController.h: Added.
502         (WTR::TestController::verbose):
503         (WTR::TestController::injectedBundlePath):
504         * WebKitTestRunner/TestInvocation.cpp: Added.
505         (WTR::createWKURL):
506         (WTR::TestInvocation::TestInvocation):
507         (WTR::TestInvocation::~TestInvocation):
508         (WTR::TestInvocation::invoke):
509         (WTR::TestInvocation::dump):
510         (WTR::TestInvocation::initializeMainWebView):
511         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
512         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
513         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
514         (WTR::TestInvocation::didCommitLoadForFrame):
515         (WTR::TestInvocation::didFinishLoadForFrame):
516         (WTR::TestInvocation::didFailLoadForFrame):
517         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
518         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
519         * WebKitTestRunner/TestInvocation.h: Added.
520         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
521         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
522         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
523         * WebKitTestRunner/mac: Added.
524         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
525         (WTR::PlatformWebView::PlatformWebView):
526         (WTR::PlatformWebView::~PlatformWebView):
527         (WTR::PlatformWebView::page):
528         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
529         (WTR::TestInvocation::runUntil):
530         * WebKitTestRunner/mac/main.mm: Added.
531         (main):
532
533 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
534
535         Unreviewed. Adding myself to the committers list.
536
537         * Scripts/webkitpy/common/config/committers.py:
538
539 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
540
541         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
542
543         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
544         (LayoutTestController::isPageBoxVisible):
545         (LayoutTestController::pageAreaRectInPixels):
546         (LayoutTestController::preferredPageSizeInPixels):
547         * wx/build/settings.py:
548
549 2010-06-23  James Robinson  <jamesr@chromium.org>
550
551         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
552
553         * Scripts/webkitpy/common/config/committers.py:
554
555 2010-06-23  Kent Tamura  <tkent@chromium.org>
556
557         Reviewed by Dimitri Glazkov.
558
559         Correct Chromium test configuration
560         https://bugs.webkit.org/show_bug.cgi?id=41057
561
562         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
563          - Add "--use-drt" option for NRWT. It is required for Chromium and
564            ignored for other platforms.
565          - Skip JSC test on Chromium
566         * BuildSlaveSupport/test-result-archive:
567           Add Chromium support.
568
569 2010-06-23  Sam Weinig  <sam@webkit.org>
570
571         Reviewed by Anders Carlsson.
572
573         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
574         WebKit2: Flesh out more of the InjectedBundle client API
575
576         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
577         (_didStartProvisionalLoadForFrame):
578         (_didReceiveServerRedirectForProvisionalLoadForFrame):
579         (_didFailProvisionalLoadWithErrorForFrame):
580         (_didCommitLoadForFrame):
581         (_didFinishLoadForFrame):
582         (_didFailLoadWithErrorForFrame):
583         (_didReceiveTitleForFrame):
584         (_didClearWindowForFrame):
585         (_didCreatePage):
586         (_willDestroyPage):
587         (WKBundleInitialize):
588
589 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
590
591         Reviewed by Shinichiro Hamaji.
592
593         Implement page format data programming interface.
594         Add methods for testing.
595         https://bugs.webkit.org/show_bug.cgi?id=37538
596
597         * DumpRenderTree/LayoutTestController.cpp:
598         (parsePageNumber):
599         (isPageBoxVisibleCallback):
600         (pageAreaRectInPixelsCallback):
601         (preferredPageSizeInPixelsCallback):
602         (LayoutTestController::staticFunctions):
603         * DumpRenderTree/LayoutTestController.h:
604         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
605         (LayoutTestController::isPageBoxVisible):
606         (LayoutTestController::pageAreaRectInPixels):
607         (LayoutTestController::preferredPageSizeInPixels):
608         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
609         (LayoutTestController::isPageBoxVisible):
610         (LayoutTestController::pageAreaRectInPixels):
611         (LayoutTestController::preferredPageSizeInPixels):
612         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
613         (LayoutTestController::isPageBoxVisible):
614         (LayoutTestController::pageAreaRectInPixels):
615         (LayoutTestController::preferredPageSizeInPixels):
616
617 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
618
619         Reviewed by Shinichiro Hamaji.
620
621         Follow proper convention for if/switch/while as I've discovered
622         them to be through my review processes.
623         https://bugs.webkit.org/show_bug.cgi?id=40723
624
625         Modified test so that if( foo ) is not allowed as it appears not
626         to be the accepted convention.
627
628         * Scripts/webkitpy/style/checkers/cpp.py:
629         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
630
631 2010-06-22  Eric Seidel  <eric@webkit.org>
632
633         Reviewed by Adam Barth.
634
635         Run clean-header-guards to fix some header guards
636         https://bugs.webkit.org/show_bug.cgi?id=41044
637
638         No functional changes, thus no tests.
639
640         This entire change was generated by running
641         clean-header-guards, and then reverting changes
642         to files which shouldn't be changed.  Those which
643         are left all should be updated.
644
645         Some of these changes are just fixing 755 permissions
646         to be 644, since it seems various files have the wrong
647         execute bit which don't need it.  clean-header-guards
648         made those (welcome) permission fixes unintentionally.
649
650         * DumpRenderTree/chromium/WebThemeControlDRT.h:
651         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
652         * QtTestBrowser/fpstimer.h:
653
654 2010-06-22  Adam Barth  <abarth@webkit.org>
655
656         Reviewed by Eric Seidel.
657
658         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
659         https://bugs.webkit.org/show_bug.cgi?id=41043
660
661         Update the hash.
662
663         * Scripts/do-webcore-rename:
664
665 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
666
667         Reviewed by Shinichiro Hamaji.
668
669         Follow proper convention for variable declaration spacing.
670         https://bugs.webkit.org/show_bug.cgi?id=40724
671
672         Modified test so that 'int   a;' is not allowed.
673
674         * Scripts/webkitpy/style/checkers/cpp.py:
675         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
676
677 2010-06-22  Eric Seidel  <eric@webkit.org>
678
679         Unreviewed.  Add Tony Gentilcore now that he's a committer.
680
681         * Scripts/webkitpy/common/config/committers.py:
682
683 2010-06-22  Eric Seidel  <eric@webkit.org>
684
685         Reviewed by Adam Barth.
686
687         Remove Gtk 64-Release bot from core since it's broken
688         https://bugs.webkit.org/show_bug.cgi?id=41022
689
690         This bot alone has been responsible for more than 72 hours of
691         commit-queue blockage in the last week.  The bot is broken -- keeps
692         losing its display server or similar.  Until the Gtk folks can fix the
693         bot, we need to remove it from core.  The WebKit community can't keep
694         it green as is.
695
696         * Scripts/webkitpy/common/net/buildbot.py:
697         * Scripts/webkitpy/common/net/buildbot_unittest.py:
698
699 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
700
701         Reviewed by Eric Seidel.
702
703         Fix the Windows build.
704         https://bugs.webkit.org/show_bug.cgi?id=40972
705
706         * DumpRenderTree/win/ImageDiff.vcproj:
707
708 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
709
710         Reviewed by Darin Adler, Dmitry Titov.
711
712         DumpRenderTree should allow tests with modal dialogs
713         https://bugs.webkit.org/show_bug.cgi?id=35350
714
715         * DumpRenderTree/LayoutTestController.cpp:
716         (abortModalCallback):
717         (LayoutTestController::staticFunctions):
718         * DumpRenderTree/LayoutTestController.h:
719         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
720         (LayoutTestController::abortModal):
721         Add abortModal method to LayoutTestController and make it available from script.
722
723         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
724         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
725         abortModal from when modal window closes.
726         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
727
728 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
729
730         Reviewed by Anders Carlsson.
731         
732         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
733         https://bugs.webkit.org/show_bug.cgi?id=40948
734         
735         Have the script look in WebKit2.
736
737         * Scripts/do-webcore-rename:
738
739 2010-06-21  Robert Hogan  <robert@webkit.org>
740
741         Reviewed by Kenneth Rohde Christiansen.
742
743         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
744
745         It's a Mac-specific test so just add the required LayoutTestController
746         function as a no-op to avoid failing. Similar approach adopted by other
747         ports.
748
749         https://bugs.webkit.org/show_bug.cgi?id=33344
750
751         * DumpRenderTree/qt/LayoutTestControllerQt.h:
752         (LayoutTestController::addDisallowedURL):
753
754 2010-06-21  Sam Weinig  <sam@webkit.org>
755
756         Reviewed by Anders Carlsson.
757
758         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
759         Add message passing support to the WebKit2 API.
760
761         - Add some test messages.
762
763         * MiniBrowser/mac/AppDelegate.m:
764         (_didRecieveMessageFromInjectedBundle):
765         (-[BrowserAppDelegate init]):
766         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
767         (_didClearWindow):
768         (_didCreatePage):
769         (_didRecieveMessage):
770         (WKBundleInitialize):
771
772 2010-06-21  Drew Wilson  <atwilson@chromium.org>
773
774         Unreviewed.
775
776         Rolling back 61551 and 61555 due to test failures.
777
778         * DumpRenderTree/LayoutTestController.cpp:
779         (LayoutTestController::staticFunctions):
780         * DumpRenderTree/LayoutTestController.h:
781         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
782         (LayoutTestController::setEditingBehavior):
783         * DumpRenderTree/mac/UIDelegate.mm:
784
785 2010-06-21  Anders Carlsson  <andersca@apple.com>
786
787         Reviewed by Sam Weinig.
788
789         Make DumpRenderTree build with clang++
790
791         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
792         (-[LocalPasteboard setPropertyList:forType:]):
793         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
794         (-[DumpRenderTreeWindow keyDown:]):
795         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
796         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
797         (LayoutTestController::isCommandEnabled):
798
799 2010-06-21  Satish Sampath  <satish@chromium.org>
800
801         Reviewed by Steve Block.
802
803         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
804         https://bugs.webkit.org/show_bug.cgi?id=40878
805
806         * Scripts/build-webkit:
807
808 2010-06-21  Kent Tamura  <tkent@chromium.org>
809
810         Reviewed by Dimitri Glazkov.
811
812         [DRT/Chromium] Initialization for http/tests/loading/
813         https://bugs.webkit.org/show_bug.cgi?id=40902
814
815         * DumpRenderTree/chromium/TestShell.cpp:
816         (TestShell::runFileTest):
817
818 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
819
820         Unreviewed.
821
822         Adding myself to the committers list.
823
824         * Scripts/webkitpy/common/config/committers.py:
825
826 2010-06-20  Kent Tamura  <tkent@chromium.org>
827
828         Reviewed by Dimitri Glazkov.
829
830         [DRT/Chromium] Add --allow-external-pages option
831         https://bugs.webkit.org/show_bug.cgi?id=40762
832
833         Add --allow-external-pages introduced by Chromium r45403.
834         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
835
836         * DumpRenderTree/chromium/DumpRenderTree.cpp:
837         (main):
838         * DumpRenderTree/chromium/TestShell.cpp:
839         (TestShell::TestShell):
840         * DumpRenderTree/chromium/TestShell.h:
841         (TestShell::allowExternalPages):
842         (TestShell::setAllowExternalPages):
843         * DumpRenderTree/chromium/WebViewHost.cpp:
844         (WebViewHost::willSendRequest):
845
846 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
847
848         Reviewed by Adam Barth.
849
850         Sheriffbot: Should allow "r" in SVN_REVISION
851         https://bugs.webkit.org/show_bug.cgi?id=40889
852
853         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
854         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
855
856 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
857
858         Reviewed by Dimitri Glazkov.
859
860         Python Tests Fail after r61508
861         https://bugs.webkit.org/show_bug.cgi?id=40891
862
863         Test's regex list needed to be updated to match the new
864         regex list in the source code. Added new bots to the
865         example_buildbots list.
866
867         Regex list fixed in r61512. Updated bot list.
868
869         * Scripts/webkitpy/common/net/buildbot_unittest.py:
870
871 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
872
873         Unreviewed, build fix.
874
875         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
876
877         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
878
879 2010-06-19  Justin Schuh  <jschuh@chromium.org>
880
881         Unreviewed.
882
883         Adding myself to the committers list.
884
885         * Scripts/webkitpy/common/config/committers.py:
886
887 2010-06-19  Sam Weinig  <sam@webkit.org>
888
889         Reviewed by Anders Carlsson.
890
891         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
892         Add ability to have a WebProcess per WebContext.
893
894         Move to use new shared contexts API.
895
896         * MiniBrowser/mac/AppDelegate.h:
897         * MiniBrowser/mac/AppDelegate.m:
898         (-[BrowserAppDelegate init]):
899         (-[BrowserAppDelegate getCurrentPageNamespace]):
900         (-[BrowserAppDelegate validateMenuItem:]):
901         (-[BrowserAppDelegate _setProcessModel:]):
902         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
903         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
904         * MiniBrowser/win/BrowserView.cpp:
905         (BrowserView::create):
906
907 2010-06-02  Robert Hogan  <robert@webkit.org>
908
909         Reviewed by Adam Barth.
910
911         [Qt] Support evaluateScriptInIsolatedWorld()
912
913         https://bugs.webkit.org/show_bug.cgi?id=40079
914
915         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
916         (LayoutTestController::evaluateScriptInIsolatedWorld):
917         * DumpRenderTree/qt/LayoutTestControllerQt.h:
918
919 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
920
921         Reviewed by Darin Adler.
922
923         Add three more non-core Chromium builders to start testing DumpRenderTree.
924         https://bugs.webkit.org/show_bug.cgi?id=40335
925
926         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
927
928 2010-06-18  Drew Wilson  <atwilson@chromium.org>
929
930         Reviewed by Darin Fisher.
931
932         [Chromium] Plumbing for top-level frame names
933         https://bugs.webkit.org/show_bug.cgi?id=40430
934
935         * DumpRenderTree/chromium/WebViewHost.cpp:
936         (WebViewHost::reset):
937         Changed obsolete call to clearName() to use setName(WebString()) instead.
938
939 2010-06-18  Sam Weinig  <weinig@apple.com>
940
941         Rolling http://trac.webkit.org/changeset/61297 back in.
942
943         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
944         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
945         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
946         (_didClearWindow):
947         (_didCreatePage):
948         (WKBundleInitialize):
949
950 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
951
952         Reviewed by Darin Adler.
953
954         https://bugs.webkit.org/show_bug.cgi?id=40803
955         TestNetscapePlugin has an incorrect implementation of "property" property
956
957         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
958         pass a static string back, it's going to be released by NPAPI implementation.
959
960 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
961
962         Unreviewed.
963
964         Adding myself to the committers list.
965
966         * Scripts/webkitpy/common/config/committers.py:
967
968 2010-06-17  Tony Chang  <tony@chromium.org>
969
970         Reviewed by Kent Tamura.
971
972         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
973         https://bugs.webkit.org/show_bug.cgi?id=40615
974
975         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
976
977 2010-06-17  Ada Chan  <adachan@apple.com>
978
979         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
980
981         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
982         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
983         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
984
985 2010-06-17  Darin Adler  <darin@apple.com>
986
987         One more try at fix for Chromium build.
988
989         * DumpRenderTree/chromium/TestShell.cpp:
990         (TestShell::TestShell): Use set again instead of =.
991
992 2010-06-17  Darin Adler  <darin@apple.com>
993
994         Fix Chromium build.
995
996         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
997         code with all the other platforms! Wow, that should be fixed at some point.
998
999         * DumpRenderTree/chromium/TestShell.cpp:
1000         (TestShell::TestShell): Changed back to using "new".
1001         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
1002
1003 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
1004
1005         Unreviewed Qt build fix.
1006
1007         LayoutTestController in the Qt DRT is not using refs :)
1008
1009         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1010         (WebCore::DumpRenderTree::DumpRenderTree):
1011
1012 2010-06-17  Darin Adler  <darin@apple.com>
1013
1014         Reviewed by Sam Weinig.
1015
1016         Use adoptRef and create functions in more code paths
1017         https://bugs.webkit.org/show_bug.cgi?id=40760
1018
1019         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
1020
1021         * DumpRenderTree/LayoutTestController.cpp:
1022         (LayoutTestController::create): Added.
1023         * DumpRenderTree/LayoutTestController.h: Declare the create function.
1024
1025         * DumpRenderTree/chromium/TestShell.cpp:
1026         (TestShell::TestShell): Use create instead of new.
1027         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
1028
1029         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1030         (runTest): Use RefPtr and create instead of OwnPtr and new.
1031
1032         * DumpRenderTree/mac/DumpRenderTree.mm:
1033         (runTest): Use RefPtr and create instead of OwnPtr and new.
1034
1035         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1036         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
1037         instead of new.
1038
1039         * DumpRenderTree/win/DumpRenderTree.cpp:
1040         (runTest): Use RefPtr and create instead of OwnPtr and new.
1041
1042         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1043         (runTest): Use RefPtr and create instead of OwnPtr and new.
1044         (MyApp::OnInit): Removed unneeded code to delete the layout
1045         test controller. This is done during each test.
1046
1047 2010-06-17  Kent Tamura  <tkent@chromium.org>
1048
1049         Reviewed by Shinichiro Hamaji.
1050
1051         [DRT/Chromium] Fix a bug of Windows pixel tests
1052         https://bugs.webkit.org/show_bug.cgi?id=40763
1053
1054         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1055         (TestShellPrinter::handleImage):
1056
1057 2010-06-16  Kent Tamura  <tkent@chromium.org>
1058
1059         Reviewed by Shinichiro Hamaji.
1060
1061         [DRT/Chromium] Fix crash on Mac Release
1062         https://bugs.webkit.org/show_bug.cgi?id=40759
1063
1064         * DumpRenderTree/chromium/WebViewHost.cpp:
1065         (WebViewHost::paintRect): We should not use m_canvas directly because
1066           it is created lazily in canvas().
1067
1068 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
1069
1070         [wx] Build fix after new method addition.
1071
1072         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1073         (LayoutTestController::pageProperty):
1074
1075 2010-06-16  Kent Tamura  <tkent@chromium.org>
1076
1077         Reviewed by Dimitri Glazkov.
1078
1079         [DRT/Chromium] Set current working directory for each of tests
1080         https://bugs.webkit.org/show_bug.cgi?id=40668
1081
1082         This change fixes tests with eventSender.beginDragWithFiles().
1083
1084         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1085         (runTest):
1086
1087 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
1088
1089         Reviewed by Gustavo Noronha Silva.
1090
1091         [GTK] r60803 broke media/controls-drag-timebar.html
1092         https://bugs.webkit.org/show_bug.cgi?id=40269
1093
1094         Only queue events while the mouse button is down, if drag mode is enabled. Some
1095         tests may disable drag mode, to prevent the queuing of events in this situation.
1096
1097         * DumpRenderTree/gtk/EventSender.cpp:
1098         (sendOrQueueEvent): Only queue events here if dragMode is true.
1099
1100 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
1101
1102         Reviewed by Gustavo Noronha Silva.
1103
1104         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
1105         https://bugs.webkit.org/show_bug.cgi?id=40600
1106
1107         * DumpRenderTree/gtk/EventSender.cpp:
1108         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
1109
1110 2010-06-16  Adam Barth  <abarth@webkit.org>
1111
1112         Reviewed by Dimitri Glazkov.
1113
1114         Add a hidden land-cowboy command to webkit-patch to help land quick
1115         build fixes.
1116
1117         * Scripts/webkitpy/tool/commands/download.py:
1118         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1119
1120 2010-06-16  Adam Roben  <aroben@apple.com>
1121
1122         Convert console messages to UTF-8 before printing them
1123
1124         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
1125         http/tests/security/xssAuditor/embed-tag-null-char.html and
1126         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
1127         Windows. (I can't test the fix because Apache is crashing on my
1128         computer.)
1129
1130         Reviewed by Alexey Proskuryakov.
1131
1132         * DumpRenderTree/win/DumpRenderTree.cpp:
1133         (toUTF8): Extracted the code into an overload that takes a wide string
1134         and a length, then added an overload that takes a wstring.
1135
1136         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
1137         overload.
1138
1139         * DumpRenderTree/win/UIDelegate.cpp:
1140         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
1141         UTF-8 instead of letting printf convert to the current code page.
1142
1143 2010-06-16  Drew Wilson  <atwilson@chromium.org>
1144
1145         Reviewed by Kent Tamura.
1146
1147         [Chromium] Plumbing for top-level frame names
1148         https://bugs.webkit.org/show_bug.cgi?id=40430
1149
1150         * DumpRenderTree/chromium/WebViewHost.cpp:
1151         (WebViewHost::createView):
1152         Migrate to new createView() API.
1153         * DumpRenderTree/chromium/WebViewHost.h:
1154         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
1155
1156 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
1157
1158         Reviewed by Kenneth Rohde Christiansen.
1159
1160         [Qt] Scroll wheel event support to graphics based DRT
1161         https://bugs.webkit.org/show_bug.cgi?id=40577
1162
1163         * DumpRenderTree/qt/EventSenderQt.cpp:
1164         (EventSender::continuousMouseScrollBy):
1165         (EventSender::createGraphicsSceneWheelEvent):
1166         * DumpRenderTree/qt/EventSenderQt.h:
1167
1168 2010-06-16  Adam Roben  <aroben@apple.com>
1169
1170         Remove a stray newline from the Windows version of TestNetscapePlugin
1171
1172         Reviewed by Alexey Proskuryakov.
1173
1174         Fixes <http://webkit.org/b/40728>
1175         plugins/geturlnotify-during-document-teardown.html fails on Windows
1176
1177         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1178         (NPP_Destroy): Removed extra newline that the Mac version doesn't
1179         have.
1180
1181 2010-06-16  Adam Roben  <aroben@apple.com>
1182
1183         Respect LayoutTestController::isPrinting on Windows
1184
1185         This gets some printing tests closer to passing (like
1186         printing/page-rule-in-media-query.html).
1187
1188         Fixes <http://webkit.org/b/40727>.
1189
1190         Reviewed by Dan Bernstein.
1191
1192         * DumpRenderTree/win/DumpRenderTree.cpp:
1193         (dump): Pass LayoutTestController::isPrinting to
1194         IWebFramePrivate::renderTreeAsExternalRepresentation.
1195
1196 2010-06-15  Adam Barth  <abarth@webkit.org>
1197
1198         Reviewed by Eric Seidel.
1199
1200         Enable HTML5 lexer
1201         https://bugs.webkit.org/show_bug.cgi?id=40650
1202
1203         * DumpRenderTree/mac/DumpRenderTree.mm:
1204         (initializeGlobalsFromCommandLineOptions):
1205
1206 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
1207
1208         Reviewed by Shinichiro Hamaji.
1209
1210         Implement render style selection for pages to support CSS3 Paged Media.
1211         https://bugs.webkit.org/show_bug.cgi?id=35961
1212
1213         * DumpRenderTree/LayoutTestController.cpp:
1214         (parsePagePropertyParameters):
1215         (pagePropertyCallback):
1216         (LayoutTestController::staticFunctions):
1217         * DumpRenderTree/LayoutTestController.h:
1218         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1219         (LayoutTestController::pageProperty):
1220         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1221         (LayoutTestController::pageProperty):
1222         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1223         (LayoutTestController::pageProperty):
1224
1225 2010-06-15  Sam Weinig  <sam@webkit.org>
1226
1227         Reviewed by Anders Carlsson.
1228
1229         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
1230         WebKit2: Add mechanism to inject code into the WebProcess on startup
1231
1232         Add initial InjectedBundle support.
1233
1234         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1235         * MiniBrowser/WebBundle-Info.plist: Added.
1236         Add test InjectedBundle to the project.
1237
1238         * MiniBrowser/mac/AppDelegate.m:
1239         (-[BrowserAppDelegate init]):
1240         Get the path to the WebBundle from the the main bundle and pass it to the new
1241         WKContextCreateWithInjectedBundlePath function.
1242
1243         * MiniBrowser/mac/BrowserWindowController.m:
1244         (_didChangeProgress):
1245         Fix the build.  This has been broken for a while.
1246
1247         * MiniBrowser/mac/WebBundle: Added.
1248         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
1249         (_didCreatePage):
1250         (WKBundleInitialize):
1251         Add really basic InjectedBundle.
1252
1253         * MiniBrowser/win/BrowserView.cpp:
1254         (BrowserView::create):
1255         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
1256
1257 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
1258
1259         Reviewed by Darin Adler.
1260
1261         Adding myself to the reviewers list.
1262         https://bugs.webkit.org/show_bug.cgi?id=40693
1263
1264         * Scripts/webkitpy/common/config/committers.py:
1265
1266 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
1267
1268         Reviewed by Xan Lopez.
1269
1270         Switch to using GIO methods instead of realpath in GtkLauncher to determine
1271         the file URI. This should remove warnings about realpath being undefined
1272         when compiling with '-ansi'.
1273
1274         * GtkLauncher/main.c:
1275         (filenameToURL): Use GIO instead of realpath to determine file URI.
1276
1277 2010-06-15  Adam Roben  <aroben@apple.com>
1278
1279         Remove the redundant set-apple-windows-environment-variables script
1280
1281         Apparently update-webkit does this for you these days.
1282
1283         Rubber-stamped by Steve Falkenburg.
1284
1285         * Scripts/set-apple-windows-environment-variables: Removed.
1286
1287 2010-06-14  Adam Roben  <aroben@apple.com>
1288
1289         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
1290         environment variables
1291
1292         Fixes <http://webkit.org/b/40595>.
1293
1294         Reviewed by Steve Falkenburg.
1295
1296         * Scripts/set-apple-windows-environment-variables: Added.
1297         (to_windows_path): Passes the passed-in path through cygpath to
1298         generate a Windows-style path.
1299         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
1300         variables to their defaults, if they aren't already set.
1301
1302 2010-06-14  Adam Roben  <aroben@apple.com>
1303
1304         Speed up run-safari/debug-safari on Windows
1305
1306         Fixes <http://webkit.org/b/40586>.
1307
1308         Reviewed by Steve Falkenburg.
1309
1310         * Scripts/webkitdirs.pm:
1311         (runSafari): When debugging, set up the environment to run Safari
1312         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
1313         actually launch the debugger. When not debugging, just run WebKit.exe
1314         and it will do the rest for us.
1315
1316 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
1317
1318         Reviewed by Kenneth Rohde Christiansen.
1319
1320         [Qt] DRT EventSender support to graphics context events
1321         https://bugs.webkit.org/show_bug.cgi?id=40324
1322
1323         * DumpRenderTree/qt/EventSenderQt.cpp:
1324         (EventSender::contextClick):
1325
1326 2010-06-14  Tony Chang  <tony@chromium.org>
1327
1328         Reviewed by Darin Fisher.
1329
1330         [chromium] checkout chromium third_party directly
1331         https://bugs.webkit.org/show_bug.cgi?id=40556
1332
1333         * Scripts/update-webkit-chromium: some migration code for the bots
1334
1335 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
1336
1337         Chromium build fix.
1338
1339         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
1340         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
1341
1342 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
1343
1344         Reviewed by Darin Adler.
1345
1346         https://bugs.webkit.org/show_bug.cgi?id=40529
1347         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
1348
1349         * DumpRenderTree/mac/EventSendingController.mm:
1350         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
1351         event for "delete" - it had virtual key code from forward delete, and text from backspace.
1352         Fixed "delete" to mean forward delete.
1353
1354         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
1355         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
1356         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1357         Mac DRT confusion has propagated to other platforms, fixing those.
1358
1359 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
1360
1361         Reviewed by Xan Lopez.
1362
1363         Small GtkLauncher build fix for some systems.
1364
1365         * GtkLauncher/main.c: Add <limit.h> include.
1366
1367 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1368
1369         Reviewed by Laszlo Gombos.
1370
1371         [Qt] navigator.geolocation support for Qt port
1372         https://bugs.webkit.org/show_bug.cgi?id=39724
1373
1374         Implementation for geolocation cases to DumpRenderTreeQt
1375
1376         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1377         (WebCore::WebPage::allowGeolocationRequest):
1378         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1379         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1380         (LayoutTestController::setGeolocationPermission):
1381         (LayoutTestController::setMockGeolocationError):
1382         (LayoutTestController::setMockGeolocationPosition):
1383         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1384         (LayoutTestController::isGeolocationPermissionSet):
1385         (LayoutTestController::geolocationPermission):
1386
1387 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
1388
1389         Reviewed by Darin Adler.
1390
1391         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
1392         be a way of overwriting the Xcode system path.  Making
1393         $WEBKITOUTPUTDIR take precedence over the system default would make
1394         this possible.
1395
1396         * Scripts/webkitdirs.pm:
1397
1398 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
1399
1400         Reviewed by Darin Adler.
1401
1402         AX: link won't return linked element if URL contains #
1403         https://bugs.webkit.org/show_bug.cgi?id=40192
1404
1405         * DumpRenderTree/AccessibilityUIElement.cpp:
1406         (linkedUIElementAtIndexCallback):
1407         (AccessibilityUIElement::getJSClass):
1408         * DumpRenderTree/AccessibilityUIElement.h:
1409         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1410         (AccessibilityUIElement::linkedUIElementAtIndex):
1411         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1412         (AccessibilityUIElement::linkedUIElementAtIndex):
1413         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1414         (AccessibilityUIElement::linkedUIElementAtIndex):
1415
1416 2010-06-13  Adam Barth  <abarth@webkit.org>
1417
1418         Reviewed by Darin Adler.
1419
1420         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
1421         https://bugs.webkit.org/show_bug.cgi?id=39550
1422
1423         This can cause an extra request to bugs.webkit.org durig upload, but it
1424         shouldn't be too bad.  Also, this won't work if you remove the
1425         boilerplate created by prepare-ChangeLog.
1426
1427         * Scripts/webkitpy/common/checkout/changelog.py:
1428         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1429         * Scripts/webkitpy/common/net/bugzilla.py:
1430         * Scripts/webkitpy/tool/steps/abstractstep.py:
1431         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1432         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
1433
1434 2010-06-08  Robert Hogan  <robert@webkit.org>
1435
1436         Reviewed by Eric Seidel.
1437
1438         [Qt] Add support for callShouldCloseOnWebView() to DRT
1439         https://bugs.webkit.org/show_bug.cgi?id=40330
1440
1441         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1442         (LayoutTestController::callShouldCloseOnWebView):
1443         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1444         (LayoutTestController::setCallCloseOnWebViews):
1445
1446 2010-06-12  Eric Seidel  <eric@webkit.org>
1447
1448         Reviewed by Daniel Bates.
1449
1450         do-webcore-rename should have a --verbose option
1451         https://bugs.webkit.org/show_bug.cgi?id=40497
1452
1453         * Scripts/do-webcore-rename:
1454          - Unified how we handle skipping files/directories
1455            this will allow us to "black list" certain files and
1456            directories when performing renames.
1457          - Made do-webcore-rename log what it's skipping when passed --verbose.
1458
1459 2010-06-12  Darin Adler  <darin@apple.com>
1460
1461         * Scripts/run-bindings-tests: Fixed a typo in a message.
1462
1463 2010-06-12  Kent Tamura  <tkent@chromium.org>
1464
1465         Reviewed by Dimitri Glazkov.
1466
1467         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
1468         https://bugs.webkit.org/show_bug.cgi?id=40402
1469
1470         _build_path() of each Chromium port check existence of build path
1471         of Chromium checkout first, then check existence of build path of
1472         WebKit-only checkout.
1473
1474         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1475         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1476         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1477
1478 2010-06-12  Robert Hogan  <robert@webkit.org>
1479
1480         Reviewed by Kenneth Rohde Christiansen.
1481
1482         [Qt] Back-forward list dumping is incorrect
1483
1484         https://bugs.webkit.org/show_bug.cgi?id=36392
1485
1486         Support dumping child history items in DRT.
1487
1488         Unskip:
1489
1490         fast/loader/frame-src-change-added-to-history.html
1491         fast/loader/frame-src-change-not-added-to-history.html
1492         fast/loader/frame-location-change-not-added-to-history.html
1493
1494         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1495         (WebCore::dumpHistoryItem):
1496
1497 2010-06-10  Ojan Vafai  <ojan@chromium.org>
1498
1499         Reviewed by Eric Seidel.
1500
1501         upload all patches that lack in-rietveld to rietveld
1502         https://bugs.webkit.org/show_bug.cgi?id=40444
1503
1504         If it's a patch, then we'll try to upload it as long as it
1505         doesn't have in-rietveld set. No longer set in-rietveld? since
1506         it's not needed.
1507
1508         * Scripts/webkitpy/common/net/bugzilla.py:
1509
1510 2010-06-10  Ojan Vafai  <ojan@chromium.org>
1511
1512         Reviewed by Darin Fisher.
1513
1514         Fix rietveld upload when message length > 100 characters
1515         https://bugs.webkit.org/show_bug.cgi?id=40457
1516
1517         * Scripts/webkitpy/common/net/rietveld.py:
1518
1519 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
1520
1521         Reviewed by Laszlo Gombos.
1522
1523         [Qt] There should be a way to enable popups in QtTestBrowser
1524         https://bugs.webkit.org/show_bug.cgi?id=40427
1525
1526         * QtTestBrowser/main.cpp:
1527         (LauncherWindow::toggleJavascriptCanOpenWindows):
1528         (LauncherWindow::createChrome):
1529
1530 2010-06-10  Adam Barth  <abarth@webkit.org>
1531
1532         Reviewed by Daniel Bates.
1533
1534         Make SheriffBot more chatty
1535         https://bugs.webkit.org/show_bug.cgi?id=40463
1536
1537         People seem to like to talk to SheriffBot, so let's make him chat back.
1538
1539         * Scripts/webkitpy/thirdparty/__init__.py:
1540         * Scripts/webkitpy/tool/bot/irc_command.py:
1541         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
1542         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1543         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1544
1545 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
1546
1547         Reviewed by Darin Adler.
1548
1549         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
1550         
1551         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
1552         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
1553         WEXITSTATUS on $result instead of just comparing $result to 0.
1554
1555         * Scripts/update-webkit-auxiliary-libs:
1556
1557 2010-06-10  Ojan Vafai  <ojan@chromium.org>
1558
1559         Reviewed by Alexey Proskuryakov.
1560
1561         don't use Exception.message as it's deprecated in python 2.6+
1562         https://bugs.webkit.org/show_bug.cgi?id=40449
1563
1564         * Scripts/webkitpy/tool/commands/queues.py:
1565
1566 2010-06-10  Ojan Vafai  <ojan@chromium.org>
1567
1568         Reviewed by Adam Barth.
1569
1570         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
1571         https://bugs.webkit.org/show_bug.cgi?id=40436
1572
1573         * Scripts/webkitpy/common/system/outputcapture.py:
1574         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1575         * Scripts/webkitpy/tool/commands/queues.py:
1576         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1577         * Scripts/webkitpy/tool/commands/queuestest.py:
1578         * Scripts/webkitpy/tool/mocktool.py:
1579
1580 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1581
1582         Reviewed by Simon Hausmann.
1583
1584         [Qt] *All* WebGL layout tests fail!
1585         https://bugs.webkit.org/show_bug.cgi?id=40296
1586
1587         Added test for WebKitWebGLEnabled to
1588         LayoutTestController::overridePreference().
1589
1590         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1591         (LayoutTestController::overridePreference):
1592
1593 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
1594
1595         Reviewed by Kenneth Rohde Christiansen.
1596
1597         [Qt] DRT EventSender support to graphics mouse events activation
1598         https://bugs.webkit.org/show_bug.cgi?id=40017
1599
1600         * DumpRenderTree/qt/EventSenderQt.cpp:
1601         (EventSender::mouseDown):
1602         (EventSender::mouseUp):
1603         (EventSender::mouseMoveTo):
1604         (EventSender::keyDown):
1605         (EventSender::contextClick):
1606         (EventSender::sendTouchEvent):
1607         (EventSender::sendOrQueueEvent):
1608         (EventSender::eventFilter):
1609         (EventSender::createGraphicsSceneMouseEvent):
1610         (EventSender::sendEvent):
1611         * DumpRenderTree/qt/EventSenderQt.h:
1612         (EventSender::isGraphicsBased):
1613
1614 2010-06-09  Adam Barth  <abarth@webkit.org>
1615
1616         Reviewed by Ojan Vafai.
1617
1618         webkit-patch upload fails for security bugs because there's no rietveld flag
1619         https://bugs.webkit.org/show_bug.cgi?id=40309
1620
1621         There's probably a more elegant way of seeing whether the form control
1622         exists, but this seems to work.
1623
1624         * Scripts/webkitpy/common/net/bugzilla.py:
1625
1626 2010-06-09  Ojan Vafai  <ojan@chromium.org>
1627
1628         Reviewed by Adam Barth.
1629
1630         make rietveld upload faster and avoid posting to bug on errors
1631         https://bugs.webkit.org/show_bug.cgi?id=40389
1632
1633         Only grab the first item of the upload queue instead of trying
1634         to compute the whole list upfront (which is O(n) bugzilla lookups!).
1635
1636         Also, don't post comments to the bug when uploading fails.
1637
1638         * Scripts/webkitpy/common/net/bugzilla.py:
1639         * Scripts/webkitpy/tool/commands/queues.py:
1640         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1641         * Scripts/webkitpy/tool/commands/stepsequence.py:
1642         * Scripts/webkitpy/tool/mocktool.py:
1643
1644 2010-06-09  Ojan Vafai  <ojan@chromium.org>
1645
1646         Reviewed by Adam Barth.
1647
1648         Rietveld upload queue fails when setting in-rietveld flag
1649         https://bugs.webkit.org/show_bug.cgi?id=40371
1650
1651         Make the comment arguments to set_flag_on_attachment optional
1652         and add it to the MockBugzilla.
1653
1654         * Scripts/webkitpy/common/net/bugzilla.py:
1655         * Scripts/webkitpy/tool/bot/queueengine.py:
1656         * Scripts/webkitpy/tool/commands/download_unittest.py:
1657         * Scripts/webkitpy/tool/commands/queues.py:
1658         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1659         * Scripts/webkitpy/tool/mocktool.py:
1660
1661 2010-06-09  Kenneth Russell  <kbr@google.com>
1662
1663         Reviewed by Dimitri Glazkov.
1664
1665         Rename FloatArray to Float32Array
1666         https://bugs.webkit.org/show_bug.cgi?id=40323
1667
1668         Used do-webcore-rename to perform renaming. Manually undid
1669         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
1670         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
1671         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
1672         all layout tests on Safari; built Chromium and ran selected WebGL
1673         tests.
1674
1675         * Scripts/do-webcore-rename:
1676
1677 2010-06-08  Tony Chang  <tony@chromium.org>
1678
1679         Reviewed by David Levin.
1680
1681         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
1682         https://bugs.webkit.org/show_bug.cgi?id=40285
1683
1684         * Scripts/webkitdirs.pm:
1685         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1686
1687 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
1688
1689         Reviewed by Tamura Kent.
1690
1691         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
1692         https://bugs.webkit.org/show_bug.cgi?id=40052
1693         
1694         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
1695
1696         * DumpRenderTree/DumpRenderTree.gypi:
1697         * DumpRenderTree/chromium/TestShellWin.cpp:
1698         (platformInit):
1699         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
1700         (WebKit::):
1701         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
1702         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
1703         (WebKit::WebThemeControlDRT::box):
1704         (WebKit::WebThemeControlDRT::line):
1705         (WebKit::WebThemeControlDRT::triangle):
1706         (WebKit::WebThemeControlDRT::roundRect):
1707         (WebKit::WebThemeControlDRT::oval):
1708         (WebKit::WebThemeControlDRT::circle):
1709         (WebKit::WebThemeControlDRT::nestedBoxes):
1710         (WebKit::WebThemeControlDRT::markState):
1711         (WebKit::WebThemeControlDRT::draw):
1712         (WebKit::WebThemeControlDRT::drawTextField):
1713         (WebKit::WebThemeControlDRT::drawProgressBar):
1714         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
1715         (WebKit::WebThemeControlDRT::):
1716         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
1717         (WebKit::):
1718         (WebKit::WebThemeEngineDRT::paintButton):
1719         (WebKit::WebThemeEngineDRT::paintMenuList):
1720         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
1721         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
1722         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
1723         (WebKit::WebThemeEngineDRT::paintTextField):
1724         (WebKit::WebThemeEngineDRT::paintTrackbar):
1725         (WebKit::WebThemeEngineDRT::paintProgressBar):
1726         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
1727         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
1728
1729 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1730
1731         Unreviewed, rolling out r60878.
1732         http://trac.webkit.org/changeset/60878
1733         https://bugs.webkit.org/show_bug.cgi?id=40349
1734
1735         broke linux build (Requested by tony^work on #webkit).
1736
1737         * Scripts/webkitdirs.pm:
1738         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1739
1740 2010-06-08  Tony Chang  <tony@chromium.org>
1741
1742         Reviewed by David Levin.
1743
1744         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
1745         https://bugs.webkit.org/show_bug.cgi?id=40285
1746
1747         * Scripts/webkitdirs.pm:
1748         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1749
1750 2010-06-08  Kenneth Russell  <kbr@google.com>
1751
1752         Unreviewed, build fix.
1753
1754         Fix build breakage from 38145
1755         https://bugs.webkit.org/show_bug.cgi?id=40346
1756
1757         The fix for bug 38145 broke the Chromium Win build because
1758         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
1759         change log2(x) to log(x) / log(2). Built and ran WebGL layout
1760         tests in Safari on Mac OS X. Changed download mirrors for
1761         python-irclib to working ones.
1762
1763         * Scripts/webkitpy/thirdparty/__init__.py:
1764
1765 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
1766
1767         Reviewed by Eric Seidel.
1768
1769         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
1770         https://bugs.webkit.org/show_bug.cgi?id=39058
1771
1772         * Scripts/old-run-webkit-tests:
1773          use sourceDir() to find ensure-valid-python in checkPythonVersion()
1774
1775 2010-06-08  Andras Becsi  <abecsi@webkit.org>
1776
1777         Unreviewed buildfix after r60479.
1778
1779         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
1780         versions other than 2.17.3.
1781
1782         * DumpRenderTree/gtk/EventSender.cpp:
1783         (getRootCoords):
1784
1785 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
1786
1787         Reviewed by Oliver Hunt.
1788
1789         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
1790         https://bugs.webkit.org/show_bug.cgi?id=40267
1791
1792         When a mouse button is down, automatically queue mouse motion events and
1793         do not play them back until the mouse button is released. This matches the
1794         behavior of other ports' EventSenders.
1795
1796         * DumpRenderTree/gtk/EventSender.cpp:
1797         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
1798         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
1799
1800 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
1801
1802         Reviewed by Sam Weinig.
1803
1804         Add CPP bindings generator
1805         https://bugs.webkit.org/show_bug.cgi?id=38279
1806
1807         Integrate CPP bindings in run-bindings-tests.
1808
1809         * Scripts/run-bindings-tests:
1810
1811 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
1812
1813         Reviewed by Ojan Vafai.
1814
1815         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
1816         https://bugs.webkit.org/show_bug.cgi?id=40183
1817
1818         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1819
1820 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
1821
1822         Unreviewed.
1823
1824         Add my new email and IRC nick to committers.py.
1825
1826         * Scripts/webkitpy/common/config/committers.py:
1827
1828 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
1829
1830         Unreviewed.
1831
1832         Revert changes in json_results_generator.py's _get_svn_revision.
1833
1834         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1835
1836 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
1837
1838         Reviewed by Xan Lopez.
1839
1840         [GTK] GtkLauncher should support relative file paths
1841         https://bugs.webkit.org/show_bug.cgi?id=39944
1842
1843         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
1844
1845         * GtkLauncher/main.c:
1846         (filename_to_url): Added.
1847         (main): Try to resolve arguments as relative file URLs first.
1848
1849 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
1850
1851         Reviewed by Xan Lopez.
1852
1853         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
1854         https://bugs.webkit.org/show_bug.cgi?id=40182
1855
1856         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
1857         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
1858         without breaking DRT.
1859
1860         * DumpRenderTree/gtk/EventSender.cpp:
1861         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
1862         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
1863
1864 2010-06-04  Anders Carlsson  <andersca@apple.com>
1865
1866         Reviewed by David Hyatt.
1867
1868         Make the editing/spelling/context-menu-suggestions.html test more robust
1869         https://bugs.webkit.org/show_bug.cgi?id=40178
1870
1871         Change the contextClick method to return an array of strings describing the context menu items.
1872
1873         * DumpRenderTree/mac/EventSendingController.mm:
1874         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1875         (+[EventSendingController webScriptNameForSelector:]):
1876         (-[EventSendingController contextClick]):
1877
1878 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
1879
1880         Reviewed by Shinichiro Hamaji.
1881
1882         Clean up chromium-specific code from json_results_generator.py.
1883         https://bugs.webkit.org/show_bug.cgi?id=39665
1884
1885         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1886         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1887         * Scripts/webkitpy/layout_tests/port/base.py:
1888         * Scripts/webkitpy/layout_tests/port/chromium.py:
1889
1890 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
1891
1892         Reviewed by Adam Barth.
1893
1894         Utilize new takeFirst() method where appropriate.
1895         https://bugs.webkit.org/show_bug.cgi?id=40089
1896
1897         * DumpRenderTree/chromium/EventSender.cpp:
1898         (EventSender::replaySavedEvents):
1899         * DumpRenderTree/chromium/LayoutTestController.cpp:
1900         (LayoutTestController::WorkQueue::processWork):
1901         (LayoutTestController::WorkQueue::reset):
1902
1903 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
1904
1905         Reviewed by Simon Hausmann.
1906
1907         [Qt] QtTestLauncher should allow notifications by default.
1908         https://bugs.webkit.org/show_bug.cgi?id=40078
1909
1910         * QtTestBrowser/main.cpp:
1911         (NotificationsPermissionController::NotificationsPermissionController):
1912         (NotificationsPermissionController::checkPermission):
1913         (NotificationsPermissionController::requestPermission):
1914         (LauncherWindow::LauncherWindow):
1915
1916 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
1917
1918         Reviewed by Adam Barth.
1919
1920         Detect whether the user's environment can open a browser.
1921         https://bugs.webkit.org/show_bug.cgi?id=40136
1922
1923         Some environments like cygwin silently fail webbrowser.open() causing
1924         webkit-patch upload not to display any diff. This detects environments
1925         where webbrowser.open() would fail by testing if webbrowser.get()
1926         raises an exception.
1927
1928         * Scripts/webkitpy/common/system/user.py:
1929         * Scripts/webkitpy/tool/mocktool.py:
1930         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1931
1932 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
1933
1934         Reviewed by David Levin.
1935
1936         Add dependencies required to link with VS Express 2005.
1937         https://bugs.webkit.org/show_bug.cgi?id=40038
1938
1939         Visual Studio implicitly links against these libs.
1940         VC++ Express does not.
1941
1942         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1943         * WinLauncher/WinLauncher.vcproj:
1944
1945 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
1946
1947         Reviewed by David Levin.
1948
1949         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
1950         https://bugs.webkit.org/show_bug.cgi?id=40105
1951
1952         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1953         - kill pywebsocket process when url is not alive and the process is not
1954           terminated, not to leave pywebsocket server running.
1955         - fix codecs.open parameters.
1956
1957 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
1958
1959         Reviewed by Alexey Proskuryakov.
1960
1961         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
1962         https://bugs.webkit.org/show_bug.cgi?id=39058
1963
1964         * Scripts/ensure-valid-python:
1965           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
1966           - Add --check-only and --help option.
1967           - --check-only option only checks python version and don't try to install Python 2.5.
1968           - Set executable bit.
1969         * Scripts/old-run-webkit-tests:
1970           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
1971
1972 2010-05-14  Ojan Vafai  <ojan@chromium.org>
1973
1974         Reviewed by Adam Barth.
1975
1976         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
1977         https://bugs.webkit.org/show_bug.cgi?id=38918
1978
1979         Patches with in-rietveld? get uploaded to rietveld and get marked
1980         in-rietveld+. If the upload fails, they are marked in-rietveld-
1981         and an error is logged to the bug, like the commit-queue.
1982
1983         Also, get rid of --fancy-review and the ability to upload to rietveld
1984         using webkit-patch upload/post.
1985
1986         * Scripts/webkitpy/common/net/bugzilla.py:
1987         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1988         * Scripts/webkitpy/tool/commands/download.py:
1989         * Scripts/webkitpy/tool/commands/download_unittest.py:
1990         * Scripts/webkitpy/tool/commands/queues.py:
1991         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1992         * Scripts/webkitpy/tool/commands/upload.py:
1993         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1994         * Scripts/webkitpy/tool/mocktool.py:
1995         * Scripts/webkitpy/tool/steps/options.py:
1996         * Scripts/webkitpy/tool/steps/postcodereview.py:
1997
1998 2010-05-24  Ojan Vafai  <ojan@chromium.org>
1999
2000         Reviewed by Chris Jerdonek.
2001
2002         many webkit-patch commands fail in a non-svn tracking git checkout
2003         https://bugs.webkit.org/show_bug.cgi?id=38156
2004
2005         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
2006         If neither exists, then error out. This makes webkit-patch work
2007         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
2008         to checkout webkit. The fallback to master is for people who don't
2009         do the steps on that page for tracking svn.
2010
2011         * Scripts/webkitpy/common/checkout/scm.py:
2012         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2013
2014 2010-06-03  Mike Fenton  <mifenton@rim.com>
2015
2016         Unreviewed.
2017
2018         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
2019
2020         * Scripts/webkitpy/common/config/committers.py:
2021
2022 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
2023
2024         Reviewed by Yury Semikhatsky.
2025
2026         Web Inspector: a number of fixes that make InspectorController
2027         happy with null redirects.
2028
2029         https://bugs.webkit.org/show_bug.cgi?id=40109
2030
2031         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2032         (runTest):
2033         * DumpRenderTree/mac/DumpRenderTree.mm:
2034         (runTest):
2035         * DumpRenderTree/win/DumpRenderTree.cpp:
2036         (runTest):
2037
2038 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
2039
2040         Reviewed by Shinichiro Hamaji.
2041
2042         [Qt] Fix compilation with QT_NO_PROPERTIES
2043         https://bugs.webkit.org/show_bug.cgi?id=38324
2044
2045         * QtTestBrowser/main.cpp:
2046         (LauncherWindow::init):
2047
2048 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
2049
2050         Reviewed by Kenneth Rohde Christiansen.
2051
2052         [Qt] Make possible run DRT with QGraphicsWebView
2053         https://bugs.webkit.org/show_bug.cgi?id=40016
2054
2055         Make possible to use a environment variable for switching backend.
2056         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
2057
2058         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2059         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
2060         (WebCore::DumpRenderTree::DumpRenderTree):
2061         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2062         (WebCore::DumpRenderTree::setGraphicsBased):
2063         (WebCore::DumpRenderTree::isGraphicsBased):
2064         (WebCore::WebViewGraphicsBased::graphicsView):
2065         (WebCore::WebViewGraphicsBased::setPage):
2066         * Scripts/old-run-webkit-tests:
2067
2068 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
2069
2070         Reviewed by Eric Seidel.
2071
2072         Slave lost shouldn't be recognized as build failed.
2073         https://bugs.webkit.org/show_bug.cgi?id=39282
2074
2075         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
2076         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
2077
2078 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
2079
2080         Reviewed by Kenneth Rohde Christiansen.
2081
2082         [Qt] Fix the lifecycle of notification objects
2083         https://bugs.webkit.org/show_bug.cgi?id=40003
2084
2085         Remove the dependency of notifications on QWebPage.
2086
2087         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2088         (WebCore::requestPermissionCallback):
2089         (WebCore::WebPage::WebPage):
2090         (WebCore::DumpRenderTree::requestPermission):
2091         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2092
2093 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2094
2095         Unreviewed, rolling out r60559.
2096         http://trac.webkit.org/changeset/60559
2097         https://bugs.webkit.org/show_bug.cgi?id=40055
2098
2099         It broke python unit test (Requested by Ossy on #webkit).
2100
2101         * Scripts/webkitpy/common/net/buildbot.py:
2102
2103 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
2104
2105         Reviewed by Eric Seidel.
2106
2107         Slave lost shouldn't be recognized as build failed.
2108         https://bugs.webkit.org/show_bug.cgi?id=39282
2109
2110         * Scripts/webkitpy/common/net/buildbot.py:
2111
2112 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
2113
2114         Reviewed by Eric Seidel.
2115
2116         Fix crash caused when assigned_to is disabled
2117         https://bugs.webkit.org/show_bug.cgi?id=40039
2118
2119         * Scripts/webkitpy/common/net/bugzilla.py:
2120
2121 2010-06-02  Sterling Swigart  <sswigart@google.com>
2122
2123         Reviewed by David Levin.
2124
2125         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
2126         https://bugs.webkit.org/show_bug.cgi?id=39906
2127
2128         * Scripts/build-webkit:
2129
2130 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
2131
2132         Reviewed by Simon Hausmann.
2133
2134         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
2135
2136         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2137         (WebCore::WebPage::WebPage):
2138         (WebCore::WebPage::resetSettings):
2139         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2140         (LayoutTestController::setJavaScriptCanAccessClipboard):
2141
2142 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2143
2144         Reviewed by Mark Rowe.
2145
2146         A nicer Tiger build fix.
2147
2148         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2149         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2150         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
2151
2152 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2153
2154         A real Tiger build fix.
2155
2156         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
2157         for all configurations, not just debug.
2158
2159 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2160
2161         Tiger build fix.
2162
2163         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
2164
2165 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2166
2167         Reviewed by Xan Lopez.
2168
2169         [GTK] Get more mouse tests passing
2170         https://bugs.webkit.org/show_bug.cgi?id=39040
2171
2172         Reproduce the logic from the Windows EventSender for mapping
2173         button numbers to GDK button numbers. Move this logic to the
2174         prepareMouseButtonEvent helper.
2175
2176         * DumpRenderTree/gtk/EventSender.cpp:
2177         (prepareMouseButtonEvent): Reproduce Windows logic.
2178         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
2179         (mouseDownCallback): Ditto.
2180         (mouseUpCallback): Ditto.
2181
2182 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2183
2184         Reviewed by Sam Weinig.
2185
2186         https://bugs.webkit.org/show_bug.cgi?id=39434
2187         REGRESSION (r59811): Geolocation callbacks cannot be created
2188
2189         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
2190
2191         * DumpRenderTree/mac/DumpRenderTree.mm:
2192         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
2193         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
2194         into subsequent tests.
2195
2196         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2197         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
2198         (LayoutTestController::setMockGeolocationError): Ditto.
2199
2200         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
2201         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
2202         (+[MockGeolocationProvider shared]):
2203         (-[MockGeolocationProvider dealloc]):
2204         (-[MockGeolocationProvider setPosition:]):
2205         (-[MockGeolocationProvider setError:]):
2206         (-[MockGeolocationProvider registerWebView:]):
2207         (-[MockGeolocationProvider unregisterWebView:]):
2208         (-[MockGeolocationProvider lastPosition]):
2209         (-[MockGeolocationProvider stopTimer]):
2210         (-[MockGeolocationProvider timerFired]):
2211
2212         * DumpRenderTree/mac/UIDelegate.mm:
2213         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2214         This delegate method must send a response. I'm not sure what the two-stage check is supposed
2215         to achieve, it seems unnecessary.
2216
2217 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
2218
2219         Reviewed by Xan Lopez.
2220
2221         [GTK] Double clicks cause three button press events
2222         https://bugs.webkit.org/show_bug.cgi?id=38853
2223
2224         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
2225         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
2226         the GDK event queue entirely, we simply do not send the extra event.
2227
2228         * DumpRenderTree/gtk/EventSender.cpp:
2229         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
2230         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
2231
2232 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2233
2234         Not reviewed. Build fix.
2235
2236         Fix GTK+ build caused by a bad merge.
2237
2238         * DumpRenderTree/gtk/EventSender.cpp: 
2239         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
2240
2241 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
2242
2243         Reviewed by Xan Lopez.
2244
2245         [GTK] Double clicks cause three button press events
2246         https://bugs.webkit.org/show_bug.cgi?id=38853
2247
2248         Small EventSender cleanups. Consolidate some common code. Style fixes.
2249
2250         * DumpRenderTree/gtk/EventSender.cpp:
2251         (prepareMouseButtonEvent): Added.
2252         (contextClickCallback): Use prepareMouseButtonEvent.
2253         (mouseDownCallback): Use prepareMouseButtonEvent.
2254         (mouseUpCallback): Use prepareMouseButtonEvent.
2255         (mouseMoveToCallback): Small style fix.
2256
2257 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2258
2259         Reviewed by Xan Lopez.
2260
2261         [GTK] Double clicks cause three button press events
2262         https://bugs.webkit.org/show_bug.cgi?id=38853
2263
2264         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
2265         to pause for a specified amount of time. It is used in the processing of drag-
2266         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
2267         This patch enables tests that rely on the latter behavior to pass.
2268
2269         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2270         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
2271         * DumpRenderTree/gtk/EventSender.cpp:
2272         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
2273         (contextClickCallback): Use sendOrQueueEvent.
2274         (updateClickCount): Take the time offset into account when counting clicks.
2275         (mouseDownCallback): Use sendOrQueueEvent.
2276         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
2277         (mouseUpCallback): Use sendOrQueueEvent.
2278         (mouseMoveToCallback): Ditto.
2279         (mouseWheelToCallback): Ditto.
2280         (sendOrQueueEvent): Added.
2281         (dispatchEvent): Added.
2282         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
2283         (makeEventSender): Only initialize the EventSender when loading the top frame.
2284         * DumpRenderTree/gtk/EventSender.h: Ditto.
2285
2286 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
2287
2288         Reviewed by Xan Lopez.
2289
2290         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
2291         https://bugs.webkit.org/show_bug.cgi?id=39101
2292
2293         Work around timing issues for render tree dumps by pumping the
2294         main loop before doing the dump. Resize events are asynchronous
2295         in GTK+, so sometimes resize requests are still pending when DRT
2296         dumps the tree.
2297
2298         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2299         (dump): Pump the main loop before dumping the render tree.
2300
2301 2010-05-31  Kent Tamura  <tkent@chromium.org>
2302
2303         Reviewed by Dimitri Glazkov.
2304
2305         [DRT/Chromium] Fix crash of a test after another test with multiple windows
2306         https://bugs.webkit.org/show_bug.cgi?id=39942
2307
2308         If a test opens multiple windows, focuses on non-main window, and
2309         the focused window is closed, TestShell::m_focusedWidget points a
2310         deleted object.
2311
2312         * DumpRenderTree/chromium/TestShell.cpp:
2313         (TestShell::closeWindow): Clear m_focusedWidget.
2314
2315 2010-05-30  Kent Tamura  <tkent@chromium.org>
2316
2317         Reviewed by Dimitri Glazkov.
2318
2319         new-run-webkit-tests: Support DRT on Chromium-win
2320         https://bugs.webkit.org/show_bug.cgi?id=39810
2321
2322         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
2323         it behaves like test_shell about command analysis, printing
2324         format, pixel dumping, and timeout handling.
2325
2326         chromium.py and chromium_win.py supports the --test-shell flag and
2327         DRT/Chromium-win binary names.
2328         
2329         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
2330         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2331         (runTest): Support for test_shell-style command.
2332         (main): Introduce --test-shell.
2333         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
2334         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
2335           TestEventPrinter class manages stdio output and image output.
2336           TestEventPrinter.cpp has two implementations; DRTPrinter and
2337           TestShellPrinter.
2338         * DumpRenderTree/chromium/TestShell.cpp:
2339           Some changes for TestEventPrinter.
2340         (TestShell::TestShell):
2341         (TestShell::runFileTest):
2342         (TestShell::testTimedOut):
2343         (TestShell::dump):
2344         (TestShell::dumpImage):
2345         * DumpRenderTree/chromium/TestShell.h:
2346         (TestShell::printer):
2347         (TestShell::layoutTestTimeout):
2348         (TestShell::layoutTestTimeoutForWatchDog):
2349         (TestShell::setLayoutTestTimeout):
2350         * DumpRenderTree/chromium/TestShellWin.cpp:
2351         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
2352         * Scripts/webkitpy/layout_tests/port/chromium.py:
2353         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2354
2355 2010-05-30  Robert Hogan  <robert@webkit.org>
2356
2357         Reviewed by Kenneth Rohde Christiansen.
2358
2359         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
2360
2361         https://bugs.webkit.org/show_bug.cgi?id=36004
2362
2363         * DumpRenderTree/qt/EventSenderQt.cpp:
2364         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
2365                                     Scrollbar::pixelsPerLineStep() for DRT testing.
2366         (EventSender::mouseScrollBy): Added
2367         (EventSender::continuousMouseScrollBy): Added
2368         * DumpRenderTree/qt/EventSenderQt.h:
2369
2370 2010-05-28  Adam Barth  <abarth@webkit.org>
2371
2372         Reviewed by David Levin.
2373
2374         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
2375         https://bugs.webkit.org/show_bug.cgi?id=39546
2376
2377         One sublty is that we want to wait for the user to finish editing the
2378         ChangeLog before moving on to the next step.  That means we want to pass
2379         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
2380         we don't want them to have to exit the Xcode application.  For this reason,
2381         we create a new instance of the application with -n.
2382         
2383         Overall, xed seems like a better solution, so we recommend that too.
2384
2385         * Scripts/webkitpy/common/system/user.py:
2386         * Scripts/webkitpy/tool/mocktool.py:
2387         * Scripts/webkitpy/tool/steps/editchangelog.py:
2388
2389 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
2390
2391         Reviewed by Ojan Vafai.
2392
2393         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
2394         threads are wedged. Also, the script will print the results of the
2395         tests completed when the interrupt occurs.
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=33238
2398
2399         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2400         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2401         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2402         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2403
2404 2010-05-28  Darin Adler  <darin@apple.com>
2405
2406         Ignore more Python messiness.
2407
2408         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
2409         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
2410         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
2411         * Scripts/webkitpy/test: Added property svn:ignore.
2412         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
2413
2414 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
2415
2416         Reviewed by Beth Dakin.
2417
2418         Adding myself as a reviewer.
2419
2420         * Scripts/webkitpy/common/config/committers.py:
2421
2422 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
2423
2424         Build fix. No review.
2425
2426         AX: need to catch NSAccessibilityExceptions in DRT
2427         https://bugs.webkit.org/show_bug.cgi?id=39881
2428
2429         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
2430
2431         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2432         (AccessibilityUIElement::rowIndexRange):
2433         (AccessibilityUIElement::columnIndexRange):
2434         (AccessibilityUIElement::selectedTextRange):
2435
2436 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
2437
2438         Reviewed by Darin Adler.
2439
2440         AX: need to catch NSAccessibilityExceptions in DRT
2441         https://bugs.webkit.org/show_bug.cgi?id=39881
2442
2443         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
2444         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
2445   
2446         So DRT should wrap exception handlers around its AX related calls.
2447
2448         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2449         (attributesOfElement):
2450         (AccessibilityUIElement::getLinkedUIElements):
2451         (AccessibilityUIElement::getDocumentLinks):
2452         (AccessibilityUIElement::getChildren):
2453         (AccessibilityUIElement::getChildrenWithRange):
2454         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2455         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2456         (AccessibilityUIElement::disclosedRowAtIndex):
2457         (AccessibilityUIElement::selectedRowAtIndex):
2458         (AccessibilityUIElement::titleUIElement):
2459         (AccessibilityUIElement::parentElement):
2460         (AccessibilityUIElement::disclosedByRow):
2461         (AccessibilityUIElement::stringAttributeValue):
2462         (AccessibilityUIElement::boolAttributeValue):
2463         (AccessibilityUIElement::isAttributeSettable):
2464         (AccessibilityUIElement::isAttributeSupported):
2465         (AccessibilityUIElement::role):
2466         (AccessibilityUIElement::subrole):
2467         (AccessibilityUIElement::roleDescription):
2468         (AccessibilityUIElement::title):
2469         (AccessibilityUIElement::description):
2470         (AccessibilityUIElement::orientation):
2471         (AccessibilityUIElement::stringValue):
2472         (AccessibilityUIElement::language):
2473         (AccessibilityUIElement::helpText):
2474         (AccessibilityUIElement::x):
2475         (AccessibilityUIElement::y):
2476         (AccessibilityUIElement::width):
2477         (AccessibilityUIElement::height):
2478         (AccessibilityUIElement::clickPointX):
2479         (AccessibilityUIElement::clickPointY):
2480         (AccessibilityUIElement::intValue):
2481         (AccessibilityUIElement::minValue):
2482         (AccessibilityUIElement::maxValue):
2483         (AccessibilityUIElement::valueDescription):
2484         (AccessibilityUIElement::insertionPointLineNumber):
2485         (AccessibilityUIElement::isActionSupported):
2486         (AccessibilityUIElement::isEnabled):
2487         (AccessibilityUIElement::isRequired):
2488         (AccessibilityUIElement::isSelected):
2489         (AccessibilityUIElement::isExpanded):
2490         (AccessibilityUIElement::hierarchicalLevel):
2491         (AccessibilityUIElement::ariaIsGrabbed):
2492         (AccessibilityUIElement::ariaDropEffects):
2493         (AccessibilityUIElement::lineForIndex):
2494         (AccessibilityUIElement::boundsForRange):
2495         (AccessibilityUIElement::stringForRange):
2496         (AccessibilityUIElement::attributesOfColumnHeaders):
2497         (AccessibilityUIElement::attributesOfRowHeaders):
2498         (AccessibilityUIElement::attributesOfColumns):
2499         (AccessibilityUIElement::attributesOfRows):
2500         (AccessibilityUIElement::attributesOfVisibleCells):
2501         (AccessibilityUIElement::attributesOfHeader):
2502         (AccessibilityUIElement::rowCount):
2503         (AccessibilityUIElement::columnCount):
2504         (AccessibilityUIElement::indexInTable):
2505         (AccessibilityUIElement::rowIndexRange):
2506         (AccessibilityUIElement::columnIndexRange):
2507         (AccessibilityUIElement::cellForColumnAndRow):
2508         (AccessibilityUIElement::selectedTextRange):
2509         (AccessibilityUIElement::setSelectedTextRange):
2510         (AccessibilityUIElement::increment):
2511         (AccessibilityUIElement::decrement):
2512         (AccessibilityUIElement::showMenu):
2513         (AccessibilityUIElement::press):
2514         (AccessibilityUIElement::url):
2515         (AccessibilityUIElement::hasPopup):
2516
2517 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
2518
2519         Reviewed by Laszlo Gombos.
2520
2521         [Qt] Pass all web notification layout tests
2522         https://bugs.webkit.org/show_bug.cgi?id=39146
2523
2524         Mimic Chromium's test_shell security model in Qt's DRT.
2525         It makes a list of origins which were granted permission to display
2526         notifications, and only those origins can display notifications.
2527
2528         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2529         (WebCore::checkPermissionCallback):
2530         (WebCore::requestPermissionCallback):
2531         (WebCore::WebPage::WebPage):
2532         (WebCore::DumpRenderTree::checkPermission):
2533         (WebCore::DumpRenderTree::requestPermission):
2534         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2535         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2536         (LayoutTestController::reset):
2537         (LayoutTestController::grantDesktopNotificationPermission):
2538         (LayoutTestController::checkDesktopNotificationPermission):
2539         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2540
2541 2010-05-27  Philippe Normand  <pnormand@igalia.com>
2542
2543         Reviewed by Shinichiro Hamaji.
2544
2545         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
2546         https://bugs.webkit.org/show_bug.cgi?id=39372
2547
2548         Don't warn about NULL in g_*() calls. Zero can't be used instead
2549         for calls like g_build_filename and g_object_get/set.
2550
2551         * Scripts/webkitpy/style/checkers/cpp.py:
2552         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2553
2554 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
2555
2556         Reviewed by Kenneth Rohde Christiansen.
2557
2558         [Qt] Platform plugin example
2559         https://bugs.webkit.org/show_bug.cgi?id=39489
2560
2561         Exempting directory WebKit/qt/examples/ from style guide.
2562
2563         * Scripts/webkitpy/style/checker.py:
2564
2565 2010-05-26  Philippe Normand  <pnormand@igalia.com>
2566
2567         Reviewed by David Levin.
2568
2569         [style] Allow usage of NULL in gst_*_many()
2570         https://bugs.webkit.org/show_bug.cgi?id=39740
2571
2572         Don't warn if NULL is used by gst_*_many() functions. Zero can't
2573         be used for the reason explained in Bug 32858.
2574
2575         * Scripts/webkitpy/style/checkers/cpp.py:
2576         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2577
2578 2010-05-27  Adam Barth  <abarth@webkit.org>
2579
2580         Reviewed by Eric Seidel.
2581
2582         Update script to run the normal version of the parser tests.
2583
2584         * Scripts/test-html5-parser:
2585
2586 2010-05-27  Adam Barth  <abarth@webkit.org>
2587
2588         Reviewed by Eric Seidel.
2589
2590         Add HTML5 parser support to run-webkit-tests
2591         https://bugs.webkit.org/show_bug.cgi?id=39815
2592
2593         * Scripts/old-run-webkit-tests:
2594
2595 2010-05-26  Adam Barth  <abarth@webkit.org>
2596
2597         Reviewed by Eric Seidel.
2598
2599         Make HTML5 lexer not ASSERT when resuming partial parses
2600         https://bugs.webkit.org/show_bug.cgi?id=39755
2601
2602         Add webkit-resumer.html to the HTML5 parser test suite.
2603
2604         * Scripts/test-html5-parser:
2605
2606 2010-05-24  Tony Chang  <tony@chromium.org>
2607
2608         Reviewed by Kent Tamura.
2609
2610         [chromium] setup fonts on chromium linux DRT
2611         https://bugs.webkit.org/show_bug.cgi?id=39644
2612
2613         * DumpRenderTree/chromium/TestShellGtk.cpp:
2614         (setupFontconfig):
2615         (platformInit):
2616         * DumpRenderTree/chromium/WebViewHost.cpp:
2617         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
2618         * DumpRenderTree/chromium/fonts.conf: Added.
2619
2620 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
2621
2622         Reviewed by Dimitri Glazkov.
2623
2624         Re-commit r58765 - it had been rolled out to see if it was causing
2625         a perf regression (in r59787 and r59789), but that does not seem to
2626         have been the case.
2627
2628         https://bugs.webkit.org/show_bug.cgi?id=39605
2629
2630         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2631         (NotificationPresenter::show):
2632
2633 2010-05-25  Ojan Vafai  <ojan@chromium.org>
2634
2635         Reviewed by Chris Jerdonek.
2636
2637         remove suppression of rietveld logging
2638         https://bugs.webkit.org/show_bug.cgi?id=39693
2639
2640         Now that we only upload to rietveld explicitly, e.g. on the bot
2641         or via webkit-patch post-attachment-to-rietveld, we should print
2642         all the rietveld logging. It was suppressed before to avoid making
2643         webkit-patch upload too noisy.
2644
2645         * Scripts/webkitpy/common/net/rietveld.py:
2646
2647 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
2648
2649         Reviewed by Ojan Vafai.
2650
2651         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
2652         https://bugs.webkit.org/show_bug.cgi?id=39680
2653
2654         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
2655
2656         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2657         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2658         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2659         (LayoutTestController::setEditingBehavior):
2660
2661 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
2662
2663         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
2664
2665         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2666         (LayoutTestController::setEditingBehavior):
2667         * wx/build/settings.py:
2668
2669 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
2670
2671         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
2672
2673         editingBehavior settings needs to be set back to a reasonable default between tests
2674         https://bugs.webkit.org/show_bug.cgi?id=39433
2675
2676         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
2677         so that the serialized version of the setting stays in sync with expectations.
2678
2679         * DumpRenderTree/chromium/TestShell.cpp:
2680         (TestShell::resetWebSettings):
2681         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2682         (resetDefaultsToConsistentValues):
2683
2684 2010-05-24  Eric Seidel  <eric@webkit.org>
2685
2686         Reviewed by Adam Barth.
2687
2688         webkit-patch land calls scm.changed_files 4 times!
2689         https://bugs.webkit.org/show_bug.cgi?id=39584
2690
2691         * Scripts/webkitpy/tool/commands/download_unittest.py:
2692          - Assert that we don't call modified_changelogs too often.
2693         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2694          - Use cached changelogs list instead of calling modified_changelogs directly.
2695         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2696          - ditto.
2697
2698 2010-05-24  Kent Tamura  <tkent@chromium.org>
2699
2700         Reviewed by Dimitri Glazkov.
2701
2702         [DRT/Chromium] Import layout_test_helper for Windows
2703         https://bugs.webkit.org/show_bug.cgi?id=39581
2704
2705         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
2706         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
2707
2708         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
2709
2710 2010-05-24  Kent Tamura  <tkent@chromium.org>
2711
2712         Reviewed by Dimitri Glazkov.
2713
2714         [DRT/Chromium] Reset frame name
2715         https://bugs.webkit.org/show_bug.cgi?id=39586
2716
2717         This change fixes about 70 unexpected results.
2718
2719         * DumpRenderTree/chromium/WebViewHost.cpp:
2720         (WebViewHost::reset):
2721
2722 2010-05-24  Marcus Bulach  <bulach@chromium.org>
2723
2724         Reviewed by Kent Tamura.
2725
2726         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
2727         https://bugs.webkit.org/show_bug.cgi?id=39587
2728
2729         * DumpRenderTree/chromium/WebViewHost.cpp:
2730         (WebViewHost::geolocationService):
2731
2732 2010-05-24  Robert Hogan  <robert@webkit.org>
2733
2734         Reviewed by Laszlo Gombos.
2735
2736         [Qt] DRT Support for removeOriginAccessWhitelistEntry
2737
2738         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
2739
2740         [Qt] DRT Support for removeOriginAccessWhitelistEntry
2741         https://bugs.webkit.org/show_bug.cgi?id=39565
2742
2743         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2744         (LayoutTestController::removeOriginAccessWhitelistEntry):
2745
2746 2010-05-24  Marcus Bulach  <bulach@google.com>
2747
2748         Reviewed by Ojan Vafai.
2749
2750         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
2751         https://bugs.webkit.org/show_bug.cgi?id=39603
2752
2753         * Scripts/webkitpy/common/checkout/scm.py:
2754
2755 == Rolled over to ChangeLog-2010-05-24 ==