Unreviewed.
[WebKit.git] / WebKitTools / ChangeLog
1 2010-04-19  Jesus Sanchez-Palencia  <jesus@webkit.org>
2
3         Unreviewed.
4
5         Just adding myself as a committer.
6
7         * Scripts/webkitpy/common/config/committers.py:
8
9 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
10
11         Reviewed by Eric Seidel.
12
13         Add slightly better logging to the websocket python wrapper script,
14         including a --verbose flag for debug output.
15
16         https://bugs.webkit.org/show_bug.cgi?id=37233
17
18         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
19         * Scripts/new-run-webkit-websocketserver:
20
21 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
22
23         Reviewed by Eric Seidel.
24
25         new-run-webkit-tests: add a way (--print-unexpected-results) to
26         (re-)print out the tests that produced unexpected results in the
27         last run. Also add a way (--retry-unexpected-results) to
28         automatically re-test them.
29
30         https://bugs.webkit.org/show_bug.cgi?id=37783
31
32         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
33
34 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
35
36         Reviewed by Eric Seidel.
37
38         Restructure the logging in new-run-webkit-tests so that many of log
39         messages that were logged to the MeteredStream also get logged in
40         --verbose mode.
41
42         https://bugs.webkit.org/show_bug.cgi?id=37780
43
44         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
45         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
46
47 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
48
49         Reviewed by Eric Seidel.
50
51         new-run-webkit-tests: add 'summary' and 'unexpected-results' options
52         to the --log flag. Also add a 'progress' flag to enable the regular
53         progress bar (as opposed to 'detailed-progress', which enables the
54         dots). Also add a 'nothing' flag to allow you to be explicit that
55         you don't want any logging on the command line.
56
57         The default is
58         '--log detailed-progress,summary,unexpected,unexpected-results'
59
60         (The default logging is unchanged by this patch, this just makes things
61         properly configurable).
62
63         Note that 'nothing' doesn't work properly yet; I need a couple other
64         patches to land to avoid rewriting things several different ways.
65
66         https://bugs.webkit.org/show_bug.cgi?id=37785
67
68         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
69
70 2010-04-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
71
72         Reviewed by Simon Hausmann.
73
74         Make the URL change on committed load.
75
76         * QtLauncher/mainwindow.cpp:
77         (MainWindow::buildUI):
78         (MainWindow::setAddressUrl):
79         * QtLauncher/mainwindow.h:
80
81 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
82
83         Reviewed by Eric Seidel.
84
85         Fix a typo in the rebaselining tool that causes us to use "debug"
86         instead of "Debug" in a directory path, which fails on platforms with
87         case-sensitive filesystems.
88
89         https://bugs.webkit.org/show_bug.cgi?id=37819
90
91         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
92
93 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
94
95         Unreviewed, build fix.
96
97         Fix breakage of chromium-win canary bots caused by r57806. That patch
98         introduced the option of using Chrome's new port of DumpRenderTree,
99         but unfortunately that port relies on the webkit.py class
100         implementation which uses non-blocking I/O that isn't available on
101         Windows. This patch turns off that option and doesn't import the
102         class if we're running on Windows.
103
104         https://bugs.webkit.org/show_bug.cgi?id=37817
105
106         * Scripts/webkitpy/layout_tests/port/chromium.py:
107
108 2010-04-19  James Robinson  <jamesr@chromium.org>
109
110         Reviewed by abarth.
111
112         Fix a typo
113
114         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
115
116 2010-04-19  Adam Roben  <aroben@apple.com>
117
118         Fix run-webkit-tests when there are spaces in the path
119
120         Fixes <http://webkit.org/b/37809>
121
122         Reviewed by Adam Barth.
123
124         * Scripts/run-webkit-tests: Use an "indirect object" to specify the
125         path to the harness to exec(). According to perldoc, this usage will
126         prohibit perl from parsing the arguments to exec() via the shell,
127         which would incorrectly split paths with spaces in them, etc.
128
129 2010-04-19  Dave Moore  <davemoore@chromium.org>
130
131         Reviewed by Dimitri Glazkov.
132
133         Add test support for icon changes.
134
135         https://bugs.webkit.org/show_bug.cgi?id=33812
136
137         * DumpRenderTree/LayoutTestController.cpp:
138         (LayoutTestController::LayoutTestController):
139         (dumpIconChangesCallback):
140         (LayoutTestController::staticFunctions):
141         * DumpRenderTree/LayoutTestController.h:
142         (LayoutTestController::dumpIconChanges):
143         (LayoutTestController::setDumpIconChanges):
144         * DumpRenderTree/win/FrameLoadDelegate.cpp:
145         (FrameLoadDelegate::didChangeIcons):
146         * DumpRenderTree/win/FrameLoadDelegate.h:
147         * WinLauncher/WinLauncher.h:
148         (WinLauncherWebHost::didChangeIcons):
149
150 2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>
151
152         Reviewed by Adam Roben.
153
154         WinLauncher.h should use LF line-endings and use native line-endings style.
155         https://bugs.webkit.org/show_bug.cgi?id=37807
156
157         * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
158
159 2010-04-19  Kent Tamura  <tkent@chromium.org>
160
161         Reviewed by Shinichiro Hamaji.
162
163         [DRT/Chromium] Fix a test initialization problem
164         https://bugs.webkit.org/show_bug.cgi?id=37791
165
166         * DumpRenderTree/chromium/DumpRenderTree.cpp:
167         (runTest): Call resetTestController() before runFileTest(). Some
168           controllers initialize their fields in reset() and not in their
169           constructors.
170
171 2010-04-19  Kent Tamura  <tkent@chromium.org>
172
173         Reviewed by Eric Seidel.
174
175         [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
176         https://bugs.webkit.org/show_bug.cgi?id=37793
177
178         We need to use WebKitDriver instead of ChromiumDriver for Chromium
179         DRT because its interface is different from test_shell.
180
181         Chromium DRT has no UI.  So we can't use it to show test results.
182
183         * Scripts/webkitpy/layout_tests/port/chromium.py:
184
185 2010-04-18  Eric Seidel  <eric@webkit.org>
186
187         Reviewed by Adam Roben.
188
189         Make failure-reason more forgiving
190         https://bugs.webkit.org/show_bug.cgi?id=37525
191
192         Removed search_limit, which wasn't very useful anyway.
193         Added a log about the long load time loading from the builders.
194         Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
195
196         * Scripts/webkitpy/common/net/buildbot.py:
197         * Scripts/webkitpy/tool/commands/queries.py:
198
199 2010-04-18  Chris Jerdonek  <cjerdonek@webkit.org>
200
201         Reviewed by Shinichiro Hamaji.
202
203         Created a class for check-webkit-style that encapsulates iterating
204         over text files and reading them.
205
206         https://bugs.webkit.org/show_bug.cgi?id=37754
207
208         This revision is an intermediate step towards separating our
209         style-checking code from the logic of iterating over files and
210         reading them.
211
212         * Scripts/webkitpy/common/system/logtesting.py:
213           - Added a logMessages() method to the LoggingTestCase class.
214             This method provides unit tests with access to the raw list
215             of log messages in case the tester needs to do something more
216             than simply assert the list of existing messages.
217
218         * Scripts/webkitpy/style/checker.py:
219           - Added a ProcessorBase class that processors of lists of lines
220             should eventually inherit from.
221           - Also added a FIXME to use the ProcessorBase class and the
222             TextFileReader class added below.
223
224         * Scripts/webkitpy/style/filereader.py: Added.
225           - Created a TextFileReader class that encapsulates reading
226             and iterating over text files.
227
228         * Scripts/webkitpy/style/filereader_unittest.py: Added.
229           - Added a TextFileReaderTest class to unit-test the
230             new TextFileReader class.
231
232 2010-04-15  Tony Chang  <tony@chromium.org>
233
234         Reviewed by Adam Barth.
235
236         [chromium] new-run-webkit-tests should be able to use chromium DRT
237         https://bugs.webkit.org/show_bug.cgi?id=37645
238
239         Make sure that the lack of a chromium checkout doesn't cause the script to
240         fail.
241
242         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
243         * Scripts/webkitpy/layout_tests/port/chromium.py:
244         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
245             to be relative to an upstream output dir.
246         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
247
248 2010-04-18  Eric Seidel  <eric@webkit.org>
249
250         Unreviewed, fixing the Qt bot.
251
252         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
253         https://bugs.webkit.org/show_bug.cgi?id=37632
254
255         * Scripts/run-webkit-tests:
256          - Exit non-zero of launching the harness fails.
257
258 2010-04-18  Eric Seidel  <eric@webkit.org>
259
260         Unreviewed, fixing the Qt bot.
261
262         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
263         https://bugs.webkit.org/show_bug.cgi?id=37632
264
265         * Scripts/run-webkit-tests:
266          - Fix the wrapper to work for users who do not
267            have WebKitTools/Scripts in their path.
268
269 2010-04-14  Eric Seidel  <eric@webkit.org>
270
271         Reviewed by Adam Barth.
272
273         Add a layer of indirection when calling run-webkit-tests to
274         allow testing new-run-webkit-tests on various platforms.
275         https://bugs.webkit.org/show_bug.cgi?id=37632
276
277         This will let us test and fix bugs in new-run-webkit-tests
278         without needing to restart the buildbot master between tests.
279
280         Currently this change leaves run-webkit-tests as-is, but once
281         its landed we will easily be able to turn on/off
282         new-run-webkit-tests for various ports/configurations.
283
284         I will send a note out to webkit-dev about how we will
285         be using this launcher script to test on the bots.
286
287         * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
288         * Scripts/run-webkit-tests:
289          - A new script which decides whether to run new- or old-
290            run-webkit-tests based on the platform.
291         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
292          - Add some dummy argument handling for arguments which
293            old-run-webkit-tests supports but new-run-webkit-tests
294            does not yet.
295
296 2010-04-18  Eric Seidel  <eric@webkit.org>
297
298         Reviewed by Adam Barth.
299
300         Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
301         https://bugs.webkit.org/show_bug.cgi?id=33295
302
303         The Gtk builders have been green every time I've looked
304         at them in the last 5 days or so.  It would appear webkit
305         is now keeping them green and we should update the core
306         builder list to match reality.
307
308         * Scripts/webkitpy/common/net/buildbot.py:
309         * Scripts/webkitpy/common/net/buildbot_unittest.py:
310
311 2010-04-18  Robert Hogan  <robert@webkit.org>
312
313         Reviewed by Simon Hausmann.
314
315         [Qt] Add support for LayoutTestController commands:
316                    setSmartInsertDeleteEnabled
317                    setSelectTrailingWhitespaceEnabled
318                    execCommand
319                    isCommandEnabled
320
321         https://bugs.webkit.org/show_bug.cgi?id=35844
322
323         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
324         (WebCore::WebPage::resetSettings):
325         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
326         (LayoutTestController::setSmartInsertDeleteEnabled):
327         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
328         (LayoutTestController::execCommand):
329         (LayoutTestController::isCommandEnabled):
330         * DumpRenderTree/qt/LayoutTestControllerQt.h:
331
332 2010-04-17  Adam Barth  <abarth@webkit.org>
333
334         Reviewed by Eric Seidel.
335
336         Remove steps_references and commands_references
337         https://bugs.webkit.org/show_bug.cgi?id=37758
338
339         We tried using the mumble_references convention to manage our
340         dependencies, but it doesn't seem to be providing much value for the
341         steps and commands module because these modules are small pieces of the
342         larger tool module.  In this patch, I've removed the references file
343         for these modules.
344  
345         I've left the style_references file for the style module because that
346         module seems better isolated from the rest of webkitpy and the
347         style_references file appears to be providing some value.
348
349         * Scripts/webkitpy/tool/commands/commandtest.py:
350         * Scripts/webkitpy/tool/commands/download_unittest.py:
351         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
352         * Scripts/webkitpy/tool/commands/queries_unittest.py:
353         * Scripts/webkitpy/tool/commands/queues_unittest.py:
354         * Scripts/webkitpy/tool/commands/queuestest.py:
355         * Scripts/webkitpy/tool/commands/upload.py:
356         * Scripts/webkitpy/tool/commands/upload_unittest.py:
357         * Scripts/webkitpy/tool/commands_references.py: Removed.
358         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
359         * Scripts/webkitpy/tool/steps/steps_unittest.py:
360         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
361         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
362         * Scripts/webkitpy/tool/steps_references.py: Removed.
363
364 2010-04-17  Eric Seidel  <eric@webkit.org>
365
366         Reviewed by Adam Barth.
367
368         WebKit needs a Chromium Mac EWS Builder
369         https://bugs.webkit.org/show_bug.cgi?id=37742
370
371         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
372
373 2010-04-17  Adam Barth  <abarth@webkit.org>
374
375         Fix expected results for unit test broken by
376         http://trac.webkit.org/changeset/57772
377
378         * Scripts/webkitpy/common/net/buildbot_unittest.py:
379
380 2010-04-17  Sam Weinig  <weinig@apple.com>
381
382         Reviewed by Adam Roben.
383
384         Teach windows MiniBrowser how to work with window.open()
385         and targeted links.
386
387         * MiniBrowser/win/BrowserView.cpp:
388         (createNewPage): Create a new BrowserWindow and return its page.
389         (showPage): Show the page.
390         (closePage): Empty implementation.
391         (runJavaScriptAlert): Empty implementation.
392         (BrowserView::create): Register a UIClient.
393         * MiniBrowser/win/BrowserView.h:
394         (BrowserView::webView): Added.
395         Change create to take a BrowserWindow instead of an HWND.
396
397         * MiniBrowser/win/BrowserWindow.cpp:
398         (BrowserWindow::wndProc): Respond to WM_NCDESTROY.
399         (BrowserWindow::goToURL): Added. Forwards to BrowserView.
400         (BrowserWindow::onCreate): Don't always go to the default
401         url. Let the caller do this.
402         (BrowserWindow::onNCDestroy): Delete the window.
403         * MiniBrowser/win/BrowserWindow.h:
404         (BrowserWindow::view): Added.
405         (BrowserWindow::window): Added.
406
407         * MiniBrowser/win/main.cpp:
408         (_tWinMain):
409         Go to the default URL for the initial page. Allocate the initial
410         window on the heap for correctness.
411
412 2010-04-16  Adam Roben  <aroben@apple.com>
413
414         Add the Windows Debug (Test) builder to the list of core builders
415
416         It's been green for a few days now, and all the known Windows
417         flakiness is Release-only.
418
419         Rubber-stamped by Mark Rowe.
420
421         * Scripts/webkitpy/common/net/buildbot.py:
422         (BuildBot.core_builder_name_regexps): Added a regular expression to
423         match the "Windows Debug (Test)" builder.
424
425 2010-04-16  Sam Weinig  <sam@webkit.org>
426
427         Reviewed by Anders Carlsson.
428
429         Fix window.open() and targeted links.
430
431         * MiniBrowser/mac/BrowserWindowController.m:
432         (_createNewPage): Use the correct initializer to and load the window.
433
434 2010-04-16  Adam Roben  <aroben@apple.com>
435
436         Fix links to layout test results from build status pages
437
438         Reviewed by Mark Rowe.
439
440         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
441         (ExtractTestResults.finished): Prepend "/" on the URL of the test
442         results page so that it is treated as an absolute URL.
443
444 2010-04-16  Tony Chang  <tony@chromium.org>
445
446         Reviewed by Dimitri Glazkov.
447
448         [chromium] build DRT on Linux
449         https://bugs.webkit.org/show_bug.cgi?id=37690
450
451         * Scripts/build-dumprendertree: Add support for win and linux
452
453 2010-04-16  Sam Weinig  <weinig@apple.com>
454
455         Reviewed by Adam Roben.
456
457         Use the threaded process model for MiniBrowser if holding down
458         the shift key on startup.
459
460         * MiniBrowser/win/BrowserView.cpp:
461         (BrowserView::create): 
462
463 2010-04-15  Tony Chang  <tony@chromium.org>
464
465         Reviewed by Dimitri Glazkov.
466
467         [chromium] Add TestShellGtk.cpp so we can link on Linux
468         https://bugs.webkit.org/show_bug.cgi?id=37561
469
470         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and
471             add platform file exceptions.
472         * DumpRenderTree/chromium/TestShellGtk.cpp: Added.
473         (AlarmHandler):
474         (TestShell::waitTestFinished):
475
476 2010-04-15  Tony Chang  <tony@chromium.org>
477
478         Reviewed by Dimitri Glazkov.
479
480         build DRT on chromium mac
481         https://bugs.webkit.org/show_bug.cgi?id=37639
482
483         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
484         * Scripts/build-dumprendertree: enable build-dumprendertree --chromium
485
486 2010-04-15  Kent Tamura  <tkent@chromium.org>
487
488         Reviewed by Dimitri Glazkov.
489
490         [DRT/Chromium] Add LayoutTestHelper for Mac
491         https://bugs.webkit.org/show_bug.cgi?id=37668
492
493         LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
494         of Chromium.
495
496         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
497         * DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
498
499 2010-04-15  Alexey Proskuryakov  <ap@apple.com>
500
501         Reviewed by Geoff Garen.
502
503         https://bugs.webkit.org/show_bug.cgi?id=37494
504         <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
505         fails on Windows
506
507         * DumpRenderTree/win/EventSender.cpp: (makeEventSender):
508         * DumpRenderTree/win/EventSender.h:
509         Tell EventSender if it's being created for a top frame.
510         
511         * DumpRenderTree/win/FrameLoadDelegate.cpp:
512         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset
513         EventSender machinery when a new test is loaded, not when an iframe (or just its global
514         object) is created.
515
516 2010-04-15  Adam Roben  <aroben@apple.com>
517
518         Fix Windows WebKit2 build.
519
520         * MiniBrowser/win/MiniBrowser.cpp:
521
522 2010-04-15  Ojan Vafai  <ojan@chromium.org>
523
524         Reviewed by Adam Barth.
525
526         Include codereview issue number in patch description
527         https://bugs.webkit.org/show_bug.cgi?id=37677
528
529         This lets us know which rietveld issue this patch is tied to.
530
531         Also, make it so that --fancy-review overrides --no-review.
532
533         * Scripts/webkitpy/tool/steps/postcodereview.py:
534         * Scripts/webkitpy/tool/steps/postdiff.py:
535
536 2010-04-15  Adam Roben  <aroben@apple.com>
537
538         Make --exit-after-n-failures work when all tests are timing out or crashing
539
540         Fixes <http://webkit.org/b/37679>.
541
542         Reviewed by Jon Honeycutt.
543
544         * Scripts/run-webkit-tests:
545         (top level): When a test crashes or times out, break out of the main loop if
546         stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
547         from here...
548         (stopRunningTestsEarlyIfNeeded): ...to here.
549
550 2010-04-15  Sam Weinig  <sam@webkit.org>
551
552         Reviewed by Anders Carlsson.
553
554         Add WebHistoryClient support.
555         https://bugs.webkit.org/show_bug.cgi?id=37671
556
557         Add HistoryClient logging.
558
559         * MiniBrowser/mac/BrowserWindowController.m:
560         (_didNavigateWithNavigationData):
561         (_didPerformClientRedirect):
562         (_didPerformServerRedirect):
563         (_didUpdateHistoryTitle):
564         (-[BrowserWindowController awakeFromNib]):
565
566 2010-04-15  Anders Carlsson  <andersca@apple.com>
567
568         Reviewed by Sam Weinig.
569
570         Start the mini browser in threaded mode if shift is pressed during startup.
571         https://bugs.webkit.org/show_bug.cgi?id=37670
572
573         * MiniBrowser/mac/AppDelegate.m:
574         (-[BrowserAppDelegate init]):
575
576 2010-04-15  Chris Fleizach  <cfleizach@apple.com>
577
578         Reviewed by Beth Dakin.
579
580         AXHelp is being appended from ancestors incorrectly
581         https://bugs.webkit.org/show_bug.cgi?id=37659
582
583         * DumpRenderTree/AccessibilityUIElement.cpp:
584         (getHelpTextCallback):
585         (AccessibilityUIElement::getJSClass):
586         * DumpRenderTree/AccessibilityUIElement.h:
587         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
588         (AccessibilityUIElement::helpText):
589         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
590         (AccessibilityUIElement::helpText):
591         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
592         (AccessibilityUIElement::helpText):
593
594 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
595
596         Reviewed by Adam Barth.
597
598         Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
599         (broken by r57463 and r57381, at least). I've also filed bug 37477
600         to fix check-webkit-style to catch these things.
601
602         https://bugs.webkit.org/show_bug.cgi?id=38586
603
604         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
605
606 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
607
608         Reviewed by Dimitri Glazkov.
609
610         Add a way to override the user-visible name for the test binary since
611         some ports don't call it DumpRenderTree (e.g., Chromium Win uses
612         test_shell, Chromium Mac uses TestShell) by adding a driver_name()
613         method to the Port interface.
614
615         https://bugs.webkit.org/show_bug.cgi?id=37631
616
617         * Scripts/webkitpy/layout_tests/port/base.py:
618         * Scripts/webkitpy/layout_tests/port/chromium.py:
619         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
620         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
621
622 2010-04-14  Anders Carlsson  <andersca@apple.com>
623
624         Reviewed by Adam Roben.
625
626         Add "Force Repaint" to debug menu.
627         https://bugs.webkit.org/show_bug.cgi?id=37627
628
629         * MiniBrowser/mac/BrowserWindowController.h:
630         * MiniBrowser/mac/BrowserWindowController.m:
631         (-[BrowserWindowController forceRepaint:]):
632         * MiniBrowser/mac/English.lproj/MainMenu.xib:
633
634 2010-04-15  Sam Weinig  <sam@webkit.org>
635
636         Reviewed by Adam Roben.
637
638         Add debug-minibrowser script.
639
640         * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
641         * Scripts/webkitdirs.pm:
642
643 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
644  
645         Reviewed by Dimitri Glazkov.
646
647         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
648         https://bugs.webkit.org/show_bug.cgi?id=37636
649  
650         Second patch: add Windows-specific implementation parts
651         of TestShell.
652
653         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
654         * DumpRenderTree/chromium/TestShell.h:
655         (TestShell::finishedEvent):
656         * DumpRenderTree/chromium/TestShellWin.cpp:
657         (watchDogThread):
658         (TestShell::waitTestFinished):
659
660 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
661
662         Reviewed by Dimitri Glazkov.
663
664         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
665         https://bugs.webkit.org/show_bug.cgi?id=37636
666
667         First patch: fix compiler errors.
668
669         * DumpRenderTree/chromium/EventSender.cpp:
670         (EventSender::reset):
671         (EventSender::dispatchMessage):
672         * DumpRenderTree/chromium/LayoutTestController.cpp:
673         (LayoutTestController::pathToLocalResource):
674         * DumpRenderTree/chromium/TestWebWorker.h:
675         * DumpRenderTree/chromium/TextInputController.cpp:
676         * DumpRenderTree/chromium/WebViewHost.h:
677         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
678
679 2010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
680
681         Reviewed by Simon Hausmann.
682
683         [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
684         https://bugs.webkit.org/show_bug.cgi?id=37622
685
686         Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
687         (bug 35844). Moving it back.
688
689         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
690         (LayoutTestController::setViewModeMediaFeature):
691
692 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
693
694         Reviewed by Adam Barth.
695
696         Add some very minimal unit tests for new-run-webkit-tests. This should
697         be enough to catch egregious brokenness like syntax errors and import
698         declaration issues.
699
700         https://bugs.webkit.org/show_bug.cgi?id=37432
701
702         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
703         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
704
705 2010-04-14  Brian Weinstein  <bweinstein@apple.com>
706
707         Reviewed by Adam Roben.
708
709         Add a way for the buildbot to kill any old processes that are running. This
710         is useful because the Windows bots can get in states where a process remains
711         running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
712         state, and the processes must be killed manually.
713
714         * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill
715             the old processes that might be running.
716         * BuildSlaveSupport/win/kill-old-processes: Added.
717
718 2010-04-14  Sam Weinig  <sam@webkit.org>
719
720         Reviewed by Anders Carlsson.
721
722         Tear down WebKit more completely on window closing and application
723         termination. We still don't block application termination for pending
724         close, but this is a step in the right direction.
725
726         * MiniBrowser/mac/AppDelegate.m:
727         (-[BrowserAppDelegate applicationWillTerminate:]):
728         * MiniBrowser/mac/BrowserWindowController.h:
729         * MiniBrowser/mac/BrowserWindowController.m:
730         (-[BrowserWindowController dealloc]):
731         (-[BrowserWindowController windowWillClose:]):
732         (-[BrowserWindowController applicationTerminating]):
733
734 2010-04-14  Adam Barth  <abarth@webkit.org>
735
736         Reviewed by Eric Seidel.
737
738         Use pretty patch for confirming webkit-patch diffs
739         https://bugs.webkit.org/show_bug.cgi?id=37489
740
741         * Scripts/webkitpy/common/prettypatch.py: Added.
742         * Scripts/webkitpy/tool/commands/download_unittest.py:
743         * Scripts/webkitpy/tool/commands/upload_unittest.py:
744         * Scripts/webkitpy/tool/mocktool.py:
745         * Scripts/webkitpy/tool/steps/confirmdiff.py:
746
747 2010-04-14  Eric Seidel  <eric@webkit.org>
748
749         Reviewed by Adam Barth.
750
751         Teach webkit-patch how to handle revisions missing ChangeLogs
752         https://bugs.webkit.org/show_bug.cgi?id=37519
753
754         Make commit_info_for_revision return None when revision
755         is missing a ChangeLog.  Previously we would throw an array index
756         exception.
757         Teach callers how to handle None.
758
759         * Scripts/webkitpy/common/checkout/api.py:
760         * Scripts/webkitpy/common/checkout/api_unittest.py:
761         * Scripts/webkitpy/tool/commands/download.py:
762         * Scripts/webkitpy/tool/commands/queries.py:
763         * Scripts/webkitpy/tool/commands/sheriffbot.py:
764
765 2010-04-13  Eric Seidel  <eric@webkit.org>
766
767         Reviewed by Adam Roben.
768
769         Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
770         https://bugs.webkit.org/show_bug.cgi?id=33297
771
772         This is an experiment.  The bots have been green for
773         a while.  We'll see if adding them under sheriff-bot protection
774         will keep them green.
775
776         * Scripts/webkitpy/common/net/buildbot.py:
777         * Scripts/webkitpy/common/net/buildbot_unittest.py:
778
779 2010-04-13  Eric Seidel  <eric@webkit.org>
780
781         Unreviewed, just fixing a constant in the Rietveld unit test.
782
783         * Scripts/webkitpy/common/net/rietveld_unittest.py
784
785 2010-04-13  Eric Seidel  <eric@webkit.org>
786
787         Unreviewed, just adding missing Mock to fix python tests.
788
789         * Scripts/webkitpy/tool/mocktool.py:
790
791 2010-04-13  Ojan Vafai  <ojan@chromium.org>
792
793         Reviewed by David Levin.
794
795         Add experimental prototype Rietveld integration to webkit-patch upload
796         https://bugs.webkit.org/show_bug.cgi?id=37418
797
798         This patch adds bare-bones integration with Rietveld for code reviews.
799         The behavior is hidden behind the --fancy-review command line flag.
800         Currently, there's no support for uploading more than one patch per
801         issue (which is a nice feature of Rietveld).  The plan is to play with
802         this for a bit and see if it's useful.
803
804         Modified from Adam's original patch to autoinstall the rietveld upload script.
805
806         * Scripts/webkitpy/common/config/__init__.py:
807         * Scripts/webkitpy/common/net/rietveld.py: Added.
808         * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
809         * Scripts/webkitpy/tool/commands/queues_unittest.py:
810         * Scripts/webkitpy/tool/commands/upload.py:
811         * Scripts/webkitpy/tool/commands/upload_unittest.py:
812         * Scripts/webkitpy/tool/main.py:
813         * Scripts/webkitpy/tool/mocktool.py:
814         * Scripts/webkitpy/tool/steps/__init__.py:
815         * Scripts/webkitpy/tool/steps/options.py:
816         * Scripts/webkitpy/tool/steps/postcodereview.py: Added.
817         * Scripts/webkitpy/tool/steps/postdiff.py:
818
819 2010-04-13  Sam Weinig  <sam@webkit.org>
820
821         Rubber-stamped by Mark Rowe.
822
823         Add Makefile to MiniBrowser.
824
825         * MiniBrowser/Makefile: Added.
826
827 2010-04-13  Eric Seidel  <eric@webkit.org>
828
829         Unreviewed, just adding a sanity check.
830
831         Add check to make sure commit-queue can never commit too short a message
832         https://bugs.webkit.org/show_bug.cgi?id=37528
833
834         The commit-queue made bogus messages here:
835         http://trac.webkit.org/changeset/57532
836         http://trac.webkit.org/changeset/57534
837
838         This was a regression caused by adding unicode parsing for
839         our ChangeLog files.  Popen does not seem to play nice with
840         unicode strings.
841
842         I'm also adding an "assert" to make sure short ChangeLogs never happen again.
843
844         * Scripts/webkitpy/common/system/executive.py:
845          - Cast input to strings before passing to POpen
846         * Scripts/webkitpy/tool/steps/commit.py:
847          - Validate that commit messages are not to short.
848
849 2010-04-13  Adam Roben  <aroben@apple.com>
850
851         Robustify new-run-webkit-tests against paths with spaces in them
852
853         Reviewed by Eric Seidel.
854
855         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
856         (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to
857         Apache to ensure that paths with spaces in them are interpreted
858         correctly.
859
860 2010-04-13  Csaba Osztrogonác  <ossy@webkit.org>
861
862         Unreviewed buildfix after r57537.
863
864         * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
865
866 2010-04-13  Sam Weinig  <sam@webkit.org>
867
868         Reviewed by Maciej Stachowiak.
869
870         Make building new webkit API and MiniBrowser a little easier.
871
872         * Scripts/build-webkit: Make building with --webkit2 build the 
873         MiniBrowser as well and tell you how to use it.
874         * Scripts/run-minibrowser: Copied from Scripts/run-safari.
875         * Scripts/webkitdirs.pm: Add runMiniBrowser function.
876
877 2010-04-12  Timothy Hatcher  <timothy@apple.com>
878
879         SecurityOrigin needs a way to remove individual OriginAccessEntries
880         https://bugs.webkit.org/show_bug.cgi?id=37449
881
882         Reviewed by Dave Hyatt.
883
884         * DumpRenderTree/LayoutTestController.cpp:
885         (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
886         (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.
887         * DumpRenderTree/LayoutTestController.h:
888         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
889         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
890         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
891         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
892         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
893         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
894         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
895         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
896         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
897         (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
898         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
899
900 2010-04-13  Timothy Hatcher  <timothy@apple.com>
901
902         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
903         And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
904         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
905
906         SecurityOrigin needs a way to remove individual OriginAccessEntries
907         https://bugs.webkit.org/show_bug.cgi?id=37449
908
909         Reviewed by Dave Hyatt.
910
911         * DumpRenderTree/LayoutTestController.cpp:
912         (addOriginAccessWhitelistEntryCallback):
913         (LayoutTestController::staticFunctions):
914         * DumpRenderTree/LayoutTestController.h:
915         * DumpRenderTree/chromium/LayoutTestController.cpp:
916         (LayoutTestController::LayoutTestController):
917         (LayoutTestController::addOriginAccessWhitelistEntry):
918         * DumpRenderTree/chromium/LayoutTestController.h:
919         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
920         (LayoutTestController::addOriginAccessWhitelistEntry):
921         * DumpRenderTree/mac/DumpRenderTree.mm:
922         (resetWebViewToConsistentStateBeforeTesting):
923         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
924         (LayoutTestController::addOriginAccessWhitelistEntry):
925         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
926         (LayoutTestController::addOriginAccessWhitelistEntry):
927         * DumpRenderTree/qt/LayoutTestControllerQt.h:
928         * DumpRenderTree/win/DumpRenderTree.cpp:
929         (resetWebViewToConsistentStateBeforeTesting):
930         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
931         (LayoutTestController::addOriginAccessWhitelistEntry):
932         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
933         (LayoutTestController::addOriginAccessWhitelistEntry):
934
935 2010-04-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
936
937         Reviewed by Eric Seidel.
938
939         Remove duplicate function for new-run-webkit-tests
940         https://bugs.webkit.org/show_bug.cgi?id=37517
941
942         The version() function was already implemented.
943
944         * Scripts/webkitpy/layout_tests/port/webkit.py:
945
946 2010-04-13  Eric Seidel  <eric@webkit.org>
947
948         Reviewed by David Levin.
949
950         the commit-queue hates Tor Arne Vestbø
951         https://bugs.webkit.org/show_bug.cgi?id=37511
952
953         We were failing to read reviewers out of ChangeLogs
954         when the reviewer has unicode characters in his/her name.
955         I fixed this by explicitly decoding from utf8 every time we
956         read in a ChangeLog file (they are always UTF8).
957
958         * Scripts/webkitpy/common/checkout/changelog.py:
959         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
960
961 2010-04-13  Adam Roben  <aroben@apple.com>
962
963         Fix run-webkit-tests on Windows with spaces in the path
964
965         Fixes <http://webkit.org/b/37509>.
966
967         Reviewed by Steve Falkenburg.
968
969         * Scripts/run-webkit-tests:
970         (convertPathUsingCygpath): Remove spaces from the path before passing
971         them to cygpath, then add them back in after conversion, as some
972         versions of cygpath seem to convert spaces into newlines.
973
974 2010-04-13  Adam Barth  <abarth@webkit.org>
975
976         Unreviewed, but approved by Dumitru Daniliuc.  (This patch is intended
977         to fix the downstream Chromium build bots.  Hopefully it will work!)
978
979         Add a driver script for the new websocket server
980         https://bugs.webkit.org/show_bug.cgi?id=37495
981
982         websocket_server.py can't be run directly because its a module and not
983         a standalone script.  This used to work by accident because it didn't
984         depend on any other modules.
985
986         * Scripts/new-run-webkit-websocketserver: Added.
987         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
988
989 2010-04-12  Eric Seidel  <eric@webkit.org>
990
991         Reviewed by Adam Barth.
992
993         Make new-run-webkit-test PrettyPatch failure reporting more awesome
994         https://bugs.webkit.org/show_bug.cgi?id=37487
995
996         I also fixed an Executive/executive typo.
997
998         * Scripts/webkitpy/layout_tests/port/base.py:
999
1000 2010-04-12  Eric Seidel  <eric@webkit.org>
1001
1002         Reviewed by Adam Barth.
1003
1004         new-run-webkit-tests should only build java support files on Mac
1005         https://bugs.webkit.org/show_bug.cgi?id=37482
1006
1007         Only the mac needs java support files, so I pushed _build_java
1008         down into the Mac port using a new hook "_check_port_build".
1009         In the process I noticed a bunch of code which could be shared
1010         between all ports and thus got rid of _tests_for_disabled_features
1011         and version() copy/paste between all webkit ports.
1012         I also made check_build only bother to check for ImageDiff if we're
1013         using pixel tests.
1014
1015         * Scripts/webkitpy/layout_tests/port/gtk.py:
1016         * Scripts/webkitpy/layout_tests/port/mac.py:
1017         * Scripts/webkitpy/layout_tests/port/qt.py:
1018         * Scripts/webkitpy/layout_tests/port/webkit.py:
1019         * Scripts/webkitpy/layout_tests/port/win.py:
1020
1021 2010-04-12  Dumitru Daniliuc  <dumi@chromium.org>
1022
1023         Unreviewed, trying to make scripts work on machines without
1024         Ruby...
1025
1026         * Scripts/webkitpy/layout_tests/port/base.py:
1027
1028 2010-04-12  Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1029
1030         Reviewed by Eric Seidel.
1031
1032         Add stub files for running new-run-webkit-tests for the Qt port
1033
1034         * Scripts/webkitpy/layout_tests/port/factory.py:
1035         * Scripts/webkitpy/layout_tests/port/qt.py: Added.
1036
1037 2010-04-12  Dirk Pranke  <dpranke@chromium.org>
1038
1039         Reviewed by Eric Seidel.
1040
1041         Modify run_webkit_tests.py to not call sys.exit() at the end of test
1042         run; doing so makes it more difficult to embed the routine for,
1043         among other things, unit tests. We push the exit calling up into
1044         new-run-webkit-tests.
1045
1046         https://bugs.webkit.org/show_bug.cgi?id=37464
1047
1048         * Scripts/new-run-webkit-tests:
1049         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1050
1051 2010-04-12  Eric Seidel  <eric@webkit.org>
1052
1053         Unreviewed.
1054
1055         Add stub Gtk implementation for new-run-webkit-tests.
1056
1057         * Scripts/webkitpy/layout_tests/port/factory.py:
1058         * Scripts/webkitpy/layout_tests/port/gtk.py: Added.
1059
1060 2010-04-12  Eric Seidel  <eric@webkit.org>
1061
1062         Reviewed by Adam Barth.
1063
1064         new-run-webkit-tests fails with exception on systems missing ruby
1065         https://bugs.webkit.org/show_bug.cgi?id=37441
1066
1067         * Scripts/webkitpy/layout_tests/port/base.py:
1068          - Catch failures similar to how wdiff code path does.
1069          - After one failure, stop trying.
1070
1071 2010-04-12  Tony Chang  <tony@chromium.org>
1072
1073         Reviewed by Eric Seidel.
1074
1075         Fix how we import simplejson based on how it's used in this file.
1076         This fixes exceptions raised when trying to write the simplejson output.
1077
1078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1079
1080 2010-04-11  Chris Jerdonek  <cjerdonek@webkit.org>
1081
1082         Reviewed by Shinichiro Hamaji.
1083
1084         Refactored check-webkit-style so that the StyleChecker class
1085         has no dependencies on patch-related concepts.
1086
1087         https://bugs.webkit.org/show_bug.cgi?id=37065
1088
1089         This patch is an intermediate step towards making the StyleChecker
1090         class a generalized file processor that can do arbitary operations
1091         on the files corresponding to a list of paths.  This patch
1092         also simplifies the unit-testing of patch-checking code.
1093
1094         * Scripts/check-webkit-style:
1095           - Updated to use the new PatchChecker class.
1096
1097         * Scripts/webkitpy/style/checker.py:
1098           - Refactored the StyleChecker.check_patch() method into the
1099             check() method of a new PatchChecker class.
1100
1101         * Scripts/webkitpy/style/checker_unittest.py:
1102           - Refactored the unit tests as necessary, changing the
1103             StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
1104
1105 2010-04-11  Adam Barth  <abarth@webkit.org>
1106
1107         Unreviewed.
1108
1109         Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
1110         https://bugs.webkit.org/show_bug.cgi?id=37430
1111
1112         We need some basic unit testing of this script, or we're going to keep
1113         breaking it like this.  Added missing namespace qualifiers and
1114         propagated renaming of an option.
1115
1116         * Scripts/webkitpy/common/config/ports.py:
1117         * Scripts/webkitpy/layout_tests/driver_test.py:
1118         * Scripts/webkitpy/layout_tests/port/base.py:
1119         * Scripts/webkitpy/layout_tests/port/mac.py:
1120         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1121
1122 2010-04-11  Eric Seidel  <eric@webkit.org>
1123
1124         Reviewed by Adam Barth.
1125
1126         Break new-run-webkit-tests options into groups for easier re-use and possible relocation
1127         https://bugs.webkit.org/show_bug.cgi?id=37408
1128
1129         new-run-webkit-tests currently has one huge function for
1130         dealing with all options-parsing. 
1131         This patch is a first attempt at trying to split that large
1132         function down into smaller (hopefully more readable?) chunks
1133         dealing with the different areas of options.
1134         For example, it would make sense to move configuration
1135         options off into some module which deals with the vagries of
1136         WebKit's configuration system.  It would also make sense to move
1137         Chromium options off onto the Chromium port object (where they are used).
1138         It may make sense to move results.json options over to the results.json code.
1139         This change is a first iteration, and we will certainly need more
1140         refinement to this code over time.  Hopefully I didn't make things
1141         harder to read here.
1142
1143         * Scripts/webkitpy/layout_tests/driver_test.py:
1144         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1145
1146 2010-04-11  Adam Barth  <abarth@webkit.org>
1147
1148         Reviewed by Eric Seidel.
1149
1150         create-rollout copy needs to be updated to reflect removal of --no-build
1151         https://bugs.webkit.org/show_bug.cgi?id=37425
1152
1153         Removed --no-build and --no-test from the instructions because these
1154         don't exist anymore.
1155
1156         * Scripts/webkitpy/tool/commands/download_unittest.py:
1157             - Updated the expected results to reflect the new copy.
1158         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1159
1160 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1161
1162         Unreviewed, rolling out r57460.
1163         http://trac.webkit.org/changeset/57460
1164         https://bugs.webkit.org/show_bug.cgi?id=37424
1165
1166         broke chromium builders (Requested by tony^work on #webkit).
1167
1168         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1169
1170 2010-04-11  Tony Chang  <tony@chromium.org>
1171
1172         Reviewed by Darin Fisher.
1173
1174         [chromium] update chromium DEPS for upstream compile
1175         https://bugs.webkit.org/show_bug.cgi?id=36578
1176
1177         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between
1178           WebKit.gyp and webkit.gyp.
1179
1180 2010-04-11  Joseph Pecoraro  <joepeck@webkit.org>
1181
1182         Reviewed by Eric Seidel.
1183
1184         svn-apply errors out when removing directories in git
1185         https://bugs.webkit.org/show_bug.cgi?id=34871
1186
1187         * Scripts/svn-apply:
1188         (isDirectoryEmptyForRemoval): early break if the directory doesn't exist
1189         (scmRemove): have git ignore unmatched files
1190
1191 2010-04-11  Daniel Bates  <dbates@rim.com>
1192
1193         No review, rolling out 57440.
1194         http://trac.webkit.org/changeset/57440
1195         https://bugs.webkit.org/show_bug.cgi?id=27204
1196
1197         Did not handle Git patches that included both file and property
1198         changes to the same file. Rolling this change out while I look
1199         into this.
1200
1201         * Scripts/VCSUtils.pm:
1202         * Scripts/svn-apply:
1203         * Scripts/svn-unapply:
1204         * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed.
1205         * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed.
1206         * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed.
1207
1208 2010-04-11  Adam Barth  <abarth@webkit.org>
1209
1210         Reviewed by Eric Seidel.
1211
1212         Fix typo in log path for AbstractQueue
1213         https://bugs.webkit.org/show_bug.cgi?id=37414
1214
1215         * Scripts/webkitpy/tool/commands/queues.py:
1216         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1217
1218 2010-04-11  Adam Barth  <abarth@webkit.org>
1219
1220         Unreviewed.  Add missing import statement.
1221
1222         * Scripts/webkitpy/common/system/executive.py:
1223
1224 2010-04-11  Robert Hogan  <robert@webkit.org>
1225
1226         Reviewed by Simon Hausmann.
1227
1228         [Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader
1229
1230         https://bugs.webkit.org/show_bug.cgi?id=37410
1231
1232         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1233         (LayoutTestController::reset):
1234         (LayoutTestController::setWillSendRequestReturnsNull):
1235         (LayoutTestController::setWillSendRequestClearHeader):
1236         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1237
1238 2010-04-11  Csaba Osztrogonác  <ossy@webkit.org>
1239
1240         [Qt] Unreviewed buildfix for --debug build after r57433.
1241
1242         Refactor Qt DRT support in QtWebKit
1243         https://bugs.webkit.org/show_bug.cgi?id=35844
1244
1245         * QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect();
1246         (launcherMain):
1247
1248 2010-04-11  Joseph Pecoraro  <joepeck@webkit.org>
1249
1250         Reviewed by Mark Rowe.
1251
1252         Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
1253         https://bugs.webkit.org/show_bug.cgi?id=37407
1254
1255         * Scripts/commit-log-editor:
1256
1257 2010-04-11  Eric Seidel  <eric@webkit.org>
1258
1259         Reviewed by Adam Barth.
1260
1261         Add PrettyPatch links to new-run-webkit-tests output
1262         https://bugs.webkit.org/show_bug.cgi?id=37406
1263
1264         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1265          - We're leaking a file handle here, add a FIXME.
1266         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1267          - Add pretty diff links.
1268         * Scripts/webkitpy/layout_tests/port/base.py:
1269          - Add support for generating pretty diffs using PrettyPatch.
1270         * Scripts/webkitpy/layout_tests/port/webkit.py:
1271          - We're leaking another file handle here, another FIXME.
1272         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1273          - Update write_output_files signature.
1274         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1275          - Remove unused arguments from write_output_files.
1276          - Add support for dumping pretty diffs to write_output_files.
1277          - Fix a bunch of file descriptor leaks in this file.
1278         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1279          - Update write_output_files signature.
1280
1281 2010-04-10  Adam Barth  <abarth@webkit.org>
1282
1283         Reviewed by Eric Seidel.
1284
1285         kill_process is copy/pasted in five places
1286         https://bugs.webkit.org/show_bug.cgi?id=37405
1287
1288         We shouldn't replicate the kill_process logic in every port.  Instead,
1289         we should move the process interaction to Executive.
1290
1291         Dirk mentioned that he wanted this abstraction to make it easier to
1292         mock things out for testing.  It turns out this function is only used
1293         in one place where it can't be used as a mock point for testing because
1294         the corresponding create process actually creates a real process.  In
1295         the long term, we should indirect both these calls through a non-static
1296         Executive as a mock point.  However, we should wait on that until we
1297         actually want to write the test.
1298
1299         * Scripts/webkitpy/layout_tests/port/base.py:
1300         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1301         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1302         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1303         * Scripts/webkitpy/layout_tests/port/mac.py:
1304         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1305         * Scripts/webkitpy/layout_tests/port/win.py:
1306
1307 2010-04-10  Adam Barth  <abarth@webkit.org>
1308
1309         Reviewed by Eric Seidel.
1310
1311         new-run-webkit-tests shouldn't alter its path to import packages
1312         https://bugs.webkit.org/show_bug.cgi?id=37404
1313
1314         * Scripts/new-run-webkit-tests:
1315         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1316         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1317         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1319         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1320         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1321         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1322         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
1323
1324 2010-04-10  Eric Seidel  <eric@webkit.org>
1325
1326         Reviewed by Adam Barth.
1327
1328         new-run-webkit-tests should store results to a directory under the build tree
1329         https://bugs.webkit.org/show_bug.cgi?id=37380
1330
1331         * Scripts/webkitpy/layout_tests/port/webkit.py:
1332
1333 2010-04-10  Daniel Bates  <dbates@rim.com>
1334
1335         Reviewed by Eric Seidel.
1336
1337         https://bugs.webkit.org/show_bug.cgi?id=27204
1338
1339         Implement support for changing the executable bit of a file.
1340         The executable bit is among the most changed file properties.
1341         Future support can include other property changes.
1342
1343         Currently, if a patch changes the executable bit of a file
1344         it is not respected by svn-apply or svn-unapply. Since the
1345         commit-queue bot uses these tools as part of its workflow,
1346         such patches cannot be committed by it. That is, such patches
1347         need to be committed by hand. Instead, we should add support
1348         for the executable bit so that such patches can be committed
1349         by the commit-queue bot.
1350
1351         * Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc.
1352         in copyright to Apple, Inc.
1353         * Scripts/svn-apply:
1354         * Scripts/svn-unapply:
1355         * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added.
1356         * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added.
1357         * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added.
1358
1359 2010-04-10  Eric Seidel  <eric@webkit.org>
1360
1361         Reviewed by Adam Barth.
1362
1363         WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
1364         https://bugs.webkit.org/show_bug.cgi?id=37401
1365
1366         The Git-based bots don't have this trouble because
1367         Git.clean_working_directory fully removes files that were
1368         marked as "add".  SVN.clean_working_directory previously just
1369         called "svn revert" which would leave added files in the
1370         working directory untracked.  This patch makes
1371         SVN.clean_working_directory function more like
1372         Git.clean_working_directory by removing added files after revert.
1373
1374         * Scripts/webkitpy/common/checkout/scm.py:
1375          - Add SCM.absolute_path for easy conversion between
1376            repository-relative paths and absolute paths.
1377          - Add SCM.add and SCM.added_files
1378          - Make SVN.clean_working_directory remove any added_files after svn revert.
1379          - The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead.
1380         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1381          - Add tests for added code.
1382
1383 2010-04-10  Adam Barth  <abarth@webkit.org>
1384
1385         Reviewed by Eric Seidel.
1386
1387         new-run-webkit-tests can't find ImageDiff on Windows
1388         https://bugs.webkit.org/show_bug.cgi?id=37403
1389
1390         It turns out the build directory on Windows is structured differently
1391         than it is on other platforms.  Instead of assuming the normal
1392         structure, we should just ask perl to figure it out for us.
1393
1394         * Scripts/webkitpy/layout_tests/port/webkit.py:
1395
1396 2010-04-10  Adam Barth  <abarth@webkit.org>
1397
1398         Rubber-stamped by Eric Seidel.
1399
1400         Change "Gathering files" status line to "Collecting tests".  Gathering
1401         the files sounds silly to me.
1402
1403         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1404
1405 2010-04-10  Adam Barth  <abarth@webkit.org>
1406
1407         Reviewed by Eric Seidel.
1408
1409         Fix bugs to make new-run-webkit-tests almost run on windows
1410         https://bugs.webkit.org/show_bug.cgi?id=37400
1411
1412         Fix some minor bugs that prevent new-run-webkit-tests from being run on
1413         Windows.  I still haven't run it to completion, but I'm getting
1414         further.
1415
1416         * Scripts/webkitpy/layout_tests/port/factory.py:
1417         * Scripts/webkitpy/layout_tests/port/webkit.py:
1418
1419 2010-04-10  Robert Hogan  <robert@webkit.org>
1420
1421         Reviewed by Kenneth Rohde Christiansen.
1422
1423         Refactor Qt DRT support in QtWebKit
1424
1425         Update Qt DRT to use new DumpRenderTreeSupportQt static class.
1426
1427         https://bugs.webkit.org/show_bug.cgi?id=35844
1428
1429         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1430         (WebCore::DumpRenderTree::DumpRenderTree):
1431         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1432         (WebCore::DumpRenderTree::dumpFramesAsText):
1433         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1434         * DumpRenderTree/qt/GCControllerQt.cpp:
1435         (GCController::collect):
1436         (GCController::collectOnAlternateThread):
1437         (GCController::getJSObjectCount):
1438         * DumpRenderTree/qt/GCControllerQt.h:
1439         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1440         (LayoutTestController::counterValueForElementById):
1441         (LayoutTestController::setViewModeMediaFeature):
1442         (LayoutTestController::setMediaType):
1443         (LayoutTestController::closeWebInspector):
1444         (LayoutTestController::showWebInspector):
1445         (LayoutTestController::evaluateInWebInspector):
1446         (LayoutTestController::setFrameFlatteningEnabled):
1447         (LayoutTestController::setJavaScriptProfilingEnabled):
1448         (LayoutTestController::setTimelineProfilingEnabled):
1449         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1450         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1451         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1452         (LayoutTestController::numberOfActiveAnimations):
1453         (LayoutTestController::whiteListAccessFromOrigin):
1454         (LayoutTestController::setCaretBrowsingEnabled):
1455         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1456         (LayoutTestController::workerThreadCount):
1457         (LayoutTestController::pageNumberForElementById):
1458         (LayoutTestController::numberOfPages):
1459         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1460
1461 2010-04-10  Adam Barth  <abarth@webkit.org>
1462
1463         Reviewed by Eric Seidel.
1464
1465         Move global queue log to the logs directory so it survives git clean -f
1466         https://bugs.webkit.org/show_bug.cgi?id=37395
1467
1468         * Scripts/webkitpy/tool/commands/queues.py:
1469
1470 2010-04-10  Adam Barth  <abarth@webkit.org>
1471
1472         Reviewed by Eric Seidel.
1473
1474         SheriffBot should spam when it encounters errors
1475         https://bugs.webkit.org/show_bug.cgi?id=37329
1476
1477         We need to always update the status server so we don't get stuck in a
1478         spam loop.  I tried writing a test for this change, but it kind of
1479         got out of control.  We need a better way to do failure injection.
1480
1481         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1482
1483 2010-04-10  Adam Barth  <abarth@webkit.org>
1484
1485         Unreviewed attempt to fix the Chromium Mac canary.
1486
1487         * Scripts/webkitpy/common/config/ports.py:
1488         * Scripts/webkitpy/common/config/ports_unittest.py:
1489         * Scripts/webkitpy/common/system/executive.py:
1490
1491 2010-04-10  Adam Barth  <abarth@webkit.org>
1492
1493         Unreviewed.
1494
1495         Add the Apache bits to win.py for new-run-webkit-tests
1496         https://bugs.webkit.org/show_bug.cgi?id=37397
1497
1498         I still have run this yet, but I looked around to figure out what the
1499         various paths appear to be.  I'll figure out a way to remove the
1500         copy/paste code in a future patch.
1501
1502         * Scripts/webkitpy/layout_tests/port/mac.py:
1503         * Scripts/webkitpy/layout_tests/port/webkit.py:
1504         * Scripts/webkitpy/layout_tests/port/win.py:
1505
1506 2010-04-10  Adam Barth  <abarth@webkit.org>
1507
1508         Reviewed by Eric Seidel.
1509
1510         Sketch out the win port for new-run-webkit-tests
1511         https://bugs.webkit.org/show_bug.cgi?id=37393
1512
1513         I haven't tried running this yet, but we've got to start somewhere.
1514
1515         * Scripts/webkitpy/layout_tests/port/factory.py:
1516         * Scripts/webkitpy/layout_tests/port/mac.py:
1517         * Scripts/webkitpy/layout_tests/port/webkit.py:
1518         * Scripts/webkitpy/layout_tests/port/win.py: Added.
1519
1520 2010-04-10  Ojan Vafai  <ojan@chromium.org>
1521
1522         Reviewed by Adam Barth.
1523
1524         webkit-patch land should not build and test by default
1525         https://bugs.webkit.org/show_bug.cgi?id=33631
1526
1527         Reverse the sense of --no-build and --no-test to be --build and --test.
1528         Also, decoupled the build and test options so you can test without
1529         building.
1530
1531         (Patch manngled by Adam Barth.  All bugs are his fault.)
1532
1533         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1534         * Scripts/webkitpy/tool/commands/queues.py:
1535         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1536         * Scripts/webkitpy/tool/steps/options.py:
1537         * Scripts/webkitpy/tool/steps/runtests.py:
1538
1539 2010-04-10  Adam Barth  <abarth@webkit.org>
1540
1541         Reviewed by Eric Seidel.
1542
1543         Factor WebKitPort out of MacPort to allow for WinPort
1544         https://bugs.webkit.org/show_bug.cgi?id=37388
1545
1546         The split is a bit of a guess.  We might have to adjust things once we
1547         actually have a second port to work with.
1548
1549         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1550         * Scripts/webkitpy/layout_tests/port/mac.py:
1551         * Scripts/webkitpy/layout_tests/port/webkit.py: Added.
1552         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1553
1554 2010-04-10  Adam Barth  <abarth@webkit.org>
1555
1556         Reviewed by Eric Seidel.
1557
1558         run_webkit_tests.py shouldn't have platform-specific logic
1559         https://bugs.webkit.org/show_bug.cgi?id=37387
1560
1561         Dirk Pranke pointed out that my last patch was wrong because I
1562         introduced platform-specific logic into run_webkit_tests.py, limiting
1563         the parallelism in Chromium to work around a bug in the main Mac port.
1564
1565         * Scripts/webkitpy/common/system/executive.py:
1566             - Fix a typo pointed out by Chris Jerdonek.
1567         * Scripts/webkitpy/layout_tests/port/base.py:
1568         * Scripts/webkitpy/layout_tests/port/mac.py:
1569         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1570
1571 2010-04-10  Robert Hogan  <robert@webkit.org>
1572
1573         Unreviewed fix to regressions in r57416.
1574
1575         [Qt] Fix regressions in http/tests/navigation from r57416
1576
1577         Reset willSendRequestReturnsNullOnRedirect after each test to
1578         prevent it leaking to subsequent tests.
1579
1580         Error pointed out by Jakub Wieczorek.
1581
1582         https://bugs.webkit.org/show_bug.cgi?id=37237
1583
1584         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1585         (LayoutTestController::reset):
1586
1587 2010-04-11  Robert Hogan  <robert@webkit.org>
1588
1589         Reviewed by Simon Hausmann.
1590
1591         [Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.
1592
1593         Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT.
1594         Prevent dumping resource load callbacks once layout test has dumped.
1595
1596         https://bugs.webkit.org/show_bug.cgi?id=37237
1597
1598         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1599         (WebCore::DumpRenderTree::dump):
1600         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1601         (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
1602         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1603
1604 2010-04-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1605
1606         Reviewed by Kenneth Rohde Christiansen.
1607
1608         [Qt] Implement Desktop Notifications API for QtWebKit
1609         https://bugs.webkit.org/show_bug.cgi?id=35503
1610
1611         DRT stubs for notification. Enables to run and pass
1612         3 (currently disabled) tests.
1613
1614         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1615         (LayoutTestController::LayoutTestController):
1616         (LayoutTestController::grantDesktopNotificationPermission):
1617         (LayoutTestController::checkDesktopNotificationPermission):
1618         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1619
1620 2010-04-09  Dumitru Daniliuc  <dumi@chromium.org>
1621
1622         Unreviewed, another change to executive.py to make it run with
1623         python 2.4.
1624
1625         * Scripts/webkitpy/common/system/executive.py:
1626
1627 2010-04-09  Dumitru Daniliuc  <dumi@chromium.org>
1628
1629         Unreviewed, attempting to make executive.py run with python 2.4
1630         (which is still used on Chromium's Windows canary bot).
1631
1632         * Scripts/webkitpy/common/system/executive.py:
1633
1634 2010-04-09  Kevin Watters  <kevinwatters@gmail.com>
1635
1636         Reviewed by Eric Seidel.
1637
1638         [wx] Basic implementation of SVG support for wx port.
1639
1640         * wx/build/settings.py:
1641
1642 2010-04-09  Adam Barth  <abarth@webkit.org>
1643
1644         Reviewed by Eric Seidel.
1645
1646         Don't reinvent Executive.cpu_count for every port
1647         https://bugs.webkit.org/show_bug.cgi?id=37377
1648
1649         mac.py and chromium_mac.py had some copy/paste code.  This code doesn't
1650         actually have anything to do with WebKit ports.  It's really just
1651         something in the multiprocessing package.  The lame bit is that package
1652         isn't available in older versions of Python, so we need to implement a
1653         fallback.  However, we already have the fallback in common.  We don't
1654         need to reinvent it specificly for layout_tests.
1655
1656         * Scripts/webkitpy/common/system/executive.py:
1657         * Scripts/webkitpy/layout_tests/port/base.py:
1658         * Scripts/webkitpy/layout_tests/port/chromium.py:
1659         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1660         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1661         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1662         * Scripts/webkitpy/layout_tests/port/mac.py:
1663         * Scripts/webkitpy/layout_tests/port/test.py:
1664         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1665
1666 2010-04-09  Adam Barth  <abarth@webkit.org>
1667
1668         Reviewed by Eric Seidel.
1669
1670         new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
1671         https://bugs.webkit.org/show_bug.cgi?id=37376
1672
1673         We need to explicitly pass the --release flag.  I bet there are more
1674         instances of this bug.
1675
1676         * Scripts/webkitpy/layout_tests/port/base.py:
1677         * Scripts/webkitpy/layout_tests/port/mac.py:
1678
1679 2010-04-09  Tony Chang  <tony@chromium.org>
1680
1681         Reviewed by Eric Seidel.
1682
1683         [chromium] DRT compile fix on win/linux
1684         https://bugs.webkit.org/show_bug.cgi?id=37314
1685
1686         Looks like this was missed when upstreaming.
1687
1688         * DumpRenderTree/chromium/EventSender.cpp:
1689         (applyKeyModifier):
1690
1691 2010-04-09  Adam Barth  <abarth@webkit.org>
1692
1693         Unreviewed, but approved by Dirk Pranke.
1694
1695         rename test_expectations_test.py to test_expectations_unittest.py so it actually gets run
1696         https://bugs.webkit.org/show_bug.cgi?id=37372
1697
1698         We need to end unit tests with _unittest.py for them to be autodetected
1699         by the test harness.  +6 tests.
1700
1701         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py.
1702
1703 2010-04-09  Adam Barth  <abarth@webkit.org>
1704
1705         Reviewed by Eric Seidel.
1706
1707         new-run-webkit-tests should talk about DumpRenderTree not test_shell
1708         https://bugs.webkit.org/show_bug.cgi?id=37371
1709
1710         test_shell is some strange Chromium thing.
1711         DumpRenderTree (tm) is the real deal.
1712
1713         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Added.
1714         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1715         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1716         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Removed.
1717         * Scripts/webkitpy/layout_tests/port/chromium.py:
1718         * Scripts/webkitpy/layout_tests/port/server_process.py:
1719         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1720
1721 2010-04-09  Zoltan Horvath  <zoltan@webkit.org>
1722
1723         Reviewed by Alexey Proskuryakov.
1724
1725         Fix 2 issues (what were introduced in r56524) in svn-create-patch's generateDiff()
1726         https://bugs.webkit.org/show_bug.cgi?id=32582
1727
1728         Add missing return variable. Initialize $patch variable and remove unnecessary condition.
1729
1730         * Scripts/svn-create-patch:
1731
1732 2010-04-09  Kevin Ollivier  <kevino@theolliviers.com>
1733
1734         [wx] Build fix after addition of LayoutTestController method.
1735
1736         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1737         (LayoutTestController::computedStyleIncludingVisitedInfo):
1738
1739 2010-04-09  Sam Weinig  <sam@webkit.org>
1740
1741         Reviewed by Anders Carlsson.
1742
1743         Fix for https://bugs.webkit.org/show_bug.cgi?id=37368
1744         Add MiniBrowser.
1745
1746         * MiniBrowser: Added.
1747         * MiniBrowser/MiniBrowser.vcproj: Added.
1748         * MiniBrowser/MiniBrowser.xcodeproj: Added.
1749         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added.
1750         * MiniBrowser/mac: Added.
1751         * MiniBrowser/mac/AppDelegate.h: Added.
1752         * MiniBrowser/mac/AppDelegate.m: Added.
1753         * MiniBrowser/mac/BrowserWindowController.h: Added.
1754         * MiniBrowser/mac/BrowserWindowController.m: Added.
1755         * MiniBrowser/mac/English.lproj: Added.
1756         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Added.
1757         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Added.
1758         * MiniBrowser/mac/English.lproj/MainMenu.xib: Added.
1759         * MiniBrowser/mac/MiniBrowser-Info.plist: Added.
1760         * MiniBrowser/mac/MiniBrowser_Prefix.pch: Added.
1761         * MiniBrowser/mac/main.m: Added.
1762         * MiniBrowser/win: Added.
1763         * MiniBrowser/win/BrowserView.cpp: Added.
1764         * MiniBrowser/win/BrowserView.h: Added.
1765         * MiniBrowser/win/BrowserWindow.cpp: Added.
1766         * MiniBrowser/win/BrowserWindow.h: Added.
1767         * MiniBrowser/win/MiniBrowser.cpp: Added.
1768         * MiniBrowser/win/MiniBrowser.h: Added.
1769         * MiniBrowser/win/MiniBrowser.rc: Added.
1770         * MiniBrowser/win/Resources: Added.
1771         * MiniBrowser/win/main.cpp: Added.
1772         * MiniBrowser/win/resource.h: Added.
1773         * MiniBrowser/win/stdafx.cpp: Added.
1774         * MiniBrowser/win/stdafx.h: Added.
1775
1776 2010-04-09  Eric Seidel  <eric@webkit.org>
1777
1778         Reviewed by Adam Barth.
1779
1780         webkit-patch attached my patch to the wrong bug
1781         https://bugs.webkit.org/show_bug.cgi?id=37015
1782
1783         The problem here is that SVN was violating SCM's implicit
1784         contract of always returning paths relative to the repository root.
1785         That can easily be fixed by telling SVN that the CWD is the repository root.
1786
1787         When fixing this I realized there are a large number of places in SCM.py where
1788         we want to consider explicitly passing self.checkout_root as the CWD.
1789         That would allow scm methods to be executed even when the CWD is not inside
1790         the scm tree at all, and would also make sure (in the case of SVN) that paths
1791         returned are relative to the root.  Git (almost always) returns paths relative
1792         to the repository root.
1793
1794         * Scripts/webkitpy/common/checkout/scm.py:
1795          - Explicitly pass self.checkout_root as cwd in run_status_and_extract_filenames
1796          - Add a ton of FIXMEs about the need to go back and decide which methods require cwd=self.checkout_root
1797            and which do not.  We'll probably add a helper function to scm (likely SCM._run) which
1798            always passes cwd=self.checkout_root to Executive.run_command
1799         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1800          - Add a test for this change.
1801         * Scripts/webkitpy/tool/commands/upload.py:
1802          - Removed the explicit os.chdir to the repository root, since scm.py methods
1803            should be robust against the cwd not being equal to the root.
1804
1805 2010-04-09  Adam Roben  <aroben@apple.com>
1806
1807         Don't return 0 as a JSValueRef
1808
1809         That is an illegal use of the JSC API.
1810
1811         Fixes <http://webkit.org/b/37333> REGRESSION (r57292): :visited tests
1812         are asserting on debug Windows and GTK builds
1813
1814         Reviewed by Anders Carlsson.
1815
1816         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1817         (LayoutTestController::computedStyleIncludingVisitedInfo):
1818         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1819         (LayoutTestController::computedStyleIncludingVisitedInfo):
1820         Return an "undefined" JSValueRef instead of 0.
1821
1822 2010-04-09  Csaba Osztrogonác  <ossy@webkit.org>
1823
1824         Reviewed by Eric Seidel.
1825
1826         Make DumpRenderTree parallelizable
1827         https://bugs.webkit.org/show_bug.cgi?id=36899
1828
1829         * DumpRenderTree/mac/DumpRenderTree.mm:
1830         (libraryPathForDumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.
1831         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1832         (WebCore::DumpRenderTree::DumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.
1833         * Scripts/run-webkit-tests:
1834           - Create a unique temporary directory and pass its path to
1835           DumpRenderTree with DUMPRENDERTREE_TEMP environment variable.
1836
1837 2010-04-09  Mark Rowe  <mrowe@apple.com>
1838
1839         Reviewed by Oliver Hunt.
1840
1841         <http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again
1842
1843         Add a script to detect the presence of inappropriate files in the frameworks.  At present
1844         it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources,
1845         as these are the only cases we've encountered recently.  It can be extended to check the
1846         other frameworks or for other inappropriate files in the future.
1847
1848         * Scripts/check-for-inappropriate-files-in-framework: Added.
1849
1850 2010-04-08  Sam Weinig  <sam@webkit.org>
1851
1852         Reviewed by Darin Adler.
1853
1854         Add option to build WebKit2 to build-webkit.
1855
1856         * Scripts/build-webkit:
1857
1858 2010-04-08  Darin Adler  <darin@apple.com>
1859
1860         Reviewed by Alexey Proskuryakov.
1861
1862         run-webkit-tests should respect argument order
1863         https://bugs.webkit.org/show_bug.cgi?id=37257
1864
1865         * Scripts/run-webkit-tests: Changed so that sorting is done only
1866         on the results of iterating directories. Test order is based on
1867         what's passed on the command line. Removed code that aimed to
1868         eliminate duplicates since it can be useful to run the same test
1869         more than once.
1870
1871 2010-04-07  David Hyatt  <hyatt@apple.com>
1872
1873         Reviewed by Oliver Hunt.
1874
1875         https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS.  Add a new method for
1876         obtaining computed style with :visited info included.  This allows layout tests to actually tell that
1877         :visited is in effect.
1878
1879         * DumpRenderTree/LayoutTestController.cpp:
1880         (computedStyleIncludingVisitedInfoCallback):
1881         (LayoutTestController::staticFunctions):
1882         * DumpRenderTree/LayoutTestController.h:
1883         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1884         (LayoutTestController::computedStyleIncludingVisitedInfo):
1885
1886 2010-04-07  Dirk Pranke  <dpranke@chromium.org>
1887
1888         Reviewed by Adam Barth.
1889
1890         Enable rebaseline-chromium-webkit-tests to run from a webkit-only
1891         checkout (i.e., you don't need anything from the Chromium tree checked
1892         out). This requires us to introduce the concept of a "target"
1893         port/platform that we use to get configuration information from as well
1894         as the "running" port that we use to make directories and diff images
1895         and the "rebaselining" port we use to actually manage baselines.
1896
1897         https://bugs.webkit.org/show_bug.cgi?id=37238
1898
1899         * Scripts/webkitpy/layout_tests/port/mac.py:
1900         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1901
1902 2010-04-05  Antonio Gomes  <tonikitoo@webkit.org>
1903
1904         Reviewed by Simon Hausmann.
1905
1906         [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
1907         https://bugs.webkit.org/show_bug.cgi?id=29431
1908
1909         Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method.
1910
1911         * DumpRenderTree/LayoutTestController.cpp:
1912         (setScrollbarPolicyCallback):
1913         (LayoutTestController::staticFunctions):
1914         * DumpRenderTree/LayoutTestController.h:
1915         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1916         (LayoutTestController::setScrollbarPolicy):
1917         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1918         (LayoutTestController::setScrollbarPolicy):
1919         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1920         (LayoutTestController::setScrollbarPolicy):
1921         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1922         (LayoutTestController::setScrollbarPolicy):
1923
1924 2010-04-01  Antonio Gomes  <tonikitoo@webkit.org>
1925
1926         Reviewed by David Hyatt.
1927
1928         [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
1929         https://bugs.webkit.org/show_bug.cgi?id=29431
1930
1931         Make possible to DRT to set scrollbar policies (on, off or auto).
1932
1933         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1934         (LayoutTestController::setScrollbarPolicy):
1935         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1936         * QtLauncher/main.cpp:
1937         (LauncherWindow::toggleScrollbars):
1938         (LauncherWindow::createChrome):
1939
1940 2010-04-08  Adam Barth  <abarth@webkit.org>
1941
1942         Reviewed by Eric Seidel.
1943
1944         new-run-webkit-tests should give a percent complete indication
1945         https://bugs.webkit.org/show_bug.cgi?id=37258
1946
1947         Because it's awesome.
1948
1949         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1950
1951 2010-04-08  Adam Barth  <abarth@webkit.org>
1952
1953         Unreviewed.
1954
1955         Add back the --target option because it's needed by the downstream
1956         Chromium bots.
1957
1958         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1959
1960 2010-04-08  Adam Barth  <abarth@webkit.org>
1961
1962         Reviewed by Eric Seidel.
1963
1964         new-run-webkit-tests should understand set-webkit-configuration
1965         https://bugs.webkit.org/show_bug.cgi?id=37252
1966
1967         * Scripts/webkitpy/layout_tests/port/base.py:
1968         * Scripts/webkitpy/layout_tests/port/mac.py:
1969         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1970
1971 2010-04-08  Adam Barth  <abarth@webkit.org>
1972
1973         Reviewed by Eric Seidel.
1974
1975         Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
1976         https://bugs.webkit.org/show_bug.cgi?id=37251
1977
1978         The rest of our tools call --debug or --release the configuration.
1979         It's confusing to call it target in this script.
1980
1981         * Scripts/webkitpy/layout_tests/driver_test.py:
1982         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1983         * Scripts/webkitpy/layout_tests/port/base.py:
1984         * Scripts/webkitpy/layout_tests/port/chromium.py:
1985         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1986         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1987         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1988         * Scripts/webkitpy/layout_tests/port/mac.py:
1989         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1990         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1991         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1992         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1993         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1994         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1995
1996 2010-04-07  Adam Barth  <abarth@webkit.org>
1997
1998         Reviewed by Eric Seidel.
1999
2000         Remove depricated op.popen2 call in new-run-webkit-tests
2001         https://bugs.webkit.org/show_bug.cgi?id=37249
2002
2003         Python complains that this API is depricated.  We already solved this
2004         problem in executive.py.
2005
2006         * Scripts/webkitpy/layout_tests/port/mac.py:
2007
2008 2010-04-07  Eric Seidel  <eric@webkit.org>
2009
2010         Reviewed by Adam Barth.
2011
2012         new-run-webkit-tests crashes when run on a 64-bit machine
2013         https://bugs.webkit.org/show_bug.cgi?id=37248
2014
2015         * Scripts/webkitpy/layout_tests/port/mac.py:
2016          - The code was trying to always run the 32-bit intel version
2017            of the DumpRenderTree binary.  DRT does not build 32-bit on 64-bit
2018            machines so that makes no sense.  This may have made sense for test_shell
2019            at some point, but I think we should just remove this for DRT.
2020
2021 2010-04-07  Eric Seidel  <eric@webkit.org>
2022
2023         Reviewed by Adam Barth.
2024
2025         WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
2026         https://bugs.webkit.org/show_bug.cgi?id=37104
2027
2028         Add warnings that the partial support for specifying what port numbers
2029         apache should bind to is even more broken after this fix.
2030
2031         * Scripts/run-webkit-httpd:
2032         * Scripts/run-webkit-tests:
2033
2034 2010-04-07  Shinichiro Hamaji  <hamaji@chromium.org>
2035
2036         Reviewed by Darin Adler.
2037
2038         LayoutTestController::m_handlesAuthenticationChallenges isn't initialized
2039         https://bugs.webkit.org/show_bug.cgi?id=37190
2040
2041         * DumpRenderTree/LayoutTestController.cpp:
2042         (LayoutTestController::LayoutTestController):
2043
2044 2010-03-31  Eric Seidel  <eric@webkit.org>
2045
2046         Reviewed by Adam Barth.
2047
2048         Add webkit-patch command to crawl buildbot history and find when tests
2049         started to fail.
2050         https://bugs.webkit.org/show_bug.cgi?id=36911
2051
2052         This is a very bare-bones implementation, which works, but isn't pretty.
2053         We will need further re-factoring and improvement to this code, but
2054         after long discussions with Adam, I think it's best that we land this
2055         and iterate from there.
2056
2057         * Scripts/webkitpy/common/net/buildbot.py:
2058          - Add revision_build_pairs_with_results for cleaner code and possible
2059            optimization of this command.
2060          - Return None if a build number can't be found for a revision in
2061            build_for_revision
2062          - Separate out suspect_revisions_for_transition for re-use by
2063            FailureReason
2064          - Add LayoutTestResults.failing_tests() and make our parsing code
2065            explict about what tables it accepts.
2066         * Scripts/webkitpy/tool/commands/queries.py:
2067          - Move _print_blame_information_for_commit out of WhatBroke for re-use
2068            by FailureReason.
2069          - Add FailureReason command which can crawl a given builder and explain
2070            why it is currently red on a per-test basis.
2071
2072 2010-04-06  Kent Tamura  <tkent@chromium.org>
2073
2074         Reviewed by Dimitri Glazkov.
2075
2076         [DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes
2077         https://bugs.webkit.org/show_bug.cgi?id=37137
2078
2079         - Add DumpRenderTree.gyp
2080         - Remove some dependencies to base/string_util.h,
2081           base/compiler_specific.h, base/file_path.h, base/file_util.h,
2082           base/message_loop.h, base/sys_string_conversions.h,
2083
2084         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added.
2085         * DumpRenderTree/chromium/CppVariant.cpp:
2086         (CppVariant::toStringVector):
2087         * DumpRenderTree/chromium/EventSender.cpp:
2088         (EventSender::EventSender):
2089         (EventSender::keyDown):
2090         (EventSender::scheduleAsynchronousClick):
2091         (EventSender::beginDragWithFiles):
2092         * DumpRenderTree/chromium/LayoutTestController.cpp:
2093         (LayoutTestController::setUserStyleSheetLocation):
2094         (LayoutTestController::pathToLocalResource):
2095         * DumpRenderTree/chromium/TextInputController.cpp:
2096         (TextInputController::markedRange):
2097         (TextInputController::selectedRange):
2098
2099 2010-04-06  Dirk Pranke  <dpranke@chromium.org>
2100
2101         Reviewed by Eric Seidel.
2102
2103         Write stack traces into the results directory for new-run-webkit-tests,
2104         instead of writing them alongside the test file.
2105
2106         https://bugs.webkit.org/show_bug.cgi?id=36504
2107
2108         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2109
2110 2010-04-06  Dirk Pranke  <dpranke@chromium.org>
2111
2112         Unreviewed build fix.
2113
2114         Enable pixel tests by default in new-run-webkit-tests unless
2115         explicitly set by the port or by the command line. This was broken in
2116         the fix for bug 36801 (rev. 57173).
2117
2118         https://bugs.webkit.org/show_bug.cgi?id=37184
2119
2120         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2121
2122 2010-04-06  Dirk Pranke  <dpranke@chromium.org>
2123
2124         Reviewed by Eric Seidel.
2125
2126         Disable pixel tests on the mac port by default.
2127
2128         Also, revamp the way we check for pixel tests being enabled or
2129         disabled. We now look for options.pixel_tests instead of
2130         options.no_pixel_tests, and we have the "--pixel-tests" (force enable)
2131         and "--no-pixel-tests" (force disable) flags.
2132
2133         https://bugs.webkit.org/show_bug.cgi?id=36801
2134
2135         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2136         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
2137         * Scripts/webkitpy/layout_tests/port/chromium.py:
2138         * Scripts/webkitpy/layout_tests/port/mac.py:
2139         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2140
2141 2010-04-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2142
2143         Reviewed by Laszlo Gombos.
2144
2145         [Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher
2146         https://bugs.webkit.org/show_bug.cgi?id=37159
2147
2148         * QtLauncher/useragentlist.txt:
2149
2150 2010-04-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2151
2152         Reviewed by Kenneth Rohde Christiansen.
2153
2154         [Qt] Add current user-agent string for Symbian for QtLauncher
2155         https://bugs.webkit.org/show_bug.cgi?id=37131
2156
2157         * QtLauncher/useragentlist.txt:
2158
2159 2010-04-06  Adam Barth  <abarth@webkit.org>
2160
2161         Reviewed by Eric Seidel.
2162
2163         Explain how to handle rollout patches
2164         https://bugs.webkit.org/show_bug.cgi?id=37139
2165
2166         We need to set expectations for how long landing rollout patches with
2167         the commit-queue takes.  The commit-queue is optimized for safety, not
2168         performance.  Also, give folks an alternative way to land patches
2169         quickly.
2170
2171         In addition, improve our testing of add_patch_to_bug by having
2172         MockBugzilla log.  This caused me to tighten a bunch of tests and
2173         notice that one of our tests wasn't being run.
2174
2175         * Scripts/webkitpy/tool/commands/download_unittest.py:
2176         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2177         * Scripts/webkitpy/tool/mocktool.py:
2178         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2179
2180 2010-04-06  Adam Barth  <abarth@webkit.org>
2181
2182         Reviewed by Eric Seidel.
2183
2184         Turns out commit_info.committer() can be None
2185         https://bugs.webkit.org/show_bug.cgi?id=37106
2186
2187         When the committer isn't in committers.py, the committer() property on
2188         commit_info can be None.  We need to handle that case gracefully.
2189
2190         * Scripts/webkitpy/common/checkout/commitinfo.py:
2191         * Scripts/webkitpy/tool/bot/sheriff.py:
2192         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2193         * Scripts/webkitpy/tool/commands/queries.py:
2194
2195 2010-04-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2196
2197         Reviewed by Kenneth Rohde Christiansen.
2198
2199         [Qt] [Symbian] Build fix for Dumprendertree if Qt printing is not supported
2200         https://bugs.webkit.org/show_bug.cgi?id=37082
2201
2202         Use the QT_NO_PRINTER guard to flag QPrinter dependent code.
2203
2204         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2205         (WebCore::DumpRenderTree::dryRunPrint):
2206
2207 2010-04-05  Adam Barth  <abarth@webkit.org>
2208
2209         Reviewed by Eric Seidel.
2210
2211         SheriffBot should force_build builders that are idle and have failed exactly once
2212         https://bugs.webkit.org/show_bug.cgi?id=37059
2213
2214         We can get into a deadlocked state where the commit-queue is stopped
2215         because the builders are red but the SheriffBot hasn't taken action
2216         because the builder has failed only once.  The SheriffBot should force
2217         build idle builders that have failed exactly once to either turn the
2218         tree green again (if the test was flaky) or trigger the "failed twice"
2219         remedies (IRC and bug posts).
2220
2221         * Scripts/webkitpy/common/net/buildbot.py:
2222         * Scripts/webkitpy/tool/bot/sheriff.py:
2223         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2224         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2225         * Scripts/webkitpy/tool/mocktool.py:
2226
2227 2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>
2228
2229         Reviewed by Shinichiro Hamaji.
2230
2231         Fixed check-webkit-style issue where the script was prematurely
2232         exiting when encountering deleted files in patches.
2233
2234         https://bugs.webkit.org/show_bug.cgi?id=37122
2235
2236         * Scripts/webkitpy/style/checker.py:
2237           - Changed non-existent file message from ERROR to WARN.
2238           - StyleChecker.check_file() no longer raises an exception when
2239             a file is not found.
2240
2241         * Scripts/webkitpy/style/checker_unittest.py:
2242           - Updated unit tests as necessary.
2243
2244 2010-04-05  Adam Barth  <abarth@webkit.org>
2245
2246         Reviewed by Eric Seidel.
2247
2248         SheriffBot should include blamelist when posting to bugs
2249         https://bugs.webkit.org/show_bug.cgi?id=37113
2250
2251         When posting on bugs, we should include the full list of SVN revisions
2252         that caused the regression to folks have a better sense of whether they
2253         are to blame.
2254
2255         * Scripts/webkitpy/tool/bot/sheriff.py:
2256         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2257         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2258         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2259         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2260         * Scripts/webkitpy/tool/mocktool.py:
2261
2262 2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>
2263
2264         Unreviewed after discussion with Adam, Darin, and Eric.
2265
2266         Deleted the auto-install directory since it is no longer needed in
2267         source control (it is auto-generated).
2268
2269         Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
2270         svn:ignore property.
2271
2272         * Scripts/webkitpy/thirdparty/autoinstalled: Removed.
2273
2274 2010-04-05  Mark Rowe  <mrowe@apple.com>
2275
2276         Reviewed by Adele Peterson.
2277
2278         Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
2279         REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
2280
2281         Add a JavaScript hook in DRT to call through to WebView's -setEditable:.  This is required in order to reproduce
2282         the crash.
2283
2284         * DumpRenderTree/LayoutTestController.cpp:
2285         (setWebViewEditableCallback):
2286         (LayoutTestController::staticFunctions):
2287         * DumpRenderTree/LayoutTestController.h:
2288         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2289         (LayoutTestController::setWebViewEditable):
2290         * DumpRenderTree/mac/DumpRenderTree.mm:
2291         (resetWebViewToConsistentStateBeforeTesting):
2292         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2293         (LayoutTestController::setWebViewEditable):
2294         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2295         (LayoutTestController::setWebViewEditable):
2296         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2297         (LayoutTestController::setWebViewEditable):
2298         (LayoutTestController::layerTreeAsText):
2299
2300 2010-04-05  Darin Adler  <darin@apple.com>
2301
2302         Ignore more files the Python tools strew about the working directory.
2303
2304         * Scripts/webkitpy: Added property svn:ignore.
2305         * Scripts/webkitpy/common: Added property svn:ignore.
2306         * Scripts/webkitpy/common/checkout: Added property svn:ignore.
2307         * Scripts/webkitpy/common/config: Added property svn:ignore.
2308         * Scripts/webkitpy/common/net: Added property svn:ignore.
2309         * Scripts/webkitpy/common/thread: Added property svn:ignore.
2310         * Scripts/webkitpy/python24: Added property svn:ignore.
2311         * Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
2312         * Scripts/webkitpy/tool/bot: Added property svn:ignore.
2313
2314 2010-04-05  Adam Barth  <abarth@webkit.org>
2315
2316         Unreviewed.  Add Vitaly Repeshko as a committer.
2317
2318         * Scripts/webkitpy/common/config/committers.py:
2319
2320 2010-04-05  Adam Barth  <abarth@webkit.org>
2321
2322         Unreviewed.  Update kenne's IRC nick to his registered nick.
2323
2324         * Scripts/webkitpy/common/config/committers.py:
2325
2326 2010-04-05  Ojan Vafai  <ojan@chromium.org>
2327
2328         Reviewed by Eric Seidel.
2329
2330         assorted helper functions and cleanup of git utilities
2331         https://bugs.webkit.org/show_bug.cgi?id=37103
2332
2333         * Scripts/webkitpy/common/checkout/scm.py:
2334         No code currently uses the optional dry_run argument. So removing it.
2335         Change all uses of "trunk" to read the correct value out of the git config.
2336         Made the dcommit call actually get called when dry_run==true.
2337         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2338         * Scripts/webkitpy/common/net/credentials.py:
2339         Move the git config call into scm.
2340         * Scripts/webkitpy/common/net/credentials_unittest.py:
2341         * Scripts/webkitpy/common/system/executive.py:
2342         If return_exit_code==true, don't error out, just return the exit_code.
2343
2344 2010-04-05  Ojan Vafai  <ojan@chromium.org>
2345
2346         Reviewed by Eric Seidel.
2347
2348         prepare-ChangeLog should take a merge-base for which git branch to diff against.
2349         https://bugs.webkit.org/show_bug.cgi?id=36394
2350
2351         * Scripts/prepare-ChangeLog:
2352
2353 2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>
2354
2355         Reviewed by Shinichiro Hamaji.
2356
2357         Removed the PatchStyleErrorHandler class and incorporated its
2358         functionality into the DefaultStyleErrorHandler class.
2359
2360         https://bugs.webkit.org/show_bug.cgi?id=37067
2361
2362         * Scripts/webkitpy/style/checker.py:
2363           - In the StyleChecker class:
2364             - Added a line_number parameter to the check_file() method.
2365             - Renamed the handle_style_error parameter to
2366               mock_handle_style_error to be consistent with the other mock_*
2367               parameter names.
2368             - Added a mock_check_file parameter to the check_patch() method
2369               to facilitate unit testing the changes in this patch.
2370             - Rewrote the check_patch() method with the patch-parsing logic
2371               taken from the PatchStyleErrorHandler class.
2372
2373         * Scripts/webkitpy/style/checker_unittest.py:
2374           - Added a StyleCheckerCheckFileBase class and sub-classed the
2375             existing StyleCheckerCheckFileTest class from it.
2376           - Added a StyleCheckerCheckPatchTest class to unit-test the
2377             rewritten check_patch() method.
2378           - Removed the vestigial __main__ code at the bottom of the file.
2379             This is left over from when check-webkit-style was implemented
2380             as a module and a wrapper module.
2381
2382         * Scripts/webkitpy/style/error_handlers.py:
2383           - Added an optional line_numbers parameter to the
2384             DefaultStyleErrorHandler class constructor and adjusted the
2385             __call__() method as necessary.
2386           - Removed the PatchStyleErrorHandler class.
2387
2388         * Scripts/webkitpy/style/error_handlers_unittest.py:
2389           - Removed the PatchStyleErrorHandlerTest class which unit-tested
2390             the PatchStyleErrorHandler class which is being removed in this
2391             patch.
2392           - Added a test_line_numbers() test method to the
2393             DefaultStyleErrorHandlerTest class to test use of the
2394             DefaultStyleErrorHandler's new line_numbers attribute.
2395
2396 2010-04-05  Adam Barth  <abarth@webkit.org>
2397
2398         Unreviewed.
2399
2400         Tighten SheriffBot's flaky test detector
2401         https://bugs.webkit.org/show_bug.cgi?id=37063
2402
2403         Instead of just looking for two sequential red builds, look for two
2404         sequential failures of the same test.  This should reduce sheriffbot
2405         false positive substantially.
2406
2407         I'm landing this change unreviewed because I've noticed SheriffBot
2408         triggering a lot more false positives now that we've expanded the set
2409         of core builders.  I've tried to take Eric's comments on Bug 37063 into
2410         account.  I'm happy to iterate on this patch tomorrow once Eric wakes
2411         up.
2412
2413         * Scripts/webkitpy/common/net/buildbot.py:
2414         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2415         * Scripts/webkitpy/tool/commands/queries.py:
2416
2417 2010-04-04  John Gregg  <johnnyg@google.com>
2418
2419         Unreviewed, add myself to the committers list.
2420
2421         * Scripts/webkitpy/common/config/committers.py:
2422
2423 2010-04-04  Robert Hogan  <robert@webkit.org>
2424
2425         Unreviewed, add myself to the committers list.
2426
2427         * Scripts/webkitpy/common/config/committers.py:
2428
2429 2010-04-04  Dumitru Daniliuc  <dumi@chromium.org>
2430
2431         Unreviewed, adding my IRC nickname to committers.py
2432
2433         * Scripts/webkitpy/common/config/committers.py:
2434
2435 2010-04-04  Chris Jerdonek  <cjerdonek@webkit.org>
2436
2437         Reviewed by Shinichiro Hamaji.
2438
2439         Refactored check-webkit-style's option-parsing code.
2440
2441         https://bugs.webkit.org/show_bug.cgi?id=37064
2442
2443         * Scripts/check-webkit-style:
2444           - Moved the "WebKit checkout not found" check from
2445             ArgumentParser.parse() to the calling code.
2446           - Moved the --git-commit argument validation from the calling
2447             code to ArgumentParser.parse().
2448
2449         * Scripts/webkitpy/style/checker_unittest.py:
2450           - Updated a unit test as necessary.
2451
2452         * Scripts/webkitpy/style/optparser.py:
2453           - Renamed ArgumentParser._exit_with_help() to _parse_error()
2454             and made its error_message parameter required.
2455           - Removed the found_checkout parameter from ArgumentParser.parse().
2456           - Removed the "WebKit checkout not found" check and moved it
2457             to the calling code.
2458           - Added --git-commit argument checking.
2459
2460         * Scripts/webkitpy/style/optparser_unittest.py:
2461           - Adjusted the import statements to be fully qualified.
2462           - Changed the ArgumentParserTest class to inherit from
2463             LoggingTestCase, and updated the class as necessary.
2464           - Added a unit-test for the --git-commit validation.
2465           - Added unit tests for the --git-diff and --git-since variants
2466             of --git-commit.
2467
2468 2010-04-03  Chris Jerdonek  <cjerdonek@webkit.org>
2469
2470         Reviewed by Shinichiro Hamaji.
2471
2472         The check-webkit-style script now logs an ERROR and exits when
2473         encountering a file path that does not exist.  Previously, it failed
2474         silently on such paths.
2475
2476         https://bugs.webkit.org/show_bug.cgi?id=36957
2477
2478         * Scripts/webkitpy/common/system/logtesting.py:
2479           - Added a FIXME to rename the LoggingTestCase class to
2480             LoggingTestCaseBase.
2481
2482         * Scripts/webkitpy/style/checker.py:
2483           - In the StyleChecker.check_file() method:
2484             - Added a mock_os_path_exists parameter.
2485             - Renamed the process_file parameter to mock_process_file.
2486             - Added logic to log an error and exist if the given path does
2487               not exist.
2488
2489         * Scripts/webkitpy/style/checker_unittest.py:
2490           - Refactored the StyleCheckerCheckFileTest class slightly to
2491             inherit from LoggingTestCase.
2492           - Added a test method to unit-test the case of a file that
2493             does not exist.
2494           - Adjusted the other test methods as necessary.
2495
2496 2010-04-03  Adam Barth  <abarth@webkit.org>
2497
2498         Reviewed by Eric Seidel.
2499
2500         Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
2501         https://bugs.webkit.org/show_bug.cgi?id=33289
2502
2503         Add Tiger and SnowLeopard Tests to the core builders.  This is a bit of
2504         an experiment now that the bots are green.  Hopefully we can keep them
2505         on the list and have the tree stay greener.
2506
2507         * Scripts/webkitpy/common/net/buildbot.py:
2508
2509 2010-04-02  Adam Barth  <abarth@webkit.org>
2510
2511         Unreviewed.
2512
2513         Have Eric and Adam watch the SheriffBot
2514         https://bugs.webkit.org/show_bug.cgi?id=37054
2515
2516         * Scripts/webkitpy/tool/bot/sheriff.py:
2517         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2518         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2519
2520 2010-04-02  Adam Barth  <abarth@webkit.org>
2521
2522         Reviewed by Darin Adler.
2523
2524         commit-queue should ignore builders when landing rollouts
2525         https://bugs.webkit.org/show_bug.cgi?id=37051
2526
2527         When we moved the "builders are red" check into the master process, we
2528         forgot about rollouts.  I thought we had a test covering this case, but
2529         looking at the test, it was a bit too loose.  I added a new test and
2530         introduced some new logging technology into MockTool to make the test
2531         tighter.
2532
2533         * Scripts/webkitpy/tool/commands/queues.py:
2534         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2535         * Scripts/webkitpy/tool/mocktool.py:
2536
2537 2010-04-02  David Levin  <levin@chromium.org>
2538
2539         Reviewed by Adam Barth.
2540
2541         sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
2542         https://bugs.webkit.org/show_bug.cgi?id=37030
2543
2544         * Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't
2545           start with -.
2546         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout
2547           reason which starts with -.
2548         * Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.
2549
2550 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
2551
2552         Unreviewed.
2553
2554         Fixed check-webkit-style to recognize the short form of the
2555         --verbose option, as stated in --help.
2556
2557         * Scripts/check-webkit-style:
2558           - Tweaked one line.
2559
2560 2010-04-02  Kevin Ollivier  <kevino@theolliviers.com>
2561
2562         [wx] Build fix for DumpRenderTree after addition of layerTreeAsText.
2563
2564         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2565         (LayoutTestController::layerTreeAsText):
2566
2567 2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2568
2569         Reviewed by Eric Seidel.
2570
2571         Accept XHTML-MP content type as XHTML content
2572         https://bugs.webkit.org/show_bug.cgi?id=34262
2573
2574         Register xhtmlmp file extension as the new type
2575         for XHTML-MP test content.
2576
2577         * Scripts/run-webkit-tests:
2578         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2579         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2580
2581 2010-04-02  Adam Barth  <abarth@webkit.org>
2582
2583         Reviewed by Eric Seidel.
2584
2585         create-rollout doesn't fill out ChangeLog
2586         https://bugs.webkit.org/show_bug.cgi?id=37010
2587
2588         The contract between apply_reverse_diff and PrepareChangeLogForRevert
2589         was unclear.  I broke filling out the ChangeLog during rollout earlier
2590         when I changed apply_reverse_diff to revert the ChangeLogs because
2591         PrepareChangeLogForRevert thought that it was supposed to do that.
2592         I've now taught PrepareChangeLogsForRevert the new contract.
2593
2594         It's unclear to me how to test this change because it's essentially an
2595         integration issue that requires the file system.  At some point we
2596         should think about a testing strategy for integration.  As the system
2597         becomes larger, we're running into more of these issues.
2598
2599         * Scripts/webkitpy/common/checkout/api.py:
2600         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2601
2602 2010-04-02  Adam Barth  <abarth@webkit.org>
2603
2604         Reviewed by Eric Seidel.
2605
2606         Add cr-win-ews to QueueStatusServer
2607         https://bugs.webkit.org/show_bug.cgi?id=37004
2608
2609         * QueueStatusServer/model/queues.py:
2610         * QueueStatusServer/templates/dashboard.html:
2611         * QueueStatusServer/templates/statusbubble.html:
2612
2613 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
2614
2615         Reviewed by Adam Barth.
2616
2617         Unit-test networktransaction.py's log messages, and add a base
2618         class to make unit-testing log messages even easier.
2619         
2620         https://bugs.webkit.org/show_bug.cgi?id=36958
2621
2622         The purpose of this patch is also to provide a mini-tutorial on
2623         how to unit-test Python logging.py messages.
2624
2625         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2626           - Unit-tested the log messages in test_retry().
2627
2628         * Scripts/webkitpy/common/system/logtesting.py:
2629           - Adjusted the LogTesting class by moving the code that clears
2630             the array of log messages into a finally block.  This prevents
2631             redundant AssertionErrors from getting rendered to the screen
2632             while running unit tests.
2633           - Added a LoggingTestCase class so the setUp() and tearDown()
2634             methods do not need to be implemented in order to test logging.
2635             Rather, TestCase classes can simply inherit from this class.
2636
2637 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
2638
2639         Reviewed by Shinichiro Hamaji.
2640
2641         Re-wrote check-webkit-style's argument parsing code to use
2642         Python's optparser module and more uniform error-handling logic.
2643
2644         https://bugs.webkit.org/show_bug.cgi?id=34676
2645
2646         * Scripts/webkitpy/style/optparser.py:
2647           - Removed "option help" from check-webkit-style's usage string
2648             since that is provided separately by the OptionParser class.
2649           - Also changed the usage string from a function to a constant
2650             string _USAGE.
2651           - Added an _EPILOG string which renders after OptionParser's
2652             usage string and option help.
2653           - In the ArgumentParser class:
2654             - Changed the constructor's stderr_write parameter to a
2655               mock_stderr since the OptionParser accepts a sys.stderr
2656               substitute rather than a sys.stderr.write substitute.
2657             - Changed the constructor to set a _parser data attribute with
2658               an OptionParser instance.
2659             - Added a _create_option_parser() method which instantiates
2660               the OptionParser.
2661             - Updated _exit_with_help() to interact with the OptionParser's
2662               help method.
2663             - Updated the parse() method as necessary.  Also changed the
2664               raising of ValueErrors to calls to _exit_with_help().
2665
2666         * Scripts/webkitpy/style/optparser_unittest.py:
2667           - Removed the CreateUsageTest class since the create_usage method
2668             was replaced by a constant string.
2669           - Added a _MockStdErr class to the ArgumentParserTest class.
2670           - Updated the unit tests as necessary.
2671
2672
2673 2010-04-02  Adam Barth  <abarth@webkit.org>
2674
2675         Reviewed by Eric Seidel.
2676
2677         The master commit-queue process should take responsibility for checking that the builders are green
2678         https://bugs.webkit.org/show_bug.cgi?id=37009
2679
2680         We had a failure where the child process noticed that the builders were
2681         red.  We've always had this race condition, but the new optimistic
2682         design made it easier to trigger.
2683
2684         * Scripts/webkitpy/tool/commands/queues.py:
2685
2686 2010-04-02  Adam Barth  <abarth@webkit.org>
2687
2688         Reviewed by Eric Seidel.
2689
2690         Tweak rollout changelog to pass ValidateReviewer check
2691         https://bugs.webkit.org/show_bug.cgi?id=37019
2692
2693         We need to use the magic word "unreviewed" to make the commit-queue
2694         happy when landing rollouts.
2695
2696         * Scripts/webkitpy/common/checkout/changelog.py:
2697         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2698
2699 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
2700
2701         Unreviewed.
2702
2703         Removed duplicate ChangeLog entry.
2704
2705 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
2706
2707         Rubber-stamped by Eric Seidel.
2708
2709         To the Python 2.4 error message, added a link to the wiki page
2710         that contains instructions on how to upgrade.
2711
2712         * Scripts/test-webkitpy:
2713           - Eliminated a use of the ternary operator in configure_logging()
2714             to let the version warning display in case of Python 2.4.
2715
2716         * Scripts/webkitpy/python24/versioning.py:
2717           - Added this link to the error text:
2718             http://trac.webkit.org/wiki/PythonGuidelines
2719
2720         * Scripts/webkitpy/python24/versioning_unittest.py:
2721           - Updated unit test text.
2722
2723 2010-04-02  Adam Barth  <abarth@webkit.org>
2724
2725         Reviewed by Eric Seidel.
2726
2727         Record the IRC nick of folks who request rollouts
2728         https://bugs.webkit.org/show_bug.cgi?id=36999
2729
2730         * Scripts/webkitpy/common/net/irc/ircbot.py:
2731         * Scripts/webkitpy/tool/bot/irc_command.py:
2732         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
2733         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2734
2735 2010-04-01  Adam Barth  <abarth@webkit.org>
2736
2737         Reviewed by Eric Seidel.
2738
2739         Add cr-win-ews
2740         https://bugs.webkit.org/show_bug.cgi?id=36974
2741
2742         Adds support for an Early Warning System for Chromium on Linux.  The
2743         interface to the Chromium port is the same on every platform, so we
2744         don't need to create a new Port object for this queue.
2745
2746         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2747         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2748
2749 2010-04-01  Adam Barth  <abarth@webkit.org>
2750
2751         Reviewed by Eric Seidel.
2752
2753         Using a failure exit code when failing to load a required import
2754         https://bugs.webkit.org/show_bug.cgi?id=37000
2755
2756         Well spotted by Mark Rowe.
2757
2758         * Scripts/webkitpy/common/system/user.py:
2759
2760 2010-04-01  Chris Jerdonek  <cjerdonek@webkit.org>
2761
2762         Reviewed by Eric Seidel.
2763
2764         Rewrote the revision (r56942) to disable the 79 character line
2765         length limit Python/PEP8 style check.
2766
2767         https://bugs.webkit.org/show_bug.cgi?id=33639#c39
2768
2769         This rewrite puts the disabling not in the PythonProcessor but
2770         in the calling code's default filter rule configuration.  This
2771         allows the user to check line-length style from the command-line
2772         if desired.
2773
2774         * Scripts/webkitpy/style/checker.py:
2775           - Added "-pep8/E501" to the _BASE_FILTER_RULES configuration
2776             variable to disable the line-length check.
2777           - Added "-pep8/E501" to the list of recognized style categories
2778             to permit the category to be checked from the command line.
2779
2780         * Scripts/webkitpy/style/processors/python.py:
2781           - Reverted r56942: http://trac.webkit.org/changeset/56942
2782
2783 2010-04-01  Kinuko Yasuda  <kinuko@chromium.org>
2784
2785         Reviewed by Dmitry Titov.
2786
2787         Add FileThread for async file operation support in FileReader and FileWriter
2788         https://bugs.webkit.org/show_bug.cgi?id=36896
2789
2790         Add options to enable FILE_READER and FILE_WRITER support.
2791
2792         * Scripts/build-webkit:
2793
2794 2010-04-01  Kent Tamura  <tkent@chromium.org>
2795
2796         Unreviewed. Add missing license header.
2797
2798         * DumpRenderTree/chromium/TestShellMac.mm:
2799
2800 2010-04-01  Adam Barth  <abarth@webkit.org>
2801
2802         Reviewed by Eric Seidel.
2803
2804         Improve the error handling in rollout a bit
2805         https://bugs.webkit.org/show_bug.cgi?id=36995
2806
2807         This patch does a few things to make the error handling in rollout a
2808         bit more robust.
2809
2810         * Scripts/webkitpy/common/checkout/api.py:
2811             The old logic here was wrong.  We don't want to resolve the
2812             ChangeLogs (that would remove the old ChangeLog entry).  Instead,
2813             we want to revert the ChangeLogs so we can fill them with the new
2814             message.
2815         * Scripts/webkitpy/tool/commands/download_unittest.py:
2816             Update test expectations because we're using a different mock object.
2817         * Scripts/webkitpy/tool/commands/download.py:
2818             - Added an update command to make updating from the SheriffBot more
2819               robust.
2820             - Now that we have CommitInfo, we can automatically CC the
2821               responsible parties on the bug we create.
2822             - Re-ordered the steps in create-rollout.  Our original thinking
2823               was that we always wanted to create the bug, but that's not
2824               really true given how things appear to be playing out.  If we
2825               fail to apply the reverse diff, we don't want to create the bug.
2826         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2827             - Use the new, more robust update command.
2828         * Scripts/webkitpy/tool/steps/createbug.py:
2829             Allow commands to pre-load who they want to be CCed on a new bug.
2830
2831 2010-04-01  Kent Tamura  <tkent@chromium.org>
2832
2833         Reviewed by Dimitri Glazkov.
2834
2835         [DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
2836         https://bugs.webkit.org/show_bug.cgi?id=36814
2837
2838         This change introduces:
2839         - WebViewHost class
2840           It's an implementation of some delegates required by Chromium
2841           WebKit API, and manages painting of a WebView. It's base on
2842           src/webkit/tools/test_shell/test_webview_delegate.{cc,h} of
2843           Chromium rev.40492.
2844         - TestShell class
2845           The TestShell instance holds global states of DumpRenderTree process.
2846           Unlike TestShell class of Chromium test_shell, TestShell instance is
2847           created just once.
2848         - DumpRenderTree.cpp
2849           The program entry.
2850
2851         * DumpRenderTree/chromium/DumpRenderTree.cpp: Added.
2852         * DumpRenderTree/chromium/TestShell.cpp: Added.
2853         * DumpRenderTree/chromium/TestShell.h: Added.
2854         * DumpRenderTree/chromium/TestShellMac.mm: Added.
2855         * DumpRenderTree/chromium/WebViewHost.cpp: Added.
2856         * DumpRenderTree/chromium/WebViewHost.h: Added.
2857         * DumpRenderTree/chromium/config.h: Added.
2858
2859 2010-04-01  David Levin  <levin@chromium.org>
2860
2861         Reviewed by Adam Barth.
2862
2863         sheriffbot rollout should verify that the svn revision is a number.
2864         https://bugs.webkit.org/show_bug.cgi?id=37001
2865
2866         * Scripts/webkitpy/common/net/bugzilla.py: Allow for the message to be None.
2867         * Scripts/webkitpy/tool/bot/sheriff.py: Did verification that svn revision
2868          is a number. Fixed the imports (since the files uses ScriptError and log)
2869          and a typo.
2870         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added a test to verify
2871          the behavior.
2872
2873 2010-04-01  Adam Barth  <abarth@webkit.org>
2874
2875         Reviewed by Eric Seidel.
2876
2877         Print an error message for readline bogosity in MacPorts
2878         https://bugs.webkit.org/show_bug.cgi?id=36979
2879
2880         * Scripts/webkitpy/common/system/user.py:
2881
2882 2010-04-01  Adam Barth  <abarth@webkit.org>
2883
2884         Reviewed by Eric Seidel.
2885
2886         Don't pass --non-interactive to create-rollout
2887         https://bugs.webkit.org/show_bug.cgi?id=36989
2888
2889         It turns out you can't pass --non-interactive to create-rollout.  Also,
2890         improve our error reporting slighly to catch the case where we error
2891         out after creating the rollout bug.
2892
2893         * Scripts/webkitpy/tool/bot/irc_command.py:
2894         * Scripts/webkitpy/tool/bot/sheriff.py:
2895
2896 2010-04-01  Ojan Vafai  <ojan@chromium.org>
2897
2898         Reviewed by Eric Seidel.
2899
2900         webkit-patch can incorrectly think the working directory is modified
2901         https://bugs.webkit.org/show_bug.cgi?id=36985
2902
2903         If a file's modification time is modified, but the contents are not,
2904         then diff-index will think the file has been modified unless you do
2905         some crazy update-index call. Instead, call diff --name-only, which
2906         has the index update builtin.
2907
2908         Tried to write a test, but could not reproduce this in a unittest.
2909         To test manually:
2910             touch file-in-repo
2911             git diff-index HEAD
2912             git diff HEAD --name-only
2913
2914         The diff-index call incorrectly shows file-in-repo as modified.
2915
2916         * Scripts/webkitpy/common/checkout/scm.py:
2917
2918 2010-04-01  Adam Barth  <abarth@webkit.org>
2919
2920         Reviewed by Eric Seidel.
2921
2922         Add rollout command to sheriffbot
2923         https://bugs.webkit.org/show_bug.cgi?id=36986
2924
2925         This IRC command creates a new bug an attaches a rollout patch.  To
2926         actually commit the rollout, a committer needs to mark the patch
2927         commit-queue+ in bugs.webkit.org.
2928
2929         Also, factored out some of the logic from the queue into a separate
2930         object for easier testing.
2931
2932         * Scripts/webkitpy/common/system/executive.py:
2933         * Scripts/webkitpy/tool/bot/irc_command.py:
2934         * Scripts/webkitpy/tool/bot/sheriff.py: Added.
2935         * Scripts/webkitpy/tool/bot/sheriff_unittest.py: Added.
2936         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
2937         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2938         * Scripts/webkitpy/tool/commands/queues.py:
2939         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2940         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2941
2942 2010-04-01  Eric Seidel  <eric@webkit.org>
2943
2944         Unreviewed, only ignoring chatty style errors.
2945
2946         check-webkit-style: WebKit needs a python style checker
2947         https://bugs.webkit.org/show_bug.cgi?id=33639
2948
2949         Remove the 79 char line limit by ignoring 
2950         pep8/E501.  Because we have our own report_error
2951         implementation we have to ignore E501 by hand
2952         instead of passing --ignore=E501.
2953
2954         Right now over 1400 lines of our existing python
2955         fail E501 so this rule just generates needless noise.
2956         The rest of WebKit has no wrapping rule so it makes
2957         little sense for our Python to differ here.
2958
2959         * Scripts/webkitpy/style/processors/python.py:
2960
2961 2010-04-01  Adam Barth  <abarth@webkit.org>
2962
2963         Unreviewed.  Add cmarrin's IRC nickname.
2964
2965         * Scripts/webkitpy/common/config/committers.py:
2966
2967 2010-04-01  Adam Barth  <abarth@webkit.org>
2968
2969         Unreviewed.
2970
2971         EWS spins hot when unable to build
2972         https://bugs.webkit.org/show_bug.cgi?id=36981
2973
2974         The problem is that the queue engine things we have more work to do,
2975         but the bot isn't actually able to do anything.  After this change, we
2976         back off the usual amount.
2977
2978         * Scripts/webkitpy/tool/bot/queueengine.py:
2979         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2980         * Scripts/webkitpy/tool/commands/queues.py:
2981         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2982
2983 2010-04-01  Chris Marrin  <cmarrin@apple.com>
2984
2985         Reviewed by Simon Fraser.
2986
2987         Added layerTreeAsText function to DRT (for Mac)
2988         https://bugs.webkit.org/show_bug.cgi?id=36782
2989
2990         This is the DRT side. It exposes the call to JavaScript
2991         through the LayoutTestController.
2992
2993         * DumpRenderTree/LayoutTestController.cpp:Platform independent JavaScript shim
2994         (layerTreeAsTextCallback):
2995         (LayoutTestController::staticFunctions):
2996         * DumpRenderTree/LayoutTestController.h:
2997         * DumpRenderTree/mac/LayoutTestControllerMac.mm:Mac specific plumbing to WebKit
2998         (LayoutTestController::layerTreeAsText):
2999         * DumpRenderTree/win/LayoutTestControllerWin.cpp:Windows specific plumbing to WebKit
3000         (LayoutTestController::layerTreeAsText):
3001
3002 2010-04-01  Kevin Ollivier  <kevino@theolliviers.com>
3003
3004         [wx] Build fix after addition of JavaScriptCore/wtf/text directory.
3005
3006         * wx/build/settings.py:
3007
3008 2010-04-01  Jian Li  <jianli@chromium.org>
3009
3010         Rubber-stamped by David Levin.
3011
3012         Add myself to the reviewers list.
3013
3014         * Scripts/webkitpy/common/config/committers.py:
3015
3016 2010-04-01  Adam Barth  <abarth@webkit.org>
3017
3018         Unreviewed.
3019
3020         Turns out the Chromium Windows bots don't have pdevenv installed.
3021
3022         * Scripts/webkitdirs.pm:
3023
3024 2010-04-01  Adam Barth  <abarth@webkit.org>
3025
3026         Reviewed by Dimitri Glazkov.
3027
3028         Let Chromium Windows build with Visual Studio Express
3029         https://bugs.webkit.org/show_bug.cgi?id=36919
3030
3031         This is horrible, horrible copy/paste code, but that seems to be the
3032         way of webkitdirs.pm.  :(
3033
3034         Someone needs to go through an cleanup this code, but I don't have the
3035         heart to do it in this patch.
3036
3037         * Scripts/webkitdirs.pm:
3038
3039 2010-04-01  Ilya Tikhonovsky  <loislo@chromium.org>
3040
3041         Reviewed by Yury Semikhatsky.
3042
3043         Add myself to the committers list.
3044         https://bugs.webkit.org/show_bug.cgi?id=36953
3045
3046         * Scripts/webkitpy/common/config/committers.py:
3047
3048 2010-04-01  Eric Seidel  <eric@webkit.org>
3049
3050         Rubber-stamped by Adam Barth.
3051
3052         Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red)
3053         https://bugs.webkit.org/show_bug.cgi?id=33292
3054
3055         Just adding the "Build" builder for now.
3056         We'll add the "Test" builders when the tests
3057         are less flaky.
3058
3059         * Scripts/webkitpy/common/net/buildbot.py:
3060         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3061
3062 2010-04-01  Yury Semikhatsky  <yurys@chromium.org>
3063
3064         Reviewed by David Levin.
3065
3066         Add myself to the reviewers list.
3067
3068         https://bugs.webkit.org/show_bug.cgi?id=36935
3069
3070         * Scripts/webkitpy/common/config/committers.py:
3071
3072 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
3073
3074         Reviewed by Dave Levin.
3075
3076         Added Python style checking to check-webkit-style using
3077         the third-party pep8 module (via autoinstall).
3078
3079         https://bugs.webkit.org/show_bug.cgi?id=33639
3080
3081         * Scripts/webkitpy/style/checker.py:
3082           - Added PYTHON to FileType.
3083           - Updated ProcessorDispatcher to return a PythonProcessor
3084             for *.py files.
3085
3086         * Scripts/webkitpy/style/checker_unittest.py:
3087           - Updated the ProcessorDispatcher unit tests for *.py files.
3088
3089         * Scripts/webkitpy/style/processors/python.py: Added.
3090           - Added PythonProcessor class.
3091
3092         * Scripts/webkitpy/style/processors/python_unittest.py: Added.
3093           - Added PythonProcessor unit tests.
3094
3095         * Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
3096           - Added a sample Python file to test the PythonProcessor.process()
3097             code path (since pep8 accepts a file path).
3098
3099         * Scripts/webkitpy/style/unittests.py:
3100           - Updated the style unit test file to import python_unittest.py.
3101
3102         * Scripts/webkitpy/style_references.py:
3103           - Adjusted style references to import pep8.
3104
3105 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
3106
3107         Reviewed by Dave Levin.
3108
3109         Rewrote autoinstall.py to support unzipping *.zip files after
3110         download, unzipping and extracting *.tar.gz files after download,
3111         and copying installed files to a given destination directory.
3112
3113         https://bugs.webkit.org/show_bug.cgi?id=35163
3114
3115         These changes will let us autoinstall pep8.py from the web and put
3116         our third-party autoinstalled code in an explicit directory like
3117         webkitpy/thirdparty/autoinstalled. These changes should also speed
3118         up the execution of autoinstalled *.zip packages slightly since
3119         *.pyc files cannot be generated when importing from zipped
3120         packages using the current autoinstall.
3121
3122         * Scripts/test-webkitpy:
3123           - Addressed the FIXME to enable auto-install logging once
3124             autoinstall was rewritten not to log as verbosely.
3125
3126         * Scripts/webkitpy/common/net/bugzilla.py:
3127           - Updated mechanize import statement.
3128
3129         * Scripts/webkitpy/common/net/buildbot.py:
3130           - Updated mechanize import statement.
3131
3132         * Scripts/webkitpy/common/net/irc/ircbot.py:
3133           - Updated ircbot and irclib import statements.
3134
3135         * Scripts/webkitpy/common/net/networktransaction.py:
3136           - Updated mechanize import statement.
3137
3138         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3139           - Updated mechanize import statement.
3140
3141         * Scripts/webkitpy/common/net/statusserver.py:
3142           - Updated mechanize import statement.
3143
3144         * Scripts/webkitpy/common/system/autoinstall.py: Added.
3145           - Added AutoInstaller class.
3146           - Added sample/testing usage to the __main__ block.
3147
3148         * Scripts/webkitpy/thirdparty/__init__.py:
3149           - Updated the autoinstall lines to use the new autoinstall methods.
3150           - Added pep8.py to the list of auto-installed packages.
3151           - Added a README file to the target autoinstallation directory
3152             so users know that the directory is safe to delete.
3153
3154         * Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
3155           - This is replaced by the rewritten autoinstall
3156             webkitpy/common/system/autoinstall.py.
3157
3158         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Removed.
3159           - The target autoinstallation directory is now auto-generated.
3160
3161 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
3162
3163         Reviewed by Shinichiro Hamaji.
3164
3165         Tweak webkitpy's logtesting.LogTesting class to get more mileage out
3166         of our unit tests that test log messages.
3167
3168         https://bugs.webkit.org/show_bug.cgi?id=36886
3169
3170         This patch adds to the LogTesting class's tearDown() method a line
3171         asserting that the array of remaining log messages is empty.  This
3172         ensures that no extra log messages are getting logged that the caller
3173         might not be aware of or may have forgotten to check for.
3174
3175         * Scripts/webkitpy/common/system/logtesting.py:
3176           - Modified the tearDown() method as described above.
3177           - Also modified the assertMessages() method to clear the array
3178             of log messages after asserting.
3179
3180 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
3181
3182         Reviewed by Adam Barth.
3183
3184         Added support for a --verbose-logging flag to test-webkitpy.
3185
3186         https://bugs.webkit.org/show_bug.cgi?id=36429
3187
3188         Verbose logging is useful for debugging test-webkitpy code that
3189         runs before the actual unit tests -- things like autoinstalling and
3190         unit-test auto-detection logic.  This is different from verbose
3191         logging of the unit tests themselves (which corresponds to the
3192         unittest module's --verbose flag).
3193
3194         * Scripts/test-webkitpy:
3195           - In the configure_logging() method--
3196             - Added an is_verbose_logging parameter that sets the logging
3197               level to logging.DEBUG instead of logging.INFO.
3198             - Changed the method to throttle the logging level on the
3199               root logger's handler instead of directly on the root logger
3200               itself.
3201             - Enabled logging of the autoinstall module when the flag is set.
3202
3203         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
3204           - Added a work-around for a bug in Python 2.6's logging module
3205             that was discovered while working on this patch.
3206
3207 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
3208
3209         Reviewed by Adam Barth.
3210
3211         Enabled Python's logging module for webkit-patch, and replaced
3212         deprecated_logging with Python logging in networktransaction.py.
3213         This eliminates some spurious output when running test-webkitpy.
3214
3215         https://bugs.webkit.org/show_bug.cgi?id=36725
3216
3217         * Scripts/webkit-patch:
3218           - Replaced the configure_logging() function with a call to
3219             the new logutils.configure_logging() function.
3220
3221         * Scripts/webkitpy/common/net/networktransaction.py:
3222           - Replaced the use of deprecated_logging with Python logging.
3223
3224         * Scripts/webkitpy/common/system/logutils.py:
3225           - Added _default_handlers() which creates the default logging
3226             handler for webkitpy.
3227           - Added configure_logging() which configures default logging
3228             for webkitpy.
3229
3230         * Scripts/webkitpy/common/system/logutils_unittest.py:
3231           - Added unit tests for logutils.configure_logging().
3232
3233         * Scripts/webkitpy/style/checker.py:
3234           - Refactored check-webkit-style's configure_logging() method
3235             to call the new logutils.configure_logging().
3236
3237         * Scripts/webkitpy/style_references.py:
3238           - Updated references as necessary.
3239
3240 2010-03-31  Eric Seidel  <eric@webkit.org>
3241
3242         Reviewed by Adam Barth.
3243
3244         webkit-patch land fails if not run from the root directory
3245         https://bugs.webkit.org/show_bug.cgi?id=35822
3246
3247         The root of the problem was that ChangeLog.__init__ expects a path
3248         relative to the current working directory, and SCM expects to
3249         return paths relative to the SCM root.  Fix it by converting from
3250         SCM-relative to absolute paths in Checkout.modified_changelogs
3251
3252         * Scripts/webkitpy/common/checkout/api.py:
3253         * Scripts/webkitpy/common/checkout/api_unittest.py:
3254
3255 2010-03-31  Adam Barth  <abarth@webkit.org>
3256
3257         Reviewed by Eric Seidel.
3258
3259         Add more tests for webkitpy.common.checkout
3260         https://bugs.webkit.org/show_bug.cgi?id=36926
3261
3262         We don't have a great way of testing checkout, sadly.
3263
3264         * Scripts/webkitpy/common/checkout/api_unittest.py:
3265
3266 2010-03-31  Adam Barth  <abarth@webkit.org>
3267
3268         Reviewed by Eric Seidel.
3269
3270         REGRESSION: EWS crashes on failure
3271         https://bugs.webkit.org/show_bug.cgi?id=36924
3272
3273         Turns out we need to pass one more argument.  My test is kind of lame,
3274         but at least it's there.
3275
3276         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3277         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3278
3279 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
3280
3281         Unreviewed.
3282
3283         Fixed typo in WebKitTools/ChangeLog: opsys -> ospath.
3284
3285 2010-03-31  Adam Barth  <abarth@webkit.org>
3286
3287         Reviewed by Eric Seidel.
3288
3289         Make the EWS go faster by being optimistic
3290         https://bugs.webkit.org/show_bug.cgi?id=36916
3291
3292         Have the EWS be optimistic that a patch will correctly build.  This
3293         should speed up the common case by not requiring two builds for every
3294         patch.
3295
3296         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3297         * Scripts/webkitpy/tool/commands/queues.py:
3298
3299 2010-03-31  Adam Barth  <abarth@webkit.org>
3300
3301         Reviewed by Eric Seidel.
3302
3303         Add the ability to restart sheriffbot from IRC
3304         https://bugs.webkit.org/show_bug.cgi?id=36909
3305
3306         * Scripts/webkitpy/tool/bot/irc_command.py:
3307         * Scripts/webkitpy/tool/bot/queueengine.py:
3308         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3309         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3310
3311 2010-03-31  Adam Barth  <abarth@webkit.org>
3312
3313         Reviewed by Eric Seidel.
3314
3315         Add win-ews to QueueStatusServer
3316         https://bugs.webkit.org/show_bug.cgi?id=36876
3317
3318         The win-ews is still experimental, but it seems to be more or less
3319         running.  We should show its results to the people.
3320
3321         * QueueStatusServer/model/queues.py:
3322         * QueueStatusServer/templates/dashboard.html:
3323         * QueueStatusServer/templates/statusbubble.html:
3324
3325 2010-03-30  Victor Wang  <victorw@chromium.org>
3326
3327         Reviewed by Eric Seidel.
3328
3329         Update rebaseline tool to check the release image diff binary and
3330         fallback to debug if the release version does not exist.
3331
3332         https://bugs.webkit.org/show_bug.cgi?id=36245
3333
3334         * Scripts/webkitpy/layout_tests/port/base.py:
3335         * Scripts/webkitpy/layout_tests/port/chromium.py:
3336         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3337
3338 2010-03-31  Eric Seidel  <eric@webkit.org>
3339
3340         Reviewed by Adam Barth.
3341
3342         Teach buildbot.py how to parse builder activity from /one_box_per_builder
3343         https://bugs.webkit.org/show_bug.cgi?id=36898
3344
3345         I also removed some obsolete FIXMEs and
3346         refactored one_box_per_builder parsing into multiple
3347         methods for easier reading.
3348
3349         * Scripts/webkitpy/common/net/buildbot.py:
3350         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3351
3352 2010-03-31  Dirk Pranke  <dpranke@chromium.org>
3353
3354         Reviewed by Eric Seidel.
3355
3356         Fix logging in new-run-webkit-tests so that we don't report IMAGE
3357         expected failures as unexpected passes when we run with pixel tests
3358         disabled.
3359
3360         This change splits some of the logic embedded into the TestExpectations
3361         classes out into separate pure functions (result_was_expected,
3362         remove_image_failures) to make them easier to test. This also adds
3363         a parameter to matches_an_expected_result() to indicate whether or
3364         not pixel test results should be included in the expectations.
3365
3366         https://bugs.webkit.org/show_bug.cgi?id=36771
3367
3368         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3369         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
3370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3371
3372 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
3373
3374         Reviewed by Eric Seidel.
3375
3376         In webkitpy, refactored two calls to os.path.relpath() replacements
3377         to use a common method.
3378
3379         https://bugs.webkit.org/show_bug.cgi?id=36891
3380
3381         * Scripts/webkitpy/common/net/bugzilla.py:
3382           - Replaced the relpath implementation with a call to
3383             webkitpy.common.system.ospath.relpath().
3384
3385         * Scripts/webkitpy/common/system/ospath.py: Added.
3386           - Moved the relpath() implementation from style/main.py.
3387
3388         * Scripts/webkitpy/common/system/ospath_unittest.py: Added.
3389           - Moved the relpath() unit tests from style/main_unittest.py.
3390
3391         * Scripts/webkitpy/style/main.py:
3392           - Replaced the relpath implementation with a call to
3393             webkitpy.common.system.ospath.relpath().
3394
3395         * Scripts/webkitpy/style/main_unittest.py:
3396           - Moved the relpath unit tests to ospath_unittest.py.
3397
3398 2010-03-31  Adam Barth  <abarth@webkit.org>
3399
3400         Reviewed by Eric Seidel.
3401
3402         Add a Builder.force_build method
3403         https://bugs.webkit.org/show_bug.cgi?id=36875
3404
3405         We plan to eventually use this in SheriffBot to break deadlocks created
3406         by flaky tests.
3407
3408         * Scripts/webkitpy/common/net/buildbot.py:
3409
3410 2010-03-31  Adam Barth  <abarth@webkit.org>
3411
3412         Reviewed by Eric Seidel.
3413
3414         webkit-patch reads wrong bug url from unified diff context
3415         https://bugs.webkit.org/show_bug.cgi?id=36477
3416
3417         Instead of trying to figure out the bug_id from the diff, we should
3418         just get the information from the Checkout object, which understands
3419         these concepts.
3420
3421         * Scripts/webkitpy/common/checkout/api.py:
3422         * Scripts/webkitpy/common/checkout/commitinfo.py:
3423         * Scripts/webkitpy/tool/commands/download.py:
3424         * Scripts/webkitpy/tool/commands/upload.py:
3425         * Scripts/webkitpy/tool/mocktool.py:
3426
3427 2010-03-31  Adam Barth  <abarth@webkit.org>
3428
3429         Reviewed by Eric Seidel.
3430
3431         webkit-patch commit-queue should land patches optimistically
3432         https://bugs.webkit.org/show_bug.cgi?id=34187
3433
3434         This patch adds an optimistic path to commit-queue and a "fail twice"
3435         requirement for rejecting patches.  That means we'll land good patches
3436         faster (via the optmistic first run) and we'll reject many fewer
3437         patches due to flaky tests.
3438
3439         * Scripts/webkitpy/tool/commands/queues.py:
3440
3441 2010-03-31  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3442
3443         Reviewed by Kenneth Rohde Christiansen.
3444
3445         [Qt] Custom user agent for user agent switcher
3446         https://bugs.webkit.org/show_bug.cgi?id=36757
3447
3448         * QtLauncher/main.cpp:
3449         (LauncherWindow::showUserAgentDialog):
3450
3451 2010-03-31  Eric Seidel  <eric@webkit.org>
3452
3453         Reviewed by Adam Barth.
3454
3455         path to committers.py in commit-queue rejection message is wrong
3456         https://bugs.webkit.org/show_bug.cgi?id=36865
3457
3458         This fix would have only been 3 lines long if we had
3459         1. Had access to an SCM object or tool to give us the checkout root
3460         2. Been able to depend on Python 2.6
3461         Instead I've added a bunch of hack code, but at least now
3462         we should never have to update this string again as the location
3463         of committers.py is fully dynamically discovered. :p
3464
3465         * Scripts/webkitpy/common/net/bugzilla.py:
3466         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3467
3468 2010-03-31  Shinichiro Hamaji  <hamaji@chromium.org>
3469
3470         Unreviewed test fix for r56809.
3471
3472         webkit-patch what-broke throws exception
3473         https://bugs.webkit.org/show_bug.cgi?id=36852
3474
3475         * Scripts/webkitpy/common/checkout/api_unittest.py:
3476
3477 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
3478
3479         Rubber stamped by Dave Levin.
3480
3481         Made check-webkit-style less chatty.
3482
3483         Examples include:
3484          - https://bugs.webkit.org/show_bug.cgi?id=36866#c4
3485          - https://bugs.webkit.org/show_bug.cgi?id=36472#c9
3486
3487         * Scripts/webkitpy/style/checker.py:
3488           - Changed unrecognized file type log message from info to debug.
3489
3490 2010-03-30  Kevin Ollivier  <kevino@theolliviers.com>
3491
3492         [wx] Build fix after new method added.
3493
3494         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3495         (LayoutTestController::callShouldCloseOnWebView):
3496
3497 2010-03-30  Eric Seidel  <eric@webkit.org>
3498
3499         Reviewed by Adam Barth.
3500
3501         webkit-patch what-broke throws exception
3502         https://bugs.webkit.org/show_bug.cgi?id=36852
3503
3504         * Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO.
3505         * Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception.
3506
3507 2010-03-30  Alexey Proskuryakov  <ap@apple.com>
3508
3509         Reviewed by Darin Adler.
3510
3511         https://bugs.webkit.org/show_bug.cgi?id=36616
3512         Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown
3513
3514         https://bugs.webkit.org/show_bug.cgi?id=36797
3515         For non-Roman layouts, keydown Event.keyCode is always 0
3516
3517         * DumpRenderTree/mac/EventSendingController.mm:
3518         (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode
3519         for keys used in tests (we used to always pass 0 for 'A').
3520
3521 2010-03-30  Adam Barth  <abarth@webkit.org>
3522
3523         Reviewed by Eric Seidel.
3524
3525         Implement win-ews
3526         https://bugs.webkit.org/show_bug.cgi?id=36809
3527
3528         * Scripts/webkitpy/common/config/ports.py:
3529         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3530
3531 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
3532
3533         Reviewed by Eric Seidel.
3534
3535         Adjusted test-webkitpy to delete all orphaned *.pyc files
3536         from webkitpy/ prior to importing any modules from webkitpy.
3537         This ensures that no import statements in webkitpy falsely
3538         succeed because of leftover *.pyc files.
3539
3540         https://bugs.webkit.org/show_bug.cgi?id=36599
3541
3542         * Scripts/test-webkitpy:
3543           - Added _clean_pyc_files() to delete orphaned *.pyc files
3544             from a directory.
3545           - Added _clean_webkitpy_with_test() to call and test
3546             _clean_pyc_files().
3547           - Moved the "import webkitpy.python24.versioning" statement
3548             from the top of the module to the init() method -- immediately
3549             after the call to _clean_webkitpy_with_test().
3550
3551 2010-03-30  Fumitoshi Ukai  <ukai@chromium.org>
3552
3553         Reviewed by Shinichiro Hamaji.
3554
3555         [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
3556         https://bugs.webkit.org/show_bug.cgi?id=36811
3557
3558         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
3559         We don't need stdin, so use devnull as stdin.
3560         Same as https://bugs.webkit.org/show_bug.cgi?id=36586
3561
3562         * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
3563
3564 2010-03-29  Eric Seidel  <eric@webkit.org>
3565
3566         Unreviewed, build fix only.
3567
3568         * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
3569
3570 2010-03-29  Hayato Ito  <hayato@chromium.org>
3571
3572         Reviewed by Shinichiro Hamaji.
3573
3574         Remove '_flymake' suffix from base part of file name so that
3575         check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.
3576
3577         https://bugs.webkit.org/show_bug.cgi?id=36573
3578
3579         * Scripts/webkitpy/style/processors/cpp.py:
3580         * Scripts/webkitpy/style/processors/cpp_unittest.py:
3581
3582 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
3583
3584         Reviewed by Eric Seidel.
3585
3586         Get the following test-webkitpy unit test working again:
3587         scm_unittest.SVNTest.test_svn_apply().
3588
3589         https://bugs.webkit.org/show_bug.cgi?id=36696
3590
3591         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3592           - Add leading spaces to the empty lines of the ChangeLog strings.
3593           - Manually set the _reviewer attribute on the Attachment object
3594             to get the tests to pass.
3595
3596 2010-03-29  Martin Robinson  <mrobinson@webkit.org>
3597
3598         Reviewed by Holger Freyther.
3599
3600         [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
3601         https://bugs.webkit.org/show_bug.cgi?id=36390
3602
3603         Suppress debugging messages sent to the GLib logger during DRT runs.
3604
3605         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3606         (logHandler): Added.
3607         (main): Use logHandler as the default GLib log message handler.
3608
3609 2010-03-29  Eric Seidel  <eric@webkit.org>
3610
3611         Reviewed by Adam Barth.
3612
3613         sheriff-bot should comment on bugs when builders break
3614         https://bugs.webkit.org/show_bug.cgi?id=36786
3615
3616         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3617          - Add a new _post_blame_comment_to_bug and all it from process_work_item
3618          - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
3619         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3620          - Test the new _post_blame_comment_to_bug call
3621
3622 2010-03-29  Eric Seidel  <eric@webkit.org>
3623
3624         Reviewed by Adam Barth.
3625
3626         sheriff-bot fails to get information about certain builds
3627         https://bugs.webkit.org/show_bug.cgi?id=36768
3628
3629         This seems to be caused by:
3630         http://buildbot.net/trac/ticket/753
3631         I have no work-around, but for now at least we're logging
3632         the error better.  I also added allow_none to our ServerProxy
3633         creation in case that fixes things for other versions of python.
3634
3635         * Scripts/webkitpy/common/net/buildbot.py:
3636
3637 2010-03-29  Victor Wang  <victorw@chromium.org>
3638
3639         Reviewed by Adam Barth.
3640
3641         Add sign in/out link to TestResults appengine
3642
3643         Add a link to main menu for sign in/out to this appengine.
3644         People signed in with admin privilege could perform
3645         actions that are only allowed to admins like deleting files.
3646
3647         https://bugs.webkit.org/show_bug.cgi?id=36767
3648
3649         * TestResultServer/handlers/menu.py:
3650         * TestResultServer/stylesheets/menu.css:
3651         (.sign):
3652         * TestResultServer/templates/menu.html:
3653
3654 2010-03-29  Eric Seidel  <eric@webkit.org>
3655
3656         Reviewed by Adam Barth.
3657
3658         ValidateReviewer step is draconian and un-tested
3659         https://bugs.webkit.org/show_bug.cgi?id=36792
3660
3661<