2008-03-04 Alp Toker <alp@atoker.com>
[WebKit.git] / WebKitTools / ChangeLog
1 2008-03-04  Alp Toker  <alp@atoker.com>
2
3         Reviewed by Mark Rowe.
4
5         Switch the default GTK+ build system from qmake to autotools.
6
7         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
8
9         * Scripts/build-webkit:
10         * Scripts/run-launcher:
11         * Scripts/run-webkit-tests:
12         * Scripts/webkitdirs.pm:
13
14 2008-03-04  Sam Weinig  <sam@webkit.org>
15
16         Reviewed by Darin Adler.
17
18         * Scripts/do-webcore-rename: Update renaming plan.
19
20 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
21
22         Reviewed by Alp Toker.
23
24         Remove some needless LIBS.
25
26         * GNUmakefile.am:
27
28 2008-03-02  Alp Toker  <alp@atoker.com>
29
30         Reviewed by Mark Rowe.
31
32         Split the WebKit GTK+ build out of the WebCore build and change the
33         shared object name to match the package name.
34
35         * GNUmakefile.am:
36
37 2008-03-01  Mark Rowe  <mrowe@apple.com>
38
39         Reviewed by Tim Hatcher.
40
41         Update Xcode configuration to support building debug and release from the mysterious future.
42
43         * DumpRenderTree/mac/Configurations/Base.xcconfig:
44
45 2008-02-29  David Kilzer  <ddkilzer@apple.com>
46
47         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
48
49         Reviewed by Dan.
50
51         Originally broken in r26838.
52
53         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
54         not local, unused @args variable.
55
56 2008-02-29  David Kilzer  <ddkilzer@apple.com>
57
58         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
59
60         <http://bugs.webkit.org/show_bug.cgi?id=15754>
61
62         Reviewed by Geoff and Darin.
63
64         We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
65         then removing that path from all file:/// URLs in the WebArchive output so these tests
66         would pass no matter where they were run.
67
68         The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
69         current working directory, but the WebArchive does not.  This left the current working
70         directory in all file:/// URLs in the test output, and thus all tests failed, for any
71         developer that used symlinks to get to their WebKit source directory.
72
73         The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
74         remove the current working directory path (no matter what it is) after "file://" but
75         before "/LayoutTests/".  
76
77         * DumpRenderTree/mac/DumpRenderTree.mm:
78         (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
79         current working directory as described above.
80         (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
81         calls to normalizeWebResourceURL().
82         (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
83         normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
84
85 2008-02-26  Robin Dunn <robin@alldunn.com>
86
87         Reviewed by Kevin Ollivier.
88
89         Improvements to the wx build script.
90
91         http://bugs.webkit.org/show_bug.cgi?id=17492
92
93         * wx/build-wxwebkit:
94         - Update the Windows dll copying logic to copy dlls inside WebKitLibraries/win
95         - Allow the build script to properly find wxPython includes under different setups
96         - Make sure WX_PREFIX is set to WXWIN (wxWindows dir environment var.) if not defined
97
98 2008-02-26  Timothy Hatcher  <timothy@apple.com>
99
100         Reviewed by Darin Adler.
101
102         * Scripts/build-webkit: Add --universal and --64-bit flags to make building
103         64-bit architectures easy. Combine the two flags to build 4-way universal.
104         * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
105         non-zero when the build failes.
106
107 2008-02-26  Jessica Kahn  <jess@apple.com>
108
109         Reviewed by Darin.
110
111         * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
112         so that Safari inherits it when launched. Preexisting code in WebKit checks this
113         environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
114         launched by Safari continue to use the standard system WebKit.
115
116 2008-02-25  Adam Roben  <aroben@apple.com>
117
118         Fix run-webkit-tests after r30394
119
120         * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
121         executable name.
122
123 2008-02-24  Darin Adler  <darin@apple.com>
124
125         * Scripts/do-webcore-rename: Make some updates based on a trial run of
126         the renaming script.
127
128 2008-02-24  Darin Adler  <darin@apple.com>
129
130         * Scripts/do-webcore-rename: More renaming plans.
131
132 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
133
134         Rubber stamped by Darin.
135
136         Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
137         whitespaces introduced in the previous commit.
138
139         * GNUmakefile.am:
140
141 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
142
143         Rubber-stamped by Darin.
144
145         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
146
147 2008-02-23  David Kilzer  <ddkilzer@apple.com>
148
149         Please clarify licensing for some files
150         <http://bugs.webkit.org/show_bug.cgi?id=14970>
151
152         Reviewed by Darin.
153
154         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
155         copyright statement.  Replaced license with newer Apple BSD-style license.
156         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
157         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
158         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
159         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
160         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
161         * mangleme/LICENSE: Added (LGPL).
162
163 2008-02-22  Anders Carlsson  <andersca@apple.com>
164
165         Reviewed by Adam.
166
167         <rdar://problem/5748781> 
168         https://bugs.webkit.org/show_bug.cgi?id=17413
169         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
170         
171         Copy the Java plug-in over to the new location.
172         
173         * FindSafari/FindSafari.cpp:
174         (_tmain):
175
176 2008-02-22  Anders Carlsson  <andersca@apple.com>
177
178         Reviewed by Adam.
179
180         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
181         
182         * DumpRenderTree/win/DumpRenderTree.cpp:
183         (runTest):
184         Init the URL request with the correct timeout.
185
186 2008-02-21  Mike Auty  <mike.auty@gmail.com>
187
188         Reviewed by Alp Toker.
189
190         http://bugs.webkit.org/show_bug.cgi?id=17445
191         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
192
193         GTK+/autotools build system improvements
194
195         The GNUmakefile.am files make use of the LDFLAGS variable to include library
196         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
197         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
198
199         The as-needed flag discards libraries whose functions have not been needed by
200         earlier libraries, which therefore makes the ordering important.
201
202         This moves all -l library inclusion statements from LDFLAGS variables to
203         LIBADD/LDADD variables.
204
205         * GNUmakefile.am:
206
207 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
208
209         Reviewed by Alp.
210
211         - http://bugs.webkit.org/show_bug.cgi?id=17428
212           Reenable a Windows-based launcher
213
214         This patch reenables the venerable Spinneret application,
215         changing its name to match the other lanch applications.
216
217         * WinLauncher: Added.
218         * WinLauncher/WinLauncher.cpp: Added.
219         (WinLauncherWebHost::updateAddressBar):
220         (WinLauncherWebHost::QueryInterface):
221         (WinLauncherWebHost::AddRef):
222         (WinLauncherWebHost::Release):
223         (resizeSubViews):
224         (_tWinMain):
225         (MyRegisterClass):
226         (InitInstance):
227         (WndProc):
228         (MyEditProc):
229         (About):
230         (loadURL):
231         * WinLauncher/WinLauncher.h: Added.
232         (WinLauncherWebHost::WinLauncherWebHost):
233         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
234         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
235         (WinLauncherWebHost::didFailProvisionalLoadWithError):
236         (WinLauncherWebHost::didCommitLoadForFrame):
237         (WinLauncherWebHost::didReceiveTitle):
238         (WinLauncherWebHost::didReceiveIcon):
239         (WinLauncherWebHost::didFinishLoadForFrame):
240         (WinLauncherWebHost::didFailLoadWithError):
241         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
242         (WinLauncherWebHost::willPerformClientRedirectToURL):
243         (WinLauncherWebHost::didCancelClientRedirectForFrame):
244         (WinLauncherWebHost::willCloseFrame):
245         (WinLauncherWebHost::windowScriptObjectAvailable):
246         * WinLauncher/WinLauncher.ico: Added.
247         * WinLauncher/WinLauncher.rc: Added.
248         * WinLauncher/WinLauncher.vcproj: Added.
249         * WinLauncher/resource.h: Added.
250         * WinLauncher/small.ico: Added.
251         * WinLauncher/stdafx.cpp: Added.
252         * WinLauncher/stdafx.h: Added.
253
254 2008-02-19  Brady Eidson  <beidson@apple.com>
255
256         Reviewed by Geoff
257
258         Fixed a bug in DRT --threaded mode
259
260         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
261         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
262           to pthread_join() each thread that had been created, but you can't join a detached thread!
263
264 2008-02-18  Brady Eidson  <beidson@apple.com>
265
266         Changes by Geoff Garen, Reviewed by Darin
267
268         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
269
270         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
271
272         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
273         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
274         this series of method calls will deadlock.  If things are good, it will complete successfully.
275
276         * DumpRenderTree/mac/ObjCController.m:
277         (runJavaScriptThread):
278         (+[ObjCController isSelectorExcludedFromWebScript:]):
279         (+[ObjCController webScriptNameForSelector:]):
280         (-[ObjCController testValueForKey]):
281
282 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
283
284         Reviewed by Adam.
285
286         Remove FindSafari's Release configuration.
287
288         * FindSafari/FindSafari.vcproj:
289
290 2008-02-15  Adam Roben  <aroben@apple.com>
291
292         Fix a typo that broke the Mac build
293
294         Reviewed by Mark.
295
296         * Scripts/build-webkit:
297
298 2008-02-14  Adam Roben  <aroben@apple.com>
299
300         Turn on cross-document messaging support by default
301
302         Reviewed by Darin.
303
304         * Scripts/build-webkit:
305
306 2008-02-14  Adam Roben  <aroben@apple.com>
307
308         Conditionalize cross-document messaging support
309
310         The cross-document messaging parts of HTML 5 are in flux and we want
311         ports to be able to turn off the support as needed.
312
313         Note that the support is turned off by default right now. A subsequent
314         commit will turn it on by default.
315
316         Reviewed by Darin.
317
318         * Scripts/build-webkit:
319
320 2008-02-14  Darin Adler  <darin@apple.com>
321
322        - fix Windows build
323
324         * DumpRenderTree/win/UIDelegate.cpp:
325         (UIDelegate::setStatusText): Update parameter types to match declaration.
326
327 2008-02-14  Oliver Hunt  <oliver@apple.com>
328
329         Reviewed by Geoff G and Weinig.
330
331         Add ability for DRT to report tests setting the status text.
332
333         * DumpRenderTree/LayoutTestController.cpp:
334         (LayoutTestController::LayoutTestController):
335         (dumpStatusCallbacksCallback):
336         (LayoutTestController::staticFunctions):
337         * DumpRenderTree/LayoutTestController.h:
338         * DumpRenderTree/mac/UIDelegate.mm:
339         (-[UIDelegate webView:setStatusText:]):
340         * DumpRenderTree/win/UIDelegate.cpp:
341         * DumpRenderTree/win/UIDelegate.h:
342
343 2008-02-13  Adam Roben  <aroben@apple.com>
344
345         Windows build fix
346
347         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
348
349 2008-02-13  Adam Roben  <aroben@apple.com>
350
351         Windows/GTK+ build fix
352
353         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
354         get isnan.
355
356 2008-02-13  Brady Eidson  <beidson@apple.com>
357
358         Reviewed by Darin Adler
359
360         Add some much needed Database support to DRT
361
362         * DumpRenderTree/LayoutTestController.cpp:
363         (LayoutTestController::LayoutTestController):
364         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
365           databases are called
366         (clearAllDatabasesCallback): Allow a test to delete all databases
367         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
368         (LayoutTestController::staticFunctions):
369
370         * DumpRenderTree/LayoutTestController.h:
371         (LayoutTestController::dumpDatabaseCallbacks):
372         (LayoutTestController::setDumpDatabaseCallbacks):
373
374         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
375         (LayoutTestController::clearAllDatabases):
376         (LayoutTestController::setDatabaseQuota):
377
378         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
379         (LayoutTestController::clearAllDatabases): Stubbed out
380         (LayoutTestController::setDatabaseQuota): Ditto
381         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
382         (LayoutTestController::clearAllDatabases): Stubbed out with error message
383         (LayoutTestController::setDatabaseQuota): Ditto
384
385         * DumpRenderTree/mac/UIDelegate.mm:
386         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
387           message with details about the event then return a 5mb quota like before
388
389
390 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
391
392         Changes to support merged MIDL output.
393
394         All COM interfaces are now generated to WebKit.h.
395
396         Reviewed by Sam, Ada.
397
398         * Drosera/win/BaseDelegate.h:
399         * Drosera/win/DebuggerClient.cpp:
400         * Drosera/win/DebuggerDocumentPlatform.cpp:
401         * Drosera/win/Drosera.cpp:
402         * Drosera/win/ServerConnection.cpp:
403         * Drosera/win/ServerConnection.h:
404         * DumpRenderTree/win/DumpRenderTree.cpp:
405         * DumpRenderTree/win/EditingDelegate.h:
406         * DumpRenderTree/win/EventSender.cpp:
407         * DumpRenderTree/win/FrameLoadDelegate.cpp:
408         * DumpRenderTree/win/FrameLoadDelegate.h:
409         * DumpRenderTree/win/GCControllerWin.cpp:
410         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
411         * DumpRenderTree/win/PolicyDelegate.h:
412         * DumpRenderTree/win/ResourceLoadDelegate.h:
413         * DumpRenderTree/win/UIDelegate.cpp:
414         * DumpRenderTree/win/UIDelegate.h:
415         * DumpRenderTree/win/WorkQueueItemWin.cpp:
416
417 2008-02-10  Dan Bernstein  <mitz@apple.com>
418
419         Reviewed by Oliver Hunt.
420
421         - fix a memory leak
422
423         * DumpRenderTree/cg/ImageDiffCG.cpp:
424         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
425         and leaking the buffer each time.
426
427 2008-02-07  Adam Roben  <aroben@apple.com>
428
429         Fix error in bisect-builds when responding "broken" for the first
430         build
431
432         Reviewed by Dave Kilzer.
433
434         * Scripts/bisect-builds: Only try to test the build if the nightly
435         info for the current index has not been deleted.
436
437 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
438
439         Reviewed by Alexey Proskuryakov.
440
441         Fixed two minor typos in the --root option, to get it working.
442
443         * Scripts/run-sunspider:
444             1. Actually assign the function argument to our local variable.
445             2. Actually set the $root variable, so we don't try to build later.
446
447 2008-02-05  Oliver Hunt  <oliver@apple.com>
448
449         RS=Eric.
450
451         Re-enable foreignObject by default as it is needed for a number of non-fO
452         related SVG tests and none of the old known crashes occur anymore.
453
454         * Scripts/build-webkit:
455
456 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
457
458         Build fix.  Don't override intermediate directory.
459
460         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
461
462 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
463
464         Build fix for Windows. willCloseFrame is a pure virtual and we are
465         forced to have an implementation.
466         
467         This partially reverts r30014.
468
469         * DumpRenderTree/win/FrameLoadDelegate.cpp:
470         (FrameLoadDelegate::willCloseFrame):
471         * DumpRenderTree/win/FrameLoadDelegate.h:
472
473 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
474
475         Reviewed by Holger.
476
477         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
478
479         * Scripts/make-js-test-wrappers:
480
481 2008-02-05  Holger Freyther  <zecke@selfish.org>
482
483         Reviewed by Darin.
484
485         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
486         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
487         depends on the order the tests are executed.
488         
489         Propose to remove willCloseFrame and didlCearWindowObject output from the
490         FrameLoadDelegate and update the test results. The output of didClearWindowObject
491         is not interesting for any of the current tests and we have other ways to find
492         out if a frame was closed or not.
493
494         * DumpRenderTree/mac/FrameLoadDelegate.mm:
495         * DumpRenderTree/win/FrameLoadDelegate.cpp:
496         (FrameLoadDelegate::didClearWindowObject):
497         * DumpRenderTree/win/FrameLoadDelegate.h:
498
499 2008-02-04  Mark Rowe  <mrowe@apple.com>
500
501         Reviewed by Oliver Hunt.
502
503         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
504         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
505
506         Don't install the signal handler unless we are running the pixel tests.
507         It is currently only used to restore the color profile, but by catching
508         signals we can trigger a deadlock in DRT while running leak tests.
509         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
510         and a more complete fix will need to be developed to address this for
511         pixel tests as well.
512
513         * DumpRenderTree/mac/DumpRenderTree.mm:
514         (dumpRenderTree):
515
516 2008-02-04  Mark Rowe  <mrowe@apple.com>
517
518        Gtk qmake build fix.
519
520         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
521
522 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
523
524         Reviewed by Alp Toker and Mark Rowe.
525
526         http://bugs.webkit.org/show_bug.cgi?id=16618
527         [GTK] build-webkit and run-webkit-tests autootools support
528
529         * Scripts/build-webkit: added --database and --icon-database options
530         * Scripts/run-launcher:
531         * Scripts/run-webkit-tests:
532         * Scripts/webkitdirs.pm:
533
534 2008-02-04  Oliver Hunt  <oliver@apple.com>
535
536         Reviewed by Steve F.
537
538         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
539
540         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
541         Issues include:
542           * Uses Sleep() to implement leapForward reliably.
543           * 3 DND tests still fail for reasons that i have not yet determined
544           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
545
546         * DumpRenderTree/win/EventSender.cpp:
547         (leapForwardCallback):
548         (mouseDownCallback):
549         (doMouseUp):
550         (mouseUpCallback):
551         (doMouseMove):
552         (mouseMoveToCallback):
553           Minor updates to these functions to handle the different message queue structure.
554
555         (replaySavedEvents):
556           More complicated now.  Where possible we just use the old while-loop model of execution,
557           but when leapForward has been used we have to jump through some hoops and set up an 
558           inner event loop so that we can ensure messages get the correct time stamp.
559
560         * DumpRenderTree/win/UIDelegate.cpp:
561         (UIDelegate::doDragDrop):
562           Call replaySavedEvents directly to force synchronous handling of drag and drop.
563
564 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
565
566         Reviewed by Alp Toker and Mark Rowe.
567
568         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
569         Bug 17175: Use of C++ compiler flags in CFLAGS
570
571         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
572
573 2008-02-04  Darin Adler  <darin@apple.com>
574
575         Reviewed by Geoff.
576
577         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
578         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
579         subdirectory.
580
581 2008-02-04  Adam Roben  <aroben@apple.com>
582
583         Windows Apple-only build fix
584
585         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
586         directory.
587
588 2008-02-04  Alp Toker  <alp@atoker.com>
589
590         Rubber-stamped by Mark Rowe.
591
592         Remove all trailing whitespace in the GTK+ port and related
593         components.
594
595         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
596         * DumpRenderTree/gtk/GCControllerGtk.cpp:
597         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
598         * GNUmakefile.am:
599
600 2008-02-01  Eric Seidel  <eric@webkit.org>
601
602         Reviewed by Oliver.
603
604         Also search LayoutTests/svg for js-based tests.
605
606         * Scripts/make-js-test-wrappers:
607
608 2008-01-31  Alp Toker  <alp@atoker.com>
609
610         Rubber-stamped by Adam Roben.
611
612         http://bugs.webkit.org/show_bug.cgi?id=17006
613         [GTK] Header path should be webkit/webkit.h
614
615         Move the GTK+ API sources as needed and update the build systems.
616
617         * DumpRenderTree/gtk/DumpRenderTree.cpp:
618         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
619         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
620         * GNUmakefile.am:
621         * GtkLauncher/main.c:
622
623 2008-01-30  Stephanie  <slewis@apple.com>
624
625         Reviewed by Geoff.
626
627         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
628
629         * Scripts/run-webkit-tests:
630
631 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
632
633         Reviewed by Adam Roben.
634
635         One more debug (external) fix.
636
637         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
638         and Debug configurations. 
639
640 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
641
642         Reviewed by Sam Weinig. Sam Weinig.
643         
644         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
645         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
646
647         Modified our policy delegates not to output window.name. Since a
648         previous test may have explicitly set window.name, we can't rely on its
649         implicit value in test results.
650
651         * DumpRenderTree/mac/PolicyDelegate.mm:
652         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
653
654         * DumpRenderTree/win/PolicyDelegate.cpp:
655         (PolicyDelegate::decidePolicyForNavigationAction):
656
657 2008-01-29  Mark Rowe  <mrowe@apple.com>
658
659         Reviewed by Tim Hatcher.
660
661         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
662
663         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
664
665 2008-01-29  David Kilzer  <ddkilzer@apple.com>
666
667         Refactor ChangeLog path code
668
669         Reviewed by Adam.
670
671         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
672         duplicate code in another foreach() loop.
673
674 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
675
676         Reviewed by Darin.
677
678         <rdar://problem/5710692> All storage tests fail/crash
679
680         * DumpRenderTree/mac/UIDelegate.mm:
681         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
682         arbitrary quota of 5 megabytes.
683
684         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
685         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
686         Removed unused (I think) code.
687         
688         * DumpRenderTree/win/UIDelegate.cpp:
689         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
690         (UIDelegate::webViewPainted): A stub implementation.
691         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
692         * DumpRenderTree/win/UIDelegate.h:
693
694 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
695
696         GTK+ DRT build fix for breakage introduced in r29822.
697
698         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
699         (LayoutTestController::setPersistentUserStyleSheetLocation):
700         (LayoutTestController::clearPersistentUserStyleSheet):
701
702 2008-01-27  Dan Bernstein  <mitz@apple.com>
703
704         Reviewed by Darin Adler.
705
706         - add support for directory prologues and epilogues to run-webkit-tests
707         - allow setting a persistent user style sheet in DumpRenderTree
708         - activate the WebKit Layout Tests font in Windows DumpRenderTree
709
710         * DumpRenderTree/LayoutTestController.cpp:
711         (clearPersistentUserStyleSheetCallback): Added.
712         (setPersistentUserStyleSheetLocationCallback): Added.
713         (LayoutTestController::staticFunctions): Added.
714         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
715         * DumpRenderTree/LayoutTestController.h:
716         * DumpRenderTree/mac/DumpRenderTree.mm:
717         (setPersistentUserStyleSheetLocation): Added.
718         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
719         to the set of things this function resets. Now it either disables the
720         user style sheet or sets it to the persistent user style sheet and
721         enables it.
722         * DumpRenderTree/mac/DumpRenderTreeMac.h:
723         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
724         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
725         (LayoutTestController::clearPersistentUserStyleSheet): Added.
726         * DumpRenderTree/win/DumpRenderTree.cpp:
727         (setPersistentUserStyleSheetLocation): Added.
728         (initialize): Added the WebKit Layout Tests font to the set of fonts to
729         install.
730         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
731         * DumpRenderTree/win/DumpRenderTreeWin.h:
732         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
733         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
734         (LayoutTestController::clearPersistentUserStyleSheet): Added.
735         * Scripts/run-webkit-tests: Changed to look for, and if found process in
736         DumpRenderTree, files named run-webkit-tests-prologue.html and
737         run-webkit-tests-epilogue.html in the resources subdirectory of any
738         test directory and platform test results directory. The prologues are
739         processed before the first test from the directory (and its
740         subdirectories) is run, and the epilogues are processed after the last
741         test from the directory is run. Platform-specific prologues and
742         epilogues are processed in order of specificity.
743
744 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
745
746         Reviewed by Mark Rowe.
747
748         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
749
750         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
751         (matching Mac DRT).
752         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
753
754 2008-01-24  Sam Weinig  <sam@webkit.org>
755
756         Reviewed by Ada Chan.
757
758         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
759
760         - Adds simplified UndoManager to windows DRT to allow testing the
761           undo/redo code paths in WebCore and WebKit.  This is a temporary
762           solution to an issue that should eventually be solved by having a
763           shared UndoManager in WebKit.
764
765         * DumpRenderTree/win/DumpRenderTree.cpp:
766         (runTest):
767         * DumpRenderTree/win/UIDelegate.cpp:
768         (DRTUndoObject::DRTUndoObject):
769         (DRTUndoObject::invoke):
770         (DRTUndoStack::~DRTUndoStack):
771         (DRTUndoStack::isEmpty):
772         (DRTUndoStack::clear):
773         (DRTUndoStack::push):
774         (DRTUndoStack::pop):
775         (DRTUndoManager::canRedo):
776         (DRTUndoManager::canUndo):
777         (DRTUndoManager::DRTUndoManager):
778         (DRTUndoManager::removeAllActions):
779         (DRTUndoManager::registerUndoWithTarget):
780         (DRTUndoManager::redo):
781         (DRTUndoManager::undo):
782         (UIDelegate::UIDelegate):
783         (UIDelegate::resetUndoManager):
784         (UIDelegate::registerUndoWithTarget):
785         (UIDelegate::removeAllActionsWithTarget):
786         (UIDelegate::setActionTitle):
787         (UIDelegate::undo):
788         (UIDelegate::redo):
789         (UIDelegate::canUndo):
790         (UIDelegate::canRedo):
791         * DumpRenderTree/win/UIDelegate.h:
792
793 2008-01-23  Adam Roben  <aroben@apple.com>
794
795         Allow directories containing ChangeLogs to be passed to
796         resolve-ChangeLogs
797
798         Reviewed by David Kilzer.
799
800         * Scripts/resolve-ChangeLogs:
801         (sub findChangeLog): Return a ChangeLog contained within the specified
802         directory if one exists.
803
804 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
805
806         <rdar://problem/5698732> Copyright strings should include 2008
807
808         Reviewed by Sam.
809
810         * Drosera/win/Drosera.vcproj/Drosera.rc:
811         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
812
813 2008-01-23  Alp Toker  <alp@atoker.com>
814
815         Rubber-stamped by Mark Rowe.
816
817         Remove whitespace after -I in automake include lists.
818
819         * GNUmakefile.am:
820
821 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
822
823         Reviewed by Lars Knoll <lars@trolltech.com>.
824
825         Reworked the JavaScriptCore Qt bindings:
826         
827         * Update JS DRT controller for Qt JS binding changes.
828         There were two functions that needed some changes
829         so that the layout tests would work, so this makes
830         a few tests pass again.
831         
832         * Bump the timeout for layout tests up to 11s.
833         At least some tests have an internal timeout of
834         10 seconds, so make the waitUntilDone approach
835         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
836         is one of these - now the failure message is more
837         accurate.
838         
839
840         * DumpRenderTree/qt/jsobjects.cpp:
841         (LayoutTestController::waitUntilDone):
842         * DumpRenderTree/qt/jsobjects.h:
843
844 2008-01-22  Anders Carlsson  <andersca@apple.com>
845
846         Reviewed by Darin and Adam.
847
848         <rdar://problem/5688975>
849         div element on microsoft site has wrong left offset.
850         
851         Add new method for testing the return vale of NPN_GetProperty.
852         
853         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
854         (pluginInvoke):
855
856 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
857
858         Reviewed by Adam Roben.
859
860         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
861
862         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
863
864 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
865
866         Reviewed by Alp Toker.
867
868         http://bugs.webkit.org/show_bug.cgi?id=16955
869         Get errors when cross-compile webkit-gtk
870
871         * GNUmakefile.am: Removed ICU_CFLAGS 
872
873 2008-01-21  Darin Adler  <darin@apple.com>
874
875         Reviewed by Mitz and Adam.
876
877         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
878         sorting speed by doing all sort criteria in a single pass instead of three sorts.
879
880 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
881
882         Reviewed by Holger.
883
884         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
885         
886         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
887         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
888         and make the return value depend on whether we successfully determined a focusable
889         node or not.
890         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
891         if we could not handle the focus chain ourselves.
892         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
893         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
894         used to control the situation of stepping out of the focus chain inside the page.
895         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
896         The layout tests expect this to be disabled but for the user it seems sensible to have it
897         on by default, hence the default in qwebsettings.cpp
898         
899
900         * DumpRenderTree/qt/DumpRenderTree.cpp:
901         (WebCore::WebPage::WebPage):
902
903 2008-01-19  Mark Rowe  <mrowe@apple.com>
904
905         Reviewed by Alp Toker.
906
907         Allow the --http flag to run-webkit-tests to override
908         the default behaviour of disabling HTTP tests for Qt,
909         Gtk and Wx.
910
911         * Scripts/run-webkit-tests:
912
913 2008-01-19  David Kilzer  <ddkilzer@apple.com>
914
915         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
916
917         Reviewed by Darin.
918
919         We now touch a check-for-global-initializers.timestamp file in
920         the TARGET_TEMP_DIR directory to determine when new object files
921         have been compiled and thus need to be checked.  If the timestamp
922         file doesn't exist, all object files will be checked.
923
924         Previously the modification time of the "executable" (the
925         framework binary, e.g., WebKit.framework/WebKit) was used, but
926         since this was the last file modified at the end of the compile
927         phase, no object files would ever get checked!
928
929         Also added JSCustomSQLTransactionCallback.o to the list of files
930         since it has static initializers in Debug builds of WebCore.
931
932         * Scripts/check-for-global-initializers:
933
934 2008-01-18  Adam Roben  <aroben@apple.com>
935
936         Build fix
937
938         * Scripts/build-webkit:
939
940 2008-01-18  Beth Dakin  <bdakin@apple.com>
941
942         Reviewed by Oliver.
943
944         Update build-webkit to account for foreign-object being disabled by 
945         default.
946
947         * Scripts/build-webkit:
948
949 2008-01-18  Adam Roben  <aroben@apple.com>
950
951         Updated for method renames
952
953         Reviewed by Adele.
954
955         * DumpRenderTree/mac/FrameLoadDelegate.mm:
956         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
957         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
958         (LayoutTestController::setMainFrameIsFirstResponder):
959         (LayoutTestController::setWindowIsKey):
960         * DumpRenderTree/mac/UIDelegate.mm:
961         (-[UIDelegate webViewFocus:]):
962         * DumpRenderTree/win/FrameLoadDelegate.cpp:
963         (FrameLoadDelegate::didCommitLoadForFrame):
964
965 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
966
967         Reviewed by Adam Roben.
968
969         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
970         between DRT and TestNetscapePlugin.
971
972         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
973         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
974
975 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
976
977         Reviewed by Holger.
978
979         Fix fast/dom/Window/window-resize.html
980         
981         In DRT connect the page's geometryChangeRequest signal to a slot that
982         sets the geometry of the view widget.
983         
984
985         * DumpRenderTree/qt/DumpRenderTree.cpp:
986         (WebCore::WebPage::setViewGeometry):
987         (WebCore::WebPage::WebPage):
988
989 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
990
991         Build fix.
992
993         * Drosera/DroseraWin.make:
994
995 2008-01-17  Darin Adler  <darin@apple.com>
996
997         * Scripts/run-webkit-tests: Fixed a bug number.
998
999 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
1000
1001         Reviewed by Adam Roben.
1002
1003         http://bugs.webkit.org/show_bug.cgi?id=16908
1004         run-webkit-tests complains about missing FindSafari.exe
1005
1006         * Scripts/webkitdirs.pm: Append _debug as appropriate.
1007
1008 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1009
1010         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
1011         
1012         Rubber-stamped by Jon Honeycutt.
1013
1014         * DumpRenderTree/win/DumpRenderTree.vcproj:
1015
1016 2008-01-16  Alp Toker  <alp@atoker.com>
1017
1018         Reviewed by Mark Rowe.
1019
1020         http://bugs.webkit.org/show_bug.cgi?id=16218
1021         [GTK] API: Should this entry point be called go_back rather than go_backward?
1022
1023         Track back/forward API changes in the tools.
1024
1025         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1026         (BackForwardItem::invoke):
1027         * GtkLauncher/main.c:
1028         (go_back_cb):
1029
1030 2008-01-16  Adam Roben  <aroben@apple.com>
1031
1032         Windows build fix after r29488
1033
1034         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1035         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
1036         expects to find the plugin.
1037
1038 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1039
1040         Reviewed by Sam Weinig.
1041         
1042         Fixed the waitUntilDone watchdog timer -- the old code never added the
1043         timer to the run loop, so it didn't do anything.
1044
1045         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1046         (LayoutTestController::setWaitToDump):
1047         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1048         (LayoutTestController::setWaitToDump):
1049
1050 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
1051
1052         Use shared vsprops for most vcproj properties.
1053         
1054         Reviewed by Darin.
1055
1056         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1057         * DumpRenderTree/win/DumpRenderTree.vcproj:
1058         * DumpRenderTree/win/ImageDiff.vcproj:
1059         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1060         * FindSafari/FindSafari.vcproj:
1061
1062 2008-01-14  Stephanie  <slewis@apple.com>
1063
1064        Reviewed by NOBODY.
1065   
1066        revert accidental character.
1067
1068        * Scripts/run-webkit-tests:
1069
1070 2008-01-14  Stephanie  <slewis@apple.com>
1071
1072         RS=Oliver
1073
1074         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
1075
1076         * Scripts/run-webkit-tests:
1077
1078 2008-01-14  Darin Adler  <darin@apple.com>
1079
1080         * Scripts/do-webcore-rename: Queue up another rename.
1081
1082 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1083
1084         Reviewed by Darin.
1085
1086         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
1087         the tests were ran.
1088         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
1089
1090         * Scripts/run-webkit-tests:
1091
1092 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1093
1094         Reviewed by Darin.
1095
1096         * Randomize tests array to spot test cases where the results depends on the order
1097         the tests are ran.
1098         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
1099
1100         * Scripts/run-webkit-tests:
1101
1102 2008-01-14  Darin Adler  <darin@apple.com>
1103
1104         * Scripts/run-webkit-tests: More ignore list tweaking.
1105
1106 2008-01-14  Darin Adler  <darin@apple.com>
1107
1108         * Scripts/run-webkit-tests: Add another leak to the ignore list.
1109
1110 2008-01-14  Dan Bernstein  <mitz@apple.com>
1111
1112         Reviewed by Adam Roben.
1113
1114         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
1115           build bots
1116
1117         * DumpRenderTree/win/DumpRenderTree.cpp:
1118         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
1119
1120 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
1121
1122         Share common files across projects.
1123         
1124         Unify vsprops files
1125         Debug:          common.vsprops, debug.vsprops
1126         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
1127         Release:        common.vsprops, release.vsprops
1128         
1129         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
1130         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
1131
1132         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
1133
1134         Reviewed by Adam Roben.
1135
1136         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1137         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
1138         * Drosera/win/Drosera.vcproj/VERSION: Removed.
1139         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
1140         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
1141         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
1142         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
1143         * DumpRenderTree/win/DumpRenderTree.vcproj:
1144         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1145         * DumpRenderTree/win/debug.vsprops: Removed.
1146         * DumpRenderTree/win/debug_internal.vsprops: Removed.
1147         * DumpRenderTree/win/release.vsprops: Removed.
1148
1149 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
1150
1151         Reviewed by Maciej.
1152
1153         - http://bugs.webkit.org/show_bug.cgi?id=16314
1154           Script to launch Drosera
1155
1156         * Scripts/gdb-drosera: Added.
1157         * Scripts/run-drosera: Added.
1158         * Scripts/run-drosera-nightly.cmd: Added.
1159         * Scripts/webkitdirs.pm: Added runDrosera function.
1160
1161 2008-01-13  Dan Bernstein  <mitz@apple.com>
1162
1163         - fix breakage due to last-minute change
1164
1165         * DumpRenderTree/win/DumpRenderTree.cpp:
1166         (runTest): Declare the loop variable.
1167
1168 2008-01-13  Dan Bernstein  <mitz@apple.com>
1169
1170         Reviewed by Adam Roben.
1171
1172         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
1173
1174         * DumpRenderTree/win/DumpRenderTree.cpp:
1175         (DumpRenderTreeWndProc):
1176         (initialize):
1177         (dumpBackForwardList):
1178         (dumpBackForwardListForAllWindows):
1179         (dump):
1180         (resetWebViewToConsistentStateBeforeTesting): Factored out of
1181         runTest().
1182         (runTest):
1183         (allWindows): Added. Returns a vector of all open windows.
1184         (windowToWebViewMap): Added. Returns a map from open windows to their
1185         WebViews.
1186         (createWebViewAndOffscreenWindow): Factored out of main() to be
1187         reusable for creating extra windows.
1188         (main):
1189         * DumpRenderTree/win/DumpRenderTreeWin.h:
1190         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1191         (LayoutTestController::windowCount): Implemented.
1192         * DumpRenderTree/win/UIDelegate.cpp:
1193         (UIDelegate::createWebViewWithRequest): Implemented.
1194         (UIDelegate::webViewClose): Implemented.
1195         * DumpRenderTree/win/UIDelegate.h:
1196
1197 2008-01-12  Alp Toker  <alp@atoker.com>
1198
1199         Reviewed by Mark Rowe.
1200
1201         Hide non-public symbols in GTK+/autotools release builds.
1202
1203         * GNUmakefile.am:
1204
1205 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1206
1207         Reviewed by Ap.
1208
1209         * Make launching of the WebKit httpd work on GNU/Debian/Linux
1210         
1211         The configuration of Apache2 and installation does not depend on
1212         the kernel but on the distribution policy. Make launching of httpd
1213         work for Debian derived distributions.
1214
1215         * Scripts/run-webkit-httpd:
1216         * Scripts/run-webkit-tests:
1217         * Scripts/webkitdirs.pm:
1218
1219 2008-01-12  Mark Rowe  <mrowe@apple.com>
1220
1221         Reviewed by Maciej Stachowiak.
1222
1223         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
1224
1225         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
1226         match the callers expectations that it can take ownership of the string.
1227
1228 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
1229
1230         Reviewed by Adam Roben.
1231
1232         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
1233
1234         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
1235         as these are only posted because the test window is not a normal visible one, and
1236         they confuse drag&drop machinery.
1237
1238 2008-01-11  Adam Roben  <aroben@apple.com>
1239
1240         Fix a crash when pathToLocalResource fails and a leak
1241
1242         Reviewed by Darin.
1243
1244         * DumpRenderTree/LayoutTestController.cpp:
1245         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
1246         sure not to pass null to JSValueMakeString.
1247         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1248         (LayoutTestController::pathToLocalResource): Print an error message if
1249         the conversion fails so it's clear what happened.
1250
1251 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1252
1253         Reviewed by John Sullivan.
1254
1255         * DumpRenderTree/mac/GCControllerMac.mm:
1256         (GCController::collectOnAlternateThread): Updated for name change.
1257
1258 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
1259
1260         wx build fix. Don't build dftables any longer since it's now a Perl
1261         script.
1262
1263         * wx/build-wxwebkit:
1264
1265 2008-01-10  Sam Weinig  <sam@webkit.org>
1266
1267         Reviewed by Anders Carlsson.
1268
1269         Make DRT track open windows instead of allocated windows so that
1270         we can avoid ASSERTION due to late deallocs out of our control.
1271
1272         * DumpRenderTree/mac/DumpRenderTree.mm:
1273         (dumpBackForwardListForAllWindows):
1274         (runTest):
1275         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1276         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1277         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1278         (+[DumpRenderTreeWindow openWindows]):
1279         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1280         (-[DumpRenderTreeWindow close]):
1281         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1282         (LayoutTestController::windowCount):
1283
1284 2008-01-10  Ada Chan  <adachan@apple.com>
1285
1286         Meta key is not the same as Alt key on windows.
1287
1288         Reviewed by Darin.
1289
1290         * DumpRenderTree/win/EventSender.cpp:
1291         (keyDownCallback):
1292
1293 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
1294
1295         Reviewed by Darin, Sam and Adam.
1296
1297         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
1298         link in gmail message displays JavaScript alert falsely complaining
1299         about pop-up blocking.
1300         - Added the ability to enable the pop-up blocker via the
1301         LayoutTestController.
1302
1303         * DumpRenderTree/LayoutTestController.cpp:
1304         (setPopupBlockingEnabledCallback):
1305         (LayoutTestController::staticFunctions):
1306         * DumpRenderTree/LayoutTestController.h:
1307         * DumpRenderTree/mac/DumpRenderTree.mm:
1308         (setDefaultsToConsistentValuesForTesting):
1309         (resetWebViewToConsistentStateBeforeTesting):
1310         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1311         (LayoutTestController::setPopupBlockingEnabled):
1312
1313 2008-01-10  Lars Knoll  <lars@trolltech.com>
1314
1315         Reviewed by Simon.
1316
1317         rename QWebPageHistory to QWebHistory.
1318         
1319
1320         * DumpRenderTree/qt/jsobjects.cpp:
1321
1322 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
1323
1324         Reviewed by Darin.
1325         
1326         - add some more renames, adjust some
1327
1328         * Scripts/do-webcore-rename:
1329
1330 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1331
1332         Reviewed by Oliver.
1333
1334         Enable SVG Fonts support by default.
1335
1336         * Scripts/build-webkit:
1337
1338 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1339
1340         Reviewed by Adam.
1341
1342         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
1343         DRT doesn't handle platform specific pixel test results correctly.
1344
1345         <test>-expected.txt files and <test>-expected.png files may now live
1346         in different directories (ie. a cross-platform <test>-expected.txt file
1347         and a platform-specific <test>-expected.png file).
1348
1349         * Scripts/run-webkit-tests:
1350
1351 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
1352
1353         Reviewed by Darin.
1354
1355         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
1356         DRT did not correctly handle printing the '\0' char.  Now it does.
1357
1358         * DumpRenderTree/win/DumpRenderTree.cpp:
1359         (dumpFramesAsText):
1360         (dump):
1361
1362 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
1363
1364         Reviewed by Lars.
1365
1366         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
1367         
1368
1369         * DumpRenderTree/qt/main.cpp:
1370         * DumpRenderTree/qt/testplugin.cpp:
1371         * DumpRenderTree/qt/testplugin.h:
1372
1373 2008-01-05  Mark Rowe  <mrowe@apple.com>
1374
1375         Reviewed by Alp Toker.
1376
1377         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
1378
1379         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1380         (processWork): Process pending work.
1381         (webViewLoadFinished): Schedule processing of pending work.
1382         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
1383
1384 2008-01-05  Darin Adler  <darin@apple.com>
1385
1386         * Scripts/do-webcore-rename: Some more renaming plans.
1387
1388 2008-01-04  Alice Liu  <alice.liu@apple.com>
1389
1390         Reviewed by Alexey and Darin.
1391
1392         Adding "home" and "end" to DRT's keydown since
1393         DOM key events can't handle keyIdentifiers at this point. 
1394
1395         * DumpRenderTree/mac/EventSendingController.mm:
1396         (-[EventSendingController keyDown:withModifiers:]):
1397         * DumpRenderTree/win/EventSender.cpp:
1398         (keyDownCallback):
1399
1400 2008-01-04  Lars Knoll  <lars@trolltech.com>
1401
1402         Reviewed by Simon.
1403
1404         fix DRT after the changes to QWebPage.
1405         
1406         The great thing is that we actually don't have
1407         any regressions from the QWebPage change :)
1408         
1409
1410         * DumpRenderTree/qt/DumpRenderTree.cpp:
1411         (WebCore::DumpRenderTree::DumpRenderTree):
1412
1413 2008-01-04  Lars Knoll  <lars@trolltech.com>
1414
1415         Reviewed by Simon.
1416
1417         make QWebPage a QObject and get things to compile.
1418         
1419         Nothing works currently though.
1420         
1421
1422         * DumpRenderTree/qt/DumpRenderTree.cpp:
1423         (WebCore::DumpRenderTree::DumpRenderTree):
1424
1425 2008-01-04  Lars Knoll  <lars@trolltech.com>
1426
1427         Reviewed by Simon.
1428
1429         take a QString as identifier in QWebFrame::addToJSWindowObject.
1430
1431         * DumpRenderTree/qt/DumpRenderTree.cpp:
1432         (WebCore::DumpRenderTree::initJSObjects):
1433
1434 2008-01-04  Alp Toker  <alp@atoker.com>
1435
1436         GTK+ DRT build fix for breakage introduced in r29149.
1437
1438         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1439         (LayoutTestController::execCommand):
1440
1441 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1442
1443         Reviewed by Darin.
1444
1445         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1446
1447         Added layoutTestController.execCommand to access editor commands that are not available
1448         via document.execCommand.
1449
1450         * DumpRenderTree/LayoutTestController.cpp:
1451         (execCommandCallback):
1452         (LayoutTestController::staticFunctions):
1453         * DumpRenderTree/LayoutTestController.h:
1454         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1455         (LayoutTestController::execCommand):
1456         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1457         (LayoutTestController::queueLoad):
1458         (LayoutTestController::execCommand):
1459
1460 2008-01-03  Alice Liu  <alice.liu@apple.com>
1461
1462         Reviewed by Darin, Mitz.
1463
1464         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
1465
1466         the clickcount should not increase if the last click was at a different location.  it's a new click.
1467
1468         * DumpRenderTree/mac/DumpRenderTree.mm:
1469         (runTest):
1470         * DumpRenderTree/mac/EventSendingController.h:
1471         * DumpRenderTree/mac/EventSendingController.mm:
1472         (-[EventSendingController mouseDown]):
1473         (-[EventSendingController mouseUp]):
1474
1475 2008-01-03  Darin Adler  <darin@apple.com>
1476
1477         Reviewed by Adam.
1478
1479         * Scripts/update-webkit: Make this work a little better for the people at Apple
1480         who have a directory named Internal.
1481
1482 2008-01-03  Adam Roben  <aroben@apple.com>
1483
1484         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
1485
1486         Rubberstamped by Mark.
1487
1488         * Scripts/update-webkit-auxiliary-libs:
1489
1490 2008-01-03  Adam Roben  <aroben@apple.com>
1491
1492         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
1493
1494         http://bugs.webkit.org/show_bug.cgi?id=15663
1495
1496         Added a fuzz factor into the Last-Modified comparison for downloading
1497         WebKitAuxiliaryLibrary.zip.
1498
1499         The zip file is served from a set of mirrors who give Last-Modified
1500         times that are off by 1-3 seconds from each other. This was causing
1501         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1502         which would then cause all of WebCore to rebuild each time.
1503
1504         Reviewed by Mark.
1505
1506         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1507         at least 30 seconds newer than the old one -- otherwise we assume that
1508         the difference in time is due to the mirrors being slightly offset
1509         from each other.
1510         (sub lastModifiedToUnixTime): Added.
1511
1512 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1513
1514         Windows build fix.
1515
1516         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1517
1518 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1519
1520         Reviewed by Lars.
1521
1522         Moved QWebPage::open to QWebFrame::load and added setHtml.
1523         
1524
1525         * DumpRenderTree/qt/DumpRenderTree.cpp:
1526         (WebCore::DumpRenderTree::open):
1527
1528 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1529
1530         Reviewed by Lars.
1531
1532         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1533         
1534
1535         * DumpRenderTree/qt/DumpRenderTree.cpp:
1536         (WebCore::DumpRenderTree::DumpRenderTree):
1537
1538 2008-01-02  Sam Weinig  <sam@webkit.org>
1539
1540         * Scripts/do-webcore-rename: Yet more renaming ideas.
1541
1542 2008-01-02  Darin Adler  <darin@apple.com>
1543
1544         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1545
1546 2008-01-02  Alice Liu  <alice.liu@apple.com>
1547
1548         Reviewed by Sam Weinig.
1549
1550         fixing assertion hit with editing/selection/move-begin-end.html
1551
1552         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1553         * DumpRenderTree/win/DumpRenderTree.vcproj:
1554         * DumpRenderTree/win/EventSender.cpp:
1555         (keyDownCallback):
1556         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1557
1558 2008-01-02  Darin Adler  <darin@apple.com>
1559
1560         * Scripts/do-webcore-rename: Some more name change plans.
1561
1562 2008-01-02  Alice Liu  <alice.liu@apple.com>
1563
1564         Reviewed by Maciej.
1565
1566         Added handling for page up and page down in EventSender
1567
1568         * DumpRenderTree/mac/EventSendingController.mm:
1569         (-[EventSendingController keyDown:withModifiers:]):
1570         * DumpRenderTree/win/EventSender.cpp:
1571         (keyDownCallback):
1572
1573 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1574
1575         Reviewed by Darin.
1576
1577         Fix fast/events/arrow-keys-on-body.html for real.
1578
1579         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1580
1581 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1582
1583         Reviewed by Darin.
1584
1585         http://bugs.webkit.org/show_bug.cgi?id=16674
1586         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1587
1588         * Scripts/run-launcher:
1589
1590 2007-12-31  Darin Adler  <darin@apple.com>
1591
1592         Suggested by Antti.
1593
1594         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1595         we get it installed on the build bots.
1596
1597 2007-12-30  Eric Seidel  <eric@webkit.org>
1598
1599         Reviewed by Sam.
1600
1601         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1602
1603 2007-12-29  Darin Adler  <darin@apple.com>
1604
1605         Reviewed by Oliver.
1606
1607         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1608           leak bot shows createCStringFromNPVariant result leaking
1609
1610         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1611         (pluginInvoke): Added a missing free.
1612
1613 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1614
1615         Reviewed by Alp Toker.
1616
1617         http://bugs.webkit.org/show_bug.cgi?id=16390
1618         Use autotools or GNU make as the build system for the GTK port
1619
1620         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1621         * GNUmakefile.am: Added.
1622
1623 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1624
1625         Reviewed by Oliver.
1626
1627         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1628
1629         * DumpRenderTree/win/EventSender.cpp:
1630         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1631         of 1, even though WebKit currently ignores it.
1632
1633 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1634
1635         wx buildbot fix. Update libpng dl script to the latest version.
1636
1637         * wx/install-unix-extras:
1638
1639 2007-12-22  Antti Koivisto  <antti@apple.com>
1640
1641         Fix a typo.
1642
1643         * Scripts/webkitdirs.pm:
1644
1645 2007-12-21  Sam Weinig  <sam@webkit.org>
1646
1647         Reviewed by Mark Rowe.
1648
1649         - Disable the back/forward cache using the new WebPreferences API
1650           instead of through the BackForwardList.  This makes us match what
1651           we do on Windows.
1652
1653         * DumpRenderTree/mac/DumpRenderTree.mm:
1654         (createWebViewAndOffscreenWindow):
1655         (setDefaultsToConsistentValuesForTesting):
1656
1657 2007-12-21  Dan Bernstein  <mitz@apple.com>
1658
1659         Reviewed by Mark Rowe.
1660
1661         - disable the back/forward cache in Windows DumpRenderTree. It is
1662           already disabled in Mac DumpRenderTree.
1663
1664         * DumpRenderTree/win/DumpRenderTree.cpp:
1665         (initializePreferences):
1666
1667 2007-12-13  Antti Koivisto  <antti@apple.com>
1668
1669         Reviewed by Darin and Steve.
1670         
1671         - check for QuickTime SDK on Windows.
1672         - build media support on Windows by default
1673
1674         * Scripts/build-webkit:
1675         * Scripts/webkitdirs.pm:
1676
1677 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1678
1679         Build script fix for buildbot.
1680
1681         * wx/build-wxwebkit:
1682
1683 2007-12-20  Eric Seidel  <eric@webkit.org>
1684
1685         Reviewed by mjs.
1686
1687         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1688
1689 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1690
1691         Reviewed by Steve.
1692
1693         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1694         WebKit.
1695
1696         - Drosera and Safari need to use the same ProgIDs in order for
1697         CoCreateInstance to work properly.  The most robust way to do this is
1698         for WebKit to dynamically publish those ProgIDs.
1699
1700         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1701         (DebuggerClient::createWebViewWithRequest):
1702         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1703         statics.
1704         (Drosera::initUI):
1705         (Drosera::attach):
1706         (Drosera::attemptToCreateServerConnection):
1707         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1708         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1709         make use of the published ProgIDs.
1710         (ServerConnection::attemptToCreateServerConnection):
1711
1712 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1713
1714         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1715         - Build bot and leak fix.
1716
1717         * DumpRenderTree/LayoutTestController.cpp:
1718         (pathToLocalResourceCallback):
1719
1720 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1721
1722         Make svn-apply/svn-unapply work with patches from git-format-patch.
1723
1724         Reviewed by Darin.
1725
1726         * Scripts/svn-apply:
1727         (patch): If 'Index:' can't be found in the text passed in, print it
1728         out with a warning and return early.
1729         * Scripts/svn-unapply:
1730         (patch): Ditto.
1731
1732 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1733
1734         Reviewed by Alp Toker.
1735
1736         Build related fixes.
1737
1738         * wx/build-wxwebkit:
1739         - Check to make sure the user is running a supported wx port
1740         - More robust checks for Cygwin
1741         - Only run install-unix-extras on Mac, it's not the right solution
1742           for Linux distros.
1743         - Remove outdated Linux instructions after successful build
1744         - Clean Bakefile-generated files during a clean operation
1745
1746 2007-12-18  Darin Adler  <darin@apple.com>
1747
1748         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1749
1750 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1751
1752         Add script to run Drosera as part of the nightly.
1753         
1754         Reviewed by Kevin M.
1755
1756         * Scripts/run-drosera.cmd: Added.
1757
1758 2007-12-18  Darin Adler  <darin@apple.com>
1759
1760         * Scripts/do-webcore-rename: Remove a stray K.
1761
1762 2007-12-18  Darin Adler  <darin@apple.com>
1763
1764         * Scripts/do-webcore-rename: Plan more renaming.
1765
1766 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1767
1768         Reviewed by Alp Toker.
1769
1770         http://bugs.webkit.org/show_bug.cgi?id=16042
1771         [GTK] Eliminate webkit_init()
1772
1773         Moving webkit initialization to WebView class init.
1774
1775         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1776         (main):
1777         * GtkLauncher/main.c:
1778         (main):
1779
1780 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1781
1782         Reviewed by Alp Toker.
1783
1784         http://bugs.webkit.org/show_bug.cgi?id=13542
1785         gdklauncher doesnt change URL in adress GTKEntry.
1786
1787         * GtkLauncher/main.c:
1788         (load_commit_cb): added
1789         (title_change_cb):
1790         (create_browser):
1791
1792 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1793
1794         Reviewed by Adam Roben.
1795
1796         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1797
1798         * FindSafari/FindSafari.cpp:
1799         (_tmain):
1800
1801 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1802
1803         Reviewed by Adam Roben.
1804
1805         http://bugs.webkit.org/show_bug.cgi?id=16315
1806         FindSafari needs a path-only option.
1807
1808         * FindSafari/FindSafari.cpp:
1809         (_tmain):
1810
1811 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1812
1813         Reviewed by Darin.
1814
1815         http://bugs.webkit.org/show_bug.cgi?id=16462
1816         REGRESSION: access keys broken on Windows
1817
1818         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1819         if Alt is pressed.
1820
1821 2007-12-15  Sam Weinig  <sam@webkit.org>
1822
1823         Reviewed by Mark Rowe.
1824
1825         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1826         the case when wstring.find doesn't find anything.
1827
1828         * DumpRenderTree/win/DumpRenderTree.cpp:
1829         (urlSuitableForTestResult):
1830
1831 2007-12-15  Alp Toker  <alp@atoker.com>
1832
1833         GTK+ DRT build fix for GLib < 2.14.
1834
1835         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1836         (LayoutTestController::setWaitToDump):
1837
1838 2007-12-05  Mark Rowe  <mrowe@apple.com>
1839
1840         Reviewed by Alp Toker.
1841
1842         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1843         many layout tests from hanging while waiting on user responses to dialogs.
1844
1845         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1846         (invalidateAnyPreviousWaitToDumpWatchdog):
1847         (webViewScriptAlert):
1848         (webViewScriptPrompt):
1849         (webViewScriptConfirm):
1850         (main):
1851         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1852         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1853         (waitToDumpWatchdogFired):
1854         (LayoutTestController::setWaitToDump):
1855
1856 2007-12-05  Mark Rowe  <mrowe@apple.com>
1857
1858         Reviewed by Alp Toker.
1859
1860         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1861
1862         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1863         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1864         (dump):
1865         (runTest):
1866         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1867         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1868         work queue is empty.
1869         (webViewWindowObjectCleared): Set up window.layoutTestController.
1870         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1871         (main): Hook up the new signals.
1872         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1873         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1874         dumping multiple times.
1875         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1876         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1877
1878 2007-12-14  Anders Carlsson  <andersca@apple.com>
1879
1880         Reviewed by Brady.
1881
1882         Assert that a web frame that's loading a resource always has either a data source or 
1883         a provisional data source.
1884         
1885         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1886         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1887
1888 2007-12-14  Darin Adler  <darin@apple.com>
1889
1890         - fix mistake causing nearly all tests to fail on Windows
1891
1892         * DumpRenderTree/win/UIDelegate.cpp:
1893         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1894         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1895
1896         * DumpRenderTree/mac/UIDelegate.mm:
1897         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1898         than passing the entire message.
1899
1900 2007-12-14  Darin Adler  <darin@apple.com>
1901
1902         - fix Tiger build
1903
1904         * DumpRenderTree/mac/UIDelegate.mm:
1905         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1906         new-to-Leopard methods.
1907
1908 2007-12-14  Darin Adler  <darin@apple.com>
1909
1910         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1911         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1912         delegate methods here.
1913
1914 2007-12-14  Anders Carlsson  <andersca@apple.com>
1915
1916         Reviewed by Darin and Geoff.
1917
1918         <rdar://problem/5619295> 
1919         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1920         
1921         Add property getting methods to the plug-in.
1922         
1923         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1924         (pluginInvoke):
1925
1926 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1927
1928         Reviewed by Darin.
1929
1930         - Layout test fix for mac. When dumped to the console local file paths
1931         now only show the name of the resource not the whole path.  This is to
1932         make the results machine and OS independent.
1933
1934         * DumpRenderTree/mac/UIDelegate.mm:
1935         (-[UIDelegate webView:addMessageToConsole:]):
1936
1937 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1938
1939         Reviewed by Adam.
1940
1941         - Layout tests fix.  We need a way to remove machine-dependent
1942         information from paths in layout test results. The UIDelegate now does
1943         this.
1944
1945         * DumpRenderTree/DumpRenderTree.h:
1946         * DumpRenderTree/win/DumpRenderTree.cpp:
1947         (urlSuitableForTestResult):
1948         * DumpRenderTree/win/DumpRenderTreeWin.h:
1949         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1950         * DumpRenderTree/win/UIDelegate.cpp:
1951         (UIDelegate::webViewAddMessageToConsole):
1952
1953 2007-12-13  Alp Toker  <alp@atoker.com>
1954
1955         Build fix for DRT breakage introduced in r28690.
1956
1957         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1958         (LayoutTestController::pathToLocalResource):
1959
1960 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1961
1962         Reviewed by Alice and Sam.
1963
1964         - <rdar://5621435> Need a way to specify local resources (being loaded
1965         from HTTP tests) on Windows.
1966         - Implemented pathToLocalResource which exposes the functionality of
1967         converting a given unix path to the correct location on Windows.
1968
1969         * DumpRenderTree/LayoutTestController.cpp:
1970         (pathToLocalResourceCallback):
1971         (LayoutTestController::staticFunctions):
1972         * DumpRenderTree/LayoutTestController.h:
1973         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1974         (LayoutTestController::pathToLocalResource):
1975         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1976         (LayoutTestController::pathToLocalResource):
1977
1978 2007-12-12  Anders Carlsson  <andersca@apple.com>
1979
1980         Reviewed by Sam.
1981
1982         <rdar://problem/5132003>
1983         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1984
1985         * DumpRenderTree/win/DumpRenderTree.cpp:
1986         (main):
1987         Set the resource load delegate.
1988         
1989         * DumpRenderTree/win/DumpRenderTree.vcproj:
1990         
1991         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1992         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1993
1994 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1995
1996         Reviewed by Adam Roben.
1997
1998         Fix conversion from double to LPARAM in dispatchMessage().
1999
2000         * DumpRenderTree/win/EventSender.cpp:
2001         (dispatchMessageCallback):
2002
2003 2007-12-11  Dan Bernstein  <mitz@apple.com>
2004
2005         Reviewed by Mark Rowe and Sam Weinig too!
2006
2007         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
2008           fonts DumpRenderTree registers.
2009
2010         * DumpRenderTree/win/DumpRenderTree.cpp:
2011         (initialize):
2012
2013 2007-12-11  Brady Eidson  <beidson@apple.com>
2014
2015         Reviewed by Anders
2016
2017         Make DumpRenderTree on mac use its own path for Databases testing
2018
2019         * DumpRenderTree/mac/DumpRenderTree.mm:
2020         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
2021           for future DRT-only use, then use it to construct the Databases path and set that default
2022
2023 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
2024
2025         Reviewed by Darin.
2026
2027         <rdar://problem/5535636>
2028         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
2029
2030         http://bugs.webkit.org/show_bug.cgi?id=13916
2031         JavaScript detects Tab as a character input on a textfield validation
2032
2033         * DumpRenderTree/mac/EventSendingController.mm:
2034         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
2035         Dispatch a keyup to better match what happens when a key is physically pressed.
2036
2037         * DumpRenderTree/win/EventSender.cpp:
2038         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
2039         returning from keyDown().
2040         (getConstantCallback): Fixed a couple copy/paste mistakes.
2041
2042 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
2043
2044         Reviewed by Oliver.
2045
2046         - <rdar://5599845> Drosera: Does not show loal files in the file list
2047         on the left side.
2048
2049         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
2050         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
2051         so the open source community can build.
2052
2053 2007-12-10  Brady Eidson  <beidson@apple.com>
2054
2055         Rubberstamped by Sam Weinig
2056
2057         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
2058
2059         * DumpRenderTree/mac/UIDelegate.mm:
2060         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2061         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
2062
2063 2007-12-08  Oliver Hunt  <oliver@apple.com>
2064
2065         Reviewed by Sam W.
2066
2067         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
2068         
2069         Fixes <rdar://problem/5620249> Must disable SVG animation
2070         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
2071         
2072         In order to allow finer grained control over the set of SVG features
2073         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
2074         distinct flags:
2075         ENABLE_SVG_ANIMATION
2076         ENABLE_SVG_FILTERS
2077         ENABLE_SVG_FONTS
2078         ENABLE_SVG_AS_IMAGE
2079         ENABLE_SVG_USE
2080         
2081         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
2082         
2083         Script handles all the new build flags, and allows --svg-experimental
2084         to automatically enable all features.
2085
2086         * Scripts/build-webkit:
2087
2088 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
2089
2090         Fix version parsing.
2091
2092         Rubber-stamped by Oliver.
2093
2094         * Drosera/win/Drosera.vcproj/auto-version.sh:
2095
2096 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
2097
2098         Build modifications for Drosera.
2099
2100         Reviewed by Adam.
2101
2102         * Drosera/DroseraWin.make: Added.
2103         * Drosera/win/Drosera.vcproj/Drosera.rc:
2104         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2105         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
2106         * Drosera/win/Drosera.vcproj/VERSION: Added.
2107         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
2108
2109 2007-12-06  Adam Roben  <aroben@apple.com>
2110
2111         Explicitly turn on the Mac font ascent hack on Windows
2112
2113         This keeps our font metrics matching those from Mac.
2114
2115         Reviewed by Hyatt.
2116
2117         * DumpRenderTree/win/DumpRenderTree.cpp:
2118         (main):
2119
2120 2007-12-06  Anders Carlsson  <andersca@apple.com>
2121
2122         Rename main.c to main.cpp here too.
2123         
2124         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
2125
2126 2007-12-06  Sam Weinig  <sam@webkit.org>
2127
2128         Rubber stamped by Geoff.
2129
2130         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
2131
2132 2007-12-06  Darin Adler  <darin@apple.com>
2133
2134         * Scripts/do-webcore-rename: Some more renaming plans.
2135
2136 2007-12-06  Anders Carlsson  <andersca@apple.com>
2137
2138         Restore implementation of testGetIntIdentifier that was accidentally
2139         removed somehow (possibly when I made PluginObject be a cpp file).
2140         
2141         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2142         (pluginInvoke):
2143
2144 2007-12-05  Anders Carlsson  <andersca@apple.com>
2145
2146         Make the entry points extern "C".
2147         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2148         
2149 2007-12-05  Anders Carlsson  <andersca@apple.com>
2150
2151         C++ warning fixes.
2152         
2153         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2154         (NPP_New):
2155         (NPP_Destroy):
2156         (NPP_SetWindow):
2157         (NPP_NewStream):
2158         (NPP_HandleEvent):
2159         (NPP_URLNotify):
2160         (NPP_GetValue):
2161
2162 2007-12-05  Anders Carlsson  <andersca@apple.com>
2163
2164         Add the .cpp files to the TestNetscapePlugIn target.
2165
2166         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2167
2168 2007-12-05  Anders Carlsson  <andersca@apple.com>
2169
2170         Reviewed by Geoff.
2171         
2172         Rename the TestNetscapePlugIn .c files to be .cpp.
2173
2174         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2175         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
2176         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
2177         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
2178         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
2179         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
2180         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
2181         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2182
2183 2007-12-05  Adam Roben  <aroben@apple.com>
2184
2185         Fix case of keypresses from the Windows implementation of eventSender.keyDown
2186
2187         This fixes several regression tests.
2188
2189         Reviewed by Alice.
2190
2191         * DumpRenderTree/win/EventSender.cpp:
2192         (keyDownCallback): Virtual keycodes for ASCII characters are always
2193         uppercase, so we need to check the case of the original character
2194         passed in to eventSender.keyDown.
2195
2196 2007-12-05  Adam Roben  <aroben@apple.com>
2197
2198         Learn from Tim's mistakes
2199
2200         * DumpRenderTree/win/DumpRenderTree.cpp:
2201         (runTest): Reset the authorAndUserStylesEnabled preference for each
2202         test.
2203
2204 2007-12-05  Alp Toker  <alp@atoker.com>
2205
2206         Reviewed by Mark Rowe.
2207
2208         Initialize GTK+ and WebKit so the tests can run.
2209
2210         Reorganize the headers a little.
2211
2212         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2213         (main):
2214
2215 2007-12-04  Anders Carlsson  <andersca@apple.com>
2216
2217         Remove IWebScriptScope include.
2218         
2219         * Drosera/win/DebuggerDocumentPlatform.cpp:
2220
2221 2007-12-04  Sam Weinig  <sam@webkit.org>
2222
2223         Rubber stamped by Mark Rowe.
2224
2225         Define CF as platform for mac and revert r28409
2226
2227         * DumpRenderTree/DumpRenderTree.h:
2228         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2229
2230 2007-12-04  Sam Weinig  <sam@webkit.org>
2231
2232         Define CF as platform for windows.
2233
2234         Reviewed by Adam Roben.
2235
2236         * DumpRenderTree/win/DumpRenderTreeWin.h:
2237
2238 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
2239
2240         Reviewed by Adam and Darin.
2241
2242         - Removed a needless BSTR cleanup.
2243
2244         * Drosera/win/DebuggerDocumentPlatform.cpp:
2245         (DebuggerDocument::getPlatformCurrentFunctionStack):
2246
2247 2007-11-27  Adam Roben  <aroben@apple.com>
2248
2249         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
2250
2251         Reviewed by Maciej.
2252
2253         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2254         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
2255
2256 2007-12-04  Alp Toker  <alp@atoker.com>
2257
2258         Prospective Win DRT build fix.
2259
2260         * DumpRenderTree/DumpRenderTree.h:
2261
2262 2007-12-04  Alp Toker  <alp@atoker.com>
2263
2264         Fix a clobbered copyright header.
2265
2266         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2267
2268 2007-12-04  Xan Lopez  <xan@gnome.org>
2269
2270         Reviewed by Alp Toker.
2271
2272         http://bugs.webkit.org/show_bug.cgi?id=15561
2273         GTK port needs DumpRenderTree implementation
2274
2275         Start work on the GTK+ DRT.
2276
2277         This does not work yet, and there are a few lingering style issues
2278         (nothing major) but this patch has been stuck in the bug tracker for
2279         too long already.
2280
2281         * DumpRenderTree/DumpRenderTree.h:
2282         * DumpRenderTree/gtk: Added.
2283         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
2284         (autocorrectURL):
2285         (shouldLogFrameLoadDelegates):
2286         (dumpFrameScrollPosition):
2287         (displayWebView):
2288         (appendString):
2289         (dumpFramesAsText):
2290         (dumpRenderTreeAsText):
2291         (dump):
2292         (runTest):
2293         (main):
2294         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
2295         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
2296         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
2297         (GCController::collect):
2298         (GCController::collectOnAlternateThread):
2299         (GCController::getJSObjectCount):
2300         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
2301         (LayoutTestController::~LayoutTestController):
2302         (LayoutTestController::addDisallowedURL):
2303         (LayoutTestController::clearBackForwardList):
2304         (LayoutTestController::copyDecodedHostName):
2305         (LayoutTestController::copyEncodedHostName):
2306         (LayoutTestController::display):
2307         (LayoutTestController::keepWebHistory):
2308         (LayoutTestController::notifyDone):
2309         (LayoutTestController::queueBackNavigation):
2310         (LayoutTestController::queueForwardNavigation):
2311         (LayoutTestController::queueLoad):
2312         (LayoutTestController::queueReload):
2313         (LayoutTestController::queueScript):
2314         (LayoutTestController::setAcceptsEditing):
2315         (LayoutTestController::setCustomPolicyDelegate):
2316         (LayoutTestController::setMainFrameIsFirstResponder):
2317         (LayoutTestController::setTabKeyCyclesThroughElements):
2318         (LayoutTestController::setUseDashboardCompatibilityMode):
2319         (LayoutTestController::setUserStyleSheetEnabled):
2320         (LayoutTestController::setUserStyleSheetLocation):
2321         (LayoutTestController::setWindowIsKey):
2322         (LayoutTestController::setWaitToDump):
2323         (LayoutTestController::windowCount):
2324         (LayoutTestController::setPrivateBrowsingEnabled):
2325         (LayoutTestController::setAuthorAndUserStylesEnabled):
2326         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
2327         (JSStringCopyUTF8CString):
2328         (LoadItem::invoke):
2329         (ReloadItem::invoke):
2330         (ScriptItem::invoke):
2331         (BackForwardItem::invoke):
2332
2333 2007-12-03  Sam Weinig  <sam@webkit.org>
2334
2335         Move JavaScriptCore thread testing code to pthread specific directory
2336         and remove the dependance on CoreFoundation by using WTF::HashSet.
2337
2338         Reviewed by Geoff and Oliver.
2339
2340         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2341         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
2342         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
2343         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
2344         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
2345         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
2346         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
2347         * DumpRenderTree/pthreads: Added.
2348         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
2349         (javaScriptThreads):
2350         (runJavaScriptThread):
2351         (startJavaScriptThreads):
2352         (stopJavaScriptThreads):
2353
2354 2007-12-03  Andrew Bonventre  <andybons@google.com>
2355
2356         Reviewed by Darin Adler.
2357
2358         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
2359         Symbol lookup menu broken in debugger view
2360
2361         * Drosera/debugger.js: Fixed javascript error where document property
2362         should have been used instead of contentDocument in switchFunction that
2363         was breaking the select symbol dropdown menu.  This is because
2364         window.frames will return a Window object and not a frame object like
2365         the author was originally expecting.
2366
2367 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
2368
2369         Reviewed by Adam.
2370
2371         - <rdar://5618942> Drosera: Console window does not process everything
2372         correctly.
2373         - <rdar://5619005> Drosera: could be sped up by moving the 
2374         WebScriptScope stuff into the WebScriptCallFrame.
2375         - Now the console can correctly process objects and does not receive
2376         notifications from JavaScriptCore about the JavaScript in Drosera's
2377         own process.
2378
2379         * Drosera/win/DebuggerDocumentPlatform.cpp:
2380         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2381         (DebuggerDocument::platformValueForScopeVariableNamed):
2382
2383 2007-12-03  Stephanie  <slewis@apple.com>
2384
2385         Reviewed by Darin.
2386
2387         Check to see if we are building a debug root
2388
2389         * Scripts/check-for-global-initializers: 
2390
2391 2007-12-03  Dan Bernstein  <mitz@apple.com>
2392
2393         Reviewed by Darin Adler.
2394
2395         - added a testGetIntIdentifier() method to TestNetscapePlugIn
2396
2397         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2398         (pluginInvoke):
2399
2400 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
2401
2402         Reviewed by Oliver.
2403
2404         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
2405         in a more fine-grained manner than eventSender.keyDown().
2406
2407         * DumpRenderTree/win/EventSender.cpp:
2408         (getConstantCallback):
2409         (dispatchMessageCallback):
2410
2411 2007-12-02  Darin Adler  <darin@apple.com>
2412
2413         * Scripts/do-webcore-rename: More planned renaming.
2414
2415 2007-12-02  Sam Weinig  <sam@webkit.org>
2416
2417         Rubber stamped by Anders.
2418
2419         Use [NSURL absoluteString] instead of [NSURL description] in order to get
2420         more uniform results cross platform.
2421
2422         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2423         (-[NSURL _drt_descriptionSuitableForTestResult]):
2424
2425 2007-12-02  Sam Weinig  <sam@webkit.org>
2426
2427         Rubber stamped by Niko.
2428
2429         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
2430
2431         * DumpRenderTree/win/DumpRenderTree.cpp:
2432         * DumpRenderTree/win/DumpRenderTree.vcproj:
2433         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
2434         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
2435         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
2436         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
2437
2438 2007-12-01  Alp Toker  <alp@atoker.com>
2439
2440         Reviewed by Adam Roben.
2441
2442         Make use of the newly introduced webkit.h convenience header.
2443
2444         * GtkLauncher/main.c:
2445
2446 2007-12-01  Adam Treat  <treat@kde.org>
2447
2448         Reviewed by Simon.
2449
2450         * Check to see if the directory exists and exit if not.
2451
2452         * DumpRenderTree/qt/main.cpp:
2453         (main):
2454
2455 2007-12-01  Adam Treat  <treat@kde.org>
2456
2457         Reviewed by Simon.
2458
2459         * Don't hide symbols when in Debug mode
2460         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
2461
2462
2463         * DumpRenderTree/qt/main.cpp:
2464         (messageHandler):
2465
2466 2007-11-30  Alp Toker  <alp@atoker.com>
2467
2468         Reviewed by Adam Roben.
2469
2470         http://bugs.webkit.org/show_bug.cgi?id=15691
2471         [GTK] Public API does not follow GTK+ conventions
2472
2473         Refactor the WebKit/GTK+ public API. Changes:
2474           WebKitPage -> WebKitWebView
2475           WebKitFrame -> WebKitWebFrame
2476
2477         Public API source and header names have been updated to mirror the API
2478         changes.
2479
2480         The API is now kept in WebKit/gtk/WebView to match other ports in the
2481         same class such as Mac and Win.
2482
2483         * GtkLauncher/main.c:
2484         (activate_uri_entry_cb):
2485         (link_hover_cb):
2486         (title_change_cb):
2487         (progress_change_cb):
2488         (go_back_cb):
2489         (go_forward_cb):
2490         (create_browser):
2491         (main):
2492
2493 2007-11-30  Adam Roben  <aroben@apple.com>
2494
2495         Hopefully the final build fix
2496
2497         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2498         pull in WTF's assertion/logging functions.
2499
2500 2007-11-30  Adam Roben  <aroben@apple.com>
2501
2502         Another build fix
2503
2504         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2505         WebKit.lib.
2506
2507 2007-11-30  Adam Roben  <aroben@apple.com>
2508
2509         Debug build fix
2510
2511         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2512         configuration.
2513         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2514         projects.
2515         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2516         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2517         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2518
2519 2007-11-30  Sam Weinig  <sam@webkit.org>
2520
2521         Reviewed by Adam Roben.
2522
2523         Fix drawSelectionRect to actually draw the selection rect.
2524
2525         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2526         (drawSelectionRect):
2527
2528 2007-11-30  Darin Adler  <darin@apple.com>
2529
2530         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2531
2532 2007-11-30  Darin Adler  <darin@apple.com>
2533
2534         * Scripts/do-webcore-rename: Get ready for some future renaming.
2535
2536 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2537
2538         Reviewed by Adam.
2539
2540         - Removed some unnecessary functions and changed an unused return type. 
2541
2542         * Drosera/win/DebuggerClient.cpp:
2543         (registerConsoleClass):
2544         * Drosera/win/DebuggerClient.h:
2545         * Drosera/win/Drosera.cpp:
2546         (registerDroseraClass):
2547
2548 2007-11-28  Alp Toker  <alp@atoker.com>
2549
2550         Reviewed by Timothy Hatcher.
2551
2552         http://bugs.webkit.org/show_bug.cgi?id=16174
2553         [GTK] Use "URI" not "URL" in public API
2554
2555         Replace use of the term "URL" with "URI" in public headers,
2556         documentation and some internal code to match GLib/GTK+ convention.
2557
2558         This is now mentioned in the API guidelines:
2559           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2560
2561         * GtkLauncher/main.c:
2562         (activate_uri_entry_cb):
2563         (title_change_cb):
2564         (create_toolbar):
2565         (main):
2566
2567 2007-11-29  Anders Carlsson  <andersca@apple.com>
2568
2569         Reviewed by Sam.
2570
2571         <rdar://problem/5230478>
2572         FrameLoadDelegate callbacks are not dumped in DRT.
2573         
2574         * DumpRenderTree/win/DumpRenderTree.cpp:
2575         (shouldLogFrameLoadDelegates):
2576         (runTest):
2577         (main):
2578         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2579         (BSTRtoString):
2580         (descriptionSuitableForTestResult):
2581         (FrameLoadDelegate::QueryInterface):
2582         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2583         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2584         (FrameLoadDelegate::didCommitLoadForFrame):
2585         (FrameLoadDelegate::didFinishLoadForFrame):
2586         (FrameLoadDelegate::willCloseFrame):
2587         (FrameLoadDelegate::didClearWindowObject):
2588         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2589         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2590         * DumpRenderTree/win/FrameLoaderDelegate.h:
2591         (FrameLoadDelegate::windowScriptObjectAvailable):
2592         (FrameLoadDelegate::didFirstLayoutInFrame):
2593
2594 2007-11-29  Sam Weinig  <sam@webkit.org>
2595
2596         Reviewed by Anders.
2597
2598         Add database quota UIDelegates methods to DRT UIDelegate.
2599
2600         * DumpRenderTree/mac/UIDelegate.mm:
2601         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2602         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2603
2604 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2605
2606         Reviewed by Sam.
2607
2608         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2609         dying and vice versa.
2610         - This fix will allow Drosera and Safari to reconnect if either of them
2611         closes correctly, but does not fix the case where one of them dies
2612         silently.
2613
2614         * Drosera/win/ServerConnection.cpp:
2615         (ServerConnection::attemptToCreateServerConnection): Added a safety
2616         check, because it's possilbe to try to connect to a server that's dying.
2617         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2618         the server has died.
2619         * Drosera/win/ServerConnection.h: Added the new function and removed
2620         an unnecessary member.
2621
2622 2007-11-29  Anders Carlsson  <andersca@apple.com>
2623
2624         * DumpRenderTree/win/DumpRenderTree.vcproj:
2625         Add shlwapi.lib to all configurations.
2626
2627 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2628
2629         - Build fix.  Added additional includes for VS Express to the Release
2630         project.
2631
2632         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2633
2634 2007-11-29  Anders Carlsson  <andersca@apple.com>
2635
2636         Reviewed by Adam.
2637
2638         <rdar://problem/5132005>
2639         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2640         
2641         * DumpRenderTree/win/DumpRenderTree.vcproj:
2642         Add shlwapi.lib
2643         
2644         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2645         (LayoutTestController::setUserStyleSheetEnabled):
2646         Implement this.
2647         
2648         (appendComponentToPath):
2649         New method which wraps the Win32 API PathAppend.
2650         
2651         (followShortcuts):
2652         New method which checks if a file points to a shortcut and
2653         follows the shortcut.
2654         
2655         (resolveCygwinPath):
2656         New method that takes a cygwin unix-style path and returns the Win32 path.
2657         
2658         (cfStringRefToWString):
2659         
2660         (LayoutTestController::setUserStyleSheetLocation):
2661         Implement this.
2662
2663 2007-11-29  Alice Liu  <alice.liu@apple.com>
2664
2665         Reviewed by Adam.
2666
2667         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2668
2669         * DumpRenderTree/win/EventSender.cpp:
2670         (keyDownCallback):
2671         uppercase letters were being sent as lowercase letters without the shift key down.
2672
2673 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2674
2675         - Windows build fix. VS express needs some love.
2676
2677         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2678
2679 2007-11-28  Darin Adler  <darin@apple.com>
2680
2681         Reviewed by Adam Roben.
2682
2683         * DumpRenderTree/mac/EventSendingController.mm:
2684         (-[EventSendingController keyDown:withModifiers:]):
2685         Send capital letters through as lowercase letters with the shift key down
2686         rather than sending them as if they were highly unusual "capital letter keys".
2687
2688         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2689         where you need to update results and more tests are failing than before.
2690
2691 2007-11-28  Anders Carlsson  <andersca@apple.com>
2692
2693         Reviewed by Darin.
2694
2695         <rdar://problem/5132001>
2696         contextClick is not implemented in DRT on Windows.
2697         
2698         * DumpRenderTree/win/EventSender.cpp:
2699         (contextClickCallback):
2700         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2701         by a WM_RBUTTONUP message.
2702         
2703         * DumpRenderTree/win/UIDelegate.cpp:
2704         (UIDelegate::hasCustomMenuImplementation):
2705         (UIDelegate::trackCustomPopupMenu):
2706         * DumpRenderTree/win/UIDelegate.h:
2707         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2708         menu from being shown (and causing the DRT to hang).
2709
2710 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2711
2712         Reviewed by Darin.
2713
2714         Fix DumpRenderTree ObjC bug comparing strings.
2715
2716         * DumpRenderTree/mac/ObjCController.m:
2717         (-[ObjCController identityIsEqual::]): Compare strings with string
2718         equality instead of identiy equality.
2719
2720 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2721
2722         Reviewed by Sam.
2723
2724         Reset the authorAndUserStylesEnabled preference
2725         back to YES for each test. Fixes the broken tests.
2726
2727         * DumpRenderTree/mac/DumpRenderTree.mm:
2728         (resetWebViewToConsistentStateBeforeTesting):
2729
2730 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2731
2732         Reviewed by Adam.
2733
2734         - Drosera now displays the console window, although it cannot currently
2735         process JavaScript.
2736
2737         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2738         (registerConsoleClass): Implemented.
2739         (consoleWndProc): Implemented.
2740         (DebuggerClient::onSize): Implemented.
2741         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2742         new window.
2743         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2744         creating and maintaining a new window.
2745         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2746         lines of code to more appropriate places.
2747         (Drosera::handleCommand):
2748         (Drosera::initUI):
2749         (Drosera::onSize):
2750         (Drosera::attach):
2751
2752 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2753
2754         Reviewed by Dave Hyatt.
2755
2756         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2757         
2758         Add support for disabling author and user styles for testing.
2759
2760         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2761         * DumpRenderTree/LayoutTestController.cpp:
2762         (setAuthorAndUserStylesEnabledCallback):
2763         (LayoutTestController::staticFunctions):
2764         * DumpRenderTree/LayoutTestController.h:
2765         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2766         (LayoutTestController::setAuthorAndUserStylesEnabled):
2767         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2768         (LayoutTestController::setAuthorAndUserStylesEnabled):
2769
2770 2007-11-26  Dan Bernstein  <mitz@apple.com>
2771
2772         - Tiger build fix.
2773
2774         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2775
2776 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2777
2778         Reviewed by Maciej.
2779
2780         - Implemented displaying variables for Drosera on Win.
2781
2782         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2783         that retrieve variables to not hold onto the return value since it's
2784         not returned.  Also changed to use the new signatures of the retrieval
2785         functions.
2786         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2787         (DebuggerDocument::platformValueForScopeVariableNamed):
2788         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2789         (droseraWndProc):
2790
2791 2007-11-26  Sam Weinig  <sam@webkit.org>
2792
2793         Cleanup names of painting and repainting functions.
2794
2795         Reviewed by Adam Roben.
2796
2797         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2798         (drawSelectionRect): was drawSelectionRectIntoContext.
2799         (dumpWebViewAsPixelsAndCompareWithExpected):
2800         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2801         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2802         (paintWebView): was drawWebViewIntoContext.
2803         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2804
2805 2007-11-26  Sam Weinig  <sam@webkit.org>
2806
2807         Reviewed by Dan Bernstein.
2808
2809         - Leopard build fix
2810
2811         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2812
2813 2007-11-26  Sam Weinig  <sam@webkit.org>
2814
2815         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2816         Use shared PixelDumpSupport for Mac DRT
2817
2818         Reviewed by Adam Roben.
2819
2820         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2821         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2822         * DumpRenderTree/cg/ImageDiffCG.cpp:
2823         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2824         (drawSelectionRectIntoContext):
2825         (dumpWebViewAsPixelsAndCompareWithExpected):
2826         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2827         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2828         * DumpRenderTree/mac/DumpRenderTree.mm:
2829         (dump):
2830         * DumpRenderTree/mac/ImageDiff.m: Removed.
2831         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2832         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2833         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2834         (setDefaultColorProfileToRGB):
2835         (getBitmapContextFromWebView):
2836         (drawWebViewIntoContext):
2837         (repaintWithVerticalSweep):
2838         (repaintWithHorizontalSweep):
2839         (getSelectionRect):
2840         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2841
2842 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2843
2844         Bug 16052: prepare-ChangeLog doesn't report deleted files
2845         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2846
2847         Reviewed by Sam.
2848
2849         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2850
2851 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2852
2853         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2854         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2855
2856         Reviewed by Adam.
2857
2858         Roll functionality of merge-changelog into resolve-ChangeLogs
2859         script.  The script now checks for ChangeLog.rej and
2860         ChangeLog.orig files first.  If it finds them, it uses the
2861         ChangeLog.rej file as a patch (in old contextual diff format) to
2862         apply with --fuzz=3.
2863
2864         * Scripts/merge-changelog: Removed.
2865         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2866
2867 2007-11-25  Sam Weinig  <sam@webkit.org>
2868
2869         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2870
2871         Reviewed by Mark Rowe.
2872
2873         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2874         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2875         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2876         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2877         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2878
2879 2007-11-25  Sam Weinig  <sam@webkit.org>
2880
2881         Convert DumpRenderTree to ues .xcconfig files.
2882
2883         Reviewed by Mark Rowe.
2884
2885         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2886         * DumpRenderTree/mac/Configurations: Added.
2887         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2888         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2889         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2890
2891 2007-11-25  Sam Weinig  <sam@webkit.org>
2892
2893         Add ForwardingHeaders to wtf for DumpRenderTree.
2894
2895         Reviewed by Mark Rowe.
2896
2897         * DumpRenderTree/DumpRenderTree.h:
2898         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2899         * DumpRenderTree/ForwardingHeaders: Added.
2900         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2901         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2902         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2903         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2904         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2905         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2906         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2907         * DumpRenderTree/LayoutTestController.cpp:
2908         * DumpRenderTree/WorkQueue.cpp:
2909         * DumpRenderTree/mac/DumpRenderTree.mm:
2910         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2911         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2912         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2913         * DumpRenderTree/mac/ObjCController.m:
2914         * DumpRenderTree/mac/UIDelegate.mm:
2915         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2916
2917 2007-11-25  Adam Roben  <aroben@apple.com>
2918
2919         Fix some test failures caused by r28019
2920
2921         Now that stdout is in binary mode, we need to always use printf
2922         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2923         the output.
2924
2925         Reviewed by Sam.
2926
2927         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2928         printf.
2929         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2930         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2931         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2932         (UIDelegate::webViewAddMessageToConsole):
2933
2934 2007-11-25  Adam Roben  <aroben@apple.com>
2935
2936         Set the font smoothing preference in DRT
2937
2938         This makes the pixel results on Windows closer to the Mac results.
2939
2940         Reviewed by Mitz.
2941
2942         * DumpRenderTree/win/DumpRenderTree.cpp:
2943         (initializePreferences):
2944
2945 2007-11-25  Adam Roben  <aroben@apple.com>
2946
2947         Port ImageDiff to CG and C++
2948
2949         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2950         <rdar://5071708>
2951
2952         Reviewed by Sam.
2953
2954         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2955         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2956         (main):
2957         (createImageFromStdin):
2958         (compareImages):
2959         (getDifferenceBitmap):
2960         (computePercentageDifferent):
2961         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2962
2963 2007-11-25  Adam Roben  <aroben@apple.com>
2964
2965         Fix image diff link generation on Windows
2966
2967         Reviewed by Sam.
2968
2969         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2970         to toURL.
2971
2972 2007-11-25  Adam Roben  <aroben@apple.com>
2973
2974         Implement pixel dumping in Windows DRT
2975
2976         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2977         <rdar://5071708>
2978
2979         Reviewed by Sam.
2980
2981         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2982         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2983         Content-Length header.
2984         (getMD5HashStringForBitmap):
2985         (dumpWebViewAsPixelsAndCompareWithExpected):
2986         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2987         * DumpRenderTree/win/DumpRenderTree.cpp:
2988         (dump): Do a pixel dump if requested.
2989         (main): Parse pixel test options.
2990         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2991         the cg/ subdirectory to the include path.
2992         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2993         available in a header or import library, so we have to go through this
2994         LoadLibrary/GetProcAddress dance to use them.
2995         (cryptDLL):
2996         (init):
2997         (update):
2998         (final):
2999         (MD5_Init):
3000         (MD5_Update):
3001         (MD5_Final):
3002         * DumpRenderTree/win/MD5.h: Added.
3003         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
3004         moved up to the top level to share it with Mac eventually.
3005         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
3006         (getBitmapContextFromWebView): Forces the WebView to paint using a
3007         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
3008
3009 2007-11-25  Adam Roben  <aroben@apple.com>
3010
3011         Clean up Windows DRT's option parsing a little bit
3012
3013         Reviewed by Sam.
3014
3015         * DumpRenderTree/win/DumpRenderTree.cpp:
3016         (main): Put non-option arguments into a Vector.
3017
3018 2007-11-25  Adam Roben  <aroben@apple.com>
3019
3020         Make Windows DRT stop changing LF into CRLF
3021
3022         Reviewed by Sam.
3023
3024         * DumpRenderTree/win/DumpRenderTree.cpp:
3025         (main): Put stdout in binary mode.
3026         * Scripts/run-webkit-tests: Remove the CRLF hack.
3027
3028 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
3029
3030         Removed empty directory.
3031
3032         * Scripts/resources: Removed.
3033
3034 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
3035
3036         Fix bisect-builds to work with recent WebKit nightly builds.
3037
3038         Reviewed by Dan.
3039
3040         * Scripts/bisect-builds: Check for the 
3041         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
3042         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
3043         to WebKit.app/Contents/Resources.
3044
3045 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
3046
3047         Reviewed by Maciej.
3048
3049         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
3050         not closed (affects digg.com)
3051
3052         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
3053         one after finishing with a test to avoid having its delayed onload handler firing when
3054         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
3055         but it helps somewhat.
3056
3057 2007-11-22  Mark Rowe  <mrowe@apple.com>
3058
3059         Reviewed by Alp Toker.
3060
3061         Fix build-webkit to propagate make's exit status if it fails.
3062
3063         * Scripts/webkitdirs.pm:
3064
3065 2007-11-22  Dan Bernstein  <mitz@apple.com>
3066
3067         Reviewed by Mark Rowe.
3068
3069         - fix crash when running pixel tests
3070
3071         * DumpRenderTree/mac/DumpRenderTree.mm:
3072         (dumpRenderTree): Parse the command line options before setting up the
3073         environment so that we know if we need to set up the pixel dump
3074         machinery.
3075
3076 2007-11-21  Eric Seidel  <eric@webkit.org>
3077
3078         Speculative build fix for Tiger.
3079
3080         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
3081
3082 2007-11-21  Eric Seidel  <eric@webkit.org>
3083
3084         Reviewed by Tim Hatcher.
3085
3086         Break out more of DumpRenderTree.mm into individual files
3087
3088         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3089         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
3090         (checkedMalloc):
3091         (checkedRealloc):
3092         (makeLargeMallocFailSilently):
3093         * DumpRenderTree/mac/CheckedMalloc.h: Added.
3094         * DumpRenderTree/mac/DumpRenderTree.mm:
3095         (crashHandler):
3096         (dump):
3097         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3098         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3099         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3100         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3101         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3102         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
3103         (javaScriptThreads):
3104         (runJavaScriptThread):
3105         (startJavaScriptThreads):
3106         (stopJavaScriptThreads):
3107         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
3108         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
3109         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
3110         (restoreColorSpace):
3111         (setDefaultColorProfileToRGB):
3112         (initializeColorSpaceAndScreeBufferForPixelTests):
3113         (md5HashStringForBitmap):
3114         (dumpWebViewAsPixelsAndCompareWithExpected):
3115
3116 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
3117
3118         Move install-unix-extras to wx directory as it seems only to be used by that 
3119         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
3120         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
3121         have install-unix-extras install into WebKitLibraries as per
3122         convention.
3123         
3124         Reviewed by Mark Rowe.
3125
3126         * Scripts/install-unix-extras: Removed.
3127         * wx/build-wxwebkit:
3128         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
3129
3130 2007-11-21  Eric Seidel  <eric@webkit.org>
3131
3132         Reviewed by Adam.
3133
3134         More refactoring for greater code readability
3135
3136         * DumpRenderTree/mac/DumpRenderTree.mm:
3137         (initializeGlobalsFromCommandLineOptions):
3138         (initializeColorSpaceAndScreeBufferForPixelTests):
3139         (addTestPluginsToPluginSearchPath):
3140         (useLongRunningServerMode):
3141         (runTestingServerLoop):
3142         (prepareConsistentTestingEnvironment):
3143         (dumpRenderTree):
3144         (main):
3145         (dumpFramesAsText):
3146         (dumpBackForwardListForWebView):
3147         (sizeWebViewForCurrentTest):
3148         (methodNameStringForFailedTest):
3149         (dumpBackForwardListForAllWindows):
3150         (dumpWebViewAsPixelsAndCompareWithExpected):
3151         (invalidateAnyPreviousWaitToDumpWatchdog):
3152         (dump):
3153         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3154         * DumpRenderTree/mac/UIDelegate.mm:
3155         (-[UIDelegate webView:createWebViewWithRequest:]):
3156
3157 2007-11-21  Eric Seidel  <eric@webkit.org>
3158
3159         Reviewed by Tim Hatcher.
3160
3161         Abstract more of DRT into static methods
3162
3163         * DumpRenderTree/mac/DumpRenderTree.mm:
3164         (setDefaultsToConsistentValuesForTesting):
3165         (setupSignalHandlers):
3166         (allocateGlobalControllers):
3167         (releaseAndZero):
3168         (releaseGlobalControllers):
3169         (dumpRenderTree):
3170         (shouldLogFrameLoadDelegates):
3171         (createCFURLFromPathOrURL):
3172         (resetWebViewToConsistentStateBeforeTesting):
3173         (runTest):
3174
3175 2007-11-21  Eric Seidel  <eric@webkit.org>
3176
3177         Reviewed by Tim Hatcher.
3178
3179         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
3180
3181         * DumpRenderTree/DumpRenderTree.h:
3182         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3183         * DumpRenderTree/mac/DumpRenderTree.mm:
3184         (dumpRenderTree):
3185         (dump):
3186         (runTest):
3187         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
3188         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
3189         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
3190         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
3191         (-[DumpRenderTreePasteboard declareType:owner:]):
3192         (+[LocalPasteboard alloc]):
3193         (-[LocalPasteboard init]):
3194         (-[LocalPasteboard dealloc]):
3195         (-[LocalPasteboard name]):
3196         (-[LocalPasteboard releaseGlobally]):
3197         (-[LocalPasteboard declareTypes:owner:]):
3198         (-[LocalPasteboard addTypes:owner:]):
3199         (-[LocalPasteboard changeCount]):
3200         (-[LocalPasteboard types]):
3201         (-[LocalPasteboard availableTypeFromArray:]):
3202         (-[LocalPasteboard setData:forType:]):
3203         (-[LocalPasteboard dataForType:]):
3204         (-[LocalPasteboard setPropertyList:forType:]):
3205         (-[LocalPasteboard setString:forType:]):
3206         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
3207         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
3208         (+[DumpRenderTreeWindow allWindows]):
3209         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3210         (-[DumpRenderTreeWindow dealloc]):
3211         (-[DumpRenderTreeWindow isKeyWindow]):
3212         (-[DumpRenderTreeWindow keyDown:]):
3213
3214 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
3215
3216         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
3217         it indiscriminately copies any headers inside JavaScriptCore,
3218         which includes Tiger ICU headers. 
3219
3220         * wx/build-wxwebkit:
3221         Don't run WebCore/move-js-headers.sh any longer.
3222
3223 2007-11-20  Adam Treat  <treat@kde.org>
3224
3225         Reviewed by David Kilzer.
3226
3227         * Prepend git branch name to $baseProductDir
3228
3229         * Scripts/VCSUtils.pm:
3230         * Scripts/webkitdirs.pm:
3231
3232 2007-11-20  Mark Rowe  <mrowe@apple.com>
3233
3234         Reviewed by Simon Hausmann.
3235
3236         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
3237         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
3238         Have it trigger a "make distclean" rather than "make clean" to ensure that the
3239         built product and generated Makefile's are removed.
3240
3241 2007-11-19  Alp Toker  <alp@atoker.com>
3242
3243         Reviewed by Mark Rowe.
3244
3245         http://bugs.webkit.org/show_bug.cgi?id=16040
3246         [GTK] GtkLauncher should be written in C
3247
3248         Port GtkLauncher to plain C.
3249
3250         Use a more conventional GTK+ coding style.
3251
3252         Use a toolbar instead of menus.
3253
3254         Various signature fixes and cleanups.
3255
3256         Add a license header. Assume all previous modifications were copyright
3257         assigned to Apple Inc. by default.
3258
3259         * GtkLauncher/GtkLauncher.pro:
3260         * GtkLauncher/main.c: Added.
3261         (activate_url_entry_cb):
3262         (update_title):
3263         (link_hover_cb):
3264         (title_change_cb):
3265         (progress_change_cb):
3266         (destroy_cb):
3267         (go_back_cb):
3268         (go_forward_cb):
3269         (create_browser):
3270         (create_statusbar):
3271         (create_toolbar):
3272         (create_window):
3273         (main):
3274         * GtkLauncher/main.cpp: Removed.
3275
3276 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
3277
3278         Build script fixes to ensure they do the right thing for the 
3279         wx port, and update build-wxwebkit to reflect the way the
3280         build scripts now work.
3281
3282         Reviewed by Adam.
3283
3284         * Scripts/build-testkjs:
3285         * Scripts/build-webkit:
3286         * Scripts/run-javascriptcore-tests:
3287         * Scripts/webkitdirs.pm:
3288         * wx/build-wxwebkit:
3289
3290 2007-11-18  Eric Seidel  <eric@webkit.org>
3291
3292         Reviewed by Anders.
3293
3294         Make run-javascriptcore-tests report failures on exit (to support git bisect)
3295
3296         * Scripts/run-javascriptcore-tests:
3297
3298 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
3299
3300         Reviewed by Adam Roben.
3301
3302         Make run-webkit-tests work with Windows debug build.
3303
3304         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
3305         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
3306         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
3307         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
3308         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
3309
3310 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
3311
3312         Add wxWebKit sample and build script, and integrate it with 
3313         build-webkit. Also make build-webkit --clean work for all
3314         ports.
3315
3316         Reviewed by Darin Adler.
3317
3318         * Scripts/build-webkit:
3319         * Scripts/webkitdirs.pm:
3320         * wx: Added.
3321         * wx/browser: Added.
3322         * wx/browser/browser.bkl: Added.
3323         * wx/browser/browser.cpp: Added.
3324         * wx/build-wxwebkit: Added.
3325
3326 2007-11-17  Adam Roben  <aroben@apple.com>
3327
3328         Make it easy to run Safari in the debugger on Windows
3329
3330         I've added a new script, debug-safari, which launches Safari in the
3331         debugger. On OS X it just calls gdb-safari.
3332
3333         Reviewed by Mark Rowe.
3334
3335         * FindSafari/FindSafari.cpp:
3336         (_tmain): Added a /debugger flag, which in combination with
3337         /printSafariLauncher will print a script that launches Safari in the
3338         debugger.
3339         * Scripts/debug-safari: Added.
3340         * Scripts/run-safari: Changed to call runSafari().
3341         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
3342         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
3343         first argument along to FindSafari.
3344         * Scripts/webkitdirs.pm:
3345         (sub runSafari): Added.
3346
3347 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
3348
3349         Reviewed by Adam Roben.
3350
3351         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
3352
3353 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
3354
3355         Reviewed by David Kilzer.
3356
3357         The git config command was renamed to repo-config at some point. This
3358         change tries git config and then git repo-config if the first fails.
3359
3360         * Scripts/prepare-ChangeLog:
3361         (gitConfig):
3362
3363 2007-11-16  Dan Bernstein  <mitz@apple.com>
3364
3365         Reviewed by Darin Adler and Sam Weinig.
3366
3367         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
3368
3369         * DumpRenderTree/win/EventSender.cpp:
3370         (keyDownCallback): For characters that cannot be entered on the active
3371         keyboard layout, send a WM_CHAR message with the character along with
3372         a WM_KEYDOWN message with a virtual key code of 255.
3373
3374 2007-11-16  Mark Rowe  <mrowe@apple.com>
3375
3376         Reviewed by Tim Hatcher.
3377
3378         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
3379
3380         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3381         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3382
3383 2007-11-15  Adam Roben  <aroben@apple.com>
3384
3385         Make run-safari actually work on Windows
3386
3387         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
3388         chdir call.
3389
3390 2007-11-14  Adam Roben  <aroben@apple.com>
3391
3392         Updates to Safari launching now that 3.0.4 is released
3393
3394         Reviewed by Sam.
3395
3396         * FindSafari/FindSafari.cpp:
3397         (getWebViewCLSID): Use version-independent ProgID.
3398         * Scripts/run-safari: Use run-webkit-nightly.cmd.
3399
3400 2007-11-14  Anders Carlsson  <andersca@apple.com>
3401
3402         Reviewed by Adam.
3403
3404         <rdar://problem/5309081>
3405         In DRT, "plugin.logDestroy = true" not working on Windows.
3406         
3407         * DumpRenderTree/win/TestNetscapePlugin/main.c:
3408         (NPP_Destroy):
3409
3410 2007-11-14  Eric Seidel  <eric@webkit.org>
3411
3412         Reviewed by Sam.
3413
3414         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
3415
3416 2007-11-14  Anders Carlsson  <andersca@apple.com>
3417
3418         Reviewed by Adam.
3419
3420         <rdar://problem/5141186>
3421         window.layoutTestController.setWindowIsKey is not implemented in DRT.
3422         
3423         Implement setWindowIsKey.
3424         
3425         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3426         (LayoutTestController::setWindowIsKey):
3427
3428 2007-11-13  Sam Weinig  <sam@webkit.org>
3429
3430         Reviewed by Adam Roben.
3431
3432         Fix for <rdar://problem/5382579>
3433         http/tests/security/cross-frame-access-put.html reports large 
3434         negative numbers for screenLeft and screenTop (Mac reports "0")
3435
3436         * DumpRenderTree/win/UIDelegate.cpp:
3437         (UIDelegate::UIDelegate): Initialize the RECT.
3438         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
3439         (UIDelegate::webViewFrame): ditto.
3440         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
3441
3442 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
3443
3444         Reviewed by Adam.
3445
3446         - Make Drosera show source, source URLs, and function stack on Windows,
3447         and some minor fixes.
3448
3449         * Drosera/DebuggerDocument.cpp: Force source to always update display.
3450         (DebuggerDocument::updateFileSource):
3451         * Drosera/debugger.js: Force source to always update display.
3452         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
3453         menu controls.
3454         (DebuggerClient::resume):
3455         (DebuggerClient::pause):
3456         (DebuggerClient::stepInto):
3457         (DebuggerClient::stepOver):
3458         (DebuggerClient::stepOut):
3459         (DebuggerClient::showConsole):
3460         (DebuggerClient::closeCurrentFile):
3461         * Drosera/win/DebuggerClient.h: Ditto.
3462         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
3463         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
3464         removed two bugs.  1) caller could be in a bad state when asked to
3465         assign into it. 2) BSTRs were not created correctly.
3466         (DebuggerDocument::getPlatformCurrentFunctionStack):
3467         * Drosera/win/Drosera.cpp: Hook up the menu controls.
3468         (droseraWndProc):
3469         (handleCommand):
3470         (Drosera::resume):
3471         (Drosera::pause):
3472         (Drosera::stepInto):
3473         (Drosera::stepOver):
3474         (Drosera::stepOut):
3475         (Drosera::showConsole):
3476         (Drosera::closeCurrentFile):
3477         * Drosera/win/Drosera.h: Hook up the menu controls.
3478         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
3479         functions, added a null check, and fixed another bug where caller could
3480         be in a bad state when asked to assign into it.
3481         (ServerConnection::didLoadMainResourceForDataSource):
3482         (ServerConnection::getCallerFrame):
3483         * Drosera/win/ServerConnection.h: Safety first.
3484
3485 2007-11-13  Dan Bernstein  <mitz@apple.com>
3486
3487         Reviewed by Darin Adler.
3488
3489         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
3490           DumpRenderTree --pixel-tests renders each test twice
3491
3492         * DumpRenderTree/mac/DumpRenderTree.mm:
3493         (dumpRenderTree): Removed the --paint option because the painting code
3494         is always exercised as a result of
3495         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
3496         calling -displayIfNeeded.
3497         (dump): Changed to always grab the image from the window since the view
3498         is always displayed.
3499         (runTest):
3500         (displayWebView):
3501         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3502         because it always paints.
3503
3504 2007-11-12  Antti Koivisto  <antti@apple.com>
3505
3506         Reviewed by Adele.
3507         
3508         Add support for http media tests
3509
3510         * Scripts/run-webkit-tests:
3511
3512 2007-11-12  Sam Weinig  <sam@webkit.org>
3513
3514         Reviewed by Adam Roben.
3515
3516         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3517
3518         * DumpRenderTree/win/DumpRenderTree.cpp:
3519         (runTest):
3520         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3521         (LayoutTestController::setPrivateBrowsingEnabled):
3522
3523 2007-11-12  Adam Roben  <aroben@apple.com>
3524
3525         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3526         mac and win subdirectories.
3527
3528 2007-11-11  Adam Roben  <aroben@apple.com>
3529
3530         Fix <rdar://5133816> keepWebHistory is not implemented
3531
3532         Fixes fast/history/clicked-link-is-visited.html.
3533
3534         Reviewed by Darin.
3535
3536         * DumpRenderTree/win/DumpRenderTree.cpp:
3537         (runTest): Clear the optionalSharedHistory.
3538         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3539         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3540
3541 2007-11-10  Sam Weinig  <sam@webkit.org>
3542
3543         Reviewed by Tim Hatcher.
3544
3545         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
3546         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
3547         is turned on)
3548
3549         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3550
3551         Added test: http/tests/security/cross-frame-access-private-browsing.html
3552
3553         * DumpRenderTree/LayoutTestController.cpp:
3554         (setPrivateBrowsingEnabledCallback):
3555         (LayoutTestController::staticFunctions):
3556         * DumpRenderTree/LayoutTestController.h:
3557         * DumpRenderTree/mac/DumpRenderTree.mm:
3558         (runTest): Default to private browsing disabled.
3559         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3560         (LayoutTestController::setPrivateBrowsingEnabled):
3561         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3562         (LayoutTestController::setPrivateBrowsingEnabled):
3563
3564 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3565
3566         Reviewed by Adam.
3567
3568         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3569         WebCore's!
3570
3571         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3572         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3573         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3574         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3575         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3576         * Drosera/win/Drosera.cpp:
3577         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3578
3579 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3580
3581         Reviewed by Sam.
3582
3583         - Use the new IWebFrame [local] function signature and get the shared
3584         server correctly.
3585
3586         * Drosera/win/DebuggerClient.cpp:
3587         (DebuggerClient::didFinishLoadForFrame):
3588         * Drosera/win/ServerConnection.cpp:
3589         (ServerConnection::attemptToCreateServerConnection):
3590
3591 2007-11-07  Dan Bernstein  <mitz@apple.com>
3592
3593         Reviewed by Darin Adler.
3594
3595         - add an option to run-webkit-tests to ignore pixel test failures where
3596           all pixels differ by no more than a specified threshold
3597
3598         * DumpRenderTree/mac/ImageDiff.m:
3599         (main):
3600         (compareImages):
3601         (computePercentageDifferent):
3602         * Scripts/run-webkit-tests:
3603
3604 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3605
3606         Reviewed by Lars.
3607
3608         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3609
3610         * DumpRenderTree/qt/DumpRenderTree.cpp:
3611
3612 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3613
3614         Reviewed by Lars.
3615
3616         Reworked the QWebSettings API.
3617         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3618
3619         * DumpRenderTree/qt/DumpRenderTree.cpp:
3620
3621 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3622
3623         Reviewed by Lars.
3624
3625         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3626
3627         * DumpRenderTree/qt/jsobjects.cpp:
3628
3629 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3630
3631         Reviewed by Lars Knoll <lars@trolltech.com>.
3632
3633         Add a QWebPage::frameCreated() signal and fix DRT
3634         
3635         The removal of createFrame in QWebPage broke the re-implementation
3636         in DumpRenderTree. Instead emit a frameCreated() signal and
3637         connect to it in DumpRenderTree.
3638         
3639
3640         * DumpRenderTree/qt/DumpRenderTree.cpp:
3641         (WebCore::WebPage::WebPage):
3642         (WebCore::DumpRenderTree::dump):
3643         (WebCore::DumpRenderTree::connectFrame):
3644         * DumpRenderTree/qt/DumpRenderTree.h:
3645
3646 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3647
3648         Reviewed by Lars Knoll <lars@trolltech.com>.
3649
3650         Moved all the event handlers from QWebFrame into QWebPage.
3651         
3652         This cleans up the public API and allows us to remove the
3653         HackWebFrame hack in DumpRenderTree.
3654         
3655
3656         * DumpRenderTree/qt/jsobjects.cpp:
3657         (EventSender::mouseDown):
3658         (EventSender::mouseUp):
3659         (EventSender::mouseMoveTo):
3660
3661 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3662
3663         Reviewed by Mark.
3664
3665         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3666         to prevent the default implementation from popping up messageboxes.
3667
3668         * DumpRenderTree/qt/DumpRenderTree.cpp:
3669         (WebCore::WebPage::javaScriptConfirm):
3670         (WebCore::WebPage::javaScriptPrompt):
3671
3672 2007-11-06  Eric Seidel  <eric@webkit.org>
3673
3674         * Scripts/build-testkjs: build fix... too many $$
3675
3676 2007-11-06  Eric Seidel  <eric@webkit.org>
3677
3678         Reviewed by Mark Rowe.
3679
3680         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3681
3682 2007-11-05  Adam Roben  <aroben@apple.com>
3683
3684         Add support on Windows for WEBKIT_TESTFONTS
3685
3686         This environment variable lets you specify where the fonts to be used
3687         by DumpRenderTree reside. The Qt port is already using this, so I'm
3688         just following their lead.
3689
3690         Reviewed by Darin.
3691
3692         * DumpRenderTree/win/DumpRenderTree.cpp:
3693         (exePath): Refactored code out of initialize().
3694         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3695         DumpRenderTree.resources.
3696         (initialize): Use the new fontsPath function.
3697         (main): Use the new exePath function.
3698         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3699         variable to DRT, like Qt does.
3700
3701 2007-11-05  Mark Rowe  <mrowe@apple.com>
3702
3703         Rubber-stamped by Alp Toker.
3704
3705         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3706
3707         * GtkLauncher/main.cpp:
3708         (goToURLBarText):
3709         (main):
3710
3711 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3712
3713         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3714         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3715
3716         Reviewed by Timothy.
3717
3718         Restrict the range of nightly builds used by the bisect-builds script
3719         based on the version of Safari and the version of Mac OS X being used.
3720
3721         Mac OS X 10.4: Safari 2.0: r11976 or newer
3722         Mac OS X 10.4: Safari 3.0: r19992 or newer
3723
3724         Mac OS X 10.5: Safari 2.0: r19594 or newer
3725         Mac OS X 10.5: Safari 3.0: r25124 or newer
3726
3727         * Scripts/bisect-builds:
3728         (findMacOSXVersion): Added.
3729         (makeNightlyList): Added argument to provide version of Mac OS X.
3730         Restrict range of nightly builds based on Safari and Mac OS X versions.
3731
3732 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3733
3734         Reviewed by Maciej.
3735
3736         - This patch involves several changes, all of them were noticed that
3737         they were needed by the work being done in WebKit to get Drosera and
3738         WebKit working together on Windows.
3739         - The changes are:
3740         1) Added a debugger console for output messages.
3741         2) Drosera now listens for the WebKit server (before, the server would
3742         have to be running before Drosera was started.)
3743         3) Fixed a bug where the WebView started out as 0x0 pixels.
3744         4) Fixed a bug when there is no scope.
3745         5) Added the HTML, JS, and CSS to the project file to make them easy to
3746         find.