7bd2c27be7289ba4418c7a4625105d15bfab1036
[WebKit.git] / WebKitTools / ChangeLog
1 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
2
3         Rubber-stamped by Dan Bernstein.
4
5         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
6         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
7         slow down the tests).
8
9         * Scripts/webkitpy/common/system/executive.py:
10
11 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
12
13         Reviewed by Kenneth Rohde Christiansen.
14
15         [Qt] Mac build fix
16         https://bugs.webkit.org/show_bug.cgi?id=41967
17
18         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
19
20         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
21
22 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
23
24         Reviewed by Antonio Gomes.
25
26         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
27         https://bugs.webkit.org/show_bug.cgi?id=41966
28
29         * MiniBrowser/qt/BrowserWindow.cpp:
30         (BrowserWindow::BrowserWindow):
31
32 2010-07-09  Leon Clarke  <leonclarke@google.com>
33
34         Reviewed by Adam Barth.
35
36         add support for link prefetching
37         https://bugs.webkit.org/show_bug.cgi?id=3652
38
39         * Scripts/build-webkit:
40
41 2010-07-09  Ojan Vafai  <ojan@chromium.org>
42
43         Reviewed by Adam Barth.
44
45         r63004 broke some python tests
46         https://bugs.webkit.org/show_bug.cgi?id=42007
47
48         AbstractStep now checks options.no_squash and options.squash, so
49         they needed to have real values. Mock would return an object for those,
50         which would then act as if the values were True.
51
52         * Scripts/webkitpy/tool/commands/commandtest.py:
53         * Scripts/webkitpy/tool/commands/download_unittest.py:
54         * Scripts/webkitpy/tool/commands/stepsequence.py:
55         * Scripts/webkitpy/tool/commands/upload_unittest.py:
56         * Scripts/webkitpy/tool/mocktool.py:
57         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
58         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
59         * Scripts/webkitpy/tool/steps/steps_unittest.py:
60         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
61         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
62
63 2010-07-09  Ojan Vafai  <ojan@chromium.org>
64
65         Reviewed by Adam Barth.
66
67         --squash should go away and become the default
68         https://bugs.webkit.org/show_bug.cgi?id=39624
69
70         If there are local commits and working copy changes, then prompt the user
71         whether to continue. Setting git config webkit-patch.commit_should_always_squash
72         true bypasses the prompt.
73
74         --git-commit=HEAD.. operates on working copy changes only.
75         --git-commit=committish operates on a range of commits as a single commit.
76             e.g. --git-commit=HEAD only operates on the HEAD commit.
77             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
78
79         --no-squash and --squash are left in with descriptive error messages if used.
80
81         * Scripts/check-webkit-style:
82         * Scripts/webkitpy/common/checkout/api.py:
83         * Scripts/webkitpy/common/checkout/api_unittest.py:
84         * Scripts/webkitpy/common/checkout/scm.py:
85         * Scripts/webkitpy/common/checkout/scm_unittest.py:
86         * Scripts/webkitpy/common/net/rietveld.py:
87         * Scripts/webkitpy/common/system/user.py:
88         * Scripts/webkitpy/style/optparser.py:
89         * Scripts/webkitpy/style_references.py:
90         * Scripts/webkitpy/tool/commands/download.py:
91         * Scripts/webkitpy/tool/commands/upload.py:
92         * Scripts/webkitpy/tool/mocktool.py:
93         * Scripts/webkitpy/tool/steps/abstractstep.py:
94         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
95         * Scripts/webkitpy/tool/steps/checkstyle.py:
96         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
97         * Scripts/webkitpy/tool/steps/commit.py:
98         * Scripts/webkitpy/tool/steps/options.py:
99         * Scripts/webkitpy/tool/steps/preparechangelog.py:
100         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
101         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
102         * Scripts/webkitpy/tool/steps/validatereviewer.py:
103
104 2010-07-09  Mark Rowe  <mrowe@apple.com>
105
106         Add two new Windows test build slaves.
107
108         * BuildSlaveSupport/build.webkit.org-config/config.json:
109
110 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
111
112         Reviewed by David Levin.
113
114         rebaseline_chromium_webkit_tests missing --use_drt option on linux
115         https://bugs.webkit.org/show_bug.cgi?id=41985
116
117         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
118         so that it works on linux. This is essentially a "compile-fix" for the
119         script.
120
121         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
122
123 2010-07-09  Nico Weber  <thakis@chromium.org>
124
125         Unreviewed. Adding myself as committer.
126
127         * Scripts/webkitpy/common/config/committers.py:
128
129 2010-07-09  David Kilzer  <ddkilzer@apple.com>
130
131         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
132
133         This reverts commit r62692.
134
135         * Scripts/commit-log-editor:
136
137 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
138
139         Reviewed by Ojan Vafai.
140
141         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
142         https://bugs.webkit.org/show_bug.cgi?id=38693
143
144         Introduced a new base class JSONResultsGeneratorBase that doesn't
145         have any dependency on layout_tests packages.
146         Turned JSONResultsGenerator into a wrapper class of the base class
147         so that the old code can work with it during the cleanup.
148
149         Added json_results_generator_unittest.py.
150
151         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
152         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
153         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
154
155 2010-07-09  Abhishek Arya  <inferno@chromium.org>
156
157         Unreviewed.
158
159         Marking myself as a committer.
160
161         * Scripts/webkitpy/common/config/committers.py:
162
163 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
164
165         Reviewed by Antti Koivisto.
166
167         Implement MiniBrowser for Qt.
168         https://bugs.webkit.org/show_bug.cgi?id=40233
169
170         * MiniBrowser/qt/BrowserWindow.cpp: Added.
171         (createNewPage):
172         (BrowserView::BrowserView):
173         (BrowserView::resizeEvent):
174         (BrowserView::load):
175         (BrowserView::view):
176         (BrowserWindow::BrowserWindow):
177         (BrowserWindow::load):
178         (BrowserWindow::changeLocation):
179         (BrowserWindow::~BrowserWindow):
180         * MiniBrowser/qt/BrowserWindow.h: Added.
181         (BrowserView::~BrowserView):
182         * MiniBrowser/qt/MiniBrowser.pro: Added.
183         * MiniBrowser/qt/main.cpp: Added.
184         (main):
185
186 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
187
188         Reviewed by Simon Hausmann.
189
190         Introduce the Qt autotest launcher.
191
192         Qt autotests should be executed more frequently, ideally by the Qt
193         build bot. This is the first step to provide the tests more accessible.
194
195         [Qt] It should be easier to run all Qt's autotests.
196         https://bugs.webkit.org/show_bug.cgi?id=31625
197
198         * Scripts/run-qtwebkit-tests: Added.
199
200 2010-07-09  Adam Barth  <abarth@webkit.org>
201
202         Reviewed by Eric Seidel.
203
204         commit-queue should merge to TOT when checkout needs update
205         https://bugs.webkit.org/show_bug.cgi?id=41944
206
207         There are a bunch of different designs that are possible here.  This
208         one merges to top of tree by cleaning out the working copy and
209         re-applying the patch.  Once you decide to merge that way, you need to
210         decide who's going to retry.  In this patch, we retry in the child
211         process instead of plumbing the failure reason to the master process.
212
213         This patch is difficult to test end-to-end, but hopefully it will work.
214         :)
215
216         * Scripts/webkitpy/tool/commands/queues.py:
217         * Scripts/webkitpy/tool/commands/stepsequence.py:
218         * Scripts/webkitpy/tool/multicommandtool.py:
219         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
220
221 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
222
223         Reviewed by Darin Adler.
224
225         Add a script to check for unnecessary includes in header files.
226         https://bugs.webkit.org/show_bug.cgi?id=41894
227
228         * Scripts/check-header-includes: Added.
229
230 2010-07-09  Adam Barth  <abarth@webkit.org>
231
232         Reviewed by Eric Seidel.
233
234         Add --html5-treebuilder option to run-webkit-tests
235         https://bugs.webkit.org/show_bug.cgi?id=41922
236
237         We're down to one or two regressions in the HTML5lib test suite.  It's
238         getting to be time to look at fixing LayoutTests.
239
240         * Scripts/old-run-webkit-tests:
241
242 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
243
244         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
245         in the drawing model never getting set on Tiger.
246
247         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
248         (NPP_New):
249
250 2010-07-08  Aaron Boodman  <aa@chromium.org>
251
252         Reviewed by Timothy Hatcher.
253
254         Add the ability for user scripts and user styles to affect just the top frame.
255
256         https://bugs.webkit.org/show_bug.cgi?id=41529
257
258         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
259         * DumpRenderTree/LayoutTestController.cpp: Ditto.
260         (addUserScriptCallback):
261         (addUserStyleSheetCallback):
262         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
263         (LayoutTestController::addUserScript):
264         (LayoutTestController::addUserStyleSheet):
265         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
266         (LayoutTestController::addUserScript):
267         (LayoutTestController::addUserStyleSheet):
268         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
269         (LayoutTestController::addUserScript):
270         (LayoutTestController::addUserStyleSheet):
271         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
272         (LayoutTestController::addUserScript):
273         (LayoutTestController::addUserStyleSheet):
274         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
275         (LayoutTestController::addUserScript):
276         (LayoutTestController::addUserStyleSheet):
277
278 2010-07-08  Adele Peterson  <adele@apple.com>
279
280         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
281
282         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
283         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
284
285         Log when the missing plugin button is pressed.
286
287         * DumpRenderTree/mac/UIDelegate.mm:
288         (-[UIDelegate webView:didPressMissingPluginButton:]):
289         * DumpRenderTree/win/UIDelegate.cpp:
290         (UIDelegate::QueryInterface):
291         (UIDelegate::createWebViewWithRequest):
292         (UIDelegate::drawBackground):
293         (UIDelegate::decidePolicyForGeolocationRequest):
294         (UIDelegate::didPressMissingPluginButton):
295         * DumpRenderTree/win/UIDelegate.h:
296
297 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
298
299         Fix the Tiger build.
300
301         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
302         (NPP_New):
303
304 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
305
306         Fix windows build.
307
308         #ifdef code for Mac.
309
310         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
311         (NPP_New):
312
313 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
314
315         Reviewed by Anders Carlsson.
316
317         Allow the TestPlugin to use Core Animation rendering for testing
318         https://bugs.webkit.org/show_bug.cgi?id=41872
319         
320         Add the ability for the TestPlugin to use the CoreAnimation rendering model
321         when available, based on the "drawingmodel" attribute of the embed tag:
322             drawingmodel="coreanimation"
323
324         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
325         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
326         when building on Tiger. Add a void* coreAnimationLayer member.
327         
328         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
329         (createCoreAnimationLayer): Obj-C method to create the CALayer.
330         
331         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
332         (NPP_New): Look for the drawingmodel attribute to decide which drawing
333         model to use.
334         (NPP_Destroy): Release the CALayer if we have one.
335         (NPP_GetValue): Return the retained CALayer.
336
337 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
338
339         Reviewed by Xan Lopez.
340
341         [GTK] Support pixel tests
342         https://bugs.webkit.org/show_bug.cgi?id=31518
343
344         Convert this file from CRLF to NL line endings. It will soon
345         be used on more than just the WinCairo platform.
346
347         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
348         (writeFunction):
349         (printPNG):
350         (computeMD5HashStringForBitmapContext):
351         (dumpBitmap):
352
353 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
354
355         Reviewed by Darin Adler.
356
357         Enable Data Execution Prevention for our test harnesses on Windows
358         https://bugs.webkit.org/show_bug.cgi?id=41882
359
360         * DumpRenderTree/win/DumpRenderTree.vcproj:
361         * DumpRenderTree/win/ImageDiff.vcproj:
362         * WebKitAPITest/WebKitAPITest.vcproj:
363         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
364
365 2010-07-07  Robert Hogan  <robert@webkit.org>
366
367         Reviewed by Kenneth Rohde Christiansen.
368
369         [Qt] Add DRT support for pageProperty etc.
370
371         https://bugs.webkit.org/show_bug.cgi?id=41584
372
373         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
374         (LayoutTestController::isPageBoxVisible):
375         (LayoutTestController::pageSizeAndMarginsInPixels):
376         (LayoutTestController::pageProperty):
377         (LayoutTestController::addUserStyleSheet):
378         * DumpRenderTree/qt/LayoutTestControllerQt.h:
379
380 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
381
382         Reviewed by Xan Lopez.
383
384         Remove a warnings from the ImageDiff build by using the proper
385         printf format string for the gsize data type.
386
387         * DumpRenderTree/gtk/ImageDiff.cpp:
388         (printImage): Use the proper printf format string for the gsize data type.
389
390 2010-07-08  Alice Liu  <alice.liu@apple.com>
391
392         Reviewed by Sam Weinig.
393
394         https://bugs.webkit.org/show_bug.cgi?id=41653
395         Add new WebKitTestRunner project for Windows
396
397         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
398         Similar to how it's done in DumpRenderTree, define max and min early
399         on so that they don't get replaced by a macro requiring 2 arguments.
400
401         * WebKitTestRunner/win: Added.
402         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
403         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
404         * WebKitTestRunner/win/main.cpp: Added.
405         (main): Implemented
406
407         Added these files with stubbed out functions:
408         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
409         (WTR::PlatformWebView::PlatformWebView):
410         (WTR::PlatformWebView::~PlatformWebView):
411         (WTR::PlatformWebView::page):
412         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
413         (WTR::TestController::initializeInjectedBundlePath):
414         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
415         (WTR::TestInvocation::runUntil):
416
417 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
418
419         Reviewed by Gustavo Noronha Silva.
420
421         [GTK] Implement ImageDiff and add it to the build system
422         https://bugs.webkit.org/show_bug.cgi?id=41779
423
424         Add the initial implementation of the ImageDiff tool for the GTK+
425         port. This is an essential tool for doing pixel tests. The implementation
426         is based on the Mac and Chromium ports.
427
428         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
429         (readPixbufFromStdin): Added.
430         (differenceImageFromDifferenceBuffer): Ditto.
431         (calculateDifference): Ditto.
432         (printImage): Ditto.
433         (printImageDifferences): Ditto.
434         (main): Ditto.
435         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
436
437 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
438
439         Unreviewed. Adding myself as a committer.
440
441         * Scripts/webkitpy/common/config/committers.py:
442
443 2010-07-08  Adam Roben  <aroben@apple.com>
444
445         Make Windows stop running tests from platform/mac
446
447         r62742 made a change (at my suggestion!) that caused us to start
448         looking for tests in platform/mac, rather than just looking for
449         expected results in platform/mac. This patch just undoes that part of
450         r62742.
451
452         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
453         tests from platform/mac, but shouldn't
454
455         Reviewed by Antti Koivisto and Anders Carlsson.
456
457         * Scripts/old-run-webkit-tests:
458         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
459         so we won't look in those directories for tests to run.
460         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
461         platform/mac-snowleopard and platform/mac for expected results.
462
463 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
464
465         Unreviewed. Adding myself as a reviewer.
466
467         * Scripts/webkitpy/common/config/committers.py:
468
469 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
470
471         Update my e-mail in committers.py
472
473         * Scripts/webkitpy/common/config/committers.py:
474
475 2010-07-07  Daniel Bates  <dbates@rim.com>
476
477         Reviewed by Dumitru Daniliuc.
478
479         VCSUtils.pm complains about uninitialized value $newLine
480         https://bugs.webkit.org/show_bug.cgi?id=41333
481
482         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
483         an array when fixing a change log entry that overlaps with an earlier
484         entry. In particular, when a patch contains a change log entry inserted
485         earlier in the change log file, but after an entry with the same author
486         and date.
487
488         * Scripts/VCSUtils.pm:
489             - Added for-loop constraint to fixChangeLogPatch() so that it does not
490               read off the end of the @overlappingLines array.
491         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
492
493 2010-07-07  Anders Carlsson  <andersca@apple.com>
494
495         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
496
497         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
498         (NPP_New):
499
500 2010-07-07  Kent Tamura  <tkent@chromium.org>
501
502         Reviewed by Adam Barth.
503
504         [DRT/Chromium] Support for indeterminate checkbox
505         https://bugs.webkit.org/show_bug.cgi?id=41747
506
507         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
508
509         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
510         (WebThemeControlDRT::draw):
511         * DumpRenderTree/chromium/WebThemeControlDRT.h:
512         (WebThemeControlDRT::):
513         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
514         (WebThemeEngineDRT::paintButton):
515
516 2010-07-07  Sam Weinig  <sam@webkit.org>
517
518         Reviewed by Mark Rowe.
519
520         Clean up MiniBrowser Xcode project.
521
522         - Use xcconfig files.
523         - Rename plists to canonical Info.plist
524         - Remove localizations.
525
526         * MiniBrowser/Configurations: Added.
527         * MiniBrowser/Configurations/Base.xcconfig: Added.
528         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
529         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
530         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
531         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
532         * MiniBrowser/WebBundle-Info.plist: Removed.
533         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
534         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
535         * MiniBrowser/mac/BrowserWindow.xib: Added.
536         * MiniBrowser/mac/BrowserWindowController.m:
537         (-[BrowserWindowController initWithPageNamespace:]):
538         * MiniBrowser/mac/English.lproj: Removed.
539         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
540         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
541         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
542         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
543         * MiniBrowser/mac/MainMenu.xib: Added.
544         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
545         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
546
547 2010-07-07  Kent Tamura  <tkent@chromium.org>
548
549         Reviewed by Dimitri Glazkov.
550
551         [DRT/Chromium] Fix two regressions
552         https://bugs.webkit.org/show_bug.cgi?id=41745
553
554         * DumpRenderTree/chromium/WebViewHost.cpp:
555         (WebViewHost::paintInvalidatedRegion):
556          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
557          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
558          though test_shell does it twice. Probably DRT needs it because
559          DRT delays painting as possible.
560
561 2010-07-07  Anders Carlsson  <andersca@apple.com>
562
563         Try to fix build.
564
565         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
566         (webkit_test_plugin_destroy_stream):
567
568 2010-07-07  Anders Carlsson  <andersca@apple.com>
569
570         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
571
572         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
573         (webkit_test_plugin_new_stream):
574         (webkit_test_plugin_destroy_stream):
575         (webkit_test_plugin_write_ready):
576         (webkit_test_plugin_write):
577
578 2010-07-07  Sam Weinig  <sam@webkit.org>
579
580         Reviewed by Mark Rowe.
581
582         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
583
584         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
585
586 2010-07-07  Anders Carlsson  <andersca@apple.com>
587
588         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
589
590         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
591         (NPP_New):
592         (NPP_HandleEvent):
593
594 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
595
596         Reviewed by Adam Roben.
597
598         Need to have a way to specify different results for Windows XP and 7
599         https://bugs.webkit.org/show_bug.cgi?id=41776
600         
601         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
602         subdirectories, so we can have different results for tests on Windows XP, Windows
603         Vista, and Windows 7.
604
605         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
606         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
607         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
608
609         This matches the behavior of the mac.
610
611         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
612             or Vista, try looking in other win-* subdirectories before win.
613         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
614             we are running.
615
616 2010-07-07  Kent Tamura  <tkent@chromium.org>
617
618         Reviewed by Dimitri Glazkov.
619
620         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
621         https://bugs.webkit.org/show_bug.cgi?id=41753
622
623         The original code of the following functions in
624         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
625         ASSERT_NOT_REACHED(). The program shouldn't stop at these
626         functions.
627
628         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
629         (DRTDevToolsClient::activateWindow):
630         (DRTDevToolsClient::closeWindow):
631         (DRTDevToolsClient::dockWindow):
632         (DRTDevToolsClient::undockWindow):
633
634 2010-07-07  Anders Carlsson  <andersca@apple.com>
635
636         Reviewed by Sam Weinig.
637
638         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
639         https://bugs.webkit.org/show_bug.cgi?id=41821
640
641         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
642         (pluginGetProperty):
643         (pluginSetProperty):
644         (pluginAllocate):
645         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
646         Add and initialize the returnNegativeOneFromWrite property.
647
648         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
649         (NPP_NewStream):
650         Set the stream type to NP_NORMAL so we'll get write callbacks.
651
652         (NPP_DestroyStream):
653         Treat the onstreamdestroy attribute as a function name and not a string.
654
655         (NPP_WriteReady):
656         Have this return a nonzero value.
657
658         (NPP_Write):
659         If returnNegativeOneFromWrite is true return -1.
660
661 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
662
663         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
664         latest version is selected by default, and allows the version to be specified.
665
666         * wx/build/settings.py:
667
668 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
669
670         Reviewed by Darin Adler.
671
672         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
673         https://bugs.webkit.org/show_bug.cgi?id=41810
674
675         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
676         (AccessibilityUIElement::selectedTextRange):
677
678 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
679
680         Unreviewed.
681
682         Build fix after r62700.
683
684         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
685         source file locations.
686
687 2010-07-07  Ojan Vafai  <ojan@chromium.org>
688
689         Reviewed by David Levin.
690
691         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
692         https://bugs.webkit.org/show_bug.cgi?id=41814
693
694         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
695         * Scripts/old-run-webkit-tests:
696
697 2010-07-07  Ojan Vafai  <ojan@chromium.org>
698
699         Reviewed by David Levin.
700
701         add --exit-after-n-crashes to run-webkit-tests
702         https://bugs.webkit.org/show_bug.cgi?id=41811
703
704         Change the bots at build.webkit.org to use --exit-after-n-crashes
705         instead of --exit-after-n-failures since we want to be able to have
706         more than 20 failures on those bots, but more than 20 crashes means
707         something should be rolled out.
708
709         * Scripts/old-run-webkit-tests:
710         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
711
712 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
713
714         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
715         TestNetscapePlugin project, because this was removed from the tree.
716
717         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
718
719 2010-07-07  Anders Carlsson  <andersca@apple.com>
720
721         Reviewed by Simon Fraser.
722
723         Unify Mac and Windows TestNetscapePlugin main.cpp files
724         https://bugs.webkit.org/show_bug.cgi?id=41798
725         
726         * DumpRenderTree/DumpRenderTree.sln:
727         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
728         (strcasecmp):
729         (NP_Initialize):
730         (NP_GetEntryPoints):
731         (NP_Shutdown):
732         (NPP_New):
733         (NPP_Destroy):
734         (NPP_HandleEvent):
735         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
736         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
737
738 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
739
740         [wx] Build fix. pageProperty needs to return a value.
741
742         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
743         (LayoutTestController::pageProperty):
744
745 2010-07-07  David Kilzer  <ddkilzer@apple.com>
746
747         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
748
749         Reviewed by Anders Carlsson.
750
751         For both svn and git, commit-log-editor is invoked from the root
752         of the working directory.  Unlike svn, git returns a list of
753         changed files that are relative to the directory where the
754         command was invoked.  This caused the ChangeLog file in the root
755         directory to be read instead of the ChangeLog in the current
756         directory.
757
758         The fix is to use $ENV{PWD} as the base directory when fixing
759         the path to the ChangeLog files.  With svn, this has no net
760         effect since $ENV{PWD} is the root of the working directory and
761         the ChangeLog paths are already relative to that directory.
762         With git, $ENV{PWD} is the directory that the commit was invoked
763         from, which fixes the ChangeLog paths so that the correct files
764         are read when creating the commit log entry.
765
766         Note that the call to makeFilePathRelative() was supposed to
767         address this issue, but it doesn't because (a) it does nothing
768         with svn working directories by design, and (b) it does nothing
769         with git working directories because it's invoked when the
770         current directory is the root of the working directory, thus
771         giving no relative path.
772
773         * Scripts/commit-log-editor: Removed call to
774         makeFilePathRelative() since since it does nothing.  Moved code
775         to fix up $changeLog path so that it's fixed before trying to
776         open the file, and use $ENV{PWD} as the base path.  Also use
777         canonicalizePath() to clean up paths with "../" in them.
778
779 2010-07-07  Anders Carlsson  <andersca@apple.com>
780
781         Another attempt at fixing the Qt build.
782
783         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
784
785 2010-07-07  Anders Carlsson  <andersca@apple.com>
786
787         Try to fix Qt build.
788
789         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
790
791 2010-07-07  Anders Carlsson  <andersca@apple.com>
792
793         Reviewed by Simon Fraser.
794
795         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
796         https://bugs.webkit.org/show_bug.cgi?id=41781
797
798         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
799         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
800         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
801         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
802         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
803         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
804         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
805         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
806         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
807         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
808         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
809         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
810         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
811
812 2010-07-07  Andras Becsi  <abecsi@webkit.org>
813
814         Unreviewed trivial fix.
815
816         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
817         which was checked in accidentally in r62635.
818
819         * Scripts/webkitpy/layout_tests/port/webkit.py:
820
821 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
822
823         Reviewed by Eric Seidel.
824
825         Pass port specific environment to server process.
826         https://bugs.webkit.org/show_bug.cgi?id=41593
827
828         * Scripts/webkitpy/layout_tests/port/qt.py:
829         * Scripts/webkitpy/layout_tests/port/webkit.py:
830
831 2010-07-06  Kent Tamura  <tkent@chromium.org>
832
833         Reviewed by Shinichiro Hamaji.
834
835         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
836         https://bugs.webkit.org/show_bug.cgi?id=41644
837
838         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
839         tolerance. We don't need tolerance for rebaseline.
840
841         * Scripts/webkitpy/layout_tests/port/base.py:
842           Add optional tolerance parameter to diff_image().
843         * Scripts/webkitpy/layout_tests/port/test.py:
844           Add optional tolerance parameter to diff_image().
845         * Scripts/webkitpy/layout_tests/port/webkit.py:
846           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
847         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
848           diff_files() always calls diff_image() with tolerance=0.
849           diff_files() is used only by rebaseline-chromium-webkit-tests.
850
851 2010-07-06  Sam Weinig  <sam@webkit.org>
852
853         Fix MiniBrowser build.
854
855         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
856
857 2010-07-06  Sam Weinig  <sam@webkit.org>
858
859         Reviewed by Anders Carlsson.
860
861         Add support for dumping the contents of messages to the console to WebKitTestRunner
862
863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
864         (WTR::InjectedBundlePage::InjectedBundlePage):
865         (WTR::InjectedBundlePage::_addMessageToConsole):
866         (WTR::InjectedBundlePage::addMessageToConsole):
867         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
868
869 2010-07-06  Sam Weinig  <sam@webkit.org>
870
871         Reviewed by Anders Carlsson.
872
873         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
874         Add dumpAsText support for WebKitTestRunner
875
876         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
877         (WTR::InjectedBundle::InjectedBundle):
878         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
879         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
880         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
881         API to dump the main frames text.
882
883 2010-07-06  Darin Adler  <darin@apple.com>
884
885         Fix Chromium build.
886
887         * DumpRenderTree/chromium/WebViewHost.cpp:
888         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
889         (WebViewHost::didNavigateWithinPage): Ditto.
890         (WebViewHost::updateURL): Ditto.
891
892 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
893
894         Reviewed by Xan Lopez.
895
896         [GTK] build-webkit should not run autogen.sh unconditionally
897         https://bugs.webkit.org/show_bug.cgi?id=41704
898
899         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
900         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
901         some very minor cleanup.
902
903 2010-07-06  Darin Adler  <darin@apple.com>
904
905         Try to fix Chromium build.
906
907         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
908
909 2010-07-06  Darin Adler  <darin@apple.com>
910
911         Fix build.
912
913         * WebKitAPITest/TestsController.cpp:
914         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
915
916 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
917
918         Reviewed by Kent Tamura.
919
920         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
921         https://bugs.webkit.org/show_bug.cgi?id=40558
922
923         Upstream DevTools for Chromium DRT.
924         (original Chromium files rev. 51287)
925
926         * DumpRenderTree/DumpRenderTree.gypi:
927         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
928         (DRTDevToolsAgent::DRTDevToolsAgent):
929         (DRTDevToolsAgent::setWebView):
930         (DRTDevToolsAgent::sendMessageToFrontend):
931         (DRTDevToolsAgent::forceRepaint):
932         (DRTDevToolsAgent::runtimeFeatureStateChanged):
933         (DRTDevToolsAgent::injectedScriptSource):
934         (DRTDevToolsAgent::injectedScriptDispatcherSource):
935         (DRTDevToolsAgent::debuggerScriptSource):
936         (DRTDevToolsAgent::asyncCall):
937         (DRTDevToolsAgent::call):
938         (DRTDevToolsAgent::webDevToolsAgent):
939         (DRTDevToolsAgent::attach):
940         (DRTDevToolsAgent::detach):
941         (DRTDevToolsAgent::setTimelineProfilingEnabled):
942         (DRTDevToolsAgent::evaluateInWebInspector):
943         (DRTDevToolsAgent::dispatchMessageLoop):
944         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
945         (DRTDevToolsAgent::~DRTDevToolsAgent):
946         (DRTDevToolsAgent::hostIdentifier):
947         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
948         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
949         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
950         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
951         (DRTDevToolsCallArgs::callsCount):
952         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
953         (DRTDevToolsClient::DRTDevToolsClient):
954         (DRTDevToolsClient::~DRTDevToolsClient):
955         (DRTDevToolsClient::sendMessageToAgent):
956         (DRTDevToolsClient::sendDebuggerCommandToAgent):
957         (DRTDevToolsClient::activateWindow):
958         (DRTDevToolsClient::closeWindow):
959         (DRTDevToolsClient::dockWindow):
960         (DRTDevToolsClient::undockWindow):
961         (DRTDevToolsClient::asyncCall):
962         (DRTDevToolsClient::call):
963         (DRTDevToolsClient::allMessagesProcessed):
964         * DumpRenderTree/chromium/DRTDevToolsClient.h:
965         * DumpRenderTree/chromium/EventSender.cpp:
966         * DumpRenderTree/chromium/LayoutTestController.cpp:
967         (LayoutTestController::LayoutTestController):
968         (LayoutTestController::closeWebInspector):
969         (LayoutTestController::setTimelineProfilingEnabled):
970         (LayoutTestController::evaluateInWebInspector):
971         * DumpRenderTree/chromium/LayoutTestController.h:
972         * DumpRenderTree/chromium/TestShell.cpp:
973         (TestShell::TestShell):
974         (TestShell::~TestShell):
975         (TestShell::createDRTDevToolsClient):
976         (TestShell::showDevTools):
977         (TestShell::closeDevTools):
978         (TestShell::runFileTest):
979         (TestShell::createNewWindow):
980         * DumpRenderTree/chromium/TestShell.h:
981         (TestShell::drtDevToolsAgent):
982         (TestShell::drtDevToolsClient):
983         * DumpRenderTree/chromium/config.h:
984
985 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
986
987         Reviewed by Eric Seidel.
988
989         Don't pass image hash to DRT when pixel tests are disabled.
990         https://bugs.webkit.org/show_bug.cgi?id=41597
991
992         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
993
994 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
995
996         Reviewed by Eric Seidel.
997
998         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
999         https://bugs.webkit.org/show_bug.cgi?id=41612
1000
1001         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1002
1003 2010-07-05  Adam Barth  <abarth@webkit.org>
1004
1005         Reviewed by Eric Seidel.
1006
1007         We should be able to specify a bug to block for webkit-patch upload
1008         https://bugs.webkit.org/show_bug.cgi?id=41648
1009
1010         This will be useful for working on the HTML5 parser.
1011
1012         * Scripts/webkitpy/tool/steps/createbug.py:
1013         * Scripts/webkitpy/tool/steps/options.py:
1014
1015 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1016
1017         Reviewed by Oliver Hunt.
1018
1019         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1020         https://bugs.webkit.org/show_bug.cgi?id=41017
1021
1022         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1023         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1024
1025 2010-07-04  MORITA Hajime  <morrita@google.com>
1026
1027         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1028         https://bugs.webkit.org/show_bug.cgi?id=41589
1029
1030         * run() method can result non-utf-8 bytes, that causes utf-8
1031           decoding fail.  Fixed to disable decoding.
1032         * Fixed Git.find_checkout_root() to make a test pass.
1033
1034         * Scripts/webkitpy/common/checkout/scm.py:
1035         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1036
1037 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1038
1039         Reviewed by Simon Hausmann.
1040
1041         [Qt] Fix DumpRenderTree userStyleSheet handling.
1042         https://bugs.webkit.org/show_bug.cgi?id=41570
1043
1044         DumpRenderTree did only set the userStyleSheet at
1045         layoutTestController.setUserStyleSheetEnabled().
1046
1047         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1048         (LayoutTestController::reset):
1049         (LayoutTestController::setUserStyleSheetLocation):
1050         (LayoutTestController::setUserStyleSheetEnabled):
1051         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1052
1053 2010-07-03  Robert Hogan  <robert@webkit.org>
1054
1055         Reviewed by Kenneth Rohde Christiansen.
1056
1057         [Qt] support dumpChildFrameScrollPositions
1058
1059         https://bugs.webkit.org/show_bug.cgi?id=41088
1060
1061         Unskip:
1062
1063         http/tests/navigation/anchor-subframeload.html
1064         http/tests/navigation/relativeanchor-frames.html
1065
1066         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1067         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1068         (WebCore::DumpRenderTree::dump):
1069         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1070         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1071         (LayoutTestController::reset):
1072         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1073         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1074         (LayoutTestController::dumpChildFrameScrollPositions):
1075
1076 2010-07-02  Sam Weinig  <sam@webkit.org>
1077
1078         Reviewed by Anders Carlsson.
1079
1080         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1081
1082         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1083         * Scripts/debug-webkittestrunner: Removed.
1084         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1085         * Scripts/run-webkittestrunner: Removed.
1086
1087 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1088
1089         Reviewed by Steve Falkenburg.
1090
1091         Some http tests fail on Windows with Cygwin 1.7
1092         https://bugs.webkit.org/show_bug.cgi?id=41537
1093         
1094         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1095         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1096         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1097
1098         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1099         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1100             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1101
1102 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1103
1104         Reviewed by Gustavo Noronha Silva.
1105
1106         [GTK] Separate DerivedSources per-project
1107         https://bugs.webkit.org/show_bug.cgi?id=41109
1108
1109         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1110         allowing the tools to build as a side-effect. Now that the top-level directory
1111         is no longer in the list of JavaScriptCore includes, include it explicitly.
1112
1113         * GNUmakefile.am:
1114
1115 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1116
1117         Reviewed by Kenneth Rohde Christiansen.
1118
1119         [Qt] Make context menus show up in the right place in QTestBrowser
1120
1121         Context menus were shown at scene-relative coordinates for
1122         QGraphicsWebView while QMenu expects them to be global. The
1123         change to the QWidget case was to get rid of the mapToGlobal.
1124
1125         * QtTestBrowser/webview.cpp:
1126
1127 2010-07-01  Robert Hogan <robert@webkit.org>
1128
1129         Reviewed by Kenneth Rohde Christiansen.
1130
1131         [Qt] dump frames in ascending alphabetical order of title
1132
1133         https://bugs.webkit.org/show_bug.cgi?id=41261
1134
1135         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1136         (WebCore::dumpHistoryItem):
1137
1138 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1139
1140         Unreviewed. 
1141
1142         Fix the GTK+ build after r62278.
1143
1144         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1145         let them override the automatic CPU detection for autotools builds.
1146
1147 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1148
1149         Unreviewed.
1150
1151         Fix the Windows build after r62278.
1152
1153         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1154
1155 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1156
1157         Reviewed by Gustavo Noronha Silva.
1158
1159         [GTK] build-webkit does not detect the number of CPUs
1160         https://bugs.webkit.org/show_bug.cgi?id=41469
1161
1162         Pass the appropriate -j<#> flag to make when building autotools builds.
1163         This causes make to spawn that many number of child processes for doing
1164         parallel builds.
1165
1166         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1167         of CPUs. This makes the script work across more platforms.
1168         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1169         number of CPUs across several platforms. Use this new function to determine the appropriate
1170         arguments to pass to make for doing parallel builds with autotools build files.
1171
1172 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1173
1174         Rubber-stamped by Laszlo Gombos.
1175
1176         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1177
1178         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1179         and use the one from WebKit.pri instead.
1180
1181 2010-07-01  Adam Barth  <abarth@webkit.org>
1182
1183         Reviewed by Eric Seidel.
1184
1185         Promote webkit-patch land-safely to main help
1186         https://bugs.webkit.org/show_bug.cgi?id=41446
1187
1188         I've been using this command a bunch and recommending it to folks.  We
1189         should show it in main help as it's past the experimental phase.
1190
1191         * Scripts/webkitpy/tool/commands/upload.py:
1192
1193 2010-06-28  MORITA Hajime  <morrita@google.com>
1194
1195         Reviewed by Shinichiro Hamaji.
1196
1197         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1198         https://bugs.webkit.org/show_bug.cgi?id=38775
1199
1200         - Introduced SCM.show_head() and SCM.diff_for_file().
1201         - Replaced direct svn invocations with newly implement SCM methods.
1202
1203         * Scripts/webkitpy/common/checkout/scm.py:
1204         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1205         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1206
1207 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1208
1209         Reviewed by Sam Weinig.
1210
1211         Allow MiniBrowser to open local files
1212         https://bugs.webkit.org/show_bug.cgi?id=41104
1213
1214         Wire up the openDocument: message with an NSOpenPanel, so we can open
1215         local files.
1216         
1217         Also change the xib so that the window remembers its size.
1218         
1219         * MiniBrowser/mac/AppDelegate.m:
1220         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1221         (-[BrowserAppDelegate openDocument:]):
1222         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1223         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1224
1225 2010-06-30  Sam Weinig  <sam@webkit.org>
1226
1227         Rubber-stamped by Anders Carlsson.
1228
1229         Add debug-webkittestrunner and cleanup related scripts.
1230
1231         * Scripts/debug-webkittestrunner: Added.
1232         * Scripts/run-webkittestrunner:
1233         * Scripts/webkitdirs.pm:
1234
1235 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1236
1237         [wx] Build fix after recent changes to LayoutTestController.
1238
1239         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1240         (LayoutTestController::pageSizeAndMarginsInPixels):
1241
1242 2010-06-29  Sam Weinig  <sam@webkit.org>
1243
1244         Reviewed by Anders Carlsson.
1245
1246         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1247         Make WebKitTestRunner work with more than one test at a time.
1248
1249         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1250         where there is a single WKView and each test is run it, rather than
1251         the design I was using where each test got its own WKView.
1252
1253         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1254         (WTR::InjectedBundle::didRecieveMessage):
1255         (WTR::InjectedBundle::reset):
1256         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1257         * WebKitTestRunner/TestController.cpp:
1258         (WTR::TestController::initialize):
1259         (WTR::TestController::runTest):
1260         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1261         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1262         * WebKitTestRunner/TestController.h:
1263         (WTR::TestController::mainWebView):
1264         (WTR::TestController::pageNamespace):
1265         (WTR::TestController::context):
1266         * WebKitTestRunner/TestInvocation.cpp:
1267         (WTR::TestInvocation::TestInvocation):
1268         (WTR::TestInvocation::~TestInvocation):
1269         (WTR::TestInvocation::invoke):
1270         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1271         * WebKitTestRunner/TestInvocation.h:
1272
1273 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1274
1275         Reviewed by Laszlo Gombos.
1276
1277         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1278         https://bugs.webkit.org/show_bug.cgi?id=40446
1279
1280         We quickly run out of memory on Symbian when loading web pages. This is
1281         caused by the default heap size, which is not suited for a web browser.
1282
1283         This change bumps the max heap size to 32MB.
1284
1285         * QtTestBrowser/QtTestBrowser.pro:
1286
1287 2010-06-30  Eric Seidel  <eric@webkit.org>
1288
1289         Reviewed by Adam Barth.
1290
1291         webkit-patch land allow the user to continue even if the builders are red
1292         https://bugs.webkit.org/show_bug.cgi?id=41395
1293
1294         I don't think it's good that we've been teaching people
1295         to always pass --ignore-builders.  At least land is now
1296         useable w/o --ignore-builders.
1297
1298         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1299
1300 2010-06-29  Robert Hogan  <robert@webkit.org>
1301
1302         Reviewed by Kenneth Rohde Christiansen.
1303
1304         [Qt] support dumpResourceResponseMIMETypes
1305         https://bugs.webkit.org/show_bug.cgi?id=41260
1306
1307         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1308         (LayoutTestController::reset):
1309         (LayoutTestController::dumpResourceResponseMIMETypes):
1310         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1311
1312 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1313
1314         Reviewed by Kenneth Rohde Christiansen.
1315
1316         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1317         https://bugs.webkit.org/show_bug.cgi?id=41173
1318
1319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1320         (WebCore::WebPage::setViewGeometry):
1321         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1322
1323 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1324
1325         Reviewed by Simon Hausmann.
1326
1327         [Qt] Deal with postEvent in case of graphics based DRT
1328         https://bugs.webkit.org/show_bug.cgi?id=41174
1329
1330         QGraphicsScene does not have a postEvent method, so make scene
1331         send the event, in case of graphics based DRT, and delete it after that.
1332
1333         * DumpRenderTree/qt/EventSenderQt.cpp:
1334         (EventSender::scheduleAsynchronousClick):
1335         (EventSender::replaySavedEvents):
1336         (EventSender::postEvent):
1337         * DumpRenderTree/qt/EventSenderQt.h:
1338
1339 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1340
1341         Reviewed by Kenneth Rohde Christiansen.
1342
1343         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1344         https://bugs.webkit.org/show_bug.cgi?id=41172
1345
1346         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1347         (WebCore::DumpRenderTree::switchFocus):
1348
1349 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1350
1351         Reviewed by Xan Lopez.
1352
1353         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1354         https://bugs.webkit.org/show_bug.cgi?id=40009
1355
1356         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1357         are used when returning those values, for coherency with other ports.
1358
1359         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1360         (AccessibilityUIElement::role):
1361         (AccessibilityUIElement::title):
1362         (AccessibilityUIElement::description):
1363
1364 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1365
1366         Unreviewed, rolling out r62106.
1367         http://trac.webkit.org/changeset/62106
1368         https://bugs.webkit.org/show_bug.cgi?id=41346
1369
1370         "Broke editing tests" (Requested by xan_ on #webkit).
1371
1372         * Scripts/old-run-webkit-tests:
1373
1374 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1375
1376         Reviewed by Xan Lopez.
1377
1378         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1379         https://bugs.webkit.org/show_bug.cgi?id=38648
1380
1381         Add the GTK_MODULES envvar (set to "gail") to the clean
1382         environment when running DRT for the Gtk+ port
1383
1384         * Scripts/old-run-webkit-tests:
1385
1386 2010-06-28  Adam Barth  <abarth@webkit.org>
1387
1388         Unreviewed.
1389
1390         Switch test-html5-parser back to using runner.html.
1391
1392         * Scripts/test-html5-parser:
1393
1394 2010-06-28  Adam Barth  <abarth@webkit.org>
1395
1396         Reviewed by Eric Seidel.
1397
1398         Restore webkit-runner.html for use with new tree builder
1399         https://bugs.webkit.org/show_bug.cgi?id=41317
1400
1401         For now, we just want to run webkit-runner when we test-html5-parser.
1402
1403         * Scripts/test-html5-parser:
1404
1405 2010-06-23  John Gregg  <johnnyg@google.com>
1406
1407         Reviewed by Kent Tamura.
1408
1409         add ENABLE_DIRECTORY_UPLOAD build support
1410         https://bugs.webkit.org/show_bug.cgi?id=41100
1411
1412         * Scripts/build-webkit:
1413
1414 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1415
1416         Rubber-stamped by Xan Lopez.
1417
1418         Update webkitdirs's knowledge of our library's name.
1419
1420         * Scripts/webkitdirs.pm:
1421
1422 2010-06-28  Sam Weinig  <sam@webkit.org>
1423
1424         Reviewed by Anders Carlsson.
1425
1426         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1427         Build up WebKitTestRunner output in the InjectedBundle
1428
1429         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1430         and sending it over postMessage when done, instead of using the async
1431         WKPageRenderTreeExternalRepresentation.
1432
1433         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1434         (WTR::InjectedBundle::done):
1435         (WTR::InjectedBundle::didRecieveMessage):
1436         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1437         (WTR::InjectedBundle::os):
1438         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1439         (WTR::WKStringToUTF8):
1440         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1441         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1442         * WebKitTestRunner/TestInvocation.cpp:
1443         (WTR::WKStringToUTF8):
1444         (WTR::TestInvocation::TestInvocation):
1445         (WTR::TestInvocation::invoke):
1446         (WTR::TestInvocation::initializeMainWebView):
1447         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1448         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1449         * WebKitTestRunner/TestInvocation.h:
1450
1451 2010-06-28  Robert Hogan  <robert@webkit.org>
1452
1453         Unreviewed, rolling out r62021.
1454         http://trac.webkit.org/changeset/62021
1455         https://bugs.webkit.org/show_bug.cgi?id=41261
1456
1457         Broke http/navigation tests among other
1458
1459         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1460         (WebCore::DumpRenderTree::dumpFramesAsText):
1461
1462 2010-06-28  Sam Weinig  <sam@webkit.org>
1463
1464         Reviewed by Anders Carlsson.
1465
1466         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1467         environment.
1468
1469         * Scripts/run-webkittestrunner: Added.
1470         * Scripts/webkitdirs.pm:
1471
1472 2010-06-28  Robert Hogan  <robert@webkit.org>
1473
1474         Reviewed by Kenneth Rohde Christiansen.
1475
1476         [Qt] dump frames in ascending alphabetical order of title
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=41261
1479
1480         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1481         (WebCore::DumpRenderTree::dumpFramesAsText):
1482
1483 2010-06-28  Robert Hogan  <robert@webkit.org>
1484
1485         Reviewed by Kenneth Rohde Christiansen.
1486
1487         [Qt] dump bf history of child windows
1488
1489         https://bugs.webkit.org/show_bug.cgi?id=41266
1490
1491         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1492         (WebCore::DumpRenderTree::dumpBackForwardList):
1493         (WebCore::DumpRenderTree::dump):
1494         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1495
1496 2010-06-28  Sam Weinig  <sam@webkit.org>
1497
1498         Reviewed by Anders Carlsson.
1499
1500         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1501         WebKit2: Add frame API for InjectedBundle code
1502
1503         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1504         (_didClearWindowForFrame):
1505
1506 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1507
1508         Reviewed by Kenneth Rohde Christiansen.
1509
1510         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1511         https://bugs.webkit.org/show_bug.cgi?id=38597
1512
1513         Fix behavior so reload button really acts as a load and a reload button.
1514
1515         * QtTestBrowser/mainwindow.cpp:
1516         (MainWindow::changeLocation):
1517
1518 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1519
1520         Reviewed by Gustavo Noronha.
1521
1522         [GTK] Does not compile with -DGSEAL_ENABLE
1523         https://bugs.webkit.org/show_bug.cgi?id=37851
1524
1525         Fix build with GSEAL enabled.
1526
1527         * DumpRenderTree/gtk/EventSender.cpp:
1528         (gtk_widget_get_window):
1529         (prepareMouseButtonEvent):
1530         (mouseMoveToCallback):
1531         (mouseWheelToCallback):
1532         (keyDownCallback):
1533
1534 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1535
1536         Reviewed by Gustavo Noronha.
1537
1538         [GTK] Add support for GTK+3
1539         https://bugs.webkit.org/show_bug.cgi?id=41253
1540
1541         Adapt build system for 3.x support.
1542
1543         * GNUmakefile.am:
1544
1545 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1546
1547         Reviewed by Simon Hausmann.
1548
1549         [QT][S60] build-webkit scripts picks wrong make spec for windows build
1550         https://bugs.webkit.org/show_bug.cgi?id=41198
1551
1552         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
1553
1554         * Scripts/webkitdirs.pm:
1555         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
1556
1557 2010-06-28  Eric Seidel  <eric@webkit.org>
1558
1559         Reviewed by Adam Barth.
1560
1561         Make it possible to test the new HTML5 TreeBuilder
1562         https://bugs.webkit.org/show_bug.cgi?id=41276
1563
1564         Adam was concerned that someone might make their port
1565         depend on this setting (I guess we had some trouble with that
1566         with the HTML5Parser setting), so I littered the code with warnings.
1567
1568         test-html5-parser now tests this code path.
1569
1570         * DumpRenderTree/mac/DumpRenderTree.mm:
1571         (resetDefaultsToConsistentValues):
1572         (initializeGlobalsFromCommandLineOptions):
1573         * Scripts/test-html5-parser:
1574
1575 2010-06-27  MORITA Hajime  <morrita@google.com>
1576
1577         Unreviewed. 
1578         
1579         Some never-called @staticmethods touched self. 
1580         Fixed it to replace these self with a class.
1581
1582         * Scripts/webkitpy/common/checkout/scm.py:
1583
1584 2010-06-27  MORITA Hajime  <morrita@google.com>
1585
1586         Unreviewed.
1587         
1588         Fixed exception raising syntax that is pointed out at
1589         https://bugs.webkit.org/show_bug.cgi?id=41153
1590
1591         * Scripts/webkitpy/common/checkout/scm.py:
1592         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
1593           Removed a bad line that I accidentally checked-in at last revision.
1594
1595 2010-06-24  MORITA Hajime  <morrita@google.com>
1596
1597         Reviewed by Eric Seidel.
1598
1599         rebaseline-chromium-webkit-tests should add or remove files to local git repository
1600         https://bugs.webkit.org/show_bug.cgi?id=41153
1601
1602         - Added SCM.add() and SCM.remove()
1603         - Replaced "svn add" and "svn remove"
1604           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
1605         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
1606           for debugging purpose.
1607
1608         * Scripts/webkitpy/common/checkout/scm.py:
1609         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1610         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1611
1612 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
1613
1614         Reviewed by Shinichiro Hamaji.
1615
1616         Improve default value handling for page format properties.
1617         https://bugs.webkit.org/show_bug.cgi?id=41150
1618
1619         * DumpRenderTree/LayoutTestController.cpp:
1620         (parsePageNumber):
1621         (parsePageNumberSizeMarings):
1622         (pageSizeAndMarginsInPixelsCallback):
1623         (LayoutTestController::staticFunctions):
1624         * DumpRenderTree/LayoutTestController.h:
1625         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1626         (LayoutTestController::pageSizeAndMarginsInPixels):
1627         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1628         (LayoutTestController::pageSizeAndMarginsInPixels):
1629         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1630         (LayoutTestController::pageSizeAndMarginsInPixels):
1631
1632 2010-06-21  Robert Hogan  <robert@webkit.org>
1633
1634         Reviewed by Kenneth Rohde Christiansen.
1635
1636         [Qt] DRT Support for setCustomPolicyDelegate
1637
1638         https://bugs.webkit.org/show_bug.cgi?id=39564
1639
1640         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1641         (LayoutTestController::setCustomPolicyDelegate):
1642         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1643
1644 2010-06-26  Robert Hogan  <robert@webkit.org>
1645
1646         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
1647         
1648         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
1649         exported.
1650
1651         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1652
1653 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
1654
1655         Reviewed by Dimitri Glazkov.
1656
1657         Add a build-webkit option for enabling Web Timing support.
1658         https://bugs.webkit.org/show_bug.cgi?id=38924
1659
1660         * Scripts/build-webkit:
1661
1662 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1663
1664         Reviewed by Kenneth Rohde Christiansen.
1665
1666         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1667         https://bugs.webkit.org/show_bug.cgi?id=38597
1668
1669         Make the reload button act as a load button as well.
1670
1671         * QtTestBrowser/mainwindow.cpp:
1672         (MainWindow::buildUI):
1673         (MainWindow::changeLocation):
1674
1675 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
1676
1677         Reviewed by Dmitry Titov.
1678
1679         Add empty abortModal() method to all platforms.
1680         https://bugs.webkit.org/show_bug.cgi?id=40864
1681
1682         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
1683         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
1684         that use abortModal will become mac specific which is not desirable.
1685
1686         * DumpRenderTree/LayoutTestController.cpp:
1687         (abortModalCallback):
1688         (LayoutTestController::staticFunctions):
1689         * DumpRenderTree/LayoutTestController.h:
1690         * DumpRenderTree/chromium/LayoutTestController.cpp:
1691         (LayoutTestController::LayoutTestController):
1692         (LayoutTestController::abortModal):
1693         * DumpRenderTree/chromium/LayoutTestController.h:
1694         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1695         (LayoutTestController::abortModal):
1696         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1697         (LayoutTestController::abortModal):
1698         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1699         (LayoutTestController::abortModal):
1700         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1701         (LayoutTestController::abortModal):
1702
1703 2010-06-25  Sam Weinig  <sam@webkit.org>
1704
1705         Reviewed by Anders Carlsson.
1706
1707         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
1708         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
1709
1710         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
1711         (WTR::InjectedBundle::shared):
1712         (WTR::InjectedBundle::InjectedBundle):
1713         (WTR::InjectedBundle::_didCreatePage):
1714         (WTR::InjectedBundle::_willDestroyPage):
1715         (WTR::InjectedBundle::_didRecieveMessage):
1716         (WTR::InjectedBundle::initialize):
1717         (WTR::InjectedBundle::didCreatePage):
1718         (WTR::InjectedBundle::willDestroyPage):
1719         (WTR::InjectedBundle::didRecieveMessage):
1720         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
1721         (WTR::InjectedBundle::layoutTestController):
1722         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1723         (WKBundleInitialize):
1724         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
1725         (WTR::InjectedBundlePage::InjectedBundlePage):
1726         (WTR::InjectedBundlePage::~InjectedBundlePage):
1727         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
1728         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
1729         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
1730         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
1731         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
1732         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
1733         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
1734         (WTR::InjectedBundlePage::_didClearWindowForFrame):
1735         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1736         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1737         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1738         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1739         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1740         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1741         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1742         (WTR::InjectedBundlePage::didClearWindowForFrame):
1743         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
1744         (WTR::InjectedBundlePage::page):
1745         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
1746         (WTR::LayoutTestController::create):
1747         (WTR::LayoutTestController::LayoutTestController):
1748         (WTR::LayoutTestController::~LayoutTestController):
1749         (WTR::dumpAsTextCallback):
1750         (WTR::layoutTestControllerObjectFinalize):
1751         (WTR::LayoutTestController::makeWindowObject):
1752         (WTR::LayoutTestController::getJSClass):
1753         (WTR::LayoutTestController::staticFunctions):
1754         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
1755         (WTR::LayoutTestController::dumpAsText):
1756         (WTR::LayoutTestController::setDumpAsText):
1757         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1758
1759 2010-06-25  Sam Weinig  <sam@webkit.org>
1760
1761         Reviewed by Anders Carlsson.
1762
1763         Make WebKitTestRunner really work with run-webkit-tests. 
1764
1765         - Add Forwarding headers to allow some cleanup.
1766
1767         * WebKitTestRunner/ForwardingHeaders: Added.
1768         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
1769         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
1770         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
1771         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
1772         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
1773         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
1774         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
1775         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
1776         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
1777         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
1778         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
1779         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
1780         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
1781         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
1782         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
1783         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
1784         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
1785         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
1786         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
1787         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
1788         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
1789         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
1790         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
1791         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
1792         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
1793         * WebKitTestRunner/TestInvocation.cpp:
1794         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
1795         * WebKitTestRunner/TestInvocation.h:
1796
1797 2010-06-25  Sam Weinig  <sam@webkit.org>
1798
1799         Reviewed by Mark Rowe.
1800
1801         Add support for WebKitTestRunner to old-run-webkit-tests
1802
1803         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
1804
1805         * Scripts/build-webkittestrunner: Added.
1806         * Scripts/old-run-webkit-tests:
1807
1808 2010-06-25  Adam Barth  <abarth@webkit.org>
1809
1810         Reviewed by David Levin.
1811
1812         Incremental build failed on Chromium ews
1813         https://bugs.webkit.org/show_bug.cgi?id=41011
1814
1815         The division of responsibility between update-webkit --chromium and
1816         build-webkit --chromium is slightly unclear.  In this patch, we make
1817         build-webkit --chromium also update DEPS and re-run GYP in case the
1818         developer has changed either since they updated.
1819
1820         This change is also helpful for the EWS, which wants to update DEPS and
1821         re-run GYP after applying patches, but the EWS doesn't want to run
1822         update-webkit --chromium because it has a dirty working copy.
1823
1824         * Scripts/webkitdirs.pm:
1825
1826 2010-06-25  Robert Hogan  <robert@webkit.org>
1827
1828         Reviewed by Simon Hausmann.
1829
1830         [Qt] Support evaluateScriptInIsolatedWorld()
1831
1832         https://bugs.webkit.org/show_bug.cgi?id=40079
1833
1834         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
1835         Remove QWebScriptWorld from exported headers.
1836         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
1837
1838         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1839         (LayoutTestController::reset):
1840         (LayoutTestController::evaluateScriptInIsolatedWorld):
1841         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1842
1843 2010-06-25  Anders Carlsson  <andersca@apple.com>
1844
1845         Revert accidental part and add a newline.
1846
1847         * MiniBrowser/mac/AppDelegate.m:
1848         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1849
1850 2010-06-25  Anders Carlsson  <andersca@apple.com>
1851
1852         Rubber-stamped by Dan Bernstein.
1853
1854         Add a LOG macro that expands to a no-op by default.
1855
1856         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1857         * MiniBrowser/mac/AppDelegate.m:
1858         (_didRecieveMessageFromInjectedBundle):
1859         * MiniBrowser/mac/BrowserWindowController.m:
1860         (-[BrowserWindowController windowShouldClose:]):
1861         (_didStartProvisionalLoadForFrame):
1862         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1863         (_didFailProvisionalLoadWithErrorForFrame):
1864         (_didCommitLoadForFrame):
1865         (_didFinishLoadForFrame):
1866         (_didFailLoadWithErrorForFrame):
1867         (_didReceiveTitleForFrame):
1868         (_didFirstLayoutForFrame):
1869         (_didFirstVisuallyNonEmptyLayoutForFrame):
1870         (_didBecomeUnresponsive):
1871         (_didBecomeResponsive):
1872         (_decidePolicyForNavigationAction):
1873         (_decidePolicyForNewWindowAction):
1874         (_createNewPage):
1875         (_showPage):
1876         (_closePage):
1877         (_didNavigateWithNavigationData):
1878         (_didPerformClientRedirect):
1879         (_didPerformServerRedirect):
1880         (_didUpdateHistoryTitle):
1881         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1882         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1883         (_didClearWindowForFrame):
1884         (_didCreatePage):
1885         (_willDestroyPage):
1886         (_didRecieveMessage):
1887
1888 2010-06-24  Adam Barth  <abarth@webkit.org>
1889
1890         Reviewed by Eric Seidel.
1891
1892         commit-queue is taking too long to land patches because of red trees
1893         https://bugs.webkit.org/show_bug.cgi?id=41194
1894
1895         Instead of checking for the tree to be green, we'll just spin hot
1896         trying to land patches.  This is probably too extreme in ignoring the
1897         tree, but I think we should try it for a while to see if we have
1898         trouble.  That will help us find the right balance.
1899
1900         * Scripts/webkitpy/tool/commands/queues.py:
1901         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1902
1903 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
1904
1905         Reviewed by Xan Lopez.
1906
1907         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
1908         https://bugs.webkit.org/show_bug.cgi?id=40843
1909
1910         Define the version for old GTK+s in a way that is forward-compatible
1911         and clean up the logic a bit.
1912
1913         * DumpRenderTree/gtk/EventSender.cpp:
1914         (gdk_window_get_root_coords): Renamed and cleaned up.
1915         (prepareMouseButtonEvent): Remove #ifdefs.
1916         (mouseMoveToCallback): Remove #ifdefs.
1917
1918 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
1919
1920         Reviewed by Eric Seidel.
1921
1922         Fix NewRunWebKitTests to work on Windows.
1923         https://bugs.webkit.org/show_bug.cgi?id=41180
1924
1925         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
1926             because Windows fails to understand what we're asking of it.
1927
1928 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
1929
1930         Reviewed by Xan Lopez.
1931
1932         [GTK] The url passed to the WebView during layout tests is invalid
1933         https://bugs.webkit.org/show_bug.cgi?id=40832
1934
1935         Set the test URL to the full real file URL and do a small cleanup.
1936         Previously a URL like file://relative/path/to/test.html was passed
1937         to the WebView. This malformed file URL would be returned by
1938         webkit_web_view_get_url and webkit_web_frame_get_url.
1939
1940         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1941         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
1942         (shouldOpenWebInspector): Change to take a const string& as the argument.
1943         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
1944         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
1945
1946 2010-06-24  Sam Weinig  <sam@webkit.org>
1947
1948         Reviewed by Anders Carlsson.
1949
1950         Fix WebKitTestRunner Makefile typos.
1951
1952         * WebKitTestRunner/Makefile:
1953
1954 2010-06-24  Adele Peterson  <adele@apple.com>
1955
1956         Reviewed by Eric Carlson.
1957
1958         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
1959         https://bugs.webkit.org/show_bug.cgi?id=41085
1960
1961         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
1962         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
1963
1964 2010-06-23  Sam Weinig  <sam@webkit.org>
1965
1966         Reviewed by Anders Carlsson.
1967
1968         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
1969         Add new WebKitTestRunner project (ie. DRT for WebKit2).
1970
1971         - Mac only.
1972         - run-webkit-tests has not been modified to call it yet.
1973         - Only dumps the render tree at this time. 
1974
1975         * WebKitTestRunner: Added.
1976         * WebKitTestRunner/Configurations: Added.
1977         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
1978         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
1979         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
1980         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
1981         * WebKitTestRunner/InjectedBundle: Added.
1982         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
1983         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
1984         (_didStartProvisionalLoadForFrame):
1985         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1986         (_didFailProvisionalLoadWithErrorForFrame):
1987         (_didCommitLoadForFrame):
1988         (_didFinishLoadForFrame):
1989         (_didFailLoadWithErrorForFrame):
1990         (_didReceiveTitleForFrame):
1991         (_didClearWindow):
1992         (_didCreatePage):
1993         (_willDestroyPage):
1994         (_didRecieveMessage):
1995         (WKBundleInitialize):
1996         * WebKitTestRunner/Makefile: Added.
1997         * WebKitTestRunner/PlatformWebView.h: Added.
1998         (WTR::PlatformWebView::platformView):
1999         * WebKitTestRunner/TestController.cpp: Added.
2000         (WTR::TestController::shared):
2001         (WTR::TestController::TestController):
2002         (WTR::TestController::initialize):
2003         (WTR::TestController::runTest):
2004         (WTR::TestController::runTestingServerLoop):
2005         (WTR::TestController::run):
2006         * WebKitTestRunner/TestController.h: Added.
2007         (WTR::TestController::verbose):
2008         (WTR::TestController::injectedBundlePath):
2009         * WebKitTestRunner/TestInvocation.cpp: Added.
2010         (WTR::createWKURL):
2011         (WTR::TestInvocation::TestInvocation):
2012         (WTR::TestInvocation::~TestInvocation):
2013         (WTR::TestInvocation::invoke):
2014         (WTR::TestInvocation::dump):
2015         (WTR::TestInvocation::initializeMainWebView):
2016         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2017         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2018         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2019         (WTR::TestInvocation::didCommitLoadForFrame):
2020         (WTR::TestInvocation::didFinishLoadForFrame):
2021         (WTR::TestInvocation::didFailLoadForFrame):
2022         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2023         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2024         * WebKitTestRunner/TestInvocation.h: Added.
2025         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2026         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2027         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2028         * WebKitTestRunner/mac: Added.
2029         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2030         (WTR::PlatformWebView::PlatformWebView):
2031         (WTR::PlatformWebView::~PlatformWebView):
2032         (WTR::PlatformWebView::page):
2033         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2034         (WTR::TestInvocation::runUntil):
2035         * WebKitTestRunner/mac/main.mm: Added.
2036         (main):
2037
2038 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2039
2040         Unreviewed. Adding myself to the committers list.
2041
2042         * Scripts/webkitpy/common/config/committers.py:
2043
2044 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2045
2046         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2047
2048         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2049         (LayoutTestController::isPageBoxVisible):
2050         (LayoutTestController::pageAreaRectInPixels):
2051         (LayoutTestController::preferredPageSizeInPixels):
2052         * wx/build/settings.py:
2053
2054 2010-06-23  James Robinson  <jamesr@chromium.org>
2055
2056         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2057
2058         * Scripts/webkitpy/common/config/committers.py:
2059
2060 2010-06-23  Kent Tamura  <tkent@chromium.org>
2061
2062         Reviewed by Dimitri Glazkov.
2063
2064         Correct Chromium test configuration
2065         https://bugs.webkit.org/show_bug.cgi?id=41057
2066
2067         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2068          - Add "--use-drt" option for NRWT. It is required for Chromium and
2069            ignored for other platforms.
2070          - Skip JSC test on Chromium
2071         * BuildSlaveSupport/test-result-archive:
2072           Add Chromium support.
2073
2074 2010-06-23  Sam Weinig  <sam@webkit.org>
2075
2076         Reviewed by Anders Carlsson.
2077
2078         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2079         WebKit2: Flesh out more of the InjectedBundle client API
2080
2081         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2082         (_didStartProvisionalLoadForFrame):
2083         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2084         (_didFailProvisionalLoadWithErrorForFrame):
2085         (_didCommitLoadForFrame):
2086         (_didFinishLoadForFrame):
2087         (_didFailLoadWithErrorForFrame):
2088         (_didReceiveTitleForFrame):
2089         (_didClearWindowForFrame):
2090         (_didCreatePage):
2091         (_willDestroyPage):
2092         (WKBundleInitialize):
2093
2094 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2095
2096         Reviewed by Shinichiro Hamaji.
2097
2098         Implement page format data programming interface.
2099         Add methods for testing.
2100         https://bugs.webkit.org/show_bug.cgi?id=37538
2101
2102         * DumpRenderTree/LayoutTestController.cpp:
2103         (parsePageNumber):
2104         (isPageBoxVisibleCallback):
2105         (pageAreaRectInPixelsCallback):
2106         (preferredPageSizeInPixelsCallback):
2107         (LayoutTestController::staticFunctions):
2108         * DumpRenderTree/LayoutTestController.h:
2109         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2110         (LayoutTestController::isPageBoxVisible):
2111         (LayoutTestController::pageAreaRectInPixels):
2112         (LayoutTestController::preferredPageSizeInPixels):
2113         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2114         (LayoutTestController::isPageBoxVisible):
2115         (LayoutTestController::pageAreaRectInPixels):
2116         (LayoutTestController::preferredPageSizeInPixels):
2117         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2118         (LayoutTestController::isPageBoxVisible):
2119         (LayoutTestController::pageAreaRectInPixels):
2120         (LayoutTestController::preferredPageSizeInPixels):
2121
2122 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2123
2124         Reviewed by Shinichiro Hamaji.
2125
2126         Follow proper convention for if/switch/while as I've discovered
2127         them to be through my review processes.
2128         https://bugs.webkit.org/show_bug.cgi?id=40723
2129
2130         Modified test so that if( foo ) is not allowed as it appears not
2131         to be the accepted convention.
2132
2133         * Scripts/webkitpy/style/checkers/cpp.py:
2134         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2135
2136 2010-06-22  Eric Seidel  <eric@webkit.org>
2137
2138         Reviewed by Adam Barth.
2139
2140         Run clean-header-guards to fix some header guards
2141         https://bugs.webkit.org/show_bug.cgi?id=41044
2142
2143         No functional changes, thus no tests.
2144
2145         This entire change was generated by running
2146         clean-header-guards, and then reverting changes
2147         to files which shouldn't be changed.  Those which
2148         are left all should be updated.
2149
2150         Some of these changes are just fixing 755 permissions
2151         to be 644, since it seems various files have the wrong
2152         execute bit which don't need it.  clean-header-guards
2153         made those (welcome) permission fixes unintentionally.
2154
2155         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2156         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2157         * QtTestBrowser/fpstimer.h:
2158
2159 2010-06-22  Adam Barth  <abarth@webkit.org>
2160
2161         Reviewed by Eric Seidel.
2162
2163         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2164         https://bugs.webkit.org/show_bug.cgi?id=41043
2165
2166         Update the hash.
2167
2168         * Scripts/do-webcore-rename:
2169
2170 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2171
2172         Reviewed by Shinichiro Hamaji.
2173
2174         Follow proper convention for variable declaration spacing.
2175         https://bugs.webkit.org/show_bug.cgi?id=40724
2176
2177         Modified test so that 'int   a;' is not allowed.
2178
2179         * Scripts/webkitpy/style/checkers/cpp.py:
2180         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2181
2182 2010-06-22  Eric Seidel  <eric@webkit.org>
2183
2184         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2185
2186         * Scripts/webkitpy/common/config/committers.py:
2187
2188 2010-06-22  Eric Seidel  <eric@webkit.org>
2189
2190         Reviewed by Adam Barth.
2191
2192         Remove Gtk 64-Release bot from core since it's broken
2193         https://bugs.webkit.org/show_bug.cgi?id=41022
2194
2195         This bot alone has been responsible for more than 72 hours of
2196         commit-queue blockage in the last week.  The bot is broken -- keeps
2197         losing its display server or similar.  Until the Gtk folks can fix the
2198         bot, we need to remove it from core.  The WebKit community can't keep
2199         it green as is.
2200
2201         * Scripts/webkitpy/common/net/buildbot.py:
2202         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2203
2204 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2205
2206         Reviewed by Eric Seidel.
2207
2208         Fix the Windows build.
2209         https://bugs.webkit.org/show_bug.cgi?id=40972
2210
2211         * DumpRenderTree/win/ImageDiff.vcproj:
2212
2213 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2214
2215         Reviewed by Darin Adler, Dmitry Titov.
2216
2217         DumpRenderTree should allow tests with modal dialogs
2218         https://bugs.webkit.org/show_bug.cgi?id=35350
2219
2220         * DumpRenderTree/LayoutTestController.cpp:
2221         (abortModalCallback):
2222         (LayoutTestController::staticFunctions):
2223         * DumpRenderTree/LayoutTestController.h:
2224         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2225         (LayoutTestController::abortModal):
2226         Add abortModal method to LayoutTestController and make it available from script.
2227
2228         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2229         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2230         abortModal from when modal window closes.
2231         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2232
2233 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2234
2235         Reviewed by Anders Carlsson.
2236         
2237         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2238         https://bugs.webkit.org/show_bug.cgi?id=40948
2239         
2240         Have the script look in WebKit2.
2241
2242         * Scripts/do-webcore-rename:
2243
2244 2010-06-21  Robert Hogan  <robert@webkit.org>
2245
2246         Reviewed by Kenneth Rohde Christiansen.
2247
2248         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2249
2250         It's a Mac-specific test so just add the required LayoutTestController
2251         function as a no-op to avoid failing. Similar approach adopted by other
2252         ports.
2253
2254         https://bugs.webkit.org/show_bug.cgi?id=33344
2255
2256         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2257         (LayoutTestController::addDisallowedURL):
2258
2259 2010-06-21  Sam Weinig  <sam@webkit.org>
2260
2261         Reviewed by Anders Carlsson.
2262
2263         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2264         Add message passing support to the WebKit2 API.
2265
2266         - Add some test messages.
2267
2268         * MiniBrowser/mac/AppDelegate.m:
2269         (_didRecieveMessageFromInjectedBundle):
2270         (-[BrowserAppDelegate init]):
2271         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2272         (_didClearWindow):
2273         (_didCreatePage):
2274         (_didRecieveMessage):
2275         (WKBundleInitialize):
2276
2277 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2278
2279         Unreviewed.
2280
2281         Rolling back 61551 and 61555 due to test failures.
2282
2283         * DumpRenderTree/LayoutTestController.cpp:
2284         (LayoutTestController::staticFunctions):
2285         * DumpRenderTree/LayoutTestController.h:
2286         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2287         (LayoutTestController::setEditingBehavior):
2288         * DumpRenderTree/mac/UIDelegate.mm:
2289
2290 2010-06-21  Anders Carlsson  <andersca@apple.com>
2291
2292         Reviewed by Sam Weinig.
2293
2294         Make DumpRenderTree build with clang++
2295
2296         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2297         (-[LocalPasteboard setPropertyList:forType:]):
2298         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2299         (-[DumpRenderTreeWindow keyDown:]):
2300         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2301         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2302         (LayoutTestController::isCommandEnabled):
2303
2304 2010-06-21  Satish Sampath  <satish@chromium.org>
2305
2306         Reviewed by Steve Block.
2307
2308         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2309         https://bugs.webkit.org/show_bug.cgi?id=40878
2310
2311         * Scripts/build-webkit:
2312
2313 2010-06-21  Kent Tamura  <tkent@chromium.org>
2314
2315         Reviewed by Dimitri Glazkov.
2316
2317         [DRT/Chromium] Initialization for http/tests/loading/
2318         https://bugs.webkit.org/show_bug.cgi?id=40902
2319
2320         * DumpRenderTree/chromium/TestShell.cpp:
2321         (TestShell::runFileTest):
2322
2323 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2324
2325         Unreviewed.
2326
2327         Adding myself to the committers list.
2328
2329         * Scripts/webkitpy/common/config/committers.py:
2330
2331 2010-06-20  Kent Tamura  <tkent@chromium.org>
2332
2333         Reviewed by Dimitri Glazkov.
2334
2335         [DRT/Chromium] Add --allow-external-pages option
2336         https://bugs.webkit.org/show_bug.cgi?id=40762
2337
2338         Add --allow-external-pages introduced by Chromium r45403.
2339         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2340
2341         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2342         (main):
2343         * DumpRenderTree/chromium/TestShell.cpp:
2344         (TestShell::TestShell):
2345         * DumpRenderTree/chromium/TestShell.h:
2346         (TestShell::allowExternalPages):
2347         (TestShell::setAllowExternalPages):
2348         * DumpRenderTree/chromium/WebViewHost.cpp:
2349         (WebViewHost::willSendRequest):
2350
2351 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2352
2353         Reviewed by Adam Barth.
2354
2355         Sheriffbot: Should allow "r" in SVN_REVISION
2356         https://bugs.webkit.org/show_bug.cgi?id=40889
2357
2358         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2359         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2360
2361 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2362
2363         Reviewed by Dimitri Glazkov.
2364
2365         Python Tests Fail after r61508
2366         https://bugs.webkit.org/show_bug.cgi?id=40891
2367
2368         Test's regex list needed to be updated to match the new
2369         regex list in the source code. Added new bots to the
2370         example_buildbots list.
2371
2372         Regex list fixed in r61512. Updated bot list.
2373
2374         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2375
2376 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2377
2378         Unreviewed, build fix.
2379
2380         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2381
2382         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2383
2384 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2385
2386         Unreviewed.
2387
2388         Adding myself to the committers list.
2389
2390         * Scripts/webkitpy/common/config/committers.py:
2391
2392 2010-06-19  Sam Weinig  <sam@webkit.org>
2393
2394         Reviewed by Anders Carlsson.
2395
2396         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2397         Add ability to have a WebProcess per WebContext.
2398
2399         Move to use new shared contexts API.
2400
2401         * MiniBrowser/mac/AppDelegate.h:
2402         * MiniBrowser/mac/AppDelegate.m:
2403         (-[BrowserAppDelegate init]):
2404         (-[BrowserAppDelegate getCurrentPageNamespace]):
2405         (-[BrowserAppDelegate validateMenuItem:]):
2406         (-[BrowserAppDelegate _setProcessModel:]):
2407         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2408         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2409         * MiniBrowser/win/BrowserView.cpp:
2410         (BrowserView::create):
2411
2412 2010-06-02  Robert Hogan  <robert@webkit.org>
2413
2414         Reviewed by Adam Barth.
2415
2416         [Qt] Support evaluateScriptInIsolatedWorld()
2417
2418         https://bugs.webkit.org/show_bug.cgi?id=40079
2419
2420         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2421         (LayoutTestController::evaluateScriptInIsolatedWorld):
2422         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2423
2424 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2425
2426         Reviewed by Darin Adler.
2427
2428         Add three more non-core Chromium builders to start testing DumpRenderTree.
2429         https://bugs.webkit.org/show_bug.cgi?id=40335
2430
2431         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2432
2433 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2434
2435         Reviewed by Darin Fisher.
2436
2437         [Chromium] Plumbing for top-level frame names
2438         https://bugs.webkit.org/show_bug.cgi?id=40430
2439
2440         * DumpRenderTree/chromium/WebViewHost.cpp:
2441         (WebViewHost::reset):
2442         Changed obsolete call to clearName() to use setName(WebString()) instead.
2443
2444 2010-06-18  Sam Weinig  <weinig@apple.com>
2445
2446         Rolling http://trac.webkit.org/changeset/61297 back in.
2447
2448         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2449         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2450         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2451         (_didClearWindow):
2452         (_didCreatePage):
2453         (WKBundleInitialize):
2454
2455 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2456
2457         Reviewed by Darin Adler.
2458
2459         https://bugs.webkit.org/show_bug.cgi?id=40803
2460         TestNetscapePlugin has an incorrect implementation of "property" property
2461
2462         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2463         pass a static string back, it's going to be released by NPAPI implementation.
2464
2465 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2466
2467         Unreviewed.
2468
2469         Adding myself to the committers list.
2470
2471         * Scripts/webkitpy/common/config/committers.py:
2472
2473 2010-06-17  Tony Chang  <tony@chromium.org>
2474
2475         Reviewed by Kent Tamura.
2476
2477         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2478         https://bugs.webkit.org/show_bug.cgi?id=40615
2479
2480         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2481
2482 2010-06-17  Ada Chan  <adachan@apple.com>
2483
2484         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2485
2486         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2487         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2488         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2489
2490 2010-06-17  Darin Adler  <darin@apple.com>
2491
2492         One more try at fix for Chromium build.
2493
2494         * DumpRenderTree/chromium/TestShell.cpp:
2495         (TestShell::TestShell): Use set again instead of =.
2496
2497 2010-06-17  Darin Adler  <darin@apple.com>
2498
2499         Fix Chromium build.
2500
2501         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2502         code with all the other platforms! Wow, that should be fixed at some point.
2503
2504         * DumpRenderTree/chromium/TestShell.cpp:
2505         (TestShell::TestShell): Changed back to using "new".
2506         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2507
2508 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2509
2510         Unreviewed Qt build fix.
2511
2512         LayoutTestController in the Qt DRT is not using refs :)
2513
2514         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2515         (WebCore::DumpRenderTree::DumpRenderTree):
2516
2517 2010-06-17  Darin Adler  <darin@apple.com>
2518
2519         Reviewed by Sam Weinig.
2520
2521         Use adoptRef and create functions in more code paths
2522         https://bugs.webkit.org/show_bug.cgi?id=40760
2523
2524         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2525
2526         * DumpRenderTree/LayoutTestController.cpp:
2527         (LayoutTestController::create): Added.
2528         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2529
2530         * DumpRenderTree/chromium/TestShell.cpp:
2531         (TestShell::TestShell): Use create instead of new.
2532         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2533
2534         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2535         (runTest): Use RefPtr and create instead of OwnPtr and new.
2536
2537         * DumpRenderTree/mac/DumpRenderTree.mm:
2538         (runTest): Use RefPtr and create instead of OwnPtr and new.
2539
2540         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2541         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
2542         instead of new.
2543
2544         * DumpRenderTree/win/DumpRenderTree.cpp:
2545         (runTest): Use RefPtr and create instead of OwnPtr and new.
2546
2547         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2548         (runTest): Use RefPtr and create instead of OwnPtr and new.
2549         (MyApp::OnInit): Removed unneeded code to delete the layout
2550         test controller. This is done during each test.
2551
2552 2010-06-17  Kent Tamura  <tkent@chromium.org>
2553
2554         Reviewed by Shinichiro Hamaji.
2555
2556         [DRT/Chromium] Fix a bug of Windows pixel tests
2557         https://bugs.webkit.org/show_bug.cgi?id=40763
2558
2559         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2560         (TestShellPrinter::handleImage):
2561
2562 2010-06-16  Kent Tamura  <tkent@chromium.org>
2563
2564         Reviewed by Shinichiro Hamaji.
2565
2566         [DRT/Chromium] Fix crash on Mac Release
2567         https://bugs.webkit.org/show_bug.cgi?id=40759
2568
2569         * DumpRenderTree/chromium/WebViewHost.cpp:
2570         (WebViewHost::paintRect): We should not use m_canvas directly because
2571           it is created lazily in canvas().
2572
2573 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2574
2575         [wx] Build fix after new method addition.
2576
2577         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2578         (LayoutTestController::pageProperty):
2579
2580 2010-06-16  Kent Tamura  <tkent@chromium.org>
2581
2582         Reviewed by Dimitri Glazkov.
2583
2584         [DRT/Chromium] Set current working directory for each of tests
2585         https://bugs.webkit.org/show_bug.cgi?id=40668
2586
2587         This change fixes tests with eventSender.beginDragWithFiles().
2588
2589         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2590         (runTest):
2591
2592 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2593
2594         Reviewed by Gustavo Noronha Silva.
2595
2596         [GTK] r60803 broke media/controls-drag-timebar.html
2597         https://bugs.webkit.org/show_bug.cgi?id=40269
2598
2599         Only queue events while the mouse button is down, if drag mode is enabled. Some
2600         tests may disable drag mode, to prevent the queuing of events in this situation.
2601
2602         * DumpRenderTree/gtk/EventSender.cpp:
2603         (sendOrQueueEvent): Only queue events here if dragMode is true.
2604
2605 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2606
2607         Reviewed by Gustavo Noronha Silva.
2608
2609         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
2610         https://bugs.webkit.org/show_bug.cgi?id=40600
2611
2612         * DumpRenderTree/gtk/EventSender.cpp:
2613         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
2614
2615 2010-06-16  Adam Barth  <abarth@webkit.org>
2616
2617         Reviewed by Dimitri Glazkov.
2618
2619         Add a hidden land-cowboy command to webkit-patch to help land quick
2620         build fixes.
2621
2622         * Scripts/webkitpy/tool/commands/download.py:
2623         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2624
2625 2010-06-16  Adam Roben  <aroben@apple.com>
2626
2627         Convert console messages to UTF-8 before printing them
2628
2629         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
2630         http/tests/security/xssAuditor/embed-tag-null-char.html and
2631         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
2632         Windows. (I can't test the fix because Apache is crashing on my
2633         computer.)
2634
2635         Reviewed by Alexey Proskuryakov.
2636
2637         * DumpRenderTree/win/DumpRenderTree.cpp:
2638         (toUTF8): Extracted the code into an overload that takes a wide string
2639         and a length, then added an overload that takes a wstring.
2640
2641         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
2642         overload.
2643
2644         * DumpRenderTree/win/UIDelegate.cpp:
2645         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
2646         UTF-8 instead of letting printf convert to the current code page.
2647
2648 2010-06-16  Drew Wilson  <atwilson@chromium.org>
2649
2650         Reviewed by Kent Tamura.
2651
2652         [Chromium] Plumbing for top-level frame names
2653         https://bugs.webkit.org/show_bug.cgi?id=40430
2654
2655         * DumpRenderTree/chromium/WebViewHost.cpp:
2656         (WebViewHost::createView):
2657         Migrate to new createView() API.
2658         * DumpRenderTree/chromium/WebViewHost.h:
2659         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
2660
2661 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
2662
2663         Reviewed by Kenneth Rohde Christiansen.
2664
2665         [Qt] Scroll wheel event support to graphics based DRT
2666         https://bugs.webkit.org/show_bug.cgi?id=40577
2667
2668         * DumpRenderTree/qt/EventSenderQt.cpp:
2669         (EventSender::continuousMouseScrollBy):
2670         (EventSender::createGraphicsSceneWheelEvent):
2671         * DumpRenderTree/qt/EventSenderQt.h:
2672
2673 2010-06-16  Adam Roben  <aroben@apple.com>
2674
2675         Remove a stray newline from the Windows version of TestNetscapePlugin
2676
2677         Reviewed by Alexey Proskuryakov.
2678
2679         Fixes <http://webkit.org/b/40728>
2680         plugins/geturlnotify-during-document-teardown.html fails on Windows
2681
2682         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2683         (NPP_Destroy): Removed extra newline that the Mac version doesn't
2684         have.
2685
2686 2010-06-16  Adam Roben  <aroben@apple.com>
2687
2688         Respect LayoutTestController::isPrinting on Windows
2689
2690         This gets some printing tests closer to passing (like
2691         printing/page-rule-in-media-query.html).
2692
2693         Fixes <http://webkit.org/b/40727>.
2694
2695         Reviewed by Dan Bernstein.
2696
2697         * DumpRenderTree/win/DumpRenderTree.cpp:
2698         (dump): Pass LayoutTestController::isPrinting to
2699         IWebFramePrivate::renderTreeAsExternalRepresentation.
2700
2701 2010-06-15  Adam Barth  <abarth@webkit.org>
2702
2703         Reviewed by Eric Seidel.
2704
2705         Enable HTML5 lexer
2706         https://bugs.webkit.org/show_bug.cgi?id=40650
2707
2708         * DumpRenderTree/mac/DumpRenderTree.mm:
2709         (initializeGlobalsFromCommandLineOptions):
2710
2711 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
2712
2713         Reviewed by Shinichiro Hamaji.
2714
2715         Implement render style selection for pages to support CSS3 Paged Media.
2716         https://bugs.webkit.org/show_bug.cgi?id=35961
2717
2718         * DumpRenderTree/LayoutTestController.cpp:
2719         (parsePagePropertyParameters):
2720         (pagePropertyCallback):
2721         (LayoutTestController::staticFunctions):
2722         * DumpRenderTree/LayoutTestController.h:
2723         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2724         (LayoutTestController::pageProperty):
2725         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2726         (LayoutTestController::pageProperty):
2727         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2728         (LayoutTestController::pageProperty):
2729
2730 2010-06-15  Sam Weinig  <sam@webkit.org>
2731
2732         Reviewed by Anders Carlsson.
2733
2734         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
2735         WebKit2: Add mechanism to inject code into the WebProcess on startup
2736
2737         Add initial InjectedBundle support.
2738
2739         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2740         * MiniBrowser/WebBundle-Info.plist: Added.
2741         Add test InjectedBundle to the project.
2742
2743         * MiniBrowser/mac/AppDelegate.m:
2744         (-[BrowserAppDelegate init]):
2745         Get the path to the WebBundle from the the main bundle and pass it to the new
2746         WKContextCreateWithInjectedBundlePath function.
2747
2748         * MiniBrowser/mac/BrowserWindowController.m:
2749         (_didChangeProgress):
2750         Fix the build.  This has been broken for a while.
2751
2752         * MiniBrowser/mac/WebBundle: Added.
2753         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
2754         (_didCreatePage):
2755         (WKBundleInitialize):
2756         Add really basic InjectedBundle.
2757
2758         * MiniBrowser/win/BrowserView.cpp:
2759         (BrowserView::create):
2760         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
2761
2762 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
2763
2764         Reviewed by Darin Adler.
2765
2766         Adding myself to the reviewers list.
2767         https://bugs.webkit.org/show_bug.cgi?id=40693
2768
2769         * Scripts/webkitpy/common/config/committers.py:
2770
2771 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
2772
2773         Reviewed by Xan Lopez.
2774
2775         Switch to using GIO methods instead of realpath in GtkLauncher to determine
2776         the file URI. This should remove warnings about realpath being undefined
2777         when compiling with '-ansi'.
2778
2779         * GtkLauncher/main.c:
2780         (filenameToURL): Use GIO instead of realpath to determine file URI.
2781
2782 2010-06-15  Adam Roben  <aroben@apple.com>
2783
2784         Remove the redundant set-apple-windows-environment-variables script
2785
2786         Apparently update-webkit does this for you these days.
2787
2788         Rubber-stamped by Steve Falkenburg.
2789
2790         * Scripts/set-apple-windows-environment-variables: Removed.
2791
2792 2010-06-14  Adam Roben  <aroben@apple.com>
2793
2794         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
2795         environment variables
2796
2797         Fixes <http://webkit.org/b/40595>.
2798
2799         Reviewed by Steve Falkenburg.
2800
2801         * Scripts/set-apple-windows-environment-variables: Added.
2802         (to_windows_path): Passes the passed-in path through cygpath to
2803         generate a Windows-style path.
2804         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
2805         variables to their defaults, if they aren't already set.
2806
2807 2010-06-14  Adam Roben  <aroben@apple.com>
2808
2809         Speed up run-safari/debug-safari on Windows
2810
2811         Fixes <http://webkit.org/b/40586>.
2812
2813         Reviewed by Steve Falkenburg.
2814
2815         * Scripts/webkitdirs.pm:
2816         (runSafari): When debugging, set up the environment to run Safari
2817         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
2818         actually launch the debugger. When not debugging, just run WebKit.exe
2819         and it will do the rest for us.
2820
2821 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
2822
2823         Reviewed by Kenneth Rohde Christiansen.
2824
2825         [Qt] DRT EventSender support to graphics context events
2826         https://bugs.webkit.org/show_bug.cgi?id=40324
2827
2828         * DumpRenderTree/qt/EventSenderQt.cpp:
2829         (EventSender::contextClick):
2830
2831 2010-06-14  Tony Chang  <tony@chromium.org>
2832
2833         Reviewed by Darin Fisher.
2834
2835         [chromium] checkout chromium third_party directly
2836         https://bugs.webkit.org/show_bug.cgi?id=40556
2837
2838         * Scripts/update-webkit-chromium: some migration code for the bots
2839
2840 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2841
2842         Chromium build fix.
2843
2844         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
2845         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
2846
2847 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2848
2849         Reviewed by Darin Adler.
2850
2851         https://bugs.webkit.org/show_bug.cgi?id=40529
2852         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
2853
2854         * DumpRenderTree/mac/EventSendingController.mm:
2855         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
2856         event for "delete" - it had virtual key code from forward delete, and text from backspace.
2857         Fixed "delete" to mean forward delete.
2858
2859         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
2860         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
2861         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2862         Mac DRT confusion has propagated to other platforms, fixing those.
2863
2864 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
2865
2866         Reviewed by Xan Lopez.
2867
2868         Small GtkLauncher build fix for some systems.
2869
2870         * GtkLauncher/main.c: Add <limit.h> include.
2871
2872 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2873
2874         Reviewed by Laszlo Gombos.
2875
2876         [Qt] navigator.geolocation support for Qt port
2877         https://bugs.webkit.org/show_bug.cgi?id=39724
2878
2879         Implementation for geolocation cases to DumpRenderTreeQt
2880
2881         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2882         (WebCore::WebPage::allowGeolocationRequest):
2883         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2884         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2885         (LayoutTestController::setGeolocationPermission):
2886         (LayoutTestController::setMockGeolocationError):
2887         (LayoutTestController::setMockGeolocationPosition):
2888         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2889         (LayoutTestController::isGeolocationPermissionSet):
2890         (LayoutTestController::geolocationPermission):
2891
2892 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
2893
2894         Reviewed by Darin Adler.
2895
2896         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
2897         be a way of overwriting the Xcode system path.  Making
2898         $WEBKITOUTPUTDIR take precedence over the system default would make
2899         this possible.
2900
2901         * Scripts/webkitdirs.pm:
2902
2903 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
2904
2905         Reviewed by Darin Adler.
2906
2907         AX: link won't return linked element if URL contains #
2908         https://bugs.webkit.org/show_bug.cgi?id=40192
2909
2910         * DumpRenderTree/AccessibilityUIElement.cpp:
2911         (linkedUIElementAtIndexCallback):
2912         (AccessibilityUIElement::getJSClass):
2913         * DumpRenderTree/AccessibilityUIElement.h:
2914         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2915         (AccessibilityUIElement::linkedUIElementAtIndex):
2916         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2917         (AccessibilityUIElement::linkedUIElementAtIndex):
2918         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2919         (AccessibilityUIElement::linkedUIElementAtIndex):
2920
2921 2010-06-13  Adam Barth  <abarth@webkit.org>
2922
2923         Reviewed by Darin Adler.
2924
2925         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
2926         https://bugs.webkit.org/show_bug.cgi?id=39550
2927
2928         This can cause an extra request to bugs.webkit.org durig upload, but it
2929         shouldn't be too bad.  Also, this won't work if you remove the
2930         boilerplate created by prepare-ChangeLog.
2931
2932         * Scripts/webkitpy/common/checkout/changelog.py:
2933         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2934         * Scripts/webkitpy/common/net/bugzilla.py:
2935         * Scripts/webkitpy/tool/steps/abstractstep.py:
2936         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2937         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
2938
2939 2010-06-08  Robert Hogan  <robert@webkit.org>
2940
2941         Reviewed by Eric Seidel.
2942
2943         [Qt] Add support for callShouldCloseOnWebView() to DRT
2944         https://bugs.webkit.org/show_bug.cgi?id=40330
2945
2946         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2947         (LayoutTestController::callShouldCloseOnWebView):
2948         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2949         (LayoutTestController::setCallCloseOnWebViews):
2950
2951 2010-06-12  Eric Seidel  <eric@webkit.org>
2952
2953         Reviewed by Daniel Bates.
2954
2955         do-webcore-rename should have a --verbose option
2956         https://bugs.webkit.org/show_bug.cgi?id=40497
2957
2958         * Scripts/do-webcore-rename:
2959          - Unified how we handle skipping files/directories
2960            this will allow us to "black list" certain files and
2961            directories when performing renames.
2962          - Made do-webcore-rename log what it's skipping when passed --verbose.
2963
2964 2010-06-12  Darin Adler  <darin@apple.com>
2965
2966         * Scripts/run-bindings-tests: Fixed a typo in a message.
2967
2968 2010-06-12  Kent Tamura  <tkent@chromium.org>
2969
2970         Reviewed by Dimitri Glazkov.
2971
2972         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
2973         https://bugs.webkit.org/show_bug.cgi?id=40402
2974
2975         _build_path() of each Chromium port check existence of build path
2976         of Chromium checkout first, then check existence of build path of
2977         WebKit-only checkout.
2978
2979         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2980         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2981         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2982
2983 2010-06-12  Robert Hogan  <robert@webkit.org>
2984
2985         Reviewed by Kenneth Rohde Christiansen.
2986
2987         [Qt] Back-forward list dumping is incorrect
2988
2989         https://bugs.webkit.org/show_bug.cgi?id=36392
2990
2991         Support dumping child history items in DRT.
2992
2993         Unskip:
2994
2995         fast/loader/frame-src-change-added-to-history.html
2996         fast/loader/frame-src-change-not-added-to-history.html
2997         fast/loader/frame-location-change-not-added-to-history.html
2998
2999         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3000         (WebCore::dumpHistoryItem):
3001
3002 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3003
3004         Reviewed by Eric Seidel.
3005
3006         upload all patches that lack in-rietveld to rietveld
3007         https://bugs.webkit.org/show_bug.cgi?id=40444
3008
3009         If it's a patch, then we'll try to upload it as long as it
3010         doesn't have in-rietveld set. No longer set in-rietveld? since
3011         it's not needed.
3012
3013         * Scripts/webkitpy/common/net/bugzilla.py:
3014
3015 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3016
3017         Reviewed by Darin Fisher.
3018
3019         Fix rietveld upload when message length > 100 characters
3020         https://bugs.webkit.org/show_bug.cgi?id=40457
3021
3022         * Scripts/webkitpy/common/net/rietveld.py:
3023
3024 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3025
3026         Reviewed by Laszlo Gombos.
3027
3028         [Qt] There should be a way to enable popups in QtTestBrowser
3029         https://bugs.webkit.org/show_bug.cgi?id=40427
3030
3031         * QtTestBrowser/main.cpp:
3032         (LauncherWindow::toggleJavascriptCanOpenWindows):
3033         (LauncherWindow::createChrome):
3034
3035 2010-06-10  Adam Barth  <abarth@webkit.org>
3036
3037         Reviewed by Daniel Bates.
3038
3039         Make SheriffBot more chatty
3040         https://bugs.webkit.org/show_bug.cgi?id=40463
3041
3042         People seem to like to talk to SheriffBot, so let's make him chat back.
3043
3044         * Scripts/webkitpy/thirdparty/__init__.py:
3045         * Scripts/webkitpy/tool/bot/irc_command.py:
3046         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3047         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3048         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3049
3050 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3051
3052         Reviewed by Darin Adler.
3053
3054         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3055         
3056         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3057         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3058         WEXITSTATUS on $result instead of just comparing $result to 0.
3059
3060         * Scripts/update-webkit-auxiliary-libs:
3061
3062 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3063
3064         Reviewed by Alexey Proskuryakov.
3065
3066         don't use Exception.message as it's deprecated in python 2.6+
3067         https://bugs.webkit.org/show_bug.cgi?id=40449
3068
3069         * Scripts/webkitpy/tool/commands/queues.py:
3070
3071 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3072
3073         Reviewed by Adam Barth.
3074
3075         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3076         https://bugs.webkit.org/show_bug.cgi?id=40436
3077
3078         * Scripts/webkitpy/common/system/outputcapture.py:
3079         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3080         * Scripts/webkitpy/tool/commands/queues.py:
3081         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3082         * Scripts/webkitpy/tool/commands/queuestest.py:
3083         * Scripts/webkitpy/tool/mocktool.py:
3084
3085 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3086
3087         Reviewed by Simon Hausmann.
3088
3089         [Qt] *All* WebGL layout tests fail!
3090         https://bugs.webkit.org/show_bug.cgi?id=40296
3091
3092         Added test for WebKitWebGLEnabled to
3093         LayoutTestController::overridePreference().
3094
3095         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3096         (LayoutTestController::overridePreference):
3097
3098 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3099
3100         Reviewed by Kenneth Rohde Christiansen.
3101
3102         [Qt] DRT EventSender support to graphics mouse events activation
3103         https://bugs.webkit.org/show_bug.cgi?id=40017
3104
3105         * DumpRenderTree/qt/EventSenderQt.cpp:
3106         (EventSender::mouseDown):
3107         (EventSender::mouseUp):
3108         (EventSender::mouseMoveTo):
3109         (EventSender::keyDown):
3110         (EventSender::contextClick):
3111         (EventSender::sendTouchEvent):
3112         (EventSender::sendOrQueueEvent):
3113         (EventSender::eventFilter):
3114         (EventSender::createGraphicsSceneMouseEvent):
3115         (EventSender::sendEvent):
3116         * DumpRenderTree/qt/EventSenderQt.h:
3117         (EventSender::isGraphicsBased):
3118
3119 2010-06-09  Adam Barth  <abarth@webkit.org>
3120
3121         Reviewed by Ojan Vafai.
3122
3123         webkit-patch upload fails for security bugs because there's no rietveld flag
3124         https://bugs.webkit.org/show_bug.cgi?id=40309
3125
3126         There's probably a more elegant way of seeing whether the form control
3127         exists, but this seems to work.
3128
3129         * Scripts/webkitpy/common/net/bugzilla.py:
3130
3131 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3132
3133         Reviewed by Adam Barth.
3134
3135         make rietveld upload faster and avoid posting to bug on errors
3136         https://bugs.webkit.org/show_bug.cgi?id=40389
3137
3138         Only grab the first item of the upload queue instead of trying
3139         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3140
3141         Also, don't post comments to the bug when uploading fails.
3142
3143         * Scripts/webkitpy/common/net/bugzilla.py:
3144         * Scripts/webkitpy/tool/commands/queues.py:
3145         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3146         * Scripts/webkitpy/tool/commands/stepsequence.py:
3147         * Scripts/webkitpy/tool/mocktool.py:
3148
3149 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3150
3151         Reviewed by Adam Barth.
3152
3153         Rietveld upload queue fails when setting in-rietveld flag
3154         https://bugs.webkit.org/show_bug.cgi?id=40371
3155
3156         Make the comment arguments to set_flag_on_attachment optional
3157         and add it to the MockBugzilla.
3158
3159         * Scripts/webkitpy/common/net/bugzilla.py:
3160         * Scripts/webkitpy/tool/bot/queueengine.py:
3161         * Scripts/webkitpy/tool/commands/download_unittest.py:
3162         * Scripts/webkitpy/tool/commands/queues.py:
3163         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3164         * Scripts/webkitpy/tool/mocktool.py:
3165
3166 2010-06-09  Kenneth Russell  <kbr@google.com>
3167
3168         Reviewed by Dimitri Glazkov.
3169
3170         Rename FloatArray to Float32Array
3171         https://bugs.webkit.org/show_bug.cgi?id=40323
3172
3173         Used do-webcore-rename to perform renaming. Manually undid
3174         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3175         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3176         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3177         all layout tests on Safari; built Chromium and ran selected WebGL
3178         tests.
3179
3180         * Scripts/do-webcore-rename:
3181
3182 2010-06-08  Tony Chang  <tony@chromium.org>
3183
3184         Reviewed by David Levin.
3185
3186         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3187         https://bugs.webkit.org/show_bug.cgi?id=40285
3188
3189         * Scripts/webkitdirs.pm:
3190         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3191
3192 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3193
3194         Reviewed by Tamura Kent.
3195
3196         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3197         https://bugs.webkit.org/show_bug.cgi?id=40052
3198         
3199         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3200
3201         * DumpRenderTree/DumpRenderTree.gypi:
3202         * DumpRenderTree/chromium/TestShellWin.cpp:
3203         (platformInit):
3204         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3205         (WebKit::):
3206         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3207         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3208         (WebKit::WebThemeControlDRT::box):
3209         (WebKit::WebThemeControlDRT::line):
3210         (WebKit::WebThemeControlDRT::triangle):
3211         (WebKit::WebThemeControlDRT::roundRect):
3212         (WebKit::WebThemeControlDRT::oval):
3213         (WebKit::WebThemeControlDRT::circle):
3214         (WebKit::WebThemeControlDRT::nestedBoxes):
3215         (WebKit::WebThemeControlDRT::markState):
3216         (WebKit::WebThemeControlDRT::draw):
3217         (WebKit::WebThemeControlDRT::drawTextField):
3218         (WebKit::WebThemeControlDRT::drawProgressBar):
3219         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3220         (WebKit::WebThemeControlDRT::):
3221         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3222         (WebKit::):
3223         (WebKit::WebThemeEngineDRT::paintButton):
3224         (WebKit::WebThemeEngineDRT::paintMenuList):
3225         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3226         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3227         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3228         (WebKit::WebThemeEngineDRT::paintTextField):
3229         (WebKit::WebThemeEngineDRT::paintTrackbar):
3230         (WebKit::WebThemeEngineDRT::paintProgressBar):
3231         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3232         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3233
3234 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3235
3236         Unreviewed, rolling out r60878.
3237         http://trac.webkit.org/changeset/60878
3238         https://bugs.webkit.org/show_bug.cgi?id=40349
3239
3240         broke linux build (Requested by tony^work on #webkit).
3241
3242         * Scripts/webkitdirs.pm:
3243         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3244
3245 2010-06-08  Tony Chang  <tony@chromium.org>
3246
3247         Reviewed by David Levin.
3248
3249         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3250         https://bugs.webkit.org/show_bug.cgi?id=40285
3251
3252         * Scripts/webkitdirs.pm:
3253         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3254
3255 2010-06-08  Kenneth Russell  <kbr@google.com>
3256
3257         Unreviewed, build fix.
3258
3259         Fix build breakage from 38145
3260         https://bugs.webkit.org/show_bug.cgi?id=40346
3261
3262         The fix for bug 38145 broke the Chromium Win build because
3263         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3264         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3265         tests in Safari on Mac OS X. Changed download mirrors for
3266         python-irclib to working ones.
3267
3268         * Scripts/webkitpy/thirdparty/__init__.py:
3269
3270 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3271
3272         Reviewed by Eric Seidel.
3273
3274         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3275         https://bugs.webkit.org/show_bug.cgi?id=39058
3276
3277         * Scripts/old-run-webkit-tests:
3278          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3279
3280 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3281
3282         Unreviewed buildfix after r60479.
3283
3284         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3285         versions other than 2.17.3.
3286
3287         * DumpRenderTree/gtk/EventSender.cpp:
3288         (getRootCoords):
3289
3290 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3291
3292         Reviewed by Oliver Hunt.
3293
3294         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3295         https://bugs.webkit.org/show_bug.cgi?id=40267
3296
3297         When a mouse button is down, automatically queue mouse motion events and
3298         do not play them back until the mouse button is released. This matches the
3299         behavior of other ports' EventSenders.
3300
3301         * DumpRenderTree/gtk/EventSender.cpp:
3302         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3303         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3304
3305 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3306
3307         Reviewed by Sam Weinig.
3308
3309         Add CPP bindings generator
3310         https://bugs.webkit.org/show_bug.cgi?id=38279
3311
3312         Integrate CPP bindings in run-bindings-tests.
3313
3314         * Scripts/run-bindings-tests:
3315
3316 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3317
3318         Reviewed by Ojan Vafai.
3319
3320         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3321         https://bugs.webkit.org/show_bug.cgi?id=40183
3322
3323         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3324
3325 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3326
3327         Unreviewed.
3328
3329         Add my new email and IRC nick to committers.py.
3330
3331         * Scripts/webkitpy/common/config/committers.py:
3332
3333 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
3334
3335         Unreviewed.
3336
3337         Revert changes in json_results_generator.py's _get_svn_revision.
3338
3339         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3340
3341 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3342
3343         Reviewed by Xan Lopez.
3344
3345         [GTK] GtkLauncher should support relative file paths
3346         https://bugs.webkit.org/show_bug.cgi?id=39944
3347
3348         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
3349
3350         * GtkLauncher/main.c:
3351         (filename_to_url): Added.
3352         (main): Try to resolve arguments as relative file URLs first.
3353
3354 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3355
3356         Reviewed by Xan Lopez.
3357
3358         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
3359         https://bugs.webkit.org/show_bug.cgi?id=40182
3360
3361         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
3362         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
3363         without breaking DRT.
3364
3365         * DumpRenderTree/gtk/EventSender.cpp:
3366         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
3367         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
3368
3369 2010-06-04  Anders Carlsson  <andersca@apple.com>
3370
3371         Reviewed by David Hyatt.
3372
3373         Make the editing/spelling/context-menu-suggestions.html test more robust
3374         https://bugs.webkit.org/show_bug.cgi?id=40178
3375
3376         Change the contextClick method to return an array of strings describing the context menu items.
3377
3378         * DumpRenderTree/mac/EventSendingController.mm:
3379         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3380         (+[EventSendingController webScriptNameForSelector:]):
3381         (-[EventSendingController contextClick]):
3382
3383 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
3384
3385         Reviewed by Shinichiro Hamaji.
3386
3387         Clean up chromium-specific code from json_results_generator.py.
3388         https://bugs.webkit.org/show_bug.cgi?id=39665
3389
3390         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3391         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3392         * Scripts/webkitpy/layout_tests/port/base.py:
3393         * Scripts/webkitpy/layout_tests/port/chromium.py:
3394
3395 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3396
3397         Reviewed by Adam Barth.
3398
3399         Utilize new takeFirst() method where appropriate.
3400         https://bugs.webkit.org/show_bug.cgi?id=40089
3401
3402         * DumpRenderTree/chromium/EventSender.cpp:
3403         (EventSender::replaySavedEvents):
3404         * DumpRenderTree/chromium/LayoutTestController.cpp:
3405         (LayoutTestController::WorkQueue::processWork):
3406         (LayoutTestController::WorkQueue::reset):
3407
3408 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
3409
3410         Reviewed by Simon Hausmann.
3411
3412         [Qt] QtTestLauncher should allow notifications by default.
3413         https://bugs.webkit.org/show_bug.cgi?id=40078
3414
3415         * QtTestBrowser/main.cpp:
3416         (NotificationsPermissionController::NotificationsPermissionController):
3417         (NotificationsPermissionController::checkPermission):
3418         (NotificationsPermissionController::requestPermission):
3419         (LauncherWindow::LauncherWindow):
3420
3421 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3422
3423         Reviewed by Adam Barth.
3424
3425         Detect whether the user's environment can open a browser.
3426         https://bugs.webkit.org/show_bug.cgi?id=40136
3427
3428         Some environments like cygwin silently fail webbrowser.open() causing
3429         webkit-patch upload not to display any diff. This detects environments
3430         where webbrowser.open() would fail by testing if webbrowser.get()
3431         raises an exception.
3432
3433         * Scripts/webkitpy/common/system/user.py:
3434         * Scripts/webkitpy/tool/mocktool.py:
3435         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3436
3437 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
3438
3439         Reviewed by David Levin.
3440
3441         Add dependencies required to link with VS Express 2005.
3442         https://bugs.webkit.org/show_bug.cgi?id=40038
3443
3444         Visual Studio implicitly links against these libs.
3445         VC++ Express does not.
3446
3447         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3448         * WinLauncher/WinLauncher.vcproj:
3449
3450 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3451
3452         Reviewed by David Levin.
3453
3454         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
3455         https://bugs.webkit.org/show_bug.cgi?id=40105
3456
3457         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3458         - kill pywebsocket process when url is not alive and the process is not
3459           terminated, not to leave pywebsocket server running.
3460         - fix codecs.open parameters.
3461
3462 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3463
3464         Reviewed by Alexey Proskuryakov.
3465
3466         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3467         https://bugs.webkit.org/show_bug.cgi?id=39058
3468
3469         * Scripts/ensure-valid-python:
3470           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
3471           - Add --check-only and --help option.
3472           - --check-only option only checks python version and don't try to install Python 2.5.
3473           - Set executable bit.
3474         * Scripts/old-run-webkit-tests:
3475           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
3476
3477 2010-05-14  Ojan Vafai  <ojan@chromium.org>
3478
3479         Reviewed by Adam Barth.
3480
3481         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
3482         https://bugs.webkit.org/show_bug.cgi?id=38918
3483
3484         Patches with in-rietveld? get uploaded to rietveld and get marked
3485         in-rietveld+. If the upload fails, they are marked in-rietveld-
3486         and an error is logged to the bug, like the commit-queue.
3487
3488         Also, get rid of --fancy-review and the ability to upload to rietveld
3489         using webkit-patch upload/post.
3490
3491         * Scripts/webkitpy/common/net/bugzilla.py:
3492         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3493         * Scripts/webkitpy/tool/commands/download.py:
3494         * Scripts/webkitpy/tool/commands/download_unittest.py:
3495         * Scripts/webkitpy/tool/commands/queues.py:
3496         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3497         * Scripts/webkitpy/tool/commands/upload.py:
3498         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3499         * Scripts/webkitpy/tool/mocktool.py:
3500         * Scripts/webkitpy/tool/steps/options.py:
3501         * Scripts/webkitpy/tool/steps/postcodereview.py:
3502
3503 2010-05-24  Ojan Vafai  <ojan@chromium.org>
3504
3505         Reviewed by Chris Jerdonek.
3506
3507         many webkit-patch commands fail in a non-svn tracking git checkout
3508         https://bugs.webkit.org/show_bug.cgi?id=38156
3509
3510         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
3511         If neither exists, then error out. This makes webkit-patch work
3512         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
3513         to checkout webkit. The fallback to master is for people who don't
3514         do the steps on that page for tracking svn.
3515
3516         * Scripts/webkitpy/common/checkout/scm.py:
3517         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3518
3519 2010-06-03  Mike Fenton  <mifenton@rim.com>
3520
3521         Unreviewed.
3522
3523         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
3524
3525         * Scripts/webkitpy/common/config/committers.py:
3526
3527 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
3528
3529         Reviewed by Yury Semikhatsky.
3530
3531         Web Inspector: a number of fixes that make InspectorController
3532         happy with null redirects.
3533
3534         https://bugs.webkit.org/show_bug.cgi?id=40109
3535
3536         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3537         (runTest):
3538         * DumpRenderTree/mac/DumpRenderTree.mm:
3539         (runTest):
3540         * DumpRenderTree/win/DumpRenderTree.cpp:
3541         (runTest):
3542
3543 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
3544
3545         Reviewed by Shinichiro Hamaji.
3546
3547         [Qt] Fix compilation with QT_NO_PROPERTIES
3548         https://bugs.webkit.org/show_bug.cgi?id=38324
3549
3550         * QtTestBrowser/main.cpp:
3551         (LauncherWindow::init):
3552
3553 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
3554
3555         Reviewed by Kenneth Rohde Christiansen.
3556
3557         [Qt] Make possible run DRT with QGraphicsWebView
3558         https://bugs.webkit.org/show_bug.cgi?id=40016
3559
3560         Make possible to use a environment variable for switching backend.
3561         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
3562
3563         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3564         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
3565         (WebCore::DumpRenderTree::DumpRenderTree):
3566         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3567         (WebCore::DumpRenderTree::setGraphicsBased):
3568         (WebCore::DumpRenderTree::isGraphicsBased):
3569         (WebCore::WebViewGraphicsBased::graphicsView):
3570         (WebCore::WebViewGraphicsBased::setPage):
3571         * Scripts/old-run-webkit-tests:
3572
3573 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
3574
3575         Reviewed by Eric Seidel.
3576
3577         Slave lost shouldn't be recognized as build failed.
3578         https://bugs.webkit.org/show_bug.cgi?id=39282
3579
3580         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
3581         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
3582
3583 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
3584
3585         Reviewed by Kenneth Rohde Christiansen.
3586
3587         [Qt] Fix the lifecycle of notification objects
3588         https://bugs.webkit.org/show_bug.cgi?id=40003
3589
3590         Remove the dependency of notifications on QWebPage.
3591
3592         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3593         (WebCore::requestPermissionCallback):
3594         (WebCore::WebPage::WebPage):
3595         (WebCore::DumpRenderTree::requestPermission):
3596         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3597
3598 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3599
3600         Unreviewed, rolling out r60559.
3601         http://trac.webkit.org/changeset/60559
3602         https://bugs.webkit.org/show_bug.cgi?id=40055
3603
3604         It broke python unit test (Requested by Ossy on #webkit).
3605
3606         * Scripts/webkitpy/common/net/buildbot.py:
3607
3608 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
3609
3610         Reviewed by Eric Seidel.
3611
3612         Slave lost shouldn't be recognized as build failed.
3613         https://bugs.webkit.org/show_bug.cgi?id=39282
3614
3615         * Scripts/webkitpy/common/net/buildbot.py:
3616
3617 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
3618
3619         Reviewed by Eric Seidel.
3620
3621         Fix crash caused when assigned_to is disabled
3622         https://bugs.webkit.org/show_bug.cgi?id=40039
3623
3624         * Scripts/webkitpy/common/net/bugzilla.py:
3625
3626 2010-06-02  Sterling Swigart  <sswigart@google.com>
3627
3628         Reviewed by David Levin.
3629
3630         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
3631         https://bugs.webkit.org/show_bug.cgi?id=39906
3632
3633         * Scripts/build-webkit:
3634
3635 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
3636
3637         Reviewed by Simon Hausmann.
3638
3639         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
3640
3641         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3642         (WebCore::WebPage::WebPage):
3643         (WebCore::WebPage::resetSettings):
3644         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3645         (LayoutTestController::setJavaScriptCanAccessClipboard):
3646
3647 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3648
3649         Reviewed by Mark Rowe.
3650
3651         A nicer Tiger build fix.
3652
3653         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3654         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3655         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
3656
3657 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3658
3659         A real Tiger build fix.
3660
3661         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
3662         for all configurations, not just debug.
3663
3664 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3665
3666         Tiger build fix.
3667
3668         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
3669
3670 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3671
3672         Reviewed by Xan Lopez.
3673
3674         [GTK] Get more mouse tests passing
3675         https://bugs.webkit.org/show_bug.cgi?id=39040
3676
3677         Reproduce the logic from the Windows EventSender for mapping
3678         button numbers to GDK button numbers. Move this logic to the
3679         prepareMouseButtonEvent helper.
3680
3681         * DumpRenderTree/gtk/EventSender.cpp:
3682         (prepareMouseButtonEvent): Reproduce Windows logic.
3683         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
3684         (mouseDownCallback): Ditto.
3685         (mouseUpCallback): Ditto.
3686
3687 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3688
3689         Reviewed by Sam Weinig.
3690
3691         https://bugs.webkit.org/show_bug.cgi?id=39434
3692         REGRESSION (r59811): Geolocation callbacks cannot be created
3693
3694         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
3695
3696         * DumpRenderTree/mac/DumpRenderTree.mm:
3697         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
3698         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
3699         into subsequent tests.
3700
3701         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3702         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
3703         (LayoutTestController::setMockGeolocationError): Ditto.
3704
3705         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
3706         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
3707         (+[MockGeolocationProvider shared]):
3708         (-[MockGeolocationProvider dealloc]):
3709         (-[MockGeolocationProvider setPosition:]):
3710         (-[MockGeolocationProvider setError:]):
3711         (-[MockGeolocationProvider registerWebView:]):
3712         (-[MockGeolocationProvider unregisterWebView:]):
3713         (-[MockGeolocationProvider lastPosition]):
3714         (-[MockGeolocationProvider stopTimer]):
3715         (-[MockGeolocationProvider timerFired]):
3716
3717         * DumpRenderTree/mac/UIDelegate.mm:
3718         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3719         This delegate method must send a response. I'm not sure what the two-stage check is supposed
3720         to achieve, it seems unnecessary.
3721
3722 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
3723
3724         Reviewed by Xan Lopez.
3725
3726         [GTK] Double clicks cause three button press events
3727         https://bugs.webkit.org/show_bug.cgi?id=38853
3728
3729         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
3730         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
3731         the GDK event queue entirely, we simply do not send the extra event.
3732
3733         * DumpRenderTree/gtk/EventSender.cpp:
3734         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
3735         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
3736
3737 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3738
3739         Not reviewed. Build fix.
3740
3741         Fix GTK+ build caused by a bad merge.
3742
3743         * DumpRenderTree/gtk/EventSender.cpp: 
3744         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
3745
3746 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
3747
3748         Reviewed by Xan Lopez.
3749
3750         [GTK] Double clicks cause three button press events
3751         https://bugs.webkit.org/show_bug.cgi?id=38853
3752
3753         Small EventSender cleanups. Consolidate some common code. Style fixes.
3754
3755         * DumpRenderTree/gtk/EventSender.cpp:
3756         (prepareMouseButtonEvent): Added.
3757         (contextClickCallback): Use prepareMouseButtonEvent.
3758         (mouseDownCallback): Use prepareMouseButtonEvent.
3759         (mouseUpCallback): Use prepareMouseButtonEvent.
3760         (mouseMoveToCallback): Small style fix.
3761
3762 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3763
3764         Reviewed by Xan Lopez.
3765
3766         [GTK] Double clicks cause three button press events
3767         https://bugs.webkit.org/show_bug.cgi?id=38853
3768
3769         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
3770         to pause for a specified amount of time. It is used in the processing of drag-
3771         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
3772         This patch enables tests that rely on the latter behavior to pass.
3773
3774         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3775         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
3776         * DumpRenderTree/gtk/EventSender.cpp:
3777         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
3778         (contextClickCallback): Use sendOrQueueEvent.
3779         (updateClickCount): Take the time offset into account when counting clicks.
3780         (mouseDownCallback): Use sendOrQueueEvent.
3781         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
3782         (mouseUpCallback): Use sendOrQueueEvent.
3783         (mouseMoveToCallback): Ditto.
3784         (mouseWheelToCallback): Ditto.
3785         (sendOrQueueEvent): Added.
3786         (dispatchEvent): Added.
3787         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
3788         (makeEventSender): Only initialize the EventSender when loading the top frame.
3789         * DumpRenderTree/gtk/EventSender.h: Ditto.
3790
3791 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3792
3793         Reviewed by Xan Lopez.
3794
3795         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
3796         https://bugs.webkit.org/show_bug.cgi?id=39101
3797
3798         Work around timing issues for render tree dumps by pumping the
3799         main loop before doing the dump. Resize events are asynchronous
3800         in GTK+, so sometimes resize requests are still pending when DRT
3801         dumps the tree.
3802
3803         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3804         (dump): Pump the main loop before dumping the render tree.
3805
3806 2010-05-31  Kent Tamura  <tkent@chromium.org>
3807
3808         Reviewed by Dimitri Glazkov.
3809
3810         [DRT/Chromium] Fix crash of a test after another test with multiple windows
3811         https://bugs.webkit.org/show_bug.cgi?id=39942
3812
3813         If a test opens multiple windows, focuses on non-main window, and
3814         the focused window is closed, TestShell::m_focusedWidget points a
3815         deleted object.
3816
3817         * DumpRenderTree/chromium/TestShell.cpp:
3818         (TestShell::closeWindow): Clear m_focusedWidget.
3819
3820 2010-05-30  Kent Tamura  <tkent@chromium.org>
3821
3822         Reviewed by Dimitri Glazkov.
3823
3824         new-run-webkit-tests: Support DRT on Chromium-win
3825         https://bugs.webkit.org/show_bug.cgi?id=39810
3826
3827         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
3828         it behaves like test_shell about command analysis, printing
3829         format, pixel dumping, and timeout handling.
3830
3831         chromium.py and chromium_win.py supports the --test-shell flag and
3832         DRT/Chromium-win binary names.
3833         
3834         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
3835         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3836         (runTest): Support for test_shell-style command.
3837         (main): Introduce --test-shell.
3838         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
3839         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
3840           TestEventPrinter class manages stdio output and image output.
3841           TestEventPrinter.cpp has two implementations; DRTPrinter and
3842           TestShellPrinter.
3843         * DumpRenderTree/chromium/TestShell.cpp:
3844           Some changes for TestEventPrinter.
3845         (TestShell::TestShell):
3846         (TestShell::runFileTest):
3847         (TestShell::testTimedOut):
3848         (TestShell::dump):
3849         (TestShell::dumpImage):
3850         * DumpRenderTree/chromium/TestShell.h:
3851         (TestShell::printer):
3852         (TestShell::layoutTestTimeout):
3853         (TestShell::layoutTestTimeoutForWatchDog):
3854         (TestShell::setLayoutTestTimeout):
3855         * DumpRenderTree/chromium/TestShellWin.cpp:
3856         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
3857         * Scripts/webkitpy/layout_tests/port/chromium.py:
3858         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3859
3860 2010-05-30  Robert Hogan  <robert@webkit.org>
3861
3862         Reviewed by Kenneth Rohde Christiansen.
3863
3864         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
3865
3866         https://bugs.webkit.org/show_bug.cgi?id=36004
3867
3868         * DumpRenderTree/qt/EventSenderQt.cpp:
3869         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
3870                                     Scrollbar::pixelsPerLineStep() for DRT testing.
3871         (EventSender::mouseScrollBy): Added
3872         (EventSender::continuousMouseScrollBy): Added
3873         * DumpRenderTree/qt/EventSenderQt.h:
3874
3875 2010-05-28  Adam Barth  <abarth@webkit.org>
3876
3877         Reviewed by David Levin.
3878
3879         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
3880         https://bugs.webkit.org/show_bug.cgi?id=39546
3881
3882         One sublty is that we want to wait for the user to finish editing the
3883         ChangeLog before moving on to the next step.  That means we want to pass
3884         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
3885         we don't want them to have to exit the Xcode application.  For this reason,
3886         we create a new instance of the application with -n.
3887         
3888         Overall, xed seems like a better solution, so we recommend that too.
3889
3890         * Scripts/webkitpy/common/system/user.py:
3891         * Scripts/webkitpy/tool/mocktool.py:
3892         * Scripts/webkitpy/tool/steps/editchangelog.py:
3893
3894 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
3895
3896         Reviewed by Ojan Vafai.
3897
3898         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
3899         threads are wedged. Also, the script will print the results of the
3900         tests completed when the interrupt occurs.
3901
3902         https://bugs.webkit.org/show_bug.cgi?id=33238
3903
3904         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3905         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3906         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3907         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3908
3909 2010-05-28  Darin Adler  <darin@apple.com>
3910
3911         Ignore more Python messiness.
3912
3913         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
3914         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
3915         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
3916         * Scripts/webkitpy/test: Added property svn:ignore.
3917         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
3918
3919 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
3920
3921         Reviewed by Beth Dakin.
3922
3923         Adding myself as a reviewer.
3924
3925         * Scripts/webkitpy/common/config/committers.py:
3926
3927 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
3928
3929         Build fix. No review.
3930
3931         AX: need to catch NSAccessibilityExceptions in DRT
3932         https://bugs.webkit.org/show_bug.cgi?id=39881
3933
3934         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
3935
3936         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3937         (AccessibilityUIElement::rowIndexRange):
3938         (AccessibilityUIElement::columnIndexRange):
3939         (AccessibilityUIElement::selectedTextRange):
3940
3941 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
3942
3943         Reviewed by Darin Adler.
3944
3945         AX: need to catch NSAccessibilityExceptions in DRT
3946         https://bugs.webkit.org/show_bug.cgi?id=39881
3947
3948         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
3949         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
3950   
3951         So DRT should wrap exception handlers around its AX related calls.
3952
3953         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3954         (attributesOfElement):
3955         (AccessibilityUIElement::getLinkedUIElements):
3956         (AccessibilityUIElement::getDocumentLinks):
3957         (AccessibilityUIElement::getChildren):
3958         (AccessibilityUIElement::getChildrenWithRange):
3959         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3960         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3961         (AccessibilityUIElement::disclosedRowAtIndex):
3962         (AccessibilityUIElement::selectedRowAtIndex):
3963         (AccessibilityUIElement::titleUIElement):
3964         (AccessibilityUIElement::parentElement):
3965         (AccessibilityUIElement::disclosedByRow):
3966         (AccessibilityUIElement::stringAttributeValue):
3967         (AccessibilityUIElement::boolAttributeValue):
3968         (AccessibilityUIElement::isAttributeSettable):
3969         (AccessibilityUIElement::isAttributeSupported):
3970         (AccessibilityUIElement::role):
3971         (AccessibilityUIElement::subrole):
3972         (AccessibilityUIElement::roleDescription):
3973         (AccessibilityUIElement::title):
3974         (AccessibilityUIElement::description):
3975         (AccessibilityUIElement::orientation):
3976         (AccessibilityUIElement::stringValue):
3977         (AccessibilityUIElement::language):
3978         (AccessibilityUIElement::helpText):
3979         (AccessibilityUIElement::x):
3980         (AccessibilityUIElement::y):
3981         (AccessibilityUIElement::width):
3982         (AccessibilityUIElement::height):
3983         (AccessibilityUIElement::clickPointX):
3984         (AccessibilityUIElement::clickPointY):
3985         (AccessibilityUIElement::intValue):
3986         (AccessibilityUIElement::minValue):
3987         (AccessibilityUIElement::maxValue):
3988         (AccessibilityUIElement::valueDescription):
3989         (AccessibilityUIElement::insertionPointLineNumber):
3990         (AccessibilityUIElement::isActionSupported):
3991         (AccessibilityUIElement::isEnabled):
3992         (AccessibilityUIElement::isRequired):
3993         (AccessibilityUIElement::isSelected):
3994         (AccessibilityUIElement::isExpanded):
3995         (AccessibilityUIElement::hierarchicalLevel):
3996         (AccessibilityUIElement::ariaIsGrabbed):
3997         (AccessibilityUIElement::ariaDropEffects):
3998         (AccessibilityUIElement::lineForIndex):
3999         (AccessibilityUIElement::boundsForRange):
4000         (AccessibilityUIElement::stringForRange):
4001         (AccessibilityUIElement::attributesOfColumnHeaders):
4002         (AccessibilityUIElement::attributesOfRowHeaders):
4003         (AccessibilityUIElement::attributesOfColumns):
4004         (AccessibilityUIElement::attributesOfRows):
4005         (AccessibilityUIElement::attributesOfVisibleCells):
4006         (AccessibilityUIElement::attributesOfHeader):
4007         (AccessibilityUIElement::rowCount):
4008         (AccessibilityUIElement::columnCount):
4009         (AccessibilityUIElement::indexInTable):
4010         (AccessibilityUIElement::rowIndexRange):
4011         (AccessibilityUIElement::columnIndexRange):
4012         (AccessibilityUIElement::cellForColumnAndRow):
4013         (AccessibilityUIElement::selectedTextRange):
4014         (AccessibilityUIElement::setSelectedTextRange):
4015         (AccessibilityUIElement::increment):
4016         (AccessibilityUIElement::decrement):
4017         (AccessibilityUIElement::showMenu):
4018         (AccessibilityUIElement::press):
4019         (AccessibilityUIElement::url):
4020         (AccessibilityUIElement::hasPopup):
4021
4022 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
4023
4024         Reviewed by Laszlo Gombos.
4025
4026         [Qt] Pass all web notification layout tests
4027         https://bugs.webkit.org/show_bug.cgi?id=39146
4028
4029         Mimic Chromium's test_shell security model in Qt's DRT.
4030         It makes a list of origins which were granted permission to display
4031         notifications, and only those origins can display notifications.
4032
4033         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4034         (WebCore::checkPermissionCallback):
4035         (WebCore::requestPermissionCallback):
4036         (WebCore::WebPage::WebPage):
4037         (WebCore::DumpRenderTree::checkPermission):
4038         (WebCore::DumpRenderTree::requestPermission):
4039         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4040         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4041         (LayoutTestController::reset):
4042         (LayoutTestController::grantDesktopNotificationPermission):
4043         (LayoutTestController::checkDesktopNotificationPermission):
4044         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4045
4046 2010-05-27  Philippe Normand  <pnormand@igalia.com>
4047
4048         Reviewed by Shinichiro Hamaji.
4049
4050         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
4051         https://bugs.webkit.org/show_bug.cgi?id=39372
4052
4053         Don't warn about NULL in g_*() calls. Zero can't be used instead
4054         for calls like g_build_filename and g_object_get/set.
4055
4056         * Scripts/webkitpy/style/checkers/cpp.py:
4057         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4058
4059 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
4060
4061         Reviewed by Kenneth Rohde Christiansen.
4062
4063         [Qt] Platform plugin example
4064         https://bugs.webkit.org/show_bug.cgi?id=39489
4065
4066         Exempting directory WebKit/qt/examples/ from style guide.
4067
4068         * Scripts/webkitpy/style/checker.py:
4069
4070 2010-05-26  Philippe Normand  <pnormand@igalia.com>
4071
4072         Reviewed by David Levin.
4073
4074         [style] Allow usage of NULL in gst_*_many()
4075         https://bugs.webkit.org/show_bug.cgi?id=39740
4076
4077         Don't warn if NULL is used by gst_*_many() functions. Zero can't
4078         be used for the reason explained in Bug 32858.
4079
4080         * Scripts/webkitpy/style/checkers/cpp.py:
4081         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4082
4083 2010-05-27  Adam Barth  <abarth@webkit.org>
4084
4085         Reviewed by Eric Seidel.
4086
4087         Update script to run the normal version of the parser tests.
4088
4089         * Scripts/test-html5-parser:
4090
4091 2010-05-27  Adam Barth  <abarth@webkit.org>
4092
4093         Reviewed by Eric Seidel.
4094
4095         Add HTML5 parser support to run-webkit-tests
4096         https://bugs.webkit.org/show_bug.cgi?id=39815
4097
4098         * Scripts/old-run-webkit-tests:
4099
4100 2010-05-26  Adam Barth  <abarth@webkit.org>
4101
4102         Reviewed by Eric Seidel.
4103
4104         Make HTML5 lexer not ASSERT when resuming partial parses
4105         https://bugs.webkit.org/show_bug.cgi?id=39755
4106
4107         Add webkit-resumer.html to the HTML5 parser test suite.
4108
4109         * Scripts/test-html5-parser:
4110
4111 2010-05-24  Tony Chang  <tony@chromium.org>
4112
4113         Reviewed by Kent Tamura.
4114
4115         [chromium] setup fonts on chromium linux DRT
4116         https://bugs.webkit.org/show_bug.cgi?id=39644
4117
4118         * DumpRenderTree/chromium/TestShellGtk.cpp:
4119         (setupFontconfig):
4120         (platformInit):
4121         * DumpRenderTree/chromium/WebViewHost.cpp:
4122         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
4123         * DumpRenderTree/chromium/fonts.conf: Added.
4124
4125 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
4126
4127         Reviewed by Dimitri Glazkov.
4128
4129         Re-commit r58765 - it had been rolled out to see if it was causing
4130         a perf regression (in r59787 and r59789), but that does not seem to
4131         have been the case.
4132
4133         https://bugs.webkit.org/show_bug.cgi?id=39605
4134
4135         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4136         (NotificationPresenter::show):
4137
4138 2010-05-25  Ojan Vafai  <ojan@chromium.org>
4139
4140         Reviewed by Chris Jerdonek.
4141
4142         remove suppression of rietveld logging
4143         https://bugs.webkit.org/show_bug.cgi?id=39693
4144
4145         Now that we only upload to rietveld explicitly, e.g. on the bot
4146         or via webkit-patch post-attachment-to-rietveld, we should print
4147         all the rietveld logging. It was suppressed before to avoid making
4148         webkit-patch upload too noisy.
4149
4150         * Scripts/webkitpy/common/net/rietveld.py:
4151
4152 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
4153
4154         Reviewed by Ojan Vafai.
4155
4156         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
4157         https://bugs.webkit.org/show_bug.cgi?id=39680
4158
4159         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
4160
4161         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4162         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4163         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4164         (LayoutTestController::setEditingBehavior):
4165
4166 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
4167
4168         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
4169
4170         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4171         (LayoutTestController::setEditingBehavior):
4172         * wx/build/settings.py:
4173
4174 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
4175
4176         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
4177
4178         editingBehavior settings needs to be set back to a reasonable default between tests
4179         https://bugs.webkit.org/show_bug.cgi?id=39433
4180
4181         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
4182         so that the serialized version of the setting stays in sync with expectations.
4183
4184         * DumpRenderTree/chromium/TestShell.cpp:
4185         (TestShell::resetWebSettings):
4186         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4187         (resetDefaultsToConsistentValues):
4188
4189 2010-05-24  Eric Seidel  <eric@webkit.org>
4190
4191         Reviewed by Adam Barth.
4192
4193         webkit-patch land calls scm.changed_files 4 times!
4194         https://bugs.webkit.org/show_bug.cgi?id=39584
4195
4196         * Scripts/webkitpy/tool/commands/download_unittest.py:
4197          - Assert that we don't call modified_changelogs too often.
4198         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4199          - Use cached changelogs list instead of calling modified_changelogs directly.
4200         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4201          - ditto.
4202
4203 2010-05-24  Kent Tamura  <tkent@chromium.org>
4204
4205         Reviewed by Dimitri Glazkov.
4206
4207         [DRT/Chromium] Import layout_test_helper for Windows
4208         https://bugs.webkit.org/show_bug.cgi?id=39581
4209
4210         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
4211         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
4212
4213         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
4214
4215 2010-05-24  Kent Tamura  <tkent@chromium.org>
4216
4217         Reviewed by Dimitri Glazkov.
4218
4219         [DRT/Chromium] Reset frame name
4220         https://bugs.webkit.org/show_bug.cgi?id=39586
4221
4222         This change fixes about 70 unexpected results.
4223
4224         * DumpRenderTree/chromium/WebViewHost.cpp:
4225         (WebViewHost::reset):
4226
4227 2010-05-24  Marcus Bulach  <bulach@chromium.org>
4228
4229         Reviewed by Kent Tamura.
4230
4231         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
4232         https://bugs.webkit.org/show_bug.cgi?id=39587
4233
4234         * DumpRenderTree/chromium/WebViewHost.cpp:
4235         (WebViewHost::geolocationService):
4236
4237 2010-05-24  Robert Hogan  <robert@webkit.org>
4238
4239         Reviewed by Laszlo Gombos.
4240
4241         [Qt] DRT Support for removeOriginAccessWhitelistEntry
4242
4243         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
4244
4245         [Qt] DRT Support for removeOriginAccessWhitelistEntry
4246         https://bugs.webkit.org/show_bug.cgi?id=39565
4247
4248         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4249         (LayoutTestController::removeOriginAccessWhitelistEntry):
4250
4251 2010-05-24  Marcus Bulach  <bulach@google.com>
4252
4253         Reviewed by Ojan Vafai.
4254
4255         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
4256         https://bugs.webkit.org/show_bug.cgi?id=39603
4257
4258         * Scripts/webkitpy/common/checkout/scm.py:
4259
4260 == Rolled over to ChangeLog-2010-05-24 ==