2010-12-02 Sam Weinig <sam@webkit.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-12-02  Sam Weinig  <sam@webkit.org>
2
3         Fix Qt build.
4
5         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
6         (WTR::PlatformWebView::PlatformWebView):
7
8 2010-12-02  Sam Weinig  <sam@webkit.org>
9
10         Reviewed by Anders Carlsson.
11
12         WebKit2 Preferences should be held off the PageGroup, not the Context
13         https://bugs.webkit.org/show_bug.cgi?id=50414
14
15         Update for API changes.
16
17         * WebKitTestRunner/PlatformWebView.h:
18         * WebKitTestRunner/TestController.cpp:
19         (WTR::createOtherPage):
20         (WTR::TestController::initialize):
21         (WTR::TestController::resetStateToConsistentValues):
22         * WebKitTestRunner/TestController.h:
23         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
24         (WTR::PlatformWebView::PlatformWebView):
25         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
26         (WTR::PlatformWebView::PlatformWebView):
27
28 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
29
30         Reviewed by Tony Chang.
31
32         new-run-webkit-tests: minor cleanup for multiprocessing work
33
34         This change:
35         * moves worker naming into TestShellThread, eliminating a
36           parameter to the constructor and putting the responsibility in
37           the correct place.
38         * eliminates the _WorkerState() class in message_broker, because
39           it turns out that state really needs to be in run_webkit_tests
40         * renames the Broker classes to be module-private.
41         * fixes a bunch of minor commenting and whitespace issues to
42           make subsequent patches a bit clearer.
43         * Adds a Port hook for default_worker_model() so that we can
44           accomodate the potential for different worker models on
45           different ports.
46         * merge in the fix from 50420 for the brokenness introduced in
47           bug 50367.
48
49         This patch depends on bug 50367.
50
51         https://bugs.webkit.org/show_bug.cgi?id=50372
52
53         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
54         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
55         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
56         * Scripts/webkitpy/layout_tests/port/base.py:
57         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
58         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
59
60 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
61
62         Reviewed by Tony Chang.
63
64         This change is a bunch of cleanup / refactoring of the file
65         below. It moves a bunch of free functions to methods on the
66         TestShellThread class, and restructures other methods to be
67         closer to the structure we'll need for the multiprocessing
68         rewrite.
69
70         It also makes the logic of --run-singly a *lot* easier to follow
71         by nestling all of the separate-thread logic into a single
72         routine.
73
74         There should be no semantic changes in this patch, just cleanup.
75
76         https://bugs.webkit.org/show_bug.cgi?id=50367
77
78         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
79
80 2010-12-02  Tony Chang  <tony@chromium.org>
81
82         Unreviewed, rolling out r73164.
83         http://trac.webkit.org/changeset/73164
84         https://bugs.webkit.org/show_bug.cgi?id=50359
85
86         broke debugger tests on win
87
88         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
89
90 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
91
92         Reviewed by Tony Chang.
93
94         Rebaseline server: add updating of baselines
95         https://bugs.webkit.org/show_bug.cgi?id=50305
96         
97         Implements updating of baselines, where we copy -actual.* files over
98         the current -expected.* files. To do this, we need a
99         _get_actual_result_files method to get test results files and a
100         _rebaseline_test method to actually do the file copy and SCM operation.
101         _rebaseline_test logs output into a buffer, this is useful for both
102         showing result in the UI and for unit tests.
103         
104         To make passing around of the various test environment properties
105         (results directory, filesystem, SCM, etc) easier, add a TestConfig
106         class for them.
107         
108         Moving of existing baselines is not implemented yet, this patch is big
109         enough as it is.
110
111         * Scripts/webkitpy/common/system/filesystem.py:
112         * Scripts/webkitpy/common/system/filesystem_mock.py:
113         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
114         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
115         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
116         * Scripts/webkitpy/tool/mocktool.py:
117
118 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
119
120         Unreviewed build fix after vcproj updates.
121
122         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
123         that WIN_CAIRO is defined for this build.
124         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
125         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
126         (these were previously 'Debug_Cairo' and 'Release_Cairo'
127
128 2010-12-02  Sam Weinig  <sam@webkit.org>
129
130         Reviewed by Anders Carlsson.
131
132         WebKit2 needs API to turn on popup blocking
133         https://bugs.webkit.org/show_bug.cgi?id=50407
134
135         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
136         (TestWebKitAPI::TEST):
137         * WebKitTestRunner/TestController.cpp:
138         (WTR::TestController::resetStateToConsistentValues):
139
140 2010-12-01  Tony Chang  <tony@chromium.org>
141
142         Reviewed by Ojan Vafai.
143
144         [chromium] force NRWT to use DRT
145         https://bugs.webkit.org/show_bug.cgi?id=50359
146
147         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
148
149 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
150
151         Reviewed by Xan Lopez.
152
153         [GTK] DumpRenderTree has two copies of JavaScriptCore
154         https://bugs.webkit.org/show_bug.cgi?id=49877
155
156         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
157         LDADD list for DumpRenderTree.
158
159 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
160
161         Unreviewed: Added myself to list of Committers.
162
163         * Scripts/webkitpy/common/config/committers.py:
164
165 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
166
167         Reviewed by Adam Barth.
168
169         build-webkit --chromium always updates DEPS and re-generates project files
170         https://bugs.webkit.org/show_bug.cgi?id=50340
171         
172         Make build-webkit --chromium invoke update-webkit-chromium only when
173         --update-chromium is passed in, so that we don't add 20 seconds to all
174         builds.
175         
176         Making all invocations update was added with r61883, with the goal of
177         making EWS bots always update. The bots will switch to using this flag
178         (as will all other webkit-patch build steps) so nothing should change
179         for them.
180
181         * Scripts/webkitdirs.pm:
182         * Scripts/webkitpy/common/config/ports.py:
183         * Scripts/webkitpy/common/config/ports_unittest.py:
184
185 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
186
187         Reviewed by Tony Chang.
188
189         new-run-webkit-tests: add a --dry-run / -n flag
190         https://bugs.webkit.org/show_bug.cgi?id=50045
191
192         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
193         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
194
195 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
196
197         Reviewed by Adam Roben.
198
199         WinCairo build should not use link-time code generation (LTCG)
200         https://bugs.webkit.org/show_bug.cgi?id=50353
201
202         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
203         * DumpRenderTree/win/DumpRenderTree.vcproj:
204         * DumpRenderTree/win/ImageDiff.vcproj:
205         * FindSafari/FindSafari.vcproj:
206         * MiniBrowser/MiniBrowser.vcproj:
207         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
208         * WebKitAPITest/WebKitAPITest.vcproj:
209         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
210         * WebKitTestRunner/win/InjectedBundle.vcproj:
211         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
212         * WinLauncher/WinLauncher.vcproj:
213         * record-memory-win/record-memory-win.vcproj:
214
215 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
216
217         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
218         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
219         adding the file to the sources list was not enough to force the rebuild.
220
221         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
222         Remove an empty line at the end of this file to force a rebuild.
223
224 2010-12-01  Sam Weinig  <sam@webkit.org>
225
226         Fix windows build.
227
228         * MiniBrowser/win/BrowserView.cpp:
229         (BrowserView::create):
230
231 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
232
233         Add missing file to the TestNetscapePlugin sources list after r73057.
234
235         * GNUmakefile.am: Add missing file.
236
237 2010-12-01  Sam Weinig  <sam@webkit.org>
238
239         Reviewed by Anders Carlsson.
240
241         Add PageGrouping to WebKit2 API
242         https://bugs.webkit.org/show_bug.cgi?id=50332
243
244         - Update testing harnesses to deal with new PageGroup API.
245
246         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
247         (WKBundleInitialize):
248         * TestWebKitAPI/InjectedBundleController.cpp:
249         (TestWebKitAPI::InjectedBundleController::initialize):
250         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
251         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
252         * TestWebKitAPI/InjectedBundleController.h:
253         * TestWebKitAPI/InjectedBundleTest.h:
254         (TestWebKitAPI::InjectedBundleTest::initialize):
255         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
256         * TestWebKitAPI/PlatformUtilities.cpp:
257         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
258         * TestWebKitAPI/PlatformUtilities.h:
259         * TestWebKitAPI/PlatformWebView.h:
260         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
261         (TestWebKitAPI::TEST):
262         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
263         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
264         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
265         (TestWebKitAPI::PlatformWebView::PlatformWebView):
266         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
267         (TestWebKitAPI::PlatformWebView::PlatformWebView):
268         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
269         (WTR::InjectedBundle::didInitializePageGroup):
270         (WTR::InjectedBundle::initialize):
271         (WTR::InjectedBundle::beginTesting):
272         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
273         (WTR::InjectedBundle::pageGroup):
274         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
275         (WTR::LayoutTestController::addUserScript):
276         (WTR::LayoutTestController::addUserStyleSheet):
277         (WTR::LayoutTestController::setXSSAuditorEnabled):
278         * WebKitTestRunner/TestController.cpp:
279         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
280         (WTR::PlatformWebView::PlatformWebView):
281
282 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
283
284         Reviewed by Adam Roben.
285
286         vcproj changes can't be applied cleanly by the Windows EWS bot
287         https://bugs.webkit.org/show_bug.cgi?id=50328
288
289         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
290         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
291         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
292         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
293         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
294         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
295         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
296         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
297         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
298         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
299         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
300         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
301         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
302         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
303         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
304         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
305         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
306         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
307         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
308         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
309         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
310         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
311         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
312         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
313         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
314         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
315         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
316         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
317         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
318         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
319         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
320         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
321         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
322         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
323         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
324         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
325         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
326         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
327         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
328         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
329         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
330         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
331         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
332         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
333         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
334
335 2010-12-01  Anders Carlsson  <andersca@apple.com>
336
337         Reviewed by Darin Adler.
338
339         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
340         https://bugs.webkit.org/show_bug.cgi?id=50336
341
342         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
343         Add new test.
344
345         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
346         (PluginTest::NPP_New):
347         Add default implementation/
348
349         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
350         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
351         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
352         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
353         Get the user agent.
354
355         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
356         (NPP_New):
357         Call PluginTest::NPP_New.
358
359         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
360         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
361         Add new files.
362
363         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
364         (webkit_test_plugin_new_instance):
365         Call PluginTest::NPP_New.
366
367 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
368
369         [wx] Build fixes after recent trunk changes.
370
371         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
372         (LayoutTestController::findString):
373         * wx/build/settings.py:
374
375 2010-12-01  Dan Bernstein  <mitz@apple.com>
376
377         Reviewed by Darin Adler.
378
379         WebKitTestRunner needs layoutTestController.findString
380         https://bugs.webkit.org/show_bug.cgi?id=50238
381
382         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
383         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
384         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
385         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
386
387 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
388
389         Try using svn:eol-style native on a vcproj file.
390
391         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
392
393 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
394
395         Reviewed by Adam Roben.
396
397         [WINCE] Add WinCELauncher
398         https://bugs.webkit.org/show_bug.cgi?id=50217
399
400         * WinCELauncher/main.cpp: Added.
401
402 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
403
404         Reviewed by Kenneth Rohde Christiansen.
405
406         [Qt] Implement layoutTestController.findString
407         https://bugs.webkit.org/show_bug.cgi?id=50236
408
409         Add the missing function to the LayoutTestController.
410
411         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
412         (LayoutTestController::findString):
413         * DumpRenderTree/qt/LayoutTestControllerQt.h:
414
415 2010-11-30  Tony Chang  <tony@chromium.org>
416
417         Reviewed by Adam Barth.
418
419         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
420         https://bugs.webkit.org/show_bug.cgi?id=49036
421
422         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
423             for CppVariants.
424         (LayoutTestController::cppVariantToBool):
425         (LayoutTestController::cppVariantToInt32):
426         (LayoutTestController::setDatabaseQuota):
427         (LayoutTestController::evaluateInWebInspector):
428         (LayoutTestController::setMockGeolocationError):
429
430 2010-11-30  Eric Seidel  <eric@webkit.org>
431
432         Reviewed by Tony Chang.
433
434         update-webkit should call git fetch before git svn rebase
435         https://bugs.webkit.org/show_bug.cgi?id=50273
436
437         After discussion on webkit-dev, we've decided to move the "default"
438         git setup to pulling updates from git.webkit.org in preference
439         to rebuilding the local svn index using git svn fetch every time.
440
441         This change should have no effect on people using the "old" git setup
442         and should dramatically increase the speed of updates for those using
443         the "new" git setup along with update-webkit.  I'm about to move the
444         EWS and other queues over to this setup once this lands.
445
446         * Scripts/update-webkit:
447
448 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
449
450         Reviewed by Xan Lopez.
451
452         GTK: AX: implement press in DRT
453         https://bugs.webkit.org/show_bug.cgi?id=36146
454
455         Implement AccessibilityUIElement::press() for GTK.
456
457         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
458         (AccessibilityUIElement::press): Implemented.
459
460 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
461
462         Reviewed by Tony Chang.
463
464         config.webkit_base_dir returns a path with a trailing slash
465         https://bugs.webkit.org/show_bug.cgi?id=50197
466         
467         config.webkit_base_dir() should return a path without a trailing slash,
468         like all the other methods that return paths.
469         
470         Undoes MockFileSytem changes by r72640, since they're no longer
471         necessary for GetBaselinesTest to pass.
472
473         * Scripts/webkitpy/common/system/filesystem_mock.py:
474         * Scripts/webkitpy/layout_tests/port/base.py:
475         * Scripts/webkitpy/layout_tests/port/config.py:
476         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
477
478 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
479
480         Reviewed by Tony Chang.
481
482         Rebaseline server: baseline display tweaks
483         https://bugs.webkit.org/show_bug.cgi?id=50207
484         
485         Determine which baselines were used when running the tests and highlight
486         them in the UI. Sort platform names alphabetically.
487         
488         Also makes the server URL be launched in the user's browser
489         automatically.
490
491         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
492         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
493         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
494         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
495         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
496
497 2010-11-30  Dan Bernstein  <mitz@apple.com>
498
499         Reviewed by Anders Carlsson.
500
501         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
502         https://bugs.webkit.org/show_bug.cgi?id=50238
503
504         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
505         (WTR::LayoutTestController::findString): Added.
506         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
507
508 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
509
510         Reviewed by Adam Roben.
511
512         All projects on Windows should use cmd files for build events
513         https://bugs.webkit.org/show_bug.cgi?id=50213
514
515         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
516         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
517         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
518         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
519         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
520         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
521         * DumpRenderTree/win/ImageDiffCommon.vsprops:
522         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
523         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
524         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
525         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
526         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
527         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
528         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
529         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
530         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
531         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
532         * WebKitAPITest/WebKitAPITestCommon.vsprops:
533         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
534         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
535         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
536         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
537         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
538         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
539         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
540         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
541         * WinLauncher/WinLauncherCommon.vsprops:
542         * WinLauncher/WinLauncherPostBuild.cmd: Added.
543         * WinLauncher/WinLauncherPreBuild.cmd: Added.
544
545 2010-11-29  Dan Bernstein  <mitz@apple.com>
546
547         GTK DumpRenderTree build fix after r72887.
548
549         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
550         (LayoutTestController::findString):
551
552 2010-11-29  Dan Bernstein  <mitz@apple.com>
553
554         Windows DumpRenderTree build fix after r72887.
555
556         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
557         (LayoutTestController::findString): Added empty implementation.
558
559 2010-11-29  Dan Bernstein  <mitz@apple.com>
560
561         Reviewed by Darin Adler.
562
563         DumpRenderTree changes for testing the text search API.
564         https://bugs.webkit.org/show_bug.cgi?id=50038
565
566         * DumpRenderTree/LayoutTestController.cpp:
567         (findStringCallback):
568         (LayoutTestController::staticFunctions):
569         * DumpRenderTree/LayoutTestController.h:
570         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
571         (LayoutTestController::findString):
572         * MiniBrowser/mac/BrowserWindowController.m:
573         (-[BrowserWindowController find:]):
574
575 2010-11-29  Johnny Ding  <jnd@chromium.org>
576
577         Unreviewed: Add myself to the list of Committers.
578
579         * Scripts/webkitpy/common/config/committers.py:
580
581 2010-11-29  Mark Rowe  <mrowe@apple.com>
582
583         Reviewed by Adele Peterson.
584
585         <rdar://problem/8694997> DumpRenderTree fails to build.
586
587         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
588
589 2010-11-29  Mark Rowe  <mrowe@apple.com>
590
591         Reviewed by Adele Peterson.
592
593         <rdar://problem/8694997> DumpRenderTree fails to build.
594
595         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
596         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
597         * DumpRenderTree/mac/PerlSupport/Makefile:
598
599 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
600
601         Reviewed by Martin Robinson.
602
603         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
604         https://bugs.webkit.org/show_bug.cgi?id=50154
605
606         Added missing checks to allAttributes().
607
608         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
609         (AccessibilityUIElement::allAttributes): Added missing checks.
610
611 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
612
613         Reviewed by Kenneth Rohde Christiansen.
614
615         [Qt] Allow pre-generation for package builds for WebKit2
616         https://bugs.webkit.org/show_bug.cgi?id=50139
617
618         Use a build variable for the generated directory path and set the
619         value based on CONFIG just like for WebKit1.
620
621         For non-package builds use a relative base path for the
622         genrated directory just like for WebKit1.
623
624         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
625         * WebKitTestRunner/qt/WebKitTestRunner.pro:
626
627 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
628
629         Reviewed by Kenneth Rohde Christiansen.
630
631         [Qt] Move some build logic from Qt to platform independent code
632         https://bugs.webkit.org/show_bug.cgi?id=50134
633
634         Create target directories inside generate-forwarding-headers.pl.
635
636         * Scripts/generate-forwarding-headers.pl:
637
638 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
639
640         Reviewed by Martin Robinson.
641
642         [GTK] Windowless plugins gets broken key input
643         https://bugs.webkit.org/show_bug.cgi?id=49927
644
645         Convert the XEvent::keycode to ASCII before printing it. Not
646         doing this was causing false positive in 
647         plugins/keyboard-events.html.
648
649         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
650         (keycode_to_char):
651         (webkit_test_plugin_handle_event):
652
653 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
654
655         Reviewed by Antonio Gomes.
656
657         [Qt] Html autofocus not working with QGraphicsWebView
658         https://bugs.webkit.org/show_bug.cgi?id=43169
659
660         Tell the scene to set the webview item as the currently
661         focused item. This makes the input field with autofocus get
662         focus as it should.
663
664         * QtTestBrowser/webview.cpp:
665         (WebViewGraphicsBased::WebViewGraphicsBased):
666
667 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
668
669         Reviewed by Tony Chang.
670
671         nrwt - clean up create_driver interface and print out the
672         command line used for DumpRenderTree/TestShell.
673
674         This patch adds a driver_cmd_line() call to the Port class in
675         order to retrive the command line to print it out (as part of
676         --print config).
677
678         In addition, this patch cleans up the Port.create_driver()
679         signature and the Driver constructor interface to take a worker
680         number and no longer require the image_path argument (Chromium's
681         drivers now synthesize the image_path from the worker number
682         internally).
683
684         https://bugs.webkit.org/show_bug.cgi?id=49934
685
686         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
687         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
688         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
689         * Scripts/webkitpy/layout_tests/port/base.py:
690         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
691         * Scripts/webkitpy/layout_tests/port/chromium.py:
692         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
693         * Scripts/webkitpy/layout_tests/port/dryrun.py:
694         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
695         * Scripts/webkitpy/layout_tests/port/test.py:
696         * Scripts/webkitpy/layout_tests/port/webkit.py:
697         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
698         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
699
700 2010-11-24  Ojan Vafai  <ojan@chromium.org>
701
702         Reviewed by Tony Chang.
703
704         [chromium] improve memory usage for test results server and store fewer runs
705         https://bugs.webkit.org/show_bug.cgi?id=50035
706
707         Store fewer runs and don't pass full files around when we only need bools.
708         Greatly improves error rates on test-results.appspot.com.
709
710         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
711         * TestResultServer/handlers/testfilehandler.py:
712         * TestResultServer/model/dashboardfile.py:
713         * TestResultServer/model/jsonresults.py:
714
715 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
716
717         Reviewed by Tony Chang.
718
719         This patch implements the first part of the manager side of the
720         Broker objects - it handles creating threads, waiting for them
721         to complete, and running a single-threaded loop as well.
722
723         https://bugs.webkit.org/show_bug.cgi?id=49779
724
725         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
726         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
727         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
728         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
729
730 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
731
732         Reviewed by David Levin.
733
734         DRT should not generate pixel output for text/plain tests
735         https://bugs.webkit.org/show_bug.cgi?id=50002
736         
737         Modify Mac, Windows and GTK DRT implementations to disable pixel output
738         when encountering a text/plain response (the Chromium one already does
739         this, and none of the other ports special-case text/plain output in
740         the first place).
741
742         * DumpRenderTree/gtk/DumpRenderTree.cpp:
743         (dump):
744         * DumpRenderTree/mac/DumpRenderTree.mm:
745         (dump):
746         * DumpRenderTree/win/DumpRenderTree.cpp:
747         (dump):
748
749 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
750
751         Unreviewed.
752
753         Add my other email address to committers.py.
754
755         * Scripts/webkitpy/common/config/committers.py:
756
757 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
758
759         Reviewed by Csaba Osztrogonác.
760
761         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
762         https://bugs.webkit.org/show_bug.cgi?id=49975
763
764         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
765         to enable the script to define it 0 in case of a minimal build.
766
767 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
768
769         Reviewed by Xan Lopez.
770
771         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
772         https://bugs.webkit.org/show_bug.cgi?id=49143
773
774         * DumpRenderTree/gtk/DumpRenderTree.cpp:
775         (createWebView): Call the new connectEditingCallbacks function.
776         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
777         (dumpNodePath):
778         (dumpRange):
779         (insertActionString):
780         (selectionAffinityString):
781         (shouldBeginEditing):
782         (shouldEndEditing):
783         (shouldInsertNode):
784         (shouldInsertText):
785         (shouldDeleteRange):
786         (shouldShowDeleteInterfaceForElement):
787         (shouldChangeSelectedRange):
788         (shouldApplyStyle):
789         (editingBegan):
790         (userChangedContents):
791         (editingEnded):
792         (selectionChanged):
793         (connectEditingCallbacks):
794         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
795         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
796
797 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
798
799         Reviewed by Andreas Kling.
800
801         [Qt] Make QtTestBrowser remember the selected user agent
802         https://bugs.webkit.org/show_bug.cgi?id=50021
803
804         Set user agent for a new page by using the old page's
805
806         * QtTestBrowser/mainwindow.cpp:
807         (MainWindow::setPage):
808
809 2010-11-24 Patrick Gansterer <paroga@webkit.org>
810
811         Reviewed by Csaba Osztrogonác.
812
813         Remove Bakefile build system files
814         https://bugs.webkit.org/show_bug.cgi?id=49983
815
816         r53757 only removed the content, but not the files.
817         This patch removes that empty files.
818
819         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
820         * wx/browser/browser.bkl: Removed.
821         * wx/build-wxwebkit: Removed.
822
823 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
824
825         Reviewed by Tony Chang.
826
827         This patch cleans up the logic used to shard tests into groups a
828         bit and adds the --worker-model flag to NRWT. The flag is only
829         used at the moment to control whether to run single-threaded or
830         not, but eventually will also allow toggling between threads and
831         processes.
832
833         Also add a minor cleanup with _test_is_slow(), which just
834         eliminates some repetition and gives slightly better encapsulation.
835
836         https://bugs.webkit.org/show_bug.cgi?id=49773
837
838         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
839         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
840
841 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
842
843         Reviewed by Tony Chang.
844
845         Rebaseline server: list current baselines and platforms
846         https://bugs.webkit.org/show_bug.cgi?id=49991
847         
848         List existing baselines (with Trac links) for tests.
849         
850         Add dropdowns for choosing with platform baselines to target (and what
851         to do with existing ones).
852
853         Also fix MockFileSystem.join to behave more like os.path.join (unit
854         test was ending up with two consecutive slashes in a layout test
855         path).        
856
857         * Scripts/webkitpy/common/system/filesystem_mock.py:
858         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
859         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
860         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
861         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
862         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
863         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
864         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
865
866 2010-11-23  Ojan Vafai  <ojan@chromium.org>
867
868         Reviewed by Tony Chang.
869
870         remove timeout argument to urlopen
871         https://bugs.webkit.org/show_bug.cgi?id=49995
872
873         Apparently the version of python we have on the bots doesn't accept a timeout argument.
874
875         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
876
877 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
878
879         Unreviewed, rolling out r72628.
880         http://trac.webkit.org/changeset/72628
881         https://bugs.webkit.org/show_bug.cgi?id=49994
882
883         This patch is causing layout-test failtures on GTK Linux
884         64-bit Debug (Requested by ctguil on #webkit).
885
886         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
887         (AccessibilityUIElement::AccessibilityUIElement):
888         (AccessibilityUIElement::parentElementCallback):
889         * DumpRenderTree/chromium/AccessibilityUIElement.h:
890         * DumpRenderTree/chromium/CppBoundClass.cpp:
891         * DumpRenderTree/chromium/CppBoundClass.h:
892
893 2010-11-22  Ojan Vafai  <ojan@chromium.org>
894
895         Reviewed by Tony Chang.
896
897         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
898         https://bugs.webkit.org/show_bug.cgi?id=49944
899
900         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
901
902 2010-11-23  Chris Guillory  <chris.guillory@google.com>
903
904         Reviewed by Dimitri Glazkov.
905
906         Include the FrameView widget of a RenderWidget in the accessibility tree.
907         https://bugs.webkit.org/show_bug.cgi?id=49106
908
909         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
910         (AccessibilityUIElement::AccessibilityUIElement):
911         (AccessibilityUIElement::parentElementCallback):
912         (AccessibilityUIElement::isEqualCallback):
913         * DumpRenderTree/chromium/AccessibilityUIElement.h:
914         * DumpRenderTree/chromium/CppBoundClass.cpp:
915         (CppBoundClass::getFromCppVariant):
916         * DumpRenderTree/chromium/CppBoundClass.h:
917
918 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
919
920         Reviewed by Kenneth Rohde Christiansen.
921
922         [EFL] Add tiled backing store to EWebLauncher
923         https://bugs.webkit.org/show_bug.cgi?id=45777
924
925         Allow EWebLauncher to choose between single and tiled backing store
926
927         * EWebLauncher/main.c:
928         (on_key_down):
929         (browserCreate):
930         (main):
931
932 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
933
934         Reviewed by Tor Arne Vestbø.
935
936         [Qt] Review the setUserPermission & friends API
937         https://bugs.webkit.org/show_bug.cgi?id=46810
938
939         Renamed requestPermissionFromUser to featurePermissionRequested
940         and cancelRequestsForPermission to featurePermissionRequestCanceled.
941
942         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
943         (WebCore::WebPage::WebPage):
944         * QtTestBrowser/webpage.cpp:
945         (WebPage::WebPage):
946         (WebPage::featurePermissionRequestCanceled):
947         * QtTestBrowser/webpage.h:
948
949 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
950
951         Reviewed by Tor Arne Vestbø.
952
953         [Qt] Review the setUserPermission & friends API
954         https://bugs.webkit.org/show_bug.cgi?id=46810
955
956         Rename setUserPermission to setFeaturePermission
957
958         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
959         (WebCore::WebPage::requestPermission):
960         (WebCore::WebPage::permissionSet):
961         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
962         (LayoutTestController::grantDesktopNotificationPermission):
963         * QtTestBrowser/webpage.cpp:
964         (WebPage::requestPermission):
965
966 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
967
968         Reviewed by Tor Arne Vestbø.
969
970         [Qt] Review the setUserPermission & friends API
971         https://bugs.webkit.org/show_bug.cgi?id=46810
972
973         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
974         and GeolocationPermissionDomain to Geolocation.
975
976         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
977         (WebCore::WebPage::WebPage):
978         (WebCore::WebPage::requestPermission):
979         (WebCore::WebPage::cancelPermission):
980         (WebCore::WebPage::permissionSet):
981         (WebCore::DumpRenderTree::geolocationPermissionSet):
982         * DumpRenderTree/qt/DumpRenderTreeQt.h:
983         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
984         (LayoutTestController::grantDesktopNotificationPermission):
985         * QtTestBrowser/webpage.cpp:
986         (WebPage::WebPage):
987         (WebPage::requestPermission):
988         (WebPage::cancelRequestsForPermission):
989         * QtTestBrowser/webpage.h:
990
991 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
992
993         Reviewed by Tor Arne Vestbø.
994
995         [Qt] Review the setUserPermission & friends API
996         https://bugs.webkit.org/show_bug.cgi?id=46810
997
998         Add a ByUser suffix to PermissionGranted/Denied. In the future
999         we can add PermissionGrantedByDefault.
1000
1001
1002         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1003         (WebCore::WebPage::requestPermission):
1004         (WebCore::WebPage::permissionSet):
1005         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1006         (LayoutTestController::grantDesktopNotificationPermission):
1007         * QtTestBrowser/webpage.cpp:
1008         (WebPage::requestPermission):
1009
1010 2010-11-18  Satish Sampath  <satish@chromium.org>
1011
1012         Reviewed by Jeremy Orlow.
1013
1014         For speech input event, send an event object containing all the recognition results and metadata.
1015         https://bugs.webkit.org/show_bug.cgi?id=49736
1016
1017         Updated DRT by renaming the mock result method on all platforms to the new signature.
1018
1019         * DumpRenderTree/LayoutTestController.cpp:
1020         (addMockSpeechInputResultCallback):
1021         (LayoutTestController::staticFunctions):
1022         * DumpRenderTree/LayoutTestController.h:
1023         * DumpRenderTree/chromium/LayoutTestController.cpp:
1024         (LayoutTestController::LayoutTestController):
1025         (LayoutTestController::addMockSpeechInputResult):
1026         * DumpRenderTree/chromium/LayoutTestController.h:
1027         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1028         (LayoutTestController::addMockSpeechInputResult):
1029         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1030         (LayoutTestController::addMockSpeechInputResult):
1031         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1032         (LayoutTestController::addMockSpeechInputResult):
1033         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1034         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1035         (LayoutTestController::addMockSpeechInputResult):
1036         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1037         (LayoutTestController::addMockSpeechInputResult):
1038
1039 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1040
1041         Reviewed by Tony Chang.
1042
1043         Fix some spacing issues with log messages with
1044         new-run-webkit-tests --verbose.
1045
1046         https://bugs.webkit.org/show_bug.cgi?id=49936
1047
1048         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1049
1050 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1051
1052         Reviewed by Adam Barth.
1053
1054         update scm to work with different remote branches
1055         https://bugs.webkit.org/show_bug.cgi?id=49949
1056
1057         This works if there are multiple svn tracking branches
1058         and/or if the tracking branch is refs/remots/origin/master
1059         instead of refs/remotes/trunk which is the direction we're trying
1060         to head since that makes fetches faster.
1061
1062         * Scripts/webkitpy/common/checkout/scm.py:
1063         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1064
1065 2010-11-22  Hayato Ito  <hayato@chromium.org>
1066
1067         Reviewed by Shinichiro Hamaji.
1068
1069         Ignore reference files which will be used by reftests when collecting
1070         test cases.
1071         https://bugs.webkit.org/show_bug.cgi?id=49835
1072
1073         * Scripts/webkitpy/layout_tests/port/test_files.py:
1074         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1075
1076 2010-11-22  Adam Roben  <aroben@apple.com>
1077
1078         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1079
1080         Apple's Windows build allows placing header files and import libraries for WebKit's
1081         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1082         $WebKitLibrariesDir environment variable. This is both required for production builds and
1083         convenient for Apple-internal developer builds. Apple's production builds also require that
1084         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1085         builds, the files are copied into that directory tree by the
1086         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1087         copying is done by
1088         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1089
1090         This .vsprops copying is problematic in one very important case: when a developer updates
1091         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1092         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1093         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1094         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1095         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1096         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1097
1098         To fix this, we now use normal relative paths to access the .vsprops files in the source
1099         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1100         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1101         unset, so the normal relative paths are used to read the .vsprops files out of the source
1102         tree directly. In production builds, this environment variable is set to a fake directory
1103         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1104         is resolved.
1105         
1106         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1107
1108         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1109
1110         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1111         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1112         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1113         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1114         FeatureDefines.vsprops becomes:
1115
1116         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1117
1118         which resolves to:
1119
1120         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1121
1122         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1123         actually exist since they are matched by an equal number of ".." path components.)
1124
1125         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1126         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1127
1128         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1129         updated
1130
1131         Reviewed by Dave Hyatt.
1132
1133         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1134         * DumpRenderTree/win/DumpRenderTree.vcproj:
1135         * DumpRenderTree/win/ImageDiff.vcproj:
1136         * FindSafari/FindSafari.vcproj:
1137         * MiniBrowser/MiniBrowser.vcproj:
1138         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1139         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1140         * WebKitAPITest/WebKitAPITest.vcproj:
1141         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1142         * WebKitTestRunner/win/InjectedBundle.vcproj:
1143         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1144         * WinLauncher/WinLauncher.vcproj:
1145         * record-memory-win/record-memory-win.vcproj:
1146         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1147         files.
1148
1149 2010-11-22  Adam Roben  <aroben@apple.com>
1150
1151         Make it possible to run tests on Windows without Visual Studio or VC++
1152         Express installed
1153
1154         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1155         are not installed. But this function doesn't need to be called when we
1156         already have a build available and are just trying to run the tests.
1157
1158         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1159         because Visual Studio/VC++ Express aren't installed
1160
1161         Reviewed by Dave Hyatt.
1162
1163         * Scripts/webkitdirs.pm:
1164         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1165         it is not needed by this function. Also added a FIXME.
1166
1167         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1168         relying on determineConfigurationForVisualStudio doing it.
1169
1170 2010-11-19  Hayato Ito  <hayato@chromium.org>
1171
1172         Reviewed by Shinichiro Hamaji.
1173
1174         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1175
1176         https://bugs.webkit.org/show_bug.cgi?id=49812
1177
1178         * Scripts/webkitpy/layout_tests/driver_test.py:
1179         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1180         * Scripts/webkitpy/layout_tests/port/base.py:
1181         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1182         * Scripts/webkitpy/layout_tests/port/chromium.py:
1183         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1184         * Scripts/webkitpy/layout_tests/port/test.py:
1185         * Scripts/webkitpy/layout_tests/port/webkit.py:
1186         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1187         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1188
1189 2010-11-22  Hayato Ito  <hayato@chromium.org>
1190
1191         Reviewed by Tony Chang.
1192
1193         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1194
1195         https://bugs.webkit.org/show_bug.cgi?id=49924
1196
1197         * Scripts/webkitpy/layout_tests/port/chromium.py:
1198
1199 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1200
1201         Reviewed by Kenneth Rohde Christiansen.
1202
1203         Fix EWebLauncher zoom discretization
1204         https://bugs.webkit.org/show_bug.cgi?id=49810
1205
1206         * EWebLauncher/main.c:
1207         (nearest_zoom_level_get):
1208         (zoom_level_set):
1209         (on_load_finished):
1210         (on_key_down):
1211
1212 2010-11-21  Sam Weinig  <sam@webkit.org>
1213
1214         Rubber-stamped by Dan Bernstein.
1215
1216         Fix ~300 WebKit2 tests by enabling developer extras preference.
1217
1218         * WebKitTestRunner/TestController.cpp:
1219         (WTR::TestController::resetStateToConsistentValues):
1220
1221 2010-11-21  Sam Weinig  <sam@webkit.org>
1222
1223         Reviewed by Dan Bernstein.
1224
1225         Textareas should be resizable by default
1226         https://bugs.webkit.org/show_bug.cgi?id=49892
1227
1228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1229         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1230         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1231         Add preferences test.
1232
1233 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1234
1235         Reviewed by Tony Chang.
1236
1237         Rebaseline server: checksum-only differences and prefetching
1238         https://bugs.webkit.org/show_bug.cgi?id=49841
1239         
1240         Add support for image test results where the only difference is in the
1241         checksum.
1242         
1243         Add prefetching of the image results from the next test.
1244         
1245         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1246         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1247         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1248
1249 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1250
1251         Reviewed by Tony Chang.
1252
1253         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1254
1255         Add the 'worker number' and 'worker name' concepts to the 
1256         TestShellThread objects, and move test_types and test_args from
1257         the TestRunner to the TestShellThread.
1258
1259         https://bugs.webkit.org/show_bug.cgi?id=49768
1260
1261         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1262         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1263
1264 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1265
1266         Reviewed by Ojan Vafai.
1267
1268         Do some minor cleanup and bug fixing.
1269
1270         https://bugs.webkit.org/show_bug.cgi?id=49777
1271
1272         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1273         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1274
1275 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1276
1277         Reviewed by Ojan Vafai.
1278
1279         nrwt - config.build_directory() is busted
1280
1281         Fixes a typo that was causing us to usually return the top level
1282         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1283         bug was hidden by test stubs that were too simplistic :(.
1284
1285         https://bugs.webkit.org/show_bug.cgi?id=49815
1286
1287         * Scripts/webkitpy/common/system/executive_mock.py:
1288         * Scripts/webkitpy/layout_tests/port/config.py:
1289         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1290
1291 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1292
1293         Reviewed by Adam Roben.
1294
1295         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1296         https://bugs.webkit.org/show_bug.cgi?id=49819
1297
1298         * DumpRenderTree/DumpRenderTree.sln:
1299         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1300         * DumpRenderTree/win/DumpRenderTree.vcproj:
1301         * DumpRenderTree/win/ImageDiff.vcproj:
1302         * FindSafari/FindSafari.vcproj:
1303         * MiniBrowser/MiniBrowser.vcproj:
1304         * TestWebKitAPI/win/TestWebKitAPI.sln:
1305         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1306         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1307         * WebKitAPITest/WebKitAPITest.vcproj:
1308         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1309         * WebKitTestRunner/win/InjectedBundle.vcproj:
1310         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1311         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1312         * WinLauncher/WinLauncher.vcproj:
1313         * record-memory-win/record-memory-win.vcproj:
1314
1315 2010-11-19  Adam Roben  <aroben@apple.com>
1316
1317         Add some more Windows slaves
1318
1319         This is probably more than we will be using in the immediate future,
1320         but having some extra slave names makes experimenting with different
1321         configurations easier.
1322
1323         Reviewed by Jon Honeycutt.
1324
1325         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1326         Windows slaves and distributed them among the three different Test
1327         builders.
1328
1329 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1330
1331         Reviewed by Ojan Vafai.
1332
1333         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1334         https://bugs.webkit.org/show_bug.cgi?id=49702
1335
1336         Re-landing r72357 with a test fix.
1337
1338         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1339         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1340         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1341
1342 2010-11-19  Avi Drissman  <avi@google.com>
1343
1344         Reviewed by Antonio Gomes.
1345
1346         Complete support for Unix editing mode
1347         https://bugs.webkit.org/show_bug.cgi?id=49757
1348
1349         * DumpRenderTree/LayoutTestController.cpp:
1350         (setEditingBehaviorCallback):
1351         * DumpRenderTree/chromium/LayoutTestController.cpp:
1352         (LayoutTestController::setEditingBehavior):
1353
1354 2010-11-19  Adam Roben  <aroben@apple.com>
1355
1356         Fix run-javascriptcore-tests when there's a space in the path to
1357         testapi
1358
1359         Reviewed by Sam Weinig.
1360
1361         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1362         system() to force it to interpret spaces in the path correctly.
1363
1364 2010-11-19  Adam Roben  <aroben@apple.com>
1365
1366         Update scripts for .exe name changes after r72327
1367
1368         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1369
1370         Reviewed by Sam Weinig.
1371
1372         * Scripts/run-javascriptcore-tests:
1373         (testapiPath):
1374
1375         * Scripts/sunspider-compare-results:
1376         (pathToBuiltJSC):
1377
1378         * Scripts/webkitdirs.pm:
1379         (jscPath):
1380         (safariPath):
1381
1382 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1383
1384         Reviewed by Darin Adler.
1385
1386         Normalize Cairo/CFLite project/solution configuration names
1387         https://bugs.webkit.org/show_bug.cgi?id=49818
1388
1389         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1390         * DumpRenderTree/win/DumpRenderTree.vcproj:
1391         * DumpRenderTree/win/ImageDiff.vcproj:
1392         * MiniBrowser/MiniBrowser.vcproj:
1393         * TestWebKitAPI/win/TestWebKitAPI.sln:
1394         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1395         * WebKitAPITest/WebKitAPITest.vcproj:
1396         * WebKitTestRunner/win/InjectedBundle.vcproj:
1397         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1398         * WinLauncher/WinLauncher.vcproj:
1399         * Scripts/webkitdirs.pm: Updated cairo build configs.
1400
1401 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1402
1403         Reviewed by Adam Roben.
1404
1405         Windows vcproj configuration names should be normalized across projects
1406         https://bugs.webkit.org/show_bug.cgi?id=49776
1407
1408         * DumpRenderTree/DumpRenderTree.sln:
1409         * FindSafari/FindSafari.vcproj:
1410         * TestWebKitAPI/win/TestWebKitAPI.sln:
1411         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1412         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1413         * WebKitAPITest/WebKitAPITest.vcproj:
1414         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1415         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1416         * WebKitTestRunner/WebKitTestRunner.sln:
1417         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1418         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1419         * record-memory-win/record-memory-win.vcproj:
1420
1421 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1422
1423         Build fix - as per DRT-mac, always enabled developer extras,
1424         in win/qt/gtk DRT.
1425
1426         This is necessary to enable rich exception messages to be generated
1427         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1428
1429         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1430         (shouldEnableDeveloperExtras):
1431         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1432         (WebCore::shouldEnableDeveloperExtras):
1433         * DumpRenderTree/win/DumpRenderTree.cpp:
1434         (shouldEnableDeveloperExtras):
1435
1436 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1437
1438         Unreviewed, rolling out r72357.
1439         http://trac.webkit.org/changeset/72357
1440         https://bugs.webkit.org/show_bug.cgi?id=49784
1441
1442         It broke test-webkitpy tests since the patch didn't have the
1443         corresponding test update (Requested by kinuko on #webkit).
1444
1445         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1446         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1447
1448 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
1449
1450         Reviewed by Tony Chang.
1451
1452         Rebaseline server: add rebaseline queue
1453         https://bugs.webkit.org/show_bug.cgi?id=49763
1454         
1455         Add a UI queue (a multi-item <select>) where tests to be baselined
1456         can be enqueued (also supports basic removal). A queue is used instead
1457         of immediately doing rebaselines since SCM operations can take a while.
1458         It's better to go through lots of tests quickly to mark them as
1459         needing rebaselining and then batch the SCM operations.
1460         
1461         Also adds a simple log where results can be displayed.
1462
1463         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1464         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1465         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1466         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
1467         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1468         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1469
1470 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1471
1472         Reviewed by Oliver Hunt.
1473
1474         Bug 49708 - Stop recompiling functions to regenerate exception info.
1475
1476         Instead only hold info as necessary – keep divot info is the inspector
1477         is enabled, line number info is debugging or profiling, and handler
1478         info for functions with try/catch.
1479
1480         * DumpRenderTree/mac/DumpRenderTree.mm:
1481         (shouldEnableDeveloperExtras):
1482             - always enable the developer tools from DRT, to ensure we
1483               produce rich error messages on JavaScript exceptions.
1484
1485 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1486
1487         Reviewed by Ojan Vafai.
1488
1489         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1490         https://bugs.webkit.org/show_bug.cgi?id=49702
1491
1492         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1493         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1494
1495 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1496
1497         Reviewed by Tony Chang.
1498
1499         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1500
1501         Create the first version of the 'message_broker' package. This
1502         class will encapsulate all of the threading/multiprocessing and
1503         message-sending details for the communication between the
1504         'manager' object and the 'worker' objects. For the moment, it
1505         just holds some routines and tests for logging thread stacks.
1506
1507         There should be no functional changes in this patch, just moving stuff
1508         around.
1509
1510         https://bugs.webkit.org/show_bug.cgi?id=49707
1511
1512         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1513         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1514         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1515         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1516         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1517         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1518
1519 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1520
1521         Reviewed by Adam Roben.
1522
1523         Remove leftover Windows Debug_Internal configurations
1524         https://bugs.webkit.org/show_bug.cgi?id=49758
1525
1526         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1527         * DumpRenderTree/win/DumpRenderTree.vcproj:
1528         * DumpRenderTree/win/ImageDiff.vcproj:
1529         * MiniBrowser/MiniBrowser.vcproj:
1530         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1531         * WebKitAPITest/WebKitAPITest.vcproj:
1532         * WebKitTestRunner/win/InjectedBundle.vcproj:
1533         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1534         * WinLauncher/WinLauncher.vcproj:
1535
1536 2010-11-18  Adam Roben  <aroben@apple.com>
1537
1538         Add three new Windows XP build slaves
1539
1540         Reviewed by Steve Falkenburg.
1541
1542         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1543         new slaves, and added them to the Windows XP Debug (Tests) builder.
1544
1545 2010-11-18  Daniel Bates  <dbates@rim.com>
1546
1547         Reviewed by Adam Roben.
1548
1549         update-webkit-support-libs should fall back to existing
1550         WebKitSupportLibrary version if there is no internet connectivity
1551         https://bugs.webkit.org/show_bug.cgi?id=49503
1552
1553         Fall back to existing support libraries (if present) when there is
1554         no internet connection.
1555
1556         Currently, update-webkit-support-libs dies with an "out-of-date"
1557         error when there is no internet connection because it cannot
1558         retrieve versioning information from developer.apple.com. Because
1559         update-webkit-support-libs fails, build-webkit fails. Instead,
1560         if there is no internet connection and the support libraries are
1561         present then we should warn the user and exit() with success so
1562         that build-webkit can work without an internet connection.
1563
1564         * Scripts/update-webkit-support-libs:
1565
1566 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1567
1568         Reviewed by Adam Roben.
1569
1570         Debug_Internal Windows configuration is unnecessary, should be removed
1571         https://bugs.webkit.org/show_bug.cgi?id=49753
1572
1573         * DumpRenderTree/win/DumpRenderTree.cpp:
1574         * MiniBrowser/win/stdafx.h:
1575         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1576         * WebKitTestRunner/win/TestControllerWin.cpp:
1577
1578 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1579
1580         Reviewed by Adam Roben.
1581
1582         Clean up vcproj errors
1583         https://bugs.webkit.org/show_bug.cgi?id=49741
1584
1585         * MiniBrowser/MiniBrowser.vcproj:
1586         * WebKitAPITest/WebKitAPITest.vcproj:
1587         * WebKitTestRunner/win/InjectedBundle.vcproj:
1588         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1589
1590 2010-11-18  Hayato Ito  <hayato@chromium.org>
1591
1592         Reviewed by Shinichiro Hamaji.
1593
1594         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1595         which is caused by r72249.
1596
1597         https://bugs.webkit.org/show_bug.cgi?id=49751
1598
1599         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1600
1601 2010-11-18  Adam Roben  <aroben@apple.com>
1602
1603         Implement layoutTestController.waitForPolicyDelegate on Windows
1604
1605         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1606
1607         Reviewed by Simon Fraser.
1608
1609         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1610         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1611         code from LayoutTestControllerMac.mm.
1612
1613 2010-11-18  Hayato Ito  <hayato@chromium.org>
1614
1615         Reviewed by Shinichiro Hamaji.
1616
1617         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1618
1619         https://bugs.webkit.org/show_bug.cgi?id=49740
1620
1621         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1622
1623 2010-11-18  Tony Chang  <tony@chromium.org>
1624
1625         Reviewed by Adam Barth.
1626
1627         run platform/chromium/plugins/refcount-leaks.html on all platforms
1628         https://bugs.webkit.org/show_bug.cgi?id=49485
1629
1630         Add PluginObject.testObjectCount which returns the number of allocated
1631         TestObjects. Add PluginObject.testCreateTestObject which allocates
1632         and returns a TestObject.
1633
1634         Add TestObject.refCount which returns the number of refs on the
1635         TestObject.
1636
1637         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1638         (pluginGetProperty):
1639         (pluginInvoke):
1640         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1641         (getTestObjectCount):
1642         (testAllocate):
1643         (testDeallocate):
1644         (testGetProperty):
1645         (testScriptObjectInvoke): Release a ref to a plugin object that was
1646             previously leaked.
1647         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1648
1649 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1650
1651         Reviewed by Adam Roben.
1652
1653         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1654         https://bugs.webkit.org/show_bug.cgi?id=49711
1655
1656         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1657         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1658         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1659         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1660         * record-memory-win/record-memory-win-common.vsprops: Added.
1661         * record-memory-win/record-memory-win.vcproj:
1662
1663 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1664
1665         Reviewed by Csaba Osztrogonác.
1666
1667         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1668
1669         * MiniBrowser/qt/BrowserWindow.cpp:
1670         (BrowserWindow::updateUserAgentList):
1671
1672 2010-11-17  Adam Roben  <aroben@apple.com>
1673
1674         Don't trigger Windows builds when chromium-win test results change
1675
1676         Reviewed by Mark Rowe.
1677
1678         * Scripts/webkitpy/common/config/build.py:
1679         (_should_file_trigger_build): Changed the regular expression used to
1680         search for directory names to only consider full directory names,
1681         rather than matching directory names where the string we care about is
1682         a suffix of the name.
1683
1684         * Scripts/webkitpy/common/config/build_unittest.py:
1685         (ShouldBuildTest): Added a test.
1686
1687 2010-11-17  Hayato Ito  <hayato@chromium.org>
1688
1689         Reviewed by Shinichiro Hamaji.
1690
1691         Remove a uri member from TestInput class.
1692
1693         https://bugs.webkit.org/show_bug.cgi?id=49691
1694
1695         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1696         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1697
1698 2010-11-17  Adam Roben  <aroben@apple.com>
1699
1700         Move FindSafari's settings into a vsprops file
1701
1702         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1703
1704         Reviewed by Steve Falkenburg.
1705
1706         * FindSafari/FindSafari.vcproj:
1707         * FindSafari/FindSafariCommon.vsprops: Added.
1708
1709 2010-11-17  Adam Roben  <aroben@apple.com>
1710
1711         Use a minimum font size of 0 in DRT on Windows
1712
1713         This is the Windows equivalent of r72164.
1714
1715         Rubber-stamped by Dave Hyatt.
1716
1717         * DumpRenderTree/win/DumpRenderTree.cpp:
1718         (resetDefaultsToConsistentValues):
1719
1720 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1721
1722         Reviewed by Andreas Kling.
1723
1724         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1725         https://bugs.webkit.org/show_bug.cgi?id=49639
1726
1727         * Scripts/webkitpy/common/checkout/scm.py:
1728
1729 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1730
1731         Reviewed by Tony Chang.
1732
1733         Rebaseline server: add loupe for image diffs
1734         https://bugs.webkit.org/show_bug.cgi?id=49692
1735         
1736         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1737         enlarged area of the expected, actual and diff images side by side.
1738
1739         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1740         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1741         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1742         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1743
1744 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1745
1746         Reviewed by Adam Roben.
1747
1748         WebKitLauncherWin should use vsprops for shared build settings
1749         https://bugs.webkit.org/show_bug.cgi?id=49696
1750
1751         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1752         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1753
1754 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1755
1756         Reviewed by Adam Roben.
1757
1758         WinLauncher should use vsprops for shared build settings
1759         https://bugs.webkit.org/show_bug.cgi?id=49695
1760
1761         * WinLauncher/WinLauncher.cpp:
1762         (_tWinMain):
1763         (PrintView):
1764         (WndProc):
1765         (MyEditProc):
1766         * WinLauncher/WinLauncher.vcproj:
1767         * WinLauncher/WinLauncherCommon.vsprops: Added.
1768
1769 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1770
1771         Delete unused file unintentionally added in last change.
1772
1773         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1774
1775 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1776
1777         Reviewed by Adam Roben.
1778
1779         DumpRenderTree on Windows should use a vsprops file for shared project settings
1780         https://bugs.webkit.org/show_bug.cgi?id=49690
1781
1782         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1783         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1784         * DumpRenderTree/win/DumpRenderTree.vcproj:
1785         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1786         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1787         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1788         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1789         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1790         * DumpRenderTree/win/ImageDiff.vcproj:
1791         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1792
1793 2010-11-17  Hayato Ito  <hayato@chromium.org>
1794
1795         Refactor TestTypeBase.compare_output().
1796
1797         Introduce a TestOutput class and update compare_output() of each test
1798         types so that they can take both actual and expected TestOutput objects.
1799
1800         https://bugs.webkit.org/show_bug.cgi?id=49431
1801
1802         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1803         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1804         * Scripts/webkitpy/layout_tests/port/base.py:
1805         * Scripts/webkitpy/layout_tests/port/chromium.py:
1806         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1807         * Scripts/webkitpy/layout_tests/port/test.py:
1808         * Scripts/webkitpy/layout_tests/port/webkit.py:
1809         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1810         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1811         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1812         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1813
1814 2010-11-17  Adam Roben  <aroben@apple.com>
1815
1816         Make each Windows Test builder use the same OS for all its slaves
1817
1818         Currently each WebKit1 Windows Test builder has one Windows XP slave
1819         and one Windows 7 slave. Having different OSes in a single builder
1820         meant that the builders would alternate between red and green when
1821         there were OS-specific failures.
1822
1823         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1824         between red and green because of multiple OS versions
1825
1826         Reviewed by Mark Rowe.
1827
1828         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1829         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1830         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1831         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1832         builders for the two WebKit1 builders so that they would all use the
1833         appropriate OS.
1834
1835 2010-11-17  James Robinson  <jamesr@chromium.org>
1836
1837         Reviewed by Dan Bernstein.
1838
1839         [chromium] Set minimum font size to 0 for DRT
1840         https://bugs.webkit.org/show_bug.cgi?id=49677
1841
1842         Followup for http://trac.webkit.org/changeset/72141.
1843
1844         Test: http/tests/misc/acid3.html
1845
1846         * DumpRenderTree/chromium/WebPreferences.cpp:
1847         (WebPreferences::reset):
1848
1849 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1850
1851         Unreviewed build fix.
1852
1853         [Qt] Add missing file I forgot in r72220.
1854
1855         * MiniBrowser/MiniBrowser.qrc: Added.
1856
1857 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1858
1859         Reviewed by Andreas Kling.
1860
1861         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1862         https://bugs.webkit.org/show_bug.cgi?id=49627
1863
1864         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1865
1866         * MiniBrowser/MiniBrowser.qrc: Added.
1867         Add it here to prevent qmake from detecting it
1868         since it needs to be copied to the build directory.
1869         * MiniBrowser/qt/BrowserWindow.cpp:
1870         (BrowserWindow::BrowserWindow):
1871         (BrowserWindow::updateUserAgentList):
1872         (BrowserWindow::showUserAgentDialog):
1873         * MiniBrowser/qt/BrowserWindow.h:
1874         * MiniBrowser/qt/MiniBrowser.pro:
1875
1876 2010-11-17  Adam Roben  <aroben@apple.com>
1877
1878         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1879
1880         We use that file on Windows!
1881
1882         Fixes <http://webkit.org/b/49643> Changes to
1883         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1884
1885         Reviewed by Steve Falkenburg.
1886
1887         * Scripts/webkitpy/common/config/build.py:
1888         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1889         trigger builds on SnowLeopard and Windows.
1890
1891         * Scripts/webkitpy/common/config/build_unittest.py:
1892         (ShouldBuildTest.test_should_build): Added a test.
1893
1894 2010-11-17  Satish Sampath  <satish@chromium.org>
1895
1896         Reviewed by Jeremy Orlow.
1897
1898         Clear the speech input mock explicitly before each test.
1899         https://bugs.webkit.org/show_bug.cgi?id=49660
1900
1901         * DumpRenderTree/chromium/LayoutTestController.cpp:
1902         (LayoutTestController::setMockSpeechInputResult):
1903         * DumpRenderTree/chromium/LayoutTestController.h:
1904         * DumpRenderTree/chromium/WebViewHost.cpp:
1905         (WebViewHost::speechInputController):
1906         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1907         * DumpRenderTree/chromium/WebViewHost.h:
1908         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1909
1910 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1911
1912         Unreviewed, specify IRC nickname in committers.py.
1913
1914         * Scripts/webkitpy/common/config/committers.py:
1915
1916 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1917
1918         Reviewed by Tony Chang.
1919
1920         [NRWT] Make http locking similar to perl implementation
1921         https://bugs.webkit.org/show_bug.cgi?id=49187
1922
1923         * Scripts/webkitpy/common/system/file_lock.py: Added.
1924         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1925         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1926
1927 2010-11-17  MORITA Hajime  <morrita@google.com>
1928
1929         Reviewed by Kent Tamura.
1930
1931         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1932         https://bugs.webkit.org/show_bug.cgi?id=49366
1933
1934         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1935           according to the spellchecker suggestion
1936         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1937
1938         test_expectations.txt will be changed after this change is ported to test_shell.
1939         
1940         * DumpRenderTree/chromium/EventSender.cpp:
1941         (makeMenuItemStringsFor):
1942         (EventSender::contextClick):
1943         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1944         (MockSpellCheck::fillSuggestionList):
1945         (MockSpellCheck::initializeIfNeeded):
1946         * DumpRenderTree/chromium/MockSpellCheck.h:
1947         * DumpRenderTree/chromium/WebViewHost.cpp:
1948         (WebViewHost::mockSpellCheck):
1949         * DumpRenderTree/chromium/WebViewHost.h:
1950
1951 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1952
1953         Reviewed by Sam Weinig.
1954
1955         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1956         since the bots have 1 stuck in their plist otherwise.
1957
1958         * DumpRenderTree/mac/DumpRenderTree.mm:
1959         (resetDefaultsToConsistentValues):
1960
1961 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1962
1963         Reviewed by Tony Chang.
1964
1965         Rebaseline server: compute diffs client-side
1966         https://bugs.webkit.org/show_bug.cgi?id=49640
1967         
1968         The image diff output from the DRT is pretty bad on some ports (at
1969         least the Mac one), so it's better to compute diffs on the client by
1970         using <canvas>.
1971
1972         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1973         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1974         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1975
1976 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1977
1978         Reviewed by Tony Chang.
1979
1980         Rebaseline server: display test results
1981         https://bugs.webkit.org/show_bug.cgi?id=49626
1982         
1983         Adds basic result display to the rebaseline server. On the Python side
1984         this involves:
1985         - Parsing the unexpected_results.json into a dictionary.
1986         - Serving it as JSON under /results.json.
1987         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
1988         but I'll need to have access to the parsed results on the Python side
1989         for follow-up changes).
1990         
1991         On the web UI side this adds:
1992         - Markup for display image and text results (expected, actual, diff),
1993           and JS for populating it.
1994         - Markup for breaking down test results by failure type and directory,
1995           and JS for populating it.
1996
1997         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1998         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1999         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2000         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
2001         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2002
2003 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2004
2005         Reviewed by Ojan Vafai.
2006
2007         See Chromium issue http://codereview.chromium.org/5133001/ - we
2008         are modifying the build bots to pass in the builder name with
2009         the "GPU" string appended instead of appending it in the code.
2010
2011         https://bugs.webkit.org/show_bug.cgi?id=49636
2012
2013         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2014
2015 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
2016
2017         Reviewed by Adam Roben.
2018
2019         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2020         https://bugs.webkit.org/show_bug.cgi?id=49632
2021
2022         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2023         * DumpRenderTree/win/DumpRenderTree.vcproj:
2024         * DumpRenderTree/win/ImageDiff.vcproj:
2025         * MiniBrowser/MiniBrowser.vcproj:
2026         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2027         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2028         * WebKitTestRunner/win/InjectedBundle.vcproj:
2029         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2030         * WinLauncher/WinLauncher.vcproj:
2031         * record-memory-win/record-memory-win.vcproj:
2032
2033 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2034
2035         Reviewed by Ojan Vafai.
2036
2037         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2038
2039         Rename the TestInfo class to TestInput to be clearer about its
2040         function, and move the checksum-reading code into dump_render_tree_thread
2041         to avoid cross-thread access.
2042
2043         https://bugs.webkit.org/show_bug.cgi?id=49573
2044
2045         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2046         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2047         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2048
2049 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2050
2051         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2052
2053         * DumpRenderTree/mac/DumpRenderTree.mm:
2054         (resetDefaultsToConsistentValues):
2055
2056 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2057
2058         Reviewed by Geoff Garen.
2059
2060         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2061
2062         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
2063         for every WebView, and the WebKit API doesn't support that ownership model.
2064
2065         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2066
2067         * DumpRenderTree/mac/DumpRenderTree.mm:
2068         (createWebViewAndOffscreenWindow):
2069         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2070         (LayoutTestController::setMockDeviceOrientation):
2071
2072 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2073
2074         Reviewed by Ojan Vafai.
2075
2076         new-run-webkit-tests: log the process id in --verbose mode
2077
2078         As part of the switch to multi-process mode, we should log the
2079         process id when running w/ --verbose.
2080
2081         https://bugs.webkit.org/show_bug.cgi?id=49571
2082
2083         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2084
2085 2010-11-16  Adam Roben  <aroben@apple.com>
2086
2087         Only trigger Windows builds when files that we actually use on Windows
2088         are changed
2089
2090         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2091         It uses the new webkitpy.common.config.build module to determine
2092         whether a particular change should trigger a build on a particular
2093         platform. The Windows builders have been switched to use a
2094         PlatformSpecificScheduler.
2095
2096         The logic to determine whether or not a particular change should
2097         trigger a build on a given platform has only been implemented/tested
2098         for Windows. I tried to make it easy to add more platforms in the
2099         future, but I don't have enough familiarity with all platforms to be
2100         able to implement it for them.
2101
2102         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2103         lots irrelevant changes (e.g., rebaselining Chromium test results)
2104
2105         Reviewed by Eric Seidel.
2106
2107         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2108         PlatformSpecificScheduler for the Windows builders.
2109
2110         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2111         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2112         up a ChangeFilter that filters to our branch and will call through to
2113         our filter method, and calls up to our base class.
2114         (PlatformSpecificScheduler.filter): Calls through to
2115         build.should_build to find out whether we should trigger a build for
2116         this change.
2117
2118         * Scripts/webkitpy/common/net/build.py: Added.
2119         (_should_file_trigger_build): Uses a set of directories and regexp
2120         patterns to determine whether the given file should trigger a build on
2121         the given platform. As mentioned earlier, this has only been
2122         implemented for Windows, though I did try to make some guesses about
2123         other platforms.
2124         (should_build): Returns true if any of the files should trigger a
2125         build on the given platform.
2126
2127         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2128         (ShouldBuildTest.test_should_build): Does some basic testing to make
2129         sure we're triggering builds for the right files. It only tests
2130         Windows for now, though I tried to make some guesses about other
2131         platforms.
2132
2133 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2134
2135         Reviewed by Andreas Kling.
2136
2137         [Qt] Remove synchronous QWebPage::checkPermissions signal
2138         https://bugs.webkit.org/show_bug.cgi?id=46810
2139
2140         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2141         (WebCore::WebPage::WebPage):
2142         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2143         (LayoutTestController::grantDesktopNotificationPermission): When granting
2144         permission, grant it directly on the QWebPage/Frame, that will remember it.
2145         * QtTestBrowser/webpage.cpp:
2146         (WebPage::WebPage):
2147         * QtTestBrowser/webpage.h:
2148
2149
2150 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2151
2152         Reviewed by Csaba Osztrogonác.
2153
2154         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2155
2156         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2157         (LayoutTestController::reset):
2158         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2159         (LayoutTestController::isPrinting):
2160         (LayoutTestController::setPrinting):
2161
2162 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2163
2164         Reviewed by Andreas Kling.
2165
2166         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2167         https://bugs.webkit.org/show_bug.cgi?id=49587
2168
2169         * MiniBrowser/qt/BrowserView.cpp:
2170         (BrowserView::BrowserView): Added BackingStoreType
2171         argument to ctor. Propagating it to the QGraphicsWKView.
2172         * MiniBrowser/qt/BrowserView.h:
2173         * MiniBrowser/qt/BrowserWindow.cpp:
2174         (BrowserWindow::BrowserWindow):
2175         (BrowserWindow::newWindow): Create the new BrowserWindow
2176         with the same BackingStoreType that this instance has.
2177         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2178         * MiniBrowser/qt/main.cpp:
2179         (main): Use tiled backing store if got -tiled command line argument.
2180         Avoid redundant copy of command line args.
2181
2182 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2183
2184         Reviewed by Jeremy Orlow.
2185
2186         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2187         https://bugs.webkit.org/show_bug.cgi?id=48506
2188
2189         This ensures that there is one mock per page WebView / WebViewHost. This is a
2190         design constraint of the DeviceOrientationClientMock because the m_controller
2191         field can only store a pointer to a single instance of the corresponding
2192         DeviceOrientationController.
2193
2194         Test: fast/dom/DeviceOrientation/no-page-cache.html
2195
2196         * DumpRenderTree/chromium/LayoutTestController.cpp:
2197         (LayoutTestController::setMockDeviceOrientation):
2198         (LayoutTestController::deviceOrientationClientMock):
2199         * DumpRenderTree/chromium/LayoutTestController.h:
2200         * DumpRenderTree/chromium/WebViewHost.cpp:
2201         (WebViewHost::deviceOrientationClientMock):
2202         (WebViewHost::deviceOrientationClient):
2203         (WebViewHost::reset):
2204         * DumpRenderTree/chromium/WebViewHost.h:
2205
2206 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2207
2208         Reviewed by Andreas Kling.
2209
2210         [Qt][WK2] Avoid polling in WebKitTestRunner.
2211         https://bugs.webkit.org/show_bug.cgi?id=49542
2212
2213         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2214         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2215
2216         * WebKitTestRunner/TestController.cpp:
2217         (WTR::TestController::didFinishLoadForFrame):
2218         * WebKitTestRunner/TestController.h:
2219         * WebKitTestRunner/TestInvocation.cpp:
2220         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2221         * WebKitTestRunner/mac/TestControllerMac.mm:
2222         (WTR::TestController::notifyDone): Add method stub.
2223         * WebKitTestRunner/qt/TestControllerQt.cpp:
2224         (WTR::TestControllerRunLoop::instance):
2225         (WTR::TestControllerRunLoop::start):
2226         (WTR::TestControllerRunLoop::stop):
2227         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2228         (WTR::TestControllerRunLoop::timerEvent):
2229         (WTR::TestController::notifyDone):
2230         (WTR::TestController::platformRunUntil):
2231         * WebKitTestRunner/win/TestControllerWin.cpp:
2232         (WTR::TestController::notifyDone): Add method stub.
2233
2234 2010-11-15  Darin Adler  <darin@apple.com>
2235
2236         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2237
2238 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2239
2240         Reviewed by Andreas Kling.
2241
2242         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2243         https://bugs.webkit.org/show_bug.cgi?id=49544
2244
2245         Add the shortcut to BrowserWindow.
2246
2247         * MiniBrowser/qt/BrowserWindow.cpp:
2248         (BrowserWindow::BrowserWindow):
2249         (BrowserWindow::openLocation):
2250         * MiniBrowser/qt/BrowserWindow.h:
2251
2252 2010-11-14  David Levin  <levin@chromium.org>
2253
2254         Reviewed by Daniel Bates.
2255
2256         check-webkit-style should detect PassRefPtr usage in functions.
2257         https://bugs.webkit.org/show_bug.cgi?id=49513
2258
2259         * Scripts/webkitpy/style/checkers/cpp.py:
2260         (check_for_function_lengths): Revert a comment change that I
2261          accidentally made in r71986.
2262         (check_pass_ptr_usage): Added the code to do the check.
2263         (process_line): Added the call to check_pass_ptr_usage.
2264         (CppChecker): Added the new error category.
2265         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2266         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2267          testing purposes.
2268         (PassPtrTest::*): The class/functions to unit test the new
2269          functionality.
2270
2271 2010-11-14  David Levin  <levin@chromium.org>
2272
2273         Reviewed by Shinichiro Hamaji.
2274
2275         check-webkit-style function detection and the line count style checks should be separate.
2276         https://bugs.webkit.org/show_bug.cgi?id=49512
2277
2278         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2279         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2280           call the detection function and fix line counts in two places now that
2281           the code really only counts the lines in the body of the function.
2282
2283 2010-11-14  Andreas Kling  <kling@webkit.org>
2284
2285         Reviewed by Antonio Gomes.
2286
2287         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2288         https://bugs.webkit.org/show_bug.cgi?id=33438
2289
2290         Stifle "Unhandled variable" warning to match what the other
2291         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2292         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2293
2294         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2295         (webkit_test_plugin_get_value):
2296
2297 2010-11-13  David Levin  <levin@chromium.org>
2298
2299         Reviewed by Eric Seidel.
2300
2301         check-webkit-style function detection crashes on functions in templates.
2302         https://bugs.webkit.org/show_bug.cgi?id=49504
2303
2304         For example "template <bool shouldClose(const Element*)>".
2305
2306         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2307         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2308           function detection test to expose this issue.
2309
2310 2010-11-12  David Levin  <levin@chromium.org>
2311
2312         Reviewed by Shinichiro Hamaji.
2313
2314         check-webkit-style function detection doesn't detect indented functions declaractions.
2315         https://bugs.webkit.org/show_bug.cgi?id=49446
2316
2317         Indented function declarations occur inside class definitions, so
2318         they are a pretty common (and worth detecting).
2319
2320         * Scripts/webkitpy/style/checkers/cpp.py:
2321           Changed regex to allow indentation.
2322           Changed the function start detection to only happen when not in a
2323           function.
2324           Changed function end detection to work based on matching braces
2325           instead of finding a close brace at the beginning of the line.
2326           Fixed close_expression to do what it says when it doesn't find
2327           the close.
2328         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2329
2330 2010-11-12  Daniel Bates  <dbates@rim.com>
2331
2332         Rubber-stamped by Nikolas Zimmermann.
2333
2334         Make do-file-rename rename files in the directory WebKit2.
2335
2336         This also makes the list of searched directories in do-file-rename
2337         consistent with the list of searched directories in the script do-webcore-rename.
2338
2339         * Scripts/do-file-rename:
2340
2341 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2342
2343         Reviewed by James Robinson.
2344
2345         Attempt yet again to land the fix for bug 49360 (respecting
2346         set-webkit-configuration). We need to handle the cases where
2347         trying to run webkit-build-directory to find out where the
2348         default configuration might be fails (that shows up on some
2349         Chromium bots that apparently don't have perl installed).
2350
2351         https://bugs.webkit.org/show_bug.cgi?id=49360
2352
2353         * Scripts/webkitpy/layout_tests/port/config.py:
2354         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2355         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2356
2357 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2358
2359         Reviewed by Adam Barth.
2360
2361         webkit-patch land logs commit message twice
2362         https://bugs.webkit.org/show_bug.cgi?id=49482
2363         
2364         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2365         that's just the commit message, which we now output following the
2366         actual commit.
2367
2368         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2369
2370 2010-11-12  Tony Chang  <tony@chromium.org>
2371
2372         Reviewed by Adam Barth.
2373
2374         run platform/chromium/plugins/script-object-invoke.html on all platforms
2375         https://bugs.webkit.org/show_bug.cgi?id=49280
2376
2377         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2378         (testScriptObjectInvoke):
2379         (pluginInvoke):
2380
2381 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2382
2383         Reviewed by Adam Barth.
2384
2385         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2386         https://bugs.webkit.org/show_bug.cgi?id=49471
2387
2388         Right now there's no indication of a successful commit.
2389         
2390         * Scripts/webkitpy/tool/commands/download_unittest.py:
2391         * Scripts/webkitpy/tool/steps/commit.py:
2392
2393 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2394
2395         Reviewed by Ojan Vafai.
2396
2397         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2398         https://bugs.webkit.org/show_bug.cgi?id=49354
2399
2400         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2401
2402         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2403         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2404         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2405         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2406
2407 2010-11-12  Tony Chang  <tony@chromium.org>
2408
2409         Reviewed by Kent Tamura.
2410
2411         [chromium] Load a blank page when closing DRT WebViewHosts
2412         https://bugs.webkit.org/show_bug.cgi?id=49417
2413
2414         In test_shell, when we close a window, we first load about:blank
2415         and run GC to fire the destruction logic of the page.  In test_shell,
2416         this happens in ~TestShell.  In DRT, we manage virtual windows as
2417         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2418
2419         Managing focus is a bit trickier, since normally you would get window
2420         events to reset the focus to the right window.  We do it manually
2421         instead.
2422
2423         This fixes 2 plugin tests on DRT.
2424
2425         * DumpRenderTree/chromium/TestShell.cpp:
2426         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2427         (TestShell::closeWindow): Move widget close() to WVH destructor and
2428             manage focus manually.
2429         (TestShell::closeRemainingWindows): Comment typo.
2430         * DumpRenderTree/chromium/WebViewHost.cpp:
2431         (WebViewHost::closeWidget):
2432         (invokeCloseWidget):
2433         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2434             test_shell).
2435         (WebViewHost::~WebViewHost):
2436         * DumpRenderTree/chromium/WebViewHost.h:
2437
2438 2010-11-12  David Levin  <levin@chromium.org>
2439
2440         Reviewed by Adam Barth.
2441
2442         cpp.py needs some tidying.
2443         https://bugs.webkit.org/show_bug.cgi?id=49443
2444
2445         * Scripts/webkitpy/style/checkers/cpp.py:
2446           Fix parameter ordering for iteratively_replace_matches_with_char
2447           to mirror other similar functions (and improved comments, etc.)
2448           Also, use a python-ism (for/else) to get rid of a variable that
2449           was there to determine if something had been found in the loop.
2450
2451 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
2452
2453         Reviewed by James Robinson.
2454
2455         [Chromium/DRT] Make EventSendingController send complete touch events.
2456         https://bugs.webkit.org/show_bug.cgi?id=49285
2457
2458         * DumpRenderTree/chromium/EventSender.cpp:
2459         (EventSender::addTouchPoint):
2460         (EventSender::updateTouchPoint):
2461         (EventSender::sendCurrentTouchEvent):
2462
2463 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2464
2465         Unreviewed rollout of r71858.
2466
2467         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
2468         NaCl tests.
2469
2470         * Scripts/webkitpy/layout_tests/port/config.py:
2471         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
2472         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2473
2474 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
2475
2476         Reviewed by Kenneth Rohde Christiansen.
2477
2478         [Qt] TestController::runUntil doesn't honor the timeout parameter
2479         https://bugs.webkit.org/show_bug.cgi?id=48941
2480
2481         Implement the missing timeout of WebKitTestRunner for Qt.
2482
2483         A QElapsedTimer has been added to RunUntilConditionLoop in order
2484         to measure how long the loop has been running. When the timer
2485         is bigger or equal than the timeout, the loop ends even if the
2486         condition is not met.
2487
2488         * WebKitTestRunner/qt/TestControllerQt.cpp:
2489         (WTR::RunUntilConditionLoop::start):
2490         (WTR::RunUntilConditionLoop::run):
2491         (WTR::RunUntilConditionLoop::timerEvent):
2492         (WTR::TestController::platformRunUntil):
2493
2494 2010-11-11  David Levin  <levin@chromium.org>
2495
2496         Reviewed by Shinichiro Hamaji.
2497
2498         check-webkit-style function detection doesn't handle templates with spaces.
2499         https://bugs.webkit.org/show_bug.cgi?id=49427
2500
2501         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2502           finding the function name.
2503         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2504           template with a space.
2505
2506 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2507
2508         Reviewed by Shinichiro Hamaji.
2509
2510         Enable check-webkit-style on Qt files
2511         https://bugs.webkit.org/show_bug.cgi?id=48322
2512
2513         Adding exception for _q_... private slots and
2514         ..._data() methods in tests
2515
2516         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2517         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2518
2519 2010-11-11  David Levin  <levin@chromium.org>
2520
2521         Reviewed by Shinichiro Hamaji.
2522
2523         check-webkit-style function detection doesn't work for templates and destructors.
2524         https://bugs.webkit.org/show_bug.cgi?id=49425
2525
2526         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2527         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2528
2529 2010-11-11  Joone Hur  <joone@kldp.org>
2530
2531         Reviewed by Antonio Gomes.
2532
2533         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2534         https://bugs.webkit.org/show_bug.cgi?id=46598
2535
2536         Support nodesFromRect in DRT
2537
2538         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2539         (LayoutTestController::nodesFromRect):
2540
2541 2010-11-11  MORITA Hajime  <morrita@google.com>
2542
2543         Reviewed by Kent Tamura.
2544
2545         editing/selection/context-menu-on-text.html fails on chromium
2546         https://bugs.webkit.org/show_bug.cgi?id=45898
2547
2548         Enhance Chromium's EventSender::contextClick() to return
2549         array of menu strings. The implementation incomplete because
2550         Although actual context menu is implemented by the browser,
2551         it reflects editability of underlying context thus makes
2552         context-menu-on-text.html passed.
2553         
2554         * DumpRenderTree/chromium/EventSender.cpp:
2555         (makeMenuItemStringsFor): Added.
2556         (EventSender::contextClick): Now returns array of menu strings.
2557         * DumpRenderTree/chromium/WebViewHost.cpp:
2558         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2559         (WebViewHost::clearContextMenuData): Added.
2560         (WebViewHost::lastContextMenuData): Added.
2561         * DumpRenderTree/chromium/WebViewHost.h:
2562
2563 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2564
2565         Unreviewed, build fix.
2566
2567         fix build breakage caused by fix for bug 49380 (r71858).
2568
2569         config_standalone needs to ensure that the packages it needs are
2570         in sys.path.
2571
2572         https://bugs.webkit.org/show_bug.cgi?id=49419
2573
2574         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2575
2576 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2577
2578         Reviewed by Adam Roben.
2579
2580         Fix NRWT to respect set-webkit-configuration again :(
2581
2582         This change fixes a typo in config.py that was causing the wrong
2583         value to be read initially and us never actually looking into
2584         the filesystem to get the default configuration.
2585         
2586         * Scripts/webkitpy/layout_tests/port/config.py:
2587         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2588         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2589
2590 2010-11-11  Eric Seidel  <eric@webkit.org>
2591
2592         Reviewed by Adam Barth.
2593
2594         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2595         https://bugs.webkit.org/show_bug.cgi?id=49403
2596
2597         CommitterValidator really had nothing to do with bugzilla.py.
2598         I've put it next to committers.py for now since its rather tied to that file.
2599
2600         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2601         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2602         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2603         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2604         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2605         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2606         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2607         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2608         * Scripts/webkitpy/tool/bot/feeders.py:
2609         * Scripts/webkitpy/tool/commands/queues.py:
2610
2611 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2612
2613         Reviewed by Eric Seidel.
2614
2615         fix missing 'pid' argument for http lockfile checking on win32
2616         https://bugs.webkit.org/show_bug.cgi?id=49363
2617
2618         * Scripts/webkitpy/common/system/executive.py:
2619
2620 2010-11-11  Eric Seidel  <eric@webkit.org>
2621
2622         Rubber-stamped by Adam Barth.
2623
2624         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2625         https://bugs.webkit.org/show_bug.cgi?id=49402
2626
2627         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2628         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2629         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2630
2631 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2632
2633         Reviewed by Chris Fleizach.
2634
2635         Use IAccessibleComparable to compare accessibility objects.
2636         https://bugs.webkit.org/show_bug.cgi?id=49118
2637
2638         * DumpRenderTree/AccessibilityUIElement.cpp:
2639         (AccessibilityUIElement::isEqual):
2640         * DumpRenderTree/AccessibilityUIElement.h:
2641         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2642         (comparableObject):
2643         (AccessibilityUIElement::isEqual):
2644
2645 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2646
2647         Reviewed by David Hyatt.
2648
2649         HTML5 Ruby support should be mandatory feature
2650         https://bugs.webkit.org/show_bug.cgi?id=49272
2651
2652         Remove Ruby as optional feature.
2653
2654         * Scripts/build-webkit:
2655
2656 2010-11-10  Adam Roben  <aroben@apple.com>
2657
2658         Print VC++ Express build logs in the same order that the projects are
2659         built
2660
2661         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2662         in an unhelpful order
2663
2664         Reviewed by Eric Seidel.
2665
2666         * Scripts/print-vse-failure-logs:
2667         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2668         print-msvc-project-dependencies to figure out the order in which
2669         projects are built.
2670         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2671         based on their build order and project name.
2672         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2673         scripts directory from here...
2674         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2675         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2676         them.
2677
2678 2010-11-10  Adam Roben  <aroben@apple.com>
2679
2680         Only print the interesting text from VC++ Express build logs
2681
2682         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2683         output from print-vse-failure-logs
2684
2685         Reviewed by Eric Seidel.
2686
2687         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2688         added newly-required imports. Removed a comment that was essentially a
2689         FIXME, and is now fixed.
2690         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2691         BeautifulSoup to extract the relevant text from the build log.
2692         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2693
2694 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2695
2696         Reviewed by Tony Chang.
2697
2698         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2699         https://bugs.webkit.org/show_bug.cgi?id=49286
2700         
2701         The tests in http/tests/security/XFrameOptions started to fail after
2702         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2703         logic to always assign identifiers to requests, even if we're not going
2704         to be dumping resource load callbacks at that point. These tests
2705         only call LayoutTestController.dumpResourceLoadCallbacks after the
2706         request is started, thus their expectations have "<unknown>" as the
2707         identifier. Change WebViewHost to the previous behavior, which also
2708         match the other ports'.
2709
2710         * DumpRenderTree/chromium/WebViewHost.cpp:
2711         (WebViewHost::assignIdentifierToRequest):
2712         (WebViewHost::removeIdentifierForRequest):
2713
2714 2010-11-08  Tony Chang  <tony@chromium.org>
2715
2716         Reviewed by Adam Barth.
2717
2718         run platform/chromium/plugins/return-npobject.html on all platforms
2719         https://bugs.webkit.org/show_bug.cgi?id=49103
2720
2721         This tests that we can get an NPObject returned through a method on
2722         an NPAPI Object.
2723
2724         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2725         (testCallbackReturn):
2726         (pluginInvoke):
2727
2728 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2729
2730         Unreviewed, rolling out r71672.
2731         http://trac.webkit.org/changeset/71672
2732         https://bugs.webkit.org/show_bug.cgi?id=49276
2733
2734         It doesn't work on Chromium Windows bot (Requested by Ossy on
2735         #webkit).
2736
2737         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2738         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2739         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2740
2741 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2742
2743         Reviewed by Tony Chang.
2744
2745         [NRWT] Make http locking similar to perl implementation
2746         https://bugs.webkit.org/show_bug.cgi?id=49187
2747
2748         * Scripts/webkitpy/common/system/file_lock.py: Added.
2749         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2750         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2751
2752 2010-11-09  James Kozianski  <koz@chromium.org>
2753
2754         Reviewed by Eric Seidel.
2755
2756         Clean up imports for webkit-patch.
2757         https://bugs.webkit.org/show_bug.cgi?id=49083
2758
2759         Move some imports from commands into main.py where they are used.
2760         Move command imports into the __init__ of the commands module.
2761
2762         * Scripts/webkitpy/tool/commands/__init__.py:
2763         * Scripts/webkitpy/tool/commands/download.py:
2764         * Scripts/webkitpy/tool/commands/queues.py:
2765         * Scripts/webkitpy/tool/main.py:
2766
2767 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2768
2769         Reviewed by Andreas Kling.
2770
2771         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2772         https://bugs.webkit.org/show_bug.cgi?id=49047
2773
2774         * QtTestBrowser/mainwindow.cpp:
2775         (MainWindow::setAddressUrl):
2776
2777 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2778
2779         Reviewed by Csaba Osztrogonác.
2780
2781         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2782         https://bugs.webkit.org/show_bug.cgi?id=49252
2783
2784         * Scripts/old-run-webkit-tests:
2785
2786 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2787
2788         Reviewed by Tor Arne Vestbø.
2789
2790         Output of old-run-webkit-tests is buggy in verbose mode
2791         https://bugs.webkit.org/show_bug.cgi?id=49249
2792
2793         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2794
2795 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2796
2797         Reviewed by Martin Robinson.
2798
2799         [GTK] Link with target name set does not work
2800         https://bugs.webkit.org/show_bug.cgi?id=48865
2801
2802         When a new page is created with a name (target=myFrame), the new
2803         mainFrame could not be found because they where not stored in the
2804         same PageGroup. As PageGroup are not exposed externally so the
2805         simpliest solution is to use a global page group name. This also fixes
2806         issue with visited link coloration across pages. After this change the
2807         private function webkit_web_view_set_group_name() was no longer used
2808         so it was removed completly.
2809
2810         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2811         (createWebView):
2812
2813 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2814
2815         Reviewed by Kent Tamura.
2816
2817         WebViewHost::reset() uses placement new.
2818         https://bugs.webkit.org/show_bug.cgi?id=49069
2819
2820         WebViewHost is using placement destruction / new to simulate a fresh
2821         WebViewHost object at the same address. This is because the WebView remains
2822         open across tests and maintains a pointer to the WebViewHost.
2823         This change resets member variables explictly instead of the placement new dance.
2824
2825         * DumpRenderTree/chromium/WebViewHost.cpp:
2826         (WebViewHost::WebViewHost):
2827         (WebViewHost::reset):
2828
2829 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2830
2831         Reviewed by Eric Seidel.
2832
2833         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
2834         It turns out that NRWT can't use the code in scm.find_checkout_root()
2835         because the Chromium bots don't do full checkouts of the WebKit
2836         tree; they only check out subdirectories like WebKitTools/Scripts.
2837         Until we can figure out a better approach for this, I've
2838         restored the base_dir-detecting code from NRWT, which works in
2839         any directory tree, scm or no.
2840
2841         This also restores the files modified in r71475 and r71474.
2842
2843         https://bugs.webkit.org/show_bug.cgi?id=49151
2844
2845         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2846         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2847
2848 2010-11-08  Eric Seidel  <eric@webkit.org>
2849
2850         Reviewed by Adam Barth.
2851
2852         webkit-patch failure-reason explodes if a build is missing
2853         https://bugs.webkit.org/show_bug.cgi?id=49195
2854
2855         This is likely a recent regression.  Adding a unit test for this case.
2856
2857         * Scripts/webkitpy/common/net/buildbot.py:
2858         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2859
2860 2010-11-08  Dan Bernstein  <mitz@apple.com>
2861
2862         Reviewed by Darin Adler.
2863
2864         Ignore the system scrollbar setting.
2865
2866         * DumpRenderTree/mac/DumpRenderTree.mm:
2867         (resetDefaultsToConsistentValues): Set the scrollbar default.
2868
2869 2010-11-05  Adam Roben  <aroben@apple.com>
2870
2871         Make webkitpy.common.system.executive_unittest pass when running under
2872         Win32 Python
2873
2874         Fixes <http://webkit.org/b/49033>.
2875
2876         Reviewed by Dave Levin and Eric Seidel.
2877
2878         * Scripts/webkitpy/common/system/executive.py:
2879         (Executive._run_command_with_teed_output): Pass the arguments through
2880         encode_argument_if_needed rather than using Cygwin-specific code here.
2881         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2882         the output.
2883         (Executive.run_command): Use encode_argument_if_needed to encode the
2884         arguments and child_process_encoding to decode the output.
2885         (Executive._child_process_encoding): Returns the encoding that should be
2886         used when communicating with child processes. On Windows we use mbcs,
2887         which maps to the current code page. On all other platforms we use
2888         UTF-8.
2889         (Executive._should_encode_child_process_arguments): Returns True if
2890         arguments to child processes need to be encoded. This is currently
2891         only needed on Cygwin and Win32 Python 2.x.
2892         (Executive._encode_argument_if_needed): Encode the argument using
2893         child_process_encoding if we need to encode arguments to child
2894         processes on this platform.
2895
2896         * Scripts/webkitpy/common/system/executive_unittest.py:
2897         (never_ending_command): Added. Returns arguments to run a command that
2898         will not quit until we kill it. On Windows we use wmic, on other
2899         platforms we use yes.
2900         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2901         mbcs encoding to be used and for output from the child processes to
2902         have been roundtripped through encode/decode on Win32 Python. When
2903         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2904         it's possible that some characters will not be able to be converted
2905         and will be replaced by question marks; the round-tripping allows us
2906         to expect this result.
2907
2908         (ExecutiveTest.test_kill_process):
2909         (ExecutiveTest.test_kill_all):
2910         Use never_ending_command instead of invoking "yes" directly. Expect an
2911         exit code of 1 when using Win32 Python, as that's what seems to happen.
2912
2913 2010-11-08  Adam Roben  <aroben@apple.com>
2914
2915         Roll out r71532
2916
2917         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2918         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2919
2920         * Scripts/webkitdirs.pm:
2921
2922 2010-11-08  Tony Chang  <tony@chromium.org>
2923
2924         Reviewed by Adam Barth.
2925
2926         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2927         https://bugs.webkit.org/show_bug.cgi?id=49094
2928
2929         This tests that objects created by plugins are proplery cleaned up.
2930
2931         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2932         (testPassTestObject):
2933         (pluginInvoke):
2934         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2935         (testAllocate):
2936         (testDeallocate):
2937         (testGetProperty):
2938         (testConstruct):
2939
2940 2010-11-08  Adam Roben  <aroben@apple.com>
2941
2942         Mark Windows builds triggered from Perl as being non-interactive
2943
2944         This affects whether some of our scripts will show alerts vs. printing
2945         to the build log.
2946
2947         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2948         .vsprops files are updated
2949
2950         Reviewed by Steve Falkenburg.
2951
2952         * Scripts/webkitdirs.pm:
2953         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2954
2955 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2956
2957         Reviewed by Ojan Vafai.
2958
2959         Make http locking default in NRWT.
2960         https://bugs.webkit.org/show_bug.cgi?id=48053
2961
2962         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2963         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2964
2965 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2966
2967         Reviewed by Csaba Osztrogonác.
2968
2969         [NRWT] If the http lock fails we shouldn't do any locking
2970         https://bugs.webkit.org/show_bug.cgi?id=49164
2971
2972         If something goes wrong with the locking, the test should keep going.
2973
2974         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2975
2976 2010-11-08  Adam Roben  <aroben@apple.com>
2977
2978         Switch back to using kCGImageAlphaPremultipliedFirst when generating
2979         pixel dumps on Windows
2980
2981         I changed this behavior in r71418 thinking that it was required for
2982         getting plugins to show up in pixel dumps. But it doesn't seem to be
2983         necessary, and was making it impossible to compare new Windows pixel
2984         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
2985         compare an image with alpha to an image without alpha).
2986
2987         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
2988         new Windows pixel results to existing Windows or Mac results
2989
2990         Reviewed by Antti Koivisto.
2991
2992         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2993         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
2994         with kCGImageAlphaPremultipliedFirst.
2995
2996 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
2997
2998         Unreviewed, rolling out r71466.
2999         http://trac.webkit.org/changeset/71466
3000         https://bugs.webkit.org/show_bug.cgi?id=48865
3001
3002         It broke layout tests on GTK bots.
3003
3004         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3005         (createWebView):
3006
3007 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3008
3009         Reviewed by Csaba Osztrogonác.
3010
3011         Enable running of Qt API tests on BuildBot
3012         https://bugs.webkit.org/show_bug.cgi?id=49004
3013
3014         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3015
3016 2010-11-08  Eric Seidel  <eric@webkit.org>
3017
3018         Reviewed by Adam Barth.
3019
3020         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
3021         https://bugs.webkit.org/show_bug.cgi?id=49160
3022
3023         Bugzilla doesn't automatically remove r? when a bug gets closed.
3024         This script takes care of that for webkit.org.
3025
3026         * Scripts/webkitpy/common/net/bugzilla.py:
3027         * Scripts/webkitpy/tool/commands/upload.py:
3028
3029 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3030
3031         Unreviewed, rolling out r71474.
3032         http://trac.webkit.org/changeset/71474
3033         https://bugs.webkit.org/show_bug.cgi?id=48280
3034
3035         breaks chromium webkit tests
3036         https://bugs.webkit.org/show_bug.cgi?id=49151
3037
3038         * Scripts/webkitpy/layout_tests/port/base.py:
3039         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3040         * Scripts/webkitpy/layout_tests/port/config.py:
3041         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3042         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3043         * Scripts/webkitpy/layout_tests/port/webkit.py:
3044         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3045         * Scripts/webkitpy/tool/mocktool.py:
3046
3047 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3048
3049         Unreviewed, rolling out r71475.
3050         http://trac.webkit.org/changeset/71475
3051  
3052         breaks chromium webkit tests
3053         https://bugs.webkit.org/show_bug.cgi?id=49151
3054
3055         * Scripts/webkitpy/common/newstringio.py: Removed.
3056         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
3057         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
3058         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
3059         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
3060
3061 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3062
3063         Unreviewed, build fix.
3064
3065         Add files inexplicably not committed in r71474 as part of the
3066         fix for bug 48280.
3067
3068         * Scripts/webkitpy/common/newstringio.py: Added.
3069         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3070         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3071         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3072         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
3073
3074 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3075
3076         Reviewed by Eric Siedel.
3077
3078         new-run-webkit-tests: update port/base and port/webkit to use the
3079         new FileSystem and Config abstractions, pulling more logic out of
3080         the base Port classes into separate, mockable objects.
3081
3082         Also create a MockFileSystem object, a MockConfig object, move
3083         MockExecutive into common/system to be next to executive, and
3084         update the config object to use a FileSystem.
3085
3086         https://bugs.webkit.org/show_bug.cgi?id=48280
3087
3088         * Scripts/webkitpy/common/newstringio.py: Added.
3089         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3090         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3091         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3092         * Scripts/webkitpy/layout_tests/port/base.py:
3093         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3094         * Scripts/webkitpy/layout_tests/port/config.py:
3095         * Scripts/webkitpy/layout_tests/port/config_mock.py:
3096         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3097         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3098         * Scripts/webkitpy/layout_tests/port/webkit.py:
3099         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3100         * Scripts/webkitpy/tool/mocktool.py:
3101
3102 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3103
3104         Unreviewed, build breakage.
3105
3106         Apparently I uploaded the wrong version of the file to fix 49122
3107         and neither Eric or I noticed - it was missing a dirname() call.
3108         Fixing ...
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=49122
3111
3112         * Scripts/webkitpy/common/checkout/scm.py:
3113
3114 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3115
3116         Reviewed by Eric Seidel.
3117
3118         webkitpy/tool/* unittests change cwd and don't clean up properly
3119
3120         https://bugs.webkit.org/show_bug.cgi?id=49122
3121
3122         * Scripts/webkitpy/common/checkout/scm.py:
3123
3124 2010-11-05  Chris Marrin  <cmarrin@apple.com>
3125
3126         Reviewed by Simon Fraser.
3127
3128         suspendAnimations/resumeAnimations not present in WebKit2
3129         https://bugs.webkit.org/show_bug.cgi?id=49109
3130
3131         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3132         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3133         (WTR::LayoutTestController::suspendAnimations):
3134         (WTR::LayoutTestController::resumeAnimations):
3135         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3136
3137 2010-11-05  Tony Chang  <tony@chromium.org>
3138
3139         Reviewed by David Levin.
3140
3141         cleanup style in TestNetscapePlugIn/PluginObject.cpp
3142         https://bugs.webkit.org/show_bug.cgi?id=49044
3143
3144         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3145         (getPluginClass):
3146         (pluginGetProperty):
3147         (pluginSetProperty):
3148         (variantToIdentifier):
3149         (testCallback):
3150         (getURL):
3151         (getURLNotify):
3152         (testInvokeDefault):
3153         (testGetProperty):
3154         (testDocumentOpen):
3155         (testWindowOpen):
3156         (pluginInvoke):
3157         (handleCallback):
3158         (notifyStream):
3159         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3160
3161 2010-11-05  Eric Seidel  <eric@webkit.org>
3162
3163         Reviewed by David Levin.
3164
3165         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
3166         https://bugs.webkit.org/show_bug.cgi?id=49032
3167
3168         I wrote this file as part of bug 47847, but I forgot to commit it.
3169         No one else noticed it missing because test-webkitpy knows how
3170         to recover in the case where it can't import QueueStatusServer
3171         (which generally occurs due to not having installed the AppEngine SDK).
3172
3173         * QueueStatusServer/__init__.py: Added.
3174         * QueueStatusServer/model/workitems_unittest.py:
3175          - Remove a test which fails.  This was probably landed (by me)
3176            from my other machine, which since this __init__.py was missing
3177            I never noticed the failure and landed this invalid test.
3178            Sadly we can't really test remove_work_item as it depends
3179            on .key() working.  .key() will throw unless the object
3180            has already been saved it seems.
3181            This may be a mis-design in our remove_work_item implementation,
3182            but for now, just removing the test.
3183
3184 2010-11-04  Adam Roben  <aroben@apple.com>
3185
3186         Teach check-webkit-style about TestNetscapePlugIn
3187
3188         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
3189         TestNetscapePlugIn's coding conventions
3190
3191         Reviewed by John Sullivan.
3192
3193         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3194         WebKitAPITest and TestWebKitAPI in having different include order and
3195         naming conventions than WebCore. Added some comments about why the
3196         exceptions exist.
3197
3198 2010-11-04  Adam Roben  <aroben@apple.com>
3199
3200         Add a test that shows that windowed plugins are able to paint
3201
3202         Somehow we never had a test for this before.
3203
3204         Fixes <http://webkit.org/b/49029> Should add a test that shows
3205         windowed plugins can paint
3206
3207         Reviewed by Jon Honeycutt.
3208
3209         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3210         (DrawsGradient::DrawsGradient):
3211         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3212
3213         (DrawsGradient::onPaint):
3214         (DrawsGradient::onPrintClient):
3215         These both just call through to paint.
3216
3217         (DrawsGradient::paint): Fills our client area with some gradients.
3218
3219         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3220         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3221
3222         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3223         (createBitmapContextFromWebView): Use WM_PRINT instead of
3224         WM_PRINTCLIENT so that ::DefWindowProc will send
3225         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3226         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3227         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3228         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3229         will run on a big-endian platform.
3230
3231 2010-11-04  Adam Roben  <aroben@apple.com>
3232
3233         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3234         WindowedPluginTest base class
3235
3236         The base class takes care of subclassing the plugin's window so that a
3237         custom WNDPROC is called. This will make it easier to write tests that
3238         need to handle window messages.
3239
3240         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3241         a custom WNDPROC
3242
3243         Reviewed by Jon Honeycutt.
3244
3245         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3246         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3247         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3248         (NPNInvalidateRectInvalidatesWindow::wndProc):
3249         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3250         Moved code from here to WindowedPluginTest. Changed to use window()
3251         instead of m_window.
3252
3253         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3254         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3255         include path. Also reordered the include path to make a little more
3256         sense and simplified the entry that added TestNetscapePlugIn itself to
3257         the include path.
3258
3259         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3260         (WindowedPluginTest::WindowedPluginTest):
3261         (WindowedPluginTest::NPP_SetWindow):
3262         (WindowedPluginTest::staticWndProc):
3263         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3264         (WindowedPluginTest::window):
3265         Code came from NPNInvalidateRectInvalidatesWindow.
3266
3267 2010-11-04  Adam Roben  <aroben@apple.com>
3268
3269         Add a plugin test to show that windowed plugins are clipped correctly
3270
3271         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3272         plugins aren't clipped in WebKit2 on Windows
3273
3274         Reviewed by Jon Honeycutt.
3275
3276         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3277         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3278         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3279         region matches the clip rect we know we should have based on
3280         window-region-is-set-to-clip-rect.html, and check that our window class
3281         doesn't have the CS_PARENTDC style.
3282
3283         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3284         Added WindowRegionIsSetToClipRect.
3285
3286 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3287
3288         Reviewed by Martin Robinson.
3289
3290         [GTK] Avoid font hinting in the DRT
3291         https://bugs.webkit.org/show_bug.cgi?id=48548
3292
3293         Change the settings to avoid font hinting, it was causing
3294         different results depending on the distribution.
3295
3296         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3297         (initializeGtkFontSettings):
3298         * DumpRenderTree/gtk/fonts/fonts.conf:
3299
3300 2010-11-05  Eric Seidel  <eric@webkit.org>
3301
3302         Reviewed by Adam Barth.
3303
3304         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3305         https://bugs.webkit.org/show_bug.cgi?id=49051
3306
3307         This is a speculative fix.  The unit tests cover these methods, however
3308         I don't know if this will fully stop the system.log spam.
3309
3310         * Scripts/webkitpy/layout_tests/port/base.py:
3311         * Scripts/webkitpy/layout_tests/port/webkit.py:
3312
3313 2010-11-05  Eric Seidel  <eric@webkit.org>
3314
3315         Reviewed by Adam Barth.
3316
3317         Add basic support for showing bot id on /queue-status/ pages
3318         https://bugs.webkit.org/show_bug.cgi?id=49037
3319
3320         This support is really simple.  Eventually we'll want to
3321         show the bot id in the lock table too, but we don't have
3322         that information stored in the server yet.
3323
3324         * QueueStatusServer/handlers/queuestatus.py:
3325         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3326         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3327
3328 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3329
3330         Reviewed by Adam Barth.
3331
3332         Create a filesystem wrapper that we can use to enforce
3333         particular conventions and use for mocking and dependency
3334         injection down the line.
3335
3336         https://bugs.webkit.org/show_bug.cgi?id=48144
3337
3338         * Scripts/webkitpy/common/system/filesystem.py: Added.
3339         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3340
3341 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3342
3343         Reviewed by Tony Chang.
3344
3345         run_webkit_tests_unittest fails under Python 2.5
3346         https://bugs.webkit.org/show_bug.cgi?id=49043
3347         
3348         Switch from itertools.chain.from_iterable (which was added in 2.6)
3349         to using itertools.chain directly.
3350
3351         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3352
3353 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3354
3355         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3356         Python 2.5 (it needs an import to use the with statement).
3357
3358         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3359
3360 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3361
3362         Reviewed by Adam Barth.
3363
3364         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3365
3366         The current NRWT code has webkit-specific configuration code (like
3367         _script_path, default configuration, etc.) mixed in with
3368         layout-test-specific stuff in port/base. The configuration code
3369         should be split out into a separate module for easier mocking,
3370         testing, and isolation.
3371
3372         https://bugs.webkit.org/show_bug.cgi?id=48264
3373
3374         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3375         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3376
3377 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3378
3379         Reviewed by Tony Chang.
3380
3381         Rebaseline server: initial framework
3382         https://bugs.webkit.org/show_bug.cgi?id=48892
3383         
3384         Adds the basic framework for the rebaseline server (details at 
3385         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
3386         command, which starts an HTTP server that can serve static files or
3387         invoke handler methods on a class.
3388
3389         * Scripts/webkitpy/tool/commands/__init__.py:
3390         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
3391         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
3392         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
3393         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
3394
3395 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3396
3397         Reviewed by James Robinson.
3398
3399         new-run-webkit-tests wasn't using DRT by default for
3400         --platform chromium-gpu
3401
3402         The default value was set to False instead of None, which meant
3403         that the platform specific logic wasn't firing to change the
3404         value to True (b/c we were afraid we'd be overriding the user
3405         preference).
3406
3407         https://bugs.webkit.org/show_bug.cgi?id=49038
3408
3409         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3410
3411 2010-11-04  Tony Chang  <tony@chromium.org>
3412
3413         Reviewed by Adam Barth.
3414
3415         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
3416         https://bugs.webkit.org/show_bug.cgi?id=49026
3417
3418         Have the testObject.bar property return the string "bar".  This lets
3419         us run and pass platform/chromium/plugins/multiple-plugins.html on all
3420         platforms.
3421
3422         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3423         (testGetProperty):
3424
3425 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3426
3427         Reviewed by Tony Chang.
3428
3429         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
3430         https://bugs.webkit.org/show_bug.cgi?id=48878
3431         
3432         Add get_tests_run so that it's easy to see which tests get run (and with
3433         what batching) for a given flag combination. Flesh out the various
3434         test cases that have FIXMEs.
3435         
3436         Also fixes an off-by-one error (batch sizes were one larger than 
3437         expected) and makes --run-part also have wraparound behavior, like
3438         --run-chunk.
3439
3440         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3441         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3442         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3443
3444 2010-11-04  Erik Arvidsson  <arv@chromium.org>
3445
3446         Reviewed by Dimitri Glazkov.
3447
3448         Support box-sizing without the vendor prefix
3449         https://bugs.webkit.org/show_bug.cgi?id=36713
3450
3451         Based on patch by Peter Beverloo <peter@lvp-media.com>
3452
3453         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
3454
3455 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3456
3457         Unreviewed rollout r71340, because it broke Chromium Windows bot.
3458
3459         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3460         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3461
3462 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3463
3464         Reviewed by Ojan Vafai.
3465
3466         Make http locking default in NRWT.
3467         https://bugs.webkit.org/show_bug.cgi?id=48053
3468
3469         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3470         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3471
3472 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3473
3474         Reviewed by Eric Seidel.
3475
3476         [NRWT] Clear invalid http locks on Windows platform as well
3477         https://bugs.webkit.org/show_bug.cgi?id=48515
3478
3479         * Scripts/webkitpy/common/system/executive.py:
3480         * Scripts/webkitpy/common/system/executive_unittest.py:
3481         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3482
3483 2010-11-02  Adam Roben  <aroben@apple.com>
3484
3485         Reduce our dependence on coreutils when running Python tests
3486
3487         This patch introduces versions of the standard echo and cat utilities
3488         implemented in Python. They are probably missing features of their
3489         coreutils equivalents, but they can do what's necessary for our Python
3490         tests. This is useful on Windows, where these utilities typically
3491         aren't available.
3492
3493         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3494         and cat utilities from coreutils, which are not present on Windows
3495
3496         Reviewed by Eric Seidel.
3497
3498         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3499         our Python-based echo and cat.
3500
3501         * Scripts/webkitpy/common/system/fileutils.py: Added.
3502         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3503         that \n won't be translated into \r\n. I couldn't think of a good way
3504         to test this directly without touching the filesystem, but it is tested
3505         indirectly by echo_unittest.
3506
3507         * Scripts/webkitpy/test/cat.py: Added.
3508         (command_arguments): Returns a list for invoking cat with the given arguments.
3509         (main): Acts like a simplified version of the coreutils cat utility.
3510
3511         * Scripts/webkitpy/test/cat_unittest.py: Added.
3512         (CatTest.assert_cat): Runs cat with the given input and ensures the
3513         output matches the input.
3514         (CatTest.test_basic): Performs a simple test of cat.
3515         (CatTest.test_no_newline): Tests what happens when the input string
3516         doesn't have a trailing newline.
3517         (CatTest.test_unicode): Tests passing a unicode string to cat.
3518         (CatTest.test_as_command): Tests running cat as a separate command.
3519
3520         * Scripts/webkitpy/test/echo.py: Added.
3521         (command_arguments): Returns a list for invoking echo with the given arguments.
3522         (main): Acts like a simplified version of the coreutils echo utility.
3523
3524         * Scripts/webkitpy/test/echo_unittest.py: Added.
3525         (EchoTest.test_basic): Performs a simple test of echo.
3526         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3527         trailing newline.
3528         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3529         to echo.
3530         (EchoTest.test_argument_order): Tests what happens when -n is not the
3531         first argument.
3532         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3533         echo.main.
3534         (EchoTest.test_no_arguments): Tests what happens when you call
3535         echo.main with no arguments.
3536         (EchoTest.test_as_command): Tests running echo as a separate command.
3537
3538 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3539
3540         Unreviewed: Add myself to the list of Committers.
3541
3542         * Scripts/webkitpy/common/config/committers.py:
3543
3544 2010-11-04  Andreas Kling  <kling@webkit.org>
3545
3546         Reviewed by Kenneth Rohde Christiansen.
3547
3548         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3549
3550         In RTC mode the QGraphicsWebView item is the size of the contents,
3551         scrolling works a bit differently  (we need to react to scrollRequested.)
3552
3553         Normally QGraphicsView will replay the last mouse event when scrolling,
3554         so to prevent WebKit from getting confused by this we temporarily make
3555         the QGraphicsView non-interactive.
3556
3557         * QtTestBrowser/webview.cpp:
3558         (WebViewGraphicsBased::setPage):
3559         (WebViewGraphicsBased::scrollRequested):
3560         * QtTestBrowser/webview.h:
3561
3562 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3563
3564         Reviewed by Andreas Kling.
3565
3566         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3567
3568         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3569         the Mac-port, not the Mac OS X operating system.
3570
3571         * WebKitTestRunner/qt/TestControllerQt.cpp:
3572         (WTR::isExistingLibrary):
3573
3574 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3575
3576         Reviewed by Andreas Kling.
3577
3578         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3579         https://bugs.webkit.org/show_bug.cgi?id=48869
3580
3581         * QtTestBrowser/useragentlist.txt:
3582
3583 2010-11-03  Adam Roben  <aroben@apple.com>
3584
3585         Always use uppercase drive names in strings returned by abspath_to_uri
3586
3587         Some versions of cygpath use lowercase drive letters while others use
3588         uppercase, which makes it hard to test the output of code that uses
3589         cygpath.
3590
3591         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
3592         fails with Cygwin 1.5
3593
3594         Reviewed by Eric Seidel.
3595
3596         * Scripts/webkitpy/common/system/path.py:
3597         (cygpath): Updated the docstring to indicate that only absolute paths
3598         should be passed for now (though relative paths will work fine).
3599         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
3600
3601 2010-11-03  George Guo  <George.Guo@Nokia.com>
3602
3603         Reviewed by Andreas Kling.
3604
3605         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
3606         https://bugs.webkit.org/show_bug.cgi?id=48767
3607     
3608         Paging is needd on Symbian devices to support benchmarks tests like
3609         dromaeo.com and Celtic Kane that need a lot of memory to run  
3610
3611         * QtTestBrowser/QtTestBrowser.pro:
3612
3613 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
3614
3615         Reviewed by Dmitry Titov.
3616
3617         Chromium: Update resource tracking when moving a frame between documents
3618         https://bugs.webkit.org/show_bug.cgi?id=48363
3619
3620         * DumpRenderTree/chromium/WebViewHost.cpp:
3621         (WebViewHost::assignIdentifierToRequest):
3622         Always put resource id in map so we can make assumptions about its
3623         presence.
3624         (WebViewHost::removeIdentifierForRequest):
3625         Added.
3626         (WebViewHost::didFinishResourceLoad):
3627         (WebViewHost::didFailResourceLoad):
3628         Check existence of resource id before removing from map.
3629         * DumpRenderTree/chromium/WebViewHost.h:
3630
3631 2010-11-03  Victor Wang  <victorw@chromium.org>
3632
3633         Reviewed by Adam Barth.
3634
3635         [Chromium] update buildbot names in chromium rebaseline tool.
3636
3637         https://bugs.webkit.org/show_bug.cgi?id=48881
3638
3639         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3640
3641 2010-11-03  Darin Adler  <darin@apple.com>
3642
3643         Updated Xcode projects by opening them with Xcode 3.2.4.
3644         Updated svn:ignore for Xcode projects.
3645
3646         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
3647         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
3648         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3649         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
3650
3651 2010-11-03  Adam Roben  <aroben@apple.com>
3652
3653         Stop waiting for messages from the web process after a timeout elapses
3654
3655         TestController::runUntil now takes a timeout parameter that specifies
3656         how long to wait for the condition to become true. WebKitTestRunner
3657         takes a --timeout flag that specifies how long the timeout should be.
3658         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
3659         will be similar to run-webkit-tests.
3660