Fix minor problem in sunspider-compare-results which left it broken.
[WebKit.git] / WebKitTools / ChangeLog
1 2009-12-13  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Gavin Barraclaugh.
4
5         Fix minor problem in sunspider-compare-results which left it broken.
6
7         * Scripts/sunspider-compare-results: Declare $parseonly
8
9 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
10
11         Reviewed by Oliver Hunt.
12
13         Give command-line sunspider the ability to handle multiple suites and versions
14         https://bugs.webkit.org/show_bug.cgi?id=32477
15
16         * Scripts/run-sunspider: Updated for changes to command-line parameters.
17         * Scripts/sunspider-compare-results: ditto
18
19 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
20
21         Not reviewed, fixing previous comment.
22
23         Remove accidental change to sunspider-compare-results
24
25         * Scripts/sunspider-compare-results:
26
27 2009-12-11  Yael Aharon  <yael.aharon@nokia.com>
28
29         Unreviewed build fix for Qt versions < 4.6. 
30         Guard every slot individually with #ifdef.
31
32         * DumpRenderTree/qt/EventSenderQt.cpp:
33         (EventSender::addTouchPoint):
34         (EventSender::updateTouchPoint):
35         (EventSender::touchStart):
36         (EventSender::touchMove):
37         (EventSender::touchEnd):
38         (EventSender::clearTouchPoints):
39         (EventSender::releaseTouchPoint):
40         (EventSender::sendTouchEvent):
41         * DumpRenderTree/qt/EventSenderQt.h:
42
43 2009-12-11  Eric Seidel  <eric@webkit.org>
44
45         Reviewed by Adam Barth.
46
47         CommandsTest.assert_execute_outputs doesn't check stderr
48         https://bugs.webkit.org/show_bug.cgi?id=32352
49
50         Fix assert_execute_outputs to check stderr
51         and then fix all the unit tests which needed to
52         pass stderr output.
53
54         * Scripts/modules/commands/commandtest.py:
55         * Scripts/modules/commands/download_unittest.py:
56         * Scripts/modules/commands/upload_unittest.py:
57
58 2009-12-11  Adam Barth  <abarth@webkit.org>
59
60         Reviewed by Eric Seidel.
61
62         [check-webkit-style] False positive for tst_QWebFrame
63         https://bugs.webkit.org/show_bug.cgi?id=32436
64
65         Add an exception for function names that start with "tst_".  These are
66         used by the Qt unit testing framework.
67
68         * Scripts/modules/cpp_style.py:
69         * Scripts/modules/cpp_style_unittest.py:
70
71 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
72
73         Reviewed by Antti Koivisto.
74
75         Added support for creating synthetic touch events with EventSender
76         in Qt's DumpRenderTree.
77
78         https://bugs.webkit.org/show_bug.cgi?id=32114
79
80         * DumpRenderTree/qt/EventSenderQt.cpp:
81         (EventSender::addTouchPoint):
82         (EventSender::updateTouchPoint):
83         (EventSender::touchStart):
84         (EventSender::touchMove):
85         (EventSender::touchEnd):
86         (EventSender::clearTouchPoints):
87         (EventSender::releaseTouchPoint):
88         (EventSender::sendTouchEvent):
89         * DumpRenderTree/qt/EventSenderQt.h:
90
91 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
92
93         Reviewed by Darin Adler.
94
95         The values of RuntimeArray are not enumerable
96         https://bugs.webkit.org/show_bug.cgi?id=29005
97
98         * DumpRenderTree/mac/ObjCController.m:
99         (+[ObjCController isSelectorExcludedFromWebScript:]):
100         (+[ObjCController webScriptNameForSelector:]):
101         (-[ObjCController arrayOfString]):
102
103 2009-12-10  Eric Seidel  <eric@webkit.org>
104
105         No review, just updating unit tests to match recent checkins.
106
107         * Scripts/modules/mock_bugzillatool.py:
108          - Add missing red_core_builders_names method causing exception.
109         * Scripts/modules/workqueue_unittest.py:
110          - processutils is dead, use executive.py instead.
111
112 2009-12-10  Eric Seidel  <eric@webkit.org>
113
114         Reviewed by Adam Barth.
115
116         Move run_command onto Executive to make code which uses run_command testable
117         https://bugs.webkit.org/show_bug.cgi?id=32396
118
119         * Scripts/modules/executive.py:
120          - Move run_command and error handlers onto Executive.
121         * Scripts/modules/scm.py:
122         * Scripts/modules/scm_unittest.py:
123
124 2009-12-09  Eric Seidel  <eric@webkit.org>
125
126         Reviewed by Adam Barth.
127
128         bugzilla-tool needs a command to list patches needing cq+
129         https://bugs.webkit.org/show_bug.cgi?id=32351
130
131         * Scripts/modules/bugzilla.py:
132          - Parse attacher_email from attachment xml.
133         * Scripts/modules/bugzilla_unittest.py:
134          - Test new attacher_email parsing.
135         * Scripts/modules/commands/queries.py:
136          - Add PatchesToCommitQueue
137         * Scripts/modules/commands/queries_unittest.py:
138          - Tests for PatchesToCommitQueue
139         * Scripts/modules/mock_bugzillatool.py:
140          - Add necessary mock methods for running PatchesToCommitQueue
141
142 2009-12-10  Adam Barth  <abarth@webkit.org>
143
144         Unreviewed.  Turns out every StepSequence command needs a --quiet
145         option.
146
147         * Scripts/modules/stepsequence.py:
148
149 2009-12-10  Eric Z. Ayers  <zundel@google.com>
150
151         Reviewed by Pavel Feldman.
152
153         Implements displayWebView() to force an invalidation and repaint.
154         This fixes a problem running the timeline-paint.html unit test.
155
156         https://bugs.webkit.org/show_bug.cgi?id=31729
157
158         * DumpRenderTree/gtk/DumpRenderTree.cpp:
159         (displayWebView):
160
161 2009-12-10  Adam Barth  <abarth@webkit.org>
162
163         Reviewed by Eric Seidel.
164
165         [bzt] Convert more commands to StepSequences
166         https://bugs.webkit.org/show_bug.cgi?id=32362
167
168         We should eventually convert all the commands, but I'm starting with
169         the easy ones.
170
171         * Scripts/modules/commands/download.py:
172
173 2009-12-10  Xan Lopez  <xlopez@igalia.com>
174
175         Reviewed by Jan Alonzo.
176
177         [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
178         https://bugs.webkit.org/show_bug.cgi?id=31103
179
180         Give focus to the webviews when we create them, since some tests expect this.
181
182         * DumpRenderTree/gtk/DumpRenderTree.cpp:
183         (main):
184
185 2009-12-10  Eric Seidel  <eric@webkit.org>
186
187         Reviewed by Adam Barth.
188
189         bugzilla-tool "builders are red" error should tell you which builders
190         https://bugs.webkit.org/show_bug.cgi?id=32211
191
192         * Scripts/modules/buildsteps.py:
193
194 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
195
196         Reviewed by Adam Roben.
197
198         Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
199         Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
200         in Windows as part of running update_webkit.
201
202         * Scripts/update-webkit:
203          - Run setupAppleWinEnv() on Apple's Windows port.
204         * Scripts/webkitdirs.pm:
205          - Added functions that return the source directory, libraries directory and default build directory on Windows.
206          - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
207          - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir
208            and Cygwin to their desired values.
209
210 2009-12-09  Adam Barth  <abarth@webkit.org>
211
212         Reviewed by Eric Seidel.
213
214         exception thrown when running apply-patches
215         https://bugs.webkit.org/show_bug.cgi?id=32344
216
217         The update step now takes a port option.  Once we finish the Steps
218         refactoring, we won't have to worry about this kind of bug again.
219
220         * Scripts/modules/commands/download.py:
221
222 2009-12-09  Adam Barth  <abarth@webkit.org>
223
224         Unreviewed.  Fix ScriptError includes.  I don't understand why these
225         didn't throw during unit testing...
226
227         * Scripts/modules/commands/download.py:
228         * Scripts/modules/logging_unittest.py:
229         * Scripts/modules/workqueue.py:
230
231 2009-12-09  Adam Barth  <abarth@webkit.org>
232
233         Reviewed by Eric Seidel.
234
235         [bzt] Remove unused PatchCollection class
236         https://bugs.webkit.org/show_bug.cgi?id=32312
237
238         It's dead code.
239
240         * Scripts/modules/patchcollection.py:
241         * Scripts/modules/patchcollection_unittest.py: Removed.
242
243 2009-12-09  Adam Barth  <abarth@webkit.org>
244
245         Unreviewed "build" fix.  CheckStyle needs a --no-upate option.
246
247         * Scripts/modules/commands/download.py:
248
249 2009-12-09  Adam Barth  <abarth@webkit.org>
250
251         Reviewed by Eric Seidel.
252
253         [bzt] Convert Build to use Sequence
254         https://bugs.webkit.org/show_bug.cgi?id=32310
255
256         So much prettier.
257
258         * Scripts/modules/buildsteps.py:
259         * Scripts/modules/commands/download.py:
260         * Scripts/modules/landingsequence.py:
261         * Scripts/modules/stepsequence.py: Added.
262
263 2009-12-09  Adam Barth  <abarth@webkit.org>
264
265         Add missing file.
266
267         * Scripts/modules/executive.py: Added.
268
269 2009-12-09  Adam Barth  <abarth@webkit.org>
270
271         Unreviewed "build" fix.
272
273         * Scripts/modules/landingsequence.py:
274
275 2009-12-09  Adam Barth  <abarth@webkit.org>
276
277         Reviewed by Eric Seidel.
278
279         [bzt] Implement abstract Steps
280         https://bugs.webkit.org/show_bug.cgi?id=32212
281
282         This is a fairly disruptive change that refactors how we build
283         commands.  Instead of using a landing sequence, we can now assemble a
284         sequence of steps directly.  We still use the landing sequence in the
285         interim, but this will be removed soon.
286
287         * Scripts/bugzilla-tool:
288         * Scripts/modules/buildsteps.py:
289         * Scripts/modules/commands/download.py:
290         * Scripts/modules/commands/early_warning_system.py:
291         * Scripts/modules/commands/queues.py:
292         * Scripts/modules/commands/queues_unittest.py:
293         * Scripts/modules/landingsequence.py:
294         * Scripts/modules/mock_bugzillatool.py:
295         * Scripts/modules/processutils.py: Removed.
296         * Scripts/modules/scm.py:
297         * Scripts/modules/scm_unittest.py:
298         * Scripts/modules/webkitport.py:
299
300 2009-12-08  Eric Seidel  <eric@webkit.org>
301
302         Reviewed by Adam Barth.
303
304         run_command and ScriptError should move into processutils.py
305         https://bugs.webkit.org/show_bug.cgi?id=32305
306
307         Turns out there are a zillion callers to run_command.
308
309         * Scripts/modules/commands/download.py:
310         * Scripts/modules/commands/early_warning_system.py:
311         * Scripts/modules/commands/queues.py:
312         * Scripts/modules/landingsequence.py:
313         * Scripts/modules/logging_unittest.py:
314         * Scripts/modules/processutils.py:
315         * Scripts/modules/scm.py:
316         * Scripts/modules/scm_unittest.py:
317         * Scripts/modules/workqueue.py:
318         * Scripts/modules/workqueue_unittest.py:
319
320 2009-12-08  Kevin Watters  <kevinwatters@gmail.com>
321
322         Reviewed by Kevin Ollivier.
323
324         [wx] Mac plugins support.
325         
326         https://bugs.webkit.org/show_bug.cgi?id=32236
327
328         * wx/browser/wscript:
329
330 2009-12-08  David Levin  <levin@chromium.org>
331
332         Reviewed by Adam Barth.
333
334         [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
335         https://bugs.webkit.org/show_bug.cgi?id=32193
336
337         * Scripts/modules/cpp_style.py: For the function { rule, if there is space
338           at the beginning of line, ignore lines which then have a macro.
339         * Scripts/modules/cpp_style_unittest.py: Add tests to verify the
340           new behavior.
341
342 2009-12-08  Dmitry Titov  <dimich@chromium.org>
343
344         Rubber-stamped by David Levin.
345
346         Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
347         It may have caused massive increase of reported leaks on the bots.
348         https://bugs.webkit.org/show_bug.cgi?id=31639
349
350         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
351
352 2009-12-08  Dmitry Titov  <dimich@chromium.org>
353
354         Reviewed by Darin Adler.
355
356         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
357         https://bugs.webkit.org/show_bug.cgi?id=31639
358
359         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
360
361 2009-12-08  David Levin  <levin@chromium.org>
362
363         Reviewed by Adam Barth.
364
365         [check-webkit-style] False positive for camel case of JSC op codes
366         https://bugs.webkit.org/show_bug.cgi?id=32192
367
368         * Scripts/modules/cpp_style.py: Added an exception for the JSC op
369           code functions and const_iterator as well since I noticed a false
370           positive there when testing the fix.
371         * Scripts/modules/cpp_style_unittest.py: Added tests for these
372           changes.
373
374 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
375
376         Rubber-stamped by Maciej Stachowiak.
377
378         Turn on (SVG) Filters for Win.
379         https://bugs.webkit.org/show_bug.cgi?id=32224
380
381         * Scripts/webkitdirs.pm:
382
383 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
384
385         Rubber-stamped by Maciej Stachowiak.
386
387         Turn on (SVG) Filters for Gtk.
388         https://bugs.webkit.org/show_bug.cgi?id=32224
389
390         * Scripts/build-webkit:
391
392 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
393
394         Reviewed by David Levin.
395
396         [check-webkit-style] S_OK is a fine identifier
397         https://bugs.webkit.org/show_bug.cgi?id=32225
398
399         * Scripts/modules/cpp_style.py:
400         * Scripts/modules/cpp_style_unittest.py:
401
402 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
403
404         Rubber-stamped by Maciej Stachowiak.
405
406         Turn on (SVG) Filters for Qt.
407         https://bugs.webkit.org/show_bug.cgi?id=32224
408
409         * Scripts/build-webkit:
410
411 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
412
413         Reviewed by Alexey Proskuryakov.
414
415         Make run-webkit-websocketserver log to stderr rather than to a file.
416         https://bugs.webkit.org/show_bug.cgi?id=32234
417
418         * Scripts/run-webkit-websocketserver:
419
420 2009-12-07  Dmitry Titov  <dimich@chromium.org>
421
422         Rubber-stamped by Darin Adler.
423
424         Remove ENABLE_SHARED_SCRIPT flags
425         https://bugs.webkit.org/show_bug.cgi?id=32245
426         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
427
428         * Scripts/build-webkit:
429
430 2009-12-07  Simon Fraser  <simon.fraser@apple.com>
431
432         Reviewed by Darin Adler.
433
434         <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
435
436         The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
437         accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
438         This caused one compositing test make DumpRenderTree think that all subsequent tests
439         were compositing too.
440
441         Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
442         notification informs the client that a WebHTMLView entered compositing mode (or an already-
443         compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
444         compositing subviews were removed, since this is tricky to get right.
445         
446         DumpRenderTreeWindow listens for this notification, and uses it to turn on window
447         autodisplay, which is necessary to kick-start Core Animation rendering and animations.
448         We ensure that window autodisplay is turned off before every test.
449
450         * DumpRenderTree/mac/DumpRenderTree.mm:
451         (createWebViewAndOffscreenWindow):
452         (resetWebViewToConsistentStateBeforeTesting):
453         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
454         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
455         (-[DumpRenderTreeWindow close]):
456         (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]):
457         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
458
459 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
460
461         Reviewed by Holger Hans Peter Freyther.
462
463         Turn on (SVG) Filters support, by default.
464         https://bugs.webkit.org/show_bug.cgi?id=32224
465
466         For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon.
467
468         * Scripts/build-webkit:
469
470 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
471
472         Reviewed by Darin Fisher.
473
474         Chromium buildbots are not red when they fail
475         https://bugs.webkit.org/show_bug.cgi?id=32235
476
477         * Scripts/build-webkit:
478
479 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
480
481         Reviewed by Darin Fisher.
482
483         Typo in chromium linux builder
484         https://bugs.webkit.org/show_bug.cgi?id=32238
485
486         * Scripts/webkitdirs.pm:
487
488 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
489
490         Reviewed by Darin Fisher.
491
492         fixes to build-webkit --chromium
493         https://bugs.webkit.org/show_bug.cgi?id=32179
494
495         * Scripts/webkitdirs.pm:
496
497 2009-12-07  Eric Seidel  <eric@webkit.org>
498
499         No review, just adding two recently approved committers.
500
501         * Scripts/modules/committers.py:
502
503 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
504
505         * Scripts/run-webkit-websocketserver: Added property svn:executable.
506
507 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
508
509         Reviewed by Alexey Proskuryakov.
510
511         Add run-webkit-websocketserver
512
513         https://bugs.webkit.org/show_bug.cgi?id=31390
514
515         * Scripts/run-webkit-websocketserver: Added.
516
517 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
518
519         Build fix. Be flexible about which version of ICU is used on Windows.
520
521         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
522
523 2009-12-07  Dirk Schulze  <krit@webkit.org>
524
525         Not reviewed, adding myself to the reviewers list.
526
527         * Scripts/modules/committers.py:
528
529 2009-12-06  Eric Seidel  <eric@webkit.org>
530
531         Reviewed by Adam Barth.
532
533         Add an API for uploading results files to StatusBot
534         https://bugs.webkit.org/show_bug.cgi?id=32210
535
536         Add Content-Type: plain/text which was forgotten
537         from the previous commit when I landed with land-patches
538         instead of land-diff.
539
540         * QueueStatusServer/queue_status.py:
541
542 2009-12-06  Eric Seidel  <eric@webkit.org>
543
544         Reviewed by Adam Barth.
545
546         Status Server needs a way to handle uploaded results
547         https://bugs.webkit.org/show_bug.cgi?id=32209
548
549         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
550         * QueueStatusServer/update_status.html: Add file upload.
551
552 2009-12-06  Eric Seidel  <eric@webkit.org>
553
554         Reviewed by Adam Barth.
555
556         Add an API for uploading results files to StatusBot
557         https://bugs.webkit.org/show_bug.cgi?id=32210
558
559         * Scripts/modules/statusbot.py:
560
561 2009-12-06  Eric Seidel  <eric@webkit.org>
562
563         Reviewed by Adam Barth.
564
565         Status Server needs a way to handle uploaded results
566         https://bugs.webkit.org/show_bug.cgi?id=32209
567
568         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
569         * QueueStatusServer/update_status.html: Add file upload.
570
571 2009-12-06  Adam Barth  <abarth@webkit.org>
572
573         Reviewed by Eric Seidel.
574
575         [bzt] BuildAttachment should not check the builders
576         https://bugs.webkit.org/show_bug.cgi?id=32207
577
578         This is code that got copied here by accident when the class was created.
579
580         * Scripts/modules/commands/download.py:
581
582 2009-12-06  Adam Barth  <abarth@webkit.org>
583
584         Reviewed by Eric Seidel.
585
586         [bzt] Make LandingSequence.update aware of ports
587         https://bugs.webkit.org/show_bug.cgi?id=32208
588
589         This is required to make build work on the Chromium port because
590         Chromium has a custom update-webkit.
591
592         * Scripts/modules/landingsequence.py:
593
594 2009-12-06  Adam Barth  <abarth@webkit.org>
595
596         Reviewed by Eric Seidel.
597
598         Add early warning system commands to bugzilla-tool.
599
600         * Scripts/bugzilla-tool:
601         * Scripts/modules/landingsequence.py:
602         * Scripts/modules/webkitport.py:
603
604 2009-12-06  Adam Barth  <abarth@webkit.org>
605
606         Reviewed by Eric Seidel.
607
608         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
609         https://bugs.webkit.org/show_bug.cgi?id=32205
610
611         * Scripts/modules/commands/early_warning_system.py: Added.
612         * Scripts/modules/commands/queues.py:
613
614 2009-12-06  Dan Bernstein  <mitz@apple.com>
615
616         Reviewed by Adele Peterson.
617
618         REGRESSION (r51728): update-webkit fails when the current directory is
619         not inside a Subversion working copy
620         https://bugs.webkit.org/show_bug.cgi?id=32204
621
622         * Scripts/update-webkit: Invoke isSVN() in the correct working
623         directory.
624
625 2009-12-06  Adam Barth  <abarth@webkit.org>
626
627         Reviewed by Eric Seidel.
628
629         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
630         https://bugs.webkit.org/show_bug.cgi?id=32202
631
632         * Scripts/modules/commands/queues.py:
633
634 2009-12-05  Adam Barth  <abarth@webkit.org>
635
636         Reviewed by Eric Seidel.
637
638         [bzt] Implement ChromiumPort
639         https://bugs.webkit.org/show_bug.cgi?id=32182
640
641         * Scripts/modules/webkitport.py:
642         * Scripts/modules/webkitport_unittest.py:
643
644 2009-12-05  Adam Barth  <abarth@webkit.org>
645
646         Reviewed by Eric Seidel.
647
648         Move update-webkit into BuildSteps
649         https://bugs.webkit.org/show_bug.cgi?id=32181
650
651         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
652         that WebKit exists.  The proper place for the knowledge of the existence of
653         update-webkit is in WebKitPort because some ports have specialized update
654         scripts (analogous to build-webkit).
655
656         * Scripts/modules/buildsteps.py:
657         * Scripts/modules/commands/download.py:
658         * Scripts/modules/landingsequence.py:
659         * Scripts/modules/scm.py:
660         * Scripts/modules/webkitport.py:
661
662 2009-12-05  Adam Barth  <abarth@webkit.org>
663
664         Reviewed by Eric Seidel.
665
666         update-webkit should call git svn rebase and resolve-ChangeLogs -f
667         https://bugs.webkit.org/show_bug.cgi?id=27162
668
669         Teach update-webkit about Git.  I didn't add the call to
670         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
671         can iterate from here, however.
672
673         * Scripts/update-webkit:
674
675 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
676
677         Unreviewed build fix.
678
679         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
680
681         * DumpRenderTree/qt/DumpRenderTree.cpp:
682
683 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
684
685         Reviewed by Adam Treat.
686
687         Add some missing methods for showing and hiding the
688         Web Inspector.
689
690         * DumpRenderTree/qt/DumpRenderTree.cpp:
691         (WebCore::WebPage::WebPage):
692         (WebCore::WebPage::~WebPage):
693         (WebCore::WebPage::webInspector):
694         * DumpRenderTree/qt/DumpRenderTree.h:
695         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
696         (LayoutTestController::showWebInspector):
697         (LayoutTestController::hideWebInspector):
698         * DumpRenderTree/qt/LayoutTestControllerQt.h:
699
700 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
701
702         Reviewed by Adam Treat.
703
704         Implement the setAllowUniversalAccessFromFileURLs method
705         for the Qt LayoutTestController.
706
707         * DumpRenderTree/qt/DumpRenderTree.cpp:
708         (WebCore::WebPage::resetSettings):
709         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
710         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
711         * DumpRenderTree/qt/LayoutTestControllerQt.h:
712
713 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
714
715         Reviewed by Darin Adler.
716
717         REGRESSION: AX: buttons now extremely repetitive
718         https://bugs.webkit.org/show_bug.cgi?id=32164
719
720         * DumpRenderTree/AccessibilityUIElement.cpp:
721         (isAttributeSupportedCallback):
722         (AccessibilityUIElement::getJSClass):
723         * DumpRenderTree/AccessibilityUIElement.h:
724         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
725         (AccessibilityUIElement::isAttributeSupported):
726         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
727         (AccessibilityUIElement::isAttributeSupported):
728         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
729         (AccessibilityUIElement::isAttributeSupported):
730
731 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
732
733         Reviewed by David Levin.
734
735         check-webkit-style should check for camelCase variable names
736         https://bugs.webkit.org/show_bug.cgi?id=32051
737
738         * Scripts/modules/cpp_style.py:
739         * Scripts/modules/cpp_style_unittest.py:
740
741 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
742
743         Reviewed by Eric Seidel.
744
745         AX: VO just says "term" on many web sites
746         https://bugs.webkit.org/show_bug.cgi?id=32139
747
748         * DumpRenderTree/AccessibilityUIElement.cpp:
749         (getRoleDescriptionCallback):
750         (AccessibilityUIElement::getJSClass):
751         * DumpRenderTree/AccessibilityUIElement.h:
752         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
753         (AccessibilityUIElement::roleDescription):
754         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
755         (AccessibilityUIElement::roleDescription):
756         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
757         (AccessibilityUIElement::roleDescription):
758
759 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
760
761         Reviewed by Beth Dakin.
762
763         Implement WAI-ARIA scrollbar role and related property aria-orientation
764         https://bugs.webkit.org/show_bug.cgi?id=32126
765
766         * DumpRenderTree/AccessibilityUIElement.cpp:
767         (getOrientationCallback):
768         (AccessibilityUIElement::getJSClass):
769         * DumpRenderTree/AccessibilityUIElement.h:
770         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
771         (AccessibilityUIElement::orientation):
772         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
773         (AccessibilityUIElement::orientation):
774         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
775         (AccessibilityUIElement::orientation):
776
777 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
778
779         Reviewed by Adam Roben.
780
781         Minor correction to r51663.
782
783         * DumpRenderTree/win/DumpRenderTree.cpp:
784         (addQTDirToPATH):
785             GetEnvironmentVariable -> GetEnvironmentVariableW.
786
787 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
788
789         Reviewed by Adam Roben.
790
791         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
792         https://bugs.webkit.org/show_bug.cgi?id=30256
793
794         Add the QuickTime dll directory to the PATH environment variable so
795         inialization can succeed.
796
797         * DumpRenderTree/win/DumpRenderTree.cpp:
798         (addQTDirToPATH):
799         (initialize):
800
801 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
802
803         Reviewed by Kenneth Rohde Christiansen.
804
805         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
806
807         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
808         (LayoutTestController::maybeDump):
809
810 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
811
812         Reviewed by Eric Seidel.
813
814         Update pywebsocket to 0.4.3
815         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
816         Stack trace is logged now in INFO level.
817         https://bugs.webkit.org/show_bug.cgi?id=32097
818
819         * pywebsocket/mod_pywebsocket/dispatch.py:
820         * pywebsocket/mod_pywebsocket/msgutil.py:
821         * pywebsocket/mod_pywebsocket/standalone.py:
822         * pywebsocket/mod_pywebsocket/util.py:
823         * pywebsocket/setup.py:
824         * pywebsocket/test/test_dispatch.py:
825         * pywebsocket/test/test_util.py:
826
827 2009-12-03  Sam Weinig  <sam@webkit.org>
828
829         Reviewed by Gavin Barraclough.
830
831         Fix JSClassRef leak.
832
833         * DumpRenderTree/AccessibilityController.cpp:
834         (AccessibilityController::makeWindowObject):
835         * DumpRenderTree/GCController.cpp:
836         (GCController::makeWindowObject):
837         * DumpRenderTree/LayoutTestController.cpp:
838         (LayoutTestController::makeWindowObject):
839
840 2009-12-03  Brady Eidson  <beidson@apple.com>
841
842         Reviewed by Sam Weinig.
843
844         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
845
846         Keep DRT-win building...
847
848         * DumpRenderTree/win/FrameLoadDelegate.h:
849         (FrameLoadDelegate::didPushStateWithinPageForFrame):
850         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
851         (FrameLoadDelegate::didPopStateWithinPageForFrame):
852
853 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
854
855         Unreviewed build fix.
856
857         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
858
859         * DumpRenderTree/qt/DumpRenderTree.cpp:
860
861 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
862
863         Reviewed by Kenneth Rohde Christiansen.
864
865         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
866         Prevent DRT from showing the main view if these childs get deleted.
867         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
868
869         * DumpRenderTree/qt/DumpRenderTree.cpp:
870         (WebCore::WebPage::WebPage):
871         (WebCore::DumpRenderTree::DumpRenderTree):
872         (WebCore::DumpRenderTree::~DumpRenderTree):
873         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
874         (WebCore::DumpRenderTree::open):
875         (WebCore::DumpRenderTree::closeRemainingWindows):
876         (WebCore::DumpRenderTree::createWindow):
877         (WebCore::DumpRenderTree::windowCount):
878         * DumpRenderTree/qt/DumpRenderTree.h:
879
880 2009-12-02  Eric Seidel  <eric@webkit.org>
881
882         Reviewed by Adam Barth.
883
884         REGRESSION(51595): commit-queue is throwing exceptions
885         https://bugs.webkit.org/show_bug.cgi?id=32083
886
887         * Scripts/modules/commands/queues.py:
888          - Don't use default value of [] as it ends up getting shared.
889          - Make log_progress accept arrays of ints as well as strings.
890          - Return an exit code from execute()
891         * Scripts/modules/commands/queues_unittest.py: Added.
892          - Test to make sure log_progress will accept ints.
893          - Test to make sure run_bugzilla_tool will accept ints.
894         * Scripts/modules/workqueue.py:
895          - Print the stack trace on unexpected exceptions for easier debugging.
896         * Scripts/run-webkit-unittests:
897          - Add queues_unittest.
898
899         * Scripts/modules/commands/queues.py:
900         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
901         * Scripts/modules/mock_bugzillatool.py:
902         * Scripts/modules/workqueue.py:
903         * Scripts/run-webkit-unittests:
904
905 2009-12-02  David Levin  <levin@chromium.org>
906
907         Reviewed by Adam Barth.
908
909         check-webkit-style is too noisy about namespace indenting issues.
910         https://bugs.webkit.org/show_bug.cgi?id=32096
911
912         * Scripts/modules/cpp_style.py:
913         Added a _FileState object to be able to track file level information. In this
914         case, it simply tracks whether the error has already been given, so that it isn't
915         done again.
916         * Scripts/modules/cpp_style_unittest.py:
917         Modified test cases to pass in the _FileState object and fix a test that expected
918         to see the namespace error twice (now it only occurs once). No new tests because
919         existing tests cover the change in functionality.
920
921 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
922
923         Reviewed by Eric Seidel.
924
925         [wx] Get DumpRenderTree building after waf switch.
926         
927         https://bugs.webkit.org/show_bug.cgi?id=32041
928
929         * DumpRenderTree/wscript: Added.
930         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
931         (LayoutTestController::setTimelineProfilingEnabled):
932         (LayoutTestController::evaluateScriptInIsolatedWorld):
933         (LayoutTestController::disableImageLoading):
934         (LayoutTestController::whiteListAccessFromOrigin):
935         (LayoutTestController::counterValueForElementById):
936         * Scripts/build-webkit:
937
938 2009-12-02  Adam Barth  <abarth@webkit.org>
939
940         Reviewed by Eric Seidel.
941
942         [bzt] build-attachment shouldn't check whether the builders are red
943         https://bugs.webkit.org/show_bug.cgi?id=32062
944
945         build-attachment doesn't touch the remote repository, so there isn't a
946         need to hold off when the builders are red.
947
948         * Scripts/modules/commands/download.py:
949         * Scripts/modules/landingsequence.py:
950
951 2009-12-02  Eric Seidel  <eric@webkit.org>
952
953         Reviewed by Adam Barth.
954
955         REGRESSION(51590): style-queue and build-queue think their empty when they are not
956         https://bugs.webkit.org/show_bug.cgi?id=32061
957
958         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
959         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
960
961 2009-12-02  Eric Seidel  <eric@webkit.org>
962
963         Reviewed by Adam Barth.
964
965         build-queue is throwing exceptions and complaining about
966         lack of --no-update on build-attachment.  Make it stop.
967
968         * Scripts/modules/buildsteps.py:
969         * Scripts/modules/commands/download.py:
970
971 2009-12-02  Adam Barth  <abarth@webkit.org>
972
973         Unreviewed "build" fix.  Forgot to declare my variables.  :(
974
975         * QueueStatusServer/queue_status.py:
976
977 2009-12-02  Adam Barth  <abarth@webkit.org>
978
979         Reviewed by Eric Seidel.
980
981         [bzt] Implement status bubble view
982         https://bugs.webkit.org/show_bug.cgi?id=32057
983
984         The status bubble is a compact representation of the queue status for a
985         given patch.  This will eventually help us reduce the comment spam from
986         the queues.
987
988         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
989         * QueueStatusServer/queue_status.py:
990         * QueueStatusServer/status_bubble.html: Added.
991
992 2009-12-02  Eric Seidel  <eric@webkit.org>
993
994         Reviewed by Adam Barth.
995
996         trim commands/*.py includes now that commands are unit tested
997         https://bugs.webkit.org/show_bug.cgi?id=32056
998
999         In the course of ensuring that the unit tests still
1000         passed after this change, I had to actually make them
1001         pass in the first place.
1002
1003         * Scripts/modules/bugzilla.py:
1004          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
1005         * Scripts/modules/commands/download.py: Remove unneeded imports.
1006         * Scripts/modules/commands/queries.py: Ditto.
1007         * Scripts/modules/commands/queues.py: Ditto.
1008         * Scripts/modules/commands/upload.py: Ditto.
1009         * Scripts/modules/scm_unittest.py:
1010          - Fix to expect the \n after the path since echo adds an \n.
1011
1012 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
1013
1014         build-webkit: Remove flex,bison,gperf check for chromium
1015         https://bugs.webkit.org/show_bug.cgi?id=32043
1016
1017         * Scripts/webkitdirs.pm:
1018
1019 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1020
1021         Build fixage for Windows/GTK for DumpRenderTree.
1022
1023         WAI-ARIA: implement support for ARIA drag and drop
1024         https://bugs.webkit.org/show_bug.cgi?id=32007
1025
1026         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1027         (AccessibilityUIElement::ariaIsGrabbed):
1028         (AccessibilityUIElement::ariaDropEffects):
1029         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1030         (AccessibilityUIElement::ariaIsGrabbed):
1031         (AccessibilityUIElement::ariaDropEffects):
1032
1033 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1034
1035         Reviewed by Darin Adler.
1036
1037         WAI-ARIA: implement support for ARIA drag and drop
1038         https://bugs.webkit.org/show_bug.cgi?id=32007
1039
1040         * DumpRenderTree/AccessibilityUIElement.cpp:
1041         (getARIADropEffectsCallback):
1042         (getARIAIsGrabbedCallback):
1043         (AccessibilityUIElement::getJSClass):
1044         * DumpRenderTree/AccessibilityUIElement.h:
1045         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1046         (AccessibilityUIElement::ariaIsGrabbed):
1047         (AccessibilityUIElement::ariaDropEffects):
1048
1049 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1050
1051         Not reviewed. GTK DRT try 2.
1052
1053         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1054         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1055
1056 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1057
1058         Not reviewed. Try to fix gtk DRT build.
1059
1060         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1061
1062 2009-12-01  David Levin  <levin@chromium.org>
1063
1064         Reviewed by Eric Seidel.
1065
1066         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
1067         https://bugs.webkit.org/show_bug.cgi?id=32033
1068
1069         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
1070                                         instead of startswith.
1071         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
1072
1073 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1074
1075         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
1076
1077         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
1078
1079 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1080
1081         Reviewed by Simon Fraser.
1082
1083         Add SVG animation test framework with 'snapshot' functionality
1084         https://bugs.webkit.org/show_bug.cgi?id=31897
1085
1086         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
1087         used by the new SVG animation testing framework, implemented
1088         for qt/gtk/win/mac.
1089
1090         * DumpRenderTree/LayoutTestController.cpp:
1091         (sampleSVGAnimationForElementAtTimeCallback):
1092         (LayoutTestController::staticFunctions):
1093         * DumpRenderTree/LayoutTestController.h:
1094         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1095         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1096         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1097         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1098         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1099         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1100         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1101         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1102         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1103         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1104         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1105
1106 2009-12-01  Adam Roben  <aroben@apple.com>
1107
1108         Remove user content before running each test on Windows
1109
1110         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
1111
1112         Reviewed by Alexey Proskuryakov.
1113
1114         * DumpRenderTree/win/DumpRenderTree.cpp:
1115         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
1116         before each test, which matches Mac.
1117
1118 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
1119
1120         Reviewed by Alexey Proskuryakov.
1121
1122         Make pywebsocket log errors to a file
1123         https://bugs.webkit.org/show_bug.cgi?id=31604
1124
1125         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
1126         (by passing the path to the server via a recently added -l option).
1127
1128 2009-12-01  Adam Roben  <aroben@apple.com>
1129
1130         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
1131
1132         Reviewed by Ada Chan.
1133
1134         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
1135         TestNetscapePlugin fail in Debug_Internal builds
1136
1137         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
1138         directory in Debug and Debug_All builds, but not in Debug_Internal
1139         builds.
1140
1141 2009-12-01  Adam Roben  <aroben@apple.com>
1142
1143         Re-enable DRT's watchdog timer on Windows
1144
1145         It was accidentally disabled in r50907.
1146
1147         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1148         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
1149         into an if condition.
1150
1151 2009-12-01  Adam Barth  <abarth@webkit.org>
1152
1153         Reviewed by Eric Seidel.
1154
1155         check-webkit-style complains about #imports with / in them
1156         https://bugs.webkit.org/show_bug.cgi?id=32022
1157
1158         We need to exclude #import directives in addition to #include from the
1159         binary operator whitespace checks.
1160
1161         * Scripts/modules/cpp_style.py:
1162         * Scripts/modules/cpp_style_unittest.py:
1163
1164 2009-11-30  Adam Barth  <abarth@webkit.org>
1165
1166         Reviewed by Eric Seidel.
1167
1168         check-webkit-style is slightly too verbose
1169         https://bugs.webkit.org/show_bug.cgi?id=32010
1170
1171         check-webkit-style prints out a bunch of "done" lines that seem redundant,
1172         especially for the style-queue.
1173
1174         * Scripts/modules/cpp_style.py:
1175
1176 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
1177
1178         Reviewed by Eric Seidel.
1179
1180         [GTK] Moved the functions that are closing the result log of the
1181         tests to the last line of the runTest function, this avoids
1182         reporting crashes in the wrong test if there is a problem when
1183         reseting the state after the test.
1184
1185         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1186         (dump):
1187         (runTest):
1188
1189 2009-11-30  Sam Weinig  <sam@webkit.org>
1190
1191         Reviewed by Geoffrey Garen.
1192
1193         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
1194         fast/js/date-proto-generic-invocation breaks another test
1195
1196         Don't cache JSClassRefs, a change to the prototype chain will
1197         last between tests.
1198
1199         * DumpRenderTree/AccessibilityController.cpp:
1200         (AccessibilityController::getJSClass):
1201         * DumpRenderTree/GCController.cpp:
1202         (GCController::getJSClass):
1203         * DumpRenderTree/GCController.h:
1204         * DumpRenderTree/LayoutTestController.cpp:
1205         (LayoutTestController::getJSClass):
1206
1207 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
1208
1209         Reviewed by Alexey Proskuryakov.
1210
1211         Update pywebsocket to 0.4.2.1.
1212         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
1213         https://bugs.webkit.org/show_bug.cgi?id=31976
1214
1215         * pywebsocket/mod_pywebsocket/standalone.py:
1216         * pywebsocket/setup.py:
1217
1218 2009-11-30  Adam Barth  <abarth@webkit.org>
1219
1220         Reviewed by Eric Seidel.
1221
1222         [bzt] Generate pass messages for style-queue
1223         https://bugs.webkit.org/show_bug.cgi?id=31995
1224
1225         With this change, the style-queue posts "pass" messages to bugs as
1226         well.  Also, added more information to the state store w.r.t. passing
1227         and failing.
1228
1229         * Scripts/modules/commands/queues.py:
1230         * Scripts/modules/patchcollection.py:
1231
1232 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1233
1234         Reviewed by Simon Fraser.
1235
1236         Check for WEBKIT_TESTFONTS environment variable in
1237         run-webkit-tests, for GTK+, to have a more prominent error
1238         message.
1239
1240         * Scripts/run-webkit-tests:
1241
1242 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
1243
1244         Reviewed by Dimitri Glazkov.
1245
1246         update-webkit --chromium forces gclient sync
1247
1248         https://bugs.webkit.org/show_bug.cgi?id=31967
1249
1250         * Scripts/update-webkit-chromium:
1251
1252 2009-11-29  Eric Seidel  <eric@webkit.org>
1253
1254         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
1255
1256         * Scripts/modules/committers.py:
1257
1258 2009-11-29  Eric Seidel  <eric@webkit.org>
1259
1260         No review, just adding missing svn property.
1261
1262         Set svn:executable property on new scripts.
1263         These were added by commit-queue commits, but the executable
1264         property was lost due to a bug in svn-apply:
1265         https://bugs.webkit.org/show_bug.cgi?id=27204
1266
1267         * Scripts/update-webkit-chromium: Added property svn:executable.
1268         * Scripts/validate-committer-lists: Added property svn:executable.
1269
1270 2009-11-29  Eric Seidel  <eric@webkit.org>
1271
1272         Reviewed by Adam Barth.
1273
1274         Need a way to validate that committers.py includes all committers/reviewers
1275         https://bugs.webkit.org/show_bug.cgi?id=30970
1276
1277         Add a script which knows how to compare our public committer/reviewer
1278         lists and show discrepancies between them.
1279
1280         Validates mailing lists vs. committers.py:
1281         - committers.py committers missing from webkit-committers@lists
1282         - webkit-committers@lists members missing from committers.py
1283         - committers.py reviewers missing from webkit-reviewers@lists
1284         - webkit-reviewers@lists members missing from committers.py
1285         - webkit-reviewers@lists members missing from committers.py reviewer list
1286
1287         Validates committers.py vs. trunk/ SVN history:
1288         - committers who have not committed in over a year
1289         - SVN committers missing from committers.py
1290         - committers.py members who have no record in SVN.
1291
1292         All of these lists still show "false positives" until a few more committers.py updates are made, like:
1293         https://bugs.webkit.org/show_bug.cgi?id=31366
1294
1295         * Scripts/validate-committer-lists: Added.
1296
1297 2009-11-28  Adam Barth  <abarth@webkit.org>
1298
1299         Reviewed by Eric Seidel.
1300
1301         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
1302         https://bugs.webkit.org/show_bug.cgi?id=31950
1303
1304         Now we cache the last status that we get back from QueueStatusServer.
1305         Eventually we'll have to do something more fancy if we want to support
1306         a "try again" button on QueueStatusServer, but we can cross that bridge
1307         when we come to it.
1308
1309         * Scripts/modules/patchcollection.py:
1310
1311 2009-11-28  Adam Barth  <abarth@webkit.org>
1312
1313         Reviewed by Eric Seidel.
1314
1315         StyleQueue scans ~100 bug pages every 5 minutes
1316         https://bugs.webkit.org/show_bug.cgi?id=31947
1317
1318         Instead of getting the pending-review attachment ids by scanning each
1319         bug (which results in a network request), we should just get them all
1320         from webkit.org/pending-review in one shot.
1321
1322         * Scripts/modules/bugzilla.py:
1323         * Scripts/modules/bugzilla_unittest.py:
1324         * Scripts/modules/commands/queries.py:
1325         * Scripts/modules/commands/queries_unittest.py:
1326         * Scripts/modules/commands/queues.py:
1327         * Scripts/modules/mock_bugzillatool.py:
1328         * Scripts/modules/patchcollection.py:
1329
1330 2009-11-28  Adam Barth  <abarth@webkit.org>
1331
1332         Reviewed by Eric Seidel.
1333
1334         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
1335         https://bugs.webkit.org/show_bug.cgi?id=31952
1336
1337         The mailing list is open for anyone to subscribe.
1338
1339         * Scripts/modules/bugzilla.py:
1340         * Scripts/modules/commands/queues.py:
1341
1342 2009-11-28  Adam Barth  <abarth@webkit.org>
1343
1344         Reviewed by Eric Seidel.
1345
1346         [bzt] style-queue should report style errors to bugzilla
1347         https://bugs.webkit.org/show_bug.cgi?id=31945
1348
1349         Currently, we're just logging the style errors locally.  With this
1350         patch we'll actually log the errors to bugzilla.  Note: I plan to run
1351         with the "local-only" logging during development.
1352
1353         * Scripts/modules/commands/queues.py:
1354         * Scripts/modules/scm.py:
1355
1356 2009-11-28  Adam Barth  <abarth@webkit.org>
1357
1358         Reviewed by Eric Seidel.
1359
1360         [bzt] style-queue shouldn't reject patches from the commit-queue
1361         https://bugs.webkit.org/show_bug.cgi?id=31944
1362
1363         Currently the style-queue subprocess gets confused and thinks its the
1364         commit-queue.  If the patch has an error, it rejects it from the
1365         commit-queue.  Instead, we should have style-queue specific logic.
1366         This patch doesn't add that logic, but it gives us a callback we can
1367         use to add that logic.
1368
1369         * Scripts/modules/buildsteps.py:
1370         * Scripts/modules/commands/queues.py:
1371         * Scripts/modules/landingsequence.py:
1372
1373 2009-11-27  Adam Barth  <abarth@webkit.org>
1374
1375         Rubber stamped by Eric Seidel.
1376
1377         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
1378
1379         * CommitQueueStatus: Removed.
1380         * CommitQueueStatus/app.yaml: Removed.
1381         * CommitQueueStatus/filters: Removed.
1382         * CommitQueueStatus/filters/__init__.py: Removed.
1383         * CommitQueueStatus/filters/webkit_extras.py: Removed.
1384         * CommitQueueStatus/index.html: Removed.
1385         * CommitQueueStatus/index.yaml: Removed.
1386         * CommitQueueStatus/queue_status.py: Removed.
1387         * CommitQueueStatus/stylesheets: Removed.
1388         * CommitQueueStatus/stylesheets/main.css: Removed.
1389         * CommitQueueStatus/update_status.html: Removed.
1390         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
1391
1392 2009-11-27  Adam Barth  <abarth@webkit.org>
1393
1394         Reviewed by Eric Seidel.
1395
1396         style-queue should only process each patch once
1397         https://bugs.webkit.org/show_bug.cgi?id=31939
1398
1399         Actually address reviewer comments!
1400
1401         * Scripts/bugzilla-tool:
1402
1403 2009-11-27  Adam Barth  <abarth@webkit.org>
1404
1405         Reviewed by Eric Seidel.
1406
1407         [bzt] style-queue fails to apply a bunch of patches for no reason
1408         https://bugs.webkit.org/show_bug.cgi?id=31942
1409
1410         By passing --non-interactive to check-style, we convince check-style
1411         to pass --force to svn-apply, which lets it apply more patches.
1412
1413         * Scripts/modules/commands/queues.py:
1414
1415 2009-11-27  Adam Barth  <abarth@webkit.org>
1416
1417         Reviewed by Eric Seidel.
1418
1419         [bzt] Support --status-host in style-queue
1420         https://bugs.webkit.org/show_bug.cgi?id=31941
1421
1422         * Scripts/modules/commands/queues.py:
1423         * Scripts/modules/statusbot.py:
1424
1425 2009-11-27  Adam Barth  <abarth@webkit.org>
1426
1427         Reviewed by Eric Seidel.
1428
1429         style-queue should only process each patch once
1430         https://bugs.webkit.org/show_bug.cgi?id=31939
1431
1432         Before processing a patch, the try-queues now ask the web service
1433         whether they have already processed the patch.  This is an initial cut
1434         of this functionality.  I expect we're make it richer over time.
1435
1436         * Scripts/bugzilla-tool:
1437         * Scripts/modules/commands/queues.py:
1438         * Scripts/modules/patchcollection.py:
1439
1440 2009-11-27  Adam Barth  <abarth@webkit.org>
1441
1442         Reviewed by Eric Seidel.
1443
1444         PatchStatus does not return status
1445         https://bugs.webkit.org/show_bug.cgi?id=31938
1446
1447         We need to parse attachment_id as an int.  Otherwise, we can't find
1448         anything in the datastore.
1449
1450         * CommitQueueStatus/queue_status.py:
1451
1452 2009-11-27  Adam Barth  <abarth@webkit.org>
1453
1454         Reviewed by Eric Seidel.
1455
1456         Make commit-queue status not throw an exception where there is not
1457         status
1458         https://bugs.webkit.org/show_bug.cgi?id=31936
1459
1460         We need to actually fetch the results of the query to see what's in the
1461         datastore.
1462
1463         * CommitQueueStatus/queue_status.py:
1464
1465 2009-11-27  Adam Barth  <abarth@webkit.org>
1466
1467         Reviewed by Eric Seidel.
1468
1469         [bzt] unit test ApplyPatches and ApplyAttachment
1470         https://bugs.webkit.org/show_bug.cgi?id=31935
1471
1472         * Scripts/modules/commands/download.py:
1473         * Scripts/modules/commands/download_unittest.py:
1474
1475 2009-11-27  Adam Barth  <abarth@webkit.org>
1476
1477         Reviewed by Eric Seidel.
1478
1479         [bzt] Unit test download commands
1480         https://bugs.webkit.org/show_bug.cgi?id=31923
1481
1482         Adds download_unittest and fixes a bug found while testing.
1483
1484         * Scripts/modules/commands/commandtest.py:
1485         * Scripts/modules/commands/download.py:
1486             Fixed a bug where we'd throw an error because [].append returns
1487             None.
1488         * Scripts/modules/commands/download_unittest.py: Added.
1489         * Scripts/modules/mock_bugzillatool.py:
1490         * Scripts/run-webkit-unittests:
1491
1492 2009-11-27  Adam Barth  <abarth@webkit.org>
1493
1494         Unreviewed "build" fix found while writing unit tests.
1495
1496         * Scripts/modules/commands/download.py:
1497
1498 2009-11-27  Adam Barth  <abarth@webkit.org>
1499
1500         Reviewed by Eric Seidel.
1501
1502         [bzt] Kill WebKitLandingScripts
1503         https://bugs.webkit.org/show_bug.cgi?id=31904
1504
1505         Step 6: Kill the rest.
1506
1507         * Scripts/modules/buildsteps.py:
1508         * Scripts/modules/commands/download.py:
1509         * Scripts/modules/commands/queries.py:
1510         * Scripts/modules/commands/upload.py:
1511         * Scripts/modules/landingsequence.py:
1512         * Scripts/modules/scm.py:
1513         * Scripts/modules/webkitlandingscripts.py: Removed.
1514
1515 2009-11-27  Adam Barth  <abarth@webkit.org>
1516
1517         Reviewed by Eric Seidel.
1518
1519         [bzt] Unit test upload commands
1520         https://bugs.webkit.org/show_bug.cgi?id=31903
1521
1522         Adds unit tests for all but two of the upload commands.  The two
1523         remaining ones are more difficult.  I'll return to them later.  The
1524         goal of these tests is just to run the commands.  We can test more
1525         detailed behavior later.
1526
1527         * Scripts/modules/commands/commandtest.py:
1528         * Scripts/modules/commands/upload.py:
1529         * Scripts/modules/commands/upload_unittest.py:
1530         * Scripts/modules/mock.py: Added.
1531         * Scripts/modules/mock_bugzillatool.py:
1532
1533 2009-11-26  Adam Barth  <abarth@webkit.org>
1534
1535         Reviewed by Eric Seidel.
1536
1537         [bzt] Kill WebKitLandingScripts
1538         https://bugs.webkit.org/show_bug.cgi?id=31904
1539
1540         Step 5: Kill run_and_throw_if_fail.
1541
1542         * Scripts/modules/buildsteps.py:
1543         * Scripts/modules/processutils.py: Added.
1544         * Scripts/modules/webkitlandingscripts.py:
1545
1546 2009-11-26  Adam Barth  <abarth@webkit.org>
1547
1548         Reviewed by Eric Seidel.
1549
1550         [bzt] Kill WebKitLandingScripts
1551         https://bugs.webkit.org/show_bug.cgi?id=31904
1552
1553         Step 4: Kill run_webkit_script.
1554
1555         * Scripts/modules/buildsteps.py:
1556         * Scripts/modules/commands/download.py:
1557         * Scripts/modules/webkitlandingscripts.py:
1558
1559 2009-11-26  Adam Barth  <abarth@webkit.org>
1560
1561         Reviewed by Eric Seidel.
1562
1563         [bzt] Kill WebKitLandingScripts
1564         https://bugs.webkit.org/show_bug.cgi?id=31904
1565
1566         Step 3: Kill build_webkit.
1567
1568         * Scripts/modules/buildsteps.py:
1569         * Scripts/modules/landingsequence.py:
1570         * Scripts/modules/webkitlandingscripts.py:
1571
1572 2009-11-26  Adam Barth  <abarth@webkit.org>
1573
1574         Reviewed by Eric Seidel.
1575
1576         [bzt] Kill WebKitLandingScripts
1577         https://bugs.webkit.org/show_bug.cgi?id=31904
1578
1579         Step 2: Kill ensure_builders_are_green.
1580
1581         * Scripts/modules/buildsteps.py:
1582         * Scripts/modules/commands/download.py:
1583         * Scripts/modules/landingsequence.py:
1584         * Scripts/modules/webkitlandingscripts.py:
1585
1586 2009-11-26  Adam Barth  <abarth@webkit.org>
1587
1588         Reviewed by Eric Seidel.
1589
1590         [bzt] Kill WebKitLandingScripts
1591         https://bugs.webkit.org/show_bug.cgi?id=31904
1592
1593         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
1594
1595         * Scripts/bugzilla-tool:
1596         * Scripts/modules/buildsteps.py: Added.
1597         * Scripts/modules/commands/download.py:
1598         * Scripts/modules/landingsequence.py:
1599         * Scripts/modules/webkitlandingscripts.py:
1600
1601 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
1602
1603         Reviewed by Adam Barth.
1604
1605         Remove directory prefixes from linux commands
1606
1607         SCM unittests can cause errors on some systems if we use absolute reference to
1608         the commands, so directory prefixes have been removed.
1609
1610         * Scripts/modules/scm_unittest.py:
1611
1612 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
1613
1614         Reviewed by Kenneth Rohde Christiansen.
1615
1616         Link DumpRenderTree to the Qt Ui Tools
1617         https://bugs.webkit.org/show_bug.cgi?id=31203
1618
1619         Implement QWebPage::createPlugin using the Qt Ui Tools
1620         to be able to create classes like QProgressBar from within
1621         the <object></object> tags This is required for the
1622         new automatic test of Qt Plugins.
1623
1624         * DumpRenderTree/qt/DumpRenderTree.cpp:
1625         (WebCore::WebPage::createPlugin):
1626         * DumpRenderTree/qt/DumpRenderTree.h:
1627         * DumpRenderTree/qt/DumpRenderTree.pro:
1628
1629 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
1630
1631         Reviewed by Eric Seidel.
1632
1633         Update pywebsocket to 0.4.2
1634
1635         Update pywebsocket to 0.4.2
1636         https://bugs.webkit.org/show_bug.cgi?id=31861
1637
1638         * pywebsocket/example/echo_client.py:
1639         * pywebsocket/example/echo_wsh.py:
1640         * pywebsocket/mod_pywebsocket/__init__.py:
1641         * pywebsocket/mod_pywebsocket/dispatch.py:
1642         * pywebsocket/mod_pywebsocket/msgutil.py:
1643         * pywebsocket/mod_pywebsocket/standalone.py:
1644         * pywebsocket/setup.py:
1645         * pywebsocket/test/test_dispatch.py:
1646         * pywebsocket/test/test_msgutil.py:
1647
1648 2009-11-25  Adam Barth  <abarth@webkit.org>
1649
1650         Reviewed by Eric Seidel.
1651
1652         Add unit test for mark-fixed
1653         https://bugs.webkit.org/show_bug.cgi?id=31896
1654
1655         * Scripts/modules/commands/commandtest.py: Added.
1656         * Scripts/modules/commands/queries_unittest.py:
1657         * Scripts/modules/commands/upload_unittest.py: Added.
1658         * Scripts/modules/mock_bugzillatool.py:
1659         * Scripts/run-webkit-unittests:
1660
1661 2009-11-25  Adam Barth  <abarth@webkit.org>
1662
1663         Reviewed by Eric Seidel.
1664
1665         bugzilla-tool should have a mark-fixed command
1666         https://bugs.webkit.org/show_bug.cgi?id=31853
1667
1668         Pretty simple stuff.
1669
1670         * Scripts/modules/commands/upload.py:
1671
1672 2009-11-25  Eric Seidel  <eric@webkit.org>
1673
1674         Reviewed by Adam Barth.
1675
1676         'bugzilla-tool help' should only show common commands like how 'git help' does
1677         https://bugs.webkit.org/show_bug.cgi?id=31772
1678
1679         I also took this opportunity to make 'help' a real Command.
1680         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
1681
1682         * Scripts/bugzilla-tool:
1683          - change should_show_command_help to should_show_in_main_help
1684         * Scripts/modules/commands/download.py:
1685          - Mark commands as being shown in main help or not.
1686          - show_in_main_help = False is not required (default is false),
1687            but it seemed to make the commands more self-documenting.
1688         * Scripts/modules/commands/queries.py: ditto
1689         * Scripts/modules/commands/queues.py: ditto
1690         * Scripts/modules/commands/upload.py: ditto
1691         * Scripts/modules/multicommandtool.py:
1692          - Make Command hold a pointer to tool in self.tool.  Most Command
1693            subclasses do not take advantage of this yet, but it was required
1694            for HelpCommand to be able to reach the tool from _help_epilog().
1695          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
1696          - Move MultiCommandTool._help_epilog to Command._help_epilog
1697          - Move "help" logic into HelpCommand.execute()
1698          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
1699         * Scripts/modules/multicommandtool_unittest.py:
1700          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
1701
1702 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
1703
1704         Reviewed by Dan Bernstein.
1705         
1706         Patch by Mark Rowe.
1707
1708         The buildbots are failing on Windows because when they were upgraded
1709         to 4.0.4, Apple Application Support was not in their path. Add it to
1710         the path to fix the buildots.
1711
1712         * Scripts/webkitdirs.pm:
1713
1714 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1715
1716         Reviewed by David Kilzer.
1717
1718         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1719         https://bugs.webkit.org/show_bug.cgi?id=31799
1720
1721         * Scripts/run-webkit-tests: Fixed.
1722
1723 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1724
1725         Reviewed by Eric Seidel.
1726
1727         Change run_command to give back stderr by default
1728         https://bugs.webkit.org/show_bug.cgi?id=31734
1729
1730         Change run_command to give back stderr by default.
1731         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1732         Change the related unittest call.
1733
1734         * Scripts/modules/scm.py:
1735         * Scripts/modules/scm_unittest.py:
1736
1737 2009-11-25  Eric Seidel  <eric@webkit.org>
1738
1739         Reviewed by Adam Barth.
1740
1741         Centralize required argument parsing in Command
1742         https://bugs.webkit.org/show_bug.cgi?id=31872
1743
1744         * Scripts/modules/commands/download.py: remove custom required arg message.
1745         * Scripts/modules/commands/upload.py: ditto.
1746         * Scripts/modules/multicommandtool.py:
1747          - Add _parse_required_arguments.
1748          - Pass program name off to OptionParser.
1749          - Add name() for access to tool name.
1750          - Add check_arguments_and_execute and make it return a return code.
1751          - Replace a couple uses of + with %.
1752         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1753
1754 2009-11-25  Eric Seidel  <eric@webkit.org>
1755
1756         Reviewed by Adam Barth.
1757
1758         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1759         https://bugs.webkit.org/show_bug.cgi?id=31870
1760
1761         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1762         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1763         * Scripts/modules/outputcapture.py: Added.
1764
1765 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1766
1767         Reviewed by Eric Seidel.
1768
1769         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1770         https://bugs.webkit.org/show_bug.cgi?id=31444
1771
1772         * Scripts/build-webkit:
1773
1774 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1775
1776         Reviewed by Simon Fraser.
1777
1778         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1779         https://bugs.webkit.org/show_bug.cgi?id=27314
1780         
1781         Now the script allows the directories with these tests to be included on all
1782         platforms but Mac, where they behave the same as always. For all other platforms
1783         the tests need to be excluded using the Skipped files, which is currently done
1784         for all platforms (including win since we're not turned on yet)
1785
1786         * Scripts/webkitdirs.pm:
1787
1788 2009-11-24  Eric Seidel  <eric@webkit.org>
1789
1790         Reviewed by Adam Barth.
1791
1792         queries_unittest.py should test command output
1793         https://bugs.webkit.org/show_bug.cgi?id=31845
1794
1795         * Scripts/modules/commands/queries_unittest.py:
1796          - Capture stdout and stderr and compare with expected strings.
1797
1798 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1799
1800         No Review.
1801
1802         Fix spelling error ("depenedencies").
1803
1804         * Scripts/build-webkit:
1805
1806 2009-11-24  Mark Rowe  <mrowe@apple.com>
1807
1808         Land the configuration that includes the two debug GTK Linux builders.
1809
1810         * BuildSlaveSupport/build.webkit.org-config/config.json:
1811
1812 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1813
1814         <http://webkit.org/b/31840> bisect-builds broke after r50080
1815
1816         Reviewed by Dan Bernstein.
1817
1818         * Scripts/bisect-builds:
1819         (mountAndRunNightly): Switched back to using backticks to run
1820         the hdiutil command since exec() will terminate the existing
1821         script, which is not what we want.  Store the output of
1822         File::Spec->devnull() in a variable for use in the hdiutil
1823         detach commands.
1824
1825 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1826
1827         Reviewed by Kenneth Rohde Christiansen.
1828
1829         Include "config.h" to meet Coding Style Guidelines
1830         https://bugs.webkit.org/show_bug.cgi?id=31792
1831
1832         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1833         * DumpRenderTree/qt/jsobjects.cpp:
1834         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1835
1836 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1837
1838         Reviewed by Oliver Hunt.
1839
1840         Implement new required function to pass test we used to pass. This
1841         change is required since r51294.
1842
1843         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1844         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1845
1846 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1847
1848         Reviewed by Kenneth Rohde Christiansen.
1849
1850         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1851         https://bugs.webkit.org/show_bug.cgi?id=31775
1852
1853         LayoutTestController::dumpBackForwardList() should work with local URLs
1854         as well as with normal URLs (in http tests for instance).
1855         Currently it does not output the latter properly.
1856
1857         Unskip a bunch of passing http/navigation tests.
1858
1859         * DumpRenderTree/qt/DumpRenderTree.cpp:
1860         (WebCore::dumpHistoryItem):
1861
1862 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1863
1864         Reviewed by Oliver Hunt.
1865
1866         ARIA: support aria-flowto
1867         https://bugs.webkit.org/show_bug.cgi?id=31762
1868
1869         * DumpRenderTree/AccessibilityUIElement.cpp:
1870         (ariaFlowToElementAtIndexCallback):
1871         (AccessibilityUIElement::getJSClass):
1872         * DumpRenderTree/AccessibilityUIElement.h:
1873         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1874         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1875         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1876         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1877         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1878         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1879
1880 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1881
1882         Reviewed by Kenneth Christiansen.
1883
1884         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1885         https://bugs.webkit.org/show_bug.cgi?id=31638
1886
1887         Unfreeze WorkQueue after each test execution.
1888
1889         * DumpRenderTree/qt/DumpRenderTree.cpp:
1890         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1891
1892 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1893
1894         Reviewed by Adam Barth.
1895
1896         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1897         for localhost and 127.0.0.1.
1898         https://bugs.webkit.org/show_bug.cgi?id=31783
1899
1900         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1901
1902         * DumpRenderTree/qt/DumpRenderTree.cpp:
1903         (WebCore::NetworkAccessManager::NetworkAccessManager):
1904         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1905         (WebCore::WebPage::WebPage):
1906         * DumpRenderTree/qt/DumpRenderTree.h:
1907
1908 2009-11-22  Chris Evans  <cevans@chromium.org>
1909
1910         Reviewed by Adam Barth.
1911
1912         Disable access to file:/// directory listings
1913         https://bugs.webkit.org/show_bug.cgi?id=31329
1914
1915         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1916         file URL security.
1917
1918         * DumpRenderTree/LayoutTestController.cpp:
1919         (setAllowUniversalAccessFromFileURLsCallback):
1920         (LayoutTestController::staticFunctions):
1921         * DumpRenderTree/LayoutTestController.h:
1922         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1923         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1924         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1925         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1926         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1927         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1928         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1929         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1930
1931 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1932
1933         Reviewed by Kenneth Rohde Christiansen.
1934
1935         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1936         https://bugs.webkit.org/show_bug.cgi?id=31638
1937
1938         The test is timeouting, because it uses the WorkQueue to load a document in one
1939         of the child frames and once the loading is finished, the DRT does not dump the
1940         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1941         the main frame, while it should connect to QWebPage::loadFinished().
1942
1943         * DumpRenderTree/qt/DumpRenderTree.cpp:
1944         (WebCore::DumpRenderTree::DumpRenderTree):
1945
1946 2009-11-21  Eric Seidel  <eric@webkit.org>
1947
1948         Reviewed by Adam Barth.
1949
1950         bugzilla-tool --help spews way too much text
1951         https://bugs.webkit.org/show_bug.cgi?id=31771
1952
1953         * Scripts/bugzilla-tool:
1954          - Remove self.cached_scm initialization hack.
1955         * Scripts/modules/buildbot.py:
1956          - Make default_host accessible to callers.
1957         * Scripts/modules/commands/download.py:
1958          - Phrase help for all commands consistently and remove spurious help text punctuation.
1959         * Scripts/modules/commands/queries.py: Ditto.
1960         * Scripts/modules/commands/queues.py: Ditto.
1961         * Scripts/modules/commands/upload.py: Ditto.
1962         * Scripts/modules/multicommandtool.py:
1963          - Add HelpPrintingOptionParser.format_epilog to replace
1964            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
1965            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
1966          - Make --help only show a list of commands like "svn help" and "git help" do --
1967            previously --help was listing all commands and options.
1968          - Sort list of commands alphabetically.
1969
1970 2009-11-21  Eric Seidel  <eric@webkit.org>
1971
1972         No review.  Fixing a typo from the previous patch for bug 31767.
1973
1974         AbstractQueue.run_bugzilla_tool throws an exception
1975         https://bugs.webkit.org/show_bug.cgi?id=31769
1976
1977         * Scripts/modules/commands/queues.py:
1978
1979 2009-11-21  Eric Seidel  <eric@webkit.org>
1980
1981         Reviewed by Adam Barth.
1982
1983         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
1984         https://bugs.webkit.org/show_bug.cgi?id=31767
1985
1986         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
1987         Since we don't have a good way to test BugzillaTool pieces, I've
1988         left out a test for now.
1989
1990         * Scripts/bugzilla-tool:
1991          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1992         * Scripts/modules/commands/queues.py:
1993          - Use tool.path() instead of __file__.
1994         * Scripts/modules/multicommandtool.py:
1995          - Add a new path() method to MultiComandTool.
1996         * Scripts/modules/multicommandtool_unittest.py:
1997          - Provide a path() method.  Little point in testing this mock implementation.
1998
1999 2009-11-21  Adam Barth  <abarth@webkit.org>
2000
2001         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
2002         WebKitTools.
2003
2004         * Scripts/modules/commands/download.py:
2005
2006 2009-11-21  Adam Barth  <abarth@webkit.org>
2007
2008         Reviewed by Eric Seidel.
2009
2010         Convert check-style to use LandingSequence
2011         https://bugs.webkit.org/show_bug.cgi?id=31763
2012
2013         Instead of manipulating the working copy by hand, we should use the
2014         LandingSequence in CheckStyle.  This will make this code eaiser to
2015         test.
2016
2017         * Scripts/modules/commands/download.py:
2018
2019 2009-11-20  Adam Barth  <abarth@webkit.org>
2020
2021         Reviewed by Eric Seidel.
2022
2023         Unit test query commands
2024         https://bugs.webkit.org/show_bug.cgi?id=31755
2025
2026         These tests are pretty rough, but hopefully they'll grow.
2027
2028         * Scripts/modules/commands/queries_unittest.py: Added.
2029         * Scripts/modules/mock_bugzillatool.py: Added.
2030         * Scripts/run-webkit-unittests:
2031
2032 2009-11-20  Eric Seidel  <eric@webkit.org>
2033
2034         Reviewed by Adam Barth.
2035
2036         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
2037         https://bugs.webkit.org/show_bug.cgi?id=31758
2038
2039         * Scripts/modules/multicommandtool.py:
2040          - Allow passing of explicit commands to MultiCommandTool.__init__
2041         * Scripts/modules/multicommandtool_unittest.py:
2042          - Use new Command.name naming system.
2043          - Test Command auto-discovery.
2044         * Scripts/modules/workqueue.py:
2045          - bug_id no longer exists, use patch['bug_id'] instead.
2046         * Scripts/modules/workqueue_unittest.py:
2047          - WorkQueues require names now.
2048          - should_proceed_with_work_item must return a patch object.
2049
2050 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
2051
2052         Reviewed by Beth Dakin.
2053
2054         WAI-ARIA: add support for aria-owns
2055         https://bugs.webkit.org/show_bug.cgi?id=31702
2056
2057         * DumpRenderTree/AccessibilityUIElement.cpp:
2058         (ariaOwnsElementAtIndexCallback):
2059         (AccessibilityUIElement::getJSClass):
2060         * DumpRenderTree/AccessibilityUIElement.h:
2061         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2062         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2063         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2064         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2065         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2066         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2067
2068 2009-11-20  Eric Seidel  <eric@webkit.org>
2069
2070         Reviewed by Adam Barth.
2071
2072         Fix exception thrown when running the commit-queue.
2073
2074         * Scripts/modules/statusbot.py: patch is optional.
2075         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
2076
2077 2009-11-20  Eric Seidel  <eric@webkit.org>
2078
2079         Reviewed by Adam Barth.
2080
2081         Teach the StatusBot how to support more than just the commit-queue
2082         https://bugs.webkit.org/show_bug.cgi?id=31754
2083
2084         * Scripts/modules/workqueue.py: Another typo.
2085
2086 2009-11-20  Eric Seidel  <eric@webkit.org>
2087
2088         Reviewed by Adam Barth.
2089
2090         Teach the StatusBot how to support more than just the commit-queue
2091         https://bugs.webkit.org/show_bug.cgi?id=31754
2092
2093         * Scripts/modules/commands/queues.py: Fix silly typo.
2094
2095 2009-11-20  Eric Seidel  <eric@webkit.org>
2096
2097         Reviewed by Adam Barth.
2098
2099         Teach the StatusBot how to support more than just the commit-queue
2100         https://bugs.webkit.org/show_bug.cgi?id=31754
2101
2102         * CommitQueueStatus/index.yaml:
2103          - Add indices required for the new queries.
2104         * CommitQueueStatus/queue_status.py:
2105          - Add a patch-status page and move update_status to update-status.
2106          - Only display "commit-queue" status records for the commit-queue.
2107          - Add support for a queue_name property on status records.
2108          - Fix _int_from_request to actually work.
2109         * CommitQueueStatus/update_status.html:
2110          - Add support for a queue_name on status records.
2111          - Remove unused list of bug ids.
2112          * Scripts/modules/commands/queues.py
2113           - Make the queues pass the patch instead of the bug_id to StatusBot.
2114         * Scripts/modules/statusbot.py:
2115          - Support passing the queue_name to the status updates.
2116          - Support fetching patch status with patch_status().
2117         * Scripts/modules/workqueue.py:
2118          - Pass the patch to the StatusBot instead of the bug_id.
2119          - Let WorkQueues have a name.
2120
2121 2009-11-20  Adam Barth  <abarth@webkit.org>
2122
2123         Reviewed by Eric Seidel.
2124
2125         Move bugzilla-tool commands into their own file
2126         https://bugs.webkit.org/show_bug.cgi?id=31752
2127
2128         This will let us write unit tests.
2129
2130         * Scripts/bugzilla-tool:
2131         * Scripts/modules/commands/__init__.py: Added.
2132         * Scripts/modules/commands/download.py: Added.
2133         * Scripts/modules/commands/queries.py: Added.
2134         * Scripts/modules/commands/queues.py: Added.
2135         * Scripts/modules/commands/upload.py: Added.
2136         * Scripts/modules/grammar.py: Added.
2137
2138 2009-11-20  Adam Barth  <abarth@webkit.org>
2139
2140         Reviewed by Eric Seidel.
2141
2142         BuildQueue should check if the tree is currently buildable
2143         https://bugs.webkit.org/show_bug.cgi?id=31744
2144
2145         * Scripts/bugzilla-tool:
2146         * Scripts/modules/landingsequence.py:
2147         * Scripts/modules/webkitlandingscripts.py:
2148
2149 2009-11-20  Adam Barth  <abarth@webkit.org>
2150
2151         Reviewed by Eric Seidel.
2152
2153         Move prepare_clean_working_directory into the LandingSequence
2154         https://bugs.webkit.org/show_bug.cgi?id=31743
2155
2156         * Scripts/bugzilla-tool:
2157         * Scripts/modules/landingsequence.py:
2158
2159 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
2160
2161         Reviewed by Kenneth Rohde Christiansen.
2162
2163         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
2164         https://bugs.webkit.org/show_bug.cgi?id=30460
2165
2166         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
2167
2168         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2169         (pluginInvoke):
2170
2171 2009-11-20  Adam Barth  <abarth@webkit.org>
2172
2173         Reviewed by Eric Seidel.
2174
2175         Pass the port information to the child process
2176         https://bugs.webkit.org/show_bug.cgi?id=31736
2177
2178         We need to do this so the child process knows what to build!
2179
2180         * Scripts/bugzilla-tool:
2181         * Scripts/modules/landingsequence.py:
2182         * Scripts/modules/webkitport.py:
2183         * Scripts/modules/webkitport_unittest.py:
2184
2185 2009-11-20  Adam Barth  <abarth@webkit.org>
2186
2187         Reviewed by Eric Seidel.
2188
2189         Support Qt port in build-queue
2190         https://bugs.webkit.org/show_bug.cgi?id=31733
2191
2192         * Scripts/bugzilla-tool:
2193
2194 2009-11-20  Adam Barth  <abarth@webkit.org>
2195
2196         Reviewed by Eric Seidel.
2197
2198         Implement a build-queue
2199         https://bugs.webkit.org/show_bug.cgi?id=31725
2200
2201         Currently this just builds the first 10 patches in the review queue.
2202         We'll want to do something smarter soon.
2203
2204         * Scripts/bugzilla-tool:
2205
2206 2009-11-20  Adam Barth  <abarth@webkit.org>
2207
2208         Reviewed by Eric Seidel.
2209
2210         Make commit-queue and style-queue show up in help
2211         https://bugs.webkit.org/show_bug.cgi?id=31724
2212
2213         We need to store their names on their class to make these commands
2214         properly register themselves with MultiCommandTool.
2215
2216         * Scripts/bugzilla-tool:
2217
2218 2009-11-20  Adam Barth  <abarth@webkit.org>
2219
2220         Reviewed by Eric Seidel.
2221
2222         Implement bugzilla-tool build-attachment
2223         https://bugs.webkit.org/show_bug.cgi?id=31722
2224
2225         This command builds an attachment from bugzilla.  It leaves the built
2226         patch in the working copy.
2227
2228         * Scripts/bugzilla-tool:
2229         * Scripts/modules/landingsequence.py:
2230         * Scripts/modules/webkitlandingscripts.py:
2231
2232 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
2233
2234         Reviewed by Xan Lopez.
2235
2236         [GTK] DRT release event does not create the state correctly
2237         https://bugs.webkit.org/show_bug.cgi?id=31717
2238
2239         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2240
2241 2009-11-20  Eric Seidel  <eric@webkit.org>
2242
2243         Reviewed by Adam Barth.
2244
2245         MultiCommandTool should find Command objects automatically instead of with a manual list
2246         https://bugs.webkit.org/show_bug.cgi?id=31710
2247
2248         * Scripts/bugzilla-tool:
2249         * Scripts/modules/multicommandtool.py:
2250          - Use some wild python-fu to crawl all the known subclasses of Command.
2251
2252 2009-11-20  Adam Barth  <abarth@webkit.org>
2253
2254         Unreviewed "build" fix.  Added missing import.
2255
2256         * Scripts/bugzilla-tool:
2257
2258 2009-11-20  Adam Barth  <abarth@webkit.org>
2259
2260         Unreviewed "build" fix.  I failed to update LandingSequence.test
2261         properly.
2262
2263         * Scripts/modules/landingsequence.py:
2264
2265 2009-11-20  Adam Barth  <abarth@webkit.org>
2266
2267         Reviewed by Eric Seidel.
2268
2269         Create LandingSequence as the all-sing, all-dance landing class
2270         https://bugs.webkit.org/show_bug.cgi?id=31709
2271
2272         Client can inherit from this class to carefully control exactly which
2273         steps they wish to have happen in the landing sequence.
2274
2275         * Scripts/bugzilla-tool:
2276         * Scripts/modules/landingsequence.py: Added.
2277         * Scripts/modules/webkitlandingscripts.py: Added.
2278
2279 2009-11-19  Adam Barth  <abarth@webkit.org>
2280
2281         Reviewed by Eric Seidel.
2282
2283         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
2284         https://bugs.webkit.org/show_bug.cgi?id=31707
2285
2286         This is to help when we implement build-attachment.
2287
2288         * Scripts/bugzilla-tool:
2289
2290 2009-11-19  Adam Barth  <abarth@webkit.org>
2291
2292         Reviewed by Eric Seidel.
2293
2294         Support Qt port in bugzilla-tool
2295         https://bugs.webkit.org/show_bug.cgi?id=31701
2296
2297         Now we support building with Qt!
2298
2299         * Scripts/bugzilla-tool:
2300         * Scripts/modules/webkitport.py: Added.
2301         * Scripts/modules/webkitport_unittest.py: Added.
2302         * Scripts/run-webkit-unittests:
2303
2304 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
2305
2306         Reviewed by Adam Barth.
2307
2308         Remove inserting stderr into patch in bugzilla-tool
2309         https://bugs.webkit.org/show_bug.cgi?id=29914
2310
2311         Modify SCM python module's run_command function to avoid return of stderr
2312         by default, so stderr won't be inserted into the patches.
2313         Modify the related unit test.
2314
2315         * Scripts/modules/scm.py:
2316         * Scripts/modules/scm_unittest.py:
2317
2318 2009-11-19  Eric Seidel  <eric@webkit.org>
2319
2320         Reviewed by Adam Barth.
2321
2322         bugzilla-tool needs per-command help
2323         https://bugs.webkit.org/show_bug.cgi?id=31697
2324
2325         Added support for "bugzilla-tool help command-name"
2326         and a unit test to make sure it works.
2327
2328         * Scripts/modules/multicommandtool.py:
2329         * Scripts/modules/multicommandtool_unittest.py:
2330
2331 2009-11-19  Eric Seidel  <eric@webkit.org>
2332
2333         Reviewed by Adam Barth.
2334
2335         Move MultiCommandTool and Command into a separate file and add some basic unit tests
2336         https://bugs.webkit.org/show_bug.cgi?id=31695
2337
2338         * Scripts/bugzilla-tool:
2339         * Scripts/modules/multicommandtool.py: Added.
2340         * Scripts/modules/multicommandtool_unittest.py: Added.
2341         * Scripts/run-webkit-unittests:
2342
2343 2009-11-19  Eric Seidel  <eric@webkit.org>
2344
2345         No review, just adding a FIXME.
2346
2347         Split out command parsing and help printing from BugzillaTool
2348         https://bugs.webkit.org/show_bug.cgi?id=31688
2349
2350         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
2351
2352 2009-11-19  Eric Seidel  <eric@webkit.org>
2353
2354         Reviewed by Adam Barth.
2355
2356         Split out command parsing and help printing from BugzillaTool
2357         https://bugs.webkit.org/show_bug.cgi?id=31688
2358
2359         * Scripts/bugzilla-tool:
2360          - Add new MultiCommandTool class to contain option parsing and help printing logic.
2361          - Rename private methods to use _ pattern.
2362          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
2363          - 
2364
2365 2009-11-19  Eric Seidel  <eric@webkit.org>
2366
2367         Reviewed by Adam Barth.
2368
2369         Re-factor help printing to use modern python idioms
2370         https://bugs.webkit.org/show_bug.cgi?id=31685
2371
2372         * Scripts/bugzilla-tool:
2373
2374 2009-11-19  Eric Seidel  <eric@webkit.org>
2375
2376         Reviewed by Darin Adler.
2377
2378         commit-queue empty queue logs twice
2379         https://bugs.webkit.org/show_bug.cgi?id=31679
2380
2381         * Scripts/bugzilla-tool:
2382
2383 2009-11-19  Eric Seidel  <eric@webkit.org>
2384
2385         Reviewed by Darin Adler.
2386
2387         bugzilla-tool's reviewer/committer rejection message should be clearer
2388         https://bugs.webkit.org/show_bug.cgi?id=31126
2389
2390         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
2391
2392         * Scripts/modules/bugzilla.py:
2393
2394 2009-11-19  Eric Z. Ayers  <zundel@google.com>
2395
2396         Reviewed by Pavel Feldman.
2397
2398         Forces a WM_PAINT event on calling layoutTestController.display()
2399         in order to enable the timeline-paint.html test on Windows.
2400         ::UpdateWindow() does not force an event becaue the window is 
2401         not visible.
2402
2403         https://bugs.webkit.org/show_bug.cgi?id=31402
2404
2405         * DumpRenderTree/win/DumpRenderTree.cpp:
2406         (displayWebView):
2407
2408 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
2409
2410         No review needed.
2411
2412         Added myself to committers list.
2413
2414         * Scripts/modules/committers.py:
2415
2416 2009-11-19  Adam Barth  <abarth@webkit.org>
2417
2418         Reviewed by Eric Seidel.
2419
2420         Bugzilla-tool command classes should match command names
2421         https://bugs.webkit.org/show_bug.cgi?id=31666
2422
2423         I renamed all the commands except CommitMessageForCurrentDiff because
2424         the new name would conflict with an existing class.
2425
2426         * Scripts/bugzilla-tool:
2427
2428 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
2429
2430         Reviewed by Gustavo Noronha Silva.
2431
2432         Web Inspector: Implement "show inspector" in WebKit GTK
2433         API and enable console tests.
2434
2435         https://bugs.webkit.org/show_bug.cgi?id=31669
2436
2437         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2438         (LayoutTestController::showWebInspector):
2439
2440 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2441
2442         Reviewed by Simon Hausmann.
2443
2444         Minor refactoring + more documentation.
2445
2446         * DumpRenderTree/qt/DumpRenderTree.cpp:
2447         (WebCore::clearHistory):
2448         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2449
2450 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
2451
2452         Reviewed by Eric Seidel.
2453
2454         Ignore websocket tests when --no-http is specified.
2455         https://bugs.webkit.org/show_bug.cgi?id=31662
2456
2457         * Scripts/run-webkit-tests:
2458
2459 2009-11-18  Adam Barth  <abarth@webkit.org>
2460
2461         Reviewed by Eric Seidel.
2462
2463         Normalize ' and " in bugzilla-tool
2464         https://bugs.webkit.org/show_bug.cgi?id=31655
2465
2466         We decided " is better than ' and we should be consistent.
2467
2468         * Scripts/bugzilla-tool:
2469
2470 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2471
2472         Reviewed by Kenneth Rohde Christiansen.
2473
2474         [Qt] Remove support for Qt v4.3 or older versions
2475         https://bugs.webkit.org/show_bug.cgi?id=29469
2476
2477         * DumpRenderTree/qt/DumpRenderTree.pro:
2478         * DumpRenderTree/qt/ImageDiff.pro:
2479
2480 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
2481
2482         Reviewed by Eric Seidel.
2483
2484         GitTest.test_create_binary_patch fails if /tmp is symlink
2485         https://bugs.webkit.org/show_bug.cgi?id=31536
2486
2487         * Scripts/modules/scm_unittest.py:
2488
2489 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
2490
2491         Reviewed by Darin Adler.
2492
2493         Configuration for Chromium Build Slaves.
2494
2495         https://bugs.webkit.org/show_bug.cgi?id=31442
2496
2497         * BuildSlaveSupport/build.webkit.org-config/config.json:
2498         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2499
2500 2009-11-18  Eric Seidel  <eric@webkit.org>
2501
2502         Reviewed by Darin Adler.
2503
2504         workqueue.py results in totally broken commit-queue UI
2505         https://bugs.webkit.org/show_bug.cgi?id=31645
2506
2507         * Scripts/bugzilla-tool:
2508          - Remove unneeded use of PatchCollection.
2509          - Grab a new copy of the cq'd patches every run of the queue.
2510
2511 2009-11-18  Sam Weinig  <sam@webkit.org>
2512
2513         Reviewed by Anders Carlsson.
2514
2515         Make the Mac Geolocation API async.
2516
2517         Update DRT to use the new async Mac Geolocation API.
2518
2519         * DumpRenderTree/mac/UIDelegate.mm:
2520         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2521
2522 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2523
2524         Reviewed by Kenneth Rohde Christiansen.
2525
2526         Add and option to toggle HTML5 datalist support to build-webkit
2527         https://bugs.webkit.org/show_bug.cgi?id=31599
2528
2529         * Scripts/build-webkit:
2530
2531 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
2532
2533         Reviewed by Kevin Ollivier.
2534
2535         Enable wx plugin support using the Windows implementation as a base.
2536         
2537         https://bugs.webkit.org/show_bug.cgi?id=31636
2538
2539         * wx/build/settings.py:
2540
2541 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2542
2543         Reviewed by Simon Hausmann.
2544
2545         Change the initialization order so that the controllers
2546         will be created before exporting them to the JS DOM window.
2547
2548         * DumpRenderTree/qt/DumpRenderTree.cpp:
2549         (WebCore::DumpRenderTree::DumpRenderTree):
2550
2551 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2552
2553         Reviewed by Simon Hausmann.
2554
2555         Fix a code copy and paste error. m_page should be page.
2556
2557         * DumpRenderTree/qt/DumpRenderTree.cpp:
2558         (WebCore::DumpRenderTree::createWindow):
2559
2560 2009-11-17  Mark Rowe  <mrowe@apple.com>
2561
2562         Reviewed by Alexey Proskuryakov.
2563
2564         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
2565
2566         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
2567         This prevents symlinks from confusing the descendant check.
2568
2569 2009-11-17  Mark Rowe  <mrowe@apple.com>
2570
2571         Reviewed by Alexey Proskuryakov.
2572
2573         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
2574
2575         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
2576         server to be up rather than having run-webkit-tests abort immediately.
2577
2578         * Scripts/run-webkit-tests:
2579
2580 2009-11-17  Eric Seidel  <eric@webkit.org>
2581
2582         Reviewed by Darin Adler.
2583
2584         commit-queue is failing to set reviewer in ChangeLogs
2585         https://bugs.webkit.org/show_bug.cgi?id=31592
2586
2587         * Scripts/bugzilla-tool: Clarify the "applying" log message.
2588         * Scripts/modules/bugzilla.py:
2589          - Add a new _validate_committer_and_reviewer function as a
2590            temporary solution until we can make a real Attachment object
2591            which knows how to fill in its committer/reviewer fields automatically.
2592
2593 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2594
2595         Unreviewed buildbot fix.
2596
2597         Revert part of earlier patch and add comment, as it
2598         was causing timeouts on the buildbot.
2599
2600         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2601         (LayoutTestController::notifyDone):
2602
2603 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2604
2605         Reviewed by Oliver Hunt.
2606
2607         Make the timeout 15 sec as for the other DRT's and make
2608         it print out the same output when a test timeout.
2609
2610         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2611         (LayoutTestController::waitUntilDone):
2612         (LayoutTestController::notifyDone):
2613         (LayoutTestController::timerEvent):
2614
2615 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
2616
2617         Reviewed by Timothy Hatcher.
2618
2619         Fixed typos in comments.
2620
2621         * Scripts/modules/committers.py:
2622
2623 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2624
2625         Reviewed by Timothy Hatcher.
2626
2627         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2628         - Updated DRT to show/close inspector for all tests under /inspector
2629         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2630           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2631         - Removed reload on each inspector test
2632         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2633         inspector for those.
2634         - Reimplemented timeline tests in order to get rid of reload there.
2635         - Moved tests that don't require harness into the fast group.
2636
2637         https://bugs.webkit.org/show_bug.cgi?id=31472
2638
2639         * DumpRenderTree/LayoutTestController.cpp:
2640         (setTimelineProfilingEnabledCallback):
2641         (closeWebInspectorCallback):
2642         (LayoutTestController::staticFunctions):
2643         * DumpRenderTree/LayoutTestController.h:
2644         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2645         (shouldOpenWebInspector):
2646         (runTest):
2647         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2648         (LayoutTestController::setTimelineProfilingEnabled):
2649         * DumpRenderTree/mac/DumpRenderTree.mm:
2650         (shouldOpenWebInspector):
2651         (runTest):
2652         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2653         (LayoutTestController::setTimelineProfilingEnabled):
2654         * DumpRenderTree/win/DumpRenderTree.cpp:
2655         (shouldOpenWebInspector):
2656         (runTest):
2657         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2658         (LayoutTestController::setTimelineProfilingEnabled):
2659
2660 2009-11-17  Oliver Hunt  <oliver@apple.com>
2661
2662         Reviewed by Maciej Stachowiak.
2663
2664         Incorrect use of JavaScriptCore API in DumpRenderTree
2665         https://bugs.webkit.org/show_bug.cgi?id=31577
2666
2667         Return undefined rather than a literal null.
2668
2669         * DumpRenderTree/AccessibilityUIElement.cpp:
2670         (setSelectedTextRangeCallback):
2671         (incrementCallback):
2672         (decrementCallback):
2673         (showMenuCallback):
2674
2675 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2676
2677         Reviewed by Beth Dakin.
2678
2679         AX: aria-labelledby duplicates some of its WAI-ARIA label
2680         https://bugs.webkit.org/show_bug.cgi?id=31565
2681
2682         * DumpRenderTree/AccessibilityUIElement.cpp:
2683         (titleUIElementCallback):
2684         (getIsValidCallback):
2685         (AccessibilityUIElement::getJSClass):
2686
2687 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2688
2689         Reviewed by Simon Hausmann.
2690
2691         r50942 broke output from created windows. Make the
2692         m_enableTextOutput a member of the DRT and not the
2693         WebPage.
2694
2695         * DumpRenderTree/qt/DumpRenderTree.cpp:
2696         (WebCore::WebPage::WebPage):
2697         (WebCore::WebPage::javaScriptAlert):
2698         (WebCore::WebPage::javaScriptConsoleMessage):
2699         (WebCore::WebPage::javaScriptConfirm):
2700         (WebCore::WebPage::javaScriptPrompt):
2701         (WebCore::WebPage::acceptNavigationRequest):
2702         (WebCore::DumpRenderTree::DumpRenderTree):
2703         (WebCore::DumpRenderTree::open):
2704         (WebCore::DumpRenderTree::createWindow):
2705         * DumpRenderTree/qt/DumpRenderTree.h:
2706         (WebCore::DumpRenderTree::setTextOutputEnabled):
2707         (WebCore::DumpRenderTree::isTextOutputEnabled):
2708         (WebCore::WebPage::shouldInterruptJavaScript):
2709         (WebCore::WebPage::isTextOutputEnabled):
2710         (WebCore::WebPage::setViewGeometry):
2711
2712 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2713
2714         Reviewed by Gustavo Noronha Silva.
2715
2716         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2717         as the implementation is being used by at least Qt and Gtk+.
2718
2719         Update buildsystems as well.
2720
2721         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2722         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2723         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2724         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2725         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2726         * GNUmakefile.am:
2727
2728 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2729
2730         Reviewed by Alexey Proskuryakov.
2731
2732         Disable wss until all platforms support pyOpenSSL
2733
2734         https://bugs.webkit.org/show_bug.cgi?id=31479
2735
2736         * Scripts/run-webkit-tests:
2737
2738 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2739
2740         Reviewed by Kenneth Christiansen.
2741
2742         [Qt] Implement load error pages support for Qt's DRT.
2743         https://bugs.webkit.org/show_bug.cgi?id=31509
2744
2745         For now, it will not be a default feature, and layout tests
2746         that want to make use of this have to explicitily call
2747         'handleErrorPages();' for the test source.
2748
2749         Any of the other DumpRenderTree's (mac, win and gtk)
2750         support handling error pages. Qt's will be the first.
2751
2752         * DumpRenderTree/qt/DumpRenderTree.cpp:
2753         (WebCore::WebPage::supportsExtension):
2754         (WebCore::WebPage::extension):
2755         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2756         (LayoutTestController::reset):
2757         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2758         (LayoutTestController::shouldHandleErrorPages):
2759         (LayoutTestController::handleErrorPages):
2760
2761 2009-11-16  Eric Seidel  <eric@webkit.org>
2762
2763         Reviewed by Adam Barth.
2764
2765         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2766         https://bugs.webkit.org/show_bug.cgi?id=31549
2767
2768         Renamed --commit-queue to --non-interactive in most places
2769         and remove the code in land-patches which is no longer needed.
2770
2771         * Scripts/bugzilla-tool:
2772
2773 2009-11-16  Eric Seidel  <eric@webkit.org>
2774
2775         Reviewed by Adam Barth.
2776
2777         The commit-queue should use land-attachment
2778         https://bugs.webkit.org/show_bug.cgi?id=31548
2779
2780         * Scripts/bugzilla-tool:
2781
2782 2009-11-16  Adam Barth  <abarth@webkit.org>
2783
2784         Reviewed by Eric Seidel.
2785
2786         Convert CommitQueue over to PatchCollection
2787         https://bugs.webkit.org/show_bug.cgi?id=31547
2788
2789         Also fixes a bug in workqueue and adds a test!
2790
2791         * Scripts/bugzilla-tool:
2792         * Scripts/modules/workqueue.py:
2793         * Scripts/modules/workqueue_unittest.py:
2794
2795 2009-11-16  Adam Barth  <abarth@webkit.org>
2796
2797         Reviewed by Eric Seidel.
2798
2799         Move StyleQueue over to using PatchCollection
2800         https://bugs.webkit.org/show_bug.cgi?id=31544
2801
2802         That's what the class it's for.
2803
2804         * Scripts/bugzilla-tool:
2805         * Scripts/modules/patchcollection.py:
2806         * Scripts/modules/patchcollection_unittest.py:
2807
2808 2009-11-16  Eric Seidel  <eric@webkit.org>
2809
2810         Reviewed by Adam Barth.
2811
2812         bugzilla-tool needs a land-attachment command
2813         https://bugs.webkit.org/show_bug.cgi?id=31546
2814
2815         * Scripts/bugzilla-tool:
2816          - Move all the logic into AbstractLandingCommand and
2817            add a new LandAttachment command subclass.
2818          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2819
2820 2009-11-16  Eric Seidel  <eric@webkit.org>
2821
2822         Reviewed by Adam Barth.
2823
2824         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2825         https://bugs.webkit.org/show_bug.cgi?id=31543
2826
2827         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2828
2829         * Scripts/bugzilla-tool:
2830
2831 2009-11-16  Eric Seidel  <eric@webkit.org>
2832
2833         Reviewed by Adam Barth.
2834
2835         Disable the style queue from posting to the commit queue status page.
2836
2837         * Scripts/bugzilla-tool:
2838
2839 2009-11-16  Adam Barth  <abarth@webkit.org>
2840
2841         Reviewed by Eric Seidel.
2842
2843         Implement PatchCollection
2844         https://bugs.webkit.org/show_bug.cgi?id=31541
2845
2846         This class holds a set of patches and lets clients iterate through
2847         them.  Optionally, clients can install a filter.
2848
2849         * Scripts/modules/patchcollection.py: Added.
2850         * Scripts/modules/patchcollection_unittest.py: Added.
2851         * Scripts/run-webkit-unittests:
2852
2853 2009-11-16  Eric Seidel  <eric@webkit.org>
2854
2855         Reviewed by Adam Barth.
2856
2857         bugzilla-tool land-patches will close bugs with patches r=?
2858         https://bugs.webkit.org/show_bug.cgi?id=28230
2859
2860         The commit-queue shouldn't close patches with outstanding reviews on them,
2861         even if many reviewers seem to be against multi-patch bugs.
2862
2863         * Scripts/bugzilla-tool:
2864
2865 2009-11-16  Eric Seidel  <eric@webkit.org>
2866
2867         Reviewed by Adam Barth.
2868
2869         bugzilla-tool check-style should work with attachment ids instead of bug ids
2870         https://bugs.webkit.org/show_bug.cgi?id=31540
2871
2872         * Scripts/bugzilla-tool:
2873
2874 2009-11-16  Eric Seidel  <eric@webkit.org>
2875
2876         Reviewed by Adam Barth.
2877
2878         WorkQueue is the only place that should know about special exit codes
2879         https://bugs.webkit.org/show_bug.cgi?id=31534
2880
2881         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2882         and add tests for handling exit codes.
2883         I also cleaned up workqueue_unittest.py more.
2884
2885         * Scripts/bugzilla-tool:
2886         * Scripts/modules/workqueue.py:
2887         * Scripts/modules/workqueue_unittest.py:
2888
2889 2009-11-16  Eric Seidel  <eric@webkit.org>
2890
2891         Reviewed by Adam Barth.
2892
2893         Re-factor workqueue_unittest to allow for more than one test.
2894         https://bugs.webkit.org/show_bug.cgi?id=31535
2895
2896         * Scripts/modules/workqueue_unittest.py:
2897
2898 2009-11-16  Eric Seidel  <eric@webkit.org>
2899
2900         Reviewed by Adam Barth.
2901
2902         land-patches needs to be re-factored into smaller chunks
2903         https://bugs.webkit.org/show_bug.cgi?id=31532
2904
2905         * Scripts/bugzilla-tool: fix a couple obvious typos.
2906
2907 2009-11-16  Eric Seidel  <eric@webkit.org>
2908
2909         Reviewed by Adam Barth.
2910
2911         land-patches needs to be re-factored into smaller chunks
2912         https://bugs.webkit.org/show_bug.cgi?id=31532
2913
2914         The next patch will move these methods into WebKitLandingScripts.
2915
2916         * Scripts/bugzilla-tool:
2917          - Split out _land_patch and _close_bug_if_no_active_patches.
2918
2919 2009-11-16  Adam Barth  <abarth@webkit.org>
2920
2921         Reviewed by Eric Seidel.
2922
2923         Fix silly copy-and-paste code.  I am a terrible coder.
2924
2925         * Scripts/modules/bugzilla.py:
2926
2927 2009-11-16  Adam Barth  <abarth@webkit.org>
2928
2929         Reviewed by Eric Seidel.
2930
2931         Implement a StyleQueue
2932         https://bugs.webkit.org/show_bug.cgi?id=31537
2933
2934         The first iteration of the style queue only produces output locally.
2935         There is also a limit of 10 patches because it's not that useful to
2936         iterate through the entire review queue at this point.  We can remove
2937         the limit later.
2938
2939         * Scripts/bugzilla-tool:
2940         * Scripts/modules/bugzilla.py:
2941
2942 2009-11-16  Adam Barth  <abarth@webkit.org>
2943
2944         Reviewed by Eric Seidel.
2945
2946         Unit test WorkQueue
2947         https://bugs.webkit.org/show_bug.cgi?id=31531
2948
2949         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
2950
2951         * Scripts/bugzilla-tool:
2952         * Scripts/modules/statusbot.py:
2953         * Scripts/modules/workqueue.py:
2954         * Scripts/modules/workqueue_unittest.py: Added.
2955         * Scripts/run-webkit-unittests:
2956
2957 2009-11-16  Eric Seidel  <eric@webkit.org>
2958
2959         Reviewed by Adam Barth.
2960
2961         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
2962         https://bugs.webkit.org/show_bug.cgi?id=31530
2963
2964         * Scripts/bugzilla-tool:
2965
2966 2009-11-16  Eric Seidel  <eric@webkit.org>
2967
2968         Reviewed by Adam Barth.
2969
2970         bugzilla-tool needs apply-attachment
2971         https://bugs.webkit.org/show_bug.cgi?id=31528
2972
2973         * Scripts/bugzilla-tool:
2974          - Add ApplyAttachment command.
2975          - Abstract applying code into WebKitApplyingScripts.
2976          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
2977         * Scripts/modules/bugzilla.py:
2978          - Add fetch_attachment and bug_id_for_attachment_id.
2979         * Scripts/modules/bugzilla_unittest.py:
2980          - Add test for new parsing.
2981          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
2982
2983 2009-11-16  Eric Seidel  <eric@webkit.org>
2984
2985         Reviewed by Adam Barth.
2986
2987         Document check-style's use of force_clean.
2988
2989         * Scripts/bugzilla-tool:
2990         * Scripts/modules/scm.py:
2991
2992 2009-11-16  Adam Barth  <abarth@webkit.org>
2993
2994         Reviewed by Eric Seidel.
2995
2996         Move WorkQueue to its own file
2997         https://bugs.webkit.org/show_bug.cgi?id=31529
2998
2999         WorkQueue and WorkQueueDelegate are separate concerns from
3000         bugzilla-tool.  Also added a missing include to logging.py.
3001
3002         * Scripts/bugzilla-tool:
3003         * Scripts/modules/logging.py:
3004         * Scripts/modules/workqueue.py:
3005
3006 2009-11-16  Adam Barth  <abarth@webkit.org>
3007
3008         Reviewed by Eric Seidel.
3009
3010         Move OutputTee to logging.py.
3011
3012         * Scripts/bugzilla-tool:
3013         * Scripts/modules/logging.py:
3014
3015 2009-11-15  Adam Barth  <abarth@webkit.org>
3016
3017         Reviewed by Eric Seidel.
3018
3019         Refactor bugzilla-tool to allow for multiple queues
3020         https://bugs.webkit.org/show_bug.cgi?id=31513
3021
3022         Divide the commit queue class into three class to make creating
3023         additional queues easier.
3024
3025         * Scripts/bugzilla-tool:
3026
3027 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3028
3029         Reviewed by Eric Seidel.
3030
3031         svn-apply may not handle git patches created by bugzilla-tool
3032         https://bugs.webkit.org/show_bug.cgi?id=31457
3033
3034         * Scripts/modules/scm.py:
3035         * Scripts/modules/scm_unittest.py:
3036
3037 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3038
3039         Reviewed by Eric Seidel.
3040
3041         bugzilla-tool should post git binary diff
3042         https://bugs.webkit.org/show_bug.cgi?id=31458
3043
3044         Add --binary option to Git.create_patch.
3045
3046         * Scripts/modules/scm.py:
3047         * Scripts/modules/scm_unittest.py:
3048
3049 2009-11-15  Adam Barth  <abarth@webkit.org>
3050
3051         Reviewed by Darin Adler.
3052
3053         Add bugzilla-tool check-style
3054         https://bugs.webkit.org/show_bug.cgi?id=31515
3055
3056         * Scripts/bugzilla-tool:
3057         * Scripts/modules/bugzilla.py:
3058
3059 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3060
3061         Reviewed by Simon Hausmann.
3062
3063         Make the Qt Linux only --valgrind feature, suppress errors
3064         defined in the SuppressedValgrindErrors file.
3065
3066         * Scripts/run-webkit-tests:
3067
3068 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3069
3070         Reviewed by Simon Hausmann.
3071
3072         Set the locale to C and not to the current one in use on the system.
3073
3074         * DumpRenderTree/qt/DumpRenderTree.cpp:
3075         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3076
3077 2009-11-13  Adam Roben  <aroben@apple.com>
3078
3079         Add support for
3080         http/tests/security/isolatedWorld/didClearWindowObject.html
3081
3082         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
3083         window objects in isolated worlds are cleared
3084
3085         Reviewed by Dave Hyatt.
3086
3087         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
3088
3089         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3090         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3091         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
3092         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
3093         Added. Sets a __worldID property on the global object whose value is
3094         the ID of this world.
3095         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
3096         Respond to this new delegate callback by calling through to one of the
3097         above new methods.
3098         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3099         (worldMap): Added. Returns a HashMap containing all the worlds we've
3100         created.
3101         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
3102         haven't kept track of this world.
3103         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
3104         instead of declaring our own.
3105
3106         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
3107
3108         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3109         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
3110         didClearWindowObjectForFrameInStandardWorld.
3111         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
3112         Respond to this new delegate callback by calling through to one of the
3113         below new methods.
3114         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
3115         Added. Sets a __worldID property on the gobal object whose value is
3116         the ID of this world.
3117         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
3118         Added. Moved code here from didClearWindowObject.
3119
3120         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
3121         didClearWindowObjectForFrame* functions.
3122
3123         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3124         (worldMap): Added. Returns a HashMap containing all the worlds we've
3125         created.
3126         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
3127         haven't kept track of this world.
3128         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
3129         instead of declaring our own.
3130
3131 2009-11-13  Adam Roben  <aroben@apple.com>
3132
3133         Finish replacing worldIDs with world objects
3134
3135         The only remaining use of worldIDs was in a method only used by DRT
3136         for the isolated worlds tests.
3137
3138         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
3139
3140         Reviewed by Mark Rowe.
3141
3142         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3143         (LayoutTestController::evaluateScriptInIsolatedWorld):
3144         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3145         (LayoutTestController::evaluateScriptInIsolatedWorld):
3146         Updated for changes to WebFrame. Now holds the map of worldID -> world
3147         at this level instead of making WebKit do it.
3148
3149 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3150
3151         Reviewed by Simon Hausmann.
3152
3153         [Qt] Ensure the DRT does not output anything until first test is run
3154
3155         * DumpRenderTree/qt/DumpRenderTree.cpp:
3156         * DumpRenderTree/qt/DumpRenderTree.h:
3157
3158 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3159
3160         Reviewed by Tor Arne Vestbø.
3161
3162         Clear the undo stack in before each new test run.
3163
3164         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
3165
3166         * DumpRenderTree/qt/DumpRenderTree.cpp:
3167         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3168
3169 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3170
3171         Reviewed by Kenneth Rohde Christiansen.
3172
3173         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
3174
3175         * DumpRenderTree/qt/DumpRenderTree.cpp:
3176         (WebCore::WebPage::resetSettings):
3177         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3178         (LayoutTestController::overridePreference):
3179
3180 2009-11-13  Eric Seidel  <eric@webkit.org>
3181
3182         Reviewed by Adam Barth.
3183
3184         Update committers.py based on svn records
3185         https://bugs.webkit.org/show_bug.cgi?id=31366
3186
3187         This list was generated using validate-committer-lists from
3188         https://bugs.webkit.org/show_bug.cgi?id=30970
3189         and makes committers.py current for committers who have
3190         committed in the last 3 years.
3191
3192         * Scripts/modules/committers.py:
3193
3194 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
3195
3196         Reviewed by Adam Barth.
3197
3198         The document-open.html test was flaky at times. The test invokes the layout test plugin
3199         which in its destroy stream handler opens a new document. This basically tears down the
3200         stream and the associated plugin instance. The pluginLog function in the layout test
3201         plugin attempts to retrieve the window script object on a torn down plugin instance
3202         which crashed consistently on windows in the debugger. The functions which issue
3203         these logs already have a valid window script object. We now have variants of the pluginLog
3204         function which take in a window script object with and without variable arguments. 
3205
3206         https://bugs.webkit.org/show_bug.cgi?id=31067
3207
3208         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3209         (pluginLogWithWindowObject):
3210         (pluginLogWithWindowObjectVariableArgs):
3211         (pluginLog):
3212         (notifyTestCompletion):
3213         (testDocumentOpen):
3214         (testWindowOpen):
3215
3216 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3217
3218         Reviewed by Gustavo Noronha Silva.
3219
3220         https://bugs.webkit.org/show_bug.cgi?id=30997
3221         [Gtk] Implemment AtkDocument
3222
3223         Added testing support.
3224
3225         * DumpRenderTree/AccessibilityUIElement.cpp:
3226         * DumpRenderTree/AccessibilityUIElement.h:
3227         (getDocumentEncodingCallback):
3228         (getDocumentURICallback):
3229         (AccessibilityUIElement::getJSClass):
3230         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3231         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3232         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3233         (AccessibilityUIElement::documentEncoding):
3234         (AccessibilityUIElement::documentURI):
3235
3236 2009-11-12  Adam Roben  <aroben@apple.com>
3237
3238         Replace worldIDs with world objects
3239
3240         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
3241         user scripts/stylesheets and isolated worlds
3242
3243         Reviewed by Sam Weinig.
3244
3245         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3246         (LayoutTestController::addUserScript):
3247         (LayoutTestController::addUserStyleSheet):
3248         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3249         (LayoutTestController::addUserScript):
3250         (LayoutTestController::addUserStyleSheet):
3251         Changed these functions to create a new WebJSWorld each time they're
3252         called and to pass that world to WebKit.
3253
3254 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
3255
3256         Reviewed by Oliver Hunt.
3257
3258         need to implement aria tree roles
3259         https://bugs.webkit.org/show_bug.cgi?id=31284
3260
3261         * DumpRenderTree/AccessibilityUIElement.cpp:
3262         (disclosedRowAtIndexCallback):
3263         (selectedRowAtIndexCallback):
3264         (isEqualCallback):
3265         (isAttributeSettableCallback):
3266         (isActionSupportedCallback):
3267         (disclosedByRowCallback):
3268         (hierarchicalLevelCallback):
3269         (AccessibilityUIElement::getJSClass):
3270         * DumpRenderTree/AccessibilityUIElement.h:
3271         (AccessibilityUIElement::isEqual):
3272         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3273         (AccessibilityUIElement::hierarchicalLevel):
3274         (AccessibilityUIElement::disclosedRowAtIndex):
3275         (AccessibilityUIElement::selectedRowAtIndex):
3276         (AccessibilityUIElement::disclosedByRow):
3277         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3278         (AccessibilityUIElement::getChildAtIndex):
3279         (AccessibilityUIElement::disclosedRowAtIndex):
3280         (AccessibilityUIElement::selectedRowAtIndex):
3281         (AccessibilityUIElement::titleUIElement):
3282         (AccessibilityUIElement::parentElement):
3283         (AccessibilityUIElement::disclosedByRow):
3284         (AccessibilityUIElement::hierarchicalLevel):
3285         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3286         (AccessibilityUIElement::hierarchicalLevel):
3287         (AccessibilityUIElement::disclosedRowAtIndex):
3288         (AccessibilityUIElement::selectedRowAtIndex):
3289         (AccessibilityUIElement::disclosedByRow):
3290
3291 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
3292
3293         Reviewed by Darin Adler.
3294
3295         svn-apply can not handle git binary diffs
3296         https://bugs.webkit.org/show_bug.cgi?id=26830
3297
3298         Support "literal" type git binary diffs.
3299
3300         * Scripts/VCSUtils.pm:
3301         * Scripts/modules/scm_unittest.py:
3302         * Scripts/svn-apply:
3303
3304 2009-11-11  Dmitry Titov  <dimich@chromium.org>
3305
3306         Not reviewed, removing duplicate entry for myself in committers.py.
3307
3308         * Scripts/modules/committers.py:
3309
3310 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
3311
3312         Reviewed by Darin Adler and Mark Rowe.
3313
3314         https://bugs.webkit.org/show_bug.cgi?id=31200
3315         Tests in http/tests/security/mixedContent start to fail when new tests are added
3316
3317         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
3318
3319 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3320
3321         Reviewed by Jan Alonzo.
3322
3323         Create, and display a window for the inspector, for inspector
3324         tests.
3325
3326         Need to also show/hide the inspector window to avoid having
3327         problems with code assuming it is realized
3328         https://bugs.webkit.org/show_bug.cgi?id=31347
3329
3330         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3331         (webInspectorShowWindow):
3332         (webInspectorCloseWindow):
3333         (webInspectorInspectWebView):
3334         (createWebView):
3335
3336 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3337
3338         Unreviewed Qt buildbot fix.
3339
3340         My previous fix was wrong, so revert that change and fix it by
3341         returning when the document of the frame has no document element.
3342         Idea is borrowed from mac and win DRT.
3343
3344         * DumpRenderTree/qt/DumpRenderTree.cpp:
3345         (WebCore::DumpRenderTree::dumpFramesAsText):
3346
3347 2009-11-11  Eric Seidel  <eric@webkit.org>
3348
3349         Reviewed byg Kenneth Rohde Christiansen.
3350
3351         Update Kenneth's committer record to include the email he
3352         uses on lists.webkit.org.
3353
3354         * Scripts/modules/committers.py:
3355
3356 2009-11-11  Eric Seidel  <eric@webkit.org>
3357
3358         Reviewed by Gustavo Noronha Silva.
3359
3360         Several committers use separate email addresses for bugzilla and svn.webkit.org
3361         https://bugs.webkit.org/show_bug.cgi?id=31364
3362
3363         Update records for existing committers to include email addresses
3364         used in svn.webkit.org and lists.webkit.org.
3365         Most committers use the same email address in all 3 places, but some use
3366         separate addresses.  committers.py needs record of each of these addresses.
3367
3368         * Scripts/modules/committers.py:
3369
3370 2009-11-11  Eric Seidel  <eric@webkit.org>
3371
3372         No review, adding second email address for an existing committer.
3373
3374         Add Yong Li's second bugzilla account to his committer record.
3375         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
3376
3377         * Scripts/modules/committers.py:
3378
3379 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3380
3381         Reviewed by Simon Hausmann.
3382
3383         If the frame has no innerText don't append it, and
3384         do not add a newline which breaks some cross platform
3385         results.
3386
3387         * DumpRenderTree/qt/DumpRenderTree.cpp:
3388         (WebCore::DumpRenderTree::dumpFramesAsText):
3389
3390 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3391
3392         Reviewed by Simon Hausmann.
3393
3394         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
3395
3396         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
3397         (webkit_test_plugin_new_instance):
3398         (webkit_test_plugin_destroy_instance):
3399         (webkit_test_plugin_destroy_stream):
3400
3401 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3402
3403         Reviewed by Mark Rowe.
3404
3405         Implement the functionality needed by plugins/window-open.html
3406
3407         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
3408         (webkit_test_plugin_new_instance):
3409         (webkit_test_plugin_set_window):
3410
3411 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3412
3413         Reviewed by Simon Hausmann.
3414
3415         [Qt] Force -graphicssystem raster and -style windows when running DRT
3416
3417         * DumpRenderTree/qt/main.cpp:
3418         * Scripts/run-webkit-tests:
3419
3420 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3421
3422         Reviewed by Simon Hausmann.
3423
3424         Compute correct library paths for Qt
3425
3426         * Scripts/webkitdirs.pm:
3427
3428 2009-11-10  Mark Rowe  <mrowe@apple.com>
3429
3430         Reviewed by Sam Weinig.
3431
3432         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
3433
3434         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
3435         about the validity of the self-signed certificates used in the regression tests.  We would then add the
3436         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
3437         that had enabled frame load delegate logging this would result in extra log messages being generated,
3438         causing the test to fail.
3439
3440         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
3441         tests.
3442
3443         * DumpRenderTree/mac/DumpRenderTree.mm:
3444         (dumpRenderTree):
3445         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3446         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3447
3448 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3449
3450         Reviewed by Kenneth Rohde Christiansen.
3451
3452         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
3453
3454         * DumpRenderTree/qt/DumpRenderTree.cpp:
3455         (WebCore::DumpRenderTree::DumpRenderTree):
3456
3457 2009-11-10  Philippe Normand  <pnormand@igalia.com>
3458
3459         Reviewed by Jan Alonzo.
3460
3461         [GTK] Remove WebSocket configuration from WebKitWebSettings
3462         https://bugs.webkit.org/show_bug.cgi?id=31244
3463
3464         Follow-up of r50724. Don't set the enable-web-socket property
3465         anymore.
3466
3467         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3468         (resetDefaultsToConsistentValues):
3469
3470 2009-11-10  Oliver Hunt  <oliver@apple.com>
3471
3472         Reviewed by Maciej Stachowiak.
3473
3474         Rename 3D Canvas related classes to use WebGL prefix
3475         https://bugs.webkit.org/show_bug.cgi?id=29095
3476
3477         Checkin new version of do-webcore-rename used to do the WebGL type rename,
3478         and upate webkitdirs script to new method of testing for WebGL.
3479
3480         * Scripts/do-webcore-rename:
3481         * Scripts/webkitdirs.pm:
3482
3483 2009-11-09  Oliver Hunt  <oliver@apple.com>
3484
3485         Reviewed by Geoff Garen.
3486
3487         Make do-webcore-rename work with git.
3488
3489         * Scripts/do-webcore-rename:
3490
3491 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3492
3493         Adding Kenneth to the reviewers list.
3494
3495         * Scripts/modules/committers.py:
3496
3497 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
3498
3499         Reviewed by Jan Alonzo.
3500
3501         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
3502         https://bugs.webkit.org/show_bug.cgi?id=30482
3503
3504         LayoutTestControllerGtk now uses the exposed
3505         Page::tabKeyCyclesThroughElements API
3506
3507         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3508         (LayoutTestController::setTabKeyCyclesThroughElements):
3509
3510 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
3511
3512         Reviewed by Holger Freyther.
3513
3514         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
3515         This helps to pass the test case below. Also replaced hardcoded
3516         code numbers with defined constants.
3517         https://bugs.webkit.org/show_bug.cgi?id=31185
3518         
3519         Test: editing/undo/undo-deleteWord.html
3520
3521         * DumpRenderTree/qt/EventSenderQt.cpp:
3522         (EventSender::keyDown):
3523
3524 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
3525
3526         Reviewed by Holger Freyther.
3527
3528         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
3529         https://bugs.webkit.org/show_bug.cgi?id=31164
3530
3531         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
3532
3533         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3534         (LayoutTestController::processWork):
3535
3536 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
3537
3538         Reviewed by Holger Freyther.
3539
3540         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
3541         https://bugs.webkit.org/show_bug.cgi?id=31158
3542
3543         By invoking a script queue'd by queueScript(), 'true' was beeing returned
3544         always, which from WorkQueue prospective means that a load has been started
3545         and the queue processing should stop and wait for the load to finish.
3546         Spinning it off into a loading and a non-loading variants was the solution
3547         adopted by Mac's DRT to work around this problem. The former keeps returning
3548         'true' while the later executes the script synchronously and returns 'false'
3549         making it possible to the WorkQueue to proceed right away.
3550
3551         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3552         (LayoutTestController::processWork):
3553         (LayoutTestController::queueLoadingScript):
3554         (LayoutTestController::queueNonLoadingScript):
3555         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3556         * DumpRenderTree/qt/WorkQueueItem.h:
3557         (LoadingScriptItem::LoadingScriptItem):
3558         (LoadingScriptItem::invoke):
3559         (NonLoadingScriptItem::NonLoadingScriptItem):
3560         (NonLoadingScriptItem::invoke):
3561
3562 2009-11-07  Mark Rowe  <mrowe@apple.com>
3563
3564         Rubber-stamped by Cameron Zwarich.
3565
3566         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
3567
3568         * Scripts/commit-log-editor:
3569
3570 2009-11-07  Mark Rowe  <mrowe@apple.com>
3571
3572         Reviewed by Darin Adler.
3573
3574         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
3575         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
3576
3577         Move logic for determining the name and email address to use in a ChangeLog entry from
3578         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
3579         whether the author of the patch matches committer, and therefore needs access to the
3580         email address that would be used in a ChangeLog entry.
3581
3582         Based on a patch by Pierre d'Herbemont.
3583
3584         * Scripts/VCSUtils.pm:
3585         * Scripts/commit-log-editor:
3586         * Scripts/prepare-ChangeLog:
3587         * Scripts/webkitdirs.pm:
3588
3589 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3590
3591         Reviewed by Adam Barth.
3592
3593         Added functionality to the layout test plugin to invoke document.open and
3594         window.open with default arguments. The associated webkit bug is
3595         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
3596         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
3597         work in Chromium (V8) if there is no calling javascript context. To achieve this
3598         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
3599         for the window.open test case and in NPP_DestroyStream for the document.open test case.
3600
3601         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3602         (testDocumentOpen):
3603         (testWindowOpen):
3604         (pluginAllocate):
3605         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3606         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3607         (NPP_New):
3608         (NPP_SetWindow):
3609         (NPP_DestroyStream):
3610         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3611         (NPP_New):
3612         (NPP_SetWindow):
3613         (NPP_NewStream):
3614         (NPP_DestroyStream):
3615
3616 2009-11-06  Eric Seidel  <eric@webkit.org>
3617
3618         Reviewed by Adam Barth.
3619
3620         bugzilla-tool crashed with exception
3621         https://bugs.webkit.org/show_bug.cgi?id=31092
3622
3623         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
3624
3625 2009-11-04  Eric Seidel  <eric@webkit.org>
3626
3627         No review, just add a line which got left out of the patch uploaded for commit.
3628
3629         commit-queue is crashing when trying to reject patches after unknown failures
3630         https://bugs.webkit.org/show_bug.cgi?id=31091
3631
3632         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
3633
3634 2009-11-04  Adam Roben  <aroben@apple.com>
3635
3636         Remove bogus else clause in bugzilla-tool
3637
3638         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
3639         create-bug raises exception after entering bug description
3640
3641         Reviewed by David Kilzer.
3642
3643         * Scripts/bugzilla-tool:
3644         (CreateBug): else clauses are only hit if no exception is raised, so
3645         it makes no sense to try to re-raise the exception in an else clause.
3646         The exception will automatically be re-raised if it doesn't match any
3647         of the except clauses, so we don't have to do anything special here at
3648         all to get the desired behavior.
3649
3650 2009-11-04  Eric Seidel  <eric@webkit.org>
3651
3652         Reviewed by David Kilzer.
3653
3654         svn-apply's fixChangeLogPatch function seems broken
3655         https://bugs.webkit.org/show_bug.cgi?id=30683
3656
3657         Update fixChangeLogPatch to be able to handle patches which
3658         don't start at line 1.
3659         Add unit tests for svn-apply to scm_unittest.py.
3660
3661         * Scripts/VCSUtils.pm:
3662         * Scripts/modules/scm_unittest.py:
3663
3664 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3665
3666         Reviewed by Beth Dakin.
3667
3668         Need to implement ARIA role="combobox"
3669         https://bugs.webkit.org/show_bug.cgi?id=31096
3670
3671         * DumpRenderTree/AccessibilityUIElement.cpp:
3672         (showMenuCallback):
3673         (getIsExpandedCallback):
3674         (AccessibilityUIElement::getJSClass):
3675         * DumpRenderTree/AccessibilityUIElement.h:
3676         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3677         (AccessibilityUIElement::isExpanded):
3678         (AccessibilityUIElement::showMenu):
3679         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3680         (AccessibilityUIElement::isExpanded):
3681         (AccessibilityUIElement::showMenu):
3682         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3683         (AccessibilityUIElement::isSelected):
3684         (AccessibilityUIElement::isExpanded):
3685         (AccessibilityUIElement::showMenu):
3686
3687 2009-11-04  Eric Seidel  <eric@webkit.org>
3688
3689         Reviewed by Adam Barth.
3690
3691         commit-queue is crashing when trying to reject patches after unknown failures
3692         https://bugs.webkit.org/show_bug.cgi?id=31091
3693
3694         * Scripts/bugzilla-tool:
3695          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
3696            so we have to find out what the current patch is by asking bugzilla again.
3697          - Discovered that this code was also leaking file descriptors, so fixed that.
3698
3699 2009-11-04  Adam Roben  <aroben@apple.com>
3700
3701         Make run-webkit-tests work for the Debug_Internal Windows
3702         configuration
3703
3704         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
3705         suffix.
3706
3707         Fixes <http://webkit.org/b/31123>.
3708
3709         Reviewed by Sam Weinig.
3710
3711         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3712         Debug_Internal, either.
3713
3714 2009-11-04  Eric Seidel  <eric@webkit.org>
3715
3716         Reviewed by Adam Barth.
3717
3718         committers.py needs a way to store non-bugzilla email addresses
3719         https://bugs.webkit.org/show_bug.cgi?id=31037
3720
3721         Make Committer and Reviewer constructors take a single email or a list of emails.
3722         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3723         Expose reviewers(), used by validate-committer-lists on bug 30970.
3724
3725         * Scripts/modules/committers.py:
3726         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3727
3728 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3729
3730         Reviewed by David Levin.
3731
3732         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3733         https://bugs.webkit.org/show_bug.cgi?id=27491
3734
3735         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3736         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3737
3738         Functions to start or stop Web Socket servers are added.
3739
3740         * Scripts/run-webkit-tests:
3741
3742 2009-11-03  Eric Seidel  <eric@webkit.org>
3743
3744         No review, just changing wording of log message.
3745
3746         Change log string to say "failed" instead of "rejected"
3747         when a commit fails due to an out of date checkout.
3748         This makes grepping the commit-queue log for rejected patches easier.
3749
3750         * Scripts/bugzilla-tool:
3751
3752 2009-11-03  Eric Seidel  <eric@webkit.org>
3753
3754         No review, adding commonly known committers missing from the file.
3755
3756         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3757
3758 2009-11-03  Eric Seidel  <eric@webkit.org>
3759
3760         No review, just sort-order cleanup.
3761
3762         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3763
3764 2009-11-03  Stephen White  <senorblanco@chromium.org>
3765
3766         (Unreviewed).
3767
3768         Add myself to committers.py.