Teach resolve-ChangeLogs to act as a merge-driver for Git
[WebKit.git] / WebKitTools / ChangeLog
1 2010-02-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2
3         Reviewed by Eric Seidel.
4
5         Teach resolve-ChangeLogs to act as a merge-driver for Git
6
7         https://bugs.webkit.org/show_bug.cgi?id=28721
8
9         To enable automatic merging of ChangeLog files, use the following command:
10
11         git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"
12
13         The driver always works in "downstream" merge mode, meaning
14         it will always put the user's changelog entries on top.
15
16         * Scripts/resolve-ChangeLogs:
17
18 2009-12-05  Gustavo Noronha Silva  <gns@gnome.org>
19
20         Reviewed by Eric Seidel.
21
22         Enable running of GTK+ API tests.
23
24         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
25         * Scripts/run-gtk-tests: Added.
26
27 2010-02-18  Shinichiro Hamaji  <hamaji@chromium.org>
28
29         Reviewed by Adam Barth.
30
31         debug-safari doesn't pass --debug option to gdb-safari on MacOSX
32         https://bugs.webkit.org/show_bug.cgi?id=34411
33
34         * Scripts/webkitdirs.pm:
35
36 2010-02-18  Eric Seidel  <eric@webkit.org>
37
38         Reviewed by Adam Barth.
39
40         run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
41         https://bugs.webkit.org/show_bug.cgi?id=35053
42
43         * Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
44         * Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
45         * Scripts/webkitpy/layout_tests/port/mac.py:
46          - Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
47          - Call build-dumprendertree (and make sure it succeeds) before running the tests.
48
49 2010-02-16  Chris Jerdonek  <cjerdonek@webkit.org>
50
51         Reviewed by Shinichiro Hamaji.
52
53         Refactored check-webkit-style's ProcessorOptions class into two
54         classes. This revision contains no new functionality.
55
56         https://bugs.webkit.org/show_bug.cgi?id=34674
57
58         Divided the ProcessorOptions class into a CommandOptionValues
59         class (the result of parsing the command-line options) and
60         a StyleCheckerConfiguration class (which configures the main
61         StyleChecker).
62
63         * Scripts/check-webkit-style:
64           - Updated main() to convert the parsed command option values
65             to a StyleCheckConfiguration instance prior to constructing
66             a StyleChecker.
67
68         * Scripts/webkitpy/style/checker.py:
69           - Added check_webkit_style_configuration() to convert a
70             CommandOptionValues instance into a StyleCheckerConfiguration
71             instance.
72           - Renamed the ProcessorOptions class to CommandOptionValues.
73           - In the CommandOptionValues class--
74             - Replaced the filter_configuration attribute with the
75               simpler filter_rules attribute.
76             - Removed the max_reports_per_error attribute.
77             - Moved the is_reportable() method to the new
78               StyleCheckerConfiguration class.
79           - Removed the base_filter_rules attribute from the
80             DefaultCommandOptionValues class.
81           - In the ArgumentParser class--
82             - Added base_filter_rules to the constructor.
83             - Changed the parse() method to return a CommandOptionValues
84               instance instead of a ProcessorOptions instance.
85           - Created a StyleCheckerConfiguration class.
86             - Added the data attributes max_reports_per_category,
87               stderr_write, and verbosity.
88             - Added is_reportable() (moved from the ProcessorOptions
89               class) and write_style_error() (moved from the
90               DefaultStyleErrorHandler class).
91           - In the StyleChecker class--
92             - Replaced the ProcessorOptions options attribute with the
93               StyleCheckerConfiguration _configuration attribute.
94             - Removed the _stderr_write attribute.
95
96         * Scripts/webkitpy/style/checker_unittest.py:
97           - Updated the existing unit test classes as necessary.
98           - Added a StyleCheckerConfigurationTest class.
99
100         * Scripts/webkitpy/style/error_handlers.py:
101           - Updated the DefaultStyleErrorHandler class to accept a
102             StyleCheckerConfiguration instance instead of a ProcessorOptions
103             instance and an stderr_write method.
104
105         * Scripts/webkitpy/style/error_handlers_unittest.py:
106           - Updated the unit test classes as necessary.
107
108         * Scripts/webkitpy/style/filter.py:
109           - Addressed the FIXME in the FilterConfiguration class to change
110             the user_rules attribute to _user_rules (since it is now
111             accessed only internally).
112
113         * Scripts/webkitpy/style/filter_unittest.py:
114           - Updated to reflect the change from user_rules to _user_rules.
115
116 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
117
118         Reviewed by Eric Seidel.
119
120         Share the DRT values maxViewWidth/Height among ports
121         https://bugs.webkit.org/show_bug.cgi?id=34474
122
123         * DumpRenderTree/LayoutTestController.cpp:
124         (pageNumberForElementByIdCallback):
125         * DumpRenderTree/LayoutTestController.h:
126         (LayoutTestController::maxViewWidth):
127         (LayoutTestController::maxViewHeight):
128         * DumpRenderTree/gtk/DumpRenderTree.cpp:
129         (runTest):
130         * DumpRenderTree/mac/DumpRenderTree.mm:
131         (createWebViewAndOffscreenWindow):
132         (sizeWebViewForCurrentTest):
133         * DumpRenderTree/win/DumpRenderTree.cpp:
134         (dump):
135         (createWebViewAndOffscreenWindow):
136
137 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
138
139         Reviewed by Eric Seidel.
140
141         [Win] Implement test functions for printing
142         https://bugs.webkit.org/show_bug.cgi?id=34570
143
144         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
145         (LayoutTestController::pageNumberForElementById):
146         (LayoutTestController::numberOfPages):
147
148 2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>
149
150         Reviewed by Eric Seidel.
151
152         websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
153         https://bugs.webkit.org/show_bug.cgi?id=35001
154
155         * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.
156
157 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
158
159         Reviewed by Eric Seidel.
160
161         check-webkit-style: Misses variables that contain underscores.
162         https://bugs.webkit.org/show_bug.cgi?id=33724
163
164         - Check identifiers whose types are unsigned.
165         - Check bitfields properly.
166
167         * Scripts/webkitpy/style/processors/cpp.py:
168         * Scripts/webkitpy/style/processors/cpp_unittest.py:
169
170 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
171
172         Reviewed by Eric Seidel.
173
174         check-webkit-style should report the number of files checked
175         https://bugs.webkit.org/show_bug.cgi?id=34971
176
177         * Scripts/check-webkit-style:
178         * Scripts/webkitpy/style/checker.py:
179         * Scripts/webkitpy/style/checker_unittest.py:
180
181 2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>
182
183         Reviewed by Ariya Hidayat.
184
185         Make possible Qt DRT to get total number of pages to be printed
186
187         LayoutTests:
188             printing/numberOfPages.html
189
190         [Qt] DRT: Get total number of pages to be printed
191         https://bugs.webkit.org/show_bug.cgi?id=34955
192
193         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
194         (LayoutTestController::numberOfPages):
195         * DumpRenderTree/qt/LayoutTestControllerQt.h:
196
197 2010-02-17  Xan Lopez  <xlopez@igalia.com>
198
199         Reviewed by Gustavo Noronha.
200
201         Update to use new property name.
202
203         * DumpRenderTree/gtk/DumpRenderTree.cpp:
204         (resetDefaultsToConsistentValues):
205
206 2010-02-17  Julien Chaffraix  <jchaffraix@webkit.org>
207
208         Reviewed by Ariya Hidayat.
209
210         Remove some warnings seen when building Qt
211         https://bugs.webkit.org/show_bug.cgi?id=35017
212
213         Using a machine without the needed tools to build WebKit leads to
214         several errors and warnings.
215
216         * Scripts/webkitdirs.pm: Refactored the code testing the command's
217         presence into a commandExists routine. While doing so removed, stderr
218         output as it usually does not give anything more than our message. Also
219         added a Qt check for qmake that was missing.
220
221 2010-02-17  Xan Lopez  <xlopez@igalia.com>
222
223         Rubber-stamped by Gustavo Noronha.
224
225         Disable Java by default in DRT.
226
227         * DumpRenderTree/gtk/DumpRenderTree.cpp:
228         (resetDefaultsToConsistentValues):
229
230 2010-02-15  Chris Jerdonek  <cjerdonek@webkit.org>
231
232         Reviewed by Shinichiro Hamaji.
233
234         Some minor check-webkit-style code clean-ups.  This revision
235         contains no new functionality.
236
237         https://bugs.webkit.org/show_bug.cgi?id=34932
238
239         * Scripts/check-webkit-style:
240           - Replaced the call to webkit_argument_defaults() with a
241             default parameter in the ArgumentParser constructor.
242
243         * Scripts/webkitpy/style/checker.py:
244           - Removed the WEBKIT prefix from the default global variables.
245           - Prefixed several of the global variables with an underscore
246             to reflect that they are used internally.
247           - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
248           - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER
249             configuration from list-tuple pairs to list-list pairs.
250           - Renamed style_categories() to _all_categories().
251           - Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
252           - Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
253           - In the ArgumentParser class--
254             - Renamed the doc_print attribute to stderr_write.
255             - Other minor updates.
256
257         * Scripts/webkitpy/style/checker_unittest.py:
258           - Updated the import statements and unit test classes as necessary.
259           - Added assertions to test _PATH_RULES_SPECIFIER more fully.
260
261         * Scripts/webkitpy/style/error_handlers_unittest.py:
262           - Updated the unit test classes as necessary.
263           - Changed StyleErrorHandlerTestBase to store a list of error
264             messages rather than just the last one.
265
266         * Scripts/webkitpy/style/filter.py:
267           - Altered FilterConfiguration._path_rules_from_path()
268             to convert the path_rules list to a tuple.
269
270         * Scripts/webkitpy/style/filter_unittest.py:
271           - Updated the unit tests to reflect the change from tuples to
272             lists in the _PATH_RULES_SPECIFIER configuration variable.
273
274 2010-02-16  Mark Rowe  <mrowe@apple.com>
275
276         Let's not check garbage in to common build scripts and hose the world now eh guys?
277
278         * Scripts/webkitdirs.pm:
279
280 2010-02-16  Eric Seidel  <eric@webkit.org>
281
282         Reviewed by Adam Barth.
283
284         re-factor Skipped list parsing code into multiple functions and unit test it
285         https://bugs.webkit.org/show_bug.cgi?id=34986
286
287         * Scripts/test-webkitpy: Add new unit test.
288         * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
289         * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
290         * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
291
292 2010-02-16  Xan Lopez  <xlopez@igalia.com>
293
294         Reviewed by Gustavo Noronha.
295
296         Enable 'auto-resize-window' in our DRT.
297
298         * DumpRenderTree/gtk/DumpRenderTree.cpp:
299         (resetDefaultsToConsistentValues):
300
301 2010-02-15  Martin Robinson  <mrobinson@webkit.org>
302
303         Reviewed by Darin Adler.
304
305         check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
306         https://bugs.webkit.org/show_bug.cgi?id=34834
307
308         * Scripts/webkitpy/style/processors/cpp.py:
309         * Scripts/webkitpy/style/processors/cpp_unittest.py:
310
311 2010-02-12  Alexey Proskuryakov  <ap@apple.com>
312
313         Reviewed by Kevin Decker.
314
315         <rdar://problem/7130641> Browser objects identity is not preserved by Safari
316
317         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
318         (pluginInvoke): Added methods for checking object identity (via refcount).
319
320 2010-02-15  Robert Hogan  <robert@roberthogan.net>
321
322         Reviewed by Simon Hausmann.
323
324         [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
325
326         Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
327
328         https://bugs.webkit.org/show_bug.cgi?id=33096
329
330         This allows the following tests to pass:
331
332         inspector/console-format-collections.html
333         inspector/styles-iframe.html
334         inspector/syntax-highlight-css.html
335         inspector/syntax-highlight-javascript.html
336         inspector/timeline-enum-stability.html
337         inspector/timeline-layout.html
338         inspector/timeline-mark-timeline.html
339         inspector/timeline-paint.html
340         inspector/timeline-parse-html.html
341         inspector/timeline-recalculate-styles.html
342         inspector/timeline-script-tag-1.html
343         inspector/timeline-script-tag-2.html
344         inspector/timeline-trivial.html
345         inspector/cookie-resource-match.html
346         inspector/elements-img-tooltip.html
347         inspector/elements-panel-selection-on-refresh.html
348         inspector/inspected-objects-not-overriden.html
349         inspector/timeline-event-dispatch.html
350         inspector/timeline-network-resource.html
351         inspector/elements-panel-rewrite-href.html
352         inspector/console-dir.html
353         inspector/console-dirxml.html
354         inspector/console-format.html
355         inspector/console-tests.html
356         inspector/elements-panel-structure.html
357         inspector/evaluate-in-frontend.html
358         inspector/console-clear.html
359
360         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
361         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
362         (WebCore::isWebInspectorTest):
363         (WebCore::DumpRenderTree::open):
364         * DumpRenderTree/qt/DumpRenderTreeQt.h:
365         (WebCore::DumpRenderTree::display):
366         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
367         (LayoutTestController::closeWebInspector):
368         (LayoutTestController::showWebInspector):
369         (LayoutTestController::evaluateInWebInspector):
370         (LayoutTestController::setTimelineProfilingEnabled):
371         (LayoutTestController::display):
372         * DumpRenderTree/qt/LayoutTestControllerQt.h:
373
374 2010-02-14  Dirk Pranke  <dpranke@chromium.org>
375
376         Reviewed by Eric Seidel.
377
378         Update rebaseline-chromium-webkit-tests to work with the new code
379         structure (port objects instead of path_utils and platform_utils).
380
381         Added a path_to_test_expectations_file() to the Port interface.
382   
383         Fixed a bug in the chromium_* platform implementations where the
384         'target' option was assumed to be set.
385
386         * Scripts/rebaseline-chromium-webkit-tests:
387         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
388         * Scripts/webkitpy/layout_tests/port/base.py:
389         * Scripts/webkitpy/layout_tests/port/chromium.py:
390         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
391         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
392         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
393         * Scripts/webkitpy/layout_tests/port/test.py:
394         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
395
396 2010-02-14  Eric Seidel  <eric@webkit.org>
397
398         Reviewed by Darin Adler.
399
400         webkit-build-directory misuses terms
401         https://bugs.webkit.org/show_bug.cgi?id=34822
402
403         * Scripts/webkit-build-directory:
404          - Add --top-level and --configuration options and make using one of them required.
405         * Scripts/webkitpy/layout_tests/port/mac.py:
406          - Use --top-level instead of --base.
407
408 2010-02-14  Chang Shu  <Chang.Shu@nokia.com>
409
410         Reviewed by Laszlo Gombos.
411
412         [Qt] Enable appcache feature.
413         https://bugs.webkit.org/show_bug.cgi?id=34713
414
415         Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
416         Persistent storage for AppCache is already initialized in
417         DumpRenderTreeQt.cpp.
418
419         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
420         (WebCore::WebPage::WebPage):
421
422 2010-02-12  Chang Shu  <Chang.Shu@nokia.com>
423
424         Not Reviewed.
425
426         Change case of my email address as a work-around for the following bug.
427         https://bugs.webkit.org/show_bug.cgi?id=34717
428
429         * Scripts/webkitpy/committers.py:
430
431 2010-02-12  Darin Adler  <darin@apple.com>
432
433         Ignore compiled Python in more of webkitpy.
434
435         * Scripts/webkitpy/style/processors: Added property svn:ignore.
436
437 2010-02-12  Diego Gonzalez  <diego.gonzalez@openbossa.org>
438
439         Reviewed by Kenneth Rohde Christiansen.
440
441         Qt DRT now dump the frame loader callbacks when LayoutTestController()
442         method is called.
443
444         LayoutTests:
445             http/tests/security/mixedContent/data-url-script-in-iframe.html
446             http/tests/security/mixedContent/empty-url-plugin-in-frame.html
447             http/tests/security/mixedContent/insecure-css-in-iframe.html
448             http/tests/security/mixedContent/insecure-iframe-in-iframe.html
449             http/tests/security/mixedContent/insecure-image-in-iframe.html
450             http/tests/security/mixedContent/insecure-plugin-in-iframe.html
451             http/tests/security/mixedContent/insecure-script-in-iframe.html
452             http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
453             http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
454
455         [Qt] Make possible Qt DRT dump frame load callbacks
456         https://bugs.webkit.org/show_bug.cgi?id=34702
457
458         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
459         (LayoutTestController::reset):
460         (LayoutTestController::dumpFrameLoadCallbacks):
461         * DumpRenderTree/qt/LayoutTestControllerQt.h:
462
463 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
464
465         Reviewed by Antti Koivisto.
466
467         Make QtLauncher somewhat useable on S60.
468
469         Show the window fullscreen to make scrollbars appear, resize
470         the toolbar buttons to 16x16 to give more screen space to
471         web content and moved the location lineedit into a separate
472         line.
473
474         * QtLauncher/main.cpp:
475         (LauncherWindow::LauncherWindow):
476         * QtLauncher/mainwindow.cpp:
477         (MainWindow::buildUI):
478
479 2010-02-12  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
480
481         Reviewed by Kenneth Rohde Christiansen.
482
483         Support frameset flattening
484         https://bugs.webkit.org/show_bug.cgi?id=32717
485
486         Add FrameSet Flattening support to Mac DRT.
487
488         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
489         (LayoutTestController::setFrameSetFlatteningEnabled):
490         * DumpRenderTree/win/DumpRenderTree.cpp:
491         (resetDefaultsToConsistentValues):
492         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
493         (LayoutTestController::setXSSAuditorEnabled):
494         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
495         (LayoutTestController::setFrameSetFlatteningEnabled):
496         * DumpRenderTree/LayoutTestController.cpp:
497         (setFrameSetFlatteningEnabledCallback):
498         (LayoutTestController::staticFunctions):
499         * DumpRenderTree/LayoutTestController.h:
500         * DumpRenderTree/mac/DumpRenderTree.mm:
501         (resetDefaultsToConsistentValues):
502         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
503         (LayoutTestController::setFrameSetFlatteningEnabled):
504
505 2010-02-12  Dirk Pranke  <dpranke@chromium.org>
506
507         Reviewed by Eric Seidel.
508
509         Fix typos in driver_test.py 
510
511         https://bugs.webkit.org/show_bug.cgi?id=34810
512
513         * Scripts/webkitpy/layout_tests/driver_test.py:
514
515 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
516
517         Reviewed by Kenneth Rohde Christiansen.
518
519         [Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time
520         https://bugs.webkit.org/show_bug.cgi?id=34844
521
522         * QtLauncher/main.cpp:
523         (LauncherWindow::LauncherWindow):
524         (LauncherWindow::initializeView):
525         (LauncherWindow::setupUI):
526         * QtLauncher/webview.cpp:
527         (WebViewGraphicsBased::WebViewGraphicsBased):
528
529 2010-02-11  Fumitoshi Ukai  <ukai@chromium.org>
530
531         Reviewed by Alexey Proskuryakov.
532
533         WebSocket ignores HttpOnly cookies, but should use in Handshake.
534         https://bugs.webkit.org/show_bug.cgi?id=34289
535
536         Update pywebsocket to 0.4.8, which supports cgi directories.
537         run-webkit-tests and run-webkit-websocketserver will run
538         pywebsocket, specifying /websocket/test/cookies as cgi directory.
539
540         * Scripts/run-webkit-tests:
541         * Scripts/run-webkit-websocketserver:
542         * pywebsocket/mod_pywebsocket/standalone.py:
543         * pywebsocket/setup.py:
544
545 2010-02-11  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
546
547         Reviewed by Dan Bernstein.
548
549         [Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT
550         https://bugs.webkit.org/show_bug.cgi?id=34798
551
552         Remove duplicated setXSSAuditorEnabled preference at Mac DRT
553
554         * DumpRenderTree/mac/DumpRenderTree.mm:
555         (resetDefaultsToConsistentValues):
556
557 2010-02-11  Eric Seidel  <eric@webkit.org>
558
559         No review, build fix only.
560
561         webkitdirs.pm has a crazy amount of duplicated feature detection code
562         https://bugs.webkit.org/show_bug.cgi?id=34869
563
564         * Scripts/build-webkit: Fix typo which broke bots.
565
566 2010-02-11  Eric Seidel  <eric@webkit.org>
567
568         Reviewed by Adam Barth.
569
570         webkitdirs.pm has a crazy amount of duplicated feature detection code
571         https://bugs.webkit.org/show_bug.cgi?id=34869
572
573         * Scripts/build-webkit: Use the new hotness.
574         * Scripts/run-webkit-tests: ditto
575         * Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
576         * Scripts/webkitperl/features.pm: Added.
577          - Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.
578
579 2010-02-11  Daniel Bates  <dbates@rim.com>
580
581         Reviewed by Adam Barth.
582
583         https://bugs.webkit.org/show_bug.cgi?id=34830
584
585         Makes method User.prompt static and adds the parameter repeat
586         to prompt the user up to repeat times.
587
588         * Scripts/test-webkitpy:
589         * Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
590         * Scripts/webkitpy/commands/upload.py: Ditto
591         * Scripts/webkitpy/credentials.py: Ditto
592         * Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
593         * Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
594         * Scripts/webkitpy/user_unittest.py: Added.
595
596 2010-02-10  Yuzo Fujishima  <yuzo@google.com>
597
598         Reviewed by Darin Adler.
599
600         Allow underscored identifiers in CSSParser.cpp
601
602         Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
603         WebCore/css/CSSParser.cpp needs to handle some such identifiers.
604         We should relax the style rule for the file to allow underscored identifiers.
605
606         https://bugs.webkit.org/show_bug.cgi?id=34787
607
608         * Scripts/webkitpy/style/checker.py:
609
610 2010-02-11  Eric Seidel  <eric@webkit.org>
611
612         Rubber-stamped by Adam Barth.
613
614         Remove DrawTest, the application I used when bringing up SVG support on the Mac.
615         The code hasn't been touched (or used) in years.  No sense in keeping it in trunk.
616
617         * Scripts/build-drawtest: Removed.
618         * Scripts/run-drawtest: Removed.
619         * DrawTest: Removed.
620
621 2010-02-11  Eric Seidel  <eric@webkit.org>
622
623         Reviewed by Adam Barth.
624
625         Need a command to clear r+ on obsolete patches in the pending-commit queue.
626         https://bugs.webkit.org/show_bug.cgi?id=34863
627
628         Unfortunately our http://webkit.org/pending-commit bugzilla query is not
629         smart enough to ignore obsolete patches, so bugs show up there which are
630         still open, but do not have patches ready for landing on them.
631         This new command "clean-pending-commit" will remove r+ from obsolete patches
632         in the pending-commit list.
633
634         * Scripts/test-webkitpy: Add grammar_unittest
635         * Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
636         * Scripts/webkitpy/grammar.py: Add join_with_separators
637         * Scripts/webkitpy/grammar_unittest.py: Added.
638
639 2010-02-11  Eric Seidel  <eric@webkit.org>
640
641         Reviewed by Adam Barth.
642
643         run-chromium-webkit-tests fails random pixel tests on Mac
644         https://bugs.webkit.org/show_bug.cgi?id=34862
645
646         This is due to the fact that the Mac port has an
647         invalid path to the image diff tool.  Currently it points
648         to image_diff even though ImageDiff would be correct.  We
649         can't change it to the right path yet without causing the
650         script to hang.  ImageDiff expects to be long-running and
651         be passed image data over stdin.  image_diff (chromium's fork)
652         expects to be passed command line arguments.
653         This fix works around the random failures by disabling pixel
654         tests on mac and logging if the user was trying to run with pixel
655         tests enabled.
656
657         * Scripts/webkitpy/layout_tests/port/mac.py:
658
659 2010-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
660
661         Reviewed by Adam Roben.
662         Try to fix build breakage from r54665.
663         
664         * Scripts/check-for-global-initializers:
665
666 2010-02-11  Simon Hausmann  <simon.hausmann@nokia.com>
667
668         Reviewed by Tor Arne Vestbø.
669
670         Make it possible to toggle accelerated compositing from the menu
671         at run-time.
672
673         * QtLauncher/main.cpp:
674         (LauncherWindow::toggleAcceleratedCompositing):
675         (LauncherWindow::setupUI):
676
677 2010-02-08  Maciej Stachowiak  <mjs@apple.com>
678
679         Reviewed by Cameron Zwarich.
680
681         Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
682         https://bugs.webkit.org/show_bug.cgi?id=34698
683
684         * Scripts/build-webkit:
685
686 2010-02-10  Dirk Pranke  <dpranke@chromium.org>
687
688         Reviewed by Eric Seidel.
689
690         Fix various minor bugs keeping run-chromium-webkit-tests from actually
691         working on the linux and win ports of Chromium.
692
693         https://bugs.webkit.org/show_bug.cgi?id=34739
694
695         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
696         * Scripts/webkitpy/layout_tests/port/__init__.py:
697         * Scripts/webkitpy/layout_tests/port/base.py:
698         * Scripts/webkitpy/layout_tests/port/chromium.py:
699         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
700         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
701         * Scripts/webkitpy/layout_tests/port/http_server.py:
702         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
703
704 2010-02-10  Eric Seidel  <eric@webkit.org>
705
706         Reviewed by David Levin.
707
708         run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
709         https://bugs.webkit.org/show_bug.cgi?id=34817
710
711         This doesn't fix the root cause of us not
712         correctly failing when support binaries are missing.
713         This only causes the DumpRenderTree binary not to be
714         missing in the custom build directory case.
715         Later patches will make us correctly fail fast when
716         support binaries (like DumpRenderTree or ImageDiff) are missing.
717
718         * Scripts/webkit-build-directory: Added.
719          - Need a way to re-use the perl logic for finding build directories in non-perl scripts.
720         * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
721         * Scripts/webkitpy/layout_tests/port/mac.py:
722          - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
723         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
724
725 2010-02-10  Kevin Watters  <kevinwatters@gmail.com>
726
727         Reviewed by Kevin Ollivier.
728
729         [wx] Add Windows complex text support.
730         
731         https://bugs.webkit.org/show_bug.cgi?id=34759
732
733         * wx/build/settings.py:
734
735 2010-02-10  Kevin Ollivier  <kevino@theolliviers.com>
736
737         [wx] Build fix. Add stub for new LayoutTestController method.
738
739         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
740         (LayoutTestController::numberOfPages):
741
742 2010-02-10  Csaba Osztrogonác  <ossy@webkit.org>
743
744         Unreviewed. Roll out r54626, because it broke GTK and Win build.
745         https://bugs.webkit.org/show_bug.cgi?id=32717
746
747         * DumpRenderTree/LayoutTestController.cpp:
748         (LayoutTestController::staticFunctions):
749         * DumpRenderTree/LayoutTestController.h:
750         * DumpRenderTree/mac/DumpRenderTree.mm:
751         (resetDefaultsToConsistentValues):
752         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
753
754 2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
755
756         Reviewed by Kenneth Rohde Christiansen.
757
758         Support frameset flattening
759         https://bugs.webkit.org/show_bug.cgi?id=32717
760
761         Add FrameSet Flattening support to Mac DRT.
762
763         * DumpRenderTree/LayoutTestController.cpp:
764         (setFrameSetFlatteningEnabledCallback):
765         (LayoutTestController::staticFunctions):
766         * DumpRenderTree/LayoutTestController.h:
767         * DumpRenderTree/mac/DumpRenderTree.mm:
768         (resetDefaultsToConsistentValues):
769         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
770         (LayoutTestController::setFrameSetFlatteningEnabled):
771
772 2010-02-08  Jon Honeycutt  <jhoneycutt@apple.com>
773
774         <rdar://problem/7436875> Crash in Flash when visiting
775         http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
776
777         Reviewed by Darin Adler.
778
779         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
780         (executeScript):
781         Moved to an earlier point in the file.
782         (NPP_New):
783         If the plug-in has an onDestroy attribute, store its value.
784         (NPP_Destroy):
785         If the plug-in has code to run on destruction, run it and free it.
786
787 2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
788
789         Reviewed by Kenneth Rohde Christiansen.
790
791         Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
792         to make Qt DRT able to get page number.
793
794         LayoutTests:
795             printing/page-break-always.html
796             printing/pageNumerForElementById.html
797             printing/css2.1/page-break-before-000.html
798             printing/css2.1/page-break-after-000.html
799             printing/css2.1/page-break-after-004.html
800             printing/css2.1/page-break-before-001.html
801             printing/css2.1/page-break-after-001.html
802             printing/css2.1/page-break-after-002.html
803             printing/css2.1/page-break-before-002.html
804             printing/css2.1/page-break-inside-000.html
805
806         [Qt] Make possible Qt DRT get a page number for element by ID
807         https://bugs.webkit.org/show_bug.cgi?id=34777
808
809         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
810         (LayoutTestController::pageNumberForElementById):
811         * DumpRenderTree/qt/LayoutTestControllerQt.h:
812
813 2010-02-10  Andras Becsi  <abecsi@webkit.org>
814
815         Reviewed by Adam Barth.
816
817         Make run-iexploder-tests work on Linux.
818         https://bugs.webkit.org/show_bug.cgi?id=34748
819
820         Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
821         called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
822
823         * Scripts/run-iexploder-tests:
824         * Scripts/webkitperl/httpd.pm:
825
826 2010-02-09  Csaba Osztrogonác  <ossy@webkit.org>
827
828         [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
829         https://bugs.webkit.org/show_bug.cgi?id=34713
830
831         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
832         (WebCore::WebPage::WebPage):
833         * DumpRenderTree/qt/main.cpp:
834         (main):
835
836 2010-02-09  Alejandro G. Castro  <alex@igalia.com>
837
838         Unreviewed; added myself to committers
839
840         * Scripts/webkitpy/committers.py:
841
842 2010-02-09  Yael Aharon  <yael.aharon@nokia.com>
843
844         Reviewed by Kenneth Rohde Christiansen.
845
846         [Qt] Webkit in Qt does not have window.showModalDialog
847         https://bugs.webkit.org/show_bug.cgi?id=25585
848
849         Set the modality flag when createWindow is called with window type WebWindowDialog.
850
851         * QtLauncher/main.cpp:
852         (WebPage::createWindow):
853
854 2010-02-09  Andras Becsi  <abecsi@webkit.org>
855
856         Unreviewed trivial warning fix.
857
858         * Scripts/build-webkit:
859
860 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
861
862         Reviewed by Tor Arne Vestbø.
863
864         Add possibility of passing parameters to build-webkit by environment variable,
865         because the buildbot slaves can't control the arguments.
866
867         * Scripts/build-webkit:
868
869 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
870
871         Reviewed by Laszlo Gombos.
872
873         [Qt] Enable appcache feature.
874         https://bugs.webkit.org/show_bug.cgi?id=34713
875
876
877         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
878         (WebCore::WebPage::WebPage):
879         * DumpRenderTree/qt/main.cpp:
880         (main):
881
882 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
883
884         Reviewed by Darin Adler.
885
886         Provide a way to get total number of pages to be printed
887         https://bugs.webkit.org/show_bug.cgi?id=34699
888
889         * DumpRenderTree/LayoutTestController.cpp:
890         (parsePageParameters):
891         (pageNumberForElementByIdCallback):
892         (numberOfPagesCallback):
893         (LayoutTestController::staticFunctions):
894         * DumpRenderTree/LayoutTestController.h:
895         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
896         (LayoutTestController::numberOfPages):
897         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
898         (LayoutTestController::numberOfPages):
899         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
900         (LayoutTestController::numberOfPages):
901
902 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
903
904         Reviewed by Darin Adler.
905
906         https://bugs.webkit.org/show_bug.cgi?id=34727
907         Assertion crashes and freezes when plug-in property access results in an exception
908
909         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
910         (pluginGetProperty): Raise an exception when accessing a particular property.
911         (pluginSetProperty): Ditto.
912         (pluginInvoke): Added methods to get and set host object properties.
913
914 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
915
916         Reviewed by Ariya Hidayat.
917
918         [Qt] Backport No'am Rosenthal's frame rate measurement
919
920         * QtLauncher/main.cpp:
921         (LauncherWindow::LauncherWindow):
922         (LauncherApplication::handleUserOptions):
923         * QtLauncher/webview.cpp:
924         (WebViewGraphicsBased::WebViewGraphicsBased):
925         (WebViewGraphicsBased::enableFrameRateMeasurement):
926         (WebViewGraphicsBased::updateFrameRate):
927         (WebViewGraphicsBased::paintEvent):
928         * QtLauncher/webview.h:
929
930 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
931
932         Reviewed by Tor Arne Vestbø.
933
934         [Qt] Make overridePreference complain when it does not
935         support the preference given.
936
937         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
938         (LayoutTestController::overridePreference):
939
940 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
941
942         Reviewed by Kenneth Rohde Christiansen.
943
944         [Qt] Set stdout/stderr to binary mode for DRT on Windows
945
946         This makes sure we don't end up with lots of CRLFs in the
947         DRT output, which breaks tons of results. Matches what
948         the Windows DRT does.
949
950         * DumpRenderTree/qt/main.cpp:
951
952 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
953
954         Reviewed by Kenneth Rohde Christiansen.
955
956         Build fix for Qt on Windows.
957
958         Don't use noreturn directly since it's a gcc attribute.
959         Instead use the NO_RETURN macro from AlwaysInline.h
960
961         * QtLauncher/QtLauncher.pro:
962         * QtLauncher/utils.h:
963
964 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
965
966         Reviewed by Shinichiro Hamaji.
967
968         Suppressed check-webkit-style's underscore check in Qt's autotests.
969         Also made the path-specific filter check case-insensitive.
970
971         https://bugs.webkit.org/show_bug.cgi?id=34574
972
973         * Scripts/webkitpy/style/checker.py:
974           - Added a list element to _PATH_RULES_SPECIFIER for
975             directories that should be excluded from the
976             "readability/naming" category (the category that relates to
977             underscores in identifiers, for example).
978
979         * Scripts/webkitpy/style/checker_unittest.py:
980           - Added an "end-to-end" test for "WebKit/qt/tests/".
981
982         * Scripts/webkitpy/style/filter.py:
983           - Altered FilterConfiguration's should_check() method to
984             check for path substring matches case-insensitively.
985
986         * Scripts/webkitpy/style/filter_unittest.py:
987           - Added a test to check case-insensitive path substring matching.
988
989         * Scripts/webkitpy/style/processors/cpp.py:
990           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
991             since this is now taken care of by the _PATH_RULES_SPECIFIER
992             configuration variable.
993
994         * Scripts/webkitpy/style/processors/cpp_unittest.py:
995           - Removed the unit test for the GTK directory since this
996             is now taken care of by the checker._PATH_RULES_SPECIFIER
997             end-to-end tests.
998
999 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
1000
1001         Reviewed by Darin Adler.
1002
1003         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
1004         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
1005         environemnt variables when there is a space in the user's /home path.
1006
1007         * Scripts/webkitdirs.pm:
1008          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
1009
1010 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
1011
1012         Reviewed by Oliver Hunt.
1013
1014         https://bugs.webkit.org/show_bug.cgi?id=34670
1015         TestNetscapePlugin should work with Firefox
1016
1017         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
1018         browser doesn't tell what it supports.
1019
1020 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
1021
1022         Reviewed by Gustavo Noronha Silva.
1023
1024         [Gtk] Implement layoutTestController.pageNumberForElementById
1025         https://bugs.webkit.org/show_bug.cgi?id=34572
1026
1027         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1028         (LayoutTestController::pageNumberForElementById):
1029
1030 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1031
1032         Reviewed by Eric Seidel.
1033
1034         Add a simple test implementation and the WebKit Mac implementation
1035         for the layout_tests/port package. Also add a simple test driver of
1036         that interface.
1037
1038         https://bugs.webkit.org/show_bug.cgi?id=34511
1039
1040         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
1041         * Scripts/webkitpy/layout_tests/port/__init__.py:
1042         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
1043         * Scripts/webkitpy/layout_tests/port/test.py: Added.
1044
1045 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1046
1047         Reviewed by Eric Siedel.
1048
1049         Refactor the port package into an object-oriented style and merge
1050         path_utils into it. We add a 'base' and a 'chromium' object to the
1051         port package; this will allow us to easily add new ports (like
1052         WebKit Mac).
1053
1054         https://bugs.webkit.org/show_bug.cgi?id=34511
1055
1056         * Scripts/rebaseline-chromium-webkit-tests:
1057         * Scripts/run-chromium-webkit-tests:
1058         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1059         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1060         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1061         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1062         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1063         * Scripts/webkitpy/layout_tests/port/__init__.py:
1064         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1065         * Scripts/webkitpy/layout_tests/port/base.py: Added.
1066         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
1067         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1068         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1069         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1070         * Scripts/webkitpy/layout_tests/port/http_server.py:
1071         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1072         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
1073         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1074         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1075         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1076         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1077         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1078         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1079         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1080
1081 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1082
1083         Reviewed by Dave Hyatt.
1084
1085         Implement flattening of framesets
1086         https://bugs.webkit.org/show_bug.cgi?id=32717
1087
1088         Add support for testing frame flattening with the Qt DRT
1089
1090         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1091         (LayoutTestController::setFrameSetFlatteningEnabled):
1092         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1093
1094 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
1095
1096         Reviewed by Shinichiro Hamaji.
1097
1098         Provided a way in check-webkit-style to specify filter rules
1099         on a per file or folder basis, via a configuration variable.
1100
1101         https://bugs.webkit.org/show_bug.cgi?id=33684
1102
1103         * Scripts/webkitpy/style/checker.py:
1104           - Added _PATH_RULES_SPECIFIER configuration variable.
1105           - In ProcessorOptions class--
1106             - Changed the CategoryFilter attribute to FilterConfiguration.
1107             - Added path parameter to is_reportable().
1108           - Renamed ArgumentDefaults filter_rules attribute to
1109             base_filter_rules.
1110           - Updated ArgumentPrinter class.
1111           - Added filter rule validation to ArgumentParser (instead of
1112             in CategoryFilter constructor).
1113
1114         * Scripts/webkitpy/style/checker_unittest.py:
1115           - Updated unit tests as necessary.
1116           - Added unit tests for PATH_RULES_SPECIFIER.
1117
1118         * Scripts/webkitpy/style/error_handlers.py:
1119           - Updated DefaultStyleErrorHandler to use file path when
1120             calling is_reportable().
1121
1122         * Scripts/webkitpy/style/error_handlers_unittest.py:
1123           - Updated unit tests as necessary.
1124
1125         * Scripts/webkitpy/style/filter.py:
1126           - Marked CategoryFilter internal with an underscore.
1127           - Removed argument validation from CategoryFilter.
1128           - Added FilterConfiguration class.
1129
1130         * Scripts/webkitpy/style/filter_unittest.py:
1131           - Updated CategoryFilterTest class.
1132           - Added FilterConfigurationTest unit tests.
1133
1134         * Scripts/webkitpy/style/processors/cpp.py:
1135           - Removed _is_test_filename() code.
1136           - Removed hard-coded path checks from check_include_line().
1137
1138         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1139           - Removed three unit tests related to exempted files.
1140
1141 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1142
1143         Reviewed by Ariya Hidayat.
1144
1145         [Qt] Apply the command line options as settings to the
1146         graphics system.
1147
1148         * QtLauncher/main.cpp:
1149         (LauncherWindow::LauncherWindow):
1150         (requiresGraphicsView):
1151         (LauncherApplication::handleUserOptions):
1152         * QtLauncher/webview.h:
1153         (WebViewGraphicsBased::setItemCacheMode):
1154
1155 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1156
1157         Reviewed by Simon Hausmann.
1158
1159         Notify user that run-webkit-tests has to be run under Cygwin
1160
1161         The script will bail out if run under Windows shell or Msys.
1162
1163         * Scripts/run-webkit-tests:
1164         * Scripts/webkitdirs.pm:
1165
1166 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1167
1168         Reviewed by Simon Hausmann.
1169
1170         [Qt] Generate convenience headers (QWebView, etc) using qmake
1171
1172         In Qt this is done using syncqt, but we use a pro-file instead
1173         that generates makefile-rules for each of the extra headers.
1174
1175         These extra headers are installed alongside the normal headers.
1176
1177         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
1178
1179 2010-02-05  Andras Becsi  <abecsi@webkit.org>
1180
1181         Unreviewed typo fix.
1182
1183         Fix wrong whitespace alignment introduced in r54342.
1184
1185         * Scripts/run-webkit-tests:
1186
1187 2010-02-04  Mark Rowe  <mrowe@apple.com>
1188
1189         Reviewed by Timothy Hatcher.
1190
1191         Build fix.  Remove a symbol corresponding to an inline function from the linker export
1192         file to prevent a weak external failure.
1193
1194         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
1195         Teach the script how to detect weak external symbols so that these errors can be caught immediately
1196         in the future.
1197
1198 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1199
1200         Rubberstamped by Oliver Hunt.
1201
1202         [Qt] Make it possible to choose whether the launcher should
1203         use the traditional QWidget based QWebView or the newer
1204         QGraphics based QGraphicsWebView on a QGraphicsView.
1205
1206         * QtLauncher/main.cpp:
1207         (LauncherWindow::LauncherWindow):
1208         (LauncherWindow::eventFilter):
1209         (LauncherWindow::loadStarted):
1210         (LauncherWindow::print):
1211         (LauncherWindow::screenshot):
1212         (LauncherWindow::setEditable):
1213         (LauncherWindow::setupUI):
1214         (main):
1215         * QtLauncher/webview.cpp:
1216         (WebViewGraphicsBased::WebViewGraphicsBased):
1217         (WebViewGraphicsBased::resizeEvent):
1218         (GraphicsWebView::mousePressEvent):
1219         (GraphicsWebView::contextMenuEvent):
1220         * QtLauncher/webview.h:
1221         (WebViewTraditional::WebViewTraditional):
1222         (GraphicsWebView::GraphicsWebView):
1223         (WebViewGraphicsBased::setPage):
1224
1225 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1226
1227         Rubberstamped by Oliver Hunt.
1228
1229         [Qt] QtLauncher cleanup.
1230
1231         Refactor option handling out in utility functions and make the
1232         arguments more Qt compatible.
1233
1234         * QtLauncher/main.cpp:
1235         (requiresGraphicsView):
1236         (LauncherApplication::handleUserOptions):
1237         * QtLauncher/utils.cpp:
1238         (takeOptionValue):
1239         (formatKeys):
1240         (enumToKeys):
1241         (appQuit):
1242         * QtLauncher/utils.h:
1243
1244 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
1245
1246         Reviewed by Tor Arne Vestbø.
1247
1248         Implement a locking and scheduling mechanism for http testing sessions to be able
1249         to run multiple instances of run-webkit-tests parallel on the same machine.
1250         If a test session wants to run http tests and this feature is enabled, the pending
1251         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
1252         the running test sessions in first come first served order. An exclusive lock ensures
1253         that the lock numbers are sequential to avoid deadlocks and starvation.
1254         Because the buildbot master specifies the flags used by slaves we need an environment
1255         variable too to be able to use the feature per-slave.
1256         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
1257         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
1258
1259         https://bugs.webkit.org/show_bug.cgi?id=33153
1260
1261         * Scripts/run-webkit-tests:
1262         * Scripts/webkitperl/httpd.pm:
1263
1264 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1265
1266         Reviewed by Simon Hausmann.
1267
1268         Make run-webkit-tests work under Cygwin for the Qt port
1269
1270         setPathForRunningWebKitApp() is implemented for the Qt port
1271         by using qmake to query for the location of the Qt libraries.
1272
1273         This requires the original environment (%ENV) to be untouched,
1274         so launchWithCurrentEnv() was refactored to launchWithEnv(),
1275         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
1276         instead. This has the added benefit of getting rid of the temp
1277         variables used for storing the current env.
1278
1279         openDumpTool() is also refactored a bit into platform-spesific,
1280         port-spesific, and generic environment variables.
1281
1282         Checks for undef was added a few places to fix Perl concat
1283         warnings when run-webkit-tests is aborted.
1284
1285         https://bugs.webkit.org/show_bug.cgi?id=33895
1286
1287         * Scripts/run-webkit-tests:
1288         * Scripts/webkitdirs.pm:
1289
1290 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
1291
1292         Unreviewed.
1293
1294         Add Yuzo to the committers list.
1295
1296         * Scripts/webkitpy/committers.py:
1297
1298 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1299
1300         Rubber-stamped by Eric Seidel.
1301
1302         Change "the Chromium name" to "the name of Google Inc." in the licenses
1303
1304         https://bugs.webkit.org/show_bug.cgi?id=34511
1305
1306         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1307         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1308         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1309         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1310         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1311         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1312         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1313         * Scripts/webkitpy/layout_tests/port/__init__.py:
1314         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1315         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1316         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1317         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1318         * Scripts/webkitpy/layout_tests/port/http_server.py:
1319         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1320         * Scripts/webkitpy/layout_tests/port/path_utils.py:
1321         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1322         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1323         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1324         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1325         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1326         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1327         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1328
1329 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1330
1331         Rubber-stamped by Eric Siedel.
1332
1333         Rename files as part of refactoring the layout_tests package. All
1334         the platform_utils* module, the path_utils.py module, and
1335         the http server and web socket server modules are moved into a new
1336         port/ package.
1337
1338         https://bugs.webkit.org/show_bug.cgi?id=34511
1339
1340         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
1341         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
1342         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
1343         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
1344         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1345         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1346         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
1347         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
1348         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
1349         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
1350         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
1351         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
1352         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1353         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1354         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1355         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
1356         * Scripts/webkitpy/layout_tests/port: Added.
1357         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
1358         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
1359         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
1360         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
1361         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
1362         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
1363         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
1364         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
1365         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
1366         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
1367         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
1368         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1369         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1370         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1371         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1372         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1373         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1374
1375
1376 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1377
1378         Rubber-stamped by Eric Seidel.
1379
1380         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
1381         https://bugs.webkit.org/show_bug.cgi?id=34399
1382
1383         * Scripts/run-iexploder-tests:
1384         * Scripts/run-webkit-httpd:
1385         * Scripts/run-webkit-tests:
1386         * Scripts/webkitperl/httpd.pm: Added.
1387
1388 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1389
1390         Rubber-stamped by Eric Seidel.
1391
1392         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
1393
1394         * Scripts/run-iexploder-tests:
1395         * Scripts/run-webkit-httpd:
1396         * Scripts/run-webkit-tests:
1397         * Scripts/webkitperl/httpd.pm: Removed.
1398
1399 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1400
1401         Rubber-stamped by Ariya Hidayat.
1402
1403         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
1404         https://bugs.webkit.org/show_bug.cgi?id=34399
1405
1406         * DumpRenderTree/win/EventSender.cpp:
1407         (buildModifierFlags):
1408         (mouseDownCallback):
1409         (mouseUpCallback):
1410         (keyDownCallback):
1411
1412 2010-02-03  Eric Seidel  <eric@webkit.org>
1413
1414         No review, just fixing copyrights.
1415
1416         Concerns were expressed about "The Chromium Authors" being
1417         a valid legal entity for copyright assignment in the WebKit repository,
1418         so this change removes all "The Chromium Authors".
1419
1420         I looked at the svn logs in src.chromium.org and failed to find any
1421         non-google contributions to these files, so they are all now
1422         marked as copyright "Google Inc" as all Google contributers assign
1423         copyright to "Google Inc" as part of their employment agreement.
1424
1425         * Scripts/rebaseline-chromium-webkit-tests:
1426         * Scripts/run-chromium-webkit-tests:
1427         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
1428         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
1429         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
1430         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1431         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1432         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1433         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
1434         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
1435         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
1436         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
1437         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
1438         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1439         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1440         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1441         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1442         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
1443         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1444         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1445         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1446         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1447         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1448         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1449
1450 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1451
1452         Reviewed by Ariya Hidayat.
1453
1454         [Qt] QtLauncher, refactor argument handling in preparation of merge
1455         with QGVLauncher
1456
1457         * QtLauncher/main.cpp:
1458         (LauncherApplication::urls):
1459         (LauncherApplication::isRobotized):
1460         (LauncherApplication::applyDefaultSettings):
1461         (LauncherApplication::LauncherApplication):
1462         (LauncherApplication::formatKeys):
1463         (LauncherApplication::enumToKeys):
1464         (fail):
1465         (LauncherApplication::handleUserOptions):
1466         (main):
1467
1468 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1469
1470         Rubber-stamped by Ariya Hidayat.
1471
1472         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
1473         https://bugs.webkit.org/show_bug.cgi?id=34399
1474
1475         * DumpRenderTree/win/EventSender.cpp:
1476         (mouseDownCallback):
1477         (mouseUpCallback):
1478         (keyDownCallback):
1479
1480 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
1481
1482         Reviewed by Ariya Hidayat.
1483
1484         [Qt] Fix pixel tests support.
1485         https://bugs.webkit.org/show_bug.cgi?id=27813
1486
1487         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1488         (WebCore::DumpRenderTree::open):
1489         (WebCore::DumpRenderTree::processLine):
1490          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
1491         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
1492
1493 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
1494
1495         Reviewed by Kevin Ollivier.
1496
1497         [wx] Enable JIT compilation for wx.
1498         
1499         https://bugs.webkit.org/show_bug.cgi?id=34536
1500
1501         * wx/build/settings.py:
1502
1503 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
1504
1505         [wx] Build fix after introduction of pageNumberForElementById.
1506
1507         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1508         (LayoutTestController::pageNumberForElementById):
1509
1510 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
1511
1512         Unreviewed.
1513
1514         Add myself to list of committers.
1515
1516         * Scripts/webkitpy/committers.py:
1517
1518 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
1519
1520         Reviewed by Shinichiro Hamaji.
1521
1522         Moved filter-related check-webkit-style code into a separate
1523         filter module.
1524
1525         https://bugs.webkit.org/show_bug.cgi?id=34408
1526
1527         This is preparatory refactoring for Bug 33684, which will allow
1528         file and folder-specific filter rules.
1529
1530         * Scripts/webkitpy/style/checker.py:
1531           - Removed CategoryFilter class (moved to filter.py).
1532
1533         * Scripts/webkitpy/style/checker_unittest.py:
1534           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
1535
1536         * Scripts/webkitpy/style/filter.py: Added.
1537           - Added CategoryFilter class (moved from checker.py).
1538
1539         * Scripts/webkitpy/style/filter_unittest.py: Added.
1540           - Added CategoryFilter unit tests (moved from checker_unittest.py).
1541
1542         * Scripts/webkitpy/style/unittests.py:
1543           - Added reference to filter_unittest.py.
1544
1545 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
1546
1547         Reviewed by Shinichiro Hamaji.
1548
1549         Addressed FIXME in check-webkit-style so that the carriage-return
1550         check will work for patches.
1551
1552         https://bugs.webkit.org/show_bug.cgi?id=34260
1553
1554         Also added support for limiting the number of errors reported
1555         per category, per file.
1556
1557         * Scripts/webkitpy/style/checker.py:
1558           - Added new "whitespace/carriage_return" category from common.py.
1559           - Added MAX_REPORTS_PER_CATEGORY dictionary.
1560           - Added max_reports_per_category attribute to ProcessorOptions class.
1561           - Refactored StyleChecker._process_file().
1562
1563         * Scripts/webkitpy/style/checker_unittest.py:
1564           - Updated ProcessorOptionsTest tests.
1565           - Added test to check MAX_REPORTS_PER_CATEGORY.
1566
1567         * Scripts/webkitpy/style/error_handlers.py:
1568           - Added support for suppressing the display of errors after
1569             reaching a per-category maximum (from max_reports_per_category).
1570
1571         * Scripts/webkitpy/style/error_handlers_unittest.py:
1572           - Added test for suppressing error display.
1573
1574         * Scripts/webkitpy/style/processors/common.py: Added.
1575           - Moved carriage-return check to new file.
1576
1577         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
1578           - Added unit tests for carriage-return check.
1579
1580         * Scripts/webkitpy/style/unittests.py:
1581           - Added reference to common_unittest.py.
1582
1583 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
1584
1585         Reviewed by Eric Seidel.
1586
1587         Provide a way to get page number with layoutTestController
1588         https://bugs.webkit.org/show_bug.cgi?id=33840
1589
1590         * DumpRenderTree/LayoutTestController.cpp:
1591         (pageNumberForElementByIdCallback):
1592         (LayoutTestController::staticFunctions):
1593         * DumpRenderTree/LayoutTestController.h:
1594         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1595         (LayoutTestController::pageNumberForElementById):
1596         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1597         (LayoutTestController::pageNumberForElementById):
1598         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1599         (LayoutTestController::pageNumberForElementById):
1600
1601 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
1602
1603         Unreviewed fix for an invalid function call.
1604
1605         check-webkit-style: Remove filename parameter from all functions where no longer used
1606         https://bugs.webkit.org/show_bug.cgi?id=34249
1607
1608         * Scripts/webkitpy/style/checker.py:
1609
1610 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1611
1612         Reviewed by Kenneth Rohde Christiansen.
1613
1614         [Qt] DRT Provide global flag ability
1615         https://bugs.webkit.org/show_bug.cgi?id=34418
1616
1617         Add the globalFlag property to the Qt LayoutTestController to allow
1618         cross-domain indications.
1619
1620         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1621         (LayoutTestController::reset):
1622         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1623         (LayoutTestController::globalFlag):
1624         (LayoutTestController::setGlobalFlag):
1625
1626 2010-02-01  Brady Eidson  <beidson@apple.com>
1627
1628         Reviewed by Adele Peterson.
1629
1630         Crash in Safari opening new tabs to "same page"
1631         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
1632
1633         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
1634
1635         * DumpRenderTree/LayoutTestController.cpp:
1636         (LayoutTestController::LayoutTestController):
1637         (setNewWindowsCopyBackForwardListCallback):
1638         (LayoutTestController::staticFunctions):
1639
1640         * DumpRenderTree/LayoutTestController.h:
1641         (LayoutTestController::newWindowsCopyBackForwardList):
1642         (LayoutTestController::setNewWindowsCopyBackForwardList):
1643
1644         * DumpRenderTree/mac/UIDelegate.mm:
1645         (-[UIDelegate webView:createWebViewWithRequest:]):
1646
1647 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
1648
1649         Unreviewed.
1650
1651         Add myself to list of committers.
1652
1653         * Scripts/webkitpy/committers.py:
1654
1655 2010-02-01  Nate Chapin  <japhet@chromium.org>
1656
1657         Rubber-stamped by David Levin.
1658
1659         Add myself to reviewer list.
1660
1661         * Scripts/webkitpy/committers.py:
1662
1663 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
1664
1665         Reviewed by Shinichiro Hamaji.
1666
1667         Moved style error handler code to their own classes, and
1668         related refactoring. Increased unit test code coverage of
1669         style error handling.
1670
1671         https://bugs.webkit.org/show_bug.cgi?id=34379
1672
1673         * Scripts/check-webkit-style:
1674           - Minor change: added error_count variable.
1675
1676         * Scripts/webkitpy/style/checker.py:
1677           - Renamed ProcessorOptions.should_report_error() to is_reportable().
1678           - In the StyleChecker class--
1679             - Removed _default_style_error_handler().
1680             - Added _increment_error_count().
1681             - Refactored to use DefaultStyleErrorHandler and
1682               PatchStyleErrorHandler constructors.
1683
1684         * Scripts/webkitpy/style/checker_unittest.py:
1685           - In the StyleStyleCheckerTest class--
1686             - Removed write_sample_error().
1687             - Removed test_default_style_error_handler().
1688
1689         * Scripts/webkitpy/style/error_handlers.py: Added.
1690           - Added DefaultStyleErrorHandler class.
1691           - Added PatchStyleErrorHandler class.
1692
1693         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
1694           - Added unit tests for DefaultStyleErrorHandler and
1695             PatchStyleErrorHandler.
1696
1697         * Scripts/webkitpy/style/unittests.py:
1698           - Added error_handlers unit tests.
1699
1700 2010-01-29  Mark Rowe  <mrowe@apple.com>
1701
1702         Rubber-stamped by Stephanie Lewis.
1703
1704         Fix run-leaks with newer versions of the leaks tool.
1705
1706         * Scripts/run-leaks:
1707
1708 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1709
1710         Reviewed by Eric Siedel.
1711
1712         Top-level test drivers for running the Chromium port of run-webkit-tests
1713         and being able to rebaseline test results from the test bots.  The
1714         files in the Scripts directory are simply wrappers around the files
1715         in webkitpy/layout_tests for convenience.
1716  
1717         https://bugs.webkit.org/show_bug.cgi?id=31498
1718
1719         * Scripts/rebaseline-chromium-webkit-tests: Added.
1720         * Scripts/run-chromium-webkit-tests: Added.
1721         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
1722         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
1723
1724 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1725
1726         Reviewed by Eric Siedel.
1727
1728         Add in the second block of python code for the Chromium port
1729         of run-webkit-tests. These files execute different diffs to classify
1730         the various types of failures from a test.
1731
1732         * Scripts/webkitpy/layout_tests/test_types: Added.
1733         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
1734         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
1735         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
1736         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
1737         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
1738
1739 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1740
1741         Reviewed by Eric Siedel.
1742
1743         Check in the first part of the Chromium Python port of the 
1744         run-webkit-tests test driver. The files under 
1745         layout_tests/layout_layout constitute most of the implementation;
1746         they can be roughly divided into code that parses the 
1747         "test_expectations.txt" file that describes how we expect tests to
1748         pass or fail, platform-specific hooks for the different Chromium 
1749         ports (in platform_utils*), code for parsing the output of the
1750         tests and generating results files and HTML and JSON for the
1751         dashboards, auxiliary scripts for starting and stopping HTTP and
1752         Web Socket servers, and then one of the actual driver files 
1753         (test_shell_thread). Code for actually parsing test output for 
1754         failures and the top-level driver scripts will follow shortly.
1755
1756         https://bugs.webkit.org/show_bug.cgi?id=31498
1757
1758         * Scripts/webkitpy/layout_tests: Added.
1759         * Scripts/webkitpy/layout_tests/layout_package: Added.
1760         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
1761         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
1762         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
1763         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
1764         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
1765           - scripts to start and stop apache. Note that the apache file
1766             generates a conf file dynamically, and we should switch to 
1767             using the same static conf file that the regular run-webkit-tests
1768             uses, and we can also use the same httpd2.pem file.
1769
1770         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
1771         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
1772           - scripts to generate the JSON layout test dashboard and the
1773             flakiness dashboard
1774         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
1775           - default configuration for LigHTTPd (used on Windows)
1776         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
1777           - utility class that implements progress bars on the console to
1778             be displayed while the tests are running
1779         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
1780           - various routines for manipulating paths and URIs
1781         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
1782         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
1783         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
1784         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
1785           - platform-specific aspects of the drivers (binary names, paths,
1786             process control, etc.)
1787         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
1788           - code for parsing the 'test_expectations.txt' file to determine
1789             which tests are expected to fail (and how) on which platforms
1790         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
1791           - code for handling different kinds of failures (generating output
1792             in the results, etc.)
1793         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
1794           - code to gather the lists of tests
1795         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
1796           - code to actually execute tests via TestShell and process
1797             the output
1798         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
1799           - scripts to start and stop the pywebsocket server
1800
1801 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1802
1803         Reviewed by Eric Seidel.
1804
1805         Check in a copy of the simplejson library; it will be used by
1806         the Chromium port of run-webkit-tests.
1807         
1808         https://bugs.webkit.org/show_bug.cgi?id=31498
1809
1810         * simplejson: Added.
1811         * simplejson/LICENSE.txt: Added.
1812         * simplejson/README.txt: Added.
1813         * simplejson/__init__.py: Added.
1814         * simplejson/_speedups.c: Added.
1815         (ascii_escape_char):
1816         (ascii_escape_unicode):
1817         (ascii_escape_str):
1818         (py_encode_basestring_ascii):
1819         (init_speedups):
1820         * simplejson/decoder.py: Added.
1821         * simplejson/encoder.py: Added.
1822         * simplejson/jsonfilter.py: Added.
1823         * simplejson/scanner.py: Added.
1824
1825 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
1826
1827         No review
1828
1829         Add myself to the committers list
1830
1831         * Scripts/webkitpy/committers.py:
1832
1833 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
1834
1835         Reviewed by Dimitri Glazkov.
1836
1837         A first step towards the Indexed Database API
1838         https://bugs.webkit.org/show_bug.cgi?id=34342
1839
1840         Add indexed database API.
1841
1842         * Scripts/build-webkit:
1843
1844 2010-01-29  Andras Becsi  <abecsi@webkit.org>
1845
1846         Reviewed by Alexey Proskuryakov.
1847
1848         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
1849         This fixes a regression introduced in r53559.
1850
1851         https://bugs.webkit.org/show_bug.cgi?id=34336
1852
1853         * Scripts/webkitperl/httpd.pm:
1854
1855 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
1856
1857         MSAA: Crash when posting a notification for a detached object
1858
1859         https://bugs.webkit.org/show_bug.cgi?id=34309
1860         <rdar://problem/7409759>
1861
1862         Reviewed by Darin Adler.
1863
1864         * DumpRenderTree/AccessibilityController.h:
1865         Declare new functions. Add new members to store the event hook and the
1866         mapping of accessibility elements to their JS callbacks.
1867
1868         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1869         (AccessibilityController::notificationReceived):
1870         Stubbed.
1871         (AccessibilityController::addNotificationListener):
1872         Stubbed.
1873
1874         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1875         (AccessibilityController::notificationReceived):
1876         Stubbed.
1877         (AccessibilityController::addNotificationListener):
1878         Stubbed.
1879
1880         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1881         (AccessibilityController::AccessibilityController):
1882         Initialize the event hook.
1883         (AccessibilityController::~AccessibilityController):
1884         Remove the event hook. Unprotect all of the JS functions that are stored
1885         in the map.
1886         (logEventProc):
1887         Clean-up a variable.
1888         (stringEvent):
1889         Return a string description of the MSAA event code.
1890         (notificationListenerProc):
1891         Get the accessible object from the event, and query it for IAccessible.
1892         Call the AccessibilityController's notificationReceived().
1893         (comparableObject):
1894         Use QueryService to obtain the IAccessibleComparable for the
1895         IServiceProvider.
1896         (AccessibilityController::notificationReceived):
1897         Iterate the map of objects that have registered for notification
1898         callbacks. Query each for IServiceProvider, then use comparableObject()
1899         to get an IAccessibleComparable. If we find an object matching the
1900         notified object, call its callback, passing the event that was received.
1901         (AccessibilityController::addNotificationListener):
1902         If we have not created the event hook, create it. Protect the JS
1903         callback function object, and add the object and its callback to our
1904         map.
1905
1906         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1907         (AccessibilityUIElement::addNotificationListener):
1908         Call through to the AccessibilityController's addNotificationListener().
1909
1910         * DumpRenderTree/win/DumpRenderTreeWin.h:
1911         Add an extern declaration for the shared FrameLoadDelegate extern, so we
1912         can access it from AccessibilityController.
1913
1914         * DumpRenderTree/win/FrameLoadDelegate.h:
1915         (FrameLoadDelegate::accessibilityController):
1916         Return the AccessibilityController.
1917
1918 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
1919
1920         Reviewed by Darin Adler.
1921
1922         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
1923         https://bugs.webkit.org/show_bug.cgi?id=34313
1924
1925         * Scripts/prepare-ChangeLog:
1926
1927 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1928
1929         Rubberstamped by Simon Hausmann.
1930
1931         [Qt] Separate implementation from class definition.
1932
1933         * QtLauncher/main.cpp:
1934         (LauncherWindow::webView):
1935         (LauncherWindow::LauncherWindow):
1936         (LauncherWindow::~LauncherWindow):
1937         (LauncherWindow::keyPressEvent):
1938         (LauncherWindow::grabZoomKeys):
1939         (LauncherWindow::sendTouchEvent):
1940         (LauncherWindow::eventFilter):
1941         (LauncherWindow::loadStarted):
1942         (LauncherWindow::loadFinished):
1943         (LauncherWindow::showLinkHover):
1944         (LauncherWindow::zoomIn):
1945         (LauncherWindow::zoomOut):
1946         (LauncherWindow::resetZoom):
1947         (LauncherWindow::toggleZoomTextOnly):
1948         (LauncherWindow::print):
1949         (LauncherWindow::screenshot):
1950         (LauncherWindow::setEditable):
1951         (LauncherWindow::dumpHtml):
1952         (LauncherWindow::selectElements):
1953         (LauncherWindow::setTouchMocking):
1954         (LauncherWindow::newWindow):
1955         (LauncherWindow::setupUI):
1956
1957 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1958
1959         Reviewed by Ariya Hidayat.
1960
1961         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
1962         should result in all text selected.
1963
1964         * QtLauncher/locationedit.cpp:
1965         (LocationEdit::focusInEvent):
1966         * QtLauncher/locationedit.h:
1967
1968 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1969
1970         Reviewed by Ariya Hidayat.
1971
1972         [Qt] Show progress reaching 100% for loads.
1973
1974         * QtLauncher/locationedit.cpp:
1975         (LocationEdit::LocationEdit):
1976         (LocationEdit::setProgress):
1977         (LocationEdit::reset):
1978         (LocationEdit::paintEvent):
1979         * QtLauncher/locationedit.h:
1980
1981 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1982
1983         Reviewed by Kenneth Rohde Christiansen.
1984
1985         [Qt] Disable the QtLauncher statusbar on Maemo
1986
1987         https://bugs.webkit.org/show_bug.cgi?id=34330
1988
1989         * QtLauncher/main.cpp:
1990         (LauncherWindow::showLinkHover):
1991         (LauncherWindow::selectElements):
1992
1993 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1994
1995         Reviewed by Kenneth Rohde Christiansen.
1996
1997         [Qt] Display page loading progress inside the QtLauncher location bar
1998
1999         https://bugs.webkit.org/show_bug.cgi?id=34210
2000
2001         * QtLauncher/QtLauncher.pro:
2002         * QtLauncher/locationedit.cpp: Added.
2003         (LocationEdit::LocationEdit):
2004         (LocationEdit::setProgress):
2005         (LocationEdit::paintEvent):
2006         * QtLauncher/locationedit.h: Added.
2007         * QtLauncher/mainwindow.cpp:
2008         (MainWindow::buildUI):
2009         * QtLauncher/mainwindow.h:
2010
2011 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2012
2013         Reviewed by Kenneth Rohde Christiansen.
2014
2015         [Qt] Add support for Maemo zoom keys in QtLauncher
2016
2017         https://bugs.webkit.org/show_bug.cgi?id=34160
2018
2019         * QtLauncher/main.cpp:
2020         (LauncherWindow::LauncherWindow):
2021         (LauncherWindow::~LauncherWindow):
2022         (LauncherWindow::keyPressEvent):
2023         (LauncherWindow::grabZoomKeys):
2024
2025 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
2026
2027         Reviewed by Kenneth Rohde Christiansen.
2028
2029         [Qt] Implement the display() method of the layout test controller
2030         https://bugs.webkit.org/show_bug.cgi?id=34258
2031
2032         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2033         (WebCore::DumpRenderTree::DumpRenderTree):
2034         (WebCore::DumpRenderTree::showPage):
2035         (WebCore::DumpRenderTree::hidePage):
2036         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2037         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2038         (LayoutTestController::reset):
2039         (LayoutTestController::display):
2040         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2041
2042 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
2043
2044         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
2045         implements pthread_t in a way that makes it impossible to check its validity,
2046         which is needed by ThreadingPthreads.cpp.
2047
2048         * DumpRenderTree/wscript:
2049         * wx/build/settings.py:
2050
2051 2010-01-28  Andras Becsi  <abecsi@webkit.org>
2052
2053         Adding myself to the committer list. No review needed.
2054
2055         * Scripts/webkitpy/committers.py:
2056
2057 2010-01-28  Hayato Ito  <hayato@chromium.org>
2058
2059         Reviewed by David Levin.
2060
2061         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
2062
2063         https://bugs.webkit.org/show_bug.cgi?id=34252
2064
2065         * Scripts/make-script-test-wrappers:
2066
2067 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
2068
2069         [wx] Build fix after removal of the zlib image decoder.
2070
2071         * wx/build/settings.py:
2072
2073 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
2074
2075         [Qt] Unreviewed, roll out r54000.
2076
2077         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2078         (WebCore::DumpRenderTree::DumpRenderTree):
2079         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2080         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2081         (LayoutTestController::reset):
2082         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2083         (LayoutTestController::display):
2084
2085 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2086
2087         Reviewed by Kenneth Rohde Christiansen.
2088
2089         [Qt] Implement the display() method of the layout test controller
2090         https://bugs.webkit.org/show_bug.cgi?id=34258
2091
2092         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2093         (WebCore::DumpRenderTree::DumpRenderTree):
2094         (WebCore::DumpRenderTree::showPage):
2095         (WebCore::DumpRenderTree::hidePage):
2096         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2097         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2098         (LayoutTestController::reset):
2099         (LayoutTestController::display):
2100         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2101
2102 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
2103
2104         Reviewed by Shinichiro Hamaji.
2105
2106         Eliminated the filename parameter from functions in
2107         check-webkit-style's cpp.py where it is no longer used.
2108
2109         https://bugs.webkit.org/show_bug.cgi?id=34249
2110
2111         * Scripts/webkitpy/style/processors/cpp.py:
2112           - Reduced number of occurrences of "filename" variable from
2113             approximately 200 to 120.
2114
2115         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2116           - Refactored unit tests as necessary to accommodate changes to cpp.py.
2117           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
2118             where the incorrect file extension was getting passed to
2119             cpp_style.check_language().
2120
2121 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
2122
2123         Reviewed by Shinichiro Hamaji.
2124
2125         In check-webkit-style, eliminated the dependency of
2126         processors/cpp_unittest.py on checker.py.
2127
2128         https://bugs.webkit.org/show_bug.cgi?id=34205
2129
2130         * Scripts/webkitpy/style/checker.py:
2131           - Addressed FIXME by removing STYLE_CATEGORIES data.
2132           - Added style_categories().
2133
2134         * Scripts/webkitpy/style/checker_unittest.py:
2135           - Minor changes.
2136
2137         * Scripts/webkitpy/style/processors/cpp.py:
2138           - Added categories attribute to CppProcessor class (data
2139             was originally checker.STYLE_CATEGORIES).
2140
2141         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2142           - Addressed FIXME by eliminating "import" from checker.py.
2143
2144 2010-01-28  Anton Muhin  <antonm@chromium.org>
2145
2146         Reviewed by Shinichiro Hamaji.
2147
2148         Improve treatment of conditions and rest of the line for if, else, switch and alikes
2149         https://bugs.webkit.org/show_bug.cgi?id=34173
2150
2151         * Scripts/webkitpy/style/cpp_style.py:
2152         * Scripts/webkitpy/style/cpp_style_unittest.py:
2153
2154 2010-01-28  Joe Mason  <jmason@rim.com>
2155
2156         Reviewed by Adam Barth.
2157
2158         Limit login retries to 5
2159         https://bugs.webkit.org/show_bug.cgi?id=34193
2160
2161         * Scripts/webkitpy/bugzilla.py:
2162
2163 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
2164
2165         Adding myself to the committer list. No review necessary.
2166
2167         * Scripts/webkitpy/committers.py:
2168
2169 2010-01-27  George Wright  <gwright@rim.com>
2170
2171         Reviewed by Adam Treat.
2172
2173         https://bugs.webkit.org/show_bug.cgi?id=34216
2174
2175         Add missing include for wtf/Platform.h
2176
2177         * DumpRenderTree/AccessibilityController.h:
2178
2179 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2180
2181         Reviewed by Kenneth Rohde Christiansen.
2182
2183         [Qt] DRT Provide worker thread ability to track counters
2184         https://bugs.webkit.org/show_bug.cgi?id=34221
2185
2186         Implement workerThreadCount() in LayoutTestController of Qt DRT
2187
2188         Tests:
2189         fast/workers/dedicated-worker-lifecycle.html
2190         fast/workers/shared-worker-frame-lifecycle.html
2191         fast/workers/shared-worker-lifecycle.html
2192         fast/workers/worker-lifecycle.html
2193
2194         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2195         (LayoutTestController::workerThreadCount):
2196         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2197
2198 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2199
2200         Rubberstamped by Simon Hausmann.
2201
2202         [Qt] QtLauncher refactoring:
2203
2204         Make the LauncherWindow depend less on the view, so that more
2205         code can be shared in near future.
2206
2207         * QtLauncher/main.cpp:
2208         (LauncherWindow::sendTouchEvent):
2209         (LauncherWindow::loadFinished):
2210         (LauncherWindow::zoomIn):
2211         (LauncherWindow::zoomOut):
2212         (LauncherWindow::resetZoom):
2213         (LauncherWindow::toggleZoomTextOnly):
2214         (LauncherWindow::dumpHtml):
2215         (LauncherWindow::selectElements):
2216         (LauncherWindow::setupUI):
2217
2218 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
2219
2220         Reviewed by Eric Seidel.
2221
2222         Correctly handle the KeyLocation argument that has been introduced
2223         recently to test location-dependent key events in EventSender.keyDown.
2224         http://bugs.webkit.org/show_bug.cgi?id=28247
2225
2226         Test: fast/events/keydown-numpad-keys.html
2227
2228         * DumpRenderTree/gtk/EventSender.cpp:
2229         (keyDownCallback):
2230
2231 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2232
2233         Rubberstamped by Simon Hausmann.
2234
2235         [Qt] QtLauncher refactoring:
2236
2237         Move out code from the MainWindow (renamed to LauncherWindow)
2238         that is not depending on the view, and add it to a new class
2239         called MainWindow.
2240
2241         * QtLauncher/QtLauncher.pro:
2242         * QtLauncher/main.cpp:
2243         (LauncherWindow::LauncherWindow):
2244         (LauncherWindow::eventFilter):
2245         (LauncherWindow::loadStarted):
2246         (LauncherWindow::loadFinished):
2247         (LauncherWindow::newWindow):
2248         (LauncherWindow::setupUI):
2249         (WebPage::createWindow):
2250         (main):
2251         * QtLauncher/mainwindow.cpp: Added.
2252         (MainWindow::MainWindow):
2253         (MainWindow::buildUI):
2254         (MainWindow::page):
2255         (MainWindow::setAddressUrl):
2256         (MainWindow::addCompleterEntry):
2257         (MainWindow::load):
2258         (MainWindow::changeLocation):
2259         (MainWindow::openFile):
2260         * QtLauncher/mainwindow.h: Added.
2261
2262 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2263
2264         Rubberstamped by Simon Hausmann.
2265
2266         [Qt] QtLauncher, coding style fixes.
2267
2268         * QtLauncher/main.cpp:
2269         (MainWindow::MainWindow):
2270         (MainWindow::sendTouchEvent):
2271         (MainWindow::eventFilter):
2272         (MainWindow::loadURL):
2273         (MainWindow::setupUI):
2274         (WebPage::createPlugin):
2275
2276 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2277
2278         Rubberstamped by Simon Hausmann.
2279
2280         [Qt] QtLauncher refactoring, separating the webview and
2281         adding a QGraphicsWebView based version.
2282
2283         * QtLauncher/QtLauncher.pro:
2284         * QtLauncher/main.cpp:
2285         (MainWindow::MainWindow):
2286         * QtLauncher/webpage.h:
2287         * QtLauncher/webview.cpp: Added.
2288         (createContextMenu):
2289         (WebViewGraphicsBased::mousePressEvent):
2290         (WebViewTraditional::mousePressEvent):
2291         (WebViewGraphicsBased::contextMenuEvent):
2292         (WebViewTraditional::contextMenuEvent):
2293         * QtLauncher/webview.h: Added.
2294         (WebViewGraphicsBased::WebViewGraphicsBased):
2295         (WebViewTraditional::WebViewTraditional):
2296
2297 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
2298
2299         Adding myself as committer. No review necessary.
2300
2301         * Scripts/webkitpy/committers.py:
2302
2303 2010-01-27  Eric Seidel  <eric@webkit.org>
2304
2305         Reviewed by Darin Adler.
2306
2307         webkit-patch needs an open-bugs command
2308         https://bugs.webkit.org/show_bug.cgi?id=30793
2309
2310         * Scripts/test-webkitpy: import OpenBugsTest
2311         * Scripts/webkit-patch: import OpenBugs
2312         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
2313         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
2314         * Scripts/webkitpy/commands/queries_unittest.py: ditto
2315         * Scripts/webkitpy/commands/queues_unittest.py: ditto
2316         * Scripts/webkitpy/commands/upload_unittest.py: ditto
2317         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
2318
2319 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2320
2321         Rubberstamped by Simon Hausmann
2322
2323         [Qt] QtLauncher refactoring, separating utility methods.
2324
2325         * QtLauncher/QtLauncher.pro:
2326         * QtLauncher/main.cpp:
2327         * QtLauncher/utils.cpp: Added.
2328         (urlFromUserInput):
2329         * QtLauncher/utils.h: Added.
2330
2331 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2332
2333         Rubberstamped by Simon Hausmann
2334
2335         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
2336
2337         * QtLauncher/main.cpp:
2338         (MainWindow::MainWindow):
2339         * QtLauncher/webpage.cpp:
2340         (WebPage::WebPage):
2341         (WebPage::applyProxy):
2342         * QtLauncher/webpage.h:
2343
2344 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2345
2346         Reviewed by Tor Arne Vestbø.
2347
2348         [Qt] Corrects debug build of DumpRenderTree on Windows.
2349
2350         * DumpRenderTree/qt/DumpRenderTree.pro:
2351
2352 2010-01-26  Daniel Bates  <dbates@webkit.org>
2353
2354         Reviewed by Adam Barth.
2355
2356         https://bugs.webkit.org/show_bug.cgi?id=34070
2357
2358         Moves the try/catch for OSError exceptions in Executive.run_command
2359         to Credentials.read_credentials() so that the unit test
2360         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
2361         assert that Executive.run_command throws an OSError exception.
2362
2363         * Scripts/webkitpy/credentials.py:
2364         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
2365         method Credentials.read_credentials().
2366         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
2367         apply: test_run_command_with_bad_command_check_return_code and
2368         test_run_command_with_bad_command_check_calls_error_handler. Added new
2369         test to assert that run_command throws OSError exceptions.
2370
2371 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2372
2373         Reviewed by Kenneth Rohde Christiansen.
2374
2375         [Qt] DRT WebHistory support
2376         https://bugs.webkit.org/show_bug.cgi?id=34167
2377
2378         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2379         (LayoutTestController::reset):
2380         (LayoutTestController::webHistoryItemCount):
2381         (LayoutTestController::keepWebHistory):
2382         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2383
2384 2010-01-26  Kent Tamura  <tkent@chromium.org>
2385
2386         Reviewed by Eric Seidel.
2387
2388         [Win] Add modifiers parameter support to Windows DumpRenderTree
2389         https://bugs.webkit.org/show_bug.cgi?id=34068
2390
2391         Add support for functional name modifiers; "addSelectionKey" and
2392         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
2393         and eventSender.mouseUp().
2394         This change is similar to r53498 for Mac.
2395         
2396         * DumpRenderTree/win/EventSender.cpp:
2397         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
2398         (mouseDownCallback): Call buidlModifiersFlags().
2399         (mouseUpCallback): ditto.
2400         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
2401
2402 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
2403
2404         Reviewed by Eric Seidel.
2405
2406         The Python autoinstall cache directory now only gets created
2407         in the directory containing autoinstall.py.
2408
2409         https://bugs.webkit.org/show_bug.cgi?id=33365
2410
2411         * Scripts/webkitpy/autoinstall.py:
2412           - Also added a README file to the cache directory saying
2413             where it came from.
2414
2415 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
2416
2417         Reviewed by Eric Seidel.
2418
2419         Moved the check-webkit-style processors into a new
2420         webkitpy/style/processors directory.
2421
2422         https://bugs.webkit.org/show_bug.cgi?id=34060
2423
2424         * Scripts/webkitpy/style/checker.py:
2425         * Scripts/webkitpy/style/checker_unittest.py:
2426         * Scripts/webkitpy/style/cpp_style.py: Removed.
2427         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
2428         * Scripts/webkitpy/style/processors: Added.
2429         * Scripts/webkitpy/style/processors/__init__.py: Added.
2430         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
2431         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
2432         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
2433         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
2434         * Scripts/webkitpy/style/text_style.py: Removed.
2435         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
2436         * Scripts/webkitpy/style/unittests.py:
2437
2438 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
2439
2440         [wx] Build fix, make sure stub function returns a value.
2441
2442         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2443         (LayoutTestController::counterValueForElementById):
2444
2445 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
2446
2447         Reviewed by Oliver Hunt.
2448
2449         Windows build references non-existent include paths
2450         https://bugs.webkit.org/show_bug.cgi?id=34175
2451
2452         * DumpRenderTree/win/DumpRenderTree.vcproj:
2453         * DumpRenderTree/win/ImageDiff.vcproj:
2454         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2455
2456 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2457
2458         Reviewed by Ariya Hidayat.
2459
2460         [Qt] Separating out the UrlLoader from the QtLauncher in it's
2461         own implementation and header file.
2462
2463         * QtLauncher/main.cpp:
2464         (main):
2465         * QtLauncher/urlloader.cpp: Added.
2466         (UrlLoader::UrlLoader):
2467         (UrlLoader::loadNext):
2468         (UrlLoader::init):
2469         (UrlLoader::getUrl):
2470         * QtLauncher/urlloader.h: Added.
2471
2472 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
2473
2474         Reviewed by Shinichiro Hamaji.
2475
2476         Refactored check-webkit-style by removing the file path
2477         parameter from the style error handler functions.
2478
2479         https://bugs.webkit.org/show_bug.cgi?id=34031
2480
2481         * Scripts/webkitpy/style/checker.py:
2482           - Added _default_style_error_handler() to StyleChecker class.
2483           - Moved handle_style_error() to inside _default_style_error_handler().
2484
2485         * Scripts/webkitpy/style/checker_unittest.py:
2486           - Removed file path from calls to error handler.
2487
2488         * Scripts/webkitpy/style/cpp_style.py:
2489           - Removed file path from calls to error handler.
2490
2491         * Scripts/webkitpy/style/cpp_style_unittest.py:
2492           - Removed file path from calls to error handler.
2493
2494         * Scripts/webkitpy/style/text_style.py:
2495           - Removed file path from calls to error handler.
2496
2497         * Scripts/webkitpy/style/text_style_unittest.py:
2498           - Removed file path from calls to error handler.
2499
2500 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
2501
2502         Adding myself as reviewer.  No review necessary.
2503
2504         * Scripts/webkitpy/committers.py:
2505
2506 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
2507
2508         Reviewed by Adam Barth.
2509
2510         Improved prepare-ChangeLog so that it preserves the relative
2511         indentation of a git commit message.
2512
2513         https://bugs.webkit.org/show_bug.cgi?id=34058
2514
2515         * Scripts/prepare-ChangeLog:
2516           - Also adjusted the script so that it does not add white
2517             space characters to empty lines.
2518
2519 2010-01-24  Eric Seidel  <eric@webkit.org>
2520
2521         No review, rolling out r53763.
2522         http://trac.webkit.org/changeset/53763
2523         https://bugs.webkit.org/show_bug.cgi?id=33895
2524
2525         Broke 20+ tests on Windows.
2526
2527         * Scripts/run-webkit-tests:
2528         * Scripts/webkitdirs.pm:
2529
2530 2010-01-24  Adam Barth  <abarth@webkit.org>
2531
2532         Rubber stamped by Eric Seidel.
2533
2534         More pep8 compliance.
2535
2536         * Scripts/webkitpy/mock_bugzillatool.py:
2537
2538 2010-01-24  Adam Barth  <abarth@webkit.org>
2539
2540         Rubber stamped by Eric Seidel.
2541
2542         More pep8 compliance.
2543
2544         * Scripts/webkitpy/executive.py:
2545         * Scripts/webkitpy/grammar.py:
2546
2547 2010-01-24  Adam Barth  <abarth@webkit.org>
2548
2549         Rubber stamped by Eric Seidel.
2550
2551         More pep8 compliance.
2552
2553         * Scripts/webkitpy/comments.py:
2554         * Scripts/webkitpy/committers.py:
2555         * Scripts/webkitpy/credentials.py:
2556
2557 2010-01-24  Adam Barth  <abarth@webkit.org>
2558
2559         Rubber stamped by Eric Seidel.
2560
2561         Make changelogs.py pass pep8.
2562
2563         * Scripts/webkitpy/changelogs.py:
2564
2565 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2566
2567         [Qt] Unreviewed build fix
2568
2569         * QtLauncher/QtLauncher.pro:
2570         * QtLauncher/webinspector.h:
2571
2572 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2573
2574         Rubberstamped by Simon Hausmann.
2575
2576         [Qt] Move the WebInspector class to it's own header file.
2577
2578         * QtLauncher/main.cpp:
2579         * QtLauncher/webinspector.h: Added.
2580         (WebInspector::WebInspector):
2581         (WebInspector::showEvent):
2582         (WebInspector::hideEvent):
2583
2584 2010-01-23  Robert Hogan  <robert@roberthogan.net>
2585
2586         Reviewed by Kenneth Rohde Christiansen.
2587
2588         Qt DRT: respect window.close() and window.closed()
2589         
2590         Qt DRT needs to maintain a correct count of open windows
2591         for windowCount(). It also needs to delete windows that
2592         have been closed by window.close().
2593         
2594         This fixes the following tests:
2595         
2596         plugins/destroy-during-npp-new.html
2597         fast/dom/Document/early-document-access.html
2598         fast/dom/Window/window-early-properties.html
2599         fast/events/open-window-from-another-frame.html
2600         fast/events/popup-blocking-click-in-iframe.html
2601         
2602         https://bugs.webkit.org/show_bug.cgi?id=32953
2603
2604         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2605         (WebCore::DumpRenderTree::DumpRenderTree):
2606         (WebCore::DumpRenderTree::createWindow):
2607         (WebCore::DumpRenderTree::windowCloseRequested):
2608         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2609         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2610         (LayoutTestController::maybeDump):
2611
2612 2010-01-23  Dan Bernstein  <mitz@apple.com>
2613
2614         Reviewed by Mark Rowe.
2615
2616         Added a user default for specifying a fallback frameworks path in case
2617         the bundle does not contain frameworks for the current Mac OS X version.
2618
2619         * WebKitLauncher/main.m:
2620         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
2621         keyed by the FallbackSystemVersions user default and returns it.
2622         (main): If a frameworks directory for the current system version is not found,
2623         try the fallback.
2624
2625 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2626
2627         Reviewed by Simon Hausmann.
2628
2629         Make run-webkit-tests work under Cygwin for the Qt port
2630
2631         setPathForRunningWebKitApp() is implemented for the Qt port
2632         by using qmake to query for the location of the Qt libraries.
2633
2634         This requires the original environment (%ENV) to be untouched,
2635         so launchWithCurrentEnv() was refactored to launchWithEnv(),
2636         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
2637         instead. This has the added benefit of getting rid of the temp
2638         variables used for storing the current env.
2639
2640         openDumpTool() is also refactored a bit into platform-spesific,
2641         port-spesific, and generic environment variables.
2642
2643         Checks for undef was added a few places to fix Perl concat
2644         warnings when run-webkit-tests is aborted.
2645
2646         https://bugs.webkit.org/show_bug.cgi?id=33895
2647
2648         * Scripts/run-webkit-tests:
2649         * Scripts/webkitdirs.pm:
2650
2651 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
2652
2653         Reviewed by Kevin Ollivier.
2654
2655         [wx] Remove the Bakefile build system, which is no longer being used.
2656         
2657         https://bugs.webkit.org/show_bug.cgi?id=34022
2658
2659         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2660         * wx/browser/browser.bkl: Removed.
2661         * wx/build-wxwebkit: Removed.
2662
2663 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
2664
2665         Reviewed by Simon Fraser.
2666
2667         Reset zoom level to 1.0 when resetting view state. This is causing
2668         many tests to fail after svg/custom/text-zoom.xhtml changes the
2669         zoom level.
2670
2671         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2672         (resetDefaultsToConsistentValues):
2673
2674 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
2675
2676         Reviewed by Darin Adler.
2677
2678         https://bugs.webkit.org/show_bug.cgi?id=34025
2679         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
2680
2681         * Scripts/build-webkit:
2682
2683 2010-01-22  Adam Barth  <abarth@webkit.org>
2684
2685         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
2686
2687         * Scripts/webkitpy/commands/queues.py:
2688
2689 2010-01-22  Adam Barth  <abarth@webkit.org>
2690
2691         Rubber stamped by Eric Seidel.
2692
2693         Make __init__.py and buildbot.py pass pep8 style checker.
2694
2695         * Scripts/webkitpy/__init__.py:
2696         * Scripts/webkitpy/buildbot.py:
2697
2698 2010-01-21  Joe Mason  <jmason@rim.com>
2699
2700         Reviewed by Adam Barth.
2701
2702         webkit-patch should retry on invalid password
2703         https://bugs.webkit.org/show_bug.cgi?id=33955
2704
2705         Ask for bugs.webkit.org authentication in a loop.
2706
2707         * Scripts/webkitpy/bugzilla.py:
2708
2709 2010-01-22  Adam Barth  <abarth@webkit.org>
2710
2711         Unreviewed.  Don't call seek on a NoneType.
2712
2713         * Scripts/webkitpy/statusserver.py:
2714
2715 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
2716
2717         Reviewed by David Levin.
2718
2719         check-webkit-style breaks on files with unknown types
2720         https://bugs.webkit.org/show_bug.cgi?id=34001
2721
2722         For files with type FileType.NONE, dispatch_processor returns None.
2723
2724         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
2725
2726 2010-01-22  Adam Barth  <abarth@webkit.org>
2727
2728         Reviewed by Eric Seidel.
2729
2730         Make bugzilla.py and webkitport.py conform to pep8
2731         https://bugs.webkit.org/show_bug.cgi?id=34015
2732
2733         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
2734         style as enforced by pep8.py.  I wasn't able to get rid of all the
2735         errors because I'm not sure how to wrap some lines properly.  Also,
2736         there are a few deprication errors that I couldn't resolve easily.
2737         However, this is a massive improvement in compliance.
2738
2739         * Scripts/webkitpy/bugzilla.py:
2740         * Scripts/webkitpy/webkitport.py:
2741
2742 2010-01-22  Adam Barth  <abarth@webkit.org>
2743
2744         Reviewed by Darin Adler.
2745
2746         Limit length of EWS results to 5MB
2747         https://bugs.webkit.org/show_bug.cgi?id=34016
2748
2749         Hopefully this will fix the bug where the results link doesn't appear.
2750         Our current theory is that the results blob is too big and the server
2751         is rejecting the request with a 500 error.  That causes us to re-try
2752         the post, but when we re-try the StringIO buffer has its seek pointer
2753         at the end.
2754
2755         * Scripts/webkitpy/commands/queues.py:
2756         * Scripts/webkitpy/statusserver.py:
2757
2758 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
2759
2760         Reviewed by Adam Barth.
2761
2762         Made check-webkit-style able to check patches when script not
2763         run from source root. Also consolidated external references
2764         to a single file.
2765
2766         https://bugs.webkit.org/show_bug.cgi?id=33791
2767
2768         * Scripts/check-webkit-style:
2769           - Changed to import style_references.py.
2770
2771         * Scripts/webkitpy/style/__init__.py:
2772           - Removed __path__ hack that allowed searching Scripts/ directory.
2773
2774         * Scripts/webkitpy/style/checker.py:
2775           - Changed to import style_references.py.
2776
2777         * Scripts/webkitpy/style_references.py: Added.
2778
2779 2010-01-22  Dmitry Titov  <dimich@chromium.org>
2780
2781         Reviewed by Maciej Stachowiak.
2782
2783         Fix the leak of ThreadIdentifiers in threadMap across threads.
2784         https://bugs.webkit.org/show_bug.cgi?id=32689
2785
2786         Add a new test to verify the ThreadIdentifiers are not reused across threads.
2787         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
2788         waiting for the previous thread to terminate before starting the next.
2789         The treads use WTF::currentThread() in their thread function. Without a fix, this
2790         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
2791         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
2792         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
2793         The test practically does not affect the DRT run time because the threads end immediately.
2794
2795         * DumpRenderTree/mac/DumpRenderTree.mm:
2796         (runThread): Test thread function.
2797         (testThreadIdentifierMap):
2798         (dumpRenderTree):
2799
2800 2010-01-22  Kent Tamura  <tkent@chromium.org>
2801
2802         Reviewed by Maciej Stachowiak.
2803
2804         Fix a bug that mouseDown:withModifiers: is never called.
2805         https://bugs.webkit.org/show_bug.cgi?id=33989
2806
2807         * DumpRenderTree/mac/EventSendingController.mm:
2808         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2809         (+[EventSendingController webScriptNameForSelector:]):
2810
2811 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2812
2813         Rubberstamped by Antti Koivisto.
2814
2815         [Qt] Separate out the WebPage class into it's own
2816         cpp/header files. Also, removed the assumption that
2817         the view is a QWebView, in preparation of a merger
2818         of the two Qt WebKit launchers.
2819
2820         * QtLauncher/QtLauncher.pro:
2821         * QtLauncher/main.cpp:
2822         (WebView::mousePressEvent):
2823         * QtLauncher/webpage.cpp: Added.
2824         (WebPage::supportsExtension):
2825         (WebPage::extension):
2826         (WebPage::acceptNavigationRequest):
2827         (WebPage::openUrlInDefaultBrowser):
2828         * QtLauncher/webpage.h: Added.
2829         (WebPage::WebPage):
2830
2831 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
2832
2833         Reviewed by Shinichiro Hamaji.
2834
2835         Refactored to move file name and file-reading related code
2836         from cpp_style.py and text_style.py to checker.py.
2837
2838         https://bugs.webkit.org/show_bug.cgi?id=33775
2839
2840         * Scripts/check-webkit-style:
2841           - Updates caused by changes to checker.py.
2842
2843         * Scripts/webkitpy/style/checker.py:
2844           - Added SKIPPED_FILES_WITH_WARNING list.
2845           - Added SKIPPED_FILES_WITHOUT_WARNING list.
2846           - Added FileType class.
2847           - Added ProcessorDispatcher class.
2848           - In StyleChecker class:
2849             - Renamed process_patch() to check_patch().
2850             - Renamed process_file() to check_file().
2851             - Added _process_file().
2852             - Related refactoring.
2853             - Addressed check_patch() FIXME to share code with process_file().
2854
2855         * Scripts/webkitpy/style/checker_unittest.py:
2856           - Added ProcessorDispatcherSkipTest class.
2857           - Added ProcessorDispatcherDispatchTest class.
2858           - Added StyleCheckerCheckFileTest class.
2859
2860         * Scripts/webkitpy/style/cpp_style.py:
2861           - Renamed process_file_data() to _process_lines.
2862           - Removed process_file() (moved logic to checker.py).
2863           - Removed can_handle() (moved logic to checker.py).
2864           - Added CppProcessor class.
2865           - Removed is_exempt() (moved logic to checker.py).
2866           - Added process_file_data() back as a wrapper function.
2867
2868         * Scripts/webkitpy/style/cpp_style_unittest.py:
2869           - Removed test_can_handle().
2870           - Removed test_is_exempt().
2871           - Added CppProcessorTest class.
2872
2873         * Scripts/webkitpy/style/text_style.py:
2874           - Added TextProcessor class.
2875           - Removed process_file().
2876           - Removed can_handle().
2877
2878         * Scripts/webkitpy/style/text_style_unittest.py:
2879           - Removed test_can_handle().
2880           - Added TextProcessorTest class.
2881
2882 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
2883
2884         Reviewed by David Kilzer.
2885
2886         Create a unit-tested subroutine to parse patch files created
2887         by svn-create-patch.
2888
2889         https://bugs.webkit.org/show_bug.cgi?id=33475
2890
2891         * Scripts/VCSUtils.pm:
2892           - Added parseDiff().
2893           - Added parsePatch().
2894
2895         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
2896           - Added unit tests for parseDiff().
2897
2898         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2899           - Total number of tests now computed dynamically.
2900
2901         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
2902           - Added unit tests for parsePatch().
2903
2904 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
2905
2906         [wx] Build fix, add new directory to dir list.
2907
2908         * wx/build/settings.py:
2909
2910 2010-01-21  Adam Barth  <abarth@webkit.org>
2911
2912         Reviewed by Eric Seidel.
2913
2914         Make the EWS transactional
2915         https://bugs.webkit.org/show_bug.cgi?id=33978
2916
2917         Now if the EWS gets interrupted in the middle of processing a patch,
2918         the bots will re-process the patch.
2919
2920         * Scripts/test-webkitpy:
2921         * Scripts/webkitpy/commands/queues.py:
2922         * Scripts/webkitpy/commands/queues_unittest.py:
2923         * Scripts/webkitpy/patchcollection.py:
2924         * Scripts/webkitpy/patchcollection_unittest.py: Added.
2925
2926 2010-01-21  Adam Barth  <abarth@webkit.org>
2927
2928         Unreviewed.  Add missing "ago" for style in the status bubble.
2929
2930         * QueueStatusServer/templates/statusbubble.html:
2931
2932 2010-01-21  Adam Barth  <abarth@webkit.org>
2933
2934         Reviewed by David Levin.
2935
2936         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
2937         https://bugs.webkit.org/show_bug.cgi?id=33356
2938
2939         White list unix_hacker_style names in WebKit/gtk/webkit because these
2940         are used in the GTK+ API.
2941
2942         * Scripts/webkitpy/style/cpp_style.py:
2943         * Scripts/webkitpy/style/cpp_style_unittest.py:
2944
2945 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2946
2947         Reviewed by Kenneth Rohde Christiansen.
2948
2949         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
2950         https://bugs.webkit.org/show_bug.cgi?id=33945
2951
2952         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2953         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2954         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2955
2956 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
2957
2958         No review, rolling out 53615 as it causes two
2959         crashes on the bot.
2960
2961         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2962         (WebCore::DumpRenderTree::DumpRenderTree):
2963         (WebCore::DumpRenderTree::createWindow):
2964         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2965         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2966         (LayoutTestController::maybeDump):
2967
2968 2010-01-21  Robert Hogan  <robert@roberthogan.net>
2969
2970         Reviewed by Simon Hausmann.
2971
2972         Qt DRT: respect window.close() and window.closed()
2973
2974         Qt DRT needs to maintain a correct count of open windows
2975         for windowCount(). It also needs to delete windows that
2976         have been closed by window.close().
2977
2978         This fixes the following tests:
2979
2980         plugins/destroy-during-npp-new.html
2981         fast/dom/Document/early-document-access.html
2982         fast/dom/Window/window-early-properties.html
2983         fast/events/open-window-from-another-frame.html
2984         fast/events/popup-blocking-click-in-iframe.html
2985
2986         https://bugs.webkit.org/show_bug.cgi?id=32953
2987
2988         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2989         (WebCore::DumpRenderTree::DumpRenderTree):
2990         (WebCore::DumpRenderTree::createWindow):
2991         (WebCore::DumpRenderTree::windowCloseRequested):
2992         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2993         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2994         (LayoutTestController::maybeDump):
2995
2996 2010-01-20  Eric Seidel  <eric@webkit.org>
2997
2998         No review, rolling out r53593.
2999         http://trac.webkit.org/changeset/53593
3000         https://bugs.webkit.org/show_bug.cgi?id=33496
3001
3002         Re-rollout this patch, the commit-queue should not have landed
3003         it again, but it did due to land-diff and rollout both not
3004         clearing flags.
3005
3006         * Scripts/webkitpy/commands/early_warning_system.py:
3007         * Scripts/webkitpy/commands/queues.py:
3008         * Scripts/webkitpy/queueengine.py:
3009         * Scripts/webkitpy/scm.py:
3010         * Scripts/webkitpy/scm_unittest.py:
3011
3012 2010-01-20  Eric Seidel  <eric@webkit.org>
3013
3014         Reviewed by Adam Barth.
3015
3016         webkit-commit-queue status page is confusing
3017         https://bugs.webkit.org/show_bug.cgi?id=33496
3018
3019         This should improve the status page by removing more Fail messages.
3020         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
3021         to behave more like one another.  This meant moving where the failure reporting was done.
3022         Previously the AbstractReviewQueue always used the parent process to report the error,
3023         while CommitQueue used the subprocess when possible, and the parent only reported errors
3024         that we didn't know how to handle (bugs in the commit-queue itself).
3025         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
3026         in both implementations and required teaching handle_script_error in each to post Fail messages
3027         to the status server instead of calling exit(1).
3028
3029         This will also make the style-queue share more bug posting logic with other queues:
3030         https://bugs.webkit.org/show_bug.cgi?id=33871
3031
3032         * Scripts/webkitpy/commands/early_warning_system.py:
3033          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
3034            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
3035            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
3036            _update_status_for_script_error knows how to post the Fail message to the status server.
3037          - Teach _update_status_for_script_error how to post Fail messages to the status server.
3038         * Scripts/webkitpy/commands/queues.py:
3039          - Remove the try block from process_work_item since the caller already has one.
3040          - Only CC watchers on failure to cut down on commit-queue generated mail.
3041          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
3042          - Abstract _format_script_error_output_for_bug to share code between all queues.
3043          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
3044          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
3045          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
3046          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
3047         * Scripts/webkitpy/queueengine.py:
3048          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
3049         * Scripts/webkitpy/scm.py:
3050          - Add new checkout_revision function.
3051         * Scripts/webkitpy/scm_unittest.py:
3052          - Test our new checkout_revision function.
3053
3054 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
3055
3056         Reviewed by Alexey Proskuryakov.
3057
3058         WebSocket: Missing Request-URI, when no tralling slash in host
3059         https://bugs.webkit.org/show_bug.cgi?id=33689
3060
3061         Update pywebsocket to 0.4.7.1, which supports alias for resource
3062         name, so that we could test for ws://127.0.0.1:8880
3063
3064         * Scripts/run-webkit-tests:
3065         * Scripts/run-webkit-websocketserver:
3066         * pywebsocket/mod_pywebsocket/dispatch.py:
3067         * pywebsocket/mod_pywebsocket/handshake.py:
3068         * pywebsocket/mod_pywebsocket/standalone.py:
3069         * pywebsocket/setup.py:
3070         * pywebsocket/test/test_dispatch.py:
3071         * pywebsocket/test/test_handshake.py:
3072
3073 2010-01-20  Eric Seidel  <eric@webkit.org>
3074
3075         No review, rolling out r53537.
3076         http://trac.webkit.org/changeset/53537
3077         https://bugs.webkit.org/show_bug.cgi?id=33496
3078
3079         Added a failure condition to the commit-queue and looks to
3080         have broken the EWS bots
3081
3082         * Scripts/webkitpy/commands/early_warning_system.py:
3083         * Scripts/webkitpy/commands/queues.py:
3084         * Scripts/webkitpy/queueengine.py:
3085         * Scripts/webkitpy/scm.py:
3086         * Scripts/webkitpy/scm_unittest.py:
3087
3088 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
3089
3090         MSAA: accSelect() is not implemented
3091
3092         https://bugs.webkit.org/show_bug.cgi?id=33918
3093         <rdar://problem/7436861>
3094
3095         Reviewed by Darin Adler.
3096
3097         * DumpRenderTree/AccessibilityUIElement.cpp:
3098         (takeFocusCallback):
3099         Call the object's takeFocus() function.
3100         (takeSelectionCallback):
3101         Call its takeSelection() function.
3102         (addSelectionCallback):
3103         Call its addSelection() function.
3104         (removeSelectionCallback):
3105         Call its removeSelection() function.
3106         (AccessibilityUIElement::getJSClass):
3107         Add new functions to the JS class definition.
3108
3109         * DumpRenderTree/AccessibilityUIElement.h:
3110         Declare new functions.
3111
3112         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3113         (AccessibilityUIElement::takeFocus):
3114         Stubbed.
3115         (AccessibilityUIElement::takeSelection):
3116         Stubbed.
3117         (AccessibilityUIElement::addSelection):
3118         Stubbed.
3119         (AccessibilityUIElement::removeSelection):
3120         Stubbed.
3121
3122         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3123         (AccessibilityUIElement::takeFocus):
3124         Stubbed.
3125         (AccessibilityUIElement::takeSelection):
3126         Stubbed.
3127         (AccessibilityUIElement::addSelection):
3128         Stubbed.
3129         (AccessibilityUIElement::removeSelection):
3130         Stubbed.
3131
3132         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3133         (AccessibilityUIElement::takeFocus):
3134         Call the object's accSelect() function, passing the appropriate flag.
3135         (AccessibilityUIElement::takeSelection):
3136         Ditto.
3137         (AccessibilityUIElement::addSelection):
3138         Ditto.
3139         (AccessibilityUIElement::removeSelection):
3140         Ditto.
3141
3142 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
3143
3144         Reviewed by Alexey Proskuryakov.
3145
3146         Extract Apache handling to httpd.pm module and use the provided functionality
3147         in scripts where Apache is needed.
3148         The module httpd.pm stores the PID of Apache in a variable and cleans up
3149         the PID directory after Apache properly shut down. Catching INT and TERM
3150         signals allows the scripts to close Apache and clean up its PID directory
3151         even if the testing was interrupted.
3152
3153         https://bugs.webkit.org/show_bug.cgi?id=33153
3154
3155         * Scripts/webkitperl/httpd.pm: Added.
3156         * Scripts/run-iexploder-tests:
3157         * Scripts/run-webkit-httpd:
3158         * Scripts/run-webkit-tests:
3159
3160 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3161
3162         Reviewed by Simon Hausmann.
3163
3164         [Qt] Make DumpRenderTree build on Windows
3165
3166         * DumpRenderTree/qt/DumpRenderTree.pro:
3167         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3168         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3169         * DumpRenderTree/qt/main.cpp:
3170
3171 2010-01-20  Steve Block  <steveblock@google.com>
3172
3173         Reviewed by Eric Seidel.
3174
3175         Fix commit bot to land patches in order of the bug last modification date.
3176         https://bugs.webkit.org/show_bug.cgi?id=33395
3177
3178         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
3179
3180 2010-01-20  Adam Barth  <abarth@webkit.org>
3181
3182         Reviewed by Eric Seidel.
3183
3184         Teach check-webkit-style about WebKit/gtk/tests
3185         https://bugs.webkit.org/show_bug.cgi?id=33892
3186
3187         Removes false positives found in
3188         https://bugs.webkit.org/show_bug.cgi?id=30883
3189
3190         * Scripts/webkitpy/style/cpp_style.py:
3191         * Scripts/webkitpy/style/cpp_style_unittest.py:
3192
3193 2010-01-20  Adam Barth  <abarth@webkit.org>
3194
3195         Reviewed by Eric Seidel.
3196
3197         Teach check-webkit-style about QGVLauncher
3198         https://bugs.webkit.org/show_bug.cgi?id=33890
3199
3200         Remove false positives found in
3201         https://bugs.webkit.org/show_bug.cgi?id=33708
3202
3203         * Scripts/webkitpy/style/cpp_style.py:
3204         * Scripts/webkitpy/style/cpp_style_unittest.py:
3205
3206 2010-01-20  Eric Seidel  <eric@webkit.org>
3207
3208         Reviewed by Adam Barth.
3209
3210         webkit-commit-queue status page is confusing
3211         https://bugs.webkit.org/show_bug.cgi?id=33496
3212
3213         This should improve the status page by removing more Fail messages.
3214         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
3215         to behave more like one another.  This meant moving where the failure reporting was done.
3216         Previously the AbstractReviewQueue always used the parent process to report the error,
3217         while CommitQueue used the subprocess when possible, and the parent only reported errors
3218         that we didn't know how to handle (bugs in the commit-queue itself).
3219         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
3220         in both implementations and required teaching handle_script_error in each to post Fail messages
3221         to the status server instead of calling exit(1).
3222
3223         This will also make the style-queue share more bug posting logic with other queues:
3224         https://bugs.webkit.org/show_bug.cgi?id=33871
3225
3226         * Scripts/webkitpy/commands/early_warning_system.py:
3227          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
3228            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
3229            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
3230            _update_status_for_script_error knows how to post the Fail message to the status server.
3231          - Teach _update_status_for_script_error how to post Fail messages to the status server.
3232         * Scripts/webkitpy/commands/queues.py:
3233          - Remove the try block from process_work_item since the caller already has one.
3234          - Only CC watchers on failure to cut down on commit-queue generated mail.
3235          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
3236          - Abstract _format_script_error_output_for_bug to share code between all queues.
3237          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
3238          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
3239          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
3240          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
3241         * Scripts/webkitpy/queueengine.py:
3242          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
3243         * Scripts/webkitpy/scm.py:
3244          - Add new checkout_revision function.
3245         * Scripts/webkitpy/scm_unittest.py:
3246          - Test our new checkout_revision function.
3247
3248 2010-01-20  Adam Barth  <abarth@webkit.org>
3249
3250         Reviewed by Darin Adler.
3251
3252         Exempt JavaScriptCore/qt/api from style checks
3253         https://bugs.webkit.org/show_bug.cgi?id=33879
3254
3255         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
3256         API.
3257
3258         * Scripts/webkitpy/style/cpp_style.py:
3259         * Scripts/webkitpy/style/cpp_style_unittest.py:
3260
3261 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3262
3263         Reviewed by Simon Hausmann.
3264
3265         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
3266
3267         QSocketNotifier is not available on Windows. Instead we read
3268         stdin synchronously after each test using signals and slots.
3269
3270         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3271         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3272         * DumpRenderTree/qt/main.cpp:
3273
3274 2010-01-19  Adam Barth  <abarth@webkit.org>
3275
3276         Rubber stamped by Eric Seidel.
3277
3278         Move chromium-ews back to building release only to make the EWS faster.
3279
3280         * Scripts/webkitpy/commands/early_warning_system.py:
3281
3282 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
3283
3284         MSAA: The child <option> elements of a non-multiple <select> are not
3285         exposed
3286
3287         https://bugs.webkit.org/show_bug.cgi?id=33773
3288         <rdar://problem/7550556>
3289
3290         Reviewed by Alice Liu.
3291
3292         * DumpRenderTree/AccessibilityUIElement.cpp:
3293         (getIsVisibleCallback):
3294         Call the object's isVisible() function.
3295         (getIsOffScreenCallback):
3296         Ditto, for isOffScreen().
3297         (getIsCollapsedCallback):
3298         Ditto, for isCollapsed().
3299         (getHasPopupCallback):
3300         Ditto, for hasPopup().
3301         (AccessibilityUIElement::getJSClass):
3302         Add isVisible and isOffScreen attributes.
3303
3304         * DumpRenderTree/AccessibilityUIElement.h:
3305         Declare new functions.
3306
3307         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3308         (AccessibilityUIElement::isVisible):
3309         Stubbed.
3310         (AccessibilityUIElement::isOffScreen):
3311         Stubbed.
3312         (AccessibilityUIElement::isCollapsed):
3313         Stubbed.
3314         (AccessibilityUIElement::hasPopup):
3315         Stubbed.
3316
3317         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3318         (AccessibilityUIElement::isVisible):
3319         Stubbed.
3320         (AccessibilityUIElement::isOffScreen):
3321         Stubbed.
3322         (AccessibilityUIElement::isCollapsed):
3323         Stubbed.
3324         (AccessibilityUIElement::hasPopup):
3325         Stubbed.
3326
3327         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3328         (AccessibilityUIElement::showMenu):
3329         Call the object's accDoDefaultAction() to show its popup menu.
3330         (AccessibilityUIElement::isEnabled):
3331         Check that the object does not have the "unavailable" state.
3332         (AccessibilityUIElement::isVisible):
3333         Check that the object does not have the "invisible" state.
3334         (AccessibilityUIElement::isOffScreen):
3335         Check whether the object has the "offscreen" state.
3336         (AccessibilityUIElement::isCollapsed):
3337         Check whether the object has the "collapsed" state.
3338         (AccessibilityUIElement::hasPopup):
3339         Check whether the object has the "has popup" state.
3340
3341 2010-01-19  Victor Wang  <victorw@chromium.org>
3342
3343         Reviewed by Eric Seidel.
3344
3345         Correct committer name.
3346         https://bugs.webkit.org/show_bug.cgi?id=33868
3347
3348         * Scripts/webkitpy/committers.py:
3349
3350 2010-01-19  Kent Tamura  <tkent@chromium.org>
3351
3352         Reviewed by Darin Adler.
3353
3354         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
3355         https://bugs.webkit.org/show_bug.cgi?id=33783
3356
3357         Some listbox tests check selection behavior by click events with
3358         "meta" or "shift" keys. Behaviors for such modifier keys are
3359         platform-dependent. The new parameter of mouseDown() and mouseUp()
3360         allows to specify not only concrete modifier keys such as
3361         "shiftKey" "metaKey", but also functional names like
3362         "addSelectionKey" "rangeSelectionKey".
3363
3364         * DumpRenderTree/mac/EventSendingController.mm:
3365         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3366         (+[EventSendingController webScriptNameForSelector:]):
3367         (buildModifierFlags):
3368         (-[EventSendingController mouseDown:withModifiers:]):
3369         (-[EventSendingController mouseDown:]):
3370         (-[EventSendingController mouseUp:withModifiers:]):
3371         (-[EventSendingController mouseUp:]):
3372         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3373
3374 2010-01-19  Adam Barth  <abarth@webkit.org>
3375
3376         Reviewed by Eric Seidel.
3377
3378         Unbreak --request-commit
3379         https://bugs.webkit.org/show_bug.cgi?id=33832
3380
3381         * Scripts/webkitpy/bugzilla.py:
3382
3383 2010-01-19  Eric Seidel  <eric@webkit.org>
3384
3385         Reviewed by Adam Barth.
3386
3387         validate-committer-lists throws exception and committers.py needs a refresh
3388         https://bugs.webkit.org/show_bug.cgi?id=33831
3389
3390         * Scripts/validate-committer-lists: use webkit_logging
3391         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
3392
3393 2010-01-18  Adam Roben  <aroben@apple.com>
3394
3395         Add LayoutTestController support for calling new WebKit SPI to
3396         disallow setting document.domain
3397
3398         DRT part of fixing <http://webkit.org/b/33806>
3399         <rdar://problem/7552837> Would like API to disallow setting of
3400         document.domain for pages with certain URL schemes
3401
3402         Reviewed by Sam Weinig.
3403
3404         * DumpRenderTree/LayoutTestController.cpp:
3405         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
3406         through to LayoutTestController.
3407         (LayoutTestController::staticFunctions): Added
3408         setDomainRelaxationForbiddenForURLScheme.
3409
3410         * DumpRenderTree/LayoutTestController.h: Added
3411         setDomainRelaxationForbiddenForURLScheme.
3412
3413         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3414         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3415         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3416         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3417         Added. Calls through to WebKit.
3418
3419         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3420         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3421         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3422         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3423         Stubbed out.
3424
3425 2010-01-18  Adam Barth  <abarth@webkit.org>
3426
3427         Reviewed by Adam Roben.
3428
3429         Rename patches-to-commit to patches-in-commit-queue
3430         https://bugs.webkit.org/show_bug.cgi?id=33789
3431
3432         The command really lists the patches in the commit-queue not all the
3433         patches that are pending-commit (as the FIXME commands).
3434
3435         * Scripts/webkitpy/commands/queries.py:
3436         * Scripts/webkitpy/commands/queries_unittest.py:
3437
3438 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3439
3440         Reviewed by Simon Hausmann.
3441
3442         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
3443
3444         * Scripts/webkitdirs.pm:
3445
3446 2010-01-18  Adam Roben  <aroben@apple.com>
3447
3448         Clean up use of /useenv when invoking Visual C++
3449
3450         This change reverts things to their pre-r49485 state. That revision
3451         (and, subsequently, r49664 and r51788) started passing /useenv to
3452         Visual C++, even in cases where we don't want to do so (such as when
3453         invoking Visual C++ Express), in the name of making the Chromium build
3454         work. Now that Chromium isn't using buildVisualStudioProject or
3455         pdevenv, we can put things back they way they were.
3456
3457         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
3458         (due to /useenv flag)
3459
3460         Reviewed by Sam Weinig.
3461
3462         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
3463         script anymore.
3464         * Scripts/webkitdirs.pm:
3465         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
3466         care of this itself, and we don't want to pass /useenv when not using
3467         pdevenv (e.g., when using VC++ Express, because that will cause it to
3468         ignore the Platform SDK).
3469
3470 2010-01-18  Adam Barth  <abarth@webkit.org>
3471
3472         Reviewed by Eric Seidel.
3473
3474         webkit-patch land-safely should obsolete old patches
3475         https://bugs.webkit.org/show_bug.cgi?id=33788
3476
3477         When posting a commit-queue+ patch with land-safely, we should
3478         obsolete the old patches on the bug.  They're really confusing
3479         because the main use case is to address reviewer feedback on a
3480         previous patch.
3481
3482         * Scripts/webkitpy/commands/upload.py:
3483         * Scripts/webkitpy/commands/upload_unittest.py:
3484
3485 2010-01-18  Adam Barth  <abarth@webkit.org>
3486
3487         Reviewed by David Levin.
3488
3489         webkit-patch should authenticate more often
3490         https://bugs.webkit.org/show_bug.cgi?id=33701
3491
3492         This makes it easier to work with security patches.
3493
3494         * Scripts/webkitpy/bugzilla.py:
3495
3496 2010-01-18  Adam Barth  <abarth@webkit.org>
3497
3498         Reviewed by Darin Adler.
3499
3500         style checker needs to know about GObject-specific requirements
3501         inside WebCore/bindings/gobject/
3502         https://bugs.webkit.org/show_bug.cgi?id=33606
3503
3504         Add an exception to the underscore rule for certain
3505         GObject-specific names.
3506
3507         * Scripts/webkitpy/style/cpp_style.py:
3508         * Scripts/webkitpy/style/cpp_style_unittest.py:
3509
3510 2010-01-18  Adam Barth  <abarth@webkit.org>
3511
3512         Reviewed by Shinichiro Hamaji.
3513
3514         [check-webkit-style] does understand ResourceHandleWin.h
3515         https://bugs.webkit.org/show_bug.cgi?id=32975
3516
3517         I'm not 100% convinced this fix is correct, but without more examples,
3518         it's hard to generalize.  We can always generalize the fix in the
3519         future.
3520
3521         * Scripts/webkitpy/style/cpp_style.py:
3522         * Scripts/webkitpy/style/cpp_style_unittest.py:
3523
3524 2010-01-18  Adam Barth  <abarth@webkit.org>
3525
3526         Unreviewed "build" fix.
3527
3528         * Scripts/webkitpy/bugzilla.py:
3529
3530 2010-01-18  Adam Barth  <abarth@webkit.org>
3531
3532         Unreviewed.  Actually make land-safely mark commit-queue+ as
3533         discussed with Eric.
3534
3535         * Scripts/webkitpy/bugzilla.py:
3536         * Scripts/webkitpy/steps/postdiffforcommit.py:
3537
3538 2010-01-17  Adam Barth  <abarth@webkit.org>
3539
3540         Reviewed by Darin Adler.
3541
3542         style-queue complains about one-line macros that include multiple statements
3543         https://bugs.webkit.org/show_bug.cgi?id=33173
3544
3545         Add an exception for multiple statements on a line that starts a macro.
3546
3547         * Scripts/webkitpy/style/cpp_style.py:
3548         * Scripts/webkitpy/style/cpp_style_unittest.py:
3549
3550 2010-01-17  Adam Barth  <abarth@webkit.org>
3551
3552         Reviewed by Darin Adler.
3553
3554         [check-webkit-style] qt unit testing false positives
3555         https://bugs.webkit.org/show_bug.cgi?id=32833
3556
3557         Exempt the Qt API and unit tests from the style checker.
3558
3559         * Scripts/webkitpy/style/cpp_style.py:
3560         * Scripts/webkitpy/style/cpp_style_unittest.py:
3561
3562 2010-01-17  Adam Barth  <abarth@webkit.org>
3563
3564         Reviewed by Darin Adler.
3565
3566         style-check script reports loads of errors on gtk2drawing.c
3567         https://bugs.webkit.org/show_bug.cgi?id=33771
3568
3569         Exempt WebCore/platform/gtk/gtk2drawing.c and
3570         WebCore/platform/gtk/gtk2drawing.h from style checks.
3571
3572         * Scripts/webkitpy/style/cpp_style.py:
3573         * Scripts/webkitpy/style/cpp_style_unittest.py:
3574
3575 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
3576
3577         Reviewed by Shinichiro Hamaji.
3578
3579         Finished eliminating _cpp_style_state global state variable from
3580         check-webkit-style code and eliminating _CppStyleState class.
3581
3582         https://bugs.webkit.org/show_bug.cgi?id=33764
3583
3584         * Scripts/webkitpy/style/checker.py:
3585           - Minor updates caused by changes to cpp_style.py.
3586
3587         * Scripts/webkitpy/style/cpp_style.py:
3588           - Removed _CppStyleState class.
3589           - Removed verbose_level functions.
3590           - Added verbosity as a parameter to _FunctionState constructor.
3591           - Added verbosity as a parameter to process_file().
3592           - Added verbosity as a parameter to process_file_data().
3593
3594         * Scripts/webkitpy/style/cpp_style_unittest.py:
3595           - Added helper functions to set verbosity while running tests.
3596
3597 2010-01-17  Adam Barth  <abarth@webkit.org>
3598
3599         Reviewed by Shinichiro Hamaji.
3600
3601         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
3602         https://bugs.webkit.org/show_bug.cgi?id=33663
3603
3604         * Scripts/webkitpy/style/cpp_style.py:
3605         * Scripts/webkitpy/style/cpp_style_unittest.py:
3606
3607 2010-01-17  Adam Barth  <abarth@webkit.org>
3608
3609         Reviewed by Eric Seidel.
3610
3611         style-queue complains about missing #include of config.h for non-WebCore projects
3612         https://bugs.webkit.org/show_bug.cgi?id=33170
3613
3614         WebKitAPITests are consumers of the WebKit API and therefore do not
3615         need to follow the same include discipline as the rest of WebKit.  This
3616         patch exempts them from the include checks.
3617
3618         * Scripts/webkitpy/style/cpp_style.py:
3619         * Scripts/webkitpy/style/cpp_style_unittest.py:
3620
3621 2010-01-17  Adam Barth  <abarth@webkit.org>
3622
3623         Reviewed by Eric Seidel.
3624
3625         EWS (Early Warning Systems) should build both debug and release
3626         https://bugs.webkit.org/show_bug.cgi?id=33681
3627
3628         Build both debug and release for chromium-ews.
3629
3630         * Scripts/webkitpy/commands/early_warning_system.py:
3631
3632 2010-01-17  Adam Barth  <abarth@webkit.org>
3633
3634         Reviewed by Darin Adler.
3635
3636         style-queue should include instructions for how to file bugs against check-webkit-style
3637         https://bugs.webkit.org/show_bug.cgi?id=32345
3638
3639         Added some text to the error message asking folks to file bugs against
3640         false positives.
3641
3642         * Scripts/webkitpy/commands/queues.py:
3643
3644 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
3645
3646         Reviewed by Adam Barth.
3647
3648         Eliminated the error_count global variable and related
3649         check-webkit-style refactoring.
3650
3651         https://bugs.webkit.org/show_bug.cgi?id=33678
3652
3653         * Scripts/check-webkit-style:
3654           - Updated to use webkit_argument_defaults().
3655           - Renamed styleChecker to style_checker.
3656
3657         * Scripts/webkitpy/style/checker.py:
3658           - Prefixed the three default arguments with WEBKIT_DEFAULT.
3659           - Added webkit_argument_defaults().
3660           - Added default filter_rules parameter to CategoryFilter constructor.
3661           - Added __ne__() to CategoryFilter class.
3662           - Added __eq__() and __ne__() to ProcessorOptions class.
3663           - Added error_count and _write_error attributes to StyleChecker class.
3664           - Made StyleChecker._handle_error() increment the error count.
3665
3666         * Scripts/webkitpy/style/checker_unittest.py:
3667           - Improved CategoryFilterTest.test_eq().
3668           - Added CategoryFilterTest.test_ne().
3669           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
3670           - Updated unit tests to use webkit_argument_defaults().
3671           - Added StyleCheckerTest class.
3672
3673         * Scripts/webkitpy/style/cpp_style.py:
3674           - Removed references to global error_count.
3675
3676         * Scripts/webkitpy/style/cpp_style_unittest.py:
3677