2007-12-26 Jan Michael Alonzo <jmalonzo@unpluggable.com>
[WebKit.git] / WebKitTools / ChangeLog
1 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
2
3         Reviewed by Alp Toker.
4
5         http://bugs.webkit.org/show_bug.cgi?id=16390
6         Use autotools or GNU make as the build system for the GTK port
7
8         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
9         * GNUmakefile.am: Added.
10
11 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
12
13         Reviewed by Oliver.
14
15         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
16
17         * DumpRenderTree/win/EventSender.cpp:
18         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
19         of 1, even though WebKit currently ignores it.
20
21 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
22
23         wx buildbot fix. Update libpng dl script to the latest version.
24
25         * wx/install-unix-extras:
26
27 2007-12-22  Antti Koivisto  <antti@apple.com>
28
29         Fix a typo.
30
31         * Scripts/webkitdirs.pm:
32
33 2007-12-21  Sam Weinig  <sam@webkit.org>
34
35         Reviewed by Mark Rowe.
36
37         - Disable the back/forward cache using the new WebPreferences API
38           instead of through the BackForwardList.  This makes us match what
39           we do on Windows.
40
41         * DumpRenderTree/mac/DumpRenderTree.mm:
42         (createWebViewAndOffscreenWindow):
43         (setDefaultsToConsistentValuesForTesting):
44
45 2007-12-21  Dan Bernstein  <mitz@apple.com>
46
47         Reviewed by Mark Rowe.
48
49         - disable the back/forward cache in Windows DumpRenderTree. It is
50           already disabled in Mac DumpRenderTree.
51
52         * DumpRenderTree/win/DumpRenderTree.cpp:
53         (initializePreferences):
54
55 2007-12-13  Antti Koivisto  <antti@apple.com>
56
57         Reviewed by Darin and Steve.
58         
59         - check for QuickTime SDK on Windows.
60         - build media support on Windows by default
61
62         * Scripts/build-webkit:
63         * Scripts/webkitdirs.pm:
64
65 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
66
67         Build script fix for buildbot.
68
69         * wx/build-wxwebkit:
70
71 2007-12-20  Eric Seidel  <eric@webkit.org>
72
73         Reviewed by mjs.
74
75         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
76
77 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
78
79         Reviewed by Steve.
80
81         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
82         WebKit.
83
84         - Drosera and Safari need to use the same ProgIDs in order for
85         CoCreateInstance to work properly.  The most robust way to do this is
86         for WebKit to dynamically publish those ProgIDs.
87
88         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
89         (DebuggerClient::createWebViewWithRequest):
90         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
91         statics.
92         (Drosera::initUI):
93         (Drosera::attach):
94         (Drosera::attemptToCreateServerConnection):
95         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
96         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
97         make use of the published ProgIDs.
98         (ServerConnection::attemptToCreateServerConnection):
99
100 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
101
102         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
103         - Build bot and leak fix.
104
105         * DumpRenderTree/LayoutTestController.cpp:
106         (pathToLocalResourceCallback):
107
108 2007-12-19  David Kilzer  <ddkilzer@apple.com>
109
110         Make svn-apply/svn-unapply work with patches from git-format-patch.
111
112         Reviewed by Darin.
113
114         * Scripts/svn-apply:
115         (patch): If 'Index:' can't be found in the text passed in, print it
116         out with a warning and return early.
117         * Scripts/svn-unapply:
118         (patch): Ditto.
119
120 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
121
122         Reviewed by Alp Toker.
123
124         Build related fixes.
125
126         * wx/build-wxwebkit:
127         - Check to make sure the user is running a supported wx port
128         - More robust checks for Cygwin
129         - Only run install-unix-extras on Mac, it's not the right solution
130           for Linux distros.
131         - Remove outdated Linux instructions after successful build
132         - Clean Bakefile-generated files during a clean operation
133
134 2007-12-18  Darin Adler  <darin@apple.com>
135
136         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
137
138 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
139
140         Add script to run Drosera as part of the nightly.
141         
142         Reviewed by Kevin M.
143
144         * Scripts/run-drosera.cmd: Added.
145
146 2007-12-18  Darin Adler  <darin@apple.com>
147
148         * Scripts/do-webcore-rename: Remove a stray K.
149
150 2007-12-18  Darin Adler  <darin@apple.com>
151
152         * Scripts/do-webcore-rename: Plan more renaming.
153
154 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
155
156         Reviewed by Alp Toker.
157
158         http://bugs.webkit.org/show_bug.cgi?id=16042
159         [GTK] Eliminate webkit_init()
160
161         Moving webkit initialization to WebView class init.
162
163         * DumpRenderTree/gtk/DumpRenderTree.cpp:
164         (main):
165         * GtkLauncher/main.c:
166         (main):
167
168 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
169
170         Reviewed by Alp Toker.
171
172         http://bugs.webkit.org/show_bug.cgi?id=13542
173         gdklauncher doesnt change URL in adress GTKEntry.
174
175         * GtkLauncher/main.c:
176         (load_commit_cb): added
177         (title_change_cb):
178         (create_browser):
179
180 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
181
182         Reviewed by Adam Roben.
183
184         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
185
186         * FindSafari/FindSafari.cpp:
187         (_tmain):
188
189 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
190
191         Reviewed by Adam Roben.
192
193         http://bugs.webkit.org/show_bug.cgi?id=16315
194         FindSafari needs a path-only option.
195
196         * FindSafari/FindSafari.cpp:
197         (_tmain):
198
199 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
200
201         Reviewed by Darin.
202
203         http://bugs.webkit.org/show_bug.cgi?id=16462
204         REGRESSION: access keys broken on Windows
205
206         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
207         if Alt is pressed.
208
209 2007-12-15  Sam Weinig  <sam@webkit.org>
210
211         Reviewed by Mark Rowe.
212
213         Fix urlSuitableForTestResult to correctly identify wstring::npos as
214         the case when wstring.find doesn't find anything.
215
216         * DumpRenderTree/win/DumpRenderTree.cpp:
217         (urlSuitableForTestResult):
218
219 2007-12-15  Alp Toker  <alp@atoker.com>
220
221         GTK+ DRT build fix for GLib < 2.14.
222
223         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
224         (LayoutTestController::setWaitToDump):
225
226 2007-12-05  Mark Rowe  <mrowe@apple.com>
227
228         Reviewed by Alp Toker.
229
230         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
231         many layout tests from hanging while waiting on user responses to dialogs.
232
233         * DumpRenderTree/gtk/DumpRenderTree.cpp:
234         (invalidateAnyPreviousWaitToDumpWatchdog):
235         (webViewScriptAlert):
236         (webViewScriptPrompt):
237         (webViewScriptConfirm):
238         (main):
239         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
240         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
241         (waitToDumpWatchdogFired):
242         (LayoutTestController::setWaitToDump):
243
244 2007-12-05  Mark Rowe  <mrowe@apple.com>
245
246         Reviewed by Alp Toker.
247
248         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
249
250         * DumpRenderTree/gtk/DumpRenderTree.cpp:
251         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
252         (dump):
253         (runTest):
254         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
255         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
256         work queue is empty.
257         (webViewWindowObjectCleared): Set up window.layoutTestController.
258         (webViewConsoleMessage): Match the console message format expected by the layout test results.
259         (main): Hook up the new signals.
260         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
261         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
262         dumping multiple times.
263         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
264         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
265
266 2007-12-14  Anders Carlsson  <andersca@apple.com>
267
268         Reviewed by Brady.
269
270         Assert that a web frame that's loading a resource always has either a data source or 
271         a provisional data source.
272         
273         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
274         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
275
276 2007-12-14  Darin Adler  <darin@apple.com>
277
278         - fix mistake causing nearly all tests to fail on Windows
279
280         * DumpRenderTree/win/UIDelegate.cpp:
281         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
282         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
283
284         * DumpRenderTree/mac/UIDelegate.mm:
285         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
286         than passing the entire message.
287
288 2007-12-14  Darin Adler  <darin@apple.com>
289
290         - fix Tiger build
291
292         * DumpRenderTree/mac/UIDelegate.mm:
293         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
294         new-to-Leopard methods.
295
296 2007-12-14  Darin Adler  <darin@apple.com>
297
298         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
299         since it now triggers unwanted icon loading. We only had it because we implemented "all"
300         delegate methods here.
301
302 2007-12-14  Anders Carlsson  <andersca@apple.com>
303
304         Reviewed by Darin and Geoff.
305
306         <rdar://problem/5619295> 
307         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
308         
309         Add property getting methods to the plug-in.
310         
311         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
312         (pluginInvoke):
313
314 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
315
316         Reviewed by Darin.
317
318         - Layout test fix for mac. When dumped to the console local file paths
319         now only show the name of the resource not the whole path.  This is to
320         make the results machine and OS independent.
321
322         * DumpRenderTree/mac/UIDelegate.mm:
323         (-[UIDelegate webView:addMessageToConsole:]):
324
325 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
326
327         Reviewed by Adam.
328
329         - Layout tests fix.  We need a way to remove machine-dependent
330         information from paths in layout test results. The UIDelegate now does
331         this.
332
333         * DumpRenderTree/DumpRenderTree.h:
334         * DumpRenderTree/win/DumpRenderTree.cpp:
335         (urlSuitableForTestResult):
336         * DumpRenderTree/win/DumpRenderTreeWin.h:
337         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
338         * DumpRenderTree/win/UIDelegate.cpp:
339         (UIDelegate::webViewAddMessageToConsole):
340
341 2007-12-13  Alp Toker  <alp@atoker.com>
342
343         Build fix for DRT breakage introduced in r28690.
344
345         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
346         (LayoutTestController::pathToLocalResource):
347
348 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
349
350         Reviewed by Alice and Sam.
351
352         - <rdar://5621435> Need a way to specify local resources (being loaded
353         from HTTP tests) on Windows.
354         - Implemented pathToLocalResource which exposes the functionality of
355         converting a given unix path to the correct location on Windows.
356
357         * DumpRenderTree/LayoutTestController.cpp:
358         (pathToLocalResourceCallback):
359         (LayoutTestController::staticFunctions):
360         * DumpRenderTree/LayoutTestController.h:
361         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
362         (LayoutTestController::pathToLocalResource):
363         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
364         (LayoutTestController::pathToLocalResource):
365
366 2007-12-12  Anders Carlsson  <andersca@apple.com>
367
368         Reviewed by Sam.
369
370         <rdar://problem/5132003>
371         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
372
373         * DumpRenderTree/win/DumpRenderTree.cpp:
374         (main):
375         Set the resource load delegate.
376         
377         * DumpRenderTree/win/DumpRenderTree.vcproj:
378         
379         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
380         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
381
382 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
383
384         Reviewed by Adam Roben.
385
386         Fix conversion from double to LPARAM in dispatchMessage().
387
388         * DumpRenderTree/win/EventSender.cpp:
389         (dispatchMessageCallback):
390
391 2007-12-11  Dan Bernstein  <mitz@apple.com>
392
393         Reviewed by Mark Rowe and Sam Weinig too!
394
395         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
396           fonts DumpRenderTree registers.
397
398         * DumpRenderTree/win/DumpRenderTree.cpp:
399         (initialize):
400
401 2007-12-11  Brady Eidson  <beidson@apple.com>
402
403         Reviewed by Anders
404
405         Make DumpRenderTree on mac use its own path for Databases testing
406
407         * DumpRenderTree/mac/DumpRenderTree.mm:
408         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
409           for future DRT-only use, then use it to construct the Databases path and set that default
410
411 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
412
413         Reviewed by Darin.
414
415         <rdar://problem/5535636>
416         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
417
418         http://bugs.webkit.org/show_bug.cgi?id=13916
419         JavaScript detects Tab as a character input on a textfield validation
420
421         * DumpRenderTree/mac/EventSendingController.mm:
422         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
423         Dispatch a keyup to better match what happens when a key is physically pressed.
424
425         * DumpRenderTree/win/EventSender.cpp:
426         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
427         returning from keyDown().
428         (getConstantCallback): Fixed a couple copy/paste mistakes.
429
430 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
431
432         Reviewed by Oliver.
433
434         - <rdar://5599845> Drosera: Does not show loal files in the file list
435         on the left side.
436
437         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
438         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
439         so the open source community can build.
440
441 2007-12-10  Brady Eidson  <beidson@apple.com>
442
443         Rubberstamped by Sam Weinig
444
445         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
446
447         * DumpRenderTree/mac/UIDelegate.mm:
448         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
449         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
450
451 2007-12-08  Oliver Hunt  <oliver@apple.com>
452
453         Reviewed by Sam W.
454
455         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
456         
457         Fixes <rdar://problem/5620249> Must disable SVG animation
458         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
459         
460         In order to allow finer grained control over the set of SVG features
461         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
462         distinct flags:
463         ENABLE_SVG_ANIMATION
464         ENABLE_SVG_FILTERS
465         ENABLE_SVG_FONTS
466         ENABLE_SVG_AS_IMAGE
467         ENABLE_SVG_USE
468         
469         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
470         
471         Script handles all the new build flags, and allows --svg-experimental
472         to automatically enable all features.
473
474         * Scripts/build-webkit:
475
476 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
477
478         Fix version parsing.
479
480         Rubber-stamped by Oliver.
481
482         * Drosera/win/Drosera.vcproj/auto-version.sh:
483
484 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
485
486         Build modifications for Drosera.
487
488         Reviewed by Adam.
489
490         * Drosera/DroseraWin.make: Added.
491         * Drosera/win/Drosera.vcproj/Drosera.rc:
492         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
493         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
494         * Drosera/win/Drosera.vcproj/VERSION: Added.
495         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
496
497 2007-12-06  Adam Roben  <aroben@apple.com>
498
499         Explicitly turn on the Mac font ascent hack on Windows
500
501         This keeps our font metrics matching those from Mac.
502
503         Reviewed by Hyatt.
504
505         * DumpRenderTree/win/DumpRenderTree.cpp:
506         (main):
507
508 2007-12-06  Anders Carlsson  <andersca@apple.com>
509
510         Rename main.c to main.cpp here too.
511         
512         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
513
514 2007-12-06  Sam Weinig  <sam@webkit.org>
515
516         Rubber stamped by Geoff.
517
518         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
519
520 2007-12-06  Darin Adler  <darin@apple.com>
521
522         * Scripts/do-webcore-rename: Some more renaming plans.
523
524 2007-12-06  Anders Carlsson  <andersca@apple.com>
525
526         Restore implementation of testGetIntIdentifier that was accidentally
527         removed somehow (possibly when I made PluginObject be a cpp file).
528         
529         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
530         (pluginInvoke):
531
532 2007-12-05  Anders Carlsson  <andersca@apple.com>
533
534         Make the entry points extern "C".
535         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
536         
537 2007-12-05  Anders Carlsson  <andersca@apple.com>
538
539         C++ warning fixes.
540         
541         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
542         (NPP_New):
543         (NPP_Destroy):
544         (NPP_SetWindow):
545         (NPP_NewStream):
546         (NPP_HandleEvent):
547         (NPP_URLNotify):
548         (NPP_GetValue):
549
550 2007-12-05  Anders Carlsson  <andersca@apple.com>
551
552         Add the .cpp files to the TestNetscapePlugIn target.
553
554         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
555
556 2007-12-05  Anders Carlsson  <andersca@apple.com>
557
558         Reviewed by Geoff.
559         
560         Rename the TestNetscapePlugIn .c files to be .cpp.
561
562         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
563         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
564         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
565         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
566         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
567         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
568         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
569         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
570
571 2007-12-05  Adam Roben  <aroben@apple.com>
572
573         Fix case of keypresses from the Windows implementation of eventSender.keyDown
574
575         This fixes several regression tests.
576
577         Reviewed by Alice.
578
579         * DumpRenderTree/win/EventSender.cpp:
580         (keyDownCallback): Virtual keycodes for ASCII characters are always
581         uppercase, so we need to check the case of the original character
582         passed in to eventSender.keyDown.
583
584 2007-12-05  Adam Roben  <aroben@apple.com>
585
586         Learn from Tim's mistakes
587
588         * DumpRenderTree/win/DumpRenderTree.cpp:
589         (runTest): Reset the authorAndUserStylesEnabled preference for each
590         test.
591
592 2007-12-05  Alp Toker  <alp@atoker.com>
593
594         Reviewed by Mark Rowe.
595
596         Initialize GTK+ and WebKit so the tests can run.
597
598         Reorganize the headers a little.
599
600         * DumpRenderTree/gtk/DumpRenderTree.cpp:
601         (main):
602
603 2007-12-04  Anders Carlsson  <andersca@apple.com>
604
605         Remove IWebScriptScope include.
606         
607         * Drosera/win/DebuggerDocumentPlatform.cpp:
608
609 2007-12-04  Sam Weinig  <sam@webkit.org>
610
611         Rubber stamped by Mark Rowe.
612
613         Define CF as platform for mac and revert r28409
614
615         * DumpRenderTree/DumpRenderTree.h:
616         * DumpRenderTree/mac/DumpRenderTreeMac.h:
617
618 2007-12-04  Sam Weinig  <sam@webkit.org>
619
620         Define CF as platform for windows.
621
622         Reviewed by Adam Roben.
623
624         * DumpRenderTree/win/DumpRenderTreeWin.h:
625
626 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
627
628         Reviewed by Adam and Darin.
629
630         - Removed a needless BSTR cleanup.
631
632         * Drosera/win/DebuggerDocumentPlatform.cpp:
633         (DebuggerDocument::getPlatformCurrentFunctionStack):
634
635 2007-11-27  Adam Roben  <aroben@apple.com>
636
637         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
638
639         Reviewed by Maciej.
640
641         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
642         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
643
644 2007-12-04  Alp Toker  <alp@atoker.com>
645
646         Prospective Win DRT build fix.
647
648         * DumpRenderTree/DumpRenderTree.h:
649
650 2007-12-04  Alp Toker  <alp@atoker.com>
651
652         Fix a clobbered copyright header.
653
654         * DumpRenderTree/gtk/DumpRenderTree.cpp:
655
656 2007-12-04  Xan Lopez  <xan@gnome.org>
657
658         Reviewed by Alp Toker.
659
660         http://bugs.webkit.org/show_bug.cgi?id=15561
661         GTK port needs DumpRenderTree implementation
662
663         Start work on the GTK+ DRT.
664
665         This does not work yet, and there are a few lingering style issues
666         (nothing major) but this patch has been stuck in the bug tracker for
667         too long already.
668
669         * DumpRenderTree/DumpRenderTree.h:
670         * DumpRenderTree/gtk: Added.
671         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
672         (autocorrectURL):
673         (shouldLogFrameLoadDelegates):
674         (dumpFrameScrollPosition):
675         (displayWebView):
676         (appendString):
677         (dumpFramesAsText):
678         (dumpRenderTreeAsText):
679         (dump):
680         (runTest):
681         (main):
682         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
683         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
684         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
685         (GCController::collect):
686         (GCController::collectOnAlternateThread):
687         (GCController::getJSObjectCount):
688         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
689         (LayoutTestController::~LayoutTestController):
690         (LayoutTestController::addDisallowedURL):
691         (LayoutTestController::clearBackForwardList):
692         (LayoutTestController::copyDecodedHostName):
693         (LayoutTestController::copyEncodedHostName):
694         (LayoutTestController::display):
695         (LayoutTestController::keepWebHistory):
696         (LayoutTestController::notifyDone):
697         (LayoutTestController::queueBackNavigation):
698         (LayoutTestController::queueForwardNavigation):
699         (LayoutTestController::queueLoad):
700         (LayoutTestController::queueReload):
701         (LayoutTestController::queueScript):
702         (LayoutTestController::setAcceptsEditing):
703         (LayoutTestController::setCustomPolicyDelegate):
704         (LayoutTestController::setMainFrameIsFirstResponder):
705         (LayoutTestController::setTabKeyCyclesThroughElements):
706         (LayoutTestController::setUseDashboardCompatibilityMode):
707         (LayoutTestController::setUserStyleSheetEnabled):
708         (LayoutTestController::setUserStyleSheetLocation):
709         (LayoutTestController::setWindowIsKey):
710         (LayoutTestController::setWaitToDump):
711         (LayoutTestController::windowCount):
712         (LayoutTestController::setPrivateBrowsingEnabled):
713         (LayoutTestController::setAuthorAndUserStylesEnabled):
714         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
715         (JSStringCopyUTF8CString):
716         (LoadItem::invoke):
717         (ReloadItem::invoke):
718         (ScriptItem::invoke):
719         (BackForwardItem::invoke):
720
721 2007-12-03  Sam Weinig  <sam@webkit.org>
722
723         Move JavaScriptCore thread testing code to pthread specific directory
724         and remove the dependance on CoreFoundation by using WTF::HashSet.
725
726         Reviewed by Geoff and Oliver.
727
728         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
729         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
730         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
731         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
732         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
733         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
734         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
735         * DumpRenderTree/pthreads: Added.
736         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
737         (javaScriptThreads):
738         (runJavaScriptThread):
739         (startJavaScriptThreads):
740         (stopJavaScriptThreads):
741
742 2007-12-03  Andrew Bonventre  <andybons@google.com>
743
744         Reviewed by Darin Adler.
745
746         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
747         Symbol lookup menu broken in debugger view
748
749         * Drosera/debugger.js: Fixed javascript error where document property
750         should have been used instead of contentDocument in switchFunction that
751         was breaking the select symbol dropdown menu.  This is because
752         window.frames will return a Window object and not a frame object like
753         the author was originally expecting.
754
755 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
756
757         Reviewed by Adam.
758
759         - <rdar://5618942> Drosera: Console window does not process everything
760         correctly.
761         - <rdar://5619005> Drosera: could be sped up by moving the 
762         WebScriptScope stuff into the WebScriptCallFrame.
763         - Now the console can correctly process objects and does not receive
764         notifications from JavaScriptCore about the JavaScript in Drosera's
765         own process.
766
767         * Drosera/win/DebuggerDocumentPlatform.cpp:
768         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
769         (DebuggerDocument::platformValueForScopeVariableNamed):
770
771 2007-12-03  Stephanie  <slewis@apple.com>
772
773         Reviewed by Darin.
774
775         Check to see if we are building a debug root
776
777         * Scripts/check-for-global-initializers: 
778
779 2007-12-03  Dan Bernstein  <mitz@apple.com>
780
781         Reviewed by Darin Adler.
782
783         - added a testGetIntIdentifier() method to TestNetscapePlugIn
784
785         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
786         (pluginInvoke):
787
788 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
789
790         Reviewed by Oliver.
791
792         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
793         in a more fine-grained manner than eventSender.keyDown().
794
795         * DumpRenderTree/win/EventSender.cpp:
796         (getConstantCallback):
797         (dispatchMessageCallback):
798
799 2007-12-02  Darin Adler  <darin@apple.com>
800
801         * Scripts/do-webcore-rename: More planned renaming.
802
803 2007-12-02  Sam Weinig  <sam@webkit.org>
804
805         Rubber stamped by Anders.
806
807         Use [NSURL absoluteString] instead of [NSURL description] in order to get
808         more uniform results cross platform.
809
810         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
811         (-[NSURL _drt_descriptionSuitableForTestResult]):
812
813 2007-12-02  Sam Weinig  <sam@webkit.org>
814
815         Rubber stamped by Niko.
816
817         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
818
819         * DumpRenderTree/win/DumpRenderTree.cpp:
820         * DumpRenderTree/win/DumpRenderTree.vcproj:
821         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
822         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
823         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
824         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
825
826 2007-12-01  Alp Toker  <alp@atoker.com>
827
828         Reviewed by Adam Roben.
829
830         Make use of the newly introduced webkit.h convenience header.
831
832         * GtkLauncher/main.c:
833
834 2007-12-01  Adam Treat  <treat@kde.org>
835
836         Reviewed by Simon.
837
838         * Check to see if the directory exists and exit if not.
839
840         * DumpRenderTree/qt/main.cpp:
841         (main):
842
843 2007-12-01  Adam Treat  <treat@kde.org>
844
845         Reviewed by Simon.
846
847         * Don't hide symbols when in Debug mode
848         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
849
850
851         * DumpRenderTree/qt/main.cpp:
852         (messageHandler):
853
854 2007-11-30  Alp Toker  <alp@atoker.com>
855
856         Reviewed by Adam Roben.
857
858         http://bugs.webkit.org/show_bug.cgi?id=15691
859         [GTK] Public API does not follow GTK+ conventions
860
861         Refactor the WebKit/GTK+ public API. Changes:
862           WebKitPage -> WebKitWebView
863           WebKitFrame -> WebKitWebFrame
864
865         Public API source and header names have been updated to mirror the API
866         changes.
867
868         The API is now kept in WebKit/gtk/WebView to match other ports in the
869         same class such as Mac and Win.
870
871         * GtkLauncher/main.c:
872         (activate_uri_entry_cb):
873         (link_hover_cb):
874         (title_change_cb):
875         (progress_change_cb):
876         (go_back_cb):
877         (go_forward_cb):
878         (create_browser):
879         (main):
880
881 2007-11-30  Adam Roben  <aroben@apple.com>
882
883         Hopefully the final build fix
884
885         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
886         pull in WTF's assertion/logging functions.
887
888 2007-11-30  Adam Roben  <aroben@apple.com>
889
890         Another build fix
891
892         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
893         WebKit.lib.
894
895 2007-11-30  Adam Roben  <aroben@apple.com>
896
897         Debug build fix
898
899         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
900         configuration.
901         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
902         projects.
903         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
904         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
905         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
906
907 2007-11-30  Sam Weinig  <sam@webkit.org>
908
909         Reviewed by Adam Roben.
910
911         Fix drawSelectionRect to actually draw the selection rect.
912
913         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
914         (drawSelectionRect):
915
916 2007-11-30  Darin Adler  <darin@apple.com>
917
918         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
919
920 2007-11-30  Darin Adler  <darin@apple.com>
921
922         * Scripts/do-webcore-rename: Get ready for some future renaming.
923
924 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
925
926         Reviewed by Adam.
927
928         - Removed some unnecessary functions and changed an unused return type. 
929
930         * Drosera/win/DebuggerClient.cpp:
931         (registerConsoleClass):
932         * Drosera/win/DebuggerClient.h:
933         * Drosera/win/Drosera.cpp:
934         (registerDroseraClass):
935
936 2007-11-28  Alp Toker  <alp@atoker.com>
937
938         Reviewed by Timothy Hatcher.
939
940         http://bugs.webkit.org/show_bug.cgi?id=16174
941         [GTK] Use "URI" not "URL" in public API
942
943         Replace use of the term "URL" with "URI" in public headers,
944         documentation and some internal code to match GLib/GTK+ convention.
945
946         This is now mentioned in the API guidelines:
947           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
948
949         * GtkLauncher/main.c:
950         (activate_uri_entry_cb):
951         (title_change_cb):
952         (create_toolbar):
953         (main):
954
955 2007-11-29  Anders Carlsson  <andersca@apple.com>
956
957         Reviewed by Sam.
958
959         <rdar://problem/5230478>
960         FrameLoadDelegate callbacks are not dumped in DRT.
961         
962         * DumpRenderTree/win/DumpRenderTree.cpp:
963         (shouldLogFrameLoadDelegates):
964         (runTest):
965         (main):
966         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
967         (BSTRtoString):
968         (descriptionSuitableForTestResult):
969         (FrameLoadDelegate::QueryInterface):
970         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
971         (FrameLoadDelegate::didFailProvisionalLoadWithError):
972         (FrameLoadDelegate::didCommitLoadForFrame):
973         (FrameLoadDelegate::didFinishLoadForFrame):
974         (FrameLoadDelegate::willCloseFrame):
975         (FrameLoadDelegate::didClearWindowObject):
976         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
977         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
978         * DumpRenderTree/win/FrameLoaderDelegate.h:
979         (FrameLoadDelegate::windowScriptObjectAvailable):
980         (FrameLoadDelegate::didFirstLayoutInFrame):
981
982 2007-11-29  Sam Weinig  <sam@webkit.org>
983
984         Reviewed by Anders.
985
986         Add database quota UIDelegates methods to DRT UIDelegate.
987
988         * DumpRenderTree/mac/UIDelegate.mm:
989         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
990         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
991
992 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
993
994         Reviewed by Sam.
995
996         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
997         dying and vice versa.
998         - This fix will allow Drosera and Safari to reconnect if either of them
999         closes correctly, but does not fix the case where one of them dies
1000         silently.
1001
1002         * Drosera/win/ServerConnection.cpp:
1003         (ServerConnection::attemptToCreateServerConnection): Added a safety
1004         check, because it's possilbe to try to connect to a server that's dying.
1005         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1006         the server has died.
1007         * Drosera/win/ServerConnection.h: Added the new function and removed
1008         an unnecessary member.
1009
1010 2007-11-29  Anders Carlsson  <andersca@apple.com>
1011
1012         * DumpRenderTree/win/DumpRenderTree.vcproj:
1013         Add shlwapi.lib to all configurations.
1014
1015 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1016
1017         - Build fix.  Added additional includes for VS Express to the Release
1018         project.
1019
1020         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1021
1022 2007-11-29  Anders Carlsson  <andersca@apple.com>
1023
1024         Reviewed by Adam.
1025
1026         <rdar://problem/5132005>
1027         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1028         
1029         * DumpRenderTree/win/DumpRenderTree.vcproj:
1030         Add shlwapi.lib
1031         
1032         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1033         (LayoutTestController::setUserStyleSheetEnabled):
1034         Implement this.
1035         
1036         (appendComponentToPath):
1037         New method which wraps the Win32 API PathAppend.
1038         
1039         (followShortcuts):
1040         New method which checks if a file points to a shortcut and
1041         follows the shortcut.
1042         
1043         (resolveCygwinPath):
1044         New method that takes a cygwin unix-style path and returns the Win32 path.
1045         
1046         (cfStringRefToWString):
1047         
1048         (LayoutTestController::setUserStyleSheetLocation):
1049         Implement this.
1050
1051 2007-11-29  Alice Liu  <alice.liu@apple.com>
1052
1053         Reviewed by Adam.
1054
1055         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1056
1057         * DumpRenderTree/win/EventSender.cpp:
1058         (keyDownCallback):
1059         uppercase letters were being sent as lowercase letters without the shift key down.
1060
1061 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1062
1063         - Windows build fix. VS express needs some love.
1064
1065         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1066
1067 2007-11-28  Darin Adler  <darin@apple.com>
1068
1069         Reviewed by Adam Roben.
1070
1071         * DumpRenderTree/mac/EventSendingController.mm:
1072         (-[EventSendingController keyDown:withModifiers:]):
1073         Send capital letters through as lowercase letters with the shift key down
1074         rather than sending them as if they were highly unusual "capital letter keys".
1075
1076         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1077         where you need to update results and more tests are failing than before.
1078
1079 2007-11-28  Anders Carlsson  <andersca@apple.com>
1080
1081         Reviewed by Darin.
1082
1083         <rdar://problem/5132001>
1084         contextClick is not implemented in DRT on Windows.
1085         
1086         * DumpRenderTree/win/EventSender.cpp:
1087         (contextClickCallback):
1088         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1089         by a WM_RBUTTONUP message.
1090         
1091         * DumpRenderTree/win/UIDelegate.cpp:
1092         (UIDelegate::hasCustomMenuImplementation):
1093         (UIDelegate::trackCustomPopupMenu):
1094         * DumpRenderTree/win/UIDelegate.h:
1095         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1096         menu from being shown (and causing the DRT to hang).
1097
1098 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1099
1100         Reviewed by Darin.
1101
1102         Fix DumpRenderTree ObjC bug comparing strings.
1103
1104         * DumpRenderTree/mac/ObjCController.m:
1105         (-[ObjCController identityIsEqual::]): Compare strings with string
1106         equality instead of identiy equality.
1107
1108 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1109
1110         Reviewed by Sam.
1111
1112         Reset the authorAndUserStylesEnabled preference
1113         back to YES for each test. Fixes the broken tests.
1114
1115         * DumpRenderTree/mac/DumpRenderTree.mm:
1116         (resetWebViewToConsistentStateBeforeTesting):
1117
1118 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1119
1120         Reviewed by Adam.
1121
1122         - Drosera now displays the console window, although it cannot currently
1123         process JavaScript.
1124
1125         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1126         (registerConsoleClass): Implemented.
1127         (consoleWndProc): Implemented.
1128         (DebuggerClient::onSize): Implemented.
1129         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1130         new window.
1131         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1132         creating and maintaining a new window.
1133         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1134         lines of code to more appropriate places.
1135         (Drosera::handleCommand):
1136         (Drosera::initUI):
1137         (Drosera::onSize):
1138         (Drosera::attach):
1139
1140 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1141
1142         Reviewed by Dave Hyatt.
1143
1144         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1145         
1146         Add support for disabling author and user styles for testing.
1147
1148         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1149         * DumpRenderTree/LayoutTestController.cpp:
1150         (setAuthorAndUserStylesEnabledCallback):
1151         (LayoutTestController::staticFunctions):
1152         * DumpRenderTree/LayoutTestController.h:
1153         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1154         (LayoutTestController::setAuthorAndUserStylesEnabled):
1155         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1156         (LayoutTestController::setAuthorAndUserStylesEnabled):
1157
1158 2007-11-26  Dan Bernstein  <mitz@apple.com>
1159
1160         - Tiger build fix.
1161
1162         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1163
1164 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1165
1166         Reviewed by Maciej.
1167
1168         - Implemented displaying variables for Drosera on Win.
1169
1170         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1171         that retrieve variables to not hold onto the return value since it's
1172         not returned.  Also changed to use the new signatures of the retrieval
1173         functions.
1174         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1175         (DebuggerDocument::platformValueForScopeVariableNamed):
1176         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1177         (droseraWndProc):
1178
1179 2007-11-26  Sam Weinig  <sam@webkit.org>
1180
1181         Cleanup names of painting and repainting functions.
1182
1183         Reviewed by Adam Roben.
1184
1185         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1186         (drawSelectionRect): was drawSelectionRectIntoContext.
1187         (dumpWebViewAsPixelsAndCompareWithExpected):
1188         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1189         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1190         (paintWebView): was drawWebViewIntoContext.
1191         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1192
1193 2007-11-26  Sam Weinig  <sam@webkit.org>
1194
1195         Reviewed by Dan Bernstein.
1196
1197         - Leopard build fix
1198
1199         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1200
1201 2007-11-26  Sam Weinig  <sam@webkit.org>
1202
1203         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1204         Use shared PixelDumpSupport for Mac DRT
1205
1206         Reviewed by Adam Roben.
1207
1208         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1209         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1210         * DumpRenderTree/cg/ImageDiffCG.cpp:
1211         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1212         (drawSelectionRectIntoContext):
1213         (dumpWebViewAsPixelsAndCompareWithExpected):
1214         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1215         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1216         * DumpRenderTree/mac/DumpRenderTree.mm:
1217         (dump):
1218         * DumpRenderTree/mac/ImageDiff.m: Removed.
1219         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1220         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1221         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1222         (setDefaultColorProfileToRGB):
1223         (getBitmapContextFromWebView):
1224         (drawWebViewIntoContext):
1225         (repaintWithVerticalSweep):
1226         (repaintWithHorizontalSweep):
1227         (getSelectionRect):
1228         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1229
1230 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1231
1232         Bug 16052: prepare-ChangeLog doesn't report deleted files
1233         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1234
1235         Reviewed by Sam.
1236
1237         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1238
1239 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1240
1241         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1242         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1243
1244         Reviewed by Adam.
1245
1246         Roll functionality of merge-changelog into resolve-ChangeLogs
1247         script.  The script now checks for ChangeLog.rej and
1248         ChangeLog.orig files first.  If it finds them, it uses the
1249         ChangeLog.rej file as a patch (in old contextual diff format) to
1250         apply with --fuzz=3.
1251
1252         * Scripts/merge-changelog: Removed.
1253         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1254
1255 2007-11-25  Sam Weinig  <sam@webkit.org>
1256
1257         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1258
1259         Reviewed by Mark Rowe.
1260
1261         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1262         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1263         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1264         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1265         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1266
1267 2007-11-25  Sam Weinig  <sam@webkit.org>
1268
1269         Convert DumpRenderTree to ues .xcconfig files.
1270
1271         Reviewed by Mark Rowe.
1272
1273         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1274         * DumpRenderTree/mac/Configurations: Added.
1275         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1276         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1277         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1278
1279 2007-11-25  Sam Weinig  <sam@webkit.org>
1280
1281         Add ForwardingHeaders to wtf for DumpRenderTree.
1282
1283         Reviewed by Mark Rowe.
1284
1285         * DumpRenderTree/DumpRenderTree.h:
1286         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1287         * DumpRenderTree/ForwardingHeaders: Added.
1288         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1289         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1290         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1291         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1292         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1293         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1294         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1295         * DumpRenderTree/LayoutTestController.cpp:
1296         * DumpRenderTree/WorkQueue.cpp:
1297         * DumpRenderTree/mac/DumpRenderTree.mm:
1298         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1299         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1300         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1301         * DumpRenderTree/mac/ObjCController.m:
1302         * DumpRenderTree/mac/UIDelegate.mm:
1303         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1304
1305 2007-11-25  Adam Roben  <aroben@apple.com>
1306
1307         Fix some test failures caused by r28019
1308
1309         Now that stdout is in binary mode, we need to always use printf
1310         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1311         the output.
1312
1313         Reviewed by Sam.
1314
1315         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1316         printf.
1317         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1318         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1319         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1320         (UIDelegate::webViewAddMessageToConsole):
1321
1322 2007-11-25  Adam Roben  <aroben@apple.com>
1323
1324         Set the font smoothing preference in DRT
1325
1326         This makes the pixel results on Windows closer to the Mac results.
1327
1328         Reviewed by Mitz.
1329
1330         * DumpRenderTree/win/DumpRenderTree.cpp:
1331         (initializePreferences):
1332
1333 2007-11-25  Adam Roben  <aroben@apple.com>
1334
1335         Port ImageDiff to CG and C++
1336
1337         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1338         <rdar://5071708>
1339
1340         Reviewed by Sam.
1341
1342         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1343         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1344         (main):
1345         (createImageFromStdin):
1346         (compareImages):
1347         (getDifferenceBitmap):
1348         (computePercentageDifferent):
1349         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1350
1351 2007-11-25  Adam Roben  <aroben@apple.com>
1352
1353         Fix image diff link generation on Windows
1354
1355         Reviewed by Sam.
1356
1357         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1358         to toURL.
1359
1360 2007-11-25  Adam Roben  <aroben@apple.com>
1361
1362         Implement pixel dumping in Windows DRT
1363
1364         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1365         <rdar://5071708>
1366
1367         Reviewed by Sam.
1368
1369         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1370         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1371         Content-Length header.
1372         (getMD5HashStringForBitmap):
1373         (dumpWebViewAsPixelsAndCompareWithExpected):
1374         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1375         * DumpRenderTree/win/DumpRenderTree.cpp:
1376         (dump): Do a pixel dump if requested.
1377         (main): Parse pixel test options.
1378         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1379         the cg/ subdirectory to the include path.
1380         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1381         available in a header or import library, so we have to go through this
1382         LoadLibrary/GetProcAddress dance to use them.
1383         (cryptDLL):
1384         (init):
1385         (update):
1386         (final):
1387         (MD5_Init):
1388         (MD5_Update):
1389         (MD5_Final):
1390         * DumpRenderTree/win/MD5.h: Added.
1391         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1392         moved up to the top level to share it with Mac eventually.
1393         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1394         (getBitmapContextFromWebView): Forces the WebView to paint using a
1395         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1396
1397 2007-11-25  Adam Roben  <aroben@apple.com>
1398
1399         Clean up Windows DRT's option parsing a little bit
1400
1401         Reviewed by Sam.
1402
1403         * DumpRenderTree/win/DumpRenderTree.cpp:
1404         (main): Put non-option arguments into a Vector.
1405
1406 2007-11-25  Adam Roben  <aroben@apple.com>
1407
1408         Make Windows DRT stop changing LF into CRLF
1409
1410         Reviewed by Sam.
1411
1412         * DumpRenderTree/win/DumpRenderTree.cpp:
1413         (main): Put stdout in binary mode.
1414         * Scripts/run-webkit-tests: Remove the CRLF hack.
1415
1416 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1417
1418         Removed empty directory.
1419
1420         * Scripts/resources: Removed.
1421
1422 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1423
1424         Fix bisect-builds to work with recent WebKit nightly builds.
1425
1426         Reviewed by Dan.
1427
1428         * Scripts/bisect-builds: Check for the 
1429         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1430         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1431         to WebKit.app/Contents/Resources.
1432
1433 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1434
1435         Reviewed by Maciej.
1436
1437         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1438         not closed (affects digg.com)
1439
1440         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1441         one after finishing with a test to avoid having its delayed onload handler firing when
1442         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1443         but it helps somewhat.
1444
1445 2007-11-22  Mark Rowe  <mrowe@apple.com>
1446
1447         Reviewed by Alp Toker.
1448
1449         Fix build-webkit to propagate make's exit status if it fails.
1450
1451         * Scripts/webkitdirs.pm:
1452
1453 2007-11-22  Dan Bernstein  <mitz@apple.com>
1454
1455         Reviewed by Mark Rowe.
1456
1457         - fix crash when running pixel tests
1458
1459         * DumpRenderTree/mac/DumpRenderTree.mm:
1460         (dumpRenderTree): Parse the command line options before setting up the
1461         environment so that we know if we need to set up the pixel dump
1462         machinery.
1463
1464 2007-11-21  Eric Seidel  <eric@webkit.org>
1465
1466         Speculative build fix for Tiger.
1467
1468         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1469
1470 2007-11-21  Eric Seidel  <eric@webkit.org>
1471
1472         Reviewed by Tim Hatcher.
1473
1474         Break out more of DumpRenderTree.mm into individual files
1475
1476         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1477         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1478         (checkedMalloc):
1479         (checkedRealloc):
1480         (makeLargeMallocFailSilently):
1481         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1482         * DumpRenderTree/mac/DumpRenderTree.mm:
1483         (crashHandler):
1484         (dump):
1485         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1486         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1487         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1488         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1489         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1490         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1491         (javaScriptThreads):
1492         (runJavaScriptThread):
1493         (startJavaScriptThreads):
1494         (stopJavaScriptThreads):
1495         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1496         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1497         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1498         (restoreColorSpace):
1499         (setDefaultColorProfileToRGB):
1500         (initializeColorSpaceAndScreeBufferForPixelTests):
1501         (md5HashStringForBitmap):
1502         (dumpWebViewAsPixelsAndCompareWithExpected):
1503
1504 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1505
1506         Move install-unix-extras to wx directory as it seems only to be used by that 
1507         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1508         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1509         have install-unix-extras install into WebKitLibraries as per
1510         convention.
1511         
1512         Reviewed by Mark Rowe.
1513
1514         * Scripts/install-unix-extras: Removed.
1515         * wx/build-wxwebkit:
1516         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1517
1518 2007-11-21  Eric Seidel  <eric@webkit.org>
1519
1520         Reviewed by Adam.
1521
1522         More refactoring for greater code readability
1523
1524         * DumpRenderTree/mac/DumpRenderTree.mm:
1525         (initializeGlobalsFromCommandLineOptions):
1526         (initializeColorSpaceAndScreeBufferForPixelTests):
1527         (addTestPluginsToPluginSearchPath):
1528         (useLongRunningServerMode):
1529         (runTestingServerLoop):
1530         (prepareConsistentTestingEnvironment):
1531         (dumpRenderTree):
1532         (main):
1533         (dumpFramesAsText):
1534         (dumpBackForwardListForWebView):
1535         (sizeWebViewForCurrentTest):
1536         (methodNameStringForFailedTest):
1537         (dumpBackForwardListForAllWindows):
1538         (dumpWebViewAsPixelsAndCompareWithExpected):
1539         (invalidateAnyPreviousWaitToDumpWatchdog):
1540         (dump):
1541         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1542         * DumpRenderTree/mac/UIDelegate.mm:
1543         (-[UIDelegate webView:createWebViewWithRequest:]):
1544
1545 2007-11-21  Eric Seidel  <eric@webkit.org>
1546
1547         Reviewed by Tim Hatcher.
1548
1549         Abstract more of DRT into static methods
1550
1551         * DumpRenderTree/mac/DumpRenderTree.mm:
1552         (setDefaultsToConsistentValuesForTesting):
1553         (setupSignalHandlers):
1554         (allocateGlobalControllers):
1555         (releaseAndZero):
1556         (releaseGlobalControllers):
1557         (dumpRenderTree):
1558         (shouldLogFrameLoadDelegates):
1559         (createCFURLFromPathOrURL):
1560         (resetWebViewToConsistentStateBeforeTesting):
1561         (runTest):
1562
1563 2007-11-21  Eric Seidel  <eric@webkit.org>
1564
1565         Reviewed by Tim Hatcher.
1566
1567         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1568
1569         * DumpRenderTree/DumpRenderTree.h:
1570         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1571         * DumpRenderTree/mac/DumpRenderTree.mm:
1572         (dumpRenderTree):
1573         (dump):
1574         (runTest):
1575         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1576         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1577         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1578         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1579         (-[DumpRenderTreePasteboard declareType:owner:]):
1580         (+[LocalPasteboard alloc]):
1581         (-[LocalPasteboard init]):
1582         (-[LocalPasteboard dealloc]):
1583         (-[LocalPasteboard name]):
1584         (-[LocalPasteboard releaseGlobally]):
1585         (-[LocalPasteboard declareTypes:owner:]):
1586         (-[LocalPasteboard addTypes:owner:]):
1587         (-[LocalPasteboard changeCount]):
1588         (-[LocalPasteboard types]):
1589         (-[LocalPasteboard availableTypeFromArray:]):
1590         (-[LocalPasteboard setData:forType:]):
1591         (-[LocalPasteboard dataForType:]):
1592         (-[LocalPasteboard setPropertyList:forType:]):
1593         (-[LocalPasteboard setString:forType:]):
1594         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1595         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1596         (+[DumpRenderTreeWindow allWindows]):
1597         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1598         (-[DumpRenderTreeWindow dealloc]):
1599         (-[DumpRenderTreeWindow isKeyWindow]):
1600         (-[DumpRenderTreeWindow keyDown:]):
1601
1602 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1603
1604         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1605         it indiscriminately copies any headers inside JavaScriptCore,
1606         which includes Tiger ICU headers. 
1607
1608         * wx/build-wxwebkit:
1609         Don't run WebCore/move-js-headers.sh any longer.
1610
1611 2007-11-20  Adam Treat  <treat@kde.org>
1612
1613         Reviewed by David Kilzer.
1614
1615         * Prepend git branch name to $baseProductDir
1616
1617         * Scripts/VCSUtils.pm:
1618         * Scripts/webkitdirs.pm:
1619
1620 2007-11-20  Mark Rowe  <mrowe@apple.com>
1621
1622         Reviewed by Simon Hausmann.
1623
1624         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1625         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1626         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1627         built product and generated Makefile's are removed.
1628
1629 2007-11-19  Alp Toker  <alp@atoker.com>
1630
1631         Reviewed by Mark Rowe.
1632
1633         http://bugs.webkit.org/show_bug.cgi?id=16040
1634         [GTK] GtkLauncher should be written in C
1635
1636         Port GtkLauncher to plain C.
1637
1638         Use a more conventional GTK+ coding style.
1639
1640         Use a toolbar instead of menus.
1641
1642         Various signature fixes and cleanups.
1643
1644         Add a license header. Assume all previous modifications were copyright
1645         assigned to Apple Inc. by default.
1646
1647         * GtkLauncher/GtkLauncher.pro:
1648         * GtkLauncher/main.c: Added.
1649         (activate_url_entry_cb):
1650         (update_title):
1651         (link_hover_cb):
1652         (title_change_cb):
1653         (progress_change_cb):
1654         (destroy_cb):
1655         (go_back_cb):
1656         (go_forward_cb):
1657         (create_browser):
1658         (create_statusbar):
1659         (create_toolbar):
1660         (create_window):
1661         (main):
1662         * GtkLauncher/main.cpp: Removed.
1663
1664 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1665
1666         Build script fixes to ensure they do the right thing for the 
1667         wx port, and update build-wxwebkit to reflect the way the
1668         build scripts now work.
1669
1670         Reviewed by Adam.
1671
1672         * Scripts/build-testkjs:
1673         * Scripts/build-webkit:
1674         * Scripts/run-javascriptcore-tests:
1675         * Scripts/webkitdirs.pm:
1676         * wx/build-wxwebkit:
1677
1678 2007-11-18  Eric Seidel  <eric@webkit.org>
1679
1680         Reviewed by Anders.
1681
1682         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1683
1684         * Scripts/run-javascriptcore-tests:
1685
1686 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1687
1688         Reviewed by Adam Roben.
1689
1690         Make run-webkit-tests work with Windows debug build.
1691
1692         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1693         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1694         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1695         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1696         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1697
1698 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1699
1700         Add wxWebKit sample and build script, and integrate it with 
1701         build-webkit. Also make build-webkit --clean work for all
1702         ports.
1703
1704         Reviewed by Darin Adler.
1705
1706         * Scripts/build-webkit:
1707         * Scripts/webkitdirs.pm:
1708         * wx: Added.
1709         * wx/browser: Added.
1710         * wx/browser/browser.bkl: Added.
1711         * wx/browser/browser.cpp: Added.
1712         * wx/build-wxwebkit: Added.
1713
1714 2007-11-17  Adam Roben  <aroben@apple.com>
1715
1716         Make it easy to run Safari in the debugger on Windows
1717
1718         I've added a new script, debug-safari, which launches Safari in the
1719         debugger. On OS X it just calls gdb-safari.
1720
1721         Reviewed by Mark Rowe.
1722
1723         * FindSafari/FindSafari.cpp:
1724         (_tmain): Added a /debugger flag, which in combination with
1725         /printSafariLauncher will print a script that launches Safari in the
1726         debugger.
1727         * Scripts/debug-safari: Added.
1728         * Scripts/run-safari: Changed to call runSafari().
1729         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1730         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1731         first argument along to FindSafari.
1732         * Scripts/webkitdirs.pm:
1733         (sub runSafari): Added.
1734
1735 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1736
1737         Reviewed by Adam Roben.
1738
1739         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1740
1741 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1742
1743         Reviewed by David Kilzer.
1744
1745         The git config command was renamed to repo-config at some point. This
1746         change tries git config and then git repo-config if the first fails.
1747
1748         * Scripts/prepare-ChangeLog:
1749         (gitConfig):
1750
1751 2007-11-16  Dan Bernstein  <mitz@apple.com>
1752
1753         Reviewed by Darin Adler and Sam Weinig.
1754
1755         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1756
1757         * DumpRenderTree/win/EventSender.cpp:
1758         (keyDownCallback): For characters that cannot be entered on the active
1759         keyboard layout, send a WM_CHAR message with the character along with
1760         a WM_KEYDOWN message with a virtual key code of 255.
1761
1762 2007-11-16  Mark Rowe  <mrowe@apple.com>
1763
1764         Reviewed by Tim Hatcher.
1765
1766         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1767
1768         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1769         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1770
1771 2007-11-15  Adam Roben  <aroben@apple.com>
1772
1773         Make run-safari actually work on Windows
1774
1775         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1776         chdir call.
1777
1778 2007-11-14  Adam Roben  <aroben@apple.com>
1779
1780         Updates to Safari launching now that 3.0.4 is released
1781
1782         Reviewed by Sam.
1783
1784         * FindSafari/FindSafari.cpp:
1785         (getWebViewCLSID): Use version-independent ProgID.
1786         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1787
1788 2007-11-14  Anders Carlsson  <andersca@apple.com>
1789
1790         Reviewed by Adam.
1791
1792         <rdar://problem/5309081>
1793         In DRT, "plugin.logDestroy = true" not working on Windows.
1794         
1795         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1796         (NPP_Destroy):
1797
1798 2007-11-14  Eric Seidel  <eric@webkit.org>
1799
1800         Reviewed by Sam.
1801
1802         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1803
1804 2007-11-14  Anders Carlsson  <andersca@apple.com>
1805
1806         Reviewed by Adam.
1807
1808         <rdar://problem/5141186>
1809         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1810         
1811         Implement setWindowIsKey.
1812         
1813         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1814         (LayoutTestController::setWindowIsKey):
1815
1816 2007-11-13  Sam Weinig  <sam@webkit.org>
1817
1818         Reviewed by Adam Roben.
1819
1820         Fix for <rdar://problem/5382579>
1821         http/tests/security/cross-frame-access-put.html reports large 
1822         negative numbers for screenLeft and screenTop (Mac reports "0")
1823
1824         * DumpRenderTree/win/UIDelegate.cpp:
1825         (UIDelegate::UIDelegate): Initialize the RECT.
1826         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1827         (UIDelegate::webViewFrame): ditto.
1828         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1829
1830 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1831
1832         Reviewed by Adam.
1833
1834         - Make Drosera show source, source URLs, and function stack on Windows,
1835         and some minor fixes.
1836
1837         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1838         (DebuggerDocument::updateFileSource):
1839         * Drosera/debugger.js: Force source to always update display.
1840         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1841         menu controls.
1842         (DebuggerClient::resume):
1843         (DebuggerClient::pause):
1844         (DebuggerClient::stepInto):
1845         (DebuggerClient::stepOver):
1846         (DebuggerClient::stepOut):
1847         (DebuggerClient::showConsole):
1848         (DebuggerClient::closeCurrentFile):
1849         * Drosera/win/DebuggerClient.h: Ditto.
1850         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1851         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1852         removed two bugs.  1) caller could be in a bad state when asked to
1853         assign into it. 2) BSTRs were not created correctly.
1854         (DebuggerDocument::getPlatformCurrentFunctionStack):
1855         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1856         (droseraWndProc):
1857         (handleCommand):
1858         (Drosera::resume):
1859         (Drosera::pause):
1860         (Drosera::stepInto):
1861         (Drosera::stepOver):
1862         (Drosera::stepOut):
1863         (Drosera::showConsole):
1864         (Drosera::closeCurrentFile):
1865         * Drosera/win/Drosera.h: Hook up the menu controls.
1866         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1867         functions, added a null check, and fixed another bug where caller could
1868         be in a bad state when asked to assign into it.
1869         (ServerConnection::didLoadMainResourceForDataSource):
1870         (ServerConnection::getCallerFrame):
1871         * Drosera/win/ServerConnection.h: Safety first.
1872
1873 2007-11-13  Dan Bernstein  <mitz@apple.com>
1874
1875         Reviewed by Darin Adler.
1876
1877         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1878           DumpRenderTree --pixel-tests renders each test twice
1879
1880         * DumpRenderTree/mac/DumpRenderTree.mm:
1881         (dumpRenderTree): Removed the --paint option because the painting code
1882         is always exercised as a result of
1883         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1884         calling -displayIfNeeded.
1885         (dump): Changed to always grab the image from the window since the view
1886         is always displayed.
1887         (runTest):
1888         (displayWebView):
1889         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1890         because it always paints.
1891
1892 2007-11-12  Antti Koivisto  <antti@apple.com>
1893
1894         Reviewed by Adele.
1895         
1896         Add support for http media tests
1897
1898         * Scripts/run-webkit-tests:
1899
1900 2007-11-12  Sam Weinig  <sam@webkit.org>
1901
1902         Reviewed by Adam Roben.
1903
1904         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1905
1906         * DumpRenderTree/win/DumpRenderTree.cpp:
1907         (runTest):
1908         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1909         (LayoutTestController::setPrivateBrowsingEnabled):
1910
1911 2007-11-12  Adam Roben  <aroben@apple.com>
1912
1913         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1914         mac and win subdirectories.
1915
1916 2007-11-11  Adam Roben  <aroben@apple.com>
1917
1918         Fix <rdar://5133816> keepWebHistory is not implemented
1919
1920         Fixes fast/history/clicked-link-is-visited.html.
1921
1922         Reviewed by Darin.
1923
1924         * DumpRenderTree/win/DumpRenderTree.cpp:
1925         (runTest): Clear the optionalSharedHistory.
1926         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1927         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1928
1929 2007-11-10  Sam Weinig  <sam@webkit.org>
1930
1931         Reviewed by Tim Hatcher.
1932
1933         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1934         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1935         is turned on)
1936
1937         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1938
1939         Added test: http/tests/security/cross-frame-access-private-browsing.html
1940
1941         * DumpRenderTree/LayoutTestController.cpp:
1942         (setPrivateBrowsingEnabledCallback):
1943         (LayoutTestController::staticFunctions):
1944         * DumpRenderTree/LayoutTestController.h:
1945         * DumpRenderTree/mac/DumpRenderTree.mm:
1946         (runTest): Default to private browsing disabled.
1947         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1948         (LayoutTestController::setPrivateBrowsingEnabled):
1949         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1950         (LayoutTestController::setPrivateBrowsingEnabled):
1951
1952 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1953
1954         Reviewed by Adam.
1955
1956         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1957         WebCore's!
1958
1959         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1960         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1961         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1962         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1963         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1964         * Drosera/win/Drosera.cpp:
1965         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1966
1967 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1968
1969         Reviewed by Sam.
1970
1971         - Use the new IWebFrame [local] function signature and get the shared
1972         server correctly.
1973
1974         * Drosera/win/DebuggerClient.cpp:
1975         (DebuggerClient::didFinishLoadForFrame):
1976         * Drosera/win/ServerConnection.cpp:
1977         (ServerConnection::attemptToCreateServerConnection):
1978
1979 2007-11-07  Dan Bernstein  <mitz@apple.com>
1980
1981         Reviewed by Darin Adler.
1982
1983         - add an option to run-webkit-tests to ignore pixel test failures where
1984           all pixels differ by no more than a specified threshold
1985
1986         * DumpRenderTree/mac/ImageDiff.m:
1987         (main):
1988         (compareImages):
1989         (computePercentageDifferent):
1990         * Scripts/run-webkit-tests:
1991
1992 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1993
1994         Reviewed by Lars.
1995
1996         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1997
1998         * DumpRenderTree/qt/DumpRenderTree.cpp:
1999
2000 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2001
2002         Reviewed by Lars.
2003
2004         Reworked the QWebSettings API.
2005         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2006
2007         * DumpRenderTree/qt/DumpRenderTree.cpp:
2008
2009 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2010
2011         Reviewed by Lars.
2012
2013         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2014
2015         * DumpRenderTree/qt/jsobjects.cpp:
2016
2017 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2018
2019         Reviewed by Lars Knoll <lars@trolltech.com>.
2020
2021         Add a QWebPage::frameCreated() signal and fix DRT
2022         
2023         The removal of createFrame in QWebPage broke the re-implementation
2024         in DumpRenderTree. Instead emit a frameCreated() signal and
2025         connect to it in DumpRenderTree.
2026         
2027
2028         * DumpRenderTree/qt/DumpRenderTree.cpp:
2029         (WebCore::WebPage::WebPage):
2030         (WebCore::DumpRenderTree::dump):
2031         (WebCore::DumpRenderTree::connectFrame):
2032         * DumpRenderTree/qt/DumpRenderTree.h:
2033
2034 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2035
2036         Reviewed by Lars Knoll <lars@trolltech.com>.
2037
2038         Moved all the event handlers from QWebFrame into QWebPage.
2039         
2040         This cleans up the public API and allows us to remove the
2041         HackWebFrame hack in DumpRenderTree.
2042         
2043
2044         * DumpRenderTree/qt/jsobjects.cpp:
2045         (EventSender::mouseDown):
2046         (EventSender::mouseUp):
2047         (EventSender::mouseMoveTo):
2048
2049 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2050
2051         Reviewed by Mark.
2052
2053         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2054         to prevent the default implementation from popping up messageboxes.
2055
2056         * DumpRenderTree/qt/DumpRenderTree.cpp:
2057         (WebCore::WebPage::javaScriptConfirm):
2058         (WebCore::WebPage::javaScriptPrompt):
2059
2060 2007-11-06  Eric Seidel  <eric@webkit.org>
2061
2062         * Scripts/build-testkjs: build fix... too many $$
2063
2064 2007-11-06  Eric Seidel  <eric@webkit.org>
2065
2066         Reviewed by Mark Rowe.
2067
2068         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2069
2070 2007-11-05  Adam Roben  <aroben@apple.com>
2071
2072         Add support on Windows for WEBKIT_TESTFONTS
2073
2074         This environment variable lets you specify where the fonts to be used
2075         by DumpRenderTree reside. The Qt port is already using this, so I'm
2076         just following their lead.
2077
2078         Reviewed by Darin.
2079
2080         * DumpRenderTree/win/DumpRenderTree.cpp:
2081         (exePath): Refactored code out of initialize().
2082         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2083         DumpRenderTree.resources.
2084         (initialize): Use the new fontsPath function.
2085         (main): Use the new exePath function.
2086         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2087         variable to DRT, like Qt does.
2088
2089 2007-11-05  Mark Rowe  <mrowe@apple.com>
2090
2091         Rubber-stamped by Alp Toker.
2092
2093         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2094
2095         * GtkLauncher/main.cpp:
2096         (goToURLBarText):
2097         (main):
2098
2099 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2100
2101         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2102         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2103
2104         Reviewed by Timothy.
2105
2106         Restrict the range of nightly builds used by the bisect-builds script
2107         based on the version of Safari and the version of Mac OS X being used.
2108
2109         Mac OS X 10.4: Safari 2.0: r11976 or newer
2110         Mac OS X 10.4: Safari 3.0: r19992 or newer
2111
2112         Mac OS X 10.5: Safari 2.0: r19594 or newer
2113         Mac OS X 10.5: Safari 3.0: r25124 or newer
2114
2115         * Scripts/bisect-builds:
2116         (findMacOSXVersion): Added.
2117         (makeNightlyList): Added argument to provide version of Mac OS X.
2118         Restrict range of nightly builds based on Safari and Mac OS X versions.
2119
2120 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2121
2122         Reviewed by Maciej.
2123
2124         - This patch involves several changes, all of them were noticed that
2125         they were needed by the work being done in WebKit to get Drosera and
2126         WebKit working together on Windows.
2127         - The changes are:
2128         1) Added a debugger console for output messages.
2129         2) Drosera now listens for the WebKit server (before, the server would
2130         have to be running before Drosera was started.)
2131         3) Fixed a bug where the WebView started out as 0x0 pixels.
2132         4) Fixed a bug when there is no scope.
2133         5) Added the HTML, JS, and CSS to the project file to make them easy to
2134         find.
2135         6) Made the ServerConnection functions virtual.
2136
2137         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2138         for the WebKit server.
2139         (DebuggerClient::DebuggerClient):
2140         (DebuggerClient::~DebuggerClient):
2141         (DebuggerClient::didFinishLoadForFrame):
2142         (DebuggerClient::serverConnected):
2143         (DebuggerClient::attemptToCreateServerConnection):
2144         * Drosera/win/DebuggerClient.h: Ditto.
2145         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2146         scope.
2147         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2148         (DebuggerDocument::platformValueForScopeVariableNamed):
2149         * Drosera/win/Drosera.cpp:
2150         (_tWinMain): Added a console in debug for output messages.
2151         (Drosera::Drosera): Listen for server.
2152         (Drosera::initUI): The server now Initializes COM.
2153         (Drosera::serverConnected): Part of the listening for the server.
2154         (Drosera::attemptToCreateServerConnection): Ditto.
2155         * Drosera/win/Drosera.h: New interface for listening for the server.
2156         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2157         files to the VS project.
2158         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2159         connection.
2160         (ServerConnection::ServerConnection):
2161         (ServerConnection::attemptToCreateServerConnection):
2162         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2163         methods.
2164         (ServerConnection::serverConnected):
2165
2166 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2167
2168         Reviewed by Maciej.
2169
2170         http://bugs.webkit.org/show_bug.cgi?id=15832
2171         fast/dom/gc-10.html crashes when run alone
2172
2173         Check for !done before using objects that can be already deallocated.
2174
2175         * DumpRenderTree/mac/EditingDelegate.mm:
2176         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2177         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2178         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2179         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2180         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2181         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2182         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2183         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2184         (-[EditingDelegate webViewDidBeginEditing:]):
2185         (-[EditingDelegate webViewDidChange:]):
2186         (-[EditingDelegate webViewDidEndEditing:]):
2187         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2188         (-[EditingDelegate webViewDidChangeSelection:]):
2189         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2190         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2191         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2192         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2193         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2194         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2195         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2196         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2197         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2198         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2199         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2200         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2201         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2202         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2203         (-[FrameLoadDelegate webView:willCloseFrame:]):
2204         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2205         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2206         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2207         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2208         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2209         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2210         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2211         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2212         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2213
2214 2007-11-04  Mark Rowe  <mrowe@apple.com>
2215
2216         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2217         warnings that would otherwise be suppressed due to it being a system header.
2218
2219         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2220
2221 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2222
2223         Rubber stamped by Adam.
2224         
2225         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2226
2227         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2228
2229 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2230
2231         Sort files(...); sections of Xcode project files.
2232
2233         Rubber-stamped by Darin.
2234
2235         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2236         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2237         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2238         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2239
2240 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2241
2242         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2243
2244         Reviewed by Darin.
2245
2246         * Scripts/sort-Xcode-project-file: Added.
2247
2248 2007-11-02  Darin Adler  <darin@apple.com>
2249
2250         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2251
2252 2007-11-02  Darin Adler  <darin@apple.com>
2253
2254         Reviewed by Maciej.
2255
2256         * Scripts/run-sunspider: Pass the "--base" option through.
2257
2258         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2259         the real script do that. Default configuration to Release to match run-sunspider
2260         so we don't end up building Debug just to compare results.
2261
2262 2007-11-01  Adam Roben  <aroben@apple.com>
2263
2264         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2265
2266         Reviewed by Sam.
2267
2268         * Scripts/commit-log-editor: Show all the directories beneath the
2269         source root, instead of just the last one.
2270
2271 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2272
2273         Reviewed by Adam Roben.
2274
2275         Print out an error message when the Windows build fails
2276         and provide guidance on how to find out what went wrong.
2277
2278         * Scripts/build-webkit:
2279         * Scripts/webkitdirs.pm:
2280
2281 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2282
2283         Rubber-stamped by Adam Roben.
2284
2285         Rolled out r27326 - debug CRT seems to cause no problems after all.
2286
2287         * DumpRenderTree/win/DumpRenderTree.vcproj:
2288
2289 2007-10-31  Adam Roben  <aroben@apple.com>
2290
2291         Switch the Debug configuration to using the non-debug CRT
2292
2293         This matches WebKit.
2294
2295         Reviewed by Steve.
2296
2297         * DumpRenderTree/win/DumpRenderTree.vcproj:
2298
2299 2007-10-31  Antti Koivisto  <antti@apple.com>
2300
2301         Reviewed by bdash.
2302         
2303         Disable media tests when doing leak checking on Tiger.
2304         They crash in QuickTime (rdar://problem/5537157).
2305
2306         * Scripts/run-webkit-tests:
2307
2308 2007-10-29  Antti Koivisto  <antti@apple.com>
2309
2310         Reviewed by Maciej.
2311         
2312         Build media support by default on OSX only.
2313
2314         * Scripts/build-webkit:
2315
2316 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2317
2318         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2319         get caught by the pre-commit hooks.
2320
2321 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2322
2323         Reviewed by Adam.
2324
2325         - This is a collection of relatively unrelated changes and cleanups
2326         to Drosera to prepare it for interacting with WebKit.  A lot of these
2327         changes are just correcting mistakes, for example removing included
2328         headers that are no longer needed.
2329
2330         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2331         this will be needed by the DebuggerClient.
2332         (DebuggerDocument::server):
2333         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2334         * Drosera/win/DebuggerClient.cpp: 
2335         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2336         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2337         (DebuggerClient::createWebViewWithRequest): Added comment about its
2338         purpose. 
2339         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2340         declarations.
2341         (DebuggerClient::webViewLoaded): Moved.
2342         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2343         file, since this was the only place it was used.
2344         (cfStringToBSTR):
2345         * Drosera/win/Drosera.h: Cleaned up the includes.
2346         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2347         * Drosera/win/HelperFunctions.h: Removed.
2348
2349 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2350
2351         Reviewed by Adam.
2352
2353         - Small cleanup in the ServerConnection class.
2354
2355         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2356         and added an include.
2357         (ServerConnection::currentFrame):
2358         (ServerConnection::getCallerFrame):
2359         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2360         made a pointer into a COMPtr, and cleaned up the includes.
2361
2362 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2363
2364         Reviewed by John Sullivan.
2365         
2366         - Place the Localizable.strings file in mac or win directories
2367           if that location exists.
2368         - Also look for UI_STRING in .c files.
2369
2370         * Scripts/extract-localizable-strings:
2371
2372 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2373
2374         Reviewed by Adam.
2375
2376         - Set the eol-style to native and made all the line endings the same
2377         so that I avoid messy diffs that show eol changes.
2378
2379         * Drosera/win/ServerConnection.cpp:
2380         (ServerConnection::didParseSource):
2381         (ServerConnection::didEnterCallFrame):
2382         (ServerConnection::willExecuteStatement):
2383         (ServerConnection::willLeaveCallFrame):
2384         (ServerConnection::exceptionWasRaised):
2385
2386 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2387
2388         Reviewed by Adam.
2389
2390         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2391         functionality that could not have existed previously without the new
2392         interfaces.
2393         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2394         from a BSTR to a JSValueRef.
2395         (DebuggerDocument::platformEvaluateScript): Implemented.
2396         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2397         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2398         Implemented.
2399         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2400         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2401         * Drosera/win/ServerConnection.cpp: Added a helper function.
2402         (ServerConnection::getCallerFrame):
2403         * Drosera/win/ServerConnection.h: Added a helper function.
2404
2405 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2406
2407         updated reviewers for my previous changelog.
2408
2409 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2410         Reviewed by Maciej and Adam and Geoff.
2411
2412         - Minor mac-side improvements including moving a function to a more
2413         appropriate location, fixing a warning, and correctly checking
2414         exceptions.
2415
2416         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2417         (DebuggerDocument::willExecuteStatement):
2418         (DebuggerDocument::didEnterCallFrame):
2419         (DebuggerDocument::willLeaveCallFrame):
2420         (DebuggerDocument::windowScriptObjectAvailable):
2421         (DebuggerDocument::callFunctionOnObject):
2422         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2423         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2424         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2425         because it doesn't require the ServerConnection at all.
2426         (NSStringCreateWithJSStringRef): Made an argument const.
2427         (JSValueRefCreateWithNSString): Made an argument const.
2428         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2429         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2430         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2431         * Drosera/mac/ServerConnection.mm: Ditto.
2432         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2433
2434 2007-10-29  Sam Weinig  <sam@webkit.org>
2435
2436         Reviewed by Adam Roben.
2437
2438         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2439
2440         * DumpRenderTree/LayoutTestController.cpp:
2441         (LayoutTestController::LayoutTestController):
2442         (getGlobalFlagCallback):
2443         (setGlobalFlagCallback):
2444         (LayoutTestController::getJSClass):
2445         (LayoutTestController::staticValues):
2446         * DumpRenderTree/LayoutTestController.h:
2447         (LayoutTestController::globalFlag):
2448         (LayoutTestController::setGlobalFlag):
2449
2450 2007-10-29  Darin Adler  <darin@apple.com>
2451
2452         Reviewed by Maciej.
2453
2454         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2455         resolution instead of its default.
2456
2457 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2458
2459         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2460
2461         Reviewed by Mark Rowe.
2462
2463         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2464         was successfully resolved, but this would not show any status because the change had
2465         already been cached in the index using "git add".  The solution is to add an optional
2466         second argument to showStatus() which adds the "--cached" switch to the command.
2467
2468         * Scripts/resolve-ChangeLogs:
2469         (showStatus):
2470
2471 2007-10-28  Eric Seidel  <eric@webkit.org>
2472
2473         Reviewed by Maciej and Geoff, in unison.
2474
2475         * Scripts/run-webkit-tests: remove broken --svg option
2476
2477 2007-10-28  Darin Adler  <darin@apple.com>
2478
2479         Reviewed by Adam.
2480
2481         * Scripts/run-sunspider: Default to "Release" configuration rather than
2482         defaulting to the last configuration used as other scripts do. This can
2483         still be overriden on the command line with "--debug" if there's some
2484         reason to do so. Also fix a typo.
2485
2486         * Scripts/sunspider-compare-results: Fix a typo.
2487
2488 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2489
2490         Reviewed by Adam.
2491
2492         - Implemented the WebScriptDebugListener functions now that the
2493         WebScriptDebugServer exists
2494
2495         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2496         functions.
2497         (ServerConnection::currentFrame):
2498         (ServerConnection::didLoadMainResourceForDataSource):
2499         (ServerConnection::didParseSource):
2500         (ServerConnection::failedToParseSource):
2501         (ServerConnection::didEnterCallFrame):
2502         (ServerConnection::willExecuteStatement):
2503         (ServerConnection::willLeaveCallFrame):
2504         (ServerConnection::exceptionWasRaised):
2505         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2506         members arguments list.
2507
2508 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2509
2510         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2511         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2512
2513         Reviewed by Darin.
2514
2515         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2516         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2517         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2518         file.  Note that it may also be used as a stand-alone script.
2519
2520         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2521         * Scripts/resolve-ChangeLogs: Added.
2522         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2523
2524 2007-10-26  Mark Rowe  <mrowe@apple.com>
2525
2526         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2527         to the Qt port on the assumption that it was an implementation of the cross-platform
2528         LayoutTestController class.  It is not, so it did not need to be changed.
2529
2530         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2531
2532 2007-10-25  Mark Rowe  <mrowe@apple.com>
2533
2534         Reviewed by Maciej.
2535
2536         Fix builds with code coverage enabled.
2537
2538         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2539
2540 2007-10-25  Darin Adler  <darin@apple.com>
2541
2542         Reviewed by Mark Rowe.
2543
2544         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2545         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2546
2547 2007-10-25  Stephanie  <slewis@apple.com>
2548
2549         build Fix
2550
2551         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2552
2553 2007-10-25  Stephanie  <slewis@apple.com>
2554
2555         Reviewed by Mark Rowe, Adam Roben.
2556
2557         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2558
2559         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2560
2561 2007-10-25  Alice Liu  <alice.liu@apple.com>
2562
2563         Reviewed by Adam.
2564
2565         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2566
2567         Moving destructor into platform-specific files
2568         * DumpRenderTree/LayoutTestController.cpp:
2569         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2570         (LayoutTestController::~LayoutTestController):
2571         * DumpRenderTree/qt/jsobjects.cpp:
2572         (LayoutTestController::~LayoutTestController):
2573
2574         LayoutTestController wasn't being destroyed
2575         * DumpRenderTree/win/DumpRenderTree.cpp:
2576         (runTest):
2577
2578         Added declspec
2579         * DumpRenderTree/win/EditingDelegate.h:
2580
2581         Reset certain values on the webview (or related delegate) that might 
2582         have changed while running a test
2583         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2584         (LayoutTestController::~LayoutTestController):
2585
2586 2007-10-25  Adam Roben  <aroben@apple.com>
2587
2588         Make sunspider-compare-results work with relative paths
2589
2590         Reviewed by Sam.
2591
2592         * Scripts/sunspider-compare-results: Convert arguments to absolute
2593         paths before we chdir.
2594
2595 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2596
2597         Reviewed by Sam.
2598
2599         - Implemented server calls now the WebScriptDebugServer exists.
2600         - Also removed no longer needed call to initialize CG.
2601
2602         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2603         automatically now.
2604         (_tWinMain):
2605         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2606         (ServerConnection::ServerConnection):
2607         (ServerConnection::~ServerConnection):
2608         (ServerConnection::pause):
2609         (ServerConnection::resume):
2610         (ServerConnection::stepInto):
2611         (ServerConnection::applicationTerminating):
2612         (ServerConnection::serverConnectionDidDie):
2613         * Drosera/win/ServerConnection.h: Now uses the COM class.
2614
2615 2007-10-24  George Staikos  <staikos@kde.org>
2616
2617         Unbreak Qt build.
2618
2619         * Scripts/build-webkit:
2620
2621 2007-10-24  Adam Roben  <aroben@apple.com>
2622
2623         Remove now-unnecessary call to InitializeCoreGraphics
2624
2625         WebKit takes care of this now.
2626
2627         Reviewed by Ada.
2628
2629         * DumpRenderTree/win/DumpRenderTree.cpp:
2630         (initialize):
2631
2632 2007-10-24  Adam Roben  <aroben@apple.com>
2633
2634         Use WebTextRenderer in DRT
2635
2636         Reviewed by Ada.
2637
2638         * DumpRenderTree/win/DumpRenderTree.cpp:
2639         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2640
2641 2007-10-24  Sven Herzberg  <sven@imendio.com>
2642
2643         Reviewed by Mark Rowe.
2644
2645         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2646         Bug 15614: [GTK] qmake based backends don't build on OS X
2647
2648         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2649         GTK backend on a Mac
2650         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2651         isDarwin() to make it reusable in other places (like the workaround-
2652         for-prebuilt-qmake in build-webkit)
2653
2654 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2655
2656         Refurbish update-webkit script.
2657
2658         Reviewed by Adam.
2659
2660         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2661         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2662         multi-argument version of system() for flexibility and security.  Check for existence
2663         of Internal directory using -d test instead of -x.
2664
2665 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2666
2667         Minor clean-up of prepare-ChangeLog script.
2668
2669         Reviewed by Adam.
2670
2671         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2672         of a string.  Use multi-argument versions of open() and system() for flexibility and
2673         security.
2674
2675 2007-10-24  Alice Liu  <alice.liu@apple.com>
2676
2677         Reviewed by Oliver.
2678
2679         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2680
2681         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2682         replay the saved events when we're still processing the mousedown that starts the drag
2683         * DumpRenderTree/win/EventSender.cpp:
2684         (doMouseMove):
2685         * DumpRenderTree/win/UIDelegate.cpp:
2686         (UIDelegate::doDragDrop):
2687
2688 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2689
2690         Reviewed by Sam, Steve and Darin.
2691
2692         - Stubbed out the WebScriptDebugListener functionality in the Server
2693         Connection class to prepare it for receiving those callbacks.
2694         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2695         and the ServerConnection to not need to be initialized with a server
2696         name, since that is not the way we connect to the WebKit server. 
2697
2698         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2699         no exception.  Now it only loggs when there is an exception
2700         (DebuggerDocument::willExecuteStatement):
2701         (DebuggerDocument::didEnterCallFrame):
2702         (DebuggerDocument::willLeaveCallFrame):
2703         (DebuggerDocument::windowScriptObjectAvailable):
2704         (DebuggerDocument::callFunctionOnObject):
2705         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2706         to be instantiated with a server's name.
2707         (DebuggerClient::DebuggerClient):
2708         (DebuggerClient::didFinishLoadForFrame):
2709         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2710         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2711         a server name.
2712         (Drosera::init):
2713         (Drosera::initServer):
2714         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2715         instantiated with a server's name.
2716         * Drosera/win/ServerConnection.cpp: 
2717         (ServerConnection::ServerConnection): No longer needs a server name
2718         (ServerConnection::~ServerConnection): Only release the global context
2719         if there is one.
2720         (ServerConnection::serverConnectionDidDie): Stub for
2721         IWebScriptDebugListener
2722         (ServerConnection::QueryInterface): ditto
2723         (ServerConnection::AddRef): ditto
2724         (ServerConnection::Release): ditto
2725         (ServerConnection::didLoadMainResourceForDataSource): ditto
2726         (ServerConnection::didParseSource): ditto
2727         (ServerConnection::failedToParseSource): ditto
2728         (ServerConnection::didEnterCallFrame): ditto
2729         (ServerConnection::willExecuteStatement): ditto
2730         (ServerConnection::willLeaveCallFrame): ditto
2731         (ServerConnection::exceptionWasRaised): ditto
2732         * Drosera/win/ServerConnection.h: Stubbed out the
2733         IWebScriptDebugListener functions, and this class no longer needs to be
2734         instantiated with a server name.
2735
2736 2007-10-24  Lars Knoll  <lars@trolltech.com>
2737
2738         Reviewed by Simon.
2739
2740         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2741
2742         * DumpRenderTree/qt/jsobjects.h:
2743
2744 2007-10-24  Lars Knoll  <lars@trolltech.com>
2745
2746         Reviewed by Simon.
2747
2748         add another command.
2749
2750         * DumpRenderTree/qt/jsobjects.cpp:
2751         (TextInputController::doCommand):
2752
2753 2007-10-24  Lars Knoll  <lars@trolltech.com>
2754
2755         Reviewed by Simon.
2756
2757         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2758
2759         * DumpRenderTree/qt/jsobjects.cpp:
2760         (EventSender::keyDown):
2761         * DumpRenderTree/qt/jsobjects.h:
2762
2763 2007-10-24  Lars Knoll  <lars@trolltech.com>
2764
2765         Reviewed by Simon.
2766
2767         implement eventSender.keyDown().
2768
2769         * DumpRenderTree/qt/jsobjects.cpp:
2770         (EventSender::keyDown):
2771
2772 2007-10-24  Lars Knoll  <lars@trolltech.com>
2773
2774         Reviewed by Simon.
2775
2776         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2777
2778         * DumpRenderTree/qt/DumpRenderTree.cpp:
2779         (WebCore::DumpRenderTree::DumpRenderTree):
2780         (WebCore::DumpRenderTree::initJSObjects):
2781         * DumpRenderTree/qt/jsobjects.cpp:
2782         (TextInputController::doCommand):
2783
2784 2007-10-24  Lars Knoll  <lars@trolltech.com>
2785
2786         Reviewed by Simon.
2787
2788         first bit of implementation for the textinputcontroller.
2789
2790         * DumpRenderTree/qt/DumpRenderTree.cpp:
2791         (WebCore::DumpRenderTree::DumpRenderTree):
2792         * DumpRenderTree/qt/DumpRenderTree.h:
2793         * DumpRenderTree/qt/jsobjects.cpp:
2794         (TextInputController::TextInputController):
2795         (TextInputController::doCommand):
2796         * DumpRenderTree/qt/jsobjects.h:
2797
2798 2007-10-24  Lars Knoll  <lars@trolltech.com>
2799
2800         Reviewed by Simon.
2801
2802         make the man webpage believe it has focus, so the editing tests work correctly.
2803
2804         * DumpRenderTree/qt/DumpRenderTree.cpp:
2805         (WebCore::DumpRenderTree::DumpRenderTree):
2806
2807 2007-10-24  Lars Knoll  <lars@trolltech.com>
2808
2809         Reviewed by Simon.
2810
2811         implement layoutTestController.dumpEditingCallbacks() correctly.
2812
2813         * DumpRenderTree/qt/DumpRenderTree.cpp:
2814         (WebCore::DumpRenderTree::DumpRenderTree):
2815         * DumpRenderTree/qt/jsobjects.cpp:
2816         (LayoutTestController::reset):
2817         (LayoutTestController::dumpEditingCallbacks):
2818
2819 2007-10-24  Lars Knoll  <lars@trolltech.com>
2820
2821         Reviewed by Simon.
2822
2823         Implement support for testing editing.
2824
2825         * DumpRenderTree/qt/DumpRenderTree.cpp:
2826         (WebCore::DumpRenderTree::DumpRenderTree):
2827
2828 2007-10-23  Sam Weinig  <sam@webkit.org>
2829
2830         Check for null BSTR that can be passed to the UIDelegate methods
2831         from javascript null and undefined.  Fixes a failing test case on
2832         Windows (fast/dom/Window/alert-undefined.html)
2833
2834         Reviewed by Eric Seidel.
2835
2836         * DumpRenderTree/win/UIDelegate.cpp:
2837         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2838         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2839         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2840         (UIDelegate::webViewAddMessageToConsole):
2841
2842 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2843
2844         Reviewed by Darin.
2845         
2846         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2847
2848         * Scripts/build-testkjs:
2849
2850 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2851
2852         Reviewed by Darin.
2853
2854         - add wrapper that finds the right copy of testkjs
2855         
2856         * Scripts/sunspider-compare-results: Added.
2857
2858 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2859
2860         Reviewed by Sam.
2861
2862         - After talking with Steve I now see that the WebKit server must be
2863         running for DCOM to create the distributed objects, which makes sense
2864         and currently WebKit only allows one instance to be running at a time
2865         which avoids accidentally connecting to the wrong server
2866         - In light of this I have removed the code for the attach box and
2867         NotificationServer and known server names, since they are all extranious
2868         now.
2869
2870         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2871         names.
2872         (_tWinMain): Uses init instead of initUI.
2873         (droseraWndProc): No longer creats an attach dialog box.
2874         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2875         it's not manditory to call init before doing COM stuff.
2876         (Drosera::init): calls initUI and will call attach when the
2877         functionality exists. 
2878         (Drosera::initUI): Has changed very little.
2879         (Drosera::attach): Changed the signature to reflect that we no longer
2880         need the dictionary of known server names.
2881         * Drosera/win/Drosera.h: Removed notification classes and known server
2882         names.  Also renamed and moved some functions.
2883         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2884         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2885         headers to the resources folder. 
2886         * Drosera/win/resource.h: Removed the Attach box.
2887
2888 2007-10-22  Adam Roben  <aroben@apple.com>
2889
2890         Windows build fix
2891
2892         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2893
2894 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2895
2896         - Removed a leak that was fixed.
2897
2898         * Scripts/run-webkit-tests:
2899
2900 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2901
2902         Reviewed by Darin.
2903
2904         - Changed the Client so that the DebuggerDocument now own the
2905         ServerConnection.  This simplifies ownership and cleanup. 
2906
2907         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2908         ServerConnection.
2909         (DebuggerClient::initWithServerName):
2910         (DebuggerClient::didFinishLoadForFrame):
2911         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2912         ServerConnection.
2913         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2914         until after we have a server which we are attached to.
2915         (Drosera::initUI):
2916         (Drosera::attach):
2917         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2918         out previously.
2919
2920 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2921
2922         Reviewed by Nikolas.
2923
2924         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2925
2926         * Scripts/run-javascriptcore-tests:
2927
2928 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2929
2930         Reviewed by Nikolas.
2931
2932         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2933
2934         * Scripts/build-drosera:
2935         * Scripts/build-dumprendertree:
2936         * Scripts/build-testkjs:
2937         * Scripts/build-webkit:
2938         * Scripts/run-javascriptcore-tests:
2939         * Scripts/run-sunspider:
2940         * Scripts/run-webkit-tests:
2941         * Scripts/webkitdirs.pm:
2942
2943 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2944
2945         Reviewed by Mark Rowe.
2946         
2947         Fix for local database support after r26879
2948         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2949
2950         * Scripts/build-webkit:
2951
2952 2007-10-22  Holger Freyther  <zecke@selfish.org>
2953
2954         Reviewed by Simon Hausmann <hausmann@kde.org>.
2955
2956         - Do not build testkjs as an application bundle. This is
2957         needed for run-javascriptcore-tests on OSX.
2958         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2959         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2960         as we do not have -rpath on OSX.
2961
2962         * DumpRenderTree/qt/DumpRenderTree.pro:
2963         * Scripts/run-webkit-tests:
2964
2965 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2966
2967         Reviewed by aroben.
2968
2969         Fix support for Signed-off-by detection in prepare-ChangeLog
2970         --git-commit. The Signed-off-by tag does not appear in the header
2971         but usually at the end.
2972
2973         * Scripts/prepare-ChangeLog:
2974
2975 2007-10-21  Mark Rowe  <mrowe@apple.com>
2976
2977         Reviewed by Eric.
2978
2979         Fix run-javascriptcore-tests for Gtk.
2980
2981         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2982
2983 2007-10-20  Eric Seidel  <eric@webkit.org>
2984
2985         Reviewed by aroben.
2986
2987         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2988
2989 2007-10-20  Eric Seidel  <eric@webkit.org>
2990
2991         Reviewed by darin.
2992         
2993         Add improved argument handling to run-sunspider, including
2994         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2995         Also re-factor code into subroutines
2996
2997         * Scripts/build-dumprendertree: removed bogus comments
2998         * Scripts/build-testkjs: Added.
2999         * Scripts/run-javascriptcore-tests: use build-testkjs
3000         * Scripts/run-sunspider: improved argument handling, abstraction
3001         * Scripts/run-webkit-tests: improved abstraction
3002
3003 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3004
3005         Not reviewed, Windows build fix.
3006
3007         * DumpRenderTree/win/EventSender.cpp:
3008         (keyDownCallback):
3009
3010 2007-10-20  Darin Adler  <darin@apple.com>
3011
3012         Reviewed by Tim Hatcher.
3013
3014         - http://bugs.webkit.org/show_bug.cgi?id=15544
3015           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3016           not rely on Apple-specific key codes
3017
3018         * DumpRenderTree/mac/EventSendingController.mm:
3019         (-[EventSendingController keyDown:withModifiers:]):
3020         Added named key "rightArrow". Later we could have a whole table of these.
3021         Also tweaked modifiers code a little.
3022
3023         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3024
3025 2007-10-19  Darin Adler  <darin@apple.com>
3026
3027         Reviewed by Eric.
3028
3029         - http://bugs.webkit.org/show_bug.cgi?id=15566
3030           possible fix for leak seen in DumpRenderTree
3031
3032         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3033         Delete the item if it's not put on the queue, since the caller has
3034         no way of knowing that. Would be better to have the parameter type
3035         be auto_ptr to express the fact that we take ownership.
3036
3037         - unrelated change
3038
3039         * Drosera/mac/main.m: Add missing include.
3040
3041 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3042
3043         Reviewed by Adam.
3044
3045         - This change should be identical but for some reason was not working
3046         on my machine.
3047
3048         * Scripts/prepare-ChangeLog:
3049
3050 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3051
3052         Reviewed by Oliver and Tim.
3053
3054         - Made use of RetainPtr to avoid retain and release issues and moved the
3055         log function to DebuggerDocumentPlatform, which seems to be a more
3056         logical place for it to live.
3057         - Also moved knownServers from the ServerConnection to
3058         DebuggerApplication to match the Windows code and because it makes sense
3059         that a connection knows its own server but not all of them.
3060
3061         * Drosera/mac/DebuggerClient.h: Moved the log function to
3062           DebuggerDocumentPlatform.
3063         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3064           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3065           call for the server name up from the ServerConnection class.
3066         (-[DebuggerClient dealloc]):
3067         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3068           for the server name up from the ServerConnection.
3069         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3070         (DebuggerDocument::platformPause):
3071         (DebuggerDocument::platformResume):
3072         (DebuggerDocument::platformStepInto):
3073         (DebuggerDocument::platformEvaluateScript):
3074         (DebuggerDocument::getPlatformCurrentFunctionStack):
3075         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3076         (DebuggerDocument::platformValueForScopeVariableNamed):
3077         (DebuggerDocument::platformLog): Log directly from here. No need to call
3078           DebuggerClient.
3079         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3080           way I see it, a ServerConnection should only know about its connection
3081           and the group of all possible servers should be kept by the
3082           application.
3083         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3084           currentServerName, it makes sense that the connection should know that
3085           name.
3086         (-[ServerConnection currentServerName]):
3087
3088 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3089
3090         Reviewed by Adam.
3091
3092         - Integrated changes from mac drosera.  Recently I've encapsulated
3093         out the server connection object from the rest of Drosera because
3094         it is very platform dependent right now and RPC is not implemented on
3095         windows.  This functionality, of communicating with the WebKit server
3096         is the next area I will be focusing on in Windows.
3097
3098         - Other changes and cleanup were made to organize the code and add notes
3099         on which parts still need work.  Also some mac code is added and
3100         commented out, to act as pseudocode for the logic of those parts.
3101
3102         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3103           pointer.
3104         * Drosera/config.h: Added whitespace.
3105         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3106           these files got moved into Drosera.h/cpp
3107         * Drosera/win/DebuggerApplication.h: Removed.
3108         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3109           happened here to better match the logic flow of the same code on the 
3110           mac side and to use the new ServerConnection class.
3111         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3112         (DebuggerClient::initWithServerName): Initializer that will set up the
3113           class to use a ServerConnection object.  This was necessary so I could
3114           create a DebuggerClient without having to initilaize it at
3115           construction.
3116         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3117           will be the UIDelegate and FrameLoadDelegate.
3118         (DebuggerClient::AddRef): For IUnknown.
3119         (DebuggerClient::Release): For IUnknown.
3120         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3121           this still needs to set the global context of the server, but
3122           IWebFrame does not have an accessor for the global context yet. 
3123         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3124           this is a pass through for the same function in the document.
3125         (DebuggerClient::didReceiveTitle): Unimplemented part of
3126           FrameLoadDelegate this would change the title of the window.
3127         (DebuggerClient::createWebViewWithRequest): Part of the
3128           FrameLoadDelegate.  This is about new windows via Window.open() and
3129           how their delegates are set.
3130         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3131           UIDelegate.  Just a debug function for printing messages.
3132         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3133           because the Client should be the UIDelegate and FrameLoadDelegate
3134           to match the delegates on mac.
3135         (DebuggerClient::webViewLoaded): Added accessor method.
3136         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3137           forgotten to add this file before.  This is where the platform
3138           dependent versions of the Documents functions live. Most of these are
3139           unimplemented because some piece of functionality does not exist on
3140           Windows yet.
3141         (DebuggerDocument::platformPause):
3142         (DebuggerDocument::platformResume):
3143         (DebuggerDocument::platformStepInto):
3144         (DebuggerDocument::platformEvaluateScript):
3145         (DebuggerDocument::getPlatformCurrentFunctionStack):
3146         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3147         (DebuggerDocument::platformValueForScopeVariableNamed):
3148         (DebuggerDocument::platformLog):
3149         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3150           responsibilities becaue they belong in the Client. Also I laid the
3151           groundwork for attaching Drosera to a WebKit process
3152         (attachWndProc): Now if a server is selected the Client becomes it's
3153           delegate.
3154         (Drosera::Drosera): Added the construction of the Client and dictionary
3155           of server names. 
3156         (Drosera::initUI): This is no longer the delegates, the Client is.
3157         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3158           state. 
3159         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3160           notification registration when it's possible to implement.
3161         (Drosera::serverLoaded): Ditto
3162         (Drosera::serverUnloaded): Ditto
3163         (Drosera::attach): Attach Drosera to the WebKit server.
3164         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3165         (Drosera::getInst): 
3166         (Drosera::setInst):
3167         (Drosera::knownServers):
3168         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3169           and added the ServerConnection.
3170         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3171         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3172           Most of the functions are completely unimlemented because they cannot
3173           connect with the WebKit server, because one does not exist on Windows
3174           yet.
3175         (ServerConnection::initWithServerName): 
3176         (ServerConnection::~ServerConnection):
3177         (ServerConnection::setGlobalContext):
3178         (ServerConnection::pause):
3179         (ServerConnection::resume):
3180         (ServerConnection::stepInto):
3181         (ServerConnection::switchToServerNamed):
3182         (ServerConnection::applicationTerminating):
3183         (ServerConnection::serverConnectionDidDie):
3184         (ServerConnection::currentFrame):
3185         * Drosera/win/ServerConnection.h: Added. Ditto.
3186         (ServerConnection::ServerConnection):
3187
3188 2007-10-19  Alice Liu  <alice.liu@apple.com>
3189
3190         Reviewed by Darin.
3191
3192         Fix for these broken layout tests on Windows:
3193         
3194         fast/forms/focus-selection-input.html
3195         fast/forms/focus-selection-textarea.html
3196         fast/forms/select-accesskey.html
3197         
3198         * DumpRenderTree/win/EventSender.cpp:
3199         (keyDownCallback):
3200         correct the VK code for alt key.
3201         
3202 2007-10-19  Eric Seidel  <eric@webkit.org>
3203
3204         Reviewed by Mark Rowe.
3205         
3206         Make the GtkLauncher code slightly more readable.
3207
3208         * GtkLauncher/main.cpp:
3209         (setupMainMenu): Added.
3210         (setupMainWindowUI): Added.
3211         (main):
3212
3213 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3214
3215         Rubber stamped by Adam.
3216         
3217         - don't delay-load WebKit in DumpRenderTree.
3218
3219         * DumpRenderTree/win/DumpRenderTree.vcproj:
3220
3221 2007-10-18  Dan Bernstein  <mitz@apple.com>
3222
3223         Reviewed by Adam Roben.
3224
3225         - fix <rdar://problem/5313523>
3226         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3227
3228         * DumpRenderTree/mac/DumpRenderTree.mm:
3229         (dump): Changed to use _responseMIMEType.
3230
3231 2007-10-17  Adam Roben  <aroben@apple.com>
3232
3233         Make it possible to have Windows-specific tests and results
3234
3235         When searching for tests to run and the Skipped file, we will only
3236         look in platform/win and the cross-platform directory. When looking
3237         for expected results, we will look in platform/win, then
3238         platform/mac-leopard, then platform/mac, then finally the
3239         cross-platform directory.
3240
3241         Reviewed by Sam.
3242
3243         * Scripts/run-webkit-tests:
3244         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3245         searching in the cross-platform directory.
3246         (sub buildPlatformHierarchy): Removed some unneeded calls to
3247         dirname/basename.
3248
3249 2007-10-17  Adam Roben  <aroben@apple.com>
3250
3251         Add back the call to register WebKit that we had before WebKitInitializer existed
3252
3253         This is needed to ensure that the right WebKit is used when
3254         instantiating COM objects.
3255
3256         Reviewed by Oliver.
3257
3258         * DumpRenderTree/win/debug_internal.vsprops: Define
3259         DEBUG_WEBKIT_HAS_SUFFIX.
3260         * DumpRenderTree/win/DumpRenderTree.cpp:
3261         (initialize):
3262
3263 2007-10-17  Adam Roben  <aroben@apple.com>
3264
3265         Import File::Basename in webkitdirs since we use it
3266
3267         * Scripts/webkitdirs.pm:
3268
3269 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3270
3271         - Updated the tiger leaks list to make the internal bots green.
3272
3273         * Scripts/run-webkit-tests:
3274
3275 2007-10-17  Adam Roben  <aroben@apple.com>
3276
3277         Build fix for VC++ Express
3278
3279         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3280         and ole32.lib.
3281
3282 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3283
3284         Reviewed by Sam.
3285
3286         - Minor mac improvements based on observations I made while implementing the
3287         Windows code.
3288
3289         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3290         then hand it to the Client who will retain it, it should just be the client who
3291         creates and owns the server.
3292         (-[DebuggerApplication attach:]):
3293         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3294         * Drosera/mac/DebuggerClient.mm: Creates the server.
3295         (-[DebuggerClient initWithServerName:]):
3296         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3297         can instead forward declare what it needs.
3298
3299 2007-10-16  Darin Adler  <darin@apple.com>
3300
3301         Reviewed by Geoff Garen.
3302
3303         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3304         want to turn failing tests into platform-specific test results. Also did a
3305         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3306         would take the type of results into account only some of the time.
3307
3308 2007-10-16  Adam Roben  <aroben@apple.com>
3309
3310         Add a new nightly launcher script for Windows
3311
3312         This new script is for versions of Safari that don't delay-load
3313         WebKit. I had to make FindSafari be able to print out the nightly
3314         launcher script on stdout because Windows shell scripts can't capture
3315         the output from a command into an environment variable.
3316
3317         Reviewed by Steve.
3318
3319         * FindSafari/FindSafari.cpp:
3320         (_tmain): Added /printSafariLauncher option.
3321         * Scripts/run-webkit-nightly.cmd: Added.
3322
3323 2007-10-16  Adam Roben  <aroben@apple.com>
3324
3325         Replace WebKitInitializer with FindSafari
3326
3327         We now rely on setting the PATH environment variable to tell Windows
3328         where to find WebKit and its dependencies (similar to
3329         DYLD_FRAMEWORK_PATH on Mac).
3330
3331         This change also make DumpRenderTree no longer delay-load WebKit.
3332
3333         Reviewed by Sam.
3334
3335         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3336         FindSafari.
3337         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3338         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3339         WebKitInitializer, don't delay-load WebKit.
3340         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3341         * Scripts/run-webkit-tests: Ditto.
3342         * Scripts/webkitdirs.pm:
3343         (sub setPathForRunningWebKitApp): Added.
3344         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3345         * WebKitInitializer/WebKitInitializer.h: Removed.
3346         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3347         * WebKitInitializer/debug.vsprops: Removed.
3348         * WebKitInitializer/debug_internal.vsprops: Removed.
3349         * WebKitInitializer/release.vsprops: Removed.
3350
3351 2007-10-16  Adam Roben  <aroben@apple.com>
3352
3353         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3354
3355         http://bugs.webkit.org/show_bug.cgi?id=15532
3356
3357         FindSafari simply prints the location of an installed Safari.exe on
3358         stdout.
3359
3360         Reviewed by Darin.
3361
3362         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3363         (getStringValue):
3364         (getWebViewCLSID):
3365         (getInstalledWebKitDirectory):
3366         (_tmain):
3367         * FindSafari/FindSafari.vcproj: Added.
3368         * Scripts/webkitdirs.pm:
3369         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3370
3371 2007-10-16  Adam Roben  <aroben@apple.com>
3372
3373         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3374
3375         Reviewed by Kevin McCullough.
3376
3377         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3378         when referring to WebKit.dll.
3379         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3380         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3381         * DumpRenderTree/win/release.vsprops: Ditto.
3382         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3383         never have a _debug suffix on WebKit.dll.
3384         * WebKitInitializer/WebKitInitializer.cpp:
3385         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3386         specified.
3387         * WebKitInitializer/debug_internal.vsprops: Added
3388         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3389
3390 2007-10-16  Darin Adler  <darin@apple.com>
3391
3392         Reviewed by Adele.
3393
3394         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3395         Remove now-unneeded control/alt key hack; the tests have been updated.
3396
3397 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3398
3399         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3400         one of the leaks was fixed between that revision and the bot's previous version of
3401         leopard.
3402
3403         * Scripts/run-webkit-tests:
3404
3405 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3406
3407         Reviewed by Tim.
3408
3409         - I encapsulated out the server connecton functionality because it is a specific part
3410         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3411         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3412         Windows.  So the majority of this patch is moving preexisting functionality.
3413
3414         - Also I removed the prefix header and changed to use config.h because it is more
3415         standard on how we use config.h in windows and it didn't make much sense to keep
3416         the prefix header and the config.h
3417
3418         * Drosera/DebuggerDocument.cpp:
3419         (DebuggerDocument::DebuggerDocument):
3420         * Drosera/DebuggerDocument.h:
3421         * Drosera/config.h:
3422         * Drosera/mac/DebuggerApplication.mm:
3423         (-[DebuggerApplication attach:]):
3424         * Drosera/mac/DebuggerClient.h:
3425         * Drosera/mac/DebuggerClient.mm:
3426         (-[DebuggerClient initWithServerConnection:]):
3427         (-[DebuggerClient dealloc]):
3428         (-[DebuggerClient windowDidLoad]):
3429         (-[DebuggerClient windowWillClose:]):
3430         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3431         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3432         * Drosera/mac/DebuggerDocumentPlatform.mm:
3433         (DebuggerDocument::platformPause):
3434         (DebuggerDocument::platformResume):
3435         (DebuggerDocument::platformStepInto):
3436         (DebuggerDocument::platformEvaluateScript):
3437         (DebuggerDocument::getPlatformCurrentFunctionStack):
3438         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3439         (DebuggerDocument::platformValueForScopeVariableNamed):
3440         (DebuggerDocument::platformLog):
3441         * Drosera/mac/Drosera.pch: Removed.
3442         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3443         * Drosera/mac/ServerConnection.h: Added.
3444         * Drosera/mac/ServerConnection.mm: Added.
3445         (-[ServerConnection initWithServerName:]):
3446         (-[ServerConnection dealloc]):
3447         (-[ServerConnection setGlobalContext:]):
3448         (-[ServerConnection pause]):
3449         (-[ServerConnection resume]):
3450         (-[ServerConnection stepInto]):
3451         (-[ServerConnection switchToServerNamed:]):
3452         (-[ServerConnection applicationTerminating:]):
3453         (-[ServerConnection serverConnectionDidDie:]):
3454         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3455         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3456         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3457         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3458         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3459         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3460         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3461         (-[ServerConnection currentFrame]):
3462         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3463         (-[ServerConnection knownServers]):
3464
3465 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3466
3467         Reviewed by Eric.
3468
3469         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3470           Script to automatically search nightly builds for regressions (bisect-builds)
3471
3472         * Scripts/bisect-builds: Added.
3473
3474 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3475
3476         Reviewed by Darin.
3477
3478         - New JavaScript benchmark
3479         http://bugs.webkit.org/show_bug.cgi?id=15515
3480
3481         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3482         current development or release build of JavaScriptCore.
3483
3484 2007-10-15  Mark Rowe  <mrowe@apple.com>
3485
3486         Reviewed by Sam.
3487
3488         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3489
3490         * Scripts/webkitdirs.pm:
3491         - Change checkArgv to remove the options from @ARGV to prevent
3492         them from interfering with further option processing.
3493         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3494         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3495         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3496         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3497
3498 2007-10-15  Darin Adler  <darin@apple.com>
3499
3500         Reviewed by Sam.
3501
3502         - added logging of window.prompt and window.confirm
3503
3504         * DumpRenderTree/mac/UIDelegate.mm:
3505         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3506         Implement the recommended delegate rather than the deprecated one.
3507         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3508         Added.
3509         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3510         Added.
3511
3512         * DumpRenderTree/win/UIDelegate.h:
3513         * DumpRenderTree/win/UIDelegate.cpp:
3514         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3515         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3516         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3517         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3518
3519 2007-10-15  Alice Liu  <alice.liu@apple.com>
3520
3521         Reviewed by Sam Weinig.
3522
3523         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3524
3525         * DumpRenderTree/win/DumpRenderTree.cpp:
3526         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3527         (main): allocate the global policy delegate for DRT's custom use
3528         * DumpRenderTree/win/DumpRenderTree.vcproj:
3529         Adding files to project
3530         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3531         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3532         (LayoutTestController::setCustomPolicyDelegate):
3533         set the webview's policy delegate to DRT's custom one if the test requests it.
3534         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3535         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3536         (PolicyDelegate::PolicyDelegate):
3537         (PolicyDelegate::QueryInterface):
3538         (PolicyDelegate::AddRef):
3539         (PolicyDelegate::Release):
3540         (PolicyDelegate::decidePolicyForNavigationAction):
3541         * DumpRenderTree/win/PolicyDelegate.h: Added.
3542         (PolicyDelegate::decidePolicyForNewWindowAction):
3543         (PolicyDelegate::decidePolicyForMIMEType):
3544         (PolicyDelegate::unableToImplementPolicyWithError):
3545
3546 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3547
3548         Reviewed by Mark.
3549
3550         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3551         when querying for QMAKE_MKSPECS.
3552
3553 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3554
3555         Reviewed by Adam Roben.
3556         
3557         Fix run-webkit-tests is too greedy calculating platform hierarchy
3558         http://bugs.webkit.org/show_bug.cgi?id=15465
3559         
3560         Fix run-webkit-tests being too greedy in trying to split the platform name up
3561         causing it to try and find tests in every directory above the first "-" in the
3562         path to the LayoutTests
3563
3564         * Scripts/run-webkit-tests:
3565
3566 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3567
3568         Reviewed by Darin.
3569
3570         http://bugs.webkit.org/show_bug.cgi?id=15006
3571         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3572         to reduce code duplication.
3573
3574         * Scripts/build-webkit:
3575         * Scripts/webkitdirs.pm:
3576         buildQMakeProject() renamed to buildQMakeQtProject().
3577         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3578         unused $colorize has been removed.
3579
3580 === Start merge of feature-branch 2007-10-12 ===
3581
3582 2007-10-08  Eric Seidel  <eric@webkit.org>
3583
3584         Reviewed by Mark Rowe.
3585
3586         * Scripts/build-webkit: add --help, remove unused --color
3587
3588 2007-10-07  Eric Seidel  <eric@webkit.org>
3589
3590         Reviewed by darin.
3591
3592         * Drosera/mac/DebuggerDocumentPlatform.mm:
3593         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3594
3595 2007-10-03  Rob Buis  <buis@kde.org>
3596
3597         Reviewed by Olliej.
3598
3599         Adapt to changed location of Ahem font.
3600
3601         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3602
3603 2007-10-02  Eric Seidel  <eric@webkit.org>
3604
3605         Reviewed by Adam Roben.
3606         
3607         Make pixel tests more useful!
3608         Finally fix the image diff 0.00% mystery problem
3609         Highlight any image differences in the image diff.
3610         Add a link from image diffs back to original test file.
3611
3612         * DumpRenderTree/mac/ImageDiff.m:
3613         (compareImages): highlight any differences
3614         (computePercentageDifferent): round to two decimal places
3615         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3616
3617 2007-10-02  Eric Seidel  <eric@webkit.org>
3618
3619         Reviewed by Alexey Proskuryakov.
3620
3621         * Scripts/run-webkit-tests: print the % image difference on main results page
3622
3623 2007-10-02  Mark Rowe  <mrowe@apple.com>
3624
3625         Reviewed by Oliver.
3626
3627         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3628
3629         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3630         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3631
3632 2007-10-01  Mark Rowe  <mrowe@apple.com>
3633
3634         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3635
3636 2007-09-25  Eric Seidel  <eric@webkit.org>
3637
3638         Reviewed by Mark Rowe.
3639         
3640         DerivedSources.make was finding "ENABLE_SVG" in the string
3641         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3642         quite correctly.
3643
3644         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3645
3646 2007-09-25  Mark Rowe  <mrowe@apple.com>
3647
3648         Rubber-stamped by Eric.
3649
3650         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3651         This makes it possible to automate nightly builds for the feature-branch.
3652
3653 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3654
3655         Rubber stamped by Mark.
3656
3657         Enable svg experimental features as default here in feature-branch.
3658
3659         * Scripts/build-webkit:
3660
3661 2007-06-29  Antti Koivisto  <antti@apple.com>
3662
3663         Reviewed by Weinig.
3664         
3665         Add VIDEO flag for timed media features
3666
3667         * Scripts/build-webkit
3668         
3669 === End merge of feature-branch 2007-10-12 ===
3670
3671 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3672
3673         Reviewed by Darin.
3674
3675         - Updated rational for the leaks list to be more clear.
3676
3677         * Scripts/run-webkit-tests:
3678
3679 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3680
3681         Rubber Stamp by Sam.
3682
3683         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3684         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3685
3686         * Scripts/run-webkit-tests:
3687
3688 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3689
3690         Reviewed by Lars.
3691
3692         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3693         includes are needed for INT_MAX, std::auto_ptr and the like.
3694