59d63370c51b6c51db7836d947eebad698cc792f
[WebKit.git] / WebKitTools / ChangeLog
1 2010-04-05  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         SheriffBot should include blamelist when posting to bugs
6         https://bugs.webkit.org/show_bug.cgi?id=37113
7
8         When posting on bugs, we should include the full list of SVN revisions
9         that caused the regression to folks have a better sense of whether they
10         are to blame.
11
12         * Scripts/webkitpy/tool/bot/sheriff.py:
13         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
14         * Scripts/webkitpy/tool/commands/sheriffbot.py:
15         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
16         * Scripts/webkitpy/tool/commands/upload_unittest.py:
17         * Scripts/webkitpy/tool/mocktool.py:
18
19 2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>
20
21         Unreviewed after discussion with Adam, Darin, and Eric.
22
23         Deleted the auto-install directory since it is no longer needed in
24         source control (it is auto-generated).
25
26         Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
27         svn:ignore property.
28
29         * Scripts/webkitpy/thirdparty/autoinstalled: Removed.
30
31 2010-04-05  Mark Rowe  <mrowe@apple.com>
32
33         Reviewed by Adele Peterson.
34
35         Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
36         REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
37
38         Add a JavaScript hook in DRT to call through to WebView's -setEditable:.  This is required in order to reproduce
39         the crash.
40
41         * DumpRenderTree/LayoutTestController.cpp:
42         (setWebViewEditableCallback):
43         (LayoutTestController::staticFunctions):
44         * DumpRenderTree/LayoutTestController.h:
45         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
46         (LayoutTestController::setWebViewEditable):
47         * DumpRenderTree/mac/DumpRenderTree.mm:
48         (resetWebViewToConsistentStateBeforeTesting):
49         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
50         (LayoutTestController::setWebViewEditable):
51         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
52         (LayoutTestController::setWebViewEditable):
53         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
54         (LayoutTestController::setWebViewEditable):
55         (LayoutTestController::layerTreeAsText):
56
57 2010-04-05  Darin Adler  <darin@apple.com>
58
59         Ignore more files the Python tools strew about the working directory.
60
61         * Scripts/webkitpy: Added property svn:ignore.
62         * Scripts/webkitpy/common: Added property svn:ignore.
63         * Scripts/webkitpy/common/checkout: Added property svn:ignore.
64         * Scripts/webkitpy/common/config: Added property svn:ignore.
65         * Scripts/webkitpy/common/net: Added property svn:ignore.
66         * Scripts/webkitpy/common/thread: Added property svn:ignore.
67         * Scripts/webkitpy/python24: Added property svn:ignore.
68         * Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
69         * Scripts/webkitpy/tool/bot: Added property svn:ignore.
70
71 2010-04-05  Adam Barth  <abarth@webkit.org>
72
73         Unreviewed.  Add Vitaly Repeshko as a committer.
74
75         * Scripts/webkitpy/common/config/committers.py:
76
77 2010-04-05  Adam Barth  <abarth@webkit.org>
78
79         Unreviewed.  Update kenne's IRC nick to his registered nick.
80
81         * Scripts/webkitpy/common/config/committers.py:
82
83 2010-04-05  Ojan Vafai  <ojan@chromium.org>
84
85         Reviewed by Eric Seidel.
86
87         assorted helper functions and cleanup of git utilities
88         https://bugs.webkit.org/show_bug.cgi?id=37103
89
90         * Scripts/webkitpy/common/checkout/scm.py:
91         No code currently uses the optional dry_run argument. So removing it.
92         Change all uses of "trunk" to read the correct value out of the git config.
93         Made the dcommit call actually get called when dry_run==true.
94         * Scripts/webkitpy/common/checkout/scm_unittest.py:
95         * Scripts/webkitpy/common/net/credentials.py:
96         Move the git config call into scm.
97         * Scripts/webkitpy/common/net/credentials_unittest.py:
98         * Scripts/webkitpy/common/system/executive.py:
99         If return_exit_code==true, don't error out, just return the exit_code.
100
101 2010-04-05  Ojan Vafai  <ojan@chromium.org>
102
103         Reviewed by Eric Seidel.
104
105         prepare-ChangeLog should take a merge-base for which git branch to diff against.
106         https://bugs.webkit.org/show_bug.cgi?id=36394
107
108         * Scripts/prepare-ChangeLog:
109
110 2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>
111
112         Reviewed by Shinichiro Hamaji.
113
114         Removed the PatchStyleErrorHandler class and incorporated its
115         functionality into the DefaultStyleErrorHandler class.
116
117         https://bugs.webkit.org/show_bug.cgi?id=37067
118
119         * Scripts/webkitpy/style/checker.py:
120           - In the StyleChecker class:
121             - Added a line_number parameter to the check_file() method.
122             - Renamed the handle_style_error parameter to
123               mock_handle_style_error to be consistent with the other mock_*
124               parameter names.
125             - Added a mock_check_file parameter to the check_patch() method
126               to facilitate unit testing the changes in this patch.
127             - Rewrote the check_patch() method with the patch-parsing logic
128               taken from the PatchStyleErrorHandler class.
129
130         * Scripts/webkitpy/style/checker_unittest.py:
131           - Added a StyleCheckerCheckFileBase class and sub-classed the
132             existing StyleCheckerCheckFileTest class from it.
133           - Added a StyleCheckerCheckPatchTest class to unit-test the
134             rewritten check_patch() method.
135           - Removed the vestigial __main__ code at the bottom of the file.
136             This is left over from when check-webkit-style was implemented
137             as a module and a wrapper module.
138
139         * Scripts/webkitpy/style/error_handlers.py:
140           - Added an optional line_numbers parameter to the
141             DefaultStyleErrorHandler class constructor and adjusted the
142             __call__() method as necessary.
143           - Removed the PatchStyleErrorHandler class.
144
145         * Scripts/webkitpy/style/error_handlers_unittest.py:
146           - Removed the PatchStyleErrorHandlerTest class which unit-tested
147             the PatchStyleErrorHandler class which is being removed in this
148             patch.
149           - Added a test_line_numbers() test method to the
150             DefaultStyleErrorHandlerTest class to test use of the
151             DefaultStyleErrorHandler's new line_numbers attribute.
152
153 2010-04-05  Adam Barth  <abarth@webkit.org>
154
155         Unreviewed.
156
157         Tighten SheriffBot's flaky test detector
158         https://bugs.webkit.org/show_bug.cgi?id=37063
159
160         Instead of just looking for two sequential red builds, look for two
161         sequential failures of the same test.  This should reduce sheriffbot
162         false positive substantially.
163
164         I'm landing this change unreviewed because I've noticed SheriffBot
165         triggering a lot more false positives now that we've expanded the set
166         of core builders.  I've tried to take Eric's comments on Bug 37063 into
167         account.  I'm happy to iterate on this patch tomorrow once Eric wakes
168         up.
169
170         * Scripts/webkitpy/common/net/buildbot.py:
171         * Scripts/webkitpy/common/net/buildbot_unittest.py:
172         * Scripts/webkitpy/tool/commands/queries.py:
173
174 2010-04-04  John Gregg  <johnnyg@google.com>
175
176         Unreviewed, add myself to the committers list.
177
178         * Scripts/webkitpy/common/config/committers.py:
179
180 2010-04-04  Robert Hogan  <robert@webkit.org>
181
182         Unreviewed, add myself to the committers list.
183
184         * Scripts/webkitpy/common/config/committers.py:
185
186 2010-04-04  Dumitru Daniliuc  <dumi@chromium.org>
187
188         Unreviewed, adding my IRC nickname to committers.py
189
190         * Scripts/webkitpy/common/config/committers.py:
191
192 2010-04-04  Chris Jerdonek  <cjerdonek@webkit.org>
193
194         Reviewed by Shinichiro Hamaji.
195
196         Refactored check-webkit-style's option-parsing code.
197
198         https://bugs.webkit.org/show_bug.cgi?id=37064
199
200         * Scripts/check-webkit-style:
201           - Moved the "WebKit checkout not found" check from
202             ArgumentParser.parse() to the calling code.
203           - Moved the --git-commit argument validation from the calling
204             code to ArgumentParser.parse().
205
206         * Scripts/webkitpy/style/checker_unittest.py:
207           - Updated a unit test as necessary.
208
209         * Scripts/webkitpy/style/optparser.py:
210           - Renamed ArgumentParser._exit_with_help() to _parse_error()
211             and made its error_message parameter required.
212           - Removed the found_checkout parameter from ArgumentParser.parse().
213           - Removed the "WebKit checkout not found" check and moved it
214             to the calling code.
215           - Added --git-commit argument checking.
216
217         * Scripts/webkitpy/style/optparser_unittest.py:
218           - Adjusted the import statements to be fully qualified.
219           - Changed the ArgumentParserTest class to inherit from
220             LoggingTestCase, and updated the class as necessary.
221           - Added a unit-test for the --git-commit validation.
222           - Added unit tests for the --git-diff and --git-since variants
223             of --git-commit.
224
225 2010-04-03  Chris Jerdonek  <cjerdonek@webkit.org>
226
227         Reviewed by Shinichiro Hamaji.
228
229         The check-webkit-style script now logs an ERROR and exits when
230         encountering a file path that does not exist.  Previously, it failed
231         silently on such paths.
232
233         https://bugs.webkit.org/show_bug.cgi?id=36957
234
235         * Scripts/webkitpy/common/system/logtesting.py:
236           - Added a FIXME to rename the LoggingTestCase class to
237             LoggingTestCaseBase.
238
239         * Scripts/webkitpy/style/checker.py:
240           - In the StyleChecker.check_file() method:
241             - Added a mock_os_path_exists parameter.
242             - Renamed the process_file parameter to mock_process_file.
243             - Added logic to log an error and exist if the given path does
244               not exist.
245
246         * Scripts/webkitpy/style/checker_unittest.py:
247           - Refactored the StyleCheckerCheckFileTest class slightly to
248             inherit from LoggingTestCase.
249           - Added a test method to unit-test the case of a file that
250             does not exist.
251           - Adjusted the other test methods as necessary.
252
253 2010-04-03  Adam Barth  <abarth@webkit.org>
254
255         Reviewed by Eric Seidel.
256
257         Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
258         https://bugs.webkit.org/show_bug.cgi?id=33289
259
260         Add Tiger and SnowLeopard Tests to the core builders.  This is a bit of
261         an experiment now that the bots are green.  Hopefully we can keep them
262         on the list and have the tree stay greener.
263
264         * Scripts/webkitpy/common/net/buildbot.py:
265
266 2010-04-02  Adam Barth  <abarth@webkit.org>
267
268         Unreviewed.
269
270         Have Eric and Adam watch the SheriffBot
271         https://bugs.webkit.org/show_bug.cgi?id=37054
272
273         * Scripts/webkitpy/tool/bot/sheriff.py:
274         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
275         * Scripts/webkitpy/tool/commands/sheriffbot.py:
276
277 2010-04-02  Adam Barth  <abarth@webkit.org>
278
279         Reviewed by Darin Adler.
280
281         commit-queue should ignore builders when landing rollouts
282         https://bugs.webkit.org/show_bug.cgi?id=37051
283
284         When we moved the "builders are red" check into the master process, we
285         forgot about rollouts.  I thought we had a test covering this case, but
286         looking at the test, it was a bit too loose.  I added a new test and
287         introduced some new logging technology into MockTool to make the test
288         tighter.
289
290         * Scripts/webkitpy/tool/commands/queues.py:
291         * Scripts/webkitpy/tool/commands/queues_unittest.py:
292         * Scripts/webkitpy/tool/mocktool.py:
293
294 2010-04-02  David Levin  <levin@chromium.org>
295
296         Reviewed by Adam Barth.
297
298         sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
299         https://bugs.webkit.org/show_bug.cgi?id=37030
300
301         * Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't
302           start with -.
303         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout
304           reason which starts with -.
305         * Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.
306
307 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
308
309         Unreviewed.
310
311         Fixed check-webkit-style to recognize the short form of the
312         --verbose option, as stated in --help.
313
314         * Scripts/check-webkit-style:
315           - Tweaked one line.
316
317 2010-04-02  Kevin Ollivier  <kevino@theolliviers.com>
318
319         [wx] Build fix for DumpRenderTree after addition of layerTreeAsText.
320
321         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
322         (LayoutTestController::layerTreeAsText):
323
324 2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
325
326         Reviewed by Eric Seidel.
327
328         Accept XHTML-MP content type as XHTML content
329         https://bugs.webkit.org/show_bug.cgi?id=34262
330
331         Register xhtmlmp file extension as the new type
332         for XHTML-MP test content.
333
334         * Scripts/run-webkit-tests:
335         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
336         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
337
338 2010-04-02  Adam Barth  <abarth@webkit.org>
339
340         Reviewed by Eric Seidel.
341
342         create-rollout doesn't fill out ChangeLog
343         https://bugs.webkit.org/show_bug.cgi?id=37010
344
345         The contract between apply_reverse_diff and PrepareChangeLogForRevert
346         was unclear.  I broke filling out the ChangeLog during rollout earlier
347         when I changed apply_reverse_diff to revert the ChangeLogs because
348         PrepareChangeLogForRevert thought that it was supposed to do that.
349         I've now taught PrepareChangeLogsForRevert the new contract.
350
351         It's unclear to me how to test this change because it's essentially an
352         integration issue that requires the file system.  At some point we
353         should think about a testing strategy for integration.  As the system
354         becomes larger, we're running into more of these issues.
355
356         * Scripts/webkitpy/common/checkout/api.py:
357         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
358
359 2010-04-02  Adam Barth  <abarth@webkit.org>
360
361         Reviewed by Eric Seidel.
362
363         Add cr-win-ews to QueueStatusServer
364         https://bugs.webkit.org/show_bug.cgi?id=37004
365
366         * QueueStatusServer/model/queues.py:
367         * QueueStatusServer/templates/dashboard.html:
368         * QueueStatusServer/templates/statusbubble.html:
369
370 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
371
372         Reviewed by Adam Barth.
373
374         Unit-test networktransaction.py's log messages, and add a base
375         class to make unit-testing log messages even easier.
376         
377         https://bugs.webkit.org/show_bug.cgi?id=36958
378
379         The purpose of this patch is also to provide a mini-tutorial on
380         how to unit-test Python logging.py messages.
381
382         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
383           - Unit-tested the log messages in test_retry().
384
385         * Scripts/webkitpy/common/system/logtesting.py:
386           - Adjusted the LogTesting class by moving the code that clears
387             the array of log messages into a finally block.  This prevents
388             redundant AssertionErrors from getting rendered to the screen
389             while running unit tests.
390           - Added a LoggingTestCase class so the setUp() and tearDown()
391             methods do not need to be implemented in order to test logging.
392             Rather, TestCase classes can simply inherit from this class.
393
394 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
395
396         Reviewed by Shinichiro Hamaji.
397
398         Re-wrote check-webkit-style's argument parsing code to use
399         Python's optparser module and more uniform error-handling logic.
400
401         https://bugs.webkit.org/show_bug.cgi?id=34676
402
403         * Scripts/webkitpy/style/optparser.py:
404           - Removed "option help" from check-webkit-style's usage string
405             since that is provided separately by the OptionParser class.
406           - Also changed the usage string from a function to a constant
407             string _USAGE.
408           - Added an _EPILOG string which renders after OptionParser's
409             usage string and option help.
410           - In the ArgumentParser class:
411             - Changed the constructor's stderr_write parameter to a
412               mock_stderr since the OptionParser accepts a sys.stderr
413               substitute rather than a sys.stderr.write substitute.
414             - Changed the constructor to set a _parser data attribute with
415               an OptionParser instance.
416             - Added a _create_option_parser() method which instantiates
417               the OptionParser.
418             - Updated _exit_with_help() to interact with the OptionParser's
419               help method.
420             - Updated the parse() method as necessary.  Also changed the
421               raising of ValueErrors to calls to _exit_with_help().
422
423         * Scripts/webkitpy/style/optparser_unittest.py:
424           - Removed the CreateUsageTest class since the create_usage method
425             was replaced by a constant string.
426           - Added a _MockStdErr class to the ArgumentParserTest class.
427           - Updated the unit tests as necessary.
428
429
430 2010-04-02  Adam Barth  <abarth@webkit.org>
431
432         Reviewed by Eric Seidel.
433
434         The master commit-queue process should take responsibility for checking that the builders are green
435         https://bugs.webkit.org/show_bug.cgi?id=37009
436
437         We had a failure where the child process noticed that the builders were
438         red.  We've always had this race condition, but the new optimistic
439         design made it easier to trigger.
440
441         * Scripts/webkitpy/tool/commands/queues.py:
442
443 2010-04-02  Adam Barth  <abarth@webkit.org>
444
445         Reviewed by Eric Seidel.
446
447         Tweak rollout changelog to pass ValidateReviewer check
448         https://bugs.webkit.org/show_bug.cgi?id=37019
449
450         We need to use the magic word "unreviewed" to make the commit-queue
451         happy when landing rollouts.
452
453         * Scripts/webkitpy/common/checkout/changelog.py:
454         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
455
456 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
457
458         Unreviewed.
459
460         Removed duplicate ChangeLog entry.
461
462 2010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
463
464         Rubber-stamped by Eric Seidel.
465
466         To the Python 2.4 error message, added a link to the wiki page
467         that contains instructions on how to upgrade.
468
469         * Scripts/test-webkitpy:
470           - Eliminated a use of the ternary operator in configure_logging()
471             to let the version warning display in case of Python 2.4.
472
473         * Scripts/webkitpy/python24/versioning.py:
474           - Added this link to the error text:
475             http://trac.webkit.org/wiki/PythonGuidelines
476
477         * Scripts/webkitpy/python24/versioning_unittest.py:
478           - Updated unit test text.
479
480 2010-04-02  Adam Barth  <abarth@webkit.org>
481
482         Reviewed by Eric Seidel.
483
484         Record the IRC nick of folks who request rollouts
485         https://bugs.webkit.org/show_bug.cgi?id=36999
486
487         * Scripts/webkitpy/common/net/irc/ircbot.py:
488         * Scripts/webkitpy/tool/bot/irc_command.py:
489         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
490         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
491
492 2010-04-01  Adam Barth  <abarth@webkit.org>
493
494         Reviewed by Eric Seidel.
495
496         Add cr-win-ews
497         https://bugs.webkit.org/show_bug.cgi?id=36974
498
499         Adds support for an Early Warning System for Chromium on Linux.  The
500         interface to the Chromium port is the same on every platform, so we
501         don't need to create a new Port object for this queue.
502
503         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
504         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
505
506 2010-04-01  Adam Barth  <abarth@webkit.org>
507
508         Reviewed by Eric Seidel.
509
510         Using a failure exit code when failing to load a required import
511         https://bugs.webkit.org/show_bug.cgi?id=37000
512
513         Well spotted by Mark Rowe.
514
515         * Scripts/webkitpy/common/system/user.py:
516
517 2010-04-01  Chris Jerdonek  <cjerdonek@webkit.org>
518
519         Reviewed by Eric Seidel.
520
521         Rewrote the revision (r56942) to disable the 79 character line
522         length limit Python/PEP8 style check.
523
524         https://bugs.webkit.org/show_bug.cgi?id=33639#c39
525
526         This rewrite puts the disabling not in the PythonProcessor but
527         in the calling code's default filter rule configuration.  This
528         allows the user to check line-length style from the command-line
529         if desired.
530
531         * Scripts/webkitpy/style/checker.py:
532           - Added "-pep8/E501" to the _BASE_FILTER_RULES configuration
533             variable to disable the line-length check.
534           - Added "-pep8/E501" to the list of recognized style categories
535             to permit the category to be checked from the command line.
536
537         * Scripts/webkitpy/style/processors/python.py:
538           - Reverted r56942: http://trac.webkit.org/changeset/56942
539
540 2010-04-01  Kinuko Yasuda  <kinuko@chromium.org>
541
542         Reviewed by Dmitry Titov.
543
544         Add FileThread for async file operation support in FileReader and FileWriter
545         https://bugs.webkit.org/show_bug.cgi?id=36896
546
547         Add options to enable FILE_READER and FILE_WRITER support.
548
549         * Scripts/build-webkit:
550
551 2010-04-01  Kent Tamura  <tkent@chromium.org>
552
553         Unreviewed. Add missing license header.
554
555         * DumpRenderTree/chromium/TestShellMac.mm:
556
557 2010-04-01  Adam Barth  <abarth@webkit.org>
558
559         Reviewed by Eric Seidel.
560
561         Improve the error handling in rollout a bit
562         https://bugs.webkit.org/show_bug.cgi?id=36995
563
564         This patch does a few things to make the error handling in rollout a
565         bit more robust.
566
567         * Scripts/webkitpy/common/checkout/api.py:
568             The old logic here was wrong.  We don't want to resolve the
569             ChangeLogs (that would remove the old ChangeLog entry).  Instead,
570             we want to revert the ChangeLogs so we can fill them with the new
571             message.
572         * Scripts/webkitpy/tool/commands/download_unittest.py:
573             Update test expectations because we're using a different mock object.
574         * Scripts/webkitpy/tool/commands/download.py:
575             - Added an update command to make updating from the SheriffBot more
576               robust.
577             - Now that we have CommitInfo, we can automatically CC the
578               responsible parties on the bug we create.
579             - Re-ordered the steps in create-rollout.  Our original thinking
580               was that we always wanted to create the bug, but that's not
581               really true given how things appear to be playing out.  If we
582               fail to apply the reverse diff, we don't want to create the bug.
583         * Scripts/webkitpy/tool/commands/sheriffbot.py:
584             - Use the new, more robust update command.
585         * Scripts/webkitpy/tool/steps/createbug.py:
586             Allow commands to pre-load who they want to be CCed on a new bug.
587
588 2010-04-01  Kent Tamura  <tkent@chromium.org>
589
590         Reviewed by Dimitri Glazkov.
591
592         [DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
593         https://bugs.webkit.org/show_bug.cgi?id=36814
594
595         This change introduces:
596         - WebViewHost class
597           It's an implementation of some delegates required by Chromium
598           WebKit API, and manages painting of a WebView. It's base on
599           src/webkit/tools/test_shell/test_webview_delegate.{cc,h} of
600           Chromium rev.40492.
601         - TestShell class
602           The TestShell instance holds global states of DumpRenderTree process.
603           Unlike TestShell class of Chromium test_shell, TestShell instance is
604           created just once.
605         - DumpRenderTree.cpp
606           The program entry.
607
608         * DumpRenderTree/chromium/DumpRenderTree.cpp: Added.
609         * DumpRenderTree/chromium/TestShell.cpp: Added.
610         * DumpRenderTree/chromium/TestShell.h: Added.
611         * DumpRenderTree/chromium/TestShellMac.mm: Added.
612         * DumpRenderTree/chromium/WebViewHost.cpp: Added.
613         * DumpRenderTree/chromium/WebViewHost.h: Added.
614         * DumpRenderTree/chromium/config.h: Added.
615
616 2010-04-01  David Levin  <levin@chromium.org>
617
618         Reviewed by Adam Barth.
619
620         sheriffbot rollout should verify that the svn revision is a number.
621         https://bugs.webkit.org/show_bug.cgi?id=37001
622
623         * Scripts/webkitpy/common/net/bugzilla.py: Allow for the message to be None.
624         * Scripts/webkitpy/tool/bot/sheriff.py: Did verification that svn revision
625          is a number. Fixed the imports (since the files uses ScriptError and log)
626          and a typo.
627         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added a test to verify
628          the behavior.
629
630 2010-04-01  Adam Barth  <abarth@webkit.org>
631
632         Reviewed by Eric Seidel.
633
634         Print an error message for readline bogosity in MacPorts
635         https://bugs.webkit.org/show_bug.cgi?id=36979
636
637         * Scripts/webkitpy/common/system/user.py:
638
639 2010-04-01  Adam Barth  <abarth@webkit.org>
640
641         Reviewed by Eric Seidel.
642
643         Don't pass --non-interactive to create-rollout
644         https://bugs.webkit.org/show_bug.cgi?id=36989
645
646         It turns out you can't pass --non-interactive to create-rollout.  Also,
647         improve our error reporting slighly to catch the case where we error
648         out after creating the rollout bug.
649
650         * Scripts/webkitpy/tool/bot/irc_command.py:
651         * Scripts/webkitpy/tool/bot/sheriff.py:
652
653 2010-04-01  Ojan Vafai  <ojan@chromium.org>
654
655         Reviewed by Eric Seidel.
656
657         webkit-patch can incorrectly think the working directory is modified
658         https://bugs.webkit.org/show_bug.cgi?id=36985
659
660         If a file's modification time is modified, but the contents are not,
661         then diff-index will think the file has been modified unless you do
662         some crazy update-index call. Instead, call diff --name-only, which
663         has the index update builtin.
664
665         Tried to write a test, but could not reproduce this in a unittest.
666         To test manually:
667             touch file-in-repo
668             git diff-index HEAD
669             git diff HEAD --name-only
670
671         The diff-index call incorrectly shows file-in-repo as modified.
672
673         * Scripts/webkitpy/common/checkout/scm.py:
674
675 2010-04-01  Adam Barth  <abarth@webkit.org>
676
677         Reviewed by Eric Seidel.
678
679         Add rollout command to sheriffbot
680         https://bugs.webkit.org/show_bug.cgi?id=36986
681
682         This IRC command creates a new bug an attaches a rollout patch.  To
683         actually commit the rollout, a committer needs to mark the patch
684         commit-queue+ in bugs.webkit.org.
685
686         Also, factored out some of the logic from the queue into a separate
687         object for easier testing.
688
689         * Scripts/webkitpy/common/system/executive.py:
690         * Scripts/webkitpy/tool/bot/irc_command.py:
691         * Scripts/webkitpy/tool/bot/sheriff.py: Added.
692         * Scripts/webkitpy/tool/bot/sheriff_unittest.py: Added.
693         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
694         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
695         * Scripts/webkitpy/tool/commands/queues.py:
696         * Scripts/webkitpy/tool/commands/sheriffbot.py:
697         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
698
699 2010-04-01  Eric Seidel  <eric@webkit.org>
700
701         Unreviewed, only ignoring chatty style errors.
702
703         check-webkit-style: WebKit needs a python style checker
704         https://bugs.webkit.org/show_bug.cgi?id=33639
705
706         Remove the 79 char line limit by ignoring 
707         pep8/E501.  Because we have our own report_error
708         implementation we have to ignore E501 by hand
709         instead of passing --ignore=E501.
710
711         Right now over 1400 lines of our existing python
712         fail E501 so this rule just generates needless noise.
713         The rest of WebKit has no wrapping rule so it makes
714         little sense for our Python to differ here.
715
716         * Scripts/webkitpy/style/processors/python.py:
717
718 2010-04-01  Adam Barth  <abarth@webkit.org>
719
720         Unreviewed.  Add cmarrin's IRC nickname.
721
722         * Scripts/webkitpy/common/config/committers.py:
723
724 2010-04-01  Adam Barth  <abarth@webkit.org>
725
726         Unreviewed.
727
728         EWS spins hot when unable to build
729         https://bugs.webkit.org/show_bug.cgi?id=36981
730
731         The problem is that the queue engine things we have more work to do,
732         but the bot isn't actually able to do anything.  After this change, we
733         back off the usual amount.
734
735         * Scripts/webkitpy/tool/bot/queueengine.py:
736         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
737         * Scripts/webkitpy/tool/commands/queues.py:
738         * Scripts/webkitpy/tool/commands/sheriffbot.py:
739
740 2010-04-01  Chris Marrin  <cmarrin@apple.com>
741
742         Reviewed by Simon Fraser.
743
744         Added layerTreeAsText function to DRT (for Mac)
745         https://bugs.webkit.org/show_bug.cgi?id=36782
746
747         This is the DRT side. It exposes the call to JavaScript
748         through the LayoutTestController.
749
750         * DumpRenderTree/LayoutTestController.cpp:Platform independent JavaScript shim
751         (layerTreeAsTextCallback):
752         (LayoutTestController::staticFunctions):
753         * DumpRenderTree/LayoutTestController.h:
754         * DumpRenderTree/mac/LayoutTestControllerMac.mm:Mac specific plumbing to WebKit
755         (LayoutTestController::layerTreeAsText):
756         * DumpRenderTree/win/LayoutTestControllerWin.cpp:Windows specific plumbing to WebKit
757         (LayoutTestController::layerTreeAsText):
758
759 2010-04-01  Kevin Ollivier  <kevino@theolliviers.com>
760
761         [wx] Build fix after addition of JavaScriptCore/wtf/text directory.
762
763         * wx/build/settings.py:
764
765 2010-04-01  Jian Li  <jianli@chromium.org>
766
767         Rubber-stamped by David Levin.
768
769         Add myself to the reviewers list.
770
771         * Scripts/webkitpy/common/config/committers.py:
772
773 2010-04-01  Adam Barth  <abarth@webkit.org>
774
775         Unreviewed.
776
777         Turns out the Chromium Windows bots don't have pdevenv installed.
778
779         * Scripts/webkitdirs.pm:
780
781 2010-04-01  Adam Barth  <abarth@webkit.org>
782
783         Reviewed by Dimitri Glazkov.
784
785         Let Chromium Windows build with Visual Studio Express
786         https://bugs.webkit.org/show_bug.cgi?id=36919
787
788         This is horrible, horrible copy/paste code, but that seems to be the
789         way of webkitdirs.pm.  :(
790
791         Someone needs to go through an cleanup this code, but I don't have the
792         heart to do it in this patch.
793
794         * Scripts/webkitdirs.pm:
795
796 2010-04-01  Ilya Tikhonovsky  <loislo@chromium.org>
797
798         Reviewed by Yury Semikhatsky.
799
800         Add myself to the committers list.
801         https://bugs.webkit.org/show_bug.cgi?id=36953
802
803         * Scripts/webkitpy/common/config/committers.py:
804
805 2010-04-01  Eric Seidel  <eric@webkit.org>
806
807         Rubber-stamped by Adam Barth.
808
809         Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red)
810         https://bugs.webkit.org/show_bug.cgi?id=33292
811
812         Just adding the "Build" builder for now.
813         We'll add the "Test" builders when the tests
814         are less flaky.
815
816         * Scripts/webkitpy/common/net/buildbot.py:
817         * Scripts/webkitpy/common/net/buildbot_unittest.py:
818
819 2010-04-01  Yury Semikhatsky  <yurys@chromium.org>
820
821         Reviewed by David Levin.
822
823         Add myself to the reviewers list.
824
825         https://bugs.webkit.org/show_bug.cgi?id=36935
826
827         * Scripts/webkitpy/common/config/committers.py:
828
829 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
830
831         Reviewed by Dave Levin.
832
833         Added Python style checking to check-webkit-style using
834         the third-party pep8 module (via autoinstall).
835
836         https://bugs.webkit.org/show_bug.cgi?id=33639
837
838         * Scripts/webkitpy/style/checker.py:
839           - Added PYTHON to FileType.
840           - Updated ProcessorDispatcher to return a PythonProcessor
841             for *.py files.
842
843         * Scripts/webkitpy/style/checker_unittest.py:
844           - Updated the ProcessorDispatcher unit tests for *.py files.
845
846         * Scripts/webkitpy/style/processors/python.py: Added.
847           - Added PythonProcessor class.
848
849         * Scripts/webkitpy/style/processors/python_unittest.py: Added.
850           - Added PythonProcessor unit tests.
851
852         * Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
853           - Added a sample Python file to test the PythonProcessor.process()
854             code path (since pep8 accepts a file path).
855
856         * Scripts/webkitpy/style/unittests.py:
857           - Updated the style unit test file to import python_unittest.py.
858
859         * Scripts/webkitpy/style_references.py:
860           - Adjusted style references to import pep8.
861
862 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
863
864         Reviewed by Dave Levin.
865
866         Rewrote autoinstall.py to support unzipping *.zip files after
867         download, unzipping and extracting *.tar.gz files after download,
868         and copying installed files to a given destination directory.
869
870         https://bugs.webkit.org/show_bug.cgi?id=35163
871
872         These changes will let us autoinstall pep8.py from the web and put
873         our third-party autoinstalled code in an explicit directory like
874         webkitpy/thirdparty/autoinstalled. These changes should also speed
875         up the execution of autoinstalled *.zip packages slightly since
876         *.pyc files cannot be generated when importing from zipped
877         packages using the current autoinstall.
878
879         * Scripts/test-webkitpy:
880           - Addressed the FIXME to enable auto-install logging once
881             autoinstall was rewritten not to log as verbosely.
882
883         * Scripts/webkitpy/common/net/bugzilla.py:
884           - Updated mechanize import statement.
885
886         * Scripts/webkitpy/common/net/buildbot.py:
887           - Updated mechanize import statement.
888
889         * Scripts/webkitpy/common/net/irc/ircbot.py:
890           - Updated ircbot and irclib import statements.
891
892         * Scripts/webkitpy/common/net/networktransaction.py:
893           - Updated mechanize import statement.
894
895         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
896           - Updated mechanize import statement.
897
898         * Scripts/webkitpy/common/net/statusserver.py:
899           - Updated mechanize import statement.
900
901         * Scripts/webkitpy/common/system/autoinstall.py: Added.
902           - Added AutoInstaller class.
903           - Added sample/testing usage to the __main__ block.
904
905         * Scripts/webkitpy/thirdparty/__init__.py:
906           - Updated the autoinstall lines to use the new autoinstall methods.
907           - Added pep8.py to the list of auto-installed packages.
908           - Added a README file to the target autoinstallation directory
909             so users know that the directory is safe to delete.
910
911         * Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
912           - This is replaced by the rewritten autoinstall
913             webkitpy/common/system/autoinstall.py.
914
915         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Removed.
916           - The target autoinstallation directory is now auto-generated.
917
918 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
919
920         Reviewed by Shinichiro Hamaji.
921
922         Tweak webkitpy's logtesting.LogTesting class to get more mileage out
923         of our unit tests that test log messages.
924
925         https://bugs.webkit.org/show_bug.cgi?id=36886
926
927         This patch adds to the LogTesting class's tearDown() method a line
928         asserting that the array of remaining log messages is empty.  This
929         ensures that no extra log messages are getting logged that the caller
930         might not be aware of or may have forgotten to check for.
931
932         * Scripts/webkitpy/common/system/logtesting.py:
933           - Modified the tearDown() method as described above.
934           - Also modified the assertMessages() method to clear the array
935             of log messages after asserting.
936
937 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
938
939         Reviewed by Adam Barth.
940
941         Added support for a --verbose-logging flag to test-webkitpy.
942
943         https://bugs.webkit.org/show_bug.cgi?id=36429
944
945         Verbose logging is useful for debugging test-webkitpy code that
946         runs before the actual unit tests -- things like autoinstalling and
947         unit-test auto-detection logic.  This is different from verbose
948         logging of the unit tests themselves (which corresponds to the
949         unittest module's --verbose flag).
950
951         * Scripts/test-webkitpy:
952           - In the configure_logging() method--
953             - Added an is_verbose_logging parameter that sets the logging
954               level to logging.DEBUG instead of logging.INFO.
955             - Changed the method to throttle the logging level on the
956               root logger's handler instead of directly on the root logger
957               itself.
958             - Enabled logging of the autoinstall module when the flag is set.
959
960         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
961           - Added a work-around for a bug in Python 2.6's logging module
962             that was discovered while working on this patch.
963
964 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
965
966         Reviewed by Adam Barth.
967
968         Enabled Python's logging module for webkit-patch, and replaced
969         deprecated_logging with Python logging in networktransaction.py.
970         This eliminates some spurious output when running test-webkitpy.
971
972         https://bugs.webkit.org/show_bug.cgi?id=36725
973
974         * Scripts/webkit-patch:
975           - Replaced the configure_logging() function with a call to
976             the new logutils.configure_logging() function.
977
978         * Scripts/webkitpy/common/net/networktransaction.py:
979           - Replaced the use of deprecated_logging with Python logging.
980
981         * Scripts/webkitpy/common/system/logutils.py:
982           - Added _default_handlers() which creates the default logging
983             handler for webkitpy.
984           - Added configure_logging() which configures default logging
985             for webkitpy.
986
987         * Scripts/webkitpy/common/system/logutils_unittest.py:
988           - Added unit tests for logutils.configure_logging().
989
990         * Scripts/webkitpy/style/checker.py:
991           - Refactored check-webkit-style's configure_logging() method
992             to call the new logutils.configure_logging().
993
994         * Scripts/webkitpy/style_references.py:
995           - Updated references as necessary.
996
997 2010-03-31  Eric Seidel  <eric@webkit.org>
998
999         Reviewed by Adam Barth.
1000
1001         webkit-patch land fails if not run from the root directory
1002         https://bugs.webkit.org/show_bug.cgi?id=35822
1003
1004         The root of the problem was that ChangeLog.__init__ expects a path
1005         relative to the current working directory, and SCM expects to
1006         return paths relative to the SCM root.  Fix it by converting from
1007         SCM-relative to absolute paths in Checkout.modified_changelogs
1008
1009         * Scripts/webkitpy/common/checkout/api.py:
1010         * Scripts/webkitpy/common/checkout/api_unittest.py:
1011
1012 2010-03-31  Adam Barth  <abarth@webkit.org>
1013
1014         Reviewed by Eric Seidel.
1015
1016         Add more tests for webkitpy.common.checkout
1017         https://bugs.webkit.org/show_bug.cgi?id=36926
1018
1019         We don't have a great way of testing checkout, sadly.
1020
1021         * Scripts/webkitpy/common/checkout/api_unittest.py:
1022
1023 2010-03-31  Adam Barth  <abarth@webkit.org>
1024
1025         Reviewed by Eric Seidel.
1026
1027         REGRESSION: EWS crashes on failure
1028         https://bugs.webkit.org/show_bug.cgi?id=36924
1029
1030         Turns out we need to pass one more argument.  My test is kind of lame,
1031         but at least it's there.
1032
1033         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1034         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1035
1036 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
1037
1038         Unreviewed.
1039
1040         Fixed typo in WebKitTools/ChangeLog: opsys -> ospath.
1041
1042 2010-03-31  Adam Barth  <abarth@webkit.org>
1043
1044         Reviewed by Eric Seidel.
1045
1046         Make the EWS go faster by being optimistic
1047         https://bugs.webkit.org/show_bug.cgi?id=36916
1048
1049         Have the EWS be optimistic that a patch will correctly build.  This
1050         should speed up the common case by not requiring two builds for every
1051         patch.
1052
1053         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1054         * Scripts/webkitpy/tool/commands/queues.py:
1055
1056 2010-03-31  Adam Barth  <abarth@webkit.org>
1057
1058         Reviewed by Eric Seidel.
1059
1060         Add the ability to restart sheriffbot from IRC
1061         https://bugs.webkit.org/show_bug.cgi?id=36909
1062
1063         * Scripts/webkitpy/tool/bot/irc_command.py:
1064         * Scripts/webkitpy/tool/bot/queueengine.py:
1065         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1066         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1067
1068 2010-03-31  Adam Barth  <abarth@webkit.org>
1069
1070         Reviewed by Eric Seidel.
1071
1072         Add win-ews to QueueStatusServer
1073         https://bugs.webkit.org/show_bug.cgi?id=36876
1074
1075         The win-ews is still experimental, but it seems to be more or less
1076         running.  We should show its results to the people.
1077
1078         * QueueStatusServer/model/queues.py:
1079         * QueueStatusServer/templates/dashboard.html:
1080         * QueueStatusServer/templates/statusbubble.html:
1081
1082 2010-03-30  Victor Wang  <victorw@chromium.org>
1083
1084         Reviewed by Eric Seidel.
1085
1086         Update rebaseline tool to check the release image diff binary and
1087         fallback to debug if the release version does not exist.
1088
1089         https://bugs.webkit.org/show_bug.cgi?id=36245
1090
1091         * Scripts/webkitpy/layout_tests/port/base.py:
1092         * Scripts/webkitpy/layout_tests/port/chromium.py:
1093         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1094
1095 2010-03-31  Eric Seidel  <eric@webkit.org>
1096
1097         Reviewed by Adam Barth.
1098
1099         Teach buildbot.py how to parse builder activity from /one_box_per_builder
1100         https://bugs.webkit.org/show_bug.cgi?id=36898
1101
1102         I also removed some obsolete FIXMEs and
1103         refactored one_box_per_builder parsing into multiple
1104         methods for easier reading.
1105
1106         * Scripts/webkitpy/common/net/buildbot.py:
1107         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1108
1109 2010-03-31  Dirk Pranke  <dpranke@chromium.org>
1110
1111         Reviewed by Eric Seidel.
1112
1113         Fix logging in new-run-webkit-tests so that we don't report IMAGE
1114         expected failures as unexpected passes when we run with pixel tests
1115         disabled.
1116
1117         This change splits some of the logic embedded into the TestExpectations
1118         classes out into separate pure functions (result_was_expected,
1119         remove_image_failures) to make them easier to test. This also adds
1120         a parameter to matches_an_expected_result() to indicate whether or
1121         not pixel test results should be included in the expectations.
1122
1123         https://bugs.webkit.org/show_bug.cgi?id=36771
1124
1125         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1126         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
1127         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1128
1129 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
1130
1131         Reviewed by Eric Seidel.
1132
1133         In webkitpy, refactored two calls to os.path.relpath() replacements
1134         to use a common method.
1135
1136         https://bugs.webkit.org/show_bug.cgi?id=36891
1137
1138         * Scripts/webkitpy/common/net/bugzilla.py:
1139           - Replaced the relpath implementation with a call to
1140             webkitpy.common.system.ospath.relpath().
1141
1142         * Scripts/webkitpy/common/system/ospath.py: Added.
1143           - Moved the relpath() implementation from style/main.py.
1144
1145         * Scripts/webkitpy/common/system/ospath_unittest.py: Added.
1146           - Moved the relpath() unit tests from style/main_unittest.py.
1147
1148         * Scripts/webkitpy/style/main.py:
1149           - Replaced the relpath implementation with a call to
1150             webkitpy.common.system.ospath.relpath().
1151
1152         * Scripts/webkitpy/style/main_unittest.py:
1153           - Moved the relpath unit tests to ospath_unittest.py.
1154
1155 2010-03-31  Adam Barth  <abarth@webkit.org>
1156
1157         Reviewed by Eric Seidel.
1158
1159         Add a Builder.force_build method
1160         https://bugs.webkit.org/show_bug.cgi?id=36875
1161
1162         We plan to eventually use this in SheriffBot to break deadlocks created
1163         by flaky tests.
1164
1165         * Scripts/webkitpy/common/net/buildbot.py:
1166
1167 2010-03-31  Adam Barth  <abarth@webkit.org>
1168
1169         Reviewed by Eric Seidel.
1170
1171         webkit-patch reads wrong bug url from unified diff context
1172         https://bugs.webkit.org/show_bug.cgi?id=36477
1173
1174         Instead of trying to figure out the bug_id from the diff, we should
1175         just get the information from the Checkout object, which understands
1176         these concepts.
1177
1178         * Scripts/webkitpy/common/checkout/api.py:
1179         * Scripts/webkitpy/common/checkout/commitinfo.py:
1180         * Scripts/webkitpy/tool/commands/download.py:
1181         * Scripts/webkitpy/tool/commands/upload.py:
1182         * Scripts/webkitpy/tool/mocktool.py:
1183
1184 2010-03-31  Adam Barth  <abarth@webkit.org>
1185
1186         Reviewed by Eric Seidel.
1187
1188         webkit-patch commit-queue should land patches optimistically
1189         https://bugs.webkit.org/show_bug.cgi?id=34187
1190
1191         This patch adds an optimistic path to commit-queue and a "fail twice"
1192         requirement for rejecting patches.  That means we'll land good patches
1193         faster (via the optmistic first run) and we'll reject many fewer
1194         patches due to flaky tests.
1195
1196         * Scripts/webkitpy/tool/commands/queues.py:
1197
1198 2010-03-31  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1199
1200         Reviewed by Kenneth Rohde Christiansen.
1201
1202         [Qt] Custom user agent for user agent switcher
1203         https://bugs.webkit.org/show_bug.cgi?id=36757
1204
1205         * QtLauncher/main.cpp:
1206         (LauncherWindow::showUserAgentDialog):
1207
1208 2010-03-31  Eric Seidel  <eric@webkit.org>
1209
1210         Reviewed by Adam Barth.
1211
1212         path to committers.py in commit-queue rejection message is wrong
1213         https://bugs.webkit.org/show_bug.cgi?id=36865
1214
1215         This fix would have only been 3 lines long if we had
1216         1. Had access to an SCM object or tool to give us the checkout root
1217         2. Been able to depend on Python 2.6
1218         Instead I've added a bunch of hack code, but at least now
1219         we should never have to update this string again as the location
1220         of committers.py is fully dynamically discovered. :p
1221
1222         * Scripts/webkitpy/common/net/bugzilla.py:
1223         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1224
1225 2010-03-31  Shinichiro Hamaji  <hamaji@chromium.org>
1226
1227         Unreviewed test fix for r56809.
1228
1229         webkit-patch what-broke throws exception
1230         https://bugs.webkit.org/show_bug.cgi?id=36852
1231
1232         * Scripts/webkitpy/common/checkout/api_unittest.py:
1233
1234 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
1235
1236         Rubber stamped by Dave Levin.
1237
1238         Made check-webkit-style less chatty.
1239
1240         Examples include:
1241          - https://bugs.webkit.org/show_bug.cgi?id=36866#c4
1242          - https://bugs.webkit.org/show_bug.cgi?id=36472#c9
1243
1244         * Scripts/webkitpy/style/checker.py:
1245           - Changed unrecognized file type log message from info to debug.
1246
1247 2010-03-30  Kevin Ollivier  <kevino@theolliviers.com>
1248
1249         [wx] Build fix after new method added.
1250
1251         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1252         (LayoutTestController::callShouldCloseOnWebView):
1253
1254 2010-03-30  Eric Seidel  <eric@webkit.org>
1255
1256         Reviewed by Adam Barth.
1257
1258         webkit-patch what-broke throws exception
1259         https://bugs.webkit.org/show_bug.cgi?id=36852
1260
1261         * Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO.
1262         * Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception.
1263
1264 2010-03-30  Alexey Proskuryakov  <ap@apple.com>
1265
1266         Reviewed by Darin Adler.
1267
1268         https://bugs.webkit.org/show_bug.cgi?id=36616
1269         Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown
1270
1271         https://bugs.webkit.org/show_bug.cgi?id=36797
1272         For non-Roman layouts, keydown Event.keyCode is always 0
1273
1274         * DumpRenderTree/mac/EventSendingController.mm:
1275         (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode
1276         for keys used in tests (we used to always pass 0 for 'A').
1277
1278 2010-03-30  Adam Barth  <abarth@webkit.org>
1279
1280         Reviewed by Eric Seidel.
1281
1282         Implement win-ews
1283         https://bugs.webkit.org/show_bug.cgi?id=36809
1284
1285         * Scripts/webkitpy/common/config/ports.py:
1286         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1287
1288 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
1289
1290         Reviewed by Eric Seidel.
1291
1292         Adjusted test-webkitpy to delete all orphaned *.pyc files
1293         from webkitpy/ prior to importing any modules from webkitpy.
1294         This ensures that no import statements in webkitpy falsely
1295         succeed because of leftover *.pyc files.
1296
1297         https://bugs.webkit.org/show_bug.cgi?id=36599
1298
1299         * Scripts/test-webkitpy:
1300           - Added _clean_pyc_files() to delete orphaned *.pyc files
1301             from a directory.
1302           - Added _clean_webkitpy_with_test() to call and test
1303             _clean_pyc_files().
1304           - Moved the "import webkitpy.python24.versioning" statement
1305             from the top of the module to the init() method -- immediately
1306             after the call to _clean_webkitpy_with_test().
1307
1308 2010-03-30  Fumitoshi Ukai  <ukai@chromium.org>
1309
1310         Reviewed by Shinichiro Hamaji.
1311
1312         [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
1313         https://bugs.webkit.org/show_bug.cgi?id=36811
1314
1315         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
1316         We don't need stdin, so use devnull as stdin.
1317         Same as https://bugs.webkit.org/show_bug.cgi?id=36586
1318
1319         * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
1320
1321 2010-03-29  Eric Seidel  <eric@webkit.org>
1322
1323         Unreviewed, build fix only.
1324
1325         * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
1326
1327 2010-03-29  Hayato Ito  <hayato@chromium.org>
1328
1329         Reviewed by Shinichiro Hamaji.
1330
1331         Remove '_flymake' suffix from base part of file name so that
1332         check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.
1333
1334         https://bugs.webkit.org/show_bug.cgi?id=36573
1335
1336         * Scripts/webkitpy/style/processors/cpp.py:
1337         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1338
1339 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
1340
1341         Reviewed by Eric Seidel.
1342
1343         Get the following test-webkitpy unit test working again:
1344         scm_unittest.SVNTest.test_svn_apply().
1345
1346         https://bugs.webkit.org/show_bug.cgi?id=36696
1347
1348         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1349           - Add leading spaces to the empty lines of the ChangeLog strings.
1350           - Manually set the _reviewer attribute on the Attachment object
1351             to get the tests to pass.
1352
1353 2010-03-29  Martin Robinson  <mrobinson@webkit.org>
1354
1355         Reviewed by Holger Freyther.
1356
1357         [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
1358         https://bugs.webkit.org/show_bug.cgi?id=36390
1359
1360         Suppress debugging messages sent to the GLib logger during DRT runs.
1361
1362         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1363         (logHandler): Added.
1364         (main): Use logHandler as the default GLib log message handler.
1365
1366 2010-03-29  Eric Seidel  <eric@webkit.org>
1367
1368         Reviewed by Adam Barth.
1369
1370         sheriff-bot should comment on bugs when builders break
1371         https://bugs.webkit.org/show_bug.cgi?id=36786
1372
1373         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1374          - Add a new _post_blame_comment_to_bug and all it from process_work_item
1375          - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
1376         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1377          - Test the new _post_blame_comment_to_bug call
1378
1379 2010-03-29  Eric Seidel  <eric@webkit.org>
1380
1381         Reviewed by Adam Barth.
1382
1383         sheriff-bot fails to get information about certain builds
1384         https://bugs.webkit.org/show_bug.cgi?id=36768
1385
1386         This seems to be caused by:
1387         http://buildbot.net/trac/ticket/753
1388         I have no work-around, but for now at least we're logging
1389         the error better.  I also added allow_none to our ServerProxy
1390         creation in case that fixes things for other versions of python.
1391
1392         * Scripts/webkitpy/common/net/buildbot.py:
1393
1394 2010-03-29  Victor Wang  <victorw@chromium.org>
1395
1396         Reviewed by Adam Barth.
1397
1398         Add sign in/out link to TestResults appengine
1399
1400         Add a link to main menu for sign in/out to this appengine.
1401         People signed in with admin privilege could perform
1402         actions that are only allowed to admins like deleting files.
1403
1404         https://bugs.webkit.org/show_bug.cgi?id=36767
1405
1406         * TestResultServer/handlers/menu.py:
1407         * TestResultServer/stylesheets/menu.css:
1408         (.sign):
1409         * TestResultServer/templates/menu.html:
1410
1411 2010-03-29  Eric Seidel  <eric@webkit.org>
1412
1413         Reviewed by Adam Barth.
1414
1415         ValidateReviewer step is draconian and un-tested
1416         https://bugs.webkit.org/show_bug.cgi?id=36792
1417
1418         ValidateReviewer logic was commented out in
1419         http://trac.webkit.org/changeset/56744
1420         That was a symptom of the fact that validatereviewer.py
1421         is too inflexible to be used when real humans are driving webkit-patch.
1422         For now we just disable ValidateReviewer when humans are at the keyboard.
1423
1424         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1425          - Only run when in non-interactive mode.
1426         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
1427          - Test our validation logic to make sure it's sane.
1428
1429 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
1430
1431         Reviewed by Shinichiro Hamaji.
1432
1433         Eliminate explicit slash characters from check-webkit-style's
1434         _rel_path() method to make its implementation more platform
1435         independent.
1436
1437         https://bugs.webkit.org/show_bug.cgi?id=36759
1438
1439         * Scripts/webkitpy/style/main.py:
1440           - Changed to use os.sep instead of slash_chars "/\\".  This can
1441             be done since os.path.abspath() converts slashes to os.sep.
1442
1443 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
1444
1445         Reviewed by Dimitri Glazkov.
1446
1447         Change new-run-webkit-tests to not use more than four threads by
1448         default on the mac port until
1449         https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.
1450
1451         https://bugs.webkit.org/show_bug.cgi?id=36687
1452
1453         * Scripts/webkitpy/layout_tests/port/mac.py:
1454
1455 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
1456
1457         Reviewed by Dimitri Glazkov.
1458
1459         Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.
1460
1461         https://bugs.webkit.org/show_bug.cgi?id=36691
1462
1463         * Scripts/webkitpy/layout_tests/port/mac.py:
1464
1465 2010-03-29  Eric Seidel  <eric@webkit.org>
1466
1467         Reviewed by Adam Barth.
1468
1469         new-run-webkit-tests fails java/lc3 on a clean checkout
1470         https://bugs.webkit.org/show_bug.cgi?id=36078
1471
1472         * Scripts/webkitpy/layout_tests/port/mac.py:
1473          - Build the java support files in check_build
1474          - Unwrap a line which would still fit under 80col
1475
1476 2010-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1477
1478         Reviewed by Simon Fraser.
1479
1480         Add support for Widgets 1.0: View Mode Media Feature
1481         https://bugs.webkit.org/show_bug.cgi?id=35446
1482
1483         Add hooks to the Qt DRT for testing the view mode media feature.
1484
1485         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1486         (LayoutTestController::setViewModeMediaFeature):
1487         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1488
1489 2010-03-29  Adam Barth  <abarth@webkit.org>
1490
1491         Unreviewed.  Update expected results for unit tests.
1492
1493         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1494         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1495
1496 2010-03-29  Adam Barth  <abarth@webkit.org>
1497
1498         Unreviewed.  I think Eric meant svn_revision.
1499
1500         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1501
1502 2010-03-26  Eric Seidel  <eric@webkit.org>
1503
1504         Reviewed by Adam Barth.
1505
1506         webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
1507         https://bugs.webkit.org/show_bug.cgi?id=29311
1508
1509         Now that we have sheriff-bot watching the tree, it can post
1510         rollout patches on behalf of the commit queue.
1511
1512         * Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
1513         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
1514         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1515          - Break IRC logic out into _post_irc_warning for easier testing.
1516          - Add _post_rollout_patch for posting rollout patches to bugzilla.
1517         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1518          - Test _rollout_reason
1519         * Scripts/webkitpy/tool/grammar.py:
1520          - Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
1521         * Scripts/webkitpy/tool/grammar_unittest.py:
1522          - Test join_with_separators
1523
1524 2010-03-29  Adam Barth  <abarth@webkit.org>
1525
1526         Reviewed by Eric Seidel.
1527
1528         Sheriffbot should actually run commands
1529         https://bugs.webkit.org/show_bug.cgi?id=36776
1530
1531         Some minor changes to Sheriffbot:
1532
1533         1) We should actually run commands (by giving control back to the
1534         command processing object.
1535
1536         2) Use URLs instead of just numbers to represent SVN revisions (making
1537         it easier to folks in IRC ot followup).
1538
1539         * Scripts/webkitpy/tool/bot/irc_command.py:
1540         * Scripts/webkitpy/tool/bot/queueengine.py:
1541         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1542
1543 2010-03-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1544
1545         Reviewed by Antti Koivisto.
1546
1547         Renaming of frame flattening LayoutTestController method
1548         to setFrameFlatteningEnabled(bool)
1549
1550         * DumpRenderTree/LayoutTestController.cpp:
1551         (setFrameFlatteningEnabledCallback):
1552         (LayoutTestController::staticFunctions):
1553         * DumpRenderTree/LayoutTestController.h:
1554         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1555         (LayoutTestController::setFrameFlatteningEnabled):
1556         * DumpRenderTree/mac/DumpRenderTree.mm:
1557         (resetDefaultsToConsistentValues):
1558         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1559         (LayoutTestController::setFrameFlatteningEnabled):
1560         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1561         (WebCore::WebPage::resetSettings):
1562         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1563         (LayoutTestController::setFrameFlatteningEnabled):
1564         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1565         * DumpRenderTree/win/DumpRenderTree.cpp:
1566         (resetDefaultsToConsistentValues):
1567         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1568         (LayoutTestController::setFrameFlatteningEnabled):
1569         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1570         (LayoutTestController::setFrameFlatteningEnabled):
1571
1572 2010-03-28  Gustavo Noronha Silva  <gns@gnome.org>
1573
1574         No review, rolling out r56679.
1575         http://trac.webkit.org/changeset/56679
1576         https://bugs.webkit.org/show_bug.cgi?id=36454
1577
1578         Lots of tests broken.
1579
1580         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1581         (createWebView):
1582
1583 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1584
1585         Unreviewed.
1586
1587         Fixed typo in deprecated_logging_unittest.py, which is masking
1588         sys.stderr while running test-webkitpy.
1589
1590         See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3
1591
1592         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
1593
1594 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1595
1596         Reviewed by Shinichiro Hamaji.
1597
1598         Renamed check-webkit-style's --debug flag to --verbose to be more
1599         in line with other WebKit scripts.  Also renamed the current
1600         --verbose flag to --min-confidence to allow the --debug rename.
1601
1602         https://bugs.webkit.org/show_bug.cgi?id=36521
1603
1604         We also renamed the internal "verbose" variables to "confidence" or
1605         "min_confidence," as appropriate, to avoid confusion with the
1606         --verbose flag, and because the new names are more accurate.
1607
1608         * Scripts/check-webkit-style:
1609           - Renamed is_debug to is_verbose.
1610
1611         * Scripts/webkitpy/style/checker.py:
1612           - Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE.
1613           - Renamed "verbosity" parameters to "min_confidence" throughout.
1614           - Renamed configure_logging()'s is_debug parameter to is_verbose.
1615
1616         * Scripts/webkitpy/style/checker_unittest.py:
1617           - Updated the unit tests as necessary.
1618
1619         * Scripts/webkitpy/style/error_handlers.py:
1620           - Updated the call to StyleCheckerConfiguration.write_style_error().
1621
1622         * Scripts/webkitpy/style/error_handlers_unittest.py:
1623           - Updated the unit tests as necessary.
1624
1625         * Scripts/webkitpy/style/optparser.py:
1626           - Updated the usage string with the new flag names.
1627           - Renamed the verbosity parameter to min_confidence throughout.
1628           - Renamed the is_debug parameter to is_verbose throughout.
1629
1630         * Scripts/webkitpy/style/optparser_unittest.py:
1631           - Updated the unit tests as necessary.
1632
1633         * Scripts/webkitpy/style/processors/cpp.py:
1634           - Renamed the verbosity parameter to min_confidence throughout.
1635
1636         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1637           - Updated the unit tests as necessary.
1638
1639 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1640
1641         Unreviewed.
1642
1643         Added back a line that accidentally got deleted in r56690.
1644
1645         * Scripts/check-webkit-style:
1646
1647 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1648
1649         Reviewed by Shinichiro Hamaji.
1650
1651         Add to check-webkit-style support for checking directories.
1652
1653         https://bugs.webkit.org/show_bug.cgi?id=35234
1654
1655         * Scripts/check-webkit-style:
1656           - Replaced the call to check_file() with a call to check_paths().
1657
1658         * Scripts/webkitpy/style/checker.py:
1659           - In the StyleChecker class:
1660             - Added a check_paths() method that accepts a list of paths
1661               to files and directories.
1662             - Added a _check_directory() method that checks the files
1663               in a directory.
1664
1665         * Scripts/webkitpy/style/checker_unittest.py:
1666           - Added a StyleCheckerCheckPathsTest to unit-test the new
1667             check_paths() method.
1668
1669         * Scripts/webkitpy/style/optparser.py:
1670           - Updated the usage string.
1671
1672 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
1673
1674         Reviewed by Shinichiro Hamaji.
1675
1676         Changed check-webkit-style to convert paths to paths relative to
1677         the checkout root when invoking check-webkit-style with path
1678         arguments.  Also added warning messages where appropriate.
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=35498
1681
1682         Converting paths to paths relative to the checkout root ensures
1683         that style checking will behave as expected (since path-specific
1684         rules assume input paths are relative to a source root).
1685
1686         * Scripts/check-webkit-style:
1687           - Added debug logging of whether the current directory was found
1688             to be in a WebKit checkout.
1689           - Added the found_checkout parameter to the call to parser.parse().
1690           - Renamed the files variable to paths.
1691           - Added a call to change_directory() prior to checking style.
1692
1693         * Scripts/webkitpy/style/checker.py:
1694           - For StyleChecker.check_file():
1695             - Updated the docstring.
1696             - Added two log messages.
1697
1698         * Scripts/webkitpy/style/checker_unittest.py:
1699           - Updated a call to parser.parse() with the found_checkout parameter.
1700
1701         * Scripts/webkitpy/style/main.py: Added.
1702           - Added a new file so the code in this patch could be unit-tested,
1703             as opposed to adding new code to check-webkit-style.
1704           - Added the method _rel_path() as a substitute for os.path.relpath(),
1705             which is available only in Python 2.6.
1706           - Added the method change_directory(), which contains most of the
1707             new functionality in this patch.
1708
1709         * Scripts/webkitpy/style/main_unittest.py: Added.
1710           - Added RelPathTest to test main._rel_path().
1711           - Added ChangeDirectoryTest to test main.change_directory().
1712
1713         * Scripts/webkitpy/style/optparser.py:
1714           - Updated check-webkit-style's usage string.
1715           - For the ArgumentParser.parse() method:
1716             - Added a found_checkout parameter.
1717             - Renamed filenames to paths.
1718             - Added logic so that an error is raised if no paths are passed
1719               if found_checkout is False.
1720
1721         * Scripts/webkitpy/style/optparser_unittest.py:
1722           - Updated the ArgumentParser.parse() unit tests to include
1723             coverage for the new found_checkout parameter.
1724
1725         * Scripts/webkitpy/style/unittests.py:
1726           - Added an import statement for main_unittest.
1727
1728         * Scripts/webkitpy/style_references.py:
1729           - Renamed SimpleScm to WebKitCheckout.
1730           - Added a detect_checkout() function to allow returning None
1731             instead of a WebKitCheckout instance if no checkout is found.
1732           - Renamed checkout_root to root_path.
1733
1734 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1735
1736         Reviewed by Eric Seidel.
1737
1738         Print didHandleOnloadEventsForFrame in the callback of
1739         onload-event signal comming from frame loader
1740
1741         [GTK] Improve reporting of frame loader callbacks in DRT
1742         https://bugs.webkit.org/show_bug.cgi?id=36454
1743
1744         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1745         (webViewOnloadEvent):
1746         (createWebView): added connection to signal::onload-event and
1747         signal callback
1748
1749 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1750
1751         Reviewed by Eric Seidel.
1752
1753         Print didCommitLoadForFrame in the callback of signal::load-committed
1754
1755         [GTK] Improve reporting of frame loader callbacks in DRT
1756         https://bugs.webkit.org/show_bug.cgi?id=36454
1757
1758         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1759         (webViewLoadCommitted):
1760         (createWebView): added connection to sinal::load-committed and
1761         signal callback
1762
1763 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1764
1765         Reviewed by Eric Seidel.
1766
1767         Print didStartProvisionalLoadForFrame in the callback of
1768         notify::load-status property change notification
1769
1770         [GTK] Improve reporting of frame loader callbacks in DRT
1771         https://bugs.webkit.org/show_bug.cgi?id=36454
1772
1773         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1774         (webInspectorCloseWindow):
1775         (webInspectorInspectWebView):
1776         (createWebView): added connection to notify::load-status and
1777         signal callback
1778
1779 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
1780
1781         Reviewed by Adam Barth.
1782
1783         In webkitpy/, deleted the /unittests.py files since test-webkitpy
1784         now auto-detects all *_unittest.py files.
1785
1786         https://bugs.webkit.org/show_bug.cgi?id=36712
1787
1788         * Scripts/webkitpy/common/net/irc/unittests.py: Removed.
1789         * Scripts/webkitpy/common/system/unittests.py: Removed.
1790         * Scripts/webkitpy/common/thread/unittests.py: Removed.
1791         * Scripts/webkitpy/common/unittests.py: Removed.
1792         * Scripts/webkitpy/python24/unittests.py: Removed.
1793         * Scripts/webkitpy/style/unittests.py: Removed.
1794         * Scripts/webkitpy/tool/unittests.py: Removed.
1795         * Scripts/webkitpy/unittests.py: Removed.
1796
1797 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1798
1799         Reviewed by Eric Seidel.
1800
1801         Add a CR after printing didFinishDocumentLoadForFrame
1802
1803         [GTK] Improve reporting of frame loader callbacks in DRT
1804         https://bugs.webkit.org/show_bug.cgi?id=36454
1805
1806         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1807         (webViewLoadFinished):
1808
1809 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
1810
1811         Rubber-stamped by Adam Barth.
1812
1813         Fixed the name of a unit test file in webkitpy.
1814
1815         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
1816         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.
1817
1818 2010-03-26  Chris Jerdonek  <cjerdonek@webkit.org>
1819
1820         Reviewed by Adam Barth.
1821
1822         The test-webkitpy script now automatically detects all unit-test
1823         files in webkitpy/.  This lets us eliminate the need to have and
1824         maintain all of the unittests.py files.
1825
1826         https://bugs.webkit.org/show_bug.cgi?id=36591
1827
1828         * Scripts/test-webkitpy:
1829           - Replaced the "from webkitpy.unittests import *" with a call
1830             to webkitpy.test.main.Tester().run_tests().
1831
1832         * Scripts/webkitpy/test/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1833           - Required file for the new webkitpy/test/ directory.
1834
1835         * Scripts/webkitpy/test/main.py: Added.
1836           - Added a Tester class that contains the following methods:
1837             - _find_unittest_files() to detect all the unit-test files.
1838             - _modules_from_paths() to convert the paths to the unit-test
1839               files to fully-qualified module names.
1840             - run_tests() which calls the above two methods and then passes
1841               the module names to Python's unittest module.
1842
1843 2010-03-27  Robert Hogan  <robert@webkit.org>
1844
1845         Reviewed by Simon Fraser.
1846
1847         [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.
1848
1849         https://bugs.webkit.org/show_bug.cgi?id=36701
1850
1851         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1852         (webkit_test_plugin_new_instance): Add onSetWindow.
1853         (webkit_test_plugin_destroy_instance): Add onSetWindow.
1854         (webkit_test_plugin_set_window): Add onSetWindow.
1855         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1856         (NPP_New): Add onSetWindow.
1857         (NPP_Destroy): Add onSetWindow.
1858         (NPP_SetWindow): Add onSetWindow.
1859
1860 2010-03-26  Robert Hogan  <robert@roberthogan.net>
1861
1862         Reviewed by Simon Hausmann.
1863
1864         Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',
1865          when pluginsEnabled is false.
1866
1867         Add support for LayoutTestController.WebKitPluginsEnabled
1868
1869         https://bugs.webkit.org/show_bug.cgi?id=32196
1870
1871         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1872         (resetDefaultsToConsistentValues):
1873         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1874         (copyWebSettingKey):
1875         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1876         (WebCore::WebPage::resetSettings):
1877         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1878         (LayoutTestController::overridePreference):
1879
1880 2010-03-26  Adam Barth  <abarth@webkit.org>
1881
1882         Reviewed by Eric Seidel.
1883
1884         Add some basic IRC commands to sheriffbot
1885         https://bugs.webkit.org/show_bug.cgi?id=36684
1886
1887         Adds support for sheriffbot to respond to a "hi" command and a
1888         "last-green-revision" command.  It's lame that we're rebuilding
1889         MultiCommandTool, but as discussed in person we'll intergrate the two
1890         once we see what the requirements are.
1891
1892         * Scripts/webkitpy/tool/bot/irc_command.py: Added.
1893         * Scripts/webkitpy/tool/bot/queueengine.py:
1894         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1895         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1896         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added.
1897         * Scripts/webkitpy/tool/commands/queues.py:
1898         * Scripts/webkitpy/tool/commands/queuestest.py:
1899         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1900         * Scripts/webkitpy/tool/main.py:
1901         * Scripts/webkitpy/tool/mocktool.py:
1902         * Scripts/webkitpy/tool/unittests.py:
1903
1904 2010-03-26  Adam Barth  <abarth@webkit.org>
1905
1906         Unreviewed.  More errors in the IRC module.  I have no idea how to test
1907         ircbot.py, which is too bad.  Hopefully we've abstracted it away enough
1908         that we don't have to touch it very much after this patch.
1909
1910         * Scripts/webkitpy/common/net/irc/ircbot.py:
1911
1912 2010-03-26  Adam Barth  <abarth@webkit.org>
1913
1914         Unreviewed.  Add a missing "_".
1915
1916         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1917         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added.
1918         * Scripts/webkitpy/common/net/irc/unittests.py:
1919
1920 2010-03-26  Adam Barth  <abarth@webkit.org>
1921
1922         Unreviewed.  Fix a the commit queue after my recent change.
1923
1924         * Scripts/webkitpy/tool/bot/queueengine.py:
1925
1926 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1927
1928         Unreviewed fix.
1929
1930         Fix the return value for port/base.diff_image (changed from 1/0 to
1931         True/False in bug 34826.
1932
1933         * Scripts/webkitpy/layout_tests/port/base.py:
1934
1935 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1936
1937         Reviewed by Eric Seidel.
1938
1939         Change the Mac port of new-run-webkit-tests to look for a
1940         test_expectations.txt file in addition to the Skipped files, so we
1941         can track pixel failures.
1942
1943         https://bugs.webkit.org/show_bug.cgi?id=36619
1944
1945         * Scripts/webkitpy/layout_tests/port/mac.py:
1946
1947 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1948
1949         Reviewed by Eric Seidel.
1950
1951         Implement pixel tests (image diff) properly on the Mac port.
1952
1953         This change introduces a new "ServerPocess" class that can be used
1954         to manage processes that the run-webkit-tests harness forks off and
1955         expects to stay up for longer than a single request/response session.
1956         Both DumpRenderTree and ImageDiff use this style of communication,
1957         although the current code forks off a new ImageDiff for each diff
1958         (We need to restructure other parts of the code to be able to do this
1959         safely in a multi-threaded environment).
1960
1961         Also, now that the ServerProcess abstraction exists, we can probably
1962         clean up and simplify some of the thread management logic in
1963         test_shell_thread as well.
1964
1965         https://bugs.webkit.org/show_bug.cgi?id=34826
1966
1967         * Scripts/webkitpy/layout_tests/port/mac.py:
1968         * Scripts/webkitpy/layout_tests/port/server_process.py:
1969         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1970
1971 2010-03-26  Sergio Villar Senin  <svillar@igalia.com>
1972
1973         Reviewed by Eric Seidel.
1974
1975         Print didFinishLoadForFrame outcome in DRT
1976
1977         [GTK] Improve reporting of frame loader callbacks in DRT
1978         https://bugs.webkit.org/show_bug.cgi?id=36454
1979
1980         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1981         (webViewLoadCommitted):
1982
1983 2010-03-26  Eric Seidel  <eric@webkit.org>
1984
1985         Unreviewed test fix.
1986         My change conflicted with one of Adam's causing test-webkitpy to fail.
1987
1988         Move commit_message_for_this_commit from scm to checkout
1989         https://bugs.webkit.org/show_bug.cgi?id=36629
1990
1991         * Scripts/webkitpy/common/checkout/api_unittest.py:
1992          - modified_changelogs is now on Checkout instead of scm.
1993
1994 2010-03-26  Adam Barth  <abarth@webkit.org>
1995
1996         Reviewed by Eric Seidel.
1997
1998         Refactor IRCBot controller logic to allow for commands
1999         https://bugs.webkit.org/show_bug.cgi?id=36676
2000
2001         We need to move the controller logic into the tool package so it can
2002         know about commands.  The changes to queueengine could go in a
2003         different patch, but we're going to need it anyway.
2004
2005         * Scripts/webkitpy/common/config/irc.py: Added.
2006         * Scripts/webkitpy/common/net/irc/ircbot.py:
2007         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2008         * Scripts/webkitpy/tool/bot/queueengine.py:
2009         * Scripts/webkitpy/tool/bot/sheriffircbot.py: Added.
2010         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2011         * Scripts/webkitpy/tool/main.py:
2012         * Scripts/webkitpy/tool/mocktool.py:
2013
2014 2010-03-26  Adam Barth  <abarth@webkit.org>
2015
2016         Rubber stamped by Eric Seidel.
2017
2018         Move the threading code into its own module.  (It has nothing to do with IRC.)
2019
2020         * Scripts/webkitpy/common/net/irc/ircbot.py:
2021         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2022         * Scripts/webkitpy/common/net/irc/messagepump.py: Removed.
2023         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed.
2024         * Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed.
2025         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed.
2026         * Scripts/webkitpy/common/net/irc/unittests.py:
2027         * Scripts/webkitpy/common/thread: Added.
2028         * Scripts/webkitpy/common/thread/__init__.py: Added.
2029         * Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py.
2030         * Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py.
2031         * Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py.
2032         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py.
2033         * Scripts/webkitpy/common/thread/unittests.py: Added.
2034         * Scripts/webkitpy/common/unittests.py:
2035
2036 2010-03-26  Eric Seidel  <eric@webkit.org>
2037
2038         Reviewed by Adam Barth.
2039
2040         Move commit_message_for_this_commit from scm to checkout
2041         https://bugs.webkit.org/show_bug.cgi?id=36629
2042
2043         Finally add some basic unit testing for Checkout.commit_message_for_this_commit
2044
2045         * Scripts/webkitpy/common/checkout/api.py:
2046         * Scripts/webkitpy/common/checkout/api_unittest.py: Added.
2047         * Scripts/webkitpy/common/unittests.py:
2048
2049 2010-03-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2050
2051         [Qt] User Agent Switcher on QtLauncher
2052         https://bugs.webkit.org/show_bug.cgi?id=36451
2053
2054         Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26
2055         Reviewed by Simon Hausmann.
2056
2057         Make possible to change the QtLauncher user agent via
2058         a predefined list.
2059
2060         * QtLauncher/QtLauncher.pro:
2061         * QtLauncher/QtLauncher.qrc: Added.
2062         * QtLauncher/main.cpp:
2063         (LauncherWindow::showUserAgentDialog):
2064         (LauncherWindow::createChrome):
2065         * QtLauncher/useragentlist.txt: Added.
2066         * QtLauncher/webpage.cpp:
2067         (WebPage::userAgentForUrl):
2068         * QtLauncher/webpage.h:
2069         (WebPage::setUserAgent):
2070
2071 2010-03-26  Victor Wang  <victorw@chromium.org>
2072
2073         Reviewed by Adam Barth.
2074
2075         Host layout test flakiness dashboard in TestResultServer appengine.
2076
2077         Flakiness dashboard is a tool to monitor layout test status and
2078         help layout test regression diagnostics.
2079
2080         https://bugs.webkit.org/show_bug.cgi?id=36195
2081
2082         * TestResultServer/handlers/dashboardhandler.py: Added.
2083          - New handler to handle dashboard request
2084         * TestResultServer/handlers/menu.py:
2085          - Add new dashboard links
2086         * TestResultServer/handlers/testfilehandler.py:
2087          - Request routes refactory
2088         * TestResultServer/index.yaml:
2089         * TestResultServer/main.py:
2090          - Add new dashboard request routes and refactor test result file rountes.
2091         * TestResultServer/model/dashboardfile.py: Added.
2092          - Model to access datastore for dashboard files
2093         * TestResultServer/model/testfile.py:
2094         * TestResultServer/stylesheets/dashboardfile.css: Added.
2095         * TestResultServer/templates/dashboardfilelist.html: Added.
2096         * TestResultServer/templates/showfilelist.html:
2097
2098 2010-03-26  Adam Barth  <abarth@webkit.org>
2099
2100         Reviewed by Eric Seidel.
2101
2102         Remove some evil statics from CommitInfo
2103         https://bugs.webkit.org/show_bug.cgi?id=36637
2104
2105         These methods should really be on checkout.  You can tell because they
2106         know about ChangeLogs and take an SCM as an argument.  :)
2107
2108         * Scripts/webkitpy/common/checkout/api.py:
2109         * Scripts/webkitpy/common/checkout/changelog.py:
2110         * Scripts/webkitpy/common/checkout/commitinfo.py:
2111         * Scripts/webkitpy/tool/commands/queries.py:
2112
2113 2010-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2114
2115         Reviewed by Simon Hausmann.
2116
2117         Add an option to QtLauncher to enable/disable a QGLWidget as Viewport
2118         of the QGraphicsView when the launcher is running on graphicsview mode.
2119
2120         [Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport
2121         https://bugs.webkit.org/show_bug.cgi?id=36270
2122
2123         * QtLauncher/QtLauncher.pro:
2124         * QtLauncher/main.cpp:
2125         (LauncherWindow::toggleQGLWidgetViewport):
2126         (LauncherWindow::createChrome):
2127
2128 2010-03-26  Fumitoshi Ukai  <ukai@chromium.org>
2129
2130         Reviewed by Shinichiro Hamaji.
2131
2132         [Chromium-Win] websocket_server.py failed to start
2133         https://bugs.webkit.org/show_bug.cgi?id=36586
2134         
2135         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
2136         We don't need stdin, so use devnull as stdin.
2137
2138         * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin
2139
2140 2010-03-26  Kent Tamura  <tkent@chromium.org>
2141
2142         Reviewed by Dimitri Glazkov.
2143
2144         [DRT/Chromium] Add TestNavigationController and TestWebWorker
2145         https://bugs.webkit.org/show_bug.cgi?id=36520
2146
2147         Add LayoutTestController class, which is going to be used by
2148         DumpRenderTree Chromium port. These files are based on:
2149         - src/webkit/tools/test_shell/layout_test_controller.cc
2150         - src/webkit/tools/test_shell/layout_test_controller.h
2151         of Chromium rev.40492.
2152
2153         * DumpRenderTree/chromium/LayoutTestController.cpp: Added.
2154         * DumpRenderTree/chromium/LayoutTestController.h: Added.
2155
2156 2010-03-25  Charlie Reis  <creis@chromium.org>
2157
2158         Reviewed by Adam Barth.
2159
2160         onbeforeunload not called at window close + frame or iframe focused
2161         https://bugs.webkit.org/show_bug.cgi?id=27481
2162
2163         Adds a callShouldCloseOnWebView method to LayoutTestController,
2164         to allow automated testing for bug 27481.
2165
2166         * DumpRenderTree/LayoutTestController.cpp:
2167         (callShouldCloseOnWebViewCallback):
2168         (LayoutTestController::staticFunctions):
2169         * DumpRenderTree/LayoutTestController.h:
2170         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2171         (LayoutTestController::callShouldCloseOnWebView):
2172         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2173         (LayoutTestController::callShouldCloseOnWebView):
2174         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2175         (LayoutTestController::callShouldCloseOnWebView):
2176         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2177         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2178         (LayoutTestController::callShouldCloseOnWebView):
2179
2180 2010-03-25  Eric Seidel  <eric@webkit.org>
2181
2182         Reviewed by Adam Barth.
2183
2184         Add webkit-patch lkgr for finding last known good revision
2185         https://bugs.webkit.org/show_bug.cgi?id=36626
2186
2187         This is rather slow for now because the command
2188         has to compute this information from the buildbot.
2189         A better long-term solution would be to have a server
2190         somewhere store a pre-computed LKGR and then any
2191         script (like webkit-patch) could just fetch it.
2192
2193         * Scripts/webkitpy/common/net/buildbot.py:
2194         * Scripts/webkitpy/tool/commands/queries.py:
2195
2196 2010-03-25  Adam Barth  <abarth@webkit.org>
2197
2198         Reviewed by Eric Seidel.
2199
2200         Move modified_changelogs (and friends) from scm to checkout
2201         https://bugs.webkit.org/show_bug.cgi?id=36636
2202
2203         These functions know about ChangeLogs, which is forbidden knowledge in
2204         scm.py.
2205
2206         * Scripts/webkitpy/common/checkout/api.py:
2207         * Scripts/webkitpy/common/checkout/changelog.py:
2208         * Scripts/webkitpy/common/checkout/scm.py:
2209         * Scripts/webkitpy/tool/mocktool.py:
2210         * Scripts/webkitpy/tool/steps/abstractstep.py:
2211         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2212         * Scripts/webkitpy/tool/steps/revertrevision.py:
2213         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2214         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2215
2216 2010-03-25  Adam Barth  <abarth@webkit.org>
2217
2218         Reviewed by Eric Seidel.
2219
2220         Move apply_patch from scm to checkout
2221         https://bugs.webkit.org/show_bug.cgi?id=36635
2222
2223         SCM shouldn't have any knowledge of WebKit scripts.
2224
2225         * Scripts/webkitpy/common/checkout/api.py:
2226         * Scripts/webkitpy/common/checkout/scm.py:
2227         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2228         * Scripts/webkitpy/tool/mocktool.py:
2229         * Scripts/webkitpy/tool/steps/applypatch.py:
2230
2231 2010-03-25  Eric Seidel  <eric@webkit.org>
2232
2233         Unreviewed build fix to un-break webkit-patch land.
2234         Test-case coming in follow-up commit.
2235
2236         Move commit_message_for_this_commit from scm to checkout
2237         https://bugs.webkit.org/show_bug.cgi?id=36629
2238
2239         * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
2240
2241 2010-03-25  Dan Bernstein  <mitz@apple.com>
2242
2243         Reviewed by Darin Adler.
2244
2245         <rdar://problem/7728903> Support color bitmap fonts
2246
2247         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
2248         and ColorBits-A.png.
2249         * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
2250         * DumpRenderTree/fonts/ColorBits.ttf: Added.
2251         * DumpRenderTree/mac/DumpRenderTree.mm:
2252         (activateFonts): Activate ColorBits.ttf.
2253
2254 2010-03-25  Mark Rowe  <mrowe@apple.com>
2255
2256         Remove a printf that was causing commit-log-editor to spew the name of the editor
2257         to the terminal many times during a commit.
2258
2259         * Scripts/commit-log-editor:
2260
2261 2010-03-25  Adam Barth  <abarth@webkit.org>
2262
2263         Reviewed by Eric Seidel.
2264
2265         Move commit_message_for_this_commit from scm to checkout
2266         https://bugs.webkit.org/show_bug.cgi?id=36629
2267
2268         This function requires knowledge of ChangeLogs, but scm shouldn't know
2269         about ChangeLogs.
2270
2271         * Scripts/webkitpy/common/checkout/api.py:
2272         * Scripts/webkitpy/common/checkout/scm.py:
2273         * Scripts/webkitpy/tool/commands/upload.py:
2274         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2275         * Scripts/webkitpy/tool/mocktool.py:
2276         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
2277         * Scripts/webkitpy/tool/steps/commit.py:
2278
2279 2010-03-25  Adam Barth  <abarth@webkit.org>
2280
2281         Reviewed by Eric Seidel.
2282
2283         REGRESSION: webkit-patch land can't land "rubber-stamped" patches
2284         https://bugs.webkit.org/show_bug.cgi?id=36582
2285
2286         Allow a "-" in rubber stamped.
2287
2288         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2289
2290 2010-03-25  Adam Barth  <abarth@webkit.org>
2291
2292         Unreviewed.  Fix some copyright lines to remove extraneous comma and
2293         python directive.
2294
2295         * Scripts/webkitpy/tool/bot/patchcollection.py:
2296         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
2297         * Scripts/webkitpy/tool/bot/queueengine.py:
2298         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2299         * Scripts/webkitpy/tool/commands/download.py:
2300         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2301         * Scripts/webkitpy/tool/commands/queries.py:
2302         * Scripts/webkitpy/tool/commands/queues.py:
2303         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2304         * Scripts/webkitpy/tool/comments.py:
2305         * Scripts/webkitpy/tool/grammar.py:
2306         * Scripts/webkitpy/tool/multicommandtool.py:
2307         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2308
2309 2010-03-25  Simon Fraser  <simon.fraser@apple.com>
2310
2311         Reviewed by Darin Adler, Alexey Proskuryakov.
2312
2313         https://bugs.webkit.org/show_bug.cgi?id=36631
2314         Allow the test plugin to run scripts in response to NPP_SetWindow calls
2315         
2316         Hook up the ability for the TestNetscapePlugIn to run JavaScript in
2317         response to NPP_SetWindow.
2318         
2319         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2320         (pluginAllocate):
2321         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2322         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2323         (NPP_New):
2324         (NPP_Destroy):
2325         (NPP_SetWindow):
2326
2327 2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2328
2329         Unreviewed, build fix.
2330
2331         [Qt] Fix QtLauncher guards.
2332
2333         * QtLauncher/main.cpp:
2334         (LauncherWindow::showFPS):
2335         (LauncherWindow::updateFPS):
2336
2337 2010-03-25  Yury Semikhatsky  <yurys@chromium.org>
2338
2339         Reviewed by Pavel Feldman.
2340
2341         Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.
2342
2343         https://bugs.webkit.org/show_bug.cgi?id=36610
2344
2345         * DumpRenderTree/LayoutTestController.h:
2346         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2347         (shouldEnableDeveloperExtras):
2348         (runTest):
2349         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2350         (LayoutTestController::setJavaScriptProfilingEnabled):
2351         (LayoutTestController::setDeveloperExtrasEnabled):
2352         (LayoutTestController::showWebInspector):
2353         (LayoutTestController::closeWebInspector):
2354         * DumpRenderTree/mac/DumpRenderTree.mm:
2355         (shouldEnableDeveloperExtras):
2356         (runTest):
2357         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2358         (LayoutTestController::setJavaScriptProfilingEnabled):
2359         (LayoutTestController::setDeveloperExtrasEnabled):
2360         (LayoutTestController::showWebInspector):
2361         (LayoutTestController::closeWebInspector):
2362         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2363         (WebCore::shouldEnableDeveloperExtras):
2364         (WebCore::DumpRenderTree::open):
2365         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2366         (LayoutTestController::closeWebInspector):
2367         (LayoutTestController::setDeveloperExtrasEnabled):
2368         (LayoutTestController::showWebInspector):
2369         (LayoutTestController::setJavaScriptProfilingEnabled):
2370         * DumpRenderTree/win/DumpRenderTree.cpp:
2371         (shouldEnableDeveloperExtras):
2372         (runTest):
2373         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2374         (LayoutTestController::setJavaScriptProfilingEnabled):
2375         (LayoutTestController::setDeveloperExtrasEnabled):
2376         (LayoutTestController::showWebInspector):
2377         (LayoutTestController::closeWebInspector):
2378
2379 2010-03-25  Adam Barth  <abarth@webkit.org>
2380
2381         Rubber stamped by Eric Seidel.
2382
2383         Tweaks to sheriffbot to improve latency by keeping the working copy up
2384         to date even when there's no build break.  Also, officially move
2385         sheriffbot to #webkit.
2386
2387         (Also teach ValidateReviewer to understand rubber stamps.)
2388
2389         * Scripts/webkitpy/common/net/irc/ircbot.py:
2390         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2391         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2392
2393 2010-03-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2394
2395         Reviewed by Simon Hausmann.
2396
2397         Not displaying FPS info on the terminal. On S60 and Maemo the
2398         Window title will be used and Status bar will used on desktop.
2399
2400         [Qt] QtLauncher's FPS info should not be displayed on the terminal
2401         https://bugs.webkit.org/show_bug.cgi?id=36244
2402
2403         * QtLauncher/main.cpp:
2404         (LauncherWindow::initializeView):
2405         (LauncherWindow::showFPS):
2406         (LauncherWindow::updateFPS):
2407         * QtLauncher/webview.cpp:
2408         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
2409         (WebViewGraphicsBased::updateFrameRate):
2410         * QtLauncher/webview.h:
2411         (WebViewGraphicsBased::frameRateMeasurementEnabled):
2412
2413 2010-03-25  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2414
2415         Reviewed by Kenneth Christiansen.
2416
2417         Added missing frame flattening activation on
2418         fast/frames/flattening/frameset-flattening-grid.html;
2419         removed unnecessary CONSOLE MESSAGE from the expected file;
2420         reset the setFrameSetFlatteningEnabled for each test.
2421
2422         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2423         (WebCore::WebPage::resetSettings):
2424
2425 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2426
2427         Reviewed by Adam Barth.
2428
2429         Moved deprecated_logging unit test import statement from
2430         webkitpy/unittests.py to webkitpy/common/system/unittests.py.
2431
2432         https://bugs.webkit.org/show_bug.cgi?id=36093
2433
2434         This is part of the master bug to reorganize webkitpy.
2435
2436         * Scripts/webkitpy/common/system/unittests.py:
2437         * Scripts/webkitpy/unittests.py:
2438
2439 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2440
2441         Reviewed by Adam Barth.
2442
2443         Moved webkit_logging.py to common/system/deprecated_logging.py
2444         inside webkitpy.
2445
2446         https://bugs.webkit.org/show_bug.cgi?id=36093
2447
2448         This is part of the master bug to reorganize webkitpy.
2449
2450         * Scripts/validate-committer-lists:
2451         * Scripts/webkitpy/common/checkout/changelog.py:
2452         * Scripts/webkitpy/common/checkout/scm.py:
2453         * Scripts/webkitpy/common/net/bugzilla.py:
2454         * Scripts/webkitpy/common/net/buildbot.py:
2455         * Scripts/webkitpy/common/net/credentials.py:
2456         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2457         * Scripts/webkitpy/common/net/networktransaction.py:
2458         * Scripts/webkitpy/common/net/statusserver.py:
2459         * Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
2460         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
2461         * Scripts/webkitpy/common/system/executive.py:
2462         * Scripts/webkitpy/tool/bot/queueengine.py:
2463         * Scripts/webkitpy/tool/commands/download.py:
2464         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2465         * Scripts/webkitpy/tool/commands/openbugs.py:
2466         * Scripts/webkitpy/tool/commands/queries.py:
2467         * Scripts/webkitpy/tool/commands/queues.py:
2468         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2469         * Scripts/webkitpy/tool/commands/stepsequence.py:
2470         * Scripts/webkitpy/tool/commands/upload.py:
2471         * Scripts/webkitpy/tool/main.py:
2472         * Scripts/webkitpy/tool/mocktool.py:
2473         * Scripts/webkitpy/tool/multicommandtool.py:
2474         * Scripts/webkitpy/tool/steps/abstractstep.py:
2475         * Scripts/webkitpy/tool/steps/applypatch.py:
2476         * Scripts/webkitpy/tool/steps/build.py:
2477         * Scripts/webkitpy/tool/steps/checkstyle.py:
2478         * Scripts/webkitpy/tool/steps/closebug.py:
2479         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2480         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2481         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2482         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
2483         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2484         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2485         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2486         * Scripts/webkitpy/tool/steps/runtests.py:
2487         * Scripts/webkitpy/tool/steps/update.py:
2488         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2489         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2490         * Scripts/webkitpy/unittests.py:
2491         * Scripts/webkitpy/webkit_logging.py: Removed.
2492         * Scripts/webkitpy/webkit_logging_unittest.py: Removed.
2493
2494 2010-03-25  Julien Chaffraix  <jchaffraix@webkit.org>
2495
2496         Reviewed by Kenneth Rohde Christiansen.
2497
2498         commit-log-editor can call itself in an infinite loop
2499         https://bugs.webkit.org/show_bug.cgi?id=35291
2500
2501         if $editor ends up being commit-log-editor, the script will exec itself
2502         in an infinite loop.
2503
2504         To avoid this, we now check that the $editor variable is not
2505         commit-log-editor to avoid this case.
2506
2507         * Scripts/commit-log-editor: Added an isCommitLogEditor method and
2508         reworked the $editor setting to add this check.
2509
2510 2010-03-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2511
2512         Reviewed by Kenneth Rohde Christiansen.
2513
2514         Add a Toggle Frame Flattening option to QtLauncher.
2515         It will be enabled by default on Maemo5 and S60 platforms.
2516
2517         [Qt] Add enable/disable Frame Flattening option to QtLauncher
2518         https://bugs.webkit.org/show_bug.cgi?id=36558
2519
2520         * QtLauncher/main.cpp:
2521         (LauncherWindow::applyPrefs):
2522         (LauncherWindow::toggleFrameFlattening):
2523         (LauncherWindow::createChrome):
2524
2525 2010-03-25  Zoltan Horvath  <zoltan@webkit.org>
2526
2527         Reviewed by Eric Seidel.
2528
2529         svn-create-patch prints a warning for large patches
2530         https://bugs.webkit.org/show_bug.cgi?id=32582
2531
2532         svn-create-patch prints a warning message for larger patches than 20k.
2533
2534         * Scripts/svn-create-patch:
2535
2536 2010-03-25  Adam Barth  <abarth@webkit.org>
2537
2538         Unreviewed.  Renamed early_warning_system.py to earlywarningsystem.py.
2539         https://bugs.webkit.org/show_bug.cgi?id=36093
2540
2541         * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
2542         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
2543         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
2544         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
2545         * Scripts/webkitpy/tool/main.py:
2546         * Scripts/webkitpy/tool/unittests.py:
2547
2548 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2549
2550         Reviewed by Adam Barth.
2551
2552         In webkitpy, pushed the unit test import statements in
2553         webkitpy/unittests.py into appropriate unittests.py files in the
2554         new root-level packages beneath webkitpy.
2555
2556         https://bugs.webkit.org/show_bug.cgi?id=36093
2557
2558         This is part of the master bug to reorganize webkitpy.
2559
2560         * Scripts/webkitpy/common/system/unittests.py:
2561         * Scripts/webkitpy/common/unittests.py: Added.
2562         * Scripts/webkitpy/python24/unittests.py: Added.
2563         * Scripts/webkitpy/tool/unittests.py: Added.
2564         * Scripts/webkitpy/unittests.py:
2565
2566 2010-03-25  Adam Barth  <abarth@webkit.org>
2567
2568         Unreviewed.  Move WebKitCheckout into the webkitpy.common.checkout
2569         package.
2570         https://bugs.webkit.org/show_bug.cgi?id=36093
2571
2572         * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
2573         * Scripts/webkitpy/tool/main.py:
2574         * Scripts/webkitpy/tool/mocktool.py:
2575         * Scripts/webkitpy/webkitcheckout.py: Removed.
2576
2577 2010-03-25  Adam Barth  <abarth@webkit.org>
2578
2579         Unreviewed.  Move OutputCapture to webkitpy.common.system.
2580         https://bugs.webkit.org/show_bug.cgi?id=36093
2581
2582         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2583         * Scripts/webkitpy/common/net/credentials_unittest.py:
2584         * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
2585         * Scripts/webkitpy/outputcapture.py: Removed.
2586         * Scripts/webkitpy/tool/commands/commandtest.py:
2587         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2588         * Scripts/webkitpy/tool/commands/queuestest.py:
2589         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2590         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2591         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2592         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2593
2594 2010-03-25  Adam Barth  <abarth@webkit.org>
2595
2596         Unreviewed.  Move user.py to webkitpy.common.system.
2597
2598         * Scripts/webkitpy/common/checkout/scm.py:
2599         * Scripts/webkitpy/common/net/bugzilla.py:
2600         * Scripts/webkitpy/common/net/credentials.py:
2601         * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
2602         * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
2603         * Scripts/webkitpy/tool/commands/upload.py:
2604         * Scripts/webkitpy/tool/main.py:
2605         * Scripts/webkitpy/unittests.py:
2606         * Scripts/webkitpy/user.py: Removed.
2607         * Scripts/webkitpy/user_unittest.py: Removed.
2608
2609 2010-03-25  Adam Barth  <abarth@webkit.org>
2610
2611         Unreviewed.  Move executive.py to webkitpy.common.system.
2612         https://bugs.webkit.org/show_bug.cgi?id=36093
2613
2614         * Scripts/webkitpy/common/checkout/scm.py:
2615         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2616         * Scripts/webkitpy/common/config/ports.py:
2617         * Scripts/webkitpy/common/config/ports_unittest.py:
2618         * Scripts/webkitpy/common/net/credentials.py:
2619         * Scripts/webkitpy/common/net/credentials_unittest.py:
2620         * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
2621         * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
2622         * Scripts/webkitpy/executive.py: Removed.
2623         * Scripts/webkitpy/executive_unittest.py: Removed.
2624         * Scripts/webkitpy/layout_tests/port/mac.py:
2625         * Scripts/webkitpy/tool/bot/queueengine.py:
2626         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2627         * Scripts/webkitpy/tool/commands/download.py:
2628         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2629         * Scripts/webkitpy/tool/commands/queues.py:
2630         * Scripts/webkitpy/tool/commands/stepsequence.py:
2631         * Scripts/webkitpy/tool/main.py:
2632         * Scripts/webkitpy/tool/steps/checkstyle.py:
2633         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2634         * Scripts/webkitpy/unittests.py:
2635         * Scripts/webkitpy/webkit_logging_unittest.py:
2636
2637 2010-03-25  Adam Barth  <abarth@webkit.org>
2638
2639         Unreviewed.  Move grammary.py into webkitpy.tool.
2640         https://bugs.webkit.org/show_bug.cgi?id=36093
2641
2642         * Scripts/webkitpy/grammar.py: Removed.
2643         * Scripts/webkitpy/grammar_unittest.py: Removed.
2644         * Scripts/webkitpy/tool/commands/download.py:
2645         * Scripts/webkitpy/tool/commands/queries.py:
2646         * Scripts/webkitpy/tool/commands/queues.py:
2647         * Scripts/webkitpy/tool/commands/upload.py:
2648         * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
2649         * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
2650         * Scripts/webkitpy/tool/multicommandtool.py:
2651         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2652         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2653         * Scripts/webkitpy/unittests.py:
2654
2655 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2656
2657         Reviewed by Adam Barth.
2658
2659         In webkitpy, moved init/ to common/system/.
2660
2661         https://bugs.webkit.org/show_bug.cgi?id=36093
2662
2663         This is part of the master bug to reorganize webkitpy.
2664
2665         * Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
2666         * Scripts/webkitpy/common/system/logutils.py:
2667         * Scripts/webkitpy/common/system/logutils_unittest.py:
2668         * Scripts/webkitpy/init: Removed.
2669         * Scripts/webkitpy/init/__init__.py: Removed.
2670         * Scripts/webkitpy/init/logtesting.py: Removed.
2671         * Scripts/webkitpy/init/logutils.py: Removed.
2672         * Scripts/webkitpy/init/logutils_unittest.py: Removed.
2673         * Scripts/webkitpy/init/unittests.py: Removed.
2674         * Scripts/webkitpy/python24/versioning_unittest.py:
2675         * Scripts/webkitpy/style_references.py:
2676         * Scripts/webkitpy/unittests.py:
2677
2678 2010-03-25  Adam Barth  <abarth@webkit.org>
2679
2680         Unreviewed.  Move stepsequence to webkitpy.tool.commands.
2681         https://bugs.webkit.org/show_bug.cgi?id=36093
2682
2683         * Scripts/webkitpy/stepsequence.py: Removed.
2684         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2685         * Scripts/webkitpy/tool/commands/download.py:
2686         * Scripts/webkitpy/tool/commands/queues.py:
2687         * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
2688
2689 2010-03-25  Adam Barth  <abarth@webkit.org>
2690
2691         Unreviewed.  Create webkitpy.common.checkout as described in
2692         https://bugs.webkit.org/show_bug.cgi?id=36093
2693
2694         * Scripts/webkitpy/changelogs.py: Removed.
2695         * Scripts/webkitpy/changelogs_unittest.py: Removed.
2696         * Scripts/webkitpy/commitinfo.py: Removed.
2697         * Scripts/webkitpy/commitinfo_unittest.py: Removed.
2698         * Scripts/webkitpy/common/checkout: Added.
2699         * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py.
2700         * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
2701         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
2702         * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
2703         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
2704         * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
2705         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
2706         * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
2707         * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
2708         * Scripts/webkitpy/common/net/credentials.py:
2709         * Scripts/webkitpy/diff_parser.py: Removed.
2710         * Scripts/webkitpy/diff_parser_unittest.py: Removed.
2711         * Scripts/webkitpy/layout_tests/port/base.py:
2712         * Scripts/webkitpy/scm.py: Removed.
2713         * Scripts/webkitpy/scm_unittest.py: Removed.
2714         * Scripts/webkitpy/stepsequence.py:
2715         * Scripts/webkitpy/style_references.py:
2716         * Scripts/webkitpy/tool/commands/download.py:
2717         * Scripts/webkitpy/tool/commands/queries.py:
2718         * Scripts/webkitpy/tool/comments.py:
2719         * Scripts/webkitpy/tool/main.py:
2720         * Scripts/webkitpy/tool/mocktool.py:
2721         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2722         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2723         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2724         * Scripts/webkitpy/unittests.py:
2725         * Scripts/webkitpy/webkitcheckout.py:
2726
2727 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2728
2729         Reviewed by Adam Barth.
2730
2731         In webkitpy, moved init/versioning.py to python24/.
2732
2733         https://bugs.webkit.org/show_bug.cgi?id=36093
2734
2735         This is part of the master bug to reorganize webkitpy.
2736
2737         * Scripts/test-webkitpy:
2738         * Scripts/webkit-patch:
2739         * Scripts/webkitpy/init/unittests.py:
2740         * Scripts/webkitpy/init/versioning.py: Removed.
2741         * Scripts/webkitpy/init/versioning_unittest.py: Removed.
2742         * Scripts/webkitpy/python24: Added.
2743         * Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py.
2744         * Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
2745         * Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
2746         * Scripts/webkitpy/unittests.py:
2747
2748 2010-03-25  Adam Barth  <abarth@webkit.org>
2749
2750         Unreviewed.
2751
2752         Create webkitpy.common.net as described in
2753         https://bugs.webkit.org/show_bug.cgi?id=36093
2754
2755         * Scripts/webkitpy/bugzilla.py: Removed.
2756         * Scripts/webkitpy/bugzilla_unittest.py: Removed.
2757         * Scripts/webkitpy/buildbot.py: Removed.
2758         * Scripts/webkitpy/buildbot_unittest.py: Removed.
2759         * Scripts/webkitpy/commitinfo.py:
2760         * Scripts/webkitpy/common/net: Added.
2761         * Scripts/webkitpy/common/net/__init__.py: Added.
2762         * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
2763         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
2764         * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
2765         * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
2766         * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
2767         * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
2768         * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
2769         * Scripts/webkitpy/common/net/irc/ircbot.py:
2770         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2771         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
2772         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
2773         * Scripts/webkitpy/common/net/irc/unittests.py:
2774         * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
2775         * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
2776         * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
2777         * Scripts/webkitpy/credentials.py: Removed.
2778         * Scripts/webkitpy/credentials_unittest.py: Removed.
2779         * Scripts/webkitpy/irc: Removed.
2780         * Scripts/webkitpy/irc/__init__.py: Removed.
2781         * Scripts/webkitpy/irc/ircbot.py: Removed.
2782         * Scripts/webkitpy/irc/ircproxy.py: Removed.
2783         * Scripts/webkitpy/irc/messagepump.py: Removed.
2784         * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
2785         * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
2786         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
2787         * Scripts/webkitpy/irc/unittests.py: Removed.
2788         * Scripts/webkitpy/networktransaction.py: Removed.
2789         * Scripts/webkitpy/networktransaction_unittest.py: Removed.
2790         * Scripts/webkitpy/scm_unittest.py:
2791         * Scripts/webkitpy/statusserver.py: Removed.
2792         * Scripts/webkitpy/tool/bot/queueengine.py:
2793         * Scripts/webkitpy/tool/commands/download.py:
2794         * Scripts/webkitpy/tool/commands/queries.py:
2795         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2796         * Scripts/webkitpy/tool/commands/queues.py:
2797         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2798         * Scripts/webkitpy/tool/commands/queuestest.py:
2799         * Scripts/webkitpy/tool/commands/upload.py:
2800         * Scripts/webkitpy/tool/main.py:
2801         * Scripts/webkitpy/tool/mocktool.py:
2802         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2803         * Scripts/webkitpy/unittests.py:
2804
2805 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2806
2807         Reviewed by Adam Barth.
2808
2809         In webkitpy, renamed MockBugzillaTool to MockTool.
2810
2811         * Scripts/webkitpy/tool/commands/commandtest.py:
2812         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2813         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2814         * Scripts/webkitpy/tool/commands/queuestest.py:
2815         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2816         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2817         * Scripts/webkitpy/tool/mocktool.py:
2818         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2819         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2820         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2821
2822 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2823
2824         Reviewed by Adam Barth.
2825
2826         In Scripts/webkitpy, moved webkitport.py and committers.py into
2827         common/config/ (also creating common/config/).
2828
2829         https://bugs.webkit.org/show_bug.cgi?id=36093
2830
2831         This is part of the master bug to reorganize webkitpy.
2832
2833         * Scripts/validate-committer-lists:
2834         * Scripts/webkitpy/bugzilla.py:
2835         * Scripts/webkitpy/bugzilla_unittest.py:
2836         * Scripts/webkitpy/changelogs.py:
2837         * Scripts/webkitpy/commitinfo.py:
2838         * Scripts/webkitpy/commitinfo_unittest.py:
2839         * Scripts/webkitpy/committers.py: Removed.
2840         * Scripts/webkitpy/committers_unittest.py: Removed.
2841         * Scripts/webkitpy/common: Added.
2842         * Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
2843         * Scripts/webkitpy/common/config: Added.
2844         * Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
2845         * Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
2846         * Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
2847         * Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
2848         * Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
2849         * Scripts/webkitpy/mock_bugzillatool.py:
2850         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2851         * Scripts/webkitpy/tool/commands/queries.py:
2852         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2853         * Scripts/webkitpy/tool/commands/upload.py:
2854         * Scripts/webkitpy/tool/steps/abstractstep.py:
2855         * Scripts/webkitpy/unittests.py:
2856         * Scripts/webkitpy/webkitport.py: Removed.
2857         * Scripts/webkitpy/webkitport_unittest.py: Removed.
2858
2859 2010-03-25  Adam Barth  <abarth@webkit.org>
2860
2861         Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.
2862
2863         * Scripts/webkitpy/mock_bugzillatool.py: Removed.
2864         * Scripts/webkitpy/tool/commands/commandtest.py:
2865         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2866         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2867         * Scripts/webkitpy/tool/commands/queuestest.py:
2868         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2869         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2870         * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
2871         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2872         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2873         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2874
2875 2010-03-24  Adam Barth  <abarth@webkit.org>
2876
2877         Unreviewed.  Move comments.py and multicommandtool.py to their new
2878         home.
2879
2880         * Scripts/webkitpy/comments.py: Removed.
2881         * Scripts/webkitpy/multicommandtool.py: Removed.
2882         * Scripts/webkitpy/multicommandtool_unittest.py: Removed.
2883         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2884         * Scripts/webkitpy/tool/commands/download.py:
2885         * Scripts/webkitpy/tool/commands/openbugs.py:
2886         * Scripts/webkitpy/tool/commands/queries.py:
2887         * Scripts/webkitpy/tool/commands/queues.py:
2888         * Scripts/webkitpy/tool/commands/upload.py:
2889         * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
2890         * Scripts/webkitpy/tool/main.py:
2891         * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
2892         * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
2893         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2894         * Scripts/webkitpy/tool/steps/closepatch.py:
2895         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2896         * Scripts/webkitpy/unittests.py:
2897
2898 2010-03-24  Adam Barth  <abarth@webkit.org>
2899
2900         Unreviewed.  Fixup one import statement I didn't find because the .pyc
2901         masked the error.
2902
2903         * Scripts/webkitpy/stepsequence.py:
2904
2905 2010-03-24  Adam Barth  <abarth@webkit.org>
2906
2907         Unreviewed.  Move queueengine.py to its new home.
2908
2909         * Scripts/webkitpy/queueengine.py: Removed.
2910         * Scripts/webkitpy/queueengine_unittest.py: Removed.
2911         * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
2912         * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
2913         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2914         * Scripts/webkitpy/tool/commands/queues.py:
2915         * Scripts/webkitpy/unittests.py:
2916
2917 2010-03-24  Adam Barth  <abarth@webkit.org>
2918
2919         Unreviewed.  Move patchcollection.py to its new home.
2920
2921         * Scripts/webkitpy/patchcollection.py: Removed.
2922         * Scripts/webkitpy/patchcollection_unittest.py: Removed.
2923         * Scripts/webkitpy/tool/bot: Added.
2924         * Scripts/webkitpy/tool/bot/__init__.py: Added.
2925         * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
2926         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
2927         * Scripts/webkitpy/tool/commands/queues.py:
2928         * Scripts/webkitpy/unittests.py:
2929
2930 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
2931
2932         Reviewed by Adam Barth.
2933
2934         In Scripts/webkitpy, moved steps_references.py and the steps
2935         folder into webkitpy/patch.
2936
2937         https://bugs.webkit.org/show_bug.cgi?id=36093
2938
2939         * Scripts/webkitpy/steps: Removed.
2940         * Scripts/webkitpy/steps/__init__.py: Removed.
2941         * Scripts/webkitpy/steps/abstractstep.py: Removed.
2942         * Scripts/webkitpy/steps/applypatch.py: Removed.
2943         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
2944         * Scripts/webkitpy/steps/build.py: Removed.
2945         * Scripts/webkitpy/steps/checkstyle.py: Removed.
2946         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
2947         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
2948         * Scripts/webkitpy/steps/closebug.py: Removed.
2949         * Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
2950         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
2951         * Scripts/webkitpy/steps/closepatch.py: Removed.
2952         * Scripts/webkitpy/steps/commit.py: Removed.
2953         * Scripts/webkitpy/steps/confirmdiff.py: Removed.
2954         * Scripts/webkitpy/steps/createbug.py: Removed.
2955         * Scripts/webkitpy/steps/editchangelog.py: Removed.
2956         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
2957         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
2958         * Scripts/webkitpy/steps/metastep.py: Removed.
2959         * Scripts/webkitpy/steps/obsoletepatches.py: Removed.
2960         * Scripts/webkitpy/steps/options.py: Removed.
2961         * Scripts/webkitpy/steps/postdiff.py: Removed.
2962         * Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
2963         * Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
2964         * Scripts/webkitpy/steps/preparechangelog.py: Removed.
2965         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
2966         * Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
2967         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
2968         * Scripts/webkitpy/steps/revertrevision.py: Removed.
2969         * Scripts/webkitpy/steps/runtests.py: Removed.
2970         * Scripts/webkitpy/steps/steps_unittest.py: Removed.
2971         * Scripts/webkitpy/steps/update.py: Removed.
2972         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
2973         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
2974         * Scripts/webkitpy/steps/validatereviewer.py: Removed.
2975         * Scripts/webkitpy/steps_references.py: Removed.
2976         * Scripts/webkitpy/stepsequence.py:
2977         * Scripts/webkitpy/tool/commands/download.py:
2978         * Scripts/webkitpy/tool/commands/upload.py:
2979         * Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
2980         * Scripts/webkitpy/tool/steps/__init__.py:
2981         * Scripts/webkitpy/tool/steps/applypatch.py:
2982         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
2983         * Scripts/webkitpy/tool/steps/build.py:
2984         * Scripts/webkitpy/tool/steps/checkstyle.py:
2985         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2986         * Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
2987         * Scripts/webkitpy/tool/steps/closebug.py:
2988         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2989         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2990         * Scripts/webkitpy/tool/steps/closepatch.py:
2991         * Scripts/webkitpy/tool/steps/commit.py:
2992         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2993         * Scripts/webkitpy/tool/steps/createbug.py:
2994         * Scripts/webkitpy/tool/steps/editchangelog.py:
2995         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2996         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
2997         * Scripts/webkitpy/tool/steps/metastep.py:
2998         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2999         * Scripts/webkitpy/tool/steps/postdiff.py:
3000         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3001         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3002         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3003         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3004         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
3005         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3006         * Scripts/webkitpy/tool/steps/revertrevision.py:
3007         * Scripts/webkitpy/tool/steps/runtests.py:
3008         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3009         * Scripts/webkitpy/tool/steps/update.py:
3010         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
3011         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3012         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3013         * Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
3014         * Scripts/webkitpy/unittests.py:
3015
3016 2010-03-24  Eric Seidel  <eric@webkit.org>
3017
3018         Unreviewed, build fix only.
3019
3020         Abstract LayoutTestResults logic for easier reuse
3021         https://bugs.webkit.org/show_bug.cgi?id=36579
3022
3023         * Scripts/webkitpy/buildbot_unittest.py: Add a missing import.
3024
3025 2010-03-24  Adam Barth  <abarth@webkit.org>
3026
3027         Unreviewed.  Fix a stray comma to test landing an patch without review.
3028
3029         * Scripts/webkitpy/commitinfo.py:
3030
3031 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
3032
3033         Reviewed by Adam Barth.
3034
3035         In Scripts/webkitpy, moved commands_references.py and the commands
3036         folder into webkitpy/patch.
3037
3038         https://bugs.webkit.org/show_bug.cgi?id=36483
3039
3040         This is part of master bug 36093 to organize webkitpy.
3041
3042         * Scripts/webkitpy/commands: Removed.
3043         * Scripts/webkitpy/commands/__init__.py: Removed.
3044         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
3045         * Scripts/webkitpy/commands/commandtest.py: Removed.
3046         * Scripts/webkitpy/commands/download.py: Removed.
3047         * Scripts/webkitpy/commands/download_unittest.py: Removed.
3048         * Scripts/webkitpy/commands/early_warning_system.py: Removed.
3049         * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
3050         * Scripts/webkitpy/commands/openbugs.py: Removed.
3051         * Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
3052         * Scripts/webkitpy/commands/queries.py: Removed.
3053         * Scripts/webkitpy/commands/queries_unittest.py: Removed.
3054         * Scripts/webkitpy/commands/queues.py: Removed.
3055         * Scripts/webkitpy/commands/queues_unittest.py: Removed.
3056         * Scripts/webkitpy/commands/queuestest.py: Removed.
3057         * Scripts/webkitpy/commands/sheriffbot.py: Removed.
3058         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
3059         * Scripts/webkitpy/commands/upload.py: Removed.
3060         * Scripts/webkitpy/commands/upload_unittest.py: Removed.
3061         * Scripts/webkitpy/commands_references.py: Removed.
3062         * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
3063         * Scripts/webkitpy/tool/commands/commandtest.py:
3064         * Scripts/webkitpy/tool/commands/download.py:
3065         * Scripts/webkitpy/tool/commands/download_unittest.py:
3066         * Scripts/webkitpy/tool/commands/early_warning_system.py:
3067         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
3068         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3069         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3070         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3071         * Scripts/webkitpy/tool/commands/queuestest.py:
3072         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3073         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3074         * Scripts/webkitpy/tool/commands/upload.py:
3075         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3076         * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
3077         * Scripts/webkitpy/tool/main.py:
3078         * Scripts/webkitpy/unittests.py:
3079
3080 2010-03-24  Adam Barth  <abarth@webkit.org>
3081
3082         Reviewed by Eric Seidel.
3083
3084         Rename webkitpy.patch to webkitpy.tool
3085         https://bugs.webkit.org/show_bug.cgi?id=36580
3086
3087         This is in preparation for the great webkitpy naming cleanup.
3088
3089         * Scripts/webkit-patch:
3090         * Scripts/webkitpy/patch: Removed.
3091         * Scripts/webkitpy/patch/__init__.py: Removed.
3092         * Scripts/webkitpy/patch/patcher.py: Removed.
3093         * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
3094         * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
3095         * Scripts/webkitpy/tool/patcher.py: Removed.
3096
3097 2010-03-24  Eric Seidel  <eric@webkit.org>
3098
3099         Reviewed by Adam Barth.
3100
3101         Abstract LayoutTestResults logic for easier reuse
3102         https://bugs.webkit.org/show_bug.cgi?id=36579
3103
3104         * Scripts/webkitpy/buildbot.py:
3105          - Split out logic into new LayoutTestResults class.
3106         * Scripts/webkitpy/buildbot_unittest.py:
3107          - Rename the testing class to match.
3108         * Scripts/webkitpy/commands/queries.py:
3109          - Use the new LayoutTestResults class.
3110
3111 2010-03-24  Eric Seidel  <eric@webkit.org>
3112
3113         Reviewed by Eric Seidel.
3114
3115         Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
3116         https://bugs.webkit.org/show_bug.cgi?id=36577
3117
3118         * Scripts/webkitpy/bugzilla.py:
3119          - Move prompt_for_component to User
3120         * Scripts/webkitpy/commands/queries.py:
3121          - Add a missing argument_names declaration.
3122         * Scripts/webkitpy/user.py:
3123          - Add prompt_with_list
3124          - Make staticmethods classmethods for easier mocking
3125
3126 2010-03-24  David Kilzer  <ddkilzer@apple.com>
3127
3128         <http://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file
3129
3130         Reviewed by Eric Seidel.
3131
3132         Fixes the following error when committing a file with
3133         "ChangeLog" in the name that isn't a ChangeLog (like
3134         mergeChangeLogs.pl from r56471 and r56472):
3135
3136             $ git commit .
3137             Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
3138             error: There was a problem with the editor 'commit-log-editor'.
3139             Please supply the message using either -m or -F option.
3140
3141         * Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
3142         the end of the file name when searching for ChangeLog files in a
3143         commit.
3144
3145 2010-03-24  David Kilzer  <ddkilzer@apple.com>
3146
3147         <http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged
3148
3149         Reviewed by Eric Seidel.
3150
3151         * Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
3152         the merge attempt fails.
3153
3154 2010-03-24  Adam Barth  <abarth@webkit.org>
3155
3156         Reviewed by Eric Seidel.
3157
3158         webkit-patch or pre-commit hook should validate reviewer lines before committing
3159         https://bugs.webkit.org/show_bug.cgi?id=26927
3160
3161         Validate that patches have valid reivewers listed in their ChangeLogs
3162         before landing.  For patches without reviewers can be landed if their
3163         ChangeLogs state that they are unreviewed.
3164
3165         * Scripts/webkitpy/changelogs.py:
3166         * Scripts/webkitpy/commands/download.py:
3167         * Scripts/webkitpy/commitinfo.py:
3168         * Scripts/webkitpy/commitinfo_unittest.py:
3169         * Scripts/webkitpy/mock_bugzillatool.py:
3170         * Scripts/webkitpy/steps/__init__.py:
3171         * Scripts/webkitpy/steps/validatereviewer.py: Added.
3172
3173 2010-03-19  Holger Hans Peter Freyther  <zecke@selfish.org>
3174
3175         Reviewed by David Levin.
3176
3177         Undefined names reported by pyflakes in python scripts
3178         https://bugs.webkit.org/show_bug.cgi?id=36403
3179
3180         Attempt to use names that exist or can exist in the lexical
3181         scope instead of not being available at all.
3182
3183         * Scripts/webkitpy/changelogs.py: Use self._content.
3184         * Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
3185         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
3186         * Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re
3187
3188 2010-03-24  David Kilzer  <ddkilzer@apple.com>
3189
3190         <http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge
3191
3192         Reviewed by Eric Seidel.
3193
3194         When resolve-ChangeLogs fails to merge a patch while running as
3195         a git merge driver, it deletes the original file, which causes
3196         an internal failure and stops git mid-merge:
3197
3198             fatal: Failed to execute internal merge
3199
3200         The fix is to use the --force switch with patch so that it will
3201         always attempt to apply the patch.  (The change in
3202         mergeChangeLogs() for the previous commit also fixed this, but
3203         adding --force also prevents any potential user interaction that
3204         patch may want to display.)
3205
3206         * Scripts/VCSUtils.pm:
3207         (mergeChangeLogs): Added --force switch to patch command.  Also
3208         changed to use the exit status from the patch command to
3209         determine the return value for this method.
3210         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
3211         test to cover this bug.
3212
3213 2010-03-24  David Kilzer  <ddkilzer@apple.com>
3214
3215         <http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package
3216
3217         Reviewed by Eric Seidel.
3218
3219         * Scripts/VCSUtils.pm:
3220         (mergeChangeLogs): Copied from mergeChanges() in
3221         resolve-ChangeLogs and renamed.  Added method documentation.
3222         Fixed bug found by new tests where the original file to be
3223         patched was deleted when cleaning up after a traditinal rejected
3224         patch failed to apply.
3225         * Scripts/resolve-ChangeLogs: Switched to using
3226         mergeChangeLogs().
3227         (mergeChanges): Moved to VCSUtils.pm and renamed to
3228         mergeChangeLogs().
3229         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.
3230
3231 2010-03-24  Eric Seidel  <eric@webkit.org>
3232
3233         Reviewed by Adam Barth.
3234
3235         Add support for qt's unassigned list to webkit-patch assign-to-committer
3236         https://bugs.webkit.org/show_bug.cgi?id=36559
3237
3238         * Scripts/webkitpy/bugzilla.py:
3239          - Move Bugzilla.unassigned_email into Bug and make it a set.
3240         * Scripts/webkitpy/bugzilla_unittest.py:
3241          - Test the new Bug.is_unassigned method
3242         * Scripts/webkitpy/commands/upload.py:
3243          - Use the new Bug.is_unassigned method instead of an explicit ==
3244         * Scripts/webkitpy/mock_bugzillatool.py:
3245          - Bugzilla.unassigned_email no longer needs mocking
3246
3247 2010-03-24  Kent Hansen  <kent.hansen@nokia.com>
3248
3249         Reviewed by Simon Hausmann.
3250
3251         [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
3252         https://bugs.webkit.org/show_bug.cgi?id=36522
3253
3254         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3255         (LayoutTestController::setXSSAuditorEnabled): Use the new name.
3256
3257 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
3258
3259         Reviewed by Shinichiro Hamaji.
3260
3261         Added to check-webkit-style support for a --debug flag.
3262
3263         https://bugs.webkit.org/show_bug.cgi?id=36100
3264
3265         The --debug flag adjusts the logging level to DEBUG and
3266         includes the logger name and level in each log message.
3267
3268         * Scripts/check-webkit-style:
3269           - Changed the code to check for the --debug flag and pass
3270             the result to the configure_logging() method.
3271         * Scripts/webkitpy/style/checker.py:
3272           - Added an is_debug parameter to configure_logging().
3273           - Refactored configure_logging() by adding calls to
3274             the following two methods: _create_log_handlers() and
3275             _create_debug_log_handlers().
3276         * Scripts/webkitpy/style/checker_unittest.py:
3277           - Added unit tests for configure_logging() with is_debug True
3278             by splitting the ConfigureLoggingTest class into
3279             ConfigureLoggingTest and ConfigureLoggingTestBase, and
3280             adding ConfigureLoggingDebugTest.
3281         * Scripts/webkitpy/style/optparser.py:
3282           - Updated the usage string.
3283           - Added an is_debug data attribute to the CommandOptionValues
3284             class.
3285           - Added support for the --debug flag to the ArgumentParser.parse()
3286             method.
3287           - Also added extra error information to the parse() method in
3288             the case of an invalid flag.
3289         * Scripts/webkitpy/style/optparser_unittest.py:
3290           - Updated the unit tests as necessary.
3291           - Also fixed an issue with the CommandOptionValuesTest.test_eq()
3292             unit test.
3293
3294 2010-03-23  Kent Tamura  <tkent@chromium.org>
3295
3296         Reviewed by Dimitri Glazkov.
3297
3298         [DRT/Chromium] Add TestNavigationController and TestWebWorker
3299         https://bugs.webkit.org/show_bug.cgi?id=36489
3300
3301         Add TestNavigationController and TestWebWorker classes, which are
3302         going to be used by DumpRenderTree Chromium port. These files are
3303         based on:
3304         - src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
3305         - src/webkit/tools/test_shell/test_web_worker.h
3306         of Chromium rev.40492.
3307
3308         TestNavigationController has non-style changes.
3309         - Change ContentState type: binary string -> WebHistoryItem
3310         - Remove TestShell dependency by introducing NavigationHost interface.
3311
3312         * DumpRenderTree/chromium/TestNavigationController.cpp: Added.
3313         * DumpRenderTree/chromium/TestNavigationController.h: Added.
3314         * DumpRenderTree/chromium/TestWebWorker.h: Added.
3315
3316 2010-03-23  Eric Seidel  <eric@webkit.org>
3317
3318         Reviewed by Adam Barth.
3319
3320         Add support for revision -> build lookup in buildbot.py and layout test result parsing
3321         https://bugs.webkit.org/show_bug.cgi?id=36474
3322
3323         * Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
3324         * Scripts/webkitpy/buildbot.py: 
3325          - Add support for looking up builds by revision number.
3326          - Add support for fetching and parsing results.html files from buildbot.
3327          - build_for_revision has an allow_failed_lookups option to work around the fact that
3328            our buildbot's xmlrpc calls return failure on old revision numbers.
3329          - Add parsing support for twisted directory listings.
3330         * Scripts/webkitpy/buildbot_unittest.py:
3331          - Unit test all the new code.
3332         * Scripts/webkitpy/commands/queries.py:
3333          - Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
3334
3335 2010-03-23  Daniel Bates  <dbates@rim.com>
3336
3337         Reviewed by Adam Roben.
3338
3339         https://bugs.webkit.org/show_bug.cgi?id=36048
3340
3341         Detect if the Windows Platform SDK is missing when building with
3342         Visual C++ Express Edition and inform the user to download it.
3343
3344         * Scripts/webkitdirs.pm:
3345
3346 2010-03-23  Darin Adler  <darin@apple.com>
3347
3348         Tell Subversion about more directories that expect to have .pyc files.
3349
3350         * Scripts/webkitpy: Modified property svn:ignore.
3351         * Scripts/webkitpy/irc: Added property svn:ignore.
3352
3353 2010-03-23  Daniel Bates  <dbates@rim.com>
3354
3355         Reviewed by Adam Barth.
3356
3357         https://bugs.webkit.org/show_bug.cgi?id=36149
3358
3359         Import the GNU readline interface to modify the behavior
3360         of raw_input so as to provide line editing support. In
3361         particular this will prevent "delete" characters from
3362         appearing in the returned value for function raw_input.
3363
3364         * Scripts/webkitpy/user.py:
3365
3366 2010-03-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3367
3368         Reviewed by Kenneth Rohde Christiansen.
3369
3370         [Qt] Remove support for Qt v4.4
3371         https://bugs.webkit.org/show_bug.cgi?id=36389
3372
3373         * DumpRenderTree/qt/main.cpp:
3374         (main):
3375         * QtLauncher/mainwindow.cpp:
3376         (MainWindow::MainWindow):
3377
3378 2010-03-22  Csaba Osztrogon√°c  <ossy@webkit.org>
3379
3380         Reviewed by Adam Barth.
3381
3382         Make build_webkit_command() pass MAKEFLAGS environment variable to make.
3383         https://bugs.webkit.org/show_bug.cgi?id=36440
3384
3385         * Scripts/webkitpy/webkitport.py:
3386         * Scripts/webkitpy/webkitport_unittest.py:
3387
3388 2010-03-22  Dirk Pranke  <dpranke@chromium.org>
3389
3390         Reviewed by Dimitri Glazkov.
3391
3392         Change baseline_path() to point to the upstream locations for the
3393         Chromium ports. Also change the reabselining scripts to use the
3394         correct functions to get the baseline directories, and fix the
3395         script's sys.path to pull in simplejson correctly.
3396
3397         https://bugs.webkit.org/show_bug.cgi?id=36417
3398
3399         * Scripts/rebaseline-chromium-webkit-tests:
3400           - fix sys.path to pick up simplejson properly
3401         * Scripts/webkitpy/layout_tests/port/chromium.py:
3402           - change baseline_path() to use webkit_baseline_path()
3403           - error out correctly if we can't find the chromium base dir
3404         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3405           - call baseline_path(), not chromium_baseline_path()
3406
3407 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
3408
3409         Reviewed by Adam Barth.
3410
3411         Refactored the cpu_count() code in executive.py.
3412
3413         https://bugs.webkit.org/show_bug.cgi?id=36437
3414
3415         * Scripts/webkitpy/executive.py:
3416           - Moved the import of the multiprocessing module to the top
3417             of the file rather than importing from within a function.
3418
3419 2010-03-22 Antonio Gomes <tonikitoo@webkit.org>
3420
3421         Unreviewed.
3422
3423         Rolling out r56183: http://trac.webkit.org/changeset/56183
3424
3425         https://bugs.webkit.org/show_bug.cgi?id=36244
3426
3427         Need to roll out because this patch will be re-worked by the author
3428         and other reviewers agreed on it.
3429
3430 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
3431
3432         Reviewed by Adam Barth.
3433
3434         Created a function for getting a module-specific logging.logger
3435         based on the __file__ value of the module.
3436
3437         https://bugs.webkit.org/show_bug.cgi?id=35821
3438
3439         This function allows us to get the module-specific logger for
3440         a module without having to hard-code the fully-qualified name
3441         of the module in the module itself.  The code can be the same
3442         in every case: "_log = logutils.get_logger(__file__)".
3443
3444         * Scripts/webkitpy/init/logutils.py: Added.
3445           - Added a module with a get_logger() function to return
3446             a module-specific logger based on the module's __file__
3447             variable.
3448
3449         * Scripts/webkitpy/init/logutils_unittest.py: Added.
3450           - Added unit tests for logutils.py.
3451
3452         * Scripts/webkitpy/init/unittests.py:
3453           - Added logutils_unittest to the list of imports.
3454
3455 2010-03-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3456
3457         Reviewed by Simon Hausmann.
3458
3459         [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
3460         https://bugs.webkit.org/show_bug.cgi?id=36386
3461
3462         Fix the regression by implementing a null printer for Qt DRT.
3463
3464         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3465         (WebCore::NullPrinter::NullPaintEngine::begin):
3466         (WebCore::NullPrinter::NullPaintEngine::end):
3467         (WebCore::NullPrinter::NullPaintEngine::type):
3468         (WebCore::NullPrinter::NullPaintEngine::drawPixmap):
3469         (WebCore::NullPrinter::NullPaintEngine::updateState):
3470         (WebCore::NullPrinter::paintEngine):
3471         (WebCore::DumpRenderTree::dryRunPrint):
3472
3473 2010-03-20  Martin Robinson  <mrobinson@webkit.org>
3474
3475         Reviewed by Xan Lopez.
3476
3477         [GTK] eventSender.zoomPageOut() bug?
3478         https://bugs.webkit.org/show_bug.cgi?id=30575
3479
3480         Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.
3481
3482         * DumpRenderTree/gtk/EventSender.cpp:
3483         (zoomIn): Added.
3484         (zoomOut): Added.
3485         (textZoomInCallback): Use zoomIn helper function.
3486         (textZoomOutCallback): Use zoomOut helper function.
3487         (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor.
3488         (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
3489
3490 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
3491
3492         [wx] Build fix after recent database API change.
3493
3494         * wx/browser/browser.cpp:
3495         (MyApp::OnInit):
3496
3497 2010-03-20  Chris Jerdonek  <cjerdonek@webkit.org>
3498
3499         Reviewed by Adam Barth.
3500
3501         Renamed UnitTestLogStream to TestLogStream in webkitpy.
3502
3503         https://bugs.webkit.org/show_bug.cgi?id=36099
3504
3505         TestLogStream is more concise and more consistent with the name of
3506         the module (logtesting rather than logunittesting) and its main
3507         class (LogTesting rather than LogUnitTesting).
3508
3509         * Scripts/webkitpy/init/logtesting.py:
3510           - Renamings.
3511
3512         * Scripts/webkitpy/style/checker_unittest.py:
3513           - Renamings.
3514
3515         * Scripts/webkitpy/style_references.py:
3516           - Renamings.
3517
3518 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
3519
3520         [wx] Build fixes for new method in LayoutTestController.
3521
3522         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3523         (LayoutTestController::setSpatialNavigationEnabled):
3524         * wx/build/settings.py:
3525
3526 2010-03-20  Dimitri Glazkov  <dglazkov@chromium.org>
3527
3528         Unreviewed, tool fix.
3529
3530         Remove vestiges of downstream directory names to unbreak rebaselining tool.
3531
3532         * Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
3533
3534 2010-03-20  Dirk Pranke  <dpranke@chromium.org>
3535
3536         Reviewed by Dimitri Glazkov.
3537
3538         Re-enable the downstream test_expectations overrides file that was
3539         disabled in bug 36396 / r56287.
3540
3541         https://bugs.chromium.org/show_bug.cgi?id=36401
3542
3543         * Scripts/webkitpy/layout_tests/port/chromium.py:
3544
3545 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
3546
3547         Reviewed by Dimitri Glazkov.
3548
3549         Disable the downstream override expectations temporarily to allow
3550         us to test that we've upstreamed everything correctly. Also, stop
3551         looking at the downstream baselines at all (now you will only be
3552         able to update baselines upstream). In theory this should work, but
3553         if we need to we can always add the downstream dirs back in.
3554
3555         https://bugs.webkit.org/show_bug.cgi?id=36396
3556
3557         * Scripts/webkitpy/layout_tests/port/chromium.py:
3558         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3559         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3560         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3561
3562 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
3563
3564         Reviewed by Dimitri Glazkov.
3565
3566         fix typo in chromium test expectations overrides routine
3567         https://bugs.webkit.org/show_bug.cgi?id=36397
3568
3569         * Scripts/webkitpy/layout_tests/port/chromium.py:
3570
3571 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
3572
3573         Reviewed by Dimitri Glazkov.
3574
3575         Flip the Chromium ports to look first for the test expectations
3576         in LayoutTests/platform/chromium and only afterwards look in the
3577         Chromium repo downstream for overrides.
3578
3579         https://bugs.webkit.org/show_bug.cgi?id=36326
3580
3581         * Scripts/webkitpy/layout_tests/port/chromium.py:
3582
3583 2010-03-19  James Hawkins  <jhawkins@chromium.org>
3584
3585         Unreviewed.
3586
3587         Add myself to the committers list.
3588
3589         * Scripts/webkitpy/committers.py:
3590
3591 2010-03-19  Adam Barth  <abarth@webkit.org>
3592
3593         Unreviewed.
3594
3595         Fix SheriffBot exception lock when we can't retrieve the first build
3596         from buildbot.  (I'll ask Eric to review this change after the fact,
3597         but he's at lunch and I want to get the bot unlocked.)
3598
3599         * Scripts/webkitpy/buildbot.py:
3600         * Scripts/webkitpy/buildbot_unittest.py:
3601
3602 2010-03-19  Alexey Proskuryakov  <ap@apple.com>
3603
3604         Reviewed by Darin Adler.
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=36380
3607         websocket/tests/frame-lengths.html times out on Tiger bot
3608
3609         https://bugs.webkit.org/show_bug.cgi?id=35041
3610         websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot
3611
3612         Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
3613         sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
3614         timing out than to detect it early.
3615
3616         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3617         (LayoutTestController::setWaitToDump):
3618         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3619         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3620         (LayoutTestController::waitUntilDone):
3621         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3622         * Scripts/run-webkit-tests:
3623
3624 2010-03-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3625
3626         Unreviewed.
3627
3628         Buildfix for Qt v4.5.
3629
3630         * QtLauncher/main.cpp:
3631         (LauncherWindow::LauncherWindow):
3632         (LauncherWindow::applyZoom):
3633
3634 2010-03-19  Adam Barth  <abarth@webkit.org>
3635
3636         Reviewed by Eric Seidel.
3637
3638         Operational tweaks to SheriffBot
3639         https://bugs.webkit.org/show_bug.cgi?id=36385
3640
3641         These changes aren't pretty, but they're helpful to make SheriffBot
3642         work operationally.  I plan to iterate in these areas, but I wanted to
3643         get this patch landed so I could be running the bot against TOT.
3644
3645         * Scripts/webkitpy/commands/sheriffbot.py:
3646         * Scripts/webkitpy/irc/ircbot.py:
3647         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
3648
3649 2010-03-19  Eric Seidel  <eric@webkit.org>
3650
3651         Reviewed by Adam Barth.
3652
3653         Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
3654         https://bugs.webkit.org/show_bug.cgi?id=36354
3655
3656         * Scripts/webkitpy/buildbot.py:
3657          - Make Build creation easier to Mock and test
3658         * Scripts/webkitpy/buildbot_unittest.py:
3659          - Test finding green to red transitions and suspect revisions
3660         * Scripts/webkitpy/commands/queries.py:
3661          - Make what-broke note when builders have only failed once.
3662
3663 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
3664
3665         Reviewed by Dimitri Glazkov.
3666
3667         Fix the rebaselining tool, which was broken by r36324 when I
3668         added the concept of overridding expectations.
3669
3670         https://bugs.webkit.org/show_bug.cgi?id=36374
3671
3672         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3673
3674 2010-03-19  Adam Barth  <abarth@webkit.org>
3675
3676         Reviewed by Eric Seidel.
3677
3678         Misc bug fixes to make the SheriffBot actually work
3679         https://bugs.webkit.org/show_bug.cgi?id=36355
3680
3681         With these changes, I can actually run the sheriff-bot from start to
3682         finish.
3683
3684         * Scripts/webkitpy/irc/ircproxy.py:
3685         * Scripts/webkitpy/patch/patcher.py:
3686         * Scripts/webkitpy/statusserver.py:
3687
3688 2010-03-19  Adam Barth  <abarth@webkit.org>
3689
3690         Unreviewed.
3691
3692         Actually import the sheriff-bot command so we can run it.  Also, move
3693         the bot to #webkit-test so it doesn't cause a ruckus while we test it.
3694
3695         * Scripts/webkitpy/patch/patcher.py:
3696         * Scripts/webkitpy/irc/ircbot.py:
3697
3698 2010-03-19  Adam Barth  <abarth@webkit.org>
3699
3700         Reviewed by Eric Seidel.
3701
3702         Second cut at SheriffBot
3703         https://bugs.webkit.org/show_bug.cgi?id=36353
3704
3705         This patch should contain a complete SheriffBot that's capable of
3706         saying reasonable things on IRC.  I had to refactor the use of
3707         CommitInfo to make the SheriffBot testable, but I did the minimum
3708         necessary.  We should grow webkitcheckout over time to contain the
3709         knowledge of ChangeLogs from scm.
3710
3711         * Scripts/webkitpy/commands/sheriffbot.py:
3712         * Scripts/webkitpy/commands/sheriffbot_unittest.py:
3713         * Scripts/webkitpy/mock_bugzillatool.py:
3714         * Scripts/webkitpy/patch/patcher.py:
3715         * Scripts/webkitpy/webkitcheckout.py: Added.
3716
3717 2010-03-19  Adam Barth  <abarth@webkit.org>
3718
3719         Unreviewed.
3720
3721         Fix Hyatt's IRC nickname.
3722
3723         * Scripts/webkitpy/committers.py:
3724
3725 2010-03-19  Adam Barth  <abarth@webkit.org>
3726
3727         Unreviewed.
3728
3729         Add IRC nicknames for the non-reviewer committers.
3730
3731         * Scripts/webkitpy/committers.py:
3732
3733 2010-03-19  Adam Barth  <abarth@webkit.org>
3734
3735         Unreviewed.
3736
3737         More reviewer IRC nicknames.
3738
3739         * Scripts/webkitpy/committers.py:
3740
3741 2010-03-19  Adam Barth  <abarth@webkit.org>
3742
3743         Unreviewed.
3744
3745         Add a bunch of IRC nicknames for reviewers.
3746
3747         * Scripts/webkitpy/committers.py:
3748
3749 2010-03-19  Zoltan Horvath  <zoltan@webkit.org>
3750
3751         Reviewed by Oliver Hunt.
3752
3753         Added USE_SYSTEM_MALLOC flag to build-webkit
3754         https://bugs.webkit.org/show_bug.cgi?id=21272
3755
3756         Add system-alloc flag to build-webkit. It makes easy to switch
3757         between system allocator and TCmalloc.
3758
3759         * Scripts/build-webkit:
3760
3761 2010-03-19  Adam Barth  <abarth@webkit.org>
3762
3763         Unreviewed "build" fix.
3764
3765         Of course, I caused a regression in the file that isn't tested.  :(
3766
3767         * Scripts/webkitpy/statusserver.py:
3768
3769 2010-03-19  Eric Seidel  <eric@webkit.org>
3770
3771         Reviewed by Adam Barth.
3772
3773         Add basic "who-broke-it" command and revision -> broken builder association code
3774         https://bugs.webkit.org/show_bug.cgi?id=36352
3775
3776         The "what-broke" command prints builders and what revisions we suspect
3777         broke them.  who-broke-it prints revisions and what builders we suspect
3778         they broke.  The sheriff-bot needs this revision to broken builder mapping
3779         so this change adds it!
3780
3781         * Scripts/webkitpy/buildbot.py:
3782         * Scripts/webkitpy/commands/queries.py:
3783
3784 2010-03-19  Eric Seidel  <eric@webkit.org>
3785
3786         Reviewed by Adam Barth.
3787
3788         Simplify BuildBot core builder code for easier re-use
3789         https://bugs.webkit.org/show_bug.cgi?id=36350
3790
3791         I simply couldn't see anything through all this Yak-hair.
3792
3793         * Scripts/webkitpy/buildbot.py:
3794         * Scripts/webkitpy/commands/queries.py:
3795
3796 2010-03-19  Adam Barth  <abarth@webkit.org>
3797
3798         Reviewed by Eric Seidel.
3799
3800         committers.py should know IRC nicknames
3801         https://bugs.webkit.org/show_bug.cgi?id=36349
3802
3803         I'll add the actual nicknames in another patch.
3804
3805         * Scripts/webkitpy/committers.py:
3806         * Scripts/webkitpy/committers_unittest.py:
3807
3808 2010-03-18  Anders Bakken  <agbakken@gmail.com>
3809
3810         Reviewed by Simon Hausmann.
3811
3812         https://bugs.webkit.org/show_bug.cgi?id=36318
3813
3814         QtLauncher runs as a GuiClient by default in Qt Embedded which will
3815         make it try to connect to an existing GuiServer. This patch makes it
3816         run like a stand-alone app.
3817
3818         * QtLauncher/main.cpp:
3819         (LauncherApplication::LauncherApplication):
3820
3821 2010-03-19  Eric Seidel  <eric@webkit.org>
3822
3823         Reviewed by Adam Barth.
3824
3825         Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
3826         https://bugs.webkit.org/show_bug.cgi?id=36345
3827
3828         * Scripts/webkitpy/buildbot.py:
3829         * Scripts/webkitpy/commands/queries.py:
3830
3831 2010-03-19  Adam Barth  <abarth@webkit.org>
3832
3833         Reviewed by Adam Barth.
3834
3835         Actually pass the IRC password to the IRC object
3836         https://bugs.webkit.org/show_bug.cgi?id=36346
3837
3838         I wanted to do this before, but both patches were in flight.  This
3839         patch finally closes the loop and makes the IRCProxy system complete.
3840
3841         * Scripts/webkitpy/patch/patcher.py:
3842
3843 2010-03-18  Adam Barth  <abarth@webkit.org>
3844
3845         Reviewed by Eric Seidel.
3846
3847         Add a StatusServer front end to the SVNRevision table on QueueStatusServer
3848         https://bugs.webkit.org/show_bug.cgi?id=36344
3849
3850         No test because Browser was too hard to mock.  :(  I couldn't figure
3851         out how to make Mock be a dictionary as well as an object.
3852
3853         * Scripts/webkitpy/statusserver.py:
3854
3855 2010-03-18  Eric Seidel  <eric@webkit.org>
3856
3857         Reviewed by Adam Barth.
3858
3859         Split out CommitInfo class and add unit tests
3860         https://bugs.webkit.org/show_bug.cgi?id=36343
3861
3862         Move more logic out of "what-broke" into a shared CommitInfo
3863         class so that it can be used by other commands and unit tested.
3864
3865         * Scripts/webkitpy/commands/queries.py:
3866         * Scripts/webkitpy/commitinfo.py: Added.
3867         * Scripts/webkitpy/commitinfo_unittest.py: Added.
3868         * Scripts/webkitpy/unittests.py:
3869
3870 2010-03-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3871
3872         Reviewed by Kenneth Rohde Christiansen.
3873
3874         [Qt] Fix LayoutTests/http/tests/appcache/max-size.html
3875         https://bugs.webkit.org/show_bug.cgi?id=36207
3876
3877         Implement setAppCacheMaximumSize() for Qt.
3878
3879         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3880         (LayoutTestController::setAppCacheMaximumSize):
3881         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3882
3883 2010-03-18  Adam Barth  <abarth@webkit.org>
3884
3885         Reviewed by Eric Seidel.
3886
3887         QueueStatusServer should be able to log broken bots
3888         https://bugs.webkit.org/show_bug.cgi?id=36341
3889
3890         We need to add a new table to the QueueStatusServer to store persistent
3891         information for the SheriffBot.  The new table will keep track of which
3892         bots each SVN revision broke.
3893
3894         * QueueStatusServer/handlers/__init__.py:
3895         * QueueStatusServer/handlers/svnrevision.py: Added.
3896         * QueueStatusServer/handlers/updatebase.py: Added.
3897         * QueueStatusServer/handlers/updatestatus.py:
3898         * QueueStatusServer/handlers/updatesvnrevision.py: Added.
3899         * QueueStatusServer/index.yaml:
3900         * QueueStatusServer/main.py:
3901         * QueueStatusServer/model/__init__.py:
3902         * QueueStatusServer/model/svnrevision.py: Added.
3903         * QueueStatusServer/templates/updatesvnrevision.html: Added.
3904
3905 2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3906
3907         Reviewed by Darin Adler.
3908
3909         Add a new method to the Qt LayoutTestController for
3910         changing media type and make the DRT support dry-run printing.
3911
3912         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3913         (WebCore::DumpRenderTree::DumpRenderTree):
3914         (WebCore::DumpRenderTree::dryRunPrint):
3915         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3916         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3917         (LayoutTestController::setMediaType):
3918         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3919
3920 2010-03-18  Dirk Pranke  <dpranke@chromium.org>
3921
3922         Reviewed by Dimitri Glazkov.
3923
3924         Add upstream LayoutTests/platform/chromium* directories to the
3925         baseline search path for new-run-webkit-tests in preparation for
3926         upstreaming all of the Chromium baselines. Note that this does
3927         not actually create the directories themselves, but that's okay.
3928
3929         https://bugs.webkit.org/show_bug.cgi?id=36324
3930
3931         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3932         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3933         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3934
3935 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
3936
3937         Reviewed by Anders Carlsson.
3938
3939         https://bugs.webkit.org/show_bug.cgi?id=36327
3940         Test that a plug-in can override Node methods of its element
3941
3942         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3943         (normalizeOverride):
3944         (pluginInvoke):
3945         Override "normalize", and call back to let a test know that the plug-in was called.
3946
3947 2010-03-17  Dirk Pranke  <dpranke@chromium.org>
3948
3949         Reviewed by Dimitri Glazkov.
3950
3951         Add the concept of an "overrides" file for expectations so that we
3952         can store test_expectations both upstream and downstream for a port
3953         that runs both in webkit.org and in a separate repository (like
3954         Chromium). Also add some unit tests for the expectations module.
3955
3956         https://bugs.webkit.org/show_bug.cgi?id=36249
3957
3958         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3959         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added.
3960         * Scripts/webkitpy/layout_tests/port/base.py:
3961         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3962
3963 2010-03-18  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3964
3965         Reviewed by Kenneth Rohde Christiansen.
3966
3967         Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info
3968         on the launcher and not on the terminal anymore.
3969
3970         [Qt] QtLauncher's FPS info should be displayed on an overlay text item
3971         https://bugs.webkit.org/show_bug.cgi?id=36244
3972
3973         * QtLauncher/webview.cpp:
3974         (WebViewGraphicsBased::WebViewGraphicsBased):
3975         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
3976         (WebViewGraphicsBased::updateFrameRate):
3977         * QtLauncher/webview.h:
3978
3979 2010-03-18  Adam Barth  <abarth@webkit.org>
3980
3981         Reviewed by Eric Seidel.
3982
3983         First cut at SheriffBot
3984         https://bugs.webkit.org/show_bug.cgi?id=36253
3985
3986         This patch contains a first attempt at writing a sheriff bot.
3987         Currently, we're missing the logic that actually finds the SVN revision
3988         numbers to complain about, but once we have that, we'll have the rest
3989         of the infrustructure to ping IRC and to file bugs.
3990
3991         There's a lot to fill in for the SheriffBot, but this patch give us the
3992         framework in which to do it.
3993
3994         This patch required a bit of refactoring of AbstractQueue because
3995         SheriffBot is the first bot that doesn't process patches (it processes
3996         SVN revisions).  Accordingly, I've factored out AbstractPatchQueue to
3997         hold the parts of AbstractQueue that are specific to dealing with
3998         patches.  Some of the choices here might not be obvious yet, but we can
3999         tweak them as our needs become clearer.
4000
4001         * Scripts/webkitpy/commands/queues.py:
4002         * Scripts/webkitpy/commands/queues_unittest.py:
4003         * Scripts/webkitpy/commands/sheriffbot.py: Added.
4004         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
4005         * Scripts/webkitpy/mock_bugzillatool.py:
4006             Added a MockIRC object to the mock tool.
4007         * Scripts/webkitpy/multicommandtool.py:
4008             Added a finalize method so the tool can disconnect from IRC
4009             cleanly instead of just droping the socket.
4010         * Scripts/webkitpy/multicommandtool_unittest.py:
4011         * Scripts/webkitpy/patch/patcher.py:
4012             Added support for talking to IRC.
4013         * Scripts/webkitpy/unittests.py:
4014             We should add a commands/unittests.py file at some point to make
4015             the commands module more self-contained.
4016
4017 2010-03-18  Antti Koivisto  <koivisto@iki.fi>
4018
4019         Reviewed by Kenneth Rohde Christiansen.
4020
4021         https://bugs.webkit.org/show_bug.cgi?id=36102
4022         [Qt] Scaling control API for tiled backing store
4023         
4024         Add animated smooth zooming to Qt launcher when in tiled mode.
4025
4026         * QtLauncher/main.cpp:
4027         (LauncherWindow::LauncherWindow):
4028         (LauncherWindow::zoomAnimationFinished):
4029         (LauncherWindow::applyZoom):
4030         (LauncherWindow::zoomIn):
4031         (LauncherWindow::zoomOut):
4032         * QtLauncher/webview.h:
4033         (WebViewGraphicsBased::graphicsWebView):
4034
4035 2010-03-18  Adam Barth  <abarth@webkit.org>
4036
4037         Reviewed by Eric Seidel.
4038
4039         Support using IRC accounts with a password
4040         https://bugs.webkit.org/show_bug.cgi?id=36287
4041
4042         Add a global option to specify an IRC password so we can use the
4043         sheriffbot account (which needs a password).
4044
4045         * Scripts/webkitpy/irc/ircbot.py:
4046         * Scripts/webkitpy/irc/ircproxy.py:
4047         * Scripts/webkitpy/patch/patcher.py:
4048
4049 2010-03-18  Eric Seidel  <eric@webkit.org>
4050
4051         Just fixing missing parenthesis typo, no review.
4052
4053         * Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses.
4054
4055 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
4056
4057         Reviewed by Adam Roben and Anders Carlsson.
4058
4059         https://bugs.webkit.org/show_bug.cgi?id=36210
4060         plugins/resize-from-plugin.html fails on some platforms
4061
4062         Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for
4063         the test to their versions of the file.
4064
4065         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4066         (webkit_test_plugin_set_window):
4067         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
4068         (NPP_SetWindow):
4069
4070 2010-03-18  Leandro Pereira  <leandro@profusion.mobi>
4071
4072         Reviewed by Kenneth Rohde Christiansen.
4073
4074         Add support to run-launcher to open the EFL example browser.
4075         http://webkit.org/b/36181
4076
4077         * Scripts/webkitdirs.pm:
4078         * Scripts/run-launcher:
4079
4080 2010-03-18  Sergio Villar Senin  <svillar@igalia.com>
4081
4082         Reviewed by Xan Lopez.
4083
4084         [GTK] Failing tests http/tests/misc/image-blocked-src-change.html
4085         & http/tests/misc/image-blocked-src-no-change.html
4086         https://bugs.webkit.org/show_bug.cgi?id=36227
4087
4088         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4089         (webViewConsoleMessage): print only the file name instead of the
4090         whole URI when printing messages with local URI's
4091
4092 2010-03-18  Eric Seidel  <eric@webkit.org>
4093
4094         Reviewed by Adam Barth.
4095
4096         Teach what-broke how to look up reviewer and author Committer objects by name
4097         https://bugs.webkit.org/show_bug.cgi?id=36264
4098
4099         * Scripts/webkitpy/commands/queries.py:
4100          - Add committer_by_name lookups for both reviewer and author
4101          - Improve printing in the cases where lookups fail.
4102         * Scripts/webkitpy/committers.py:
4103          - Add committer_by_name
4104         * Scripts/webkitpy/committers_unittest.py:
4105          - Test committer_by_name
4106
4107 2010-03-17  Adam Barth  <abarth@webkit.org>
4108
4109         Reviewed by Eric Seidel.
4110
4111         create-rollout should actually fill out the description
4112         https://bugs.webkit.org/show_bug.cgi?id=36261
4113
4114         * Scripts/webkitpy/commands/download.py:
4115             The % operator was applied to the wrong string.
4116         * Scripts/webkitpy/commands/download_unittest.py:
4117         * Scripts/webkitpy/commands/upload_unittest.py:
4118         * Scripts/webkitpy/mock_bugzillatool.py:
4119             Add support for seeing what we actually do with create_bug.
4120
4121 2010-03-17  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
4122
4123         Reviewed by Kenneth Rohde Christiansen.
4124
4125         Accelerated Compositing is now default on QtWebKit so the option
4126         in QtLauncher must be true as default.
4127
4128         [Qt] QtLauncher's Accelerated Compositing option must be true as default
4129         https://bugs.webkit.org/show_bug.cgi?id=36234
4130
4131         * QtLauncher/main.cpp:
4132         (LauncherWindow::applyPrefs):
4133         (LauncherWindow::toggleAcceleratedCompositing):
4134         (LauncherApplication::handleUserOptions):
4135
4136 2010-03-17  Adam Barth  <abarth@webkit.org>
4137
4138         Reviewed by Eric Seidel.
4139
4140         Commit queue should ignore (probably red) builders when landing rollouts
4141         https://bugs.webkit.org/show_bug.cgi?id=36169
4142
4143         When landing a rollout, the builders are probably red, so we need to
4144         ignore them in the subprocess too.  Also, we might as well update the
4145         working copy because we haven't validated anything about the current
4146         revision prior to trying to land.
4147
4148         This change is testable, but it requires changing the mock executive to
4149         log its arguments.  That will generate a lot of expectation changes, so
4150         I'd like to do that in a separate patch.
4151
4152         * Scripts/webkitpy/commands/queues.py:
4153
4154 2010-03-17  Chang Shu  <chang.shu@nokia.com>
4155
4156         Reviewed by Laszlo Gombos.
4157
4158         https://bugs.webkit.org/show_bug.cgi?id=36139
4159         [Qt] Clean up cache each time DumpRenderTree starts. This behavior 
4160         matches other platforms, such as mac and gtk.
4161
4162         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4163         (WebCore::DumpRenderTree::DumpRenderTree):
4164
4165 2010-03-17  Adam Barth  <abarth@webkit.org>
4166
4167         Unreviewed.
4168
4169         Turns out this needs to be a string.
4170
4171         * Scripts/webkitpy/bugzilla.py:
4172
4173 2010-03-17  Eric Seidel  <eric@webkit.org>
4174
4175         Reviewed by Adam Barth.
4176
4177         Add more infrastructure for sheriff-bot, including making what-broke more awesome
4178         https://bugs.webkit.org/show_bug.cgi?id=36254
4179
4180         * Scripts/webkitpy/bugzilla.py:
4181          - Made the various URL methods return None when passed None.
4182         * Scripts/webkitpy/bugzilla_unittest.py:
4183          - Test that the url methods work as expected.
4184         * Scripts/webkitpy/buildbot.py:
4185          - Add a static Build.build_url so that its possible to generate a build url without a Build object.
4186          - Give users a URL in _fetch_xmlrpc_build_dictionary error message.
4187         * Scripts/webkitpy/changelogs.py:
4188          - Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
4189          - Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
4190          - Make ChangeLog.parse_latest_entry_from_file a public method.
4191         * Scripts/webkitpy/changelogs_unittest.py:
4192          - Add tests for new ChangeLog entry parsing.
4193         * Scripts/webkitpy/commands/queries.py:
4194          - Make "what-broke" not print "ok" builders, only failing ones.
4195          - Print much more information on failing builders, including links and authorship/reviewer information.
4196         * Scripts/webkitpy/commands/queues_unittest.py:
4197          - Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
4198         * Scripts/webkitpy/mock_bugzillatool.py:
4199          - Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
4200         * Scripts/webkitpy/patch/patcher.py:
4201          - Remove code which was broken now that this file has moved.
4202          - Code was also redundant now that SCM.find_checkout_root() exists.
4203         * Scripts/webkitpy/scm.py:
4204          - Greatly simplify modified_changelogs now that I understand list comprehensions.
4205          - Expect ChangeLogEntry objects instead of raw strings.
4206          - Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
4207          - Add commit_with_message argument to all sites since someone half-added it before. :(
4208          - Get rid of copy/paste code using _status_regexp()
4209         * Scripts/webkitpy/scm_unittest.py:
4210          - Fix these tests!
4211          - Add new tests for new scm code.
4212          - Fix spelling of "awsome" to "awesome".
4213
4214 2010-03-17  Daniel Bates  <dbates@rim.com>
4215
4216         Rubber-stamped by David Levin.
4217
4218         Add myself to the list of reviewers.
4219
4220         * Scripts/webkitpy/committers.py:
4221
4222 2010-03-17  Adam Barth  <abarth@webkit.org>
4223
4224         Reviewed by Eric Seidel.
4225
4226         Change post-rollout to create-rollout and have it make a new bug
4227         instead of posting the rollout to the old bug.
4228         https://bugs.webkit.org/show_bug.cgi?id=36250
4229
4230         The new bug blocks the old bug instead of adding more complexity to the
4231         old bug.  One tricky question is whether to create the bug if we're
4232         unable to create a rollout patch.  In this patch, we do create the bug,
4233         but we might revist this question in the future.
4234
4235         * Scripts/webkitpy/bugzilla.py:
4236         * Scripts/webkitpy/commands/download.py:
4237         * Scripts/webkitpy/commands/download_unittest.py:
4238         * Scripts/webkitpy/steps/createbug.py:
4239
4240 2010-03-17  Adam Barth  <abarth@webkit.org>
4241
4242         Reviewed by Eric Seidel.
4243
4244         Add a way for the bots to send messages to IRC
4245         https://bugs.webkit.org/show_bug.cgi?id=36235
4246
4247         We'll use these classes to notify #webkit about bad SVN revisions.
4248         This patch just has some skeleton code for us to play with.
4249
4250         * Scripts/webkitpy/irc/__init__.py: Added.
4251         * Scripts/webkitpy/irc/ircbot.py: Added.
4252             A bot that knows how to talk to IRC.
4253         * Scripts/webkitpy/irc/ircproxy.py: Added.
4254             We need to run the bot on its own thread because the irclib needs
4255             its own mainloop.  This class provides an abstraction of the
4256             threading.
4257         * Scripts/webkitpy/irc/messagepump.py: Added.
4258         * Scripts/webkitpy/irc/messagepump_unittest.py: Added.
4259         * Scripts/webkitpy/irc/threadedmessagequeue.py: Added.
4260             A thread-safe message queue for sending messages from the main
4261             thread to the IRC thread.
4262         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added.
4263         * Scripts/webkitpy/irc/unittests.py: Added.
4264         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
4265             Autoinstall irclib
4266         * Scripts/webkitpy/unittests.py:
4267
4268 2010-03-17  Victor Wang  <victorw@chromium.org>
4269
4270         Reviewed by Dimitri Glazkov.
4271
4272         Fix image_diff syntax in webkitpy/port/base.py.
4273         The syntax is wrong if diff_filename is specified.
4274
4275         https://bugs.webkit.org/show_bug.cgi?id=36230
4276
4277         * Scripts/webkitpy/layout_tests/port/base.py:
4278
4279 2010-03-16  Diego Gonzalez  <diego.gonzalez@openbossa.org>
4280
4281         Reviewed by Kenneth Christiansen.
4282
4283         Provide to QtLauncher a way to change the ViewportUpdateMode
4284         when it's in graphics based mode.
4285
4286         [Qt] Make QtLaucher able to select the ViewportUpdateMode
4287         https://bugs.webkit.org/show_bug.cgi?id=36175
4288
4289         * QtLauncher/main.cpp:
4290         (LauncherWindow::selectViewportUpdateMode):
4291         (LauncherWindow::createChrome):
4292
4293 2010-03-17  Zoltan Horvath  <zoltan@webkit.org>
4294
4295         Reviewed by Darin Adler.