Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
[WebKit.git] / WebKitTools / ChangeLog
1 2010-09-11  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Dan Bernstein.
4
5         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
6         <rdar://problem/8359252>
7         https://bugs.webkit.org/show_bug.cgi?id=45605
8
9         * MiniBrowser/mac/BrowserWindowController.m:
10         (setStatusText):
11         (contentsSizeChanged):
12         (-[BrowserWindowController awakeFromNib]):
13         * MiniBrowser/win/BrowserView.cpp:
14         (runJavaScriptConfirm):
15         (runJavaScriptPrompt):
16         (setStatusText):
17         (contentsSizeChanged):
18         (BrowserView::create):
19         * WebKitTestRunner/TestController.cpp:
20         (WTR::createOtherPage):
21         (WTR::TestController::initialize):
22
23 2010-09-11  Sam Weinig  <sam@webkit.org>
24
25         Reviewed by Dan Bernstein.
26
27         Add callback mechanism for the getting the source of a frame
28         <rdar://problem/8364681>
29         https://bugs.webkit.org/show_bug.cgi?id=45604
30
31         Add ability to dump the main frame's source to the console.
32
33         * MiniBrowser/mac/BrowserWindowController.h:
34         * MiniBrowser/mac/BrowserWindowController.m:
35         (-[BrowserWindowController dumpSourceToConsole:]):
36         * MiniBrowser/mac/MainMenu.xib:
37
38 2010-09-11  Eric Seidel  <eric@webkit.org>
39
40         Reviewed by Adam Barth.
41
42         Remove unneeded Empty Queue messages
43         https://bugs.webkit.org/show_bug.cgi?id=45602
44
45         We already have a /gc job to delete these.
46         recentstatus.py is already smart enough to use the
47         most recent of the workitems last update or the most recent status,
48         so removing these should not change the _last_status_date() return
49         value more than a few milliseconds.
50
51         These messages just spam the recent status log.
52
53         * Scripts/webkitpy/tool/commands/queues.py:
54
55 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
56
57         Reviewed by Adam Barth.
58
59         Fix Python exception when generating synthetic patch IDs
60         https://bugs.webkit.org/show_bug.cgi?id=45592
61
62         Can't concatenate strings and numbers directly.
63
64         * QueueStatusServer/handlers/queuestatus.py:
65
66 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
67
68         Reviewed by Adam Barth.
69
70         Group statuses in queue status by patch ID
71         https://bugs.webkit.org/show_bug.cgi?id=45588
72
73         Group statuses by patch ID so that the status page is easier
74         to scan.
75
76         * QueueStatusServer/handlers/queuestatus.py:
77         * QueueStatusServer/stylesheets/dashboard.css:
78         (.status-group):
79         (.status-bug):
80         (.status-group ul):
81         (.status-group ul li):
82         (.status-group ul li:hover):
83         (.status-cell):
84         (.status-cell:hover):
85         (.status-cell.pass):
86         (.status-cell.fail):
87         (.status-cell.pending):
88         (.status-cell.error):
89         * QueueStatusServer/templates/dashboard.html:
90         * QueueStatusServer/templates/queuestatus.html:
91
92 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
93
94         Reviewed by Tony Chang.
95
96         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
97         https://bugs.webkit.org/show_bug.cgi?id=45479
98
99         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
100         implementation in ResourceLoadDelegate in the Mac port).
101
102         * DumpRenderTree/chromium/LayoutTestController.cpp:
103         (LayoutTestController::LayoutTestController):
104         (LayoutTestController::dumpResourceResponseMIMETypes):
105         (LayoutTestController::reset):
106         * DumpRenderTree/chromium/LayoutTestController.h:
107         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
108         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
109         * DumpRenderTree/chromium/TestShell.h:
110         (TestShell::shouldDumpResourceResponseMIMETypes):
111         * DumpRenderTree/chromium/WebViewHost.cpp:
112         (WebViewHost::didReceiveResponse):
113
114 2010-09-11  Eric Seidel  <eric@webkit.org>
115
116         Reviewed by Adam Barth.
117
118         queues.webkit.org should expose /remote_api for data upload/download
119         https://bugs.webkit.org/show_bug.cgi?id=45559
120
121         * QueueStatusServer/app.yaml:
122          - /remote_api is a standard app-engine service which allows use of
123            the bulk uploader for data upload/download.  Exposing this
124            (for admin access only) allows us to use 
125
126 2010-09-10  Sam Weinig  <sam@webkit.org>
127
128         Reviewed by Dan Bernstein.
129
130         Add zoom support to WebKit2 API
131         <rdar://problem/7660657>
132         https://bugs.webkit.org/show_bug.cgi?id=45585
133
134         - Add zoom options to MiniBrowser that mimic Safari's options using
135           the new WebKit2 zoom APIs.
136         - Switch uses of float for the zoom APIs to use double.
137
138         * MiniBrowser/mac/BrowserWindowController.h:
139         * MiniBrowser/mac/BrowserWindowController.m:
140         (-[BrowserWindowController initWithPageNamespace:]):
141         (-[BrowserWindowController validateMenuItem:]):
142         (-[BrowserWindowController validateUserInterfaceItem:]):
143         (-[BrowserWindowController currentZoomFactor]):
144         (-[BrowserWindowController setCurrentZoomFactor:]):
145         (-[BrowserWindowController canZoomIn]):
146         (-[BrowserWindowController zoomIn:]):
147         (-[BrowserWindowController canZoomOut]):
148         (-[BrowserWindowController zoomOut:]):
149         (-[BrowserWindowController canResetZoom]):
150         (-[BrowserWindowController resetZoom:]):
151         (-[BrowserWindowController toggleZoomMode:]):
152         * MiniBrowser/mac/MainMenu.xib:
153         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
154         (WTR::EventSendingController::textZoomIn):
155         (WTR::EventSendingController::textZoomOut):
156         (WTR::EventSendingController::zoomPageIn):
157         (WTR::EventSendingController::zoomPageOut):
158
159 2010-09-10  Robert Hogan  <robert@webkit.org>
160
161         Reviewed by Andreas Kling.
162
163         [Qt] Fix crash in DRT in standalone mode
164
165         https://bugs.webkit.org/show_bug.cgi?id=45454
166
167         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
168         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
169
170 2010-09-10  Sam Weinig  <sam@webkit.org>
171
172         Reviewed by Darin Adler.
173
174         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
175         Precursor to <rdar://problem/7660657>
176         https://bugs.webkit.org/show_bug.cgi?id=45522
177
178         Update for changes to the Bundle API to allow separate control of page and text zoom
179         levels.
180
181         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
182         (WTR::EventSendingController::textZoomIn):
183         (WTR::EventSendingController::textZoomOut):
184         (WTR::EventSendingController::zoomPageIn):
185         (WTR::EventSendingController::zoomPageOut):
186         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
187         (WTR::InjectedBundlePage::reset):
188
189 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
190
191         Reviewed by Andreas Kling.
192
193         [Qt] Support click event for notifications
194         https://bugs.webkit.org/show_bug.cgi?id=44836
195
196         Add support for simulateDesktopNotificationClick by calling
197         back to DumpRenderTreeSupportQt.cpp.
198
199         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
200         (LayoutTestController::simulateDesktopNotificationClick):
201         * DumpRenderTree/qt/LayoutTestControllerQt.h:
202
203 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
204
205         Reviewed by Eric Seidel.
206
207         Update queue status when patches fail their first land attempt
208         https://bugs.webkit.org/show_bug.cgi?id=45583
209
210         Add a few more _update_status calls to make it more obvious if a patch is 
211         being retried because tests failed.
212
213         * Scripts/webkitpy/tool/commands/queues.py:
214
215 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
216
217         Reviewed by Andreas Kling.
218
219         [Qt] MiniBrowser crashes with multiply windows when closing one of them
220         https://bugs.webkit.org/show_bug.cgi?id=45536
221
222         * MiniBrowser/qt/BrowserView.cpp:
223         (BrowserView::BrowserView): Reference the context instead of adopting it
224         because it can be shared across different views.
225
226 2010-09-10  Tony Chang  <tony@chromium.org>
227
228         Unreviewed, rolling out r67241.
229         http://trac.webkit.org/changeset/67241
230         https://bugs.webkit.org/show_bug.cgi?id=44709
231
232         Accidentally committed.
233
234         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
235         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
236
237 2010-09-10  Tony Chang  <tony@chromium.org>
238
239         Reviewed by Ojan Vafai.
240
241         deduplicate-tests should be runnable from any WebKit directory
242         https://bugs.webkit.org/show_bug.cgi?id=44709
243
244         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
245         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
246
247 2010-09-10  Tony Chang  <tony@chromium.org>
248
249         Unreviewed, rolling out r67216.
250         http://trac.webkit.org/changeset/67216
251         https://bugs.webkit.org/show_bug.cgi?id=44709
252
253         Broke
254
255         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
256         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
257
258 2010-09-10  Tony Chang  <tony@chromium.org>
259
260         Reviewed by Ojan Vafai.
261
262         deduplicate-tests should be runnable from any WebKit directory
263         https://bugs.webkit.org/show_bug.cgi?id=44709
264
265         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
266         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
267
268 2010-09-09  Hans Wennborg  <hans@chromium.org>
269
270         Reviewed by Jeremy Orlow.
271
272         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
273         https://bugs.webkit.org/show_bug.cgi?id=45460
274
275         This enables DumpRenderTree to run layout tests for DeviceOrientation.
276
277         Also declare the LayoutTestController destructor out-of-line.
278         Otherwise the implicit destructor would cause compiler errors because
279         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
280
281         * DumpRenderTree/chromium/LayoutTestController.cpp:
282         (LayoutTestController::~LayoutTestController):
283         (LayoutTestController::setMockDeviceOrientation):
284         (LayoutTestController::deviceOrientationClient):
285         * DumpRenderTree/chromium/LayoutTestController.h:
286         * DumpRenderTree/chromium/WebViewHost.cpp:
287         (WebViewHost::deviceOrientationClient):
288         * DumpRenderTree/chromium/WebViewHost.h:
289
290 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
291
292         Unreviewed, rolling out r67119.
293         http://trac.webkit.org/changeset/67119
294         https://bugs.webkit.org/show_bug.cgi?id=45505
295
296         Extra newlines in results (Requested by tony^work on #webkit).
297
298         * DumpRenderTree/chromium/LayoutTestController.cpp:
299         (LayoutTestController::LayoutTestController):
300         (LayoutTestController::reset):
301         * DumpRenderTree/chromium/LayoutTestController.h:
302         * DumpRenderTree/chromium/TestShell.h:
303         * DumpRenderTree/chromium/WebViewHost.cpp:
304         (printResponseDescription):
305         (printNodeDescription):
306         (printRangeDescription):
307         (WebViewHost::shouldBeginEditing):
308         (WebViewHost::shouldEndEditing):
309         (WebViewHost::shouldInsertNode):
310         (WebViewHost::shouldChangeSelectedRange):
311         (WebViewHost::shouldDeleteRange):
312         (WebViewHost::shouldApplyStyle):
313         (WebViewHost::didBeginEditing):
314         (WebViewHost::didChangeSelection):
315         (WebViewHost::didChangeContents):
316         (WebViewHost::didEndEditing):
317         (WebViewHost::decidePolicyForNavigation):
318         (WebViewHost::didCancelClientRedirect):
319         (WebViewHost::didStartProvisionalLoad):
320         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
321         (WebViewHost::didFailProvisionalLoad):
322         (WebViewHost::didCommitProvisionalLoad):
323         (WebViewHost::didFinishDocumentLoad):
324         (WebViewHost::didHandleOnloadEvents):
325         (WebViewHost::didFailLoad):
326         (WebViewHost::didFinishLoad):
327         (WebViewHost::didChangeLocationWithinPage):
328         (WebViewHost::willSendRequest):
329         (WebViewHost::didReceiveResponse):
330         (WebViewHost::didFinishResourceLoad):
331         (WebViewHost::didFailResourceLoad):
332         (WebViewHost::didDisplayInsecureContent):
333         (WebViewHost::didRunInsecureContent):
334         (WebViewHost::printFrameDescription):
335
336 2010-09-09  Michael Saboff  <msaboff@apple.com>
337
338         Unreviewed, adding myself to committers list.
339
340         * Scripts/webkitpy/common/config/committers.py:
341
342 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
343
344         Reviewed by Tony Chang.
345
346         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
347         https://bugs.webkit.org/show_bug.cgi?id=45479
348
349         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
350         implementation in ResourceLoadDelegate in the Mac port).
351
352         * DumpRenderTree/chromium/LayoutTestController.cpp:
353         (LayoutTestController::LayoutTestController):
354         (LayoutTestController::dumpResourceResponseMIMETypes):
355         (LayoutTestController::reset):
356         * DumpRenderTree/chromium/LayoutTestController.h:
357         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
358         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
359         * DumpRenderTree/chromium/TestShell.h:
360         (TestShell::shouldDumpResourceResponseMIMETypes):
361         * DumpRenderTree/chromium/WebViewHost.cpp:
362         (WebViewHost::didReceiveResponse):
363
364 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
365
366         Reviewed by Daniel Bates.
367
368         svn-apply tries to delete directories it shouldn't
369         https://bugs.webkit.org/show_bug.cgi?id=45424
370
371         isDirectoryEmptyForRemoval had the wrong check. If an item in the
372         directory is itself a directory, then the directory is definitely
373         not empty.
374
375         * Scripts/svn-apply:
376
377 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
378
379         Fixing GTK and windows build failure.
380
381         AX: Support AccessibilityTextMarkers in DRT
382         https://bugs.webkit.org/show_bug.cgi?id=44778
383
384         * DumpRenderTree/AccessibilityTextMarker.h:
385         (AccessibilityTextMarker::platformTextMarker):
386         (AccessibilityTextMarkerRange::platformTextMarkerRange):
387         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
388         (AccessibilityTextMarker::platformTextMarker):
389         (AccessibilityTextMarkerRange::platformTextMarkerRange):
390
391 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
392
393         Reviewed by David Kilzer.
394
395         AX: Support AccessibilityTextMarkers in DRT
396         https://bugs.webkit.org/show_bug.cgi?id=44778
397
398         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
399         that WebCore uses when vending information about its VisiblePositions through AX.
400
401         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
402         methods for encapsulating and checking equality.
403
404         This will allow future bug fixes in the text marker system to be adequately tested.
405
406         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
407         (toTextMarker):
408         (isMarkerEqualCallback):
409         (markerFinalize):
410         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
411         (AccessibilityTextMarker::getJSClass):
412         (toTextMarkerRange):
413         (isMarkerRangeEqualCallback):
414         (markerRangeFinalize):
415         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
416         (AccessibilityTextMarkerRange::getJSClass):
417         * DumpRenderTree/AccessibilityTextMarker.h: Added.
418         (AccessibilityTextMarker::platformTextMarker):
419         (AccessibilityTextMarkerRange::platformTextMarkerRange):
420         (AccessibilityTextMarker::AccessibilityTextMarker):
421         (AccessibilityTextMarker::~AccessibilityTextMarker):
422         (AccessibilityTextMarker::isEqual):
423         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
424         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
425         (AccessibilityTextMarkerRange::isEqual):
426         * DumpRenderTree/AccessibilityUIElement.cpp:
427         (textMarkerRangeForElementCallback):
428         (textMarkerRangeLengthCallback):
429         (textMarkerRangeForMarkersCallback):
430         (startTextMarkerForTextMarkerRangeCallback):
431         (endTextMarkerForTextMarkerRangeCallback):
432         (accessibilityElementForTextMarkerCallback):
433         (AccessibilityUIElement::textMarkerRangeForElement):
434         (AccessibilityUIElement::textMarkerRangeLength):
435         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
436         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
437         (AccessibilityUIElement::accessibilityElementForTextMarker):
438         (AccessibilityUIElement::getJSClass):
439         * DumpRenderTree/AccessibilityUIElement.h:
440         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
441         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
442         (AccessibilityTextMarker::AccessibilityTextMarker):
443         (AccessibilityTextMarker::~AccessibilityTextMarker):
444         (AccessibilityTextMarker::isEqual):
445         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
446         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
447         (AccessibilityTextMarkerRange::isEqual):
448         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
449         (AccessibilityUIElement::textMarkerRangeForElement):
450         (AccessibilityUIElement::textMarkerRangeLength):
451         (AccessibilityUIElement::textMarkerRangeForMarkers):
452         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
453         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
454         (AccessibilityUIElement::accessibilityElementForTextMarker):
455         * DumpRenderTree/win/DumpRenderTree.vcproj:
456
457 2010-08-25  Tony Chang  <tony@chromium.org>
458
459         Reviewed by Ojan Vafai.
460
461         don't delete duplicates needed because of intermediate results
462         https://bugs.webkit.org/show_bug.cgi?id=44653
463
464         Also, output the full path so we can pipe the output to rm.
465
466         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
467         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
468
469 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
470
471         Reviewed by Andreas Kling.
472
473         [Qt] MiniBrowser does not starts properly
474         https://bugs.webkit.org/show_bug.cgi?id=45459
475
476         Do not try set up the first window by calling newWindow on a
477         newly created BrowserWindow since it creates a new object.
478         * MiniBrowser/qt/BrowserWindow.cpp:
479         (BrowserWindow::BrowserWindow):
480         * MiniBrowser/qt/main.cpp:
481         (main):
482
483 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
484
485         Reviewed by Xan Lopez.
486
487         [GTK] Get ImageDiff building on Win32
488         https://bugs.webkit.org/show_bug.cgi?id=45353
489
490         * DumpRenderTree/gtk/ImageDiff.cpp:
491         (main): Switch from using strtok to g_strsplit.
492
493 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
494
495         Reviewed by Andreas Kling.
496
497         [Qt] Modify load method of MiniBrowser's BrowserView class
498         https://bugs.webkit.org/show_bug.cgi?id=45442
499
500         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
501
502         * MiniBrowser/qt/BrowserView.cpp:
503         (BrowserView::load):
504         * MiniBrowser/qt/BrowserView.h:
505         * MiniBrowser/qt/BrowserWindow.cpp:
506         (BrowserWindow::load):
507
508 2010-09-09  Tony Chang  <tony@chromium.org>
509
510         Reviewed by Ojan Vafai.
511
512         fix show_results in new-run-webkit-tests
513         https://bugs.webkit.org/show_bug.cgi?id=45413
514
515         * Scripts/webkitpy/layout_tests/port/chromium.py:
516
517 2010-09-08  Victor Wang  <victorw@chromium.org>
518
519         Reviewed by Ojan Vafai.
520
521         [Chromium] Fix test results server to make sure
522         it does not have corrupted data.
523
524         results.json file size coulbe be >1M and we split
525         the data into multiple data store entries in this
526         case. This patch fixes the issue that the data may
527         be corrupted if data store error happens in the middle
528         of saving multiple entries.
529
530         https://bugs.webkit.org/show_bug.cgi?id=45063
531
532         * TestResultServer/model/datastorefile.py:
533
534 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
535
536         Reviewed by Kenneth Rohde Christiansen.
537
538         Fix ignoring return value warning in case of gcc 4.4.4
539         https://bugs.webkit.org/show_bug.cgi?id=45384
540
541         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
542         (testPostURLFile):
543         If fwrite have written zero byte then the testPostURLFile function
544         returns with false as tempFile can't be opened.
545         * DumpRenderTree/qt/ImageDiff.cpp:
546         (main):
547         Put fwrite function into an if condition without body to avoid
548         warning. It is safe because this function writes to the stdout.
549
550 2010-09-08  Satish Sampath  <satish@chromium.org>
551
552         Unreviewed, adding myself to committers list.
553
554         * Scripts/webkitpy/common/config/committers.py:
555
556 2010-09-08  Hans Wennborg  <hans@chromium.org>
557
558         Unreviewed.
559
560         Adding myself as a committer in committers.py.
561
562         * Scripts/webkitpy/common/config/committers.py:
563
564 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
565
566         Reviewed by Simon Hausmann.
567
568         [Qt] Refactor MiniBrowser 
569         https://bugs.webkit.org/show_bug.cgi?id=45173
570
571         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
572
573         * MiniBrowser/qt/BrowserView.cpp: Added.
574         (createNewPage):
575         (BrowserView::BrowserView):
576         (BrowserView::resizeEvent):
577         (BrowserView::load):
578         (BrowserView::view):
579         * MiniBrowser/qt/BrowserView.h: Added.
580         (BrowserView::~BrowserView):
581         * MiniBrowser/qt/BrowserWindow.cpp:
582         * MiniBrowser/qt/BrowserWindow.h:
583         * MiniBrowser/qt/MiniBrowser.pro:
584
585 2010-09-08  Adam Barth  <abarth@webkit.org>
586
587         Rubber-stamped by Eric Seidel.
588
589         Rename DocLoader to CachedResourceLoader because that's what it does.
590
591         * Scripts/do-webcore-rename:
592
593 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
594
595         Reviewed by Ojan Vafai.
596
597         Enable incremental results.json generation for non-layout tests.
598         https://bugs.webkit.org/show_bug.cgi?id=45315
599
600         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
601
602         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
603
604
605 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
606
607         Unreviewed, build fix
608
609         Missed one test in mac_unittest.py in previous change; for some
610         reason the method is listed twice. I will fix both for now, but will
611         figure this out in a later, not-time-sensitive patch.
612
613         https://bugs.webkit.org/show_bug.cgi?id=45357
614
615         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
616
617 2010-09-07  Kent Tamura  <tkent@chromium.org>
618
619         Reviewed by Tony Chang.
620
621         test-webkitpy: Fix load error of
622         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
623         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
624
625         * Scripts/webkitpy/layout_tests/port/server_process.py:
626           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
627           and we don't use server_process.py on Win32 Python. However
628           unittest.py tries to load everything in a module.
629
630 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
631
632         Reviewed by Kent Tamura.
633
634         Fix regression introduced in previous change to new-run-webkit-tests
635         (bug 45090) to not try to run unittests for the Mac implementation
636         of the Port interface if we aren't running on a Mac.
637
638         Also fix the overrides implementation mock in the chromium unittests
639         to fix the case where there are overrides checked in that cause
640         problems.
641
642         https://bugs.webkit.org/show_bug.cgi?id=45357
643
644         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
645         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
646         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
647
648 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
649
650         Reviewed by Ojan Vafai.
651
652         new-run-webkit-tests: still more unit tests
653
654         Clean up and remove unnecessary code. Biggest notable change is
655         moving the chromium-specific imagediff code from port/base to
656         port/chromium.
657
658         Add more unit tests for run_webkit_tests.py, port/base.py,
659         port/factory.py, port/dryrun.py, and
660         layout_package/dump_render_tree_thread.py
661
662         This covers almost all of the generic and test code paths except for
663         a few error paths involving invalid or port-specific command line
664         arguments, and the code path for uploading results files to the
665         buildbots.
666         
667         https://bugs.webkit.org/show_bug.cgi?id=45090
668
669         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
670         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
671         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
672         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
673         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
674         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
675         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
676         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
677         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
678         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
679         * Scripts/webkitpy/layout_tests/port/base.py:
680         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
681         * Scripts/webkitpy/layout_tests/port/chromium.py:
682         * Scripts/webkitpy/layout_tests/port/dryrun.py:
683         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
684         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
685         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
686         * Scripts/webkitpy/layout_tests/port/server_process.py:
687         * Scripts/webkitpy/layout_tests/port/test.py:
688         * Scripts/webkitpy/layout_tests/port/webkit.py:
689         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
690         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
691
692 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
693
694         Reviewed by Darin Adler.
695
696         Provide a way to trigger a <select multiple> onchange event on changes
697         https://bugs.webkit.org/show_bug.cgi?id=45192
698
699         Adds a selector on ObjCController for testing
700         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
701         its different uses.
702
703         * DumpRenderTree/mac/ObjCController.m:
704         (+[ObjCController isSelectorExcludedFromWebScript:]):
705         (+[ObjCController webScriptNameForSelector:]):
706         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
707
708 2010-09-07  James Robinson  <jamesr@chromium.org>
709
710         Rubber-stamped by Dimitri Glazkov.
711
712         Move myself from the committer to the reviewer list.
713
714         * Scripts/webkitpy/common/config/committers.py:
715
716 2010-09-07  Tony Chang  <tony@chromium.org>
717
718         Reviewed by Darin Fisher.
719
720         [chromium] Make a public flag for how DRT generates bitmaps on Linux
721         https://bugs.webkit.org/show_bug.cgi?id=45133
722
723         * DumpRenderTree/chromium/TestShell.cpp:
724         (TestShell::dumpImage):
725
726 2010-09-07  Kent Tamura  <tkent@chromium.org>
727
728         Reviewed by Dimitri Glazkov.
729
730         [DRT/Chromium] Implement --check-layout-test-sys-deps
731         https://bugs.webkit.org/show_bug.cgi?id=45283
732
733         * DumpRenderTree/chromium/DumpRenderTree.cpp:
734         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
735         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
736         * DumpRenderTree/chromium/TestShellGtk.cpp:
737         (checkLayoutTestSystemDependencies): Add an empty implementation.
738         * DumpRenderTree/chromium/TestShellMac.mm:
739         (checkLayoutTestSystemDependencies): Add an empty implementation.
740         * DumpRenderTree/chromium/TestShellWin.cpp:
741         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
742
743 2010-09-07  Jessie Berlin  <jberlin@apple.com>
744
745         Unreviewed. Mac build fix.
746
747         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
748         (didClearWindowObjectForFrame):
749
750 2010-09-07  Jessie Berlin  <jberlin@apple.com>
751
752         Reviewed by Darin Adler.
753
754         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
755         https://bugs.webkit.org/show_bug.cgi?id=45217
756         
757         Make WebKitTestRunner work with this change.
758
759         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
760         (WTR::InjectedBundlePage::didClearWindowForFrame):
761         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
762         WebFrameLoaderClient.
763         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
764
765 2010-09-07  Philippe Normand  <pnormand@igalia.com>
766
767         Unreviewed, build fix.
768
769         webkit-patch command to find the ports covering a specific layout test
770         https://bugs.webkit.org/show_bug.cgi?id=42832
771
772         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
773         tests are present when building the expectations. This is needed
774         for the unittests.
775
776 2010-09-06  Philippe Normand  <pnormand@igalia.com>
777
778         Reviewed by Adam Barth.
779
780         webkit-patch command to find the ports covering a specific layout test
781         https://bugs.webkit.org/show_bug.cgi?id=42832
782
783         To use it: webkit-patch skipped-ports some/layout/test.html
784
785         * Scripts/webkitpy/layout_tests/port/base.py:
786         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
787         * Scripts/webkitpy/layout_tests/port/chromium.py:
788         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
789         * Scripts/webkitpy/layout_tests/port/factory.py:
790         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
791         * Scripts/webkitpy/layout_tests/port/test.py:
792         * Scripts/webkitpy/layout_tests/port/webkit.py:
793         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
794         * Scripts/webkitpy/tool/commands/queries.py:
795         * Scripts/webkitpy/tool/commands/queries_unittest.py:
796         * Scripts/webkitpy/tool/main.py:
797         * Scripts/webkitpy/tool/mocktool.py:
798
799 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
800
801         Reviewed by Eric Seidel.
802
803         [NRWT] Add temp directory to all running drivers.
804         https://bugs.webkit.org/show_bug.cgi?id=45261
805
806         * Scripts/webkitpy/layout_tests/port/webkit.py:
807
808 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
809
810         Reviewed by Kent Tamura.
811
812         [Chromium/DRT] Empty out user stylesheet after each test run.
813         https://bugs.webkit.org/show_bug.cgi?id=45282
814
815         This should significantly cut down on the number of the mysterious flaky tests
816         whose diffs looked like the page was blown up to a very lage size. This
817         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
818         which set the base body font to 100px.
819
820         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
821         the same thread failed.
822
823         * DumpRenderTree/chromium/TestShell.cpp:
824         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
825
826 2010-09-06  Kent Tamura  <tkent@chromium.org>
827
828         Reviewed by Dimitri Glazkov.
829
830         [DRT/Chromium] Do not generate pixel results for text/plain resources
831         https://bugs.webkit.org/show_bug.cgi?id=45253
832
833         * DumpRenderTree/chromium/TestShell.cpp:
834         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
835
836 2010-09-06  Ojan Vafai  <ojan@chromium.org>
837
838         Reviewed by Kent Tamura.
839
840         print out correct error when a DRT thread dies in NRWT
841         https://bugs.webkit.org/show_bug.cgi?id=45281
842
843         Not sure why, but with the parens, python 2.6.5 on Linux
844         gives an error that raise takes 5 arguments and 0 were given.
845         Didn't test other platforms or python versions, but putting it
846         all on one line fixes it and correctly prints the exception
847         from the DRT thread.
848
849         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
850
851 2010-09-06  Eric Seidel  <eric@webkit.org>
852
853         Unreviewed, just adding some emails from lists.webkit.org.
854
855         Update committers.py to include emails from lists.webkit.org
856         as found by the validate-committer-lists script.
857
858         * Scripts/webkitpy/common/config/committers.py:
859
860 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
861
862         Reviewed by Xan Lopez.
863
864         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
865         https://bugs.webkit.org/show_bug.cgi?id=45213
866
867         * DumpRenderTree/gtk/DumpRenderTree.cpp:
868         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
869         have to surround the invocation with #ifdefs.
870         (useLongRunningServerMode): Added.
871         (runTestingServerLoop): Added.
872         (initializeGlobalsFromCommandLineOptions): Added.
873         (runTest): Removed ifdefs.
874         (main): Use new helper functions.
875
876 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
877
878         Reviewed by Xan Lopez.
879
880         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
881         https://bugs.webkit.org/show_bug.cgi?id=45235
882
883         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
884         methods of the EventSender.
885
886         * DumpRenderTree/gtk/EventSender.cpp:
887         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
888         with the current modifiers.
889         (contextClickCallback): Always send no modifiers when preparing the mouse event.
890         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
891         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
892         (mouseUpCallback): Ditto.
893
894 2010-09-05  Peter Kasting  <pkasting@google.com>
895
896         Reviewed by Adam Barth.
897
898         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
899         https://bugs.webkit.org/show_bug.cgi?id=45155
900
901         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
902         (EventSender::handleMouseWheel):
903
904 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
905
906         Reviewed by Joseph Pecoraro.
907
908         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
909         https://bugs.webkit.org/show_bug.cgi?id=45179
910
911         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
912         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
913
914 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
915
916         Rubber-stamped by Daniel Bates.
917
918         Adding myself as reviewer.
919
920         * Scripts/webkitpy/common/config/committers.py:
921
922 2010-09-04  Daniel Bates  <dbates@rim.com>
923
924         Reviewed by Martin Robinson.
925
926         Teach svn-apply/unapply about svn:mergeinfo
927         https://bugs.webkit.org/show_bug.cgi?id=45236
928
929         Recognize the svn:mergeinfo property and ignore it for now.
930
931         Currently, svn-apply/unapply recognize only '+' and '-'
932         property changes within a diff. We should add support
933         to recognize "Merged" and "Reverse-merged" changes as well.
934         Because svn:mergeinfo is metadata that is used only by SVN
935         and tends to be error-prone and/or nuisance (*), we will ignore
936         it for now.
937         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
938
939         * Scripts/VCSUtils.pm:
940           - Modified parseSvnProperty() to recognize "Merged" and
941             "Reverse-merged" as the start of a property value.
942         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
943           - Added the following unit tests:
944             "simple: add svn:mergeinfo"
945             "simple: delete svn:mergeinfo"
946             "simple: modified svn:mergeinfo"
947         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
948           - Added the following unit tests:
949             "simple: add svn:mergeinfo"
950             "simple: delete svn:mergeinfo"
951             "simple: modified svn:mergeinfo"
952             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
953             "'Merged' change followed by 'Merged' change"
954             "'Reverse-merged' change followed by 'Reverse-merged' change"
955         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
956           - Added the following unit tests:
957             "'Merged' change"
958             "'Reverse-merged' change"
959             "'Reverse-merged' change followed by 'Merge' change"
960             "'Merged' change followed by 'Merge' change"
961             "'Reverse-merged' change followed by 'Reverse-merged' change"
962             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
963
964 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
965
966         Reviewed by Kenneth Rohde Christiansen.
967
968         [EFL] Move test browser to WebKitTools directory
969         https://bugs.webkit.org/show_bug.cgi?id=45212
970
971         Follow other ports like QT and GTK which moved the test browser to
972         WebKitTools directory.
973
974         * CMakeListsEfl.txt: Added.
975         * EWebLauncher/main.c: Added.
976         (print_history):
977         (zoom_level_set):
978         (on_ecore_evas_resize):
979         (title_set):
980         (viewport_set):
981         (on_title_changed):
982         (on_progress):
983         (on_load_finished):
984         (on_toolbars_visible_set):
985         (on_toolbars_visible_get):
986         (on_statusbar_visible_set):
987         (on_statusbar_visible_get):
988         (on_scrollbars_visible_set):
989         (on_scrollbars_visible_get):
990         (on_menubar_visible_set):
991         (on_menubar_visible_get):
992         (on_tooltip_text_set):
993         (on_inputmethod_changed):
994         (on_viewport_changed):
995         (on_mouse_down):
996         (on_focus_out):
997         (on_focus_in):
998         (on_resized):
999         (on_key_down):
1000         (on_browser_del):
1001         (on_closeWindow):
1002         (quit):
1003         (browserCreate):
1004         (browserDestroy):
1005         (closeWindow):
1006         (main_signal_exit):
1007         (findThemePath):
1008         (main):
1009
1010 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
1011
1012         Reviewed by Adam Roben.
1013
1014         Set project dependencies so that they build serially. This fixes
1015         issues when running run-webkit-tests if DRT is not built yet.
1016
1017         * DumpRenderTree/DumpRenderTree.sln:
1018
1019 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
1020
1021         Reviewed by Adam Barth.
1022
1023         Fix reading configuraiton in NWRT to work on Windows.
1024         https://bugs.webkit.org/show_bug.cgi?id=45180
1025
1026         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
1027             with the file otherwise.
1028
1029 2010-09-03  Chris Rogers  <crogers@google.com>
1030
1031         Unreviewed
1032
1033         Add myself to the committers list
1034         https://bugs.webkit.org/show_bug.cgi?id=45189
1035
1036         * Scripts/webkitpy/common/config/committers.py:
1037
1038 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
1039
1040         Reviewed by Yury Semikhatsky.
1041
1042         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
1043         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
1044         https://bugs.webkit.org/show_bug.cgi?id=45137
1045
1046         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
1047
1048 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1049
1050         Reviewed by Eric Seidel.
1051
1052         Add feature detection support to NRWT.
1053         https://bugs.webkit.org/show_bug.cgi?id=41842
1054
1055         * Scripts/webkitpy/layout_tests/port/base.py:
1056         * Scripts/webkitpy/layout_tests/port/qt.py:
1057         * Scripts/webkitpy/layout_tests/port/webkit.py:
1058         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
1059
1060 2010-09-03  Hironori Bono  <hbono@chromium.org>
1061
1062         Reviewed by Kent Tamura.
1063
1064         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
1065         and implements it for Mac.
1066         https://bugs.webkit.org/show_bug.cgi?id=41832
1067
1068         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
1069         and bind it so we can call it from JavaScript.
1070         (+[TextInputController isSelectorExcludedFromWebScript:]):
1071         (+[TextInputController webScriptNameForSelector:]):
1072         (-[TextInputController hasSpellingMarker:length:]):
1073
1074 2010-09-02  Eric Seidel  <eric@webkit.org>
1075
1076         Reviewed by Adam Barth.
1077
1078         Add a unit test for commit-queue retries
1079         https://bugs.webkit.org/show_bug.cgi?id=45162
1080
1081         I think commit-queue retries are not correctly avoiding
1082         build and test on retries.  So I started testing the code.
1083         Unfortunately this test did not find the bug.  But now
1084         that we have the test we might as well keep it.
1085         I also fixed a broken import in validate-committer-lists.
1086
1087         * Scripts/validate-committer-lists:
1088         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1089
1090 2010-09-02  Kent Tamura  <tkent@chromium.org>
1091
1092         Reviewed by Dimitri Glazkov.
1093
1094         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
1095         https://bugs.webkit.org/show_bug.cgi?id=45091
1096
1097         Task.{cpp,h} introduces a simpler version of Chromium
1098         base/task.h. It doesn't have TupleN and Method.
1099
1100         * DumpRenderTree/DumpRenderTree.gypi:
1101          Add Task.cpp and Task.h
1102         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1103         (DRTDevToolsAgent::DRTDevToolsAgent):
1104         (DRTDevToolsAgent::reset):
1105         (DRTDevToolsAgent::asyncCall):
1106         (DRTDevToolsAgent::frontendLoaded):
1107         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1108         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
1109         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1110         (DRTDevToolsClient::DRTDevToolsClient):
1111         (DRTDevToolsClient::~DRTDevToolsClient):
1112         (DRTDevToolsClient::reset):
1113         (DRTDevToolsClient::asyncCall):
1114         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1115         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
1116         * DumpRenderTree/chromium/EventSender.cpp:
1117         (EventSender::EventSender):
1118         (EventSender::reset):
1119         (EventSender::scheduleAsynchronousClick):
1120         * DumpRenderTree/chromium/EventSender.h:
1121         (EventSender::taskList): Added to use MethodTask<T>.
1122         * DumpRenderTree/chromium/LayoutTestController.cpp:
1123         (LayoutTestController::LayoutTestController):
1124         (LayoutTestController::WorkQueue::processWorkSoon):
1125         (LayoutTestController::waitUntilDone):
1126         (LayoutTestController::notifyDone):
1127         (LayoutTestController::reset):
1128         * DumpRenderTree/chromium/LayoutTestController.h:
1129         (LayoutTestController::taskList): Added to use MethodTask<T>.
1130         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
1131         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1132         (deferredDisplayDispatch):
1133         (NotificationPresenter::show):
1134         * DumpRenderTree/chromium/Task.cpp: Added.
1135         * DumpRenderTree/chromium/Task.h: Added.
1136
1137 2010-09-02  Steve Block  <steveblock@google.com>
1138
1139         Reviewed by Adam Barth.
1140
1141         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
1142         https://bugs.webkit.org/show_bug.cgi?id=43181
1143
1144         * DumpRenderTree/mac/DumpRenderTree.mm:
1145         (createWebViewAndOffscreenWindow):
1146         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1147         (LayoutTestController::setMockDeviceOrientation):
1148
1149 2010-08-31  Adam Roben  <aroben@apple.com>
1150
1151         Fix flashiness when resizing the browser window on Windows
1152
1153         Reviewed by Sam Weinig.
1154
1155         * MiniBrowser/win/BrowserWindow.cpp:
1156         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
1157         periodically fill the window with white.
1158
1159 2010-09-02  Peter Kasting  <pkasting@google.com>
1160
1161         Reviewed by Dimitri Glazkov.
1162
1163         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
1164         https://bugs.webkit.org/show_bug.cgi?id=45073
1165
1166         * DumpRenderTree/chromium/EventSender.cpp:
1167         (EventSender::EventSender):
1168         (EventSender::mouseScrollBy):
1169         (EventSender::continuousMouseScrollBy):
1170         (EventSender::sendCurrentTouchEvent):
1171         (EventSender::handleMouseWheel):
1172         * DumpRenderTree/chromium/EventSender.h:
1173         * DumpRenderTree/gtk/EventSender.cpp:
1174         (mouseScrollByCallback):
1175         (continuousMouseScrollByCallback):
1176
1177 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1178
1179         Reviewed by Tony Chang.
1180
1181         Land a patched version of r66542 - change TestRunner to have an
1182         separate cleanup method and fix the ordering of cleanup between
1183         TestRunner and the printing module, and then wrap everything in a
1184         try/finally block to ensure reliable cleanup without needing to
1185         rely on stuff happening in the destructor of the TestRunner.
1186
1187         Also refactor run_webkit_tests.run() to be much smaller and cleaner
1188         by creating a bunch of helper methods and moving more stuff into
1189         the TestRunner class.
1190
1191         This fixes the crash at the end of the linux test run of
1192         new-run-webkit-tests (and undoes the rollout in 66547).
1193
1194         https://bugs.webkit.org/show_bug.cgi?id=44902
1195
1196         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1197         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1198         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1199         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1200         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1201         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1202         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1203         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1204         * Scripts/webkitpy/layout_tests/port/base.py:
1205         * Scripts/webkitpy/layout_tests/port/test.py:
1206         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1207         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1208
1209 2010-09-01  Mark Rowe  <mrowe@apple.com>
1210
1211         Reviewed by Adam Roben.
1212
1213         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
1214
1215         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1216
1217 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
1218
1219         Reviewed by Adam Roben.
1220
1221         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
1222         and WebKitTestRunner.
1223
1224         * BuildSlaveSupport/win/kill-old-processes:
1225
1226 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1227
1228         Reviewed by Antonio Gomes.
1229
1230         [Qt] Remove obsolete include path from DumpRenderTree.pro
1231
1232         * DumpRenderTree/qt/DumpRenderTree.pro:
1233
1234 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1235
1236         Reviewed by Laszlo Gombos.
1237
1238         [Qt] QWebPage::allowGeolocationRequest should be async API
1239         https://bugs.webkit.org/show_bug.cgi?id=41364
1240
1241         Implements new async API for geolocation permission similar to
1242         Notification. WebPage maintains list of geolocation permission request
1243         QtWebkit and set's when LayoutTestController gets the access from test JS
1244
1245         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1246         (WebCore::WebPage::WebPage):
1247         (WebCore::WebPage::resetSettings):
1248         (WebCore::WebPage::requestPermission):
1249         (WebCore::WebPage::cancelPermission):
1250         (WebCore::WebPage::permissionSet):
1251         (WebCore::DumpRenderTree::DumpRenderTree):
1252         (WebCore::DumpRenderTree::processLine):
1253         (WebCore::DumpRenderTree::geolocationPermissionSet):
1254         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1255         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1256         (LayoutTestController::reset):
1257         (LayoutTestController::setGeolocationPermission):
1258         (LayoutTestController::setGeolocationPermissionCommon):
1259         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1260
1261 2010-09-01  Andras Becsi  <abecsi@webkit.org>
1262
1263         Reviewed by Antti Koivisto.
1264
1265         [Qt] Auto-generate WebKit2 forwarding headers
1266         https://bugs.webkit.org/show_bug.cgi?id=44692
1267
1268         * MiniBrowser/qt/BrowserWindow.h: use source style includes
1269         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
1270         * Scripts/enumerate-included-framework-headers: Removed.
1271
1272 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1273
1274         Reviewed by Adam Barth.
1275
1276         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
1277         https://bugs.webkit.org/show_bug.cgi?id=44789
1278
1279         * Scripts/webkitpy/common/net/bugzilla.py:
1280
1281 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
1282
1283         Reviewed by Adam Barth.
1284
1285         ews: Add support for EFL-EWS
1286         https://bugs.webkit.org/show_bug.cgi?id=44982
1287
1288         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
1289         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
1290         and add it to the ports dict.
1291         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
1292         EflEWS class.
1293         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
1294         a test case for the EFL EWS.
1295
1296 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
1297
1298         Reviewed by Sam Weinig.
1299
1300         https://bugs.webkit.org/show_bug.cgi?id=42195
1301         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
1302
1303         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1304         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
1305         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1306         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
1307         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
1308
1309         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1310         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
1311         which forgets its override.
1312
1313 2010-08-31  Sam Weinig  <sam@webkit.org>
1314
1315         Reviewed by Gavin Barraclough.
1316
1317         WebKitTestRunner needs layoutTestController.addUserStyleSheet
1318         https://bugs.webkit.org/show_bug.cgi?id=42680
1319
1320         WebKitTestRunner needs layoutTestController.addUserScript
1321         https://bugs.webkit.org/show_bug.cgi?id=42681
1322
1323         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1324         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1325         (WTR::InjectedBundle::beginTesting):
1326         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1327         (WTR::LayoutTestController::addUserScript):
1328         (WTR::LayoutTestController::addUserStyleSheet):
1329         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1330
1331 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1332
1333         Unreviewed, rolling out r66542.
1334         http://trac.webkit.org/changeset/66542
1335         https://bugs.webkit.org/show_bug.cgi?id=44902
1336
1337         r66542 - the weird logging dependencies in Python stuck again ...
1338
1339         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
1340         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
1341         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
1342         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
1343         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1344         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1345         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1346         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1347         * Scripts/webkitpy/layout_tests/port/base.py:
1348         * Scripts/webkitpy/layout_tests/port/test.py:
1349         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1350         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1351
1352 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
1353
1354         Reviewed by Tony Chang.
1355
1356         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
1357
1358         * DumpRenderTree/chromium/LayoutTestController.cpp:
1359         (LayoutTestController::LayoutTestController):
1360         (LayoutTestController::markerTextForListItem):
1361         * DumpRenderTree/chromium/LayoutTestController.h:
1362
1363 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1364
1365         Reviewed by Ojan Vafai.
1366
1367         new-run-webkit-tests: add more unit tests
1368
1369         Add more unit tests for new-run-webkit-tests; we now cover all but
1370         the most obscure code paths in the generic code. We still need to
1371         add coverage for the http server and web socket paths, and add better
1372         coverage of the platform-specific logic. Note that the rebaselining
1373         tool is still not well tested.
1374
1375         Also clean up some of the configuration logic for the printing
1376         module and the way it interacts with the Python logging module; that
1377         is a crufty interface, to be certain.
1378         
1379         https://bugs.webkit.org/show_bug.cgi?id=44902
1380
1381         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1382         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1383         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1384         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1385         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1386         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1387         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1388         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1389         * Scripts/webkitpy/layout_tests/port/base.py:
1390         * Scripts/webkitpy/layout_tests/port/test.py:
1391         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1392         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1393
1394 2010-08-31  Darin Adler  <darin@apple.com>
1395
1396         Reviewed by Anders Carlsson.
1397
1398         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
1399         in a debug build when built with certain compilers.
1400
1401 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
1402
1403         Reviewed by Gustavo Noronha Silva.
1404
1405         [GTK] Isolate all GTK+ typedefs into one file
1406         https://bugs.webkit.org/show_bug.cgi?id=44900
1407
1408         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
1409
1410 2010-08-31  Eric Seidel  <eric@webkit.org>
1411
1412         Reviewed by Adam Barth.
1413
1414         Show more status on queue status pages
1415         https://bugs.webkit.org/show_bug.cgi?id=44938
1416
1417         I upped the number of status lines from 6 to 15 --
1418         this has been bugging me for a while...
1419
1420         I also disabled showing the chromium-win EWS queue
1421         since it's been down for almost 5 months now.
1422
1423         * QueueStatusServer/handlers/dashboard.py:
1424         * QueueStatusServer/handlers/queuestatus.py:
1425         * QueueStatusServer/model/queues.py:
1426
1427 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
1428
1429         Reviewed by Antonio Gomes.
1430
1431         [Qt] Read command line arguments and open them as URLs in new windows
1432         https://bugs.webkit.org/show_bug.cgi?id=44944
1433
1434         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
1435
1436         * MiniBrowser/qt/main.cpp:
1437         (main):
1438
1439 2010-08-31  Adrian Perez  <aperez@igalia.com>
1440
1441         Reviewed by Martin Robinson.
1442
1443         Support scripts to run Buildbot slaves under daemontools (gtk related)
1444         https://bugs.webkit.org/show_bug.cgi?id=40053
1445
1446         * BuildSlaveSupport/gtk: Added.
1447         * BuildSlaveSupport/gtk/README: Added.
1448         * BuildSlaveSupport/gtk/buildbot: Added.
1449         * BuildSlaveSupport/gtk/buildbot/log: Added.
1450         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
1451         * BuildSlaveSupport/gtk/buildbot/run: Added.
1452         * BuildSlaveSupport/gtk/crashmon: Added.
1453         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
1454         * BuildSlaveSupport/gtk/crashmon/log: Added.
1455         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
1456         * BuildSlaveSupport/gtk/crashmon/run: Added.
1457         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
1458         * BuildSlaveSupport/gtk/pulseaudio: Added.
1459         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
1460         * BuildSlaveSupport/gtk/xvfb: Added.
1461         * BuildSlaveSupport/gtk/xvfb/log: Added.
1462         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
1463         * BuildSlaveSupport/gtk/xvfb/run: Added.
1464
1465 2010-08-27  John Gregg  <johnnyg@google.com>
1466
1467         Reviewed by David Levin.
1468
1469         Notifications should support a click event.
1470         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
1471         can be simulated during a layout test.  Requires storing a list of active
1472         notifications so that they can be referred to later for clicking.
1473         https://bugs.webkit.org/show_bug.cgi?id=44800
1474
1475         * DumpRenderTree/chromium/LayoutTestController.cpp:
1476         (LayoutTestController::LayoutTestController):
1477         (LayoutTestController::simulateDesktopNotificationClick):
1478         * DumpRenderTree/chromium/LayoutTestController.h:
1479         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1480         (NotificationPresenter::simulateClick):
1481         (NotificationPresenter::show):
1482         (NotificationPresenter::cancel):
1483         (NotificationPresenter::objectDestroyed):
1484         * DumpRenderTree/chromium/NotificationPresenter.h:
1485
1486 2010-08-30  Alice Liu  <alice.liu@apple.com>
1487
1488         Reviewed by Darin Adler.
1489
1490         Add missing parts of didFinishDocumentLoadForFrame
1491         https://bugs.webkit.org/show_bug.cgi?id=44913
1492
1493         * MiniBrowser/mac/BrowserWindowController.m:
1494         (didFinishDocumentLoadForFrame): Added
1495         (-[BrowserWindowController awakeFromNib]): Updated struct
1496         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1497         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
1498         * WebKitTestRunner/TestController.cpp:
1499         (WTR::TestController::initialize): Updated struct
1500
1501 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
1502
1503         Unreviewed: Add myself to the list of Committers.
1504
1505         * Scripts/webkitpy/common/config/committers.py:
1506
1507 2010-08-30  Kent Tamura  <tkent@chromium.org>
1508
1509         Reviewed by Adam Barth.
1510
1511         Fix fast/notifications/notifications-display-close-events.html failure
1512         https://bugs.webkit.org/show_bug.cgi?id=44585
1513
1514         Apply http://crrev.com/48893. We should dispatch display events
1515         asynchronously.
1516
1517         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1518         (deferredDisplayDispatch):
1519         (NotificationPresenter::show):
1520
1521 2010-08-30  Robert Hogan  <robert@webkit.org>
1522
1523         Reviewed by Simon Hausmann.
1524
1525         allow ports with windowed plugins to support windowless plugin tests
1526
1527         https://bugs.webkit.org/show_bug.cgi?id=40730
1528
1529         Ports that implement plugins windowed by default need to have a way of
1530         supporting plugin tests that assume the plugin is windowless. Add this
1531         feature to the tests and support it in the webkit test plugin. Also
1532         add mouse and keyboard event logging to the webkit-test plugin on Unix.
1533
1534         Unskip the following tests on Qt:
1535
1536         plugins/mouse-events.html
1537         plugins/keyboard-events.html
1538         plugins/mouse-events-fixedpos.html
1539
1540         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1541         (pluginSetProperty):
1542         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1543         (NPP_New):
1544         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1545         (webkit_test_plugin_handle_event):
1546
1547 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
1548
1549         [wx] Build fix after addition of fileapi directory in WebCore.
1550
1551         * wx/build/settings.py:
1552
1553 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1554
1555         Reviewed by Xan Lopez.
1556
1557         Fixed compilation error, now that we have included the
1558         GtkVersioning.h we have to remove some version dependent code from
1559         EventSender.
1560
1561         * DumpRenderTree/gtk/EventSender.cpp:
1562
1563 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1564
1565         Reviewed by Martin Robinson.
1566
1567         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
1568         are deprecated
1569         https://bugs.webkit.org/show_bug.cgi?id=44787
1570
1571         We have replaced GtkVersioning.cpp with GtkVersioning.c and
1572         created a function (getDefaultGDKPointerDevice) to get the pointer
1573         of the window with the new APIs. We added that function to DRT and
1574         copyandpaste unit test.
1575
1576         * DumpRenderTree/gtk/EventSender.cpp:
1577         (prepareMouseButtonEvent):
1578         (mouseMoveToCallback):
1579         (keyDownCallback):
1580         * GNUmakefile.am:
1581
1582 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
1583
1584         Reviewed by Kenneth Rohde Christiansen.
1585
1586         [Qt] Add new window menu to MiniBrowser
1587
1588         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
1589
1590         * MiniBrowser/qt/BrowserWindow.cpp:
1591         (BrowserWindow::BrowserWindow):
1592         (BrowserWindow::newWindow):
1593         * MiniBrowser/qt/BrowserWindow.h:
1594         * MiniBrowser/qt/main.cpp:
1595         (main):
1596
1597 2010-08-29  James Robinson  <jamesr@chromium.org>
1598
1599         Reviewed by David Levin.
1600
1601         Make failing the download step fail the build
1602         https://bugs.webkit.org/show_bug.cgi?id=44298
1603
1604         If the download step fails on a test bot, this ensures that
1605         the build goes red instead of only the download step going red
1606         and the overall build staying green.
1607
1608         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1609
1610 2010-08-29  Kent Tamura  <tkent@chromium.org>
1611
1612         Reviewed by Dimitri Glazkov.
1613
1614         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
1615         https://bugs.webkit.org/show_bug.cgi?id=44847
1616
1617         * DumpRenderTree/chromium/EventSender.cpp:
1618          Use webkit_support::VKEY_* instead of base::VKEY_*.
1619
1620 2010-08-29  Darin Adler  <darin@apple.com>
1621
1622         https://bugs.webkit.org/show_bug.cgi?id=40589
1623
1624         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
1625         function names.
1626
1627 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1628
1629         Reviewed by Darin Adler.
1630
1631         [iExploder] Add new CSS Properties and HTML Attributes
1632         https://bugs.webkit.org/show_bug.cgi?id=44746
1633
1634         Updated the files with the update-iexploder-cssproperties script
1635         and manually readded the -webkit-binding CSS Property to the list.
1636
1637         * iExploder/htdocs/cssproperties.in:
1638         * iExploder/htdocs/htmlattrs.in:
1639         * iExploder/htdocs/htmltags.in:
1640
1641 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1642
1643         Reviewed by Darin Adler.
1644
1645         Fix Coverage build after the addition of ANGLE
1646         https://bugs.webkit.org/show_bug.cgi?id=44744
1647
1648         ANGLE is using libtool to build a static library and the version of
1649         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
1650         parameters. The easiest way to handle this is to not build ANGLE with
1651         coverage information.
1652
1653         This is achieved by applying the XCode options for each project
1654         separately and exclude ANGLE.
1655
1656         * Scripts/build-webkit: Remove -framework AppKit due link errors.
1657         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
1658
1659 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
1660
1661         [wx] Build fix after directory addition.
1662
1663         * wx/build/settings.py:
1664
1665 2010-08-28  Chris Guillory   <chris.guillory@google.com>
1666
1667         Reviewed by Chris Fleizach.
1668
1669         Add AX notification for childrenChanged
1670         https://bugs.webkit.org/show_bug.cgi?id=44472
1671
1672         * DumpRenderTree/chromium/AccessibilityController.cpp:
1673         (AccessibilityController::AccessibilityController):
1674         (AccessibilityController::reset):
1675         (AccessibilityController::getRootElement):
1676         (AccessibilityController::dumpAccessibilityNotifications):
1677         * DumpRenderTree/chromium/AccessibilityController.h:
1678         (AccessibilityController::shouldDumpAccessibilityNotifications):
1679         * DumpRenderTree/chromium/WebViewHost.cpp:
1680         (WebViewHost::didChangeAccessibilityObjectChildren):
1681         * DumpRenderTree/chromium/WebViewHost.h:
1682
1683 2010-08-28  Eric Seidel  <eric@webkit.org>
1684
1685         Reviewed by Adam Barth.
1686
1687         Update commit-queue failure message
1688         https://bugs.webkit.org/show_bug.cgi?id=44798
1689
1690         The commit-queue auto-restarts itself and has for a very long time.
1691         No need for people to email me to request a restart anymore.
1692
1693         * Scripts/webkitpy/common/net/bugzilla.py:
1694         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1695         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1696
1697 2010-07-27  Jer Noble  <jer.noble@apple.com>
1698
1699         Reviewed by Eric Carlson.
1700
1701         Add JavaScript API to allow a page to go fullscreen.
1702         rdar://problem/6867795
1703         
1704         Added basic full screen support to DumpRenderTree: when a webView requests
1705         that DumpRenderTree go "full screen", just call the provided callback listener object's
1706         will/did Enter/Exit full screen methods.  Also, register a new user default which 
1707         enables full screen support.
1708
1709         * DumpRenderTree/mac/DumpRenderTree.mm:
1710         (resetDefaultsToConsistentValues):
1711         * DumpRenderTree/mac/UIDelegate.mm:
1712         (-[UIDelegate webView:supportsFullscreenForElement:]):
1713         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
1714         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
1715
1716 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1717
1718         Unreviewed. Add myself to the committers list.
1719
1720         * Scripts/webkitpy/common/config/committers.py:
1721
1722 2010-08-27  Kent Tamura  <tkent@chromium.org>
1723
1724         Reviewed by Pavel Feldman.
1725
1726         [DRT/Chromium] Fix inspector test failures
1727         https://bugs.webkit.org/show_bug.cgi?id=44748
1728
1729         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1730         (DRTDevToolsAgent::createClientMessageLoop):
1731           Returns a valid WebKitClientMessageLoop instance
1732         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1733
1734 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
1735
1736         Add Windows WebKit2 Tester to buildbot
1737         <rdar://problem/7887703>
1738
1739         Reviewed by Dan Bernstein.
1740
1741         * BuildSlaveSupport/build.webkit.org-config/config.json:
1742
1743 2010-08-26  Philippe Normand  <pnormand@igalia.com>
1744
1745         Reviewed by Martin Robinson.
1746
1747         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1748         https://bugs.webkit.org/show_bug.cgi?id=42152
1749
1750         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1751         (LoadHTMLStringItem::invoke): Implementation using
1752         webkit_web_frame_load_string().
1753
1754 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
1755
1756         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
1757         WebKitTestRunner (44331)
1758
1759         Reviewed by Darin Adler.
1760
1761         * WebKitTestRunner/TestController.cpp:
1762         (WTR::TestController::initialize):
1763         The hang occurs when WebKitTestRunner begins launching the WebKit2
1764         web process then exits before it finishes launching. Work around this by
1765         looking for the --print-supported-features argument and exiting without
1766         creating the web process.
1767
1768 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
1769
1770         Reviewed by Tony Chang.
1771
1772         new-run-webkit-tests: add rebaselining tests for test_expectations
1773         
1774         This patch adds more unit tests for the rebaselining code in the
1775         test_expectations module. It doesn't add any tests for
1776         rebaseline_chromium_webkit_tests itself; that will come some other
1777         time.
1778
1779         https://bugs.webkit.org/show_bug.cgi?id=44648
1780
1781         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1782         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1783
1784 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1785
1786         Reviewed by Martin Robinson.
1787
1788         [GTK] Add HTTP caching support
1789         https://bugs.webkit.org/show_bug.cgi?id=44261
1790
1791         Ignore new soup API that we decided to merge into the soup backend
1792         while it is being cooked. It follows the libsoup style, and will
1793         be removed from WebKit as soon as it is merged into libsoup.
1794
1795         * Scripts/webkitpy/style/checker.py:
1796
1797 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1798
1799         Reviewed by Kenneth Rohde Christiansen.
1800
1801         [Qt] DumpRenderTree runs only one test from command mode
1802         https://bugs.webkit.org/show_bug.cgi?id=44012
1803
1804         Enables support to run multiple test files and single
1805         folder containing html files in stand alone mode
1806
1807         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1808         (WebCore::DumpRenderTree::DumpRenderTree):
1809         (WebCore::DumpRenderTree::processArgsLine):
1810         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1811         (WebCore::DumpRenderTree::processLine):
1812         (WebCore::DumpRenderTree::dump):
1813         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1814         (WebCore::DumpRenderTree::setStandAloneMode):
1815         (WebCore::DumpRenderTree::isStandAloneMode):
1816         * DumpRenderTree/qt/main.cpp:
1817         (main):
1818
1819 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1820
1821         Updating webkitpy test expectations.
1822
1823         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1824
1825 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1826
1827         Reviewed by Eric Seidel.
1828
1829         fix the always squash git config
1830         https://bugs.webkit.org/show_bug.cgi?id=44651
1831
1832         Fix help text and apparently underscores are not allowed
1833         in git config keys.
1834
1835         * Scripts/webkitpy/common/checkout/scm.py:
1836         * Scripts/webkitpy/tool/steps/commit.py:
1837
1838 2010-08-25  Darin Adler  <darin@apple.com>
1839
1840         Reviewed by John Sullivan.
1841
1842         * Scripts/commit-log-editor: Fix perl warning for people who have no
1843         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
1844
1845 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1846
1847         Reviewed by Eric Seidel.
1848
1849         stop blocking commits when the bots are red
1850         https://bugs.webkit.org/show_bug.cgi?id=44644
1851
1852         This check currently is just annoying. It doesn't actually
1853         help keep the tree green. We can always add it back later
1854         if we decide the tree is generally more green.
1855
1856         * Scripts/webkitpy/tool/commands/download_unittest.py:
1857         * Scripts/webkitpy/tool/mocktool.py:
1858         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1859
1860 2010-08-25  Eric Seidel  <eric@webkit.org>
1861
1862         Reviewed by Simon Fraser.
1863
1864         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
1865         https://bugs.webkit.org/show_bug.cgi?id=38912
1866
1867         I know of nothing else to do but skip all media tests for the cq.
1868
1869         * Scripts/webkitpy/tool/steps/runtests.py:
1870
1871 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1872
1873         Reviewed by Ojan Vafai.
1874
1875         new-run-webkit-tests: add more unit tests for test_expectations
1876         This adds unit tests to cover (almost?) all of the non-rebaselining
1877         functionality.
1878
1879         https://bugs.webkit.org/show_bug.cgi?id=44579
1880
1881         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1882         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1883
1884 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1885
1886         Reviewed by Ojan Vafai.
1887
1888         new-run-webkit-tests: add more unit tests
1889
1890         This change adds more unit tests for the image_diff, test_failures,
1891         and test_files modules, bringing them to 100% coverage (and adds a
1892         couple tests to run_webkit_tests while we're at it).
1893
1894         This test also turns on the "dryrun" port for testing when run on
1895         the mac, increasing coverage in a few other places.
1896
1897         https://bugs.webkit.org/show_bug.cgi?id=44578
1898
1899         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
1900         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
1901         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
1902         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
1903         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
1904         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
1905         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
1906         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
1907         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1908         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
1909         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1910         * Scripts/webkitpy/layout_tests/port/test.py:
1911         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1912
1913 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1914
1915         Reviewed by Ojan Vafai.
1916
1917         new-run-webkit-tests: add more unit tests for layout_package/printing.py
1918
1919         This change adds more unit tests to get the test coverage to 100%
1920         for the printing module. This code is actually pretty crufty and
1921         has some layering violations that need to be cleaned up but I'll
1922         save that for another CL after we get all the unit tests written and
1923         we fix the multithreading issues. At least now we'll be able to tell
1924         if we break things.
1925
1926         https://bugs.webkit.org/show_bug.cgi?id=44576
1927
1928         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1929         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1930
1931 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1932
1933         Reviewed by Adam Barth.
1934
1935         new-run-webkit-tests should respect set-webkit-configuration
1936         https://bugs.webkit.org/show_bug.cgi?id=44633
1937
1938         Moves the getting of the configuration into the base Port so that
1939         chromium ports use it as well. In the downstream chromium port,
1940         this should still just return Release.
1941
1942         * Scripts/webkitpy/layout_tests/port/base.py:
1943         * Scripts/webkitpy/layout_tests/port/webkit.py:
1944
1945 2010-08-25  Tony Chang  <tony@chromium.org>
1946
1947         Not reviewed, changing svn props for a script.
1948
1949         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
1950
1951 2010-08-25  Adam Barth  <abarth@webkit.org>
1952
1953         Reviewed by Eric Seidel.
1954
1955         Remove WebKit2 from core builders
1956         https://bugs.webkit.org/show_bug.cgi?id=44625
1957
1958         This builder was added to the core builders by accident.  It doesn't
1959         appear to be green enough to be a core builder yet.
1960
1961         * Scripts/webkitpy/common/net/buildbot.py:
1962         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1963
1964 2010-08-19  Adam Roben  <aroben@apple.com>
1965
1966         Test that NP_Initialize and NP_GetEntryPoints are called in the
1967         correct order
1968
1969         The order differs between Mac and Windows (see r38858).
1970
1971         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1972         NP_Initialize when loading QuickTime when running
1973         plugins/embed-attributes-setting.html in WebKit2 on Windows
1974
1975         Reviewed by John Sullivan.
1976
1977         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1978         a boolean to record whether NP_GetEntryPoints has been called.
1979         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1980         called yet. This matches Flash and QuickTime's behavior.
1981         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
1982         yet. This matches Silverlight's behavior.
1983
1984 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1985
1986         Reviewed by Gustavo Noronha Silva.
1987
1988         Cairo and EFL port shouldn't depend on glib.
1989         https://bugs.webkit.org/show_bug.cgi?id=44354
1990
1991         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
1992         adoptPlatformRef.
1993
1994         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1995         (AccessibilityUIElement::isSelected):
1996
1997 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1998
1999         Fix order of Timothy's email address. The script, and
2000         other tools all assume that the first email is the bugzilla address.
2001
2002         * Scripts/webkitpy/common/config/committers.py:
2003
2004 2010-08-24  Kent Tamura  <tkent@chromium.org>
2005
2006         Reviewed by Pavel Feldman.
2007
2008         [DRT/Chromium] Fix 26 inspector test crashes
2009         https://bugs.webkit.org/show_bug.cgi?id=44580
2010
2011         - DRTDevToolsAgent has a reference to the main WebView. So we
2012           should not clear it in closeDevTools() and should clear it in
2013           ~TestShell().
2014         - DRTDevToolsClient has a reference to a DevTools WebView and no
2015           way to update it. So we should delete DRTDevToolsClient instances
2016           in closeDevTools().
2017
2018         * DumpRenderTree/chromium/TestShell.cpp:
2019         (TestShell::~TestShell):
2020         (TestShell::closeDevTools):
2021
2022 2010-08-24  Eric Seidel  <eric@webkit.org>
2023
2024         Reviewed by Adam Barth.
2025
2026         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
2027         https://bugs.webkit.org/show_bug.cgi?id=44584
2028
2029         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2030
2031 2010-08-24  Eric Seidel  <eric@webkit.org>
2032
2033         Reviewed by Adam Barth.
2034
2035         commit-queue and EWS bots should report all failures
2036         https://bugs.webkit.org/show_bug.cgi?id=41820
2037
2038         Right now commit-queue/EWS only report failures when the
2039         patch under testing fails.  We should report all failures
2040         to the status server so that we can diagnose when the bots
2041         are wedged w/o needing to log into the machines.
2042
2043         I also reduced the amount of data we upload since we've seen
2044         timeouts during status upload.
2045
2046         * Scripts/webkitpy/common/system/executive.py:
2047         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2048         * Scripts/webkitpy/tool/commands/queues.py:
2049         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2050
2051 2010-08-24  Eric Seidel  <eric@webkit.org>
2052
2053         Reviewed by Adam Barth.
2054
2055         Remove HTML5 parser testing infrastructure now that we don't need it
2056         https://bugs.webkit.org/show_bug.cgi?id=44581
2057
2058         * DumpRenderTree/mac/DumpRenderTree.mm:
2059         (resetDefaultsToConsistentValues):
2060         (initializeGlobalsFromCommandLineOptions):
2061         * Scripts/old-run-webkit-tests:
2062         * Scripts/test-html5-parser: Removed.
2063
2064 2010-08-24  Kent Tamura  <tkent@chromium.org>
2065
2066         Reviewed by Dimitri Glazkov.
2067
2068         [DRT/Chromium] Fix 28 inspector test crashes
2069         https://bugs.webkit.org/show_bug.cgi?id=44574
2070
2071         Reset DevToolsClient and DevToolsAgent before closing a DevTools
2072         WebView in order to avoid accessing to a deleted WebView instance.
2073
2074         * DumpRenderTree/chromium/TestShell.cpp:
2075         (TestShell::closeDevTools):
2076
2077 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2078
2079         Reviewed by Ojan Vafai.
2080
2081         new-run-webkit-tests: clean up code for test_types, test_failures
2082
2083         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
2084         webkitpy.layout_tests.layout_package.test_failures, and remove
2085         some dead code and otherwise clean up things.
2086
2087         https://bugs.webkit.org/show_bug.cgi?id=44559
2088
2089         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2090         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
2091         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2092         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2093         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2094         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
2095         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2096
2097 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2098
2099         Reviewed by Eric Seidel.
2100
2101         new-run-webkit-tests: revise unit testing strategy for test failures
2102     
2103         This change revamps the way we store test data for new-run-webkit-tests.
2104         Previously we had a few copies of test files from the main test tree.
2105         Now we have a bunch of completely fake test data and use the test
2106         data to generate different kinds of test failures, getting
2107         much better coverage.
2108
2109         https://bugs.webkit.org/show_bug.cgi?id=44556
2110
2111         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
2112         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
2113         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
2114         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
2115         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
2116         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
2117         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
2118         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
2119         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
2120         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
2121         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
2122         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
2123         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
2124         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
2125         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
2126         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
2127         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
2128         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
2129         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
2130         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
2131         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
2132         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
2133         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
2134         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
2135         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
2136         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
2137         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
2138         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
2139         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
2140         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
2141         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
2142         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
2143         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
2144         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
2145         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
2146         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
2147         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
2148         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
2149         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
2150         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
2151         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
2152         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
2153         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
2154         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2155         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
2156         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
2157         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2158         * Scripts/webkitpy/layout_tests/port/test.py:
2159         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2160         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2161
2162 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2163
2164         Reviewed by Eric Seidel.
2165
2166         speed up new-run-webkit-tests unit tests
2167
2168         Add a --no-record-results flag that turns off generating the JSON
2169         results file on every test run. Generating the file requires us to
2170         fetch the old results down from the bots, which can be slow. This
2171         flag is off by default.
2172     
2173         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
2174     
2175         These changes together shorten the test cycle from ~4.5s to ~1.5s
2176         - a 3x speedup.
2177
2178         https://bugs.webkit.org/show_bug.cgi?id=44553
2179
2180         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2181         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2182
2183 2010-08-24  Tony Chang  <tony@chromium.org>
2184
2185         Reviewed by Eric Seidel.
2186
2187         [chromium] fix the platform result fallback order on mac/win
2188         https://bugs.webkit.org/show_bug.cgi?id=44483
2189
2190         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2191
2192 2010-08-24  Xan Lopez  <xlopez@igalia.com>
2193
2194         Reviewed by Martin Robinson.
2195
2196         Set a device to the event struct when building with GTK+ 3.x, it's
2197         mandatory.
2198
2199         * DumpRenderTree/gtk/EventSender.cpp:
2200         (keyDownCallback):
2201
2202 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2203
2204         Reviewed by Xan Lopez.
2205
2206         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2207         https://bugs.webkit.org/show_bug.cgi?id=44534
2208
2209         Fix two double-frees introduced in my previous commit.
2210
2211         * DumpRenderTree/gtk/EventSender.cpp:
2212         (contextClickCallback): Copy the event before using it again.
2213         (keyDownCallback): Ditto.
2214
2215 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2216
2217         Reviewed by Xan Lopez.
2218
2219         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2220         https://bugs.webkit.org/show_bug.cgi?id=44534
2221
2222         * DumpRenderTree/gtk/EventSender.cpp:
2223         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
2224         when setting it on the event. It is dereferenced by gdk_event_free(...).
2225         (contextClickCallback): Ditto.
2226         (mouseDownCallback): Ditto.
2227         (mouseUpCallback): Ditto.
2228         (mouseMoveToCallback): Ditto.
2229         (mouseWheelToCallback): Ditto.
2230         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
2231         (dispatchEvent): Ditto. Also free the event when we are done with it.
2232         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
2233
2234 2010-08-24  Andras Becsi  <abecsi@webkit.org>
2235
2236         [Qt] WebKit2 build fix.
2237
2238         * Scripts/enumerate-included-framework-headers:
2239         Remove stray global option form sed.
2240
2241 2010-08-24  Kent Tamura  <tkent@chromium.org>
2242
2243         Reviewed by Jeremy Orlow.
2244
2245         [DRT/Chromium] Support for IndexedDB tests
2246         https://bugs.webkit.org/show_bug.cgi?id=44490
2247
2248         * DumpRenderTree/chromium/TestShell.cpp:
2249         (TestShell::TestShell): Enable IndexedDB.
2250
2251 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
2252
2253         Reviewed by Gustavo Noronha Silva.
2254
2255         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
2256         https://bugs.webkit.org/show_bug.cgi?id=44465
2257
2258         Initialize the axes field of mouse button and motion events to null.
2259         This is the value that should be used for events originating from the
2260         mouse device.
2261
2262         * DumpRenderTree/gtk/EventSender.cpp:
2263         (prepareMouseButtonEvent): Initalize button event axes field to null.
2264         (mouseMoveToCallback): Initialize motion event axes field to null.
2265
2266 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2267
2268         Unreviewed, rolling out r65703.
2269         http://trac.webkit.org/changeset/65703
2270         https://bugs.webkit.org/show_bug.cgi?id=44460
2271
2272         "Causing lots of crashes on Snow Leopard when running the
2273         layout tests" (Requested by eseidel2 on #webkit).
2274
2275         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2276         (NP_Initialize):
2277         (NP_GetEntryPoints):
2278
2279 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
2280
2281         Layout tests do not run when using WebKitTestRunner in a Debug build.
2282         https://bugs.webkit.org/show_bug.cgi?id=44409
2283
2284         Reviewed by Dan Bernstein.
2285
2286         * WebKitTestRunner/win/TestControllerWin.cpp:
2287         (WTR::TestController::initializeInjectedBundlePath):
2288         Use InjectedBundle_debug.dll when building Debug.
2289
2290 2010-08-23  Xan Lopez  <xlopez@igalia.com>
2291
2292         Reviewed by Martin Robinson.
2293
2294         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
2295         https://bugs.webkit.org/show_bug.cgi?id=42026
2296
2297         If a GTK+ 3.x build is present return that as the library to use,
2298         otherwise fallback to the GTK+ 2.x build.
2299
2300         * Scripts/webkitdirs.pm:
2301
2302 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
2303
2304         Reviewed by Ariya Hidayat.
2305
2306         [Qt] Find needed forwarding headers for WebKit2 automatically
2307         https://bugs.webkit.org/show_bug.cgi?id=44336
2308
2309         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
2310         The new script does not satisfy the needs of this file however using normal includes
2311         is generally better here.
2312         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
2313         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
2314         given frameworks by files in the current directory (and subdirectories).
2315         In the future this needs to be rewritten in perl for being able to use on Windows.
2316
2317 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
2318
2319         Reviewed by Ariya Hidayat.
2320
2321         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
2322         https://bugs.webkit.org/show_bug.cgi?id=43010
2323
2324         * QtTestBrowser/launcherwindow.cpp:
2325         (LauncherWindow::applyPrefs):
2326         * QtTestBrowser/main.cpp:
2327         (LauncherApplication::handleUserOptions):
2328
2329 2010-08-21  Sam Weinig  <sam@webkit.org>
2330
2331         Reviewed by Dan Bernstein.
2332
2333         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
2334         https://bugs.webkit.org/show_bug.cgi?id=44386
2335
2336         * MiniBrowser/mac/AppDelegate.m:
2337         (didRecieveMessageFromInjectedBundle):
2338         (didNavigateWithNavigationData):
2339         (-[BrowserAppDelegate init]):
2340         (-[BrowserAppDelegate applicationWillTerminate:]):
2341         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2342         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
2343         (-[BrowserStatisticsWindowController dealloc]):
2344         * MiniBrowser/mac/BrowserWindowController.m:
2345         (-[BrowserWindowController initWithPageNamespace:]):
2346         (-[BrowserWindowController fetch:]):
2347         (-[BrowserWindowController windowWillClose:]):
2348         (-[BrowserWindowController applicationTerminating]):
2349         (closePage):
2350         (runJavaScriptAlert):
2351         (runJavaScriptConfirm):
2352         (runJavaScriptPrompt):
2353         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2354         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2355         (didClearWindowObjectForFrame):
2356         * MiniBrowser/win/BrowserView.cpp:
2357         (BrowserView::goToURL):
2358         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2359         (WTR::PlatformWebView::~PlatformWebView):
2360
2361 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
2362
2363         Reviewed by Kenneth Rohde Christiansen.
2364
2365         WebKit does not build with Python 2.3
2366         https://bugs.webkit.org/show_bug.cgi?id=44373
2367
2368         Replaced the function sorted() by a call to sort()
2369         on the entry list.
2370         The function sorted() has been added to Python 2.4.
2371         The function method sort() of List works with older
2372         versions of Python.
2373
2374         * Scripts/create-html-entity-table:
2375
2376 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
2377
2378         Reviewed by Pavel Feldman.
2379
2380         Web Inspector: Inspector tests were disabled for GTK.
2381         https://bugs.webkit.org/show_bug.cgi?id=43977
2382
2383         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
2384         path before running tests.
2385
2386 2010-08-20  Daniel Bates  <dbates@rim.com>
2387
2388         Reviewed by Eric Seidel.
2389
2390         svn-apply doesn't detect empty line with Windows line endings
2391         after property value
2392         https://bugs.webkit.org/show_bug.cgi?id=43981
2393
2394         Part 2 of 2
2395
2396         Add unit tests that were not landed in the first commit.
2397
2398         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2399           - Added the following test cases:
2400             "SVN: binary file (isBinary true) using Windows line endings"
2401             "SVN: property diff, followed by file change diff using Windows line endings"
2402             "SVN: two consecutive property diffs using Windows line endings"
2403             "SVN: binary file with executable bit change usng Windows line endings"
2404             "SVN: binary file followed by property change on different file using Windows line endings"
2405             "SVN: binary file followed by file change on different file using Windows line endings"
2406             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2407             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2408         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2409           - Added the following test cases:
2410             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2411             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2412             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2413             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2414             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2415             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2416             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2417             "single-line '+' with trailing new line using Windows line endings"
2418             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2419             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2420             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2421         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2422           - Added the following test cases:
2423             "single-line '-' change followed by empty line with Windows line endings"
2424             "multi-line '+' change and start of binary patch with Windows line endings"
2425
2426 2010-08-20  Daniel Bates  <dbates@rim.com>
2427
2428         Reviewed by Eric Seidel.
2429
2430         svn-apply doesn't detect empty line with Windows line endings
2431         after property value
2432         https://bugs.webkit.org/show_bug.cgi?id=43981
2433
2434         Fixes an issue where an empty line following the property value
2435         in an SVN property change diff would not be detected if it had
2436         Windows line endings (i.e. ended in CRLF). Hence it was consumed
2437         as if it was part of a multi-line property value. 
2438
2439         * Scripts/VCSUtils.pm:
2440           - Modified parseSvnPropertyValue() to detect empty line
2441             with Windows line endings.
2442           - Added toWindowsLineEndings().
2443         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2444           - Added the following test cases:
2445             "SVN: binary file (isBinary true) using Windows line endings"
2446             "SVN: property diff, followed by file change diff using Windows line endings"
2447             "SVN: two consecutive property diffs using Windows line endings"
2448             "SVN: binary file with executable bit change usng Windows line endings"
2449             "SVN: binary file followed by property change on different file using Windows line endings"
2450             "SVN: binary file followed by file change on different file using Windows line endings"
2451             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2452             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2453         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2454           - Added the following test cases:
2455             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2456             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2457             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2458             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2459             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2460             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2461             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2462             "single-line '+' with trailing new line using Windows line endings"
2463             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2464             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2465             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2466         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2467           - Added the following test cases:
2468             "single-line '-' change followed by empty line with Windows line endings"
2469             "multi-line '+' change and start of binary patch with Windows line endings"
2470
2471 2010-08-19  David Kilzer  <ddkilzer@apple.com>
2472
2473         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
2474
2475         * MiniBrowser/mac/BrowserWindowController.m:
2476         (decidePolicyForNavigationAction): Updated method signature.
2477         (decidePolicyForNewWindowAction): Updated method signature.
2478
2479 2010-08-19  Adam Roben  <aroben@apple.com>
2480
2481         Test that NP_Initialize and NP_GetEntryPoints are called in the
2482         correct order
2483
2484         The order differs between Mac and Windows (see r38858).
2485
2486         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
2487         NP_Initialize when loading QuickTime when running
2488         plugins/embed-attributes-setting.html in WebKit2 on Windows
2489
2490         Reviewed by Sam Weinig.
2491
2492         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
2493         a boolean to record whether NP_GetEntryPoints has been called.
2494         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
2495         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
2496         if NP_GetEntryPoints has been called already. This matches
2497         Silverlight's behavior.
2498
2499 2010-08-19  Adam Roben  <aroben@apple.com>
2500
2501         Make build-webkittestrunner build TestNetscapePlugIn on Windows
2502
2503         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
2504
2505         Reviewed by Sam Weinig.
2506
2507         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
2508         Threaded it in between ImageDiff and InjectedBundleGenerated.
2509
2510 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2511
2512         Reviewed by Adam Barth.
2513
2514         install rietveld's upload script from a versioned url
2515         https://bugs.webkit.org/show_bug.cgi?id=44291
2516
2517         autoinstall expects the file at a given URL to never change.
2518         In order to be able to update the file, we need to be able to
2519         change the path.
2520
2521         * Scripts/webkitpy/thirdparty/__init__.py:
2522
2523 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2524
2525         Reviewed by Adam Barth.
2526
2527         add --webkit_patch_id to reitveld uploads
2528         https://bugs.webkit.org/show_bug.cgi?id=44289
2529
2530         This is the first step in having rietveld store which
2531         patches have been uploaded and getting rid of the
2532         in-rietveld flag.
2533
2534         * Scripts/webkitpy/common/net/rietveld.py:
2535         * Scripts/webkitpy/tool/mocktool.py:
2536         * Scripts/webkitpy/tool/steps/postcodereview.py:
2537
2538 2010-08-19  Kenneth Russell  <kbr@google.com>
2539
2540         Reviewed by David Levin.
2541
2542         Adjust my status from committer to reviewer
2543         https://bugs.webkit.org/show_bug.cgi?id=44277
2544
2545         * Scripts/webkitpy/common/config/committers.py:
2546
2547 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2548
2549         Reviewed by Yury Semikhatsky.
2550
2551         Chromium DevTools: remove injected script fetcher from test harness.
2552         https://bugs.webkit.org/show_bug.cgi?id=44266
2553
2554         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2555         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2556
2557 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2558
2559         Reviewed by Yury Semikhatsky.
2560
2561         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
2562         Now that we populate front-end after its onload handler, we don't need
2563         to install injected script early. Exposing injected script source on the WebCore
2564         level here.
2565         https://bugs.webkit.org/show_bug.cgi?id=44029
2566
2567         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2568         (DRTDevToolsAgent::runtimePropertyChanged):
2569         (DRTDevToolsAgent::delayedFrontendLoaded):
2570         (DRTDevToolsAgent::frontendLoaded):
2571         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2572
2573 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2574
2575         Reviewed by Kenneth Rohde Christiansen.
2576
2577         [Gtk] Enable view mode media feature layout test
2578         https://bugs.webkit.org/show_bug.cgi?id=43278
2579
2580         Add view mode media feature testing infrastructure, and add
2581         placeholder methods for the other platforms'
2582         LayoutTestControllers.
2583
2584         * DumpRenderTree/LayoutTestController.cpp:
2585         (setViewModeMediaFeatureCallback):
2586         (LayoutTestController::staticFunctions):
2587         * DumpRenderTree/LayoutTestController.h:
2588         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2589         (LayoutTestController::setViewModeMediaFeature):
2590         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2591         (LayoutTestController::setViewModeMediaFeature):
2592         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2593         (LayoutTestController::setViewModeMediaFeature):
2594         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2595         (LayoutTestController::setViewModeMediaFeature):
2596
2597 2010-08-18  Mark Rowe  <mrowe@apple.com>
2598
2599         Reviewed by Sam Weinig.
2600
2601         Make it so the WebKit2 test slave runs the WebKit2 tests
2602
2603         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2604
2605 2010-08-18  Sam Weinig  <sam@webkit.org>
2606
2607         Reviewed by Mark Rowe.
2608
2609         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
2610         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
2611         module and the TestNetscapePlugin.
2612
2613         * Scripts/old-run-webkit-tests:
2614
2615 2010-08-18  Adam Roben  <aroben@apple.com>
2616
2617         Fix hang when saving crash logs on Windows
2618
2619         * Scripts/old-run-webkit-tests:
2620         (setUpWindowsCrashLogSaving):
2621         (END):
2622         Pass -s to regtool so it will write the Auto value as a string instead
2623         of as a number. This was causing a "do you want to debug?" dialog to
2624         appear.
2625
2626 2010-08-17  Victor Wang  <victorw@chromium.org>
2627
2628         Unreviewed. Fixed chromium incremental test json upload.
2629         Quote builder name and test results server in url.
2630
2631         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2632
2633 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2634
2635         Reviewed by Ariya Hidayat.
2636
2637         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
2638         https://bugs.webkit.org/show_bug.cgi?id=44124
2639
2640         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
2641         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
2642         Symbian dependencies.
2643
2644         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2645         (WebCore::DumpRenderTree::open):
2646         * QtTestBrowser/launcherwindow.cpp:
2647         (LauncherWindow::init):
2648         (LauncherWindow::toggleFullScreenMode):
2649         (LauncherWindow::showFPS):
2650         (LauncherWindow::updateFPS):
2651         * QtTestBrowser/launcherwindow.h:
2652         (WindowOptions::WindowOptions):
2653         * QtTestBrowser/mainwindow.cpp:
2654         (MainWindow::buildUI):
2655
2656 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2657
2658         Reviewed by David Levin.
2659
2660         new-run-webkit-tests: remove --show-sources option
2661
2662         --show-sources is pretty much obsolete with --trace everything, so
2663         I'm removing it.
2664
2665         Also rename a couple of methods in the TestTextDiff class to make their
2666         intended visibility (private) more obvious.
2667
2668         https://bugs.webkit.org/show_bug.cgi?id=44143
2669
2670         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2671         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2672         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2673         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2674         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2675
2676 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2677
2678         Reviewed by David Levin.
2679
2680         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
2681
2682         This code bit-rotted at some point more than a year ago, and nobody seems
2683         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
2684         should support instead, making this flag unnecessary anyway.
2685
2686         https://bugs.webkit.org/show_bug.cgi?id=44141
2687
2688         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2689         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2690         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
2691
2692 2010-08-17  Victor Wang  <victorw@chromium.org>
2693
2694         Reviewed by Ojan Vafai.
2695
2696         Update json results generator to have incremental json including
2697         results for tests that pass in current run but failed before.
2698
2699         https://bugs.webkit.org/show_bug.cgi?id=44119
2700
2701         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2702         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2703         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2704
2705 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2706
2707         Reviewed by Eric Seidel.
2708
2709         fix test-webkitpy, add easy way to find a checkout root
2710
2711         test-webkitpy currently doesn't work right if run from someplace other
2712         than the checkout root, and it spews a bunch of debug logging because
2713         the deduplicate_tests tests contaminates the test environment.
2714
2715         This patch cleans up the deduplicate_tests unit tests, and creates
2716         two new methods in scm.py: find_checkout_root() and default_scm(),
2717         both of which use a single algorithm for guessing what checkout root
2718         to use if you aren't explicitly told one from a path.
2719
2720         https://bugs.webkit.org/show_bug.cgi?id=44001
2721
2722         * Scripts/deduplicate-tests:
2723         * Scripts/webkitpy/common/checkout/scm.py:
2724         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2725         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2726         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2727         * Scripts/webkitpy/layout_tests/port/test.py:
2728         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2729         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2730         * Scripts/webkitpy/tool/main.py:
2731
2732 2010-08-17  Victor Wang  <victorw@chromium.org>
2733
2734         Reviewed by Ojan Vafai.
2735
2736         Add support to the test results server for downloading json that
2737         contains test list only.
2738
2739         This is for json results generator to generate incremental json
2740         results so that it includes results not only for tests failed in
2741         current run, but also tests failed before.
2742
2743         Also set the results type to "N" (no data) instead of "P" (pass)
2744         if test results cannot be found in incremental json file.
2745
2746         https://bugs.webkit.org/show_bug.cgi?id=44117
2747
2748         * TestResultServer/handlers/testfilehandler.py:
2749         * TestResultServer/model/jsonresults.py:
2750         * TestResultServer/model/jsonresults_unittest.py:
2751
2752 2010-08-17  Adam Roben  <aroben@apple.com>
2753
2754         Use the right path style
2755
2756         * Scripts/old-run-webkit-tests:
2757
2758 2010-08-17  Adam Roben  <aroben@apple.com>
2759
2760         Fix typo
2761
2762         * Scripts/old-run-webkit-tests:
2763
2764 2010-08-17  Adam Roben  <aroben@apple.com>
2765
2766         Don't hang when running run-webkit-tests as a non-Administrator on
2767         Vista/7
2768
2769         * Scripts/old-run-webkit-tests:
2770         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
2771         post-mortem debugger, rather than using NTSD itself. The latter waits
2772         for user input when it fails to set the registry values; the former
2773         does not.
2774
2775 2010-08-17  Adam Roben  <aroben@apple.com>
2776
2777         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
2778         save crash logs on Windows
2779
2780         The crash logs are saved to /tmp/layout-test-results and have names
2781         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
2782
2783         Unfortunately, crashes in the WebKit2 web process are recorded as
2784         time-outs by run-webkit-tests. Fixing this is covered by
2785         <http://webkit.org/b/44121>.
2786
2787         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
2788         DumpRenderTree should save a stack trace and/or dump file when it
2789         crashes
2790
2791         Reviewed by Sam Weinig.
2792
2793         * DumpRenderTree/win/DumpRenderTree.cpp:
2794         (exceptionFilter):
2795         (main):
2796         * WebKitTestRunner/win/TestControllerWin.cpp:
2797         (WTR::exceptionFilter):
2798         (WTR::TestController::platformInitialize):
2799         These changes set up an exception filter that prints #CRASHED to
2800         stderr, then lets the exception propagate normally. This allows
2801         run-webkit-tests to detect when we've crashed even when a post-mortem
2802         debugger attaches to the process.
2803
2804         * Scripts/old-run-webkit-tests:
2805         (top level): Declared some variables used by the crash-log-saving
2806         code.
2807         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
2808         that the post-mortem debugger has access to it.
2809         (toCygwinPath): Added. This is the opposite of toWindowsPath.
2810         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
2811         stderr, consider it a crash.
2812         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
2813         debugger, then sets ntsd as the post-mortem debugger. ntsd is
2814         configured to save a crash log and then quit automatically.
2815         (END): Added. Restores the previous post-mortem debugger when the
2816         script exits.
2817
2818 2010-08-17  Victor Wang  <victorw@chromium.org>
2819
2820         Reviewed by ojan@chromium.org.
2821
2822         Update test results server:
2823         1. Normalize test results and times after merging (prune tests where
2824            all runs pass or do not have data, truncate all test items to max
2825            number of builds)
2826         2. times should be int not string.
2827         3. when inserting a new test item, should keep old data regardless
2828            whether or not they have same item type with new one.
2829
2830         https://bugs.webkit.org/show_bug.cgi?id=43861
2831
2832         * TestResultServer/model/jsonresults.py:
2833         * TestResultServer/model/jsonresults_unittest.py:
2834
2835 2010-08-16  Sam Weinig  <sam@webkit.org>
2836
2837         Reviewed by Mark Rowe.
2838
2839         Add WebKit2 Mac tester to buildbot.
2840
2841         * BuildSlaveSupport/build.webkit.org-config/config.json:
2842         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2843
2844 2010-08-16  Paul Sawaya  <psawaya@apple.com>
2845
2846         Reviewed by Chris Marrin.
2847
2848         Added shader validation via ANGLE
2849         https://bugs.webkit.org/show_bug.cgi?id=42405
2850
2851         Added ANGLE to webkit build
2852
2853         * Scripts/build-webkit:
2854
2855 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
2856
2857         [wx] Build fix, do not build WebCore as a convenience library as this leads to
2858         errors in the Win build w/export symbols and causes problems with DOM bindings
2859         debugging in gdb.
2860
2861         * DumpRenderTree/wscript:
2862         * Scripts/build-webkit:
2863         * wx/browser/wscript:
2864         * wx/build/settings.py:
2865         * wx/build/waf_extensions.py:
2866
2867 2010-08-16  Dan Bernstein  <mitz@apple.com>
2868
2869         Build fix.
2870
2871         * WebKitTestRunner/TestController.cpp:
2872         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
2873         (WTR::TestController::initialize): Ditto.
2874
2875 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2876
2877         Reviewed by Kenneth Rohde Christiansen.
2878
2879         Handle content size change in WebKit2
2880         Re-landing after fix.
2881
2882         https://bugs.webkit.org/show_bug.cgi?id=43198
2883
2884         * MiniBrowser/mac/BrowserWindowController.m:
2885         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2886         * MiniBrowser/win/BrowserView.cpp:
2887         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2888
2889 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2890
2891         Unreviewed, rolling out r65419.
2892         http://trac.webkit.org/changeset/65419
2893         https://bugs.webkit.org/show_bug.cgi?id=44053
2894
2895         Broke the Windows build (Requested by bbandix on #webkit).
2896
2897         * MiniBrowser/mac/BrowserWindowController.m:
2898         (-[BrowserWindowController awakeFromNib]):
2899         * MiniBrowser/win/BrowserView.cpp:
2900         (BrowserView::create):
2901
2902 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2903
2904         Reviewed by Kenneth Rohde Christiansen.
2905
2906         Handle content size change in WebKit2
2907
2908         https://bugs.webkit.org/show_bug.cgi?id=43198
2909
2910         * MiniBrowser/mac/BrowserWindowController.m:
2911         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2912         * MiniBrowser/win/BrowserView.cpp:
2913         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2914
2915 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
2916
2917         Add my new email address to committers.py.
2918
2919         * Scripts/webkitpy/common/config/committers.py:
2920
2921 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
2922
2923         Add my old e-mail addresses to committers.py.
2924
2925         * Scripts/webkitpy/common/config/committers.py:
2926
2927 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2928
2929         WebEditorClient::didBeginEditing is never called in WebKit2
2930         https://bugs.webkit.org/show_bug.cgi?id=42939
2931
2932         Reviewed by Sam Weinig.
2933
2934         * WebKitTestRunner/PlatformWebView.h:
2935         Declare focus().
2936
2937         * WebKitTestRunner/TestController.cpp:
2938         (WTR::TestController::resetStateToConsistentValues):
2939         Focus the PlatformWebView.
2940
2941         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2942         (WTR::PlatformWebView::focus):
2943         Stubbed.
2944
2945         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2946         (WTR::PlatformWebView::focus):
2947         Focus the view.
2948
2949 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2950
2951         run-webkit-tests should not strip editing callbacks when using
2952         WebKitTestRunner on Windows
2953         https://bugs.webkit.org/show_bug.cgi?id=44000
2954
2955         Reviewed by Mark Rowe.
2956
2957         * Scripts/old-run-webkit-tests:
2958         Leave $stripEditingCallbacks undefined until we look for command-line
2959         arguments. If using WebKit2, set it to 0 if not explicity set on the
2960         command line. Later, set it to isCygwin() to match old behavior if it is
2961         not yet defined.
2962
2963 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
2964
2965         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
2966
2967         * wx/build/settings.py:
2968
2969 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
2970
2971         Reviewed by Kenneth Rohde Christiansen.
2972
2973         [GTK] autogen.sh not executed if build-webkit options change
2974         https://bugs.webkit.org/show_bug.cgi?id=42266
2975
2976         Rerun autogen.sh in situations where the arguments to build-webkit have
2977         changed since the previous build. This will fix some issues on the bots
2978         where the build does not notice changes to default build-webkit arguments.
2979
2980         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
2981
2982 2010-08-14  Eric Seidel  <eric@webkit.org>
2983
2984         Unreviewed.  Another fix to support python 2.3.
2985
2986         Add support for MathML entities
2987         https://bugs.webkit.org/show_bug.cgi?id=43949
2988
2989         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
2990          - It looks like our simplejson is version 1.7.3 which
2991            should be python 2.3 compatible.  But someone modified
2992            our copy slightly from the original source.
2993            I've removed the relative import in hopes this fixes
2994            the problem.
2995
2996 2010-08-13  Eric Seidel  <eric@webkit.org>
2997
2998         Unreviewed.  Build fix only.
2999
3000         Add support for MathML entities
3001         https://bugs.webkit.org/show_bug.cgi?id=43949
3002
3003         * Scripts/create-html-entity-table:
3004          - Hack sys.path to avoid executing 2.5 dependent python
3005            on systems (like chromium-win and Tiger) which do not have 2.5 python.
3006
3007 2010-08-13  Adam Barth  <abarth@webkit.org>
3008
3009         Reviewed by Eric Seidel.
3010
3011         Rename some concepts in HTML entity search to be more self-documenting
3012         https://bugs.webkit.org/show_bug.cgi?id=44004
3013
3014         Reflect name change in generator script.
3015
3016         * Scripts/create-html-entity-table:
3017
3018 2010-08-12  Adam Barth  <abarth@webkit.org>
3019
3020         Reviewed by Eric Seidel.
3021
3022         Add support for MathML entities
3023         https://bugs.webkit.org/show_bug.cgi?id=43949
3024
3025         A script for generating the C++ state data structure describing all the
3026         entities from a JSON description.
3027
3028         * Scripts/create-html-entity-table: Added.
3029
3030 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
3031
3032         Reviewed by Eric Seidel.
3033
3034         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
3035         check for exceptions on all threads, not just the first thread.
3036         
3037         This change also changes the logging behavior for wedged threads
3038         to only dump the stacks of threads that are actually wedged.
3039
3040         Refactor the thread classes in the dump_render_tree_thread module
3041         to make the contract between TestRunner and TestShellThread clearer.
3042
3043         Added a bunch of unit tests.
3044         https://bugs.webkit.org/show_bug.cgi?id=38561
3045
3046         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3047         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3048         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3049
3050 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
3051
3052         Reviewed by Shinichiro Hamaji.
3053
3054         Add test_expectations.txt syntax checker to check-webkit-style.
3055         https://bugs.webkit.org/show_bug.cgi?id=43899
3056
3057         Just utilizing layout_tests/layout_package/test_expectations.py for checking
3058         the syntax of test_expectations.txt.
3059         This change also moves tab checking class from style/checkers/text.py to
3060         style/checkers/common.py for sharing code.
3061
3062         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3063         * Scripts/webkitpy/style/checker.py:
3064         * Scripts/webkitpy/style/checkers/common.py:
3065         * Scripts/webkitpy/style/checkers/common_unittest.py:
3066         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
3067         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
3068         * Scripts/webkitpy/style/checkers/text.py:
3069         * Scripts/webkitpy/style_references.py:
3070
3071 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3072
3073         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
3074         https://bugs.webkit.org/show_bug.cgi?id=43945
3075
3076         Reviewed by Sam Weinig.
3077
3078         * WebKitTestRunner/TestInvocation.cpp:
3079         (WTR::sizeWebViewForCurrentTest):
3080         Allow for a Windows-style path.
3081
3082         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3083         (WTR::PlatformWebView::resizeTo):
3084         Call SetWindowPos to resize the view window.
3085
3086 2010-08-12  David Levin  <levin@chromium.org>
3087
3088         Build break fix.
3089
3090         * WebKitTestRunner/TestController.cpp:
3091         (WTR::TestController::resetStateToConsistentValues): Removed usage
3092         of a variable that doesn't exist in the class.
3093
3094 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3095
3096         WebKitTestRunner needs to run tests without using native controls
3097         https://bugs.webkit.org/show_bug.cgi?id=43772
3098
3099         Reviewed by Sam Weinig.
3100
3101         * WebKitTestRunner/TestController.cpp:
3102         (WTR::TestController::initialize):
3103         Call platformInitializeContext().
3104
3105         * WebKitTestRunner/TestController.h:
3106         Declare platformInitializeContext().
3107
3108         * WebKitTestRunner/mac/TestControllerMac.mm:
3109         (WTR::TestController::platformInitializeContext):
3110         Stubbed.
3111
3112         * WebKitTestRunner/win/TestControllerWin.cpp:
3113         (WTR::TestController::platformInitializeContext):
3114         Call WKContextSetShouldPaintNativeControls() to disable native control
3115         drawing.
3116
3117 2010-08-12  Sam Weinig  <sam@webkit.org>
3118
3119         Reviewed by Alexey Proskuryakov.
3120
3121         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
3122         https://bugs.webkit.org/show_bug.cgi?id=43653
3123
3124         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3125         (WTR::InjectedBundle::InjectedBundle):
3126         (WTR::InjectedBundle::didReceiveMessage):
3127         (WTR::InjectedBundle::beginTesting):
3128         (WTR::InjectedBundle::done):
3129         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3130         (WTR::InjectedBundle::isTestRunning):
3131         (WTR::InjectedBundle::):
3132         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3133         (WTR::InjectedBundlePage::stopLoading):
3134         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3135         (WTR::InjectedBundlePage::dump):
3136         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3137         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3138         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3139         (WTR::InjectedBundlePage::didClearWindowForFrame):
3140         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3141         (WTR::InjectedBundlePage::willAddMessageToConsole):
3142         (WTR::InjectedBundlePage::willSetStatusbarText):
3143         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3144         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3145         (WTR::InjectedBundlePage::shouldBeginEditing):
3146         (WTR::InjectedBundlePage::shouldEndEditing):
3147         (WTR::InjectedBundlePage::shouldInsertNode):
3148         (WTR::InjectedBundlePage::shouldInsertText):
3149         (WTR::InjectedBundlePage::shouldDeleteRange):
3150         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3151         (WTR::InjectedBundlePage::shouldApplyStyle):
3152         (WTR::InjectedBundlePage::didBeginEditing):
3153         (WTR::InjectedBundlePage::didEndEditing):
3154         (WTR::InjectedBundlePage::didChange):
3155         (WTR::InjectedBundlePage::didChangeSelection):
3156         Don't do any work if we are not currently running a test.
3157
3158         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3159         * WebKitTestRunner/StringFunctions.h:
3160         (WTR::toCF):
3161         Add conversion function for WKURLRef -> CFURLRef
3162
3163         * WebKitTestRunner/TestController.cpp:
3164         (WTR::TestController::TestController):
3165         (WTR::TestController::initialize):
3166         (WTR::TestController::resetStateToConsistentValues):
3167         (WTR::TestController::runTest):
3168         (WTR::TestController::didFinishLoadForFrame):
3169         * WebKitTestRunner/TestController.h:
3170         (WTR::TestController::):
3171         * WebKitTestRunner/TestInvocation.cpp:
3172         (WTR::TestInvocation::invoke):
3173         * WebKitTestRunner/TestInvocation.h:
3174         Move resetting code to TestController.
3175
3176         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3177         * WebKitTestRunner/mac/TestControllerMac.mm:
3178         (WTR::TestController::runUntil):
3179         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3180         * WebKitTestRunner/win/TestControllerWin.cpp:
3181         (WTR::TestController::runUntil):
3182         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
3183         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3184         Move runUntil to TestController.
3185
3186 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3187
3188         Unreviewed.
3189
3190         Adding myself to the committers list.
3191
3192         * Scripts/webkitpy/common/config/committers.py:
3193
3194 2010-08-12  Hayato Ito  <hayato@chromium.org>
3195
3196         Reviewed by Tony Chang.
3197
3198         Merge pretty printers for gdb.
3199         https://bugs.webkit.org/show_bug.cgi?id=43850
3200
3201         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
3202         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
3203         webcore.py is left for backward compatibility.
3204
3205         * gdb/webcore.py:
3206         * gdb/webkit.py: Added.
3207         * gdb/wtf.py: Removed.
3208
3209 2010-08-11  Tony Chang  <tony@chromium.org>
3210
3211         Reviewed by David Levin.
3212
3213         [chromium] add google-chrome layout test result directories
3214         https://bugs.webkit.org/show_bug.cgi?id=43889
3215
3216         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3217         * Scripts/webkitpy/layout_tests/port/factory.py:
3218         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
3219         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3220
3221 2010-08-11  Kent Tamura  <tkent@chromium.org>
3222
3223         Reviewed by Dimitri Glazkov.
3224
3225         [DRT/Chromium] Disable accelerated compositing
3226         https://bugs.webkit.org/show_bug.cgi?id=43894
3227
3228         Disable accelerated compositing because DRT is not ready for
3229         it. This change fixes hundreds of test crashes on Windows and
3230         Linux.
3231
3232         * DumpRenderTree/chromium/TestShell.cpp:
3233         (TestShell::resetWebSettings):
3234
3235 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3236
3237         Unreviewed. Adding my Collabora personality to the list.
3238
3239         * Scripts/webkitpy/common/config/committers.py:
3240
3241 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
3242
3243         Adding myself as a reviewer.
3244
3245         * Scripts/webkitpy/common/config/committers.py:
3246
3247 2010-08-11  Daniel Bates  <dbates@rim.com>
3248
3249         Reviewed by Darin Adler.
3250
3251         Perl warnings when running commit-log-editor
3252         https://bugs.webkit.org/show_bug.cgi?id=43856
3253
3254         Fixes Perl warnings introduced by the patch for Bug #40548.
3255
3256         Perl doesn't have symbolic names for True/False. Instead, we
3257         should use boolean values. Moreover, the variable installedEditorApplication
3258         is not be used and should be renamed builtEditorApplication so that it
3259         uses the existing machinery to set the commit log editor application.
3260
3261         * Scripts/commit-log-editor:
3262
3263 2010-08-11  Adam Barth  <abarth@webkit.org>
3264
3265         Reviewed by Eric Seidel.
3266
3267         Trying waiting for httpd lock in the EWS
3268         https://bugs.webkit.org/show_bug.cgi?id=43833
3269
3270         If this works, we can probably run the tests on the mac-ews, which
3271         would be very exciting.  :)
3272
3273         * Scripts/webkitpy/tool/steps/runtests.py:
3274
3275 2010-08-11  Marcus Bulach  <bulach@chromium.org>
3276
3277         Reviewed by Eric Seidel.
3278
3279         Check in a script to list redundant test outputs.
3280         https://bugs.webkit.org/show_bug.cgi?id=37630
3281
3282         If e.g. platform/mac-leopard is missing an expected test output, we
3283         fall back on platform/mac.  This means it's possible to grow redundant
3284         test outputs, where we have the same expected data in both a platform
3285         directory and another platform it falls back on.
3286         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
3287
3288         * Scripts/deduplicate-tests: Added.
3289         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
3290         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
3291
3292 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3293
3294         Reviewed by Ariya Hidayat.
3295
3296         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
3297         https://bugs.webkit.org/show_bug.cgi?id=43853
3298
3299         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
3300         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
3301         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
3302         to slots at all.
3303
3304         * QtTestBrowser/launcherwindow.cpp:
3305         (LauncherWindow::createChrome):
3306         (LauncherWindow::animatedFlip):
3307         (LauncherWindow::animatedYFlip):
3308         * QtTestBrowser/launcherwindow.h:
3309
3310 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3311
3312         Reviewed by Simon Hausmann.
3313
3314         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
3315         https://bugs.webkit.org/show_bug.cgi?id=43851
3316
3317         All window options data (including the bool holding if the view is either QWebView or
3318         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
3319         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
3320         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
3321         getting broken.
3322
3323         Patch addresses this issue.
3324
3325         * QtTestBrowser/launcherwindow.cpp:
3326         (LauncherWindow::createChrome):
3327         (LauncherWindow::toggleWebView):
3328         (LauncherWindow::toggleAcceleratedCompositing):
3329
3330 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
3331
3332         Reviewed by Ariya Hidayat.
3333
3334         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
3335         https://bugs.webkit.org/show_bug.cgi?id=43831
3336
3337         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
3338
3339         * QtTestBrowser/webview.cpp:
3340         (WebViewGraphicsBased::WebViewGraphicsBased):
3341         (WebViewGraphicsBased::animatedYFlip):
3342
3343 2010-08-11  Darin Adler  <darin@apple.com>
3344
3345         Reviewed by John Sullivan.
3346
3347         Improved editor options for prepare-ChangeLog and commit-log-editor
3348         https://bugs.webkit.org/show_bug.cgi?id=40548
3349
3350         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
3351         values like "xed --launch --wait" work properly.
3352
3353         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
3354         use a command line tool with the $openChangeLogs feature.
3355
3356 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
3357
3358         Reviewed by Pavel Feldman.
3359
3360         Web Inspector: remove InjectDispatch.js
3361         https://bugs.webkit.org/show_bug.cgi?id=43835
3362
3363         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3364         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3365
3366 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
3367
3368         Reviewed by Eric Seidel.
3369
3370         webkit-patch should refuse to run under Win32 Python
3371         https://bugs.webkit.org/show_bug.cgi?id=40962
3372
3373         Given that there are lots of places in webkit-patch's code that
3374         assume unix-style filenames (forward slashes), webkit-patch fails
3375         with weird file-not-found errors when run under a native windows
3376         Python. It would be nice if we just trapped this and errored out
3377         at the beginning, rather than producing unpredictable errors.
3378
3379         * Scripts/webkit-patch:
3380
3381 2010-08-10  Kent Tamura  <tkent@chromium.org>
3382
3383         Unreviewed, build fix.
3384         
3385         Chromium build fix for r65107.
3386
3387         * DumpRenderTree/chromium/LayoutTestController.cpp:
3388         (LayoutTestController::suspendAnimations):
3389         (LayoutTestController::resumeAnimations):
3390
3391 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
3392
3393         Reviewed by Xan Lopez.
3394
3395         [GTK] http/tests/media/video-cookie.html fails
3396         https://bugs.webkit.org/show_bug.cgi?id=42240
3397
3398         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3399         (LayoutTestController::setAlwaysAcceptCookies): create the
3400         SoupCookieJar if it does not exist. Otherwise the accept policy
3401         won't be set.
3402
3403 2010-08-10  Chris Marrin  <cmarrin@apple.com>
3404
3405         Reviewed by Oliver Hunt.
3406
3407         Add suspendAnimations/resumeAnimation API to DRT
3408         https://bugs.webkit.org/show_bug.cgi?id=43733
3409         
3410         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
3411         Calls functions with the same names on AnimationController for the 
3412         mainFrame.
3413
3414         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3415         * DumpRenderTree/LayoutTestController.cpp:
3416         (suspendAnimationsCallback):
3417         (resumeAnimationsCallback):
3418         (LayoutTestController::staticFunctions):
3419         * DumpRenderTree/LayoutTestController.h:
3420         * DumpRenderTree/chromium/LayoutTestController.cpp:
3421         (LayoutTestController::LayoutTestController):
3422         (LayoutTestController::suspendAnimations):
3423         (LayoutTestController::resumeAnimations):
3424         * DumpRenderTree/chromium/LayoutTestController.h:
3425         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3426         (LayoutTestController::suspendAnimations):
3427         (LayoutTestController::resumeAnimations):
3428         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3429         (LayoutTestController::suspendAnimations):
3430         (LayoutTestController::resumeAnimations):
3431         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3432         (LayoutTestController::suspendAnimations):
3433         (LayoutTestController::resumeAnimations):
3434         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3435         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3436         (LayoutTestController::suspendAnimations):
3437         (LayoutTestController::resumeAnimations):
3438         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3439         (LayoutTestController::suspendAnimations):
3440         (LayoutTestController::resumeAnimations):
3441
3442 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3443
3444         Reviewed by Ojan Vafai.
3445
3446         [Chromium/DRT] Enable saving layout test results.
3447         https://bugs.webkit.org/show_bug.cgi?id=43796
3448
3449         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
3450             parameters to the new-run-webkit-tests, including the name
3451             of the test results server.
3452
3453 2010-08-10  Jian Li  <jianli@chromium.org>
3454
3455         More chromium build fix.
3456
3457         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3458         (MockSpellCheck::spellCheckWord):
3459         (MockSpellCheck::initializeIfNeeded):
3460         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3461         (NotificationPresenter::grantPermission):
3462         (NotificationPresenter::show):
3463         (NotificationPresenter::checkPermission):
3464
3465 2010-08-10  Jian Li  <jianli@chromium.org>
3466
3467         Chromium build fix.
3468
3469         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3470         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3471
3472 2010-08-10  Victor Wang  <victorw@chromium.org>
3473
3474         Reviewed by Ojan Vafai.
3475
3476         Update test results server merge logic so the aggregated
3477         results and times are updated for tests that are
3478         in aggragated json but not in incremental json.
3479
3480         Also update unittest to test this case.
3481
3482         https://bugs.webkit.org/show_bug.cgi?id=43769
3483
3484         * TestResultServer/model/jsonresults.py:
3485         * TestResultServer/model/jsonresults_unittest.py:
3486
3487 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3488
3489         Reviewed by Ariya Hidayat.
3490
3491         [Qt] QtTestBrowser: proper set scene rect
3492
3493         When resizesToContents is ON scene's rect is set to the boundary of
3494         the mainFrame. However, navigating to other web page should keep resizing
3495         scene's rect according to the new document loaded. Patch addresses this issue.
3496
3497         Now resizesToContents and scrolling properly work on QtTestBrowser.
3498
3499         * QtTestBrowser/webview.cpp:
3500         (WebViewGraphicsBased::setPage):
3501         (WebViewGraphicsBased::contentsSizeChanged):
3502         (WebViewGraphicsBased::setResizesToContents):
3503         (WebViewGraphicsBased::resizeEvent):
3504         * QtTestBrowser/webview.h:
3505
3506 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3507
3508         Reviewed by Ariya Hidayat.
3509
3510         [Qt] QtTestBrowser: Clean up LauncherWindow code.
3511
3512         * QtTestBrowser/launcherwindow.cpp:
3513         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
3514         (LauncherWindow::init): Fixed comments.
3515         (LauncherWindow::applyPrefs): Move the method around.
3516         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
3517
3518 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3519
3520         Reviewed by Ariya Hidayat.
3521
3522         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
3523
3524         It gets control+0 the same visual effect as control++ or control-.
3525
3526         * QtTestBrowser/launcherwindow.cpp:
3527         (LauncherWindow::toggleZoomTextOnly):
3528
3529 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3530
3531         Reviewed by Ariya Hidayat.
3532
3533         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
3534
3535         Not all instances of LauncherWindow need its own m_zoomLevel.
3536
3537         * QtTestBrowser/launcherwindow.cpp:
3538         * QtTestBrowser/launcherwindow.h:
3539
3540 2010-08-09  Sam Weinig  <sam@webkit.org>
3541
3542         Reviewed by Geoffrey Garen.
3543
3544         Add zoom support for injected bundle
3545         https://bugs.webkit.org/show_bug.cgi?id=43759
3546
3547         Use zoom factor SPI to implement zoom related eventSender functions.
3548
3549         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3550         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3551         (WTR::EventSendingController::textZoomIn):
3552         (WTR::EventSendingController::textZoomOut):
3553         (WTR::EventSendingController::zoomPageIn):
3554         (WTR::EventSendingController::zoomPageOut):
3555         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3556         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3557         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
3558
3559 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
3560
3561         Speculative chromium build fix III.
3562
3563         * DumpRenderTree/chromium/MockSpellCheck.h:
3564         * DumpRenderTree/chromium/NotificationPresenter.h:
3565         * DumpRenderTree/chromium/WebViewHost.h:
3566         (WebViewHost::addClearHeader):
3567         (WebViewHost::clearHeaders):
3568
3569 2010-08-09  Ojan Vafai  <ojan@chromium.org>
3570
3571         Reviewed by Tony Chang.
3572
3573         increase the number of test results that we save
3574         https://bugs.webkit.org/show_bug.cgi?id=43763
3575
3576         Now that we do incremental uploads, we can increase the number of
3577         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
3578
3579         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3580
3581 2010-08-09  Evan Martin  <evan@chromium.org>
3582
3583         Reviewed by Tony Chang.
3584
3585         [chromium] DRT error print statement incorrectly tries to print a FILE*
3586         https://bugs.webkit.org/show_bug.cgi?id=43747
3587
3588         * DumpRenderTree/chromium/ImageDiff.cpp:
3589         (writeFile): pass the correct pointer.
3590
3591 2010-08-09  Victor Wang  <victorw@chromium.org>
3592
3593         Reviewed by Ojan Vafai.
3594
3595         Upload incremental test results json to server by default.
3596
3597         https://bugs.webkit.org/show_bug.cgi?id=43743
3598
3599         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3600
3601 2010-08-09  Eric Seidel  <eric@webkit.org>
3602
3603         Reviewed by Adam Barth.
3604
3605         EWS bots wait 2 minutes between patches
3606         https://bugs.webkit.org/show_bug.cgi?id=43731
3607
3608         * Scripts/webkitpy/tool/bot/queueengine.py:
3609          - Don't sleep after failures.  This was a hold-over from
3610            an earlier design.
3611         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3612          - EWS bots were not properly reporting true/false from process_work_item.
3613            They were always returning None, thus false, thus always logging
3614            as a failure and sleeping 2 minutes after each patch.
3615
3616 2010-08-09  Sam Weinig  <sam@webkit.org>
3617
3618         Reviewed by Anders Carlsson.
3619
3620         Stub out EventSender for WebKitTestRunner
3621         https://bugs.webkit.org/show_bug.cgi?id=43703
3622
3623         * WebKitTestRunner/DerivedSources.make:
3624         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3625         Add ability to pass javascript arguments to the wrapped object.
3626
3627         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
3628         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
3629         (WTR::EventSendingController::create):
3630         (WTR::EventSendingController::EventSendingController):
3631         (WTR::EventSendingController::~EventSendingController):
3632         (WTR::EventSendingController::wrapperClass):
3633         (WTR::setExceptionForString):
3634         (WTR::EventSendingController::mouseDown):
3635         (WTR::EventSendingController::mouseUp):
3636         (WTR::EventSendingController::mouseMoveTo):
3637         (WTR::EventSendingController::keyDown):
3638         (WTR::EventSendingController::contextClick):
3639         (WTR::EventSendingController::leapForward):
3640         (WTR::EventSendingController::textZoomIn):
3641         (WTR::EventSendingController::textZoomOut):
3642         (WTR::EventSendingController::zoomPageIn):
3643         (WTR::EventSendingController::zoomPageOut):
3644         (WTR::EventSendingController::makeWindowObject):
3645         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
3646         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3647         (WTR::InjectedBundle::reset):
3648         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3649         (WTR::InjectedBundle::eventSendingController):
3650         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3651         (WTR::InjectedBundlePage::didClearWindowForFrame):
3652         Add stubbed out EventSenderController.
3653
3654         * WebKitTestRunner/InjectedBundle/GCController.h:
3655         Remove incorrect comment.
3656
3657         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3658         * WebKitTestRunner/win/InjectedBundle.vcproj: