2010-05-06 Anders Carlsson <andersca@apple.com>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-05-06  Anders Carlsson  <andersca@apple.com>
2
3         Reviewed by Darin Adler and Dan Bernstein..
4
5         REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
6         https://bugs.webkit.org/show_bug.cgi?id=38698
7         <rdar://problem/7942075>
8
9         Add a 'setPluginsEnabled' layoutTestController function for disabling plug-ins. This is only implemented on Mac currently
10         because the bug that needs this functionality is mac specific.
11
12         * DumpRenderTree/LayoutTestController.cpp:
13         (setPluginsEnabledCallback):
14         (LayoutTestController::staticFunctions):
15         * DumpRenderTree/LayoutTestController.h:
16         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
17         (LayoutTestController::setPluginsEnabled):
18         * DumpRenderTree/mac/DumpRenderTree.mm:
19         (resetDefaultsToConsistentValues):
20         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
21         (LayoutTestController::setPluginsEnabled):
22         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
23         (LayoutTestController::setPluginsEnabled):
24         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
25         (LayoutTestController::setPluginsEnabled):
26         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
27         (LayoutTestController::setPluginsEnabled):
28
29 2010-05-06  Jochen Eisinger  <jochen@chromium.org>
30
31         Reviewed by Dimitri Glazkov.
32
33         Make ImageDiff depend on WebKit. When compiled from within Chromium, WTF is not a standalone dynamic library but depends on WebKit.
34         https://bugs.webkit.org/show_bug.cgi?id=38632
35
36         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
37
38 2010-05-06  Simon Hausmann  <simon.hausmann@nokia.com>
39
40         Reviewed by Kenneth Rohde Christiansen.
41
42         [Qt] Replace public inspector url with private property for QtLauncher
43         https://bugs.webkit.org/show_bug.cgi?id=35340
44
45         Replace the public API with a private dynamic property until this feature
46         is ready.
47
48         * QtLauncher/main.cpp:
49         (LauncherWindow::init):
50
51 2010-05-05  Joseph Pecoraro  <joepeck@webkit.org>
52
53         Reviewed by Pavel Feldman.
54
55         Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js
56         https://bugs.webkit.org/show_bug.cgi?id=38449
57
58         * Scripts/webkitdirs.pm:
59
60 2010-05-05  Charles Wei  <charles.wei@torchmobile.com.cn>
61
62         Reviewed by George Staikos
63
64         This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
65         Make the test cases in fast/wcss optionional only when  WCSS is enabled.
66
67         https://bugs.webkit.org/show_bug.cgi?id=37848
68
69         * Scripts/old-run-webkit-tests:
70         * Scripts/webkitperl/features.pm:
71
72 2010-05-05  Kent Tamura  <tkent@chromium.org>
73
74         Reviewed by Eric Seidel.
75
76         [DRT/Chromium] Remove InitWebCoreSystemInterface() call
77         https://bugs.webkit.org/show_bug.cgi?id=38624
78
79         Chromium r45167 <http://src.chromium.org/viewvc/chrome?view=rev&revision=45167>
80         added InitWebCoreSystemInterface() to webkit/support/platform_support_mac.mm.
81         So we don't need to call it from DumpRenderTree.cpp anymore.
82
83         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
84         * DumpRenderTree/chromium/DumpRenderTree.cpp:
85         (main): Remove InitWebCoreSystemInterface().
86
87 2010-05-05  Dirk Pranke  <dpranke@chromium.org>
88
89         Reviewed by Eric Seidel.
90
91         new-run-webkit-tests: clean up newline handling in printing
92
93         The new printing module seems to handle newlines somewhat
94         inconsistently, especially in --verbose mode. This change cleans up
95         the code to make things more consistent and adds a bunch of unit tests.
96
97         https://bugs.webkit.org/show_bug.cgi?id=38616
98
99         * Scripts/webkitpy/common/array_stream.py: Added.
100         * Scripts/webkitpy/common/array_stream_unittest.py: Added.
101         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
102         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Added.
103         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
104         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
105         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
106         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
107
108 2010-05-05  James Robinson  <jamesr@chromium.org>
109
110         Reviewed by Adam Barth.
111
112         Ban the single letter 'l' as an identifier name
113         http://trac.webkit.org/changeset/58844
114
115         Add a lint rule to ban the single letter 'l' as an identifier name
116         since it is very easy to confuse with the numeral '1', especially
117         in code like WebCore/css/CSSHelper.cpp.
118
119         See http://trac.webkit.org/changeset/58844 as an example of a bug
120         caused by confusing short variable names.
121
122         * Scripts/webkitpy/style/checkers/cpp.py:
123         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
124
125 2010-05-04  Eric Seidel  <eric@webkit.org>
126
127         Reviewed by Shinichiro Hamaji.
128
129         PrettyPatch.pretty_diff("") should not hang
130         https://bugs.webkit.org/show_bug.cgi?id=38552
131
132         Also found a bug in PrettyPatch.pretty_diff where it would
133         hang when passed "" as input.
134
135         I suspect there may be bugs in prettify.rb (or our use there-of)
136         where it can hang, which would then cause the testing thread to hang.
137
138         * Scripts/webkitpy/common/prettypatch.py:
139          - Don't hang when passed ""
140         * Scripts/webkitpy/common/prettypatch_unittest.py:
141          - Test that we don't hang when passed ""
142         * Scripts/webkitpy/layout_tests/port/base.py:
143          - Add a FIXME that we should share code with prettypatch.rb
144
145 2010-05-04  Dirk Pranke  <dpranke@chromium.org>
146
147         Reviewed by Eric Seidel.
148
149         new-run-webkit-tests: turn off threading on the Chromium Mac port until
150         we can stabilize the port more and figure out why it is hanging so
151         frequently.
152
153         https://bugs.webkit.org/show_bug.cgi?id=38553
154
155         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
156           - override default_child_processes() and log a warning
157         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
158           - fix a typo that caused us to print a method object instead of the
159             value the method object returns in the case where there is only
160             one child process.
161         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
162           - Add unit tests for the output of run_webkit_tests - in this case,
163             the handling of --child-processes and --print config
164
165 2010-05-04  Timothy Hatcher  <timothy@apple.com>
166
167         Fix the find command in extract-localizable-strings so skip
168         directories are correctly skipped and header files are searched.
169
170         https://bugs.webkit.org/show_bug.cgi?id=38545
171         rdar://problem/7941295
172
173         Reviewed by Darin Adler.
174
175         * Scripts/extract-localizable-strings: Append -o after each -prune
176         so -and isn't implied. Surround all the -name arguments so they get
177         an implied -print action. Removed check for "icu". Skip any header that
178         ends in LocalizableStrings.h, so SafariLocalizableStrings.h is skipped.
179         * Scripts/update-webkit-localizable-strings: Add the two icu directories
180         to the skip list.
181
182 2010-05-04  Jesus Sanchez-Palencia  <jesus@webkit.org>
183
184         Reviewed by Eric Seidel.
185
186         Wrong documentation on 'webkit-patch help land'.
187         https://bugs.webkit.org/show_bug.cgi?id=37871
188
189         Small fix on the help documentation for webkit-patch
190         land.
191
192         * Scripts/webkitpy/tool/commands/download.py:
193
194 2010-05-04  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
195
196         Reviewed by Kenneth Rohde Christiansen.
197
198         [Qt] QWebPage viewMode property
199         https://bugs.webkit.org/show_bug.cgi?id=38119
200
201         Rename the property from wrt_viewMode to _q_viewMode.
202
203         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
204         (LayoutTestController::setViewModeMediaFeature):
205
206 2010-05-04  Jochen Eisinger  <jochen@chromium.org>
207
208         Reviewed by Jeremy Orlow.
209
210         Fix typo in run_webkit_tests.py: s/_print\./_printer./
211         https://bugs.webkit.org/show_bug.cgi?id=38515
212
213         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
214
215 2010-05-04  Chris Jerdonek  <cjerdonek@webkit.org>
216
217         Reviewed by Eric Seidel.
218
219         This revision completes the terminology change from "processor" to
220         "checker" for the CarriageReturnProcessor, CppProcessor,
221         PythonProcessor, and TextProcessor classes, etc.
222
223         https://bugs.webkit.org/show_bug.cgi?id=38262
224
225         The word "processor" currently has two uses in our code.  This
226         revision renames the lower-level use to "checker" and preserves the
227         word "processor" for higher-level, more general uses.  This
228         revision also makes whatever other name changes that logically
229         followed from this change.
230
231         * Scripts/check-webkit-style:
232           - Updated references to PatchChecker.
233
234         * Scripts/webkitpy/style/checker.py:
235           - Renamed the StyleCheckerConfiguration class to
236             StyleProcessorConfiguration.
237           - Renamed the ProcessorDispatcher class to CheckerDispatcher, and
238             made similar changes for the class's method names.
239           - Renamed the PatchChecker class to PatchReader.
240           - Updated the file as necessary to accommodate the other class
241             renames in this patch.
242
243         * Scripts/webkitpy/style/checker_unittest.py:
244           - Updated the unit test code as necessary.
245
246         * Scripts/webkitpy/style/checkers/common.py:
247           - Renamed the CarriageReturnProcessor class to CarriageReturnChecker,
248             and changed its process() method to check().
249
250         * Scripts/webkitpy/style/checkers/common_unittest.py:
251           - Updated the unit test code as necessary.
252
253         * Scripts/webkitpy/style/checkers/cpp.py:
254           - Renamed the CppProcessor class to CppChecker, and renamed its
255             process() method to check().
256
257         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
258           - Updated the unit test code as necessary.
259
260         * Scripts/webkitpy/style/checkers/python.py:
261           - Renamed the PythonProcessor class to PythonChecker, and renamed
262             its process() method to check().
263
264         * Scripts/webkitpy/style/checkers/python_unittest.py:
265           - Updated the unit test code as necessary.
266
267         * Scripts/webkitpy/style/checkers/text.py:
268           - Renamed the TextProcessor class to TextChecker, and renamed
269             its process() method to check().
270
271         * Scripts/webkitpy/style/checkers/text_unittest.py:
272           - Updated the unit test code as necessary.
273
274         * Scripts/webkitpy/style/error_handlers.py:
275           - Updated the code as necessary.
276
277         * Scripts/webkitpy/style/error_handlers_unittest.py:
278           - Updated the unit test code as necessary.
279
280 2010-05-04  Chris Jerdonek  <cjerdonek@webkit.org>
281
282         Reviewed by Eric Seidel.
283
284         Adjusted svn-apply and -unapply to accept git diffs generated
285         using the --no-prefix flag.
286
287         https://bugs.webkit.org/show_bug.cgi?id=32438
288
289         * Scripts/VCSUtils.pm:
290           - Loosened the regular expression for the "diff --git" line to
291             match when the --no-prefix flag is used with "git diff".
292           - Also refactored the code parsing the first line so that the
293             script exits with an error message if the first line cannot
294             be parsed.
295         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
296           - Added a unit test case for the --no-prefix case.
297
298 2010-05-04  Chris Jerdonek  <cjerdonek@webkit.org>
299
300         Reviewed by Daniel Bates.
301
302         Changed VCSUtils.pm's parseDiffHeader() to call the new
303         parseGitDiffHeader() method.
304
305         https://bugs.webkit.org/show_bug.cgi?id=38454
306
307         This revision makes more progress towards adding executable-bit
308         support to svn-apply and svn-unapply.  It also makes more progress
309         towards refactoring the code into a more maintainable form.
310
311         * Scripts/VCSUtils.pm:
312           - Removed gitdiff2svndiff().
313           - Removed the Git-specific logic from parseDiffHeader() and
314             renamed it parseSvnDiffHeader().
315           - Added a new parseDiffHeader() subroutine which calls
316             parseSvnDiffHeader() or parseGitDiffHeader() depending on
317             the format of the first header line.
318
319         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Removed.
320         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
321           - Removed most of the test cases since these cases are now
322             covered by the unit tests for parseSvnDiffHeader() and
323             parseGitDiffHeader().
324
325         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: Added.
326           - Copied the SVN unit tests from parseDiffHeader.pl and updated
327             them as necessary.
328
329 2010-05-03  Eric Seidel  <eric@webkit.org>
330
331         Reviewed by Adam Barth.
332
333         Builders should run the perl and python unit tests on every commit
334         https://bugs.webkit.org/show_bug.cgi?id=37976
335
336         The unit tests take a few seconds to run, so they should not
337         have any noticable effect on builder speed.
338
339         We're running the tests everywhere but Tiger as Tiger's
340         Python version is ancient.
341         I would have rather have detected the python version of the
342         slave but I couldn't find any API to do that, and I didn't want
343         to hack version detection into test-webkitpy (at least not yet).
344
345         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
346
347 2010-05-03  Chris Jerdonek  <cjerdonek@webkit.org>
348
349         Reviewed by Adam Barth.
350
351         Fixed a recent REGRESSION that caused svn-apply and -unapply to
352         skip over changes to the first file in a diff if leading junk was
353         present (like in an e-mail diff) and if the --force option was used.
354
355         https://bugs.webkit.org/show_bug.cgi?id=38507
356
357         * Scripts/svn-apply:
358           - Removed the bit of code at the beginning of the patch()
359             subroutine that checks for the "Index:" line at the beginning
360             of a file diff (since the parsePatch() subroutine already
361             checks this).
362
363         * Scripts/svn-unapply:
364           - Removed the bit of code at the beginning of the patch()
365             subroutine that checks for the "Index:" line at the beginning
366             of a file diff (since the parsePatch() subroutine already
367             checks this).
368
369 2010-05-03  Chris Jerdonek  <cjerdonek@webkit.org>
370
371         Unreviewed.
372
373         Adjusted the ChangeLog entry below for r58732 (bug 35804) to reflect
374         the fact that the change will not become active until the patch
375         for bug 38454 lands.
376
377 2010-05-03  Chris Jerdonek  <cjerdonek@webkit.org>
378
379         Reviewed by Eric Seidel.
380
381         Added code for svn-apply and -unapply to display an instructive error
382         message if the --binary flag is left off the "git diff" command
383         for diffs containing binary file differences.
384
385         https://bugs.webkit.org/show_bug.cgi?id=35804
386
387         This change will become active when parseDiffHeader() is modified
388         to call parseGitDiffHeader (see bug 38454).
389
390         * Scripts/VCSUtils.pm:
391           - Adjusted parseDiffHeader() to exit with an appropriate error message
392             if it encounters a line of the form "Binary files <path1> and
393             <path2> differ".
394
395 2010-05-03  Dirk Pranke  <dpranke@chromium.org>
396
397         Unreviewed, build fix.
398
399         new-run-webkit-tests: r58728 broke the buildbot logic for parsing the
400         output of the log; specifying --verbose should basically be equivalent
401         to --print everything, but instead it was equivalent to not specifying
402         --print and getting the default set. Now, --verbose acts as if
403         --print everything was implicitly specified as the default (you can
404         still override it if you specify both; this is a somewhat debatable
405         call).
406
407         https://bugs.webkit.org/show_bug.cgi?id=38504
408
409         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
410
411 2010-05-03  Dirk Pranke  <dpranke@chromium.org>
412
413         Unreviewed, build fix.
414
415         new-run-webkit-tests: Fix minor precedence bug introduced in r58728 where we printed
416         "-\n" 78 times instead of "-" 78 times followed by a single "\n".
417
418         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
419
420 2010-05-03  Dirk Pranke  <dpranke@chromium.org>
421
422         Reviewed by Eric Seidel.
423
424         new-run-webkit-tests: refactor a large chunk of the printing/logging
425         code out of run-webkit-tests py (almost 300 lines out of 1900).
426
427         This change also renames --log to --print (to be slightly more
428         descriptive). I've also added better help messages for printing.
429
430         The new code has unit tests!
431
432         There is still more code to be moved, but this patch is big enough as
433         it is. Namely, still to move are the printing of the actual results
434         and the timing statistics, which should move another 300-400 lines
435         out of the file.
436
437         Notable changes to run_webkit_tests.py beyond code simply moving:
438         * MeteredStream is now hidden under the new printing.Printer class.
439           All the references to self._meter now point to self._printer.
440         * All logging configuration is done in printing.configure_logging()
441         * Instead of using write() lambdas to control what is and isn't
442           printed, we use separate methods on the printer object. This will
443           make it easier to grep which print statements are printed
444           under protection of each flag.
445         * The print_results flag I added a few revs back to suppress printing
446           in the unit tests has been replaced with --print nothing.
447         * The ResultSummary class now stores the entire TestResult for each
448           test, not just the actual result type.
449         * summarize_unexpected_results() got moved from a method on TestRunner
450           to a standalone function. This should move into a separate file
451           along with the ResultSummary class and the TestResult class
452         * The --trace option added recently has been replaced by
453           '--print trace-everything' and '--print trace-unexpected'
454
455         https://bugs.webkit.org/show_bug.cgi?id=38018
456
457         * Scripts/new-run-webkit-tests:
458           - update to new entry points in run_webkit_tests.py
459         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
460           - fix a minor nit where we were printing an empty string where
461             we didn't need to
462         * Scripts/webkitpy/layout_tests/layout_package/printing.py: Added.
463         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Added
464         * Scripts/webkitpy/layout_tests/port/test.py:
465           - implement relative_test_filename() and expected_filename() so
466             we can test printing unexpected results in a platform-neutral
467             way
468         * Scripts/webkitpy/run_webkit_test.py:
469           - move a lot of the printing code into printing.py
470           - change the signatures of the exported entry points for easier
471             unit testing
472         * Scripts/webkitpy/run_webkit_tests_unittest.py:
473           - update w/ changes to run_webkit_tests entry points.
474
475 2010-05-03  Kevin Watters  <kevinwatters@gmail.com>
476
477         Reviewed by Kevin Ollivier.
478
479         [wx] Build and use Mac's ComplexTextController to support complex text in wx.
480         https://bugs.webkit.org/show_bug.cgi?id=38482
481
482         * wx/build/settings.py:
483
484 2010-05-03  Abhishek Arya  <inferno@chromium.org>
485
486         Reviewed by Adam Barth.
487
488         Add support for controlling clipboard access from javascript.
489         Clipboard access from javascript is enabled in test framework.
490         https://bugs.webkit.org/show_bug.cgi?id=27751
491
492         * DumpRenderTree/LayoutTestController.cpp:
493         (setJavaScriptCanAccessClipboardCallback):
494         (LayoutTestController::staticFunctions):
495         * DumpRenderTree/LayoutTestController.h:
496         * DumpRenderTree/chromium/LayoutTestController.cpp:
497         (LayoutTestController::LayoutTestController):
498         (LayoutTestController::setJavaScriptCanAccessClipboard):
499         (LayoutTestController::overridePreference):
500         * DumpRenderTree/chromium/LayoutTestController.h:
501         * DumpRenderTree/chromium/TestShell.cpp:
502         (TestShell::resetWebSettings):
503         * DumpRenderTree/gtk/DumpRenderTree.cpp:
504         (resetDefaultsToConsistentValues):
505         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
506         (LayoutTestController::setJavaScriptCanAccessClipboard):
507         * DumpRenderTree/mac/DumpRenderTree.mm:
508         (resetDefaultsToConsistentValues):
509         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
510         (LayoutTestController::setJavaScriptCanAccessClipboard):
511         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
512         (WebCore::WebPage::WebPage):
513         (WebCore::WebPage::resetSettings):
514         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
515         (LayoutTestController::setJavaScriptCanAccessClipboard):
516         * DumpRenderTree/qt/LayoutTestControllerQt.h:
517         * DumpRenderTree/win/DumpRenderTree.cpp:
518         (resetDefaultsToConsistentValues):
519         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
520         (LayoutTestController::setJavaScriptCanAccessClipboard):
521         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
522         (LayoutTestController::setJavaScriptCanAccessClipboard):
523
524 2010-05-03  Anders Carlsson  <andersca@apple.com>
525
526         Reviewed by Adam Roben.
527
528         Maui MiniBrowser: Add an option to show/hide the web view
529         https://bugs.webkit.org/show_bug.cgi?id=38486
530
531         * MiniBrowser/win/BrowserWindow.cpp:
532         (BrowserWindow::createWindow):
533         Set the background brush to something other than null.
534
535         (BrowserWindow::onCommand):
536         Show and hide the web view accordingly.
537         
538         * MiniBrowser/win/MiniBrowser.rc:
539         * MiniBrowser/win/resource.h:
540         Add new menu item.
541
542 2010-05-03  Chris Jerdonek  <cjerdonek@webkit.org>
543
544         Reviewed by Daniel Bates.
545
546         Added a parseGitDiffHeader() subroutine to VCSUtils.pm that
547         parses any changes to the executable bit in a Git diff.
548
549         https://bugs.webkit.org/show_bug.cgi?id=38425
550
551         This revision is more preparation towards adding "executable bit"
552         support to svn-apply and svn-unapply.  No code is going "live" in
553         this change except for the new unit tests in test-webkitperl.
554
555         * Scripts/VCSUtils.pm:
556           - Added isExecutable() to determine whether a file mode has the
557             executable bit set or not.
558           - Added parseGitDiffHeader() to parse the header of a Git diff.
559
560         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Added.
561           - Added unit tests for parseGitDiffHeader().
562
563 2010-05-03  Daniel Bates  <dbates@rim.com>
564
565         Reviewed by Chris Jerdonek.
566
567         https://bugs.webkit.org/show_bug.cgi?id=38447
568
569         Refactor the unit tests in VCSUtils_unittest/parseDiff.pl to use
570         Test::More::is_deeply like we do in VCSUtils_unittest/parseDiffHeader.pl.
571
572         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
573
574 2010-05-02  Chris Jerdonek  <cjerdonek@webkit.org>
575
576         Unreviewed.
577
578         Corrected a file path in the ChangeLog entry for r58663 (bug 38319) below.
579
580 2010-05-02  Chris Jerdonek  <cjerdonek@webkit.org>
581
582         Reviewed by Eric Seidel.
583
584         https://bugs.webkit.org/show_bug.cgi?id=38319
585
586         * Scripts/VCSUtils.pm:
587           - In parseDiffHeader()--
588             - Added an "scmFormat" hash key to the return value to represent
589               whether the diff is Git or SVN formatted.
590             - Adjusted the code so the value of "copiedFromPath" will
591               be undef rather than "does not exist" if the file was not
592               copied.
593
594         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
595           - Added a FIXME to refactor these unit tests to use is_deeply().
596
597         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
598           - Updated the unit tests to test the "scmFormat" value.
599           - Simplified the unit tests by refactoring them to use is_deeply().
600
601 2010-05-01  Daniel Bates  <dbates@rim.com>
602
603         Reviewed by Chris Jerdonek.
604
605         https://bugs.webkit.org/show_bug.cgi?id=38423
606
607         Adds infrastructure to change the file mode of a file using
608         the appropriate SCM-specific routines.
609
610         No functionality was changed, so no new tests.
611
612         * Scripts/VCSUtils.pm: Added subroutines scmToggleExecutableBit,
613         scmAddExecutableBit, and scmRemoveExecutableBit.
614         * Scripts/svn-apply: Check for the hash key executableBitDelta
615         and toggle the executable bit.
616         * Scripts/svn-unapply: Ditto.
617
618 2010-04-30  Chris Marrin  <cmarrin@apple.com>
619
620         Reviewed by Simon Fraser.
621
622         Enabled accelerated compositing in DRT for Windows
623         https://bugs.webkit.org/show_bug.cgi?id=38404
624
625         * DumpRenderTree/win/DumpRenderTree.cpp:
626         (main):
627
628 2010-04-30  Anders Carlsson  <andersca@apple.com>
629
630         Try to fix GTK+ build.
631
632         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
633         (webkit_test_plugin_new_stream):
634
635 2010-04-30  Anders Carlsson  <andersca@apple.com>
636
637         Fix build.
638
639         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
640
641 2010-04-30  Anders Carlsson  <andersca@apple.com>
642
643         Reviewed by Timothy Hatcher.
644
645         Next step towards fixing
646         
647         https://bugs.webkit.org/show_bug.cgi?id=20784
648         move npapi.h to C99 integer types
649
650         Use the C99 types everywhere. The "old" types are still around but will be removed
651         in a subsequent commit.
652
653         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
654         (int32VariantToIdentifier):
655         (doubleVariantToIdentifier):
656         (testIdentifierToInt):
657         (testGetIntIdentifier):
658         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
659         (NPP_New):
660         (NPP_NewStream):
661         (NPP_WriteReady):
662         (NPP_Write):
663         (NPP_HandleEvent):
664         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
665         (NPP_New):
666         (NPP_NewStream):
667         (NPP_WriteReady):
668         (NPP_Write):
669         (NPP_HandleEvent):
670
671 2010-04-30  Steve Block  <steveblock@google.com>
672
673         Reviewed by Jeremy Orlow.
674
675         Changed Steve Block from committer to reviewer.
676
677         * Scripts/webkitpy/common/config/committers.py:
678
679 2010-04-28  Ojan Vafai  <ojan@chromium.org>
680
681         Reviewed by Eric Seidel.
682
683         webkit-patch doesn't work if a git repo is tracking multiple svn repos
684         https://bugs.webkit.org/show_bug.cgi?id=38290
685         
686         Getting the tests to pass required getting our SVN repo to more closely
687         match the real svn.webkit.org repo by having a trunk directory.
688         That involved adding an extra commit at the beginning and thus changing
689         all the commit numbers in the tests.
690
691         * Scripts/webkitpy/common/checkout/scm.py:
692
693 2010-04-29  Eric Seidel  <eric@webkit.org>
694
695         Reviewed by Adam Barth.
696
697         new-run-webkit-tests can deadlock with Chromium's TestShell
698         https://bugs.webkit.org/show_bug.cgi?id=38298
699
700         Fix _write_command_and_read_line to never send unicode() to
701         test_shell, instead to always encode as utf-8.  This was causing
702         random hangs because if test_shell ever encounters a \0 in the
703         stream it can deadlock with NRWT.
704
705         There is still a deadlock bug to fix in NRWT/test_shell design, however
706         this fix should make the deadlock occur less often.
707
708         * Scripts/webkitpy/layout_tests/port/chromium.py:
709         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
710
711 2010-04-29  Chris Jerdonek  <cjerdonek@webkit.org>
712
713         Reviewed by Eric Seidel.
714
715         Refactored svn-apply and svn-unapply to use the new
716         parsePatch() subroutine.
717
718         https://bugs.webkit.org/show_bug.cgi?id=34033
719
720         * Scripts/VCSUtils.pm:
721           - Consolidated %diffHash documentation.
722           - Added prepareParsedPatch().
723
724         * Scripts/svn-apply:
725           - Replaced main while loop with calls to parsePatch() and
726             prepareParsedPatch().
727
728         * Scripts/svn-unapply:
729           - Replaced main while loop with calls to parsePatch() and
730             prepareParsedPatch().
731
732         * Scripts/test-webkitperl:
733           - Changed to render relative test paths rather than absolute
734             test paths.
735
736         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added.
737           - Added unit tests for prepareParsedPatch().
738
739 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
740
741         Reviewed by Eric Seidel.
742
743         Added to VCSUtils's parseDiffHeader() support for binary patches.
744
745         https://bugs.webkit.org/show_bug.cgi?id=38094
746
747         The parseDiffHeader() function is part of new patch-parsing code
748         for svn-apply and svn-unapply that will go live in a subsequent
749         revision.
750
751         * Scripts/VCSUtils.pm:
752           - Added logic to parseDiffHeader() to recognize the ending of
753             the header portion of a binary diff.
754
755         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
756           - Added unit test cases for SVN and Git binary diffs.
757
758 2010-04-28  Eric Seidel  <eric@webkit.org>
759
760         Reviewed by David Levin.
761
762         Document that subprocess.poll/wait are not threadsafe
763         https://bugs.webkit.org/show_bug.cgi?id=38289
764
765         * Scripts/webkitpy/common/system/executive.py:
766         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
767         * Scripts/webkitpy/layout_tests/port/chromium.py:
768         * Scripts/webkitpy/layout_tests/port/http_server.py:
769         * Scripts/webkitpy/layout_tests/port/server_process.py:
770         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
771
772 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
773
774         Reviewed by Daniel Bates.
775
776         Removed the dividing line (i.e. "====...") logic from the code
777         called by svn-apply and svn-unapply.
778
779         https://bugs.webkit.org/show_bug.cgi?id=38093
780
781         The dividing line logic is unnecessary.  Removing it simplifies the
782         code and makes some subsequent changes easier.
783
784         * Scripts/VCSUtils.pm:
785           - Removed the logic in gitdiff2svndiff() to convert the git
786             "index" line to an SVN dividing line.
787           - Adjusted the logic similarly in parseDiffHeader().
788
789         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
790           - Updated the unit tests as necessary.
791
792         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
793           - Updated the unit tests as necessary.
794           - Corrected an error in the unit tests whereby all elements
795             of an array were referencing the same element rather than
796             distinct elements -- causing unit test failures to be masked.
797
798         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
799           - Updated the unit tests as necessary.
800           - Made the same unit test correction as above for parseDiff.pl.
801
802 2010-04-28  Evan Stade  <estade@chromium.org>
803
804         Unreviewed.
805
806         * Scripts/webkitpy/common/config/committers.py: adding myself as a committer
807
808 2010-04-28  Sam Weinig  <sam@webkit.org>
809
810         Reviewed by Mark Rowe.
811
812         Add MiniBrowser to the lists of modules to build and only build it on
813         SnowLeopard and later.
814
815         * Makefile:
816         * MiniBrowser/Makefile:
817
818 2010-04-28  Sam Weinig  <sam@webkit.org>
819
820         Reviewed by Mark Rowe.
821
822         Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
823
824         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
825         * MiniBrowser/mac/make-launchable.sh: Added.
826
827 2010-04-28  Eric Seidel  <eric@webkit.org>
828
829         Reviewed by David Levin.
830
831         Audit all uses of subprocess in webkitpy
832         https://bugs.webkit.org/show_bug.cgi?id=38284
833
834         After further discussions with Jeffrey Yasskin
835         about http://bugs.python.org/issue2320
836         and related issues of using subprocess from
837         multiple threads, I have learned that subprocess
838         is known to be non-threadsafe through recent
839         Python 2.7 builds.
840
841         I'm attempting to lessen our exposure to these
842         subprocess bugs by auditing each use of subprocess
843         in webkitpy.  I did not find any unsafe calls
844         in my audit, but I did remove numerous unneeded
845         import subprocess lines.
846
847         * Scripts/webkitpy/common/checkout/api.py:
848         * Scripts/webkitpy/common/net/bugzilla.py:
849         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
850         * Scripts/webkitpy/common/system/user.py:
851         * Scripts/webkitpy/layout_tests/port/base.py:
852         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
853         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
854         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
855         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
856         * Scripts/webkitpy/layout_tests/port/gtk.py:
857         * Scripts/webkitpy/layout_tests/port/mac.py:
858         * Scripts/webkitpy/layout_tests/port/qt.py:
859         * Scripts/webkitpy/layout_tests/port/webkit.py:
860         * Scripts/webkitpy/layout_tests/port/win.py:
861
862 2010-04-28  Darin Adler  <darin@apple.com>
863
864         Ignore a directory the Python tools creates.
865
866         * Scripts/webkitpy/style: Modified property svn:ignore.
867
868 2010-04-28  Darin Adler  <darin@apple.com>
869
870         * Scripts/extract-localizable-strings: Fix minor mistake in
871         argument checking.
872
873 2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>
874
875         Reviewed by Kenneth Rohde Christiansen.
876
877         [Qt] QWebPage viewMode property
878         https://bugs.webkit.org/show_bug.cgi?id=38119
879
880         Replacing method qt_wrt_setViewMode by wrt_viewMode property.
881
882         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
883         (LayoutTestController::setViewModeMediaFeature):
884
885 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
886
887         Reviewed by Shinichiro Hamaji.
888
889         Adjusted check-webkit-style so that files with file type NONE
890         are automatically skipped without warning.
891
892         https://bugs.webkit.org/show_bug.cgi?id=38197
893
894         This change simplifies configuring which files to skip.  It also
895         addresses an issue whereby check-webkit-style was unintentionally
896         checking .vcproj files for carriage returns.
897
898         * Scripts/webkitpy/style/checker.py:
899           - Moved the C++, Python, and text file extensions to new
900             module-level configuration variables.
901           - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
902             variable.
903           - Changed the numeric values of the FileType enum so that
904             FileType.NONE evaluates to False.
905           - For ProcessorDispatcher.should_skip_without_warning():
906             - Changed the method to return True for FileType.NONE files.
907             - Made ChangeLog files an exception to getting skipped.
908           - Changed the StyleProcessor.process() method to raise an
909             exception if given a file path that should not be processed.
910
911         * Scripts/webkitpy/style/checker_unittest.py:
912           - Updated the unit tests and added more test cases as necessary.
913
914 2010-04-28  Eric Seidel  <eric@webkit.org>
915
916         Reviewed by Jeremy Orlow.
917
918         webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
919         https://bugs.webkit.org/show_bug.cgi?id=38248
920
921         The previous code did not check the return code of taskkill.
922         When I moved that callsite from using subprocess.call to
923         Executive.run_command having a non-zero return code became an error.
924
925         In this change I've centralized our killall handling in executive,
926         and added tests for it to make sure it works.
927
928         Currently kill_process and kill_all swallow exceptions in the cases
929         where the process(es) to be killed do(es) not exist.
930
931         * Scripts/webkitpy/common/system/executive.py:
932         * Scripts/webkitpy/common/system/executive_unittest.py:
933         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
934         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
935         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
936         * Scripts/webkitpy/layout_tests/port/gtk.py:
937         * Scripts/webkitpy/layout_tests/port/mac.py:
938         * Scripts/webkitpy/layout_tests/port/qt.py:
939         * Scripts/webkitpy/layout_tests/port/win.py:
940
941 2010-04-28  Eric Seidel  <eric@webkit.org>
942
943         Reviewed by Shinichiro Hamaji.
944
945         wdiff_text throws ScriptError because wdiff returns non-zero when files differ
946         https://bugs.webkit.org/show_bug.cgi?id=38246
947
948         wdiff returns 0 when files are the same, 1 when they differ.
949         run_command by default raises ScriptError if the return code is non-zero.
950         Fixed this by adding a custom error handler which only raises if the
951         return code is not 1.
952
953         I broke up the huge wdiff_text() method into little pieces
954         for easier unit testing.  There is only one functional change here
955         and that is the addition of the custom error handler.
956
957         * Scripts/webkitpy/layout_tests/port/base.py:
958         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
959
960 2010-04-28  Fumitoshi Ukai  <ukai@chromium.org>
961
962         Unreviewed build fix.
963
964         * DumpRenderTree/chromium/TestShell.cpp:
965         (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
966         * DumpRenderTree/chromium/WebViewHost.cpp:
967         (WebViewHost::willSendRequest): too few arguments for format.
968
969 2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
970
971         Reviewed by Darin Adler and Eric Seidel.
972
973         Add layoutTestController.setPrinting()
974         https://bugs.webkit.org/show_bug.cgi?id=37203
975
976         * DumpRenderTree/LayoutTestController.cpp:
977         (LayoutTestController::LayoutTestController):
978         (setPrintingCallback):
979         (LayoutTestController::staticFunctions):
980         * DumpRenderTree/LayoutTestController.h:
981         (LayoutTestController::isPrinting):
982         (LayoutTestController::setIsPrinting):
983         * DumpRenderTree/mac/DumpRenderTree.mm:
984         (dump):
985
986 2010-04-27  Michael Nordman  <michaeln@google.com>
987
988         Reviewed by Dmitry Titov.
989
990         [Chromium] Add two things to the webkit API to support appcaches in workers.
991         1) WebURLRequest TargetTypes for worker and shared worker main resources.
992         2) Factory method on class WebCommonWorkerClient to
993            createApplicationCacheHost() for the associated worker.
994
995         https://bugs.webkit.org/show_bug.cgi?id=38147
996
997         * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method 
998         (TestWebWorker::createApplicationCacheHost):
999
1000 2010-04-27  Adam Barth  <abarth@webkit.org>
1001
1002         Reviewed by Eric Seidel.
1003
1004         run-bindings-tests doesn't work in an SVN checkout
1005         https://bugs.webkit.org/show_bug.cgi?id=38225
1006
1007         Previously detect_scm_system needed an absolute path for SVN.  Now we
1008         accept a relative path.
1009
1010         * Scripts/webkitpy/common/checkout/scm.py:
1011         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1012
1013 2010-04-27  Sam Weinig  <sam@webkit.org>
1014
1015         Reviewed by Stephanie Lewis.
1016
1017         Always build WebKit2 when building on SnowLeopard and later. 
1018
1019         * Scripts/build-webkit:
1020
1021 2010-04-27  Sam Weinig  <sam@webkit.org>
1022
1023         Reviewed by Maciej Stachowiak.
1024
1025         Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
1026         Allow both WebKit and WebKit2 to link to the same WebCore.framework
1027
1028         * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
1029         WebCore for WebKit2, it is no longer necessary.
1030
1031 2010-04-27  James Robinson  <jamesr@chromium.org>
1032
1033         Reviewed by David Levin.
1034
1035         Fix a typo in chromium.py that causes NRWT to fail in --verbose
1036         mode in a Chromium checkout.
1037         https://bugs.webkit.org/show_bug.cgi?id=38234
1038
1039         * Scripts/webkitpy/layout_tests/port/chromium.py:
1040
1041 2010-04-27  Darin Fisher  <darin@chromium.org>
1042
1043         Reviewed by Dimitri Glazkov.
1044
1045         [Chromium] Remove deprecated form of didChangeLocationWithinPage
1046         https://bugs.webkit.org/show_bug.cgi?id=38178
1047
1048         Switch over to implementing didNavigateWithinPage.
1049
1050         * DumpRenderTree/chromium/WebViewHost.cpp:
1051         (TestWebViewDelegate::didNavigateWithinPage):
1052         (WebViewHost::didChangeLocationWithinPage):
1053         * DumpRenderTree/chromium/WebViewHost.h:
1054
1055 2010-04-27  Evan Martin  <evan@chromium.org>
1056
1057         Unreviewed.
1058
1059         Adding myself to commmitters list.
1060
1061         * Scripts/webkitpy/common/config/committers.py:
1062
1063 2010-04-27  Adam Barth  <abarth@webkit.org>
1064
1065         Reviewed by Darin Adler.
1066
1067         run-bindings-tests should use --reset-results instead of --overwrite
1068         https://bugs.webkit.org/show_bug.cgi?id=38200
1069
1070         As requested by Ojan.
1071
1072         * Scripts/run-bindings-tests:
1073
1074 2010-04-27  Adam Barth  <abarth@webkit.org>
1075
1076         Reviewed by Eric Seidel.
1077
1078         REGRESSION(r58261): webkit-patch edit-changelogs is broken
1079         https://bugs.webkit.org/show_bug.cgi?id=38204
1080
1081         In 58261, we added code to abstract step that interrogates the squash
1082         and git_commit options, but it doesn't declare that it uses those
1083         options.  That means any command that doesn't happen to declare those
1084         options might be broken if it uses the cached_lookup mechanism.
1085
1086         * Scripts/webkitpy/tool/steps/abstractstep.py:
1087         * Scripts/webkitpy/tool/steps/applypatch.py:
1088         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
1089         * Scripts/webkitpy/tool/steps/build.py:
1090         * Scripts/webkitpy/tool/steps/checkstyle.py:
1091         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1092         * Scripts/webkitpy/tool/steps/closebug.py:
1093         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
1094         * Scripts/webkitpy/tool/steps/commit.py:
1095         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1096         * Scripts/webkitpy/tool/steps/createbug.py:
1097         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1098         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
1099         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1100         * Scripts/webkitpy/tool/steps/postcodereview.py:
1101         * Scripts/webkitpy/tool/steps/postdiff.py:
1102         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1103         * Scripts/webkitpy/tool/steps/runtests.py:
1104         * Scripts/webkitpy/tool/steps/update.py:
1105         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1106         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1107
1108 2010-04-27  Eric Seidel  <eric@webkit.org>
1109
1110         Reviewed by David Levin.
1111
1112         prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
1113         https://bugs.webkit.org/show_bug.cgi?id=38212
1114
1115         * Scripts/prepare-ChangeLog:
1116          - Pass --insecure to curl to work around CYGWIN missing certs.
1117
1118 2010-04-27  Sam Weinig  <sam@webkit.org>
1119
1120         Rubber-stamped by Beth Dakin.
1121
1122         It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
1123         or WTF_USE_WEB_THREAD. Remove them.
1124
1125         * Scripts/build-webkit:
1126
1127 2010-04-27  Chris Jerdonek  <cjerdonek@webkit.org>
1128
1129         Reviewed by David Levin.
1130
1131         Changed Chris Jerdonek from committer to reviewer.
1132
1133         * Scripts/webkitpy/common/config/committers.py:
1134
1135 2010-04-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1136
1137         Reviewed by Kenneth Rohde Christiansen.
1138
1139         [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
1140         https://bugs.webkit.org/show_bug.cgi?id=35834
1141
1142         The scene should always have the size of the web view otherwhise it is
1143         possible to scroll the graphics view.
1144
1145         * QtLauncher/webview.cpp:
1146         (WebViewGraphicsBased::resizeEvent):
1147
1148 2010-04-27  Diego Gonzalez  <diegohcg@webkit.org>
1149
1150         Unreviewed.
1151
1152         Adding myself to committers.py
1153
1154         * Scripts/webkitpy/common/config/committers.py:
1155
1156 2010-04-27  Eric Seidel  <eric@webkit.org>
1157
1158         Reviewed by Adam Barth.
1159
1160         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
1161         https://bugs.webkit.org/show_bug.cgi?id=37987
1162
1163         After further research, I believe the hang is caused by:
1164         http://bugs.python.org/issue2320
1165         Basically Popen() is not reentrant.
1166         The workaround is to pass close_fds=True to Popen() on Mac/Linux.
1167
1168         I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
1169         when appropriate.
1170
1171         I audited all places we call Popen() and either moved them to run_command
1172         or left a FIXME that they are not thread safe.  A few places I added the
1173         close_fds workaround there and left an explanitory note.
1174
1175         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1176          - Added note that this Popen use is not threadsafe.
1177         * Scripts/webkitpy/common/system/executive.py:
1178          - Fixed our Executive.run_* to workaround python bug 2320.
1179         * Scripts/webkitpy/common/system/user.py:
1180          _ Added note that this Popen use is not threadsafe.
1181         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
1182         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
1183         * Scripts/webkitpy/layout_tests/port/base.py:
1184          - Change wdiff back to using run_command now that we believe it
1185            to be threadsafe.
1186         * Scripts/webkitpy/layout_tests/port/chromium.py:
1187          - Fix to use Executive in places.
1188          - Pass self._executive down to the Driver for easier unit testing.
1189         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1190          - Re-factor to use a _kill_all method.
1191          - Made the _kill_all method use run_command to be threadsafe.
1192         * Scripts/webkitpy/layout_tests/port/http_server.py:
1193          - Add FIXME about using Executive.
1194         * Scripts/webkitpy/layout_tests/port/server_process.py:
1195          - Use Executive to be threadsafe.
1196         * Scripts/webkitpy/layout_tests/port/webkit.py:
1197          - Pass self._executive down to the Driver.
1198         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1199          - Add note about Popen not being threadsafe.
1200         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1201          - Move one caller to run_command add notes about moving others.
1202
1203 2010-04-27  Adam Barth  <abarth@webkit.org>
1204
1205         Reviewed by Maciej Stachowiak.
1206
1207         REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
1208         https://bugs.webkit.org/show_bug.cgi?id=38186
1209
1210         Unfortunately, we don't have a good way of testing this change because
1211         our test coverage of the scm.py API is poor...
1212
1213         * Scripts/webkitpy/common/checkout/scm.py:
1214         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1215
1216 2010-04-26  Eric Seidel  <eric@webkit.org>
1217
1218         Reviewed by Adam Barth.
1219
1220         Remove unused code from text_diff.py
1221         https://bugs.webkit.org/show_bug.cgi?id=38170
1222
1223         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1224          - Remove is_render_tree_dump which appears unused.
1225
1226 2010-04-26  Adam Barth  <abarth@webkit.org>
1227
1228         Reviewed by Eric Seidel.
1229
1230         webkit-patch pretty-diff is broken
1231         https://bugs.webkit.org/show_bug.cgi?id=38172
1232
1233         We need to register for these options because they're used when we look
1234         up the diff.
1235
1236         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1237
1238 2010-04-26  Adam Barth  <abarth@webkit.org>
1239
1240         Reviewed by Eric Seidel.
1241
1242         Add ObjC and GObject to run-bindings-test
1243         https://bugs.webkit.org/show_bug.cgi?id=38168
1244
1245         * Scripts/run-bindings-tests:
1246
1247 2010-04-26  Adam Barth  <abarth@webkit.org>
1248
1249         Reviewed by Eric Seidel.
1250
1251         Add testing infrastructure for JSC bindings generator
1252         https://bugs.webkit.org/show_bug.cgi?id=38167
1253
1254         Add support for testing more than one bindings.  Also, converted the
1255         script to PEP8 style.
1256
1257         * Scripts/run-bindings-tests:
1258
1259 2010-04-26  Eric Seidel  <eric@webkit.org>
1260
1261         Reviewed by Adam Barth.
1262
1263         Refactor results.html generation out into a new method and test it
1264         https://bugs.webkit.org/show_bug.cgi?id=38164
1265
1266         Hopefully this results in no change in functionality.
1267
1268         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1269         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1270
1271 2010-04-26  Adam Barth  <abarth@webkit.org>
1272
1273         Unreviewed, rolling out r58265.
1274         http://trac.webkit.org/changeset/58265
1275         https://bugs.webkit.org/show_bug.cgi?id=38021
1276
1277         This change prevents me from uploading patches.  It also breaks sheriff-bot.
1278
1279         * Scripts/webkitpy/tool/steps/options.py:
1280
1281 2010-04-26  Eric Seidel  <eric@webkit.org>
1282
1283         Reviewed by Adam Barth.
1284
1285         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
1286         https://bugs.webkit.org/show_bug.cgi?id=37987
1287
1288         Rolled out:
1289         http://trac.webkit.org/changeset/58062
1290         http://trac.webkit.org/changeset/58060
1291         http://trac.webkit.org/changeset/58059
1292         http://trac.webkit.org/changeset/58055
1293         http://trac.webkit.org/changeset/58054
1294         and parts of:
1295         http://trac.webkit.org/changeset/58050
1296
1297         I also wrote some new comments and a tiny amount of new
1298         code to help make ChromiumDriver.run_test easier to read.
1299
1300         In order to unit-test my new code, I had to change ChromiumDriver
1301         to not automatically start itself when created.  That ended up
1302         being a lot of plumbing, but is hopefully easier to understand now.
1303
1304         There are no tests for the (restored) wdiff code.  wdiff does not
1305         exist on all systems, so for now we will assume it worked since
1306         it is just old code being reverted.
1307
1308          * Scripts/webkitpy/layout_tests/driver_test.py:
1309           - Use create_driver instead of start_driver, and be sure to call .stop()
1310          * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1311           - Use create_driver instead of start_driver
1312          * Scripts/webkitpy/layout_tests/port/base.py:
1313           - Added a comment to explain that diffs are binary files.
1314           - Various patch reverts relating to wdiff
1315           - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
1316           - Made _command_wrapper use shlex.split to get rid of the FIXME.
1317          * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
1318           - test the new _command_wrapper
1319          * Scripts/webkitpy/layout_tests/port/chromium.py:
1320          - Use _command_wrapper to get rid of a bunch of ugly code.
1321          - Make __init__ stop auto-starting.
1322          - Rename create_driver to start_driver.
1323          - Added _write_command_and_read_line to make it possible to
1324            put a FIXME next to read_line() w/o having to put it in two places.
1325          - Moved test_shell command building into _test_shell_command and tested it.
1326          - Fix comments to say test_shell since ChromiumDriver is test_shell only.
1327          * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
1328           - Test the new test_shell_command method.
1329          * Scripts/webkitpy/layout_tests/port/dryrun.py:
1330           - Rename create_driver to start_driver.
1331          * Scripts/webkitpy/layout_tests/port/test.py:
1332           - Rename create_driver to start_driver.
1333          * Scripts/webkitpy/layout_tests/port/webkit.py:
1334           - Rename create_driver to start_driver.
1335           - Treat output as binary arrays.
1336          * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1337           - Treat diff files as binary.
1338          * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1339           - Treat diff files as binary.
1340
1341 2010-04-26  Adam Barth  <abarth@webkit.org>
1342
1343         Reviewed by Eric Seidel.
1344
1345         Move bindings test directory into the scripts directory
1346         https://bugs.webkit.org/show_bug.cgi?id=38161
1347
1348         Change script to point to the new location of these data files.
1349
1350         * Scripts/run-bindings-tests:
1351
1352 2010-04-26  Adam Barth  <abarth@webkit.org>
1353
1354         Unreviewed.  Mark run-bindings-tests executable so we can execute it.
1355
1356         * Scripts/run-bindings-tests:
1357
1358 2010-04-26  Tony Chang  <tony@chromium.org>
1359
1360         Reviewed by David Levin.
1361
1362         [chromium] build-webkit --chromium should build release by default
1363         https://bugs.webkit.org/show_bug.cgi?id=38028
1364
1365         * Scripts/build-dumprendertree: Also should build release by default
1366         * Scripts/build-webkit: Make sure to pass command line args through
1367         * Scripts/webkitdirs.pm: Build the right configuration
1368
1369 2010-04-26  Ojan Vafai  <ojan@chromium.org>
1370
1371         Reviewed by Eric Seidel.
1372
1373         complete rietveld bugzilla integration
1374         https://bugs.webkit.org/show_bug.cgi?id=38021
1375
1376         Makes --fancy-review the default. All this means is that the patch will
1377         be uploaded to rietveld in addition to bugs.webkit.org. 
1378
1379         * Scripts/webkitpy/tool/steps/options.py:
1380
1381 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
1382
1383         Reviewed by Shinichiro Hamaji.
1384
1385         For check-webkit-style, renamed the style/processors/ directory
1386         to style/checkers/.
1387
1388         https://bugs.webkit.org/show_bug.cgi?id=38122
1389
1390         * Scripts/webkitpy/style/checker.py:
1391           - Updated import statements.
1392
1393         * Scripts/webkitpy/style/checker_unittest.py:
1394           - Updated import statements.
1395
1396         * Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
1397         * Scripts/webkitpy/style/processors: Removed.
1398         * Scripts/webkitpy/style/processors/__init__.py: Removed.
1399         * Scripts/webkitpy/style/processors/common.py: Removed.
1400         * Scripts/webkitpy/style/processors/common_unittest.py: Removed.
1401         * Scripts/webkitpy/style/processors/cpp.py: Removed.
1402         * Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
1403         * Scripts/webkitpy/style/processors/python.py: Removed.
1404         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
1405         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
1406         * Scripts/webkitpy/style/processors/text.py: Removed.
1407         * Scripts/webkitpy/style/processors/text_unittest.py: Removed.
1408
1409 2010-04-06  Ojan Vafai  <ojan@chromium.org>
1410
1411         Reviewed by Adam Barth.
1412
1413         Include git commits in the diff for webkit-patch upload/land.
1414         https://bugs.webkit.org/show_bug.cgi?id=36394
1415
1416         Adds --squash, --no-squash and --git-commit.
1417
1418         --git-commit will use a specific local commit for land/upload.
1419         If a commit-range is specified, then that range is treated as
1420         a single squashed commit.
1421
1422         --squash will squash all local changes including working copy changes
1423         into a single patch.
1424
1425         --no-squash is the legacy behavior (upload only considers the working copy,
1426         land commits the working copy and then each local commit separately to SVN)
1427
1428         If neither is specified, then an informative error is raised if there is
1429         more than one local commit or when there are local commit(s) and working
1430         copy changes.
1431
1432         If the webkit-patch.squash git config parameter is set, then
1433         that will be respected instead of raising an error.
1434
1435         * Scripts/check-webkit-style:
1436         * Scripts/webkitpy/common/checkout/api.py:
1437         * Scripts/webkitpy/common/checkout/api_unittest.py:
1438         * Scripts/webkitpy/common/checkout/scm.py:
1439         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1440         * Scripts/webkitpy/style/optparser.py:
1441         --git-since is removed and --git-commit no longer implies commit_id..
1442         Instead, it treats that individual commit, but also supports commit ranges
1443         (e.g. commit_id..) as arguments.
1444         * Scripts/webkitpy/style/optparser_unittest.py:
1445         * Scripts/webkitpy/style_references.py:
1446         * Scripts/webkitpy/tool/commands/download.py:
1447         * Scripts/webkitpy/tool/commands/upload.py:
1448         * Scripts/webkitpy/tool/main.py:
1449         * Scripts/webkitpy/tool/mocktool.py:
1450         * Scripts/webkitpy/tool/steps/abstractstep.py:
1451         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
1452         * Scripts/webkitpy/tool/steps/checkstyle.py:
1453         * Scripts/webkitpy/tool/steps/commit.py:
1454         * Scripts/webkitpy/tool/steps/options.py:
1455         * Scripts/webkitpy/tool/steps/postdiff.py:
1456         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1457         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1458         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1459         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1460
1461 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
1462
1463         Reviewed by Shinichiro Hamaji.
1464
1465         Deleted the StyleChecker-related classes that are no longer
1466         being used.
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=38118
1469
1470         * Scripts/webkitpy/style/checker.py:
1471           - Deleted the DeprecatedStyleChecker class.
1472
1473         * Scripts/webkitpy/style/checker_unittest.py:
1474           - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase,
1475             StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
1476
1477 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
1478
1479         Reviewed by Shinichiro Hamaji.
1480
1481         Changed the StyleChecker class to use the new TextFileReader class.
1482
1483         https://bugs.webkit.org/show_bug.cgi?id=37066
1484
1485         This revision separates the code responsible for reading and iterating
1486         over text files from the rest of check-webkit-style.
1487
1488         * Scripts/check-webkit-style:
1489           - Changed the script to use the new StyleProcessor and
1490             TextFileReader classes instead of the StyleChecker class.
1491
1492         * Scripts/webkitpy/style/checker.py:
1493           - Added a FIXME to rename many of uses of the word "processor" to
1494             "checker".  We did this to clarify the difference between
1495             ProcessorBase instances passed to the TextFileReader and
1496             classes that process and check lines for style.
1497           - Added a FIXME to remove FileType.NONE as a possible return value
1498             of ProcessorDispatcher._file_type().  This will better consolidate
1499             the logic of which files should be skipped.
1500           - Added a FIXME to delete the StyleChecker class.
1501           - Added the StyleProcessor class which implements ProcessorBase.
1502             This class is responsible for processing lines to check style
1503             (but not for reading files).  For each file, this class creates
1504             creates both a carriage-return checker and a format-specific
1505             style checker (e.g. one of C++, Python, etc).
1506           - Updated the PatchChecker class to use a TextFileReader instance
1507             instead of a StyleChecker.
1508
1509         * Scripts/webkitpy/style/checker_unittest.py:
1510           - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
1511             tests of the StyleProcessor class.
1512           - Added the StyleProcessor_CodeCoverageTest to test the
1513             StyleProcessor class with more complete code coverage.
1514             Unlike the StyleProcessor_EndToEndTest class, this class makes
1515             heavy use of mock parameters.
1516           - Added FIXME's to delete the unit test classes that are no
1517             longer needed.
1518           - Updated the PatchCheckerTest class to use a MockTextFileReader
1519             instead of a MockStyleChecker.
1520
1521         * Scripts/webkitpy/style/filereader.py:
1522           - Updated the TextFileReader class to use the preferred logic
1523             of checking file existence at the beginning of the process_file()
1524             method instead of in the except block, per
1525             https://bugs.webkit.org/show_bug.cgi?id=37122
1526
1527         * Scripts/webkitpy/style/filereader_unittest.py:
1528           - In the TextFileReaderTest class:
1529             - Moved the test_process_file__should_not_process() method.
1530             - Added a test_process_file__file_stdin() method to test
1531               the file path "-".
1532
1533 2010-04-20  Robert Hogan  <robert@webkit.org>
1534
1535         Reviewed by Simon Hausmann.
1536
1537         [Qt] Add more support for textInputController
1538
1539         Add support for selectedRange(), setMarkedText(), insertText(),
1540         and firstRectForCharacterRange().
1541
1542         Unskip tests:
1543
1544         fast/forms/input-maxlength-ime-preedit.html
1545         fast/forms/input-maxlength-ime-completed.html
1546         fast/text/international/thai-cursor-position.html
1547         fast/events/ime-composition-events-001.html
1548         editing/selection/5825350-1.html
1549         editing/selection/5825350-2.html
1550         editing/selection/mixed-editability-10.html
1551
1552         https://bugs.webkit.org/show_bug.cgi?id=35702
1553
1554         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1555         (TextInputController::setMarkedText):
1556         (TextInputController::insertText):
1557         (TextInputController::selectedRange):
1558         (TextInputController::firstRectForCharacterRange):
1559         * DumpRenderTree/qt/TextInputControllerQt.h:
1560
1561 2010-04-23  Eric Seidel  <eric@webkit.org>
1562
1563         Reviewed by Adam Barth.
1564
1565         check-webkit-style complains about non-utf8 data in layout test result
1566         https://bugs.webkit.org/show_bug.cgi?id=38027
1567
1568         The problem was we were assuming patch files/diff output as utf-8.
1569         Turns out they're not.  We have to treat them as binary data because
1570         a single patch may have multiple text files in it with conflicting encodings!
1571
1572         * Scripts/webkitpy/common/checkout/api.py:
1573          - contents_at_revision returns a byte array, so decode it to unicode
1574            before passing it to parse_latest_entry_from_file
1575         * Scripts/webkitpy/common/checkout/api_unittest.py:
1576          - Update our mock mock_contents_at_revision to match the encoding
1577            semantics of the real one.
1578         * Scripts/webkitpy/common/checkout/scm.py:
1579          - Be careful not to decode output which may contain file contents
1580            (like diff, cat or show) as the encoding for that content is unknown.
1581         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1582          - Update our tests to use both latin1 and utf-8 encoded data.
1583         * Scripts/webkitpy/common/net/bugzilla.py:
1584          - _fill_attachment_form should not assume unicode data.  Callers
1585            may wish to attach other types of files to bugs.
1586         * Scripts/webkitpy/common/prettypatch.py:
1587          - Diffs are byte arrays, deal with them as such.
1588         * Scripts/webkitpy/common/prettypatch_unittest.py:
1589          - Test to make sure we handle diffs with multiple conflicting encodings.
1590         * Scripts/webkitpy/common/system/executive_unittest.py:
1591          - Make sure that our unicode support does not break our
1592            byte array input support for run_command.
1593
1594 2010-04-23  Sam Weinig  <sam@webkit.org>
1595
1596         Reviewed by David Levin.
1597
1598         Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
1599         Split up Threading.h
1600
1601         Add necessary forwarding headers.
1602
1603         * DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
1604         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
1605         * DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
1606
1607 2010-04-23  Xiaomei Ji  <xji@chromium.org>
1608
1609         No need to review.
1610
1611         Add xji as committer.
1612
1613         * Scripts/webkitpy/common/config/committers.py:
1614
1615 2010-04-23  Kevin Ollivier  <kevino@theolliviers.com>
1616
1617         [wx] Build fix, add platform stub for new LayoutTestController method.
1618
1619         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1620         (LayoutTestController::markerTextForListItem):
1621
1622 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
1623
1624         Reviewed by Adam Barth.
1625
1626         new-run-webkit-tests: add a "--retry-failures" flag and a
1627         "--no-retry-failures" flag (the former is the default). Also, rename
1628         "--print-unexpected-results" and "--retry-unexpected-results" to
1629         "--print-last-failures" and "--retry-last-failures" because the
1630         retry flag was confusing. The new flag names aren't great, but
1631         hopefully they're less confusing.
1632
1633         https://bugs.webkit.org/show_bug.cgi?id=37838
1634
1635         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1636
1637 2010-04-22  Sam Weinig  <sam@webkit.org>
1638
1639         Reviewed by Anders Carlsson.
1640
1641         Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
1642         Move isMainThread predicate function to MainThread.h
1643
1644         Added forwarding header for MainThread.h
1645
1646         * DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
1647
1648 2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1649
1650         Reviewed by Kenneth Rohde Christiansen.
1651
1652         [Qt] Disable Netscape plugin support for minimal configuration
1653         https://bugs.webkit.org/show_bug.cgi?id=38026
1654
1655         Pass the minimal configuration option to Qt build system 
1656         as part of the CONFIG variable.
1657
1658         * Scripts/build-webkit:
1659
1660 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1661
1662         Unreviewed fix.
1663
1664         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
1665
1666 2010-04-22  James Robinson  <jamesr@chromium.org>
1667
1668         Reviewed by Adam Barth.
1669
1670         Revert 58077 and follow-ups.  It's broken.
1671         https://bugs.webkit.org/show_bug.cgi?id=37664
1672
1673         * Scripts/new-run-webkit-httpd:
1674         * Scripts/new-run-webkit-websocketserver:
1675         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1676         * Scripts/webkitpy/layout_tests/port/http_server.py:
1677         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1678
1679 2010-04-22  Yaar Schnitman  <yaar@chromium.org>
1680
1681         Reviewed by Adam Barth.
1682
1683         Integrate v8 testing utility with webkit tests
1684         https://bugs.webkit.org/show_bug.cgi?id=37731
1685
1686         * Scripts/run-bindings-tests: Added.
1687
1688 2010-04-22  Eric Seidel  <eric@webkit.org>
1689
1690         Reviewed by Dimitri Glazkov.
1691
1692         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1693         https://bugs.webkit.org/show_bug.cgi?id=37794
1694
1695         * Scripts/webkitpy/layout_tests/port/webkit.py:
1696          - Remove the assert() since our ServerProcess code does not always
1697            seem to be reading the full stderr output (or we're not waiting for it to).
1698
1699 2010-04-22  Eric Seidel  <eric@webkit.org>
1700
1701         Reviewed by Adam Barth.
1702
1703         Add code to help debug new-run-webkit-test hangs on the Chromium bots
1704         https://bugs.webkit.org/show_bug.cgi?id=38011
1705
1706         I can see no reasonable way to test this change.
1707         Stubbing out sys._current_frames() and traceback.extract_stack
1708         seems folly.  Dumping real data would have line number
1709         (and possibly other call stack) variance between runs.
1710
1711         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1712          - Add _dump_thread_states and _dump_thread_states_if_necessary
1713            to have our main thread dump the states of all threads every
1714            60 seconds when running in verbose mode.
1715          - Better document what is going on in our main loop.
1716
1717 2010-04-22  Sam Weinig  <sam@webkit.org>
1718
1719         Reviewed by Anders Carlsson.
1720
1721         Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
1722         Add rudimentary statistics gathering for WebKit2
1723
1724         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1725         * MiniBrowser/mac/AppDelegate.h:
1726         * MiniBrowser/mac/AppDelegate.m:
1727         (-[BrowserAppDelegate init]):
1728         (-[BrowserAppDelegate newWindow:]):
1729         (-[BrowserAppDelegate getCurrentPageNamespace]):
1730         (-[BrowserAppDelegate _setProcessModel:]):
1731         (-[BrowserAppDelegate showStatisticsWindow:]):
1732         (-[BrowserAppDelegate applicationWillTerminate:]):
1733         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
1734         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
1735         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
1736         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1737         (-[BrowserStatisticsWindowController dealloc]):
1738         (-[BrowserStatisticsWindowController windowDidLoad]):
1739         (-[BrowserStatisticsWindowController refreshStatistics:]):
1740         * MiniBrowser/mac/BrowserWindowController.h:
1741         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1742         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1743
1744 2010-04-22  Dave Moore  <davemoore@chromium.org>
1745
1746         Reviewed by Dimitri Glazkov.
1747
1748         Add test support for icon changes.
1749
1750         https://bugs.webkit.org/show_bug.cgi?id=33812
1751
1752         * DumpRenderTree/LayoutTestController.cpp:
1753         (LayoutTestController::LayoutTestController):
1754         (dumpIconChangesCallback):
1755         (LayoutTestController::staticFunctions):
1756         * DumpRenderTree/LayoutTestController.h:
1757         (LayoutTestController::dumpIconChanges):
1758         (LayoutTestController::setDumpIconChanges):
1759         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1760         (FrameLoadDelegate::didChangeIcons):
1761         * DumpRenderTree/win/FrameLoadDelegate.h:
1762         * WinLauncher/WinLauncher.h:
1763         (WinLauncherWebHost::didChangeIcons):
1764
1765 2010-04-22  Eric Seidel  <eric@webkit.org>
1766
1767         Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.
1768
1769         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1770         https://bugs.webkit.org/show_bug.cgi?id=37794
1771
1772         The bots are seeing cases where .error is sometimes empty.
1773         Lets make the code not crash in that case for now.
1774
1775         * Scripts/webkitpy/layout_tests/port/webkit.py:
1776
1777 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1778
1779         Unreviewed fix.
1780
1781         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
1782
1783 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1784
1785         Unreviewed fix.
1786
1787         * Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
1788
1789 2010-04-22  Eric Seidel  <eric@webkit.org>
1790
1791         Unreviewed.  Restore the Leopard bots to using
1792         old-run-webkit-tests for now.
1793
1794         * Scripts/run-webkit-tests:
1795
1796 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1797
1798         Unreviewed fix.
1799
1800         * Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
1801
1802 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1803
1804         Unreviewed fix.
1805
1806         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
1807
1808 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1809
1810         Reviewed by Adam Barth.
1811
1812         Chromium: Add --chromium option to new-run-webkit-websocketserver
1813         https://bugs.webkit.org/show_bug.cgi?id=37664
1814
1815         Move cygwin setup logic in chromium_win.py.
1816
1817         * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
1818         * Scripts/new-run-webkit-websocketserver: add --chromium flag
1819         * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
1820         * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
1821         * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
1822
1823 2010-04-22  Eric Seidel  <eric@webkit.org>
1824
1825         Reviewed by Adam Barth.
1826
1827         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1828         https://bugs.webkit.org/show_bug.cgi?id=37794
1829
1830         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1831          - Fix the log message to explain that this is stderr output, not test output.
1832         * Scripts/webkitpy/layout_tests/port/webkit.py:
1833          - Be sure to reset the server_process.error after reading (seems like the wrong
1834            place to do this, but at least this fixes the bug and dpranke and I can talk
1835            about better designs later).
1836          - Also remove the #EOF from the stderr output before returning it.
1837
1838 2010-04-22  Eric Seidel  <eric@webkit.org>
1839
1840         Unreviewed.  Fixing new-run-webkit-tests on the bots.
1841
1842         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1843          - Fixing _compat_shim_option to take variable keyword args.
1844          - Turns out that nargs + callback is ignored unless type is specified.
1845            So I added the type so that the option was properly consumed.
1846            This was why new-run-webkit-tests couldn't find any tests, it
1847            was looking for them under "20" because that was the argument
1848            which should have been consumed by --exit-after-n-failures.
1849
1850 2010-04-22  Tony Chang  <tony@chromium.org>
1851
1852         Not reviewed, build fix for chromium Windows.
1853
1854         [chromium] fix ImageDiff compile on windows
1855         https://bugs.webkit.org/show_bug.cgi?id=37979
1856
1857         * DumpRenderTree/chromium/ImageDiff.cpp:
1858
1859 2010-04-22  Adam Barth  <abarth@webkit.org>
1860
1861         Unreviewed, rolling out r58069.
1862         http://trac.webkit.org/changeset/58069
1863         https://bugs.webkit.org/show_bug.cgi?id=27751
1864
1865         Broke compile on Windows.
1866
1867         * DumpRenderTree/LayoutTestController.cpp:
1868         (LayoutTestController::staticFunctions):
1869         * DumpRenderTree/LayoutTestController.h:
1870         * DumpRenderTree/chromium/LayoutTestController.cpp:
1871         (LayoutTestController::LayoutTestController):
1872         (LayoutTestController::overridePreference):
1873         * DumpRenderTree/chromium/LayoutTestController.h:
1874         * DumpRenderTree/chromium/TestShell.cpp:
1875         (TestShell::resetWebSettings):
1876         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1877         * DumpRenderTree/mac/DumpRenderTree.mm:
1878         (resetDefaultsToConsistentValues):
1879         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1880         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1881         (WebCore::WebPage::WebPage):
1882         (WebCore::WebPage::resetSettings):
1883         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1884         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1885         * DumpRenderTree/win/DumpRenderTree.cpp:
1886         (resetDefaultsToConsistentValues):
1887         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1888         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1889
1890 2010-04-22  Eric Seidel  <eric@webkit.org>
1891
1892         Unreviewed.  Just adding logging.
1893
1894         Adding logging to help debug why the Leopard Bot
1895         can't find any tests to run.
1896
1897         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1898         * Scripts/webkitpy/layout_tests/port/base.py:
1899         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1900          - Make it a fatal error to have no tests to run.
1901
1902 2010-04-22  Abhishek Arya  <inferno@chromium.org>
1903
1904         Reviewed by Adam Barth.
1905
1906         Add support for controlling clipboard access from javascript.
1907         Clipboard access from javascript is enabled in test framework.
1908         https://bugs.webkit.org/show_bug.cgi?id=27751
1909
1910         * DumpRenderTree/LayoutTestController.cpp:
1911         (setJavaScriptCanAccessClipboardCallback):
1912         (LayoutTestController::staticFunctions):
1913         * DumpRenderTree/LayoutTestController.h:
1914         * DumpRenderTree/chromium/LayoutTestController.cpp:
1915         (LayoutTestController::LayoutTestController):
1916         (LayoutTestController::setJavaScriptCanAccessClipboard):
1917         (LayoutTestController::overridePreference):
1918         * DumpRenderTree/chromium/LayoutTestController.h:
1919         * DumpRenderTree/chromium/TestShell.cpp:
1920         (TestShell::resetWebSettings):
1921         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1922         (LayoutTestController::setJavaScriptCanAccessClipboard):
1923         * DumpRenderTree/mac/DumpRenderTree.mm:
1924         (resetDefaultsToConsistentValues):
1925         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1926         (LayoutTestController::setJavaScriptCanAccessClipboard):
1927         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1928         (WebCore::WebPage::WebPage):
1929         (WebCore::WebPage::resetSettings):
1930         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1931         (LayoutTestController::setJavaScriptCanAccessClipboard):
1932         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1933         * DumpRenderTree/win/DumpRenderTree.cpp:
1934         (resetDefaultsToConsistentValues):
1935         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1936         (LayoutTestController::setJavaScriptCanAccessClipboard):
1937         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1938         (LayoutTestController::setJavaScriptCanAccessClipboard):
1939
1940 2010-04-21  Adam Barth  <abarth@webkit.org>
1941
1942         Reviewed by Eric Seidel.
1943
1944         webkit-patch can't fetch attachments on security bugs
1945         https://bugs.webkit.org/show_bug.cgi?id=37975
1946
1947         Instead of calling CURL, we just need to use our Mechanize object,
1948         which understand bugs.webkit.org authentication.
1949
1950         * Scripts/webkitpy/common/checkout/api.py:
1951         * Scripts/webkitpy/common/net/bugzilla.py:
1952
1953 2010-04-21  Eric Seidel  <eric@webkit.org>
1954
1955         Unreviewed.  Temporary commit, will roll-out before morning.
1956
1957         Turning on new-run-webkit-tests for the Leopard build bot
1958         for testing of the harness.
1959         Users should not noctice (except for the results.html difference).
1960
1961         * Scripts/run-webkit-tests:
1962
1963 2010-04-21  Eric Seidel  <eric@webkit.org>
1964
1965         Unreviewed.  Fix typo in my previous fix attempt.
1966
1967         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1968         https://bugs.webkit.org/show_bug.cgi?id=37765
1969
1970         More on-the-bot debugging, sigh.  I wish I had a local build.
1971
1972         * Scripts/webkitpy/layout_tests/port/base.py:
1973
1974 2010-04-21  Eric Seidel  <eric@webkit.org>
1975
1976         Unreviewed.  Fix typo in my previous fix attempt.
1977
1978         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1979         https://bugs.webkit.org/show_bug.cgi?id=37765
1980
1981         * Scripts/webkitpy/layout_tests/port/base.py:
1982          - Add self. to class variable access.
1983
1984 2010-04-21  Eric Seidel  <eric@webkit.org>
1985
1986         Unreviewed.  Another attempt to fix NRWT for chromium.
1987
1988         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1989         https://bugs.webkit.org/show_bug.cgi?id=37765
1990
1991         * Scripts/webkitpy/layout_tests/port/base.py:
1992          - wdiff_text was returning a byte array instead of a
1993            unicode string.  The simple fix was to just decode
1994            the result.  However, seeing so much duplicated code
1995            with Executive made me cry, so I re-wrote the function
1996            to be more like pretty_patch_text and use run_command
1997            (which already knows how to handle unicode).
1998
1999 2010-04-21  Adam Barth  <abarth@webkit.org>
2000
2001         Reviewed by Eric Seidel.
2002
2003         Windows tests buildbots are too slow to be core builders
2004         https://bugs.webkit.org/show_bug.cgi?id=37970
2005
2006         It's 10:45.  The Windows test bots are still hours behind.  They're too
2007         slow to be core builders.  When they get fast, we can add them back.
2008
2009         * Scripts/webkitpy/common/net/buildbot.py:
2010         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2011
2012 2010-04-21  Eric Seidel  <eric@webkit.org>
2013
2014         Unreviewed.  Attempt one more time to fix NRWT for chromium.
2015
2016         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2017         https://bugs.webkit.org/show_bug.cgi?id=37765
2018
2019         I'm debugging in the blind because I don't have a chromium
2020         build on this laptop.
2021
2022         * Scripts/webkitpy/layout_tests/port/chromium.py:
2023          - Apply the previous fix to a second caller.
2024
2025 2010-04-21  Eric Seidel  <eric@webkit.org>
2026
2027         Unreviewed.  Attempt one more time to fix NRWT for chromium.
2028
2029         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2030         https://bugs.webkit.org/show_bug.cgi?id=37765
2031
2032         * Scripts/webkitpy/layout_tests/port/chromium.py:
2033          - Fix handling of test_shell output so that we always
2034            decode it as utf-8.
2035            Unlike DumpRenderTree test_shell does not ever return
2036            pixel data.  It spits out the pixel dumps in a separate
2037            file, thus all output over stdout is utf-8 text.
2038
2039 2010-04-21  Eric Seidel  <eric@webkit.org>
2040
2041         Unreviewed.  Attempt one more time to fix NRWT for chromium.
2042
2043         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2044         https://bugs.webkit.org/show_bug.cgi?id=37765
2045
2046         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2047          - Pass encoding to _save_baseline_data and write_output_files
2048         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2049          - Make _save_baseline_data and write_output_files take an encoding.
2050         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2051         - Pass encoding to _save_baseline_data and write_output_files
2052
2053 2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
2054
2055         Reviewed by Kenneth Rohde Christiansen.
2056
2057         [Qt] QtLauncher: make FPS measurement accurate
2058         https://bugs.webkit.org/show_bug.cgi?id=37934
2059
2060         Instead of counting paints, which are not interchangeable with frames that
2061         the user sees, we now set an arbitrary timer for FPS measurements. The idea is
2062         that if the main thread is delayed for any reason, that timer would be delayed
2063         as well.
2064
2065         * QtLauncher/QtLauncher.pro:
2066         * QtLauncher/fpstimer.cpp: Added.
2067         (FpsTimer::FpsTimer):
2068         (FpsTimer::numFrames):
2069         (FpsTimer::start):
2070         (FpsTimer::stop):
2071         (FpsTimer::timerEvent):
2072         * QtLauncher/fpstimer.h: Added.
2073         * QtLauncher/webview.cpp:
2074         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
2075         (WebViewGraphicsBased::updateFrameRate):
2076         (WebViewGraphicsBased::paintEvent):
2077         * QtLauncher/webview.h:
2078
2079 2010-04-21  Eric Seidel  <eric@webkit.org>
2080
2081         Unreviewed, just adding missing ":" in python file.
2082
2083         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2084         https://bugs.webkit.org/show_bug.cgi?id=37765
2085
2086         new-run-webkit-tests --chromium was borked.
2087
2088         * Scripts/webkitpy/layout_tests/port/chromium.py:
2089
2090 2010-04-21  Eric Seidel  <eric@webkit.org>
2091
2092         Reviewed by Adam Barth.
2093
2094         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2095         https://bugs.webkit.org/show_bug.cgi?id=37765
2096
2097         Third time is the charm.  I've fixed all the
2098         new-run-webkit-tests regressions from previous attempts.
2099
2100         I fixed the queue to not ignore Tor as a reviwer in r57531,
2101         but instead it throws an exception every time his name is in a patch.
2102
2103         This fixes our Executive.run_command code to work around a Popen
2104         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
2105         do not correctly handle unicode objects as input or output to
2106         Popen.communicate.
2107
2108         Following the advice of:
2109         http://farmdev.com/talks/unicode/
2110         I have changed all of webkitpy to use unicode() objects as strings
2111         instead of str objects (which in Python 3 are renamed "bytes").
2112
2113         String literals were left as "foo" instead of converting to u"foo"
2114         as u"foo" is only required if the string has a non-ascii code point.
2115         Python is smart about comparing str() and unicode() values and will
2116         log an error to the console if the comparison is ever invalid.
2117
2118         Executive.run* now correctly accept and return unicode() objects.
2119         I attempted to fix all the places that we call .write() to make sure we
2120         encode any unicode() objects into utf-8.
2121
2122         I removed several uses of StringIO.  StringIO should generally always be
2123         passed a unicode() value.
2124
2125         Likewise I replaced most calls to open() with codecs.open().
2126         codecs.open() matches Python 3 open semantics in requiring an encoding
2127         parameter.  Files opened with codecs.open() with a unicode-compatible
2128         encoding will vend unicode() objects from their read() calls, like how
2129         StringIO created with a unicode() object will do.
2130
2131         I also deployed "with" statements wider (now that the project has
2132         settled on Python 2.5) to close a bunch of file descriptor leaks.
2133
2134         * Scripts/webkitpy/common/checkout/api_unittest.py:
2135          - Read/write utf-8 files instead of ascii.
2136          - Update the tests to use test for proper unicode() handling.
2137         * Scripts/webkitpy/common/checkout/changelog.py:
2138          - Document that parse_latest_entry_from_file expects
2139            file-like objects which return unicode strings.
2140         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2141          - Use unicode() strings instead of str() byte arrays.
2142          - Deploy "with" to close file descriptor leaks.
2143         * Scripts/webkitpy/common/checkout/commitinfo.py:
2144          - Remove unneeded import.
2145         * Scripts/webkitpy/common/checkout/scm.py:
2146          - Remove use of str().
2147         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2148          - Read/write utf-8 files and use unicode() strings in testing.
2149         * Scripts/webkitpy/common/config/committers.py:
2150          - Use \u instead of \x to make slightly clearer what we're doing.
2151         * Scripts/webkitpy/common/net/bugzilla.py:
2152          - Add a new _string_contents() method and explain why
2153             we have to call unicode() on the result of soup.string
2154             and why it's safe to do so w/o needing to pass a codec name.
2155           - Remove the (unused) support for passing a file object to add_patch_to_bug().
2156         * Scripts/webkitpy/common/net/buildbot.py:
2157          - Use unicode() instead of str() when needing to coax a
2158             NavigableString object into a unicode() object.
2159         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2160          - Add a test which contains a unicode builder name.
2161         * Scripts/webkitpy/common/net/statusserver.py:
2162          - Remove use of str()
2163         * Scripts/webkitpy/common/prettypatch.py:
2164          - Write out the patch file as utf-8.
2165         * Scripts/webkitpy/common/system/autoinstall.py:
2166          - Write out files with a explicit encodings.
2167          - Deploy "with" to close file descriptor leaks.
2168         * Scripts/webkitpy/common/system/deprecated_logging.py:
2169          - Write out log files as utf-8.
2170         * Scripts/webkitpy/common/system/executive.py:
2171          - Make run* properly take and return unicode() objects.
2172          - Cleaned up input handling in run_command a little by adding
2173            a _compute_input() method which can return early instead of having
2174            such a long/cluttered if-block.
2175         * Scripts/webkitpy/common/system/executive_unittest.py:
2176          - Added a unit test to make sure we don't break Tor again!
2177         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2178          - Write out the test list as utf-8.
2179         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2180          - Write out json files as utf-8.
2181         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2182          - Deploy "with" to close file descriptor leaks.
2183         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
2184         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
2185         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
2186         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
2187         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
2188         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2189          - Make the skipped file parsing test unicode.
2190         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
2191         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
2192         * Scripts/webkitpy/layout_tests/port/webkit.py:
2193          - Deploy "with" to close file descriptor leaks.
2194         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2195          - Make explicit the encodings of log files and pid files.
2196         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2197          - Make encodings explicit and deploy "with".
2198         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
2199         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
2200         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
2201         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
2202         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
2203         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
2204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2205          - Removed extra import.
2206         * Scripts/webkitpy/tool/commands/queues.py:
2207          - No need to map args to strings now that run_command does.
2208          - Update test results to match args changes.
2209          - Document our global argument hacks.
2210         * Scripts/webkitpy/tool/commands/upload.py:
2211          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2212         * Scripts/webkitpy/tool/mocktool.py:
2213          - Rename add_patch_to_bug argument to match bugzilla.py
2214         * Scripts/webkitpy/tool/steps/abstractstep.py:
2215          - Executive.run_* now require lists instead of strings.
2216            The lack of this change was what broke webkit-patch
2217            for svn users the first time this was landed.
2218         * Scripts/webkitpy/tool/steps/postdiff.py:
2219          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2220         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
2221         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
2222         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2223          - Fixed spurious logging seen when running test-webkitpy
2224
2225 2010-04-21  Chris Fleizach  <cfleizach@apple.com>
2226
2227         Reviewed by Alexey Proskuryakov.
2228
2229         aria-liveregion-notifications.html fails on leopard release bot
2230         https://bugs.webkit.org/show_bug.cgi?id=37112
2231
2232         Change the way that notifications are listened for by forcing clients
2233         to call a remove listener as well to match the add listener. DRT will
2234         assert if those are not done in the correct order. 
2235
2236         * DumpRenderTree/AccessibilityUIElement.cpp:
2237         (removeNotificationListenerCallback):
2238         (AccessibilityUIElement::getJSClass):
2239         * DumpRenderTree/AccessibilityUIElement.h:
2240         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2241         (AccessibilityUIElement::removeNotificationListener):
2242         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2243         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
2244         (-[AccessibilityNotificationHandler dealloc]):
2245         (-[AccessibilityNotificationHandler _notificationReceived:]):
2246         (-[AccessibilityNotificationHandler setCallback:]):
2247         (AccessibilityUIElement::AccessibilityUIElement):
2248         (AccessibilityUIElement::~AccessibilityUIElement):
2249         (AccessibilityUIElement::addNotificationListener):
2250         (AccessibilityUIElement::removeNotificationListener):
2251         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2252         (AccessibilityUIElement::removeNotificationListener):
2253
2254 2010-04-21  Anders Carlsson  <andersca@apple.com>
2255
2256         Reviewed by Sam Weinig.
2257
2258         Add debug menu items to show/hide the Web View.
2259         https://bugs.webkit.org/show_bug.cgi?id=37958
2260
2261         * MiniBrowser/mac/BrowserWindowController.h:
2262         * MiniBrowser/mac/BrowserWindowController.m:
2263         (-[BrowserWindowController showHideWebView:]):
2264         (-[BrowserWindowController removeReinsertWebView:]):
2265         (-[BrowserWindowController validateMenuItem:]):
2266         * MiniBrowser/mac/English.lproj/MainMenu.xib:
2267
2268 2010-04-21  Eric Seidel  <eric@webkit.org>
2269
2270         Unreviewed.  Rolling out unicode() changes as they broke NRWT for chromium.
2271         Rolling out:
2272         http://trac.webkit.org/changeset/58014
2273         http://trac.webkit.org/changeset/58016
2274         http://trac.webkit.org/changeset/58020
2275
2276         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
2277         https://bugs.webkit.org/show_bug.cgi?id=37765
2278
2279         * Scripts/webkitpy/common/checkout/api_unittest.py:
2280         * Scripts/webkitpy/common/checkout/changelog.py:
2281         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2282         * Scripts/webkitpy/common/checkout/commitinfo.py:
2283         * Scripts/webkitpy/common/checkout/scm.py:
2284         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2285         * Scripts/webkitpy/common/config/committers.py:
2286         * Scripts/webkitpy/common/net/bugzilla.py:
2287         * Scripts/webkitpy/common/net/buildbot.py:
2288         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2289         * Scripts/webkitpy/common/net/statusserver.py:
2290         * Scripts/webkitpy/common/prettypatch.py:
2291         * Scripts/webkitpy/common/system/autoinstall.py:
2292         * Scripts/webkitpy/common/system/deprecated_logging.py:
2293         * Scripts/webkitpy/common/system/executive.py:
2294         * Scripts/webkitpy/common/system/executive_unittest.py:
2295         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2296         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2297         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2298         * Scripts/webkitpy/layout_tests/port/chromium.py:
2299         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2300         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2301         * Scripts/webkitpy/layout_tests/port/gtk.py:
2302         * Scripts/webkitpy/layout_tests/port/mac.py:
2303         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2304         * Scripts/webkitpy/layout_tests/port/qt.py:
2305         * Scripts/webkitpy/layout_tests/port/server_process.py:
2306         * Scripts/webkitpy/layout_tests/port/webkit.py:
2307         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2308         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2309         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2310         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2311         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2312         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2313         * Scripts/webkitpy/style/filereader_unittest.py:
2314         * Scripts/webkitpy/thirdparty/__init__.py:
2315         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2316         * Scripts/webkitpy/tool/commands/queues.py:
2317         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2318         * Scripts/webkitpy/tool/commands/upload.py:
2319         * Scripts/webkitpy/tool/mocktool.py:
2320         * Scripts/webkitpy/tool/steps/abstractstep.py:
2321         * Scripts/webkitpy/tool/steps/postdiff.py:
2322         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2323         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2324         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2325
2326 2010-04-21  Eric Seidel  <eric@webkit.org>
2327
2328         Unreviewed, fixing NRWT for real this time.
2329
2330         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2331         https://bugs.webkit.org/show_bug.cgi?id=37765
2332
2333         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2334          - Add a hack to fix new-run-webkit-tests
2335            my understanding of codecs.open(encoding=None)
2336            must have been wrong.
2337
2338 2010-04-21  Eric Seidel  <eric@webkit.org>
2339
2340         Unreviewed, just fixing exception seen on builders.
2341
2342         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2343         https://bugs.webkit.org/show_bug.cgi?id=37765
2344
2345         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2346          - Pass and encoding to _write_into_file_at_path
2347
2348 2010-04-21  Eric Seidel  <eric@webkit.org>
2349
2350         Reviewed by Adam Barth.
2351
2352         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2353         https://bugs.webkit.org/show_bug.cgi?id=37765
2354
2355         I fixed the queue to not ignore Tor as a reviwer in r57531,
2356         but instead it throws an exception every time his name is in a patch.
2357
2358         This fixes our Executive.run_command code to work around a Popen
2359         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
2360         do not correctly handle unicode objects as input or output to
2361         Popen.communicate.
2362
2363         Following the advice of:
2364         http://farmdev.com/talks/unicode/
2365         I have changed all of webkitpy to use unicode() objects as strings
2366         instead of str objects (which in Python 3 are renamed "bytes").
2367
2368         String literals were left as "foo" instead of converting to u"foo"
2369         as u"foo" is only required if the string has a non-ascii code point.
2370         Python is smart about comparing str() and unicode() values and will
2371         log an error to the console if the comparison is ever invalid.
2372
2373         Executive.run* now correctly accept and return unicode() objects.
2374         I attempted to fix all the places that we call .write() to make sure we
2375         encode any unicode() objects into utf-8.
2376
2377         I removed several uses of StringIO.  StringIO should generally always be
2378         passed a unicode() value.
2379
2380         Likewise I replaced most calls to open() with codecs.open().
2381         codecs.open() matches Python 3 open semantics in requiring an encoding
2382         parameter.  Files opened with codecs.open() with a unicode-compatible
2383         encoding will vend unicode() objects from their read() calls, like how
2384         StringIO created with a unicode() object will do.
2385
2386         I also deployed "with" statements wider (now that the project has
2387         settled on Python 2.5) to close a bunch of file descriptor leaks.
2388
2389         * Scripts/webkitpy/common/checkout/api_unittest.py:
2390          - Read/write utf-8 files instead of ascii.
2391          - Update the tests to use test for proper unicode() handling.
2392         * Scripts/webkitpy/common/checkout/changelog.py:
2393          - Document that parse_latest_entry_from_file expects
2394            file-like objects which return unicode strings.
2395         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2396          - Use unicode() strings instead of str() byte arrays.
2397          - Deploy "with" to close file descriptor leaks.
2398         * Scripts/webkitpy/common/checkout/commitinfo.py:
2399          - Remove unneeded import.
2400         * Scripts/webkitpy/common/checkout/scm.py:
2401          - Remove use of str().
2402         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2403          - Read/write utf-8 files and use unicode() strings in testing.
2404         * Scripts/webkitpy/common/config/committers.py:
2405          - Use \u instead of \x to make slightly clearer what we're doing.
2406         * Scripts/webkitpy/common/net/bugzilla.py:
2407          - Add a new _string_contents() method and explain why
2408             we have to call unicode() on the result of soup.string
2409             and why it's safe to do so w/o needing to pass a codec name.
2410           - Remove the (unused) support for passing a file object to add_patch_to_bug().
2411         * Scripts/webkitpy/common/net/buildbot.py:
2412          - Use unicode() instead of str() when needing to coax a
2413             NavigableString object into a unicode() object.
2414         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2415          - Add a test which contains a unicode builder name.
2416         * Scripts/webkitpy/common/net/statusserver.py:
2417          - Remove use of str()
2418         * Scripts/webkitpy/common/prettypatch.py:
2419          - Write out the patch file as utf-8.
2420         * Scripts/webkitpy/common/system/autoinstall.py:
2421          - Write out files with a explicit encodings.
2422          - Deploy "with" to close file descriptor leaks.
2423         * Scripts/webkitpy/common/system/deprecated_logging.py:
2424          - Write out log files as utf-8.
2425         * Scripts/webkitpy/common/system/executive.py:
2426          - Make run* properly take and return unicode() objects.
2427          - Cleaned up input handling in run_command a little by adding
2428            a _compute_input() method which can return early instead of having
2429            such a long/cluttered if-block.
2430         * Scripts/webkitpy/common/system/executive_unittest.py:
2431          - Added a unit test to make sure we don't break Tor again!
2432         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2433          - Write out the test list as utf-8.
2434         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2435          - Write out json files as utf-8.
2436         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2437          - Deploy "with" to close file descriptor leaks.
2438         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
2439         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
2440         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
2441         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
2442         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
2443         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2444          - Make the skipped file parsing test unicode.
2445         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
2446         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
2447         * Scripts/webkitpy/layout_tests/port/webkit.py:
2448          - Deploy "with" to close file descriptor leaks.
2449         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2450          - Make explicit the encodings of log files and pid files.
2451         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2452          - Make encodings explicit and deploy "with".
2453         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
2454         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
2455         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
2456         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
2457         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
2458         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
2459         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2460          - Removed extra import.
2461         * Scripts/webkitpy/tool/commands/queues.py:
2462          - No need to map args to strings now that run_command does.
2463          - Update test results to match args changes.
2464          - Document our global argument hacks.
2465         * Scripts/webkitpy/tool/commands/upload.py:
2466          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2467         * Scripts/webkitpy/tool/mocktool.py:
2468          - Rename add_patch_to_bug argument to match bugzilla.py
2469         * Scripts/webkitpy/tool/steps/abstractstep.py:
2470          - Executive.run_* now require lists instead of strings.
2471            The lack of this change was what broke webkit-patch
2472            for svn users the first time this was landed.
2473         * Scripts/webkitpy/tool/steps/postdiff.py:
2474          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2475         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
2476         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
2477         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2478          - Fixed spurious logging seen when running test-webkitpy
2479
2480 2010-04-21  Kinuko Yasuda  <kinuko@chromium.org>
2481
2482         Unreviewed.
2483
2484         Add myself in committers.py.
2485
2486         * Scripts/webkitpy/common/config/committers.py:
2487
2488 2010-04-21  Dirk Pranke  <dpranke@chromium.org>
2489
2490         Reviewed by Dimitri Glazkov.
2491
2492         new-run-webkit-tests: fix a bug in the Chromium port where we would
2493         try to talk to a crashed test_shell and raise exceptions that weren't
2494         being caught.
2495
2496         https://bugs.webkit.org/show_bug.cgi?id=37941
2497
2498         * Scripts/webkitpy/layout_tests/port/chromium.py:
2499
2500 2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2501
2502         Unreviewed.
2503
2504         [Qt] [Symbian] Build fix.
2505
2506         Work around a Qt quirk. Some versions of Symbian port Qt
2507         QFontDatabase::removeAllApplicationFonts symbol is not available.
2508
2509         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2510         (WebCore::DumpRenderTree::open):
2511
2512 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
2513
2514         Unreviewed.
2515
2516         https://bugs.webkit.org/show_bug.cgi?id=37933
2517         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
2518
2519         Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
2520         a real implementation may or may not be necessary for the one test that currently uses it
2521         to pass.
2522
2523         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2524         (LayoutTestController::authenticateSession):
2525         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2526
2527 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
2528
2529         Reviewed by Brady Eidson.
2530
2531         https://bugs.webkit.org/show_bug.cgi?id=37933
2532         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
2533
2534         Adding authenticateSession() method that adds credentials to per-process credential storage
2535         (for platforms that even have such). No Windows implementation, because writing another
2536         loader for DRT is painful.
2537
2538         * DumpRenderTree/LayoutTestController.cpp:
2539         (authenticateSessionCallback):
2540         (LayoutTestController::staticFunctions):
2541         * DumpRenderTree/LayoutTestController.h:
2542         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2543         (-[SynchronousLoader dealloc]):
2544         (-[SynchronousLoader connectionShouldUseCredentialStorage:]):
2545         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2546         (-[SynchronousLoader connection:didFailWithError:]):
2547         (-[SynchronousLoader connectionDidFinishLoading:]):
2548         (+[SynchronousLoader makeRequest:withUsername:password:]):
2549         (LayoutTestController::authenticateSession):
2550
2551         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2552         (LayoutTestController::authenticateSession):
2553         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2554         (LayoutTestController::authenticateSession):
2555         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2556         (LayoutTestController::authenticateSession):
2557         Stub implementations.
2558
2559 2010-04-21  Kent Tamura  <tkent@chromium.org>
2560
2561         Reviewed by Dimitri Glazkov.
2562
2563         [DRT/Chromium] Make DRT compilable in Chromium tree
2564         https://bugs.webkit.org/show_bug.cgi?id=37923
2565
2566         We need to use different GYPs in a case of WebKit-only checkout
2567         and a case of whole Chromium checkout because the relative paths
2568         from webkit/ to WebKit/chromium/features.gypi are different in
2569         these cases and we can't use 'conditions' for 'includes' in GYPs.
2570
2571         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2572
2573 2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>
2574
2575         Reviewed by Darin Adler.
2576
2577         List item markers are not always updated after changes in the DOM.
2578         https://bugs.webkit.org/show_bug.cgi?id=37060
2579
2580         * DumpRenderTree/LayoutTestController.cpp:
2581         (markerTextForListItemCallback): A function that returns the marker text for a given list item.
2582         (LayoutTestController::staticFunctions):
2583         * DumpRenderTree/LayoutTestController.h:
2584         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2585         (LayoutTestController::markerTextForListItem): Implement it in the GTK port.
2586         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2587         (LayoutTestController::markerTextForListItem): Add a stub.
2588         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2589         (LayoutTestController::LayoutTestController):
2590         (LayoutTestController::markerTextForListItem): Implement it in the Qt port.
2591         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2592         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2593         (LayoutTestController::markerTextForListItem): Add a stub.
2594
2595 2010-04-21  Adam Roben  <aroben@apple.com>
2596
2597         Exclude leaks in CGGradientCreateWithColorComponents from
2598         run-webkit-tests leaks output
2599
2600         The leak in CG is covered by <rdar://problem/7888492>.
2601
2602         Fixes <http://webkit.org/b/37927>.
2603
2604         Reviewed by Eric Carlson.
2605
2606         * Scripts/old-run-webkit-tests:
2607         (sub countAndPrintLeaks): Exclude leaks in
2608         CGGradientCreateWithColorComponents on certain OSs.
2609
2610 2010-04-21  Kent Tamura  <tkent@chromium.org>
2611
2612         Reviewed by Shinichiro Hamaji.
2613
2614         [DRT/Chromium] Import MockSpellCheck from Chromium
2615         https://bugs.webkit.org/show_bug.cgi?id=37910
2616
2617         Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.
2618
2619         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2620           Add ICU explicitly because WTFString.h includes ICU headers.
2621           Add MockSpellCheck.{cpp,h}.
2622         * DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
2623         * DumpRenderTree/chromium/MockSpellCheck.h: Added.
2624         * DumpRenderTree/chromium/WebViewHost.cpp:
2625         (WebViewHost::spellCheck):
2626         * DumpRenderTree/chromium/WebViewHost.h:
2627         * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used
2628           by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
2629
2630 2010-04-21  Adam Barth  <abarth@webkit.org>
2631
2632         Reviewed by Eric Seidel.
2633
2634         Add webkit-patch pretty-diff
2635         https://bugs.webkit.org/show_bug.cgi?id=37892
2636
2637         This is slightly lame because it asks you whether the diff is correct,
2638         but it's a starting point.
2639
2640         * Scripts/webkitpy/tool/commands/__init__.py:
2641         * Scripts/webkitpy/tool/commands/prettydiff.py: Added.
2642         * Scripts/webkitpy/tool/main.py:
2643
2644 2010-04-21  Adam Barth  <abarth@webkit.org>
2645
2646         Reviewed by Darin Adler.
2647
2648         Remove mention of non-existant --no-build option
2649         https://bugs.webkit.org/show_bug.cgi?id=37893
2650
2651         The option doesn't exist!
2652
2653         * Scripts/webkitpy/tool/commands/stepsequence.py:
2654
2655 2010-04-21  Balazs Kelemen  <kb@inf.u-szeged.hu>
2656
2657         Reviewed by Kenneth Rohde Christiansen.
2658
2659         [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
2660         https://bugs.webkit.org/show_bug.cgi?id=37198
2661
2662         * QtLauncher/main.cpp:
2663         (LauncherWindow::toggleInterruptingJavaScriptEnabled):
2664         (LauncherWindow::newWindow):
2665         (LauncherWindow::cloneWindow):
2666         (LauncherWindow::createChrome):
2667         (main):
2668         * QtLauncher/webpage.cpp:
2669         (WebPage::WebPage):
2670         (WebPage::shouldInterruptJavaScript):
2671         * QtLauncher/webpage.h:
2672         (WebPage::setInterruptingJavaScriptEnabled):
2673
2674 2010-04-21  Eric Seidel  <eric@webkit.org>
2675
2676         Unreviewed, rolling out r57963.
2677         http://trac.webkit.org/changeset/57963
2678         https://bugs.webkit.org/show_bug.cgi?id=37759
2679
2680         Three tests started crashing on the Qt bot.
2681
2682         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2683         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2684
2685 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2686
2687         Reviewed by Eric Seidel.
2688
2689         Make new-run-webkit-tests work for the Qt port
2690         https://bugs.webkit.org/show_bug.cgi?id=37588
2691
2692         * Scripts/webkitpy/layout_tests/port/qt.py:
2693
2694 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2695
2696         Reviewed by Eric Seidel.
2697
2698         new-run-webkit-tests: try to detect alternate apache path
2699         https://bugs.webkit.org/show_bug.cgi?id=37587
2700
2701         _check_port_build() also needs to return true in the
2702         base implementation to not fail the check_build step.
2703
2704         * Scripts/webkitpy/layout_tests/port/webkit.py:
2705
2706 2010-04-21  Yi Shen  <yi.4.shen@nokia.com>
2707
2708         Reviewed by Simon Hausmann.
2709
2710         [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
2711         https://bugs.webkit.org/show_bug.cgi?id=37759
2712
2713         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2714         (LayoutTestController::computedStyleIncludingVisitedInfo):
2715         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2716
2717 2010-04-21  Eric Seidel  <eric@webkit.org>
2718
2719         Unreviewed, test fix only.
2720
2721         new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
2722         https://bugs.webkit.org/show_bug.cgi?id=37726
2723
2724         This change seems to have broken a test.
2725         Attempting to handle the case where we don't have any
2726         timing information.  Dirk may have to correct this change.
2727
2728         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2729
2730 2010-04-19  Eric Seidel  <eric@webkit.org>
2731
2732         Reviewed by Adam Barth.
2733
2734         new-run-webkit-tests has much higher startup latency than run-webkit-tests
2735         https://bugs.webkit.org/show_bug.cgi?id=37643
2736
2737         I got rid of the -expected.checksum reads during startup.
2738         This makes startup noticably better on my laptop.
2739
2740         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2741          - Use image_hash() instead of .image_hash now that expected.checksum
2742            file reads are done lazily.
2743         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2744          - Add debug logging for this sleep call.
2745            In my testing I never saw this sleep() hit.
2746         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2747          - Sleep a shorter interval to make websocket server
2748            startup more responsive.  On my machine startup was
2749            taking around 1 second.
2750          - Remove the unconditional .5s delay on startup.
2751         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2752          - Make image_hash file reads done lazily in a new image_hash() function.
2753          - Add a "Starting testing ..." meter update after DRT threads have
2754            been started, but before we get updates from the first one.
2755          - Rename variable "t" to a full english name to match WebKit style.
2756
2757 2010-04-20  Daniel Bates  <dbates@rim.com>
2758
2759         Reviewed by Eric Seidel.
2760
2761         https://bugs.webkit.org/show_bug.cgi?id=37748
2762
2763         Make Sheriffbot more inspirational.
2764
2765         * Scripts/webkitpy/common/net/bugzilla.py:
2766         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2767         * Scripts/webkitpy/tool/bot/irc_command.py:
2768         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2769         * Scripts/webkitpy/tool/mocktool.py:
2770
2771 2010-04-20  Kent Tamura  <tkent@chromium.org>
2772
2773         Reviewed by Dimitri Glazkov.
2774
2775         [DRT/Chromium] Import Chromium image_diff as ImageDiff
2776         https://bugs.webkit.org/show_bug.cgi?id=37790
2777
2778         ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
2779
2780         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2781         * DumpRenderTree/chromium/ImageDiff.cpp: Added.
2782         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2783
2784 2010-04-20  Dirk Pranke <dpranke@chromium.org>
2785
2786         This patch to new-run-webkit-tests adds a --log 'trace' option
2787         that prints out detailed info about a given test as it executes
2788         (where the baselines are, what the expectation is, what we got,
2789         how long it took).
2790
2791         https://bugs.webkit.org/show_bug.cgi?id=37726
2792
2793         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2794           - use the newly exposed TestResult class and implement
2795             --log trace
2796         * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
2797           - rename TestStats to TestResult and make it more public, resulting
2798             in cleaner code
2799         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2800           - add expectation_to_string() as a separate callable function
2801
2802 2010-04-20  Eric Seidel  <eric@webkit.org>
2803
2804         Unreviewed, rolling out r57907.
2805         http://trac.webkit.org/changeset/57907
2806         https://bugs.webkit.org/show_bug.cgi?id=37765
2807
2808         Appears to have broken MacEWS and possibly webkit-patch upload
2809         for svn users.  Needs further investigation.
2810
2811         * Scripts/webkitpy/common/checkout/api.py:
2812         * Scripts/webkitpy/common/checkout/api_unittest.py:
2813         * Scripts/webkitpy/common/checkout/changelog.py:
2814         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2815         * Scripts/webkitpy/common/checkout/commitinfo.py:
2816         * Scripts/webkitpy/common/checkout/scm.py:
2817         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2818         * Scripts/webkitpy/common/config/committers.py:
2819         * Scripts/webkitpy/common/net/bugzilla.py:
2820         * Scripts/webkitpy/common/net/buildbot.py:
2821         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2822         * Scripts/webkitpy/common/net/statusserver.py:
2823         * Scripts/webkitpy/common/prettypatch.py:
2824         * Scripts/webkitpy/common/system/autoinstall.py:
2825         * Scripts/webkitpy/common/system/deprecated_logging.py:
2826         * Scripts/webkitpy/common/system/executive.py:
2827         * Scripts/webkitpy/common/system/executive_unittest.py:
2828         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2829         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2830         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2831         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2832         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2833         * Scripts/webkitpy/tool/commands/queues.py:
2834         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2835         * Scripts/webkitpy/tool/commands/upload.py:
2836         * Scripts/webkitpy/tool/mocktool.py:
2837         * Scripts/webkitpy/tool/steps/abstractstep.py:
2838         * Scripts/webkitpy/tool/steps/postdiff.py:
2839         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2840         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2841         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2842
2843 2010-04-20  Nate Chapin  <japhet@chromium.org>
2844
2845         Unreviewed.
2846
2847         Update my irc handle in committers.py (natechapin -> japhet).
2848
2849         * Scripts/webkitpy/common/config/committers.py:
2850
2851 2010-04-20  Eric Seidel  <eric@webkit.org>
2852
2853         Reviewed by Adam Barth.
2854
2855         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2856         https://bugs.webkit.org/show_bug.cgi?id=37765
2857
2858         I fixed the queue to not ignore Tor as a reviwer in r57531,
2859         but instead it throws an exception every time his name is in a patch.
2860
2861         This fixes our Executive.run_command code to work around a Popen
2862         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
2863         do not correctly handle unicode objects as input or output to
2864         Popen.communicate.
2865
2866         Following the advice of:
2867         http://farmdev.com/talks/unicode/
2868         I'm attempting to take the python unicode plunge and use unicode()
2869         objects as strings instead of str() objects everywhere in webkitpy.
2870
2871         We do not have to use u"" instead of "" because u"a" == "a" as expected
2872         in Python.  Python will generate a warning to the console in cases where
2873         a unicode() == str() operation cannot be performed.
2874
2875         I also cleaned up the input handling in run_command a little by adding
2876         a new _compute_input() method which can return early instead of having
2877         such a long/cluttered if-block.
2878
2879         Executive.run* now correctly accept and return unicode() objects.
2880         I attempted to fix all the places that we call .write() to make sure we
2881         encode any unicode() objects into utf-8.
2882
2883         All places which use StringIO need to be sure to pass StringIO a
2884         pre-encoded byte-array (str object) instead of unicode so that
2885         clients which read from the StringIO don't have encoding exceptions.
2886         To make this easier, I removed the patch_file_object support from
2887         add_patch_to_bug, and changed the 4 places which previously used
2888         StringIO to create a fake patch file.
2889
2890         I attempted to document any places where we are not correctly converting
2891         to/from bytes (str() objects) to strings (unicode() objects).
2892
2893         * Scripts/webkitpy/common/checkout/api_unittest.py:
2894          - Read/write utf-8 files instead of ascii.
2895          - Update the tests to use test for proper unicode() handling.
2896         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2897          - Use unicode() strings instead of str() byte arrays.
2898         * Scripts/webkitpy/common/checkout/scm.py:
2899          - Remove use of str().
2900         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2901          - Read/write utf-8 files and use unicode() strings in testing.
2902         * Scripts/webkitpy/common/config/committers.py:
2903          - Use \u instead of \x to make slightly clearer what we're doing.
2904         * Scripts/webkitpy/common/net/bugzilla.py:
2905          - Add a new _string_contents() method and explain why
2906            we have to call unicode() on the result of soup.string
2907            and why it's safe to do so w/o needing to pass a codec name.
2908          - Remove the (unused) support for passing a file object to add_patch_to_bug().
2909         * Scripts/webkitpy/common/net/buildbot.py:
2910          - Use unicode() instead of str() when needing to coax a
2911            NavigableString object into a unicode() object.
2912         * Scripts/webkitpy/common/net/statusserver.py:
2913          - Remove use of str()
2914         * Scripts/webkitpy/common/prettypatch.py:
2915          - Write out the patch file as utf-8.
2916         * Scripts/webkitpy/common/system/autoinstall.py:
2917          - Add a FIXME about encoding.
2918         * Scripts/webkitpy/common/system/deprecated_logging.py:
2919          - Document that tee() works on bytes, not strings.
2920         * Scripts/webkitpy/common/system/executive.py:
2921          - Make run* properly take and return unicode() objects.
2922         * Scripts/webkitpy/common/system/executive_unittest.py:
2923          - Added a unit test to make sure we don't break Tor again!
2924         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2925          - Write out the test list as utf-8.
2926         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2927          - Write out json files as utf-8.
2928         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2929          - Add FIXME about encoding handling.
2930         * Scripts/webkitpy/tool/commands/upload.py:
2931          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2932         * Scripts/webkitpy/tool/mocktool.py:
2933          - Rename add_patch_to_bug argument to match bugzilla.py
2934         * Scripts/webkitpy/tool/steps/postdiff.py:
2935          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2936         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
2937         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
2938         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2939          - Fixed spurious logging seen when running test-webkitpy
2940
2941 2010-04-20  Chris Jerdonek  <cjerdonek@webkit.org>
2942
2943         Reviewed by Shinichiro Hamaji.
2944
2945         For check-webkit-style, implemented __eq__() and __ne__() (the
2946         built-in equality and inequality methods) for the
2947         DefaultStyleErrorHandler class.
2948
2949         https://bugs.webkit.org/show_bug.cgi?id=37850
2950
2951         This will facilitate unit-testing for a subsequent patch,
2952         namely for https://bugs.webkit.org/show_bug.cgi?id=37850
2953
2954         * Scripts/webkitpy/style/error_handlers.py:
2955           - Added __eq__() and __ne__() to the DefaultStyleErrorHandler
2956             class.
2957
2958         * Scripts/webkitpy/style/error_handlers_unittest.py:
2959           - Added unit tests for __eq__() and __ne__().
2960           - Also included a minor clean-up refactoring of combining the
2961             StyleErrorHandlerTestBase class (which has not needed to
2962             be separate due to previous changes) into the
2963             DefaultStyleErrorHandlerTest class.
2964
2965 2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>
2966
2967         Unreviewed.
2968
2969         Add my IRC nick to the committers.py list.
2970
2971         * Scripts/webkitpy/common/config/committers.py:
2972
2973 2010-04-20  Kim Grönholm  <kim.gronholm@nomovok.com>
2974
2975         Reviewed by Simon Hausmann.
2976
2977         [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
2978         https://bugs.webkit.org/show_bug.cgi?id=37816
2979         
2980         Fix multi-touch mocking in QtLauncher when using QGraphicsView.
2981         Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955
2982
2983         * QtLauncher/main.cpp:
2984         (LauncherWindow::eventFilter):
2985         (LauncherWindow::initializeView):
2986
2987 2010-04-20  MORITA Hajime <morrita@google.com>
2988
2989         Unreviewed, add myself to the committers list.
2990
2991         * Scripts/webkitpy/common/config/committers.py:
2992
2993 2010-04-20  Kent Tamura  <tkent@chromium.org>
2994
2995         Reviewed by Shinichiro Hamaji.
2996
2997         [DRT/Chromium] Fix some unexpected results of editing
2998         https://bugs.webkit.org/show_bug.cgi?id=37843
2999
3000         This change fixes about 70 unexpected results.
3001         The original test_webview_delegate.cc doesn't have this bug.
3002         The bug was introduced when I ported it to WebKit tree.
3003
3004         * DumpRenderTree/chromium/WebViewHost.cpp:
3005         (printRangeDescription): Replace the latter startContainer() with endContainer().
3006
3007 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3008
3009         Unreviewed, build fix.
3010
3011         Turn off some unit tests for now - the new-run-webkit-tests dryrun
3012         tests for chromium won't work if you don't have a chromium checkout.
3013
3014         https://bugs.webkit.org/show_bug.cgi?id=37841
3015
3016         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3017
3018 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3019
3020         Unreviewed, build fix.
3021
3022         (Re-)add dryrun.py; this was renamed from passing.py in the previous
3023         CL but apparently somehow didn't get checked in.
3024
3025         https://bugs.webkit.org/show_bug.cgi?id=37841
3026
3027         * Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
3028
3029 2010-04-19  Shinichiro Hamaji  <hamaji@chromium.org>
3030
3031         Reviewed by David Levin.
3032
3033         check-webkit-style: exits when encountering a deleted file
3034         https://bugs.webkit.org/show_bug.cgi?id=37122
3035
3036         This reverts the quick fix done by r57119 and makes check_patch
3037         not call check_file for deleted files.
3038
3039         Also this change fixes the behavior for "-", which should mean
3040         stdin.  Before this change, the style checker just ignored "-"
3041         with a warning message.
3042
3043         * Scripts/webkitpy/style/checker.py:
3044         * Scripts/webkitpy/style/checker_unittest.py:
3045
3046 2010-04-19  Daniel Bates  <dbates@rim.com>
3047
3048         No review, rolling out 57868.
3049         http://trac.webkit.org/changeset/57868
3050         https://bugs.webkit.org/show_bug.cgi?id=37748
3051
3052         Sheriffbot wasn't very inspirational after this patch.
3053         Instead, he was silent when you said hi :-(. Rolling
3054         out this patch so that I can debug/test this some more.
3055
3056         * Scripts/webkitpy/common/net/bugzilla.py:
3057         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3058         * Scripts/webkitpy/tool/bot/irc_command.py:
3059         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3060         * Scripts/webkitpy/tool/mocktool.py:
3061
3062 2010-04-19  Daniel Bates  <dbates@rim.com>
3063
3064         Reviewed by Adam Barth.
3065
3066         https://bugs.webkit.org/show_bug.cgi?id=37748
3067
3068         Make Sheriffbot more inspirational.
3069
3070         * Scripts/webkitpy/common/net/bugzilla.py:
3071         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3072         * Scripts/webkitpy/tool/bot/irc_command.py:
3073         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3074         * Scripts/webkitpy/tool/mocktool.py:
3075
3076 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
3077
3078         [wx] Build fix, add missing header.
3079
3080         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3081
3082 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3083  
3084          Reviewed by Adam Barth.
3085  
3086          new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
3087          that can be used to test platforms other than the one you are running
3088          on. This can be useful for checking baselines and testing code
3089          coverage.
3090  
3091          Note that running the code on the "wrong" port requires each
3092          port-specific implementation to actually not require any
3093          platform-specific python code (e.g., the chromium-win port must
3094          test for the existence of windows functions before calling them).
3095  
3096          https://bugs.webkit.org/show_bug.cgi?id=37782
3097  
3098          * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3099          * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
3100          * Scripts/webkitpy/layout_tests/port/factory.py:
3101          * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3102
3103 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3104
3105         Reviewed by Eric Seidel.
3106
3107         new-run-webkit-tests: add --build (default) and --no-build
3108         options to make that step optional. This flag modifies what happens
3109         in port.check_build().
3110
3111         https://bugs.webkit.org/show_bug.cgi?id=37786
3112
3113         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3114         * Scripts/webkitpy/layout_tests/port/chromium.py:
3115         * Scripts/webkitpy/layout_tests/port/webkit.py:
3116
3117 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3118
3119         Unreviewed, build fix.
3120
3121         new-run-webkit-tests - fix a typo in r57480 that caused us to stop
3122         logging the actual list of unexpected results.
3123
3124         https://bugs.webkit.org/show_bug.cgi?id=37831
3125
3126         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3127
3128 2010-04-19  Dirk Pranke <dpranke@chromium.org>
3129
3130         Reviewed by Adam Barth.
3131
3132         From a patch by Tor Arne Vestbo  <tor.arne.vestbo@nokia.com>
3133
3134         new-run-webkit-tests: make the retry step more explicit
3135         https://bugs.webkit.org/show_bug.cgi?id=37606
3136
3137         It might be confusing to see the test and percent counters
3138         reset without any notice of what's going on, so we make the
3139         message that a retry-run is started explicit.
3140
3141         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3142
3143 2010-04-19  Sam Weinig  <weinig@apple.com>
3144
3145         Reviewed by Anders Carlsson.
3146
3147         Add support for opening a new window (File->New Window) to
3148         Windows MiniBrowser. Accelerator doesn't work.
3149
3150         * MiniBrowser/win/BrowserView.cpp:
3151         (createNewPage): Use BrowserView::create.
3152         * MiniBrowser/win/BrowserWindow.cpp:
3153         (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
3154         by creating a new window.
3155         * MiniBrowser/win/BrowserWindow.h:
3156         (BrowserWindow::create): Added. Don't allow creating
3157         BrowserWindows on the stack by making constructor
3158         private and exposing the create function.
3159         * MiniBrowser/win/MiniBrowser.cpp:
3160         (MiniBrowser::createNewWindow): Move new window creation
3161         logic here.
3162         * MiniBrowser/win/MiniBrowser.h:
3163         * MiniBrowser/win/MiniBrowser.rc: 
3164         * MiniBrowser/win/main.cpp:
3165         (_tWinMain): Use the new MiniBrowser::createNewWindow().
3166
3167 2010-04-19  Chris Fleizach  <cfleizach@apple.com>
3168
3169         Reviewed by Beth Dakin.
3170
3171         AX: aria-haspopup needs to be exposed
3172         https://bugs.webkit.org/show_bug.cgi?id=37808
3173
3174         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3175         (AccessibilityUIElement::hasPopup):
3176
3177 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3178
3179         Reviewed by Eric Seidel.
3180
3181         Submit a better workaround for r57806 than the one in r57831 - log
3182         an error and exit if you try to run new-run-webkit-tests with --use-drt
3183         on Windows.
3184
3185         https://bugs.webkit.org/show_bug.cgi?id=37822
3186
3187         * Scripts/webkitpy/layout_tests/port/chromium.py:
3188
3189 2010-04-19  Jesus Sanchez-Palencia  <jesus@webkit.org>
3190
3191         Unreviewed.
3192
3193         Just adding myself as a committer.
3194
3195         * Scripts/webkitpy/common/config/committers.py:
3196
3197 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3198
3199         Reviewed by Eric Seidel.
3200
3201         Add slightly better logging to the websocket python wrapper script,
3202         including a --verbose flag for debug output.
3203
3204         https://bugs.webkit.org/show_bug.cgi?id=37233
3205
3206         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3207         * Scripts/new-run-webkit-websocketserver:
3208
3209 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3210
3211         Reviewed by Eric Seidel.
3212
3213         new-run-webkit-tests: add a way (--print-unexpected-results) to
3214         (re-)print out the tests that produced unexpected results in the
3215         last run. Also add a way (--retry-unexpected-results) to
3216         automatically re-test them.
3217
3218         https://bugs.webkit.org/show_bug.cgi?id=37783
3219
3220         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3221
3222 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3223
3224         Reviewed by Eric Seidel.
3225
3226         Restructure the logging in new-run-webkit-tests so that many of log
3227         messages that were logged to the MeteredStream also get logged in
3228         --verbose mode.
3229
3230         https://bugs.webkit.org/show_bug.cgi?id=37780
3231
3232         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
3233         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3234
3235 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3236
3237         Reviewed by Eric Seidel.
3238
3239         new-run-webkit-tests: add 'summary' and 'unexpected-results' options
3240         to the --log flag. Also add a 'progress' flag to enable the regular
3241         progress bar (as opposed to 'detailed-progress', which enables the
3242         dots). Also add a 'nothing' flag to allow you to be explicit that
3243         you don't want any logging on the command line.
3244
3245         The default is
3246         '--log detailed-progress,summary,unexpected,unexpected-results'
3247
3248         (The default logging is unchanged by this patch, this just makes things
3249         properly configurable).
3250
3251         Note that 'nothing' doesn't work properly yet; I need a couple other
3252         patches to land to avoid rewriting things several different ways.
3253
3254         https://bugs.webkit.org/show_bug.cgi?id=37785
3255
3256         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3257
3258 2010-04-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3259
3260         Reviewed by Simon Hausmann.
3261
3262         Make the URL change on committed load.
3263
3264         * QtLauncher/mainwindow.cpp:
3265         (MainWindow::buildUI):
3266         (MainWindow::setAddressUrl):
3267         * QtLauncher/mainwindow.h:
3268
3269 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3270
3271         Reviewed by Eric Seidel.
3272
3273         Fix a typo in the rebaselining tool that causes us to use "debug"
3274         instead of "Debug" in a directory path, which fails on platforms with
3275         case-sensitive filesystems.
3276
3277         https://bugs.webkit.org/show_bug.cgi?id=37819
3278
3279         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3280
3281 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
3282
3283         Unreviewed, build fix.
3284
3285         Fix breakage of chromium-win canary bots caused by r57806. That patch
3286         introduced the option of using Chrome's new port of DumpRenderTree,
3287         but unfortunately that port relies on the webkit.py class
3288         implementation which uses non-blocking I/O that isn't available on
3289         Windows. This patch turns off that option and doesn't import the
3290         class if we're running on Windows.
3291
3292         https://bugs.webkit.org/show_bug.cgi?id=37817
3293
3294         * Scripts/webkitpy/layout_tests/port/chromium.py:
3295
3296 2010-04-19  James Robinson  <jamesr@chromium.org>
3297
3298         Reviewed by abarth.
3299
3300         Fix a typo
3301
3302         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3303
3304 2010-04-19  Adam Roben  <aroben@apple.com>
3305
3306         Fix run-webkit-tests when there are spaces in the path
3307
3308         Fixes <http://webkit.org/b/37809>
3309
3310         Reviewed by Adam Barth.
3311
3312         * Scripts/run-webkit-tests: Use an "indirect object" to specify the
3313         path to the harness to exec(). According to perldoc, this usage will
3314         prohibit perl from parsing the arguments to exec() via the shell,
3315         which would incorrectly split paths with spaces in them, etc.
3316
3317 2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>
3318
3319         Reviewed by Adam Roben.
3320
3321         WinLauncher.h should use LF line-endings and use native line-endings style.
3322         https://bugs.webkit.org/show_bug.cgi?id=37807
3323
3324         * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
3325
3326 2010-04-19  Kent Tamura  <tkent@chromium.org>
3327
3328         Reviewed by Shinichiro Hamaji.
3329
3330         [DRT/Chromium] Fix a test initialization problem
3331         https://bugs.webkit.org/show_bug.cgi?id=37791
3332
3333         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3334         (runTest): Call resetTestController() before runFileTest(). Some
3335           controllers initialize their fields in reset() and not in their
3336           constructors.
3337
3338 2010-04-19  Kent Tamura  <tkent@chromium.org>
3339
3340         Reviewed by Eric Seidel.
3341
3342         [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
3343         https://bugs.webkit.org/show_bug.cgi?id=37793
3344
3345         We need to use WebKitDriver instead of ChromiumDriver for Chromium
3346         DRT because its interface is different from test_shell.
3347
3348         Chromium DRT has no UI.  So we can't use it to show test results.
3349
3350         * Scripts/webkitpy/layout_tests/port/chromium.py:
3351
3352 2010-04-18  Eric Seidel  <eric@webkit.org>
3353
3354         Reviewed by Adam Roben.
3355
3356         Make failure-reason more forgiving
3357         https://bugs.webkit.org/show_bug.cgi?id=37525
3358
3359         Removed search_limit, which wasn't very useful anyway.
3360         Added a log about the long load time loading from the builders.
3361         Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
3362
3363         * Scripts/webkitpy/common/net/buildbot.py:
3364         * Scripts/webkitpy/tool/commands/queries.py:
3365
3366 2010-04-18  Chris Jerdonek  <cjerdonek@webkit.org>
3367
3368         Reviewed by Shinichiro Hamaji.
3369
3370         Created a class for check-webkit-style that encapsulates iterating
3371         over text files and reading them.
3372
3373         https://bugs.webkit.org/show_bug.cgi?id=37754
3374
3375         This revision is an intermediate step towards separating our
3376         style-checking code from the logic of iterating over files and
3377         reading them.
3378
3379         * Scripts/webkitpy/common/system/logtesting.py:
3380           - Added a logMessages() method to the LoggingTestCase class.
3381             This method provides unit tests with access to the raw list
3382             of log messages in case the tester needs to do something more
3383             than simply assert the list of existing messages.
3384
3385         * Scripts/webkitpy/style/checker.py:
3386           - Added a ProcessorBase class that processors of lists of lines
3387             should eventually inherit from.
3388           - Also added a FIXME to use the ProcessorBase class and the
3389             TextFileReader class added below.
3390
3391         * Scripts/webkitpy/style/filereader.py: Added.
3392           - Created a TextFileReader class that encapsulates reading
3393             and iterating over text files.
3394
3395         * Scripts/webkitpy/style/filereader_unittest.py: Added.
3396           - Added a TextFileReaderTest class to unit-test the
3397             new TextFileReader class.
3398
3399 2010-04-15  Tony Chang  <tony@chromium.org>
3400
3401         Reviewed by Adam Barth.
3402
3403         [chromium] new-run-webkit-tests should be able to use chromium DRT
3404         https://bugs.webkit.org/show_bug.cgi?id=37645
3405
3406         Make sure that the lack of a chromium checkout doesn't cause the script to
3407         fail.
3408
3409         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3410         * Scripts/webkitpy/layout_tests/port/chromium.py:
3411         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
3412             to be relative to an upstream output dir.
3413         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
3414
3415 2010-04-18  Eric Seidel  <eric@webkit.org>
3416
3417         Unreviewed, fixing the Qt bot.
3418
3419         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
3420         https://bugs.webkit.org/show_bug.cgi?id=37632
3421
3422         * Scripts/run-webkit-tests:
3423          - Exit non-zero of launching the harness fails.
3424
3425 2010-04-18  Eric Seidel  <eric@webkit.org>
3426
3427         Unreviewed, fixing the Qt bot.
3428
3429         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
3430         https://bugs.webkit.org/show_bug.cgi?id=37632
3431
3432         * Scripts/run-webkit-tests:
3433          - Fix the wrapper to work for users who do not
3434            have WebKitTools/Scripts in their path.
3435
3436 2010-04-14  Eric Seidel  <eric@webkit.org>
3437
3438         Reviewed by Adam Barth.
3439
3440         Add a layer of indirection when calling run-webkit-tests to
3441         allow testing new-run-webkit-tests on various platforms.
3442         https://bugs.webkit.org/show_bug.cgi?id=37632
3443
3444         This will let us test and fix bugs in new-run-webkit-tests
3445         without needing to restart the buildbot master between tests.
3446
3447         Currently this change leaves run-webkit-tests as-is, but once
3448         its landed we will easily be able to turn on/off
3449         new-run-webkit-tests for various ports/configurations.
3450
3451         I will send a note out to webkit-dev about how we will
3452         be using this launcher script to test on the bots.
3453
3454         * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
3455         * Scripts/run-webkit-tests:
3456          - A new script which decides whether to run new- or old-
3457            run-webkit-tests based on the platform.
3458         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3459          - Add some dummy argument handling for arguments which
3460            old-run-webkit-tests supports but new-run-webkit-tests
3461            does not yet.
3462
3463 2010-04-18  Eric Seidel  <eric@webkit.org>
3464
3465         Reviewed by Adam Barth.
3466
3467         Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
3468         https://bugs.webkit.org/show_bug.cgi?id=33295
3469
3470         The Gtk builders have been green every time I've looked
3471         at them in the last 5 days or so.  It would appear webkit
3472         is now keeping them green and we should update the core
3473         builder list to match reality.
3474
3475         * Scripts/webkitpy/common/net/buildbot.py:
3476         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3477
3478 2010-04-18  Robert Hogan  <robert@webkit.org>
3479
3480         Reviewed by Simon Hausmann.
3481
3482         [Qt] Add support for LayoutTestController commands:
3483                    setSmartInsertDeleteEnabled
3484                    setSelectTrailingWhitespaceEnabled
3485                    execCommand
3486                    isCommandEnabled
3487
3488         https://bugs.webkit.org/show_bug.cgi?id=35844
3489
3490         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3491         (WebCore::WebPage::resetSettings):
3492         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3493         (LayoutTestController::setSmartInsertDeleteEnabled):
3494         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
3495         (LayoutTestController::execCommand):
3496         (LayoutTestController::isCommandEnabled):
3497         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3498
3499 2010-04-17  Adam Barth  <abarth@webkit.org>
3500
3501         Reviewed by Eric Seidel.
3502
3503         Remove steps_references and commands_references
3504         https://bugs.webkit.org/show_bug.cgi?id=37758
3505
3506         We tried using the mumble_references convention to manage our
3507         dependencies, but it doesn't seem to be providing much value for the
3508         steps and commands module because these modules are small pieces of the
3509         larger tool module.  In this patch, I've removed the references file
3510         for these modules.
3511  
3512         I've left the style_references file for the style module because that
3513         module seems better isolated from the rest of webkitpy and the
3514         style_references file appears to be providing some value.
3515
3516         * Scripts/webkitpy/tool/commands/commandtest.py:
3517         * Scripts/webkitpy/tool/commands/download_unittest.py:
3518         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3519         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3520         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3521         * Scripts/webkitpy/tool/commands/queuestest.py:
3522         * Scripts/webkitpy/tool/commands/upload.py:
3523         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3524         * Scripts/webkitpy/tool/commands_references.py: Removed.
3525         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3526         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3527         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3528         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
3529         * Scripts/webkitpy/tool/steps_references.py: Removed.
3530
3531 2010-04-17  Eric Seidel  <eric@webkit.org>
3532
3533         Reviewed by Adam Barth.
3534
3535         WebKit needs a Chromium Mac EWS Builder
3536         https://bugs.webkit.org/show_bug.cgi?id=37742
3537
3538         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3539
3540 2010-04-17  Adam Barth  <abarth@webkit.org>
3541
3542         Fix expected results for unit test broken by
3543         http://trac.webkit.org/changeset/57772
3544
3545         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3546
3547 2010-04-17  Sam Weinig  <weinig@apple.com>
3548
3549         Reviewed by Adam Roben.
3550
3551         Teach windows MiniBrowser how to work with window.open()
3552         and targeted links.
3553
3554         * MiniBrowser/win/BrowserView.cpp:
3555         (createNewPage): Create a new BrowserWindow and return its page.
3556         (showPage): Show the page.
3557         (closePage): Empty implementation.
3558         (runJavaScriptAlert): Empty implementation.
3559         (BrowserView::create): Register a UIClient.
3560         * MiniBrowser/win/BrowserView.h:
3561         (BrowserView::webView): Added.
3562         Change create to take a BrowserWindow instead of an HWND.
3563
3564         * MiniBrowser/win/BrowserWindow.cpp:
3565         (BrowserWindow::wndProc): Respond to WM_NCDESTROY.
3566         (BrowserWindow::goToURL): Added. Forwards to BrowserView.
3567         (BrowserWindow::onCreate): Don't always go to the default
3568         url. Let the caller do this.
3569         (BrowserWindow::onNCDestroy): Delete the window.
3570         * MiniBrowser/win/BrowserWindow.h:
3571         (BrowserWindow::view): Added.
3572         (BrowserWindow::window): Added.
3573
3574         * MiniBrowser/win/main.cpp:
3575         (_tWinMain):
3576         Go to the default URL for the initial page. Allocate the initial
3577         window on the heap for correctness.
3578
3579 2010-04-16  Adam Roben  <aroben@apple.com>
3580
3581         Add the Windows Debug (Test) builder to the list of core builders
3582
3583         It's been green for a few days now, and all the known Windows
3584         flakiness is Release-only.
3585
3586         Rubber-stamped by Mark Rowe.
3587
3588         * Scripts/webkitpy/common/net/buildbot.py:
3589         (BuildBot.core_builder_name_regexps): Added a regular expression to
3590         match the "Windows Debug (Test)" builder.
3591