2010-09-11 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Anders Carlsson.
4
5         Attempt to fix Windows MiniBrowser build (untested)
6         https://bugs.webkit.org/show_bug.cgi?id=45609
7
8         * MiniBrowser/win/BrowserView.cpp:
9         (runJavaScriptConfirm):
10         (runJavaScriptPrompt):
11
12 2010-09-11  Sam Weinig  <sam@webkit.org>
13
14         Reviewed by Maciej Stachowiak.
15
16         Fix zoom related tests when testing WebKit2.
17
18         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
19         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
20
21 2010-09-11  Sam Weinig  <sam@webkit.org>
22
23         Reviewed by Dan Bernstein.
24
25         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
26         <rdar://problem/8359252>
27         https://bugs.webkit.org/show_bug.cgi?id=45605
28
29         * MiniBrowser/mac/BrowserWindowController.m:
30         (setStatusText):
31         (contentsSizeChanged):
32         (-[BrowserWindowController awakeFromNib]):
33         * MiniBrowser/win/BrowserView.cpp:
34         (runJavaScriptConfirm):
35         (runJavaScriptPrompt):
36         (setStatusText):
37         (contentsSizeChanged):
38         (BrowserView::create):
39         * WebKitTestRunner/TestController.cpp:
40         (WTR::createOtherPage):
41         (WTR::TestController::initialize):
42
43 2010-09-11  Sam Weinig  <sam@webkit.org>
44
45         Reviewed by Dan Bernstein.
46
47         Add callback mechanism for the getting the source of a frame
48         <rdar://problem/8364681>
49         https://bugs.webkit.org/show_bug.cgi?id=45604
50
51         Add ability to dump the main frame's source to the console.
52
53         * MiniBrowser/mac/BrowserWindowController.h:
54         * MiniBrowser/mac/BrowserWindowController.m:
55         (-[BrowserWindowController dumpSourceToConsole:]):
56         * MiniBrowser/mac/MainMenu.xib:
57
58 2010-09-11  Eric Seidel  <eric@webkit.org>
59
60         Reviewed by Adam Barth.
61
62         Remove unneeded Empty Queue messages
63         https://bugs.webkit.org/show_bug.cgi?id=45602
64
65         We already have a /gc job to delete these.
66         recentstatus.py is already smart enough to use the
67         most recent of the workitems last update or the most recent status,
68         so removing these should not change the _last_status_date() return
69         value more than a few milliseconds.
70
71         These messages just spam the recent status log.
72
73         * Scripts/webkitpy/tool/commands/queues.py:
74
75 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
76
77         Reviewed by Adam Barth.
78
79         Fix Python exception when generating synthetic patch IDs
80         https://bugs.webkit.org/show_bug.cgi?id=45592
81
82         Can't concatenate strings and numbers directly.
83
84         * QueueStatusServer/handlers/queuestatus.py:
85
86 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
87
88         Reviewed by Adam Barth.
89
90         Group statuses in queue status by patch ID
91         https://bugs.webkit.org/show_bug.cgi?id=45588
92
93         Group statuses by patch ID so that the status page is easier
94         to scan.
95
96         * QueueStatusServer/handlers/queuestatus.py:
97         * QueueStatusServer/stylesheets/dashboard.css:
98         (.status-group):
99         (.status-bug):
100         (.status-group ul):
101         (.status-group ul li):
102         (.status-group ul li:hover):
103         (.status-cell):
104         (.status-cell:hover):
105         (.status-cell.pass):
106         (.status-cell.fail):
107         (.status-cell.pending):
108         (.status-cell.error):
109         * QueueStatusServer/templates/dashboard.html:
110         * QueueStatusServer/templates/queuestatus.html:
111
112 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
113
114         Reviewed by Tony Chang.
115
116         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
117         https://bugs.webkit.org/show_bug.cgi?id=45479
118
119         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
120         implementation in ResourceLoadDelegate in the Mac port).
121
122         * DumpRenderTree/chromium/LayoutTestController.cpp:
123         (LayoutTestController::LayoutTestController):
124         (LayoutTestController::dumpResourceResponseMIMETypes):
125         (LayoutTestController::reset):
126         * DumpRenderTree/chromium/LayoutTestController.h:
127         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
128         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
129         * DumpRenderTree/chromium/TestShell.h:
130         (TestShell::shouldDumpResourceResponseMIMETypes):
131         * DumpRenderTree/chromium/WebViewHost.cpp:
132         (WebViewHost::didReceiveResponse):
133
134 2010-09-11  Eric Seidel  <eric@webkit.org>
135
136         Reviewed by Adam Barth.
137
138         queues.webkit.org should expose /remote_api for data upload/download
139         https://bugs.webkit.org/show_bug.cgi?id=45559
140
141         * QueueStatusServer/app.yaml:
142          - /remote_api is a standard app-engine service which allows use of
143            the bulk uploader for data upload/download.  Exposing this
144            (for admin access only) allows us to use 
145
146 2010-09-10  Sam Weinig  <sam@webkit.org>
147
148         Reviewed by Dan Bernstein.
149
150         Add zoom support to WebKit2 API
151         <rdar://problem/7660657>
152         https://bugs.webkit.org/show_bug.cgi?id=45585
153
154         - Add zoom options to MiniBrowser that mimic Safari's options using
155           the new WebKit2 zoom APIs.
156         - Switch uses of float for the zoom APIs to use double.
157
158         * MiniBrowser/mac/BrowserWindowController.h:
159         * MiniBrowser/mac/BrowserWindowController.m:
160         (-[BrowserWindowController initWithPageNamespace:]):
161         (-[BrowserWindowController validateMenuItem:]):
162         (-[BrowserWindowController validateUserInterfaceItem:]):
163         (-[BrowserWindowController currentZoomFactor]):
164         (-[BrowserWindowController setCurrentZoomFactor:]):
165         (-[BrowserWindowController canZoomIn]):
166         (-[BrowserWindowController zoomIn:]):
167         (-[BrowserWindowController canZoomOut]):
168         (-[BrowserWindowController zoomOut:]):
169         (-[BrowserWindowController canResetZoom]):
170         (-[BrowserWindowController resetZoom:]):
171         (-[BrowserWindowController toggleZoomMode:]):
172         * MiniBrowser/mac/MainMenu.xib:
173         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
174         (WTR::EventSendingController::textZoomIn):
175         (WTR::EventSendingController::textZoomOut):
176         (WTR::EventSendingController::zoomPageIn):
177         (WTR::EventSendingController::zoomPageOut):
178
179 2010-09-10  Robert Hogan  <robert@webkit.org>
180
181         Reviewed by Andreas Kling.
182
183         [Qt] Fix crash in DRT in standalone mode
184
185         https://bugs.webkit.org/show_bug.cgi?id=45454
186
187         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
188         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
189
190 2010-09-10  Sam Weinig  <sam@webkit.org>
191
192         Reviewed by Darin Adler.
193
194         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
195         Precursor to <rdar://problem/7660657>
196         https://bugs.webkit.org/show_bug.cgi?id=45522
197
198         Update for changes to the Bundle API to allow separate control of page and text zoom
199         levels.
200
201         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
202         (WTR::EventSendingController::textZoomIn):
203         (WTR::EventSendingController::textZoomOut):
204         (WTR::EventSendingController::zoomPageIn):
205         (WTR::EventSendingController::zoomPageOut):
206         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
207         (WTR::InjectedBundlePage::reset):
208
209 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
210
211         Reviewed by Andreas Kling.
212
213         [Qt] Support click event for notifications
214         https://bugs.webkit.org/show_bug.cgi?id=44836
215
216         Add support for simulateDesktopNotificationClick by calling
217         back to DumpRenderTreeSupportQt.cpp.
218
219         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
220         (LayoutTestController::simulateDesktopNotificationClick):
221         * DumpRenderTree/qt/LayoutTestControllerQt.h:
222
223 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
224
225         Reviewed by Eric Seidel.
226
227         Update queue status when patches fail their first land attempt
228         https://bugs.webkit.org/show_bug.cgi?id=45583
229
230         Add a few more _update_status calls to make it more obvious if a patch is 
231         being retried because tests failed.
232
233         * Scripts/webkitpy/tool/commands/queues.py:
234
235 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
236
237         Reviewed by Andreas Kling.
238
239         [Qt] MiniBrowser crashes with multiply windows when closing one of them
240         https://bugs.webkit.org/show_bug.cgi?id=45536
241
242         * MiniBrowser/qt/BrowserView.cpp:
243         (BrowserView::BrowserView): Reference the context instead of adopting it
244         because it can be shared across different views.
245
246 2010-09-10  Tony Chang  <tony@chromium.org>
247
248         Unreviewed, rolling out r67241.
249         http://trac.webkit.org/changeset/67241
250         https://bugs.webkit.org/show_bug.cgi?id=44709
251
252         Accidentally committed.
253
254         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
255         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
256
257 2010-09-10  Tony Chang  <tony@chromium.org>
258
259         Reviewed by Ojan Vafai.
260
261         deduplicate-tests should be runnable from any WebKit directory
262         https://bugs.webkit.org/show_bug.cgi?id=44709
263
264         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
265         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
266
267 2010-09-10  Tony Chang  <tony@chromium.org>
268
269         Unreviewed, rolling out r67216.
270         http://trac.webkit.org/changeset/67216
271         https://bugs.webkit.org/show_bug.cgi?id=44709
272
273         Broke
274
275         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
276         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
277
278 2010-09-10  Tony Chang  <tony@chromium.org>
279
280         Reviewed by Ojan Vafai.
281
282         deduplicate-tests should be runnable from any WebKit directory
283         https://bugs.webkit.org/show_bug.cgi?id=44709
284
285         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
286         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
287
288 2010-09-09  Hans Wennborg  <hans@chromium.org>
289
290         Reviewed by Jeremy Orlow.
291
292         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
293         https://bugs.webkit.org/show_bug.cgi?id=45460
294
295         This enables DumpRenderTree to run layout tests for DeviceOrientation.
296
297         Also declare the LayoutTestController destructor out-of-line.
298         Otherwise the implicit destructor would cause compiler errors because
299         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
300
301         * DumpRenderTree/chromium/LayoutTestController.cpp:
302         (LayoutTestController::~LayoutTestController):
303         (LayoutTestController::setMockDeviceOrientation):
304         (LayoutTestController::deviceOrientationClient):
305         * DumpRenderTree/chromium/LayoutTestController.h:
306         * DumpRenderTree/chromium/WebViewHost.cpp:
307         (WebViewHost::deviceOrientationClient):
308         * DumpRenderTree/chromium/WebViewHost.h:
309
310 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
311
312         Unreviewed, rolling out r67119.
313         http://trac.webkit.org/changeset/67119
314         https://bugs.webkit.org/show_bug.cgi?id=45505
315
316         Extra newlines in results (Requested by tony^work on #webkit).
317
318         * DumpRenderTree/chromium/LayoutTestController.cpp:
319         (LayoutTestController::LayoutTestController):
320         (LayoutTestController::reset):
321         * DumpRenderTree/chromium/LayoutTestController.h:
322         * DumpRenderTree/chromium/TestShell.h:
323         * DumpRenderTree/chromium/WebViewHost.cpp:
324         (printResponseDescription):
325         (printNodeDescription):
326         (printRangeDescription):
327         (WebViewHost::shouldBeginEditing):
328         (WebViewHost::shouldEndEditing):
329         (WebViewHost::shouldInsertNode):
330         (WebViewHost::shouldChangeSelectedRange):
331         (WebViewHost::shouldDeleteRange):
332         (WebViewHost::shouldApplyStyle):
333         (WebViewHost::didBeginEditing):
334         (WebViewHost::didChangeSelection):
335         (WebViewHost::didChangeContents):
336         (WebViewHost::didEndEditing):
337         (WebViewHost::decidePolicyForNavigation):
338         (WebViewHost::didCancelClientRedirect):
339         (WebViewHost::didStartProvisionalLoad):
340         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
341         (WebViewHost::didFailProvisionalLoad):
342         (WebViewHost::didCommitProvisionalLoad):
343         (WebViewHost::didFinishDocumentLoad):
344         (WebViewHost::didHandleOnloadEvents):
345         (WebViewHost::didFailLoad):
346         (WebViewHost::didFinishLoad):
347         (WebViewHost::didChangeLocationWithinPage):
348         (WebViewHost::willSendRequest):
349         (WebViewHost::didReceiveResponse):
350         (WebViewHost::didFinishResourceLoad):
351         (WebViewHost::didFailResourceLoad):
352         (WebViewHost::didDisplayInsecureContent):
353         (WebViewHost::didRunInsecureContent):
354         (WebViewHost::printFrameDescription):
355
356 2010-09-09  Michael Saboff  <msaboff@apple.com>
357
358         Unreviewed, adding myself to committers list.
359
360         * Scripts/webkitpy/common/config/committers.py:
361
362 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
363
364         Reviewed by Tony Chang.
365
366         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
367         https://bugs.webkit.org/show_bug.cgi?id=45479
368
369         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
370         implementation in ResourceLoadDelegate in the Mac port).
371
372         * DumpRenderTree/chromium/LayoutTestController.cpp:
373         (LayoutTestController::LayoutTestController):
374         (LayoutTestController::dumpResourceResponseMIMETypes):
375         (LayoutTestController::reset):
376         * DumpRenderTree/chromium/LayoutTestController.h:
377         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
378         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
379         * DumpRenderTree/chromium/TestShell.h:
380         (TestShell::shouldDumpResourceResponseMIMETypes):
381         * DumpRenderTree/chromium/WebViewHost.cpp:
382         (WebViewHost::didReceiveResponse):
383
384 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
385
386         Reviewed by Daniel Bates.
387
388         svn-apply tries to delete directories it shouldn't
389         https://bugs.webkit.org/show_bug.cgi?id=45424
390
391         isDirectoryEmptyForRemoval had the wrong check. If an item in the
392         directory is itself a directory, then the directory is definitely
393         not empty.
394
395         * Scripts/svn-apply:
396
397 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
398
399         Fixing GTK and windows build failure.
400
401         AX: Support AccessibilityTextMarkers in DRT
402         https://bugs.webkit.org/show_bug.cgi?id=44778
403
404         * DumpRenderTree/AccessibilityTextMarker.h:
405         (AccessibilityTextMarker::platformTextMarker):
406         (AccessibilityTextMarkerRange::platformTextMarkerRange):
407         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
408         (AccessibilityTextMarker::platformTextMarker):
409         (AccessibilityTextMarkerRange::platformTextMarkerRange):
410
411 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
412
413         Reviewed by David Kilzer.
414
415         AX: Support AccessibilityTextMarkers in DRT
416         https://bugs.webkit.org/show_bug.cgi?id=44778
417
418         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
419         that WebCore uses when vending information about its VisiblePositions through AX.
420
421         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
422         methods for encapsulating and checking equality.
423
424         This will allow future bug fixes in the text marker system to be adequately tested.
425
426         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
427         (toTextMarker):
428         (isMarkerEqualCallback):
429         (markerFinalize):
430         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
431         (AccessibilityTextMarker::getJSClass):
432         (toTextMarkerRange):
433         (isMarkerRangeEqualCallback):
434         (markerRangeFinalize):
435         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
436         (AccessibilityTextMarkerRange::getJSClass):
437         * DumpRenderTree/AccessibilityTextMarker.h: Added.
438         (AccessibilityTextMarker::platformTextMarker):
439         (AccessibilityTextMarkerRange::platformTextMarkerRange):
440         (AccessibilityTextMarker::AccessibilityTextMarker):
441         (AccessibilityTextMarker::~AccessibilityTextMarker):
442         (AccessibilityTextMarker::isEqual):
443         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
444         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
445         (AccessibilityTextMarkerRange::isEqual):
446         * DumpRenderTree/AccessibilityUIElement.cpp:
447         (textMarkerRangeForElementCallback):
448         (textMarkerRangeLengthCallback):
449         (textMarkerRangeForMarkersCallback):
450         (startTextMarkerForTextMarkerRangeCallback):
451         (endTextMarkerForTextMarkerRangeCallback):
452         (accessibilityElementForTextMarkerCallback):
453         (AccessibilityUIElement::textMarkerRangeForElement):
454         (AccessibilityUIElement::textMarkerRangeLength):
455         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
456         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
457         (AccessibilityUIElement::accessibilityElementForTextMarker):
458         (AccessibilityUIElement::getJSClass):
459         * DumpRenderTree/AccessibilityUIElement.h:
460         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
461         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
462         (AccessibilityTextMarker::AccessibilityTextMarker):
463         (AccessibilityTextMarker::~AccessibilityTextMarker):
464         (AccessibilityTextMarker::isEqual):
465         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
466         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
467         (AccessibilityTextMarkerRange::isEqual):
468         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
469         (AccessibilityUIElement::textMarkerRangeForElement):
470         (AccessibilityUIElement::textMarkerRangeLength):
471         (AccessibilityUIElement::textMarkerRangeForMarkers):
472         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
473         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
474         (AccessibilityUIElement::accessibilityElementForTextMarker):
475         * DumpRenderTree/win/DumpRenderTree.vcproj:
476
477 2010-08-25  Tony Chang  <tony@chromium.org>
478
479         Reviewed by Ojan Vafai.
480
481         don't delete duplicates needed because of intermediate results
482         https://bugs.webkit.org/show_bug.cgi?id=44653
483
484         Also, output the full path so we can pipe the output to rm.
485
486         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
487         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
488
489 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
490
491         Reviewed by Andreas Kling.
492
493         [Qt] MiniBrowser does not starts properly
494         https://bugs.webkit.org/show_bug.cgi?id=45459
495
496         Do not try set up the first window by calling newWindow on a
497         newly created BrowserWindow since it creates a new object.
498         * MiniBrowser/qt/BrowserWindow.cpp:
499         (BrowserWindow::BrowserWindow):
500         * MiniBrowser/qt/main.cpp:
501         (main):
502
503 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
504
505         Reviewed by Xan Lopez.
506
507         [GTK] Get ImageDiff building on Win32
508         https://bugs.webkit.org/show_bug.cgi?id=45353
509
510         * DumpRenderTree/gtk/ImageDiff.cpp:
511         (main): Switch from using strtok to g_strsplit.
512
513 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
514
515         Reviewed by Andreas Kling.
516
517         [Qt] Modify load method of MiniBrowser's BrowserView class
518         https://bugs.webkit.org/show_bug.cgi?id=45442
519
520         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
521
522         * MiniBrowser/qt/BrowserView.cpp:
523         (BrowserView::load):
524         * MiniBrowser/qt/BrowserView.h:
525         * MiniBrowser/qt/BrowserWindow.cpp:
526         (BrowserWindow::load):
527
528 2010-09-09  Tony Chang  <tony@chromium.org>
529
530         Reviewed by Ojan Vafai.
531
532         fix show_results in new-run-webkit-tests
533         https://bugs.webkit.org/show_bug.cgi?id=45413
534
535         * Scripts/webkitpy/layout_tests/port/chromium.py:
536
537 2010-09-08  Victor Wang  <victorw@chromium.org>
538
539         Reviewed by Ojan Vafai.
540
541         [Chromium] Fix test results server to make sure
542         it does not have corrupted data.
543
544         results.json file size coulbe be >1M and we split
545         the data into multiple data store entries in this
546         case. This patch fixes the issue that the data may
547         be corrupted if data store error happens in the middle
548         of saving multiple entries.
549
550         https://bugs.webkit.org/show_bug.cgi?id=45063
551
552         * TestResultServer/model/datastorefile.py:
553
554 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
555
556         Reviewed by Kenneth Rohde Christiansen.
557
558         Fix ignoring return value warning in case of gcc 4.4.4
559         https://bugs.webkit.org/show_bug.cgi?id=45384
560
561         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
562         (testPostURLFile):
563         If fwrite have written zero byte then the testPostURLFile function
564         returns with false as tempFile can't be opened.
565         * DumpRenderTree/qt/ImageDiff.cpp:
566         (main):
567         Put fwrite function into an if condition without body to avoid
568         warning. It is safe because this function writes to the stdout.
569
570 2010-09-08  Satish Sampath  <satish@chromium.org>
571
572         Unreviewed, adding myself to committers list.
573
574         * Scripts/webkitpy/common/config/committers.py:
575
576 2010-09-08  Hans Wennborg  <hans@chromium.org>
577
578         Unreviewed.
579
580         Adding myself as a committer in committers.py.
581
582         * Scripts/webkitpy/common/config/committers.py:
583
584 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
585
586         Reviewed by Simon Hausmann.
587
588         [Qt] Refactor MiniBrowser 
589         https://bugs.webkit.org/show_bug.cgi?id=45173
590
591         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
592
593         * MiniBrowser/qt/BrowserView.cpp: Added.
594         (createNewPage):
595         (BrowserView::BrowserView):
596         (BrowserView::resizeEvent):
597         (BrowserView::load):
598         (BrowserView::view):
599         * MiniBrowser/qt/BrowserView.h: Added.
600         (BrowserView::~BrowserView):
601         * MiniBrowser/qt/BrowserWindow.cpp:
602         * MiniBrowser/qt/BrowserWindow.h:
603         * MiniBrowser/qt/MiniBrowser.pro:
604
605 2010-09-08  Adam Barth  <abarth@webkit.org>
606
607         Rubber-stamped by Eric Seidel.
608
609         Rename DocLoader to CachedResourceLoader because that's what it does.
610
611         * Scripts/do-webcore-rename:
612
613 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
614
615         Reviewed by Ojan Vafai.
616
617         Enable incremental results.json generation for non-layout tests.
618         https://bugs.webkit.org/show_bug.cgi?id=45315
619
620         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
621
622         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
623
624
625 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
626
627         Unreviewed, build fix
628
629         Missed one test in mac_unittest.py in previous change; for some
630         reason the method is listed twice. I will fix both for now, but will
631         figure this out in a later, not-time-sensitive patch.
632
633         https://bugs.webkit.org/show_bug.cgi?id=45357
634
635         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
636
637 2010-09-07  Kent Tamura  <tkent@chromium.org>
638
639         Reviewed by Tony Chang.
640
641         test-webkitpy: Fix load error of
642         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
643         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
644
645         * Scripts/webkitpy/layout_tests/port/server_process.py:
646           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
647           and we don't use server_process.py on Win32 Python. However
648           unittest.py tries to load everything in a module.
649
650 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
651
652         Reviewed by Kent Tamura.
653
654         Fix regression introduced in previous change to new-run-webkit-tests
655         (bug 45090) to not try to run unittests for the Mac implementation
656         of the Port interface if we aren't running on a Mac.
657
658         Also fix the overrides implementation mock in the chromium unittests
659         to fix the case where there are overrides checked in that cause
660         problems.
661
662         https://bugs.webkit.org/show_bug.cgi?id=45357
663
664         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
665         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
666         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
667
668 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
669
670         Reviewed by Ojan Vafai.
671
672         new-run-webkit-tests: still more unit tests
673
674         Clean up and remove unnecessary code. Biggest notable change is
675         moving the chromium-specific imagediff code from port/base to
676         port/chromium.
677
678         Add more unit tests for run_webkit_tests.py, port/base.py,
679         port/factory.py, port/dryrun.py, and
680         layout_package/dump_render_tree_thread.py
681
682         This covers almost all of the generic and test code paths except for
683         a few error paths involving invalid or port-specific command line
684         arguments, and the code path for uploading results files to the
685         buildbots.
686         
687         https://bugs.webkit.org/show_bug.cgi?id=45090
688
689         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
690         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
691         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
692         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
693         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
694         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
695         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
696         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
697         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
698         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
699         * Scripts/webkitpy/layout_tests/port/base.py:
700         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
701         * Scripts/webkitpy/layout_tests/port/chromium.py:
702         * Scripts/webkitpy/layout_tests/port/dryrun.py:
703         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
704         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
705         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
706         * Scripts/webkitpy/layout_tests/port/server_process.py:
707         * Scripts/webkitpy/layout_tests/port/test.py:
708         * Scripts/webkitpy/layout_tests/port/webkit.py:
709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
710         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
711
712 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
713
714         Reviewed by Darin Adler.
715
716         Provide a way to trigger a <select multiple> onchange event on changes
717         https://bugs.webkit.org/show_bug.cgi?id=45192
718
719         Adds a selector on ObjCController for testing
720         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
721         its different uses.
722
723         * DumpRenderTree/mac/ObjCController.m:
724         (+[ObjCController isSelectorExcludedFromWebScript:]):
725         (+[ObjCController webScriptNameForSelector:]):
726         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
727
728 2010-09-07  James Robinson  <jamesr@chromium.org>
729
730         Rubber-stamped by Dimitri Glazkov.
731
732         Move myself from the committer to the reviewer list.
733
734         * Scripts/webkitpy/common/config/committers.py:
735
736 2010-09-07  Tony Chang  <tony@chromium.org>
737
738         Reviewed by Darin Fisher.
739
740         [chromium] Make a public flag for how DRT generates bitmaps on Linux
741         https://bugs.webkit.org/show_bug.cgi?id=45133
742
743         * DumpRenderTree/chromium/TestShell.cpp:
744         (TestShell::dumpImage):
745
746 2010-09-07  Kent Tamura  <tkent@chromium.org>
747
748         Reviewed by Dimitri Glazkov.
749
750         [DRT/Chromium] Implement --check-layout-test-sys-deps
751         https://bugs.webkit.org/show_bug.cgi?id=45283
752
753         * DumpRenderTree/chromium/DumpRenderTree.cpp:
754         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
755         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
756         * DumpRenderTree/chromium/TestShellGtk.cpp:
757         (checkLayoutTestSystemDependencies): Add an empty implementation.
758         * DumpRenderTree/chromium/TestShellMac.mm:
759         (checkLayoutTestSystemDependencies): Add an empty implementation.
760         * DumpRenderTree/chromium/TestShellWin.cpp:
761         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
762
763 2010-09-07  Jessie Berlin  <jberlin@apple.com>
764
765         Unreviewed. Mac build fix.
766
767         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
768         (didClearWindowObjectForFrame):
769
770 2010-09-07  Jessie Berlin  <jberlin@apple.com>
771
772         Reviewed by Darin Adler.
773
774         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
775         https://bugs.webkit.org/show_bug.cgi?id=45217
776         
777         Make WebKitTestRunner work with this change.
778
779         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
780         (WTR::InjectedBundlePage::didClearWindowForFrame):
781         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
782         WebFrameLoaderClient.
783         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
784
785 2010-09-07  Philippe Normand  <pnormand@igalia.com>
786
787         Unreviewed, build fix.
788
789         webkit-patch command to find the ports covering a specific layout test
790         https://bugs.webkit.org/show_bug.cgi?id=42832
791
792         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
793         tests are present when building the expectations. This is needed
794         for the unittests.
795
796 2010-09-06  Philippe Normand  <pnormand@igalia.com>
797
798         Reviewed by Adam Barth.
799
800         webkit-patch command to find the ports covering a specific layout test
801         https://bugs.webkit.org/show_bug.cgi?id=42832
802
803         To use it: webkit-patch skipped-ports some/layout/test.html
804
805         * Scripts/webkitpy/layout_tests/port/base.py:
806         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
807         * Scripts/webkitpy/layout_tests/port/chromium.py:
808         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
809         * Scripts/webkitpy/layout_tests/port/factory.py:
810         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
811         * Scripts/webkitpy/layout_tests/port/test.py:
812         * Scripts/webkitpy/layout_tests/port/webkit.py:
813         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
814         * Scripts/webkitpy/tool/commands/queries.py:
815         * Scripts/webkitpy/tool/commands/queries_unittest.py:
816         * Scripts/webkitpy/tool/main.py:
817         * Scripts/webkitpy/tool/mocktool.py:
818
819 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
820
821         Reviewed by Eric Seidel.
822
823         [NRWT] Add temp directory to all running drivers.
824         https://bugs.webkit.org/show_bug.cgi?id=45261
825
826         * Scripts/webkitpy/layout_tests/port/webkit.py:
827
828 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
829
830         Reviewed by Kent Tamura.
831
832         [Chromium/DRT] Empty out user stylesheet after each test run.
833         https://bugs.webkit.org/show_bug.cgi?id=45282
834
835         This should significantly cut down on the number of the mysterious flaky tests
836         whose diffs looked like the page was blown up to a very lage size. This
837         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
838         which set the base body font to 100px.
839
840         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
841         the same thread failed.
842
843         * DumpRenderTree/chromium/TestShell.cpp:
844         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
845
846 2010-09-06  Kent Tamura  <tkent@chromium.org>
847
848         Reviewed by Dimitri Glazkov.
849
850         [DRT/Chromium] Do not generate pixel results for text/plain resources
851         https://bugs.webkit.org/show_bug.cgi?id=45253
852
853         * DumpRenderTree/chromium/TestShell.cpp:
854         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
855
856 2010-09-06  Ojan Vafai  <ojan@chromium.org>
857
858         Reviewed by Kent Tamura.
859
860         print out correct error when a DRT thread dies in NRWT
861         https://bugs.webkit.org/show_bug.cgi?id=45281
862
863         Not sure why, but with the parens, python 2.6.5 on Linux
864         gives an error that raise takes 5 arguments and 0 were given.
865         Didn't test other platforms or python versions, but putting it
866         all on one line fixes it and correctly prints the exception
867         from the DRT thread.
868
869         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
870
871 2010-09-06  Eric Seidel  <eric@webkit.org>
872
873         Unreviewed, just adding some emails from lists.webkit.org.
874
875         Update committers.py to include emails from lists.webkit.org
876         as found by the validate-committer-lists script.
877
878         * Scripts/webkitpy/common/config/committers.py:
879
880 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
881
882         Reviewed by Xan Lopez.
883
884         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
885         https://bugs.webkit.org/show_bug.cgi?id=45213
886
887         * DumpRenderTree/gtk/DumpRenderTree.cpp:
888         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
889         have to surround the invocation with #ifdefs.
890         (useLongRunningServerMode): Added.
891         (runTestingServerLoop): Added.
892         (initializeGlobalsFromCommandLineOptions): Added.
893         (runTest): Removed ifdefs.
894         (main): Use new helper functions.
895
896 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
897
898         Reviewed by Xan Lopez.
899
900         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
901         https://bugs.webkit.org/show_bug.cgi?id=45235
902
903         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
904         methods of the EventSender.
905
906         * DumpRenderTree/gtk/EventSender.cpp:
907         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
908         with the current modifiers.
909         (contextClickCallback): Always send no modifiers when preparing the mouse event.
910         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
911         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
912         (mouseUpCallback): Ditto.
913
914 2010-09-05  Peter Kasting  <pkasting@google.com>
915
916         Reviewed by Adam Barth.
917
918         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
919         https://bugs.webkit.org/show_bug.cgi?id=45155
920
921         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
922         (EventSender::handleMouseWheel):
923
924 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
925
926         Reviewed by Joseph Pecoraro.
927
928         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
929         https://bugs.webkit.org/show_bug.cgi?id=45179
930
931         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
932         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
933
934 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
935
936         Rubber-stamped by Daniel Bates.
937
938         Adding myself as reviewer.
939
940         * Scripts/webkitpy/common/config/committers.py:
941
942 2010-09-04  Daniel Bates  <dbates@rim.com>
943
944         Reviewed by Martin Robinson.
945
946         Teach svn-apply/unapply about svn:mergeinfo
947         https://bugs.webkit.org/show_bug.cgi?id=45236
948
949         Recognize the svn:mergeinfo property and ignore it for now.
950
951         Currently, svn-apply/unapply recognize only '+' and '-'
952         property changes within a diff. We should add support
953         to recognize "Merged" and "Reverse-merged" changes as well.
954         Because svn:mergeinfo is metadata that is used only by SVN
955         and tends to be error-prone and/or nuisance (*), we will ignore
956         it for now.
957         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
958
959         * Scripts/VCSUtils.pm:
960           - Modified parseSvnProperty() to recognize "Merged" and
961             "Reverse-merged" as the start of a property value.
962         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
963           - Added the following unit tests:
964             "simple: add svn:mergeinfo"
965             "simple: delete svn:mergeinfo"
966             "simple: modified svn:mergeinfo"
967         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
968           - Added the following unit tests:
969             "simple: add svn:mergeinfo"
970             "simple: delete svn:mergeinfo"
971             "simple: modified svn:mergeinfo"
972             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
973             "'Merged' change followed by 'Merged' change"
974             "'Reverse-merged' change followed by 'Reverse-merged' change"
975         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
976           - Added the following unit tests:
977             "'Merged' change"
978             "'Reverse-merged' change"
979             "'Reverse-merged' change followed by 'Merge' change"
980             "'Merged' change followed by 'Merge' change"
981             "'Reverse-merged' change followed by 'Reverse-merged' change"
982             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
983
984 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
985
986         Reviewed by Kenneth Rohde Christiansen.
987
988         [EFL] Move test browser to WebKitTools directory
989         https://bugs.webkit.org/show_bug.cgi?id=45212
990
991         Follow other ports like QT and GTK which moved the test browser to
992         WebKitTools directory.
993
994         * CMakeListsEfl.txt: Added.
995         * EWebLauncher/main.c: Added.
996         (print_history):
997         (zoom_level_set):
998         (on_ecore_evas_resize):
999         (title_set):
1000         (viewport_set):
1001         (on_title_changed):
1002         (on_progress):
1003         (on_load_finished):
1004         (on_toolbars_visible_set):
1005         (on_toolbars_visible_get):
1006         (on_statusbar_visible_set):
1007         (on_statusbar_visible_get):
1008         (on_scrollbars_visible_set):
1009         (on_scrollbars_visible_get):
1010         (on_menubar_visible_set):
1011         (on_menubar_visible_get):
1012         (on_tooltip_text_set):
1013         (on_inputmethod_changed):
1014         (on_viewport_changed):
1015         (on_mouse_down):
1016         (on_focus_out):
1017         (on_focus_in):
1018         (on_resized):
1019         (on_key_down):
1020         (on_browser_del):
1021         (on_closeWindow):
1022         (quit):
1023         (browserCreate):
1024         (browserDestroy):
1025         (closeWindow):
1026         (main_signal_exit):
1027         (findThemePath):
1028         (main):
1029
1030 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
1031
1032         Reviewed by Adam Roben.
1033
1034         Set project dependencies so that they build serially. This fixes
1035         issues when running run-webkit-tests if DRT is not built yet.
1036
1037         * DumpRenderTree/DumpRenderTree.sln:
1038
1039 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
1040
1041         Reviewed by Adam Barth.
1042
1043         Fix reading configuraiton in NWRT to work on Windows.
1044         https://bugs.webkit.org/show_bug.cgi?id=45180
1045
1046         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
1047             with the file otherwise.
1048
1049 2010-09-03  Chris Rogers  <crogers@google.com>
1050
1051         Unreviewed
1052
1053         Add myself to the committers list
1054         https://bugs.webkit.org/show_bug.cgi?id=45189
1055
1056         * Scripts/webkitpy/common/config/committers.py:
1057
1058 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
1059
1060         Reviewed by Yury Semikhatsky.
1061
1062         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
1063         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
1064         https://bugs.webkit.org/show_bug.cgi?id=45137
1065
1066         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
1067
1068 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1069
1070         Reviewed by Eric Seidel.
1071
1072         Add feature detection support to NRWT.
1073         https://bugs.webkit.org/show_bug.cgi?id=41842
1074
1075         * Scripts/webkitpy/layout_tests/port/base.py:
1076         * Scripts/webkitpy/layout_tests/port/qt.py:
1077         * Scripts/webkitpy/layout_tests/port/webkit.py:
1078         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
1079
1080 2010-09-03  Hironori Bono  <hbono@chromium.org>
1081
1082         Reviewed by Kent Tamura.
1083
1084         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
1085         and implements it for Mac.
1086         https://bugs.webkit.org/show_bug.cgi?id=41832
1087
1088         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
1089         and bind it so we can call it from JavaScript.
1090         (+[TextInputController isSelectorExcludedFromWebScript:]):
1091         (+[TextInputController webScriptNameForSelector:]):
1092         (-[TextInputController hasSpellingMarker:length:]):
1093
1094 2010-09-02  Eric Seidel  <eric@webkit.org>
1095
1096         Reviewed by Adam Barth.
1097
1098         Add a unit test for commit-queue retries
1099         https://bugs.webkit.org/show_bug.cgi?id=45162
1100
1101         I think commit-queue retries are not correctly avoiding
1102         build and test on retries.  So I started testing the code.
1103         Unfortunately this test did not find the bug.  But now
1104         that we have the test we might as well keep it.
1105         I also fixed a broken import in validate-committer-lists.
1106
1107         * Scripts/validate-committer-lists:
1108         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1109
1110 2010-09-02  Kent Tamura  <tkent@chromium.org>
1111
1112         Reviewed by Dimitri Glazkov.
1113
1114         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
1115         https://bugs.webkit.org/show_bug.cgi?id=45091
1116
1117         Task.{cpp,h} introduces a simpler version of Chromium
1118         base/task.h. It doesn't have TupleN and Method.
1119
1120         * DumpRenderTree/DumpRenderTree.gypi:
1121          Add Task.cpp and Task.h
1122         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1123         (DRTDevToolsAgent::DRTDevToolsAgent):
1124         (DRTDevToolsAgent::reset):
1125         (DRTDevToolsAgent::asyncCall):
1126         (DRTDevToolsAgent::frontendLoaded):
1127         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1128         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
1129         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1130         (DRTDevToolsClient::DRTDevToolsClient):
1131         (DRTDevToolsClient::~DRTDevToolsClient):
1132         (DRTDevToolsClient::reset):
1133         (DRTDevToolsClient::asyncCall):
1134         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1135         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
1136         * DumpRenderTree/chromium/EventSender.cpp:
1137         (EventSender::EventSender):
1138         (EventSender::reset):
1139         (EventSender::scheduleAsynchronousClick):
1140         * DumpRenderTree/chromium/EventSender.h:
1141         (EventSender::taskList): Added to use MethodTask<T>.
1142         * DumpRenderTree/chromium/LayoutTestController.cpp:
1143         (LayoutTestController::LayoutTestController):
1144         (LayoutTestController::WorkQueue::processWorkSoon):
1145         (LayoutTestController::waitUntilDone):
1146         (LayoutTestController::notifyDone):
1147         (LayoutTestController::reset):
1148         * DumpRenderTree/chromium/LayoutTestController.h:
1149         (LayoutTestController::taskList): Added to use MethodTask<T>.
1150         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
1151         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1152         (deferredDisplayDispatch):
1153         (NotificationPresenter::show):
1154         * DumpRenderTree/chromium/Task.cpp: Added.
1155         * DumpRenderTree/chromium/Task.h: Added.
1156
1157 2010-09-02  Steve Block  <steveblock@google.com>
1158
1159         Reviewed by Adam Barth.
1160
1161         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
1162         https://bugs.webkit.org/show_bug.cgi?id=43181
1163
1164         * DumpRenderTree/mac/DumpRenderTree.mm:
1165         (createWebViewAndOffscreenWindow):
1166         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1167         (LayoutTestController::setMockDeviceOrientation):
1168
1169 2010-08-31  Adam Roben  <aroben@apple.com>
1170
1171         Fix flashiness when resizing the browser window on Windows
1172
1173         Reviewed by Sam Weinig.
1174
1175         * MiniBrowser/win/BrowserWindow.cpp:
1176         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
1177         periodically fill the window with white.
1178
1179 2010-09-02  Peter Kasting  <pkasting@google.com>
1180
1181         Reviewed by Dimitri Glazkov.
1182
1183         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
1184         https://bugs.webkit.org/show_bug.cgi?id=45073
1185
1186         * DumpRenderTree/chromium/EventSender.cpp:
1187         (EventSender::EventSender):
1188         (EventSender::mouseScrollBy):
1189         (EventSender::continuousMouseScrollBy):
1190         (EventSender::sendCurrentTouchEvent):
1191         (EventSender::handleMouseWheel):
1192         * DumpRenderTree/chromium/EventSender.h:
1193         * DumpRenderTree/gtk/EventSender.cpp:
1194         (mouseScrollByCallback):
1195         (continuousMouseScrollByCallback):
1196
1197 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1198
1199         Reviewed by Tony Chang.
1200
1201         Land a patched version of r66542 - change TestRunner to have an
1202         separate cleanup method and fix the ordering of cleanup between
1203         TestRunner and the printing module, and then wrap everything in a
1204         try/finally block to ensure reliable cleanup without needing to
1205         rely on stuff happening in the destructor of the TestRunner.
1206
1207         Also refactor run_webkit_tests.run() to be much smaller and cleaner
1208         by creating a bunch of helper methods and moving more stuff into
1209         the TestRunner class.
1210
1211         This fixes the crash at the end of the linux test run of
1212         new-run-webkit-tests (and undoes the rollout in 66547).
1213
1214         https://bugs.webkit.org/show_bug.cgi?id=44902
1215
1216         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1217         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1218         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1219         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1220         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1221         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1222         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1223         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1224         * Scripts/webkitpy/layout_tests/port/base.py:
1225         * Scripts/webkitpy/layout_tests/port/test.py:
1226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1227         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1228
1229 2010-09-01  Mark Rowe  <mrowe@apple.com>
1230
1231         Reviewed by Adam Roben.
1232
1233         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
1234
1235         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1236
1237 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
1238
1239         Reviewed by Adam Roben.
1240
1241         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
1242         and WebKitTestRunner.
1243
1244         * BuildSlaveSupport/win/kill-old-processes:
1245
1246 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1247
1248         Reviewed by Antonio Gomes.
1249
1250         [Qt] Remove obsolete include path from DumpRenderTree.pro
1251
1252         * DumpRenderTree/qt/DumpRenderTree.pro:
1253
1254 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1255
1256         Reviewed by Laszlo Gombos.
1257
1258         [Qt] QWebPage::allowGeolocationRequest should be async API
1259         https://bugs.webkit.org/show_bug.cgi?id=41364
1260
1261         Implements new async API for geolocation permission similar to
1262         Notification. WebPage maintains list of geolocation permission request
1263         QtWebkit and set's when LayoutTestController gets the access from test JS
1264
1265         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1266         (WebCore::WebPage::WebPage):
1267         (WebCore::WebPage::resetSettings):
1268         (WebCore::WebPage::requestPermission):
1269         (WebCore::WebPage::cancelPermission):
1270         (WebCore::WebPage::permissionSet):
1271         (WebCore::DumpRenderTree::DumpRenderTree):
1272         (WebCore::DumpRenderTree::processLine):
1273         (WebCore::DumpRenderTree::geolocationPermissionSet):
1274         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1275         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1276         (LayoutTestController::reset):
1277         (LayoutTestController::setGeolocationPermission):
1278         (LayoutTestController::setGeolocationPermissionCommon):
1279         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1280
1281 2010-09-01  Andras Becsi  <abecsi@webkit.org>
1282
1283         Reviewed by Antti Koivisto.
1284
1285         [Qt] Auto-generate WebKit2 forwarding headers
1286         https://bugs.webkit.org/show_bug.cgi?id=44692
1287
1288         * MiniBrowser/qt/BrowserWindow.h: use source style includes
1289         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
1290         * Scripts/enumerate-included-framework-headers: Removed.
1291
1292 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1293
1294         Reviewed by Adam Barth.
1295
1296         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
1297         https://bugs.webkit.org/show_bug.cgi?id=44789
1298
1299         * Scripts/webkitpy/common/net/bugzilla.py:
1300
1301 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
1302
1303         Reviewed by Adam Barth.
1304
1305         ews: Add support for EFL-EWS
1306         https://bugs.webkit.org/show_bug.cgi?id=44982
1307
1308         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
1309         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
1310         and add it to the ports dict.
1311         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
1312         EflEWS class.
1313         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
1314         a test case for the EFL EWS.
1315
1316 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
1317
1318         Reviewed by Sam Weinig.
1319
1320         https://bugs.webkit.org/show_bug.cgi?id=42195
1321         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
1322
1323         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1324         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
1325         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1326         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
1327         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
1328
1329         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1330         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
1331         which forgets its override.
1332
1333 2010-08-31  Sam Weinig  <sam@webkit.org>
1334
1335         Reviewed by Gavin Barraclough.
1336
1337         WebKitTestRunner needs layoutTestController.addUserStyleSheet
1338         https://bugs.webkit.org/show_bug.cgi?id=42680
1339
1340         WebKitTestRunner needs layoutTestController.addUserScript
1341         https://bugs.webkit.org/show_bug.cgi?id=42681
1342
1343         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1344         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1345         (WTR::InjectedBundle::beginTesting):
1346         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1347         (WTR::LayoutTestController::addUserScript):
1348         (WTR::LayoutTestController::addUserStyleSheet):
1349         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1350
1351 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1352
1353         Unreviewed, rolling out r66542.
1354         http://trac.webkit.org/changeset/66542
1355         https://bugs.webkit.org/show_bug.cgi?id=44902
1356
1357         r66542 - the weird logging dependencies in Python stuck again ...
1358
1359         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
1360         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
1361         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
1362         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
1363         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1364         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1365         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1366         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1367         * Scripts/webkitpy/layout_tests/port/base.py:
1368         * Scripts/webkitpy/layout_tests/port/test.py:
1369         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1370         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1371
1372 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
1373
1374         Reviewed by Tony Chang.
1375
1376         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
1377
1378         * DumpRenderTree/chromium/LayoutTestController.cpp:
1379         (LayoutTestController::LayoutTestController):
1380         (LayoutTestController::markerTextForListItem):
1381         * DumpRenderTree/chromium/LayoutTestController.h:
1382
1383 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1384
1385         Reviewed by Ojan Vafai.
1386
1387         new-run-webkit-tests: add more unit tests
1388
1389         Add more unit tests for new-run-webkit-tests; we now cover all but
1390         the most obscure code paths in the generic code. We still need to
1391         add coverage for the http server and web socket paths, and add better
1392         coverage of the platform-specific logic. Note that the rebaselining
1393         tool is still not well tested.
1394
1395         Also clean up some of the configuration logic for the printing
1396         module and the way it interacts with the Python logging module; that
1397         is a crufty interface, to be certain.
1398         
1399         https://bugs.webkit.org/show_bug.cgi?id=44902
1400
1401         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1402         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1403         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1404         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1405         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1406         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1407         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1408         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1409         * Scripts/webkitpy/layout_tests/port/base.py:
1410         * Scripts/webkitpy/layout_tests/port/test.py:
1411         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1412         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1413
1414 2010-08-31  Darin Adler  <darin@apple.com>
1415
1416         Reviewed by Anders Carlsson.
1417
1418         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
1419         in a debug build when built with certain compilers.
1420
1421 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
1422
1423         Reviewed by Gustavo Noronha Silva.
1424
1425         [GTK] Isolate all GTK+ typedefs into one file
1426         https://bugs.webkit.org/show_bug.cgi?id=44900
1427
1428         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
1429
1430 2010-08-31  Eric Seidel  <eric@webkit.org>
1431
1432         Reviewed by Adam Barth.
1433
1434         Show more status on queue status pages
1435         https://bugs.webkit.org/show_bug.cgi?id=44938
1436
1437         I upped the number of status lines from 6 to 15 --
1438         this has been bugging me for a while...
1439
1440         I also disabled showing the chromium-win EWS queue
1441         since it's been down for almost 5 months now.
1442
1443         * QueueStatusServer/handlers/dashboard.py:
1444         * QueueStatusServer/handlers/queuestatus.py:
1445         * QueueStatusServer/model/queues.py:
1446
1447 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
1448
1449         Reviewed by Antonio Gomes.
1450
1451         [Qt] Read command line arguments and open them as URLs in new windows
1452         https://bugs.webkit.org/show_bug.cgi?id=44944
1453
1454         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
1455
1456         * MiniBrowser/qt/main.cpp:
1457         (main):
1458
1459 2010-08-31  Adrian Perez  <aperez@igalia.com>
1460
1461         Reviewed by Martin Robinson.
1462
1463         Support scripts to run Buildbot slaves under daemontools (gtk related)
1464         https://bugs.webkit.org/show_bug.cgi?id=40053
1465
1466         * BuildSlaveSupport/gtk: Added.
1467         * BuildSlaveSupport/gtk/README: Added.
1468         * BuildSlaveSupport/gtk/buildbot: Added.
1469         * BuildSlaveSupport/gtk/buildbot/log: Added.
1470         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
1471         * BuildSlaveSupport/gtk/buildbot/run: Added.
1472         * BuildSlaveSupport/gtk/crashmon: Added.
1473         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
1474         * BuildSlaveSupport/gtk/crashmon/log: Added.
1475         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
1476         * BuildSlaveSupport/gtk/crashmon/run: Added.
1477         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
1478         * BuildSlaveSupport/gtk/pulseaudio: Added.
1479         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
1480         * BuildSlaveSupport/gtk/xvfb: Added.
1481         * BuildSlaveSupport/gtk/xvfb/log: Added.
1482         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
1483         * BuildSlaveSupport/gtk/xvfb/run: Added.
1484
1485 2010-08-27  John Gregg  <johnnyg@google.com>
1486
1487         Reviewed by David Levin.
1488
1489         Notifications should support a click event.
1490         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
1491         can be simulated during a layout test.  Requires storing a list of active
1492         notifications so that they can be referred to later for clicking.
1493         https://bugs.webkit.org/show_bug.cgi?id=44800
1494
1495         * DumpRenderTree/chromium/LayoutTestController.cpp:
1496         (LayoutTestController::LayoutTestController):
1497         (LayoutTestController::simulateDesktopNotificationClick):
1498         * DumpRenderTree/chromium/LayoutTestController.h:
1499         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1500         (NotificationPresenter::simulateClick):
1501         (NotificationPresenter::show):
1502         (NotificationPresenter::cancel):
1503         (NotificationPresenter::objectDestroyed):
1504         * DumpRenderTree/chromium/NotificationPresenter.h:
1505
1506 2010-08-30  Alice Liu  <alice.liu@apple.com>
1507
1508         Reviewed by Darin Adler.
1509
1510         Add missing parts of didFinishDocumentLoadForFrame
1511         https://bugs.webkit.org/show_bug.cgi?id=44913
1512
1513         * MiniBrowser/mac/BrowserWindowController.m:
1514         (didFinishDocumentLoadForFrame): Added
1515         (-[BrowserWindowController awakeFromNib]): Updated struct
1516         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1517         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
1518         * WebKitTestRunner/TestController.cpp:
1519         (WTR::TestController::initialize): Updated struct
1520
1521 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
1522
1523         Unreviewed: Add myself to the list of Committers.
1524
1525         * Scripts/webkitpy/common/config/committers.py:
1526
1527 2010-08-30  Kent Tamura  <tkent@chromium.org>
1528
1529         Reviewed by Adam Barth.
1530
1531         Fix fast/notifications/notifications-display-close-events.html failure
1532         https://bugs.webkit.org/show_bug.cgi?id=44585
1533
1534         Apply http://crrev.com/48893. We should dispatch display events
1535         asynchronously.
1536
1537         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1538         (deferredDisplayDispatch):
1539         (NotificationPresenter::show):
1540
1541 2010-08-30  Robert Hogan  <robert@webkit.org>
1542
1543         Reviewed by Simon Hausmann.
1544
1545         allow ports with windowed plugins to support windowless plugin tests
1546
1547         https://bugs.webkit.org/show_bug.cgi?id=40730
1548
1549         Ports that implement plugins windowed by default need to have a way of
1550         supporting plugin tests that assume the plugin is windowless. Add this
1551         feature to the tests and support it in the webkit test plugin. Also
1552         add mouse and keyboard event logging to the webkit-test plugin on Unix.
1553
1554         Unskip the following tests on Qt:
1555
1556         plugins/mouse-events.html
1557         plugins/keyboard-events.html
1558         plugins/mouse-events-fixedpos.html
1559
1560         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1561         (pluginSetProperty):
1562         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1563         (NPP_New):
1564         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1565         (webkit_test_plugin_handle_event):
1566
1567 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
1568
1569         [wx] Build fix after addition of fileapi directory in WebCore.
1570
1571         * wx/build/settings.py:
1572
1573 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1574
1575         Reviewed by Xan Lopez.
1576
1577         Fixed compilation error, now that we have included the
1578         GtkVersioning.h we have to remove some version dependent code from
1579         EventSender.
1580
1581         * DumpRenderTree/gtk/EventSender.cpp:
1582
1583 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1584
1585         Reviewed by Martin Robinson.
1586
1587         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
1588         are deprecated
1589         https://bugs.webkit.org/show_bug.cgi?id=44787
1590
1591         We have replaced GtkVersioning.cpp with GtkVersioning.c and
1592         created a function (getDefaultGDKPointerDevice) to get the pointer
1593         of the window with the new APIs. We added that function to DRT and
1594         copyandpaste unit test.
1595
1596         * DumpRenderTree/gtk/EventSender.cpp:
1597         (prepareMouseButtonEvent):
1598         (mouseMoveToCallback):
1599         (keyDownCallback):
1600         * GNUmakefile.am:
1601
1602 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
1603
1604         Reviewed by Kenneth Rohde Christiansen.
1605
1606         [Qt] Add new window menu to MiniBrowser
1607
1608         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
1609
1610         * MiniBrowser/qt/BrowserWindow.cpp:
1611         (BrowserWindow::BrowserWindow):
1612         (BrowserWindow::newWindow):
1613         * MiniBrowser/qt/BrowserWindow.h:
1614         * MiniBrowser/qt/main.cpp:
1615         (main):
1616
1617 2010-08-29  James Robinson  <jamesr@chromium.org>
1618
1619         Reviewed by David Levin.
1620
1621         Make failing the download step fail the build
1622         https://bugs.webkit.org/show_bug.cgi?id=44298
1623
1624         If the download step fails on a test bot, this ensures that
1625         the build goes red instead of only the download step going red
1626         and the overall build staying green.
1627
1628         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1629
1630 2010-08-29  Kent Tamura  <tkent@chromium.org>
1631
1632         Reviewed by Dimitri Glazkov.
1633
1634         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
1635         https://bugs.webkit.org/show_bug.cgi?id=44847
1636
1637         * DumpRenderTree/chromium/EventSender.cpp:
1638          Use webkit_support::VKEY_* instead of base::VKEY_*.
1639
1640 2010-08-29  Darin Adler  <darin@apple.com>
1641
1642         https://bugs.webkit.org/show_bug.cgi?id=40589
1643
1644         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
1645         function names.
1646
1647 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1648
1649         Reviewed by Darin Adler.
1650
1651         [iExploder] Add new CSS Properties and HTML Attributes
1652         https://bugs.webkit.org/show_bug.cgi?id=44746
1653
1654         Updated the files with the update-iexploder-cssproperties script
1655         and manually readded the -webkit-binding CSS Property to the list.
1656
1657         * iExploder/htdocs/cssproperties.in:
1658         * iExploder/htdocs/htmlattrs.in:
1659         * iExploder/htdocs/htmltags.in:
1660
1661 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1662
1663         Reviewed by Darin Adler.
1664
1665         Fix Coverage build after the addition of ANGLE
1666         https://bugs.webkit.org/show_bug.cgi?id=44744
1667
1668         ANGLE is using libtool to build a static library and the version of
1669         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
1670         parameters. The easiest way to handle this is to not build ANGLE with
1671         coverage information.
1672
1673         This is achieved by applying the XCode options for each project
1674         separately and exclude ANGLE.
1675
1676         * Scripts/build-webkit: Remove -framework AppKit due link errors.
1677         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
1678
1679 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
1680
1681         [wx] Build fix after directory addition.
1682
1683         * wx/build/settings.py:
1684
1685 2010-08-28  Chris Guillory   <chris.guillory@google.com>
1686
1687         Reviewed by Chris Fleizach.
1688
1689         Add AX notification for childrenChanged
1690         https://bugs.webkit.org/show_bug.cgi?id=44472
1691
1692         * DumpRenderTree/chromium/AccessibilityController.cpp:
1693         (AccessibilityController::AccessibilityController):
1694         (AccessibilityController::reset):
1695         (AccessibilityController::getRootElement):
1696         (AccessibilityController::dumpAccessibilityNotifications):
1697         * DumpRenderTree/chromium/AccessibilityController.h:
1698         (AccessibilityController::shouldDumpAccessibilityNotifications):
1699         * DumpRenderTree/chromium/WebViewHost.cpp:
1700         (WebViewHost::didChangeAccessibilityObjectChildren):
1701         * DumpRenderTree/chromium/WebViewHost.h:
1702
1703 2010-08-28  Eric Seidel  <eric@webkit.org>
1704
1705         Reviewed by Adam Barth.
1706
1707         Update commit-queue failure message
1708         https://bugs.webkit.org/show_bug.cgi?id=44798
1709
1710         The commit-queue auto-restarts itself and has for a very long time.
1711         No need for people to email me to request a restart anymore.
1712
1713         * Scripts/webkitpy/common/net/bugzilla.py:
1714         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1715         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1716
1717 2010-07-27  Jer Noble  <jer.noble@apple.com>
1718
1719         Reviewed by Eric Carlson.
1720
1721         Add JavaScript API to allow a page to go fullscreen.
1722         rdar://problem/6867795
1723         
1724         Added basic full screen support to DumpRenderTree: when a webView requests
1725         that DumpRenderTree go "full screen", just call the provided callback listener object's
1726         will/did Enter/Exit full screen methods.  Also, register a new user default which 
1727         enables full screen support.
1728
1729         * DumpRenderTree/mac/DumpRenderTree.mm:
1730         (resetDefaultsToConsistentValues):
1731         * DumpRenderTree/mac/UIDelegate.mm:
1732         (-[UIDelegate webView:supportsFullscreenForElement:]):
1733         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
1734         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
1735
1736 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1737
1738         Unreviewed. Add myself to the committers list.
1739
1740         * Scripts/webkitpy/common/config/committers.py:
1741
1742 2010-08-27  Kent Tamura  <tkent@chromium.org>
1743
1744         Reviewed by Pavel Feldman.
1745
1746         [DRT/Chromium] Fix inspector test failures
1747         https://bugs.webkit.org/show_bug.cgi?id=44748
1748
1749         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1750         (DRTDevToolsAgent::createClientMessageLoop):
1751           Returns a valid WebKitClientMessageLoop instance
1752         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1753
1754 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
1755
1756         Add Windows WebKit2 Tester to buildbot
1757         <rdar://problem/7887703>
1758
1759         Reviewed by Dan Bernstein.
1760
1761         * BuildSlaveSupport/build.webkit.org-config/config.json:
1762
1763 2010-08-26  Philippe Normand  <pnormand@igalia.com>
1764
1765         Reviewed by Martin Robinson.
1766
1767         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1768         https://bugs.webkit.org/show_bug.cgi?id=42152
1769
1770         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1771         (LoadHTMLStringItem::invoke): Implementation using
1772         webkit_web_frame_load_string().
1773
1774 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
1775
1776         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
1777         WebKitTestRunner (44331)
1778
1779         Reviewed by Darin Adler.
1780
1781         * WebKitTestRunner/TestController.cpp:
1782         (WTR::TestController::initialize):
1783         The hang occurs when WebKitTestRunner begins launching the WebKit2
1784         web process then exits before it finishes launching. Work around this by
1785         looking for the --print-supported-features argument and exiting without
1786         creating the web process.
1787
1788 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
1789
1790         Reviewed by Tony Chang.
1791
1792         new-run-webkit-tests: add rebaselining tests for test_expectations
1793         
1794         This patch adds more unit tests for the rebaselining code in the
1795         test_expectations module. It doesn't add any tests for
1796         rebaseline_chromium_webkit_tests itself; that will come some other
1797         time.
1798
1799         https://bugs.webkit.org/show_bug.cgi?id=44648
1800
1801         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1802         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1803
1804 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1805
1806         Reviewed by Martin Robinson.
1807
1808         [GTK] Add HTTP caching support
1809         https://bugs.webkit.org/show_bug.cgi?id=44261
1810
1811         Ignore new soup API that we decided to merge into the soup backend
1812         while it is being cooked. It follows the libsoup style, and will
1813         be removed from WebKit as soon as it is merged into libsoup.
1814
1815         * Scripts/webkitpy/style/checker.py:
1816
1817 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1818
1819         Reviewed by Kenneth Rohde Christiansen.
1820
1821         [Qt] DumpRenderTree runs only one test from command mode
1822         https://bugs.webkit.org/show_bug.cgi?id=44012
1823
1824         Enables support to run multiple test files and single
1825         folder containing html files in stand alone mode
1826
1827         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1828         (WebCore::DumpRenderTree::DumpRenderTree):
1829         (WebCore::DumpRenderTree::processArgsLine):
1830         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1831         (WebCore::DumpRenderTree::processLine):
1832         (WebCore::DumpRenderTree::dump):
1833         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1834         (WebCore::DumpRenderTree::setStandAloneMode):
1835         (WebCore::DumpRenderTree::isStandAloneMode):
1836         * DumpRenderTree/qt/main.cpp:
1837         (main):
1838
1839 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1840
1841         Updating webkitpy test expectations.
1842
1843         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1844
1845 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1846
1847         Reviewed by Eric Seidel.
1848
1849         fix the always squash git config
1850         https://bugs.webkit.org/show_bug.cgi?id=44651
1851
1852         Fix help text and apparently underscores are not allowed
1853         in git config keys.
1854
1855         * Scripts/webkitpy/common/checkout/scm.py:
1856         * Scripts/webkitpy/tool/steps/commit.py:
1857
1858 2010-08-25  Darin Adler  <darin@apple.com>
1859
1860         Reviewed by John Sullivan.
1861
1862         * Scripts/commit-log-editor: Fix perl warning for people who have no
1863         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
1864
1865 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1866
1867         Reviewed by Eric Seidel.
1868
1869         stop blocking commits when the bots are red
1870         https://bugs.webkit.org/show_bug.cgi?id=44644
1871
1872         This check currently is just annoying. It doesn't actually
1873         help keep the tree green. We can always add it back later
1874         if we decide the tree is generally more green.
1875
1876         * Scripts/webkitpy/tool/commands/download_unittest.py:
1877         * Scripts/webkitpy/tool/mocktool.py:
1878         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1879
1880 2010-08-25  Eric Seidel  <eric@webkit.org>
1881
1882         Reviewed by Simon Fraser.
1883
1884         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
1885         https://bugs.webkit.org/show_bug.cgi?id=38912
1886
1887         I know of nothing else to do but skip all media tests for the cq.
1888
1889         * Scripts/webkitpy/tool/steps/runtests.py:
1890
1891 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1892
1893         Reviewed by Ojan Vafai.
1894
1895         new-run-webkit-tests: add more unit tests for test_expectations
1896         This adds unit tests to cover (almost?) all of the non-rebaselining
1897         functionality.
1898
1899         https://bugs.webkit.org/show_bug.cgi?id=44579
1900
1901         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1902         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1903
1904 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1905
1906         Reviewed by Ojan Vafai.
1907
1908         new-run-webkit-tests: add more unit tests
1909
1910         This change adds more unit tests for the image_diff, test_failures,
1911         and test_files modules, bringing them to 100% coverage (and adds a
1912         couple tests to run_webkit_tests while we're at it).
1913
1914         This test also turns on the "dryrun" port for testing when run on
1915         the mac, increasing coverage in a few other places.
1916
1917         https://bugs.webkit.org/show_bug.cgi?id=44578
1918
1919         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
1920         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
1921         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
1922         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
1923         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
1924         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
1925         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
1926         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
1927         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1928         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
1929         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1930         * Scripts/webkitpy/layout_tests/port/test.py:
1931         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1932
1933 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1934
1935         Reviewed by Ojan Vafai.
1936
1937         new-run-webkit-tests: add more unit tests for layout_package/printing.py
1938
1939         This change adds more unit tests to get the test coverage to 100%
1940         for the printing module. This code is actually pretty crufty and
1941         has some layering violations that need to be cleaned up but I'll
1942         save that for another CL after we get all the unit tests written and
1943         we fix the multithreading issues. At least now we'll be able to tell
1944         if we break things.
1945
1946         https://bugs.webkit.org/show_bug.cgi?id=44576
1947
1948         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1949         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1950
1951 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1952
1953         Reviewed by Adam Barth.
1954
1955         new-run-webkit-tests should respect set-webkit-configuration
1956         https://bugs.webkit.org/show_bug.cgi?id=44633
1957
1958         Moves the getting of the configuration into the base Port so that
1959         chromium ports use it as well. In the downstream chromium port,
1960         this should still just return Release.
1961
1962         * Scripts/webkitpy/layout_tests/port/base.py:
1963         * Scripts/webkitpy/layout_tests/port/webkit.py:
1964
1965 2010-08-25  Tony Chang  <tony@chromium.org>
1966
1967         Not reviewed, changing svn props for a script.
1968
1969         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
1970
1971 2010-08-25  Adam Barth  <abarth@webkit.org>
1972
1973         Reviewed by Eric Seidel.
1974
1975         Remove WebKit2 from core builders
1976         https://bugs.webkit.org/show_bug.cgi?id=44625
1977
1978         This builder was added to the core builders by accident.  It doesn't
1979         appear to be green enough to be a core builder yet.
1980
1981         * Scripts/webkitpy/common/net/buildbot.py:
1982         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1983
1984 2010-08-19  Adam Roben  <aroben@apple.com>
1985
1986         Test that NP_Initialize and NP_GetEntryPoints are called in the
1987         correct order
1988
1989         The order differs between Mac and Windows (see r38858).
1990
1991         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1992         NP_Initialize when loading QuickTime when running
1993         plugins/embed-attributes-setting.html in WebKit2 on Windows
1994
1995         Reviewed by John Sullivan.
1996
1997         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1998         a boolean to record whether NP_GetEntryPoints has been called.
1999         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
2000         called yet. This matches Flash and QuickTime's behavior.
2001         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
2002         yet. This matches Silverlight's behavior.
2003
2004 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
2005
2006         Reviewed by Gustavo Noronha Silva.
2007
2008         Cairo and EFL port shouldn't depend on glib.
2009         https://bugs.webkit.org/show_bug.cgi?id=44354
2010
2011         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
2012         adoptPlatformRef.
2013
2014         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2015         (AccessibilityUIElement::isSelected):
2016
2017 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2018
2019         Fix order of Timothy's email address. The script, and
2020         other tools all assume that the first email is the bugzilla address.
2021
2022         * Scripts/webkitpy/common/config/committers.py:
2023
2024 2010-08-24  Kent Tamura  <tkent@chromium.org>
2025
2026         Reviewed by Pavel Feldman.
2027
2028         [DRT/Chromium] Fix 26 inspector test crashes
2029         https://bugs.webkit.org/show_bug.cgi?id=44580
2030
2031         - DRTDevToolsAgent has a reference to the main WebView. So we
2032           should not clear it in closeDevTools() and should clear it in
2033           ~TestShell().
2034         - DRTDevToolsClient has a reference to a DevTools WebView and no
2035           way to update it. So we should delete DRTDevToolsClient instances
2036           in closeDevTools().
2037
2038         * DumpRenderTree/chromium/TestShell.cpp:
2039         (TestShell::~TestShell):
2040         (TestShell::closeDevTools):
2041
2042 2010-08-24  Eric Seidel  <eric@webkit.org>
2043
2044         Reviewed by Adam Barth.
2045
2046         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
2047         https://bugs.webkit.org/show_bug.cgi?id=44584
2048
2049         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2050
2051 2010-08-24  Eric Seidel  <eric@webkit.org>
2052
2053         Reviewed by Adam Barth.
2054
2055         commit-queue and EWS bots should report all failures
2056         https://bugs.webkit.org/show_bug.cgi?id=41820
2057
2058         Right now commit-queue/EWS only report failures when the
2059         patch under testing fails.  We should report all failures
2060         to the status server so that we can diagnose when the bots
2061         are wedged w/o needing to log into the machines.
2062
2063         I also reduced the amount of data we upload since we've seen
2064         timeouts during status upload.
2065
2066         * Scripts/webkitpy/common/system/executive.py:
2067         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2068         * Scripts/webkitpy/tool/commands/queues.py:
2069         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2070
2071 2010-08-24  Eric Seidel  <eric@webkit.org>
2072
2073         Reviewed by Adam Barth.
2074
2075         Remove HTML5 parser testing infrastructure now that we don't need it
2076         https://bugs.webkit.org/show_bug.cgi?id=44581
2077
2078         * DumpRenderTree/mac/DumpRenderTree.mm:
2079         (resetDefaultsToConsistentValues):
2080         (initializeGlobalsFromCommandLineOptions):
2081         * Scripts/old-run-webkit-tests:
2082         * Scripts/test-html5-parser: Removed.
2083
2084 2010-08-24  Kent Tamura  <tkent@chromium.org>
2085
2086         Reviewed by Dimitri Glazkov.
2087
2088         [DRT/Chromium] Fix 28 inspector test crashes
2089         https://bugs.webkit.org/show_bug.cgi?id=44574
2090
2091         Reset DevToolsClient and DevToolsAgent before closing a DevTools
2092         WebView in order to avoid accessing to a deleted WebView instance.
2093
2094         * DumpRenderTree/chromium/TestShell.cpp:
2095         (TestShell::closeDevTools):
2096
2097 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2098
2099         Reviewed by Ojan Vafai.
2100
2101         new-run-webkit-tests: clean up code for test_types, test_failures
2102
2103         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
2104         webkitpy.layout_tests.layout_package.test_failures, and remove
2105         some dead code and otherwise clean up things.
2106
2107         https://bugs.webkit.org/show_bug.cgi?id=44559
2108
2109         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2110         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
2111         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2112         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2113         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2114         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
2115         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2116
2117 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2118
2119         Reviewed by Eric Seidel.
2120
2121         new-run-webkit-tests: revise unit testing strategy for test failures
2122     
2123         This change revamps the way we store test data for new-run-webkit-tests.
2124         Previously we had a few copies of test files from the main test tree.
2125         Now we have a bunch of completely fake test data and use the test
2126         data to generate different kinds of test failures, getting
2127         much better coverage.
2128
2129         https://bugs.webkit.org/show_bug.cgi?id=44556
2130
2131         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
2132         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
2133         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
2134         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
2135         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
2136         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
2137         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
2138         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
2139         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
2140         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
2141         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
2142         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
2143         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
2144         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
2145         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
2146         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
2147         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
2148         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
2149         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
2150         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
2151         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
2152         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
2153         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
2154         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
2155         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
2156         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
2157         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
2158         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
2159         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
2160         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
2161         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
2162         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
2163         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
2164         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
2165         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
2166         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
2167         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
2168         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
2169         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
2170         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
2171         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
2172         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
2173         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
2174         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2175         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
2176         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
2177         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2178         * Scripts/webkitpy/layout_tests/port/test.py:
2179         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2180         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2181
2182 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2183
2184         Reviewed by Eric Seidel.
2185
2186         speed up new-run-webkit-tests unit tests
2187
2188         Add a --no-record-results flag that turns off generating the JSON
2189         results file on every test run. Generating the file requires us to
2190         fetch the old results down from the bots, which can be slow. This
2191         flag is off by default.
2192     
2193         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
2194     
2195         These changes together shorten the test cycle from ~4.5s to ~1.5s
2196         - a 3x speedup.
2197
2198         https://bugs.webkit.org/show_bug.cgi?id=44553
2199
2200         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2201         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2202
2203 2010-08-24  Tony Chang  <tony@chromium.org>
2204
2205         Reviewed by Eric Seidel.
2206
2207         [chromium] fix the platform result fallback order on mac/win
2208         https://bugs.webkit.org/show_bug.cgi?id=44483
2209
2210         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2211
2212 2010-08-24  Xan Lopez  <xlopez@igalia.com>
2213
2214         Reviewed by Martin Robinson.
2215
2216         Set a device to the event struct when building with GTK+ 3.x, it's
2217         mandatory.
2218
2219         * DumpRenderTree/gtk/EventSender.cpp:
2220         (keyDownCallback):
2221
2222 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2223
2224         Reviewed by Xan Lopez.
2225
2226         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2227         https://bugs.webkit.org/show_bug.cgi?id=44534
2228
2229         Fix two double-frees introduced in my previous commit.
2230
2231         * DumpRenderTree/gtk/EventSender.cpp:
2232         (contextClickCallback): Copy the event before using it again.
2233         (keyDownCallback): Ditto.
2234
2235 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2236
2237         Reviewed by Xan Lopez.
2238
2239         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2240         https://bugs.webkit.org/show_bug.cgi?id=44534
2241
2242         * DumpRenderTree/gtk/EventSender.cpp:
2243         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
2244         when setting it on the event. It is dereferenced by gdk_event_free(...).
2245         (contextClickCallback): Ditto.
2246         (mouseDownCallback): Ditto.
2247         (mouseUpCallback): Ditto.
2248         (mouseMoveToCallback): Ditto.
2249         (mouseWheelToCallback): Ditto.
2250         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
2251         (dispatchEvent): Ditto. Also free the event when we are done with it.
2252         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
2253
2254 2010-08-24  Andras Becsi  <abecsi@webkit.org>
2255
2256         [Qt] WebKit2 build fix.
2257
2258         * Scripts/enumerate-included-framework-headers:
2259         Remove stray global option form sed.
2260
2261 2010-08-24  Kent Tamura  <tkent@chromium.org>
2262
2263         Reviewed by Jeremy Orlow.
2264
2265         [DRT/Chromium] Support for IndexedDB tests
2266         https://bugs.webkit.org/show_bug.cgi?id=44490
2267
2268         * DumpRenderTree/chromium/TestShell.cpp:
2269         (TestShell::TestShell): Enable IndexedDB.
2270
2271 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
2272
2273         Reviewed by Gustavo Noronha Silva.
2274
2275         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
2276         https://bugs.webkit.org/show_bug.cgi?id=44465
2277
2278         Initialize the axes field of mouse button and motion events to null.
2279         This is the value that should be used for events originating from the
2280         mouse device.
2281
2282         * DumpRenderTree/gtk/EventSender.cpp:
2283         (prepareMouseButtonEvent): Initalize button event axes field to null.
2284         (mouseMoveToCallback): Initialize motion event axes field to null.
2285
2286 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2287
2288         Unreviewed, rolling out r65703.
2289         http://trac.webkit.org/changeset/65703
2290         https://bugs.webkit.org/show_bug.cgi?id=44460
2291
2292         "Causing lots of crashes on Snow Leopard when running the
2293         layout tests" (Requested by eseidel2 on #webkit).
2294
2295         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2296         (NP_Initialize):
2297         (NP_GetEntryPoints):
2298
2299 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
2300
2301         Layout tests do not run when using WebKitTestRunner in a Debug build.
2302         https://bugs.webkit.org/show_bug.cgi?id=44409
2303
2304         Reviewed by Dan Bernstein.
2305
2306         * WebKitTestRunner/win/TestControllerWin.cpp:
2307         (WTR::TestController::initializeInjectedBundlePath):
2308         Use InjectedBundle_debug.dll when building Debug.
2309
2310 2010-08-23  Xan Lopez  <xlopez@igalia.com>
2311
2312         Reviewed by Martin Robinson.
2313
2314         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
2315         https://bugs.webkit.org/show_bug.cgi?id=42026
2316
2317         If a GTK+ 3.x build is present return that as the library to use,
2318         otherwise fallback to the GTK+ 2.x build.
2319
2320         * Scripts/webkitdirs.pm:
2321
2322 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
2323
2324         Reviewed by Ariya Hidayat.
2325
2326         [Qt] Find needed forwarding headers for WebKit2 automatically
2327         https://bugs.webkit.org/show_bug.cgi?id=44336
2328
2329         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
2330         The new script does not satisfy the needs of this file however using normal includes
2331         is generally better here.
2332         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
2333         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
2334         given frameworks by files in the current directory (and subdirectories).
2335         In the future this needs to be rewritten in perl for being able to use on Windows.
2336
2337 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
2338
2339         Reviewed by Ariya Hidayat.
2340
2341         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
2342         https://bugs.webkit.org/show_bug.cgi?id=43010
2343
2344         * QtTestBrowser/launcherwindow.cpp:
2345         (LauncherWindow::applyPrefs):
2346         * QtTestBrowser/main.cpp:
2347         (LauncherApplication::handleUserOptions):
2348
2349 2010-08-21  Sam Weinig  <sam@webkit.org>
2350
2351         Reviewed by Dan Bernstein.
2352
2353         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
2354         https://bugs.webkit.org/show_bug.cgi?id=44386
2355
2356         * MiniBrowser/mac/AppDelegate.m:
2357         (didRecieveMessageFromInjectedBundle):
2358         (didNavigateWithNavigationData):
2359         (-[BrowserAppDelegate init]):
2360         (-[BrowserAppDelegate applicationWillTerminate:]):
2361         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2362         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
2363         (-[BrowserStatisticsWindowController dealloc]):
2364         * MiniBrowser/mac/BrowserWindowController.m:
2365         (-[BrowserWindowController initWithPageNamespace:]):
2366         (-[BrowserWindowController fetch:]):
2367         (-[BrowserWindowController windowWillClose:]):
2368         (-[BrowserWindowController applicationTerminating]):
2369         (closePage):
2370         (runJavaScriptAlert):
2371         (runJavaScriptConfirm):
2372         (runJavaScriptPrompt):
2373         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2374         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2375         (didClearWindowObjectForFrame):
2376         * MiniBrowser/win/BrowserView.cpp:
2377         (BrowserView::goToURL):
2378         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2379         (WTR::PlatformWebView::~PlatformWebView):
2380
2381 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
2382
2383         Reviewed by Kenneth Rohde Christiansen.
2384
2385         WebKit does not build with Python 2.3
2386         https://bugs.webkit.org/show_bug.cgi?id=44373
2387
2388         Replaced the function sorted() by a call to sort()
2389         on the entry list.
2390         The function sorted() has been added to Python 2.4.
2391         The function method sort() of List works with older
2392         versions of Python.
2393
2394         * Scripts/create-html-entity-table:
2395
2396 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
2397
2398         Reviewed by Pavel Feldman.
2399
2400         Web Inspector: Inspector tests were disabled for GTK.
2401         https://bugs.webkit.org/show_bug.cgi?id=43977
2402
2403         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
2404         path before running tests.
2405
2406 2010-08-20  Daniel Bates  <dbates@rim.com>
2407
2408         Reviewed by Eric Seidel.
2409
2410         svn-apply doesn't detect empty line with Windows line endings
2411         after property value
2412         https://bugs.webkit.org/show_bug.cgi?id=43981
2413
2414         Part 2 of 2
2415
2416         Add unit tests that were not landed in the first commit.
2417
2418         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2419           - Added the following test cases:
2420             "SVN: binary file (isBinary true) using Windows line endings"
2421             "SVN: property diff, followed by file change diff using Windows line endings"
2422             "SVN: two consecutive property diffs using Windows line endings"
2423             "SVN: binary file with executable bit change usng Windows line endings"
2424             "SVN: binary file followed by property change on different file using Windows line endings"
2425             "SVN: binary file followed by file change on different file using Windows line endings"
2426             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2427             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2428         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2429           - Added the following test cases:
2430             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2431             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2432             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2433             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2434             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2435             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2436             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2437             "single-line '+' with trailing new line using Windows line endings"
2438             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2439             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2440             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2441         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2442           - Added the following test cases:
2443             "single-line '-' change followed by empty line with Windows line endings"
2444             "multi-line '+' change and start of binary patch with Windows line endings"
2445
2446 2010-08-20  Daniel Bates  <dbates@rim.com>
2447
2448         Reviewed by Eric Seidel.
2449
2450         svn-apply doesn't detect empty line with Windows line endings
2451         after property value
2452         https://bugs.webkit.org/show_bug.cgi?id=43981
2453
2454         Fixes an issue where an empty line following the property value
2455         in an SVN property change diff would not be detected if it had
2456         Windows line endings (i.e. ended in CRLF). Hence it was consumed
2457         as if it was part of a multi-line property value. 
2458
2459         * Scripts/VCSUtils.pm:
2460           - Modified parseSvnPropertyValue() to detect empty line
2461             with Windows line endings.
2462           - Added toWindowsLineEndings().
2463         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2464           - Added the following test cases:
2465             "SVN: binary file (isBinary true) using Windows line endings"
2466             "SVN: property diff, followed by file change diff using Windows line endings"
2467             "SVN: two consecutive property diffs using Windows line endings"
2468             "SVN: binary file with executable bit change usng Windows line endings"
2469             "SVN: binary file followed by property change on different file using Windows line endings"
2470             "SVN: binary file followed by file change on different file using Windows line endings"
2471             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2472             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2473         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2474           - Added the following test cases:
2475             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2476             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2477             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2478             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2479             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2480             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2481             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2482             "single-line '+' with trailing new line using Windows line endings"
2483             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2484             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2485             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2486         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2487           - Added the following test cases:
2488             "single-line '-' change followed by empty line with Windows line endings"
2489             "multi-line '+' change and start of binary patch with Windows line endings"
2490
2491 2010-08-19  David Kilzer  <ddkilzer@apple.com>
2492
2493         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
2494
2495         * MiniBrowser/mac/BrowserWindowController.m:
2496         (decidePolicyForNavigationAction): Updated method signature.
2497         (decidePolicyForNewWindowAction): Updated method signature.
2498
2499 2010-08-19  Adam Roben  <aroben@apple.com>
2500
2501         Test that NP_Initialize and NP_GetEntryPoints are called in the
2502         correct order
2503
2504         The order differs between Mac and Windows (see r38858).
2505
2506         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
2507         NP_Initialize when loading QuickTime when running
2508         plugins/embed-attributes-setting.html in WebKit2 on Windows
2509
2510         Reviewed by Sam Weinig.
2511
2512         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
2513         a boolean to record whether NP_GetEntryPoints has been called.
2514         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
2515         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
2516         if NP_GetEntryPoints has been called already. This matches
2517         Silverlight's behavior.
2518
2519 2010-08-19  Adam Roben  <aroben@apple.com>
2520
2521         Make build-webkittestrunner build TestNetscapePlugIn on Windows
2522
2523         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
2524
2525         Reviewed by Sam Weinig.
2526
2527         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
2528         Threaded it in between ImageDiff and InjectedBundleGenerated.
2529
2530 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2531
2532         Reviewed by Adam Barth.
2533
2534         install rietveld's upload script from a versioned url
2535         https://bugs.webkit.org/show_bug.cgi?id=44291
2536
2537         autoinstall expects the file at a given URL to never change.
2538         In order to be able to update the file, we need to be able to
2539         change the path.
2540
2541         * Scripts/webkitpy/thirdparty/__init__.py:
2542
2543 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2544
2545         Reviewed by Adam Barth.
2546
2547         add --webkit_patch_id to reitveld uploads
2548         https://bugs.webkit.org/show_bug.cgi?id=44289
2549
2550         This is the first step in having rietveld store which
2551         patches have been uploaded and getting rid of the
2552         in-rietveld flag.
2553
2554         * Scripts/webkitpy/common/net/rietveld.py:
2555         * Scripts/webkitpy/tool/mocktool.py:
2556         * Scripts/webkitpy/tool/steps/postcodereview.py:
2557
2558 2010-08-19  Kenneth Russell  <kbr@google.com>
2559
2560         Reviewed by David Levin.
2561
2562         Adjust my status from committer to reviewer
2563         https://bugs.webkit.org/show_bug.cgi?id=44277
2564
2565         * Scripts/webkitpy/common/config/committers.py:
2566
2567 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2568
2569         Reviewed by Yury Semikhatsky.
2570
2571         Chromium DevTools: remove injected script fetcher from test harness.
2572         https://bugs.webkit.org/show_bug.cgi?id=44266
2573
2574         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2575         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2576
2577 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2578
2579         Reviewed by Yury Semikhatsky.
2580
2581         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
2582         Now that we populate front-end after its onload handler, we don't need
2583         to install injected script early. Exposing injected script source on the WebCore
2584         level here.
2585         https://bugs.webkit.org/show_bug.cgi?id=44029
2586
2587         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2588         (DRTDevToolsAgent::runtimePropertyChanged):
2589         (DRTDevToolsAgent::delayedFrontendLoaded):
2590         (DRTDevToolsAgent::frontendLoaded):
2591         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2592
2593 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2594
2595         Reviewed by Kenneth Rohde Christiansen.
2596
2597         [Gtk] Enable view mode media feature layout test
2598         https://bugs.webkit.org/show_bug.cgi?id=43278
2599
2600         Add view mode media feature testing infrastructure, and add
2601         placeholder methods for the other platforms'
2602         LayoutTestControllers.
2603
2604         * DumpRenderTree/LayoutTestController.cpp:
2605         (setViewModeMediaFeatureCallback):
2606         (LayoutTestController::staticFunctions):
2607         * DumpRenderTree/LayoutTestController.h:
2608         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2609         (LayoutTestController::setViewModeMediaFeature):
2610         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2611         (LayoutTestController::setViewModeMediaFeature):
2612         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2613         (LayoutTestController::setViewModeMediaFeature):
2614         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2615         (LayoutTestController::setViewModeMediaFeature):
2616
2617 2010-08-18  Mark Rowe  <mrowe@apple.com>
2618
2619         Reviewed by Sam Weinig.
2620
2621         Make it so the WebKit2 test slave runs the WebKit2 tests
2622
2623         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2624
2625 2010-08-18  Sam Weinig  <sam@webkit.org>
2626
2627         Reviewed by Mark Rowe.
2628
2629         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
2630         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
2631         module and the TestNetscapePlugin.
2632
2633         * Scripts/old-run-webkit-tests:
2634
2635 2010-08-18  Adam Roben  <aroben@apple.com>
2636
2637         Fix hang when saving crash logs on Windows
2638
2639         * Scripts/old-run-webkit-tests:
2640         (setUpWindowsCrashLogSaving):
2641         (END):
2642         Pass -s to regtool so it will write the Auto value as a string instead
2643         of as a number. This was causing a "do you want to debug?" dialog to
2644         appear.
2645
2646 2010-08-17  Victor Wang  <victorw@chromium.org>
2647
2648         Unreviewed. Fixed chromium incremental test json upload.
2649         Quote builder name and test results server in url.
2650
2651         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2652
2653 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2654
2655         Reviewed by Ariya Hidayat.
2656
2657         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
2658         https://bugs.webkit.org/show_bug.cgi?id=44124
2659
2660         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
2661         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
2662         Symbian dependencies.
2663
2664         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2665         (WebCore::DumpRenderTree::open):
2666         * QtTestBrowser/launcherwindow.cpp:
2667         (LauncherWindow::init):
2668         (LauncherWindow::toggleFullScreenMode):
2669         (LauncherWindow::showFPS):
2670         (LauncherWindow::updateFPS):
2671         * QtTestBrowser/launcherwindow.h:
2672         (WindowOptions::WindowOptions):
2673         * QtTestBrowser/mainwindow.cpp:
2674         (MainWindow::buildUI):
2675
2676 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2677
2678         Reviewed by David Levin.
2679
2680         new-run-webkit-tests: remove --show-sources option
2681
2682         --show-sources is pretty much obsolete with --trace everything, so
2683         I'm removing it.
2684
2685         Also rename a couple of methods in the TestTextDiff class to make their
2686         intended visibility (private) more obvious.
2687
2688         https://bugs.webkit.org/show_bug.cgi?id=44143
2689
2690         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2691         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2692         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2693         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2694         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2695
2696 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2697
2698         Reviewed by David Levin.
2699
2700         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
2701
2702         This code bit-rotted at some point more than a year ago, and nobody seems
2703         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
2704         should support instead, making this flag unnecessary anyway.
2705
2706         https://bugs.webkit.org/show_bug.cgi?id=44141
2707
2708         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2710         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
2711
2712 2010-08-17  Victor Wang  <victorw@chromium.org>
2713
2714         Reviewed by Ojan Vafai.
2715
2716         Update json results generator to have incremental json including
2717         results for tests that pass in current run but failed before.
2718
2719         https://bugs.webkit.org/show_bug.cgi?id=44119
2720
2721         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2722         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2723         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2724
2725 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2726
2727         Reviewed by Eric Seidel.
2728
2729         fix test-webkitpy, add easy way to find a checkout root
2730
2731         test-webkitpy currently doesn't work right if run from someplace other
2732         than the checkout root, and it spews a bunch of debug logging because
2733         the deduplicate_tests tests contaminates the test environment.
2734
2735         This patch cleans up the deduplicate_tests unit tests, and creates
2736         two new methods in scm.py: find_checkout_root() and default_scm(),
2737         both of which use a single algorithm for guessing what checkout root
2738         to use if you aren't explicitly told one from a path.
2739
2740         https://bugs.webkit.org/show_bug.cgi?id=44001
2741
2742         * Scripts/deduplicate-tests:
2743         * Scripts/webkitpy/common/checkout/scm.py:
2744         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2745         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2746         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2747         * Scripts/webkitpy/layout_tests/port/test.py:
2748         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2749         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2750         * Scripts/webkitpy/tool/main.py:
2751
2752 2010-08-17  Victor Wang  <victorw@chromium.org>
2753
2754         Reviewed by Ojan Vafai.
2755
2756         Add support to the test results server for downloading json that
2757         contains test list only.
2758
2759         This is for json results generator to generate incremental json
2760         results so that it includes results not only for tests failed in
2761         current run, but also tests failed before.
2762
2763         Also set the results type to "N" (no data) instead of "P" (pass)
2764         if test results cannot be found in incremental json file.
2765
2766         https://bugs.webkit.org/show_bug.cgi?id=44117
2767
2768         * TestResultServer/handlers/testfilehandler.py:
2769         * TestResultServer/model/jsonresults.py:
2770         * TestResultServer/model/jsonresults_unittest.py:
2771
2772 2010-08-17  Adam Roben  <aroben@apple.com>
2773
2774         Use the right path style
2775
2776         * Scripts/old-run-webkit-tests:
2777
2778 2010-08-17  Adam Roben  <aroben@apple.com>
2779
2780         Fix typo
2781
2782         * Scripts/old-run-webkit-tests:
2783
2784 2010-08-17  Adam Roben  <aroben@apple.com>
2785
2786         Don't hang when running run-webkit-tests as a non-Administrator on
2787         Vista/7
2788
2789         * Scripts/old-run-webkit-tests:
2790         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
2791         post-mortem debugger, rather than using NTSD itself. The latter waits
2792         for user input when it fails to set the registry values; the former
2793         does not.
2794
2795 2010-08-17  Adam Roben  <aroben@apple.com>
2796
2797         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
2798         save crash logs on Windows
2799
2800         The crash logs are saved to /tmp/layout-test-results and have names
2801         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
2802
2803         Unfortunately, crashes in the WebKit2 web process are recorded as
2804         time-outs by run-webkit-tests. Fixing this is covered by
2805         <http://webkit.org/b/44121>.
2806
2807         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
2808         DumpRenderTree should save a stack trace and/or dump file when it
2809         crashes
2810
2811         Reviewed by Sam Weinig.
2812
2813         * DumpRenderTree/win/DumpRenderTree.cpp:
2814         (exceptionFilter):
2815         (main):
2816         * WebKitTestRunner/win/TestControllerWin.cpp:
2817         (WTR::exceptionFilter):
2818         (WTR::TestController::platformInitialize):
2819         These changes set up an exception filter that prints #CRASHED to
2820         stderr, then lets the exception propagate normally. This allows
2821         run-webkit-tests to detect when we've crashed even when a post-mortem
2822         debugger attaches to the process.
2823
2824         * Scripts/old-run-webkit-tests:
2825         (top level): Declared some variables used by the crash-log-saving
2826         code.
2827         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
2828         that the post-mortem debugger has access to it.
2829         (toCygwinPath): Added. This is the opposite of toWindowsPath.
2830         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
2831         stderr, consider it a crash.
2832         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
2833         debugger, then sets ntsd as the post-mortem debugger. ntsd is
2834         configured to save a crash log and then quit automatically.
2835         (END): Added. Restores the previous post-mortem debugger when the
2836         script exits.
2837
2838 2010-08-17  Victor Wang  <victorw@chromium.org>
2839
2840         Reviewed by ojan@chromium.org.
2841
2842         Update test results server:
2843         1. Normalize test results and times after merging (prune tests where
2844            all runs pass or do not have data, truncate all test items to max
2845            number of builds)
2846         2. times should be int not string.
2847         3. when inserting a new test item, should keep old data regardless
2848            whether or not they have same item type with new one.
2849
2850         https://bugs.webkit.org/show_bug.cgi?id=43861
2851
2852         * TestResultServer/model/jsonresults.py:
2853         * TestResultServer/model/jsonresults_unittest.py:
2854
2855 2010-08-16  Sam Weinig  <sam@webkit.org>
2856
2857         Reviewed by Mark Rowe.
2858
2859         Add WebKit2 Mac tester to buildbot.
2860
2861         * BuildSlaveSupport/build.webkit.org-config/config.json:
2862         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2863
2864 2010-08-16  Paul Sawaya  <psawaya@apple.com>
2865
2866         Reviewed by Chris Marrin.
2867
2868         Added shader validation via ANGLE
2869         https://bugs.webkit.org/show_bug.cgi?id=42405
2870
2871         Added ANGLE to webkit build
2872
2873         * Scripts/build-webkit:
2874
2875 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
2876
2877         [wx] Build fix, do not build WebCore as a convenience library as this leads to
2878         errors in the Win build w/export symbols and causes problems with DOM bindings
2879         debugging in gdb.
2880
2881         * DumpRenderTree/wscript:
2882         * Scripts/build-webkit:
2883         * wx/browser/wscript:
2884         * wx/build/settings.py:
2885         * wx/build/waf_extensions.py:
2886
2887 2010-08-16  Dan Bernstein  <mitz@apple.com>
2888
2889         Build fix.
2890
2891         * WebKitTestRunner/TestController.cpp:
2892         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
2893         (WTR::TestController::initialize): Ditto.
2894
2895 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2896
2897         Reviewed by Kenneth Rohde Christiansen.
2898
2899         Handle content size change in WebKit2
2900         Re-landing after fix.
2901
2902         https://bugs.webkit.org/show_bug.cgi?id=43198
2903
2904         * MiniBrowser/mac/BrowserWindowController.m:
2905         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2906         * MiniBrowser/win/BrowserView.cpp:
2907         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2908
2909 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2910
2911         Unreviewed, rolling out r65419.
2912         http://trac.webkit.org/changeset/65419
2913         https://bugs.webkit.org/show_bug.cgi?id=44053
2914
2915         Broke the Windows build (Requested by bbandix on #webkit).
2916
2917         * MiniBrowser/mac/BrowserWindowController.m:
2918         (-[BrowserWindowController awakeFromNib]):
2919         * MiniBrowser/win/BrowserView.cpp:
2920         (BrowserView::create):
2921
2922 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2923
2924         Reviewed by Kenneth Rohde Christiansen.
2925
2926         Handle content size change in WebKit2
2927
2928         https://bugs.webkit.org/show_bug.cgi?id=43198
2929
2930         * MiniBrowser/mac/BrowserWindowController.m:
2931         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2932         * MiniBrowser/win/BrowserView.cpp:
2933         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2934
2935 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
2936
2937         Add my new email address to committers.py.
2938
2939         * Scripts/webkitpy/common/config/committers.py:
2940
2941 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
2942
2943         Add my old e-mail addresses to committers.py.
2944
2945         * Scripts/webkitpy/common/config/committers.py:
2946
2947 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2948
2949         WebEditorClient::didBeginEditing is never called in WebKit2
2950         https://bugs.webkit.org/show_bug.cgi?id=42939
2951
2952         Reviewed by Sam Weinig.
2953
2954         * WebKitTestRunner/PlatformWebView.h:
2955         Declare focus().
2956
2957         * WebKitTestRunner/TestController.cpp:
2958         (WTR::TestController::resetStateToConsistentValues):
2959         Focus the PlatformWebView.
2960
2961         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2962         (WTR::PlatformWebView::focus):
2963         Stubbed.
2964
2965         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2966         (WTR::PlatformWebView::focus):
2967         Focus the view.
2968
2969 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2970
2971         run-webkit-tests should not strip editing callbacks when using
2972         WebKitTestRunner on Windows
2973         https://bugs.webkit.org/show_bug.cgi?id=44000
2974
2975         Reviewed by Mark Rowe.
2976
2977         * Scripts/old-run-webkit-tests:
2978         Leave $stripEditingCallbacks undefined until we look for command-line
2979         arguments. If using WebKit2, set it to 0 if not explicity set on the
2980         command line. Later, set it to isCygwin() to match old behavior if it is
2981         not yet defined.
2982
2983 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
2984
2985         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
2986
2987         * wx/build/settings.py:
2988
2989 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
2990
2991         Reviewed by Kenneth Rohde Christiansen.
2992
2993         [GTK] autogen.sh not executed if build-webkit options change
2994         https://bugs.webkit.org/show_bug.cgi?id=42266
2995
2996         Rerun autogen.sh in situations where the arguments to build-webkit have
2997         changed since the previous build. This will fix some issues on the bots
2998         where the build does not notice changes to default build-webkit arguments.
2999
3000         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
3001
3002 2010-08-14  Eric Seidel  <eric@webkit.org>
3003
3004         Unreviewed.  Another fix to support python 2.3.
3005
3006         Add support for MathML entities
3007         https://bugs.webkit.org/show_bug.cgi?id=43949
3008
3009         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
3010          - It looks like our simplejson is version 1.7.3 which
3011            should be python 2.3 compatible.  But someone modified
3012            our copy slightly from the original source.
3013            I've removed the relative import in hopes this fixes
3014            the problem.
3015
3016 2010-08-13  Eric Seidel  <eric@webkit.org>
3017
3018         Unreviewed.  Build fix only.
3019
3020         Add support for MathML entities
3021         https://bugs.webkit.org/show_bug.cgi?id=43949
3022
3023         * Scripts/create-html-entity-table:
3024          - Hack sys.path to avoid executing 2.5 dependent python
3025            on systems (like chromium-win and Tiger) which do not have 2.5 python.
3026
3027 2010-08-13  Adam Barth  <abarth@webkit.org>
3028
3029         Reviewed by Eric Seidel.
3030
3031         Rename some concepts in HTML entity search to be more self-documenting
3032         https://bugs.webkit.org/show_bug.cgi?id=44004
3033
3034         Reflect name change in generator script.
3035
3036         * Scripts/create-html-entity-table:
3037
3038 2010-08-12  Adam Barth  <abarth@webkit.org>
3039
3040         Reviewed by Eric Seidel.
3041
3042         Add support for MathML entities
3043         https://bugs.webkit.org/show_bug.cgi?id=43949
3044
3045         A script for generating the C++ state data structure describing all the
3046         entities from a JSON description.
3047
3048         * Scripts/create-html-entity-table: Added.
3049
3050 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
3051
3052         Reviewed by Eric Seidel.
3053
3054         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
3055         check for exceptions on all threads, not just the first thread.
3056         
3057         This change also changes the logging behavior for wedged threads
3058         to only dump the stacks of threads that are actually wedged.
3059
3060         Refactor the thread classes in the dump_render_tree_thread module
3061         to make the contract between TestRunner and TestShellThread clearer.
3062
3063         Added a bunch of unit tests.
3064         https://bugs.webkit.org/show_bug.cgi?id=38561
3065
3066         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3067         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3068         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3069
3070 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
3071
3072         Reviewed by Shinichiro Hamaji.
3073
3074         Add test_expectations.txt syntax checker to check-webkit-style.
3075         https://bugs.webkit.org/show_bug.cgi?id=43899
3076
3077         Just utilizing layout_tests/layout_package/test_expectations.py for checking
3078         the syntax of test_expectations.txt.
3079         This change also moves tab checking class from style/checkers/text.py to
3080         style/checkers/common.py for sharing code.
3081
3082         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3083         * Scripts/webkitpy/style/checker.py:
3084         * Scripts/webkitpy/style/checkers/common.py:
3085         * Scripts/webkitpy/style/checkers/common_unittest.py:
3086         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
3087         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
3088         * Scripts/webkitpy/style/checkers/text.py:
3089         * Scripts/webkitpy/style_references.py:
3090
3091 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3092
3093         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
3094         https://bugs.webkit.org/show_bug.cgi?id=43945
3095
3096         Reviewed by Sam Weinig.
3097
3098         * WebKitTestRunner/TestInvocation.cpp:
3099         (WTR::sizeWebViewForCurrentTest):
3100         Allow for a Windows-style path.
3101
3102         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3103         (WTR::PlatformWebView::resizeTo):
3104         Call SetWindowPos to resize the view window.
3105
3106 2010-08-12  David Levin  <levin@chromium.org>
3107
3108         Build break fix.
3109
3110         * WebKitTestRunner/TestController.cpp:
3111         (WTR::TestController::resetStateToConsistentValues): Removed usage
3112         of a variable that doesn't exist in the class.
3113
3114 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3115
3116         WebKitTestRunner needs to run tests without using native controls
3117         https://bugs.webkit.org/show_bug.cgi?id=43772
3118
3119         Reviewed by Sam Weinig.
3120
3121         * WebKitTestRunner/TestController.cpp:
3122         (WTR::TestController::initialize):
3123         Call platformInitializeContext().
3124
3125         * WebKitTestRunner/TestController.h:
3126         Declare platformInitializeContext().
3127
3128         * WebKitTestRunner/mac/TestControllerMac.mm:
3129         (WTR::TestController::platformInitializeContext):
3130         Stubbed.
3131
3132         * WebKitTestRunner/win/TestControllerWin.cpp:
3133         (WTR::TestController::platformInitializeContext):
3134         Call WKContextSetShouldPaintNativeControls() to disable native control
3135         drawing.
3136
3137 2010-08-12  Sam Weinig  <sam@webkit.org>
3138
3139         Reviewed by Alexey Proskuryakov.
3140
3141         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
3142         https://bugs.webkit.org/show_bug.cgi?id=43653
3143
3144         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3145         (WTR::InjectedBundle::InjectedBundle):
3146         (WTR::InjectedBundle::didReceiveMessage):
3147         (WTR::InjectedBundle::beginTesting):
3148         (WTR::InjectedBundle::done):
3149         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3150         (WTR::InjectedBundle::isTestRunning):
3151         (WTR::InjectedBundle::):
3152         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3153         (WTR::InjectedBundlePage::stopLoading):
3154         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3155         (WTR::InjectedBundlePage::dump):
3156         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3157         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3158         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3159         (WTR::InjectedBundlePage::didClearWindowForFrame):
3160         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3161         (WTR::InjectedBundlePage::willAddMessageToConsole):
3162         (WTR::InjectedBundlePage::willSetStatusbarText):
3163         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3164         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3165         (WTR::InjectedBundlePage::shouldBeginEditing):
3166         (WTR::InjectedBundlePage::shouldEndEditing):
3167         (WTR::InjectedBundlePage::shouldInsertNode):
3168         (WTR::InjectedBundlePage::shouldInsertText):
3169         (WTR::InjectedBundlePage::shouldDeleteRange):
3170         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3171         (WTR::InjectedBundlePage::shouldApplyStyle):
3172         (WTR::InjectedBundlePage::didBeginEditing):
3173         (WTR::InjectedBundlePage::didEndEditing):
3174         (WTR::InjectedBundlePage::didChange):
3175         (WTR::InjectedBundlePage::didChangeSelection):
3176         Don't do any work if we are not currently running a test.
3177
3178         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3179         * WebKitTestRunner/StringFunctions.h:
3180         (WTR::toCF):
3181         Add conversion function for WKURLRef -> CFURLRef
3182
3183         * WebKitTestRunner/TestController.cpp:
3184         (WTR::TestController::TestController):
3185         (WTR::TestController::initialize):
3186         (WTR::TestController::resetStateToConsistentValues):
3187         (WTR::TestController::runTest):
3188         (WTR::TestController::didFinishLoadForFrame):
3189         * WebKitTestRunner/TestController.h:
3190         (WTR::TestController::):
3191         * WebKitTestRunner/TestInvocation.cpp:
3192         (WTR::TestInvocation::invoke):
3193         * WebKitTestRunner/TestInvocation.h:
3194         Move resetting code to TestController.
3195
3196         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3197         * WebKitTestRunner/mac/TestControllerMac.mm:
3198         (WTR::TestController::runUntil):
3199         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3200         * WebKitTestRunner/win/TestControllerWin.cpp:
3201         (WTR::TestController::runUntil):
3202         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
3203         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3204         Move runUntil to TestController.
3205
3206 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3207
3208         Unreviewed.
3209
3210         Adding myself to the committers list.
3211
3212         * Scripts/webkitpy/common/config/committers.py:
3213
3214 2010-08-12  Hayato Ito  <hayato@chromium.org>
3215
3216         Reviewed by Tony Chang.
3217
3218         Merge pretty printers for gdb.
3219         https://bugs.webkit.org/show_bug.cgi?id=43850
3220
3221         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
3222         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
3223         webcore.py is left for backward compatibility.
3224
3225         * gdb/webcore.py:
3226         * gdb/webkit.py: Added.
3227         * gdb/wtf.py: Removed.
3228
3229 2010-08-11  Tony Chang  <tony@chromium.org>
3230
3231         Reviewed by David Levin.
3232
3233         [chromium] add google-chrome layout test result directories
3234         https://bugs.webkit.org/show_bug.cgi?id=43889
3235
3236         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3237         * Scripts/webkitpy/layout_tests/port/factory.py:
3238         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
3239         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3240
3241 2010-08-11  Kent Tamura  <tkent@chromium.org>
3242
3243         Reviewed by Dimitri Glazkov.
3244
3245         [DRT/Chromium] Disable accelerated compositing
3246         https://bugs.webkit.org/show_bug.cgi?id=43894
3247
3248         Disable accelerated compositing because DRT is not ready for
3249         it. This change fixes hundreds of test crashes on Windows and
3250         Linux.
3251
3252         * DumpRenderTree/chromium/TestShell.cpp:
3253         (TestShell::resetWebSettings):
3254
3255 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3256
3257         Unreviewed. Adding my Collabora personality to the list.
3258
3259         * Scripts/webkitpy/common/config/committers.py:
3260
3261 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
3262
3263         Adding myself as a reviewer.
3264
3265         * Scripts/webkitpy/common/config/committers.py:
3266
3267 2010-08-11  Daniel Bates  <dbates@rim.com>
3268
3269         Reviewed by Darin Adler.
3270
3271         Perl warnings when running commit-log-editor
3272         https://bugs.webkit.org/show_bug.cgi?id=43856
3273
3274         Fixes Perl warnings introduced by the patch for Bug #40548.
3275
3276         Perl doesn't have symbolic names for True/False. Instead, we
3277         should use boolean values. Moreover, the variable installedEditorApplication
3278         is not be used and should be renamed builtEditorApplication so that it
3279         uses the existing machinery to set the commit log editor application.
3280
3281         * Scripts/commit-log-editor:
3282
3283 2010-08-11  Adam Barth  <abarth@webkit.org>
3284
3285         Reviewed by Eric Seidel.
3286
3287         Trying waiting for httpd lock in the EWS
3288         https://bugs.webkit.org/show_bug.cgi?id=43833
3289
3290         If this works, we can probably run the tests on the mac-ews, which
3291         would be very exciting.  :)
3292
3293         * Scripts/webkitpy/tool/steps/runtests.py:
3294
3295 2010-08-11  Marcus Bulach  <bulach@chromium.org>
3296
3297         Reviewed by Eric Seidel.
3298
3299         Check in a script to list redundant test outputs.
3300         https://bugs.webkit.org/show_bug.cgi?id=37630
3301
3302         If e.g. platform/mac-leopard is missing an expected test output, we
3303         fall back on platform/mac.  This means it's possible to grow redundant
3304         test outputs, where we have the same expected data in both a platform
3305         directory and another platform it falls back on.
3306         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
3307
3308         * Scripts/deduplicate-tests: Added.
3309         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
3310         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
3311
3312 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3313
3314         Reviewed by Ariya Hidayat.
3315
3316         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
3317         https://bugs.webkit.org/show_bug.cgi?id=43853
3318
3319         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
3320         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
3321         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
3322         to slots at all.
3323
3324         * QtTestBrowser/launcherwindow.cpp:
3325         (LauncherWindow::createChrome):
3326         (LauncherWindow::animatedFlip):
3327         (LauncherWindow::animatedYFlip):
3328         * QtTestBrowser/launcherwindow.h:
3329
3330 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3331
3332         Reviewed by Simon Hausmann.
3333
3334         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
3335         https://bugs.webkit.org/show_bug.cgi?id=43851
3336
3337         All window options data (including the bool holding if the view is either QWebView or
3338         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
3339         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
3340         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
3341         getting broken.
3342
3343         Patch addresses this issue.
3344
3345         * QtTestBrowser/launcherwindow.cpp:
3346         (LauncherWindow::createChrome):
3347         (LauncherWindow::toggleWebView):
3348         (LauncherWindow::toggleAcceleratedCompositing):
3349
3350 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
3351
3352         Reviewed by Ariya Hidayat.
3353
3354         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
3355         https://bugs.webkit.org/show_bug.cgi?id=43831
3356
3357         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
3358
3359         * QtTestBrowser/webview.cpp:
3360         (WebViewGraphicsBased::WebViewGraphicsBased):
3361         (WebViewGraphicsBased::animatedYFlip):
3362
3363 2010-08-11  Darin Adler  <darin@apple.com>
3364
3365         Reviewed by John Sullivan.
3366
3367         Improved editor options for prepare-ChangeLog and commit-log-editor
3368         https://bugs.webkit.org/show_bug.cgi?id=40548
3369
3370         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
3371         values like "xed --launch --wait" work properly.
3372
3373         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
3374         use a command line tool with the $openChangeLogs feature.
3375
3376 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
3377
3378         Reviewed by Pavel Feldman.
3379
3380         Web Inspector: remove InjectDispatch.js
3381         https://bugs.webkit.org/show_bug.cgi?id=43835
3382
3383         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3384         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3385
3386 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
3387
3388         Reviewed by Eric Seidel.
3389
3390         webkit-patch should refuse to run under Win32 Python
3391         https://bugs.webkit.org/show_bug.cgi?id=40962
3392
3393         Given that there are lots of places in webkit-patch's code that
3394         assume unix-style filenames (forward slashes), webkit-patch fails
3395         with weird file-not-found errors when run under a native windows
3396         Python. It would be nice if we just trapped this and errored out
3397         at the beginning, rather than producing unpredictable errors.
3398
3399         * Scripts/webkit-patch:
3400
3401 2010-08-10  Kent Tamura  <tkent@chromium.org>
3402
3403         Unreviewed, build fix.
3404         
3405         Chromium build fix for r65107.
3406
3407         * DumpRenderTree/chromium/LayoutTestController.cpp:
3408         (LayoutTestController::suspendAnimations):
3409         (LayoutTestController::resumeAnimations):
3410
3411 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
3412
3413         Reviewed by Xan Lopez.
3414
3415         [GTK] http/tests/media/video-cookie.html fails
3416         https://bugs.webkit.org/show_bug.cgi?id=42240
3417
3418         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3419         (LayoutTestController::setAlwaysAcceptCookies): create the
3420         SoupCookieJar if it does not exist. Otherwise the accept policy
3421         won't be set.
3422
3423 2010-08-10  Chris Marrin  <cmarrin@apple.com>
3424
3425         Reviewed by Oliver Hunt.
3426
3427         Add suspendAnimations/resumeAnimation API to DRT
3428         https://bugs.webkit.org/show_bug.cgi?id=43733
3429         
3430         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
3431         Calls functions with the same names on AnimationController for the 
3432         mainFrame.
3433
3434         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3435         * DumpRenderTree/LayoutTestController.cpp:
3436         (suspendAnimationsCallback):
3437         (resumeAnimationsCallback):
3438         (LayoutTestController::staticFunctions):
3439         * DumpRenderTree/LayoutTestController.h:
3440         * DumpRenderTree/chromium/LayoutTestController.cpp:
3441         (LayoutTestController::LayoutTestController):
3442         (LayoutTestController::suspendAnimations):
3443         (LayoutTestController::resumeAnimations):
3444         * DumpRenderTree/chromium/LayoutTestController.h:
3445         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3446         (LayoutTestController::suspendAnimations):
3447         (LayoutTestController::resumeAnimations):
3448         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3449         (LayoutTestController::suspendAnimations):
3450         (LayoutTestController::resumeAnimations):
3451         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3452         (LayoutTestController::suspendAnimations):
3453         (LayoutTestController::resumeAnimations):
3454         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3455         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3456         (LayoutTestController::suspendAnimations):
3457         (LayoutTestController::resumeAnimations):
3458         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3459         (LayoutTestController::suspendAnimations):
3460         (LayoutTestController::resumeAnimations):
3461
3462 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3463
3464         Reviewed by Ojan Vafai.
3465
3466         [Chromium/DRT] Enable saving layout test results.
3467         https://bugs.webkit.org/show_bug.cgi?id=43796
3468
3469         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
3470             parameters to the new-run-webkit-tests, including the name
3471             of the test results server.
3472
3473 2010-08-10  Jian Li  <jianli@chromium.org>
3474
3475         More chromium build fix.
3476
3477         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3478         (MockSpellCheck::spellCheckWord):
3479         (MockSpellCheck::initializeIfNeeded):
3480         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3481         (NotificationPresenter::grantPermission):
3482         (NotificationPresenter::show):
3483         (NotificationPresenter::checkPermission):
3484
3485 2010-08-10  Jian Li  <jianli@chromium.org>
3486
3487         Chromium build fix.
3488
3489         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3490         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3491
3492 2010-08-10  Victor Wang  <victorw@chromium.org>
3493
3494         Reviewed by Ojan Vafai.
3495
3496         Update test results server merge logic so the aggregated
3497         results and times are updated for tests that are
3498         in aggragated json but not in incremental json.
3499
3500         Also update unittest to test this case.
3501
3502         https://bugs.webkit.org/show_bug.cgi?id=43769
3503
3504         * TestResultServer/model/jsonresults.py:
3505         * TestResultServer/model/jsonresults_unittest.py:
3506
3507 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3508
3509         Reviewed by Ariya Hidayat.
3510
3511         [Qt] QtTestBrowser: proper set scene rect
3512
3513         When resizesToContents is ON scene's rect is set to the boundary of
3514         the mainFrame. However, navigating to other web page should keep resizing
3515         scene's rect according to the new document loaded. Patch addresses this issue.
3516
3517         Now resizesToContents and scrolling properly work on QtTestBrowser.
3518
3519         * QtTestBrowser/webview.cpp:
3520         (WebViewGraphicsBased::setPage):
3521         (WebViewGraphicsBased::contentsSizeChanged):
3522         (WebViewGraphicsBased::setResizesToContents):
3523         (WebViewGraphicsBased::resizeEvent):
3524         * QtTestBrowser/webview.h:
3525
3526 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3527
3528         Reviewed by Ariya Hidayat.
3529
3530         [Qt] QtTestBrowser: Clean up LauncherWindow code.
3531
3532         * QtTestBrowser/launcherwindow.cpp:
3533         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
3534         (LauncherWindow::init): Fixed comments.
3535         (LauncherWindow::applyPrefs): Move the method around.
3536         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
3537
3538 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3539
3540         Reviewed by Ariya Hidayat.
3541
3542         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
3543
3544         It gets control+0 the same visual effect as control++ or control-.
3545
3546         * QtTestBrowser/launcherwindow.cpp:
3547         (LauncherWindow::toggleZoomTextOnly):
3548
3549 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3550
3551         Reviewed by Ariya Hidayat.
3552
3553         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
3554
3555         Not all instances of LauncherWindow need its own m_zoomLevel.
3556
3557         * QtTestBrowser/launcherwindow.cpp:
3558         * QtTestBrowser/launcherwindow.h:
3559
3560 2010-08-09  Sam Weinig  <sam@webkit.org>
3561
3562         Reviewed by Geoffrey Garen.
3563
3564         Add zoom support for injected bundle
3565         https://bugs.webkit.org/show_bug.cgi?id=43759
3566
3567         Use zoom factor SPI to implement zoom related eventSender functions.
3568
3569         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3570         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3571         (WTR::EventSendingController::textZoomIn):
3572         (WTR::EventSendingController::textZoomOut):
3573         (WTR::EventSendingController::zoomPageIn):
3574         (WTR::EventSendingController::zoomPageOut):
3575         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3576         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3577         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
3578
3579 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
3580
3581         Speculative chromium build fix III.
3582
3583         * DumpRenderTree/chromium/MockSpellCheck.h:
3584         * DumpRenderTree/chromium/NotificationPresenter.h:
3585         * DumpRenderTree/chromium/WebViewHost.h:
3586         (WebViewHost::addClearHeader):
3587         (WebViewHost::clearHeaders):
3588
3589 2010-08-09  Ojan Vafai  <ojan@chromium.org>
3590
3591         Reviewed by Tony Chang.
3592
3593         increase the number of test results that we save
3594         https://bugs.webkit.org/show_bug.cgi?id=43763
3595
3596         Now that we do incremental uploads, we can increase the number of
3597         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
3598
3599         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3600
3601 2010-08-09  Evan Martin  <evan@chromium.org>
3602
3603         Reviewed by Tony Chang.
3604
3605         [chromium] DRT error print statement incorrectly tries to print a FILE*
3606         https://bugs.webkit.org/show_bug.cgi?id=43747
3607
3608         * DumpRenderTree/chromium/ImageDiff.cpp:
3609         (writeFile): pass the correct pointer.
3610
3611 2010-08-09  Victor Wang  <victorw@chromium.org>
3612
3613         Reviewed by Ojan Vafai.
3614
3615         Upload incremental test results json to server by default.
3616
3617         https://bugs.webkit.org/show_bug.cgi?id=43743
3618
3619         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3620
3621 2010-08-09  Eric Seidel  <eric@webkit.org>
3622
3623         Reviewed by Adam Barth.
3624
3625         EWS bots wait 2 minutes between patches
3626         https://bugs.webkit.org/show_bug.cgi?id=43731
3627
3628         * Scripts/webkitpy/tool/bot/queueengine.py:
3629          - Don't sleep after failures.  This was a hold-over from
3630            an earlier design.
3631         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3632          - EWS bots were not properly reporting true/false from process_work_item.
3633            They were always returning None, thus false, thus always logging
3634            as a failure and sleeping 2 minutes after each patch.
3635
3636 2010-08-09  Sam Weinig  <sam@webkit.org>
3637
3638         Reviewed by Anders Carlsson.
3639
3640         Stub out EventSender for WebKitTestRunner
3641         https://bugs.webkit.org/show_bug.cgi?id=43703
3642
3643         * WebKitTestRunner/DerivedSources.make:
3644         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3645         Add ability to pass javascript arguments to the wrapped object.
3646
3647         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
3648         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
3649         (WTR::EventSendingController::create):
3650         (WTR::EventSendingController::EventSendingController):
3651         (WTR::EventSendingController::~EventSendingController):
3652         (WTR::EventSendingController::wrapperClass):
3653         (WTR::setExceptionForString):
3654         (WTR::EventSendingController::mouseDown):
3655         (WTR::EventSendingController::mouseUp):
3656         (WTR::EventSendingController::mouseMoveTo):
3657         (WTR::EventSendingController::keyDown):
3658         (WTR::EventSendingController::contextClick):
3659         (WTR::EventSendingController::leapForward):
3660         (WTR::EventSendingController::textZoomIn):