Add tests that require layoutTestController.layerTreeAsText to WebKit2 skipped list
[WebKit.git] / WebKitTools / ChangeLog
1 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
2
3         Reviewed by Eric Seidel.
4
5         Remove check-header-includes, as it didn't turn out to be very useful.
6         https://bugs.webkit.org/show_bug.cgi?id=41970
7
8         * Scripts/check-header-includes: Removed.
9
10 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
11
12         Reviewed by Maciej Stachowiak.
13
14         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
15         https://bugs.webkit.org/show_bug.cgi?id=40922
16         
17         Always build WebKit2 on Windows. Necessary since our WebKit build on
18         Windows is packaged into a DLL with WebKit2.
19
20         * Scripts/build-webkit: Always build WebKit2 on Windows.
21
22 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
23
24         Reviewed by Steve Falkenburg.
25
26         One http test timing out on Windows can cause all future tests to time out
27         https://bugs.webkit.org/show_bug.cgi?id=42146
28         
29         There have been multiple times on the Windows bots where one http test timing out causes all future
30         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
31         times out, we should restart httpd on Cygwin to prevent this.
32
33         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
34         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
35             using kill fails.
36
37 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
38
39         Reviewed by Dan Bernstein.
40
41         Remove use of auto_ptr in WebKitTestRunner
42         https://bugs.webkit.org/show_bug.cgi?id=42134
43         
44         Replaced auto_ptr with PassOwnPtr / OwnPtr.
45
46         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
47         (WTR::WKStringToUTF8):
48         (WTR::InjectedBundlePage::dump):
49         (WTR::InjectedBundlePage::addMessageToConsole):
50         * WebKitTestRunner/TestInvocation.cpp:
51         (WTR::WKStringToUTF8):
52         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
53
54 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
55
56         Reviewed by Sam Weinig.
57
58         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
59         https://bugs.webkit.org/show_bug.cgi?id=42132
60
61         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
62         platform directories.
63
64 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
65
66         Reviewed by Anders Carlsson.
67
68         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
69         https://bugs.webkit.org/show_bug.cgi?id=42126
70
71         * WebKitTestRunner/PlatformWebView.h:
72         * WebKitTestRunner/TestInvocation.cpp:
73         (WTR::TestInvocation::TestInvocation): Store the path as a C
74         string for later use.
75         (WTR::TestInvocation::~TestInvocation):
76         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
77         size, depending on whether this is a W3C SVG test.
78         (WTR::TestInvocation::invoke): Call the size function.
79         * WebKitTestRunner/TestInvocation.h:
80         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
81         (WTR::PlatformWebView::resizeTo): Implement.
82         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
83         (WTR::PlatformWebView::resizeTo): Placeholder.
84
85 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
86
87         Reviewed by Xan Lopez.
88
89         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
90         https://bugs.webkit.org/show_bug.cgi?id=38648
91
92         Add the GTK_MODULES envvar (set to "gail") to the clean
93         environment when running DRT for the Gtk+ port
94
95         * Scripts/old-run-webkit-tests:
96
97 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
98
99         Reviewed by Dirk Schulze.
100
101         [GTK] Support pixel tests
102         https://bugs.webkit.org/show_bug.cgi?id=31518
103
104         Finish support for pixel tests on GTK+.
105
106         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
107         works on CoreFoundation systems) and add missing cstdio include.
108         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
109         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
110         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
111         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
112         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
113         by the ANSI standard and this fails on Linux, so unroll the loop here.
114         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
115         (BitmapContext::BitmapContext): There is no reason to check the value of the
116         m_context member in the constructor and it certainly should not be freed. Instead
117         just initialize it with the incoming value.
118         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
119         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
120         dump pixels.
121         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
122         (createBitmapContextFromWebView):
123         * GNUmakefile.am: Add new files to the build.
124
125 2010-07-12  Adam Barth  <abarth@webkit.org>
126
127         Unreviewed.
128
129         Remove stray "raise e" that got included in a previous patch.  This
130         caused the EWS bots to turn red instead of purple when a patch failed
131         to apply.
132
133         * Scripts/webkitpy/tool/commands/stepsequence.py:
134
135 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
136
137         Unreviewed, rolling out r63101.
138         http://trac.webkit.org/changeset/63101
139         https://bugs.webkit.org/show_bug.cgi?id=42103
140
141         Broke one API test (Requested by xan_ on #webkit).
142
143         * Scripts/old-run-webkit-tests:
144
145 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
146
147         Reviewed by Adam Roben.
148
149         https://bugs.webkit.org/show_bug.cgi?id=13075
150         XMLHttpRequest with failed authentication should set status to 401
151
152         https://bugs.webkit.org/show_bug.cgi?id=6871
153         <rdar://problem/3363403> 401 error page is never shown
154
155         Fix crashes in Windows DumpRenderTree.
156
157         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
158         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
159         again on a destroyed sender.
160
161 2010-07-12  Adam Roben  <aroben@apple.com>
162
163         Windows failure-to-launch fix
164
165         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
166         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
167         we already do for CoreFoundation, CFNetwork, etc.
168
169 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
170
171         Reviewed by Xan Lopez.
172
173         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
174         https://bugs.webkit.org/show_bug.cgi?id=38648
175
176         Add the GTK_MODULES envvar (set to "gail") to the clean
177         environment when running DRT for the Gtk+ port
178
179         * Scripts/old-run-webkit-tests:
180
181 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
182
183         Reviewed by Darin Adler.
184
185         https://bugs.webkit.org/show_bug.cgi?id=13075
186         XMLHttpRequest with failed authentication should set status to 401
187
188         https://bugs.webkit.org/show_bug.cgi?id=6871
189         <rdar://problem/3363403> 401 error page is never shown
190
191         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
192         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
193         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
194         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
195         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
196         the Cancel button.
197
198 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
199
200         Reviewed by Tor Arne Vestbø.
201
202         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
203         https://bugs.webkit.org/show_bug.cgi?id=42082
204
205         * QtTestBrowser/main.cpp:
206         (LauncherWindow::createChrome):
207         * QtTestBrowser/mainwindow.cpp:
208         (MainWindow::openLocation):
209         * QtTestBrowser/mainwindow.h:
210
211 2010-07-12  Adam Roben  <aroben@apple.com>
212
213         Make the Python autoinstaller not use a dead SourceForge server
214
215         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
216         offline SourceForge server
217
218         Reviewed by Anders Carlsson.
219
220         * Scripts/webkitpy/thirdparty/__init__.py: Use
221         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
222         which seems to be down.
223
224 2010-07-12  Adam Roben  <aroben@apple.com>
225
226         Make run-webkit-tests print how many tests timed out when exiting
227         early
228
229         The number of timed-out tests is taken into account when deciding
230         whether to exit early. Leaving it out of the output just makes the
231         script look buggy (because it might say something like "Exiting early
232         after 0 crashes.").
233
234         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
235         messages when exiting early due to crashes and time-outs
236
237         Reviewed by Anders Carlsson.
238
239         * Scripts/old-run-webkit-tests:
240         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
241         timed-out tests, too.
242
243 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
244
245         Reviewed by Dan Bernstein.
246
247         Implement animation-related methods for WebKitTestRunner
248         https://bugs.webkit.org/show_bug.cgi?id=42053
249         
250         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
251         animation tests were hanging otherwise.
252
253         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
254         (WTR::LayoutTestController::numberOfActiveAnimations):
255         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
256         (WTR::numberOfActiveAnimationsCallback):
257         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
258         (WTR::LayoutTestController::staticFunctions):
259         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
260
261 2010-07-11  Daniel Bates  <dbates@rim.com>
262
263         Reviewed by David Kilzer.
264
265         Enable executable support for svn-apply and svn-unapply
266         https://bugs.webkit.org/show_bug.cgi?id=39409
267
268         Connect up the Git and SVN executable bit support in parseDiff() so that
269         executable bit changes are propagated via the returned diff hash to the
270         patch function in svn-apply and svn-unapply.
271
272         * Scripts/VCSUtils.pm:
273           - Modified parseDiff() to call parseSvnDiffProperties when
274             it finds the start of an SVN property change diff.
275           - Removed FIXME comment above parseSvnDiffProperties() since
276             it is now being used by parseDiff().
277           - Export method scmToggleExecutableBit() now that we added the
278             executableBitDelta hash key. (This should have been exported
279             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
280         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
281           - Updated results for:
282             "rename (with executable bit change)"
283               - Test value of executableBitDelta (now that we have support).
284             "SVN: binary file (isBinary true)"
285               - Remove the property change diff from svnConvertedText. We plan
286                 to remove svnConvertedText in the future. So, we decided
287                 against adding such support to any new code, such as the
288                 property parsing routines. Therefore, we do not keep SVN
289                 converted text for property change diffs.
290           - Added unit tests:
291             "SVN: file change diff with property change diff"
292             "SVN: file change diff, followed by property change diff on different file"
293             "SVN: property diff, followed by file change diff"
294             "SVN: copied file with property change"
295             "SVN: two consecutive property diffs"
296             "SVN: binary file with executable bit change"
297             "SVN: binary file followed by property change on different file"
298             "SVN: binary file followed by file change on different file"
299             "SVN: file change diff with property change, followed by property change diff"
300             "SVN: file change diff with property change, followed by file change diff"
301
302 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
303
304         Reviewed by Dan Bernstein.
305
306         Implement waitUntilDone and notifyDone for WebKitTestRunner
307         https://bugs.webkit.org/show_bug.cgi?id=42049
308
309         With this fix, most of the DOM tests pass.
310         
311         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
312         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
313         a great way to do it in the future case where we may get multiple
314         pages - we really need a way to send it over from the ui process.
315         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
316         (WTR::InjectedBundle::page): A way to get the main page.
317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
318         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
319         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
320         are loading.
321         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
322         called by the layout test controller. Also, cancel any pending watchdogs.
323         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
324         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
326         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
327         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
328         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
329         to false.
330         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
331         the watchdog.
332         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
333         (WTR::LayoutTestController::setWaitToDump): Set the flag.
334         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
335         where waitUntilDone times out.
336         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
337         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
338         (WTR::notifyDoneCallback): JS glue for notifyDone.
339         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
340         to the layoutController.
341         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
342         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
343
344 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
345
346         Rubber-stamped by Dan Bernstein.
347
348         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
349         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
350         slow down the tests).
351
352         * Scripts/webkitpy/common/system/executive.py:
353
354 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
355
356         Reviewed by Kenneth Rohde Christiansen.
357
358         [Qt] Mac build fix
359         https://bugs.webkit.org/show_bug.cgi?id=41967
360
361         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
362
363         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
364
365 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
366
367         Reviewed by Antonio Gomes.
368
369         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
370         https://bugs.webkit.org/show_bug.cgi?id=41966
371
372         * MiniBrowser/qt/BrowserWindow.cpp:
373         (BrowserWindow::BrowserWindow):
374
375 2010-07-09  Leon Clarke  <leonclarke@google.com>
376
377         Reviewed by Adam Barth.
378
379         add support for link prefetching
380         https://bugs.webkit.org/show_bug.cgi?id=3652
381
382         * Scripts/build-webkit:
383
384 2010-07-09  Ojan Vafai  <ojan@chromium.org>
385
386         Reviewed by Adam Barth.
387
388         r63004 broke some python tests
389         https://bugs.webkit.org/show_bug.cgi?id=42007
390
391         AbstractStep now checks options.no_squash and options.squash, so
392         they needed to have real values. Mock would return an object for those,
393         which would then act as if the values were True.
394
395         * Scripts/webkitpy/tool/commands/commandtest.py:
396         * Scripts/webkitpy/tool/commands/download_unittest.py:
397         * Scripts/webkitpy/tool/commands/stepsequence.py:
398         * Scripts/webkitpy/tool/commands/upload_unittest.py:
399         * Scripts/webkitpy/tool/mocktool.py:
400         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
401         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
402         * Scripts/webkitpy/tool/steps/steps_unittest.py:
403         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
404         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
405
406 2010-07-09  Ojan Vafai  <ojan@chromium.org>
407
408         Reviewed by Adam Barth.
409
410         --squash should go away and become the default
411         https://bugs.webkit.org/show_bug.cgi?id=39624
412
413         If there are local commits and working copy changes, then prompt the user
414         whether to continue. Setting git config webkit-patch.commit_should_always_squash
415         true bypasses the prompt.
416
417         --git-commit=HEAD.. operates on working copy changes only.
418         --git-commit=committish operates on a range of commits as a single commit.
419             e.g. --git-commit=HEAD only operates on the HEAD commit.
420             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
421
422         --no-squash and --squash are left in with descriptive error messages if used.
423
424         * Scripts/check-webkit-style:
425         * Scripts/webkitpy/common/checkout/api.py:
426         * Scripts/webkitpy/common/checkout/api_unittest.py:
427         * Scripts/webkitpy/common/checkout/scm.py:
428         * Scripts/webkitpy/common/checkout/scm_unittest.py:
429         * Scripts/webkitpy/common/net/rietveld.py:
430         * Scripts/webkitpy/common/system/user.py:
431         * Scripts/webkitpy/style/optparser.py:
432         * Scripts/webkitpy/style_references.py:
433         * Scripts/webkitpy/tool/commands/download.py:
434         * Scripts/webkitpy/tool/commands/upload.py:
435         * Scripts/webkitpy/tool/mocktool.py:
436         * Scripts/webkitpy/tool/steps/abstractstep.py:
437         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
438         * Scripts/webkitpy/tool/steps/checkstyle.py:
439         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
440         * Scripts/webkitpy/tool/steps/commit.py:
441         * Scripts/webkitpy/tool/steps/options.py:
442         * Scripts/webkitpy/tool/steps/preparechangelog.py:
443         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
444         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
445         * Scripts/webkitpy/tool/steps/validatereviewer.py:
446
447 2010-07-09  Mark Rowe  <mrowe@apple.com>
448
449         Add two new Windows test build slaves.
450
451         * BuildSlaveSupport/build.webkit.org-config/config.json:
452
453 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
454
455         Reviewed by David Levin.
456
457         rebaseline_chromium_webkit_tests missing --use_drt option on linux
458         https://bugs.webkit.org/show_bug.cgi?id=41985
459
460         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
461         so that it works on linux. This is essentially a "compile-fix" for the
462         script.
463
464         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
465
466 2010-07-09  Nico Weber  <thakis@chromium.org>
467
468         Unreviewed. Adding myself as committer.
469
470         * Scripts/webkitpy/common/config/committers.py:
471
472 2010-07-09  David Kilzer  <ddkilzer@apple.com>
473
474         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
475
476         This reverts commit r62692.
477
478         * Scripts/commit-log-editor:
479
480 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
481
482         Reviewed by Ojan Vafai.
483
484         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
485         https://bugs.webkit.org/show_bug.cgi?id=38693
486
487         Introduced a new base class JSONResultsGeneratorBase that doesn't
488         have any dependency on layout_tests packages.
489         Turned JSONResultsGenerator into a wrapper class of the base class
490         so that the old code can work with it during the cleanup.
491
492         Added json_results_generator_unittest.py.
493
494         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
495         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
496         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
497
498 2010-07-09  Abhishek Arya  <inferno@chromium.org>
499
500         Unreviewed.
501
502         Marking myself as a committer.
503
504         * Scripts/webkitpy/common/config/committers.py:
505
506 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
507
508         Reviewed by Antti Koivisto.
509
510         Implement MiniBrowser for Qt.
511         https://bugs.webkit.org/show_bug.cgi?id=40233
512
513         * MiniBrowser/qt/BrowserWindow.cpp: Added.
514         (createNewPage):
515         (BrowserView::BrowserView):
516         (BrowserView::resizeEvent):
517         (BrowserView::load):
518         (BrowserView::view):
519         (BrowserWindow::BrowserWindow):
520         (BrowserWindow::load):
521         (BrowserWindow::changeLocation):
522         (BrowserWindow::~BrowserWindow):
523         * MiniBrowser/qt/BrowserWindow.h: Added.
524         (BrowserView::~BrowserView):
525         * MiniBrowser/qt/MiniBrowser.pro: Added.
526         * MiniBrowser/qt/main.cpp: Added.
527         (main):
528
529 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
530
531         Reviewed by Simon Hausmann.
532
533         Introduce the Qt autotest launcher.
534
535         Qt autotests should be executed more frequently, ideally by the Qt
536         build bot. This is the first step to provide the tests more accessible.
537
538         [Qt] It should be easier to run all Qt's autotests.
539         https://bugs.webkit.org/show_bug.cgi?id=31625
540
541         * Scripts/run-qtwebkit-tests: Added.
542
543 2010-07-09  Adam Barth  <abarth@webkit.org>
544
545         Reviewed by Eric Seidel.
546
547         commit-queue should merge to TOT when checkout needs update
548         https://bugs.webkit.org/show_bug.cgi?id=41944
549
550         There are a bunch of different designs that are possible here.  This
551         one merges to top of tree by cleaning out the working copy and
552         re-applying the patch.  Once you decide to merge that way, you need to
553         decide who's going to retry.  In this patch, we retry in the child
554         process instead of plumbing the failure reason to the master process.
555
556         This patch is difficult to test end-to-end, but hopefully it will work.
557         :)
558
559         * Scripts/webkitpy/tool/commands/queues.py:
560         * Scripts/webkitpy/tool/commands/stepsequence.py:
561         * Scripts/webkitpy/tool/multicommandtool.py:
562         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
563
564 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
565
566         Reviewed by Darin Adler.
567
568         Add a script to check for unnecessary includes in header files.
569         https://bugs.webkit.org/show_bug.cgi?id=41894
570
571         * Scripts/check-header-includes: Added.
572
573 2010-07-09  Adam Barth  <abarth@webkit.org>
574
575         Reviewed by Eric Seidel.
576
577         Add --html5-treebuilder option to run-webkit-tests
578         https://bugs.webkit.org/show_bug.cgi?id=41922
579
580         We're down to one or two regressions in the HTML5lib test suite.  It's
581         getting to be time to look at fixing LayoutTests.
582
583         * Scripts/old-run-webkit-tests:
584
585 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
586
587         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
588         in the drawing model never getting set on Tiger.
589
590         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
591         (NPP_New):
592
593 2010-07-08  Aaron Boodman  <aa@chromium.org>
594
595         Reviewed by Timothy Hatcher.
596
597         Add the ability for user scripts and user styles to affect just the top frame.
598
599         https://bugs.webkit.org/show_bug.cgi?id=41529
600
601         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
602         * DumpRenderTree/LayoutTestController.cpp: Ditto.
603         (addUserScriptCallback):
604         (addUserStyleSheetCallback):
605         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
606         (LayoutTestController::addUserScript):
607         (LayoutTestController::addUserStyleSheet):
608         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
609         (LayoutTestController::addUserScript):
610         (LayoutTestController::addUserStyleSheet):
611         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
612         (LayoutTestController::addUserScript):
613         (LayoutTestController::addUserStyleSheet):
614         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
615         (LayoutTestController::addUserScript):
616         (LayoutTestController::addUserStyleSheet):
617         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
618         (LayoutTestController::addUserScript):
619         (LayoutTestController::addUserStyleSheet):
620
621 2010-07-08  Adele Peterson  <adele@apple.com>
622
623         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
624
625         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
626         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
627
628         Log when the missing plugin button is pressed.
629
630         * DumpRenderTree/mac/UIDelegate.mm:
631         (-[UIDelegate webView:didPressMissingPluginButton:]):
632         * DumpRenderTree/win/UIDelegate.cpp:
633         (UIDelegate::QueryInterface):
634         (UIDelegate::createWebViewWithRequest):
635         (UIDelegate::drawBackground):
636         (UIDelegate::decidePolicyForGeolocationRequest):
637         (UIDelegate::didPressMissingPluginButton):
638         * DumpRenderTree/win/UIDelegate.h:
639
640 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
641
642         Fix the Tiger build.
643
644         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
645         (NPP_New):
646
647 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
648
649         Fix windows build.
650
651         #ifdef code for Mac.
652
653         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
654         (NPP_New):
655
656 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
657
658         Reviewed by Anders Carlsson.
659
660         Allow the TestPlugin to use Core Animation rendering for testing
661         https://bugs.webkit.org/show_bug.cgi?id=41872
662         
663         Add the ability for the TestPlugin to use the CoreAnimation rendering model
664         when available, based on the "drawingmodel" attribute of the embed tag:
665             drawingmodel="coreanimation"
666
667         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
668         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
669         when building on Tiger. Add a void* coreAnimationLayer member.
670         
671         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
672         (createCoreAnimationLayer): Obj-C method to create the CALayer.
673         
674         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
675         (NPP_New): Look for the drawingmodel attribute to decide which drawing
676         model to use.
677         (NPP_Destroy): Release the CALayer if we have one.
678         (NPP_GetValue): Return the retained CALayer.
679
680 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
681
682         Reviewed by Xan Lopez.
683
684         [GTK] Support pixel tests
685         https://bugs.webkit.org/show_bug.cgi?id=31518
686
687         Convert this file from CRLF to NL line endings. It will soon
688         be used on more than just the WinCairo platform.
689
690         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
691         (writeFunction):
692         (printPNG):
693         (computeMD5HashStringForBitmapContext):
694         (dumpBitmap):
695
696 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
697
698         Reviewed by Darin Adler.
699
700         Enable Data Execution Prevention for our test harnesses on Windows
701         https://bugs.webkit.org/show_bug.cgi?id=41882
702
703         * DumpRenderTree/win/DumpRenderTree.vcproj:
704         * DumpRenderTree/win/ImageDiff.vcproj:
705         * WebKitAPITest/WebKitAPITest.vcproj:
706         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
707
708 2010-07-07  Robert Hogan  <robert@webkit.org>
709
710         Reviewed by Kenneth Rohde Christiansen.
711
712         [Qt] Add DRT support for pageProperty etc.
713
714         https://bugs.webkit.org/show_bug.cgi?id=41584
715
716         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
717         (LayoutTestController::isPageBoxVisible):
718         (LayoutTestController::pageSizeAndMarginsInPixels):
719         (LayoutTestController::pageProperty):
720         (LayoutTestController::addUserStyleSheet):
721         * DumpRenderTree/qt/LayoutTestControllerQt.h:
722
723 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
724
725         Reviewed by Xan Lopez.
726
727         Remove a warnings from the ImageDiff build by using the proper
728         printf format string for the gsize data type.
729
730         * DumpRenderTree/gtk/ImageDiff.cpp:
731         (printImage): Use the proper printf format string for the gsize data type.
732
733 2010-07-08  Alice Liu  <alice.liu@apple.com>
734
735         Reviewed by Sam Weinig.
736
737         https://bugs.webkit.org/show_bug.cgi?id=41653
738         Add new WebKitTestRunner project for Windows
739
740         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
741         Similar to how it's done in DumpRenderTree, define max and min early
742         on so that they don't get replaced by a macro requiring 2 arguments.
743
744         * WebKitTestRunner/win: Added.
745         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
746         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
747         * WebKitTestRunner/win/main.cpp: Added.
748         (main): Implemented
749
750         Added these files with stubbed out functions:
751         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
752         (WTR::PlatformWebView::PlatformWebView):
753         (WTR::PlatformWebView::~PlatformWebView):
754         (WTR::PlatformWebView::page):
755         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
756         (WTR::TestController::initializeInjectedBundlePath):
757         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
758         (WTR::TestInvocation::runUntil):
759
760 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
761
762         Reviewed by Gustavo Noronha Silva.
763
764         [GTK] Implement ImageDiff and add it to the build system
765         https://bugs.webkit.org/show_bug.cgi?id=41779
766
767         Add the initial implementation of the ImageDiff tool for the GTK+
768         port. This is an essential tool for doing pixel tests. The implementation
769         is based on the Mac and Chromium ports.
770
771         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
772         (readPixbufFromStdin): Added.
773         (differenceImageFromDifferenceBuffer): Ditto.
774         (calculateDifference): Ditto.
775         (printImage): Ditto.
776         (printImageDifferences): Ditto.
777         (main): Ditto.
778         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
779
780 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
781
782         Unreviewed. Adding myself as a committer.
783
784         * Scripts/webkitpy/common/config/committers.py:
785
786 2010-07-08  Adam Roben  <aroben@apple.com>
787
788         Make Windows stop running tests from platform/mac
789
790         r62742 made a change (at my suggestion!) that caused us to start
791         looking for tests in platform/mac, rather than just looking for
792         expected results in platform/mac. This patch just undoes that part of
793         r62742.
794
795         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
796         tests from platform/mac, but shouldn't
797
798         Reviewed by Antti Koivisto and Anders Carlsson.
799
800         * Scripts/old-run-webkit-tests:
801         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
802         so we won't look in those directories for tests to run.
803         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
804         platform/mac-snowleopard and platform/mac for expected results.
805
806 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
807
808         Unreviewed. Adding myself as a reviewer.
809
810         * Scripts/webkitpy/common/config/committers.py:
811
812 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
813
814         Update my e-mail in committers.py
815
816         * Scripts/webkitpy/common/config/committers.py:
817
818 2010-07-07  Daniel Bates  <dbates@rim.com>
819
820         Reviewed by Dumitru Daniliuc.
821
822         VCSUtils.pm complains about uninitialized value $newLine
823         https://bugs.webkit.org/show_bug.cgi?id=41333
824
825         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
826         an array when fixing a change log entry that overlaps with an earlier
827         entry. In particular, when a patch contains a change log entry inserted
828         earlier in the change log file, but after an entry with the same author
829         and date.
830
831         * Scripts/VCSUtils.pm:
832             - Added for-loop constraint to fixChangeLogPatch() so that it does not
833               read off the end of the @overlappingLines array.
834         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
835
836 2010-07-07  Anders Carlsson  <andersca@apple.com>
837
838         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
839
840         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
841         (NPP_New):
842
843 2010-07-07  Kent Tamura  <tkent@chromium.org>
844
845         Reviewed by Adam Barth.
846
847         [DRT/Chromium] Support for indeterminate checkbox
848         https://bugs.webkit.org/show_bug.cgi?id=41747
849
850         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
851
852         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
853         (WebThemeControlDRT::draw):
854         * DumpRenderTree/chromium/WebThemeControlDRT.h:
855         (WebThemeControlDRT::):
856         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
857         (WebThemeEngineDRT::paintButton):
858
859 2010-07-07  Sam Weinig  <sam@webkit.org>
860
861         Reviewed by Mark Rowe.
862
863         Clean up MiniBrowser Xcode project.
864
865         - Use xcconfig files.
866         - Rename plists to canonical Info.plist
867         - Remove localizations.
868
869         * MiniBrowser/Configurations: Added.
870         * MiniBrowser/Configurations/Base.xcconfig: Added.
871         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
872         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
873         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
874         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
875         * MiniBrowser/WebBundle-Info.plist: Removed.
876         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
877         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
878         * MiniBrowser/mac/BrowserWindow.xib: Added.
879         * MiniBrowser/mac/BrowserWindowController.m:
880         (-[BrowserWindowController initWithPageNamespace:]):
881         * MiniBrowser/mac/English.lproj: Removed.
882         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
883         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
884         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
885         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
886         * MiniBrowser/mac/MainMenu.xib: Added.
887         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
888         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
889
890 2010-07-07  Kent Tamura  <tkent@chromium.org>
891
892         Reviewed by Dimitri Glazkov.
893
894         [DRT/Chromium] Fix two regressions
895         https://bugs.webkit.org/show_bug.cgi?id=41745
896
897         * DumpRenderTree/chromium/WebViewHost.cpp:
898         (WebViewHost::paintInvalidatedRegion):
899          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
900          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
901          though test_shell does it twice. Probably DRT needs it because
902          DRT delays painting as possible.
903
904 2010-07-07  Anders Carlsson  <andersca@apple.com>
905
906         Try to fix build.
907
908         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
909         (webkit_test_plugin_destroy_stream):
910
911 2010-07-07  Anders Carlsson  <andersca@apple.com>
912
913         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
914
915         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
916         (webkit_test_plugin_new_stream):
917         (webkit_test_plugin_destroy_stream):
918         (webkit_test_plugin_write_ready):
919         (webkit_test_plugin_write):
920
921 2010-07-07  Sam Weinig  <sam@webkit.org>
922
923         Reviewed by Mark Rowe.
924
925         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
926
927         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
928
929 2010-07-07  Anders Carlsson  <andersca@apple.com>
930
931         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
932
933         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
934         (NPP_New):
935         (NPP_HandleEvent):
936
937 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
938
939         Reviewed by Adam Roben.
940
941         Need to have a way to specify different results for Windows XP and 7
942         https://bugs.webkit.org/show_bug.cgi?id=41776
943         
944         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
945         subdirectories, so we can have different results for tests on Windows XP, Windows
946         Vista, and Windows 7.
947
948         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
949         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
950         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
951
952         This matches the behavior of the mac.
953
954         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
955             or Vista, try looking in other win-* subdirectories before win.
956         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
957             we are running.
958
959 2010-07-07  Kent Tamura  <tkent@chromium.org>
960
961         Reviewed by Dimitri Glazkov.
962
963         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
964         https://bugs.webkit.org/show_bug.cgi?id=41753
965
966         The original code of the following functions in
967         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
968         ASSERT_NOT_REACHED(). The program shouldn't stop at these
969         functions.
970
971         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
972         (DRTDevToolsClient::activateWindow):
973         (DRTDevToolsClient::closeWindow):
974         (DRTDevToolsClient::dockWindow):
975         (DRTDevToolsClient::undockWindow):
976
977 2010-07-07  Anders Carlsson  <andersca@apple.com>
978
979         Reviewed by Sam Weinig.
980
981         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
982         https://bugs.webkit.org/show_bug.cgi?id=41821
983
984         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
985         (pluginGetProperty):
986         (pluginSetProperty):
987         (pluginAllocate):
988         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
989         Add and initialize the returnNegativeOneFromWrite property.
990
991         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
992         (NPP_NewStream):
993         Set the stream type to NP_NORMAL so we'll get write callbacks.
994
995         (NPP_DestroyStream):
996         Treat the onstreamdestroy attribute as a function name and not a string.
997
998         (NPP_WriteReady):
999         Have this return a nonzero value.
1000
1001         (NPP_Write):
1002         If returnNegativeOneFromWrite is true return -1.
1003
1004 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1005
1006         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
1007         latest version is selected by default, and allows the version to be specified.
1008
1009         * wx/build/settings.py:
1010
1011 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
1012
1013         Reviewed by Darin Adler.
1014
1015         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
1016         https://bugs.webkit.org/show_bug.cgi?id=41810
1017
1018         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1019         (AccessibilityUIElement::selectedTextRange):
1020
1021 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
1022
1023         Unreviewed.
1024
1025         Build fix after r62700.
1026
1027         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
1028         source file locations.
1029
1030 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1031
1032         Reviewed by David Levin.
1033
1034         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
1035         https://bugs.webkit.org/show_bug.cgi?id=41814
1036
1037         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1038         * Scripts/old-run-webkit-tests:
1039
1040 2010-07-07  Ojan Vafai  <ojan@chromium.org>
1041
1042         Reviewed by David Levin.
1043
1044         add --exit-after-n-crashes to run-webkit-tests
1045         https://bugs.webkit.org/show_bug.cgi?id=41811
1046
1047         Change the bots at build.webkit.org to use --exit-after-n-crashes
1048         instead of --exit-after-n-failures since we want to be able to have
1049         more than 20 failures on those bots, but more than 20 crashes means
1050         something should be rolled out.
1051
1052         * Scripts/old-run-webkit-tests:
1053         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1054
1055 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
1056
1057         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
1058         TestNetscapePlugin project, because this was removed from the tree.
1059
1060         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1061
1062 2010-07-07  Anders Carlsson  <andersca@apple.com>
1063
1064         Reviewed by Simon Fraser.
1065
1066         Unify Mac and Windows TestNetscapePlugin main.cpp files
1067         https://bugs.webkit.org/show_bug.cgi?id=41798
1068         
1069         * DumpRenderTree/DumpRenderTree.sln:
1070         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1071         (strcasecmp):
1072         (NP_Initialize):
1073         (NP_GetEntryPoints):
1074         (NP_Shutdown):
1075         (NPP_New):
1076         (NPP_Destroy):
1077         (NPP_HandleEvent):
1078         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1079         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
1080
1081 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
1082
1083         [wx] Build fix. pageProperty needs to return a value.
1084
1085         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1086         (LayoutTestController::pageProperty):
1087
1088 2010-07-07  David Kilzer  <ddkilzer@apple.com>
1089
1090         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
1091
1092         Reviewed by Anders Carlsson.
1093
1094         For both svn and git, commit-log-editor is invoked from the root
1095         of the working directory.  Unlike svn, git returns a list of
1096         changed files that are relative to the directory where the
1097         command was invoked.  This caused the ChangeLog file in the root
1098         directory to be read instead of the ChangeLog in the current
1099         directory.
1100
1101         The fix is to use $ENV{PWD} as the base directory when fixing
1102         the path to the ChangeLog files.  With svn, this has no net
1103         effect since $ENV{PWD} is the root of the working directory and
1104         the ChangeLog paths are already relative to that directory.
1105         With git, $ENV{PWD} is the directory that the commit was invoked
1106         from, which fixes the ChangeLog paths so that the correct files
1107         are read when creating the commit log entry.
1108
1109         Note that the call to makeFilePathRelative() was supposed to
1110         address this issue, but it doesn't because (a) it does nothing
1111         with svn working directories by design, and (b) it does nothing
1112         with git working directories because it's invoked when the
1113         current directory is the root of the working directory, thus
1114         giving no relative path.
1115
1116         * Scripts/commit-log-editor: Removed call to
1117         makeFilePathRelative() since since it does nothing.  Moved code
1118         to fix up $changeLog path so that it's fixed before trying to
1119         open the file, and use $ENV{PWD} as the base path.  Also use
1120         canonicalizePath() to clean up paths with "../" in them.
1121
1122 2010-07-07  Anders Carlsson  <andersca@apple.com>
1123
1124         Another attempt at fixing the Qt build.
1125
1126         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1127
1128 2010-07-07  Anders Carlsson  <andersca@apple.com>
1129
1130         Try to fix Qt build.
1131
1132         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1133
1134 2010-07-07  Anders Carlsson  <andersca@apple.com>
1135
1136         Reviewed by Simon Fraser.
1137
1138         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
1139         https://bugs.webkit.org/show_bug.cgi?id=41781
1140
1141         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1142         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
1143         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
1144         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
1145         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
1146         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
1147         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
1148         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
1149         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
1150         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
1151         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
1152         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
1153         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
1154
1155 2010-07-07  Andras Becsi  <abecsi@webkit.org>
1156
1157         Unreviewed trivial fix.
1158
1159         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
1160         which was checked in accidentally in r62635.
1161
1162         * Scripts/webkitpy/layout_tests/port/webkit.py:
1163
1164 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1165
1166         Reviewed by Eric Seidel.
1167
1168         Pass port specific environment to server process.
1169         https://bugs.webkit.org/show_bug.cgi?id=41593
1170
1171         * Scripts/webkitpy/layout_tests/port/qt.py:
1172         * Scripts/webkitpy/layout_tests/port/webkit.py:
1173
1174 2010-07-06  Kent Tamura  <tkent@chromium.org>
1175
1176         Reviewed by Shinichiro Hamaji.
1177
1178         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
1179         https://bugs.webkit.org/show_bug.cgi?id=41644
1180
1181         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
1182         tolerance. We don't need tolerance for rebaseline.
1183
1184         * Scripts/webkitpy/layout_tests/port/base.py:
1185           Add optional tolerance parameter to diff_image().
1186         * Scripts/webkitpy/layout_tests/port/test.py:
1187           Add optional tolerance parameter to diff_image().
1188         * Scripts/webkitpy/layout_tests/port/webkit.py:
1189           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
1190         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1191           diff_files() always calls diff_image() with tolerance=0.
1192           diff_files() is used only by rebaseline-chromium-webkit-tests.
1193
1194 2010-07-06  Sam Weinig  <sam@webkit.org>
1195
1196         Fix MiniBrowser build.
1197
1198         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1199
1200 2010-07-06  Sam Weinig  <sam@webkit.org>
1201
1202         Reviewed by Anders Carlsson.
1203
1204         Add support for dumping the contents of messages to the console to WebKitTestRunner
1205
1206         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1207         (WTR::InjectedBundlePage::InjectedBundlePage):
1208         (WTR::InjectedBundlePage::_addMessageToConsole):
1209         (WTR::InjectedBundlePage::addMessageToConsole):
1210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1211
1212 2010-07-06  Sam Weinig  <sam@webkit.org>
1213
1214         Reviewed by Anders Carlsson.
1215
1216         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
1217         Add dumpAsText support for WebKitTestRunner
1218
1219         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1220         (WTR::InjectedBundle::InjectedBundle):
1221         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
1222         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1223         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
1224         API to dump the main frames text.
1225
1226 2010-07-06  Darin Adler  <darin@apple.com>
1227
1228         Fix Chromium build.
1229
1230         * DumpRenderTree/chromium/WebViewHost.cpp:
1231         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
1232         (WebViewHost::didNavigateWithinPage): Ditto.
1233         (WebViewHost::updateURL): Ditto.
1234
1235 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
1236
1237         Reviewed by Xan Lopez.
1238
1239         [GTK] build-webkit should not run autogen.sh unconditionally
1240         https://bugs.webkit.org/show_bug.cgi?id=41704
1241
1242         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
1243         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
1244         some very minor cleanup.
1245
1246 2010-07-06  Darin Adler  <darin@apple.com>
1247
1248         Try to fix Chromium build.
1249
1250         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
1251
1252 2010-07-06  Darin Adler  <darin@apple.com>
1253
1254         Fix build.
1255
1256         * WebKitAPITest/TestsController.cpp:
1257         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
1258
1259 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
1260
1261         Reviewed by Kent Tamura.
1262
1263         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
1264         https://bugs.webkit.org/show_bug.cgi?id=40558
1265
1266         Upstream DevTools for Chromium DRT.
1267         (original Chromium files rev. 51287)
1268
1269         * DumpRenderTree/DumpRenderTree.gypi:
1270         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
1271         (DRTDevToolsAgent::DRTDevToolsAgent):
1272         (DRTDevToolsAgent::setWebView):
1273         (DRTDevToolsAgent::sendMessageToFrontend):
1274         (DRTDevToolsAgent::forceRepaint):
1275         (DRTDevToolsAgent::runtimeFeatureStateChanged):
1276         (DRTDevToolsAgent::injectedScriptSource):
1277         (DRTDevToolsAgent::injectedScriptDispatcherSource):
1278         (DRTDevToolsAgent::debuggerScriptSource):
1279         (DRTDevToolsAgent::asyncCall):
1280         (DRTDevToolsAgent::call):
1281         (DRTDevToolsAgent::webDevToolsAgent):
1282         (DRTDevToolsAgent::attach):
1283         (DRTDevToolsAgent::detach):
1284         (DRTDevToolsAgent::setTimelineProfilingEnabled):
1285         (DRTDevToolsAgent::evaluateInWebInspector):
1286         (DRTDevToolsAgent::dispatchMessageLoop):
1287         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
1288         (DRTDevToolsAgent::~DRTDevToolsAgent):
1289         (DRTDevToolsAgent::hostIdentifier):
1290         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
1291         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1292         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
1293         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
1294         (DRTDevToolsCallArgs::callsCount):
1295         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
1296         (DRTDevToolsClient::DRTDevToolsClient):
1297         (DRTDevToolsClient::~DRTDevToolsClient):
1298         (DRTDevToolsClient::sendMessageToAgent):
1299         (DRTDevToolsClient::sendDebuggerCommandToAgent):
1300         (DRTDevToolsClient::activateWindow):
1301         (DRTDevToolsClient::closeWindow):
1302         (DRTDevToolsClient::dockWindow):
1303         (DRTDevToolsClient::undockWindow):
1304         (DRTDevToolsClient::asyncCall):
1305         (DRTDevToolsClient::call):
1306         (DRTDevToolsClient::allMessagesProcessed):
1307         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1308         * DumpRenderTree/chromium/EventSender.cpp:
1309         * DumpRenderTree/chromium/LayoutTestController.cpp:
1310         (LayoutTestController::LayoutTestController):
1311         (LayoutTestController::closeWebInspector):
1312         (LayoutTestController::setTimelineProfilingEnabled):
1313         (LayoutTestController::evaluateInWebInspector):
1314         * DumpRenderTree/chromium/LayoutTestController.h:
1315         * DumpRenderTree/chromium/TestShell.cpp:
1316         (TestShell::TestShell):
1317         (TestShell::~TestShell):
1318         (TestShell::createDRTDevToolsClient):
1319         (TestShell::showDevTools):
1320         (TestShell::closeDevTools):
1321         (TestShell::runFileTest):
1322         (TestShell::createNewWindow):
1323         * DumpRenderTree/chromium/TestShell.h:
1324         (TestShell::drtDevToolsAgent):
1325         (TestShell::drtDevToolsClient):
1326         * DumpRenderTree/chromium/config.h:
1327
1328 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1329
1330         Reviewed by Eric Seidel.
1331
1332         Don't pass image hash to DRT when pixel tests are disabled.
1333         https://bugs.webkit.org/show_bug.cgi?id=41597
1334
1335         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1336
1337 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1338
1339         Reviewed by Eric Seidel.
1340
1341         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1342         https://bugs.webkit.org/show_bug.cgi?id=41612
1343
1344         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1345
1346 2010-07-05  Adam Barth  <abarth@webkit.org>
1347
1348         Reviewed by Eric Seidel.
1349
1350         We should be able to specify a bug to block for webkit-patch upload
1351         https://bugs.webkit.org/show_bug.cgi?id=41648
1352
1353         This will be useful for working on the HTML5 parser.
1354
1355         * Scripts/webkitpy/tool/steps/createbug.py:
1356         * Scripts/webkitpy/tool/steps/options.py:
1357
1358 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1359
1360         Reviewed by Oliver Hunt.
1361
1362         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1363         https://bugs.webkit.org/show_bug.cgi?id=41017
1364
1365         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1366         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1367
1368 2010-07-04  MORITA Hajime  <morrita@google.com>
1369
1370         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1371         https://bugs.webkit.org/show_bug.cgi?id=41589
1372
1373         * run() method can result non-utf-8 bytes, that causes utf-8
1374           decoding fail.  Fixed to disable decoding.
1375         * Fixed Git.find_checkout_root() to make a test pass.
1376
1377         * Scripts/webkitpy/common/checkout/scm.py:
1378         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1379
1380 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1381
1382         Reviewed by Simon Hausmann.
1383
1384         [Qt] Fix DumpRenderTree userStyleSheet handling.
1385         https://bugs.webkit.org/show_bug.cgi?id=41570
1386
1387         DumpRenderTree did only set the userStyleSheet at
1388         layoutTestController.setUserStyleSheetEnabled().
1389
1390         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1391         (LayoutTestController::reset):
1392         (LayoutTestController::setUserStyleSheetLocation):
1393         (LayoutTestController::setUserStyleSheetEnabled):
1394         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1395
1396 2010-07-03  Robert Hogan  <robert@webkit.org>
1397
1398         Reviewed by Kenneth Rohde Christiansen.
1399
1400         [Qt] support dumpChildFrameScrollPositions
1401
1402         https://bugs.webkit.org/show_bug.cgi?id=41088
1403
1404         Unskip:
1405
1406         http/tests/navigation/anchor-subframeload.html
1407         http/tests/navigation/relativeanchor-frames.html
1408
1409         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1410         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1411         (WebCore::DumpRenderTree::dump):
1412         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1413         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1414         (LayoutTestController::reset):
1415         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1416         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1417         (LayoutTestController::dumpChildFrameScrollPositions):
1418
1419 2010-07-02  Sam Weinig  <sam@webkit.org>
1420
1421         Reviewed by Anders Carlsson.
1422
1423         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1424
1425         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1426         * Scripts/debug-webkittestrunner: Removed.
1427         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1428         * Scripts/run-webkittestrunner: Removed.
1429
1430 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1431
1432         Reviewed by Steve Falkenburg.
1433
1434         Some http tests fail on Windows with Cygwin 1.7
1435         https://bugs.webkit.org/show_bug.cgi?id=41537
1436         
1437         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1438         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1439         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1440
1441         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1442         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1443             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1444
1445 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1446
1447         Reviewed by Gustavo Noronha Silva.
1448
1449         [GTK] Separate DerivedSources per-project
1450         https://bugs.webkit.org/show_bug.cgi?id=41109
1451
1452         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1453         allowing the tools to build as a side-effect. Now that the top-level directory
1454         is no longer in the list of JavaScriptCore includes, include it explicitly.
1455
1456         * GNUmakefile.am:
1457
1458 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1459
1460         Reviewed by Kenneth Rohde Christiansen.
1461
1462         [Qt] Make context menus show up in the right place in QTestBrowser
1463
1464         Context menus were shown at scene-relative coordinates for
1465         QGraphicsWebView while QMenu expects them to be global. The
1466         change to the QWidget case was to get rid of the mapToGlobal.
1467
1468         * QtTestBrowser/webview.cpp:
1469
1470 2010-07-01  Robert Hogan <robert@webkit.org>
1471
1472         Reviewed by Kenneth Rohde Christiansen.
1473
1474         [Qt] dump frames in ascending alphabetical order of title
1475
1476         https://bugs.webkit.org/show_bug.cgi?id=41261
1477
1478         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1479         (WebCore::dumpHistoryItem):
1480
1481 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1482
1483         Unreviewed. 
1484
1485         Fix the GTK+ build after r62278.
1486
1487         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1488         let them override the automatic CPU detection for autotools builds.
1489
1490 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1491
1492         Unreviewed.
1493
1494         Fix the Windows build after r62278.
1495
1496         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1497
1498 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1499
1500         Reviewed by Gustavo Noronha Silva.
1501
1502         [GTK] build-webkit does not detect the number of CPUs
1503         https://bugs.webkit.org/show_bug.cgi?id=41469
1504
1505         Pass the appropriate -j<#> flag to make when building autotools builds.
1506         This causes make to spawn that many number of child processes for doing
1507         parallel builds.
1508
1509         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1510         of CPUs. This makes the script work across more platforms.
1511         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1512         number of CPUs across several platforms. Use this new function to determine the appropriate
1513         arguments to pass to make for doing parallel builds with autotools build files.
1514
1515 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1516
1517         Rubber-stamped by Laszlo Gombos.
1518
1519         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1520
1521         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1522         and use the one from WebKit.pri instead.
1523
1524 2010-07-01  Adam Barth  <abarth@webkit.org>
1525
1526         Reviewed by Eric Seidel.
1527
1528         Promote webkit-patch land-safely to main help
1529         https://bugs.webkit.org/show_bug.cgi?id=41446
1530
1531         I've been using this command a bunch and recommending it to folks.  We
1532         should show it in main help as it's past the experimental phase.
1533
1534         * Scripts/webkitpy/tool/commands/upload.py:
1535
1536 2010-06-28  MORITA Hajime  <morrita@google.com>
1537
1538         Reviewed by Shinichiro Hamaji.
1539
1540         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1541         https://bugs.webkit.org/show_bug.cgi?id=38775
1542
1543         - Introduced SCM.show_head() and SCM.diff_for_file().
1544         - Replaced direct svn invocations with newly implement SCM methods.
1545
1546         * Scripts/webkitpy/common/checkout/scm.py:
1547         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1548         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1549
1550 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1551
1552         Reviewed by Sam Weinig.
1553
1554         Allow MiniBrowser to open local files
1555         https://bugs.webkit.org/show_bug.cgi?id=41104
1556
1557         Wire up the openDocument: message with an NSOpenPanel, so we can open
1558         local files.
1559         
1560         Also change the xib so that the window remembers its size.
1561         
1562         * MiniBrowser/mac/AppDelegate.m:
1563         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1564         (-[BrowserAppDelegate openDocument:]):
1565         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1566         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1567
1568 2010-06-30  Sam Weinig  <sam@webkit.org>
1569
1570         Rubber-stamped by Anders Carlsson.
1571
1572         Add debug-webkittestrunner and cleanup related scripts.
1573
1574         * Scripts/debug-webkittestrunner: Added.
1575         * Scripts/run-webkittestrunner:
1576         * Scripts/webkitdirs.pm:
1577
1578 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1579
1580         [wx] Build fix after recent changes to LayoutTestController.
1581
1582         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1583         (LayoutTestController::pageSizeAndMarginsInPixels):
1584
1585 2010-06-29  Sam Weinig  <sam@webkit.org>
1586
1587         Reviewed by Anders Carlsson.
1588
1589         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1590         Make WebKitTestRunner work with more than one test at a time.
1591
1592         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1593         where there is a single WKView and each test is run it, rather than
1594         the design I was using where each test got its own WKView.
1595
1596         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1597         (WTR::InjectedBundle::didRecieveMessage):
1598         (WTR::InjectedBundle::reset):
1599         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::TestController::initialize):
1602         (WTR::TestController::runTest):
1603         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1604         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1605         * WebKitTestRunner/TestController.h:
1606         (WTR::TestController::mainWebView):
1607         (WTR::TestController::pageNamespace):
1608         (WTR::TestController::context):
1609         * WebKitTestRunner/TestInvocation.cpp:
1610         (WTR::TestInvocation::TestInvocation):
1611         (WTR::TestInvocation::~TestInvocation):
1612         (WTR::TestInvocation::invoke):
1613         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1614         * WebKitTestRunner/TestInvocation.h:
1615
1616 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1617
1618         Reviewed by Laszlo Gombos.
1619
1620         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1621         https://bugs.webkit.org/show_bug.cgi?id=40446
1622
1623         We quickly run out of memory on Symbian when loading web pages. This is
1624         caused by the default heap size, which is not suited for a web browser.
1625
1626         This change bumps the max heap size to 32MB.
1627
1628         * QtTestBrowser/QtTestBrowser.pro:
1629
1630 2010-06-30  Eric Seidel  <eric@webkit.org>
1631
1632         Reviewed by Adam Barth.
1633
1634         webkit-patch land allow the user to continue even if the builders are red
1635         https://bugs.webkit.org/show_bug.cgi?id=41395
1636
1637         I don't think it's good that we've been teaching people
1638         to always pass --ignore-builders.  At least land is now
1639         useable w/o --ignore-builders.
1640
1641         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1642
1643 2010-06-29  Robert Hogan  <robert@webkit.org>
1644
1645         Reviewed by Kenneth Rohde Christiansen.
1646
1647         [Qt] support dumpResourceResponseMIMETypes
1648         https://bugs.webkit.org/show_bug.cgi?id=41260
1649
1650         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1651         (LayoutTestController::reset):
1652         (LayoutTestController::dumpResourceResponseMIMETypes):
1653         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1654
1655 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1656
1657         Reviewed by Kenneth Rohde Christiansen.
1658
1659         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1660         https://bugs.webkit.org/show_bug.cgi?id=41173
1661
1662         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1663         (WebCore::WebPage::setViewGeometry):
1664         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1665
1666 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1667
1668         Reviewed by Simon Hausmann.
1669
1670         [Qt] Deal with postEvent in case of graphics based DRT
1671         https://bugs.webkit.org/show_bug.cgi?id=41174
1672
1673         QGraphicsScene does not have a postEvent method, so make scene
1674         send the event, in case of graphics based DRT, and delete it after that.
1675
1676         * DumpRenderTree/qt/EventSenderQt.cpp:
1677         (EventSender::scheduleAsynchronousClick):
1678         (EventSender::replaySavedEvents):
1679         (EventSender::postEvent):
1680         * DumpRenderTree/qt/EventSenderQt.h:
1681
1682 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1683
1684         Reviewed by Kenneth Rohde Christiansen.
1685
1686         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1687         https://bugs.webkit.org/show_bug.cgi?id=41172
1688
1689         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1690         (WebCore::DumpRenderTree::switchFocus):
1691
1692 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1693
1694         Reviewed by Xan Lopez.
1695
1696         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1697         https://bugs.webkit.org/show_bug.cgi?id=40009
1698
1699         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1700         are used when returning those values, for coherency with other ports.
1701
1702         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1703         (AccessibilityUIElement::role):
1704         (AccessibilityUIElement::title):
1705         (AccessibilityUIElement::description):
1706
1707 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1708
1709         Unreviewed, rolling out r62106.
1710         http://trac.webkit.org/changeset/62106
1711         https://bugs.webkit.org/show_bug.cgi?id=41346
1712
1713         "Broke editing tests" (Requested by xan_ on #webkit).
1714
1715         * Scripts/old-run-webkit-tests:
1716
1717 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1718
1719         Reviewed by Xan Lopez.
1720
1721         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1722         https://bugs.webkit.org/show_bug.cgi?id=38648
1723
1724         Add the GTK_MODULES envvar (set to "gail") to the clean
1725         environment when running DRT for the Gtk+ port
1726
1727         * Scripts/old-run-webkit-tests:
1728
1729 2010-06-28  Adam Barth  <abarth@webkit.org>
1730
1731         Unreviewed.
1732
1733         Switch test-html5-parser back to using runner.html.
1734
1735         * Scripts/test-html5-parser:
1736
1737 2010-06-28  Adam Barth  <abarth@webkit.org>
1738
1739         Reviewed by Eric Seidel.
1740
1741         Restore webkit-runner.html for use with new tree builder
1742         https://bugs.webkit.org/show_bug.cgi?id=41317
1743
1744         For now, we just want to run webkit-runner when we test-html5-parser.
1745
1746         * Scripts/test-html5-parser:
1747
1748 2010-06-23  John Gregg  <johnnyg@google.com>
1749
1750         Reviewed by Kent Tamura.
1751
1752         add ENABLE_DIRECTORY_UPLOAD build support
1753         https://bugs.webkit.org/show_bug.cgi?id=41100
1754
1755         * Scripts/build-webkit:
1756
1757 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1758
1759         Rubber-stamped by Xan Lopez.
1760
1761         Update webkitdirs's knowledge of our library's name.
1762
1763         * Scripts/webkitdirs.pm:
1764
1765 2010-06-28  Sam Weinig  <sam@webkit.org>
1766
1767         Reviewed by Anders Carlsson.
1768
1769         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1770         Build up WebKitTestRunner output in the InjectedBundle
1771
1772         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1773         and sending it over postMessage when done, instead of using the async
1774         WKPageRenderTreeExternalRepresentation.
1775
1776         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1777         (WTR::InjectedBundle::done):
1778         (WTR::InjectedBundle::didRecieveMessage):
1779         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1780         (WTR::InjectedBundle::os):
1781         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1782         (WTR::WKStringToUTF8):
1783         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1784         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1785         * WebKitTestRunner/TestInvocation.cpp:
1786         (WTR::WKStringToUTF8):
1787         (WTR::TestInvocation::TestInvocation):
1788         (WTR::TestInvocation::invoke):
1789         (WTR::TestInvocation::initializeMainWebView):
1790         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1791         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1792         * WebKitTestRunner/TestInvocation.h:
1793
1794 2010-06-28  Robert Hogan  <robert@webkit.org>
1795
1796         Unreviewed, rolling out r62021.
1797         http://trac.webkit.org/changeset/62021
1798         https://bugs.webkit.org/show_bug.cgi?id=41261
1799
1800         Broke http/navigation tests among other
1801
1802         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1803         (WebCore::DumpRenderTree::dumpFramesAsText):
1804
1805 2010-06-28  Sam Weinig  <sam@webkit.org>
1806
1807         Reviewed by Anders Carlsson.
1808
1809         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1810         environment.
1811
1812         * Scripts/run-webkittestrunner: Added.
1813         * Scripts/webkitdirs.pm:
1814
1815 2010-06-28  Robert Hogan  <robert@webkit.org>
1816
1817         Reviewed by Kenneth Rohde Christiansen.
1818
1819         [Qt] dump frames in ascending alphabetical order of title
1820
1821         https://bugs.webkit.org/show_bug.cgi?id=41261
1822
1823         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1824         (WebCore::DumpRenderTree::dumpFramesAsText):
1825
1826 2010-06-28  Robert Hogan  <robert@webkit.org>
1827
1828         Reviewed by Kenneth Rohde Christiansen.
1829
1830         [Qt] dump bf history of child windows
1831
1832         https://bugs.webkit.org/show_bug.cgi?id=41266
1833
1834         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1835         (WebCore::DumpRenderTree::dumpBackForwardList):
1836         (WebCore::DumpRenderTree::dump):
1837         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1838
1839 2010-06-28  Sam Weinig  <sam@webkit.org>
1840
1841         Reviewed by Anders Carlsson.
1842
1843         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1844         WebKit2: Add frame API for InjectedBundle code
1845
1846         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1847         (_didClearWindowForFrame):
1848
1849 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1850
1851         Reviewed by Kenneth Rohde Christiansen.
1852
1853         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1854         https://bugs.webkit.org/show_bug.cgi?id=38597
1855
1856         Fix behavior so reload button really acts as a load and a reload button.
1857
1858         * QtTestBrowser/mainwindow.cpp:
1859         (MainWindow::changeLocation):
1860
1861 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1862
1863         Reviewed by Gustavo Noronha.
1864
1865         [GTK] Does not compile with -DGSEAL_ENABLE
1866         https://bugs.webkit.org/show_bug.cgi?id=37851
1867
1868         Fix build with GSEAL enabled.
1869
1870         * DumpRenderTree/gtk/EventSender.cpp:
1871         (gtk_widget_get_window):
1872         (prepareMouseButtonEvent):
1873         (mouseMoveToCallback):
1874         (mouseWheelToCallback):
1875         (keyDownCallback):
1876
1877 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1878
1879         Reviewed by Gustavo Noronha.
1880
1881         [GTK] Add support for GTK+3
1882         https://bugs.webkit.org/show_bug.cgi?id=41253
1883
1884         Adapt build system for 3.x support.
1885
1886         * GNUmakefile.am:
1887
1888 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1889
1890         Reviewed by Simon Hausmann.
1891
1892         [QT][S60] build-webkit scripts picks wrong make spec for windows build
1893         https://bugs.webkit.org/show_bug.cgi?id=41198
1894
1895         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
1896
1897         * Scripts/webkitdirs.pm:
1898         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
1899
1900 2010-06-28  Eric Seidel  <eric@webkit.org>
1901
1902         Reviewed by Adam Barth.
1903
1904         Make it possible to test the new HTML5 TreeBuilder
1905         https://bugs.webkit.org/show_bug.cgi?id=41276
1906
1907         Adam was concerned that someone might make their port
1908         depend on this setting (I guess we had some trouble with that
1909         with the HTML5Parser setting), so I littered the code with warnings.
1910
1911         test-html5-parser now tests this code path.
1912
1913         * DumpRenderTree/mac/DumpRenderTree.mm:
1914         (resetDefaultsToConsistentValues):
1915         (initializeGlobalsFromCommandLineOptions):
1916         * Scripts/test-html5-parser:
1917
1918 2010-06-27  MORITA Hajime  <morrita@google.com>
1919
1920         Unreviewed. 
1921         
1922         Some never-called @staticmethods touched self. 
1923         Fixed it to replace these self with a class.
1924
1925         * Scripts/webkitpy/common/checkout/scm.py:
1926
1927 2010-06-27  MORITA Hajime  <morrita@google.com>
1928
1929         Unreviewed.
1930         
1931         Fixed exception raising syntax that is pointed out at
1932         https://bugs.webkit.org/show_bug.cgi?id=41153
1933
1934         * Scripts/webkitpy/common/checkout/scm.py:
1935         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
1936           Removed a bad line that I accidentally checked-in at last revision.
1937
1938 2010-06-24  MORITA Hajime  <morrita@google.com>
1939
1940         Reviewed by Eric Seidel.
1941
1942         rebaseline-chromium-webkit-tests should add or remove files to local git repository
1943         https://bugs.webkit.org/show_bug.cgi?id=41153
1944
1945         - Added SCM.add() and SCM.remove()
1946         - Replaced "svn add" and "svn remove"
1947           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
1948         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
1949           for debugging purpose.
1950
1951         * Scripts/webkitpy/common/checkout/scm.py:
1952         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1953         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1954
1955 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
1956
1957         Reviewed by Shinichiro Hamaji.
1958
1959         Improve default value handling for page format properties.
1960         https://bugs.webkit.org/show_bug.cgi?id=41150
1961
1962         * DumpRenderTree/LayoutTestController.cpp:
1963         (parsePageNumber):
1964         (parsePageNumberSizeMarings):
1965         (pageSizeAndMarginsInPixelsCallback):
1966         (LayoutTestController::staticFunctions):
1967         * DumpRenderTree/LayoutTestController.h:
1968         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1969         (LayoutTestController::pageSizeAndMarginsInPixels):
1970         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1971         (LayoutTestController::pageSizeAndMarginsInPixels):
1972         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1973         (LayoutTestController::pageSizeAndMarginsInPixels):
1974
1975 2010-06-21  Robert Hogan  <robert@webkit.org>
1976
1977         Reviewed by Kenneth Rohde Christiansen.
1978
1979         [Qt] DRT Support for setCustomPolicyDelegate
1980
1981         https://bugs.webkit.org/show_bug.cgi?id=39564
1982
1983         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1984         (LayoutTestController::setCustomPolicyDelegate):
1985         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1986
1987 2010-06-26  Robert Hogan  <robert@webkit.org>
1988
1989         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
1990         
1991         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
1992         exported.
1993
1994         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1995
1996 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
1997
1998         Reviewed by Dimitri Glazkov.
1999
2000         Add a build-webkit option for enabling Web Timing support.
2001         https://bugs.webkit.org/show_bug.cgi?id=38924
2002
2003         * Scripts/build-webkit:
2004
2005 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2006
2007         Reviewed by Kenneth Rohde Christiansen.
2008
2009         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
2010         https://bugs.webkit.org/show_bug.cgi?id=38597
2011
2012         Make the reload button act as a load button as well.
2013
2014         * QtTestBrowser/mainwindow.cpp:
2015         (MainWindow::buildUI):
2016         (MainWindow::changeLocation):
2017
2018 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
2019
2020         Reviewed by Dmitry Titov.
2021
2022         Add empty abortModal() method to all platforms.
2023         https://bugs.webkit.org/show_bug.cgi?id=40864
2024
2025         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
2026         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
2027         that use abortModal will become mac specific which is not desirable.
2028
2029         * DumpRenderTree/LayoutTestController.cpp:
2030         (abortModalCallback):
2031         (LayoutTestController::staticFunctions):
2032         * DumpRenderTree/LayoutTestController.h:
2033         * DumpRenderTree/chromium/LayoutTestController.cpp:
2034         (LayoutTestController::LayoutTestController):
2035         (LayoutTestController::abortModal):
2036         * DumpRenderTree/chromium/LayoutTestController.h:
2037         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2038         (LayoutTestController::abortModal):
2039         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2040         (LayoutTestController::abortModal):
2041         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2042         (LayoutTestController::abortModal):
2043         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2044         (LayoutTestController::abortModal):
2045
2046 2010-06-25  Sam Weinig  <sam@webkit.org>
2047
2048         Reviewed by Anders Carlsson.
2049
2050         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
2051         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
2052
2053         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
2054         (WTR::InjectedBundle::shared):
2055         (WTR::InjectedBundle::InjectedBundle):
2056         (WTR::InjectedBundle::_didCreatePage):
2057         (WTR::InjectedBundle::_willDestroyPage):
2058         (WTR::InjectedBundle::_didRecieveMessage):
2059         (WTR::InjectedBundle::initialize):
2060         (WTR::InjectedBundle::didCreatePage):
2061         (WTR::InjectedBundle::willDestroyPage):
2062         (WTR::InjectedBundle::didRecieveMessage):
2063         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
2064         (WTR::InjectedBundle::layoutTestController):
2065         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2066         (WKBundleInitialize):
2067         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
2068         (WTR::InjectedBundlePage::InjectedBundlePage):
2069         (WTR::InjectedBundlePage::~InjectedBundlePage):
2070         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
2071         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
2072         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
2073         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
2074         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
2075         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
2076         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
2077         (WTR::InjectedBundlePage::_didClearWindowForFrame):
2078         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2079         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2080         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2081         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2082         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2083         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2084         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2085         (WTR::InjectedBundlePage::didClearWindowForFrame):
2086         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
2087         (WTR::InjectedBundlePage::page):
2088         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
2089         (WTR::LayoutTestController::create):
2090         (WTR::LayoutTestController::LayoutTestController):
2091         (WTR::LayoutTestController::~LayoutTestController):
2092         (WTR::dumpAsTextCallback):
2093         (WTR::layoutTestControllerObjectFinalize):
2094         (WTR::LayoutTestController::makeWindowObject):
2095         (WTR::LayoutTestController::getJSClass):
2096         (WTR::LayoutTestController::staticFunctions):
2097         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
2098         (WTR::LayoutTestController::dumpAsText):
2099         (WTR::LayoutTestController::setDumpAsText):
2100         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2101
2102 2010-06-25  Sam Weinig  <sam@webkit.org>
2103
2104         Reviewed by Anders Carlsson.
2105
2106         Make WebKitTestRunner really work with run-webkit-tests. 
2107
2108         - Add Forwarding headers to allow some cleanup.
2109
2110         * WebKitTestRunner/ForwardingHeaders: Added.
2111         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
2112         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
2113         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
2114         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
2115         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
2116         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
2117         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
2118         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
2119         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
2120         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
2121         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
2122         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
2123         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
2124         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
2125         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2126         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
2127         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
2128         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
2129         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
2130         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
2131         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
2132         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
2133         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
2134         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
2135         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
2136         * WebKitTestRunner/TestInvocation.cpp:
2137         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
2138         * WebKitTestRunner/TestInvocation.h:
2139
2140 2010-06-25  Sam Weinig  <sam@webkit.org>
2141
2142         Reviewed by Mark Rowe.
2143
2144         Add support for WebKitTestRunner to old-run-webkit-tests
2145
2146         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
2147
2148         * Scripts/build-webkittestrunner: Added.
2149         * Scripts/old-run-webkit-tests:
2150
2151 2010-06-25  Adam Barth  <abarth@webkit.org>
2152
2153         Reviewed by David Levin.
2154
2155         Incremental build failed on Chromium ews
2156         https://bugs.webkit.org/show_bug.cgi?id=41011
2157
2158         The division of responsibility between update-webkit --chromium and
2159         build-webkit --chromium is slightly unclear.  In this patch, we make
2160         build-webkit --chromium also update DEPS and re-run GYP in case the
2161         developer has changed either since they updated.
2162
2163         This change is also helpful for the EWS, which wants to update DEPS and
2164         re-run GYP after applying patches, but the EWS doesn't want to run
2165         update-webkit --chromium because it has a dirty working copy.
2166
2167         * Scripts/webkitdirs.pm:
2168
2169 2010-06-25  Robert Hogan  <robert@webkit.org>
2170
2171         Reviewed by Simon Hausmann.
2172
2173         [Qt] Support evaluateScriptInIsolatedWorld()
2174
2175         https://bugs.webkit.org/show_bug.cgi?id=40079
2176
2177         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
2178         Remove QWebScriptWorld from exported headers.
2179         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
2180
2181         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2182         (LayoutTestController::reset):
2183         (LayoutTestController::evaluateScriptInIsolatedWorld):
2184         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2185
2186 2010-06-25  Anders Carlsson  <andersca@apple.com>
2187
2188         Revert accidental part and add a newline.
2189
2190         * MiniBrowser/mac/AppDelegate.m:
2191         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2192
2193 2010-06-25  Anders Carlsson  <andersca@apple.com>
2194
2195         Rubber-stamped by Dan Bernstein.
2196
2197         Add a LOG macro that expands to a no-op by default.
2198
2199         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2200         * MiniBrowser/mac/AppDelegate.m:
2201         (_didRecieveMessageFromInjectedBundle):
2202         * MiniBrowser/mac/BrowserWindowController.m:
2203         (-[BrowserWindowController windowShouldClose:]):
2204         (_didStartProvisionalLoadForFrame):
2205         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2206         (_didFailProvisionalLoadWithErrorForFrame):
2207         (_didCommitLoadForFrame):
2208         (_didFinishLoadForFrame):
2209         (_didFailLoadWithErrorForFrame):
2210         (_didReceiveTitleForFrame):
2211         (_didFirstLayoutForFrame):
2212         (_didFirstVisuallyNonEmptyLayoutForFrame):
2213         (_didBecomeUnresponsive):
2214         (_didBecomeResponsive):
2215         (_decidePolicyForNavigationAction):
2216         (_decidePolicyForNewWindowAction):
2217         (_createNewPage):
2218         (_showPage):
2219         (_closePage):
2220         (_didNavigateWithNavigationData):
2221         (_didPerformClientRedirect):
2222         (_didPerformServerRedirect):
2223         (_didUpdateHistoryTitle):
2224         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2225         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2226         (_didClearWindowForFrame):
2227         (_didCreatePage):
2228         (_willDestroyPage):
2229         (_didRecieveMessage):
2230
2231 2010-06-24  Adam Barth  <abarth@webkit.org>
2232
2233         Reviewed by Eric Seidel.
2234
2235         commit-queue is taking too long to land patches because of red trees
2236         https://bugs.webkit.org/show_bug.cgi?id=41194
2237
2238         Instead of checking for the tree to be green, we'll just spin hot
2239         trying to land patches.  This is probably too extreme in ignoring the
2240         tree, but I think we should try it for a while to see if we have
2241         trouble.  That will help us find the right balance.
2242
2243         * Scripts/webkitpy/tool/commands/queues.py:
2244         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2245
2246 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2247
2248         Reviewed by Xan Lopez.
2249
2250         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
2251         https://bugs.webkit.org/show_bug.cgi?id=40843
2252
2253         Define the version for old GTK+s in a way that is forward-compatible
2254         and clean up the logic a bit.
2255
2256         * DumpRenderTree/gtk/EventSender.cpp:
2257         (gdk_window_get_root_coords): Renamed and cleaned up.
2258         (prepareMouseButtonEvent): Remove #ifdefs.
2259         (mouseMoveToCallback): Remove #ifdefs.
2260
2261 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
2262
2263         Reviewed by Eric Seidel.
2264
2265         Fix NewRunWebKitTests to work on Windows.
2266         https://bugs.webkit.org/show_bug.cgi?id=41180
2267
2268         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
2269             because Windows fails to understand what we're asking of it.
2270
2271 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
2272
2273         Reviewed by Xan Lopez.
2274
2275         [GTK] The url passed to the WebView during layout tests is invalid
2276         https://bugs.webkit.org/show_bug.cgi?id=40832
2277
2278         Set the test URL to the full real file URL and do a small cleanup.
2279         Previously a URL like file://relative/path/to/test.html was passed
2280         to the WebView. This malformed file URL would be returned by
2281         webkit_web_view_get_url and webkit_web_frame_get_url.
2282
2283         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2284         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
2285         (shouldOpenWebInspector): Change to take a const string& as the argument.
2286         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
2287         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2288
2289 2010-06-24  Sam Weinig  <sam@webkit.org>
2290
2291         Reviewed by Anders Carlsson.
2292
2293         Fix WebKitTestRunner Makefile typos.
2294
2295         * WebKitTestRunner/Makefile:
2296
2297 2010-06-24  Adele Peterson  <adele@apple.com>
2298
2299         Reviewed by Eric Carlson.
2300
2301         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2302         https://bugs.webkit.org/show_bug.cgi?id=41085
2303
2304         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2305         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2306
2307 2010-06-23  Sam Weinig  <sam@webkit.org>
2308
2309         Reviewed by Anders Carlsson.
2310
2311         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2312         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2313
2314         - Mac only.
2315         - run-webkit-tests has not been modified to call it yet.
2316         - Only dumps the render tree at this time. 
2317
2318         * WebKitTestRunner: Added.
2319         * WebKitTestRunner/Configurations: Added.
2320         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2321         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2322         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2323         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2324         * WebKitTestRunner/InjectedBundle: Added.
2325         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2326         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2327         (_didStartProvisionalLoadForFrame):
2328         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2329         (_didFailProvisionalLoadWithErrorForFrame):
2330         (_didCommitLoadForFrame):
2331         (_didFinishLoadForFrame):
2332         (_didFailLoadWithErrorForFrame):
2333         (_didReceiveTitleForFrame):
2334         (_didClearWindow):
2335         (_didCreatePage):
2336         (_willDestroyPage):
2337         (_didRecieveMessage):
2338         (WKBundleInitialize):
2339         * WebKitTestRunner/Makefile: Added.
2340         * WebKitTestRunner/PlatformWebView.h: Added.
2341         (WTR::PlatformWebView::platformView):
2342         * WebKitTestRunner/TestController.cpp: Added.
2343         (WTR::TestController::shared):
2344         (WTR::TestController::TestController):
2345         (WTR::TestController::initialize):
2346         (WTR::TestController::runTest):
2347         (WTR::TestController::runTestingServerLoop):
2348         (WTR::TestController::run):
2349         * WebKitTestRunner/TestController.h: Added.
2350         (WTR::TestController::verbose):
2351         (WTR::TestController::injectedBundlePath):
2352         * WebKitTestRunner/TestInvocation.cpp: Added.
2353         (WTR::createWKURL):
2354         (WTR::TestInvocation::TestInvocation):
2355         (WTR::TestInvocation::~TestInvocation):
2356         (WTR::TestInvocation::invoke):
2357         (WTR::TestInvocation::dump):
2358         (WTR::TestInvocation::initializeMainWebView):
2359         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2360         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2361         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2362         (WTR::TestInvocation::didCommitLoadForFrame):
2363         (WTR::TestInvocation::didFinishLoadForFrame):
2364         (WTR::TestInvocation::didFailLoadForFrame):
2365         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2366         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2367         * WebKitTestRunner/TestInvocation.h: Added.
2368         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2369         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2370         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2371         * WebKitTestRunner/mac: Added.
2372         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2373         (WTR::PlatformWebView::PlatformWebView):
2374         (WTR::PlatformWebView::~PlatformWebView):
2375         (WTR::PlatformWebView::page):
2376         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2377         (WTR::TestInvocation::runUntil):
2378         * WebKitTestRunner/mac/main.mm: Added.
2379         (main):
2380
2381 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2382
2383         Unreviewed. Adding myself to the committers list.
2384
2385         * Scripts/webkitpy/common/config/committers.py:
2386
2387 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2388
2389         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2390
2391         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2392         (LayoutTestController::isPageBoxVisible):
2393         (LayoutTestController::pageAreaRectInPixels):
2394         (LayoutTestController::preferredPageSizeInPixels):
2395         * wx/build/settings.py:
2396
2397 2010-06-23  James Robinson  <jamesr@chromium.org>
2398
2399         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2400
2401         * Scripts/webkitpy/common/config/committers.py:
2402
2403 2010-06-23  Kent Tamura  <tkent@chromium.org>
2404
2405         Reviewed by Dimitri Glazkov.
2406
2407         Correct Chromium test configuration
2408         https://bugs.webkit.org/show_bug.cgi?id=41057
2409
2410         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2411          - Add "--use-drt" option for NRWT. It is required for Chromium and
2412            ignored for other platforms.
2413          - Skip JSC test on Chromium
2414         * BuildSlaveSupport/test-result-archive:
2415           Add Chromium support.
2416
2417 2010-06-23  Sam Weinig  <sam@webkit.org>
2418
2419         Reviewed by Anders Carlsson.
2420
2421         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2422         WebKit2: Flesh out more of the InjectedBundle client API
2423
2424         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2425         (_didStartProvisionalLoadForFrame):
2426         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2427         (_didFailProvisionalLoadWithErrorForFrame):
2428         (_didCommitLoadForFrame):
2429         (_didFinishLoadForFrame):
2430         (_didFailLoadWithErrorForFrame):
2431         (_didReceiveTitleForFrame):
2432         (_didClearWindowForFrame):
2433         (_didCreatePage):
2434         (_willDestroyPage):
2435         (WKBundleInitialize):
2436
2437 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2438
2439         Reviewed by Shinichiro Hamaji.
2440
2441         Implement page format data programming interface.
2442         Add methods for testing.
2443         https://bugs.webkit.org/show_bug.cgi?id=37538
2444
2445         * DumpRenderTree/LayoutTestController.cpp:
2446         (parsePageNumber):
2447         (isPageBoxVisibleCallback):
2448         (pageAreaRectInPixelsCallback):
2449         (preferredPageSizeInPixelsCallback):
2450         (LayoutTestController::staticFunctions):
2451         * DumpRenderTree/LayoutTestController.h:
2452         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2453         (LayoutTestController::isPageBoxVisible):
2454         (LayoutTestController::pageAreaRectInPixels):
2455         (LayoutTestController::preferredPageSizeInPixels):
2456         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2457         (LayoutTestController::isPageBoxVisible):
2458         (LayoutTestController::pageAreaRectInPixels):
2459         (LayoutTestController::preferredPageSizeInPixels):
2460         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2461         (LayoutTestController::isPageBoxVisible):
2462         (LayoutTestController::pageAreaRectInPixels):
2463         (LayoutTestController::preferredPageSizeInPixels):
2464
2465 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2466
2467         Reviewed by Shinichiro Hamaji.
2468
2469         Follow proper convention for if/switch/while as I've discovered
2470         them to be through my review processes.
2471         https://bugs.webkit.org/show_bug.cgi?id=40723
2472
2473         Modified test so that if( foo ) is not allowed as it appears not
2474         to be the accepted convention.
2475
2476         * Scripts/webkitpy/style/checkers/cpp.py:
2477         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2478
2479 2010-06-22  Eric Seidel  <eric@webkit.org>
2480
2481         Reviewed by Adam Barth.
2482
2483         Run clean-header-guards to fix some header guards
2484         https://bugs.webkit.org/show_bug.cgi?id=41044
2485
2486         No functional changes, thus no tests.
2487
2488         This entire change was generated by running
2489         clean-header-guards, and then reverting changes
2490         to files which shouldn't be changed.  Those which
2491         are left all should be updated.
2492
2493         Some of these changes are just fixing 755 permissions
2494         to be 644, since it seems various files have the wrong
2495         execute bit which don't need it.  clean-header-guards
2496         made those (welcome) permission fixes unintentionally.
2497
2498         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2499         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2500         * QtTestBrowser/fpstimer.h:
2501
2502 2010-06-22  Adam Barth  <abarth@webkit.org>
2503
2504         Reviewed by Eric Seidel.
2505
2506         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2507         https://bugs.webkit.org/show_bug.cgi?id=41043
2508
2509         Update the hash.
2510
2511         * Scripts/do-webcore-rename:
2512
2513 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2514
2515         Reviewed by Shinichiro Hamaji.
2516
2517         Follow proper convention for variable declaration spacing.
2518         https://bugs.webkit.org/show_bug.cgi?id=40724
2519
2520         Modified test so that 'int   a;' is not allowed.
2521
2522         * Scripts/webkitpy/style/checkers/cpp.py:
2523         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2524
2525 2010-06-22  Eric Seidel  <eric@webkit.org>
2526
2527         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2528
2529         * Scripts/webkitpy/common/config/committers.py:
2530
2531 2010-06-22  Eric Seidel  <eric@webkit.org>
2532
2533         Reviewed by Adam Barth.
2534
2535         Remove Gtk 64-Release bot from core since it's broken
2536         https://bugs.webkit.org/show_bug.cgi?id=41022
2537
2538         This bot alone has been responsible for more than 72 hours of
2539         commit-queue blockage in the last week.  The bot is broken -- keeps
2540         losing its display server or similar.  Until the Gtk folks can fix the
2541         bot, we need to remove it from core.  The WebKit community can't keep
2542         it green as is.
2543
2544         * Scripts/webkitpy/common/net/buildbot.py:
2545         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2546
2547 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2548
2549         Reviewed by Eric Seidel.
2550
2551         Fix the Windows build.
2552         https://bugs.webkit.org/show_bug.cgi?id=40972
2553
2554         * DumpRenderTree/win/ImageDiff.vcproj:
2555
2556 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2557
2558         Reviewed by Darin Adler, Dmitry Titov.
2559
2560         DumpRenderTree should allow tests with modal dialogs
2561         https://bugs.webkit.org/show_bug.cgi?id=35350
2562
2563         * DumpRenderTree/LayoutTestController.cpp:
2564         (abortModalCallback):
2565         (LayoutTestController::staticFunctions):
2566         * DumpRenderTree/LayoutTestController.h:
2567         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2568         (LayoutTestController::abortModal):
2569         Add abortModal method to LayoutTestController and make it available from script.
2570
2571         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2572         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2573         abortModal from when modal window closes.
2574         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2575
2576 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2577
2578         Reviewed by Anders Carlsson.
2579         
2580         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2581         https://bugs.webkit.org/show_bug.cgi?id=40948
2582         
2583         Have the script look in WebKit2.
2584
2585         * Scripts/do-webcore-rename:
2586
2587 2010-06-21  Robert Hogan  <robert@webkit.org>
2588
2589         Reviewed by Kenneth Rohde Christiansen.
2590
2591         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2592
2593         It's a Mac-specific test so just add the required LayoutTestController
2594         function as a no-op to avoid failing. Similar approach adopted by other
2595         ports.
2596
2597         https://bugs.webkit.org/show_bug.cgi?id=33344
2598
2599         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2600         (LayoutTestController::addDisallowedURL):
2601
2602 2010-06-21  Sam Weinig  <sam@webkit.org>
2603
2604         Reviewed by Anders Carlsson.
2605
2606         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2607         Add message passing support to the WebKit2 API.
2608
2609         - Add some test messages.
2610
2611         * MiniBrowser/mac/AppDelegate.m:
2612         (_didRecieveMessageFromInjectedBundle):
2613         (-[BrowserAppDelegate init]):
2614         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2615         (_didClearWindow):
2616         (_didCreatePage):
2617         (_didRecieveMessage):
2618         (WKBundleInitialize):
2619
2620 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2621
2622         Unreviewed.
2623
2624         Rolling back 61551 and 61555 due to test failures.
2625
2626         * DumpRenderTree/LayoutTestController.cpp:
2627         (LayoutTestController::staticFunctions):
2628         * DumpRenderTree/LayoutTestController.h:
2629         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2630         (LayoutTestController::setEditingBehavior):
2631         * DumpRenderTree/mac/UIDelegate.mm:
2632
2633 2010-06-21  Anders Carlsson  <andersca@apple.com>
2634
2635         Reviewed by Sam Weinig.
2636
2637         Make DumpRenderTree build with clang++
2638
2639         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2640         (-[LocalPasteboard setPropertyList:forType:]):
2641         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2642         (-[DumpRenderTreeWindow keyDown:]):
2643         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2644         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2645         (LayoutTestController::isCommandEnabled):
2646
2647 2010-06-21  Satish Sampath  <satish@chromium.org>
2648
2649         Reviewed by Steve Block.
2650
2651         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2652         https://bugs.webkit.org/show_bug.cgi?id=40878
2653
2654         * Scripts/build-webkit:
2655
2656 2010-06-21  Kent Tamura  <tkent@chromium.org>
2657
2658         Reviewed by Dimitri Glazkov.
2659
2660         [DRT/Chromium] Initialization for http/tests/loading/
2661         https://bugs.webkit.org/show_bug.cgi?id=40902
2662
2663         * DumpRenderTree/chromium/TestShell.cpp:
2664         (TestShell::runFileTest):
2665
2666 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2667
2668         Unreviewed.
2669
2670         Adding myself to the committers list.
2671
2672         * Scripts/webkitpy/common/config/committers.py:
2673
2674 2010-06-20  Kent Tamura  <tkent@chromium.org>
2675
2676         Reviewed by Dimitri Glazkov.
2677
2678         [DRT/Chromium] Add --allow-external-pages option
2679         https://bugs.webkit.org/show_bug.cgi?id=40762
2680
2681         Add --allow-external-pages introduced by Chromium r45403.
2682         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2683
2684         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2685         (main):
2686         * DumpRenderTree/chromium/TestShell.cpp:
2687         (TestShell::TestShell):
2688         * DumpRenderTree/chromium/TestShell.h:
2689         (TestShell::allowExternalPages):
2690         (TestShell::setAllowExternalPages):
2691         * DumpRenderTree/chromium/WebViewHost.cpp:
2692         (WebViewHost::willSendRequest):
2693
2694 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2695
2696         Reviewed by Adam Barth.
2697
2698         Sheriffbot: Should allow "r" in SVN_REVISION
2699         https://bugs.webkit.org/show_bug.cgi?id=40889
2700
2701         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2702         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2703
2704 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2705
2706         Reviewed by Dimitri Glazkov.
2707
2708         Python Tests Fail after r61508
2709         https://bugs.webkit.org/show_bug.cgi?id=40891
2710
2711         Test's regex list needed to be updated to match the new
2712         regex list in the source code. Added new bots to the
2713         example_buildbots list.
2714
2715         Regex list fixed in r61512. Updated bot list.
2716
2717         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2718
2719 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2720
2721         Unreviewed, build fix.
2722
2723         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2724
2725         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2726
2727 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2728
2729         Unreviewed.
2730
2731         Adding myself to the committers list.
2732
2733         * Scripts/webkitpy/common/config/committers.py:
2734
2735 2010-06-19  Sam Weinig  <sam@webkit.org>
2736
2737         Reviewed by Anders Carlsson.
2738
2739         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2740         Add ability to have a WebProcess per WebContext.
2741
2742         Move to use new shared contexts API.
2743
2744         * MiniBrowser/mac/AppDelegate.h:
2745         * MiniBrowser/mac/AppDelegate.m:
2746         (-[BrowserAppDelegate init]):
2747         (-[BrowserAppDelegate getCurrentPageNamespace]):
2748         (-[BrowserAppDelegate validateMenuItem:]):
2749         (-[BrowserAppDelegate _setProcessModel:]):
2750         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2751         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2752         * MiniBrowser/win/BrowserView.cpp:
2753         (BrowserView::create):
2754
2755 2010-06-02  Robert Hogan  <robert@webkit.org>
2756
2757         Reviewed by Adam Barth.
2758
2759         [Qt] Support evaluateScriptInIsolatedWorld()
2760
2761         https://bugs.webkit.org/show_bug.cgi?id=40079
2762
2763         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2764         (LayoutTestController::evaluateScriptInIsolatedWorld):
2765         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2766
2767 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2768
2769         Reviewed by Darin Adler.
2770
2771         Add three more non-core Chromium builders to start testing DumpRenderTree.
2772         https://bugs.webkit.org/show_bug.cgi?id=40335
2773
2774         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2775
2776 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2777
2778         Reviewed by Darin Fisher.
2779
2780         [Chromium] Plumbing for top-level frame names
2781         https://bugs.webkit.org/show_bug.cgi?id=40430
2782
2783         * DumpRenderTree/chromium/WebViewHost.cpp:
2784         (WebViewHost::reset):
2785         Changed obsolete call to clearName() to use setName(WebString()) instead.
2786
2787 2010-06-18  Sam Weinig  <weinig@apple.com>
2788
2789         Rolling http://trac.webkit.org/changeset/61297 back in.
2790
2791         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2792         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2793         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2794         (_didClearWindow):
2795         (_didCreatePage):
2796         (WKBundleInitialize):
2797
2798 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2799
2800         Reviewed by Darin Adler.
2801
2802         https://bugs.webkit.org/show_bug.cgi?id=40803
2803         TestNetscapePlugin has an incorrect implementation of "property" property
2804
2805         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2806         pass a static string back, it's going to be released by NPAPI implementation.
2807
2808 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2809
2810         Unreviewed.
2811
2812         Adding myself to the committers list.
2813
2814         * Scripts/webkitpy/common/config/committers.py:
2815
2816 2010-06-17  Tony Chang  <tony@chromium.org>
2817
2818         Reviewed by Kent Tamura.
2819
2820         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2821         https://bugs.webkit.org/show_bug.cgi?id=40615
2822
2823         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2824
2825 2010-06-17  Ada Chan  <adachan@apple.com>
2826
2827         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2828
2829         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2830         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2831         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2832
2833 2010-06-17  Darin Adler  <darin@apple.com>
2834
2835         One more try at fix for Chromium build.
2836
2837         * DumpRenderTree/chromium/TestShell.cpp:
2838         (TestShell::TestShell): Use set again instead of =.
2839
2840 2010-06-17  Darin Adler  <darin@apple.com>
2841
2842         Fix Chromium build.
2843
2844         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2845         code with all the other platforms! Wow, that should be fixed at some point.
2846
2847         * DumpRenderTree/chromium/TestShell.cpp:
2848         (TestShell::TestShell): Changed back to using "new".
2849         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2850
2851 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2852
2853         Unreviewed Qt build fix.
2854
2855         LayoutTestController in the Qt DRT is not using refs :)
2856
2857         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2858         (WebCore::DumpRenderTree::DumpRenderTree):
2859
2860 2010-06-17  Darin Adler  <darin@apple.com>
2861
2862         Reviewed by Sam Weinig.
2863
2864         Use adoptRef and create functions in more code paths
2865         https://bugs.webkit.org/show_bug.cgi?id=40760
2866
2867         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2868
2869         * DumpRenderTree/LayoutTestController.cpp:
2870         (LayoutTestController::create): Added.
2871         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2872
2873         * DumpRenderTree/chromium/TestShell.cpp:
2874         (TestShell::TestShell): Use create instead of new.
2875         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2876
2877         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2878         (runTest): Use RefPtr and create instead of OwnPtr and new.
2879
2880         * DumpRenderTree/mac/DumpRenderTree.mm:
2881         (runTest): Use RefPtr and create instead of OwnPtr and new.
2882
2883         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2884         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
2885         instead of new.
2886
2887         * DumpRenderTree/win/DumpRenderTree.cpp:
2888         (runTest): Use RefPtr and create instead of OwnPtr and new.
2889
2890         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2891         (runTest): Use RefPtr and create instead of OwnPtr and new.
2892         (MyApp::OnInit): Removed unneeded code to delete the layout
2893         test controller. This is done during each test.
2894
2895 2010-06-17  Kent Tamura  <tkent@chromium.org>
2896
2897         Reviewed by Shinichiro Hamaji.
2898
2899         [DRT/Chromium] Fix a bug of Windows pixel tests
2900         https://bugs.webkit.org/show_bug.cgi?id=40763
2901
2902         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2903         (TestShellPrinter::handleImage):
2904
2905 2010-06-16  Kent Tamura  <tkent@chromium.org>
2906
2907         Reviewed by Shinichiro Hamaji.
2908
2909         [DRT/Chromium] Fix crash on Mac Release
2910         https://bugs.webkit.org/show_bug.cgi?id=40759
2911
2912         * DumpRenderTree/chromium/WebViewHost.cpp:
2913         (WebViewHost::paintRect): We should not use m_canvas directly because
2914           it is created lazily in canvas().
2915
2916 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2917
2918         [wx] Build fix after new method addition.
2919
2920         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2921         (LayoutTestController::pageProperty):
2922
2923 2010-06-16  Kent Tamura  <tkent@chromium.org>
2924
2925         Reviewed by Dimitri Glazkov.
2926
2927         [DRT/Chromium] Set current working directory for each of tests
2928         https://bugs.webkit.org/show_bug.cgi?id=40668
2929
2930         This change fixes tests with eventSender.beginDragWithFiles().
2931
2932         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2933         (runTest):
2934
2935 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2936
2937         Reviewed by Gustavo Noronha Silva.
2938
2939         [GTK] r60803 broke media/controls-drag-timebar.html
2940         https://bugs.webkit.org/show_bug.cgi?id=40269
2941
2942         Only queue events while the mouse button is down, if drag mode is enabled. Some
2943         tests may disable drag mode, to prevent the queuing of events in this situation.
2944
2945         * DumpRenderTree/gtk/EventSender.cpp:
2946         (sendOrQueueEvent): Only queue events here if dragMode is true.
2947
2948 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2949
2950         Reviewed by Gustavo Noronha Silva.
2951
2952         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
2953         https://bugs.webkit.org/show_bug.cgi?id=40600
2954
2955         * DumpRenderTree/gtk/EventSender.cpp:
2956         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
2957
2958 2010-06-16  Adam Barth  <abarth@webkit.org>
2959
2960         Reviewed by Dimitri Glazkov.
2961
2962         Add a hidden land-cowboy command to webkit-patch to help land quick
2963         build fixes.
2964
2965         * Scripts/webkitpy/tool/commands/download.py:
2966         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2967
2968 2010-06-16  Adam Roben  <aroben@apple.com>
2969
2970         Convert console messages to UTF-8 before printing them
2971
2972         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
2973         http/tests/security/xssAuditor/embed-tag-null-char.html and
2974         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
2975         Windows. (I can't test the fix because Apache is crashing on my
2976         computer.)
2977
2978         Reviewed by Alexey Proskuryakov.
2979
2980         * DumpRenderTree/win/DumpRenderTree.cpp:
2981         (toUTF8): Extracted the code into an overload that takes a wide string
2982         and a length, then added an overload that takes a wstring.
2983
2984         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
2985         overload.
2986
2987         * DumpRenderTree/win/UIDelegate.cpp:
2988         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
2989         UTF-8 instead of letting printf convert to the current code page.
2990
2991 2010-06-16  Drew Wilson  <atwilson@chromium.org>
2992
2993         Reviewed by Kent Tamura.
2994
2995         [Chromium] Plumbing for top-level frame names
2996         https://bugs.webkit.org/show_bug.cgi?id=40430
2997
2998         * DumpRenderTree/chromium/WebViewHost.cpp:
2999         (WebViewHost::createView):
3000         Migrate to new createView() API.
3001         * DumpRenderTree/chromium/WebViewHost.h:
3002         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
3003
3004 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
3005
3006         Reviewed by Kenneth Rohde Christiansen.
3007
3008         [Qt] Scroll wheel event support to graphics based DRT
3009         https://bugs.webkit.org/show_bug.cgi?id=40577
3010
3011         * DumpRenderTree/qt/EventSenderQt.cpp:
3012         (EventSender::continuousMouseScrollBy):
3013         (EventSender::createGraphicsSceneWheelEvent):
3014         * DumpRenderTree/qt/EventSenderQt.h:
3015
3016 2010-06-16  Adam Roben  <aroben@apple.com>
3017
3018         Remove a stray newline from the Windows version of TestNetscapePlugin
3019
3020         Reviewed by Alexey Proskuryakov.
3021
3022         Fixes <http://webkit.org/b/40728>
3023         plugins/geturlnotify-during-document-teardown.html fails on Windows
3024
3025         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3026         (NPP_Destroy): Removed extra newline that the Mac version doesn't
3027         have.
3028
3029 2010-06-16  Adam Roben  <aroben@apple.com>
3030
3031         Respect LayoutTestController::isPrinting on Windows
3032
3033         This gets some printing tests closer to passing (like
3034         printing/page-rule-in-media-query.html).
3035
3036         Fixes <http://webkit.org/b/40727>.
3037
3038         Reviewed by Dan Bernstein.
3039
3040         * DumpRenderTree/win/DumpRenderTree.cpp:
3041         (dump): Pass LayoutTestController::isPrinting to
3042         IWebFramePrivate::renderTreeAsExternalRepresentation.
3043
3044 2010-06-15  Adam Barth  <abarth@webkit.org>
3045
3046         Reviewed by Eric Seidel.
3047
3048         Enable HTML5 lexer
3049         https://bugs.webkit.org/show_bug.cgi?id=40650
3050
3051         * DumpRenderTree/mac/DumpRenderTree.mm:
3052         (initializeGlobalsFromCommandLineOptions):
3053
3054 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
3055
3056         Reviewed by Shinichiro Hamaji.
3057
3058         Implement render style selection for pages to support CSS3 Paged Media.
3059         https://bugs.webkit.org/show_bug.cgi?id=35961
3060
3061         * DumpRenderTree/LayoutTestController.cpp:
3062         (parsePagePropertyParameters):
3063         (pagePropertyCallback):
3064         (LayoutTestController::staticFunctions):
3065         * DumpRenderTree/LayoutTestController.h:
3066         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3067         (LayoutTestController::pageProperty):
3068         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3069         (LayoutTestController::pageProperty):
3070         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3071         (LayoutTestController::pageProperty):
3072
3073 2010-06-15  Sam Weinig  <sam@webkit.org>
3074
3075         Reviewed by Anders Carlsson.
3076
3077         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
3078         WebKit2: Add mechanism to inject code into the WebProcess on startup
3079
3080         Add initial InjectedBundle support.
3081
3082         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3083         * MiniBrowser/WebBundle-Info.plist: Added.
3084         Add test InjectedBundle to the project.
3085
3086         * MiniBrowser/mac/AppDelegate.m:
3087         (-[BrowserAppDelegate init]):
3088         Get the path to the WebBundle from the the main bundle and pass it to the new
3089         WKContextCreateWithInjectedBundlePath function.
3090
3091         * MiniBrowser/mac/BrowserWindowController.m:
3092         (_didChangeProgress):
3093         Fix the build.  This has been broken for a while.
3094
3095         * MiniBrowser/mac/WebBundle: Added.
3096         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
3097         (_didCreatePage):
3098         (WKBundleInitialize):
3099         Add really basic InjectedBundle.
3100
3101         * MiniBrowser/win/BrowserView.cpp:
3102         (BrowserView::create):
3103         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
3104
3105 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
3106
3107         Reviewed by Darin Adler.
3108
3109         Adding myself to the reviewers list.
3110         https://bugs.webkit.org/show_bug.cgi?id=40693
3111
3112         * Scripts/webkitpy/common/config/committers.py:
3113
3114 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
3115
3116         Reviewed by Xan Lopez.
3117
3118         Switch to using GIO methods instead of realpath in GtkLauncher to determine
3119         the file URI. This should remove warnings about realpath being undefined
3120         when compiling with '-ansi'.
3121
3122         * GtkLauncher/main.c:
3123         (filenameToURL): Use GIO instead of realpath to determine file URI.
3124
3125 2010-06-15  Adam Roben  <aroben@apple.com>
3126
3127         Remove the redundant set-apple-windows-environment-variables script
3128
3129         Apparently update-webkit does this for you these days.
3130
3131         Rubber-stamped by Steve Falkenburg.
3132
3133         * Scripts/set-apple-windows-environment-variables: Removed.
3134
3135 2010-06-14  Adam Roben  <aroben@apple.com>
3136
3137         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
3138         environment variables
3139
3140         Fixes <http://webkit.org/b/40595>.
3141
3142         Reviewed by Steve Falkenburg.
3143
3144         * Scripts/set-apple-windows-environment-variables: Added.
3145         (to_windows_path): Passes the passed-in path through cygpath to
3146         generate a Windows-style path.
3147         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
3148         variables to their defaults, if they aren't already set.
3149
3150 2010-06-14  Adam Roben  <aroben@apple.com>
3151
3152         Speed up run-safari/debug-safari on Windows
3153
3154         Fixes <http://webkit.org/b/40586>.
3155
3156         Reviewed by Steve Falkenburg.
3157
3158         * Scripts/webkitdirs.pm:
3159         (runSafari): When debugging, set up the environment to run Safari
3160         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
3161         actually launch the debugger. When not debugging, just run WebKit.exe
3162         and it will do the rest for us.
3163
3164 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
3165
3166         Reviewed by Kenneth Rohde Christiansen.
3167
3168         [Qt] DRT EventSender support to graphics context events
3169         https://bugs.webkit.org/show_bug.cgi?id=40324
3170
3171         * DumpRenderTree/qt/EventSenderQt.cpp:
3172         (EventSender::contextClick):
3173
3174 2010-06-14  Tony Chang  <tony@chromium.org>
3175
3176         Reviewed by Darin Fisher.
3177
3178         [chromium] checkout chromium third_party directly
3179         https://bugs.webkit.org/show_bug.cgi?id=40556
3180
3181         * Scripts/update-webkit-chromium: some migration code for the bots
3182
3183 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3184
3185         Chromium build fix.
3186
3187         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
3188         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3189
3190 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
3191
3192         Reviewed by Darin Adler.
3193
3194         https://bugs.webkit.org/show_bug.cgi?id=40529
3195         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
3196
3197         * DumpRenderTree/mac/EventSendingController.mm:
3198         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
3199         event for "delete" - it had virtual key code from forward delete, and text from backspace.
3200         Fixed "delete" to mean forward delete.
3201
3202         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
3203         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
3204         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3205         Mac DRT confusion has propagated to other platforms, fixing those.
3206
3207 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
3208
3209         Reviewed by Xan Lopez.
3210
3211         Small GtkLauncher build fix for some systems.
3212
3213         * GtkLauncher/main.c: Add <limit.h> include.
3214
3215 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3216
3217         Reviewed by Laszlo Gombos.
3218
3219         [Qt] navigator.geolocation support for Qt port
3220         https://bugs.webkit.org/show_bug.cgi?id=39724
3221
3222         Implementation for geolocation cases to DumpRenderTreeQt
3223
3224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3225         (WebCore::WebPage::allowGeolocationRequest):
3226         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3227         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3228         (LayoutTestController::setGeolocationPermission):
3229         (LayoutTestController::setMockGeolocationError):
3230         (LayoutTestController::setMockGeolocationPosition):
3231         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3232         (LayoutTestController::isGeolocationPermissionSet):
3233         (LayoutTestController::geolocationPermission):
3234
3235 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
3236
3237         Reviewed by Darin Adler.
3238
3239         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
3240         be a way of overwriting the Xcode system path.  Making
3241         $WEBKITOUTPUTDIR take precedence over the system default would make
3242         this possible.
3243
3244         * Scripts/webkitdirs.pm:
3245
3246 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
3247
3248         Reviewed by Darin Adler.
3249
3250         AX: link won't return linked element if URL contains #
3251         https://bugs.webkit.org/show_bug.cgi?id=40192
3252
3253         * DumpRenderTree/AccessibilityUIElement.cpp:
3254         (linkedUIElementAtIndexCallback):
3255         (AccessibilityUIElement::getJSClass):
3256         * DumpRenderTree/AccessibilityUIElement.h:
3257         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3258         (AccessibilityUIElement::linkedUIElementAtIndex):
3259         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3260         (AccessibilityUIElement::linkedUIElementAtIndex):
3261         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3262         (AccessibilityUIElement::linkedUIElementAtIndex):
3263
3264 2010-06-13  Adam Barth  <abarth@webkit.org>
3265
3266         Reviewed by Darin Adler.
3267
3268         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
3269         https://bugs.webkit.org/show_bug.cgi?id=39550
3270
3271         This can cause an extra request to bugs.webkit.org durig upload, but it
3272         shouldn't be too bad.  Also, this won't work if you remove the
3273         boilerplate created by prepare-ChangeLog.
3274
3275         * Scripts/webkitpy/common/checkout/changelog.py:
3276         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3277         * Scripts/webkitpy/common/net/bugzilla.py:
3278         * Scripts/webkitpy/tool/steps/abstractstep.py:
3279         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3280         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
3281
3282 2010-06-08  Robert Hogan  <robert@webkit.org>
3283
3284         Reviewed by Eric Seidel.
3285
3286         [Qt] Add support for callShouldCloseOnWebView() to DRT
3287         https://bugs.webkit.org/show_bug.cgi?id=40330
3288
3289         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3290         (LayoutTestController::callShouldCloseOnWebView):
3291         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3292         (LayoutTestController::setCallCloseOnWebViews):
3293
3294 2010-06-12  Eric Seidel  <eric@webkit.org>
3295
3296         Reviewed by Daniel Bates.
3297
3298         do-webcore-rename should have a --verbose option
3299         https://bugs.webkit.org/show_bug.cgi?id=40497
3300
3301         * Scripts/do-webcore-rename:
3302          - Unified how we handle skipping files/directories
3303            this will allow us to "black list" certain files and
3304            directories when performing renames.
3305          - Made do-webcore-rename log what it's skipping when passed --verbose.
3306
3307 2010-06-12  Darin Adler  <darin@apple.com>
3308
3309         * Scripts/run-bindings-tests: Fixed a typo in a message.
3310
3311 2010-06-12  Kent Tamura  <tkent@chromium.org>
3312
3313         Reviewed by Dimitri Glazkov.
3314
3315         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3316         https://bugs.webkit.org/show_bug.cgi?id=40402
3317
3318         _build_path() of each Chromium port check existence of build path
3319         of Chromium checkout first, then check existence of build path of
3320         WebKit-only checkout.
3321
3322         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3323         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3324         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3325
3326 2010-06-12  Robert Hogan  <robert@webkit.org>
3327
3328         Reviewed by Kenneth Rohde Christiansen.
3329
3330         [Qt] Back-forward list dumping is incorrect
3331
3332         https://bugs.webkit.org/show_bug.cgi?id=36392
3333
3334         Support dumping child history items in DRT.
3335
3336         Unskip:
3337
3338         fast/loader/frame-src-change-added-to-history.html
3339         fast/loader/frame-src-change-not-added-to-history.html
3340         fast/loader/frame-location-change-not-added-to-history.html
3341
3342         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3343         (WebCore::dumpHistoryItem):
3344
3345 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3346
3347         Reviewed by Eric Seidel.
3348
3349         upload all patches that lack in-rietveld to rietveld
3350         https://bugs.webkit.org/show_bug.cgi?id=40444
3351
3352         If it's a patch, then we'll try to upload it as long as it
3353         doesn't have in-rietveld set. No longer set in-rietveld? since
3354         it's not needed.
3355
3356         * Scripts/webkitpy/common/net/bugzilla.py:
3357
3358 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3359
3360         Reviewed by Darin Fisher.
3361
3362         Fix rietveld upload when message length > 100 characters
3363         https://bugs.webkit.org/show_bug.cgi?id=40457
3364
3365         * Scripts/webkitpy/common/net/rietveld.py:
3366
3367 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3368
3369         Reviewed by Laszlo Gombos.
3370
3371         [Qt] There should be a way to enable popups in QtTestBrowser
3372         https://bugs.webkit.org/show_bug.cgi?id=40427
3373
3374         * QtTestBrowser/main.cpp:
3375         (LauncherWindow::toggleJavascriptCanOpenWindows):
3376         (LauncherWindow::createChrome):
3377
3378 2010-06-10  Adam Barth  <abarth@webkit.org>
3379
3380         Reviewed by Daniel Bates.
3381
3382         Make SheriffBot more chatty
3383         https://bugs.webkit.org/show_bug.cgi?id=40463
3384
3385         People seem to like to talk to SheriffBot, so let's make him chat back.
3386
3387         * Scripts/webkitpy/thirdparty/__init__.py:
3388         * Scripts/webkitpy/tool/bot/irc_command.py:
3389         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3390         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3391         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3392
3393 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3394
3395         Reviewed by Darin Adler.
3396
3397         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3398         
3399         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3400         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3401         WEXITSTATUS on $result instead of just comparing $result to 0.
3402
3403         * Scripts/update-webkit-auxiliary-libs:
3404
3405 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3406
3407         Reviewed by Alexey Proskuryakov.
3408
3409         don't use Exception.message as it's deprecated in python 2.6+
3410         https://bugs.webkit.org/show_bug.cgi?id=40449
3411
3412         * Scripts/webkitpy/tool/commands/queues.py:
3413
3414 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3415
3416         Reviewed by Adam Barth.
3417
3418         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3419         https://bugs.webkit.org/show_bug.cgi?id=40436
3420
3421         * Scripts/webkitpy/common/system/outputcapture.py:
3422         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3423         * Scripts/webkitpy/tool/commands/queues.py:
3424         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3425         * Scripts/webkitpy/tool/commands/queuestest.py:
3426         * Scripts/webkitpy/tool/mocktool.py:
3427
3428 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3429
3430         Reviewed by Simon Hausmann.
3431
3432         [Qt] *All* WebGL layout tests fail!
3433         https://bugs.webkit.org/show_bug.cgi?id=40296
3434
3435         Added test for WebKitWebGLEnabled to
3436         LayoutTestController::overridePreference().
3437
3438         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3439         (LayoutTestController::overridePreference):
3440
3441 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3442
3443         Reviewed by Kenneth Rohde Christiansen.
3444
3445         [Qt] DRT EventSender support to graphics mouse events activation
3446         https://bugs.webkit.org/show_bug.cgi?id=40017
3447
3448         * DumpRenderTree/qt/EventSenderQt.cpp:
3449         (EventSender::mouseDown):
3450         (EventSender::mouseUp):
3451         (EventSender::mouseMoveTo):
3452         (EventSender::keyDown):
3453         (EventSender::contextClick):
3454         (EventSender::sendTouchEvent):
3455         (EventSender::sendOrQueueEvent):
3456         (EventSender::eventFilter):
3457         (EventSender::createGraphicsSceneMouseEvent):
3458         (EventSender::sendEvent):
3459         * DumpRenderTree/qt/EventSenderQt.h:
3460         (EventSender::isGraphicsBased):
3461
3462 2010-06-09  Adam Barth  <abarth@webkit.org>
3463
3464         Reviewed by Ojan Vafai.
3465
3466         webkit-patch upload fails for security bugs because there's no rietveld flag
3467         https://bugs.webkit.org/show_bug.cgi?id=40309
3468
3469         There's probably a more elegant way of seeing whether the form control
3470         exists, but this seems to work.
3471
3472         * Scripts/webkitpy/common/net/bugzilla.py:
3473
3474 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3475
3476         Reviewed by Adam Barth.
3477
3478         make rietveld upload faster and avoid posting to bug on errors
3479         https://bugs.webkit.org/show_bug.cgi?id=40389
3480
3481         Only grab the first item of the upload queue instead of trying
3482         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3483
3484         Also, don't post comments to the bug when uploading fails.
3485
3486         * Scripts/webkitpy/common/net/bugzilla.py:
3487         * Scripts/webkitpy/tool/commands/queues.py:
3488         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3489         * Scripts/webkitpy/tool/commands/stepsequence.py:
3490         * Scripts/webkitpy/tool/mocktool.py:
3491
3492 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3493
3494         Reviewed by Adam Barth.
3495
3496         Rietveld upload queue fails when setting in-rietveld flag
3497         https://bugs.webkit.org/show_bug.cgi?id=40371
3498
3499         Make the comment arguments to set_flag_on_attachment optional
3500         and add it to the MockBugzilla.
3501
3502         * Scripts/webkitpy/common/net/bugzilla.py:
3503         * Scripts/webkitpy/tool/bot/queueengine.py:
3504         * Scripts/webkitpy/tool/commands/download_unittest.py:
3505         * Scripts/webkitpy/tool/commands/queues.py:
3506         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3507         * Scripts/webkitpy/tool/mocktool.py:
3508
3509 2010-06-09  Kenneth Russell  <kbr@google.com>
3510
3511         Reviewed by Dimitri Glazkov.
3512
3513         Rename FloatArray to Float32Array
3514         https://bugs.webkit.org/show_bug.cgi?id=40323
3515
3516         Used do-webcore-rename to perform renaming. Manually undid
3517         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3518         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3519         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3520         all layout tests on Safari; built Chromium and ran selected WebGL
3521         tests.
3522
3523         * Scripts/do-webcore-rename:
3524
3525 2010-06-08  Tony Chang  <tony@chromium.org>
3526
3527         Reviewed by David Levin.
3528
3529         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3530         https://bugs.webkit.org/show_bug.cgi?id=40285
3531
3532         * Scripts/webkitdirs.pm:
3533         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3534
3535 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3536
3537         Reviewed by Tamura Kent.
3538
3539         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3540         https://bugs.webkit.org/show_bug.cgi?id=40052
3541         
3542         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3543
3544         * DumpRenderTree/DumpRenderTree.gypi:
3545         * DumpRenderTree/chromium/TestShellWin.cpp:
3546         (platformInit):
3547         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3548         (WebKit::):
3549         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3550         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3551         (WebKit::WebThemeControlDRT::box):
3552         (WebKit::WebThemeControlDRT::line):
3553         (WebKit::WebThemeControlDRT::triangle):
3554         (WebKit::WebThemeControlDRT::roundRect):
3555         (WebKit::WebThemeControlDRT::oval):
3556         (WebKit::WebThemeControlDRT::circle):
3557         (WebKit::WebThemeControlDRT::nestedBoxes):
3558         (WebKit::WebThemeControlDRT::markState):
3559         (WebKit::WebThemeControlDRT::draw):
3560         (WebKit::WebThemeControlDRT::drawTextField):
3561         (WebKit::WebThemeControlDRT::drawProgressBar):
3562         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3563         (WebKit::WebThemeControlDRT::):
3564         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3565         (WebKit::):
3566         (WebKit::WebThemeEngineDRT::paintButton):
3567         (WebKit::WebThemeEngineDRT::paintMenuList):
3568         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3569         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3570         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3571         (WebKit::WebThemeEngineDRT::paintTextField):
3572         (WebKit::WebThemeEngineDRT::paintTrackbar):
3573         (WebKit::WebThemeEngineDRT::paintProgressBar):
3574         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3575         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3576
3577 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3578
3579         Unreviewed, rolling out r60878.
3580         http://trac.webkit.org/changeset/60878
3581         https://bugs.webkit.org/show_bug.cgi?id=40349
3582
3583         broke linux build (Requested by tony^work on #webkit).
3584
3585         * Scripts/webkitdirs.pm:
3586         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3587
3588 2010-06-08  Tony Chang  <tony@chromium.org>
3589
3590         Reviewed by David Levin.
3591
3592         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3593         https://bugs.webkit.org/show_bug.cgi?id=40285
3594
3595         * Scripts/webkitdirs.pm:
3596         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3597
3598 2010-06-08  Kenneth Russell  <kbr@google.com>
3599
3600         Unreviewed, build fix.
3601
3602         Fix build breakage from 38145
3603         https://bugs.webkit.org/show_bug.cgi?id=40346
3604
3605         The fix for bug 38145 broke the Chromium Win build because
3606         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3607         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3608         tests in Safari on Mac OS X. Changed download mirrors for
3609         python-irclib to working ones.
3610
3611         * Scripts/webkitpy/thirdparty/__init__.py:
3612
3613 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3614
3615         Reviewed by Eric Seidel.
3616
3617         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3618         https://bugs.webkit.org/show_bug.cgi?id=39058
3619
3620         * Scripts/old-run-webkit-tests:
3621          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3622
3623 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3624
3625         Unreviewed buildfix after r60479.
3626
3627         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3628         versions other than 2.17.3.
3629
3630         * DumpRenderTree/gtk/EventSender.cpp:
3631         (getRootCoords):
3632
3633 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3634
3635         Reviewed by Oliver Hunt.
3636
3637         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3638         https://bugs.webkit.org/show_bug.cgi?id=40267
3639
3640         When a mouse button is down, automatically queue mouse motion events and
3641         do not play them back until the mouse button is released. This matches the
3642         behavior of other ports' EventSenders.
3643
3644         * DumpRenderTree/gtk/EventSender.cpp:
3645         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3646         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3647
3648 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3649
3650         Reviewed by Sam Weinig.
3651
3652         Add CPP bindings generator
3653         https://bugs.webkit.org/show_bug.cgi?id=38279
3654
3655         Integrate CPP bindings in run-bindings-tests.
3656
3657         * Scripts/run-bindings-tests:
3658
3659 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3660
3661         Reviewed by Ojan Vafai.
3662
3663         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3664         https://bugs.webkit.org/show_bug.cgi?id=40183
3665
3666         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3667
3668 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3669
3670         Unreviewed.
3671
3672         Add my new email and IRC nick to committers.py.
3673
3674         * Scripts/webkitpy/common/config/committers.py:
3675
3676 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
3677
3678         Unreviewed.
3679
3680         Revert changes in json_results_generator.py's _get_svn_revision.
3681
3682         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3683
3684 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3685
3686         Reviewed by Xan Lopez.
3687
3688         [GTK] GtkLauncher should support relative file paths
3689         https://bugs.webkit.org/show_bug.cgi?id=39944
3690
3691         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
3692
3693         * GtkLauncher/main.c:
3694         (filename_to_url): Added.
3695         (main): Try to resolve arguments as relative file URLs first.
3696
3697 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3698
3699         Reviewed by Xan Lopez.
3700
3701         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
3702         https://bugs.webkit.org/show_bug.cgi?id=40182
3703
3704         Instead of invoking signal handlers directly via g_signal_emit_by_name, call