3cbe0bbe7c16a8e02b2eb2377888973693f6fafc
[WebKit.git] / WebKitTools / ChangeLog
1 2010-09-11  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Dan Bernstein.
4
5         Add callback mechanism for the getting the source of a frame
6         <rdar://problem/8364681>
7         https://bugs.webkit.org/show_bug.cgi?id=45604
8
9         Add ability to dump the main frame's source to the console.
10
11         * MiniBrowser/mac/BrowserWindowController.h:
12         * MiniBrowser/mac/BrowserWindowController.m:
13         (-[BrowserWindowController dumpSourceToConsole:]):
14         * MiniBrowser/mac/MainMenu.xib:
15
16 2010-09-11  Eric Seidel  <eric@webkit.org>
17
18         Reviewed by Adam Barth.
19
20         Remove unneeded Empty Queue messages
21         https://bugs.webkit.org/show_bug.cgi?id=45602
22
23         We already have a /gc job to delete these.
24         recentstatus.py is already smart enough to use the
25         most recent of the workitems last update or the most recent status,
26         so removing these should not change the _last_status_date() return
27         value more than a few milliseconds.
28
29         These messages just spam the recent status log.
30
31         * Scripts/webkitpy/tool/commands/queues.py:
32
33 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
34
35         Reviewed by Adam Barth.
36
37         Fix Python exception when generating synthetic patch IDs
38         https://bugs.webkit.org/show_bug.cgi?id=45592
39
40         Can't concatenate strings and numbers directly.
41
42         * QueueStatusServer/handlers/queuestatus.py:
43
44 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
45
46         Reviewed by Adam Barth.
47
48         Group statuses in queue status by patch ID
49         https://bugs.webkit.org/show_bug.cgi?id=45588
50
51         Group statuses by patch ID so that the status page is easier
52         to scan.
53
54         * QueueStatusServer/handlers/queuestatus.py:
55         * QueueStatusServer/stylesheets/dashboard.css:
56         (.status-group):
57         (.status-bug):
58         (.status-group ul):
59         (.status-group ul li):
60         (.status-group ul li:hover):
61         (.status-cell):
62         (.status-cell:hover):
63         (.status-cell.pass):
64         (.status-cell.fail):
65         (.status-cell.pending):
66         (.status-cell.error):
67         * QueueStatusServer/templates/dashboard.html:
68         * QueueStatusServer/templates/queuestatus.html:
69
70 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
71
72         Reviewed by Tony Chang.
73
74         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
75         https://bugs.webkit.org/show_bug.cgi?id=45479
76
77         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
78         implementation in ResourceLoadDelegate in the Mac port).
79
80         * DumpRenderTree/chromium/LayoutTestController.cpp:
81         (LayoutTestController::LayoutTestController):
82         (LayoutTestController::dumpResourceResponseMIMETypes):
83         (LayoutTestController::reset):
84         * DumpRenderTree/chromium/LayoutTestController.h:
85         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
86         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
87         * DumpRenderTree/chromium/TestShell.h:
88         (TestShell::shouldDumpResourceResponseMIMETypes):
89         * DumpRenderTree/chromium/WebViewHost.cpp:
90         (WebViewHost::didReceiveResponse):
91
92 2010-09-11  Eric Seidel  <eric@webkit.org>
93
94         Reviewed by Adam Barth.
95
96         queues.webkit.org should expose /remote_api for data upload/download
97         https://bugs.webkit.org/show_bug.cgi?id=45559
98
99         * QueueStatusServer/app.yaml:
100          - /remote_api is a standard app-engine service which allows use of
101            the bulk uploader for data upload/download.  Exposing this
102            (for admin access only) allows us to use 
103
104 2010-09-10  Sam Weinig  <sam@webkit.org>
105
106         Reviewed by Dan Bernstein.
107
108         Add zoom support to WebKit2 API
109         <rdar://problem/7660657>
110         https://bugs.webkit.org/show_bug.cgi?id=45585
111
112         - Add zoom options to MiniBrowser that mimic Safari's options using
113           the new WebKit2 zoom APIs.
114         - Switch uses of float for the zoom APIs to use double.
115
116         * MiniBrowser/mac/BrowserWindowController.h:
117         * MiniBrowser/mac/BrowserWindowController.m:
118         (-[BrowserWindowController initWithPageNamespace:]):
119         (-[BrowserWindowController validateMenuItem:]):
120         (-[BrowserWindowController validateUserInterfaceItem:]):
121         (-[BrowserWindowController currentZoomFactor]):
122         (-[BrowserWindowController setCurrentZoomFactor:]):
123         (-[BrowserWindowController canZoomIn]):
124         (-[BrowserWindowController zoomIn:]):
125         (-[BrowserWindowController canZoomOut]):
126         (-[BrowserWindowController zoomOut:]):
127         (-[BrowserWindowController canResetZoom]):
128         (-[BrowserWindowController resetZoom:]):
129         (-[BrowserWindowController toggleZoomMode:]):
130         * MiniBrowser/mac/MainMenu.xib:
131         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
132         (WTR::EventSendingController::textZoomIn):
133         (WTR::EventSendingController::textZoomOut):
134         (WTR::EventSendingController::zoomPageIn):
135         (WTR::EventSendingController::zoomPageOut):
136
137 2010-09-10  Robert Hogan  <robert@webkit.org>
138
139         Reviewed by Andreas Kling.
140
141         [Qt] Fix crash in DRT in standalone mode
142
143         https://bugs.webkit.org/show_bug.cgi?id=45454
144
145         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
146         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
147
148 2010-09-10  Sam Weinig  <sam@webkit.org>
149
150         Reviewed by Darin Adler.
151
152         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
153         Precursor to <rdar://problem/7660657>
154         https://bugs.webkit.org/show_bug.cgi?id=45522
155
156         Update for changes to the Bundle API to allow separate control of page and text zoom
157         levels.
158
159         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
160         (WTR::EventSendingController::textZoomIn):
161         (WTR::EventSendingController::textZoomOut):
162         (WTR::EventSendingController::zoomPageIn):
163         (WTR::EventSendingController::zoomPageOut):
164         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
165         (WTR::InjectedBundlePage::reset):
166
167 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
168
169         Reviewed by Andreas Kling.
170
171         [Qt] Support click event for notifications
172         https://bugs.webkit.org/show_bug.cgi?id=44836
173
174         Add support for simulateDesktopNotificationClick by calling
175         back to DumpRenderTreeSupportQt.cpp.
176
177         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
178         (LayoutTestController::simulateDesktopNotificationClick):
179         * DumpRenderTree/qt/LayoutTestControllerQt.h:
180
181 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
182
183         Reviewed by Eric Seidel.
184
185         Update queue status when patches fail their first land attempt
186         https://bugs.webkit.org/show_bug.cgi?id=45583
187
188         Add a few more _update_status calls to make it more obvious if a patch is 
189         being retried because tests failed.
190
191         * Scripts/webkitpy/tool/commands/queues.py:
192
193 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
194
195         Reviewed by Andreas Kling.
196
197         [Qt] MiniBrowser crashes with multiply windows when closing one of them
198         https://bugs.webkit.org/show_bug.cgi?id=45536
199
200         * MiniBrowser/qt/BrowserView.cpp:
201         (BrowserView::BrowserView): Reference the context instead of adopting it
202         because it can be shared across different views.
203
204 2010-09-10  Tony Chang  <tony@chromium.org>
205
206         Unreviewed, rolling out r67241.
207         http://trac.webkit.org/changeset/67241
208         https://bugs.webkit.org/show_bug.cgi?id=44709
209
210         Accidentally committed.
211
212         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
213         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
214
215 2010-09-10  Tony Chang  <tony@chromium.org>
216
217         Reviewed by Ojan Vafai.
218
219         deduplicate-tests should be runnable from any WebKit directory
220         https://bugs.webkit.org/show_bug.cgi?id=44709
221
222         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
223         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
224
225 2010-09-10  Tony Chang  <tony@chromium.org>
226
227         Unreviewed, rolling out r67216.
228         http://trac.webkit.org/changeset/67216
229         https://bugs.webkit.org/show_bug.cgi?id=44709
230
231         Broke
232
233         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
234         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
235
236 2010-09-10  Tony Chang  <tony@chromium.org>
237
238         Reviewed by Ojan Vafai.
239
240         deduplicate-tests should be runnable from any WebKit directory
241         https://bugs.webkit.org/show_bug.cgi?id=44709
242
243         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
244         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
245
246 2010-09-09  Hans Wennborg  <hans@chromium.org>
247
248         Reviewed by Jeremy Orlow.
249
250         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
251         https://bugs.webkit.org/show_bug.cgi?id=45460
252
253         This enables DumpRenderTree to run layout tests for DeviceOrientation.
254
255         Also declare the LayoutTestController destructor out-of-line.
256         Otherwise the implicit destructor would cause compiler errors because
257         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
258
259         * DumpRenderTree/chromium/LayoutTestController.cpp:
260         (LayoutTestController::~LayoutTestController):
261         (LayoutTestController::setMockDeviceOrientation):
262         (LayoutTestController::deviceOrientationClient):
263         * DumpRenderTree/chromium/LayoutTestController.h:
264         * DumpRenderTree/chromium/WebViewHost.cpp:
265         (WebViewHost::deviceOrientationClient):
266         * DumpRenderTree/chromium/WebViewHost.h:
267
268 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
269
270         Unreviewed, rolling out r67119.
271         http://trac.webkit.org/changeset/67119
272         https://bugs.webkit.org/show_bug.cgi?id=45505
273
274         Extra newlines in results (Requested by tony^work on #webkit).
275
276         * DumpRenderTree/chromium/LayoutTestController.cpp:
277         (LayoutTestController::LayoutTestController):
278         (LayoutTestController::reset):
279         * DumpRenderTree/chromium/LayoutTestController.h:
280         * DumpRenderTree/chromium/TestShell.h:
281         * DumpRenderTree/chromium/WebViewHost.cpp:
282         (printResponseDescription):
283         (printNodeDescription):
284         (printRangeDescription):
285         (WebViewHost::shouldBeginEditing):
286         (WebViewHost::shouldEndEditing):
287         (WebViewHost::shouldInsertNode):
288         (WebViewHost::shouldChangeSelectedRange):
289         (WebViewHost::shouldDeleteRange):
290         (WebViewHost::shouldApplyStyle):
291         (WebViewHost::didBeginEditing):
292         (WebViewHost::didChangeSelection):
293         (WebViewHost::didChangeContents):
294         (WebViewHost::didEndEditing):
295         (WebViewHost::decidePolicyForNavigation):
296         (WebViewHost::didCancelClientRedirect):
297         (WebViewHost::didStartProvisionalLoad):
298         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
299         (WebViewHost::didFailProvisionalLoad):
300         (WebViewHost::didCommitProvisionalLoad):
301         (WebViewHost::didFinishDocumentLoad):
302         (WebViewHost::didHandleOnloadEvents):
303         (WebViewHost::didFailLoad):
304         (WebViewHost::didFinishLoad):
305         (WebViewHost::didChangeLocationWithinPage):
306         (WebViewHost::willSendRequest):
307         (WebViewHost::didReceiveResponse):
308         (WebViewHost::didFinishResourceLoad):
309         (WebViewHost::didFailResourceLoad):
310         (WebViewHost::didDisplayInsecureContent):
311         (WebViewHost::didRunInsecureContent):
312         (WebViewHost::printFrameDescription):
313
314 2010-09-09  Michael Saboff  <msaboff@apple.com>
315
316         Unreviewed, adding myself to committers list.
317
318         * Scripts/webkitpy/common/config/committers.py:
319
320 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
321
322         Reviewed by Tony Chang.
323
324         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
325         https://bugs.webkit.org/show_bug.cgi?id=45479
326
327         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
328         implementation in ResourceLoadDelegate in the Mac port).
329
330         * DumpRenderTree/chromium/LayoutTestController.cpp:
331         (LayoutTestController::LayoutTestController):
332         (LayoutTestController::dumpResourceResponseMIMETypes):
333         (LayoutTestController::reset):
334         * DumpRenderTree/chromium/LayoutTestController.h:
335         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
336         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
337         * DumpRenderTree/chromium/TestShell.h:
338         (TestShell::shouldDumpResourceResponseMIMETypes):
339         * DumpRenderTree/chromium/WebViewHost.cpp:
340         (WebViewHost::didReceiveResponse):
341
342 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
343
344         Reviewed by Daniel Bates.
345
346         svn-apply tries to delete directories it shouldn't
347         https://bugs.webkit.org/show_bug.cgi?id=45424
348
349         isDirectoryEmptyForRemoval had the wrong check. If an item in the
350         directory is itself a directory, then the directory is definitely
351         not empty.
352
353         * Scripts/svn-apply:
354
355 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
356
357         Fixing GTK and windows build failure.
358
359         AX: Support AccessibilityTextMarkers in DRT
360         https://bugs.webkit.org/show_bug.cgi?id=44778
361
362         * DumpRenderTree/AccessibilityTextMarker.h:
363         (AccessibilityTextMarker::platformTextMarker):
364         (AccessibilityTextMarkerRange::platformTextMarkerRange):
365         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
366         (AccessibilityTextMarker::platformTextMarker):
367         (AccessibilityTextMarkerRange::platformTextMarkerRange):
368
369 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
370
371         Reviewed by David Kilzer.
372
373         AX: Support AccessibilityTextMarkers in DRT
374         https://bugs.webkit.org/show_bug.cgi?id=44778
375
376         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
377         that WebCore uses when vending information about its VisiblePositions through AX.
378
379         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
380         methods for encapsulating and checking equality.
381
382         This will allow future bug fixes in the text marker system to be adequately tested.
383
384         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
385         (toTextMarker):
386         (isMarkerEqualCallback):
387         (markerFinalize):
388         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
389         (AccessibilityTextMarker::getJSClass):
390         (toTextMarkerRange):
391         (isMarkerRangeEqualCallback):
392         (markerRangeFinalize):
393         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
394         (AccessibilityTextMarkerRange::getJSClass):
395         * DumpRenderTree/AccessibilityTextMarker.h: Added.
396         (AccessibilityTextMarker::platformTextMarker):
397         (AccessibilityTextMarkerRange::platformTextMarkerRange):
398         (AccessibilityTextMarker::AccessibilityTextMarker):
399         (AccessibilityTextMarker::~AccessibilityTextMarker):
400         (AccessibilityTextMarker::isEqual):
401         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
402         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
403         (AccessibilityTextMarkerRange::isEqual):
404         * DumpRenderTree/AccessibilityUIElement.cpp:
405         (textMarkerRangeForElementCallback):
406         (textMarkerRangeLengthCallback):
407         (textMarkerRangeForMarkersCallback):
408         (startTextMarkerForTextMarkerRangeCallback):
409         (endTextMarkerForTextMarkerRangeCallback):
410         (accessibilityElementForTextMarkerCallback):
411         (AccessibilityUIElement::textMarkerRangeForElement):
412         (AccessibilityUIElement::textMarkerRangeLength):
413         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
414         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
415         (AccessibilityUIElement::accessibilityElementForTextMarker):
416         (AccessibilityUIElement::getJSClass):
417         * DumpRenderTree/AccessibilityUIElement.h:
418         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
419         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
420         (AccessibilityTextMarker::AccessibilityTextMarker):
421         (AccessibilityTextMarker::~AccessibilityTextMarker):
422         (AccessibilityTextMarker::isEqual):
423         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
424         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
425         (AccessibilityTextMarkerRange::isEqual):
426         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
427         (AccessibilityUIElement::textMarkerRangeForElement):
428         (AccessibilityUIElement::textMarkerRangeLength):
429         (AccessibilityUIElement::textMarkerRangeForMarkers):
430         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
431         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
432         (AccessibilityUIElement::accessibilityElementForTextMarker):
433         * DumpRenderTree/win/DumpRenderTree.vcproj:
434
435 2010-08-25  Tony Chang  <tony@chromium.org>
436
437         Reviewed by Ojan Vafai.
438
439         don't delete duplicates needed because of intermediate results
440         https://bugs.webkit.org/show_bug.cgi?id=44653
441
442         Also, output the full path so we can pipe the output to rm.
443
444         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
445         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
446
447 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
448
449         Reviewed by Andreas Kling.
450
451         [Qt] MiniBrowser does not starts properly
452         https://bugs.webkit.org/show_bug.cgi?id=45459
453
454         Do not try set up the first window by calling newWindow on a
455         newly created BrowserWindow since it creates a new object.
456         * MiniBrowser/qt/BrowserWindow.cpp:
457         (BrowserWindow::BrowserWindow):
458         * MiniBrowser/qt/main.cpp:
459         (main):
460
461 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
462
463         Reviewed by Xan Lopez.
464
465         [GTK] Get ImageDiff building on Win32
466         https://bugs.webkit.org/show_bug.cgi?id=45353
467
468         * DumpRenderTree/gtk/ImageDiff.cpp:
469         (main): Switch from using strtok to g_strsplit.
470
471 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
472
473         Reviewed by Andreas Kling.
474
475         [Qt] Modify load method of MiniBrowser's BrowserView class
476         https://bugs.webkit.org/show_bug.cgi?id=45442
477
478         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
479
480         * MiniBrowser/qt/BrowserView.cpp:
481         (BrowserView::load):
482         * MiniBrowser/qt/BrowserView.h:
483         * MiniBrowser/qt/BrowserWindow.cpp:
484         (BrowserWindow::load):
485
486 2010-09-09  Tony Chang  <tony@chromium.org>
487
488         Reviewed by Ojan Vafai.
489
490         fix show_results in new-run-webkit-tests
491         https://bugs.webkit.org/show_bug.cgi?id=45413
492
493         * Scripts/webkitpy/layout_tests/port/chromium.py:
494
495 2010-09-08  Victor Wang  <victorw@chromium.org>
496
497         Reviewed by Ojan Vafai.
498
499         [Chromium] Fix test results server to make sure
500         it does not have corrupted data.
501
502         results.json file size coulbe be >1M and we split
503         the data into multiple data store entries in this
504         case. This patch fixes the issue that the data may
505         be corrupted if data store error happens in the middle
506         of saving multiple entries.
507
508         https://bugs.webkit.org/show_bug.cgi?id=45063
509
510         * TestResultServer/model/datastorefile.py:
511
512 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
513
514         Reviewed by Kenneth Rohde Christiansen.
515
516         Fix ignoring return value warning in case of gcc 4.4.4
517         https://bugs.webkit.org/show_bug.cgi?id=45384
518
519         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
520         (testPostURLFile):
521         If fwrite have written zero byte then the testPostURLFile function
522         returns with false as tempFile can't be opened.
523         * DumpRenderTree/qt/ImageDiff.cpp:
524         (main):
525         Put fwrite function into an if condition without body to avoid
526         warning. It is safe because this function writes to the stdout.
527
528 2010-09-08  Satish Sampath  <satish@chromium.org>
529
530         Unreviewed, adding myself to committers list.
531
532         * Scripts/webkitpy/common/config/committers.py:
533
534 2010-09-08  Hans Wennborg  <hans@chromium.org>
535
536         Unreviewed.
537
538         Adding myself as a committer in committers.py.
539
540         * Scripts/webkitpy/common/config/committers.py:
541
542 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
543
544         Reviewed by Simon Hausmann.
545
546         [Qt] Refactor MiniBrowser 
547         https://bugs.webkit.org/show_bug.cgi?id=45173
548
549         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
550
551         * MiniBrowser/qt/BrowserView.cpp: Added.
552         (createNewPage):
553         (BrowserView::BrowserView):
554         (BrowserView::resizeEvent):
555         (BrowserView::load):
556         (BrowserView::view):
557         * MiniBrowser/qt/BrowserView.h: Added.
558         (BrowserView::~BrowserView):
559         * MiniBrowser/qt/BrowserWindow.cpp:
560         * MiniBrowser/qt/BrowserWindow.h:
561         * MiniBrowser/qt/MiniBrowser.pro:
562
563 2010-09-08  Adam Barth  <abarth@webkit.org>
564
565         Rubber-stamped by Eric Seidel.
566
567         Rename DocLoader to CachedResourceLoader because that's what it does.
568
569         * Scripts/do-webcore-rename:
570
571 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
572
573         Reviewed by Ojan Vafai.
574
575         Enable incremental results.json generation for non-layout tests.
576         https://bugs.webkit.org/show_bug.cgi?id=45315
577
578         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
579
580         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
581
582
583 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
584
585         Unreviewed, build fix
586
587         Missed one test in mac_unittest.py in previous change; for some
588         reason the method is listed twice. I will fix both for now, but will
589         figure this out in a later, not-time-sensitive patch.
590
591         https://bugs.webkit.org/show_bug.cgi?id=45357
592
593         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
594
595 2010-09-07  Kent Tamura  <tkent@chromium.org>
596
597         Reviewed by Tony Chang.
598
599         test-webkitpy: Fix load error of
600         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
601         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
602
603         * Scripts/webkitpy/layout_tests/port/server_process.py:
604           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
605           and we don't use server_process.py on Win32 Python. However
606           unittest.py tries to load everything in a module.
607
608 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
609
610         Reviewed by Kent Tamura.
611
612         Fix regression introduced in previous change to new-run-webkit-tests
613         (bug 45090) to not try to run unittests for the Mac implementation
614         of the Port interface if we aren't running on a Mac.
615
616         Also fix the overrides implementation mock in the chromium unittests
617         to fix the case where there are overrides checked in that cause
618         problems.
619
620         https://bugs.webkit.org/show_bug.cgi?id=45357
621
622         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
623         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
624         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
625
626 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
627
628         Reviewed by Ojan Vafai.
629
630         new-run-webkit-tests: still more unit tests
631
632         Clean up and remove unnecessary code. Biggest notable change is
633         moving the chromium-specific imagediff code from port/base to
634         port/chromium.
635
636         Add more unit tests for run_webkit_tests.py, port/base.py,
637         port/factory.py, port/dryrun.py, and
638         layout_package/dump_render_tree_thread.py
639
640         This covers almost all of the generic and test code paths except for
641         a few error paths involving invalid or port-specific command line
642         arguments, and the code path for uploading results files to the
643         buildbots.
644         
645         https://bugs.webkit.org/show_bug.cgi?id=45090
646
647         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
648         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
649         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
650         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
651         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
652         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
653         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
654         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
655         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
656         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
657         * Scripts/webkitpy/layout_tests/port/base.py:
658         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
659         * Scripts/webkitpy/layout_tests/port/chromium.py:
660         * Scripts/webkitpy/layout_tests/port/dryrun.py:
661         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
662         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
663         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
664         * Scripts/webkitpy/layout_tests/port/server_process.py:
665         * Scripts/webkitpy/layout_tests/port/test.py:
666         * Scripts/webkitpy/layout_tests/port/webkit.py:
667         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
668         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
669
670 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
671
672         Reviewed by Darin Adler.
673
674         Provide a way to trigger a <select multiple> onchange event on changes
675         https://bugs.webkit.org/show_bug.cgi?id=45192
676
677         Adds a selector on ObjCController for testing
678         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
679         its different uses.
680
681         * DumpRenderTree/mac/ObjCController.m:
682         (+[ObjCController isSelectorExcludedFromWebScript:]):
683         (+[ObjCController webScriptNameForSelector:]):
684         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
685
686 2010-09-07  James Robinson  <jamesr@chromium.org>
687
688         Rubber-stamped by Dimitri Glazkov.
689
690         Move myself from the committer to the reviewer list.
691
692         * Scripts/webkitpy/common/config/committers.py:
693
694 2010-09-07  Tony Chang  <tony@chromium.org>
695
696         Reviewed by Darin Fisher.
697
698         [chromium] Make a public flag for how DRT generates bitmaps on Linux
699         https://bugs.webkit.org/show_bug.cgi?id=45133
700
701         * DumpRenderTree/chromium/TestShell.cpp:
702         (TestShell::dumpImage):
703
704 2010-09-07  Kent Tamura  <tkent@chromium.org>
705
706         Reviewed by Dimitri Glazkov.
707
708         [DRT/Chromium] Implement --check-layout-test-sys-deps
709         https://bugs.webkit.org/show_bug.cgi?id=45283
710
711         * DumpRenderTree/chromium/DumpRenderTree.cpp:
712         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
713         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
714         * DumpRenderTree/chromium/TestShellGtk.cpp:
715         (checkLayoutTestSystemDependencies): Add an empty implementation.
716         * DumpRenderTree/chromium/TestShellMac.mm:
717         (checkLayoutTestSystemDependencies): Add an empty implementation.
718         * DumpRenderTree/chromium/TestShellWin.cpp:
719         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
720
721 2010-09-07  Jessie Berlin  <jberlin@apple.com>
722
723         Unreviewed. Mac build fix.
724
725         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
726         (didClearWindowObjectForFrame):
727
728 2010-09-07  Jessie Berlin  <jberlin@apple.com>
729
730         Reviewed by Darin Adler.
731
732         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
733         https://bugs.webkit.org/show_bug.cgi?id=45217
734         
735         Make WebKitTestRunner work with this change.
736
737         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
738         (WTR::InjectedBundlePage::didClearWindowForFrame):
739         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
740         WebFrameLoaderClient.
741         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
742
743 2010-09-07  Philippe Normand  <pnormand@igalia.com>
744
745         Unreviewed, build fix.
746
747         webkit-patch command to find the ports covering a specific layout test
748         https://bugs.webkit.org/show_bug.cgi?id=42832
749
750         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
751         tests are present when building the expectations. This is needed
752         for the unittests.
753
754 2010-09-06  Philippe Normand  <pnormand@igalia.com>
755
756         Reviewed by Adam Barth.
757
758         webkit-patch command to find the ports covering a specific layout test
759         https://bugs.webkit.org/show_bug.cgi?id=42832
760
761         To use it: webkit-patch skipped-ports some/layout/test.html
762
763         * Scripts/webkitpy/layout_tests/port/base.py:
764         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
765         * Scripts/webkitpy/layout_tests/port/chromium.py:
766         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
767         * Scripts/webkitpy/layout_tests/port/factory.py:
768         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
769         * Scripts/webkitpy/layout_tests/port/test.py:
770         * Scripts/webkitpy/layout_tests/port/webkit.py:
771         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
772         * Scripts/webkitpy/tool/commands/queries.py:
773         * Scripts/webkitpy/tool/commands/queries_unittest.py:
774         * Scripts/webkitpy/tool/main.py:
775         * Scripts/webkitpy/tool/mocktool.py:
776
777 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
778
779         Reviewed by Eric Seidel.
780
781         [NRWT] Add temp directory to all running drivers.
782         https://bugs.webkit.org/show_bug.cgi?id=45261
783
784         * Scripts/webkitpy/layout_tests/port/webkit.py:
785
786 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
787
788         Reviewed by Kent Tamura.
789
790         [Chromium/DRT] Empty out user stylesheet after each test run.
791         https://bugs.webkit.org/show_bug.cgi?id=45282
792
793         This should significantly cut down on the number of the mysterious flaky tests
794         whose diffs looked like the page was blown up to a very lage size. This
795         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
796         which set the base body font to 100px.
797
798         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
799         the same thread failed.
800
801         * DumpRenderTree/chromium/TestShell.cpp:
802         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
803
804 2010-09-06  Kent Tamura  <tkent@chromium.org>
805
806         Reviewed by Dimitri Glazkov.
807
808         [DRT/Chromium] Do not generate pixel results for text/plain resources
809         https://bugs.webkit.org/show_bug.cgi?id=45253
810
811         * DumpRenderTree/chromium/TestShell.cpp:
812         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
813
814 2010-09-06  Ojan Vafai  <ojan@chromium.org>
815
816         Reviewed by Kent Tamura.
817
818         print out correct error when a DRT thread dies in NRWT
819         https://bugs.webkit.org/show_bug.cgi?id=45281
820
821         Not sure why, but with the parens, python 2.6.5 on Linux
822         gives an error that raise takes 5 arguments and 0 were given.
823         Didn't test other platforms or python versions, but putting it
824         all on one line fixes it and correctly prints the exception
825         from the DRT thread.
826
827         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
828
829 2010-09-06  Eric Seidel  <eric@webkit.org>
830
831         Unreviewed, just adding some emails from lists.webkit.org.
832
833         Update committers.py to include emails from lists.webkit.org
834         as found by the validate-committer-lists script.
835
836         * Scripts/webkitpy/common/config/committers.py:
837
838 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
839
840         Reviewed by Xan Lopez.
841
842         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
843         https://bugs.webkit.org/show_bug.cgi?id=45213
844
845         * DumpRenderTree/gtk/DumpRenderTree.cpp:
846         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
847         have to surround the invocation with #ifdefs.
848         (useLongRunningServerMode): Added.
849         (runTestingServerLoop): Added.
850         (initializeGlobalsFromCommandLineOptions): Added.
851         (runTest): Removed ifdefs.
852         (main): Use new helper functions.
853
854 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
855
856         Reviewed by Xan Lopez.
857
858         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
859         https://bugs.webkit.org/show_bug.cgi?id=45235
860
861         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
862         methods of the EventSender.
863
864         * DumpRenderTree/gtk/EventSender.cpp:
865         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
866         with the current modifiers.
867         (contextClickCallback): Always send no modifiers when preparing the mouse event.
868         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
869         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
870         (mouseUpCallback): Ditto.
871
872 2010-09-05  Peter Kasting  <pkasting@google.com>
873
874         Reviewed by Adam Barth.
875
876         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
877         https://bugs.webkit.org/show_bug.cgi?id=45155
878
879         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
880         (EventSender::handleMouseWheel):
881
882 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
883
884         Reviewed by Joseph Pecoraro.
885
886         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
887         https://bugs.webkit.org/show_bug.cgi?id=45179
888
889         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
890         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
891
892 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
893
894         Rubber-stamped by Daniel Bates.
895
896         Adding myself as reviewer.
897
898         * Scripts/webkitpy/common/config/committers.py:
899
900 2010-09-04  Daniel Bates  <dbates@rim.com>
901
902         Reviewed by Martin Robinson.
903
904         Teach svn-apply/unapply about svn:mergeinfo
905         https://bugs.webkit.org/show_bug.cgi?id=45236
906
907         Recognize the svn:mergeinfo property and ignore it for now.
908
909         Currently, svn-apply/unapply recognize only '+' and '-'
910         property changes within a diff. We should add support
911         to recognize "Merged" and "Reverse-merged" changes as well.
912         Because svn:mergeinfo is metadata that is used only by SVN
913         and tends to be error-prone and/or nuisance (*), we will ignore
914         it for now.
915         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
916
917         * Scripts/VCSUtils.pm:
918           - Modified parseSvnProperty() to recognize "Merged" and
919             "Reverse-merged" as the start of a property value.
920         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
921           - Added the following unit tests:
922             "simple: add svn:mergeinfo"
923             "simple: delete svn:mergeinfo"
924             "simple: modified svn:mergeinfo"
925         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
926           - Added the following unit tests:
927             "simple: add svn:mergeinfo"
928             "simple: delete svn:mergeinfo"
929             "simple: modified svn:mergeinfo"
930             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
931             "'Merged' change followed by 'Merged' change"
932             "'Reverse-merged' change followed by 'Reverse-merged' change"
933         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
934           - Added the following unit tests:
935             "'Merged' change"
936             "'Reverse-merged' change"
937             "'Reverse-merged' change followed by 'Merge' change"
938             "'Merged' change followed by 'Merge' change"
939             "'Reverse-merged' change followed by 'Reverse-merged' change"
940             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
941
942 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
943
944         Reviewed by Kenneth Rohde Christiansen.
945
946         [EFL] Move test browser to WebKitTools directory
947         https://bugs.webkit.org/show_bug.cgi?id=45212
948
949         Follow other ports like QT and GTK which moved the test browser to
950         WebKitTools directory.
951
952         * CMakeListsEfl.txt: Added.
953         * EWebLauncher/main.c: Added.
954         (print_history):
955         (zoom_level_set):
956         (on_ecore_evas_resize):
957         (title_set):
958         (viewport_set):
959         (on_title_changed):
960         (on_progress):
961         (on_load_finished):
962         (on_toolbars_visible_set):
963         (on_toolbars_visible_get):
964         (on_statusbar_visible_set):
965         (on_statusbar_visible_get):
966         (on_scrollbars_visible_set):
967         (on_scrollbars_visible_get):
968         (on_menubar_visible_set):
969         (on_menubar_visible_get):
970         (on_tooltip_text_set):
971         (on_inputmethod_changed):
972         (on_viewport_changed):
973         (on_mouse_down):
974         (on_focus_out):
975         (on_focus_in):
976         (on_resized):
977         (on_key_down):
978         (on_browser_del):
979         (on_closeWindow):
980         (quit):
981         (browserCreate):
982         (browserDestroy):
983         (closeWindow):
984         (main_signal_exit):
985         (findThemePath):
986         (main):
987
988 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
989
990         Reviewed by Adam Roben.
991
992         Set project dependencies so that they build serially. This fixes
993         issues when running run-webkit-tests if DRT is not built yet.
994
995         * DumpRenderTree/DumpRenderTree.sln:
996
997 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
998
999         Reviewed by Adam Barth.
1000
1001         Fix reading configuraiton in NWRT to work on Windows.
1002         https://bugs.webkit.org/show_bug.cgi?id=45180
1003
1004         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
1005             with the file otherwise.
1006
1007 2010-09-03  Chris Rogers  <crogers@google.com>
1008
1009         Unreviewed
1010
1011         Add myself to the committers list
1012         https://bugs.webkit.org/show_bug.cgi?id=45189
1013
1014         * Scripts/webkitpy/common/config/committers.py:
1015
1016 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
1017
1018         Reviewed by Yury Semikhatsky.
1019
1020         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
1021         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
1022         https://bugs.webkit.org/show_bug.cgi?id=45137
1023
1024         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
1025
1026 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1027
1028         Reviewed by Eric Seidel.
1029
1030         Add feature detection support to NRWT.
1031         https://bugs.webkit.org/show_bug.cgi?id=41842
1032
1033         * Scripts/webkitpy/layout_tests/port/base.py:
1034         * Scripts/webkitpy/layout_tests/port/qt.py:
1035         * Scripts/webkitpy/layout_tests/port/webkit.py:
1036         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
1037
1038 2010-09-03  Hironori Bono  <hbono@chromium.org>
1039
1040         Reviewed by Kent Tamura.
1041
1042         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
1043         and implements it for Mac.
1044         https://bugs.webkit.org/show_bug.cgi?id=41832
1045
1046         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
1047         and bind it so we can call it from JavaScript.
1048         (+[TextInputController isSelectorExcludedFromWebScript:]):
1049         (+[TextInputController webScriptNameForSelector:]):
1050         (-[TextInputController hasSpellingMarker:length:]):
1051
1052 2010-09-02  Eric Seidel  <eric@webkit.org>
1053
1054         Reviewed by Adam Barth.
1055
1056         Add a unit test for commit-queue retries
1057         https://bugs.webkit.org/show_bug.cgi?id=45162
1058
1059         I think commit-queue retries are not correctly avoiding
1060         build and test on retries.  So I started testing the code.
1061         Unfortunately this test did not find the bug.  But now
1062         that we have the test we might as well keep it.
1063         I also fixed a broken import in validate-committer-lists.
1064
1065         * Scripts/validate-committer-lists:
1066         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1067
1068 2010-09-02  Kent Tamura  <tkent@chromium.org>
1069
1070         Reviewed by Dimitri Glazkov.
1071
1072         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
1073         https://bugs.webkit.org/show_bug.cgi?id=45091
1074
1075         Task.{cpp,h} introduces a simpler version of Chromium
1076         base/task.h. It doesn't have TupleN and Method.
1077
1078         * DumpRenderTree/DumpRenderTree.gypi:
1079          Add Task.cpp and Task.h
1080         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1081         (DRTDevToolsAgent::DRTDevToolsAgent):
1082         (DRTDevToolsAgent::reset):
1083         (DRTDevToolsAgent::asyncCall):
1084         (DRTDevToolsAgent::frontendLoaded):
1085         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1086         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
1087         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1088         (DRTDevToolsClient::DRTDevToolsClient):
1089         (DRTDevToolsClient::~DRTDevToolsClient):
1090         (DRTDevToolsClient::reset):
1091         (DRTDevToolsClient::asyncCall):
1092         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1093         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
1094         * DumpRenderTree/chromium/EventSender.cpp:
1095         (EventSender::EventSender):
1096         (EventSender::reset):
1097         (EventSender::scheduleAsynchronousClick):
1098         * DumpRenderTree/chromium/EventSender.h:
1099         (EventSender::taskList): Added to use MethodTask<T>.
1100         * DumpRenderTree/chromium/LayoutTestController.cpp:
1101         (LayoutTestController::LayoutTestController):
1102         (LayoutTestController::WorkQueue::processWorkSoon):
1103         (LayoutTestController::waitUntilDone):
1104         (LayoutTestController::notifyDone):
1105         (LayoutTestController::reset):
1106         * DumpRenderTree/chromium/LayoutTestController.h:
1107         (LayoutTestController::taskList): Added to use MethodTask<T>.
1108         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
1109         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1110         (deferredDisplayDispatch):
1111         (NotificationPresenter::show):
1112         * DumpRenderTree/chromium/Task.cpp: Added.
1113         * DumpRenderTree/chromium/Task.h: Added.
1114
1115 2010-09-02  Steve Block  <steveblock@google.com>
1116
1117         Reviewed by Adam Barth.
1118
1119         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
1120         https://bugs.webkit.org/show_bug.cgi?id=43181
1121
1122         * DumpRenderTree/mac/DumpRenderTree.mm:
1123         (createWebViewAndOffscreenWindow):
1124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1125         (LayoutTestController::setMockDeviceOrientation):
1126
1127 2010-08-31  Adam Roben  <aroben@apple.com>
1128
1129         Fix flashiness when resizing the browser window on Windows
1130
1131         Reviewed by Sam Weinig.
1132
1133         * MiniBrowser/win/BrowserWindow.cpp:
1134         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
1135         periodically fill the window with white.
1136
1137 2010-09-02  Peter Kasting  <pkasting@google.com>
1138
1139         Reviewed by Dimitri Glazkov.
1140
1141         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
1142         https://bugs.webkit.org/show_bug.cgi?id=45073
1143
1144         * DumpRenderTree/chromium/EventSender.cpp:
1145         (EventSender::EventSender):
1146         (EventSender::mouseScrollBy):
1147         (EventSender::continuousMouseScrollBy):
1148         (EventSender::sendCurrentTouchEvent):
1149         (EventSender::handleMouseWheel):
1150         * DumpRenderTree/chromium/EventSender.h:
1151         * DumpRenderTree/gtk/EventSender.cpp:
1152         (mouseScrollByCallback):
1153         (continuousMouseScrollByCallback):
1154
1155 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1156
1157         Reviewed by Tony Chang.
1158
1159         Land a patched version of r66542 - change TestRunner to have an
1160         separate cleanup method and fix the ordering of cleanup between
1161         TestRunner and the printing module, and then wrap everything in a
1162         try/finally block to ensure reliable cleanup without needing to
1163         rely on stuff happening in the destructor of the TestRunner.
1164
1165         Also refactor run_webkit_tests.run() to be much smaller and cleaner
1166         by creating a bunch of helper methods and moving more stuff into
1167         the TestRunner class.
1168
1169         This fixes the crash at the end of the linux test run of
1170         new-run-webkit-tests (and undoes the rollout in 66547).
1171
1172         https://bugs.webkit.org/show_bug.cgi?id=44902
1173
1174         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1175         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1176         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1177         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1178         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1179         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1180         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1181         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1182         * Scripts/webkitpy/layout_tests/port/base.py:
1183         * Scripts/webkitpy/layout_tests/port/test.py:
1184         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1185         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1186
1187 2010-09-01  Mark Rowe  <mrowe@apple.com>
1188
1189         Reviewed by Adam Roben.
1190
1191         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
1192
1193         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1194
1195 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
1196
1197         Reviewed by Adam Roben.
1198
1199         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
1200         and WebKitTestRunner.
1201
1202         * BuildSlaveSupport/win/kill-old-processes:
1203
1204 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1205
1206         Reviewed by Antonio Gomes.
1207
1208         [Qt] Remove obsolete include path from DumpRenderTree.pro
1209
1210         * DumpRenderTree/qt/DumpRenderTree.pro:
1211
1212 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1213
1214         Reviewed by Laszlo Gombos.
1215
1216         [Qt] QWebPage::allowGeolocationRequest should be async API
1217         https://bugs.webkit.org/show_bug.cgi?id=41364
1218
1219         Implements new async API for geolocation permission similar to
1220         Notification. WebPage maintains list of geolocation permission request
1221         QtWebkit and set's when LayoutTestController gets the access from test JS
1222
1223         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1224         (WebCore::WebPage::WebPage):
1225         (WebCore::WebPage::resetSettings):
1226         (WebCore::WebPage::requestPermission):
1227         (WebCore::WebPage::cancelPermission):
1228         (WebCore::WebPage::permissionSet):
1229         (WebCore::DumpRenderTree::DumpRenderTree):
1230         (WebCore::DumpRenderTree::processLine):
1231         (WebCore::DumpRenderTree::geolocationPermissionSet):
1232         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1233         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1234         (LayoutTestController::reset):
1235         (LayoutTestController::setGeolocationPermission):
1236         (LayoutTestController::setGeolocationPermissionCommon):
1237         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1238
1239 2010-09-01  Andras Becsi  <abecsi@webkit.org>
1240
1241         Reviewed by Antti Koivisto.
1242
1243         [Qt] Auto-generate WebKit2 forwarding headers
1244         https://bugs.webkit.org/show_bug.cgi?id=44692
1245
1246         * MiniBrowser/qt/BrowserWindow.h: use source style includes
1247         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
1248         * Scripts/enumerate-included-framework-headers: Removed.
1249
1250 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1251
1252         Reviewed by Adam Barth.
1253
1254         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
1255         https://bugs.webkit.org/show_bug.cgi?id=44789
1256
1257         * Scripts/webkitpy/common/net/bugzilla.py:
1258
1259 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
1260
1261         Reviewed by Adam Barth.
1262
1263         ews: Add support for EFL-EWS
1264         https://bugs.webkit.org/show_bug.cgi?id=44982
1265
1266         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
1267         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
1268         and add it to the ports dict.
1269         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
1270         EflEWS class.
1271         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
1272         a test case for the EFL EWS.
1273
1274 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
1275
1276         Reviewed by Sam Weinig.
1277
1278         https://bugs.webkit.org/show_bug.cgi?id=42195
1279         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
1280
1281         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1282         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
1283         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1284         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
1285         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
1286
1287         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1288         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
1289         which forgets its override.
1290
1291 2010-08-31  Sam Weinig  <sam@webkit.org>
1292
1293         Reviewed by Gavin Barraclough.
1294
1295         WebKitTestRunner needs layoutTestController.addUserStyleSheet
1296         https://bugs.webkit.org/show_bug.cgi?id=42680
1297
1298         WebKitTestRunner needs layoutTestController.addUserScript
1299         https://bugs.webkit.org/show_bug.cgi?id=42681
1300
1301         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1302         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1303         (WTR::InjectedBundle::beginTesting):
1304         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1305         (WTR::LayoutTestController::addUserScript):
1306         (WTR::LayoutTestController::addUserStyleSheet):
1307         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1308
1309 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1310
1311         Unreviewed, rolling out r66542.
1312         http://trac.webkit.org/changeset/66542
1313         https://bugs.webkit.org/show_bug.cgi?id=44902
1314
1315         r66542 - the weird logging dependencies in Python stuck again ...
1316
1317         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
1318         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
1319         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
1320         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
1321         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1322         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1323         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1324         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1325         * Scripts/webkitpy/layout_tests/port/base.py:
1326         * Scripts/webkitpy/layout_tests/port/test.py:
1327         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1328         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1329
1330 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
1331
1332         Reviewed by Tony Chang.
1333
1334         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
1335
1336         * DumpRenderTree/chromium/LayoutTestController.cpp:
1337         (LayoutTestController::LayoutTestController):
1338         (LayoutTestController::markerTextForListItem):
1339         * DumpRenderTree/chromium/LayoutTestController.h:
1340
1341 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1342
1343         Reviewed by Ojan Vafai.
1344
1345         new-run-webkit-tests: add more unit tests
1346
1347         Add more unit tests for new-run-webkit-tests; we now cover all but
1348         the most obscure code paths in the generic code. We still need to
1349         add coverage for the http server and web socket paths, and add better
1350         coverage of the platform-specific logic. Note that the rebaselining
1351         tool is still not well tested.
1352
1353         Also clean up some of the configuration logic for the printing
1354         module and the way it interacts with the Python logging module; that
1355         is a crufty interface, to be certain.
1356         
1357         https://bugs.webkit.org/show_bug.cgi?id=44902
1358
1359         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1360         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1361         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1362         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1363         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1364         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1365         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1366         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1367         * Scripts/webkitpy/layout_tests/port/base.py:
1368         * Scripts/webkitpy/layout_tests/port/test.py:
1369         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1370         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1371
1372 2010-08-31  Darin Adler  <darin@apple.com>
1373
1374         Reviewed by Anders Carlsson.
1375
1376         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
1377         in a debug build when built with certain compilers.
1378
1379 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
1380
1381         Reviewed by Gustavo Noronha Silva.
1382
1383         [GTK] Isolate all GTK+ typedefs into one file
1384         https://bugs.webkit.org/show_bug.cgi?id=44900
1385
1386         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
1387
1388 2010-08-31  Eric Seidel  <eric@webkit.org>
1389
1390         Reviewed by Adam Barth.
1391
1392         Show more status on queue status pages
1393         https://bugs.webkit.org/show_bug.cgi?id=44938
1394
1395         I upped the number of status lines from 6 to 15 --
1396         this has been bugging me for a while...
1397
1398         I also disabled showing the chromium-win EWS queue
1399         since it's been down for almost 5 months now.
1400
1401         * QueueStatusServer/handlers/dashboard.py:
1402         * QueueStatusServer/handlers/queuestatus.py:
1403         * QueueStatusServer/model/queues.py:
1404
1405 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
1406
1407         Reviewed by Antonio Gomes.
1408
1409         [Qt] Read command line arguments and open them as URLs in new windows
1410         https://bugs.webkit.org/show_bug.cgi?id=44944
1411
1412         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
1413
1414         * MiniBrowser/qt/main.cpp:
1415         (main):
1416
1417 2010-08-31  Adrian Perez  <aperez@igalia.com>
1418
1419         Reviewed by Martin Robinson.
1420
1421         Support scripts to run Buildbot slaves under daemontools (gtk related)
1422         https://bugs.webkit.org/show_bug.cgi?id=40053
1423
1424         * BuildSlaveSupport/gtk: Added.
1425         * BuildSlaveSupport/gtk/README: Added.
1426         * BuildSlaveSupport/gtk/buildbot: Added.
1427         * BuildSlaveSupport/gtk/buildbot/log: Added.
1428         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
1429         * BuildSlaveSupport/gtk/buildbot/run: Added.
1430         * BuildSlaveSupport/gtk/crashmon: Added.
1431         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
1432         * BuildSlaveSupport/gtk/crashmon/log: Added.
1433         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
1434         * BuildSlaveSupport/gtk/crashmon/run: Added.
1435         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
1436         * BuildSlaveSupport/gtk/pulseaudio: Added.
1437         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
1438         * BuildSlaveSupport/gtk/xvfb: Added.
1439         * BuildSlaveSupport/gtk/xvfb/log: Added.
1440         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
1441         * BuildSlaveSupport/gtk/xvfb/run: Added.
1442
1443 2010-08-27  John Gregg  <johnnyg@google.com>
1444
1445         Reviewed by David Levin.
1446
1447         Notifications should support a click event.
1448         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
1449         can be simulated during a layout test.  Requires storing a list of active
1450         notifications so that they can be referred to later for clicking.
1451         https://bugs.webkit.org/show_bug.cgi?id=44800
1452
1453         * DumpRenderTree/chromium/LayoutTestController.cpp:
1454         (LayoutTestController::LayoutTestController):
1455         (LayoutTestController::simulateDesktopNotificationClick):
1456         * DumpRenderTree/chromium/LayoutTestController.h:
1457         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1458         (NotificationPresenter::simulateClick):
1459         (NotificationPresenter::show):
1460         (NotificationPresenter::cancel):
1461         (NotificationPresenter::objectDestroyed):
1462         * DumpRenderTree/chromium/NotificationPresenter.h:
1463
1464 2010-08-30  Alice Liu  <alice.liu@apple.com>
1465
1466         Reviewed by Darin Adler.
1467
1468         Add missing parts of didFinishDocumentLoadForFrame
1469         https://bugs.webkit.org/show_bug.cgi?id=44913
1470
1471         * MiniBrowser/mac/BrowserWindowController.m:
1472         (didFinishDocumentLoadForFrame): Added
1473         (-[BrowserWindowController awakeFromNib]): Updated struct
1474         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1475         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
1476         * WebKitTestRunner/TestController.cpp:
1477         (WTR::TestController::initialize): Updated struct
1478
1479 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
1480
1481         Unreviewed: Add myself to the list of Committers.
1482
1483         * Scripts/webkitpy/common/config/committers.py:
1484
1485 2010-08-30  Kent Tamura  <tkent@chromium.org>
1486
1487         Reviewed by Adam Barth.
1488
1489         Fix fast/notifications/notifications-display-close-events.html failure
1490         https://bugs.webkit.org/show_bug.cgi?id=44585
1491
1492         Apply http://crrev.com/48893. We should dispatch display events
1493         asynchronously.
1494
1495         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1496         (deferredDisplayDispatch):
1497         (NotificationPresenter::show):
1498
1499 2010-08-30  Robert Hogan  <robert@webkit.org>
1500
1501         Reviewed by Simon Hausmann.
1502
1503         allow ports with windowed plugins to support windowless plugin tests
1504
1505         https://bugs.webkit.org/show_bug.cgi?id=40730
1506
1507         Ports that implement plugins windowed by default need to have a way of
1508         supporting plugin tests that assume the plugin is windowless. Add this
1509         feature to the tests and support it in the webkit test plugin. Also
1510         add mouse and keyboard event logging to the webkit-test plugin on Unix.
1511
1512         Unskip the following tests on Qt:
1513
1514         plugins/mouse-events.html
1515         plugins/keyboard-events.html
1516         plugins/mouse-events-fixedpos.html
1517
1518         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1519         (pluginSetProperty):
1520         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1521         (NPP_New):
1522         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1523         (webkit_test_plugin_handle_event):
1524
1525 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
1526
1527         [wx] Build fix after addition of fileapi directory in WebCore.
1528
1529         * wx/build/settings.py:
1530
1531 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1532
1533         Reviewed by Xan Lopez.
1534
1535         Fixed compilation error, now that we have included the
1536         GtkVersioning.h we have to remove some version dependent code from
1537         EventSender.
1538
1539         * DumpRenderTree/gtk/EventSender.cpp:
1540
1541 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
1542
1543         Reviewed by Martin Robinson.
1544
1545         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
1546         are deprecated
1547         https://bugs.webkit.org/show_bug.cgi?id=44787
1548
1549         We have replaced GtkVersioning.cpp with GtkVersioning.c and
1550         created a function (getDefaultGDKPointerDevice) to get the pointer
1551         of the window with the new APIs. We added that function to DRT and
1552         copyandpaste unit test.
1553
1554         * DumpRenderTree/gtk/EventSender.cpp:
1555         (prepareMouseButtonEvent):
1556         (mouseMoveToCallback):
1557         (keyDownCallback):
1558         * GNUmakefile.am:
1559
1560 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
1561
1562         Reviewed by Kenneth Rohde Christiansen.
1563
1564         [Qt] Add new window menu to MiniBrowser
1565
1566         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
1567
1568         * MiniBrowser/qt/BrowserWindow.cpp:
1569         (BrowserWindow::BrowserWindow):
1570         (BrowserWindow::newWindow):
1571         * MiniBrowser/qt/BrowserWindow.h:
1572         * MiniBrowser/qt/main.cpp:
1573         (main):
1574
1575 2010-08-29  James Robinson  <jamesr@chromium.org>
1576
1577         Reviewed by David Levin.
1578
1579         Make failing the download step fail the build
1580         https://bugs.webkit.org/show_bug.cgi?id=44298
1581
1582         If the download step fails on a test bot, this ensures that
1583         the build goes red instead of only the download step going red
1584         and the overall build staying green.
1585
1586         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1587
1588 2010-08-29  Kent Tamura  <tkent@chromium.org>
1589
1590         Reviewed by Dimitri Glazkov.
1591
1592         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
1593         https://bugs.webkit.org/show_bug.cgi?id=44847
1594
1595         * DumpRenderTree/chromium/EventSender.cpp:
1596          Use webkit_support::VKEY_* instead of base::VKEY_*.
1597
1598 2010-08-29  Darin Adler  <darin@apple.com>
1599
1600         https://bugs.webkit.org/show_bug.cgi?id=40589
1601
1602         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
1603         function names.
1604
1605 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1606
1607         Reviewed by Darin Adler.
1608
1609         [iExploder] Add new CSS Properties and HTML Attributes
1610         https://bugs.webkit.org/show_bug.cgi?id=44746
1611
1612         Updated the files with the update-iexploder-cssproperties script
1613         and manually readded the -webkit-binding CSS Property to the list.
1614
1615         * iExploder/htdocs/cssproperties.in:
1616         * iExploder/htdocs/htmlattrs.in:
1617         * iExploder/htdocs/htmltags.in:
1618
1619 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1620
1621         Reviewed by Darin Adler.
1622
1623         Fix Coverage build after the addition of ANGLE
1624         https://bugs.webkit.org/show_bug.cgi?id=44744
1625
1626         ANGLE is using libtool to build a static library and the version of
1627         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
1628         parameters. The easiest way to handle this is to not build ANGLE with
1629         coverage information.
1630
1631         This is achieved by applying the XCode options for each project
1632         separately and exclude ANGLE.
1633
1634         * Scripts/build-webkit: Remove -framework AppKit due link errors.
1635         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
1636
1637 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
1638
1639         [wx] Build fix after directory addition.
1640
1641         * wx/build/settings.py:
1642
1643 2010-08-28  Chris Guillory   <chris.guillory@google.com>
1644
1645         Reviewed by Chris Fleizach.
1646
1647         Add AX notification for childrenChanged
1648         https://bugs.webkit.org/show_bug.cgi?id=44472
1649
1650         * DumpRenderTree/chromium/AccessibilityController.cpp:
1651         (AccessibilityController::AccessibilityController):
1652         (AccessibilityController::reset):
1653         (AccessibilityController::getRootElement):
1654         (AccessibilityController::dumpAccessibilityNotifications):
1655         * DumpRenderTree/chromium/AccessibilityController.h:
1656         (AccessibilityController::shouldDumpAccessibilityNotifications):
1657         * DumpRenderTree/chromium/WebViewHost.cpp:
1658         (WebViewHost::didChangeAccessibilityObjectChildren):
1659         * DumpRenderTree/chromium/WebViewHost.h:
1660
1661 2010-08-28  Eric Seidel  <eric@webkit.org>
1662
1663         Reviewed by Adam Barth.
1664
1665         Update commit-queue failure message
1666         https://bugs.webkit.org/show_bug.cgi?id=44798
1667
1668         The commit-queue auto-restarts itself and has for a very long time.
1669         No need for people to email me to request a restart anymore.
1670
1671         * Scripts/webkitpy/common/net/bugzilla.py:
1672         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1673         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1674
1675 2010-07-27  Jer Noble  <jer.noble@apple.com>
1676
1677         Reviewed by Eric Carlson.
1678
1679         Add JavaScript API to allow a page to go fullscreen.
1680         rdar://problem/6867795
1681         
1682         Added basic full screen support to DumpRenderTree: when a webView requests
1683         that DumpRenderTree go "full screen", just call the provided callback listener object's
1684         will/did Enter/Exit full screen methods.  Also, register a new user default which 
1685         enables full screen support.
1686
1687         * DumpRenderTree/mac/DumpRenderTree.mm:
1688         (resetDefaultsToConsistentValues):
1689         * DumpRenderTree/mac/UIDelegate.mm:
1690         (-[UIDelegate webView:supportsFullscreenForElement:]):
1691         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
1692         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
1693
1694 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1695
1696         Unreviewed. Add myself to the committers list.
1697
1698         * Scripts/webkitpy/common/config/committers.py:
1699
1700 2010-08-27  Kent Tamura  <tkent@chromium.org>
1701
1702         Reviewed by Pavel Feldman.
1703
1704         [DRT/Chromium] Fix inspector test failures
1705         https://bugs.webkit.org/show_bug.cgi?id=44748
1706
1707         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1708         (DRTDevToolsAgent::createClientMessageLoop):
1709           Returns a valid WebKitClientMessageLoop instance
1710         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1711
1712 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
1713
1714         Add Windows WebKit2 Tester to buildbot
1715         <rdar://problem/7887703>
1716
1717         Reviewed by Dan Bernstein.
1718
1719         * BuildSlaveSupport/build.webkit.org-config/config.json:
1720
1721 2010-08-26  Philippe Normand  <pnormand@igalia.com>
1722
1723         Reviewed by Martin Robinson.
1724
1725         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1726         https://bugs.webkit.org/show_bug.cgi?id=42152
1727
1728         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1729         (LoadHTMLStringItem::invoke): Implementation using
1730         webkit_web_frame_load_string().
1731
1732 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
1733
1734         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
1735         WebKitTestRunner (44331)
1736
1737         Reviewed by Darin Adler.
1738
1739         * WebKitTestRunner/TestController.cpp:
1740         (WTR::TestController::initialize):
1741         The hang occurs when WebKitTestRunner begins launching the WebKit2
1742         web process then exits before it finishes launching. Work around this by
1743         looking for the --print-supported-features argument and exiting without
1744         creating the web process.
1745
1746 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
1747
1748         Reviewed by Tony Chang.
1749
1750         new-run-webkit-tests: add rebaselining tests for test_expectations
1751         
1752         This patch adds more unit tests for the rebaselining code in the
1753         test_expectations module. It doesn't add any tests for
1754         rebaseline_chromium_webkit_tests itself; that will come some other
1755         time.
1756
1757         https://bugs.webkit.org/show_bug.cgi?id=44648
1758
1759         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1760         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1761
1762 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1763
1764         Reviewed by Martin Robinson.
1765
1766         [GTK] Add HTTP caching support
1767         https://bugs.webkit.org/show_bug.cgi?id=44261
1768
1769         Ignore new soup API that we decided to merge into the soup backend
1770         while it is being cooked. It follows the libsoup style, and will
1771         be removed from WebKit as soon as it is merged into libsoup.
1772
1773         * Scripts/webkitpy/style/checker.py:
1774
1775 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1776
1777         Reviewed by Kenneth Rohde Christiansen.
1778
1779         [Qt] DumpRenderTree runs only one test from command mode
1780         https://bugs.webkit.org/show_bug.cgi?id=44012
1781
1782         Enables support to run multiple test files and single
1783         folder containing html files in stand alone mode
1784
1785         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1786         (WebCore::DumpRenderTree::DumpRenderTree):
1787         (WebCore::DumpRenderTree::processArgsLine):
1788         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1789         (WebCore::DumpRenderTree::processLine):
1790         (WebCore::DumpRenderTree::dump):
1791         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1792         (WebCore::DumpRenderTree::setStandAloneMode):
1793         (WebCore::DumpRenderTree::isStandAloneMode):
1794         * DumpRenderTree/qt/main.cpp:
1795         (main):
1796
1797 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1798
1799         Updating webkitpy test expectations.
1800
1801         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1802
1803 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1804
1805         Reviewed by Eric Seidel.
1806
1807         fix the always squash git config
1808         https://bugs.webkit.org/show_bug.cgi?id=44651
1809
1810         Fix help text and apparently underscores are not allowed
1811         in git config keys.
1812
1813         * Scripts/webkitpy/common/checkout/scm.py:
1814         * Scripts/webkitpy/tool/steps/commit.py:
1815
1816 2010-08-25  Darin Adler  <darin@apple.com>
1817
1818         Reviewed by John Sullivan.
1819
1820         * Scripts/commit-log-editor: Fix perl warning for people who have no
1821         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
1822
1823 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1824
1825         Reviewed by Eric Seidel.
1826
1827         stop blocking commits when the bots are red
1828         https://bugs.webkit.org/show_bug.cgi?id=44644
1829
1830         This check currently is just annoying. It doesn't actually
1831         help keep the tree green. We can always add it back later
1832         if we decide the tree is generally more green.
1833
1834         * Scripts/webkitpy/tool/commands/download_unittest.py:
1835         * Scripts/webkitpy/tool/mocktool.py:
1836         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1837
1838 2010-08-25  Eric Seidel  <eric@webkit.org>
1839
1840         Reviewed by Simon Fraser.
1841
1842         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
1843         https://bugs.webkit.org/show_bug.cgi?id=38912
1844
1845         I know of nothing else to do but skip all media tests for the cq.
1846
1847         * Scripts/webkitpy/tool/steps/runtests.py:
1848
1849 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1850
1851         Reviewed by Ojan Vafai.
1852
1853         new-run-webkit-tests: add more unit tests for test_expectations
1854         This adds unit tests to cover (almost?) all of the non-rebaselining
1855         functionality.
1856
1857         https://bugs.webkit.org/show_bug.cgi?id=44579
1858
1859         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1860         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1861
1862 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1863
1864         Reviewed by Ojan Vafai.
1865
1866         new-run-webkit-tests: add more unit tests
1867
1868         This change adds more unit tests for the image_diff, test_failures,
1869         and test_files modules, bringing them to 100% coverage (and adds a
1870         couple tests to run_webkit_tests while we're at it).
1871
1872         This test also turns on the "dryrun" port for testing when run on
1873         the mac, increasing coverage in a few other places.
1874
1875         https://bugs.webkit.org/show_bug.cgi?id=44578
1876
1877         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
1878         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
1879         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
1880         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
1881         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
1882         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
1883         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
1884         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
1885         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1886         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
1887         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1888         * Scripts/webkitpy/layout_tests/port/test.py:
1889         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1890
1891 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
1892
1893         Reviewed by Ojan Vafai.
1894
1895         new-run-webkit-tests: add more unit tests for layout_package/printing.py
1896
1897         This change adds more unit tests to get the test coverage to 100%
1898         for the printing module. This code is actually pretty crufty and
1899         has some layering violations that need to be cleaned up but I'll
1900         save that for another CL after we get all the unit tests written and
1901         we fix the multithreading issues. At least now we'll be able to tell
1902         if we break things.
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=44576
1905
1906         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1907         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1908
1909 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1910
1911         Reviewed by Adam Barth.
1912
1913         new-run-webkit-tests should respect set-webkit-configuration
1914         https://bugs.webkit.org/show_bug.cgi?id=44633
1915
1916         Moves the getting of the configuration into the base Port so that
1917         chromium ports use it as well. In the downstream chromium port,
1918         this should still just return Release.
1919
1920         * Scripts/webkitpy/layout_tests/port/base.py:
1921         * Scripts/webkitpy/layout_tests/port/webkit.py:
1922
1923 2010-08-25  Tony Chang  <tony@chromium.org>
1924
1925         Not reviewed, changing svn props for a script.
1926
1927         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
1928
1929 2010-08-25  Adam Barth  <abarth@webkit.org>
1930
1931         Reviewed by Eric Seidel.
1932
1933         Remove WebKit2 from core builders
1934         https://bugs.webkit.org/show_bug.cgi?id=44625
1935
1936         This builder was added to the core builders by accident.  It doesn't
1937         appear to be green enough to be a core builder yet.
1938
1939         * Scripts/webkitpy/common/net/buildbot.py:
1940         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1941
1942 2010-08-19  Adam Roben  <aroben@apple.com>
1943
1944         Test that NP_Initialize and NP_GetEntryPoints are called in the
1945         correct order
1946
1947         The order differs between Mac and Windows (see r38858).
1948
1949         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1950         NP_Initialize when loading QuickTime when running
1951         plugins/embed-attributes-setting.html in WebKit2 on Windows
1952
1953         Reviewed by John Sullivan.
1954
1955         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1956         a boolean to record whether NP_GetEntryPoints has been called.
1957         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1958         called yet. This matches Flash and QuickTime's behavior.
1959         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
1960         yet. This matches Silverlight's behavior.
1961
1962 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1963
1964         Reviewed by Gustavo Noronha Silva.
1965
1966         Cairo and EFL port shouldn't depend on glib.
1967         https://bugs.webkit.org/show_bug.cgi?id=44354
1968
1969         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
1970         adoptPlatformRef.
1971
1972         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1973         (AccessibilityUIElement::isSelected):
1974
1975 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1976
1977         Fix order of Timothy's email address. The script, and
1978         other tools all assume that the first email is the bugzilla address.
1979
1980         * Scripts/webkitpy/common/config/committers.py:
1981
1982 2010-08-24  Kent Tamura  <tkent@chromium.org>
1983
1984         Reviewed by Pavel Feldman.
1985
1986         [DRT/Chromium] Fix 26 inspector test crashes
1987         https://bugs.webkit.org/show_bug.cgi?id=44580
1988
1989         - DRTDevToolsAgent has a reference to the main WebView. So we
1990           should not clear it in closeDevTools() and should clear it in
1991           ~TestShell().
1992         - DRTDevToolsClient has a reference to a DevTools WebView and no
1993           way to update it. So we should delete DRTDevToolsClient instances
1994           in closeDevTools().
1995
1996         * DumpRenderTree/chromium/TestShell.cpp:
1997         (TestShell::~TestShell):
1998         (TestShell::closeDevTools):
1999
2000 2010-08-24  Eric Seidel  <eric@webkit.org>
2001
2002         Reviewed by Adam Barth.
2003
2004         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
2005         https://bugs.webkit.org/show_bug.cgi?id=44584
2006
2007         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2008
2009 2010-08-24  Eric Seidel  <eric@webkit.org>
2010
2011         Reviewed by Adam Barth.
2012
2013         commit-queue and EWS bots should report all failures
2014         https://bugs.webkit.org/show_bug.cgi?id=41820
2015
2016         Right now commit-queue/EWS only report failures when the
2017         patch under testing fails.  We should report all failures
2018         to the status server so that we can diagnose when the bots
2019         are wedged w/o needing to log into the machines.
2020
2021         I also reduced the amount of data we upload since we've seen
2022         timeouts during status upload.
2023
2024         * Scripts/webkitpy/common/system/executive.py:
2025         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2026         * Scripts/webkitpy/tool/commands/queues.py:
2027         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2028
2029 2010-08-24  Eric Seidel  <eric@webkit.org>
2030
2031         Reviewed by Adam Barth.
2032
2033         Remove HTML5 parser testing infrastructure now that we don't need it
2034         https://bugs.webkit.org/show_bug.cgi?id=44581
2035
2036         * DumpRenderTree/mac/DumpRenderTree.mm:
2037         (resetDefaultsToConsistentValues):
2038         (initializeGlobalsFromCommandLineOptions):
2039         * Scripts/old-run-webkit-tests:
2040         * Scripts/test-html5-parser: Removed.
2041
2042 2010-08-24  Kent Tamura  <tkent@chromium.org>
2043
2044         Reviewed by Dimitri Glazkov.
2045
2046         [DRT/Chromium] Fix 28 inspector test crashes
2047         https://bugs.webkit.org/show_bug.cgi?id=44574
2048
2049         Reset DevToolsClient and DevToolsAgent before closing a DevTools
2050         WebView in order to avoid accessing to a deleted WebView instance.
2051
2052         * DumpRenderTree/chromium/TestShell.cpp:
2053         (TestShell::closeDevTools):
2054
2055 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2056
2057         Reviewed by Ojan Vafai.
2058
2059         new-run-webkit-tests: clean up code for test_types, test_failures
2060
2061         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
2062         webkitpy.layout_tests.layout_package.test_failures, and remove
2063         some dead code and otherwise clean up things.
2064
2065         https://bugs.webkit.org/show_bug.cgi?id=44559
2066
2067         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2068         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
2069         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2070         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2071         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2072         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
2073         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2074
2075 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2076
2077         Reviewed by Eric Seidel.
2078
2079         new-run-webkit-tests: revise unit testing strategy for test failures
2080     
2081         This change revamps the way we store test data for new-run-webkit-tests.
2082         Previously we had a few copies of test files from the main test tree.
2083         Now we have a bunch of completely fake test data and use the test
2084         data to generate different kinds of test failures, getting
2085         much better coverage.
2086
2087         https://bugs.webkit.org/show_bug.cgi?id=44556
2088
2089         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
2090         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
2091         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
2092         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
2093         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
2094         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
2095         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
2096         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
2097         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
2098         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
2099         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
2100         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
2101         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
2102         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
2103         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
2104         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
2105         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
2106         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
2107         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
2108         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
2109         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
2110         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
2111         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
2112         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
2113         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
2114         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
2115         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
2116         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
2117         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
2118         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
2119         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
2120         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
2121         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
2122         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
2123         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
2124         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
2125         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
2126         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
2127         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
2128         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
2129         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
2130         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
2131         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
2132         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2133         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
2134         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
2135         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2136         * Scripts/webkitpy/layout_tests/port/test.py:
2137         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2138         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2139
2140 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2141
2142         Reviewed by Eric Seidel.
2143
2144         speed up new-run-webkit-tests unit tests
2145
2146         Add a --no-record-results flag that turns off generating the JSON
2147         results file on every test run. Generating the file requires us to
2148         fetch the old results down from the bots, which can be slow. This
2149         flag is off by default.
2150     
2151         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
2152     
2153         These changes together shorten the test cycle from ~4.5s to ~1.5s
2154         - a 3x speedup.
2155
2156         https://bugs.webkit.org/show_bug.cgi?id=44553
2157
2158         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2159         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2160
2161 2010-08-24  Tony Chang  <tony@chromium.org>
2162
2163         Reviewed by Eric Seidel.
2164
2165         [chromium] fix the platform result fallback order on mac/win
2166         https://bugs.webkit.org/show_bug.cgi?id=44483
2167
2168         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2169
2170 2010-08-24  Xan Lopez  <xlopez@igalia.com>
2171
2172         Reviewed by Martin Robinson.
2173
2174         Set a device to the event struct when building with GTK+ 3.x, it's
2175         mandatory.
2176
2177         * DumpRenderTree/gtk/EventSender.cpp:
2178         (keyDownCallback):
2179
2180 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2181
2182         Reviewed by Xan Lopez.
2183
2184         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2185         https://bugs.webkit.org/show_bug.cgi?id=44534
2186
2187         Fix two double-frees introduced in my previous commit.
2188
2189         * DumpRenderTree/gtk/EventSender.cpp:
2190         (contextClickCallback): Copy the event before using it again.
2191         (keyDownCallback): Ditto.
2192
2193 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2194
2195         Reviewed by Xan Lopez.
2196
2197         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2198         https://bugs.webkit.org/show_bug.cgi?id=44534
2199
2200         * DumpRenderTree/gtk/EventSender.cpp:
2201         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
2202         when setting it on the event. It is dereferenced by gdk_event_free(...).
2203         (contextClickCallback): Ditto.
2204         (mouseDownCallback): Ditto.
2205         (mouseUpCallback): Ditto.
2206         (mouseMoveToCallback): Ditto.
2207         (mouseWheelToCallback): Ditto.
2208         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
2209         (dispatchEvent): Ditto. Also free the event when we are done with it.
2210         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
2211
2212 2010-08-24  Andras Becsi  <abecsi@webkit.org>
2213
2214         [Qt] WebKit2 build fix.
2215
2216         * Scripts/enumerate-included-framework-headers:
2217         Remove stray global option form sed.
2218
2219 2010-08-24  Kent Tamura  <tkent@chromium.org>
2220
2221         Reviewed by Jeremy Orlow.
2222
2223         [DRT/Chromium] Support for IndexedDB tests
2224         https://bugs.webkit.org/show_bug.cgi?id=44490
2225
2226         * DumpRenderTree/chromium/TestShell.cpp:
2227         (TestShell::TestShell): Enable IndexedDB.
2228
2229 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
2230
2231         Reviewed by Gustavo Noronha Silva.
2232
2233         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
2234         https://bugs.webkit.org/show_bug.cgi?id=44465
2235
2236         Initialize the axes field of mouse button and motion events to null.
2237         This is the value that should be used for events originating from the
2238         mouse device.
2239
2240         * DumpRenderTree/gtk/EventSender.cpp:
2241         (prepareMouseButtonEvent): Initalize button event axes field to null.
2242         (mouseMoveToCallback): Initialize motion event axes field to null.
2243
2244 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2245
2246         Unreviewed, rolling out r65703.
2247         http://trac.webkit.org/changeset/65703
2248         https://bugs.webkit.org/show_bug.cgi?id=44460
2249
2250         "Causing lots of crashes on Snow Leopard when running the
2251         layout tests" (Requested by eseidel2 on #webkit).
2252
2253         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2254         (NP_Initialize):
2255         (NP_GetEntryPoints):
2256
2257 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
2258
2259         Layout tests do not run when using WebKitTestRunner in a Debug build.
2260         https://bugs.webkit.org/show_bug.cgi?id=44409
2261
2262         Reviewed by Dan Bernstein.
2263
2264         * WebKitTestRunner/win/TestControllerWin.cpp:
2265         (WTR::TestController::initializeInjectedBundlePath):
2266         Use InjectedBundle_debug.dll when building Debug.
2267
2268 2010-08-23  Xan Lopez  <xlopez@igalia.com>
2269
2270         Reviewed by Martin Robinson.
2271
2272         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
2273         https://bugs.webkit.org/show_bug.cgi?id=42026
2274
2275         If a GTK+ 3.x build is present return that as the library to use,
2276         otherwise fallback to the GTK+ 2.x build.
2277
2278         * Scripts/webkitdirs.pm:
2279
2280 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
2281
2282         Reviewed by Ariya Hidayat.
2283
2284         [Qt] Find needed forwarding headers for WebKit2 automatically
2285         https://bugs.webkit.org/show_bug.cgi?id=44336
2286
2287         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
2288         The new script does not satisfy the needs of this file however using normal includes
2289         is generally better here.
2290         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
2291         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
2292         given frameworks by files in the current directory (and subdirectories).
2293         In the future this needs to be rewritten in perl for being able to use on Windows.
2294
2295 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
2296
2297         Reviewed by Ariya Hidayat.
2298
2299         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
2300         https://bugs.webkit.org/show_bug.cgi?id=43010
2301
2302         * QtTestBrowser/launcherwindow.cpp:
2303         (LauncherWindow::applyPrefs):
2304         * QtTestBrowser/main.cpp:
2305         (LauncherApplication::handleUserOptions):
2306
2307 2010-08-21  Sam Weinig  <sam@webkit.org>
2308
2309         Reviewed by Dan Bernstein.
2310
2311         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
2312         https://bugs.webkit.org/show_bug.cgi?id=44386
2313
2314         * MiniBrowser/mac/AppDelegate.m:
2315         (didRecieveMessageFromInjectedBundle):
2316         (didNavigateWithNavigationData):
2317         (-[BrowserAppDelegate init]):
2318         (-[BrowserAppDelegate applicationWillTerminate:]):
2319         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2320         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
2321         (-[BrowserStatisticsWindowController dealloc]):
2322         * MiniBrowser/mac/BrowserWindowController.m:
2323         (-[BrowserWindowController initWithPageNamespace:]):
2324         (-[BrowserWindowController fetch:]):
2325         (-[BrowserWindowController windowWillClose:]):
2326         (-[BrowserWindowController applicationTerminating]):
2327         (closePage):
2328         (runJavaScriptAlert):
2329         (runJavaScriptConfirm):
2330         (runJavaScriptPrompt):
2331         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2332         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2333         (didClearWindowObjectForFrame):
2334         * MiniBrowser/win/BrowserView.cpp:
2335         (BrowserView::goToURL):
2336         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2337         (WTR::PlatformWebView::~PlatformWebView):
2338
2339 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
2340
2341         Reviewed by Kenneth Rohde Christiansen.
2342
2343         WebKit does not build with Python 2.3
2344         https://bugs.webkit.org/show_bug.cgi?id=44373
2345
2346         Replaced the function sorted() by a call to sort()
2347         on the entry list.
2348         The function sorted() has been added to Python 2.4.
2349         The function method sort() of List works with older
2350         versions of Python.
2351
2352         * Scripts/create-html-entity-table:
2353
2354 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
2355
2356         Reviewed by Pavel Feldman.
2357
2358         Web Inspector: Inspector tests were disabled for GTK.
2359         https://bugs.webkit.org/show_bug.cgi?id=43977
2360
2361         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
2362         path before running tests.
2363
2364 2010-08-20  Daniel Bates  <dbates@rim.com>
2365
2366         Reviewed by Eric Seidel.
2367
2368         svn-apply doesn't detect empty line with Windows line endings
2369         after property value
2370         https://bugs.webkit.org/show_bug.cgi?id=43981
2371
2372         Part 2 of 2
2373
2374         Add unit tests that were not landed in the first commit.
2375
2376         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2377           - Added the following test cases:
2378             "SVN: binary file (isBinary true) using Windows line endings"
2379             "SVN: property diff, followed by file change diff using Windows line endings"
2380             "SVN: two consecutive property diffs using Windows line endings"
2381             "SVN: binary file with executable bit change usng Windows line endings"
2382             "SVN: binary file followed by property change on different file using Windows line endings"
2383             "SVN: binary file followed by file change on different file using Windows line endings"
2384             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2385             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2386         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2387           - Added the following test cases:
2388             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2389             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2390             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2391             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2392             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2393             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2394             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2395             "single-line '+' with trailing new line using Windows line endings"
2396             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2397             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2398             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2399         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2400           - Added the following test cases:
2401             "single-line '-' change followed by empty line with Windows line endings"
2402             "multi-line '+' change and start of binary patch with Windows line endings"
2403
2404 2010-08-20  Daniel Bates  <dbates@rim.com>
2405
2406         Reviewed by Eric Seidel.
2407
2408         svn-apply doesn't detect empty line with Windows line endings
2409         after property value
2410         https://bugs.webkit.org/show_bug.cgi?id=43981
2411
2412         Fixes an issue where an empty line following the property value
2413         in an SVN property change diff would not be detected if it had
2414         Windows line endings (i.e. ended in CRLF). Hence it was consumed
2415         as if it was part of a multi-line property value. 
2416
2417         * Scripts/VCSUtils.pm:
2418           - Modified parseSvnPropertyValue() to detect empty line
2419             with Windows line endings.
2420           - Added toWindowsLineEndings().
2421         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2422           - Added the following test cases:
2423             "SVN: binary file (isBinary true) using Windows line endings"
2424             "SVN: property diff, followed by file change diff using Windows line endings"
2425             "SVN: two consecutive property diffs using Windows line endings"
2426             "SVN: binary file with executable bit change usng Windows line endings"
2427             "SVN: binary file followed by property change on different file using Windows line endings"
2428             "SVN: binary file followed by file change on different file using Windows line endings"
2429             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2430             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2431         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2432           - Added the following test cases:
2433             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2434             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2435             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2436             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2437             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2438             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2439             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2440             "single-line '+' with trailing new line using Windows line endings"
2441             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2442             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2443             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2444         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2445           - Added the following test cases:
2446             "single-line '-' change followed by empty line with Windows line endings"
2447             "multi-line '+' change and start of binary patch with Windows line endings"
2448
2449 2010-08-19  David Kilzer  <ddkilzer@apple.com>
2450
2451         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
2452
2453         * MiniBrowser/mac/BrowserWindowController.m:
2454         (decidePolicyForNavigationAction): Updated method signature.
2455         (decidePolicyForNewWindowAction): Updated method signature.
2456
2457 2010-08-19  Adam Roben  <aroben@apple.com>
2458
2459         Test that NP_Initialize and NP_GetEntryPoints are called in the
2460         correct order
2461
2462         The order differs between Mac and Windows (see r38858).
2463
2464         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
2465         NP_Initialize when loading QuickTime when running
2466         plugins/embed-attributes-setting.html in WebKit2 on Windows
2467
2468         Reviewed by Sam Weinig.
2469
2470         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
2471         a boolean to record whether NP_GetEntryPoints has been called.
2472         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
2473         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
2474         if NP_GetEntryPoints has been called already. This matches
2475         Silverlight's behavior.
2476
2477 2010-08-19  Adam Roben  <aroben@apple.com>
2478
2479         Make build-webkittestrunner build TestNetscapePlugIn on Windows
2480
2481         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
2482
2483         Reviewed by Sam Weinig.
2484
2485         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
2486         Threaded it in between ImageDiff and InjectedBundleGenerated.
2487
2488 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2489
2490         Reviewed by Adam Barth.
2491
2492         install rietveld's upload script from a versioned url
2493         https://bugs.webkit.org/show_bug.cgi?id=44291
2494
2495         autoinstall expects the file at a given URL to never change.
2496         In order to be able to update the file, we need to be able to
2497         change the path.
2498
2499         * Scripts/webkitpy/thirdparty/__init__.py:
2500
2501 2010-08-19  Ojan Vafai  <ojan@chromium.org>
2502
2503         Reviewed by Adam Barth.
2504
2505         add --webkit_patch_id to reitveld uploads
2506         https://bugs.webkit.org/show_bug.cgi?id=44289
2507
2508         This is the first step in having rietveld store which
2509         patches have been uploaded and getting rid of the
2510         in-rietveld flag.
2511
2512         * Scripts/webkitpy/common/net/rietveld.py:
2513         * Scripts/webkitpy/tool/mocktool.py:
2514         * Scripts/webkitpy/tool/steps/postcodereview.py:
2515
2516 2010-08-19  Kenneth Russell  <kbr@google.com>
2517
2518         Reviewed by David Levin.
2519
2520         Adjust my status from committer to reviewer
2521         https://bugs.webkit.org/show_bug.cgi?id=44277
2522
2523         * Scripts/webkitpy/common/config/committers.py:
2524
2525 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2526
2527         Reviewed by Yury Semikhatsky.
2528
2529         Chromium DevTools: remove injected script fetcher from test harness.
2530         https://bugs.webkit.org/show_bug.cgi?id=44266
2531
2532         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2533         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2534
2535 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
2536
2537         Reviewed by Yury Semikhatsky.
2538
2539         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
2540         Now that we populate front-end after its onload handler, we don't need
2541         to install injected script early. Exposing injected script source on the WebCore
2542         level here.
2543         https://bugs.webkit.org/show_bug.cgi?id=44029
2544
2545         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2546         (DRTDevToolsAgent::runtimePropertyChanged):
2547         (DRTDevToolsAgent::delayedFrontendLoaded):
2548         (DRTDevToolsAgent::frontendLoaded):
2549         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2550
2551 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2552
2553         Reviewed by Kenneth Rohde Christiansen.
2554
2555         [Gtk] Enable view mode media feature layout test
2556         https://bugs.webkit.org/show_bug.cgi?id=43278
2557
2558         Add view mode media feature testing infrastructure, and add
2559         placeholder methods for the other platforms'
2560         LayoutTestControllers.
2561
2562         * DumpRenderTree/LayoutTestController.cpp:
2563         (setViewModeMediaFeatureCallback):
2564         (LayoutTestController::staticFunctions):
2565         * DumpRenderTree/LayoutTestController.h:
2566         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2567         (LayoutTestController::setViewModeMediaFeature):
2568         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2569         (LayoutTestController::setViewModeMediaFeature):
2570         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2571         (LayoutTestController::setViewModeMediaFeature):
2572         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2573         (LayoutTestController::setViewModeMediaFeature):
2574
2575 2010-08-18  Mark Rowe  <mrowe@apple.com>
2576
2577         Reviewed by Sam Weinig.
2578
2579         Make it so the WebKit2 test slave runs the WebKit2 tests
2580
2581         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2582
2583 2010-08-18  Sam Weinig  <sam@webkit.org>
2584
2585         Reviewed by Mark Rowe.
2586
2587         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
2588         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
2589         module and the TestNetscapePlugin.
2590
2591         * Scripts/old-run-webkit-tests:
2592
2593 2010-08-18  Adam Roben  <aroben@apple.com>
2594
2595         Fix hang when saving crash logs on Windows
2596
2597         * Scripts/old-run-webkit-tests:
2598         (setUpWindowsCrashLogSaving):
2599         (END):
2600         Pass -s to regtool so it will write the Auto value as a string instead
2601         of as a number. This was causing a "do you want to debug?" dialog to
2602         appear.
2603
2604 2010-08-17  Victor Wang  <victorw@chromium.org>
2605
2606         Unreviewed. Fixed chromium incremental test json upload.
2607         Quote builder name and test results server in url.
2608
2609         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2610
2611 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2612
2613         Reviewed by Ariya Hidayat.
2614
2615         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
2616         https://bugs.webkit.org/show_bug.cgi?id=44124
2617
2618         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
2619         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
2620         Symbian dependencies.
2621
2622         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2623         (WebCore::DumpRenderTree::open):
2624         * QtTestBrowser/launcherwindow.cpp:
2625         (LauncherWindow::init):
2626         (LauncherWindow::toggleFullScreenMode):
2627         (LauncherWindow::showFPS):
2628         (LauncherWindow::updateFPS):
2629         * QtTestBrowser/launcherwindow.h:
2630         (WindowOptions::WindowOptions):
2631         * QtTestBrowser/mainwindow.cpp:
2632         (MainWindow::buildUI):
2633
2634 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2635
2636         Reviewed by David Levin.
2637
2638         new-run-webkit-tests: remove --show-sources option
2639
2640         --show-sources is pretty much obsolete with --trace everything, so
2641         I'm removing it.
2642
2643         Also rename a couple of methods in the TestTextDiff class to make their
2644         intended visibility (private) more obvious.
2645
2646         https://bugs.webkit.org/show_bug.cgi?id=44143
2647
2648         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2649         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2650         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2651         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2652         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2653
2654 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2655
2656         Reviewed by David Levin.
2657
2658         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
2659
2660         This code bit-rotted at some point more than a year ago, and nobody seems
2661         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
2662         should support instead, making this flag unnecessary anyway.
2663
2664         https://bugs.webkit.org/show_bug.cgi?id=44141
2665
2666         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2667         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2668         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
2669
2670 2010-08-17  Victor Wang  <victorw@chromium.org>
2671
2672         Reviewed by Ojan Vafai.
2673
2674         Update json results generator to have incremental json including
2675         results for tests that pass in current run but failed before.
2676
2677         https://bugs.webkit.org/show_bug.cgi?id=44119
2678
2679         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2680         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2681         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2682
2683 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
2684
2685         Reviewed by Eric Seidel.
2686
2687         fix test-webkitpy, add easy way to find a checkout root
2688
2689         test-webkitpy currently doesn't work right if run from someplace other
2690         than the checkout root, and it spews a bunch of debug logging because
2691         the deduplicate_tests tests contaminates the test environment.
2692
2693         This patch cleans up the deduplicate_tests unit tests, and creates
2694         two new methods in scm.py: find_checkout_root() and default_scm(),
2695         both of which use a single algorithm for guessing what checkout root
2696         to use if you aren't explicitly told one from a path.
2697
2698         https://bugs.webkit.org/show_bug.cgi?id=44001
2699
2700         * Scripts/deduplicate-tests:
2701         * Scripts/webkitpy/common/checkout/scm.py:
2702         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2703         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2704         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2705         * Scripts/webkitpy/layout_tests/port/test.py:
2706         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2707         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2708         * Scripts/webkitpy/tool/main.py:
2709
2710 2010-08-17  Victor Wang  <victorw@chromium.org>
2711
2712         Reviewed by Ojan Vafai.
2713
2714         Add support to the test results server for downloading json that
2715         contains test list only.
2716
2717         This is for json results generator to generate incremental json
2718         results so that it includes results not only for tests failed in
2719         current run, but also tests failed before.
2720
2721         Also set the results type to "N" (no data) instead of "P" (pass)
2722         if test results cannot be found in incremental json file.
2723
2724         https://bugs.webkit.org/show_bug.cgi?id=44117
2725
2726         * TestResultServer/handlers/testfilehandler.py:
2727         * TestResultServer/model/jsonresults.py:
2728         * TestResultServer/model/jsonresults_unittest.py:
2729
2730 2010-08-17  Adam Roben  <aroben@apple.com>
2731
2732         Use the right path style
2733
2734         * Scripts/old-run-webkit-tests:
2735
2736 2010-08-17  Adam Roben  <aroben@apple.com>
2737
2738         Fix typo
2739
2740         * Scripts/old-run-webkit-tests:
2741
2742 2010-08-17  Adam Roben  <aroben@apple.com>
2743
2744         Don't hang when running run-webkit-tests as a non-Administrator on
2745         Vista/7
2746
2747         * Scripts/old-run-webkit-tests:
2748         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
2749         post-mortem debugger, rather than using NTSD itself. The latter waits
2750         for user input when it fails to set the registry values; the former
2751         does not.
2752
2753 2010-08-17  Adam Roben  <aroben@apple.com>
2754
2755         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
2756         save crash logs on Windows
2757
2758         The crash logs are saved to /tmp/layout-test-results and have names
2759         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
2760
2761         Unfortunately, crashes in the WebKit2 web process are recorded as
2762         time-outs by run-webkit-tests. Fixing this is covered by
2763         <http://webkit.org/b/44121>.
2764
2765         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
2766         DumpRenderTree should save a stack trace and/or dump file when it
2767         crashes
2768
2769         Reviewed by Sam Weinig.
2770
2771         * DumpRenderTree/win/DumpRenderTree.cpp:
2772         (exceptionFilter):
2773         (main):
2774         * WebKitTestRunner/win/TestControllerWin.cpp:
2775         (WTR::exceptionFilter):
2776         (WTR::TestController::platformInitialize):
2777         These changes set up an exception filter that prints #CRASHED to
2778         stderr, then lets the exception propagate normally. This allows
2779         run-webkit-tests to detect when we've crashed even when a post-mortem
2780         debugger attaches to the process.
2781
2782         * Scripts/old-run-webkit-tests:
2783         (top level): Declared some variables used by the crash-log-saving
2784         code.
2785         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
2786         that the post-mortem debugger has access to it.
2787         (toCygwinPath): Added. This is the opposite of toWindowsPath.
2788         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
2789         stderr, consider it a crash.
2790         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
2791         debugger, then sets ntsd as the post-mortem debugger. ntsd is
2792         configured to save a crash log and then quit automatically.
2793         (END): Added. Restores the previous post-mortem debugger when the
2794         script exits.
2795
2796 2010-08-17  Victor Wang  <victorw@chromium.org>
2797
2798         Reviewed by ojan@chromium.org.
2799
2800         Update test results server:
2801         1. Normalize test results and times after merging (prune tests where
2802            all runs pass or do not have data, truncate all test items to max
2803            number of builds)
2804         2. times should be int not string.
2805         3. when inserting a new test item, should keep old data regardless
2806            whether or not they have same item type with new one.
2807
2808         https://bugs.webkit.org/show_bug.cgi?id=43861
2809
2810         * TestResultServer/model/jsonresults.py:
2811         * TestResultServer/model/jsonresults_unittest.py:
2812
2813 2010-08-16  Sam Weinig  <sam@webkit.org>
2814
2815         Reviewed by Mark Rowe.
2816
2817         Add WebKit2 Mac tester to buildbot.
2818
2819         * BuildSlaveSupport/build.webkit.org-config/config.json:
2820         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2821
2822 2010-08-16  Paul Sawaya  <psawaya@apple.com>
2823
2824         Reviewed by Chris Marrin.
2825
2826         Added shader validation via ANGLE
2827         https://bugs.webkit.org/show_bug.cgi?id=42405
2828
2829         Added ANGLE to webkit build
2830
2831         * Scripts/build-webkit:
2832
2833 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
2834
2835         [wx] Build fix, do not build WebCore as a convenience library as this leads to
2836         errors in the Win build w/export symbols and causes problems with DOM bindings
2837         debugging in gdb.
2838
2839         * DumpRenderTree/wscript:
2840         * Scripts/build-webkit:
2841         * wx/browser/wscript:
2842         * wx/build/settings.py:
2843         * wx/build/waf_extensions.py:
2844
2845 2010-08-16  Dan Bernstein  <mitz@apple.com>
2846
2847         Build fix.
2848
2849         * WebKitTestRunner/TestController.cpp:
2850         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
2851         (WTR::TestController::initialize): Ditto.
2852
2853 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2854
2855         Reviewed by Kenneth Rohde Christiansen.
2856
2857         Handle content size change in WebKit2
2858         Re-landing after fix.
2859
2860         https://bugs.webkit.org/show_bug.cgi?id=43198
2861
2862         * MiniBrowser/mac/BrowserWindowController.m:
2863         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2864         * MiniBrowser/win/BrowserView.cpp:
2865         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2866
2867 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2868
2869         Unreviewed, rolling out r65419.
2870         http://trac.webkit.org/changeset/65419
2871         https://bugs.webkit.org/show_bug.cgi?id=44053
2872
2873         Broke the Windows build (Requested by bbandix on #webkit).
2874
2875         * MiniBrowser/mac/BrowserWindowController.m:
2876         (-[BrowserWindowController awakeFromNib]):
2877         * MiniBrowser/win/BrowserView.cpp:
2878         (BrowserView::create):
2879
2880 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
2881
2882         Reviewed by Kenneth Rohde Christiansen.
2883
2884         Handle content size change in WebKit2
2885
2886         https://bugs.webkit.org/show_bug.cgi?id=43198
2887
2888         * MiniBrowser/mac/BrowserWindowController.m:
2889         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
2890         * MiniBrowser/win/BrowserView.cpp:
2891         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2892
2893 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
2894
2895         Add my new email address to committers.py.
2896
2897         * Scripts/webkitpy/common/config/committers.py:
2898
2899 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
2900
2901         Add my old e-mail addresses to committers.py.
2902
2903         * Scripts/webkitpy/common/config/committers.py:
2904
2905 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2906
2907         WebEditorClient::didBeginEditing is never called in WebKit2
2908         https://bugs.webkit.org/show_bug.cgi?id=42939
2909
2910         Reviewed by Sam Weinig.
2911
2912         * WebKitTestRunner/PlatformWebView.h:
2913         Declare focus().
2914
2915         * WebKitTestRunner/TestController.cpp:
2916         (WTR::TestController::resetStateToConsistentValues):
2917         Focus the PlatformWebView.
2918
2919         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2920         (WTR::PlatformWebView::focus):
2921         Stubbed.
2922
2923         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2924         (WTR::PlatformWebView::focus):
2925         Focus the view.
2926
2927 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
2928
2929         run-webkit-tests should not strip editing callbacks when using
2930         WebKitTestRunner on Windows
2931         https://bugs.webkit.org/show_bug.cgi?id=44000
2932
2933         Reviewed by Mark Rowe.
2934
2935         * Scripts/old-run-webkit-tests:
2936         Leave $stripEditingCallbacks undefined until we look for command-line
2937         arguments. If using WebKit2, set it to 0 if not explicity set on the
2938         command line. Later, set it to isCygwin() to match old behavior if it is
2939         not yet defined.
2940
2941 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
2942
2943         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
2944
2945         * wx/build/settings.py:
2946
2947 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
2948
2949         Reviewed by Kenneth Rohde Christiansen.
2950
2951         [GTK] autogen.sh not executed if build-webkit options change
2952         https://bugs.webkit.org/show_bug.cgi?id=42266
2953
2954         Rerun autogen.sh in situations where the arguments to build-webkit have
2955         changed since the previous build. This will fix some issues on the bots
2956         where the build does not notice changes to default build-webkit arguments.
2957
2958         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
2959
2960 2010-08-14  Eric Seidel  <eric@webkit.org>
2961
2962         Unreviewed.  Another fix to support python 2.3.
2963
2964         Add support for MathML entities
2965         https://bugs.webkit.org/show_bug.cgi?id=43949
2966
2967         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
2968          - It looks like our simplejson is version 1.7.3 which
2969            should be python 2.3 compatible.  But someone modified
2970            our copy slightly from the original source.
2971            I've removed the relative import in hopes this fixes
2972            the problem.
2973
2974 2010-08-13  Eric Seidel  <eric@webkit.org>
2975
2976         Unreviewed.  Build fix only.
2977
2978         Add support for MathML entities
2979         https://bugs.webkit.org/show_bug.cgi?id=43949
2980
2981         * Scripts/create-html-entity-table:
2982          - Hack sys.path to avoid executing 2.5 dependent python
2983            on systems (like chromium-win and Tiger) which do not have 2.5 python.
2984
2985 2010-08-13  Adam Barth  <abarth@webkit.org>
2986
2987         Reviewed by Eric Seidel.
2988
2989         Rename some concepts in HTML entity search to be more self-documenting
2990         https://bugs.webkit.org/show_bug.cgi?id=44004
2991
2992         Reflect name change in generator script.
2993
2994         * Scripts/create-html-entity-table:
2995
2996 2010-08-12  Adam Barth  <abarth@webkit.org>
2997
2998         Reviewed by Eric Seidel.
2999
3000         Add support for MathML entities
3001         https://bugs.webkit.org/show_bug.cgi?id=43949
3002
3003         A script for generating the C++ state data structure describing all the
3004         entities from a JSON description.
3005
3006         * Scripts/create-html-entity-table: Added.
3007
3008 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
3009
3010         Reviewed by Eric Seidel.
3011
3012         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
3013         check for exceptions on all threads, not just the first thread.
3014         
3015         This change also changes the logging behavior for wedged threads
3016         to only dump the stacks of threads that are actually wedged.
3017
3018         Refactor the thread classes in the dump_render_tree_thread module
3019         to make the contract between TestRunner and TestShellThread clearer.
3020
3021         Added a bunch of unit tests.
3022         https://bugs.webkit.org/show_bug.cgi?id=38561
3023
3024         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3025         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3026         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3027
3028 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
3029
3030         Reviewed by Shinichiro Hamaji.
3031
3032         Add test_expectations.txt syntax checker to check-webkit-style.
3033         https://bugs.webkit.org/show_bug.cgi?id=43899
3034
3035         Just utilizing layout_tests/layout_package/test_expectations.py for checking
3036         the syntax of test_expectations.txt.
3037         This change also moves tab checking class from style/checkers/text.py to
3038         style/checkers/common.py for sharing code.
3039
3040         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3041         * Scripts/webkitpy/style/checker.py:
3042         * Scripts/webkitpy/style/checkers/common.py:
3043         * Scripts/webkitpy/style/checkers/common_unittest.py:
3044         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
3045         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
3046         * Scripts/webkitpy/style/checkers/text.py:
3047         * Scripts/webkitpy/style_references.py:
3048
3049 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3050
3051         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
3052         https://bugs.webkit.org/show_bug.cgi?id=43945
3053
3054         Reviewed by Sam Weinig.
3055
3056         * WebKitTestRunner/TestInvocation.cpp:
3057         (WTR::sizeWebViewForCurrentTest):
3058         Allow for a Windows-style path.
3059
3060         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3061         (WTR::PlatformWebView::resizeTo):
3062         Call SetWindowPos to resize the view window.
3063
3064 2010-08-12  David Levin  <levin@chromium.org>
3065
3066         Build break fix.
3067
3068         * WebKitTestRunner/TestController.cpp:
3069         (WTR::TestController::resetStateToConsistentValues): Removed usage
3070         of a variable that doesn't exist in the class.
3071
3072 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3073
3074         WebKitTestRunner needs to run tests without using native controls
3075         https://bugs.webkit.org/show_bug.cgi?id=43772
3076
3077         Reviewed by Sam Weinig.
3078
3079         * WebKitTestRunner/TestController.cpp:
3080         (WTR::TestController::initialize):
3081         Call platformInitializeContext().
3082
3083         * WebKitTestRunner/TestController.h:
3084         Declare platformInitializeContext().
3085
3086         * WebKitTestRunner/mac/TestControllerMac.mm:
3087         (WTR::TestController::platformInitializeContext):
3088         Stubbed.
3089
3090         * WebKitTestRunner/win/TestControllerWin.cpp:
3091         (WTR::TestController::platformInitializeContext):
3092         Call WKContextSetShouldPaintNativeControls() to disable native control
3093         drawing.
3094
3095 2010-08-12  Sam Weinig  <sam@webkit.org>
3096
3097         Reviewed by Alexey Proskuryakov.
3098
3099         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
3100         https://bugs.webkit.org/show_bug.cgi?id=43653
3101
3102         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3103         (WTR::InjectedBundle::InjectedBundle):
3104         (WTR::InjectedBundle::didReceiveMessage):
3105         (WTR::InjectedBundle::beginTesting):
3106         (WTR::InjectedBundle::done):
3107         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3108         (WTR::InjectedBundle::isTestRunning):
3109         (WTR::InjectedBundle::):
3110         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3111         (WTR::InjectedBundlePage::stopLoading):
3112         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3113         (WTR::InjectedBundlePage::dump):
3114         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3115         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3116         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3117         (WTR::InjectedBundlePage::didClearWindowForFrame):
3118         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3119         (WTR::InjectedBundlePage::willAddMessageToConsole):
3120         (WTR::InjectedBundlePage::willSetStatusbarText):
3121         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3122         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3123         (WTR::InjectedBundlePage::shouldBeginEditing):
3124         (WTR::InjectedBundlePage::shouldEndEditing):
3125         (WTR::InjectedBundlePage::shouldInsertNode):
3126         (WTR::InjectedBundlePage::shouldInsertText):
3127         (WTR::InjectedBundlePage::shouldDeleteRange):
3128         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3129         (WTR::InjectedBundlePage::shouldApplyStyle):
3130         (WTR::InjectedBundlePage::didBeginEditing):
3131         (WTR::InjectedBundlePage::didEndEditing):
3132         (WTR::InjectedBundlePage::didChange):
3133         (WTR::InjectedBundlePage::didChangeSelection):
3134         Don't do any work if we are not currently running a test.
3135
3136         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3137         * WebKitTestRunner/StringFunctions.h:
3138         (WTR::toCF):
3139         Add conversion function for WKURLRef -> CFURLRef
3140
3141         * WebKitTestRunner/TestController.cpp:
3142         (WTR::TestController::TestController):
3143         (WTR::TestController::initialize):
3144         (WTR::TestController::resetStateToConsistentValues):
3145         (WTR::TestController::runTest):
3146         (WTR::TestController::didFinishLoadForFrame):
3147         * WebKitTestRunner/TestController.h:
3148         (WTR::TestController::):
3149         * WebKitTestRunner/TestInvocation.cpp:
3150         (WTR::TestInvocation::invoke):
3151         * WebKitTestRunner/TestInvocation.h:
3152         Move resetting code to TestController.
3153
3154         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3155         * WebKitTestRunner/mac/TestControllerMac.mm:
3156         (WTR::TestController::runUntil):
3157         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3158         * WebKitTestRunner/win/TestControllerWin.cpp:
3159         (WTR::TestController::runUntil):
3160         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
3161         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3162         Move runUntil to TestController.
3163
3164 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3165
3166         Unreviewed.
3167
3168         Adding myself to the committers list.
3169
3170         * Scripts/webkitpy/common/config/committers.py:
3171
3172 2010-08-12  Hayato Ito  <hayato@chromium.org>
3173
3174         Reviewed by Tony Chang.
3175
3176         Merge pretty printers for gdb.
3177         https://bugs.webkit.org/show_bug.cgi?id=43850
3178
3179         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
3180         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
3181         webcore.py is left for backward compatibility.
3182
3183         * gdb/webcore.py:
3184         * gdb/webkit.py: Added.
3185         * gdb/wtf.py: Removed.
3186
3187 2010-08-11  Tony Chang  <tony@chromium.org>
3188
3189         Reviewed by David Levin.
3190
3191         [chromium] add google-chrome layout test result directories
3192         https://bugs.webkit.org/show_bug.cgi?id=43889
3193
3194         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3195         * Scripts/webkitpy/layout_tests/port/factory.py:
3196         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
3197         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3198
3199 2010-08-11  Kent Tamura  <tkent@chromium.org>
3200
3201         Reviewed by Dimitri Glazkov.
3202
3203         [DRT/Chromium] Disable accelerated compositing
3204         https://bugs.webkit.org/show_bug.cgi?id=43894
3205
3206         Disable accelerated compositing because DRT is not ready for
3207         it. This change fixes hundreds of test crashes on Windows and
3208         Linux.
3209
3210         * DumpRenderTree/chromium/TestShell.cpp:
3211         (TestShell::resetWebSettings):
3212
3213 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3214
3215         Unreviewed. Adding my Collabora personality to the list.
3216
3217         * Scripts/webkitpy/common/config/committers.py:
3218
3219 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
3220
3221         Adding myself as a reviewer.
3222
3223         * Scripts/webkitpy/common/config/committers.py:
3224
3225 2010-08-11  Daniel Bates  <dbates@rim.com>
3226
3227         Reviewed by Darin Adler.
3228
3229         Perl warnings when running commit-log-editor
3230         https://bugs.webkit.org/show_bug.cgi?id=43856
3231
3232         Fixes Perl warnings introduced by the patch for Bug #40548.
3233
3234         Perl doesn't have symbolic names for True/False. Instead, we
3235         should use boolean values. Moreover, the variable installedEditorApplication
3236         is not be used and should be renamed builtEditorApplication so that it
3237         uses the existing machinery to set the commit log editor application.
3238
3239         * Scripts/commit-log-editor:
3240
3241 2010-08-11  Adam Barth  <abarth@webkit.org>
3242
3243         Reviewed by Eric Seidel.
3244
3245         Trying waiting for httpd lock in the EWS
3246         https://bugs.webkit.org/show_bug.cgi?id=43833
3247
3248         If this works, we can probably run the tests on the mac-ews, which
3249         would be very exciting.  :)
3250
3251         * Scripts/webkitpy/tool/steps/runtests.py:
3252
3253 2010-08-11  Marcus Bulach  <bulach@chromium.org>
3254
3255         Reviewed by Eric Seidel.
3256
3257         Check in a script to list redundant test outputs.
3258         https://bugs.webkit.org/show_bug.cgi?id=37630
3259
3260         If e.g. platform/mac-leopard is missing an expected test output, we
3261         fall back on platform/mac.  This means it's possible to grow redundant
3262         test outputs, where we have the same expected data in both a platform
3263         directory and another platform it falls back on.
3264         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
3265
3266         * Scripts/deduplicate-tests: Added.
3267         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
3268         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
3269
3270 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3271
3272         Reviewed by Ariya Hidayat.
3273
3274         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
3275         https://bugs.webkit.org/show_bug.cgi?id=43853
3276
3277         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
3278         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
3279         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
3280         to slots at all.
3281
3282         * QtTestBrowser/launcherwindow.cpp:
3283         (LauncherWindow::createChrome):
3284         (LauncherWindow::animatedFlip):
3285         (LauncherWindow::animatedYFlip):
3286         * QtTestBrowser/launcherwindow.h:
3287
3288 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
3289
3290         Reviewed by Simon Hausmann.
3291
3292         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
3293         https://bugs.webkit.org/show_bug.cgi?id=43851
3294
3295         All window options data (including the bool holding if the view is either QWebView or
3296         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
3297         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
3298         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
3299         getting broken.
3300
3301         Patch addresses this issue.
3302
3303         * QtTestBrowser/launcherwindow.cpp:
3304         (LauncherWindow::createChrome):
3305         (LauncherWindow::toggleWebView):
3306         (LauncherWindow::toggleAcceleratedCompositing):
3307
3308 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
3309
3310         Reviewed by Ariya Hidayat.
3311
3312         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
3313         https://bugs.webkit.org/show_bug.cgi?id=43831
3314
3315         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
3316
3317         * QtTestBrowser/webview.cpp:
3318         (WebViewGraphicsBased::WebViewGraphicsBased):
3319         (WebViewGraphicsBased::animatedYFlip):
3320
3321 2010-08-11  Darin Adler  <darin@apple.com>
3322
3323         Reviewed by John Sullivan.
3324
3325         Improved editor options for prepare-ChangeLog and commit-log-editor
3326         https://bugs.webkit.org/show_bug.cgi?id=40548
3327
3328         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
3329         values like "xed --launch --wait" work properly.
3330
3331         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
3332         use a command line tool with the $openChangeLogs feature.
3333
3334 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
3335
3336         Reviewed by Pavel Feldman.
3337
3338         Web Inspector: remove InjectDispatch.js
3339         https://bugs.webkit.org/show_bug.cgi?id=43835
3340
3341         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3342         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3343
3344 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
3345
3346         Reviewed by Eric Seidel.
3347
3348         webkit-patch should refuse to run under Win32 Python
3349         https://bugs.webkit.org/show_bug.cgi?id=40962
3350
3351         Given that there are lots of places in webkit-patch's code that
3352         assume unix-style filenames (forward slashes), webkit-patch fails
3353         with weird file-not-found errors when run under a native windows
3354         Python. It would be nice if we just trapped this and errored out
3355         at the beginning, rather than producing unpredictable errors.
3356
3357         * Scripts/webkit-patch:
3358
3359 2010-08-10  Kent Tamura  <tkent@chromium.org>
3360
3361         Unreviewed, build fix.
3362         
3363         Chromium build fix for r65107.
3364
3365         * DumpRenderTree/chromium/LayoutTestController.cpp:
3366         (LayoutTestController::suspendAnimations):
3367         (LayoutTestController::resumeAnimations):
3368
3369 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
3370
3371         Reviewed by Xan Lopez.
3372
3373         [GTK] http/tests/media/video-cookie.html fails
3374         https://bugs.webkit.org/show_bug.cgi?id=42240
3375
3376         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3377         (LayoutTestController::setAlwaysAcceptCookies): create the
3378         SoupCookieJar if it does not exist. Otherwise the accept policy
3379         won't be set.
3380
3381 2010-08-10  Chris Marrin  <cmarrin@apple.com>
3382
3383         Reviewed by Oliver Hunt.
3384
3385         Add suspendAnimations/resumeAnimation API to DRT
3386         https://bugs.webkit.org/show_bug.cgi?id=43733
3387         
3388         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
3389         Calls functions with the same names on AnimationController for the 
3390         mainFrame.
3391
3392         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3393         * DumpRenderTree/LayoutTestController.cpp:
3394         (suspendAnimationsCallback):
3395         (resumeAnimationsCallback):
3396         (LayoutTestController::staticFunctions):
3397         * DumpRenderTree/LayoutTestController.h:
3398         * DumpRenderTree/chromium/LayoutTestController.cpp:
3399         (LayoutTestController::LayoutTestController):
3400         (LayoutTestController::suspendAnimations):
3401         (LayoutTestController::resumeAnimations):
3402         * DumpRenderTree/chromium/LayoutTestController.h:
3403         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3404         (LayoutTestController::suspendAnimations):
3405         (LayoutTestController::resumeAnimations):
3406         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3407         (LayoutTestController::suspendAnimations):
3408         (LayoutTestController::resumeAnimations):
3409         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3410         (LayoutTestController::suspendAnimations):
3411         (LayoutTestController::resumeAnimations):
3412         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3413         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3414         (LayoutTestController::suspendAnimations):
3415         (LayoutTestController::resumeAnimations):
3416         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3417         (LayoutTestController::suspendAnimations):
3418         (LayoutTestController::resumeAnimations):
3419
3420 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3421
3422         Reviewed by Ojan Vafai.
3423
3424         [Chromium/DRT] Enable saving layout test results.
3425         https://bugs.webkit.org/show_bug.cgi?id=43796
3426
3427         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
3428             parameters to the new-run-webkit-tests, including the name
3429             of the test results server.
3430
3431 2010-08-10  Jian Li  <jianli@chromium.org>
3432
3433         More chromium build fix.
3434
3435         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3436         (MockSpellCheck::spellCheckWord):
3437         (MockSpellCheck::initializeIfNeeded):
3438         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3439         (NotificationPresenter::grantPermission):
3440         (NotificationPresenter::show):
3441         (NotificationPresenter::checkPermission):
3442
3443 2010-08-10  Jian Li  <jianli@chromium.org>
3444
3445         Chromium build fix.
3446
3447         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3448         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3449
3450 2010-08-10  Victor Wang  <victorw@chromium.org>
3451
3452         Reviewed by Ojan Vafai.
3453
3454         Update test results server merge logic so the aggregated
3455         results and times are updated for tests that are
3456         in aggragated json but not in incremental json.
3457
3458         Also update unittest to test this case.
3459
3460         https://bugs.webkit.org/show_bug.cgi?id=43769
3461
3462         * TestResultServer/model/jsonresults.py:
3463         * TestResultServer/model/jsonresults_unittest.py:
3464
3465 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3466
3467         Reviewed by Ariya Hidayat.
3468
3469         [Qt] QtTestBrowser: proper set scene rect
3470
3471         When resizesToContents is ON scene's rect is set to the boundary of
3472         the mainFrame. However, navigating to other web page should keep resizing
3473         scene's rect according to the new document loaded. Patch addresses this issue.
3474
3475         Now resizesToContents and scrolling properly work on QtTestBrowser.
3476
3477         * QtTestBrowser/webview.cpp:
3478         (WebViewGraphicsBased::setPage):
3479         (WebViewGraphicsBased::contentsSizeChanged):
3480         (WebViewGraphicsBased::setResizesToContents):
3481         (WebViewGraphicsBased::resizeEvent):
3482         * QtTestBrowser/webview.h:
3483
3484 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3485
3486         Reviewed by Ariya Hidayat.
3487
3488         [Qt] QtTestBrowser: Clean up LauncherWindow code.
3489
3490         * QtTestBrowser/launcherwindow.cpp:
3491         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
3492         (LauncherWindow::init): Fixed comments.
3493         (LauncherWindow::applyPrefs): Move the method around.
3494         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
3495
3496 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3497
3498         Reviewed by Ariya Hidayat.
3499
3500         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
3501
3502         It gets control+0 the same visual effect as control++ or control-.
3503
3504         * QtTestBrowser/launcherwindow.cpp:
3505         (LauncherWindow::toggleZoomTextOnly):
3506
3507 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
3508
3509         Reviewed by Ariya Hidayat.
3510
3511         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
3512
3513         Not all instances of LauncherWindow need its own m_zoomLevel.
3514
3515         * QtTestBrowser/launcherwindow.cpp:
3516         * QtTestBrowser/launcherwindow.h:
3517
3518 2010-08-09  Sam Weinig  <sam@webkit.org>
3519
3520         Reviewed by Geoffrey Garen.
3521
3522         Add zoom support for injected bundle
3523         https://bugs.webkit.org/show_bug.cgi?id=43759
3524
3525         Use zoom factor SPI to implement zoom related eventSender functions.
3526
3527         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3528         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3529         (WTR::EventSendingController::textZoomIn):
3530         (WTR::EventSendingController::textZoomOut):
3531         (WTR::EventSendingController::zoomPageIn):
3532         (WTR::EventSendingController::zoomPageOut):
3533         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3535         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
3536
3537 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
3538
3539         Speculative chromium build fix III.
3540
3541         * DumpRenderTree/chromium/MockSpellCheck.h:
3542         * DumpRenderTree/chromium/NotificationPresenter.h:
3543         * DumpRenderTree/chromium/WebViewHost.h:
3544         (WebViewHost::addClearHeader):
3545         (WebViewHost::clearHeaders):
3546
3547 2010-08-09  Ojan Vafai  <ojan@chromium.org>
3548
3549         Reviewed by Tony Chang.
3550
3551         increase the number of test results that we save
3552         https://bugs.webkit.org/show_bug.cgi?id=43763
3553
3554         Now that we do incremental uploads, we can increase the number of
3555         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
3556
3557         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3558
3559 2010-08-09  Evan Martin  <evan@chromium.org>
3560
3561         Reviewed by Tony Chang.
3562
3563         [chromium] DRT error print statement incorrectly tries to print a FILE*
3564         https://bugs.webkit.org/show_bug.cgi?id=43747
3565
3566         * DumpRenderTree/chromium/ImageDiff.cpp:
3567         (writeFile): pass the correct pointer.
3568
3569 2010-08-09  Victor Wang  <victorw@chromium.org>
3570
3571         Reviewed by Ojan Vafai.
3572
3573         Upload incremental test results json to server by default.
3574
3575         https://bugs.webkit.org/show_bug.cgi?id=43743
3576
3577         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3578
3579 2010-08-09  Eric Seidel  <eric@webkit.org>
3580
3581         Reviewed by Adam Barth.
3582
3583         EWS bots wait 2 minutes between patches
3584         https://bugs.webkit.org/show_bug.cgi?id=43731
3585
3586         * Scripts/webkitpy/tool/bot/queueengine.py:
3587          - Don't sleep after failures.  This was a hold-over from
3588            an earlier design.
3589         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3590          - EWS bots were not properly reporting true/false from process_work_item.
3591            They were always returning None, thus false, thus always logging
3592            as a failure and sleeping 2 minutes after each patch.
3593
3594 2010-08-09  Sam Weinig  <sam@webkit.org>
3595
3596         Reviewed by Anders Carlsson.
3597
3598         Stub out EventSender for WebKitTestRunner
3599         https://bugs.webkit.org/show_bug.cgi?id=43703
3600
3601         * WebKitTestRunner/DerivedSources.make:
3602         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3603         Add ability to pass javascript arguments to the wrapped object.
3604
3605         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
3606         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
3607         (WTR::EventSendingController::create):
3608         (WTR::EventSendingController::EventSendingController):
3609         (WTR::EventSendingController::~EventSendingController):
3610         (WTR::EventSendingController::wrapperClass):
3611         (WTR::setExceptionForString):
3612         (WTR::EventSendingController::mouseDown):
3613         (WTR::EventSendingController::mouseUp):
3614         (WTR::EventSendingController::mouseMoveTo):
3615         (WTR::EventSendingController::keyDown):
3616         (WTR::EventSendingController::contextClick):
3617         (WTR::EventSendingController::leapForward):
3618         (WTR::EventSendingController::textZoomIn):
3619         (WTR::EventSendingController::textZoomOut):
3620         (WTR::EventSendingController::zoomPageIn):
3621         (WTR::EventSendingController::zoomPageOut):
3622         (WTR::EventSendingController::makeWindowObject):
3623         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
3624         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3625         (WTR::InjectedBundle::reset):
3626         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3627         (WTR::InjectedBundle::eventSendingController):
3628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3629         (WTR::InjectedBundlePage::didClearWindowForFrame):
3630         Add stubbed out EventSenderController.
3631
3632         * WebKitTestRunner/InjectedBundle/GCController.h:
3633         Remove incorrect comment.
3634
3635         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3636         * WebKitTestRunner/win/InjectedBundle.vcproj:
3637         Add new files.
3638
3639 2010-08-08  Kent Tamura  <tkent@chromium.org>
3640
3641         Unreviewed, trivial fix.
3642
3643         Fix "WindowsError: [Error 32] The process cannot access the file
3644         because it is being used by another process" introduced by r64959.
3645
3646         * BuildSlaveSupport/test-result-archive:
3647
3648 2010-08-08  Kent Tamura  <tkent@chromium.org>
3649
3650         Reviewed by Tony Chang.
3651
3652         Chromium buildbot: Avoid "zip" command dependency
3653         https://bugs.webkit.org/show_bug.cgi?id=43470
3654
3655         * BuildSlaveSupport/test-result-archive:
3656          For Chromium port, creates a zip archive with zipfile package of Python
3657          instead of external "zip" command. We'd like to avoid additional
3658          command installation.
3659
3660 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
3661
3662         WebKitTestRunner should add the QuickTime dir to the PATH environment
3663         variable
3664         https://bugs.webkit.org/show_bug.cgi?id=43686
3665
3666         Reviewed by Dan Bernstein.
3667
3668         * WebKitTestRunner/win/TestControllerWin.cpp:
3669         (WTR::addQTDirToPATH):
3670         Copied from DRT.
3671         (WTR::TestController::platformInitialize):
3672         Call addQTDirToPath().
3673         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3674         Link to shlwapi.lib for SHGetValue.
3675
3676 2010-08-07  Sam Weinig  <sam@webkit.org>
3677
3678         Reviewed by Maciej Stachowiak.
3679
3680         WebKitTestRunner needs layoutTestController.dumpTitleChanges
3681         <rdar://problem/8213861>
3682         https://bugs.webkit.org/show_bug.cgi?id=42683
3683
3684         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3685         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3686         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3687         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3688         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3689         (WTR::LayoutTestController::LayoutTestController):
3690         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3691         (WTR::LayoutTestController::dumpTitleChanges):
3692         (WTR::LayoutTestController::shouldDumpTitleChanges):
3693
3694 2010-08-07  Sam Weinig  <sam@webkit.org>
3695
3696         Reviewed by Anders Carlsson.
3697
3698         WebKitTestRunner needs to print onunload handler information
3699         <rdar://problem/8213831>
3700         https://bugs.webkit.org/show_bug.cgi?id=42703
3701
3702         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3703         (WTR::operator<<):
3704         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3705
3706 2010-08-07  Sam Weinig  <sam@webkit.org>
3707
3708         Reviewed by Anders Carlsson.
3709
3710         Add additional loader client functions need to complete WebKitTestRunner
3711         https://bugs.webkit.org/show_bug.cgi?id=43684
3712
3713         Remove unnecessary and jarring underscores as well.
3714
3715         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3716         (didClearWindowObjectForFrame):
3717         (didCreatePage):
3718         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3719         (WTR::InjectedBundlePage::InjectedBundlePage):
3720         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3721         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3722         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3723         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3724         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3725         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3726         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3727         (WTR::InjectedBundlePage::didClearWindowForFrame):
3728         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
3729         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
3730         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
3731         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3732         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
3733         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
3734         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
3735         (WTR::InjectedBundlePage::willAddMessageToConsole):
3736         (WTR::InjectedBundlePage::willSetStatusbarText):
3737         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3738         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3739         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3740         (WTR::InjectedBundlePage::shouldBeginEditing):
3741         (WTR::InjectedBundlePage::shouldEndEditing):
3742         (WTR::InjectedBundlePage::shouldInsertNode):
3743         (WTR::InjectedBundlePage::shouldInsertText):
3744         (WTR::InjectedBundlePage::shouldDeleteRange):
3745         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3746         (WTR::InjectedBundlePage::shouldApplyStyle):
3747         (WTR::InjectedBundlePage::didBeginEditing):
3748         (WTR::InjectedBundlePage::didEndEditing):
3749         (WTR::InjectedBundlePage::didChange):
3750         (WTR::InjectedBundlePage::didChangeSelection):
3751         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3752
3753 2010-08-07  Dan Bernstein  <mitz@apple.com>
3754
3755         Build fix.
3756
3757         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
3758         to JSGCController.{cpp,h} relative to the build root.
3759
3760 2010-08-07  Sam Weinig  <sam@webkit.org>
3761
3762         Reviewed by Anders Carlsson.
3763
3764         WebKitTestRunner needs GCController
3765         <rdar://problem/8213834>
3766         https://bugs.webkit.org/show_bug.cgi?id=42701
3767
3768         * WebKitTestRunner/DerivedSources.make:
3769         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
3770         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
3771         (WTR::setProperty):
3772         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
3773         (WTR::GCController::create):
3774         (WTR::GCController::GCController):
3775         (WTR::GCController::~GCController):
3776         (WTR::GCController::wrapperClass):
3777         (WTR::GCController::collect):
3778         (WTR::GCController::collectOnAlternateThread):
3779         (WTR::GCController::getJSObjectCount):
3780         (WTR::GCController::makeWindowObject):
3781         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
3782         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3783         (WTR::InjectedBundle::reset):
3784         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3785         (WTR::InjectedBundle::bundle):
3786         (WTR::InjectedBundle::gcController):
3787         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3788         (WTR::InjectedBundlePage::didClearWindowForFrame):
3789         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3790         (WTR::LayoutTestController::keepWebHistory):
3791         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3792         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3793         * WebKitTestRunner/win/InjectedBundle.vcproj:
3794
3795 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
3796
3797         WebKitTestRunner needs to be able to set the font smoothing type
3798         https://bugs.webkit.org/show_bug.cgi?id=43406
3799
3800         Reviewed by Adam Roben.
3801
3802         * WebKitTestRunner/TestInvocation.cpp:
3803         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3804         Set the font smoothing level to
3805         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
3806
3807 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
3808
3809         Fix a missed variable rename.
3810
3811         Unreviewed.
3812
3813         * Scripts/old-run-webkit-tests:
3814
3815 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
3816
3817         mac-wk2/Skipped should be used on Windows when running regression tests
3818         https://bugs.webkit.org/show_bug.cgi?id=43494
3819
3820         Reviewed by Adam Roben.
3821
3822         * Scripts/old-run-webkit-tests:
3823         If the platform is win-wk2, also read the mac-wk2 skipped list.
3824
3825 2010-08-06  Kent Tamura  <tkent@chromium.org>
3826
3827         Reviewed by Dimitri Glazkov.
3828
3829         [DRT/Chromium] Should revoke scheduled tasks
3830         https://bugs.webkit.org/show_bug.cgi?id=43560
3831
3832         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3833         (DRTDevToolsAgent::reset): Calls RevokeAll().
3834         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3835         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3836         (DRTDevToolsClient::reset): Calls RevokeAll().
3837         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3838         * DumpRenderTree/chromium/EventSender.cpp:
3839         (EventSender::reset): Calls RevokeAll().
3840         * DumpRenderTree/chromium/LayoutTestController.cpp:
3841         (LayoutTestController::reset): Calls RevokeAll().
3842         * DumpRenderTree/chromium/TestShell.cpp:
3843         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
3844
3845 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3846
3847         Reviewed by Antonio Gomes.
3848
3849         [Qt] Fix the DRT build on Mac OS X
3850
3851         * DumpRenderTree/qt/DumpRenderTree.pro:
3852
3853 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
3854
3855         Reviewed by Pavel Feldman.
3856
3857         Rietvield's upload.py moved to a different location.
3858         https://bugs.webkit.org/show_bug.cgi?id=43613
3859
3860         * Scripts/webkitpy/thirdparty/__init__.py:
3861
3862 2010-05-23  Eric Seidel  <eric@webkit.org>
3863
3864         Reviewed by Adam Barth.
3865
3866         QueueStatusServer needs better queue-status pages
3867         https://bugs.webkit.org/show_bug.cgi?id=39562
3868
3869         The primary goal of this patch is to display queue
3870         positions somewhere on the site so that it's easier
3871         for commit-queue users to know when their pach will
3872         be landed.  I also tried to improve the root page
3873         to be more useful than the previous wall of status text.
3874
3875         * QueueStatusServer/handlers/recentstatus.py:
3876         * QueueStatusServer/main.py:
3877         * QueueStatusServer/model/queues.py:
3878         * QueueStatusServer/templates/recentstatus.html:
3879
3880 2010-08-05  Victor Wang  <victorw@chromium.org>
3881
3882         Reviewed by Ojan Vafai.
3883
3884         Add option to generate/upload incremental json results to test result server.
3885         Also refactor the json results generator unittest code to test
3886         incremental and aggregated json results.
3887
3888         https://bugs.webkit.org/show_bug.cgi?id=43519
3889
3890         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3891         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3892         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3893         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3894
3895 2010-08-05  Jian Li  <jianli@chromium.org>
3896
3897         Reviewed by David Levin.
3898
3899         Unify blob related feature defines to ENABLE(BLOB).
3900         https://bugs.webkit.org/show_bug.cgi?id=43081
3901
3902         * Scripts/build-webkit:
3903
3904 2010-08-05  Satish Sampath  <satish@chromium.org>
3905
3906         Reviewed by Jeremy Orlow.
3907
3908         Add speech input controller mock in WebKit and a layout test.
3909         https://bugs.webkit.org/show_bug.cgi?id=43477
3910
3911         Added LayoutTestController::setMockSpeechInputResultCallback method.
3912
3913         * DumpRenderTree/LayoutTestController.cpp:
3914         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
3915         (LayoutTestController::staticFunctions):
3916         * DumpRenderTree/LayoutTestController.h:
3917         * DumpRenderTree/chromium/LayoutTestController.cpp:
3918         (LayoutTestController::LayoutTestController):
3919         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
3920         (LayoutTestController::speechInputController): Creates the mock controller.
3921         * DumpRenderTree/chromium/LayoutTestController.h:
3922         * DumpRenderTree/chromium/WebViewHost.cpp:
3923         (WebViewHost::speechInputController): Creates the mock controller.
3924         * DumpRenderTree/chromium/WebViewHost.h:
3925         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3926         (LayoutTestController::setMockSpeechInputResult): dummy method.
3927         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3928         (LayoutTestController::setMockSpeechInputResult): dummy method.
3929         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3930         (LayoutTestController::setMockSpeechInputResult): dummy method.
3931         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3932         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
3933         (LayoutTestController::setMockSpeechInputResult):
3934         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
3935         (LayoutTestController::setMockSpeechInputResult):
3936
3937 2010-08-04  Adam Roben  <aroben@apple.com>
3938
3939         Fix the path to TestNetscapePlugin's directory on Windows
3940
3941         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
3942         load TestNetscapePlugin
3943
3944         Reviewed by Jon Honeycutt.
3945
3946         * WebKitTestRunner/win/TestControllerWin.cpp:
3947         (WTR::TestController::initializeTestPluginDirectory):
3948         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
3949         next to WebKitTestRunner.exe. Previously we were passing the directory
3950         that contains WebKitTestRunner.exe. Also fixed some leaks.
3951
3952 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
3953
3954         Reviewed by Shinichiro Hamaji.
3955
3956         check-webkit-style returns non-zero when patch is entirely minus lines.
3957         https://bugs.webkit.org/show_bug.cgi?id=38169
3958
3959         * Scripts/check-webkit-style:
3960         Check whether a patch contains modified files that are entirely minus lines.
3961         * Scripts/webkitpy/style/filereader.py:
3962         Add a variable that holds number of files that contain only deleted lines.
3963         * Scripts/webkitpy/style/patchreader.py:
3964         Count up modified files that contain only deleted lines.
3965
3966 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
3967
3968         Reviewed by Yury Semikhatsky.
3969
3970         DevTools: get rid of delayed command dispatching on front-end side.
3971
3972         https://bugs.webkit.org/show_bug.cgi?id=43479
3973
3974         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3975         (DRTDevToolsAgent::detach):
3976         (DRTDevToolsAgent::frontendLoaded):
3977         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3978         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3979         (DRTDevToolsClient::~DRTDevToolsClient):
3980         (DRTDevToolsClient::sendFrontendLoaded):
3981         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3982
3983 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
3984
3985         Reviewed by Shinichiro Hamaji.
3986
3987         Fixes check-webkit-style false positive on "new uint32_t."
3988         https://bugs.webkit.org/show_bug.cgi?id=43077
3989
3990         * Scripts/webkitpy/style/checkers/cpp.py:
3991         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3992
3993 2010-08-04  Kent Tamura  <tkent@chromium.org>
3994
3995         Reviewed by Dimitri Glazkov.
3996
3997         [DRT/Chromium] Remove base/linked_ptr.h dependency
3998         https://bugs.webkit.org/show_bug.cgi?id=43472
3999
4000         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
4001         We need to use RefPtr<> because m_pendingEntry points an object in
4002         m_entries or not in m_entries.
4003
4004         * DumpRenderTree/chromium/TestNavigationController.cpp:
4005         (TestNavigationEntry::create): Added.
4006         (TestNavigationController::activeEntry):
4007         (TestNavigationController::didNavigateToEntry):
4008         (TestNavigationController::discardPendingEntry):
4009         (TestNavigationController::insertEntry):
4010         (TestNavigationController::navigateToPendingEntry):
4011         * DumpRenderTree/chromium/TestNavigationController.h:
4012         * DumpRenderTree/chromium/WebViewHost.cpp:
4013         (WebViewHost::loadURLForFrame):
4014          Use TestNavigationEntry::create().
4015         (WebViewHost::updateURL):
4016          Use RefPtr<>.
4017         (WebViewHost::updateSessionHistory):
4018          Remove unnecessary static_cast<>.
4019
4020 2010-08-04  Kent Tamura  <tkent@chromium.org>
4021
4022         Reviewed by Dimitri Glazkov.
4023
4024         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
4025         https://bugs.webkit.org/show_bug.cgi?id=43333
4026
4027         * BuildSlaveSupport/test-result-archive:
4028           - Make layoutTestResultsDir local and pass it to archiveTestResults()
4029           - Adjust layoutTestResultsDir for Chromium
4030
4031 2010-08-04  Kent Tamura  <tkent@chromium.org>
4032
4033         Reviewed by Dimitri Glazkov.
4034
4035         NRWT: websocket_server startup detection failure
4036         https://bugs.webkit.org/show_bug.cgi?id=43466
4037
4038         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
4039          Increase timeout value: 5 second -> 10 second
4040
4041 2010-08-04  Victor Wang  <victorw@chromium.org>
4042
4043         Reviewed by Ojan Vafai.
4044
4045         -. Add result.json incremental merging functionality to test results app engine.
4046         -. blobstore is not suitable for AE data merging and there is no API to
4047            programatically edit existing blob or write a new one yet, so replace blobstore
4048            with datastore. If file is oversize (>1000*1000 bytes), store file data in
4049            multiple datastore entries.
4050         -. Fix styles.
4051
4052         Test: jsonresults_unittest to test merging logics.
4053
4054         https://bugs.webkit.org/show_bug.cgi?id=38599
4055
4056         * TestResultServer/handlers/dashboardhandler.py:
4057         * TestResultServer/handlers/menu.py:
4058         * TestResultServer/handlers/testfilehandler.py:
4059         * TestResultServer/main.py:
4060         * TestResultServer/model/dashboardfile.py:
4061         * TestResultServer/model/datastorefile.py: Added.
4062         * TestResultServer/model/jsonresults.py: Added.
4063         * TestResultServer/model/jsonresults_unittest.py: Added.
4064         * TestResultServer/model/testfile.py:
4065         * TestResultServer/templates/uploadform.html:
4066
4067 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
4068
4069         Reviewed by Kenneth Christiansen.
4070
4071         [Qt] [QtTestBrowser] Remove unneeded QAction class members
4072         https://bugs.webkit.org/show_bug.cgi?id=43518
4073
4074         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
4075         m_flipYAnimated. Also, in initializeView method there are some dead code block
4076         trying to connect them at the wrong time, when they have not been instanciated.
4077
4078         This patch:
4079
4080         - removes the two cited class members in favor of local variables in createChrome method;
4081         - removes the dead code block.
4082
4083         * QtTestBrowser/launcherwindow.cpp:
4084         (LauncherWindow::LauncherWindow):
4085         (LauncherWindow::initializeView):
4086         (LauncherWindow::createChrome):
4087         * QtTestBrowser/launcherwindow.h:
4088
4089 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
4090
4091         Reviewed by Simon Hausmann and Kenneth Christiansen.
4092
4093         [Qt] [QtTestBrowser] Clean up static and global menu state controls
4094         https://bugs.webkit.org/show_bug.cgi?id=43448
4095
4096         After LauncherWindow class was refactored out of from main.cpp, all global variables that
4097         were hanging in main.cpp became temporarily public static class members of newly added
4098         LauncherWindow class. This design was not properly handling the initial purpose of the
4099         global variables: newly created launcher windows should inherit the settings of the originating
4100         one.
4101
4102         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
4103         comprises all data needed to handling the goal described above.
4104
4105         * QtTestBrowser/launcherwindow.cpp:
4106         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
4107                                           holding all user settings configured in the menus and command line.
4108                                           It also receices an optional QGraphicsScene points in case we are doing
4109                                           a "Clone Window".
4110         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
4111                                 value.
4112         (LauncherWindow::initializeView): Ditto.
4113         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
4114         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
4115                                       apply the preferences is provided by m_userData.
4116         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
4117         (LauncherWindow::toggleResizesToContents): Ditto.
4118         (LauncherWindow::toggleWebGL): Ditto.
4119         (LauncherWindow::toggleFrameFlattening): Ditto.
4120         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
4121         (LauncherWindow::changeViewportUpdateMode): Ditto.
4122         (LauncherWindow::showFPS): Ditto.
4123         (LauncherWindow::newWindow): Changed to pass the userData.
4124         (LauncherWindow::cloneWindow): Ditto.
4125         * QtTestBrowser/launcherwindow.h:
4126         (WindowOptions::WindowOptions):
4127         * QtTestBrowser/main.cpp:
4128         (requiresGraphicsView):
4129         (LauncherApplication::handleUserOptions):
4130         (main):
4131
4132 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
4133
4134         [wx] Build fix for gcc not importing all symbols from convenience libraries.
4135         Works on 10.6 only for Mac until the build system is reworked. 
4136
4137         * wx/build/settings.py:
4138
4139 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
4140
4141         Reviewed by Simon Hausmann.
4142
4143         [Qt] Change wording in QtTestBrowser
4144         https://bugs.webkit.org/show_bug.cgi?id=43241
4145
4146         * QtTestBrowser/launcherwindow.cpp:
4147         (LauncherWindow::createChrome):
4148
4149 2010-08-04  Aaron Boodman  <aa@chromium.org>
4150
4151         Reviewed by Eric Seidel.
4152
4153         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
4154         https://bugs.webkit.org/show_bug.cgi?id=43460
4155
4156         * Scripts/prepare-ChangeLog:
4157
4158 2010-08-03  MORITA Hajime  <morrita@google.com>
4159
4160         Reviewed by Tony Chang.
4161
4162         [DRT] Assertion failed when drag and move a draggable element.
4163         https://bugs.webkit.org/show_bug.cgi?id=41695
4164
4165         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
4166         But Cocoa doesn't call mouseDragged() until dragging is done.
4167         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
4168         on UIDelegate failed when mouseDragged() is called during dragging.
4169         This change eliminated the mouseDragged() call when dragging begins,
4170         which is implicated by draggingInfo instance.
4171         
4172         * DumpRenderTree/mac/EventSendingController.mm:
4173         (-[EventSendingController mouseMoveToX:Y:]):
4174
4175         Test: fast/events/dragging-mouse-moves.html
4176         
4177 2010-08-02  Steve Block  <steveblock@google.com>
4178
4179         Reviewed by Alexey Proskuryakov.
4180
4181         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
4182         https://bugs.webkit.org/show_bug.cgi?id=40002
4183
4184         The code in LayoutTestController::setGeolocationPermission() was moved to
4185         setGeolocationPermissionCommon() to allow each port to provide its own
4186         implementation of setGeolocationPermission().
4187
4188         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
4189         new permission, so it can call back to WebCore if permission requests are in
4190         progress and are waiting for a response. A minor fix to the Mac
4191         MockGeolocationProvider was also required to make sure that the mock provider
4192         calls back to WebCore when it is first started.
4193
4194         For other ports, LayoutTestController::setGeolocationPermission() is not
4195         implemented.
4196
4197         * DumpRenderTree/LayoutTestController.cpp:
4198         (LayoutTestController::setGeolocationPermissionCommon):
4199         * DumpRenderTree/LayoutTestController.h:
4200         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4201         (LayoutTestController::setGeolocationPermission):
4202         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4203         (LayoutTestController::setGeolocationPermission):
4204         * DumpRenderTree/mac/MockGeolocationProvider.mm:
4205         (-[MockGeolocationProvider registerWebView:]):
4206         * DumpRenderTree/mac/UIDelegate.h:
4207         * DumpRenderTree/mac/UIDelegate.mm:
4208         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
4209         (-[UIDelegate setGeolocationPermission:]):
4210         (-[UIDelegate dealloc]):
4211         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4212         (LayoutTestController::setGeolocationPermission):
4213         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4214         (LayoutTestController::setGeolocationPermission):
4215
4216 2010-08-03  Kent Tamura  <tkent@chromium.org>
4217
4218         Reviewed by Dimitri Glazkov.
4219
4220         [DRT/Chromium] Implement --testshell-startup-dialog
4221         https://bugs.webkit.org/show_bug.cgi?id=40616
4222
4223         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4224         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
4225         if it is specfied.
4226         * DumpRenderTree/chromium/TestShell.h:
4227           Declare openStartUpDialog().
4228         * DumpRenderTree/chromium/TestShellGtk.cpp:
4229         (openStartupDialog):
4230         * DumpRenderTree/chromium/TestShellMac.mm:
4231         (openStartupDialog):
4232         * DumpRenderTree/chromium/TestShellWin.cpp:
4233         (openStartupDialog):
4234
4235 2010-08-03  Kent Tamura  <tkent@chromium.org>
4236
4237         Reviewed by Dimitri Glazkov.
4238
4239         [DRT/Chromium] Remove dependency of base/md5.h
4240         https://bugs.webkit.org/show_bug.cgi?id=43403
4241
4242         * DumpRenderTree/chromium/TestShell.cpp:
4243         (TestShell::dumpImage): Use wtf/MD5.h
4244
4245 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
4246
4247         Reviewed by David Kilzer.
4248
4249         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
4250         https://bugs.webkit.org/show_bug.cgi?id=40627
4251
4252         Part 6 - LayoutTest and Cleanup
4253
4254           Allow tests to delete application caches and set application cache
4255           origin quotas, so they can be tested.
4256
4257         * DumpRenderTree/LayoutTestController.cpp:
4258         (LayoutTestController::LayoutTestController):
4259         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
4260         (clearAllApplicationCachesCallback): should delete all application caches.
4261         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
4262         (LayoutTestController::staticFunctions):
4263         * DumpRenderTree/LayoutTestController.h:
4264         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
4265         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
4266
4267           Mac implementation.
4268
4269         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4270         (LayoutTestController::clearAllApplicationCaches): delete application caches.
4271         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
4272         * DumpRenderTree/mac/UIDelegate.mm:
4273         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
4274         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
4275
4276           Stub implementations for other platforms.
4277
4278         * DumpRenderTree/chromium/LayoutTestController.cpp:
4279         (LayoutTestController::LayoutTestController):
4280         (LayoutTestController::clearAllApplicationCaches):
4281         (LayoutTestController::setApplicationCacheOriginQuota):
4282         * DumpRenderTree/chromium/LayoutTestController.h:
4283         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4284         (LayoutTestController::clearAllApplicationCaches):
4285         (LayoutTestController::setApplicationCacheOriginQuota):
4286         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4287         (LayoutTestController::clearAllApplicationCaches):
4288         (LayoutTestController::setApplicationCacheOriginQuota):
4289         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4290         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4291         (LayoutTestController::clearAllApplicationCaches):
4292         (LayoutTestController::setApplicationCacheOriginQuota):
4293         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4294         (LayoutTestController::clearAllApplicationCaches):
4295         (LayoutTestController::setApplicationCacheOriginQuota):
4296
4297 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
4298
4299         Reviewed by David Kilzer.
4300
4301         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
4302         https://bugs.webkit.org/show_bug.cgi?id=40627
4303
4304         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
4305
4306           Change old style calls to make use of the managers.
4307
4308         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4309         (LayoutTestController::setDatabaseQuota):
4310         * DumpRenderTree/mac/UIDelegate.mm:
4311         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
4312
4313 2010-08-03  Mark Rowe  <mrowe@apple.com>
4314
4315         Add a new Leopard build slave to run the release tests.
4316
4317         * BuildSlaveSupport/build.webkit.org-config/config.json: