[WebKit.git] / WebKitTools / ChangeLog

2009-09-14  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Oliver Hunt.

        Add LayoutTests infrastructure to enable and disable webgl tests.
        https://bugs.webkit.org/show_bug.cgi?id=29254

        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

2009-09-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.
        
        Add --iterations option to run-webkit-tests to repeat the tests N times
        https://bugs.webkit.org/show_bug.cgi?id=29263

        When run with --iterations N, run-webkit-tests will repeat the tests N times.

        * Scripts/run-webkit-tests:

2009-09-14  Brady Eidson  <beidson@apple.com>

        Not reviewed, maybe should've been:

        Cleaning up more Windows-specific fallout from the fix for:
        <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160

        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
          and call the correct method to get the Sender.

2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>

        GTK build fix.

        Unreviewed.

        * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
        (AccessibilityController::setLogScrollingStartEvents):

2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>

        DRT/test part of
        <rdar://problem/7197644> WebKit should broadcast an MSAA event when
        jumping to a named anchor

        https://bugs.webkit.org/show_bug.cgi?id=28899

        Reviewed by Adam Roben.

        * DumpRenderTree/AccessibilityController.cpp:
        (logScrollingStartEventsCallback):
        Turn on logging of scrolling start events.
        (AccessibilityController::getJSClass):
        Add a "logScrollingStartEvents" to the AccessibilityController's JS
        class definition.
        (AccessibilityController::resetToConsistentState):
        Turn off logging of scrolling start events.

        * DumpRenderTree/AccessibilityController.h:
        Declare setLogScrollingStartEvents(). Add a member for the scrolling
        start event hook.

        * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
        (AccessibilityController::setLogScrollingStartEvents):
        Stubbed.

        * DumpRenderTree/win/AccessibilityControllerWin.cpp:
        (AccessibilityController::AccessibilityController):
        Initialize the handle to 0.
        (logEventProc):
        Renamed from logFocusEventProc; now logs scrolling start events, too.
        Removed the assertion that the event is a focus event. Added a switch
        to print a message for focus, scrolling start, and other, unknown
        events.
        (AccessibilityController::setLogFocusEvents):
        Changed to use logEventProc.
        (AccessibilityController::setLogScrollingStartEvents):
        If turning logging off, unhook the scrolling start event hook, and clear
        the member holding the handle. If turning on, query for the root
        accessible, so that accessibility is enabled for the WebView, and call
        SetWinEventHook to setup an event hook using logEventProc as the
        callback function.

2009-09-14  Brady Eidson  <beidson@apple.com>

        Windows build fix.

        * DumpRenderTree/LayoutTestController.cpp:
        (setAuthenticationPasswordCallback):
        (setAuthenticationUsernameCallback):
        
        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::didReceiveAuthenticationChallenge):

2009-09-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Alexey Proskuryakov.

        Safari 4 cannot be used to update firmware on Linksys routers.
        <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160

        Add the ability for DRT to handle authentication challenges.

        * DumpRenderTree/LayoutTestController.cpp:
        (setAuthenticationPasswordCallback):
        (setAuthenticationUsernameCallback):
        (setHandlesAuthenticationChallengesCallback):
        (LayoutTestController::staticFunctions):

        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::handlesAuthenticationChallenges):
        (LayoutTestController::setHandlesAuthenticationChallenges):
        (LayoutTestController::authenticationUsername):
        (LayoutTestController::setAuthenticationUsername):
        (LayoutTestController::authenticationPassword):
        (LayoutTestController::setAuthenticationPassword):

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):

        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
        * DumpRenderTree/win/ResourceLoadDelegate.h:

2009-09-12  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Test for <rdar://problem/6954546> and <rdar://problem/7090444>.

        Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
        This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):

2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix for non-wxPython builds and a fix for errors when updating swig.py.

        * wx/build/build_utils.py:
        * wx/build/settings.py:

2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Tor Arne Vestbø.

        [Qt] Build fix for windows build.

        * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.

2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>

        Fix typo accidently landed in last commit.

        * wx/build/settings.py:

2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix, error out if using the wrong Python.

        * wx/build/settings.py:

2009-09-13  Xan Lopez  <xlopez@igalia.com>

        Build fix for GTK+ < 2.14.

        Do not use gtk_widget_get_window, access the window directly
        through the struct.

        * DumpRenderTree/gtk/EventSender.cpp:
        (contextClickCallback):
        (mouseDownCallback):
        (mouseUpCallback):
        (mouseMoveToCallback):
        (keyDownCallback):

2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez and Jan Alonzo.

        [GTK] EventSender does not set 'window' property on synthesized GDK events
        https://bugs.webkit.org/show_bug.cgi?id=29169

        Set the window property on synthesized GDK events in the GTK+ EventSender.

        * DumpRenderTree/gtk/EventSender.cpp:
        (contextClickCallback):
        (mouseDownCallback):
        (mouseUpCallback):
        (mouseMoveToCallback):
        (keyDownCallback):

2009-09-12  Drew Wilson  <atwilson@google.com>

        Reviewed by Mark Rowe.

        run-webkit-tests has a timeout value that is too low
        https://bugs.webkit.org/show_bug.cgi?id=29223

        * Scripts/run-webkit-tests:
        Changed timeout value to 20 seconds to avoid timing out too early.

2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
        architectures are supported for building wxWebKit.

        * wx/build/settings.py:

2009-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        bugzilla-tool rollout threw exception under svn
        https://bugs.webkit.org/show_bug.cgi?id=29211

        * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
        * Scripts/modules/scm_unittest.py: add testing for this fix.

2009-09-11  Brian Weinstein  <bweinstein@apple.com>

        Add myself to the committers list.

        * Scripts/modules/committers.py:

2009-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool land-patches should only fail-fast in --commit-queue mode
        https://bugs.webkit.org/show_bug.cgi?id=29201

        * Scripts/bugzilla-tool:

2009-09-11  Adam Roben  <aroben@apple.com>

        Make commit-log-editor move common prefixes to the top of the log

        Fies <http://webkit.org/b/29190> commit-log-editor should move common
        prefixes to the top of the commit log

        Reviewed by Darin Adler.

        * Scripts/commit-log-editor: Find and remove the longest common prefix
        ending in a double newline from each ChangeLog entry, then put that
        common prefix at the top of the commit log.
        (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
        removes, and returns the longest common prefix ending in a double
        newline from a hash of strings

2009-09-11  Eric Seidel  <eric@webkit.org>

        Fix obvious typo in previous commit, no review.

        bugzilla-tool should automate rollouts
        https://bugs.webkit.org/show_bug.cgi?id=26715

        * Scripts/bugzilla-tool: add back missing "scm" argument.

2009-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool should automate rollouts
        https://bugs.webkit.org/show_bug.cgi?id=26715

        bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
        The --complete-rollout option will automatically land and update the bug.
        Eventually --complete-rollout will be default, but that will require more testing.

        This first pass is good enough for others to try and file bugs about.

        * Scripts/bugzilla-tool:
         - Move modified_changelogs into scm.py.
         - Move svn_revision_from_commit_text logic into scm.py.
         - Add RolloutCommit command.
        * Scripts/modules/bugzilla.py:
         - Add reopen_bug command used by RolloutCommit.
        * Scripts/modules/scm.py:
         - Add functions to support RolloutCommit.
         - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
         - Add a str() call so that svn_commit_log can take a numeric argument.
         - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
         - Made dry_run commits return something that svn_revision_from_commit_text can parse.
        * Scripts/modules/scm_unittest.py:
         - Add read_from_path for easy file reading.
         - Put test4 on a new line to make reverts work w/o conflict.
         - Add an "svn update" call so that the checkout revision matches the server revision.
         - Add tests for svn_revision_from_commit_text.
         - Add a simple test for apply_reverse_diff.
         - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
         - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.

2009-09-11  Adam Roben  <aroben@apple.com>

        Get user script/stylesheet tests running on Windows

        Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
        skipped on Windows

        Reviewed by John Sullivan.

        * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
        against comsuppw.lib so we can use _bstr_t.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
        order, added #include of comutil.h for _bstr_t.

        (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
        (LayoutTestController::addUserScript):
        (LayoutTestController::addUserStyleSheet):
        Implemented. Implementations were based on those in
        LayoutTestControllerMac.mm.

2009-09-10  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 

        Reviewed by Mark Rowe.

        * Scripts/run-webkit-tests: Updated to make -h switch show help.

2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add WebCore/websockets directory in wx build system.
        https://bugs.webkit.org/show_bug.cgi?id=28038

        * wx/build/settings.py:

2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>

        [GTK] EventSender does not properly convert some keyDown strings
        https://bugs.webkit.org/show_bug.cgi?id=29119

        Add more keyDown string to character code conversions for GTK+ EventSender.

        * DumpRenderTree/gtk/EventSender.cpp:
        (keyDownCallback):

2009-09-09  Steve Block  <steveblock@google.com>

        Reviewed by Maciej Stachowiak.

        Geolocation Coordinates::toString() prints bogus values for unspecified properties.
        https://bugs.webkit.org/show_bug.cgi?id=29080

        * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.

2009-09-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Eric Carlson.

        reviewer/committer lookups are backwards
        https://bugs.webkit.org/show_bug.cgi?id=29113

        I also moved Eric Carlson from the committer list to the reviewer list now that he is one.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/committers.py:

2009-09-09  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        svn-unapply doesn't revert directories correctly
        https://bugs.webkit.org/show_bug.cgi?id=29065

        * Scripts/svn-unapply: Make svnStatus consistently return status
        lines including a newline.
        * Scripts/svn-apply: Keep svnStatus in sync with the one in
        svn-unapply, in lieu of moving it to a common file.

2009-09-09  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        svn-apply doesn't handle changes to files copied to new directories properly
        https://bugs.webkit.org/show_bug.cgi?id=29059

        * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
        additions if we know that we've just copied a file to this name.

2009-09-09  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        commit-queue hangs if a builder has never built
        https://bugs.webkit.org/show_bug.cgi?id=29091

        * Scripts/modules/buildbot.py:
        * Scripts/modules/buildbot_unittest.py:

2009-09-09  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] DumpRenderTree needs eventSender object and implementation
        https://bugs.webkit.org/show_bug.cgi?id=25990

        Implements most of the EventSender object's functionality for
        the DumpRenderTree tool. Implementation still lacks support
        for drag and drop tests and forward leaps.

        Based on work by Holger Hans Peter Freyther.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (runTest): Focus on the view before loading a new test.
        (webViewWindowObjectCleared):
        * DumpRenderTree/gtk/EventSender.cpp: Added.
        (getDragModeCallback):
        (setDragModeCallback):
        (leapForwardCallback):
        (contextClickCallback):
        (updateClickCount):
        (mouseDownCallback):
        (mouseUpCallback):
        (mouseMoveToCallback):
        (beginDragWithFilesCallback):
        (replaySavedEvents):
        (keyDownCallback):
        (textZoomInCallback):
        (textZoomOutCallback):
        (zoomPageInCallback):
        (zoomPageOutCallback):
        (getClass):
        (makeEventSender):
        * DumpRenderTree/gtk/EventSender.h: Added.
        * GNUmakefile.am: Add build rules for EventSender.

2009-09-09  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Roben.
        
        https://bugs.webkit.org/show_bug.cgi?id=28953

        Added pre- and post- build events so that on build failure, the file 
        buildfailed is written to the directory $(WebKitOutputDir).

        * WinLauncher/WinLauncher.vcproj:

2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

2009-09-08  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        commit-queue gets stuck if a non-committer sets commit-queue+ or review+
        https://bugs.webkit.org/show_bug.cgi?id=28605
        https://bugs.webkit.org/show_bug.cgi?id=28916

        * Scripts/bugzilla-tool:
         - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
           comment now that it's used for rejecting patches for invalid committers too.
         - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
         - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
        * Scripts/modules/bugzilla.py:
         - Make _parse_attachment_element not validate reviewer/committer.
         - Share flag parsing code in _parse_attachment_flag.
         - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
         - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
         - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
        * Scripts/modules/bugzilla_unittest.py:
         - Update this test to no longer expect committer/reviewer validation.
        * Scripts/modules/committers.py:
         - Return None on failed lookups instead of raising Exceptions.
        * Scripts/modules/committers_unittest.py:
         - Update tests to expect None returns instead of exceptions.

2009-09-09  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()

        Reviewed by Mark Rowe.

        No change to layout test results.

        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::clickPointY): Changed to return y value
        instead of x value.

2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Mark Rowe.

        Reduce dglazkov's boboiness by properly concatenating revision value.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
            rather than "+".

2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>

        wxWebKit Python extension build fix - get swig.py if it doesn't exist.

        * wx/build/build_utils.py:

2009-09-08  Mark Rowe  <mrowe@apple.com>

        Fix an incorrect variable name in UpdateChromiumSource.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

2009-09-08  Mark Rowe  <mrowe@apple.com>

        Don't check for leaks on the release SnowLeopard builder.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

2009-09-08  Mark Rowe  <mrowe@apple.com>

        Add a SnowLeopard release builder.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

2009-09-08  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Remove end of line whitespace check from check-webkit-style.
        https://bugs.webkit.org/show_bug.cgi?id=29053

        * Scripts/modules/cpp_style.py:

2009-09-08  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Darin Adler.

        Fix DumpRenderTree build from clean tree on Tiger
        https://bugs.webkit.org/show_bug.cgi?id=28927

        * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
        DerivedSources/DumpRenderTree directory exists when
        building on Tiger.

2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix after introduction of platform/mock directory.

        * wx/build/settings.py:

2009-09-08  Yael Aharon  <yael.aharon@nokia.com>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

2009-09-08  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Darin Adler.

        prepare-ChangeLog too chatty on file additions
        https://bugs.webkit.org/show_bug.cgi?id=29019

        * Scripts/prepare-ChangeLog: Omit description of added properties
        on newly added files.

2009-09-08  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Adds a LayoutTestController method to set the permission state for Geolocation.
        This is required to use the mock Geolocation service for testing.
        https://bugs.webkit.org/show_bug.cgi?id=29027

        * DumpRenderTree/LayoutTestController.cpp: Modified.
        (setDatabaseQuotaCallback): Modified. Style fix.
        (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
        (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
        * DumpRenderTree/LayoutTestController.h: Modified.
        (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
        (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
        (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
        * DumpRenderTree/mac/UIDelegate.mm: Modified.
        (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.

2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] QtWebKit single API to enable persistency
        https://bugs.webkit.org/show_bug.cgi?id=28682

        Use the new enablePersistentStorage API instead 
        of enabling all persistent features one-by-one.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::DumpRenderTree::DumpRenderTree):

2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Tor Arne Vestbø.

        Refactor --strict switch to --ignore-metrics and correct the
        implementation to make the feature usable on all platforms.
        https://bugs.webkit.org/show_bug.cgi?id=28907

        run-webkit-tests --ignore-metrics strips the font related metrics from
        the actual and expected data before comparing them.
        In this way the render trees can be checked for obvious differences but
        a successful test implies by no means that the layout is actually correct.

        * Scripts/run-webkit-tests:

2009-09-07  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Adds a mock Geolocation service. This will be used to provide predictable behavior of the
        Geolocation API for use in LayoutTests. Later changes will integrate the the mock
        Geolocation service with DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=28264

        * DumpRenderTree/LayoutTestController.cpp: Modified.
        (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
        (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
        (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
        * DumpRenderTree/LayoutTestController.h: Modified.
        * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
        (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
        (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.

2009-09-07  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        Enable SHARED_WORKERS by default
        https://bugs.webkit.org/show_bug.cgi?id=28959

        * Scripts/build-webkit:

2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fixes for wx SVN trunk.

        * wx/build/settings.py:

2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix. Switch USE_ defines over to the compiler so that they can be
        checked by files not including config.h (like WebCorePrefix.h).

        * wx/build/settings.py:

2009-09-04  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.

        Update declaration of FrameLoadDelegate to reflect that
        IWebFrameLoadDelegatePrivate2 inherits from
        IWebFrameLoadDelegatePrivate.

        * DumpRenderTree/win/FrameLoadDelegate.h:

2009-09-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24696

        Add testing instrumentation for mixed content.

        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate webView:]):
        (-[FrameLoadDelegate webView:didRunInsecureContent:]):
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (descriptionSuitableForTestResult):
        (FrameLoadDelegate::QueryInterface):
        (FrameLoadDelegate::didDisplayInsecureContent):
        (FrameLoadDelegate::didRunInsecureContent):
        * DumpRenderTree/win/FrameLoadDelegate.h:

2009-09-03  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Kevin Ollivier.

        [wx] Frames support
        https://bugs.webkit.org/show_bug.cgi?id=19041

        * wx/build-wxwebkit:

2009-09-02  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28880> svn-apply --force doesn't actually work

        Reviewed by Eric Seidel.

        This fixes "svn-apply --force" and adds unit tests for the
        scm.apply_patch() method which uses this script.

        * Scripts/svn-apply: Created $globalExitCode variable that
        defaults to 0.  Exit with a value of $globalExitCode when the
        script is finished.
        (applyPatch): Ignore a non-zero $exitCode if $force is true, but
        set $globalExitCode to $exitCode so that svn-apply exits with a
        non-zero status if any patches did not apply cleanly.  Also
        print out the actual patch command if $force was not true.

        * Scripts/modules/scm.py:
        (scripts_directory): Added.  Extracted from script_path().
        (script_path): Extracted scripts_directory().
        * Scripts/modules/scm_unittest.py: Import urllib.
        (SVNTestRepository.setup): Save the original working directory
        in test_object since this represents the WebKit repository from
        where the unit tests are run.
        (SCMTest): Created new super class to hold utility methods.
        (SCMTest._create_patch): Creates a patch file on disk and a
        dictionary for use with scm.svn_apply().
        (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
        back to WebKitTools/Scripts in the test repository so that
        scm.apply_patch() is able to find the svn-apply script.
        (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
        (SVNTest.tearDown): Make sure to change directories back to the
        original_path before the next test.
        (SVNTest.test_apply_svn_patch): New test case for applying an
        svn patch with scm.apply_patch().
        (SVNTest.test_apply_svn_patch_force): New test case for applying
        an svn patch with scm.apply_patch() that conflicts.
        (GitTest): Inherit from SCMTest instead of unittest.TestCase.
        (GitTest.tearDown): Make sure to change directories back to the
        original_path before the next test.
        (GitTest.test_apply_git_patch): New test case for applying a git
        patch with scm.apply_patch().
        (GitTest.test_apply_git_patch_force): New test case for applying
        a git patch with scm.apply_patch() that conflicts.

2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Mark Rowe.

        [Qt] Add support for platform-spesific layout-test results

        For the Qt port we use the qt-[mac|linux|win] directories and then fall
        back to the generic qt directory for both test results and skipped list.

        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

2009-09-02  Laurent Cerveau  <lcerveau@me.com>

        Reviewed by David Kilzer.

        <http://webkit.org/b/25517> build-webkit script should print build time at end

        * Scripts/build-webkit:
        Added startTime and endTime variable so that the build time is computed and printed as
        part of the build message; display formatting has been separated in a dedicated subroutine.

2009-09-02  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root

        Reviewed by Eric Seidel.

        * Scripts/VCSUtils.pm:
        (determineSvnRoot): Added back check for repository root that
        was removed in r46134 when this code lived in svn-create-patch.
        It's necessary to check both the repository root and the
        repository UUID in case two different working directories are
        checked out from the same repository.

2009-09-02  Timothy Hatcher  <timothy@apple.com>

        Use new 512x512 icons for nightly builds.

        Rubber-stamped by Mark Rowe.

        * WebKitLauncher/webkit.icns:

2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>

        waf build fix. Remove local variable shadowing global.

        * wx/build/settings.py:

2009-09-02  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by David Kilzer.

        Calls exitStatus function from the main package where it is also defined.

        * Scripts/VCSUtils.pm:

2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>

        waf build fixes for Windows/MSVC and Mac/Snow Leopard.

        * wx/browser/wscript:
        * wx/build/build_utils.py:
        * wx/build/settings.py:

2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>

        Reviewed by Eric Seidel.

        Changes needed for build-webkit to support the waf build system for the wx port.
        
        https://bugs.webkit.org/show_bug.cgi?id=27619

        * Scripts/build-webkit:
        * Scripts/run-launcher:
        * Scripts/webkitdirs.pm:

2009-09-02  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts

        Reviewed by Eric Seidel.

        * Scripts/update-webkit: Added "--accept postpone" to
        @svnOptions when running with svn-1.6 or newer.

2009-09-02  David Kilzer  <ddkilzer@apple.com>

        Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()

        Reviewed by Eric Seidel.

        * Scripts/VCSUtils.pm:
        (@EXPORT): Added &isSVNVersion16OrNewer.
        (svnVersion): Added.  Internal method that gets the SVN version
        and caches it.
        (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
        version check.
        * Scripts/prepare-ChangeLog: Switched to use new
        isSVNVersion16OrNewer() method.
        * Scripts/resolve-ChangeLogs: Ditto.
        * Scripts/svn-create-patch: Ditto.

2009-09-02  David Kilzer  <ddkilzer@apple.com>

        Clean up VCSUtils.pm

        Reviewed by Eric Seidel.

        * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
        indentation of BEGIN block.  Listed each exported method on a
        line by itself.  Added methods to the export list after adding
        the package statement.  Sorted module variables.  Moved
        definiton of $gitRoot next to other module variables.

2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Fix layout-test plugins/plugin-javascript-access.html

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        js tests should move into jstests subdirectory instead of resources/
        https://bugs.webkit.org/show_bug.cgi?id=25880

        make-script-wrappers supports both resources and script-tests directories.
        run-webkit-tests ignores files in script-tests.
        Move script tests of animations to check the new script is working.

        * Scripts/make-script-test-wrappers:
        * Scripts/run-webkit-tests:

2009-09-02  Szabo Carol  <carol.szabo@nokia.com>

        Reviewed by David Levin.

        check-webkit-style uses python from /usr/bin instead of the PATH
        https://bugs.webkit.org/show_bug.cgi?id=28225

        * Scripts/bugzilla-tool:
        * Scripts/check-webkit-style:
        * Scripts/run-webkit-unittests:
        * Scripts/update-sources-list.py:
          Changed the first line from
          #!/usr/bin/python
          to
          #!/usr/bin/env python
          which causes python to be invoked from the path location returned
          by "which python" when any of these scripts are launched.
          these are currently all the python scripts in WebKitTools/Scripts.

2009-09-01  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards

        Reviewed by Adam Barth.

        * Scripts/modules/scm.py:
        (Git.commit_ids_from_commitish_arguments): Reverse the list of
        commits returned from git-rev-list since we always want to post
        the oldest patches first to bugs.webkit.org.
        * Scripts/modules/scm_unittest.py:
        (run): Added return statement to return the output now that we
        want it sometimes.
        (SVNTestRepository._setup_test_commits): Added a fourth commit
        so the GitTest.test_commitish_order() test has more commits to
        work with.
        (GitTest.test_commitish_order): Added unit test for change to
        Git.commit_ids_from_commitish_arguments() in scm.py.

2009-09-01  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed

        Reviewed by David Levin.

        The mark-fixed subcommand is for those times when you don't use
        bugzilla-tool to commit a patch, but you want to use it to close
        the bug with a committed-revision message.

        * Scripts/bugzilla-tool:
        (bug_comment_from_svn_revision): Added.  Extracted from
        bug_comment_from_commit_text().
        (bug_comment_from_commit_text): Extracted
        bug_comment_from_svn_revision() from this method.
        (MarkBugFixed.__init__): Added.
        (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
        log from the last commit if no svn revision is specified, else
        the commit log for the specified svn revision.
        (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
        Attempts to determine the bug id and svn revision if one or both
        were not defined on the command line.
        (MarkBugFixed.execute): Added.  Adds a comment about the
        revision that fixed the bug and closes the bug.
        (BugzillaTool.__init__): Added mark-fixed subcommand.
        * Scripts/modules/bugzilla.py:
        (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
        bug given a bug id.
        * Scripts/modules/scm.py:
        (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
        the leading 'r' from an svn revision.
        (SCM.svn_commit_log): Added.  Subclasses must override.
        (SCM.last_svn_commit_log): Added.  Subclasses must override.
        (SVN.svn_commit_log): Added.  Returns svn log for a given
        revision.
        (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
        last commit in an svn working directory and then runs svn log.
        (Git.svn_commit_log): Added.  Returns svn log for a given
        revision.
        (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
        of one log message.

2009-09-01  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28880> svn-apply --force doesn't actually work

        Reviewed by Brady Eidson.

        * Scripts/svn-apply:
        (applyPatch): Add "--force" to $options arrayref if $force is
        set.

2009-09-01  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch

        Reviewed by Adam Roben.

        When git-filter-branch has been invoked to rewrite ChangeLog
        files on series of git commits, it changes directories into
        .git-rewrite/t before re-running resolve-ChangeLogs.  This
        causes determineVCSRoot() in VCSUtils.pm to return
        ".git-rewrite/t", which causes that path to be prepended to all
        ChangeLog paths, which results in an error like this:

            error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
            Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.

        The correct way to fix this is not to try to find the repository
        root when invoked by git-filter-branch.

        * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
        set $relativePath to '.' instead of calling
        chdirReturningRelativePath(determineVCSRoot()).
        (isInGitFilterBranch): Added.  Checks for the existence of the
        MAPPED_PREVIOUS_COMMIT environment variable.

2009-09-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Add support for Fedora distros in the http tests
        https://bugs.webkit.org/show_bug.cgi?id=28263

        Add detection code for Fedora distribution, and use the proper
        httpd conf file when needed.

        * Scripts/run-webkit-httpd:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Eric Seidel.

        [Gtk] DRT needs implementation of overridePreference
        https://bugs.webkit.org/show_bug.cgi?id=28830

        Implement overridePreference.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        (setDefaultsToConsistentStateValuesForTesting):
        (runTest):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (toWebSettingKey):
        (LayoutTestController::overridePreference):

2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>

        <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying

        Reviewed by Eric Seidel.

        Jump back and forth between the repository root directory (to apply) and the
        directory the script was run from (to find the patch).

        * Scripts/svn-apply:
        * Scripts/svn-unapply:

2009-08-31  Adam Roben  <aroben@apple.com>

        Fall back to a Release version of Safari if a Debug one doesn't exist

        <http://webkit.org/b/28849>

        Reviewed by Sam Weinig.

        * Scripts/webkitdirs.pm:
        (safariPath): If the user is working with a Debug build, but there's
        no Debug version of Safari present, fall back to using a Release
        version of Safari.

2009-08-31  Adam Roben  <aroben@apple.com>

        Make safariPath() work for Debug builds of Safari on Windows

        <http://webkit.org/b/28849>

        Reviewed by Sam Weinig.

        * Scripts/webkitdirs.pm:
        (safariPath): If the user is working with a Debug build, add the
        _debug suffix to Safari.exe.

2009-08-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue needs a master process
        https://bugs.webkit.org/show_bug.cgi?id=28040

        Add a bugzilla-tool commit-queue command
        Keeps per-bug logs, but doesn't yet upload them anywhere.

        * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
        * Scripts/modules/buildbot.py: remove noisy log message
        * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python

2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        [GTK] Geolocation needs permission API before being enabled by default

        Build the Gtk port with geolocation enabled. This option is only
        enabled for the buildbot. The autotools option will be enabled by
        default once the permissions API is implemented.

        * Scripts/build-webkit:

2009-08-26  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by David Kilzer.

        Make prepare-ChangeLog notice property changes
        https://bugs.webkit.org/show_bug.cgi?id=28675

        Make the generated ChangeLog entry include a short description of
        property changes if there were such changes.  Also make
        prepare-ChangeLog not bail if the only changes are property changes.

        * Scripts/prepare-ChangeLog:

2009-08-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Oliver Hunt.

        Don't let local files access web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28480

        A bunch of our LayoutTests rely on our old behavior, so we explicitly
        grant local files universal access during testing.  Mainly, these tests
        involve making XMLHttpRequests for data URLs.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

2009-08-26  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Minor style correction and include fix for notifications
        https://bugs.webkit.org/show_bug.cgi?id=28745

        * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
          change to correct EnumStyle
        (DRTDesktopNotificationPresenter::checkNotificationPermission):

2009-08-26  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        XMLHttpRequest.withCredentials=false shouldn't save cookies.
        https://bugs.webkit.org/show_bug.cgi?id=28743

        Added the support to the layout test controller on OSX and
        Windows (for CFNETWORK) to allow for changing the accept cookie
        policy.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController): Added a bool
        to track the state of accepting cookies.
        (setAlwaysAcceptCookiesCallback): Standard wrapper method
        to go from js to a C++ method.
        (LayoutTestController::staticFunctions): Added the
        setAlwaysAcceptCookies method to the js layoutTestController.
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::alwaysAcceptCookies): Returns the value.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues): Reset the accept cookie to
        its default.
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setAlwaysAcceptCookies): Does the work for
        OSX to change the cookie accept policy.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (setAlwaysAcceptCookies): Method to handle all the calls necessary
        to change the accept cookie policy on Windows.
        (resetDefaultsToConsistentValues): Reset the accept cookie to
        its default.
        * DumpRenderTree/win/DumpRenderTreeWin.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setAlwaysAcceptCookies): Stub out method.

2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed.

        Remove accidentally left in clobber option.
        https://bugs.webkit.org/show_bug.cgi?id=28400

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.

2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Mark Rowe.

        Add canary-style Chromium WebKit build slave to the waterfall.
        https://bugs.webkit.org/show_bug.cgi?id=28400

        * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.

2009-08-25  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Darin Adler.

        make-script-test-wrappers should be executable
        https://bugs.webkit.org/show_bug.cgi?id=28669

        Make make-script-test-wrappers and update-sources-list.py both be
        executable.

        * Scripts/update-sources-list.py:
        * Scripts/make-script-test-wrappers:

2009-08-25  Brent Fulgham  <bfulgham@webkit.org>

        Build fix

        Revise Debug_Cairo targets to point inherit from the 
        debug_wincairo.vsprops property sheet so that they link
        against the proper libraries in Debug build.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        * WinLauncher/WinLauncher.vcproj:

2009-08-25  David Levin  <levin@chromium.org>

        Reviewed by Adam Roben.

        PLATFORM(CFNETWORK) should be USE(CFNETWORK).
        https://bugs.webkit.org/show_bug.cgi?id=28713

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main):

2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt/Mac] Use CONFIG+=build_all only when building libraries

        If no configuration is specified when building WebKit we pass the
        debug_and_release option to QMake which results in Makefiles for
        both configurations being generated.

        Previously we built both of these configurations by default, for
        all targets (both the QtWebKit framework/dyldlib and the various
        executables such as QtLauncher and tests). This makes sense for
        the libraries, which get the _debug suffix and can be loaded on
        demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
        ended up building the same executable twice.

        We now only build one instance of each executable, and since this
        is a developer build we build the debug-version. Passing either
        --debug or --release to build-webkit will override this, and
        even in the default case the release version can still be built
        by running 'make release' in the the build directory of each
        target.

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
        * Scripts/webkitdirs.pm:

2009-08-24  Hironori Bono  <hbono@chromium.org>

        Reviewed by Adam Barth.

        Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
        <https://bugs.webkit.org/show_bug.cgi?id=27827>.

        Because of the lack of mappings from GDK key-codes to WebKit key-codes,
        Chromium cannot send valid key-codes to JavaScript when a user types
        function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

        To write layout tests for this issue, added mappings from function-key
        names to platform-specific key-codes to EventSendingController objects
        so that eventSender.keyDown() can send function-key events without using
        platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
        is only for Mac. So this change adds this new test to Skipped tests for other
        platforms to prevent this change from crashing the build trees.)

        * DumpRenderTree/mac/EventSendingController.mm:
        (-[EventSendingController keyDown:withModifiers:]):

2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] API for disabling local file access to web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28663

        Enable this setting for DRT.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):

2009-08-22  Adam Barth  <abarth@webkit.org>

        Revert 47684.  We're going to do this later once clients have had a
        chance to opt into the setting they like.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

2009-08-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't let local files access web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28480

        A bunch of our LayoutTests rely on our old behavior, so we explicitly
        grant local files universal access during testing.  Mainly, these tests
        involve making XMLHttpRequests for data URLs.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

2009-08-22  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Anders Carlsson.

        Bring signed updates to the Mac nightly builds.

        * WebKitLauncher/Info.plist:
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
        * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
        (initializeSparkle):
        * WebKitLauncher/nightly.webkit.org.public.pem: Added.

2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubberstamped by Simon Fraser.

        Remove GNOME keyring support in build-webkit. This dependency's
        already been removed in the Gtk port.

        * Scripts/build-webkit:

2009-08-20  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.
        Based on original patch by Stephanie Lewis.

        Added support of the Windows malloc history format to parse-malloc history, so we can
        read and parse it.

        * Scripts/parse-malloc-history:

2009-08-20  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Enable various "grouping" ARIA roles
        https://bugs.webkit.org/show_bug.cgi?id=28486

        Expose the ability to retrieve the subrole through accessibility for DRT.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:

2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed.

        Added myself as a committer.

        * Scripts/modules/committers.py:

2009-08-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Fix memory leaks.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::whiteListAccessFromOrigin):
        (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
        (LayoutTestController::pauseTransitionAtTimeOnElementWithId):

2009-08-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool post-diff can post partial diffs from SVN checkouts.
        https://bugs.webkit.org/show_bug.cgi?id=28445

        Pass the checkout root as the cwd.  Also wrote a test to ensure this.

        * Scripts/modules/scm.py:
        * Scripts/modules/scm_unittest.py:

2009-08-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adele Peterson.

        Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (attributeValueCallback):

2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed, build fix.

        [Qt] The template-based qMax() compares two qreals.

        * DumpRenderTree/qt/ImageDiff.cpp:
        (main):

2009-08-20  David Levin  <levin@chromium.org>

        Reviewed by David Kilzer.

        bugzilla-tool patch retrieval should handle 302 redirects.
        https://bugs.webkit.org/show_bug.cgi?id=28485

        * Scripts/modules/scm.py: Pass the --location parameter to curl
        so that 302's are followed.

2009-08-20  Aaron Boodman  <aa@chromium.org>

        One more speculative build for gtk.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

2009-08-20  Aaron Boodman  <aa@chromium.org>

        Speculative build for gtk.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::whiteListAccessFromOrigin):

2009-08-20  Mark Rowe  <mrowe@apple.com>

        Ignore some leaks that are known to originate from ImageIO.

        * Scripts/run-webkit-tests:

2009-08-20  Aaron Boodman  <aa@chromium.org>

        With David Levin.

        Speculative build fix for qt.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::whiteListAccessFromOrigin):
        * DumpRenderTree/qt/jsobjects.h:

2009-08-19  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot

        Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.

        * Scripts/check-for-global-initializers:

2009-08-19  Aaron Boodman  <aa@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
        specify a more granular policy for cross-origin XHR access.

        * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
        (whiteListAccessFromOriginCallback): Ditto.
        (LayoutTestController::staticFunctions): Ditto.
        * DumpRenderTree/LayoutTestController.h: Ditto.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
        (LayoutTestController::whiteListAccessToOrigin): Ditto.
        * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
        (LayoutTestController::whiteListAccessFromOrigin): Ditto.
        * DumpRenderTree/qt/jsobjects.cpp: Ditto.
        (LayoutTestController::whiteListAccessFromOrigin): Ditto.
        * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
        (LayoutTestController::whiteListAccessFromOrigin): Ditto.
        * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
        (resetWebViewToConsistentStateBeforeTesting): Ditto.
        * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
        (resetWebViewToConsistentStateBeforeTesting): Ditto.
        * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.

2009-08-19  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Dan Bernstein.

        Ignore some leaks that are known to originate from QTKit.

        * Scripts/run-webkit-tests:

2009-08-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue/bugzilla-tool can get wedged if git is mid-rebase
        https://bugs.webkit.org/show_bug.cgi?id=28436

        Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
        This code will only ever be run when --force-clean is passed.

        I also added a new unit test to make sure this code actually works. :)

        * Scripts/modules/scm.py:
        * Scripts/modules/scm_unittest.py:

2009-08-19  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        WebKit needs a changelogs.py to hold changelog-related code
        https://bugs.webkit.org/show_bug.cgi?id=28477

        This is moving code and adding tests.  There was only one functional
        change (which was removing a trailing newline from the last_entry() result).

        * Scripts/bugzilla-tool:
        * Scripts/modules/changelogs.py: Added.
        * Scripts/modules/changelogs_unittest.py: Added.
        * Scripts/run-webkit-unittests:

2009-08-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
        https://bugs.webkit.org/show_bug.cgi?id=28222

        Basic support for now.  This has been in testing for 24 hours now and worked great!

        * Scripts/bugzilla-tool:
        * Scripts/modules/buildbot.py: Added.
        * Scripts/modules/buildbot_unittest.py: Added.
        * Scripts/run-webkit-unittests:

2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
        default timeout used by run-webkit-tests. Mac and Win ports were
        recently bumped in http://trac.webkit.org/changeset/r47465.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setWaitToDump):

2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>

        DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger

        Reviewed by Mark Rowe.

        Provide pre-generated swig source files for Tiger so it may
        benefit from the faster run-webkit-tests.

        * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
        Generated by swig.
        * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
        Generated by swig.
        (swig_type_info::SWIG_TypeNameComp):
        (swig_type_info::SWIG_TypeEquiv):
        (swig_type_info::SWIG_TypeRegisterTL):
        (swig_type_info::SWIG_TypeCheck):
        (swig_type_info::SWIG_TypeCast):
        (swig_type_info::SWIG_TypeDynamicCast):
        (swig_type_info::SWIG_TypeName):
        (swig_type_info::SWIG_TypePrettyName):
        (swig_type_info::SWIG_TypeQueryTL):
        (swig_type_info::SWIG_TypeClientDataTL):
        (swig_type_info::SWIG_PackData):
        (swig_type_info::SWIG_UnpackData):
        (swig_type_info::SWIG_PropagateClientDataTL):
        (swig_type_info::SWIG_PackVoidPtr):
        (swig_type_info::SWIG_UnpackVoidPtr):
        (swig_type_info::SWIG_PackDataName):
        (swig_type_info::SWIG_UnpackDataName):
        * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
        Tiger using pre-generated files.

2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Kilzer.

        run-webkit-tests hangs when WebCore tries to log too much
        https://bugs.webkit.org/show_bug.cgi?id=15743

        Read stdout and stderr in parallel.

        * Scripts/run-webkit-tests:

2009-08-18  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Oliver Hunt.

        Add a new build configuration that checks for leaks during the layout tests,
        and hook a new machine up to it.

        * BuildSlaveSupport/build.webkit.org-config/config.json:
        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

2009-08-18  Aaron Boodman  <aa@chromium.org>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.

        No new tests: Already covered by existing tests.

        * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.

2009-08-18  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Geoff Garen.

        Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:

2009-08-18  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.

        Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
        and removed include to fix building on VC++ Express.

        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::exceededDatabaseQuota):

2009-08-18  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Oliver Hunt.

        Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 
        LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
        
        Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
        Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setDatabaseQuota):
        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::exceededDatabaseQuota):

2009-08-18  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=28415
        Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
        have it.

        * record-memory-win/record-memory-win.vcproj:
        * WinLauncher/WinLauncher.vcproj:
        * WebKitLauncherWin/WebKitLauncherWin.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * FindSafari/FindSafari.vcproj:

2009-08-18  Drew Wilson  <atwilson@google.com>

        Reviewed by Eric Seidel.

        Need to extend DumpRenderTree to expose number of worker threads
        https://bugs.webkit.org/show_bug.cgi?id=28292

        Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.

        * DumpRenderTree/LayoutTestController.cpp:
        (getWorkerThreadCountCallback):
        (LayoutTestController::staticValues):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::workerThreadCount):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::workerThreadCount):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::workerThreadCount):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::workerThreadCount):

2009-08-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Initialize x and y in the GtkAllocation structure to shut up
        valgrind.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (runTest):

2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Some HTMLs are modified by make-script-test-wrappers
        https://bugs.webkit.org/show_bug.cgi?id=28213

        Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
        the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
        re-generated wml/* and Geolocation/* .

        * Scripts/make-script-test-wrappers:

2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        -webkit-box-orient:horizontal doesn't work on <button> tag
        https://bugs.webkit.org/show_bug.cgi?id=34445

        Make a flexible button's anonymous child flexible and pass the
        parent's box-orient to the anonymous child.

        Also, added a renderName for anonymous flexible boxes.

        * Scripts/make-script-test-wrappers:

2009-08-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        Can no longer --reset-results of a layout test directory
        https://bugs.webkit.org/show_bug.cgi?id=28336

        --reset-results and --exit-after-n-failures are incompatible.

        * Scripts/run-webkit-tests:

2009-08-17  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git

        Reviewed by Adam Roben.

        New commit message:
            Committed r12345: <http://trac.webkit.org/changeset/12345>

        * Scripts/bugzilla-tool:
        (bug_comment_from_commit_text): Print out a compact,
        standardized commit message for both git and svn.

2009-08-17  Peter Kasting  <pkasting@google.com>

        Reviewed by Steve Falkenburg.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Only add Cygwin to the path when it isn't already there.  This avoids
        causing problems for people who purposefully have non-Cygwin versions of
        executables like svn in front of the Cygwin ones in their paths.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

2009-08-17  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()

        Reviewed by David Levin.

        * Scripts/modules/cpp_style.py:
        (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
        (check_max_min_macros): Added.  Returns level 4 error when MAX()
        and MIN() macros are used in header files and C++ source files.
        (check_style): Added call to check_max_min_macros().
        * Scripts/modules/cpp_style_unittest.py: Added unit tests.
        (test_max_macro): Added.
        (test_min_macro): Added.

2009-08-13  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Eric Seidel.

        Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
        and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.

        https://bugs.webkit.org/show_bug.cgi?id=28268

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:

2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Adam Treat.

        Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
        WebKit style guide.

        https://bugs.webkit.org/show_bug.cgi?id=28161

        * DumpRenderTree/qt/jsobjects.cpp:
        (findFrameNamed):
        (LoadItem::invoke):
        (LayoutTestController::provisionalLoad):
        (LayoutTestController::timerEvent):
        (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
        (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
        (LayoutTestController::numberOfActiveAnimations):
        (EventSender::keyDown):
        (EventSender::frameUnderMouse):
        (TextInputController::doCommand):

2009-08-16  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements

        Reviewed by David Levin.

        In <http://webkit.org/b/28355#c1>, it was noted that new source
        files use 'using namespace std;' instead of individual
        'using std::foo;' statements.  This adds a level 4 check for
        such statements.

        * Scripts/modules/cpp_style.py:
        (_ERROR_CATEGORIES): Added 'build/using_std'.
        (check_using_std): Added.
        (check_style): Added call to check_using_std().
        * Scripts/modules/cpp_style_unittest.py:
        (WebKitStyleTest.test_using_std): Added unit test.

2009-08-16  David Kilzer  <ddkilzer@apple.com>

        Backed out r47343 which was mistakenly committed

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

2009-08-16  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class

        Reviewed by David Levin.

        The ScriptError class doesn't exist in bugzilla.py, so any
        errors print error messages about ScriptError instead of the
        actual error:

            NameError: global name 'ScriptError' is not defined

        * Scripts/modules/bugzilla.py:
        (BugzillaError): Added class.  Modeled after ScriptError class
        in scm.py.
        (Bugzilla.authenticate): Changed to use BugzillaError instead of
        ScriptError.
        (Bugzilla._check_create_bug_response): Ditto.

2009-08-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        Reviewed by Sam Weinig.

        Added EventSource to the build script (default on).
        https://bugs.webkit.org/show_bug.cgi?id=14997 

        * Scripts/build-webkit:

2009-08-15  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

2009-08-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Fix layout test failures after r47312.

        Reviewed by Cameron Zwarich.

        * DumpRenderTree/AccessibilityController.h:
        Replaced logFocusEvents() with setLogFocusEvents(), which takes a
        boolean argument to turn logging of focus events on or off.
        Added a function to reset the AccessibilityController to a consistent
        state.

        * DumpRenderTree/AccessibilityController.cpp:
        (logFocusEventsCallback):
        Call setLogFocusEvents() to enable logging.
        (AccessibilityController::resetToConsistentState):
        Call setLogFocusEvents() to disable logging.

        * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
        (AccessibilityController::setLogFocusEvents):
        Update stub.

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::setLogFocusEvents):
        Update stub.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        Call the FrameLoadDelegate's resetToConsistentState method.

        * DumpRenderTree/mac/FrameLoadDelegate.h:
        Declare the resetToConsistentState method.

        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate resetToConsistentState]):
        Call the AccessibilityController's resetToConsistentState() function.

        * DumpRenderTree/win/AccessibilityControllerWin.cpp:
        (AccessibilityController::~AccessibilityController):
        Turn off focus event logging when the controller is destroyed.
        (AccessibilityController::setLogFocusEvents):
        If the caller passes false, unhook the focus event, and clear
        m_focusEventHook.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        Call the FrameLoadDelegate's resetToConsistentState function.

        * DumpRenderTree/win/FrameLoadDelegate.h:
        Declare the resetToConsistentState() function.

        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::resetToConsistentState):
        Call the AccessibilityController's resetToConsistentState() function.


2009-08-14  Jon Honeycutt  <jhoneycutt@apple.com>

        Add a mechanism for logging MSAA focus events.

        Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
        nightly (20866)

        https://bugs.webkit.org/show_bug.cgi?id=20866

        Reviewed by Oliver Hunt.

        * DumpRenderTree/AccessibilityController.cpp:
        (logFocusEventsCallback):
        Call the AccessibilityController's logFocusEvents() function.
        (AccessibilityController::getJSClass):
        Add a "logFocusEvents" function to the AccessibilityController's JS
        class definition.

        * DumpRenderTree/AccessibilityController.h:
        On Windows, include windows.h, and add a member variable to hold the
        handle to the event hook for focus events. Add a declaration for a
        function that enables logging of focus events.

        * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
        (AccessibilityController::logFocusEvents):
        Stubbed.

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::logFocusEvents):
        Stubbed.

        * DumpRenderTree/win/AccessibilityControllerWin.cpp:
        (AccessibilityController::AccessibilityController):
        (AccessibilityController::~AccessibilityController):
        If we hooked the focus event, unhook it.
        (logFocusEventProc):
        When we receive a focus event, get the accessible object for the event,
        and log its name to stdout.
        (AccessibilityController::logFocusEvents):
        Setup the focus event hook to listen for events in the current process.

2009-08-14  Eric Seidel  <eric@webkit.org>

        No review.  Fix 5-space indent to be 4-spaces.

        * Scripts/bugzilla-tool:

2009-08-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Public API to configure the storage path for HTML5 localStorage
        https://bugs.webkit.org/show_bug.cgi?id=28036

        Turn on LocalStorage support for Qt DumpRenderTree since
        LocalStorage is now disabled by defult for QtWebkit.

        * DumpRenderTree/qt/DumpRenderTree.cpp: 
        (WebCore::WebPage::WebPage):

2009-08-14  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Do not unref the main webview, it's owned by its parent
        container. Instead destroy the container, which should take care
        of everything (not terribly important since we exit right after
        that, but still).

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (main):

2009-08-13  Eric Seidel  <eric@webkit.org>

        No review, correcting obvious python error seen in the commit queue.

        args can be a string or an array.  Assuming args is always an array results in
        double-spaced text in error logs.

        * Scripts/bugzilla-tool:

2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix. Include stdio.h for using stdout, stderr,
        and fprintf.

        * DumpRenderTree/LayoutTestController.cpp:

2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        rename make-js-test-wrappers to make-script-test-wrappers
        https://bugs.webkit.org/show_bug.cgi?id=28212

        * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.

2009-08-13  Drew Wilson <atwilson@chromium.org>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

2009-08-13  John Sullivan  <sullivan@apple.com>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

2009-08-13  Eric Seidel  <eric@webkit.org>

        Correct spelling error in file name.  No review.

        * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
        * Scripts/run-webkit-unittests:

2009-08-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION(r47175): error running run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=28261

        Fix "Use of uninitialized value in concatenation (.) or string at
        WebKitTools/Scripts/run-webkit-tests line 191." by setting
        $testsPerDumpTool to 1000 by default.

        * Scripts/run-webkit-tests:

2009-08-13  Nate Chapin  <japhet@chromium.org>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

2009-08-13  Brent Fulgham  <bfulgham@webkit.org>

        Unreviewed.

        Add 'Brent Fulgham' to the committers list.

        * Scripts/modules/committers.py:

2009-08-13  Adam Langley  <agl@chromium.org>

        Review not required.

        * Scripts/modules/committers.py:
          Adding myself to this list because Eric told me to.

2009-08-13  Greg Bolsinga  <bolsinga@apple.com>

        Unreviewed.

        Add 'Greg Bolsinga' to the committers list.

        * Scripts/modules/committers.py:

2009-08-13  Adam Roben  <aroben@apple.com>

        Fix off-by-one result comparisons in media tests on Windows Debug
        builds

        media/video-played.html seems always to time out in Windows Debug
        builds. A race condition between media/video-test.js's "hang" timer and
        DumpRenderTree's built-in "watchdog" timer was causing results for
        media/video-played.html to be printed twice, causing all future media
        tests to be compared to the previous test's results.

        The fix is to make the watchdog timer got through the same code path
        as calling notifyDone manually, so that the results will only get
        printed once. A subsequent patch will remove video-test.js's hang
        timer entirely, since it is redundant.

        Fixes <http://webkit.org/b/28265>.

        Reviewed by Mark Rowe.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
        from Gtk/Mac/Win's watchdog timer handlers, but we now call
        notifyDone() instead of dump() so that a subsequent call to
        notifyDone() won't print the results out again.

        * DumpRenderTree/LayoutTestController.h: Added
        waitToDumpWatchdogTimerFired.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (waitToDumpWatchdogFired):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (waitUntilDoneWatchdogFired):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (waitUntilDoneWatchdogFired):
        Changed to call waitToDumpWatchdogTimerFired.

2009-08-13  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed.

        Added 'Eric Carlson' to the committers list.

        * Scripts/modules/committers.py:

2009-08-13  Dirk Schulze  <krit@webkit.org>

        Unreviewed.
        Added 'Dirk Schulze' to the committers list.

        * Scripts/modules/committers.py:

2009-08-13  Adam Roben  <aroben@apple.com>

        Enable running testapi in run-javascriptcore-tests on Windows

        Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run
        testapi on Windows

        Reviewed by Mark Rowe.

        * Scripts/run-javascriptcore-tests: Allow testapi to run if we're in
        the AppleWinWebKit configuration.

2009-08-13  Adam Roben  <aroben@apple.com>

        Re-enable testapi in run-javascriptcore-tests on Mac

        This seems to have been mistakenly disabled in r47089.

        Rubber-stamped by Mark Rowe.

        * Scripts/run-javascriptcore-tests: Removed comment markers that were
        preventing running testapi.

2009-08-12  George Staikos  <george.staikos@torchmobile.com>

        Reviewed by Adam Treat.

        Enable WCSS and XHTML-MP flags for build-webkit.

        * Scripts/build-webkit:

2009-08-12  David Kilzer  <ddkilzer@apple.com>

        run-webkit-tests: document --nthly flag in help message

        Reviewed by Simon Fraser.

        * Scripts/run-webkit-tests: Added --nthly flag to $usage string.
        Also noted that -1|--singly implies --nthly 1.

2009-08-12  Eric Seidel  <eric@webkit.org>

        No review, just fixing mismerged ChangeLogs.

2009-08-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        run-webkit-tests needs a --exit-after-failures=N option
        https://bugs.webkit.org/show_bug.cgi?id=28192

        Added the option and deployed it to bugzilla-tool.

        * Scripts/bugzilla-tool:
        * Scripts/run-webkit-tests:

2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        bugzilla-tool : various improvements for running the commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=28199

        Make run_and_throw_if_fail silence STDERR as well as STDIN.
        I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
        Change a few "print" statements to "log" so they appear in the output.
        Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
        Added a little more logging so that --quiet mode is easier to understand.
        Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
        Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
        Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
        Made curl call (downloading patch files) quieter.

        * Scripts/bugzilla-tool:
        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

2009-08-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Change pattern that strips all trailing whitespace to just remove EOL
        chars (\r, \n), to make it clear that varying EOL chars is the primary
        problem being solved.

        * Scripts/prepare-ChangeLog:
        * Scripts/resolve-ChangeLogs:
        * Scripts/svn-create-patch:
        * Scripts/update-webkit:

2009-08-12  Kevin Ollivier  <kevino@theolliviers.com>

        wx waf build fix, add new directories to the build.

        * wx/build/settings.py:

2009-08-11  Adam Roben  <aroben@apple.com>

        Update DumpRenderTree for IWebUIDelegatePrivate changes

        Reviewed by Dave Hyatt.

        * DumpRenderTree/win/UIDelegate.h: Updated to match
        IWebUIDelegatePrivate.

2009-08-12  Adam Roben  <aroben@apple.com>

        Don't try to seek to the end of stdin on Cygwin

        Doing so seems to always cause an exception (for unknown reasons).

        Fixes <http://webkit.org/b/28159> create-bug throws an exception in
        Cygwin

        Reviewed by Dave Kilzer.

        * Scripts/bugzilla-tool:
        (CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
        generated by calling sys.stdin.seek, since these seem to be generated
        for no good reason on Cygwin.

2009-08-12  Adam Roben  <aroben@apple.com>

        Don't raise an exception when --cc is not passed to create-bug

        Fixes <http://webkit.org/b/28158> create-bug throws an exception if
        --cc is not specified

        Reviewed by Dave Kilzer.

        * Scripts/modules/bugzilla.py:
        (Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
        string was specified. Otherwise we'll generate an exception about the
        "cc" variable not being a string.

2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool : various improvements for running the commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=28199

        Make run_and_throw_if_fail silence STDERR as well as STDIN.
        I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
        Change a few "print" statements to "log" so they appear in the output.
        Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
        Added a little more logging so that --quiet mode is easier to understand.
        Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
        Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
        Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
        Made curl call (downloading patch files) quieter.

        * Scripts/bugzilla-tool:
        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

2009-08-11  Eric Seidel  <eric@webkit.org>

        No review, script regression fix only.

        run-webkit-tests --quiet hangs
        https://bugs.webkit.org/show_bug.cgi?id=28202

        Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
        This was what I came up with after discussions in #perl.

        * Scripts/run-webkit-tests:

2009-08-11  John Gregg  <johnnyg@google.com>

        Reviewed by Maciej Stachowiak.

        Switch DumpRenderTree to contain a WebUIDelegate2, which extends
        WebUIDelegate, so that the notifications tests will still work.
        https://bugs.webkit.org/show_bug.cgi?id=28198

        * DumpRenderTree/win/UIDelegate.h:

2009-08-11  Darin Adler  <darin@apple.com>

        Try to fix GTK build.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::stringForRange): Added.

2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Adam Treat.

        Add processing for string constants used by the tests to trigger
        common actions like up, down, left, right, etc. for the Qt
        implementation of DumpRenderTree.

        Note this allows fast/forms/textarea-arrow-navigation.html to pass
        correctly.

        https://bugs.webkit.org/show_bug.cgi?id=28161

        * DumpRenderTree/qt/jsobjects.cpp:
        (EventSender::keyDown):

2009-08-11  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 28200 - ListMarker should be included as part of the text value to parse
        https://bugs.webkit.org/show_bug.cgi?id=28200

        Add the ability to retrieve a string given a plain NSRange.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (stringForRangeCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::valueDescription):
        (AccessibilityUIElement::stringForRange):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::stringForRange):

2009-08-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by NOBODY (Speculative fix for the layout test failure).

        Fix fast/dom/prototype-inheritance.html
        and fast/dom/prototype-inheritance-2.html
        broken on Windows by http://trac.webkit.org/changeset/47018

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues): enable app cache in Windows DRT.

2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool: Re-factor shared landing logic into helper class to share more code
        https://bugs.webkit.org/show_bug.cgi?id=28193

        Added new WebKitLandingScripts class to hold this shared logic.
        Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core.

        * Scripts/bugzilla-tool:

2009-08-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Adam Treat.

        Fix the current failures on the buildbot.

        As Qt hooks up the maybeDump to loadFinished, we need to make
        sure that calling dump() will not call maybeDump on loadFinished.

        As dump is called my emitting done() which calls dump() and then
        setting m_isLoading to false. So in the case m_isLoading is false,
        do not dump again.

        The current code is confusing, and should be made more clear
        in another commit.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::maybeDump):
        (LayoutTestController::notifyDone):

2009-08-11  John Gregg  <johnnyg@google.com>

        Reviewed by Maciej Stachowiak.

        Add support for desktop notifications API to DumpRenderTree,
        and support for ENABLE_NOTIFICATIONS flag to build-webkit.

        * DumpRenderTree/LayoutTestController.cpp:
        (grantDesktopNotificationPermissionCallback):
        (LayoutTestController::staticFunctions):
        (LayoutTestController::grantDesktopNotificationPermission):
        (LayoutTestController::checkDesktopNotificationPermission):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added.
        (DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter):
        (DRTDesktopNotificationPresenter::QueryInterface):
        (DRTDesktopNotificationPresenter::AddRef):
        (DRTDesktopNotificationPresenter::Release):
        (DRTDesktopNotificationPresenter::showDesktopNotification):
        (DRTDesktopNotificationPresenter::cancelDesktopNotification):
        (DRTDesktopNotificationPresenter::notificationDestroyed):
        (DRTDesktopNotificationPresenter::checkNotificationPermission):
        (DRTDesktopNotificationPresenter::requestNotificationPermission):
        * DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added.
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::UIDelegate):
        (UIDelegate::desktopNotificationsDelegate):
        * DumpRenderTree/win/UIDelegate.h:
        * Scripts/build-webkit:

2009-08-11  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Handle arbitrary line endings when manufacturing patches for additions
        with history.

        * Scripts/svn-create-patch:

2009-08-11  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=28183
        Support VS2008 as well as VS2005 in a few scripts.

        * Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS.
        * Scripts/webkitdirs.pm: Use $VSINSTALLDIR if available instead of hardcoding the VS2005 dir.

2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        run-webkit-tests --quiet should not output build-dumprendertree output
        https://bugs.webkit.org/show_bug.cgi?id=28189

        * Scripts/run-webkit-tests:

2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        Exception in land-patches
        https://bugs.webkit.org/show_bug.cgi?id=27962

        Use ("%s" % object) instead of ("" + object).
        Added unit tests for logging.py.

        * Scripts/modules/logging.py:
        * Scripts/modules/logging_unittest.py: Added.
        * Scripts/run-webkit-unittests:

2009-08-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by NOBODY (Windows layout tests fix).

        Fix for layout tests failures. Need to initialize some preferences early
        because WebView on Windows uses them during create time.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main):

2009-08-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Adam Roben.

        Originally implemented by Glenn Wilson  <gwilson@chromium.org>.

        Added support for overriding default preferences per-test.
        See https://bugs.webkit.org/show_bug.cgi?id=20534

        * DumpRenderTree/LayoutTestController.cpp:
        (overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
        (LayoutTestController::staticFunctions): same.
        * DumpRenderTree/LayoutTestController.h: same.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::overridePreference): added empty overridePreference method.
        * DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.
        (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
        (setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time  DRT starts.
        (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::overridePreference):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
        (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
        (createWebViewAndOffscreenWindow): same.
        (main): same.
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::overridePreference):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::overridePreference):

2009-08-11  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Sam Weinig.

        Added support for DRT to support arguments for eventSender.mouseDown and eventSender.mouseUp for Windows.
        https://bugs.webkit.org/show_bug.cgi?id=28166.
        
        This is a step towards fixing fast/events/mouse-click-events.html on Windows.

        * DumpRenderTree/win/EventSender.cpp:
        (mouseDownCallback):
        (mouseUpCallback):
        (replaySavedEvents):

2009-08-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Build the TestNetscapePlugin on Qt/Mac

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

2009-08-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by NOBODY (build fix).

        Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows
        bots that runs Layout Tests to save "JS disabled" and "default font 24pt"
        preferences permanently. Since these preferences are not initialized explicitly in DRT,
        almost all Layout tests are failing. Attempt to fix by explicit
        initialization of these into defaults (enabled, 16pt) at the beginning of the DRT.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main):  see above.

2009-08-10  Steve Falkenburg  <sfalken@apple.com>

        Windows nightly fix.

        Reviewed by Ada Chan.

        * FindSafari/FindSafari.cpp:
        (_tmain): Copy Safari.dll if it exists.

2009-08-10  David Levin  <levin@chromium.org>

        Reviewed by David Kilzer.

        check-webkit-style doesn't catch braces around single line statements when followed by else.
        https://bugs.webkit.org/show_bug.cgi?id=28164

        * Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when
          checking the no braces for "single lines" rule.
        * Scripts/modules/cpp_style_unittest.py: Added test case.

2009-08-10  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module

        Reviewed by David Levin.

        * Scripts/bugzilla-tool:
        (parse_bug_id): Added.  Moved from CommitMessage.parse_bug_id()
        in scm module.
        * Scripts/modules/scm.py: Removed import of bugzilla module.
        (CommitMessage.parse_bug_id): Deleted.

2009-08-10  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=18599
        Work around apparent bug in abs2rel() with symlinked directories.

        * Scripts/resolve-ChangeLogs:

2009-08-10  Dan Bernstein  <mitz@apple.com>

        Build fix

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):

2009-08-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Fix a bunch of build warnings in TestNetscapePlugin
        
        * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
        * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:

2009-08-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Adam Roben.
        
        Allow TestNetscapePlugIn to fall back to the Carbon event model
        
        Previously the plugin would fail, even though the Carbon event
        model was available. The only way to get the Carbon event model
        was to pass the "forcecarbon" argument in the test markup, but no
        tests were using this.
        
        Now the plugin uses carbon either if it's forced, or if the Cocoa
        event model is not supported.
        
        This helps us run most of the plugin tests on Qt/Mac, which still
        does not support the Cocoa event model.
        
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):

2009-08-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool needs a --quiet option
        https://bugs.webkit.org/show_bug.cgi?id=28060

        A first pass at a --quiet option.  This doesn't do all the excting
        things we might want, but it addresses 80% of the use case.

        * Scripts/bugzilla-tool:

2009-08-08  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Enable accessibility in Gtk DRT
        https://bugs.webkit.org/show_bug.cgi?id=25989

        Add Accessibility support to the GTK DRT.

        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added.
        (AccessibilityController::AccessibilityController):
        (AccessibilityController::~AccessibilityController):
        (AccessibilityController::focusedElement):
        (AccessibilityController::rootElement):
        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added.
        (AccessibilityUIElement::AccessibilityUIElement):
        (AccessibilityUIElement::~AccessibilityUIElement):
        (AccessibilityUIElement::getLinkedUIElements):
        (AccessibilityUIElement::getDocumentLinks):
        (AccessibilityUIElement::getChildren):
        (AccessibilityUIElement::getChildrenWithRange):
        (AccessibilityUIElement::childrenCount):
        (AccessibilityUIElement::elementAtPoint):
        (AccessibilityUIElement::getChildAtIndex):
        (AccessibilityUIElement::allAttributes):
        (AccessibilityUIElement::attributesOfLinkedUIElements):
        (AccessibilityUIElement::attributesOfDocumentLinks):
        (AccessibilityUIElement::titleUIElement):
        (AccessibilityUIElement::parentElement):
        (AccessibilityUIElement::attributesOfChildren):
        (AccessibilityUIElement::parameterizedAttributeNames):
        (AccessibilityUIElement::role):
        (AccessibilityUIElement::title):
        (AccessibilityUIElement::description):
        (AccessibilityUIElement::language):
        (AccessibilityUIElement::x):
        (AccessibilityUIElement::y):
        (AccessibilityUIElement::width):
        (AccessibilityUIElement::height):
        (AccessibilityUIElement::clickPointX):
        (AccessibilityUIElement::clickPointY):
        (AccessibilityUIElement::intValue):
        (AccessibilityUIElement::minValue):
        (AccessibilityUIElement::maxValue):
        (AccessibilityUIElement::valueDescription):
        (AccessibilityUIElement::isEnabled):
        (AccessibilityUIElement::insertionPointLineNumber):
        (AccessibilityUIElement::isActionSupported):
        (AccessibilityUIElement::isRequired):
        (AccessibilityUIElement::attributesOfColumnHeaders):
        (AccessibilityUIElement::attributesOfRowHeaders):
        (AccessibilityUIElement::attributesOfColumns):
        (AccessibilityUIElement::attributesOfRows):
        (AccessibilityUIElement::attributesOfVisibleCells):
        (AccessibilityUIElement::attributesOfHeader):
        (AccessibilityUIElement::indexInTable):
        (AccessibilityUIElement::rowIndexRange):
        (AccessibilityUIElement::columnIndexRange):
        (AccessibilityUIElement::lineForIndex):
        (AccessibilityUIElement::boundsForRange):
        (AccessibilityUIElement::cellForColumnAndRow):
        (AccessibilityUIElement::selectedTextRange):
        (AccessibilityUIElement::setSelectedTextRange):
        (AccessibilityUIElement::attributeValue):
        (AccessibilityUIElement::isAttributeSettable):
        (AccessibilityUIElement::increment):
        (AccessibilityUIElement::decrement):
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewWindowObjectCleared):
        (main):
        * GNUmakefile.am:

2009-08-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Unreviewed Gtk build fix.

        DRT needs internal WTF symbols so we link to libJavaScriptCore.la
        too. Also don't force Gtk to use USE_SYSTEM_MALLOC.

        * GNUmakefile.am:

2009-08-07  Darin Adler  <darin@apple.com>

        * Scripts/commit-log-editor: Fix unchecked access to environment
        variable that may not be there.

2009-08-07  Mark Rowe  <mrowe@apple.com>

        Handle the case where only a single test is missing results.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

2009-08-07  George Wright  <george.wright@torchmobile.com>

        Reviewed by Adam Treat

        Fix DumpRenderTree for the Qt port to always dump the PNG data unless
        the expected and actual hashes match.

        https://bugs.webkit.org/show_bug.cgi?id=28077

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::dump):

2009-08-07  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Eric Seidel.

        commit-log-editor does not produce a git commit log that is git friendly.
        https://bugs.webkit.org/show_bug.cgi?id=27754

        We make sure we end up with:
        - A first paragraph describing the bug. It is eventually prefixed by
        "WebKit: <line>" or "WebCore: <line>". This used to be
        "WebCore:\n\n<line>".
        - The Reviewed By line.
        - An eventual Patch By line if author and committer doesn't match.
        - The rest of the commit.

        * Scripts/commit-log-editor:

2009-08-07  Adam Barth  <abarth@webkit.org>

        Unreviewed.  (Darin Adler indicated he'd prefer if we landed these
        kinds of changes unreviewed, like editing the WebKit Team wiki page.)

        Added Pierre d'Herbemont to list of committers.

        * Scripts/modules/committers.py:

2009-08-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adele Peterson.

        Cannot scroll for box-reflect:right
        https://bugs.webkit.org/show_bug.cgi?id=27979

        Update m_overflowLeft an m_overflowWidth for reflection just like
        m_overflowTop and m_overflowHeight.

        * Scripts/make-js-test-wrappers:  Added regexp to skip box-shadow-overflo
w-scroll.js

2009-08-06  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adam Barth.

        box-shadow's spread is ignored with <table>
        https://bugs.webkit.org/show_bug.cgi?id=28017

        Use RenderStyle::getBoxShadowExtent just like RenderBlock.

        * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js

2009-08-06  Eric Seidel  <eric@webkit.org>

        No review, only changing make-js-test-wrappers.

        Fix make-js-test-wrappers to ignore a few more js tests
        with custom templates.

        * Scripts/make-js-test-wrappers:

2009-08-06  Chris Marrin  <cmarrin@apple.com>

        Reviewed by David Hyatt.

        Added ENABLE_3D_CANVAS flag to build, default to off

        * Scripts/build-webkit:

2009-08-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Win DRT's resource load delegate is missing didReceiveResponse
        https://bugs.webkit.org/show_bug.cgi?id=28033

        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        Added:
        (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
        (FrameLoadDelegate::willPerformClientRedirectToURL):
        (FrameLoadDelegate::didCancelClientRedirectForFrame):

        Minor style cleanup:
        (FrameLoadDelegate::didStartProvisionalLoadForFrame): 
        (FrameLoadDelegate::didReceiveTitle):
        (FrameLoadDelegate::didFinishLoadForFrame):
        (FrameLoadDelegate::willCloseFrame):
        (FrameLoadDelegate::didClearWindowObject):
        * DumpRenderTree/win/FrameLoadDelegate.h:

2009-08-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Win DRT's resource load delegate is missing didReceiveResponse
        https://bugs.webkit.org/show_bug.cgi?id=28033

        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::didReceiveResponse):
        * DumpRenderTree/win/ResourceLoadDelegate.h:

2009-08-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        Add layoutTestController.dumpWillCacheResponse
        https://bugs.webkit.org/show_bug.cgi?id=28010

        willCacheResponse is only interesting for embedders of mainline WebKit on Mac.
        Splitting off a new dumpWillCacheResponse allows a number of existings tests
        to run across platforms.

        The test that was specifically verifying willCacheResponse now calls
        dumpWillCacheResponse.

        * DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse
        (LayoutTestController::LayoutTestController):
        (dumpWillCacheResponseCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::dumpWillCacheResponse):
        (LayoutTestController::setDumpWillCacheResponse):
        * DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse
        instead of dumpResourceLoadCallbacks.
        (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):

2009-08-05  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Add my name to committers.py
        https://bugs.webkit.org/show_bug.cgi?id=28013

        Add my name to committers.py.

        * Scripts/modules/committers.py:

2009-08-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        A minor refactoring of the Qt DRT to be a bit more similar to
        the other DRTs, as well as more understandable.

        Splitting up resetJSObjects into a LayoutTestController->reset()
        plus a new closeRemainingWindows() method.

        Added a resetToConsistentStateBeforeTesting() method to keep
        the code in one place, making it easier to verify that we are
        doing things properly.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        (WebCore::DumpRenderTree::open):
        (WebCore::DumpRenderTree::closeRemainingWindows):
        * DumpRenderTree/qt/DumpRenderTree.h:

2009-08-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        Make the Qt DRT WorkQueue work similarily to the cross platform
        one. This means that all items return true if they started
        loading.

        This change paves the way for unforking the WorkQueue, if we [Qt]
        would like that.

        * DumpRenderTree/qt/WorkQueue.cpp:
        (WorkQueue::processWork):
        * DumpRenderTree/qt/WorkQueue.h:
        * DumpRenderTree/qt/WorkQueueItem.h:
        * DumpRenderTree/qt/jsobjects.cpp:
        (LoadItem::invoke):
        (ReloadItem::invoke):
        (ScriptItem::invoke):
        (BackForwardItem::invoke):
        (LayoutTestController::processWork):
        (LayoutTestController::maybeDump):

2009-08-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        If load of a test fails, don't dump as it will be dumped
        in the preceding test, resulting in a invalid incorrect layout.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::maybeDump):

2009-08-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        Make the Qt DumpRenderTree more similar to the mac one.

        Changes include:
        1) Reset zoom factor before each test
        2) Only dump the backforward list when we got other dump result
        3) When we dump the render tree, and got zero result print out:
           [mainFrame renderTreeAsExternalRepresentation]
           and not:
           [frame renderTreeAsExternalRepresentation]

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::open):
        (WebCore::methodNameStringForFailedTest):
        (WebCore::DumpRenderTree::dump):

2009-08-05  chris fleizach  <cfleizach@apple.com>

        Fix Tiger build breakage.

        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:

2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
        https://bugs.webkit.org/show_bug.cgi?id=27994

        Expose valueDescription for accessibility. 

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (getValueDescriptionCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::valueDescription):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::valueDescription):

2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
        https://bugs.webkit.org/show_bug.cgi?id=28006

        Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig

        * DumpRenderTree/mac/PerlSupport/Makefile:

2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Add pkasting to bugzilla-tool as a committer
        https://bugs.webkit.org/show_bug.cgi?id=28002

        * Scripts/modules/committers.py:

2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27993 - AXSliders are missing required attributes and actions
        https://bugs.webkit.org/show_bug.cgi?id=27993

        Add ability to check if any arbitrary action is supported.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (isActionSupportedCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::isActionSupported):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::isActionSupported):

2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool unit tests need a test harness
        https://bugs.webkit.org/show_bug.cgi?id=27977

        * Scripts/run-webkit-unittests: Added.

2009-08-04  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Gavin "Gavvy" Barraclough.

        Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions
        by listing the DumpRenderTree binary as a dependency.  Xcode has the smarts to rebuild
        DumpRenderTree itself when switching OS versions so this dependency removes the need
        for any smarts in the Makefile.

        * DumpRenderTree/mac/PerlSupport/Makefile:

2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool needs unit tests
        https://bugs.webkit.org/show_bug.cgi?id=26916

        Add some basic unit testing for scm.py.

        * Scripts/modules/scm.py:
        * Scripts/modules/scm_unittest.py: Added.

2009-08-04  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Adam Treat.

        Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking
        to make sure the Skipped entries are not in the $ignoredDirectories array.  Directories commonly included
        are (http, media, compositing, wml, wcss).

        https://bugs.webkit.org/show_bug.cgi?id=27893

        * Scripts/run-webkit-tests:

2009-08-03  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Jon Honeycutt.

        Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
        https://bugs.webkit.org/show_bug.cgi?id=27958

        Exposed isRequired to DumpRenderTree for accessibility.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (getIsRequiredCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::isRequired):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::isRequired):

2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool --commit-queue should validate commit-queue setter is a committer
        https://bugs.webkit.org/show_bug.cgi?id=27974

        With a test!

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/bugzilla_unittest.py:

2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs
        https://bugs.webkit.org/show_bug.cgi?id=27973

        The trailing comma (suppresses newlines) was lost in r46700.

        * Scripts/bugzilla-tool:

2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool has too many fatal errors
        https://bugs.webkit.org/show_bug.cgi?id=27969

        Replace several fatal errors with ScriptError exceptions.

        * Scripts/bugzilla-tool:
        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

2009-08-04  Eric Seidel  <eric@webkit.org>

        No review, ChangeLog fix only.

        Fix a ChangeLog line-spacing disaster caused by:
        https://bugs.webkit.org/show_bug.cgi?id=27973

        Still unsure what the fix for bugzilla-tool will be.

2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool --commit-queue should only land commit-queue+ patches
        https://bugs.webkit.org/show_bug.cgi?id=27970

        commit-queue mode for bugzilla-tool
        https://bugs.webkit.org/show_bug.cgi?id=27918

        Make bugzilla tool smart enough to find the commit-queue+ flags and
        land those patches.
        When we call land-patches with --commit-queue, we should filter the
        patches we land to only those that have the commit-queue+ flag set.
        That way, when we call bugzilla-tool from a main commit queue process,
        we won't land the wrong patches.

        * Scripts/bugzilla-tool:

2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        committer logic should be split out of bugzilla.py into its own module

        https://bugs.webkit.org/show_bug.cgi?id=27972

        I also added unit tests for the functionality I added.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/bugzilla_unittest.py: Added.
        * Scripts/modules/commiters_unittest.py: Added.
        * Scripts/modules/committers.py: Added.

2009-08-03  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Handle any kind of line endings in svn-apply and svn-unapply, instead
        of assuming LF.

        * Scripts/svn-apply:
        * Scripts/svn-unapply:

2009-08-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool land-patches needs --queue mode
        https://bugs.webkit.org/show_bug.cgi?id=27961

        Add a --commit-queue command line option to suppress user interaction.

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

2009-08-03  Mark Rowe  <mrowe@apple.com>

        Build fix.  Add installsrc, installhdrs and install targets.

        * DumpRenderTree/mac/PerlSupport/Makefile:

2009-08-03  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        HTMLInputElement is not controllable by assistive technologies
        https://bugs.webkit.org/show_bug.cgi?id=27941

        Accessibility control of a slider required adding increment() and decrement()
        methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (incrementCallback): New, call UI element increment method.
        (decrementCallback): New, call UI element decrement method.
        (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.

        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper.
        (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.

        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::increment): New, do nothing.
        (AccessibilityUIElement::decrement): New, do nothing.

2009-08-02  David D. Kilzer  <ddkilzer@webkit.org>

        <http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø

        Reviewed by Tor Arne Vestbø.

        * Scripts/bugzilla-tool:
        (set_reviewer_in_changelog): Made sure reviewer is properly
        encoded when calling replace().

2009-08-02  Kevin Ollivier  <kevino@theolliviers.com>

        Reviewed by David Levin.

        Script for building the wxBrowser sample app for wx.
        https://bugs.webkit.org/show_bug.cgi?id=27619

        * wx/browser/wscript: Added.

2009-08-02  Kevin Ollivier  <kevino@theolliviers.com>

        Reviewed by Jan Alonzo.

        Scripts needed for the waf build.
        https://bugs.webkit.org/show_bug.cgi?id=27619

        * wx/build: Added.
        * wx/build/build_utils.py: Added.
        * wx/build/settings.py: Added.
        * wx/build/waf_extensions.py: Added.
        * wx/build/wxpresets.py: Added.

2009-08-01  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        Make pixel test results more consistent across Mac OS X versions

        * DumpRenderTree/cg/ImageDiffCG.cpp:
        (createDifferenceImage): Avoid color correction when rendering the
            images into graphics contexts, so that the actual color values are
            compared, regardless of how the images are tagged.
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (createWebViewAndOffscreenWindow): Set the window’s color space to the
            main screen’s color space, even though the window is off-screen.

2009-08-01  Mark Rowe  <mrowe@apple.com>

        Try again to make the Qt build bot happy.

        * BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created
        directory to prevent 'zip' from failing due to the directory containing no files.

2009-08-01  Mark Rowe  <mrowe@apple.com>

        Try and make the Qt build bot happy.

        * BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates
        no output files at all and thus does not create the layout-test-results directory.

2009-08-01  Mark Rowe  <mrowe@apple.com>

        Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built.

        * Scripts/run-webkit-tests:

2009-08-01  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig and David D. Kilzer.

        Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>.
        Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X

        run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
        in the process of crashing.  We can do the same test more efficiently with a simple call to sysctl.
        I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
        instead.  This speeds up run-webkit-tests by around 8%.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.
        (processIsCrashing):
        * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added.  Tiger does not have the SWIG tool
        that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger.
        * DumpRenderTree/mac/PerlSupport/Makefile: Added.
        * Scripts/run-webkit-tests:

2009-08-01  Mark Rowe  <mrowe@apple.com>

        Reviewed by David D. Kilzer.

        Display the reminder once rather than once per ChangeLog.

        * Scripts/prepare-ChangeLog:

2009-08-01  David Kilzer  <ddkilzer@apple.com>

        resolve-ChangeLogs: add error checking to git ls-files command on close()

        Reviewed by Eric Seidel.

        Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>.

        * Scripts/resolve-ChangeLogs: Added error checking to close()
        after running git ls-files.  Added error checking to all
        system() calls by checking for a non-zero WEXITSTATUS($?).
        Changed "|| die;" expressions to "or die $!;".

2009-08-01  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

        Reviewed by Eric Seidel.

        * Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath()
        and determineVCSRoot() to change directories to the root of the
        project before running the command and to provide a path for
        removeChangeLogArguments() to make sure any ChangeLog arguments
        on the command line are still found.
        (canonicalRelativePath): Added.  Returns a canonical path (e.g.,
        stripping 'dir/../' from the path) relative to the current
        directory.
        (removeChangeLogArguments): Added argument which contains a
        relative path that must be prepended to any ChangeLog arguments.
        Used canonicalRelativePath() and File::Spec->catfile() to
        construct a normalized, relative path to each file.

2009-08-01  David Kilzer  <ddkilzer@apple.com>

        Implement VCSUtils::chdirReturningRelativePath()

        Reviewed by Eric Seidel.

        Step 2 to fix:
        <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

        * Scripts/VCSUtils.pm:
        (VCSUtils::chdirReturningRelativePath): Moved here from
        chdirAndGetDifference() in svn-create-patch.
        * Scripts/svn-create-patch: Switched to use
        chdirReturningRelativePath() instead of chdirAndGetDifference().
        (chdirAndGetDifference): Removed.

2009-08-01  David Kilzer  <ddkilzer@apple.com>

        Implement VCSUtils::determineVCSRoot()

        Reviewed by Eric Seidel.

        Step 1 to fix:
        <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

        * Scripts/VCSUtils.pm: Removed reference to webkitdirs module.
        (VCSUtils::EXPORT): Added &determineVCSRoot.  Realphabetized.
        (VCSUtils::determineGitRoot): Added.  Based on code in
        commit-log-editor.
        (VCSUtils::determineVCSRoot): Implemented using
        determineGitRoot() and determineSVNRoot().
        * Scripts/commit-log-editor: Replaced use of
        topLevelSourceDirectory() with determineVCSRoot().  Resorted
        use statements.
        (topLevelSourceDirectory): Removed.

2009-07-31  Daniel Bates  <dbates@intudata.com>

        Reviewed by Eric Seidel.
        
        https://bugs.webkit.org/show_bug.cgi?id=27757

        Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are 
        defined in both File::Temp and POSIX.
        
        This stops the warnings by preventing the "import" method of File::Temp from being called,
        which would otherwise add these functions into the primary namespace. Note, "use POSIX" 
        will import these functions into the primary namespace anyway. We only need one instance
        of these functions in our namespace (or we get redefinition warnings), so lets use the 
        one's in the POSIX package.
        
        * Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()".
        * Scripts/update-webkit-support-libs: ditto

2009-07-31  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Add a top level build option to control datagrid support
        https://bugs.webkit.org/show_bug.cgi?id=27915

        * Scripts/build-webkit:

2009-07-31  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        check-webkit-style --git-commit has bugs if you select a commit in the past
        https://bugs.webkit.org/show_bug.cgi?id=27908

        * Scripts/check-webkit-style:
        (main): Made the git-commit command only select the first commit
        if a range is given (and print a warning).
        * Scripts/modules/scm.py:
        (SCM::create_patch_from_local_commit):
        (SCM::create_patch_since_local_commit):
        (SCM::commit_locally_with_message):
        (SCM::discard_local_commits):
        Added an error messages in case these aren't overriden.

        (Git::create_patch_since_local_commit):
        Added this command to allow doing a diff of everything after a given commit.

2009-07-31  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Speculative Qt build fix. Not reviewed.

        Add LayoutTestController::disableImageLoading() in jsobjects.h.

        * DumpRenderTree/qt/jsobjects.h:

2009-07-31  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
        Favicons are still loaded when automatic image loading is disabled.

        * DumpRenderTree/LayoutTestController.cpp:
        (disableImageLoadingCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::disableImageLoading):

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::disableImageLoading):

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::disableImageLoading): Stubbed for now.
        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::disableImageLoading): Ditto.

2009-07-30  Eric Seidel  <eric@webkit.org>

        Reviewed by David Kilzer.

        bugzilla-tool post-commits trunk..head errors out
        https://bugs.webkit.org/show_bug.cgi?id=27847

        Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments
        and make it handle the new arguments format proposed in the bug.

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

2009-07-30  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        clean up build-webkit to use less copy/paste code and remove unneeded SVG warning
        https://bugs.webkit.org/show_bug.cgi?id=27857

        * Scripts/build-webkit:

2009-07-31  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5

        Reviewed by Eric Seidel.

        * Scripts/modules/bugzilla.py:
        (Bugzilla.clear_attachment_review_flag): Specify which 'comment'
        form field to use when setting its value.

2009-07-31  Eric Seidel  <eric@webkit.org>

        Reviewed by David Kilzer.

        bugzilla-tool post-commits obsoletes its own work :(
        https://bugs.webkit.org/show_bug.cgi?id=27849

        Simple fix.  Use .add() instead of .update()

        * Scripts/bugzilla-tool:

2009-07-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Anders Carlsson.

        Improve platform-detection in run-webkit-tests

        This prevents miss-detection of mac-* over Qt/Mac.

        * Scripts/run-webkit-tests:

2009-07-30  Mark Rowe  <mrowe@apple.com>

        Reviewed by Cameron Zwarich.

        Teach buildbot to detect test cases that are missing results.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

2009-07-30  Mark Rowe  <mrowe@apple.com>

        Things work better when you create the correct directories.

        * Scripts/run-webkit-tests:

2009-07-30  Mark Rowe  <mrowe@apple.com>

        Include some information about the error when we die.

        * Scripts/run-webkit-tests:

2009-07-30  Mark Rowe  <mrowe@apple.com>

        Ensure that the path exists before writing results to it.
        Hopefully this will make the Windows build bot happy.

        * Scripts/run-webkit-tests:

2009-07-30  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam Treat and Jon Honeycutt.

        Teach run-webkit-tests to always store the actual results in the results directory for new tests.
        This allows us to give a working link to the results from the result summary page, even if we're
        not generating new results in to the tree.

        * Scripts/run-webkit-tests:

2009-07-30  Mark Rowe  <mrowe@apple.com>

        Add a Qt Linux build bot.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

2009-07-30  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Roben.

         Add --minimal option to webkit-build.
         https://bugs.webkit.org/show_bug.cgi?id=27852

         This option disables all optional build features unless
         they are explicitly enabled.

         * Scripts/build-webkit:

2009-07-30  Jakub Wieczorek  <faw217@gmail.com>

        [Qt] Fix build with GCC 4.4.

        * DumpRenderTree/qt/ImageDiff.cpp:

2009-07-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=27813

        [Qt] Support pixel tests in DumpRenderTree for the Qt port.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::open):
        (WebCore::DumpRenderTree::setDumpPixels):
        (WebCore::DumpRenderTree::dump):
        * DumpRenderTree/qt/DumpRenderTree.h:
        * DumpRenderTree/qt/main.cpp:
        (main):

2009-07-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=27813

        [Qt] Implement ImageDiff.

        * DumpRenderTree/qt/ImageDiff.cpp: Added.
        * DumpRenderTree/qt/ImageDiff.pro: Added.

2009-07-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Eric Seidel.

        build-webkit: Reorder logic for determining the baseProductDir
        
        https://bugs.webkit.org/show_bug.cgi?id=27699

        We now do port-spesific probing for the product dir first, and then
        fall back to either the generic WEBKITOUTPUTDIR (which now also works
        on Mac), or WebKitBuild.
        
        Then we add the git branch if the git branch build option is enabled.
        
        Finally we massage the product dir based on the port. For example the
        Mac port will now always set the SYMROOT and OBJROOT configuration for
        XCode.
        
        Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive,
        hence the normal if and not elsif in the last two blocks.

        * Scripts/webkitdirs.pm:

2009-07-29  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches

        Reviewed by David Levin.

        * Scripts/bugzilla-tool:
        (LandPatchesFromBugs.__init__): Added --no-close switch.
        (LandPatchesFromBugs.land_patches): Don't close the bug if the
        --no-close switch was used.  Always clear the review+ flag on
        every landed patch using the commit_text message when cleared.
        This prevents patches from showing up in the commit queue if
        reopened and provides consistency with all landed patches.
        * Scripts/modules/bugzilla.py:
        (Bugzilla.clear_attachment_review_flag): Added.

2009-07-29  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command

        Reviewed by Eric Seidel.

        * Scripts/bugzilla-tool:
        (PostDiffAsPatchToBug.execute): Changed default patch name from
        "patch" to "Patch v1".
        (PostCommitsAsPatchesToBug.__init__): Added -m/--description
        switch.
        (PostCommitsAsPatchesToBug.execute): Use description provided by
        -m/--description switch first, else fall back to the commit
        message.

2009-07-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Dave Levin.

        Make check-webkit-style support files as arguments.
        https://bugs.webkit.org/show_bug.cgi?id=27549

        * Scripts/check-webkit-style:
        Support files as argument. Change documentation and use basename
        on the binary name when used in the documentation. Also do not
        die when printing something containing non-ASCII characters.

2009-08-06  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by David Levin.

        Add validation for pointer and reference declaration as defined by webkit style guidelines to cpp_style.py.
        Add unit tests for validation and update existing c style cast test to be run explicitly as c validation.

        https://bugs.webkit.org/show_bug.cgi?id=27984

        * Scripts/modules/cpp_style.py:
        * Scripts/modules/cpp_style_unittest.py:

2009-07-29  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command

        Reviewed by David Levin.

        Implement "create-bug" command for bugzilla-tool.

        * Scripts/bugzilla-tool: Added CreateBug class.
        (CreateBug.__init__): Added.
        (CreateBug.create_bug_from_commit): Added.
        (CreateBug.create_bug_from_patch): Added.
        (CreateBug.prompt_for_bug_title_and_comment): Added.
        (CreateBug.execute): Added.
        (BugzillaTool.__init__): Added create-bug command.
        * Scripts/modules/bugzilla.py:
        (Bugzilla.prompt_for_component): Added.
        (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added.
        (Bugzilla.create_bug_with_patch): Added.

2009-07-29  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Eric Seidel and Xan Lopez.

        [Gtk] Enable http/tests/appcache tests
        https://bugs.webkit.org/show_bug.cgi?id=27674

        Add support for testing http/tests/appcache tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setAppCacheMaximumSize):

2009-07-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with.

        * WebKitLauncher/main.m:
        (checkSafariVersion): Add a minimum required Safari version of 4.0.  This matches the requirement on Windows.
        (main): If the minimum version requirement is not met, display an alert and bail out.

2009-07-28  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        cpplint* should be named cpp_style*
        https://bugs.webkit.org/show_bug.cgi?id=27752

        The files were renamed. A few renames were done:
          CppLint -> CppStyle
          cpplint -> cpp_style

        * Scripts/check-webkit-style:
        * Scripts/modules/cpp_style.py: Copied from cpplint.py and
          did name fix ups.
        * Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and
          did name fix ups.
        * Scripts/modules/cpplint.py: Removed.
        * Scripts/modules/cpplint_unittest.py: Removed.

2009-07-28  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Rubber-stamped by Holger Freyther.
        
        Add Steve Falkenburg to bugzilla-tools' reviewers list

        * Scripts/modules/bugzilla.py:

2009-07-28  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Implement test result archive support for the Qt port.

        * BuildSlaveSupport/test-result-archive:

2009-07-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=27755
        Layout tests that dump resource load delegate calls should dump the request method and the response status code.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[NSURLResponse _drt_descriptionSuitableForTestResult]):
        (-[NSURLRequest _drt_descriptionSuitableForTestResult]):

        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (descriptionSuitableForTestResult):

2009-07-27  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by David Levin.

        "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
        https://bugs.webkit.org/show_bug.cgi?id=27747

        modules.bugzilla is not found because not included.

        * Scripts/modules/scm.py: Properly import modules.bugzilla.

2009-07-24  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by David Kilzer.

        commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog
        https://bugs.webkit.org/show_bug.cgi?id=27664

        * Scripts/commit-log-editor: Add --regenerate-log option.
        The user is asked if he wants to suppress previous ChangeLog and regenerate it,
        if this option is enabled.

2009-07-27  Gabor Rapcsanyi  <rapcsanyi.gabor@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Generating remote links causes a lot of unnecessary spew on Qt build bot too

        * Scripts/run-webkit-tests:

2009-07-25  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Darin Adler.

        Windows build break due to warning C4819
        https://bugs.webkit.org/show_bug.cgi?id=27416

        Disable C4819 warning to fix build.

        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

2009-07-24  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py

        * Scripts/modules/bugzilla.py:

2009-07-24  Eli Fidler  <eli.fidler@torchmobile.com>

        Reviewed by Adam Treat.

        Improve git workflow by populating commit messages with ChangeLog entries.
        https://bugs.webkit.org/show_bug.cgi?id=27605

        If the user doesn't manually modify the ChangeLog files, use
        prepare-ChangeLog to populate the git commit message. This behaviour
        can be disabled by the 'webkitGenerateCommitMessage' git configuration option.

        * Scripts/commit-log-editor:

2009-07-24  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        cpplint crash when there is a duplicate header followed by another header.
        https://bugs.webkit.org/show_bug.cgi?id=27625

        * Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even
          there is a duplicate header, which resulted in some code rearrangement.  Also,
          changed some if's in this function to return early.  This avoids having nearly the
          whole function content being indented.
        * Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash.

2009-07-24  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Treat.

         Filetype support changes for cpplint and check_webkit_style
         https://bugs.webkit.org/show_bug.cgi?id=27653

         Introduce .c support for check_webkit_style, and remove support for
         .cc files in favor of .cpp.

         * Scripts/check-webkit-style:
         * Scripts/modules/cpplint.py:
         * Scripts/modules/cpplint_unittest.py:

2009-07-24  Eli Fidler  <eli.fidler@torchmobile.com>

        Reviewed by David Levin.

        Improve git workflow by populating commit messages with ChangeLog entries.
        https://bugs.webkit.org/show_bug.cgi?id=27605

        add --[no-]write prepare-ChangeLog options to bash completion

        * Scripts/webkit-tools-completion.sh:

2009-07-24  Andrei Popescu  <andreip@google.com>

        Reviewed by Anders Carlsson.

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        Adds a new method on the LayoutTestController that
        allows a JS unit test to configure the maximum size
        of the Application Cache.

        * DumpRenderTree/LayoutTestController.cpp:
        (setAppCacheMaximumSizeCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setAppCacheMaximumSize):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setAppCacheMaximumSize):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setAppCacheMaximumSize):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setAppCacheMaximumSize):

2009-07-24  Adam Barth  <abarth@webkit.org>

        Rubber stamped by Eric Seidel.

        Added andersca to list of reviewers.

        * Scripts/modules/bugzilla.py:

2009-07-24  Mark Rowe  <mrowe@apple.com>

        Reviewed by Xan Lopez.

        Fix dozens of "Deallocation of a pointer not malloced" messages seen while running
        layout tests on the build bot.

        Memory allocated via FastMalloc was being deleted via the system memory allocator
        due to an inconsistent including of FastMalloc.h.  We address this by including it
        from config.h and including config.h from every implementation file, as in our other
        projects.

        * DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h.
        * DumpRenderTree/config.h:
        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        * DumpRenderTree/mac/AppleScriptController.m:
        * DumpRenderTree/mac/CheckedMalloc.cpp:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
        * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        * DumpRenderTree/mac/EditingDelegate.mm:
        * DumpRenderTree/mac/EventSendingController.mm:
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        * DumpRenderTree/mac/GCControllerMac.mm:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/mac/NavigationController.m:
        * DumpRenderTree/mac/ObjCController.m:
        * DumpRenderTree/mac/ObjCPlugin.m:
        * DumpRenderTree/mac/ObjCPluginFunction.m:
        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        * DumpRenderTree/mac/PlainTextController.mm:
        * DumpRenderTree/mac/PolicyDelegate.mm:
        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        * DumpRenderTree/mac/TextInputController.m:
        * DumpRenderTree/mac/UIDelegate.mm:
        * DumpRenderTree/mac/WorkQueueItemMac.mm:

2009-07-24  Mark Rowe  <mrowe@apple.com>

        Reviewed by Simon Hausmann.

        Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore.
        This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests,
        leading to situations where the build system unnecessarily feels that the need to recompile.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        * Scripts/run-javascriptcore-tests:

2009-07-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Eric Seidel.

        [Gtk] Add implementation of GCController for DRT
        https://bugs.webkit.org/show_bug.cgi?id=27636

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewWindowObjectCleared):
        (main):
        * DumpRenderTree/gtk/GCControllerGtk.cpp:
        (GCController::collect):
        (GCController::collectOnAlternateThread):
        (GCController::getJSObjectCount):

2009-07-23  Mark Rowe  <mrowe@apple.com>

        Update build.webkit.org config for new machine.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

2009-07-23  Brady Eidson  <beidson@apple.com>

        Remove accidentally checked in code.

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (waitUntilDoneWatchdogFired):
        (LayoutTestController::setWaitToDump):

2009-07-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoff Garen.

        WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
        https://bugs.webkit.org/show_bug.cgi?id=27595

        Add the ability to tell the LayoutTestController to return a null request for willSendRequest
        redirect callbacks.
        
        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setWillSendRequestReturnsNullOnRedirectCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::willSendRequestReturnsNullOnRedirect):
        (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::willSendRequest):

2009-07-23  Mark Rowe  <mrowe@apple.com>

        Reviewed Oliver Hunt.

        Fix DumpRenderTree to not fail an assertion on launch on a new machine.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setDefaultsToConsistentValuesForTesting): Disable the XSS auditor.  It being enabled
        breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString,
        which causes us to exit due to an assertion failure.  It's not clear why the XSS auditor
        decides to interfere with these tests.

2009-07-23  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows
        in hopes of fixing some layout test failures seen on the build bot.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):

2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Treat.

         Fix false positives for switch statement indentation check in cpplint.
         https://bugs.webkit.org/show_bug.cgi?id=27615

         Makes one-line case statements (e.g. "case foo: bar();") work.
         Also a few general improvements to the robustness and readability of
         the check, and more test cases.

         * Scripts/modules/cpplint.py:
         * Scripts/modules/cpplint_unittest.py:

2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Treat.

         Add check for line-breaking rule #3 to cpplint.
         https://bugs.webkit.org/show_bug.cgi?id=27610

         "An else if statement should be written as an if statement when
         the prior if concludes with a return statement."

         Implemented by a multi-line (kind of back-tracking) algorithm.
         Comes with loads of unit tests. Fixes the check for label indentation
         to be not so overzealous, as it didn't allow for completely unindented
         goto labels (at the very start of a line).

         * Scripts/modules/cpplint.py:
         * Scripts/modules/cpplint_unittest.py:

2009-07-23  Eli Fidler  <eli.fidler@torchmobile.com>

         Reviewed by Adam Treat.

         Improve git workflow by populating commit messages with ChangeLog entries.
         https://bugs.webkit.org/show_bug.cgi?id=27605

         add --[no-]write option to optionally output new ChangeLog entries to
         stdout instead of modifying ChangeLog files

         fix Torch Mobile copyright

         * Scripts/prepare-ChangeLog:

2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        Enable cpplint for .c files.
        https://bugs.webkit.org/show_bug.cgi?id=27604

        Also make sure that the check for NULL does not apply to .c files.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-22  Steve Falkenburg  <sfalken@apple.com>

        Checkpoint new Windows nightly launcher.
        
        Reviewed by Mark Rowe.

        * WebKitLauncherWin: Added.
        * WebKitLauncherWin/Resource.h: Added.
        * WebKitLauncherWin/WebKitLauncherWin.cpp: Added.
        (getStringValue): Retrieve a string registry value.
        (applePathFromRegistry): Get an Apple-related path out of the registry.
        (copyEnvironmentVariable): Copy an environment variable.
        (safariInstallDir): Helper function to get the install directory for Safari.
        (safariBrowserExe): Helper function to get the full path of the Safari executable.
        (_tWinMain): Locate Safari and launch it after setting up an environment variable.
        * WebKitLauncherWin/WebKitLauncherWin.h: Added.
        * WebKitLauncherWin/WebKitLauncherWin.rc: Added.
        * WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
        * WebKitLauncherWin/webkit.ico: Added.

2009-07-22  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        run-webkit-lint should be named check-webkit-style
        https://bugs.webkit.org/show_bug.cgi?id=27568

        This name better reflects the fact that it is about checking the style of files.

        * Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.

2009-07-22  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by Darin Adler.

        VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
        https://bugs.webkit.org/show_bug.cgi?id=26375

        Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
        the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
        in the macros before writing out them into the file to update.

        By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
        strings in the Localizable.strings file.

        Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
        users to update-webkit-localizable-strings.

        * Scripts/extract-localizable-strings:

2009-07-22  Shinichiro Hamaji  <hamaji@google.com>

        Reviewed by David Levin.

        Tiny typo fixes for cpplint.py
        https://bugs.webkit.org/show_bug.cgi?id=27530

        * Scripts/modules/cpplint.py:

2009-07-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        run-webkit-lint checks code which are not changed
        https://bugs.webkit.org/show_bug.cgi?id=27529

        Add check if the line is newly added.

        * Scripts/run-webkit-lint:

2009-07-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        run-webkit-lint should have --git-commit option
        https://bugs.webkit.org/show_bug.cgi?id=27528

        * Scripts/modules/cpplint.py:
        * Scripts/run-webkit-lint:

2009-07-22  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Factor svn-create-patch's "determineSvnRoot()" into a function in
        VCSUtils.pm so commit-log-editor can use it too.

        * Scripts/VCSUtils.pm: Add determineSVNRoot().
        * Scripts/commit-log-editor: Use determineSVNRoot() instead of old
          code (which didn't work as well).
        * Scripts/svn-create-patch: Remove determineSvnRoot() (moved).

2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        Fix false positives in namespace indentation checks.
        https://bugs.webkit.org/show_bug.cgi?id=27567

        The regular expression detecting goto labels (in order
        to skip those) was too permissive, which caused other
        code like "Foo::Bar()" to be treated as a label too,
        thereby not stopping the processing loop as expected.

        Now comes with a stricter regexp, and more demanding
        test cases to check for these issues.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        Fix cpplint generating false positives for
        "primary" includes in headers.
        https://bugs.webkit.org/show_bug.cgi?id=27553

        Doing so by only flagging includes in header files
        as primary when the include filename exactly matches
        the header filename.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        cpplint generates false positives for primary includes
        https://bugs.webkit.org/show_bug.cgi?id=27544

        Fix false positives for instances when cpplint would
        normally classify multiple includes as primary: After
        the first primary include, classify subsequent ones as
        "other" includes even if they look like primary ones.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-22  Gabor Rapcsanyi  <rapcsanyi.gabor@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Pass XAUTHORITY environment variable to $dumpTool as well.

        * Scripts/run-webkit-tests:

2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Treat.

         Add check for correct wtf includes to cpplint.
         https://bugs.webkit.org/show_bug.cgi?id=27524

         * Scripts/modules/cpplint.py:
         * Scripts/modules/cpplint_unittest.py:

2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by David Levin.

        Add checks for multi-line boolean operator placement.
        https://bugs.webkit.org/show_bug.cgi?id=27496

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-21  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Levin.

        We can't match implementation file and primary header exactly
        since we have so many files in WebKit where the port suffix
        is appended to the filename.

        Example: FooQt.cpp and the primary header is Foo.h.

        * Scripts/modules/cpplint.py:

2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by David Levin.

        Add checks for switch statement indentation to cpplint.
        https://bugs.webkit.org/show_bug.cgi?id=27508

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-21  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Adam Treat.

        Feature request: cpplint should check for braces - rule 2
        https://bugs.webkit.org/show_bug.cgi?id=27497

        Add the requested feature: Make sure { is on the same line
        as the foreach "keyword".

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-20  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by David Levin.

        Add checks for namespace indentation to cpplint.
        https://bugs.webkit.org/show_bug.cgi?id=27461

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-20  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Levin.

        Add cpplint check for proper include order
        https://bugs.webkit.org/show_bug.cgi?id=27462

        Add a new check to cpplint to flag cases where the include section of a file
        does not match the mandated include order and style of the Webkit coding style
        guidelines.

        Add associated tests.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        Support lint for patches
        https://bugs.webkit.org/show_bug.cgi?id=27291

        Add run-webkit-lint script, which lints recent changes in local
        repository.  Also, modified cpplint.py so that we don't need to
        specify verbose level for process_file().

        * Scripts/modules/cpplint.py:
        * Scripts/run-webkit-lint: Added.

2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        diff_parser should accept lines without trailing \n
        https://bugs.webkit.org/show_bug.cgi?id=27483

        Normalize the input lines by removing a trailing newline.
        Also, add a case for unittest for newly added files.

        * Scripts/modules/diff_parser.py:
        * Scripts/modules/diff_parser_unittest.py:

2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        cpplint.py's process_file() should accept customized error function
        https://bugs.webkit.org/show_bug.cgi?id=27487

        * Scripts/modules/cpplint.py:

2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        cpplint.py should have an interface to get global error count
        https://bugs.webkit.org/show_bug.cgi?id=27486

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        cpplint's parse_argument should not exit even if no files are specified
        https://bugs.webkit.org/show_bug.cgi?id=27489

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        diff_parser: s/add_deleted_line/add_old_line/g
        https://bugs.webkit.org/show_bug.cgi?id=27484

        * Scripts/modules/diff_parser.py:

2009-07-21  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by David Levin.

        Add ENABLE_RUBY to list of build options
        https://bugs.webkit.org/show_bug.cgi?id=27324

        * Scripts/build-webkit: Added flag ENABLE_RUBY.

2009-07-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by David D. Kilzer.

        Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
        Bug 27482: svn-apply cannot apply patch generated by Windows SVN

        A regexp in svn-apply was treating everything prior to a \n as part of the
        file name.  The native Windows SVN client uses \r\n for line endings which
        meant that the \r was being included in the file name.  This defeated the
        special-case logic for ChangeLogs to apply them with an increased fuzz factor,
        meaning that the ChangeLog portions of such patches would fail to apply.

        Also updated two other regexps that look like they would hit similar problems
        with line-endings so that they will correctly handle patches from Windows SVN.

        * Scripts/svn-apply:

2009-07-20  Peter Kasting  <pkasting@google.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=27468
        Back out r46060, which caused problems for some Apple developers.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

2009-07-20  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=27323