2010-08-24 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Ojan Vafai.
4
5         new-run-webkit-tests: clean up code for test_types, test_failures
6
7         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
8         webkitpy.layout_tests.layout_package.test_failures, and remove
9         some dead code and otherwise clean up things.
10
11         https://bugs.webkit.org/show_bug.cgi?id=44559
12
13         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
14         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
15         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
16         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
17         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
18         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
19         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
20
21 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
22
23         Reviewed by Eric Seidel.
24
25         new-run-webkit-tests: revise unit testing strategy for test failures
26     
27         This change revamps the way we store test data for new-run-webkit-tests.
28         Previously we had a few copies of test files from the main test tree.
29         Now we have a bunch of completely fake test data and use the test
30         data to generate different kinds of test failures, getting
31         much better coverage.
32
33         https://bugs.webkit.org/show_bug.cgi?id=44556
34
35         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
36         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
37         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
38         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
39         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
40         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
41         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
42         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
43         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
44         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
45         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
46         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
47         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
48         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
49         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
50         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
51         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
52         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
53         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
54         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
55         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
56         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
57         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
58         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
59         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
60         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
61         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
62         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
63         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
64         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
65         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
66         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
67         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
68         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
69         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
70         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
71         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
72         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
73         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
74         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
75         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
76         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
77         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
78         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
79         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
80         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
81         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
82         * Scripts/webkitpy/layout_tests/port/test.py:
83         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
84         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
85
86 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
87
88         Reviewed by Eric Seidel.
89
90         speed up new-run-webkit-tests unit tests
91
92         Add a --no-record-results flag that turns off generating the JSON
93         results file on every test run. Generating the file requires us to
94         fetch the old results down from the bots, which can be slow. This
95         flag is off by default.
96     
97         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
98     
99         These changes together shorten the test cycle from ~4.5s to ~1.5s
100         - a 3x speedup.
101
102         https://bugs.webkit.org/show_bug.cgi?id=44553
103
104         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
105         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
106
107 2010-08-24  Tony Chang  <tony@chromium.org>
108
109         Reviewed by Eric Seidel.
110
111         [chromium] fix the platform result fallback order on mac/win
112         https://bugs.webkit.org/show_bug.cgi?id=44483
113
114         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
115
116 2010-08-24  Xan Lopez  <xlopez@igalia.com>
117
118         Reviewed by Martin Robinson.
119
120         Set a device to the event struct when building with GTK+ 3.x, it's
121         mandatory.
122
123         * DumpRenderTree/gtk/EventSender.cpp:
124         (keyDownCallback):
125
126 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
127
128         Reviewed by Xan Lopez.
129
130         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
131         https://bugs.webkit.org/show_bug.cgi?id=44534
132
133         Fix two double-frees introduced in my previous commit.
134
135         * DumpRenderTree/gtk/EventSender.cpp:
136         (contextClickCallback): Copy the event before using it again.
137         (keyDownCallback): Ditto.
138
139 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
140
141         Reviewed by Xan Lopez.
142
143         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
144         https://bugs.webkit.org/show_bug.cgi?id=44534
145
146         * DumpRenderTree/gtk/EventSender.cpp:
147         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
148         when setting it on the event. It is dereferenced by gdk_event_free(...).
149         (contextClickCallback): Ditto.
150         (mouseDownCallback): Ditto.
151         (mouseUpCallback): Ditto.
152         (mouseMoveToCallback): Ditto.
153         (mouseWheelToCallback): Ditto.
154         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
155         (dispatchEvent): Ditto. Also free the event when we are done with it.
156         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
157
158 2010-08-24  Andras Becsi  <abecsi@webkit.org>
159
160         [Qt] WebKit2 build fix.
161
162         * Scripts/enumerate-included-framework-headers:
163         Remove stray global option form sed.
164
165 2010-08-24  Kent Tamura  <tkent@chromium.org>
166
167         Reviewed by Jeremy Orlow.
168
169         [DRT/Chromium] Support for IndexedDB tests
170         https://bugs.webkit.org/show_bug.cgi?id=44490
171
172         * DumpRenderTree/chromium/TestShell.cpp:
173         (TestShell::TestShell): Enable IndexedDB.
174
175 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
176
177         Reviewed by Gustavo Noronha Silva.
178
179         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
180         https://bugs.webkit.org/show_bug.cgi?id=44465
181
182         Initialize the axes field of mouse button and motion events to null.
183         This is the value that should be used for events originating from the
184         mouse device.
185
186         * DumpRenderTree/gtk/EventSender.cpp:
187         (prepareMouseButtonEvent): Initalize button event axes field to null.
188         (mouseMoveToCallback): Initialize motion event axes field to null.
189
190 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
191
192         Unreviewed, rolling out r65703.
193         http://trac.webkit.org/changeset/65703
194         https://bugs.webkit.org/show_bug.cgi?id=44460
195
196         "Causing lots of crashes on Snow Leopard when running the
197         layout tests" (Requested by eseidel2 on #webkit).
198
199         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
200         (NP_Initialize):
201         (NP_GetEntryPoints):
202
203 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
204
205         Layout tests do not run when using WebKitTestRunner in a Debug build.
206         https://bugs.webkit.org/show_bug.cgi?id=44409
207
208         Reviewed by Dan Bernstein.
209
210         * WebKitTestRunner/win/TestControllerWin.cpp:
211         (WTR::TestController::initializeInjectedBundlePath):
212         Use InjectedBundle_debug.dll when building Debug.
213
214 2010-08-23  Xan Lopez  <xlopez@igalia.com>
215
216         Reviewed by Martin Robinson.
217
218         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
219         https://bugs.webkit.org/show_bug.cgi?id=42026
220
221         If a GTK+ 3.x build is present return that as the library to use,
222         otherwise fallback to the GTK+ 2.x build.
223
224         * Scripts/webkitdirs.pm:
225
226 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
227
228         Reviewed by Ariya Hidayat.
229
230         [Qt] Find needed forwarding headers for WebKit2 automatically
231         https://bugs.webkit.org/show_bug.cgi?id=44336
232
233         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
234         The new script does not satisfy the needs of this file however using normal includes
235         is generally better here.
236         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
237         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
238         given frameworks by files in the current directory (and subdirectories).
239         In the future this needs to be rewritten in perl for being able to use on Windows.
240
241 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
242
243         Reviewed by Ariya Hidayat.
244
245         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
246         https://bugs.webkit.org/show_bug.cgi?id=43010
247
248         * QtTestBrowser/launcherwindow.cpp:
249         (LauncherWindow::applyPrefs):
250         * QtTestBrowser/main.cpp:
251         (LauncherApplication::handleUserOptions):
252
253 2010-08-21  Sam Weinig  <sam@webkit.org>
254
255         Reviewed by Dan Bernstein.
256
257         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
258         https://bugs.webkit.org/show_bug.cgi?id=44386
259
260         * MiniBrowser/mac/AppDelegate.m:
261         (didRecieveMessageFromInjectedBundle):
262         (didNavigateWithNavigationData):
263         (-[BrowserAppDelegate init]):
264         (-[BrowserAppDelegate applicationWillTerminate:]):
265         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
266         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
267         (-[BrowserStatisticsWindowController dealloc]):
268         * MiniBrowser/mac/BrowserWindowController.m:
269         (-[BrowserWindowController initWithPageNamespace:]):
270         (-[BrowserWindowController fetch:]):
271         (-[BrowserWindowController windowWillClose:]):
272         (-[BrowserWindowController applicationTerminating]):
273         (closePage):
274         (runJavaScriptAlert):
275         (runJavaScriptConfirm):
276         (runJavaScriptPrompt):
277         (-[BrowserWindowController updateProvisionalURLForFrame:]):
278         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
279         (didClearWindowObjectForFrame):
280         * MiniBrowser/win/BrowserView.cpp:
281         (BrowserView::goToURL):
282         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
283         (WTR::PlatformWebView::~PlatformWebView):
284
285 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
286
287         Reviewed by Kenneth Rohde Christiansen.
288
289         WebKit does not build with Python 2.3
290         https://bugs.webkit.org/show_bug.cgi?id=44373
291
292         Replaced the function sorted() by a call to sort()
293         on the entry list.
294         The function sorted() has been added to Python 2.4.
295         The function method sort() of List works with older
296         versions of Python.
297
298         * Scripts/create-html-entity-table:
299
300 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
301
302         Reviewed by Pavel Feldman.
303
304         Web Inspector: Inspector tests were disabled for GTK.
305         https://bugs.webkit.org/show_bug.cgi?id=43977
306
307         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
308         path before running tests.
309
310 2010-08-20  Daniel Bates  <dbates@rim.com>
311
312         Reviewed by Eric Seidel.
313
314         svn-apply doesn't detect empty line with Windows line endings
315         after property value
316         https://bugs.webkit.org/show_bug.cgi?id=43981
317
318         Part 2 of 2
319
320         Add unit tests that were not landed in the first commit.
321
322         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
323           - Added the following test cases:
324             "SVN: binary file (isBinary true) using Windows line endings"
325             "SVN: property diff, followed by file change diff using Windows line endings"
326             "SVN: two consecutive property diffs using Windows line endings"
327             "SVN: binary file with executable bit change usng Windows line endings"
328             "SVN: binary file followed by property change on different file using Windows line endings"
329             "SVN: binary file followed by file change on different file using Windows line endings"
330             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
331             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
332         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
333           - Added the following test cases:
334             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
335             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
336             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
337             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
338             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
339             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
340             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
341             "single-line '+' with trailing new line using Windows line endings"
342             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
343             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
344             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
345         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
346           - Added the following test cases:
347             "single-line '-' change followed by empty line with Windows line endings"
348             "multi-line '+' change and start of binary patch with Windows line endings"
349
350 2010-08-20  Daniel Bates  <dbates@rim.com>
351
352         Reviewed by Eric Seidel.
353
354         svn-apply doesn't detect empty line with Windows line endings
355         after property value
356         https://bugs.webkit.org/show_bug.cgi?id=43981
357
358         Fixes an issue where an empty line following the property value
359         in an SVN property change diff would not be detected if it had
360         Windows line endings (i.e. ended in CRLF). Hence it was consumed
361         as if it was part of a multi-line property value. 
362
363         * Scripts/VCSUtils.pm:
364           - Modified parseSvnPropertyValue() to detect empty line
365             with Windows line endings.
366           - Added toWindowsLineEndings().
367         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
368           - Added the following test cases:
369             "SVN: binary file (isBinary true) using Windows line endings"
370             "SVN: property diff, followed by file change diff using Windows line endings"
371             "SVN: two consecutive property diffs using Windows line endings"
372             "SVN: binary file with executable bit change usng Windows line endings"
373             "SVN: binary file followed by property change on different file using Windows line endings"
374             "SVN: binary file followed by file change on different file using Windows line endings"
375             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
376             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
377         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
378           - Added the following test cases:
379             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
380             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
381             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
382             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
383             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
384             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
385             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
386             "single-line '+' with trailing new line using Windows line endings"
387             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
388             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
389             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
390         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
391           - Added the following test cases:
392             "single-line '-' change followed by empty line with Windows line endings"
393             "multi-line '+' change and start of binary patch with Windows line endings"
394
395 2010-08-19  David Kilzer  <ddkilzer@apple.com>
396
397         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
398
399         * MiniBrowser/mac/BrowserWindowController.m:
400         (decidePolicyForNavigationAction): Updated method signature.
401         (decidePolicyForNewWindowAction): Updated method signature.
402
403 2010-08-19  Adam Roben  <aroben@apple.com>
404
405         Test that NP_Initialize and NP_GetEntryPoints are called in the
406         correct order
407
408         The order differs between Mac and Windows (see r38858).
409
410         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
411         NP_Initialize when loading QuickTime when running
412         plugins/embed-attributes-setting.html in WebKit2 on Windows
413
414         Reviewed by Sam Weinig.
415
416         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
417         a boolean to record whether NP_GetEntryPoints has been called.
418         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
419         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
420         if NP_GetEntryPoints has been called already. This matches
421         Silverlight's behavior.
422
423 2010-08-19  Adam Roben  <aroben@apple.com>
424
425         Make build-webkittestrunner build TestNetscapePlugIn on Windows
426
427         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
428
429         Reviewed by Sam Weinig.
430
431         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
432         Threaded it in between ImageDiff and InjectedBundleGenerated.
433
434 2010-08-19  Ojan Vafai  <ojan@chromium.org>
435
436         Reviewed by Adam Barth.
437
438         install rietveld's upload script from a versioned url
439         https://bugs.webkit.org/show_bug.cgi?id=44291
440
441         autoinstall expects the file at a given URL to never change.
442         In order to be able to update the file, we need to be able to
443         change the path.
444
445         * Scripts/webkitpy/thirdparty/__init__.py:
446
447 2010-08-19  Ojan Vafai  <ojan@chromium.org>
448
449         Reviewed by Adam Barth.
450
451         add --webkit_patch_id to reitveld uploads
452         https://bugs.webkit.org/show_bug.cgi?id=44289
453
454         This is the first step in having rietveld store which
455         patches have been uploaded and getting rid of the
456         in-rietveld flag.
457
458         * Scripts/webkitpy/common/net/rietveld.py:
459         * Scripts/webkitpy/tool/mocktool.py:
460         * Scripts/webkitpy/tool/steps/postcodereview.py:
461
462 2010-08-19  Kenneth Russell  <kbr@google.com>
463
464         Reviewed by David Levin.
465
466         Adjust my status from committer to reviewer
467         https://bugs.webkit.org/show_bug.cgi?id=44277
468
469         * Scripts/webkitpy/common/config/committers.py:
470
471 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
472
473         Reviewed by Yury Semikhatsky.
474
475         Chromium DevTools: remove injected script fetcher from test harness.
476         https://bugs.webkit.org/show_bug.cgi?id=44266
477
478         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
479         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
480
481 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
482
483         Reviewed by Yury Semikhatsky.
484
485         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
486         Now that we populate front-end after its onload handler, we don't need
487         to install injected script early. Exposing injected script source on the WebCore
488         level here.
489         https://bugs.webkit.org/show_bug.cgi?id=44029
490
491         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
492         (DRTDevToolsAgent::runtimePropertyChanged):
493         (DRTDevToolsAgent::delayedFrontendLoaded):
494         (DRTDevToolsAgent::frontendLoaded):
495         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
496
497 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
498
499         Reviewed by Kenneth Rohde Christiansen.
500
501         [Gtk] Enable view mode media feature layout test
502         https://bugs.webkit.org/show_bug.cgi?id=43278
503
504         Add view mode media feature testing infrastructure, and add
505         placeholder methods for the other platforms'
506         LayoutTestControllers.
507
508         * DumpRenderTree/LayoutTestController.cpp:
509         (setViewModeMediaFeatureCallback):
510         (LayoutTestController::staticFunctions):
511         * DumpRenderTree/LayoutTestController.h:
512         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
513         (LayoutTestController::setViewModeMediaFeature):
514         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
515         (LayoutTestController::setViewModeMediaFeature):
516         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
517         (LayoutTestController::setViewModeMediaFeature):
518         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
519         (LayoutTestController::setViewModeMediaFeature):
520
521 2010-08-18  Mark Rowe  <mrowe@apple.com>
522
523         Reviewed by Sam Weinig.
524
525         Make it so the WebKit2 test slave runs the WebKit2 tests
526
527         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
528
529 2010-08-18  Sam Weinig  <sam@webkit.org>
530
531         Reviewed by Mark Rowe.
532
533         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
534         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
535         module and the TestNetscapePlugin.
536
537         * Scripts/old-run-webkit-tests:
538
539 2010-08-18  Adam Roben  <aroben@apple.com>
540
541         Fix hang when saving crash logs on Windows
542
543         * Scripts/old-run-webkit-tests:
544         (setUpWindowsCrashLogSaving):
545         (END):
546         Pass -s to regtool so it will write the Auto value as a string instead
547         of as a number. This was causing a "do you want to debug?" dialog to
548         appear.
549
550 2010-08-17  Victor Wang  <victorw@chromium.org>
551
552         Unreviewed. Fixed chromium incremental test json upload.
553         Quote builder name and test results server in url.
554
555         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
556
557 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
558
559         Reviewed by Ariya Hidayat.
560
561         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
562         https://bugs.webkit.org/show_bug.cgi?id=44124
563
564         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
565         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
566         Symbian dependencies.
567
568         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
569         (WebCore::DumpRenderTree::open):
570         * QtTestBrowser/launcherwindow.cpp:
571         (LauncherWindow::init):
572         (LauncherWindow::toggleFullScreenMode):
573         (LauncherWindow::showFPS):
574         (LauncherWindow::updateFPS):
575         * QtTestBrowser/launcherwindow.h:
576         (WindowOptions::WindowOptions):
577         * QtTestBrowser/mainwindow.cpp:
578         (MainWindow::buildUI):
579
580 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
581
582         Reviewed by David Levin.
583
584         new-run-webkit-tests: remove --show-sources option
585
586         --show-sources is pretty much obsolete with --trace everything, so
587         I'm removing it.
588
589         Also rename a couple of methods in the TestTextDiff class to make their
590         intended visibility (private) more obvious.
591
592         https://bugs.webkit.org/show_bug.cgi?id=44143
593
594         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
595         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
596         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
597         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
598         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
599
600 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
601
602         Reviewed by David Levin.
603
604         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
605
606         This code bit-rotted at some point more than a year ago, and nobody seems
607         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
608         should support instead, making this flag unnecessary anyway.
609
610         https://bugs.webkit.org/show_bug.cgi?id=44141
611
612         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
613         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
614         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
615
616 2010-08-17  Victor Wang  <victorw@chromium.org>
617
618         Reviewed by Ojan Vafai.
619
620         Update json results generator to have incremental json including
621         results for tests that pass in current run but failed before.
622
623         https://bugs.webkit.org/show_bug.cgi?id=44119
624
625         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
626         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
627         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
628
629 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
630
631         Reviewed by Eric Seidel.
632
633         fix test-webkitpy, add easy way to find a checkout root
634
635         test-webkitpy currently doesn't work right if run from someplace other
636         than the checkout root, and it spews a bunch of debug logging because
637         the deduplicate_tests tests contaminates the test environment.
638
639         This patch cleans up the deduplicate_tests unit tests, and creates
640         two new methods in scm.py: find_checkout_root() and default_scm(),
641         both of which use a single algorithm for guessing what checkout root
642         to use if you aren't explicitly told one from a path.
643
644         https://bugs.webkit.org/show_bug.cgi?id=44001
645
646         * Scripts/deduplicate-tests:
647         * Scripts/webkitpy/common/checkout/scm.py:
648         * Scripts/webkitpy/common/checkout/scm_unittest.py:
649         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
650         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
651         * Scripts/webkitpy/layout_tests/port/test.py:
652         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
653         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
654         * Scripts/webkitpy/tool/main.py:
655
656 2010-08-17  Victor Wang  <victorw@chromium.org>
657
658         Reviewed by Ojan Vafai.
659
660         Add support to the test results server for downloading json that
661         contains test list only.
662
663         This is for json results generator to generate incremental json
664         results so that it includes results not only for tests failed in
665         current run, but also tests failed before.
666
667         Also set the results type to "N" (no data) instead of "P" (pass)
668         if test results cannot be found in incremental json file.
669
670         https://bugs.webkit.org/show_bug.cgi?id=44117
671
672         * TestResultServer/handlers/testfilehandler.py:
673         * TestResultServer/model/jsonresults.py:
674         * TestResultServer/model/jsonresults_unittest.py:
675
676 2010-08-17  Adam Roben  <aroben@apple.com>
677
678         Use the right path style
679
680         * Scripts/old-run-webkit-tests:
681
682 2010-08-17  Adam Roben  <aroben@apple.com>
683
684         Fix typo
685
686         * Scripts/old-run-webkit-tests:
687
688 2010-08-17  Adam Roben  <aroben@apple.com>
689
690         Don't hang when running run-webkit-tests as a non-Administrator on
691         Vista/7
692
693         * Scripts/old-run-webkit-tests:
694         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
695         post-mortem debugger, rather than using NTSD itself. The latter waits
696         for user input when it fails to set the registry values; the former
697         does not.
698
699 2010-08-17  Adam Roben  <aroben@apple.com>
700
701         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
702         save crash logs on Windows
703
704         The crash logs are saved to /tmp/layout-test-results and have names
705         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
706
707         Unfortunately, crashes in the WebKit2 web process are recorded as
708         time-outs by run-webkit-tests. Fixing this is covered by
709         <http://webkit.org/b/44121>.
710
711         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
712         DumpRenderTree should save a stack trace and/or dump file when it
713         crashes
714
715         Reviewed by Sam Weinig.
716
717         * DumpRenderTree/win/DumpRenderTree.cpp:
718         (exceptionFilter):
719         (main):
720         * WebKitTestRunner/win/TestControllerWin.cpp:
721         (WTR::exceptionFilter):
722         (WTR::TestController::platformInitialize):
723         These changes set up an exception filter that prints #CRASHED to
724         stderr, then lets the exception propagate normally. This allows
725         run-webkit-tests to detect when we've crashed even when a post-mortem
726         debugger attaches to the process.
727
728         * Scripts/old-run-webkit-tests:
729         (top level): Declared some variables used by the crash-log-saving
730         code.
731         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
732         that the post-mortem debugger has access to it.
733         (toCygwinPath): Added. This is the opposite of toWindowsPath.
734         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
735         stderr, consider it a crash.
736         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
737         debugger, then sets ntsd as the post-mortem debugger. ntsd is
738         configured to save a crash log and then quit automatically.
739         (END): Added. Restores the previous post-mortem debugger when the
740         script exits.
741
742 2010-08-17  Victor Wang  <victorw@chromium.org>
743
744         Reviewed by ojan@chromium.org.
745
746         Update test results server:
747         1. Normalize test results and times after merging (prune tests where
748            all runs pass or do not have data, truncate all test items to max
749            number of builds)
750         2. times should be int not string.
751         3. when inserting a new test item, should keep old data regardless
752            whether or not they have same item type with new one.
753
754         https://bugs.webkit.org/show_bug.cgi?id=43861
755
756         * TestResultServer/model/jsonresults.py:
757         * TestResultServer/model/jsonresults_unittest.py:
758
759 2010-08-16  Sam Weinig  <sam@webkit.org>
760
761         Reviewed by Mark Rowe.
762
763         Add WebKit2 Mac tester to buildbot.
764
765         * BuildSlaveSupport/build.webkit.org-config/config.json:
766         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
767
768 2010-08-16  Paul Sawaya  <psawaya@apple.com>
769
770         Reviewed by Chris Marrin.
771
772         Added shader validation via ANGLE
773         https://bugs.webkit.org/show_bug.cgi?id=42405
774
775         Added ANGLE to webkit build
776
777         * Scripts/build-webkit:
778
779 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
780
781         [wx] Build fix, do not build WebCore as a convenience library as this leads to
782         errors in the Win build w/export symbols and causes problems with DOM bindings
783         debugging in gdb.
784
785         * DumpRenderTree/wscript:
786         * Scripts/build-webkit:
787         * wx/browser/wscript:
788         * wx/build/settings.py:
789         * wx/build/waf_extensions.py:
790
791 2010-08-16  Dan Bernstein  <mitz@apple.com>
792
793         Build fix.
794
795         * WebKitTestRunner/TestController.cpp:
796         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
797         (WTR::TestController::initialize): Ditto.
798
799 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
800
801         Reviewed by Kenneth Rohde Christiansen.
802
803         Handle content size change in WebKit2
804         Re-landing after fix.
805
806         https://bugs.webkit.org/show_bug.cgi?id=43198
807
808         * MiniBrowser/mac/BrowserWindowController.m:
809         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
810         * MiniBrowser/win/BrowserView.cpp:
811         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
812
813 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
814
815         Unreviewed, rolling out r65419.
816         http://trac.webkit.org/changeset/65419
817         https://bugs.webkit.org/show_bug.cgi?id=44053
818
819         Broke the Windows build (Requested by bbandix on #webkit).
820
821         * MiniBrowser/mac/BrowserWindowController.m:
822         (-[BrowserWindowController awakeFromNib]):
823         * MiniBrowser/win/BrowserView.cpp:
824         (BrowserView::create):
825
826 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
827
828         Reviewed by Kenneth Rohde Christiansen.
829
830         Handle content size change in WebKit2
831
832         https://bugs.webkit.org/show_bug.cgi?id=43198
833
834         * MiniBrowser/mac/BrowserWindowController.m:
835         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
836         * MiniBrowser/win/BrowserView.cpp:
837         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
838
839 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
840
841         Add my new email address to committers.py.
842
843         * Scripts/webkitpy/common/config/committers.py:
844
845 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
846
847         Add my old e-mail addresses to committers.py.
848
849         * Scripts/webkitpy/common/config/committers.py:
850
851 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
852
853         WebEditorClient::didBeginEditing is never called in WebKit2
854         https://bugs.webkit.org/show_bug.cgi?id=42939
855
856         Reviewed by Sam Weinig.
857
858         * WebKitTestRunner/PlatformWebView.h:
859         Declare focus().
860
861         * WebKitTestRunner/TestController.cpp:
862         (WTR::TestController::resetStateToConsistentValues):
863         Focus the PlatformWebView.
864
865         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
866         (WTR::PlatformWebView::focus):
867         Stubbed.
868
869         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
870         (WTR::PlatformWebView::focus):
871         Focus the view.
872
873 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
874
875         run-webkit-tests should not strip editing callbacks when using
876         WebKitTestRunner on Windows
877         https://bugs.webkit.org/show_bug.cgi?id=44000
878
879         Reviewed by Mark Rowe.
880
881         * Scripts/old-run-webkit-tests:
882         Leave $stripEditingCallbacks undefined until we look for command-line
883         arguments. If using WebKit2, set it to 0 if not explicity set on the
884         command line. Later, set it to isCygwin() to match old behavior if it is
885         not yet defined.
886
887 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
888
889         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
890
891         * wx/build/settings.py:
892
893 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
894
895         Reviewed by Kenneth Rohde Christiansen.
896
897         [GTK] autogen.sh not executed if build-webkit options change
898         https://bugs.webkit.org/show_bug.cgi?id=42266
899
900         Rerun autogen.sh in situations where the arguments to build-webkit have
901         changed since the previous build. This will fix some issues on the bots
902         where the build does not notice changes to default build-webkit arguments.
903
904         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
905
906 2010-08-14  Eric Seidel  <eric@webkit.org>
907
908         Unreviewed.  Another fix to support python 2.3.
909
910         Add support for MathML entities
911         https://bugs.webkit.org/show_bug.cgi?id=43949
912
913         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
914          - It looks like our simplejson is version 1.7.3 which
915            should be python 2.3 compatible.  But someone modified
916            our copy slightly from the original source.
917            I've removed the relative import in hopes this fixes
918            the problem.
919
920 2010-08-13  Eric Seidel  <eric@webkit.org>
921
922         Unreviewed.  Build fix only.
923
924         Add support for MathML entities
925         https://bugs.webkit.org/show_bug.cgi?id=43949
926
927         * Scripts/create-html-entity-table:
928          - Hack sys.path to avoid executing 2.5 dependent python
929            on systems (like chromium-win and Tiger) which do not have 2.5 python.
930
931 2010-08-13  Adam Barth  <abarth@webkit.org>
932
933         Reviewed by Eric Seidel.
934
935         Rename some concepts in HTML entity search to be more self-documenting
936         https://bugs.webkit.org/show_bug.cgi?id=44004
937
938         Reflect name change in generator script.
939
940         * Scripts/create-html-entity-table:
941
942 2010-08-12  Adam Barth  <abarth@webkit.org>
943
944         Reviewed by Eric Seidel.
945
946         Add support for MathML entities
947         https://bugs.webkit.org/show_bug.cgi?id=43949
948
949         A script for generating the C++ state data structure describing all the
950         entities from a JSON description.
951
952         * Scripts/create-html-entity-table: Added.
953
954 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
955
956         Reviewed by Eric Seidel.
957
958         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
959         check for exceptions on all threads, not just the first thread.
960         
961         This change also changes the logging behavior for wedged threads
962         to only dump the stacks of threads that are actually wedged.
963
964         Refactor the thread classes in the dump_render_tree_thread module
965         to make the contract between TestRunner and TestShellThread clearer.
966
967         Added a bunch of unit tests.
968         https://bugs.webkit.org/show_bug.cgi?id=38561
969
970         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
971         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
972         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
973
974 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
975
976         Reviewed by Shinichiro Hamaji.
977
978         Add test_expectations.txt syntax checker to check-webkit-style.
979         https://bugs.webkit.org/show_bug.cgi?id=43899
980
981         Just utilizing layout_tests/layout_package/test_expectations.py for checking
982         the syntax of test_expectations.txt.
983         This change also moves tab checking class from style/checkers/text.py to
984         style/checkers/common.py for sharing code.
985
986         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
987         * Scripts/webkitpy/style/checker.py:
988         * Scripts/webkitpy/style/checkers/common.py:
989         * Scripts/webkitpy/style/checkers/common_unittest.py:
990         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
991         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
992         * Scripts/webkitpy/style/checkers/text.py:
993         * Scripts/webkitpy/style_references.py:
994
995 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
996
997         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
998         https://bugs.webkit.org/show_bug.cgi?id=43945
999
1000         Reviewed by Sam Weinig.
1001
1002         * WebKitTestRunner/TestInvocation.cpp:
1003         (WTR::sizeWebViewForCurrentTest):
1004         Allow for a Windows-style path.
1005
1006         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1007         (WTR::PlatformWebView::resizeTo):
1008         Call SetWindowPos to resize the view window.
1009
1010 2010-08-12  David Levin  <levin@chromium.org>
1011
1012         Build break fix.
1013
1014         * WebKitTestRunner/TestController.cpp:
1015         (WTR::TestController::resetStateToConsistentValues): Removed usage
1016         of a variable that doesn't exist in the class.
1017
1018 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1019
1020         WebKitTestRunner needs to run tests without using native controls
1021         https://bugs.webkit.org/show_bug.cgi?id=43772
1022
1023         Reviewed by Sam Weinig.
1024
1025         * WebKitTestRunner/TestController.cpp:
1026         (WTR::TestController::initialize):
1027         Call platformInitializeContext().
1028
1029         * WebKitTestRunner/TestController.h:
1030         Declare platformInitializeContext().
1031
1032         * WebKitTestRunner/mac/TestControllerMac.mm:
1033         (WTR::TestController::platformInitializeContext):
1034         Stubbed.
1035
1036         * WebKitTestRunner/win/TestControllerWin.cpp:
1037         (WTR::TestController::platformInitializeContext):
1038         Call WKContextSetShouldPaintNativeControls() to disable native control
1039         drawing.
1040
1041 2010-08-12  Sam Weinig  <sam@webkit.org>
1042
1043         Reviewed by Alexey Proskuryakov.
1044
1045         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
1046         https://bugs.webkit.org/show_bug.cgi?id=43653
1047
1048         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1049         (WTR::InjectedBundle::InjectedBundle):
1050         (WTR::InjectedBundle::didReceiveMessage):
1051         (WTR::InjectedBundle::beginTesting):
1052         (WTR::InjectedBundle::done):
1053         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1054         (WTR::InjectedBundle::isTestRunning):
1055         (WTR::InjectedBundle::):
1056         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1057         (WTR::InjectedBundlePage::stopLoading):
1058         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1059         (WTR::InjectedBundlePage::dump):
1060         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1061         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1062         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1063         (WTR::InjectedBundlePage::didClearWindowForFrame):
1064         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1065         (WTR::InjectedBundlePage::willAddMessageToConsole):
1066         (WTR::InjectedBundlePage::willSetStatusbarText):
1067         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1068         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1069         (WTR::InjectedBundlePage::shouldBeginEditing):
1070         (WTR::InjectedBundlePage::shouldEndEditing):
1071         (WTR::InjectedBundlePage::shouldInsertNode):
1072         (WTR::InjectedBundlePage::shouldInsertText):
1073         (WTR::InjectedBundlePage::shouldDeleteRange):
1074         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1075         (WTR::InjectedBundlePage::shouldApplyStyle):
1076         (WTR::InjectedBundlePage::didBeginEditing):
1077         (WTR::InjectedBundlePage::didEndEditing):
1078         (WTR::InjectedBundlePage::didChange):
1079         (WTR::InjectedBundlePage::didChangeSelection):
1080         Don't do any work if we are not currently running a test.
1081
1082         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1083         * WebKitTestRunner/StringFunctions.h:
1084         (WTR::toCF):
1085         Add conversion function for WKURLRef -> CFURLRef
1086
1087         * WebKitTestRunner/TestController.cpp:
1088         (WTR::TestController::TestController):
1089         (WTR::TestController::initialize):
1090         (WTR::TestController::resetStateToConsistentValues):
1091         (WTR::TestController::runTest):
1092         (WTR::TestController::didFinishLoadForFrame):
1093         * WebKitTestRunner/TestController.h:
1094         (WTR::TestController::):
1095         * WebKitTestRunner/TestInvocation.cpp:
1096         (WTR::TestInvocation::invoke):
1097         * WebKitTestRunner/TestInvocation.h:
1098         Move resetting code to TestController.
1099
1100         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1101         * WebKitTestRunner/mac/TestControllerMac.mm:
1102         (WTR::TestController::runUntil):
1103         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1104         * WebKitTestRunner/win/TestControllerWin.cpp:
1105         (WTR::TestController::runUntil):
1106         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
1107         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1108         Move runUntil to TestController.
1109
1110 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1111
1112         Unreviewed.
1113
1114         Adding myself to the committers list.
1115
1116         * Scripts/webkitpy/common/config/committers.py:
1117
1118 2010-08-12  Hayato Ito  <hayato@chromium.org>
1119
1120         Reviewed by Tony Chang.
1121
1122         Merge pretty printers for gdb.
1123         https://bugs.webkit.org/show_bug.cgi?id=43850
1124
1125         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
1126         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
1127         webcore.py is left for backward compatibility.
1128
1129         * gdb/webcore.py:
1130         * gdb/webkit.py: Added.
1131         * gdb/wtf.py: Removed.
1132
1133 2010-08-11  Tony Chang  <tony@chromium.org>
1134
1135         Reviewed by David Levin.
1136
1137         [chromium] add google-chrome layout test result directories
1138         https://bugs.webkit.org/show_bug.cgi?id=43889
1139
1140         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1141         * Scripts/webkitpy/layout_tests/port/factory.py:
1142         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
1143         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1144
1145 2010-08-11  Kent Tamura  <tkent@chromium.org>
1146
1147         Reviewed by Dimitri Glazkov.
1148
1149         [DRT/Chromium] Disable accelerated compositing
1150         https://bugs.webkit.org/show_bug.cgi?id=43894
1151
1152         Disable accelerated compositing because DRT is not ready for
1153         it. This change fixes hundreds of test crashes on Windows and
1154         Linux.
1155
1156         * DumpRenderTree/chromium/TestShell.cpp:
1157         (TestShell::resetWebSettings):
1158
1159 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1160
1161         Unreviewed. Adding my Collabora personality to the list.
1162
1163         * Scripts/webkitpy/common/config/committers.py:
1164
1165 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
1166
1167         Adding myself as a reviewer.
1168
1169         * Scripts/webkitpy/common/config/committers.py:
1170
1171 2010-08-11  Daniel Bates  <dbates@rim.com>
1172
1173         Reviewed by Darin Adler.
1174
1175         Perl warnings when running commit-log-editor
1176         https://bugs.webkit.org/show_bug.cgi?id=43856
1177
1178         Fixes Perl warnings introduced by the patch for Bug #40548.
1179
1180         Perl doesn't have symbolic names for True/False. Instead, we
1181         should use boolean values. Moreover, the variable installedEditorApplication
1182         is not be used and should be renamed builtEditorApplication so that it
1183         uses the existing machinery to set the commit log editor application.
1184
1185         * Scripts/commit-log-editor:
1186
1187 2010-08-11  Adam Barth  <abarth@webkit.org>
1188
1189         Reviewed by Eric Seidel.
1190
1191         Trying waiting for httpd lock in the EWS
1192         https://bugs.webkit.org/show_bug.cgi?id=43833
1193
1194         If this works, we can probably run the tests on the mac-ews, which
1195         would be very exciting.  :)
1196
1197         * Scripts/webkitpy/tool/steps/runtests.py:
1198
1199 2010-08-11  Marcus Bulach  <bulach@chromium.org>
1200
1201         Reviewed by Eric Seidel.
1202
1203         Check in a script to list redundant test outputs.
1204         https://bugs.webkit.org/show_bug.cgi?id=37630
1205
1206         If e.g. platform/mac-leopard is missing an expected test output, we
1207         fall back on platform/mac.  This means it's possible to grow redundant
1208         test outputs, where we have the same expected data in both a platform
1209         directory and another platform it falls back on.
1210         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
1211
1212         * Scripts/deduplicate-tests: Added.
1213         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
1214         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
1215
1216 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1217
1218         Reviewed by Ariya Hidayat.
1219
1220         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
1221         https://bugs.webkit.org/show_bug.cgi?id=43853
1222
1223         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
1224         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
1225         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
1226         to slots at all.
1227
1228         * QtTestBrowser/launcherwindow.cpp:
1229         (LauncherWindow::createChrome):
1230         (LauncherWindow::animatedFlip):
1231         (LauncherWindow::animatedYFlip):
1232         * QtTestBrowser/launcherwindow.h:
1233
1234 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1235
1236         Reviewed by Simon Hausmann.
1237
1238         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
1239         https://bugs.webkit.org/show_bug.cgi?id=43851
1240
1241         All window options data (including the bool holding if the view is either QWebView or
1242         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
1243         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
1244         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
1245         getting broken.
1246
1247         Patch addresses this issue.
1248
1249         * QtTestBrowser/launcherwindow.cpp:
1250         (LauncherWindow::createChrome):
1251         (LauncherWindow::toggleWebView):
1252         (LauncherWindow::toggleAcceleratedCompositing):
1253
1254 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
1255
1256         Reviewed by Ariya Hidayat.
1257
1258         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
1259         https://bugs.webkit.org/show_bug.cgi?id=43831
1260
1261         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
1262
1263         * QtTestBrowser/webview.cpp:
1264         (WebViewGraphicsBased::WebViewGraphicsBased):
1265         (WebViewGraphicsBased::animatedYFlip):
1266
1267 2010-08-11  Darin Adler  <darin@apple.com>
1268
1269         Reviewed by John Sullivan.
1270
1271         Improved editor options for prepare-ChangeLog and commit-log-editor
1272         https://bugs.webkit.org/show_bug.cgi?id=40548
1273
1274         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
1275         values like "xed --launch --wait" work properly.
1276
1277         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
1278         use a command line tool with the $openChangeLogs feature.
1279
1280 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
1281
1282         Reviewed by Pavel Feldman.
1283
1284         Web Inspector: remove InjectDispatch.js
1285         https://bugs.webkit.org/show_bug.cgi?id=43835
1286
1287         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1288         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1289
1290 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
1291
1292         Reviewed by Eric Seidel.
1293
1294         webkit-patch should refuse to run under Win32 Python
1295         https://bugs.webkit.org/show_bug.cgi?id=40962
1296
1297         Given that there are lots of places in webkit-patch's code that
1298         assume unix-style filenames (forward slashes), webkit-patch fails
1299         with weird file-not-found errors when run under a native windows
1300         Python. It would be nice if we just trapped this and errored out
1301         at the beginning, rather than producing unpredictable errors.
1302
1303         * Scripts/webkit-patch:
1304
1305 2010-08-10  Kent Tamura  <tkent@chromium.org>
1306
1307         Unreviewed, build fix.
1308         
1309         Chromium build fix for r65107.
1310
1311         * DumpRenderTree/chromium/LayoutTestController.cpp:
1312         (LayoutTestController::suspendAnimations):
1313         (LayoutTestController::resumeAnimations):
1314
1315 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
1316
1317         Reviewed by Xan Lopez.
1318
1319         [GTK] http/tests/media/video-cookie.html fails
1320         https://bugs.webkit.org/show_bug.cgi?id=42240
1321
1322         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1323         (LayoutTestController::setAlwaysAcceptCookies): create the
1324         SoupCookieJar if it does not exist. Otherwise the accept policy
1325         won't be set.
1326
1327 2010-08-10  Chris Marrin  <cmarrin@apple.com>
1328
1329         Reviewed by Oliver Hunt.
1330
1331         Add suspendAnimations/resumeAnimation API to DRT
1332         https://bugs.webkit.org/show_bug.cgi?id=43733
1333         
1334         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
1335         Calls functions with the same names on AnimationController for the 
1336         mainFrame.
1337
1338         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1339         * DumpRenderTree/LayoutTestController.cpp:
1340         (suspendAnimationsCallback):
1341         (resumeAnimationsCallback):
1342         (LayoutTestController::staticFunctions):
1343         * DumpRenderTree/LayoutTestController.h:
1344         * DumpRenderTree/chromium/LayoutTestController.cpp:
1345         (LayoutTestController::LayoutTestController):
1346         (LayoutTestController::suspendAnimations):
1347         (LayoutTestController::resumeAnimations):
1348         * DumpRenderTree/chromium/LayoutTestController.h:
1349         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1350         (LayoutTestController::suspendAnimations):
1351         (LayoutTestController::resumeAnimations):
1352         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1353         (LayoutTestController::suspendAnimations):
1354         (LayoutTestController::resumeAnimations):
1355         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1356         (LayoutTestController::suspendAnimations):
1357         (LayoutTestController::resumeAnimations):
1358         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1359         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1360         (LayoutTestController::suspendAnimations):
1361         (LayoutTestController::resumeAnimations):
1362         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1363         (LayoutTestController::suspendAnimations):
1364         (LayoutTestController::resumeAnimations):
1365
1366 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1367
1368         Reviewed by Ojan Vafai.
1369
1370         [Chromium/DRT] Enable saving layout test results.
1371         https://bugs.webkit.org/show_bug.cgi?id=43796
1372
1373         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
1374             parameters to the new-run-webkit-tests, including the name
1375             of the test results server.
1376
1377 2010-08-10  Jian Li  <jianli@chromium.org>
1378
1379         More chromium build fix.
1380
1381         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1382         (MockSpellCheck::spellCheckWord):
1383         (MockSpellCheck::initializeIfNeeded):
1384         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1385         (NotificationPresenter::grantPermission):
1386         (NotificationPresenter::show):
1387         (NotificationPresenter::checkPermission):
1388
1389 2010-08-10  Jian Li  <jianli@chromium.org>
1390
1391         Chromium build fix.
1392
1393         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1394         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1395
1396 2010-08-10  Victor Wang  <victorw@chromium.org>
1397
1398         Reviewed by Ojan Vafai.
1399
1400         Update test results server merge logic so the aggregated
1401         results and times are updated for tests that are
1402         in aggragated json but not in incremental json.
1403
1404         Also update unittest to test this case.
1405
1406         https://bugs.webkit.org/show_bug.cgi?id=43769
1407
1408         * TestResultServer/model/jsonresults.py:
1409         * TestResultServer/model/jsonresults_unittest.py:
1410
1411 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1412
1413         Reviewed by Ariya Hidayat.
1414
1415         [Qt] QtTestBrowser: proper set scene rect
1416
1417         When resizesToContents is ON scene's rect is set to the boundary of
1418         the mainFrame. However, navigating to other web page should keep resizing
1419         scene's rect according to the new document loaded. Patch addresses this issue.
1420
1421         Now resizesToContents and scrolling properly work on QtTestBrowser.
1422
1423         * QtTestBrowser/webview.cpp:
1424         (WebViewGraphicsBased::setPage):
1425         (WebViewGraphicsBased::contentsSizeChanged):
1426         (WebViewGraphicsBased::setResizesToContents):
1427         (WebViewGraphicsBased::resizeEvent):
1428         * QtTestBrowser/webview.h:
1429
1430 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1431
1432         Reviewed by Ariya Hidayat.
1433
1434         [Qt] QtTestBrowser: Clean up LauncherWindow code.
1435
1436         * QtTestBrowser/launcherwindow.cpp:
1437         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
1438         (LauncherWindow::init): Fixed comments.
1439         (LauncherWindow::applyPrefs): Move the method around.
1440         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
1441
1442 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1443
1444         Reviewed by Ariya Hidayat.
1445
1446         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
1447
1448         It gets control+0 the same visual effect as control++ or control-.
1449
1450         * QtTestBrowser/launcherwindow.cpp:
1451         (LauncherWindow::toggleZoomTextOnly):
1452
1453 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1454
1455         Reviewed by Ariya Hidayat.
1456
1457         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
1458
1459         Not all instances of LauncherWindow need its own m_zoomLevel.
1460
1461         * QtTestBrowser/launcherwindow.cpp:
1462         * QtTestBrowser/launcherwindow.h:
1463
1464 2010-08-09  Sam Weinig  <sam@webkit.org>
1465
1466         Reviewed by Geoffrey Garen.
1467
1468         Add zoom support for injected bundle
1469         https://bugs.webkit.org/show_bug.cgi?id=43759
1470
1471         Use zoom factor SPI to implement zoom related eventSender functions.
1472
1473         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1474         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1475         (WTR::EventSendingController::textZoomIn):
1476         (WTR::EventSendingController::textZoomOut):
1477         (WTR::EventSendingController::zoomPageIn):
1478         (WTR::EventSendingController::zoomPageOut):
1479         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1480         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1481         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
1482
1483 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
1484
1485         Speculative chromium build fix III.
1486
1487         * DumpRenderTree/chromium/MockSpellCheck.h:
1488         * DumpRenderTree/chromium/NotificationPresenter.h:
1489         * DumpRenderTree/chromium/WebViewHost.h:
1490         (WebViewHost::addClearHeader):
1491         (WebViewHost::clearHeaders):
1492
1493 2010-08-09  Ojan Vafai  <ojan@chromium.org>
1494
1495         Reviewed by Tony Chang.
1496
1497         increase the number of test results that we save
1498         https://bugs.webkit.org/show_bug.cgi?id=43763
1499
1500         Now that we do incremental uploads, we can increase the number of
1501         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
1502
1503         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1504
1505 2010-08-09  Evan Martin  <evan@chromium.org>
1506
1507         Reviewed by Tony Chang.
1508
1509         [chromium] DRT error print statement incorrectly tries to print a FILE*
1510         https://bugs.webkit.org/show_bug.cgi?id=43747
1511
1512         * DumpRenderTree/chromium/ImageDiff.cpp:
1513         (writeFile): pass the correct pointer.
1514
1515 2010-08-09  Victor Wang  <victorw@chromium.org>
1516
1517         Reviewed by Ojan Vafai.
1518
1519         Upload incremental test results json to server by default.
1520
1521         https://bugs.webkit.org/show_bug.cgi?id=43743
1522
1523         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1524
1525 2010-08-09  Eric Seidel  <eric@webkit.org>
1526
1527         Reviewed by Adam Barth.
1528
1529         EWS bots wait 2 minutes between patches
1530         https://bugs.webkit.org/show_bug.cgi?id=43731
1531
1532         * Scripts/webkitpy/tool/bot/queueengine.py:
1533          - Don't sleep after failures.  This was a hold-over from
1534            an earlier design.
1535         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1536          - EWS bots were not properly reporting true/false from process_work_item.
1537            They were always returning None, thus false, thus always logging
1538            as a failure and sleeping 2 minutes after each patch.
1539
1540 2010-08-09  Sam Weinig  <sam@webkit.org>
1541
1542         Reviewed by Anders Carlsson.
1543
1544         Stub out EventSender for WebKitTestRunner
1545         https://bugs.webkit.org/show_bug.cgi?id=43703
1546
1547         * WebKitTestRunner/DerivedSources.make:
1548         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1549         Add ability to pass javascript arguments to the wrapped object.
1550
1551         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
1552         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
1553         (WTR::EventSendingController::create):
1554         (WTR::EventSendingController::EventSendingController):
1555         (WTR::EventSendingController::~EventSendingController):
1556         (WTR::EventSendingController::wrapperClass):
1557         (WTR::setExceptionForString):
1558         (WTR::EventSendingController::mouseDown):
1559         (WTR::EventSendingController::mouseUp):
1560         (WTR::EventSendingController::mouseMoveTo):
1561         (WTR::EventSendingController::keyDown):
1562         (WTR::EventSendingController::contextClick):
1563         (WTR::EventSendingController::leapForward):
1564         (WTR::EventSendingController::textZoomIn):
1565         (WTR::EventSendingController::textZoomOut):
1566         (WTR::EventSendingController::zoomPageIn):
1567         (WTR::EventSendingController::zoomPageOut):
1568         (WTR::EventSendingController::makeWindowObject):
1569         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
1570         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1571         (WTR::InjectedBundle::reset):
1572         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1573         (WTR::InjectedBundle::eventSendingController):
1574         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1575         (WTR::InjectedBundlePage::didClearWindowForFrame):
1576         Add stubbed out EventSenderController.
1577
1578         * WebKitTestRunner/InjectedBundle/GCController.h:
1579         Remove incorrect comment.
1580
1581         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1582         * WebKitTestRunner/win/InjectedBundle.vcproj:
1583         Add new files.
1584
1585 2010-08-08  Kent Tamura  <tkent@chromium.org>
1586
1587         Unreviewed, trivial fix.
1588
1589         Fix "WindowsError: [Error 32] The process cannot access the file
1590         because it is being used by another process" introduced by r64959.
1591
1592         * BuildSlaveSupport/test-result-archive:
1593
1594 2010-08-08  Kent Tamura  <tkent@chromium.org>
1595
1596         Reviewed by Tony Chang.
1597
1598         Chromium buildbot: Avoid "zip" command dependency
1599         https://bugs.webkit.org/show_bug.cgi?id=43470
1600
1601         * BuildSlaveSupport/test-result-archive:
1602          For Chromium port, creates a zip archive with zipfile package of Python
1603          instead of external "zip" command. We'd like to avoid additional
1604          command installation.
1605
1606 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
1607
1608         WebKitTestRunner should add the QuickTime dir to the PATH environment
1609         variable
1610         https://bugs.webkit.org/show_bug.cgi?id=43686
1611
1612         Reviewed by Dan Bernstein.
1613
1614         * WebKitTestRunner/win/TestControllerWin.cpp:
1615         (WTR::addQTDirToPATH):
1616         Copied from DRT.
1617         (WTR::TestController::platformInitialize):
1618         Call addQTDirToPath().
1619         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1620         Link to shlwapi.lib for SHGetValue.
1621
1622 2010-08-07  Sam Weinig  <sam@webkit.org>
1623
1624         Reviewed by Maciej Stachowiak.
1625
1626         WebKitTestRunner needs layoutTestController.dumpTitleChanges
1627         <rdar://problem/8213861>
1628         https://bugs.webkit.org/show_bug.cgi?id=42683
1629
1630         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1631         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1632         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1633         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1634         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1635         (WTR::LayoutTestController::LayoutTestController):
1636         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1637         (WTR::LayoutTestController::dumpTitleChanges):
1638         (WTR::LayoutTestController::shouldDumpTitleChanges):
1639
1640 2010-08-07  Sam Weinig  <sam@webkit.org>
1641
1642         Reviewed by Anders Carlsson.
1643
1644         WebKitTestRunner needs to print onunload handler information
1645         <rdar://problem/8213831>
1646         https://bugs.webkit.org/show_bug.cgi?id=42703
1647
1648         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1649         (WTR::operator<<):
1650         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1651
1652 2010-08-07  Sam Weinig  <sam@webkit.org>
1653
1654         Reviewed by Anders Carlsson.
1655
1656         Add additional loader client functions need to complete WebKitTestRunner
1657         https://bugs.webkit.org/show_bug.cgi?id=43684
1658
1659         Remove unnecessary and jarring underscores as well.
1660
1661         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1662         (didClearWindowObjectForFrame):
1663         (didCreatePage):
1664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1665         (WTR::InjectedBundlePage::InjectedBundlePage):
1666         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1667         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1668         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1669         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1670         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1671         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1672         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1673         (WTR::InjectedBundlePage::didClearWindowForFrame):
1674         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1675         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1676         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1677         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1678         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1679         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1680         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1681         (WTR::InjectedBundlePage::willAddMessageToConsole):
1682         (WTR::InjectedBundlePage::willSetStatusbarText):
1683         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1684         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1685         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1686         (WTR::InjectedBundlePage::shouldBeginEditing):
1687         (WTR::InjectedBundlePage::shouldEndEditing):
1688         (WTR::InjectedBundlePage::shouldInsertNode):
1689         (WTR::InjectedBundlePage::shouldInsertText):
1690         (WTR::InjectedBundlePage::shouldDeleteRange):
1691         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1692         (WTR::InjectedBundlePage::shouldApplyStyle):
1693         (WTR::InjectedBundlePage::didBeginEditing):
1694         (WTR::InjectedBundlePage::didEndEditing):
1695         (WTR::InjectedBundlePage::didChange):
1696         (WTR::InjectedBundlePage::didChangeSelection):
1697         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1698
1699 2010-08-07  Dan Bernstein  <mitz@apple.com>
1700
1701         Build fix.
1702
1703         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
1704         to JSGCController.{cpp,h} relative to the build root.
1705
1706 2010-08-07  Sam Weinig  <sam@webkit.org>
1707
1708         Reviewed by Anders Carlsson.
1709
1710         WebKitTestRunner needs GCController
1711         <rdar://problem/8213834>
1712         https://bugs.webkit.org/show_bug.cgi?id=42701
1713
1714         * WebKitTestRunner/DerivedSources.make:
1715         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
1716         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
1717         (WTR::setProperty):
1718         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
1719         (WTR::GCController::create):
1720         (WTR::GCController::GCController):
1721         (WTR::GCController::~GCController):
1722         (WTR::GCController::wrapperClass):
1723         (WTR::GCController::collect):
1724         (WTR::GCController::collectOnAlternateThread):
1725         (WTR::GCController::getJSObjectCount):
1726         (WTR::GCController::makeWindowObject):
1727         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
1728         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1729         (WTR::InjectedBundle::reset):
1730         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1731         (WTR::InjectedBundle::bundle):
1732         (WTR::InjectedBundle::gcController):
1733         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1734         (WTR::InjectedBundlePage::didClearWindowForFrame):
1735         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1736         (WTR::LayoutTestController::keepWebHistory):
1737         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1738         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1739         * WebKitTestRunner/win/InjectedBundle.vcproj:
1740
1741 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
1742
1743         WebKitTestRunner needs to be able to set the font smoothing type
1744         https://bugs.webkit.org/show_bug.cgi?id=43406
1745
1746         Reviewed by Adam Roben.
1747
1748         * WebKitTestRunner/TestInvocation.cpp:
1749         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1750         Set the font smoothing level to
1751         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
1752
1753 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
1754
1755         Fix a missed variable rename.
1756
1757         Unreviewed.
1758
1759         * Scripts/old-run-webkit-tests:
1760
1761 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
1762
1763         mac-wk2/Skipped should be used on Windows when running regression tests
1764         https://bugs.webkit.org/show_bug.cgi?id=43494
1765
1766         Reviewed by Adam Roben.
1767
1768         * Scripts/old-run-webkit-tests:
1769         If the platform is win-wk2, also read the mac-wk2 skipped list.
1770
1771 2010-08-06  Kent Tamura  <tkent@chromium.org>
1772
1773         Reviewed by Dimitri Glazkov.
1774
1775         [DRT/Chromium] Should revoke scheduled tasks
1776         https://bugs.webkit.org/show_bug.cgi?id=43560
1777
1778         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1779         (DRTDevToolsAgent::reset): Calls RevokeAll().
1780         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1781         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1782         (DRTDevToolsClient::reset): Calls RevokeAll().
1783         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1784         * DumpRenderTree/chromium/EventSender.cpp:
1785         (EventSender::reset): Calls RevokeAll().
1786         * DumpRenderTree/chromium/LayoutTestController.cpp:
1787         (LayoutTestController::reset): Calls RevokeAll().
1788         * DumpRenderTree/chromium/TestShell.cpp:
1789         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
1790
1791 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1792
1793         Reviewed by Antonio Gomes.
1794
1795         [Qt] Fix the DRT build on Mac OS X
1796
1797         * DumpRenderTree/qt/DumpRenderTree.pro:
1798
1799 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
1800
1801         Reviewed by Pavel Feldman.
1802
1803         Rietvield's upload.py moved to a different location.
1804         https://bugs.webkit.org/show_bug.cgi?id=43613
1805
1806         * Scripts/webkitpy/thirdparty/__init__.py:
1807
1808 2010-05-23  Eric Seidel  <eric@webkit.org>
1809
1810         Reviewed by Adam Barth.
1811
1812         QueueStatusServer needs better queue-status pages
1813         https://bugs.webkit.org/show_bug.cgi?id=39562
1814
1815         The primary goal of this patch is to display queue
1816         positions somewhere on the site so that it's easier
1817         for commit-queue users to know when their pach will
1818         be landed.  I also tried to improve the root page
1819         to be more useful than the previous wall of status text.
1820
1821         * QueueStatusServer/handlers/recentstatus.py:
1822         * QueueStatusServer/main.py:
1823         * QueueStatusServer/model/queues.py:
1824         * QueueStatusServer/templates/recentstatus.html:
1825
1826 2010-08-05  Victor Wang  <victorw@chromium.org>
1827
1828         Reviewed by Ojan Vafai.
1829
1830         Add option to generate/upload incremental json results to test result server.
1831         Also refactor the json results generator unittest code to test
1832         incremental and aggregated json results.
1833
1834         https://bugs.webkit.org/show_bug.cgi?id=43519
1835
1836         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1837         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1838         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1839         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1840
1841 2010-08-05  Jian Li  <jianli@chromium.org>
1842
1843         Reviewed by David Levin.
1844
1845         Unify blob related feature defines to ENABLE(BLOB).
1846         https://bugs.webkit.org/show_bug.cgi?id=43081
1847
1848         * Scripts/build-webkit:
1849
1850 2010-08-05  Satish Sampath  <satish@chromium.org>
1851
1852         Reviewed by Jeremy Orlow.
1853
1854         Add speech input controller mock in WebKit and a layout test.
1855         https://bugs.webkit.org/show_bug.cgi?id=43477
1856
1857         Added LayoutTestController::setMockSpeechInputResultCallback method.
1858
1859         * DumpRenderTree/LayoutTestController.cpp:
1860         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
1861         (LayoutTestController::staticFunctions):
1862         * DumpRenderTree/LayoutTestController.h:
1863         * DumpRenderTree/chromium/LayoutTestController.cpp:
1864         (LayoutTestController::LayoutTestController):
1865         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
1866         (LayoutTestController::speechInputController): Creates the mock controller.
1867         * DumpRenderTree/chromium/LayoutTestController.h:
1868         * DumpRenderTree/chromium/WebViewHost.cpp:
1869         (WebViewHost::speechInputController): Creates the mock controller.
1870         * DumpRenderTree/chromium/WebViewHost.h:
1871         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1872         (LayoutTestController::setMockSpeechInputResult): dummy method.
1873         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1874         (LayoutTestController::setMockSpeechInputResult): dummy method.
1875         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1876         (LayoutTestController::setMockSpeechInputResult): dummy method.
1877         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1878         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
1879         (LayoutTestController::setMockSpeechInputResult):
1880         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
1881         (LayoutTestController::setMockSpeechInputResult):
1882
1883 2010-08-04  Adam Roben  <aroben@apple.com>
1884
1885         Fix the path to TestNetscapePlugin's directory on Windows
1886
1887         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
1888         load TestNetscapePlugin
1889
1890         Reviewed by Jon Honeycutt.
1891
1892         * WebKitTestRunner/win/TestControllerWin.cpp:
1893         (WTR::TestController::initializeTestPluginDirectory):
1894         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
1895         next to WebKitTestRunner.exe. Previously we were passing the directory
1896         that contains WebKitTestRunner.exe. Also fixed some leaks.
1897
1898 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
1899
1900         Reviewed by Shinichiro Hamaji.
1901
1902         check-webkit-style returns non-zero when patch is entirely minus lines.
1903         https://bugs.webkit.org/show_bug.cgi?id=38169
1904
1905         * Scripts/check-webkit-style:
1906         Check whether a patch contains modified files that are entirely minus lines.
1907         * Scripts/webkitpy/style/filereader.py:
1908         Add a variable that holds number of files that contain only deleted lines.
1909         * Scripts/webkitpy/style/patchreader.py:
1910         Count up modified files that contain only deleted lines.
1911
1912 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
1913
1914         Reviewed by Yury Semikhatsky.
1915
1916         DevTools: get rid of delayed command dispatching on front-end side.
1917
1918         https://bugs.webkit.org/show_bug.cgi?id=43479
1919
1920         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1921         (DRTDevToolsAgent::detach):
1922         (DRTDevToolsAgent::frontendLoaded):
1923         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1924         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1925         (DRTDevToolsClient::~DRTDevToolsClient):
1926         (DRTDevToolsClient::sendFrontendLoaded):
1927         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1928
1929 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
1930
1931         Reviewed by Shinichiro Hamaji.
1932
1933         Fixes check-webkit-style false positive on "new uint32_t."
1934         https://bugs.webkit.org/show_bug.cgi?id=43077
1935
1936         * Scripts/webkitpy/style/checkers/cpp.py:
1937         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1938
1939 2010-08-04  Kent Tamura  <tkent@chromium.org>
1940
1941         Reviewed by Dimitri Glazkov.
1942
1943         [DRT/Chromium] Remove base/linked_ptr.h dependency
1944         https://bugs.webkit.org/show_bug.cgi?id=43472
1945
1946         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
1947         We need to use RefPtr<> because m_pendingEntry points an object in
1948         m_entries or not in m_entries.
1949
1950         * DumpRenderTree/chromium/TestNavigationController.cpp:
1951         (TestNavigationEntry::create): Added.
1952         (TestNavigationController::activeEntry):
1953         (TestNavigationController::didNavigateToEntry):
1954         (TestNavigationController::discardPendingEntry):
1955         (TestNavigationController::insertEntry):
1956         (TestNavigationController::navigateToPendingEntry):
1957         * DumpRenderTree/chromium/TestNavigationController.h:
1958         * DumpRenderTree/chromium/WebViewHost.cpp:
1959         (WebViewHost::loadURLForFrame):
1960          Use TestNavigationEntry::create().
1961         (WebViewHost::updateURL):
1962          Use RefPtr<>.
1963         (WebViewHost::updateSessionHistory):
1964          Remove unnecessary static_cast<>.
1965
1966 2010-08-04  Kent Tamura  <tkent@chromium.org>
1967
1968         Reviewed by Dimitri Glazkov.
1969
1970         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
1971         https://bugs.webkit.org/show_bug.cgi?id=43333
1972
1973         * BuildSlaveSupport/test-result-archive:
1974           - Make layoutTestResultsDir local and pass it to archiveTestResults()
1975           - Adjust layoutTestResultsDir for Chromium
1976
1977 2010-08-04  Kent Tamura  <tkent@chromium.org>
1978
1979         Reviewed by Dimitri Glazkov.
1980
1981         NRWT: websocket_server startup detection failure
1982         https://bugs.webkit.org/show_bug.cgi?id=43466
1983
1984         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1985          Increase timeout value: 5 second -> 10 second
1986
1987 2010-08-04  Victor Wang  <victorw@chromium.org>
1988
1989         Reviewed by Ojan Vafai.
1990
1991         -. Add result.json incremental merging functionality to test results app engine.
1992         -. blobstore is not suitable for AE data merging and there is no API to
1993            programatically edit existing blob or write a new one yet, so replace blobstore
1994            with datastore. If file is oversize (>1000*1000 bytes), store file data in
1995            multiple datastore entries.
1996         -. Fix styles.
1997
1998         Test: jsonresults_unittest to test merging logics.
1999
2000         https://bugs.webkit.org/show_bug.cgi?id=38599
2001
2002         * TestResultServer/handlers/dashboardhandler.py:
2003         * TestResultServer/handlers/menu.py:
2004         * TestResultServer/handlers/testfilehandler.py:
2005         * TestResultServer/main.py:
2006         * TestResultServer/model/dashboardfile.py:
2007         * TestResultServer/model/datastorefile.py: Added.
2008         * TestResultServer/model/jsonresults.py: Added.
2009         * TestResultServer/model/jsonresults_unittest.py: Added.
2010         * TestResultServer/model/testfile.py:
2011         * TestResultServer/templates/uploadform.html:
2012
2013 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2014
2015         Reviewed by Kenneth Christiansen.
2016
2017         [Qt] [QtTestBrowser] Remove unneeded QAction class members
2018         https://bugs.webkit.org/show_bug.cgi?id=43518
2019
2020         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
2021         m_flipYAnimated. Also, in initializeView method there are some dead code block
2022         trying to connect them at the wrong time, when they have not been instanciated.
2023
2024         This patch:
2025
2026         - removes the two cited class members in favor of local variables in createChrome method;
2027         - removes the dead code block.
2028
2029         * QtTestBrowser/launcherwindow.cpp:
2030         (LauncherWindow::LauncherWindow):
2031         (LauncherWindow::initializeView):
2032         (LauncherWindow::createChrome):
2033         * QtTestBrowser/launcherwindow.h:
2034
2035 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2036
2037         Reviewed by Simon Hausmann and Kenneth Christiansen.
2038
2039         [Qt] [QtTestBrowser] Clean up static and global menu state controls
2040         https://bugs.webkit.org/show_bug.cgi?id=43448
2041
2042         After LauncherWindow class was refactored out of from main.cpp, all global variables that
2043         were hanging in main.cpp became temporarily public static class members of newly added
2044         LauncherWindow class. This design was not properly handling the initial purpose of the
2045         global variables: newly created launcher windows should inherit the settings of the originating
2046         one.
2047
2048         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
2049         comprises all data needed to handling the goal described above.
2050
2051         * QtTestBrowser/launcherwindow.cpp:
2052         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
2053                                           holding all user settings configured in the menus and command line.
2054                                           It also receices an optional QGraphicsScene points in case we are doing
2055                                           a "Clone Window".
2056         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
2057                                 value.
2058         (LauncherWindow::initializeView): Ditto.
2059         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
2060         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
2061                                       apply the preferences is provided by m_userData.
2062         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
2063         (LauncherWindow::toggleResizesToContents): Ditto.
2064         (LauncherWindow::toggleWebGL): Ditto.
2065         (LauncherWindow::toggleFrameFlattening): Ditto.
2066         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
2067         (LauncherWindow::changeViewportUpdateMode): Ditto.
2068         (LauncherWindow::showFPS): Ditto.
2069         (LauncherWindow::newWindow): Changed to pass the userData.
2070         (LauncherWindow::cloneWindow): Ditto.
2071         * QtTestBrowser/launcherwindow.h:
2072         (WindowOptions::WindowOptions):
2073         * QtTestBrowser/main.cpp:
2074         (requiresGraphicsView):
2075         (LauncherApplication::handleUserOptions):
2076         (main):
2077
2078 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
2079
2080         [wx] Build fix for gcc not importing all symbols from convenience libraries.
2081         Works on 10.6 only for Mac until the build system is reworked. 
2082
2083         * wx/build/settings.py:
2084
2085 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
2086
2087         Reviewed by Simon Hausmann.
2088
2089         [Qt] Change wording in QtTestBrowser
2090         https://bugs.webkit.org/show_bug.cgi?id=43241
2091
2092         * QtTestBrowser/launcherwindow.cpp:
2093         (LauncherWindow::createChrome):
2094
2095 2010-08-04  Aaron Boodman  <aa@chromium.org>
2096
2097         Reviewed by Eric Seidel.
2098
2099         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
2100         https://bugs.webkit.org/show_bug.cgi?id=43460
2101
2102         * Scripts/prepare-ChangeLog:
2103
2104 2010-08-03  MORITA Hajime  <morrita@google.com>
2105
2106         Reviewed by Tony Chang.
2107
2108         [DRT] Assertion failed when drag and move a draggable element.
2109         https://bugs.webkit.org/show_bug.cgi?id=41695
2110
2111         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
2112         But Cocoa doesn't call mouseDragged() until dragging is done.
2113         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
2114         on UIDelegate failed when mouseDragged() is called during dragging.
2115         This change eliminated the mouseDragged() call when dragging begins,
2116         which is implicated by draggingInfo instance.
2117         
2118         * DumpRenderTree/mac/EventSendingController.mm:
2119         (-[EventSendingController mouseMoveToX:Y:]):
2120
2121         Test: fast/events/dragging-mouse-moves.html
2122         
2123 2010-08-02  Steve Block  <steveblock@google.com>
2124
2125         Reviewed by Alexey Proskuryakov.
2126
2127         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
2128         https://bugs.webkit.org/show_bug.cgi?id=40002
2129
2130         The code in LayoutTestController::setGeolocationPermission() was moved to
2131         setGeolocationPermissionCommon() to allow each port to provide its own
2132         implementation of setGeolocationPermission().
2133
2134         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
2135         new permission, so it can call back to WebCore if permission requests are in
2136         progress and are waiting for a response. A minor fix to the Mac
2137         MockGeolocationProvider was also required to make sure that the mock provider
2138         calls back to WebCore when it is first started.
2139
2140         For other ports, LayoutTestController::setGeolocationPermission() is not
2141         implemented.
2142
2143         * DumpRenderTree/LayoutTestController.cpp:
2144         (LayoutTestController::setGeolocationPermissionCommon):
2145         * DumpRenderTree/LayoutTestController.h:
2146         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2147         (LayoutTestController::setGeolocationPermission):
2148         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2149         (LayoutTestController::setGeolocationPermission):
2150         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2151         (-[MockGeolocationProvider registerWebView:]):
2152         * DumpRenderTree/mac/UIDelegate.h:
2153         * DumpRenderTree/mac/UIDelegate.mm:
2154         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2155         (-[UIDelegate setGeolocationPermission:]):
2156         (-[UIDelegate dealloc]):
2157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2158         (LayoutTestController::setGeolocationPermission):
2159         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2160         (LayoutTestController::setGeolocationPermission):
2161
2162 2010-08-03  Kent Tamura  <tkent@chromium.org>
2163
2164         Reviewed by Dimitri Glazkov.
2165
2166         [DRT/Chromium] Implement --testshell-startup-dialog
2167         https://bugs.webkit.org/show_bug.cgi?id=40616
2168
2169         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2170         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
2171         if it is specfied.
2172         * DumpRenderTree/chromium/TestShell.h:
2173           Declare openStartUpDialog().
2174         * DumpRenderTree/chromium/TestShellGtk.cpp:
2175         (openStartupDialog):
2176         * DumpRenderTree/chromium/TestShellMac.mm:
2177         (openStartupDialog):
2178         * DumpRenderTree/chromium/TestShellWin.cpp:
2179         (openStartupDialog):
2180
2181 2010-08-03  Kent Tamura  <tkent@chromium.org>
2182
2183         Reviewed by Dimitri Glazkov.
2184
2185         [DRT/Chromium] Remove dependency of base/md5.h
2186         https://bugs.webkit.org/show_bug.cgi?id=43403
2187
2188         * DumpRenderTree/chromium/TestShell.cpp:
2189         (TestShell::dumpImage): Use wtf/MD5.h
2190
2191 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2192
2193         Reviewed by David Kilzer.
2194
2195         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2196         https://bugs.webkit.org/show_bug.cgi?id=40627
2197
2198         Part 6 - LayoutTest and Cleanup
2199
2200           Allow tests to delete application caches and set application cache
2201           origin quotas, so they can be tested.
2202
2203         * DumpRenderTree/LayoutTestController.cpp:
2204         (LayoutTestController::LayoutTestController):
2205         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
2206         (clearAllApplicationCachesCallback): should delete all application caches.
2207         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
2208         (LayoutTestController::staticFunctions):
2209         * DumpRenderTree/LayoutTestController.h:
2210         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
2211         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
2212
2213           Mac implementation.
2214
2215         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2216         (LayoutTestController::clearAllApplicationCaches): delete application caches.
2217         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
2218         * DumpRenderTree/mac/UIDelegate.mm:
2219         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
2220         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
2221
2222           Stub implementations for other platforms.
2223
2224         * DumpRenderTree/chromium/LayoutTestController.cpp:
2225         (LayoutTestController::LayoutTestController):
2226         (LayoutTestController::clearAllApplicationCaches):
2227         (LayoutTestController::setApplicationCacheOriginQuota):
2228         * DumpRenderTree/chromium/LayoutTestController.h:
2229         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2230         (LayoutTestController::clearAllApplicationCaches):
2231         (LayoutTestController::setApplicationCacheOriginQuota):
2232         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2233         (LayoutTestController::clearAllApplicationCaches):
2234         (LayoutTestController::setApplicationCacheOriginQuota):
2235         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2236         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2237         (LayoutTestController::clearAllApplicationCaches):
2238         (LayoutTestController::setApplicationCacheOriginQuota):
2239         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2240         (LayoutTestController::clearAllApplicationCaches):
2241         (LayoutTestController::setApplicationCacheOriginQuota):
2242
2243 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2244
2245         Reviewed by David Kilzer.
2246
2247         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2248         https://bugs.webkit.org/show_bug.cgi?id=40627
2249
2250         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
2251
2252           Change old style calls to make use of the managers.
2253
2254         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2255         (LayoutTestController::setDatabaseQuota):
2256         * DumpRenderTree/mac/UIDelegate.mm:
2257         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2258
2259 2010-08-03  Mark Rowe  <mrowe@apple.com>
2260
2261         Add a new Leopard build slave to run the release tests.
2262
2263         * BuildSlaveSupport/build.webkit.org-config/config.json:
2264
2265 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
2266
2267         WebKitTestRunner needs to activate the Mac font ascent hack
2268         https://bugs.webkit.org/show_bug.cgi?id=43404
2269
2270         Reviewed by Darin Adler.
2271
2272         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2273         (WTR::InjectedBundle::initialize):
2274         Call WKBundleActivateMacFontAscentHack().
2275
2276 2010-08-03  Alex Milowski  <alex@milowski.com>
2277
2278         Reviewed by Beth Dakin.
2279
2280         Changed the default for MathML support so that is is enabled by default.
2281
2282         * Scripts/build-webkit:
2283
2284 2010-08-03  Sam Weinig  <sam@webkit.org>
2285
2286         Roll r64566 back in this time with all the overloads in place..
2287
2288         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2289         (WTR::InjectedBundlePage::shouldInsertNode):
2290         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2291         * WebKitTestRunner/StringFunctions.h:
2292         * WebKitTestRunner/TestInvocation.cpp:
2293         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2294         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2295         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2296
2297 2010-08-03  Sam Weinig  <sam@webkit.org>
2298
2299         Rollout r64566. It broke all the WebKit2 tests.
2300
2301         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2302         (WTR::operator<<):
2303         (WTR::InjectedBundlePage::shouldInsertNode):
2304         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2305         * WebKitTestRunner/StringFunctions.h: Removed.
2306         * WebKitTestRunner/TestInvocation.cpp:
2307         (WTR::createWKURL):
2308         (WTR::WKStringToUTF8):
2309         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2310         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2311         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2312
2313 2010-08-03  Sam Weinig  <sam@webkit.org>
2314
2315         Reviewed by Anders Carlsson.
2316
2317         WTR: Move all the utility functions for working with strings to a shared header.
2318         https://bugs.webkit.org/show_bug.cgi?id=43386
2319
2320         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2321         (WTR::InjectedBundlePage::shouldInsertNode):
2322         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2323         * WebKitTestRunner/StringFunctions.h: Added.
2324         * WebKitTestRunner/TestInvocation.cpp:
2325         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2326         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2327         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2328
2329 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
2330
2331         Reviewed by Kenneth Christiansen.
2332
2333         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
2334         https://bugs.webkit.org/show_bug.cgi?id=43168
2335
2336         QGraphicsWebView resizesToContents property has to work together with QWebPage's
2337         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
2338
2339         * QtTestBrowser/launcherwindow.cpp:
2340         (LauncherWindow::applyPrefs):
2341         * QtTestBrowser/webview.cpp:
2342         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
2343                                                       needed when toggle resizesToContents on/off.
2344         (WebViewGraphicsBased::resizeEvent):
2345         * QtTestBrowser/webview.h:
2346         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
2347         (WebViewGraphicsBased::customLayoutSize): Getter helper.
2348
2349 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
2350
2351         Unreviewed. Adding myself as committer.
2352
2353         * Scripts/webkitpy/common/config/committers.py:
2354
2355 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
2356
2357         Reviewed by Yury Semikhatsky.
2358
2359         Chromium DevTools: Get rid of DevTools RPC.
2360
2361         https://bugs.webkit.org/show_bug.cgi?id=43335
2362
2363         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2364         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
2365         (DRTDevToolsAgent::call):
2366         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2367         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
2368         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
2369         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2370         (DRTDevToolsClient::sendMessageToBackend):
2371         (DRTDevToolsClient::call):
2372         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2373
2374 2010-08-02  Kent Tamura  <tkent@chromium.org>
2375
2376         Reviewed by Dimitri Glazkov.
2377
2378         [DRT/Chromium] Remove dependencies to some Chromium headers
2379         https://bugs.webkit.org/show_bug.cgi?id=43396
2380
2381         * DumpRenderTree/chromium/CppVariant.h:
2382          Remove base/basictypes.h because webkit_support.h contains it.
2383         * DumpRenderTree/chromium/EventSender.cpp:
2384         (getCurrentEventTimeSec): Use new wrapper function.
2385         * DumpRenderTree/chromium/TestNavigationController.h:
2386          Remove base/basictypes.h because webkit_support.h contains it.
2387         * DumpRenderTree/chromium/TestShell.cpp:
2388         (dumpHistoryItem): Use new wrapper function.
2389         * DumpRenderTree/chromium/WebViewHost.cpp:
2390         (WebViewHost::cancelledError): Use new wrapper function.
2391         (WebViewHost::didFailResourceLoad): Use new wrapper function.
2392
2393 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2394
2395         Reviewed by Xan Lopez.
2396
2397         [GTK] DRT implement execCommand()
2398         https://bugs.webkit.org/show_bug.cgi?id=35351
2399
2400         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2401         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
2402         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
2403         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
2404
2405 2010-08-02  Sam Weinig  <sam@webkit.org>
2406
2407         Reviewed by Anders Carlsson.
2408
2409         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
2410
2411         * Scripts/old-run-webkit-tests:
2412
2413 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2414
2415         WebKitTestRunner needs to support loading custom fonts (via the
2416         WEBKIT_TESTFONTS environment variable)
2417         https://bugs.webkit.org/show_bug.cgi?id=42782
2418
2419         Reviewed by Adam Roben.
2420
2421         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2422         (WTR::fontsPath):
2423         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
2424         as this directory doesn't appear to be created anymore.
2425         (WTR::activateFonts):
2426         Loop through the fonts, and call AddFontResourceExW() for each.
2427
2428 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2429
2430         Restore the WebKitTestRunner.sln that was removed, and remove the
2431         correct one.
2432
2433         Rubber-stamped by Sam Weinig.
2434
2435         * WebKitTestRunner/WebKitTestRunner.sln: Added.
2436         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
2437
2438 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2439
2440         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
2441
2442         Remove the unused WebKitTestRunner.sln.
2443
2444         Reviewed by Sam Weinig.
2445
2446         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2447         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
2448         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
2449         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
2450         * WebKitTestRunner/win/WebKitTestRunner.sln:
2451
2452 2010-08-02  Sam Weinig  <sam@webkit.org>
2453
2454         Fix the windows build.
2455
2456         * WebKitTestRunner/win/main.cpp:
2457
2458 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
2459
2460         Add a Skipped list on Windows, and have run-webkit-tests respect it.
2461
2462         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
2463         there are zero tests failing
2464         https://bugs.webkit.org/show_bug.cgi?id=43374
2465
2466         Reviewed by Adam Roben.
2467
2468         * Scripts/old-run-webkit-tests:
2469         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
2470         win-wk2. When building the result hierarchy, if the platform is win-wk2,
2471         add it first to the list of platforms.
2472
2473 2010-08-02  Darin Adler  <darin@apple.com>
2474
2475         Reviewed by Sam Weinig.
2476
2477         WebKitTestRunner needs layoutTestController.setCanOpenWindows
2478         https://bugs.webkit.org/show_bug.cgi?id=42321
2479
2480         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
2481         https://bugs.webkit.org/show_bug.cgi?id=42779
2482
2483         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
2484         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
2485
2486         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2487         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
2488         waiting for the first call to didCreatePage.
2489         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
2490         is created. Put other pages into a map.
2491         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
2492         of the main page.
2493         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
2494         the main page.
2495         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
2496         closeOtherPages functions.
2497
2498         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2499         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
2500         the main page affect dumping.
2501         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
2502
2503         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2504         (WTR::LayoutTestController::LayoutTestController): Initialize the new
2505         m_shouldCloseExtraWindows member.
2506         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
2507         (WTR::LayoutTestController::windowCount): Added.
2508
2509         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2510         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
2511         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
2512         m_shouldCloseExtraWindows.
2513
2514         * WebKitTestRunner/TestController.cpp:
2515         (WTR::TestController::shared): Return a pointer to the shared copy, but
2516         don't allocate and leak it. This seemed cleaner than adding an explicit
2517         finalize call to go along with the explicit initialize call.
2518         (WTR::TestController::TestController): Added calls to the initialize and
2519         run function, which are now done automatically.
2520         (WTR::TestController::~TestController): Added, since it's called now.
2521         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
2522         (WTR::createOtherPage): Added. Used to create pages other than the main page.
2523         (WTR::TestController::initialize): Added code to set up createOtherPage.
2524         (WTR::TestController::run): Removed unused return value.
2525         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
2526         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
2527
2528         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2529         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
2530         to avoid releasing the window twice. Another way to handle it would be to
2531         remove the release, but this approach is slightly more robust because it works
2532         even if some other code calls the close method an extra time.
2533
2534         * WebKitTestRunner/mac/main.mm:
2535         (main): Use a stack-allocated TestController object instead of calling
2536         initalize and run on a globally allocated one.
2537
2538 2010-08-02  Tony Chang  <tony@chromium.org>
2539
2540         Reviewed by David Levin.
2541
2542         add myself to the reviewers list
2543         https://bugs.webkit.org/show_bug.cgi?id=43366
2544
2545         * Scripts/webkitpy/common/config/committers.py:
2546
2547 2010-08-02  Anders Carlsson  <andersca@apple.com>
2548
2549         Reviewed by Sam Weinig.
2550
2551         Cache JSNPObjects and fix bugs in the object map
2552         https://bugs.webkit.org/show_bug.cgi?id=43368
2553
2554         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
2555         wrap an NPObject that came from a plug-in that is now destroyed.
2556
2557         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2558         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2559         (PluginTest::Object::getProperty):
2560         (PluginTest::Object::NP_GetProperty):
2561         (PluginTest::Object::npClass):
2562         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
2563         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
2564         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2565         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
2566         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
2567         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2568         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2569         * GNUmakefile.am:
2570
2571 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2572
2573         Reviewed by Xan Lopez.
2574
2575         [Gtk] DOM listeners get wrong keycodes for some keys
2576         https://bugs.webkit.org/show_bug.cgi?id=35170
2577
2578         Add support to all event senders for simulating keypad insert
2579         and print screen keys.
2580
2581         * DumpRenderTree/chromium/EventSender.cpp:
2582         (EventSender::keyDown): Add support for generating keypad insert and print screen.
2583         * DumpRenderTree/gtk/EventSender.cpp:
2584         (keyDownCallback): Ditto.
2585         * DumpRenderTree/mac/EventSendingController.mm:
2586         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
2587         * DumpRenderTree/qt/EventSenderQt.cpp:
2588         (EventSender::keyDown): Ditto.
2589         * DumpRenderTree/win/EventSender.cpp:
2590         (keyDownCallback): Ditto.
2591
2592 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2593
2594         Build fix for building against development versions of GTK+. GTK 2.22
2595         has not yet been released, so these function definitions must be conditionalized
2596         on the development version.
2597
2598         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
2599
2600 2010-08-02  Tony Chang  <tony@chromium.org>
2601
2602         Reviewed by Kent Tamura.
2603
2604         [chromium] use ChromiumDriver on Linux when running webkit tests
2605         https://bugs.webkit.org/show_bug.cgi?id=43273
2606
2607         * Scripts/webkitpy/layout_tests/port/chromium.py:
2608
2609 2010-08-02  Kent Tamura  <tkent@chromium.org>
2610
2611         Reviewed by Dimitri Glazkov.
2612
2613         [DRT/Chromium] Always initialize GTK
2614         https://bugs.webkit.org/show_bug.cgi?id=43327
2615
2616         Call gtk_init() in order to fix plugin test crash.
2617
2618         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2619         (main): Pass argc/argv to platformInit().
2620         * DumpRenderTree/chromium/TestShell.h:
2621         * DumpRenderTree/chromium/TestShellGtk.cpp:
2622         (platformInit): Update parameters, call gtk_init().
2623         * DumpRenderTree/chromium/TestShellMac.mm:
2624         (platformInit): Update parameters.
2625         * DumpRenderTree/chromium/TestShellWin.cpp:
2626         (platformInit): Update parameters.
2627
2628 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
2629
2630         Reviewed by Simon Hausmann.
2631
2632         [Qt] Generate forwarding headers for WebKit2
2633
2634         https://bugs.webkit.org/show_bug.cgi?id=43336
2635
2636         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
2637
2638 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
2639
2640         Reviewed by Kent Tamura.
2641
2642         WebSocket server should start with SO_REUSEADDR
2643         https://bugs.webkit.org/show_bug.cgi?id=43329
2644
2645         Pulls in pywebsocket-0.5.2.
2646         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
2647         http://code.google.com/p/pywebsocket/source/detail?r=273
2648
2649         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
2650
2651 2010-08-01  Kent Tamura  <tkent@chromium.org>
2652
2653         Reviewed by Dimitri Glazkov.
2654
2655         [DRT/Chromium] Remove string_util.h dependency
2656         https://bugs.webkit.org/show_bug.cgi?id=43312
2657
2658         * DumpRenderTree/chromium/LayoutTestController.cpp:
2659         (LayoutTestController::pathToLocalResource):
2660          Use string::find() instead of StartsWithASCII().
2661         (LayoutTestController::cppVariantToInt32):
2662          Use strtol() instead of StringToNumber().
2663
2664 2010-08-01  Sam Weinig  <sam@webkit.org>
2665
2666         Reviewed by Anders Carlsson.
2667
2668         Add ability to reset frame names for WebKitTestRunner
2669         https://bugs.webkit.org/show_bug.cgi?id=43316
2670
2671         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2672         (WTR::InjectedBundle::reset):
2673         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2674         (WTR::InjectedBundlePage::reset):
2675         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2676
2677 2010-08-01  Anders Carlsson  <andersca@apple.com>
2678
2679         Reviewed by Sam Weinig.
2680
2681         Implement NPN_RemoveProperty
2682         https://bugs.webkit.org/show_bug.cgi?id=43315
2683
2684         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2685         Add NPRuntimeRemoveProperty.cpp
2686         
2687         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2688         (PluginTest::NPN_GetStringIdentifier):
2689         (PluginTest::NPN_GetIntIdentifier):
2690         (PluginTest::NPN_RemoveProperty):
2691         Add NPN_ helpers.
2692
2693         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2694         Support more NPClass functions.
2695
2696         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
2697         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
2698         Test for NPN_RemoveProperty.
2699
2700         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
2701         (NPRuntimeRemoveProperty::TestObject::invoke):
2702         Add a testRemoveProperty method.
2703
2704         (NPRuntimeRemoveProperty::NPP_GetValue):
2705         Return the test object.
2706
2707         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2708         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2709         * GNUmakefile.am:
2710         Add NPRuntimeRemoveProperty.cpp
2711
2712 2010-07-30  Anders Carlsson  <andersca@apple.com>
2713
2714         Reviewed by Sam Weinig.
2715
2716         Add an NPObject class template helper to TestNetscapePlugin
2717         https://bugs.webkit.org/show_bug.cgi?id=43288
2718
2719         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2720         Add some template magic to be able to figure out if a class has a member function of a given type.
2721
2722         (PluginTest::Object::create):
2723         Create an object.
2724
2725         (PluginTest::Object::invokeDefault):
2726         Add dummy function, this should never be called.
2727
2728         (PluginTest::Object::Object):
2729         Initialize m_pluginTest to 0.
2730
2731         (PluginTest::Object::~Object):
2732         Add virtual destructor.
2733
2734         (PluginTest::Object::NP_Allocate):
2735         Create a new object.
2736
2737         (PluginTest::Object::NP_Deallocate):
2738         Delete the object.
2739
2740         (PluginTest::Object::NP_InvokeDefault):
2741         Call invokeDefault.
2742
2743         (PluginTest::Object::npClass):
2744         Initialize the NPClass struct.
2745
2746         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
2747         (DocumentOpenInDestroyStream::NPP_DestroyStream):
2748         Move this inline.
2749
2750         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
2751         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
2752         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
2753         Use the PluginTest::Object class template.
2754
2755 2010-07-31  Sam Weinig  <sam@webkit.org>
2756
2757         Reviewed by Dan Bernstein.
2758
2759         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
2760         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
2761         due to SVGElements not having the innerText function.
2762
2763         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2764         (WTR::dumpFrameText):
2765
2766 2010-07-30  Sam Weinig  <sam@webkit.org>
2767
2768         Reviewed by Maciej Stachowiak.
2769
2770         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
2771         Add structured message passing from the injected bundle to UIProcess
2772
2773         * MiniBrowser/mac/AppDelegate.m:
2774         (didRecieveMessageFromInjectedBundle):
2775         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2776         (didClearWindowForFrame):
2777         (didRecieveMessage):
2778         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2779         (WTR::InjectedBundle::done):
2780         (WTR::InjectedBundle::didReceiveMessage):
2781         * WebKitTestRunner/TestController.cpp:
2782         (WTR::TestController::initialize):
2783         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2784         * WebKitTestRunner/TestController.h:
2785         * WebKitTestRunner/TestInvocation.cpp:
2786         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2787         * WebKitTestRunner/TestInvocation.h:
2788         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2789
2790 2010-07-30  Sam Weinig  <sam@webkit.org>
2791
2792         Reviewed by Anders Carlsson.
2793
2794         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
2795         Make WKArrayRef more usable.
2796
2797         Remove now unnecessary const_casts.
2798
2799         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2800         (WTR::dumpDescendantFrameScrollPositions):
2801         (WTR::dumpDescendantFramesText):
2802
2803 2010-07-30  Sam Weinig  <sam@webkit.org>
2804
2805         Reviewed by Anders Carlsson.
2806
2807         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
2808         Add first pass of structured message passing.
2809
2810         Update Minibrowser and WebKitTestRunner to work with the new post message
2811         function.
2812
2813         * MiniBrowser/mac/AppDelegate.m:
2814         (didRecieveMessageFromInjectedBundle):
2815         (-[BrowserAppDelegate init]):
2816         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2817         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2818         (didStartProvisionalLoadForFrame):
2819         (didReceiveServerRedirectForProvisionalLoadForFrame):
2820         (didFailProvisionalLoadWithErrorForFrame):
2821         (didCommitLoadForFrame):
2822         (didFinishLoadForFrame):
2823         (didFailLoadWithErrorForFrame):
2824         (didReceiveTitleForFrame):
2825         (didClearWindowForFrame):
2826         (didCreatePage):
2827         (willDestroyPage):
2828         (didRecieveMessage):
2829         (WKBundleInitialize):
2830         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2831         (WTR::InjectedBundle::_didReceiveMessage):
2832         (WTR::InjectedBundle::didReceiveMessage):
2833         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2834         * WebKitTestRunner/TestInvocation.cpp:
2835         (WTR::TestInvocation::invoke):
2836         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2837
2838 2010-07-30  Anders Carlsson  <andersca@apple.com>
2839
2840         Try to fix the layout test failures.
2841
2842         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2843         (webkit_test_plugin_get_value):
2844
2845 2010-07-29  Anders Carlsson  <andersca@apple.com>
2846
2847         Reviewed by Adam Roben.
2848
2849         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
2850         https://bugs.webkit.org/show_bug.cgi?id=43232
2851
2852         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2853         Add PluginScriptableNPObjectInvokeDefault.cpp.
2854
2855         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2856         Remove invokeDefault callback function.
2857
2858         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2859         (PluginTest::create):
2860         Move this to the top of the file.
2861
2862         (PluginTest::NPP_GetValue):
2863         Add default implementation.
2864
2865         (PluginTest::NPN_CreateObject):
2866         Add NPN_ wrapper.
2867
2868         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2869         (PluginTest::identifier):
2870         Add identifier getter.
2871
2872         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
2873         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
2874         Add "using namespace std".
2875
2876         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2877         (NPP_GetValue):
2878         Give PluginTest a chance to return a value.
2879
2880         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2881         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2882         * GNUmakefile.am:
2883         Add PluginScriptableNPObjectInvokeDefault.cpp.
2884         
2885         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2886         (webkit_test_plugin_get_value):
2887         Give PluginTest a chance to return a value.
2888
2889 2010-07-30  Steve Block  <steveblock@google.com>
2890
2891         Reviewed by Steve Block.
2892
2893         Add LayoutTestController methods to test DeviceOrientation
2894         https://bugs.webkit.org/show_bug.cgi?id=39589
2895
2896         * DumpRenderTree/LayoutTestController.cpp:
2897         (setMockDeviceOrientationCallback):
2898         (LayoutTestController::staticFunctions):
2899         * DumpRenderTree/LayoutTestController.h:
2900         * DumpRenderTree/chromium/LayoutTestController.cpp:
2901         (LayoutTestController::LayoutTestController):
2902         (LayoutTestController::setMockDeviceOrientation):
2903         * DumpRenderTree/chromium/LayoutTestController.h:
2904         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2905         (LayoutTestController::setMockDeviceOrientation):
2906         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2907         (LayoutTestController::setMockDeviceOrientation):
2908         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2909         (LayoutTestController::setMockDeviceOrientation):
2910         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2911         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2912         (LayoutTestController::setMockDeviceOrientation):
2913         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2914         (LayoutTestController::setMockDeviceOrientation):
2915         * Scripts/build-webkit:
2916
2917 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2918
2919         Reviewed by Kenneth Christiansen.
2920
2921         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
2922         https://bugs.webkit.org/show_bug.cgi?id=43209
2923
2924         When -resizes-to-content was being passed as a command line parameter it was simply
2925         not being set (although the corresponding menu item was marked as ON).
2926         User had to toggle the menu OFF and then ON again for it to take place.
2927
2928         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
2929         the command line, but not resizesToContents. Patch addresses that.
2930
2931         * QtTestBrowser/launcherwindow.cpp:
2932         (LauncherWindow::createChrome):
2933         (LauncherWindow::applyPrefs):
2934         (LauncherWindow::toggleResizesToContents):
2935         * QtTestBrowser/webview.h:
2936         (WebViewGraphicsBased::resizesToContents):
2937
2938 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
2939
2940         Rubber-stamped by Simon Fraser.
2941
2942         [Qt] QtTestBrowser: more method grouping and clean ups.
2943
2944         Moving blocks of code around. Basically grouping related methods close to each.
2945
2946         * QtTestBrowser/launcherwindow.cpp:
2947         (LauncherWindow::initializeView):
2948         (LauncherWindow::createChrome):
2949         (LauncherWindow::changeViewportUpdateMode):
2950         (LauncherWindow::showFPS):
2951         (LauncherWindow::newWindow):
2952         (LauncherWindow::cloneWindow):
2953         * QtTestBrowser/launcherwindow.h:
2954
2955 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2956
2957         Reviewed by Tor Arne Vestbø.
2958
2959         [QT][Symbian] QtTestBrowser missing location capabilities
2960         https://bugs.webkit.org/show_bug.cgi?id=43235
2961
2962         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
2963
2964         * QtTestBrowser/QtTestBrowser.pro:
2965
2966 2010-07-29  Anders Carlsson  <andersca@apple.com>
2967
2968         Add PluginTest.cpp
2969
2970         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2971
2972 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
2973
2974         Reviewed by Eric Seidel.
2975
2976         Update download URLs for python irclib package; the old URLs 
2977         pointed at a specific mirror host and not the general sourceforge
2978         URLs.
2979
2980         https://bugs.webkit.org/show_bug.cgi?id=43228
2981
2982         * Scripts/webkitpy/thirdparty/__init__.py:
2983
2984 2010-07-29  Anders Carlsson  <andersca@apple.com>
2985
2986         Fix typo.
2987
2988         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2989
2990 2010-07-29  Anders Carlsson  <andersca@apple.com>
2991
2992         Another attempt at fixing the Qt and GTK+ build.
2993
2994         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2995         (webkit_test_plugin_new_instance):
2996         (webkit_test_plugin_destroy_stream):
2997
2998 2010-07-29  Anders Carlsson  <andersca@apple.com>
2999
3000         Another build fix attempt.
3001
3002         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3003         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3004         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3005         (webkit_test_plugin_new_instance):
3006         * GNUmakefile.am:
3007
3008 2010-07-29  Anders Carlsson  <andersca@apple.com>
3009
3010         Try to fix Windows and Unix builds.
3011
3012         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3013         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3014         (webkit_test_plugin_new_instance):
3015         (webkit_test_plugin_destroy_stream):
3016
3017 2010-07-29  Anders Carlsson  <andersca@apple.com>
3018
3019         Reviewed by Sam Weinig.
3020
3021         Refactor TestNetscapePlugin so tests can be split in separate files
3022         https://bugs.webkit.org/show_bug.cgi?id=43220
3023
3024         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3025         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3026
3027         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3028         (pluginAllocate):
3029         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
3030
3031         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3032         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
3033         (PluginTest::PluginTest):
3034         Initialize m_npp and the test identifier.
3035         
3036         (PluginTest::createTestFunctions):
3037         Return the map from identifiers to createTest functions.
3038
3039         (PluginTest::registerCreateTestFunction):
3040         Insert the identifier and create function pair in the map.
3041
3042         (PluginTest::create):
3043         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
3044
3045         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
3046         (PluginTest::Register::Register):
3047         Helper class template for registering plug-in tests.
3048         
3049         (PluginTest::Register::create):
3050         Create a new test of the given type.
3051
3052         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
3053         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3054         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
3055
3056         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3057         (NPP_New):
3058         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
3059
3060         (NPP_DestroyStream):
3061         Call the plug-in test NPP_DestroyStream member function.
3062
3063         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3064         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3065
3066 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3067
3068         Unreviewed build fix.
3069
3070         Add missing second argument to assert_lint in new style checker tests.
3071
3072         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3073
3074 2010-07-29  Anders Carlsson  <andersca@apple.com>
3075
3076         Reviewed by Adam Roben.
3077
3078         check-webkit-style shouldn't complain about NPAPI functions
3079         https://bugs.webkit.org/show_bug.cgi?id=43211
3080
3081         Allow underscores in functions that start with NPN_, NPP_ or NP_.
3082
3083         * Scripts/webkitpy/style/checkers/cpp.py:
3084         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3085
3086 2010-07-29  Victor Wang  <victorw@chromium.org>
3087
3088         Unreviewed, rolling out r64270.
3089         http://trac.webkit.org/changeset/64270
3090         https://bugs.webkit.org/show_bug.cgi?id=39589
3091
3092         The patch breaks chromium webkit unittest
3093
3094         * DumpRenderTree/LayoutTestController.cpp:
3095         (LayoutTestController::staticFunctions):
3096         * DumpRenderTree/LayoutTestController.h:
3097         * DumpRenderTree/chromium/LayoutTestController.cpp:
3098         (LayoutTestController::LayoutTestController):
3099         * DumpRenderTree/chromium/LayoutTestController.h:
3100         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3101         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3102         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3103         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3104         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3105         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3106         * Scripts/build-webkit:
3107
3108 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3109
3110         Reviewed by Kenneth Christiansen.
3111
3112         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
3113         https://bugs.webkit.org/show_bug.cgi?id=43199
3114
3115         There is no sense in keeping WebPage method definitions in main.cpp once
3116         webpage.cpp already exists.
3117
3118         No behavior change.
3119
3120         * QtTestBrowser/main.cpp:
3121         * QtTestBrowser/webpage.cpp:
3122         (WebPage::createWindow):
3123         (WebPage::createPlugin):
3124
3125 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3126
3127         Reviewed by Kenneth Christiansen.
3128
3129         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
3130         https://bugs.webkit.org/show_bug.cgi?id=43170
3131
3132         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
3133         launcherwindow.{cpp|h}
3134
3135         No behavior change.
3136
3137         Also changed all global static variables (named "gXXX") from main.cpp to
3138         static public variables of the LauncherWindow class.
3139
3140         * QtTestBrowser/QtTestBrowser.pro:
3141         * QtTestBrowser/launcherwindow.cpp: Added.
3142         * QtTestBrowser/launcherwindow.h: Added.
3143         * QtTestBrowser/main.cpp:
3144         (LauncherApplication::handleUserOptions):
3145         (main):
3146
3147 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3148
3149         Reviewed by Xan Lopez.
3150
3151         Build fix for building against GTK+ 3.x. GSEAL requires that we
3152         access internals of the GdkDragContext via methods. For older versions
3153         of GTK+, define those methods.
3154
3155         * DumpRenderTree/gtk/EventSender.cpp:
3156         (gdk_drag_context_get_selected_action): Added.
3157         (gdk_drag_context_get_actions): Added.
3158         (dispatchEvent): Use the two new accessor methods.
3159
3160 2010-07-29  Adam Roben  <aroben@apple.com>
3161
3162         Always say "plugins directory" when referring to a directory
3163         containing one or more plugins
3164
3165         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
3166         directory" when it means "plugins directory"
3167
3168         Reviewed by John Sullivan.
3169
3170         * WebKitTestRunner/TestController.cpp:
3171         (WTR::TestController::initialize): Updated for rename.
3172
3173 2010-07-29  Adam Roben  <aroben@apple.com>
3174
3175         Always say "directory" when referring to a plugin directory
3176
3177         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
3178         when it means "plugin directory"
3179
3180         Reviewed by John Sullivan.
3181
3182         * WebKitTestRunner/TestController.cpp:
3183         (WTR::TestController::initialize): Updated for renames.
3184
3185         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
3186         m_testPluginDirectory.
3187         (WTR::TestController::testPluginDirectory): Renamed from
3188         testPluginPath.
3189
3190         * WebKitTestRunner/mac/TestControllerMac.mm:
3191         (WTR::TestController::initializeTestPluginDirectory):
3192         * WebKitTestRunner/win/TestControllerWin.cpp:
3193         (WTR::TestController::initializeTestPluginDirectory):
3194         Renamed from initializeTestPluginPath and updated for rename.
3195
3196 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3197
3198          Reviewed by Antonio Gomes.
3199
3200          Initialize all members of NPClass struct.
3201          https://bugs.webkit.org/show_bug.cgi?id=43193
3202
3203          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3204
3205 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3206
3207         Reviewed by Antonio Gomes.
3208
3209         Warning fix on platforms where XP_MACOSX is undefined.
3210         https://bugs.webkit.org/show_bug.cgi?id=43192
3211
3212         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3213         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
3214
3215 2010-07-29  Adam Roben  <aroben@apple.com>
3216
3217         Give find-included-framework-headers our standard license
3218
3219         * Scripts/find-included-framework-headers: Used the license from
3220         WebCore/LICENSE-APPLE.
3221
3222 2010-07-29  Adam Roben  <aroben@apple.com>
3223
3224         Speed up find-included-framework-headers
3225
3226         We only do one invocation of find now, no longer pipe to grep, and
3227         replace uniq with sort -u.
3228
3229         Also added a license header.
3230
3231         * Scripts/find-included-framework-headers:
3232
3233 2010-07-29  Steve Block  <steveblock@google.com>
3234
3235         Reviewed by Jeremy Orlow.
3236
3237         Add LayoutTestController methods to test DeviceOrientation
3238         https://bugs.webkit.org/show_bug.cgi?id=39589
3239
3240         * DumpRenderTree/LayoutTestController.cpp:
3241         (setMockDeviceOrientationCallback):
3242         (LayoutTestController::staticFunctions):
3243         * DumpRenderTree/LayoutTestController.h:
3244         * DumpRenderTree/chromium/LayoutTestController.cpp:
3245         * DumpRenderTree/chromium/LayoutTestController.h:
3246         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3247         (LayoutTestController::setMockDeviceOrientation):
3248         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3249         (LayoutTestController::setMockDeviceOrientation):
3250         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3251         (LayoutTestController::setMockDeviceOrientation):
3252         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3253         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3254         (LayoutTestController::setMockDeviceOrientation):
3255         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3256         (LayoutTestController::setMockDeviceOrientation):
3257         * Scripts/build-webkit:
3258
3259 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
3260
3261         Reviewed by Shinichiro Hamaji.
3262
3263         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
3264         check-webkit-style gives false positives in single-line functions.
3265
3266         * Scripts/webkitpy/style/checkers/cpp.py:
3267         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3268
3269 2010-07-28  Darin Adler  <darin@apple.com>
3270
3271         Reviewed by Sam Weinig.
3272
3273         WebKitTestRunner needs to support layoutTestController.execCommand
3274         <https://bugs.webkit.org/show_bug.cgi?id=42538>
3275
3276         WebKitTestRunner needs layoutTestController.isCommandEnabled
3277         <https://bugs.webkit.org/show_bug.cgi?id=42671>
3278
3279         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3280         Added execCommand and isCommandEnabled.
3281         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3282         (WTR::LayoutTestController::execCommand): Added.
3283         (WTR::LayoutTestController::isCommandEnabled): Added.
3284         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3285
3286 2010-07-28  Kent Tamura  <tkent@chromium.org>
3287
3288         Reviewed by Dimitri Glazkov.
3289
3290         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
3291         https://bugs.webkit.org/show_bug.cgi?id=43123
3292
3293         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
3294         which overrides test expectations only for DumpRenderTree, in
3295         order to manage what problems are investigated.
3296         This change will be reverted when we switch to DRT completely.
3297
3298         * Scripts/webkitpy/layout_tests/port/chromium.py:
3299          Add drt_expectations.txt content to the result of
3300          test_expectations_overrides() if --use-drt is specified.
3301
3302 2010-07-28  Brady Eidson  <beidson@apple.com>
3303
3304         Reviewed by Darin Adler.
3305
3306         First pass at visited link support for WK2
3307         https://bugs.webkit.org/show_bug.cgi?id=43157
3308
3309         * MiniBrowser/mac/AppDelegate.m:
3310         (didNavigateWithNavigationData):
3311         (didPerformClientRedirect):
3312         (didPerformServerRedirect):
3313         (didUpdateHistoryTitle):
3314         (populateVisitedLinks): Added for the new version of the HistoryClient.
3315         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
3316         
3317         * MiniBrowser/mac/BrowserWindowController.m:
3318         (-[BrowserWindowController awakeFromNib]):
3319
3320 2010-07-28  Robin Dunn  <robin@alldunn.com>
3321
3322         Reviewed by Kevin Ollivier.
3323
3324         Add DOM bindings support for wx port.
3325
3326         * DumpRenderTree/wscript:
3327         * wx/browser/wscript:
3328         * wx/build/settings.py:
3329
3330 2010-07-28  Tony Chang  <tony@chromium.org>
3331
3332         Reviewed by Kent Tamura.
3333
3334         [chromium] cleanup temp files left by Linux DRT
3335         https://bugs.webkit.org/show_bug.cgi?id=43062
3336
3337         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
3338         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
3339             by crashed DRTs
3340
3341 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
3342
3343         Rubber-stamped by Kenneth Christiansen.
3344
3345         More Developer menu items reordering.
3346
3347         Grouping related menu items together, visually and logically (in the code).
3348
3349         No behavior change.
3350
3351         * QtTestBrowser/main.cpp:
3352         (LauncherWindow::createChrome):
3353
3354 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
3355
3356         Reviewed by Ojan Vafai.
3357
3358         Add FILE_SYSTEM build flag for FileSystem API
3359         https://bugs.webkit.org/show_bug.cgi?id=42915
3360
3361         * Scripts/build-webkit:
3362
3363 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
3364
3365         Reviewed by David Levin.
3366
3367         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
3368         https://bugs.webkit.org/show_bug.cgi?id=43090
3369
3370         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
3371         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
3372
3373 2010-07-27  Kent Tamura  <tkent@chromium.org>
3374
3375         Unreviewed, trivial typo fix.
3376
3377         * Scripts/webkitpy/layout_tests/port/chromium.py:
3378           Fix a wrong method name committed by r64109.
3379
3380 2010-07-27  Sam Weinig  <sam@webkit.org>
3381
3382         Reviewed by Anders Carlsson.
3383
3384         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
3385         Clean up handling of strings at the WebKit2 API layer.
3386
3387         * MiniBrowser/mac/BrowserWindowController.m:
3388         (runJavaScriptAlert):
3389         (runJavaScriptConfirm):
3390         (runJavaScriptPrompt):
3391         (didNavigateWithNavigationData):
3392         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3393         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3394         (_didClearWindowForFrame):
3395
3396 2010-07-27  Ojan Vafai  <ojan@chromium.org>
3397
3398         Reviewed by Eric Seidel.
3399
3400         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
3401         https://bugs.webkit.org/show_bug.cgi?id=42984
3402
3403         squash and no_squash have been intentionally erroring for a couple weeks now.
3404         But post-commits was just broken. Just remove squash/no_squash.
3405
3406         * Scripts/webkitpy/tool/steps/abstractstep.py:
3407         * Scripts/webkitpy/tool/steps/options.py:
3408
3409 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
3410
3411         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
3412
3413         * wx/build/settings.py:
3414
3415 2010-07-27  Adam Roben  <aroben@apple.com>
3416
3417         Mac build fix
3418
3419         * MiniBrowser/mac/BrowserWindowController.m:
3420         (processDidExit):
3421         (-[BrowserWindowController awakeFromNib]):
3422         Added processDidExit support.
3423
3424 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
3425
3426         Rubber-stamped by Simon Hausmann.
3427
3428         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
3429
3430         Move some less useful menu items on Developers menu from the top to the bottom, so
3431         QGraphicsView menu goes to the top, and becomes more quickly accessible.
3432
3433         * QtTestBrowser/main.cpp:
3434         (LauncherWindow::createChrome):
3435
3436 2010-07-26  Adam Roben  <aroben@apple.com>
3437
3438         Fix the path to InjectedBundle.dll in Debug_Internal builds
3439
3440         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
3441         InjectedBundle.dll in the Debug_Internal configuration
3442
3443         Reviewed by Anders Carlsson.
3444
3445         * WebKitTestRunner/win/TestControllerWin.cpp:
3446         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
3447         suffix only in Debug_All builds.
3448
3449 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3450
3451         Reviewed by Darin Adler.
3452
3453         https://bugs.webkit.org/show_bug.cgi?id=42947
3454         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
3455         error. Without which dumpRenderTree crashes.
3456
3457         * Scripts/old-run-webkit-tests:
3458
3459 2010-07-27  Kent Tamura  <tkent@chromium.org>
3460
3461         Reviewed by Dimitri Glazkov.
3462
3463         https://bugs.webkit.org/show_bug.cgi?id=42956
3464         [DRT/Chromium] Fix "out of sync" assertion error
3465
3466         Fix an assertion error on Windows like the following:
3467         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
3468         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3469         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
3470
3471         * Scripts/webkitpy/layout_tests/port/chromium.py:
3472         If the url matches with "file:///[a-z]:", does case-ignore comparison.
3473         GURL capitalize the driver letter of a file: URL.
3474
3475 2010-07-26  Darin Adler  <darin@apple.com>
3476
3477         Reviewed by Sam Weinig.
3478
3479         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
3480         https://bugs.webkit.org/show_bug.cgi?id=42537
3481
3482         WebKitTestRunner needs layoutTestController.markerTextForListItem
3483         https://bugs.webkit.org/show_bug.cgi?id=42549
3484
3485         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3486         Fixed _paramterExpression typo. Improved support for string type as a
3487         return value, so we don't try to include DOMString.h and we can convert
3488         the string to a JSValue by calling JSValueMakeStringOrNull.
3489
3490         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
3491         Added JSValueMakeStringOrNull, used by the code generator.
3492
3493         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3494         Added counterValueForElementById and markerTextForListItem.
3495
3496         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3497         Moved constant to the top of the file.
3498         (WTR::toCF): Added. Converts strings to CFStringRef.
3499         (WTR::toWK): Added. Converts strings to WKStringRef.
3500         (WTR::toJS): Added. Converts strings to JSStringRef.
3501         (WTR::setProperty): Moved this function to the top of the file
3502         rather than having it down where it's used inside the class. Also
3503         renamed it so it's a separate function rather than an overload of
3504         JSObjectSetProperty.
3505         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
3506         Should move it somewhere we can share it.
3507         (WTR::propertyObject): Ditto.
3508         (WTR::getElementById): Added. Calls getElementById through the magic
3509         of JavaScript.
3510         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3511         Chagned to use toWK instead of four local variables.
3512         (WTR::LayoutTestController::counterValueForElementById): Added.
3513         Calls WKBundleFrameCopyCounterValue.
3514         (WTR::LayoutTestController::markerTextForListItem): Added.
3515         Calls WKBundleFrameCopyMarkerText.
3516
3517         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3518         Added counterValueForElementById and markerTextForListItem.
3519
3520 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
3521
3522         Reviewed by Gustavo Noronha Silva.
3523
3524         [GTK] The EventSender should support simulating drop events
3525         https://bugs.webkit.org/show_bug.cgi?id=39844
3526
3527         Add initial dropping support to the GTK+ EventSender.
3528
3529         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3530         (createWebView): Listen for some new drag-and-drop signals.
3531         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
3532         (dispatchEvent):
3533         Detect situations where a drag is either starting or ending and massage
3534         GTK+ into sending the appropriate signals to the WebView.
3535         (replaySavedEvents): Remove comment.
3536         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
3537         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
3538         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
3539         (dragFailedCallback): Disable the GTK+ drag failed animation.
3540         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
3541
3542 2010-07-26  Daniel Bates  <dbates@rim.com>
3543
3544         Reviewed by Darin Adler.
3545
3546         svn-unapply warns of uninitialized variable when unapplying
3547         a patch that describes an svn move operation
3548         https://bugs.webkit.org/show_bug.cgi?id=42036
3549
3550         Fixes Perl uninitialized variable warnings when un-applying
3551         a patch that moves a file.
3552
3553         * Scripts/svn-unapply:
3554           - Modified patch() so that it initializes $patch to the empty
3555             string when we don't have svnConvertedText (such as when
3556             reversing a diff that represents a svn copy/move operation).
3557
3558 2010-07-26  Sam Weinig  <sam@webkit.org>
3559
3560         Reviewed by Anders Carlsson.
3561
3562         Move some non-APIish functions into private headers.
3563
3564         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3565         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3566
3567 2010-07-26  Sam Weinig  <sam@webkit.org>
3568
3569         Reviewed by Anders Carlsson.
3570
3571         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
3572         Add prompt and confirm client functions to WebKit2
3573
3574         * MiniBrowser/mac/BrowserWindowController.m:
3575         (-[BrowserWindowController awakeFromNib]):
3576
3577 2010-07-26  Adam Roben  <aroben@apple.com>
3578
3579         Windows build fix
3580
3581         * MiniBrowser/MiniBrowser.vcproj:
3582         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3583         Removed empty attributes so the values will be picked up from the
3584         vsprops files. (Also removed a couple of attributes that accidentally
3585         duplicated values from the vsprops files.)
3586
3587 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
3588
3589         Rubber-stamped by Adam Roben.
3590         
3591         Touch MiniBrowser's stdafx to fix the build.
3592
3593         * MiniBrowser/win/stdafx.h:
3594
3595 2010-07-26  Hayato Ito  <hayato@chromium.org>
3596
3597         Reviewed by Shinichiro Hamaji.
3598
3599         Add pretty printer of WTF::Vector for GDB 7.
3600
3601         https://bugs.webkit.org/show_bug.cgi?id=40909
3602
3603         * gdb/wtf.py: Added.
3604
3605 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3606
3607         Reviewed by Simon Hausmann.
3608
3609         [Qt] Fix feature detection regexp
3610
3611         We were missing the last feature
3612
3613         * Scripts/webkitdirs.pm:
3614
3615 2010-07-25  Darin Adler  <darin@apple.com>
3616
3617         Reviewed by Dan Bernstein.
3618
3619         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
3620         https://bugs.webkit.org/show_bug.cgi?id=42326
3621
3622         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3623         Added dumpSelectionRect.
3624
3625         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3626         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
3627         does nothing because its purpose is to change pixel test output and
3628         we do not have pixel tests implemented yet.
3629
3630 2010-07-25  Darin Adler  <darin@apple.com>
3631
3632         Reviewed by Maciej Stachowiak.
3633
3634         WebKitTestRunner needs to support layoutTestController.keepWebHistory
3635         https://bugs.webkit.org/show_bug.cgi?id=42323
3636
3637         Added keepWebHistory and computedStyleIncludingVisitedInfo.
3638
3639         Also fixed misspellings of the word "receive".
3640
3641         Also tweaked the names of some of the LayoutTestController members.
3642
3643         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3644         Added support for a type named "object" that is passed and returns as
3645         a JSValueRef.
3646
3647         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3648         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
3649         put setAcceptsEditing up nearer the top.
3650
3651         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3652         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
3653         (WTR::InjectedBundle::initialize): Ditto.
3654         (WTR::InjectedBundle::didReceiveMessage): Ditto.
3655         (WTR::InjectedBundle::reset): Reset the state of visited links between
3656   &