WebKitTools/ChangeLog

   1 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
   2
   3         Reviewed by Tony Chang.
   4
   5         nrwt multiprocessing - move logic back into run_webkit_tests
   6
   7         This change moves a bunch of logic that I had put into
   8         message_broker back into run_webkit_tests, in a slightly
   9         different format. WorkerMessageBroker needed to become less aware of
  10         the logic the TestRunner class uses, and more generic.
  11         Eventually the MessageBroker will only do generic messaging and
  12         thread/process-pooling, and (almost) all of the
  13         run-webkit-tests-specific logic will be moved to
  14         run_webkit_tests.py and dump_render_tree_thread.py.
  15
  16         The biggest changes are that the Broker can now start a single
  17         worker, but the responsibility for starting all of them is pushed
  18         back to the TestRunner (Manager), and the logic for checking if
  19         the threads are done or wedged is moved back to TestRunner. We
  20         also remove WorkerMessageBroker.cleanup (not needed) and
  21         cancel_workers (they have to be cancelled individually).
  22
  23         The  message_broker is now encapsulated inside
  24         TestRunner._run_tests(); it only needs to exist while actually
  25         running the tests.
  26
  27         Also, delete a bunch of tests in message_broker_unittest that no
  28         longer make much sense.
  29
  30         This patch depends on bug 50372.
  31
  32         https://bugs.webkit.org/show_bug.cgi?id=50374
  33
  34         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  35         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  36         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
  37         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  38         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  39
  40 2010-12-02  Hayato Ito  <hayato@chromium.org>
  41
  42         Reviewed by Eric Seidel.
  43
  44         Refactor test_types's compare_output() method so that it takes a
  45         TestInput object.
  46
  47         compare_output() will need additional information included in a TestInput
  48         object to support reftests. This change is a pre-requirement of that.
  49
  50         https://bugs.webkit.org/show_bug.cgi?id=50362
  51
  52         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  53         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  54         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  55         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
  56         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  57
  58 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
  59
  60         Reviewed by Anders Carlsson.
  61
  62         Add the ability to run script on 'new' and 'paint' in the test plugin
  63         https://bugs.webkit.org/show_bug.cgi?id=50425
  64
  65         Add "onnew" and "onpaintevent" attributes to the test plugin,
  66         so that tests can run JS at these times.
  67
  68         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  69         (pluginAllocate):
  70         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  71         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  72         (NPP_New):
  73         (NPP_Destroy):
  74         (handleEventCarbon):
  75         (handleEventCocoa):
  76         (NPP_HandleEvent):
  77
  78 2010-12-02  Sam Weinig  <sam@webkit.org>
  79
  80         Fix Qt build.
  81
  82         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  83         (WTR::PlatformWebView::PlatformWebView):
  84
  85 2010-12-02  Sam Weinig  <sam@webkit.org>
  86
  87         Reviewed by Anders Carlsson.
  88
  89         WebKit2 Preferences should be held off the PageGroup, not the Context
  90         https://bugs.webkit.org/show_bug.cgi?id=50414
  91
  92         Update for API changes.
  93
  94         * WebKitTestRunner/PlatformWebView.h:
  95         * WebKitTestRunner/TestController.cpp:
  96         (WTR::createOtherPage):
  97         (WTR::TestController::initialize):
  98         (WTR::TestController::resetStateToConsistentValues):
  99         * WebKitTestRunner/TestController.h:
 100         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 101         (WTR::PlatformWebView::PlatformWebView):
 102         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
 103         (WTR::PlatformWebView::PlatformWebView):
 104
 105 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
 106
 107         Reviewed by Tony Chang.
 108
 109         new-run-webkit-tests: minor cleanup for multiprocessing work
 110
 111         This change:
 112         * moves worker naming into TestShellThread, eliminating a
 113           parameter to the constructor and putting the responsibility in
 114           the correct place.
 115         * eliminates the _WorkerState() class in message_broker, because
 116           it turns out that state really needs to be in run_webkit_tests
 117         * renames the Broker classes to be module-private.
 118         * fixes a bunch of minor commenting and whitespace issues to
 119           make subsequent patches a bit clearer.
 120         * Adds a Port hook for default_worker_model() so that we can
 121           accomodate the potential for different worker models on
 122           different ports.
 123         * merge in the fix from 50420 for the brokenness introduced in
 124           bug 50367.
 125
 126         This patch depends on bug 50367.
 127
 128         https://bugs.webkit.org/show_bug.cgi?id=50372
 129
 130         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 131         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 132         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
 133         * Scripts/webkitpy/layout_tests/port/base.py:
 134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 135         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 136
 137 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
 138
 139         Reviewed by Tony Chang.
 140
 141         This change is a bunch of cleanup / refactoring of the file
 142         below. It moves a bunch of free functions to methods on the
 143         TestShellThread class, and restructures other methods to be
 144         closer to the structure we'll need for the multiprocessing
 145         rewrite.
 146
 147         It also makes the logic of --run-singly a *lot* easier to follow
 148         by nestling all of the separate-thread logic into a single
 149         routine.
 150
 151         There should be no semantic changes in this patch, just cleanup.
 152
 153         https://bugs.webkit.org/show_bug.cgi?id=50367
 154
 155         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 156
 157 2010-12-02  Tony Chang  <tony@chromium.org>
 158
 159         Unreviewed, rolling out r73164.
 160         http://trac.webkit.org/changeset/73164
 161         https://bugs.webkit.org/show_bug.cgi?id=50359
 162
 163         broke debugger tests on win
 164
 165         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 166
 167 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
 168
 169         Reviewed by Tony Chang.
 170
 171         Rebaseline server: add updating of baselines
 172         https://bugs.webkit.org/show_bug.cgi?id=50305
 173
 174         Implements updating of baselines, where we copy -actual.* files over
 175         the current -expected.* files. To do this, we need a
 176         _get_actual_result_files method to get test results files and a
 177         _rebaseline_test method to actually do the file copy and SCM operation.
 178         _rebaseline_test logs output into a buffer, this is useful for both
 179         showing result in the UI and for unit tests.
 180
 181         To make passing around of the various test environment properties
 182         (results directory, filesystem, SCM, etc) easier, add a TestConfig
 183         class for them.
 184
 185         Moving of existing baselines is not implemented yet, this patch is big
 186         enough as it is.
 187
 188         * Scripts/webkitpy/common/system/filesystem.py:
 189         * Scripts/webkitpy/common/system/filesystem_mock.py:
 190         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
 191         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
 192         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
 193         * Scripts/webkitpy/tool/mocktool.py:
 194
 195 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
 196
 197         Unreviewed build fix after vcproj updates.
 198
 199         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
 200         that WIN_CAIRO is defined for this build.
 201         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
 202         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
 203         (these were previously 'Debug_Cairo' and 'Release_Cairo'
 204
 205 2010-12-02  Sam Weinig  <sam@webkit.org>
 206
 207         Reviewed by Anders Carlsson.
 208
 209         WebKit2 needs API to turn on popup blocking
 210         https://bugs.webkit.org/show_bug.cgi?id=50407
 211
 212         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
 213         (TestWebKitAPI::TEST):
 214         * WebKitTestRunner/TestController.cpp:
 215         (WTR::TestController::resetStateToConsistentValues):
 216
 217 2010-12-01  Tony Chang  <tony@chromium.org>
 218
 219         Reviewed by Ojan Vafai.
 220
 221         [chromium] force NRWT to use DRT
 222         https://bugs.webkit.org/show_bug.cgi?id=50359
 223
 224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 225
 226 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
 227
 228         Reviewed by Xan Lopez.
 229
 230         [GTK] DumpRenderTree has two copies of JavaScriptCore
 231         https://bugs.webkit.org/show_bug.cgi?id=49877
 232
 233         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
 234         LDADD list for DumpRenderTree.
 235
 236 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
 237
 238         Unreviewed: Added myself to list of Committers.
 239
 240         * Scripts/webkitpy/common/config/committers.py:
 241
 242 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
 243
 244         Reviewed by Adam Barth.
 245
 246         build-webkit --chromium always updates DEPS and re-generates project files
 247         https://bugs.webkit.org/show_bug.cgi?id=50340
 248
 249         Make build-webkit --chromium invoke update-webkit-chromium only when
 250         --update-chromium is passed in, so that we don't add 20 seconds to all
 251         builds.
 252
 253         Making all invocations update was added with r61883, with the goal of
 254         making EWS bots always update. The bots will switch to using this flag
 255         (as will all other webkit-patch build steps) so nothing should change
 256         for them.
 257
 258         * Scripts/webkitdirs.pm:
 259         * Scripts/webkitpy/common/config/ports.py:
 260         * Scripts/webkitpy/common/config/ports_unittest.py:
 261
 262 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
 263
 264         Reviewed by Tony Chang.
 265
 266         new-run-webkit-tests: add a --dry-run / -n flag
 267         https://bugs.webkit.org/show_bug.cgi?id=50045
 268
 269         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 270         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 271
 272 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
 273
 274         Reviewed by Adam Roben.
 275
 276         WinCairo build should not use link-time code generation (LTCG)
 277         https://bugs.webkit.org/show_bug.cgi?id=50353
 278
 279         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 280         * DumpRenderTree/win/DumpRenderTree.vcproj:
 281         * DumpRenderTree/win/ImageDiff.vcproj:
 282         * FindSafari/FindSafari.vcproj:
 283         * MiniBrowser/MiniBrowser.vcproj:
 284         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
 285         * WebKitAPITest/WebKitAPITest.vcproj:
 286         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
 287         * WebKitTestRunner/win/InjectedBundle.vcproj:
 288         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
 289         * WinLauncher/WinLauncher.vcproj:
 290         * record-memory-win/record-memory-win.vcproj:
 291
 292 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
 293
 294         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
 295         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
 296         adding the file to the sources list was not enough to force the rebuild.
 297
 298         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
 299         Remove an empty line at the end of this file to force a rebuild.
 300
 301 2010-12-01  Sam Weinig  <sam@webkit.org>
 302
 303         Fix windows build.
 304
 305         * MiniBrowser/win/BrowserView.cpp:
 306         (BrowserView::create):
 307
 308 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
 309
 310         Add missing file to the TestNetscapePlugin sources list after r73057.
 311
 312         * GNUmakefile.am: Add missing file.
 313
 314 2010-12-01  Sam Weinig  <sam@webkit.org>
 315
 316         Reviewed by Anders Carlsson.
 317
 318         Add PageGrouping to WebKit2 API
 319         https://bugs.webkit.org/show_bug.cgi?id=50332
 320
 321         - Update testing harnesses to deal with new PageGroup API.
 322
 323         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
 324         (WKBundleInitialize):
 325         * TestWebKitAPI/InjectedBundleController.cpp:
 326         (TestWebKitAPI::InjectedBundleController::initialize):
 327         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
 328         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
 329         * TestWebKitAPI/InjectedBundleController.h:
 330         * TestWebKitAPI/InjectedBundleTest.h:
 331         (TestWebKitAPI::InjectedBundleTest::initialize):
 332         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
 333         * TestWebKitAPI/PlatformUtilities.cpp:
 334         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
 335         * TestWebKitAPI/PlatformUtilities.h:
 336         * TestWebKitAPI/PlatformWebView.h:
 337         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
 338         (TestWebKitAPI::TEST):
 339         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
 340         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
 341         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 342         (TestWebKitAPI::PlatformWebView::PlatformWebView):
 343         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
 344         (TestWebKitAPI::PlatformWebView::PlatformWebView):
 345         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 346         (WTR::InjectedBundle::didInitializePageGroup):
 347         (WTR::InjectedBundle::initialize):
 348         (WTR::InjectedBundle::beginTesting):
 349         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 350         (WTR::InjectedBundle::pageGroup):
 351         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 352         (WTR::LayoutTestController::addUserScript):
 353         (WTR::LayoutTestController::addUserStyleSheet):
 354         (WTR::LayoutTestController::setXSSAuditorEnabled):
 355         * WebKitTestRunner/TestController.cpp:
 356         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
 357         (WTR::PlatformWebView::PlatformWebView):
 358
 359 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
 360
 361         Reviewed by Adam Roben.
 362
 363         vcproj changes can't be applied cleanly by the Windows EWS bot
 364         https://bugs.webkit.org/show_bug.cgi?id=50328
 365
 366         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
 367         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
 368         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
 369         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
 370         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
 371         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
 372         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
 373         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
 374         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
 375         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
 376         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
 377         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
 378         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
 379         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
 380         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
 381         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
 382         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
 383         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
 384         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
 385         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
 386         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
 387         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
 388         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
 389         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
 390         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
 391         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
 392         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
 393         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
 394         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
 395         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
 396         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
 397         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
 398         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
 399         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
 400         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
 401         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
 402         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
 403         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
 404         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
 405         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
 406         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
 407         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
 408         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
 409         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
 410         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
 411
 412 2010-12-01  Anders Carlsson  <andersca@apple.com>
 413
 414         Reviewed by Darin Adler.
 415
 416         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
 417         https://bugs.webkit.org/show_bug.cgi?id=50336
 418
 419         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 420         Add new test.
 421
 422         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
 423         (PluginTest::NPP_New):
 424         Add default implementation/
 425
 426         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
 427         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
 428         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
 429         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
 430         Get the user agent.
 431
 432         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 433         (NPP_New):
 434         Call PluginTest::NPP_New.
 435
 436         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 437         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 438         Add new files.
 439
 440         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 441         (webkit_test_plugin_new_instance):
 442         Call PluginTest::NPP_New.
 443
 444 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
 445
 446         [wx] Build fixes after recent trunk changes.
 447
 448         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 449         (LayoutTestController::findString):
 450         * wx/build/settings.py:
 451
 452 2010-12-01  Dan Bernstein  <mitz@apple.com>
 453
 454         Reviewed by Darin Adler.
 455
 456         WebKitTestRunner needs layoutTestController.findString
 457         https://bugs.webkit.org/show_bug.cgi?id=50238
 458
 459         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
 460         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 461         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
 462         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
 463
 464 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
 465
 466         Try using svn:eol-style native on a vcproj file.
 467
 468         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
 469
 470 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
 471
 472         Reviewed by Adam Roben.
 473
 474         [WINCE] Add WinCELauncher
 475         https://bugs.webkit.org/show_bug.cgi?id=50217
 476
 477         * WinCELauncher/main.cpp: Added.
 478
 479 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
 480
 481         Reviewed by Kenneth Rohde Christiansen.
 482
 483         [Qt] Implement layoutTestController.findString
 484         https://bugs.webkit.org/show_bug.cgi?id=50236
 485
 486         Add the missing function to the LayoutTestController.
 487
 488         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 489         (LayoutTestController::findString):
 490         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 491
 492 2010-11-30  Tony Chang  <tony@chromium.org>
 493
 494         Reviewed by Adam Barth.
 495
 496         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
 497         https://bugs.webkit.org/show_bug.cgi?id=49036
 498
 499         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
 500             for CppVariants.
 501         (LayoutTestController::cppVariantToBool):
 502         (LayoutTestController::cppVariantToInt32):
 503         (LayoutTestController::setDatabaseQuota):
 504         (LayoutTestController::evaluateInWebInspector):
 505         (LayoutTestController::setMockGeolocationError):
 506
 507 2010-11-30  Eric Seidel  <eric@webkit.org>
 508
 509         Reviewed by Tony Chang.
 510
 511         update-webkit should call git fetch before git svn rebase
 512         https://bugs.webkit.org/show_bug.cgi?id=50273
 513
 514         After discussion on webkit-dev, we've decided to move the "default"
 515         git setup to pulling updates from git.webkit.org in preference
 516         to rebuilding the local svn index using git svn fetch every time.
 517
 518         This change should have no effect on people using the "old" git setup
 519         and should dramatically increase the speed of updates for those using
 520         the "new" git setup along with update-webkit.  I'm about to move the
 521         EWS and other queues over to this setup once this lands.
 522
 523         * Scripts/update-webkit:
 524
 525 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
 526
 527         Reviewed by Xan Lopez.
 528
 529         GTK: AX: implement press in DRT
 530         https://bugs.webkit.org/show_bug.cgi?id=36146
 531
 532         Implement AccessibilityUIElement::press() for GTK.
 533
 534         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 535         (AccessibilityUIElement::press): Implemented.
 536
 537 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
 538
 539         Reviewed by Tony Chang.
 540
 541         config.webkit_base_dir returns a path with a trailing slash
 542         https://bugs.webkit.org/show_bug.cgi?id=50197
 543
 544         config.webkit_base_dir() should return a path without a trailing slash,
 545         like all the other methods that return paths.
 546
 547         Undoes MockFileSytem changes by r72640, since they're no longer
 548         necessary for GetBaselinesTest to pass.
 549
 550         * Scripts/webkitpy/common/system/filesystem_mock.py:
 551         * Scripts/webkitpy/layout_tests/port/base.py:
 552         * Scripts/webkitpy/layout_tests/port/config.py:
 553         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
 554
 555 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
 556
 557         Reviewed by Tony Chang.
 558
 559         Rebaseline server: baseline display tweaks
 560         https://bugs.webkit.org/show_bug.cgi?id=50207
 561
 562         Determine which baselines were used when running the tests and highlight
 563         them in the UI. Sort platform names alphabetically.
 564
 565         Also makes the server URL be launched in the user's browser
 566         automatically.
 567
 568         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
 569         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
 570         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
 571         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
 572         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
 573
 574 2010-11-30  Dan Bernstein  <mitz@apple.com>
 575
 576         Reviewed by Anders Carlsson.
 577
 578         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
 579         https://bugs.webkit.org/show_bug.cgi?id=50238
 580
 581         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 582         (WTR::LayoutTestController::findString): Added.
 583         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 584
 585 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
 586
 587         Reviewed by Adam Roben.
 588
 589         All projects on Windows should use cmd files for build events
 590         https://bugs.webkit.org/show_bug.cgi?id=50213
 591
 592         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
 593         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
 594         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
 595         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
 596         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
 597         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
 598         * DumpRenderTree/win/ImageDiffCommon.vsprops:
 599         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
 600         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
 601         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
 602         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
 603         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
 604         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
 605         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
 606         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
 607         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
 608         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
 609         * WebKitAPITest/WebKitAPITestCommon.vsprops:
 610         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
 611         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
 612         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
 613         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
 614         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
 615         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
 616         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
 617         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
 618         * WinLauncher/WinLauncherCommon.vsprops:
 619         * WinLauncher/WinLauncherPostBuild.cmd: Added.
 620         * WinLauncher/WinLauncherPreBuild.cmd: Added.
 621
 622 2010-11-29  Dan Bernstein  <mitz@apple.com>
 623
 624         GTK DumpRenderTree build fix after r72887.
 625
 626         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 627         (LayoutTestController::findString):
 628
 629 2010-11-29  Dan Bernstein  <mitz@apple.com>
 630
 631         Windows DumpRenderTree build fix after r72887.
 632
 633         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 634         (LayoutTestController::findString): Added empty implementation.
 635
 636 2010-11-29  Dan Bernstein  <mitz@apple.com>
 637
 638         Reviewed by Darin Adler.
 639
 640         DumpRenderTree changes for testing the text search API.
 641         https://bugs.webkit.org/show_bug.cgi?id=50038
 642
 643         * DumpRenderTree/LayoutTestController.cpp:
 644         (findStringCallback):
 645         (LayoutTestController::staticFunctions):
 646         * DumpRenderTree/LayoutTestController.h:
 647         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 648         (LayoutTestController::findString):
 649         * MiniBrowser/mac/BrowserWindowController.m:
 650         (-[BrowserWindowController find:]):
 651
 652 2010-11-29  Johnny Ding  <jnd@chromium.org>
 653
 654         Unreviewed: Add myself to the list of Committers.
 655
 656         * Scripts/webkitpy/common/config/committers.py:
 657
 658 2010-11-29  Mark Rowe  <mrowe@apple.com>
 659
 660         Reviewed by Adele Peterson.
 661
 662         <rdar://problem/8694997> DumpRenderTree fails to build.
 663
 664         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
 665
 666 2010-11-29  Mark Rowe  <mrowe@apple.com>
 667
 668         Reviewed by Adele Peterson.
 669
 670         <rdar://problem/8694997> DumpRenderTree fails to build.
 671
 672         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
 673         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
 674         * DumpRenderTree/mac/PerlSupport/Makefile:
 675
 676 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
 677
 678         Reviewed by Martin Robinson.
 679
 680         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
 681         https://bugs.webkit.org/show_bug.cgi?id=50154
 682
 683         Added missing checks to allAttributes().
 684
 685         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 686         (AccessibilityUIElement::allAttributes): Added missing checks.
 687
 688 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 689
 690         Reviewed by Kenneth Rohde Christiansen.
 691
 692         [Qt] Allow pre-generation for package builds for WebKit2
 693         https://bugs.webkit.org/show_bug.cgi?id=50139
 694
 695         Use a build variable for the generated directory path and set the
 696         value based on CONFIG just like for WebKit1.
 697
 698         For non-package builds use a relative base path for the
 699         genrated directory just like for WebKit1.
 700
 701         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 702         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 703
 704 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 705
 706         Reviewed by Kenneth Rohde Christiansen.
 707
 708         [Qt] Move some build logic from Qt to platform independent code
 709         https://bugs.webkit.org/show_bug.cgi?id=50134
 710
 711         Create target directories inside generate-forwarding-headers.pl.
 712
 713         * Scripts/generate-forwarding-headers.pl:
 714
 715 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
 716
 717         Reviewed by Martin Robinson.
 718
 719         [GTK] Windowless plugins gets broken key input
 720         https://bugs.webkit.org/show_bug.cgi?id=49927
 721
 722         Convert the XEvent::keycode to ASCII before printing it. Not
 723         doing this was causing false positive in
 724         plugins/keyboard-events.html.
 725
 726         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 727         (keycode_to_char):
 728         (webkit_test_plugin_handle_event):
 729
 730 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
 731
 732         Reviewed by Antonio Gomes.
 733
 734         [Qt] Html autofocus not working with QGraphicsWebView
 735         https://bugs.webkit.org/show_bug.cgi?id=43169
 736
 737         Tell the scene to set the webview item as the currently
 738         focused item. This makes the input field with autofocus get
 739         focus as it should.
 740
 741         * QtTestBrowser/webview.cpp:
 742         (WebViewGraphicsBased::WebViewGraphicsBased):
 743
 744 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
 745
 746         Reviewed by Tony Chang.
 747
 748         nrwt - clean up create_driver interface and print out the
 749         command line used for DumpRenderTree/TestShell.
 750
 751         This patch adds a driver_cmd_line() call to the Port class in
 752         order to retrive the command line to print it out (as part of
 753         --print config).
 754
 755         In addition, this patch cleans up the Port.create_driver()
 756         signature and the Driver constructor interface to take a worker
 757         number and no longer require the image_path argument (Chromium's
 758         drivers now synthesize the image_path from the worker number
 759         internally).
 760
 761         https://bugs.webkit.org/show_bug.cgi?id=49934
 762
 763         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 764         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 765         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 766         * Scripts/webkitpy/layout_tests/port/base.py:
 767         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 768         * Scripts/webkitpy/layout_tests/port/chromium.py:
 769         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 770         * Scripts/webkitpy/layout_tests/port/dryrun.py:
 771         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 772         * Scripts/webkitpy/layout_tests/port/test.py:
 773         * Scripts/webkitpy/layout_tests/port/webkit.py:
 774         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 775         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 776
 777 2010-11-24  Ojan Vafai  <ojan@chromium.org>
 778
 779         Reviewed by Tony Chang.
 780
 781         [chromium] improve memory usage for test results server and store fewer runs
 782         https://bugs.webkit.org/show_bug.cgi?id=50035
 783
 784         Store fewer runs and don't pass full files around when we only need bools.
 785         Greatly improves error rates on test-results.appspot.com.
 786
 787         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
 788         * TestResultServer/handlers/testfilehandler.py:
 789         * TestResultServer/model/dashboardfile.py:
 790         * TestResultServer/model/jsonresults.py:
 791
 792 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
 793
 794         Reviewed by Tony Chang.
 795
 796         This patch implements the first part of the manager side of the
 797         Broker objects - it handles creating threads, waiting for them
 798         to complete, and running a single-threaded loop as well.
 799
 800         https://bugs.webkit.org/show_bug.cgi?id=49779
 801
 802         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 803         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
 804         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 805         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 806
 807 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
 808
 809         Reviewed by David Levin.
 810
 811         DRT should not generate pixel output for text/plain tests
 812         https://bugs.webkit.org/show_bug.cgi?id=50002
 813
 814         Modify Mac, Windows and GTK DRT implementations to disable pixel output
 815         when encountering a text/plain response (the Chromium one already does
 816         this, and none of the other ports special-case text/plain output in
 817         the first place).
 818
 819         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 820         (dump):
 821         * DumpRenderTree/mac/DumpRenderTree.mm:
 822         (dump):
 823         * DumpRenderTree/win/DumpRenderTree.cpp:
 824         (dump):
 825
 826 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
 827
 828         Unreviewed.
 829
 830         Add my other email address to committers.py.
 831
 832         * Scripts/webkitpy/common/config/committers.py:
 833
 834 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
 835
 836         Reviewed by Csaba Osztrogonác.
 837
 838         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
 839         https://bugs.webkit.org/show_bug.cgi?id=49975
 840
 841         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
 842         to enable the script to define it 0 in case of a minimal build.
 843
 844 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
 845
 846         Reviewed by Xan Lopez.
 847
 848         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
 849         https://bugs.webkit.org/show_bug.cgi?id=49143
 850
 851         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 852         (createWebView): Call the new connectEditingCallbacks function.
 853         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
 854         (dumpNodePath):
 855         (dumpRange):
 856         (insertActionString):
 857         (selectionAffinityString):
 858         (shouldBeginEditing):
 859         (shouldEndEditing):
 860         (shouldInsertNode):
 861         (shouldInsertText):
 862         (shouldDeleteRange):
 863         (shouldShowDeleteInterfaceForElement):
 864         (shouldChangeSelectedRange):
 865         (shouldApplyStyle):
 866         (editingBegan):
 867         (userChangedContents):
 868         (editingEnded):
 869         (selectionChanged):
 870         (connectEditingCallbacks):
 871         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
 872         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
 873
 874 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
 875
 876         Reviewed by Andreas Kling.
 877
 878         [Qt] Make QtTestBrowser remember the selected user agent
 879         https://bugs.webkit.org/show_bug.cgi?id=50021
 880
 881         Set user agent for a new page by using the old page's
 882
 883         * QtTestBrowser/mainwindow.cpp:
 884         (MainWindow::setPage):
 885
 886 2010-11-24 Patrick Gansterer <paroga@webkit.org>
 887
 888         Reviewed by Csaba Osztrogonác.
 889
 890         Remove Bakefile build system files
 891         https://bugs.webkit.org/show_bug.cgi?id=49983
 892
 893         r53757 only removed the content, but not the files.
 894         This patch removes that empty files.
 895
 896         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
 897         * wx/browser/browser.bkl: Removed.
 898         * wx/build-wxwebkit: Removed.
 899
 900 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
 901
 902         Reviewed by Tony Chang.
 903
 904         This patch cleans up the logic used to shard tests into groups a
 905         bit and adds the --worker-model flag to NRWT. The flag is only
 906         used at the moment to control whether to run single-threaded or
 907         not, but eventually will also allow toggling between threads and
 908         processes.
 909
 910         Also add a minor cleanup with _test_is_slow(), which just
 911         eliminates some repetition and gives slightly better encapsulation.
 912
 913         https://bugs.webkit.org/show_bug.cgi?id=49773
 914
 915         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 916         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 917
 918 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
 919
 920         Reviewed by Tony Chang.
 921
 922         Rebaseline server: list current baselines and platforms
 923         https://bugs.webkit.org/show_bug.cgi?id=49991
 924
 925         List existing baselines (with Trac links) for tests.
 926
 927         Add dropdowns for choosing with platform baselines to target (and what
 928         to do with existing ones).
 929
 930         Also fix MockFileSystem.join to behave more like os.path.join (unit
 931         test was ending up with two consecutive slashes in a layout test
 932         path).
 933
 934         * Scripts/webkitpy/common/system/filesystem_mock.py:
 935         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
 936         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
 937         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
 938         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
 939         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
 940         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
 941         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
 942
 943 2010-11-23  Ojan Vafai  <ojan@chromium.org>
 944
 945         Reviewed by Tony Chang.
 946
 947         remove timeout argument to urlopen
 948         https://bugs.webkit.org/show_bug.cgi?id=49995
 949
 950         Apparently the version of python we have on the bots doesn't accept a timeout argument.
 951
 952         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
 953
 954 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
 955
 956         Unreviewed, rolling out r72628.
 957         http://trac.webkit.org/changeset/72628
 958         https://bugs.webkit.org/show_bug.cgi?id=49994
 959
 960         This patch is causing layout-test failtures on GTK Linux
 961         64-bit Debug (Requested by ctguil on #webkit).
 962
 963         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
 964         (AccessibilityUIElement::AccessibilityUIElement):
 965         (AccessibilityUIElement::parentElementCallback):
 966         * DumpRenderTree/chromium/AccessibilityUIElement.h:
 967         * DumpRenderTree/chromium/CppBoundClass.cpp:
 968         * DumpRenderTree/chromium/CppBoundClass.h:
 969
 970 2010-11-22  Ojan Vafai  <ojan@chromium.org>
 971
 972         Reviewed by Tony Chang.
 973
 974         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
 975         https://bugs.webkit.org/show_bug.cgi?id=49944
 976
 977         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
 978
 979 2010-11-23  Chris Guillory  <chris.guillory@google.com>
 980
 981         Reviewed by Dimitri Glazkov.
 982
 983         Include the FrameView widget of a RenderWidget in the accessibility tree.
 984         https://bugs.webkit.org/show_bug.cgi?id=49106
 985
 986         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
 987         (AccessibilityUIElement::AccessibilityUIElement):
 988         (AccessibilityUIElement::parentElementCallback):
 989         (AccessibilityUIElement::isEqualCallback):
 990         * DumpRenderTree/chromium/AccessibilityUIElement.h:
 991         * DumpRenderTree/chromium/CppBoundClass.cpp:
 992         (CppBoundClass::getFromCppVariant):
 993         * DumpRenderTree/chromium/CppBoundClass.h:
 994
 995 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
 996
 997         Reviewed by Kenneth Rohde Christiansen.
 998
 999         [EFL] Add tiled backing store to EWebLauncher
1000         https://bugs.webkit.org/show_bug.cgi?id=45777
1001
1002         Allow EWebLauncher to choose between single and tiled backing store
1003
1004         * EWebLauncher/main.c:
1005         (on_key_down):
1006         (browserCreate):
1007         (main):
1008
1009 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1010
1011         Reviewed by Tor Arne Vestbø.
1012
1013         [Qt] Review the setUserPermission & friends API
1014         https://bugs.webkit.org/show_bug.cgi?id=46810
1015
1016         Renamed requestPermissionFromUser to featurePermissionRequested
1017         and cancelRequestsForPermission to featurePermissionRequestCanceled.
1018
1019         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1020         (WebCore::WebPage::WebPage):
1021         * QtTestBrowser/webpage.cpp:
1022         (WebPage::WebPage):
1023         (WebPage::featurePermissionRequestCanceled):
1024         * QtTestBrowser/webpage.h:
1025
1026 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1027
1028         Reviewed by Tor Arne Vestbø.
1029
1030         [Qt] Review the setUserPermission & friends API
1031         https://bugs.webkit.org/show_bug.cgi?id=46810
1032
1033         Rename setUserPermission to setFeaturePermission
1034
1035         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1036         (WebCore::WebPage::requestPermission):
1037         (WebCore::WebPage::permissionSet):
1038         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1039         (LayoutTestController::grantDesktopNotificationPermission):
1040         * QtTestBrowser/webpage.cpp:
1041         (WebPage::requestPermission):
1042
1043 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1044
1045         Reviewed by Tor Arne Vestbø.
1046
1047         [Qt] Review the setUserPermission & friends API
1048         https://bugs.webkit.org/show_bug.cgi?id=46810
1049
1050         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
1051         and GeolocationPermissionDomain to Geolocation.
1052
1053         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1054         (WebCore::WebPage::WebPage):
1055         (WebCore::WebPage::requestPermission):
1056         (WebCore::WebPage::cancelPermission):
1057         (WebCore::WebPage::permissionSet):
1058         (WebCore::DumpRenderTree::geolocationPermissionSet):
1059         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1060         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1061         (LayoutTestController::grantDesktopNotificationPermission):
1062         * QtTestBrowser/webpage.cpp:
1063         (WebPage::WebPage):
1064         (WebPage::requestPermission):
1065         (WebPage::cancelRequestsForPermission):
1066         * QtTestBrowser/webpage.h:
1067
1068 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1069
1070         Reviewed by Tor Arne Vestbø.
1071
1072         [Qt] Review the setUserPermission & friends API
1073         https://bugs.webkit.org/show_bug.cgi?id=46810
1074
1075         Add a ByUser suffix to PermissionGranted/Denied. In the future
1076         we can add PermissionGrantedByDefault.
1077
1078
1079         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1080         (WebCore::WebPage::requestPermission):
1081         (WebCore::WebPage::permissionSet):
1082         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1083         (LayoutTestController::grantDesktopNotificationPermission):
1084         * QtTestBrowser/webpage.cpp:
1085         (WebPage::requestPermission):
1086
1087 2010-11-18  Satish Sampath  <satish@chromium.org>
1088
1089         Reviewed by Jeremy Orlow.
1090
1091         For speech input event, send an event object containing all the recognition results and metadata.
1092         https://bugs.webkit.org/show_bug.cgi?id=49736
1093
1094         Updated DRT by renaming the mock result method on all platforms to the new signature.
1095
1096         * DumpRenderTree/LayoutTestController.cpp:
1097         (addMockSpeechInputResultCallback):
1098         (LayoutTestController::staticFunctions):
1099         * DumpRenderTree/LayoutTestController.h:
1100         * DumpRenderTree/chromium/LayoutTestController.cpp:
1101         (LayoutTestController::LayoutTestController):
1102         (LayoutTestController::addMockSpeechInputResult):
1103         * DumpRenderTree/chromium/LayoutTestController.h:
1104         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1105         (LayoutTestController::addMockSpeechInputResult):
1106         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1107         (LayoutTestController::addMockSpeechInputResult):
1108         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1109         (LayoutTestController::addMockSpeechInputResult):
1110         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1111         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1112         (LayoutTestController::addMockSpeechInputResult):
1113         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1114         (LayoutTestController::addMockSpeechInputResult):
1115
1116 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1117
1118         Reviewed by Tony Chang.
1119
1120         Fix some spacing issues with log messages with
1121         new-run-webkit-tests --verbose.
1122
1123         https://bugs.webkit.org/show_bug.cgi?id=49936
1124
1125         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1126
1127 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1128
1129         Reviewed by Adam Barth.
1130
1131         update scm to work with different remote branches
1132         https://bugs.webkit.org/show_bug.cgi?id=49949
1133
1134         This works if there are multiple svn tracking branches
1135         and/or if the tracking branch is refs/remots/origin/master
1136         instead of refs/remotes/trunk which is the direction we're trying
1137         to head since that makes fetches faster.
1138
1139         * Scripts/webkitpy/common/checkout/scm.py:
1140         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1141
1142 2010-11-22  Hayato Ito  <hayato@chromium.org>
1143
1144         Reviewed by Shinichiro Hamaji.
1145
1146         Ignore reference files which will be used by reftests when collecting
1147         test cases.
1148         https://bugs.webkit.org/show_bug.cgi?id=49835
1149
1150         * Scripts/webkitpy/layout_tests/port/test_files.py:
1151         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1152
1153 2010-11-22  Adam Roben  <aroben@apple.com>
1154
1155         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1156
1157         Apple's Windows build allows placing header files and import libraries for WebKit's
1158         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1159         $WebKitLibrariesDir environment variable. This is both required for production builds and
1160         convenient for Apple-internal developer builds. Apple's production builds also require that
1161         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1162         builds, the files are copied into that directory tree by the
1163         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1164         copying is done by
1165         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1166
1167         This .vsprops copying is problematic in one very important case: when a developer updates
1168         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1169         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1170         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1171         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1172         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1173         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1174
1175         To fix this, we now use normal relative paths to access the .vsprops files in the source
1176         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1177         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1178         unset, so the normal relative paths are used to read the .vsprops files out of the source
1179         tree directly. In production builds, this environment variable is set to a fake directory
1180         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1181         is resolved.
1182
1183         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1184
1185         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1186
1187         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1188         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1189         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1190         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1191         FeatureDefines.vsprops becomes:
1192
1193         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1194
1195         which resolves to:
1196
1197         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1198
1199         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1200         actually exist since they are matched by an equal number of ".." path components.)
1201
1202         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1203         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1204
1205         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1206         updated
1207
1208         Reviewed by Dave Hyatt.
1209
1210         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1211         * DumpRenderTree/win/DumpRenderTree.vcproj:
1212         * DumpRenderTree/win/ImageDiff.vcproj:
1213         * FindSafari/FindSafari.vcproj:
1214         * MiniBrowser/MiniBrowser.vcproj:
1215         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1216         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1217         * WebKitAPITest/WebKitAPITest.vcproj:
1218         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1219         * WebKitTestRunner/win/InjectedBundle.vcproj:
1220         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1221         * WinLauncher/WinLauncher.vcproj:
1222         * record-memory-win/record-memory-win.vcproj:
1223         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1224         files.
1225
1226 2010-11-22  Adam Roben  <aroben@apple.com>
1227
1228         Make it possible to run tests on Windows without Visual Studio or VC++
1229         Express installed
1230
1231         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1232         are not installed. But this function doesn't need to be called when we
1233         already have a build available and are just trying to run the tests.
1234
1235         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1236         because Visual Studio/VC++ Express aren't installed
1237
1238         Reviewed by Dave Hyatt.
1239
1240         * Scripts/webkitdirs.pm:
1241         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1242         it is not needed by this function. Also added a FIXME.
1243
1244         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1245         relying on determineConfigurationForVisualStudio doing it.
1246
1247 2010-11-19  Hayato Ito  <hayato@chromium.org>
1248
1249         Reviewed by Shinichiro Hamaji.
1250
1251         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1252
1253         https://bugs.webkit.org/show_bug.cgi?id=49812
1254
1255         * Scripts/webkitpy/layout_tests/driver_test.py:
1256         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1257         * Scripts/webkitpy/layout_tests/port/base.py:
1258         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1259         * Scripts/webkitpy/layout_tests/port/chromium.py:
1260         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1261         * Scripts/webkitpy/layout_tests/port/test.py:
1262         * Scripts/webkitpy/layout_tests/port/webkit.py:
1263         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1264         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1265
1266 2010-11-22  Hayato Ito  <hayato@chromium.org>
1267
1268         Reviewed by Tony Chang.
1269
1270         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1271
1272         https://bugs.webkit.org/show_bug.cgi?id=49924
1273
1274         * Scripts/webkitpy/layout_tests/port/chromium.py:
1275
1276 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1277
1278         Reviewed by Kenneth Rohde Christiansen.
1279
1280         Fix EWebLauncher zoom discretization
1281         https://bugs.webkit.org/show_bug.cgi?id=49810
1282
1283         * EWebLauncher/main.c:
1284         (nearest_zoom_level_get):
1285         (zoom_level_set):
1286         (on_load_finished):
1287         (on_key_down):
1288
1289 2010-11-21  Sam Weinig  <sam@webkit.org>
1290
1291         Rubber-stamped by Dan Bernstein.
1292
1293         Fix ~300 WebKit2 tests by enabling developer extras preference.
1294
1295         * WebKitTestRunner/TestController.cpp:
1296         (WTR::TestController::resetStateToConsistentValues):
1297
1298 2010-11-21  Sam Weinig  <sam@webkit.org>
1299
1300         Reviewed by Dan Bernstein.
1301
1302         Textareas should be resizable by default
1303         https://bugs.webkit.org/show_bug.cgi?id=49892
1304
1305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1306         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1307         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1308         Add preferences test.
1309
1310 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1311
1312         Reviewed by Tony Chang.
1313
1314         Rebaseline server: checksum-only differences and prefetching
1315         https://bugs.webkit.org/show_bug.cgi?id=49841
1316
1317         Add support for image test results where the only difference is in the
1318         checksum.
1319
1320         Add prefetching of the image results from the next test.
1321
1322         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1323         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1324         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1325
1326 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1327
1328         Reviewed by Tony Chang.
1329
1330         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1331
1332         Add the 'worker number' and 'worker name' concepts to the
1333         TestShellThread objects, and move test_types and test_args from
1334         the TestRunner to the TestShellThread.
1335
1336         https://bugs.webkit.org/show_bug.cgi?id=49768
1337
1338         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1339         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1340
1341 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1342
1343         Reviewed by Ojan Vafai.
1344
1345         Do some minor cleanup and bug fixing.
1346
1347         https://bugs.webkit.org/show_bug.cgi?id=49777
1348
1349         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1350         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1351
1352 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1353
1354         Reviewed by Ojan Vafai.
1355
1356         nrwt - config.build_directory() is busted
1357
1358         Fixes a typo that was causing us to usually return the top level
1359         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1360         bug was hidden by test stubs that were too simplistic :(.
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=49815
1363
1364         * Scripts/webkitpy/common/system/executive_mock.py:
1365         * Scripts/webkitpy/layout_tests/port/config.py:
1366         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1367
1368 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1369
1370         Reviewed by Adam Roben.
1371
1372         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1373         https://bugs.webkit.org/show_bug.cgi?id=49819
1374
1375         * DumpRenderTree/DumpRenderTree.sln:
1376         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1377         * DumpRenderTree/win/DumpRenderTree.vcproj:
1378         * DumpRenderTree/win/ImageDiff.vcproj:
1379         * FindSafari/FindSafari.vcproj:
1380         * MiniBrowser/MiniBrowser.vcproj:
1381         * TestWebKitAPI/win/TestWebKitAPI.sln:
1382         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1383         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1384         * WebKitAPITest/WebKitAPITest.vcproj:
1385         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1386         * WebKitTestRunner/win/InjectedBundle.vcproj:
1387         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1388         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1389         * WinLauncher/WinLauncher.vcproj:
1390         * record-memory-win/record-memory-win.vcproj:
1391
1392 2010-11-19  Adam Roben  <aroben@apple.com>
1393
1394         Add some more Windows slaves
1395
1396         This is probably more than we will be using in the immediate future,
1397         but having some extra slave names makes experimenting with different
1398         configurations easier.
1399
1400         Reviewed by Jon Honeycutt.
1401
1402         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1403         Windows slaves and distributed them among the three different Test
1404         builders.
1405
1406 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1407
1408         Reviewed by Ojan Vafai.
1409
1410         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1411         https://bugs.webkit.org/show_bug.cgi?id=49702
1412
1413         Re-landing r72357 with a test fix.
1414
1415         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1416         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1417         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1418
1419 2010-11-19  Avi Drissman  <avi@google.com>
1420
1421         Reviewed by Antonio Gomes.
1422
1423         Complete support for Unix editing mode
1424         https://bugs.webkit.org/show_bug.cgi?id=49757
1425
1426         * DumpRenderTree/LayoutTestController.cpp:
1427         (setEditingBehaviorCallback):
1428         * DumpRenderTree/chromium/LayoutTestController.cpp:
1429         (LayoutTestController::setEditingBehavior):
1430
1431 2010-11-19  Adam Roben  <aroben@apple.com>
1432
1433         Fix run-javascriptcore-tests when there's a space in the path to
1434         testapi
1435
1436         Reviewed by Sam Weinig.
1437
1438         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1439         system() to force it to interpret spaces in the path correctly.
1440
1441 2010-11-19  Adam Roben  <aroben@apple.com>
1442
1443         Update scripts for .exe name changes after r72327
1444
1445         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1446
1447         Reviewed by Sam Weinig.
1448
1449         * Scripts/run-javascriptcore-tests:
1450         (testapiPath):
1451
1452         * Scripts/sunspider-compare-results:
1453         (pathToBuiltJSC):
1454
1455         * Scripts/webkitdirs.pm:
1456         (jscPath):
1457         (safariPath):
1458
1459 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1460
1461         Reviewed by Darin Adler.
1462
1463         Normalize Cairo/CFLite project/solution configuration names
1464         https://bugs.webkit.org/show_bug.cgi?id=49818
1465
1466         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1467         * DumpRenderTree/win/DumpRenderTree.vcproj:
1468         * DumpRenderTree/win/ImageDiff.vcproj:
1469         * MiniBrowser/MiniBrowser.vcproj:
1470         * TestWebKitAPI/win/TestWebKitAPI.sln:
1471         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1472         * WebKitAPITest/WebKitAPITest.vcproj:
1473         * WebKitTestRunner/win/InjectedBundle.vcproj:
1474         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1475         * WinLauncher/WinLauncher.vcproj:
1476         * Scripts/webkitdirs.pm: Updated cairo build configs.
1477
1478 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1479
1480         Reviewed by Adam Roben.
1481
1482         Windows vcproj configuration names should be normalized across projects
1483         https://bugs.webkit.org/show_bug.cgi?id=49776
1484
1485         * DumpRenderTree/DumpRenderTree.sln:
1486         * FindSafari/FindSafari.vcproj:
1487         * TestWebKitAPI/win/TestWebKitAPI.sln:
1488         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1489         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1490         * WebKitAPITest/WebKitAPITest.vcproj:
1491         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1492         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1493         * WebKitTestRunner/WebKitTestRunner.sln:
1494         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1495         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1496         * record-memory-win/record-memory-win.vcproj:
1497
1498 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1499
1500         Build fix - as per DRT-mac, always enabled developer extras,
1501         in win/qt/gtk DRT.
1502
1503         This is necessary to enable rich exception messages to be generated
1504         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1505
1506         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1507         (shouldEnableDeveloperExtras):
1508         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1509         (WebCore::shouldEnableDeveloperExtras):
1510         * DumpRenderTree/win/DumpRenderTree.cpp:
1511         (shouldEnableDeveloperExtras):
1512
1513 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1514
1515         Unreviewed, rolling out r72357.
1516         http://trac.webkit.org/changeset/72357
1517         https://bugs.webkit.org/show_bug.cgi?id=49784
1518
1519         It broke test-webkitpy tests since the patch didn't have the
1520         corresponding test update (Requested by kinuko on #webkit).
1521
1522         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1523         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1524
1525 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
1526
1527         Reviewed by Tony Chang.
1528
1529         Rebaseline server: add rebaseline queue
1530         https://bugs.webkit.org/show_bug.cgi?id=49763
1531
1532         Add a UI queue (a multi-item <select>) where tests to be baselined
1533         can be enqueued (also supports basic removal). A queue is used instead
1534         of immediately doing rebaselines since SCM operations can take a while.
1535         It's better to go through lots of tests quickly to mark them as
1536         needing rebaselining and then batch the SCM operations.
1537
1538         Also adds a simple log where results can be displayed.
1539
1540         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1541         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1542         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1543         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
1544         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1545         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1546
1547 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1548
1549         Reviewed by Oliver Hunt.
1550
1551         Bug 49708 - Stop recompiling functions to regenerate exception info.
1552
1553         Instead only hold info as necessary – keep divot info is the inspector
1554         is enabled, line number info is debugging or profiling, and handler
1555         info for functions with try/catch.
1556
1557         * DumpRenderTree/mac/DumpRenderTree.mm:
1558         (shouldEnableDeveloperExtras):
1559             - always enable the developer tools from DRT, to ensure we
1560               produce rich error messages on JavaScript exceptions.
1561
1562 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1563
1564         Reviewed by Ojan Vafai.
1565
1566         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1567         https://bugs.webkit.org/show_bug.cgi?id=49702
1568
1569         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1570         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1571
1572 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1573
1574         Reviewed by Tony Chang.
1575
1576         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1577
1578         Create the first version of the 'message_broker' package. This
1579         class will encapsulate all of the threading/multiprocessing and
1580         message-sending details for the communication between the
1581         'manager' object and the 'worker' objects. For the moment, it
1582         just holds some routines and tests for logging thread stacks.
1583
1584         There should be no functional changes in this patch, just moving stuff
1585         around.
1586
1587         https://bugs.webkit.org/show_bug.cgi?id=49707
1588
1589         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1590         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1591         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1592         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1593         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1594         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1595
1596 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1597
1598         Reviewed by Adam Roben.
1599
1600         Remove leftover Windows Debug_Internal configurations
1601         https://bugs.webkit.org/show_bug.cgi?id=49758
1602
1603         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1604         * DumpRenderTree/win/DumpRenderTree.vcproj:
1605         * DumpRenderTree/win/ImageDiff.vcproj:
1606         * MiniBrowser/MiniBrowser.vcproj:
1607         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1608         * WebKitAPITest/WebKitAPITest.vcproj:
1609         * WebKitTestRunner/win/InjectedBundle.vcproj:
1610         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1611         * WinLauncher/WinLauncher.vcproj:
1612
1613 2010-11-18  Adam Roben  <aroben@apple.com>
1614
1615         Add three new Windows XP build slaves
1616
1617         Reviewed by Steve Falkenburg.
1618
1619         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1620         new slaves, and added them to the Windows XP Debug (Tests) builder.
1621
1622 2010-11-18  Daniel Bates  <dbates@rim.com>
1623
1624         Reviewed by Adam Roben.
1625
1626         update-webkit-support-libs should fall back to existing
1627         WebKitSupportLibrary version if there is no internet connectivity
1628         https://bugs.webkit.org/show_bug.cgi?id=49503
1629
1630         Fall back to existing support libraries (if present) when there is
1631         no internet connection.
1632
1633         Currently, update-webkit-support-libs dies with an "out-of-date"
1634         error when there is no internet connection because it cannot
1635         retrieve versioning information from developer.apple.com. Because
1636         update-webkit-support-libs fails, build-webkit fails. Instead,
1637         if there is no internet connection and the support libraries are
1638         present then we should warn the user and exit() with success so
1639         that build-webkit can work without an internet connection.
1640
1641         * Scripts/update-webkit-support-libs:
1642
1643 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1644
1645         Reviewed by Adam Roben.
1646
1647         Debug_Internal Windows configuration is unnecessary, should be removed
1648         https://bugs.webkit.org/show_bug.cgi?id=49753
1649
1650         * DumpRenderTree/win/DumpRenderTree.cpp:
1651         * MiniBrowser/win/stdafx.h:
1652         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1653         * WebKitTestRunner/win/TestControllerWin.cpp:
1654
1655 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1656
1657         Reviewed by Adam Roben.
1658
1659         Clean up vcproj errors
1660         https://bugs.webkit.org/show_bug.cgi?id=49741
1661
1662         * MiniBrowser/MiniBrowser.vcproj:
1663         * WebKitAPITest/WebKitAPITest.vcproj:
1664         * WebKitTestRunner/win/InjectedBundle.vcproj:
1665         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1666
1667 2010-11-18  Hayato Ito  <hayato@chromium.org>
1668
1669         Reviewed by Shinichiro Hamaji.
1670
1671         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1672         which is caused by r72249.
1673
1674         https://bugs.webkit.org/show_bug.cgi?id=49751
1675
1676         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1677
1678 2010-11-18  Adam Roben  <aroben@apple.com>
1679
1680         Implement layoutTestController.waitForPolicyDelegate on Windows
1681
1682         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1683
1684         Reviewed by Simon Fraser.
1685
1686         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1687         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1688         code from LayoutTestControllerMac.mm.
1689
1690 2010-11-18  Hayato Ito  <hayato@chromium.org>
1691
1692         Reviewed by Shinichiro Hamaji.
1693
1694         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1695
1696         https://bugs.webkit.org/show_bug.cgi?id=49740
1697
1698         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1699
1700 2010-11-18  Tony Chang  <tony@chromium.org>
1701
1702         Reviewed by Adam Barth.
1703
1704         run platform/chromium/plugins/refcount-leaks.html on all platforms
1705         https://bugs.webkit.org/show_bug.cgi?id=49485
1706
1707         Add PluginObject.testObjectCount which returns the number of allocated
1708         TestObjects. Add PluginObject.testCreateTestObject which allocates
1709         and returns a TestObject.
1710
1711         Add TestObject.refCount which returns the number of refs on the
1712         TestObject.
1713
1714         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1715         (pluginGetProperty):
1716         (pluginInvoke):
1717         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1718         (getTestObjectCount):
1719         (testAllocate):
1720         (testDeallocate):
1721         (testGetProperty):
1722         (testScriptObjectInvoke): Release a ref to a plugin object that was
1723             previously leaked.
1724         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1725
1726 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1727
1728         Reviewed by Adam Roben.
1729
1730         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1731         https://bugs.webkit.org/show_bug.cgi?id=49711
1732
1733         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1734         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1735         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1736         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1737         * record-memory-win/record-memory-win-common.vsprops: Added.
1738         * record-memory-win/record-memory-win.vcproj:
1739
1740 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1741
1742         Reviewed by Csaba Osztrogonác.
1743
1744         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1745
1746         * MiniBrowser/qt/BrowserWindow.cpp:
1747         (BrowserWindow::updateUserAgentList):
1748
1749 2010-11-17  Adam Roben  <aroben@apple.com>
1750
1751         Don't trigger Windows builds when chromium-win test results change
1752
1753         Reviewed by Mark Rowe.
1754
1755         * Scripts/webkitpy/common/config/build.py:
1756         (_should_file_trigger_build): Changed the regular expression used to
1757         search for directory names to only consider full directory names,
1758         rather than matching directory names where the string we care about is
1759         a suffix of the name.
1760
1761         * Scripts/webkitpy/common/config/build_unittest.py:
1762         (ShouldBuildTest): Added a test.
1763
1764 2010-11-17  Hayato Ito  <hayato@chromium.org>
1765
1766         Reviewed by Shinichiro Hamaji.
1767
1768         Remove a uri member from TestInput class.
1769
1770         https://bugs.webkit.org/show_bug.cgi?id=49691
1771
1772         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1773         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1774
1775 2010-11-17  Adam Roben  <aroben@apple.com>
1776
1777         Move FindSafari's settings into a vsprops file
1778
1779         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1780
1781         Reviewed by Steve Falkenburg.
1782
1783         * FindSafari/FindSafari.vcproj:
1784         * FindSafari/FindSafariCommon.vsprops: Added.
1785
1786 2010-11-17  Adam Roben  <aroben@apple.com>
1787
1788         Use a minimum font size of 0 in DRT on Windows
1789
1790         This is the Windows equivalent of r72164.
1791
1792         Rubber-stamped by Dave Hyatt.
1793
1794         * DumpRenderTree/win/DumpRenderTree.cpp:
1795         (resetDefaultsToConsistentValues):
1796
1797 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1798
1799         Reviewed by Andreas Kling.
1800
1801         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1802         https://bugs.webkit.org/show_bug.cgi?id=49639
1803
1804         * Scripts/webkitpy/common/checkout/scm.py:
1805
1806 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1807
1808         Reviewed by Tony Chang.
1809
1810         Rebaseline server: add loupe for image diffs
1811         https://bugs.webkit.org/show_bug.cgi?id=49692
1812
1813         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1814         enlarged area of the expected, actual and diff images side by side.
1815
1816         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1817         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1818         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1819         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1820
1821 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1822
1823         Reviewed by Adam Roben.
1824
1825         WebKitLauncherWin should use vsprops for shared build settings
1826         https://bugs.webkit.org/show_bug.cgi?id=49696
1827
1828         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1829         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1830
1831 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1832
1833         Reviewed by Adam Roben.
1834
1835         WinLauncher should use vsprops for shared build settings
1836         https://bugs.webkit.org/show_bug.cgi?id=49695
1837
1838         * WinLauncher/WinLauncher.cpp:
1839         (_tWinMain):
1840         (PrintView):
1841         (WndProc):
1842         (MyEditProc):
1843         * WinLauncher/WinLauncher.vcproj:
1844         * WinLauncher/WinLauncherCommon.vsprops: Added.
1845
1846 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1847
1848         Delete unused file unintentionally added in last change.
1849
1850         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1851
1852 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1853
1854         Reviewed by Adam Roben.
1855
1856         DumpRenderTree on Windows should use a vsprops file for shared project settings
1857         https://bugs.webkit.org/show_bug.cgi?id=49690
1858
1859         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1860         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1861         * DumpRenderTree/win/DumpRenderTree.vcproj:
1862         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1863         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1864         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1865         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1866         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1867         * DumpRenderTree/win/ImageDiff.vcproj:
1868         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1869
1870 2010-11-17  Hayato Ito  <hayato@chromium.org>
1871
1872         Refactor TestTypeBase.compare_output().
1873
1874         Introduce a TestOutput class and update compare_output() of each test
1875         types so that they can take both actual and expected TestOutput objects.
1876
1877         https://bugs.webkit.org/show_bug.cgi?id=49431
1878
1879         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1880         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1881         * Scripts/webkitpy/layout_tests/port/base.py:
1882         * Scripts/webkitpy/layout_tests/port/chromium.py:
1883         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1884         * Scripts/webkitpy/layout_tests/port/test.py:
1885         * Scripts/webkitpy/layout_tests/port/webkit.py:
1886         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1887         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1888         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1889         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1890
1891 2010-11-17  Adam Roben  <aroben@apple.com>
1892
1893         Make each Windows Test builder use the same OS for all its slaves
1894
1895         Currently each WebKit1 Windows Test builder has one Windows XP slave
1896         and one Windows 7 slave. Having different OSes in a single builder
1897         meant that the builders would alternate between red and green when
1898         there were OS-specific failures.
1899
1900         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1901         between red and green because of multiple OS versions
1902
1903         Reviewed by Mark Rowe.
1904
1905         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1906         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1907         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1908         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1909         builders for the two WebKit1 builders so that they would all use the
1910         appropriate OS.
1911
1912 2010-11-17  James Robinson  <jamesr@chromium.org>
1913
1914         Reviewed by Dan Bernstein.
1915
1916         [chromium] Set minimum font size to 0 for DRT
1917         https://bugs.webkit.org/show_bug.cgi?id=49677
1918
1919         Followup for http://trac.webkit.org/changeset/72141.
1920
1921         Test: http/tests/misc/acid3.html
1922
1923         * DumpRenderTree/chromium/WebPreferences.cpp:
1924         (WebPreferences::reset):
1925
1926 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1927
1928         Unreviewed build fix.
1929
1930         [Qt] Add missing file I forgot in r72220.
1931
1932         * MiniBrowser/MiniBrowser.qrc: Added.
1933
1934 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1935
1936         Reviewed by Andreas Kling.
1937
1938         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1939         https://bugs.webkit.org/show_bug.cgi?id=49627
1940
1941         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1942
1943         * MiniBrowser/MiniBrowser.qrc: Added.
1944         Add it here to prevent qmake from detecting it
1945         since it needs to be copied to the build directory.
1946         * MiniBrowser/qt/BrowserWindow.cpp:
1947         (BrowserWindow::BrowserWindow):
1948         (BrowserWindow::updateUserAgentList):
1949         (BrowserWindow::showUserAgentDialog):
1950         * MiniBrowser/qt/BrowserWindow.h:
1951         * MiniBrowser/qt/MiniBrowser.pro:
1952
1953 2010-11-17  Adam Roben  <aroben@apple.com>
1954
1955         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1956
1957         We use that file on Windows!
1958
1959         Fixes <http://webkit.org/b/49643> Changes to
1960         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1961
1962         Reviewed by Steve Falkenburg.
1963
1964         * Scripts/webkitpy/common/config/build.py:
1965         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1966         trigger builds on SnowLeopard and Windows.
1967
1968         * Scripts/webkitpy/common/config/build_unittest.py:
1969         (ShouldBuildTest.test_should_build): Added a test.
1970
1971 2010-11-17  Satish Sampath  <satish@chromium.org>
1972
1973         Reviewed by Jeremy Orlow.
1974
1975         Clear the speech input mock explicitly before each test.
1976         https://bugs.webkit.org/show_bug.cgi?id=49660
1977
1978         * DumpRenderTree/chromium/LayoutTestController.cpp:
1979         (LayoutTestController::setMockSpeechInputResult):
1980         * DumpRenderTree/chromium/LayoutTestController.h:
1981         * DumpRenderTree/chromium/WebViewHost.cpp:
1982         (WebViewHost::speechInputController):
1983         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1984         * DumpRenderTree/chromium/WebViewHost.h:
1985         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1986
1987 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1988
1989         Unreviewed, specify IRC nickname in committers.py.
1990
1991         * Scripts/webkitpy/common/config/committers.py:
1992
1993 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1994
1995         Reviewed by Tony Chang.
1996
1997         [NRWT] Make http locking similar to perl implementation
1998         https://bugs.webkit.org/show_bug.cgi?id=49187
1999
2000         * Scripts/webkitpy/common/system/file_lock.py: Added.
2001         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2002         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2003
2004 2010-11-17  MORITA Hajime  <morrita@google.com>
2005
2006         Reviewed by Kent Tamura.
2007
2008         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
2009         https://bugs.webkit.org/show_bug.cgi?id=49366
2010
2011         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
2012           according to the spellchecker suggestion
2013         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
2014
2015         test_expectations.txt will be changed after this change is ported to test_shell.
2016
2017         * DumpRenderTree/chromium/EventSender.cpp:
2018         (makeMenuItemStringsFor):
2019         (EventSender::contextClick):
2020         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2021         (MockSpellCheck::fillSuggestionList):
2022         (MockSpellCheck::initializeIfNeeded):
2023         * DumpRenderTree/chromium/MockSpellCheck.h:
2024         * DumpRenderTree/chromium/WebViewHost.cpp:
2025         (WebViewHost::mockSpellCheck):
2026         * DumpRenderTree/chromium/WebViewHost.h:
2027
2028 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2029
2030         Reviewed by Sam Weinig.
2031
2032         Make sure the pref for minimum font size is just explicitly set to 0 every time,
2033         since the bots have 1 stuck in their plist otherwise.
2034
2035         * DumpRenderTree/mac/DumpRenderTree.mm:
2036         (resetDefaultsToConsistentValues):
2037
2038 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2039
2040         Reviewed by Tony Chang.
2041
2042         Rebaseline server: compute diffs client-side
2043         https://bugs.webkit.org/show_bug.cgi?id=49640
2044
2045         The image diff output from the DRT is pretty bad on some ports (at
2046         least the Mac one), so it's better to compute diffs on the client by
2047         using <canvas>.
2048
2049         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2050         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2051         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2052
2053 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2054
2055         Reviewed by Tony Chang.
2056
2057         Rebaseline server: display test results
2058         https://bugs.webkit.org/show_bug.cgi?id=49626
2059
2060         Adds basic result display to the rebaseline server. On the Python side
2061         this involves:
2062         - Parsing the unexpected_results.json into a dictionary.
2063         - Serving it as JSON under /results.json.
2064         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
2065         but I'll need to have access to the parsed results on the Python side
2066         for follow-up changes).
2067
2068         On the web UI side this adds:
2069         - Markup for display image and text results (expected, actual, diff),
2070           and JS for populating it.
2071         - Markup for breaking down test results by failure type and directory,
2072           and JS for populating it.
2073
2074         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2075         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2076         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2077         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
2078         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2079
2080 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2081
2082         Reviewed by Ojan Vafai.
2083
2084         See Chromium issue http://codereview.chromium.org/5133001/ - we
2085         are modifying the build bots to pass in the builder name with
2086         the "GPU" string appended instead of appending it in the code.
2087
2088         https://bugs.webkit.org/show_bug.cgi?id=49636
2089
2090         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2091
2092 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
2093
2094         Reviewed by Adam Roben.
2095
2096         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2097         https://bugs.webkit.org/show_bug.cgi?id=49632
2098
2099         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2100         * DumpRenderTree/win/DumpRenderTree.vcproj:
2101         * DumpRenderTree/win/ImageDiff.vcproj:
2102         * MiniBrowser/MiniBrowser.vcproj:
2103         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2104         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2105         * WebKitTestRunner/win/InjectedBundle.vcproj:
2106         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2107         * WinLauncher/WinLauncher.vcproj:
2108         * record-memory-win/record-memory-win.vcproj:
2109
2110 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2111
2112         Reviewed by Ojan Vafai.
2113
2114         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2115
2116         Rename the TestInfo class to TestInput to be clearer about its
2117         function, and move the checksum-reading code into dump_render_tree_thread
2118         to avoid cross-thread access.
2119
2120         https://bugs.webkit.org/show_bug.cgi?id=49573
2121
2122         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2123         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2124         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2125
2126 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2127
2128         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2129
2130         * DumpRenderTree/mac/DumpRenderTree.mm:
2131         (resetDefaultsToConsistentValues):
2132
2133 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2134
2135         Reviewed by Geoff Garen.
2136
2137         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2138
2139         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock
2140         for every WebView, and the WebKit API doesn't support that ownership model.
2141
2142         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2143
2144         * DumpRenderTree/mac/DumpRenderTree.mm:
2145         (createWebViewAndOffscreenWindow):
2146         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2147         (LayoutTestController::setMockDeviceOrientation):
2148
2149 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2150
2151         Reviewed by Ojan Vafai.
2152
2153         new-run-webkit-tests: log the process id in --verbose mode
2154
2155         As part of the switch to multi-process mode, we should log the
2156         process id when running w/ --verbose.
2157
2158         https://bugs.webkit.org/show_bug.cgi?id=49571
2159
2160         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2161
2162 2010-11-16  Adam Roben  <aroben@apple.com>
2163
2164         Only trigger Windows builds when files that we actually use on Windows
2165         are changed
2166
2167         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2168         It uses the new webkitpy.common.config.build module to determine
2169         whether a particular change should trigger a build on a particular
2170         platform. The Windows builders have been switched to use a
2171         PlatformSpecificScheduler.
2172
2173         The logic to determine whether or not a particular change should
2174         trigger a build on a given platform has only been implemented/tested
2175         for Windows. I tried to make it easy to add more platforms in the
2176         future, but I don't have enough familiarity with all platforms to be
2177         able to implement it for them.
2178
2179         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2180         lots irrelevant changes (e.g., rebaselining Chromium test results)
2181
2182         Reviewed by Eric Seidel.
2183
2184         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2185         PlatformSpecificScheduler for the Windows builders.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2188         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2189         up a ChangeFilter that filters to our branch and will call through to
2190         our filter method, and calls up to our base class.
2191         (PlatformSpecificScheduler.filter): Calls through to
2192         build.should_build to find out whether we should trigger a build for
2193         this change.
2194
2195         * Scripts/webkitpy/common/net/build.py: Added.
2196         (_should_file_trigger_build): Uses a set of directories and regexp
2197         patterns to determine whether the given file should trigger a build on
2198         the given platform. As mentioned earlier, this has only been
2199         implemented for Windows, though I did try to make some guesses about
2200         other platforms.
2201         (should_build): Returns true if any of the files should trigger a
2202         build on the given platform.
2203
2204         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2205         (ShouldBuildTest.test_should_build): Does some basic testing to make
2206         sure we're triggering builds for the right files. It only tests
2207         Windows for now, though I tried to make some guesses about other
2208         platforms.
2209
2210 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2211
2212         Reviewed by Andreas Kling.
2213
2214         [Qt] Remove synchronous QWebPage::checkPermissions signal
2215         https://bugs.webkit.org/show_bug.cgi?id=46810
2216
2217         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2218         (WebCore::WebPage::WebPage):
2219         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2220         (LayoutTestController::grantDesktopNotificationPermission): When granting
2221         permission, grant it directly on the QWebPage/Frame, that will remember it.
2222         * QtTestBrowser/webpage.cpp:
2223         (WebPage::WebPage):
2224         * QtTestBrowser/webpage.h:
2225
2226
2227 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2228
2229         Reviewed by Csaba Osztrogonác.
2230
2231         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2232
2233         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2234         (LayoutTestController::reset):
2235         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2236         (LayoutTestController::isPrinting):
2237         (LayoutTestController::setPrinting):
2238
2239 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2240
2241         Reviewed by Andreas Kling.
2242
2243         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2244         https://bugs.webkit.org/show_bug.cgi?id=49587
2245
2246         * MiniBrowser/qt/BrowserView.cpp:
2247         (BrowserView::BrowserView): Added BackingStoreType
2248         argument to ctor. Propagating it to the QGraphicsWKView.
2249         * MiniBrowser/qt/BrowserView.h:
2250         * MiniBrowser/qt/BrowserWindow.cpp:
2251         (BrowserWindow::BrowserWindow):
2252         (BrowserWindow::newWindow): Create the new BrowserWindow
2253         with the same BackingStoreType that this instance has.
2254         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2255         * MiniBrowser/qt/main.cpp:
2256         (main): Use tiled backing store if got -tiled command line argument.
2257         Avoid redundant copy of command line args.
2258
2259 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2260
2261         Reviewed by Jeremy Orlow.
2262
2263         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2264         https://bugs.webkit.org/show_bug.cgi?id=48506
2265
2266         This ensures that there is one mock per page WebView / WebViewHost. This is a
2267         design constraint of the DeviceOrientationClientMock because the m_controller
2268         field can only store a pointer to a single instance of the corresponding
2269         DeviceOrientationController.
2270
2271         Test: fast/dom/DeviceOrientation/no-page-cache.html
2272
2273         * DumpRenderTree/chromium/LayoutTestController.cpp:
2274         (LayoutTestController::setMockDeviceOrientation):
2275         (LayoutTestController::deviceOrientationClientMock):
2276         * DumpRenderTree/chromium/LayoutTestController.h:
2277         * DumpRenderTree/chromium/WebViewHost.cpp:
2278         (WebViewHost::deviceOrientationClientMock):
2279         (WebViewHost::deviceOrientationClient):
2280         (WebViewHost::reset):
2281         * DumpRenderTree/chromium/WebViewHost.h:
2282
2283 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2284
2285         Reviewed by Andreas Kling.
2286
2287         [Qt][WK2] Avoid polling in WebKitTestRunner.
2288         https://bugs.webkit.org/show_bug.cgi?id=49542
2289
2290         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2291         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2292
2293         * WebKitTestRunner/TestController.cpp:
2294         (WTR::TestController::didFinishLoadForFrame):
2295         * WebKitTestRunner/TestController.h:
2296         * WebKitTestRunner/TestInvocation.cpp:
2297         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2298         * WebKitTestRunner/mac/TestControllerMac.mm:
2299         (WTR::TestController::notifyDone): Add method stub.
2300         * WebKitTestRunner/qt/TestControllerQt.cpp:
2301         (WTR::TestControllerRunLoop::instance):
2302         (WTR::TestControllerRunLoop::start):
2303         (WTR::TestControllerRunLoop::stop):
2304         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2305         (WTR::TestControllerRunLoop::timerEvent):
2306         (WTR::TestController::notifyDone):
2307         (WTR::TestController::platformRunUntil):
2308         * WebKitTestRunner/win/TestControllerWin.cpp:
2309         (WTR::TestController::notifyDone): Add method stub.
2310
2311 2010-11-15  Darin Adler  <darin@apple.com>
2312
2313         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2314
2315 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2316
2317         Reviewed by Andreas Kling.
2318
2319         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2320         https://bugs.webkit.org/show_bug.cgi?id=49544
2321
2322         Add the shortcut to BrowserWindow.
2323
2324         * MiniBrowser/qt/BrowserWindow.cpp:
2325         (BrowserWindow::BrowserWindow):
2326         (BrowserWindow::openLocation):
2327         * MiniBrowser/qt/BrowserWindow.h:
2328
2329 2010-11-14  David Levin  <levin@chromium.org>
2330
2331         Reviewed by Daniel Bates.
2332
2333         check-webkit-style should detect PassRefPtr usage in functions.
2334         https://bugs.webkit.org/show_bug.cgi?id=49513
2335
2336         * Scripts/webkitpy/style/checkers/cpp.py:
2337         (check_for_function_lengths): Revert a comment change that I
2338          accidentally made in r71986.
2339         (check_pass_ptr_usage): Added the code to do the check.
2340         (process_line): Added the call to check_pass_ptr_usage.
2341         (CppChecker): Added the new error category.
2342         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2343         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2344          testing purposes.
2345         (PassPtrTest::*): The class/functions to unit test the new
2346          functionality.
2347
2348 2010-11-14  David Levin  <levin@chromium.org>
2349
2350         Reviewed by Shinichiro Hamaji.
2351
2352         check-webkit-style function detection and the line count style checks should be separate.
2353         https://bugs.webkit.org/show_bug.cgi?id=49512
2354
2355         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2356         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2357           call the detection function and fix line counts in two places now that
2358           the code really only counts the lines in the body of the function.
2359
2360 2010-11-14  Andreas Kling  <kling@webkit.org>
2361
2362         Reviewed by Antonio Gomes.
2363
2364         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2365         https://bugs.webkit.org/show_bug.cgi?id=33438
2366
2367         Stifle "Unhandled variable" warning to match what the other
2368         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2369         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2370
2371         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2372         (webkit_test_plugin_get_value):
2373
2374 2010-11-13  David Levin  <levin@chromium.org>
2375
2376         Reviewed by Eric Seidel.
2377
2378         check-webkit-style function detection crashes on functions in templates.
2379         https://bugs.webkit.org/show_bug.cgi?id=49504
2380
2381         For example "template <bool shouldClose(const Element*)>".
2382
2383         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2384         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2385           function detection test to expose this issue.
2386
2387 2010-11-12  David Levin  <levin@chromium.org>
2388
2389         Reviewed by Shinichiro Hamaji.
2390
2391         check-webkit-style function detection doesn't detect indented functions declaractions.
2392         https://bugs.webkit.org/show_bug.cgi?id=49446
2393
2394         Indented function declarations occur inside class definitions, so
2395         they are a pretty common (and worth detecting).
2396
2397         * Scripts/webkitpy/style/checkers/cpp.py:
2398           Changed regex to allow indentation.
2399           Changed the function start detection to only happen when not in a
2400           function.
2401           Changed function end detection to work based on matching braces
2402           instead of finding a close brace at the beginning of the line.
2403           Fixed close_expression to do what it says when it doesn't find
2404           the close.
2405         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2406
2407 2010-11-12  Daniel Bates  <dbates@rim.com>
2408
2409         Rubber-stamped by Nikolas Zimmermann.
2410
2411         Make do-file-rename rename files in the directory WebKit2.
2412
2413         This also makes the list of searched directories in do-file-rename
2414         consistent with the list of searched directories in the script do-webcore-rename.
2415
2416         * Scripts/do-file-rename:
2417
2418 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2419
2420         Reviewed by James Robinson.
2421
2422         Attempt yet again to land the fix for bug 49360 (respecting
2423         set-webkit-configuration). We need to handle the cases where
2424         trying to run webkit-build-directory to find out where the
2425         default configuration might be fails (that shows up on some
2426         Chromium bots that apparently don't have perl installed).
2427
2428         https://bugs.webkit.org/show_bug.cgi?id=49360
2429
2430         * Scripts/webkitpy/layout_tests/port/config.py:
2431         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2432         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2433
2434 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2435
2436         Reviewed by Adam Barth.
2437
2438         webkit-patch land logs commit message twice
2439         https://bugs.webkit.org/show_bug.cgi?id=49482
2440
2441         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2442         that's just the commit message, which we now output following the
2443         actual commit.
2444
2445         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2446
2447 2010-11-12  Tony Chang  <tony@chromium.org>
2448
2449         Reviewed by Adam Barth.
2450
2451         run platform/chromium/plugins/script-object-invoke.html on all platforms
2452         https://bugs.webkit.org/show_bug.cgi?id=49280
2453
2454         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2455         (testScriptObjectInvoke):
2456         (pluginInvoke):
2457
2458 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2459
2460         Reviewed by Adam Barth.
2461
2462         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2463         https://bugs.webkit.org/show_bug.cgi?id=49471
2464
2465         Right now there's no indication of a successful commit.
2466
2467         * Scripts/webkitpy/tool/commands/download_unittest.py:
2468         * Scripts/webkitpy/tool/steps/commit.py:
2469
2470 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2471
2472         Reviewed by Ojan Vafai.
2473
2474         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2475         https://bugs.webkit.org/show_bug.cgi?id=49354
2476
2477         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2478
2479         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2480         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2481         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2482         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2483
2484 2010-11-12  Tony Chang  <tony@chromium.org>
2485
2486         Reviewed by Kent Tamura.
2487
2488         [chromium] Load a blank page when closing DRT WebViewHosts
2489         https://bugs.webkit.org/show_bug.cgi?id=49417
2490
2491         In test_shell, when we close a window, we first load about:blank
2492         and run GC to fire the destruction logic of the page.  In test_shell,
2493         this happens in ~TestShell.  In DRT, we manage virtual windows as
2494         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2495
2496         Managing focus is a bit trickier, since normally you would get window
2497         events to reset the focus to the right window.  We do it manually
2498         instead.
2499
2500         This fixes 2 plugin tests on DRT.
2501
2502         * DumpRenderTree/chromium/TestShell.cpp:
2503         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2504         (TestShell::closeWindow): Move widget close() to WVH destructor and
2505             manage focus manually.
2506         (TestShell::closeRemainingWindows): Comment typo.
2507         * DumpRenderTree/chromium/WebViewHost.cpp:
2508         (WebViewHost::closeWidget):
2509         (invokeCloseWidget):
2510         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2511             test_shell).
2512         (WebViewHost::~WebViewHost):
2513         * DumpRenderTree/chromium/WebViewHost.h:
2514
2515 2010-11-12  David Levin  <levin@chromium.org>
2516
2517         Reviewed by Adam Barth.
2518
2519         cpp.py needs some tidying.
2520         https://bugs.webkit.org/show_bug.cgi?id=49443
2521
2522         * Scripts/webkitpy/style/checkers/cpp.py:
2523           Fix parameter ordering for iteratively_replace_matches_with_char
2524           to mirror other similar functions (and improved comments, etc.)
2525           Also, use a python-ism (for/else) to get rid of a variable that
2526           was there to determine if something had been found in the loop.
2527
2528 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
2529
2530         Reviewed by James Robinson.
2531
2532         [Chromium/DRT] Make EventSendingController send complete touch events.
2533         https://bugs.webkit.org/show_bug.cgi?id=49285
2534
2535         * DumpRenderTree/chromium/EventSender.cpp:
2536         (EventSender::addTouchPoint):
2537         (EventSender::updateTouchPoint):
2538         (EventSender::sendCurrentTouchEvent):
2539
2540 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2541
2542         Unreviewed rollout of r71858.
2543
2544         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
2545         NaCl tests.
2546
2547         * Scripts/webkitpy/layout_tests/port/config.py:
2548         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
2549         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2550
2551 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
2552
2553         Reviewed by Kenneth Rohde Christiansen.
2554
2555         [Qt] TestController::runUntil doesn't honor the timeout parameter
2556         https://bugs.webkit.org/show_bug.cgi?id=48941
2557
2558         Implement the missing timeout of WebKitTestRunner for Qt.
2559
2560         A QElapsedTimer has been added to RunUntilConditionLoop in order
2561         to measure how long the loop has been running. When the timer
2562         is bigger or equal than the timeout, the loop ends even if the
2563         condition is not met.
2564
2565         * WebKitTestRunner/qt/TestControllerQt.cpp:
2566         (WTR::RunUntilConditionLoop::start):
2567         (WTR::RunUntilConditionLoop::run):
2568         (WTR::RunUntilConditionLoop::timerEvent):
2569         (WTR::TestController::platformRunUntil):
2570
2571 2010-11-11  David Levin  <levin@chromium.org>
2572
2573         Reviewed by Shinichiro Hamaji.
2574
2575         check-webkit-style function detection doesn't handle templates with spaces.
2576         https://bugs.webkit.org/show_bug.cgi?id=49427
2577
2578         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2579           finding the function name.
2580         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2581           template with a space.
2582
2583 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2584
2585         Reviewed by Shinichiro Hamaji.
2586
2587         Enable check-webkit-style on Qt files
2588         https://bugs.webkit.org/show_bug.cgi?id=48322
2589
2590         Adding exception for _q_... private slots and
2591         ..._data() methods in tests
2592
2593         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2594         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2595
2596 2010-11-11  David Levin  <levin@chromium.org>
2597
2598         Reviewed by Shinichiro Hamaji.
2599
2600         check-webkit-style function detection doesn't work for templates and destructors.
2601         https://bugs.webkit.org/show_bug.cgi?id=49425
2602
2603         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2604         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2605
2606 2010-11-11  Joone Hur  <joone@kldp.org>
2607
2608         Reviewed by Antonio Gomes.
2609
2610         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2611         https://bugs.webkit.org/show_bug.cgi?id=46598
2612
2613         Support nodesFromRect in DRT
2614
2615         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2616         (LayoutTestController::nodesFromRect):
2617
2618 2010-11-11  MORITA Hajime  <morrita@google.com>
2619
2620         Reviewed by Kent Tamura.
2621
2622         editing/selection/context-menu-on-text.html fails on chromium
2623         https://bugs.webkit.org/show_bug.cgi?id=45898
2624
2625         Enhance Chromium's EventSender::contextClick() to return
2626         array of menu strings. The implementation incomplete because
2627         Although actual context menu is implemented by the browser,
2628         it reflects editability of underlying context thus makes
2629         context-menu-on-text.html passed.
2630
2631         * DumpRenderTree/chromium/EventSender.cpp:
2632         (makeMenuItemStringsFor): Added.
2633         (EventSender::contextClick): Now returns array of menu strings.
2634         * DumpRenderTree/chromium/WebViewHost.cpp:
2635         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2636         (WebViewHost::clearContextMenuData): Added.
2637         (WebViewHost::lastContextMenuData): Added.
2638         * DumpRenderTree/chromium/WebViewHost.h:
2639
2640 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2641
2642         Unreviewed, build fix.
2643
2644         fix build breakage caused by fix for bug 49380 (r71858).
2645
2646         config_standalone needs to ensure that the packages it needs are
2647         in sys.path.
2648
2649         https://bugs.webkit.org/show_bug.cgi?id=49419
2650
2651         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2652
2653 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2654
2655         Reviewed by Adam Roben.
2656
2657         Fix NRWT to respect set-webkit-configuration again :(
2658
2659         This change fixes a typo in config.py that was causing the wrong
2660         value to be read initially and us never actually looking into
2661         the filesystem to get the default configuration.
2662
2663         * Scripts/webkitpy/layout_tests/port/config.py:
2664         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2665         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2666
2667 2010-11-11  Eric Seidel  <eric@webkit.org>
2668
2669         Reviewed by Adam Barth.
2670
2671         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2672         https://bugs.webkit.org/show_bug.cgi?id=49403
2673
2674         CommitterValidator really had nothing to do with bugzilla.py.
2675         I've put it next to committers.py for now since its rather tied to that file.
2676
2677         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2678         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2679         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2680         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2681         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2682         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2683         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2684         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2685         * Scripts/webkitpy/tool/bot/feeders.py:
2686         * Scripts/webkitpy/tool/commands/queues.py:
2687
2688 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2689
2690         Reviewed by Eric Seidel.
2691
2692         fix missing 'pid' argument for http lockfile checking on win32
2693         https://bugs.webkit.org/show_bug.cgi?id=49363
2694
2695         * Scripts/webkitpy/common/system/executive.py:
2696
2697 2010-11-11  Eric Seidel  <eric@webkit.org>
2698
2699         Rubber-stamped by Adam Barth.
2700
2701         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2702         https://bugs.webkit.org/show_bug.cgi?id=49402
2703
2704         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2705         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2706         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2707
2708 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2709
2710         Reviewed by Chris Fleizach.
2711
2712         Use IAccessibleComparable to compare accessibility objects.
2713         https://bugs.webkit.org/show_bug.cgi?id=49118
2714
2715         * DumpRenderTree/AccessibilityUIElement.cpp:
2716         (AccessibilityUIElement::isEqual):
2717         * DumpRenderTree/AccessibilityUIElement.h:
2718         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2719         (comparableObject):
2720         (AccessibilityUIElement::isEqual):
2721
2722 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2723
2724         Reviewed by David Hyatt.
2725
2726         HTML5 Ruby support should be mandatory feature
2727         https://bugs.webkit.org/show_bug.cgi?id=49272
2728
2729         Remove Ruby as optional feature.
2730
2731         * Scripts/build-webkit:
2732
2733 2010-11-10  Adam Roben  <aroben@apple.com>
2734
2735         Print VC++ Express build logs in the same order that the projects are
2736         built
2737
2738         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2739         in an unhelpful order
2740
2741         Reviewed by Eric Seidel.
2742
2743         * Scripts/print-vse-failure-logs:
2744         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2745         print-msvc-project-dependencies to figure out the order in which
2746         projects are built.
2747         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2748         based on their build order and project name.
2749         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2750         scripts directory from here...
2751         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2752         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2753         them.
2754
2755 2010-11-10  Adam Roben  <aroben@apple.com>
2756
2757         Only print the interesting text from VC++ Express build logs
2758
2759         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2760         output from print-vse-failure-logs
2761
2762         Reviewed by Eric Seidel.
2763
2764         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2765         added newly-required imports. Removed a comment that was essentially a
2766         FIXME, and is now fixed.
2767         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2768         BeautifulSoup to extract the relevant text from the build log.
2769         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2770
2771 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2772
2773         Reviewed by Tony Chang.
2774
2775         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2776         https://bugs.webkit.org/show_bug.cgi?id=49286
2777
2778         The tests in http/tests/security/XFrameOptions started to fail after
2779         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2780         logic to always assign identifiers to requests, even if we're not going
2781         to be dumping resource load callbacks at that point. These tests
2782         only call LayoutTestController.dumpResourceLoadCallbacks after the
2783         request is started, thus their expectations have "<unknown>" as the
2784         identifier. Change WebViewHost to the previous behavior, which also
2785         match the other ports'.
2786
2787         * DumpRenderTree/chromium/WebViewHost.cpp:
2788         (WebViewHost::assignIdentifierToRequest):
2789         (WebViewHost::removeIdentifierForRequest):
2790
2791 2010-11-08  Tony Chang  <tony@chromium.org>
2792
2793         Reviewed by Adam Barth.
2794
2795         run platform/chromium/plugins/return-npobject.html on all platforms
2796         https://bugs.webkit.org/show_bug.cgi?id=49103
2797
2798         This tests that we can get an NPObject returned through a method on
2799         an NPAPI Object.
2800
2801         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2802         (testCallbackReturn):
2803         (pluginInvoke):
2804
2805 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2806
2807         Unreviewed, rolling out r71672.
2808         http://trac.webkit.org/changeset/71672
2809         https://bugs.webkit.org/show_bug.cgi?id=49276
2810
2811         It doesn't work on Chromium Windows bot (Requested by Ossy on
2812         #webkit).
2813
2814         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2815         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2816         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2817
2818 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2819
2820         Reviewed by Tony Chang.
2821
2822         [NRWT] Make http locking similar to perl implementation
2823         https://bugs.webkit.org/show_bug.cgi?id=49187
2824
2825         * Scripts/webkitpy/common/system/file_lock.py: Added.
2826         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2827         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2828
2829 2010-11-09  James Kozianski  <koz@chromium.org>
2830
2831         Reviewed by Eric Seidel.
2832
2833         Clean up imports for webkit-patch.
2834         https://bugs.webkit.org/show_bug.cgi?id=49083
2835
2836         Move some imports from commands into main.py where they are used.
2837         Move command imports into the __init__ of the commands module.
2838
2839         * Scripts/webkitpy/tool/commands/__init__.py:
2840         * Scripts/webkitpy/tool/commands/download.py:
2841         * Scripts/webkitpy/tool/commands/queues.py:
2842         * Scripts/webkitpy/tool/main.py:
2843
2844 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2845
2846         Reviewed by Andreas Kling.
2847
2848         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2849         https://bugs.webkit.org/show_bug.cgi?id=49047
2850
2851         * QtTestBrowser/mainwindow.cpp:
2852         (MainWindow::setAddressUrl):
2853
2854 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2855
2856         Reviewed by Csaba Osztrogonác.
2857
2858         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2859         https://bugs.webkit.org/show_bug.cgi?id=49252
2860
2861         * Scripts/old-run-webkit-tests:
2862
2863 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2864
2865         Reviewed by Tor Arne Vestbø.
2866
2867         Output of old-run-webkit-tests is buggy in verbose mode
2868         https://bugs.webkit.org/show_bug.cgi?id=49249
2869
2870         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2871
2872 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2873
2874         Reviewed by Martin Robinson.
2875
2876         [GTK] Link with target name set does not work
2877         https://bugs.webkit.org/show_bug.cgi?id=48865
2878
2879         When a new page is created with a name (target=myFrame), the new
2880         mainFrame could not be found because they where not stored in the
2881         same PageGroup. As PageGroup are not exposed externally so the
2882         simpliest solution is to use a global page group name. This also fixes
2883         issue with visited link coloration across pages. After this change the
2884         private function webkit_web_view_set_group_name() was no longer used
2885         so it was removed completly.
2886
2887         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2888         (createWebView):
2889
2890 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2891
2892         Reviewed by Kent Tamura.
2893
2894         WebViewHost::reset() uses placement new.
2895         https://bugs.webkit.org/show_bug.cgi?id=49069
2896
2897         WebViewHost is using placement destruction / new to simulate a fresh
2898         WebViewHost object at the same address. This is because the WebView remains
2899         open across tests and maintains a pointer to the WebViewHost.
2900         This change resets member variables explictly instead of the placement new dance.
2901
2902         * DumpRenderTree/chromium/WebViewHost.cpp:
2903         (WebViewHost::WebViewHost):
2904         (WebViewHost::reset):
2905
2906 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2907
2908         Reviewed by Eric Seidel.
2909
2910         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
2911         It turns out that NRWT can't use the code in scm.find_checkout_root()
2912         because the Chromium bots don't do full checkouts of the WebKit
2913         tree; they only check out subdirectories like WebKitTools/Scripts.
2914         Until we can figure out a better approach for this, I've
2915         restored the base_dir-detecting code from NRWT, which works in
2916         any directory tree, scm or no.
2917
2918         This also restores the files modified in r71475 and r71474.
2919
2920         https://bugs.webkit.org/show_bug.cgi?id=49151
2921
2922         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2923         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2924
2925 2010-11-08  Eric Seidel  <eric@webkit.org>
2926
2927         Reviewed by Adam Barth.
2928
2929         webkit-patch failure-reason explodes if a build is missing
2930         https://bugs.webkit.org/show_bug.cgi?id=49195
2931
2932         This is likely a recent regression.  Adding a unit test for this case.
2933
2934         * Scripts/webkitpy/common/net/buildbot.py:
2935         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2936
2937 2010-11-08  Dan Bernstein  <mitz@apple.com>
2938
2939         Reviewed by Darin Adler.
2940
2941         Ignore the system scrollbar setting.
2942
2943         * DumpRenderTree/mac/DumpRenderTree.mm:
2944         (resetDefaultsToConsistentValues): Set the scrollbar default.
2945
2946 2010-11-05  Adam Roben  <aroben@apple.com>
2947
2948         Make webkitpy.common.system.executive_unittest pass when running under
2949         Win32 Python
2950
2951         Fixes <http://webkit.org/b/49033>.
2952
2953         Reviewed by Dave Levin and Eric Seidel.
2954
2955         * Scripts/webkitpy/common/system/executive.py:
2956         (Executive._run_command_with_teed_output): Pass the arguments through
2957         encode_argument_if_needed rather than using Cygwin-specific code here.
2958         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2959         the output.
2960         (Executive.run_command): Use encode_argument_if_needed to encode the
2961         arguments and child_process_encoding to decode the output.
2962         (Executive._child_process_encoding): Returns the encoding that should be
2963         used when communicating with child processes. On Windows we use mbcs,
2964         which maps to the current code page. On all other platforms we use
2965         UTF-8.
2966         (Executive._should_encode_child_process_arguments): Returns True if
2967         arguments to child processes need to be encoded. This is currently
2968         only needed on Cygwin and Win32 Python 2.x.
2969         (Executive._encode_argument_if_needed): Encode the argument using
2970         child_process_encoding if we need to encode arguments to child
2971         processes on this platform.
2972
2973         * Scripts/webkitpy/common/system/executive_unittest.py:
2974         (never_ending_command): Added. Returns arguments to run a command that
2975         will not quit until we kill it. On Windows we use wmic, on other
2976         platforms we use yes.
2977         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2978         mbcs encoding to be used and for output from the child processes to
2979         have been roundtripped through encode/decode on Win32 Python. When
2980         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2981         it's possible that some characters will not be able to be converted
2982         and will be replaced by question marks; the round-tripping allows us
2983         to expect this result.
2984
2985         (ExecutiveTest.test_kill_process):
2986         (ExecutiveTest.test_kill_all):
2987         Use never_ending_command instead of invoking "yes" directly. Expect an
2988         exit code of 1 when using Win32 Python, as that's what seems to happen.
2989
2990 2010-11-08  Adam Roben  <aroben@apple.com>
2991
2992         Roll out r71532
2993
2994         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2995         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2996
2997         * Scripts/webkitdirs.pm:
2998
2999 2010-11-08  Tony Chang  <tony@chromium.org>
3000
3001         Reviewed by Adam Barth.
3002
3003         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
3004         https://bugs.webkit.org/show_bug.cgi?id=49094
3005
3006         This tests that objects created by plugins are proplery cleaned up.
3007
3008         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3009         (testPassTestObject):
3010         (pluginInvoke):
3011         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3012         (testAllocate):
3013         (testDeallocate):
3014         (testGetProperty):
3015         (testConstruct):
3016
3017 2010-11-08  Adam Roben  <aroben@apple.com>
3018
3019         Mark Windows builds triggered from Perl as being non-interactive
3020
3021         This affects whether some of our scripts will show alerts vs. printing
3022         to the build log.
3023
3024         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
3025         .vsprops files are updated
3026
3027         Reviewed by Steve Falkenburg.
3028
3029         * Scripts/webkitdirs.pm:
3030         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
3031
3032 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3033
3034         Reviewed by Ojan Vafai.
3035
3036         Make http locking default in NRWT.
3037         https://bugs.webkit.org/show_bug.cgi?id=48053
3038
3039         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3040         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3041
3042 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3043
3044         Reviewed by Csaba Osztrogonác.
3045
3046         [NRWT] If the http lock fails we shouldn't do any locking
3047         https://bugs.webkit.org/show_bug.cgi?id=49164
3048
3049         If something goes wrong with the locking, the test should keep going.
3050
3051         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3052
3053 2010-11-08  Adam Roben  <aroben@apple.com>
3054
3055         Switch back to using kCGImageAlphaPremultipliedFirst when generating
3056         pixel dumps on Windows
3057
3058         I changed this behavior in r71418 thinking that it was required for
3059         getting plugins to show up in pixel dumps. But it doesn't seem to be
3060         necessary, and was making it impossible to compare new Windows pixel
3061         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
3062         compare an image with alpha to an image without alpha).
3063
3064         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
3065         new Windows pixel results to existing Windows or Mac results
3066
3067         Reviewed by Antti Koivisto.
3068
3069         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3070         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
3071         with kCGImageAlphaPremultipliedFirst.
3072
3073 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
3074
3075         Unreviewed, rolling out r71466.
3076         http://trac.webkit.org/changeset/71466
3077         https://bugs.webkit.org/show_bug.cgi?id=48865
3078
3079         It broke layout tests on GTK bots.
3080
3081         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3082         (createWebView):
3083
3084 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3085
3086         Reviewed by Csaba Osztrogonác.
3087
3088         Enable running of Qt API tests on BuildBot
3089         https://bugs.webkit.org/show_bug.cgi?id=49004
3090
3091         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3092
3093 2010-11-08  Eric Seidel  <eric@webkit.org>
3094
3095         Reviewed by Adam Barth.
3096
3097         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
3098         https://bugs.webkit.org/show_bug.cgi?id=49160
3099
3100         Bugzilla doesn't automatically remove r? when a bug gets closed.
3101         This script takes care of that for webkit.org.
3102
3103         * Scripts/webkitpy/common/net/bugzilla.py:
3104         * Scripts/webkitpy/tool/commands/upload.py:
3105
3106 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3107
3108         Unreviewed, rolling out r71474.
3109         http://trac.webkit.org/changeset/71474
3110         https://bugs.webkit.org/show_bug.cgi?id=48280
3111
3112         breaks chromium webkit tests
3113         https://bugs.webkit.org/show_bug.cgi?id=49151
3114
3115         * Scripts/webkitpy/layout_tests/port/base.py:
3116         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3117         * Scripts/webkitpy/layout_tests/port/config.py:
3118         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3119         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3120         * Scripts/webkitpy/layout_tests/port/webkit.py:
3121         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3122         * Scripts/webkitpy/tool/mocktool.py:
3123
3124 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3125
3126         Unreviewed, rolling out r71475.
3127         http://trac.webkit.org/changeset/71475
3128
3129         breaks chromium webkit tests
3130         https://bugs.webkit.org/show_bug.cgi?id=49151
3131
3132         * Scripts/webkitpy/common/newstringio.py: Removed.
3133         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
3134         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
3135         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
3136         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
3137
3138 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3139
3140         Unreviewed, build fix.
3141
3142         Add files inexplicably not committed in r71474 as part of the
3143         fix for bug 48280.
3144
3145         * Scripts/webkitpy/common/newstringio.py: Added.
3146         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3147         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3148         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3149         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
3150
3151 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3152
3153         Reviewed by Eric Siedel.
3154
3155         new-run-webkit-tests: update port/base and port/webkit to use the
3156         new FileSystem and Config abstractions, pulling more logic out of
3157         the base Port classes into separate, mockable objects.
3158
3159         Also create a MockFileSystem object, a MockConfig object, move
3160         MockExecutive into common/system to be next to executive, and
3161         update the config object to use a FileSystem.
3162
3163         https://bugs.webkit.org/show_bug.cgi?id=48280
3164
3165         * Scripts/webkitpy/common/newstringio.py: Added.
3166         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3167         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3168         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3169         * Scripts/webkitpy/layout_tests/port/base.py:
3170         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3171         * Scripts/webkitpy/layout_tests/port/config.py:
3172         * Scripts/webkitpy/layout_tests/port/config_mock.py:
3173         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3174         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3175         * Scripts/webkitpy/layout_tests/port/webkit.py:
3176         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3177         * Scripts/webkitpy/tool/mocktool.py:
3178
3179 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3180
3181         Unreviewed, build breakage.
3182
3183         Apparently I uploaded the wrong version of the file to fix 49122
3184         and neither Eric or I noticed - it was missing a dirname() call.
3185         Fixing ...
3186
3187         https://bugs.webkit.org/show_bug.cgi?id=49122
3188
3189         * Scripts/webkitpy/common/checkout/scm.py:
3190
3191 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3192
3193         Reviewed by Eric Seidel.
3194
3195         webkitpy/tool/* unittests change cwd and don't clean up properly
3196
3197         https://bugs.webkit.org/show_bug.cgi?id=49122
3198
3199         * Scripts/webkitpy/common/checkout/scm.py:
3200
3201 2010-11-05  Chris Marrin  <cmarrin@apple.com>
3202
3203         Reviewed by Simon Fraser.
3204
3205         suspendAnimations/resumeAnimations not present in WebKit2
3206         https://bugs.webkit.org/show_bug.cgi?id=49109
3207
3208         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3209         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3210         (WTR::LayoutTestController::suspendAnimations):
3211         (WTR::LayoutTestController::resumeAnimations):
3212         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3213
3214 2010-11-05  Tony Chang  <tony@chromium.org>
3215
3216         Reviewed by David Levin.
3217
3218         cleanup style in TestNetscapePlugIn/PluginObject.cpp
3219         https://bugs.webkit.org/show_bug.cgi?id=49044
3220
3221         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3222         (getPluginClass):
3223         (pluginGetProperty):
3224         (pluginSetProperty):
3225         (variantToIdentifier):
3226         (testCallback):
3227         (getURL):
3228         (getURLNotify):
3229         (testInvokeDefault):
3230         (testGetProperty):
3231         (testDocumentOpen):
3232         (testWindowOpen):
3233         (pluginInvoke):
3234         (handleCallback):
3235         (notifyStream):
3236         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3237
3238 2010-11-05  Eric Seidel  <eric@webkit.org>
3239
3240         Reviewed by David Levin.
3241
3242         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
3243         https://bugs.webkit.org/show_bug.cgi?id=49032
3244
3245         I wrote this file as part of bug 47847, but I forgot to commit it.
3246         No one else noticed it missing because test-webkitpy knows how
3247         to recover in the case where it can't import QueueStatusServer
3248         (which generally occurs due to not having installed the AppEngine SDK).
3249
3250         * QueueStatusServer/__init__.py: Added.
3251         * QueueStatusServer/model/workitems_unittest.py:
3252          - Remove a test which fails.  This was probably landed (by me)
3253            from my other machine, which since this __init__.py was missing
3254            I never noticed the failure and landed this invalid test.
3255            Sadly we can't really test remove_work_item as it depends
3256            on .key() working.  .key() will throw unless the object
3257            has already been saved it seems.
3258            This may be a mis-design in our remove_work_item implementation,
3259            but for now, just removing the test.
3260
3261 2010-11-04  Adam Roben  <aroben@apple.com>
3262
3263         Teach check-webkit-style about TestNetscapePlugIn
3264
3265         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
3266         TestNetscapePlugIn's coding conventions
3267
3268         Reviewed by John Sullivan.
3269
3270         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3271         WebKitAPITest and TestWebKitAPI in having different include order and
3272         naming conventions than WebCore. Added some comments about why the
3273         exceptions exist.
3274
3275 2010-11-04  Adam Roben  <aroben@apple.com>
3276
3277         Add a test that shows that windowed plugins are able to paint
3278
3279         Somehow we never had a test for this before.
3280
3281         Fixes <http://webkit.org/b/49029> Should add a test that shows
3282         windowed plugins can paint
3283
3284         Reviewed by Jon Honeycutt.
3285
3286         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3287         (DrawsGradient::DrawsGradient):
3288         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3289
3290         (DrawsGradient::onPaint):
3291         (DrawsGradient::onPrintClient):
3292         These both just call through to paint.
3293
3294         (DrawsGradient::paint): Fills our client area with some gradients.
3295
3296         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3297         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3298
3299         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3300         (createBitmapContextFromWebView): Use WM_PRINT instead of
3301         WM_PRINTCLIENT so that ::DefWindowProc will send
3302         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3303         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3304         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3305         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3306         will run on a big-endian platform.
3307
3308 2010-11-04  Adam Roben  <aroben@apple.com>
3309
3310         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3311         WindowedPluginTest base class
3312
3313         The base class takes care of subclassing the plugin's window so that a
3314         custom WNDPROC is called. This will make it easier to write tests that
3315         need to handle window messages.
3316
3317         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3318         a custom WNDPROC
3319
3320         Reviewed by Jon Honeycutt.
3321
3322         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3323         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3324         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3325         (NPNInvalidateRectInvalidatesWindow::wndProc):
3326         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3327         Moved code from here to WindowedPluginTest. Changed to use window()
3328         instead of m_window.
3329
3330         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3331         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3332         include path. Also reordered the include path to make a little more
3333         sense and simplified the entry that added TestNetscapePlugIn itself to
3334         the include path.
3335
3336         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3337         (WindowedPluginTest::WindowedPluginTest):
3338         (WindowedPluginTest::NPP_SetWindow):
3339         (WindowedPluginTest::staticWndProc):
3340         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3341         (WindowedPluginTest::window):
3342         Code came from NPNInvalidateRectInvalidatesWindow.
3343
3344 2010-11-04  Adam Roben  <aroben@apple.com>
3345
3346         Add a plugin test to show that windowed plugins are clipped correctly
3347
3348         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3349         plugins aren't clipped in WebKit2 on Windows
3350
3351         Reviewed by Jon Honeycutt.
3352
3353         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3354         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3355         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3356         region matches the clip rect we know we should have based on
3357         window-region-is-set-to-clip-rect.html, and check that our window class
3358         doesn't have the CS_PARENTDC style.
3359
3360         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3361         Added WindowRegionIsSetToClipRect.
3362
3363 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3364
3365         Reviewed by Martin Robinson.
3366
3367         [GTK] Avoid font hinting in the DRT
3368         https://bugs.webkit.org/show_bug.cgi?id=48548
3369
3370         Change the settings to avoid font hinting, it was causing
3371         different results depending on the distribution.
3372
3373         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3374         (initializeGtkFontSettings):
3375         * DumpRenderTree/gtk/fonts/fonts.conf:
3376
3377 2010-11-05  Eric Seidel  <eric@webkit.org>
3378
3379         Reviewed by Adam Barth.
3380
3381         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3382         https://bugs.webkit.org/show_bug.cgi?id=49051
3383
3384         This is a speculative fix.  The unit tests cover these methods, however
3385         I don't know if this will fully stop the system.log spam.
3386
3387         * Scripts/webkitpy/layout_tests/port/base.py:
3388         * Scripts/webkitpy/layout_tests/port/webkit.py:
3389
3390 2010-11-05  Eric Seidel  <eric@webkit.org>
3391
3392         Reviewed by Adam Barth.
3393
3394         Add basic support for showing bot id on /queue-status/ pages
3395         https://bugs.webkit.org/show_bug.cgi?id=49037
3396
3397         This support is really simple.  Eventually we'll want to
3398         show the bot id in the lock table too, but we don't have
3399         that information stored in the server yet.
3400
3401         * QueueStatusServer/handlers/queuestatus.py:
3402         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3403         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3404
3405 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3406
3407         Reviewed by Adam Barth.
3408
3409         Create a filesystem wrapper that we can use to enforce
3410         particular conventions and use for mocking and dependency
3411         injection down the line.
3412
3413         https://bugs.webkit.org/show_bug.cgi?id=48144
3414
3415         * Scripts/webkitpy/common/system/filesystem.py: Added.
3416         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3417
3418 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3419
3420         Reviewed by Tony Chang.
3421
3422         run_webkit_tests_unittest fails under Python 2.5
3423         https://bugs.webkit.org/show_bug.cgi?id=49043
3424
3425         Switch from itertools.chain.from_iterable (which was added in 2.6)
3426         to using itertools.chain directly.
3427
3428         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3429
3430 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3431
3432         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3433         Python 2.5 (it needs an import to use the with statement).
3434
3435         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3436
3437 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3438
3439         Reviewed by Adam Barth.
3440
3441         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3442
3443         The current NRWT code has webkit-specific configuration code (like
3444         _script_path, default configuration, etc.) mixed in with
3445         layout-test-specific stuff in port/base. The configuration code
3446         should be split out into a separate module for easier mocking,
3447         testing, and isolation.
3448
3449         https://bugs.webkit.org/show_bug.cgi?id=48264
3450
3451         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3452         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3453
3454 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3455
3456         Reviewed by Tony Chang.
3457
3458         Rebaseline server: initial framework
3459         https://bugs.webkit.org/show_bug.cgi?id=48892
3460
3461         Adds the basic framework for the rebaseline server (details at
3462         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
3463         command, which starts an HTTP server that can serve static files or
3464         invoke handler methods on a class.
3465
3466         * Scripts/webkitpy/tool/commands/__init__.py:
3467         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
3468         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
3469         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
3470         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
3471
3472 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3473
3474         Reviewed by James Robinson.
3475
3476         new-run-webkit-tests wasn't using DRT by default for
3477         --platform chromium-gpu
3478
3479         The default value was set to False instead of None, which meant
3480         that the platform specific logic wasn't firing to change the
3481         value to True (b/c we were afraid we'd be overriding the user
3482         preference).
3483
3484         https://bugs.webkit.org/show_bug.cgi?id=49038
3485
3486         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3487
3488 2010-11-04  Tony Chang  <tony@chromium.org>
3489
3490         Reviewed by Adam Barth.
3491
3492         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
3493         https://bugs.webkit.org/show_bug.cgi?id=49026
3494
3495         Have the testObject.bar property return the string "bar".  This lets
3496         us run and pass platform/chromium/plugins/multiple-plugins.html on all
3497         platforms.
3498
3499         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3500         (testGetProperty):
3501
3502 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3503
3504         Reviewed by Tony Chang.
3505
3506         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
3507         https://bugs.webkit.org/show_bug.cgi?id=48878
3508
3509         Add get_tests_run so that it's easy to see which tests get run (and with
3510         what batching) for a given flag combination. Flesh out the various
3511         test cases that have FIXMEs.
3512
3513         Also fixes an off-by-one error (batch sizes were one larger than
3514         expected) and makes --run-part also have wraparound behavior, like
3515         --run-chunk.
3516
3517         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3519         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3520
3521 2010-11-04  Erik Arvidsson  <arv@chromium.org>
3522
3523         Reviewed by Dimitri Glazkov.
3524
3525         Support box-sizing without the vendor prefix
3526         https://bugs.webkit.org/show_bug.cgi?id=36713
3527
3528         Based on patch by Peter Beverloo <peter@lvp-media.com>
3529
3530         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
3531
3532 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3533
3534         Unreviewed rollout r71340, because it broke Chromium Windows bot.
3535
3536         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3537         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3538
3539 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3540
3541         Reviewed by Ojan Vafai.
3542
3543         Make http locking default in NRWT.
3544         https://bugs.webkit.org/show_bug.cgi?id=48053
3545
3546         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3547         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3548
3549 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3550
3551         Reviewed by Eric Seidel.
3552
3553         [NRWT] Clear invalid http locks on Windows platform as well
3554         https://bugs.webkit.org/show_bug.cgi?id=48515
3555
3556         * Scripts/webkitpy/common/system/executive.py:
3557         * Scripts/webkitpy/common/system/executive_unittest.py:
3558         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3559
3560 2010-11-02  Adam Roben  <aroben@apple.com>
3561
3562         Reduce our dependence on coreutils when running Python tests
3563
3564         This patch introduces versions of the standard echo and cat utilities
3565         implemented in Python. They are probably missing features of their
3566         coreutils equivalents, but they can do what's necessary for our Python
3567         tests. This is useful on Windows, where these utilities typically
3568         aren't available.
3569
3570         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3571         and cat utilities from coreutils, which are not present on Windows
3572
3573         Reviewed by Eric Seidel.
3574
3575         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3576         our Python-based echo and cat.
3577
3578         * Scripts/webkitpy/common/system/fileutils.py: Added.
3579         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3580         that \n won't be translated into \r\n. I couldn't think of a good way
3581         to test this directly without touching the filesystem, but it is tested
3582         indirectly by echo_unittest.
3583
3584         * Scripts/webkitpy/test/cat.py: Added.
3585         (command_arguments): Returns a list for invoking cat with the given arguments.
3586         (main): Acts like a simplified version of the coreutils cat utility.
3587
3588         * Scripts/webkitpy/test/cat_unittest.py: Added.
3589         (CatTest.assert_cat): Runs cat with the given input and ensures the
3590         output matches the input.
3591         (CatTest.test_basic): Performs a simple test of cat.
3592         (CatTest.test_no_newline): Tests what happens when the input string
3593         doesn't have a trailing newline.
3594         (CatTest.test_unicode): Tests passing a unicode string to cat.
3595         (CatTest.test_as_command): Tests running cat as a separate command.
3596
3597         * Scripts/webkitpy/test/echo.py: Added.
3598         (command_arguments): Returns a list for invoking echo with the given arguments.
3599         (main): Acts like a simplified version of the coreutils echo utility.
3600
3601         * Scripts/webkitpy/test/echo_unittest.py: Added.
3602         (EchoTest.test_basic): Performs a simple test of echo.
3603         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3604         trailing newline.
3605         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3606         to echo.
3607         (EchoTest.test_argument_order): Tests what happens when -n is not the
3608         first argument.
3609         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3610         echo.main.
3611         (EchoTest.test_no_arguments): Tests what happens when you call
3612         echo.main with no arguments.
3613         (EchoTest.test_as_command): Tests running echo as a separate command.
3614
3615 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3616
3617         Unreviewed: Add myself to the list of Committers.
3618
3619         * Scripts/webkitpy/common/config/committers.py:
3620
3621 2010-11-04  Andreas Kling  <kling@webkit.org>
3622
3623         Reviewed by Kenneth Rohde Christiansen.
3624
3625         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3626
3627         In RTC mode the QGraphicsWebView item is the size of the contents,
3628         scrolling works a bit differently  (we need to react to scrollRequested.)
3629
3630         Normally QGraphicsView will replay the last mouse event when scrolling,
3631         so to prevent WebKit from getting confused by this we temporarily make
3632         the QGraphicsView non-interactive.
3633
3634         * QtTestBrowser/webview.cpp:
3635         (WebViewGraphicsBased::setPage):
3636         (WebViewGraphicsBased::scrollRequested):
3637         * QtTestBrowser/webview.h:
3638
3639 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3640
3641         Reviewed by Andreas Kling.
3642
3643         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3644
3645         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3646         the Mac-port, not the Mac OS X operating system.
3647
3648         * WebKitTestRunner/qt/TestControllerQt.cpp:
3649         (WTR::isExistingLibrary):
3650
3651 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3652
3653         Reviewed by Andreas Kling.
3654
3655         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3656         https://bugs.webkit.org/show_bug.cgi?id=48869
3657
3658         * QtTestBrowser/useragentlist.txt: