2010-07-11 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         Implement waitUntilDone and notifyDone for WebKitTestRunner
6         https://bugs.webkit.org/show_bug.cgi?id=42049
7
8         With this fix, most of the DOM tests pass.
9         
10         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
11         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
12         a great way to do it in the future case where we may get multiple
13         pages - we really need a way to send it over from the ui process.
14         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
15         (WTR::InjectedBundle::page): A way to get the main page.
16         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
17         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
18         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
19         are loading.
20         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
21         called by the layout test controller. Also, cancel any pending watchdogs.
22         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
23         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
24         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
25         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
26         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
27         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
28         to false.
29         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
30         the watchdog.
31         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
32         (WTR::LayoutTestController::setWaitToDump): Set the flag.
33         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
34         where waitUntilDone times out.
35         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
36         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
37         (WTR::notifyDoneCallback): JS glue for notifyDone.
38         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
39         to the layoutController.
40         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
41         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
42
43 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
44
45         Rubber-stamped by Dan Bernstein.
46
47         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
48         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
49         slow down the tests).
50
51         * Scripts/webkitpy/common/system/executive.py:
52
53 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
54
55         Reviewed by Kenneth Rohde Christiansen.
56
57         [Qt] Mac build fix
58         https://bugs.webkit.org/show_bug.cgi?id=41967
59
60         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
61
62         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
63
64 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
65
66         Reviewed by Antonio Gomes.
67
68         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
69         https://bugs.webkit.org/show_bug.cgi?id=41966
70
71         * MiniBrowser/qt/BrowserWindow.cpp:
72         (BrowserWindow::BrowserWindow):
73
74 2010-07-09  Leon Clarke  <leonclarke@google.com>
75
76         Reviewed by Adam Barth.
77
78         add support for link prefetching
79         https://bugs.webkit.org/show_bug.cgi?id=3652
80
81         * Scripts/build-webkit:
82
83 2010-07-09  Ojan Vafai  <ojan@chromium.org>
84
85         Reviewed by Adam Barth.
86
87         r63004 broke some python tests
88         https://bugs.webkit.org/show_bug.cgi?id=42007
89
90         AbstractStep now checks options.no_squash and options.squash, so
91         they needed to have real values. Mock would return an object for those,
92         which would then act as if the values were True.
93
94         * Scripts/webkitpy/tool/commands/commandtest.py:
95         * Scripts/webkitpy/tool/commands/download_unittest.py:
96         * Scripts/webkitpy/tool/commands/stepsequence.py:
97         * Scripts/webkitpy/tool/commands/upload_unittest.py:
98         * Scripts/webkitpy/tool/mocktool.py:
99         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
100         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
101         * Scripts/webkitpy/tool/steps/steps_unittest.py:
102         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
103         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
104
105 2010-07-09  Ojan Vafai  <ojan@chromium.org>
106
107         Reviewed by Adam Barth.
108
109         --squash should go away and become the default
110         https://bugs.webkit.org/show_bug.cgi?id=39624
111
112         If there are local commits and working copy changes, then prompt the user
113         whether to continue. Setting git config webkit-patch.commit_should_always_squash
114         true bypasses the prompt.
115
116         --git-commit=HEAD.. operates on working copy changes only.
117         --git-commit=committish operates on a range of commits as a single commit.
118             e.g. --git-commit=HEAD only operates on the HEAD commit.
119             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
120
121         --no-squash and --squash are left in with descriptive error messages if used.
122
123         * Scripts/check-webkit-style:
124         * Scripts/webkitpy/common/checkout/api.py:
125         * Scripts/webkitpy/common/checkout/api_unittest.py:
126         * Scripts/webkitpy/common/checkout/scm.py:
127         * Scripts/webkitpy/common/checkout/scm_unittest.py:
128         * Scripts/webkitpy/common/net/rietveld.py:
129         * Scripts/webkitpy/common/system/user.py:
130         * Scripts/webkitpy/style/optparser.py:
131         * Scripts/webkitpy/style_references.py:
132         * Scripts/webkitpy/tool/commands/download.py:
133         * Scripts/webkitpy/tool/commands/upload.py:
134         * Scripts/webkitpy/tool/mocktool.py:
135         * Scripts/webkitpy/tool/steps/abstractstep.py:
136         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
137         * Scripts/webkitpy/tool/steps/checkstyle.py:
138         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
139         * Scripts/webkitpy/tool/steps/commit.py:
140         * Scripts/webkitpy/tool/steps/options.py:
141         * Scripts/webkitpy/tool/steps/preparechangelog.py:
142         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
143         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
144         * Scripts/webkitpy/tool/steps/validatereviewer.py:
145
146 2010-07-09  Mark Rowe  <mrowe@apple.com>
147
148         Add two new Windows test build slaves.
149
150         * BuildSlaveSupport/build.webkit.org-config/config.json:
151
152 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
153
154         Reviewed by David Levin.
155
156         rebaseline_chromium_webkit_tests missing --use_drt option on linux
157         https://bugs.webkit.org/show_bug.cgi?id=41985
158
159         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
160         so that it works on linux. This is essentially a "compile-fix" for the
161         script.
162
163         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
164
165 2010-07-09  Nico Weber  <thakis@chromium.org>
166
167         Unreviewed. Adding myself as committer.
168
169         * Scripts/webkitpy/common/config/committers.py:
170
171 2010-07-09  David Kilzer  <ddkilzer@apple.com>
172
173         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
174
175         This reverts commit r62692.
176
177         * Scripts/commit-log-editor:
178
179 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
180
181         Reviewed by Ojan Vafai.
182
183         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
184         https://bugs.webkit.org/show_bug.cgi?id=38693
185
186         Introduced a new base class JSONResultsGeneratorBase that doesn't
187         have any dependency on layout_tests packages.
188         Turned JSONResultsGenerator into a wrapper class of the base class
189         so that the old code can work with it during the cleanup.
190
191         Added json_results_generator_unittest.py.
192
193         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
194         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
195         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
196
197 2010-07-09  Abhishek Arya  <inferno@chromium.org>
198
199         Unreviewed.
200
201         Marking myself as a committer.
202
203         * Scripts/webkitpy/common/config/committers.py:
204
205 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
206
207         Reviewed by Antti Koivisto.
208
209         Implement MiniBrowser for Qt.
210         https://bugs.webkit.org/show_bug.cgi?id=40233
211
212         * MiniBrowser/qt/BrowserWindow.cpp: Added.
213         (createNewPage):
214         (BrowserView::BrowserView):
215         (BrowserView::resizeEvent):
216         (BrowserView::load):
217         (BrowserView::view):
218         (BrowserWindow::BrowserWindow):
219         (BrowserWindow::load):
220         (BrowserWindow::changeLocation):
221         (BrowserWindow::~BrowserWindow):
222         * MiniBrowser/qt/BrowserWindow.h: Added.
223         (BrowserView::~BrowserView):
224         * MiniBrowser/qt/MiniBrowser.pro: Added.
225         * MiniBrowser/qt/main.cpp: Added.
226         (main):
227
228 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
229
230         Reviewed by Simon Hausmann.
231
232         Introduce the Qt autotest launcher.
233
234         Qt autotests should be executed more frequently, ideally by the Qt
235         build bot. This is the first step to provide the tests more accessible.
236
237         [Qt] It should be easier to run all Qt's autotests.
238         https://bugs.webkit.org/show_bug.cgi?id=31625
239
240         * Scripts/run-qtwebkit-tests: Added.
241
242 2010-07-09  Adam Barth  <abarth@webkit.org>
243
244         Reviewed by Eric Seidel.
245
246         commit-queue should merge to TOT when checkout needs update
247         https://bugs.webkit.org/show_bug.cgi?id=41944
248
249         There are a bunch of different designs that are possible here.  This
250         one merges to top of tree by cleaning out the working copy and
251         re-applying the patch.  Once you decide to merge that way, you need to
252         decide who's going to retry.  In this patch, we retry in the child
253         process instead of plumbing the failure reason to the master process.
254
255         This patch is difficult to test end-to-end, but hopefully it will work.
256         :)
257
258         * Scripts/webkitpy/tool/commands/queues.py:
259         * Scripts/webkitpy/tool/commands/stepsequence.py:
260         * Scripts/webkitpy/tool/multicommandtool.py:
261         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
262
263 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
264
265         Reviewed by Darin Adler.
266
267         Add a script to check for unnecessary includes in header files.
268         https://bugs.webkit.org/show_bug.cgi?id=41894
269
270         * Scripts/check-header-includes: Added.
271
272 2010-07-09  Adam Barth  <abarth@webkit.org>
273
274         Reviewed by Eric Seidel.
275
276         Add --html5-treebuilder option to run-webkit-tests
277         https://bugs.webkit.org/show_bug.cgi?id=41922
278
279         We're down to one or two regressions in the HTML5lib test suite.  It's
280         getting to be time to look at fixing LayoutTests.
281
282         * Scripts/old-run-webkit-tests:
283
284 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
285
286         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
287         in the drawing model never getting set on Tiger.
288
289         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
290         (NPP_New):
291
292 2010-07-08  Aaron Boodman  <aa@chromium.org>
293
294         Reviewed by Timothy Hatcher.
295
296         Add the ability for user scripts and user styles to affect just the top frame.
297
298         https://bugs.webkit.org/show_bug.cgi?id=41529
299
300         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
301         * DumpRenderTree/LayoutTestController.cpp: Ditto.
302         (addUserScriptCallback):
303         (addUserStyleSheetCallback):
304         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
305         (LayoutTestController::addUserScript):
306         (LayoutTestController::addUserStyleSheet):
307         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
308         (LayoutTestController::addUserScript):
309         (LayoutTestController::addUserStyleSheet):
310         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
311         (LayoutTestController::addUserScript):
312         (LayoutTestController::addUserStyleSheet):
313         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
314         (LayoutTestController::addUserScript):
315         (LayoutTestController::addUserStyleSheet):
316         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
317         (LayoutTestController::addUserScript):
318         (LayoutTestController::addUserStyleSheet):
319
320 2010-07-08  Adele Peterson  <adele@apple.com>
321
322         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
323
324         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
325         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
326
327         Log when the missing plugin button is pressed.
328
329         * DumpRenderTree/mac/UIDelegate.mm:
330         (-[UIDelegate webView:didPressMissingPluginButton:]):
331         * DumpRenderTree/win/UIDelegate.cpp:
332         (UIDelegate::QueryInterface):
333         (UIDelegate::createWebViewWithRequest):
334         (UIDelegate::drawBackground):
335         (UIDelegate::decidePolicyForGeolocationRequest):
336         (UIDelegate::didPressMissingPluginButton):
337         * DumpRenderTree/win/UIDelegate.h:
338
339 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
340
341         Fix the Tiger build.
342
343         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
344         (NPP_New):
345
346 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
347
348         Fix windows build.
349
350         #ifdef code for Mac.
351
352         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
353         (NPP_New):
354
355 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
356
357         Reviewed by Anders Carlsson.
358
359         Allow the TestPlugin to use Core Animation rendering for testing
360         https://bugs.webkit.org/show_bug.cgi?id=41872
361         
362         Add the ability for the TestPlugin to use the CoreAnimation rendering model
363         when available, based on the "drawingmodel" attribute of the embed tag:
364             drawingmodel="coreanimation"
365
366         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
367         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
368         when building on Tiger. Add a void* coreAnimationLayer member.
369         
370         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
371         (createCoreAnimationLayer): Obj-C method to create the CALayer.
372         
373         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
374         (NPP_New): Look for the drawingmodel attribute to decide which drawing
375         model to use.
376         (NPP_Destroy): Release the CALayer if we have one.
377         (NPP_GetValue): Return the retained CALayer.
378
379 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
380
381         Reviewed by Xan Lopez.
382
383         [GTK] Support pixel tests
384         https://bugs.webkit.org/show_bug.cgi?id=31518
385
386         Convert this file from CRLF to NL line endings. It will soon
387         be used on more than just the WinCairo platform.
388
389         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
390         (writeFunction):
391         (printPNG):
392         (computeMD5HashStringForBitmapContext):
393         (dumpBitmap):
394
395 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
396
397         Reviewed by Darin Adler.
398
399         Enable Data Execution Prevention for our test harnesses on Windows
400         https://bugs.webkit.org/show_bug.cgi?id=41882
401
402         * DumpRenderTree/win/DumpRenderTree.vcproj:
403         * DumpRenderTree/win/ImageDiff.vcproj:
404         * WebKitAPITest/WebKitAPITest.vcproj:
405         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
406
407 2010-07-07  Robert Hogan  <robert@webkit.org>
408
409         Reviewed by Kenneth Rohde Christiansen.
410
411         [Qt] Add DRT support for pageProperty etc.
412
413         https://bugs.webkit.org/show_bug.cgi?id=41584
414
415         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
416         (LayoutTestController::isPageBoxVisible):
417         (LayoutTestController::pageSizeAndMarginsInPixels):
418         (LayoutTestController::pageProperty):
419         (LayoutTestController::addUserStyleSheet):
420         * DumpRenderTree/qt/LayoutTestControllerQt.h:
421
422 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
423
424         Reviewed by Xan Lopez.
425
426         Remove a warnings from the ImageDiff build by using the proper
427         printf format string for the gsize data type.
428
429         * DumpRenderTree/gtk/ImageDiff.cpp:
430         (printImage): Use the proper printf format string for the gsize data type.
431
432 2010-07-08  Alice Liu  <alice.liu@apple.com>
433
434         Reviewed by Sam Weinig.
435
436         https://bugs.webkit.org/show_bug.cgi?id=41653
437         Add new WebKitTestRunner project for Windows
438
439         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
440         Similar to how it's done in DumpRenderTree, define max and min early
441         on so that they don't get replaced by a macro requiring 2 arguments.
442
443         * WebKitTestRunner/win: Added.
444         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
445         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
446         * WebKitTestRunner/win/main.cpp: Added.
447         (main): Implemented
448
449         Added these files with stubbed out functions:
450         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
451         (WTR::PlatformWebView::PlatformWebView):
452         (WTR::PlatformWebView::~PlatformWebView):
453         (WTR::PlatformWebView::page):
454         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
455         (WTR::TestController::initializeInjectedBundlePath):
456         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
457         (WTR::TestInvocation::runUntil):
458
459 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
460
461         Reviewed by Gustavo Noronha Silva.
462
463         [GTK] Implement ImageDiff and add it to the build system
464         https://bugs.webkit.org/show_bug.cgi?id=41779
465
466         Add the initial implementation of the ImageDiff tool for the GTK+
467         port. This is an essential tool for doing pixel tests. The implementation
468         is based on the Mac and Chromium ports.
469
470         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
471         (readPixbufFromStdin): Added.
472         (differenceImageFromDifferenceBuffer): Ditto.
473         (calculateDifference): Ditto.
474         (printImage): Ditto.
475         (printImageDifferences): Ditto.
476         (main): Ditto.
477         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
478
479 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
480
481         Unreviewed. Adding myself as a committer.
482
483         * Scripts/webkitpy/common/config/committers.py:
484
485 2010-07-08  Adam Roben  <aroben@apple.com>
486
487         Make Windows stop running tests from platform/mac
488
489         r62742 made a change (at my suggestion!) that caused us to start
490         looking for tests in platform/mac, rather than just looking for
491         expected results in platform/mac. This patch just undoes that part of
492         r62742.
493
494         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
495         tests from platform/mac, but shouldn't
496
497         Reviewed by Antti Koivisto and Anders Carlsson.
498
499         * Scripts/old-run-webkit-tests:
500         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
501         so we won't look in those directories for tests to run.
502         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
503         platform/mac-snowleopard and platform/mac for expected results.
504
505 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
506
507         Unreviewed. Adding myself as a reviewer.
508
509         * Scripts/webkitpy/common/config/committers.py:
510
511 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
512
513         Update my e-mail in committers.py
514
515         * Scripts/webkitpy/common/config/committers.py:
516
517 2010-07-07  Daniel Bates  <dbates@rim.com>
518
519         Reviewed by Dumitru Daniliuc.
520
521         VCSUtils.pm complains about uninitialized value $newLine
522         https://bugs.webkit.org/show_bug.cgi?id=41333
523
524         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
525         an array when fixing a change log entry that overlaps with an earlier
526         entry. In particular, when a patch contains a change log entry inserted
527         earlier in the change log file, but after an entry with the same author
528         and date.
529
530         * Scripts/VCSUtils.pm:
531             - Added for-loop constraint to fixChangeLogPatch() so that it does not
532               read off the end of the @overlappingLines array.
533         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
534
535 2010-07-07  Anders Carlsson  <andersca@apple.com>
536
537         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
538
539         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
540         (NPP_New):
541
542 2010-07-07  Kent Tamura  <tkent@chromium.org>
543
544         Reviewed by Adam Barth.
545
546         [DRT/Chromium] Support for indeterminate checkbox
547         https://bugs.webkit.org/show_bug.cgi?id=41747
548
549         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
550
551         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
552         (WebThemeControlDRT::draw):
553         * DumpRenderTree/chromium/WebThemeControlDRT.h:
554         (WebThemeControlDRT::):
555         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
556         (WebThemeEngineDRT::paintButton):
557
558 2010-07-07  Sam Weinig  <sam@webkit.org>
559
560         Reviewed by Mark Rowe.
561
562         Clean up MiniBrowser Xcode project.
563
564         - Use xcconfig files.
565         - Rename plists to canonical Info.plist
566         - Remove localizations.
567
568         * MiniBrowser/Configurations: Added.
569         * MiniBrowser/Configurations/Base.xcconfig: Added.
570         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
571         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
572         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
573         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
574         * MiniBrowser/WebBundle-Info.plist: Removed.
575         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
576         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
577         * MiniBrowser/mac/BrowserWindow.xib: Added.
578         * MiniBrowser/mac/BrowserWindowController.m:
579         (-[BrowserWindowController initWithPageNamespace:]):
580         * MiniBrowser/mac/English.lproj: Removed.
581         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
582         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
583         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
584         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
585         * MiniBrowser/mac/MainMenu.xib: Added.
586         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
587         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
588
589 2010-07-07  Kent Tamura  <tkent@chromium.org>
590
591         Reviewed by Dimitri Glazkov.
592
593         [DRT/Chromium] Fix two regressions
594         https://bugs.webkit.org/show_bug.cgi?id=41745
595
596         * DumpRenderTree/chromium/WebViewHost.cpp:
597         (WebViewHost::paintInvalidatedRegion):
598          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
599          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
600          though test_shell does it twice. Probably DRT needs it because
601          DRT delays painting as possible.
602
603 2010-07-07  Anders Carlsson  <andersca@apple.com>
604
605         Try to fix build.
606
607         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
608         (webkit_test_plugin_destroy_stream):
609
610 2010-07-07  Anders Carlsson  <andersca@apple.com>
611
612         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
613
614         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
615         (webkit_test_plugin_new_stream):
616         (webkit_test_plugin_destroy_stream):
617         (webkit_test_plugin_write_ready):
618         (webkit_test_plugin_write):
619
620 2010-07-07  Sam Weinig  <sam@webkit.org>
621
622         Reviewed by Mark Rowe.
623
624         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
625
626         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
627
628 2010-07-07  Anders Carlsson  <andersca@apple.com>
629
630         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
631
632         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
633         (NPP_New):
634         (NPP_HandleEvent):
635
636 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
637
638         Reviewed by Adam Roben.
639
640         Need to have a way to specify different results for Windows XP and 7
641         https://bugs.webkit.org/show_bug.cgi?id=41776
642         
643         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
644         subdirectories, so we can have different results for tests on Windows XP, Windows
645         Vista, and Windows 7.
646
647         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
648         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
649         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
650
651         This matches the behavior of the mac.
652
653         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
654             or Vista, try looking in other win-* subdirectories before win.
655         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
656             we are running.
657
658 2010-07-07  Kent Tamura  <tkent@chromium.org>
659
660         Reviewed by Dimitri Glazkov.
661
662         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
663         https://bugs.webkit.org/show_bug.cgi?id=41753
664
665         The original code of the following functions in
666         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
667         ASSERT_NOT_REACHED(). The program shouldn't stop at these
668         functions.
669
670         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
671         (DRTDevToolsClient::activateWindow):
672         (DRTDevToolsClient::closeWindow):
673         (DRTDevToolsClient::dockWindow):
674         (DRTDevToolsClient::undockWindow):
675
676 2010-07-07  Anders Carlsson  <andersca@apple.com>
677
678         Reviewed by Sam Weinig.
679
680         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
681         https://bugs.webkit.org/show_bug.cgi?id=41821
682
683         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
684         (pluginGetProperty):
685         (pluginSetProperty):
686         (pluginAllocate):
687         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
688         Add and initialize the returnNegativeOneFromWrite property.
689
690         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
691         (NPP_NewStream):
692         Set the stream type to NP_NORMAL so we'll get write callbacks.
693
694         (NPP_DestroyStream):
695         Treat the onstreamdestroy attribute as a function name and not a string.
696
697         (NPP_WriteReady):
698         Have this return a nonzero value.
699
700         (NPP_Write):
701         If returnNegativeOneFromWrite is true return -1.
702
703 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
704
705         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
706         latest version is selected by default, and allows the version to be specified.
707
708         * wx/build/settings.py:
709
710 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
711
712         Reviewed by Darin Adler.
713
714         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
715         https://bugs.webkit.org/show_bug.cgi?id=41810
716
717         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
718         (AccessibilityUIElement::selectedTextRange):
719
720 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
721
722         Unreviewed.
723
724         Build fix after r62700.
725
726         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
727         source file locations.
728
729 2010-07-07  Ojan Vafai  <ojan@chromium.org>
730
731         Reviewed by David Levin.
732
733         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
734         https://bugs.webkit.org/show_bug.cgi?id=41814
735
736         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
737         * Scripts/old-run-webkit-tests:
738
739 2010-07-07  Ojan Vafai  <ojan@chromium.org>
740
741         Reviewed by David Levin.
742
743         add --exit-after-n-crashes to run-webkit-tests
744         https://bugs.webkit.org/show_bug.cgi?id=41811
745
746         Change the bots at build.webkit.org to use --exit-after-n-crashes
747         instead of --exit-after-n-failures since we want to be able to have
748         more than 20 failures on those bots, but more than 20 crashes means
749         something should be rolled out.
750
751         * Scripts/old-run-webkit-tests:
752         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
753
754 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
755
756         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
757         TestNetscapePlugin project, because this was removed from the tree.
758
759         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
760
761 2010-07-07  Anders Carlsson  <andersca@apple.com>
762
763         Reviewed by Simon Fraser.
764
765         Unify Mac and Windows TestNetscapePlugin main.cpp files
766         https://bugs.webkit.org/show_bug.cgi?id=41798
767         
768         * DumpRenderTree/DumpRenderTree.sln:
769         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
770         (strcasecmp):
771         (NP_Initialize):
772         (NP_GetEntryPoints):
773         (NP_Shutdown):
774         (NPP_New):
775         (NPP_Destroy):
776         (NPP_HandleEvent):
777         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
778         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
779
780 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
781
782         [wx] Build fix. pageProperty needs to return a value.
783
784         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
785         (LayoutTestController::pageProperty):
786
787 2010-07-07  David Kilzer  <ddkilzer@apple.com>
788
789         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
790
791         Reviewed by Anders Carlsson.
792
793         For both svn and git, commit-log-editor is invoked from the root
794         of the working directory.  Unlike svn, git returns a list of
795         changed files that are relative to the directory where the
796         command was invoked.  This caused the ChangeLog file in the root
797         directory to be read instead of the ChangeLog in the current
798         directory.
799
800         The fix is to use $ENV{PWD} as the base directory when fixing
801         the path to the ChangeLog files.  With svn, this has no net
802         effect since $ENV{PWD} is the root of the working directory and
803         the ChangeLog paths are already relative to that directory.
804         With git, $ENV{PWD} is the directory that the commit was invoked
805         from, which fixes the ChangeLog paths so that the correct files
806         are read when creating the commit log entry.
807
808         Note that the call to makeFilePathRelative() was supposed to
809         address this issue, but it doesn't because (a) it does nothing
810         with svn working directories by design, and (b) it does nothing
811         with git working directories because it's invoked when the
812         current directory is the root of the working directory, thus
813         giving no relative path.
814
815         * Scripts/commit-log-editor: Removed call to
816         makeFilePathRelative() since since it does nothing.  Moved code
817         to fix up $changeLog path so that it's fixed before trying to
818         open the file, and use $ENV{PWD} as the base path.  Also use
819         canonicalizePath() to clean up paths with "../" in them.
820
821 2010-07-07  Anders Carlsson  <andersca@apple.com>
822
823         Another attempt at fixing the Qt build.
824
825         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
826
827 2010-07-07  Anders Carlsson  <andersca@apple.com>
828
829         Try to fix Qt build.
830
831         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
832
833 2010-07-07  Anders Carlsson  <andersca@apple.com>
834
835         Reviewed by Simon Fraser.
836
837         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
838         https://bugs.webkit.org/show_bug.cgi?id=41781
839
840         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
841         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
842         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
843         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
844         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
845         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
846         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
847         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
848         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
849         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
850         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
851         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
852         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
853
854 2010-07-07  Andras Becsi  <abecsi@webkit.org>
855
856         Unreviewed trivial fix.
857
858         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
859         which was checked in accidentally in r62635.
860
861         * Scripts/webkitpy/layout_tests/port/webkit.py:
862
863 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
864
865         Reviewed by Eric Seidel.
866
867         Pass port specific environment to server process.
868         https://bugs.webkit.org/show_bug.cgi?id=41593
869
870         * Scripts/webkitpy/layout_tests/port/qt.py:
871         * Scripts/webkitpy/layout_tests/port/webkit.py:
872
873 2010-07-06  Kent Tamura  <tkent@chromium.org>
874
875         Reviewed by Shinichiro Hamaji.
876
877         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
878         https://bugs.webkit.org/show_bug.cgi?id=41644
879
880         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
881         tolerance. We don't need tolerance for rebaseline.
882
883         * Scripts/webkitpy/layout_tests/port/base.py:
884           Add optional tolerance parameter to diff_image().
885         * Scripts/webkitpy/layout_tests/port/test.py:
886           Add optional tolerance parameter to diff_image().
887         * Scripts/webkitpy/layout_tests/port/webkit.py:
888           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
889         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
890           diff_files() always calls diff_image() with tolerance=0.
891           diff_files() is used only by rebaseline-chromium-webkit-tests.
892
893 2010-07-06  Sam Weinig  <sam@webkit.org>
894
895         Fix MiniBrowser build.
896
897         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
898
899 2010-07-06  Sam Weinig  <sam@webkit.org>
900
901         Reviewed by Anders Carlsson.
902
903         Add support for dumping the contents of messages to the console to WebKitTestRunner
904
905         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
906         (WTR::InjectedBundlePage::InjectedBundlePage):
907         (WTR::InjectedBundlePage::_addMessageToConsole):
908         (WTR::InjectedBundlePage::addMessageToConsole):
909         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
910
911 2010-07-06  Sam Weinig  <sam@webkit.org>
912
913         Reviewed by Anders Carlsson.
914
915         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
916         Add dumpAsText support for WebKitTestRunner
917
918         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
919         (WTR::InjectedBundle::InjectedBundle):
920         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
921         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
922         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
923         API to dump the main frames text.
924
925 2010-07-06  Darin Adler  <darin@apple.com>
926
927         Fix Chromium build.
928
929         * DumpRenderTree/chromium/WebViewHost.cpp:
930         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
931         (WebViewHost::didNavigateWithinPage): Ditto.
932         (WebViewHost::updateURL): Ditto.
933
934 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
935
936         Reviewed by Xan Lopez.
937
938         [GTK] build-webkit should not run autogen.sh unconditionally
939         https://bugs.webkit.org/show_bug.cgi?id=41704
940
941         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
942         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
943         some very minor cleanup.
944
945 2010-07-06  Darin Adler  <darin@apple.com>
946
947         Try to fix Chromium build.
948
949         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
950
951 2010-07-06  Darin Adler  <darin@apple.com>
952
953         Fix build.
954
955         * WebKitAPITest/TestsController.cpp:
956         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
957
958 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
959
960         Reviewed by Kent Tamura.
961
962         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
963         https://bugs.webkit.org/show_bug.cgi?id=40558
964
965         Upstream DevTools for Chromium DRT.
966         (original Chromium files rev. 51287)
967
968         * DumpRenderTree/DumpRenderTree.gypi:
969         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
970         (DRTDevToolsAgent::DRTDevToolsAgent):
971         (DRTDevToolsAgent::setWebView):
972         (DRTDevToolsAgent::sendMessageToFrontend):
973         (DRTDevToolsAgent::forceRepaint):
974         (DRTDevToolsAgent::runtimeFeatureStateChanged):
975         (DRTDevToolsAgent::injectedScriptSource):
976         (DRTDevToolsAgent::injectedScriptDispatcherSource):
977         (DRTDevToolsAgent::debuggerScriptSource):
978         (DRTDevToolsAgent::asyncCall):
979         (DRTDevToolsAgent::call):
980         (DRTDevToolsAgent::webDevToolsAgent):
981         (DRTDevToolsAgent::attach):
982         (DRTDevToolsAgent::detach):
983         (DRTDevToolsAgent::setTimelineProfilingEnabled):
984         (DRTDevToolsAgent::evaluateInWebInspector):
985         (DRTDevToolsAgent::dispatchMessageLoop):
986         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
987         (DRTDevToolsAgent::~DRTDevToolsAgent):
988         (DRTDevToolsAgent::hostIdentifier):
989         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
990         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
991         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
992         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
993         (DRTDevToolsCallArgs::callsCount):
994         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
995         (DRTDevToolsClient::DRTDevToolsClient):
996         (DRTDevToolsClient::~DRTDevToolsClient):
997         (DRTDevToolsClient::sendMessageToAgent):
998         (DRTDevToolsClient::sendDebuggerCommandToAgent):
999         (DRTDevToolsClient::activateWindow):
1000         (DRTDevToolsClient::closeWindow):
1001         (DRTDevToolsClient::dockWindow):
1002         (DRTDevToolsClient::undockWindow):
1003         (DRTDevToolsClient::asyncCall):
1004         (DRTDevToolsClient::call):
1005         (DRTDevToolsClient::allMessagesProcessed):
1006         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1007         * DumpRenderTree/chromium/EventSender.cpp:
1008         * DumpRenderTree/chromium/LayoutTestController.cpp:
1009         (LayoutTestController::LayoutTestController):
1010         (LayoutTestController::closeWebInspector):
1011         (LayoutTestController::setTimelineProfilingEnabled):
1012         (LayoutTestController::evaluateInWebInspector):
1013         * DumpRenderTree/chromium/LayoutTestController.h:
1014         * DumpRenderTree/chromium/TestShell.cpp:
1015         (TestShell::TestShell):
1016         (TestShell::~TestShell):
1017         (TestShell::createDRTDevToolsClient):
1018         (TestShell::showDevTools):
1019         (TestShell::closeDevTools):
1020         (TestShell::runFileTest):
1021         (TestShell::createNewWindow):
1022         * DumpRenderTree/chromium/TestShell.h:
1023         (TestShell::drtDevToolsAgent):
1024         (TestShell::drtDevToolsClient):
1025         * DumpRenderTree/chromium/config.h:
1026
1027 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1028
1029         Reviewed by Eric Seidel.
1030
1031         Don't pass image hash to DRT when pixel tests are disabled.
1032         https://bugs.webkit.org/show_bug.cgi?id=41597
1033
1034         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1035
1036 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
1037
1038         Reviewed by Eric Seidel.
1039
1040         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
1041         https://bugs.webkit.org/show_bug.cgi?id=41612
1042
1043         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
1044
1045 2010-07-05  Adam Barth  <abarth@webkit.org>
1046
1047         Reviewed by Eric Seidel.
1048
1049         We should be able to specify a bug to block for webkit-patch upload
1050         https://bugs.webkit.org/show_bug.cgi?id=41648
1051
1052         This will be useful for working on the HTML5 parser.
1053
1054         * Scripts/webkitpy/tool/steps/createbug.py:
1055         * Scripts/webkitpy/tool/steps/options.py:
1056
1057 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
1058
1059         Reviewed by Oliver Hunt.
1060
1061         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
1062         https://bugs.webkit.org/show_bug.cgi?id=41017
1063
1064         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
1065         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
1066
1067 2010-07-04  MORITA Hajime  <morrita@google.com>
1068
1069         rebaseline-chromium-webkit-tests: UnicodeDecodeError
1070         https://bugs.webkit.org/show_bug.cgi?id=41589
1071
1072         * run() method can result non-utf-8 bytes, that causes utf-8
1073           decoding fail.  Fixed to disable decoding.
1074         * Fixed Git.find_checkout_root() to make a test pass.
1075
1076         * Scripts/webkitpy/common/checkout/scm.py:
1077         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1078
1079 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
1080
1081         Reviewed by Simon Hausmann.
1082
1083         [Qt] Fix DumpRenderTree userStyleSheet handling.
1084         https://bugs.webkit.org/show_bug.cgi?id=41570
1085
1086         DumpRenderTree did only set the userStyleSheet at
1087         layoutTestController.setUserStyleSheetEnabled().
1088
1089         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1090         (LayoutTestController::reset):
1091         (LayoutTestController::setUserStyleSheetLocation):
1092         (LayoutTestController::setUserStyleSheetEnabled):
1093         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1094
1095 2010-07-03  Robert Hogan  <robert@webkit.org>
1096
1097         Reviewed by Kenneth Rohde Christiansen.
1098
1099         [Qt] support dumpChildFrameScrollPositions
1100
1101         https://bugs.webkit.org/show_bug.cgi?id=41088
1102
1103         Unskip:
1104
1105         http/tests/navigation/anchor-subframeload.html
1106         http/tests/navigation/relativeanchor-frames.html
1107
1108         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1109         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1110         (WebCore::DumpRenderTree::dump):
1111         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1112         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1113         (LayoutTestController::reset):
1114         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1115         (LayoutTestController::shouldDumpChildFrameScrollPositions):
1116         (LayoutTestController::dumpChildFrameScrollPositions):
1117
1118 2010-07-02  Sam Weinig  <sam@webkit.org>
1119
1120         Reviewed by Anders Carlsson.
1121
1122         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
1123
1124         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
1125         * Scripts/debug-webkittestrunner: Removed.
1126         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
1127         * Scripts/run-webkittestrunner: Removed.
1128
1129 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
1130
1131         Reviewed by Steve Falkenburg.
1132
1133         Some http tests fail on Windows with Cygwin 1.7
1134         https://bugs.webkit.org/show_bug.cgi?id=41537
1135         
1136         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
1137         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
1138         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
1139
1140         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1141         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
1142             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
1143
1144 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
1145
1146         Reviewed by Gustavo Noronha Silva.
1147
1148         [GTK] Separate DerivedSources per-project
1149         https://bugs.webkit.org/show_bug.cgi?id=41109
1150
1151         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
1152         allowing the tools to build as a side-effect. Now that the top-level directory
1153         is no longer in the list of JavaScriptCore includes, include it explicitly.
1154
1155         * GNUmakefile.am:
1156
1157 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1158
1159         Reviewed by Kenneth Rohde Christiansen.
1160
1161         [Qt] Make context menus show up in the right place in QTestBrowser
1162
1163         Context menus were shown at scene-relative coordinates for
1164         QGraphicsWebView while QMenu expects them to be global. The
1165         change to the QWidget case was to get rid of the mapToGlobal.
1166
1167         * QtTestBrowser/webview.cpp:
1168
1169 2010-07-01  Robert Hogan <robert@webkit.org>
1170
1171         Reviewed by Kenneth Rohde Christiansen.
1172
1173         [Qt] dump frames in ascending alphabetical order of title
1174
1175         https://bugs.webkit.org/show_bug.cgi?id=41261
1176
1177         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1178         (WebCore::dumpHistoryItem):
1179
1180 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1181
1182         Unreviewed. 
1183
1184         Fix the GTK+ build after r62278.
1185
1186         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
1187         let them override the automatic CPU detection for autotools builds.
1188
1189 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1190
1191         Unreviewed.
1192
1193         Fix the Windows build after r62278.
1194
1195         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
1196
1197 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
1198
1199         Reviewed by Gustavo Noronha Silva.
1200
1201         [GTK] build-webkit does not detect the number of CPUs
1202         https://bugs.webkit.org/show_bug.cgi?id=41469
1203
1204         Pass the appropriate -j<#> flag to make when building autotools builds.
1205         This causes make to spawn that many number of child processes for doing
1206         parallel builds.
1207
1208         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
1209         of CPUs. This makes the script work across more platforms.
1210         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
1211         number of CPUs across several platforms. Use this new function to determine the appropriate
1212         arguments to pass to make for doing parallel builds with autotools build files.
1213
1214 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
1215
1216         Rubber-stamped by Laszlo Gombos.
1217
1218         [Qt][Symbian] Bumped up the maximum heap size to 96MB
1219
1220         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
1221         and use the one from WebKit.pri instead.
1222
1223 2010-07-01  Adam Barth  <abarth@webkit.org>
1224
1225         Reviewed by Eric Seidel.
1226
1227         Promote webkit-patch land-safely to main help
1228         https://bugs.webkit.org/show_bug.cgi?id=41446
1229
1230         I've been using this command a bunch and recommending it to folks.  We
1231         should show it in main help as it's past the experimental phase.
1232
1233         * Scripts/webkitpy/tool/commands/upload.py:
1234
1235 2010-06-28  MORITA Hajime  <morrita@google.com>
1236
1237         Reviewed by Shinichiro Hamaji.
1238
1239         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
1240         https://bugs.webkit.org/show_bug.cgi?id=38775
1241
1242         - Introduced SCM.show_head() and SCM.diff_for_file().
1243         - Replaced direct svn invocations with newly implement SCM methods.
1244
1245         * Scripts/webkitpy/common/checkout/scm.py:
1246         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1247         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1248
1249 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
1250
1251         Reviewed by Sam Weinig.
1252
1253         Allow MiniBrowser to open local files
1254         https://bugs.webkit.org/show_bug.cgi?id=41104
1255
1256         Wire up the openDocument: message with an NSOpenPanel, so we can open
1257         local files.
1258         
1259         Also change the xib so that the window remembers its size.
1260         
1261         * MiniBrowser/mac/AppDelegate.m:
1262         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1263         (-[BrowserAppDelegate openDocument:]):
1264         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1265         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
1266
1267 2010-06-30  Sam Weinig  <sam@webkit.org>
1268
1269         Rubber-stamped by Anders Carlsson.
1270
1271         Add debug-webkittestrunner and cleanup related scripts.
1272
1273         * Scripts/debug-webkittestrunner: Added.
1274         * Scripts/run-webkittestrunner:
1275         * Scripts/webkitdirs.pm:
1276
1277 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
1278
1279         [wx] Build fix after recent changes to LayoutTestController.
1280
1281         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1282         (LayoutTestController::pageSizeAndMarginsInPixels):
1283
1284 2010-06-29  Sam Weinig  <sam@webkit.org>
1285
1286         Reviewed by Anders Carlsson.
1287
1288         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
1289         Make WebKitTestRunner work with more than one test at a time.
1290
1291         This converts WebKitTestRunner to a similar model as DumpRenderTree,
1292         where there is a single WKView and each test is run it, rather than
1293         the design I was using where each test got its own WKView.
1294
1295         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1296         (WTR::InjectedBundle::didRecieveMessage):
1297         (WTR::InjectedBundle::reset):
1298         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1299         * WebKitTestRunner/TestController.cpp:
1300         (WTR::TestController::initialize):
1301         (WTR::TestController::runTest):
1302         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
1303         (WTR::TestController::didRecieveMessageFromInjectedBundle):
1304         * WebKitTestRunner/TestController.h:
1305         (WTR::TestController::mainWebView):
1306         (WTR::TestController::pageNamespace):
1307         (WTR::TestController::context):
1308         * WebKitTestRunner/TestInvocation.cpp:
1309         (WTR::TestInvocation::TestInvocation):
1310         (WTR::TestInvocation::~TestInvocation):
1311         (WTR::TestInvocation::invoke):
1312         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1313         * WebKitTestRunner/TestInvocation.h:
1314
1315 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
1316
1317         Reviewed by Laszlo Gombos.
1318
1319         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
1320         https://bugs.webkit.org/show_bug.cgi?id=40446
1321
1322         We quickly run out of memory on Symbian when loading web pages. This is
1323         caused by the default heap size, which is not suited for a web browser.
1324
1325         This change bumps the max heap size to 32MB.
1326
1327         * QtTestBrowser/QtTestBrowser.pro:
1328
1329 2010-06-30  Eric Seidel  <eric@webkit.org>
1330
1331         Reviewed by Adam Barth.
1332
1333         webkit-patch land allow the user to continue even if the builders are red
1334         https://bugs.webkit.org/show_bug.cgi?id=41395
1335
1336         I don't think it's good that we've been teaching people
1337         to always pass --ignore-builders.  At least land is now
1338         useable w/o --ignore-builders.
1339
1340         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1341
1342 2010-06-29  Robert Hogan  <robert@webkit.org>
1343
1344         Reviewed by Kenneth Rohde Christiansen.
1345
1346         [Qt] support dumpResourceResponseMIMETypes
1347         https://bugs.webkit.org/show_bug.cgi?id=41260
1348
1349         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1350         (LayoutTestController::reset):
1351         (LayoutTestController::dumpResourceResponseMIMETypes):
1352         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1353
1354 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1355
1356         Reviewed by Kenneth Rohde Christiansen.
1357
1358         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
1359         https://bugs.webkit.org/show_bug.cgi?id=41173
1360
1361         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1362         (WebCore::WebPage::setViewGeometry):
1363         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1364
1365 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1366
1367         Reviewed by Simon Hausmann.
1368
1369         [Qt] Deal with postEvent in case of graphics based DRT
1370         https://bugs.webkit.org/show_bug.cgi?id=41174
1371
1372         QGraphicsScene does not have a postEvent method, so make scene
1373         send the event, in case of graphics based DRT, and delete it after that.
1374
1375         * DumpRenderTree/qt/EventSenderQt.cpp:
1376         (EventSender::scheduleAsynchronousClick):
1377         (EventSender::replaySavedEvents):
1378         (EventSender::postEvent):
1379         * DumpRenderTree/qt/EventSenderQt.h:
1380
1381 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
1382
1383         Reviewed by Kenneth Rohde Christiansen.
1384
1385         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
1386         https://bugs.webkit.org/show_bug.cgi?id=41172
1387
1388         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1389         (WebCore::DumpRenderTree::switchFocus):
1390
1391 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1392
1393         Reviewed by Xan Lopez.
1394
1395         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
1396         https://bugs.webkit.org/show_bug.cgi?id=40009
1397
1398         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
1399         are used when returning those values, for coherency with other ports.
1400
1401         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1402         (AccessibilityUIElement::role):
1403         (AccessibilityUIElement::title):
1404         (AccessibilityUIElement::description):
1405
1406 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1407
1408         Unreviewed, rolling out r62106.
1409         http://trac.webkit.org/changeset/62106
1410         https://bugs.webkit.org/show_bug.cgi?id=41346
1411
1412         "Broke editing tests" (Requested by xan_ on #webkit).
1413
1414         * Scripts/old-run-webkit-tests:
1415
1416 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
1417
1418         Reviewed by Xan Lopez.
1419
1420         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
1421         https://bugs.webkit.org/show_bug.cgi?id=38648
1422
1423         Add the GTK_MODULES envvar (set to "gail") to the clean
1424         environment when running DRT for the Gtk+ port
1425
1426         * Scripts/old-run-webkit-tests:
1427
1428 2010-06-28  Adam Barth  <abarth@webkit.org>
1429
1430         Unreviewed.
1431
1432         Switch test-html5-parser back to using runner.html.
1433
1434         * Scripts/test-html5-parser:
1435
1436 2010-06-28  Adam Barth  <abarth@webkit.org>
1437
1438         Reviewed by Eric Seidel.
1439
1440         Restore webkit-runner.html for use with new tree builder
1441         https://bugs.webkit.org/show_bug.cgi?id=41317
1442
1443         For now, we just want to run webkit-runner when we test-html5-parser.
1444
1445         * Scripts/test-html5-parser:
1446
1447 2010-06-23  John Gregg  <johnnyg@google.com>
1448
1449         Reviewed by Kent Tamura.
1450
1451         add ENABLE_DIRECTORY_UPLOAD build support
1452         https://bugs.webkit.org/show_bug.cgi?id=41100
1453
1454         * Scripts/build-webkit:
1455
1456 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
1457
1458         Rubber-stamped by Xan Lopez.
1459
1460         Update webkitdirs's knowledge of our library's name.
1461
1462         * Scripts/webkitdirs.pm:
1463
1464 2010-06-28  Sam Weinig  <sam@webkit.org>
1465
1466         Reviewed by Anders Carlsson.
1467
1468         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
1469         Build up WebKitTestRunner output in the InjectedBundle
1470
1471         Simplify WebKitTestRunner by building up the output in the InjectedBundle
1472         and sending it over postMessage when done, instead of using the async
1473         WKPageRenderTreeExternalRepresentation.
1474
1475         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1476         (WTR::InjectedBundle::done):
1477         (WTR::InjectedBundle::didRecieveMessage):
1478         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1479         (WTR::InjectedBundle::os):
1480         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1481         (WTR::WKStringToUTF8):
1482         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1483         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1484         * WebKitTestRunner/TestInvocation.cpp:
1485         (WTR::WKStringToUTF8):
1486         (WTR::TestInvocation::TestInvocation):
1487         (WTR::TestInvocation::invoke):
1488         (WTR::TestInvocation::initializeMainWebView):
1489         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
1490         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
1491         * WebKitTestRunner/TestInvocation.h:
1492
1493 2010-06-28  Robert Hogan  <robert@webkit.org>
1494
1495         Unreviewed, rolling out r62021.
1496         http://trac.webkit.org/changeset/62021
1497         https://bugs.webkit.org/show_bug.cgi?id=41261
1498
1499         Broke http/navigation tests among other
1500
1501         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1502         (WebCore::DumpRenderTree::dumpFramesAsText):
1503
1504 2010-06-28  Sam Weinig  <sam@webkit.org>
1505
1506         Reviewed by Anders Carlsson.
1507
1508         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
1509         environment.
1510
1511         * Scripts/run-webkittestrunner: Added.
1512         * Scripts/webkitdirs.pm:
1513
1514 2010-06-28  Robert Hogan  <robert@webkit.org>
1515
1516         Reviewed by Kenneth Rohde Christiansen.
1517
1518         [Qt] dump frames in ascending alphabetical order of title
1519
1520         https://bugs.webkit.org/show_bug.cgi?id=41261
1521
1522         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1523         (WebCore::DumpRenderTree::dumpFramesAsText):
1524
1525 2010-06-28  Robert Hogan  <robert@webkit.org>
1526
1527         Reviewed by Kenneth Rohde Christiansen.
1528
1529         [Qt] dump bf history of child windows
1530
1531         https://bugs.webkit.org/show_bug.cgi?id=41266
1532
1533         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1534         (WebCore::DumpRenderTree::dumpBackForwardList):
1535         (WebCore::DumpRenderTree::dump):
1536         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1537
1538 2010-06-28  Sam Weinig  <sam@webkit.org>
1539
1540         Reviewed by Anders Carlsson.
1541
1542         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
1543         WebKit2: Add frame API for InjectedBundle code
1544
1545         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1546         (_didClearWindowForFrame):
1547
1548 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1549
1550         Reviewed by Kenneth Rohde Christiansen.
1551
1552         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1553         https://bugs.webkit.org/show_bug.cgi?id=38597
1554
1555         Fix behavior so reload button really acts as a load and a reload button.
1556
1557         * QtTestBrowser/mainwindow.cpp:
1558         (MainWindow::changeLocation):
1559
1560 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1561
1562         Reviewed by Gustavo Noronha.
1563
1564         [GTK] Does not compile with -DGSEAL_ENABLE
1565         https://bugs.webkit.org/show_bug.cgi?id=37851
1566
1567         Fix build with GSEAL enabled.
1568
1569         * DumpRenderTree/gtk/EventSender.cpp:
1570         (gtk_widget_get_window):
1571         (prepareMouseButtonEvent):
1572         (mouseMoveToCallback):
1573         (mouseWheelToCallback):
1574         (keyDownCallback):
1575
1576 2010-06-28  Xan Lopez  <xlopez@igalia.com>
1577
1578         Reviewed by Gustavo Noronha.
1579
1580         [GTK] Add support for GTK+3
1581         https://bugs.webkit.org/show_bug.cgi?id=41253
1582
1583         Adapt build system for 3.x support.
1584
1585         * GNUmakefile.am:
1586
1587 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1588
1589         Reviewed by Simon Hausmann.
1590
1591         [QT][S60] build-webkit scripts picks wrong make spec for windows build
1592         https://bugs.webkit.org/show_bug.cgi?id=41198
1593
1594         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
1595
1596         * Scripts/webkitdirs.pm:
1597         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
1598
1599 2010-06-28  Eric Seidel  <eric@webkit.org>
1600
1601         Reviewed by Adam Barth.
1602
1603         Make it possible to test the new HTML5 TreeBuilder
1604         https://bugs.webkit.org/show_bug.cgi?id=41276
1605
1606         Adam was concerned that someone might make their port
1607         depend on this setting (I guess we had some trouble with that
1608         with the HTML5Parser setting), so I littered the code with warnings.
1609
1610         test-html5-parser now tests this code path.
1611
1612         * DumpRenderTree/mac/DumpRenderTree.mm:
1613         (resetDefaultsToConsistentValues):
1614         (initializeGlobalsFromCommandLineOptions):
1615         * Scripts/test-html5-parser:
1616
1617 2010-06-27  MORITA Hajime  <morrita@google.com>
1618
1619         Unreviewed. 
1620         
1621         Some never-called @staticmethods touched self. 
1622         Fixed it to replace these self with a class.
1623
1624         * Scripts/webkitpy/common/checkout/scm.py:
1625
1626 2010-06-27  MORITA Hajime  <morrita@google.com>
1627
1628         Unreviewed.
1629         
1630         Fixed exception raising syntax that is pointed out at
1631         https://bugs.webkit.org/show_bug.cgi?id=41153
1632
1633         * Scripts/webkitpy/common/checkout/scm.py:
1634         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
1635           Removed a bad line that I accidentally checked-in at last revision.
1636
1637 2010-06-24  MORITA Hajime  <morrita@google.com>
1638
1639         Reviewed by Eric Seidel.
1640
1641         rebaseline-chromium-webkit-tests should add or remove files to local git repository
1642         https://bugs.webkit.org/show_bug.cgi?id=41153
1643
1644         - Added SCM.add() and SCM.remove()
1645         - Replaced "svn add" and "svn remove"
1646           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
1647         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
1648           for debugging purpose.
1649
1650         * Scripts/webkitpy/common/checkout/scm.py:
1651         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1652         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1653
1654 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
1655
1656         Reviewed by Shinichiro Hamaji.
1657
1658         Improve default value handling for page format properties.
1659         https://bugs.webkit.org/show_bug.cgi?id=41150
1660
1661         * DumpRenderTree/LayoutTestController.cpp:
1662         (parsePageNumber):
1663         (parsePageNumberSizeMarings):
1664         (pageSizeAndMarginsInPixelsCallback):
1665         (LayoutTestController::staticFunctions):
1666         * DumpRenderTree/LayoutTestController.h:
1667         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1668         (LayoutTestController::pageSizeAndMarginsInPixels):
1669         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1670         (LayoutTestController::pageSizeAndMarginsInPixels):
1671         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1672         (LayoutTestController::pageSizeAndMarginsInPixels):
1673
1674 2010-06-21  Robert Hogan  <robert@webkit.org>
1675
1676         Reviewed by Kenneth Rohde Christiansen.
1677
1678         [Qt] DRT Support for setCustomPolicyDelegate
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=39564
1681
1682         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1683         (LayoutTestController::setCustomPolicyDelegate):
1684         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1685
1686 2010-06-26  Robert Hogan  <robert@webkit.org>
1687
1688         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
1689         
1690         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
1691         exported.
1692
1693         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1694
1695 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
1696
1697         Reviewed by Dimitri Glazkov.
1698
1699         Add a build-webkit option for enabling Web Timing support.
1700         https://bugs.webkit.org/show_bug.cgi?id=38924
1701
1702         * Scripts/build-webkit:
1703
1704 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1705
1706         Reviewed by Kenneth Rohde Christiansen.
1707
1708         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1709         https://bugs.webkit.org/show_bug.cgi?id=38597
1710
1711         Make the reload button act as a load button as well.
1712
1713         * QtTestBrowser/mainwindow.cpp:
1714         (MainWindow::buildUI):
1715         (MainWindow::changeLocation):
1716
1717 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
1718
1719         Reviewed by Dmitry Titov.
1720
1721         Add empty abortModal() method to all platforms.
1722         https://bugs.webkit.org/show_bug.cgi?id=40864
1723
1724         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
1725         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
1726         that use abortModal will become mac specific which is not desirable.
1727
1728         * DumpRenderTree/LayoutTestController.cpp:
1729         (abortModalCallback):
1730         (LayoutTestController::staticFunctions):
1731         * DumpRenderTree/LayoutTestController.h:
1732         * DumpRenderTree/chromium/LayoutTestController.cpp:
1733         (LayoutTestController::LayoutTestController):
1734         (LayoutTestController::abortModal):
1735         * DumpRenderTree/chromium/LayoutTestController.h:
1736         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1737         (LayoutTestController::abortModal):
1738         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1739         (LayoutTestController::abortModal):
1740         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1741         (LayoutTestController::abortModal):
1742         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1743         (LayoutTestController::abortModal):
1744
1745 2010-06-25  Sam Weinig  <sam@webkit.org>
1746
1747         Reviewed by Anders Carlsson.
1748
1749         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
1750         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
1751
1752         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
1753         (WTR::InjectedBundle::shared):
1754         (WTR::InjectedBundle::InjectedBundle):
1755         (WTR::InjectedBundle::_didCreatePage):
1756         (WTR::InjectedBundle::_willDestroyPage):
1757         (WTR::InjectedBundle::_didRecieveMessage):
1758         (WTR::InjectedBundle::initialize):
1759         (WTR::InjectedBundle::didCreatePage):
1760         (WTR::InjectedBundle::willDestroyPage):
1761         (WTR::InjectedBundle::didRecieveMessage):
1762         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
1763         (WTR::InjectedBundle::layoutTestController):
1764         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1765         (WKBundleInitialize):
1766         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
1767         (WTR::InjectedBundlePage::InjectedBundlePage):
1768         (WTR::InjectedBundlePage::~InjectedBundlePage):
1769         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
1770         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
1771         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
1772         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
1773         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
1774         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
1775         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
1776         (WTR::InjectedBundlePage::_didClearWindowForFrame):
1777         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1778         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1779         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1780         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1781         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1782         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1783         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1784         (WTR::InjectedBundlePage::didClearWindowForFrame):
1785         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
1786         (WTR::InjectedBundlePage::page):
1787         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
1788         (WTR::LayoutTestController::create):
1789         (WTR::LayoutTestController::LayoutTestController):
1790         (WTR::LayoutTestController::~LayoutTestController):
1791         (WTR::dumpAsTextCallback):
1792         (WTR::layoutTestControllerObjectFinalize):
1793         (WTR::LayoutTestController::makeWindowObject):
1794         (WTR::LayoutTestController::getJSClass):
1795         (WTR::LayoutTestController::staticFunctions):
1796         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
1797         (WTR::LayoutTestController::dumpAsText):
1798         (WTR::LayoutTestController::setDumpAsText):
1799         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1800
1801 2010-06-25  Sam Weinig  <sam@webkit.org>
1802
1803         Reviewed by Anders Carlsson.
1804
1805         Make WebKitTestRunner really work with run-webkit-tests. 
1806
1807         - Add Forwarding headers to allow some cleanup.
1808
1809         * WebKitTestRunner/ForwardingHeaders: Added.
1810         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
1811         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
1812         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
1813         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
1814         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
1815         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
1816         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
1817         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
1818         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
1819         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
1820         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
1821         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
1822         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
1823         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
1824         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
1825         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
1826         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
1827         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
1828         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
1829         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
1830         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
1831         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
1832         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
1833         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
1834         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
1835         * WebKitTestRunner/TestInvocation.cpp:
1836         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
1837         * WebKitTestRunner/TestInvocation.h:
1838
1839 2010-06-25  Sam Weinig  <sam@webkit.org>
1840
1841         Reviewed by Mark Rowe.
1842
1843         Add support for WebKitTestRunner to old-run-webkit-tests
1844
1845         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
1846
1847         * Scripts/build-webkittestrunner: Added.
1848         * Scripts/old-run-webkit-tests:
1849
1850 2010-06-25  Adam Barth  <abarth@webkit.org>
1851
1852         Reviewed by David Levin.
1853
1854         Incremental build failed on Chromium ews
1855         https://bugs.webkit.org/show_bug.cgi?id=41011
1856
1857         The division of responsibility between update-webkit --chromium and
1858         build-webkit --chromium is slightly unclear.  In this patch, we make
1859         build-webkit --chromium also update DEPS and re-run GYP in case the
1860         developer has changed either since they updated.
1861
1862         This change is also helpful for the EWS, which wants to update DEPS and
1863         re-run GYP after applying patches, but the EWS doesn't want to run
1864         update-webkit --chromium because it has a dirty working copy.
1865
1866         * Scripts/webkitdirs.pm:
1867
1868 2010-06-25  Robert Hogan  <robert@webkit.org>
1869
1870         Reviewed by Simon Hausmann.
1871
1872         [Qt] Support evaluateScriptInIsolatedWorld()
1873
1874         https://bugs.webkit.org/show_bug.cgi?id=40079
1875
1876         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
1877         Remove QWebScriptWorld from exported headers.
1878         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
1879
1880         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1881         (LayoutTestController::reset):
1882         (LayoutTestController::evaluateScriptInIsolatedWorld):
1883         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1884
1885 2010-06-25  Anders Carlsson  <andersca@apple.com>
1886
1887         Revert accidental part and add a newline.
1888
1889         * MiniBrowser/mac/AppDelegate.m:
1890         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1891
1892 2010-06-25  Anders Carlsson  <andersca@apple.com>
1893
1894         Rubber-stamped by Dan Bernstein.
1895
1896         Add a LOG macro that expands to a no-op by default.
1897
1898         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1899         * MiniBrowser/mac/AppDelegate.m:
1900         (_didRecieveMessageFromInjectedBundle):
1901         * MiniBrowser/mac/BrowserWindowController.m:
1902         (-[BrowserWindowController windowShouldClose:]):
1903         (_didStartProvisionalLoadForFrame):
1904         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1905         (_didFailProvisionalLoadWithErrorForFrame):
1906         (_didCommitLoadForFrame):
1907         (_didFinishLoadForFrame):
1908         (_didFailLoadWithErrorForFrame):
1909         (_didReceiveTitleForFrame):
1910         (_didFirstLayoutForFrame):
1911         (_didFirstVisuallyNonEmptyLayoutForFrame):
1912         (_didBecomeUnresponsive):
1913         (_didBecomeResponsive):
1914         (_decidePolicyForNavigationAction):
1915         (_decidePolicyForNewWindowAction):
1916         (_createNewPage):
1917         (_showPage):
1918         (_closePage):
1919         (_didNavigateWithNavigationData):
1920         (_didPerformClientRedirect):
1921         (_didPerformServerRedirect):
1922         (_didUpdateHistoryTitle):
1923         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1924         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1925         (_didClearWindowForFrame):
1926         (_didCreatePage):
1927         (_willDestroyPage):
1928         (_didRecieveMessage):
1929
1930 2010-06-24  Adam Barth  <abarth@webkit.org>
1931
1932         Reviewed by Eric Seidel.
1933
1934         commit-queue is taking too long to land patches because of red trees
1935         https://bugs.webkit.org/show_bug.cgi?id=41194
1936
1937         Instead of checking for the tree to be green, we'll just spin hot
1938         trying to land patches.  This is probably too extreme in ignoring the
1939         tree, but I think we should try it for a while to see if we have
1940         trouble.  That will help us find the right balance.
1941
1942         * Scripts/webkitpy/tool/commands/queues.py:
1943         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1944
1945 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
1946
1947         Reviewed by Xan Lopez.
1948
1949         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
1950         https://bugs.webkit.org/show_bug.cgi?id=40843
1951
1952         Define the version for old GTK+s in a way that is forward-compatible
1953         and clean up the logic a bit.
1954
1955         * DumpRenderTree/gtk/EventSender.cpp:
1956         (gdk_window_get_root_coords): Renamed and cleaned up.
1957         (prepareMouseButtonEvent): Remove #ifdefs.
1958         (mouseMoveToCallback): Remove #ifdefs.
1959
1960 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
1961
1962         Reviewed by Eric Seidel.
1963
1964         Fix NewRunWebKitTests to work on Windows.
1965         https://bugs.webkit.org/show_bug.cgi?id=41180
1966
1967         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
1968             because Windows fails to understand what we're asking of it.
1969
1970 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
1971
1972         Reviewed by Xan Lopez.
1973
1974         [GTK] The url passed to the WebView during layout tests is invalid
1975         https://bugs.webkit.org/show_bug.cgi?id=40832
1976
1977         Set the test URL to the full real file URL and do a small cleanup.
1978         Previously a URL like file://relative/path/to/test.html was passed
1979         to the WebView. This malformed file URL would be returned by
1980         webkit_web_view_get_url and webkit_web_frame_get_url.
1981
1982         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1983         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
1984         (shouldOpenWebInspector): Change to take a const string& as the argument.
1985         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
1986         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
1987
1988 2010-06-24  Sam Weinig  <sam@webkit.org>
1989
1990         Reviewed by Anders Carlsson.
1991
1992         Fix WebKitTestRunner Makefile typos.
1993
1994         * WebKitTestRunner/Makefile:
1995
1996 2010-06-24  Adele Peterson  <adele@apple.com>
1997
1998         Reviewed by Eric Carlson.
1999
2000         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
2001         https://bugs.webkit.org/show_bug.cgi?id=41085
2002
2003         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
2004         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2005
2006 2010-06-23  Sam Weinig  <sam@webkit.org>
2007
2008         Reviewed by Anders Carlsson.
2009
2010         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
2011         Add new WebKitTestRunner project (ie. DRT for WebKit2).
2012
2013         - Mac only.
2014         - run-webkit-tests has not been modified to call it yet.
2015         - Only dumps the render tree at this time. 
2016
2017         * WebKitTestRunner: Added.
2018         * WebKitTestRunner/Configurations: Added.
2019         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
2020         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
2021         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
2022         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
2023         * WebKitTestRunner/InjectedBundle: Added.
2024         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
2025         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
2026         (_didStartProvisionalLoadForFrame):
2027         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2028         (_didFailProvisionalLoadWithErrorForFrame):
2029         (_didCommitLoadForFrame):
2030         (_didFinishLoadForFrame):
2031         (_didFailLoadWithErrorForFrame):
2032         (_didReceiveTitleForFrame):
2033         (_didClearWindow):
2034         (_didCreatePage):
2035         (_willDestroyPage):
2036         (_didRecieveMessage):
2037         (WKBundleInitialize):
2038         * WebKitTestRunner/Makefile: Added.
2039         * WebKitTestRunner/PlatformWebView.h: Added.
2040         (WTR::PlatformWebView::platformView):
2041         * WebKitTestRunner/TestController.cpp: Added.
2042         (WTR::TestController::shared):
2043         (WTR::TestController::TestController):
2044         (WTR::TestController::initialize):
2045         (WTR::TestController::runTest):
2046         (WTR::TestController::runTestingServerLoop):
2047         (WTR::TestController::run):
2048         * WebKitTestRunner/TestController.h: Added.
2049         (WTR::TestController::verbose):
2050         (WTR::TestController::injectedBundlePath):
2051         * WebKitTestRunner/TestInvocation.cpp: Added.
2052         (WTR::createWKURL):
2053         (WTR::TestInvocation::TestInvocation):
2054         (WTR::TestInvocation::~TestInvocation):
2055         (WTR::TestInvocation::invoke):
2056         (WTR::TestInvocation::dump):
2057         (WTR::TestInvocation::initializeMainWebView):
2058         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
2059         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
2060         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
2061         (WTR::TestInvocation::didCommitLoadForFrame):
2062         (WTR::TestInvocation::didFinishLoadForFrame):
2063         (WTR::TestInvocation::didFailLoadForFrame):
2064         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
2065         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
2066         * WebKitTestRunner/TestInvocation.h: Added.
2067         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
2068         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
2069         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
2070         * WebKitTestRunner/mac: Added.
2071         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
2072         (WTR::PlatformWebView::PlatformWebView):
2073         (WTR::PlatformWebView::~PlatformWebView):
2074         (WTR::PlatformWebView::page):
2075         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2076         (WTR::TestInvocation::runUntil):
2077         * WebKitTestRunner/mac/main.mm: Added.
2078         (main):
2079
2080 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
2081
2082         Unreviewed. Adding myself to the committers list.
2083
2084         * Scripts/webkitpy/common/config/committers.py:
2085
2086 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
2087
2088         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
2089
2090         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2091         (LayoutTestController::isPageBoxVisible):
2092         (LayoutTestController::pageAreaRectInPixels):
2093         (LayoutTestController::preferredPageSizeInPixels):
2094         * wx/build/settings.py:
2095
2096 2010-06-23  James Robinson  <jamesr@chromium.org>
2097
2098         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
2099
2100         * Scripts/webkitpy/common/config/committers.py:
2101
2102 2010-06-23  Kent Tamura  <tkent@chromium.org>
2103
2104         Reviewed by Dimitri Glazkov.
2105
2106         Correct Chromium test configuration
2107         https://bugs.webkit.org/show_bug.cgi?id=41057
2108
2109         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2110          - Add "--use-drt" option for NRWT. It is required for Chromium and
2111            ignored for other platforms.
2112          - Skip JSC test on Chromium
2113         * BuildSlaveSupport/test-result-archive:
2114           Add Chromium support.
2115
2116 2010-06-23  Sam Weinig  <sam@webkit.org>
2117
2118         Reviewed by Anders Carlsson.
2119
2120         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
2121         WebKit2: Flesh out more of the InjectedBundle client API
2122
2123         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2124         (_didStartProvisionalLoadForFrame):
2125         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2126         (_didFailProvisionalLoadWithErrorForFrame):
2127         (_didCommitLoadForFrame):
2128         (_didFinishLoadForFrame):
2129         (_didFailLoadWithErrorForFrame):
2130         (_didReceiveTitleForFrame):
2131         (_didClearWindowForFrame):
2132         (_didCreatePage):
2133         (_willDestroyPage):
2134         (WKBundleInitialize):
2135
2136 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
2137
2138         Reviewed by Shinichiro Hamaji.
2139
2140         Implement page format data programming interface.
2141         Add methods for testing.
2142         https://bugs.webkit.org/show_bug.cgi?id=37538
2143
2144         * DumpRenderTree/LayoutTestController.cpp:
2145         (parsePageNumber):
2146         (isPageBoxVisibleCallback):
2147         (pageAreaRectInPixelsCallback):
2148         (preferredPageSizeInPixelsCallback):
2149         (LayoutTestController::staticFunctions):
2150         * DumpRenderTree/LayoutTestController.h:
2151         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2152         (LayoutTestController::isPageBoxVisible):
2153         (LayoutTestController::pageAreaRectInPixels):
2154         (LayoutTestController::preferredPageSizeInPixels):
2155         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2156         (LayoutTestController::isPageBoxVisible):
2157         (LayoutTestController::pageAreaRectInPixels):
2158         (LayoutTestController::preferredPageSizeInPixels):
2159         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2160         (LayoutTestController::isPageBoxVisible):
2161         (LayoutTestController::pageAreaRectInPixels):
2162         (LayoutTestController::preferredPageSizeInPixels):
2163
2164 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
2165
2166         Reviewed by Shinichiro Hamaji.
2167
2168         Follow proper convention for if/switch/while as I've discovered
2169         them to be through my review processes.
2170         https://bugs.webkit.org/show_bug.cgi?id=40723
2171
2172         Modified test so that if( foo ) is not allowed as it appears not
2173         to be the accepted convention.
2174
2175         * Scripts/webkitpy/style/checkers/cpp.py:
2176         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2177
2178 2010-06-22  Eric Seidel  <eric@webkit.org>
2179
2180         Reviewed by Adam Barth.
2181
2182         Run clean-header-guards to fix some header guards
2183         https://bugs.webkit.org/show_bug.cgi?id=41044
2184
2185         No functional changes, thus no tests.
2186
2187         This entire change was generated by running
2188         clean-header-guards, and then reverting changes
2189         to files which shouldn't be changed.  Those which
2190         are left all should be updated.
2191
2192         Some of these changes are just fixing 755 permissions
2193         to be 644, since it seems various files have the wrong
2194         execute bit which don't need it.  clean-header-guards
2195         made those (welcome) permission fixes unintentionally.
2196
2197         * DumpRenderTree/chromium/WebThemeControlDRT.h:
2198         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2199         * QtTestBrowser/fpstimer.h:
2200
2201 2010-06-22  Adam Barth  <abarth@webkit.org>
2202
2203         Reviewed by Eric Seidel.
2204
2205         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
2206         https://bugs.webkit.org/show_bug.cgi?id=41043
2207
2208         Update the hash.
2209
2210         * Scripts/do-webcore-rename:
2211
2212 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
2213
2214         Reviewed by Shinichiro Hamaji.
2215
2216         Follow proper convention for variable declaration spacing.
2217         https://bugs.webkit.org/show_bug.cgi?id=40724
2218
2219         Modified test so that 'int   a;' is not allowed.
2220
2221         * Scripts/webkitpy/style/checkers/cpp.py:
2222         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2223
2224 2010-06-22  Eric Seidel  <eric@webkit.org>
2225
2226         Unreviewed.  Add Tony Gentilcore now that he's a committer.
2227
2228         * Scripts/webkitpy/common/config/committers.py:
2229
2230 2010-06-22  Eric Seidel  <eric@webkit.org>
2231
2232         Reviewed by Adam Barth.
2233
2234         Remove Gtk 64-Release bot from core since it's broken
2235         https://bugs.webkit.org/show_bug.cgi?id=41022
2236
2237         This bot alone has been responsible for more than 72 hours of
2238         commit-queue blockage in the last week.  The bot is broken -- keeps
2239         losing its display server or similar.  Until the Gtk folks can fix the
2240         bot, we need to remove it from core.  The WebKit community can't keep
2241         it green as is.
2242
2243         * Scripts/webkitpy/common/net/buildbot.py:
2244         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2245
2246 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
2247
2248         Reviewed by Eric Seidel.
2249
2250         Fix the Windows build.
2251         https://bugs.webkit.org/show_bug.cgi?id=40972
2252
2253         * DumpRenderTree/win/ImageDiff.vcproj:
2254
2255 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
2256
2257         Reviewed by Darin Adler, Dmitry Titov.
2258
2259         DumpRenderTree should allow tests with modal dialogs
2260         https://bugs.webkit.org/show_bug.cgi?id=35350
2261
2262         * DumpRenderTree/LayoutTestController.cpp:
2263         (abortModalCallback):
2264         (LayoutTestController::staticFunctions):
2265         * DumpRenderTree/LayoutTestController.h:
2266         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2267         (LayoutTestController::abortModal):
2268         Add abortModal method to LayoutTestController and make it available from script.
2269
2270         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
2271         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
2272         abortModal from when modal window closes.
2273         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2274
2275 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
2276
2277         Reviewed by Anders Carlsson.
2278         
2279         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
2280         https://bugs.webkit.org/show_bug.cgi?id=40948
2281         
2282         Have the script look in WebKit2.
2283
2284         * Scripts/do-webcore-rename:
2285
2286 2010-06-21  Robert Hogan  <robert@webkit.org>
2287
2288         Reviewed by Kenneth Rohde Christiansen.
2289
2290         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
2291
2292         It's a Mac-specific test so just add the required LayoutTestController
2293         function as a no-op to avoid failing. Similar approach adopted by other
2294         ports.
2295
2296         https://bugs.webkit.org/show_bug.cgi?id=33344
2297
2298         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2299         (LayoutTestController::addDisallowedURL):
2300
2301 2010-06-21  Sam Weinig  <sam@webkit.org>
2302
2303         Reviewed by Anders Carlsson.
2304
2305         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
2306         Add message passing support to the WebKit2 API.
2307
2308         - Add some test messages.
2309
2310         * MiniBrowser/mac/AppDelegate.m:
2311         (_didRecieveMessageFromInjectedBundle):
2312         (-[BrowserAppDelegate init]):
2313         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2314         (_didClearWindow):
2315         (_didCreatePage):
2316         (_didRecieveMessage):
2317         (WKBundleInitialize):
2318
2319 2010-06-21  Drew Wilson  <atwilson@chromium.org>
2320
2321         Unreviewed.
2322
2323         Rolling back 61551 and 61555 due to test failures.
2324
2325         * DumpRenderTree/LayoutTestController.cpp:
2326         (LayoutTestController::staticFunctions):
2327         * DumpRenderTree/LayoutTestController.h:
2328         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2329         (LayoutTestController::setEditingBehavior):
2330         * DumpRenderTree/mac/UIDelegate.mm:
2331
2332 2010-06-21  Anders Carlsson  <andersca@apple.com>
2333
2334         Reviewed by Sam Weinig.
2335
2336         Make DumpRenderTree build with clang++
2337
2338         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2339         (-[LocalPasteboard setPropertyList:forType:]):
2340         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2341         (-[DumpRenderTreeWindow keyDown:]):
2342         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2343         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2344         (LayoutTestController::isCommandEnabled):
2345
2346 2010-06-21  Satish Sampath  <satish@chromium.org>
2347
2348         Reviewed by Steve Block.
2349
2350         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
2351         https://bugs.webkit.org/show_bug.cgi?id=40878
2352
2353         * Scripts/build-webkit:
2354
2355 2010-06-21  Kent Tamura  <tkent@chromium.org>
2356
2357         Reviewed by Dimitri Glazkov.
2358
2359         [DRT/Chromium] Initialization for http/tests/loading/
2360         https://bugs.webkit.org/show_bug.cgi?id=40902
2361
2362         * DumpRenderTree/chromium/TestShell.cpp:
2363         (TestShell::runFileTest):
2364
2365 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2366
2367         Unreviewed.
2368
2369         Adding myself to the committers list.
2370
2371         * Scripts/webkitpy/common/config/committers.py:
2372
2373 2010-06-20  Kent Tamura  <tkent@chromium.org>
2374
2375         Reviewed by Dimitri Glazkov.
2376
2377         [DRT/Chromium] Add --allow-external-pages option
2378         https://bugs.webkit.org/show_bug.cgi?id=40762
2379
2380         Add --allow-external-pages introduced by Chromium r45403.
2381         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
2382
2383         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2384         (main):
2385         * DumpRenderTree/chromium/TestShell.cpp:
2386         (TestShell::TestShell):
2387         * DumpRenderTree/chromium/TestShell.h:
2388         (TestShell::allowExternalPages):
2389         (TestShell::setAllowExternalPages):
2390         * DumpRenderTree/chromium/WebViewHost.cpp:
2391         (WebViewHost::willSendRequest):
2392
2393 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2394
2395         Reviewed by Adam Barth.
2396
2397         Sheriffbot: Should allow "r" in SVN_REVISION
2398         https://bugs.webkit.org/show_bug.cgi?id=40889
2399
2400         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
2401         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2402
2403 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
2404
2405         Reviewed by Dimitri Glazkov.
2406
2407         Python Tests Fail after r61508
2408         https://bugs.webkit.org/show_bug.cgi?id=40891
2409
2410         Test's regex list needed to be updated to match the new
2411         regex list in the source code. Added new bots to the
2412         example_buildbots list.
2413
2414         Regex list fixed in r61512. Updated bot list.
2415
2416         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2417
2418 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
2419
2420         Unreviewed, build fix.
2421
2422         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
2423
2424         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2425
2426 2010-06-19  Justin Schuh  <jschuh@chromium.org>
2427
2428         Unreviewed.
2429
2430         Adding myself to the committers list.
2431
2432         * Scripts/webkitpy/common/config/committers.py:
2433
2434 2010-06-19  Sam Weinig  <sam@webkit.org>
2435
2436         Reviewed by Anders Carlsson.
2437
2438         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
2439         Add ability to have a WebProcess per WebContext.
2440
2441         Move to use new shared contexts API.
2442
2443         * MiniBrowser/mac/AppDelegate.h:
2444         * MiniBrowser/mac/AppDelegate.m:
2445         (-[BrowserAppDelegate init]):
2446         (-[BrowserAppDelegate getCurrentPageNamespace]):
2447         (-[BrowserAppDelegate validateMenuItem:]):
2448         (-[BrowserAppDelegate _setProcessModel:]):
2449         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
2450         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
2451         * MiniBrowser/win/BrowserView.cpp:
2452         (BrowserView::create):
2453
2454 2010-06-02  Robert Hogan  <robert@webkit.org>
2455
2456         Reviewed by Adam Barth.
2457
2458         [Qt] Support evaluateScriptInIsolatedWorld()
2459
2460         https://bugs.webkit.org/show_bug.cgi?id=40079
2461
2462         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2463         (LayoutTestController::evaluateScriptInIsolatedWorld):
2464         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2465
2466 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
2467
2468         Reviewed by Darin Adler.
2469
2470         Add three more non-core Chromium builders to start testing DumpRenderTree.
2471         https://bugs.webkit.org/show_bug.cgi?id=40335
2472
2473         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2474
2475 2010-06-18  Drew Wilson  <atwilson@chromium.org>
2476
2477         Reviewed by Darin Fisher.
2478
2479         [Chromium] Plumbing for top-level frame names
2480         https://bugs.webkit.org/show_bug.cgi?id=40430
2481
2482         * DumpRenderTree/chromium/WebViewHost.cpp:
2483         (WebViewHost::reset):
2484         Changed obsolete call to clearName() to use setName(WebString()) instead.
2485
2486 2010-06-18  Sam Weinig  <weinig@apple.com>
2487
2488         Rolling http://trac.webkit.org/changeset/61297 back in.
2489
2490         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2491         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
2492         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
2493         (_didClearWindow):
2494         (_didCreatePage):
2495         (WKBundleInitialize):
2496
2497 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
2498
2499         Reviewed by Darin Adler.
2500
2501         https://bugs.webkit.org/show_bug.cgi?id=40803
2502         TestNetscapePlugin has an incorrect implementation of "property" property
2503
2504         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
2505         pass a static string back, it's going to be released by NPAPI implementation.
2506
2507 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2508
2509         Unreviewed.
2510
2511         Adding myself to the committers list.
2512
2513         * Scripts/webkitpy/common/config/committers.py:
2514
2515 2010-06-17  Tony Chang  <tony@chromium.org>
2516
2517         Reviewed by Kent Tamura.
2518
2519         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
2520         https://bugs.webkit.org/show_bug.cgi?id=40615
2521
2522         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2523
2524 2010-06-17  Ada Chan  <adachan@apple.com>
2525
2526         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
2527
2528         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2529         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
2530         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2531
2532 2010-06-17  Darin Adler  <darin@apple.com>
2533
2534         One more try at fix for Chromium build.
2535
2536         * DumpRenderTree/chromium/TestShell.cpp:
2537         (TestShell::TestShell): Use set again instead of =.
2538
2539 2010-06-17  Darin Adler  <darin@apple.com>
2540
2541         Fix Chromium build.
2542
2543         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
2544         code with all the other platforms! Wow, that should be fixed at some point.
2545
2546         * DumpRenderTree/chromium/TestShell.cpp:
2547         (TestShell::TestShell): Changed back to using "new".
2548         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2549
2550 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
2551
2552         Unreviewed Qt build fix.
2553
2554         LayoutTestController in the Qt DRT is not using refs :)
2555
2556         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2557         (WebCore::DumpRenderTree::DumpRenderTree):
2558
2559 2010-06-17  Darin Adler  <darin@apple.com>
2560
2561         Reviewed by Sam Weinig.
2562
2563         Use adoptRef and create functions in more code paths
2564         https://bugs.webkit.org/show_bug.cgi?id=40760
2565
2566         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
2567
2568         * DumpRenderTree/LayoutTestController.cpp:
2569         (LayoutTestController::create): Added.
2570         * DumpRenderTree/LayoutTestController.h: Declare the create function.
2571
2572         * DumpRenderTree/chromium/TestShell.cpp:
2573         (TestShell::TestShell): Use create instead of new.
2574         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
2575
2576         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2577         (runTest): Use RefPtr and create instead of OwnPtr and new.
2578
2579         * DumpRenderTree/mac/DumpRenderTree.mm:
2580         (runTest): Use RefPtr and create instead of OwnPtr and new.
2581
2582         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2583         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
2584         instead of new.
2585
2586         * DumpRenderTree/win/DumpRenderTree.cpp:
2587         (runTest): Use RefPtr and create instead of OwnPtr and new.
2588
2589         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2590         (runTest): Use RefPtr and create instead of OwnPtr and new.
2591         (MyApp::OnInit): Removed unneeded code to delete the layout
2592         test controller. This is done during each test.
2593
2594 2010-06-17  Kent Tamura  <tkent@chromium.org>
2595
2596         Reviewed by Shinichiro Hamaji.
2597
2598         [DRT/Chromium] Fix a bug of Windows pixel tests
2599         https://bugs.webkit.org/show_bug.cgi?id=40763
2600
2601         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2602         (TestShellPrinter::handleImage):
2603
2604 2010-06-16  Kent Tamura  <tkent@chromium.org>
2605
2606         Reviewed by Shinichiro Hamaji.
2607
2608         [DRT/Chromium] Fix crash on Mac Release
2609         https://bugs.webkit.org/show_bug.cgi?id=40759
2610
2611         * DumpRenderTree/chromium/WebViewHost.cpp:
2612         (WebViewHost::paintRect): We should not use m_canvas directly because
2613           it is created lazily in canvas().
2614
2615 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2616
2617         [wx] Build fix after new method addition.
2618
2619         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2620         (LayoutTestController::pageProperty):
2621
2622 2010-06-16  Kent Tamura  <tkent@chromium.org>
2623
2624         Reviewed by Dimitri Glazkov.
2625
2626         [DRT/Chromium] Set current working directory for each of tests
2627         https://bugs.webkit.org/show_bug.cgi?id=40668
2628
2629         This change fixes tests with eventSender.beginDragWithFiles().
2630
2631         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2632         (runTest):
2633
2634 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2635
2636         Reviewed by Gustavo Noronha Silva.
2637
2638         [GTK] r60803 broke media/controls-drag-timebar.html
2639         https://bugs.webkit.org/show_bug.cgi?id=40269
2640
2641         Only queue events while the mouse button is down, if drag mode is enabled. Some
2642         tests may disable drag mode, to prevent the queuing of events in this situation.
2643
2644         * DumpRenderTree/gtk/EventSender.cpp:
2645         (sendOrQueueEvent): Only queue events here if dragMode is true.
2646
2647 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2648
2649         Reviewed by Gustavo Noronha Silva.
2650
2651         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
2652         https://bugs.webkit.org/show_bug.cgi?id=40600
2653
2654         * DumpRenderTree/gtk/EventSender.cpp:
2655         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
2656
2657 2010-06-16  Adam Barth  <abarth@webkit.org>
2658
2659         Reviewed by Dimitri Glazkov.
2660
2661         Add a hidden land-cowboy command to webkit-patch to help land quick
2662         build fixes.
2663
2664         * Scripts/webkitpy/tool/commands/download.py:
2665         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2666
2667 2010-06-16  Adam Roben  <aroben@apple.com>
2668
2669         Convert console messages to UTF-8 before printing them
2670
2671         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
2672         http/tests/security/xssAuditor/embed-tag-null-char.html and
2673         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
2674         Windows. (I can't test the fix because Apache is crashing on my
2675         computer.)
2676
2677         Reviewed by Alexey Proskuryakov.
2678
2679         * DumpRenderTree/win/DumpRenderTree.cpp:
2680         (toUTF8): Extracted the code into an overload that takes a wide string
2681         and a length, then added an overload that takes a wstring.
2682
2683         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
2684         overload.
2685
2686         * DumpRenderTree/win/UIDelegate.cpp:
2687         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
2688         UTF-8 instead of letting printf convert to the current code page.
2689
2690 2010-06-16  Drew Wilson  <atwilson@chromium.org>
2691
2692         Reviewed by Kent Tamura.
2693
2694         [Chromium] Plumbing for top-level frame names
2695         https://bugs.webkit.org/show_bug.cgi?id=40430
2696
2697         * DumpRenderTree/chromium/WebViewHost.cpp:
2698         (WebViewHost::createView):
2699         Migrate to new createView() API.
2700         * DumpRenderTree/chromium/WebViewHost.h:
2701         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
2702
2703 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
2704
2705         Reviewed by Kenneth Rohde Christiansen.
2706
2707         [Qt] Scroll wheel event support to graphics based DRT
2708         https://bugs.webkit.org/show_bug.cgi?id=40577
2709
2710         * DumpRenderTree/qt/EventSenderQt.cpp:
2711         (EventSender::continuousMouseScrollBy):
2712         (EventSender::createGraphicsSceneWheelEvent):
2713         * DumpRenderTree/qt/EventSenderQt.h:
2714
2715 2010-06-16  Adam Roben  <aroben@apple.com>
2716
2717         Remove a stray newline from the Windows version of TestNetscapePlugin
2718
2719         Reviewed by Alexey Proskuryakov.
2720
2721         Fixes <http://webkit.org/b/40728>
2722         plugins/geturlnotify-during-document-teardown.html fails on Windows
2723
2724         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2725         (NPP_Destroy): Removed extra newline that the Mac version doesn't
2726         have.
2727
2728 2010-06-16  Adam Roben  <aroben@apple.com>
2729
2730         Respect LayoutTestController::isPrinting on Windows
2731
2732         This gets some printing tests closer to passing (like
2733         printing/page-rule-in-media-query.html).
2734
2735         Fixes <http://webkit.org/b/40727>.
2736
2737         Reviewed by Dan Bernstein.
2738
2739         * DumpRenderTree/win/DumpRenderTree.cpp:
2740         (dump): Pass LayoutTestController::isPrinting to
2741         IWebFramePrivate::renderTreeAsExternalRepresentation.
2742
2743 2010-06-15  Adam Barth  <abarth@webkit.org>
2744
2745         Reviewed by Eric Seidel.
2746
2747         Enable HTML5 lexer
2748         https://bugs.webkit.org/show_bug.cgi?id=40650
2749
2750         * DumpRenderTree/mac/DumpRenderTree.mm:
2751         (initializeGlobalsFromCommandLineOptions):
2752
2753 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
2754
2755         Reviewed by Shinichiro Hamaji.
2756
2757         Implement render style selection for pages to support CSS3 Paged Media.
2758         https://bugs.webkit.org/show_bug.cgi?id=35961
2759
2760         * DumpRenderTree/LayoutTestController.cpp:
2761         (parsePagePropertyParameters):
2762         (pagePropertyCallback):
2763         (LayoutTestController::staticFunctions):
2764         * DumpRenderTree/LayoutTestController.h:
2765         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2766         (LayoutTestController::pageProperty):
2767         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2768         (LayoutTestController::pageProperty):
2769         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2770         (LayoutTestController::pageProperty):
2771
2772 2010-06-15  Sam Weinig  <sam@webkit.org>
2773
2774         Reviewed by Anders Carlsson.
2775
2776         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
2777         WebKit2: Add mechanism to inject code into the WebProcess on startup
2778
2779         Add initial InjectedBundle support.
2780
2781         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2782         * MiniBrowser/WebBundle-Info.plist: Added.
2783         Add test InjectedBundle to the project.
2784
2785         * MiniBrowser/mac/AppDelegate.m:
2786         (-[BrowserAppDelegate init]):
2787         Get the path to the WebBundle from the the main bundle and pass it to the new
2788         WKContextCreateWithInjectedBundlePath function.
2789
2790         * MiniBrowser/mac/BrowserWindowController.m:
2791         (_didChangeProgress):
2792         Fix the build.  This has been broken for a while.
2793
2794         * MiniBrowser/mac/WebBundle: Added.
2795         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
2796         (_didCreatePage):
2797         (WKBundleInitialize):
2798         Add really basic InjectedBundle.
2799
2800         * MiniBrowser/win/BrowserView.cpp:
2801         (BrowserView::create):
2802         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
2803
2804 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
2805
2806         Reviewed by Darin Adler.
2807
2808         Adding myself to the reviewers list.
2809         https://bugs.webkit.org/show_bug.cgi?id=40693
2810
2811         * Scripts/webkitpy/common/config/committers.py:
2812
2813 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
2814
2815         Reviewed by Xan Lopez.
2816
2817         Switch to using GIO methods instead of realpath in GtkLauncher to determine
2818         the file URI. This should remove warnings about realpath being undefined
2819         when compiling with '-ansi'.
2820
2821         * GtkLauncher/main.c:
2822         (filenameToURL): Use GIO instead of realpath to determine file URI.
2823
2824 2010-06-15  Adam Roben  <aroben@apple.com>
2825
2826         Remove the redundant set-apple-windows-environment-variables script
2827
2828         Apparently update-webkit does this for you these days.
2829
2830         Rubber-stamped by Steve Falkenburg.
2831
2832         * Scripts/set-apple-windows-environment-variables: Removed.
2833
2834 2010-06-14  Adam Roben  <aroben@apple.com>
2835
2836         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
2837         environment variables
2838
2839         Fixes <http://webkit.org/b/40595>.
2840
2841         Reviewed by Steve Falkenburg.
2842
2843         * Scripts/set-apple-windows-environment-variables: Added.
2844         (to_windows_path): Passes the passed-in path through cygpath to
2845         generate a Windows-style path.
2846         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
2847         variables to their defaults, if they aren't already set.
2848
2849 2010-06-14  Adam Roben  <aroben@apple.com>
2850
2851         Speed up run-safari/debug-safari on Windows
2852
2853         Fixes <http://webkit.org/b/40586>.
2854
2855         Reviewed by Steve Falkenburg.
2856
2857         * Scripts/webkitdirs.pm:
2858         (runSafari): When debugging, set up the environment to run Safari
2859         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
2860         actually launch the debugger. When not debugging, just run WebKit.exe
2861         and it will do the rest for us.
2862
2863 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
2864
2865         Reviewed by Kenneth Rohde Christiansen.
2866
2867         [Qt] DRT EventSender support to graphics context events
2868         https://bugs.webkit.org/show_bug.cgi?id=40324
2869
2870         * DumpRenderTree/qt/EventSenderQt.cpp:
2871         (EventSender::contextClick):
2872
2873 2010-06-14  Tony Chang  <tony@chromium.org>
2874
2875         Reviewed by Darin Fisher.
2876
2877         [chromium] checkout chromium third_party directly
2878         https://bugs.webkit.org/show_bug.cgi?id=40556
2879
2880         * Scripts/update-webkit-chromium: some migration code for the bots
2881
2882 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2883
2884         Chromium build fix.
2885
2886         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
2887         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
2888
2889 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2890
2891         Reviewed by Darin Adler.
2892
2893         https://bugs.webkit.org/show_bug.cgi?id=40529
2894         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
2895
2896         * DumpRenderTree/mac/EventSendingController.mm:
2897         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
2898         event for "delete" - it had virtual key code from forward delete, and text from backspace.
2899         Fixed "delete" to mean forward delete.
2900
2901         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
2902         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
2903         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2904         Mac DRT confusion has propagated to other platforms, fixing those.
2905
2906 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
2907
2908         Reviewed by Xan Lopez.
2909
2910         Small GtkLauncher build fix for some systems.
2911
2912         * GtkLauncher/main.c: Add <limit.h> include.
2913
2914 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2915
2916         Reviewed by Laszlo Gombos.
2917
2918         [Qt] navigator.geolocation support for Qt port
2919         https://bugs.webkit.org/show_bug.cgi?id=39724
2920
2921         Implementation for geolocation cases to DumpRenderTreeQt
2922
2923         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2924         (WebCore::WebPage::allowGeolocationRequest):
2925         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2926         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2927         (LayoutTestController::setGeolocationPermission):
2928         (LayoutTestController::setMockGeolocationError):
2929         (LayoutTestController::setMockGeolocationPosition):
2930         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2931         (LayoutTestController::isGeolocationPermissionSet):
2932         (LayoutTestController::geolocationPermission):
2933
2934 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
2935
2936         Reviewed by Darin Adler.
2937
2938         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
2939         be a way of overwriting the Xcode system path.  Making
2940         $WEBKITOUTPUTDIR take precedence over the system default would make
2941         this possible.
2942
2943         * Scripts/webkitdirs.pm:
2944
2945 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
2946
2947         Reviewed by Darin Adler.
2948
2949         AX: link won't return linked element if URL contains #
2950         https://bugs.webkit.org/show_bug.cgi?id=40192
2951
2952         * DumpRenderTree/AccessibilityUIElement.cpp:
2953         (linkedUIElementAtIndexCallback):
2954         (AccessibilityUIElement::getJSClass):
2955         * DumpRenderTree/AccessibilityUIElement.h:
2956         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2957         (AccessibilityUIElement::linkedUIElementAtIndex):
2958         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2959         (AccessibilityUIElement::linkedUIElementAtIndex):
2960         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2961         (AccessibilityUIElement::linkedUIElementAtIndex):
2962
2963 2010-06-13  Adam Barth  <abarth@webkit.org>
2964
2965         Reviewed by Darin Adler.
2966
2967         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
2968         https://bugs.webkit.org/show_bug.cgi?id=39550
2969
2970         This can cause an extra request to bugs.webkit.org durig upload, but it
2971         shouldn't be too bad.  Also, this won't work if you remove the
2972         boilerplate created by prepare-ChangeLog.
2973
2974         * Scripts/webkitpy/common/checkout/changelog.py:
2975         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2976         * Scripts/webkitpy/common/net/bugzilla.py:
2977         * Scripts/webkitpy/tool/steps/abstractstep.py:
2978         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2979         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
2980
2981 2010-06-08  Robert Hogan  <robert@webkit.org>
2982
2983         Reviewed by Eric Seidel.
2984
2985         [Qt] Add support for callShouldCloseOnWebView() to DRT
2986         https://bugs.webkit.org/show_bug.cgi?id=40330
2987
2988         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2989         (LayoutTestController::callShouldCloseOnWebView):
2990         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2991         (LayoutTestController::setCallCloseOnWebViews):
2992
2993 2010-06-12  Eric Seidel  <eric@webkit.org>
2994
2995         Reviewed by Daniel Bates.
2996
2997         do-webcore-rename should have a --verbose option
2998         https://bugs.webkit.org/show_bug.cgi?id=40497
2999
3000         * Scripts/do-webcore-rename:
3001          - Unified how we handle skipping files/directories
3002            this will allow us to "black list" certain files and
3003            directories when performing renames.
3004          - Made do-webcore-rename log what it's skipping when passed --verbose.
3005
3006 2010-06-12  Darin Adler  <darin@apple.com>
3007
3008         * Scripts/run-bindings-tests: Fixed a typo in a message.
3009
3010 2010-06-12  Kent Tamura  <tkent@chromium.org>
3011
3012         Reviewed by Dimitri Glazkov.
3013
3014         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
3015         https://bugs.webkit.org/show_bug.cgi?id=40402
3016
3017         _build_path() of each Chromium port check existence of build path
3018         of Chromium checkout first, then check existence of build path of
3019         WebKit-only checkout.
3020
3021         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3022         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3023         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3024
3025 2010-06-12  Robert Hogan  <robert@webkit.org>
3026
3027         Reviewed by Kenneth Rohde Christiansen.
3028
3029         [Qt] Back-forward list dumping is incorrect
3030
3031         https://bugs.webkit.org/show_bug.cgi?id=36392
3032
3033         Support dumping child history items in DRT.
3034
3035         Unskip:
3036
3037         fast/loader/frame-src-change-added-to-history.html
3038         fast/loader/frame-src-change-not-added-to-history.html
3039         fast/loader/frame-location-change-not-added-to-history.html
3040
3041         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3042         (WebCore::dumpHistoryItem):
3043
3044 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3045
3046         Reviewed by Eric Seidel.
3047
3048         upload all patches that lack in-rietveld to rietveld
3049         https://bugs.webkit.org/show_bug.cgi?id=40444
3050
3051         If it's a patch, then we'll try to upload it as long as it
3052         doesn't have in-rietveld set. No longer set in-rietveld? since
3053         it's not needed.
3054
3055         * Scripts/webkitpy/common/net/bugzilla.py:
3056
3057 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3058
3059         Reviewed by Darin Fisher.
3060
3061         Fix rietveld upload when message length > 100 characters
3062         https://bugs.webkit.org/show_bug.cgi?id=40457
3063
3064         * Scripts/webkitpy/common/net/rietveld.py:
3065
3066 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
3067
3068         Reviewed by Laszlo Gombos.
3069
3070         [Qt] There should be a way to enable popups in QtTestBrowser
3071         https://bugs.webkit.org/show_bug.cgi?id=40427
3072
3073         * QtTestBrowser/main.cpp:
3074         (LauncherWindow::toggleJavascriptCanOpenWindows):
3075         (LauncherWindow::createChrome):
3076
3077 2010-06-10  Adam Barth  <abarth@webkit.org>
3078
3079         Reviewed by Daniel Bates.
3080
3081         Make SheriffBot more chatty
3082         https://bugs.webkit.org/show_bug.cgi?id=40463
3083
3084         People seem to like to talk to SheriffBot, so let's make him chat back.
3085
3086         * Scripts/webkitpy/thirdparty/__init__.py:
3087         * Scripts/webkitpy/tool/bot/irc_command.py:
3088         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
3089         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
3090         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3091
3092 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
3093
3094         Reviewed by Darin Adler.
3095
3096         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
3097         
3098         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
3099         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
3100         WEXITSTATUS on $result instead of just comparing $result to 0.
3101
3102         * Scripts/update-webkit-auxiliary-libs:
3103
3104 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3105
3106         Reviewed by Alexey Proskuryakov.
3107
3108         don't use Exception.message as it's deprecated in python 2.6+
3109         https://bugs.webkit.org/show_bug.cgi?id=40449
3110
3111         * Scripts/webkitpy/tool/commands/queues.py:
3112
3113 2010-06-10  Ojan Vafai  <ojan@chromium.org>
3114
3115         Reviewed by Adam Barth.
3116
3117         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
3118         https://bugs.webkit.org/show_bug.cgi?id=40436
3119
3120         * Scripts/webkitpy/common/system/outputcapture.py:
3121         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3122         * Scripts/webkitpy/tool/commands/queues.py:
3123         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3124         * Scripts/webkitpy/tool/commands/queuestest.py:
3125         * Scripts/webkitpy/tool/mocktool.py:
3126
3127 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3128
3129         Reviewed by Simon Hausmann.
3130
3131         [Qt] *All* WebGL layout tests fail!
3132         https://bugs.webkit.org/show_bug.cgi?id=40296
3133
3134         Added test for WebKitWebGLEnabled to
3135         LayoutTestController::overridePreference().
3136
3137         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3138         (LayoutTestController::overridePreference):
3139
3140 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
3141
3142         Reviewed by Kenneth Rohde Christiansen.
3143
3144         [Qt] DRT EventSender support to graphics mouse events activation
3145         https://bugs.webkit.org/show_bug.cgi?id=40017
3146
3147         * DumpRenderTree/qt/EventSenderQt.cpp:
3148         (EventSender::mouseDown):
3149         (EventSender::mouseUp):
3150         (EventSender::mouseMoveTo):
3151         (EventSender::keyDown):
3152         (EventSender::contextClick):
3153         (EventSender::sendTouchEvent):
3154         (EventSender::sendOrQueueEvent):
3155         (EventSender::eventFilter):
3156         (EventSender::createGraphicsSceneMouseEvent):
3157         (EventSender::sendEvent):
3158         * DumpRenderTree/qt/EventSenderQt.h:
3159         (EventSender::isGraphicsBased):
3160
3161 2010-06-09  Adam Barth  <abarth@webkit.org>
3162
3163         Reviewed by Ojan Vafai.
3164
3165         webkit-patch upload fails for security bugs because there's no rietveld flag
3166         https://bugs.webkit.org/show_bug.cgi?id=40309
3167
3168         There's probably a more elegant way of seeing whether the form control
3169         exists, but this seems to work.
3170
3171         * Scripts/webkitpy/common/net/bugzilla.py:
3172
3173 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3174
3175         Reviewed by Adam Barth.
3176
3177         make rietveld upload faster and avoid posting to bug on errors
3178         https://bugs.webkit.org/show_bug.cgi?id=40389
3179
3180         Only grab the first item of the upload queue instead of trying
3181         to compute the whole list upfront (which is O(n) bugzilla lookups!).
3182
3183         Also, don't post comments to the bug when uploading fails.
3184
3185         * Scripts/webkitpy/common/net/bugzilla.py:
3186         * Scripts/webkitpy/tool/commands/queues.py:
3187         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3188         * Scripts/webkitpy/tool/commands/stepsequence.py:
3189         * Scripts/webkitpy/tool/mocktool.py:
3190
3191 2010-06-09  Ojan Vafai  <ojan@chromium.org>
3192
3193         Reviewed by Adam Barth.
3194
3195         Rietveld upload queue fails when setting in-rietveld flag
3196         https://bugs.webkit.org/show_bug.cgi?id=40371
3197
3198         Make the comment arguments to set_flag_on_attachment optional
3199         and add it to the MockBugzilla.
3200
3201         * Scripts/webkitpy/common/net/bugzilla.py:
3202         * Scripts/webkitpy/tool/bot/queueengine.py:
3203         * Scripts/webkitpy/tool/commands/download_unittest.py:
3204         * Scripts/webkitpy/tool/commands/queues.py:
3205         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3206         * Scripts/webkitpy/tool/mocktool.py:
3207
3208 2010-06-09  Kenneth Russell  <kbr@google.com>
3209
3210         Reviewed by Dimitri Glazkov.
3211
3212         Rename FloatArray to Float32Array
3213         https://bugs.webkit.org/show_bug.cgi?id=40323
3214
3215         Used do-webcore-rename to perform renaming. Manually undid
3216         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
3217         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
3218         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
3219         all layout tests on Safari; built Chromium and ran selected WebGL
3220         tests.
3221
3222         * Scripts/do-webcore-rename:
3223
3224 2010-06-08  Tony Chang  <tony@chromium.org>
3225
3226         Reviewed by David Levin.
3227
3228         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3229         https://bugs.webkit.org/show_bug.cgi?id=40285
3230
3231         * Scripts/webkitdirs.pm:
3232         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3233
3234 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
3235
3236         Reviewed by Tamura Kent.
3237
3238         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
3239         https://bugs.webkit.org/show_bug.cgi?id=40052
3240         
3241         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
3242
3243         * DumpRenderTree/DumpRenderTree.gypi:
3244         * DumpRenderTree/chromium/TestShellWin.cpp:
3245         (platformInit):
3246         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
3247         (WebKit::):
3248         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
3249         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
3250         (WebKit::WebThemeControlDRT::box):
3251         (WebKit::WebThemeControlDRT::line):
3252         (WebKit::WebThemeControlDRT::triangle):
3253         (WebKit::WebThemeControlDRT::roundRect):
3254         (WebKit::WebThemeControlDRT::oval):
3255         (WebKit::WebThemeControlDRT::circle):
3256         (WebKit::WebThemeControlDRT::nestedBoxes):
3257         (WebKit::WebThemeControlDRT::markState):
3258         (WebKit::WebThemeControlDRT::draw):
3259         (WebKit::WebThemeControlDRT::drawTextField):
3260         (WebKit::WebThemeControlDRT::drawProgressBar):
3261         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
3262         (WebKit::WebThemeControlDRT::):
3263         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
3264         (WebKit::):
3265         (WebKit::WebThemeEngineDRT::paintButton):
3266         (WebKit::WebThemeEngineDRT::paintMenuList):
3267         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
3268         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
3269         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
3270         (WebKit::WebThemeEngineDRT::paintTextField):
3271         (WebKit::WebThemeEngineDRT::paintTrackbar):
3272         (WebKit::WebThemeEngineDRT::paintProgressBar):
3273         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
3274         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
3275
3276 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3277
3278         Unreviewed, rolling out r60878.
3279         http://trac.webkit.org/changeset/60878
3280         https://bugs.webkit.org/show_bug.cgi?id=40349
3281
3282         broke linux build (Requested by tony^work on #webkit).
3283
3284         * Scripts/webkitdirs.pm:
3285         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3286
3287 2010-06-08  Tony Chang  <tony@chromium.org>
3288
3289         Reviewed by David Levin.
3290
3291         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
3292         https://bugs.webkit.org/show_bug.cgi?id=40285
3293
3294         * Scripts/webkitdirs.pm:
3295         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3296
3297 2010-06-08  Kenneth Russell  <kbr@google.com>
3298
3299         Unreviewed, build fix.
3300
3301         Fix build breakage from 38145
3302         https://bugs.webkit.org/show_bug.cgi?id=40346
3303
3304         The fix for bug 38145 broke the Chromium Win build because
3305         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
3306         change log2(x) to log(x) / log(2). Built and ran WebGL layout
3307         tests in Safari on Mac OS X. Changed download mirrors for
3308         python-irclib to working ones.
3309
3310         * Scripts/webkitpy/thirdparty/__init__.py:
3311
3312 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
3313
3314         Reviewed by Eric Seidel.
3315
3316         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3317         https://bugs.webkit.org/show_bug.cgi?id=39058
3318
3319         * Scripts/old-run-webkit-tests:
3320          use sourceDir() to find ensure-valid-python in checkPythonVersion()
3321
3322 2010-06-08  Andras Becsi  <abecsi@webkit.org>
3323
3324         Unreviewed buildfix after r60479.
3325
3326         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
3327         versions other than 2.17.3.
3328
3329         * DumpRenderTree/gtk/EventSender.cpp:
3330         (getRootCoords):
3331
3332 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
3333
3334         Reviewed by Oliver Hunt.
3335
3336         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
3337         https://bugs.webkit.org/show_bug.cgi?id=40267
3338
3339         When a mouse button is down, automatically queue mouse motion events and
3340         do not play them back until the mouse button is released. This matches the
3341         behavior of other ports' EventSenders.
3342
3343         * DumpRenderTree/gtk/EventSender.cpp:
3344         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
3345         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
3346
3347 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3348
3349         Reviewed by Sam Weinig.
3350
3351         Add CPP bindings generator
3352         https://bugs.webkit.org/show_bug.cgi?id=38279
3353
3354         Integrate CPP bindings in run-bindings-tests.
3355
3356         * Scripts/run-bindings-tests:
3357
3358 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3359
3360         Reviewed by Ojan Vafai.
3361
3362         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
3363         https://bugs.webkit.org/show_bug.cgi?id=40183
3364
3365         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3366
3367 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3368
3369         Unreviewed.
3370
3371         Add my new email and IRC nick to committers.py.
3372
3373         * Scripts/webkitpy/common/config/committers.py:
3374
3375 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
3376
3377         Unreviewed.
3378
3379         Revert changes in json_results_generator.py's _get_svn_revision.
3380
3381         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3382
3383 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3384
3385         Reviewed by Xan Lopez.
3386
3387         [GTK] GtkLauncher should support relative file paths
3388         https://bugs.webkit.org/show_bug.cgi?id=39944
3389
3390         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
3391
3392         * GtkLauncher/main.c:
3393         (filename_to_url): Added.
3394         (main): Try to resolve arguments as relative file URLs first.
3395
3396 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
3397
3398         Reviewed by Xan Lopez.
3399
3400         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
3401         https://bugs.webkit.org/show_bug.cgi?id=40182
3402
3403         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
3404         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
3405         without breaking DRT.
3406
3407         * DumpRenderTree/gtk/EventSender.cpp:
3408         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
3409         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
3410
3411 2010-06-04  Anders Carlsson  <andersca@apple.com>
3412
3413         Reviewed by David Hyatt.
3414
3415         Make the editing/spelling/context-menu-suggestions.html test more robust
3416         https://bugs.webkit.org/show_bug.cgi?id=40178
3417
3418         Change the contextClick method to return an array of strings describing the context menu items.
3419
3420         * DumpRenderTree/mac/EventSendingController.mm:
3421         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3422         (+[EventSendingController webScriptNameForSelector:]):
3423         (-[EventSendingController contextClick]):
3424
3425 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
3426
3427         Reviewed by Shinichiro Hamaji.
3428
3429         Clean up chromium-specific code from json_results_generator.py.
3430         https://bugs.webkit.org/show_bug.cgi?id=39665
3431
3432         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3433         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3434         * Scripts/webkitpy/layout_tests/port/base.py:
3435         * Scripts/webkitpy/layout_tests/port/chromium.py:
3436
3437 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3438
3439         Reviewed by Adam Barth.
3440
3441         Utilize new takeFirst() method where appropriate.
3442         https://bugs.webkit.org/show_bug.cgi?id=40089
3443
3444         * DumpRenderTree/chromium/EventSender.cpp:
3445         (EventSender::replaySavedEvents):
3446         * DumpRenderTree/chromium/LayoutTestController.cpp:
3447         (LayoutTestController::WorkQueue::processWork):
3448         (LayoutTestController::WorkQueue::reset):
3449
3450 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
3451
3452         Reviewed by Simon Hausmann.
3453
3454         [Qt] QtTestLauncher should allow notifications by default.
3455         https://bugs.webkit.org/show_bug.cgi?id=40078
3456
3457         * QtTestBrowser/main.cpp:
3458         (NotificationsPermissionController::NotificationsPermissionController):
3459         (NotificationsPermissionController::checkPermission):
3460         (NotificationsPermissionController::requestPermission):
3461         (LauncherWindow::LauncherWindow):
3462
3463 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
3464
3465         Reviewed by Adam Barth.
3466
3467         Detect whether the user's environment can open a browser.
3468         https://bugs.webkit.org/show_bug.cgi?id=40136
3469
3470         Some environments like cygwin silently fail webbrowser.open() causing
3471         webkit-patch upload not to display any diff. This detects environments
3472         where webbrowser.open() would fail by testing if webbrowser.get()
3473         raises an exception.
3474
3475         * Scripts/webkitpy/common/system/user.py:
3476         * Scripts/webkitpy/tool/mocktool.py:
3477         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3478
3479 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
3480
3481         Reviewed by David Levin.
3482
3483         Add dependencies required to link with VS Express 2005.
3484         https://bugs.webkit.org/show_bug.cgi?id=40038
3485
3486         Visual Studio implicitly links against these libs.
3487         VC++ Express does not.
3488
3489         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3490         * WinLauncher/WinLauncher.vcproj:
3491
3492 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3493
3494         Reviewed by David Levin.
3495
3496         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
3497         https://bugs.webkit.org/show_bug.cgi?id=40105
3498
3499         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3500         - kill pywebsocket process when url is not alive and the process is not
3501           terminated, not to leave pywebsocket server running.
3502         - fix codecs.open parameters.
3503
3504 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
3505
3506         Reviewed by Alexey Proskuryakov.
3507
3508         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
3509         https://bugs.webkit.org/show_bug.cgi?id=39058
3510
3511         * Scripts/ensure-valid-python:
3512           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
3513           - Add --check-only and --help option.
3514           - --check-only option only checks python version and don't try to install Python 2.5.
3515           - Set executable bit.
3516         * Scripts/old-run-webkit-tests:
3517           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
3518
3519 2010-05-14  Ojan Vafai  <ojan@chromium.org>
3520
3521         Reviewed by Adam Barth.
3522
3523         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
3524         https://bugs.webkit.org/show_bug.cgi?id=38918
3525
3526         Patches with in-rietveld? get uploaded to rietveld and get marked
3527         in-rietveld+. If the upload fails, they are marked in-rietveld-
3528         and an error is logged to the bug, like the commit-queue.
3529
3530         Also, get rid of --fancy-review and the ability to upload to rietveld
3531         using webkit-patch upload/post.
3532
3533         * Scripts/webkitpy/common/net/bugzilla.py:
3534         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3535         * Scripts/webkitpy/tool/commands/download.py:
3536         * Scripts/webkitpy/tool/commands/download_unittest.py:
3537         * Scripts/webkitpy/tool/commands/queues.py:
3538         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3539         * Scripts/webkitpy/tool/commands/upload.py:
3540         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3541         * Scripts/webkitpy/tool/mocktool.py:
3542         * Scripts/webkitpy/tool/steps/options.py:
3543         * Scripts/webkitpy/tool/steps/postcodereview.py:
3544
3545 2010-05-24  Ojan Vafai  <ojan@chromium.org>
3546
3547         Reviewed by Chris Jerdonek.
3548
3549         many webkit-patch commands fail in a non-svn tracking git checkout
3550         https://bugs.webkit.org/show_bug.cgi?id=38156
3551
3552         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
3553         If neither exists, then error out. This makes webkit-patch work
3554         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
3555         to checkout webkit. The fallback to master is for people who don't
3556         do the steps on that page for tracking svn.
3557
3558         * Scripts/webkitpy/common/checkout/scm.py:
3559         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3560
3561 2010-06-03  Mike Fenton  <mifenton@rim.com>
3562
3563         Unreviewed.
3564
3565         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
3566
3567         * Scripts/webkitpy/common/config/committers.py:
3568
3569 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
3570
3571         Reviewed by Yury Semikhatsky.
3572
3573         Web Inspector: a number of fixes that make InspectorController
3574         happy with null redirects.
3575
3576         https://bugs.webkit.org/show_bug.cgi?id=40109
3577
3578         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3579         (runTest):
3580         * DumpRenderTree/mac/DumpRenderTree.mm:
3581         (runTest):
3582         * DumpRenderTree/win/DumpRenderTree.cpp:
3583         (runTest):
3584
3585 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
3586
3587         Reviewed by Shinichiro Hamaji.
3588
3589         [Qt] Fix compilation with QT_NO_PROPERTIES
3590         https://bugs.webkit.org/show_bug.cgi?id=38324
3591
3592         * QtTestBrowser/main.cpp:
3593         (LauncherWindow::init):
3594
3595 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
3596
3597         Reviewed by Kenneth Rohde Christiansen.
3598
3599         [Qt] Make possible run DRT with QGraphicsWebView
3600         https://bugs.webkit.org/show_bug.cgi?id=40016
3601
3602         Make possible to use a environment variable for switching backend.
3603         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
3604
3605         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3606         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
3607         (WebCore::DumpRenderTree::DumpRenderTree):
3608         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3609         (WebCore::DumpRenderTree::setGraphicsBased):
3610         (WebCore::DumpRenderTree::isGraphicsBased):
3611         (WebCore::WebViewGraphicsBased::graphicsView):
3612         (WebCore::WebViewGraphicsBased::setPage):
3613         * Scripts/old-run-webkit-tests:
3614
3615 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
3616
3617         Reviewed by Eric Seidel.
3618
3619         Slave lost shouldn't be recognized as build failed.
3620         https://bugs.webkit.org/show_bug.cgi?id=39282
3621
3622         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
3623         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
3624
3625 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
3626
3627         Reviewed by Kenneth Rohde Christiansen.
3628
3629         [Qt] Fix the lifecycle of notification objects
3630         https://bugs.webkit.org/show_bug.cgi?id=40003
3631
3632         Remove the dependency of notifications on QWebPage.
3633
3634         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3635         (WebCore::requestPermissionCallback):
3636         (WebCore::WebPage::WebPage):
3637         (WebCore::DumpRenderTree::requestPermission):
3638         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3639
3640 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3641
3642         Unreviewed, rolling out r60559.
3643         http://trac.webkit.org/changeset/60559
3644         https://bugs.webkit.org/show_bug.cgi?id=40055
3645
3646         It broke python unit test (Requested by Ossy on #webkit).
3647
3648         * Scripts/webkitpy/common/net/buildbot.py:
3649
3650 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
3651
3652         Reviewed by Eric Seidel.
3653
3654         Slave lost shouldn't be recognized as build failed.
3655         https://bugs.webkit.org/show_bug.cgi?id=39282
3656
3657         * Scripts/webkitpy/common/net/buildbot.py:
3658
3659 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
3660
3661         Reviewed by Eric Seidel.
3662
3663         Fix crash caused when assigned_to is disabled
3664         https://bugs.webkit.org/show_bug.cgi?id=40039
3665
3666         * Scripts/webkitpy/common/net/bugzilla.py:
3667
3668 2010-06-02  Sterling Swigart  <sswigart@google.com>
3669
3670         Reviewed by David Levin.
3671
3672         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
3673         https://bugs.webkit.org/show_bug.cgi?id=39906
3674
3675         * Scripts/build-webkit:
3676
3677 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
3678
3679         Reviewed by Simon Hausmann.
3680
3681         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
3682
3683         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3684         (WebCore::WebPage::WebPage):
3685         (WebCore::WebPage::resetSettings):
3686         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3687         (LayoutTestController::setJavaScriptCanAccessClipboard):
3688
3689 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3690
3691         Reviewed by Mark Rowe.
3692
3693         A nicer Tiger build fix.
3694
3695         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3696         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3697         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
3698
3699 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3700
3701         A real Tiger build fix.
3702
3703         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
3704         for all configurations, not just debug.
3705
3706 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3707
3708         Tiger build fix.
3709
3710         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
3711
3712 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3713
3714         Reviewed by Xan Lopez.
3715
3716         [GTK] Get more mouse tests passing
3717         https://bugs.webkit.org/show_bug.cgi?id=39040
3718
3719         Reproduce the logic from the Windows EventSender for mapping
3720         button numbers to GDK button numbers. Move this logic to the
3721         prepareMouseButtonEvent helper.
3722