2010-12-01 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         new-run-webkit-tests: add a --dry-run / -n flag
6         https://bugs.webkit.org/show_bug.cgi?id=50045
7
8         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
10
11 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
12
13         Reviewed by Adam Roben.
14
15         WinCairo build should not use link-time code generation (LTCG)
16         https://bugs.webkit.org/show_bug.cgi?id=50353
17
18         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
19         * DumpRenderTree/win/DumpRenderTree.vcproj:
20         * DumpRenderTree/win/ImageDiff.vcproj:
21         * FindSafari/FindSafari.vcproj:
22         * MiniBrowser/MiniBrowser.vcproj:
23         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
24         * WebKitAPITest/WebKitAPITest.vcproj:
25         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
26         * WebKitTestRunner/win/InjectedBundle.vcproj:
27         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
28         * WinLauncher/WinLauncher.vcproj:
29         * record-memory-win/record-memory-win.vcproj:
30
31 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
32
33         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
34         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
35         adding the file to the sources list was not enough to force the rebuild.
36
37         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
38         Remove an empty line at the end of this file to force a rebuild.
39
40 2010-12-01  Sam Weinig  <sam@webkit.org>
41
42         Fix windows build.
43
44         * MiniBrowser/win/BrowserView.cpp:
45         (BrowserView::create):
46
47 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
48
49         Add missing file to the TestNetscapePlugin sources list after r73057.
50
51         * GNUmakefile.am: Add missing file.
52
53 2010-12-01  Sam Weinig  <sam@webkit.org>
54
55         Reviewed by Anders Carlsson.
56
57         Add PageGrouping to WebKit2 API
58         https://bugs.webkit.org/show_bug.cgi?id=50332
59
60         - Update testing harnesses to deal with new PageGroup API.
61
62         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
63         (WKBundleInitialize):
64         * TestWebKitAPI/InjectedBundleController.cpp:
65         (TestWebKitAPI::InjectedBundleController::initialize):
66         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
67         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
68         * TestWebKitAPI/InjectedBundleController.h:
69         * TestWebKitAPI/InjectedBundleTest.h:
70         (TestWebKitAPI::InjectedBundleTest::initialize):
71         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
72         * TestWebKitAPI/PlatformUtilities.cpp:
73         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
74         * TestWebKitAPI/PlatformUtilities.h:
75         * TestWebKitAPI/PlatformWebView.h:
76         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
77         (TestWebKitAPI::TEST):
78         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
79         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
80         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
81         (TestWebKitAPI::PlatformWebView::PlatformWebView):
82         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
83         (TestWebKitAPI::PlatformWebView::PlatformWebView):
84         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
85         (WTR::InjectedBundle::didInitializePageGroup):
86         (WTR::InjectedBundle::initialize):
87         (WTR::InjectedBundle::beginTesting):
88         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
89         (WTR::InjectedBundle::pageGroup):
90         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
91         (WTR::LayoutTestController::addUserScript):
92         (WTR::LayoutTestController::addUserStyleSheet):
93         (WTR::LayoutTestController::setXSSAuditorEnabled):
94         * WebKitTestRunner/TestController.cpp:
95         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
96         (WTR::PlatformWebView::PlatformWebView):
97
98 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
99
100         Reviewed by Adam Roben.
101
102         vcproj changes can't be applied cleanly by the Windows EWS bot
103         https://bugs.webkit.org/show_bug.cgi?id=50328
104
105         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
106         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
107         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
108         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
109         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
110         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
111         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
112         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
113         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
114         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
115         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
116         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
117         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
118         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
119         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
120         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
121         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
122         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
123         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
124         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
125         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
126         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
127         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
128         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
129         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
130         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
131         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
132         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
133         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
134         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
135         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
136         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
137         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
138         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
139         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
140         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
141         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
142         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
143         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
144         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
145         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
146         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
147         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
148         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
149         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
150
151 2010-12-01  Anders Carlsson  <andersca@apple.com>
152
153         Reviewed by Darin Adler.
154
155         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
156         https://bugs.webkit.org/show_bug.cgi?id=50336
157
158         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
159         Add new test.
160
161         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
162         (PluginTest::NPP_New):
163         Add default implementation/
164
165         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
166         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
167         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
168         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
169         Get the user agent.
170
171         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
172         (NPP_New):
173         Call PluginTest::NPP_New.
174
175         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
176         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
177         Add new files.
178
179         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
180         (webkit_test_plugin_new_instance):
181         Call PluginTest::NPP_New.
182
183 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
184
185         [wx] Build fixes after recent trunk changes.
186
187         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
188         (LayoutTestController::findString):
189         * wx/build/settings.py:
190
191 2010-12-01  Dan Bernstein  <mitz@apple.com>
192
193         Reviewed by Darin Adler.
194
195         WebKitTestRunner needs layoutTestController.findString
196         https://bugs.webkit.org/show_bug.cgi?id=50238
197
198         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
199         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
200         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
201         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
202
203 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
204
205         Try using svn:eol-style native on a vcproj file.
206
207         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
208
209 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
210
211         Reviewed by Adam Roben.
212
213         [WINCE] Add WinCELauncher
214         https://bugs.webkit.org/show_bug.cgi?id=50217
215
216         * WinCELauncher/main.cpp: Added.
217
218 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
219
220         Reviewed by Kenneth Rohde Christiansen.
221
222         [Qt] Implement layoutTestController.findString
223         https://bugs.webkit.org/show_bug.cgi?id=50236
224
225         Add the missing function to the LayoutTestController.
226
227         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
228         (LayoutTestController::findString):
229         * DumpRenderTree/qt/LayoutTestControllerQt.h:
230
231 2010-11-30  Tony Chang  <tony@chromium.org>
232
233         Reviewed by Adam Barth.
234
235         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
236         https://bugs.webkit.org/show_bug.cgi?id=49036
237
238         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
239             for CppVariants.
240         (LayoutTestController::cppVariantToBool):
241         (LayoutTestController::cppVariantToInt32):
242         (LayoutTestController::setDatabaseQuota):
243         (LayoutTestController::evaluateInWebInspector):
244         (LayoutTestController::setMockGeolocationError):
245
246 2010-11-30  Eric Seidel  <eric@webkit.org>
247
248         Reviewed by Tony Chang.
249
250         update-webkit should call git fetch before git svn rebase
251         https://bugs.webkit.org/show_bug.cgi?id=50273
252
253         After discussion on webkit-dev, we've decided to move the "default"
254         git setup to pulling updates from git.webkit.org in preference
255         to rebuilding the local svn index using git svn fetch every time.
256
257         This change should have no effect on people using the "old" git setup
258         and should dramatically increase the speed of updates for those using
259         the "new" git setup along with update-webkit.  I'm about to move the
260         EWS and other queues over to this setup once this lands.
261
262         * Scripts/update-webkit:
263
264 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
265
266         Reviewed by Xan Lopez.
267
268         GTK: AX: implement press in DRT
269         https://bugs.webkit.org/show_bug.cgi?id=36146
270
271         Implement AccessibilityUIElement::press() for GTK.
272
273         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
274         (AccessibilityUIElement::press): Implemented.
275
276 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
277
278         Reviewed by Tony Chang.
279
280         config.webkit_base_dir returns a path with a trailing slash
281         https://bugs.webkit.org/show_bug.cgi?id=50197
282         
283         config.webkit_base_dir() should return a path without a trailing slash,
284         like all the other methods that return paths.
285         
286         Undoes MockFileSytem changes by r72640, since they're no longer
287         necessary for GetBaselinesTest to pass.
288
289         * Scripts/webkitpy/common/system/filesystem_mock.py:
290         * Scripts/webkitpy/layout_tests/port/base.py:
291         * Scripts/webkitpy/layout_tests/port/config.py:
292         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
293
294 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
295
296         Reviewed by Tony Chang.
297
298         Rebaseline server: baseline display tweaks
299         https://bugs.webkit.org/show_bug.cgi?id=50207
300         
301         Determine which baselines were used when running the tests and highlight
302         them in the UI. Sort platform names alphabetically.
303         
304         Also makes the server URL be launched in the user's browser
305         automatically.
306
307         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
308         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
309         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
310         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
311         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
312
313 2010-11-30  Dan Bernstein  <mitz@apple.com>
314
315         Reviewed by Anders Carlsson.
316
317         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
318         https://bugs.webkit.org/show_bug.cgi?id=50238
319
320         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
321         (WTR::LayoutTestController::findString): Added.
322         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
323
324 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
325
326         Reviewed by Adam Roben.
327
328         All projects on Windows should use cmd files for build events
329         https://bugs.webkit.org/show_bug.cgi?id=50213
330
331         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
332         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
333         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
334         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
335         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
336         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
337         * DumpRenderTree/win/ImageDiffCommon.vsprops:
338         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
339         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
340         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
341         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
342         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
343         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
344         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
345         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
346         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
347         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
348         * WebKitAPITest/WebKitAPITestCommon.vsprops:
349         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
350         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
351         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
352         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
353         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
354         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
355         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
356         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
357         * WinLauncher/WinLauncherCommon.vsprops:
358         * WinLauncher/WinLauncherPostBuild.cmd: Added.
359         * WinLauncher/WinLauncherPreBuild.cmd: Added.
360
361 2010-11-29  Dan Bernstein  <mitz@apple.com>
362
363         GTK DumpRenderTree build fix after r72887.
364
365         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
366         (LayoutTestController::findString):
367
368 2010-11-29  Dan Bernstein  <mitz@apple.com>
369
370         Windows DumpRenderTree build fix after r72887.
371
372         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
373         (LayoutTestController::findString): Added empty implementation.
374
375 2010-11-29  Dan Bernstein  <mitz@apple.com>
376
377         Reviewed by Darin Adler.
378
379         DumpRenderTree changes for testing the text search API.
380         https://bugs.webkit.org/show_bug.cgi?id=50038
381
382         * DumpRenderTree/LayoutTestController.cpp:
383         (findStringCallback):
384         (LayoutTestController::staticFunctions):
385         * DumpRenderTree/LayoutTestController.h:
386         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
387         (LayoutTestController::findString):
388         * MiniBrowser/mac/BrowserWindowController.m:
389         (-[BrowserWindowController find:]):
390
391 2010-11-29  Johnny Ding  <jnd@chromium.org>
392
393         Unreviewed: Add myself to the list of Committers.
394
395         * Scripts/webkitpy/common/config/committers.py:
396
397 2010-11-29  Mark Rowe  <mrowe@apple.com>
398
399         Reviewed by Adele Peterson.
400
401         <rdar://problem/8694997> DumpRenderTree fails to build.
402
403         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
404
405 2010-11-29  Mark Rowe  <mrowe@apple.com>
406
407         Reviewed by Adele Peterson.
408
409         <rdar://problem/8694997> DumpRenderTree fails to build.
410
411         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
412         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
413         * DumpRenderTree/mac/PerlSupport/Makefile:
414
415 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
416
417         Reviewed by Martin Robinson.
418
419         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
420         https://bugs.webkit.org/show_bug.cgi?id=50154
421
422         Added missing checks to allAttributes().
423
424         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
425         (AccessibilityUIElement::allAttributes): Added missing checks.
426
427 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
428
429         Reviewed by Kenneth Rohde Christiansen.
430
431         [Qt] Allow pre-generation for package builds for WebKit2
432         https://bugs.webkit.org/show_bug.cgi?id=50139
433
434         Use a build variable for the generated directory path and set the
435         value based on CONFIG just like for WebKit1.
436
437         For non-package builds use a relative base path for the
438         genrated directory just like for WebKit1.
439
440         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
441         * WebKitTestRunner/qt/WebKitTestRunner.pro:
442
443 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
444
445         Reviewed by Kenneth Rohde Christiansen.
446
447         [Qt] Move some build logic from Qt to platform independent code
448         https://bugs.webkit.org/show_bug.cgi?id=50134
449
450         Create target directories inside generate-forwarding-headers.pl.
451
452         * Scripts/generate-forwarding-headers.pl:
453
454 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
455
456         Reviewed by Martin Robinson.
457
458         [GTK] Windowless plugins gets broken key input
459         https://bugs.webkit.org/show_bug.cgi?id=49927
460
461         Convert the XEvent::keycode to ASCII before printing it. Not
462         doing this was causing false positive in 
463         plugins/keyboard-events.html.
464
465         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
466         (keycode_to_char):
467         (webkit_test_plugin_handle_event):
468
469 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
470
471         Reviewed by Antonio Gomes.
472
473         [Qt] Html autofocus not working with QGraphicsWebView
474         https://bugs.webkit.org/show_bug.cgi?id=43169
475
476         Tell the scene to set the webview item as the currently
477         focused item. This makes the input field with autofocus get
478         focus as it should.
479
480         * QtTestBrowser/webview.cpp:
481         (WebViewGraphicsBased::WebViewGraphicsBased):
482
483 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
484
485         Reviewed by Tony Chang.
486
487         nrwt - clean up create_driver interface and print out the
488         command line used for DumpRenderTree/TestShell.
489
490         This patch adds a driver_cmd_line() call to the Port class in
491         order to retrive the command line to print it out (as part of
492         --print config).
493
494         In addition, this patch cleans up the Port.create_driver()
495         signature and the Driver constructor interface to take a worker
496         number and no longer require the image_path argument (Chromium's
497         drivers now synthesize the image_path from the worker number
498         internally).
499
500         https://bugs.webkit.org/show_bug.cgi?id=49934
501
502         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
503         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
504         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
505         * Scripts/webkitpy/layout_tests/port/base.py:
506         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
507         * Scripts/webkitpy/layout_tests/port/chromium.py:
508         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
509         * Scripts/webkitpy/layout_tests/port/dryrun.py:
510         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
511         * Scripts/webkitpy/layout_tests/port/test.py:
512         * Scripts/webkitpy/layout_tests/port/webkit.py:
513         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
514         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
515
516 2010-11-24  Ojan Vafai  <ojan@chromium.org>
517
518         Reviewed by Tony Chang.
519
520         [chromium] improve memory usage for test results server and store fewer runs
521         https://bugs.webkit.org/show_bug.cgi?id=50035
522
523         Store fewer runs and don't pass full files around when we only need bools.
524         Greatly improves error rates on test-results.appspot.com.
525
526         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
527         * TestResultServer/handlers/testfilehandler.py:
528         * TestResultServer/model/dashboardfile.py:
529         * TestResultServer/model/jsonresults.py:
530
531 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
532
533         Reviewed by Tony Chang.
534
535         This patch implements the first part of the manager side of the
536         Broker objects - it handles creating threads, waiting for them
537         to complete, and running a single-threaded loop as well.
538
539         https://bugs.webkit.org/show_bug.cgi?id=49779
540
541         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
542         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
543         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
544         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
545
546 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
547
548         Reviewed by David Levin.
549
550         DRT should not generate pixel output for text/plain tests
551         https://bugs.webkit.org/show_bug.cgi?id=50002
552         
553         Modify Mac, Windows and GTK DRT implementations to disable pixel output
554         when encountering a text/plain response (the Chromium one already does
555         this, and none of the other ports special-case text/plain output in
556         the first place).
557
558         * DumpRenderTree/gtk/DumpRenderTree.cpp:
559         (dump):
560         * DumpRenderTree/mac/DumpRenderTree.mm:
561         (dump):
562         * DumpRenderTree/win/DumpRenderTree.cpp:
563         (dump):
564
565 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
566
567         Unreviewed.
568
569         Add my other email address to committers.py.
570
571         * Scripts/webkitpy/common/config/committers.py:
572
573 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
574
575         Reviewed by Csaba Osztrogonác.
576
577         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
578         https://bugs.webkit.org/show_bug.cgi?id=49975
579
580         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
581         to enable the script to define it 0 in case of a minimal build.
582
583 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
584
585         Reviewed by Xan Lopez.
586
587         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
588         https://bugs.webkit.org/show_bug.cgi?id=49143
589
590         * DumpRenderTree/gtk/DumpRenderTree.cpp:
591         (createWebView): Call the new connectEditingCallbacks function.
592         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
593         (dumpNodePath):
594         (dumpRange):
595         (insertActionString):
596         (selectionAffinityString):
597         (shouldBeginEditing):
598         (shouldEndEditing):
599         (shouldInsertNode):
600         (shouldInsertText):
601         (shouldDeleteRange):
602         (shouldShowDeleteInterfaceForElement):
603         (shouldChangeSelectedRange):
604         (shouldApplyStyle):
605         (editingBegan):
606         (userChangedContents):
607         (editingEnded):
608         (selectionChanged):
609         (connectEditingCallbacks):
610         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
611         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
612
613 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
614
615         Reviewed by Andreas Kling.
616
617         [Qt] Make QtTestBrowser remember the selected user agent
618         https://bugs.webkit.org/show_bug.cgi?id=50021
619
620         Set user agent for a new page by using the old page's
621
622         * QtTestBrowser/mainwindow.cpp:
623         (MainWindow::setPage):
624
625 2010-11-24 Patrick Gansterer <paroga@webkit.org>
626
627         Reviewed by Csaba Osztrogonác.
628
629         Remove Bakefile build system files
630         https://bugs.webkit.org/show_bug.cgi?id=49983
631
632         r53757 only removed the content, but not the files.
633         This patch removes that empty files.
634
635         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
636         * wx/browser/browser.bkl: Removed.
637         * wx/build-wxwebkit: Removed.
638
639 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
640
641         Reviewed by Tony Chang.
642
643         This patch cleans up the logic used to shard tests into groups a
644         bit and adds the --worker-model flag to NRWT. The flag is only
645         used at the moment to control whether to run single-threaded or
646         not, but eventually will also allow toggling between threads and
647         processes.
648
649         Also add a minor cleanup with _test_is_slow(), which just
650         eliminates some repetition and gives slightly better encapsulation.
651
652         https://bugs.webkit.org/show_bug.cgi?id=49773
653
654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
655         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
656
657 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
658
659         Reviewed by Tony Chang.
660
661         Rebaseline server: list current baselines and platforms
662         https://bugs.webkit.org/show_bug.cgi?id=49991
663         
664         List existing baselines (with Trac links) for tests.
665         
666         Add dropdowns for choosing with platform baselines to target (and what
667         to do with existing ones).
668
669         Also fix MockFileSystem.join to behave more like os.path.join (unit
670         test was ending up with two consecutive slashes in a layout test
671         path).        
672
673         * Scripts/webkitpy/common/system/filesystem_mock.py:
674         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
675         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
676         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
677         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
678         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
679         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
680         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
681
682 2010-11-23  Ojan Vafai  <ojan@chromium.org>
683
684         Reviewed by Tony Chang.
685
686         remove timeout argument to urlopen
687         https://bugs.webkit.org/show_bug.cgi?id=49995
688
689         Apparently the version of python we have on the bots doesn't accept a timeout argument.
690
691         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
692
693 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
694
695         Unreviewed, rolling out r72628.
696         http://trac.webkit.org/changeset/72628
697         https://bugs.webkit.org/show_bug.cgi?id=49994
698
699         This patch is causing layout-test failtures on GTK Linux
700         64-bit Debug (Requested by ctguil on #webkit).
701
702         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
703         (AccessibilityUIElement::AccessibilityUIElement):
704         (AccessibilityUIElement::parentElementCallback):
705         * DumpRenderTree/chromium/AccessibilityUIElement.h:
706         * DumpRenderTree/chromium/CppBoundClass.cpp:
707         * DumpRenderTree/chromium/CppBoundClass.h:
708
709 2010-11-22  Ojan Vafai  <ojan@chromium.org>
710
711         Reviewed by Tony Chang.
712
713         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
714         https://bugs.webkit.org/show_bug.cgi?id=49944
715
716         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
717
718 2010-11-23  Chris Guillory  <chris.guillory@google.com>
719
720         Reviewed by Dimitri Glazkov.
721
722         Include the FrameView widget of a RenderWidget in the accessibility tree.
723         https://bugs.webkit.org/show_bug.cgi?id=49106
724
725         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
726         (AccessibilityUIElement::AccessibilityUIElement):
727         (AccessibilityUIElement::parentElementCallback):
728         (AccessibilityUIElement::isEqualCallback):
729         * DumpRenderTree/chromium/AccessibilityUIElement.h:
730         * DumpRenderTree/chromium/CppBoundClass.cpp:
731         (CppBoundClass::getFromCppVariant):
732         * DumpRenderTree/chromium/CppBoundClass.h:
733
734 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
735
736         Reviewed by Kenneth Rohde Christiansen.
737
738         [EFL] Add tiled backing store to EWebLauncher
739         https://bugs.webkit.org/show_bug.cgi?id=45777
740
741         Allow EWebLauncher to choose between single and tiled backing store
742
743         * EWebLauncher/main.c:
744         (on_key_down):
745         (browserCreate):
746         (main):
747
748 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
749
750         Reviewed by Tor Arne Vestbø.
751
752         [Qt] Review the setUserPermission & friends API
753         https://bugs.webkit.org/show_bug.cgi?id=46810
754
755         Renamed requestPermissionFromUser to featurePermissionRequested
756         and cancelRequestsForPermission to featurePermissionRequestCanceled.
757
758         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
759         (WebCore::WebPage::WebPage):
760         * QtTestBrowser/webpage.cpp:
761         (WebPage::WebPage):
762         (WebPage::featurePermissionRequestCanceled):
763         * QtTestBrowser/webpage.h:
764
765 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
766
767         Reviewed by Tor Arne Vestbø.
768
769         [Qt] Review the setUserPermission & friends API
770         https://bugs.webkit.org/show_bug.cgi?id=46810
771
772         Rename setUserPermission to setFeaturePermission
773
774         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
775         (WebCore::WebPage::requestPermission):
776         (WebCore::WebPage::permissionSet):
777         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
778         (LayoutTestController::grantDesktopNotificationPermission):
779         * QtTestBrowser/webpage.cpp:
780         (WebPage::requestPermission):
781
782 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
783
784         Reviewed by Tor Arne Vestbø.
785
786         [Qt] Review the setUserPermission & friends API
787         https://bugs.webkit.org/show_bug.cgi?id=46810
788
789         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
790         and GeolocationPermissionDomain to Geolocation.
791
792         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
793         (WebCore::WebPage::WebPage):
794         (WebCore::WebPage::requestPermission):
795         (WebCore::WebPage::cancelPermission):
796         (WebCore::WebPage::permissionSet):
797         (WebCore::DumpRenderTree::geolocationPermissionSet):
798         * DumpRenderTree/qt/DumpRenderTreeQt.h:
799         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
800         (LayoutTestController::grantDesktopNotificationPermission):
801         * QtTestBrowser/webpage.cpp:
802         (WebPage::WebPage):
803         (WebPage::requestPermission):
804         (WebPage::cancelRequestsForPermission):
805         * QtTestBrowser/webpage.h:
806
807 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
808
809         Reviewed by Tor Arne Vestbø.
810
811         [Qt] Review the setUserPermission & friends API
812         https://bugs.webkit.org/show_bug.cgi?id=46810
813
814         Add a ByUser suffix to PermissionGranted/Denied. In the future
815         we can add PermissionGrantedByDefault.
816
817
818         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
819         (WebCore::WebPage::requestPermission):
820         (WebCore::WebPage::permissionSet):
821         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
822         (LayoutTestController::grantDesktopNotificationPermission):
823         * QtTestBrowser/webpage.cpp:
824         (WebPage::requestPermission):
825
826 2010-11-18  Satish Sampath  <satish@chromium.org>
827
828         Reviewed by Jeremy Orlow.
829
830         For speech input event, send an event object containing all the recognition results and metadata.
831         https://bugs.webkit.org/show_bug.cgi?id=49736
832
833         Updated DRT by renaming the mock result method on all platforms to the new signature.
834
835         * DumpRenderTree/LayoutTestController.cpp:
836         (addMockSpeechInputResultCallback):
837         (LayoutTestController::staticFunctions):
838         * DumpRenderTree/LayoutTestController.h:
839         * DumpRenderTree/chromium/LayoutTestController.cpp:
840         (LayoutTestController::LayoutTestController):
841         (LayoutTestController::addMockSpeechInputResult):
842         * DumpRenderTree/chromium/LayoutTestController.h:
843         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
844         (LayoutTestController::addMockSpeechInputResult):
845         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
846         (LayoutTestController::addMockSpeechInputResult):
847         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
848         (LayoutTestController::addMockSpeechInputResult):
849         * DumpRenderTree/qt/LayoutTestControllerQt.h:
850         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
851         (LayoutTestController::addMockSpeechInputResult):
852         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
853         (LayoutTestController::addMockSpeechInputResult):
854
855 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
856
857         Reviewed by Tony Chang.
858
859         Fix some spacing issues with log messages with
860         new-run-webkit-tests --verbose.
861
862         https://bugs.webkit.org/show_bug.cgi?id=49936
863
864         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
865
866 2010-11-22  Ojan Vafai  <ojan@chromium.org>
867
868         Reviewed by Adam Barth.
869
870         update scm to work with different remote branches
871         https://bugs.webkit.org/show_bug.cgi?id=49949
872
873         This works if there are multiple svn tracking branches
874         and/or if the tracking branch is refs/remots/origin/master
875         instead of refs/remotes/trunk which is the direction we're trying
876         to head since that makes fetches faster.
877
878         * Scripts/webkitpy/common/checkout/scm.py:
879         * Scripts/webkitpy/common/checkout/scm_unittest.py:
880
881 2010-11-22  Hayato Ito  <hayato@chromium.org>
882
883         Reviewed by Shinichiro Hamaji.
884
885         Ignore reference files which will be used by reftests when collecting
886         test cases.
887         https://bugs.webkit.org/show_bug.cgi?id=49835
888
889         * Scripts/webkitpy/layout_tests/port/test_files.py:
890         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
891
892 2010-11-22  Adam Roben  <aroben@apple.com>
893
894         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
895
896         Apple's Windows build allows placing header files and import libraries for WebKit's
897         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
898         $WebKitLibrariesDir environment variable. This is both required for production builds and
899         convenient for Apple-internal developer builds. Apple's production builds also require that
900         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
901         builds, the files are copied into that directory tree by the
902         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
903         copying is done by
904         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
905
906         This .vsprops copying is problematic in one very important case: when a developer updates
907         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
908         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
909         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
910         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
911         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
912         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
913
914         To fix this, we now use normal relative paths to access the .vsprops files in the source
915         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
916         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
917         unset, so the normal relative paths are used to read the .vsprops files out of the source
918         tree directly. In production builds, this environment variable is set to a fake directory
919         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
920         is resolved.
921         
922         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
923
924         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
925
926         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
927         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
928         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
929         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
930         FeatureDefines.vsprops becomes:
931
932         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
933
934         which resolves to:
935
936         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
937
938         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
939         actually exist since they are matched by an equal number of ".." path components.)
940
941         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
942         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
943
944         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
945         updated
946
947         Reviewed by Dave Hyatt.
948
949         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
950         * DumpRenderTree/win/DumpRenderTree.vcproj:
951         * DumpRenderTree/win/ImageDiff.vcproj:
952         * FindSafari/FindSafari.vcproj:
953         * MiniBrowser/MiniBrowser.vcproj:
954         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
955         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
956         * WebKitAPITest/WebKitAPITest.vcproj:
957         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
958         * WebKitTestRunner/win/InjectedBundle.vcproj:
959         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
960         * WinLauncher/WinLauncher.vcproj:
961         * record-memory-win/record-memory-win.vcproj:
962         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
963         files.
964
965 2010-11-22  Adam Roben  <aroben@apple.com>
966
967         Make it possible to run tests on Windows without Visual Studio or VC++
968         Express installed
969
970         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
971         are not installed. But this function doesn't need to be called when we
972         already have a build available and are just trying to run the tests.
973
974         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
975         because Visual Studio/VC++ Express aren't installed
976
977         Reviewed by Dave Hyatt.
978
979         * Scripts/webkitdirs.pm:
980         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
981         it is not needed by this function. Also added a FIXME.
982
983         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
984         relying on determineConfigurationForVisualStudio doing it.
985
986 2010-11-19  Hayato Ito  <hayato@chromium.org>
987
988         Reviewed by Shinichiro Hamaji.
989
990         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
991
992         https://bugs.webkit.org/show_bug.cgi?id=49812
993
994         * Scripts/webkitpy/layout_tests/driver_test.py:
995         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
996         * Scripts/webkitpy/layout_tests/port/base.py:
997         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
998         * Scripts/webkitpy/layout_tests/port/chromium.py:
999         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1000         * Scripts/webkitpy/layout_tests/port/test.py:
1001         * Scripts/webkitpy/layout_tests/port/webkit.py:
1002         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1003         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1004
1005 2010-11-22  Hayato Ito  <hayato@chromium.org>
1006
1007         Reviewed by Tony Chang.
1008
1009         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1010
1011         https://bugs.webkit.org/show_bug.cgi?id=49924
1012
1013         * Scripts/webkitpy/layout_tests/port/chromium.py:
1014
1015 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1016
1017         Reviewed by Kenneth Rohde Christiansen.
1018
1019         Fix EWebLauncher zoom discretization
1020         https://bugs.webkit.org/show_bug.cgi?id=49810
1021
1022         * EWebLauncher/main.c:
1023         (nearest_zoom_level_get):
1024         (zoom_level_set):
1025         (on_load_finished):
1026         (on_key_down):
1027
1028 2010-11-21  Sam Weinig  <sam@webkit.org>
1029
1030         Rubber-stamped by Dan Bernstein.
1031
1032         Fix ~300 WebKit2 tests by enabling developer extras preference.
1033
1034         * WebKitTestRunner/TestController.cpp:
1035         (WTR::TestController::resetStateToConsistentValues):
1036
1037 2010-11-21  Sam Weinig  <sam@webkit.org>
1038
1039         Reviewed by Dan Bernstein.
1040
1041         Textareas should be resizable by default
1042         https://bugs.webkit.org/show_bug.cgi?id=49892
1043
1044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1045         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1046         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1047         Add preferences test.
1048
1049 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1050
1051         Reviewed by Tony Chang.
1052
1053         Rebaseline server: checksum-only differences and prefetching
1054         https://bugs.webkit.org/show_bug.cgi?id=49841
1055         
1056         Add support for image test results where the only difference is in the
1057         checksum.
1058         
1059         Add prefetching of the image results from the next test.
1060         
1061         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1062         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1063         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1064
1065 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1066
1067         Reviewed by Tony Chang.
1068
1069         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1070
1071         Add the 'worker number' and 'worker name' concepts to the 
1072         TestShellThread objects, and move test_types and test_args from
1073         the TestRunner to the TestShellThread.
1074
1075         https://bugs.webkit.org/show_bug.cgi?id=49768
1076
1077         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1079
1080 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1081
1082         Reviewed by Ojan Vafai.
1083
1084         Do some minor cleanup and bug fixing.
1085
1086         https://bugs.webkit.org/show_bug.cgi?id=49777
1087
1088         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1089         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1090
1091 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1092
1093         Reviewed by Ojan Vafai.
1094
1095         nrwt - config.build_directory() is busted
1096
1097         Fixes a typo that was causing us to usually return the top level
1098         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1099         bug was hidden by test stubs that were too simplistic :(.
1100
1101         https://bugs.webkit.org/show_bug.cgi?id=49815
1102
1103         * Scripts/webkitpy/common/system/executive_mock.py:
1104         * Scripts/webkitpy/layout_tests/port/config.py:
1105         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1106
1107 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1108
1109         Reviewed by Adam Roben.
1110
1111         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1112         https://bugs.webkit.org/show_bug.cgi?id=49819
1113
1114         * DumpRenderTree/DumpRenderTree.sln:
1115         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1116         * DumpRenderTree/win/DumpRenderTree.vcproj:
1117         * DumpRenderTree/win/ImageDiff.vcproj:
1118         * FindSafari/FindSafari.vcproj:
1119         * MiniBrowser/MiniBrowser.vcproj:
1120         * TestWebKitAPI/win/TestWebKitAPI.sln:
1121         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1122         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1123         * WebKitAPITest/WebKitAPITest.vcproj:
1124         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1125         * WebKitTestRunner/win/InjectedBundle.vcproj:
1126         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1127         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1128         * WinLauncher/WinLauncher.vcproj:
1129         * record-memory-win/record-memory-win.vcproj:
1130
1131 2010-11-19  Adam Roben  <aroben@apple.com>
1132
1133         Add some more Windows slaves
1134
1135         This is probably more than we will be using in the immediate future,
1136         but having some extra slave names makes experimenting with different
1137         configurations easier.
1138
1139         Reviewed by Jon Honeycutt.
1140
1141         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1142         Windows slaves and distributed them among the three different Test
1143         builders.
1144
1145 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1146
1147         Reviewed by Ojan Vafai.
1148
1149         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1150         https://bugs.webkit.org/show_bug.cgi?id=49702
1151
1152         Re-landing r72357 with a test fix.
1153
1154         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1155         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1156         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1157
1158 2010-11-19  Avi Drissman  <avi@google.com>
1159
1160         Reviewed by Antonio Gomes.
1161
1162         Complete support for Unix editing mode
1163         https://bugs.webkit.org/show_bug.cgi?id=49757
1164
1165         * DumpRenderTree/LayoutTestController.cpp:
1166         (setEditingBehaviorCallback):
1167         * DumpRenderTree/chromium/LayoutTestController.cpp:
1168         (LayoutTestController::setEditingBehavior):
1169
1170 2010-11-19  Adam Roben  <aroben@apple.com>
1171
1172         Fix run-javascriptcore-tests when there's a space in the path to
1173         testapi
1174
1175         Reviewed by Sam Weinig.
1176
1177         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1178         system() to force it to interpret spaces in the path correctly.
1179
1180 2010-11-19  Adam Roben  <aroben@apple.com>
1181
1182         Update scripts for .exe name changes after r72327
1183
1184         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1185
1186         Reviewed by Sam Weinig.
1187
1188         * Scripts/run-javascriptcore-tests:
1189         (testapiPath):
1190
1191         * Scripts/sunspider-compare-results:
1192         (pathToBuiltJSC):
1193
1194         * Scripts/webkitdirs.pm:
1195         (jscPath):
1196         (safariPath):
1197
1198 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1199
1200         Reviewed by Darin Adler.
1201
1202         Normalize Cairo/CFLite project/solution configuration names
1203         https://bugs.webkit.org/show_bug.cgi?id=49818
1204
1205         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1206         * DumpRenderTree/win/DumpRenderTree.vcproj:
1207         * DumpRenderTree/win/ImageDiff.vcproj:
1208         * MiniBrowser/MiniBrowser.vcproj:
1209         * TestWebKitAPI/win/TestWebKitAPI.sln:
1210         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1211         * WebKitAPITest/WebKitAPITest.vcproj:
1212         * WebKitTestRunner/win/InjectedBundle.vcproj:
1213         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1214         * WinLauncher/WinLauncher.vcproj:
1215         * Scripts/webkitdirs.pm: Updated cairo build configs.
1216
1217 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1218
1219         Reviewed by Adam Roben.
1220
1221         Windows vcproj configuration names should be normalized across projects
1222         https://bugs.webkit.org/show_bug.cgi?id=49776
1223
1224         * DumpRenderTree/DumpRenderTree.sln:
1225         * FindSafari/FindSafari.vcproj:
1226         * TestWebKitAPI/win/TestWebKitAPI.sln:
1227         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1228         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1229         * WebKitAPITest/WebKitAPITest.vcproj:
1230         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1231         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1232         * WebKitTestRunner/WebKitTestRunner.sln:
1233         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1234         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1235         * record-memory-win/record-memory-win.vcproj:
1236
1237 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1238
1239         Build fix - as per DRT-mac, always enabled developer extras,
1240         in win/qt/gtk DRT.
1241
1242         This is necessary to enable rich exception messages to be generated
1243         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1244
1245         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1246         (shouldEnableDeveloperExtras):
1247         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1248         (WebCore::shouldEnableDeveloperExtras):
1249         * DumpRenderTree/win/DumpRenderTree.cpp:
1250         (shouldEnableDeveloperExtras):
1251
1252 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1253
1254         Unreviewed, rolling out r72357.
1255         http://trac.webkit.org/changeset/72357
1256         https://bugs.webkit.org/show_bug.cgi?id=49784
1257
1258         It broke test-webkitpy tests since the patch didn't have the
1259         corresponding test update (Requested by kinuko on #webkit).
1260
1261         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1262         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1263
1264 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
1265
1266         Reviewed by Tony Chang.
1267
1268         Rebaseline server: add rebaseline queue
1269         https://bugs.webkit.org/show_bug.cgi?id=49763
1270         
1271         Add a UI queue (a multi-item <select>) where tests to be baselined
1272         can be enqueued (also supports basic removal). A queue is used instead
1273         of immediately doing rebaselines since SCM operations can take a while.
1274         It's better to go through lots of tests quickly to mark them as
1275         needing rebaselining and then batch the SCM operations.
1276         
1277         Also adds a simple log where results can be displayed.
1278
1279         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1280         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1281         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1282         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
1283         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1284         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1285
1286 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1287
1288         Reviewed by Oliver Hunt.
1289
1290         Bug 49708 - Stop recompiling functions to regenerate exception info.
1291
1292         Instead only hold info as necessary – keep divot info is the inspector
1293         is enabled, line number info is debugging or profiling, and handler
1294         info for functions with try/catch.
1295
1296         * DumpRenderTree/mac/DumpRenderTree.mm:
1297         (shouldEnableDeveloperExtras):
1298             - always enable the developer tools from DRT, to ensure we
1299               produce rich error messages on JavaScript exceptions.
1300
1301 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1302
1303         Reviewed by Ojan Vafai.
1304
1305         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1306         https://bugs.webkit.org/show_bug.cgi?id=49702
1307
1308         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1309         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1310
1311 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1312
1313         Reviewed by Tony Chang.
1314
1315         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1316
1317         Create the first version of the 'message_broker' package. This
1318         class will encapsulate all of the threading/multiprocessing and
1319         message-sending details for the communication between the
1320         'manager' object and the 'worker' objects. For the moment, it
1321         just holds some routines and tests for logging thread stacks.
1322
1323         There should be no functional changes in this patch, just moving stuff
1324         around.
1325
1326         https://bugs.webkit.org/show_bug.cgi?id=49707
1327
1328         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1329         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1330         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1331         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1332         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1333         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1334
1335 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1336
1337         Reviewed by Adam Roben.
1338
1339         Remove leftover Windows Debug_Internal configurations
1340         https://bugs.webkit.org/show_bug.cgi?id=49758
1341
1342         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1343         * DumpRenderTree/win/DumpRenderTree.vcproj:
1344         * DumpRenderTree/win/ImageDiff.vcproj:
1345         * MiniBrowser/MiniBrowser.vcproj:
1346         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1347         * WebKitAPITest/WebKitAPITest.vcproj:
1348         * WebKitTestRunner/win/InjectedBundle.vcproj:
1349         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1350         * WinLauncher/WinLauncher.vcproj:
1351
1352 2010-11-18  Adam Roben  <aroben@apple.com>
1353
1354         Add three new Windows XP build slaves
1355
1356         Reviewed by Steve Falkenburg.
1357
1358         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1359         new slaves, and added them to the Windows XP Debug (Tests) builder.
1360
1361 2010-11-18  Daniel Bates  <dbates@rim.com>
1362
1363         Reviewed by Adam Roben.
1364
1365         update-webkit-support-libs should fall back to existing
1366         WebKitSupportLibrary version if there is no internet connectivity
1367         https://bugs.webkit.org/show_bug.cgi?id=49503
1368
1369         Fall back to existing support libraries (if present) when there is
1370         no internet connection.
1371
1372         Currently, update-webkit-support-libs dies with an "out-of-date"
1373         error when there is no internet connection because it cannot
1374         retrieve versioning information from developer.apple.com. Because
1375         update-webkit-support-libs fails, build-webkit fails. Instead,
1376         if there is no internet connection and the support libraries are
1377         present then we should warn the user and exit() with success so
1378         that build-webkit can work without an internet connection.
1379
1380         * Scripts/update-webkit-support-libs:
1381
1382 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1383
1384         Reviewed by Adam Roben.
1385
1386         Debug_Internal Windows configuration is unnecessary, should be removed
1387         https://bugs.webkit.org/show_bug.cgi?id=49753
1388
1389         * DumpRenderTree/win/DumpRenderTree.cpp:
1390         * MiniBrowser/win/stdafx.h:
1391         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1392         * WebKitTestRunner/win/TestControllerWin.cpp:
1393
1394 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1395
1396         Reviewed by Adam Roben.
1397
1398         Clean up vcproj errors
1399         https://bugs.webkit.org/show_bug.cgi?id=49741
1400
1401         * MiniBrowser/MiniBrowser.vcproj:
1402         * WebKitAPITest/WebKitAPITest.vcproj:
1403         * WebKitTestRunner/win/InjectedBundle.vcproj:
1404         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1405
1406 2010-11-18  Hayato Ito  <hayato@chromium.org>
1407
1408         Reviewed by Shinichiro Hamaji.
1409
1410         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1411         which is caused by r72249.
1412
1413         https://bugs.webkit.org/show_bug.cgi?id=49751
1414
1415         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1416
1417 2010-11-18  Adam Roben  <aroben@apple.com>
1418
1419         Implement layoutTestController.waitForPolicyDelegate on Windows
1420
1421         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1422
1423         Reviewed by Simon Fraser.
1424
1425         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1426         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1427         code from LayoutTestControllerMac.mm.
1428
1429 2010-11-18  Hayato Ito  <hayato@chromium.org>
1430
1431         Reviewed by Shinichiro Hamaji.
1432
1433         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1434
1435         https://bugs.webkit.org/show_bug.cgi?id=49740
1436
1437         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1438
1439 2010-11-18  Tony Chang  <tony@chromium.org>
1440
1441         Reviewed by Adam Barth.
1442
1443         run platform/chromium/plugins/refcount-leaks.html on all platforms
1444         https://bugs.webkit.org/show_bug.cgi?id=49485
1445
1446         Add PluginObject.testObjectCount which returns the number of allocated
1447         TestObjects. Add PluginObject.testCreateTestObject which allocates
1448         and returns a TestObject.
1449
1450         Add TestObject.refCount which returns the number of refs on the
1451         TestObject.
1452
1453         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1454         (pluginGetProperty):
1455         (pluginInvoke):
1456         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1457         (getTestObjectCount):
1458         (testAllocate):
1459         (testDeallocate):
1460         (testGetProperty):
1461         (testScriptObjectInvoke): Release a ref to a plugin object that was
1462             previously leaked.
1463         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1464
1465 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1466
1467         Reviewed by Adam Roben.
1468
1469         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1470         https://bugs.webkit.org/show_bug.cgi?id=49711
1471
1472         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1473         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1474         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1475         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1476         * record-memory-win/record-memory-win-common.vsprops: Added.
1477         * record-memory-win/record-memory-win.vcproj:
1478
1479 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1480
1481         Reviewed by Csaba Osztrogonác.
1482
1483         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1484
1485         * MiniBrowser/qt/BrowserWindow.cpp:
1486         (BrowserWindow::updateUserAgentList):
1487
1488 2010-11-17  Adam Roben  <aroben@apple.com>
1489
1490         Don't trigger Windows builds when chromium-win test results change
1491
1492         Reviewed by Mark Rowe.
1493
1494         * Scripts/webkitpy/common/config/build.py:
1495         (_should_file_trigger_build): Changed the regular expression used to
1496         search for directory names to only consider full directory names,
1497         rather than matching directory names where the string we care about is
1498         a suffix of the name.
1499
1500         * Scripts/webkitpy/common/config/build_unittest.py:
1501         (ShouldBuildTest): Added a test.
1502
1503 2010-11-17  Hayato Ito  <hayato@chromium.org>
1504
1505         Reviewed by Shinichiro Hamaji.
1506
1507         Remove a uri member from TestInput class.
1508
1509         https://bugs.webkit.org/show_bug.cgi?id=49691
1510
1511         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1512         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1513
1514 2010-11-17  Adam Roben  <aroben@apple.com>
1515
1516         Move FindSafari's settings into a vsprops file
1517
1518         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1519
1520         Reviewed by Steve Falkenburg.
1521
1522         * FindSafari/FindSafari.vcproj:
1523         * FindSafari/FindSafariCommon.vsprops: Added.
1524
1525 2010-11-17  Adam Roben  <aroben@apple.com>
1526
1527         Use a minimum font size of 0 in DRT on Windows
1528
1529         This is the Windows equivalent of r72164.
1530
1531         Rubber-stamped by Dave Hyatt.
1532
1533         * DumpRenderTree/win/DumpRenderTree.cpp:
1534         (resetDefaultsToConsistentValues):
1535
1536 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1537
1538         Reviewed by Andreas Kling.
1539
1540         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1541         https://bugs.webkit.org/show_bug.cgi?id=49639
1542
1543         * Scripts/webkitpy/common/checkout/scm.py:
1544
1545 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1546
1547         Reviewed by Tony Chang.
1548
1549         Rebaseline server: add loupe for image diffs
1550         https://bugs.webkit.org/show_bug.cgi?id=49692
1551         
1552         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1553         enlarged area of the expected, actual and diff images side by side.
1554
1555         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1556         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1557         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1558         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1559
1560 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1561
1562         Reviewed by Adam Roben.
1563
1564         WebKitLauncherWin should use vsprops for shared build settings
1565         https://bugs.webkit.org/show_bug.cgi?id=49696
1566
1567         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1568         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1569
1570 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1571
1572         Reviewed by Adam Roben.
1573
1574         WinLauncher should use vsprops for shared build settings
1575         https://bugs.webkit.org/show_bug.cgi?id=49695
1576
1577         * WinLauncher/WinLauncher.cpp:
1578         (_tWinMain):
1579         (PrintView):
1580         (WndProc):
1581         (MyEditProc):
1582         * WinLauncher/WinLauncher.vcproj:
1583         * WinLauncher/WinLauncherCommon.vsprops: Added.
1584
1585 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1586
1587         Delete unused file unintentionally added in last change.
1588
1589         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1590
1591 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1592
1593         Reviewed by Adam Roben.
1594
1595         DumpRenderTree on Windows should use a vsprops file for shared project settings
1596         https://bugs.webkit.org/show_bug.cgi?id=49690
1597
1598         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1599         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1600         * DumpRenderTree/win/DumpRenderTree.vcproj:
1601         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1602         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1603         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1604         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1605         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1606         * DumpRenderTree/win/ImageDiff.vcproj:
1607         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1608
1609 2010-11-17  Hayato Ito  <hayato@chromium.org>
1610
1611         Refactor TestTypeBase.compare_output().
1612
1613         Introduce a TestOutput class and update compare_output() of each test
1614         types so that they can take both actual and expected TestOutput objects.
1615
1616         https://bugs.webkit.org/show_bug.cgi?id=49431
1617
1618         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1619         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1620         * Scripts/webkitpy/layout_tests/port/base.py:
1621         * Scripts/webkitpy/layout_tests/port/chromium.py:
1622         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1623         * Scripts/webkitpy/layout_tests/port/test.py:
1624         * Scripts/webkitpy/layout_tests/port/webkit.py:
1625         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1626         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1627         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1628         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1629
1630 2010-11-17  Adam Roben  <aroben@apple.com>
1631
1632         Make each Windows Test builder use the same OS for all its slaves
1633
1634         Currently each WebKit1 Windows Test builder has one Windows XP slave
1635         and one Windows 7 slave. Having different OSes in a single builder
1636         meant that the builders would alternate between red and green when
1637         there were OS-specific failures.
1638
1639         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1640         between red and green because of multiple OS versions
1641
1642         Reviewed by Mark Rowe.
1643
1644         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1645         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1646         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1647         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1648         builders for the two WebKit1 builders so that they would all use the
1649         appropriate OS.
1650
1651 2010-11-17  James Robinson  <jamesr@chromium.org>
1652
1653         Reviewed by Dan Bernstein.
1654
1655         [chromium] Set minimum font size to 0 for DRT
1656         https://bugs.webkit.org/show_bug.cgi?id=49677
1657
1658         Followup for http://trac.webkit.org/changeset/72141.
1659
1660         Test: http/tests/misc/acid3.html
1661
1662         * DumpRenderTree/chromium/WebPreferences.cpp:
1663         (WebPreferences::reset):
1664
1665 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1666
1667         Unreviewed build fix.
1668
1669         [Qt] Add missing file I forgot in r72220.
1670
1671         * MiniBrowser/MiniBrowser.qrc: Added.
1672
1673 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1674
1675         Reviewed by Andreas Kling.
1676
1677         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1678         https://bugs.webkit.org/show_bug.cgi?id=49627
1679
1680         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1681
1682         * MiniBrowser/MiniBrowser.qrc: Added.
1683         Add it here to prevent qmake from detecting it
1684         since it needs to be copied to the build directory.
1685         * MiniBrowser/qt/BrowserWindow.cpp:
1686         (BrowserWindow::BrowserWindow):
1687         (BrowserWindow::updateUserAgentList):
1688         (BrowserWindow::showUserAgentDialog):
1689         * MiniBrowser/qt/BrowserWindow.h:
1690         * MiniBrowser/qt/MiniBrowser.pro:
1691
1692 2010-11-17  Adam Roben  <aroben@apple.com>
1693
1694         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1695
1696         We use that file on Windows!
1697
1698         Fixes <http://webkit.org/b/49643> Changes to
1699         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1700
1701         Reviewed by Steve Falkenburg.
1702
1703         * Scripts/webkitpy/common/config/build.py:
1704         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1705         trigger builds on SnowLeopard and Windows.
1706
1707         * Scripts/webkitpy/common/config/build_unittest.py:
1708         (ShouldBuildTest.test_should_build): Added a test.
1709
1710 2010-11-17  Satish Sampath  <satish@chromium.org>
1711
1712         Reviewed by Jeremy Orlow.
1713
1714         Clear the speech input mock explicitly before each test.
1715         https://bugs.webkit.org/show_bug.cgi?id=49660
1716
1717         * DumpRenderTree/chromium/LayoutTestController.cpp:
1718         (LayoutTestController::setMockSpeechInputResult):
1719         * DumpRenderTree/chromium/LayoutTestController.h:
1720         * DumpRenderTree/chromium/WebViewHost.cpp:
1721         (WebViewHost::speechInputController):
1722         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1723         * DumpRenderTree/chromium/WebViewHost.h:
1724         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1725
1726 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1727
1728         Unreviewed, specify IRC nickname in committers.py.
1729
1730         * Scripts/webkitpy/common/config/committers.py:
1731
1732 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1733
1734         Reviewed by Tony Chang.
1735
1736         [NRWT] Make http locking similar to perl implementation
1737         https://bugs.webkit.org/show_bug.cgi?id=49187
1738
1739         * Scripts/webkitpy/common/system/file_lock.py: Added.
1740         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1741         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1742
1743 2010-11-17  MORITA Hajime  <morrita@google.com>
1744
1745         Reviewed by Kent Tamura.
1746
1747         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1748         https://bugs.webkit.org/show_bug.cgi?id=49366
1749
1750         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1751           according to the spellchecker suggestion
1752         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1753
1754         test_expectations.txt will be changed after this change is ported to test_shell.
1755         
1756         * DumpRenderTree/chromium/EventSender.cpp:
1757         (makeMenuItemStringsFor):
1758         (EventSender::contextClick):
1759         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1760         (MockSpellCheck::fillSuggestionList):
1761         (MockSpellCheck::initializeIfNeeded):
1762         * DumpRenderTree/chromium/MockSpellCheck.h:
1763         * DumpRenderTree/chromium/WebViewHost.cpp:
1764         (WebViewHost::mockSpellCheck):
1765         * DumpRenderTree/chromium/WebViewHost.h:
1766
1767 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1768
1769         Reviewed by Sam Weinig.
1770
1771         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1772         since the bots have 1 stuck in their plist otherwise.
1773
1774         * DumpRenderTree/mac/DumpRenderTree.mm:
1775         (resetDefaultsToConsistentValues):
1776
1777 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1778
1779         Reviewed by Tony Chang.
1780
1781         Rebaseline server: compute diffs client-side
1782         https://bugs.webkit.org/show_bug.cgi?id=49640
1783         
1784         The image diff output from the DRT is pretty bad on some ports (at
1785         least the Mac one), so it's better to compute diffs on the client by
1786         using <canvas>.
1787
1788         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1789         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1790         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1791
1792 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1793
1794         Reviewed by Tony Chang.
1795
1796         Rebaseline server: display test results
1797         https://bugs.webkit.org/show_bug.cgi?id=49626
1798         
1799         Adds basic result display to the rebaseline server. On the Python side
1800         this involves:
1801         - Parsing the unexpected_results.json into a dictionary.
1802         - Serving it as JSON under /results.json.
1803         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
1804         but I'll need to have access to the parsed results on the Python side
1805         for follow-up changes).
1806         
1807         On the web UI side this adds:
1808         - Markup for display image and text results (expected, actual, diff),
1809           and JS for populating it.
1810         - Markup for breaking down test results by failure type and directory,
1811           and JS for populating it.
1812
1813         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1814         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1815         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1816         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
1817         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1818
1819 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1820
1821         Reviewed by Ojan Vafai.
1822
1823         See Chromium issue http://codereview.chromium.org/5133001/ - we
1824         are modifying the build bots to pass in the builder name with
1825         the "GPU" string appended instead of appending it in the code.
1826
1827         https://bugs.webkit.org/show_bug.cgi?id=49636
1828
1829         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1830
1831 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
1832
1833         Reviewed by Adam Roben.
1834
1835         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
1836         https://bugs.webkit.org/show_bug.cgi?id=49632
1837
1838         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1839         * DumpRenderTree/win/DumpRenderTree.vcproj:
1840         * DumpRenderTree/win/ImageDiff.vcproj:
1841         * MiniBrowser/MiniBrowser.vcproj:
1842         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1843         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1844         * WebKitTestRunner/win/InjectedBundle.vcproj:
1845         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1846         * WinLauncher/WinLauncher.vcproj:
1847         * record-memory-win/record-memory-win.vcproj:
1848
1849 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1850
1851         Reviewed by Ojan Vafai.
1852
1853         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
1854
1855         Rename the TestInfo class to TestInput to be clearer about its
1856         function, and move the checksum-reading code into dump_render_tree_thread
1857         to avoid cross-thread access.
1858
1859         https://bugs.webkit.org/show_bug.cgi?id=49573
1860
1861         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1862         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1863         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1864
1865 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1866
1867         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
1868
1869         * DumpRenderTree/mac/DumpRenderTree.mm:
1870         (resetDefaultsToConsistentValues):
1871
1872 2010-11-16  Stephanie Lewis  <slewis@apple.com>
1873
1874         Reviewed by Geoff Garen.
1875
1876         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
1877
1878         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
1879         for every WebView, and the WebKit API doesn't support that ownership model.
1880
1881         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
1882
1883         * DumpRenderTree/mac/DumpRenderTree.mm:
1884         (createWebViewAndOffscreenWindow):
1885         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1886         (LayoutTestController::setMockDeviceOrientation):
1887
1888 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1889
1890         Reviewed by Ojan Vafai.
1891
1892         new-run-webkit-tests: log the process id in --verbose mode
1893
1894         As part of the switch to multi-process mode, we should log the
1895         process id when running w/ --verbose.
1896
1897         https://bugs.webkit.org/show_bug.cgi?id=49571
1898
1899         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1900
1901 2010-11-16  Adam Roben  <aroben@apple.com>
1902
1903         Only trigger Windows builds when files that we actually use on Windows
1904         are changed
1905
1906         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
1907         It uses the new webkitpy.common.config.build module to determine
1908         whether a particular change should trigger a build on a particular
1909         platform. The Windows builders have been switched to use a
1910         PlatformSpecificScheduler.
1911
1912         The logic to determine whether or not a particular change should
1913         trigger a build on a given platform has only been implemented/tested
1914         for Windows. I tried to make it easy to add more platforms in the
1915         future, but I don't have enough familiarity with all platforms to be
1916         able to implement it for them.
1917
1918         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
1919         lots irrelevant changes (e.g., rebaselining Chromium test results)
1920
1921         Reviewed by Eric Seidel.
1922
1923         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
1924         PlatformSpecificScheduler for the Windows builders.
1925
1926         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1927         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
1928         up a ChangeFilter that filters to our branch and will call through to
1929         our filter method, and calls up to our base class.
1930         (PlatformSpecificScheduler.filter): Calls through to
1931         build.should_build to find out whether we should trigger a build for
1932         this change.
1933
1934         * Scripts/webkitpy/common/net/build.py: Added.
1935         (_should_file_trigger_build): Uses a set of directories and regexp
1936         patterns to determine whether the given file should trigger a build on
1937         the given platform. As mentioned earlier, this has only been
1938         implemented for Windows, though I did try to make some guesses about
1939         other platforms.
1940         (should_build): Returns true if any of the files should trigger a
1941         build on the given platform.
1942
1943         * Scripts/webkitpy/common/net/build_unittest.py: Added.
1944         (ShouldBuildTest.test_should_build): Does some basic testing to make
1945         sure we're triggering builds for the right files. It only tests
1946         Windows for now, though I tried to make some guesses about other
1947         platforms.
1948
1949 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1950
1951         Reviewed by Andreas Kling.
1952
1953         [Qt] Remove synchronous QWebPage::checkPermissions signal
1954         https://bugs.webkit.org/show_bug.cgi?id=46810
1955
1956         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1957         (WebCore::WebPage::WebPage):
1958         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1959         (LayoutTestController::grantDesktopNotificationPermission): When granting
1960         permission, grant it directly on the QWebPage/Frame, that will remember it.
1961         * QtTestBrowser/webpage.cpp:
1962         (WebPage::WebPage):
1963         * QtTestBrowser/webpage.h:
1964
1965
1966 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
1967
1968         Reviewed by Csaba Osztrogonác.
1969
1970         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
1971
1972         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1973         (LayoutTestController::reset):
1974         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1975         (LayoutTestController::isPrinting):
1976         (LayoutTestController::setPrinting):
1977
1978 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
1979
1980         Reviewed by Andreas Kling.
1981
1982         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
1983         https://bugs.webkit.org/show_bug.cgi?id=49587
1984
1985         * MiniBrowser/qt/BrowserView.cpp:
1986         (BrowserView::BrowserView): Added BackingStoreType
1987         argument to ctor. Propagating it to the QGraphicsWKView.
1988         * MiniBrowser/qt/BrowserView.h:
1989         * MiniBrowser/qt/BrowserWindow.cpp:
1990         (BrowserWindow::BrowserWindow):
1991         (BrowserWindow::newWindow): Create the new BrowserWindow
1992         with the same BackingStoreType that this instance has.
1993         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
1994         * MiniBrowser/qt/main.cpp:
1995         (main): Use tiled backing store if got -tiled command line argument.
1996         Avoid redundant copy of command line args.
1997
1998 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
1999
2000         Reviewed by Jeremy Orlow.
2001
2002         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2003         https://bugs.webkit.org/show_bug.cgi?id=48506
2004
2005         This ensures that there is one mock per page WebView / WebViewHost. This is a
2006         design constraint of the DeviceOrientationClientMock because the m_controller
2007         field can only store a pointer to a single instance of the corresponding
2008         DeviceOrientationController.
2009
2010         Test: fast/dom/DeviceOrientation/no-page-cache.html
2011
2012         * DumpRenderTree/chromium/LayoutTestController.cpp:
2013         (LayoutTestController::setMockDeviceOrientation):
2014         (LayoutTestController::deviceOrientationClientMock):
2015         * DumpRenderTree/chromium/LayoutTestController.h:
2016         * DumpRenderTree/chromium/WebViewHost.cpp:
2017         (WebViewHost::deviceOrientationClientMock):
2018         (WebViewHost::deviceOrientationClient):
2019         (WebViewHost::reset):
2020         * DumpRenderTree/chromium/WebViewHost.h:
2021
2022 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2023
2024         Reviewed by Andreas Kling.
2025
2026         [Qt][WK2] Avoid polling in WebKitTestRunner.
2027         https://bugs.webkit.org/show_bug.cgi?id=49542
2028
2029         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2030         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2031
2032         * WebKitTestRunner/TestController.cpp:
2033         (WTR::TestController::didFinishLoadForFrame):
2034         * WebKitTestRunner/TestController.h:
2035         * WebKitTestRunner/TestInvocation.cpp:
2036         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2037         * WebKitTestRunner/mac/TestControllerMac.mm:
2038         (WTR::TestController::notifyDone): Add method stub.
2039         * WebKitTestRunner/qt/TestControllerQt.cpp:
2040         (WTR::TestControllerRunLoop::instance):
2041         (WTR::TestControllerRunLoop::start):
2042         (WTR::TestControllerRunLoop::stop):
2043         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2044         (WTR::TestControllerRunLoop::timerEvent):
2045         (WTR::TestController::notifyDone):
2046         (WTR::TestController::platformRunUntil):
2047         * WebKitTestRunner/win/TestControllerWin.cpp:
2048         (WTR::TestController::notifyDone): Add method stub.
2049
2050 2010-11-15  Darin Adler  <darin@apple.com>
2051
2052         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2053
2054 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2055
2056         Reviewed by Andreas Kling.
2057
2058         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2059         https://bugs.webkit.org/show_bug.cgi?id=49544
2060
2061         Add the shortcut to BrowserWindow.
2062
2063         * MiniBrowser/qt/BrowserWindow.cpp:
2064         (BrowserWindow::BrowserWindow):
2065         (BrowserWindow::openLocation):
2066         * MiniBrowser/qt/BrowserWindow.h:
2067
2068 2010-11-14  David Levin  <levin@chromium.org>
2069
2070         Reviewed by Daniel Bates.
2071
2072         check-webkit-style should detect PassRefPtr usage in functions.
2073         https://bugs.webkit.org/show_bug.cgi?id=49513
2074
2075         * Scripts/webkitpy/style/checkers/cpp.py:
2076         (check_for_function_lengths): Revert a comment change that I
2077          accidentally made in r71986.
2078         (check_pass_ptr_usage): Added the code to do the check.
2079         (process_line): Added the call to check_pass_ptr_usage.
2080         (CppChecker): Added the new error category.
2081         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2082         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2083          testing purposes.
2084         (PassPtrTest::*): The class/functions to unit test the new
2085          functionality.
2086
2087 2010-11-14  David Levin  <levin@chromium.org>
2088
2089         Reviewed by Shinichiro Hamaji.
2090
2091         check-webkit-style function detection and the line count style checks should be separate.
2092         https://bugs.webkit.org/show_bug.cgi?id=49512
2093
2094         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2095         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2096           call the detection function and fix line counts in two places now that
2097           the code really only counts the lines in the body of the function.
2098
2099 2010-11-14  Andreas Kling  <kling@webkit.org>
2100
2101         Reviewed by Antonio Gomes.
2102
2103         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2104         https://bugs.webkit.org/show_bug.cgi?id=33438
2105
2106         Stifle "Unhandled variable" warning to match what the other
2107         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2108         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2109
2110         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2111         (webkit_test_plugin_get_value):
2112
2113 2010-11-13  David Levin  <levin@chromium.org>
2114
2115         Reviewed by Eric Seidel.
2116
2117         check-webkit-style function detection crashes on functions in templates.
2118         https://bugs.webkit.org/show_bug.cgi?id=49504
2119
2120         For example "template <bool shouldClose(const Element*)>".
2121
2122         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2123         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2124           function detection test to expose this issue.
2125
2126 2010-11-12  David Levin  <levin@chromium.org>
2127
2128         Reviewed by Shinichiro Hamaji.
2129
2130         check-webkit-style function detection doesn't detect indented functions declaractions.
2131         https://bugs.webkit.org/show_bug.cgi?id=49446
2132
2133         Indented function declarations occur inside class definitions, so
2134         they are a pretty common (and worth detecting).
2135
2136         * Scripts/webkitpy/style/checkers/cpp.py:
2137           Changed regex to allow indentation.
2138           Changed the function start detection to only happen when not in a
2139           function.
2140           Changed function end detection to work based on matching braces
2141           instead of finding a close brace at the beginning of the line.
2142           Fixed close_expression to do what it says when it doesn't find
2143           the close.
2144         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2145
2146 2010-11-12  Daniel Bates  <dbates@rim.com>
2147
2148         Rubber-stamped by Nikolas Zimmermann.
2149
2150         Make do-file-rename rename files in the directory WebKit2.
2151
2152         This also makes the list of searched directories in do-file-rename
2153         consistent with the list of searched directories in the script do-webcore-rename.
2154
2155         * Scripts/do-file-rename:
2156
2157 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2158
2159         Reviewed by James Robinson.
2160
2161         Attempt yet again to land the fix for bug 49360 (respecting
2162         set-webkit-configuration). We need to handle the cases where
2163         trying to run webkit-build-directory to find out where the
2164         default configuration might be fails (that shows up on some
2165         Chromium bots that apparently don't have perl installed).
2166
2167         https://bugs.webkit.org/show_bug.cgi?id=49360
2168
2169         * Scripts/webkitpy/layout_tests/port/config.py:
2170         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2171         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2172
2173 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2174
2175         Reviewed by Adam Barth.
2176
2177         webkit-patch land logs commit message twice
2178         https://bugs.webkit.org/show_bug.cgi?id=49482
2179         
2180         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2181         that's just the commit message, which we now output following the
2182         actual commit.
2183
2184         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2185
2186 2010-11-12  Tony Chang  <tony@chromium.org>
2187
2188         Reviewed by Adam Barth.
2189
2190         run platform/chromium/plugins/script-object-invoke.html on all platforms
2191         https://bugs.webkit.org/show_bug.cgi?id=49280
2192
2193         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2194         (testScriptObjectInvoke):
2195         (pluginInvoke):
2196
2197 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2198
2199         Reviewed by Adam Barth.
2200
2201         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2202         https://bugs.webkit.org/show_bug.cgi?id=49471
2203
2204         Right now there's no indication of a successful commit.
2205         
2206         * Scripts/webkitpy/tool/commands/download_unittest.py:
2207         * Scripts/webkitpy/tool/steps/commit.py:
2208
2209 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2210
2211         Reviewed by Ojan Vafai.
2212
2213         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2214         https://bugs.webkit.org/show_bug.cgi?id=49354
2215
2216         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2217
2218         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2219         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2220         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2221         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2222
2223 2010-11-12  Tony Chang  <tony@chromium.org>
2224
2225         Reviewed by Kent Tamura.
2226
2227         [chromium] Load a blank page when closing DRT WebViewHosts
2228         https://bugs.webkit.org/show_bug.cgi?id=49417
2229
2230         In test_shell, when we close a window, we first load about:blank
2231         and run GC to fire the destruction logic of the page.  In test_shell,
2232         this happens in ~TestShell.  In DRT, we manage virtual windows as
2233         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2234
2235         Managing focus is a bit trickier, since normally you would get window
2236         events to reset the focus to the right window.  We do it manually
2237         instead.
2238
2239         This fixes 2 plugin tests on DRT.
2240
2241         * DumpRenderTree/chromium/TestShell.cpp:
2242         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2243         (TestShell::closeWindow): Move widget close() to WVH destructor and
2244             manage focus manually.
2245         (TestShell::closeRemainingWindows): Comment typo.
2246         * DumpRenderTree/chromium/WebViewHost.cpp:
2247         (WebViewHost::closeWidget):
2248         (invokeCloseWidget):
2249         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2250             test_shell).
2251         (WebViewHost::~WebViewHost):
2252         * DumpRenderTree/chromium/WebViewHost.h:
2253
2254 2010-11-12  David Levin  <levin@chromium.org>
2255
2256         Reviewed by Adam Barth.
2257
2258         cpp.py needs some tidying.
2259         https://bugs.webkit.org/show_bug.cgi?id=49443
2260
2261         * Scripts/webkitpy/style/checkers/cpp.py:
2262           Fix parameter ordering for iteratively_replace_matches_with_char
2263           to mirror other similar functions (and improved comments, etc.)
2264           Also, use a python-ism (for/else) to get rid of a variable that
2265           was there to determine if something had been found in the loop.
2266
2267 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
2268
2269         Reviewed by James Robinson.
2270
2271         [Chromium/DRT] Make EventSendingController send complete touch events.
2272         https://bugs.webkit.org/show_bug.cgi?id=49285
2273
2274         * DumpRenderTree/chromium/EventSender.cpp:
2275         (EventSender::addTouchPoint):
2276         (EventSender::updateTouchPoint):
2277         (EventSender::sendCurrentTouchEvent):
2278
2279 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2280
2281         Unreviewed rollout of r71858.
2282
2283         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
2284         NaCl tests.
2285
2286         * Scripts/webkitpy/layout_tests/port/config.py:
2287         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
2288         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2289
2290 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
2291
2292         Reviewed by Kenneth Rohde Christiansen.
2293
2294         [Qt] TestController::runUntil doesn't honor the timeout parameter
2295         https://bugs.webkit.org/show_bug.cgi?id=48941
2296
2297         Implement the missing timeout of WebKitTestRunner for Qt.
2298
2299         A QElapsedTimer has been added to RunUntilConditionLoop in order
2300         to measure how long the loop has been running. When the timer
2301         is bigger or equal than the timeout, the loop ends even if the
2302         condition is not met.
2303
2304         * WebKitTestRunner/qt/TestControllerQt.cpp:
2305         (WTR::RunUntilConditionLoop::start):
2306         (WTR::RunUntilConditionLoop::run):
2307         (WTR::RunUntilConditionLoop::timerEvent):
2308         (WTR::TestController::platformRunUntil):
2309
2310 2010-11-11  David Levin  <levin@chromium.org>
2311
2312         Reviewed by Shinichiro Hamaji.
2313
2314         check-webkit-style function detection doesn't handle templates with spaces.
2315         https://bugs.webkit.org/show_bug.cgi?id=49427
2316
2317         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2318           finding the function name.
2319         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2320           template with a space.
2321
2322 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2323
2324         Reviewed by Shinichiro Hamaji.
2325
2326         Enable check-webkit-style on Qt files
2327         https://bugs.webkit.org/show_bug.cgi?id=48322
2328
2329         Adding exception for _q_... private slots and
2330         ..._data() methods in tests
2331
2332         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2333         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2334
2335 2010-11-11  David Levin  <levin@chromium.org>
2336
2337         Reviewed by Shinichiro Hamaji.
2338
2339         check-webkit-style function detection doesn't work for templates and destructors.
2340         https://bugs.webkit.org/show_bug.cgi?id=49425
2341
2342         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2343         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2344
2345 2010-11-11  Joone Hur  <joone@kldp.org>
2346
2347         Reviewed by Antonio Gomes.
2348
2349         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2350         https://bugs.webkit.org/show_bug.cgi?id=46598
2351
2352         Support nodesFromRect in DRT
2353
2354         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2355         (LayoutTestController::nodesFromRect):
2356
2357 2010-11-11  MORITA Hajime  <morrita@google.com>
2358
2359         Reviewed by Kent Tamura.
2360
2361         editing/selection/context-menu-on-text.html fails on chromium
2362         https://bugs.webkit.org/show_bug.cgi?id=45898
2363
2364         Enhance Chromium's EventSender::contextClick() to return
2365         array of menu strings. The implementation incomplete because
2366         Although actual context menu is implemented by the browser,
2367         it reflects editability of underlying context thus makes
2368         context-menu-on-text.html passed.
2369         
2370         * DumpRenderTree/chromium/EventSender.cpp:
2371         (makeMenuItemStringsFor): Added.
2372         (EventSender::contextClick): Now returns array of menu strings.
2373         * DumpRenderTree/chromium/WebViewHost.cpp:
2374         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2375         (WebViewHost::clearContextMenuData): Added.
2376         (WebViewHost::lastContextMenuData): Added.
2377         * DumpRenderTree/chromium/WebViewHost.h:
2378
2379 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2380
2381         Unreviewed, build fix.
2382
2383         fix build breakage caused by fix for bug 49380 (r71858).
2384
2385         config_standalone needs to ensure that the packages it needs are
2386         in sys.path.
2387
2388         https://bugs.webkit.org/show_bug.cgi?id=49419
2389
2390         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2391
2392 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2393
2394         Reviewed by Adam Roben.
2395
2396         Fix NRWT to respect set-webkit-configuration again :(
2397
2398         This change fixes a typo in config.py that was causing the wrong
2399         value to be read initially and us never actually looking into
2400         the filesystem to get the default configuration.
2401         
2402         * Scripts/webkitpy/layout_tests/port/config.py:
2403         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2404         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2405
2406 2010-11-11  Eric Seidel  <eric@webkit.org>
2407
2408         Reviewed by Adam Barth.
2409
2410         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2411         https://bugs.webkit.org/show_bug.cgi?id=49403
2412
2413         CommitterValidator really had nothing to do with bugzilla.py.
2414         I've put it next to committers.py for now since its rather tied to that file.
2415
2416         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2417         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2418         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2419         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2420         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2421         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2422         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2423         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2424         * Scripts/webkitpy/tool/bot/feeders.py:
2425         * Scripts/webkitpy/tool/commands/queues.py:
2426
2427 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2428
2429         Reviewed by Eric Seidel.
2430
2431         fix missing 'pid' argument for http lockfile checking on win32
2432         https://bugs.webkit.org/show_bug.cgi?id=49363
2433
2434         * Scripts/webkitpy/common/system/executive.py:
2435
2436 2010-11-11  Eric Seidel  <eric@webkit.org>
2437
2438         Rubber-stamped by Adam Barth.
2439
2440         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2441         https://bugs.webkit.org/show_bug.cgi?id=49402
2442
2443         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2444         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2445         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2446
2447 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2448
2449         Reviewed by Chris Fleizach.
2450
2451         Use IAccessibleComparable to compare accessibility objects.
2452         https://bugs.webkit.org/show_bug.cgi?id=49118
2453
2454         * DumpRenderTree/AccessibilityUIElement.cpp:
2455         (AccessibilityUIElement::isEqual):
2456         * DumpRenderTree/AccessibilityUIElement.h:
2457         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2458         (comparableObject):
2459         (AccessibilityUIElement::isEqual):
2460
2461 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2462
2463         Reviewed by David Hyatt.
2464
2465         HTML5 Ruby support should be mandatory feature
2466         https://bugs.webkit.org/show_bug.cgi?id=49272
2467
2468         Remove Ruby as optional feature.
2469
2470         * Scripts/build-webkit:
2471
2472 2010-11-10  Adam Roben  <aroben@apple.com>
2473
2474         Print VC++ Express build logs in the same order that the projects are
2475         built
2476
2477         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2478         in an unhelpful order
2479
2480         Reviewed by Eric Seidel.
2481
2482         * Scripts/print-vse-failure-logs:
2483         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2484         print-msvc-project-dependencies to figure out the order in which
2485         projects are built.
2486         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2487         based on their build order and project name.
2488         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2489         scripts directory from here...
2490         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2491         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2492         them.
2493
2494 2010-11-10  Adam Roben  <aroben@apple.com>
2495
2496         Only print the interesting text from VC++ Express build logs
2497
2498         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2499         output from print-vse-failure-logs
2500
2501         Reviewed by Eric Seidel.
2502
2503         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2504         added newly-required imports. Removed a comment that was essentially a
2505         FIXME, and is now fixed.
2506         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2507         BeautifulSoup to extract the relevant text from the build log.
2508         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2509
2510 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2511
2512         Reviewed by Tony Chang.
2513
2514         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2515         https://bugs.webkit.org/show_bug.cgi?id=49286
2516         
2517         The tests in http/tests/security/XFrameOptions started to fail after
2518         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2519         logic to always assign identifiers to requests, even if we're not going
2520         to be dumping resource load callbacks at that point. These tests
2521         only call LayoutTestController.dumpResourceLoadCallbacks after the
2522         request is started, thus their expectations have "<unknown>" as the
2523         identifier. Change WebViewHost to the previous behavior, which also
2524         match the other ports'.
2525
2526         * DumpRenderTree/chromium/WebViewHost.cpp:
2527         (WebViewHost::assignIdentifierToRequest):
2528         (WebViewHost::removeIdentifierForRequest):
2529
2530 2010-11-08  Tony Chang  <tony@chromium.org>
2531
2532         Reviewed by Adam Barth.
2533
2534         run platform/chromium/plugins/return-npobject.html on all platforms
2535         https://bugs.webkit.org/show_bug.cgi?id=49103
2536
2537         This tests that we can get an NPObject returned through a method on
2538         an NPAPI Object.
2539
2540         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2541         (testCallbackReturn):
2542         (pluginInvoke):
2543
2544 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2545
2546         Unreviewed, rolling out r71672.
2547         http://trac.webkit.org/changeset/71672
2548         https://bugs.webkit.org/show_bug.cgi?id=49276
2549
2550         It doesn't work on Chromium Windows bot (Requested by Ossy on
2551         #webkit).
2552
2553         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2554         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2555         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2556
2557 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2558
2559         Reviewed by Tony Chang.
2560
2561         [NRWT] Make http locking similar to perl implementation
2562         https://bugs.webkit.org/show_bug.cgi?id=49187
2563
2564         * Scripts/webkitpy/common/system/file_lock.py: Added.
2565         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2566         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2567
2568 2010-11-09  James Kozianski  <koz@chromium.org>
2569
2570         Reviewed by Eric Seidel.
2571
2572         Clean up imports for webkit-patch.
2573         https://bugs.webkit.org/show_bug.cgi?id=49083
2574
2575         Move some imports from commands into main.py where they are used.
2576         Move command imports into the __init__ of the commands module.
2577
2578         * Scripts/webkitpy/tool/commands/__init__.py:
2579         * Scripts/webkitpy/tool/commands/download.py:
2580         * Scripts/webkitpy/tool/commands/queues.py:
2581         * Scripts/webkitpy/tool/main.py:
2582
2583 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2584
2585         Reviewed by Andreas Kling.
2586
2587         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2588         https://bugs.webkit.org/show_bug.cgi?id=49047
2589
2590         * QtTestBrowser/mainwindow.cpp:
2591         (MainWindow::setAddressUrl):
2592
2593 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2594
2595         Reviewed by Csaba Osztrogonác.
2596
2597         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2598         https://bugs.webkit.org/show_bug.cgi?id=49252
2599
2600         * Scripts/old-run-webkit-tests:
2601
2602 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2603
2604         Reviewed by Tor Arne Vestbø.
2605
2606         Output of old-run-webkit-tests is buggy in verbose mode
2607         https://bugs.webkit.org/show_bug.cgi?id=49249
2608
2609         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2610
2611 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2612
2613         Reviewed by Martin Robinson.
2614
2615         [GTK] Link with target name set does not work
2616         https://bugs.webkit.org/show_bug.cgi?id=48865
2617
2618         When a new page is created with a name (target=myFrame), the new
2619         mainFrame could not be found because they where not stored in the
2620         same PageGroup. As PageGroup are not exposed externally so the
2621         simpliest solution is to use a global page group name. This also fixes
2622         issue with visited link coloration across pages. After this change the
2623         private function webkit_web_view_set_group_name() was no longer used
2624         so it was removed completly.
2625
2626         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2627         (createWebView):
2628
2629 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2630
2631         Reviewed by Kent Tamura.
2632
2633         WebViewHost::reset() uses placement new.
2634         https://bugs.webkit.org/show_bug.cgi?id=49069
2635
2636         WebViewHost is using placement destruction / new to simulate a fresh
2637         WebViewHost object at the same address. This is because the WebView remains
2638         open across tests and maintains a pointer to the WebViewHost.
2639         This change resets member variables explictly instead of the placement new dance.
2640
2641         * DumpRenderTree/chromium/WebViewHost.cpp:
2642         (WebViewHost::WebViewHost):
2643         (WebViewHost::reset):
2644
2645 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2646
2647         Reviewed by Eric Seidel.
2648
2649         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
2650         It turns out that NRWT can't use the code in scm.find_checkout_root()
2651         because the Chromium bots don't do full checkouts of the WebKit
2652         tree; they only check out subdirectories like WebKitTools/Scripts.
2653         Until we can figure out a better approach for this, I've
2654         restored the base_dir-detecting code from NRWT, which works in
2655         any directory tree, scm or no.
2656
2657         This also restores the files modified in r71475 and r71474.
2658
2659         https://bugs.webkit.org/show_bug.cgi?id=49151
2660
2661         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2662         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2663
2664 2010-11-08  Eric Seidel  <eric@webkit.org>
2665
2666         Reviewed by Adam Barth.
2667
2668         webkit-patch failure-reason explodes if a build is missing
2669         https://bugs.webkit.org/show_bug.cgi?id=49195
2670
2671         This is likely a recent regression.  Adding a unit test for this case.
2672
2673         * Scripts/webkitpy/common/net/buildbot.py:
2674         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2675
2676 2010-11-08  Dan Bernstein  <mitz@apple.com>
2677
2678         Reviewed by Darin Adler.
2679
2680         Ignore the system scrollbar setting.
2681
2682         * DumpRenderTree/mac/DumpRenderTree.mm:
2683         (resetDefaultsToConsistentValues): Set the scrollbar default.
2684
2685 2010-11-05  Adam Roben  <aroben@apple.com>
2686
2687         Make webkitpy.common.system.executive_unittest pass when running under
2688         Win32 Python
2689
2690         Fixes <http://webkit.org/b/49033>.
2691
2692         Reviewed by Dave Levin and Eric Seidel.
2693
2694         * Scripts/webkitpy/common/system/executive.py:
2695         (Executive._run_command_with_teed_output): Pass the arguments through
2696         encode_argument_if_needed rather than using Cygwin-specific code here.
2697         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2698         the output.
2699         (Executive.run_command): Use encode_argument_if_needed to encode the
2700         arguments and child_process_encoding to decode the output.
2701         (Executive._child_process_encoding): Returns the encoding that should be
2702         used when communicating with child processes. On Windows we use mbcs,
2703         which maps to the current code page. On all other platforms we use
2704         UTF-8.
2705         (Executive._should_encode_child_process_arguments): Returns True if
2706         arguments to child processes need to be encoded. This is currently
2707         only needed on Cygwin and Win32 Python 2.x.
2708         (Executive._encode_argument_if_needed): Encode the argument using
2709         child_process_encoding if we need to encode arguments to child
2710         processes on this platform.
2711
2712         * Scripts/webkitpy/common/system/executive_unittest.py:
2713         (never_ending_command): Added. Returns arguments to run a command that
2714         will not quit until we kill it. On Windows we use wmic, on other
2715         platforms we use yes.
2716         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2717         mbcs encoding to be used and for output from the child processes to
2718         have been roundtripped through encode/decode on Win32 Python. When
2719         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2720         it's possible that some characters will not be able to be converted
2721         and will be replaced by question marks; the round-tripping allows us
2722         to expect this result.
2723
2724         (ExecutiveTest.test_kill_process):
2725         (ExecutiveTest.test_kill_all):
2726         Use never_ending_command instead of invoking "yes" directly. Expect an
2727         exit code of 1 when using Win32 Python, as that's what seems to happen.
2728
2729 2010-11-08  Adam Roben  <aroben@apple.com>
2730
2731         Roll out r71532
2732
2733         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2734         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2735
2736         * Scripts/webkitdirs.pm:
2737
2738 2010-11-08  Tony Chang  <tony@chromium.org>
2739
2740         Reviewed by Adam Barth.
2741
2742         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2743         https://bugs.webkit.org/show_bug.cgi?id=49094
2744
2745         This tests that objects created by plugins are proplery cleaned up.
2746
2747         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2748         (testPassTestObject):
2749         (pluginInvoke):
2750         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2751         (testAllocate):
2752         (testDeallocate):
2753         (testGetProperty):
2754         (testConstruct):
2755
2756 2010-11-08  Adam Roben  <aroben@apple.com>
2757
2758         Mark Windows builds triggered from Perl as being non-interactive
2759
2760         This affects whether some of our scripts will show alerts vs. printing
2761         to the build log.
2762
2763         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2764         .vsprops files are updated
2765
2766         Reviewed by Steve Falkenburg.
2767
2768         * Scripts/webkitdirs.pm:
2769         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2770
2771 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2772
2773         Reviewed by Ojan Vafai.
2774
2775         Make http locking default in NRWT.
2776         https://bugs.webkit.org/show_bug.cgi?id=48053
2777
2778         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2779         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2780
2781 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2782
2783         Reviewed by Csaba Osztrogonác.
2784
2785         [NRWT] If the http lock fails we shouldn't do any locking
2786         https://bugs.webkit.org/show_bug.cgi?id=49164
2787
2788         If something goes wrong with the locking, the test should keep going.
2789
2790         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2791
2792 2010-11-08  Adam Roben  <aroben@apple.com>
2793
2794         Switch back to using kCGImageAlphaPremultipliedFirst when generating
2795         pixel dumps on Windows
2796
2797         I changed this behavior in r71418 thinking that it was required for
2798         getting plugins to show up in pixel dumps. But it doesn't seem to be
2799         necessary, and was making it impossible to compare new Windows pixel
2800         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
2801         compare an image with alpha to an image without alpha).
2802
2803         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
2804         new Windows pixel results to existing Windows or Mac results
2805
2806         Reviewed by Antti Koivisto.
2807
2808         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2809         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
2810         with kCGImageAlphaPremultipliedFirst.
2811
2812 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
2813
2814         Unreviewed, rolling out r71466.
2815         http://trac.webkit.org/changeset/71466
2816         https://bugs.webkit.org/show_bug.cgi?id=48865
2817
2818         It broke layout tests on GTK bots.
2819
2820         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2821         (createWebView):
2822
2823 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2824
2825         Reviewed by Csaba Osztrogonác.
2826
2827         Enable running of Qt API tests on BuildBot
2828         https://bugs.webkit.org/show_bug.cgi?id=49004
2829
2830         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2831
2832 2010-11-08  Eric Seidel  <eric@webkit.org>
2833
2834         Reviewed by Adam Barth.
2835
2836         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
2837         https://bugs.webkit.org/show_bug.cgi?id=49160
2838
2839         Bugzilla doesn't automatically remove r? when a bug gets closed.
2840         This script takes care of that for webkit.org.
2841
2842         * Scripts/webkitpy/common/net/bugzilla.py:
2843         * Scripts/webkitpy/tool/commands/upload.py:
2844
2845 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2846
2847         Unreviewed, rolling out r71474.
2848         http://trac.webkit.org/changeset/71474
2849         https://bugs.webkit.org/show_bug.cgi?id=48280
2850
2851         breaks chromium webkit tests
2852         https://bugs.webkit.org/show_bug.cgi?id=49151
2853
2854         * Scripts/webkitpy/layout_tests/port/base.py:
2855         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2856         * Scripts/webkitpy/layout_tests/port/config.py:
2857         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2858         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2859         * Scripts/webkitpy/layout_tests/port/webkit.py:
2860         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2861         * Scripts/webkitpy/tool/mocktool.py:
2862
2863 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2864
2865         Unreviewed, rolling out r71475.
2866         http://trac.webkit.org/changeset/71475
2867  
2868         breaks chromium webkit tests
2869         https://bugs.webkit.org/show_bug.cgi?id=49151
2870
2871         * Scripts/webkitpy/common/newstringio.py: Removed.
2872         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
2873         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
2874         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
2875         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
2876
2877 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2878
2879         Unreviewed, build fix.
2880
2881         Add files inexplicably not committed in r71474 as part of the
2882         fix for bug 48280.
2883
2884         * Scripts/webkitpy/common/newstringio.py: Added.
2885         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2886         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2887         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2888         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
2889
2890 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2891
2892         Reviewed by Eric Siedel.
2893
2894         new-run-webkit-tests: update port/base and port/webkit to use the
2895         new FileSystem and Config abstractions, pulling more logic out of
2896         the base Port classes into separate, mockable objects.
2897
2898         Also create a MockFileSystem object, a MockConfig object, move
2899         MockExecutive into common/system to be next to executive, and
2900         update the config object to use a FileSystem.
2901
2902         https://bugs.webkit.org/show_bug.cgi?id=48280
2903
2904         * Scripts/webkitpy/common/newstringio.py: Added.
2905         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2906         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2907         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2908         * Scripts/webkitpy/layout_tests/port/base.py:
2909         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2910         * Scripts/webkitpy/layout_tests/port/config.py:
2911         * Scripts/webkitpy/layout_tests/port/config_mock.py:
2912         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2913         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2914         * Scripts/webkitpy/layout_tests/port/webkit.py:
2915         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2916         * Scripts/webkitpy/tool/mocktool.py:
2917
2918 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2919
2920         Unreviewed, build breakage.
2921
2922         Apparently I uploaded the wrong version of the file to fix 49122
2923         and neither Eric or I noticed - it was missing a dirname() call.
2924         Fixing ...
2925
2926         https://bugs.webkit.org/show_bug.cgi?id=49122
2927
2928         * Scripts/webkitpy/common/checkout/scm.py:
2929
2930 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2931
2932         Reviewed by Eric Seidel.
2933
2934         webkitpy/tool/* unittests change cwd and don't clean up properly
2935
2936         https://bugs.webkit.org/show_bug.cgi?id=49122
2937
2938         * Scripts/webkitpy/common/checkout/scm.py:
2939
2940 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2941
2942         Reviewed by Simon Fraser.
2943
2944         suspendAnimations/resumeAnimations not present in WebKit2
2945         https://bugs.webkit.org/show_bug.cgi?id=49109
2946
2947         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2948         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2949         (WTR::LayoutTestController::suspendAnimations):
2950         (WTR::LayoutTestController::resumeAnimations):
2951         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2952
2953 2010-11-05  Tony Chang  <tony@chromium.org>
2954
2955         Reviewed by David Levin.
2956
2957         cleanup style in TestNetscapePlugIn/PluginObject.cpp
2958         https://bugs.webkit.org/show_bug.cgi?id=49044
2959
2960         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2961         (getPluginClass):
2962         (pluginGetProperty):
2963         (pluginSetProperty):
2964         (variantToIdentifier):
2965         (testCallback):
2966         (getURL):
2967         (getURLNotify):
2968         (testInvokeDefault):
2969         (testGetProperty):
2970         (testDocumentOpen):
2971         (testWindowOpen):
2972         (pluginInvoke):
2973         (handleCallback):
2974         (notifyStream):
2975         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2976
2977 2010-11-05  Eric Seidel  <eric@webkit.org>
2978
2979         Reviewed by David Levin.
2980
2981         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
2982         https://bugs.webkit.org/show_bug.cgi?id=49032
2983
2984         I wrote this file as part of bug 47847, but I forgot to commit it.
2985         No one else noticed it missing because test-webkitpy knows how
2986         to recover in the case where it can't import QueueStatusServer
2987         (which generally occurs due to not having installed the AppEngine SDK).
2988
2989         * QueueStatusServer/__init__.py: Added.
2990         * QueueStatusServer/model/workitems_unittest.py:
2991          - Remove a test which fails.  This was probably landed (by me)
2992            from my other machine, which since this __init__.py was missing
2993            I never noticed the failure and landed this invalid test.
2994            Sadly we can't really test remove_work_item as it depends
2995            on .key() working.  .key() will throw unless the object
2996            has already been saved it seems.
2997            This may be a mis-design in our remove_work_item implementation,
2998            but for now, just removing the test.
2999
3000 2010-11-04  Adam Roben  <aroben@apple.com>
3001
3002         Teach check-webkit-style about TestNetscapePlugIn
3003
3004         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
3005         TestNetscapePlugIn's coding conventions
3006
3007         Reviewed by John Sullivan.
3008
3009         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3010         WebKitAPITest and TestWebKitAPI in having different include order and
3011         naming conventions than WebCore. Added some comments about why the
3012         exceptions exist.
3013
3014 2010-11-04  Adam Roben  <aroben@apple.com>
3015
3016         Add a test that shows that windowed plugins are able to paint
3017
3018         Somehow we never had a test for this before.
3019
3020         Fixes <http://webkit.org/b/49029> Should add a test that shows
3021         windowed plugins can paint
3022
3023         Reviewed by Jon Honeycutt.
3024
3025         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3026         (DrawsGradient::DrawsGradient):
3027         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3028
3029         (DrawsGradient::onPaint):
3030         (DrawsGradient::onPrintClient):
3031         These both just call through to paint.
3032
3033         (DrawsGradient::paint): Fills our client area with some gradients.
3034
3035         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3036         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3037
3038         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3039         (createBitmapContextFromWebView): Use WM_PRINT instead of
3040         WM_PRINTCLIENT so that ::DefWindowProc will send
3041         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3042         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3043         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3044         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3045         will run on a big-endian platform.
3046
3047 2010-11-04  Adam Roben  <aroben@apple.com>
3048
3049         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3050         WindowedPluginTest base class
3051
3052         The base class takes care of subclassing the plugin's window so that a
3053         custom WNDPROC is called. This will make it easier to write tests that
3054         need to handle window messages.
3055
3056         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3057         a custom WNDPROC
3058
3059         Reviewed by Jon Honeycutt.
3060
3061         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3062         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3063         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3064         (NPNInvalidateRectInvalidatesWindow::wndProc):
3065         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3066         Moved code from here to WindowedPluginTest. Changed to use window()
3067         instead of m_window.
3068
3069         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3070         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3071         include path. Also reordered the include path to make a little more
3072         sense and simplified the entry that added TestNetscapePlugIn itself to
3073         the include path.
3074
3075         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3076         (WindowedPluginTest::WindowedPluginTest):
3077         (WindowedPluginTest::NPP_SetWindow):
3078         (WindowedPluginTest::staticWndProc):
3079         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3080         (WindowedPluginTest::window):
3081         Code came from NPNInvalidateRectInvalidatesWindow.
3082
3083 2010-11-04  Adam Roben  <aroben@apple.com>
3084
3085         Add a plugin test to show that windowed plugins are clipped correctly
3086
3087         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3088         plugins aren't clipped in WebKit2 on Windows
3089
3090         Reviewed by Jon Honeycutt.
3091
3092         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3093         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3094         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3095         region matches the clip rect we know we should have based on
3096         window-region-is-set-to-clip-rect.html, and check that our window class
3097         doesn't have the CS_PARENTDC style.
3098
3099         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3100         Added WindowRegionIsSetToClipRect.
3101
3102 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3103
3104         Reviewed by Martin Robinson.
3105
3106         [GTK] Avoid font hinting in the DRT
3107         https://bugs.webkit.org/show_bug.cgi?id=48548
3108
3109         Change the settings to avoid font hinting, it was causing
3110         different results depending on the distribution.
3111
3112         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3113         (initializeGtkFontSettings):
3114         * DumpRenderTree/gtk/fonts/fonts.conf:
3115
3116 2010-11-05  Eric Seidel  <eric@webkit.org>
3117
3118         Reviewed by Adam Barth.
3119
3120         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3121         https://bugs.webkit.org/show_bug.cgi?id=49051
3122
3123         This is a speculative fix.  The unit tests cover these methods, however
3124         I don't know if this will fully stop the system.log spam.
3125
3126         * Scripts/webkitpy/layout_tests/port/base.py:
3127         * Scripts/webkitpy/layout_tests/port/webkit.py:
3128
3129 2010-11-05  Eric Seidel  <eric@webkit.org>
3130
3131         Reviewed by Adam Barth.
3132
3133         Add basic support for showing bot id on /queue-status/ pages
3134         https://bugs.webkit.org/show_bug.cgi?id=49037
3135
3136         This support is really simple.  Eventually we'll want to
3137         show the bot id in the lock table too, but we don't have
3138         that information stored in the server yet.
3139
3140         * QueueStatusServer/handlers/queuestatus.py:
3141         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3142         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3143
3144 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3145
3146         Reviewed by Adam Barth.
3147
3148         Create a filesystem wrapper that we can use to enforce
3149         particular conventions and use for mocking and dependency
3150         injection down the line.
3151
3152         https://bugs.webkit.org/show_bug.cgi?id=48144
3153
3154         * Scripts/webkitpy/common/system/filesystem.py: Added.
3155         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3156
3157 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3158
3159         Reviewed by Tony Chang.
3160
3161         run_webkit_tests_unittest fails under Python 2.5
3162         https://bugs.webkit.org/show_bug.cgi?id=49043
3163         
3164         Switch from itertools.chain.from_iterable (which was added in 2.6)
3165         to using itertools.chain directly.
3166
3167         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3168
3169 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3170
3171         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3172         Python 2.5 (it needs an import to use the with statement).
3173
3174         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3175
3176 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3177
3178         Reviewed by Adam Barth.
3179
3180         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3181
3182         The current NRWT code has webkit-specific configuration code (like
3183         _script_path, default configuration, etc.) mixed in with
3184         layout-test-specific stuff in port/base. The configuration code
3185         should be split out into a separate module for easier mocking,
3186         testing, and isolation.
3187
3188         https://bugs.webkit.org/show_bug.cgi?id=48264
3189
3190         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3191         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3192
3193 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3194
3195         Reviewed by Tony Chang.
3196
3197         Rebaseline server: initial framework
3198         https://bugs.webkit.org/show_bug.cgi?id=48892
3199         
3200         Adds the basic framework for the rebaseline server (details at 
3201         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
3202         command, which starts an HTTP server that can serve static files or
3203         invoke handler methods on a class.
3204
3205         * Scripts/webkitpy/tool/commands/__init__.py:
3206         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
3207         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
3208         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
3209         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
3210
3211 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3212
3213         Reviewed by James Robinson.
3214
3215         new-run-webkit-tests wasn't using DRT by default for
3216         --platform chromium-gpu
3217
3218         The default value was set to False instead of None, which meant
3219         that the platform specific logic wasn't firing to change the
3220         value to True (b/c we were afraid we'd be overriding the user
3221         preference).
3222
3223         https://bugs.webkit.org/show_bug.cgi?id=49038
3224
3225         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3226
3227 2010-11-04  Tony Chang  <tony@chromium.org>
3228
3229         Reviewed by Adam Barth.
3230
3231         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
3232         https://bugs.webkit.org/show_bug.cgi?id=49026
3233
3234         Have the testObject.bar property return the string "bar".  This lets
3235         us run and pass platform/chromium/plugins/multiple-plugins.html on all
3236         platforms.
3237
3238         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3239         (testGetProperty):
3240
3241 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3242
3243         Reviewed by Tony Chang.
3244
3245         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
3246         https://bugs.webkit.org/show_bug.cgi?id=48878
3247         
3248         Add get_tests_run so that it's easy to see which tests get run (and with
3249         what batching) for a given flag combination. Flesh out the various
3250         test cases that have FIXMEs.
3251         
3252         Also fixes an off-by-one error (batch sizes were one larger than 
3253         expected) and makes --run-part also have wraparound behavior, like
3254         --run-chunk.
3255
3256         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3258         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3259
3260 2010-11-04  Erik Arvidsson  <arv@chromium.org>
3261
3262         Reviewed by Dimitri Glazkov.
3263
3264         Support box-sizing without the vendor prefix
3265         https://bugs.webkit.org/show_bug.cgi?id=36713
3266
3267         Based on patch by Peter Beverloo <peter@lvp-media.com>
3268
3269         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
3270
3271 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3272
3273         Unreviewed rollout r71340, because it broke Chromium Windows bot.
3274
3275         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3276         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3277
3278 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3279
3280         Reviewed by Ojan Vafai.
3281
3282         Make http locking default in NRWT.
3283         https://bugs.webkit.org/show_bug.cgi?id=48053
3284
3285         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3286         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3287
3288 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3289
3290         Reviewed by Eric Seidel.
3291
3292         [NRWT] Clear invalid http locks on Windows platform as well
3293         https://bugs.webkit.org/show_bug.cgi?id=48515
3294
3295         * Scripts/webkitpy/common/system/executive.py:
3296         * Scripts/webkitpy/common/system/executive_unittest.py:
3297         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3298
3299 2010-11-02  Adam Roben  <aroben@apple.com>
3300
3301         Reduce our dependence on coreutils when running Python tests
3302
3303         This patch introduces versions of the standard echo and cat utilities
3304         implemented in Python. They are probably missing features of their
3305         coreutils equivalents, but they can do what's necessary for our Python
3306         tests. This is useful on Windows, where these utilities typically
3307         aren't available.
3308
3309         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3310         and cat utilities from coreutils, which are not present on Windows
3311
3312         Reviewed by Eric Seidel.
3313
3314         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3315         our Python-based echo and cat.
3316
3317         * Scripts/webkitpy/common/system/fileutils.py: Added.
3318         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3319         that \n won't be translated into \r\n. I couldn't think of a good way
3320         to test this directly without touching the filesystem, but it is tested
3321         indirectly by echo_unittest.
3322
3323         * Scripts/webkitpy/test/cat.py: Added.
3324         (command_arguments): Returns a list for invoking cat with the given arguments.
3325         (main): Acts like a simplified version of the coreutils cat utility.
3326
3327         * Scripts/webkitpy/test/cat_unittest.py: Added.
3328         (CatTest.assert_cat): Runs cat with the given input and ensures the
3329         output matches the input.
3330         (CatTest.test_basic): Performs a simple test of cat.
3331         (CatTest.test_no_newline): Tests what happens when the input string
3332         doesn't have a trailing newline.
3333         (CatTest.test_unicode): Tests passing a unicode string to cat.
3334         (CatTest.test_as_command): Tests running cat as a separate command.
3335
3336         * Scripts/webkitpy/test/echo.py: Added.
3337         (command_arguments): Returns a list for invoking echo with the given arguments.
3338         (main): Acts like a simplified version of the coreutils echo utility.
3339
3340         * Scripts/webkitpy/test/echo_unittest.py: Added.
3341         (EchoTest.test_basic): Performs a simple test of echo.
3342         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3343         trailing newline.
3344         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3345         to echo.
3346         (EchoTest.test_argument_order): Tests what happens when -n is not the
3347         first argument.
3348         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3349         echo.main.
3350         (EchoTest.test_no_arguments): Tests what happens when you call
3351         echo.main with no arguments.
3352         (EchoTest.test_as_command): Tests running echo as a separate command.
3353
3354 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3355
3356         Unreviewed: Add myself to the list of Committers.
3357
3358         * Scripts/webkitpy/common/config/committers.py:
3359
3360 2010-11-04  Andreas Kling  <kling@webkit.org>
3361
3362         Reviewed by Kenneth Rohde Christiansen.
3363
3364         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3365
3366         In RTC mode the QGraphicsWebView item is the size of the contents,
3367         scrolling works a bit differently  (we need to react to scrollRequested.)
3368
3369         Normally QGraphicsView will replay the last mouse event when scrolling,
3370         so to prevent WebKit from getting confused by this we temporarily make
3371         the QGraphicsView non-interactive.
3372
3373         * QtTestBrowser/webview.cpp:
3374         (WebViewGraphicsBased::setPage):
3375         (WebViewGraphicsBased::scrollRequested):
3376         * QtTestBrowser/webview.h:
3377
3378 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3379
3380         Reviewed by Andreas Kling.
3381
3382         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3383
3384         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3385         the Mac-port, not the Mac OS X operating system.
3386
3387         * WebKitTestRunner/qt/TestControllerQt.cpp:
3388         (WTR::isExistingLibrary):
3389
3390 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3391
3392         Reviewed by Andreas Kling.
3393
3394         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3395         https://bugs.webkit.org/show_bug.cgi?id=48869
3396
3397         * QtTestBrowser/useragentlist.txt:
3398
3399 2010-11-03  Adam Roben  <aroben@apple.com>
3400
3401         Always use uppercase drive names in strings returned by abspath_to_uri
3402
3403         Some versions of cygpath use lowercase drive letters while others use
3404         uppercase, which makes it hard to test the output of code that uses
3405         cygpath.
3406
3407         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
3408         fails with Cygwin 1.5
3409
3410         Reviewed by Eric Seidel.
3411
3412         * Scripts/webkitpy/common/system/path.py:
3413         (cygpath): Updated the docstring to indicate that only absolute paths
3414         should be passed for now (though relative paths will work fine).
3415         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
3416
3417 2010-11-03  George Guo  <George.Guo@Nokia.com>
3418
3419         Reviewed by Andreas Kling.
3420
3421         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
3422         https://bugs.webkit.org/show_bug.cgi?id=48767
3423     
3424         Paging is needd on Symbian devices to support benchmarks tests like
3425         dromaeo.com and Celtic Kane that need a lot of memory to run  
3426
3427         * QtTestBrowser/QtTestBrowser.pro:
3428
3429 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
3430
3431         Reviewed by Dmitry Titov.
3432
3433         Chromium: Update resource tracking when moving a frame between documents
3434         https://bugs.webkit.org/show_bug.cgi?id=48363
3435
3436         * DumpRenderTree/chromium/WebViewHost.cpp:
3437         (WebViewHost::assignIdentifierToRequest):
3438         Always put resource id in map so we can make assumptions about its
3439         presence.
3440         (WebViewHost::removeIdentifierForRequest):
3441         Added.
3442         (WebViewHost::didFinishResourceLoad):
3443         (WebViewHost::didFailResourceLoad):
3444         Check existence of resource id before removing from map.
3445         * DumpRenderTree/chromium/WebViewHost.h:
3446
3447 2010-11-03  Victor Wang  <victorw@chromium.org>
3448
3449         Reviewed by Adam Barth.
3450
3451         [Chromium] update buildbot names in chromium rebaseline tool.
3452
3453         https://bugs.webkit.org/show_bug.cgi?id=48881
3454
3455         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3456
3457 2010-11-03  Darin Adler  <darin@apple.com>
3458
3459         Updated Xcode projects by opening them with Xcode 3.2.4.
3460         Updated svn:ignore for Xcode projects.
3461
3462         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
3463         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
3464         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3465         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
3466
3467 2010-11-03  Adam Roben  <aroben@apple.com>
3468
3469         Stop waiting for messages from the web process after a timeout elapses
3470
3471         TestController::runUntil now takes a timeout parameter that specifies
3472         how long to wait for the condition to become true. WebKitTestRunner
3473         takes a --timeout flag that specifies how long the timeout should be.
3474         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
3475         will be similar to run-webkit-tests.
3476
3477         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
3478         WebKitTestRunner waits forever if the web process crashes
3479
3480         Reviewed by Darin Adler and Anders Carlsson.
3481
3482         * Scripts/old-run-webkit-tests:
3483         (top level): Moved the GuardMalloc timeout adjustment here from
3484         readFromDumpToolWithTimer.
3485         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
3486         than the one that was specified on the command line.
3487
3488         * WebKitTestRunner/TestController.cpp:
3489         (WTR::TestController::TestController): Initialize our timeout values.
3490         (WTR::TestController::initialize): Parse the --timeout flag and use it
3491         to modify our timeout values.
3492         (WTR::TestController::resetStateToConsistentValues): Changed to use a
3493         short timeout while waiting for the web process to reset and to return
3494         a boolean indicating whether we were able to reset the web process.
3495         Uses a 5-second timeout while waiting for the process to be reset.
3496         (WTR::TestController::runTest): Changed to return a boolean indicating
3497         whether we were able to reset the web process (and thus run the test).
3498         (WTR::TestController::runUntil): Call through to platformRunUntil.
3499
3500         (WTR::TestController::runTestingServerLoop):
3501         (WTR::TestController::run):
3502         Changed to bail if any test can't be run. This will cause the process
3503         to exit. (Unfortunately this will make run-webkit-tests think we
3504         crashed; see <http://webkit.org/b/48943>.)
3505
3506         * WebKitTestRunner/TestController.h: Added platformRunUntil,
3507         m_longTimeout, and m_shortTimeout.
3508
3509         * WebKitTestRunner/TestInvocation.cpp:
3510         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
3511         initial response and a long timeout when waiting for the test to
3512         complete. Check whether runUntil timed out and print an error message
3513         if so.
3514
3515         * WebKitTestRunner/mac/TestControllerMac.mm:
3516         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
3517         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
3518         won't block waiting for the run loop. Only loop until the timeout
3519         elapses.
3520
3521         * WebKitTestRunner/qt/TestControllerQt.cpp:
3522         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
3523         FIXME about honoring the timeout.
3524
3525         * WebKitTestRunner/win/TestControllerWin.cpp:
3526         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
3527         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
3528         ::PeekMessageW so that we don't block waiting for messages to become
3529         available.
3530
3531 2010-11-03  Adam Roben  <aroben@apple.com>
3532
3533         Add a plugin test that evaluates JS after removing the plugin element
3534         from the document
3535
3536         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
3537         That test was made to prevent a crash very similar to this one, but
3538         unfortunately tested only the mechanism that prevented the crash and
3539         not whether the crash itself was prevented. Since WebKit2 uses a
3540         different mechanism to prevent the crash, the test was failing even
3541         though WebKit2 was not vulnerable to the crash. This new test crashes
3542         if there is no mechanism in place to prevent it and passes in both
3543         WebKit1 and WebKit2.
3544
3545         Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
3546         platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2
3547
3548         Reviewed by Anders Carlsson.
3549
3550         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3551         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3552         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3553         * GNUmakefile.am:
3554         Added new file.
3555
3556         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3557         (pluginDeallocate): Make sure we delete the PluginTest object. This
3558         prevents a leak and also allows us to test the crash.
3559
3560         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3561         (PluginTest::executeScript): Made this into a non-static member
3562         function.
3563
3564         (PluginTest::waitUntilDone):
3565         (PluginTest::notifyDone):
3566         Updated for changes to executeScript.
3567
3568         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
3569
3570         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.
3571         (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
3572         Initialize ourselves and tell the test harness to wait.
3573         (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
3574         plugin element from the document, then execute some JavaScript. If
3575         WebKit does not have appropriate mechanisms in place, we'll be
3576         destroyed inside the first call to executeScript and crash on the
3577         second call.
3578
3579 2010-11-02  Stephen White  <senorblanco@chromium.org>
3580
3581         Reviewed by Tony Chang.
3582
3583         [chromium] Fix LayoutTestController UMRs.
3584         https://bugs.webkit.org/show_bug.cgi?id=48872
3585
3586         * DumpRenderTree/chromium/LayoutTestController.cpp:
3587         (LayoutTestController::LayoutTestController):
3588
3589 2010-11-03  Kent Tamura  <tkent@chromium.org>
3590
3591         Reviewed by Dimitri Glazkov.
3592
3593         REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
3594         image dup detection
3595         https://bugs.webkit.org/show_bug.cgi?id=48744
3596
3597         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3598          - Make a function for option parsing for ease of test
3599          - Set 0 to options.tolerance
3600         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3601          - Add a test for this change
3602
3603 2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3604
3605         Unreviewed: Add myself to the list of Committers.
3606
3607         * Scripts/webkitpy/common/config/committers.py:
3608
3609 2010-11-02  Anders Carlsson  <andersca@apple.com>
3610
3611         Fix build.
3612
3613         * TestWebKitAPI/PlatformUtilities.cpp:
3614         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3615
3616 2010-11-02  Sam Weinig  <sam@webkit.org>
3617
3618         Reviewed by Anders Carlsson.
3619
3620         Add a way to send startup messages on the context which can be posted when a process launches
3621         <rdar://problem/8617928>
3622         https://bugs.webkit.org/show_bug.cgi?id=48838
3623
3624         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3625         (WKBundleInitialize):
3626         * TestWebKitAPI/InjectedBundleController.cpp:
3627         (TestWebKitAPI::InjectedBundleController::initialize):
3628         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
3629         * TestWebKitAPI/InjectedBundleController.h:
3630         * TestWebKitAPI/InjectedBundleMain.cpp:
3631         (WKBundleInitialize):
3632         * TestWebKitAPI/PlatformUtilities.cpp:
3633         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3634         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3635         (WKBundleInitialize):
3636         Update implementations of WKBundleInitialize to take an initial userData
3637         argument.  Change TestWebKitAPI to use the new initial userData to initialize
3638         each test's bundle.
3639
3640 2010-11-02  Benjamin Kalman  <kalman@google.com>
3641
3642         Reviewed by Ojan Vafai.
3643
3644         new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
3645         https://bugs.webkit.org/show_bug.cgi?id=48794
3646
3647         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
3648
3649 2010-11-02  Adam Roben  <aroben@apple.com>
3650
3651         Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin
3652         Python 2.5.x
3653
3654         It is known to hang on that version of