0ae738dbdad1fe8718bc87d4b95650e7d03259b5
[WebKit.git] / WebKitTools / ChangeLog
1 2010-09-22  Adam Roben  <aroben@apple.com>
2
3         Make test-webkitpy test WebKit2's scripts
4
5         These scripts can't be in WebKitTools due to limitations of Apple's
6         build process. But that doesn't mean we can't test them!
7
8         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
9         WebKit2/Scripts
10
11         Reviewed by Adam Barth.
12
13         * Scripts/test-webkitpy:
14         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
15         Now takes an external_package_paths parameter and cleans both webkitpy
16         and any external packages.
17         (init): Added an external_package_paths parameter which we pass along
18         to _clean_packages_with_test.
19         (top level): Add WebKit2/Scripts/webkit2 as our only external package
20         and pass it along to init and Tester.run_tests.
21
22         * Scripts/webkitpy/test/main.py:
23         (Tester.run_tests): Added an optional external_package_paths
24         parameter. We modify sys.path so that the external packages can be
25         imported, and search for unittest files inside all external packages
26         in addition to inside webkitpy.
27
28 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
29
30         Reviewed by Tony Chang.
31
32         new-run-webkit-tests: r68063 broke linux python tests
33
34         Add a missing "from __future__ import with_statement" to this
35         new file; the perils of testing only on the Mac and by review :(
36
37         https://bugs.webkit.org/show_bug.cgi?id=46293
38
39         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
40
41 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
42
43         Reviewed by Tony Chang.
44
45         Add a 'chromium-gpu' set of ports that will test the accelerated
46         GPU paths. This patch adds:
47
48         - support for the '--accelerated-compositing' and
49           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
50           'no-' flags)
51         - adds a new set of Ports that will look under
52           platform/chromium-gpu-$OS/ for baselines before looking in the
53           regular chromium search path
54         - adds a new test_expectations.txt file in platform/chromium-gpu
55           that skips all but the tests we actually want to run with
56           acceleration.
57
58         This patch will allow us to run both with and without acceleration
59         and to change the defaults for both the regular and -gpu options
60         as the code evolves.
61
62         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
63         each test bot.
64
65         https://bugs.webkit.org/show_bug.cgi?id=46225
66
67         * Scripts/webkitpy/layout_tests/port/chromium.py:
68         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
69         * Scripts/webkitpy/layout_tests/port/factory.py:
70         * Scripts/webkitpy/layout_tests/port/webkit.py:
71
72 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
73
74         Reviewed by Kenneth Rohde Christiansen.
75
76         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
77         https://bugs.webkit.org/show_bug.cgi?id=43988
78
79         Runs a web debug server on port specified by QtTestBrowser
80         argument -remote-inspector-port. Property
81         _q_webInspectorServerPort of the QWebPage instance will be set
82         according to the argument. All pages with that property set will
83         be remotely inspectable.
84
85         URL for remote inspection of first QWebPage is
86             http://localhost:9222/webkit/inspector/inspector.html?page=1
87         where 1 is the number of the QWebPage instance.
88
89         The base URL yields an index page with links to the individual inspectors:
90             http://localhost:9222/
91
92         * QtTestBrowser/launcherwindow.cpp:
93         (LauncherWindow::init):
94         * QtTestBrowser/launcherwindow.h:
95         * QtTestBrowser/main.cpp:
96         (LauncherApplication::handleUserOptions):
97
98 2010-09-22  Adam Roben  <aroben@apple.com>
99
100         Fix webkit-patch failure-reason now that build.webkit.org has been
101         updated
102
103         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
104         every time
105
106         Reviewed by Eric Seidel.
107
108         * Scripts/webkitpy/common/net/buildbot.py:
109         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
110         looking for an element that contains text, then returns it.
111         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
112         text out of the cells. This way it doesn't matter whether the cells
113         have <b> children (as for cells in directory rows) or not (as for
114         cells in file rows)
115         (BuildBot._parse_twisted_directory_listing): Look for rows that have
116         the "directory" or "file" class, rather than rows with any class,
117         since header rows now have a class attribute.
118
119         * Scripts/webkitpy/common/net/buildbot_unittest.py:
120         (BuildBotTest._example_directory_listing): Updated to more closely
121         match the markup that build.webkit.org is producing now.
122
123 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
124
125         Unreviewed, build fix.
126
127         new-run-webkit-tests: fix bug introduced in r68008 where if you
128         specify --chromium and no --platform, and you're running on
129         windows, you use the 'chromium-win' port by default instead of the
130         version-specific port. This breaks the buildbots.
131
132         It will be good for this refactoring to settle down so I can
133         rewrite the logic for default ports and the unit tests to be
134         clearer (and the testing more comprehensive).
135
136         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
137
138 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
139
140         Reviewed by Adam Barth.
141
142         Modify the Port interface to take only a series of keyword arguments
143         in the constructor, and modify Port/factory.get() to accomodate that,
144         and to accept user=XXX as an argument so we can pass
145         webkitpy.common.system.user.User objects in.
146
147         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
148         to use the common routine in webkitpy.common.system.user.open_url()
149         to display HTML files.
150
151         There was a routine in the Port interface to do the same thing,
152         but I see no need for a port-specific hook for this, since it is
153         something that will always be executed by the host environment
154         and displaying web pages has nothing to do with running layout tests.
155
156         Note that new-run-webkit-tests used to use test_shell to display
157         the page; this is potentially useful so that you can actually click
158         from a result to the broken page; however, since DumpRenderTree
159         doesn't support this functionality, it will be going away eventually.
160
161         https://bugs.webkit.org/show_bug.cgi?id=46128
162
163         * Scripts/webkitpy/layout_tests/port/base.py:
164         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
165         * Scripts/webkitpy/layout_tests/port/chromium.py:
166         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
167         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
168         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
169         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
170         * Scripts/webkitpy/layout_tests/port/dryrun.py:
171         * Scripts/webkitpy/layout_tests/port/factory.py:
172         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
173         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
174         * Scripts/webkitpy/layout_tests/port/gtk.py:
175         * Scripts/webkitpy/layout_tests/port/mac.py:
176         * Scripts/webkitpy/layout_tests/port/qt.py:
177         * Scripts/webkitpy/layout_tests/port/test.py:
178         * Scripts/webkitpy/layout_tests/port/webkit.py:
179         * Scripts/webkitpy/layout_tests/port/win.py:
180         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
181         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
182         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
183
184 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
185
186         Reviewed by Kenneth Rohde Christiansen.
187
188         [EFL] Get fresh theme when running EWebLauncher
189         https://bugs.webkit.org/show_bug.cgi?id=46210
190
191         If user tried to run EWebLauncher outside of the build tree, it would
192         not find the theme and fallback to the installed one. However, since
193         EWebLauncher is not installed, we always want to take the theme from
194         the just compiled source code. If user had never installed WebKit's
195         EFL port it could even receive a segv since no theme would be found.
196
197         Now EWebLauncher does not fallback to the installed theme and CMake
198         gives as DATA_DIR the directory of the theme it has just built.
199
200         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
201         EWebLauncher.
202         * EWebLauncher/main.c: Use only the theme from build director. Do not
203         fallback to others as this could hide real bugs.
204         (quit):
205         (browserCreate):
206         (findThemePath):
207         (main):
208
209 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
210
211         Unreviewed, build fix.
212
213         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
214         it just confuses it.
215
216         https://bugs.webkit.org/show_bug.cgi?id=46230
217
218         * Scripts/webkitpy/layout_tests/port/webkit.py:
219
220 2010-09-21  Lucas Forschler  <lforschler@apple.com>
221
222         Reviewed by Stephanie Lewis.
223
224         Make a new buildbot for Leopard Debug Test
225
226         * BuildSlaveSupport/build.webkit.org-config/config.json:
227
228 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
229
230         Unreviewed, build fix.
231
232         Fix breakage of Chromium Mac DRT port caused by r67905.
233
234         https://bugs.webkit.org/show_bug.cgi?id=46230
235
236         * Scripts/webkitpy/layout_tests/port/webkit.py:
237
238 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
239
240         Unreviewed, build fix.
241
242         Add missing import of 'tempfile'.
243
244         * Scripts/webkitpy/layout_tests/port/chromium.py:
245
246 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
247
248         Reviewed by Ojan Vafai.
249
250         new-run-webkit-tests: pull the list of tests from the Port, and
251            make it possible to run with no actual test files in the filesystem.
252
253         This set of changes allows us to delete the special
254         webkitpy/layout_tests/data directory and test the generic code without
255         touching the filesystem (except to write results). This speeds up
256         test-webkitpy substantially.
257
258         This also cleans up and removes several code paths in the generic
259         code and fixes some minor bugs, notably in the test_expectations
260         parsing, which was previously fragile if the tests weren't present.
261
262         We also change the way we diff image results to be able to do so
263         in memory, without relying on files. This slows down chromium
264         test_shell, which always writes images to files, but should speed
265         up DRT and ImageDiff-based implementations slightly.
266
267         Note that pulling the list of tests to run from the Port will allow
268         ports to specify what tests to run as an inclusive list; previously
269         you could only do this as an exclusive list by using a 
270         test_expectations file or Skipped files; nothing actually uses this
271         feature yet and it's unclear if it should be used.
272
273         Note that there are no functional changes -- apart from now 
274         always printing out the location of the checksum file when we are
275         tracing test runs -- and the total number of lines of non-test code
276         actually drops by two.
277
278         There is some more cleanup that can be done in the Port/Driver 
279         interface and in some handling of filenames, but I'll save that
280         for another change.
281
282         https://bugs.webkit.org/show_bug.cgi?id=45801
283
284         * Scripts/webkitpy/layout_tests/data/*: Removed.
285             - no longer need special mock layout_tests_directory in the
286               repository.
287         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
288             - add code to display missing text files, checksums when tracing
289             - update to not look at the filesystem directly.
290         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
291             - add more unit tests
292         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
293             - remove tests_are_present flag
294             - update with changes in Port interface - no longer access
295               the filesystem directly, although we still use os.path for
296               filename manipulation.
297         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
298             - add more unit tests
299         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
300             - renamed to port/test_files.py
301         * Scripts/webkitpy/layout_tests/port/base.py:
302             - change diff_image() to expect actual image data, not filenames
303             - add expected_checksum(), expected_image(), expected_text() to
304               return the content of the files so that we don't need a filesystem
305             - add path_exists(), path_isdir() for filesystem-like access.
306             - add test_dirs() to keep clobber-test-results from needing to
307               actually look at a real layout tests dir
308             - add tests() to return the list of tests to run on the port
309               (calls port/test_files to do the work).
310             - add update_baseline() to be able to save new baselines
311             - add uri_to_test_name() from port/dryrun.py so we can easily check
312               filename_to_uri()
313         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
314             - add more unit tests
315         * Scripts/webkitpy/layout_tests/port/chromium.py:
316             - change diff_image() to accept image content, not filenames.
317               This will be slower for test_shell/image_diff, but faster
318               for DRT/ImageDiff.
319         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
320             - add more unit tests
321         * Scripts/webkitpy/layout_tests/port/dryrun.py:
322             - simplify greatly
323         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
324             - add more unit tests
325         * Scripts/webkitpy/layout_tests/port/test.py:
326             - massive rewrite to use in-script list of tests and expectations
327         * Scripts/webkitpy/layout_tests/port/test_files.py:
328             - rename from layout_package/test_files.
329         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
330             - add unit tests
331         * Scripts/webkitpy/layout_tests/port/webkit.py:
332             - update diff_image() to take image contents, not files. Should
333               make things slightly faster.
334         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
335             - update with changes to diff_image()
336         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
337             - update with changes to diff_image()
338         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
339             - remove tests_are_present from test_expectations
340             - pull the list of tests from port.tests() instead
341               of calling test_files.py directly.
342         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
343             - update unit tests
344         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
345             - update with changes to 
346         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
347             - update with change in Port interface
348         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
349             - update with change in Port interface
350         * Scripts/webkitpy/style/checkers/test_expectations.py:
351             - remove the tests_are_present flag
352
353 2010-09-21  Anders Carlsson  <andersca@apple.com>
354
355         Disable logging.
356
357         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
358
359 2010-09-21  Tony Chang  <tony@chromium.org>
360
361         Reviewed by Kent Tamura.
362
363         add a script for running webkit_unit_tests
364         https://bugs.webkit.org/show_bug.cgi?id=46014
365
366         * Scripts/run-chromium-webkit-unit-tests: Added.
367
368 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
369
370         Reviewed by Martin Robinson.
371
372         Fix linking problems on Windows.
373         https://bugs.webkit.org/show_bug.cgi?id=45844
374
375         * GNUmakefile.am: link the executables with winmm.dll
376
377 2010-09-21  Adam Barth  <abarth@webkit.org>
378
379         Reviewed by Eric Seidel.
380
381         feeder-queue svn updates more often than needed
382         https://bugs.webkit.org/show_bug.cgi?id=46171
383
384         We don't need to poll SVN every time we feed the feeders.  Rather, we
385         can count on the wrapper shell script to auto-update the queue.
386
387         * Scripts/webkitpy/tool/commands/queues.py:
388         * Scripts/webkitpy/tool/commands/queues_unittest.py:
389
390 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
391
392         Reviewed by Andreas Kling.
393
394         [Qt] Add robot loader timeout and extra time options.
395         https://bugs.webkit.org/show_bug.cgi?id=46172
396
397         [-robot-timeout <s>]: Load the next page after s seconds if the current
398         page didn't finish loading.
399         [-robot-extra-time <s>]: Wait s seconds after the current page finished
400         loading before loading the next one. This should allow some time for the
401         page's JavaScript to execute.
402
403         * QtTestBrowser/launcherwindow.cpp:
404         (LauncherWindow::applyPrefs):
405         * QtTestBrowser/main.cpp:
406         (LauncherApplication::robotTimeout):
407         (LauncherApplication::robotExtraTime):
408         (LauncherApplication::LauncherApplication):
409         (LauncherApplication::handleUserOptions):
410         (main):
411         * QtTestBrowser/urlloader.cpp:
412         (UrlLoader::UrlLoader):
413         (UrlLoader::loadNext):
414         (UrlLoader::loadUrlList):
415         * QtTestBrowser/urlloader.h:
416
417 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
418
419         Unreviewed.
420
421         Adding myself to the committers list.
422
423         * Scripts/webkitpy/common/config/committers.py:
424
425 2010-09-20  Philippe Normand  <pnormand@igalia.com>
426
427         Reviewed by Eric Carlson.
428
429         [GTK] enhanced context menu for media elements
430         https://bugs.webkit.org/show_bug.cgi?id=45021
431
432         EventSender::contextClick() now returns an array of js
433         objects. Each object has a title property and a click() method.
434
435         * DumpRenderTree/gtk/EventSender.cpp:
436         (getMenuItemTitleCallback):
437         (setMenuItemTitleCallback):
438         (menuItemClickCallback):
439         (getMenuItemClass):
440         (contextClickCallback):
441
442 2010-09-20  Hayato Ito  <hayato@chromium.org>
443
444         Unreviewed.
445         Adding myself to the committers list.
446
447         * Scripts/webkitpy/common/config/committers.py:
448
449 2010-09-20  Adam Barth  <abarth@webkit.org>
450
451         Reviewed by Eric Seidel.
452
453         The tool member variable should be called _tool
454         https://bugs.webkit.org/show_bug.cgi?id=46160
455
456         Created by find-and-replace.
457
458         * Scripts/webkitpy/tool/commands/download.py:
459         * Scripts/webkitpy/tool/commands/openbugs.py:
460         * Scripts/webkitpy/tool/commands/queries.py:
461         * Scripts/webkitpy/tool/commands/queues.py:
462         * Scripts/webkitpy/tool/commands/queues_unittest.py:
463         * Scripts/webkitpy/tool/commands/rebaseline.py:
464         * Scripts/webkitpy/tool/commands/sheriffbot.py:
465         * Scripts/webkitpy/tool/commands/upload.py:
466         * Scripts/webkitpy/tool/multicommandtool.py:
467
468 2010-09-20  Adam Barth  <abarth@webkit.org>
469
470         I ran the tests before landing but ignored the fact that they failed.  :(
471
472         * Scripts/webkitpy/tool/commands/queues.py:
473
474 2010-09-20  Adam Barth  <abarth@webkit.org>
475
476         Reviewed by Eric Seidel.
477
478         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
479         https://bugs.webkit.org/show_bug.cgi?id=46141
480
481         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
482         list of work items on the status server.  The individual commit-cluster
483         nodes then grab the patches from the server and process them.
484
485         * Scripts/webkitpy/tool/bot/feeders.py: Added.
486         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
487         * Scripts/webkitpy/tool/commands/queues.py:
488         * Scripts/webkitpy/tool/commands/queues_unittest.py:
489         * Scripts/webkitpy/tool/commands/queuestest.py:
490
491 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
492
493         Reviewed by Darin Adler.
494
495         build-webkit: Add support for CMake build system
496         https://bugs.webkit.org/show_bug.cgi?id=44979
497
498         * Scripts/build-webkit: Add "--efl" command-line option to build the
499         EFL port of WebKit.
500         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
501         buildEflCMakeProject() subroutines.
502
503 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
504
505         Reviewed by Ojan Vafai.
506
507         new-run-webkit-tests: refactor command line args getting passed to DRT
508
509         This change cleans up some argument parsing between functions to get
510         rid of some overlapping data structures. There should be no functional
511         changes in this patch; it is pure refactoring in preparation for
512         landing the Chrome GPU port and adding a generic way to pass
513         args to DRT/TestShell.
514
515         https://bugs.webkit.org/show_bug.cgi?id=46135
516
517         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
518           - pass the options argument explicitly to the threads and drivers,
519             also consolidate the passing of options to the driver.
520           - pass options directly to process_output() to remove a couple
521             parameters (minor cleanup).
522         * Scripts/webkitpy/layout_tests/port/base.py:
523           - pass the options argument to Port.create_driver().
524         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
525           - update Port.create_driver() test
526         * Scripts/webkitpy/layout_tests/port/chromium.py:
527           - pass the options argument to Port.create_driver(), and clean up
528             building of the cmd line for DRT.
529         * Scripts/webkitpy/layout_tests/port/dryrun.py:
530           - pass the options argument to Port.create_driver()
531         * Scripts/webkitpy/layout_tests/port/test.py:
532           - pass the options argument to Port.create_driver()
533         * Scripts/webkitpy/layout_tests/port/webkit.py:
534           - pass the options argument to Port.create_driver(), and clean up
535             building of the cmd line for DRT.
536         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
537           - consolidate args in _get_dump_render_tree_args and rename to
538             _get_test_args(); move all of the command-line args to the
539             Port implementations.
540
541 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
542
543         Revert change which was accidentally committed along with some expectation changes.
544
545         * Scripts/webkitpy/layout_tests/port/base.py:
546
547 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
548
549         Reviewed by Adam Barth.
550
551         Add explicit --force-patch flag to webkitpy tools
552         https://bugs.webkit.org/show_bug.cgi?id=46103
553         
554         It wasn't obvious until I read the applypatch.py source code that
555         --non-interfactive implies passing --force to patch. Add --force-patch
556         as an alias to the flag, so that this behavior is more discoverable.
557
558         * Scripts/webkitpy/tool/steps/applypatch.py:
559         * Scripts/webkitpy/tool/steps/options.py:
560
561 2010-09-20  Eric Seidel  <eric@webkit.org>
562
563         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
564
565         commit-queue can't land patches
566         https://bugs.webkit.org/show_bug.cgi?id=46138
567
568         Add a line of code I forgot in my last commit.
569
570         * Scripts/webkitpy/common/net/bugzilla.py:
571         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
572
573 2010-09-20  Adam Barth  <abarth@webkit.org>
574
575         Reviewed by Eric Seidel.
576
577         The commit-cluster bots still race to lock patch_ids
578         https://bugs.webkit.org/show_bug.cgi?id=46130
579
580         It turns out we need to use a transaction object to make the
581         read/modify/write lock operation atomic.  From reading the AppEngine
582         documentation, I think this patch should do what we want.  It's hard to
583         test locally because the test instance isn't distributed in the same
584         way the production instance is.
585
586         * QueueStatusServer/handlers/nextpatch.py:
587         * QueueStatusServer/model/activeworkitems.py: Added.
588
589 2010-09-20  Andy Estes  <aestes@apple.com>
590
591         Reviewed by Adam Barth.
592
593         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
594         https://bugs.webkit.org/show_bug.cgi?id=40961
595
596         Implement WebKitUsePreHTML5ParserQuirks preference.
597
598         * DumpRenderTree/mac/DumpRenderTree.mm:
599         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
600         to false after a test finishes.
601
602 2010-09-20  Adam Roben  <aroben@apple.com>
603
604         Windows build fix
605
606         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
607         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
608         we'll pick up the most recent versions of the headers.
609
610 2010-09-20  Eric Seidel  <eric@webkit.org>
611
612         Reviewed by Adam Barth.
613
614         commit-queue should check commit-queue+ again just before committing
615         https://bugs.webkit.org/show_bug.cgi?id=32679
616
617         Added a _revalidate_patch check, right before landing.
618
619         Since _revalidate_patch passes the patch_id from the work item
620         back to bugzilla, I had to fix all of the previous queue tests to
621         use valid attachment ids (that's the majority of this change).
622
623         In order to validate that the bug was still open, I had to teach
624         bugzilla.Bug about open/closed states.
625
626         * Scripts/webkitpy/common/net/bugzilla.py:
627         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
628         * Scripts/webkitpy/tool/commands/queues.py:
629         * Scripts/webkitpy/tool/commands/queues_unittest.py:
630         * Scripts/webkitpy/tool/commands/queuestest.py:
631         * Scripts/webkitpy/tool/mocktool.py:
632
633 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
634
635         Unreviewed.
636
637         Adding myself as a comitter.
638
639         * Scripts/webkitpy/common/config/committers.py:
640
641 2010-09-20  Adam Barth  <abarth@webkit.org>
642
643         Reviewed by Eric Seidel.
644
645         Two instances of commit-queue try to process the same patch
646         https://bugs.webkit.org/show_bug.cgi?id=46113
647
648         This patch makes next-patch atomic so that the server won't vend the
649         same patch twice in the same hour.
650
651         * QueueStatusServer/handlers/nextpatch.py:
652
653 2010-09-20  Adam Roben  <aroben@apple.com>
654
655         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
656
657         We were previously trying to use a CFRunLoopTimer, but since Windows
658         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
659         Windows-style timer on Windows.
660
661         I also replaced all uses of "watchdog" with "watchdog timer".
662
663         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
664         watchdog timer doesn't work on Windows
665
666         Reviewed by Anders Carlsson.
667
668         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
669         (WTR::InjectedBundlePage::dump): Updated for rename.
670
671         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
672         platform-specific functions.
673         (WTR::LayoutTestController::LayoutTestController): Added call to
674         platformInitialize.
675         (WTR::LayoutTestController::waitUntilDone): Changed to call
676         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
677         right in this function.
678         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
679         rename.
680
681         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
682         members needed to support the watchdog timer abstraction. Replaced
683         some "watchdog"s with "watchdog timer".
684
685         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
686         Added.
687         (WTR::LayoutTestController::platformInitialize): Does nothing on this
688         platform.
689         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
690         from LayoutTestController.cpp and changed to use an early return.
691         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
692         LayoutTestController.cpp.
693         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
694         Moved code here from LayoutTestController::waitUntilDone and changed
695         to use an early return.
696
697         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
698         Added.
699         (WTR::LayoutTestController::platformInitialize): Initialize our
700         watchdog timer.
701         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
702         Kills and clears the watchdog timer.
703         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
704         LayoutTestController member function of the same name.
705         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
706         Added. Sets up the timer if it isn't already set.
707
708         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
709         LayoutTestControllerMac.mm.
710
711         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
712         LayoutTestControllerWin.cpp.
713
714 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
715
716         Reviewed by Daniel Bates.
717
718         [GTK] fast/forms/listbox-selection.html fails
719         https://bugs.webkit.org/show_bug.cgi?id=45942
720
721         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
722         strings in keyDownCallback.
723
724         * DumpRenderTree/gtk/EventSender.cpp:
725         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
726         modifier parsing logic.
727
728 2010-09-19  Sam Weinig  <sam@webkit.org>
729
730         Reviewed by Anders Carlsson.
731
732         WebKit2 decidePolicyForNavigationAction should include mouse button information
733         <rdar://problem/8413165>
734         https://bugs.webkit.org/show_bug.cgi?id=46060
735
736         * MiniBrowser/mac/BrowserWindowController.m:
737         (decidePolicyForNavigationAction):
738         (decidePolicyForNewWindowAction):
739
740 2010-09-19  Daniel Bates  <dbates@rim.com>
741
742         Reviewed by Martin Robinson.
743
744         Add unit tests for diffs that delete or modify a change log entry
745         or describe changes that are far apart
746         https://bugs.webkit.org/show_bug.cgi?id=46046
747
748         Add additional unit tests to test change log diffs that contain
749         deletions or changes that are far apart from each other in the
750         ChangeLog file.
751
752         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
753           - Added the following unit tests:
754           "fixChangeLogPatch: [no change] In-place change."
755           "fixChangeLogPatch: [no change] Remove first entry."
756           "fixChangeLogPatch: [no change] Remove entry in the middle."
757           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
758
759 2010-09-19  Sam Weinig  <sam@webkit.org>
760
761         Reviewed by Anders Carlsson.
762
763         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
764         https://bugs.webkit.org/show_bug.cgi?id=46054
765
766         The new one acts like WKBundleNodeHandleRef and allows for getting a
767         wrapper in a specific world for the handle.
768
769         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
770         (WTR::propertyValue):
771         (WTR::propertyValueDouble):
772         (WTR::propertyValueInt):
773         (WTR::numericWindowPropertyValue):
774         (WTR::toStr):
775         (WTR::InjectedBundlePage::shouldBeginEditing):
776         (WTR::InjectedBundlePage::shouldEndEditing):
777         (WTR::InjectedBundlePage::shouldInsertNode):
778         (WTR::InjectedBundlePage::shouldInsertText):
779         (WTR::InjectedBundlePage::shouldDeleteRange):
780         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
781         (WTR::InjectedBundlePage::shouldApplyStyle):
782         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
783
784 2010-09-19  Kent Tamura  <tkent@chromium.org>
785
786         Unreviewed. Fix WebGL test regressions by r67809.
787
788         * DumpRenderTree/chromium/WebPreferences.cpp:
789         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
790
791 2010-09-19  Kent Tamura  <tkent@chromium.org>
792
793         Reviewed by Adam Barth.
794
795         [DRT/Chromium] Fix a WebSettings handling bug
796         https://bugs.webkit.org/show_bug.cgi?id=45945
797
798         Before this change, Chromium DRT reset WebSettings for every new
799         window. It was wrong.
800         If new window is not the first one, we have to apply the same
801         settings as the first window.  So, we introduce WebPreference to
802         store the current settings, and apply it to new windows. It's same
803         as test_shell's behavior.
804
805         * DumpRenderTree/DumpRenderTree.gypi:
806         * DumpRenderTree/chromium/LayoutTestController.cpp:
807           Use WebPreferences instead of WebSettings.
808         (LayoutTestController::setUserStyleSheetEnabled):
809         (LayoutTestController::setUserStyleSheetLocation):
810         (LayoutTestController::setAuthorAndUserStylesEnabled):
811         (LayoutTestController::setPopupBlockingEnabled):
812         (LayoutTestController::disableImageLoading):
813         (LayoutTestController::setJavaScriptCanAccessClipboard):
814         (LayoutTestController::setXSSAuditorEnabled):
815         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
816         (LayoutTestController::setAllowFileAccessFromFileURLs):
817         (LayoutTestController::overridePreference):
818         (LayoutTestController::setEditingBehavior):
819         * DumpRenderTree/chromium/TestShell.cpp:
820         (TestShell::resetWebSettings): Use WebPreferences.
821         (TestShell::runFileTest): ditto.
822         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
823         * DumpRenderTree/chromium/TestShell.h:
824         (TestShell::preferences):
825         (TestShell::applyPreferences):
826         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
827         * DumpRenderTree/chromium/WebPreferences.h: Added.
828
829 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
830
831         Reviewed by David Levin.
832
833         update-webkit --chromium spitting out a spurious error
834         https://bugs.webkit.org/show_bug.cgi?id=45868
835
836         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
837
838 2010-09-18  Sam Weinig  <sam@webkit.org>
839
840         Reviewed by Dan Bernstein.
841
842         Improve/unify the PageLoadClient interfaces
843         https://bugs.webkit.org/show_bug.cgi?id=46043
844
845         * MiniBrowser/mac/BrowserWindowController.m:
846         (didStartProvisionalLoadForFrame):
847         (didReceiveServerRedirectForProvisionalLoadForFrame):
848         (didFailProvisionalLoadWithErrorForFrame):
849         (didCommitLoadForFrame):
850         (didFinishDocumentLoadForFrame):
851         (didFinishLoadForFrame):
852         (didFailLoadWithErrorForFrame):
853         (didReceiveTitleForFrame):
854         (didFirstLayoutForFrame):
855         (didFirstVisuallyNonEmptyLayoutForFrame):
856         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
857         (WTR::InjectedBundlePage::InjectedBundlePage):
858         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
859         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
860         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
861         (WTR::InjectedBundlePage::didCommitLoadForFrame):
862         (WTR::InjectedBundlePage::didFinishLoadForFrame):
863         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
864         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
865         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
866         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
867         * WebKitTestRunner/TestController.cpp:
868         (WTR::TestController::didReceiveMessageFromInjectedBundle):
869         (WTR::TestController::didFinishLoadForFrame):
870         * WebKitTestRunner/TestController.h:
871
872 2010-09-17  Eric Seidel  <eric@webkit.org>
873
874         Unreviewed.  Adding a shell script I use to run the
875         commit-queue. Now that multiple machines run the cq,
876         it makes sense to share the script between them.
877
878         * EWSTools/start-commit-queue.sh: Added.
879
880 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
881
882         Reviewed by Jon Honeycutt.
883
884         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
885         slightly harder to read, so this reverts the previous background colors for various
886         states, making it easier to read.
887
888         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
889         (.success):
890         (.failure):
891         (.warnings):
892         (.exception):
893         (.start,.running,td.building):
894         (.offline,td.offline):
895
896 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
897
898         Unreviewed, rolling out r67692.
899         http://trac.webkit.org/changeset/67692
900         https://bugs.webkit.org/show_bug.cgi?id=46011
901
902         broke layout test dashboard (Requested by johnny_g on
903         #webkit).
904
905         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
906         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
907         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
908
909 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
910
911         Reviewed by Oliver Hunt.
912
913         Style bot complains about cairo forward declaration naming
914         https://bugs.webkit.org/show_bug.cgi?id=45867
915
916         Exclude Cairo forward declarations from indentifiers with underscores checks.
917
918         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
919         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
920
921 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
922
923         Reviewed by Ojan Vafai.
924
925         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
926         https://bugs.webkit.org/show_bug.cgi?id=45408
927
928         This change also tries to remove duplicated upload_results_json methods
929         in run_webkit_tests.py and json_results_generator.py.
930
931         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
932         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
933         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
934
935 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
936
937         Reviewed by Andreas Kling.
938
939         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
940
941         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
942         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
943         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
944         all page specific stuff to the UI.
945
946         * QtTestBrowser/launcherwindow.cpp:
947         (LauncherWindow::initializeView):
948         * QtTestBrowser/mainwindow.cpp:
949         (MainWindow::MainWindow):
950         (MainWindow::buildUI):
951         (MainWindow::setPage):
952         * QtTestBrowser/mainwindow.h:
953
954 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
955
956         Reviewed by Andreas Kling.
957
958         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
959
960         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
961         object will move to the qgraphicsscene instead of the qgraphicsview.
962
963         * QtTestBrowser/webview.cpp:
964         (WebViewGraphicsBased::setPage):
965         (WebViewGraphicsBased::setResizesToContents):
966         (WebViewGraphicsBased::resizeEvent):
967         (WebViewGraphicsBased::animatedFlip):
968         * QtTestBrowser/webview.h:
969         (WebViewGraphicsBased::setItemCacheMode):
970         (WebViewGraphicsBased::itemCacheMode):
971
972 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
973
974         Reviewed by Andreas Kling.
975
976         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
977
978         We usually separate methods whose body are larger than a few lines from the class definition.
979
980         * QtTestBrowser/webview.h:
981         (WebViewGraphicsBased::yRotation):
982         (WebViewGraphicsBased::setYRotation):
983
984 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
985
986         Reviewed by Andreas Kling.
987
988         Make initializeView method of LauncherWindow private.
989
990         No one else needs to be able to call it but LauncherWindow.
991         Also moving the declation of isGraphicsBased method down in the same file, in order
992         to better group related methods.
993
994         * QtTestBrowser/launcherwindow.h:
995
996 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
997
998         Reviewed by Andreas Kling.
999
1000         Make the getter 'page' method of MainWindow const.
1001
1002         * QtTestBrowser/mainwindow.cpp:
1003         (MainWindow::page):
1004         * QtTestBrowser/mainwindow.h:
1005
1006 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1007
1008         Reviewed by Andreas Kling.
1009
1010         Remove useless parameter from MainWindow class' constructor.
1011
1012         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
1013         not referred in the constructor body and does not make much sense.
1014
1015         * QtTestBrowser/mainwindow.cpp:
1016         (MainWindow::MainWindow):
1017         * QtTestBrowser/mainwindow.h:
1018
1019 2010-09-15  Tony Chang  <tony@chromium.org>
1020
1021         Reviewed by Kent Tamura.
1022
1023         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1024         https://bugs.webkit.org/show_bug.cgi?id=42151
1025
1026         * DumpRenderTree/chromium/LayoutTestController.cpp:
1027         (LayoutTestController::LayoutTestController):
1028         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1029         (WorkItemLoadHTMLString::run):
1030         (LayoutTestController::queueLoadHTMLString):
1031         (LayoutTestController::reset):
1032         (LayoutTestController::setDeferMainResourceDataLoad):
1033         * DumpRenderTree/chromium/LayoutTestController.h:
1034         (LayoutTestController::deferMainResourceDataLoad):
1035         * DumpRenderTree/chromium/WebViewHost.cpp:
1036         (WebViewHost::didCreateDataSource):
1037
1038 2010-09-16  Adrienne Walker  <enne@google.com>
1039
1040         Reviewed by Kenneth Russell.
1041
1042         Add script to synchronize WebKit and Khronos WebGL tests
1043         https://bugs.webkit.org/show_bug.cgi?id=42336
1044
1045         * Scripts/update-webgl-conformance-tests: Added.
1046         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
1047         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
1048
1049 2010-09-16  Sam Weinig  <sam@webkit.org>
1050
1051         Reviewed by Anders Carlsson.
1052
1053         Add support for sending synchronous messages from the InjectedBundle to the WKContext
1054         <rdar://problem/8365320>
1055         https://bugs.webkit.org/show_bug.cgi?id=44785
1056
1057         * MiniBrowser/mac/AppDelegate.m:
1058         (didReceiveSynchronousMessageFromInjectedBundle):
1059         (-[BrowserAppDelegate init]):
1060         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1061         (didCreatePage):
1062         * WebKitTestRunner/TestController.cpp:
1063         (WTR::TestController::initialize):
1064
1065 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
1066
1067         Reviewed by Andreas Kling.
1068
1069         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
1070         https://bugs.webkit.org/show_bug.cgi?id=45885
1071
1072         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
1073
1074         * QtTestBrowser/launcherwindow.cpp:
1075         (LauncherWindow::screenshot):
1076
1077 2010-09-16  Anders Carlsson  <andersca@apple.com>
1078
1079         Fix clang++ build.
1080
1081         * MiniBrowser/mac/BrowserWindowController.m:
1082         (-[BrowserWindowController zoomIn:]):
1083         (-[BrowserWindowController zoomOut:]):
1084         (-[BrowserWindowController resetZoom:]):
1085         Remove trailing semicolons.
1086
1087 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1088
1089         Unreviewed, rolling out r67628.
1090         http://trac.webkit.org/changeset/67628
1091         https://bugs.webkit.org/show_bug.cgi?id=45904
1092
1093         broke the build (Requested by eric_carlson on #webkit).
1094
1095         * DumpRenderTree/gtk/EventSender.cpp:
1096         (contextClickCallback):
1097
1098 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
1099
1100         Unreviewed.
1101
1102         Adding myself as a comitter.
1103
1104         * Scripts/webkitpy/common/config/committers.py:
1105
1106 2010-09-15  Philippe Normand  <pnormand@igalia.com>
1107
1108         Reviewed by Eric Carlson.
1109
1110         [GTK] enhanced context menu for media elements
1111         https://bugs.webkit.org/show_bug.cgi?id=45021
1112
1113         EventSender::contextClick() now returns an array of js
1114         objects. Each object has a title property and a click() method.
1115
1116         * DumpRenderTree/gtk/EventSender.cpp:
1117         (getMenuItemTitleCallback):
1118         (setMenuItemTitleCallback):
1119         (menuItemClickCallback):
1120         (getMenuItemClass):
1121         (contextClickCallback):
1122
1123 2010-09-14  Philippe Normand  <pnormand@igalia.com>
1124
1125         Reviewed by Eric Carlson and Martin Robinson.
1126
1127         [GTK] eventSender.contextClick() should return the contents of the context menu
1128         https://bugs.webkit.org/show_bug.cgi?id=39102
1129
1130         Make the eventSender use the new private WebKitGtk+ API to
1131         retrieve the context-menu item titles and store them in an array.
1132
1133         * DumpRenderTree/gtk/EventSender.cpp:
1134         (contextClickCallback):
1135
1136 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
1137
1138         Reviewed by Jian Li.
1139
1140         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
1141         https://bugs.webkit.org/show_bug.cgi?id=45798
1142
1143         * Scripts/build-webkit:
1144
1145 2010-09-16  Robert Hogan  <robert@webkit.org>
1146
1147         Reviewed by Antonio Gomes.
1148
1149         [Qt] Support globalhistory tests
1150         https://bugs.webkit.org/show_bug.cgi?id=45774
1151
1152         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1153         (WebCore::isGlobalHistoryTest):
1154         (WebCore::DumpRenderTree::open):
1155         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1156         (LayoutTestController::reset):
1157         (LayoutTestController::dumpHistoryCallbacks):
1158         (LayoutTestController::removeAllVisitedLinks):
1159         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1160
1161 2010-09-10  Tony Chang  <tony@chromium.org>
1162
1163         Reviewed by Eric Seidel.
1164
1165         deduplicate-tests should be runnable from any WebKit directory
1166         https://bugs.webkit.org/show_bug.cgi?id=44709
1167
1168         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1169         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1170
1171 2010-09-15  Tony Chang  <tony@chromium.org>
1172
1173         Reviewed by Kent Tamura.
1174
1175         [chromium] sort testing methods in DRT
1176         https://bugs.webkit.org/show_bug.cgi?id=45850
1177
1178         * DumpRenderTree/chromium/EventSender.cpp:
1179         (EventSender::EventSender):
1180         * DumpRenderTree/chromium/LayoutTestController.cpp:
1181         (LayoutTestController::LayoutTestController):
1182         * DumpRenderTree/chromium/TextInputController.cpp:
1183         (TextInputController::TextInputController):
1184
1185 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
1186
1187         Reviewed by Adam Barth.
1188
1189         CQ status shows items out of order
1190         https://bugs.webkit.org/show_bug.cgi?id=45846
1191         
1192         Only group consecutive status items with the same patch ID into the same
1193         group, so that overall item ordering is preserved.
1194         
1195         Also don't indent status items that only have a single item in their
1196         group.
1197
1198         * QueueStatusServer/handlers/queuestatus.py:
1199         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
1200         * QueueStatusServer/templates/queuestatus.html:
1201
1202 2010-09-15  Eric Seidel  <eric@webkit.org>
1203
1204         Reviewed by Adam Barth.
1205
1206         Add queue start/stop messages
1207         https://bugs.webkit.org/show_bug.cgi?id=45853
1208
1209         I ended up needing to clean up a bunch of our unit testing
1210         in order to test this new code path nicely.
1211
1212         There are also a few PEP8 changes needed to pass check-webkit-style.
1213
1214         * Scripts/webkitpy/tool/bot/queueengine.py:
1215         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1216         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1217         * Scripts/webkitpy/tool/commands/queues.py:
1218         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1219         * Scripts/webkitpy/tool/commands/queuestest.py:
1220         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1221
1222 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
1223
1224         https://bugs.webkit.org/show_bug.cgi?id=45849
1225         WKURLCreateWithCFURL crashes with null url
1226         
1227         Fix MiniBrowser crash when the url is not parseable.
1228
1229         * MiniBrowser/mac/BrowserWindowController.m:
1230         (-[BrowserWindowController fetch:]):
1231
1232 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
1233
1234         Unreviewed.
1235
1236         Adding myself to the committers list.
1237
1238         * Scripts/webkitpy/common/config/committers.py:
1239
1240 2010-09-14  Eric Seidel  <eric@webkit.org>
1241
1242         Reviewed by Adam Barth.
1243
1244         Make it possible to run more than one commit-queue instance
1245         https://bugs.webkit.org/show_bug.cgi?id=45786
1246
1247         Mostly we need to make sure the two (or more) instances get
1248         different patches to work on.  To do this, I re-worked
1249         the code responsible for getting the next work item to
1250         round trip through the status server.  The status server only
1251         vends patches from the work items list, only if those patches
1252         have not had status reported for them in the last hour.
1253
1254         This is another step towards making all queues go through the
1255         status server, thus making it possible to run more than one
1256         instance of various EWS bots (as requested in bug 44292).
1257
1258         The webkitpy changes are already covered by existing unit tests.
1259         The QueueStatusSever sadly has no testing infrastructure yet. :(
1260
1261         * QueueStatusServer/handlers/nextpatch.py: Added.
1262         * QueueStatusServer/index.yaml:
1263         * QueueStatusServer/main.py:
1264         * Scripts/webkitpy/tool/commands/queues.py:
1265
1266 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
1267
1268         Reviewed by Tony Chang.
1269
1270         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
1271         https://bugs.webkit.org/show_bug.cgi?id=45791
1272
1273         Force filenames to be raw bytes before running difflib.unified_diff.
1274
1275         * Scripts/webkitpy/layout_tests/port/base.py:
1276         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1277
1278 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
1279
1280         Reviewed by Tor Arne Vestbø.
1281
1282         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
1283         https://bugs.webkit.org/show_bug.cgi?id=35247
1284
1285         The main issue when changing the views is that the plugins and any other components that
1286         depend on view specific attributes such as the native window id are not teared down.
1287         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
1288         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
1289         we decided to work around this in QtTestBrowser by making toggling between QWebView
1290         and QGraphicsWebView also re-create the page.
1291
1292         * QtTestBrowser/launcherwindow.cpp:
1293         (LauncherWindow::initializeView):
1294         * QtTestBrowser/mainwindow.h:
1295
1296 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
1297
1298         Reviewed by Adam Barth.
1299
1300         Send webkit accessibility notifications to Chromium
1301         https://bugs.webkit.org/show_bug.cgi?id=45156
1302
1303         Move printf inside shouldDumpAccessibilityNotifications check.
1304
1305         * DumpRenderTree/chromium/WebViewHost.cpp:
1306         (WebViewHost::postAccessibilityNotification):
1307
1308 2010-09-14  Tony Chang  <tony@chromium.org>
1309
1310         Reviewed by Kent Tamura.
1311
1312         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
1313         https://bugs.webkit.org/show_bug.cgi?id=45788
1314
1315         * DumpRenderTree/chromium/LayoutTestController.cpp:
1316         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
1317
1318 2010-09-14  Tony Chang  <tony@chromium.org>
1319
1320         Reviewed by Ojan Vafai.
1321
1322         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
1323         https://bugs.webkit.org/show_bug.cgi?id=45768
1324
1325         * DumpRenderTree/chromium/TestShell.cpp:
1326         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
1327
1328 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1329
1330         [wx] Build fix, add newly added directories to the directory list.
1331
1332         * wx/build/settings.py:
1333
1334 2010-09-14  Sam Weinig  <sam@webkit.org>
1335
1336         Reviewed by Anders Carlsson.
1337
1338         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
1339         https://bugs.webkit.org/show_bug.cgi?id=45785
1340
1341         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1342         (WTR::propertyValue):
1343         (WTR::numericWindowPropertyValue):
1344         (WTR::dumpPath):
1345         (WTR::toStr):
1346         (WTR::operator<<):
1347         (WTR::InjectedBundlePage::InjectedBundlePage):
1348         (WTR::InjectedBundlePage::shouldInsertNode):
1349         (WTR::InjectedBundlePage::shouldBeginEditing):
1350         (WTR::InjectedBundlePage::shouldEndEditing):
1351         (WTR::InjectedBundlePage::shouldInsertText):
1352         (WTR::InjectedBundlePage::shouldDeleteRange):
1353         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1354         (WTR::InjectedBundlePage::shouldApplyStyle):
1355         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1356
1357 2010-09-14  Adam Barth  <abarth@webkit.org>
1358
1359         Fix two typos in commit-queue.  The first is harmless.  The second
1360         causes the queue to reject patches when the build is broken.  :(
1361
1362         * Scripts/webkitpy/tool/commands/queues.py:
1363         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1364
1365 2010-09-14  Chris Guillory   <chris.guillory@google.com>
1366
1367         Reviewed by Chris Fleizach.
1368
1369         Send all accessibility notifications to Chromium.
1370         https://bugs.webkit.org/show_bug.cgi?id=45156
1371
1372         * DumpRenderTree/chromium/WebViewHost.cpp:
1373         (WebViewHost::postAccessibilityNotification):
1374         * DumpRenderTree/chromium/WebViewHost.h:
1375
1376 2010-09-14  Adam Barth  <abarth@webkit.org>
1377
1378         Reviewed by Eric Seidel.
1379
1380         commit-queue is slow during the day
1381         https://bugs.webkit.org/show_bug.cgi?id=45780
1382
1383         Thanks to the new logging, we've noticed that checkout-is-out-of-date
1384         errors in the first pass of landing don't retry the land.  Instead,
1385         they're treated as failures and cause the commit-queue to do two more
1386         builds before really trying to land the patch.  Worse, in the second
1387         build, we can get bitten by a flaky test.
1388
1389         This patch takes a slightly different approach to the commit-queue's
1390         main control logic.  We now use a separate subprocess for building and
1391         testing and for landing.  This means we should very rarely see the
1392         checkout-is-out-of-date error, and when we do see it, we should retry
1393         more quickly.  If my understanding is correct, this should be a big
1394         speed win for the commit-queue.
1395
1396         * Scripts/webkitpy/tool/commands/download.py:
1397         * Scripts/webkitpy/tool/commands/queues.py:
1398         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1399
1400 2010-09-14  Tony Chang  <tony@chromium.org>
1401
1402         Reviewed by Dimitri Glazkov.
1403
1404         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
1405         https://bugs.webkit.org/show_bug.cgi?id=45762
1406
1407         * DumpRenderTree/chromium/LayoutTestController.cpp:
1408         (LayoutTestController::LayoutTestController):
1409         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1410         * DumpRenderTree/chromium/LayoutTestController.h:
1411
1412 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
1413
1414         Adding myself as a reviewer.
1415
1416         * Scripts/webkitpy/common/config/committers.py:
1417
1418 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
1419
1420         Reviewed by Kenneth Rohde Christiansen.
1421
1422         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
1423         https://bugs.webkit.org/show_bug.cgi?id=45736
1424
1425         Build-webkit has showed a warning when WebKitBuild didn't exist, add
1426         an additional condition to avoid it.
1427
1428         * Scripts/build-webkit:
1429
1430 2010-09-13  Eric Seidel  <eric@webkit.org>
1431
1432         Reviewed by Adam Barth.
1433
1434         commit-queue should log when it's retrying due to checkout out of date error
1435         https://bugs.webkit.org/show_bug.cgi?id=45725
1436
1437         This will allow us to better track how often we see these errors
1438         and how long it takes the queue to recover from them.
1439
1440         In order to pass the tests, I had to correct an error
1441         from a previous change.  The UnitTestPort should not have
1442         ever been using the base port method as that will read
1443         a file from disk.  If the unit tests haven't passed the contents
1444         it should raise an IOError as though the file doesn't exist.
1445
1446         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1447         * Scripts/webkitpy/tool/commands/queues.py:
1448         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1449
1450 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
1451
1452         Reviewed by Adam Barth.
1453
1454         Upload results when cq patch landing fails
1455         https://bugs.webkit.org/show_bug.cgi?id=45683
1456         
1457         Include script errors when CommitQueue._land fails.
1458
1459         * Scripts/webkitpy/tool/commands/queues.py:
1460
1461 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1462
1463         Reviewed by David Kilzer.
1464
1465         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
1466         https://bugs.webkit.org/show_bug.cgi?id=45548
1467
1468         * DumpRenderTree/AccessibilityUIElement.cpp:
1469         (isIgnoredCallback):
1470         (AccessibilityUIElement::getJSClass):
1471         * DumpRenderTree/AccessibilityUIElement.h:
1472         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1473         (AccessibilityUIElement::isIgnored):
1474         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1475         (AccessibilityUIElement::isIgnored):
1476         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1477         (AccessibilityUIElement::isIgnored):
1478
1479 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1480
1481         Reviewed by Andreas Kling.
1482
1483         jscPath() is incorrect in Windows' cmd.exe shell
1484         https://bugs.webkit.org/show_bug.cgi?id=45651
1485
1486         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
1487
1488 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1489
1490         Reviewed by Darin Adler.
1491
1492         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
1493         https://bugs.webkit.org/show_bug.cgi?id=43807
1494
1495         * DumpRenderTree/AccessibilityUIElement.cpp:
1496         (textMarkerForPointCallback):
1497         (AccessibilityUIElement::textMarkerForPoint):
1498         (AccessibilityUIElement::getJSClass):
1499         * DumpRenderTree/AccessibilityUIElement.h:
1500         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1501         (AccessibilityUIElement::textMarkerForPoint):
1502
1503 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
1504
1505         Reviewed by Kenneth Rohde Christiansen.
1506
1507         [Qt] build-webkit: Add --v8 option to build against V8
1508
1509         Note that V8 is picked up from QtScript, so this currently requires building
1510         against the experimental qt-script-v8 branch.
1511
1512         * Scripts/build-webkit:
1513
1514 2010-09-13  Hans Wennborg  <hans@chromium.org>
1515
1516         Reviewed by Jeremy Orlow.
1517
1518         Add WebDeviceOrientationClientMock::create() and use it from DRT.
1519         https://bugs.webkit.org/show_bug.cgi?id=45650
1520
1521         Do not use the WebDeviceOrientationClientMock constructor directly,
1522         but use the create() member function.
1523
1524         This should fix the linker errors for the multi-DLL Chromium DRT build.
1525
1526         * DumpRenderTree/chromium/LayoutTestController.cpp:
1527         (LayoutTestController::setMockDeviceOrientation):
1528         (LayoutTestController::deviceOrientationClient):
1529
1530 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1531
1532         Reviewed by Antti Koivisto.
1533
1534         Add support for testing the viewport meta tag algorithm,
1535         based on the following draft spec:
1536
1537         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
1538
1539         Add common handling of viewport meta tag based on new Opera spec
1540         https://bugs.webkit.org/show_bug.cgi?id=44201
1541
1542         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1543         (LayoutTestController::dumpConfigurationForViewport):
1544         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1545
1546 2010-09-12  Kent Tamura  <tkent@chromium.org>
1547
1548         Reviewed by Tony Chang.
1549
1550         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
1551         https://bugs.webkit.org/show_bug.cgi?id=45517
1552
1553         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
1554
1555         * DumpRenderTree/chromium/ImageDiff.cpp:
1556         (Image::craeteFromStdin):
1557         (Image::createFromFilename):
1558         (diffImages):
1559         * DumpRenderTree/chromium/TestShell.cpp:
1560         (TestShell::dumpImage):
1561
1562 2010-09-10  MORITA Hajime  <morrita@google.com>
1563
1564         Reviewed by Tony Chang.
1565
1566         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
1567         https://bugs.webkit.org/show_bug.cgi?id=45441
1568
1569         Added TextInputController::hasSpellingMarker().
1570         
1571         * DumpRenderTree/chromium/TextInputController.cpp:
1572         (TextInputController::TextInputController):
1573         (TextInputController::hasSpellingMarker):
1574         * DumpRenderTree/chromium/TextInputController.h:
1575
1576 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
1577
1578         Unreviewed, build fix.
1579
1580         My last change accidentally contained a local change to the
1581         rebaselinig script; webkit-patch land picked it up without telling
1582         me and committed it :(
1583
1584         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1585
1586 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
1587
1588         Reviewed by Anders Carlsson.
1589
1590         Attempt to fix Windows MiniBrowser build (untested)
1591         https://bugs.webkit.org/show_bug.cgi?id=45609
1592
1593         * MiniBrowser/win/BrowserView.cpp:
1594         (runJavaScriptConfirm):
1595         (runJavaScriptPrompt):
1596
1597 2010-09-11  Sam Weinig  <sam@webkit.org>
1598
1599         Reviewed by Maciej Stachowiak.
1600
1601         Fix zoom related tests when testing WebKit2.
1602
1603         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1604         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
1605
1606 2010-09-11  Sam Weinig  <sam@webkit.org>
1607
1608         Reviewed by Dan Bernstein.
1609
1610         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
1611         <rdar://problem/8359252>
1612         https://bugs.webkit.org/show_bug.cgi?id=45605
1613
1614         * MiniBrowser/mac/BrowserWindowController.m:
1615         (setStatusText):
1616         (contentsSizeChanged):
1617         (-[BrowserWindowController awakeFromNib]):
1618         * MiniBrowser/win/BrowserView.cpp:
1619         (runJavaScriptConfirm):
1620         (runJavaScriptPrompt):
1621         (setStatusText):
1622         (contentsSizeChanged):
1623         (BrowserView::create):
1624         * WebKitTestRunner/TestController.cpp:
1625         (WTR::createOtherPage):
1626         (WTR::TestController::initialize):
1627
1628 2010-09-11  Sam Weinig  <sam@webkit.org>
1629
1630         Reviewed by Dan Bernstein.
1631
1632         Add callback mechanism for the getting the source of a frame
1633         <rdar://problem/8364681>
1634         https://bugs.webkit.org/show_bug.cgi?id=45604
1635
1636         Add ability to dump the main frame's source to the console.
1637
1638         * MiniBrowser/mac/BrowserWindowController.h:
1639         * MiniBrowser/mac/BrowserWindowController.m:
1640         (-[BrowserWindowController dumpSourceToConsole:]):
1641         * MiniBrowser/mac/MainMenu.xib:
1642
1643 2010-09-11  Eric Seidel  <eric@webkit.org>
1644
1645         Reviewed by Adam Barth.
1646
1647         Remove unneeded Empty Queue messages
1648         https://bugs.webkit.org/show_bug.cgi?id=45602
1649
1650         We already have a /gc job to delete these.
1651         recentstatus.py is already smart enough to use the
1652         most recent of the workitems last update or the most recent status,
1653         so removing these should not change the _last_status_date() return
1654         value more than a few milliseconds.
1655
1656         These messages just spam the recent status log.
1657
1658         * Scripts/webkitpy/tool/commands/queues.py:
1659
1660 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1661
1662         Reviewed by Adam Barth.
1663
1664         Fix Python exception when generating synthetic patch IDs
1665         https://bugs.webkit.org/show_bug.cgi?id=45592
1666
1667         Can't concatenate strings and numbers directly.
1668
1669         * QueueStatusServer/handlers/queuestatus.py:
1670
1671 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1672
1673         Reviewed by Adam Barth.
1674
1675         Group statuses in queue status by patch ID
1676         https://bugs.webkit.org/show_bug.cgi?id=45588
1677
1678         Group statuses by patch ID so that the status page is easier
1679         to scan.
1680
1681         * QueueStatusServer/handlers/queuestatus.py:
1682         * QueueStatusServer/stylesheets/dashboard.css:
1683         (.status-group):
1684         (.status-bug):
1685         (.status-group ul):
1686         (.status-group ul li):
1687         (.status-group ul li:hover):
1688         (.status-cell):
1689         (.status-cell:hover):
1690         (.status-cell.pass):
1691         (.status-cell.fail):
1692         (.status-cell.pending):
1693         (.status-cell.error):
1694         * QueueStatusServer/templates/dashboard.html:
1695         * QueueStatusServer/templates/queuestatus.html:
1696
1697 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1698
1699         Reviewed by Tony Chang.
1700
1701         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1702         https://bugs.webkit.org/show_bug.cgi?id=45479
1703
1704         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1705         implementation in ResourceLoadDelegate in the Mac port).
1706
1707         * DumpRenderTree/chromium/LayoutTestController.cpp:
1708         (LayoutTestController::LayoutTestController):
1709         (LayoutTestController::dumpResourceResponseMIMETypes):
1710         (LayoutTestController::reset):
1711         * DumpRenderTree/chromium/LayoutTestController.h:
1712         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1713         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1714         * DumpRenderTree/chromium/TestShell.h:
1715         (TestShell::shouldDumpResourceResponseMIMETypes):
1716         * DumpRenderTree/chromium/WebViewHost.cpp:
1717         (WebViewHost::didReceiveResponse):
1718
1719 2010-09-11  Eric Seidel  <eric@webkit.org>
1720
1721         Reviewed by Adam Barth.
1722
1723         queues.webkit.org should expose /remote_api for data upload/download
1724         https://bugs.webkit.org/show_bug.cgi?id=45559
1725
1726         * QueueStatusServer/app.yaml:
1727          - /remote_api is a standard app-engine service which allows use of
1728            the bulk uploader for data upload/download.  Exposing this
1729            (for admin access only) allows us to use 
1730
1731 2010-09-10  Sam Weinig  <sam@webkit.org>
1732
1733         Reviewed by Dan Bernstein.
1734
1735         Add zoom support to WebKit2 API
1736         <rdar://problem/7660657>
1737         https://bugs.webkit.org/show_bug.cgi?id=45585
1738
1739         - Add zoom options to MiniBrowser that mimic Safari's options using
1740           the new WebKit2 zoom APIs.
1741         - Switch uses of float for the zoom APIs to use double.
1742
1743         * MiniBrowser/mac/BrowserWindowController.h:
1744         * MiniBrowser/mac/BrowserWindowController.m:
1745         (-[BrowserWindowController initWithPageNamespace:]):
1746         (-[BrowserWindowController validateMenuItem:]):
1747         (-[BrowserWindowController validateUserInterfaceItem:]):
1748         (-[BrowserWindowController currentZoomFactor]):
1749         (-[BrowserWindowController setCurrentZoomFactor:]):
1750         (-[BrowserWindowController canZoomIn]):
1751         (-[BrowserWindowController zoomIn:]):
1752         (-[BrowserWindowController canZoomOut]):
1753         (-[BrowserWindowController zoomOut:]):
1754         (-[BrowserWindowController canResetZoom]):
1755         (-[BrowserWindowController resetZoom:]):
1756         (-[BrowserWindowController toggleZoomMode:]):
1757         * MiniBrowser/mac/MainMenu.xib:
1758         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1759         (WTR::EventSendingController::textZoomIn):
1760         (WTR::EventSendingController::textZoomOut):
1761         (WTR::EventSendingController::zoomPageIn):
1762         (WTR::EventSendingController::zoomPageOut):
1763
1764 2010-09-10  Robert Hogan  <robert@webkit.org>
1765
1766         Reviewed by Andreas Kling.
1767
1768         [Qt] Fix crash in DRT in standalone mode
1769
1770         https://bugs.webkit.org/show_bug.cgi?id=45454
1771
1772         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1773         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1774
1775 2010-09-10  Sam Weinig  <sam@webkit.org>
1776
1777         Reviewed by Darin Adler.
1778
1779         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
1780         Precursor to <rdar://problem/7660657>
1781         https://bugs.webkit.org/show_bug.cgi?id=45522
1782
1783         Update for changes to the Bundle API to allow separate control of page and text zoom
1784         levels.
1785
1786         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1787         (WTR::EventSendingController::textZoomIn):
1788         (WTR::EventSendingController::textZoomOut):
1789         (WTR::EventSendingController::zoomPageIn):
1790         (WTR::EventSendingController::zoomPageOut):
1791         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1792         (WTR::InjectedBundlePage::reset):
1793
1794 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
1795
1796         Reviewed by Andreas Kling.
1797
1798         [Qt] Support click event for notifications
1799         https://bugs.webkit.org/show_bug.cgi?id=44836
1800
1801         Add support for simulateDesktopNotificationClick by calling
1802         back to DumpRenderTreeSupportQt.cpp.
1803
1804         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1805         (LayoutTestController::simulateDesktopNotificationClick):
1806         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1807
1808 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
1809
1810         Reviewed by Eric Seidel.
1811
1812         Update queue status when patches fail their first land attempt
1813         https://bugs.webkit.org/show_bug.cgi?id=45583
1814
1815         Add a few more _update_status calls to make it more obvious if a patch is 
1816         being retried because tests failed.
1817
1818         * Scripts/webkitpy/tool/commands/queues.py:
1819
1820 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
1821
1822         Reviewed by Andreas Kling.
1823
1824         [Qt] MiniBrowser crashes with multiply windows when closing one of them
1825         https://bugs.webkit.org/show_bug.cgi?id=45536
1826
1827         * MiniBrowser/qt/BrowserView.cpp:
1828         (BrowserView::BrowserView): Reference the context instead of adopting it
1829         because it can be shared across different views.
1830
1831 2010-09-10  Tony Chang  <tony@chromium.org>
1832
1833         Unreviewed, rolling out r67241.
1834         http://trac.webkit.org/changeset/67241
1835         https://bugs.webkit.org/show_bug.cgi?id=44709
1836
1837         Accidentally committed.
1838
1839         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1840         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1841
1842 2010-09-10  Tony Chang  <tony@chromium.org>
1843
1844         Reviewed by Ojan Vafai.
1845
1846         deduplicate-tests should be runnable from any WebKit directory
1847         https://bugs.webkit.org/show_bug.cgi?id=44709
1848
1849         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1850         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1851
1852 2010-09-10  Tony Chang  <tony@chromium.org>
1853
1854         Unreviewed, rolling out r67216.
1855         http://trac.webkit.org/changeset/67216
1856         https://bugs.webkit.org/show_bug.cgi?id=44709
1857
1858         Broke
1859
1860         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1861         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1862
1863 2010-09-10  Tony Chang  <tony@chromium.org>
1864
1865         Reviewed by Ojan Vafai.
1866
1867         deduplicate-tests should be runnable from any WebKit directory
1868         https://bugs.webkit.org/show_bug.cgi?id=44709
1869
1870         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1871         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1872
1873 2010-09-09  Hans Wennborg  <hans@chromium.org>
1874
1875         Reviewed by Jeremy Orlow.
1876
1877         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
1878         https://bugs.webkit.org/show_bug.cgi?id=45460
1879
1880         This enables DumpRenderTree to run layout tests for DeviceOrientation.
1881
1882         Also declare the LayoutTestController destructor out-of-line.
1883         Otherwise the implicit destructor would cause compiler errors because
1884         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
1885
1886         * DumpRenderTree/chromium/LayoutTestController.cpp:
1887         (LayoutTestController::~LayoutTestController):
1888         (LayoutTestController::setMockDeviceOrientation):
1889         (LayoutTestController::deviceOrientationClient):
1890         * DumpRenderTree/chromium/LayoutTestController.h:
1891         * DumpRenderTree/chromium/WebViewHost.cpp:
1892         (WebViewHost::deviceOrientationClient):
1893         * DumpRenderTree/chromium/WebViewHost.h:
1894
1895 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1896
1897         Unreviewed, rolling out r67119.
1898         http://trac.webkit.org/changeset/67119
1899         https://bugs.webkit.org/show_bug.cgi?id=45505
1900
1901         Extra newlines in results (Requested by tony^work on #webkit).
1902
1903         * DumpRenderTree/chromium/LayoutTestController.cpp:
1904         (LayoutTestController::LayoutTestController):
1905         (LayoutTestController::reset):
1906         * DumpRenderTree/chromium/LayoutTestController.h:
1907         * DumpRenderTree/chromium/TestShell.h:
1908         * DumpRenderTree/chromium/WebViewHost.cpp:
1909         (printResponseDescription):
1910         (printNodeDescription):
1911         (printRangeDescription):
1912         (WebViewHost::shouldBeginEditing):
1913         (WebViewHost::shouldEndEditing):
1914         (WebViewHost::shouldInsertNode):
1915         (WebViewHost::shouldChangeSelectedRange):
1916         (WebViewHost::shouldDeleteRange):
1917         (WebViewHost::shouldApplyStyle):
1918         (WebViewHost::didBeginEditing):
1919         (WebViewHost::didChangeSelection):
1920         (WebViewHost::didChangeContents):
1921         (WebViewHost::didEndEditing):
1922         (WebViewHost::decidePolicyForNavigation):
1923         (WebViewHost::didCancelClientRedirect):
1924         (WebViewHost::didStartProvisionalLoad):
1925         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1926         (WebViewHost::didFailProvisionalLoad):
1927         (WebViewHost::didCommitProvisionalLoad):
1928         (WebViewHost::didFinishDocumentLoad):
1929         (WebViewHost::didHandleOnloadEvents):
1930         (WebViewHost::didFailLoad):
1931         (WebViewHost::didFinishLoad):
1932         (WebViewHost::didChangeLocationWithinPage):
1933         (WebViewHost::willSendRequest):
1934         (WebViewHost::didReceiveResponse):
1935         (WebViewHost::didFinishResourceLoad):
1936         (WebViewHost::didFailResourceLoad):
1937         (WebViewHost::didDisplayInsecureContent):
1938         (WebViewHost::didRunInsecureContent):
1939         (WebViewHost::printFrameDescription):
1940
1941 2010-09-09  Michael Saboff  <msaboff@apple.com>
1942
1943         Unreviewed, adding myself to committers list.
1944
1945         * Scripts/webkitpy/common/config/committers.py:
1946
1947 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1948
1949         Reviewed by Tony Chang.
1950
1951         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1952         https://bugs.webkit.org/show_bug.cgi?id=45479
1953
1954         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1955         implementation in ResourceLoadDelegate in the Mac port).
1956
1957         * DumpRenderTree/chromium/LayoutTestController.cpp:
1958         (LayoutTestController::LayoutTestController):
1959         (LayoutTestController::dumpResourceResponseMIMETypes):
1960         (LayoutTestController::reset):
1961         * DumpRenderTree/chromium/LayoutTestController.h:
1962         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1963         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1964         * DumpRenderTree/chromium/TestShell.h:
1965         (TestShell::shouldDumpResourceResponseMIMETypes):
1966         * DumpRenderTree/chromium/WebViewHost.cpp:
1967         (WebViewHost::didReceiveResponse):
1968
1969 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1970
1971         Reviewed by Daniel Bates.
1972
1973         svn-apply tries to delete directories it shouldn't
1974         https://bugs.webkit.org/show_bug.cgi?id=45424
1975
1976         isDirectoryEmptyForRemoval had the wrong check. If an item in the
1977         directory is itself a directory, then the directory is definitely
1978         not empty.
1979
1980         * Scripts/svn-apply:
1981
1982 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
1983
1984         Fixing GTK and windows build failure.
1985
1986         AX: Support AccessibilityTextMarkers in DRT
1987         https://bugs.webkit.org/show_bug.cgi?id=44778
1988
1989         * DumpRenderTree/AccessibilityTextMarker.h:
1990         (AccessibilityTextMarker::platformTextMarker):
1991         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1992         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1993         (AccessibilityTextMarker::platformTextMarker):
1994         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1995
1996 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
1997
1998         Reviewed by David Kilzer.
1999
2000         AX: Support AccessibilityTextMarkers in DRT
2001         https://bugs.webkit.org/show_bug.cgi?id=44778
2002
2003         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
2004         that WebCore uses when vending information about its VisiblePositions through AX.
2005
2006         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
2007         methods for encapsulating and checking equality.
2008
2009         This will allow future bug fixes in the text marker system to be adequately tested.
2010
2011         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
2012         (toTextMarker):
2013         (isMarkerEqualCallback):
2014         (markerFinalize):
2015         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
2016         (AccessibilityTextMarker::getJSClass):
2017         (toTextMarkerRange):
2018         (isMarkerRangeEqualCallback):
2019         (markerRangeFinalize):
2020         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
2021         (AccessibilityTextMarkerRange::getJSClass):
2022         * DumpRenderTree/AccessibilityTextMarker.h: Added.
2023         (AccessibilityTextMarker::platformTextMarker):
2024         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2025         (AccessibilityTextMarker::AccessibilityTextMarker):
2026         (AccessibilityTextMarker::~AccessibilityTextMarker):
2027         (AccessibilityTextMarker::isEqual):
2028         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2029         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2030         (AccessibilityTextMarkerRange::isEqual):
2031         * DumpRenderTree/AccessibilityUIElement.cpp:
2032         (textMarkerRangeForElementCallback):
2033         (textMarkerRangeLengthCallback):
2034         (textMarkerRangeForMarkersCallback):
2035         (startTextMarkerForTextMarkerRangeCallback):
2036         (endTextMarkerForTextMarkerRangeCallback):
2037         (accessibilityElementForTextMarkerCallback):
2038         (AccessibilityUIElement::textMarkerRangeForElement):
2039         (AccessibilityUIElement::textMarkerRangeLength):
2040         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2041         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2042         (AccessibilityUIElement::accessibilityElementForTextMarker):
2043         (AccessibilityUIElement::getJSClass):
2044         * DumpRenderTree/AccessibilityUIElement.h:
2045         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2046         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
2047         (AccessibilityTextMarker::AccessibilityTextMarker):
2048         (AccessibilityTextMarker::~AccessibilityTextMarker):
2049         (AccessibilityTextMarker::isEqual):
2050         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2051         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2052         (AccessibilityTextMarkerRange::isEqual):
2053         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2054         (AccessibilityUIElement::textMarkerRangeForElement):
2055         (AccessibilityUIElement::textMarkerRangeLength):
2056         (AccessibilityUIElement::textMarkerRangeForMarkers):
2057         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2058         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2059         (AccessibilityUIElement::accessibilityElementForTextMarker):
2060         * DumpRenderTree/win/DumpRenderTree.vcproj:
2061
2062 2010-08-25  Tony Chang  <tony@chromium.org>
2063
2064         Reviewed by Ojan Vafai.
2065
2066         don't delete duplicates needed because of intermediate results
2067         https://bugs.webkit.org/show_bug.cgi?id=44653
2068
2069         Also, output the full path so we can pipe the output to rm.
2070
2071         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2072         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2073
2074 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
2075
2076         Reviewed by Andreas Kling.
2077
2078         [Qt] MiniBrowser does not starts properly
2079         https://bugs.webkit.org/show_bug.cgi?id=45459
2080
2081         Do not try set up the first window by calling newWindow on a
2082         newly created BrowserWindow since it creates a new object.
2083         * MiniBrowser/qt/BrowserWindow.cpp:
2084         (BrowserWindow::BrowserWindow):
2085         * MiniBrowser/qt/main.cpp:
2086         (main):
2087
2088 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
2089
2090         Reviewed by Xan Lopez.
2091
2092         [GTK] Get ImageDiff building on Win32
2093         https://bugs.webkit.org/show_bug.cgi?id=45353
2094
2095         * DumpRenderTree/gtk/ImageDiff.cpp:
2096         (main): Switch from using strtok to g_strsplit.
2097
2098 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
2099
2100         Reviewed by Andreas Kling.
2101
2102         [Qt] Modify load method of MiniBrowser's BrowserView class
2103         https://bugs.webkit.org/show_bug.cgi?id=45442
2104
2105         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
2106
2107         * MiniBrowser/qt/BrowserView.cpp:
2108         (BrowserView::load):
2109         * MiniBrowser/qt/BrowserView.h:
2110         * MiniBrowser/qt/BrowserWindow.cpp:
2111         (BrowserWindow::load):
2112
2113 2010-09-09  Tony Chang  <tony@chromium.org>
2114
2115         Reviewed by Ojan Vafai.
2116
2117         fix show_results in new-run-webkit-tests
2118         https://bugs.webkit.org/show_bug.cgi?id=45413
2119
2120         * Scripts/webkitpy/layout_tests/port/chromium.py:
2121
2122 2010-09-08  Victor Wang  <victorw@chromium.org>
2123
2124         Reviewed by Ojan Vafai.
2125
2126         [Chromium] Fix test results server to make sure
2127         it does not have corrupted data.
2128
2129         results.json file size coulbe be >1M and we split
2130         the data into multiple data store entries in this
2131         case. This patch fixes the issue that the data may
2132         be corrupted if data store error happens in the middle
2133         of saving multiple entries.
2134
2135         https://bugs.webkit.org/show_bug.cgi?id=45063
2136
2137         * TestResultServer/model/datastorefile.py:
2138
2139 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
2140
2141         Reviewed by Kenneth Rohde Christiansen.
2142
2143         Fix ignoring return value warning in case of gcc 4.4.4
2144         https://bugs.webkit.org/show_bug.cgi?id=45384
2145
2146         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2147         (testPostURLFile):
2148         If fwrite have written zero byte then the testPostURLFile function
2149         returns with false as tempFile can't be opened.
2150         * DumpRenderTree/qt/ImageDiff.cpp:
2151         (main):
2152         Put fwrite function into an if condition without body to avoid
2153         warning. It is safe because this function writes to the stdout.
2154
2155 2010-09-08  Satish Sampath  <satish@chromium.org>
2156
2157         Unreviewed, adding myself to committers list.
2158
2159         * Scripts/webkitpy/common/config/committers.py:
2160
2161 2010-09-08  Hans Wennborg  <hans@chromium.org>
2162
2163         Unreviewed.
2164
2165         Adding myself as a committer in committers.py.
2166
2167         * Scripts/webkitpy/common/config/committers.py:
2168
2169 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
2170
2171         Reviewed by Simon Hausmann.
2172
2173         [Qt] Refactor MiniBrowser 
2174         https://bugs.webkit.org/show_bug.cgi?id=45173
2175
2176         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
2177
2178         * MiniBrowser/qt/BrowserView.cpp: Added.
2179         (createNewPage):
2180         (BrowserView::BrowserView):
2181         (BrowserView::resizeEvent):
2182         (BrowserView::load):
2183         (BrowserView::view):
2184         * MiniBrowser/qt/BrowserView.h: Added.
2185         (BrowserView::~BrowserView):
2186         * MiniBrowser/qt/BrowserWindow.cpp:
2187         * MiniBrowser/qt/BrowserWindow.h:
2188         * MiniBrowser/qt/MiniBrowser.pro:
2189
2190 2010-09-08  Adam Barth  <abarth@webkit.org>
2191
2192         Rubber-stamped by Eric Seidel.
2193
2194         Rename DocLoader to CachedResourceLoader because that's what it does.
2195
2196         * Scripts/do-webcore-rename:
2197
2198 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
2199
2200         Reviewed by Ojan Vafai.
2201
2202         Enable incremental results.json generation for non-layout tests.
2203         https://bugs.webkit.org/show_bug.cgi?id=45315
2204
2205         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
2206
2207         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
2208
2209
2210 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
2211
2212         Unreviewed, build fix
2213
2214         Missed one test in mac_unittest.py in previous change; for some
2215         reason the method is listed twice. I will fix both for now, but will
2216         figure this out in a later, not-time-sensitive patch.
2217
2218         https://bugs.webkit.org/show_bug.cgi?id=45357
2219
2220         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2221
2222 2010-09-07  Kent Tamura  <tkent@chromium.org>
2223
2224         Reviewed by Tony Chang.
2225
2226         test-webkitpy: Fix load error of
2227         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
2228         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
2229
2230         * Scripts/webkitpy/layout_tests/port/server_process.py:
2231           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
2232           and we don't use server_process.py on Win32 Python. However
2233           unittest.py tries to load everything in a module.
2234
2235 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
2236
2237         Reviewed by Kent Tamura.
2238
2239         Fix regression introduced in previous change to new-run-webkit-tests
2240         (bug 45090) to not try to run unittests for the Mac implementation
2241         of the Port interface if we aren't running on a Mac.
2242
2243         Also fix the overrides implementation mock in the chromium unittests
2244         to fix the case where there are overrides checked in that cause
2245         problems.
2246
2247         https://bugs.webkit.org/show_bug.cgi?id=45357
2248
2249         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2250         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2251         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2252
2253 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
2254
2255         Reviewed by Ojan Vafai.
2256
2257         new-run-webkit-tests: still more unit tests
2258
2259         Clean up and remove unnecessary code. Biggest notable change is
2260         moving the chromium-specific imagediff code from port/base to
2261         port/chromium.
2262
2263         Add more unit tests for run_webkit_tests.py, port/base.py,
2264         port/factory.py, port/dryrun.py, and
2265         layout_package/dump_render_tree_thread.py
2266
2267         This covers almost all of the generic and test code paths except for
2268         a few error paths involving invalid or port-specific command line
2269         arguments, and the code path for uploading results files to the
2270         buildbots.
2271         
2272         https://bugs.webkit.org/show_bug.cgi?id=45090
2273
2274         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
2275         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2276         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2277         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2278         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2279         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2280         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
2281         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
2282         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2283         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
2284         * Scripts/webkitpy/layout_tests/port/base.py:
2285         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2286         * Scripts/webkitpy/layout_tests/port/chromium.py:
2287         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2288         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2289         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2290         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
2291         * Scripts/webkitpy/layout_tests/port/server_process.py:
2292         * Scripts/webkitpy/layout_tests/port/test.py:
2293         * Scripts/webkitpy/layout_tests/port/webkit.py:
2294         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2295         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2296
2297 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
2298
2299         Reviewed by Darin Adler.
2300
2301         Provide a way to trigger a <select multiple> onchange event on changes
2302         https://bugs.webkit.org/show_bug.cgi?id=45192
2303
2304         Adds a selector on ObjCController for testing
2305         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
2306         its different uses.
2307
2308         * DumpRenderTree/mac/ObjCController.m:
2309         (+[ObjCController isSelectorExcludedFromWebScript:]):
2310         (+[ObjCController webScriptNameForSelector:]):
2311         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
2312
2313 2010-09-07  James Robinson  <jamesr@chromium.org>
2314
2315         Rubber-stamped by Dimitri Glazkov.
2316
2317         Move myself from the committer to the reviewer list.
2318
2319         * Scripts/webkitpy/common/config/committers.py:
2320
2321 2010-09-07  Tony Chang  <tony@chromium.org>
2322
2323         Reviewed by Darin Fisher.
2324
2325         [chromium] Make a public flag for how DRT generates bitmaps on Linux
2326         https://bugs.webkit.org/show_bug.cgi?id=45133
2327
2328         * DumpRenderTree/chromium/TestShell.cpp:
2329         (TestShell::dumpImage):
2330
2331 2010-09-07  Kent Tamura  <tkent@chromium.org>
2332
2333         Reviewed by Dimitri Glazkov.
2334
2335         [DRT/Chromium] Implement --check-layout-test-sys-deps
2336         https://bugs.webkit.org/show_bug.cgi?id=45283
2337
2338         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2339         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
2340         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
2341         * DumpRenderTree/chromium/TestShellGtk.cpp:
2342         (checkLayoutTestSystemDependencies): Add an empty implementation.
2343         * DumpRenderTree/chromium/TestShellMac.mm:
2344         (checkLayoutTestSystemDependencies): Add an empty implementation.
2345         * DumpRenderTree/chromium/TestShellWin.cpp:
2346         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
2347
2348 2010-09-07  Jessie Berlin  <jberlin@apple.com>
2349
2350         Unreviewed. Mac build fix.
2351
2352         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2353         (didClearWindowObjectForFrame):
2354
2355 2010-09-07  Jessie Berlin  <jberlin@apple.com>
2356
2357         Reviewed by Darin Adler.
2358
2359         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
2360         https://bugs.webkit.org/show_bug.cgi?id=45217
2361         
2362         Make WebKitTestRunner work with this change.
2363
2364         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2365         (WTR::InjectedBundlePage::didClearWindowForFrame):
2366         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
2367         WebFrameLoaderClient.
2368         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2369
2370 2010-09-07  Philippe Normand  <pnormand@igalia.com>
2371
2372         Unreviewed, build fix.
2373
2374         webkit-patch command to find the ports covering a specific layout test
2375         https://bugs.webkit.org/show_bug.cgi?id=42832
2376
2377         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
2378         tests are present when building the expectations. This is needed
2379         for the unittests.
2380
2381 2010-09-06  Philippe Normand  <pnormand@igalia.com>
2382
2383         Reviewed by Adam Barth.
2384
2385         webkit-patch command to find the ports covering a specific layout test
2386         https://bugs.webkit.org/show_bug.cgi?id=42832
2387
2388         To use it: webkit-patch skipped-ports some/layout/test.html
2389
2390         * Scripts/webkitpy/layout_tests/port/base.py:
2391         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2392         * Scripts/webkitpy/layout_tests/port/chromium.py:
2393         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2394         * Scripts/webkitpy/layout_tests/port/factory.py:
2395         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2396         * Scripts/webkitpy/layout_tests/port/test.py:
2397         * Scripts/webkitpy/layout_tests/port/webkit.py:
2398         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2399         * Scripts/webkitpy/tool/commands/queries.py:
2400         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2401         * Scripts/webkitpy/tool/main.py:
2402         * Scripts/webkitpy/tool/mocktool.py:
2403
2404 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2405
2406         Reviewed by Eric Seidel.
2407
2408         [NRWT] Add temp directory to all running drivers.
2409         https://bugs.webkit.org/show_bug.cgi?id=45261
2410
2411         * Scripts/webkitpy/layout_tests/port/webkit.py:
2412
2413 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
2414
2415         Reviewed by Kent Tamura.
2416
2417         [Chromium/DRT] Empty out user stylesheet after each test run.
2418         https://bugs.webkit.org/show_bug.cgi?id=45282
2419
2420         This should significantly cut down on the number of the mysterious flaky tests
2421         whose diffs looked like the page was blown up to a very lage size. This
2422         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
2423         which set the base body font to 100px.
2424
2425         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
2426         the same thread failed.
2427
2428         * DumpRenderTree/chromium/TestShell.cpp:
2429         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
2430
2431 2010-09-06  Kent Tamura  <tkent@chromium.org>
2432
2433         Reviewed by Dimitri Glazkov.
2434
2435         [DRT/Chromium] Do not generate pixel results for text/plain resources
2436         https://bugs.webkit.org/show_bug.cgi?id=45253
2437
2438         * DumpRenderTree/chromium/TestShell.cpp:
2439         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
2440
2441 2010-09-06  Ojan Vafai  <ojan@chromium.org>
2442
2443         Reviewed by Kent Tamura.
2444
2445         print out correct error when a DRT thread dies in NRWT
2446         https://bugs.webkit.org/show_bug.cgi?id=45281
2447
2448         Not sure why, but with the parens, python 2.6.5 on Linux
2449         gives an error that raise takes 5 arguments and 0 were given.
2450         Didn't test other platforms or python versions, but putting it
2451         all on one line fixes it and correctly prints the exception
2452         from the DRT thread.
2453
2454         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2455
2456 2010-09-06  Eric Seidel  <eric@webkit.org>
2457
2458         Unreviewed, just adding some emails from lists.webkit.org.
2459
2460         Update committers.py to include emails from lists.webkit.org
2461         as found by the validate-committer-lists script.
2462
2463         * Scripts/webkitpy/common/config/committers.py:
2464
2465 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2466
2467         Reviewed by Xan Lopez.
2468
2469         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
2470         https://bugs.webkit.org/show_bug.cgi?id=45213
2471
2472         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2473         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
2474         have to surround the invocation with #ifdefs.
2475         (useLongRunningServerMode): Added.
2476         (runTestingServerLoop): Added.
2477         (initializeGlobalsFromCommandLineOptions): Added.
2478         (runTest): Removed ifdefs.
2479         (main): Use new helper functions.
2480
2481 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2482
2483         Reviewed by Xan Lopez.
2484
2485         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
2486         https://bugs.webkit.org/show_bug.cgi?id=45235
2487
2488         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
2489         methods of the EventSender.
2490
2491         * DumpRenderTree/gtk/EventSender.cpp:
2492         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
2493         with the current modifiers.
2494         (contextClickCallback): Always send no modifiers when preparing the mouse event.
2495         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
2496         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
2497         (mouseUpCallback): Ditto.
2498
2499 2010-09-05  Peter Kasting  <pkasting@google.com>
2500
2501         Reviewed by Adam Barth.
2502
2503         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
2504         https://bugs.webkit.org/show_bug.cgi?id=45155
2505
2506         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
2507         (EventSender::handleMouseWheel):
2508
2509 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
2510
2511         Reviewed by Joseph Pecoraro.
2512
2513         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
2514         https://bugs.webkit.org/show_bug.cgi?id=45179
2515
2516         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2517         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2518
2519 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
2520
2521         Rubber-stamped by Daniel Bates.
2522
2523         Adding myself as reviewer.
2524
2525         * Scripts/webkitpy/common/config/committers.py:
2526
2527 2010-09-04  Daniel Bates  <dbates@rim.com>
2528
2529         Reviewed by Martin Robinson.
2530
2531         Teach svn-apply/unapply about svn:mergeinfo
2532         https://bugs.webkit.org/show_bug.cgi?id=45236
2533
2534         Recognize the svn:mergeinfo property and ignore it for now.
2535
2536         Currently, svn-apply/unapply recognize only '+' and '-'
2537         property changes within a diff. We should add support
2538         to recognize "Merged" and "Reverse-merged" changes as well.
2539         Because svn:mergeinfo is metadata that is used only by SVN
2540         and tends to be error-prone and/or nuisance (*), we will ignore
2541         it for now.
2542         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
2543
2544         * Scripts/VCSUtils.pm:
2545           - Modified parseSvnProperty() to recognize "Merged" and
2546             "Reverse-merged" as the start of a property value.
2547         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2548           - Added the following unit tests:
2549             "simple: add svn:mergeinfo"
2550             "simple: delete svn:mergeinfo"
2551             "simple: modified svn:mergeinfo"
2552         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2553           - Added the following unit tests:
2554             "simple: add svn:mergeinfo"
2555             "simple: delete svn:mergeinfo"
2556             "simple: modified svn:mergeinfo"
2557             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
2558             "'Merged' change followed by 'Merged' change"
2559             "'Reverse-merged' change followed by 'Reverse-merged' change"
2560         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2561           - Added the following unit tests:
2562             "'Merged' change"
2563             "'Reverse-merged' change"
2564             "'Reverse-merged' change followed by 'Merge' change"
2565             "'Merged' change followed by 'Merge' change"
2566             "'Reverse-merged' change followed by 'Reverse-merged' change"
2567             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
2568
2569 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2570
2571         Reviewed by Kenneth Rohde Christiansen.
2572
2573         [EFL] Move test browser to WebKitTools directory
2574         https://bugs.webkit.org/show_bug.cgi?id=45212
2575
2576         Follow other ports like QT and GTK which moved the test browser to
2577         WebKitTools directory.
2578
2579         * CMakeListsEfl.txt: Added.
2580         * EWebLauncher/main.c: Added.
2581         (print_history):
2582         (zoom_level_set):
2583         (on_ecore_evas_resize):
2584         (title_set):
2585         (viewport_set):
2586         (on_title_changed):
2587         (on_progress):
2588         (on_load_finished):
2589         (on_toolbars_visible_set):
2590         (on_toolbars_visible_get):
2591         (on_statusbar_visible_set):
2592         (on_statusbar_visible_get):
2593         (on_scrollbars_visible_set):
2594         (on_scrollbars_visible_get):
2595         (on_menubar_visible_set):
2596         (on_menubar_visible_get):
2597         (on_tooltip_text_set):
2598         (on_inputmethod_changed):
2599         (on_viewport_changed):
2600         (on_mouse_down):
2601         (on_focus_out):
2602         (on_focus_in):
2603         (on_resized):
2604         (on_key_down):
2605         (on_browser_del):
2606         (on_closeWindow):
2607         (quit):
2608         (browserCreate):
2609         (browserDestroy):
2610         (closeWindow):
2611         (main_signal_exit):
2612         (findThemePath):
2613         (main):
2614
2615 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
2616
2617         Reviewed by Adam Roben.
2618
2619         Set project dependencies so that they build serially. This fixes
2620         issues when running run-webkit-tests if DRT is not built yet.
2621
2622         * DumpRenderTree/DumpRenderTree.sln:
2623
2624 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
2625
2626         Reviewed by Adam Barth.
2627
2628         Fix reading configuraiton in NWRT to work on Windows.
2629         https://bugs.webkit.org/show_bug.cgi?id=45180
2630
2631         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
2632             with the file otherwise.
2633
2634 2010-09-03  Chris Rogers  <crogers@google.com>
2635
2636         Unreviewed
2637
2638         Add myself to the committers list
2639         https://bugs.webkit.org/show_bug.cgi?id=45189
2640
2641         * Scripts/webkitpy/common/config/committers.py:
2642
2643 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
2644
2645         Reviewed by Yury Semikhatsky.
2646
2647         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
2648         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
2649         https://bugs.webkit.org/show_bug.cgi?id=45137
2650
2651         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2652
2653 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2654
2655         Reviewed by Eric Seidel.
2656
2657         Add feature detection support to NRWT.
2658         https://bugs.webkit.org/show_bug.cgi?id=41842
2659
2660         * Scripts/webkitpy/layout_tests/port/base.py:
2661         * Scripts/webkitpy/layout_tests/port/qt.py:
2662         * Scripts/webkitpy/layout_tests/port/webkit.py:
2663         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
2664
2665 2010-09-03  Hironori Bono  <hbono@chromium.org>
2666
2667         Reviewed by Kent Tamura.
2668
2669         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
2670         and implements it for Mac.
2671         https://bugs.webkit.org/show_bug.cgi?id=41832
2672
2673         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
2674         and bind it so we can call it from JavaScript.
2675         (+[TextInputController isSelectorExcludedFromWebScript:]):
2676         (+[TextInputController webScriptNameForSelector:]):
2677         (-[TextInputController hasSpellingMarker:length:]):
2678
2679 2010-09-02  Eric Seidel  <eric@webkit.org>
2680
2681         Reviewed by Adam Barth.
2682
2683         Add a unit test for commit-queue retries
2684         https://bugs.webkit.org/show_bug.cgi?id=45162
2685
2686         I think commit-queue retries are not correctly avoiding
2687         build and test on retries.  So I started testing the code.
2688         Unfortunately this test did not find the bug.  But now
2689         that we have the test we might as well keep it.
2690         I also fixed a broken import in validate-committer-lists.
2691
2692         * Scripts/validate-committer-lists:
2693         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2694
2695 2010-09-02  Kent Tamura  <tkent@chromium.org>
2696
2697         Reviewed by Dimitri Glazkov.
2698
2699         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
2700         https://bugs.webkit.org/show_bug.cgi?id=45091
2701
2702         Task.{cpp,h} introduces a simpler version of Chromium
2703         base/task.h. It doesn't have TupleN and Method.
2704
2705         * DumpRenderTree/DumpRenderTree.gypi:
2706          Add Task.cpp and Task.h
2707         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2708         (DRTDevToolsAgent::DRTDevToolsAgent):
2709         (DRTDevToolsAgent::reset):
2710         (DRTDevToolsAgent::asyncCall):
2711         (DRTDevToolsAgent::frontendLoaded):
2712         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2713         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
2714         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2715         (DRTDevToolsClient::DRTDevToolsClient):
2716         (DRTDevToolsClient::~DRTDevToolsClient):
2717         (DRTDevToolsClient::reset):
2718         (DRTDevToolsClient::asyncCall):
2719         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2720         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
2721         * DumpRenderTree/chromium/EventSender.cpp:
2722         (EventSender::EventSender):
2723         (EventSender::reset):
2724         (EventSender::scheduleAsynchronousClick):
2725         * DumpRenderTree/chromium/EventSender.h:
2726         (EventSender::taskList): Added to use MethodTask<T>.
2727         * DumpRenderTree/chromium/LayoutTestController.cpp:
2728         (LayoutTestController::LayoutTestController):
2729         (LayoutTestController::WorkQueue::processWorkSoon):
2730         (LayoutTestController::waitUntilDone):
2731         (LayoutTestController::notifyDone):
2732         (LayoutTestController::reset):
2733         * DumpRenderTree/chromium/LayoutTestController.h:
2734         (LayoutTestController::taskList): Added to use MethodTask<T>.
2735         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
2736         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2737         (deferredDisplayDispatch):
2738         (NotificationPresenter::show):
2739         * DumpRenderTree/chromium/Task.cpp: Added.
2740         * DumpRenderTree/chromium/Task.h: Added.
2741
2742 2010-09-02  Steve Block  <steveblock@google.com>
2743
2744         Reviewed by Adam Barth.
2745
2746         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
2747         https://bugs.webkit.org/show_bug.cgi?id=43181
2748
2749         * DumpRenderTree/mac/DumpRenderTree.mm:
2750         (createWebViewAndOffscreenWindow):
2751         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2752         (LayoutTestController::setMockDeviceOrientation):
2753
2754 2010-08-31  Adam Roben  <aroben@apple.com>
2755
2756         Fix flashiness when resizing the browser window on Windows
2757
2758         Reviewed by Sam Weinig.
2759
2760         * MiniBrowser/win/BrowserWindow.cpp:
2761         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
2762         periodically fill the window with white.
2763
2764 2010-09-02  Peter Kasting  <pkasting@google.com>
2765
2766         Reviewed by Dimitri Glazkov.
2767
2768         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
2769         https://bugs.webkit.org/show_bug.cgi?id=45073
2770
2771         * DumpRenderTree/chromium/EventSender.cpp:
2772         (EventSender::EventSender):
2773         (EventSender::mouseScrollBy):
2774         (EventSender::continuousMouseScrollBy):
2775         (EventSender::sendCurrentTouchEvent):
2776         (EventSender::handleMouseWheel):
2777         * DumpRenderTree/chromium/EventSender.h:
2778         * DumpRenderTree/gtk/EventSender.cpp:
2779         (mouseScrollByCallback):
2780         (continuousMouseScrollByCallback):
2781
2782 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
2783
2784         Reviewed by Tony Chang.
2785
2786         Land a patched version of r66542 - change TestRunner to have an
2787         separate cleanup method and fix the ordering of cleanup between
2788         TestRunner and the printing module, and then wrap everything in a
2789         try/finally block to ensure reliable cleanup without needing to
2790         rely on stuff happening in the destructor of the TestRunner.
2791
2792         Also refactor run_webkit_tests.run() to be much smaller and cleaner
2793         by creating a bunch of helper methods and moving more stuff into
2794         the TestRunner class.
2795
2796         This fixes the crash at the end of the linux test run of
2797         new-run-webkit-tests (and undoes the rollout in 66547).
2798
2799         https://bugs.webkit.org/show_bug.cgi?id=44902
2800
2801         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2802         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2803         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2804         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2805         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2806         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2807         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2808         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2809         * Scripts/webkitpy/layout_tests/port/base.py:
2810         * Scripts/webkitpy/layout_tests/port/test.py:
2811         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2812         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2813
2814 2010-09-01  Mark Rowe  <mrowe@apple.com>
2815
2816         Reviewed by Adam Roben.
2817
2818         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
2819
2820         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2821
2822 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
2823
2824         Reviewed by Adam Roben.
2825
2826         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
2827         and WebKitTestRunner.
2828
2829         * BuildSlaveSupport/win/kill-old-processes:
2830
2831 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2832
2833         Reviewed by Antonio Gomes.
2834
2835         [Qt] Remove obsolete include path from DumpRenderTree.pro
2836
2837         * DumpRenderTree/qt/DumpRenderTree.pro:
2838
2839 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2840
2841         Reviewed by Laszlo Gombos.
2842
2843         [Qt] QWebPage::allowGeolocationRequest should be async API
2844         https://bugs.webkit.org/show_bug.cgi?id=41364
2845
2846         Implements new async API for geolocation permission similar to
2847         Notification. WebPage maintains list of geolocation permission request
2848         QtWebkit and set's when LayoutTestController gets the access from test JS
2849
2850         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2851         (WebCore::WebPage::WebPage):
2852         (WebCore::WebPage::resetSettings):
2853         (WebCore::WebPage::requestPermission):
2854         (WebCore::WebPage::cancelPermission):
2855         (WebCore::WebPage::permissionSet):
2856         (WebCore::DumpRenderTree::DumpRenderTree):
2857         (WebCore::DumpRenderTree::processLine):
2858         (WebCore::DumpRenderTree::geolocationPermissionSet):
2859         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2860         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2861         (LayoutTestController::reset):
2862         (LayoutTestController::setGeolocationPermission):
2863         (LayoutTestController::setGeolocationPermissionCommon):
2864         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2865
2866 2010-09-01  Andras Becsi  <abecsi@webkit.org>
2867
2868         Reviewed by Antti Koivisto.
2869
2870         [Qt] Auto-generate WebKit2 forwarding headers
2871         https://bugs.webkit.org/show_bug.cgi?id=44692
2872
2873         * MiniBrowser/qt/BrowserWindow.h: use source style includes
2874         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
2875         * Scripts/enumerate-included-framework-headers: Removed.
2876
2877 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2878
2879         Reviewed by Adam Barth.
2880
2881         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
2882         https://bugs.webkit.org/show_bug.cgi?id=44789
2883
2884         * Scripts/webkitpy/common/net/bugzilla.py:
2885
2886 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
2887
2888         Reviewed by Adam Barth.
2889
2890         ews: Add support for EFL-EWS
2891         https://bugs.webkit.org/show_bug.cgi?id=44982
2892
2893         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
2894         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
2895         and add it to the ports dict.
2896         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
2897         EflEWS class.
2898         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
2899         a test case for the EFL EWS.
2900
2901 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
2902
2903         Reviewed by Sam Weinig.
2904
2905         https://bugs.webkit.org/show_bug.cgi?id=42195
2906         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
2907
2908         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2909         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
2910         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2911         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
2912         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
2913
2914         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2915         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
2916         which forgets its override.
2917
2918 2010-08-31  Sam Weinig  <sam@webkit.org>
2919
2920         Reviewed by Gavin Barraclough.
2921
2922         WebKitTestRunner needs layoutTestController.addUserStyleSheet
2923         https://bugs.webkit.org/show_bug.cgi?id=42680
2924
2925         WebKitTestRunner needs layoutTestController.addUserScript
2926         https://bugs.webkit.org/show_bug.cgi?id=42681
2927
2928         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2929         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2930         (WTR::InjectedBundle::beginTesting):
2931         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2932         (WTR::LayoutTestController::addUserScript):
2933         (WTR::LayoutTestController::addUserStyleSheet):
2934         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2935
2936 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2937
2938         Unreviewed, rolling out r66542.
2939         http://trac.webkit.org/changeset/66542
2940         https://bugs.webkit.org/show_bug.cgi?id=44902
2941
2942         r66542 - the weird logging dependencies in Python stuck again ...
2943
2944         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
2945         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
2946         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
2947         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
2948         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2949         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2950         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2951         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2952         * Scripts/webkitpy/layout_tests/port/base.py:
2953         * Scripts/webkitpy/layout_tests/port/test.py:
2954         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2955         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2956
2957 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
2958
2959         Reviewed by Tony Chang.
2960
2961         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
2962
2963         * DumpRenderTree/chromium/LayoutTestController.cpp:
2964         (LayoutTestController::LayoutTestController):
2965         (LayoutTestController::markerTextForListItem):
2966         * DumpRenderTree/chromium/LayoutTestController.h:
2967
2968 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2969
2970         Reviewed by Ojan Vafai.
2971
2972         new-run-webkit-tests: add more unit tests
2973
2974         Add more unit tests for new-run-webkit-tests; we now cover all but
2975         the most obscure code paths in the generic code. We still need to
2976         add coverage for the http server and web socket paths, and add better
2977         coverage of the platform-specific logic. Note that the rebaselining
2978         tool is still not well tested.
2979
2980         Also clean up some of the configuration logic for the printing
2981         module and the way it interacts with the Python logging module; that
2982         is a crufty interface, to be certain.
2983         
2984         https://bugs.webkit.org/show_bug.cgi?id=44902
2985
2986         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2987         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2988         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2989         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2990         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2991         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2992         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2993         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2994         * Scripts/webkitpy/layout_tests/port/base.py:
2995         * Scripts/webkitpy/layout_tests/port/test.py:
2996         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2997         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2998
2999 2010-08-31  Darin Adler  <darin@apple.com>
3000
3001         Reviewed by Anders Carlsson.
3002
3003         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
3004         in a debug build when built with certain compilers.
3005
3006 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
3007
3008         Reviewed by Gustavo Noronha Silva.
3009
3010         [GTK] Isolate all GTK+ typedefs into one file
3011         https://bugs.webkit.org/show_bug.cgi?id=44900
3012
3013         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
3014
3015 2010-08-31  Eric Seidel  <eric@webkit.org>
3016
3017         Reviewed by Adam Barth.
3018
3019         Show more status on queue status pages
3020         https://bugs.webkit.org/show_bug.cgi?id=44938
3021
3022         I upped the number of status lines from 6 to 15 --
3023         this has been bugging me for a while...
3024
3025         I also disabled showing the chromium-win EWS queue
3026         since it's been down for almost 5 months now.
3027
3028         * QueueStatusServer/handlers/dashboard.py:
3029         * QueueStatusServer/handlers/queuestatus.py:
3030         * QueueStatusServer/model/queues.py:
3031
3032 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
3033
3034         Reviewed by Antonio Gomes.
3035
3036         [Qt] Read command line arguments and open them as URLs in new windows
3037         https://bugs.webkit.org/show_bug.cgi?id=44944
3038
3039         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
3040
3041         * MiniBrowser/qt/main.cpp:
3042         (main):
3043
3044 2010-08-31  Adrian Perez  <aperez@igalia.com>
3045
3046         Reviewed by Martin Robinson.
3047
3048         Support scripts to run Buildbot slaves under daemontools (gtk related)
3049         https://bugs.webkit.org/show_bug.cgi?id=40053
3050
3051         * BuildSlaveSupport/gtk: Added.
3052         * BuildSlaveSupport/gtk/README: Added.
3053         * BuildSlaveSupport/gtk/buildbot: Added.
3054         * BuildSlaveSupport/gtk/buildbot/log: Added.
3055         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
3056         * BuildSlaveSupport/gtk/buildbot/run: Added.
3057         * BuildSlaveSupport/gtk/crashmon: Added.
3058         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
3059         * BuildSlaveSupport/gtk/crashmon/log: Added.
3060         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
3061         * BuildSlaveSupport/gtk/crashmon/run: Added.
3062         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
3063         * BuildSlaveSupport/gtk/pulseaudio: Added.
3064         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
3065         * BuildSlaveSupport/gtk/xvfb: Added.
3066         * BuildSlaveSupport/gtk/xvfb/log: Added.
3067         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
3068         * BuildSlaveSupport/gtk/xvfb/run: Added.
3069
3070 2010-08-27  John Gregg  <johnnyg@google.com>
3071
3072         Reviewed by David Levin.
3073
3074         Notifications should support a click event.
3075         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
3076         can be simulated during a layout test.  Requires storing a list of active
3077         notifications so that they can be referred to later for clicking.
3078         https://bugs.webkit.org/show_bug.cgi?id=44800
3079
3080         * DumpRenderTree/chromium/LayoutTestController.cpp:
3081         (LayoutTestController::LayoutTestController):
3082         (LayoutTestController::simulateDesktopNotificationClick):
3083         * DumpRenderTree/chromium/LayoutTestController.h:
3084         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3085         (NotificationPresenter::simulateClick):
3086         (NotificationPresenter::show):
3087         (NotificationPresenter::cancel):
3088         (NotificationPresenter::objectDestroyed):
3089         * DumpRenderTree/chromium/NotificationPresenter.h:
3090
3091 2010-08-30  Alice Liu  <alice.liu@apple.com>
3092
3093         Reviewed by Darin Adler.
3094
3095         Add missing parts of didFinishDocumentLoadForFrame
3096         https://bugs.webkit.org/show_bug.cgi?id=44913
3097
3098         * MiniBrowser/mac/BrowserWindowController.m:
3099         (didFinishDocumentLoadForFrame): Added
3100         (-[BrowserWindowController awakeFromNib]): Updated struct
3101         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3102         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
3103         * WebKitTestRunner/TestController.cpp:
3104         (WTR::TestController::initialize): Updated struct
3105
3106 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
3107
3108         Unreviewed: Add myself to the list of Committers.
3109
3110         * Scripts/webkitpy/common/config/committers.py:
3111
3112 2010-08-30  Kent Tamura  <tkent@chromium.org>
3113
3114         Reviewed by Adam Barth.
3115
3116         Fix fast/notifications/notifications-display-close-events.html failure
3117         https://bugs.webkit.org/show_bug.cgi?id=44585
3118
3119         Apply http://crrev.com/48893. We should dispatch display events
3120         asynchronously.
3121
3122         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3123         (deferredDisplayDispatch):
3124         (NotificationPresenter::show):
3125
3126 2010-08-30  Robert Hogan  <robert@webkit.org>
3127
3128         Reviewed by Simon Hausmann.
3129
3130         allow ports with windowed plugins to support windowless plugin tests
3131
3132         https://bugs.webkit.org/show_bug.cgi?id=40730
3133
3134         Ports that implement plugins windowed by default need to have a way of
3135         supporting plugin tests that assume the plugin is windowless. Add this
3136         feature to the tests and support it in the webkit test plugin. Also
3137         add mouse and keyboard event logging to the webkit-test plugin on Unix.
3138
3139         Unskip the following tests on Qt:
3140
3141         plugins/mouse-events.html
3142         plugins/keyboard-events.html
3143         plugins/mouse-events-fixedpos.html
3144
3145         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3146         (pluginSetProperty):
3147         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3148         (NPP_New):
3149         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3150         (webkit_test_plugin_handle_event):
3151
3152 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
3153
3154         [wx] Build fix after addition of fileapi directory in WebCore.
3155
3156         * wx/build/settings.py:
3157
3158 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
3159
3160         Reviewed by Xan Lopez.
3161
3162         Fixed compilation error, now that we have included the
3163         GtkVersioning.h we have to remove some version dependent code from
3164         EventSender.
3165
3166         * DumpRenderTree/gtk/EventSender.cpp:
3167
3168 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
3169
3170         Reviewed by Martin Robinson.
3171
3172         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
3173         are deprecated
3174         https://bugs.webkit.org/show_bug.cgi?id=44787
3175
3176         We have replaced GtkVersioning.cpp with GtkVersioning.c and
3177         created a function (getDefaultGDKPointerDevice) to get the pointer
3178         of the window with the new APIs. We added that function to DRT and
3179         copyandpaste unit test.
3180
3181         * DumpRenderTree/gtk/EventSender.cpp:
3182         (prepareMouseButtonEvent):
3183         (mouseMoveToCallback):
3184         (keyDownCallback):
3185         * GNUmakefile.am:
3186
3187 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
3188
3189         Reviewed by Kenneth Rohde Christiansen.
3190
3191         [Qt] Add new window menu to MiniBrowser
3192
3193         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
3194
3195         * MiniBrowser/qt/BrowserWindow.cpp:
3196         (BrowserWindow::BrowserWindow):
3197         (BrowserWindow::newWindow):
3198         * MiniBrowser/qt/BrowserWindow.h:
3199         * MiniBrowser/qt/main.cpp:
3200         (main):
3201
3202 2010-08-29  James Robinson  <jamesr@chromium.org>
3203
3204         Reviewed by David Levin.
3205
3206         Make failing the download step fail the build
3207         https://bugs.webkit.org/show_bug.cgi?id=44298
3208
3209         If the download step fails on a test bot, this ensures that
3210         the build goes red instead of only the download step going red
3211         and the overall build staying green.
3212
3213         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3214
3215 2010-08-29  Kent Tamura  <tkent@chromium.org>
3216
3217         Reviewed by Dimitri Glazkov.
3218
3219         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
3220         https://bugs.webkit.org/show_bug.cgi?id=44847
3221
3222         * DumpRenderTree/chromium/EventSender.cpp:
3223          Use webkit_support::VKEY_* instead of base::VKEY_*.
3224
3225 2010-08-29  Darin Adler  <darin@apple.com>
3226
3227         https://bugs.webkit.org/show_bug.cgi?id=40589
3228
3229         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
3230         function names.
3231
3232 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3233
3234         Reviewed by Darin Adler.
3235
3236         [iExploder] Add new CSS Properties and HTML Attributes
3237         https://bugs.webkit.org/show_bug.cgi?id=44746
3238
3239         Updated the files with the update-iexploder-cssproperties script
3240         and manually readded the -webkit-binding CSS Property to the list.
3241
3242         * iExploder/htdocs/cssproperties.in:
3243         * iExploder/htdocs/htmlattrs.in:
3244         * iExploder/htdocs/htmltags.in:
3245
3246 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3247
3248         Reviewed by Darin Adler.
3249
3250         Fix Coverage build after the addition of ANGLE
3251         https://bugs.webkit.org/show_bug.cgi?id=44744
3252
3253         ANGLE is using libtool to build a static library and the version of
3254         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
3255         parameters. The easiest way to handle this is to not build ANGLE with
3256         coverage information.
3257
3258         This is achieved by applying the XCode options for each project
3259         separately and exclude ANGLE.
3260
3261         * Scripts/build-webkit: Remove -framework AppKit due link errors.
3262         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
3263
3264 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
3265
3266         [wx] Build fix after directory addition.
3267
3268         * wx/build/settings.py:
3269
3270 2010-08-28  Chris Guillory   <chris.guillory@google.com>
3271
3272         Reviewed by Chris Fleizach.
3273
3274         Add AX notification for childrenChanged
3275         https://bugs.webkit.org/show_bug.cgi?id=44472
3276
3277         * DumpRenderTree/chromium/AccessibilityController.cpp:
3278         (AccessibilityController::AccessibilityController):
3279         (AccessibilityController::reset):
3280         (AccessibilityController::getRootElement):
3281         (AccessibilityController::dumpAccessibilityNotifications):
3282         * DumpRenderTree/chromium/AccessibilityController.h:
3283         (AccessibilityController::shouldDumpAccessibilityNotifications):
3284         * DumpRenderTree/chromium/WebViewHost.cpp:
3285         (WebViewHost::didChangeAccessibilityObjectChildren):
3286         * DumpRenderTree/chromium/WebViewHost.h:
3287
3288 2010-08-28  Eric Seidel  <eric@webkit.org>
3289
3290         Reviewed by Adam Barth.
3291
3292         Update commit-queue failure message
3293         https://bugs.webkit.org/show_bug.cgi?id=44798
3294
3295         The commit-queue auto-restarts itself and has for a very long time.
3296         No need for people to email me to request a restart anymore.
3297
3298         * Scripts/webkitpy/common/net/bugzilla.py:
3299         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3300         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3301
3302 2010-07-27  Jer Noble  <jer.noble@apple.com>
3303
3304         Reviewed by Eric Carlson.
3305
3306         Add JavaScript API to allow a page to go fullscreen.
3307         rdar://problem/6867795
3308         
3309         Added basic full screen support to DumpRenderTree: when a webView requests
3310         that DumpRenderTree go "full screen", just call the provided callback listener object's
3311         will/did Enter/Exit full screen methods.  Also, register a new user default which 
3312         enables full screen support.
3313
3314         * DumpRenderTree/mac/DumpRenderTree.mm:
3315         (resetDefaultsToConsistentValues):
3316         * DumpRenderTree/mac/UIDelegate.mm:
3317         (-[UIDelegate webView:supportsFullscreenForElement:]):
3318         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
3319         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
3320
3321 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
3322
3323         Unreviewed. Add myself to the committers list.
3324
3325         * Scripts/webkitpy/common/config/committers.py:
3326
3327 2010-08-27  Kent Tamura  <tkent@chromium.org>
3328
3329         Reviewed by Pavel Feldman.
3330
3331         [DRT/Chromium] Fix inspector test failures
3332         https://bugs.webkit.org/show_bug.cgi?id=44748
3333
3334         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3335         (DRTDevToolsAgent::createClientMessageLoop):
3336           Returns a valid WebKitClientMessageLoop instance
3337         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3338
3339 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
3340
3341         Add Windows WebKit2 Tester to buildbot
3342         <rdar://problem/7887703>
3343
3344         Reviewed by Dan Bernstein.
3345
3346         * BuildSlaveSupport/build.webkit.org-config/config.json:
3347
3348 2010-08-26  Philippe Normand  <pnormand@igalia.com>
3349
3350         Reviewed by Martin Robinson.
3351
3352         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3353         https://bugs.webkit.org/show_bug.cgi?id=42152
3354
3355         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3356         (LoadHTMLStringItem::invoke): Implementation using
3357         webkit_web_frame_load_string().
3358
3359 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
3360
3361         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
3362         WebKitTestRunner (44331)
3363
3364         Reviewed by Darin Adler.
3365
3366         * WebKitTestRunner/TestController.cpp:
3367         (WTR::TestController::initialize):
3368         The hang occurs when WebKitTestRunner begins launching the WebKit2
3369         web process then exits before it finishes launching. Work around this by
3370         looking for the --print-supported-features argument and exiting without
3371         creating the web process.
3372
3373 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
3374
3375         Reviewed by Tony Chang.
3376
3377         new-run-webkit-tests: add rebaselining tests for test_expectations
3378         
3379         This patch adds more unit tests for the rebaselining code in the
3380         test_expectations module. It doesn't add any tests for
3381         rebaseline_chromium_webkit_tests itself; that will come some other
3382         time.
3383
3384         https://bugs.webkit.org/show_bug.cgi?id=44648
3385
3386         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3387         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3388
3389 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3390
3391         Reviewed by Martin Robinson.
3392
3393         [GTK] Add HTTP caching support
3394         https://bugs.webkit.org/show_bug.cgi?id=44261
3395
3396         Ignore new soup API that we decided to merge into the soup backend
3397         while it is being cooked. It follows the libsoup style, and will
3398         be removed from WebKit as soon as it is merged into libsoup.
3399
3400         * Scripts/webkitpy/style/checker.py:
3401
3402 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3403
3404         Reviewed by Kenneth Rohde Christiansen.
3405
3406         [Qt] DumpRenderTree runs only one test from command mode
3407         https://bugs.webkit.org/show_bug.cgi?id=44012
3408
3409         Enables support to run multiple test files and single
3410         folder containing html files in stand alone mode
3411
3412         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3413         (WebCore::DumpRenderTree::DumpRenderTree):
3414         (WebCore::DumpRenderTree::processArgsLine):
3415         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3416         (WebCore::DumpRenderTree::processLine):
3417         (WebCore::DumpRenderTree::dump):
3418         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3419         (WebCore::DumpRenderTree::setStandAloneMode):
3420         (WebCore::DumpRenderTree::isStandAloneMode):
3421         * DumpRenderTree/qt/main.cpp:
3422         (main):
3423
3424 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
3425
3426         Updating webkitpy test expectations.
3427
3428         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3429
3430 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3431
3432         Reviewed by Eric Seidel.
3433
3434         fix the always squash git config
3435         https://bugs.webkit.org/show_bug.cgi?id=44651
3436
3437         Fix help text and apparently underscores are not allowed
3438         in git config keys.
3439
3440         * Scripts/webkitpy/common/checkout/scm.py:
3441         * Scripts/webkitpy/tool/steps/commit.py:
3442
3443 2010-08-25  Darin Adler  <darin@apple.com>
3444
3445         Reviewed by John Sullivan.
3446
3447         * Scripts/commit-log-editor: Fix perl warning for people who have no
3448         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
3449
3450 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3451
3452         Reviewed by Eric Seidel.
3453
3454         stop blocking commits when the bots are red
3455         https://bugs.webkit.org/show_bug.cgi?id=44644
3456
3457         This check currently is just annoying. It doesn't actually
3458         help keep the tree green. We can always add it back later
3459         if we decide the tree is generally more green.
3460
3461         * Scripts/webkitpy/tool/commands/download_unittest.py:
3462         * Scripts/webkitpy/tool/mocktool.py:
3463         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
3464
3465 2010-08-25  Eric Seidel  <eric@webkit.org>
3466
3467         Reviewed by Simon Fraser.
3468
3469         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
3470         https://bugs.webkit.org/show_bug.cgi?id=38912
3471
3472         I know of nothing else to do but skip all media tests for the cq.
3473
3474         * Scripts/webkitpy/tool/steps/runtests.py:
3475
3476 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3477
3478         Reviewed by Ojan Vafai.
3479
3480         new-run-webkit-tests: add more unit tests for test_expectations
3481         This adds unit tests to cover (almost?) all of the non-rebaselining
3482         functionality.
3483
3484         https://bugs.webkit.org/show_bug.cgi?id=44579
3485
3486         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3487         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3488
3489 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3490
3491         Reviewed by Ojan Vafai.
3492
3493         new-run-webkit-tests: add more unit tests
3494
3495         This change adds more unit tests for the image_diff, test_failures,
3496         and test_files modules, bringing them to 100% coverage (and adds a
3497         couple tests to run_webkit_tests while we're at it).
3498
3499         This test also turns on the "dryrun" port for testing when run on
3500         the mac, increasing coverage in a few other places.
3501
3502         https://bugs.webkit.org/show_bug.cgi?id=44578
3503
3504         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
3505         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
3506         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
3507         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
3508         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
3509         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
3510         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
3511         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
3512         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3513         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
3514         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3515         * Scripts/webkitpy/layout_tests/port/test.py:
3516         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3517
3518 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3519
3520         Reviewed by Ojan Vafai.
3521
3522         new-run-webkit-tests: add more unit tests for layout_package/printing.py
3523
3524         This change adds more unit tests to get the test coverage to 100%
3525         for the printing module. This code is actually pretty crufty and
3526         has some layering violations that need to be cleaned up but I'll
3527         save that for another CL after we get all the unit tests written and
3528         we fix the multithreading issues. At least now we'll be able to tell
3529         if we break things.
3530
3531         https://bugs.webkit.org/show_bug.cgi?id=44576
3532
3533         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3534         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3535
3536 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3537
3538         Reviewed by Adam Barth.
3539
3540         new-run-webkit-tests should respect set-webkit-configuration
3541         https://bugs.webkit.org/show_bug.cgi?id=44633
3542
3543         Moves the getting of the configuration into the base Port so that
3544         chromium ports use it as well. In the downstream chromium port,
3545         this should still just return Release.
3546
3547         * Scripts/webkitpy/layout_tests/port/base.py:
3548         * Scripts/webkitpy/layout_tests/port/webkit.py:
3549
3550 2010-08-25  Tony Chang  <tony@chromium.org>
3551
3552         Not reviewed, changing svn props for a script.
3553
3554         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
3555
3556 2010-08-25  Adam Barth  <abarth@webkit.org>
3557
3558         Reviewed by Eric Seidel.
3559
3560         Remove WebKit2 from core builders
3561         https://bugs.webkit.org/show_bug.cgi?id=44625
3562
3563         This builder was added to the core builders by accident.  It doesn't
3564         appear to be green enough to be a core builder yet.
3565
3566         * Scripts/webkitpy/common/net/buildbot.py:
3567         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3568
3569 2010-08-19  Adam Roben  <aroben@apple.com>
3570
3571         Test that NP_Initialize and NP_GetEntryPoints are called in the
3572         correct order
3573
3574         The order differs between Mac and Windows (see r38858).
3575
3576         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
3577         NP_Initialize when loading QuickTime when running
3578         plugins/embed-attributes-setting.html in WebKit2 on Windows
3579
3580         Reviewed by John Sullivan.
3581
3582         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
3583         a boolean to record whether NP_GetEntryPoints has been called.
3584         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
3585         called yet. This matches Flash and QuickTime's behavior.
3586         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
3587         yet. This matches Silverlight's behavior.
3588
3589 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
3590
3591         Reviewed by Gustavo Noronha Silva.
3592
3593         Cairo and EFL port shouldn't depend on glib.
3594         https://bugs.webkit.org/show_bug.cgi?id=44354
3595
3596         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
3597         adoptPlatformRef.
3598
3599         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3600         (AccessibilityUIElement::isSelected):
3601
3602 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3603
3604         Fix order of Timothy's email address. The script, and
3605         other tools all assume that the first email is the bugzilla address.
3606
3607         * Scripts/webkitpy/common/config/committers.py:
3608
3609 2010-08-24  Kent Tamura  <tkent@chromium.org>
3610
3611         Reviewed by Pavel Feldman.
3612
3613         [DRT/Chromium] Fix 26 inspector test crashes
3614         https://bugs.webkit.org/show_bug.cgi?id=44580
3615
3616         - DRTDevToolsAgent has a reference to the main WebView. So we
3617           should not clear it in closeDevTools() and should clear it in
3618           ~TestShell().
3619         - DRTDevToolsClient has a reference to a DevTools WebView and no
3620           way to update it. So we should delete DRTDevToolsClient instances
3621           in closeDevTools().
3622
3623         * DumpRenderTree/chromium/TestShell.cpp:
3624         (TestShell::~TestShell):
3625         (TestShell::closeDevTools):
3626
3627 2010-08-24  Eric Seidel  <eric@webkit.org>
3628
3629         Reviewed by Adam Barth.
3630
3631         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
3632         https://bugs.webkit.org/show_bug.cgi?id=44584
3633
3634         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3635
3636 2010-08-24  Eric Seidel  <eric@webkit.org>
3637
3638         Reviewed by Adam Barth.
3639
3640         commit-queue and EWS bots should report all failures
3641         https://bugs.webkit.org/show_bug.cgi?id=41820
3642
3643         Right now commit-queue/EWS only report failures when the
3644         patch under testing fails.  We should report all failures
3645         to the status server so that we can diagnose when the bots
3646         are wedged w/o needing to log into the machines.
3647
3648         I also reduced the amount of data we upload since we've seen
3649         timeouts during status upload.
3650
3651         * Scripts/webkitpy/common/system/executive.py:
3652         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3653         * Scripts/webkitpy/tool/commands/queues.py:
3654         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3655
3656 2010-08-24  Eric Seidel  <eric@webkit.org>
3657
3658         Reviewed by Adam Barth.
3659
3660         Remove HTML5 parser testing infrastructure now that we don't need it
3661         https://bugs.webkit.org/show_bug.cgi?id=44581
3662
3663         * DumpRenderTree/mac/DumpRenderTree.mm:
3664         (resetDefaultsToConsistentValues):
3665         (initializeGlobalsFromCommandLineOptions):
3666         * Scripts/old-run-webkit-tests:
3667         * Scripts/test-html5-parser: Removed.
3668
3669 2010-08-24  Kent Tamura  <tkent@chromium.org>
3670
3671         Reviewed by Dimitri Glazkov.
3672
3673         [DRT/Chromium] Fix 28 inspector test crashes
3674         https://bugs.webkit.org/show_bug.cgi?id=44574
3675
3676         Reset DevToolsClient and DevToolsAgent before closing a DevTools
3677         WebView in order to avoid accessing to a deleted WebView instance.
3678
3679         * DumpRenderTree/chromium/TestShell.cpp:
3680         (TestShell::closeDevTools):
3681
3682 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3683
3684         Reviewed by Ojan Vafai.
3685
3686         new-run-webkit-tests: clean up code for test_types, test_failures
3687
3688         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
3689         webkitpy.layout_tests.layout_package.test_failures, and remove
3690         some dead code and otherwise clean up things.
3691
3692         https://bugs.webkit.org/show_bug.cgi?id=44559
3693
3694         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3695         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
3696         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3697         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3698         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3699         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
3700         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3701
3702 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3703
3704         Reviewed by Eric Seidel.
3705
3706         new-run-webkit-tests: revise unit testing strategy for test failures
3707     
3708         This change revamps the way we store test data for new-run-webkit-tests.
3709         Previously we had a few copies of test files from the main test tree.
3710         Now we have a bunch of completely fake test data and use the test
3711         data to generate different kinds of test failures, getting
3712         much better coverage.
3713
3714         https://bugs.webkit.org/show_bug.cgi?id=44556
3715
3716         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
3717         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
3718         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
3719         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
3720         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
3721         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
3722         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
3723         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
3724         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
3725         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
3726         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
3727         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
3728         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
3729         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
3730         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
3731         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
3732         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
3733         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
3734         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
3735         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
3736         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
3737         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
3738         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
3739         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
3740         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
3741         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
3742         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
3743         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
3744         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
3745         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
3746         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
3747         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
3748         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
3749         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
3750         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
3751         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
3752         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
3753         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
3754         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
3755         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
3756         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
3757         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
3758         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
3759         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3760         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
3761         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
3762         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3763         * Scripts/webkitpy/layout_tests/port/test.py:
3764         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3765         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3766
3767 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3768
3769         Reviewed by Eric Seidel.
3770
3771         speed up new-run-webkit-tests unit tests
3772
3773         Add a --no-record-results flag that turns off generating the JSON
3774         results file on every test run. Generating the file requires us to
3775         fetch the old results down from the bots, which can be slow. This
3776         flag is off by default.
3777     
3778         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
3779     
3780         These changes together shorten the test cycle from ~4.5s to ~1.5s
3781         - a 3x speedup.
3782
3783         https://bugs.webkit.org/show_bug.cgi?id=44553
3784
3785         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3786         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3787
3788 2010-08-24  Tony Chang  <tony@chromium.org>
3789
3790         Reviewed by Eric Seidel.
3791
3792         [chromium] fix the platform result fallback order on mac/win
3793         https://bugs.webkit.org/show_bug.cgi?id=44483
3794
3795         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3796
3797 2010-08-24  Xan Lopez  <xlopez@igalia.com>
3798
3799         Reviewed by Martin Robinson.
3800
3801         Set a device to the event struct when building with GTK+ 3.x, it's
3802         mandatory.
3803
3804         * DumpRenderTree/gtk/EventSender.cpp:
3805         (keyDownCallback):
3806
3807 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
3808
3809         Reviewed by Xan Lopez.
3810
3811         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
3812         https://bugs.webkit.org/show_bug.cgi?id=44534
3813
3814         Fix two double-frees introduced in my previous commit.
3815
3816         * DumpRenderTree/gtk/EventSender.cpp:
3817         (contextClickCallback): Copy the event before using it again.
3818         (keyDownCallback): Ditto.
3819
3820 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
3821
3822         Reviewed by Xan Lopez.
3823
3824         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
3825         https://bugs.webkit.org/show_bug.cgi?id=44534
3826
3827         * DumpRenderTree/gtk/EventSender.cpp:
3828         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
3829         when setting it on the event. It is dereferenced by gdk_event_free(...).
3830         (contextClickCallback): Ditto.
3831         (mouseDownCallback): Ditto.
3832         (mouseUpCallback): Ditto.
3833         (mouseMoveToCallback): Ditto.
3834         (mouseWheelToCallback): Ditto.
3835         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
3836         (dispatchEvent): Ditto. Also free the event when we are done with it.
3837         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
3838
3839 2010-08-24  Andras Becsi  <abecsi@webkit.org>
3840
3841         [Qt] WebKit2 build fix.
3842
3843         * Scripts/enumerate-included-framework-headers:
3844         Remove stray global option form sed.
3845
3846 2010-08-24  Kent Tamura  <tkent@chromium.org>
3847
3848         Reviewed by Jeremy Orlow.
3849
3850         [DRT/Chromium] Support for IndexedDB tests
3851         https://bugs.webkit.org/show_bug.cgi?id=44490
3852
3853         * DumpRenderTree/chromium/TestShell.cpp:
3854         (TestShell::TestShell): Enable IndexedDB.
3855
3856 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
3857
3858         Reviewed by Gustavo Noronha Silva.
3859
3860         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
3861         https://bugs.webkit.org/show_bug.cgi?id=44465
3862
3863         Initialize the axes field of mouse button and motion events to null.
3864         This is the value that should be used for events originating from the
3865         mouse device.
3866
3867         * DumpRenderTree/gtk/EventSender.cpp:
3868         (prepareMouseButtonEvent): Initalize button event axes field to null.
3869         (mouseMoveToCallback): Initialize motion event axes field to null.
3870
3871 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3872
3873         Unreviewed, rolling out r65703.
3874         http://trac.webkit.org/changeset/65703
3875         https://bugs.webkit.org/show_bug.cgi?id=44460
3876
3877         "Causing lots of crashes on Snow Leopard when running the
3878         layout tests" (Requested by eseidel2 on #webkit).
3879
3880         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3881         (NP_Initialize):
3882         (NP_GetEntryPoints):
3883
3884 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
3885
3886         Layout tests do not run when using WebKitTestRunner in a Debug build.
3887         https://bugs.webkit.org/show_bug.cgi?id=44409
3888
3889         Reviewed by Dan Bernstein.
3890
3891         * WebKitTestRunner/win/TestControllerWin.cpp:
3892         (WTR::TestController::initializeInjectedBundlePath):
3893         Use InjectedBundle_debug.dll when building Debug.
3894
3895 2010-08-23  Xan Lopez  <xlopez@igalia.com>
3896
3897         Reviewed by Martin Robinson.
3898
3899         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
3900         https://bugs.webkit.org/show_bug.cgi?id=42026
3901
3902         If a GTK+ 3.x build is present return that as the library to use,
3903         otherwise fallback to the GTK+ 2.x build.
3904
3905         * Scripts/webkitdirs.pm:
3906
3907 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
3908
3909         Reviewed by Ariya Hidayat.
3910
3911         [Qt] Find needed forwarding headers for WebKit2 automatically
3912         https://bugs.webkit.org/show_bug.cgi?id=44336
3913
3914         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
3915         The new script does not satisfy the needs of this file however using normal includes
3916         is generally better here.
3917         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
3918         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
3919         given frameworks by files in the current directory (and subdirectories).
3920         In the future this needs to be rewritten in perl for being able to use on Windows.
3921
3922 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
3923
3924         Reviewed by Ariya Hidayat.
3925
3926         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
3927         https://bugs.webkit.org/show_bug.cgi?id=43010
3928
3929         * QtTestBrowser/launcherwindow.cpp:
3930         (LauncherWindow::applyPrefs):
3931         * QtTestBrowser/main.cpp:
3932         (LauncherApplication::handleUserOptions):
3933
3934 2010-08-21  Sam Weinig  <sam@webkit.org>
3935
3936         Reviewed by Dan Bernstein.
3937
3938         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
3939         https://bugs.webkit.org/show_bug.cgi?id=44386
3940
3941         * MiniBrowser/mac/AppDelegate.m:
3942         (didRecieveMessageFromInjectedBundle):
3943         (didNavigateWithNavigationData):
3944         (-[BrowserAppDelegate init]):
3945         (-[BrowserAppDelegate applicationWillTerminate:]):
3946         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3947         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
3948         (-[BrowserStatisticsWindowController dealloc]):
3949         * MiniBrowser/mac/BrowserWindowController.m:
3950         (-[BrowserWindowController initWithPageNamespace:]):
3951         (-[BrowserWindowController fetch:]):
3952         (-[BrowserWindowController windowWillClose:]):
3953         (-[BrowserWindowController applicationTerminating]):
3954         (closePage):
3955         (runJavaScriptAlert):
3956         (runJavaScriptConfirm):
3957         (runJavaScriptPrompt):
3958         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3959         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3960         (didClearWindowObjectForFrame):
3961         * MiniBrowser/win/BrowserView.cpp:
3962         (BrowserView::goToURL):
3963         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3964         (WTR::PlatformWebView::~PlatformWebView):
3965
3966 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
3967
3968         Reviewed by Kenneth Rohde Christiansen.
3969
3970         WebKit does not build with Python 2.3
3971         https://bugs.webkit.org/show_bug.cgi?id=44373
3972
3973         Replaced the function sorted() by a call to sort()
3974         on the entry list.
3975         The function sorted() has been added to Python 2.4.
3976         The function method sort() of List works with older
3977         versions of Python.
3978
3979         * Scripts/create-html-entity-table:
3980
3981 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
3982
3983         Reviewed by Pavel Feldman.
3984
3985         Web Inspector: Inspector tests were disabled for GTK.
3986         https://bugs.webkit.org/show_bug.cgi?id=43977
3987
3988         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
3989         path before running tests.
3990
3991 2010-08-20  Daniel Bates  <dbates@rim.com>
3992
3993         Reviewed by Eric Seidel.
3994
3995         svn-apply doesn't detect empty line with Windows line endings
3996         after property value
3997         https://bugs.webkit.org/show_bug.cgi?id=43981
3998
3999         Part 2 of 2
4000
4001         Add unit tests that were not landed in the first commit.
4002
4003         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
4004           - Added the following test cases:
4005             "SVN: binary file (isBinary true) using Windows line endings"
4006             "SVN: property diff, followed by file change diff using Windows line endings"
4007             "SVN: two consecutive property diffs using Windows line endings"
4008             "SVN: binary file with executable bit change usng Windows line endings"
4009             "SVN: binary file followed by property change on different file using Windows line endings"
4010             "SVN: binary file followed by file change on different file using Windows line endings"
4011             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
4012             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
4013         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
4014           - Added the following test cases:
4015             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
4016             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
4017             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
4018             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
4019             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
4020             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
4021             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
4022             "single-line '+' with trailing new line using Windows line endings"
4023             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
4024             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
4025             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
4026         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
4027           - Added the following test cases:
4028             "single-line '-' change followed by empty line with Windows line endings"
4029             "multi-line '+' change and start of binary patch with Windows line endings"
4030
4031 2010-08-20  Daniel Bates  <dbates@rim.com>
4032
4033         Reviewed by Eric Seidel.
4034
4035         svn-apply doesn't detect empty line with Windows line endings
4036         after property value
4037         https://bugs.webkit.org/show_bug.cgi?id=43981
4038
4039         Fixes an issue where an empty line following the property value
4040         in an SVN property change diff would not be detected if it had
4041         Windows line endings (i.e. ended in CRLF). Hence it was consumed
4042         as if it was part of a multi-line property value. 
4043
4044         * Scripts/VCSUtils.pm:
4045           - Modified parseSvnPropertyValue() to detect empty line
4046             with Windows line endings.
4047           - Added toWindowsLineEndings().
4048         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
4049           - Added the following test cases:
4050             "SVN: binary file (isBinary true) using Windows line endings"
4051             "SVN: property diff, followed by file change diff using Windows line endings"
4052             "SVN: two consecutive property diffs using Windows line endings"
4053             "SVN: binary file with executable bit change usng Windows line endings"
4054             "SVN: binary file followed by property change on different file using Windows line endings"
4055             "SVN: binary file followed by file change on different file using Windows line endings"
4056             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
4057             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
4058         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
4059           - Added the following test cases:
4060             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
4061             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
4062             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
4063             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
4064             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
4065             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
4066             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
4067             "single-line '+' with trailing new line using Windows line endings"
4068             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
4069             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
4070             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
4071         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
4072           - Added the following test cases:
4073             "single-line '-' change followed by empty line with Windows line endings"
4074             "multi-line '+' change and start of binary patch with Windows line endings"
4075
4076 2010-08-19  David Kilzer  <ddkilzer@apple.com>
4077
4078         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
4079
4080         * MiniBrowser/mac/BrowserWindowController.m:
4081         (decidePolicyForNavigationAction): Updated method signature.
4082         (decidePolicyForNewWindowAction): Updated method signature.
4083
4084 2010-08-19  Adam Roben  <aroben@apple.com>
4085
4086         Test that NP_Initialize and NP_GetEntryPoints are called in the
4087         correct order
4088
4089         The order differs between Mac and Windows (see r38858).
4090
4091         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
4092         NP_Initialize when loading QuickTime when running
4093         plugins/embed-attributes-setting.html in WebKit2 on Windows
4094
4095         Reviewed by Sam Weinig.
4096
4097         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
4098         a boolean to record whether NP_GetEntryPoints has been called.
4099         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
4100         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
4101         if NP_GetEntryPoints has been called already. This matches
4102         Silverlight's behavior.
4103
4104 2010-08-19  Adam Roben  <aroben@apple.com>
4105
4106         Make build-webkittestrunner build TestNetscapePlugIn on Windows
4107
4108         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
4109
4110         Reviewed by Sam Weinig.
4111
4112         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
4113         Threaded it in between ImageDiff and InjectedBundleGenerated.
4114
4115 2010-08-19  Ojan Vafai  <ojan@chromium.org>
4116
4117         Reviewed by Adam Barth.
4118
4119         install rietveld's upload script from a versioned url
4120         https://bugs.webkit.org/show_bug.cgi?id=44291
4121
4122         autoinstall expects the file at a given URL to never change.
4123         In order to be able to update the file, we need to be able to
4124         change the path.
4125
4126         * Scripts/webkitpy/thirdparty/__init__.py:
4127
4128 2010-08-19  Ojan Vafai  <ojan@chromium.org>
4129
4130         Reviewed by Adam Barth.
4131
4132         add --webkit_patch_id to reitveld uploads
4133         https://bugs.webkit.org/show_bug.cgi?id=44289
4134
4135         This is the first step in having rietveld store which
4136         patches have been uploaded and getting rid of the
4137         in-rietveld flag.
4138
4139         * Scripts/webkitpy/common/net/rietveld.py:
4140         * Scripts/webkitpy/tool/mocktool.py:
4141         * Scripts/webkitpy/tool/steps/postcodereview.py:
4142
4143 2010-08-19  Kenneth Russell  <kbr@google.com>
4144
4145         Reviewed by David Levin.
4146
4147         Adjust my status from committer to reviewer
4148         https://bugs.webkit.org/show_bug.cgi?id=44277
4149
4150         * Scripts/webkitpy/common/config/committers.py:
4151
4152 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
4153
4154         Reviewed by Yury Semikhatsky.
4155
4156         Chromium DevTools: remove injected script fetcher from test harness.
4157         https://bugs.webkit.org/show_bug.cgi?id=44266
4158
4159         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
4160         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
4161
4162 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
4163
4164         Reviewed by Yury Semikhatsky.
4165
4166         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
4167         Now that we populate front-end after its onload handler, we don't need
4168         to install injected script early. Exposing injected script source on the WebCore
4169         level here.
4170         https://bugs.webkit.org/show_bug.cgi?id=44029
4171
4172         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
4173         (DRTDevToolsAgent::runtimePropertyChanged):
4174         (DRTDevToolsAgent::delayedFrontendLoaded):
4175         (DRTDevToolsAgent::frontendLoaded):
4176         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
4177
4178 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4179
4180         Reviewed by Kenneth Rohde Christiansen.
4181
4182         [Gtk] Enable view mode media feature layout test
4183         https://bugs.webkit.org/show_bug.cgi?id=43278
4184
4185         Add view mode media feature testing infrastructure, and add
4186         placeholder methods for the other platforms'
4187         LayoutTestControllers.
4188
4189         * DumpRenderTree/LayoutTestController.cpp:
4190         (setViewModeMediaFeatureCallback):
4191         (LayoutTestController::staticFunctions):
4192         * DumpRenderTree/LayoutTestController.h:
4193         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4194         (LayoutTestController::setViewModeMediaFeature):
4195         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4196         (LayoutTestController::setViewModeMediaFeature):
4197         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4198         (LayoutTestController::setViewModeMediaFeature):
4199         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4200         (LayoutTestController::setViewModeMediaFeature):
4201
4202 2010-08-18  Mark Rowe  <mrowe@apple.com>
4203
4204         Reviewed by Sam Weinig.
4205
4206         Make it so the WebKit2 test slave runs the WebKit2 tests
4207
4208         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4209
4210 2010-08-18  Sam Weinig  <sam@webkit.org>
4211
4212         Reviewed by Mark Rowe.
4213
4214         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
4215         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
4216         module and the TestNetscapePlugin.
4217
4218         * Scripts/old-run-webkit-tests:
4219
4220 2010-08-18  Adam Roben  <aroben@apple.com>
4221
4222         Fix hang when saving crash logs on Windows
4223
4224         * Scripts/old-run-webkit-tests:
4225         (setUpWindowsCrashLogSaving):
4226         (END):
4227         Pass -s to regtool so it will write the Auto value as a string instead
4228         of as a number. This was causing a "do you want to debug?" dialog to
4229         appear.
4230
4231 2010-08-17  Victor Wang  <victorw@chromium.org>
4232
4233         Unreviewed. Fixed chromium incremental test json upload.
4234         Quote builder name and test results server in url.
4235
4236         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4237
4238 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4239
4240         Reviewed by Ariya Hidayat.
4241
4242         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
4243         https://bugs.webkit.org/show_bug.cgi?id=44124
4244
4245         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
4246         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
4247         Symbian dependencies.
4248
4249         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4250         (WebCore::DumpRenderTree::open):
4251         * QtTestBrowser/launcherwindow.cpp:
4252         (LauncherWindow::init):
4253         (LauncherWindow::toggleFullScreenMode):
4254         (LauncherWindow::showFPS):
4255         (LauncherWindow::updateFPS):
4256         * QtTestBrowser/launcherwindow.h:
4257         (WindowOptions::WindowOptions):
4258         * QtTestBrowser/mainwindow.cpp:
4259         (MainWindow::buildUI):
4260
4261 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
4262
4263         Reviewed by David Levin.
4264
4265         new-run-webkit-tests: remove --show-sources option
4266
4267         --show-sources is pretty much obsolete with --trace everything, so
4268         I'm removing it.
4269
4270         Also rename a couple of methods in the TestTextDiff class to make their
4271         intended visibility (private) more obvious.
4272
4273         https://bugs.webkit.org/show_bug.cgi?id=44143
4274
4275         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4276         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4277         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
4278         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
4279         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4280
4281 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
4282
4283         Reviewed by David Levin.
4284
4285         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
4286
4287         This code bit-rotted at some point more than a year ago, and nobody seems
4288         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
4289         should support instead, making this flag unnecessary anyway.
4290
4291         https://bugs.webkit.org/show_bug.cgi?id=44141
4292
4293         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4294         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4295         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
4296
4297 2010-08-17  Victor Wang  <victorw@chromium.org>
4298
4299         Reviewed by Ojan Vafai.
4300
4301         Update json results generator to have incremental json including
4302         results for tests that pass in current run but failed before.
4303
4304         https://bugs.webkit.org/show_bug.cgi?id=44119
4305
4306         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
4307         * Scripts/webkitpy/layou