2010-08-26 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / WebKitTools / ChangeLog
1 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         new-run-webkit-tests: add rebaselining tests for test_expectations
6         
7         This patch adds more unit tests for the rebaselining code in the
8         test_expectations module. It doesn't add any tests for
9         rebaseline_chromium_webkit_tests itself; that will come some other
10         time.
11
12         https://bugs.webkit.org/show_bug.cgi?id=44648
13
14         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
15         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
16
17 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
18
19         Reviewed by Martin Robinson.
20
21         [GTK] Add HTTP caching support
22         https://bugs.webkit.org/show_bug.cgi?id=44261
23
24         Ignore new soup API that we decided to merge into the soup backend
25         while it is being cooked. It follows the libsoup style, and will
26         be removed from WebKit as soon as it is merged into libsoup.
27
28         * Scripts/webkitpy/style/checker.py:
29
30 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
31
32         Reviewed by Kenneth Rohde Christiansen.
33
34         [Qt] DumpRenderTree runs only one test from command mode
35         https://bugs.webkit.org/show_bug.cgi?id=44012
36
37         Enables support to run multiple test files and single
38         folder containing html files in stand alone mode
39
40         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
41         (WebCore::DumpRenderTree::DumpRenderTree):
42         (WebCore::DumpRenderTree::processArgsLine):
43         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
44         (WebCore::DumpRenderTree::processLine):
45         (WebCore::DumpRenderTree::dump):
46         * DumpRenderTree/qt/DumpRenderTreeQt.h:
47         (WebCore::DumpRenderTree::setStandAloneMode):
48         (WebCore::DumpRenderTree::isStandAloneMode):
49         * DumpRenderTree/qt/main.cpp:
50         (main):
51
52 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
53
54         Updating webkitpy test expectations.
55
56         * Scripts/webkitpy/tool/steps/steps_unittest.py:
57
58 2010-08-25  Ojan Vafai  <ojan@chromium.org>
59
60         Reviewed by Eric Seidel.
61
62         fix the always squash git config
63         https://bugs.webkit.org/show_bug.cgi?id=44651
64
65         Fix help text and apparently underscores are not allowed
66         in git config keys.
67
68         * Scripts/webkitpy/common/checkout/scm.py:
69         * Scripts/webkitpy/tool/steps/commit.py:
70
71 2010-08-25  Darin Adler  <darin@apple.com>
72
73         Reviewed by John Sullivan.
74
75         * Scripts/commit-log-editor: Fix perl warning for people who have no
76         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
77
78 2010-08-25  Ojan Vafai  <ojan@chromium.org>
79
80         Reviewed by Eric Seidel.
81
82         stop blocking commits when the bots are red
83         https://bugs.webkit.org/show_bug.cgi?id=44644
84
85         This check currently is just annoying. It doesn't actually
86         help keep the tree green. We can always add it back later
87         if we decide the tree is generally more green.
88
89         * Scripts/webkitpy/tool/commands/download_unittest.py:
90         * Scripts/webkitpy/tool/mocktool.py:
91         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
92
93 2010-08-25  Eric Seidel  <eric@webkit.org>
94
95         Reviewed by Simon Fraser.
96
97         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
98         https://bugs.webkit.org/show_bug.cgi?id=38912
99
100         I know of nothing else to do but skip all media tests for the cq.
101
102         * Scripts/webkitpy/tool/steps/runtests.py:
103
104 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
105
106         Reviewed by Ojan Vafai.
107
108         new-run-webkit-tests: add more unit tests for test_expectations
109         This adds unit tests to cover (almost?) all of the non-rebaselining
110         functionality.
111
112         https://bugs.webkit.org/show_bug.cgi?id=44579
113
114         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
115         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
116
117 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
118
119         Reviewed by Ojan Vafai.
120
121         new-run-webkit-tests: add more unit tests
122
123         This change adds more unit tests for the image_diff, test_failures,
124         and test_files modules, bringing them to 100% coverage (and adds a
125         couple tests to run_webkit_tests while we're at it).
126
127         This test also turns on the "dryrun" port for testing when run on
128         the mac, increasing coverage in a few other places.
129
130         https://bugs.webkit.org/show_bug.cgi?id=44578
131
132         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
133         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
134         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
135         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
136         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
137         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
138         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
139         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
140         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
141         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
142         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
143         * Scripts/webkitpy/layout_tests/port/test.py:
144         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
145
146 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
147
148         Reviewed by Ojan Vafai.
149
150         new-run-webkit-tests: add more unit tests for layout_package/printing.py
151
152         This change adds more unit tests to get the test coverage to 100%
153         for the printing module. This code is actually pretty crufty and
154         has some layering violations that need to be cleaned up but I'll
155         save that for another CL after we get all the unit tests written and
156         we fix the multithreading issues. At least now we'll be able to tell
157         if we break things.
158
159         https://bugs.webkit.org/show_bug.cgi?id=44576
160
161         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
162         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
163
164 2010-08-25  Ojan Vafai  <ojan@chromium.org>
165
166         Reviewed by Adam Barth.
167
168         new-run-webkit-tests should respect set-webkit-configuration
169         https://bugs.webkit.org/show_bug.cgi?id=44633
170
171         Moves the getting of the configuration into the base Port so that
172         chromium ports use it as well. In the downstream chromium port,
173         this should still just return Release.
174
175         * Scripts/webkitpy/layout_tests/port/base.py:
176         * Scripts/webkitpy/layout_tests/port/webkit.py:
177
178 2010-08-25  Tony Chang  <tony@chromium.org>
179
180         Not reviewed, changing svn props for a script.
181
182         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
183
184 2010-08-25  Adam Barth  <abarth@webkit.org>
185
186         Reviewed by Eric Seidel.
187
188         Remove WebKit2 from core builders
189         https://bugs.webkit.org/show_bug.cgi?id=44625
190
191         This builder was added to the core builders by accident.  It doesn't
192         appear to be green enough to be a core builder yet.
193
194         * Scripts/webkitpy/common/net/buildbot.py:
195         * Scripts/webkitpy/common/net/buildbot_unittest.py:
196
197 2010-08-19  Adam Roben  <aroben@apple.com>
198
199         Test that NP_Initialize and NP_GetEntryPoints are called in the
200         correct order
201
202         The order differs between Mac and Windows (see r38858).
203
204         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
205         NP_Initialize when loading QuickTime when running
206         plugins/embed-attributes-setting.html in WebKit2 on Windows
207
208         Reviewed by John Sullivan.
209
210         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
211         a boolean to record whether NP_GetEntryPoints has been called.
212         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
213         called yet. This matches Flash and QuickTime's behavior.
214         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
215         yet. This matches Silverlight's behavior.
216
217 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
218
219         Reviewed by Gustavo Noronha Silva.
220
221         Cairo and EFL port shouldn't depend on glib.
222         https://bugs.webkit.org/show_bug.cgi?id=44354
223
224         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
225         adoptPlatformRef.
226
227         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
228         (AccessibilityUIElement::isSelected):
229
230 2010-08-25  Ojan Vafai  <ojan@chromium.org>
231
232         Fix order of Timothy's email address. The script, and
233         other tools all assume that the first email is the bugzilla address.
234
235         * Scripts/webkitpy/common/config/committers.py:
236
237 2010-08-24  Kent Tamura  <tkent@chromium.org>
238
239         Reviewed by Pavel Feldman.
240
241         [DRT/Chromium] Fix 26 inspector test crashes
242         https://bugs.webkit.org/show_bug.cgi?id=44580
243
244         - DRTDevToolsAgent has a reference to the main WebView. So we
245           should not clear it in closeDevTools() and should clear it in
246           ~TestShell().
247         - DRTDevToolsClient has a reference to a DevTools WebView and no
248           way to update it. So we should delete DRTDevToolsClient instances
249           in closeDevTools().
250
251         * DumpRenderTree/chromium/TestShell.cpp:
252         (TestShell::~TestShell):
253         (TestShell::closeDevTools):
254
255 2010-08-24  Eric Seidel  <eric@webkit.org>
256
257         Reviewed by Adam Barth.
258
259         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
260         https://bugs.webkit.org/show_bug.cgi?id=44584
261
262         * Scripts/webkitpy/tool/commands/queues_unittest.py:
263
264 2010-08-24  Eric Seidel  <eric@webkit.org>
265
266         Reviewed by Adam Barth.
267
268         commit-queue and EWS bots should report all failures
269         https://bugs.webkit.org/show_bug.cgi?id=41820
270
271         Right now commit-queue/EWS only report failures when the
272         patch under testing fails.  We should report all failures
273         to the status server so that we can diagnose when the bots
274         are wedged w/o needing to log into the machines.
275
276         I also reduced the amount of data we upload since we've seen
277         timeouts during status upload.
278
279         * Scripts/webkitpy/common/system/executive.py:
280         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
281         * Scripts/webkitpy/tool/commands/queues.py:
282         * Scripts/webkitpy/tool/commands/queues_unittest.py:
283
284 2010-08-24  Eric Seidel  <eric@webkit.org>
285
286         Reviewed by Adam Barth.
287
288         Remove HTML5 parser testing infrastructure now that we don't need it
289         https://bugs.webkit.org/show_bug.cgi?id=44581
290
291         * DumpRenderTree/mac/DumpRenderTree.mm:
292         (resetDefaultsToConsistentValues):
293         (initializeGlobalsFromCommandLineOptions):
294         * Scripts/old-run-webkit-tests:
295         * Scripts/test-html5-parser: Removed.
296
297 2010-08-24  Kent Tamura  <tkent@chromium.org>
298
299         Reviewed by Dimitri Glazkov.
300
301         [DRT/Chromium] Fix 28 inspector test crashes
302         https://bugs.webkit.org/show_bug.cgi?id=44574
303
304         Reset DevToolsClient and DevToolsAgent before closing a DevTools
305         WebView in order to avoid accessing to a deleted WebView instance.
306
307         * DumpRenderTree/chromium/TestShell.cpp:
308         (TestShell::closeDevTools):
309
310 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
311
312         Reviewed by Ojan Vafai.
313
314         new-run-webkit-tests: clean up code for test_types, test_failures
315
316         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
317         webkitpy.layout_tests.layout_package.test_failures, and remove
318         some dead code and otherwise clean up things.
319
320         https://bugs.webkit.org/show_bug.cgi?id=44559
321
322         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
323         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
324         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
325         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
326         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
327         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
328         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
329
330 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
331
332         Reviewed by Eric Seidel.
333
334         new-run-webkit-tests: revise unit testing strategy for test failures
335     
336         This change revamps the way we store test data for new-run-webkit-tests.
337         Previously we had a few copies of test files from the main test tree.
338         Now we have a bunch of completely fake test data and use the test
339         data to generate different kinds of test failures, getting
340         much better coverage.
341
342         https://bugs.webkit.org/show_bug.cgi?id=44556
343
344         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
345         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
346         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
347         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
348         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
349         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
350         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
351         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
352         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
353         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
354         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
355         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
356         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
357         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
358         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
359         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
360         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
361         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
362         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
363         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
364         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
365         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
366         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
367         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
368         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
369         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
370         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
371         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
372         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
373         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
374         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
375         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
376         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
377         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
378         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
379         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
380         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
381         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
382         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
383         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
384         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
385         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
386         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
387         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
388         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
389         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
390         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
391         * Scripts/webkitpy/layout_tests/port/test.py:
392         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
393         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
394
395 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
396
397         Reviewed by Eric Seidel.
398
399         speed up new-run-webkit-tests unit tests
400
401         Add a --no-record-results flag that turns off generating the JSON
402         results file on every test run. Generating the file requires us to
403         fetch the old results down from the bots, which can be slow. This
404         flag is off by default.
405     
406         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
407     
408         These changes together shorten the test cycle from ~4.5s to ~1.5s
409         - a 3x speedup.
410
411         https://bugs.webkit.org/show_bug.cgi?id=44553
412
413         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
414         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
415
416 2010-08-24  Tony Chang  <tony@chromium.org>
417
418         Reviewed by Eric Seidel.
419
420         [chromium] fix the platform result fallback order on mac/win
421         https://bugs.webkit.org/show_bug.cgi?id=44483
422
423         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
424
425 2010-08-24  Xan Lopez  <xlopez@igalia.com>
426
427         Reviewed by Martin Robinson.
428
429         Set a device to the event struct when building with GTK+ 3.x, it's
430         mandatory.
431
432         * DumpRenderTree/gtk/EventSender.cpp:
433         (keyDownCallback):
434
435 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
436
437         Reviewed by Xan Lopez.
438
439         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
440         https://bugs.webkit.org/show_bug.cgi?id=44534
441
442         Fix two double-frees introduced in my previous commit.
443
444         * DumpRenderTree/gtk/EventSender.cpp:
445         (contextClickCallback): Copy the event before using it again.
446         (keyDownCallback): Ditto.
447
448 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
449
450         Reviewed by Xan Lopez.
451
452         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
453         https://bugs.webkit.org/show_bug.cgi?id=44534
454
455         * DumpRenderTree/gtk/EventSender.cpp:
456         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
457         when setting it on the event. It is dereferenced by gdk_event_free(...).
458         (contextClickCallback): Ditto.
459         (mouseDownCallback): Ditto.
460         (mouseUpCallback): Ditto.
461         (mouseMoveToCallback): Ditto.
462         (mouseWheelToCallback): Ditto.
463         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
464         (dispatchEvent): Ditto. Also free the event when we are done with it.
465         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
466
467 2010-08-24  Andras Becsi  <abecsi@webkit.org>
468
469         [Qt] WebKit2 build fix.
470
471         * Scripts/enumerate-included-framework-headers:
472         Remove stray global option form sed.
473
474 2010-08-24  Kent Tamura  <tkent@chromium.org>
475
476         Reviewed by Jeremy Orlow.
477
478         [DRT/Chromium] Support for IndexedDB tests
479         https://bugs.webkit.org/show_bug.cgi?id=44490
480
481         * DumpRenderTree/chromium/TestShell.cpp:
482         (TestShell::TestShell): Enable IndexedDB.
483
484 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
485
486         Reviewed by Gustavo Noronha Silva.
487
488         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
489         https://bugs.webkit.org/show_bug.cgi?id=44465
490
491         Initialize the axes field of mouse button and motion events to null.
492         This is the value that should be used for events originating from the
493         mouse device.
494
495         * DumpRenderTree/gtk/EventSender.cpp:
496         (prepareMouseButtonEvent): Initalize button event axes field to null.
497         (mouseMoveToCallback): Initialize motion event axes field to null.
498
499 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
500
501         Unreviewed, rolling out r65703.
502         http://trac.webkit.org/changeset/65703
503         https://bugs.webkit.org/show_bug.cgi?id=44460
504
505         "Causing lots of crashes on Snow Leopard when running the
506         layout tests" (Requested by eseidel2 on #webkit).
507
508         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
509         (NP_Initialize):
510         (NP_GetEntryPoints):
511
512 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
513
514         Layout tests do not run when using WebKitTestRunner in a Debug build.
515         https://bugs.webkit.org/show_bug.cgi?id=44409
516
517         Reviewed by Dan Bernstein.
518
519         * WebKitTestRunner/win/TestControllerWin.cpp:
520         (WTR::TestController::initializeInjectedBundlePath):
521         Use InjectedBundle_debug.dll when building Debug.
522
523 2010-08-23  Xan Lopez  <xlopez@igalia.com>
524
525         Reviewed by Martin Robinson.
526
527         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
528         https://bugs.webkit.org/show_bug.cgi?id=42026
529
530         If a GTK+ 3.x build is present return that as the library to use,
531         otherwise fallback to the GTK+ 2.x build.
532
533         * Scripts/webkitdirs.pm:
534
535 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
536
537         Reviewed by Ariya Hidayat.
538
539         [Qt] Find needed forwarding headers for WebKit2 automatically
540         https://bugs.webkit.org/show_bug.cgi?id=44336
541
542         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
543         The new script does not satisfy the needs of this file however using normal includes
544         is generally better here.
545         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
546         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
547         given frameworks by files in the current directory (and subdirectories).
548         In the future this needs to be rewritten in perl for being able to use on Windows.
549
550 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
551
552         Reviewed by Ariya Hidayat.
553
554         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
555         https://bugs.webkit.org/show_bug.cgi?id=43010
556
557         * QtTestBrowser/launcherwindow.cpp:
558         (LauncherWindow::applyPrefs):
559         * QtTestBrowser/main.cpp:
560         (LauncherApplication::handleUserOptions):
561
562 2010-08-21  Sam Weinig  <sam@webkit.org>
563
564         Reviewed by Dan Bernstein.
565
566         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
567         https://bugs.webkit.org/show_bug.cgi?id=44386
568
569         * MiniBrowser/mac/AppDelegate.m:
570         (didRecieveMessageFromInjectedBundle):
571         (didNavigateWithNavigationData):
572         (-[BrowserAppDelegate init]):
573         (-[BrowserAppDelegate applicationWillTerminate:]):
574         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
575         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
576         (-[BrowserStatisticsWindowController dealloc]):
577         * MiniBrowser/mac/BrowserWindowController.m:
578         (-[BrowserWindowController initWithPageNamespace:]):
579         (-[BrowserWindowController fetch:]):
580         (-[BrowserWindowController windowWillClose:]):
581         (-[BrowserWindowController applicationTerminating]):
582         (closePage):
583         (runJavaScriptAlert):
584         (runJavaScriptConfirm):
585         (runJavaScriptPrompt):
586         (-[BrowserWindowController updateProvisionalURLForFrame:]):
587         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
588         (didClearWindowObjectForFrame):
589         * MiniBrowser/win/BrowserView.cpp:
590         (BrowserView::goToURL):
591         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
592         (WTR::PlatformWebView::~PlatformWebView):
593
594 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
595
596         Reviewed by Kenneth Rohde Christiansen.
597
598         WebKit does not build with Python 2.3
599         https://bugs.webkit.org/show_bug.cgi?id=44373
600
601         Replaced the function sorted() by a call to sort()
602         on the entry list.
603         The function sorted() has been added to Python 2.4.
604         The function method sort() of List works with older
605         versions of Python.
606
607         * Scripts/create-html-entity-table:
608
609 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
610
611         Reviewed by Pavel Feldman.
612
613         Web Inspector: Inspector tests were disabled for GTK.
614         https://bugs.webkit.org/show_bug.cgi?id=43977
615
616         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
617         path before running tests.
618
619 2010-08-20  Daniel Bates  <dbates@rim.com>
620
621         Reviewed by Eric Seidel.
622
623         svn-apply doesn't detect empty line with Windows line endings
624         after property value
625         https://bugs.webkit.org/show_bug.cgi?id=43981
626
627         Part 2 of 2
628
629         Add unit tests that were not landed in the first commit.
630
631         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
632           - Added the following test cases:
633             "SVN: binary file (isBinary true) using Windows line endings"
634             "SVN: property diff, followed by file change diff using Windows line endings"
635             "SVN: two consecutive property diffs using Windows line endings"
636             "SVN: binary file with executable bit change usng Windows line endings"
637             "SVN: binary file followed by property change on different file using Windows line endings"
638             "SVN: binary file followed by file change on different file using Windows line endings"
639             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
640             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
641         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
642           - Added the following test cases:
643             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
644             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
645             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
646             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
647             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
648             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
649             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
650             "single-line '+' with trailing new line using Windows line endings"
651             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
652             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
653             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
654         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
655           - Added the following test cases:
656             "single-line '-' change followed by empty line with Windows line endings"
657             "multi-line '+' change and start of binary patch with Windows line endings"
658
659 2010-08-20  Daniel Bates  <dbates@rim.com>
660
661         Reviewed by Eric Seidel.
662
663         svn-apply doesn't detect empty line with Windows line endings
664         after property value
665         https://bugs.webkit.org/show_bug.cgi?id=43981
666
667         Fixes an issue where an empty line following the property value
668         in an SVN property change diff would not be detected if it had
669         Windows line endings (i.e. ended in CRLF). Hence it was consumed
670         as if it was part of a multi-line property value. 
671
672         * Scripts/VCSUtils.pm:
673           - Modified parseSvnPropertyValue() to detect empty line
674             with Windows line endings.
675           - Added toWindowsLineEndings().
676         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
677           - Added the following test cases:
678             "SVN: binary file (isBinary true) using Windows line endings"
679             "SVN: property diff, followed by file change diff using Windows line endings"
680             "SVN: two consecutive property diffs using Windows line endings"
681             "SVN: binary file with executable bit change usng Windows line endings"
682             "SVN: binary file followed by property change on different file using Windows line endings"
683             "SVN: binary file followed by file change on different file using Windows line endings"
684             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
685             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
686         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
687           - Added the following test cases:
688             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
689             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
690             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
691             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
692             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
693             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
694             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
695             "single-line '+' with trailing new line using Windows line endings"
696             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
697             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
698             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
699         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
700           - Added the following test cases:
701             "single-line '-' change followed by empty line with Windows line endings"
702             "multi-line '+' change and start of binary patch with Windows line endings"
703
704 2010-08-19  David Kilzer  <ddkilzer@apple.com>
705
706         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
707
708         * MiniBrowser/mac/BrowserWindowController.m:
709         (decidePolicyForNavigationAction): Updated method signature.
710         (decidePolicyForNewWindowAction): Updated method signature.
711
712 2010-08-19  Adam Roben  <aroben@apple.com>
713
714         Test that NP_Initialize and NP_GetEntryPoints are called in the
715         correct order
716
717         The order differs between Mac and Windows (see r38858).
718
719         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
720         NP_Initialize when loading QuickTime when running
721         plugins/embed-attributes-setting.html in WebKit2 on Windows
722
723         Reviewed by Sam Weinig.
724
725         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
726         a boolean to record whether NP_GetEntryPoints has been called.
727         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
728         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
729         if NP_GetEntryPoints has been called already. This matches
730         Silverlight's behavior.
731
732 2010-08-19  Adam Roben  <aroben@apple.com>
733
734         Make build-webkittestrunner build TestNetscapePlugIn on Windows
735
736         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
737
738         Reviewed by Sam Weinig.
739
740         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
741         Threaded it in between ImageDiff and InjectedBundleGenerated.
742
743 2010-08-19  Ojan Vafai  <ojan@chromium.org>
744
745         Reviewed by Adam Barth.
746
747         install rietveld's upload script from a versioned url
748         https://bugs.webkit.org/show_bug.cgi?id=44291
749
750         autoinstall expects the file at a given URL to never change.
751         In order to be able to update the file, we need to be able to
752         change the path.
753
754         * Scripts/webkitpy/thirdparty/__init__.py:
755
756 2010-08-19  Ojan Vafai  <ojan@chromium.org>
757
758         Reviewed by Adam Barth.
759
760         add --webkit_patch_id to reitveld uploads
761         https://bugs.webkit.org/show_bug.cgi?id=44289
762
763         This is the first step in having rietveld store which
764         patches have been uploaded and getting rid of the
765         in-rietveld flag.
766
767         * Scripts/webkitpy/common/net/rietveld.py:
768         * Scripts/webkitpy/tool/mocktool.py:
769         * Scripts/webkitpy/tool/steps/postcodereview.py:
770
771 2010-08-19  Kenneth Russell  <kbr@google.com>
772
773         Reviewed by David Levin.
774
775         Adjust my status from committer to reviewer
776         https://bugs.webkit.org/show_bug.cgi?id=44277
777
778         * Scripts/webkitpy/common/config/committers.py:
779
780 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
781
782         Reviewed by Yury Semikhatsky.
783
784         Chromium DevTools: remove injected script fetcher from test harness.
785         https://bugs.webkit.org/show_bug.cgi?id=44266
786
787         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
788         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
789
790 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
791
792         Reviewed by Yury Semikhatsky.
793
794         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
795         Now that we populate front-end after its onload handler, we don't need
796         to install injected script early. Exposing injected script source on the WebCore
797         level here.
798         https://bugs.webkit.org/show_bug.cgi?id=44029
799
800         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
801         (DRTDevToolsAgent::runtimePropertyChanged):
802         (DRTDevToolsAgent::delayedFrontendLoaded):
803         (DRTDevToolsAgent::frontendLoaded):
804         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
805
806 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
807
808         Reviewed by Kenneth Rohde Christiansen.
809
810         [Gtk] Enable view mode media feature layout test
811         https://bugs.webkit.org/show_bug.cgi?id=43278
812
813         Add view mode media feature testing infrastructure, and add
814         placeholder methods for the other platforms'
815         LayoutTestControllers.
816
817         * DumpRenderTree/LayoutTestController.cpp:
818         (setViewModeMediaFeatureCallback):
819         (LayoutTestController::staticFunctions):
820         * DumpRenderTree/LayoutTestController.h:
821         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
822         (LayoutTestController::setViewModeMediaFeature):
823         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
824         (LayoutTestController::setViewModeMediaFeature):
825         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
826         (LayoutTestController::setViewModeMediaFeature):
827         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
828         (LayoutTestController::setViewModeMediaFeature):
829
830 2010-08-18  Mark Rowe  <mrowe@apple.com>
831
832         Reviewed by Sam Weinig.
833
834         Make it so the WebKit2 test slave runs the WebKit2 tests
835
836         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
837
838 2010-08-18  Sam Weinig  <sam@webkit.org>
839
840         Reviewed by Mark Rowe.
841
842         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
843         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
844         module and the TestNetscapePlugin.
845
846         * Scripts/old-run-webkit-tests:
847
848 2010-08-18  Adam Roben  <aroben@apple.com>
849
850         Fix hang when saving crash logs on Windows
851
852         * Scripts/old-run-webkit-tests:
853         (setUpWindowsCrashLogSaving):
854         (END):
855         Pass -s to regtool so it will write the Auto value as a string instead
856         of as a number. This was causing a "do you want to debug?" dialog to
857         appear.
858
859 2010-08-17  Victor Wang  <victorw@chromium.org>
860
861         Unreviewed. Fixed chromium incremental test json upload.
862         Quote builder name and test results server in url.
863
864         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
865
866 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
867
868         Reviewed by Ariya Hidayat.
869
870         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
871         https://bugs.webkit.org/show_bug.cgi?id=44124
872
873         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
874         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
875         Symbian dependencies.
876
877         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
878         (WebCore::DumpRenderTree::open):
879         * QtTestBrowser/launcherwindow.cpp:
880         (LauncherWindow::init):
881         (LauncherWindow::toggleFullScreenMode):
882         (LauncherWindow::showFPS):
883         (LauncherWindow::updateFPS):
884         * QtTestBrowser/launcherwindow.h:
885         (WindowOptions::WindowOptions):
886         * QtTestBrowser/mainwindow.cpp:
887         (MainWindow::buildUI):
888
889 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
890
891         Reviewed by David Levin.
892
893         new-run-webkit-tests: remove --show-sources option
894
895         --show-sources is pretty much obsolete with --trace everything, so
896         I'm removing it.
897
898         Also rename a couple of methods in the TestTextDiff class to make their
899         intended visibility (private) more obvious.
900
901         https://bugs.webkit.org/show_bug.cgi?id=44143
902
903         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
904         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
905         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
906         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
907         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
908
909 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
910
911         Reviewed by David Levin.
912
913         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
914
915         This code bit-rotted at some point more than a year ago, and nobody seems
916         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
917         should support instead, making this flag unnecessary anyway.
918
919         https://bugs.webkit.org/show_bug.cgi?id=44141
920
921         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
922         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
923         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
924
925 2010-08-17  Victor Wang  <victorw@chromium.org>
926
927         Reviewed by Ojan Vafai.
928
929         Update json results generator to have incremental json including
930         results for tests that pass in current run but failed before.
931
932         https://bugs.webkit.org/show_bug.cgi?id=44119
933
934         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
935         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
936         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
937
938 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
939
940         Reviewed by Eric Seidel.
941
942         fix test-webkitpy, add easy way to find a checkout root
943
944         test-webkitpy currently doesn't work right if run from someplace other
945         than the checkout root, and it spews a bunch of debug logging because
946         the deduplicate_tests tests contaminates the test environment.
947
948         This patch cleans up the deduplicate_tests unit tests, and creates
949         two new methods in scm.py: find_checkout_root() and default_scm(),
950         both of which use a single algorithm for guessing what checkout root
951         to use if you aren't explicitly told one from a path.
952
953         https://bugs.webkit.org/show_bug.cgi?id=44001
954
955         * Scripts/deduplicate-tests:
956         * Scripts/webkitpy/common/checkout/scm.py:
957         * Scripts/webkitpy/common/checkout/scm_unittest.py:
958         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
959         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
960         * Scripts/webkitpy/layout_tests/port/test.py:
961         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
962         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
963         * Scripts/webkitpy/tool/main.py:
964
965 2010-08-17  Victor Wang  <victorw@chromium.org>
966
967         Reviewed by Ojan Vafai.
968
969         Add support to the test results server for downloading json that
970         contains test list only.
971
972         This is for json results generator to generate incremental json
973         results so that it includes results not only for tests failed in
974         current run, but also tests failed before.
975
976         Also set the results type to "N" (no data) instead of "P" (pass)
977         if test results cannot be found in incremental json file.
978
979         https://bugs.webkit.org/show_bug.cgi?id=44117
980
981         * TestResultServer/handlers/testfilehandler.py:
982         * TestResultServer/model/jsonresults.py:
983         * TestResultServer/model/jsonresults_unittest.py:
984
985 2010-08-17  Adam Roben  <aroben@apple.com>
986
987         Use the right path style
988
989         * Scripts/old-run-webkit-tests:
990
991 2010-08-17  Adam Roben  <aroben@apple.com>
992
993         Fix typo
994
995         * Scripts/old-run-webkit-tests:
996
997 2010-08-17  Adam Roben  <aroben@apple.com>
998
999         Don't hang when running run-webkit-tests as a non-Administrator on
1000         Vista/7
1001
1002         * Scripts/old-run-webkit-tests:
1003         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
1004         post-mortem debugger, rather than using NTSD itself. The latter waits
1005         for user input when it fails to set the registry values; the former
1006         does not.
1007
1008 2010-08-17  Adam Roben  <aroben@apple.com>
1009
1010         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
1011         save crash logs on Windows
1012
1013         The crash logs are saved to /tmp/layout-test-results and have names
1014         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
1015
1016         Unfortunately, crashes in the WebKit2 web process are recorded as
1017         time-outs by run-webkit-tests. Fixing this is covered by
1018         <http://webkit.org/b/44121>.
1019
1020         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
1021         DumpRenderTree should save a stack trace and/or dump file when it
1022         crashes
1023
1024         Reviewed by Sam Weinig.
1025
1026         * DumpRenderTree/win/DumpRenderTree.cpp:
1027         (exceptionFilter):
1028         (main):
1029         * WebKitTestRunner/win/TestControllerWin.cpp:
1030         (WTR::exceptionFilter):
1031         (WTR::TestController::platformInitialize):
1032         These changes set up an exception filter that prints #CRASHED to
1033         stderr, then lets the exception propagate normally. This allows
1034         run-webkit-tests to detect when we've crashed even when a post-mortem
1035         debugger attaches to the process.
1036
1037         * Scripts/old-run-webkit-tests:
1038         (top level): Declared some variables used by the crash-log-saving
1039         code.
1040         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
1041         that the post-mortem debugger has access to it.
1042         (toCygwinPath): Added. This is the opposite of toWindowsPath.
1043         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
1044         stderr, consider it a crash.
1045         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
1046         debugger, then sets ntsd as the post-mortem debugger. ntsd is
1047         configured to save a crash log and then quit automatically.
1048         (END): Added. Restores the previous post-mortem debugger when the
1049         script exits.
1050
1051 2010-08-17  Victor Wang  <victorw@chromium.org>
1052
1053         Reviewed by ojan@chromium.org.
1054
1055         Update test results server:
1056         1. Normalize test results and times after merging (prune tests where
1057            all runs pass or do not have data, truncate all test items to max
1058            number of builds)
1059         2. times should be int not string.
1060         3. when inserting a new test item, should keep old data regardless
1061            whether or not they have same item type with new one.
1062
1063         https://bugs.webkit.org/show_bug.cgi?id=43861
1064
1065         * TestResultServer/model/jsonresults.py:
1066         * TestResultServer/model/jsonresults_unittest.py:
1067
1068 2010-08-16  Sam Weinig  <sam@webkit.org>
1069
1070         Reviewed by Mark Rowe.
1071
1072         Add WebKit2 Mac tester to buildbot.
1073
1074         * BuildSlaveSupport/build.webkit.org-config/config.json:
1075         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1076
1077 2010-08-16  Paul Sawaya  <psawaya@apple.com>
1078
1079         Reviewed by Chris Marrin.
1080
1081         Added shader validation via ANGLE
1082         https://bugs.webkit.org/show_bug.cgi?id=42405
1083
1084         Added ANGLE to webkit build
1085
1086         * Scripts/build-webkit:
1087
1088 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
1089
1090         [wx] Build fix, do not build WebCore as a convenience library as this leads to
1091         errors in the Win build w/export symbols and causes problems with DOM bindings
1092         debugging in gdb.
1093
1094         * DumpRenderTree/wscript:
1095         * Scripts/build-webkit:
1096         * wx/browser/wscript:
1097         * wx/build/settings.py:
1098         * wx/build/waf_extensions.py:
1099
1100 2010-08-16  Dan Bernstein  <mitz@apple.com>
1101
1102         Build fix.
1103
1104         * WebKitTestRunner/TestController.cpp:
1105         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
1106         (WTR::TestController::initialize): Ditto.
1107
1108 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1109
1110         Reviewed by Kenneth Rohde Christiansen.
1111
1112         Handle content size change in WebKit2
1113         Re-landing after fix.
1114
1115         https://bugs.webkit.org/show_bug.cgi?id=43198
1116
1117         * MiniBrowser/mac/BrowserWindowController.m:
1118         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1119         * MiniBrowser/win/BrowserView.cpp:
1120         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1121
1122 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1123
1124         Unreviewed, rolling out r65419.
1125         http://trac.webkit.org/changeset/65419
1126         https://bugs.webkit.org/show_bug.cgi?id=44053
1127
1128         Broke the Windows build (Requested by bbandix on #webkit).
1129
1130         * MiniBrowser/mac/BrowserWindowController.m:
1131         (-[BrowserWindowController awakeFromNib]):
1132         * MiniBrowser/win/BrowserView.cpp:
1133         (BrowserView::create):
1134
1135 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1136
1137         Reviewed by Kenneth Rohde Christiansen.
1138
1139         Handle content size change in WebKit2
1140
1141         https://bugs.webkit.org/show_bug.cgi?id=43198
1142
1143         * MiniBrowser/mac/BrowserWindowController.m:
1144         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1145         * MiniBrowser/win/BrowserView.cpp:
1146         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1147
1148 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
1149
1150         Add my new email address to committers.py.
1151
1152         * Scripts/webkitpy/common/config/committers.py:
1153
1154 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
1155
1156         Add my old e-mail addresses to committers.py.
1157
1158         * Scripts/webkitpy/common/config/committers.py:
1159
1160 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1161
1162         WebEditorClient::didBeginEditing is never called in WebKit2
1163         https://bugs.webkit.org/show_bug.cgi?id=42939
1164
1165         Reviewed by Sam Weinig.
1166
1167         * WebKitTestRunner/PlatformWebView.h:
1168         Declare focus().
1169
1170         * WebKitTestRunner/TestController.cpp:
1171         (WTR::TestController::resetStateToConsistentValues):
1172         Focus the PlatformWebView.
1173
1174         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1175         (WTR::PlatformWebView::focus):
1176         Stubbed.
1177
1178         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1179         (WTR::PlatformWebView::focus):
1180         Focus the view.
1181
1182 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1183
1184         run-webkit-tests should not strip editing callbacks when using
1185         WebKitTestRunner on Windows
1186         https://bugs.webkit.org/show_bug.cgi?id=44000
1187
1188         Reviewed by Mark Rowe.
1189
1190         * Scripts/old-run-webkit-tests:
1191         Leave $stripEditingCallbacks undefined until we look for command-line
1192         arguments. If using WebKit2, set it to 0 if not explicity set on the
1193         command line. Later, set it to isCygwin() to match old behavior if it is
1194         not yet defined.
1195
1196 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
1197
1198         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
1199
1200         * wx/build/settings.py:
1201
1202 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
1203
1204         Reviewed by Kenneth Rohde Christiansen.
1205
1206         [GTK] autogen.sh not executed if build-webkit options change
1207         https://bugs.webkit.org/show_bug.cgi?id=42266
1208
1209         Rerun autogen.sh in situations where the arguments to build-webkit have
1210         changed since the previous build. This will fix some issues on the bots
1211         where the build does not notice changes to default build-webkit arguments.
1212
1213         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
1214
1215 2010-08-14  Eric Seidel  <eric@webkit.org>
1216
1217         Unreviewed.  Another fix to support python 2.3.
1218
1219         Add support for MathML entities
1220         https://bugs.webkit.org/show_bug.cgi?id=43949
1221
1222         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
1223          - It looks like our simplejson is version 1.7.3 which
1224            should be python 2.3 compatible.  But someone modified
1225            our copy slightly from the original source.
1226            I've removed the relative import in hopes this fixes
1227            the problem.
1228
1229 2010-08-13  Eric Seidel  <eric@webkit.org>
1230
1231         Unreviewed.  Build fix only.
1232
1233         Add support for MathML entities
1234         https://bugs.webkit.org/show_bug.cgi?id=43949
1235
1236         * Scripts/create-html-entity-table:
1237          - Hack sys.path to avoid executing 2.5 dependent python
1238            on systems (like chromium-win and Tiger) which do not have 2.5 python.
1239
1240 2010-08-13  Adam Barth  <abarth@webkit.org>
1241
1242         Reviewed by Eric Seidel.
1243
1244         Rename some concepts in HTML entity search to be more self-documenting
1245         https://bugs.webkit.org/show_bug.cgi?id=44004
1246
1247         Reflect name change in generator script.
1248
1249         * Scripts/create-html-entity-table:
1250
1251 2010-08-12  Adam Barth  <abarth@webkit.org>
1252
1253         Reviewed by Eric Seidel.
1254
1255         Add support for MathML entities
1256         https://bugs.webkit.org/show_bug.cgi?id=43949
1257
1258         A script for generating the C++ state data structure describing all the
1259         entities from a JSON description.
1260
1261         * Scripts/create-html-entity-table: Added.
1262
1263 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
1264
1265         Reviewed by Eric Seidel.
1266
1267         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
1268         check for exceptions on all threads, not just the first thread.
1269         
1270         This change also changes the logging behavior for wedged threads
1271         to only dump the stacks of threads that are actually wedged.
1272
1273         Refactor the thread classes in the dump_render_tree_thread module
1274         to make the contract between TestRunner and TestShellThread clearer.
1275
1276         Added a bunch of unit tests.
1277         https://bugs.webkit.org/show_bug.cgi?id=38561
1278
1279         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1280         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1281         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1282
1283 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
1284
1285         Reviewed by Shinichiro Hamaji.
1286
1287         Add test_expectations.txt syntax checker to check-webkit-style.
1288         https://bugs.webkit.org/show_bug.cgi?id=43899
1289
1290         Just utilizing layout_tests/layout_package/test_expectations.py for checking
1291         the syntax of test_expectations.txt.
1292         This change also moves tab checking class from style/checkers/text.py to
1293         style/checkers/common.py for sharing code.
1294
1295         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1296         * Scripts/webkitpy/style/checker.py:
1297         * Scripts/webkitpy/style/checkers/common.py:
1298         * Scripts/webkitpy/style/checkers/common_unittest.py:
1299         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
1300         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
1301         * Scripts/webkitpy/style/checkers/text.py:
1302         * Scripts/webkitpy/style_references.py:
1303
1304 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1305
1306         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
1307         https://bugs.webkit.org/show_bug.cgi?id=43945
1308
1309         Reviewed by Sam Weinig.
1310
1311         * WebKitTestRunner/TestInvocation.cpp:
1312         (WTR::sizeWebViewForCurrentTest):
1313         Allow for a Windows-style path.
1314
1315         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1316         (WTR::PlatformWebView::resizeTo):
1317         Call SetWindowPos to resize the view window.
1318
1319 2010-08-12  David Levin  <levin@chromium.org>
1320
1321         Build break fix.
1322
1323         * WebKitTestRunner/TestController.cpp:
1324         (WTR::TestController::resetStateToConsistentValues): Removed usage
1325         of a variable that doesn't exist in the class.
1326
1327 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
1328
1329         WebKitTestRunner needs to run tests without using native controls
1330         https://bugs.webkit.org/show_bug.cgi?id=43772
1331
1332         Reviewed by Sam Weinig.
1333
1334         * WebKitTestRunner/TestController.cpp:
1335         (WTR::TestController::initialize):
1336         Call platformInitializeContext().
1337
1338         * WebKitTestRunner/TestController.h:
1339         Declare platformInitializeContext().
1340
1341         * WebKitTestRunner/mac/TestControllerMac.mm:
1342         (WTR::TestController::platformInitializeContext):
1343         Stubbed.
1344
1345         * WebKitTestRunner/win/TestControllerWin.cpp:
1346         (WTR::TestController::platformInitializeContext):
1347         Call WKContextSetShouldPaintNativeControls() to disable native control
1348         drawing.
1349
1350 2010-08-12  Sam Weinig  <sam@webkit.org>
1351
1352         Reviewed by Alexey Proskuryakov.
1353
1354         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
1355         https://bugs.webkit.org/show_bug.cgi?id=43653
1356
1357         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1358         (WTR::InjectedBundle::InjectedBundle):
1359         (WTR::InjectedBundle::didReceiveMessage):
1360         (WTR::InjectedBundle::beginTesting):
1361         (WTR::InjectedBundle::done):
1362         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1363         (WTR::InjectedBundle::isTestRunning):
1364         (WTR::InjectedBundle::):
1365         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1366         (WTR::InjectedBundlePage::stopLoading):
1367         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1368         (WTR::InjectedBundlePage::dump):
1369         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1370         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1371         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1372         (WTR::InjectedBundlePage::didClearWindowForFrame):
1373         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1374         (WTR::InjectedBundlePage::willAddMessageToConsole):
1375         (WTR::InjectedBundlePage::willSetStatusbarText):
1376         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1377         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1378         (WTR::InjectedBundlePage::shouldBeginEditing):
1379         (WTR::InjectedBundlePage::shouldEndEditing):
1380         (WTR::InjectedBundlePage::shouldInsertNode):
1381         (WTR::InjectedBundlePage::shouldInsertText):
1382         (WTR::InjectedBundlePage::shouldDeleteRange):
1383         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1384         (WTR::InjectedBundlePage::shouldApplyStyle):
1385         (WTR::InjectedBundlePage::didBeginEditing):
1386         (WTR::InjectedBundlePage::didEndEditing):
1387         (WTR::InjectedBundlePage::didChange):
1388         (WTR::InjectedBundlePage::didChangeSelection):
1389         Don't do any work if we are not currently running a test.
1390
1391         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1392         * WebKitTestRunner/StringFunctions.h:
1393         (WTR::toCF):
1394         Add conversion function for WKURLRef -> CFURLRef
1395
1396         * WebKitTestRunner/TestController.cpp:
1397         (WTR::TestController::TestController):
1398         (WTR::TestController::initialize):
1399         (WTR::TestController::resetStateToConsistentValues):
1400         (WTR::TestController::runTest):
1401         (WTR::TestController::didFinishLoadForFrame):
1402         * WebKitTestRunner/TestController.h:
1403         (WTR::TestController::):
1404         * WebKitTestRunner/TestInvocation.cpp:
1405         (WTR::TestInvocation::invoke):
1406         * WebKitTestRunner/TestInvocation.h:
1407         Move resetting code to TestController.
1408
1409         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1410         * WebKitTestRunner/mac/TestControllerMac.mm:
1411         (WTR::TestController::runUntil):
1412         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1413         * WebKitTestRunner/win/TestControllerWin.cpp:
1414         (WTR::TestController::runUntil):
1415         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
1416         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1417         Move runUntil to TestController.
1418
1419 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1420
1421         Unreviewed.
1422
1423         Adding myself to the committers list.
1424
1425         * Scripts/webkitpy/common/config/committers.py:
1426
1427 2010-08-12  Hayato Ito  <hayato@chromium.org>
1428
1429         Reviewed by Tony Chang.
1430
1431         Merge pretty printers for gdb.
1432         https://bugs.webkit.org/show_bug.cgi?id=43850
1433
1434         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
1435         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
1436         webcore.py is left for backward compatibility.
1437
1438         * gdb/webcore.py:
1439         * gdb/webkit.py: Added.
1440         * gdb/wtf.py: Removed.
1441
1442 2010-08-11  Tony Chang  <tony@chromium.org>
1443
1444         Reviewed by David Levin.
1445
1446         [chromium] add google-chrome layout test result directories
1447         https://bugs.webkit.org/show_bug.cgi?id=43889
1448
1449         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1450         * Scripts/webkitpy/layout_tests/port/factory.py:
1451         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
1452         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1453
1454 2010-08-11  Kent Tamura  <tkent@chromium.org>
1455
1456         Reviewed by Dimitri Glazkov.
1457
1458         [DRT/Chromium] Disable accelerated compositing
1459         https://bugs.webkit.org/show_bug.cgi?id=43894
1460
1461         Disable accelerated compositing because DRT is not ready for
1462         it. This change fixes hundreds of test crashes on Windows and
1463         Linux.
1464
1465         * DumpRenderTree/chromium/TestShell.cpp:
1466         (TestShell::resetWebSettings):
1467
1468 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1469
1470         Unreviewed. Adding my Collabora personality to the list.
1471
1472         * Scripts/webkitpy/common/config/committers.py:
1473
1474 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
1475
1476         Adding myself as a reviewer.
1477
1478         * Scripts/webkitpy/common/config/committers.py:
1479
1480 2010-08-11  Daniel Bates  <dbates@rim.com>
1481
1482         Reviewed by Darin Adler.
1483
1484         Perl warnings when running commit-log-editor
1485         https://bugs.webkit.org/show_bug.cgi?id=43856
1486
1487         Fixes Perl warnings introduced by the patch for Bug #40548.
1488
1489         Perl doesn't have symbolic names for True/False. Instead, we
1490         should use boolean values. Moreover, the variable installedEditorApplication
1491         is not be used and should be renamed builtEditorApplication so that it
1492         uses the existing machinery to set the commit log editor application.
1493
1494         * Scripts/commit-log-editor:
1495
1496 2010-08-11  Adam Barth  <abarth@webkit.org>
1497
1498         Reviewed by Eric Seidel.
1499
1500         Trying waiting for httpd lock in the EWS
1501         https://bugs.webkit.org/show_bug.cgi?id=43833
1502
1503         If this works, we can probably run the tests on the mac-ews, which
1504         would be very exciting.  :)
1505
1506         * Scripts/webkitpy/tool/steps/runtests.py:
1507
1508 2010-08-11  Marcus Bulach  <bulach@chromium.org>
1509
1510         Reviewed by Eric Seidel.
1511
1512         Check in a script to list redundant test outputs.
1513         https://bugs.webkit.org/show_bug.cgi?id=37630
1514
1515         If e.g. platform/mac-leopard is missing an expected test output, we
1516         fall back on platform/mac.  This means it's possible to grow redundant
1517         test outputs, where we have the same expected data in both a platform
1518         directory and another platform it falls back on.
1519         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
1520
1521         * Scripts/deduplicate-tests: Added.
1522         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
1523         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
1524
1525 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1526
1527         Reviewed by Ariya Hidayat.
1528
1529         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
1530         https://bugs.webkit.org/show_bug.cgi?id=43853
1531
1532         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
1533         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
1534         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
1535         to slots at all.
1536
1537         * QtTestBrowser/launcherwindow.cpp:
1538         (LauncherWindow::createChrome):
1539         (LauncherWindow::animatedFlip):
1540         (LauncherWindow::animatedYFlip):
1541         * QtTestBrowser/launcherwindow.h:
1542
1543 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
1544
1545         Reviewed by Simon Hausmann.
1546
1547         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
1548         https://bugs.webkit.org/show_bug.cgi?id=43851
1549
1550         All window options data (including the bool holding if the view is either QWebView or
1551         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
1552         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
1553         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
1554         getting broken.
1555
1556         Patch addresses this issue.
1557
1558         * QtTestBrowser/launcherwindow.cpp:
1559         (LauncherWindow::createChrome):
1560         (LauncherWindow::toggleWebView):
1561         (LauncherWindow::toggleAcceleratedCompositing):
1562
1563 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
1564
1565         Reviewed by Ariya Hidayat.
1566
1567         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
1568         https://bugs.webkit.org/show_bug.cgi?id=43831
1569
1570         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
1571
1572         * QtTestBrowser/webview.cpp:
1573         (WebViewGraphicsBased::WebViewGraphicsBased):
1574         (WebViewGraphicsBased::animatedYFlip):
1575
1576 2010-08-11  Darin Adler  <darin@apple.com>
1577
1578         Reviewed by John Sullivan.
1579
1580         Improved editor options for prepare-ChangeLog and commit-log-editor
1581         https://bugs.webkit.org/show_bug.cgi?id=40548
1582
1583         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
1584         values like "xed --launch --wait" work properly.
1585
1586         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
1587         use a command line tool with the $openChangeLogs feature.
1588
1589 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
1590
1591         Reviewed by Pavel Feldman.
1592
1593         Web Inspector: remove InjectDispatch.js
1594         https://bugs.webkit.org/show_bug.cgi?id=43835
1595
1596         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1597         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1598
1599 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
1600
1601         Reviewed by Eric Seidel.
1602
1603         webkit-patch should refuse to run under Win32 Python
1604         https://bugs.webkit.org/show_bug.cgi?id=40962
1605
1606         Given that there are lots of places in webkit-patch's code that
1607         assume unix-style filenames (forward slashes), webkit-patch fails
1608         with weird file-not-found errors when run under a native windows
1609         Python. It would be nice if we just trapped this and errored out
1610         at the beginning, rather than producing unpredictable errors.
1611
1612         * Scripts/webkit-patch:
1613
1614 2010-08-10  Kent Tamura  <tkent@chromium.org>
1615
1616         Unreviewed, build fix.
1617         
1618         Chromium build fix for r65107.
1619
1620         * DumpRenderTree/chromium/LayoutTestController.cpp:
1621         (LayoutTestController::suspendAnimations):
1622         (LayoutTestController::resumeAnimations):
1623
1624 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
1625
1626         Reviewed by Xan Lopez.
1627
1628         [GTK] http/tests/media/video-cookie.html fails
1629         https://bugs.webkit.org/show_bug.cgi?id=42240
1630
1631         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1632         (LayoutTestController::setAlwaysAcceptCookies): create the
1633         SoupCookieJar if it does not exist. Otherwise the accept policy
1634         won't be set.
1635
1636 2010-08-10  Chris Marrin  <cmarrin@apple.com>
1637
1638         Reviewed by Oliver Hunt.
1639
1640         Add suspendAnimations/resumeAnimation API to DRT
1641         https://bugs.webkit.org/show_bug.cgi?id=43733
1642         
1643         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
1644         Calls functions with the same names on AnimationController for the 
1645         mainFrame.
1646
1647         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1648         * DumpRenderTree/LayoutTestController.cpp:
1649         (suspendAnimationsCallback):
1650         (resumeAnimationsCallback):
1651         (LayoutTestController::staticFunctions):
1652         * DumpRenderTree/LayoutTestController.h:
1653         * DumpRenderTree/chromium/LayoutTestController.cpp:
1654         (LayoutTestController::LayoutTestController):
1655         (LayoutTestController::suspendAnimations):
1656         (LayoutTestController::resumeAnimations):
1657         * DumpRenderTree/chromium/LayoutTestController.h:
1658         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1659         (LayoutTestController::suspendAnimations):
1660         (LayoutTestController::resumeAnimations):
1661         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1662         (LayoutTestController::suspendAnimations):
1663         (LayoutTestController::resumeAnimations):
1664         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1665         (LayoutTestController::suspendAnimations):
1666         (LayoutTestController::resumeAnimations):
1667         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1668         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1669         (LayoutTestController::suspendAnimations):
1670         (LayoutTestController::resumeAnimations):
1671         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1672         (LayoutTestController::suspendAnimations):
1673         (LayoutTestController::resumeAnimations):
1674
1675 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1676
1677         Reviewed by Ojan Vafai.
1678
1679         [Chromium/DRT] Enable saving layout test results.
1680         https://bugs.webkit.org/show_bug.cgi?id=43796
1681
1682         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
1683             parameters to the new-run-webkit-tests, including the name
1684             of the test results server.
1685
1686 2010-08-10  Jian Li  <jianli@chromium.org>
1687
1688         More chromium build fix.
1689
1690         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1691         (MockSpellCheck::spellCheckWord):
1692         (MockSpellCheck::initializeIfNeeded):
1693         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1694         (NotificationPresenter::grantPermission):
1695         (NotificationPresenter::show):
1696         (NotificationPresenter::checkPermission):
1697
1698 2010-08-10  Jian Li  <jianli@chromium.org>
1699
1700         Chromium build fix.
1701
1702         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1703         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1704
1705 2010-08-10  Victor Wang  <victorw@chromium.org>
1706
1707         Reviewed by Ojan Vafai.
1708
1709         Update test results server merge logic so the aggregated
1710         results and times are updated for tests that are
1711         in aggragated json but not in incremental json.
1712
1713         Also update unittest to test this case.
1714
1715         https://bugs.webkit.org/show_bug.cgi?id=43769
1716
1717         * TestResultServer/model/jsonresults.py:
1718         * TestResultServer/model/jsonresults_unittest.py:
1719
1720 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1721
1722         Reviewed by Ariya Hidayat.
1723
1724         [Qt] QtTestBrowser: proper set scene rect
1725
1726         When resizesToContents is ON scene's rect is set to the boundary of
1727         the mainFrame. However, navigating to other web page should keep resizing
1728         scene's rect according to the new document loaded. Patch addresses this issue.
1729
1730         Now resizesToContents and scrolling properly work on QtTestBrowser.
1731
1732         * QtTestBrowser/webview.cpp:
1733         (WebViewGraphicsBased::setPage):
1734         (WebViewGraphicsBased::contentsSizeChanged):
1735         (WebViewGraphicsBased::setResizesToContents):
1736         (WebViewGraphicsBased::resizeEvent):
1737         * QtTestBrowser/webview.h:
1738
1739 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1740
1741         Reviewed by Ariya Hidayat.
1742
1743         [Qt] QtTestBrowser: Clean up LauncherWindow code.
1744
1745         * QtTestBrowser/launcherwindow.cpp:
1746         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
1747         (LauncherWindow::init): Fixed comments.
1748         (LauncherWindow::applyPrefs): Move the method around.
1749         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
1750
1751 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1752
1753         Reviewed by Ariya Hidayat.
1754
1755         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
1756
1757         It gets control+0 the same visual effect as control++ or control-.
1758
1759         * QtTestBrowser/launcherwindow.cpp:
1760         (LauncherWindow::toggleZoomTextOnly):
1761
1762 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
1763
1764         Reviewed by Ariya Hidayat.
1765
1766         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
1767
1768         Not all instances of LauncherWindow need its own m_zoomLevel.
1769
1770         * QtTestBrowser/launcherwindow.cpp:
1771         * QtTestBrowser/launcherwindow.h:
1772
1773 2010-08-09  Sam Weinig  <sam@webkit.org>
1774
1775         Reviewed by Geoffrey Garen.
1776
1777         Add zoom support for injected bundle
1778         https://bugs.webkit.org/show_bug.cgi?id=43759
1779
1780         Use zoom factor SPI to implement zoom related eventSender functions.
1781
1782         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1783         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1784         (WTR::EventSendingController::textZoomIn):
1785         (WTR::EventSendingController::textZoomOut):
1786         (WTR::EventSendingController::zoomPageIn):
1787         (WTR::EventSendingController::zoomPageOut):
1788         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1789         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1790         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
1791
1792 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
1793
1794         Speculative chromium build fix III.
1795
1796         * DumpRenderTree/chromium/MockSpellCheck.h:
1797         * DumpRenderTree/chromium/NotificationPresenter.h:
1798         * DumpRenderTree/chromium/WebViewHost.h:
1799         (WebViewHost::addClearHeader):
1800         (WebViewHost::clearHeaders):
1801
1802 2010-08-09  Ojan Vafai  <ojan@chromium.org>
1803
1804         Reviewed by Tony Chang.
1805
1806         increase the number of test results that we save
1807         https://bugs.webkit.org/show_bug.cgi?id=43763
1808
1809         Now that we do incremental uploads, we can increase the number of
1810         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
1811
1812         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1813
1814 2010-08-09  Evan Martin  <evan@chromium.org>
1815
1816         Reviewed by Tony Chang.
1817
1818         [chromium] DRT error print statement incorrectly tries to print a FILE*
1819         https://bugs.webkit.org/show_bug.cgi?id=43747
1820
1821         * DumpRenderTree/chromium/ImageDiff.cpp:
1822         (writeFile): pass the correct pointer.
1823
1824 2010-08-09  Victor Wang  <victorw@chromium.org>
1825
1826         Reviewed by Ojan Vafai.
1827
1828         Upload incremental test results json to server by default.
1829
1830         https://bugs.webkit.org/show_bug.cgi?id=43743
1831
1832         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1833
1834 2010-08-09  Eric Seidel  <eric@webkit.org>
1835
1836         Reviewed by Adam Barth.
1837
1838         EWS bots wait 2 minutes between patches
1839         https://bugs.webkit.org/show_bug.cgi?id=43731
1840
1841         * Scripts/webkitpy/tool/bot/queueengine.py:
1842          - Don't sleep after failures.  This was a hold-over from
1843            an earlier design.
1844         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1845          - EWS bots were not properly reporting true/false from process_work_item.
1846            They were always returning None, thus false, thus always logging
1847            as a failure and sleeping 2 minutes after each patch.
1848
1849 2010-08-09  Sam Weinig  <sam@webkit.org>
1850
1851         Reviewed by Anders Carlsson.
1852
1853         Stub out EventSender for WebKitTestRunner
1854         https://bugs.webkit.org/show_bug.cgi?id=43703
1855
1856         * WebKitTestRunner/DerivedSources.make:
1857         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1858         Add ability to pass javascript arguments to the wrapped object.
1859
1860         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
1861         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
1862         (WTR::EventSendingController::create):
1863         (WTR::EventSendingController::EventSendingController):
1864         (WTR::EventSendingController::~EventSendingController):
1865         (WTR::EventSendingController::wrapperClass):
1866         (WTR::setExceptionForString):
1867         (WTR::EventSendingController::mouseDown):
1868         (WTR::EventSendingController::mouseUp):
1869         (WTR::EventSendingController::mouseMoveTo):
1870         (WTR::EventSendingController::keyDown):
1871         (WTR::EventSendingController::contextClick):
1872         (WTR::EventSendingController::leapForward):
1873         (WTR::EventSendingController::textZoomIn):
1874         (WTR::EventSendingController::textZoomOut):
1875         (WTR::EventSendingController::zoomPageIn):
1876         (WTR::EventSendingController::zoomPageOut):
1877         (WTR::EventSendingController::makeWindowObject):
1878         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
1879         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1880         (WTR::InjectedBundle::reset):
1881         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1882         (WTR::InjectedBundle::eventSendingController):
1883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1884         (WTR::InjectedBundlePage::didClearWindowForFrame):
1885         Add stubbed out EventSenderController.
1886
1887         * WebKitTestRunner/InjectedBundle/GCController.h:
1888         Remove incorrect comment.
1889
1890         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1891         * WebKitTestRunner/win/InjectedBundle.vcproj:
1892         Add new files.
1893
1894 2010-08-08  Kent Tamura  <tkent@chromium.org>
1895
1896         Unreviewed, trivial fix.
1897
1898         Fix "WindowsError: [Error 32] The process cannot access the file
1899         because it is being used by another process" introduced by r64959.
1900
1901         * BuildSlaveSupport/test-result-archive:
1902
1903 2010-08-08  Kent Tamura  <tkent@chromium.org>
1904
1905         Reviewed by Tony Chang.
1906
1907         Chromium buildbot: Avoid "zip" command dependency
1908         https://bugs.webkit.org/show_bug.cgi?id=43470
1909
1910         * BuildSlaveSupport/test-result-archive:
1911          For Chromium port, creates a zip archive with zipfile package of Python
1912          instead of external "zip" command. We'd like to avoid additional
1913          command installation.
1914
1915 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
1916
1917         WebKitTestRunner should add the QuickTime dir to the PATH environment
1918         variable
1919         https://bugs.webkit.org/show_bug.cgi?id=43686
1920
1921         Reviewed by Dan Bernstein.
1922
1923         * WebKitTestRunner/win/TestControllerWin.cpp:
1924         (WTR::addQTDirToPATH):
1925         Copied from DRT.
1926         (WTR::TestController::platformInitialize):
1927         Call addQTDirToPath().
1928         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1929         Link to shlwapi.lib for SHGetValue.
1930
1931 2010-08-07  Sam Weinig  <sam@webkit.org>
1932
1933         Reviewed by Maciej Stachowiak.
1934
1935         WebKitTestRunner needs layoutTestController.dumpTitleChanges
1936         <rdar://problem/8213861>
1937         https://bugs.webkit.org/show_bug.cgi?id=42683
1938
1939         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1940         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1941         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1942         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1943         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1944         (WTR::LayoutTestController::LayoutTestController):
1945         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1946         (WTR::LayoutTestController::dumpTitleChanges):
1947         (WTR::LayoutTestController::shouldDumpTitleChanges):
1948
1949 2010-08-07  Sam Weinig  <sam@webkit.org>
1950
1951         Reviewed by Anders Carlsson.
1952
1953         WebKitTestRunner needs to print onunload handler information
1954         <rdar://problem/8213831>
1955         https://bugs.webkit.org/show_bug.cgi?id=42703
1956
1957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1958         (WTR::operator<<):
1959         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1960
1961 2010-08-07  Sam Weinig  <sam@webkit.org>
1962
1963         Reviewed by Anders Carlsson.
1964
1965         Add additional loader client functions need to complete WebKitTestRunner
1966         https://bugs.webkit.org/show_bug.cgi?id=43684
1967
1968         Remove unnecessary and jarring underscores as well.
1969
1970         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1971         (didClearWindowObjectForFrame):
1972         (didCreatePage):
1973         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1974         (WTR::InjectedBundlePage::InjectedBundlePage):
1975         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1976         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1977         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1978         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1979         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1980         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1981         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1982         (WTR::InjectedBundlePage::didClearWindowForFrame):
1983         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1984         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1985         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1986         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1987         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1988         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1989         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1990         (WTR::InjectedBundlePage::willAddMessageToConsole):
1991         (WTR::InjectedBundlePage::willSetStatusbarText):
1992         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1993         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1994         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1995         (WTR::InjectedBundlePage::shouldBeginEditing):
1996         (WTR::InjectedBundlePage::shouldEndEditing):
1997         (WTR::InjectedBundlePage::shouldInsertNode):
1998         (WTR::InjectedBundlePage::shouldInsertText):
1999         (WTR::InjectedBundlePage::shouldDeleteRange):
2000         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2001         (WTR::InjectedBundlePage::shouldApplyStyle):
2002         (WTR::InjectedBundlePage::didBeginEditing):
2003         (WTR::InjectedBundlePage::didEndEditing):
2004         (WTR::InjectedBundlePage::didChange):
2005         (WTR::InjectedBundlePage::didChangeSelection):
2006         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2007
2008 2010-08-07  Dan Bernstein  <mitz@apple.com>
2009
2010         Build fix.
2011
2012         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
2013         to JSGCController.{cpp,h} relative to the build root.
2014
2015 2010-08-07  Sam Weinig  <sam@webkit.org>
2016
2017         Reviewed by Anders Carlsson.
2018
2019         WebKitTestRunner needs GCController
2020         <rdar://problem/8213834>
2021         https://bugs.webkit.org/show_bug.cgi?id=42701
2022
2023         * WebKitTestRunner/DerivedSources.make:
2024         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
2025         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2026         (WTR::setProperty):
2027         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
2028         (WTR::GCController::create):
2029         (WTR::GCController::GCController):
2030         (WTR::GCController::~GCController):
2031         (WTR::GCController::wrapperClass):
2032         (WTR::GCController::collect):
2033         (WTR::GCController::collectOnAlternateThread):
2034         (WTR::GCController::getJSObjectCount):
2035         (WTR::GCController::makeWindowObject):
2036         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
2037         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2038         (WTR::InjectedBundle::reset):
2039         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2040         (WTR::InjectedBundle::bundle):
2041         (WTR::InjectedBundle::gcController):
2042         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2043         (WTR::InjectedBundlePage::didClearWindowForFrame):
2044         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2045         (WTR::LayoutTestController::keepWebHistory):
2046         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2047         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2048         * WebKitTestRunner/win/InjectedBundle.vcproj:
2049
2050 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
2051
2052         WebKitTestRunner needs to be able to set the font smoothing type
2053         https://bugs.webkit.org/show_bug.cgi?id=43406
2054
2055         Reviewed by Adam Roben.
2056
2057         * WebKitTestRunner/TestInvocation.cpp:
2058         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2059         Set the font smoothing level to
2060         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
2061
2062 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2063
2064         Fix a missed variable rename.
2065
2066         Unreviewed.
2067
2068         * Scripts/old-run-webkit-tests:
2069
2070 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2071
2072         mac-wk2/Skipped should be used on Windows when running regression tests
2073         https://bugs.webkit.org/show_bug.cgi?id=43494
2074
2075         Reviewed by Adam Roben.
2076
2077         * Scripts/old-run-webkit-tests:
2078         If the platform is win-wk2, also read the mac-wk2 skipped list.
2079
2080 2010-08-06  Kent Tamura  <tkent@chromium.org>
2081
2082         Reviewed by Dimitri Glazkov.
2083
2084         [DRT/Chromium] Should revoke scheduled tasks
2085         https://bugs.webkit.org/show_bug.cgi?id=43560
2086
2087         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2088         (DRTDevToolsAgent::reset): Calls RevokeAll().
2089         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2090         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2091         (DRTDevToolsClient::reset): Calls RevokeAll().
2092         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2093         * DumpRenderTree/chromium/EventSender.cpp:
2094         (EventSender::reset): Calls RevokeAll().
2095         * DumpRenderTree/chromium/LayoutTestController.cpp:
2096         (LayoutTestController::reset): Calls RevokeAll().
2097         * DumpRenderTree/chromium/TestShell.cpp:
2098         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
2099
2100 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2101
2102         Reviewed by Antonio Gomes.
2103
2104         [Qt] Fix the DRT build on Mac OS X
2105
2106         * DumpRenderTree/qt/DumpRenderTree.pro:
2107
2108 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
2109
2110         Reviewed by Pavel Feldman.
2111
2112         Rietvield's upload.py moved to a different location.
2113         https://bugs.webkit.org/show_bug.cgi?id=43613
2114
2115         * Scripts/webkitpy/thirdparty/__init__.py:
2116
2117 2010-05-23  Eric Seidel  <eric@webkit.org>
2118
2119         Reviewed by Adam Barth.
2120
2121         QueueStatusServer needs better queue-status pages
2122         https://bugs.webkit.org/show_bug.cgi?id=39562
2123
2124         The primary goal of this patch is to display queue
2125         positions somewhere on the site so that it's easier
2126         for commit-queue users to know when their pach will
2127         be landed.  I also tried to improve the root page
2128         to be more useful than the previous wall of status text.
2129
2130         * QueueStatusServer/handlers/recentstatus.py:
2131         * QueueStatusServer/main.py:
2132         * QueueStatusServer/model/queues.py:
2133         * QueueStatusServer/templates/recentstatus.html:
2134
2135 2010-08-05  Victor Wang  <victorw@chromium.org>
2136
2137         Reviewed by Ojan Vafai.
2138
2139         Add option to generate/upload incremental json results to test result server.
2140         Also refactor the json results generator unittest code to test
2141         incremental and aggregated json results.
2142
2143         https://bugs.webkit.org/show_bug.cgi?id=43519
2144
2145         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2146         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2147         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2149
2150 2010-08-05  Jian Li  <jianli@chromium.org>
2151
2152         Reviewed by David Levin.
2153
2154         Unify blob related feature defines to ENABLE(BLOB).
2155         https://bugs.webkit.org/show_bug.cgi?id=43081
2156
2157         * Scripts/build-webkit:
2158
2159 2010-08-05  Satish Sampath  <satish@chromium.org>
2160
2161         Reviewed by Jeremy Orlow.
2162
2163         Add speech input controller mock in WebKit and a layout test.
2164         https://bugs.webkit.org/show_bug.cgi?id=43477
2165
2166         Added LayoutTestController::setMockSpeechInputResultCallback method.
2167
2168         * DumpRenderTree/LayoutTestController.cpp:
2169         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
2170         (LayoutTestController::staticFunctions):
2171         * DumpRenderTree/LayoutTestController.h:
2172         * DumpRenderTree/chromium/LayoutTestController.cpp:
2173         (LayoutTestController::LayoutTestController):
2174         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
2175         (LayoutTestController::speechInputController): Creates the mock controller.
2176         * DumpRenderTree/chromium/LayoutTestController.h:
2177         * DumpRenderTree/chromium/WebViewHost.cpp:
2178         (WebViewHost::speechInputController): Creates the mock controller.
2179         * DumpRenderTree/chromium/WebViewHost.h:
2180         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2181         (LayoutTestController::setMockSpeechInputResult): dummy method.
2182         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2183         (LayoutTestController::setMockSpeechInputResult): dummy method.
2184         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2185         (LayoutTestController::setMockSpeechInputResult): dummy method.
2186         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2187         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
2188         (LayoutTestController::setMockSpeechInputResult):
2189         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
2190         (LayoutTestController::setMockSpeechInputResult):
2191
2192 2010-08-04  Adam Roben  <aroben@apple.com>
2193
2194         Fix the path to TestNetscapePlugin's directory on Windows
2195
2196         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
2197         load TestNetscapePlugin
2198
2199         Reviewed by Jon Honeycutt.
2200
2201         * WebKitTestRunner/win/TestControllerWin.cpp:
2202         (WTR::TestController::initializeTestPluginDirectory):
2203         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
2204         next to WebKitTestRunner.exe. Previously we were passing the directory
2205         that contains WebKitTestRunner.exe. Also fixed some leaks.
2206
2207 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
2208
2209         Reviewed by Shinichiro Hamaji.
2210
2211         check-webkit-style returns non-zero when patch is entirely minus lines.
2212         https://bugs.webkit.org/show_bug.cgi?id=38169
2213
2214         * Scripts/check-webkit-style:
2215         Check whether a patch contains modified files that are entirely minus lines.
2216         * Scripts/webkitpy/style/filereader.py:
2217         Add a variable that holds number of files that contain only deleted lines.
2218         * Scripts/webkitpy/style/patchreader.py:
2219         Count up modified files that contain only deleted lines.
2220
2221 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
2222
2223         Reviewed by Yury Semikhatsky.
2224
2225         DevTools: get rid of delayed command dispatching on front-end side.
2226
2227         https://bugs.webkit.org/show_bug.cgi?id=43479
2228
2229         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2230         (DRTDevToolsAgent::detach):
2231         (DRTDevToolsAgent::frontendLoaded):
2232         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2233         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2234         (DRTDevToolsClient::~DRTDevToolsClient):
2235         (DRTDevToolsClient::sendFrontendLoaded):
2236         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2237
2238 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
2239
2240         Reviewed by Shinichiro Hamaji.
2241
2242         Fixes check-webkit-style false positive on "new uint32_t."
2243         https://bugs.webkit.org/show_bug.cgi?id=43077
2244
2245         * Scripts/webkitpy/style/checkers/cpp.py:
2246         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2247
2248 2010-08-04  Kent Tamura  <tkent@chromium.org>
2249
2250         Reviewed by Dimitri Glazkov.
2251
2252         [DRT/Chromium] Remove base/linked_ptr.h dependency
2253         https://bugs.webkit.org/show_bug.cgi?id=43472
2254
2255         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
2256         We need to use RefPtr<> because m_pendingEntry points an object in
2257         m_entries or not in m_entries.
2258
2259         * DumpRenderTree/chromium/TestNavigationController.cpp:
2260         (TestNavigationEntry::create): Added.
2261         (TestNavigationController::activeEntry):
2262         (TestNavigationController::didNavigateToEntry):
2263         (TestNavigationController::discardPendingEntry):
2264         (TestNavigationController::insertEntry):
2265         (TestNavigationController::navigateToPendingEntry):
2266         * DumpRenderTree/chromium/TestNavigationController.h:
2267         * DumpRenderTree/chromium/WebViewHost.cpp:
2268         (WebViewHost::loadURLForFrame):
2269          Use TestNavigationEntry::create().
2270         (WebViewHost::updateURL):
2271          Use RefPtr<>.
2272         (WebViewHost::updateSessionHistory):
2273          Remove unnecessary static_cast<>.
2274
2275 2010-08-04  Kent Tamura  <tkent@chromium.org>
2276
2277         Reviewed by Dimitri Glazkov.
2278
2279         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
2280         https://bugs.webkit.org/show_bug.cgi?id=43333
2281
2282         * BuildSlaveSupport/test-result-archive:
2283           - Make layoutTestResultsDir local and pass it to archiveTestResults()
2284           - Adjust layoutTestResultsDir for Chromium
2285
2286 2010-08-04  Kent Tamura  <tkent@chromium.org>
2287
2288         Reviewed by Dimitri Glazkov.
2289
2290         NRWT: websocket_server startup detection failure
2291         https://bugs.webkit.org/show_bug.cgi?id=43466
2292
2293         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2294          Increase timeout value: 5 second -> 10 second
2295
2296 2010-08-04  Victor Wang  <victorw@chromium.org>
2297
2298         Reviewed by Ojan Vafai.
2299
2300         -. Add result.json incremental merging functionality to test results app engine.
2301         -. blobstore is not suitable for AE data merging and there is no API to
2302            programatically edit existing blob or write a new one yet, so replace blobstore
2303            with datastore. If file is oversize (>1000*1000 bytes), store file data in
2304            multiple datastore entries.
2305         -. Fix styles.
2306
2307         Test: jsonresults_unittest to test merging logics.
2308
2309         https://bugs.webkit.org/show_bug.cgi?id=38599
2310
2311         * TestResultServer/handlers/dashboardhandler.py:
2312         * TestResultServer/handlers/menu.py:
2313         * TestResultServer/handlers/testfilehandler.py:
2314         * TestResultServer/main.py:
2315         * TestResultServer/model/dashboardfile.py:
2316         * TestResultServer/model/datastorefile.py: Added.
2317         * TestResultServer/model/jsonresults.py: Added.
2318         * TestResultServer/model/jsonresults_unittest.py: Added.
2319         * TestResultServer/model/testfile.py:
2320         * TestResultServer/templates/uploadform.html:
2321
2322 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2323
2324         Reviewed by Kenneth Christiansen.
2325
2326         [Qt] [QtTestBrowser] Remove unneeded QAction class members
2327         https://bugs.webkit.org/show_bug.cgi?id=43518
2328
2329         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
2330         m_flipYAnimated. Also, in initializeView method there are some dead code block
2331         trying to connect them at the wrong time, when they have not been instanciated.
2332
2333         This patch:
2334
2335         - removes the two cited class members in favor of local variables in createChrome method;
2336         - removes the dead code block.
2337
2338         * QtTestBrowser/launcherwindow.cpp:
2339         (LauncherWindow::LauncherWindow):
2340         (LauncherWindow::initializeView):
2341         (LauncherWindow::createChrome):
2342         * QtTestBrowser/launcherwindow.h:
2343
2344 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
2345
2346         Reviewed by Simon Hausmann and Kenneth Christiansen.
2347
2348         [Qt] [QtTestBrowser] Clean up static and global menu state controls
2349         https://bugs.webkit.org/show_bug.cgi?id=43448
2350
2351         After LauncherWindow class was refactored out of from main.cpp, all global variables that
2352         were hanging in main.cpp became temporarily public static class members of newly added
2353         LauncherWindow class. This design was not properly handling the initial purpose of the
2354         global variables: newly created launcher windows should inherit the settings of the originating
2355         one.
2356
2357         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
2358         comprises all data needed to handling the goal described above.
2359
2360         * QtTestBrowser/launcherwindow.cpp:
2361         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
2362                                           holding all user settings configured in the menus and command line.
2363                                           It also receices an optional QGraphicsScene points in case we are doing
2364                                           a "Clone Window".
2365         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
2366                                 value.
2367         (LauncherWindow::initializeView): Ditto.
2368         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
2369         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
2370                                       apply the preferences is provided by m_userData.
2371         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
2372         (LauncherWindow::toggleResizesToContents): Ditto.
2373         (LauncherWindow::toggleWebGL): Ditto.
2374         (LauncherWindow::toggleFrameFlattening): Ditto.
2375         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
2376         (LauncherWindow::changeViewportUpdateMode): Ditto.
2377         (LauncherWindow::showFPS): Ditto.
2378         (LauncherWindow::newWindow): Changed to pass the userData.
2379         (LauncherWindow::cloneWindow): Ditto.
2380         * QtTestBrowser/launcherwindow.h:
2381         (WindowOptions::WindowOptions):
2382         * QtTestBrowser/main.cpp:
2383         (requiresGraphicsView):
2384         (LauncherApplication::handleUserOptions):
2385         (main):
2386
2387 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
2388
2389         [wx] Build fix for gcc not importing all symbols from convenience libraries.
2390         Works on 10.6 only for Mac until the build system is reworked. 
2391
2392         * wx/build/settings.py:
2393
2394 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
2395
2396         Reviewed by Simon Hausmann.
2397
2398         [Qt] Change wording in QtTestBrowser
2399         https://bugs.webkit.org/show_bug.cgi?id=43241
2400
2401         * QtTestBrowser/launcherwindow.cpp:
2402         (LauncherWindow::createChrome):
2403
2404 2010-08-04  Aaron Boodman  <aa@chromium.org>
2405
2406         Reviewed by Eric Seidel.
2407
2408         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
2409         https://bugs.webkit.org/show_bug.cgi?id=43460
2410
2411         * Scripts/prepare-ChangeLog:
2412
2413 2010-08-03  MORITA Hajime  <morrita@google.com>
2414
2415         Reviewed by Tony Chang.
2416
2417         [DRT] Assertion failed when drag and move a draggable element.
2418         https://bugs.webkit.org/show_bug.cgi?id=41695
2419
2420         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
2421         But Cocoa doesn't call mouseDragged() until dragging is done.
2422         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
2423         on UIDelegate failed when mouseDragged() is called during dragging.
2424         This change eliminated the mouseDragged() call when dragging begins,
2425         which is implicated by draggingInfo instance.
2426         
2427         * DumpRenderTree/mac/EventSendingController.mm:
2428         (-[EventSendingController mouseMoveToX:Y:]):
2429
2430         Test: fast/events/dragging-mouse-moves.html
2431         
2432 2010-08-02  Steve Block  <steveblock@google.com>
2433
2434         Reviewed by Alexey Proskuryakov.
2435
2436         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
2437         https://bugs.webkit.org/show_bug.cgi?id=40002
2438
2439         The code in LayoutTestController::setGeolocationPermission() was moved to
2440         setGeolocationPermissionCommon() to allow each port to provide its own
2441         implementation of setGeolocationPermission().
2442
2443         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
2444         new permission, so it can call back to WebCore if permission requests are in
2445         progress and are waiting for a response. A minor fix to the Mac
2446         MockGeolocationProvider was also required to make sure that the mock provider
2447         calls back to WebCore when it is first started.
2448
2449         For other ports, LayoutTestController::setGeolocationPermission() is not
2450         implemented.
2451
2452         * DumpRenderTree/LayoutTestController.cpp:
2453         (LayoutTestController::setGeolocationPermissionCommon):
2454         * DumpRenderTree/LayoutTestController.h:
2455         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2456         (LayoutTestController::setGeolocationPermission):
2457         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2458         (LayoutTestController::setGeolocationPermission):
2459         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2460         (-[MockGeolocationProvider registerWebView:]):
2461         * DumpRenderTree/mac/UIDelegate.h:
2462         * DumpRenderTree/mac/UIDelegate.mm:
2463         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2464         (-[UIDelegate setGeolocationPermission:]):
2465         (-[UIDelegate dealloc]):
2466         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2467         (LayoutTestController::setGeolocationPermission):
2468         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2469         (LayoutTestController::setGeolocationPermission):
2470
2471 2010-08-03  Kent Tamura  <tkent@chromium.org>
2472
2473         Reviewed by Dimitri Glazkov.
2474
2475         [DRT/Chromium] Implement --testshell-startup-dialog
2476         https://bugs.webkit.org/show_bug.cgi?id=40616
2477
2478         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2479         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
2480         if it is specfied.
2481         * DumpRenderTree/chromium/TestShell.h:
2482           Declare openStartUpDialog().
2483         * DumpRenderTree/chromium/TestShellGtk.cpp:
2484         (openStartupDialog):
2485         * DumpRenderTree/chromium/TestShellMac.mm:
2486         (openStartupDialog):
2487         * DumpRenderTree/chromium/TestShellWin.cpp:
2488         (openStartupDialog):
2489
2490 2010-08-03  Kent Tamura  <tkent@chromium.org>
2491
2492         Reviewed by Dimitri Glazkov.
2493
2494         [DRT/Chromium] Remove dependency of base/md5.h
2495         https://bugs.webkit.org/show_bug.cgi?id=43403
2496
2497         * DumpRenderTree/chromium/TestShell.cpp:
2498         (TestShell::dumpImage): Use wtf/MD5.h
2499
2500 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2501
2502         Reviewed by David Kilzer.
2503
2504         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2505         https://bugs.webkit.org/show_bug.cgi?id=40627
2506
2507         Part 6 - LayoutTest and Cleanup
2508
2509           Allow tests to delete application caches and set application cache
2510           origin quotas, so they can be tested.
2511
2512         * DumpRenderTree/LayoutTestController.cpp:
2513         (LayoutTestController::LayoutTestController):
2514         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
2515         (clearAllApplicationCachesCallback): should delete all application caches.
2516         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
2517         (LayoutTestController::staticFunctions):
2518         * DumpRenderTree/LayoutTestController.h:
2519         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
2520         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
2521
2522           Mac implementation.
2523
2524         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2525         (LayoutTestController::clearAllApplicationCaches): delete application caches.
2526         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
2527         * DumpRenderTree/mac/UIDelegate.mm:
2528         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
2529         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
2530
2531           Stub implementations for other platforms.
2532
2533         * DumpRenderTree/chromium/LayoutTestController.cpp:
2534         (LayoutTestController::LayoutTestController):
2535         (LayoutTestController::clearAllApplicationCaches):
2536         (LayoutTestController::setApplicationCacheOriginQuota):
2537         * DumpRenderTree/chromium/LayoutTestController.h:
2538         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2539         (LayoutTestController::clearAllApplicationCaches):
2540         (LayoutTestController::setApplicationCacheOriginQuota):
2541         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2542         (LayoutTestController::clearAllApplicationCaches):
2543         (LayoutTestController::setApplicationCacheOriginQuota):
2544         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2545         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2546         (LayoutTestController::clearAllApplicationCaches):
2547         (LayoutTestController::setApplicationCacheOriginQuota):
2548         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2549         (LayoutTestController::clearAllApplicationCaches):
2550         (LayoutTestController::setApplicationCacheOriginQuota):
2551
2552 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
2553
2554         Reviewed by David Kilzer.
2555
2556         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
2557         https://bugs.webkit.org/show_bug.cgi?id=40627
2558
2559         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
2560
2561           Change old style calls to make use of the managers.
2562
2563         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2564         (LayoutTestController::setDatabaseQuota):
2565         * DumpRenderTree/mac/UIDelegate.mm:
2566         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2567
2568 2010-08-03  Mark Rowe  <mrowe@apple.com>
2569
2570         Add a new Leopard build slave to run the release tests.
2571
2572         * BuildSlaveSupport/build.webkit.org-config/config.json:
2573
2574 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
2575
2576         WebKitTestRunner needs to activate the Mac font ascent hack
2577         https://bugs.webkit.org/show_bug.cgi?id=43404
2578
2579         Reviewed by Darin Adler.
2580
2581         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2582         (WTR::InjectedBundle::initialize):
2583         Call WKBundleActivateMacFontAscentHack().
2584
2585 2010-08-03  Alex Milowski  <alex@milowski.com>
2586
2587         Reviewed by Beth Dakin.
2588
2589         Changed the default for MathML support so that is is enabled by default.
2590
2591         * Scripts/build-webkit:
2592
2593 2010-08-03  Sam Weinig  <sam@webkit.org>
2594
2595         Roll r64566 back in this time with all the overloads in place..
2596
2597         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2598         (WTR::InjectedBundlePage::shouldInsertNode):
2599         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2600         * WebKitTestRunner/StringFunctions.h:
2601         * WebKitTestRunner/TestInvocation.cpp:
2602         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2603         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2604         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2605
2606 2010-08-03  Sam Weinig  <sam@webkit.org>
2607
2608         Rollout r64566. It broke all the WebKit2 tests.
2609
2610         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2611         (WTR::operator<<):
2612         (WTR::InjectedBundlePage::shouldInsertNode):
2613         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2614         * WebKitTestRunner/StringFunctions.h: Removed.
2615         * WebKitTestRunner/TestInvocation.cpp:
2616         (WTR::createWKURL):
2617         (WTR::WKStringToUTF8):
2618         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2619         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2620         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2621
2622 2010-08-03  Sam Weinig  <sam@webkit.org>
2623
2624         Reviewed by Anders Carlsson.
2625
2626         WTR: Move all the utility functions for working with strings to a shared header.
2627         https://bugs.webkit.org/show_bug.cgi?id=43386
2628
2629         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2630         (WTR::InjectedBundlePage::shouldInsertNode):
2631         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2632         * WebKitTestRunner/StringFunctions.h: Added.
2633         * WebKitTestRunner/TestInvocation.cpp:
2634         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2635         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2636         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2637
2638 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
2639
2640         Reviewed by Kenneth Christiansen.
2641
2642         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
2643         https://bugs.webkit.org/show_bug.cgi?id=43168
2644
2645         QGraphicsWebView resizesToContents property has to work together with QWebPage's
2646         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
2647
2648         * QtTestBrowser/launcherwindow.cpp:
2649         (LauncherWindow::applyPrefs):
2650         * QtTestBrowser/webview.cpp:
2651         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
2652                                                       needed when toggle resizesToContents on/off.
2653         (WebViewGraphicsBased::resizeEvent):
2654         * QtTestBrowser/webview.h:
2655         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
2656         (WebViewGraphicsBased::customLayoutSize): Getter helper.
2657
2658 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
2659
2660         Unreviewed. Adding myself as committer.
2661
2662         * Scripts/webkitpy/common/config/committers.py:
2663
2664 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
2665
2666         Reviewed by Yury Semikhatsky.
2667
2668         Chromium DevTools: Get rid of DevTools RPC.
2669
2670         https://bugs.webkit.org/show_bug.cgi?id=43335
2671
2672         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2673         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
2674         (DRTDevToolsAgent::call):
2675         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2676         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
2677         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
2678         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2679         (DRTDevToolsClient::sendMessageToBackend):
2680         (DRTDevToolsClient::call):
2681         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2682
2683 2010-08-02  Kent Tamura  <tkent@chromium.org>
2684
2685         Reviewed by Dimitri Glazkov.
2686
2687         [DRT/Chromium] Remove dependencies to some Chromium headers
2688         https://bugs.webkit.org/show_bug.cgi?id=43396
2689
2690         * DumpRenderTree/chromium/CppVariant.h:
2691          Remove base/basictypes.h because webkit_support.h contains it.
2692         * DumpRenderTree/chromium/EventSender.cpp:
2693         (getCurrentEventTimeSec): Use new wrapper function.
2694         * DumpRenderTree/chromium/TestNavigationController.h:
2695          Remove base/basictypes.h because webkit_support.h contains it.
2696         * DumpRenderTree/chromium/TestShell.cpp:
2697         (dumpHistoryItem): Use new wrapper function.
2698         * DumpRenderTree/chromium/WebViewHost.cpp:
2699         (WebViewHost::cancelledError): Use new wrapper function.
2700         (WebViewHost::didFailResourceLoad): Use new wrapper function.
2701
2702 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2703
2704         Reviewed by Xan Lopez.
2705
2706         [GTK] DRT implement execCommand()
2707         https://bugs.webkit.org/show_bug.cgi?id=35351
2708
2709         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2710         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
2711         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
2712         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
2713
2714 2010-08-02  Sam Weinig  <sam@webkit.org>
2715
2716         Reviewed by Anders Carlsson.
2717
2718         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
2719
2720         * Scripts/old-run-webkit-tests:
2721
2722 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2723
2724         WebKitTestRunner needs to support loading custom fonts (via the
2725         WEBKIT_TESTFONTS environment variable)
2726         https://bugs.webkit.org/show_bug.cgi?id=42782
2727
2728         Reviewed by Adam Roben.
2729
2730         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2731         (WTR::fontsPath):
2732         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
2733         as this directory doesn't appear to be created anymore.
2734         (WTR::activateFonts):
2735         Loop through the fonts, and call AddFontResourceExW() for each.
2736
2737 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2738
2739         Restore the WebKitTestRunner.sln that was removed, and remove the
2740         correct one.
2741
2742         Rubber-stamped by Sam Weinig.
2743
2744         * WebKitTestRunner/WebKitTestRunner.sln: Added.
2745         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
2746
2747 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
2748
2749         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
2750
2751         Remove the unused WebKitTestRunner.sln.
2752
2753         Reviewed by Sam Weinig.
2754
2755         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2756         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
2757         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
2758         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
2759         * WebKitTestRunner/win/WebKitTestRunner.sln:
2760
2761 2010-08-02  Sam Weinig  <sam@webkit.org>
2762
2763         Fix the windows build.
2764
2765         * WebKitTestRunner/win/main.cpp:
2766
2767 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
2768
2769         Add a Skipped list on Windows, and have run-webkit-tests respect it.
2770
2771         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
2772         there are zero tests failing
2773         https://bugs.webkit.org/show_bug.cgi?id=43374
2774
2775         Reviewed by Adam Roben.
2776
2777         * Scripts/old-run-webkit-tests:
2778         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
2779         win-wk2. When building the result hierarchy, if the platform is win-wk2,
2780         add it first to the list of platforms.
2781
2782 2010-08-02  Darin Adler  <darin@apple.com>
2783
2784         Reviewed by Sam Weinig.
2785
2786         WebKitTestRunner needs layoutTestController.setCanOpenWindows
2787         https://bugs.webkit.org/show_bug.cgi?id=42321
2788
2789         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
2790         https://bugs.webkit.org/show_bug.cgi?id=42779
2791
2792         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
2793         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
2794
2795         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2796         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
2797         waiting for the first call to didCreatePage.
2798         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
2799         is created. Put other pages into a map.
2800         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
2801         of the main page.
2802         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
2803         the main page.
2804         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
2805         closeOtherPages functions.
2806
2807         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2808         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
2809         the main page affect dumping.
2810         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
2811
2812         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2813         (WTR::LayoutTestController::LayoutTestController): Initialize the new
2814         m_shouldCloseExtraWindows member.
2815         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
2816         (WTR::LayoutTestController::windowCount): Added.
2817
2818         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2819         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
2820         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
2821         m_shouldCloseExtraWindows.
2822
2823         * WebKitTestRunner/TestController.cpp:
2824         (WTR::TestController::shared): Return a pointer to the shared copy, but
2825         don't allocate and leak it. This seemed cleaner than adding an explicit
2826         finalize call to go along with the explicit initialize call.
2827         (WTR::TestController::TestController): Added calls to the initialize and
2828         run function, which are now done automatically.
2829         (WTR::TestController::~TestController): Added, since it's called now.
2830         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
2831         (WTR::createOtherPage): Added. Used to create pages other than the main page.
2832         (WTR::TestController::initialize): Added code to set up createOtherPage.
2833         (WTR::TestController::run): Removed unused return value.
2834         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
2835         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
2836
2837         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2838         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
2839         to avoid releasing the window twice. Another way to handle it would be to
2840         remove the release, but this approach is slightly more robust because it works
2841         even if some other code calls the close method an extra time.
2842
2843         * WebKitTestRunner/mac/main.mm:
2844         (main): Use a stack-allocated TestController object instead of calling
2845         initalize and run on a globally allocated one.
2846
2847 2010-08-02  Tony Chang  <tony@chromium.org>
2848
2849         Reviewed by David Levin.
2850
2851         add myself to the reviewers list
2852         https://bugs.webkit.org/show_bug.cgi?id=43366
2853
2854         * Scripts/webkitpy/common/config/committers.py:
2855
2856 2010-08-02  Anders Carlsson  <andersca@apple.com>
2857
2858         Reviewed by Sam Weinig.
2859
2860         Cache JSNPObjects and fix bugs in the object map
2861         https://bugs.webkit.org/show_bug.cgi?id=43368
2862
2863         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
2864         wrap an NPObject that came from a plug-in that is now destroyed.
2865
2866         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2867         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2868         (PluginTest::Object::getProperty):
2869         (PluginTest::Object::NP_GetProperty):
2870         (PluginTest::Object::npClass):
2871         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
2872         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
2873         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2874         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
2875         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
2876         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2877         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2878         * GNUmakefile.am:
2879
2880 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2881
2882         Reviewed by Xan Lopez.
2883
2884         [Gtk] DOM listeners get wrong keycodes for some keys
2885         https://bugs.webkit.org/show_bug.cgi?id=35170
2886
2887         Add support to all event senders for simulating keypad insert
2888         and print screen keys.
2889
2890         * DumpRenderTree/chromium/EventSender.cpp:
2891         (EventSender::keyDown): Add support for generating keypad insert and print screen.
2892         * DumpRenderTree/gtk/EventSender.cpp:
2893         (keyDownCallback): Ditto.
2894         * DumpRenderTree/mac/EventSendingController.mm:
2895         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
2896         * DumpRenderTree/qt/EventSenderQt.cpp:
2897         (EventSender::keyDown): Ditto.
2898         * DumpRenderTree/win/EventSender.cpp:
2899         (keyDownCallback): Ditto.
2900
2901 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
2902
2903         Build fix for building against development versions of GTK+. GTK 2.22
2904         has not yet been released, so these function definitions must be conditionalized
2905         on the development version.
2906
2907         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
2908
2909 2010-08-02  Tony Chang  <tony@chromium.org>
2910
2911         Reviewed by Kent Tamura.
2912
2913         [chromium] use ChromiumDriver on Linux when running webkit tests
2914         https://bugs.webkit.org/show_bug.cgi?id=43273
2915
2916         * Scripts/webkitpy/layout_tests/port/chromium.py:
2917
2918 2010-08-02  Kent Tamura  <tkent@chromium.org>
2919
2920         Reviewed by Dimitri Glazkov.
2921
2922         [DRT/Chromium] Always initialize GTK
2923         https://bugs.webkit.org/show_bug.cgi?id=43327
2924
2925         Call gtk_init() in order to fix plugin test crash.
2926
2927         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2928         (main): Pass argc/argv to platformInit().
2929         * DumpRenderTree/chromium/TestShell.h:
2930         * DumpRenderTree/chromium/TestShellGtk.cpp:
2931         (platformInit): Update parameters, call gtk_init().
2932         * DumpRenderTree/chromium/TestShellMac.mm:
2933         (platformInit): Update parameters.
2934         * DumpRenderTree/chromium/TestShellWin.cpp:
2935         (platformInit): Update parameters.
2936
2937 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
2938
2939         Reviewed by Simon Hausmann.
2940
2941         [Qt] Generate forwarding headers for WebKit2
2942
2943         https://bugs.webkit.org/show_bug.cgi?id=43336
2944
2945         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
2946
2947 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
2948
2949         Reviewed by Kent Tamura.
2950
2951         WebSocket server should start with SO_REUSEADDR
2952         https://bugs.webkit.org/show_bug.cgi?id=43329
2953
2954         Pulls in pywebsocket-0.5.2.
2955         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
2956         http://code.google.com/p/pywebsocket/source/detail?r=273
2957
2958         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
2959
2960 2010-08-01  Kent Tamura  <tkent@chromium.org>
2961
2962         Reviewed by Dimitri Glazkov.
2963
2964         [DRT/Chromium] Remove string_util.h dependency
2965         https://bugs.webkit.org/show_bug.cgi?id=43312
2966
2967         * DumpRenderTree/chromium/LayoutTestController.cpp:
2968         (LayoutTestController::pathToLocalResource):
2969          Use string::find() instead of StartsWithASCII().
2970         (LayoutTestController::cppVariantToInt32):
2971          Use strtol() instead of StringToNumber().
2972
2973 2010-08-01  Sam Weinig  <sam@webkit.org>
2974
2975         Reviewed by Anders Carlsson.
2976
2977         Add ability to reset frame names for WebKitTestRunner
2978         https://bugs.webkit.org/show_bug.cgi?id=43316
2979
2980         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2981         (WTR::InjectedBundle::reset):
2982         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2983         (WTR::InjectedBundlePage::reset):
2984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2985
2986 2010-08-01  Anders Carlsson  <andersca@apple.com>
2987
2988         Reviewed by Sam Weinig.
2989
2990         Implement NPN_RemoveProperty
2991         https://bugs.webkit.org/show_bug.cgi?id=43315
2992
2993         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2994         Add NPRuntimeRemoveProperty.cpp
2995         
2996         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2997         (PluginTest::NPN_GetStringIdentifier):
2998         (PluginTest::NPN_GetIntIdentifier):
2999         (PluginTest::NPN_RemoveProperty):
3000         Add NPN_ helpers.
3001
3002         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3003         Support more NPClass functions.
3004
3005         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
3006         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
3007         Test for NPN_RemoveProperty.
3008
3009         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
3010         (NPRuntimeRemoveProperty::TestObject::invoke):
3011         Add a testRemoveProperty method.
3012
3013         (NPRuntimeRemoveProperty::NPP_GetValue):
3014         Return the test object.
3015
3016         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3017         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3018         * GNUmakefile.am:
3019         Add NPRuntimeRemoveProperty.cpp
3020
3021 2010-07-30  Anders Carlsson  <andersca@apple.com>
3022
3023         Reviewed by Sam Weinig.
3024
3025         Add an NPObject class template helper to TestNetscapePlugin
3026         https://bugs.webkit.org/show_bug.cgi?id=43288
3027
3028         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3029         Add some template magic to be able to figure out if a class has a member function of a given type.
3030
3031         (PluginTest::Object::create):
3032         Create an object.
3033
3034         (PluginTest::Object::invokeDefault):
3035         Add dummy function, this should never be called.
3036
3037         (PluginTest::Object::Object):
3038         Initialize m_pluginTest to 0.
3039
3040         (PluginTest::Object::~Object):
3041         Add virtual destructor.
3042
3043         (PluginTest::Object::NP_Allocate):
3044         Create a new object.
3045
3046         (PluginTest::Object::NP_Deallocate):
3047         Delete the object.
3048
3049         (PluginTest::Object::NP_InvokeDefault):
3050         Call invokeDefault.
3051
3052         (PluginTest::Object::npClass):
3053         Initialize the NPClass struct.
3054
3055         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3056         (DocumentOpenInDestroyStream::NPP_DestroyStream):
3057         Move this inline.
3058
3059         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
3060         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
3061         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
3062         Use the PluginTest::Object class template.
3063
3064 2010-07-31  Sam Weinig  <sam@webkit.org>
3065
3066         Reviewed by Dan Bernstein.
3067
3068         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
3069         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
3070         due to SVGElements not having the innerText function.
3071
3072         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3073         (WTR::dumpFrameText):
3074
3075 2010-07-30  Sam Weinig  <sam@webkit.org>
3076
3077         Reviewed by Maciej Stachowiak.
3078
3079         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
3080         Add structured message passing from the injected bundle to UIProcess
3081
3082         * MiniBrowser/mac/AppDelegate.m:
3083         (didRecieveMessageFromInjectedBundle):
3084         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3085         (didClearWindowForFrame):
3086         (didRecieveMessage):
3087         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3088         (WTR::InjectedBundle::done):
3089         (WTR::InjectedBundle::didReceiveMessage):
3090         * WebKitTestRunner/TestController.cpp:
3091         (WTR::TestController::initialize):
3092         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3093         * WebKitTestRunner/TestController.h:
3094         * WebKitTestRunner/TestInvocation.cpp:
3095         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3096         * WebKitTestRunner/TestInvocation.h:
3097         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3098
3099 2010-07-30  Sam Weinig  <sam@webkit.org>
3100
3101         Reviewed by Anders Carlsson.
3102
3103         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
3104         Make WKArrayRef more usable.
3105
3106         Remove now unnecessary const_casts.
3107
3108         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3109         (WTR::dumpDescendantFrameScrollPositions):
3110         (WTR::dumpDescendantFramesText):
3111
3112 2010-07-30  Sam Weinig  <sam@webkit.org>
3113
3114         Reviewed by Anders Carlsson.
3115
3116         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
3117         Add first pass of structured message passing.
3118
3119         Update Minibrowser and WebKitTestRunner to work with the new post message
3120         function.
3121
3122         * MiniBrowser/mac/AppDelegate.m:
3123         (didRecieveMessageFromInjectedBundle):
3124         (-[BrowserAppDelegate init]):
3125         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3126         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3127         (didStartProvisionalLoadForFrame):
3128         (didReceiveServerRedirectForProvisionalLoadForFrame):
3129         (didFailProvisionalLoadWithErrorForFrame):
3130         (didCommitLoadForFrame):
3131         (didFinishLoadForFrame):
3132         (didFailLoadWithErrorForFrame):
3133         (didReceiveTitleForFrame):
3134         (didClearWindowForFrame):
3135         (didCreatePage):
3136         (willDestroyPage):
3137         (didRecieveMessage):
3138         (WKBundleInitialize):
3139         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3140         (WTR::InjectedBundle::_didReceiveMessage):
3141         (WTR::InjectedBundle::didReceiveMessage):
3142         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3143         * WebKitTestRunner/TestInvocation.cpp:
3144         (WTR::TestInvocation::invoke):
3145         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3146
3147 2010-07-30  Anders Carlsson  <andersca@apple.com>
3148
3149         Try to fix the layout test failures.
3150
3151         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3152         (webkit_test_plugin_get_value):
3153
3154 2010-07-29  Anders Carlsson  <andersca@apple.com>
3155
3156         Reviewed by Adam Roben.
3157
3158         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
3159         https://bugs.webkit.org/show_bug.cgi?id=43232
3160
3161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3162         Add PluginScriptableNPObjectInvokeDefault.cpp.
3163
3164         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3165         Remove invokeDefault callback function.
3166
3167         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3168         (PluginTest::create):
3169         Move this to the top of the file.
3170
3171         (PluginTest::NPP_GetValue):
3172         Add default implementation.
3173
3174         (PluginTest::NPN_CreateObject):
3175         Add NPN_ wrapper.
3176
3177         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3178         (PluginTest::identifier):
3179         Add identifier getter.
3180
3181         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3182         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3183         Add "using namespace std".
3184
3185         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3186         (NPP_GetValue):
3187         Give PluginTest a chance to return a value.
3188
3189         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3190         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3191         * GNUmakefile.am:
3192         Add PluginScriptableNPObjectInvokeDefault.cpp.
3193         
3194         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3195         (webkit_test_plugin_get_value):
3196         Give PluginTest a chance to return a value.
3197
3198 2010-07-30  Steve Block  <steveblock@google.com>
3199
3200         Reviewed by Steve Block.
3201
3202         Add LayoutTestController methods to test DeviceOrientation
3203         https://bugs.webkit.org/show_bug.cgi?id=39589
3204
3205         * DumpRenderTree/LayoutTestController.cpp:
3206         (setMockDeviceOrientationCallback):
3207         (LayoutTestController::staticFunctions):
3208         * DumpRenderTree/LayoutTestController.h:
3209         * DumpRenderTree/chromium/LayoutTestController.cpp:
3210         (LayoutTestController::LayoutTestController):
3211         (LayoutTestController::setMockDeviceOrientation):
3212         * DumpRenderTree/chromium/LayoutTestController.h:
3213         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3214         (LayoutTestController::setMockDeviceOrientation):
3215         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3216         (LayoutTestController::setMockDeviceOrientation):
3217         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3218         (LayoutTestController::setMockDeviceOrientation):
3219         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3220         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3221         (LayoutTestController::setMockDeviceOrientation):
3222         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3223         (LayoutTestController::setMockDeviceOrientation):
3224         * Scripts/build-webkit:
3225
3226 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3227
3228         Reviewed by Kenneth Christiansen.
3229
3230         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
3231         https://bugs.webkit.org/show_bug.cgi?id=43209
3232
3233         When -resizes-to-content was being passed as a command line parameter it was simply
3234         not being set (although the corresponding menu item was marked as ON).
3235         User had to toggle the menu OFF and then ON again for it to take place.
3236
3237         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
3238         the command line, but not resizesToContents. Patch addresses that.
3239
3240         * QtTestBrowser/launcherwindow.cpp:
3241         (LauncherWindow::createChrome):
3242         (LauncherWindow::applyPrefs):
3243         (LauncherWindow::toggleResizesToContents):
3244         * QtTestBrowser/webview.h:
3245         (WebViewGraphicsBased::resizesToContents):
3246
3247 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3248
3249         Rubber-stamped by Simon Fraser.
3250
3251         [Qt] QtTestBrowser: more method grouping and clean ups.
3252
3253         Moving blocks of code around. Basically grouping related methods close to each.
3254
3255         * QtTestBrowser/launcherwindow.cpp:
3256         (LauncherWindow::initializeView):
3257         (LauncherWindow::createChrome):
3258         (LauncherWindow::changeViewportUpdateMode):
3259         (LauncherWindow::showFPS):
3260         (LauncherWindow::newWindow):
3261         (LauncherWindow::cloneWindow):
3262         * QtTestBrowser/launcherwindow.h:
3263
3264 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3265
3266         Reviewed by Tor Arne Vestbø.
3267
3268         [QT][Symbian] QtTestBrowser missing location capabilities
3269         https://bugs.webkit.org/show_bug.cgi?id=43235
3270
3271         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
3272
3273         * QtTestBrowser/QtTestBrowser.pro:
3274
3275 2010-07-29  Anders Carlsson  <andersca@apple.com>
3276
3277         Add PluginTest.cpp
3278
3279         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3280
3281 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
3282
3283         Reviewed by Eric Seidel.
3284
3285         Update download URLs for python irclib package; the old URLs 
3286         pointed at a specific mirror host and not the general sourceforge
3287         URLs.
3288
3289         https://bugs.webkit.org/show_bug.cgi?id=43228
3290
3291         * Scripts/webkitpy/thirdparty/__init__.py:
3292
3293 2010-07-29  Anders Carlsson  <andersca@apple.com>
3294
3295         Fix typo.
3296
3297         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3298
3299 2010-07-29  Anders Carlsson  <andersca@apple.com>
3300
3301         Another attempt at fixing the Qt and GTK+ build.
3302
3303         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3304         (webkit_test_plugin_new_instance):
3305         (webkit_test_plugin_destroy_stream):
3306
3307 2010-07-29  Anders Carlsson  <andersca@apple.com>
3308
3309         Another build fix attempt.
3310
3311         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3312         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3313         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3314         (webkit_test_plugin_new_instance):
3315         * GNUmakefile.am:
3316
3317 2010-07-29  Anders Carlsson  <andersca@apple.com>
3318
3319         Try to fix Windows and Unix builds.
3320
3321         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3322         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3323         (webkit_test_plugin_new_instance):
3324         (webkit_test_plugin_destroy_stream):
3325
3326 2010-07-29  Anders Carlsson  <andersca@apple.com>
3327
3328         Reviewed by Sam Weinig.
3329
3330         Refactor TestNetscapePlugin so tests can be split in separate files
3331         https://bugs.webkit.org/show_bug.cgi?id=43220
3332
3333         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3334         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3335
3336         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3337         (pluginAllocate):
3338         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
3339
3340         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3341         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
3342         (PluginTest::PluginTest):
3343         Initialize m_npp and the test identifier.
3344         
3345         (PluginTest::createTestFunctions):
3346         Return the map from identifiers to createTest functions.
3347
3348         (PluginTest::registerCreateTestFunction):
3349         Insert the identifier and create function pair in the map.
3350
3351         (PluginTest::create):
3352         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
3353
3354         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
3355         (PluginTest::Register::Register):
3356         Helper class template for registering plug-in tests.
3357         
3358         (PluginTest::Register::create):
3359         Create a new test of the given type.
3360
3361         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
3362         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3363         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
3364
3365         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3366         (NPP_New):
3367         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
3368
3369         (NPP_DestroyStream):
3370         Call the plug-in test NPP_DestroyStream member function.
3371
3372         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3373         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
3374
3375 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3376
3377         Unreviewed build fix.
3378
3379         Add missing second argument to assert_lint in new style checker tests.
3380
3381         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3382
3383 2010-07-29  Anders Carlsson  <andersca@apple.com>
3384
3385         Reviewed by Adam Roben.
3386
3387         check-webkit-style shouldn't complain about NPAPI functions
3388         https://bugs.webkit.org/show_bug.cgi?id=43211
3389
3390         Allow underscores in functions that start with NPN_, NPP_ or NP_.
3391
3392         * Scripts/webkitpy/style/checkers/cpp.py:
3393         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3394
3395 2010-07-29  Victor Wang  <victorw@chromium.org>
3396
3397         Unreviewed, rolling out r64270.
3398         http://trac.webkit.org/changeset/64270
3399         https://bugs.webkit.org/show_bug.cgi?id=39589
3400
3401         The patch breaks chromium webkit unittest
3402
3403         * DumpRenderTree/LayoutTestController.cpp:
3404         (LayoutTestController::staticFunctions):
3405         * DumpRenderTree/LayoutTestController.h:
3406         * DumpRenderTree/chromium/LayoutTestController.cpp:
3407         (LayoutTestController::LayoutTestController):
3408         * DumpRenderTree/chromium/LayoutTestController.h:
3409         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3410         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3411         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3412         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3413         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3414         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3415         * Scripts/build-webkit:
3416
3417 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3418
3419         Reviewed by Kenneth Christiansen.
3420
3421         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
3422         https://bugs.webkit.org/show_bug.cgi?id=43199
3423
3424         There is no sense in keeping WebPage method definitions in main.cpp once
3425         webpage.cpp already exists.
3426
3427         No behavior change.
3428
3429         * QtTestBrowser/main.cpp:
3430         * QtTestBrowser/webpage.cpp:
3431         (WebPage::createWindow):
3432         (WebPage::createPlugin):
3433
3434 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3435
3436         Reviewed by Kenneth Christiansen.
3437
3438         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
3439         https://bugs.webkit.org/show_bug.cgi?id=43170
3440
3441         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
3442         launcherwindow.{cpp|h}
3443
3444         No behavior change.
3445
3446         Also changed all global static variables (named "gXXX") from main.cpp to
3447         static public variables of the LauncherWindow class.
3448
3449         * QtTestBrowser/QtTestBrowser.pro:
3450         * QtTestBrowser/launcherwindow.cpp: Added.
3451         * QtTestBrowser/launcherwindow.h: Added.
3452         * QtTestBrowser/main.cpp:
3453         (LauncherApplication::handleUserOptions):
3454         (main):
3455
3456 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
3457
3458         Reviewed by Xan Lopez.
3459
3460         Build fix for building against GTK+ 3.x. GSEAL requires that we
3461         access internals of the GdkDragContext via methods. For older versions
3462         of GTK+, define those methods.
3463
3464         * DumpRenderTree/gtk/EventSender.cpp:
3465         (gdk_drag_context_get_selected_action): Added.
3466         (gdk_drag_context_get_actions): Added.
3467         (dispatchEvent): Use the two new accessor methods.
3468
3469 2010-07-29  Adam Roben  <aroben@apple.com>
3470
3471         Always say "plugins directory" when referring to a directory
3472         containing one or more plugins
3473
3474         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
3475         directory" when it means "plugins directory"
3476
3477         Reviewed by John Sullivan.
3478
3479         * WebKitTestRunner/TestController.cpp:
3480         (WTR::TestController::initialize): Updated for rename.
3481
3482 2010-07-29  Adam Roben  <aroben@apple.com>
3483
3484         Always say "directory" when referring to a plugin directory
3485
3486         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
3487         when it means "plugin directory"
3488
3489         Reviewed by John Sullivan.
3490
3491         * WebKitTestRunner/TestController.cpp:
3492         (WTR::TestController::initialize): Updated for renames.
3493
3494         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
3495         m_testPluginDirectory.
3496         (WTR::TestController::testPluginDirectory): Renamed from
3497         testPluginPath.
3498
3499         * WebKitTestRunner/mac/TestControllerMac.mm:
3500         (WTR::TestController::initializeTestPluginDirectory):
3501         * WebKitTestRunner/win/TestControllerWin.cpp:
3502         (WTR::TestController::initializeTestPluginDirectory):
3503         Renamed from initializeTestPluginPath and updated for rename.
3504
3505 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3506
3507          Reviewed by Antonio Gomes.
3508
3509          Initialize all members of NPClass struct.
3510          https://bugs.webkit.org/show_bug.cgi?id=43193
3511
3512          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3513
3514 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3515
3516         Reviewed by Antonio Gomes.
3517
3518         Warning fix on platforms where XP_MACOSX is undefined.
3519         https://bugs.webkit.org/show_bug.cgi?id=43192
3520
3521         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3522         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
3523
3524 2010-07-29  Adam Roben  <aroben@apple.com>
3525
3526         Give find-included-framework-headers our standard license
3527
3528         * Scripts/find-included-framework-headers: Used the license from
3529         WebCore/LICENSE-APPLE.
3530
3531 2010-07-29  Adam Roben  <aroben@apple.com>
3532
3533         Speed up find-included-framework-headers
3534
3535         We only do one invocation of find now, no longer pipe to grep, and
3536         replace uniq with sort -u.
3537
3538         Also added a license header.
3539
3540         * Scripts/find-included-framework-headers:
3541
3542 2010-07-29  Steve Block  <steveblock@google.com>
3543
3544         Reviewed by Jeremy Orlow.
3545
3546         Add LayoutTestController methods to test DeviceOrientation
3547         https://bugs.webkit.org/show_bug.cgi?id=39589
3548
3549         * DumpRenderTree/LayoutTestController.cpp:
3550         (setMockDeviceOrientationCallback):
3551         (LayoutTestController::staticFunctions):
3552         * DumpRenderTree/LayoutTestController.h:
3553         * DumpRenderTree/chromium/LayoutTestController.cpp:
3554         * DumpRenderTree/chromium/LayoutTestController.h:
3555         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3556         (LayoutTestController::setMockDeviceOrientation):
3557         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3558         (LayoutTestController::setMockDeviceOrientation):
3559         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3560         (LayoutTestController::setMockDeviceOrientation):
3561         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3562         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3563         (LayoutTestController::setMockDeviceOrientation):
3564         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3565         (LayoutTestController::setMockDeviceOrientation):
3566         * Scripts/build-webkit:
3567
3568 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
3569
3570         Reviewed by Shinichiro Hamaji.
3571
3572         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
3573         check-webkit-style gives false positives in single-line functions.
3574
3575         * Scripts/webkitpy/style/checkers/cpp.py:
3576         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3577
3578 2010-07-28  Darin Adler  <darin@apple.com>
3579
3580         Reviewed by Sam Weinig.
3581
3582         WebKitTestRunner needs to support layoutTestController.execCommand
3583         <https://bugs.webkit.org/show_bug.cgi?id=42538>
3584
3585         WebKitTestRunner needs layoutTestController.isCommandEnabled
3586         <https://bugs.webkit.org/show_bug.cgi?id=42671>
3587
3588         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3589         Added execCommand and isCommandEnabled.
3590         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3591         (WTR::LayoutTestController::execCommand): Added.
3592         (WTR::LayoutTestController::isCommandEnabled): Added.
3593         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3594
3595 2010-07-28  Kent Tamura  <tkent@chromium.org>
3596
3597         Reviewed by Dimitri Glazkov.
3598
3599         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
3600         https://bugs.webkit.org/show_bug.cgi?id=43123
3601
3602         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
3603         which overrides test expectations only for DumpRenderTree, in
3604         order to manage what problems are investigated.
3605         This change will be reverted when we switch to DRT completely.
3606
3607         * Scripts/webkitpy/layout_tests/port/chromium.py:
3608          Add drt_expectations.txt content to the result of
3609          test_expectations_overrides() if --use-drt is specified.
3610
3611 2010-07-28  Brady Eidson  <beidson@apple.com>
3612
3613         Reviewed by Darin Adler.
3614
3615         First pass at visited link support for WK2
3616         https://bugs.webkit.org/show_bug.cgi?id=43157
3617
3618         * MiniBrowser/mac/AppDelegate.m:
3619         (didNavigateWithNavigationData):
3620         (didPerformClientRedirect):
3621         (didPerformServerRedirect):
3622         (didUpdateHistoryTitle):
3623         (populateVisitedLinks): Added for the new version of the HistoryClient.
3624         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
3625         
3626         * MiniBrowser/mac/BrowserWindowController.m:
3627         (-[BrowserWindowController awakeFromNib]):
3628
3629 2010-07-28  Robin Dunn  <robin@alldunn.com>
3630
3631         Reviewed by Kevin Ollivier.
3632
3633         Add DOM bindings support for wx port.
3634
3635         * DumpRenderTree/wscript:
3636         * wx/browser/wscript:
3637         * wx/build/settings.py:
3638
3639 2010-07-28  Tony Chang  <tony@chromium.org>
3640
3641         Reviewed by Kent Tamura.
3642
3643         [chromium] cleanup temp files left by Linux DRT
3644         https://bugs.webkit.org/show_bug.cgi?id=43062
3645
3646         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
3647         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
3648             by crashed DRTs
3649
3650 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
3651
3652         Rubber-stamped by Kenneth Christiansen.
3653
3654         More Developer menu items reordering.
3655