WebKit/win/ChangeLog

   1 2009-05-18  Steve Falkenburg  <sfalken@apple.com>
   2
   3         <rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent
   4
   5         Add user agent hack for pointroll.com.
   6
   7         Reviewed by Sam Weinig.
   8
   9         * WebView.cpp:
  10
  11 2009-05-13  Dmitry Titov  <dimich@chromium.org>
  12
  13         Rubber-stamped by Mark Rowe.
  14
  15         https://bugs.webkit.org/show_bug.cgi?id=25746
  16         Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
  17
  18         * WebKit.vcproj/WebKit.def:
  19         * WebKit.vcproj/WebKit_debug.def:
  20
  21 2009-05-12  Steve Falkenburg  <sfalken@apple.com>
  22
  23         Build fix for Windows nightlies.
  24         Change link order to work around CFNetwork bug.
  25
  26         * WebKit.vcproj/WebKit.vcproj:
  27
  28 2009-05-11  Dmitry Titov  <dimich@chromium.org>
  29
  30         Reviewed by Alexey Proskuryakov and Adam Roben.
  31
  32         https://bugs.webkit.org/show_bug.cgi?id=25348
  33         Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
  34
  35         Most of the change is in WTF and WebCore.
  36
  37         * WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones.
  38         Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions
  39         which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones
  40         can be removed.
  41         * WebKit.vcproj/WebKit_debug.def: same.
  42
  43 2009-05-10  Alexey Proskuryakov  <ap@webkit.org>
  44
  45         Reviewed by Dan Bernstein.
  46
  47         <rdar://problem/6870383> Have to enter credentials twice when downloading from a protected page
  48
  49         * WebDownloadCFNet.cpp: (WebDownload::didReceiveAuthenticationChallenge): Try to use
  50         credentials from WebCore storage.
  51
  52 2009-05-07  Mark Rowe  <mrowe@apple.com>
  53
  54         Rubber-stamped by Oliver Hunt.
  55
  56         Fix <https://bugs.webkit.org/show_bug.cgi?id=25640>.
  57         Bug 25640: Crash on quit in r43384 nightly build on Leopard w/ Safari 4 beta installed
  58
  59         Roll out r43366 as it removed symbols that Safari 4 Beta uses.
  60
  61         * WebKit.vcproj/WebKit.def:
  62         * WebKit.vcproj/WebKit_debug.def:
  63
  64 2009-05-06  Steve Falkenburg  <sfalken@apple.com>
  65
  66         Change default value of WebKitPaintNativeControls to true.
  67
  68         Reviewed by Adam Roben.
  69
  70         * WebPreferences.cpp:
  71         (WebPreferences::initializeDefaultSettings):
  72
  73 2009-05-05  Ben Murdoch  <benm@google.com>
  74
  75         Reviewed by Eric Seidel.
  76
  77         Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
  78         https://bugs.webkit.org/show_bug.cgi?id=24776
  79
  80         * ForEachCoClass.h:
  81         * WebCoreSupport/WebChromeClient.cpp:
  82         * WebCoreSupport/WebChromeClient.h:
  83         * WebDatabaseManager.cpp:
  84         * WebDatabaseManager.h:
  85         * WebSecurityOrigin.cpp:
  86         (WebSecurityOrigin::usage):
  87         (WebSecurityOrigin::quota):
  88         (WebSecurityOrigin::setQuota):
  89         * WebSecurityOrigin.h:
  90         * WebView.cpp:
  91         (WebView::initWithFrame):
  92
  93 2009-05-04  Adam Roben  <aroben@apple.com>
  94
  95         Add a call to notify the UI delegate when the WebView gets invalidated
  96
  97         Reviewed by Steve Falkenburg.
  98
  99         * Interfaces/IWebUIDelegatePrivate.idl: Added webViewDidInvalidate.
 100         * WebView.cpp:
 101         (WebView::addToDirtyRegion): Call webViewDidInvalidate.
 102
 103 2009-05-04  Darin Adler  <darin@apple.com>
 104
 105         First try at fixing the Windows build.
 106
 107         * DOMHTMLClasses.cpp: Added include of HTMLCollection.h.
 108
 109 2009-05-01  Geoffrey Garen  <ggaren@apple.com>
 110
 111         Rubber Stamped by Sam Weinig.
 112
 113         Renamed JSValuePtr => JSValue.
 114
 115         * WebView.cpp:
 116         (WebView::stringByEvaluatingJavaScriptFromString):
 117
 118 2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
 119
 120         Reviewed by Timothy Hatcher.
 121
 122         Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
 123
 124         https://bugs.webkit.org/show_bug.cgi?id=25347
 125
 126         * WebCoreSupport/WebFrameLoaderClient.cpp:
 127         (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
 128         * WebCoreSupport/WebFrameLoaderClient.h:
 129
 130 2009-04-30  David Kilzer  <ddkilzer@apple.com>
 131
 132         Provide a mechanism to create a quirks delegate for HTMLParser
 133
 134         Reviewed by David Hyatt.
 135
 136         * WebCoreSupport/WebChromeClient.h:
 137         (WebChromeClient::createHTMLParserQuirks): Added.  The default
 138         implementation of this factory method returns 0.
 139
 140 2009-04-30  Pavel Feldman  <pfeldman@chromium.org>
 141
 142         Reviewed by Dimitri Glazkov.
 143
 144         https://bugs.webkit.org/show_bug.cgi?id=25342
 145         Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
 146
 147         * WebCoreSupport/WebChromeClient.cpp:
 148         (WebChromeClient::addMessageToConsole):
 149         * WebCoreSupport/WebChromeClient.h:
 150
 151 2009-04-29  Eric Seidel  <eric@webkit.org>
 152
 153         No review, rolling out a patch.
 154
 155         Revert 43020 as it caused accessibility/lists.html to fail
 156         and no one is around to tell me if it's a progression or not.
 157
 158         * AccessibleBase.cpp:
 159         (MSAARole):
 160
 161 2009-04-29  Sankar Aditya Tanguturi  <sankaraditya@gmail.com>
 162
 163         Reviewed by Jon Honeycutt.
 164
 165         Add a new accessibility role for list items. Part of
 166         http://bugs.webkit.org/show_id.cgi?id=20013
 167
 168         * win/AccessibleBase.cpp:
 169         (MSAARole): Return ROLE_SYSTEM_LISTITEM for list item role.
 170
 171 2009-04-29  Sankar Aditya Tanguturi  <sankaraditya@gmail.com>
 172
 173         Reviewed by Adele Peterson.
 174
 175         https://bugs.webkit.org/show_bug.cgi?id=23583
 176         Populate role attribute for document objects correctly
 177         on Windows platform.
 178
 179         * AccessibleDocument.cpp:
 180         (AccessibleDocument::role): Return ROLE_SYSTEM_DOCUMENT for
 181         document objects on windows. (Matching Firefox).
 182         * AccessibleDocument.h: Add the role function prototype in
 183         header file.
 184
 185 2009-04-22  Ada Chan  <adachan@apple.com>
 186
 187         <rdar://problem/5115298> Don't get error msg when download is interrupted and cannot resume due to server unavailability
 188         If we fail to get an error description back from CFNetwork, try to get the localized description
 189         based on the error code.
 190
 191         Reviewed by Darin Adler.
 192
 193         * WebError.cpp:
 194         (WebError::localizedDescription):
 195
 196 2009-04-21  Jon Honeycutt  <jhoneycutt@apple.com>
 197
 198         Allow the UI delegate to control cursor-setting.
 199
 200         Reviewed by Ada Chan.
 201
 202         * Interfaces/IWebUIDelegatePrivate.idl:
 203         Added a function to the IWebUIDelegatePrivate5 interface.
 204
 205         * WebCoreSupport/WebChromeClient.cpp:
 206         (WebChromeClient::setCursor):
 207         Try to call the UI delegate's webViewSetCursor() method. If it fails,
 208         fall back to calling SetCursor() with the passed cursor.
 209
 210         * WebCoreSupport/WebChromeClient.h:
 211
 212         * WebView.cpp:
 213         (WebViewWndProc):
 214         Call the Chrome's setCursor() method with the last set cursor.
 215
 216 2009-04-21  Dan Bernstein  <mitz@apple.com>
 217
 218         Reviewed by Jon Honeycutt.
 219
 220         - Windows part of fixing <rdar://problem/6755137> Action dictionary for
 221           policy decision is missing keys when full-page zoom is used
 222
 223         * WebActionPropertyBag.cpp:
 224         (WebActionPropertyBag::Read): Use absoluteLocation() instead of
 225         clientX() and clientY(), which are adjusted for zoom.
 226
 227 2009-04-21  Dan Bernstein  <mitz@apple.com>
 228
 229         Reviewed by Jon Honeycutt.
 230
 231         - implement DOMNode::nodeName()
 232
 233         * DOMCoreClasses.cpp:
 234         (DOMNode::nodeName):
 235
 236 2009-04-21  Steve Falkenburg  <sfalken@apple.com>
 237
 238         Minor clean-ups to WebKitCreateInstance change.
 239
 240         Reviewed by Jon Honeycutt.
 241
 242         * WebKitCOMAPI.cpp:
 243         (classFactory):
 244         (WebKitCreateInstance):
 245
 246 2009-04-21  Steve Falkenburg  <sfalken@apple.com>
 247
 248         Add registry-free CoCreateInstance API for WebKit clients: WebKitCreateInstance.
 249
 250         Manifest-based registry-free COM continues to work for clients that have embedded
 251         manifests with isolated COM information.
 252
 253         Reviewed by Adam Roben.
 254
 255         * WebKit.vcproj/WebKit.def: Added WebKitCreateInstance.
 256         * WebKit.vcproj/WebKit.vcproj: Link against rpcrt4.dll for UUID hashing.
 257         * WebKit.vcproj/WebKit_debug.def: Added WebKitCreateInstance.
 258         * WebKitCOMAPI.cpp: Added.
 259         (CLSIDHash::hash):
 260         (CLSIDHash::equal):
 261         (CLSIDHashTraits::constructDeletedValue):
 262         (CLSIDHashTraits::isDeletedValue):
 263         (classFactory):
 264         (WebKitCreateInstance): New API.
 265         * WebKitCOMAPI.h: Added.
 266
 267 2009-04-21  Adam Roben  <aroben@apple.com>
 268
 269         Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
 270         configuration
 271
 272         This matches the naming scheme for WebKit.dll, and will be necessary
 273         once Safari links against JavaScriptCore.dll. This change also causes
 274         run-safari not to fail (because the launcher printed by FindSafari was
 275         always looking for JavaScriptCore.dll, never
 276         JavaScriptCore_debug.dll).
 277
 278         Part of Bug 25305: can't run safari or drt on windows
 279         <https://bugs.webkit.org/show_bug.cgi?id=25305>
 280
 281         Reviewed by Steve Falkenburg and Sam Weinig.
 282
 283         * WebKit.vcproj/WebKit.vcproj: Use $(WebKitDLLConfigSuffix) for naming
 284         JavaScriptCore.{dll,lib}.
 285
 286 2009-04-20  Adam Roben  <aroben@apple.com>
 287
 288         Build fix
 289
 290         * MemoryStream.cpp:
 291         (MemoryStream::Clone): Fix typo introduced when implementing
 292         suggestions from patch review.
 293
 294 2009-04-20  Adam Roben  <aroben@apple.com>
 295
 296         First part of <rdar://6395825> It takes over 20 sec to launch Safari
 297         with 500KB history file
 298
 299         This ports the changes that were made to WebKit/mac's WebHistory
 300         implementation in r25275 to WebKit/win. WebHistory now stores a
 301         HashMap from CFAbsoluteTime (stored as int64_t) to CFArray of
 302         IWebHistoryItem*. The HashMap lets us look up the CFArray for a
 303         particular day's history in constant time rather than linear time. The
 304         precise reasons why we store the CFAbsoluteTime as an int64_t are lost
 305         to the mists of time, but it is likely because these CFAbsoluteTimes
 306         never have a decimal part, and integer comparisons are faster than
 307         floating-point comparisons, so storing them as int64_t should improve
 308         performance without losing precision. We also now use a binary search
 309         instead of a linear search when determining the index at which to
 310         insert a WebHistoryItem into its day's CFArray.
 311
 312         This patch reduces the time needed to load a 100,000-item
 313         History.plist from ~15 seconds to ~7.5 seconds. Further improvements
 314         could likely be made by reducing the number of string conversions,
 315         reducing calls to CFTimeZone functions, and removing all the
 316         WebHistoryItemsAdded notifications that are sent (Mac doesn't send any
 317         while loading history).
 318
 319         Reviewed by Darin Adler.
 320
 321         * WebHistory.cpp:
 322         (WebHistoryWriter::WebHistoryWriter): Changed to take a
 323         DateToEntriesMap instead of a CFArrayRef. Initialize m_dateKeys to
 324         contain the keys from m_entriesByDate in ascending order.
 325         (WebHistoryWriter::writeHistoryItems): Now loops through m_dateKeys in
 326         reverse order and gets the entries array from the DateToEntriesMap.
 327         (WebHistory::WebHistory): Removed code to initialize
 328         m_datesWithEntries (which has been removed) and m_entriesByDate (which
 329         has been converted to a HashMap).
 330         (WebHistory::removeAllItems): Clear out m_entriesByDate and
 331         m_orderedLastVisitedDays.
 332         (WebHistory::orderedLastVisitedDays): If we don't already have a
 333         cached m_orderedLastVisitedDays array, create one by converting the
 334         keys from m_entriesByDate to DATEs and sorting them in descending
 335         order. Then copy m_orderedLastVisitedDays to the output buffer.
 336         (WebHistory::orderedItemsLastVisitedOnDay): Updated to use findKey
 337         instead of findIndex and to treat m_entriesByDate as a HashMap.
 338         Now that the items in each day's CFArray are stored in descending
 339         order (newest to oldest), we don't have to reverse them when filling
 340         in the output buffer. (The old comment about putting the items in
 341         oldest-to-newest order was incorrect -- it was putting them in
 342         newest-to-oldest order.)
 343
 344         (WebHistory::addItemToDateCaches):
 345         (WebHistory::removeItemFromDateCaches):
 346         Changed to use findKey instead of findIndex and to treat
 347         m_entriesByDate as a HashMap. If we're adding a key to or removing a
 348         key from m_entriesByDate, also clear m_orderedLastVisitedDays so that
 349         we will regenerate it for the current set of keys the next time it is
 350         needed.
 351
 352         (timeIntervalForBeginningOfDay): Added. Returns the CFAbsoluteTime
 353         that corresponds to the beginning of the day in which the passed-in
 354         DATE occurs.
 355         (WebHistory::findKey): Returns the key used in m_entriesByDate to
 356         store the CFArray that should contain the IWebHistoryItem that
 357         corresponds to the passed-in DATE. Replaces findIndex.
 358         (WebHistory::insertItem): Changed to treat m_entriesByDate as a
 359         HashMap rather than a CFArray. We now optimize for inserting at the
 360         beginning and end of the array, and use a binary rather than linear
 361         search when inserting into the middle of the array.
 362         (WebHistory::data): Changed to treat m_entriesByDate as a HashMap.
 363
 364         * WebHistory.h: Changed m_entriesByDate to a DateToEntriesMap, removed
 365         m_datesWithEntries, added m_orderedLastVisitedDays.
 366
 367 2009-04-20  Adam Roben  <aroben@apple.com>
 368
 369         Change MemoryStream::createInstance to return a COMPtr
 370
 371         Part of Bug 25294: All WebKit/win classes should return COMPtrs from
 372         their static constructor members
 373         <https://bugs.webkit.org/show_bug.cgi?id=25294>
 374
 375         Reviewed by Darin Adler.
 376
 377         * MemoryStream.cpp:
 378         (MemoryStream::createInstance): Changed to return a COMPtr.
 379         (MemoryStream::Clone): Updated for createInstance change.
 380         * MemoryStream.h: Changed createInstance to return a COMPtr.
 381
 382         * WebArchive.cpp:
 383         (WebArchive::data):
 384         * WebCoreSupport/EmbeddedWidget.cpp:
 385         (EmbeddedWidget::didReceiveData):
 386         * WebDataSource.cpp:
 387         (WebDataSource::data):
 388         * WebHistory.cpp:
 389         (WebHistory::data):
 390         * WebIconFetcher.cpp:
 391         (WebIconFetcherClient::finishedFetchingIcon):
 392         * WebResource.cpp:
 393         (WebResource::createInstance):
 394         Updated for changes to MemoryStream::createInstance.
 395
 396 2009-04-20  Adam Roben  <aroben@apple.com>
 397
 398         Fix Bug 25295: Remove WebKit/win code that was used for Drosera
 399         support
 400
 401         <https://bugs.webkit.org/show_bug.cgi?id=25295>
 402
 403         Reviewed by Sam Weinig.
 404
 405         * ForEachCoClass.h: Removed WebScriptDebugServer.
 406
 407         * Interfaces/WebKit.idl: Removed WebScriptDebugServer and references
 408         to removed IDL files.
 409
 410         * WebKit.vcproj/Interfaces.vcproj:
 411         * WebKit.vcproj/WebKit.vcproj:
 412         Removed IDL and source files for IWebScriptCallFrame,
 413         IWebScriptDebugListener, IWebScriptDebugServer, WebScriptCallFrame,
 414         and WebScriptDebugServer.
 415
 416         * WebCoreSupport/WebFrameLoaderClient.cpp:
 417         * WebKitClassFactory.cpp:
 418         * WebKitDLL.cpp:
 419         Removed #includes of WebScriptDebugServer.h.
 420
 421         * Interfaces/IWebScriptCallFrame.idl: Removed.
 422         * Interfaces/IWebScriptDebugListener.idl: Removed.
 423         * Interfaces/IWebScriptDebugServer.idl: Removed.
 424         * WebScriptCallFrame.cpp: Removed.
 425         * WebScriptCallFrame.h: Removed.
 426         * WebScriptDebugServer.cpp: Removed.
 427         * WebScriptDebugServer.h: Removed.
 428
 429 2009-04-20  Steve Falkenburg  <sfalken@apple.com>
 430
 431         Separate JavaScriptCore.dll from WebKit.dll.
 432         Slight performance improvement or no change on benchmarks.
 433
 434         Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
 435         and simplifies standalone JavaScriptCore builds.
 436
 437         Reviewed by Oliver Hunt.
 438
 439         * WebKit.vcproj/WebKit.def: Mark JavaScriptCore re-exports as deprecated.
 440         * WebKit.vcproj/WebKit.vcproj: Link against JavaScriptCore.dll
 441         * WebKit.vcproj/WebKit_debug.def: Mark JavaScriptCore re-exports as deprecated.
 442
 443 2009-04-17  Ada Chan  <adachan@apple.com>
 444
 445         <rdar://problem/6803905> Lots of ASSERTs firing when trying to clear history
 446
 447         Reviewed by Steve Falkenburg.
 448
 449         * WebHistory.cpp:
 450         (WebHistory::data): Return null if there are no history items.
 451
 452 2009-04-17  Ada Chan  <adachan@apple.com>
 453
 454         - Fix a leak in WebHistoryItem::children() by adopting the created instance of WebHistoryItem.
 455         - Remove the unnecessary call to QueryInterface() which is not related to the leak.
 456
 457         Reviewed by Adam Roben.
 458
 459         * WebHistoryItem.cpp:
 460         (WebHistoryItem::children):
 461
 462 2009-04-17  Ada Chan  <adachan@apple.com>
 463
 464         Fix a leak in WebHistory::data().
 465
 466         Reviewed by Adam Roben.
 467
 468         * WebHistory.cpp:
 469         (WebHistory::data):
 470
 471 2009-04-16  Alice Liu  <alice.liu@apple.com>
 472
 473         Reviewed by Mark Rowe.
 474
 475         Fix for heavy leakage of WebURLResponses seen during the stress test
 476
 477         * WebCoreSupport/WebFrameLoaderClient.cpp:
 478         (WebFrameLoaderClient::shouldCacheResponse):
 479
 480 2009-04-16  Xan Lopez  <xlopez@igalia.com>
 481
 482         Unreviewed build fix.
 483
 484         * WebView.cpp:
 485
 486 2009-04-16  Xan Lopez  <xlopez@igalia.com>
 487
 488         Reviewed by Sam Weinig.
 489
 490         https://bugs.webkit.org/show_bug.cgi?id=25241
 491         Remove superfluous NotImplemented.h includes
 492
 493         * WebDownloadCFNet.cpp:
 494         * WebURLAuthenticationChallengeSender.cpp:
 495         * WebView.cpp:
 496
 497 2009-04-14  Adam Roben  <aroben@apple.com>
 498
 499         Remove support for profile-guided optimization on Windows
 500
 501         Rubber-stamped by Steve Falkenburg.
 502
 503         * WebKit.vcproj/WebKit.vcproj: Removed the Release_PGOInstrument and
 504         Release_PGOOptimize configurations.
 505
 506 2009-04-13  Adam Roben  <aroben@apple.com>
 507
 508         Windows part 2 of <rdar://5438063> Saving history containing 100,000
 509         entries causes pauses of 2s while browsing
 510
 511         Reviewed by Brady Eidson.
 512
 513         * Interfaces/IWebHistoryPrivate.idl: Added data, analagous to
 514         WebKit/mac's -[WebHistory _data] method.
 515
 516         * WebHistory.cpp:
 517         (WebHistory::saveHistoryGuts): Changed to call data() to get the data for
 518         saving.
 519         (WebHistory::data): Added. Returns the data for saving as an IStream.
 520         (WebHistory::data): Added. Returns the data for saving as a CFDataRef.
 521
 522         * WebHistory.h: Added data.
 523
 524 2009-04-10  Steve Falkenburg  <sfalken@apple.com>
 525
 526         <rdar://problem/6676024> REGRESSION (PB-40B1): Safari crashes on launch on tablet PC
 527
 528         r21436 changed the semantics of AXObjectCache::get() to not create
 529         objects on demand. Changing this get() call into a getOrCreate() call
 530         fixes the crash.
 531
 532         Rubber stamped by Jon Honeycutt.
 533
 534         * AccessibleDocument.cpp:
 535         (AccessibleDocument::AccessibleDocument):
 536
 537 2009-04-10  Adam Roben  <aroben@apple.com>
 538
 539         Add our invidual IDL files back to Interfaces.vcproj, but disable them
 540
 541         This allows the IDL files to be found in Solution Explorer.
 542
 543         Rubber-stamped in advance by Steve Falkenburg.
 544
 545         * WebKit.vcproj/Interfaces.vcproj:
 546
 547 2009-04-09  Adam Roben  <aroben@apple.com>
 548
 549         Windows part 1 of <rdar://problem/5438063> Saving history containing
 550         100,000 entries causes pauses of 2s while browsing
 551
 552         Use HistoryPropertyListWriter to implement IWebHistory::saveToURL.
 553
 554         Reviewed by Darin Adler.
 555
 556         * WebHistory.cpp:
 557         (WebHistoryWriter::WebHistoryWriter): Added.
 558         (WebHistoryWriter::writeHistoryItems): Added. Loop backwards through
 559         the entries for each date, and pass the corresponding
 560         WebCore::HistoryItem to writeHistoryItem.
 561         (WebHistory::saveHistoryGuts): Use WebHistoryWriter to serialize
 562         m_entriesByDate, then write the serialized data to disk using
 563         CFWriteStream.
 564
 565         * WebHistory.h: Removed datesArray.
 566
 567 2009-04-08  Adam Roben  <aroben@apple.com>
 568
 569         Fix security/block-test-no-port.html on Windows
 570
 571         Reviewed by Beth Dakin.
 572
 573         * WebMutableURLRequest.cpp:
 574         (WebMutableURLRequest::mainDocumentURL): Return the ResourceRequest's
 575         mainDocumentURL, not its URL.
 576
 577 2009-04-01  Darin Adler  <darin@apple.com>
 578
 579         Reviewed by Geoff Garen.
 580
 581         Bug 22378: Crash submitting a form when parsing an XHTML document
 582         https://bugs.webkit.org/show_bug.cgi?id=22378
 583         rdar://problem/6388377
 584
 585         * WebFrame.cpp:
 586         (WebFrame::dispatchWillSubmitForm): Updated for the new
 587         textFieldValues function in FormState.
 588
 589 2009-03-30  Adam Roben  <aroben@apple.com>
 590
 591         Build fixes after recent FrameLoader changes
 592
 593         * WebCoreSupport/WebContextMenuClient.cpp:
 594         (WebContextMenuClient::searchWithGoogle): Updated to match
 595         urlSelected's current signature. We pass true for the userGesture
 596         parameter, since the user must have selected this item from the
 597         context menu.
 598
 599         * WebCoreSupport/WebFrameLoaderClient.cpp: Removed
 600         loadURLIntoChildFrame.
 601         (WebFrameLoaderClient::createFrame): Changed to call
 602         FrameLoader::loadURLIntoChildFrame. This probably should have been
 603         done way back around r31281 when that function was added.
 604
 605         * WebCoreSupport/WebFrameLoaderClient.h: Removed
 606         loadURLIntoChildFrame.
 607
 608 2009-03-27  Adam Roben  <aroben@apple.com>
 609
 610         Don't include substitute data URLs in global history redirect chains
 611
 612         <rdar://6690169>
 613
 614         Reviewed by Darin Adler.
 615
 616         * WebCoreSupport/WebFrameLoaderClient.cpp:
 617         (WebFrameLoaderClient::updateGlobalHistory): Don't call
 618         updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now.
 619         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
 620         Added an assertion to help catch cases where we might be adding a
 621         substitute data URL into a redirect chain.
 622
 623 2009-03-26  Dan Bernstein  <mitz@apple.com>
 624
 625         Reviewed by Adam Roben.
 626
 627         - add close() to the WebView API.
 628
 629         * Interfaces/IWebView.idl:
 630         * WebView.cpp:
 631         (WebView::close):
 632         * WebView.h:
 633
 634 2009-03-24  Brent Fulgham  <bfulgham@webkit.org>
 635
 636         Reviewed by Adam Roben.
 637
 638         https://bugs.webkit.org/show_bug.cgi?id=24779
 639         Conditionalize CFNetwork-specific code in WebView to permit
 640         support for other network backends.
 641
 642         * WebView.cpp:
 643         (WebView::setCacheModel): Add CFNETWORK check around CFNetwork
 644         specific cache implementation.
 645         (updateSharedSettingsFromPreferencesIfNeeded): Add CFNETWORK
 646         check around use of CFHTTPCookie code.
 647
 648 2009-03-23  Sam Weinig  <sam@webkit.org>
 649
 650         Reviewed by Dan Bernstein.
 651
 652         Fix for <rdar://problem/6140966>
 653         Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
 654
 655         * WebCache.cpp:
 656         (WebCache::empty): Also add application cache emptying to match the mac.
 657
 658 2009-03-18  Steve Falkenburg  <sfalken@apple.com>
 659
 660         Add webViewClosing to private UI delegate.
 661
 662         Reviewed by Adam Roben.
 663
 664         * Interfaces/IWebUIDelegatePrivate.idl:
 665         * Interfaces/WebKit.idl:
 666         * WebView.cpp:
 667         (WebView::close):
 668
 669 2009-03-17  Dan Bernstein  <mitz@apple.com>
 670
 671         Reviewed by Adam Roben.
 672
 673         - WebKit part of adding a mechanism for controlling the caching of
 674           responses through WebFrameLoaderClient
 675
 676         * Interfaces/IWebResourceLoadDelegatePrivate.idl: Added the
 677         IWebResourceLoadDelegatePrivate3 interface, containing the new
 678         delegate method shouldCacheResponse().
 679
 680         * Interfaces/IWebURLRequest.idl: Added the isEqual() method.
 681
 682         * WebCoreSupport/WebFrameLoaderClient.cpp:
 683         (WebFrameLoaderClient::shouldCacheResponse): Implemented this new
 684         FrameLoaderDelegate method by calling through to the resource load
 685         delegate, if it implements shouldCacheResponse(), and returning true
 686         otherwise.
 687
 688         * WebCoreSupport/WebFrameLoaderClient.h:
 689
 690         * WebMutableURLRequest.cpp:
 691         (WebMutableURLRequest::isEqual): Added.
 692         (WebMutableURLRequest::setValue): Implemented.
 693
 694         * WebMutableURLRequest.h: Declared isEqual().
 695
 696 2009-03-16  Darin Adler  <darin@apple.com>
 697
 698         Reviewed by Dan Bernstein.
 699
 700         <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”
 701
 702         For now, change only the localized strings, not the terminology in the code.
 703
 704         * WebCoreLocalizedStrings.cpp:
 705         (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here.
 706         (WebCore::contextMenuItemTagTextDirectionMenu): And here.
 707
 708 2009-03-16  Adam Roben  <aroben@apple.com>
 709
 710         Add IWebFramePrivate::isDisplayingStandaloneImage
 711
 712         This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
 713         uses.
 714
 715         Reviewed by Darin Adler.
 716
 717         * Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.
 718
 719         * WebFrame.cpp:
 720         (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our
 721         Document is an image document.
 722
 723         * WebFrame.h: Added isDisplayingStandaloneImage.
 724
 725 2009-03-12  Peter Kasting  <pkasting@google.com>
 726
 727         Reviewed by Darin Fisher.
 728
 729         https://bugs.webkit.org/show_bug.cgi?id=24502
 730         Make horizontal scrolling on Windows always go the correct direction.
 731
 732         * WebView.cpp:
 733         (WebView::mouseWheel):
 734         (WebViewWndProc):
 735         * WebView.h:
 736
 737 2009-03-12  Adam Roben  <aroben@apple.com>
 738
 739         Implement DOMHTMLDocument::title
 740
 741         Reviewed by Dan Bernstein.
 742
 743         * DOMHTMLClasses.cpp:
 744         (DOMHTMLDocument::title): Call through to WebCore::Document (with
 745         obligatory COM error checking/type conversions).
 746
 747 2009-03-11  Adam Roben  <aroben@apple.com>
 748
 749         Export functions needed by ThreadSpecific from WebKit
 750
 751         Reviewed by John Sullivan.
 752
 753         * WebKit.vcproj/WebKit.def:
 754         * WebKit.vcproj/WebKit_debug.def:
 755         Export WTF::tlsKeyCount and WTF::tlsKeys.
 756
 757 2009-03-10  Steve Falkenburg  <sfalken@apple.com>
 758
 759         <rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults
 760
 761         Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.
 762
 763         This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
 764         The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
 765         saying there was browsing history for a particular day, and then return no history items when we requested a
 766         list of sites visited that day.
 767
 768         Reviewed by Ada Chan.
 769
 770         * MarshallingHelpers.cpp:
 771         (MarshallingHelpers::DATEToCFAbsoluteTime):
 772         (MarshallingHelpers::CFAbsoluteTimeToDATE):
 773
 774 2009-03-08  Mark Rowe  <mrowe@apple.com>
 775
 776         Reviewed by Oliver Hunt.
 777
 778         Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
 779         Frame.h no longer needs to include it.  This cuts the size of the symbols
 780         for a debug build by around 3%.
 781
 782         * WebView.cpp:
 783         (WebView::centerSelectionInVisibleArea):
 784
 785 2009-03-07  Dan Bernstein  <mitz@apple.com>
 786
 787         Reviewed by Mark Rowe.
 788
 789         - WebKit part of removing build-time and run-time support for legacy
 790           versions of CFNetwork and Core Graphics
 791
 792         * WebView.cpp:
 793         (WebView::setCacheModel):
 794
 795 2009-03-04  Adam Barth  <abath@webkit.org>
 796
 797         Reviewed by Alexey Proskuryakov.
 798
 799         https://bugs.webkit.org/show_bug.cgi?id=24356
 800
 801         Fix WebKit style for allowUniversalAccessFromFileURLs.
 802
 803         * Interfaces/IWebPreferencesPrivate.idl:
 804         * WebPreferenceKeysPrivate.h:
 805         * WebPreferences.cpp:
 806         (WebPreferences::initializeDefaultSettings):
 807         (WebPreferences::allowUniversalAccessFromFileURLs):
 808         (WebPreferences::setAllowUniversalAccessFromFileURLs):
 809         * WebPreferences.h:
 810         * WebView.cpp:
 811         (WebView::notifyPreferencesChanged):
 812
 813 2009-02-27  Adam Barth  <abarth@webkit.org>
 814
 815         Reviewed by Eric Seidel.
 816
 817         Add a preference to reduce the power of file:// URLs.
 818
 819         * Interfaces/IWebPreferencesPrivate.idl:
 820         * WebPreferenceKeysPrivate.h:
 821         * WebPreferences.cpp:
 822         (WebPreferences::initializeDefaultSettings):
 823         (WebPreferences::allowUniversalAccessFromFileUrls):
 824         (WebPreferences::setAllowUniversalAccessFromFileUrls):
 825         * WebPreferences.h:
 826         * WebView.cpp:
 827         (WebView::notifyPreferencesChanged):
 828
 829 2009-02-19  Alexey Proskuryakov  <ap@webkit.org>
 830
 831         Reviewed by Darin Adler.
 832
 833         https://bugs.webkit.org/show_bug.cgi?id=24024
 834         REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
 835         archiving a submission to about:blank
 836
 837         I don't know how to make an automated test for this bug.
 838
 839         * WebHistory.cpp: (WebHistory::visitedURL): Account for the fact that HTTP method may be
 840         non-empty for non-HTTP requests.
 841
 842 2009-02-25  Andreia Gaita  <shana@jitted.com>
 843
 844         Reviewed by Alp Toker.
 845
 846         Update Win def files with recent JavaScriptCore API additions.
 847
 848         * WebKit.vcproj/WebKit.def:
 849         * WebKit.vcproj/WebKit_Cairo.def:
 850         * WebKit.vcproj/WebKit_debug.def:
 851
 852 2009-02-24  Sam Weinig  <sam@webkit.org>
 853
 854         Reviewed by Geoffrey Garen.
 855
 856         Related to <rdar://problem/6590295>
 857         Allow disabling javascript: urls.
 858
 859         * Interfaces/IWebViewPrivate.idl:
 860         * WebView.cpp:
 861         (WebView::setJavaScriptURLsAreAllowed):
 862         * WebView.h:
 863
 864 2009-02-24  Adam Roben  <aroben@apple.com>
 865
 866         Windows build fix
 867
 868         * WebKit.vcproj/WebKit.def:
 869         * WebKit.vcproj/WebKit_debug.def:
 870         Export WTF::ThreadCondition::timedWait.
 871
 872 2009-02-12  Brady Eidson  <beidson@apple.com>
 873
 874         Reviewed by Kevin Decker
 875
 876         <rdar://problem/6582180> - Wrong HTTP method applied to history item.
 877
 878         * WebCoreSupport/WebFrameLoaderClient.cpp:
 879         (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any
 880           redirected request.
 881
 882 2009-02-11  Brady Eidson  <beidson@apple.com>
 883
 884         Fix my last checkin for more effect.
 885
 886         * WebHistoryItem.cpp:
 887         (WebHistoryItem::initFromDictionaryRepresentation):
 888
 889 2009-02-11  Adam Roben  <aroben@apple.com>
 890
 891         Windows fix for Bug 22239: Implement missing animation & transition
 892         APIs on LayoutTestController for non-mac platforms
 893
 894         <https://bugs.webkit.org/show_bug.cgi?id=22239>
 895
 896         Reviewed by Simon Fraser.
 897
 898         * Interfaces/IWebFramePrivate.idl: Added pauseAnimation,
 899         pauseTransition, and numberOfActiveAnimations.
 900
 901         * WebFrame.cpp:
 902         (WebFrame::pauseAnimation):
 903         (WebFrame::pauseTransition):
 904         (WebFrame::numberOfActiveAnimation):
 905         Added. These all call through to AnimationController.
 906
 907         * WebFrame.h: Added pauseAnimation, pauseTransition, and
 908         numberOfActiveAnimations.
 909
 910 2009-02-11  Brady Eidson  <beidson@apple.com>
 911
 912         Reviewed by Mark Rowe
 913
 914         <rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative
 915
 916         Remove the item from the date caches before registering the visit.  Otherwise it might not be successfully removed
 917         and when we add it back later it will exist in the list twice.  This will cause the entry to be written out twice,
 918         which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.
 919
 920         * WebHistory.cpp:
 921         (WebHistory::loadHistoryGutsFromURL):
 922         (WebHistory::addItems):
 923         (WebHistory::addItem): Add a mode that allows the entry being added to be discarded if an entry for the URL already
 924           exists.  Use that mode when reading the History.plist so only the most recent entry for a given URL will be used.
 925         (WebHistory::visitedURL): Swap the removeItemFromDateCaches and visitedWithTitle calls.
 926         * WebHistory.h:
 927
 928         * WebHistoryItem.cpp:
 929         (WebHistoryItem::initFromDictionaryRepresentation):  Add the negative-visit-count-correction-logic as implemented
 930           for Mac in http://trac.webkit.org/changeset/40851.
 931
 932 2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>
 933
 934         Stub out WebInspectorClient::hiddenPanels.
 935
 936         Reviewed by Timothy Hatcher.
 937
 938         * WebCoreSupport/WebInspectorClient.cpp:
 939         (WebInspectorClient::hiddenPanels):
 940         * WebCoreSupport/WebInspectorClient.h:
 941
 942 2009-02-11  Adam Roben  <aroben@apple.com>
 943
 944         Don't release the shared WebHistory instance on quit
 945
 946         This matches Mac, and prevents a race condition when the process exits
 947         that depends on the order in which global destructors are invoked.
 948
 949         Reviewed by Alexey Proskuryakov.
 950
 951         * WebHistory.cpp:
 952         (sharedHistoryStorage): Changed to use DEFINE_STATIC_LOCAL so the
 953         destructor is never called.
 954
 955 2009-02-10  Adam Roben  <aroben@apple.com>
 956
 957         Fix recursive WebView destruction when running DumpRenderTree
 958
 959         DumpRenderTree would call DestroyWindow on a WebView's host window,
 960         which would send a WM_DESTROY message to the WebView's window. Inside
 961         the WebView's WndProc, we would hold a ref to the WebView, then call
 962         close() and revokeDragDrop(), which would release all remaining
 963         references to the WebView other than the ref we held in the WndProc.
 964         When the WndProc exited, the final ref to the WebView would be
 965         released, invoking WebView's destructor. At this point,
 966         IsWindow(m_viewWindow) would return true, since we were still in the
 967         process of handling WM_DESTROY, so we would call DestroyWindow on the
 968         WebView's window again, re-entering the WndProc and re-reffing the
 969         WebView, leading to recursive destruction.
 970
 971         Reviewed by Alexey Proskuryakov.
 972
 973         * WebView.cpp:
 974         (WebView::~WebView): Don't call DestroyWindow if our window is already
 975         being destroyed.
 976         (WebViewWndProc): Only hold an extra ref to the WebView when we're not
 977         being destroyed.
 978
 979 2009-02-06  Adam Roben  <aroben@apple.com>
 980
 981         Build fix
 982
 983         Reviewed by Sam Weinig.
 984
 985         * WebCoreSupport/WebFrameLoaderClient.cpp: Added missing #include.
 986         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Removed
 987         incorrect .get(), and changed to use the new overload of
 988         WebHistory::itemForURLString.
 989
 990         * WebHistory.cpp:
 991         (WebHistory::itemForURLString): Made this const.
 992         (WebHistory::itemForURLString): Added an overload that takes a
 993         WebCore::String and returns the IWebHistoryItem instead of using an
 994         out parameter.
 995
 996         * WebHistory.h: Added public overload of itemForURLString.
 997
 998         * WebView.cpp:
 999         (WebView::prepareCandidateWindow):
1000         (WebView::onIMERequestCharPosition):
1001         (WebView::onIMERequestReconvertString):
1002         Updated for toRange -> toNormalizedRange rename.
1003
1004 2009-02-06  Geoffrey Garen  <ggaren@apple.com>
1005
1006         Reviewed by Sam Weinig.
1007
1008         Part III of <rdar://problem/6552272>.
1009
1010         Refactored to use the redirect data WebCore makes available, instead of
1011         tracking loading state in WebKit.
1012
1013         * WebCoreSupport/WebFrameLoaderClient.cpp:
1014         (WebFrameLoaderClient::updateGlobalHistory):
1015         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
1016         * WebCoreSupport/WebFrameLoaderClient.h:
1017         * WebHistory.cpp:
1018         (WebHistory::visitedURL):
1019         * WebHistory.h:
1020
1021 2009-02-06  Dan Bernstein  <mitz@apple.com>
1022
1023         Reviewed by Anders Carlsson.
1024
1025         - fix an assertion failure in Vector::at() beneath
1026           WebHistoryItem::dictionaryRepresentation.
1027
1028         * WebHistoryItem.cpp:
1029         (WebHistoryItem::dictionaryRepresentation): Give the numbers vector initial
1030         size. Also reduced the inline capacity of the vector used for weekly visit
1031         counts to 5, which is the expected maximum size.
1032
1033 2009-02-06  Brent Fulgham  <bfulgham@webkit.org>
1034
1035         Build fix.
1036
1037         * WebKit.vcproj/WebKit.vcproj: Re-enable missing file in Release
1038           target of Cairo.
1039
1040 2009-02-06  Maciej Stachowiak  <mjs@apple.com>
1041
1042         Rubber stamped by Dan Bernstein.
1043
1044         - fix obvious problem in previous commit (|| used instead of &&)
1045
1046         * WebHistoryItem.cpp:
1047         (WebHistoryItem::initFromDictionaryRepresentation):
1048
1049 2009-02-05  Maciej Stachowiak  <mjs@apple.com> and Brady Eidson  <beidson@apple.com>
1050
1051         Reviewed by Dan Bernstein and Geoff Garen..
1052
1053         - WebKit code to track per-day and per-week visit counts in history
1054
1055         For now this data is only exposed via SPI for performance reasons.
1056
1057         * Interfaces/IWebHistoryItemPrivate.idl: Added new interface.
1058         * WebHistory.cpp:
1059         (WebHistory::visitedURL): Use new recordInitialVisit method.
1060         * WebHistoryItem.cpp:
1061         (WebHistoryItem::initFromDictionaryRepresentation): Add parsing support
1062         for new data.
1063         (WebHistoryItem::dictionaryRepresentation): Add saving support for
1064         new data.
1065         (WebHistoryItem::getDailyVisitCounts): SPI accessor.
1066         (WebHistoryItem::getWeeklyVisitCounts): SPI accessor.
1067         (WebHistoryItem::recordInitialVisit): Tell WebCore to record an initial visit.
1068         * WebHistoryItem.h:
1069
1070 2009-02-05  Brent Fulgham  <bfulgham@webkit.org>
1071
1072         Reviewed by Sam Weinig <sam@webkit.org>
1073
1074         Build fix.  Update file for recently removed EventTargetNodeCast.
1075         * DOMCoreClasses.cpp:
1076         (DOMNode::dispatchEvent):
1077
1078 2009-02-05  Aaron Boodman  <aa@chromium.org>
1079
1080         Reviewed by Dave Hyatt.
1081
1082         https://bugs.webkit.org/show_bug.cgi?id=23708
1083         Adds documentElementAvailable() callback to FrameLoaderClient.
1084
1085         * WebFrame.cpp:
1086         (WebFrame::documentElementAvailable):
1087         Stub out documentElementAvailable()
1088         * WebFrame.h:
1089         Ditto.
1090
1091 2009-02-04  Geoffrey Garen  <ggaren@apple.com>
1092
1093         Build fix.
1094
1095         * WebHistory.cpp:
1096         (WebHistory::visitedURL):
1097
1098 2009-02-04  Geoffrey Garen  <ggaren@apple.com>
1099
1100         Reviewed by Mark Rowe.
1101
1102         Part I of <rdar://problem/6552272>.
1103
1104         Clear the redirectURLs entry when first visiting a site, so sites that
1105         only redirect you the first time you visit them can later learn that
1106         they don't redirect.
1107
1108         * WebHistory.cpp:
1109         (WebHistory::visitedURL):
1110
1111 2009-02-03  Geoffrey Garen  <ggaren@apple.com>
1112
1113         Build fix.
1114
1115         * WebHistory.cpp:
1116         (WebHistory::visitedURL):
1117
1118 2009-02-02  Geoffrey Garen  <ggaren@apple.com>
1119
1120         Build fix.
1121
1122         * WebHistory.cpp:
1123         (WebHistory::visitedURL):
1124
1125 2009-02-02  Hiroaki Nakamura <hnakamur@gmail.com>
1126
1127         Reviewed by Adam Roben.
1128
1129         Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
1130         Modify pre-build step to properly handle the errorlevel
1131         shell command.
1132
1133         * WebKit.vcproj/WebKit.vcproj: Change errorlevel handling
1134         for all targets so prefast is only enabled in builds
1135         where /analyze is available.
1136
1137 2009-02-02  Geoffrey Garen  <ggaren@apple.com>
1138
1139         Reviewed by Sam Weinig.
1140
1141         Track redirects in global history.
1142
1143         * Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
1144
1145         * WebCoreSupport/WebFrameLoaderClient.cpp:
1146         (WebFrameLoaderClient::updateGlobalHistory):
1147         (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
1148         Store redirect information in global history.
1149
1150         (WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
1151
1152         * WebCoreSupport/WebFrameLoaderClient.h: See above.
1153
1154         * WebFrame.cpp:
1155         (WebFrame::loadRequest):
1156         (WebFrame::loadData): Updated for extra parameter.
1157
1158         * WebHistory.cpp:
1159         (WebHistory::visitedURL):
1160         (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect
1161         information in global history.
1162
1163         * WebHistory.h: See above.
1164
1165 2009-02-02  Brady Eidson  <beidson@apple.com>
1166
1167         Reviewed by Dan Bernstein
1168
1169         Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.
1170
1171         * Interfaces/IWebHistoryItemPrivate.idl:
1172         * WebCoreSupport/WebFrameLoaderClient.cpp:
1173         (WebFrameLoaderClient::updateGlobalHistory):
1174
1175         * WebHistory.cpp:
1176         (WebHistory::visitedURL):
1177         * WebHistory.h:
1178
1179         * WebHistoryItem.cpp:
1180         (WebHistoryItem::visitedWithTitle):
1181         * WebHistoryItem.h:
1182
1183 2009-02-02  Anders Carlsson  <andersca@apple.com>
1184
1185         Fix build.
1186
1187         * WebCoreSupport/WebFrameLoaderClient.cpp:
1188         (WebFrameLoaderClient::createPlugin):
1189         * WebCoreSupport/WebFrameLoaderClient.h:
1190
1191 2009-02-02  Anders Carlsson  <andersca@apple.com>
1192
1193         Reviewed by Dan Bernstein.
1194
1195         Update for changes to WebCore.
1196
1197         * WebFrame.cpp:
1198         (WebFrame::createJavaAppletWidget):
1199         * WebFrame.h:
1200
1201 2009-02-02  Holger Hans Peter Freyther  <zecke@selfish.org>
1202
1203         Reviewed by Darin Adler.
1204
1205         Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
1206
1207         https://bugs.webkit.org/show_bug.cgi?id=23428
1208
1209         FrameView::forceLayout could be killed but the comment might
1210         contain a value over the the plain FrameView::layout...
1211
1212         Adjust the WebCore/WebKit consumers of these methods.
1213
1214         * WebCoreSupport/WebFrameLoaderClient.cpp:
1215         (WebFrameLoaderClient::forceLayout):
1216
1217 2009-01-31  Matt Lilek  <webkit@mattlilek.com>
1218
1219         Not reviewed, build fixes.
1220
1221         * WebCoreSupport/WebContextMenuClient.cpp:
1222         (WebContextMenuClient::searchWithGoogle):
1223         * WebFrame.cpp:
1224         (WebFrame::setInPrintingMode):
1225         (WebFrame::isFrameSet):
1226         * WebView.cpp:
1227         (WebView::notifyPreferencesChanged):
1228
1229 2009-01-30  Adam Barth  <abarth@webkit.org>
1230
1231         Reviewed by Sam Weinig.
1232
1233         Add a pref to disable web security.
1234
1235         * Interfaces/IWebPreferencesPrivate.idl:
1236         * WebPreferenceKeysPrivate.h:
1237         * WebPreferences.cpp:
1238         (WebPreferences::initializeDefaultSettings):
1239         (WebPreferences::isWebSecurityEnabled):
1240         (WebPreferences::setWebSecurityEnabled):
1241         * WebPreferences.h:
1242         * WebView.cpp:
1243         (WebView::notifyPreferencesChanged):
1244
1245 2009-01-30  Geoffrey Garen  <ggaren@apple.com>
1246
1247         Build fix.
1248
1249         * Interfaces/IWebFramePrivate.idl:
1250         * WebCoreSupport/WebFrameLoaderClient.cpp:
1251         (WebFrameLoaderClient::loadURLIntoChild):
1252
1253 2009-01-30  Holger Hans Peter Freyther  <zecke@selfish.org>
1254
1255         Reviewed by Simon Hausmann.
1256
1257         Kill FrameLoaderClient.cpp, move the code over to Frame::createView
1258
1259         FrameLoaderClient is supposed to be an interface, move the
1260         to be shared code to Frame which is a controller and is
1261         allowed to create a FrameView.
1262
1263         * WebCoreSupport/WebFrameLoaderClient.cpp:
1264         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1265
1266 2009-01-30  Brady Eidson  <beidson@apple.com>
1267
1268         Reviewed by Sam Weinig
1269
1270         Remove FrameLoaderClient code that is now handled by FrameLoader itself
1271
1272         * WebFrame.cpp:
1273         (WebFrame::frameLoadCompleted):
1274
1275 2009-01-29  Sam Weinig  <sam@webkit.org>
1276
1277         Fix Windows build
1278
1279         * WebHistoryItem.cpp:
1280         (WebHistoryItem::initFromDictionaryRepresentation):
1281
1282 2009-01-29  Sam Weinig  <sam@webkit.org>
1283
1284         Reviewed by Anders Carlsson.
1285
1286         Second step in tracking the urls a HistoryItem was redirected through
1287         Add SPI to access the array of redirect urls associated with a HistoryItem.
1288
1289         * Interfaces/IWebHistoryItemPrivate.idl:
1290         * WebHistoryItem.cpp:
1291         (WebHistoryItem::dictionaryRepresentation):
1292         (WebHistoryItem::redirectURLs):
1293         * WebHistoryItem.h:
1294
1295 2009-01-29  Sam Weinig  <sam@webkit.org>
1296
1297         Reviewed by Mark Rowe.
1298
1299         First step in tracking the urls a HistoryItem was redirected through.
1300
1301         * WebHistoryItem.cpp:
1302         (WebHistoryItem::initFromDictionaryRepresentation):
1303         (WebHistoryItem::dictionaryRepresentation):
1304
1305 2009-01-29  Adam Roben  <aroben@apple.com>
1306
1307         Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
1308         receives a WM_PRINTCLIENT message
1309
1310         <https://bugs.webkit.org/show_bug.cgi?id=23623>
1311         <rdar://problem/6513921>
1312         <rdar://problem/6536874>
1313
1314         Reviewed by Darin Adler.
1315
1316         * WebFrame.cpp:
1317         (WebFrame::paintDocumentRectToContext):
1318         (WebFrame::spoolPages):
1319         Call GraphicsContext::setShouldIncludeChildWindows so that child
1320         windows will be painted into the GraphicsContext rather than painted
1321         directly to the screen.
1322
1323         * WebView.cpp:
1324         (WebView::updateBackingStore): Added a windowsToPaint parameter, which
1325         we pass along to paintIntoBackingStore.
1326
1327         (WebView::paint): Tell updateBackingStore to paint child windows if
1328         we're not painting to the screen.
1329
1330         (WebView::paintIntoBackingStore): Added a windowsToPaint paramter,
1331         which we use to tell our GraphicsContext whether or not to include
1332         child windows.
1333
1334         * WebView.h: Added windowsToPaint parameters to paintIntoBackingStore
1335         and updateBackingStore (which I also made private).
1336
1337 2009-01-29  Adam Roben  <aroben@apple.com>
1338
1339         Build fix after r40353
1340
1341         * WebCoreSupport/WebFrameLoaderClient.cpp:
1342         (WebFrameLoaderClient::loadURLIntoChild): Removed the check for
1343         FrameLoadTypeReloadAllowingStaleData.
1344
1345 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
1346
1347         Reviewed by Sam Weinig.
1348
1349         Updated for WebCore rename.
1350
1351         * WebView.cpp:
1352         (WebView::setCustomTextEncodingName):
1353
1354 2009-01-27  Brady Eidson  <beidson@apple.com>
1355
1356         Reviewed by Dan Bernstein
1357
1358         Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
1359
1360         * WebCoreSupport/WebFrameLoaderClient.cpp:
1361         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1362         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1363         * WebCoreSupport/WebFrameLoaderClient.h:
1364
1365         * WebFrame.cpp:
1366         * WebFrame.h:
1367
1368 2009-01-26  Adam Roben  <aroben@apple.com>
1369
1370         Fix an assertion failure when Safari loads an error page
1371
1372         Reviewed by Alexey Proskuryakov.
1373
1374         * WebFrame.cpp:
1375         (WebFrame::loadData): Use the two-argument version of KURL and
1376         MarshallingHelpers::BSTRToKURL, for reasons mentioned in r40248.
1377
1378 2009-01-26  Adam Roben  <aroben@apple.com>
1379
1380         Fix an assertion on launch in KURL::KURL
1381
1382         All URL strings passed in to the WebKit API need to be passed to
1383         MarshallingHelpers::BSTRToKURL so that they may be properly parsed.
1384
1385         Reviewed by Alexey Proskuryakov.
1386
1387         * MarshallingHelpers.cpp:
1388         (MarshallingHelpers::BSTRToKURL): Changed to use the two-argument
1389         constructor for KURL so that the strings will be parsed rather than
1390         assumed to be in the correct encoding/form.
1391
1392         * WebResource.cpp:
1393         (WebResource::initWithData):
1394         * WebURLResponse.cpp:
1395         (WebURLResponse::initWithURL):
1396         * WebView.cpp:
1397         (WebView::userAgentForURL):
1398         (WebView::copyURL):
1399         Changed to use MarshallingHelpers::BSTRToKURL instead of trying to do
1400         the work manually.
1401
1402 2009-01-25  Darin Adler  <darin@apple.com>
1403
1404         Try to fix Windows build.
1405
1406         * WebView.cpp: Added FloatQuad.h.
1407
1408 2009-01-23  Brent Fulgham  <bfulgham@webkit.org>
1409
1410         Reviewed by Darin Adler
1411
1412         https://bugs.webkit.org/show_bug.cgi?id=23492
1413         Exclude calls to WebKitSystemInterface functions when not
1414         using CoreGraphics.
1415
1416         * WebPreferences.cpp:
1417         (WebPreferences::setFontSmoothing):
1418         (WebPreferences::setFontSmoothingContrast):
1419         * WebTextRenderer.cpp:
1420         (WebTextRenderer::registerPrivateFont):
1421
1422 2009-01-23  Brady Eidson  <beidson@apple.com>
1423
1424         Rubberstamped by Darin Adler
1425
1426         Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
1427
1428         * WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h.
1429         (WebCachedFramePlatformData::WebCachedFramePlatformData):
1430         * WebCachedPagePlatformData.h: Removed.
1431
1432         * WebCoreSupport/WebFrameLoaderClient.cpp:
1433         (WebFrameLoaderClient::savePlatformDataToCachedPage):
1434
1435         * WebKit.vcproj/WebKit.vcproj:
1436
1437 2009-01-22  Eric Roman  <eroman@chromium.org>
1438
1439         Reviewed by Eric Seidel.
1440
1441         https://bugs.webkit.org/show_bug.cgi?id=20806
1442         Deprecate RSSFeedReferrer() and setRSSFeedReferrer().
1443
1444         * WebHistoryItem.cpp:
1445         (WebHistoryItem::RSSFeedReferrer):
1446         (WebHistoryItem::setRSSFeedReferrer):
1447
1448 2009-01-19  Sam Weinig  <sam@webkit.org>
1449
1450         Rubber-stamped by Gavin Barraclough.
1451
1452         Remove temporary operator-> from JSValuePtr.
1453
1454         * WebScriptCallFrame.cpp:
1455         (WebScriptCallFrame::jsValueToString):
1456         * WebView.cpp:
1457         (WebView::stringByEvaluatingJavaScriptFromString):
1458
1459 2009-01-19  Adam Roben  <aroben@apple.com>
1460
1461         Windows build fix
1462
1463         * DOMCoreClasses.cpp: Replaced "using namespace WebCore" with
1464         individual using directives for each type we need from that namespace,
1465         to avoid conflicts between DOMObject and WebCore::DOMObject.
1466         (DOMElement::font): Added a now-needed WebCore::.
1467
1468 2009-01-17  Steve Falkenburg  <sfalken@apple.com>
1469
1470         Build fix.
1471
1472         * WebCoreSupport/WebDragClient.cpp:
1473         (WebDragClient::createDragImageForLink):
1474
1475 2009-01-17  David Hyatt  <hyatt@apple.com>
1476
1477         Eliminate dependencies on backslashAsCurrencySymbol from WebKit.
1478
1479         Reviewed by Oliver Hunt
1480
1481         * WebFrame.cpp:
1482         (WebFrame::selectedString):
1483
1484 2009-01-16  Steve Falkenburg  <sfalken@apple.com>
1485
1486         <rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.
1487
1488         This was caused by mismatched ENABLE definitions across WebCore and WebKit.
1489
1490         Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
1491         In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
1492         to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
1493         Our Windows ENABLE flags now match Mac.
1494
1495         Reviewed by Adele Peterson.
1496
1497         * WebKit.vcproj/WebKit.vcproj:
1498
1499 2009-01-15  Adele Peterson  <adele@apple.com>
1500
1501         Reviewed by Darin Adler.
1502
1503         Fix for https://bugs.webkit.org/show_bug.cgi?id=21799
1504         <rdar://problem/6310684> Crash in dumpFramesAsText() when running http/tests/security/cross-origin-xsl-BLOCKED.html
1505
1506         Return S_OK or E_FAIL based on the result from CreateInstance.
1507         This was causing DumpRenderTree to not realize it had just gotten a null documentElement.
1508
1509         * DOMCoreClasses.cpp: Made all functions that return the result of CreateInstance consistent.
1510         (DOMNode::parentNode):
1511         (DOMNode::ownerDocument):
1512         (DOMNodeList::item):
1513         (DOMDocument::documentElement):
1514         (DOMDocument::createElement):
1515         (DOMDocument::getElementsByTagName):
1516         (DOMDocument::getElementsByTagNameNS):
1517         (DOMDocument::getElementById):
1518         (DOMDocument::getComputedStyle):
1519         (DOMDocument::createEvent):
1520         (DOMElement::style):
1521
1522 2009-01-14  Adele Peterson  <adele@apple.com>
1523
1524         Reviewed by Darin Adler.
1525
1526         Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
1527         <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
1528
1529         Added artwork.
1530
1531         * WebKit.vcproj/WebKit.rc:
1532         * WebKit.vcproj/WebKit.vcproj:
1533         * WebKit.vcproj/resource.h:
1534         * WebKit.vcproj/searchCancel.png: Added.
1535         * WebKit.vcproj/searchCancelPressed.png: Added.
1536         * WebKit.vcproj/searchMagnifier.png: Added.
1537         * WebKit.vcproj/searchMagnifierResults.png: Added.
1538         * WebKitDLL.cpp:(loadResourceIntoBuffer):
1539
1540 2009-01-14  Dan Bernstein  <mitz@apple.com>
1541
1542         Reviewed by John Sullivan.
1543
1544         - update copyright
1545
1546         * WebKit.resources/Info.plist:
1547         * WebKit.vcproj/WebKit.rc:
1548
1549 2009-01-13  Steve Falkenburg  <sfalken@apple.com>
1550
1551         Build fix.
1552
1553         * WebScriptCallFrame.cpp:
1554         (WebScriptCallFrame::jsValueToString):
1555
1556 2009-01-12  Brady Eidson  <beidson@apple.com>
1557
1558         Reviewed by Dan Bernstein
1559
1560         <rdar://problem/6490446> - Crash when going back to a cached page
1561
1562         * WebCoreSupport/WebFrameLoaderClient.cpp:
1563         (WebFrameLoaderClient::savePlatformDataToCachedPage):  ENABLE(CFNETWORK) needed to be USE(CFNETWORK)
1564
1565 2009-01-12  Brady Eidson  <beidson@apple.com>
1566
1567         Reviewed by Darin Adler
1568
1569         <rdar://problem/6468274> - Track Non-get requests in global history
1570
1571         * WebCoreSupport/WebFrameLoaderClient.cpp:
1572         (WebFrameLoaderClient::updateGlobalHistory):
1573
1574         * WebHistory.cpp:
1575         (WebHistory::addItem):
1576         * WebHistory.h:
1577
1578         * Interfaces/IWebHistoryItemPrivate.idl:
1579         * WebHistoryItem.cpp:
1580         (WebHistoryItem::initFromDictionaryRepresentation):
1581         (WebHistoryItem::dictionaryRepresentation):
1582         (WebHistoryItem::lastVisitWasHTTPNonGet):
1583         (WebHistoryItem::setLastVisitWasHTTPNonGet):
1584         * WebHistoryItem.h:
1585
1586 2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
1587
1588         Reviewed by Darin Adler.
1589
1590         Bug 22861: Turn the FontCache into a singleton
1591         https://bugs.webkit.org/show_bug.cgi?id=22861
1592
1593         * WebCoreStatistics.cpp:
1594         (WebCoreStatistics::cachedFontDataCount):
1595         (WebCoreStatistics::cachedFontDataInactiveCount):
1596         (WebCoreStatistics::purgeInactiveFontData):
1597         Redirected all the static calls to the global FontCache
1598         instance.
1599
1600 2009-01-11  Dmitry Titov  <dimich@chromium.org>
1601
1602         Reviewed by Darin Adler.
1603
1604         https://bugs.webkit.org/show_bug.cgi?id=23207
1605         Moved currentTime() to from WebCore to WTF.
1606
1607         * WebDownload.cpp: a different header file included.
1608         * WebDropSource.cpp: a different header file included.
1609
1610 2009-01-09  Darin Adler  <darin@apple.com>
1611
1612         Reviewed by Jon Honeycutt.
1613
1614         Bug 22913: REGRESSION: Space bar doesn't scroll on windows
1615         https://bugs.webkit.org/show_bug.cgi?id=22913
1616         rdar://problem/6479834
1617
1618         * WebView.cpp:
1619         (WebView::keyPress): Removed code to handle space bar here; put it in
1620         WebCore instead.
1621
1622 2009-01-09  Brent Fulgham  <bfulgham@gmail.com>
1623
1624         Reviewed by Adam Roben.
1625
1626         Fixes: http://bugs.webkit.org/show_bug.cgi?id=23092
1627         Separate CFNetwork-specific code in WebKit.dll into separate
1628         implementation files. Create cURL stub files to be populated
1629         with new implementation in a future bug report.
1630
1631         * WebCookieManager.cpp: Move CFNetwork-specific routines to
1632           the new WebCookieManagerCFNet.cpp file.
1633         (WebCookieManager::Release):
1634         * WebCookieManagerCFNet.cpp: Copied from WebCookieManager.cpp.
1635         (WebCookieManager::cookieStorage):
1636         * WebCookieManagerCurl.cpp: Added.
1637         (WebCookieManager::cookieStorage):
1638         (WebCookieManager::setCookieStorage):
1639         * WebCoreSupport/WebFrameLoaderClient.cpp: Conditionalize two
1640           methods in this file.
1641         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1642         (WebFrameLoaderClient::savePlatformDataToCachedPage):
1643         * WebDownload.cpp: Move CFNetwork-specific logic to the new
1644           WebDownloadCFNet.cpp
1645         (WebDownload::bundleExtension):
1646         (WebDownload::bundleMagicNumber):
1647         (WebDownload::bundlePathForTargetPath):
1648         (WebDownload::extractResumeDataFromBundle): Made static class method
1649           so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
1650         (WebDownload::appendResumeDataToBundle): Made static class method
1651           so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
1652         * WebDownload.h:
1653         * WebDownloadCFNet.cpp: Copied from WebDownload.cpp.
1654         (WebDownload::initToResumeWithBundle):
1655         (WebDownload::setDestination):
1656         (didFailCallback):
1657         * WebDownloadCurl.cpp: Added.
1658         (WebDownload::init):
1659         (WebDownload::initWithRequest):
1660         (WebDownload::initToResumeWithBundle):
1661         (WebDownload::start):
1662         (WebDownload::cancel):
1663         (WebDownload::cancelForResume):
1664         (WebDownload::deletesFileUponFailure):
1665         (WebDownload::setDeletesFileUponFailure):
1666         (WebDownload::setDestination):
1667         (WebDownload::cancelAuthenticationChallenge):
1668         (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
1669         (WebDownload::useCredential):
1670         * WebKit.vcproj/WebKit.vcproj: Modify Apple targets to exclude the
1671           new cURL files. Modify Cairo targets to exclude CFNet files.
1672         * WebMutableURLRequest.cpp: Conditionalize the single method
1673           with a CFNetwork-speicic call.
1674         (WebMutableURLRequest::mutableCopy):
1675         * WebURLAuthenticationChallenge.cpp: Conditionalize one line that
1676           causes build problems for cURL. This will be removed later.
1677         (WebURLAuthenticationChallenge::initWithProtectionSpace):
1678         * WebURLAuthenticationChallengeSender.cpp:
1679         * WebURLAuthenticationChallengeSenderCFNet.cpp: Copied from WebURLAuthenticationChallengeSender.cpp.
1680         (WebURLAuthenticationChallengeSender::useCredential):
1681         * WebURLAuthenticationChallengeSenderCurl.cpp: Added.
1682         (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
1683         (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
1684         (WebURLAuthenticationChallengeSender::useCredential):
1685         * WebURLResponse.cpp: Exclude WebKitSystemInterface when compiling
1686           for the cURL target.
1687
1688 2009-01-09  Alexey Proskuryakov  <ap@webkit.org>
1689
1690         Reviewed by Darin Adler.
1691
1692         Fix many appcache tests on Windows by making synchronous XMLHttpRequest throw on cache miss.
1693
1694         * WebFrame.cpp: (WebFrame::cannotShowURLError): Implement, so that synchronous XHR can
1695         raise exceptions, as needed for AppCache tests. I do not know why this error was not
1696         implemented.
1697
1698 2009-01-09  Darin Adler  <darin@apple.com>
1699
1700         Reviewed and landed by Adele Peterson.
1701
1702         Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
1703         https://bugs.webkit.org/show_bug.cgi?id=23160
1704
1705         * Interfaces/IWebViewPrivate.idl: Added setMemoryCacheDelegateCallsEnabled.
1706         * WebView.cpp:
1707         (WebView::setMemoryCacheDelegateCallsEnabled): Ditto.
1708         * WebView.h: Ditto.
1709
1710 2009-01-08  Dan Bernstein  <mitz@apple.com>
1711
1712         Reviewed by Adam Roben.
1713
1714         - WebPreferences changes to support Core Graphics native glyph drawing
1715
1716         * Interfaces/IWebPreferencesPrivate.idl: Added font smoothing contrast
1717         getter and setter.
1718         * WebPreferenceKeysPrivate.h: Added
1719         WebKitFontSmoothingContrastPreferenceKey.
1720         * WebPreferences.cpp:
1721         (WebPreferences::initializeDefaultSettings): Initialized
1722         WebKitFontSmoothingContrastPreferenceKey to 2.
1723         (WebPreferences::setFloatValue): Added.
1724         (WebPreferences::setFontSmoothing): Changed to map
1725         FontSmoothingTypeWindows to FontSmoothingTypeMedium.
1726         (WebPreferences::fontSmoothingContrast): Added.
1727         (WebPreferences::setFontSmoothingContrast): Added. Calls
1728         wkSetFontSmoothingContrast().
1729         * WebPreferences.h:
1730
1731 2009-01-08  Steve Falkenburg  <sfalken@apple.com>
1732
1733         <rdar://problem/6474244> REGRESSION(39561-39603): Heap corruption when saving passwords?
1734
1735         Reviewed by Adam Roben.
1736
1737         * WebView.cpp:
1738         (WebViewWndProc): Hold a ref to the WebView inside the WNDPROC, since it could go away in an event handler.
1739
1740 2009-01-07  Jon Honeycutt  <jhoneycutt@apple.com>
1741
1742         Fix a crash with querying a WebView for its global history item when
1743         its associated Page has no global history item.
1744
1745         Reviewed by Dan Bernstein.
1746
1747         * WebView.cpp:
1748         (WebView::globalHistoryItem): If the Page has no global history item,
1749         report 0.
1750
1751 2009-01-06  Adam Roben  <aroben@apple.com>
1752
1753         Fix Bug 22262: Clicking close ("X") button in docked Web Inspector
1754         clears Web Inspector but doesn't close it
1755
1756         <https://bugs.webkit.org/show_bug.cgi?id=22262>
1757         <rdar://problem/6371873>
1758
1759         Reviewed by Darin Adler.
1760
1761         * WebCoreSupport/WebInspectorClient.cpp:
1762         (WebInspectorClient::WebInspectorClient): Initialize new member.
1763         (WebInspectorClient::showWindow): Moved code from here to
1764         showWindowWithoutNotifications.
1765         (WebInspectorClient::closeWindow): Moved code from here to
1766         closeWindowWithoutNotifications.
1767
1768         (WebInspectorClient::attachWindow):
1769         (WebInspectorClient::detachWindow):
1770         Record whether or not we should be attached, then close and reopen the
1771         window without notifying the InspectorController. Code that was in
1772         these functions moved to showWindowWithoutNotifications and
1773         closeWindowWithoutNotifications, respectively.
1774
1775         (WebInspectorClient::closeWindowWithoutNotifications): Added. Code
1776         came from closeWindow and detachWindow.
1777         (WebInspectorClient::showWindowWithoutNotifications): Added. Code came
1778         from showWindow and attachWindow.
1779
1780         * WebCoreSupport/WebInspectorClient.h: Added
1781         {close,show}WindowWithoutNotifications and m_shouldAttachWhenShown.
1782
1783 2009-01-06  Anders Carlsson  <andersca@apple.com>
1784
1785         Reviewed by Sam Weinig.
1786
1787         Add a way for application to provide custom, full frame, views for certain MIME types.
1788
1789         * Interfaces/IWebEmbeddedView.idl:
1790         Add loading related methods.
1791
1792         * Interfaces/IWebViewPrivate.idl:
1793         Add new registerEmbeddedViewMIMEType method.
1794
1795         * WebCoreSupport/EmbeddedWidget.cpp:
1796         (EmbeddedWidget::didReceiveResponse):
1797         (EmbeddedWidget::didReceiveData):
1798         (EmbeddedWidget::didFinishLoading):
1799         (EmbeddedWidget::didFail):
1800         Implement these and call the IEmbeddedView methods.
1801
1802         * WebCoreSupport/EmbeddedWidget.h:
1803         Inherit from PluginManualLoader.
1804
1805         * WebCoreSupport/WebFrameLoaderClient.cpp:
1806         (WebFrameLoaderClient::redirectDataToPlugin):
1807         Handle the case where the widget is an EnbeddedWidget.
1808
1809         (WebFrameLoaderClient::shouldUsePluginDocument):
1810         Have this call WebView::shouldUseEmbeddedView.
1811
1812         * WebView.cpp:
1813         (WebView::canShowMIMEType):
1814         Have this call WebView::shouldUseEmbeddedView.
1815
1816         (WebView::registerEmbeddedViewMIMEType):
1817         Add the MIME type to the set.
1818
1819         (WebView::shouldUseEmbeddedView):
1820         Given a MIME type, returns whether an embedded view should be used or not.
1821
1822 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1823
1824         BUILD FIX (r39641): Try to fix WebIconDatabase build errors #4
1825
1826         * WebIconDatabase.cpp:
1827         (WebIconDatabase::isEnabled): Added 'WebIconDatabase::' to method
1828         signature.  (Another copy-paste error.)
1829         (WebIconDatabase::setEnabled): Ditto.
1830         * WebIconDatabase.h:
1831         (WebIconDatabase::startUpIconDatabase): Make private again.
1832         (WebIconDatabase::shutDownIconDatabase): Ditto.
1833
1834 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1835
1836         BUILD FIX (r39641): Try to fix build errors #3
1837
1838         Try to fix the following (more specific) build errors:
1839
1840             WebIconDatabase.cpp
1841             ..\WebIconDatabase.cpp(255) : error C2248: 'WebIconDatabase::shutDownIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
1842                     ...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
1843                     ...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
1844             ..\WebIconDatabase.cpp(255) : error C2352: 'WebIconDatabase::shutDownIconDatabase' : illegal call of non-static member function
1845                     ...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
1846             ..\WebIconDatabase.cpp(258) : error C2248: 'WebIconDatabase::startUpIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
1847                     ...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
1848                     ...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
1849             ..\WebIconDatabase.cpp(258) : error C2352: 'WebIconDatabase::startUpIconDatabase' : illegal call of non-static member function
1850                     ...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
1851
1852         * WebIconDatabase.cpp:
1853         (setEnabled): Get instance of shared WebIconDatabase, then call
1854         startUp/shutDown methods on it.
1855         * WebIconDatabase.h:
1856         (WebIconDatabase::startUpIconDatabase): Make protected again.
1857         (WebIconDatabase::shutDownIconDatabase): Ditto.
1858
1859 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1860
1861         BUILD FIX (r39641): Try to fix build errors again
1862
1863         Try to fix the following build errors:
1864
1865             WebIconDatabase.cpp
1866             ..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
1867             ..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
1868
1869         * WebIconDatabase.cpp:
1870         (setEnabled): Add class prefix to startUpIconDatabase() and
1871         shutDownIconDatabase().
1872         * WebIconDatabase.h:
1873         (WebIconDatabase::startUpIconDatabase): Make private again.
1874         (WebIconDatabase::shutDownIconDatabase): Ditto.
1875
1876 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1877
1878         BUILD FIX (r39641): Try to fix build error
1879
1880         Try to fix the following build errors:
1881
1882             WebIconDatabase.cpp
1883             ..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
1884             ..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
1885
1886         * WebIconDatabase.h:
1887         (WebIconDatabase::startUpIconDatabase): Make protected.
1888         (WebIconDatabase::shutDownIconDatabase): Ditto.
1889
1890 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1891
1892         BUILD FIX (r39641): Fix more silly errors
1893
1894         Fixes the following compilation errors:
1895
1896             WebIconDatabase.cpp
1897             ..\WebIconDatabase.cpp(85) : error C2065: 'standardPrefs' : undeclared identifier
1898             ..\WebIconDatabase.cpp(85) : error C2227: left of '->iconDatabaseLocation' must point to class/struct/union/generic type
1899                     type is ''unknown-type''
1900             ..\WebIconDatabase.cpp(241) : error C2575: 'isEnabled' : only member functions and bases can be virtual
1901             ..\WebIconDatabase.cpp(248) : error C2575: 'setEnabled' : only member functions and bases can be virtual
1902             ..\WebIconDatabase.cpp(253) : error C3861: 'shutDownIconDatabase': identifier not found
1903             ..\WebIconDatabase.cpp(256) : error C3861: 'startUpIconDatabase': identifier not found
1904
1905         * WebIconDatabase.cpp:
1906         (WebIconDatabase::startUpIconDatabase): Redeclare standardPrefs
1907         since this was in init() but not in this method after it was
1908         extracted from init().
1909         (isEnabled): Don't use "virtual" in method implementation
1910         (silly copy-paste error).
1911         (setEnabled): Ditto.
1912
1913 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1914
1915         BUILD FIX (r39641): Remove STDMETHODCALLTYPE from method declarations in IWebIconDatabase.idl
1916
1917         * Interfaces/IWebIconDatabase.idl: Removed "STDMETHODCALLTYPE"
1918         from silly copy-paste error in two method declarations.
1919
1920 2009-01-05  David Kilzer  <ddkilzer@apple.com>
1921
1922         Add API to enable, disable and check state of WebIconDatabase
1923
1924         Reviewed by Darin Adler & Timothy Hatcher.
1925
1926         Add WebIconDatabase::isEnabled() and WebIconDatabase::setEnabled()
1927         API to make it possible to enable, disable and check the state of
1928         the icon database.
1929
1930         * Interfaces/IWebIconDatabase.idl: Declared isEnabled() and
1931         setEnabled() methods.
1932         * WebIconDatabase.cpp:
1933         (WebIconDatabase::init): Extracted code into startUpIconDatabase().
1934         (WebIconDatabase::startUpIconDatabase): Added.  Extracted from
1935         init().
1936         (WebIconDatabase::shutDownIconDatabase): Added.  Method is empty
1937         since there is nothing to do yet on Windows.
1938         (isEnabled): Added.
1939         (setEnabled): Added.
1940         * WebIconDatabase.h: Added method declarations.
1941
1942 2009-01-05  Anders Carlsson  <andersca@apple.com>
1943
1944         Reviewed by Jon Honeycutt.
1945
1946         Pass more information in the property bag passed to embeddedViewWithArguments.
1947
1948         * Interfaces/IWebUIDelegatePrivate.idl:
1949         Declare new keys.
1950
1951         * WebCoreSupport/WebFrameLoaderClient.cpp:
1952         (WebFrameLoaderClient::createPlugin):
1953         Pass the base URL, MIME type and the containing element to embeddedViewWithArguments.
1954
1955 2009-01-05  Anders Carlsson  <andersca@apple.com>
1956
1957         Reviewed by Darin Adler, Jon Honeycutt.
1958
1959         Add a templatized COMVariant constructor so we can make COMVariants out of
1960         everything that has a COMVariantSetter specialization.
1961
1962         Add a COMVariantSetter specialization for COMVariant.
1963
1964         * COMVariantSetter.h:
1965         (COMVariant::COMVariant):
1966
1967 2009-01-05  Brent Fulgham  <bfulgham@gmail.com>
1968
1969         Reviewed by Oliver Hunt.
1970
1971         Fixes: https://bugs.webkit.org/show_bug.cgi?id=23027
1972
1973         Removes the WebKitGraphics files from the Cairo build, as well
1974         as excluding their link definitions.  These are not used outside
1975         of Safari, and should not be part of the 'Redistributable API.'
1976
1977         * WebKit.vcproj/WebKit.vcproj:  Update *_Cairo targets to exclude
1978           the WebKitGraphics.cpp/.h files.
1979         * WebKit.vcproj/WebKit_Cairo.def: Added.  File without Safari
1980           link definitions.
1981         * WebKit.vcproj/WebKit_Cairo_debug.def: Added.  File without Safari
1982           link definitions.
1983
1984 2009-01-05  Anders Carlsson  <andersca@apple.com>
1985
1986         Reviewed by Jon Honeycutt.
1987
1988         Add a simple, memory managed, wrapper around a VARIANT struuct.
1989
1990         * COMVariantSetter.h:
1991         (COMVariant::COMVariant):
1992         (COMVariant::~COMVariant):
1993         (COMVariant::operator=):
1994         (COMVariant::copyTo):
1995         (COMVariant::variantType):
1996
1997 2009-01-05  Adele Peterson  <adele@apple.com>
1998
1999         Windows build fix.
2000
2001         * WebCoreSupport/WebChromeClient.cpp:
2002
2003 2009-01-05  Anders Carlsson  <andersca@apple.com>
2004
2005         Reviewed by Adam Roben.
2006
2007         Make it possible to have per value variant types.
2008
2009         * COMPropertyBag.h:
2010         (::Read):
2011         Call variantType here, passing in the value.
2012
2013         (::GetPropertyInfo):
2014         Ditto.
2015
2016         * COMVariantSetter.h:
2017         (COMVariantSetterBase::variantType):
2018         Add COMVariantSetterBase, whose variantType implementation just returns the
2019         VariantType variable. Make all existing classes inherit from COMVariantSetterBase.
2020
2021 2009-01-05  Adam Treat  <adam.treat@torchmobile.com>
2022
2023         Fix win build
2024
2025         * WebCoreSupport/WebChromeClient.h:
2026
2027 2009-01-05  Adam Treat  <adam.treat@torchmobile.com>
2028
2029         Reviewed by George Staikos.
2030
2031         Build fix for contentsSizeChanged
2032
2033         * WebCoreSupport/WebChromeClient.cpp:
2034         (WebChromeClient::contentsSizeChanged):
2035         * WebCoreSupport/WebChromeClient.h:
2036
2037 2009-01-05  Anders Carlsson  <andersca@apple.com>
2038
2039         Reviewed by Kevin Decker.
2040
2041         Use the ManualLoader class instead of assuming that the manual loader
2042         is a plug-in view.
2043
2044         * WebCoreSupport/WebFrameLoaderClient.cpp:
2045         (WebFrameLoaderClient::WebFrameLoaderClient):
2046         (WebFrameLoaderClient::setMainDocumentError):
2047         (WebFrameLoaderClient::committedLoad):
2048         (WebFrameLoaderClient::finishedLoading):
2049         (WebFrameLoaderClient::redirectDataToPlugin):
2050         * WebCoreSupport/WebFrameLoaderClient.h:
2051
2052 2009-01-04  Adam Treat  <adam.treat@torchmobile.com>
2053
2054         Reviewed by George Staikos.
2055
2056         Make the apple windows port build with the new fixedLayoutSize feature
2057
2058         * WebCoreSupport/WebFrameLoaderClient.cpp:
2059         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2060
2061 2008-12-20  Dan Bernstein  <mitz@apple.com>
2062
2063         Reviewed by Ada Chan.
2064
2065         - expose the new allItems() method via a new IWebHistoryPrivate
2066           interface
2067
2068         * Interfaces/IWebHistoryPrivate.idl: Added.
2069         * Interfaces/WebKit.idl: Added IWebHistoryPrivate.idl.
2070         * WebHistory.cpp:
2071         (WebHistory::QueryInterface): Added IWebHistoryPrivate.
2072         (WebHistory::allItems):
2073         * WebHistory.h:
2074
2075 2008-12-19  Geoffrey Garen  <ggaren@apple.com>
2076
2077         Build fix.
2078
2079         * WebHistory.cpp:
2080         (WebHistory::allItems):
2081
2082 2008-12-19  Geoffrey Garen  <ggaren@apple.com>
2083
2084         Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
2085
2086         Added SPI for getting an unsorted vector of all items in history.
2087
2088         * WebHistory.cpp:
2089         (WebHistory::orderedItemsLastVisitedOnDay):
2090         (WebHistory::allItems):
2091         * WebHistory.h:
2092
2093 2008-12-18  Dan Bernstein  <mitz@apple.com>
2094
2095         Reviewed by Sam Weinig.
2096
2097         - implement FrameLoaderClient::shouldUseCredentialStorage() by calling
2098           a new resource load delegae method.
2099
2100         * Interfaces/IWebResourceLoadDelegatePrivate.idl: Added
2101         a ne interface, IWebResourceLoadDelegatePrivate2, including a new
2102         method, shouldUseCredentialStorage().
2103         * WebCoreSupport/WebFrameLoaderClient.cpp:
2104         (WebFrameLoaderClient::shouldUseCredentialStorage): Added. Calls the
2105         delegate method. If the method is unimplemented, returns true for
2106         backwards compatibility.
2107         * WebCoreSupport/WebFrameLoaderClient.h:
2108
2109 2008-12-18  Sam Weinig  <sam@webkit.org>
2110
2111         Reviewed by John Sullivan.
2112
2113         Implement FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() by calling
2114         a new private frame load delegate method.
2115
2116         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
2117         * WebCoreSupport/WebFrameLoaderClient.cpp:
2118         (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
2119         * WebCoreSupport/WebFrameLoaderClient.h:
2120
2121 2008-12-16  Steve Falkenburg  <sfalken@apple.com>
2122
2123         Windows build fix.
2124
2125         Reviewed by Stephanie Lewis.
2126
2127         * COMPropertyBag.h:
2128         (::createInstance):
2129         (::adopt):
2130         (::QueryInterface):
2131         (::AddRef):
2132         (::Release):
2133         (::Read):
2134         (::Write):
2135         (::CountProperties):
2136         (::GetPropertyInfo):
2137         (::LoadObject):
2138         * WebURLResponse.cpp:
2139         (WebURLResponse::allHeaderFields):
2140
2141 2008-12-16  Stephanie Lewis  <slewis@apple.com>
2142
2143         Another Windows Build Fix.
2144
2145         * WebURLResponse.cpp:
2146         (WebURLResponse::allHeaderFields):
2147
2148 2008-12-14  Dan Bernstein  <mitz@apple.com>
2149
2150         Reviewed by Darin Adler.
2151
2152         - Windows equivalent of <rdar://problem/3258561>
2153           WebHistoryAllItemsRemovedNotification should add items to userInfo
2154
2155         * WebHistory.cpp:
2156         (WebHistory::removeAllItems): Changed to create an array of all items
2157         and send it in the notification.
2158
2159 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
2160
2161         Reviewed by Oliver Hunt.
2162
2163         Fixes: https://bugs.webkit.org/show_bug.cgi?id=22805
2164
2165         Provides implementation of image drag for Windows Cairo back-end.
2166         Switch to generic PlatformGraphicsContext data type, rather than
2167         specific use of CoreGraphics types.
2168
2169         * WebCoreSupport/WebDragClient.cpp:
2170         (WebDragClient::createDragImageForLink): Revise calls to use more
2171         generic PlatformGraphicsContext data types and calls for better
2172         portability.
2173
2174 2008-12-12  Steve Falkenburg  <sfalken@apple.com>
2175
2176         Update Windows cache sizes to match recent Mac change.
2177
2178         Reviewed by Stephanie Lewis, Sam Weinig.
2179
2180         * WebView.cpp:
2181         (WebView::setCacheModel):
2182
2183 2008-12-12  Tor Arne Vestbø  <tavestbo@trolltech.com>
2184
2185         Rubber-stamped by Oliver Hunt.
2186
2187         Remove mutables from EmbeddedWidget
2188
2189         We can do this now that frameRectsChanged() is no longer const
2190
2191         * WebCoreSupport/EmbeddedWidget.h:
2192
2193 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
2194
2195         Rubber-stamped by Mark Rowe.
2196
2197         Roll out r39212 due to assertion failures during layout tests, multiple
2198         layout test failures, memory leaks, and obvious incorrectness.
2199
2200         * Interfaces/IWebPreferencesPrivate.idl:
2201         * WebPreferenceKeysPrivate.h:
2202         * WebPreferences.cpp:
2203         * WebPreferences.h:
2204
2205 2008-12-10  Glenn Wilson  <gwilson@google.com>
2206
2207         Reviewed by Adam Roben.
2208
2209         Added support for overriding default preferences per-test.
2210         https://bugs.webkit.org/show_bug.cgi?id=20534
2211         Two new methods were added: resetToDefaults and overridePreference.
2212
2213         * Interfaces/IWebPreferencesPrivate.idl: new method signatures
2214         * WebPreferenceKeysPrivate.h: added new key for internal state
2215         * WebPreferences.cpp: added new methods
2216         (WebPreferences::overridePreference): new method
2217         (WebPreferences::resetToDefaults): new method
2218         * WebPreferences.h: new method signatures
2219
2220 2008-12-08  Tor Arne Vestbø  <tavestbo@trolltech.com>
2221
2222         Reviewed by Darin Adler and Holger Freyther.
2223
2224         Make Widget::frameRectsChanged() and overrides non-const
2225
2226         This will hopefully allow us to get rid of some of the mutables in
2227         the classes that react to the callback by changing their own state.
2228
2229         * WebCoreSupport/EmbeddedWidget.cpp:
2230         (EmbeddedWidget::frameRectsChanged):
2231         * WebCoreSupport/EmbeddedWidget.h:
2232
2233 2008-12-09  Brett Wilson  <brettw@chromium.org>
2234
2235         Reviewed by Dave Hyatt.
2236
2237         https://bugs.webkit.org/show_bug.cgi?id=22177
2238
2239         Add a callback on ChromeClient that the state of form elements on
2240         the page has changed. This is to allow clients implementing session
2241         saving to know when the current state is dirty.
2242
2243         * WebCoreSupport/WebChromeClient.h:
2244         (WebChromeClient::formStateDidChange):
2245
2246 ks2008-12-08  Dan Bernstein  <mitz@apple.com>
2247
2248         Reviewed by Adam Roben.
2249
2250         - Fix nightly builds
2251
2252         * Interfaces/IWebViewPrivate.idl: Moved globalHistoryItem() to the end,
2253         so that it comes after all methods used by Safari 3.2.1.
2254
2255 2008-12-08  Dan Bernstein  <mitz@apple.com>
2256
2257         Reviewed by John Sullivan.
2258
2259         - WebKit/win part of tracking the global history item for a WebView
2260
2261         * Interfaces/IWebViewPrivate.idl: Declared globalHistoryItem()
2262         * WebView.cpp:
2263         (WebView::globalHistoryItem): Added. Gets the page's global history
2264         item.
2265         * WebView.h:
2266
2267 2008-12-06  Simon Fraser  <simon.fraser@apple.com>
2268
2269         Reviewed by Dave Hyatt
2270
2271         https://bugs.webkit.org/show_bug.cgi?id=15671
2272
2273         Renderer::caretRect() is now localCaretRect(), which needs
2274         converting to absolute coordinates (taking transforms into account).
2275
2276         * WebView.cpp:
2277         (WebView::handleContextMenuEvent):
2278
2279 2008-12-05  Darin Adler  <darin@apple.com>
2280
2281         Reviewed by Alexey Proskuryakov.
2282
2283         - fix https://bugs.webkit.org/show_bug.cgi?id=22674
2284           Webkit r39005 does not start, an entry point not found
2285
2286         * WebView.cpp:
2287         (findCFNetworkModule): Added.
2288         (findCopySharedURLCacheFunction): Added.
2289         (WebView::setCacheModel): Call CFURLCacheCopySharedURLCache via dynamic loading
2290         instead of compiling based on which version of CFNetwork headers are present.
2291
2292 2008-12-04  Steve Falkenburg  <sfalken@apple.com>
2293
2294         Implement IPropertyBag2::Read.
2295         Fill in dwType for IPropertyBag2::GetPropertyInfo (we always use PROPBAG2_TYPE_DATA).
2296         https://bugs.webkit.org/show_bug.cgi?id=22659
2297
2298         This fixes <rdar://problem/6419127> REGRESSION: Forms autocomplete is broken for "other forms"
2299
2300         Reviewed by Ada Chan, Alice Liu.
2301
2302         * COMPropertyBag.h:
2303         (::Read): Implemented.
2304         (::GetPropertyInfo): Set dwType to PROPBAG2_TYPE_DATA.
2305
2306 2008-12-02  Adam Roben  <aroben@apple.com>
2307
2308         Export new-ish JSCore convenience constructor functions
2309
2310         Reviewed by Jon Honeycutt.
2311
2312         * WebKit.vcproj/WebKit.def:
2313         * WebKit.vcproj/WebKit_debug.def:
2314         Export JSObjectMakeArray, JSObjectMakeDate, and JSObjectMakeRegExp.
2315         Remove duplicate export of JSObjectMakeFunction.
2316
2317 2008-12-02  Michael Moss  <mmoss@chromium.org>
2318
2319         Reviewed by Eric Seidel.
2320
2321         - Fix http/tests/navigation/reload-subframe-*frame.html on Windows.
2322         https://bugs.webkit.org/show_bug.cgi?id=20926
2323
2324         Change 31264 fixed this on Mac (since moved to WebCore/loader/FrameLoader.cpp), but was never ported to Windows.
2325
2326         * WebCoreSupport/WebFrameLoaderClient.cpp:
2327         (WebFrameLoaderClient::loadURLIntoChild):
2328
2329 2008-12-01  Steve Falkenburg  <sfalken@apple.com>
2330
2331         Implement renderedImage for Windows.
2332         https://bugs.webkit.org/show_bug.cgi?25648
2333
2334         Reviewed by Adam Roben.
2335
2336         * DOMCoreClasses.cpp:
2337         (DOMElement::renderedImage):
2338         * DOMCoreClasses.h:
2339         * Interfaces/DOMPrivate.idl:
2340
2341 2008-12-01  Eric Seidel  <eric@webkit.org>
2342
2343         Reviewed by Adam Roben.
2344
2345         NULL-check documentFrameView() and topDocumentFrameView() it's possible
2346         for either of these methods to return NULL, and this was seen to cause
2347         crashes in Chromium.
2348         https://bugs.webkit.org/show_bug.cgi?id=22572
2349
2350         * AccessibleBase.cpp:
2351         (AccessibleBase::get_accParent):
2352         (AccessibleBase::accLocation):
2353         (AccessibleBase::accHitTest):
2354
2355 2008-11-30  Antti Koivisto  <antti@apple.com>
2356
2357         Another Windows build fix.
2358
2359         * WebCoreStatistics.cpp:
2360         (WebCoreStatistics::javaScriptObjectsCount):
2361
2362 2008-11-30  Antti Koivisto  <antti@apple.com>
2363
2364         Windows build fix.
2365
2366         * WebJavaScriptCollector.cpp:
2367         (WebJavaScriptCollector::objectCount):
2368
2369 2008-11-29  Brent Fulgham  <bfulgham@gmail.com>
2370
2371         Reviewed by Alexey Proskuryakov.
2372
2373         Remove Visual Studio project dependencies on non-redistributable
2374         components in the Debug_Cairo and Release_Cairo build targets.
2375         See https://bugs.webkit.org/show_bug.cgi?id=22527
2376
2377         * WebKit.vcproj/WebKit.vcproj:
2378         * WebKit.vcproj/WebKit.sln: Instruct Cairo builds to not bother
2379           building the unused QuickTime support library.
2380
2381 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
2382
2383         Reviewed by Alexey Proskuryakov.
2384
2385         http://bugs.webkit.org/show_bug.cgi?id=15643
2386
2387         Added API support for the "trailing whitespace" work-around.  This includes an APIs
2388         to get and set the state of this configuration variable.
2389
2390         * Interfaces/IWebView.idl:
2391         * WebCoreSupport/WebEditorClient.cpp:
2392         (WebEditorClient::selectTrailingWhitespaceEnabled):
2393         * WebCoreSupport/WebEditorClient.h:
2394         * WebView.cpp:
2395         (WebView::WebView):
2396         (WebView::setSelectTrailingWhitespaceEnabled):
2397         (WebView::selectTrailingWhitespaceEnabled):
2398         * WebView.h:
2399
2400 2008-11-24  Darin Adler  <darin@apple.com>
2401
2402         Reviewed by Dan Bernstein.
2403
2404         - https://bugs.webkit.org/show_bug.cgi?id=22470
2405           remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
2406
2407         * WebCoreSupport/WebFrameLoaderClient.cpp:
2408         (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the
2409         DocumentLoader, just as we do the title and the failure flag.
2410         * WebCoreSupport/WebFrameLoaderClient.h: Remove argument.
2411
2412 2008-11-24  Darin Adler  <darin@apple.com>
2413
2414         Reviewed by Dan Bernstein.
2415
2416         - finish https://bugs.webkit.org/show_bug.cgi?id=22295
2417           track which history items are from page load failures
2418
2419         Last time around I did this only for the back/forward list and missed the
2420         global history list.
2421
2422         * Interfaces/IWebHistoryItemPrivate.idl: Added setLastVisitWasFailure.
2423
2424         * WebCoreSupport/WebFrameLoaderClient.cpp:
2425         (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure
2426         and pass the argument in to WebHistory.
2427
2428         * WebHistory.cpp: (WebHistory::addItem): Added wasFailure argument.
2429         Set the flag on the newly created history item.
2430         * WebHistory.h: Ditto.
2431
2432         * WebHistoryItem.cpp:
2433         (WebHistoryItem::setLastVisitWasFailure): Added.
2434         * WebHistoryItem.h: Ditto.
2435
2436 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
2437
2438         Fix call to Frame::selectionBounds in Windows build.
2439
2440         * WebView.cpp:
2441         (WebView::selectionRect):
2442
2443 2008-11-21  Dimitri Glazkov  <dglazkov@chromium.org>
2444
2445         Reviewed by Alexey Proskuryakov.
2446
2447         Debug WebKit crashes on launch because of threading not being initialized early enough.
2448
2449         * WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory):
2450         Call JSC::InitializeThreading().
2451
2452 2008-11-19  Darin Fisher  <darin@chromium.org>
2453
2454         Reviewed by Geoff Garen.
2455
2456         https://bugs.webkit.org/show_bug.cgi?id=22345
2457         Define ScriptValue as a thin container for a JSC::Value*.
2458
2459         * WebView.cpp:
2460         (WebView::stringByEvaluatingJavaScriptFromString):
2461
2462 2008-11-19  Adele Peterson  <adele@apple.com>
2463
2464         Reviewed by Darin Adler.
2465
2466         For transparent views, clear the dirty rect instead of painting it white.
2467
2468         * WebView.cpp: (WebView::paintIntoBackingStore):
2469
2470 2008-11-18  Adele Peterson  <adele@apple.com>
2471
2472         Reverting last change.  I just realized it causes the view to never get cleared out.
2473
2474         * WebView.cpp: (WebView::paintIntoBackingStore):
2475
2476 2008-11-18  Adele Peterson  <adele@apple.com>
2477
2478         Reviewed by John Sullivan.
2479
2480         Don't fill the view with white if its transparent.
2481
2482         * WebView.cpp: (WebView::paintIntoBackingStore):
2483
2484 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
2485
2486         Try to fix the Windows build. It is view and not webView.
2487
2488         * WebCoreSupport/WebFrameLoaderClient.cpp:
2489         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2490
2491 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
2492
2493         Reviewed by Simon Hausmann.
2494
2495         Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
2496
2497         After Hyatt's work on Widget and ScrollView there is little difference
2498         between the implementation of Qt, Gtk+ and Win. In fact any kind of
2499         difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
2500         port and the Qt port has at least one of them left.
2501
2502         The only difference between the implementations is in getting the the
2503         IntSize for the new FrameView, the background color to be applied and
2504         eventually some post processing.
2505
2506         Unify the implementations by providing a static helper function that
2507         takes a Frame, IntSize, color and transparency bit and calling it from
2508         the Gtk+, the Qt and the Windows port.
2509
2510         * WebCoreSupport/WebFrameLoaderClient.cpp:
2511         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2512
2513 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
2514
2515         Reviewed by Simon Hausmann.
2516
2517         https://bugs.webkit.org/show_bug.cgi?id=22056
2518
2519         Move setting the background color and transparency from WebKit/win
2520         to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
2521         to share this code.
2522
2523         * WebFrame.cpp:
2524         (WebFrame::updateBackground):
2525
2526 2008-11-16  Geoffrey Garen  <ggaren@apple.com>
2527
2528         Not reviewed.
2529
2530         Try to fix Windows build.
2531
2532         * WebCoreSupport/WebFrameLoaderClient.cpp:
2533
2534 2008-11-16  Darin Adler  <darin@apple.com>
2535
2536         Reviewed by Dan Bernstein.
2537
2538         - https://bugs.webkit.org/show_bug.cgi?id=22295
2539           track which history items are from page load failures
2540
2541         * Interfaces/IWebHistoryItemPrivate.idl: Added lastVisitWasFailure function.
2542
2543         * WebHistoryItem.cpp:
2544         (WebHistoryItem::initFromDictionaryRepresentation): Set the lastVisitWasFailure
2545         flag in the history item if the dictionary had an entry for lastVisitWasFailureKey.
2546         (WebHistoryItem::dictionaryRepresentation): Set the lastVisitWasFailureKey key
2547         in the dictionary if the history item had the lastVisitWasFailure flag.
2548         (WebHistoryItem::lastVisitWasFailure): Added.
2549
2550         * WebHistoryItem.h: Added lastVisitWasFailure function.
2551
2552 2008-11-15  Geoffrey Garen  <ggaren@apple.com>
2553
2554         Reviewed by Sam Weinig.
2555
2556         Updated for JavaScriptCore renames.
2557
2558         * WebScriptCallFrame.cpp:
2559         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
2560
2561 2008-11-14  Dan Bernstein  <mitz@apple.com>
2562
2563         - try to fix the Windows build
2564
2565         * WebCoreLocalizedStrings.cpp:
2566         (WebCore::contextMenuItemTagTextDirectionMenu): Added.
2567
2568 2008-11-13  Adam Roben  <aroben@apple.com>
2569
2570         Fix Bug 22244: Webkit nightly builds crash with Safari 3.2
2571
2572         <https://bugs.webkit.org/show_bug.cgi?id=22244>
2573
2574         r36652 added IWebViewPrivate::clearMainFrameName into the middle of
2575         the IWebViewPrivate interface, which modifies the part of the
2576         IWebViewPrivate vtable that Safari 3.2 relies on.
2577
2578         Reviewed by Dan Bernstein.
2579
2580         * Interfaces/IWebViewPrivate.idl: Move clearMainFrameName to the end
2581         of the interface.
2582
2583 2008-11-11  Dan Bernstein  <mitz@apple.com>
2584
2585         Reviewed by Adam Roben.
2586
2587         WebKit/win part of adding a master volume control for media elements in a WebView
2588         * Interfaces/IWebViewPrivate.idl: Added setMediaVolume() and
2589         mediaVolume().
2590         * WebView.cpp:
2591         (WebView::setMediaVolume): Added.
2592         (WebView::mediaVolume): Added.
2593         * WebView.h:
2594
2595 2008-11-10  Adam Roben  <aroben@apple.com>
2596
2597         Fix Bug 22158: Would like to turn on WebCore logging channels via an
2598         environment variable
2599
2600         <https://bugs.webkit.org/show_bug.cgi?id=22158>
2601
2602         Reviewed by Anders Carlsson.
2603
2604         * WebView.cpp:
2605         (WebView::initWithFrame): Call WebCore's
2606         InitializeLoggingChannelsIfNecessary.
2607
2608 2008-11-08  Dan Bernstein  <mitz@apple.com>
2609
2610         Reviewed by Darin Adler.
2611
2612         - WebKit/win part of adding WebPreferences for controlling databases and local storage
2613
2614         * Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled,
2615         databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
2616         * WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey
2617         and WebKitLocalStorageEnabledPreferenceKey.
2618         * WebPreferences.cpp:
2619         (WebPreferences::initializeDefaultSettings): Made databases and local
2620         storage enabled by default.
2621         (WebPreferences::setDatabasesEnabled): Added.
2622         (WebPreferences::databasesEnabled): Added.
2623         (WebPreferences::setLocalStorageEnabled): Added.
2624         (WebPreferences::localStorageEnabled): Added.
2625         * WebPreferences.h:
2626         * WebView.cpp:
2627         (WebView::notifyPreferencesChanged): Transfer the databases and local
2628         storage preferences to WebCore settings.
2629
2630 2008-11-06  John Sullivan  <sullivan@apple.com>
2631
2632         Eliminated one of the two booleans tracking whether zoom was text-only, to avoid future problems.
2633
2634         Reviewed by Adam Roben
2635
2636         * WebView.h:
2637         removed m_zoomMultiplierIsTextOnly
2638
2639         * WebView.cpp:
2640         (WebView::WebView):
2641         removed initialization of m_zoomMultiplierIsTextOnly
2642         (WebView::setZoomMultiplier):
2643         use m_page->settings()->setZoomsTextOnly() instead of setting m_zoomMultiplierIsTextOnly
2644         (WebView::zoomMultiplier):
2645         use m_page->settings()->zoomsTextOnly() instead of reading m_zoomMultiplierIsTextOnly
2646
2647 2008-11-06  Adele Peterson  <adele@apple.com>
2648
2649         Reviewed by Adam Roben.
2650
2651         Add support for a WebKitZoomsTextOnly preference.
2652
2653         * Interfaces/IWebPreferences.idl:
2654         * WebPreferenceKeysPrivate.h:
2655         * WebPreferences.cpp:
2656         (WebPreferences::setZoomsTextOnly):
2657         (WebPreferences::zoomsTextOnly):
2658         * WebPreferences.h:
2659
2660         * WebView.cpp:
2661         (WebView::canMakeTextLarger): Consider the zoomsTextOnly setting when computing this.
2662         (WebView::makeTextLarger): ditto.
2663         (WebView::canMakeTextSmaller): ditto.
2664         (WebView::makeTextSmaller): ditto.
2665         (WebView::canMakeTextStandardSize):
2666         Don't consider the setting in this case since we need to reset both text zoom and page zoom regardless of the setting.
2667         (WebView::makeTextStandardSize):
2668         (WebView::notifyPreferencesChanged): Set the WebCore settings to match the WebPreference for WebKitZoomsTextOnly.
2669
2670 2008-11-05  Dan Bernstein  <mitz@apple.com>
2671
2672         Reviewed by John Sullivan.
2673
2674         - make the {protocol,proxyType} argument of
2675           WebURLProtectionSpace::initWith{Proxy}Host actually work and fix
2676           assertion failures.
2677
2678         * WebURLProtectionSpace.cpp:
2679         (WebURLProtectionSpace::initWithHost): The BString comparisons were
2680         applying the BString==BSTR operator to a right hand side that was
2681         actually a WCHAR string. Fixed by using BStrings on both sides.
2682         (WebURLProtectionSpace::initWithProxyHost): Ditto.
2683
2684 2008-11-01  Alexey Proskuryakov  <ap@webkit.org>
2685
2686         Reviewed by Darin Adler.
2687
2688         https://bugs.webkit.org/show_bug.cgi?id=22030
2689         Make EventNames usable from multiple threads
2690
2691         * WebView.cpp: (WebView::interpretKeyEvent): Access event names via eventNames() function.
2692
2693 2008-11-03  Cameron Zwarich  <zwarich@apple.com>
2694
2695         Rubber-stamped by Maciej Stachowiak.
2696
2697         Move more files into the runtime subdirectory of JavaScriptCore.
2698
2699         * WebJavaScriptCollector.cpp:
2700
2701 2008-11-03  Dan Bernstein  <mitz@apple.com>
2702
2703         Reviewed by Steve Falkenburg.
2704
2705         - implement WebMutableURLRequest::setHTTPShouldHandleCookies()
2706         - add and implement WebMutableURLRequest::mutableCopy()
2707
2708         * Interfaces/IWebURLRequest.idl:
2709         * WebMutableURLRequest.cpp:
2710         (WebMutableURLRequest::setHTTPShouldHandleCookies):
2711         (WebMutableURLRequest::mutableCopy):
2712         * WebMutableURLRequest.h:
2713
2714 2008-10-31  Dan Bernstein  <mitz@apple.com>
2715
2716         Reviewed by John Sullivan.
2717
2718         - WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
2719
2720         * Interfaces/IWebViewPrivate.idl:
2721         * WebView.cpp:
2722         (WebView::setCookieEnabled):
2723         (WebView::cookieEnabled):
2724         * WebView.h:
2725
2726 2008-10-31  Adele Peterson  <adele@apple.com>
2727
2728         Reviewed by Darin Adler.
2729
2730         WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
2731         https://bugs.webkit.org/show_bug.cgi?id=22008
2732
2733         * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel):
2734         Add support for mulitple file selection.
2735
2736 2008-10-31  Darin Adler  <darin@apple.com>
2737
2738         - try to fix build
2739
2740         * WebView.cpp:
2741         (WebView::setCacheModel): Roll out the part of my last change
2742         that involved no longer using wkCopyFoundationCacheDirectory.
2743
2744 2008-10-30  Darin Adler  <darin@apple.com>
2745
2746         Reviewed by Sam Weinig.
2747
2748         - https://bugs.webkit.org/show_bug.cgi?id=21986
2749           <rdar://problem/6294285> adopt CFURLCopySharedURLCache
2750
2751         * WebView.cpp:
2752         (WebView::setCacheModel): Use CFURLCopySharedURLCache if present.
2753
2754 2008-10-30  Dan Bernstein  <mitz@apple.com>
2755
2756         Reviewed by Sam Weinig.
2757
2758         - export WTFReportAssertionFailureWithMessage()
2759
2760         * WebKit.vcproj/WebKit_debug.def:
2761
2762 2008-10-29  Steve Falkenburg  <sfalken@apple.com>
2763
2764         <rdar://problem/6326563> Crash on launch
2765
2766         For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
2767
2768         Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
2769         callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
2770         the explicit lock/unlock functions, we can avoid this.
2771
2772         Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
2773
2774         Reviewed by Darin Adler.
2775
2776         * WebKit.vcproj/WebKit.def:
2777         * WebKit.vcproj/WebKit_debug.def:
2778
2779 2008-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2780
2781         Export atomicallyInitializedStaticMutex.
2782
2783         Rubber-stamped by Steve Falkenburg.
2784
2785         * WebKit.vcproj/WebKit.def:
2786         * WebKit.vcproj/WebKit_debug.def:
2787
2788 2008-10-28  Cameron Zwarich  <zwarich@apple.com>
2789
2790         Reviewed by Mark Rowe.
2791
2792         Move ForwardingHeaders to their correct location after the creation of
2793         the runtime directory in JavaScriptCore.
2794
2795         * WebScriptCallFrame.h:
2796
2797 2008-10-28  Adele Peterson  <adele@apple.com>
2798
2799         Reviewed by John Sullivan.
2800
2801         Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
2802         "files" string for multifile uploads needs to be localized
2803
2804         * WebCoreLocalizedStrings.cpp: (multipleFileUploadText):
2805
2806 2008-10-28  Adele Peterson  <adele@apple.com>
2807
2808         Reviewed by Sam Weinig.
2809
2810         * English.lproj: Removed.
2811         * English.lproj/Localizable.strings: Removed.
2812         * WebKit.vcproj/WebKit.vcproj: Updated to use Localizable.strings in the top directory, to share with the Mac.
2813
2814 2008-10-28  Timothy Hatcher  <timothy@apple.com>
2815
2816         Add IWebInspector methods to enable the profiler.
2817
2818         https://bugs.webkit.org/show_bug.cgi?id=21927
2819
2820         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
2821         not slow down JavaScript all the time
2822
2823         Reviewed by Darin Adler and Kevin McCullough.
2824
2825         * WebInspector.cpp:
2826         (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled.
2827         (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler
2828         or enableProfiler methods.
2829         * WebInspector.h:
2830
2831 2008-10-27  Timothy Hatcher  <timothy@apple.com>
2832
2833         Rename a few methods related to attaching and detaching the debugger.
2834
2835         * Rename attachDebugger to enableDebugger.
2836         * Rename detachDebugger to disableDebugger.
2837         * Rename the debuggerAttached getter to debuggerEnabled.
2838
2839         Reviewed by Darin Adler.
2840
2841         * WebInspector.cpp:
2842         (WebInspector::isDebuggingJavaScript):
2843         (WebInspector::toggleDebuggingJavaScript):
2844
2845 2008-10-24  Sam Weinig  <sam@webkit.org>
2846
2847         Yet another windows build fix.
2848
2849         * WebCoreSupport/WebChromeClient.cpp:
2850
2851 2008-10-24  Sam Weinig  <sam@webkit.org>
2852
2853         Another windows build fix.
2854
2855         * WebCoreSupport/WebChromeClient.cpp:
2856
2857 2008-10-24  Sam Weinig  <sam@webkit.org>
2858
2859         Reviewed by Dan Bernstein.
2860
2861         Fix https://bugs.webkit.org/show_bug.cgi?id=21759
2862         Layering violation: FileChooser should not depend on Document/Frame/Page
2863
2864         * WebCoreSupport/WebChromeClient.cpp:
2865         (WebChromeClient::runOpenPanel):
2866         * WebCoreSupport/WebChromeClient.h:
2867
2868 2008-10-24  Timothy Hatcher  <timothy@apple.com>
2869
2870         Implement new InspectorClient methods to work with Settings.
2871
2872         https://bugs.webkit.org/show_bug.cgi?id=21856
2873
2874         Reviewed by Adam Roben.
2875
2876         * WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
2877         * WebCoreSupport/WebInspectorClient.h: Add the new methods.
2878
2879 2008-10-24  Darin Adler  <darin@apple.com>
2880
2881         - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
2882
2883         * WebScriptCallFrame.cpp:
2884         (WebScriptCallFrame::jsValueToString):
2885         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
2886         (WebScriptCallFrame::valueForVariable):
2887         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
2888         * WebScriptCallFrame.h:
2889         * WebView.cpp:
2890         (WebView::stringByEvaluatingJavaScriptFromString):
2891         Use JSValue* instead of JSValuePtr.
2892
2893 2008-10-22  Brent Fulgham  <bfulgham@gmail.com>
2894
2895         Correct build regressions in Cairo port for Windows.
2896         http://bugs.webkit.org/show_bug.cgi?id=21724
2897
2898         Reviewed by Adam Roben.
2899
2900         * WebView.cpp:
2901         (WebView::notifyPreferencesChanged): Don't try to call
2902         setShouldPaintNativeControls when SafariTheme support is disabled, as
2903         that function doesn't exist in that case.
2904
2905 2008-10-22  Brady Eidson  <beidson@apple.com>
2906
2907         Reviewed by Adam Roben
2908
2909         Move elementDoesAutoComplete() to IWebFramePrivate so it is exposed for DRT to use
2910
2911         * Interfaces/IWebFramePrivate.idl:
2912
2913         * WebFrame.cpp:
2914         (WebFrame::elementDoesAutoComplete):
2915         * WebFrame.h:
2916
2917         * WebHTMLRepresentation.cpp:
2918         (WebHTMLRepresentation::elementDoesAutoComplete):
2919
2920 2008-10-20  Sam Weinig  <sam@webkit.org>
2921
2922         Reviewed by Anders Carlsson.
2923
2924         Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
2925
2926         * WebFrame.cpp:
2927         * WebFrame.h:
2928
2929 2008-10-19  Darin Adler  <darin@apple.com>
2930
2931         Reviewed by Oliver Hunt.
2932
2933         - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
2934           improve performance by eliminating JSValue as a base class for JSCell
2935
2936         Remove most uses of JSValue, which will be removed in a future patch.
2937
2938         * WebScriptCallFrame.cpp:
2939         (WebScriptCallFrame::jsValueToString): Use JSValuePtr.
2940         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Ditto.
2941         (WebScriptCallFrame::valueForVariable): Put more code inside and ifdef.
2942         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Ditto.
2943         * WebScriptCallFrame.h: Use JSValuePtr.
2944
2945         * WebView.cpp:
2946         (WebView::stringByEvaluatingJavaScriptFromString): Use JSValuePtr.
2947
2948 2008-10-18  Dan Bernstein  <mitz@apple.com>
2949
2950         - build fix
2951
2952         * WebScriptCallFrame.cpp:
2953         (WebScriptCallFrame::jsValueToString):
2954
2955 2008-10-18  Dan Bernstein  <mitz@apple.com>
2956
2957         Reviewed by Sam Weinig.
2958
2959         - WebKit/win part of https://bugs.webkit.org/show_bug.cgi?id=21736
2960           Long-dead decoded image data make up for most of the object cache's memory use over time
2961
2962         * WebView.cpp:
2963         (WebView::setCacheModel): In the primary web browser model,
2964         set the cache's dead decoded data deletion interval to 60 seconds.
2965
2966 2008-10-16  Kevin McCullough  <kmccullough@apple.com>
2967
2968         Reviewed by Steve Falkenburg.
2969
2970         <rdar://problem/6292718>
2971         Implement a standard way to get the UA given an application name.
2972
2973         * Interfaces/IWebViewPrivate.idl:
2974         * WebView.cpp:
2975         (WebView::standardUserAgentWithApplicationName):
2976         * WebView.h:
2977
2978 2008-10-17  Dan Bernstein  <mitz@apple.com>
2979
2980         Reviewed by Sam Weinig.
2981
2982         - export WTF::initializeOnMainThread()
2983
2984         * WebKit.vcproj/WebKit.def:
2985         * WebKit.vcproj/WebKit_debug.def:
2986
2987 2008-10-15  Geoffrey Garen  <ggaren@apple.com>
2988
2989         Reviewed by Cameron Zwarich.
2990
2991         Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
2992         Start the debugger without reloading the inspected page
2993
2994         * WebInspector.cpp:
2995         (WebInspector::toggleDebuggingJavaScript): Updated for rename.
2996
2997 2008-10-15  Adam Roben  <aroben@apple.com>
2998
2999         Export WTF::Mutex::tryLock
3000
3001         * WebKit.vcproj/WebKit.def:
3002         * WebKit.vcproj/WebKit_debug.def:
3003
3004 2008-10-14  Jon Honeycutt  <jhoneycutt@apple.com>
3005
3006         Export currentThread.
3007
3008         Rubber-stamped by Dan Bernstein.
3009
3010         * WebKit.vcproj/WebKit.def:
3011         * WebKit.vcproj/WebKit_debug.def:
3012
3013 2008-10-13  Steve Falkenburg  <sfalken@apple.com>
3014
3015         Reorder methods to preserve compatibility.
3016
3017         Rubber stamped by Oliver Hunt.
3018
3019         * Interfaces/IWebViewPrivate.idl:
3020
3021 2008-10-11  Dan Bernstein  <mitz@apple.com>
3022
3023         Reviewed by Sam Weinig.
3024
3025         - add SPI for forcing the complex text code path to be used for all text
3026
3027         * Interfaces/IWebViewPrivate.idl:
3028         * WebView.cpp:
3029         (WebView::setAlwaysUsesComplexTextCodePath):
3030         (WebView::alwaysUsesComplexTextCodePath):
3031         * WebView.h:
3032
3033 2008-10-10  Ada Chan  <adachan@apple.com>
3034
3035         Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can
3036         potentially hold onto stale instances of WebPreferences
3037         https://bugs.webkit.org/show_bug.cgi?id=21526
3038
3039         webPreferencesInstances now keeps a reference to all the instances it holds.
3040         Fix up callers of WebPreferences::removeReferenceForIdentifier() to call
3041         it after they have released their references to the WebPreferences objects.
3042
3043         Reviewed by Adam Roben.
3044
3045         * WebPreferences.cpp:
3046         (WebPreferences::getInstanceForIdentifier):
3047         (WebPreferences::removeReferenceForIdentifier):
3048         * WebView.cpp:
3049         (WebView::close):
3050         (WebView::setPreferences):
3051
3052 2008-10-06  David Hyatt  <hyatt@apple.com>
3053
3054         Enable viewless Mac WebKit to paint some basic pages.
3055
3056         Reviewed by Sam Weinig
3057
3058         * WebCoreSupport/WebFrameLoaderClient.cpp:
3059         (WebFrameLoaderClient::createFrame):
3060         * WebCoreSupport/WebFrameLoaderClient.h:
3061
3062 2008-10-03  David Hyatt  <hyatt@apple.com>
3063
3064         https://bugs.webkit.org/show_bug.cgi?id=21340
3065
3066         Remove "containingWindow()/setContainingWindow()" from Widget.  HostWindow covers this now.
3067
3068         Reviewed by Dan Bernstein & Darin Adler
3069
3070         * WebCoreSupport/WebFrameLoaderClient.cpp:
3071         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3072         * WebScrollBar.cpp:
3073         (WebScrollBar::WebScrollBar):
3074         (WebScrollBar::init):
3075         (WebScrollBar::invalidateScrollbarRect):
3076         * WebScrollBar.h:
3077
3078 2008-10-03  David Hyatt  <hyatt@apple.com>
3079
3080          Remove addToDirtyRegion.
3081
3082          Reviewed by Oliver Hunt
3083
3084         * WebCoreSupport/WebChromeClient.cpp:
3085
3086 2008-10-02  David Hyatt  <hyatt@apple.com>
3087
3088         https://bugs.webkit.org/show_bug.cgi?id=21328
3089
3090         Make widget invalidation more cross-platform.
3091
3092         (1) Make invalidateRect a pure virtual function on Widget.  All leaf widgets must now implement this function.
3093
3094         (2) Scrollbars now send invalidations through the ScrollbarClient.  windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
3095         This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
3096
3097         (3) Plugins now have the native window invalidation code for windowed plugins.  Windowless plugins do a repaintRectangle on the plugin's renderer.
3098
3099         (4) FrameViews now do a repaintRectangle on their owner element's renderer.
3100
3101         Reviewed by Sam Weinig
3102
3103         * WebCoreSupport/EmbeddedWidget.cpp:
3104         (EmbeddedWidget::invalidateRect):
3105         * WebCoreSupport/EmbeddedWidget.h:
3106         * WebScrollBar.cpp:
3107         (WebScrollBar::invalidateScrollbarRect):
3108         * WebScrollBar.h:
3109
3110 2008-10-02  Darin Adler  <darin@apple.com>
3111
3112         - https://bugs.webkit.org/show_bug.cgi?id=21321
3113           Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
3114
3115         * WebCoreStatistics.cpp:
3116         (WebCoreStatistics::javaScriptObjectsCount): Use heap. instead of heap-> to
3117         work with the heap.
3118         (WebCoreStatistics::javaScriptGlobalObjectsCount): Ditto.
3119         (WebCoreStatistics::javaScriptProtectedObjectsCount): Ditto.
3120         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): Ditto.
3121         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): Ditto.
3122         * WebJavaScriptCollector.cpp:
3123         (WebJavaScriptCollector::objectCount): Ditto.
3124
3125 2008-10-02  Dave Hyatt  <hyatt@apple.com>
3126
3127         https://bugs.webkit.org/show_bug.cgi?id=21316
3128
3129         Reviewed by Adele
3130
3131         * WebCoreSupport/WebFrameLoaderClient.cpp:
3132         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3133
3134 2008-10-02  David Hyatt  <hyatt@apple.com>
3135
3136         https://bugs.webkit.org/show_bug.cgi?id=21314
3137
3138         Make scrollBackingStore cross-platform.
3139
3140         Reviewed by Sam Weinig
3141
3142         * WebCoreSupport/WebChromeClient.cpp:
3143         (WebChromeClient::repaint):
3144         (WebChromeClient::scroll):
3145         * WebCoreSupport/WebChromeClient.h:
3146         * WebView.cpp:
3147         (WebView::repaint):
3148         * WebView.h:
3149
3150 2008-10-01  David Hyatt  <hyatt@apple.com>
3151
3152         https://bugs.webkit.org/show_bug.cgi?id=21298
3153
3154         Make updateScrollbars cross-platform.  For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store.  Next patch
3155         will make that cross-platform.
3156
3157         The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
3158         multiple inheritance.  For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
3159         windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).
3160
3161         Reviewed by Sam Weinig
3162
3163         * WebScrollBar.cpp:
3164         (WebScrollBar::windowClipRect):
3165         * WebScrollBar.h:
3166
3167 2008-10-01  David Hyatt  <hyatt@apple.com>
3168
3169         https://bugs.webkit.org/show_bug.cgi?id=21282
3170
3171         Make contentsToScreen/screenToContents cross-platform.  Only implemented by Mac/Win right now.
3172
3173         Reviewed by Adam Roben
3174
3175         * WebCoreSupport/WebChromeClient.cpp:
3176         (WebChromeClient::windowToScreen):
3177         (WebChromeClient::screenToWindow):
3178         * WebCoreSupport/WebChromeClient.h:
3179
3180 2008-09-30   Dave Hyatt  <hyatt@apple.com>
3181
3182         https://bugs.webkit.org/show_bug.cgi?id=21269
3183
3184         This patch makes the ScrollView::paint method cross-platform.  The paint method calls the base class
3185         Widget paint on platforms with native widgets (Mac and wx).  Otherwise it calls a virtual function,
3186         paintContents, to paint the ScrollView's contents, and then it paints each of the two scrollbars and
3187         the scrollbar corner.
3188
3189         The scrollbar themes are now responsible for painting scrollbar corners.  At the moment ScrollbarThemeWin still
3190         paints white (which is incorrect), so a future patch will actually implement proper native scroll corner painting
3191         for Windows.
3192
3193         paintContents is implemented by FrameView, and replaces Frame::paint.  All of the FramePrivate member
3194         variables used by Frame::paint have moved to FrameViewPrivate instead.  All callers of Frame::paint have
3195         been patched to use FrameView::paintContents instead.
3196
3197         Reviewed by Darin Adler
3198
3199         * WebFrame.cpp:
3200         (WebFrame::paintDocumentRectToContext):
3201         (WebFrame::spoolPages):
3202
3203 2008-09-30  Dave Hyatt  <hyatt@apple.com>
3204
3205         http://bugs.webkit.org/show_bug.cgi?id=21250
3206
3207         Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
3208         repaints up through the ChromeClient.
3209
3210         Reviewed by Darin Adler
3211
3212         * WebCoreSupport/WebChromeClient.cpp:
3213         (WebChromeClient::repaint):
3214         * WebCoreSupport/WebChromeClient.h:
3215         * WebView.cpp:
3216         (WebView::repaint):
3217         * WebView.h:
3218
3219 2008-09-29  Dan Bernstein  <mitz@apple.com>
3220
3221         Reviewed by Adam Roben.
3222
3223         - WebKit/win part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
3224
3225         * WebKitDLL.cpp:
3226         (DllMain): Call RenderThemeWin::setWebKitIsBeingUnloaded() when WebKit
3227         is being unloaded.
3228
3229 2008-09-27  David Hyatt  <hyatt@apple.com>
3230
3231         Land the frameGeometry->frameRect changes that I forgot to land in WebKit.
3232
3233         * Interfaces/IWebScrollBarPrivate.idl:
3234         * WebCoreSupport/EmbeddedWidget.cpp:
3235         (EmbeddedWidget::setFrameRect):
3236         (EmbeddedWidget::frameRectsChanged):
3237         * WebCoreSupport/EmbeddedWidget.h:
3238         * WebScrollBar.cpp:
3239         (WebScrollBar::setRect):
3240         (WebScrollBar::frameRect):
3241         * WebScrollBar.h:
3242
3243 2008-09-27  Anders Carlsson  <andersca@apple.com>
3244
3245         Fix build.
3246
3247         * WebCoreSupport/EmbeddedWidget.cpp:
3248         (EmbeddedWidget::setFrameRect):
3249         (EmbeddedWidget::frameRectsChanged):
3250         * WebCoreSupport/EmbeddedWidget.h:
3251         * WebScrollBar.cpp:
3252         (WebScrollBar::setRect):
3253         (WebScrollBar::frameGeometry):
3254
3255 2008-09-26  David Kilzer  <ddkilzer@apple.com>
3256
3257         Speculative Windows build fix with XSLT disabled
3258
3259         Reviewed by Alexey.
3260
3261         * WebCache.cpp:
3262         (WebCache::statistics): Populate xslStyleSheet statistics with
3263         zeros if XSLT is disabled.
3264
3265 2008-09-24  Matt Lilek  <webkit@mattlilek.com>
3266
3267         Reviewed by Darin Adler.
3268
3269         Bug 20999: Inspector hover to select does not work properly on Windows
3270         https://bugs.webkit.org/show_bug.cgi?id=20999
3271         <rdar://problem/6236524>
3272
3273         * WebNodeHighlight.cpp:
3274         (WebNodeHighlight::show):
3275
3276 2008-09-24  Darin Adler  <darin@apple.com>
3277
3278         * English.lproj/Localizable.strings: Updated for recent changes.
3279
3280 2008-09-22  Alice Liu  <alice.liu@apple.com>
3281
3282         Added record-memory-win.vcproj tool to the solution
3283
3284         Reviewed by Steve Falkenburg.
3285
3286         * WebKit.vcproj/WebKit.sln:
3287
3288 2008-09-20  Darin Adler  <darin@apple.com>
3289
3290         - fix build
3291
3292         * WebCoreSupport/WebChromeClient.cpp:
3293         (WebChromeClient::paintCustomScrollbar): Tweaked constant names to make this
3294         compile, but it may not be working correctly. Hyatt should do the real fix.
3295
3296 2008-09-19  Alice Liu  <alice.liu@apple.com>
3297
3298         Fix crash when submitting form at bugreport.apple.com rdar://6234126
3299
3300         Reviewed by Mark Rowe.
3301
3302         * COMPropertyBag.h:
3303         (::GetPropertyInfo):
3304         correct mis-use of comma operator
3305
3306 2008-09-18  Mark Rowe  <mrowe@apple.com>
3307
3308         Reviewed by Dan Bernstein.
3309
3310         Add SPI to WebView to allow DRT to clear the main frame's name between tests.
3311
3312         * Interfaces/IWebViewPrivate.idl:
3313         * WebView.cpp:
3314         (WebView::clearMainFrameName):
3315         * WebView.h:
3316
3317 2008-09-16  Alp Toker  <alp@nuanti.com>
3318
3319         Suggested by Dave Hyatt.
3320
3321         Build fix and cleanup. Rename ScrollBar to Scrollbar.
3322
3323         * WebScrollBar.cpp:
3324         * WebScrollBar.h:
3325
3326 2008-09-16  David Hyatt  <hyatt@apple.com>
3327
3328         Eliminate PlatformScrollbar.
3329
3330         Reviewed by Sam Weinig
3331
3332         * WebScrollBar.cpp:
3333         (WebScrollBar::init):
3334         * WebScrollBar.h:
3335
3336 2008-09-15  Chris Fleizach  <cfleizach@apple.com>
3337
3338         Reviewed by Darin Adler, Beth Dakin
3339
3340         Support strings for AXLists
3341
3342         * WebCoreLocalizedStrings.cpp:
3343         (WebCore::AXDefinitionListTermText):
3344         (WebCore::AXDefinitionListDefinitionText):
3345
3346 2008-09-13  Dave Hyatt  <hyatt@apple.com>
3347
3348         Add ScrollbarTheme to the build.
3349
3350         Reviewed by Sam Weinig
3351
3352         * WebScrollBar.cpp:
3353         (WebScrollBar::requestedWidth):
3354         (WebScrollBar::requestedHeight):
3355
3356 2008-09-13  Dave Hyatt  <hyatt@apple.com>
3357
3358         More scrollbar refactoring.
3359
3360         Reviewed by Sam Weinig
3361
3362         * WebScrollBar.h:
3363
3364 2008-09-08  Adam Roben  <aroben@apple.com>
3365
3366         Respect the font smoothing preference when drawing via WebKitGraphics
3367
3368         Reviewed by Dave Hyatt.
3369
3370         * WebKitGraphics.cpp:
3371         (makeFont): Check the font smoothing preference and update the
3372         FontDescription's rendering mode based on it.
3373
3374 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
3375
3376         Another Windows nightly build fix.
3377
3378         Remove non-production versions of CLSIDs since we'll use registry free COM with
3379         an embedded manifest now in all cases to find COM classes.
3380
3381         Reviewed by Sam Weinig.
3382
3383         * ForEachCoClass.cpp:
3384         (setUseOpenSourceWebKit): Remove COM registration code.
3385         * Interfaces/WebKit.idl: Remove non-production COM classes
3386
3387 2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3388
3389         Reviewed by Maciej Stachowiak.
3390
3391         Bug 20704: Replace the KJS namespace
3392         <https://bugs.webkit.org/show_bug.cgi?id=20704>
3393
3394         Rename the KJS namespace to JSC.
3395
3396         * WebCoreStatistics.cpp:
3397         * WebJavaScriptCollector.cpp:
3398         * WebScriptCallFrame.cpp:
3399         (WebScriptCallFrame::jsValueToString):
3400         * WebScriptCallFrame.h:
3401         (WebScriptCallFrame::state):
3402         * WebView.cpp:
3403         (WebView::WebView):
3404         (WebView::stringByEvaluatingJavaScriptFromString):
3405
3406 2008-09-05  Dave Hyatt  <hyatt@apple.com>
3407
3408         Add support for runtime switchability of the Aqua look and the native look on Windows.
3409         Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
3410
3411         Reviewed by Adam Roben
3412
3413         * Interfaces/IWebPreferencesPrivate.idl:
3414         * WebPreferenceKeysPrivate.h:
3415         * WebPreferences.cpp:
3416         (WebPreferences::initializeDefaultSettings):
3417         (WebPreferences::shouldPaintNativeControls):
3418         (WebPreferences::setShouldPaintNativeControls):
3419         * WebPreferences.h:
3420         * WebView.cpp:
3421         (WebView::notifyPreferencesChanged):
3422
3423 2008-09-04  Adam Roben  <aroben@apple.com>
3424
3425         Make JavaScriptCoreGenerated build first instead of WTF
3426
3427         JavaScriptCoreGenerated does some setup work that we want to happen
3428         before WTF builds.
3429
3430         * WebKit.vcproj/WebKit.sln: Reversed the dependencies of WTF and
3431         JavaScriptCoreGenerated.
3432
3433 2008-08-30  Sam Weinig  <sam@webkit.org>
3434
3435         Reviewed by Dan Bernstein.
3436
3437         Add WebView SPI to defer loading callbacks.
3438
3439         * Interfaces/IWebViewPrivate.idl:
3440         * WebView.cpp:
3441         (WebView::setDefersCallbacks):
3442         (WebView::defersCallbacks):
3443         * WebView.h:
3444
3445 2008-08-28  Adele Peterson  <adele@apple.com>
3446
3447         Build fix.
3448
3449         * WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
3450
3451 2008-08-28  Holger Hans Peter Freyther  <zecke@selfish.org>
3452
3453         Rubber-stamped by Darin Adler.
3454
3455         https://bugs.webkit.org/show_bug.cgi?id=17261
3456
3457         Remove the urlIcon.png from the project and the resource file. Remove
3458         the usage of this icon from WebKitDLL.cpp and change WebIconDatabase
3459         to get the icon from the IconDatabase code which is using a version of
3460         the icon that is compiled into the code.
3461
3462         * WebIconDatabase.cpp:
3463         (WebIconDatabase::getOrCreateDefaultIconBitmap): Use the icon from the
3464         IconDatabase.cpp
3465         * WebKit.vcproj/WebKit.rc: Remove urlIcon.cpp
3466         * WebKit.vcproj/urlIcon.png: Removed.
3467         * WebKitDLL.cpp:
3468         (loadResourceIntoBuffer): Remove "urlIcon"
3469
3470 2008-08-27  Alice Liu  <alice.liu@apple.com>
3471
3472         Add interface for obtaining JS object counts broken down by type
3473
3474         Reviewed by Steve Falkenburg.
3475
3476         * Interfaces/IWebCoreStatistics.idl:
3477         * WebCoreStatistics.cpp:
3478         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
3479         * WebCoreStatistics.h:
3480
3481 2008-08-27  Ada Chan  <adachan@apple.com>
3482
3483         Fixed build.
3484
3485         * WebFrame.cpp:
3486         (WebFrame::pluginWillHandleLoadError):
3487
3488 2008-08-27  Brady Eidson  <beidson@apple.com>
3489
3490         Reviewed by Anders
3491
3492         <rdar://problem/6134133> - Crash when loading large movie as a standalone document
3493
3494         * WebFrame.cpp:
3495         (WebFrame::pluginWillHandleLoadError):
3496         * WebFrame.h:
3497
3498 2008-08-26  Alice Liu  <alice.liu@apple.com>
3499
3500         Implement COMPropertyBag::GetPropertyInfo
3501         and a variant setter for type int
3502
3503         Reviewed by Anders Carlsson.
3504
3505         * COMPropertyBag.h:
3506         (::GetPropertyInfo):
3507         * COMVariantSetter.h:
3508
3509 2008-08-25  Adam Roben  <aroben@apple.com>
3510
3511         Fix an assertion when showing the Web Inspector
3512
3513         Reviewed by Kevin McCullough.
3514
3515         * WebCoreSupport/WebInspectorClient.cpp:
3516         (WebInspectorClient::attachWindow):
3517         (WebInspectorClient::detachWindow):
3518         Recent code changes have caused these functions to get called even
3519         when the window is already attached/detached, respectively. Handle
3520         this case gracefully instead of asserting something that is no longer
3521         true.
3522
3523 2008-08-24  Beth Dakin  <bdakin@apple.com>
3524
3525         Reviewed by John Sullivan.
3526
3527         Provide the excludeFromTextSearch SPI on Windows as well.
3528
3529         * Interfaces/IWebFrame.idl:
3530         * WebFrame.cpp:
3531         (WebFrame::setExcludeFromTextSearch):
3532         * WebFrame.h:
3533
3534 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
3535
3536         Cannot get the focused accessible object from the root object.
3537
3538         AccessibleBase::get_AccFocus() checks whether the focused object is a
3539         child of the current object, but
3540         http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
3541         the result is the object itself, if it has focus, or a child object of
3542         the active window, not a child of the object.
3543
3544         Reviewed by Sam Weinig.
3545
3546         * AccessibleBase.cpp:
3547         (AccessibleBase::get_accFocus): Don't check whether the focused object
3548         is our child.
3549
3550 2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>
3551
3552         Add SPI to make a Windows WebView transparent.
3553
3554         Reviewed by Dan Bernstein.
3555
3556         * Interfaces/IWebViewPrivate.idl:
3557         * WebCoreSupport/WebFrameLoaderClient.cpp:
3558         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
3559         updateBackground() when a new frame is attached, matching the Mac.
3560         * WebFrame.cpp:
3561         (WebFrame::updateBackground): Propagate WebView transparency to ourself
3562         and our child frames.
3563         * WebFrame.h:
3564         * WebView.cpp:
3565         (WebView::WebView):
3566         (WebView::paintIntoBackingStore): Pass m_transparent when creating a
3567         GraphicsContext, so the context will be created with an alpha channel.
3568         (WebView::setTransparent):
3569         (WebView::transparent):
3570         * WebView.h:
3571
3572 2008-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3573
3574         Add SPI to get a handle to the WebView's backing store bitmap.
3575
3576         Reviewed by Dan Bernstein.
3577
3578         * Interfaces/IWebViewPrivate.idl:
3579         * WebView.cpp:
3580         (WebView::backingStore):
3581         * WebView.h:
3582
3583 2008-08-21 Jonas Klink <klinktech@gmail.com>
3584
3585         Reviewed by Jon Honeycutt.
3586
3587         Fix https://bugs.webkit.org/show_bug.cgi?id=20231
3588         Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE
3589
3590         Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
3591         from accNavigate if no screen element is found in the specified direction.
3592
3593         * AccessibleBase.cpp:
3594         (AccessibleBase::accNavigate):
3595
3596 2008-08-21 Jonas Klink <klinktech@gmail.com>
3597
3598         Reviewed by Jon Honeycutt.
3599
3600         Fix http://bugs.webkit.org/show_bug.cgi?id=20230
3601         Bug 20230: get_accState should be testing state on childObj
3602
3603         Also initializes output parameter action to 0 in get_accDefaultAction.
3604
3605         * AccessibleBase.cpp:
3606         (AccessibleBase::get_accState):
3607         (AccessibleBase::get_accDefaultAction):
3608
3609 2008-08-20  Maxime Britto  <britto@apple.com>
3610
3611         Reviewed by Ada Chan.
3612
3613         rdar://5259746
3614         Mouse events are sent to page while resizing window (affects Gmail)
3615         In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.
3616
3617         * Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
3618         * WebView.cpp:
3619         (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns
3620
3621 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
3622
3623         Reviewed by Geoff Garen.
3624
3625         Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
3626
3627         * WebCoreStatistics.cpp:
3628         (WebCoreStatistics::javaScriptObjectsCount):
3629         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3630         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3631         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3632         * WebJavaScriptCollector.cpp:
3633         (WebJavaScriptCollector::objectCount):
3634         * WebScriptCallFrame.cpp:
3635         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3636         * WebView.cpp:
3637         (WebView::stringByEvaluatingJavaScriptFromString):
3638
3639 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
3640
3641         Fix build.
3642
3643         * WebScriptCallFrame.cpp:
3644         (WebScriptCallFrame::jsValueToString):
3645
3646 2008-08-14  Steve Falkenburg  <sfalken@apple.com>
3647
3648         Update cache capacities to match values used on Mac.
3649
3650         Reviewed by Dan Bernstein.
3651
3652         * WebView.cpp:
3653         (WebView::setCacheModel):
3654
3655 2008-08-14  Sam Weinig  <sam@webkit.org>
3656
3657         Reviewed by Jon Honeycutt.
3658
3659         Add WebView SPI to set HTMLTokenizer yielding parameters.
3660
3661         * Interfaces/IWebViewPrivate.idl:
3662         * WebView.cpp:
3663         (WebView::setCustomHTMLTokenizerTimeDelay):
3664         (WebView::setCustomHTMLTokenizerChunkSize):
3665         * WebView.h:
3666
3667 2008-08-13  Eric Seidel  <eric@webkit.org>
3668
3669         Attempt to fix the windows build, not review.
3670
3671         * WebIconDatabase.cpp:
3672         (WebIconDatabase::getOrCreateDefaultIconBitmap):
3673
3674 2008-08-13  Ada Chan  <adachan@apple.com>
3675
3676         Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
3677         Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
3678         content into a device context.  Changed WebView::paintDocumentRectToContext()
3679         to call that WebFrame method.
3680
3681         Reviewed by Adam Roben.
3682
3683         * DOMHTMLClasses.cpp:
3684         (DOMHTMLElement::idName):
3685         * Interfaces/IWebFramePrivate.idl:
3686         * WebFrame.cpp:
3687         (WebFrame::paintDocumentRectToContext):
3688         (WebFrame::frameElement):
3689         * WebFrame.h:
3690         * WebView.cpp:
3691         (WebView::paintDocumentRectToContext):
3692
3693 2008-08-12  Timothy Hatcher  <timothy@apple.com>
3694
3695         Add a stub for InspectorClient::setAttachedWindowHeight.
3696
3697         * WebCoreSupport/WebInspectorClient.cpp:
3698         (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
3699         * WebCoreSupport/WebInspectorClient.h:
3700
3701 2008-08-12  Adam Roben  <aroben@apple.com>
3702
3703         Export WTFLog in Debug builds
3704
3705         Reviewed by John Sullivan.
3706
3707         * WebKit.vcproj/WebKit_debug.def:
3708
3709 2008-08-07  Steve Falkenburg  <sfalken@apple.com>
3710
3711         Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.
3712
3713         WM_TIMER-based timers can be starved if enough other events are keeping
3714         our message loop busy. This change prevents many backing store deletes from stacking
3715         up in this case.
3716
3717         Reviewed by Geoff Garen.
3718
3719         * WebView.cpp:
3720         (WebView::deleteBackingStore):
3721         (WebView::deleteBackingStoreSoon):
3722         (WebView::cancelDeleteBackingStoreSoon):
3723
3724 2008-08-05  Ada Chan  <adachan@apple.com>
3725
3726         Add a getter for CFURLRequestRef in WebMutableURLRequest.
3727
3728         Reviewed by Anders Carlsson.
3729
3730         * Interfaces/IWebMutableURLRequestPrivate.idl:
3731         * WebMutableURLRequest.cpp:
3732         (WebMutableURLRequest::cfRequest):
3733         * WebMutableURLRequest.h:
3734
3735 2008-08-05  Steve Falkenburg  <sfalken@apple.com>
3736
3737         Don't invalidate a WebView in the process of being closed when prefs change.
3738
3739         Reviewed by Ada Chan.
3740
3741         * WebView.cpp:
3742         (WebView::notifyPreferencesChanged):
3743
3744 2008-08-04  Alice Liu  <alice.liu@apple.com>
3745
3746         Reviewed by Steve Falkenburg.
3747
3748         Fix CFDictionary leak
3749
3750         * CFDictionaryPropertyBag.cpp:
3751         (CFDictionaryPropertyBag::Write):
3752         m_dictionary is a RetainPtr and should adopt the CF type created
3753
3754 2008-08-02  Maxime Britto  <britto@apple.com>
3755
3756         Reviewed by Eric Seidel.
3757
3758         These icons are copies from the resizers in WebCore/Ressources
3759
3760         * ChangeLog:
3761         * WebKit.vcproj/WebKit.rc:
3762         * WebKit.vcproj/panEastCursor.png: Added.