2009-11-20 Eric Carlson <eric.carlson@apple.com>
[WebKit.git] / WebCore / ChangeLog
1 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
2
3         Reviewed by Simon Fraser.
4
5         <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
6
7         * css/mediaControls.css:
8             Define closed caption toggle button.
9
10         * rendering/RenderMedia.cpp:
11         (WebCore::RenderMedia::updateControls):
12             Create closed caption toggle button in display order.
13
14         * rendering/RenderThemeMac.mm:
15         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
16             Don't require MediaControllerThemeQuickTime theme for captions toggle button.
17             No need to check if the movie has video, a closed captions track is a video
18             track.
19
20 2009-11-20  Joseph Pecoraro  <joepeck@webkit.org>
21
22         Reviewed by Timothy Hatcher.
23
24         Web Inspector: Running code in the Console that ends with a
25         single line comment no longer produces a parse error.
26
27         * inspector/front-end/InjectedScript.js:
28         (InjectedScript._evaluateOn):
29
30 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
31
32         Reviewed by Beth Dakin.
33
34         WAI-ARIA: add support for 'math' role
35         https://bugs.webkit.org/show_bug.cgi?id=31706
36
37         * accessibility/AccessibilityObject.cpp:
38         * accessibility/AccessibilityObject.h:
39         * accessibility/mac/AccessibilityObjectWrapper.mm:
40
41 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
42
43         Reviewed by Kenneth Rohde Christiansen.
44
45         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
46         https://bugs.webkit.org/show_bug.cgi?id=30460
47
48         Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
49         It already refreshes plugins and reloads pages when necessary.
50
51         Tests: plugins/reloadplugins-and-pages.html
52                plugins/reloadplugins-no-pages.html
53
54         * plugins/PluginInfoStore.cpp:
55         (WebCore::refreshPlugins):
56
57 2009-11-20  Oliver Hunt  <oliver@apple.com>
58
59         Reviewed by Dave Hyatt.
60
61         <rdar://7409188> WebKit needs to be able to serialize and deserialize objects.
62
63         Expose WebCore object serialization to WebKit.
64
65         * WebCore.base.exp:
66         * bindings/js/SerializedScriptValue.cpp:
67         (WebCore::SerializedScriptValue::~SerializedScriptValue):
68         (WebCore::SerializedScriptValue::create):
69         (WebCore::SerializedScriptValue::deserialize):
70         * bindings/js/SerializedScriptValue.h:
71
72 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
73
74         Reviewed by Tim Hatcher.
75
76         Fixes <http://webkit.org/b/31741>.
77         Web Inspector: User Entered Data on the console should show up no matter what filters.
78         
79         Always show .console-user-command-result, no matter what the filter say
80         we should do with the other classes.
81
82         * inspector/front-end/inspector.css:
83
84 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
85
86         Reviewed by Tim Hatcher.
87
88         Fixes <http://webkit.org/b/31700>.
89         Web Inspector: isMac should be in one central location + Cached.
90         
91         We should cache the value of isMac, and make the indexOf call in one
92         single location, because we are calling it from multiple places, and saving
93         the result can save us time, and make the call sites simpler.
94
95         * inspector/front-end/AbstractTimelinePanel.js:
96         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
97         * inspector/front-end/ConsoleView.js:
98         (WebInspector.ConsoleView.prototype._updateFilter):
99         * inspector/front-end/ElementsPanel.js:
100         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
101         * inspector/front-end/ScriptsPanel.js:
102         (WebInspector.ScriptsPanel):
103         * inspector/front-end/SourceFrame.js:
104         (WebInspector.SourceFrame.prototype._loaded):
105         * inspector/front-end/inspector.js:
106         (WebInspector.documentKeyDown):
107         (WebInspector.isMac):
108
109 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
110
111         Removed .DS_Store accidentally added in last (r51245).
112
113 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
114
115         Reviewed by Timothy Hatcher.
116
117         Web Inspector: Add Console Only Layout Mode
118         https://bugs.webkit.org/show_bug.cgi?id=30282
119
120         Adds a Console Panel, which allows for a Full size Console. This
121         extends the Drawer to the size of a Panel. This also fixes previous
122         resize issues with the Drawer.
123
124         * inspector/front-end/ConsolePanel.js: added.
125         (WebInspector.ConsolePanel):
126         (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel):
127         (WebInspector.ConsolePanel.prototype.show):
128         (WebInspector.ConsolePanel.prototype.hide):
129         * inspector/front-end/Drawer.js:
130         (WebInspector.Drawer):
131         (WebInspector.Drawer.prototype.set visibleView):
132         (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console.
133         (WebInspector.Drawer.prototype.show.animationFinished):
134         (WebInspector.Drawer.prototype.show):
135         (WebInspector.Drawer.prototype.hide.animationFinished):
136         (WebInspector.Drawer.prototype.hide):
137         (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full
138         (WebInspector.Drawer.prototype.enterPanelMode):
139         (WebInspector.Drawer.prototype.exitPanelMode):
140         (WebInspector.Drawer.prototype.immediatelyExitPanelMode):
141         (WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
142         (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
143         (WebInspector.Drawer.prototype._animateDrawerHeight):
144         (WebInspector.Drawer.prototype._animationDuration):
145         (WebInspector.Drawer.prototype._startStatusBarDragging):
146         (WebInspector.Drawer.prototype._statusBarDragging):
147         (WebInspector.Drawer.prototype._endStatusBarDragging):
148
149         Miscellaneous changes and cleanup.
150
151         * English.lproj/localizedStrings.js: "Console" toolbar title.
152         * inspector/front-end/ConsoleView.js: removed unnecessary element reordering  
153         * inspector/front-end/Images/consoleIcon.png: added.
154         * inspector/front-end/inspector.css: added icon.
155         * inspector/front-end/inspector.html:
156         * inspector/front-end/inspector.js:
157         (WebInspector._createPanels): create console panel
158         (WebInspector.windowResize): resize drawer if necessary
159         (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode
160         (WebInspector.animateStyle): start animation interval, returns the interval key
161         (WebInspector.toggleAttach): resize drawer if necessary
162         (WebInspector.showConsolePanel): restore the panel when the inspector restarts
163         (WebInspector.showProfileForURL): style fix
164
165         Restore the panel when the inspector restarts.
166
167         * inspector/InspectorController.cpp:
168         (WebCore::InspectorController::setWindowVisible):
169         (WebCore::InspectorController::specialPanelForJSName):
170         * inspector/InspectorFrontend.cpp:
171         (WebCore::InspectorFrontend::showPanel):
172
173         Build files.
174
175         * WebCore.gypi:
176         * WebCore.vcproj/WebCore.vcproj:
177         * inspector/front-end/WebKit.qrc:
178
179 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
180
181         Reviewed by Tim Hatcher.
182
183         Fixes <http://webkit.org/b/31699>.
184         Web Inspector: Should Cache Values of InspectorController.platform() and port().
185
186         Refactor the Inspector to cache the value of InspectorController.platform
187         and InspectorController.port, because those need to call into C++, they are
188         being called more and more as we add platform specific keyboard shortcuts, and
189         they shouldn't change in the lifecycle of the Web Inspector.
190
191         * inspector/front-end/AbstractTimelinePanel.js:
192         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
193         * inspector/front-end/ConsoleView.js:
194         (WebInspector.ConsoleView.prototype._updateFilter):
195         * inspector/front-end/ElementsPanel.js:
196         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
197         * inspector/front-end/ScriptsPanel.js:
198         (WebInspector.ScriptsPanel):
199         * inspector/front-end/SourceFrame.js:
200         (WebInspector.SourceFrame.prototype._loaded):
201         * inspector/front-end/inspector.js:
202         (WebInspector.get platform):
203         (WebInspector.get port):
204         (WebInspector.loaded):
205         (WebInspector.documentKeyDown):
206         (WebInspector.toolbarDragStart):
207
208 2009-11-20  Dirk Schulze  <krit@webkit.org>
209
210         Unreviewed build fix for filters enabled builds.
211
212         * platform/graphics/filters/FEColorMatrix.cpp:
213         (WebCore::FEColorMatrix::apply):
214         * platform/graphics/filters/FEComposite.cpp:
215         (WebCore::FEComposite::apply):
216         * platform/graphics/filters/SourceGraphic.cpp:
217         (WebCore::SourceGraphic::apply):
218         * svg/graphics/SVGResourceFilter.cpp:
219         (WebCore::SVGResourceFilter::applyFilter):
220         * svg/graphics/filters/SVGFEMerge.cpp:
221         (WebCore::FEMerge::apply):
222         * svg/graphics/filters/SVGFEOffset.cpp:
223         (WebCore::FEOffset::apply):
224         * svg/graphics/filters/SVGFETile.cpp:
225         (WebCore::FETile::apply):
226
227 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
228
229         Reviewed by Simon Fraser.
230
231         <rdar://problem/7389945> QTKit based media engine should not claim to support 
232         fullscreen on Leopard
233
234         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
235         (WebCore::MediaPlayerPrivate::supportsFullscreen):
236             Only return true on SnowLeopard for now.
237
238         * rendering/RenderThemeMac.mm:
239         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
240             No need to special case MediaFullscreenButtonPart as the default implementation 
241             asks the media engine if it supports fullscreen.
242
243 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
244
245         Reviewed by Simon Hausmann.
246
247         Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
248                  Girish Ramakrishnan <girish@forwardbias.in>
249         
250         [Qt] Implement support for rendering plugins on Qt/Mac when a page is used
251         without a QWebView or when inside QGraphicsWebView.
252         
253         Currently, the code provides the cgcontext of the PlatformPluginWidget to
254         the plugin. This approach does not work when we are printing, or using
255         QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
256         up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
257         of the QPaintDevice's context.
258         
259         To solve all cases and keep the code simple, we render the plugin to an
260         offscreen pixmap in all cases. This way, the plugin always renders to the
261         CGContext of the pixmap and we then use QPainter to blit the pixmap into
262         the QPaintDevice. We also create a fake window and set it's WindowRef in
263         NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
264         
265         Now, that's the theory. In practice, ATM, mouse events do not work when using
266         the fake window. So, setPlatformPluginWidget() is still called when using QWebView
267         so that there are no regressions after this patch. Once we get mouse events
268         working, setPlatformPluginWidget will be removed.
269         
270         https://bugs.webkit.org/show_bug.cgi?id=31183
271
272         * plugins/PluginView.cpp:
273         (WebCore::PluginView::PluginView):
274         * plugins/PluginView.h:
275         * plugins/mac/PluginViewMac.cpp:
276         (WebCore::PluginView::platformStart):
277         (WebCore::PluginView::platformDestroy):
278         (WebCore::PluginView::setNPWindowIfNeeded):
279         (WebCore::PluginView::updatePluginWidget):
280         (WebCore::PluginView::paint):
281         (WebCore::PluginView::invalidateRect):
282
283 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
284
285         Reviewed by Timothy Hatcher.
286
287         Web Inspector: Resync Resources Backend and Frontend
288         https://bugs.webkit.org/show_bug.cgi?id=31705
289
290         * inspector/front-end/Resource.js: resync enum values with backend
291         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
292
293 2009-11-19  Steve Block  <steveblock@google.com>
294
295         Reviewed by Darin Fisher.
296
297         Android port lacks configuration in Platform.h and config.h.
298         https://bugs.webkit.org/show_bug.cgi?id=31671
299
300         Build change only. No new tests possible.
301
302         * config.h: Modified. Added Android-specific configuration.
303
304 2009-11-20  Roland Steiner  <rolandsteiner@chromium.org>
305
306         Reviewed by Darin Adler.
307
308         Change default stylesheet to reset text indentation for ruby elements by default.
309         (https://bugs.webkit.org/show_bug.cgi?id=31247)
310
311         Test: fast/ruby/ruby-text-indent.html
312
313         * css/html.css: reset text-indent on <ruby> and <rt> elements
314
315 2009-11-19  Brian Weinstein  <bweinstein@apple.com>
316
317         Reviewed by Darin Adler.
318
319         Fixes <http://webkit.org/b/22754>.
320         Web Inspector: Keyboard shortcut for Element finder.
321
322         Use Command + Shift + C as a shortcut for Node Search, to 
323         match the Firebug shortcut to do the same thing.
324
325         * inspector/front-end/ElementsPanel.js:
326         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
327
328 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
329
330         Reviewed by Darin Adler.
331
332         https://bugs.webkit.org/show_bug.cgi?id=31690
333         Make SocketStreamHandleCFNet work on Windows
334
335         * WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
336
337         * platform/network/ResourceHandle.h: Removed loaderRunLoop().
338
339         * platform/network/cf/LoaderRunLoopCF.cpp: Added.
340         (WebCore::emptyPerform):
341         (WebCore::runLoaderThread):
342         (WebCore::loaderRunLoop):
343         * platform/network/cf/LoaderRunLoopCF.h: Added.
344         Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
345         it's needed for more than just resource loading.
346
347         * platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
348
349         * platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
350
351         * platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
352         main thread.
353         * platform/network/cf/SocketStreamHandleCFNet.cpp:
354         (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
355         inoperable main run loop.
356
357         (WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo): 
358         (WebCore::SocketStreamHandle::readStreamCallback):
359         (WebCore::SocketStreamHandle::writeStreamCallback):
360         (WebCore::SocketStreamHandle::readStreamCallbackMainThread):
361         (WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
362         Forward stream events to main thread on Windows.
363
364 2009-11-19  Avi Drissman  <avi@chromium.org>
365
366         Reviewed by Darin Adler.
367
368         Quick style fix.
369         https://bugs.webkit.org/show_bug.cgi?id=27777
370
371         * platform/graphics/cg/PDFDocumentImage.cpp:
372
373 2009-11-19  Beth Dakin  <bdakin@apple.com>
374
375        Build fix. No review needed.
376
377         * platform/chromium/ScrollbarThemeChromium.cpp:
378         (WebCore::ScrollbarThemeChromium::paintTickmarks):
379         * rendering/RenderMediaControlsChromium.cpp:
380         (WebCore::paintMediaButton):
381
382 2009-11-19  Beth Dakin  <bdakin@apple.com>
383       
384        Build fix. No review needed.
385
386         * rendering/RenderThemeChromiumSkia.cpp:
387         (WebCore::RenderThemeChromiumSkia::paintCheckbox):
388         (WebCore::RenderThemeChromiumSkia::paintRadio):
389         (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
390         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
391         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
392
393 2009-11-19  Beth Dakin  <bdakin@apple.com>
394
395        Build fix. No review needed.
396
397         * platform/graphics/qt/StillImageQt.cpp:
398         (WebCore::StillImage::draw):
399         * platform/graphics/qt/StillImageQt.h:
400
401 2009-11-19  Beth Dakin  <bdakin@apple.com>
402
403        Build fix. No review needed.
404
405         * rendering/RenderThemeWin.cpp:
406         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
407         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
408         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
409
410 2009-11-19  Beth Dakin  <bdakin@apple.com>
411
412        Build fix. No review needed.
413
414         * plugins/PluginView.cpp:
415         (WebCore::PluginView::paintMissingPluginIcon):
416
417 2009-11-19  Beth Dakin  <bdakin@apple.com>
418
419         Build fix. No review needed.
420
421         * platform/graphics/win/ImageCGWin.cpp:
422         (WebCore::BitmapImage::getHBITMAPOfSize):
423         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
424
425 2009-11-19  Beth Dakin  <bdakin@apple.com>
426
427         Reviewed by Darin Adler.
428
429         Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
430         color-correction work with untagged images
431
432         Image's draw(), drawPattern(), and fillWithSolidColor() functions 
433         now take a ColorSpace. A bunch of classes inherit from Image, so 
434         draw() and drawPattern() functions there must also take a 
435         ColorSpace.
436         * platform/graphics/Image.cpp:
437         (WebCore::Image::fillWithSolidColor):
438         (WebCore::Image::drawTiled):
439         * platform/graphics/Image.h:
440         * platform/graphics/BitmapImage.h:
441         * platform/graphics/GeneratedImage.cpp:
442         (WebCore::GeneratedImage::draw):
443         (WebCore::GeneratedImage::drawPattern):
444         * platform/graphics/GeneratedImage.h:
445         * platform/graphics/cg/PDFDocumentImage.cpp:
446         (WebCore::PDFDocumentImage::draw):
447         * platform/graphics/cg/PDFDocumentImage.h:
448         * svg/graphics/SVGImage.cpp:
449         (WebCore::SVGImage::draw):
450         * svg/graphics/SVGImage.h:
451
452         All of the drawImage() functions and drawTiled() functions of 
453         GraphicsContext now take a ColorSpace.
454         * platform/graphics/GraphicsContext.cpp:
455         (WebCore::GraphicsContext::drawImage):
456         (WebCore::GraphicsContext::drawTiledImage):
457         * platform/graphics/GraphicsContext.h:
458
459         This is where the actual work is done.
460         * platform/graphics/cg/ImageCG.cpp:
461         (WebCore::imageWithColorSpace): New static function that returns a 
462         copy of the given image in the given ColorSpace *IF* we should use 
463         the given ColorSpace. We will ignore the color space if the image 
464         is tagged and return 0. 
465         (WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to 
466         call imageWithColorSpace(). 
467         (WebCore::Image::drawPattern): Same.
468
469         Attempt to keep all ports building. 
470         * platform/graphics/cairo/ImageCairo.cpp:
471         (WebCore::BitmapImage::draw):
472         (WebCore::Image::drawPattern):
473         * platform/graphics/haiku/ImageHaiku.cpp:
474         (WebCore::BitmapImage::draw):
475         (WebCore::Image::drawPattern):
476         * platform/graphics/qt/ImageQt.cpp:
477         (WebCore::Image::drawPattern):
478         (WebCore::BitmapImage::draw):
479         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
480         * platform/graphics/skia/ImageSkia.cpp:
481         (WebCore::Image::drawPattern):
482         (WebCore::BitmapImage::draw):
483         (WebCore::BitmapImageSingleFrameSkia::draw):
484         * platform/graphics/wx/ImageWx.cpp:
485         (WebCore::BitmapImage::draw):
486         (WebCore::BitmapImage::drawPattern):
487
488         Callers of GraphicsContext's drawImage() and drawTiled() functions 
489         now need to send a ColorSpace.
490         * html/HTMLCanvasElement.cpp:
491         (WebCore::HTMLCanvasElement::paint):
492         * html/canvas/CanvasRenderingContext2D.cpp:
493         (WebCore::CanvasRenderingContext2D::drawImage):
494         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
495         * platform/ScrollView.cpp:
496         (WebCore::ScrollView::wheelEvent):
497         * platform/graphics/filters/FEColorMatrix.cpp:
498         (WebCore::FEColorMatrix::apply):
499         * platform/graphics/filters/FEComposite.cpp:
500         (WebCore::FEComposite::apply):
501         * platform/graphics/filters/SourceGraphic.cpp:
502         (WebCore::SourceGraphic::apply):
503         * platform/mac/ScrollbarThemeMac.mm:
504         (WebCore::ScrollbarThemeMac::paint):
505         * rendering/RenderBoxModelObject.cpp:
506         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
507         (WebCore::RenderBoxModelObject::paintNinePieceImage):
508         * rendering/RenderImage.cpp:
509         (WebCore::RenderImage::paintReplaced):
510         * rendering/RenderLayer.cpp:
511         (WebCore::RenderLayer::paintResizer):
512         * rendering/RenderListMarker.cpp:
513         (WebCore::RenderListMarker::paint):
514         * rendering/RenderSVGImage.cpp:
515         (WebCore::RenderSVGImage::paint):
516         * rendering/RenderWidget.cpp:
517         (WebCore::RenderWidget::paint):
518         * svg/graphics/SVGPaintServerPattern.cpp:
519         (WebCore::SVGPaintServerPattern::setup):
520         * svg/graphics/SVGResourceFilter.cpp:
521         (WebCore::SVGResourceFilter::applyFilter):
522         * svg/graphics/filters/SVGFEMerge.cpp:
523         (WebCore::FEMerge::apply):
524         * svg/graphics/filters/SVGFEOffset.cpp:
525         (WebCore::FEOffset::apply):
526         * svg/graphics/filters/SVGFETile.cpp:
527         (WebCore::FETile::apply):
528
529 2009-11-19  Avi Drissman  <avi@chromium.org>
530
531         Reviewed by Darin Adler.
532
533         Properly create a CGImageRef on non-PLATFORM(MAC).
534         https://bugs.webkit.org/show_bug.cgi?id=27777
535
536         * platform/graphics/cg/ImageSourceCG.cpp:
537         (WebCore::sharedBufferGetBytesAtPosition):
538         (WebCore::sharedBufferRelease):
539         (WebCore::ImageSource::setData):
540         * platform/graphics/cg/ImageSourceCG.h:
541         * platform/graphics/cg/PDFDocumentImage.cpp:
542         (WebCore::PDFDocumentImage::dataChanged):
543
544 2009-11-19  Oliver Hunt  <oliver@apple.com>
545
546         Reviewed by Dave Hyatt.
547
548         -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
549         https://bugs.webkit.org/show_bug.cgi?id=31656
550
551         Make sure we're a child of the painting root before drawing overflow features.
552
553         * manual-tests/user-drag-with-decorations.html: Added.
554         * rendering/RenderBlock.cpp:
555         (WebCore::RenderBlock::paint):
556
557 2009-11-19  Dmitry Titov  <dimich@chromium.org>
558
559         Not reviewed, attempt to fix Chromium build.
560
561         * rendering/RenderMediaControlsChromium.cpp:
562         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
563
564 2009-11-19  Rahul Kuchhal  <kuchhal@chromium.org>
565
566         Reviewed by Darin Adler.
567
568         Do not assert when a high number is used for roman numerals in lists.
569         https://bugs.webkit.org/show_bug.cgi?id=31652
570
571         Test: fast/lists/ol-start-roman.html
572
573         * rendering/RenderListMarker.cpp:
574         (WebCore::toRoman): Increase the char array size.
575
576 2009-11-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
577
578         Rubber-stamped by Oliver Hunt.
579
580         Add translatable strings to cover validationMessage, after
581         r51172. Already covered by existing test.
582
583         * platform/gtk/LocalizedStringsGtk.cpp:
584         (WebCore::validationMessageValueMissingText):
585         (WebCore::validationMessageTypeMismatchText):
586         (WebCore::validationMessagePatternMismatchText):
587         (WebCore::validationMessageTooLongText):
588         (WebCore::validationMessageRangeUnderflowText):
589         (WebCore::validationMessageRangeOverflowText):
590         (WebCore::validationMessageStepMismatchText):
591
592 2009-11-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
593
594         Reviewed by Darin Adler.
595
596         Remove HAVE(FLOAT_H) guard
597         https://bugs.webkit.org/show_bug.cgi?id=31661
598
599         WebCore has a dependency on float.h, there is
600         no need to guard float.h.
601
602         No new tests as there is no functional change.
603
604         * html/HTMLInputElement.cpp: Remove include directive
605         for float.h as it is included in MathExtras.h already.
606
607 2009-11-19  Simon Fraser  <simon.fraser@apple.com>
608
609         Reviewed by Pavel Feldman.
610
611         Instrumentation should account for painting in compositing layers
612         https://bugs.webkit.org/show_bug.cgi?id=31674
613
614         Add calls to InspectorTimelineAgent for painting into compositing layers,
615         which is not accounted for in FrameView::paintContents().
616
617         * rendering/RenderLayerBacking.cpp:
618         (WebCore::RenderLayerBacking::paintIntoLayer):
619         Avoid fetching the FrameView multiple times.
620         
621         (WebCore::inspectorTimelineAgent):
622         (WebCore::RenderLayerBacking::paintContents):
623
624 2009-11-19  Eric Carlson  <eric.carlson@apple.com>
625
626         Reviewed by Dan Bernstein.
627
628         <rdar://problem/7035231>
629         Support closed caption in <video> element
630
631         Test: media/media-captions.html
632
633         * WebCore.base.exp:
634         * accessibility/AccessibilityMediaControls.cpp:
635         (WebCore::AccessibilityMediaControl::controlTypeName):
636             Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
637
638         * css/CSSPrimitiveValueMappings.h:
639         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
640             Add MediaToggleClosedCaptionsButtonPart.
641
642         * css/CSSSelector.cpp:
643         (WebCore::CSSSelector::extractPseudoType):
644             Define and match mediaControlsToggleClosedCaptionsButton.
645
646         * css/CSSSelector.h:
647         (WebCore::CSSSelector::):
648         * css/CSSStyleSelector.cpp:
649         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
650             Define and match PseudoMediaControlsToggleClosedCaptions.
651
652         * css/CSSValueKeywords.in:
653             Define and use media-toggle-closed-captions-button.
654
655         * css/mediaControls.css:
656         * css/mediaControlsQuickTime.css:
657             Add webkit-media-controls-toggle-closed-captions-button.
658
659         * html/HTMLMediaElement.cpp:
660         (WebCore::HTMLMediaElement::HTMLMediaElement): 
661             Initialize m_closedCaptionsVisible.
662         (WebCore::HTMLMediaElement::loadInternal): 
663             Set m_closedCaptionsVisible to false.
664         (WebCore::HTMLMediaElement::hasClosedCaptions): 
665         (WebCore::HTMLMediaElement::closedCaptionsVisible): 
666         (WebCore::HTMLMediaElement::setClosedCaptionsVisible): 
667             New, captions internal methods.
668         (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): 
669         (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): 
670         (WebCore::HTMLMediaElement::webkitHasClosedCaptions): 
671             New, captions DOM API.
672
673         * html/HTMLMediaElement.h:
674         * html/HTMLMediaElement.idl:
675             Declare methods needed for captions API.
676
677         * platform/ThemeTypes.h:
678             Add MediaToggleClosedCaptionsButtonPart.
679
680         * platform/android/LocalizedStringsAndroid.cpp:
681         (WebCore::localizedMediaControlElementString):
682         (WebCore::localizedMediaControlElementHelpText):
683         (WebCore::localizedMediaTimeDescription):
684             Add empty implmentations.
685
686         * platform/graphics/MediaPlayer.cpp:
687         (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
688         (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
689             New, empty implementations of media engine closed caption functions.
690         (WebCore::MediaPlayer::hasClosedCaptions):
691         (WebCore::MediaPlayer::setClosedCaptionsVisible):
692             New, call media engine closed caption functions.
693
694         * platform/graphics/MediaPlayer.h:
695         * platform/graphics/MediaPlayerPrivate.h:
696         (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
697         (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
698             Declare new media engine methods.
699
700         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
701         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
702         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
703         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
704             New, QTKit implementation of closed caption methods.
705
706         * platform/gtk/LocalizedStringsGtk.cpp:
707         (WebCore::localizedMediaControlElementString):
708         (WebCore::localizedMediaControlElementHelpText):
709             Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
710
711         * platform/mac/WebCoreSystemInterface.h:
712         * platform/mac/WebCoreSystemInterface.mm:
713             Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
714
715         * rendering/MediaControlElements.cpp:
716         (WebCore::MediaControlInputElement::MediaControlInputElement):
717             Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
718         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
719         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
720         (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
721             New, implement the closed caption toggle button,
722
723         * rendering/MediaControlElements.h:
724             Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
725             declare MediaControlToggleClosedCaptionsButtonElement.
726
727         * rendering/RenderMedia.cpp:
728         (WebCore::RenderMedia::styleDidChange):
729         (WebCore::RenderMedia::createToggleClosedCaptionsButton):
730         (WebCore::RenderMedia::createStatusDisplay):
731         (WebCore::RenderMedia::updateControls):
732         (WebCore::RenderMedia::forwardEvent):
733         * rendering/RenderMedia.h:
734             Deal with m_toggleClosedCaptionsButton.
735
736         * rendering/RenderTheme.cpp:
737         (WebCore::RenderTheme::paint):
738             Deal with MediaToggleClosedCaptionsButtonPart.
739
740         * rendering/RenderTheme.h:
741         * rendering/RenderThemeMac.h:
742             Declare paintMediaToggleClosedCaptionsButton.
743
744         * rendering/RenderThemeMac.mm:
745         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
746             New.
747         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
748             Don't render captions toggle button unless we are using the new theme, the
749             movie has captions, and the movie is in a <video> element since we currently
750             rely on QTKit to render the captions.
751
752         * rendering/style/RenderStyleConstants.h:
753             Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
754
755 2009-11-19  Kevin Ollivier  <kevino@theolliviers.com>
756
757         wx build fix. Add missing header.
758
759         * platform/wx/LocalizedStringsWx.cpp:
760
761 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
762
763         Reviewed by Darin Adler.
764
765         https://bugs.webkit.org/show_bug.cgi?id=31634
766         Ignore realm for proxy protection spaces
767
768         Only affects WebSocket proxy authentication, cannot be tested in DRT.
769
770         * platform/network/ProtectionSpace.cpp:
771         (WebCore::operator==):
772         * platform/network/ProtectionSpaceHash.h:
773         (WebCore::ProtectionSpaceHash::hash):
774
775 2009-11-19  Olivier Goffart  <ogoffart@trolltech.com>
776
777         Reviewed by Simon Hausmann.
778
779         [Qt] Normalize signal and slot signatures.
780
781         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
782         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
783
784 2009-11-19  Alexander Pavlov  <apavlov@chromium.org>
785
786         Reviewed by Pavel Feldman.
787
788         Store cookie domains in the WebInspector object
789
790         The cookie domains have been moved from StoragePanel into WebInspector.
791         Also, the document URLs are now passed inside the WebInspector.addResource()
792         payload rather than pushed directly from InspectorController.
793         https://bugs.webkit.org/show_bug.cgi?id=31627
794
795         * inspector/InspectorController.cpp:
796         (WebCore::InspectorController::populateScriptObjects):
797         (WebCore::InspectorController::didFinishLoading):
798         * inspector/InspectorFrontend.cpp:
799         * inspector/InspectorFrontend.h:
800         * inspector/InspectorResource.cpp:
801         (WebCore::InspectorResource::createScriptObject):
802         (WebCore::InspectorResource::updateScriptObject):
803         * inspector/front-end/StoragePanel.js:
804         (WebInspector.StoragePanel.prototype.reset):
805         (WebInspector.StoragePanel.prototype.addCookieDomain):
806         * inspector/front-end/inspector.js:
807         (WebInspector.addResource):
808         (WebInspector.addCookieDomain):
809         (WebInspector.reset):
810
811 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
812
813         Reviewed by Darin Adler.
814
815         Allow custom memory allocation control for the other part of platform directory in WebCore
816         https://bugs.webkit.org/show_bug.cgi?id=31585
817
818         Inherits the following classes from FastAllocBase because these are
819         instantiated by 'new':
820
821         class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
822         class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
823         class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
824         class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
825
826         Inherits the following classes from Noncopyable because these are
827         instantiated by 'new' and no need to be copyable:
828
829         class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
830         class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
831         struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
832
833         class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
834         class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
835
836         * platform/graphics/MediaPlayerPrivate.h:
837         * platform/graphics/Path.h:
838         * platform/graphics/qt/FontPlatformData.h:
839         * platform/graphics/transforms/TransformationMatrix.h:
840         * platform/image-decoders/ImageDecoder.h:
841         * platform/network/NetworkStateNotifier.h:
842         * platform/network/ResourceRequestBase.h:
843         * platform/qt/CursorQt.cpp:
844         * platform/text/RegularExpression.h:
845
846 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
847
848         Unreviewed.
849
850         [Qt] Build fix for QtWebKit after r51172.
851
852         * platform/qt/Localizations.cpp:
853         (WebCore::validationMessageValueMissingText):
854         (WebCore::validationMessageTypeMismatchText):
855         (WebCore::validationMessagePatternMismatchText):
856         (WebCore::validationMessageTooLongText):
857         (WebCore::validationMessageRangeUnderflowText):
858         (WebCore::validationMessageRangeOverflowText):
859         (WebCore::validationMessageStepMismatchText):
860
861 2009-11-18  Dan Bernstein  <mitz@apple.com>
862
863         Reviewed by Simon Fraser.
864
865         Fixed <rdar://problem/7398987> Assertion failure in
866         RenderLayer::updateClipRects when a plug-in’s enclosing layer is
867         enclosed by a transformed layer
868
869         Tests: fast/layers/clip-rects-transformed-2.html
870                fast/layers/clip-rects-transformed.html
871
872         * rendering/RenderLayer.cpp:
873         (WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
874         that is either transformed or composited. During painting and hit
875         testing, when a transformed or composited layer is hit, it becomes the
876         new root layer, which ultimately gets passed to calculateRects().
877         (WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
878         root layer to calculateRects(), and return the bounding box of the
879         transformed rectangle.
880         (WebCore::RenderLayer::selfClipRect): Ditto.
881         * rendering/RenderLayer.h:
882
883 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
884
885         Reviewed by Kenneth Rohde Christiansen.
886
887         [Qt] Remove support for Qt v4.3 or older versions
888         https://bugs.webkit.org/show_bug.cgi?id=29469
889
890         No new tests as there is no change if compiled with 
891         Qt v4.4 or later version.
892
893         * WebCore.pro:
894         * dom/XMLTokenizerQt.cpp:
895         (WebCore::EntityResolver::resolveUndeclaredEntity):
896         (WebCore::XMLTokenizer::XMLTokenizer):
897         (WebCore::XMLTokenizer::~XMLTokenizer):
898         (WebCore::XMLTokenizer::doWrite):
899         (WebCore::XMLTokenizer::startDocument):
900         (WebCore::XMLTokenizer::parseDtd):
901         * platform/graphics/qt/FontQt.cpp:
902         * platform/graphics/qt/FontQt43.cpp: Removed.
903         * platform/graphics/qt/ImageQt.cpp:
904         * platform/network/ResourceHandleInternal.h:
905         * platform/network/qt/QNetworkReplyHandler.cpp:
906         * platform/network/qt/QNetworkReplyHandler.h:
907         * platform/network/qt/ResourceHandleQt.cpp:
908         (WebCore::ResourceHandle::start):
909         (WebCore::ResourceHandle::cancel):
910         (WebCore::ResourceHandle::loadResourceSynchronously):
911         (WebCore::ResourceHandle::setDefersLoading):
912         * platform/network/qt/ResourceRequest.h:
913         * platform/network/qt/ResourceRequestQt.cpp:
914         * platform/qt/ClipboardQt.cpp:
915         (WebCore::ClipboardQt::clearData):
916         * platform/qt/CookieJarQt.cpp:
917         (WebCore::cookieJar):
918         (WebCore::setCookies):
919         (WebCore::cookies):
920         (WebCore::cookiesEnabled):
921         * platform/qt/PlatformKeyboardEventQt.cpp:
922         (WebCore::keyIdentifierForQtKeyCode):
923         (WebCore::windowsKeyCodeForKeyEvent):
924         * platform/text/qt/TextBoundaries.cpp:
925         * platform/text/qt/TextBreakIteratorQt.cpp:
926         * plugins/qt/PluginDataQt.cpp:
927         (WebCore::PluginData::initPlugins):
928
929 2009-11-18  Michelangelo De Simone  <micdesim@gmail.com>
930
931         Reviewed by Darin Adler.
932
933         Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
934         Support for validationMessage attribute, as per HTML5 specs.
935
936         Test: fast/forms/validationMessage.html
937
938         * html/HTMLButtonElement.idl: validationMessage attribute
939         * html/HTMLFieldSetElement.idl: validationMessage attribute
940         * html/HTMLFormControlElement.cpp:
941         * html/HTMLFormControlElement.h:
942         * html/HTMLInputElement.idl: validationMessage attribute
943         * html/HTMLSelectElement.idl: validationMessage attribute
944         * html/HTMLTextAreaElement.idl: validationMessage attribute
945         * html/ValidityState.cpp: new method to retrieve pertinent localized text
946         * html/ValidityState.h:
947         * page/mac/WebCoreViewFactory.h:
948         * platform/LocalizedStrings.h:
949         * platform/android/LocalizedStringsAndroid.cpp:
950         * platform/gtk/LocalizedStringsGtk.cpp:
951         * platform/haiku/LocalizedStringsHaiku.cpp:
952         * platform/mac/LocalizedStringsMac.mm:
953         * platform/wx/LocalizedStringsWx.cpp:
954
955 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
956
957         Unreviewed.
958
959         Fix a typo. Remove the trailing semicolon
960         from an include directive after r51137.
961
962         No new tests as there is no functional change.
963
964         * platform/qt/QWebPageClient.h:
965
966 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
967
968         Unreviewed.
969
970         [Qt] Build fix for QtWebKit after r51159.
971
972         Include float.h for DBL_MANT_DIG. Not sure why this
973         is not a problem for other ports.
974
975         * html/HTMLInputElement.cpp:
976
977 2009-11-19  Roland Steiner  <rolandsteiner@chromium.org>
978
979         Reviewed by Darin Adler.
980
981         Bug 31574 -  Crashing bug when removing <ruby> element
982         (https://bugs.webkit.org/show_bug.cgi?id=31574)
983
984         Cause of the bug:
985         1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
986         2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
987         3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
988         4.) this triggers the special handling of child removal in RenderRubyRun that
989             causes it to destroy itself
990         5.) On returning from all this the renderer crashes when accessing a member
991             or virtual function on this now illegal object.
992
993         I therefore added a flag that tracks if the ruby run is being destroyed.
994         If so, avoid doing the special handling in removeChild that caused this.
995         It's not the most elegant solution, but the easiest to implement without
996         touching unrelated code. Also, it's self-documenting.
997
998         Test: fast/ruby/ruby-remove.html
999
1000         * rendering/RenderRubyRun.cpp:
1001         (WebCore::RenderRubyRun::RenderRubyRun):
1002         (WebCore::RenderRubyRun::destroy):
1003         (WebCore::RenderRubyRun::removeChild):
1004         * rendering/RenderRubyRun.h:
1005
1006 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1007
1008         Reviewed by Kenneth Rohde Christiansen.
1009
1010         [Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
1011         https://bugs.webkit.org/show_bug.cgi?id=31643
1012
1013         No new tests as there is no functional change.
1014
1015         * WebCore.pro:
1016
1017 2009-11-18  Yong Li  <yong.li@torchmobile.com>
1018
1019         Reviewed by Eric Seidel.
1020
1021         Implement TextBoundaries for WINCE port.
1022         https://bugs.webkit.org/show_bug.cgi?id=27371
1023
1024         * platform/text/wince/TextBoundariesWince.cpp: Added.
1025
1026 2009-11-18  Yong Li  <yong.li@torchmobile.com>
1027
1028         Reviewed by Eric Seidel.
1029
1030         Implement TextBreakIterator for WINCE port.
1031         https://bugs.webkit.org/show_bug.cgi?id=27371
1032
1033         * platform/text/wince/TextBreakIteratorWince.cpp: Added.
1034
1035 2009-11-18  Kent Tamura  <tkent@chromium.org>
1036
1037         Reviewed by Darin Adler.
1038
1039         Add support for ValidityState.typeMismatch for the following INPUT types:
1040           date datetime datetime-local month time week
1041         https://bugs.webkit.org/show_bug.cgi?id=31342
1042
1043         Tests: fast/forms/ValidityState-typeMismatch-date.html
1044                fast/forms/ValidityState-typeMismatch-datetime.html
1045                fast/forms/ValidityState-typeMismatch-datetimelocal.html
1046                fast/forms/ValidityState-typeMismatch-month.html
1047                fast/forms/ValidityState-typeMismatch-time.html
1048                fast/forms/ValidityState-typeMismatch-week.html
1049
1050         * html/HTMLInputElement.cpp:
1051         (WebCore::HTMLInputElement::formStringToISODateTime): Check the type
1052           validity of the specified type and string using the ISODateTime class.
1053         * html/HTMLInputElement.h:
1054         * html/ValidityState.cpp:
1055         (WebCore::ValidityState::typeMismatch): Check the type validity
1056           for date, datetime, datetime-local, month, time and week with
1057           HTMLInputElemtn::formStringToISODateTime()
1058
1059 2009-11-18  Maciej Stachowiak  <mjs@apple.com>
1060
1061         Reviewed by Oliver Hunt.
1062
1063         Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
1064         https://bugs.webkit.org/show_bug.cgi?id=31237
1065         
1066         Also speeds up Dromaeo DOM Core tests by 1.31x.
1067
1068         * bindings/js/JSNodeCustom.cpp:
1069         (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
1070         mark bit was no longer effective; instead I changed things so only a node that has no ancestors
1071         with wrappers would do marking; there should be only one in the typical case (the root of the
1072         detached subtree).
1073         * dom/Node.cpp:
1074         (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
1075         * dom/Node.h: ditto
1076
1077 2009-11-18  Darin Adler  <darin@apple.com>
1078
1079         Reviewed by Sam Weinig.
1080
1081         Get rid of the redundant strokeType and fillType data members on
1082         a GraphicsContext as well as the FillOrStrokeType enum. Use
1083         null pointers instead.
1084
1085         * platform/graphics/GraphicsContext.cpp:
1086         (WebCore::GraphicsContext::setStrokeColor): Null out the pattern
1087         and gradient.
1088         (WebCore::GraphicsContext::setFillColor): Ditto.
1089         (WebCore::GraphicsContext::setStrokePattern): Null out the graident.
1090         (WebCore::GraphicsContext::setFillPattern): Ditto.
1091         (WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
1092         (WebCore::GraphicsContext::setFillGradient): Ditto.
1093
1094         * platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
1095
1096         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1097         (WebCore::setPlatformFill): Use null checks on fillPattern and
1098         fillGraident instead of a switch statement.
1099         (WebCore::setPlatformStroke): Ditto.
1100
1101         * platform/graphics/cg/GraphicsContextCG.cpp:
1102         (WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
1103         (WebCore::GraphicsContext::applyFillPattern): Ditto.
1104         (WebCore::calculateDrawingMode): Use fillPattern and strokePattern
1105         to see if there is a pattern instead of fillType and strokeType.
1106         (WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
1107         fillPattern, and strokePattern instead of fillType and strokeType.
1108         (WebCore::GraphicsContext::fillPath): Added FIXME about color space that
1109         is used in the pattern and gradient case probably erroneously. Moved
1110         gradient code inside an if statement. Streamlined pattern code and
1111         use an if statement. No switch any more.
1112         (WebCore::GraphicsContext::strokePath): Ditto.
1113         (WebCore::GraphicsContext::fillRect): Ditto.
1114         (WebCore::GraphicsContext::strokeRect): Ditto.
1115
1116         * platform/graphics/qt/GraphicsContextQt.cpp:
1117         (WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
1118         fillGraident instead of a switch statement.
1119         (WebCore::GraphicsContext::strokePath): Ditto.
1120         (WebCore::GraphicsContext::fillRect): Ditto.
1121
1122         * platform/graphics/wince/GraphicsContextWince.cpp:
1123         (WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
1124         (WebCore::GraphicsContext::fillRect): Ditto.
1125
1126 2009-11-18  Kent Tamura  <tkent@chromium.org>
1127
1128         Reviewed by Darin Adler.
1129
1130         Support for step attribute and ValidityStae.stepMismatch for
1131         type=number and range.  stepMismatch will be false if the
1132         difference between the current value and a multiple of the step
1133         value is very small.
1134
1135         Change the behavior of RenderSlider so that it always has a value
1136         rounded to the step attribute value.
1137
1138         https://bugs.webkit.org/show_bug.cgi?id=31331
1139
1140         Tests: fast/forms/ValidityState-stepMismatch-number.html
1141                fast/forms/ValidityState-stepMismatch-range.html
1142                fast/forms/ValidityState-stepMismatch-unsupported.html
1143                fast/forms/input-step.html
1144
1145         * html/HTMLAttributeNames.in: Add "step".
1146         * html/HTMLInputElement.cpp:
1147         (WebCore::HTMLInputElement::stepMismatch):
1148         (WebCore::HTMLInputElement::getStepParameters):
1149         (WebCore::HTMLInputElement::getAllowedValueStep):
1150         * html/HTMLInputElement.h:
1151         * html/HTMLInputElement.idl: Add "step".
1152         * html/ValidityState.cpp:
1153         (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
1154         * html/ValidityState.h:
1155         * rendering/RenderSlider.cpp:
1156         (WebCore::SliderRange::SliderRange):
1157         (WebCore::SliderRange::clampValue):
1158
1159 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1160
1161         Reviewed by Darin Adler.
1162
1163         Need to ASSERT(isMainThread()) in ThreadShared methods.
1164         https://bugs.webkit.org/show_bug.cgi?id=31637
1165
1166         Added ASSERT(IsMainThread()) to all following methods:
1167         * platform/TreeShared.h:
1168         (WebCore::TreeShared::TreeShared):
1169         (WebCore::TreeShared::~TreeShared):
1170         (WebCore::TreeShared::ref):
1171         (WebCore::TreeShared::deref):
1172         (WebCore::TreeShared::setParent):
1173         (WebCore::TreeShared::parent):
1174
1175 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1176
1177         Reviewed by Eric Seidel.
1178
1179         Add plugin visibility manual test
1180
1181         https://bugs.webkit.org/show_bug.cgi?id=31542
1182
1183         * manual-tests/plugins/windowed.html:
1184         * manual-tests/plugins/windowless.html:
1185
1186 2009-11-18  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1187
1188         Reviewed by Pavel Feldman.
1189
1190         Web Inspector - remember last script displayed in Scripts panel
1191         https://bugs.webkit.org/show_bug.cgi?id=27552
1192
1193         Manual test added
1194         
1195         * inspector/front-end/ScriptsPanel.js:
1196         (WebInspector.ScriptsPanel.prototype.showScript):
1197         (WebInspector.ScriptsPanel.prototype.showResource):
1198         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
1199         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1200         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
1201         (WebInspector.ScriptsPanel.prototype._goBack):
1202         (WebInspector.ScriptsPanel.prototype._goForward):
1203         * manual-tests/inspector/remember-last-script.html: Added.
1204
1205 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1206
1207         Reviewed by Dimitri Glazkov.
1208
1209         Win chromium is slow to draw transparent texts
1210         https://bugs.webkit.org/show_bug.cgi?id=31258
1211
1212         Create bounded transparency layers instead of just clipping.
1213
1214         No new tests because this is just a performance improvement.
1215
1216         * platform/graphics/chromium/FontChromiumWin.cpp:
1217         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1218
1219 2009-11-18  Shu Chang  <Chang.Shu@nokia.com>
1220
1221         Reviewed by Eric Seidel.
1222
1223         [Qt] Add support for displaying deleteButton.
1224         https://bugs.webkit.org/show_bug.cgi?id=31560
1225
1226         Test: LayoutTests/editing/deleting/5408255.html
1227
1228         * WebCore.qrc:
1229         * platform/graphics/qt/ImageQt.cpp:
1230         (loadResourcePixmap):
1231
1232 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1233
1234         Reviewed by Eric Seidel.
1235
1236         Fix Qt build without JavaScript debugger.
1237
1238         https://bugs.webkit.org/show_bug.cgi?id=31575
1239
1240         * page/Console.idl:
1241
1242 2009-11-18  Daniel Bates  <dbates@webkit.org>
1243
1244         Reviewed by Dave Hyatt.
1245
1246         https://bugs.webkit.org/show_bug.cgi?id=24971
1247         And
1248         <rdar://problem/7138265>
1249
1250         Fixes an issue where setting the height of a table row programmatically
1251         (via JavaScript) causes the table to be improperly rendered because the
1252         height of each row in the table is not recalculated with respect to the
1253         CSS height property.
1254
1255         In particular, programmatically setting the height of some table row causes
1256         the rows of that table to be rendered with a height equal to the minimum
1257         height required by the cells in that row, regardless of any specified cell
1258         heights. Instead, when RenderTableSection::recalcCells is called, the height
1259         of each row should be set to the CSS height property just as we do in
1260         RenderTableSection::addChild.
1261
1262         Test: fast/table/row-height-recalc2.html
1263
1264         * rendering/RenderTableSection.cpp:
1265         (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
1266         (WebCore::RenderTableSection::addChild): Moved code that set row height into
1267         method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
1268         (WebCore::RenderTableSection::recalcCells): Modified to call
1269         WebCore::setRowHeightToRowStyleHeightIfNotRelative.
1270
1271 2009-11-18  Zoltan Horvath  <zoltan@webkit.org>
1272
1273         Reviewed by Darin Adler.
1274
1275         Allow custom memory allocation control for the part of platform directory in WebCore
1276         https://bugs.webkit.org/show_bug.cgi?id=31473
1277
1278         Inherits the following classes from FastAllocBase because these are
1279         instantiated by 'new':
1280
1281         class  AnimationList         - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
1282         class  Color                 - instantiated at WebCore/rendering/RenderTheme.cpp:48
1283         struct Length                - instantiated at WebCore/platform/Length.cpp:103
1284         class  PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
1285         class  ContextMenuItem       - instantiated at WebCore/platform/ContextMenu.cpp:70
1286         class  DeprecatedPtrList     - instantiated at WebCore/rendering/RenderBlock.cpp:2284
1287
1288         Inherits the following classes from Noncopyable because these are
1289         instantiated by 'new' and no need to be copyable:
1290
1291         class  GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
1292         class  FontCache              - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
1293         struct MediaPlayerFactory     - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
1294         class  DeprecatedPtrListNode  - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
1295
1296         * platform/ContextMenuItem.h:
1297         * platform/DeprecatedPtrList.h:
1298         * platform/DeprecatedPtrListImpl.cpp:
1299         * platform/Length.h:
1300         * platform/PlatformKeyboardEvent.h:
1301         * platform/animation/AnimationList.h:
1302         * platform/graphics/Color.h:
1303         * platform/graphics/FontCache.h:
1304         * platform/graphics/GraphicsContextPrivate.h:
1305         * platform/graphics/MediaPlayer.cpp:
1306
1307 2009-11-18  Daniel Bates  <dbates@webkit.org>
1308
1309         Reviewed by Darin Adler.
1310
1311         https://bugs.webkit.org/show_bug.cgi?id=31186
1312
1313         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
1314         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
1315         These are more descriptive names so as to clear an ambiguity surrounding
1316         their usage. Also, renames associated setters and getters so that they
1317         coincide with the renamed fields.
1318
1319         No functionality was changed. So, no tests were included.
1320
1321         * bindings/objc/DOMHTML.mm:
1322         (-[DOMHTMLInputElement _isEdited]):
1323         (-[DOMHTMLTextAreaElement _isEdited]):
1324         * dom/Document.cpp:
1325         (WebCore::Document::setFocusedNode):
1326         * html/HTMLInputElement.cpp:
1327         (WebCore::HTMLInputElement::defaultEventHandler):
1328         * rendering/RenderTextControl.cpp:
1329         (WebCore::RenderTextControl::RenderTextControl):
1330         (WebCore::RenderTextControl::setInnerTextValue):
1331         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
1332         (WebCore::RenderTextControl::subtreeHasChanged):
1333         * rendering/RenderTextControl.h:
1334         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
1335         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
1336         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
1337         * rendering/RenderTextControlSingleLine.cpp:
1338         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
1339         * wml/WMLInputElement.cpp:
1340         (WebCore::WMLInputElement::defaultEventHandler):
1341
1342 2009-11-18  Tony Chang  <tony@chromium.org>
1343
1344         Reviewed by Adam Barth.
1345
1346         Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
1347         https://bugs.webkit.org/show_bug.cgi?id=31499
1348
1349         No new tests, just a build cleanup.
1350
1351         * WebCore.gypi:
1352         * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
1353         * bindings/v8/custom/V8CustomBinding.h:
1354
1355 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1356
1357         Reviewed by Kevin Ollivier.
1358
1359         Enable wx plugin support using the Windows implementation as a base.
1360         
1361         https://bugs.webkit.org/show_bug.cgi?id=31636
1362
1363         * platform/graphics/GraphicsContext.h:
1364         (WebCore::GraphicsContext::inTransparencyLayer):
1365         * platform/graphics/wx/GraphicsContextWx.cpp:
1366         (WebCore::GraphicsContext::getWindowsContext):
1367         (WebCore::GraphicsContext::releaseWindowsContext):
1368         * platform/wx/FileSystemWx.cpp:
1369         (WebCore::unloadModule):
1370         (WebCore::listDirectory):
1371         * plugins/PluginDatabase.cpp:
1372         * plugins/PluginView.cpp:
1373         (WebCore::PluginView::stop):
1374         (WebCore::PluginView::PluginView):
1375         * plugins/PluginView.h:
1376         * plugins/win/PluginViewWin.cpp:
1377         (windowHandleForPageClient):
1378         (WebCore::PluginView::handleMouseEvent):
1379         (WebCore::PluginView::platformStart):
1380         (WebCore::PluginView::snapshot):
1381         * wscript:
1382
1383 2009-11-18  Andrei Popescu  <andreip@google.com>
1384
1385         Reviewed by Dimitri Glazkov.
1386
1387         [Android] Add shared timer and sound utilities to platform/android
1388         https://bugs.webkit.org/show_bug.cgi?id=31584
1389
1390         No new tests required, this is platform specific code.
1391
1392         * platform/android/SharedTimerAndroid.cpp: Added.
1393         (WebCore::setSharedTimerFiredFunction):
1394         (WebCore::setSharedTimerFireTime):
1395         (WebCore::stopSharedTimer):
1396         * platform/android/SoundAndroid.cpp: Added.
1397         (WebCore::systemBeep):
1398
1399 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1400
1401         Reviewed by Timothy Hatcher.
1402
1403         Fix profile tree nodes loss after focus / restore actions.
1404
1405         Focusing on a node is currently implemented via nodes reattaching
1406         with some caching involved. It seems that not all code was updated
1407         to handle this scenario correctly.
1408
1409         https://bugs.webkit.org/show_bug.cgi?id=31553
1410
1411         * inspector/front-end/BottomUpProfileDataGridTree.js:
1412         (WebInspector.BottomUpProfileDataGridNode):
1413         (WebInspector.BottomUpProfileDataGridNode.prototype._restore):
1414         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
1415         (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
1416         * inspector/front-end/DataGrid.js:
1417         (WebInspector.DataGrid.prototype.insertChild):
1418         (WebInspector.DataGridNode.prototype._detach):
1419         (WebInspector.DataGridNode.prototype.savePosition):
1420         (WebInspector.DataGridNode.prototype.restorePosition):
1421         * inspector/front-end/TopDownProfileDataGridTree.js:
1422         (WebInspector.TopDownProfileDataGridTree.prototype.focus):
1423         (WebInspector.TopDownProfileDataGridTree.prototype.restore):
1424
1425 2009-11-18  Carol Szabo  <carol.szabo@nokia.com>
1426
1427         Reviewed by Kenneth Rohde Christiansen.
1428
1429         [Qt] QWebPageClient.h needs in some cases QCursor, but it does not
1430         include it 
1431         https://bugs.webkit.org/show_bug.cgi?id=31527
1432
1433         No new tests as this is just a coding style fix that affects the 
1434         build of some not yet submitted patches (i.e. for bug 30173).
1435
1436         * platform/qt/QWebPageClient.h:
1437
1438 2009-11-18  Nicolas Roard   <nicolas@roard.com>
1439
1440         Reviewed by Dimitri Glazkov.
1441
1442         InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
1443         https://bugs.webkit.org/show_bug.cgi?id=31504
1444
1445         * inspector/InspectorTimelineAgent.h:Added the guard.
1446
1447 2009-11-18  Jens Alfke  <snej@chromium.org>
1448
1449         Build fix to my previous checkin, for Windows Chromium
1450
1451         * svg/SVGAnimatedProperty.h:
1452         (WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
1453
1454 2009-11-18  Joseph Pecoraro  <joepeck@webkit.org>
1455
1456         Reviewed by Pavel Feldman.
1457
1458         Web Inspector: Directly Access <head> Instead of Searching for It
1459         https://bugs.webkit.org/show_bug.cgi?id=31641
1460         
1461         Changed old access of the head element (document.getElementsByTagName)
1462         to just use the document.head accessor.
1463
1464         * inspector/front-end/FontView.js:
1465         (WebInspector.FontView):
1466         * inspector/front-end/InjectedScript.js:
1467         (InjectedScript.addStyleSelector):
1468         * inspector/front-end/SourceFrame.js:
1469         (WebInspector.SourceFrame.prototype._loaded):
1470         * inspector/front-end/inspector.js:
1471         (windowLoaded):
1472
1473 2009-11-18  Sam Weinig  <sam@webkit.org>
1474
1475         Reviewed by Anders Carlsson.
1476
1477         Fix two Geolocation assertions.
1478
1479         * page/Chrome.cpp:
1480         (WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
1481         is not called from JS. 
1482         * page/Geolocation.cpp:
1483         (WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
1484         a RefPtr first.
1485
1486 2009-11-18  Alexey Proskuryakov  <ap@apple.com>
1487
1488         Case sensitive file system build fix.
1489
1490         * platform/network/Credential.h: It's not WTF, just wtf.
1491
1492 2009-11-18  Aaron Golden  <agolden@apple.com>
1493
1494         Reviewed by Alexey Proskuryakov.
1495
1496         Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
1497         objects and WebCore::Credential objects without losing certificate information.
1498
1499         * platform/network/Credential.cpp:
1500         (WebCore::Credential::Credential):  Adding a constructor that takes an identity argument and a certificate chain argument
1501         (WebCore::Credential::isEmpty):  Modifying isEmpty to support certificate based credentials (which don't have a username or password)
1502         (WebCore::Credential::identity): Accessor for the m_identity property
1503         (WebCore::Credential::certificates): Accessor for the m_certificates property
1504         (WebCore::Credential::type):  Accessor for the m_type property
1505         (WebCore::operator==):  Modifying == to compare the identity and certificate chains of certificate based credentials.
1506         * platform/network/Credential.h:  Adding new fields to WebCore::Credential to support certificate based credentials.
1507         * platform/network/mac/AuthenticationMac.mm:
1508         (WebCore::mac):  Modifying the mac() conversion method to correctly convert certificate based WebCore::Credential objects.
1509         (WebCore::core):  Modifying the core() conversion method to correctly convert certificate based NSURLCredential objects.
1510
1511 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1512
1513         Reviewed by Eric Seidel.
1514
1515         Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
1516         https://bugs.webkit.org/show_bug.cgi?id=31615
1517
1518         * dom/Document.cpp:
1519         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
1520         (WebCore::ScriptExecutionContextTaskTimer::fired):
1521         (WebCore::PerformTaskContext::PerformTaskContext):
1522         (WebCore::performTask):
1523         (WebCore::Document::postTask):
1524         * dom/ScriptExecutionContext.cpp:
1525         * dom/ScriptExecutionContext.h:
1526
1527 2009-11-18  Jens Alfke  <snej@chromium.org>
1528
1529         Reviewed by Darin Adler.
1530
1531         Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
1532         by causing the right v8-to-WebCore conversion function to be called for every parameter.
1533         This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
1534         To enforce correctness, I added a mode that disables implicit
1535         String-->AtomicString conversions while compiling the generated bindings.
1536         https://bugs.webkit.org/show_bug.cgi?id=31168
1537
1538         * bindings/scripts/CodeGeneratorV8.pm:  Generate usage of V8Parameter class.
1539         * bindings/v8/DerivedSourcesAllInOne.cpp:  Enable NO_IMPLICIT_ATOMICSTRING.
1540         * bindings/v8/V8Binding.h:  Add V8Parameter class.
1541         * css/WebKitCSSKeyframesRule.h:  Make AtomicString conversions explicit.
1542         * dom/Document.idl:  Remove obsolete [HintAtomic] annotation.
1543         * platform/text/AtomicString.h:  Added NO_IMPLICIT_ATOMICSTRING option.
1544         * svg/SVGAnimatedTemplate.h:  Change some return types to String to avoid implicit conversion.
1545         * svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
1546
1547 2009-11-18  Darin Adler  <darin@apple.com>
1548
1549         Reviewed by Dan Bernstein.
1550
1551         Move FillOrStrokeType out of public header.
1552
1553         * platform/graphics/GraphicsContext.h: Updated copyright date to cover
1554         some years we published Apple changes, sorted forward declarations,
1555         removed FillOrStrokeType enum.
1556         * platform/graphics/GraphicsContextPrivate.h: Updated copyright date
1557         to cover some years we published Apple changes, sorted includes,
1558         moved FillOrStrokeType enum here.
1559
1560 2009-11-18  Chris Marrin  <cmarrin@apple.com>
1561
1562         Reviewed by Simon Fraser.
1563
1564         Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
1565         https://bugs.webkit.org/show_bug.cgi?id=31601
1566
1567         These are used to debug accelerated compositing layers. I removed
1568         the platform specific code from GraphicsLayerCA.mm and added calls
1569         to GraphicsLayerClient to get it from the higher levels. The values 
1570         now get cached in RenderLayerCompositing and are queried from there
1571         by RenderLayerBacking (which implements the GraphicsLayerClient interface).
1572
1573         * WebCore.base.exp:
1574         * page/FrameView.cpp:
1575         (WebCore::FrameView::updateCompositingLayers):
1576         * page/Settings.cpp:
1577         (WebCore::Settings::Settings):
1578         (WebCore::Settings::setShowDebugBorders):
1579         (WebCore::Settings::setShowRepaintCounter):
1580         * page/Settings.h:
1581         (WebCore::Settings::showDebugBorders):
1582         (WebCore::Settings::showRepaintCounter):
1583         * platform/graphics/GraphicsLayer.h:
1584         (WebCore::GraphicsLayer::showDebugBorders):
1585         (WebCore::GraphicsLayer::showRepaintCounter):
1586         * platform/graphics/GraphicsLayerClient.h:
1587         * platform/graphics/mac/GraphicsLayerCA.mm:
1588         * rendering/RenderLayerBacking.cpp:
1589         (WebCore::RenderLayerBacking::showDebugBorders):
1590         (WebCore::RenderLayerBacking::showRepaintCounter):
1591         * rendering/RenderLayerBacking.h:
1592         * rendering/RenderLayerCompositor.cpp:
1593         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
1594         (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
1595         * rendering/RenderLayerCompositor.h:
1596         (WebCore::RenderLayerCompositor::showDebugBorders):
1597         (WebCore::RenderLayerCompositor::showRepaintCounter):
1598
1599 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1600
1601         Reviewed by Timothy Hatcher.
1602
1603         Web Inspector: Get rid of metrics and properties sidebars'
1604         flickering.
1605
1606         https://bugs.webkit.org/show_bug.cgi?id=31629
1607
1608         * inspector/front-end/MetricsSidebarPane.js:
1609         * inspector/front-end/PropertiesSidebarPane.js:
1610
1611 2009-11-17  Brian Weinstein  <bweinstein@apple.com>
1612
1613         Reviewed by Pavel Feldman.
1614
1615         Fixes <http://webkit.org/b/31606>.
1616         Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
1617         
1618         This implements Enter starting editing mode in an editable DataGrid. If the
1619         DataGrid is editable and the user hits return, startEditing the first child
1620         of the selected node. Also refactored some editing functions to take an 
1621         event target instead of the event itself, because the functions only needed
1622         the target. Lastly, added had return in editing mode stop propogation, because
1623         when enter was hit to confirm text, it would propagate back to the datagrid
1624         and try to start editing again.
1625
1626         * inspector/front-end/DataGrid.js:
1627         (WebInspector.DataGrid.prototype._ondblclick):
1628         (WebInspector.DataGrid.prototype._startEditing):
1629         (WebInspector.DataGrid.prototype.handleKeyEvent):
1630         (WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
1631         (WebInspector.DataGrid.prototype._mouseDownInDataTable):
1632         (WebInspector.DataGrid.prototype._clickInDataTable):
1633         * inspector/front-end/inspector.js:
1634         (WebInspector.startEditing.element.handleKeyEvent):
1635         (WebInspector.startEditing):
1636
1637 2009-11-18  Ben Murdoch  <benm@google.com>
1638
1639         Reviewed by Darin Adler.
1640
1641         HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
1642         https://bugs.webkit.org/show_bug.cgi?id=31593
1643
1644         Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
1645
1646         * html/HTMLAnchorElement.cpp:
1647         (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
1648
1649 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1650
1651         Not reviewed. Touch InspectorController so that frontend
1652         JS files are deployed on Windows.
1653
1654         * inspector/InspectorController.cpp:
1655
1656 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1657
1658         Reviewed by Timothy Hatcher.
1659
1660         Web Inspector: clone timeline records array instead of
1661         copying reference on invalidate all.
1662
1663         https://bugs.webkit.org/show_bug.cgi?id=31596
1664
1665         * inspector/front-end/AbstractTimelinePanel.js:
1666         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
1667
1668 2009-11-18  Simon Fraser  <simon.fraser@apple.com>
1669
1670         Reviewed by Dan Bernstein.
1671
1672         Elements don't drop out of compositing layers when animation ends
1673         https://bugs.webkit.org/show_bug.cgi?id=31613
1674         <rdar://problem/7402913>
1675
1676         Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
1677         are compositing anyway for other reasons. Doing so can cause those layers
1678         to stay in compositing mode even after animations finish, because needsToBeComposited()
1679         continues to return true.
1680         
1681         No new tests because it's not possible to determine which elements are in
1682         compositing layers from DRT output.
1683
1684         * rendering/RenderLayerCompositor.cpp:
1685         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
1686
1687 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1688
1689         Reviewed by Tor Arne Vestbø.
1690
1691         [Qt] Mac Plugins: Remove null timer
1692         
1693         A null timer was used to send mouse move events. Instead, we now use
1694         move events to send nullEvent. This brings down CPU usage by 20-30%.
1695         
1696         https://bugs.webkit.org/show_bug.cgi?id=31624
1697
1698         * plugins/PluginView.h:
1699         * plugins/mac/PluginViewMac.cpp:
1700         (WebCore::PluginView::platformStart):
1701         (WebCore::PluginView::handleMouseEvent):
1702
1703 2009-11-18  Benjamin Poulain  <benjamin.poulain@nokia.com>
1704
1705         Reviewed by Simon Hausmann.
1706
1707         [Qt] WebKit crashes when loading certain SVG images
1708
1709         Check if the familly exist before creating the PlatformData from it.
1710
1711         https://bugs.webkit.org/show_bug.cgi?id=29443
1712
1713         Test: svg/text/text-font-invalid.html
1714
1715         * platform/graphics/qt/FontFallbackListQt.cpp:
1716         (WebCore::FontFallbackList::fontDataAt):
1717
1718 2009-11-17  Nicolas Weber  <thakis@chromium.org>
1719
1720         Reviewed by Darin Fisher.
1721
1722         Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
1723         after navigation.
1724         https://bugs.webkit.org/show_bug.cgi?id=31609
1725
1726         * platform/chromium/PopupMenuChromium.cpp:
1727         (WebCore::PopupContainer::showExternal): Set parent for external
1728         dropdowns, so that |PopupListBox::hidePopup()| can successfully notify
1729         its parent's client.
1730
1731 2009-11-17  Hayato Ito  <hayato@google.com>
1732
1733         Reviewed by Darin Adler.
1734
1735         Avoid infinite mutual recursion when deeply nested tags are loaded
1736         https://bugs.webkit.org/show_bug.cgi?id=30651
1737
1738         Test: fast/parser/block-nesting-cap-table.html
1739
1740         * html/HTMLParser.cpp:
1741         (WebCore::HTMLParser::parseToken):
1742         (WebCore::tagPriorityOfNode):
1743         (WebCore::HTMLParser::limitBlockDepth):
1744         (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth):
1745         (WebCore::HTMLParser::insertNode):
1746         * html/HTMLParser.h:
1747
1748 2009-11-17  Brent Fulgham  <bfulgham@webkit.org>
1749
1750         Rubber-stamped by Alexey Proskuryakov.
1751
1752         Final clean-ups for minor coding standard violations.
1753         https://bugs.webkit.org/show_bug.cgi?id=26102.
1754
1755         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1756
1757 2009-11-17  Johnny Ding  <jnd@chromium.org>
1758
1759         Reviewed by Darin Adler.
1760
1761         In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
1762         https://bugs.webkit.org/show_bug.cgi?id=31567
1763
1764         * dom/ScriptElement.cpp:
1765         (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
1766
1767 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1768
1769         Reviewed by Timothy Hatcher.
1770
1771         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1772         - Updated DRT to show/close inspector for all tests under /inspector
1773         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1774           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1775         - Removed reload on each inspector test
1776         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1777         inspector for those.
1778         - Reimplemented timeline tests in order to get rid of reload there.
1779         - Moved tests that don't require harness into the fast group.
1780
1781         https://bugs.webkit.org/show_bug.cgi?id=31472
1782
1783         * WebCore.Inspector.exp:
1784         * inspector/front-end/TimelinePanel.js:
1785         (WebInspector.TimelinePanel.prototype._formatRecord):
1786
1787 2009-11-17  Andrei Popescu  <andreip@google.com>
1788
1789         Reviewed by Dimitri Glazkov.
1790
1791         [Android] Android is missing the implementation of the GeolocationService iface.
1792         https://bugs.webkit.org/show_bug.cgi?id=31554
1793
1794         No new tests required as this is platform specific code.
1795
1796         * platform/android/GeolocationServiceAndroid.cpp: Added.
1797         (WebCore::GeolocationServiceAndroid::create):
1798         (WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
1799         (WebCore::GeolocationServiceAndroid::startUpdating):
1800         (WebCore::GeolocationServiceAndroid::stopUpdating):
1801         (WebCore::GeolocationServiceAndroid::suspend):
1802         (WebCore::GeolocationServiceAndroid::resume):
1803         (WebCore::GeolocationServiceAndroid::newPositionAvailable):
1804         (WebCore::GeolocationServiceAndroid::newErrorAvailable):
1805         (WebCore::GeolocationServiceAndroid::timerFired):
1806         (WebCore::GeolocationServiceAndroid::isPositionMovement):
1807         (WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
1808         (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
1809         * platform/android/GeolocationServiceAndroid.h: Added.
1810         (WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
1811         (WebCore::GeolocationServiceAndroid::lastPosition):
1812         (WebCore::GeolocationServiceAndroid::lastError):
1813         * platform/android/GeolocationServiceBridge.cpp: Added.
1814         (WebCore::):
1815         (WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
1816         (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
1817         (WebCore::GeolocationServiceBridge::start):
1818         (WebCore::GeolocationServiceBridge::stop):
1819         (WebCore::GeolocationServiceBridge::setEnableGps):
1820         (WebCore::GeolocationServiceBridge::newLocationAvailable):
1821         (WebCore::GeolocationServiceBridge::newErrorAvailable):
1822         (WebCore::GeolocationServiceBridge::toGeoposition):
1823         (WebCore::GeolocationServiceBridge::startJavaImplementation):
1824         (WebCore::GeolocationServiceBridge::stopJavaImplementation):
1825         * platform/android/GeolocationServiceBridge.h: Added.
1826
1827 2009-11-16  Kent Tamura  <tkent@chromium.org>
1828
1829         Unreviewd build fix.
1830
1831         - Fix typo in WebCore.vcproj.
1832         - Intlude limits.h for INT_MAX.
1833         - Enclose with parenthesis to suspress warning.
1834
1835         * WebCore.vcproj/WebCore.vcproj:
1836         * html/ISODateTime.cpp:
1837         (WebCore::ISODateTime::addDay):
1838
1839 2009-11-16  Robin Dunn  <robin@alldunn.com>
1840
1841         Reviewed by Kevin Ollivier.
1842
1843         Make sure wx scrollbar drawing code factors in transforms when switching backends,
1844         fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
1845         
1846         https://bugs.webkit.org/show_bug.cgi?id=31570
1847
1848         * platform/wx/ScrollbarThemeWx.cpp:
1849         (WebCore::ScrollbarThemeWx::minimumThumbLength):
1850         (WebCore::ScrollbarThemeWx::splitTrack):
1851         (WebCore::ScrollbarThemeWx::forwardButtonRect):
1852         * platform/wx/ScrollbarThemeWx.h:
1853         * platform/wx/wxcode/gtk/scrollbar_render.cpp:
1854         (wxRenderer_DrawScrollbar):
1855         * platform/wx/wxcode/scrollbar_render.h:
1856         (calcThumbStartAndLength):
1857         * platform/wx/wxcode/win/scrollbar_render.cpp:
1858         (wxRenderer_DrawScrollbar):
1859
1860 2009-11-16  Kent Tamura  <tkent@chromium.org>
1861
1862         Reviewed by David Levin.
1863
1864         Introduce WebCore::ISODateTime class.
1865         https://bugs.webkit.org/show_bug.cgi?id=31340
1866
1867         This class represents a value of date/time types of the HTML5 INPUT
1868         element, and has some parsing methods for ISO 8601.
1869
1870         This change has no tests because the class is not used yet.
1871
1872         * GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
1873         * WebCore.gypi: ditto.
1874         * WebCore.pro: ditto.
1875         * WebCore.vcproj/WebCore.vcproj: ditto.
1876         * WebCore.xcodeproj/project.pbxproj: ditto.
1877         * WebCoreSources.bkl: ditto.
1878         * html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class.
1879         (WebCore::isLeapYear):
1880         (WebCore::maxDayOfMonth):
1881         (WebCore::dayOfWeek):
1882         (WebCore::ISODateTime::maxWeekNumberInYear):
1883         (WebCore::countDigits):
1884         (WebCore::toInt):
1885         (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek().
1886         (WebCore::ISODateTime::addDay): Private helper for parseTimeZone().
1887         (WebCore::ISODateTime::addMinute): ditto.
1888         (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime().
1889         (WebCore::ISODateTime::parseMonth): Parser for <input type=month>.
1890         (WebCore::ISODateTime::parseDate): Parser for <input type=date>.
1891         (WebCore::ISODateTime::parseWeek): Parser for <input type=week>.
1892         (WebCore::ISODateTime::parseTime): Parser for <input type=time>.
1893         (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>.
1894         (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
1895         * html/ISODateTime.h: Added.  Declare WebCore::ISODateTime class.
1896         (WebCore::ISODateTime::ISODateTime):
1897         (WebCore::ISODateTime::millisecond):
1898         (WebCore::ISODateTime::second):
1899         (WebCore::ISODateTime::minute):
1900         (WebCore::ISODateTime::hour):
1901         (WebCore::ISODateTime::monthDay):
1902         (WebCore::ISODateTime::month):
1903         (WebCore::ISODateTime::fullYear):
1904         (WebCore::ISODateTime::week):
1905
1906 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1907
1908         Fix a typo in previous commit.
1909
1910         * platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
1911
1912 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1913
1914         Fix a typo in previous commit.
1915
1916         * platform/network/cf/SocketStreamHandleCFNet.cpp:
1917
1918 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1919
1920         Tiger build fix.
1921
1922         * platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named
1923         differently in Tiger CFNetwork.
1924
1925 2009-11-16  Dimitri Glazkov  <dglazkov@chromium.org>
1926
1927         Reviewed by Darin Fisher.
1928
1929         [KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
1930
1931         Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
1932
1933         Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1934
1935         * platform/KURLGoogle.cpp:
1936         (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
1937
1938 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1939
1940         Rubber-stamped by Jon Honeycutt.
1941
1942         A better Windows build fix
1943
1944         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
1945         Use a macro that inserts __declspec(dllimport) when appropriate for CFNetwork imports.
1946
1947 2009-11-16  Yael Aharon  <yael.aharon@nokia.com>
1948
1949         Reviewed by Darin Adler.
1950
1951         Rename protocolIsValid to isValidProtocol.
1952         https://bugs.webkit.org/show_bug.cgi?id=31503
1953
1954         This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
1955
1956         No new tests since no new functionality was introduced.
1957
1958         * html/HTMLAnchorElement.cpp:
1959         (WebCore::HTMLAnchorElement::setProtocol):
1960         * platform/KURL.cpp:
1961         (WebCore::isValidProtocol):
1962         * platform/KURL.h:
1963         * platform/KURLGoogle.cpp:
1964         (WebCore::isValidProtocol):
1965
1966 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1967
1968         Reviewed by Beth Dakin.
1969
1970         AX: aria-labelledby duplicates some of its WAI-ARIA label
1971         https://bugs.webkit.org/show_bug.cgi?id=31565
1972
1973         Test: accessibility/aria-labelledby-overrides-label.html
1974
1975         * accessibility/AccessibilityRenderObject.cpp:
1976         (WebCore::AccessibilityRenderObject::hasTextAlternative):
1977         (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
1978         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1979         * accessibility/AccessibilityRenderObject.h:
1980
1981 2009-11-16  Nate Chapin  <japhet@chromium.org>
1982
1983         Reviewed by Darin Fisher.
1984
1985         Handle the case of a null NPObject* in NPN_SetException in
1986         the V8 bindings.  This allow out of process plugins calling
1987         NPN_SetException to just send null instead of sending an
1988         NPObject* that would be an address in a different 
1989         process's memory space.
1990
1991         https://bugs.webkit.org/show_bug.cgi?id=31561
1992
1993         * bindings/v8/NPV8Object.cpp:
1994         (_NPN_SetException): Allow null NPObject* and just throw a general error.
1995
1996 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1997
1998         Windows build fix.
1999
2000         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2001         Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
2002
2003 2009-11-14  Yael Aharon  <yael.aharon@nokia.com>
2004
2005         Reviewed by Kenneth Rohde Christiansen.
2006
2007         [Qt] ASSERT failure while running DRT
2008         https://bugs.webkit.org/show_bug.cgi?id=30978
2009
2010         Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
2011         These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
2012
2013         * bridge/qt/qt_instance.cpp:
2014         (JSC::Bindings::QtRuntimeObjectImp::createStructure):
2015         * bridge/qt/qt_runtime.h:
2016         (JSC::Bindings::QtRuntimeMethod::createStructure):
2017
2018 2009-11-16  Mark Rowe  <mrowe@apple.com>
2019
2020         Attempt to fix the build.  Land a file that was missing from r51049.
2021
2022         * bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
2023         (WebCore::setWebGLArrayFromArray):
2024
2025 2009-11-16  Kenneth Russell  <kbr@google.com>
2026
2027         Reviewed by Oliver Hunt.
2028
2029         Update API of WebGLArray and friends
2030         https://bugs.webkit.org/show_bug.cgi?id=31175
2031
2032         * bindings/js/JSWebGLArrayCustom.cpp:
2033         (WebCore::toJS):
2034         * bindings/js/JSWebGLArrayHelper.h: Added.
2035         (WebCore::setWebGLArrayFromArray):
2036         * bindings/js/JSWebGLByteArrayCustom.cpp:
2037         (WebCore::JSWebGLByteArray::set):
2038         * bindings/js/JSWebGLFloatArrayCustom.cpp:
2039         (WebCore::JSWebGLFloatArray::set):
2040         * bindings/js/JSWebGLIntArrayCustom.cpp:
2041         (WebCore::JSWebGLIntArray::set):
2042         * bindings/js/JSWebGLShortArrayCustom.cpp:
2043         (WebCore::JSWebGLShortArray::set):
2044         * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
2045         (WebCore::JSWebGLUnsignedByteArray::set):
2046         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
2047         (WebCore::JSWebGLUnsignedIntArray::set):
2048         * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
2049         (WebCore::JSWebGLUnsignedShortArray::set):
2050         * bindings/scripts/CodeGeneratorV8.pm:
2051         * bindings/v8/V8DOMWrapper.cpp:
2052         (WebCore::V8DOMWrapper::convertToV8Object):
2053         * bindings/v8/custom/V8CustomBinding.h:
2054         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2055         (WebCore::CALLBACK_FUNC_DECL):
2056         * bindings/v8/custom/V8WebGLArrayCustom.h:
2057         (WebCore::constructWebGLArray):
2058         (WebCore::getWebGLArrayElement):
2059         (WebCore::setWebGLArrayFromArray):
2060         (WebCore::setWebGLArray):
2061         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2062         (WebCore::CALLBACK_FUNC_DECL):
2063         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2064         (WebCore::CALLBACK_FUNC_DECL):
2065         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2066         (WebCore::CALLBACK_FUNC_DECL):
2067         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2068         (WebCore::CALLBACK_FUNC_DECL):
2069         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2070         (WebCore::CALLBACK_FUNC_DECL):
2071         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2072         (WebCore::CALLBACK_FUNC_DECL):
2073         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2074         (WebCore::CALLBACK_FUNC_DECL):
2075         * html/canvas/WebGLArray.cpp:
2076         (WebCore::WebGLArray::WebGLArray):
2077         (WebCore::WebGLArray::~WebGLArray):
2078         (WebCore::WebGLArray::setImpl):
2079         * html/canvas/WebGLArray.h:
2080         (WebCore::WebGLArray::isByteArray):
2081         (WebCore::WebGLArray::isUnsignedByteArray):
2082         (WebCore::WebGLArray::isShortArray):
2083         (WebCore::WebGLArray::isUnsignedShortArray):
2084         (WebCore::WebGLArray::isIntArray):
2085         (WebCore::WebGLArray::isUnsignedIntArray):
2086         (WebCore::WebGLArray::isFloatArray):
2087         (WebCore::WebGLArray::buffer):
2088         (WebCore::WebGLArray::baseAddress):
2089         (WebCore::WebGLArray::byteOffset):
2090         * html/canvas/WebGLArray.idl:
2091         * html/canvas/WebGLArrayBuffer.cpp:
2092         (WebCore::WebGLArrayBuffer::create):
2093         (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
2094         (WebCore::WebGLArrayBuffer::data):
2095         (WebCore::WebGLArrayBuffer::byteLength):
2096         (WebCore::WebGLArrayBuffer::~WebGLArrayBuffer):
2097         * html/canvas/WebGLArrayBuffer.h:
2098         * html/canvas/WebGLByteArray.cpp:
2099         (WebCore::WebGLByteArray::create):
2100         (WebCore::WebGLByteArray::byteLength):
2101         (WebCore::WebGLByteArray::slice):
2102         (WebCore::WebGLByteArray::set):
2103         * html/canvas/WebGLByteArray.h:
2104         (WebCore::WebGLByteArray::isByteArray):
2105         (WebCore::WebGLByteArray::data):
2106         (WebCore::WebGLByteArray::set):
2107         (WebCore::WebGLByteArray::get):
2108         (WebCore::WebGLByteArray::item):
2109         * html/canvas/WebGLByteArray.idl:
2110         * html/canvas/WebGLFloatArray.cpp:
2111         (WebCore::WebGLFloatArray::create):
2112         (WebCore::WebGLFloatArray::WebGLFloatArray):
2113         (WebCore::WebGLFloatArray::length):
2114         (WebCore::WebGLFloatArray::byteLength):
2115         (WebCore::WebGLFloatArray::slice):
2116         (WebCore::WebGLFloatArray::set):
2117         * html/canvas/WebGLFloatArray.h:
2118         (WebCore::WebGLFloatArray::isFloatArray):
2119         (WebCore::WebGLFloatArray::data):
2120         (WebCore::WebGLFloatArray::set):
2121         (WebCore::WebGLFloatArray::get):
2122         (WebCore::WebGLFloatArray::item):
2123         * html/canvas/WebGLFloatArray.idl:
2124         * html/canvas/WebGLIntArray.cpp:
2125         (WebCore::WebGLIntArray::create):
2126         (WebCore::WebGLIntArray::WebGLIntArray):
2127         (WebCore::WebGLIntArray::length):
2128         (WebCore::WebGLIntArray::byteLength):
2129         (WebCore::WebGLIntArray::slice):
2130         (WebCore::WebGLIntArray::set):
2131         * html/canvas/WebGLIntArray.h:
2132         (WebCore::WebGLIntArray::isIntArray):
2133         (WebCore::WebGLIntArray::data):
2134         (WebCore::WebGLIntArray::set):
2135         (WebCore::WebGLIntArray::get):
2136         (WebCore::WebGLIntArray::item):
2137         * html/canvas/WebGLIntArray.idl:
2138         * html/canvas/WebGLShortArray.cpp:
2139         (WebCore::WebGLShortArray::create):
2140         (WebCore::WebGLShortArray::WebGLShortArray):
2141         (WebCore::WebGLShortArray::length):
2142         (WebCore::WebGLShortArray::byteLength):
2143         (WebCore::WebGLShortArray::slice):
2144         (WebCore::WebGLShortArray::set):
2145         * html/canvas/WebGLShortArray.h:
2146         (WebCore::WebGLShortArray::isShortArray):
2147         (WebCore::WebGLShortArray::data):
2148         (WebCore::WebGLShortArray::set):
2149         (WebCore::WebGLShortArray::get):
2150         (WebCore::WebGLShortArray::item):
2151         * html/canvas/WebGLShortArray.idl:
2152         * html/canvas/WebGLUnsignedByteArray.cpp:
2153         (WebCore::WebGLUnsignedByteArray::create):
2154         (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
2155         (WebCore::WebGLUnsignedByteArray::length):
2156         (WebCore::WebGLUnsignedByteArray::byteLength):
2157         (WebCore::WebGLUnsignedByteArray::slice):
2158         (WebCore::WebGLUnsignedByteArray::set):
2159         * html/canvas/WebGLUnsignedByteArray.h:
2160         (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
2161         (WebCore::WebGLUnsignedByteArray::data):
2162         (WebCore::WebGLUnsignedByteArray::set):
2163         (WebCore::WebGLUnsignedByteArray::get):
2164         (WebCore::WebGLUnsignedByteArray::item):
2165         * html/canvas/WebGLUnsignedByteArray.idl:
2166         * html/canvas/WebGLUnsignedIntArray.cpp:
2167         (WebCore::WebGLUnsignedIntArray::create):
2168         (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
2169         (WebCore::WebGLUnsignedIntArray::length):
2170         (WebCore::WebGLUnsignedIntArray::byteLength):
2171         (WebCore::WebGLUnsignedIntArray::slice):
2172         (WebCore::WebGLUnsignedIntArray::set):
2173         * html/canvas/WebGLUnsignedIntArray.h:
2174         (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
2175         (WebCore::WebGLUnsignedIntArray::data):
2176         (WebCore::WebGLUnsignedIntArray::set):
2177         (WebCore::WebGLUnsignedIntArray::get):
2178         (WebCore::WebGLUnsignedIntArray::item):
2179         * html/canvas/WebGLUnsignedIntArray.idl:
2180         * html/canvas/WebGLUnsignedShortArray.cpp:
2181         (WebCore::WebGLUnsignedShortArray::create):
2182         (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
2183         (WebCore::WebGLUnsignedShortArray::length):
2184         (WebCore::WebGLUnsignedShortArray::byteLength):
2185         (WebCore::WebGLUnsignedShortArray::slice):
2186         (WebCore::WebGLUnsignedShortArray::set):
2187         * html/canvas/WebGLUnsignedShortArray.h:
2188         (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
2189         (WebCore::WebGLUnsignedShortArray::data):
2190         (WebCore::WebGLUnsignedShortArray::set):
2191         (WebCore::WebGLUnsignedShortArray::get):
2192         (WebCore::WebGLUnsignedShortArray::item):
2193         * html/canvas/WebGLUnsignedShortArray.idl:
2194         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2195         (WebCore::GraphicsContext3D::bufferData):
2196         (WebCore::GraphicsContext3D::bufferSubData):
2197
2198 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2199
2200         Windows build fix.
2201
2202         * platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
2203
2204 2009-11-15  Brent Fulgham  <bfulgham@webkit.org>
2205
2206         Reviewed by Oliver Hunt.
2207
2208         Enable support for webkit-box-shadow in Cairo builds.
2209         https://bugs.webkit.org/show_bug.cgi?id=26102.
2210
2211         Covered by existing fast/box-shadow tests.
2212
2213         * platform/graphics/cairo/GraphicsContextCairo.cpp:  Add
2214           support for fillRect shadows.
2215
2216 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2217
2218         Windows build fix.
2219
2220         * platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not
2221         in WebKitSupportLibrary.
2222
2223 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2224
2225         Reviewed by Darin Adler.
2226
2227         https://bugs.webkit.org/show_bug.cgi?id=31494
2228         Add unauthenticated proxy support to SocketStreamHandleCFNet
2229
2230         Cannot be tested in DRT.
2231
2232         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2233         (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS.
2234         (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
2235
2236 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2237
2238         Reviewed by Antti Koivisto.
2239
2240         [Qt] Broken back/forward after using ErrorPageExtension to set error page
2241         https://bugs.webkit.org/show_bug.cgi?id=30573
2242
2243         Make FrameLoader::checkLoadCompleteForThisFrame method
2244         to check for any working DocumentLoader instance (through
2245         activeDocumentLoader()) instead of only checking for
2246         'm_provisionalDocumentLoader' in order to decide to if
2247         it is going to reset of not the back and forward history.
2248         after an error page has been loaded.
2249
2250         Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
2251
2252         * loader/FrameLoader.cpp:
2253         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2254
2255 2009-11-14  Chris Fleizach  <cfleizach@apple.com>
2256
2257         Reviewed by Darin Adler.
2258
2259         Need to implement ARIA role="directory"
2260         https://bugs.webkit.org/show_bug.cgi?id=31516
2261
2262         Test: platform/mac/accessibility/aria-directory.html
2263
2264         * accessibility/AXObjectCache.cpp:
2265         (WebCore::AXObjectCache::getOrCreate):
2266         * accessibility/AccessibilityList.cpp:
2267         (WebCore::AccessibilityList::isOrderedList):
2268         * accessibility/AccessibilityRenderObject.cpp:
2269         (WebCore::createARIARoleMap):
2270
2271 2009-11-15  Dave Tapuska  <dtapuska@rim.com>
2272
2273         Reviewed by George Staikos.
2274         
2275         Compare UChars single unit at a time as opposed to the uint32_t
2276         approach as casting to unaligned addresses may cause a bus failure
2277         on ARMv5 and below. This change replicates the same defines that
2278         exists in AtomicString.cpp
2279
2280         https://bugs.webkit.org/show_bug.cgi?id=31475
2281         
2282         * platform/text/StringHash.h:
2283         (WebCore::StringHash::equal):
2284
2285 2009-11-15  Evan Martin  <evan@chromium.org>
2286
2287         Reviewed by Adam Barth.
2288
2289         Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
2290
2291         https://bugs.webkit.org/show_bug.cgi?id=31490
2292
2293         * bindings/v8/V8DOMWrapper.cpp:
2294
2295 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2296
2297         Reviewed by Adam Barth.
2298
2299         [Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
2300
2301         * platform/haiku/FileChooserHaiku.cpp:
2302
2303 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2304
2305         Reviewed by Adam Barth.
2306
2307         [Haiku] Build fix. ColorSpace name had a wrong CamelCase.
2308
2309         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2310         (WebCore::GraphicsContext::setPlatformStrokeColor):
2311
2312 2009-11-15  Daniel Bates  <dbates@webkit.org>
2313
2314         No review, rolling out r50999.
2315         http://trac.webkit.org/changeset/50999
2316
2317         Need to fix some issues in the Windows build. Missed some places where
2318         RenderTextControl::isEdited is called.
2319
2320         * bindings/objc/DOMHTML.mm:
2321         (-[DOMHTMLInputElement _isEdited]):
2322         (-[DOMHTMLTextAreaElement _isEdited]):
2323         * dom/Document.cpp:
2324         (WebCore::Document::setFocusedNode):
2325         * html/HTMLInputElement.cpp:
2326         (WebCore::HTMLInputElement::defaultEventHandler):
2327         * rendering/RenderTextControl.cpp:
2328         (WebCore::RenderTextControl::RenderTextControl):
2329         (WebCore::RenderTextControl::setInnerTextValue):
2330         (WebCore::RenderTextControl::setUserEdited):
2331         (WebCore::RenderTextControl::subtreeHasChanged):
2332         * rendering/RenderTextControl.h:
2333         (WebCore::RenderTextControl::isEdited):
2334         (WebCore::RenderTextControl::setEdited):
2335         (WebCore::RenderTextControl::isUserEdited):
2336         * rendering/RenderTextControlSingleLine.cpp:
2337         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2338         * wml/WMLInputElement.cpp:
2339         (WebCore::WMLInputElement::defaultEventHandler):
2340
2341 2009-11-15  Daniel Bates  <dbates@webkit.org>
2342
2343         Reviewed by Darin Adler.
2344
2345         https://bugs.webkit.org/show_bug.cgi?id=31186
2346
2347         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
2348         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
2349         These are more descriptive names so as to clear an ambiguity surrounding
2350         their usage. Also, renames associated setters and getters so that they
2351         coincide with the renamed fields.
2352
2353         No functionality was changed. So, no tests were included.
2354
2355         * bindings/objc/DOMHTML.mm:
2356         (-[DOMHTMLInputElement _isEdited]):
2357         (-[DOMHTMLTextAreaElement _isEdited]):
2358         * dom/Document.cpp:
2359         (WebCore::Document::setFocusedNode):
2360         * html/HTMLInputElement.cpp:
2361         (WebCore::HTMLInputElement::defaultEventHandler):
2362         * rendering/RenderTextControl.cpp:
2363         (WebCore::RenderTextControl::RenderTextControl):
2364         (WebCore::RenderTextControl::setInnerTextValue):
2365         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
2366         (WebCore::RenderTextControl::subtreeHasChanged):
2367         * rendering/RenderTextControl.h:
2368         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
2369         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
2370         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
2371         * rendering/RenderTextControlSingleLine.cpp:
2372         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2373         * wml/WMLInputElement.cpp:
2374         (WebCore::WMLInputElement::defaultEventHandler):
2375
2376 2009-11-14  Adele Peterson  <adele@apple.com>
2377
2378         Reviewed by Dan Bernstein.
2379
2380         Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
2381
2382         Test: fast/overflow/line-clamp.html
2383
2384         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
2385         * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
2386         * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
2387
2388         * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
2389         Use the line count value if available.  Otherwise, convert the percentage to the line count, as we did before.  Also,
2390         if there is anchor as the last child box, still allow adding the ellipsis.
2391
2392         * rendering/RenderLayer.cpp:
2393         (WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
2394         (WebCore::RenderLayer::scrollRectToVisible): ditto.
2395
2396         * WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
2397         * rendering/style/LineClampValue.h: Added.
2398         (WebCore::LineClampValue::LineClampValue):
2399         (WebCore::LineClampValue::value):
2400         (WebCore::LineClampValue::isPercentage):
2401         (WebCore::LineClampValue::isNone):
2402         (WebCore::LineClampValue::operator==):
2403         (WebCore::LineClampValue::operator!=):
2404         * rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
2405
2406         * rendering/style/RenderStyle.h: Use LineClampValue.
2407         (WebCore::InheritedFlags::lineClamp):
2408         (WebCore::InheritedFlags::setLineClamp):
2409         (WebCore::InheritedFlags::initialLineClamp):
2410         * rendering/style/StyleRareNonInheritedData.h:
2411
2412 2009-11-14  Eric Carlson  <eric.carlson@apple.com>
2413
2414         Reviewed by Oliver Hunt.
2415
2416         <rdar://problem/7287487> 
2417         Do not use QuickTime version to detect media controller theme
2418
2419         * WebCore.base.exp: Export wkMediaControllerThemeAvailable
2420         * platform/mac/WebCoreSystemInterface.h: Ditto.
2421         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2422
2423         * rendering/RenderThemeMac.mm:
2424         (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the
2425         QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2426
2427 2009-11-14  Kent Tamura  <tkent@chromium.org>
2428
2429         Reviewed by Darin Adler.
2430
2431         - Recognizes date/datetime/datetime-local/month/time/week types of INPUT element.
2432           They have no dedicated UI and no type validation for now.
2433         - Clean up setInputType() and formControlType() of HTMLInputElement.
2434         https://bugs.webkit.org/show_bug.cgi?id=29004
2435
2436         Test: fast/forms/input-type-change3.html
2437
2438         * html/HTMLInputElement.cpp:
2439         (WebCore::HTMLInputElement::valueMissing):
2440         (WebCore::HTMLInputElement::patternMismatch):
2441         (WebCore::HTMLInputElement::tooLong):
2442         (WebCore::createTypeMap):
2443         (WebCore::HTMLInputElement::setInputType):
2444         (WebCore::createFormControlTypes):
2445         (WebCore::HTMLInputElement::formControlType):
2446         (WebCore::HTMLInputElement::saveFormControlState):
2447         (WebCore::HTMLInputElement::restoreFormControlState):
2448         (WebCore::HTMLInputElement::accessKeyAction):
2449         (WebCore::HTMLInputElement::rendererIsNeeded):
2450         (WebCore::HTMLInputElement::createRenderer):
2451         (WebCore::HTMLInputElement::appendFormData):
2452         (WebCore::HTMLInputElement::isTextField):
2453         (WebCore::HTMLInputElement::valueWithDefault):
2454         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
2455         (WebCore::HTMLInputElement::defaultEventHandler):
2456         (WebCore::HTMLInputElement::isRequiredFormControl):
2457         (WebCore::HTMLInputElement::dataList):
2458         * html/HTMLInputElement.h:
2459         (WebCore::HTMLInputElement::):
2460
2461 2009-11-13  Chris Fleizach  <cfleizach@apple.com>
2462
2463         Reviewed by Darin Adler.
2464
2465         WAI-ARIA: checkbox does not determine its label from text content
2466         https://bugs.webkit.org/show_bug.cgi?id=31456
2467
2468         Test: accessibility/aria-checkbox-text.html
2469
2470         * accessibility/AccessibilityRenderObject.cpp:
2471         (WebCore::AccessibilityRenderObject::title):
2472
2473 2009-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2474
2475         Unreviewed, build fix.
2476
2477         [Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
2478         This is just enough changes to unbreak the port.
2479
2480         * bindings/v8/ScriptController.cpp:
2481         (WebCore::mainThreadNormalWorld):
2482         * bindings/v8/V8Proxy.cpp:
2483         (WebCore::V8Proxy::initContextIfNeeded):
2484         * loader/FrameLoaderClient.h:
2485
2486 2009-11-13  Aaron Boodman  <aa@chromium.org>
2487
2488         Unreviewed fix for Chromium build.
2489
2490         * loader/FrameLoaderClient.h:
2491         (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2492         Provide an empty implementation of this method because I don't know
2493         what it is supposed to do on Chromium.
2494
2495 2009-11-13  Aaron Boodman  <aa@chromium.org>
2496
2497         Unreviewed fix for Chromium build.
2498
2499         * loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds()
2500         public, as Chromium's V8Proxy calls it.
2501
2502 2009-11-13  Aaron Boodman  <aa@chromium.org>
2503
2504         Unreviewed fix to Chromium build.
2505
2506         * bindings/v8/ScriptController.cpp:
2507         (WebCore::ScriptController::getAllWorlds): 
2508
2509 2009-11-13  Aaron Boodman  <aa@chromium.org>
2510
2511         Unreviewed fix for Chromium build.
2512
2513         * platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
2514
2515 2009-11-13  Adam Barth  <abarth@webkit.org>
2516
2517         Unreviewed partial build fix for Chromium.  Should fix failure #4.
2518
2519         * bindings/v8/ScriptController.cpp:
2520         (WebCore::ScriptController::getAllWorlds):
2521         * bindings/v8/ScriptController.h:
2522         * bindings/v8/V8Proxy.cpp:
2523         (WebCore::V8Proxy::initContextIfNeeded):
2524
2525 2009-11-13  Adam Barth  <abarth@webkit.org>
2526
2527         Unreviewed partial build fix for Chromium.
2528
2529         * bindings/v8/ScriptController.h:
2530         (WebCore::ScriptController::getAllWorlds):
2531
2532 2009-11-13  Eric Seidel  <eric@webkit.org>
2533
2534         No review, build fix only.
2535
2536         Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
2537
2538         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2539         https://bugs.webkit.org/show_bug.cgi?id=31468
2540
2541         * WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
2542         * WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
2543
2544 2009-11-12  Jeremy Orlow  <jorlow@chromium.org>
2545
2546         Reviewed by Dmitry Titov.
2547
2548         LocalStorage quota should include key sizes in its count
2549         https://bugs.webkit.org/show_bug.cgi?id=31451
2550
2551         * storage/StorageMap.cpp:
2552         (WebCore::StorageMap::setItem):
2553             Count keys in the quota when adding a new item.
2554         (WebCore::StorageMap::removeItem):
2555             Remove the key's length from the quota if we're removing the item.
2556         (WebCore::StorageMap::importItem):
2557             Assume that we're adding things for the first time.
2558             Count keys in the quota.
2559
2560 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
2561
2562         Reviewed by Eric Seidel.
2563
2564         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2565         https://bugs.webkit.org/show_bug.cgi?id=31468
2566
2567         Moving TextBoundariesICU.cpp to TextBoundaries.cpp
2568         by removing the direct ICU dependency and replacing it
2569         with WTF functions and WebCore's own TextBreakIterator
2570         abstractions.
2571
2572         * GNUmakefile.am:
2573         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2574         * platform/text/TextBoundaries.cpp: Added.
2575         (WebCore::findNextWordFromIndex):
2576         (WebCore::findWordBoundary):
2577         * platform/text/TextBoundariesICU.cpp: Removed.
2578         * platform/text/TextBreakIterator.h:
2579         * platform/text/TextBreakIteratorICU.cpp:
2580         (WebCore::textBreakLast):
2581         (WebCore::textBreakPrevious):
2582
2583 2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
2584
2585         Reviewed by Darin Adler.
2586
2587         WebCore::externalRepresentation should update layout before getting render object
2588         https://bugs.webkit.org/show_bug.cgi?id=31459
2589
2590         * rendering/RenderTreeAsText.cpp:
2591         (WebCore::externalRepresentation):
2592
2593 2009-11-13  Adam Roben  <aroben@apple.com>
2594
2595         Tell FrameLoaderClient when window objects in isolated worlds are
2596         cleared
2597
2598         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2599         window objects in isolated worlds are cleared
2600
2601         Test: http/tests/security/isolatedWorld/didClearWindowObject.html
2602
2603         Reviewed by Dave Hyatt.
2604
2605         * bindings/js/JSDOMBinding.h:
2606         (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
2607         worlds in m_worldSet to the passed-in Vector.
2608
2609         * bindings/js/ScriptController.cpp:
2610         (WebCore::ScriptController::getAllWorlds): Added. Calls through to
2611         WebCoreJSClientData.
2612         (WebCore::ScriptController::initScript): Changed to call
2613         FrameLoader::dispatchDidClearWindowObjectInWorld.
2614
2615         * bindings/js/ScriptController.h: Added getAllWorlds.
2616
2617         * loader/EmptyClients.h:
2618         (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2619         Updated for FrameLoaderClient change.
2620
2621         * loader/FrameLoader.cpp:
2622         (WebCore::FrameLoader::receivedFirstData):
2623         (WebCore::FrameLoader::begin):
2624         Changed to call dispatchDidClearWindowObjectsInAllWorlds.
2625
2626         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
2627         Added. Retrieves all the worlds, then calls through to
2628         dispatchDidClearWindowObjectInWorld for each one.
2629         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
2630         dispatchWindowObjectAvailable. Calls up to the client, then, if the
2631         world is the mainThreadNormalWorld(), tells the Inspector about it,
2632         too.
2633
2634         * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
2635         dispatchDidClearWindowObjectInWorld. Added
2636         dispatchDidClearWindowObjectsInAllWorlds.
2637
2638         * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
2639         dispatchDidClearWindowObjectForWorld.
2640
2641 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2642
2643         Reviewed by Dimitri Glazkov.
2644
2645         [V8] Fix SVG context assignment for pod types.
2646         https://bugs.webkit.org/show_bug.cgi?id=31497
2647
2648         I broke this in r50958.
2649
2650         Tested by svg/custom/viewport-update2.svg.
2651
2652         * bindings/scripts/CodeGeneratorV8.pm:
2653
2654 2009-11-13  Andrei Popescu  <andreip@google.com>
2655
2656         Reviewed by Dmitry Titov.
2657
2658         Bring the platform/android files inline with Android 2.0
2659         https://bugs.webkit.org/show_bug.cgi?id=31423
2660
2661         No new tests required: these are all Android-specific files.
2662
2663         * platform/android/ClipboardAndroid.cpp:
2664         (WebCore::ClipboardAndroid::files):
2665         * platform/android/ClipboardAndroid.h:
2666         * platform/android/FileChooserAndroid.cpp:
2667         (WebCore::FileChooser::basenameForWidth):
2668         (WebCore::fileButtonChooseFileLabel):
2669         * platform/android/KeyEventAndroid.cpp:
2670         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2671         * platform/android/LocalizedStringsAndroid.cpp:
2672         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
2673         (WebCore::contextMenuItemTagDownloadLinkToDisk):
2674         (WebCore::contextMenuItemTagCopyLinkToClipboard):
2675         (WebCore::contextMenuItemTagOpenImageInNewWindow):
2676         (WebCore::contextMenuItemTagDownloadImageToDisk):
2677         (WebCore::contextMenuItemTagCopyImageToClipboard):
2678         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
2679         (WebCore::contextMenuItemTagCopy):
2680         (WebCore::contextMenuItemTagGoBack):
2681         (WebCore::contextMenuItemTagGoForward):
2682         (WebCore::contextMenuItemTagStop):
2683         (WebCore::contextMenuItemTagReload):
2684         (WebCore::contextMenuItemTagCut):
2685         (WebCore::contextMenuItemTagPaste):
2686         (WebCore::contextMenuItemTagNoGuessesFound):
2687         (WebCore::contextMenuItemTagIgnoreSpelling):
2688         (WebCore::contextMenuItemTagLearnSpelling):
2689         (WebCore::contextMenuItemTagSearchWeb):
2690         (WebCore::contextMenuItemTagLookUpInDictionary):
2691         (WebCore::contextMenuItemTagOpenLink):
2692         (WebCore::contextMenuItemTagIgnoreGrammar):
2693         (WebCore::contextMenuItemTagSpellingMenu):
2694         (WebCore::contextMenuItemTagShowSpellingPanel):
2695         (WebCore::contextMenuItemTagCheckSpelling):
2696         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
2697         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2698         (WebCore::contextMenuItemTagFontMenu):
2699         (WebCore::contextMenuItemTagBold):
2700         (WebCore::contextMenuItemTagItalic):
2701         (WebCore::contextMenuItemTagUnderline):
2702         (WebCore::contextMenuItemTagOutline):
2703         (WebCore::contextMenuItemTagWritingDirectionMenu):
2704         (WebCore::contextMenuItemTagTextDirectionMenu):
2705         (WebCore::contextMenuItemTagDefaultDirection):
2706         (WebCore::contextMenuItemTagLeftToRight):
2707         (WebCore::contextMenuItemTagRightToLeft):
2708         (WebCore::mediaElementLoadingStateText):
2709         (WebCore::mediaElementLiveBroadcastStateText):
2710         (WebCore::searchableIndexIntroduction):
2711         (WebCore::resetButtonDefaultLabel):
2712         (WebCore::submitButtonDefaultLabel):
2713         (WebCore::inputElementAltText):
2714         * platform/android/RenderThemeAndroid.cpp:
2715         (WebCore::RenderTheme::themeForPage):
2716         (WebCore::RenderThemeAndroid::baselinePosition):
2717         (WebCore::RenderThemeAndroid::paintButton):
2718         (WebCore::adjustMenuListStyleCommon):
2719         (WebCore::RenderThemeAndroid::paintCombo):
2720         * platform/android/ScreenAndroid.cpp:
2721         * platform/android/ScrollViewAndroid.cpp:
2722         (WebCore::ScrollView::platformOffscreenContentRectangle):
2723         * platform/android/TemporaryLinkStubs.cpp:
2724         (JSC::Bindings::dispatchJNICall):
2725         * platform/android/WidgetAndroid.cpp:
2726         (WebCore::Widget::setFrameRect):
2727
2728 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
2729
2730         Reviewed by Eric Seidel.
2731
2732         Added macros for USERINCLUDE paths within symbian blocks
2733         to guarantee inclusion of respective header files from local path
2734         first (to avoid clashes with same names of header files in system include path).
2735
2736         * WebCore.pro:
2737
2738 2009-11-13  Hironori Bono  <hbono@chromium.org>
2739
2740         Reviewed by Oliver Hunt.
2741
2742         Implement composition events introduced in DOM Level 3.
2743         This change adds a new IDL which defines the composition events, adds a class which
2744         implements the composition events, and sends the composition events according to
2745         the specification.
2746         https://bugs.webkit.org/show_bug.cgi?id=26310
2747
2748         Test: fast/events/ime-composition-events-001.html
2749
2750         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
2751         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
2752         * WebCore.gypi: ditto.
2753         * WebCore.pro: ditto
2754         * WebCore.vcproj/WebCore.vcproj: ditto.
2755         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
2756         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
2757         * bindings/js/JSEventCustom.cpp:
2758         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
2759         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
2760         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
2761         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
2762         (WebCore::V8DOMWrapper::convertEventToV8Object):
2763         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
2764         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
2765         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
2766         (WebCore::CompositionEvent::CompositionEvent):
2767         (WebCore::CompositionEvent::~CompositionEvent):
2768         (WebCore::CompositionEvent::initCompositionEvent):
2769         (WebCore::CompositionEvent::isCompositionEvent):
2770         * dom/CompositionEvent.h: Declares the CompositionEvent class.
2771         (WebCore::CompositionEvent::create):
2772         (WebCore::CompositionEvent::data):
2773         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
2774         * dom/Event.cpp:
2775         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
2776         * dom/Event.h:
2777         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
2778         * editing/Editor.cpp:
2779         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
2780         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
2781
2782 2009-11-13  Jens Alfke  <snej@chromium.org>
2783
2784         Reviewed by Dimitri Glazkov.
2785
2786         Fix a link error in unofficial GCC 4.4 builds on Linux.
2787         https://bugs.webkit.org/show_bug.cgi?id=31477
2788
2789         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
2790
2791 2009-11-13  Eric Seidel  <eric@webkit.org>
2792
2793         No review, build fix only.
2794
2795         Fix Debug build after http://trac.webkit.org/changeset/50960.
2796
2797         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
2798         https://bugs.webkit.org/show_bug.cgi?id=31213
2799
2800         * rendering/CounterNode.cpp:
2801         (WebCore::showTreeAndMark):
2802         * rendering/RenderCounter.cpp:
2803         (WebCore::destroyCounterNodeChildren):
2804
2805 2009-11-13  Dirk Schulze  <krit@webkit.org>
2806
2807         Reviewed by Gustavo Noronha.
2808
2809         [CAIRO] shadow support for Canvas and SVG
2810         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2811
2812         We currently fill a path with solid color instead of filling
2813         a clipping path. This causes problems on some composite operators,
2814         since Cairo modifies the area outside the path.
2815         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
2816
2817         Thanks to Benjamin Otte for tracking the bug down.
2818
2819         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2820         (WebCore::setPlatformFill):
2821
2822 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
2823
2824         Reviewed by Dimitri Glazkov.
2825
2826         Adding Chromium's DatabaseTracker implementation.
2827
2828         https://bugs.webkit.org/show_bug.cgi?id=31440
2829
2830         * WebCore.gyp/WebCore.gyp:
2831         * WebCore.gypi:
2832         * storage/DatabaseTracker.h:
2833         * storage/chromium/DatabaseTrackerChromium.cpp:
2834         (WebCore::DatabaseTracker::fullPathForDatabase):
2835         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
2836         * storage/chromium/QuotaTracker.cpp:
2837         (WebCore::QuotaTracker::updateDatabaseSize):
2838         * storage/chromium/QuotaTracker.h:
2839
2840 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
2841
2842         Reviewed by Darin Adler.
2843
2844         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
2845         https://bugs.webkit.org/show_bug.cgi?id=31213
2846         Added tree navigation methods that permit full implementation of CSS2.1
2847         counter feature without using recursion proportional to the counter
2848         tree depth.
2849         No new tests because I did not find any bug that is fixed by this
2850         commit yet, this just reduces the size of the patch for 11031 and
2851         helps respond to some concerns regarding that patch.
2852
2853         * rendering/CounterNode.cpp:
2854         (WebCore::CounterNode::CounterNode):
2855
2856         (WebCore::CounterNode::nextInPreOrderAfterChildren):
2857         (WebCore::CounterNode::nextInPreOrder):
2858         Added to support non-recursive tree traversal necessary for
2859         efficient full implementation of CSS2.1 counters.
2860
2861         (WebCore::CounterNode::lastDescendant):
2862         (WebCore::CounterNode::previousInPreOrder):
2863         Moved this methods such that they occupy a place similar to that of
2864         identically named methods on the render tree. This allows for their
2865         broader use needed in full implementation of CSS2.1 counters.
2866
2867         (WebCore::CounterNode::resetRenderer):
2868         (WebCore::CounterNode::resetRenderers):
2869         (WebCore::CounterNode::recount):
2870         (WebCore::CounterNode::insertAfter):
2871         (WebCore::CounterNode::removeChild):
2872         Changed such that insertion/removal of a counter, triggers not only
2873         recalculation of PrefixWidths, but also reassesment of values in
2874         counter nodes. This is the basis full implementation of CSS2.1
2875         counters. It does not change current behavior by much because of
2876         changes needed to the recalculation algorithm, but those are comming
2877         in the patch for 11031.
2878         (WebCore::showTreeAndMark):
2879         * rendering/CounterNode.h:
2880         * rendering/RenderCounter.cpp:
2881         (WebCore::counter):
2882         Only changed argument type to prepare for implementation of Darin
2883         Adler's recommendation for the patch to 11031.
2884
2885         (WebCore::RenderCounter::invalidate):
2886         (WebCore::destroyCounterNodeChildren):
2887         (WebCore::RenderCounter::destroyCounterNodes):
2888         * rendering/RenderCounter.h:
2889         * rendering/RenderObjectChildList.cpp:
2890         (WebCore::invalidateCountersInContainer):
2891         (WebCore::RenderObjectChildList::invalidateCounters):
2892         * rendering/RenderObjectChildList.h:
2893         Added the ability to restrict invalidation to counters with a given
2894         identifier.
2895         Also invalidated counters that are on the child container itself
2896         which were missed by the previous algorithm, but were a valid case.
2897
2898 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2899
2900         Reviewed by Dimitri Glazkov.
2901
2902         [V8] Protect SVG animated properties from destruction in bindings.
2903         https://bugs.webkit.org/show_bug.cgi?id=31474
2904
2905         See http://crbug.com/26719.
2906
2907         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
2908         under Valgrind.
2909
2910         Made sure we keep a reference to SVG properties while setting a
2911         context:
2912         * bindings/scripts/CodeGeneratorV8.pm:
2913         * bindings/v8/V8Proxy.h:
2914         (WebCore::V8Proxy::withSVGContext):
2915
2916 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
2917
2918         Reviewed by Alexey Proskuryakov.
2919
2920         [CAIRO] shadow support for Canvas and SVG.
2921         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2922
2923         Incorporate Benjamin Otte's recommendations to avoid
2924         a buffer overrun, and small performance improvement.
2925
2926         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2927         (WebCore::copyContextProperties): Correctly size output
2928          storage for cairo_get_dash to avoid buffer overrun.
2929         (WebCore::drawPathShadow): Prefer cairo_fill_extents
2930          to slower cairo_stroke_extents when not drawing shadows.
2931
2932 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
2933
2934         Reviewed by Dimitri Glazkov.
2935
2936         Do not register Chromium's HTML5 DB VFS as the default
2937         VFS. Otherwise, other sqlite DB users in the same process will
2938         stop working.
2939
2940         https://bugs.webkit.org/show_bug.cgi?id=31462
2941
2942         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
2943         (WebCore::SQLiteFileSystem::openDatabase):
2944         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
2945         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
2946         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
2947         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
2948
2949 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
2950
2951         Windows build fix
2952
2953         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2954         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
2955         avoiding a sign mismatch warning.
2956
2957 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
2958
2959         Release build fix.
2960
2961         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2962         (WebCore::SocketStreamHandle::readStreamCallback):
2963         (WebCore::SocketStreamHandle::writeStreamCallback):
2964         Use ASSERT_UNUSED for unused stream parameter.
2965
2966 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
2967
2968         Reviewed by Darin Adler.
2969
2970         https://bugs.webkit.org/show_bug.cgi?id=31441
2971         Implement SocketStreamHandleCFNet
2972
2973         Existing WebSocket tests now pass on Mac. No proxy support yet.
2974
2975         * platform/network/SocketStreamHandleClient.h:
2976         * platform/network/cf/SocketStreamHandle.h:
2977         (WebCore::SocketStreamHandle::shouldUseSSL):
2978         (WebCore::SocketStreamHandle::refAuthenticationClient):
2979         (WebCore::SocketStreamHandle::derefAuthenticationClient):
2980         (WebCore::SocketStreamHandle::):
2981         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2982         (WebCore::SocketStreamHandle::SocketStreamHandle):
2983         (WebCore::SocketStreamHandle::chooseProxy):
2984         (WebCore::SocketStreamHandle::createStreams):
2985         (WebCore::SocketStreamHandle::copyCFStreamDescription):
2986         (WebCore::SocketStreamHandle::readStreamCallback):
2987         (WebCore::SocketStreamHandle::writeStreamCallback):
2988         (WebCore::SocketStreamHandle::~SocketStreamHandle):
2989         (WebCore::SocketStreamHandle::platformSend):
2990         (WebCore::SocketStreamHandle::platformClose):
2991         (WebCore::SocketStreamHandle::receivedCredential):
2992         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
2993         (WebCore::SocketStreamHandle::receivedCancellation):
2994
2995 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
2996
2997         Reviewed by Timothy Hatcher.
2998
2999         Web Inspector: preload status bar button glyphs
3000         in order to prevent them from flickering (take 2).
3001
3002         https://bugs.webkit.org/show_bug.cgi?id=31439
3003
3004         * inspector/front-end/inspector.js:
3005         (preloadImages):
3006
3007 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
3008
3009         Reviewed by Adam Barth.
3010
3011         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
3012         Rolling back r50890.
3013
3014         https://bugs.webkit.org/show_bug.cgi?id=31467
3015
3016         * bindings/v8/V8Proxy.cpp:
3017         (WebCore::V8Proxy::canAccessPrivate):
3018
3019 2009-11-13  Dirk Schulze  <krit@webkit.org>
3020
3021         Reviewed by Gustavo Noronha.
3022
3023         [CAIRO] shadow support for Canvas and SVG
3024         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3025         
3026         This is the fix of a regression, caused by the shadow patch
3027         from the bug above. Reinserted the save and restore calls
3028         that were accidently removed by the previous patch.
3029
3030         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3031         (WebCore::setPlatformFill):
3032         (WebCore::setPlatformStroke):
3033
3034 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
3035
3036         Not reviewed. Reverting r50908 since it makes inspector tests
3037         time out.
3038
3039         https://bugs.webkit.org/show_bug.cgi?id=31439
3040
3041         * inspector/front-end/inspector.js:
3042
3043 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
3044
3045         Reviewed by Timothy Hatcher.
3046
3047         Enable 'console.profile()' and 'console.profileEnd()'
3048         regardless of JAVASCRIPT_DEBUGGER.
3049
3050         https://bugs.webkit.org/show_bug.cgi?id=31293
3051
3052         * WebCore.gypi:
3053         * bindings/js/JSConsoleCustom.cpp:
3054         (WebCore::JSConsole::profile):
3055         (WebCore::JSConsole::profileEnd):
3056         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
3057         (WebCore::CALLBACK_FUNC_DECL):
3058         * bindings/v8/custom/V8CustomBinding.h:
3059         * page/Console.idl:
3060
3061 2009-11-12  David Levin  <levin@chromium.org>
3062
3063         Reviewed by NOBODY.
3064
3065         Chromium build fix.
3066
3067         * bindings/v8/ScriptController.h:
3068         (WebCore::ScriptController::evaluateInWorld): Add a dummy
3069          method which isn't called in chromium to make things compile.
3070
3071 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
3072
3073         Reviewed by Adam Barth.
3074         
3075         The document-open.html test was flaky at times. The test invokes the layout test plugin
3076         which in its destroy stream handler opens a new document. This basically tears down the
3077         stream and the associated plugin instance, which causes a crash when the plugin stream
3078         dereferences an invalid m_client pointer which points to the PluginView instance which
3079         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
3080         and check for the same.
3081        
3082         https://bugs.webkit.org/show_bug.cgi?id=31067
3083
3084         * plugins/PluginStream.cpp:
3085         (WebCore::PluginStream::stop):
3086         (WebCore::PluginStream::destroyStream):
3087
3088 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3089
3090         Reviewed by Dimitri Glazkov.
3091
3092         Renaming some parameters passed to DB-related methods to better
3093         indicate their purpose.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=31449
3096
3097         * platform/chromium/ChromiumBridge.h:
3098
3099 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
3100
3101         Reviewed by Dan Bernstein.
3102
3103         Transformed reflected elements are clipped inside element with opacity
3104         https://bugs.webkit.org/show_bug.cgi?id=30957
3105         
3106         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
3107         each clip rect into painting space before taking the unions. This, however, did not work
3108         correctly with combinations of reflections and transforms. Fixed by unioning the
3109         clipRect and mapping through transforms along the way.
3110         
3111         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
3112         where the transparency layers are.
3113
3114         Test: fast/reflections/opacity-reflection-transform.html
3115
3116         * rendering/RenderLayer.cpp:
3117         (WebCore::expandClipRectForDescendantsAndReflection):
3118         (WebCore::transparencyClipBox):
3119         (WebCore::RenderLayer::beginTransparencyLayers):
3120
3121 2009-11-12  Adam Barth  <abarth@webkit.org>
3122
3123         Reviewed by Darin Fisher.
3124
3125         Improve SecurityOrigin::toString comment
3126         https://bugs.webkit.org/show_bug.cgi?id=31041
3127
3128         * page/SecurityOrigin.h:
3129
3130 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
3131
3132         Reviewed by Darin Adler.
3133
3134         externalRepresentation should take Frame as the argument
3135         https://bugs.webkit.org/show_bug.cgi?id=31393
3136
3137         No new tests as this is just a refactoring.
3138
3139         * WebCore.base.exp:
3140         * rendering/RenderTreeAsText.cpp:
3141         (WebCore::externalRepresentation):
3142         * rendering/RenderTreeAsText.h:
3143
3144 2009-11-12  Ben Murdoch  <benm@google.com>
3145
3146         Reviewed by Dimitri Glazkov.
3147
3148         [Android] The Android specific files in page/Android are out of date.
3149         https://bugs.webkit.org/show_bug.cgi?id=31437
3150
3151         No tests required.
3152
3153         * page/android/DragControllerAndroid.cpp:
3154         (WebCore::DragController::dragOperation): Added.
3155         (WebCore::DragController::cleanupAfterSystemDrag):
3156         * page/android/EventHandlerAndroid.cpp:
3157         (WebCore::EventHandler::accessKeyModifiers): Added.
3158         * page/android/InspectorControllerAndroid.cpp: Removed.
3159
3160 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
3161
3162         Reviewed by Simon Fraser.
3163
3164         [CAIRO] shadow support for Canvas and SVG.
3165         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3166
3167         Implement Canvas/SVG shadow support for Cairo.  This patch
3168         uses the filter code from SVG Filters.  That means that it is
3169         necessary to activate filters to see the shadows.
3170
3171         Test: fast/canvas/canvas-shadow.html
3172
3173         * GNUmakefile.am:
3174         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
3175         * platform/graphics/GraphicsContext.h:
3176         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3177         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
3178         (WebCore::setPlatformFill):
3179         (WebCore::setPlatformStroke):
3180         (WebCore::copyContextProperties):
3181         (WebCore::drawPathShadow):
3182         (WebCore::GraphicsContext::fillPath):
3183         (WebCore::GraphicsContext::strokePath):
3184         (WebCore::GraphicsContext::drawPath):
3185         (WebCore::GraphicsContext::setPlatformShadow):
3186         (WebCore::GraphicsContext::createPlatformShadow):
3187         * platform/graphics/cairo/ImageCairo.cpp:
3188         (WebCore::BitmapImage::draw): Add filter effect.
3189         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
3190         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
3191         * platform/graphics/filters/ImageBufferFilter.h: Added.
3192         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
3193         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
3194
3195 2009-11-12  Dmitry Titov  <dimich@chromium.org>
3196
3197         Reviewed by Alexey Proskuryakov.
3198
3199         Add postTaskToMainThread to ScriptExecutionContext.
3200         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
3201         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
3202         contexts that live on the main thread.
3203         https://bugs.webkit.org/show_bug.cgi?id=31427
3204
3205         No new tests - simply moving the code.
3206
3207         * dom/Document.cpp:
3208         (WebCore::Document::postTask):
3209         * dom/ScriptExecutionContext.cpp:
3210         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
3211         (WebCore::ScriptExecutionContextTaskTimer::fired):
3212         (WebCore::PerformTaskData::PerformTaskData):
3213         (WebCore::PerformTaskData::performTask):
3214         (WebCore::ScriptExecutionContext::postTaskToMainThread):
3215         * dom/ScriptExecutionContext.h:
3216
3217 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
3218
3219         Reviewed by Darin Adler.
3220
3221         Fix crash when removing compositing layers when GC is enabled
3222         https://bugs.webkit.org/show_bug.cgi?id=31429
3223
3224         Workaround <rdar://problem/7390716> by special-casing the removal
3225         of all sublayers when GC is enabled.
3226
3227         * platform/graphics/mac/GraphicsLayerCA.mm:
3228         (WebCore::safeSetSublayers):
3229         (WebCore::GraphicsLayerCA::updateSublayerList):
3230         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
3231
3232 2009-11-12  Jens Alfke  <snej@chromium.org>
3233
3234         Reviewed by Dimitri Glazkov.
3235
3236         The last of the V8 binding optimizations.
3237         - Replace string-valued element accessors with a shared getter/setter function.
3238         - Change error handling flow of control to avoid extra branches and function calls.
3239         https://bugs.webkit.org/show_bug.cgi?id=31443
3240         
3241         * bindings/scripts/CodeGeneratorV8.pm:
3242         * bindings/v8/V8Binding.cpp:
3243         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
3244         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
3245         * bindings/v8/V8Binding.h:
3246
3247 2009-11-12  Sam Weinig  <sam@webkit.org>
3248
3249         Reviewed by Oliver Hunt.
3250
3251         Fix for <rdar://problem/7267951>
3252         Canvas methods should reject uses of NaN and Infinity.
3253
3254         Test: fast/canvas/canvas-with-illegal-args.html
3255
3256         * html/canvas/CanvasRenderingContext2D.cpp:
3257         (WebCore::CanvasRenderingContext2D::scale):
3258         (WebCore::CanvasRenderingContext2D::rotate):
3259         (WebCore::CanvasRenderingContext2D::translate):
3260         (WebCore::CanvasRenderingContext2D::transform):
3261         (WebCore::CanvasRenderingContext2D::setTransform):
3262
3263 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3264
3265         Reviewed by Timothy Hatcher.
3266
3267         Web Inspector: profile timeline panel, fix obvious problems.
3268
3269         https://bugs.webkit.org/show_bug.cgi?id=31432
3270
3271         * inspector/front-end/AbstractTimelinePanel.js:
3272         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
3273         * inspector/front-end/TimelinePanel.js:
3274         (WebInspector.TimelinePanel.prototype._setWindowPosition):
3275         (WebInspector.TimelineCalculator):
3276         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
3277         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
3278         (WebInspector.TimelineCalculator.prototype.reset):
3279         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
3280         (WebInspector.TimelineCalculator.prototype.formatValue):
3281         (WebInspector.TimelineGraph):
3282         (WebInspector.TimelineGraph.prototype.refresh):
3283         * inspector/front-end/utilities.js:
3284         (Element.prototype.hasStyleClass):
3285
3286 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3287
3288         Reviewed by Timothy Hatcher.
3289
3290         Web Inspector: preload status bar button glyphs
3291         in order to prevent them from flickering.
3292
3293         https://bugs.webkit.org/show_bug.cgi?id=31439
3294
3295         * inspector/front-end/inspector.js:
3296         (preloadImages):
3297
3298 2009-11-12  Adam Roben  <aroben@apple.com>
3299
3300         Replace worldIDs with world objects
3301
3302         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
3303         user scripts/stylesheets and isolated worlds
3304
3305         Reviewed by Sam Weinig.
3306
3307         Covered by existing tests.
3308
3309         * WebCore.base.exp: Update exported symbols to match what now exists
3310         and is needed by WebKit.
3311
3312         * bindings/js/ScheduledAction.cpp:
3313         (WebCore::ScheduledAction::execute): Updated for function rename.
3314
3315         * bindings/js/ScriptController.cpp: Removed code that dealt with
3316         worldIDs.
3317         (WebCore::ScriptController::createWorld): Added. Returns a new world
3318         suitable for use on the main thread.
3319         (WebCore::ScriptController::executeScriptInWorld): Renamed from
3320         executeScriptInIsolatedWorld, since this works just fine with a
3321         "normal" world.
3322
3323         * bindings/js/ScriptController.h: Added createWorld, removed functions
3324         that took worldIDs, renamed executeScriptInIsolatedWorld to
3325         executeScriptInWorld.
3326
3327         * page/Frame.cpp:
3328         (WebCore::Frame::injectUserScripts):
3329         (WebCore::Frame::injectUserScriptsForWorld):
3330         Updated for changes to UserScriptMap and ScriptController.
3331
3332         * page/Frame.h: Changed injectUserScriptsForWorld to take a
3333         DOMWrapperWorld* instead of a worldID.
3334
3335         * page/PageGroup.cpp:
3336         (WebCore::PageGroup::addUserScriptToWorld):
3337         (WebCore::PageGroup::addUserStyleSheetToWorld):
3338         (WebCore::PageGroup::removeUserScriptFromWorld):
3339         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
3340         (WebCore::PageGroup::removeUserScriptsFromWorld):
3341         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
3342         * page/PageGroup.h:
3343         Changed these functions to take a DOMWrapperWorld* instead of a
3344         worldID. Also updated for changes to UserScript and UserStyleSheet.
3345
3346         * page/UserScript.h:
3347         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
3348         never used.
3349
3350         * page/UserScriptTypes.h:
3351         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
3352         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
3353         worldID as their key type.
3354
3355
3356 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
3357
3358         Reviewed by Tim Hatcher.
3359
3360         Fixes <http://webkit.org/b/31260>.
3361         Web Inspector: Main Resources Other than HTML are mis-detected.
3362         
3363         Even if the resource is a main resource, look at its CachedResource type, 
3364         because it might be an image, stylesheet, or JavaScript file, and we
3365         want to show them all correctly.
3366
3367         * inspector/InspectorResource.cpp:
3368         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
3369         (WebCore::InspectorResource::type): 
3370         * inspector/InspectorResource.h:
3371
3372 2009-11-12  Jens Alfke  <snej@chromium.org>
3373
3374         Reviewed by Dimitri Glazkov.
3375
3376         Table-driven setup for V8 binding template callback functions. 100k in code savings.
3377         https://bugs.webkit.org/show_bug.cgi?id=31420
3378
3379         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
3380             to call configureTemplate().
3381         * bindings/v8/V8Binding.cpp:
3382         (WebCore::configureTemplate):  New function; does all the standard configuration work.
3383         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
3384         * bindings/v8/V8Binding.h:
3385         * bindings/v8/V8Proxy.cpp:
3386         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
3387         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
3388         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
3389         * bindings/v8/V8Proxy.h:
3390
3391 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3392
3393         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
3394
3395         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3396
3397 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
3398
3399         Reviewed by Dan Bernstein.
3400
3401         <rdar://problem/7388969> Add DOM API for fullscreen video
3402         
3403         DOM API for fullscreen <video>.
3404
3405         Tests: media/media-fullscreen-inline.html
3406                media/media-fullscreen-not-in-document.html
3407
3408         * dom/EventNames.h:
3409             Add webkitbeginfullscreen and webkitendfullscreen.
3410
3411         * html/HTMLAttributeNames.in:
3412             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
3413
3414         * html/HTMLMediaElement.cpp:
3415         (WebCore::HTMLMediaElement::parseMappedAttribute):
3416             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
3417         (WebCore::HTMLMediaElement::enterFullscreen):
3418             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
3419             actually do enter fullscreen.
3420         (WebCore::HTMLMediaElement::exitFullscreen):
3421             Schedule webkitendfullscreenEvent event.
3422         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
3423         (WebCore::HTMLMediaElement::webkitExitFullScreen):
3424         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
3425         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
3426             New, access to fullscreen properties and methods.
3427
3428         * html/HTMLMediaElement.h:
3429         * html/HTMLMediaElement.idl:
3430             Declare methods needed for fullscreen API.
3431
3432         * html/HTMLVideoElement.cpp:
3433         (WebCore::HTMLVideoElement::supportsFullscreen):
3434             Return false if a movie does not have video.
3435
3436         * page/DOMWindow.h:
3437             Add webkitbeginfullscreen and webkitendfullscreen.
3438
3439 2009-11-12  Adam Barth  <abarth@webkit.org>
3440
3441         Reviewed by Dimitri Glazkov.
3442
3443         [Chromium] Sify compose button alerts error
3444         https://bugs.webkit.org/show_bug.cgi?id=31394
3445
3446         Test: http/tests/security/calling-versus-current.html
3447
3448         We're supposed to use the calling context for security checks.  In JSC
3449         land, this is the lexicalGlobalObject.
3450
3451         * bindings/v8/V8Proxy.cpp:
3452         (WebCore::V8Proxy::canAccessPrivate):
3453
3454 2009-11-12  Daniel Bates  <dbates@webkit.org>
3455
3456         Reviewed by Darin Adler.
3457
3458         https://bugs.webkit.org/show_bug.cgi?id=30291
3459
3460         Fixes an issue where the returned drop effect is incorrect when
3461         effectAllowed == "uninitialized".
3462
3463         According to section 7.9.2 of the HTML 5 spec.
3464         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
3465         when effectAllowed = "uninitialized" the resulting dropEffect should be the
3466         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
3467         other case.
3468         
3469         No test cases are included because we have an existing test case from
3470         bug #24731.
3471
3472         * dom/Clipboard.cpp:
3473         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
3474
3475 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3476
3477         Reviewed by Timothy Hatcher.
3478
3479         Web Inspector: Do not highlight node on refresh.
3480
3481         https://bugs.webkit.org/show_bug.cgi?id=31419
3482
3483         * inspector/front-end/ElementsPanel.js:
3484         (WebInspector.ElementsPanel.prototype.reset):
3485
3486 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3487
3488         Reviewed by Timothy Hatcher.
3489
3490         Web Inspector: Minor timeline fixes.
3491
3492         https://bugs.webkit.org/show_bug.cgi?id=31417
3493
3494         * inspector/front-end/TimelinePanel.js:
3495         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3496         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3497         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
3498         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3499
3500 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
3501
3502         SnowLeopard build fix.
3503
3504         Renamed initWithClient to initWithAuthenticationClient.
3505
3506         * platform/network/mac/AuthenticationMac.mm:
3507         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
3508         (WebCore::AuthenticationChallenge::setAuthenticationClient):
3509
3510 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
3511
3512         Reviewed by Darin Adler.
3513
3514         ARIA: add alert type roles
3515         https://bugs.webkit.org/show_bug.cgi?id=31392
3516
3517         Test: platform/mac/accessibility/aria-alerts.html
3518
3519         * accessibility/AccessibilityObject.h:
3520         * accessibility/AccessibilityRenderObject.cpp:
3521         * accessibility/mac/AccessibilityObjectWrapper.mm:
3522
3523 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
3524
3525         Reviewed by Darin Adler.
3526
3527         https://bugs.webkit.org/show_bug.cgi?id=31386
3528         Make Mac AuthenticationChallenge usable from cross-platform code
3529
3530         No change in behavior, so no tests.
3531
3532         * platform/network/ResourceHandle.cpp:
3533         (WebCore::ResourceHandle::clearAuthentication):
3534         * platform/network/ResourceHandleInternal.h:
3535         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3536         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
3537         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
3538         is identical.
3539
3540         * platform/network/cf/AuthenticationChallenge.h:
3541         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
3542         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
3543
3544         * platform/network/cf/ResourceHandleCFNet.cpp:
3545         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
3546         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
3547         be already set.
3548
3549         * platform/network/mac/AuthenticationChallenge.h:
3550         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
3551         best of my understanding.
3552         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
3553         confusion with "mac" and "web" challenges in ResourceHandleInternal.
3554
3555         * platform/network/mac/AuthenticationMac.mm:
3556         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
3557         making it possible to use the latter with NSURLAuthenticationChallenge.
3558         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
3559         m_nsChallenge renaming.
3560         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
3561         set it as sender (or unset, if client is null).
3562
3563         * platform/network/mac/ResourceHandleMac.mm:
3564         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
3565         authentication challenge sender.
3566         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
3567         authentication sheet.
3568         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
3569         using the new setAuthenticationClient() method.
3570         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
3571         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
3572         the original Mac one, not the one we created for use with authentication sheet. I don't
3573         know when a connection would cancel authentication in practice, so I haven't tested this.
3574
3575 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3576
3577         Reviewed by Timothy Hatcher.
3578
3579         Web Inspector: breakpoint sidebar entries should allow click over entire list item
3580         https://bugs.webkit.org/show_bug.cgi?id=31411
3581
3582         No new tests; no new functionality, small usability change. 
3583
3584         * inspector/front-end/BreakpointsSidebarPane.js:
3585         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
3586         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
3587
3588 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3589
3590         Reviewed by Timothy Hatcher.
3591
3592         Web Inspector: breakpoints in named evals are not restored after a reload
3593         https://bugs.webkit.org/show_bug.cgi?id=31375
3594
3595         Manual test added
3596
3597         * inspector/front-end/ScriptsPanel.js:
3598         (WebInspector.ScriptsPanel.prototype.addScript):
3599         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
3600
3601 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3602
3603         Reviewed by Kenneth Rohde Christiansen.
3604
3605         Custom printing shrink factors
3606         https://bugs.webkit.org/show_bug.cgi?id=29042
3607
3608         This reverts commit r49769. The public API for this needs to be reviewed
3609         before its inclusion in Qt.
3610
3611         * page/PrintContext.cpp:
3612         (WebCore::PrintContext::begin):
3613         * page/Settings.cpp:
3614         (WebCore::Settings::Settings):
3615         * page/Settings.h:
3616
3617 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
3618
3619         Reviewed by Pavel Feldman.
3620
3621         Web Inspector: Resource errors/warnings not shown in the Resource tree.
3622
3623         Error/Warning bubbles are not displayed next to the resource in the 
3624         Resources panel if those occur before the resource is attached to the tree.
3625         https://bugs.webkit.org/show_bug.cgi?id=31404
3626
3627         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
3628
3629         * inspector/front-end/AbstractTimelinePanel.js:
3630         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3631         * inspector/front-end/ResourcesPanel.js:
3632         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
3633
3634 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3635
3636         Reviewed by Jan Alonzo.
3637
3638         https://bugs.webkit.org/show_bug.cgi?id=31047
3639         [GTK] Failing test media/video-played-ranges-1.html
3640
3641         Follow-up of r50726, don't block the UI thread when calling
3642         gst_element_get_state(). Also fixed a compilation warning and some
3643         static casts.
3644
3645         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3646         (WebCore::playbackPosition):
3647         (WebCore::MediaPlayerPrivate::seek):
3648         (WebCore::MediaPlayerPrivate::setRate):
3649
3650 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3651
3652         Reviewed by Jan Alonzo.
3653
3654         https://bugs.webkit.org/show_bug.cgi?id=31047
3655         [GTK] Failing test media/video-played-ranges-1.html
3656
3657         don't pause pipeline if already paused, same for play()
3658
3659         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3660         (WebCore::MediaPlayerPrivate::play):
3661         (WebCore::MediaPlayerPrivate::pause):
3662
3663 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
3664
3665         Reviewed by David Levin.
3666
3667         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
3668         Chromium too.
3669         https://bugs.webkit.org/show_bug.cgi?id=31292
3670
3671         No new tests. (Corresponding test for Gtk+ is
3672         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
3673
3674         * page/EventHandler.cpp:
3675         * page/chromium/EventHandlerChromium.cpp:
3676
3677 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
3678
3679         Reviewed by Eric Seidel.
3680
3681         Prevent text inside a multi-column block from being split into columns.
3682         
3683         If the tentative height of a multi-column block was too small, we need to
3684         expand the block height and try to layout again, in order to prevent text
3685         from being split into different columns.
3686
3687         CSS Multicolumn text is split awkwardly
3688         https://bugs.webkit.org/show_bug.cgi?id=22249
3689
3690         Test: fast/multicol/single-line.html
3691
3692         * rendering/RenderBlock.cpp:
3693         (WebCore::RenderBlock::layoutColumns):
3694         * rendering/RenderBlock.h: