fd18ba00560ea943b92fc5825ffc085fe4cfe1d7
[WebKit.git] / Tools / ChangeLog
1 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Gustavo Noronha Silva.
4
5         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
6         https://bugs.webkit.org/show_bug.cgi?id=40833
7
8         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
9         GTK+ event sender.
10         (dragWithFilesDragDataGetCallback): Added.
11         (dragWithFilesDragEndCallback): Added.
12         (beginDragWithFilesCallback): Added.
13
14 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
15
16         Reviewed by Adam Barth.
17
18         ews: Add additional watcher to efl ews
19         https://bugs.webkit.org/show_bug.cgi?id=52613
20
21         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
22
23         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
24
25 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
26
27         Reviewed by Alexey Proskuryakov.
28
29         Fix some headers with missing or misspelled #ifndef guards
30         https://bugs.webkit.org/show_bug.cgi?id=52545
31
32         * DumpRenderTree/chromium/TestEventPrinter.h:
33         * DumpRenderTree/chromium/WebPreferences.h:
34
35 2011-01-17  Jessie Berlin  <jberlin@apple.com>
36
37         Reviewed by Anders Carlsson.
38
39         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
40         navigating back to an unreachable URL
41         https://bugs.webkit.org/show_bug.cgi?id=52388
42
43         Add a third parameter (unreachableURL) to queueLoadHTMLString.
44
45         * DumpRenderTree/LayoutTestController.cpp:
46         (queueLoadHTMLStringCallback):
47         (LayoutTestController::queueLoadHTMLString):
48         (LayoutTestController::queueLoadAlternateHTMLString):
49         * DumpRenderTree/LayoutTestController.h:
50
51         * DumpRenderTree/WorkQueueItem.h:
52         (LoadHTMLStringItem::LoadHTMLStringItem):
53
54         * DumpRenderTree/chromium/LayoutTestController.cpp:
55         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
56         (WorkItemLoadHTMLString::run):
57         (LayoutTestController::queueLoadHTMLString):
58
59         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
60         (LoadHTMLStringItem::invoke):
61         * DumpRenderTree/mac/WorkQueueItemMac.mm:
62         (LoadHTMLStringItem::invoke):
63         * DumpRenderTree/win/WorkQueueItemWin.cpp:
64         (LoadHTMLStringItem::invoke):
65
66 2011-01-17  Dan Bernstein  <mitz@apple.com>
67
68         Rubber-stamped by Mark Rowe.
69
70         Update xcodeproj svn:ignore to include xcuserdata.
71
72         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
73         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
74         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
75         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
76         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
77
78 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
79
80         Unreviewed fix after r75908.
81
82         Move WebKit into Source
83         https://bugs.webkit.org/show_bug.cgi?id=52530
84
85         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
86
87 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
88
89         Unreviewed.
90
91         Remove accidentally committed debug printing after r75908.
92
93         * Scripts/webkitdirs.pm:
94
95 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
96
97         Unreviewed.
98
99         Add myself to committers list
100         https://bugs.webkit.org/show_bug.cgi?id=52566
101
102         * Scripts/webkitpy/common/config/committers.py:
103
104 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
105
106         Reviewed by Jeremy Orlow.
107
108         GeolocationController should call stopUpdating on destruction
109         https://bugs.webkit.org/show_bug.cgi?id=52216
110
111         fast/dom/Geolocation/window-close-crash.html requires that a
112         Geolocation watch be started in a secondary window. Consequently,
113         we need to allow geolocation permission and provide a mock
114         geolocation position for the secondary window's
115         GeolocationClientMock.
116
117         * DumpRenderTree/chromium/LayoutTestController.cpp:
118         (LayoutTestController::setGeolocationPermission):
119         (LayoutTestController::setMockGeolocationPosition):
120         (LayoutTestController::setMockGeolocationError):
121         * DumpRenderTree/chromium/TestShell.h:
122         (TestShell::windowList):
123
124 2011-01-16  Adam Barth  <abarth@webkit.org>
125
126         Update more include paths to reflect WebKit move.
127
128         * DumpRenderTree/chromium/EventSender.cpp:
129         (EventSender::keyDown):
130         (EventSender::needsShiftModifier):
131         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
132         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
133
134 2011-01-16  Kent Tamura  <tkent@chromium.org>
135
136         Unreviewed, Chromium build fix.
137
138         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
139
140 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
141
142         Build fix for GTK+ after source directory movement.
143
144         * GNUmakefile.am: Correct include paths.
145
146 2011-01-16  Adam Barth  <abarth@webkit.org>
147
148         Teach svn-apply about WebKit move.
149
150         * Scripts/VCSUtils.pm:
151
152 2011-01-16  Adam Barth  <abarth@webkit.org>
153
154         Rubber-stamped by Eric Seidel.
155
156         Move WebKit into Source
157         https://bugs.webkit.org/show_bug.cgi?id=52530
158
159         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
160         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
161         * DumpRenderTree/qt/DumpRenderTreeQt.h:
162         * DumpRenderTree/qt/GCControllerQt.cpp:
163         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
164         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
165         * DumpRenderTree/qt/TextInputControllerQt.cpp:
166         * DumpRenderTree/wscript:
167         * QtTestBrowser/launcherwindow.h:
168         * Scripts/build-webkit:
169         * Scripts/webkitdirs.pm:
170
171 2011-01-15  Adam Barth  <abarth@webkit.org>
172
173         Teach svn-apply about WebKit2 move.
174
175         * Scripts/VCSUtils.pm:
176
177 2011-01-15  Adam Barth  <abarth@webkit.org>
178
179         Rubber-stamped by Eric Seidel.
180
181         Move WebKit2 into Source
182         https://bugs.webkit.org/show_bug.cgi?id=52438
183
184         * MiniBrowser/qt/MiniBrowser.pro:
185         * Scripts/build-webkit:
186         * Scripts/do-file-rename:
187         * Scripts/do-webcore-rename:
188         * Scripts/test-webkitpy:
189         * Scripts/webkitdirs.pm:
190         * Scripts/webkitpy/style/checker.py:
191         * WebKitTestRunner/DerivedSources.pro:
192         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
193         * WebKitTestRunner/qt/WebKitTestRunner.pro:
194
195 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
196
197         Reviewed by David Levin.
198
199         [chromium] remove obsolete createView method
200         https://bugs.webkit.org/show_bug.cgi?id=52437
201
202         * DumpRenderTree/chromium/WebViewHost.cpp:
203         (WebViewHost::createView):
204         * DumpRenderTree/chromium/WebViewHost.h:
205
206 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
207
208         Reviewed by Geoff Garen.
209
210         ShouldLoadResourceForFrame should use strings, not URLs.
211         https://bugs.webkit.org/show_bug.cgi?id=52476
212
213         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
214         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
215         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
216
217 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
218
219         Reviewed by David Levin.
220
221         Add Tony Gentilcore as a reviewer
222         https://bugs.webkit.org/show_bug.cgi?id=52480
223
224         * Scripts/webkitpy/common/config/committers.py:
225
226 2011-01-14  David Levin  <levin@chromium.org>
227
228         Reviewed by Eric Seidel.
229
230         check-webkit-style: _FunctionState should keep track of where the function name starts.
231         https://bugs.webkit.org/show_bug.cgi?id=52454
232
233         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
234         _FunctionState and logic for setting it correctly.
235         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
236
237 2011-01-14  Vincent Scheib  <scheib@chromium.org>
238
239         Reviewed by David Levin.
240
241         Add support to DumpRenderTree to use the GPU rather than software renderer
242         https://bugs.webkit.org/show_bug.cgi?id=52333
243
244         * DumpRenderTree/chromium/DumpRenderTree.cpp:
245         (main):
246         * Scripts/webkitpy/layout_tests/port/chromium.py:
247         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
248
249 2011-01-14  Tony Chang  <tony@chromium.org>
250
251         Reviewed by Kent Tamura.
252
253         [chromium] update fonts.conf to fix 6 linux tests in drt
254         https://bugs.webkit.org/show_bug.cgi?id=52411
255
256         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
257             chromium's src/webkit/tools/test_shell/resources/fonts.conf
258
259 2011-01-14  Eric Seidel  <eric@webkit.org>
260
261         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
262
263         Reviewed by Adam Barth.
264
265         Fix when running Tools/Scripts/check-webkit-style without arguments.
266         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
267
268         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
269         * Scripts/webkitpy/common/checkout/scm_unittest.py:
270
271 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
272
273         Reviewed by David Levin.
274
275         Store the tempdir object in a variable so it doesn't get deleted too early.
276         https://bugs.webkit.org/show_bug.cgi?id=51875
277
278         * Scripts/update-webkit-auxiliary-libs:
279         * Scripts/update-webkit-support-libs:
280
281 2011-01-14  Eric Seidel  <eric@webkit.org>
282
283         Unreviewed.  Make it work in python 2.5.
284
285         webkit-patch suggest-reviewers dies when ChangeLogs are missing
286         https://bugs.webkit.org/show_bug.cgi?id=49158
287
288         * Scripts/webkitpy/common/checkout/api_unittest.py:
289
290 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
291
292         Unreviewed, rolling out r75774.
293         http://trac.webkit.org/changeset/75774
294         https://bugs.webkit.org/show_bug.cgi?id=52431
295
296         gtk builds were broken (Requested by loislo2 on #webkit).
297
298         * Scripts/webkitpy/common/checkout/scm.py:
299
300 2011-01-14  David Levin  <levin@chromium.org>
301
302         Reviewed by Shinichiro Hamaji.
303
304         check-webkit-style: _FunctionState should detect pure functions.
305         https://bugs.webkit.org/show_bug.cgi?id=52428
306
307         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
308         is a pure virtual function.
309         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
310         virtual functions are correctly detected.
311
312 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
313
314         Reviewed by Yury Semikhatsky.
315
316         Just small fix for problem with check-webkit-style.
317         It just didn't work for this patch.
318         Old code can't concatenate a list of strings with None.
319
320         * Scripts/webkitpy/common/checkout/scm.py:
321
322 2011-01-13  David Levin  <levin@chromium.org>
323
324         Reviewed by Shinichiro Hamaji.
325
326         check-webkit-style: _FunctionState should use Position to know where items are.
327         https://bugs.webkit.org/show_bug.cgi?id=52424
328
329         * Scripts/webkitpy/style/checkers/cpp.py:
330         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
331         (detect_functions): Changed to pass Position's to _FunctionState.begin and
332         did some minor clean-up.
333         (*): Other changes are simply about converting to use the Position's in_FunctionState
334         instead of line numbers.
335         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
336         to verify the positions stored in _FunctionState.
337
338 2011-01-13  Eric Seidel  <eric@webkit.org>
339
340         Reviewed by David Levin.
341
342         webkit-patch suggest-reviewers dies when ChangeLogs are missing
343         https://bugs.webkit.org/show_bug.cgi?id=49158
344
345         This is not the most elegant, but it is a very safe fix to this bug.
346         One advantage of catching ScriptError like this instead of adding a
347         new added_or_modified_files or fixing all changed_files callers
348         to use a more specific change_files variant, is that we catch
349         all kinds of ScriptErrors which might cause our (non-essential)
350         suggest-reviewers code to fail out.  This should make passing
351         --suggest-reviewers to webkit-patch upload much more robust
352         and may even make it possible for us to make it default.
353
354         The root of the problem here is that SCM.changed_files includes
355         deleted ChangeLog paths (from moves, etc) which then when we ask
356         SVN/Git for the contents of the file at that revision, the command
357         errors out and Executive.run_command raises a ScriptError.
358
359         In the future we might fix this differently by making all current
360         callers of chagned_files use a more specific method for requesting
361         what types of changes they're interested in (adds, modifies, deletes, etc.)
362
363         * Scripts/webkitpy/common/checkout/api.py:
364         * Scripts/webkitpy/common/checkout/api_unittest.py:
365
366 2011-01-13  Dan Bernstein  <mitz@apple.com>
367
368         Reviewed by Alexey Proskuryakov.
369
370         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
371         https://bugs.webkit.org/show_bug.cgi?id=52419
372
373         Allow to further control the behavior of the willSendRequest delegate callback by making it
374         set a different URL in the new request.
375
376         * DumpRenderTree/LayoutTestController.cpp:
377         (addURLToRedirectCallback): Added.
378         (LayoutTestController::staticFunctions): Added addURLToRedirect.
379         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
380         (LayoutTestController::redirectionDestinationForURL): Added this getter.
381         * DumpRenderTree/LayoutTestController.h:
382         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
383         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
384         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
385         change the URL in the new request to the redirect destination.
386
387 2011-01-13  Eric Seidel  <eric@webkit.org>
388
389         Reviewed by Mihai Parparita.
390
391         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
392         https://bugs.webkit.org/show_bug.cgi?id=52416
393
394         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
395         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
396
397         I also added FIXMEs about the changed_files returning deleted files problem
398         which is causing the other most common exception for suggest-reviewers
399         (and is probably breaking sheriff-bots blame detection).
400
401         * Scripts/webkitpy/common/checkout/api.py:
402         * Scripts/webkitpy/common/checkout/api_unittest.py:
403         * Scripts/webkitpy/common/checkout/scm.py:
404
405 2011-01-13  Eric Seidel  <eric@webkit.org>
406
407         Reviewed by Adam Barth.
408
409         results archives from commit-queue are too large to upload
410         https://bugs.webkit.org/show_bug.cgi?id=52405
411
412         * Scripts/webkitpy/common/system/filesystem.py:
413         * Scripts/webkitpy/common/system/filesystem_mock.py:
414         * Scripts/webkitpy/tool/commands/queues.py:
415
416 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
417
418         Reviewed by Martin Robinson.
419
420         [gtk] Zero-sized font does not yet work
421         https://bugs.webkit.org/show_bug.cgi?id=49793
422
423         Set minimum-font-size to 0 for the DRT.
424
425         * DumpRenderTree/gtk/DumpRenderTree.cpp:
426         (resetDefaultsToConsistentValues):
427
428 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
429
430         Reviewed by Darin Adler.
431
432         Make old-run-webkit-tests more robust on buildbots
433         https://bugs.webkit.org/show_bug.cgi?id=52364
434
435         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
436
437 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
438
439         Reviewed by Darin Adler.
440
441         Make old-run-webkit-tests more robust on buildbots
442         https://bugs.webkit.org/show_bug.cgi?id=52364
443
444         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
445
446 2011-01-13  Tony Chang  <tony@chromium.org>
447
448         Reviewed by Kent Tamura.
449
450         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
451         https://bugs.webkit.org/show_bug.cgi?id=52332
452
453         Forked Info.plist is not longer needed.
454
455         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
456
457 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
458
459         Reviewed by Timothy Hatcher.
460
461         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
462         to be passed directly to WebInspector.UIString
463
464         https://bugs.webkit.org/show_bug.cgi?id=52365
465
466         * Scripts/check-inspector-strings:
467
468 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
469
470         Unreviewed, rolling out r74881.
471         http://trac.webkit.org/changeset/74881
472         https://bugs.webkit.org/show_bug.cgi?id=52357
473
474         The EFL builder has been red for days (Requested by abarth on
475         #webkit).
476
477         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
478         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
479
480 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
481
482         Reviewed by David Levin.
483
484         Add beforeunload support to WebKitTestRunner
485         https://bugs.webkit.org/show_bug.cgi?id=52353
486         
487         This makes a number of currently failing tests pass.
488
489         * WebKitTestRunner/TestController.cpp:
490         (WTR::runBeforeUnloadConfirmPanel):
491         (WTR::createOtherPage):
492         (WTR::TestController::initialize):
493
494 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
495
496         Reviewed by Sam Weinig.
497
498         Detect, identify and recover from WebProcess crashes in run-webkit-tests
499         https://bugs.webkit.org/show_bug.cgi?id=52330
500
501         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
502         a web process crash.
503         * WebKitTestRunner/TestController.cpp:
504         (WTR::TestController::initialize): Set up a processDidCrash
505         callback.
506         (WTR::TestController::processDidCrash): Report that the Web process
507         crashed.
508         * WebKitTestRunner/TestController.h:
509
510 2011-01-12  David Levin  <levin@chromium.org>
511
512         Reviewed by Shinichiro Hamaji.
513
514         check-webkit-style -- close_expression function doesn't work correctly.
515         https://bugs.webkit.org/show_bug.cgi?id=52272
516
517         * Scripts/webkitpy/style/checkers/cpp.py:
518         (Position.__str__): Added a way to convert it to a string which is useful in tests.
519         (Position.__cmp__): Added a way to compare Position which is useful in tests and
520         generally useful (for upcoming code changes).
521         (close_expression): Changed to use Position for input and output.
522         Also, fixed many bugs such as only working correctly for parenthesis,
523         not working correctly if given an offset in a line and not finding
524         the real closing element if there were multiple closing elements in
525         the same line.
526         (detect_functions): Adjusted due to the change in arguments for
527         close_expression.
528         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
529         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
530         two positions are the same.
531         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
532         (CppStyleTest.test_close_expression): Added tests to catch the issues
533         that were fixed.
534
535 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
536
537         Unreviewed, rolling out r75576.
538         http://trac.webkit.org/changeset/75576
539         https://bugs.webkit.org/show_bug.cgi?id=52304
540
541         broke rebaseline-chromium-webkit-test (Requested by thakis on
542         #webkit).
543
544         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
545         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
546         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
547         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
548         * Scripts/webkitpy/layout_tests/port/base.py:
549         * Scripts/webkitpy/layout_tests/port/chromium.py:
550         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
551         * Scripts/webkitpy/layout_tests/port/test.py:
552         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
553         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
554         * Scripts/webkitpy/style/checkers/test_expectations.py:
555         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
556
557 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
558
559         Reviewed by Darin Adler.
560
561         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
562         https://bugs.webkit.org/show_bug.cgi?id=52307
563
564         * Scripts/old-run-webkit-tests:
565
566 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
567
568         Reviewed by Martin Robinson.
569
570         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
571         https://bugs.webkit.org/show_bug.cgi?id=50867
572
573         Fixed library extention for Mac in webkitdirs.pm and type conflict in
574         TestNetscapePlugin.cpp 
575
576         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
577         * Scripts/webkitdirs.pm:
578
579 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
580
581         Reviewed by Pavel Feldman.
582
583         Add check-inspector-strings script.
584
585         https://bugs.webkit.org/show_bug.cgi?id=52295
586
587         * Scripts/check-inspector-strings: Added.
588
589 2011-01-12  Adam Roben  <aroben@apple.com>
590
591         Advertise the .testnetscape file extension on Windows
592
593         Fixes <http://webkit.org/b/52298>
594         plugins/no-mime-with-valid-extension.html fails on Windows
595
596         Reviewed by Dan Bernstein.
597
598         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
599         FileExtents field to map the .testnetscape file extension to the
600         application/x-webkit-test-netscape MIME type, just as we do on Mac.
601
602 2011-01-12  Adam Barth  <abarth@webkit.org>
603
604         Reviewed by Eric Seidel.
605
606         Make webkit-patch support subdirectories for SVN checkouts
607         https://bugs.webkit.org/show_bug.cgi?id=52261
608
609         os.relpath does not exist on Python 2.5, so we need to call our version
610         of the API.
611
612         * Scripts/webkitpy/common/checkout/scm.py:
613
614 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
615
616         Reviewed by Eric Seidel.
617
618         Close additional pages opened during a test once the test completes.
619         https://bugs.webkit.org/show_bug.cgi?id=52276
620
621         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
622         (WTR::InjectedBundle::done):
623
624 2011-01-11  David Levin  <levin@chromium.org>
625
626         Reviewed by Eric Seidel.
627
628         Errors should be separated from the command line in bot messages.
629         https://bugs.webkit.org/show_bug.cgi?id=52275
630
631         * Scripts/webkitpy/common/system/executive.py:
632         (ScriptError.message_with_output): Added a newline to separate the command
633         line from the errors.
634         * Scripts/webkitpy/common/system/executive_unittest.py:
635         (ScriptErrorTest.test_message_with_output): Added tests for the various code
636         paths in message_with_output.
637
638 2011-01-11  Eric Seidel  <eric@webkit.org>
639
640         Unreviewed.
641
642         commit-queue should know how to upload archived results (for test flakes or general failures)
643         https://bugs.webkit.org/show_bug.cgi?id=52048
644
645         The zips are mostly empty due to forgetting -r.
646         Expected diffs were not being pulled from the archive due
647         to the archive having longer paths than I realized.
648
649         * Scripts/webkitpy/common/system/workspace.py:
650         * Scripts/webkitpy/common/system/workspace_unittest.py:
651         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
652         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
653
654 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
655
656         Reviewed by Ojan Vafai.
657
658         The current modifier parsing code in test_expectations is
659         fragile and hard-coded, so it's not easy to understand the logic
660         or easily add new types of modifiers (like GPU vs. CPU testing
661         for graphics tests, or 32-bit vs. 64-bit differences).
662
663         This is the first of two patches that will add in more generic
664         support and then eliminate the GPU-specific test expectations
665         files for Chromium.
666
667         This patch adds two standalone objects for handling modifiers. The
668         rules for interpreting modifiers, precedence, and conflicts are
669         given in the docstring to the ModifierMatcher class, which
670         returns ModifierMatchResult objects.
671         
672         This patch also adds routines to the Port interface and a
673         default set of values in the base object, in order to obtain the
674         values needed on a given test run. These values are then passed
675         to the expectation parser. This also allows us to clean up the
676         logic used to lint all of the different configurations in a
677         single test_expectations.txt file.
678
679         The next patch will merge in the separate GPU expectations file.
680
681         https://bugs.webkit.org/show_bug.cgi?id=51222
682
683         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
684         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
685         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
686         * Scripts/webkitpy/layout_tests/port/base.py:
687         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
688         * Scripts/webkitpy/layout_tests/port/chromium.py:
689         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
690         * Scripts/webkitpy/layout_tests/port/test.py:
691         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
692         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
693
694 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
695
696         Reviewed by Adam Barth.
697
698         Make webkit-patch support subdirectories for SVN checkouts
699         https://bugs.webkit.org/show_bug.cgi?id=52261
700
701         * Scripts/webkitpy/common/checkout/scm.py:
702         * Scripts/webkitpy/style_references.py:
703         * Scripts/webkitpy/tool/main.py:
704         * Scripts/webkitpy/tool/steps/preparechangelog.py:
705
706 2011-01-11  Eric Seidel  <eric@webkit.org>
707
708         Unreviewed.
709
710         commit-queue should know how to upload archived results (for test flakes or general failures)
711         https://bugs.webkit.org/show_bug.cgi?id=52048
712
713         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
714         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
715
716         * Scripts/webkitpy/common/system/workspace.py:
717         * Scripts/webkitpy/common/system/workspace_unittest.py:
718         * Scripts/webkitpy/tool/commands/queues.py:
719
720 2011-01-11  Sam Weinig  <sam@webkit.org>
721
722         Roll r75474 back in.
723
724 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
725
726         Reviewed by Kenneth Rohde Christiansen.
727
728         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
729         https://bugs.webkit.org/show_bug.cgi?id=51204
730
731         * QtTestBrowser/webpage.h:
732         (QtNAMThread::QtNAMThread):
733         (QtNAMThread::networkAccessManager):
734         (QtNAMThread::run):
735
736 2011-01-11  Peter Varga  <pvarga@webkit.org>
737
738         Unreviewed.
739
740         Add myself to committers' list.
741
742         * Scripts/webkitpy/common/config/committers.py:
743
744 2011-01-11  Eric Seidel  <eric@webkit.org>
745
746         Reviewed by Adam Barth.
747
748         commit-queue should know how to upload archived results (for test flakes or general failures)
749         https://bugs.webkit.org/show_bug.cgi?id=52048
750
751         Now the queue will always upload results.  Either the entire zip, or just
752         the diffs.txt in the case of text failures.
753
754         This should make understanding flakes much easier, and paves the way
755         for having the EWS run layout tests (and upload failures).
756
757         In order to upload .zip files I had to teach bugzilla.py to autodetect
758         mime types from the filename.  Since mimetypes.py doesn't include a mapping
759         for .patch files, I have it add one before calling guess_type.
760
761         We may find that always uploading the whole zip instead of just the -diffs.txt
762         file is preferable, but for now I'm keeping the old behavior because it makes
763         quickly understanding text failures easy.
764
765         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
766         * Scripts/webkitpy/common/system/workspace.py: Added.
767         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
768         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
769         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
770         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
771         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
772         * Scripts/webkitpy/tool/commands/queues.py:
773         * Scripts/webkitpy/tool/commands/queues_unittest.py:
774
775 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
776
777         Unreviewed, rolling out r75464.
778         http://trac.webkit.org/changeset/75464
779         https://bugs.webkit.org/show_bug.cgi?id=52193
780
781         Followup rollout for 75474 (Requested by Ossy on #webkit).
782
783         * MiniBrowser/mac/BrowserWindowController.m:
784         (-[BrowserWindowController awakeFromNib]):
785         * MiniBrowser/win/BrowserView.cpp:
786         (BrowserView::create):
787         * WebKitTestRunner/TestController.cpp:
788         (WTR::createOtherPage):
789         (WTR::TestController::initialize):
790
791 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
792
793         Reviewed by Csaba Osztrogonác.
794
795         [Qt] Baseline qt_minimal configuration
796         https://bugs.webkit.org/show_bug.cgi?id=51313
797
798         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
799         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
800         QT_NO_UNDOSTACK guard.
801
802         * QtTestBrowser/launcherwindow.cpp:
803         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
804         guards.
805         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
806         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
807         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
808         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
809
810         * QtTestBrowser/launcherwindow.h:
811         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
812         * QtTestBrowser/locationedit.h: Ditto.
813
814         * QtTestBrowser/mainwindow.cpp:
815         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
816         QT_NO_UNDOSTACK guards.
817         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
818         (MainWindow::changeLocation): Ditto.
819         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
820         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
821
822         * QtTestBrowser/webpage.cpp:
823         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
824         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
825
826         * QtTestBrowser/webview.cpp:
827         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
828         (WebViewGraphicsBased::animatedYFlip): Ditto.
829
830 2011-01-10  Sam Weinig  <sam@webkit.org>
831
832         Fix build.
833
834         * MiniBrowser/mac/BrowserWindowController.m:
835         (-[BrowserWindowController awakeFromNib]):
836         * MiniBrowser/win/BrowserView.cpp:
837         (BrowserView::create):
838         * WebKitTestRunner/TestController.cpp:
839         (WTR::createOtherPage):
840         (WTR::TestController::initialize):
841
842 2011-01-10  Eric Seidel  <eric@webkit.org>
843
844         Reviewed by Ojan Vafai.
845
846         style-queue messages are way too long for big patches
847         https://bugs.webkit.org/show_bug.cgi?id=52161
848
849         We definitely could build much fancier list-to-string-with-limit functions
850         but this should be sufficient for our needs at the moment.
851
852         * Scripts/webkitpy/common/system/executive.py:
853         * Scripts/webkitpy/common/system/executive_unittest.py:
854
855 2011-01-10  Tony Chang  <tony@chromium.org>
856
857         Unreviewed, rolling out r75398.
858         http://trac.webkit.org/changeset/75398
859         https://bugs.webkit.org/show_bug.cgi?id=52008
860
861         Some layout tests are crashing on Chromium Win.
862
863         * DumpRenderTree/chromium/WebViewHost.cpp:
864         (WebViewHost::updatePaintRect):
865         * DumpRenderTree/chromium/WebViewHost.h:
866
867 2011-01-10  Adam Roben  <aroben@apple.com>
868
869         Roll out r75392
870
871         It isn't needed now that r75289 has been rolled out.
872
873         * Scripts/run-javascriptcore-tests:
874
875 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
876
877         Reviewed by Anders Carlsson.
878
879         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
880         https://bugs.webkit.org/show_bug.cgi?id=52160
881
882         * WebKitTestRunner/mac/TestControllerMac.mm:
883         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
884         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
885         anyway.
886
887 2011-01-10  Tony Chang  <tony@chromium.org>
888
889         Reviewed by Mihai Parparita.
890
891         [chromium] fix for animated gif layout tests
892         https://bugs.webkit.org/show_bug.cgi?id=52008
893
894         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
895             to trigger gif animations.
896         (WebViewHostPaintTask::WebViewHostPaintTask):
897         (WebViewHostPaintTask::runIfValid):
898         (WebViewHost::updatePaintRect):
899         * DumpRenderTree/chromium/WebViewHost.h:
900         (WebViewHost::taskList):
901
902 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
903
904         Reviewed by Xan Lopez.
905
906         [GTK] Fix gtk2 compilation for master
907         https://bugs.webkit.org/show_bug.cgi?id=51885
908
909         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
910         (createBitmapContextFromWebView): Replaced the old
911         gdk_drawable_get_size with gdk_pixmap_get_size.
912
913 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
914
915         Reviewed by Laszlo Gombos.
916
917         [WINCE] Reenable NPAPI after r75203
918         https://bugs.webkit.org/show_bug.cgi?id=52109
919
920         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
921         it with !isEfl(), because EFL port does not support NPAPI (yet).
922
923         * Scripts/build-webkit:
924
925 2011-01-10  Adam Roben  <aroben@apple.com>
926
927         Skip some asserting JS tests
928
929         See <http://webkit.org/b/52156>.
930
931         * Scripts/run-javascriptcore-tests:
932
933 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
934
935         Reviewed by Xan Lopez.
936
937         [GTK] build-webkit disable Blob support via arguments passed to automake
938         https://bugs.webkit.org/show_bug.cgi?id=52097
939
940         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
941         build-webkit.
942
943 2011-01-10  Adam Roben  <aroben@apple.com>
944
945         Use the same name and description for TestNetscapePlugin on Windows and
946         Mac
947
948         Fixes <http://webkit.org/b/52151>
949         fast/frames/iframe-reparenting-plugins.html fails on Windows
950
951         Reviewed by Steve Falkenburg.
952
953         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
954         the name and description from Mac's Info.plist.
955
956 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
957
958         Reviewed by Laszlo Gombos.
959
960         [Qt][WK2] Guard gcc-specific syntax
961
962         Non-gcc based compliers choke on the "-include"
963         syntax for preinclude, place guard around it.
964
965         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
966         * WebKitTestRunner/qt/WebKitTestRunner.pro:
967
968 2011-01-10  Andreas Kling  <kling@webkit.org>
969
970         Reviewed by Simon Hausmann.
971
972         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
973         https://bugs.webkit.org/show_bug.cgi?id=52111
974
975         When getting a createNewPage() callback from QWKPage, create the
976         new page with the same QWKContext as the page that is passed to
977         the callback.
978
979         * MiniBrowser/qt/BrowserView.h:
980         * MiniBrowser/qt/BrowserWindow.cpp:
981         (newPageFunction):
982         (BrowserWindow::BrowserWindow):
983         * MiniBrowser/qt/BrowserWindow.h:
984
985 2011-01-10  Andreas Kling  <kling@webkit.org>
986
987         Reviewed by Kenneth Rohde Christiansen.
988
989         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
990
991         BrowserView set its own useless createNewPage() callback on QWKPage.
992         This was immediately overridden by BrowserWindow anyway, so remove
993         the BrowserView one.
994
995         * MiniBrowser/qt/BrowserView.cpp:
996         (BrowserView::BrowserView):
997
998 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
999
1000         Reviewed by Jeremy Orlow.
1001
1002         [Chromium] Remove non-client-based Geolocation code
1003         https://bugs.webkit.org/show_bug.cgi?id=50921
1004
1005         * DumpRenderTree/chromium/LayoutTestController.cpp:
1006         (LayoutTestController::setGeolocationPermission):
1007         (LayoutTestController::setMockGeolocationPosition):
1008         (LayoutTestController::setMockGeolocationError):
1009         * DumpRenderTree/chromium/WebViewHost.cpp:
1010         (WebViewHost::geolocationClientMock):
1011         (WebViewHost::reset):
1012         * DumpRenderTree/chromium/WebViewHost.h:
1013
1014 2011-01-10  Eric Seidel  <eric@webkit.org>
1015
1016         Reviewed by Adam Barth.
1017
1018         Commit bot tried to land r? cq+ patch
1019         https://bugs.webkit.org/show_bug.cgi?id=36638
1020
1021         It should now be possible to post a patch with r? and cq+ and the
1022         commit-queue will correctly wait for the r+ before attempting to land the patch.
1023         (This was a feature requested by several users.)
1024
1025         One caveat: We don't actually reject r-, cq+ patches from the queue
1026         (we just ignore them), but I think that's OK for now.
1027
1028         I also noticed that setting r- once a commit-queue node had grabbed
1029         a patch would not properly cancel the landing.  That's fixed and
1030         tested in this patch.
1031
1032         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1033         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1034         * Scripts/webkitpy/tool/bot/feeders.py:
1035         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1036
1037 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1038
1039         Reviewed by Kenneth Rohde Christiansen.
1040
1041         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1042         https://bugs.webkit.org/show_bug.cgi?id=51934
1043
1044         When accessing the network from the destructor of QWebPage, the network access manager
1045         was already deleted because the object WebPage was already destructed.
1046
1047         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1048         The object is now destructed in the destructor of QObject.
1049
1050         * QtTestBrowser/webpage.cpp:
1051         (WebPage::WebPage):
1052         (WebPage::setQnamThreaded):
1053         * QtTestBrowser/webpage.h:
1054         (QtNAMThread::QtNAMThread):
1055
1056 2011-01-08  Eric Seidel  <eric@webkit.org>
1057
1058         Reviewed by Ojan Vafai.
1059
1060         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1061         https://bugs.webkit.org/show_bug.cgi?id=52067
1062
1063         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1064         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1065
1066         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1067
1068 2011-01-08  Eric Seidel  <eric@webkit.org>
1069
1070         Reviewed by Mihai Parparita.
1071
1072         commit-queue hangs when the ChangeLog diff is bad
1073         https://bugs.webkit.org/show_bug.cgi?id=52072
1074
1075         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1076         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1077
1078 2011-01-08  Adam Barth  <abarth@webkit.org>
1079
1080         Teach svn-apply how to re-write WebCore to Source/WebCore.
1081
1082         * Scripts/VCSUtils.pm:
1083
1084 2011-01-07  Adam Barth  <abarth@webkit.org>
1085
1086         Rubber-stamped by Eric Seidel.
1087
1088         Move WebCore to Source
1089         https://bugs.webkit.org/show_bug.cgi?id=52050
1090
1091         Update the tools to understand WebCore's new location.
1092
1093         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1094         * DumpRenderTree/wscript:
1095         * GNUmakefile.am:
1096         * Scripts/build-webkit:
1097         * Scripts/do-file-rename:
1098         * Scripts/do-webcore-rename:
1099         * Scripts/generate-qt-inspector-resource:
1100         * Scripts/prepare-ChangeLog:
1101         * Scripts/run-bindings-tests:
1102         * Scripts/update-iexploder-cssproperties:
1103         * Scripts/update-sources-list.py:
1104         * Scripts/update-webkit-localizable-strings:
1105         * Scripts/webkitdirs.pm:
1106         * Scripts/webkitpy/common/config/build.py:
1107         * Scripts/webkitpy/common/config/build_unittest.py:
1108         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1109         * Scripts/webkitpy/style/checker.py:
1110         * Scripts/webkitpy/style/checker_unittest.py:
1111         * WebKitTestRunner/DerivedSources.pro:
1112         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1113         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1114         * wx/browser/wscript:
1115         * wx/build/settings.py:
1116
1117 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1118
1119         Reviewed by Sam Weinig.
1120
1121         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1122         https://bugs.webkit.org/show_bug.cgi?id=52086
1123
1124         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1125         (WTR::InjectedBundle::didReceiveMessage):
1126         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1127         (WTR::LayoutTestController::notifyDone):
1128         * WebKitTestRunner/TestController.cpp:
1129         (WTR::TestController::resetStateToConsistentValues):
1130         (WTR::TestController::run):
1131
1132 2011-01-07  James Robinson  <jamesr@chromium.org>
1133
1134         Revert "Implement mozilla's animationTime property"
1135         https://bugs.webkit.org/show_bug.cgi?id=51952
1136
1137         This approach isn't quite right.
1138
1139         * DumpRenderTree/chromium/WebViewHost.cpp:
1140         (WebViewHost::paintInvalidatedRegion):
1141
1142 2011-01-07  Adam Roben  <aroben@apple.com>
1143
1144         Build master fix
1145
1146         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1147         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1148
1149 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1150
1151         Reviewed by Csaba Osztrogonác.
1152
1153         run-qtwebkit-tests should be able to kill a testsuite.
1154
1155         Add new option in the script that can setup a timeout for a test.
1156         If the test execution takes more then specified time then the test
1157         would be terminated.
1158
1159         [Qt] run-qtwebkit-tests needs timeout
1160         https://bugs.webkit.org/show_bug.cgi?id=51894
1161
1162         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1163         * Scripts/run-qtwebkit-tests:
1164
1165 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1166
1167         Unreviewed fix after r75233.
1168
1169         Based on idea from Eric Seidel.
1170
1171         Add remote zip file handling to webkitpy.
1172         https://bugs.webkit.org/show_bug.cgi?id=50901
1173
1174         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1175
1176 2011-01-07  Shane Stephens  <shanestephens@google.com>
1177
1178         Reviewed by Eric Seidel.
1179
1180         svn-apply: should support git binary delta diffs
1181         https://bugs.webkit.org/show_bug.cgi?id=38864
1182
1183         * Scripts/VCSUtils.pm:
1184         * Scripts/svn-apply:
1185
1186 2011-01-06  Julie Parent  <jparent@chromium.org>
1187
1188         Reviewed by Eric Seidel.
1189
1190         Test Result Server not removing old results.
1191         https://bugs.webkit.org/show_bug.cgi?id=52012
1192
1193         * TestResultServer/model/jsonresults.py:
1194         Fix off-by-one: Truncate if >= num_runs, not just >.
1195         * TestResultServer/model/jsonresults_unittest.py:
1196         Add unit test to test that merging in a new result with the same value
1197         as the last result causes previous result to fall off.
1198
1199 2011-01-06  James Kozianski  <koz@chromium.org>
1200
1201         Reviewed by Mihai Parparita.
1202
1203         Add classes to provide a consistent interface to a set of files.
1204         https://bugs.webkit.org/show_bug.cgi?id=50901
1205
1206         These classes allow us to write code that is agnostic to whether a
1207         particular set of files resides in a local directory or in a zip file
1208         on a remote machine.
1209
1210         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1211         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1212         * Scripts/webkitpy/common/system/fileset.py: Added.
1213         * Scripts/webkitpy/common/system/filesystem.py:
1214         * Scripts/webkitpy/common/system/filesystem_mock.py:
1215         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1216         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1217
1218 2011-01-06  Eric Seidel  <eric@webkit.org>
1219
1220         Reviewed by Adam Barth.
1221
1222         NetworkTransaction should log the url it is retrying
1223         https://bugs.webkit.org/show_bug.cgi?id=52043
1224
1225         * Scripts/webkitpy/common/net/networktransaction.py:
1226         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1227
1228 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1229
1230         Windows build fix.
1231         Import os before using it.
1232
1233         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1234
1235 2011-01-06  Eric Seidel  <eric@webkit.org>
1236
1237         Reviewed by Adam Barth.
1238
1239         StyleQueue fails to report errors when patches have many files
1240         https://bugs.webkit.org/show_bug.cgi?id=52042
1241
1242         This is one of at least two errors preventing style error reporting at the moment.
1243         When we moved to passing the list of files to check explicitly,
1244         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1245         We could change the type of the QueueStatus.message type, or we could
1246         just teach statusserver.py how to clamp values (and warn when it does).
1247         I chose the latter path.
1248
1249         * Scripts/webkitpy/common/net/statusserver.py:
1250
1251 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1252
1253         Reviewed by Stephanie Lewis.
1254         
1255         Fix syntax error in script.
1256
1257         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1258         https://bugs.webkit.org/show_bug.cgi?id=51996
1259
1260         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1261
1262 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1263
1264         Unreviewed, fixing WinCE build after r75196.
1265
1266         WinCE port does not (yet) support NPAPI.
1267
1268         * Scripts/build-webkit:
1269
1270 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1271
1272         Reviewed by Darin Adler.
1273
1274         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1275         https://bugs.webkit.org/show_bug.cgi?id=52015
1276
1277         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1278         after the platform has been detected, otherwise the script will
1279         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1280         detection.
1281
1282 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1283
1284         Reviewed by Eric Seidel.
1285
1286         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1287         https://bugs.webkit.org/show_bug.cgi?id=51346
1288
1289         * Scripts/build-webkit:
1290
1291 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1292
1293         Reviewed by Adam Roben.
1294
1295         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1296         https://bugs.webkit.org/show_bug.cgi?id=51996
1297         
1298         After the configuration directory change, we were archiving the incorrect directory for
1299         build product, so we were running tests on the wrong binaries.
1300         
1301         This change archives the correct directory, and also unarchives it into a configuration-
1302         specific directory.
1303
1304         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1305         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1306
1307 2011-01-06  Eric Seidel  <eric@webkit.org>
1308
1309         Reviewed by Mihai Parparita.
1310
1311         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1312         https://bugs.webkit.org/show_bug.cgi?id=52002
1313
1314         See an example of this here:
1315         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1316
1317         It's due to the fact that we pass around TestFailure() instance
1318         objects and yet expect them to all compare to be the same.
1319
1320         This is bad.  We should either have shared instances of these values
1321         or we should just pass around the class names.  There are already hacks
1322         in place to make TestFailure objects pass equality tests, I just added
1323         a __hash__ implementation so they can be used in sets as expected.
1324
1325         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1326         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1327
1328 2011-01-06  Evan Martin  <evan@chromium.org>
1329
1330         Reviewed by Tony Chang.
1331
1332         [gdb] handle inaccessible memory and UChar*
1333         https://bugs.webkit.org/show_bug.cgi?id=52003
1334
1335         To pretty-print a UChar*, we just grope around in the memory
1336         looking for a terminating NUL.  We need to handle the exception
1337         that can occur when we poke into an invalid location.
1338
1339         Additionally, the logic for choosing which pretty-printer would
1340         early return before hitting the point where we'd use the UChar*
1341         printer.  (Did this ever work?  How did it regress?)
1342
1343         * gdb/webkit.py:
1344
1345 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1346
1347         Reviewed by Ada Chan.
1348
1349         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1350         https://bugs.webkit.org/show_bug.cgi?id=51969
1351         
1352         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1353
1354         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1355         (WTR::InjectedBundlePage::InjectedBundlePage):
1356         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1357         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1358
1359 2011-01-06  James Robinson  <jamesr@chromium.org>
1360
1361         Reviewed by Simon Fraser.
1362
1363         Implement mozilla's animationTime property
1364         https://bugs.webkit.org/show_bug.cgi?id=51952
1365
1366         Chromium DRT support for webkitAnimationTime.
1367
1368         * DumpRenderTree/chromium/WebViewHost.cpp:
1369         (WebViewHost::paintInvalidatedRegion):
1370
1371 2011-01-06  Julie Parent  <jparent@chromium.org>
1372
1373         Reviewed by Tony Chang.
1374
1375         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1376         https://bugs.webkit.org/show_bug.cgi?id=51217
1377
1378         * TestResultServer/model/jsonresults.py:
1379         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1380         Adds missing documentation.
1381         * TestResultServer/model/jsonresults_unittest.py:
1382         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1383         Update test_merge to take a number of builds to truncate at.
1384
1385 2011-01-06  Adam Barth  <abarth@webkit.org>
1386
1387         Reviewed by Eric Seidel.
1388
1389         The EWS should log outside of the working directory
1390         https://bugs.webkit.org/show_bug.cgi?id=51986
1391
1392         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1393         script, which will actually clean the working copy back to a pristine
1394         state instead of leaving untracked directories and ignored files.
1395
1396         * Scripts/webkitpy/tool/commands/queues.py:
1397         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1398
1399 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1400
1401         Windows build fix.
1402         Back out attempted change to built-product-archive.
1403
1404         * BuildSlaveSupport/built-product-archive:
1405
1406 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1407
1408         Windows build fix.
1409         Include configuration name when unpacking a build archive.
1410
1411         Needed, since we split Windows build results into configuration-specific directories
1412         under WebKitOutputDir.
1413
1414         * BuildSlaveSupport/built-product-archive:
1415
1416 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1417
1418         Reviewed by Darin Adler.
1419
1420         Debug and Release builds on Windows clobber each other
1421         https://bugs.webkit.org/show_bug.cgi?id=49185
1422
1423         Changes the structure of WebKitBuild build products directory so we
1424         completely separate each build configuration into independent directories.
1425         
1426         Although we previously had per-configuration directories for obj, this change adds
1427         per-configuration directories for bin, lib, obj, and include. Each configuration's
1428         build products are stored within a directory inside of WebKitBuild.
1429         
1430         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1431         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1432
1433         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1434         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1435         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1436         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1437         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1438         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1439         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1440         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1441         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1442         * FindSafari/FindSafari.vcproj:
1443         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1444         * MiniBrowser/MiniBrowserPostBuild.cmd:
1445         * MiniBrowser/MiniBrowserPreBuild.cmd:
1446         * Scripts/webkitdirs.pm:
1447         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1448         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1449         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1450         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1451         * TestWebKitAPI/win/copy-resources.cmd:
1452         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1453         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1454         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1455         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1456         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1457         * WebKitTestRunner/win/InjectedBundle.vcproj:
1458         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1459         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1460         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1461         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1462         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1463         * WinLauncher/WinLauncherCommon.vsprops:
1464         * WinLauncher/WinLauncherPostBuild.cmd:
1465         * WinLauncher/WinLauncherPreBuild.cmd:
1466
1467 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1468
1469         Reviewed by Ariya Hidayat.
1470
1471         [Qt] TestNetscapePlugin doesn't link on OS X
1472         https://bugs.webkit.org/show_bug.cgi?id=51948
1473
1474         Only add a dependency on libX11 on X11 systems
1475
1476         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1477
1478 2011-01-05  Jeff Miller  <jeffm@apple.com>
1479
1480         Reviewed by Adam Roben.
1481
1482         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1483         https://bugs.webkit.org/show_bug.cgi?id=51970
1484
1485         * Scripts/webkitpy/style/checker.py:
1486         Add -readability/naming for WebKit2 C API directories.
1487
1488 2011-01-05  Eric Seidel  <eric@webkit.org>
1489
1490         Unreviewed, just fixing one more log error from my previous python patch.
1491
1492         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1493         https://bugs.webkit.org/show_bug.cgi?id=51802
1494
1495         webkit-patch failure-reason was logging about parsing errors
1496         due to my misunderstanding of how BeautifulSoup.findAll worked.
1497
1498         Fixed, and added a unit test.
1499
1500         * Scripts/webkitpy/common/net/layouttestresults.py:
1501         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1502
1503 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1504
1505         Reviewed by Kenneth Rohde Christiansen.
1506
1507         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1508         https://bugs.webkit.org/show_bug.cgi?id=51951
1509
1510         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1511         to create new window from WebKit.
1512
1513         * MiniBrowser/qt/BrowserWindow.cpp:
1514         (newPageFunction):
1515         (BrowserWindow::BrowserWindow):
1516         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1517         (BrowserWindow::newWindow):
1518         (BrowserWindow::updateUserAgentList):
1519         (BrowserWindow::showUserAgentDialog):
1520         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1521         define the type of the backing store used for new windows.
1522         * MiniBrowser/qt/main.cpp:
1523         (main):
1524
1525 2011-01-05  Eric Seidel  <eric@webkit.org>
1526
1527         Reviewed by Ojan Vafai.
1528
1529         commit-queue should report failure type when reporting flaky tests
1530         https://bugs.webkit.org/show_bug.cgi?id=51900
1531
1532         This patch was a ridiculous amount of plumbing.  In the end I like
1533         the NRWT-style TestResult class even less.  But now we're passing
1534         a list of TestResult objects from the queue to the FlakyTestReporter.
1535         Thus the FlakyTestReporter can more easily report what type of failure
1536         occurred.
1537
1538         In the process, I found that I was not alone in finding TestResult
1539         cumbersome to use.  A bunch of code was trying to create a TestResult
1540         object with default values.  However since the constructor didn't make
1541         this easy, some places were getting it wrong (including the TestResult unit test)!
1542         I've fixed the TestResult constructor to have default values for non-essential
1543         arguments.
1544
1545         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1546         * Scripts/webkitpy/common/net/layouttestresults.py:
1547         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1548         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1549         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1550         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1551         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1552         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1553         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1554         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1555         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1556         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1557         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1558         * Scripts/webkitpy/tool/commands/queues.py:
1559         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1560
1561 2011-01-05  Eric Seidel  <eric@webkit.org>
1562
1563         Unreviewed.
1564
1565         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1566         https://bugs.webkit.org/show_bug.cgi?id=51802
1567
1568         Add another unit test to cover a previously missing import.
1569
1570         * Scripts/webkitpy/common/net/layouttestresults.py:
1571         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1572
1573 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1574
1575         Reviewed by David Levin.
1576
1577         Add mihaip@chromium.org as a reviewer
1578         https://bugs.webkit.org/show_bug.cgi?id=51966
1579         
1580         Add myself as a reviewer.
1581
1582         * Scripts/webkitpy/common/config/committers.py:
1583
1584 2011-01-05  James Simonsen  <simonjam@chromium.org>
1585
1586         Unreviewed. Adding myself to the list of committers.
1587
1588         * Scripts/webkitpy/common/config/committers.py:
1589
1590 2011-01-05  Eric Seidel  <eric@webkit.org>
1591
1592         Unreviewed.
1593
1594         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1595         https://bugs.webkit.org/show_bug.cgi?id=51802
1596
1597         Fix two exceptions seen on the bots after my original commit.
1598
1599         * Scripts/webkitpy/common/net/layouttestresults.py:
1600         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1601
1602 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1603
1604         Reviewed by Andreas Kling.
1605
1606         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1607         https://bugs.webkit.org/show_bug.cgi?id=51750
1608
1609         * QtTestBrowser/main.cpp:
1610         (LauncherApplication::handleUserOptions):
1611          Local storage settings can be enable form command line arguments for
1612          QtTestBrowser.
1613
1614 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1615
1616         Reviewed by Martin Robinson.
1617
1618         GTK: AX: DRT needs to use correct root object method.
1619         https://bugs.webkit.org/show_bug.cgi?id=51911
1620
1621         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1622         (AccessibilityController::rootElement):
1623
1624 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1625
1626         Rubber-stamped by Csaba Osztrogonác.
1627
1628         Based on idea from Péter Gál.
1629
1630         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1631
1632 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1633
1634         Reviewed by Adam Barth.
1635
1636         sheriff-bot should be able to do multi-revision rollouts
1637         https://bugs.webkit.org/show_bug.cgi?id=51176
1638
1639         * Scripts/webkitpy/tool/bot/irc_command.py:
1640         * Scripts/webkitpy/tool/bot/sheriff.py:
1641         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1642
1643 2011-01-05  Eric Seidel  <eric@webkit.org>
1644
1645         Reviewed by Adam Barth.
1646
1647         queues.webkit.org should have per-bot status pages
1648         https://bugs.webkit.org/show_bug.cgi?id=51906
1649
1650         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1651         statuses from a single queue.  Now that we have many bots servicing
1652         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1653         you care about scroll off the end of the 15-message limit on the main page.
1654
1655         Eventually we should probably rename /queue-status to /queue or /queues,
1656         but that's fodder for another patch.
1657
1658         * QueueStatusServer/handlers/queuestatus.py:
1659         * QueueStatusServer/index.yaml:
1660         * QueueStatusServer/main.py:
1661         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1662          - This probably should use a custom filter instead of hard-coding
1663            the URL scheme here, but I couldn't figure out how to easily
1664            create such a filter.  Most filters work with "strings" so we can't
1665            pass the status object.  We could add a method to the status
1666            object and call that, but that seemed a bit strange too.
1667         * QueueStatusServer/templates/queuestatus.html:
1668
1669 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1670
1671         Unreviewed. Adding myself to the list of committers.
1672
1673         * Scripts/webkitpy/common/config/committers.py:
1674
1675 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1676
1677         Reviewed by David Levin.
1678
1679         check-webkit-style treated some macros with parentheses after #elif as function calls
1680         https://bugs.webkit.org/show_bug.cgi?id=51695
1681
1682         Ingore function call space checking in any preprocessor directives
1683         (things starting with #). Change search() to match() because 
1684         preprocessor directives are supposed to be in the beginning of lines.
1685
1686         * Scripts/webkitpy/style/checkers/cpp.py:
1687         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1688
1689 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1690
1691         Reviewed by Tony Chang.
1692
1693         Change the --multi-load test option to --stress-opt
1694         https://bugs.webkit.org/show_bug.cgi?id=50751
1695
1696         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1697         (runTest):
1698         (main):
1699         * DumpRenderTree/chromium/TestShell.cpp:
1700         (TestShell::TestShell):
1701         * DumpRenderTree/chromium/TestShell.h:
1702         (TestShell::stressOpt):
1703         (TestShell::setStressOpt):
1704         (TestShell::stressDeopt):
1705         (TestShell::setStressDeopt):
1706         (TestShell::javaScriptFlags):
1707         (TestShell::setJavaScriptFlags):
1708         * Scripts/webkitpy/layout_tests/port/chromium.py:
1709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1710
1711 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1712
1713         Reviewed by Sam Weinig.
1714
1715         WK2: Support Accessibility
1716         https://bugs.webkit.org/show_bug.cgi?id=51859
1717
1718         Use rootObject() method to get top of accessibility tree.
1719
1720         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1721         (AccessibilityController::focusedElement):
1722         (AccessibilityController::rootElement):
1723
1724 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1725
1726         Reviewed by Darin Adler.
1727
1728         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1729         https://bugs.webkit.org/show_bug.cgi?id=51846
1730
1731         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1732         back to GRefPtr.
1733
1734 2011-01-04  Zhe Su  <suzhe@chromium.org>
1735
1736         Reviewed by Kenneth Russell.
1737
1738         Fix insertText, setMarkedText and unmarkText methods of
1739         TextInputController to call corresponding methods of WebKit::WebView
1740         rather than WebKit::WebFrame. This change matches the behavior of
1741         chromium browser.
1742         insertText corresponds to WebView::confirmComposition(text)
1743         setMarkedText corresponds to WebView::setComposition(...)
1744         unmarkText corresponds to WebView::confirmComposition()
1745         https://bugs.webkit.org/show_bug.cgi?id=51693
1746
1747         * DumpRenderTree/chromium/TextInputController.cpp:
1748         (TextInputController::insertText):
1749         (TextInputController::setMarkedText):
1750         (TextInputController::unmarkText):
1751
1752 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1753
1754         Reviewed by Laszlo Gombos.
1755
1756         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1757
1758         On Symbian productDir points to the source directory. Removing all the
1759         empty files from the productDir directory corrupts the svn repository.
1760
1761         * Scripts/build-webkit:
1762
1763 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1764
1765         Reviewed by Adam Barth.
1766
1767         [Qt] Add SelectAll option to the context menu for the editor
1768         https://bugs.webkit.org/show_bug.cgi?id=50049
1769
1770         Set shortcut for the SelectAll action.
1771
1772         * QtTestBrowser/mainwindow.cpp:
1773         (MainWindow::buildUI):
1774
1775 2011-01-03  David Levin  <levin@chromium.org>
1776
1777         Reviewed by Eric Seidel.
1778
1779         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1780         https://bugs.webkit.org/show_bug.cgi?id=51842
1781
1782         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1783         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1784
1785 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1786
1787         Reviewed by David Kilzer.
1788
1789         [WINCE] Adds a build slave.
1790         https://bugs.webkit.org/show_bug.cgi?id=50523
1791
1792         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1793         entry for a release build of the WinCE port.
1794         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1795         flag to build the WinCE port.
1796
1797 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1798
1799         Reviewed by David Kilzer.
1800
1801         Add WinCE support to build-webkit
1802         https://bugs.webkit.org/show_bug.cgi?id=51642
1803
1804         * Scripts/build-webkit:
1805         * Scripts/webkitdirs.pm:
1806
1807 2011-01-03  Eric Seidel  <eric@webkit.org>
1808
1809         Reviewed by Adam Barth.
1810
1811         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1812         https://bugs.webkit.org/show_bug.cgi?id=51802
1813
1814         I'm not the biggest fan of the test_failures or test_results classes,
1815         but it's better to have one shared set of classes, than separate ones
1816         for new vs. old run-webkit-test result handling.
1817
1818         This moves the ORWT results class "LayoutTestResults" over to using
1819         TestResult and TestFailure classes, making it easy for us to
1820         make all our sheriff-bot and other webkitpy code NRWT ready.
1821
1822         This also makes it a trivial patch to generate results.json information
1823         from ORWT results.html files (for flaky test analysis, etc.) as well
1824         as making it a one-liner to report test failure types when the
1825         commit-queue sees flaky tests.
1826
1827         This patch tried not to add new functionality, but only to replace
1828         the guts of LayoutTestResults, while adding unit tests and hoping
1829         not to break anything.
1830
1831         I also moved callers which assumed User.prompt* were static/class methods
1832         to using them as instance methods (since we'll eventually want to make them such).
1833
1834         In the process of re-writing things, I broke the rebaseline command, so I wrote
1835         a unit test to catch my breakage were I do do so again in the future.
1836
1837         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1838         * Scripts/webkitpy/common/net/layouttestresults.py:
1839         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1840         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1841         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1842         * Scripts/webkitpy/tool/commands/queries.py:
1843         * Scripts/webkitpy/tool/commands/rebaseline.py:
1844         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1845         * Scripts/webkitpy/tool/mocktool.py:
1846
1847 2011-01-03  Adam Barth  <abarth@webkit.org>
1848
1849         Reviewed by Simon Fraser.
1850
1851         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1852         https://bugs.webkit.org/show_bug.cgi?id=51840
1853
1854         * Scripts/webkitpy/common/checkout/scm.py:
1855
1856 2011-01-03  Adam Barth  <abarth@webkit.org>
1857
1858         Reviewed by Simon Fraser.
1859
1860         webkit-patch should only hide update output if --quiet
1861         https://bugs.webkit.org/show_bug.cgi?id=51838
1862
1863         As requested by smfr.
1864
1865         * Scripts/webkitpy/tool/steps/update.py:
1866
1867 2011-01-03  Adam Barth  <abarth@webkit.org>
1868
1869         Reviewed by David Levin.
1870
1871         commit-queue shouldn't reject patches twice if two bots process the same patch
1872         https://bugs.webkit.org/show_bug.cgi?id=51805
1873
1874         Before raising an error, we first check whether the patch is still in
1875         the commit-queue.  This check is still racy, of course, but the time
1876         window is much smaller.
1877
1878         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1879
1880 2011-01-03  Sam Weinig  <sam@webkit.org>
1881
1882         Reviewed by Anders Carlsson.
1883
1884         Make run-api-tests less chatty.
1885         https://bugs.webkit.org/show_bug.cgi?id=51831
1886
1887         - Make script quiet by default and add --verbose option (replacing --quiet).
1888         - When not verbose, pipe stdout and stderr to devnull.
1889
1890         * Scripts/run-api-tests:
1891
1892 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1893
1894         Unreviewed. Adding myself to committers.py.
1895
1896         * Scripts/webkitpy/common/config/committers.py:
1897
1898 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1899
1900         Reviewed by Xan Lopez.
1901
1902         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1903         https://bugs.webkit.org/show_bug.cgi?id=51806
1904
1905         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1906         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1907         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1908         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1909         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1910         so make it 'WebKitBuild/Release/.libs'
1911
1912         * Scripts/webkitdirs.pm: 
1913
1914 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1915
1916         Reviewed by Adam Barth.
1917
1918         Make EFL a core builder
1919         https://bugs.webkit.org/show_bug.cgi?id=51804
1920
1921         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1922         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1923
1924 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1925
1926         [Qt] Unreviewed fix after r74855 and r74875.
1927
1928         * BuildSlaveSupport/built-product-archive:
1929          - Create directories explicitly.
1930          - Pass shell=True to subprocess.call().
1931
1932 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1933
1934         [Qt] Unreviewed fix after r74855.
1935
1936         Move JavaScriptCore to Source
1937         https://bugs.webkit.org/show_bug.cgi?id=51604
1938
1939         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1940
1941 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1942
1943         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1944
1945         Move JavaScriptCore to Source
1946         https://bugs.webkit.org/show_bug.cgi?id=51604
1947
1948         * Scripts/webkitdirs.pm:
1949
1950 2011-01-02  Robert Hogan  <robert@webkit.org>
1951
1952         Unreviewed, build fix.
1953
1954         [Qt] Fix DRT build after 74855
1955
1956         * DumpRenderTree/qt/DumpRenderTree.pro:
1957
1958 2011-01-01  Adam Barth  <abarth@webkit.org>
1959
1960         Remove the assumption from the Qt and Gtk builds that every project is
1961         in the root directory.
1962
1963         * Scripts/build-webkit:
1964
1965 2011-01-01  Adam Barth  <abarth@webkit.org>
1966
1967         Reviewed by Eric Seidel.
1968
1969         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1970         https://bugs.webkit.org/show_bug.cgi?id=51796
1971
1972         After this change, svn-apply will magically apply patches to
1973         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1974
1975         * Scripts/VCSUtils.pm:
1976
1977 2011-01-01  Adam Barth  <abarth@webkit.org>
1978
1979         Reviewed by Eric Seidel.
1980
1981         Move JavaScriptCore to Source
1982         https://bugs.webkit.org/show_bug.cgi?id=51604
1983
1984         Update references to JavaScriptCore to point to the new location.
1985
1986         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1987         * DumpRenderTree/qt/DumpRenderTree.pro:
1988         * DumpRenderTree/qt/ImageDiff.pro:
1989         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1990         * DumpRenderTree/wscript:
1991         * Scripts/build-jsc:
1992         * Scripts/build-webkit:
1993         * Scripts/do-file-rename:
1994         * Scripts/do-webcore-rename:
1995         * Scripts/run-javascriptcore-tests:
1996         * Scripts/update-javascriptcore-test-results:
1997         * Scripts/webkitdirs.pm:
1998         * Scripts/webkitpy/common/config/build_unittest.py:
1999         * Scripts/webkitpy/style/checker.py:
2000         * Scripts/webkitpy/style/checker_unittest.py:
2001         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2002         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2003         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2004         * wx/build/settings.py:
2005
2006 2011-01-01  Adam Barth  <abarth@webkit.org>
2007
2008         Reviewed by Eric Seidel.
2009
2010         Move Sources to Source
2011         https://bugs.webkit.org/show_bug.cgi?id=51794
2012
2013         Update scripts to point to the new location.
2014
2015         * Scripts/build-webkit:
2016         * Scripts/do-file-rename:
2017         * Scripts/do-webcore-rename:
2018         * Scripts/webkitpy/common/config/build.py:
2019         * Scripts/webkitpy/common/config/build_unittest.py:
2020
2021 2010-12-31  Kent Tamura  <tkent@chromium.org>
2022
2023         Reviewed by Eric Seidel.
2024
2025         [DRT/Chromium] Enable mock spell checker on non-OSX
2026         https://bugs.webkit.org/show_bug.cgi?id=51401
2027
2028         * DumpRenderTree/chromium/WebViewHost.cpp:
2029         (WebViewHost::spellCheck):
2030
2031 2010-12-31  Adam Barth  <abarth@webkit.org>
2032
2033         Reviewed by Ariya Hidayat.
2034
2035         Remove Tools/Scripts/wkstyle
2036         https://bugs.webkit.org/show_bug.cgi?id=51774
2037
2038         This script appears to not have been touched in a while and seems to
2039         have been replaced by check-webkit-style.
2040
2041         * Scripts/wkstyle: Removed.
2042
2043 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2044
2045         Unreviewed. Coding style fix.
2046
2047         * DumpRenderTree/chromium/TestShell.h:
2048
2049 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2050
2051         Reviewed by Pavel Feldman.
2052
2053         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2054
2055         It was a problem with Chromium DRT. DevToolsAgent object instance was
2056         attached not only to the inspected page but to the DevTools window too.
2057         As result all the inspector files were interpreted as a content of inspected page
2058         and were transfered to the DevTools scripts panel for debugging etc.
2059
2060         https://bugs.webkit.org/show_bug.cgi?id=51735
2061
2062         * DumpRenderTree/chromium/TestShell.cpp:
2063         (TestShell::TestShell):
2064         (TestShell::bindJSObjectsToWindow):
2065         (TestShell::createNewWindow):
2066         * DumpRenderTree/chromium/TestShell.h:
2067
2068 2010-12-31  Adam Barth  <abarth@webkit.org>
2069
2070         Rubber-stamped by Eric Seidel.
2071
2072         Move PageLoadTests to PerformanceTests/PageLoad
2073         https://bugs.webkit.org/show_bug.cgi?id=51771
2074
2075         Update references to PageLoadTests to point to the new location.
2076
2077         * Scripts/run-pageloadtest:
2078         * Scripts/webkitpy/common/config/build.py:
2079
2080 2010-12-31  Adam Barth  <abarth@webkit.org>
2081
2082         Rubber-stamped by Eric Seidel.
2083
2084         Move SunSpider into PerformanceTests
2085         https://bugs.webkit.org/show_bug.cgi?id=51769
2086
2087         Update these scripts to point to the new location.
2088
2089         * Scripts/run-sunspider:
2090         * Scripts/sunspider-compare-results:
2091
2092 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2093
2094         Reviewed by Kent Tamura.
2095
2096         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2097         https://bugs.webkit.org/show_bug.cgi?id=51728
2098         
2099         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2100         to render top-level scrollbars. This makes them match the Mac port's
2101         use of an NSScrollView, which means that we'll be able to share more
2102         pixel baselines.
2103         
2104         The new rendering code will not be activated until the 
2105         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2106         ScrollbarThemeChromiumMac.
2107
2108         * DumpRenderTree/DumpRenderTree.gypi:
2109         * DumpRenderTree/chromium/TestShellMac.mm:
2110         (platformInit):
2111         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2112         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2113         (+[FakeActiveWindow alwaysActiveWindow]):
2114         (+[FakeActiveWindow alwaysInactiveWindow]):
2115         (-[FakeActiveWindow initWithActiveControls:]):
2116         (-[FakeActiveWindow _hasActiveControls]):
2117         (WebThemeEngineDRTMac::paintScrollbarThumb):
2118         (stateToHIEnableState):
2119         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2120         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2121
2122 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2123
2124         Reviewed by David Kilzer.
2125
2126         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2127         used
2128         https://bugs.webkit.org/show_bug.cgi?id=51672
2129
2130         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2131         with USE_SYSTEM_MALLOC=1
2132         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2133         with USE_SYSTEM_MALLOC=1
2134
2135 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2136
2137         Reviewed by David Kilzer.
2138
2139         [Qt] [Symbian] Fix build-webkit script for Symbian
2140         https://bugs.webkit.org/show_bug.cgi?id=51509
2141
2142         Set the OUTPUT_DIR for Symbian to be the same as the source
2143         directory.
2144
2145         * Scripts/webkitdirs.pm:
2146
2147 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2148
2149         Reviewed by Darin Adler.
2150
2151         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2152         https://bugs.webkit.org/show_bug.cgi?id=51758
2153
2154         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2155
2156         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2157         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2158
2159 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2160
2161         Unreviewed WinCE buildfix.
2162
2163         * WinCELauncher/main.cpp: Add missing include.
2164
2165 2010-12-29  Daniel Bates  <dbates@rim.com>
2166
2167         Reviewed by Darin Adler.
2168
2169         svn-apply updates date of wrong change log entry for a change log diff that
2170         contains two consecutive entries with the same author and date
2171         https://bugs.webkit.org/show_bug.cgi?id=46061
2172
2173         Fixes an issue where the date of the wrong change log entry may be modified.
2174         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2175         in a ChangeLog file to the top of the file.
2176
2177         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2178         diff when it detects that the diff inserts a change log entry earlier in a
2179         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2180         change. With the advent of the commit-queue this functionality of bailing out
2181         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2182         Instead, we should always move the change log entry to the top of the ChangeLog file.
2183
2184         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2185         the date line of the correct change log entry in a ChangeLog diff.
2186
2187         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2188
2189         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2190           Updated the following unit tests now that we move entries inserted earlier to the top:
2191           - "fixChangeLogPatch: New entry inserted in middle."
2192             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2193
2194           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2195             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2196
2197         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2198
2199 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2200
2201         Reviewed by Eric Seidel.
2202
2203         [Qt] Fixed compatibility with gold linker on X11 platforms
2204         https://bugs.webkit.org/show_bug.cgi?id=51700
2205
2206         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2207         Linked TestNetscapePlugin with libX11 on Unix platforms
2208
2209 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2210
2211         Reviewed by Darin Adler.
2212
2213         Circular dependency in webkitpy.common.checkout.changelog module
2214         https://bugs.webkit.org/show_bug.cgi?id=50475
2215
2216         Remove automatic import of api.Checkout module when any checkout/
2217         submodule is imported (e.g.: when checkout.scm.Git is imported).
2218
2219         * Scripts/webkitpy/common/checkout/__init__.py:
2220
2221 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2222
2223         Reviewed by Ojan Vafai.
2224
2225         prepare-ChangeLog should support the -g option for specifying the git-commit
2226         https://bugs.webkit.org/show_bug.cgi?id=51708
2227
2228         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2229         webkit-patch, though the exact meaning of the two options remain different.
2230
2231         * Scripts/prepare-ChangeLog: Add -g.
2232
2233 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2234
2235         Reviewed by Simon Hausmann.
2236
2237         [Qt] Fix compilation with Qt in namespace
2238         https://bugs.webkit.org/show_bug.cgi?id=51701
2239
2240         * QtTestBrowser/webview.h:
2241
2242 2010-12-28  Daniel Bates  <dbates@rim.com>
2243
2244         Reviewed by Sam Weinig.
2245
2246         Substitute // MARK: for compiler-specific #pragma mark
2247         https://bugs.webkit.org/show_bug.cgi?id=51657
2248
2249         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2250         substituting  "// MARK:" for "#pragma mark", which provides
2251         analogous code-bookmarking functionality under Xcode.
2252
2253         Also, for consistency, we should substitute "// MARK:" for compiler-
2254         specific "#pragma mark" in the source files for the Mac port.
2255
2256         * DumpRenderTree/AccessibilityTextMarker.cpp:
2257         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2258         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2259         * DumpRenderTree/mac/ObjCController.m:
2260         * MiniBrowser/mac/AppDelegate.m:
2261         * MiniBrowser/mac/BrowserWindowController.m:
2262
2263 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2264
2265         Reviewed by Eric Seidel.
2266
2267         Add --no-build option to run-sunspider
2268         https://bugs.webkit.org/show_bug.cgi?id=51658
2269
2270         * Scripts/run-sunspider: add --no-build flag to skip building
2271         phase.
2272
2273 2010-12-27  Daniel Bates  <dbates@rim.com>
2274
2275         Rubber-stamped by Martin Robinson.
2276
2277         Append the directory Tools/DumpRenderTree to the list of directories that
2278         do-webcore-rename should search so that it can rename DRT files and
2279         source code.
2280
2281         * Scripts/do-webcore-rename:
2282
2283 2010-12-27  Eric Seidel  <eric@webkit.org>
2284
2285         Reviewed by Adam Barth.
2286
2287         build-webkit should detect missing Java SDK and explain how to install it
2288         https://bugs.webkit.org/show_bug.cgi?id=51651
2289
2290         * Scripts/build-webkit:
2291
2292 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2293
2294         Reviewed by Daniel Bates.
2295
2296         [GTK] Add support for build-jsc
2297         https://bugs.webkit.org/show_bug.cgi?id=51625
2298
2299         Add GTK+ support to build-jsc now that building the jsc executable as
2300         a standalone target is easy.
2301
2302         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2303         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2304         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2305         and pass it along to buildAutotoolsProject.
2306
2307 2010-12-27  David Levin  <levin@chromium.org>
2308
2309         Reviewed by Eric Seidel.
2310
2311         check-webkit-style check for meaningless variable names in function declarations.
2312         https://bugs.webkit.org/show_bug.cgi?id=51523
2313
2314         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2315         from the new check and whitespace/parens because the syntax is unusual and
2316         produced a fair number of positives for these checks.
2317         * Scripts/webkitpy/style/checkers/cpp.py:
2318         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2319         and parameter names when determining if the parameter name is useless.
2320         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2321         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2322         format.
2323         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2324         text or an acronym of it.
2325         (check_function_definition): Checks function definitions for meaningless variable names.
2326         (process_line): Added call to check_function_definition.
2327         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2328         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2329         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2330         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2331         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2332         because when only checking a snippet, there are a lot of bogus functions.
2333         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2334         that I put there previously and just noticed.
2335         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2336         check_function_definition and process_line.
2337
2338 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2339
2340         Reviewed by Martin Robinson.
2341
2342         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2343         https://bugs.webkit.org/show_bug.cgi?id=51591
2344
2345         Flash plugin uses gtk2 that is incompatible with gtk3 making
2346         webkit crash when it's built with gtk3.
2347
2348         * GtkLauncher/main.c:
2349         (main):
2350
2351 2010-12-25  Adam Barth  <abarth@webkit.org>
2352
2353         Reviewed by Eric Seidel.
2354
2355         Move ANGLE to Sources/ThirdParty
2356         https://bugs.webkit.org/show_bug.cgi?id=51605
2357
2358         * Scripts/build-webkit:
2359           - Point to the new ANGLE location.
2360
2361 2010-12-26  David Levin  <levin@chromium.org>
2362
2363         Reviewed by Eric Seidel.
2364
2365         check-webkit-style should be able to parse function declaration parameters.
2366         https://bugs.webkit.org/show_bug.cgi?id=51451
2367
2368         * Scripts/webkitpy/style/checkers/cpp.py:
2369         (Position.__init__): Holds simple position information (row, column).
2370         (Parameter.__init__): Holds information about a parameter.
2371         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2372         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2373         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2374         (find_parameter_name_index): Finds where the parameter name is.
2375         (parameter_list): Generates the list of parameters for a function.
2376         (_FunctionState.begin): Added information to allow determining the parameters
2377         on demand.
2378         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2379         (detect_functions): Improve function detection for operator functions and
2380         determine where the parameters end and pass that to _FunctionState.begin.
2381         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2382         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2383         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2384         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2385         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2386         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2387         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2388         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2389         the parameters found.
2390         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2391         detection test to verify that we catch the operator functions.
2392         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2393         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2394         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2395         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2396         test_function_length_check_definition_severity1_for_test.
2397
2398 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2399
2400         Unreviewed WinCE buildfix after r74334.
2401
2402         * CMakeListsWinCE.txt:
2403
2404 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2405
2406         Unreviewed, rolling out r74632.
2407         http://trac.webkit.org/changeset/74632
2408         https://bugs.webkit.org/show_bug.cgi?id=51600
2409
2410         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2411         on #webkit).
2412
2413         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2414         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2415
2416 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2417
2418         Reviewed by Kenneth Rohde Christiansen.
2419
2420         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2421         https://bugs.webkit.org/show_bug.cgi?id=43528
2422
2423         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2424         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2425         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2426         called.
2427
2428         * EWebLauncher/main.c:
2429         (browserCreate):
2430
2431 2010-12-24  Eric Seidel  <eric@webkit.org>
2432
2433         Reviewed by Adam Barth.
2434
2435         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2436         https://bugs.webkit.org/show_bug.cgi?id=28291
2437
2438         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2439         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2440         to strings with find in the diff.
2441         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2442
2443         * Scripts/webkitpy/common/checkout/api.py:
2444         * Scripts/webkitpy/common/checkout/diff_parser.py:
2445         * Scripts/webkitpy/tool/steps/abstractstep.py:
2446         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2447         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2448         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2449         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2450
2451 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2452
2453         Reviewed by Kenneth Russell.
2454
2455         Modify new-run-webkit-tests to shut up and exit when all the threads
2456         are wedged so that test runs complete faster and we don't end up
2457         w/ enormous log files.
2458
2459         https://bugs.webkit.org/show_bug.cgi?id=51572
2460
2461         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2462         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2463
2464 2010-12-24  Eric Seidel  <eric@webkit.org>
2465
2466         Reviewed by David Levin.
2467
2468         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2469         https://bugs.webkit.org/show_bug.cgi?id=51549
2470
2471         I've had multiple people ask me about the commit-queue's behavior
2472         regarding reporting flaky tests.  I figured it would be best to just
2473         have the queue explain itself in the bugs it files.
2474
2475         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2476         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2477
2478 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2479
2480         Reviewed by Eric Seidel.
2481
2482         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2483         https://bugs.webkit.org/show_bug.cgi?id=51467
2484
2485         * Scripts/webkitpy/style/checker.py:
2486         * Scripts/webkitpy/style/checker_unittest.py:
2487
2488 2010-12-23  Adam Barth  <abarth@webkit.org>
2489
2490         Rubber-stamped by Eric Seidel.
2491
2492         Move JavaScriptGlue into Sources
2493         https://bugs.webkit.org/show_bug.cgi?id=51583
2494
2495         These tools refer to JavaScriptGlue and need to be updated to its new
2496         location.
2497
2498         * Scripts/build-webkit:
2499         * Scripts/do-file-rename:
2500         * Scripts/do-webcore-rename:
2501         * Scripts/webkitpy/common/config/build.py:
2502         * Scripts/webkitpy/common/config/build_unittest.py:
2503
2504 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2505
2506         Reviewed by Eric Seidel.
2507
2508         Bug 51539 - update iexploder scripts to point to new location
2509
2510         * Scripts/run-iexploder-tests:
2511         * Scripts/update-iexploder-cssproperties:
2512
2513 2010-12-23  Evan Martin  <evan@chromium.org>
2514
2515         Reviewed by Ryosuke Niwa.
2516
2517         [chromium] LayoutTestController warning in float->int conversion
2518         https://bugs.webkit.org/show_bug.cgi?id=51553
2519
2520         Rather than reading an int, converting to a float, then getting a compiler
2521         warning on passing the float to something that expects an int, instead
2522         just pass around ints.
2523
2524         No tests, fixes a compiler warning.
2525
2526         * DumpRenderTree/chromium/LayoutTestController.cpp:
2527         (parsePageSizeParameters):
2528         (LayoutTestController::pageNumberForElementById):
2529         (LayoutTestController::numberOfPages):
2530
2531 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2532
2533         Reviewed by Darin Adler.
2534
2535         Bug 51537 - iexploder needs cleanup
2536         
2537         * iExploder/htdocs: Removed.
2538         * iExploder/htdocs/config.rb: Removed.
2539         * iExploder/htdocs/cssproperties.in: Removed.
2540         * iExploder/htdocs/cssvalues.in: Removed.
2541         * iExploder/htdocs/htmlattrs.in: Removed.
2542         * iExploder/htdocs/htmltags.in: Removed.
2543         * iExploder/htdocs/htmlvalues.in: Removed.
2544         * iExploder/htdocs/iexploder.cgi: Removed.
2545         * iExploder/htdocs/iexploder.rb: Removed.
2546         * iExploder/htdocs/index.html: Removed.
2547         * iExploder/htdocs/webserver.rb: Removed.
2548         * iExploder/iexploder-1.7.2/output: Removed.
2549         * iExploder/tools: Removed.
2550         * iExploder/tools/lasthit.rb: Removed.
2551         * iExploder/tools/osx_last_crash.rb: Removed.
2552         * iExploder/tools/showtest.rb: Removed.
2553
2554 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2555
2556         Reviewed by Kenneth Rohde Christiansen.
2557
2558         [EFL] Make 'single' the default backing store in EWebLauncher
2559         https://bugs.webkit.org/show_bug.cgi?id=51534
2560
2561         'single' is the simplest backing store and the one intended to be the
2562         default in the test browser. By mistake the tiled backing store was
2563         left as default in r72617.
2564
2565         * EWebLauncher/main.c:
2566         (browserCreate): ditto.
2567
2568 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2569
2570         Reviewed by Kenneth Rohde Christiansen.
2571
2572         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2573         https://bugs.webkit.org/show_bug.cgi?id=51533
2574
2575         There's no point in concatenating env("HOME") with "blah", so remove
2576         option from EWebLauncher.
2577
2578         * EWebLauncher/main.c:
2579         (main): ditto.
2580
2581 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2582
2583         Reviewed by Eric Seidel.
2584
2585         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2586
2587         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2588         I just discovered that we have two additional GC runs per each WebViewHost.
2589         Test_shell had no such calls.
2590         These gc runs eat 15% of cpu time.
2591
2592         https://bugs.webkit.org/show_bug.cgi?id=51479
2593
2594         * DumpRenderTree/chromium/WebViewHost.cpp:
2595         (WebViewHost::~WebViewHost):
2596
2597 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2598
2599         Reviewed by Ojan Vafai.
2600
2601         This change splits out the TestRunner class into its own file.
2602         When we fork the code for message passing, we will create a new
2603         TestRunner, and this change will allow that to be more modular.
2604
2605         While we're at it, split out TestInput and ResultSummary into
2606         their own files, to reduce the size of run_webkit_tests to
2607         something more managable.
2608
2609         https://bugs.webkit.org/show_bug.cgi?id=51092
2610
2611         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2612         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2613         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2614         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2615         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2616         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2617         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2618
2619  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2620
2621         Reviewed by Ojan Vafai.
2622
2623         nrwt multiprocessing - start over, prepare to fork the code
2624  
2625         This code cleans up the signatures and implementation of the
2626         TestRunner class so we can easily fork it to run either the
2627         stable implementation or the new, unstable message-passing
2628         implementation. The two variants will have different
2629         implementations of the run_tests() method. We will switch
2630         between the two based on the setting for the '--worker-model'
2631         switch. We rename the two currently valid values to 'old-inline'
2632         and 'old-threads'.
2633
2634         https://bugs.webkit.org/show_bug.cgi?id=51081
2635
2636         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2637         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2638
2639 2010-12-22  Victor Wang  <victorw@chromium.org>
2640
2641         Reviewed by Darin Fisher.
2642
2643         [Chromium] Update chromium archive test result url in rebaseline script.
2644
2645         https://bugs.webkit.org/show_bug.cgi?id=51503
2646
2647         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2648
2649 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2650
2651         Reviewed by Alice Liu.
2652
2653         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2654         Verified on Chrome, Safari, and IE.
2655         With this change, we will record memory from a parent browser window and all child processes.
2656
2657         * record-memory-win/main.cpp:
2658         (ProcessArgs):
2659         (PrintUsage):
2660         (getMemoryInfo):
2661         (printProcessInfo):
2662         (evalProcesses):
2663         (UseImage):
2664         (QueryContinuously):
2665         (ElapsedTime):
2666
2667 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2668
2669         Unreviewed rollout r74489, because it was missing changelog.
2670
2671         * record-memory-win/main.cpp:
2672         
2673 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2674
2675         Adding myself as a reviewer.
2676
2677         * Scripts/webkitpy/common/config/committers.py:
2678
2679 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2680
2681         Unreviewed.  Adding myself to committers.py.
2682
2683         * Scripts/webkitpy/common/config/committers.py:
2684
2685 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2686
2687         Reviewed by Kenneth Rohde Christiansen.
2688
2689         TestNetscapePlugIn should use #if defined
2690         https://bugs.webkit.org/show_bug.cgi?id=51471
2691
2692         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2693         (NP_Initialize):
2694         (NPP_New):
2695
2696 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2697
2698         Reviewed by Yury Semikhatsky.
2699
2700         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2701
2702         DevTools window should be closed explicitly because it has custom deinitialization code.
2703
2704         https://bugs.webkit.org/show_bug.cgi?id=50722
2705
2706         * DumpRenderTree/chromium/TestShell.cpp:
2707         (TestShell::closeRemainingWindows):
2708
2709 2010-12-22  David Levin  <levin@chromium.org>
2710
2711         Reviewed by Shinichiro Hamaji.
2712
2713         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2714         https://bugs.webkit.org/show_bug.cgi?id=51452
2715
2716         * Scripts/webkitpy/style/checkers/cpp.py:
2717         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2718         Using the file extension if possible but falling back to the file contents if we have a header file.
2719         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2720         (_FileState.is_c_or_objective_c):
2721         (check_using_std): Changed to using _FileState to determine the file type.
2722         (check_max_min_macros): Ditto.
2723         (check_for_null): Ditto.
2724         (check_style): Changed the parameters to various calls since they now need _FileState
2725         to determine the file type.
2726         (check_language): Added the file_state parameter so it could be passed
2727         to check_identifier_name_in_declaration.
2728         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2729         this is an Objective C file.
2730         (_process_lines): Added information for the _FileState constructor (and moved the
2731         call to a place that had the information).
2732         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2733         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2734         its functionality.
2735         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2736
2737 2010-12-21  Andy Estes  <aestes@apple.com>
2738
2739         Reviewed by Mark Rowe.
2740
2741         Do not build non-Intel architectures for WebKit2-related projects.
2742         https://bugs.webkit.org/show_bug.cgi?id=51440
2743
2744         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2745         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2746         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2747
2748 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2749
2750         Reviewed by Darin Fisher.
2751
2752         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2753         https://bugs.webkit.org/show_bug.cgi?id=51406 
2754         
2755         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2756         to WebThemeEngineDRTWin and update references everywhere.
2757
2758         * DumpRenderTree/DumpRenderTree.gypi:
2759         * DumpRenderTree/chromium/TestShellWin.cpp:
2760         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2761         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2762         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2763         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2764
2765 2010-12-21  Anders Carlsson  <andersca@apple.com>
2766
2767         Reviewed by John Sullivan.
2768
2769         Clicking missing plug-in text does not show a sheet
2770         https://bugs.webkit.org/show_bug.cgi?id=51403
2771
2772         Update for changes to the WebPageUIClient.
2773
2774         * MiniBrowser/mac/BrowserWindowController.m:
2775         (-[BrowserWindowController awakeFromNib]):
2776         * WebKitTestRunner/TestController.cpp:
2777         (WTR::createOtherPage):
2778         (WTR::TestController::initialize):
2779
2780 2010-12-21  Eric Seidel  <eric@webkit.org>
2781
2782         Reviewed by Adam Barth.
2783
2784         commit-queue will report constant failures as flaky if other tests flake
2785         https://bugs.webkit.org/show_bug.cgi?id=51272
2786
2787         This patch just removes functionality and adds testing.
2788         Previously we attempted to report flaky tests when we had
2789         two different tests fail in a row.  However, since we stop
2790         running the tests at the first failure, our code was wrong in
2791         trying to determine flakiness from the incomplete runs.
2792
2793         Originally I posted an alternate patch:
2794         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2795         which fixed our flaky logic in this case, however it was decided
2796         that that patch would be too difficult to maintain, so now
2797         I'm just removing the broken logic.
2798
2799         This will dramatically cut-down on our flaky-test false positives
2800         at the (small) cost of the queues being unable to report
2801         any flakiness if the tree is very flaky.  (With at least one test
2802         flaking on every run, we'll never report failures anymore.)  I think
2803         this is a tradeoff worth making.
2804
2805         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2806         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2807
2808 2010-12-20  Eric Seidel  <eric@webkit.org>
2809
2810         Reviewed by Adam Barth.
2811
2812         commit-queue wrongly rejects patches when it can't update itself
2813         https://bugs.webkit.org/show_bug.cgi?id=46636
2814
2815         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2816         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2817         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2818
2819 2010-12-20  Adam Barth  <abarth@webkit.org>
2820
2821         Move web sites to Websites directory
2822         https://bugs.webkit.org/show_bug.cgi?id=51323
2823
2824         Update references to BugsSite to point to the new location.
2825
2826         This patch was never officially reviewed (because it was too large to
2827         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2828         Rowe gave me the green light.
2829
2830         * Scripts/old-run-webkit-tests:
2831         * Scripts/webkitpy/common/config/build.py:
2832         * Scripts/webkitpy/common/config/build_unittest.py:
2833         * Scripts/webkitpy/common/prettypatch.py:
2834         * Scripts/webkitpy/layout_tests/port/base.py:
2835         * Scripts/webkitpy/style/main.py:
2836
2837 2010-12-20  Adrienne Walker  <enne@google.com>
2838
2839         Unreviewed. Adding myself to the list of committers.
2840
2841         * webkitpy/common/config/committers.py:
2842
2843 2010-12-20  Mark Rowe  <mrowe@apple.com>
2844
2845         Reviewed by Dan Bernstein.
2846
2847         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2848
2849         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2850         Resources directory.
2851
2852 2010-12-20  Eric Seidel  <eric@webkit.org>
2853
2854         Reviewed by Adam Barth.
2855
2856         commit-queue should include bot id when attaching failure diffs
2857         https://bugs.webkit.org/show_bug.cgi?id=51280
2858
2859         This is a tiny change to include the bot id in the name of the attachment.
2860         Most of this diff is just changing the unit test expectations
2861         now that I hid the comment printing when the comment is None.
2862
2863         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2864         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2865         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2866         * Scripts/webkitpy/tool/mocktool.py:
2867
2868 2010-12-20  Jeff Miller  <jeffm@apple.com>
2869
2870         Reviewed by Dan Bernstein.
2871
2872         Tools/vcbin/midl.exe needs to be rebuilt
2873         https://bugs.webkit.org/show_bug.cgi?id=51347
2874
2875         * vcbin/midl.exe: Rebuilt.
2876
2877 2010-12-20  David Levin  <levin@chromium.org>
2878
2879         Reviewed by Ariya Hidayat.
2880
2881         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2882         https://bugs.webkit.org/show_bug.cgi?id=51343
2883
2884         Follow up from the WebKitTools -> Tools rename.
2885
2886         * Scripts/webkit-tools-completion.sh:
2887
2888 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2889
2890         Reviewed by James Robinson.
2891
2892         new-run-webkit-tests ignores trailing EOL differences in text tests
2893         https://bugs.webkit.org/show_bug.cgi?id=36983
2894
2895         Changed the handling of new-line characters within new-run-webkit-tests
2896         to match old-run-webkit-tests.  Differences in leading and trailing empty
2897         lines in text expectation files are no longer ignored.
2898
2899         * Scripts/webkitpy/layout_tests/port/base.py:
2900         * Scripts/webkitpy/layout_tests/port/test.py:
2901         Added unit tests.  Removed old duplicate unit test entries.
2902         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2903
2904 2010-12-20  David Levin  <levin@chromium.org>
2905
2906         Reviewed by Shinichiro Hamaji.
2907
2908         check-webkit-style should detect function declarations (and trivial functions).
2909         https://bugs.webkit.org/show_bug.cgi?id=51303
2910
2911         * Scripts/webkitpy/style/checkers/cpp.py:
2912         (_FunctionState.begin): Add is_declaration and changed the line count
2913         start to begin at -1 (which will keep the results consistent, since
2914         the starting line number passed in is one less in this change).
2915         (detect_functions): changed function detection to now catch trivial
2916         functions and declarations.
2917         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2918         of the function as this may look at return values (when processing
2919         a declaration).
2920         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2921         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2922         of testing the function detection.
2923         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2924         function.
2925         (FunctionDetectionTest.test_function_declaration_detection): Test a
2926         declaration.
2927         (FunctionDetectionTest.test_non_functions): A test case for a case
2928         that caused the code to fail due to the { being in quotes.
2929         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2930         cases to help catch false alarms for return values.
2931         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2932         we don't get false alarms for member variables either.
2933
2934 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2935
2936         Reviewed by Antonio Gomes.
2937
2938         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2939         https://bugs.webkit.org/show_bug.cgi?id=51319
2940
2941         * CMakeListsEfl.txt:
2942
2943 2010-12-18  Adam Barth  <abarth@webkit.org>
2944
2945         Reviewed by Sam Weinig.
2946
2947         Move WebKitExamplePlugins to Examples
2948         https://bugs.webkit.org/show_bug.cgi?id=51291
2949
2950         * Scripts/webkitpy/common/config/build.py:
2951
2952 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2953
2954         Unreviewed Qt buildfix after r74301.
2955
2956         Rename WebKitTools to Tools
2957         https://bugs.webkit.org/show_bug.cgi?id=49861
2958
2959         * MiniBrowser/DerivedSources.pro:
2960         * MiniBrowser/qt/MiniBrowser.pro:
2961
2962 2010-12-17  Dan Bernstein  <mitz@apple.com>
2963
2964         Reviewed by Simon Fraser.
2965
2966         Rename WebKitTools to Tools
2967         https://bugs.webkit.org/show_bug.cgi?id=49861
2968
2969         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2970         * CodeCoverage/README:
2971         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2972         (WebCore::DumpRenderTree::initializeFonts):
2973         * EWSTools/start-commit-queue.sh:
2974         * EWSTools/start-queue.sh:
2975         * GNUmakefile.am:
2976         * MIDLWrapper/MIDLWrapper.cpp:
2977         (wmain):
2978         * MiniBrowser/qt/MiniBrowser.pro:
2979         * Scripts/build-api-tests:
2980         * Scripts/build-dumprendertree:
2981         * Scripts/build-webkit:
2982         * Scripts/build-webkittestrunner:
2983         * Scripts/generate-coverage-data:
2984         * Scripts/old-run-webkit-tests:
2985         * Scripts/run-api-tests:
2986         * Scripts/run-iexploder-tests:
2987         * Scripts/run-javascriptcore-tests:
2988         * Scripts/run-mangleme-tests:
2989         * Scripts/run-sunspider:
2990         * Scripts/run-webkit-websocketserver:
2991         * Scripts/sunspider-compare-results:
2992         * Scripts/test-webkitperl:
2993         * Scripts/test-webkitpy:
2994         * Scripts/update-iexploder-cssproperties:
2995         * Scripts/update-webkit:
2996         * Scripts/update-webkit-localizable-strings:
2997         * Scripts/webkitdirs.pm:
2998         * Scripts/webkitpy/common/checkout/scm.py:
2999         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3000         * Scripts/webkitpy/common/config/committervalidator.py:
3001         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3002         * Scripts/webkitpy/common/config/ports.py:
3003         * Scripts/webkitpy/common/config/ports_unittest.py:
3004         * Scripts/webkitpy/common/system/logutils_unittest.py:
3005         * Scripts/webkitpy/common/system/ospath_unittest.py:
3006         * Scripts/webkitpy/layout_tests/port/chromium.py:
3007         * Scripts/webkitpy/layout_tests/port/config.py:
3008         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3009         * Scripts/webkitpy/layout_tests/port/http_server.py:
3010         * Scripts/webkitpy/layout_tests/port/test.py:
3011         * Scripts/webkitpy/style/checker.py:
3012         * Scripts/webkitpy/style/checker_unittest.py:
3013         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3014         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3015         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3016         * WebKitTestRunner/DerivedSources.pro:
3017         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3018         (WTR::activateFonts):
3019         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3020         * wx/build/build_utils.py:
3021
3022 2010-12-16  Antonio Gomes  <agomes@rim.com>
3023
3024         Reviewed by Martin Robinson.
3025
3026         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3027         https://bugs.webkit.org/show_bug.cgi?id=51163
3028
3029         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3030         GTK+'s DRT should also reset to UNIX after each test execution.
3031
3032         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3033         (resetDefaultsToConsistentValues):
3034
3035 2010-12-17  David Levin  <levin@chromium.org>
3036
3037         Reviewed by Eric Seidel.
3038
3039         check-webkit-style should understand WTF #include guards
3040         https://bugs.webkit.org/show_bug.cgi?id=44911
3041
3042         * Scripts/webkitpy/style/checkers/cpp.py:
3043         (get_header_guard_cpp_variable): modify to suggest the WTF style
3044         of header guard when appropriate.
3045         (check_for_header_guard): handle multiple return values from
3046         get_header_guard_cpp_variable
3047         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3048         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3049         header style.
3050
3051 2010-12-16  David Levin  <levin@chromium.org>
3052
3053         Reviewed by Eric Seidel.
3054
3055         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3056         https://bugs.webkit.org/show_bug.cgi?id=51210
3057
3058         The error only shows up when using python 2.6 or later.
3059
3060         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3061         the decprecated field error,message with something equivalent.
3062
3063 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3064
3065         Reviewed by Eric Seidel.
3066
3067         Add --exit-after-n-failures/crashes to NRWT
3068         https://bugs.webkit.org/show_bug.cgi?id=51160
3069         
3070         Abort test run (in a similar way to how control-C is handled) when
3071         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3072         that number of unexpected failures/crashes/timeouts.
3073
3074         * Scripts/webkitpy/layout_tests/port/test.py:
3075         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3076         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3077
3078 2010-12-16  David Levin  <levin@chromium.org>
3079
3080         Reviewed by Shinichiro Hamaji.
3081
3082         check-webkit-style unit tests has some duplicate boilerplate code.
3083         https://bugs.webkit.org/show_bug.cgi?id=49519
3084
3085         * Scripts/webkitpy/style/checkers/cpp.py:
3086         (update_include_state): Replaced the "io" parameter with the global
3087         configuration _unit_test_config. This allowed not calling into
3088         functions at a low level and also not plumbing through the injection
3089         information through many levels of code.
3090         (check_for_include_what_you_use): Ditto.
3091         (process_file_data): Added the ability to set up the unit test config
3092         to allow for injection.
3093         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3094         (ErrorCollector.__init__): Added support for having a filter for errors.
3095         (ErrorCollector.__call__): Ditto.
3096         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3097         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3098         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3099         functions in the cpp.py with generic processing and a filter that
3100         indicates what errors should be kept.
3101         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3102         (CppStyleTestBase.perform_language_rules_check): Ditto.
3103         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3104         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3105         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3106         (CppStyleTest.test_multi_line_comments): Added another
3107         error message which applies to the test case.
3108         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3109         to not have config.h, since it is processed as a header file.
3110         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3111         style and indentation in checked code.
3112         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3113         Fixed line number.
3114         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3115         Ditto.
3116
3117 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3118
3119         Unreviewed, rolling out r74136.
3120         http://trac.webkit.org/changeset/74136
3121         https://bugs.webkit.org/show_bug.cgi?id=51135
3122
3123         r74136 breaks chromium canary bots because some tests are not
3124         rebaselined correctly to resolve EOL differences (Requested by
3125         jianli on #webkit).
3126
3127         * Scripts/webkitpy/layout_tests/port/base.py:
3128         * Scripts/webkitpy/layout_tests/port/test.py:
3129         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3130
3131 2010-12-15  Adam Roben  <aroben@apple.com>
3132
3133         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3134         syntax errors
3135
3136         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3137         XML syntax errors in .vcproj/.vsprops files
3138
3139         Reviewed by Dave Levin.
3140
3141         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3142         that should be treated as XML and that should be allowed to contain
3143         carriage returns. (These lists happen to be identical currently.)
3144         (FileType): Added a new XML type.
3145         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3146         Just does a simple file extension check.
3147         (CheckerDispatcher._file_type): Added a case for XML files.
3148         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3149         files (surprise!).
3150         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3151         lines through the carriage checker.
3152
3153         * Scripts/webkitpy/style/checker_unittest.py:
3154         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3155         Added. Checks a few file names to see if carriage returns are allowed
3156         or not.
3157         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3158         other assert_checker_* functions.
3159         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3160         test_*_paths functions.
3161         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3162         test_*_paths functions.
3163         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3164         file from this test case, as vcproj files now have a type.
3165         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3166         Added. Similar to the other should_* functions.
3167         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3168         Added. Checks that carriage returns aren't checked for or stripped for
3169         allowed files.
3170
3171         * Scripts/webkitpy/style/checkers/xml.py: Added.
3172         (XMLChecker.__init__): Simple init method.
3173         (XMLChecker.check): Pass each line through the expat parser, and record
3174         a style error for any errors thrown by the parser.
3175
3176         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3177         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3178         produce a style error.
3179         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3180         error of the given category on the given line.
3181         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3182         checking that the XMLChecker constructor works properly.
3183         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3184         cause a style error (see, e.g., r73887).
3185         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3186         cause a style error (see, e.g., r73773).
3187         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3188         properly.
3189         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3190         tags cause a style error (see, e.g., r72795).
3191         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3192         style error.
3193
3194 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3195
3196         Reviewed by Stephanie Lewis.
3197
3198         https://bugs.webkit.org/show_bug.cgi?id=51117
3199         Add a new leopard test bot
3200         really really commit to trunk this time.
3201
3202         * BuildSlaveSupport/build.webkit.org-config/config.json:
3203
3204 2010-12-15  Sam Weinig  <sam@webkit.org>
3205
3206         Reviewed by Anders Carlsson.
3207
3208         WebKit2: Can't add files to an <input type=file>
3209         https://bugs.webkit.org/show_bug.cgi?id=51087
3210
3211         * MiniBrowser/mac/BrowserWindowController.m:
3212         (runOpenPanel):
3213         (-[BrowserWindowController awakeFromNib]):
3214         Add simple implementation of runOpenPanel callback.
3215
3216         * MiniBrowser/win/BrowserView.cpp:
3217         (BrowserView::create):
3218         * WebKitTestRunner/TestController.cpp:
3219         (WTR::createOtherPage):
3220         (WTR::TestController::initialize):
3221         Stub out runOpenPanel callback. 
3222
3223 2010-12-14  Eric Seidel  <eric@webkit.org>
3224
3225         Reviewed by Adam Barth.
3226
3227         commit-queue should upload failure diffs when tests flake
3228         https://bugs.webkit.org/show_bug.cgi?id=51051
3229
3230         To make this testable I needed to pipe FileSystem down onto tool.
3231         We've wanted it there for a long time anyway.
3232
3233         This patch is kinda a big hack.  But we don't have a nice
3234         way to read results.html files.  I think this will need further
3235         revision before this code actually feels clean.
3236
3237         As part of testing this change, I had to make MockBugzilla.create_bug
3238         actually return an id (like it should) which required updating
3239         a few other unit test results (for the better).
3240
3241         The results_matching_keys change in layouttestresults/rebasline
3242         was an alternate path which I decided not to use in the end, but
3243         I left the change as it seemed an improvement.
3244
3245         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3246         * Scripts/webkitpy/common/net/layouttestresults.py:
3247         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3248         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3249         * Scripts/webkitpy/tool/commands/queues.py:
3250         * Scripts/webkitpy/tool/commands/rebaseline.py:
3251         * Scripts/webkitpy/tool/main.py:
3252         * Scripts/webkitpy/tool/mocktool.py:
3253
3254 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3255
3256         Reviewed by James Robinson.
3257
3258         new-run-webkit-tests ignores trailing EOL differences in text tests
3259         https://bugs.webkit.org/show_bug.cgi?id=36983
3260
3261         Changed the handling of new-line characters within new-run-webkit-tests
3262         to match old-run-webkit-tests.  Differences in leading and trailing empty
3263         lines in text expectation files are no longer ignored.
3264
3265         * Scripts/webkitpy/layout_tests/port/base.py:
3266         * Scripts/webkitpy/layout_tests/port/test.py:
3267         Added unit tests.  Removed old duplicate unit test entries.
3268         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3269
3270 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3271
3272         Reviewed by Adam Barth.
3273
3274         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3275         https://bugs.webkit.org/show_bug.cgi?id=51149
3276
3277         * QueueStatusServer/templates/statusbubble.html:
3278
3279 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3280
3281         Reviewed by Adam Barth.
3282
3283         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3284         https://bugs.webkit.org/show_bug.cgi?id=51125
3285
3286         * QueueStatusServer/templates/statusbubble.html:
3287
3288 2010-12-15  Darin Adler  <darin@apple.com>
3289
3290         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3291
3292 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3293
3294         Unreviewed, rolling out r74117.
3295         http://trac.webkit.org/changeset/74117
3296         https://bugs.webkit.org/show_bug.cgi?id=51113
3297
3298         This broke the GTK1 build. (Requested by mrobinson on
3299         #webkit).
3300
3301         * Scripts/webkitdirs.pm:
3302
3303 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3304
3305         Reviewed by Martin Robinson.
3306
3307         Change generate-forwarding-headers.pl for GTK port usage 
3308         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3309
3310         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3311
3312 2010-12-14  Kent Tamura  <tkent@chromium.org>
3313
3314         Reviewed by Jian Li.
3315
3316         [DRT/Chromium] Remove another unnecessary error message
3317         https://bugs.webkit.org/show_bug.cgi?id=51083
3318
3319         * DumpRenderTree/chromium/WebViewHost.cpp:
3320         (WebViewHost::didInvalidateRect):
3321
3322 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3323
3324         Reviewed by Stephanie Lewis.
3325
3326         Add a new Leopard Debug Test WK2 Bot
3327
3328         * BuildSlaveSupport/build.webkit.org-config/config.json:
3329
3330 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3331
3332         Fix python unittests after http://trac.webkit.org/changeset/74070.
3333
3334         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3335
3336 2010-12-14  Kent Tamura  <tkent@chromium.org>
3337
3338         Reviewed by Jian Li.
3339
3340         [DRT/Chromium] Remove a unnecessary error message
3341         https://bugs.webkit.org/show_bug.cgi?id=51069
3342
3343         * DumpRenderTree/chromium/WebViewHost.cpp:
3344         (WebViewHost::paintInvalidatedRegion):
3345
3346 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3347
3348         Reviewed by Ojan Vafai.
3349
3350         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3351         https://bugs.webkit.org/show_bug.cgi?id=48926
3352
3353         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3354         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3355
3356 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3357
3358         Reviewed by Eric Seidel.
3359
3360         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3361         https://bugs.webkit.org/show_bug.cgi?id=50231
3362
3363         Guard CONFIG+=link_pkgconfig with !symbian.
3364
3365         * DumpRenderTree/qt/DumpRenderTree.pro:
3366         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3367         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3368
3369 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3370
3371         Reviewed by Ojan Vafai.
3372
3373         [new-run-webkit-tests] expectations parsing is slow
3374         https://bugs.webkit.org/show_bug.cgi?id=50635
3375
3376         Avoid expensive iteration of all the tests when checking if a test
3377         file is to be skipped or not.
3378
3379         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3380         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3381         * Scripts/webkitpy/layout_tests/port/test.py:
3382
3383 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3384
3385         Reviewed by Xan Lopez.
3386
3387         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3388         https://bugs.webkit.org/show_bug.cgi?id=27048
3389
3390         Add support in DRT for checking whether an accessibility UI
3391         element is focusable and/or focused. Implemented for GTK.
3392
3393         * DumpRenderTree/AccessibilityUIElement.cpp:
3394         (getIsFocusedCallback): New.
3395         (getIsFocusableCallback): New.
3396         (AccessibilityUIElement::getJSClass): Add the new available
3397         callbacks for isFocused and isFocusable.
3398         * DumpRenderTree/AccessibilityUIElement.h:
3399         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3400         (AccessibilityUIElement::isFocused): New, implemented by checking
3401         whether the related AtkState value is in the object's state set.
3402         (AccessibilityUIElement::isFocusable): Ditto.
3403         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3404         (AccessibilityUIElement::isFocused): New, dummy implementation.
3405         (AccessibilityUIElement::isFocusable): Ditto.
3406         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3407         (AccessibilityUIElement::isFocused): Ditto.
3408         (AccessibilityUIElement::isFocusable): Ditto.
3409
3410 2010-12-14  Eric Seidel  <eric@webkit.org>
3411
3412         Reviewed by Ojan Vafai.
3413
3414         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3415         https://bugs.webkit.org/show_bug.cgi?id=50715
3416
3417         This patch makes webkit-patch print the following:
3418
3419         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3420         Install a 64-bit git for better performance, see:
3421         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3422
3423         I wrote this mostly because I have approximately 8 machines that I use
3424         and making sure each one is using a good Git install seemed folly.
3425         webkit-patch makes a lot of git calls, so using a fast git can shave
3426         several seconds in every invocation.  See the webkit-dev thread for more info.
3427
3428         This message will print twice during 'webkit-patch upload',
3429         once from webkit-patch and once from check-webkit-style.
3430
3431         Unfortunately there is no good way to test this due to how machine-dependent
3432         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3433
3434         * Scripts/webkitpy/common/checkout/scm.py:
3435
3436 2010-12-13  Eric Seidel  <eric@webkit.org>
3437
3438         Reviewed by Adam Barth.
3439
3440         FlakyTestReporter doesn't understand bots running from multiple email addresses
3441         https://bugs.webkit.org/show_bug.cgi?id=50960
3442
3443         This explains at least one of the dupes of:
3444         https://bugs.webkit.org/show_bug.cgi?id=50863
3445         that we saw filed by the commit-queue this morning.
3446         I think the other one was explained by my previous fix to result counting code.
3447
3448         Since this is really hard to test with a unit test, instead I
3449         create a new (possibly useful in the future) command
3450         which given a layout test path will return you
3451         the one bug which our tools would assume it the flaky test bug.
3452         If some other script wants to use bug-for-test we'll
3453         need to extend it with some options like --create-if-missing or similar.
3454
3455         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3456         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3457         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3458         * Scripts/webkitpy/tool/commands/__init__.py:
3459         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3460
3461 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3462
3463         Reviewed by James Robinson.
3464
3465         Add option to build-webkit to not build WebKit2
3466         https://bugs.webkit.org/show_bug.cgi?id=50988
3467         
3468         Add support for a --no-webkit2 option to build-webkit. It seems to save
3469         ~1 minute from clean builds and ~10 seconds from no-op builds.
3470
3471         * Scripts/build-webkit:
3472
3473 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3474
3475         Reviewed by Dave Kilzer.
3476
3477         Update iexploder from 1.3.2 to 1.7.2
3478         Move 1.3.2 into its own subdir
3479         Add 1.7.2 into its own subdir
3480         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3481
3482         * Scripts/run-iexploder-tests:
3483         * Scripts/update-iexploder-cssproperties:
3484         * iExploder/CHANGELOG.txt: Removed.
3485         * iExploder/LICENSE.txt: Removed.
3486         * iExploder/README.txt: Removed.
3487         * iExploder/htdocs: Removed.
3488         * iExploder/iexploder-1.3.2: Added.
3489         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3490         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3491         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3492         * iExploder/iexploder-1.3.2/htdocs: Added.
3493         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3494         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3495         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3496         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3497         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3498         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3499         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3500         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3501         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3502         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3503         * iExploder/iexploder-1.3.2/tools: Added.
3504         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3505         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3506         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3507         * iExploder/iexploder-1.7.2: Added.
3508         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3509         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3510         * iExploder/iexploder-1.7.2/README.txt: Added.
3511         * iExploder/iexploder-1.7.2/output: Added.
3512         * iExploder/iexploder-1.7.2/src: Added.
3513         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3514         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3515         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3516         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3517         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3518         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3519         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3520         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3521         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3522         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3523         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3524         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3525         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3526         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3527         * iExploder/iexploder-1.7.2/src/css-values: Added.
3528         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3529         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3530         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3531         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3532         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3533         * iExploder/iexploder-1.7.2/src/headers: Added.
3534         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3535         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3536         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3537         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3538         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3539         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3540         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3541         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3542         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3543         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3544         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3545         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3546         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3547         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3548         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3549         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3550         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3551         * iExploder/iexploder-1.7.2/src/html-values: Added.
3552         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3553         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3554         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3555         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3556         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3557         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3558         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3559         * iExploder/iexploder-1.7.2/src/index.html: Added.
3560         * iExploder/iexploder-1.7.2/src/media: Added.
3561         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3562         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3563         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3564         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3565         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3566         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3567         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3568         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3569         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3570         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3571         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3572         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3573         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3574         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3575         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3576         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3577         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3578         * iExploder/iexploder-1.7.2/src/protocols: Added.
3579         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3580         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3581         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3582         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3583         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3584         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3585         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3586         * iExploder/iexploder-1.7.2/testcases: Added.
3587         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3588         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3589         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3590         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3591         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3592         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3593         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3594         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3595         * iExploder/iexploder-1.7.2/tools: Added.
3596         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3597         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3598         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3599         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3600         * iExploder/tools: Removed.
3601
3602 2010-12-13  Sam Weinig  <sam@webkit.org>
3603
3604         Reviewed by Anders Carlsson.
3605
3606         Remove associated page concept from WKView constructor
3607         https://bugs.webkit.org/show_bug.cgi?id=50983
3608
3609         Step 1: Remove associate page constructors from WKView and make
3610         all views use the shared namespace for the context.
3611
3612         * TestWebKitAPI/PlatformWebView.h:
3613         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3614         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3615         * WebKitTestRunner/PlatformWebView.h:
3616         * WebKitTestRunner/TestController.cpp:
3617         (WTR::createOtherPage):
3618         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3619         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3620         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3621
3622 2010-12-13  Sam Weinig  <sam@webkit.org>
3623
3624         Reviewed by Anders Carlsson.
3625
3626         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3627         https://bugs.webkit.org/show_bug.cgi?id=50898
3628
3629         * MiniBrowser/mac/AppDelegate.h:
3630         * MiniBrowser/mac/AppDelegate.m:
3631         * MiniBrowser/mac/BrowserWindowController.h:
3632         * MiniBrowser/mac/BrowserWindowController.m:
3633         * MiniBrowser/win/BrowserView.cpp:
3634         Convert MiniBrowser to not use PageNamespaces.
3635
3636         * TestWebKitAPI/PlatformWebView.h:
3637         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3638         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3639         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3640         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3641         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3642         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3643         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3644         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3645         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3646         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3647         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3648         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3649         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3650         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3651         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3652         Convert TestWebKitAPI to not use PageNamespaces.
3653
3654         * WebKitTestRunner/PlatformWebView.h:
3655         * WebKitTestRunner/TestController.cpp:
3656         * WebKitTestRunner/TestController.h:
3657         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3658         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3659         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3660         Convert WebKitTestRunner to not use PageNamespaces.
3661
3662 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3663
3664         Reviewed by Eric Seidel.
3665
3666         webkit-patch rollout should be able to do multi-revision rollouts
3667         https://bugs.webkit.org/show_bug.cgi?id=33336
3668
3669         Make it possible to pass more than one revision to webkit-patch.
3670
3671         * Scripts/webkitpy/common/checkout/api.py:
3672         * Scripts/webkitpy/common/checkout/changelog.py:
3673         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3674         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3675         * Scripts/webkitpy/tool/commands/download.py:
3676         * Scripts/webkitpy/tool/commands/download_unittest.py:
3677         * Scripts/webkitpy/tool/mocktool.py:
3678         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3679         * Scripts/webkitpy/tool/steps/revertrevision.py:
3680
3681 2010-12-13  Eric Seidel  <eric@webkit.org>
3682
3683         Unreviewed.
3684
3685         Teach webkit-patch how to search bugzilla
3686         https://bugs.webkit.org/show_bug.cgi?id=50500
3687
3688         webkit-patch bug-search fails when there is only one result.
3689         Turns out we needed a bit more logic in our result count parsing code.
3690
3691         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3692         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3693
3694 2010-12-13  Antti Koivisto  <antti@apple.com>
3695
3696         Reviewed by Alexey Proskuryakov.
3697
3698         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3699         https://bugs.webkit.org/show_bug.cgi?id=50758
3700
3701         * DumpRenderTree/LayoutTestController.cpp:
3702         (setSerializeHTTPLoadsCallback):
3703         (LayoutTestController::staticFunctions):
3704         * DumpRenderTree/LayoutTestController.h:
3705         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3706         (LayoutTestController::setSerializeHTTPLoads):
3707         * DumpRenderTree/mac/DumpRenderTree.mm:
3708         (resetDefaultsToConsistentValues):
3709         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3710         (LayoutTestController::setSerializeHTTPLoads):
3711         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3712         (LayoutTestController::setSerializeHTTPLoads):
3713
3714 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3715
3716         Reviewed by Ojan Vafai.
3717
3718         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3719         https://bugs.webkit.org/show_bug.cgi?id=50936
3720
3721         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3722
3723 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3724
3725         Reviewed by Csaba Osztrogonác.
3726
3727         Add revlink to BuildBot status
3728         https://bugs.webkit.org/show_bug.cgi?id=50914
3729
3730         This adds a hyperlink to trac changeset on the revision numbers. 
3731
3732         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3733
3734 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3735
3736         Reviewed by Csaba Osztrogonác.
3737
3738         [Qt][WK2] Fix build if WebKitTools are not available
3739         https://bugs.webkit.org/show_bug.cgi?id=50242
3740