f7dbc755fb22ab34e803eae6978f696fb487f7a4
[WebKit.git] / Tools / ChangeLog
1 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         nrwt: handle "broken pipe" notifications from DRT more cleanly.
6
7         https://bugs.webkit.org/show_bug.cgi?id=52927
8
9         * Scripts/webkitpy/layout_tests/port/server_process.py:
10         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
11
12 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
13
14         Reviewed by Kenneth Russell.
15
16         Update, resubmit change to bug 51572. I think the race that was
17         fixed in r76703 caused the hang that caused us to roll this
18         patch out before, so I'd like to try again.
19
20         https://bugs.webkit.org/show_bug.cgi?id=51572
21
22         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
23         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
24
25 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
26
27         Unreviewed.
28
29         Adding myself to committers.py.
30
31         * Scripts/webkitpy/common/config/committers.py:
32
33 2011-02-03  Adam Roben  <aroben@apple.com>
34
35         Include the crashing function in the link to a crash log
36
37         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
38         function that crashed
39
40         Reviewed by David Kilzer.
41
42         * Scripts/old-run-webkit-tests:
43         (crashLocation): Added. Returns the location of the crash.
44         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
45         could be determined.
46
47 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
48
49         Unreviewed, build fix.
50
51         Actually make the changes suggested by Mihai in his review
52         of bug 53720 :(
53
54         https://bugs.webkit.org/show_bug.cgi?id=53720
55
56         * Scripts/webkitpy/layout_tests/port/test_files.py:
57         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
58
59 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
60
61         Reviewed by Mihai Parparita.
62
63         new-run-webkit-tests: Fix bug introduced in r77434 that was
64         causing us to run the canvas GPU tests on the Mac GPU port. This
65         bug revealed that we were not setting the port.name() field
66         properly in many cases, so I've cleaned up all of that code, and
67         removed a few comments about "version-specific" GPU ports that
68         don't exist and just confused things.
69
70         Testing also revealed that port.abspath_for_test() wasn't
71         normalizing paths on Windows properly, so I fixed that as well.
72
73         https://bugs.webkit.org/show_bug.cgi?id=53719
74
75         * Scripts/webkitpy/layout_tests/port/base.py:
76         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
77         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
78
79 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
80
81         Reviewed by Mihai Parparita.
82
83         new-run-webkit-tests: fix normalization of paths on windows when gathering files
84
85         r77434 introduced a bug that was causing the test expectations
86         for the GPU ports to not be treated properly. It turns out that
87         when we gathered the list of test files on Windows, we would
88         return paths of the form "c:\LayoutTests/fast/canvas", and the
89         mixture of backslashes and forward slashes was confusing things.
90
91         This patch normalizes all of the filenames returned from
92         test_files.find(), and adds better tests for this (fixing a
93         couple of other bugs found in the meantime).
94
95         https://bugs.webkit.org/show_bug.cgi?id=53720
96
97         * Scripts/webkitpy/layout_tests/port/test.py:
98         * Scripts/webkitpy/layout_tests/port/test_files.py:
99         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
100
101 2011-02-03  Adam Roben  <aroben@apple.com>
102
103         Add links to Windows crash logs in results.html
104
105         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
106         results.html
107
108         Reviewed by David Kilzer.
109
110         * Scripts/old-run-webkit-tests:
111         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
112         createDebuggerCommandFile).
113         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
114         tool has exited.
115         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
116         it into the test results directory tree. Only implemented for Cygwin currently.
117         (findNewestFileMatchingGlob): Added. Does what it says.
118         (htmlForResultsSection): Only link to files that exist.
119         (linksForErrorTest): Add a link to the crash log.
120         (deleteExpectedAndActualResults): Delete any old crash log for this test.
121         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
122         hardcoding it here.
123
124 2011-02-03  Adam Roben  <aroben@apple.com>
125
126         Tell the debugger the path to the WebKit source tree when saving a crash log
127
128         This allows the debugger to include the crashing line of code in the log.
129
130         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
131         of code
132
133         Reviewed by Sam Weinig.
134
135         * Scripts/old-run-webkit-tests:
136         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
137         file and returns the path to that file. The commands we pass came from
138         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
139         WebKit source code lives.
140         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
141         line using -c, save them to a file and specify the path to that file using -cf. This works
142         around what is presumably a bug in Windows's command line parsing, where having multiple
143         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
144         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
145         together to make them easier to modify in the future.
146
147 2011-02-02  Sam Weinig  <sam@webkit.org>
148
149         Reviewed by Anders Carlsson.
150
151         Add notification of the end of a rubber band.
152         <rdar://problem/8940648>
153
154         * MiniBrowser/mac/BrowserWindowController.m:
155         (-[BrowserWindowController awakeFromNib]):
156         * WebKitTestRunner/TestController.cpp:
157         (WTR::TestController::createOtherPage):
158         (WTR::TestController::initialize):
159         Stub out the new WKUIClient function.
160
161 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
162
163         Unreviewed.
164
165         Adding myself to committers.py.
166
167         * Scripts/webkitpy/common/config/committers.py:
168
169 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
170
171         Reviewed by Csaba Osztrogonác.
172
173         [Qt][WK2] MiniBrowser's window size should be 800x600
174         https://bugs.webkit.org/show_bug.cgi?id=53670
175
176         Make layout test failure debugging easier.
177         * MiniBrowser/qt/BrowserWindow.cpp:
178         (BrowserWindow::BrowserWindow):
179
180 2011-02-02  Andy Estes  <aestes@apple.com>
181
182         Reviewed by Mark Rowe.
183
184         'update-webkit' should handle OpenSource and Internal using different
185         VCSs.
186
187         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
188         Internal directory.
189
190 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
191
192         Reviewed by Mihai Parparita.
193
194         new-run-webkit-tests: hardcode the directories to scan for tests
195         for GPU bots instead of SKIPping them. See bug 53562 for some
196         context, but we will now hard-code the list of directories to
197         use by default instead of skipping over directories in the
198         expectations file. We do this so that we will be able to merge
199         the expectations files without getting conflicting SKIP
200         directives. Note that this change will reduce the # of tests
201         being run on the Mac GPU bots, because we're accidentally
202         including some today.
203
204         https://bugs.webkit.org/show_bug.cgi?id=53631
205
206         * Scripts/webkitpy/layout_tests/port/base.py:
207         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
208         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
209
210 2011-02-02  Sam Weinig  <sam@webkit.org>
211
212         Reviewed by Beth Dakin.
213
214         Add ChromeClient function to paint custom overhang areas.
215         https://bugs.webkit.org/show_bug.cgi?id=53639
216
217         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
218         (WTR::InjectedBundlePage::InjectedBundlePage):
219         Stub out new callback.
220
221 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
222
223         Reviewed by Tony Chang.
224
225         new-run-webkit-tests: support chromium code paths in mock_drt
226
227         https://bugs.webkit.org/show_bug.cgi?id=53471
228
229         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
230         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
231
232 2011-02-02  Adam Klein  <adamk@chromium.org>
233
234         Reviewed by Tony Chang.
235
236         Update new-run-webkit-tests --chromium to put output under Source/...
237         https://bugs.webkit.org/show_bug.cgi?id=53612
238
239         * BuildSlaveSupport/test-result-archive:
240         * Scripts/webkitpy/layout_tests/port/chromium.py:
241
242 2011-01-28  Tony Chang  <tony@chromium.org>
243
244         Reviewed by Eric Seidel.
245
246         [chromium] remove --use-test-shell from NRWT
247         https://bugs.webkit.org/show_bug.cgi?id=53346
248
249         I've already started removing some of the bindings like eventSender so
250         this already doesn't work isn't useful.  Also updated some comments to
251         refer to DRT instead of test_shell.
252
253         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
254         * Scripts/webkitpy/layout_tests/port/chromium.py:
255         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
256         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
257         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
258         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
259         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
260         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
261
262 2011-02-02  Steve Lacey  <sjl@chromium.org>
263
264         Reviewed by Eric Carlson.
265
266         Implement basic media statistics on media elements.
267         https://bugs.webkit.org/show_bug.cgi?id=53322
268
269         * Scripts/build-webkit:
270
271 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
272
273         [wx] Build fixes for wxWebKit.
274
275         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
276         (LayoutTestController::setSerializeHTTPLoads):
277         * wx/browser/wscript:
278         * wx/build/build_utils.py:
279         * wx/build/settings.py:
280
281 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
282
283         Reviewed by Mihai Parparita.
284
285         new-run-webkit-tests: stop skipping so many tests
286
287         r77163 introduced a regression where we weren't resetting test
288         expectations properly and were skipping too many tests as a
289         result. This patch fixes that and adds a test for it.
290
291         https://bugs.webkit.org/show_bug.cgi?id=53551
292
293         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
294         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
295
296 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
297
298         Reviewed by Tony Chang.
299
300         new-run-webkit-tests: add first stub of test_runner2. This
301         will add support for the 'inline', 'threads', and 'processes'
302         flags to --worker-model, but for now the implementatios just
303         fall back on the old ones.
304
305         https://bugs.webkit.org/show_bug.cgi?id=53157
306
307         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
308         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
309
310 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
311
312         Reviewed by James Robinson.
313
314         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
315         https://bugs.webkit.org/show_bug.cgi?id=53522
316
317         * Scripts/run-chromium-webkit-unit-tests:
318
319 2011-02-01  Adam Barth  <abarth@webkit.org>
320
321         Reviewed by Mihai Parparita.
322
323         Using Control-C to cancel webkit-patch or other python tools causes
324         unpleasant traceback console spew
325         https://bugs.webkit.org/show_bug.cgi?id=53462
326
327         Catch the exception and don't print the stack trace.
328
329         * Scripts/webkit-patch:
330
331 2011-02-01  Scott Cameron  <sccameron@rim.com>
332
333         Reviewed by Daniel Bates.
334
335         Use Windows format for MinGW HTTPD path.
336         https://bugs.webkit.org/show_bug.cgi?id=53503
337
338         * Scripts/webkitperl/httpd.pm:
339           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
340             so that we don't have to escape the space characters in the path. Also,
341             changed path to Windows-style path and removed FIXME comment.
342
343 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
344
345         Reviewed by Andreas Kling.
346
347         [Qt][WK2] Add a way to use shared process model in MiniBrowser
348         https://bugs.webkit.org/show_bug.cgi?id=53090
349
350         * MiniBrowser/qt/BrowserView.cpp:
351         (BrowserView::BrowserView): Removed the m_context member.
352         From now the context is guaranteed to be non-null and we
353         don't need to store that in the object.
354         * MiniBrowser/qt/BrowserView.h:
355         * MiniBrowser/qt/BrowserWindow.cpp:
356         Added static bool to determine that new windows need to be
357         created with their own context or not. Use the same context
358         and web process by default to be inilne with the other ports.
359         (BrowserWindow::BrowserWindow):
360         (BrowserWindow::newWindow):
361         * MiniBrowser/qt/BrowserWindow.h:
362         * MiniBrowser/qt/main.cpp:
363         (main): Added command line switch to be able to use the
364         non-shared process model. Simplify the handling of the command line
365         switches a little bit.
366
367 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
368
369         Reviewed by Andreas Kling.
370
371         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
372         https://bugs.webkit.org/show_bug.cgi?id=53491
373
374         * MiniBrowser/qt/BrowserWindow.cpp:
375         (BrowserWindow::BrowserWindow):
376         (BrowserWindow::toggleFullScreenMode):
377         * MiniBrowser/qt/BrowserWindow.h:
378
379 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
380
381         Reviewed by Andreas Kling.
382
383         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
384         https://bugs.webkit.org/show_bug.cgi?id=53489
385
386         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
387         to Settings menu.
388
389         * MiniBrowser/qt/BrowserWindow.cpp:
390         (BrowserWindow::BrowserWindow):
391         (BrowserWindow::toggleFrameFlattening):
392         (BrowserWindow::toggleDisableJavaScript):
393         (BrowserWindow::toggleAutoLoadImages):
394         * MiniBrowser/qt/BrowserWindow.h:
395
396 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
397
398         Reviewed by Tony Chang.
399
400         [Chromium] Switch chromium-mac to use ChromiumDriver
401         https://bugs.webkit.org/show_bug.cgi?id=53461
402         
403         For the sake of consistency with the other Chromium platforms (and so
404         that chromium-mac picks up special flags like --enable-hardware-gpu),
405         switch chromium-mac from the WebKitDriver to ChromiumDriver.
406
407         * Scripts/webkitpy/layout_tests/port/chromium.py:
408
409 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
410
411         Reviewed by Mihai Parparita.
412
413         The current modifier parsing code in test_expectations is
414         fragile and hard-coded, so it's not easy to understand the logic
415         or easily add new types of modifiers (like GPU vs. CPU testing
416         for graphics tests, or 32-bit vs. 64-bit differences).
417
418         This is the first of two patches that will add in more generic
419         support and then eliminate the GPU-specific test expectations
420         files for Chromium.
421
422         This patch adds two standalone objects for handling modifiers. The
423         rules for interpreting modifiers, precedence, and conflicts are
424         given in the docstring to the ModifierMatcher class, which
425         returns ModifierMatchResult objects.
426         
427         This patch also adds routines to the Port interface and a
428         default set of values in the base object, in order to obtain the
429         values needed on a given test run. These values are then passed
430         to the expectation parser. This also allows us to clean up the
431         logic used to lint all of the different configurations in a
432         single test_expectations.txt file.
433
434         The next patch will merge in the separate GPU expectations file.
435
436         https://bugs.webkit.org/show_bug.cgi?id=51222
437
438         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
439         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
440         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
441         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
442         * Scripts/webkitpy/layout_tests/port/base.py:
443         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
444         * Scripts/webkitpy/layout_tests/port/chromium.py:
445         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
446         * Scripts/webkitpy/layout_tests/port/test.py:
447         * Scripts/webkitpy/layout_tests/port/webkit.py:
448         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
449         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
450         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
451         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
452         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
453
454 2011-01-31  Scott Cameron  <sccameron@rim.com>
455
456         Reviewed by Daniel Bates.
457
458         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
459         https://bugs.webkit.org/show_bug.cgi?id=50036
460
461         This will add an Apache2.2 configuration file and modifies scripts to allow
462         running an httpd server in an MSYS environment.
463
464         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
465         in order to allow for simple installation/execution.  Simply install the latest
466         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
467         be able to execute run-webkit-httpd.
468         
469
470         * Scripts/run-webkit-httpd:
471         * Scripts/webkitperl/httpd.pm:
472
473 2011-01-31  Tony Chang  <tony@chromium.org>
474
475         Reviewed by Eric Seidel.
476
477         mac DRT should report RTL scroll offset relative to top right corner
478         https://bugs.webkit.org/show_bug.cgi?id=53324
479
480         * DumpRenderTree/mac/DumpRenderTree.mm:
481         (dumpFrameScrollPosition):
482
483 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
484
485         Reviewed by Andreas Kling.
486
487         [Qt] Add Take Screen Shot action to MiniBrowser
488         https://bugs.webkit.org/show_bug.cgi?id=53422
489
490         Add Take Screen Shot action to MiniBrowser's view menu.
491
492         * MiniBrowser/qt/BrowserWindow.cpp:
493         (BrowserWindow::BrowserWindow):
494         (BrowserWindow::screenshot):
495         * MiniBrowser/qt/BrowserWindow.h:
496
497 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
498
499         Reviewed by Xan Lopez.
500
501         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
502         https://bugs.webkit.org/show_bug.cgi?id=53379
503
504         Remove left over #ifdef's. I thought all of the conditional code
505         had been freed from the condition, but I forgot to check DRT.
506
507         * DumpRenderTree/gtk/DumpRenderTree.cpp:
508         (resetDefaultsToConsistentValues):
509         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
510         (LayoutTestController::setAlwaysAcceptCookies):
511
512 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
513
514         Unreviewed, build fix.
515
516         Fix regression introduced in r77093 - path.rsplit() doesn't
517         take keyword arguments.
518
519         https://bugs.webkit.org/show_bug.cgi?id=53326
520
521         * Scripts/webkitpy/common/system/filesystem_mock.py:
522
523 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
524
525         Reviewed by Mihai Parparita.
526
527         Add more unit tests for rebaseline-chromium-webkit-tests. This
528         change involves restructuring a bunch of r-c-w-t code to make it
529         more testable as well. We also add wrapper classes for handling
530         testing zip files and fetching URLs.
531
532         https://bugs.webkit.org/show_bug.cgi?id=53040
533
534         * Scripts/webkitpy/common/system/urlfetcher.py:
535         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
536         * Scripts/webkitpy/common/system/zipfileset_mock.py:
537         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
538         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
539         * Scripts/webkitpy/tool/mocktool.py:
540
541 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
542
543         Reviewed by Eric Seidel.
544
545         Clean up of the filesystem-related modules used in webkitpy.
546         I've added relpath() to the filesystem interface, modified
547         ospath.relpath() so that it could work with the filesystem
548         interface, and modified the fileset* routines to use the
549         filesystem interface consistently.
550
551         This patch also adds a close() routine to the fileset routines
552         to indicate that the caller is done with the fileset. This
553         allows zipfileset to clean up after itself when it creates
554         tempfiles to store downloads.
555
556         https://bugs.webkit.org/show_bug.cgi?id=53326
557
558         * Scripts/webkitpy/common/system/directoryfileset.py:
559         * Scripts/webkitpy/common/system/fileset.py:
560         * Scripts/webkitpy/common/system/filesystem.py:
561         * Scripts/webkitpy/common/system/filesystem_mock.py:
562         * Scripts/webkitpy/common/system/filesystem_unittest.py:
563         * Scripts/webkitpy/common/system/ospath.py:
564         * Scripts/webkitpy/common/system/zipfileset.py:
565         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
566
567 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
568
569         Reviewed by Csaba Osztrogonác.
570
571         [Qt][WK2]REGRESSION (r76991): Fix build errors
572         https://bugs.webkit.org/show_bug.cgi?id=53400
573
574         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
575         and remove WebKit2Prefix.h from the build.
576         * MiniBrowser/qt/MiniBrowser.pro:
577
578 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
579
580         Unreviewed.
581
582         [Qt][WK2] Buildfix.
583
584         * MiniBrowser/qt/MiniBrowser.pro:
585
586 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
587
588         Reviewed by Adam Roben.
589         
590         define NOMINMAX when building ImageDiff, as we do elsewhere.
591
592         Add various clampToInt() methods to MathExtras.h
593         https://bugs.webkit.org/show_bug.cgi?id=52910
594
595         * DumpRenderTree/win/ImageDiffCommon.vsprops:
596
597 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
598
599         Reviewed by Darin Adler.
600
601         WebKitTestRunner needs layoutTestController.setPOSIXLocale
602         https://bugs.webkit.org/show_bug.cgi?id=42682
603
604         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
605         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
606         (WTR::InjectedBundle::resetLocalSettings):
607         (WTR::InjectedBundle::didReceiveMessage):
608         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
609         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
610         (WTR::LayoutTestController::setPOSIXLocale):
611         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
612
613 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
614  
615          Reviewed by Mihai Parparita.
616  
617          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
618  
619          This patch re-enables this test and changes it to
620          handle all of the mac platform versions, not just the one
621          it is running on.
622  
623          https://bugs.webkit.org/show_bug.cgi?id=53356
624  
625          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
626  
627 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
628
629         Unreviewed, build fix.
630
631         Take two. The fix in 77023 didn't work, because we were
632         still calling path.abspath_to_uri, which calls _cygpath under
633         the covers, and it appears the cygpath on the bots does
634         something different than it does on my machine. This patch
635         removes the calls to path.abspath_to_uri, so it should be safe.
636         If it doesn't work, I'll roll it out along with r76982 and 77023.
637
638         https://bugs.webkit.org/show_bug.cgi?id=53126
639
640         * Scripts/webkitpy/layout_tests/port/test.py:
641
642 2011-01-28  David Kilzer  <ddkilzer@apple.com>
643
644         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
645         <http://webkit.org/b/53353>
646
647         Reviewed by Mark Rowe.
648
649         * Scripts/webkitdirs.pm:
650         (checkRequiredSystemConfig): Check the Xcode marketing version
651         in addition to the DevCoreTools build version before complaining
652         about an old version of Xcode.  Also make the Mac OS X version
653         check use Perl's built-in version string comparitor.
654
655 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
656
657         Unreviewed, build fix.
658
659         Work around breakage on Win 7 Release bot caused by r76982
660         and the fact that windows ports use "file:////" instead of
661         "file:///". Ideally the test code should be isolated from
662         this, but it isn't yet. Will fix properly in a bit.
663
664         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
665
666 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
667
668         Reviewed by Tony Chang.
669
670         new-run-webkit-tests: change worker model values to
671         "old-inline", "old-threads" in preparation for test_runner2 /
672         multiprocessing changes.
673
674         https://bugs.webkit.org/show_bug.cgi?id=53156
675
676         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
677         * Scripts/webkitpy/layout_tests/port/base.py:
678         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
679         * Scripts/webkitpy/layout_tests/port/mac.py:
680         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
681
682 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
683
684         Reviewed by Tony Chang.
685
686         committers.py - add an IRC nickname for dpranke
687         https://bugs.webkit.org/show_bug.cgi?id=53335
688
689         * Scripts/webkitpy/common/config/committers.py:
690
691 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
692
693         Reviewed by Tony Chang.
694
695         new-run-webkit-tests: add a "mock DRT" port implementation
696         and a separate class that emulates what we expect the
697         DumpRenderTree behavior to be.
698
699         This will eventually replace port/dryrun.py and allow us to get
700         better test coverage of the new-run-webkit-tests code as well as
701         a reference for what new-run-webkit-tests expects from DRT.
702
703         This is the first attempt at this, and it is pretty bare-boned. It
704         really only has been tested on the 'mac' port (and a little on
705         the 'chromium-mac' port.
706
707         https://bugs.webkit.org/show_bug.cgi?id=53126
708
709         * Scripts/webkitpy/common/system/filesystem_mock.py:
710         * Scripts/webkitpy/layout_tests/port/dryrun.py:
711         * Scripts/webkitpy/layout_tests/port/factory.py:
712         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
713         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
714         * Scripts/webkitpy/layout_tests/port/test.py:
715
716 2011-01-28  Pratik Solanki  <psolanki@apple.com>
717
718         Unreviewed. Removing .swp file checked in by mistake.
719
720         * Scripts/.webkitdirs.pm.swp: Removed.
721
722 2011-01-28  Pratik Solanki  <psolanki@apple.com>
723
724         Reviewed by David Kilzer.
725
726         Space not necessary for undefined feature
727         https://bugs.webkit.org/show_bug.cgi?id=53317
728
729         * Scripts/build-webkit:
730
731 2011-01-28  Chang Shu  <chang.shu@nokia.com>
732
733         Reviewed by Andreas Kling.
734
735         Reset NetworkAccessManager to clean up credentials from previous tests.
736         This change causes no performance overhead either.
737         https://bugs.webkit.org/show_bug.cgi?id=36688
738
739         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
740         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
741         (WebCore::DumpRenderTree::open):
742         * DumpRenderTree/qt/DumpRenderTreeQt.h:
743
744 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
745
746         Reviewed by Andreas Kling.
747
748         [Qt] Add Zoom Text Only action to MiniBrowser
749         https://bugs.webkit.org/show_bug.cgi?id=53297
750
751         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
752
753         * MiniBrowser/qt/BrowserWindow.cpp:
754         (BrowserWindow::BrowserWindow):
755         (BrowserWindow::zoomIn):
756         (BrowserWindow::zoomOut):
757         (BrowserWindow::resetZoom):
758         (BrowserWindow::toggleZoomTextOnly):
759         (BrowserWindow::applyZoom):
760         * MiniBrowser/qt/BrowserWindow.h:
761
762 2011-01-28  Adam Barth  <abarth@webkit.org>
763
764         Reviewed by Eric Seidel.
765
766         Add webkit-patch roll-chromium-deps
767         https://bugs.webkit.org/show_bug.cgi?id=53288
768
769         This command updates the Source/WebKit/chromium/DEPS file with the
770         last-known good revision of Chromium (or a revision specified on the
771         command line).  I'd eventually like to turn this into a SheriffBot
772         command, but this is the first step.
773
774         This patch somewhat sprawled because I needed to move a bunch of code
775         out of ChangeLog that should never have been there in the first place.
776         Also, I had to fix a bug in MockUser in order to test the new command.
777
778         * Scripts/webkitpy/common/checkout/api.py:
779         * Scripts/webkitpy/common/checkout/changelog.py:
780         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
781         * Scripts/webkitpy/common/checkout/deps.py: Added.
782         * Scripts/webkitpy/common/config/urls.py:
783         * Scripts/webkitpy/tool/commands/__init__.py:
784         * Scripts/webkitpy/tool/commands/download_unittest.py:
785         * Scripts/webkitpy/tool/commands/roll.py: Added.
786         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
787         * Scripts/webkitpy/tool/commands/upload_unittest.py:
788         * Scripts/webkitpy/tool/mocktool.py:
789         * Scripts/webkitpy/tool/steps/__init__.py:
790         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
791         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
792         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
793         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
794         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
795         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
796
797 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
798
799         Reviewed by Laszlo Gombos.
800
801         Get rid of prefix header dependency for WebKit2 build system
802         https://bugs.webkit.org/show_bug.cgi?id=50174
803
804         Change the style checker so that it enforces config.h include for
805         WebKit2.
806
807         * Scripts/webkitpy/style/checker.py:
808
809 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
810
811         Reviewed by Darin Adler.
812
813         execCommand("Paste") doesn't work in WebKitTestRunner
814         https://bugs.webkit.org/show_bug.cgi?id=52785
815
816         Enable both of the settings needed to allow paste.
817         
818         * WebKitTestRunner/TestController.cpp:
819         (WTR::TestController::resetStateToConsistentValues):
820
821 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
822
823         Reviewed by Andreas Kling.
824
825         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
826         https://bugs.webkit.org/show_bug.cgi?id=48440
827
828         Preserve user input when toggling use of QGraphicsView
829
830         * QtTestBrowser/launcherwindow.cpp:
831         (LauncherWindow::initializeView):
832         (LauncherWindow::loadFinished):
833         * QtTestBrowser/launcherwindow.h:
834         * QtTestBrowser/mainwindow.cpp:
835         (MainWindow::addressUrl):
836         * QtTestBrowser/mainwindow.h:
837
838 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
839
840         Reviewed by Mihai Parparita.
841
842         new-run-webkit-tests: turn off pixel tests correctly by default
843         for webkit-based ports. r70013 (bug 47510) used
844         port.set_option_default() to attempt to set default values, but
845         that didn't work correctly. I have removed set_option_default
846         for now since it was only being used in two places and in three
847         useless unit tests. There is a separate bug open to fix the
848         option parsing (48095), so this workaround is fine for now.
849
850         https://bugs.webkit.org/show_bug.cgi?id=53217
851
852         * Scripts/webkitpy/layout_tests/port/webkit.py:
853         * Scripts/webkitpy/layout_tests/port/base.py:
854         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
855
856 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
857
858         Rubber-stamped by Ariya Hidayat.
859
860         Trivial crash fix in WTR.
861
862         * WebKitTestRunner/TestController.cpp:
863         (WTR::TestController::initialize): Increase the size
864         of the vector by one to be able to store the null character.
865
866 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
867
868         Reviewed by Csaba Osztrogonác.
869
870         [Qt][WK2] WTR should be initialized in the same way as DRT
871         https://bugs.webkit.org/show_bug.cgi?id=53240
872
873         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
874         (WTR::activateFonts): Added missing initialization steps.
875
876 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
877
878         Unreviewed. 
879
880         Adding myself to committers.py.
881
882         * Scripts/webkitpy/common/config/committers.py:
883
884 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
885
886         Reviewed by Csaba Osztrogonác.
887
888         [Qt] [Symbian] Move project files into Source
889         https://bugs.webkit.org/show_bug.cgi?id=52891
890
891         Fix the Symbian build after the project files
892         are moved to Source directory. On Symbian qmake
893         needs to run in the same directory where the main
894         pro files (WebKit.pro, Tools.pro) are located.
895
896         * Scripts/webkitdirs.pm: Change to the directory where the pro file
897         is located before running qmake for Symbian. Qmake on Symbian
898         does not properly honor the "-o" option, work it around by setting
899         the name of the Makefile to bld.inf.
900
901 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
902
903         Reviewed by Andreas Kling.
904
905         [Qt] Add simple zooming features to MiniBrowser
906         https://bugs.webkit.org/show_bug.cgi?id=53231
907
908         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
909
910         * MiniBrowser/qt/BrowserWindow.cpp:
911         (BrowserWindow::BrowserWindow):
912         (BrowserWindow::zoomIn):
913         (BrowserWindow::zoomOut):
914         (BrowserWindow::resetZoom):
915         (BrowserWindow::updateUserAgentList):
916         (BrowserWindow::applyZoom):
917         * MiniBrowser/qt/BrowserWindow.h:
918
919 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
920
921         Reviewed by Dan Bernstein.
922
923         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
924         https://bugs.webkit.org/show_bug.cgi?id=42319
925         
926         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
927
928         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
929         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
930         (WTR::LayoutTestController::showWebInspector):
931         (WTR::LayoutTestController::closeWebInspector):
932         (WTR::LayoutTestController::evaluateInWebInspector):
933         (WTR::LayoutTestController::setTimelineProfilingEnabled):
934         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
935         * WebKitTestRunner/TestInvocation.cpp:
936         (WTR::shouldOpenWebInspector):
937         (WTR::TestInvocation::invoke):
938         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
939
940 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
941
942         Reviewed by Xan Lopez.
943
944         [GTK] Pixel dumps do not include scrollbars in output images
945         https://bugs.webkit.org/show_bug.cgi?id=53216
946
947         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
948         that have scrollbars.
949
950         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
951         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
952         instead of the web view itself.
953
954 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
955
956         Reviewed by Mihai Parparita.
957
958         Fix regression introduced in r76322 ... new-run-webkit-tests
959         was attempting to save the image diff output as a UTF-8-encoded
960         file.
961
962         https://bugs.webkit.org/show_bug.cgi?id=53210
963
964         * Scripts/webkitpy/layout_tests/port/webkit.py:
965
966 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
967
968         Unreviewed, rolling out r76709.
969         http://trac.webkit.org/changeset/76709
970         https://bugs.webkit.org/show_bug.cgi?id=53194
971
972         "broke python tests on non-snowleopard platforms" (Requested
973         by dpranke on #webkit).
974
975         * Scripts/webkitpy/layout_tests/port/factory.py:
976         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
977         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
978
979 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
980
981         Reviewed by Tony Chang.
982
983         new-run-webkit-tests: add a "mock DRT" port implementation
984         and a separate class that emulates what we expect the
985         DumpRenderTree behavior to be.
986
987         This will eventually replace port/dryrun.py and allow us to get
988         better test coverage of the new-run-webkit-tests code as well as
989         a reference for what new-run-webkit-tests expects from DRT.
990
991         This is the first attempt at this, and it is pretty bare-boned. It
992         really only has been tested on the 'mac' port (and a little on
993         the 'chromium-mac' port.
994
995         https://bugs.webkit.org/show_bug.cgi?id=53126
996
997         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
998         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
999         * Scripts/webkitpy/layout_tests/port/factory.py:
1000
1001 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1002
1003         Reviewed by Tony Chang.
1004
1005         Add '--no-timeout' option to Chromium DRT to ease debugging.
1006         https://bugs.webkit.org/show_bug.cgi?id=52873
1007
1008         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1009         (main):
1010
1011 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1012
1013         Reviewed by Andreas Kling.
1014
1015         [Qt] Fix qt_minimal build
1016         https://bugs.webkit.org/show_bug.cgi?id=53172
1017
1018         * QtTestBrowser/locationedit.h:
1019
1020 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1021
1022         Reviewed by Antonio Gomes.
1023
1024         QtTestBrowser should have a UI Setting to disable plugins
1025         https://bugs.webkit.org/show_bug.cgi?id=52408
1026         
1027         Added a new action item named "Disable Plugins"
1028         under the "Settings" menu. 
1029
1030         * QtTestBrowser/launcherwindow.cpp:
1031         (LauncherWindow::createChrome):
1032         (LauncherWindow::togglePlugins):
1033         * QtTestBrowser/launcherwindow.h:
1034
1035 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1036
1037         Reviewed by Adam Barth.
1038
1039         Move main CMakeLists.txt into Source directory
1040         https://bugs.webkit.org/show_bug.cgi?id=52888
1041
1042         * Scripts/webkitdirs.pm:
1043
1044 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1045
1046         Reviewed by Eric Seidel.
1047
1048         Improve label text in submit-to-ews
1049         https://bugs.webkit.org/show_bug.cgi?id=53130
1050
1051         * QueueStatusServer/templates/submittoews.html:
1052
1053 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1054
1055         Reviewed by Antonio Gomes.
1056
1057         QtTestBrowser should have a UI Settings to prevent loading images
1058         https://bugs.webkit.org/show_bug.cgi?id=52409
1059         
1060         Added a new action item named "DisableAutoLoadImages"
1061         under the "Settings" menu 
1062
1063         * QtTestBrowser/launcherwindow.cpp:
1064         (LauncherWindow::createChrome):
1065         (LauncherWindow::toggleAutoLoadImages):
1066         * QtTestBrowser/launcherwindow.h:
1067
1068 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1069
1070         Reviewed by Tony Chang.
1071
1072         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1073         classes, test_expectations.py. This change adds "test-win" and
1074         "test-mac" variants to the test port so that we can better test
1075         rebaselining, and adds a MockUser() object for reuse in testing.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=53036
1078
1079         * Scripts/webkitpy/common/system/filesystem.py:
1080         * Scripts/webkitpy/common/system/filesystem_mock.py:
1081         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1082         * Scripts/webkitpy/layout_tests/port/factory.py:
1083         * Scripts/webkitpy/layout_tests/port/base.py:
1084         * Scripts/webkitpy/layout_tests/port/test.py:
1085         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1086         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1087         * Scripts/webkitpy/tool/mocktool.py:
1088
1089 2011-01-25  Tony Chang  <tony@chromium.org>
1090
1091         Reviewed by Dimitri Glazkov.
1092
1093         [chromium] remove unused layoutTestController callback
1094         https://bugs.webkit.org/show_bug.cgi?id=53103
1095
1096         This method is used by a test_shell_test, but not needed by DRT.
1097
1098         * DumpRenderTree/chromium/LayoutTestController.cpp:
1099         (LayoutTestController::LayoutTestController):
1100         * DumpRenderTree/chromium/LayoutTestController.h:
1101
1102 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1103
1104         Reviewed by Andreas Kling.
1105
1106         [GTK] Remove 64 bits release bot from the buildbot master
1107         https://bugs.webkit.org/show_bug.cgi?id=52899
1108
1109         Removes the 64 bits release slave from the buildbot configuration,
1110         so that we can use it as an EWS.
1111
1112         * BuildSlaveSupport/build.webkit.org-config/config.json:
1113
1114 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1115
1116         Reviewed by Dan Bernstein.
1117
1118         Implement database quota callback to fix storage tests on WebKit2 bot
1119         https://bugs.webkit.org/show_bug.cgi?id=53064
1120
1121         * WebKitTestRunner/TestController.cpp:
1122         (WTR::exceededDatabaseQuota):
1123         (WTR::TestController::createOtherPage):
1124         (WTR::TestController::initialize):
1125
1126 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1127
1128         Reviewed by Anders Carlsson.
1129
1130         Use designated temp directory for the database for WebKit2
1131         https://bugs.webkit.org/show_bug.cgi?id=53052
1132         
1133         Adopt the new WK2 API for this.
1134
1135         * WebKitTestRunner/TestController.cpp:
1136         (WTR::TestController::libraryPathForTesting):
1137         (WTR::TestController::initialize):
1138         * WebKitTestRunner/TestController.h:
1139         * WebKitTestRunner/mac/TestControllerMac.mm:
1140         (WTR::TestController::platformLibraryPathForTesting):
1141         * WebKitTestRunner/qt/TestControllerQt.cpp:
1142         (WTR::TestController::platformLibraryPathForTesting):
1143         * WebKitTestRunner/win/TestControllerWin.cpp:
1144         (WTR::TestController::platformLibraryPathForTesting):
1145
1146 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1147
1148         Reviewed by Stephanie Lewis.
1149
1150         Add a new Leopard test bot.
1151
1152         * BuildSlaveSupport/build.webkit.org-config/config.json:
1153
1154 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1155
1156         Reviewed by Adam Barth.
1157
1158         Add EFL Builder to core waterfall
1159         https://bugs.webkit.org/show_bug.cgi?id=52704
1160
1161         Add EFL Builder to the core waterfall again.
1162
1163         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1164         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1165
1166 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1167
1168         Reviewed by Tony Chang.
1169
1170         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1171         https://bugs.webkit.org/show_bug.cgi?id=52872
1172
1173         Force disabling proxy to resolve the problem.
1174
1175         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1176         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1177
1178 2011-01-24  Andreas Kling  <kling@webkit.org>
1179
1180         Reviewed by Darin Adler.
1181
1182         check-webkit-style: Update exemptions following Source/ move.
1183         https://bugs.webkit.org/show_bug.cgi?id=53017
1184
1185         * Scripts/webkitpy/style/checker.py:
1186         * Scripts/webkitpy/style/checker_unittest.py:
1187
1188 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1189
1190         Rubber-stamped by Csaba Osztrogonác.
1191
1192         [Qt] Move project files into Source
1193         https://bugs.webkit.org/show_bug.cgi?id=52891
1194
1195         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1196
1197 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1198
1199         Reviewed by Yury Semikhatsky.
1200
1201         Web Inspector: Find duplicate strings in localizedStrings.js
1202
1203         https://bugs.webkit.org/show_bug.cgi?id=53005
1204
1205         * Scripts/check-inspector-strings:
1206
1207 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1208
1209         Reviewed by Andreas Kling.
1210
1211         [Qt] Regroup MiniBrowser's menubar and add open file action
1212         https://bugs.webkit.org/show_bug.cgi?id=53000
1213
1214         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1215
1216         * MiniBrowser/qt/BrowserWindow.cpp:
1217         (BrowserWindow::BrowserWindow):
1218         (BrowserWindow::openFile):
1219         (BrowserWindow::~BrowserWindow):
1220         * MiniBrowser/qt/BrowserWindow.h:
1221
1222 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1223
1224         Unreviewed fix after r76496
1225
1226         [Qt] Move project files into Source
1227         https://bugs.webkit.org/show_bug.cgi?id=52891
1228
1229         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1230         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1231         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1232
1233 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1234
1235         Reviewed by Csaba Osztrogonác.
1236
1237         [Qt] Move project files into Source
1238         https://bugs.webkit.org/show_bug.cgi?id=52891
1239
1240         * DerivedSources.pro: Renamed from DerivedSources.pro.
1241         * DumpRenderTree/qt/DumpRenderTree.pro:
1242         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1243         * MiniBrowser/DerivedSources.pro:
1244         * MiniBrowser/qt/MiniBrowser.pro:
1245         * QtTestBrowser/QtTestBrowser.pro:
1246         * Scripts/webkitdirs.pm:
1247         * Tools.pro: Added.
1248         * WebKitTestRunner/DerivedSources.pro:
1249         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1250         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1251
1252 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1253
1254         Reviewed by Dan Bernstein.
1255
1256         Beefed up --threaded mode to catch even more kinds of errors.
1257         https://bugs.webkit.org/show_bug.cgi?id=52971
1258
1259         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1260         context group to force JSC to mark multiple threads. (This used to be
1261         the default, but it changed in SnowLeopard.)
1262         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1263         to give threading mistakes more chances to show themselves.
1264         (startJavaScriptThreads):
1265         (stopJavaScriptThreads):
1266
1267 2011-01-22  Robert Hogan  <robert@webkit.org>
1268
1269         Reviewed by Andreas Kling.
1270
1271         [Qt] Support layoutTestController.addURLToRedirect()
1272         https://bugs.webkit.org/show_bug.cgi?id=52956
1273
1274         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1275         (LayoutTestController::addURLToRedirect):
1276         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1277
1278 2011-01-22  Robert Hogan  <robert@webkit.org>
1279
1280         Reviewed by Kenneth Rohde Christiansen.
1281
1282         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1283         https://bugs.webkit.org/show_bug.cgi?id=49802
1284
1285         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1286         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1287         (WebCore::DumpRenderTree::open):
1288
1289 2011-01-21  Adam Barth  <abarth@webkit.org>
1290
1291         Reviewed by Maciej Stachowiak.
1292
1293         Disable mac_unittest.py that fails on some of the Mac bots
1294         https://bugs.webkit.org/show_bug.cgi?id=52947
1295
1296         As noted in the comment, this test does not appear to be correct
1297         because the function this test is testing returns different results
1298         depending on which flavor of Mac the test is run on.  This patch
1299         disable the test.  Hopefully we can re-enable the test once we've
1300         probably insulated the test from its environment.
1301
1302         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1303
1304 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1305
1306         Reviewed by Mihai Parparita.
1307
1308         Fix bug introduced in r76322 that caused NRWT to not actually
1309         read the Skipped files properly.
1310
1311         https://bugs.webkit.org/show_bug.cgi?id=52771
1312
1313         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1314         * Scripts/webkitpy/layout_tests/port/webkit.py:
1315         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1316
1317 2011-01-21  Sam Weinig  <sam@webkit.org>
1318
1319         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1320
1321         WebKitTestRunner needs the HOME environment variable to be set.
1322         <rdar://problem/8896573>
1323
1324         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1325         it exists.
1326
1327 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1328
1329         Reviewed by Eric Seidel.
1330
1331         Suppress a few remaining integration tests so that none of the
1332         layout_test unit tests ever read from the filesystem or launch
1333         subprocesses that aren't part of the unit tests.
1334
1335         Also fix a minor bug in the printing unit tests that was
1336         incorrectly relying on sys.argv.
1337
1338         https://bugs.webkit.org/show_bug.cgi?id=52863
1339
1340         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1341         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1342         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1343
1344 2011-01-21  Darin Adler  <darin@apple.com>
1345
1346        Fix Mac build.
1347
1348         * MiniBrowser/mac/BrowserWindowController.m:
1349         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1350
1351 2011-01-20  Darin Adler  <darin@apple.com>
1352
1353         Reviewed by Dan Bernstein.
1354
1355         WebKit2: Implement showModalDialog
1356         https://bugs.webkit.org/show_bug.cgi?id=52855
1357
1358         This fixes WebKitTestRunner to compile, but more work is probably
1359         needed to get it to pass the tests.
1360
1361         * WebKitTestRunner/TestController.cpp:
1362         (WTR::TestController::runModal): Added. Calls through to the
1363         platform-specific version of runModal.
1364         (WTR::TestController::createOtherPage): Changed to be a private
1365         static member function so it can refer to runModal, which is
1366         a private static member function.
1367         (WTR::TestController::initialize): Pass 0 for the runModal
1368         function since we don't need to run the main window modal.
1369         I suspect this is wrong and will need to change.
1370         * WebKitTestRunner/TestController.h: Added declarations for
1371         the functions added above.
1372         * WebKitTestRunner/mac/TestControllerMac.mm:
1373         (WTR::TestController::runModal): Added. Untested implementation.
1374         * WebKitTestRunner/qt/TestControllerQt.cpp:
1375         (WTR::TestController::runModal): Added.
1376         * WebKitTestRunner/win/TestControllerWin.cpp:
1377         (WTR::TestController::runModal): Added.
1378
1379 2011-01-21  Eric Seidel  <eric@webkit.org>
1380
1381         Reviewed by Adam Barth.
1382
1383         Split Host object off from WebKitPatch for easier re-use
1384         https://bugs.webkit.org/show_bug.cgi?id=52284
1385
1386         new-run-webkit-tests and other tools are eventually going to want one of these.
1387         Basically you need to inherit from this class if you want to pretend to be a
1388         self.tool object for Steps/Commands.
1389
1390         * Scripts/webkitpy/common/host.py: Added.
1391         * Scripts/webkitpy/tool/main.py:
1392
1393 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1394
1395         Reviewed by Adam Barth.
1396
1397         Disable the tests that start and stop the http server and web
1398         server, so that we don't have to worry about port collisions on
1399         the bots.
1400
1401         https://bugs.webkit.org/show_bug.cgi?id=52861
1402
1403         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1404
1405 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1406
1407         Reviewed by Eric Seidel.
1408
1409         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1410         
1411         https://bugs.webkit.org/show_bug.cgi?id=52772
1412         
1413         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1414
1415 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1416
1417         Reviewed by Eric Siedel.
1418
1419         nrwt: clean up almost all remaining port references, remove
1420         unnecessary import clauses. The only remaining references are
1421         in places where a mock filesystem makes no sense or can't be
1422         used, and in one routine in port/google_chrome_unittest that
1423         I'll rewrite in a separate patch.
1424
1425         https://bugs.webkit.org/show_bug.cgi?id=52771
1426
1427         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1428         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1429         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1430         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1431         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1432         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1433         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1434         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1435         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1436         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1437         * Scripts/webkitpy/layout_tests/port/gtk.py:
1438         * Scripts/webkitpy/layout_tests/port/mac.py:
1439         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1440         * Scripts/webkitpy/layout_tests/port/qt.py:
1441         * Scripts/webkitpy/layout_tests/port/webkit.py:
1442         * Scripts/webkitpy/layout_tests/port/win.py:
1443         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1444
1445 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1446
1447         Reviewed by Mihai Parparita.
1448
1449         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1450
1451         https://bugs.webkit.org/show_bug.cgi?id=52762
1452
1453         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1454         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1455
1456 2011-01-20  Tony Chang  <tony@chromium.org>
1457
1458         Reviewed by Ojan Vafai.
1459
1460         [chromium] fix the paths used for the rebaseline tool
1461         https://bugs.webkit.org/show_bug.cgi?id=52857
1462
1463         Some of the bots were renamed so the path to grab the results zip
1464         file has changed.
1465
1466         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1467
1468 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1469
1470         Reviewed by Tony Chang.
1471
1472         Fix bug introduced in r72688 / bug 52768 that broke the
1473         generation of the output filename links in the results.html
1474         output. Apparently none of the unit tests actually checked to
1475         make sure the generated links were correct :(
1476
1477         https://bugs.webkit.org/show_bug.cgi?id=52854
1478
1479         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1480         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1481
1482 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1483
1484         Reviewed by Darin Adler.
1485
1486         https://bugs.webkit.org/show_bug.cgi?id=52849
1487         Make window.print work with WebKit2
1488
1489         * MiniBrowser/mac/BrowserWindowController.m:
1490         (-[BrowserWindowController awakeFromNib]):
1491         * WebKitTestRunner/TestController.cpp:
1492         (WTR::createOtherPage):
1493         (WTR::TestController::initialize):
1494         Added zeroes to WKPageUIClient structures to avoid build failures.
1495
1496 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1497
1498         Reviewed by Eric Seidel.
1499
1500         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1501
1502         https://bugs.webkit.org/show_bug.cgi?id=52756
1503
1504         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1505         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1506         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1507         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1508         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1509         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1510
1511 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1512
1513         Reviewed by Antonio Gomes.
1514
1515         QtTestBrowser should have a seperate menu for Settings
1516         https://bugs.webkit.org/show_bug.cgi?id=52817
1517         
1518         Added a new menu item named "Settings"
1519         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1520
1521         * QtTestBrowser/launcherwindow.cpp:
1522         (LauncherWindow::createChrome):
1523
1524 2011-01-20  Sam Weinig  <sam@webkit.org>
1525
1526         Reviewed by John Sullivan.
1527
1528         Update update-webkit-localizable-strings with new path to WebKit.
1529
1530         * Scripts/update-webkit-localizable-strings:
1531
1532 2011-01-20  James Robinson  <jamesr@chromium.org>
1533
1534         Reviewed by Darin Fisher.
1535
1536         Implement mozilla's requestAnimationFrame API
1537         https://bugs.webkit.org/show_bug.cgi?id=51218
1538
1539         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1540
1541         * DumpRenderTree/chromium/WebViewHost.cpp:
1542         (invokeScheduleComposite):
1543         (WebViewHost::scheduleAnimation):
1544         (WebViewHost::paintInvalidatedRegion):
1545         * DumpRenderTree/chromium/WebViewHost.h:
1546
1547 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1548
1549         Reviewed by Adam Roben.
1550
1551         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1552         https://bugs.webkit.org/show_bug.cgi?id=42327
1553
1554         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1555         for methods that take their normal arguments but also a JSContextRef.
1556         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1557         for evaluateScriptInIsolatedWorld.
1558         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1559         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1560         this call is for an isolated world.
1561         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1562         (WTR::worldMap): Helper to create a world map.
1563         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1564         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1565         added LayoutTestController API.
1566         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1567
1568 2011-01-19  Adam Roben  <aroben@apple.com>
1569
1570         Convert paths in environment variables back to msys-style inside commit-log-editor
1571
1572         When this script gets run from inside git commit, msys-style paths in the environment will
1573         have been turned into Windows-style paths with forward slashes. This screws up functions
1574         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1575         the paths back to msys-style before doing anything else.
1576
1577         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1578         using msysgit's Perl and multiple ChangeLogs have been edited
1579
1580         Reviewed by David Kilzer.
1581
1582         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1583         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1584         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1585
1586 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1587
1588         [Win] Unreviewed build fix after r76248.
1589
1590         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1591
1592 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1593
1594         Reviewed by Csaba Osztrogonác.
1595
1596         Refactoring of the custom allocation framework
1597         https://bugs.webkit.org/show_bug.cgi?id=49897
1598
1599         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1600         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1601         equivalent macro implementation at the necessary places.
1602 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1603
1604         Unreviewed. 
1605
1606         Adding myself to committers.py.
1607
1608         * Scripts/webkitpy/common/config/committers.py:
1609
1610 2011-01-20  Adam Barth  <abarth@webkit.org>
1611
1612         Reviewed by Tony Chang.
1613
1614         Chromium builders don't delete unversioned directories when DEPS change
1615         https://bugs.webkit.org/show_bug.cgi?id=52745
1616
1617         If we pass this option to gclient sync, gclient will delete directories
1618         that are no longer part of DEPS instead of leaving them around to
1619         confuse us later.  Apparently, the downstream buildbots use this option
1620         already.
1621
1622         * Scripts/update-webkit-chromium:
1623
1624 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1625
1626         Unreviewed, build fix - I pulled this patch in to fix an issue
1627         revealed by r76195 running on some new bots). Also fix a couple
1628         of other issues revealed in testing.
1629
1630         nrwt: remove fs refs from layout_package/json*
1631
1632         https://bugs.webkit.org/show_bug.cgi?id=52754
1633
1634         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1635         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1636         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1637         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1638         * Scripts/webkitpy/layout_tests/port/base.py:
1639
1640 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1641
1642         Unreviewed, build fix.
1643
1644         Fix a couple of minor bugs discovered while bringing up new bots
1645         for testing.
1646
1647         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1648         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1649
1650 2011-01-19  James Robinson  <jamesr@chromium.org>
1651
1652         Unreviewed, rolling out r76194.
1653         http://trac.webkit.org/changeset/76194
1654         https://bugs.webkit.org/show_bug.cgi?id=51218
1655
1656         Caused mysterious compile failure on the chromium win
1657         build.webkit.org bots
1658
1659         * DumpRenderTree/chromium/WebViewHost.cpp:
1660         (WebViewHost::paintInvalidatedRegion):
1661         * DumpRenderTree/chromium/WebViewHost.h:
1662
1663 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1664
1665         Reviewed by Mihai Parparita.
1666
1667         remove fs refs from test_runner, dump_render_tree_thread
1668
1669         https://bugs.webkit.org/show_bug.cgi?id=52753
1670
1671         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1672         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1673         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1674         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1675
1676 2011-01-19  James Robinson  <jamesr@chromium.org>
1677
1678         Reviewed by Darin Fisher.
1679
1680         Implement mozilla's requestAnimationFrame API
1681         https://bugs.webkit.org/show_bug.cgi?id=51218
1682
1683         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1684
1685         * DumpRenderTree/chromium/WebViewHost.cpp:
1686         (invokeScheduleComposite):
1687         (WebViewHost::scheduleAnimation):
1688         (WebViewHost::paintInvalidatedRegion):
1689         * DumpRenderTree/chromium/WebViewHost.h:
1690
1691 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1692
1693         Unreviewed, build fix.
1694
1695         Fix a few incorrect "self._filesystem" references introduced in
1696         r76184.
1697
1698         * Scripts/webkitpy/layout_tests/port/chromium.py:
1699         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1700
1701 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1702
1703         Reviewed by Mihai Parparita.
1704
1705         add a .sep property, abspath(), isabs(), mtime(), and
1706         open_text_file_for_writing() to filesystem modules. Some of
1707         these properties are not needed in this patch but will be needed
1708         in subsequent patches (I'm doing this to avoid having to track
1709         multiple versions of a single file).
1710
1711         Also, change most of the port/* modules to use the filesystem
1712         objects instead of referencing the filesystem directly.
1713
1714         https://bugs.webkit.org/show_bug.cgi?id=52748
1715
1716         * Scripts/webkitpy/common/system/filesystem.py:
1717         * Scripts/webkitpy/common/system/filesystem_mock.py:
1718         * Scripts/webkitpy/layout_tests/port/__init__.py:
1719         * Scripts/webkitpy/layout_tests/port/base.py:
1720         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1721         * Scripts/webkitpy/layout_tests/port/chromium.py:
1722         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1723         * Scripts/webkitpy/layout_tests/port/config.py:
1724         * Scripts/webkitpy/layout_tests/port/test.py:
1725         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1726
1727 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1728
1729         Reviewed by Anders Carlsson.
1730
1731         If resetting between tests times out, treat it as a WebProcess crash
1732         https://bugs.webkit.org/show_bug.cgi?id=52757
1733
1734         * WebKitTestRunner/TestController.cpp:
1735         (WTR::TestController::runTest):
1736
1737 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1738
1739         Reviewed by Darin Adler.
1740
1741         https://bugs.webkit.org/show_bug.cgi?id=52739
1742         Make it possible for a WebKit2 client to print headers and footers
1743
1744         Added dummy implementations for new printing UIClient calls.
1745
1746         * MiniBrowser/mac/BrowserWindowController.m:
1747         (-[BrowserWindowController awakeFromNib]):
1748         * WebKitTestRunner/TestController.cpp:
1749         (WTR::createOtherPage):
1750         (WTR::TestController::initialize):
1751
1752 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1753
1754         Reviewed by Ojan Vafai.
1755
1756         Change webkitpy/layout_tests/port/test.py to use the
1757         in-memory filesystem for cleaner unit testing. This
1758         change allows us to kill a lot of code that was
1759         specific to the test port, at the cost of being a
1760         little less clear about how things would work if
1761         you didn't have a filesystem.
1762
1763         https://bugs.webkit.org/show_bug.cgi?id=52605
1764
1765         * Scripts/webkitpy/layout_tests/port/test.py:
1766
1767 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1768
1769         Unreviewed, build fix.
1770
1771         Fix test failure caused by committing attachment 79368 instead
1772         of attachment 79461 on bug 52604.
1773
1774         * Scripts/webkitpy/common/system/filesystem_mock.py:
1775
1776 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1777
1778         Reviewed by Mihai Parparita.
1779
1780         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1781         unit testing. os.walk() is too much of a hassle to implement on
1782         top of the in-memory mock filesystem and adding the necessary
1783         interface to files_under() gives clients a cleaner API anyway
1784         (for this particular usage model).
1785
1786         https://bugs.webkit.org/show_bug.cgi?id=52691
1787
1788         * Scripts/webkitpy/common/system/filesystem.py:
1789         * Scripts/webkitpy/common/system/filesystem_mock.py:
1790         * Scripts/webkitpy/layout_tests/port/test_files.py:
1791         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1792
1793 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1794
1795         Reviewed by Tony Chang.
1796
1797         Change more modules in the layout-tests code to use the
1798         filesystem wrapper for cleaner unit testing.
1799
1800         This patch also adds the glob() wrapper to the filesystem
1801         abstraction.
1802         
1803         https://bugs.webkit.org/show_bug.cgi?id=52604
1804
1805         * Scripts/webkitpy/layout_tests/port/test_files.py:
1806         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1807         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1808         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1809         * Scripts/webkitpy/common/system/filesystem.py:
1810         * Scripts/webkitpy/common/system/filesystem_mock.py:
1811
1812 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1813
1814         Unreviewed.
1815
1816         Updating my email addresses and irc nick.
1817
1818         * Scripts/webkitpy/common/config/committers.py:
1819
1820 2011-01-19  Tony Chang  <tony@chromium.org>
1821
1822         Reviewed by Mihai Parparita.
1823
1824         [chromium] [linux] if check-sys-deps fails, output the failure reason
1825         https://bugs.webkit.org/show_bug.cgi?id=52671
1826
1827         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1828             error handler functions.
1829         * Scripts/webkitpy/layout_tests/port/chromium.py:
1830             output the error text from --check-sys-deps
1831         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1832
1833 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1834
1835         Reviewed by Andreas Kling.
1836
1837         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1838         https://bugs.webkit.org/show_bug.cgi?id=52554
1839         
1840         QtNetworkAccessManager is created in a thread and set as
1841         member variable in QWebPage. When the thread is destroyed
1842         the object is still used. So fix will set the object to
1843         NULL once the thread is destroyed.
1844
1845         * QtTestBrowser/launcherwindow.cpp:
1846         (LauncherWindow::~LauncherWindow):
1847
1848 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1849
1850         Rubber stamped by Csaba Osztrogonac
1851
1852         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1853
1854 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1855
1856         Reviewed by Tony Chang.
1857
1858         new-run-webkit-tests: add a --build-directory command line argument
1859
1860         Official Google Chrome builds use a non-standard build directory
1861         location. This patch adds a --build-directory argument that
1862         allows that location to be specified on the command line. Only
1863         Chromium-based builds will use this flag for now, but anyone can
1864         in the future.
1865
1866         There are no unit tests for this since it's difficult to test
1867         until mock filesystems are fully supported in the code. This was
1868         tested by hand for now.
1869
1870         https://bugs.webkit.org/show_bug.cgi?id=52694
1871
1872         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1873         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1874         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1875         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1876
1877 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1878
1879         Not reviewed. Bot fix.
1880
1881         Remove an inadvertently committed debugging print.
1882
1883         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1884         (LayoutTestController::notifyDone):
1885
1886 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1887
1888         Reviewed by Sam Weinig.
1889
1890         WebKitTestRunner should track loading more like DumpRenderTree
1891         https://bugs.webkit.org/show_bug.cgi?id=52692
1892
1893         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1894         This makes some tests that call notifyDone multiple times pass.
1895         
1896         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1897         (WTR::InjectedBundle::InjectedBundle):
1898         (WTR::InjectedBundle::done):
1899         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1900         (WTR::InjectedBundle::topLoadingFrame):
1901         (WTR::InjectedBundle::setTopLoadingFrame):
1902         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1903         (WTR::InjectedBundlePage::InjectedBundlePage):
1904         (WTR::InjectedBundlePage::stopLoading):
1905         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1906         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1907         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1908         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1909         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1910         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1911         (WTR::LayoutTestController::notifyDone):
1912         * WebKitTestRunner/TestController.cpp:
1913         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1914
1915 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1916
1917         Reviewed by Kent Tamura.
1918
1919         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1920         https://bugs.webkit.org/show_bug.cgi?id=52678
1921         
1922         Update path now that WebKit is inside Source.
1923
1924         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1925
1926 2011-01-18  Robert Hogan  <robert@webkit.org>
1927
1928         Reviewed by Simon Hausmann.
1929
1930         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1931         https://bugs.webkit.org/show_bug.cgi?id=44282
1932
1933         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1934         (WebCore::DumpRenderTree::dump):
1935
1936 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1937
1938         Reviewed by Mihai Parparita.
1939
1940         Fix a small race condition that could cause the unit tests for
1941         new-run-webkit-tests to fail in a multithreaded environment.
1942         There was a small window in the code where one thread would
1943         check to see if a thread had raised an exception, do something,
1944         and then check to see if the thread was alive. If the other
1945         thread raised an exception and exited in between these two
1946         steps, the exception would be lost. Flipping the order of the
1947         two checks fixes the race, since we will now always check for an
1948         exception on the thread before exiting.
1949
1950         https://bugs.webkit.org/show_bug.cgi?id=51579
1951
1952         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1953
1954 2011-01-18  Eric Seidel  <eric@webkit.org>
1955
1956         Reviewed by Adam Barth.
1957
1958         commit-queue dies when test archiving fails
1959         https://bugs.webkit.org/show_bug.cgi?id=52617
1960
1961         I looked at the machine and it had 10 archives already
1962         thus find_unused_name was returning None.  I've upped
1963         the limit to 100 (per bug) and tested the case where
1964         find_unused_name returns None (making archive return None).
1965
1966         * Scripts/webkitpy/common/system/workspace.py:
1967         * Scripts/webkitpy/common/system/workspace_unittest.py:
1968         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1969         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1970         * Scripts/webkitpy/tool/commands/queues.py:
1971
1972 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1973
1974         Reviewed by Ojan Vafai.
1975
1976         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1977         filesystem. Also fix a couple of "with" statements missed by
1978         r76050.
1979
1980         https://bugs.webkit.org/show_bug.cgi?id=52487
1981
1982         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1983
1984 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1985
1986         Reviewed by Martin Robinson.
1987
1988         [Gtk] Build fixes for gtk3 build
1989         https://bugs.webkit.org/show_bug.cgi?id=52648
1990
1991         * DumpRenderTree/gtk/EventSender.cpp:
1992         (beginDragWithFilesCallback):
1993
1994 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1995
1996         Reviewed by Mihai Parparita.
1997
1998         Update rebaseline-chromium-webkit-tests to use filesystem objects
1999         instead of direct references to os.path, shutil, tempfile, etc.
2000
2001         This patch doesn't change anything, but will allow subsequent
2002         patches to change the unit tests to no longer use the real
2003         filesystem.
2004
2005         This patch adds a bunch more methods to the filesystem object as
2006         well.
2007
2008         https://bugs.webkit.org/show_bug.cgi?id=52482
2009
2010         * Scripts/webkitpy/common/system/filesystem.py:
2011         * Scripts/webkitpy/common/system/filesystem_mock.py:
2012         * Scripts/webkitpy/tool/commands/queues.py:
2013         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2014         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2015
2016 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2017
2018         Reviewed by Mihai Parparita.
2019
2020         new-run-webkit-tests shouldn't crash when you try to run a
2021         directory containing only skipped files.
2022
2023         https://bugs.webkit.org/show_bug.cgi?id=52478
2024         
2025         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2026         * Scripts/webkitpy/layout_tests/port/test.py:
2027         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2028
2029 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2030
2031         Reviewed by Gustavo Noronha Silva.
2032
2033         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2034         https://bugs.webkit.org/show_bug.cgi?id=40833
2035
2036         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2037         GTK+ event sender.
2038         (dragWithFilesDragDataGetCallback): Added.
2039         (dragWithFilesDragEndCallback): Added.
2040         (beginDragWithFilesCallback): Added.
2041
2042 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2043
2044         Reviewed by Adam Barth.
2045
2046         ews: Add additional watcher to efl ews
2047         https://bugs.webkit.org/show_bug.cgi?id=52613
2048
2049         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2050
2051         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2052
2053 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2054
2055         Reviewed by Alexey Proskuryakov.
2056
2057         Fix some headers with missing or misspelled #ifndef guards
2058         https://bugs.webkit.org/show_bug.cgi?id=52545
2059
2060         * DumpRenderTree/chromium/TestEventPrinter.h:
2061         * DumpRenderTree/chromium/WebPreferences.h:
2062
2063 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2064
2065         Reviewed by Anders Carlsson.
2066
2067         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2068         navigating back to an unreachable URL
2069         https://bugs.webkit.org/show_bug.cgi?id=52388
2070
2071         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2072
2073         * DumpRenderTree/LayoutTestController.cpp:
2074         (queueLoadHTMLStringCallback):
2075         (LayoutTestController::queueLoadHTMLString):
2076         (LayoutTestController::queueLoadAlternateHTMLString):
2077         * DumpRenderTree/LayoutTestController.h:
2078
2079         * DumpRenderTree/WorkQueueItem.h:
2080         (LoadHTMLStringItem::LoadHTMLStringItem):
2081
2082         * DumpRenderTree/chromium/LayoutTestController.cpp:
2083         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2084         (WorkItemLoadHTMLString::run):
2085         (LayoutTestController::queueLoadHTMLString):
2086
2087         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2088         (LoadHTMLStringItem::invoke):
2089         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2090         (LoadHTMLStringItem::invoke):
2091         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2092         (LoadHTMLStringItem::invoke):
2093
2094 2011-01-17  Dan Bernstein  <mitz@apple.com>
2095
2096         Rubber-stamped by Mark Rowe.
2097
2098         Update xcodeproj svn:ignore to include xcuserdata.
2099
2100         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2101         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2102         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2103         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2104         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2105
2106 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2107
2108         Unreviewed fix after r75908.
2109
2110         Move WebKit into Source
2111         https://bugs.webkit.org/show_bug.cgi?id=52530
2112
2113         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2114
2115 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2116
2117         Unreviewed.
2118
2119         Remove accidentally committed debug printing after r75908.
2120
2121         * Scripts/webkitdirs.pm:
2122
2123 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2124
2125         Unreviewed.
2126
2127         Add myself to committers list
2128         https://bugs.webkit.org/show_bug.cgi?id=52566
2129
2130         * Scripts/webkitpy/common/config/committers.py:
2131
2132 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2133
2134         Reviewed by Jeremy Orlow.
2135
2136         GeolocationController should call stopUpdating on destruction
2137         https://bugs.webkit.org/show_bug.cgi?id=52216
2138
2139         fast/dom/Geolocation/window-close-crash.html requires that a
2140         Geolocation watch be started in a secondary window. Consequently,
2141         we need to allow geolocation permission and provide a mock
2142         geolocation position for the secondary window's
2143         GeolocationClientMock.
2144
2145         * DumpRenderTree/chromium/LayoutTestController.cpp:
2146         (LayoutTestController::setGeolocationPermission):
2147         (LayoutTestController::setMockGeolocationPosition):
2148         (LayoutTestController::setMockGeolocationError):
2149         * DumpRenderTree/chromium/TestShell.h:
2150         (TestShell::windowList):
2151
2152 2011-01-16  Adam Barth  <abarth@webkit.org>
2153
2154         Update more include paths to reflect WebKit move.
2155
2156         * DumpRenderTree/chromium/EventSender.cpp:
2157         (EventSender::keyDown):
2158         (EventSender::needsShiftModifier):
2159         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2160         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2161
2162 2011-01-16  Kent Tamura  <tkent@chromium.org>
2163
2164         Unreviewed, Chromium build fix.
2165
2166         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2167
2168 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2169
2170         Build fix for GTK+ after source directory movement.
2171
2172         * GNUmakefile.am: Correct include paths.
2173
2174 2011-01-16  Adam Barth  <abarth@webkit.org>
2175
2176         Teach svn-apply about WebKit move.
2177
2178         * Scripts/VCSUtils.pm:
2179
2180 2011-01-16  Adam Barth  <abarth@webkit.org>
2181
2182         Rubber-stamped by Eric Seidel.
2183
2184         Move WebKit into Source
2185         https://bugs.webkit.org/show_bug.cgi?id=52530
2186
2187         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2188         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2189         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2190         * DumpRenderTree/qt/GCControllerQt.cpp:
2191         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2192         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2193         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2194         * DumpRenderTree/wscript:
2195         * QtTestBrowser/launcherwindow.h:
2196         * Scripts/build-webkit:
2197         * Scripts/webkitdirs.pm:
2198
2199 2011-01-15  Adam Barth  <abarth@webkit.org>
2200
2201         Teach svn-apply about WebKit2 move.
2202
2203         * Scripts/VCSUtils.pm:
2204
2205 2011-01-15  Adam Barth  <abarth@webkit.org>
2206
2207         Rubber-stamped by Eric Seidel.
2208
2209         Move WebKit2 into Source
2210         https://bugs.webkit.org/show_bug.cgi?id=52438
2211
2212         * MiniBrowser/qt/MiniBrowser.pro:
2213         * Scripts/build-webkit:
2214         * Scripts/do-file-rename:
2215         * Scripts/do-webcore-rename:
2216         * Scripts/test-webkitpy:
2217         * Scripts/webkitdirs.pm:
2218         * Scripts/webkitpy/style/checker.py:
2219         * WebKitTestRunner/DerivedSources.pro:
2220         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2221         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2222
2223 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2224
2225         Reviewed by David Levin.
2226
2227         [chromium] remove obsolete createView method
2228         https://bugs.webkit.org/show_bug.cgi?id=52437
2229
2230         * DumpRenderTree/chromium/WebViewHost.cpp:
2231         (WebViewHost::createView):
2232         * DumpRenderTree/chromium/WebViewHost.h:
2233
2234 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2235
2236         Reviewed by Geoff Garen.
2237
2238         ShouldLoadResourceForFrame should use strings, not URLs.
2239         https://bugs.webkit.org/show_bug.cgi?id=52476
2240
2241         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2242         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2243         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2244
2245 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2246
2247         Reviewed by David Levin.
2248
2249         Add Tony Gentilcore as a reviewer
2250         https://bugs.webkit.org/show_bug.cgi?id=52480
2251
2252         * Scripts/webkitpy/common/config/committers.py:
2253
2254 2011-01-14  David Levin  <levin@chromium.org>
2255
2256         Reviewed by Eric Seidel.
2257
2258         check-webkit-style: _FunctionState should keep track of where the function name starts.
2259         https://bugs.webkit.org/show_bug.cgi?id=52454
2260
2261         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2262         _FunctionState and logic for setting it correctly.
2263         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2264
2265 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2266
2267         Reviewed by David Levin.
2268
2269         Add support to DumpRenderTree to use the GPU rather than software renderer
2270         https://bugs.webkit.org/show_bug.cgi?id=52333
2271
2272         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2273         (main):
2274         * Scripts/webkitpy/layout_tests/port/chromium.py:
2275         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2276
2277 2011-01-14  Tony Chang  <tony@chromium.org>
2278
2279         Reviewed by Kent Tamura.
2280
2281         [chromium] update fonts.conf to fix 6 linux tests in drt
2282         https://bugs.webkit.org/show_bug.cgi?id=52411
2283
2284         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2285             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2286
2287 2011-01-14  Eric Seidel  <eric@webkit.org>
2288
2289         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2290
2291         Reviewed by Adam Barth.
2292
2293         Fix when running Tools/Scripts/check-webkit-style without arguments.
2294         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2295
2296         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2297         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2298
2299 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2300
2301         Reviewed by David Levin.
2302
2303         Store the tempdir object in a variable so it doesn't get deleted too early.
2304         https://bugs.webkit.org/show_bug.cgi?id=51875
2305
2306         * Scripts/update-webkit-auxiliary-libs:
2307         * Scripts/update-webkit-support-libs:
2308
2309 2011-01-14  Eric Seidel  <eric@webkit.org>
2310
2311         Unreviewed.  Make it work in python 2.5.
2312
2313         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2314         https://bugs.webkit.org/show_bug.cgi?id=49158
2315
2316         * Scripts/webkitpy/common/checkout/api_unittest.py:
2317
2318 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2319
2320         Unreviewed, rolling out r75774.
2321         http://trac.webkit.org/changeset/75774
2322         https://bugs.webkit.org/show_bug.cgi?id=52431
2323
2324         gtk builds were broken (Requested by loislo2 on #webkit).
2325
2326         * Scripts/webkitpy/common/checkout/scm.py:
2327
2328 2011-01-14  David Levin  <levin@chromium.org>
2329
2330         Reviewed by Shinichiro Hamaji.
2331
2332         check-webkit-style: _FunctionState should detect pure functions.
2333         https://bugs.webkit.org/show_bug.cgi?id=52428
2334
2335         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2336         is a pure virtual function.
2337         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2338         virtual functions are correctly detected.
2339
2340 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2341
2342         Reviewed by Yury Semikhatsky.
2343
2344         Just small fix for problem with check-webkit-style.
2345         It just didn't work for this patch.
2346         Old code can't concatenate a list of strings with None.
2347
2348         * Scripts/webkitpy/common/checkout/scm.py:
2349
2350 2011-01-13  David Levin  <levin@chromium.org>
2351
2352         Reviewed by Shinichiro Hamaji.
2353
2354         check-webkit-style: _FunctionState should use Position to know where items are.
2355         https://bugs.webkit.org/show_bug.cgi?id=52424
2356
2357         * Scripts/webkitpy/style/checkers/cpp.py:
2358         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2359         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2360         did some minor clean-up.
2361         (*): Other changes are simply about converting to use the Position's in_FunctionState
2362         instead of line numbers.
2363         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2364         to verify the positions stored in _FunctionState.
2365
2366 2011-01-13  Eric Seidel  <eric@webkit.org>
2367
2368         Reviewed by David Levin.
2369
2370         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2371         https://bugs.webkit.org/show_bug.cgi?id=49158
2372
2373         This is not the most elegant, but it is a very safe fix to this bug.
2374         One advantage of catching ScriptError like this instead of adding a
2375         new added_or_modified_files or fixing all changed_files callers
2376         to use a more specific change_files variant, is that we catch
2377         all kinds of ScriptErrors which might cause our (non-essential)
2378         suggest-reviewers code to fail out.  This should make passing
2379         --suggest-reviewers to webkit-patch upload much more robust
2380         and may even make it possible for us to make it default.
2381
2382         The root of the problem here is that SCM.changed_files includes
2383         deleted ChangeLog paths (from moves, etc) which then when we ask
2384         SVN/Git for the contents of the file at that revision, the command
2385         errors out and Executive.run_command raises a ScriptError.
2386
2387         In the future we might fix this differently by making all current
2388         callers of chagned_files use a more specific method for requesting
2389         what types of changes they're interested in (adds, modifies, deletes, etc.)
2390
2391         * Scripts/webkitpy/common/checkout/api.py:
2392         * Scripts/webkitpy/common/checkout/api_unittest.py:
2393
2394 2011-01-13  Dan Bernstein  <mitz@apple.com>
2395
2396         Reviewed by Alexey Proskuryakov.
2397
2398         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2399         https://bugs.webkit.org/show_bug.cgi?id=52419
2400
2401         Allow to further control the behavior of the willSendRequest delegate callback by making it
2402         set a different URL in the new request.
2403
2404         * DumpRenderTree/LayoutTestController.cpp:
2405         (addURLToRedirectCallback): Added.
2406         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2407         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2408         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2409         * DumpRenderTree/LayoutTestController.h:
2410         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2411         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2412         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2413         change the URL in the new request to the redirect destination.
2414
2415 2011-01-13  Eric Seidel  <eric@webkit.org>
2416
2417         Reviewed by Mihai Parparita.
2418
2419         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2420         https://bugs.webkit.org/show_bug.cgi?id=52416
2421
2422         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2423         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2424
2425         I also added FIXMEs about the changed_files returning deleted files problem
2426         which is causing the other most common exception for suggest-reviewers
2427         (and is probably breaking sheriff-bots blame detection).
2428
2429         * Scripts/webkitpy/common/checkout/api.py:
2430         * Scripts/webkitpy/common/checkout/api_unittest.py:
2431         * Scripts/webkitpy/common/checkout/scm.py:
2432
2433 2011-01-13  Eric Seidel  <eric@webkit.org>
2434
2435         Reviewed by Adam Barth.
2436
2437         results archives from commit-queue are too large to upload
2438         https://bugs.webkit.org/show_bug.cgi?id=52405
2439
2440         * Scripts/webkitpy/common/system/filesystem.py:
2441         * Scripts/webkitpy/common/system/filesystem_mock.py:
2442         * Scripts/webkitpy/tool/commands/queues.py:
2443
2444 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2445
2446         Reviewed by Martin Robinson.
2447
2448         [gtk] Zero-sized font does not yet work
2449         https://bugs.webkit.org/show_bug.cgi?id=49793
2450
2451         Set minimum-font-size to 0 for the DRT.
2452
2453         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2454         (resetDefaultsToConsistentValues):
2455
2456 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2457
2458         Reviewed by Darin Adler.
2459
2460         Make old-run-webkit-tests more robust on buildbots
2461         https://bugs.webkit.org/show_bug.cgi?id=52364
2462
2463         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2464
2465 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2466
2467         Reviewed by Darin Adler.
2468
2469         Make old-run-webkit-tests more robust on buildbots
2470         https://bugs.webkit.org/show_bug.cgi?id=52364
2471
2472         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2473
2474 2011-01-13  Tony Chang  <tony@chromium.org>
2475
2476         Reviewed by Kent Tamura.
2477
2478         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2479         https://bugs.webkit.org/show_bug.cgi?id=52332
2480
2481         Forked Info.plist is not longer needed.
2482
2483         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2484
2485 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2486
2487         Reviewed by Timothy Hatcher.
2488
2489         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2490         to be passed directly to WebInspector.UIString
2491
2492         https://bugs.webkit.org/show_bug.cgi?id=52365
2493
2494         * Scripts/check-inspector-strings:
2495
2496 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2497
2498         Unreviewed, rolling out r74881.
2499         http://trac.webkit.org/changeset/74881
2500         https://bugs.webkit.org/show_bug.cgi?id=52357
2501
2502         The EFL builder has been red for days (Requested by abarth on
2503         #webkit).
2504
2505         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2506         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2507
2508 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2509
2510         Reviewed by David Levin.
2511
2512         Add beforeunload support to WebKitTestRunner
2513         https://bugs.webkit.org/show_bug.cgi?id=52353
2514         
2515         This makes a number of currently failing tests pass.
2516
2517         * WebKitTestRunner/TestController.cpp:
2518         (WTR::runBeforeUnloadConfirmPanel):
2519         (WTR::createOtherPage):
2520         (WTR::TestController::initialize):
2521
2522 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2523
2524         Reviewed by Sam Weinig.
2525
2526         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2527         https://bugs.webkit.org/show_bug.cgi?id=52330
2528
2529         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2530         a web process crash.
2531         * WebKitTestRunner/TestController.cpp:
2532         (WTR::TestController::initialize): Set up a processDidCrash
2533         callback.
2534         (WTR::TestController::processDidCrash): Report that the Web process
2535         crashed.
2536         * WebKitTestRunner/TestController.h:
2537
2538 2011-01-12  David Levin  <levin@chromium.org>
2539
2540         Reviewed by Shinichiro Hamaji.
2541
2542         check-webkit-style -- close_expression function doesn't work correctly.
2543         https://bugs.webkit.org/show_bug.cgi?id=52272
2544
2545         * Scripts/webkitpy/style/checkers/cpp.py:
2546         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2547         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2548         generally useful (for upcoming code changes).
2549         (close_expression): Changed to use Position for input and output.
2550         Also, fixed many bugs such as only working correctly for parenthesis,
2551         not working correctly if given an offset in a line and not finding
2552         the real closing element if there were multiple closing elements in
2553         the same line.
2554         (detect_functions): Adjusted due to the change in arguments for
2555         close_expression.
2556         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2557         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2558         two positions are the same.
2559         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2560         (CppStyleTest.test_close_expression): Added tests to catch the issues
2561         that were fixed.
2562
2563 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2564
2565         Unreviewed, rolling out r75576.
2566         http://trac.webkit.org/changeset/75576
2567         https://bugs.webkit.org/show_bug.cgi?id=52304
2568
2569         broke rebaseline-chromium-webkit-test (Requested by thakis on
2570         #webkit).
2571
2572         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2573         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2574         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2575         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2576         * Scripts/webkitpy/layout_tests/port/base.py:
2577         * Scripts/webkitpy/layout_tests/port/chromium.py:
2578         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2579         * Scripts/webkitpy/layout_tests/port/test.py:
2580         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2582         * Scripts/webkitpy/style/checkers/test_expectations.py:
2583         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2584
2585 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2586
2587         Reviewed by Darin Adler.
2588
2589         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2590         https://bugs.webkit.org/show_bug.cgi?id=52307
2591
2592         * Scripts/old-run-webkit-tests:
2593
2594 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2595
2596         Reviewed by Martin Robinson.
2597
2598         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2599         https://bugs.webkit.org/show_bug.cgi?id=50867
2600
2601         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2602         TestNetscapePlugin.cpp 
2603
2604         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2605         * Scripts/webkitdirs.pm:
2606
2607 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2608
2609         Reviewed by Pavel Feldman.
2610
2611         Add check-inspector-strings script.
2612
2613         https://bugs.webkit.org/show_bug.cgi?id=52295
2614
2615         * Scripts/check-inspector-strings: Added.
2616
2617 2011-01-12  Adam Roben  <aroben@apple.com>
2618
2619         Advertise the .testnetscape file extension on Windows
2620
2621         Fixes <http://webkit.org/b/52298>
2622         plugins/no-mime-with-valid-extension.html fails on Windows
2623
2624         Reviewed by Dan Bernstein.
2625
2626         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2627         FileExtents field to map the .testnetscape file extension to the
2628         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2629
2630 2011-01-12  Adam Barth  <abarth@webkit.org>
2631
2632         Reviewed by Eric Seidel.
2633
2634         Make webkit-patch support subdirectories for SVN checkouts
2635         https://bugs.webkit.org/show_bug.cgi?id=52261
2636
2637         os.relpath does not exist on Python 2.5, so we need to call our version
2638         of the API.
2639
2640         * Scripts/webkitpy/common/checkout/scm.py:
2641
2642 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2643
2644         Reviewed by Eric Seidel.
2645
2646         Close additional pages opened during a test once the test completes.
2647         https://bugs.webkit.org/show_bug.cgi?id=52276
2648
2649         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2650         (WTR::InjectedBundle::done):
2651
2652 2011-01-11  David Levin  <levin@chromium.org>
2653
2654         Reviewed by Eric Seidel.
2655
2656         Errors should be separated from the command line in bot messages.
2657         https://bugs.webkit.org/show_bug.cgi?id=52275
2658
2659         * Scripts/webkitpy/common/system/executive.py:
2660         (ScriptError.message_with_output): Added a newline to separate the command
2661         line from the errors.
2662         * Scripts/webkitpy/common/system/executive_unittest.py:
2663         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2664         paths in message_with_output.
2665
2666 2011-01-11  Eric Seidel  <eric@webkit.org>
2667
2668         Unreviewed.
2669
2670         commit-queue should know how to upload archived results (for test flakes or general failures)
2671         https://bugs.webkit.org/show_bug.cgi?id=52048
2672
2673         The zips are mostly empty due to forgetting -r.
2674         Expected diffs were not being pulled from the archive due
2675         to the archive having longer paths than I realized.
2676
2677         * Scripts/webkitpy/common/system/workspace.py:
2678         * Scripts/webkitpy/common/system/workspace_unittest.py:
2679         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2680         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2681
2682 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2683
2684         Reviewed by Ojan Vafai.
2685
2686         The current modifier parsing code in test_expectations is
2687         fragile and hard-coded, so it's not easy to understand the logic
2688         or easily add new types of modifiers (like GPU vs. CPU testing
2689         for graphics tests, or 32-bit vs. 64-bit differences).
2690
2691         This is the first of two patches that will add in more generic
2692         support and then eliminate the GPU-specific test expectations
2693         files for Chromium.
2694
2695         This patch adds two standalone objects for handling modifiers. The
2696         rules for interpreting modifiers, precedence, and conflicts are
2697         given in the docstring to the ModifierMatcher class, which
2698         returns ModifierMatchResult objects.
2699         
2700         This patch also adds routines to the Port interface and a
2701         default set of values in the base object, in order to obtain the
2702         values needed on a given test run. These values are then passed
2703         to the expectation parser. This also allows us to clean up the
2704         logic used to lint all of the different configurations in a
2705         single test_expectations.txt file.
2706
2707         The next patch will merge in the separate GPU expectations file.
2708
2709         https://bugs.webkit.org/show_bug.cgi?id=51222
2710
2711         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2712         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2713         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2714         * Scripts/webkitpy/layout_tests/port/base.py:
2715         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2716         * Scripts/webkitpy/layout_tests/port/chromium.py:
2717         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2718         * Scripts/webkitpy/layout_tests/port/test.py:
2719         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2720         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2721
2722 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2723
2724         Reviewed by Adam Barth.
2725
2726         Make webkit-patch support subdirectories for SVN checkouts
2727         https://bugs.webkit.org/show_bug.cgi?id=52261
2728
2729         * Scripts/webkitpy/common/checkout/scm.py:
2730         * Scripts/webkitpy/style_references.py:
2731         * Scripts/webkitpy/tool/main.py:
2732         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2733
2734 2011-01-11  Eric Seidel  <eric@webkit.org>
2735
2736         Unreviewed.
2737
2738         commit-queue should know how to upload archived results (for test flakes or general failures)
2739         https://bugs.webkit.org/show_bug.cgi?id=52048
2740
2741         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2742         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2743
2744         * Scripts/webkitpy/common/system/workspace.py:
2745         * Scripts/webkitpy/common/system/workspace_unittest.py:
2746         * Scripts/webkitpy/tool/commands/queues.py:
2747
2748 2011-01-11  Sam Weinig  <sam@webkit.org>
2749
2750         Roll r75474 back in.
2751
2752 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2753
2754         Reviewed by Kenneth Rohde Christiansen.
2755
2756         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2757         https://bugs.webkit.org/show_bug.cgi?id=51204
2758
2759         * QtTestBrowser/webpage.h:
2760         (QtNAMThread::QtNAMThread):
2761         (QtNAMThread::networkAccessManager):
2762         (QtNAMThread::run):
2763
2764 2011-01-11  Peter Varga  <pvarga@webkit.org>
2765
2766         Unreviewed.
2767
2768         Add myself to committers' list.
2769
2770         * Scripts/webkitpy/common/config/committers.py:
2771
2772 2011-01-11  Eric Seidel  <eric@webkit.org>
2773
2774         Reviewed by Adam Barth.
2775
2776         commit-queue should know how to upload archived results (for test flakes or general failures)
2777         https://bugs.webkit.org/show_bug.cgi?id=52048
2778
2779         Now the queue will always upload results.  Either the entire zip, or just
2780         the diffs.txt in the case of text failures.
2781
2782         This should make understanding flakes much easier, and paves the way
2783         for having the EWS run layout tests (and upload failures).
2784
2785         In order to upload .zip files I had to teach bugzilla.py to autodetect
2786         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2787         for .patch files, I have it add one before calling guess_type.
2788
2789         We may find that always uploading the whole zip instead of just the -diffs.txt
2790         file is preferable, but for now I'm keeping the old behavior because it makes
2791         quickly understanding text failures easy.
2792
2793         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2794         * Scripts/webkitpy/common/system/workspace.py: Added.
2795         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2796         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2797         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2798         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2799         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2800         * Scripts/webkitpy/tool/commands/queues.py:
2801         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2802
2803 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2804
2805         Unreviewed, rolling out r75464.
2806         http://trac.webkit.org/changeset/75464
2807         https://bugs.webkit.org/show_bug.cgi?id=52193
2808
2809         Followup rollout for 75474 (Requested by Ossy on #webkit).
2810
2811         * MiniBrowser/mac/BrowserWindowController.m:
2812         (-[BrowserWindowController awakeFromNib]):
2813         * MiniBrowser/win/BrowserView.cpp:
2814         (BrowserView::create):
2815         * WebKitTestRunner/TestController.cpp:
2816         (WTR::createOtherPage):
2817         (WTR::TestController::initialize):
2818
2819 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2820
2821         Reviewed by Csaba Osztrogonác.
2822
2823         [Qt] Baseline qt_minimal configuration
2824         https://bugs.webkit.org/show_bug.cgi?id=51313
2825
2826         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2827         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2828         QT_NO_UNDOSTACK guard.
2829
2830         * QtTestBrowser/launcherwindow.cpp:
2831         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2832         guards.
2833         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2834         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2835         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2836         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2837
2838         * QtTestBrowser/launcherwindow.h:
2839         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2840         * QtTestBrowser/locationedit.h: Ditto.
2841
2842         * QtTestBrowser/mainwindow.cpp:
2843         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2844         QT_NO_UNDOSTACK guards.
2845         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2846         (MainWindow::changeLocation): Ditto.
2847         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2848         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2849
2850         * QtTestBrowser/webpage.cpp:
2851         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2852         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2853
2854         * QtTestBrowser/webview.cpp:
2855         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2856         (WebViewGraphicsBased::animatedYFlip): Ditto.
2857
2858 2011-01-10  Sam Weinig  <sam@webkit.org>
2859
2860         Fix build.
2861
2862         * MiniBrowser/mac/BrowserWindowController.m:
2863         (-[BrowserWindowController awakeFromNib]):
2864         * MiniBrowser/win/BrowserView.cpp:
2865         (BrowserView::create):
2866         * WebKitTestRunner/TestController.cpp:
2867         (WTR::createOtherPage):
2868         (WTR::TestController::initialize):
2869
2870 2011-01-10  Eric Seidel  <eric@webkit.org>
2871
2872         Reviewed by Ojan Vafai.
2873
2874         style-queue messages are way too long for big patches
2875         https://bugs.webkit.org/show_bug.cgi?id=52161
2876
2877         We definitely could build much fancier list-to-string-with-limit functions
2878         but this should be sufficient for our needs at the moment.
2879
2880         * Scripts/webkitpy/common/system/executive.py:
2881         * Scripts/webkitpy/common/system/executive_unittest.py:
2882
2883 2011-01-10  Tony Chang  <tony@chromium.org>
2884
2885         Unreviewed, rolling out r75398.
2886         http://trac.webkit.org/changeset/75398
2887         https://bugs.webkit.org/show_bug.cgi?id=52008
2888
2889         Some layout tests are crashing on Chromium Win.
2890
2891         * DumpRenderTree/chromium/WebViewHost.cpp:
2892         (WebViewHost::updatePaintRect):
2893         * DumpRenderTree/chromium/WebViewHost.h:
2894
2895 2011-01-10  Adam Roben  <aroben@apple.com>
2896
2897         Roll out r75392
2898
2899         It isn't needed now that r75289 has been rolled out.
2900
2901         * Scripts/run-javascriptcore-tests:
2902
2903 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2904
2905         Reviewed by Anders Carlsson.
2906
2907         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2908         https://bugs.webkit.org/show_bug.cgi?id=52160
2909
2910         * WebKitTestRunner/mac/TestControllerMac.mm:
2911         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2912         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2913         anyway.
2914
2915 2011-01-10  Tony Chang  <tony@chromium.org>
2916
2917         Reviewed by Mihai Parparita.
2918
2919         [chromium] fix for animated gif layout tests
2920         https://bugs.webkit.org/show_bug.cgi?id=52008
2921
2922         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2923             to trigger gif animations.
2924         (WebViewHostPaintTask::WebViewHostPaintTask):
2925         (WebViewHostPaintTask::runIfValid):
2926         (WebViewHost::updatePaintRect):
2927         * DumpRenderTree/chromium/WebViewHost.h:
2928         (WebViewHost::taskList):
2929
2930 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2931
2932         Reviewed by Xan Lopez.
2933
2934         [GTK] Fix gtk2 compilation for master
2935         https://bugs.webkit.org/show_bug.cgi?id=51885
2936
2937         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2938         (createBitmapContextFromWebView): Replaced the old
2939         gdk_drawable_get_size with gdk_pixmap_get_size.
2940
2941 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2942
2943         Reviewed by Laszlo Gombos.
2944
2945         [WINCE] Reenable NPAPI after r75203
2946         https://bugs.webkit.org/show_bug.cgi?id=52109
2947
2948         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2949         it with !isEfl(), because EFL port does not support NPAPI (yet).
2950
2951         * Scripts/build-webkit:
2952
2953 2011-01-10  Adam Roben  <aroben@apple.com>
2954
2955         Skip some asserting JS tests
2956
2957         See <http://webkit.org/b/52156>.
2958
2959         * Scripts/run-javascriptcore-tests:
2960
2961 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2962
2963         Reviewed by Xan Lopez.
2964
2965         [GTK] build-webkit disable Blob support via arguments passed to automake
2966         https://bugs.webkit.org/show_bug.cgi?id=52097
2967
2968         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2969         build-webkit.
2970
2971 2011-01-10  Adam Roben  <aroben@apple.com>
2972
2973         Use the same name and description for TestNetscapePlugin on Windows and
2974         Mac
2975
2976         Fixes <http://webkit.org/b/52151>
2977         fast/frames/iframe-reparenting-plugins.html fails on Windows
2978
2979         Reviewed by Steve Falkenburg.
2980
2981         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2982         the name and description from Mac's Info.plist.
2983
2984 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2985
2986         Reviewed by Laszlo Gombos.
2987
2988         [Qt][WK2] Guard gcc-specific syntax
2989
2990         Non-gcc based compliers choke on the "-include"
2991         syntax for preinclude, place guard around it.
2992
2993         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2994         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2995
2996 2011-01-10  Andreas Kling  <kling@webkit.org>
2997
2998         Reviewed by Simon Hausmann.
2999
3000         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3001         https://bugs.webkit.org/show_bug.cgi?id=52111
3002
3003         When getting a createNewPage() callback from QWKPage, create the
3004         new page with the same QWKContext as the page that is passed to
3005         the callback.
3006
3007         * MiniBrowser/qt/BrowserView.h:
3008         * MiniBrowser/qt/BrowserWindow.cpp:
3009         (newPageFunction):
3010         (BrowserWindow::BrowserWindow):
3011         * MiniBrowser/qt/BrowserWindow.h:
3012
3013 2011-01-10  Andreas Kling  <kling@webkit.org>
3014
3015         Reviewed by Kenneth Rohde Christiansen.
3016
3017         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3018
3019         BrowserView set its own useless createNewPage() callback on QWKPage.
3020         This was immediately overridden by BrowserWindow anyway, so remove
3021         the BrowserView one.
3022
3023         * MiniBrowser/qt/BrowserView.cpp:
3024         (BrowserView::BrowserView):
3025
3026 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3027
3028         Reviewed by Jeremy Orlow.
3029
3030         [Chromium] Remove non-client-based Geolocation code
3031         https://bugs.webkit.org/show_bug.cgi?id=50921
3032
3033         * DumpRenderTree/chromium/LayoutTestController.cpp:
3034         (LayoutTestController::setGeolocationPermission):
3035         (LayoutTestController::setMockGeolocationPosition):
3036         (LayoutTestController::setMockGeolocationError):
3037         * DumpRenderTree/chromium/WebViewHost.cpp:
3038         (WebViewHost::geolocationClientMock):
3039         (WebViewHost::reset):
3040         * DumpRenderTree/chromium/WebViewHost.h:
3041
3042 2011-01-10  Eric Seidel  <eric@webkit.org>
3043
3044         Reviewed by Adam Barth.
3045
3046         Commit bot tried to land r? cq+ patch
3047         https://bugs.webkit.org/show_bug.cgi?id=36638
3048
3049         It should now be possible to post a patch with r? and cq+ and the
3050         commit-queue will correctly wait for the r+ before attempting to land the patch.
3051         (This was a feature requested by several users.)
3052
3053         One caveat: We don't actually reject r-, cq+ patches from the queue
3054         (we just ignore them), but I think that's OK for now.
3055
3056         I also noticed that setting r- once a commit-queue node had grabbed
3057         a patch would not properly cancel the landing.  That's fixed and
3058         tested in this patch.
3059
3060         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3061         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3062         * Scripts/webkitpy/tool/bot/feeders.py:
3063         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3064
3065 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3066
3067         Reviewed by Kenneth Rohde Christiansen.
3068
3069         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3070         https://bugs.webkit.org/show_bug.cgi?id=51934
3071
3072         When accessing the network from the destructor of QWebPage, the network access manager
3073         was already deleted because the object WebPage was already destructed.
3074
3075         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3076         The object is now destructed in the destructor of QObject.
3077
3078         * QtTestBrowser/webpage.cpp:
3079         (WebPage::WebPage):
3080         (WebPage::setQnamThreaded):
3081         * QtTestBrowser/webpage.h:
3082         (QtNAMThread::QtNAMThread):
3083
3084 2011-01-08  Eric Seidel  <eric@webkit.org>
3085
3086         Reviewed by Ojan Vafai.
3087
3088         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3089         https://bugs.webkit.org/show_bug.cgi?id=52067
3090
3091         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3092         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3093
3094         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3095
3096 2011-01-08  Eric Seidel  <eric@webkit.org>
3097
3098         Reviewed by Mihai Parparita.
3099
3100         commit-queue hangs when the ChangeLog diff is bad
3101         https://bugs.webkit.org/show_bug.cgi?id=52072
3102
3103         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3104         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3105
3106 2011-01-08  Adam Barth  <abarth@webkit.org>
3107
3108         Teach svn-apply how to re-write WebCore to Source/WebCore.
3109
3110         * Scripts/VCSUtils.pm:
3111
3112 2011-01-07  Adam Barth  <abarth@webkit.org>
3113
3114         Rubber-stamped by Eric Seidel.
3115
3116         Move WebCore to Source
3117         https://bugs.webkit.org/show_bug.cgi?id=52050
3118
3119         Update the tools to understand WebCore's new location.
3120
3121         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3122         * DumpRenderTree/wscript:
3123         * GNUmakefile.am:
3124         * Scripts/build-webkit:
3125         * Scripts/do-file-rename:
3126         * Scripts/do-webcore-rename:
3127         * Scripts/generate-qt-inspector-resource:
3128         * Scripts/prepare-ChangeLog:
3129         * Scripts/run-bindings-tests:
3130         * Scripts/update-iexploder-cssproperties:
3131         * Scripts/update-sources-list.py:
3132         * Scripts/update-webkit-localizable-strings:
3133         * Scripts/webkitdirs.pm:
3134         * Scripts/webkitpy/common/config/build.py:
3135         * Scripts/webkitpy/common/config/build_unittest.py:
3136         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3137         * Scripts/webkitpy/style/checker.py:
3138         * Scripts/webkitpy/style/checker_unittest.py:
3139         * WebKitTestRunner/DerivedSources.pro:
3140         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3141         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3142         * wx/browser/wscript:
3143         * wx/build/settings.py:
3144
3145 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3146
3147         Reviewed by Sam Weinig.
3148
3149         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3150         https://bugs.webkit.org/show_bug.cgi?id=52086
3151
3152         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3153         (WTR::InjectedBundle::didReceiveMessage):
3154         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3155         (WTR::LayoutTestController::notifyDone):
3156         * WebKitTestRunner/TestController.cpp:
3157         (WTR::TestController::resetStateToConsistentValues):
3158         (WTR::TestController::run):
3159
3160 2011-01-07  James Robinson  <jamesr@chromium.org>
3161
3162         Revert "Implement mozilla's animationTime property"
3163         https://bugs.webkit.org/show_bug.cgi?id=51952
3164
3165         This approach isn't quite right.
3166
3167         * DumpRenderTree/chromium/WebViewHost.cpp:
3168         (WebViewHost::paintInvalidatedRegion):
3169
3170 2011-01-07  Adam Roben  <aroben@apple.com>
3171
3172         Build master fix
3173
3174         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3175         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3176
3177 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3178
3179         Reviewed by Csaba Osztrogonác.
3180
3181         run-qtwebkit-tests should be able to kill a testsuite.
3182
3183         Add new option in the script that can setup a timeout for a test.
3184         If the test execution takes more then specified time then the test
3185         would be terminated.
3186
3187         [Qt] run-qtwebkit-tests needs timeout
3188         https://bugs.webkit.org/show_bug.cgi?id=51894
3189
3190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3191         * Scripts/run-qtwebkit-tests:
3192
3193 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3194
3195         Unreviewed fix after r75233.
3196
3197         Based on idea from Eric Seidel.
3198
3199         Add remote zip file handling to webkitpy.
3200         https://bugs.webkit.org/show_bug.cgi?id=50901
3201
3202         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3203
3204 2011-01-07  Shane Stephens  <shanestephens@google.com>
3205
3206         Reviewed by Eric Seidel.
3207
3208         svn-apply: should support git binary delta diffs
3209         https://bugs.webkit.org/show_bug.cgi?id=38864
3210
3211         * Scripts/VCSUtils.pm:
3212         * Scripts/svn-apply:
3213
3214 2011-01-06  Julie Parent  <jparent@chromium.org>
3215
3216         Reviewed by Eric Seidel.
3217
3218         Test Result Server not removing old results.
3219         https://bugs.webkit.org/show_bug.cgi?id=52012
3220
3221         * TestResultServer/model/jsonresults.py:
3222         Fix off-by-one: Truncate if >= num_runs, not just >.
3223         * TestResultServer/model/jsonresults_unittest.py:
3224         Add unit test to test that merging in a new result with the same value
3225         as the last result causes previous result to fall off.
3226
3227 2011-01-06  James Kozianski  <koz@chromium.org>
3228
3229         Reviewed by Mihai Parparita.
3230
3231         Add classes to provide a consistent interface to a set of files.
3232         https://bugs.webkit.org/show_bug.cgi?id=50901
3233
3234         These classes allow us to write code that is agnostic to whether a
3235         particular set of files resides in a local directory or in a zip file
3236         on a remote machine.
3237
3238         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3239         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3240         * Scripts/webkitpy/common/system/fileset.py: Added.
3241         * Scripts/webkitpy/common/system/filesystem.py:
3242         * Scripts/webkitpy/common/system/filesystem_mock.py:
3243         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3244         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3245
3246 2011-01-06  Eric Seidel  <eric@webkit.org>
3247
3248         Reviewed by Adam Barth.
3249
3250         NetworkTransaction should log the url it is retrying
3251         https://bugs.webkit.org/show_bug.cgi?id=52043
3252
3253         * Scripts/webkitpy/common/net/networktransaction.py:
3254         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3255
3256 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3257
3258         Windows build fix.
3259         Import os before using it.
3260
3261         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3262
3263 2011-01-06  Eric Seidel  <eric@webkit.org>
3264
3265         Reviewed by Adam Barth.
3266
3267         StyleQueue fails to report errors when patches have many files
3268         https://bugs.webkit.org/show_bug.cgi?id=52042
3269
3270         This is one of at least two errors preventing style error reporting at the moment.
3271         When we moved to passing the list of files to check explicitly,
3272         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3273         We could change the type of the QueueStatus.message type, or we could
3274         just teach statusserver.py how to clamp values (and warn when it does).
3275         I chose the latter path.
3276
3277         * Scripts/webkitpy/common/net/statusserver.py:
3278
3279 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3280
3281         Reviewed by Stephanie Lewis.
3282         
3283         Fix syntax error in script.
3284
3285         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3286         https://bugs.webkit.org/show_bug.cgi?id=51996
3287
3288         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3289
3290 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3291
3292         Unreviewed, fixing WinCE build after r75196.
3293
3294         WinCE port does not (yet) support NPAPI.
3295
3296         * Scripts/build-webkit:
3297
3298 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3299
3300         Reviewed by Darin Adler.
3301
3302         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3303         https://bugs.webkit.org/show_bug.cgi?id=52015
3304
3305         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3306         after the platform has been detected, otherwise the script will
3307         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3308         detection.
3309
3310 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3311
3312         Reviewed by Eric Seidel.
3313
3314         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3315         https://bugs.webkit.org/show_bug.cgi?id=51346
3316
3317         * Scripts/build-webkit:
3318
3319 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3320
3321         Reviewed by Adam Roben.
3322
3323         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3324         https://bugs.webkit.org/show_bug.cgi?id=51996
3325         
3326         After the configuration directory change, we were archiving the incorrect directory for
3327         build product, so we were running tests on the wrong binaries.
3328         
3329         This change archives the correct directory, and also unarchives it into a configuration-
3330         specific directory.
3331
3332         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3333         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3334
3335 2011-01-06  Eric Seidel  <eric@webkit.org>
3336
3337         Reviewed by Mihai Parparita.
3338
3339         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3340         https://bugs.webkit.org/show_bug.cgi?id=52002
3341
3342         See an example of this here:
3343         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3344
3345         It's due to the fact that we pass around TestFailure() instance
3346         objects and yet expect them to all compare to be the same.
3347
3348         This is bad.  We should either have shared instances of these values
3349         or we should just pass around the class names.  There are already hacks
3350         in place to make TestFailure objects pass equality tests, I just added
3351         a __hash__ implementation so they can be used in sets as expected.
3352
3353         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3354         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3355
3356 2011-01-06  Evan Martin  <evan@chromium.org>
3357
3358         Reviewed by Tony Chang.
3359
3360         [gdb] handle inaccessible memory and UChar*
3361         https://bugs.webkit.org/show_bug.cgi?id=52003
3362
3363         To pretty-print a UChar*, we just grope around in the memory
3364         looking for a terminating NUL.  We need to handle the exception
3365         that can occur when we poke into an invalid location.
3366
3367         Additionally, the logic for choosing which pretty-printer would
3368         early return before hitting the point where we'd use the UChar*
3369         printer.  (Did this ever work?  How did it regress?)
3370
3371         * gdb/webkit.py:
3372
3373 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3374
3375         Reviewed by Ada Chan.
3376
3377         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3378         https://bugs.webkit.org/show_bug.cgi?id=51969
3379         
3380         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3381
3382         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3383         (WTR::InjectedBundlePage::InjectedBundlePage):
3384         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3385         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3386
3387 2011-01-06  James Robinson  <jamesr@chromium.org>
3388
3389         Reviewed by Simon Fraser.
3390
3391         Implement mozilla's animationTime property
3392         https://bugs.webkit.org/show_bug.cgi?id=51952
3393
3394         Chromium DRT support for webkitAnimationTime.
3395
3396         * DumpRenderTree/chromium/WebViewHost.cpp:
3397         (WebViewHost::paintInvalidatedRegion):
3398
3399 2011-01-06  Julie Parent  <jparent@chromium.org>
3400
3401         Reviewed by Tony Chang.
3402
3403         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3404         https://bugs.webkit.org/show_bug.cgi?id=51217
3405
3406         * TestResultServer/model/jsonresults.py:
3407         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3408         Adds missing documentation.
3409         * TestResultServer/model/jsonresults_unittest.py:
3410         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3411         Update test_merge to take a number of builds to truncate at.
3412
3413 2011-01-06  Adam Barth  <abarth@webkit.org>
3414
3415         Reviewed by Eric Seidel.
3416
3417         The EWS should log outside of the working directory
3418         https://bugs.webkit.org/show_bug.cgi?id=51986
3419
3420         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3421         script, which will actually clean the working copy back to a pristine
3422         state instead of leaving untracked directories and ignored files.
3423
3424         * Scripts/webkitpy/tool/commands/queues.py:
3425         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3426
3427 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3428
3429         Windows build fix.
3430         Back out attempted change to built-product-archive.
3431
3432         * BuildSlaveSupport/built-product-archive:
3433
3434 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3435
3436         Windows build fix.
3437         Include configuration name when unpacking a build archive.
3438
3439         Needed, since we split Windows build results into configuration-specific directories
3440         under WebKitOutputDir.
3441
3442         * BuildSlaveSupport/built-product-archive:
3443
3444 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3445
3446         Reviewed by Darin Adler.
3447
3448         Debug and Release builds on Windows clobber each other
3449         https://bugs.webkit.org/show_bug.cgi?id=49185
3450
3451         Changes the structure of WebKitBuild build products directory so we
3452         completely separate each build configuration into independent directories.
3453         
3454         Although we previously had per-configuration directories for obj, this change adds
3455         per-configuration directories for bin, lib, obj, and include. Each configuration's
3456         build products are stored within a directory inside of WebKitBuild.
3457         
3458         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3459         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3460
3461         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3462         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3463         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3464         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3465         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3466         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3467         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3468         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3469         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3470         * FindSafari/FindSafari.vcproj:
3471         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3472         * MiniBrowser/MiniBrowserPostBuild.cmd:
3473         * MiniBrowser/MiniBrowserPreBuild.cmd:
3474         * Scripts/webkitdirs.pm:
3475         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3476         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3477         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3478         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3479         * TestWebKitAPI/win/copy-resources.cmd:
3480         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3481         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3482         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3483         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3484         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3485         * WebKitTestRunner/win/InjectedBundle.vcproj:
3486         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3487         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3488         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3489         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3490         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3491         * WinLauncher/WinLauncherCommon.vsprops:
3492         * WinLauncher/WinLauncherPostBuild.cmd:
3493         * WinLauncher/WinLauncherPreBuild.cmd:
3494
3495 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3496
3497         Reviewed by Ariya Hidayat.
3498
3499         [Qt] TestNetscapePlugin doesn't link on OS X
3500         https://bugs.webkit.org/show_bug.cgi?id=51948
3501
3502         Only add a dependency on libX11 on X11 systems
3503
3504         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3505
3506 2011-01-05  Jeff Miller  <jeffm@apple.com>
3507
3508         Reviewed by Adam Roben.
3509
3510         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3511         https://bugs.webkit.org/show_bug.cgi?id=51970
3512
3513         * Scripts/webkitpy/style/checker.py:
3514         Add -readability/naming for WebKit2 C API directories.
3515
3516 2011-01-05  Eric Seidel  <eric@webkit.org>
3517
3518         Unreviewed, just fixing one more log error from my previous python patch.
3519
3520         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3521         https://bugs.webkit.org/show_bug.cgi?id=51802
3522
3523         webkit-patch failure-reason was logging about parsing errors
3524         due to my misunderstanding of how BeautifulSoup.findAll worked.
3525
3526         Fixed, and added a unit test.
3527
3528         * Scripts/webkitpy/common/net/layouttestresults.py:
3529         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3530
3531 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3532
3533         Reviewed by Kenneth Rohde Christiansen.
3534
3535         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3536         https://bugs.webkit.org/show_bug.cgi?id=51951
3537
3538         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3539         to create new window from WebKit.
3540
3541         * MiniBrowser/qt/BrowserWindow.cpp:
3542         (newPageFunction):
3543         (BrowserWindow::BrowserWindow):
3544         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3545         (BrowserWindow::newWindow):
3546         (BrowserWindow::updateUserAgentList):
3547         (BrowserWindow::showUserAgentDialog):
3548         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3549         define the type of the backing store used for new windows.
3550         * MiniBrowser/qt/main.cpp:
3551         (main):
3552
3553 2011-01-05  Eric Seidel  <eric@webkit.org>
3554
3555         Reviewed by Ojan Vafai.
3556
3557         commit-queue should report failure type when reporting flaky tests
3558         https://bugs.webkit.org/show_bug.cgi?id=51900
3559
3560         This patch was a ridiculous amount of plumbing.  In the end I like
3561         the NRWT-style TestResult class even less.  But now we're passing
3562         a list of TestResult objects from the queue to the FlakyTestReporter.
3563         Thus the FlakyTestReporter can more easily report what type of failure
3564         occurred.
3565
3566         In the process, I found that I was not alone in finding TestResult
3567         cumbersome to use.  A bunch of code was trying to create a TestResult
3568         object with default values.  However since the constructor didn't make
3569         this easy, some places were getting it wrong (including the TestResult unit test)!
3570         I've fixed the TestResult constructor to have default values for non-essential
3571         arguments.
3572
3573         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3574         * Scripts/webkitpy/common/net/layouttestresults.py:
3575         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3576         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3577         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3578         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3579         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3580         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3581         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3582         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3583         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3584         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3585         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3586         * Scripts/webkitpy/tool/commands/queues.py:
3587         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3588
3589 2011-01-05  Eric Seidel  <eric@webkit.org>
3590
3591         Unreviewed.
3592
3593         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3594         https://bugs.webkit.org/show_bug.cgi?id=51802
3595
3596         Add another unit test to cover a previously missing import.
3597
3598         * Scripts/webkitpy/common/net/layouttestresults.py:
3599         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3600
3601 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3602
3603         Reviewed by David Levin.
3604
3605         Add mihaip@chromium.org as a reviewer
3606         https://bugs.webkit.org/show_bug.cgi?id=51966
3607         
3608         Add myself as a reviewer.
3609
3610         * Scripts/webkitpy/common/config/committers.py:
3611
3612 2011-01-05  James Simonsen  <simonjam@chromium.org>
3613
3614         Unreviewed. Adding myself to the list of committers.
3615
3616         * Scripts/webkitpy/common/config/committers.py:
3617
3618 2011-01-05  Eric Seidel  <eric@webkit.org>
3619
3620         Unreviewed.
3621
3622         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3623         https://bugs.webkit.org/show_bug.cgi?id=51802
3624
3625         Fix two exceptions seen on the bots after my original commit.
3626
3627         * Scripts/webkitpy/common/net/layouttestresults.py:
3628         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3629
3630 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3631
3632         Reviewed by Andreas Kling.
3633
3634         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3635         https://bugs.webkit.org/show_bug.cgi?id=51750
3636
3637         * QtTestBrowser/main.cpp:
3638         (LauncherApplication::handleUserOptions):
3639          Local storage settings can be enable form command line arguments for
3640          QtTestBrowser.
3641
3642 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3643
3644         Reviewed by Martin Robinson.
3645
3646         GTK: AX: DRT needs to use correct root object method.
3647         https://bugs.webkit.org/show_bug.cgi?id=51911
3648
3649         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3650         (AccessibilityController::rootElement):
3651
3652 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3653
3654         Rubber-stamped by Csaba Osztrogonác.
3655
3656         Based on idea from Péter Gál.
3657
3658         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3659
3660 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3661
3662         Reviewed by Adam Barth.
3663
3664         sheriff-bot should be able to do multi-revision rollouts
3665         https://bugs.webkit.org/show_bug.cgi?id=51176
3666
3667         * Scripts/webkitpy/tool/bot/irc_command.py:
3668         * Scripts/webkitpy/tool/bot/sheriff.py:
3669         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3670
3671 2011-01-05  Eric Seidel  <eric@webkit.org>
3672
3673         Reviewed by Adam Barth.
3674
3675         queues.webkit.org should have per-bot status pages
3676         https://bugs.webkit.org/show_bug.cgi?id=51906
3677
3678         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3679         statuses from a single queue.  Now that we have many bots servicing
3680         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3681         you care about scroll off the end of the 15-message limit on the main page.
3682
3683         Eventually we should probably rename /queue-status to /queue or /queues,
3684         but that's fodder for another patch.
3685
3686         * QueueStatusServer/handlers/queuestatus.py:
3687         * QueueStatusServer/index.yaml:
3688         * QueueStatusServer/main.py:
3689         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3690          - This probably should use a custom filter instead of hard-coding
3691            the URL scheme here, but I couldn't figure out how to easily
3692            create such a filter.  Most filters work with "strings" so we can't
3693            pass the status object.  We could add a method to the status
3694            object and call that, but that seemed a bit strange too.
3695         * QueueStatusServer/templates/queuestatus.html:
3696
3697 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3698
3699         Unreviewed. Adding myself to the list of committers.
3700
3701         * Scripts/webkitpy/common/config/committers.py:
3702
3703 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3704
3705         Reviewed by David Levin.
3706
3707         check-webkit-style treated some macros with parentheses after #elif as function calls
3708         https://bugs.webkit.org/show_bug.cgi?id=51695
3709
3710         Ingore function call space checking in any preprocessor directives
3711         (things starting with #). Change search() to match() because 
3712         preprocessor directives are supposed to be in the beginning of lines.
3713
3714         * Scripts/webkitpy/style/checkers/cpp.py:
3715         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3716
3717 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3718
3719         Reviewed by Tony Chang.
3720
3721         Change the --multi-load test option to --stress-opt
3722         https://bugs.webkit.org/show_bug.cgi?id=50751
3723
3724         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3725         (runTest):
3726         (main):
3727         * DumpRenderTree/chromium/TestShell.cpp:
3728         (TestShell::TestShell):
3729         * DumpRenderTree/chromium/TestShell.h:
3730         (TestShell::stressOpt):
3731         (TestShell::setStressOpt):
3732         (TestShell::stressDeopt):
3733         (TestShell::setStressDeopt):
3734         (TestShell::javaScriptFlags):
3735         (TestShell::setJavaScriptFlags):
3736         * Scripts/webkitpy/layout_tests/port/chromium.py:
3737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3738
3739 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3740
3741         Reviewed by Sam Weinig.
3742
3743         WK2: Support Accessibility
3744         https://bugs.webkit.org/show_bug.cgi?id=51859
3745
3746         Use rootObject() method to get top of accessibility tree.
3747
3748         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3749         (AccessibilityController::focusedElement):
3750         (AccessibilityController::rootElement):
3751
3752 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3753
3754         Reviewed by Darin Adler.
3755
3756         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3757         https://bugs.webkit.org/show_bug.cgi?id=51846
3758
3759         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3760         back to GRefPtr.
3761
3762 2011-01-04  Zhe Su  <suzhe@chromium.org>
3763
3764         Reviewed by Kenneth Russell.
3765
3766         Fix insertText, setMarkedText and unmarkText methods of
3767         TextInputController to call corresponding methods of WebKit::WebView
3768         rather than WebKit::WebFrame. This change matches the behavior of
3769         chromium browser.
3770         insertText corresponds to WebView::confirmComposition(text)
3771         setMarkedText corresponds to WebView::setComposition(...)
3772         unmarkText corresponds to WebView::confirmComposition()
3773         https://bugs.webkit.org/show_bug.cgi?id=51693
3774
3775         * DumpRenderTree/chromium/TextInputController.cpp:
3776         (TextInputController::insertText):
3777         (TextInputController::setMarkedText):
3778         (TextInputController::unmarkText):
3779
3780 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3781
3782         Reviewed by Laszlo Gombos.
3783
3784         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3785
3786         On Symbian productDir points to the source directory. Removing all the
3787         empty files from the productDir directory corrupts the svn repository.
3788
3789         * Scripts/build-webkit:
3790
3791 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3792
3793         Reviewed by Adam Barth.
3794
3795         [Qt] Add SelectAll option to the context menu for the editor
3796         https://bugs.webkit.org/show_bug.cgi?id=50049
3797
3798         Set shortcut for the SelectAll action.
3799
3800         * QtTestBrowser/mainwindow.cpp:
3801         (MainWindow::buildUI):
3802
3803 2011-01-03  David Levin  <levin@chromium.org>
3804
3805         Reviewed by Eric Seidel.
3806
3807         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3808         https://bugs.webkit.org/show_bug.cgi?id=51842
3809
3810         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3811         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3812
3813 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3814
3815         Reviewed by David Kilzer.
3816
3817         [WINCE] Adds a build slave.
3818         https://bugs.webkit.org/show_bug.cgi?id=50523
3819
3820         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3821         entry for a release build of the WinCE port.
3822         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3823         flag to build the WinCE port.
3824
3825 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3826
3827         Reviewed by David Kilzer.
3828
3829         Add WinCE support to build-webkit
3830         https://bugs.webkit.org/show_bug.cgi?id=51642
3831
3832         * Scripts/build-webkit:
3833         * Scripts/webkitdirs.pm:
3834
3835 2011-01-03  Eric Seidel  <eric@webkit.org>
3836
3837         Reviewed by Adam Barth.
3838
3839         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3840         https://bugs.webkit.org/show_bug.cgi?id=51802
3841
3842         I'm not the biggest fan of the test_failures or test_results classes,
3843         but it's better to have one shared set of classes, than separate ones
3844         for new vs. old run-webkit-test result handling.
3845
3846         This moves the ORWT results class "LayoutTestResults" over to using
3847         TestResult and TestFailure classes, making it easy for us to
3848         make all our sheriff-bot and other webkitpy code NRWT ready.
3849
3850         This also makes it a trivial patch to generate results.json information
3851         from ORWT results.html files (for flaky test analysis, etc.) as well
3852         as making it a one-liner to report test failure types when the
3853         commit-queue sees flaky tests.
3854
3855         This patch tried not to add new functionality, but only to replace
3856         the guts of LayoutTestResults, while adding unit tests and hoping
3857         not to break anything.
3858
3859         I also moved callers which assumed User.prompt* were static/class methods
3860         to using them as instance methods (since we'll eventually want to make them such).
3861
3862         In the process of re-writing things, I broke the rebaseline command, so I wrote
3863         a unit test to catch my breakage were I do do so again in the future.
3864
3865         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3866         * Scripts/webkitpy/common/net/layouttestresults.py:
3867         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3868         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3869         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3870         * Scripts/webkitpy/tool/commands/queries.py:
3871         * Scripts/webkitpy/tool/commands/rebaseline.py:
3872         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3873         * Scripts/webkitpy/tool/mocktool.py:
3874
3875 2011-01-03  Adam Barth  <abarth@webkit.org>
3876
3877         Reviewed by Simon Fraser.
3878
3879         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3880         https://bugs.webkit.org/show_bug.cgi?id=51840
3881
3882         * Scripts/webkitpy/common/checkout/scm.py:
3883
3884 2011-01-03  Adam Barth  <abarth@webkit.org>
3885
3886         Reviewed by Simon Fraser.
3887
3888         webkit-patch should only hide update output if --quiet
3889         https://bugs.webkit.org/show_bug.cgi?id=51838
3890
3891         As requested by smfr.
3892
3893         * Scripts/webkitpy/tool/steps/update.py:
3894
3895 2011-01-03  Adam Barth  <abarth@webkit.org>
3896
3897         Reviewed by David Levin.
3898
3899         commit-queue shouldn't reject patches twice if two bots process the same patch
3900         https://bugs.webkit.org/show_bug.cgi?id=51805
3901
3902         Before raising an error, we first check whether the patch is still in
3903         the commit-queue.  This check is still racy, of course, but the time
3904         window is much smaller.
3905
3906         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3907
3908 2011-01-03  Sam Weinig  <sam@webkit.org>
3909
3910         Reviewed by Anders Carlsson.
3911
3912         Make run-api-tests less chatty.
3913         https://bugs.webkit.org/show_bug.cgi?id=51831
3914
3915         - Make script quiet by default and add --verbose option (replacing --quiet).
3916         - When not verbose, pipe stdout and stderr to devnull.
3917
3918         * Scripts/run-api-tests:
3919
3920 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3921
3922         Unreviewed. Adding myself to committers.py.
3923
3924         * Scripts/webkitpy/common/config/committers.py:
3925
3926 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3927
3928         Reviewed by Xan Lopez.
3929
3930         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3931         https://bugs.webkit.org/show_bug.cgi?id=51806
3932
3933         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3934         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3935         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3936         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3937         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3938         so make it 'WebKitBuild/Release/.libs'
3939
3940         * Scripts/webkitdirs.pm: 
3941
3942 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3943
3944         Reviewed by Adam Barth.
3945
3946         Make EFL a core builder
3947         https://bugs.webkit.org/show_bug.cgi?id=51804
3948
3949         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3950         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3951
3952 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3953
3954         [Qt] Unreviewed fix after r74855 and r74875.
3955
3956         * BuildSlaveSupport/built-product-archive:
3957          - Create directories explicitly.
3958          - Pass shell=True to subprocess.call().
3959
3960 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3961
3962         [Qt] Unreviewed fix after r74855.
3963
3964         Move JavaScriptCore to Source
3965         https://bugs.webkit.org/show_bug.cgi?id=51604
3966
3967         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3968
3969 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3970
3971         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3972
3973         Move JavaScriptCore to Source
3974         https://bugs.webkit.org/show_bug.cgi?id=51604
3975
3976         * Scripts/webkitdirs.pm:
3977
3978 2011-01-02  Robert Hogan  <robert@webkit.org>
3979
3980         Unreviewed, build fix.
3981
3982         [Qt] Fix DRT build after 74855
3983
3984         * DumpRenderTree/qt/DumpRenderTree.pro:
3985
3986 2011-01-01  Adam Barth  <abarth@webkit.org>
3987
3988         Remove the assumption from the Qt and Gtk builds that every project is
3989         in the root directory.
3990
3991         * Scripts/build-webkit:
3992
3993 2011-01-01  Adam Barth  <abarth@webkit.org>
3994
3995         Reviewed by Eric Seidel.
3996
3997         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3998         https://bugs.webkit.org/show_bug.cgi?id=51796
3999
4000         After this change, svn-apply will magically apply patches to
4001         JavaScriptCore/foo to Source/JavaScriptCore/foo.
4002
4003         * Scripts/VCSUtils.pm:
4004
4005 2011-01-01  Adam Barth  <abarth@webkit.org>
4006
4007         Reviewed by Eric Seidel.
4008
4009         Move JavaScriptCore to Source
4010         https://bugs.webkit.org/show_bug.cgi?id=51604
4011
4012         Update references to JavaScriptCore to point to the new location.
4013
4014         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4015         * DumpRenderTree/qt/DumpRenderTree.pro:
4016         * DumpRenderTree/qt/ImageDiff.pro:
4017         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4018         * DumpRenderTree/wscript:
4019         * Scripts/build-jsc:
4020         * Scripts/build-webkit:
4021         * Scripts/do-file-rename:
4022         * Scripts/do-webcore-rename:
4023         * Scripts/run-javascriptcore-tests:
4024         * Scripts/update-javascriptcore-test-results:
4025         * Scripts/webkitdirs.pm:
4026         * Scripts/webkitpy/common/config/build_unittest.py:
4027         * Scripts/webkitpy/style/checker.py:
4028         * Scripts/webkitpy/style/checker_unittest.py:
4029         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4030         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4031         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4032         * wx/build/settings.py:
4033
4034 2011-01-01  Adam Barth  <abarth@webkit.org>
4035
4036         Reviewed by Eric Seidel.
4037
4038         Move Sources to Source
4039         https://bugs.webkit.org/show_bug.cgi?id=51794
4040
4041         Update scripts to point to the new location.
4042
4043         * Scripts/build-webkit:
4044         * Scripts/do-file-rename:
4045         * Scripts/do-webcore-rename:
4046         * Scripts/webkitpy/common/config/build.py:
4047         * Scripts/webkitpy/common/config/build_unittest.py:
4048
4049 2010-12-31  Kent Tamura  <tkent@chromium.org>
4050
4051         Reviewed by Eric Seidel.
4052
4053         [DRT/Chromium] Enable mock spell checker on non-OSX
4054         https://bugs.webkit.org/show_bug.cgi?id=51401
4055
4056         * DumpRenderTree/chromium/WebViewHost.cpp:
4057         (WebViewHost::spellCheck):
4058
4059 2010-12-31  Adam Barth  <abarth@webkit.org>
4060
4061         Reviewed by Ariya Hidayat.
4062
4063         Remove Tools/Scripts/wkstyle
4064         https://bugs.webkit.org/show_bug.cgi?id=51774
4065
4066         This script appears to not have been touched in a while and seems to
4067         have been replaced by check-webkit-style.
4068
4069         * Scripts/wkstyle: Removed.
4070
4071 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4072
4073         Unreviewed. Coding style fix.
4074
4075         * DumpRenderTree/chromium/TestShell.h:
4076
4077 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4078
4079         Reviewed by Pavel Feldman.
4080
4081         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
4082
4083         It was a problem with Chromium DRT. DevToolsAgent object instance was
4084         attached not only to the inspected page but to the DevTools window too.
4085         As result all the inspector files were interpreted as a content of inspected page
4086         and were transfered to the DevTools scripts panel for debugging etc.
4087
4088         https://bugs.webkit.org/show_bug.cgi?id=51735
4089
4090         * DumpRenderTree/chromium/TestShell.cpp:
4091         (TestShell::TestShell):
4092         (TestShell::bindJSObjectsToWindow):
4093         (TestShell::createNewWindow):
4094         * DumpRenderTree/chromium/TestShell.h:
4095
4096 2010-12-31  Adam Barth  <abarth@webkit.org>
4097
4098         Rubber-stamped by Eric Seidel.
4099
4100         Move PageLoadTests to PerformanceTests/PageLoad
4101         https://bugs.webkit.org/show_bug.cgi?id=51771
4102
4103         Update references to PageLoadTests to point to the new location.
4104
4105         * Scripts/run-pageloadtest:
4106         * Scripts/webkitpy/common/config/build.py:
4107
4108 2010-12-31  Adam Barth  <abarth@webkit.org>
4109
4110         Rubber-stamped by Eric Seidel.
4111
4112         Move SunSpider into PerformanceTests
4113         https://bugs.webkit.org/show_bug.cgi?id=51769
4114
4115         Update these scripts to point to the new location.
4116
4117         * Scripts/run-sunspider:
4118         * Scripts/sunspider-compare-results:
4119
4120 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
4121
4122         Reviewed by Kent Tamura.
4123
4124         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
4125         https://bugs.webkit.org/show_bug.cgi?id=51728
4126         
4127         Add implementation of the Mac WebThemeEngine that uses an NSScroller
4128         to render top-level scrollbars. This makes them match the Mac port's
4129         use of an NSScrollView, which means that we'll be able to share more
4130         pixel baselines.
4131         
4132         The new rendering code will not be activated until the 
4133         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
4134         ScrollbarThemeChromiumMac.
4135
4136         * DumpRenderTree/DumpRenderTree.gypi:
4137         * DumpRenderTree/chromium/TestShellMac.mm:
4138         (platformInit):
4139         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
4140         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
4141         (+[FakeActiveWindow alwaysActiveWindow]):
4142         (+[FakeActiveWindow alwaysInactiveWindow]):
4143         (-[FakeActiveWindow initWithActiveControls:]):
4144         (-[FakeActiveWindow _hasActiveControls]):
4145         (WebThemeEngineDRTMac::paintScrollbarThumb):
4146         (stateToHIEnableState):
4147         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
4148         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
4149
4150 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
4151
4152         Reviewed by David Kilzer.
4153
4154         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
4155         used
4156         https://bugs.webkit.org/show_bug.cgi?id=51672
4157
4158         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
4159         with USE_SYSTEM_MALLOC=1
4160         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
4161         with USE_SYSTEM_MALLOC=1
4162
4163 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4164
4165         Reviewed by David Kilzer.
4166
4167         [Qt] [Symbian] Fix build-webkit script for Symbian
4168         https://bugs.webkit.org/show_bug.cgi?id=51509
4169
4170         Set the OUTPUT_DIR for Symbian to be the same as the source
4171         directory.
4172
4173         * Scripts/webkitdirs.pm:
4174
4175 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
4176
4177         Reviewed by Darin Adler.
4178
4179         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
4180         https://bugs.webkit.org/show_bug.cgi?id=51758
4181
4182         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
4183
4184         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
4185         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
4186
4187 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
4188
4189         Unreviewed WinCE buildfix.
4190
4191         * WinCELauncher/main.cpp: Add missing include.
4192
4193 2010-12-29  Daniel Bates  <dbates@rim.com>
4194
4195         Reviewed by Darin Adler.
4196
4197         svn-apply updates date of wrong change log entry for a change log diff that
4198         contains two consecutive entries with the same author and date
4199         https://bugs.webkit.org/show_bug.cgi?id=46061
4200
4201         Fixes an issue where the date of the wrong change log entry may be modified.
4202         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
4203         in a ChangeLog file to the top of the file.
4204
4205         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
4206         diff when it detects that the diff inserts a change log entry earlier in a
4207         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
4208         change. With the advent of the commit-queue this functionality of bailing out
4209         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
4210         Instead, we should always move the change log entry to the top of the ChangeLog file.
4211
4212         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
4213         the date line of the correct change log entry in a ChangeLog diff.
4214
4215         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
4216
4217         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
4218           Updated the following unit tests now that we move entries inserted earlier to the top:
4219           - "fixChangeLogPatch: New entry inserted in middle."
4220             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
4221
4222           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
4223             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
4224
4225         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
4226
4227 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
4228
4229         Reviewed by Eric Seidel.
4230
4231         [Qt] Fixed compatibility with gold linker on X11 platforms
4232         https://bugs.webkit.org/show_bug.cgi?id=51700
4233
4234         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4235         Linked TestNetscapePlugin with libX11 on Unix platforms
4236
4237 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
4238
4239         Reviewed by Darin Adler.
4240
4241         Circular dependency in webkitpy.common.checkout.changelog module
4242         https://bugs.webkit.org/show_bug.cgi?id=50475
4243
4244         Remove automatic import of api.Checkout module when any checkout/
4245         submodule is imported (e.g.: when checkout.scm.Git is imported).
4246
4247         * Scripts/webkitpy/common/checkout/__init__.py:
4248
4249 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
4250
4251         Reviewed by Ojan Vafai.
4252
4253         prepare-ChangeLog should support the -g option for specifying the git-commit
4254         https://bugs.webkit.org/show_bug.cgi?id=51708
4255
4256         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
4257         webkit-patch, though the exact meaning of the two options remain different.
4258
4259         * Scripts/prepare-ChangeLog: Add -g.
4260
4261 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
4262
4263         Reviewed by Simon Hausmann.
4264
4265         [Qt] Fix compilation with Qt in namespace
4266         https://bugs.webkit.org/show_bug.cgi?id=51701
4267
4268         * QtTestBrowser/webview.h:
4269
4270 2010-12-28  Daniel Bates  <dbates@rim.com>
4271
4272         Reviewed by Sam Weinig.
4273
4274         Substitute // MARK: for compiler-specific #pragma mark
4275         https://bugs.webkit.org/show_bug.cgi?id=51657
4276
4277         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
4278         substituting  "// MARK:" for "#pragma mark", which provides
4279         analogous code-bookmarking functionality under Xcode.
4280
4281         Also, for consistency, we should substitute "// MARK:" for compiler-
4282         specific "#pragma mark" in the source files for the Mac port.
4283
4284         * DumpRenderTree/AccessibilityTextMarker.cpp:
4285         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
4286         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
4287         * DumpRenderTree/mac/ObjCController.m:
4288         * MiniBrowser/mac/AppDelegate.m:
4289         * MiniBrowser/mac/BrowserWindowController.m:
4290
4291 2010-12-28  Xan Lopez  <xlopez@igalia.com>
4292
4293         Reviewed by Eric Seidel.
4294
4295         Add --no-build option to run-sunspider
4296         https://bugs.webkit.org/show_bug.cgi?id=51658
4297
4298         * Scripts/run-sunspider: add --no-build flag to skip building
4299         phase.
4300
4301 2010-12-27  Daniel Bates  <dbates@rim.com>
4302
4303         Rubber-stamped by Martin Robinson.
4304
4305         Append the directory Tools/DumpRenderTree to the list of directories that
4306         do-webcore-rename should search so that it can rename DRT files and
4307         source code.
4308
4309         * Scripts/do-webcore-rename:
4310
4311 2010-12-27  Eric Seidel  <eric@webkit.org>
4312
4313         Reviewed by Adam Barth.
4314
4315         build-webkit should detect missing Java SDK and explain how to install it
4316         https://bugs.webkit.org/show_bug.cgi?id=51651
4317
4318         * Scripts/build-webkit:
4319
4320 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
4321
4322         Reviewed by Daniel Bates.
4323
4324         [GTK] Add support for build-jsc
4325         https://bugs.webkit.org/show_bug.cgi?id=51625
4326
4327         Add GTK+ support to build-jsc now that building the jsc executable as
4328         a standalone target is easy.
4329
4330         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
4331         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
4332         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
4333         and pass it along to buildAutotoolsProject.
4334
4335 2010-12-27  David Levin  <levin@chromium.org>
4336
4337         Reviewed by Eric Seidel.
4338
4339         check-webkit-style check for meaningless variable names in function declarations.
4340         https://bugs.webkit.org/show_bug.cgi?id=51523
4341
4342         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
4343         from the new check and whitespace/parens because the syntax is unusual and
4344         produced a fair number of positives for these checks.
4345         * Scripts/webkitpy/style/checkers/cpp.py:
4346         (_convert_to_lower_with_underscores): Used as a canonical form for type names
4347         and parameter names when determining if the parameter name is useless.
4348         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
4349         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
4350         format.
4351         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
4352         text or an acronym of it.
4353         (check_function_definition): Checks function definitions for meaningless variable names.
4354         (process_line): Added call to check_function_definition.
4355         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4356         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
4357         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
4358         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
4359         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
4360         because when only checking a snippet, there are a lot of bogus functions.
4361         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
4362         that I put there previously and just noticed.
4363         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
4364         check_function_definition and process_line.
4365
4366 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4367
4368         Reviewed by Martin Robinson.
4369
4370         [GTK] Disable flash plugin in GtkLauncher when using gtk3
4371         https://bugs.webkit.org/show_bug.cgi?id=51591
4372
4373         Flash plugin uses gtk2 that is incompatible with gtk3 making
4374         webkit crash when it's built with gtk3.
4375
4376         * GtkLauncher/main.c:
4377         (main):
4378
4379 2010-12-25  Adam Barth  <abarth@webkit.org>
4380
4381         Reviewed by Eric Seidel.
4382
4383         Move ANGLE to Sources/ThirdParty
4384         https://bugs.webkit.org/show_bug.cgi?id=51605
4385
4386         * Scripts/build-webkit:
4387           - Point to the new ANGLE location.
4388
4389 2010-12-26  David Levin  <levin@chromium.org>
4390
4391         Reviewed by Eric Seidel.
4392
4393         check-webkit-style should be able to parse function declaration parameters.
4394         https://bugs.webkit.org/show_bug.cgi?id=51451
4395
4396         * Scripts/webkitpy/style/checkers/cpp.py:
4397         (Position.__init__): Holds simple position information (row, column).
4398         (Parameter.__init__): Holds information about a parameter.
4399         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
4400         (SingleLineView.convert_column_to_row): Returns the original row given a column.
4401         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
4402         (find_parameter_name_index): Finds where the parameter name is.
4403         (parameter_list): Generates the list of parameters for a function.
4404         (_FunctionState.begin): Added information to allow determining the parameters
4405         on demand.
4406         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
4407         (detect_functions): Improve function detection for operator functions and
4408         determine where the parameters end and pass that to _FunctionState.begin.
4409         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4410         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
4411         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
4412         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
4413         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
4414         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
4415         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
4416         (FunctionDetectionTest.perform_function_detection): Added support for verifying
4417         the parameters found.
4418         (FunctionDetectionTest.test_function_declaration_detection): Added more function
4419         detection test to verify that we catch the operator functions.
4420         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
4421         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
4422         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
4423         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
4424         test_function_length_check_definition_severity1_for_test.
4425
4426 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
4427
4428         Unreviewed WinCE buildfix after r74334.
4429
4430         * CMakeListsWinCE.txt:
4431
4432 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
4433
4434         Unreviewed, rolling out r74632.
4435         http://trac.webkit.org/changeset/74632
4436         https://bugs.webkit.org/show_bug.cgi?id=51600
4437
4438         makes test-webkitpy hang forever on GTK (Requested by philn-tp
4439         on #webkit).
4440
4441         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4442         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4443
4444 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
4445
4446         Reviewed by Kenneth Rohde Christiansen.
4447
4448         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
4449         https://bugs.webkit.org/show_bug.cgi?id=43528
4450
4451         Remove on_resize because ewk_view_fixed_layout_size_set should not be
4452         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
4453         FrameView, rendering was ignored when _ewk_view_smart_calculate was
4454         called.
4455
4456         * EWebLauncher/main.c:
4457         (browserCreate):
4458
4459 2010-12-24  Eric Seidel  <eric@webkit.org>
4460
4461         Reviewed by Adam Barth.
4462
4463         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
4464         https://bugs.webkit.org/show_bug.cgi?id=28291
4465
4466         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
4467         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
4468         to strings with find in the diff.
4469         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
4470
4471         * Scripts/webkitpy/common/checkout/api.py:
4472         * Scripts/webkitpy/common/checkout/diff_parser.py:
4473         * Scripts/webkitpy/tool/steps/abstractstep.py:
4474         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4475         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
4476         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4477         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4478
4479 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
4480
4481         Reviewed by Kenneth Russell.
4482
4483         Modify new-run-webkit-tests to shut up and exit when all the threads
4484         are wedged so that test runs complete faster and we don't end up
4485         w/ enormous log files.
4486
4487         https://bugs.webkit.org/show_bug.cgi?id=51572
4488
4489         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4490         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4491
4492 2010-12-24  Eric Seidel  <eric@webkit.org>
4493
4494         Reviewed by David Levin.
4495
4496         commit-queue should better explain how it will re-open bugs and follow duplicate chains