1 2016-03-30 Dewei Zhu <dewei_zhu@apple.com>
3 Extend animometer timeout for slow CPUs.
4 https://bugs.webkit.org/show_bug.cgi?id=156047
6 Reviewed by Ryosuke Niwa.
8 Extend animometer timeout to 30 minutes for slow device.
10 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
12 2016-03-30 Daniel Bates <dabates@apple.com>
14 run-webkit-tests must create parent directory of user's cache directory before running tests
15 https://bugs.webkit.org/show_bug.cgi?id=156009
16 <rdar://problem/25442682>
18 Reviewed by Alexey Proskuryakov.
20 The script run-webkit-tests must create the parent directory of the user's cache directory
21 before running tests because a WebKit2 child process expects that this directory exists
24 The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
25 user's temporary directory and user's cache directory via the environment variable
26 DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
27 as part of setting up the test environment. But run-webkit-tests does not create the user's
28 cache directory. Therefore there is race between the time AppKit creates it and when the
29 launched WebContent and Network processes query for the path to the user's cache directory
30 such that the OS may return the empty string to the WebContent and Network processes if
31 queried for this directory before AppKit creates it.
33 * Scripts/webkitpy/port/base.py:
34 (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
35 empty string. We will override this method for the OS X port to return the path to the
36 user's cache directory with the specified suffix.
37 (Port.remove_cache_directory): Deleted.
38 * Scripts/webkitpy/port/driver.py:
39 (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
40 to the suffix to use for the user's temporary and cache directories and the path to the
41 user's cache directory, respectively.
42 (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
43 to self._driver_user_directory_suffix.
44 (Driver._start): Compute the user directory suffix and the path to the user's cache
45 directory. Create the user's cache directory (if applicable).
46 (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
47 * Scripts/webkitpy/port/mac.py:
48 (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
49 (MacPort.remove_cache_directory): Deleted.
51 2016-03-29 Benjamin Poulain <bpoulain@apple.com>
53 [WTF] Removing a smart pointer from HashTable issues two stores to the same location
54 https://bugs.webkit.org/show_bug.cgi?id=155676
56 Reviewed by Darin Adler.
58 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
59 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
61 2016-03-29 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
63 Add machine-readable results for JSC stress tests
64 https://bugs.webkit.org/show_bug.cgi?id=155771
66 Reviewed by Darin Adler and Dean Johnson
68 Add an option to output JSC stress test results to a user-specified file in JSON format.
70 * Scripts/run-javascriptcore-tests:
71 (runJSCStressTests): Add JSON output support
72 (readAllLines): Remove trailing newline from the end of each item
74 2016-03-29 Alex Christensen <achristensen@webkit.org>
78 * TestWebKitAPI/PlatformWin.cmake:
80 2016-03-29 Timothy Hatcher <timothy@apple.com>
82 Update WebKit nightly to have a red needle to better match Safari
84 https://bugs.webkit.org/show_bug.cgi?id=155983
86 Reviewed by Joseph Pecoraro.
88 * WebKitLauncher/webkit.icns:
90 2016-03-28 Joanmarie Diggs <jdiggs@igalia.com>
92 Adding myself as a reviewer.
96 * Scripts/webkitpy/common/config/contributors.json:
98 2016-03-25 Dewei Zhu <dewei_zhu@apple.com>
100 Dromaeo patch used by run-benchmark should not include an invalid address.
101 https://bugs.webkit.org/show_bug.cgi?id=155910
103 Reviewed by Ryosuke Niwa.
105 Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
106 * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
108 2016-03-25 Daniel Bates <dabates@apple.com>
110 Add WebKitSystemInterface for iOS 9.3
111 https://bugs.webkit.org/show_bug.cgi?id=155893
113 Rubber-stamped by Alexey Proskuryakov.
115 * Scripts/copy-webkitlibraries-to-product-directory:
117 2016-03-25 Daniel Bates <dabates@apple.com>
119 Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
120 in copy-webkitlibraries-to-product-directory
121 https://bugs.webkit.org/show_bug.cgi?id=155869
123 Reviewed by Alexey Proskuryakov.
125 It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
126 webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
129 * Scripts/copy-webkitlibraries-to-product-directory:
131 2016-03-25 Konstantin Tokarev <annulen@yandex.ru>
133 Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
134 https://bugs.webkit.org/show_bug.cgi?id=155882
136 Reviewed by Michael Catanzaro.
138 It was already enabled in all trunk ports, and is required for
139 WebInspectorUI to work.
141 * Scripts/webkitperl/FeatureList.pm:
143 2016-03-24 Jeremy Zerfas <WebKit@JeremyZerfas.com>
145 Improve update-webkit-dependency script.
146 https://bugs.webkit.org/show_bug.cgi?id=155576
148 Reviewed by Brent Fulgham.
150 * Scripts/update-webkit-dependency:
151 -Updated script to also use ETags for helping to determine whether dependency is up to date.
152 -Updated script so it usually won't need to download the entire dependency each time it is
154 -Updated script to ensure zip file contains expected directories before trying to install.
155 -Added some more error checking and improved error messages.
156 (lastModifiedToUnixTime): Deleted.
158 * Scripts/update-webkit-wincairo-libs:
159 -Corrected comment about what script does.
161 2016-03-24 Bill Ming <mbbill@gmail.com>
163 Fix webkitpy tests after r198617
164 https://bugs.webkit.org/show_bug.cgi?id=155827
166 Reviewed by Alex Christensen.
168 * Scripts/webkitpy/tool/steps/confirmdiff.py:
169 (ConfirmDiff._show_pretty_diff):
171 2016-03-23 Bill Ming <mbbill@gmail.com>
173 webkit-patch failed to open pretty diff on Windows
174 https://bugs.webkit.org/show_bug.cgi?id=155827
176 Reviewed by Alex Christensen.
178 * Scripts/webkitpy/tool/steps/confirmdiff.py:
179 (ConfirmDiff._show_pretty_diff):
181 2016-03-23 Jer Noble <jer.noble@apple.com>
183 [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
184 https://bugs.webkit.org/show_bug.cgi?id=155764
186 Reviewed by Eric Carlson.
188 Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
190 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
191 (RequiresUserActionForPlaybackTest::SetUp):
193 2016-03-23 Anders Carlsson <andersca@apple.com>
195 Crash when using KVO from within -[WebView initWithCoder:]
196 https://bugs.webkit.org/show_bug.cgi?id=155816
197 rdar://problem/17073265
199 Reviewed by Dan Bernstein.
203 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
204 * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
205 (-[EarlyKVOCrashResponder initWithWebView:]):
206 (-[EarlyKVOCrashResponder initWithCoder:]):
207 (-[EarlyKVOCrashResponder dealloc]):
208 (-[EarlyKVOCrashResponder encodeWithCoder:]):
209 (TestWebKitAPI::TEST):
211 2016-03-23 Lucas Forschler <lforschler@apple.com>
213 Teach kill-old-processes about perl 5.18.
215 Reviewed by Alexey Proskuryakov
217 * BuildSlaveSupport/kill-old-processes:
220 2016-03-22 Keith Rollin <krollin@apple.com>
222 Unreviewed: add Keith Rollin to the committers list.
224 * Scripts/webkitpy/common/config/contributors.json:
226 2016-03-22 Per Arne Vollan <peavo@outlook.com>
228 [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
229 https://bugs.webkit.org/show_bug.cgi?id=141499
231 Reviewed by Brent Fulgham.
233 As we have moved on to VS2015, this workaround is no longer needed.
235 * DumpRenderTree/cg/ImageDiffCG.cpp:
237 * DumpRenderTree/win/DumpRenderTree.cpp:
239 * DumpRenderTree/win/ImageDiffCairo.cpp:
241 * MiniBrowser/win/Common.cpp:
243 * TestWebKitAPI/win/main.cpp:
245 * win/DLLLauncher/DLLLauncherMain.cpp:
248 2016-03-22 Yusuke Suzuki <utatane.tea@gmail.com>
250 [JSC] ASMBench cannot be run without JSBENCH_PATH
251 https://bugs.webkit.org/show_bug.cgi?id=155751
253 Reviewed by Saam Barati.
255 Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
257 * Scripts/run-jsc-benchmarks:
259 2016-03-21 Brent Fulgham <bfulgham@apple.com>
261 [Win] SharedBuffer::copy() can cause a segmentation fault.
262 https://bugs.webkit.org/show_bug.cgi?id=155739
264 Reviewed by Ryosuke Niwa.
266 * TestWebKitAPI/PlatformWin.cmake: Build and run the
269 2016-03-22 Csaba Osztrogonác <ossy@webkit.org>
271 [buildbot] Move ARM Linux bots to JSCOnly port
272 https://bugs.webkit.org/show_bug.cgi?id=155655
274 Reviewed by Lucas Forschler.
276 * BuildSlaveSupport/build.webkit.org-config/config.json:
277 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
278 (ConfigureBuild.__init__):
279 (appendCustomBuildFlags):
282 (BuildAndRemoteJSCTestsFactory):
283 (BuildAndRemoteJSCTestsFactory.__init__):
284 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
285 * BuildSlaveSupport/clean-build:
288 2016-03-21 Brent Fulgham <bfulgham@apple.com>
290 Improve SharedBuffer testing
291 https://bugs.webkit.org/show_bug.cgi?id=93078
292 <rdar://problem/25277829>
294 Reviewed by Ryosuke Niwa.
296 Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
297 <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
298 and a Blink patch by <tyoshino@chromium.org>
299 <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
301 Add three test cases from the Blink project that cover various append,
302 copy, and createArrayBuffer calls.
304 * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
305 (TestWebKitAPI::TEST_F):
307 2016-03-21 Hyungwook Lee <hyungwook.lee@navercorp.com>
309 [Win] Connect layoutTestController.findString() to support testing
310 https://bugs.webkit.org/show_bug.cgi?id=50234
312 Reviewed by Alex Christensen.
314 Implement TestRunner::findString().
316 * DumpRenderTree/win/TestRunnerWin.cpp:
317 (TestRunner::findString):
319 2016-03-20 Dan Bernstein <mitz@apple.com>
321 [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
322 https://bugs.webkit.org/show_bug.cgi?id=155707
323 <rdar://problem/24980691>
325 Reviewed by Darin Adler.
327 * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
328 based on the last component of MACOSX_DEPLOYMENT_TARGET.
329 * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
330 preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
332 Similarly for these projects:
334 * DumpRenderTree/mac/Configurations/Base.xcconfig:
335 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
336 * LayoutTestRelay/Configurations/Base.xcconfig:
337 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
338 * MiniBrowser/Configurations/Base.xcconfig:
339 * MiniBrowser/Configurations/DebugRelease.xcconfig:
340 * TestWebKitAPI/Configurations/Base.xcconfig:
341 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
342 * WebEditingTester/Configurations/Base.xcconfig:
343 * WebEditingTester/Configurations/DebugRelease.xcconfig:
344 * WebKitTestRunner/Configurations/Base.xcconfig:
345 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
347 2016-03-20 Dan Bernstein <mitz@apple.com>
349 Update build settings
351 Rubber-stamped by Andy Estes.
353 * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
354 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
355 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
356 * MiniBrowser/Configurations/DebugRelease.xcconfig:
357 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
358 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
359 * WebEditingTester/Configurations/DebugRelease.xcconfig:
360 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
361 * asan/asan.xcconfig:
363 2016-03-18 Sam Weinig <sam@webkit.org>
365 Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
366 https://bugs.webkit.org/show_bug.cgi?id=155621
368 Reviewed by Alex Christensen.
370 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
371 (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
372 (TestWebKitAPI::testMovingUsingEnsure):
373 (TestWebKitAPI::testMovingUsingAdd):
374 Add tests ensuring that objects moved into a map using ensure don't
375 have extra ref-churn.
377 2016-03-17 Tim Horton <timothy_horton@apple.com>
379 Fix some deprecation warnings in WebEditingTester
380 https://bugs.webkit.org/show_bug.cgi?id=155601
382 Reviewed by Simon Fraser.
384 * WebEditingTester/AppDelegate.m:
385 (-[WebEditingAppDelegate showOperations:]):
386 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
388 2016-03-17 Tim Horton <timothy_horton@apple.com>
390 Find-in-page indicator in Mail viewer is the wrong scale and cut off
391 https://bugs.webkit.org/show_bug.cgi?id=155605
392 <rdar://problem/23948165>
394 Reviewed by Simon Fraser.
396 * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
398 Add a test that ensures that the find result image is correctly @2x.
399 The NSImage size should be in points.
401 2016-03-16 Commit Queue <commit-queue@webkit.org>
403 Unreviewed, rolling out r198187.
404 https://bugs.webkit.org/show_bug.cgi?id=155564
406 Potentially break testing on iOS (Requested by Guest23 on
411 "Add twisted-15.5.0 module to
412 webkitpy.thirdparty.autoinstalled."
413 https://bugs.webkit.org/show_bug.cgi?id=154667
414 http://trac.webkit.org/changeset/198187
416 2016-03-16 David Kilzer <ddkilzer@apple.com>
418 check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
419 <http://webkit.org/b/155445>
421 Reviewed by Darin Adler.
423 * Scripts/webkitpy/style/checker.py:
424 (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
425 on TestWebKitAPI since this project uses a config.h header as of
426 r95188. Also remove references to WebKitAPITest, which ceased
429 * Scripts/webkitpy/style/checker_unittest.py:
430 (GlobalVariablesTest.test_path_rules_specifier): Add tests.
431 Remove reference to WebKitAPITest project.
433 2016-03-16 Tim Horton <timothy_horton@apple.com>
435 [mac] Printing test snapshots are upside-down after r198242
436 https://bugs.webkit.org/show_bug.cgi?id=155543
438 Reviewed by Simon Fraser.
440 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
441 (createPagedBitmapContext):
442 Flip printing snapshots in DRT so that everything is right-side-up.
444 2016-03-16 Alexey Proskuryakov <ap@apple.com>
446 Update unit test for iOS debug queues.
448 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
450 2016-03-16 Jiewen Tan <jiewen_tan@apple.com>
452 URL Parsing should signal failure for illegal IDN
453 https://bugs.webkit.org/show_bug.cgi?id=154945
454 <rdar://problem/8014795>
456 Reviewed by Brent Fulgham.
458 * MiniBrowser/mac/WK2BrowserWindowController.m:
459 (-[WK2BrowserWindowController fetch:]):
460 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
461 (TestWebKitAPI::TEST):
463 2016-03-15 Tim Horton <timothy_horton@apple.com>
465 [iOS Simulator] Test result snapshots are upside down
466 https://bugs.webkit.org/show_bug.cgi?id=154761
468 Reviewed by Simon Fraser.
470 * WebKitTestRunner/cg/TestInvocationCG.cpp:
471 (WTR::createCGContextFromImage):
472 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
473 In r97104, Simon added code to take WindowServer snapshots, which came
474 in flipped, and added code to flip them back. At this point, WindowServer
475 snapshots got flipped, and software snapshots did not.
477 In r140067, Simon noticed that WindowServer ref test images were upside-down
478 on Mac (not sure why this changed), so turned off the flipping code (but
479 didn't delete it!). Now, WindowServer snapshots and software snapshots both
482 In r190304, Carlos added an enum for the source of the snapshot ("WebView"
483 for window server snapshots, and "WebContent" for software snapshots),
484 and - critically - changed the flipping logic to flip software snapshots!
486 We didn't notice this on Mac because at this point we've made it so that
487 we *always* have WindowServer snapshots, but on iOS we still don't have
488 WindowServer snapshots, so now they're flipped.
490 And that's how we got here.
492 To restore the behavior from r140067, and correctly unflip snapshots on
493 iOS, just delete this code.
495 2016-03-15 Alexey Proskuryakov <ap@apple.com>
497 run-api-tests doesn't print test name when the test crashes
498 https://bugs.webkit.org/show_bug.cgi?id=155476
500 Reviewed by Daniel Bates.
502 * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
503 doesn't contain the test name yet. Changed test name output to always be before raw
506 2016-03-15 Chris Dumez <cdumez@apple.com>
508 Unreviewed, rolling out r198203.
510 Favorites view is no longer loading on iOS
514 "URL Parsing should signal failure for illegal IDN"
515 https://bugs.webkit.org/show_bug.cgi?id=154945
516 http://trac.webkit.org/changeset/198203
518 2016-03-15 Jiewen Tan <jiewen_tan@apple.com>
520 URL Parsing should signal failure for illegal IDN
521 https://bugs.webkit.org/show_bug.cgi?id=154945
522 <rdar://problem/8014795>
524 Reviewed by Brent Fulgham.
526 * MiniBrowser/mac/WK2BrowserWindowController.m:
527 (-[WK2BrowserWindowController fetch:]):
528 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
529 (TestWebKitAPI::TEST):
531 2016-03-14 Chris Dumez <cdumez@apple.com>
533 Unreviewed, rolling out r197981.
535 Caused a massive PLT regression on Mac.
539 "Font antialiasing (smoothing) changes when elements are
540 rendered into compositing layers"
541 https://bugs.webkit.org/show_bug.cgi?id=23364
542 http://trac.webkit.org/changeset/197981
544 2016-03-14 Dewei Zhu <dewei_zhu@apple.com>
546 Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
547 https://bugs.webkit.org/show_bug.cgi?id=154667
549 Reviewed by Ryosuke Niwa and Simon Fraser.
551 Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
552 Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
554 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
555 (ServerControl.render_POST): Deleted.
556 * Scripts/webkitpy/thirdparty/__init__.py:
557 (AutoinstallImportHook.find_module):
558 (AutoinstallImportHook._install_twisted_15_5_0):
559 * Scripts/webkitpy/thirdparty/__init___unittest.py:
560 (ThirdpartyTest.test_imports):
562 2016-03-14 Mark Lam <mark.lam@apple.com>
564 Need to distinguish between Symbol() and Symbol("").
565 https://bugs.webkit.org/show_bug.cgi?id=155438
567 Reviewed by Saam Barati.
569 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
570 (TestWebKitAPI::TEST):
571 - Test that the a symbol with an empty string is not equivalent to a null symbol.
573 2016-03-14 David Kilzer <ddkilzer@apple.com>
575 Remove blank lines after #include "config.h"
577 Follow-up fix from review comments on Bug 155394.
579 * TestWebKitAPI/PlatformUtilities.cpp:
580 * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
582 2016-03-14 Frederic Wang <fred.wang@free.fr>
584 Unreviewed: Add my professional email address.
586 * Scripts/webkitpy/common/config/contributors.json:
588 2016-03-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
590 Web platform test server should not try to launch servers on already bound sockets
591 https://bugs.webkit.org/show_bug.cgi?id=141157
593 Reviewed by Darin Adler.
595 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
596 (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
597 (base_url): Refactored to use wpt_config_json routine.
598 (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
600 2016-03-13 Joseph Pecoraro <pecoraro@apple.com>
602 Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
603 https://bugs.webkit.org/show_bug.cgi?id=155417
605 Reviewed by Yusuke Suzuki.
607 * Scripts/webkitperl/FeatureList.pm:
608 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
610 2016-03-13 Dean Jackson <dino@apple.com>
612 DRT should enable WebGL by default on Mac
613 https://bugs.webkit.org/show_bug.cgi?id=155419
614 <rdar://problem/25136981>
616 Reviewed by Sam Weinig.
618 For some reason, lost in time, WebGL was enabled
619 by default on trunk, but disabled by default
620 in DumpRenderTree when using WebKit 1. This
621 was very annoying, because each test had
622 an explicit command to enable it.
624 * DumpRenderTree/mac/DumpRenderTree.mm:
625 (resetWebPreferencesToConsistentValues): Deleted WebGL line.
627 2016-03-13 Konstantin Tokarev <annulen@yandex.ru>
629 Added new port JSCOnly.
630 https://bugs.webkit.org/show_bug.cgi?id=154512
632 Reviewed by Michael Catanzaro.
634 This port allows to build JavaScriptCore engine with minimal
638 * Scripts/webkitdirs.pm:
639 (argumentsForConfiguration):
640 (executableProductDir):
643 (wrapperPrefixIfNeeded):
644 (generateBuildSystemFromCMakeProject):
645 (buildCMakeGeneratedProject):
647 2016-03-13 David Kilzer <ddkilzer@apple.com>
649 TestWebKitAPI: fix linker warnings
650 <http://webkit.org/b/155394>
652 Reviewed by Darin Adler.
654 * TestWebKitAPI/CMakeLists.txt:
655 - Add RefLogger.cpp source file.
656 - Add other missing cross-platform source files.
657 - Add FIXMEs about RunLoop.cpp and about missing
658 platform-specific source files.
659 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
660 - Add RefLogger.cpp source file.
662 * TestWebKitAPI/Counters.cpp:
663 (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
664 Move specific declaration here to fix linker warning.
665 * TestWebKitAPI/Counters.h:
666 (DeleterCounter<T>::deleterCount): Remove declaration of global
669 * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
670 (TestWebKitAPI::log): Added. Move inline definition in
671 RefLogger.h to here to fix linker warning.
673 * TestWebKitAPI/Tests/WTF/RefLogger.h:
674 (TestWebKitAPI::log): Replace inline function with declaration.
676 2016-03-12 David Kilzer <ddkilzer@apple.com>
678 REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
680 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
681 "Test.h" to fix incorrect case. This was discovered when adding
682 WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
684 2016-03-12 David Kilzer <ddkilzer@apple.com>
686 run-webkit-tests: handle Darwin framework/library environment variables more consistently
687 <http://webkit.org/b/155392>
689 Reviewed by Daniel Bates.
691 These changes will make it possible to pass through environment
692 variables from the run-webkit-tests command-line.
694 * Scripts/webkitpy/port/base.py:
695 (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
696 __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
697 list of variables to keep from the run-webkit-test environment.
699 * Scripts/webkitpy/port/driver.py:
700 (Driver._append_environment_variable_path): Add method to append
701 a path to an environment variable, or set the path if the
702 variable doesn't exist.
703 (Driver._setup_environ_for_driver): Extract build_root_path into
704 a local variable. Use Driver._append_environment_variable_path
705 to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
706 DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
709 * Scripts/webkitpy/port/driver_unittest.py:
710 (DriverTest.test__append_environment_variable_path): Add test
711 method to test Driver._append_environment_variable_path.
713 2016-03-11 Alexey Proskuryakov <ap@apple.com>
715 [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
716 https://bugs.webkit.org/show_bug.cgi?id=155276
718 [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
719 https://bugs.webkit.org/show_bug.cgi?id=155345
721 [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
722 https://bugs.webkit.org/show_bug.cgi?id=153997
723 <rdar://problem/23580034>
725 <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
727 Rubber-stamped by Filip Pizlo.
729 * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
731 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
734 2016-03-11 Jer Noble <jer.noble@apple.com>
736 [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
737 https://bugs.webkit.org/show_bug.cgi?id=155365
739 Reviewed by Darin Adler.
741 Allow tests running on iOS simulator to play video inline, avoiding this assert.
743 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
744 (RequiresUserActionForPlaybackTest::SetUp):
746 2016-03-11 Frederic Wang <fwang@igalia.com>
748 [jhbuild] Disable LLVM OCaml bindings.
749 https://bugs.webkit.org/show_bug.cgi?id=153274
751 Reviewed by Michael Catanzaro.
753 * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
755 2016-03-11 Commit Queue <commit-queue@webkit.org>
757 Unreviewed, rolling out r197495.
758 https://bugs.webkit.org/show_bug.cgi?id=155369
760 LLVM is needed to run update-webkitgtk-libs reliably
761 (Requested by mcatanzaro on #webkit).
765 "[jhbuild] Remove LLVM dependency."
766 https://bugs.webkit.org/show_bug.cgi?id=153274
767 http://trac.webkit.org/changeset/197495
769 2016-03-11 Youenn Fablet <youenn.fablet@crf.canon.fr>
771 WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
772 https://bugs.webkit.org/show_bug.cgi?id=153419
774 Reviewed by Darin Adler.
776 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
777 (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
780 2016-03-10 Simon Fraser <simon.fraser@apple.com>
782 Font antialiasing (smoothing) changes when elements are rendered into compositing layers
783 https://bugs.webkit.org/show_bug.cgi?id=23364
785 Reviewed by Tim Horton.
787 Turn off smoothed layer text because it affects many layout test results.
789 * DumpRenderTree/mac/DumpRenderTree.mm:
790 (resetWebViewToConsistentStateBeforeTesting):
791 * WebKitTestRunner/TestController.cpp:
792 (WTR::TestController::resetStateToConsistentValues):
794 2016-03-10 Jer Noble <jer.noble@apple.com>
796 Partial roll-out of r197953; test fails because encode/decode support of those properties were never added.
798 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
801 2016-03-10 Myles C. Maxfield <mmaxfield@apple.com>
803 [OS X] Main frame scrollbars should appear on the left on RTL systems
804 https://bugs.webkit.org/show_bug.cgi?id=155149
806 Reviewed by Simon Fraser.
808 Setting the volatile default needs to be done early, so it is
809 plumbed through the injected bundle's initialization routine.
811 Control of RTL scrollbars is handled by putting the string
812 <!-- webkit-test-runner [ rtlScrollbars=true ] -->
813 on the first line of a test.
815 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
816 (WTR::shouldUseRTLScrollbars):
817 (WTR::InjectedBundle::platformInitialize):
818 * WebKitTestRunner/TestController.cpp:
819 (WTR::TestController::generatePageConfiguration):
820 (WTR::updateTestOptionsFromTestHeader):
821 (WTR::TestController::getInjectedBundleInitializationUserData):
822 * WebKitTestRunner/TestController.h:
823 * WebKitTestRunner/TestOptions.h:
824 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
825 (WTR::PlatformWebView::viewSupportsOptions):
827 2016-03-08 Jer Noble <jer.noble@apple.com>
829 Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
830 https://bugs.webkit.org/show_bug.cgi?id=155141
832 Reviewed by Beth Dakin.
834 Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture"
835 to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture".
837 Add a new test of WK2 user gesture requirement preferences.
839 * DumpRenderTree/mac/DumpRenderTree.mm:
840 (resetWebPreferencesToConsistentValues):
841 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
842 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
843 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
844 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added.
845 (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]):
846 (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
847 (RequiresUserActionForPlaybackTest::SetUp):
848 (RequiresUserActionForPlaybackTest::createWebView):
849 (RequiresUserActionForPlaybackTest::testVideoWithAudio):
850 (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
851 (RequiresUserActionForPlaybackTest::testAudioOnly):
853 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
856 2016-03-10 Brian Burg <bburg@apple.com>
858 Web Inspector: should be able to run protocol and input generator scripts from any directory
859 https://bugs.webkit.org/show_bug.cgi?id=155307
861 Reviewed by Joseph Pecoraro.
863 * Scripts/webkitpy/inspector/main.py:
864 (InspectorGeneratorTests.main):
865 * Scripts/webkitpy/replay/main.py:
866 (InputGeneratorTests.main):
867 Compute the current SCM based on the location of the script being executed, not
868 the $CWD which could be anything. There's rarely a good reason to use $CWD.
870 2016-03-10 David Kilzer <ddkilzer@apple.com>
872 [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL
873 <http://webkit.org/b/155295>
875 Reviewed by Brent Fulgham.
877 * DumpRenderTree/mac/TestRunnerMac.mm:
878 (TestRunner::inspectorTestStubURL): Always return nullptr for
879 PLATFORM(IOS). This matches what we did in r192604 for
880 WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm.
882 2016-03-10 Frederic Wang <fwang@igalia.com>
884 [GTK] Add support for WOFF2
885 https://bugs.webkit.org/show_bug.cgi?id=152616
887 Reviewed by Carlos Garcia Campos.
889 * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2.
891 2016-03-09 Ryosuke Niwa <rniwa@webkit.org>
893 Add runtime flags for shadow DOM and custom elements
894 https://bugs.webkit.org/show_bug.cgi?id=155213
896 Reviewed by Dean Jackson.
898 Always enable shadow DOM and custom elements during testing.
900 * DumpRenderTree/mac/DumpRenderTree.mm:
901 (resetWebPreferencesToConsistentValues):
902 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
903 (WTR::InjectedBundle::beginTesting):
904 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
905 (WTR::TestRunner::setShadowDOMEnabled): Added.
906 * WebKitTestRunner/InjectedBundle/TestRunner.h:
908 2016-03-09 Brent Fulgham <bfulgham@apple.com>
910 Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
911 https://bugs.webkit.org/show_bug.cgi?id=155265
912 <rdar://problem/11101440>
914 Reviewed by Andy Estes.
916 WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default.
917 Tests that confirm blocking localStorage manually set the flag to "False" in the test.
919 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
920 (WTR::initializeWebViewConfiguration): Set the default state to the correct value.
922 2016-03-09 David Kilzer <ddkilzer@apple.com>
924 check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files
925 <http://webkit.org/b/155273>
927 Reviewed by Andy Estes.
929 * Scripts/webkitpy/style/checkers/cpp.py:
930 (check_spacing_for_function_call): Ignore @catch lines.
931 (check_braces): Ditto.
932 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
933 (CppStyleTest.test_brace_at_begin_of_line): Add test case.
935 2016-03-09 Jason Marcell <jmarcell@apple.com>
937 Removing reference to Dashboard.Repository.Internal.trac from open source unit tests.
938 https://bugs.webkit.org/show_bug.cgi?id=155274
940 Reviewed by Alexey Proskuryakov.
942 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:
943 (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an
944 error in the unit tests.
946 2016-03-09 Aakash Jain <aakash_jain@apple.com>
948 use ulimit command to check process limit in webkitpy
949 https://bugs.webkit.org/show_bug.cgi?id=155260
951 Reviewed by Alexey Proskuryakov.
953 * Scripts/webkitpy/port/ios.py:
954 (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of
955 launchctl limit maxproc command.
957 2016-03-09 Alexey Proskuryakov <ap@apple.com>
959 Stop building armv7 on iOS device builders
960 https://bugs.webkit.org/show_bug.cgi?id=155246
962 Reviewed by David Kilzer.
964 * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and
965 armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions
968 * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want
969 EWS configuration to be verified by buildbot queues.
971 * Scripts/webkitdirs.pm:
972 * Scripts/webkitpy/port/ios.py:
973 Changed default to arm64. I think that the default is probably not used in any
974 practical scenarios, but it's nice to make it more sensible.
976 2016-03-09 Alexey Proskuryakov <ap@apple.com>
978 Add iOS Simulator EWS to bot watcher's dashboard
979 https://bugs.webkit.org/show_bug.cgi?id=155220
981 Reviewed by Lucas Forschler.
983 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
985 2016-03-09 Brent Fulgham <bfulgham@apple.com>
987 Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
988 https://bugs.webkit.org/show_bug.cgi?id=155185
989 <rdar://problem/11101440>
991 Reviewed by Anders Carlsson.
993 * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
994 (TestWebKitAPI::TEST): Allow local file accesss to run test.
995 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
997 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1000 2016-03-09 Tim Horton <timothy_horton@apple.com>
1002 Removing and re-adding a script message handler with the same name results in an unusable message handler
1003 https://bugs.webkit.org/show_bug.cgi?id=155223
1005 Reviewed by Sam Weinig.
1007 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1009 Add a test ensuring that it is possible to remove and re-add a script message handler
1010 with the same name and still dispatch messages to it.
1012 2016-03-08 Alexey Proskuryakov <ap@apple.com>
1014 Fix iOS Simulator EWS.
1016 Unreviewed build fix.
1018 * Scripts/webkitpy/common/config/ports.py:
1020 2016-03-08 Aakash Jain <aakash_jain@apple.com>
1022 Booting multiple iOS simulator parallely fails sometimes
1023 https://bugs.webkit.org/show_bug.cgi?id=155208
1024 <rdar://problem/25019651>
1026 Reviewed by Darin Adler.
1028 * Scripts/webkitpy/port/ios.py:
1029 (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
1032 2016-03-08 Alexey Proskuryakov <ap@apple.com>
1034 Add iOS debug testers to flakiness dashboard
1035 https://bugs.webkit.org/show_bug.cgi?id=155206
1037 Reviewed by Darin Adler.
1039 * TestResultServer/static-dashboards/builders.jsonp:
1041 2016-03-08 Oliver Hunt <oliver@apple.com>
1043 Start moving to separated writable and executable mappings in the JIT
1044 https://bugs.webkit.org/show_bug.cgi?id=155178
1046 Reviewed by Fil Pizlo.
1048 Making run-jsc-benchmarks slightly happier on my machine.
1050 * Scripts/run-jsc-benchmarks:
1052 2016-03-08 Anders Carlsson <andersca@apple.com>
1054 Use NSUInteger instead of NSWindowStyleMask.
1056 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1058 2016-03-08 Anders Carlsson <andersca@apple.com>
1062 We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want
1063 MiniBrowser to build without WTF.
1065 * MiniBrowser/mac/AppDelegate.m:
1066 (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1067 * MiniBrowser/mac/BrowserWindowController.m:
1068 (-[BrowserWindowController windowDidLoad]):
1069 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1071 2016-03-08 Alexey Proskuryakov <ap@apple.com>
1073 Add iOS simulator EWS that runs tests
1074 https://bugs.webkit.org/show_bug.cgi?id=155175
1076 Reviewed by Lucas Forschler.
1078 * QueueStatusServer/config/queues.py:
1079 * Scripts/webkitpy/common/config/ews.json:
1080 * Scripts/webkitpy/common/config/ports.py:
1082 2016-03-08 Commit Queue <commit-queue@webkit.org>
1084 Unreviewed, rolling out r197793 and r197799.
1085 https://bugs.webkit.org/show_bug.cgi?id=155195
1087 something weird happened while landing this and everything
1088 broke (Requested by olliej on #webkit).
1090 Reverted changesets:
1092 "Start moving to separated writable and executable mappings in
1094 https://bugs.webkit.org/show_bug.cgi?id=155178
1095 http://trac.webkit.org/changeset/197793
1097 "arm64 build fix after r197793."
1098 http://trac.webkit.org/changeset/197799
1100 2016-03-08 Oliver Hunt <oliver@apple.com>
1102 Start moving to separated writable and executable mappings in the JIT
1103 https://bugs.webkit.org/show_bug.cgi?id=155178
1105 Reviewed by Filip Pizlo.
1107 Making run-jsc-benchmarks slightly happier on my machine.
1109 * Scripts/run-jsc-benchmarks:
1111 2016-03-08 Daniel Bates <dabates@apple.com>
1113 Support iterating over an OptionSet and checking if it is empty
1114 https://bugs.webkit.org/show_bug.cgi?id=154941
1115 <rdar://problem/24964187>
1117 Reviewed by Darin Adler.
1119 Add tests to ensure that we do not regression both iteration of an OptionSet and
1120 determining whether an OptionSet is empty.
1122 * TestWebKitAPI/Test.h:
1123 (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality.
1124 * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1125 (TestWebKitAPI::TEST):
1127 2016-03-08 Alexey Proskuryakov <ap@apple.com>
1129 Add debug iOS Simulator bots to the dashboard
1130 https://bugs.webkit.org/show_bug.cgi?id=155157
1132 Reviewed by Darin Adler.
1134 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1136 2016-03-08 Alejandro G. Castro <alex@igalia.com>
1138 Unreviewed EFL build fix after r197752.
1140 * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM
1141 compilation by default until EFL bumps gstreamer to 1.6.
1143 2016-03-08 Alejandro G. Castro <alex@igalia.com>
1145 [GTK] [EFL] Avoid running mediastream tests by default until we compile by default
1146 https://bugs.webkit.org/show_bug.cgi?id=153540
1148 Reviewed by Philippe Normand.
1150 After bumping gstreamer to 1.6.3 in r196804 we can enable again
1151 compilation of mediastream and running the tests.
1153 * Scripts/run-gtk-tests:
1154 (TestRunner): Enable again the UserMedia API test.
1155 * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the
1156 mediastream by default.
1157 * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules
1159 * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we
1160 are currently using.
1162 2016-03-07 Jon Lee <jonlee@apple.com>
1164 Update perf bot configuration for Animometer
1165 https://bugs.webkit.org/show_bug.cgi?id=155134
1167 Reviewed by Ryosuke Niwa.
1169 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch
1170 to work with the latest version of the harness.
1171 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout,
1172 and use the latest version of the harness.
1174 2016-03-07 Joanmarie Diggs <jdiggs@igalia.com>
1176 [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
1177 https://bugs.webkit.org/show_bug.cgi?id=154839
1179 Reviewed by Michael Catanzaro.
1181 Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos.
1183 * gtk/jhbuild-webrtc.modules:
1184 * gtk/jhbuild.modules:
1187 2016-03-07 Aakash Jain <aakash_jain@apple.com>
1189 webkitpy should verify timestamp from CrashLogs while collecting all crash logs
1190 https://bugs.webkit.org/show_bug.cgi?id=155000
1191 <rdar://problem/24860219>
1193 Reviewed by Alexey Proskuryakov.
1195 * Scripts/webkitpy/common/system/crashlogs.py:
1196 (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected
1197 time range, because file modification time is not always accurate.
1198 (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
1199 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1200 (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
1202 2016-03-06 Alexey Proskuryakov <ap@apple.com>
1204 build-webkit prints an error on iOS simulator bots
1205 https://bugs.webkit.org/show_bug.cgi?id=155078
1207 Reviewed by Dan Bernstein.
1209 This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK.
1211 * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because
1212 XcodeOptions() already passes SDKROOT as appropriate.
1214 * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset
1215 any other configuration variables that were derived from its initial value, like $portName.
1217 2016-03-05 Tim Horton <timothy_horton@apple.com>
1219 Create a DOMHTMLVideoElement when wrapping <video> elements
1220 https://bugs.webkit.org/show_bug.cgi?id=155084
1221 <rdar://problem/24997193>
1223 Reviewed by Dan Bernstein.
1225 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1226 * TestWebKitAPI/Tests/mac/DOMHTMLVideoElementWrapper.mm: Added.
1227 (-[VideoWrapperFrameLoadDelegate webView:didFinishLoadForFrame:]):
1228 (TestWebKitAPI::TEST):
1229 Add an API test for this behavior.
1231 2016-03-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
1233 [GTK] Fix logging details after r197505 (Run the run-benchmark script on the performance bot.)
1234 https://bugs.webkit.org/show_bug.cgi?id=154595
1238 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1239 (start): Use logging.exception when a test fails in order to get the details about the error.
1241 2016-03-04 Alexey Proskuryakov <ap@apple.com>
1243 Add iOS simulator debug bots
1244 https://bugs.webkit.org/show_bug.cgi?id=155053
1246 Reviewed by Lucas Forschler.
1248 * BuildSlaveSupport/build.webkit.org-config/config.json:
1250 2016-03-04 Brent Fulgham <bfulgham@apple.com>
1252 [WK2] Gather resource load statistics
1253 https://bugs.webkit.org/show_bug.cgi?id=154278
1254 <rdar://problem/24702892>
1256 Reviewed by Andy Estes.
1258 * MiniBrowser/mac/AppDelegate.m:
1259 (defaultConfiguration): Retrieve state of the ResourceLoadStatisticsEnabled setting.
1260 * MiniBrowser/mac/SettingsController.m:
1261 (-[SettingsController _populateMenu]): Move setting from WK1-only to be
1262 universally applicable.
1263 * MiniBrowser/mac/WK2BrowserWindowController.m:
1264 (-[WK2BrowserWindowController didChangeSettings]): Recognize when the
1265 Resource Load Statistics flag has changed.
1267 2016-03-04 Alex Christensen <achristensen@webkit.org>
1269 Remove vcxproj build system
1270 https://bugs.webkit.org/show_bug.cgi?id=154388
1272 Rubber-stamped by Brent Fulgham.
1274 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Removed.
1275 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Removed.
1276 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Removed.
1277 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Removed.
1278 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Removed.
1279 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Removed.
1280 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Removed.
1281 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Removed.
1282 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Removed.
1283 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Removed.
1284 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Removed.
1285 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Removed.
1286 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Removed.
1287 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Removed.
1288 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Removed.
1289 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Removed.
1290 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Removed.
1291 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Removed.
1292 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Removed.
1293 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Removed.
1294 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Removed.
1295 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Removed.
1296 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Removed.
1297 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Removed.
1298 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Removed.
1299 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Removed.
1300 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Removed.
1301 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Removed.
1302 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Removed.
1303 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Removed.
1304 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Removed.
1305 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Removed.
1306 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Removed.
1307 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Removed.
1308 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Removed.
1309 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Removed.
1310 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Removed.
1311 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Removed.
1312 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Removed.
1313 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Removed.
1314 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Removed.
1315 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Removed.
1316 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Removed.
1317 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Removed.
1318 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Removed.
1319 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Removed.
1320 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Removed.
1321 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Removed.
1322 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Removed.
1323 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Removed.
1324 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Removed.
1325 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Removed.
1326 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Removed.
1327 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Removed.
1328 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Removed.
1329 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Removed.
1330 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Removed.
1331 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Removed.
1332 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Removed.
1333 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Removed.
1334 * TestWebKitAPI/TestWebKitAPI.vcxproj: Removed.
1335 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Removed.
1336 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Removed.
1337 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Removed.
1338 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Removed.
1339 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Removed.
1340 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Removed.
1341 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Removed.
1342 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Removed.
1343 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Removed.
1344 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Removed.
1345 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Removed.
1346 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Removed.
1347 * win/AssembleBuildLogs: Removed.
1348 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Removed.
1349 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Removed.
1350 * win/AssembleBuildLogs/AssembleLogs.cmd: Removed.
1351 * win/AssembleBuildLogs/README: Removed.
1353 2016-03-04 Myles C. Maxfield <mmaxfield@apple.com>
1355 Whitespace causes font-variant: all-small-caps to synthesize
1356 https://bugs.webkit.org/show_bug.cgi?id=155004
1357 <rdar://problem/24630796>
1359 Reviewed by Darin Adler.
1361 * DumpRenderTree/mac/DumpRenderTree.mm:
1362 (allowedFontFamilySet):
1363 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1364 (WTR::allowedFontFamilySet):
1365 * WebKitTestRunner/mac/TestControllerMac.mm:
1366 (WTR::allowedFontFamilySet):
1368 2016-03-04 Myles C. Maxfield <mmaxfield@apple.com>
1370 [iOS] Crash during font loading when injected bundle cancels load
1371 https://bugs.webkit.org/show_bug.cgi?id=155001
1373 Reviewed by Tim Horton.
1375 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1376 * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
1377 * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
1378 * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
1379 (-[Myles webView:didFinishNavigation:]):
1381 * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
1382 (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1383 (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
1385 2016-03-04 Konstantin Tokarev <annulen@yandex.ru>
1387 [check-webkit-style] Added checks for redundant virtual specifiers.
1388 https://bugs.webkit.org/show_bug.cgi?id=155017
1390 Reviewed by Darin Adler.
1392 Added 3 new checks related to virtual, override, and final specifiers:
1394 1. When "override" is present, "virtual" is redundant.
1395 2. When "final" is present, "virtual" is redundant.
1396 3. When "final" is present, "override" is redundant.
1398 * Scripts/webkitpy/style/checkers/cpp.py:
1399 (_FunctionState.begin):
1400 (_FunctionState.is_virtual):
1401 (_check_parameter_name_against_text):
1402 (_error_redundant_specifier):
1403 (check_function_definition):
1405 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1406 (FunctionDetectionTest.perform_function_detection):
1407 (FunctionDetectionTest.test_basic_function_detection):
1408 (FunctionDetectionTest.test_function_declaration_detection):
1409 (FunctionDetectionTest.test_pure_function_detection):
1410 (FunctionDetectionTest.test_override_and_final_function_detection):
1411 (FunctionDetectionTest.test_non_functions):
1412 (FunctionDetectionTest.test_parameter_list):
1414 2016-03-03 Darin Adler <darin@apple.com>
1417 Remove "virtual" from all lines that have both "virtual" and "override".
1418 https://bugs.webkit.org/show_bug.cgi?id=155005
1420 Reviewed by Geoffrey Garen.
1422 * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
1423 use either override or final, not both, and to remove virtual from all lines that
1424 have both virtual and final.
1426 2016-03-03 Darin Adler <darin@apple.com>
1428 Remove "virtual" from all lines that have both "virtual" and "override".
1429 https://bugs.webkit.org/show_bug.cgi?id=155005
1431 Reviewed by Geoffrey Garen.
1433 * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
1435 2016-03-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
1437 [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
1438 https://bugs.webkit.org/show_bug.cgi?id=154595
1440 Unreviewed fix after r197505.
1442 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1443 (RunBenchmarkTests.start):
1445 2016-03-03 Daniel Bates <dabates@apple.com>
1447 Add unit tests for WTF::OptionSet
1448 https://bugs.webkit.org/show_bug.cgi?id=154925
1449 <rdar://problem/24964211>
1451 Reviewed by Darin Adler.
1453 Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
1455 * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
1456 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1457 * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
1458 (TestWebKitAPI::TEST):
1460 2016-03-03 Commit Queue <commit-queue@webkit.org>
1462 Unreviewed, rolling out r197442.
1463 https://bugs.webkit.org/show_bug.cgi?id=154967
1465 Broke tests, and also uses a wrong approach (Requested by ap
1470 "Disable FTL JIT testing on 32-bit JSC tester bots"
1471 https://bugs.webkit.org/show_bug.cgi?id=154858
1472 http://trac.webkit.org/changeset/197442
1474 2016-03-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
1476 [GTK] Run the run-benchmark script on the performance bot.
1477 https://bugs.webkit.org/show_bug.cgi?id=154595
1479 Reviewed by Carlos Garcia Campos.
1481 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
1482 (RunBenchmarkTests):
1483 (RunBenchmarkTests.start):
1484 (RunBenchmarkTests.getText):
1485 (RunBenchmarkTests.getText2):
1486 (BuildAndPerfTestFactory.__init__):
1487 (DownloadAndPerfTestFactory.__init__):
1488 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add new test for RunBenchmarkTests and update expected steps of GTK+ perf bot.
1490 (RunBenchmarkTest.assertResults):
1491 (RunBenchmarkTest.test_success):
1492 (RunBenchmarkTest.test_tests_failed):
1493 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Log both the current iteration as also the total iterations for the current benchmark/plan.
1494 (BenchmarkRunner._run_benchmark):
1495 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Use python logging also for errors.
1496 (GTKMiniBrowserDriver.close_browsers):
1497 * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Implement support for running all available benchmark plans.
1502 2016-03-03 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1504 [EFL] Remove u-szeged.hu SVN mirror in EFL perf bot
1505 https://bugs.webkit.org/show_bug.cgi?id=154960
1507 Reviewed by Csaba Osztrogonác.
1509 * BuildSlaveSupport/build.webkit.org-config/config.json: Remove szeged univ's svn mirror.
1510 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1512 2016-03-03 Frederic Wang <fwang@igalia.com>
1514 [jhbuild] Remove LLVM dependency.
1515 https://bugs.webkit.org/show_bug.cgi?id=153274
1517 Reviewed by Carlos Garcia Campos.
1519 * gtk/jhbuild.modules:
1521 2016-03-02 Alejandro G. Castro <alex@igalia.com>
1523 Unreviewed build fix for media-stream after r197114.
1525 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1526 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1528 2016-03-01 Csaba Osztrogonác <ossy@webkit.org>
1530 Disable FTL JIT testing on 32-bit JSC tester bots
1531 https://bugs.webkit.org/show_bug.cgi?id=154858
1533 Reviewed by Saam Barati.
1535 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1538 2016-03-01 Dean Johnson <dean_johnson@apple.com>
1541 https://bugs.webkit.org/show_bug.cgi?id=154880
1543 Reviewed by Alexey Proskuryakov.
1545 * Scripts/copy-webkitlibraries-to-product-directory:
1547 2016-02-29 Chris Dumez <cdumez@apple.com>
1549 Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
1550 https://bugs.webkit.org/show_bug.cgi?id=154845
1552 Reviewed by Ryosuke Niwa.
1554 Update API tests accordingly.
1556 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
1557 (TestWebKitAPI::testParseHTMLInteger):
1558 (TestWebKitAPI::parseHTMLIntegerFails):
1559 (TestWebKitAPI::testParseHTMLNonNegativeInteger):
1560 (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
1561 (TestWebKitAPI::TEST): Deleted.
1563 2016-02-29 Simon Fraser <simon.fraser@apple.com>
1565 Remove the experimental feature of antialiased font dilation
1566 https://bugs.webkit.org/show_bug.cgi?id=154843
1568 Reviewed by Zalan Bujtas.
1570 Remove the "antialiased font dilation" code path, and related prefs.
1572 * DumpRenderTree/mac/DumpRenderTree.mm:
1573 (resetWebPreferencesToConsistentValues): Deleted.
1574 * WebKitTestRunner/TestController.cpp:
1575 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1577 2016-02-29 Brady Eidson <beidson@apple.com>
1579 Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
1583 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
1584 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
1585 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1586 (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
1587 so we should always wait for it and make sure we got it.
1589 2016-02-29 Brady Eidson <beidson@apple.com>
1591 Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
1592 https://bugs.webkit.org/show_bug.cgi?id=154837
1594 Reviewed by Alex Christensen.
1596 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1597 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
1598 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
1599 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
1601 2016-02-29 Joanmarie Diggs <jdiggs@igalia.com>
1603 [GTK][jhbuild] GLib build fails with GCC 6.0
1604 https://bugs.webkit.org/show_bug.cgi?id=154825
1606 Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
1608 Reviewed by Csaba Osztrogonác.
1610 * gtk/jhbuild.modules: Apply upstream path.
1611 * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
1613 2016-02-29 Filip Pizlo <fpizlo@apple.com>
1615 We've been running Octane/regexp all wrong in run-jsc-benchmarks
1616 https://bugs.webkit.org/show_bug.cgi?id=154827
1618 Reviewed by Andreas Kling.
1620 Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
1621 it without warmup. This patches fixes this by making this script run it with warmup.
1623 This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
1624 speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
1626 It discovered this bug because for each Octane test that I want to debug, I usually make
1627 a standalone .js file that contains the whole test along with a miniharness - usually
1628 a plain loop - that runs it almost like it would for real but with whatever hacks I'm
1629 using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
1630 to match the one second of warmup that this benchmark gets in Octane. To my surprise,
1631 this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
1632 saw. That's when I found out that run-jsc-benchmarks was running it wrong.
1634 The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
1635 run on some of these very large functions in the regexp benchmark. I don't think we can
1636 do anything about that, and I'd argue that the speed-up we see after the compilation is
1637 done suggests that it was worth it.
1639 * Scripts/run-jsc-benchmarks:
1641 2016-02-29 Gavin Barraclough <barraclough@apple.com>
1643 RefCounter<T>::Event -> RefCounterEvent
1644 https://bugs.webkit.org/show_bug.cgi?id=154767
1646 Reviewed by Darin Adler.
1648 RefCounter<T>::Event is kinda verbose to use, and there is no need for this
1649 to be specific to a particular typeof RefCounter. Move the enum class up to
1650 the top level & rename to RefCounterEvent.
1652 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1653 (TestWebKitAPI::TEST):
1655 2016-02-29 Csaba Osztrogonác <ossy@webkit.org>
1657 Remove more LLVM related cruft
1658 https://bugs.webkit.org/show_bug.cgi?id=154821
1660 Reviewed by Darin Adler.
1662 * Scripts/build-jsc:
1663 * Scripts/build-webkit:
1664 * Scripts/copy-webkitlibraries-to-product-directory:
1665 * Scripts/export-llvm-build: Removed.
1666 * Scripts/run-jsc-stress-tests:
1668 2016-02-28 Sam Weinig <sam@webkit.org>
1670 Reimplement WKPageGroup in terms of WKUserContentController
1671 https://bugs.webkit.org/show_bug.cgi?id=154804
1673 Reviewed by Dan Bernstein.
1675 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1676 * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
1678 2016-02-28 Sam Weinig <sam@webkit.org>
1680 Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
1681 https://bugs.webkit.org/show_bug.cgi?id=154798
1683 Reviewed by Dan Bernstein.
1685 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1686 Add tests for removing _WKUserStyleSheets and WKUserScripts
1688 2016-02-27 Alexey Proskuryakov <ap@apple.com>
1690 Silence leaks under TextCodecICU::registerCodecs
1691 https://bugs.webkit.org/show_bug.cgi?id=154737
1693 Reviewed by Darin Adler.
1695 * Scripts/webkitpy/port/leakdetector.py:
1696 (LeakDetector._callstacks_to_exclude_from_leaks):
1698 2016-02-26 Michael Catanzaro <mcatanzaro@igalia.com>
1700 [GTK] Fix incorrect cast
1704 * MiniBrowser/gtk/main.c:
1705 (createBrowserWindow):
1707 2016-02-26 Chris Dumez <cdumez@apple.com>
1709 Fix the behavior of reflecting IDL attributes of type unsigned long
1710 https://bugs.webkit.org/show_bug.cgi?id=154771
1712 Reviewed by Ryosuke Niwa.
1714 Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
1716 - "-0" is parsed as 0.
1717 - Range boundaries are now [0; 2147483647].
1719 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
1720 (TestWebKitAPI::TEST):
1722 2016-02-26 Brady Eidson <beidson@apple.com>
1724 Modern IDB: New database versions are never committed to SQLite.
1725 <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
1727 Modern IDB: If a database handle is not open, files are not actually deleted from disk
1728 https://bugs.webkit.org/show_bug.cgi?id=154756
1730 Reviewed by Alex Christensen.
1732 This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
1734 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1735 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
1736 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
1737 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
1738 (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
1739 (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
1742 2016-02-26 Commit Queue <commit-queue@webkit.org>
1744 Unreviewed, rolling out r197216.
1745 https://bugs.webkit.org/show_bug.cgi?id=154766
1747 Test simply needs updated result (Requested by litherum on
1752 "Unreviewed, rolling out r197158."
1753 https://bugs.webkit.org/show_bug.cgi?id=154758
1754 http://trac.webkit.org/changeset/197216
1756 2016-02-26 Alexey Proskuryakov <ap@apple.com>
1758 [iOS Simulator] Reftests don't work
1759 https://bugs.webkit.org/show_bug.cgi?id=154764
1761 Reviewed by Daniel Bates.
1763 * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
1764 Use simctl instead of sim.
1766 2016-02-26 Chris Dumez <cdumez@apple.com>
1768 Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
1769 https://bugs.webkit.org/show_bug.cgi?id=154714
1771 Reviewed by Darin Adler.
1773 Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
1774 - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
1775 - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
1777 * TestWebKitAPI/PlatformEfl.cmake:
1778 * TestWebKitAPI/PlatformGTK.cmake:
1779 * TestWebKitAPI/PlatformWin.cmake:
1780 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1781 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1782 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1783 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
1784 (TestWebKitAPI::testParseHTMLInteger):
1785 (TestWebKitAPI::parseHTMLIntegerFails):
1786 (TestWebKitAPI::TEST):
1787 (TestWebKitAPI::testParseHTMLNonNegativeInteger):
1788 (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
1790 2016-02-26 Commit Queue <commit-queue@webkit.org>
1792 Unreviewed, rolling out r197158.
1793 https://bugs.webkit.org/show_bug.cgi?id=154758
1795 This change did not fix the failing test (Requested by
1796 ryanhaddad on #webkit).
1800 "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
1801 surrogate.html is flakey"
1802 https://bugs.webkit.org/show_bug.cgi?id=154709
1803 http://trac.webkit.org/changeset/197158
1805 2016-02-26 Anders Carlsson <andersca@apple.com>
1807 WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
1808 https://bugs.webkit.org/show_bug.cgi?id=154750
1809 rdar://problem/23861395
1811 Reviewed by Tim Horton.
1813 * MiniBrowser/mac/WK2BrowserWindowController.m:
1814 (-[WK2BrowserWindowController fetchWebsiteData:]):
1815 Use the new WKWebsiteDataStore SPI to compute data sizes.
1817 2016-02-25 Gavin Barraclough <barraclough@apple.com>
1819 RefCounter value changed callback should be called on all changes (not just zero edge).
1820 https://bugs.webkit.org/show_bug.cgi?id=154699
1822 Reviewed by Geoff Garen.
1824 RefCounter currently only triggers a callback when the count goes from zero
1825 to non-zero and vice-versa. Change that, to be useful to more clients.
1827 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1828 (TestWebKitAPI::TEST):
1829 - Updated for change in RefCounter callback siganture & behaviour.
1831 2016-02-25 Sam Weinig <sam@webkit.org>
1833 Allow WKUserScripts to be run in isolated worlds
1834 https://bugs.webkit.org/show_bug.cgi?id=154701
1836 Reviewed by Anders Carlsson.
1838 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1839 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
1840 (-[SimpleDelegate webView:didFinishNavigation:]):
1841 (-[UserContentWorldRemoteObject didObserveNormalWorld]):
1842 (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
1843 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
1844 (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1845 (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1846 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
1848 2016-02-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
1850 W3C test importer should have an option to clean the destination directory
1851 https://bugs.webkit.org/show_bug.cgi?id=152685
1853 Reviewed by Darin Adler.
1855 Adding --clean-dest-dir option to W3C test importer.
1856 When this option is set, all files in the destination directory will be deleted
1857 except for WebKit specific files (test expectations, .gitignore...) before new tests import.
1858 Dangling test expectations are removed after tests import.'
1860 Adding unit test and minor refactoring for the other tests.
1862 * Scripts/webkitpy/w3c/test_importer.py:
1863 (parse_args): Add '--clean-dest-dir' option.
1864 (TestImporter.do_import):
1865 (TestImporter._is_baseline): helper routine to capture -expected.txt files.
1867 (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
1868 (TestImporter.clean_destination_directory):
1869 (TestImporter.remove_dangling_expectations):
1870 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1871 (TestImporterTest._parse_options):
1872 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1873 (TestImporterTest.test_import_dir_with_no_tests):
1874 (TestImporterTest.test_import_dir_with_empty_init_py):
1875 (test_clean_directory_option):
1877 2016-02-25 Myles C. Maxfield <mmaxfield@apple.com>
1879 REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
1880 https://bugs.webkit.org/show_bug.cgi?id=154709
1881 <rdar://problem/24483596>
1883 Reviewed by Dan Bernstein.
1885 Force auto-activation rules to a consistent state.
1887 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1888 (WTR::InjectedBundle::platformInitialize):
1890 2016-02-25 Jiewen Tan <jiewen_tan@apple.com>
1892 Unreivewed build fix for r197150.
1894 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
1896 2016-02-25 Jiewen Tan <jiewen_tan@apple.com>
1898 Restrict information passed with navigation action which is triggered by untrusted event
1899 https://bugs.webkit.org/show_bug.cgi?id=154571
1900 <rdar://problem/15967937>
1902 Reviewed by Andy Estes.
1904 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1905 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
1906 (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1907 (TestWebKitAPI::TEST):
1908 (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1909 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
1911 2016-02-25 Gavin Barraclough <barraclough@apple.com>
1913 Should template RefCounter instead of RefCounter::Token
1914 https://bugs.webkit.org/show_bug.cgi?id=154691
1916 Reviewed by Anders Carlsson.
1918 Mechanical update per RefCounter interface change.
1920 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1921 (TestWebKitAPI::TEST):
1923 2016-02-25 Skachkov Aleksandr <gskachkov@gmail.com>
1925 Unreviewed: Add Aleksandr Skachkov as a commiter
1927 * Scripts/webkitpy/common/config/contributors.json:
1929 2016-02-25 Sam Weinig <sam@webkit.org>
1931 HashMap::ensure() should return an AddResult like all the other add-like functions
1932 https://bugs.webkit.org/show_bug.cgi?id=154680
1934 Reviewed by Anders Carlsson.
1936 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1937 (TestWebKitAPI::TEST):
1938 Update tests to use/test the new AddResult result.
1940 2016-02-25 Alexey Proskuryakov <ap@apple.com>
1942 Enable MallocScribble when detecting leaks
1943 https://bugs.webkit.org/show_bug.cgi?id=154679
1945 Reviewed by Geoffrey Garen.
1947 * Scripts/webkitpy/port/ios.py:
1948 (IOSSimulatorPort.setup_environ_for_server):
1949 * Scripts/webkitpy/port/mac.py:
1950 (MacPort.setup_environ_for_server):
1951 * Scripts/webkitpy/port/mac_unittest.py:
1952 (MacTest.test_setup_environ_for_server):
1954 2016-02-25 Eric Carlson <eric.carlson@apple.com>
1956 Unreviewed, fix iOS builds after r197114.
1958 * WebKitTestRunner/TestController.cpp:
1959 (WTR::createCanonicalUUIDString):
1960 (WTR::TestController::saltForOrigin):
1962 2016-02-25 Eric Carlson <eric.carlson@apple.com>
1964 [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
1965 https://bugs.webkit.org/show_bug.cgi?id=153163
1966 <rdar://problem/24334526>
1968 Reviewed by Tim Horton.
1970 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1971 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
1972 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1974 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1975 (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
1976 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1978 * WebKitTestRunner/TestController.cpp:
1979 (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
1980 (WTR::checkUserMediaPermissionForOrigin): Ditto.
1981 (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
1982 (WTR::originUserVisibleName): Return a String.
1983 (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
1984 (WTR::TestController::saltForOrigin): Return salt for an origin.
1985 (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
1986 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1987 (WTR::TestController::handleUserMediaPermissionRequest):
1988 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1989 (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
1990 (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
1991 (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
1992 (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
1993 (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
1994 (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
1995 * WebKitTestRunner/TestController.h:
1997 * WebKitTestRunner/TestInvocation.cpp:
1998 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2000 2016-02-24 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
2002 [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
2003 https://bugs.webkit.org/show_bug.cgi?id=151688
2005 Reviewed by Dean Jackson.
2007 Enables the WEB_ANIMATIONS compiler switch by default.
2009 * Scripts/webkitperl/FeatureList.pm:
2011 2016-02-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
2013 W3C importer should generate all web-platform-tests submodules descriptions
2014 https://bugs.webkit.org/show_bug.cgi?id=154587
2016 Reviewed by Darin Adler.
2018 Updated submodules description format (removing submodule name as it is the last string of the path really).
2019 Added git subroutines.
2021 * Scripts/webkitpy/common/checkout/scm/git.py:
2024 (Git.init_submodules):
2025 (Git.submodules_status):
2026 (Git.deinit_submodules):
2027 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2028 (WebPlatformTestServer._install_modules): Updated to submodule name removal.
2029 * Scripts/webkitpy/w3c/test_downloader.py:
2030 (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
2031 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2032 (TestImporterTest.test_submodules_generation): Reactivated partially this test.
2034 2016-02-23 Dan Bernstein <mitz@apple.com>
2036 [Xcode] Linker errors display mangled names, but no longer should
2037 https://bugs.webkit.org/show_bug.cgi?id=154632
2039 Reviewed by Sam Weinig.
2041 * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
2042 * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
2043 * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
2044 * MiniBrowser/Configurations/Base.xcconfig: Ditto.
2045 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2046 * WebEditingTester/Configurations/Base.xcconfig: Ditto.
2047 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2049 2016-02-23 Anders Carlsson <andersca@apple.com>
2051 WKWebView should implement NSCoding
2052 https://bugs.webkit.org/show_bug.cgi?id=137160
2054 Reviewed by Dan Bernstein.
2058 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2061 2016-02-23 Anders Carlsson <andersca@apple.com>
2063 WKProcessPool should conform to NSCoding
2064 https://bugs.webkit.org/show_bug.cgi?id=154608
2066 Reviewed by Sam Weinig.
2070 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2073 2016-02-23 Anders Carlsson <andersca@apple.com>
2075 WKWebsiteDataStore should conform to NSCoding
2076 https://bugs.webkit.org/show_bug.cgi?id=154605
2078 Reviewed by Dan Bernstein.
2080 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2083 2016-02-23 Anders Carlsson <andersca@apple.com>
2085 WKWebViewConfiguration should conform to NSCoding
2086 https://bugs.webkit.org/show_bug.cgi?id=154602
2088 Reviewed by Beth Dakin.
2090 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2093 2016-02-23 Anders Carlsson <andersca@apple.com>
2095 WKPreferences should conform to NSCoding
2096 https://bugs.webkit.org/show_bug.cgi?id=154597
2098 Reviewed by Sam Weinig.
2100 Test encoding and decoding WKPreferences.
2102 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2106 2016-02-23 Anders Carlsson <andersca@apple.com>
2110 * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2111 (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
2113 2016-02-23 Carlos Alberto Lopez Perez <clopez@igalia.com>
2115 [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
2116 https://bugs.webkit.org/show_bug.cgi?id=153993
2118 Reviewed by Carlos Garcia Campos.
2120 * MiniBrowser/gtk/main.c:
2121 (createBrowserWindow): Support --geometry argument for MiniBrowser.
2122 We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
2123 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses:
2124 The base class has to be loaded first, otherwise any subclase referencing it will give import error.
2125 In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
2126 By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
2127 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2128 (BrowserDriverFactory.create):
2129 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
2131 (GTKBrowserDriver.prepare_env):
2132 (GTKBrowserDriver.restore_env):
2133 (GTKBrowserDriver.close_browsers):
2134 (GTKBrowserDriver._launch_process):
2135 (GTKBrowserDriver._terminate_processes):
2136 (GTKBrowserDriver._screen_size):
2137 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
2138 (GTKMiniBrowserDriver):
2139 (GTKMiniBrowserDriver.prepare_env):
2140 (GTKMiniBrowserDriver.launch_url):
2141 (GTKMiniBrowserDriver.close_browsers):
2142 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above.
2143 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2144 (SimpleHTTPServerDriver):
2145 (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.
2146 Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log.
2147 * Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above.
2150 2016-02-23 Alejandro G. Castro <alex@igalia.com>
2152 [GTK] Missing configuration patch for openh264 compilation
2153 https://bugs.webkit.org/show_bug.cgi?id=154455
2155 This patch is required for the openh264 compilation with the
2156 jhbuild-webrtc.modules. The code was implemented by Alessandro
2159 Reviewed by Philippe Normand.
2161 * gtk/patches/openh264-configure.patch: Added.
2163 2016-02-20 Olivier Blin <olivier.blin@softathome.com>
2165 [cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner
2166 https://bugs.webkit.org/show_bug.cgi?id=154479
2168 Reviewed by Michael Catanzaro.
2170 * WebKitTestRunner/CMakeLists.txt:
2172 2016-02-19 Konstantin Tokarev <annulen@yandex.ru>
2174 [GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined.
2175 https://bugs.webkit.org/show_bug.cgi?id=154467
2177 Reviewed by Michael Catanzaro.
2179 * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp:
2183 2016-02-19 Brady Eidson <beidson@apple.com>
2185 Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR.
2186 https://bugs.webkit.org/show_bug.cgi?id=154428
2188 Reviewed by Jer Noble.
2190 * WebKitTestRunner/TestController.cpp:
2191 (WTR::TestController::generatePageConfiguration):
2192 (WTR::TestController::databaseProcessName):
2193 (WTR::TestController::databaseProcessDidCrash):
2194 * WebKitTestRunner/TestController.h:
2196 2016-02-18 Philippe Normand <pnormand@igalia.com>
2198 [GStreamer] Bump internal jhbuild versions to 1.6.3
2199 https://bugs.webkit.org/show_bug.cgi?id=149594
2201 Reviewed by Michael Catanzaro.
2203 * gtk/jhbuild.modules: Bump to GStreamer 1.6.3.
2204 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
2205 * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
2206 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2208 2016-02-18 Brent Fulgham <bfulgham@apple.com>
2210 Extend HashCountedSet with a method to efficiently set the count of an entry
2211 https://bugs.webkit.org/show_bug.cgi?id=154352
2213 Reviewed by Geoffrey Garen.
2215 * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
2216 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2217 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
2219 2016-02-18 Commit Queue <commit-queue@webkit.org>
2221 Unreviewed, rolling out r196791.
2222 https://bugs.webkit.org/show_bug.cgi?id=154438
2224 broke windows build (Requested by alexchristensen on #webkit).
2228 "Extend HashCountedSet with a method to efficiently set the
2230 https://bugs.webkit.org/show_bug.cgi?id=154352
2231 http://trac.webkit.org/changeset/196791
2233 2016-02-18 Brent Fulgham <bfulgham@apple.com>
2235 Extend HashCountedSet with a method to efficiently set the count of an entry
2236 https://bugs.webkit.org/show_bug.cgi?id=154352
2238 Reviewed by Geoffrey Garen.
2240 * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
2241 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2242 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
2244 2016-02-18 Anders Carlsson <andersca@apple.com>
2246 Get rid of the --target-web-process and --use-web-process-xpc-service options.
2248 Rubber-stamped by Dan Bernstein.
2250 We now always use XPC, and --target-web-process is no longer supported.
2252 * Scripts/webkitdirs.pm:
2253 (execMacWebKitAppForDebugging):
2254 (shouldTargetWebProcess): Deleted.
2255 (determineShouldTargetWebProcess): Deleted.
2256 (shouldUseXPCServiceForWebProcess): Deleted.
2257 (determineShouldUseXPCServiceForWebProcess): Deleted.
2258 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
2259 (argumentsForRunAndDebugMacWebKitApp): Deleted.
2261 2016-02-18 Ryan Haddad <ryanhaddad@apple.com>
2263 Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
2264 https://bugs.webkit.org/show_bug.cgi?id=153997
2266 Reviewed by Filip Pizlo.
2268 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2270 2016-02-18 Jer Noble <jer.noble@apple.com>
2272 run-webkit-httpd should use webkitpy to run httpd.
2273 https://bugs.webkit.org/show_bug.cgi?id=154271
2275 Reviewed by Alexey Proskuryakov.
2277 Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
2278 options to match the current run-webkit-httpd (optional) behavior.
2280 * Scripts/run-webkit-httpd:
2283 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2284 (LayoutTestApacheHttpd.__init__):
2285 * Scripts/webkitpy/layout_tests/servers/http_server.py:
2286 (Lighttpd._prepare_config):
2287 * Scripts/webkitpy/port/base.py:
2288 (Port.to.start_http_server):
2290 2016-02-18 Filip Pizlo <fpizlo@apple.com>
2292 Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
2293 https://bugs.webkit.org/show_bug.cgi?id=154383
2295 Reviewed by Saam Barati.
2297 * Scripts/run-jsc-stress-tests:
2299 2016-02-17 Filip Pizlo <fpizlo@apple.com>
2301 Remove LLVM dependencies from WebKit
2302 https://bugs.webkit.org/show_bug.cgi?id=154323
2304 Reviewed by Antti Koivisto and Benjamin Poulain.
2306 * Scripts/copy-webkitlibraries-to-product-directory:
2307 (isContentOfFileEqualToString):
2308 (fileContains): Deleted.
2309 (buildLLVM): Deleted.
2310 (symlinkLLVMLibrariesIfNeeded): Deleted.
2312 2016-02-16 Sam Weinig <sam@webkit.org>
2314 Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
2315 https://bugs.webkit.org/show_bug.cgi?id=134857
2317 Reviewed by Geoffrey Garen.
2319 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2320 Add tests for HashMap::ensure.
2322 2016-02-17 Nan Wang <n_wang@apple.com>
2324 AX: Implement sentence related text marker functions using TextIterator
2325 https://bugs.webkit.org/show_bug.cgi?id=154312
2327 Reviewed by Chris Fleizach.
2329 * DumpRenderTree/AccessibilityUIElement.cpp:
2330 (nextParagraphEndTextMarkerForTextMarkerCallback):
2331 (sentenceTextMarkerRangeForTextMarkerCallback):
2332 (previousSentenceStartTextMarkerForTextMarkerCallback):
2333 (nextSentenceEndTextMarkerForTextMarkerCallback):
2334 (setSelectedVisibleTextRangeCallback):
2335 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2336 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2337 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2338 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2339 (AccessibilityUIElement::getJSClass):
2340 * DumpRenderTree/AccessibilityUIElement.h:
2341 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2342 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2343 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2344 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2345 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2346 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2347 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2348 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2349 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2350 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2351 (AccessibilityUIElement::supportedActions):
2352 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2353 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2354 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2355 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2356 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2357 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2358 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2359 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2360 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2361 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2362 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2363 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2364 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2365 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2366 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2367 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2368 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2369 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2370 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2371 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2372 (WTR::_convertMathMultiscriptPairsToString):
2374 2016-02-15 Brent Fulgham <bfulgham@apple.com>
2376 [Mac] Gather some rudimentary statistics during resource load
2377 https://bugs.webkit.org/show_bug.cgi?id=153575
2378 <rdar://problem/24075254>
2380 Reviewed by Brady Eidson.
2382 * MiniBrowser/mac/SettingsController.h:
2383 * MiniBrowser/mac/SettingsController.m:
2384 (-[SettingsController _populateMenu]): Add menu item for new debug flag.
2385 (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
2386 (-[SettingsController resourceLoadStatisticsEnabled]): Added.
2387 * MiniBrowser/mac/WK1BrowserWindowController.m:
2388 (-[WK1BrowserWindowController didChangeSettings]): React to changes in
2389 users's desire to track resource load statistics.
2391 2016-02-15 Csaba Osztrogonác <ossy@webkit.org>
2393 [EFL] Update Tools/efl/install-dependencies
2394 https://bugs.webkit.org/show_bug.cgi?id=154239
2396 Reviewed by Michael Catanzaro.
2398 * efl/install-dependencies:
2400 2016-02-15 Alex Christensen <achristensen@webkit.org>
2402 Fix internal Windows build of projects built after WebKit
2403 https://bugs.webkit.org/show_bug.cgi?id=154249
2404 rdar://problem/24644805
2406 Reviewed by Chris Dumez.
2408 * DumpRenderTree/PlatformWin.cmake:
2409 * MiniBrowser/win/CMakeLists.txt:
2410 Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
2411 more like projects built internally after WebKit. They should only need to use what
2412 is in ForwardingHeaders/WebKit.
2414 2016-02-12 Nan Wang <n_wang@apple.com>
2416 AX: Implement paragraph related text marker functions using TextIterator
2417 https://bugs.webkit.org/show_bug.cgi?id=154098
2418 <rdar://problem/24269675>
2420 Reviewed by Chris Fleizach.
2422 * DumpRenderTree/AccessibilityUIElement.cpp:
2423 (nextWordEndTextMarkerForTextMarkerCallback):
2424 (paragraphTextMarkerRangeForTextMarkerCallback):
2425 (previousParagraphStartTextMarkerForTextMarkerCallback):
2426 (nextParagraphEndTextMarkerForTextMarkerCallback):
2427 (setSelectedVisibleTextRangeCallback):
2428 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2429 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2430 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2431 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2432 (AccessibilityUIElement::getJSClass):
2433 * DumpRenderTree/AccessibilityUIElement.h:
2434 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2435 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2436 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2437 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2438 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2439 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2440 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2441 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2442 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2443 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2444 (AccessibilityUIElement::supportedActions):
2445 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2446 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2447 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2448 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2449 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2450 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2451 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2452 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2453 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2454 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2455 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2456 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2457 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2458 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2459 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2460 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2461 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2462 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2463 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2464 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2465 (WTR::_convertMathMultiscriptPairsToString):
2467 2016-02-12 Jason Marcell <jmarcell@apple.com>
2469 Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
2470 https://bugs.webkit.org/show_bug.cgi?id=154180
2472 Reviewed by Alexey Proskuryakov.
2474 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
2477 2016-02-12 Jer Noble <jer.noble@apple.com>
2479 [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
2480 https://bugs.webkit.org/show_bug.cgi?id=154136
2482 Reviewed by Alex Christensen.
2484 Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
2486 Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
2487 to GCC_PREPROCESSOR_DEFINES.
2489 * TestWebKitAPI/Configurations/Base.xcconfig:
2490 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2491 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2492 (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
2493 (TestWebKitAPI::TEST_F):
2495 2016-02-11 Dana Burkart <dburkart@apple.com>
2497 Large logs can bring down the webkit master
2498 https://bugs.webkit.org/show_bug.cgi?id=122112
2500 Reviewed by Lucas Forschler.
2502 Implement the suggested fix of throwing away stdout / stderr.
2504 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2505 (RunWebKit1LeakTests):
2507 2016-02-10 Jason Marcell <jmarcell@apple.com>
2509 Remove calls to parseInt in order to work with non-integer revisions
2510 https://bugs.webkit.org/show_bug.cgi?id=153820
2512 Reviewed by Daniel Bates.
2514 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2515 (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
2517 (BuildbotIteration.prototype._parseData): Ditto.
2518 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2519 (BuildbotQueue.prototype.update): Ditto.
2520 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
2521 (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
2522 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2523 (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
2524 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
2525 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
2527 2016-02-10 Jason Marcell <jmarcell@apple.com>
2529 Teach dashboard code to compare non-integer revisions
2530 https://bugs.webkit.org/show_bug.cgi?id=152345
2532 Reviewed by Daniel Bates.
2534 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2535 (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
2536 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2537 (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
2538 revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
2539 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
2540 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
2541 revisions. Also uses new Trac.nextRevision method to calculate a revision range.
2542 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2543 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2544 (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
2546 (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
2547 (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
2548 (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
2549 (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
2550 (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
2551 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
2553 2016-02-09 Nan Wang <n_wang@apple.com>
2555 AX: Implement word related text marker functions using TextIterator
2556 https://bugs.webkit.org/show_bug.cgi?id=153939
2557 <rdar://problem/24269605>
2559 Reviewed by Chris Fleizach.
2561 * DumpRenderTree/AccessibilityUIElement.cpp:
2562 (endTextMarkerCallback):
2563 (leftWordTextMarkerRangeForTextMarkerCallback):
2564 (rightWordTextMarkerRangeForTextMarkerCallback):
2565 (previousWordStartTextMarkerForTextMarkerCallback):
2566 (nextWordEndTextMarkerForTextMarkerCallback):
2567 (setSelectedVisibleTextRangeCallback):
2568 (AccessibilityUIElement::setSelectedVisibleTextRange):
2569 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2570 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2571 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2572 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2573 (AccessibilityUIElement::getJSClass):
2574 * DumpRenderTree/AccessibilityUIElement.h:
2575 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2576 (AccessibilityUIElement::setSelectedVisibleTextRange):
2577 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2578 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2579 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2580 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2581 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2582 (AccessibilityUIElement::setSelectedVisibleTextRange):
2583 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2584 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2585 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2586 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2587 (AccessibilityUIElement::supportedActions):
2588 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2589 (WTR::AccessibilityUIElement::setBoolAttributeValue):
2590 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2591 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2592 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2593 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2594 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2595 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2596 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2597 (WTR::AccessibilityUIElement::endTextMarker):
2598 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2599 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2600 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2601 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2602 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2603 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2604 (WTR::AccessibilityUIElement::endTextMarker):
2605 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2606 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2607 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2608 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2609 (WTR::_convertMathMultiscriptPairsToString):
2611 2016-02-09 Csaba Osztrogonác <ossy@webkit.org>
2613 [EFL] Remove eail related cruft after r195725
2614 https://bugs.webkit.org/show_bug.cgi?id=154030
2616 Reviewed by Alex Christensen.
2620 2016-02-09 Csaba Osztrogonác <ossy@webkit.org>
2622 [EFL] Remove LLVM related cruft after r196077
2623 https://bugs.webkit.org/show_bug.cgi?id=154031
2625 Reviewed by Alex Christensen.
2627 * efl/jhbuild.modules:
2628 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
2629 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
2630 * efl/patches/llvm-version-arm64.patch: Removed.
2632 2016-02-05 Aakash Jain <aakash_jain@apple.com>
2634 tests fail if display sleeps while run-webkit-tests is running
2635 https://bugs.webkit.org/show_bug.cgi?id=153919
2637 Reviewed by Alexey Proskuryakov.
2639 * DumpRenderTree/mac/LayoutTestHelper.m:
2640 (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
2641 (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
2642 (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
2644 2016-02-05 Alex Christensen <achristensen@webkit.org>
2646 Fix iOS API tests after r196082
2647 https://bugs.webkit.org/show_bug.cgi?id=153900
2649 Reviewed by Jer Noble.
2651 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2652 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2653 [WebView initialize] doesn't call JSC::initializeThreading on iOS.
2655 2016-02-04 Jason Marcell <jmarcell@apple.com>
2657 The status message for passing combined builder queues should say "all builds succeeded" when expanded.
2658 https://bugs.webkit.org/show_bug.cgi?id=153882
2660 Reviewed by Alexey Proskuryakov.
2662 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2663 (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
2666 2016-02-03 Filip Pizlo <fpizlo@apple.com>
2668 run-jsc-stress-tests should be better at telling you details about test failures
2669 https://bugs.webkit.org/show_bug.cgi?id=153845
2671 Reviewed by Geoffrey Garen.
2673 Here's an example of the contents of results/resultsByFamily, one of the new files that this
2674 generates, for some local testing I'm doing. Notice how it groups families of tests together.
2676 You won't see this unless you cat results/resultsByFamily.
2678 regress.yaml/Regress/radar-24289839.js:
2679 regress.yaml/Regress/radar-24289839.js.default: PASS
2680 regress.yaml/Regress/radar-24289839.js.ftl: PASS
2681 regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
2682 regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
2684 regress.yaml/Regress/radar-24290639.js:
2685 regress.yaml/Regress/radar-24290639.js.default: PASS
2686 regress.yaml/Regress/radar-24290639.js.ftl: PASS
2687 regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
2688 regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
2690 regress.yaml/Regress/radar-24290670.js: FAILED
2692 * Scripts/run-jsc-stress-tests:
2694 2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
2696 [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
2697 https://bugs.webkit.org/show_bug.cgi?id=153835
2699 Reviewed by Martin Robinson.
2701 WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
2702 the context menu event is not handled, but we are using the
2703 returned value without null checking it.
2705 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2706 (WTR::EventSendingController::contextClick):
2708 2016-02-03 Jason Marcell <jmarcell@apple.com>
2710 Format revisions for display according to repository type
2711 https://bugs.webkit.org/show_bug.cgi?id=153818
2713 Reviewed by Alexey Proskuryakov.
2715 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2716 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
2718 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2719 (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
2720 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
2721 _formatRevisionForDisplay function.
2723 2016-02-03 Aakash Jain <aakash_jain@apple.com>
2725 Logs/CoreSimulator filling up OS disk on WebKit testers
2726 https://bugs.webkit.org/show_bug.cgi?id=153853
2727 <rdar://problem/24496003>
2729 Reviewed by Alexey Proskuryakov.
2731 * Scripts/webkitpy/port/ios.py:
2732 (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
2734 2016-02-03 Brian Burg <bburg@apple.com>
2736 git-add-reviewer should work when run from a subdirectory within the repository
2737 https://bugs.webkit.org/show_bug.cgi?id=153842
2739 Reviewed by David Kilzer.
2741 There are two problems that needed to be fixed:
2743 - We can't assume .git is in $PWD/.git
2744 - We can't specify absolute paths to `git commit`
2746 Fix these problems using the helpers in VCSUtils that were added to
2747 fix this same issue for prepare-changeCogs.
2749 * Scripts/VCSUtils.pm: Export gitDirectory()
2750 * Scripts/git-add-reviewer:
2751 (nonInteractive): Cache gitDirectory() result.
2754 (changeLogsForCommit): Make paths relative.
2756 2016-02-03 Jer Noble <jer.noble@apple.com>
2758 Yet another Yosemite build fix.
2760 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2762 2016-02-03 Jer Noble <jer.noble@apple.com>
2764 iOS build fix after Yosemite build fix broke iOS build.
2766 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2768 2016-02-03 Jer Noble <jer.noble@apple.com>
2770 Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
2772 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2774 2016-02-03 Joonghun Park <jh718.park@samsung.com>
2776 [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
2777 https://bugs.webkit.org/show_bug.cgi?id=153827
2779 Reviewed by Michael Catanzaro.
2781 When an array is passed to subroutines as argument in perl,
2782 a list containing its element is returned from the array.
2783 Currently @$ arguments are being passed, then it is going to be one list
2784 including all the elements not only from @ but also from $.
2785 As a result, --cmakeargs option's value is included in @cmakeArgs
2786 at generateBuildSystemFromCMakeProject subroutine,
2787 so $additionalCMakeArgs doesn't needed anymore.
2789 * Scripts/webkitdirs.pm:
2790 (generateBuildSystemFromCMakeProject):
2792 2016-02-03 Jer Noble <jer.noble@apple.com>
2794 [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
2795 https://bugs.webkit.org/show_bug.cgi?id=153669
2797 Reviewed by Alex Christensen.
2799 Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
2800 calling appropriate NSURLSessionDelegate callbacks.
2802 Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI. Without this, the ENABLE macros in WebCore
2803 header files will not match the one used when compiling WebCore, leading to strange crashes and weird
2804 inconsistencies when calling, e.g., inline methods.
2806 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
2807 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2808 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2809 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
2810 (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
2811 (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
2812 (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
2813 (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
2814 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2815 (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
2816 (TestWebKitAPI::TEST_F):
2818 2016-02-03 Konstantin Tokarev <annulen@yandex.ru>
2820 [webkitdirs] Clarify logic behind is{PortName} functions.
2821 https://bugs.webkit.org/show_bug.cgi?id=153554
2823 Reviewed by Michael Catanzaro.
2825 * Scripts/webkitdirs.pm:
2826 (prohibitUnknownPort): This function makes determinePortName()
2828 (determinePortName): Added new function which decides which port are
2829 we building based on command line switches and platform defaults.
2830 (portName): Added getter for determined $portName.
2831 (isEfl): Modified to use portName().
2833 (isWinCairo): Ditto.
2834 (isAppleMacWebKit): Ditto.
2835 (isAppleWinWebKit): Ditto.
2836 (isIOSWebKit): Ditto.
2837 (cmakeBasedPortName): Return portName() with capitalized first letter.
2838 (determineIsEfl): Deleted.
2839 (determineIsGtk): Deleted.
2840 (determineIsWinCairo): Deleted.
2842 * Scripts/build-jsc: Call prohibitUnknownPort().
2843 * Scripts/run-minibrowser: Ditto.
2844 * Scripts/webkitperl/FeatureList.pm: Ditto.
2845 * Scripts/update-webkit: Call determinePortName() instead of
2846 determineIsWinCairo().
2848 2016-02-02 Dan Bernstein <mitz@apple.com>
2850 Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
2851 https://bugs.webkit.org/show_bug.cgi?id=153683
2853 Reviewed by Darin Adler.
2855 * Scripts/webkitpy/port/driver.py:
2856 (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
2857 used by any code in the Web Content process. If that ever changed, we should send it over
2858 as a bundle parameter.
2860 * Scripts/webkitpy/port/ios.py:
2861 (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
2863 * Scripts/webkitpy/port/mac.py:
2864 (MacPort.setup_environ_for_server): Ditto.
2866 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2867 (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
2868 environment. This is early enough that libxml2 has not been initialized yet.
2870 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2871 (WTR::InjectedBundle::platformInitialize): Ditto.
2873 2016-02-02 Dan Bernstein <mitz@apple.com>
2875 Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
2876 https://bugs.webkit.org/show_bug.cgi?id=153683
2878 Reviewed by Alexey Proskuryakov.
2880 Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
2882 * Scripts/webkitpy/port/driver.py:
2883 (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
2884 * Scripts/webkitpy/port/ios.py:
2885 (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
2886 * Scripts/webkitpy/port/mac.py:
2887 (MacPort.setup_environ_for_server): Ditto.
2889 2016-01-29 Grzegorz Czajkowski <g.czajkowski@samsung.com>
2891 [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
2892 https://bugs.webkit.org/show_bug.cgi?id=153009
2894 Reviewed by Gyuyoung Kim.
2896 On mobile, virtual keyboard represented by ecore_imf module appears on
2897 the top of application layer usually covering bottom part of the screen.
2898 If the web page contains the editable content on the bottom of the page
2899 it will be overlapped by keyboard which prevents user from seeing the
2902 Pack MiniBrowser layout into conformant widget to allow EFL to guess
2903 the space that will be required by the keyboard, finally resizing it
2904 to the desired size. As a result, webview gets resized and scrolled
2905 into focused elements which makes the editable elements visible while
2908 More details about elm_conformant widger can be found at:
2909 https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
2910 https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
2912 * MiniBrowser/efl/main.c:
2913 (window_create): pack a box into conformant widget.
2915 2016-02-02 Alejandro G. Castro <alex@igalia.com>
2917 [GTK][EFL] Upgrade OpenWebRTC dependency
2918 https://bugs.webkit.org/show_bug.cgi?id=153489
2920 Reviewed by Philippe Normand.
2922 * Scripts/run-gtk-tests:
2923 (TestRunner): Avoid running the mediastream API test.
2924 * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
2925 default for gtk and efl.
2926 * gtk/jhbuild-webrtc.modules: Added modules files with
2927 dependencies required to compile and test the mediastream.
2929 2016-02-01 Jason Marcell <jmarcell@apple.com>
2931 Add code to parse the git branches out of the Trac RSS feed
2932 https://bugs.webkit.org/show_bug.cgi?id=153624
2934 Reviewed by Daniel Bates.
2936 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2937 (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
2938 (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
2939 "branches" and updated the code to work with an array instead of a string.
2940 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2941 (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
2942 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
2943 fixture that contains XML with a Git branch.
2944 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
2945 branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
2947 2016-02-01 Brady Eidson <beidson@apple.com>
2949 Add command line flag to DRT to output the number of tests completed in server mode.
2950 https://bugs.webkit.org/show_bug.cgi?id=153750
2952 Reviewed by Darin Adler.
2954 * DumpRenderTree/mac/DumpRenderTree.mm:
2955 (initializeGlobalsFromCommandLineOptions):
2956 (runTestingServerLoop):
2958 2016-02-01 Jason Marcell <jmarcell@apple.com>
2960 Improvements to botwatcher's dashboard unit tests.
2961 https://bugs.webkit.org/show_bug.cgi?id=153621
2963 Reviewed by Darin Adler.
2965 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2966 (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
2967 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2968 (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
2969 _popoverLinesForCommitRange have to traverse commits from different branches.
2970 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
2971 in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
2972 _revisionContentWithPopoverForIteration.
2974 2016-02-01 Jason Marcell <jmarcell@apple.com>
2976 Refactor to add event listeners and start periodic updates for all trac instances.
2977 https://bugs.webkit.org/show_bug.cgi?id=153609
2979 Reviewed by Darin Adler.
2981 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2982 (BuildbotQueueView): Adding event listeners for all trac instances.
2983 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
2984 for all trac instances.
2986 2016-01-31 Darin Adler <darin@apple.com>
2988 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
2989 https://bugs.webkit.org/show_bug.cgi?id=153639
2991 Reviewed by Filip Pizlo.
2993 * Scripts/do-webcore-rename: Use script to do this rename.
2995 2016-01-30 Commit Queue <commit-queue@webkit.org>
2997 Unreviewed, rolling out r195911.
2998 https://bugs.webkit.org/show_bug.cgi?id=153723
3000 Caused frequent assertion failures on bots (Requested by ap on
3005 "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
3006 https://bugs.webkit.org/show_bug.cgi?id=153639
3007 http://trac.webkit.org/changeset/195911
3009 2016-01-30 Darin Adler <darin@apple.com>
3011 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
3012 https://bugs.webkit.org/show_bug.cgi?id=153639
3014 Reviewed by Filip Pizlo.
3016 * Scripts/do-webcore-rename: Use script to do this rename.
3018 2016-01-30 Ryosuke Niwa <rniwa@webkit.org>
3020 TouchList should be retargeted
3021 https://bugs.webkit.org/show_bug.cgi?id=149592
3023 Reviewed by Antti Koivisto.
3025 Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
3026 multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
3028 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
3029 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3030 (WTR::UIScriptController::touchDownAtPoint): Added.
3031 (WTR::UIScriptController::liftUpAtPoint): Added.
3032 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3033 * WebKitTestRunner/ios/HIDEventGenerator.h:
3034 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3035 (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
3036 (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
3037 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3038 (WTR::UIScriptController::touchDownAtPoint): Added.
3039 (WTR::UIScriptController::liftUpAtPoint): Added.
3041 2016-01-30 Yusuke Suzuki <utatane.tea@gmail.com>
3043 Enable SamplingProfiler on POSIX environment
3044 https://bugs.webkit.org/show_bug.cgi?id=153584
3046 Reviewed by Michael Saboff.
3048 * Scripts/run-jsc-stress-tests:
3050 2016-01-29 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
3052 update-webkit-dependency fails to fetch updates through firewall on Windows
3053 https://bugs.webkit.org/show_bug.cgi?id=153619
3055 Reviewed by Myles C. Maxfield.
3057 On Windows, when a firewall is present we need to read proxy settings
3058 from environment variables.
3060 This patch relies on the following environment variables being set:
3064 * Scripts/update-webkit-dependency:
3066 2016-01-28 Dan Bernstein <mitz@apple.com>
3068 [Cocoa] Use the non-Development variants of XPC services for development
3069 https://bugs.webkit.org/show_bug.cgi?id=152545
3071 Reviewed by Darin Adler.
3073 * Scripts/webkitdirs.pm:
3074 (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
3076 * Scripts/webkitpy/port/driver.py:
3077 (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
3078 set in the XPC services as well.
3080 * Scripts/webkitpy/port/ios.py:
3081 (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
3082 Guard Malloc are enabled in XPC services as well.
3084 * Scripts/webkitpy/port/mac.py:
3085 (MacPort.setup_environ_for_server): Ditto.
3087 2016-01-28 Csaba Osztrogonác <ossy@webkit.org>
3089 Unreviewed buildfix after r195743.
3091 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3092 (WTR::AccessibilityUIElement::isPressActionSupported):
3094 2016-01-12 Jer Noble <jer.noble@apple.com>
3096 Custom protocol loading through AVFoundation does not support byte-range requests.
3097 https://bugs.webkit.org/show_bug.cgi?id=152919
3098 <rdar://problem/23664657>
3100 Reviewed by Alex Christensen.
3102 Add tests for new ParsedContntRange class.
3104 * TestWebKitAPI/PlatformWin.cmake:
3105 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3106 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3107 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3108 * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
3109 (TestWebKitAPI::TEST):
3111 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
3113 Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
3114 https://bugs.webkit.org/show_bug.cgi?id=153594
3116 Reviewed by Alex Christensen.
3118 * Scripts/webkitdirs.pm:
3119 (determineNumberOfCPUs):
3123 (wrapperPrefixIfNeeded):
3124 (cmakeGeneratedBuildfile):
3125 (generateBuildSystemFromCMakeProject):
3126 * Scripts/webkitperl/features.pm:
3127 (libraryContainsSymbol):
3129 2016-01-28 Chris Dumez <cdumez@apple.com>
3131 Unreviewed, rolling out r195742.
3137 "[webkitdirs] Clarify logic behind is{PortName} functions."
3138 https://bugs.webkit.org/show_bug.cgi?id=153554
3139 http://trac.webkit.org/changeset/195742
3141 2016-01-28 Darin Adler <darin@apple.com>
3143 Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
3144 https://bugs.webkit.org/show_bug.cgi?id=153411
3146 Reviewed by Ryosuke Niwa.
3148 * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
3149 have removed the function instead.
3151 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3152 (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
3153 added overloads for const char*.
3155 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3156 (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
3157 (WTR::AccessibilityUIElement::hasPopup): Ditto.
3158 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
3159 (WTR::testPathFromURL): Ditto.
3161 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
3163 [webkitdirs] Clarify logic behind is{PortName} functions.
3164 https://bugs.webkit.org/show_bug.cgi?id=153554
3166 Reviewed by Darin Adler.
3168 * Scripts/webkitdirs.pm:
3169 (determinePortName): Added new function which decides which port are
3170 we building based on command line switches and platform defaults.
3171 (portName): Added getter for determined $portName.
3172 (isEfl): Modified to use portName().
3174 (isWinCairo): Ditto.
3175 (isAppleMacWebKit): Ditto.
3176 (isAppleWinWebKit): Ditto.
3177 (isIOSWebKit): Ditto.
3178 (cmakeBasedPortName): Code replaced with portName() call.
3179 (determineIsEfl): Deleted.
3180 (determineIsGtk): Deleted.
3181 (determineIsWinCairo): Deleted.
3183 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
3185 [webkitdirs] Don't pass cmakeBasedPortName around.
3186 https://bugs.webkit.org/show_bug.cgi?id=153589
3188 Reviewed by Darin Adler.
3190 It should be local function of webkitdirs.pm instead.
3192 * Scripts/build-jsc: Don't pass cmakeBasedPortName to
3193 buildCMakeProjectOrExit().
3194 * Scripts/build-webkit: Don't pass cmakeBasedPortName to
3195 buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
3196 * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
3197 generateBuildSystemFromCMakeProject().
3198 * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
3199 (generateBuildSystemFromCMakeProject): Removed $port argument as we
3200 can get it from cmakeBasedPortName().
3201 (buildCMakeProjectOrExit): Ditto.
3203 2016-01-28 Gwang Yoon Hwang <yoon@igalia.com>
3205 [GStreamer] Clean up includes and headers related with GStreamerGL
3206 https://bugs.webkit.org/show_bug.cgi?id=153590
3208 Reviewed by Philippe Normand.
3210 * Scripts/webkitpy/style/checker.py: Skips
3211 include_order check for MediaPlayerPrivateGStreamerBase.cpp
3212 Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
3214 2016-01-27 Krzysztof Czech <k.czech@samsung.com>
3216 [EFL] Remove unused accessibility related code
3217 https://bugs.webkit.org/show_bug.cgi?id=153543
3219 Reviewed by Darin Adler.
3221 Removed reference to EAIL library.
3222 It not going to be support anymore. There have been changes in
3223 EFL/Elementary in terms of the accessibility and we should
3226 * efl/jhbuild-optional.modules:
3228 2016-01-27 Daniel Bates <dabates@apple.com>
3230 Remove WebKitSystemInterface for iOS SDK < 9
3231 https://bugs.webkit.org/show_bug.cgi?id=153570
3233 Reviewed by Andy Estes.
3235 * Scripts/copy-webkitlibraries-to-product-directory:
3237 2016-01-27 Jason Marcell <jmarcell@apple.com>
3239 Fix bugs caused by incorrect usage of "branch" vs. "branchName".
3240 https://bugs.webkit.org/show_bug.cgi?id=153330
3242 Reviewed by Daniel Bates.
3244 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
3245 "branchName" implies that the variable or property in question is simply a string. We fixed some
3246 inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
3247 spotted in BuildbotQueueView.js.
3249 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3250 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
3251 Changed branchName to branch.name in call to commitsOnBranch.
3252 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
3253 _popoverLinesForCommitRange.
3254 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
3255 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
3256 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
3259 2016-01-27 Ryosuke Niwa <rniwa@webkit.org>
3261 Add API to access closed shadowRoot in InjectedBundle
3262 https://bugs.webkit.org/show_bug.cgi?id=153533
3264 Reviewed by Antti Koivisto.
3266 Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
3268 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3269 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
3270 (TestWebKitAPI::runJavaScriptAlert):
3271 (TestWebKitAPI::TEST):
3272 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
3273 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
3274 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
3276 2016-01-27 Jason Marcell <jmarcell@apple.com>
3278 Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
3279 https://bugs.webkit.org/show_bug.cgi?id=153332
3281 Reviewed by Alexey Proskuryakov.
3283 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3284 (Trac.prototype._xmlTimelineURL): Uses new function.
3285 (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
3286 logic for parsing git hashes.
3287 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
3288 Trac._parseRevisionFromURL.
3290 2016-01-27 Alexey Proskuryakov <ap@apple.com>
3292 Remove Mavericks from the flakiness dashboard
3293 https://bugs.webkit.org/show_bug.cgi?id=153521
3295 Reviewed by Dan Bernstein.
3297 * TestResultServer/static-dashboards/builders.jsonp:
3298 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3300 2016-01-27 Alexey Proskuryakov <ap@apple.com>
3302 Remove ENABLE_CURRENTSRC
3303 https://bugs.webkit.org/show_bug.cgi?id=153545
3305 Reviewed by Simon Fraser.
3307 * Scripts/webkitperl/FeatureList.pm:
3309 2016-01-26 Jason Marcell <jmarcell@apple.com>
3311 Sort incoming commits via date instead of revision number.
3312 https://bugs.webkit.org/show_bug.cgi?id=153467
3314 Reviewed by Alexey Proskuryakov.
3316 Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
3317 for sorting revisions. Instead we use the commit date to sort revisions chronologically.
3319 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3320 (Trac.prototype._loaded): Sort via date instead of revision number.
3321 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
3322 (MockTrac): Fix up the mock data to look more like real-world data.
3323 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
3324 Fake RSS feed that adds three more commits.
3325 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
3328 2016-01-26 I-Ting Liu <iting_liu@apple.com>
3330 Add a test for WebKit::stringMatchesWildcardString.
3331 https://bugs.webkit.org/show_bug.cgi?id=153090
3333 Reviewed by Darin Adler.
3335 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3336 Add the file to the project.
3338 * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
3339 (TestWebKitAPI::TEST):
3340 Test that a string matches another string that may contain wildcard characters.
3342 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
3344 [webkitdirs] Removed check for bison, gperf, and flex.
3345 https://bugs.webkit.org/show_bug.cgi?id=153496
3347 Reviewed by Alex Christensen.
3349 This prerequisites are checked in WebKitCommon.cmake and don't
3350 have to be in $PATH.
3352 * Scripts/webkitdirs.pm:
3353 (checkRequiredSystemConfig):
3355 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
3357 [webkitdirs] isCMakeBuild should be true by default
3358 https://bugs.webkit.org/show_bug.cgi?id=153497
3360 Reviewed by Michael Catanzaro.
3362 * Scripts/webkitdirs.pm:
3365 2016-01-26 Daniel Bates <dabates@apple.com>
3367 Add WebKitSystemInterface for iOS 9.2
3368 https://bugs.webkit.org/show_bug.cgi?id=153355
3370 Rubber-stamped by David Kilzer.
3372 * Scripts/copy-webkitlibraries-to-product-directory:
3374 2016-01-26 Daniel Bates <dabates@apple.com>
3376 WebKitTestRunner: Credential cache is not cleared between tests
3377 https://bugs.webkit.org/show_bug.cgi?id=153407
3378 <rdar://problem/24280834>
3380 Reviewed by Alexey Proskuryakov.
3382 * WebKitTestRunner/TestController.cpp:
3383 (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
3384 to clear cached credentials.
3386 2016-01-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
3388 kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
3389 https://bugs.webkit.org/show_bug.cgi?id=153483
3391 Reviewed by Csaba Osztrogonác.
3393 * BuildSlaveSupport/kill-old-processes:
3394 (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
3396 2016-01-25 Simon Fraser <simon.fraser@apple.com>
3398 Give the layout test results file a <title> showing the date and time the tests were run
3399 https://bugs.webkit.org/show_bug.cgi?id=153187
3401 Reviewed by Darin Adler.
3403 Include a 'date' property in the JSON with the date and time the tests completed.
3405 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3406 (summarize_results):
3408 2016-01-25 Commit Queue <commit-queue@webkit.org>
3410 Unreviewed, rolling out r195543.
3411 https://bugs.webkit.org/show_bug.cgi?id=153451
3413 regressed performance of test bots by ~6% (Requested by dydz
3418 "WebKitTestRunner: Credential cache is not cleared between
3420 https://bugs.webkit.org/show_bug.cgi?id=153407
3421 http://trac.webkit.org/changeset/195543
3423 2016-01-25 Aakash Jain <aakash_jain@apple.com>
3425 Failing to upload to flakiness dashboard should not be a hard error
3426 https://bugs.webkit.org/show_bug.cgi?id=153444
3427 <rdar://problem/22146294>
3429 Reviewed by Alexey Proskuryakov.
3431 * Scripts/webkitpy/layout_tests/controllers/manager.py:
3432 (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
3434 2016-01-25 Daniel Bates <dabates@apple.com>
3436 WebKitTestRunner: Credential cache is not cleared between tests
3437 https://bugs.webkit.org/show_bug.cgi?id=153407
3438 <rdar://problem/24280834>
3440 Reviewed by Brady Eidson.
3442 * WebKitTestRunner/TestController.cpp:
3443 (WTR::TestController::resetStateToConsistentValues): Reset testing network session
3444 to clear cached credentials.
3446 2016-01-24 Dan Bernstein <mitz@apple.com>
3448 Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
3450 * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
3452 2016-01-22 Enrica Casucci <enrica@apple.com>
3454 Unreviewed build fix after http://trac.webkit.org/changeset/195474.
3456 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3457 (WTR::TestController::platformCreateWebView):
3459 2016-01-22 Tim Horton <timothy_horton@apple.com>
3461 Add a test for iOS arrow-key repeat
3462 https://bugs.webkit.org/show_bug.cgi?id=152857
3463 <rdar://problem/24017380>
3465 Reviewed by Darin Adler.
3467 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
3468 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3469 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
3470 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
3471 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3472 * WebKitTestRunner/ios/HIDEventGenerator.h:
3473 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3474 (-[HIDEventGenerator keyPress:completionBlock:]):
3475 (-[HIDEventGenerator keyDown:completionBlock:]):
3476 (-[HIDEventGenerator keyUp:completionBlock:]):
3477 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3478 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
3479 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
3480 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
3481 Make it possible to independently send keyUp/keyDown, instead of just paired.
3483 2016-01-22 Tim Horton <timothy_horton@apple.com>
3485 Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
3486 https://bugs.webkit.org/show_bug.cgi?id=153193
3487 <rdar://problem/24222034>
3489 Reviewed by Darin Adler.
3491 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3492 (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
3494 Add a test that exhibits the problems we're fixing here.
3495 Before, it would both log and assert in debug, and crash in release.
3496 Now it runs happily to completion.
3498 2016-01-22 Enrica Casucci <enrica@apple.com>
3500 Add support for testing data detection.
3501 https://bugs.webkit.org/show_bug.cgi?id=153360
3503 Reviewed by Tim Horton.
3505 Adding a new testing option (useDataDetection) to turn on
3506 data detection when running the a test.
3508 * WebKitTestRunner/TestController.cpp:
3509 (WTR::updateTestOptionsFromTestHeader):
3510 * WebKitTestRunner/TestOptions.h:
3511 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3512 (WTR::TestController::platformCreateWebView):
3514 2016-01-21 Simon Fraser <simon.fraser@apple.com>
3516 Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
3517 https://bugs.webkit.org/show_bug.cgi?id=153334
3519 Reviewed by Zalan Bujtas.
3521 Evaluating expressions in the LayoutUnit summary provider seems to cause
3522 re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
3525 * lldb/lldb_webkit.py:
3526 (WebCoreLayoutUnitProvider.to_string):
3528 2016-01-21 Filip Pizlo <fpizlo@apple.com>
3530 display-profiler-output should be able to display code blocks sorted by machine counts
3531 https://bugs.webkit.org/show_bug.cgi?id=153298
3533 Reviewed by Oliver Hunt.
3535 * Scripts/display-profiler-output:
3537 2016-01-21 Julien Isorce <j.isorce@samsung.com>
3539 Ensure to use compatible liborc version with wanted gstreamer version
3540 https://bugs.webkit.org/show_bug.cgi?id=153276
3542 For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
3543 The user may have a very recent liborc installed on his system.
3545 Reviewed by Philippe Normand.
3547 * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
3548 * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
3550 2016-01-21 Nan Wang <n_wang@apple.com>
3552 AX: [IOS] Implement next/previous text marker functions using TextIterator
3553 https://bugs.webkit.org/show_bug.cgi?id=153292
3554 <rdar://problem/24268243>
3556 Reviewed by Chris Fleizach.
3558 Made text marker tests available on iOS.
3560 * DumpRenderTree/AccessibilityTextMarker.h:
3561 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3562 * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
3563 (AccessibilityTextMarker::AccessibilityTextMarker):
3564 (AccessibilityTextMarker::~AccessibilityTextMarker):
3565 (AccessibilityTextMarker::isEqual):
3566 (AccessibilityTextMarker::platformTextMarker):
3567 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3568 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3569 (AccessibilityTextMarkerRange::isEqual):
3570 (AccessibilityTextMarkerRange::platformTextMarkerRange):
3571 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3572 (AccessibilityUIElement::pathDescription):
3573 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3574 (AccessibilityUIElement::textMarkerRangeForElement):
3575 (AccessibilityUIElement::selectedTextMarkerRange):
3576 (AccessibilityUIElement::resetSelectedTextMarkerRange):
3577 (AccessibilityUIElement::textMarkerRangeLength):
3578 (AccessibilityUIElement::textMarkerRangeForMarkers):
3579 (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3580 (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3581 (AccessibilityUIElement::accessibilityElementForTextMarker):
3582 (AccessibilityUIElement::endTextMarkerForBounds):
3583 (AccessibilityUIElement::startTextMarkerForBounds):
3584 (AccessibilityUIElement::textMarkerForPoint):
3585 (AccessibilityUIElement::previousTextMarker):
3586 (AccessibilityUIElement::nextTextMarker):
3587 (AccessibilityUIElement::stringForTextMarkerRange):
3588 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3589 (AccessibilityUIElement::indexForTextMarker):
3590 (AccessibilityUIElement::isTextMarkerValid):
3591 (AccessibilityUIElement::textMarkerForIndex):
3592 (AccessibilityUIElement::startTextMarker):
3593 (AccessibilityUIElement::endTextMarker):
3594 (AccessibilityUIElement::setSelectedVisibleTextRange):
3595 (AccessibilityUIElement::getLinkedUIElements):
3596 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3597 (AccessibilityTextMarkerRange::platformTextMarkerRange):
3598 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3599 (AccessibilityUIElement::removeSelection):
3600 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3601 (AccessibilityUIElement::setSelectedVisibleTextRange):
3602 (AccessibilityUIElement::supportedActions):
3603 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3604 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3605 (WTR::AccessibilityUIElement::textMarkerRangeLength):
3606 (WTR::AccessibilityUIElement::previousTextMarker):
3607 (WTR::AccessibilityUIElement::nextTextMarker):
3608 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3609 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3610 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3611 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3612 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3613 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3614 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3616 2016-01-20 Filip Pizlo <fpizlo@apple.com>
3618 Unreviewed, revert accidental unreviewed commit.
3620 * Scripts/display-profiler-output:
3622 2016-01-20 Jason Marcell <jmarcell@apple.com>
3624 Refactor compareIterations to remove duplicate code.
3625 https://bugs.webkit.org/show_bug.cgi?id=152913
3627 Reviewed by Daniel Bates.
3629 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3630 (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
3631 (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
3632 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
3633 the same behavior before and after refactor.
3635 2016-01-20 Dana Burkart <dburkart@apple.com>
3637 Botwatcher's dashboard should show an 'X' when the build is broken
3638 https://bugs.webkit.org/show_bug.cgi?id=152507
3640 Reviewed by David Kilzer.
3642 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
3643 (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
3644 (BuildbotStaticAnalyzerQueueView.prototype.update):
3646 2016-01-19 Jason Marcell <jmarcell@apple.com>
3648 Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
3649 https://bugs.webkit.org/show_bug.cgi?id=153262
3651 Reviewed by Alexey Proskuryakov.
3653 Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
3654 such cases this revisionContentForIteration method does not have any content to return, thus the
3657 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3658 (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
3660 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
3662 [GTK] Runtime critical warnings when loading a URL after a session restore
3663 https://bugs.webkit.org/show_bug.cgi?id=153233
3665 Reviewed by Michael Catanzaro.
3669 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
3671 (testWebKitWebViewNavigationAfterSessionRestore):
3674 2016-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
3676 [GTK] Remove jhbuild-optional.modules
3677 https://bugs.webkit.org/show_bug.cgi?id=152964
3679 Reviewed by Alex Christensen.
3681 * gtk/jhbuild-optional.modules: Removed.
3682 * gtk/jhbuild.modules:
3684 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
3686 [GTK] Add support to load/save session in MiniBrowser
3687 https://bugs.webkit.org/show_bug.cgi?id=153201
3689 Reviewed by Michael Catanzaro.
3691 It makes it easier to test the new WebView session API.
3693 * MiniBrowser/gtk/BrowserWindow.c:
3694 (browserWindowFinalize): Free the session file path.
3695 (browserWindowSaveSession): Save the current WebView session if
3696 there's a session file path.
3697 (browserWindowDeleteEvent): Call browserWindowSaveSession().
3698 (browser_window_load_session): Try to load the session from the
3699 given file path, otherwise fall back to homepage and keep the
3700 session file to save the session on window close.
3701 * MiniBrowser/gtk/BrowserWindow.h:
3702 * MiniBrowser/gtk/main.c:
3703 (createBrowserWindow): Pass the given session file path when
3704 shouldLoadSession is TRUE.
3705 (main): Only allow to restore/save session when MiniBrowser is
3706 launched without URL arguments.
3708 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
3710 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
3712 Geolocation is no longer allowed for unique origins after r195075.
3714 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3715 (testWebViewGeolocationPermissionRequests):
3717 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
3719 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
3720 https://bugs.webkit.org/show_bug.cgi?id=153216
3722 Reviewed by Michael Catanzaro.
3724 * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
3725 (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
3727 2016-01-18 Nan Wang <n_wang@apple.com>