f19bb75801c3c46d9e646a6fe94e5e1b427af191
[WebKit.git] / Tools / ChangeLog
1 2011-01-22  Robert Hogan  <robert@webkit.org>
2
3         Reviewed by Andreas Kling.
4
5         [Qt] Support layoutTestController.addURLToRedirect()
6         https://bugs.webkit.org/show_bug.cgi?id=52956
7
8         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
9         (LayoutTestController::addURLToRedirect):
10         * DumpRenderTree/qt/LayoutTestControllerQt.h:
11
12 2011-01-22  Robert Hogan  <robert@webkit.org>
13
14         Reviewed by Kenneth Rohde Christiansen.
15
16         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
17         https://bugs.webkit.org/show_bug.cgi?id=49802
18
19         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
20         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
21         (WebCore::DumpRenderTree::open):
22
23 2011-01-21  Adam Barth  <abarth@webkit.org>
24
25         Reviewed by Maciej Stachowiak.
26
27         Disable mac_unittest.py that fails on some of the Mac bots
28         https://bugs.webkit.org/show_bug.cgi?id=52947
29
30         As noted in the comment, this test does not appear to be correct
31         because the function this test is testing returns different results
32         depending on which flavor of Mac the test is run on.  This patch
33         disable the test.  Hopefully we can re-enable the test once we've
34         probably insulated the test from its environment.
35
36         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
37
38 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
39
40         Reviewed by Mihai Parparita.
41
42         Fix bug introduced in r76322 that caused NRWT to not actually
43         read the Skipped files properly.
44
45         https://bugs.webkit.org/show_bug.cgi?id=52771
46
47         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
48         * Scripts/webkitpy/layout_tests/port/webkit.py:
49         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
50
51 2011-01-21  Sam Weinig  <sam@webkit.org>
52
53         Reviewed by Geoffrey Sean Garen and Mark Rowe.
54
55         WebKitTestRunner needs the HOME environment variable to be set.
56         <rdar://problem/8896573>
57
58         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
59         it exists.
60
61 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
62
63         Reviewed by Eric Seidel.
64
65         Suppress a few remaining integration tests so that none of the
66         layout_test unit tests ever read from the filesystem or launch
67         subprocesses that aren't part of the unit tests.
68
69         Also fix a minor bug in the printing unit tests that was
70         incorrectly relying on sys.argv.
71
72         https://bugs.webkit.org/show_bug.cgi?id=52863
73
74         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
75         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
76         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
77
78 2011-01-21  Darin Adler  <darin@apple.com>
79
80        Fix Mac build.
81
82         * MiniBrowser/mac/BrowserWindowController.m:
83         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
84
85 2011-01-20  Darin Adler  <darin@apple.com>
86
87         Reviewed by Dan Bernstein.
88
89         WebKit2: Implement showModalDialog
90         https://bugs.webkit.org/show_bug.cgi?id=52855
91
92         This fixes WebKitTestRunner to compile, but more work is probably
93         needed to get it to pass the tests.
94
95         * WebKitTestRunner/TestController.cpp:
96         (WTR::TestController::runModal): Added. Calls through to the
97         platform-specific version of runModal.
98         (WTR::TestController::createOtherPage): Changed to be a private
99         static member function so it can refer to runModal, which is
100         a private static member function.
101         (WTR::TestController::initialize): Pass 0 for the runModal
102         function since we don't need to run the main window modal.
103         I suspect this is wrong and will need to change.
104         * WebKitTestRunner/TestController.h: Added declarations for
105         the functions added above.
106         * WebKitTestRunner/mac/TestControllerMac.mm:
107         (WTR::TestController::runModal): Added. Untested implementation.
108         * WebKitTestRunner/qt/TestControllerQt.cpp:
109         (WTR::TestController::runModal): Added.
110         * WebKitTestRunner/win/TestControllerWin.cpp:
111         (WTR::TestController::runModal): Added.
112
113 2011-01-21  Eric Seidel  <eric@webkit.org>
114
115         Reviewed by Adam Barth.
116
117         Split Host object off from WebKitPatch for easier re-use
118         https://bugs.webkit.org/show_bug.cgi?id=52284
119
120         new-run-webkit-tests and other tools are eventually going to want one of these.
121         Basically you need to inherit from this class if you want to pretend to be a
122         self.tool object for Steps/Commands.
123
124         * Scripts/webkitpy/common/host.py: Added.
125         * Scripts/webkitpy/tool/main.py:
126
127 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
128
129         Reviewed by Adam Barth.
130
131         Disable the tests that start and stop the http server and web
132         server, so that we don't have to worry about port collisions on
133         the bots.
134
135         https://bugs.webkit.org/show_bug.cgi?id=52861
136
137         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
138
139 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
140
141         Reviewed by Eric Seidel.
142
143         nrwt: rewrite google_chrome_unittest to use mock filesystem.
144         
145         https://bugs.webkit.org/show_bug.cgi?id=52772
146         
147         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
148
149 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
150
151         Reviewed by Eric Siedel.
152
153         nrwt: clean up almost all remaining port references, remove
154         unnecessary import clauses. The only remaining references are
155         in places where a mock filesystem makes no sense or can't be
156         used, and in one routine in port/google_chrome_unittest that
157         I'll rewrite in a separate patch.
158
159         https://bugs.webkit.org/show_bug.cgi?id=52771
160
161         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
162         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
163         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
164         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
165         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
166         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
167         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
168         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
169         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
170         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
171         * Scripts/webkitpy/layout_tests/port/gtk.py:
172         * Scripts/webkitpy/layout_tests/port/mac.py:
173         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
174         * Scripts/webkitpy/layout_tests/port/qt.py:
175         * Scripts/webkitpy/layout_tests/port/webkit.py:
176         * Scripts/webkitpy/layout_tests/port/win.py:
177         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
178
179 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
180
181         Reviewed by Mihai Parparita.
182
183         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
184
185         https://bugs.webkit.org/show_bug.cgi?id=52762
186
187         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
188         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
189
190 2011-01-20  Tony Chang  <tony@chromium.org>
191
192         Reviewed by Ojan Vafai.
193
194         [chromium] fix the paths used for the rebaseline tool
195         https://bugs.webkit.org/show_bug.cgi?id=52857
196
197         Some of the bots were renamed so the path to grab the results zip
198         file has changed.
199
200         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
201
202 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
203
204         Reviewed by Tony Chang.
205
206         Fix bug introduced in r72688 / bug 52768 that broke the
207         generation of the output filename links in the results.html
208         output. Apparently none of the unit tests actually checked to
209         make sure the generated links were correct :(
210
211         https://bugs.webkit.org/show_bug.cgi?id=52854
212
213         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
214         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
215
216 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
217
218         Reviewed by Darin Adler.
219
220         https://bugs.webkit.org/show_bug.cgi?id=52849
221         Make window.print work with WebKit2
222
223         * MiniBrowser/mac/BrowserWindowController.m:
224         (-[BrowserWindowController awakeFromNib]):
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::createOtherPage):
227         (WTR::TestController::initialize):
228         Added zeroes to WKPageUIClient structures to avoid build failures.
229
230 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
231
232         Reviewed by Eric Seidel.
233
234         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
235
236         https://bugs.webkit.org/show_bug.cgi?id=52756
237
238         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
239         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
240         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
241         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
242         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
243         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
244
245 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
246
247         Reviewed by Antonio Gomes.
248
249         QtTestBrowser should have a seperate menu for Settings
250         https://bugs.webkit.org/show_bug.cgi?id=52817
251         
252         Added a new menu item named "Settings"
253         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
254
255         * QtTestBrowser/launcherwindow.cpp:
256         (LauncherWindow::createChrome):
257
258 2011-01-20  Sam Weinig  <sam@webkit.org>
259
260         Reviewed by John Sullivan.
261
262         Update update-webkit-localizable-strings with new path to WebKit.
263
264         * Scripts/update-webkit-localizable-strings:
265
266 2011-01-20  James Robinson  <jamesr@chromium.org>
267
268         Reviewed by Darin Fisher.
269
270         Implement mozilla's requestAnimationFrame API
271         https://bugs.webkit.org/show_bug.cgi?id=51218
272
273         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
274
275         * DumpRenderTree/chromium/WebViewHost.cpp:
276         (invokeScheduleComposite):
277         (WebViewHost::scheduleAnimation):
278         (WebViewHost::paintInvalidatedRegion):
279         * DumpRenderTree/chromium/WebViewHost.h:
280
281 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
282
283         Reviewed by Adam Roben.
284
285         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
286         https://bugs.webkit.org/show_bug.cgi?id=42327
287
288         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
289         for methods that take their normal arguments but also a JSContextRef.
290         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
291         for evaluateScriptInIsolatedWorld.
292         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
293         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
294         this call is for an isolated world.
295         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
296         (WTR::worldMap): Helper to create a world map.
297         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
298         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
299         added LayoutTestController API.
300         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
301
302 2011-01-19  Adam Roben  <aroben@apple.com>
303
304         Convert paths in environment variables back to msys-style inside commit-log-editor
305
306         When this script gets run from inside git commit, msys-style paths in the environment will
307         have been turned into Windows-style paths with forward slashes. This screws up functions
308         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
309         the paths back to msys-style before doing anything else.
310
311         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
312         using msysgit's Perl and multiple ChangeLogs have been edited
313
314         Reviewed by David Kilzer.
315
316         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
317         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
318         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
319
320 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
321
322         [Win] Unreviewed build fix after r76248.
323
324         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
325
326 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
327
328         Reviewed by Csaba Osztrogonác.
329
330         Refactoring of the custom allocation framework
331         https://bugs.webkit.org/show_bug.cgi?id=49897
332
333         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
334         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
335         equivalent macro implementation at the necessary places.
336 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
337
338         Unreviewed. 
339
340         Adding myself to committers.py.
341
342         * Scripts/webkitpy/common/config/committers.py:
343
344 2011-01-20  Adam Barth  <abarth@webkit.org>
345
346         Reviewed by Tony Chang.
347
348         Chromium builders don't delete unversioned directories when DEPS change
349         https://bugs.webkit.org/show_bug.cgi?id=52745
350
351         If we pass this option to gclient sync, gclient will delete directories
352         that are no longer part of DEPS instead of leaving them around to
353         confuse us later.  Apparently, the downstream buildbots use this option
354         already.
355
356         * Scripts/update-webkit-chromium:
357
358 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
359
360         Unreviewed, build fix - I pulled this patch in to fix an issue
361         revealed by r76195 running on some new bots). Also fix a couple
362         of other issues revealed in testing.
363
364         nrwt: remove fs refs from layout_package/json*
365
366         https://bugs.webkit.org/show_bug.cgi?id=52754
367
368         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
369         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
370         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
371         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
372         * Scripts/webkitpy/layout_tests/port/base.py:
373
374 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
375
376         Unreviewed, build fix.
377
378         Fix a couple of minor bugs discovered while bringing up new bots
379         for testing.
380
381         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
382         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
383
384 2011-01-19  James Robinson  <jamesr@chromium.org>
385
386         Unreviewed, rolling out r76194.
387         http://trac.webkit.org/changeset/76194
388         https://bugs.webkit.org/show_bug.cgi?id=51218
389
390         Caused mysterious compile failure on the chromium win
391         build.webkit.org bots
392
393         * DumpRenderTree/chromium/WebViewHost.cpp:
394         (WebViewHost::paintInvalidatedRegion):
395         * DumpRenderTree/chromium/WebViewHost.h:
396
397 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
398
399         Reviewed by Mihai Parparita.
400
401         remove fs refs from test_runner, dump_render_tree_thread
402
403         https://bugs.webkit.org/show_bug.cgi?id=52753
404
405         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
406         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
407         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
408         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
409
410 2011-01-19  James Robinson  <jamesr@chromium.org>
411
412         Reviewed by Darin Fisher.
413
414         Implement mozilla's requestAnimationFrame API
415         https://bugs.webkit.org/show_bug.cgi?id=51218
416
417         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
418
419         * DumpRenderTree/chromium/WebViewHost.cpp:
420         (invokeScheduleComposite):
421         (WebViewHost::scheduleAnimation):
422         (WebViewHost::paintInvalidatedRegion):
423         * DumpRenderTree/chromium/WebViewHost.h:
424
425 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
426
427         Unreviewed, build fix.
428
429         Fix a few incorrect "self._filesystem" references introduced in
430         r76184.
431
432         * Scripts/webkitpy/layout_tests/port/chromium.py:
433         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
434
435 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
436
437         Reviewed by Mihai Parparita.
438
439         add a .sep property, abspath(), isabs(), mtime(), and
440         open_text_file_for_writing() to filesystem modules. Some of
441         these properties are not needed in this patch but will be needed
442         in subsequent patches (I'm doing this to avoid having to track
443         multiple versions of a single file).
444
445         Also, change most of the port/* modules to use the filesystem
446         objects instead of referencing the filesystem directly.
447
448         https://bugs.webkit.org/show_bug.cgi?id=52748
449
450         * Scripts/webkitpy/common/system/filesystem.py:
451         * Scripts/webkitpy/common/system/filesystem_mock.py:
452         * Scripts/webkitpy/layout_tests/port/__init__.py:
453         * Scripts/webkitpy/layout_tests/port/base.py:
454         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
455         * Scripts/webkitpy/layout_tests/port/chromium.py:
456         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
457         * Scripts/webkitpy/layout_tests/port/config.py:
458         * Scripts/webkitpy/layout_tests/port/test.py:
459         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
460
461 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
462
463         Reviewed by Anders Carlsson.
464
465         If resetting between tests times out, treat it as a WebProcess crash
466         https://bugs.webkit.org/show_bug.cgi?id=52757
467
468         * WebKitTestRunner/TestController.cpp:
469         (WTR::TestController::runTest):
470
471 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
472
473         Reviewed by Darin Adler.
474
475         https://bugs.webkit.org/show_bug.cgi?id=52739
476         Make it possible for a WebKit2 client to print headers and footers
477
478         Added dummy implementations for new printing UIClient calls.
479
480         * MiniBrowser/mac/BrowserWindowController.m:
481         (-[BrowserWindowController awakeFromNib]):
482         * WebKitTestRunner/TestController.cpp:
483         (WTR::createOtherPage):
484         (WTR::TestController::initialize):
485
486 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
487
488         Reviewed by Ojan Vafai.
489
490         Change webkitpy/layout_tests/port/test.py to use the
491         in-memory filesystem for cleaner unit testing. This
492         change allows us to kill a lot of code that was
493         specific to the test port, at the cost of being a
494         little less clear about how things would work if
495         you didn't have a filesystem.
496
497         https://bugs.webkit.org/show_bug.cgi?id=52605
498
499         * Scripts/webkitpy/layout_tests/port/test.py:
500
501 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
502
503         Unreviewed, build fix.
504
505         Fix test failure caused by committing attachment 79368 instead
506         of attachment 79461 on bug 52604.
507
508         * Scripts/webkitpy/common/system/filesystem_mock.py:
509
510 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
511
512         Reviewed by Mihai Parparita.
513
514         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
515         unit testing. os.walk() is too much of a hassle to implement on
516         top of the in-memory mock filesystem and adding the necessary
517         interface to files_under() gives clients a cleaner API anyway
518         (for this particular usage model).
519
520         https://bugs.webkit.org/show_bug.cgi?id=52691
521
522         * Scripts/webkitpy/common/system/filesystem.py:
523         * Scripts/webkitpy/common/system/filesystem_mock.py:
524         * Scripts/webkitpy/layout_tests/port/test_files.py:
525         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
526
527 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
528
529         Reviewed by Tony Chang.
530
531         Change more modules in the layout-tests code to use the
532         filesystem wrapper for cleaner unit testing.
533
534         This patch also adds the glob() wrapper to the filesystem
535         abstraction.
536         
537         https://bugs.webkit.org/show_bug.cgi?id=52604
538
539         * Scripts/webkitpy/layout_tests/port/test_files.py:
540         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
541         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
542         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
543         * Scripts/webkitpy/common/system/filesystem.py:
544         * Scripts/webkitpy/common/system/filesystem_mock.py:
545
546 2011-01-19  Levi Weintraub  <leviw@chromium.org>
547
548         Unreviewed.
549
550         Updating my email addresses and irc nick.
551
552         * Scripts/webkitpy/common/config/committers.py:
553
554 2011-01-19  Tony Chang  <tony@chromium.org>
555
556         Reviewed by Mihai Parparita.
557
558         [chromium] [linux] if check-sys-deps fails, output the failure reason
559         https://bugs.webkit.org/show_bug.cgi?id=52671
560
561         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
562             error handler functions.
563         * Scripts/webkitpy/layout_tests/port/chromium.py:
564             output the error text from --check-sys-deps
565         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
566
567 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
568
569         Reviewed by Andreas Kling.
570
571         [Qt] QtTestBrowser crashes when closing if Facebook is opened
572         https://bugs.webkit.org/show_bug.cgi?id=52554
573         
574         QtNetworkAccessManager is created in a thread and set as
575         member variable in QWebPage. When the thread is destroyed
576         the object is still used. So fix will set the object to
577         NULL once the thread is destroyed.
578
579         * QtTestBrowser/launcherwindow.cpp:
580         (LauncherWindow::~LauncherWindow):
581
582 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
583
584         Rubber stamped by Csaba Osztrogonac
585
586         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
587
588 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
589
590         Reviewed by Tony Chang.
591
592         new-run-webkit-tests: add a --build-directory command line argument
593
594         Official Google Chrome builds use a non-standard build directory
595         location. This patch adds a --build-directory argument that
596         allows that location to be specified on the command line. Only
597         Chromium-based builds will use this flag for now, but anyone can
598         in the future.
599
600         There are no unit tests for this since it's difficult to test
601         until mock filesystems are fully supported in the code. This was
602         tested by hand for now.
603
604         https://bugs.webkit.org/show_bug.cgi?id=52694
605
606         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
607         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
608         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
609         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
610
611 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
612
613         Not reviewed. Bot fix.
614
615         Remove an inadvertently committed debugging print.
616
617         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
618         (LayoutTestController::notifyDone):
619
620 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
621
622         Reviewed by Sam Weinig.
623
624         WebKitTestRunner should track loading more like DumpRenderTree
625         https://bugs.webkit.org/show_bug.cgi?id=52692
626
627         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
628         This makes some tests that call notifyDone multiple times pass.
629         
630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
631         (WTR::InjectedBundle::InjectedBundle):
632         (WTR::InjectedBundle::done):
633         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
634         (WTR::InjectedBundle::topLoadingFrame):
635         (WTR::InjectedBundle::setTopLoadingFrame):
636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
637         (WTR::InjectedBundlePage::InjectedBundlePage):
638         (WTR::InjectedBundlePage::stopLoading):
639         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
640         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
641         (WTR::InjectedBundlePage::didFinishLoadForFrame):
642         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
643         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
644         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
645         (WTR::LayoutTestController::notifyDone):
646         * WebKitTestRunner/TestController.cpp:
647         (WTR::TestController::didReceiveMessageFromInjectedBundle):
648
649 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
650
651         Reviewed by Kent Tamura.
652
653         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
654         https://bugs.webkit.org/show_bug.cgi?id=52678
655         
656         Update path now that WebKit is inside Source.
657
658         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
659
660 2011-01-18  Robert Hogan  <robert@webkit.org>
661
662         Reviewed by Simon Hausmann.
663
664         [Qt] http/tests/incremental/slow-utf8-text.pl fails
665         https://bugs.webkit.org/show_bug.cgi?id=44282
666
667         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
668         (WebCore::DumpRenderTree::dump):
669
670 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
671
672         Reviewed by Mihai Parparita.
673
674         Fix a small race condition that could cause the unit tests for
675         new-run-webkit-tests to fail in a multithreaded environment.
676         There was a small window in the code where one thread would
677         check to see if a thread had raised an exception, do something,
678         and then check to see if the thread was alive. If the other
679         thread raised an exception and exited in between these two
680         steps, the exception would be lost. Flipping the order of the
681         two checks fixes the race, since we will now always check for an
682         exception on the thread before exiting.
683
684         https://bugs.webkit.org/show_bug.cgi?id=51579
685
686         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
687
688 2011-01-18  Eric Seidel  <eric@webkit.org>
689
690         Reviewed by Adam Barth.
691
692         commit-queue dies when test archiving fails
693         https://bugs.webkit.org/show_bug.cgi?id=52617
694
695         I looked at the machine and it had 10 archives already
696         thus find_unused_name was returning None.  I've upped
697         the limit to 100 (per bug) and tested the case where
698         find_unused_name returns None (making archive return None).
699
700         * Scripts/webkitpy/common/system/workspace.py:
701         * Scripts/webkitpy/common/system/workspace_unittest.py:
702         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
703         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
704         * Scripts/webkitpy/tool/commands/queues.py:
705
706 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
707
708         Reviewed by Ojan Vafai.
709
710         Update rebaseline-chromium-webkit-tests unit tests to use a mock
711         filesystem. Also fix a couple of "with" statements missed by
712         r76050.
713
714         https://bugs.webkit.org/show_bug.cgi?id=52487
715
716         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
717
718 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
719
720         Reviewed by Martin Robinson.
721
722         [Gtk] Build fixes for gtk3 build
723         https://bugs.webkit.org/show_bug.cgi?id=52648
724
725         * DumpRenderTree/gtk/EventSender.cpp:
726         (beginDragWithFilesCallback):
727
728 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
729
730         Reviewed by Mihai Parparita.
731
732         Update rebaseline-chromium-webkit-tests to use filesystem objects
733         instead of direct references to os.path, shutil, tempfile, etc.
734
735         This patch doesn't change anything, but will allow subsequent
736         patches to change the unit tests to no longer use the real
737         filesystem.
738
739         This patch adds a bunch more methods to the filesystem object as
740         well.
741
742         https://bugs.webkit.org/show_bug.cgi?id=52482
743
744         * Scripts/webkitpy/common/system/filesystem.py:
745         * Scripts/webkitpy/common/system/filesystem_mock.py:
746         * Scripts/webkitpy/tool/commands/queues.py:
747         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
748         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
749
750 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
751
752         Reviewed by Mihai Parparita.
753
754         new-run-webkit-tests shouldn't crash when you try to run a
755         directory containing only skipped files.
756
757         https://bugs.webkit.org/show_bug.cgi?id=52478
758         
759         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
760         * Scripts/webkitpy/layout_tests/port/test.py:
761         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
762
763 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
764
765         Reviewed by Gustavo Noronha Silva.
766
767         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
768         https://bugs.webkit.org/show_bug.cgi?id=40833
769
770         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
771         GTK+ event sender.
772         (dragWithFilesDragDataGetCallback): Added.
773         (dragWithFilesDragEndCallback): Added.
774         (beginDragWithFilesCallback): Added.
775
776 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
777
778         Reviewed by Adam Barth.
779
780         ews: Add additional watcher to efl ews
781         https://bugs.webkit.org/show_bug.cgi?id=52613
782
783         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
784
785         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
786
787 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
788
789         Reviewed by Alexey Proskuryakov.
790
791         Fix some headers with missing or misspelled #ifndef guards
792         https://bugs.webkit.org/show_bug.cgi?id=52545
793
794         * DumpRenderTree/chromium/TestEventPrinter.h:
795         * DumpRenderTree/chromium/WebPreferences.h:
796
797 2011-01-17  Jessie Berlin  <jberlin@apple.com>
798
799         Reviewed by Anders Carlsson.
800
801         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
802         navigating back to an unreachable URL
803         https://bugs.webkit.org/show_bug.cgi?id=52388
804
805         Add a third parameter (unreachableURL) to queueLoadHTMLString.
806
807         * DumpRenderTree/LayoutTestController.cpp:
808         (queueLoadHTMLStringCallback):
809         (LayoutTestController::queueLoadHTMLString):
810         (LayoutTestController::queueLoadAlternateHTMLString):
811         * DumpRenderTree/LayoutTestController.h:
812
813         * DumpRenderTree/WorkQueueItem.h:
814         (LoadHTMLStringItem::LoadHTMLStringItem):
815
816         * DumpRenderTree/chromium/LayoutTestController.cpp:
817         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
818         (WorkItemLoadHTMLString::run):
819         (LayoutTestController::queueLoadHTMLString):
820
821         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
822         (LoadHTMLStringItem::invoke):
823         * DumpRenderTree/mac/WorkQueueItemMac.mm:
824         (LoadHTMLStringItem::invoke):
825         * DumpRenderTree/win/WorkQueueItemWin.cpp:
826         (LoadHTMLStringItem::invoke):
827
828 2011-01-17  Dan Bernstein  <mitz@apple.com>
829
830         Rubber-stamped by Mark Rowe.
831
832         Update xcodeproj svn:ignore to include xcuserdata.
833
834         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
835         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
836         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
837         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
838         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
839
840 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
841
842         Unreviewed fix after r75908.
843
844         Move WebKit into Source
845         https://bugs.webkit.org/show_bug.cgi?id=52530
846
847         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
848
849 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
850
851         Unreviewed.
852
853         Remove accidentally committed debug printing after r75908.
854
855         * Scripts/webkitdirs.pm:
856
857 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
858
859         Unreviewed.
860
861         Add myself to committers list
862         https://bugs.webkit.org/show_bug.cgi?id=52566
863
864         * Scripts/webkitpy/common/config/committers.py:
865
866 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
867
868         Reviewed by Jeremy Orlow.
869
870         GeolocationController should call stopUpdating on destruction
871         https://bugs.webkit.org/show_bug.cgi?id=52216
872
873         fast/dom/Geolocation/window-close-crash.html requires that a
874         Geolocation watch be started in a secondary window. Consequently,
875         we need to allow geolocation permission and provide a mock
876         geolocation position for the secondary window's
877         GeolocationClientMock.
878
879         * DumpRenderTree/chromium/LayoutTestController.cpp:
880         (LayoutTestController::setGeolocationPermission):
881         (LayoutTestController::setMockGeolocationPosition):
882         (LayoutTestController::setMockGeolocationError):
883         * DumpRenderTree/chromium/TestShell.h:
884         (TestShell::windowList):
885
886 2011-01-16  Adam Barth  <abarth@webkit.org>
887
888         Update more include paths to reflect WebKit move.
889
890         * DumpRenderTree/chromium/EventSender.cpp:
891         (EventSender::keyDown):
892         (EventSender::needsShiftModifier):
893         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
894         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
895
896 2011-01-16  Kent Tamura  <tkent@chromium.org>
897
898         Unreviewed, Chromium build fix.
899
900         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
901
902 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
903
904         Build fix for GTK+ after source directory movement.
905
906         * GNUmakefile.am: Correct include paths.
907
908 2011-01-16  Adam Barth  <abarth@webkit.org>
909
910         Teach svn-apply about WebKit move.
911
912         * Scripts/VCSUtils.pm:
913
914 2011-01-16  Adam Barth  <abarth@webkit.org>
915
916         Rubber-stamped by Eric Seidel.
917
918         Move WebKit into Source
919         https://bugs.webkit.org/show_bug.cgi?id=52530
920
921         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
922         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
923         * DumpRenderTree/qt/DumpRenderTreeQt.h:
924         * DumpRenderTree/qt/GCControllerQt.cpp:
925         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
926         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
927         * DumpRenderTree/qt/TextInputControllerQt.cpp:
928         * DumpRenderTree/wscript:
929         * QtTestBrowser/launcherwindow.h:
930         * Scripts/build-webkit:
931         * Scripts/webkitdirs.pm:
932
933 2011-01-15  Adam Barth  <abarth@webkit.org>
934
935         Teach svn-apply about WebKit2 move.
936
937         * Scripts/VCSUtils.pm:
938
939 2011-01-15  Adam Barth  <abarth@webkit.org>
940
941         Rubber-stamped by Eric Seidel.
942
943         Move WebKit2 into Source
944         https://bugs.webkit.org/show_bug.cgi?id=52438
945
946         * MiniBrowser/qt/MiniBrowser.pro:
947         * Scripts/build-webkit:
948         * Scripts/do-file-rename:
949         * Scripts/do-webcore-rename:
950         * Scripts/test-webkitpy:
951         * Scripts/webkitdirs.pm:
952         * Scripts/webkitpy/style/checker.py:
953         * WebKitTestRunner/DerivedSources.pro:
954         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
955         * WebKitTestRunner/qt/WebKitTestRunner.pro:
956
957 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
958
959         Reviewed by David Levin.
960
961         [chromium] remove obsolete createView method
962         https://bugs.webkit.org/show_bug.cgi?id=52437
963
964         * DumpRenderTree/chromium/WebViewHost.cpp:
965         (WebViewHost::createView):
966         * DumpRenderTree/chromium/WebViewHost.h:
967
968 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
969
970         Reviewed by Geoff Garen.
971
972         ShouldLoadResourceForFrame should use strings, not URLs.
973         https://bugs.webkit.org/show_bug.cgi?id=52476
974
975         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
976         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
977         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
978
979 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
980
981         Reviewed by David Levin.
982
983         Add Tony Gentilcore as a reviewer
984         https://bugs.webkit.org/show_bug.cgi?id=52480
985
986         * Scripts/webkitpy/common/config/committers.py:
987
988 2011-01-14  David Levin  <levin@chromium.org>
989
990         Reviewed by Eric Seidel.
991
992         check-webkit-style: _FunctionState should keep track of where the function name starts.
993         https://bugs.webkit.org/show_bug.cgi?id=52454
994
995         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
996         _FunctionState and logic for setting it correctly.
997         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
998
999 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1000
1001         Reviewed by David Levin.
1002
1003         Add support to DumpRenderTree to use the GPU rather than software renderer
1004         https://bugs.webkit.org/show_bug.cgi?id=52333
1005
1006         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1007         (main):
1008         * Scripts/webkitpy/layout_tests/port/chromium.py:
1009         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1010
1011 2011-01-14  Tony Chang  <tony@chromium.org>
1012
1013         Reviewed by Kent Tamura.
1014
1015         [chromium] update fonts.conf to fix 6 linux tests in drt
1016         https://bugs.webkit.org/show_bug.cgi?id=52411
1017
1018         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1019             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1020
1021 2011-01-14  Eric Seidel  <eric@webkit.org>
1022
1023         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1024
1025         Reviewed by Adam Barth.
1026
1027         Fix when running Tools/Scripts/check-webkit-style without arguments.
1028         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1029
1030         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1031         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1032
1033 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1034
1035         Reviewed by David Levin.
1036
1037         Store the tempdir object in a variable so it doesn't get deleted too early.
1038         https://bugs.webkit.org/show_bug.cgi?id=51875
1039
1040         * Scripts/update-webkit-auxiliary-libs:
1041         * Scripts/update-webkit-support-libs:
1042
1043 2011-01-14  Eric Seidel  <eric@webkit.org>
1044
1045         Unreviewed.  Make it work in python 2.5.
1046
1047         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1048         https://bugs.webkit.org/show_bug.cgi?id=49158
1049
1050         * Scripts/webkitpy/common/checkout/api_unittest.py:
1051
1052 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1053
1054         Unreviewed, rolling out r75774.
1055         http://trac.webkit.org/changeset/75774
1056         https://bugs.webkit.org/show_bug.cgi?id=52431
1057
1058         gtk builds were broken (Requested by loislo2 on #webkit).
1059
1060         * Scripts/webkitpy/common/checkout/scm.py:
1061
1062 2011-01-14  David Levin  <levin@chromium.org>
1063
1064         Reviewed by Shinichiro Hamaji.
1065
1066         check-webkit-style: _FunctionState should detect pure functions.
1067         https://bugs.webkit.org/show_bug.cgi?id=52428
1068
1069         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1070         is a pure virtual function.
1071         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1072         virtual functions are correctly detected.
1073
1074 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1075
1076         Reviewed by Yury Semikhatsky.
1077
1078         Just small fix for problem with check-webkit-style.
1079         It just didn't work for this patch.
1080         Old code can't concatenate a list of strings with None.
1081
1082         * Scripts/webkitpy/common/checkout/scm.py:
1083
1084 2011-01-13  David Levin  <levin@chromium.org>
1085
1086         Reviewed by Shinichiro Hamaji.
1087
1088         check-webkit-style: _FunctionState should use Position to know where items are.
1089         https://bugs.webkit.org/show_bug.cgi?id=52424
1090
1091         * Scripts/webkitpy/style/checkers/cpp.py:
1092         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1093         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1094         did some minor clean-up.
1095         (*): Other changes are simply about converting to use the Position's in_FunctionState
1096         instead of line numbers.
1097         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1098         to verify the positions stored in _FunctionState.
1099
1100 2011-01-13  Eric Seidel  <eric@webkit.org>
1101
1102         Reviewed by David Levin.
1103
1104         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1105         https://bugs.webkit.org/show_bug.cgi?id=49158
1106
1107         This is not the most elegant, but it is a very safe fix to this bug.
1108         One advantage of catching ScriptError like this instead of adding a
1109         new added_or_modified_files or fixing all changed_files callers
1110         to use a more specific change_files variant, is that we catch
1111         all kinds of ScriptErrors which might cause our (non-essential)
1112         suggest-reviewers code to fail out.  This should make passing
1113         --suggest-reviewers to webkit-patch upload much more robust
1114         and may even make it possible for us to make it default.
1115
1116         The root of the problem here is that SCM.changed_files includes
1117         deleted ChangeLog paths (from moves, etc) which then when we ask
1118         SVN/Git for the contents of the file at that revision, the command
1119         errors out and Executive.run_command raises a ScriptError.
1120
1121         In the future we might fix this differently by making all current
1122         callers of chagned_files use a more specific method for requesting
1123         what types of changes they're interested in (adds, modifies, deletes, etc.)
1124
1125         * Scripts/webkitpy/common/checkout/api.py:
1126         * Scripts/webkitpy/common/checkout/api_unittest.py:
1127
1128 2011-01-13  Dan Bernstein  <mitz@apple.com>
1129
1130         Reviewed by Alexey Proskuryakov.
1131
1132         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1133         https://bugs.webkit.org/show_bug.cgi?id=52419
1134
1135         Allow to further control the behavior of the willSendRequest delegate callback by making it
1136         set a different URL in the new request.
1137
1138         * DumpRenderTree/LayoutTestController.cpp:
1139         (addURLToRedirectCallback): Added.
1140         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1141         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1142         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1143         * DumpRenderTree/LayoutTestController.h:
1144         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1145         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1146         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1147         change the URL in the new request to the redirect destination.
1148
1149 2011-01-13  Eric Seidel  <eric@webkit.org>
1150
1151         Reviewed by Mihai Parparita.
1152
1153         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1154         https://bugs.webkit.org/show_bug.cgi?id=52416
1155
1156         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1157         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1158
1159         I also added FIXMEs about the changed_files returning deleted files problem
1160         which is causing the other most common exception for suggest-reviewers
1161         (and is probably breaking sheriff-bots blame detection).
1162
1163         * Scripts/webkitpy/common/checkout/api.py:
1164         * Scripts/webkitpy/common/checkout/api_unittest.py:
1165         * Scripts/webkitpy/common/checkout/scm.py:
1166
1167 2011-01-13  Eric Seidel  <eric@webkit.org>
1168
1169         Reviewed by Adam Barth.
1170
1171         results archives from commit-queue are too large to upload
1172         https://bugs.webkit.org/show_bug.cgi?id=52405
1173
1174         * Scripts/webkitpy/common/system/filesystem.py:
1175         * Scripts/webkitpy/common/system/filesystem_mock.py:
1176         * Scripts/webkitpy/tool/commands/queues.py:
1177
1178 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1179
1180         Reviewed by Martin Robinson.
1181
1182         [gtk] Zero-sized font does not yet work
1183         https://bugs.webkit.org/show_bug.cgi?id=49793
1184
1185         Set minimum-font-size to 0 for the DRT.
1186
1187         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1188         (resetDefaultsToConsistentValues):
1189
1190 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1191
1192         Reviewed by Darin Adler.
1193
1194         Make old-run-webkit-tests more robust on buildbots
1195         https://bugs.webkit.org/show_bug.cgi?id=52364
1196
1197         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1198
1199 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1200
1201         Reviewed by Darin Adler.
1202
1203         Make old-run-webkit-tests more robust on buildbots
1204         https://bugs.webkit.org/show_bug.cgi?id=52364
1205
1206         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1207
1208 2011-01-13  Tony Chang  <tony@chromium.org>
1209
1210         Reviewed by Kent Tamura.
1211
1212         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1213         https://bugs.webkit.org/show_bug.cgi?id=52332
1214
1215         Forked Info.plist is not longer needed.
1216
1217         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1218
1219 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1220
1221         Reviewed by Timothy Hatcher.
1222
1223         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1224         to be passed directly to WebInspector.UIString
1225
1226         https://bugs.webkit.org/show_bug.cgi?id=52365
1227
1228         * Scripts/check-inspector-strings:
1229
1230 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1231
1232         Unreviewed, rolling out r74881.
1233         http://trac.webkit.org/changeset/74881
1234         https://bugs.webkit.org/show_bug.cgi?id=52357
1235
1236         The EFL builder has been red for days (Requested by abarth on
1237         #webkit).
1238
1239         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1240         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1241
1242 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1243
1244         Reviewed by David Levin.
1245
1246         Add beforeunload support to WebKitTestRunner
1247         https://bugs.webkit.org/show_bug.cgi?id=52353
1248         
1249         This makes a number of currently failing tests pass.
1250
1251         * WebKitTestRunner/TestController.cpp:
1252         (WTR::runBeforeUnloadConfirmPanel):
1253         (WTR::createOtherPage):
1254         (WTR::TestController::initialize):
1255
1256 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1257
1258         Reviewed by Sam Weinig.
1259
1260         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1261         https://bugs.webkit.org/show_bug.cgi?id=52330
1262
1263         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1264         a web process crash.
1265         * WebKitTestRunner/TestController.cpp:
1266         (WTR::TestController::initialize): Set up a processDidCrash
1267         callback.
1268         (WTR::TestController::processDidCrash): Report that the Web process
1269         crashed.
1270         * WebKitTestRunner/TestController.h:
1271
1272 2011-01-12  David Levin  <levin@chromium.org>
1273
1274         Reviewed by Shinichiro Hamaji.
1275
1276         check-webkit-style -- close_expression function doesn't work correctly.
1277         https://bugs.webkit.org/show_bug.cgi?id=52272
1278
1279         * Scripts/webkitpy/style/checkers/cpp.py:
1280         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1281         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1282         generally useful (for upcoming code changes).
1283         (close_expression): Changed to use Position for input and output.
1284         Also, fixed many bugs such as only working correctly for parenthesis,
1285         not working correctly if given an offset in a line and not finding
1286         the real closing element if there were multiple closing elements in
1287         the same line.
1288         (detect_functions): Adjusted due to the change in arguments for
1289         close_expression.
1290         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1291         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1292         two positions are the same.
1293         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1294         (CppStyleTest.test_close_expression): Added tests to catch the issues
1295         that were fixed.
1296
1297 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1298
1299         Unreviewed, rolling out r75576.
1300         http://trac.webkit.org/changeset/75576
1301         https://bugs.webkit.org/show_bug.cgi?id=52304
1302
1303         broke rebaseline-chromium-webkit-test (Requested by thakis on
1304         #webkit).
1305
1306         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1307         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1308         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1309         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1310         * Scripts/webkitpy/layout_tests/port/base.py:
1311         * Scripts/webkitpy/layout_tests/port/chromium.py:
1312         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1313         * Scripts/webkitpy/layout_tests/port/test.py:
1314         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1315         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1316         * Scripts/webkitpy/style/checkers/test_expectations.py:
1317         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1318
1319 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1320
1321         Reviewed by Darin Adler.
1322
1323         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1324         https://bugs.webkit.org/show_bug.cgi?id=52307
1325
1326         * Scripts/old-run-webkit-tests:
1327
1328 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1329
1330         Reviewed by Martin Robinson.
1331
1332         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1333         https://bugs.webkit.org/show_bug.cgi?id=50867
1334
1335         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1336         TestNetscapePlugin.cpp 
1337
1338         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1339         * Scripts/webkitdirs.pm:
1340
1341 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1342
1343         Reviewed by Pavel Feldman.
1344
1345         Add check-inspector-strings script.
1346
1347         https://bugs.webkit.org/show_bug.cgi?id=52295
1348
1349         * Scripts/check-inspector-strings: Added.
1350
1351 2011-01-12  Adam Roben  <aroben@apple.com>
1352
1353         Advertise the .testnetscape file extension on Windows
1354
1355         Fixes <http://webkit.org/b/52298>
1356         plugins/no-mime-with-valid-extension.html fails on Windows
1357
1358         Reviewed by Dan Bernstein.
1359
1360         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1361         FileExtents field to map the .testnetscape file extension to the
1362         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1363
1364 2011-01-12  Adam Barth  <abarth@webkit.org>
1365
1366         Reviewed by Eric Seidel.
1367
1368         Make webkit-patch support subdirectories for SVN checkouts
1369         https://bugs.webkit.org/show_bug.cgi?id=52261
1370
1371         os.relpath does not exist on Python 2.5, so we need to call our version
1372         of the API.
1373
1374         * Scripts/webkitpy/common/checkout/scm.py:
1375
1376 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1377
1378         Reviewed by Eric Seidel.
1379
1380         Close additional pages opened during a test once the test completes.
1381         https://bugs.webkit.org/show_bug.cgi?id=52276
1382
1383         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1384         (WTR::InjectedBundle::done):
1385
1386 2011-01-11  David Levin  <levin@chromium.org>
1387
1388         Reviewed by Eric Seidel.
1389
1390         Errors should be separated from the command line in bot messages.
1391         https://bugs.webkit.org/show_bug.cgi?id=52275
1392
1393         * Scripts/webkitpy/common/system/executive.py:
1394         (ScriptError.message_with_output): Added a newline to separate the command
1395         line from the errors.
1396         * Scripts/webkitpy/common/system/executive_unittest.py:
1397         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1398         paths in message_with_output.
1399
1400 2011-01-11  Eric Seidel  <eric@webkit.org>
1401
1402         Unreviewed.
1403
1404         commit-queue should know how to upload archived results (for test flakes or general failures)
1405         https://bugs.webkit.org/show_bug.cgi?id=52048
1406
1407         The zips are mostly empty due to forgetting -r.
1408         Expected diffs were not being pulled from the archive due
1409         to the archive having longer paths than I realized.
1410
1411         * Scripts/webkitpy/common/system/workspace.py:
1412         * Scripts/webkitpy/common/system/workspace_unittest.py:
1413         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1414         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1415
1416 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1417
1418         Reviewed by Ojan Vafai.
1419
1420         The current modifier parsing code in test_expectations is
1421         fragile and hard-coded, so it's not easy to understand the logic
1422         or easily add new types of modifiers (like GPU vs. CPU testing
1423         for graphics tests, or 32-bit vs. 64-bit differences).
1424
1425         This is the first of two patches that will add in more generic
1426         support and then eliminate the GPU-specific test expectations
1427         files for Chromium.
1428
1429         This patch adds two standalone objects for handling modifiers. The
1430         rules for interpreting modifiers, precedence, and conflicts are
1431         given in the docstring to the ModifierMatcher class, which
1432         returns ModifierMatchResult objects.
1433         
1434         This patch also adds routines to the Port interface and a
1435         default set of values in the base object, in order to obtain the
1436         values needed on a given test run. These values are then passed
1437         to the expectation parser. This also allows us to clean up the
1438         logic used to lint all of the different configurations in a
1439         single test_expectations.txt file.
1440
1441         The next patch will merge in the separate GPU expectations file.
1442
1443         https://bugs.webkit.org/show_bug.cgi?id=51222
1444
1445         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1446         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1447         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1448         * Scripts/webkitpy/layout_tests/port/base.py:
1449         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1450         * Scripts/webkitpy/layout_tests/port/chromium.py:
1451         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1452         * Scripts/webkitpy/layout_tests/port/test.py:
1453         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1454         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1455
1456 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1457
1458         Reviewed by Adam Barth.
1459
1460         Make webkit-patch support subdirectories for SVN checkouts
1461         https://bugs.webkit.org/show_bug.cgi?id=52261
1462
1463         * Scripts/webkitpy/common/checkout/scm.py:
1464         * Scripts/webkitpy/style_references.py:
1465         * Scripts/webkitpy/tool/main.py:
1466         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1467
1468 2011-01-11  Eric Seidel  <eric@webkit.org>
1469
1470         Unreviewed.
1471
1472         commit-queue should know how to upload archived results (for test flakes or general failures)
1473         https://bugs.webkit.org/show_bug.cgi?id=52048
1474
1475         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1476         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1477
1478         * Scripts/webkitpy/common/system/workspace.py:
1479         * Scripts/webkitpy/common/system/workspace_unittest.py:
1480         * Scripts/webkitpy/tool/commands/queues.py:
1481
1482 2011-01-11  Sam Weinig  <sam@webkit.org>
1483
1484         Roll r75474 back in.
1485
1486 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1487
1488         Reviewed by Kenneth Rohde Christiansen.
1489
1490         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1491         https://bugs.webkit.org/show_bug.cgi?id=51204
1492
1493         * QtTestBrowser/webpage.h:
1494         (QtNAMThread::QtNAMThread):
1495         (QtNAMThread::networkAccessManager):
1496         (QtNAMThread::run):
1497
1498 2011-01-11  Peter Varga  <pvarga@webkit.org>
1499
1500         Unreviewed.
1501
1502         Add myself to committers' list.
1503
1504         * Scripts/webkitpy/common/config/committers.py:
1505
1506 2011-01-11  Eric Seidel  <eric@webkit.org>
1507
1508         Reviewed by Adam Barth.
1509
1510         commit-queue should know how to upload archived results (for test flakes or general failures)
1511         https://bugs.webkit.org/show_bug.cgi?id=52048
1512
1513         Now the queue will always upload results.  Either the entire zip, or just
1514         the diffs.txt in the case of text failures.
1515
1516         This should make understanding flakes much easier, and paves the way
1517         for having the EWS run layout tests (and upload failures).
1518
1519         In order to upload .zip files I had to teach bugzilla.py to autodetect
1520         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1521         for .patch files, I have it add one before calling guess_type.
1522
1523         We may find that always uploading the whole zip instead of just the -diffs.txt
1524         file is preferable, but for now I'm keeping the old behavior because it makes
1525         quickly understanding text failures easy.
1526
1527         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1528         * Scripts/webkitpy/common/system/workspace.py: Added.
1529         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1530         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1531         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1532         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1533         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1534         * Scripts/webkitpy/tool/commands/queues.py:
1535         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1536
1537 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1538
1539         Unreviewed, rolling out r75464.
1540         http://trac.webkit.org/changeset/75464
1541         https://bugs.webkit.org/show_bug.cgi?id=52193
1542
1543         Followup rollout for 75474 (Requested by Ossy on #webkit).
1544
1545         * MiniBrowser/mac/BrowserWindowController.m:
1546         (-[BrowserWindowController awakeFromNib]):
1547         * MiniBrowser/win/BrowserView.cpp:
1548         (BrowserView::create):
1549         * WebKitTestRunner/TestController.cpp:
1550         (WTR::createOtherPage):
1551         (WTR::TestController::initialize):
1552
1553 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1554
1555         Reviewed by Csaba Osztrogonác.
1556
1557         [Qt] Baseline qt_minimal configuration
1558         https://bugs.webkit.org/show_bug.cgi?id=51313
1559
1560         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1561         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1562         QT_NO_UNDOSTACK guard.
1563
1564         * QtTestBrowser/launcherwindow.cpp:
1565         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1566         guards.
1567         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1568         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1569         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1570         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1571
1572         * QtTestBrowser/launcherwindow.h:
1573         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1574         * QtTestBrowser/locationedit.h: Ditto.
1575
1576         * QtTestBrowser/mainwindow.cpp:
1577         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1578         QT_NO_UNDOSTACK guards.
1579         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1580         (MainWindow::changeLocation): Ditto.
1581         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1582         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1583
1584         * QtTestBrowser/webpage.cpp:
1585         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1586         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1587
1588         * QtTestBrowser/webview.cpp:
1589         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1590         (WebViewGraphicsBased::animatedYFlip): Ditto.
1591
1592 2011-01-10  Sam Weinig  <sam@webkit.org>
1593
1594         Fix build.
1595
1596         * MiniBrowser/mac/BrowserWindowController.m:
1597         (-[BrowserWindowController awakeFromNib]):
1598         * MiniBrowser/win/BrowserView.cpp:
1599         (BrowserView::create):
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::createOtherPage):
1602         (WTR::TestController::initialize):
1603
1604 2011-01-10  Eric Seidel  <eric@webkit.org>
1605
1606         Reviewed by Ojan Vafai.
1607
1608         style-queue messages are way too long for big patches
1609         https://bugs.webkit.org/show_bug.cgi?id=52161
1610
1611         We definitely could build much fancier list-to-string-with-limit functions
1612         but this should be sufficient for our needs at the moment.
1613
1614         * Scripts/webkitpy/common/system/executive.py:
1615         * Scripts/webkitpy/common/system/executive_unittest.py:
1616
1617 2011-01-10  Tony Chang  <tony@chromium.org>
1618
1619         Unreviewed, rolling out r75398.
1620         http://trac.webkit.org/changeset/75398
1621         https://bugs.webkit.org/show_bug.cgi?id=52008
1622
1623         Some layout tests are crashing on Chromium Win.
1624
1625         * DumpRenderTree/chromium/WebViewHost.cpp:
1626         (WebViewHost::updatePaintRect):
1627         * DumpRenderTree/chromium/WebViewHost.h:
1628
1629 2011-01-10  Adam Roben  <aroben@apple.com>
1630
1631         Roll out r75392
1632
1633         It isn't needed now that r75289 has been rolled out.
1634
1635         * Scripts/run-javascriptcore-tests:
1636
1637 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1638
1639         Reviewed by Anders Carlsson.
1640
1641         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1642         https://bugs.webkit.org/show_bug.cgi?id=52160
1643
1644         * WebKitTestRunner/mac/TestControllerMac.mm:
1645         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1646         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1647         anyway.
1648
1649 2011-01-10  Tony Chang  <tony@chromium.org>
1650
1651         Reviewed by Mihai Parparita.
1652
1653         [chromium] fix for animated gif layout tests
1654         https://bugs.webkit.org/show_bug.cgi?id=52008
1655
1656         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1657             to trigger gif animations.
1658         (WebViewHostPaintTask::WebViewHostPaintTask):
1659         (WebViewHostPaintTask::runIfValid):
1660         (WebViewHost::updatePaintRect):
1661         * DumpRenderTree/chromium/WebViewHost.h:
1662         (WebViewHost::taskList):
1663
1664 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1665
1666         Reviewed by Xan Lopez.
1667
1668         [GTK] Fix gtk2 compilation for master
1669         https://bugs.webkit.org/show_bug.cgi?id=51885
1670
1671         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1672         (createBitmapContextFromWebView): Replaced the old
1673         gdk_drawable_get_size with gdk_pixmap_get_size.
1674
1675 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1676
1677         Reviewed by Laszlo Gombos.
1678
1679         [WINCE] Reenable NPAPI after r75203
1680         https://bugs.webkit.org/show_bug.cgi?id=52109
1681
1682         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1683         it with !isEfl(), because EFL port does not support NPAPI (yet).
1684
1685         * Scripts/build-webkit:
1686
1687 2011-01-10  Adam Roben  <aroben@apple.com>
1688
1689         Skip some asserting JS tests
1690
1691         See <http://webkit.org/b/52156>.
1692
1693         * Scripts/run-javascriptcore-tests:
1694
1695 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1696
1697         Reviewed by Xan Lopez.
1698
1699         [GTK] build-webkit disable Blob support via arguments passed to automake
1700         https://bugs.webkit.org/show_bug.cgi?id=52097
1701
1702         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1703         build-webkit.
1704
1705 2011-01-10  Adam Roben  <aroben@apple.com>
1706
1707         Use the same name and description for TestNetscapePlugin on Windows and
1708         Mac
1709
1710         Fixes <http://webkit.org/b/52151>
1711         fast/frames/iframe-reparenting-plugins.html fails on Windows
1712
1713         Reviewed by Steve Falkenburg.
1714
1715         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1716         the name and description from Mac's Info.plist.
1717
1718 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1719
1720         Reviewed by Laszlo Gombos.
1721
1722         [Qt][WK2] Guard gcc-specific syntax
1723
1724         Non-gcc based compliers choke on the "-include"
1725         syntax for preinclude, place guard around it.
1726
1727         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1728         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1729
1730 2011-01-10  Andreas Kling  <kling@webkit.org>
1731
1732         Reviewed by Simon Hausmann.
1733
1734         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1735         https://bugs.webkit.org/show_bug.cgi?id=52111
1736
1737         When getting a createNewPage() callback from QWKPage, create the
1738         new page with the same QWKContext as the page that is passed to
1739         the callback.
1740
1741         * MiniBrowser/qt/BrowserView.h:
1742         * MiniBrowser/qt/BrowserWindow.cpp:
1743         (newPageFunction):
1744         (BrowserWindow::BrowserWindow):
1745         * MiniBrowser/qt/BrowserWindow.h:
1746
1747 2011-01-10  Andreas Kling  <kling@webkit.org>
1748
1749         Reviewed by Kenneth Rohde Christiansen.
1750
1751         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1752
1753         BrowserView set its own useless createNewPage() callback on QWKPage.
1754         This was immediately overridden by BrowserWindow anyway, so remove
1755         the BrowserView one.
1756
1757         * MiniBrowser/qt/BrowserView.cpp:
1758         (BrowserView::BrowserView):
1759
1760 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1761
1762         Reviewed by Jeremy Orlow.
1763
1764         [Chromium] Remove non-client-based Geolocation code
1765         https://bugs.webkit.org/show_bug.cgi?id=50921
1766
1767         * DumpRenderTree/chromium/LayoutTestController.cpp:
1768         (LayoutTestController::setGeolocationPermission):
1769         (LayoutTestController::setMockGeolocationPosition):
1770         (LayoutTestController::setMockGeolocationError):
1771         * DumpRenderTree/chromium/WebViewHost.cpp:
1772         (WebViewHost::geolocationClientMock):
1773         (WebViewHost::reset):
1774         * DumpRenderTree/chromium/WebViewHost.h:
1775
1776 2011-01-10  Eric Seidel  <eric@webkit.org>
1777
1778         Reviewed by Adam Barth.
1779
1780         Commit bot tried to land r? cq+ patch
1781         https://bugs.webkit.org/show_bug.cgi?id=36638
1782
1783         It should now be possible to post a patch with r? and cq+ and the
1784         commit-queue will correctly wait for the r+ before attempting to land the patch.
1785         (This was a feature requested by several users.)
1786
1787         One caveat: We don't actually reject r-, cq+ patches from the queue
1788         (we just ignore them), but I think that's OK for now.
1789
1790         I also noticed that setting r- once a commit-queue node had grabbed
1791         a patch would not properly cancel the landing.  That's fixed and
1792         tested in this patch.
1793
1794         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1795         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1796         * Scripts/webkitpy/tool/bot/feeders.py:
1797         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1798
1799 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1800
1801         Reviewed by Kenneth Rohde Christiansen.
1802
1803         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1804         https://bugs.webkit.org/show_bug.cgi?id=51934
1805
1806         When accessing the network from the destructor of QWebPage, the network access manager
1807         was already deleted because the object WebPage was already destructed.
1808
1809         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1810         The object is now destructed in the destructor of QObject.
1811
1812         * QtTestBrowser/webpage.cpp:
1813         (WebPage::WebPage):
1814         (WebPage::setQnamThreaded):
1815         * QtTestBrowser/webpage.h:
1816         (QtNAMThread::QtNAMThread):
1817
1818 2011-01-08  Eric Seidel  <eric@webkit.org>
1819
1820         Reviewed by Ojan Vafai.
1821
1822         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1823         https://bugs.webkit.org/show_bug.cgi?id=52067
1824
1825         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1826         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1827
1828         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1829
1830 2011-01-08  Eric Seidel  <eric@webkit.org>
1831
1832         Reviewed by Mihai Parparita.
1833
1834         commit-queue hangs when the ChangeLog diff is bad
1835         https://bugs.webkit.org/show_bug.cgi?id=52072
1836
1837         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1838         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1839
1840 2011-01-08  Adam Barth  <abarth@webkit.org>
1841
1842         Teach svn-apply how to re-write WebCore to Source/WebCore.
1843
1844         * Scripts/VCSUtils.pm:
1845
1846 2011-01-07  Adam Barth  <abarth@webkit.org>
1847
1848         Rubber-stamped by Eric Seidel.
1849
1850         Move WebCore to Source
1851         https://bugs.webkit.org/show_bug.cgi?id=52050
1852
1853         Update the tools to understand WebCore's new location.
1854
1855         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1856         * DumpRenderTree/wscript:
1857         * GNUmakefile.am:
1858         * Scripts/build-webkit:
1859         * Scripts/do-file-rename:
1860         * Scripts/do-webcore-rename:
1861         * Scripts/generate-qt-inspector-resource:
1862         * Scripts/prepare-ChangeLog:
1863         * Scripts/run-bindings-tests:
1864         * Scripts/update-iexploder-cssproperties:
1865         * Scripts/update-sources-list.py:
1866         * Scripts/update-webkit-localizable-strings:
1867         * Scripts/webkitdirs.pm:
1868         * Scripts/webkitpy/common/config/build.py:
1869         * Scripts/webkitpy/common/config/build_unittest.py:
1870         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1871         * Scripts/webkitpy/style/checker.py:
1872         * Scripts/webkitpy/style/checker_unittest.py:
1873         * WebKitTestRunner/DerivedSources.pro:
1874         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1875         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1876         * wx/browser/wscript:
1877         * wx/build/settings.py:
1878
1879 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1880
1881         Reviewed by Sam Weinig.
1882
1883         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1884         https://bugs.webkit.org/show_bug.cgi?id=52086
1885
1886         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1887         (WTR::InjectedBundle::didReceiveMessage):
1888         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1889         (WTR::LayoutTestController::notifyDone):
1890         * WebKitTestRunner/TestController.cpp:
1891         (WTR::TestController::resetStateToConsistentValues):
1892         (WTR::TestController::run):
1893
1894 2011-01-07  James Robinson  <jamesr@chromium.org>
1895
1896         Revert "Implement mozilla's animationTime property"
1897         https://bugs.webkit.org/show_bug.cgi?id=51952
1898
1899         This approach isn't quite right.
1900
1901         * DumpRenderTree/chromium/WebViewHost.cpp:
1902         (WebViewHost::paintInvalidatedRegion):
1903
1904 2011-01-07  Adam Roben  <aroben@apple.com>
1905
1906         Build master fix
1907
1908         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1909         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1910
1911 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1912
1913         Reviewed by Csaba Osztrogonác.
1914
1915         run-qtwebkit-tests should be able to kill a testsuite.
1916
1917         Add new option in the script that can setup a timeout for a test.
1918         If the test execution takes more then specified time then the test
1919         would be terminated.
1920
1921         [Qt] run-qtwebkit-tests needs timeout
1922         https://bugs.webkit.org/show_bug.cgi?id=51894
1923
1924         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1925         * Scripts/run-qtwebkit-tests:
1926
1927 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1928
1929         Unreviewed fix after r75233.
1930
1931         Based on idea from Eric Seidel.
1932
1933         Add remote zip file handling to webkitpy.
1934         https://bugs.webkit.org/show_bug.cgi?id=50901
1935
1936         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1937
1938 2011-01-07  Shane Stephens  <shanestephens@google.com>
1939
1940         Reviewed by Eric Seidel.
1941
1942         svn-apply: should support git binary delta diffs
1943         https://bugs.webkit.org/show_bug.cgi?id=38864
1944
1945         * Scripts/VCSUtils.pm:
1946         * Scripts/svn-apply:
1947
1948 2011-01-06  Julie Parent  <jparent@chromium.org>
1949
1950         Reviewed by Eric Seidel.
1951
1952         Test Result Server not removing old results.
1953         https://bugs.webkit.org/show_bug.cgi?id=52012
1954
1955         * TestResultServer/model/jsonresults.py:
1956         Fix off-by-one: Truncate if >= num_runs, not just >.
1957         * TestResultServer/model/jsonresults_unittest.py:
1958         Add unit test to test that merging in a new result with the same value
1959         as the last result causes previous result to fall off.
1960
1961 2011-01-06  James Kozianski  <koz@chromium.org>
1962
1963         Reviewed by Mihai Parparita.
1964
1965         Add classes to provide a consistent interface to a set of files.
1966         https://bugs.webkit.org/show_bug.cgi?id=50901
1967
1968         These classes allow us to write code that is agnostic to whether a
1969         particular set of files resides in a local directory or in a zip file
1970         on a remote machine.
1971
1972         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1973         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1974         * Scripts/webkitpy/common/system/fileset.py: Added.
1975         * Scripts/webkitpy/common/system/filesystem.py:
1976         * Scripts/webkitpy/common/system/filesystem_mock.py:
1977         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1978         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1979
1980 2011-01-06  Eric Seidel  <eric@webkit.org>
1981
1982         Reviewed by Adam Barth.
1983
1984         NetworkTransaction should log the url it is retrying
1985         https://bugs.webkit.org/show_bug.cgi?id=52043
1986
1987         * Scripts/webkitpy/common/net/networktransaction.py:
1988         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1989
1990 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1991
1992         Windows build fix.
1993         Import os before using it.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1996
1997 2011-01-06  Eric Seidel  <eric@webkit.org>
1998
1999         Reviewed by Adam Barth.
2000
2001         StyleQueue fails to report errors when patches have many files
2002         https://bugs.webkit.org/show_bug.cgi?id=52042
2003
2004         This is one of at least two errors preventing style error reporting at the moment.
2005         When we moved to passing the list of files to check explicitly,
2006         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2007         We could change the type of the QueueStatus.message type, or we could
2008         just teach statusserver.py how to clamp values (and warn when it does).
2009         I chose the latter path.
2010
2011         * Scripts/webkitpy/common/net/statusserver.py:
2012
2013 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2014
2015         Reviewed by Stephanie Lewis.
2016         
2017         Fix syntax error in script.
2018
2019         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2020         https://bugs.webkit.org/show_bug.cgi?id=51996
2021
2022         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2023
2024 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2025
2026         Unreviewed, fixing WinCE build after r75196.
2027
2028         WinCE port does not (yet) support NPAPI.
2029
2030         * Scripts/build-webkit:
2031
2032 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2033
2034         Reviewed by Darin Adler.
2035
2036         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2037         https://bugs.webkit.org/show_bug.cgi?id=52015
2038
2039         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2040         after the platform has been detected, otherwise the script will
2041         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2042         detection.
2043
2044 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2045
2046         Reviewed by Eric Seidel.
2047
2048         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2049         https://bugs.webkit.org/show_bug.cgi?id=51346
2050
2051         * Scripts/build-webkit:
2052
2053 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2054
2055         Reviewed by Adam Roben.
2056
2057         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2058         https://bugs.webkit.org/show_bug.cgi?id=51996
2059         
2060         After the configuration directory change, we were archiving the incorrect directory for
2061         build product, so we were running tests on the wrong binaries.
2062         
2063         This change archives the correct directory, and also unarchives it into a configuration-
2064         specific directory.
2065
2066         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2067         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2068
2069 2011-01-06  Eric Seidel  <eric@webkit.org>
2070
2071         Reviewed by Mihai Parparita.
2072
2073         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2074         https://bugs.webkit.org/show_bug.cgi?id=52002
2075
2076         See an example of this here:
2077         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2078
2079         It's due to the fact that we pass around TestFailure() instance
2080         objects and yet expect them to all compare to be the same.
2081
2082         This is bad.  We should either have shared instances of these values
2083         or we should just pass around the class names.  There are already hacks
2084         in place to make TestFailure objects pass equality tests, I just added
2085         a __hash__ implementation so they can be used in sets as expected.
2086
2087         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2088         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2089
2090 2011-01-06  Evan Martin  <evan@chromium.org>
2091
2092         Reviewed by Tony Chang.
2093
2094         [gdb] handle inaccessible memory and UChar*
2095         https://bugs.webkit.org/show_bug.cgi?id=52003
2096
2097         To pretty-print a UChar*, we just grope around in the memory
2098         looking for a terminating NUL.  We need to handle the exception
2099         that can occur when we poke into an invalid location.
2100
2101         Additionally, the logic for choosing which pretty-printer would
2102         early return before hitting the point where we'd use the UChar*
2103         printer.  (Did this ever work?  How did it regress?)
2104
2105         * gdb/webkit.py:
2106
2107 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2108
2109         Reviewed by Ada Chan.
2110
2111         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2112         https://bugs.webkit.org/show_bug.cgi?id=51969
2113         
2114         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2115
2116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2117         (WTR::InjectedBundlePage::InjectedBundlePage):
2118         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2119         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2120
2121 2011-01-06  James Robinson  <jamesr@chromium.org>
2122
2123         Reviewed by Simon Fraser.
2124
2125         Implement mozilla's animationTime property
2126         https://bugs.webkit.org/show_bug.cgi?id=51952
2127
2128         Chromium DRT support for webkitAnimationTime.
2129
2130         * DumpRenderTree/chromium/WebViewHost.cpp:
2131         (WebViewHost::paintInvalidatedRegion):
2132
2133 2011-01-06  Julie Parent  <jparent@chromium.org>
2134
2135         Reviewed by Tony Chang.
2136
2137         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2138         https://bugs.webkit.org/show_bug.cgi?id=51217
2139
2140         * TestResultServer/model/jsonresults.py:
2141         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2142         Adds missing documentation.
2143         * TestResultServer/model/jsonresults_unittest.py:
2144         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2145         Update test_merge to take a number of builds to truncate at.
2146
2147 2011-01-06  Adam Barth  <abarth@webkit.org>
2148
2149         Reviewed by Eric Seidel.
2150
2151         The EWS should log outside of the working directory
2152         https://bugs.webkit.org/show_bug.cgi?id=51986
2153
2154         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2155         script, which will actually clean the working copy back to a pristine
2156         state instead of leaving untracked directories and ignored files.
2157
2158         * Scripts/webkitpy/tool/commands/queues.py:
2159         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2160
2161 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2162
2163         Windows build fix.
2164         Back out attempted change to built-product-archive.
2165
2166         * BuildSlaveSupport/built-product-archive:
2167
2168 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2169
2170         Windows build fix.
2171         Include configuration name when unpacking a build archive.
2172
2173         Needed, since we split Windows build results into configuration-specific directories
2174         under WebKitOutputDir.
2175
2176         * BuildSlaveSupport/built-product-archive:
2177
2178 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2179
2180         Reviewed by Darin Adler.
2181
2182         Debug and Release builds on Windows clobber each other
2183         https://bugs.webkit.org/show_bug.cgi?id=49185
2184
2185         Changes the structure of WebKitBuild build products directory so we
2186         completely separate each build configuration into independent directories.
2187         
2188         Although we previously had per-configuration directories for obj, this change adds
2189         per-configuration directories for bin, lib, obj, and include. Each configuration's
2190         build products are stored within a directory inside of WebKitBuild.
2191         
2192         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2193         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2194
2195         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2196         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2197         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2198         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2199         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2200         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2201         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2202         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2203         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2204         * FindSafari/FindSafari.vcproj:
2205         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2206         * MiniBrowser/MiniBrowserPostBuild.cmd:
2207         * MiniBrowser/MiniBrowserPreBuild.cmd:
2208         * Scripts/webkitdirs.pm:
2209         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2210         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2211         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2212         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2213         * TestWebKitAPI/win/copy-resources.cmd:
2214         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2215         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2216         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2217         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2218         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2219         * WebKitTestRunner/win/InjectedBundle.vcproj:
2220         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2221         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2222         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2223         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2224         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2225         * WinLauncher/WinLauncherCommon.vsprops:
2226         * WinLauncher/WinLauncherPostBuild.cmd:
2227         * WinLauncher/WinLauncherPreBuild.cmd:
2228
2229 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2230
2231         Reviewed by Ariya Hidayat.
2232
2233         [Qt] TestNetscapePlugin doesn't link on OS X
2234         https://bugs.webkit.org/show_bug.cgi?id=51948
2235
2236         Only add a dependency on libX11 on X11 systems
2237
2238         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2239
2240 2011-01-05  Jeff Miller  <jeffm@apple.com>
2241
2242         Reviewed by Adam Roben.
2243
2244         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2245         https://bugs.webkit.org/show_bug.cgi?id=51970
2246
2247         * Scripts/webkitpy/style/checker.py:
2248         Add -readability/naming for WebKit2 C API directories.
2249
2250 2011-01-05  Eric Seidel  <eric@webkit.org>
2251
2252         Unreviewed, just fixing one more log error from my previous python patch.
2253
2254         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2255         https://bugs.webkit.org/show_bug.cgi?id=51802
2256
2257         webkit-patch failure-reason was logging about parsing errors
2258         due to my misunderstanding of how BeautifulSoup.findAll worked.
2259
2260         Fixed, and added a unit test.
2261
2262         * Scripts/webkitpy/common/net/layouttestresults.py:
2263         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2264
2265 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2266
2267         Reviewed by Kenneth Rohde Christiansen.
2268
2269         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2270         https://bugs.webkit.org/show_bug.cgi?id=51951
2271
2272         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2273         to create new window from WebKit.
2274
2275         * MiniBrowser/qt/BrowserWindow.cpp:
2276         (newPageFunction):
2277         (BrowserWindow::BrowserWindow):
2278         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2279         (BrowserWindow::newWindow):
2280         (BrowserWindow::updateUserAgentList):
2281         (BrowserWindow::showUserAgentDialog):
2282         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2283         define the type of the backing store used for new windows.
2284         * MiniBrowser/qt/main.cpp:
2285         (main):
2286
2287 2011-01-05  Eric Seidel  <eric@webkit.org>
2288
2289         Reviewed by Ojan Vafai.
2290
2291         commit-queue should report failure type when reporting flaky tests
2292         https://bugs.webkit.org/show_bug.cgi?id=51900
2293
2294         This patch was a ridiculous amount of plumbing.  In the end I like
2295         the NRWT-style TestResult class even less.  But now we're passing
2296         a list of TestResult objects from the queue to the FlakyTestReporter.
2297         Thus the FlakyTestReporter can more easily report what type of failure
2298         occurred.
2299
2300         In the process, I found that I was not alone in finding TestResult
2301         cumbersome to use.  A bunch of code was trying to create a TestResult
2302         object with default values.  However since the constructor didn't make
2303         this easy, some places were getting it wrong (including the TestResult unit test)!
2304         I've fixed the TestResult constructor to have default values for non-essential
2305         arguments.
2306
2307         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2308         * Scripts/webkitpy/common/net/layouttestresults.py:
2309         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2310         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2311         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2312         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2313         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2314         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2315         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2316         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2317         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2318         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2319         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2320         * Scripts/webkitpy/tool/commands/queues.py:
2321         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2322
2323 2011-01-05  Eric Seidel  <eric@webkit.org>
2324
2325         Unreviewed.
2326
2327         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2328         https://bugs.webkit.org/show_bug.cgi?id=51802
2329
2330         Add another unit test to cover a previously missing import.
2331
2332         * Scripts/webkitpy/common/net/layouttestresults.py:
2333         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2334
2335 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2336
2337         Reviewed by David Levin.
2338
2339         Add mihaip@chromium.org as a reviewer
2340         https://bugs.webkit.org/show_bug.cgi?id=51966
2341         
2342         Add myself as a reviewer.
2343
2344         * Scripts/webkitpy/common/config/committers.py:
2345
2346 2011-01-05  James Simonsen  <simonjam@chromium.org>
2347
2348         Unreviewed. Adding myself to the list of committers.
2349
2350         * Scripts/webkitpy/common/config/committers.py:
2351
2352 2011-01-05  Eric Seidel  <eric@webkit.org>
2353
2354         Unreviewed.
2355
2356         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2357         https://bugs.webkit.org/show_bug.cgi?id=51802
2358
2359         Fix two exceptions seen on the bots after my original commit.
2360
2361         * Scripts/webkitpy/common/net/layouttestresults.py:
2362         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2363
2364 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2365
2366         Reviewed by Andreas Kling.
2367
2368         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2369         https://bugs.webkit.org/show_bug.cgi?id=51750
2370
2371         * QtTestBrowser/main.cpp:
2372         (LauncherApplication::handleUserOptions):
2373          Local storage settings can be enable form command line arguments for
2374          QtTestBrowser.
2375
2376 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2377
2378         Reviewed by Martin Robinson.
2379
2380         GTK: AX: DRT needs to use correct root object method.
2381         https://bugs.webkit.org/show_bug.cgi?id=51911
2382
2383         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2384         (AccessibilityController::rootElement):
2385
2386 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2387
2388         Rubber-stamped by Csaba Osztrogonác.
2389
2390         Based on idea from Péter Gál.
2391
2392         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2393
2394 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2395
2396         Reviewed by Adam Barth.
2397
2398         sheriff-bot should be able to do multi-revision rollouts
2399         https://bugs.webkit.org/show_bug.cgi?id=51176
2400
2401         * Scripts/webkitpy/tool/bot/irc_command.py:
2402         * Scripts/webkitpy/tool/bot/sheriff.py:
2403         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2404
2405 2011-01-05  Eric Seidel  <eric@webkit.org>
2406
2407         Reviewed by Adam Barth.
2408
2409         queues.webkit.org should have per-bot status pages
2410         https://bugs.webkit.org/show_bug.cgi?id=51906
2411
2412         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2413         statuses from a single queue.  Now that we have many bots servicing
2414         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2415         you care about scroll off the end of the 15-message limit on the main page.
2416
2417         Eventually we should probably rename /queue-status to /queue or /queues,
2418         but that's fodder for another patch.
2419
2420         * QueueStatusServer/handlers/queuestatus.py:
2421         * QueueStatusServer/index.yaml:
2422         * QueueStatusServer/main.py:
2423         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2424          - This probably should use a custom filter instead of hard-coding
2425            the URL scheme here, but I couldn't figure out how to easily
2426            create such a filter.  Most filters work with "strings" so we can't
2427            pass the status object.  We could add a method to the status
2428            object and call that, but that seemed a bit strange too.
2429         * QueueStatusServer/templates/queuestatus.html:
2430
2431 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2432
2433         Unreviewed. Adding myself to the list of committers.
2434
2435         * Scripts/webkitpy/common/config/committers.py:
2436
2437 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2438
2439         Reviewed by David Levin.
2440
2441         check-webkit-style treated some macros with parentheses after #elif as function calls
2442         https://bugs.webkit.org/show_bug.cgi?id=51695
2443
2444         Ingore function call space checking in any preprocessor directives
2445         (things starting with #). Change search() to match() because 
2446         preprocessor directives are supposed to be in the beginning of lines.
2447
2448         * Scripts/webkitpy/style/checkers/cpp.py:
2449         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2450
2451 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2452
2453         Reviewed by Tony Chang.
2454
2455         Change the --multi-load test option to --stress-opt
2456         https://bugs.webkit.org/show_bug.cgi?id=50751
2457
2458         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2459         (runTest):
2460         (main):
2461         * DumpRenderTree/chromium/TestShell.cpp:
2462         (TestShell::TestShell):
2463         * DumpRenderTree/chromium/TestShell.h:
2464         (TestShell::stressOpt):
2465         (TestShell::setStressOpt):
2466         (TestShell::stressDeopt):
2467         (TestShell::setStressDeopt):
2468         (TestShell::javaScriptFlags):
2469         (TestShell::setJavaScriptFlags):
2470         * Scripts/webkitpy/layout_tests/port/chromium.py:
2471         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2472
2473 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2474
2475         Reviewed by Sam Weinig.
2476
2477         WK2: Support Accessibility
2478         https://bugs.webkit.org/show_bug.cgi?id=51859
2479
2480         Use rootObject() method to get top of accessibility tree.
2481
2482         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2483         (AccessibilityController::focusedElement):
2484         (AccessibilityController::rootElement):
2485
2486 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2487
2488         Reviewed by Darin Adler.
2489
2490         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2491         https://bugs.webkit.org/show_bug.cgi?id=51846
2492
2493         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2494         back to GRefPtr.
2495
2496 2011-01-04  Zhe Su  <suzhe@chromium.org>
2497
2498         Reviewed by Kenneth Russell.
2499
2500         Fix insertText, setMarkedText and unmarkText methods of
2501         TextInputController to call corresponding methods of WebKit::WebView
2502         rather than WebKit::WebFrame. This change matches the behavior of
2503         chromium browser.
2504         insertText corresponds to WebView::confirmComposition(text)
2505         setMarkedText corresponds to WebView::setComposition(...)
2506         unmarkText corresponds to WebView::confirmComposition()
2507         https://bugs.webkit.org/show_bug.cgi?id=51693
2508
2509         * DumpRenderTree/chromium/TextInputController.cpp:
2510         (TextInputController::insertText):
2511         (TextInputController::setMarkedText):
2512         (TextInputController::unmarkText):
2513
2514 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2515
2516         Reviewed by Laszlo Gombos.
2517
2518         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2519
2520         On Symbian productDir points to the source directory. Removing all the
2521         empty files from the productDir directory corrupts the svn repository.
2522
2523         * Scripts/build-webkit:
2524
2525 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2526
2527         Reviewed by Adam Barth.
2528
2529         [Qt] Add SelectAll option to the context menu for the editor
2530         https://bugs.webkit.org/show_bug.cgi?id=50049
2531
2532         Set shortcut for the SelectAll action.
2533
2534         * QtTestBrowser/mainwindow.cpp:
2535         (MainWindow::buildUI):
2536
2537 2011-01-03  David Levin  <levin@chromium.org>
2538
2539         Reviewed by Eric Seidel.
2540
2541         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2542         https://bugs.webkit.org/show_bug.cgi?id=51842
2543
2544         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2545         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2546
2547 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2548
2549         Reviewed by David Kilzer.
2550
2551         [WINCE] Adds a build slave.
2552         https://bugs.webkit.org/show_bug.cgi?id=50523
2553
2554         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2555         entry for a release build of the WinCE port.
2556         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2557         flag to build the WinCE port.
2558
2559 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2560
2561         Reviewed by David Kilzer.
2562
2563         Add WinCE support to build-webkit
2564         https://bugs.webkit.org/show_bug.cgi?id=51642
2565
2566         * Scripts/build-webkit:
2567         * Scripts/webkitdirs.pm:
2568
2569 2011-01-03  Eric Seidel  <eric@webkit.org>
2570
2571         Reviewed by Adam Barth.
2572
2573         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2574         https://bugs.webkit.org/show_bug.cgi?id=51802
2575
2576         I'm not the biggest fan of the test_failures or test_results classes,
2577         but it's better to have one shared set of classes, than separate ones
2578         for new vs. old run-webkit-test result handling.
2579
2580         This moves the ORWT results class "LayoutTestResults" over to using
2581         TestResult and TestFailure classes, making it easy for us to
2582         make all our sheriff-bot and other webkitpy code NRWT ready.
2583
2584         This also makes it a trivial patch to generate results.json information
2585         from ORWT results.html files (for flaky test analysis, etc.) as well
2586         as making it a one-liner to report test failure types when the
2587         commit-queue sees flaky tests.
2588
2589         This patch tried not to add new functionality, but only to replace
2590         the guts of LayoutTestResults, while adding unit tests and hoping
2591         not to break anything.
2592
2593         I also moved callers which assumed User.prompt* were static/class methods
2594         to using them as instance methods (since we'll eventually want to make them such).
2595
2596         In the process of re-writing things, I broke the rebaseline command, so I wrote
2597         a unit test to catch my breakage were I do do so again in the future.
2598
2599         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2600         * Scripts/webkitpy/common/net/layouttestresults.py:
2601         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2602         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2603         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2604         * Scripts/webkitpy/tool/commands/queries.py:
2605         * Scripts/webkitpy/tool/commands/rebaseline.py:
2606         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2607         * Scripts/webkitpy/tool/mocktool.py:
2608
2609 2011-01-03  Adam Barth  <abarth@webkit.org>
2610
2611         Reviewed by Simon Fraser.
2612
2613         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2614         https://bugs.webkit.org/show_bug.cgi?id=51840
2615
2616         * Scripts/webkitpy/common/checkout/scm.py:
2617
2618 2011-01-03  Adam Barth  <abarth@webkit.org>
2619
2620         Reviewed by Simon Fraser.
2621
2622         webkit-patch should only hide update output if --quiet
2623         https://bugs.webkit.org/show_bug.cgi?id=51838
2624
2625         As requested by smfr.
2626
2627         * Scripts/webkitpy/tool/steps/update.py:
2628
2629 2011-01-03  Adam Barth  <abarth@webkit.org>
2630
2631         Reviewed by David Levin.
2632
2633         commit-queue shouldn't reject patches twice if two bots process the same patch
2634         https://bugs.webkit.org/show_bug.cgi?id=51805
2635
2636         Before raising an error, we first check whether the patch is still in
2637         the commit-queue.  This check is still racy, of course, but the time
2638         window is much smaller.
2639
2640         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2641
2642 2011-01-03  Sam Weinig  <sam@webkit.org>
2643
2644         Reviewed by Anders Carlsson.
2645
2646         Make run-api-tests less chatty.
2647         https://bugs.webkit.org/show_bug.cgi?id=51831
2648
2649         - Make script quiet by default and add --verbose option (replacing --quiet).
2650         - When not verbose, pipe stdout and stderr to devnull.
2651
2652         * Scripts/run-api-tests:
2653
2654 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2655
2656         Unreviewed. Adding myself to committers.py.
2657
2658         * Scripts/webkitpy/common/config/committers.py:
2659
2660 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2661
2662         Reviewed by Xan Lopez.
2663
2664         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2665         https://bugs.webkit.org/show_bug.cgi?id=51806
2666
2667         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2668         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2669         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2670         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2671         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2672         so make it 'WebKitBuild/Release/.libs'
2673
2674         * Scripts/webkitdirs.pm: 
2675
2676 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2677
2678         Reviewed by Adam Barth.
2679
2680         Make EFL a core builder
2681         https://bugs.webkit.org/show_bug.cgi?id=51804
2682
2683         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2684         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2685
2686 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2687
2688         [Qt] Unreviewed fix after r74855 and r74875.
2689
2690         * BuildSlaveSupport/built-product-archive:
2691          - Create directories explicitly.
2692          - Pass shell=True to subprocess.call().
2693
2694 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2695
2696         [Qt] Unreviewed fix after r74855.
2697
2698         Move JavaScriptCore to Source
2699         https://bugs.webkit.org/show_bug.cgi?id=51604
2700
2701         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2702
2703 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2704
2705         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2706
2707         Move JavaScriptCore to Source
2708         https://bugs.webkit.org/show_bug.cgi?id=51604
2709
2710         * Scripts/webkitdirs.pm:
2711
2712 2011-01-02  Robert Hogan  <robert@webkit.org>
2713
2714         Unreviewed, build fix.
2715
2716         [Qt] Fix DRT build after 74855
2717
2718         * DumpRenderTree/qt/DumpRenderTree.pro:
2719
2720 2011-01-01  Adam Barth  <abarth@webkit.org>
2721
2722         Remove the assumption from the Qt and Gtk builds that every project is
2723         in the root directory.
2724
2725         * Scripts/build-webkit:
2726
2727 2011-01-01  Adam Barth  <abarth@webkit.org>
2728
2729         Reviewed by Eric Seidel.
2730
2731         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2732         https://bugs.webkit.org/show_bug.cgi?id=51796
2733
2734         After this change, svn-apply will magically apply patches to
2735         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2736
2737         * Scripts/VCSUtils.pm:
2738
2739 2011-01-01  Adam Barth  <abarth@webkit.org>
2740
2741         Reviewed by Eric Seidel.
2742
2743         Move JavaScriptCore to Source
2744         https://bugs.webkit.org/show_bug.cgi?id=51604
2745
2746         Update references to JavaScriptCore to point to the new location.
2747
2748         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2749         * DumpRenderTree/qt/DumpRenderTree.pro:
2750         * DumpRenderTree/qt/ImageDiff.pro:
2751         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2752         * DumpRenderTree/wscript:
2753         * Scripts/build-jsc:
2754         * Scripts/build-webkit:
2755         * Scripts/do-file-rename:
2756         * Scripts/do-webcore-rename:
2757         * Scripts/run-javascriptcore-tests:
2758         * Scripts/update-javascriptcore-test-results:
2759         * Scripts/webkitdirs.pm:
2760         * Scripts/webkitpy/common/config/build_unittest.py:
2761         * Scripts/webkitpy/style/checker.py:
2762         * Scripts/webkitpy/style/checker_unittest.py:
2763         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2764         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2765         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2766         * wx/build/settings.py:
2767
2768 2011-01-01  Adam Barth  <abarth@webkit.org>
2769
2770         Reviewed by Eric Seidel.
2771
2772         Move Sources to Source
2773         https://bugs.webkit.org/show_bug.cgi?id=51794
2774
2775         Update scripts to point to the new location.
2776
2777         * Scripts/build-webkit:
2778         * Scripts/do-file-rename:
2779         * Scripts/do-webcore-rename:
2780         * Scripts/webkitpy/common/config/build.py:
2781         * Scripts/webkitpy/common/config/build_unittest.py:
2782
2783 2010-12-31  Kent Tamura  <tkent@chromium.org>
2784
2785         Reviewed by Eric Seidel.
2786
2787         [DRT/Chromium] Enable mock spell checker on non-OSX
2788         https://bugs.webkit.org/show_bug.cgi?id=51401
2789
2790         * DumpRenderTree/chromium/WebViewHost.cpp:
2791         (WebViewHost::spellCheck):
2792
2793 2010-12-31  Adam Barth  <abarth@webkit.org>
2794
2795         Reviewed by Ariya Hidayat.
2796
2797         Remove Tools/Scripts/wkstyle
2798         https://bugs.webkit.org/show_bug.cgi?id=51774
2799
2800         This script appears to not have been touched in a while and seems to
2801         have been replaced by check-webkit-style.
2802
2803         * Scripts/wkstyle: Removed.
2804
2805 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2806
2807         Unreviewed. Coding style fix.
2808
2809         * DumpRenderTree/chromium/TestShell.h:
2810
2811 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2812
2813         Reviewed by Pavel Feldman.
2814
2815         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2816
2817         It was a problem with Chromium DRT. DevToolsAgent object instance was
2818         attached not only to the inspected page but to the DevTools window too.
2819         As result all the inspector files were interpreted as a content of inspected page
2820         and were transfered to the DevTools scripts panel for debugging etc.
2821
2822         https://bugs.webkit.org/show_bug.cgi?id=51735
2823
2824         * DumpRenderTree/chromium/TestShell.cpp:
2825         (TestShell::TestShell):
2826         (TestShell::bindJSObjectsToWindow):
2827         (TestShell::createNewWindow):
2828         * DumpRenderTree/chromium/TestShell.h:
2829
2830 2010-12-31  Adam Barth  <abarth@webkit.org>
2831
2832         Rubber-stamped by Eric Seidel.
2833
2834         Move PageLoadTests to PerformanceTests/PageLoad
2835         https://bugs.webkit.org/show_bug.cgi?id=51771
2836
2837         Update references to PageLoadTests to point to the new location.
2838
2839         * Scripts/run-pageloadtest:
2840         * Scripts/webkitpy/common/config/build.py:
2841
2842 2010-12-31  Adam Barth  <abarth@webkit.org>
2843
2844         Rubber-stamped by Eric Seidel.
2845
2846         Move SunSpider into PerformanceTests
2847         https://bugs.webkit.org/show_bug.cgi?id=51769
2848
2849         Update these scripts to point to the new location.
2850
2851         * Scripts/run-sunspider:
2852         * Scripts/sunspider-compare-results:
2853
2854 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2855
2856         Reviewed by Kent Tamura.
2857
2858         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2859         https://bugs.webkit.org/show_bug.cgi?id=51728
2860         
2861         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2862         to render top-level scrollbars. This makes them match the Mac port's
2863         use of an NSScrollView, which means that we'll be able to share more
2864         pixel baselines.
2865         
2866         The new rendering code will not be activated until the 
2867         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2868         ScrollbarThemeChromiumMac.
2869
2870         * DumpRenderTree/DumpRenderTree.gypi:
2871         * DumpRenderTree/chromium/TestShellMac.mm:
2872         (platformInit):
2873         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2874         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2875         (+[FakeActiveWindow alwaysActiveWindow]):
2876         (+[FakeActiveWindow alwaysInactiveWindow]):
2877         (-[FakeActiveWindow initWithActiveControls:]):
2878         (-[FakeActiveWindow _hasActiveControls]):
2879         (WebThemeEngineDRTMac::paintScrollbarThumb):
2880         (stateToHIEnableState):
2881         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2882         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2883
2884 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2885
2886         Reviewed by David Kilzer.
2887
2888         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2889         used
2890         https://bugs.webkit.org/show_bug.cgi?id=51672
2891
2892         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2893         with USE_SYSTEM_MALLOC=1
2894         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2895         with USE_SYSTEM_MALLOC=1
2896
2897 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2898
2899         Reviewed by David Kilzer.
2900
2901         [Qt] [Symbian] Fix build-webkit script for Symbian
2902         https://bugs.webkit.org/show_bug.cgi?id=51509
2903
2904         Set the OUTPUT_DIR for Symbian to be the same as the source
2905         directory.
2906
2907         * Scripts/webkitdirs.pm:
2908
2909 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2910
2911         Reviewed by Darin Adler.
2912
2913         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2914         https://bugs.webkit.org/show_bug.cgi?id=51758
2915
2916         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2917
2918         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2919         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2920
2921 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2922
2923         Unreviewed WinCE buildfix.
2924
2925         * WinCELauncher/main.cpp: Add missing include.
2926
2927 2010-12-29  Daniel Bates  <dbates@rim.com>
2928
2929         Reviewed by Darin Adler.
2930
2931         svn-apply updates date of wrong change log entry for a change log diff that
2932         contains two consecutive entries with the same author and date
2933         https://bugs.webkit.org/show_bug.cgi?id=46061
2934
2935         Fixes an issue where the date of the wrong change log entry may be modified.
2936         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2937         in a ChangeLog file to the top of the file.
2938
2939         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2940         diff when it detects that the diff inserts a change log entry earlier in a
2941         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2942         change. With the advent of the commit-queue this functionality of bailing out
2943         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2944         Instead, we should always move the change log entry to the top of the ChangeLog file.
2945
2946         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2947         the date line of the correct change log entry in a ChangeLog diff.
2948
2949         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2950
2951         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2952           Updated the following unit tests now that we move entries inserted earlier to the top:
2953           - "fixChangeLogPatch: New entry inserted in middle."
2954             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2955
2956           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2957             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2958
2959         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2960
2961 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2962
2963         Reviewed by Eric Seidel.
2964
2965         [Qt] Fixed compatibility with gold linker on X11 platforms
2966         https://bugs.webkit.org/show_bug.cgi?id=51700
2967
2968         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2969         Linked TestNetscapePlugin with libX11 on Unix platforms
2970
2971 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2972
2973         Reviewed by Darin Adler.
2974
2975         Circular dependency in webkitpy.common.checkout.changelog module
2976         https://bugs.webkit.org/show_bug.cgi?id=50475
2977
2978         Remove automatic import of api.Checkout module when any checkout/
2979         submodule is imported (e.g.: when checkout.scm.Git is imported).
2980
2981         * Scripts/webkitpy/common/checkout/__init__.py:
2982
2983 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2984
2985         Reviewed by Ojan Vafai.
2986
2987         prepare-ChangeLog should support the -g option for specifying the git-commit
2988         https://bugs.webkit.org/show_bug.cgi?id=51708
2989
2990         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2991         webkit-patch, though the exact meaning of the two options remain different.
2992
2993         * Scripts/prepare-ChangeLog: Add -g.
2994
2995 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2996
2997         Reviewed by Simon Hausmann.
2998
2999         [Qt] Fix compilation with Qt in namespace
3000         https://bugs.webkit.org/show_bug.cgi?id=51701
3001
3002         * QtTestBrowser/webview.h:
3003
3004 2010-12-28  Daniel Bates  <dbates@rim.com>
3005
3006         Reviewed by Sam Weinig.
3007
3008         Substitute // MARK: for compiler-specific #pragma mark
3009         https://bugs.webkit.org/show_bug.cgi?id=51657
3010
3011         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3012         substituting  "// MARK:" for "#pragma mark", which provides
3013         analogous code-bookmarking functionality under Xcode.
3014
3015         Also, for consistency, we should substitute "// MARK:" for compiler-
3016         specific "#pragma mark" in the source files for the Mac port.
3017
3018         * DumpRenderTree/AccessibilityTextMarker.cpp:
3019         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3020         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3021         * DumpRenderTree/mac/ObjCController.m:
3022         * MiniBrowser/mac/AppDelegate.m:
3023         * MiniBrowser/mac/BrowserWindowController.m:
3024
3025 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3026
3027         Reviewed by Eric Seidel.
3028
3029         Add --no-build option to run-sunspider
3030         https://bugs.webkit.org/show_bug.cgi?id=51658
3031
3032         * Scripts/run-sunspider: add --no-build flag to skip building
3033         phase.
3034
3035 2010-12-27  Daniel Bates  <dbates@rim.com>
3036
3037         Rubber-stamped by Martin Robinson.
3038
3039         Append the directory Tools/DumpRenderTree to the list of directories that
3040         do-webcore-rename should search so that it can rename DRT files and
3041         source code.
3042
3043         * Scripts/do-webcore-rename:
3044
3045 2010-12-27  Eric Seidel  <eric@webkit.org>
3046
3047         Reviewed by Adam Barth.
3048
3049         build-webkit should detect missing Java SDK and explain how to install it
3050         https://bugs.webkit.org/show_bug.cgi?id=51651
3051
3052         * Scripts/build-webkit:
3053
3054 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3055
3056         Reviewed by Daniel Bates.
3057
3058         [GTK] Add support for build-jsc
3059         https://bugs.webkit.org/show_bug.cgi?id=51625
3060
3061         Add GTK+ support to build-jsc now that building the jsc executable as
3062         a standalone target is easy.
3063
3064         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3065         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3066         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3067         and pass it along to buildAutotoolsProject.
3068
3069 2010-12-27  David Levin  <levin@chromium.org>
3070
3071         Reviewed by Eric Seidel.
3072
3073         check-webkit-style check for meaningless variable names in function declarations.
3074         https://bugs.webkit.org/show_bug.cgi?id=51523
3075
3076         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3077         from the new check and whitespace/parens because the syntax is unusual and
3078         produced a fair number of positives for these checks.
3079         * Scripts/webkitpy/style/checkers/cpp.py:
3080         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3081         and parameter names when determining if the parameter name is useless.
3082         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3083         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3084         format.
3085         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3086         text or an acronym of it.
3087         (check_function_definition): Checks function definitions for meaningless variable names.
3088         (process_line): Added call to check_function_definition.
3089         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3090         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3091         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3092         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3093         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3094         because when only checking a snippet, there are a lot of bogus functions.
3095         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3096         that I put there previously and just noticed.
3097         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3098         check_function_definition and process_line.
3099
3100 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3101
3102         Reviewed by Martin Robinson.
3103
3104         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3105         https://bugs.webkit.org/show_bug.cgi?id=51591
3106
3107         Flash plugin uses gtk2 that is incompatible with gtk3 making
3108         webkit crash when it's built with gtk3.
3109
3110         * GtkLauncher/main.c:
3111         (main):
3112
3113 2010-12-25  Adam Barth  <abarth@webkit.org>
3114
3115         Reviewed by Eric Seidel.
3116
3117         Move ANGLE to Sources/ThirdParty
3118         https://bugs.webkit.org/show_bug.cgi?id=51605
3119
3120         * Scripts/build-webkit:
3121           - Point to the new ANGLE location.
3122
3123 2010-12-26  David Levin  <levin@chromium.org>
3124
3125         Reviewed by Eric Seidel.
3126
3127         check-webkit-style should be able to parse function declaration parameters.
3128         https://bugs.webkit.org/show_bug.cgi?id=51451
3129
3130         * Scripts/webkitpy/style/checkers/cpp.py:
3131         (Position.__init__): Holds simple position information (row, column).
3132         (Parameter.__init__): Holds information about a parameter.
3133         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3134         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3135         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3136         (find_parameter_name_index): Finds where the parameter name is.
3137         (parameter_list): Generates the list of parameters for a function.
3138         (_FunctionState.begin): Added information to allow determining the parameters
3139         on demand.
3140         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3141         (detect_functions): Improve function detection for operator functions and
3142         determine where the parameters end and pass that to _FunctionState.begin.
3143         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3144         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3145         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3146         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3147         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3148         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3149         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3150         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3151         the parameters found.
3152         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3153         detection test to verify that we catch the operator functions.
3154         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3155         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3156         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3157         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3158         test_function_length_check_definition_severity1_for_test.
3159
3160 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3161
3162         Unreviewed WinCE buildfix after r74334.
3163
3164         * CMakeListsWinCE.txt:
3165
3166 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3167
3168         Unreviewed, rolling out r74632.
3169         http://trac.webkit.org/changeset/74632
3170         https://bugs.webkit.org/show_bug.cgi?id=51600
3171
3172         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3173         on #webkit).
3174
3175         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3176         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3177
3178 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3179
3180         Reviewed by Kenneth Rohde Christiansen.
3181
3182         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3183         https://bugs.webkit.org/show_bug.cgi?id=43528
3184
3185         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3186         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3187         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3188         called.
3189
3190         * EWebLauncher/main.c:
3191         (browserCreate):
3192
3193 2010-12-24  Eric Seidel  <eric@webkit.org>
3194
3195         Reviewed by Adam Barth.
3196
3197         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3198         https://bugs.webkit.org/show_bug.cgi?id=28291
3199
3200         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3201         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3202         to strings with find in the diff.
3203         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3204
3205         * Scripts/webkitpy/common/checkout/api.py:
3206         * Scripts/webkitpy/common/checkout/diff_parser.py:
3207         * Scripts/webkitpy/tool/steps/abstractstep.py:
3208         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3209         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3210         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3211         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3212
3213 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3214
3215         Reviewed by Kenneth Russell.
3216
3217         Modify new-run-webkit-tests to shut up and exit when all the threads
3218         are wedged so that test runs complete faster and we don't end up
3219         w/ enormous log files.
3220
3221         https://bugs.webkit.org/show_bug.cgi?id=51572
3222
3223         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3224         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3225
3226 2010-12-24  Eric Seidel  <eric@webkit.org>
3227
3228         Reviewed by David Levin.
3229
3230         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3231         https://bugs.webkit.org/show_bug.cgi?id=51549
3232
3233         I've had multiple people ask me about the commit-queue's behavior
3234         regarding reporting flaky tests.  I figured it would be best to just
3235         have the queue explain itself in the bugs it files.
3236
3237         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3238         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3239
3240 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3241
3242         Reviewed by Eric Seidel.
3243
3244         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3245         https://bugs.webkit.org/show_bug.cgi?id=51467
3246
3247         * Scripts/webkitpy/style/checker.py:
3248         * Scripts/webkitpy/style/checker_unittest.py:
3249
3250 2010-12-23  Adam Barth  <abarth@webkit.org>
3251
3252         Rubber-stamped by Eric Seidel.
3253
3254         Move JavaScriptGlue into Sources
3255         https://bugs.webkit.org/show_bug.cgi?id=51583
3256
3257         These tools refer to JavaScriptGlue and need to be updated to its new
3258         location.
3259
3260         * Scripts/build-webkit:
3261         * Scripts/do-file-rename:
3262         * Scripts/do-webcore-rename:
3263         * Scripts/webkitpy/common/config/build.py:
3264         * Scripts/webkitpy/common/config/build_unittest.py:
3265
3266 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3267
3268         Reviewed by Eric Seidel.
3269
3270         Bug 51539 - update iexploder scripts to point to new location
3271
3272         * Scripts/run-iexploder-tests:
3273         * Scripts/update-iexploder-cssproperties:
3274
3275 2010-12-23  Evan Martin  <evan@chromium.org>
3276
3277         Reviewed by Ryosuke Niwa.
3278
3279         [chromium] LayoutTestController warning in float->int conversion
3280         https://bugs.webkit.org/show_bug.cgi?id=51553
3281
3282         Rather than reading an int, converting to a float, then getting a compiler
3283         warning on passing the float to something that expects an int, instead
3284         just pass around ints.
3285
3286         No tests, fixes a compiler warning.
3287
3288         * DumpRenderTree/chromium/LayoutTestController.cpp:
3289         (parsePageSizeParameters):
3290         (LayoutTestController::pageNumberForElementById):
3291         (LayoutTestController::numberOfPages):
3292
3293 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3294
3295         Reviewed by Darin Adler.
3296
3297         Bug 51537 - iexploder needs cleanup
3298         
3299         * iExploder/htdocs: Removed.
3300         * iExploder/htdocs/config.rb: Removed.
3301         * iExploder/htdocs/cssproperties.in: Removed.
3302         * iExploder/htdocs/cssvalues.in: Removed.
3303         * iExploder/htdocs/htmlattrs.in: Removed.
3304         * iExploder/htdocs/htmltags.in: Removed.
3305         * iExploder/htdocs/htmlvalues.in: Removed.
3306         * iExploder/htdocs/iexploder.cgi: Removed.
3307         * iExploder/htdocs/iexploder.rb: Removed.
3308         * iExploder/htdocs/index.html: Removed.
3309         * iExploder/htdocs/webserver.rb: Removed.
3310         * iExploder/iexploder-1.7.2/output: Removed.
3311         * iExploder/tools: Removed.
3312         * iExploder/tools/lasthit.rb: Removed.
3313         * iExploder/tools/osx_last_crash.rb: Removed.
3314         * iExploder/tools/showtest.rb: Removed.
3315
3316 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3317
3318         Reviewed by Kenneth Rohde Christiansen.
3319
3320         [EFL] Make 'single' the default backing store in EWebLauncher
3321         https://bugs.webkit.org/show_bug.cgi?id=51534
3322
3323         'single' is the simplest backing store and the one intended to be the
3324         default in the test browser. By mistake the tiled backing store was
3325         left as default in r72617.
3326
3327         * EWebLauncher/main.c:
3328         (browserCreate): ditto.
3329
3330 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3331
3332         Reviewed by Kenneth Rohde Christiansen.
3333
3334         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3335         https://bugs.webkit.org/show_bug.cgi?id=51533
3336
3337         There's no point in concatenating env("HOME") with "blah", so remove
3338         option from EWebLauncher.
3339
3340         * EWebLauncher/main.c:
3341         (main): ditto.
3342
3343 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3344
3345         Reviewed by Eric Seidel.
3346
3347         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3348
3349         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3350         I just discovered that we have two additional GC runs per each WebViewHost.
3351         Test_shell had no such calls.
3352         These gc runs eat 15% of cpu time.
3353
3354         https://bugs.webkit.org/show_bug.cgi?id=51479
3355
3356         * DumpRenderTree/chromium/WebViewHost.cpp:
3357         (WebViewHost::~WebViewHost):
3358
3359 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3360
3361         Reviewed by Ojan Vafai.
3362
3363         This change splits out the TestRunner class into its own file.
3364         When we fork the code for message passing, we will create a new
3365         TestRunner, and this change will allow that to be more modular.
3366
3367         While we're at it, split out TestInput and ResultSummary into
3368         their own files, to reduce the size of run_webkit_tests to
3369         something more managable.
3370
3371         https://bugs.webkit.org/show_bug.cgi?id=51092
3372
3373         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3374         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3375         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3376         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3377         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3378         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3379         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3380
3381  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3382
3383         Reviewed by Ojan Vafai.
3384
3385         nrwt multiprocessing - start over, prepare to fork the code
3386  
3387         This code cleans up the signatures and implementation of the
3388         TestRunner class so we can easily fork it to run either the
3389         stable implementation or the new, unstable message-passing
3390         implementation. The two variants will have different
3391         implementations of the run_tests() method. We will switch
3392         between the two based on the setting for the '--worker-model'
3393         switch. We rename the two currently valid values to 'old-inline'
3394         and 'old-threads'.
3395
3396         https://bugs.webkit.org/show_bug.cgi?id=51081
3397
3398         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3399         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3400
3401 2010-12-22  Victor Wang  <victorw@chromium.org>
3402
3403         Reviewed by Darin Fisher.
3404
3405         [Chromium] Update chromium archive test result url in rebaseline script.
3406
3407         https://bugs.webkit.org/show_bug.cgi?id=51503
3408
3409         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3410
3411 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3412
3413         Reviewed by Alice Liu.
3414
3415         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3416         Verified on Chrome, Safari, and IE.
3417         With this change, we will record memory from a parent browser window and all child processes.
3418
3419         * record-memory-win/main.cpp:
3420         (ProcessArgs):
3421         (PrintUsage):
3422         (getMemoryInfo):
3423         (printProcessInfo):
3424         (evalProcesses):
3425         (UseImage):
3426         (QueryContinuously):
3427         (ElapsedTime):
3428
3429 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3430
3431         Unreviewed rollout r74489, because it was missing changelog.
3432
3433         * record-memory-win/main.cpp:
3434         
3435 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3436
3437         Adding myself as a reviewer.
3438
3439         * Scripts/webkitpy/common/config/committers.py:
3440
3441 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3442
3443         Unreviewed.  Adding myself to committers.py.
3444
3445         * Scripts/webkitpy/common/config/committers.py:
3446
3447 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3448
3449         Reviewed by Kenneth Rohde Christiansen.
3450
3451         TestNetscapePlugIn should use #if defined
3452         https://bugs.webkit.org/show_bug.cgi?id=51471
3453
3454         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3455         (NP_Initialize):
3456         (NPP_New):
3457
3458 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3459
3460         Reviewed by Yury Semikhatsky.
3461
3462         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3463
3464         DevTools window should be closed explicitly because it has custom deinitialization code.
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=50722
3467
3468         * DumpRenderTree/chromium/TestShell.cpp:
3469         (TestShell::closeRemainingWindows):
3470
3471 2010-12-22  David Levin  <levin@chromium.org>
3472
3473         Reviewed by Shinichiro Hamaji.
3474
3475         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3476         https://bugs.webkit.org/show_bug.cgi?id=51452
3477
3478         * Scripts/webkitpy/style/checkers/cpp.py:
3479         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3480         Using the file extension if possible but falling back to the file contents if we have a header file.
3481         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3482         (_FileState.is_c_or_objective_c):
3483         (check_using_std): Changed to using _FileState to determine the file type.
3484         (check_max_min_macros): Ditto.
3485         (check_for_null): Ditto.
3486         (check_style): Changed the parameters to various calls since they now need _FileState
3487         to determine the file type.
3488         (check_language): Added the file_state parameter so it could be passed
3489         to check_identifier_name_in_declaration.
3490         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3491         this is an Objective C file.
3492         (_process_lines): Added information for the _FileState constructor (and moved the
3493         call to a place that had the information).
3494         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3495         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3496         its functionality.
3497         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3498
3499 2010-12-21  Andy Estes  <aestes@apple.com>
3500
3501         Reviewed by Mark Rowe.
3502
3503         Do not build non-Intel architectures for WebKit2-related projects.
3504         https://bugs.webkit.org/show_bug.cgi?id=51440
3505
3506         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3507         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3508         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3509
3510 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3511
3512         Reviewed by Darin Fisher.
3513
3514         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3515         https://bugs.webkit.org/show_bug.cgi?id=51406 
3516         
3517         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3518         to WebThemeEngineDRTWin and update references everywhere.
3519
3520         * DumpRenderTree/DumpRenderTree.gypi:
3521         * DumpRenderTree/chromium/TestShellWin.cpp:
3522         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3523         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3524         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3525         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3526
3527 2010-12-21  Anders Carlsson  <andersca@apple.com>
3528
3529         Reviewed by John Sullivan.
3530
3531         Clicking missing plug-in text does not show a sheet
3532         https://bugs.webkit.org/show_bug.cgi?id=51403
3533
3534         Update for changes to the WebPageUIClient.
3535
3536         * MiniBrowser/mac/BrowserWindowController.m:
3537         (-[BrowserWindowController awakeFromNib]):
3538         * WebKitTestRunner/TestController.cpp:
3539         (WTR::createOtherPage):
3540         (WTR::TestController::initialize):
3541
3542 2010-12-21  Eric Seidel  <eric@webkit.org>
3543
3544         Reviewed by Adam Barth.
3545
3546         commit-queue will report constant failures as flaky if other tests flake
3547         https://bugs.webkit.org/show_bug.cgi?id=51272
3548
3549         This patch just removes functionality and adds testing.
3550         Previously we attempted to report flaky tests when we had
3551         two different tests fail in a row.  However, since we stop
3552         running the tests at the first failure, our code was wrong in
3553         trying to determine flakiness from the incomplete runs.
3554
3555         Originally I posted an alternate patch:
3556         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3557         which fixed our flaky logic in this case, however it was decided
3558         that that patch would be too difficult to maintain, so now
3559         I'm just removing the broken logic.
3560
3561         This will dramatically cut-down on our flaky-test false positives
3562         at the (small) cost of the queues being unable to report
3563         any flakiness if the tree is very flaky.  (With at least one test
3564         flaking on every run, we'll never report failures anymore.)  I think
3565         this is a tradeoff worth making.
3566
3567         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3568         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3569
3570 2010-12-20  Eric Seidel  <eric@webkit.org>
3571
3572         Reviewed by Adam Barth.
3573
3574         commit-queue wrongly rejects patches when it can't update itself
3575         https://bugs.webkit.org/show_bug.cgi?id=46636
3576
3577         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3578         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3579         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3580
3581 2010-12-20  Adam Barth  <abarth@webkit.org>
3582
3583         Move web sites to Websites directory
3584         https://bugs.webkit.org/show_bug.cgi?id=51323
3585
3586         Update references to BugsSite to point to the new location.
3587
3588         This patch was never officially reviewed (because it was too large to
3589         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3590         Rowe gave me the green light.
3591
3592         * Scripts/old-run-webkit-tests:
3593         * Scripts/webkitpy/common/config/build.py:
3594         * Scripts/webkitpy/common/config/build_unittest.py:
3595         * Scripts/webkitpy/common/prettypatch.py:
3596         * Scripts/webkitpy/layout_tests/port/base.py:
3597         * Scripts/webkitpy/style/main.py:
3598
3599 2010-12-20  Adrienne Walker  <enne@google.com>
3600
3601         Unreviewed. Adding myself to the list of committers.
3602
3603         * webkitpy/common/config/committers.py:
3604
3605 2010-12-20  Mark Rowe  <mrowe@apple.com>
3606
3607         Reviewed by Dan Bernstein.
3608
3609         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3610
3611         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3612         Resources directory.
3613
3614 2010-12-20  Eric Seidel  <eric@webkit.org>
3615
3616         Reviewed by Adam Barth.
3617
3618         commit-queue should include bot id when attaching failure diffs
3619         https://bugs.webkit.org/show_bug.cgi?id=51280
3620
3621         This is a tiny change to include the bot id in the name of the attachment.
3622         Most of this diff is just changing the unit test expectations
3623         now that I hid the comment printing when the comment is None.
3624
3625         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3626         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3627         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3628         * Scripts/webkitpy/tool/mocktool.py:
3629
3630 2010-12-20  Jeff Miller  <jeffm@apple.com>
3631
3632         Reviewed by Dan Bernstein.
3633
3634         Tools/vcbin/midl.exe needs to be rebuilt
3635         https://bugs.webkit.org/show_bug.cgi?id=51347
3636
3637         * vcbin/midl.exe: Rebuilt.
3638
3639 2010-12-20  David Levin  <levin@chromium.org>
3640
3641         Reviewed by Ariya Hidayat.
3642
3643         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3644         https://bugs.webkit.org/show_bug.cgi?id=51343
3645
3646         Follow up from the WebKitTools -> Tools rename.
3647
3648         * Scripts/webkit-tools-completion.sh:
3649
3650 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3651
3652         Reviewed by James Robinson.
3653
3654         new-run-webkit-tests ignores trailing EOL differences in text tests
3655         https://bugs.webkit.org/show_bug.cgi?id=36983
3656
3657         Changed the handling of new-line characters within new-run-webkit-tests
3658         to match old-run-webkit-tests.  Differences in leading and trailing empty
3659         lines in text expectation files are no longer ignored.
3660
3661         * Scripts/webkitpy/layout_tests/port/base.py:
3662         * Scripts/webkitpy/layout_tests/port/test.py:
3663         Added unit tests.  Removed old duplicate unit test entries.
3664         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3665
3666 2010-12-20  David Levin  <levin@chromium.org>
3667
3668         Reviewed by Shinichiro Hamaji.
3669
3670         check-webkit-style should detect function declarations (and trivial functions).
3671         https://bugs.webkit.org/show_bug.cgi?id=51303
3672
3673         * Scripts/webkitpy/style/checkers/cpp.py:
3674         (_FunctionState.begin): Add is_declaration and changed the line count
3675         start to begin at -1 (which will keep the results consistent, since
3676         the starting line number passed in is one less in this change).
3677         (detect_functions): changed function detection to now catch trivial
3678         functions and declarations.
3679         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3680         of the function as this may look at return values (when processing
3681         a declaration).
3682         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3683         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3684         of testing the function detection.
3685         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3686         function.
3687         (FunctionDetectionTest.test_function_declaration_detection): Test a
3688         declaration.
3689         (FunctionDetectionTest.test_non_functions): A test case for a case
3690         that caused the code to fail due to the { being in quotes.
3691         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3692         cases to help catch false alarms for return values.
3693         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3694         we don't get false alarms for member variables either.
3695
3696 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3697
3698         Reviewed by Antonio Gomes.
3699
3700         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3701         https://bugs.webkit.org/show_bug.cgi?id=51319
3702
3703         * CMakeListsEfl.txt:
3704
3705 2010-12-18  Adam Barth  <abarth@webkit.org>
3706
3707         Reviewed by Sam Weinig.
3708
3709         Move WebKitExamplePlugins to Examples
3710         https://bugs.webkit.org/show_bug.cgi?id=51291
3711
3712         * Scripts/webkitpy/common/config/build.py:
3713
3714 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3715
3716         Unreviewed Qt buildfix after r74301.
3717
3718         Rename WebKitTools to Tools
3719         https://bugs.webkit.org/show_bug.cgi?id=49861
3720
3721         * MiniBrowser/DerivedSources.pro:
3722         * MiniBrowser/qt/MiniBrowser.pro:
3723
3724 2010-12-17  Dan Bernstein  <mitz@apple.com>
3725
3726         Reviewed by Simon Fraser.
3727
3728         Rename WebKitTools to Tools
3729         https://bugs.webkit.org/show_bug.cgi?id=49861
3730
3731         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3732         * CodeCoverage/README:
3733         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3734         (WebCore::DumpRenderTree::initializeFonts):
3735         * EWSTools/start-commit-queue.sh:
3736         * EWSTools/start-queue.sh:
3737         * GNUmakefile.am:
3738         * MIDLWrapper/MIDLWrapper.cpp:
3739         (wmain):
3740         * MiniBrowser/qt/MiniBrowser.pro:
3741         * Scripts/build-api-tests:
3742         * Scripts/build-dumprendertree:
3743         * Scripts/build-webkit:
3744         * Scripts/build-webkittestrunner:
3745         * Scripts/generate-coverage-data:
3746         * Scripts/old-run-webkit-tests:
3747         * Scripts/run-api-tests:
3748         * Scripts/run-iexploder-tests:
3749         * Scripts/run-javascriptcore-tests:
3750         * Scripts/run-mangleme-tests:
3751         * Scripts/run-sunspider:
3752         * Scripts/run-webkit-websocketserver:
3753         * Scripts/sunspider-compare-results:
3754         * Scripts/test-webkitperl:
3755         * Scripts/test-webkitpy:
3756         * Scripts/update-iexploder-cssproperties:
3757         * Scripts/update-webkit:
3758         * Scripts/update-webkit-localizable-strings:
3759         * Scripts/webkitdirs.pm:
3760         * Scripts/webkitpy/common/checkout/scm.py:
3761         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3762         * Scripts/webkitpy/common/config/committervalidator.py:
3763         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3764         * Scripts/webkitpy/common/config/ports.py:
3765         * Scripts/webkitpy/common/config/ports_unittest.py:
3766         * Scripts/webkitpy/common/system/logutils_unittest.py:
3767         * Scripts/webkitpy/common/system/ospath_unittest.py:
3768         * Scripts/webkitpy/layout_tests/port/chromium.py:
3769         * Scripts/webkitpy/layout_tests/port/config.py:
3770         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3771         * Scripts/webkitpy/layout_tests/port/http_server.py:
3772         * Scripts/webkitpy/layout_tests/port/test.py:
3773         * Scripts/webkitpy/style/checker.py:
3774         * Scripts/webkitpy/style/checker_unittest.py:
3775         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3776         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3777         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3778         * WebKitTestRunner/DerivedSources.pro:
3779         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3780         (WTR::activateFonts):
3781         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3782         * wx/build/build_utils.py:
3783
3784 2010-12-16  Antonio Gomes  <agomes@rim.com>
3785
3786         Reviewed by Martin Robinson.
3787
3788         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3789         https://bugs.webkit.org/show_bug.cgi?id=51163
3790
3791         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3792         GTK+'s DRT should also reset to UNIX after each test execution.
3793
3794         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3795         (resetDefaultsToConsistentValues):
3796
3797 2010-12-17  David Levin  <levin@chromium.org>
3798
3799         Reviewed by Eric Seidel.
3800
3801         check-webkit-style should understand WTF #include guards
3802         https://bugs.webkit.org/show_bug.cgi?id=44911
3803
3804         * Scripts/webkitpy/style/checkers/cpp.py:
3805         (get_header_guard_cpp_variable): modify to suggest the WTF style
3806         of header guard when appropriate.
3807         (check_for_header_guard): handle multiple return values from
3808         get_header_guard_cpp_variable
3809         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3810         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3811         header style.
3812
3813 2010-12-16  David Levin  <levin@chromium.org>
3814
3815         Reviewed by Eric Seidel.
3816
3817         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3818         https://bugs.webkit.org/show_bug.cgi?id=51210
3819
3820         The error only shows up when using python 2.6 or later.
3821
3822         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3823         the decprecated field error,message with something equivalent.
3824
3825 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3826
3827         Reviewed by Eric Seidel.
3828
3829         Add --exit-after-n-failures/crashes to NRWT
3830         https://bugs.webkit.org/show_bug.cgi?id=51160
3831         
3832         Abort test run (in a similar way to how control-C is handled) when
3833         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3834         that number of unexpected failures/crashes/timeouts.
3835
3836         * Scripts/webkitpy/layout_tests/port/test.py:
3837         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3838         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3839
3840 2010-12-16  David Levin  <levin@chromium.org>
3841
3842         Reviewed by Shinichiro Hamaji.
3843
3844         check-webkit-style unit tests has some duplicate boilerplate code.
3845         https://bugs.webkit.org/show_bug.cgi?id=49519
3846
3847         * Scripts/webkitpy/style/checkers/cpp.py:
3848         (update_include_state): Replaced the "io" parameter with the global
3849         configuration _unit_test_config. This allowed not calling into
3850         functions at a low level and also not plumbing through the injection
3851         information through many levels of code.
3852         (check_for_include_what_you_use): Ditto.
3853         (process_file_data): Added the ability to set up the unit test config
3854         to allow for injection.
3855         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3856         (ErrorCollector.__init__): Added support for having a filter for errors.
3857         (ErrorCollector.__call__): Ditto.
3858         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3859         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3860         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3861         functions in the cpp.py with generic processing and a filter that
3862         indicates what errors should be kept.
3863         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3864         (CppStyleTestBase.perform_language_rules_check): Ditto.
3865         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3866         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3867         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3868         (CppStyleTest.test_multi_line_comments): Added another
3869         error message which applies to the test case.
3870         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3871         to not have config.h, since it is processed as a header file.
3872         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3873         style and indentation in checked code.
3874         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3875         Fixed line number.
3876         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3877         Ditto.
3878
3879 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3880
3881         Unreviewed, rolling out r74136.
3882         http://trac.webkit.org/changeset/74136
3883         https://bugs.webkit.org/show_bug.cgi?id=51135
3884
3885         r74136 breaks chromium canary bots because some tests are not
3886         rebaselined correctly to resolve EOL differences (Requested by
3887         jianli on #webkit).
3888
3889         * Scripts/webkitpy/layout_tests/port/base.py:
3890         * Scripts/webkitpy/layout_tests/port/test.py:
3891         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3892
3893 2010-12-15  Adam Roben  <aroben@apple.com>
3894
3895         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3896         syntax errors
3897
3898         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3899         XML syntax errors in .vcproj/.vsprops files
3900
3901         Reviewed by Dave Levin.
3902
3903         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3904         that should be treated as XML and that should be allowed to contain
3905         carriage returns. (These lists happen to be identical currently.)
3906         (FileType): Added a new XML type.
3907         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3908         Just does a simple file extension check.
3909         (CheckerDispatcher._file_type): Added a case for XML files.
3910         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3911         files (surprise!).
3912         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3913         lines through the carriage checker.
3914
3915         * Scripts/webkitpy/style/checker_unittest.py:
3916         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3917         Added. Checks a few file names to see if carriage returns are allowed
3918         or not.
3919         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3920         other assert_checker_* functions.
3921         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3922         test_*_paths functions.
3923         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3924         test_*_paths functions.
3925         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3926         file from this test case, as vcproj files now have a type.
3927         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3928         Added. Similar to the other should_* functions.
3929         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3930         Added. Checks that carriage returns aren't checked for or stripped for
3931         allowed files.
3932
3933         * Scripts/webkitpy/style/checkers/xml.py: Added.
3934         (XMLChecker.__init__): Simple init method.
3935         (XMLChecker.check): Pass each line through the expat parser, and record
3936         a style error for any errors thrown by the parser.
3937
3938         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3939         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3940         produce a style error.
3941         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3942         error of the given category on the given line.
3943         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3944         checking that the XMLChecker constructor works properly.
3945         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3946         cause a style error (see, e.g., r73887).
3947         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3948         cause a style error (see, e.g., r73773).
3949         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3950         properly.
3951         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3952         tags cause a style error (see, e.g., r72795).
3953         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3954         style error.
3955
3956 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3957
3958         Reviewed by Stephanie Lewis.
3959
3960         https://bugs.webkit.org/show_bug.cgi?id=51117
3961         Add a new leopard test bot
3962         really really commit to trunk this time.
3963
3964         * BuildSlaveSupport/build.webkit.org-config/config.json:
3965
3966 2010-12-15  Sam Weinig  <sam@webkit.org>
3967
3968         Reviewed by Anders Carlsson.
3969
3970         WebKit2: Can't add files to an <input type=file>
3971         https://bugs.webkit.org/show_bug.cgi?id=51087
3972
3973         * MiniBrowser/mac/BrowserWindowController.m:
3974         (runOpenPanel):
3975         (-[BrowserWindowController awakeFromNib]):
3976         Add simple implementation of runOpenPanel callback.
3977
3978         * MiniBrowser/win/BrowserView.cpp:
3979         (BrowserView::create):
3980         * WebKitTestRunner/TestController.cpp:
3981         (WTR::createOtherPage):
3982         (WTR::TestController::initialize):
3983         Stub out runOpenPanel callback. 
3984
3985 2010-12-14  Eric Seidel  <eric@webkit.org>
3986
3987         Reviewed by Adam Barth.
3988
3989         commit-queue should upload failure diffs when tests flake
3990         https://bugs.webkit.org/show_bug.cgi?id=51051
3991
3992         To make this testable I needed to pipe FileSystem down onto tool.
3993         We've wanted it there for a long time anyway.
3994
3995         This patch is kinda a big hack.  But we don't have a nice
3996         way to read results.html files.  I think this will need further
3997         revision before this code actually feels clean.
3998
3999         As part of testing this change, I had to make MockBugzilla.create_bug
4000         actually return an id (like it should) which required updating
4001         a few other unit test results (for the better).
4002
4003         The results_matching_keys change in layouttestresults/rebasline
4004         was an alternate path which I decided not to use in the end, but
4005         I left the change as it seemed an improvement.
4006
4007         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4008         * Scripts/webkitpy/common/net/layouttestresults.py:
4009         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4010         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4011         * Scripts/webkitpy/tool/commands/queues.py:
4012         * Scripts/webkitpy/tool/commands/rebaseline.py:
4013         * Scripts/webkitpy/tool/main.py:
4014         * Scripts/webkitpy/tool/mocktool.py:
4015
4016 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
4017
4018         Reviewed by James Robinson.
4019
4020         new-run-webkit-tests ignores trailing EOL differences in text tests
4021         https://bugs.webkit.org/show_bug.cgi?id=36983
4022
4023         Changed the handling of new-line characters within new-run-webkit-tests
4024         to match old-run-webkit-tests.  Differences in leading and trailing empty
4025         lines in text expectation files are no longer ignored.
4026
4027         * Scripts/webkitpy/layout_tests/port/base.py:
4028         * Scripts/webkitpy/layout_tests/port/test.py:
4029         Added unit tests.  Removed old duplicate unit test entries.
4030         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4031
4032 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4033
4034         Reviewed by Adam Barth.
4035
4036         make status-bubble white-space:nowrap so we can measure it's width without wrapping
4037         https://bugs.webkit.org/show_bug.cgi?id=51149
4038
4039         * QueueStatusServer/templates/statusbubble.html:
4040
4041 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4042
4043         Reviewed by Adam Barth.
4044
4045         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
4046         https://bugs.webkit.org/show_bug.cgi?id=51125
4047
4048         * QueueStatusServer/templates/statusbubble.html:
4049
4050 2010-12-15  Darin Adler  <darin@apple.com>
4051
4052         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
4053
4054 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4055
4056         Unreviewed, rolling out r74117.
4057         http://trac.webkit.org/changeset/74117
4058         https://bugs.webkit.org/show_bug.cgi?id=51113
4059
4060         This broke the GTK1 build. (Requested by mrobinson on
4061         #webkit).
4062
4063         * Scripts/webkitdirs.pm:
4064
4065 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
4066
4067         Reviewed by Martin Robinson.
4068
4069         Change generate-forwarding-headers.pl for GTK port usage 
4070         (https://bugs.webkit.org/show_bug.cgi?id=37369)
4071
4072         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
4073
4074 2010-12-14  Kent Tamura  <tkent@chromium.org>
4075
4076         Reviewed by Jian Li.
4077
4078         [DRT/Chromium] Remove another unnecessary error message
4079         https://bugs.webkit.org/show_bug.cgi?id=51083
4080
4081         * DumpRenderTree/chromium/WebViewHost.cpp:
4082         (WebViewHost::didInvalidateRect):
4083
4084 2010-12-14  Lucas Forschler  <lforschler@apple.com>
4085
4086         Reviewed by Stephanie Lewis.
4087
4088         Add a new Leopard Debug Test WK2 Bot
4089
4090         * BuildSlaveSupport/build.webkit.org-config/config.json:
4091
4092 2010-12-14  Ojan Vafai  <ojan@chromium.org>
4093
4094         Fix python unittests after http://trac.webkit.org/changeset/74070.
4095
4096         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4097
4098 2010-12-14  Kent Tamura  <tkent@chromium.org>
4099
4100         Reviewed by Jian Li.
4101
4102         [DRT/Chromium] Remove a unnecessary error message
4103         https://bugs.webkit.org/show_bug.cgi?id=51069
4104
4105         * DumpRenderTree/chromium/WebViewHost.cpp:
4106         (WebViewHost::paintInvalidatedRegion):
4107
4108 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
4109
4110         Reviewed by Ojan Vafai.
4111
4112         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
4113         https://bugs.webkit.org/show_bug.cgi?id=48926
4114
4115         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4116         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
4117
4118 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4119
4120         Reviewed by Eric Seidel.
4121
4122         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
4123         https://bugs.webkit.org/show_bug.cgi?id=50231
4124
4125         Guard CONFIG+=link_pkgconfig with !symbian.
4126
4127         * DumpRenderTree/qt/DumpRenderTree.pro:
4128         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4129         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4130
4131 2010-12-14  Philippe Normand  <pnormand@igalia.com>
4132
4133         Reviewed by Ojan Vafai.
4134
4135         [new-run-webkit-tests] expectations parsing is slow
4136         https://bugs.webkit.org/show_bug.cgi?id=50635
4137
4138         Avoid expensive iteration of all the tests when checking if a test
4139         file is to be skipped or not.
4140
4141         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4142         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
4143         * Scripts/webkitpy/layout_tests/port/test.py:
4144
4145 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
4146
4147         Reviewed by Xan Lopez.
4148
4149         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
4150         https://bugs.webkit.org/show_bug.cgi?id=27048
4151
4152         Add support in DRT for checking whether an accessibility UI
4153         element is focusable and/or focused. Implemented for GTK.
4154
4155         * DumpRenderTree/AccessibilityUIElement.cpp:
4156         (getIsFocusedCallback): New.
4157         (getIsFocusableCallback): New.
4158         (AccessibilityUIElement::getJSClass): Add the new available
4159         callbacks for isFocused and isFocusable.
4160         * DumpRenderTree/AccessibilityUIElement.h:
4161         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4162         (AccessibilityUIElement::isFocused): New, implemented by checking
4163         whether the related AtkState value is in the object's state set.
4164         (AccessibilityUIElement::isFocusable): Ditto.
4165         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4166         (AccessibilityUIElement::isFocused): New, dummy implementation.
4167         (AccessibilityUIElement::isFocusable): Ditto.
4168         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4169         (AccessibilityUIElement::isFocused): Ditto.
4170         (AccessibilityUIElement::isFocusable): Ditto.
4171
4172 2010-12-14  Eric Seidel  <eric@webkit.org>
4173
4174         Reviewed by Ojan Vafai.
4175
4176         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
4177         https://bugs.webkit.org/show_bug.cgi?id=50715
4178
4179         This patch makes webkit-patch print the following:
4180
4181         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
4182         Install a 64-bit git for better performance, see:
4183         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
4184
4185         I wrote this mostly because I have approximately 8 machines that I use
4186         and making sure each one is using a good Git install seemed folly.
4187         webkit-patch makes a lot of git calls, so using a fast git can shave
4188         several seconds in every invocation.  See the webkit-dev thread for more info.
4189
4190         This message will print twice during 'webkit-patch upload',
4191         once from webkit-patch and once from check-webkit-style.
4192
4193         Unfortunately there is no good way to test this due to how machine-dependent
4194         the code is.  I considered writing a test for the log message, but it seemed not worth it.
4195
4196         * Scripts/webkitpy/common/checkout/scm.py:
4197
4198 2010-12-13  Eric Seidel  <eric@webkit.org>
4199
4200         Reviewed by Adam Barth.
4201
4202         FlakyTestReporter doesn't understand bots running from multiple email addresses
4203         https://bugs.webkit.org/show_bug.cgi?id=50960
4204
4205         This explains at least one of the dupes of:
4206         https://bugs.webkit.org/show_bug.cgi?id=50863
4207         that we saw filed by the commit-queue this morning.
4208         I think the other one was explained by my previous fix to result counting code.
4209
4210         Since this is really hard to test with a unit test, instead I
4211         create a new (possibly useful in the future) command
4212         which given a layout test path will return you
4213         the one bug which our tools would assume it the flaky test bug.
4214         If some other script wants to use bug-for-test we'll
4215         need to extend it with some options like --create-if-missing or similar.
4216
4217         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4218         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4219         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4220         * Scripts/webkitpy/tool/commands/__init__.py:
4221         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
4222
4223 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
4224
4225         Reviewed by James Robinson.
4226
4227         Add option to build-webkit to not build WebKit2
4228         https://bugs.webkit.org/show_bug.cgi?id=50988
4229         
4230         Add support for a --no-webkit2 option to build-webkit. It seems to save
4231         ~1 minute from clean builds and ~10 seconds from no-op builds.
4232
4233         * Scripts/build-webkit:
4234
4235 2010-12-13  Lucas Forschler  <lforschler@apple.com>
4236
4237         Reviewed by Dave Kilzer.
4238
4239         Update iexploder from 1.3.2 to 1.7.2
4240         Move 1.3.2 into its own subdir
4241         Add 1.7.2 into its own subdir
4242         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
4243
4244         * Scripts/run-iexploder-tests:
4245         * Scripts/update-iexploder-cssproperties:
4246         * iExploder/CHANGELOG.txt: Removed.
4247         * iExploder/LICENSE.txt: Removed.
4248         * iExploder/README.txt: Removed.
4249         * iExploder/htdocs: Removed.
4250         * iExploder/iexploder-1.3.2: Added.
4251         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
4252         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
4253         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
4254         * iExploder/iexploder-1.3.2/htdocs: Added.
4255         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
4256         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
4257         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
4258         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
4259         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
4260         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
4261         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
4262         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
4263         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
4264         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
4265         * iExploder/iexploder-1.3.2/tools: Added.
4266         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
4267         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
4268         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
4269         * iExploder/iexploder-1.7.2: Added.
4270         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
4271         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
4272         * iExploder/iexploder-1.7.2/README.txt: Added.
4273         * iExploder/iexploder-1.7.2/output: Added.
4274         * iExploder/iexploder-1.7.2/src: Added.
4275         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
4276         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
4277         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
4278         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
4279         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
4280         * iExploder/iexploder-1.7.2/src/css-properties: Added.
4281         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
4282         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
4283         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
4284         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
4285         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
4286         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
4287         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
4288         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
4289         * iExploder/iexploder-1.7.2/src/css-values: Added.
4290         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
4291         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
4292         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
4293         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
4294         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
4295         * iExploder/iexploder-1.7.2/src/headers: Added.
4296         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
4297         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
4298         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
4299         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
4300         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
4301         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
4302         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
4303         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
4304         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
4305         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
4306         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
4307         * iExploder/iexploder-1.7.2/src/html-tags: Added.
4308         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
4309         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
4310         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
4311         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
4312         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
4313         * iExploder/iexploder-1.7.2/src/html-values: Added.
4314         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
4315         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
4316         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
4317         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
4318         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
4319         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
4320         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
4321         * iExploder/iexploder-1.7.2/src/index.html: Added.
4322         * iExploder/iexploder-1.7.2/src/media: Added.
4323         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
4324         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
4325         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
4326         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
4327         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
4328         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
4329         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
4330         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
4331         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
4332         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
4333         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
4334         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
4335         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
4336         * iExploder/iexploder-1.7.2/src/mime-types: Added.
4337         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
4338         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
4339         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
4340         * iExploder/iexploder-1.7.2/src/protocols: Added.
4341         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
4342         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
4343         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
4344         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
4345         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
4346         * iExploder/iexploder-1.7.2/src/version.rb: Added.
4347         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
4348         * iExploder/iexploder-1.7.2/testcases: Added.
4349         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
4350         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
4351         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
4352         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
4353         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
4354         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
4355         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
4356         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
4357         * iExploder/iexploder-1.7.2/tools: Added.
4358         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
4359         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
4360         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
4361         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
4362         * iExploder/tools: Removed.
4363
4364 2010-12-13  Sam Weinig  <sam@webkit.org>
4365
4366         Reviewed by Anders Carlsson.
4367
4368         Remove associated page concept from WKView constructor
4369         https://bugs.webkit.org/show_bug.cgi?id=50983
4370
4371         Step 1: Remove associate page constructors from WKView and make
4372         all views use the shared namespace for the context.
4373
4374         * TestWebKitAPI/PlatformWebView.h:
4375         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4376         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4377         * WebKitTestRunner/PlatformWebView.h:
4378         * WebKitTestRunner/TestController.cpp:
4379         (WTR::createOtherPage):
4380         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4381         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4382         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4383
4384 2010-12-13  Sam Weinig  <sam@webkit.org>
4385
4386         Reviewed by Anders Carlsson.
4387
4388         Change the WebKit2 public API so there is no explicit WKPageNamespace object
4389         https://bugs.webkit.org/show_bug.cgi?id=50898
4390
4391         * MiniBrowser/mac/AppDelegate.h:
4392         * MiniBrowser/mac/AppDelegate.m:
4393         * MiniBrowser/mac/BrowserWindowController.h:
4394         * MiniBrowser/mac/BrowserWindowController.m:
4395         * MiniBrowser/win/BrowserView.cpp:
4396         Convert MiniBrowser to not use PageNamespaces.
4397
4398         * TestWebKitAPI/PlatformWebView.h:
4399         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
4400         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
4401         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
4402         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
4403         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
4404         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
4405         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
4406         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
4407         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4408         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
4409         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
4410         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
4411         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
4412         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4413         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4414         Convert TestWebKitAPI to not use PageNamespaces.
4415
4416         * WebKitTestRunner/PlatformWebView.h:
4417         * WebKitTestRunner/TestController.cpp:
4418         * WebKitTestRunner/TestController.h:
4419         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4420         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4421         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4422         Convert WebKitTestRunner to not use PageNamespaces.
4423
4424 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4425
4426         Reviewed by Eric Seidel.
4427
4428         webkit-patch rollout should be able to do multi-revision rollouts
4429         https://bugs.webkit.org/show_bug.cgi?id=33336
4430
4431         Make it possible to pass more than one revision to webkit-patch.
4432
4433         * Scripts/webkitpy/common/checkout/api.py:
4434         * Scripts/webkitpy/common/checkout/changelog.py:
4435         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4436         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4437         * Scripts/webkitpy/tool/commands/download.py:
4438         * Scripts/webkitpy/tool/commands/download_unittest.py:
4439         * Scripts/webkitpy/tool/mocktool.py:
4440         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4441         * Scripts/webkitpy/tool/steps/revertrevision.py:
4442
4443 2010-12-13  Eric Seidel  <eric@webkit.org>
4444
4445         Unreviewed.
4446