ebbb116cc5084570c207f50487df8b3526c3d070
[WebKit.git] / Tools / ChangeLog
1 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r77725.
4         http://trac.webkit.org/changeset/77725
5         https://bugs.webkit.org/show_bug.cgi?id=53844
6
7         It broke Qt minimal build (Requested by Ossy_ on #webkit).
8
9         * QtTestBrowser/launcherwindow.cpp:
10         (LauncherWindow::createChrome):
11         * QtTestBrowser/launcherwindow.h:
12         (WindowOptions::WindowOptions):
13         * QtTestBrowser/main.cpp:
14         (LauncherApplication::handleUserOptions):
15
16 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
17
18         Reviewed by Adam Barth.
19
20         [GTK] plugins/plugin-document-back-forward.html fails
21         https://bugs.webkit.org/show_bug.cgi?id=53833
22
23         Add the new "alert on load" functionality for the Unix version of the
24         test plugin. This functionality was originally introduced in r77706.
25
26         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
27         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
28
29 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
30
31         Reviewed by Andreas Kling.
32
33         Local Storage settings can be enable/disable from "Develop" menu
34         https://bugs.webkit.org/show_bug.cgi?id=52296
35
36         * QtTestBrowser/launcherwindow.cpp:
37         (LauncherWindow::createChrome):
38         (LauncherWindow::toggleLocalStorage):
39         (LauncherWindow::toggleOfflineStorageDatabase):
40         (LauncherWindow::toggleOfflineWebApplicationCache):
41         (LauncherWindow::setOfflineStorageDefaultQuota):
42         * QtTestBrowser/launcherwindow.h:
43         (WindowOptions::WindowOptions):
44         * QtTestBrowser/main.cpp:
45         (LauncherApplication::handleUserOptions):
46
47 2011-02-04  Tony Chang  <tony@chromium.org>
48
49         Reviewed by Eric Seidel.
50
51         get test-webkitpy running on win32 python
52         https://bugs.webkit.org/show_bug.cgi?id=53822
53
54         The test harness crashes with a WindowsError because it can't find
55         'svn' when using subprocess.Popen.  This gets us past the error
56         so we can see the failing tests on the Chromium Win Release Tests
57         bot.
58
59         * Scripts/webkitpy/common/system/executive.py:
60
61 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
62
63         Reviewed by Gustavo Noronha Silva.
64
65         [GTK] fast/events/pagehide-timeout.html fails
66         https://bugs.webkit.org/show_bug.cgi?id=53771
67
68         Add knowledge of the document browser cache model the DRT. When resetting
69         WebKit settings to consistent values between tests, default to the document
70         browser cache model.
71
72         * DumpRenderTree/gtk/DumpRenderTree.cpp:
73         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
74         cache model between tests.
75         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
76         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
77         document browser cache model.
78
79 2011-02-04  Adam Barth  <abarth@webkit.org>
80
81         Reviewed by Eric Seidel.
82
83         PluginDocuments don't create widgets for plugins on back/forward
84         https://bugs.webkit.org/show_bug.cgi?id=53474
85
86         Teach the test plugin how to call alert on load.
87
88         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
89         (NPP_New):
90
91 2011-02-04  Adam Roben  <aroben@apple.com>
92
93         Add a test case for encode/decode of FormData/FormDataElement
94
95         If the fix made in r77401 is broken, this new test will crash.
96
97         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
98
99         Reviewed by Sam Weinig.
100
101         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
102         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
103
104         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
105         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
106         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
107         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
108         form, an return the session state data.
109         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
110         and restore it into another WKPage.
111
112         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
113
114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
115         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
116         * TestWebKitAPI/win/copy-resources.cmd:
117         Added new files.
118
119 2011-02-04  Adam Roben  <aroben@apple.com>
120
121         Move code to run JavaScript tests into its own files
122
123         This will allow other tests to use this mechanism.
124
125         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
126         world
127
128         Reviewed by Sam Weinig.
129
130         * TestWebKitAPI/JavaScriptTest.cpp: Added.
131         * TestWebKitAPI/JavaScriptTest.h: Added.
132         Moved code here...
133
134         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
135
136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
137         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
138         Added the new files.
139
140 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
141
142         Reviewed by Mihai Parparita.
143
144         merge test expectations for chromium, chromium-gpu. The
145         chromium-gpu port will no longer maintain its own
146         test expectations file.
147
148         Also add in a graphics_type() call on the port object to
149         determine what graphics type to use in the test configuration,
150         and log the configuration as a config setting.
151
152         https://bugs.webkit.org/show_bug.cgi?id=53562
153
154         * Scripts/webkitpy/layout_tests/port/base.py:
155         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
156         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
157         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
158
159 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
160
161         Reviewed by Pavel Feldman.
162
163         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
164         https://bugs.webkit.org/show_bug.cgi?id=53781
165
166         * Scripts/check-inspector-strings:
167
168 2011-02-04  Adam Roben  <aroben@apple.com>
169
170         Include the crashing function in the link to a crash log on Mac
171
172         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
173         function that crashed on Mac
174
175         Reviewed by David Kilzer.
176
177         * Scripts/old-run-webkit-tests:
178         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
179         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
180         the crash log.
181
182 2011-02-04  Adam Roben  <aroben@apple.com>
183
184         Link to Mac crash logs from results.html
185
186         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
187         results.html
188
189         Reviewed by David Kilzer.
190
191         * Scripts/old-run-webkit-tests:
192         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
193         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
194
195 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
196
197         Reviewed by Dan Bernstein.
198
199         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
200         https://bugs.webkit.org/show_bug.cgi?id=52897
201         <rdar://problem/8898294>
202
203         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
204         (WTR::InjectedBundlePage::InjectedBundlePage):
205         (WTR::InjectedBundlePage::willSendRequestForFrame):
206         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
207
208 2011-02-03  Ivan Krstić  <ike@apple.com>
209
210         Unreviewed.
211
212         Adding myself to committers.py.
213
214         * Scripts/webkitpy/common/config/committers.py:
215
216 2011-02-03  James Kozianski  <koz@chromium.org>
217
218         Reviewed by Dimitri Glazkov.
219
220         Add navigator.registerProtocolHandler behind a flag.
221         https://bugs.webkit.org/show_bug.cgi?id=52609
222
223         * Scripts/build-webkit:
224
225 2011-02-03  Hayato Ito  <hayato@chromium.org>
226
227         Reviewed by Eric Seidel.
228
229         [NRWT] Remove TestArgs class, which is wrongly used.
230
231         https://bugs.webkit.org/show_bug.cgi?id=53063
232
233         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
234         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
235         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
236         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
237         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
238         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
239
240 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
241
242         Reviewed by Kenneth Russell.
243
244         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
245         https://bugs.webkit.org/show_bug.cgi?id=53714
246
247         * Scripts/build-webkit: change --3d-canvas build option
248           to set ENABLE_WEBGL
249
250 2011-02-03  Hayato Ito  <hayato@chromium.org>
251
252         Reviewed by Tony Chang.
253
254         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
255         move _run_single_test() and _process_output() functions from
256         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
257
258         This is clean up and acts as a preparation for elimination of test_types/*
259         classes. These classes will move to the single_test_runner module introduced
260         in this patch.
261
262         https://bugs.webkit.org/show_bug.cgi?id=53004
263
264         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
265         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
266         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
267         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
268         * Scripts/webkitpy/layout_tests/port/base.py:
269         * Scripts/webkitpy/layout_tests/port/chromium.py:
270         * Scripts/webkitpy/layout_tests/port/dryrun.py:
271         * Scripts/webkitpy/layout_tests/port/test.py:
272         * Scripts/webkitpy/layout_tests/port/webkit.py:
273         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
274         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
275         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
276
277 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
278
279         Unreviewed, build fix.
280
281         Delete a line that was accidentally missed in r77586; without it
282         there is still a race between the two threads.
283
284         https://bugs.webkit.org/show_bug.cgi?id=51572
285
286         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
287
288 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
289
290         Reviewed by Tony Chang.
291
292         nrwt: handle "broken pipe" notifications from DRT more cleanly.
293
294         https://bugs.webkit.org/show_bug.cgi?id=52927
295
296         * Scripts/webkitpy/layout_tests/port/server_process.py:
297         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
298
299 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
300
301         Reviewed by Kenneth Russell.
302
303         Update, resubmit change to bug 51572. I think the race that was
304         fixed in r76703 caused the hang that caused us to roll this
305         patch out before, so I'd like to try again.
306
307         https://bugs.webkit.org/show_bug.cgi?id=51572
308
309         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
310         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
311
312 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
313
314         Unreviewed.
315
316         Adding myself to committers.py.
317
318         * Scripts/webkitpy/common/config/committers.py:
319
320 2011-02-03  Adam Roben  <aroben@apple.com>
321
322         Include the crashing function in the link to a crash log
323
324         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
325         function that crashed
326
327         Reviewed by David Kilzer.
328
329         * Scripts/old-run-webkit-tests:
330         (crashLocation): Added. Returns the location of the crash.
331         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
332         could be determined.
333
334 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
335
336         Unreviewed, build fix.
337
338         Actually make the changes suggested by Mihai in his review
339         of bug 53720 :(
340
341         https://bugs.webkit.org/show_bug.cgi?id=53720
342
343         * Scripts/webkitpy/layout_tests/port/test_files.py:
344         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
345
346 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
347
348         Reviewed by Mihai Parparita.
349
350         new-run-webkit-tests: Fix bug introduced in r77434 that was
351         causing us to run the canvas GPU tests on the Mac GPU port. This
352         bug revealed that we were not setting the port.name() field
353         properly in many cases, so I've cleaned up all of that code, and
354         removed a few comments about "version-specific" GPU ports that
355         don't exist and just confused things.
356
357         Testing also revealed that port.abspath_for_test() wasn't
358         normalizing paths on Windows properly, so I fixed that as well.
359
360         https://bugs.webkit.org/show_bug.cgi?id=53719
361
362         * Scripts/webkitpy/layout_tests/port/base.py:
363         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
364         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
365
366 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
367
368         Reviewed by Mihai Parparita.
369
370         new-run-webkit-tests: fix normalization of paths on windows when gathering files
371
372         r77434 introduced a bug that was causing the test expectations
373         for the GPU ports to not be treated properly. It turns out that
374         when we gathered the list of test files on Windows, we would
375         return paths of the form "c:\LayoutTests/fast/canvas", and the
376         mixture of backslashes and forward slashes was confusing things.
377
378         This patch normalizes all of the filenames returned from
379         test_files.find(), and adds better tests for this (fixing a
380         couple of other bugs found in the meantime).
381
382         https://bugs.webkit.org/show_bug.cgi?id=53720
383
384         * Scripts/webkitpy/layout_tests/port/test.py:
385         * Scripts/webkitpy/layout_tests/port/test_files.py:
386         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
387
388 2011-02-03  Adam Roben  <aroben@apple.com>
389
390         Add links to Windows crash logs in results.html
391
392         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
393         results.html
394
395         Reviewed by David Kilzer.
396
397         * Scripts/old-run-webkit-tests:
398         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
399         createDebuggerCommandFile).
400         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
401         tool has exited.
402         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
403         it into the test results directory tree. Only implemented for Cygwin currently.
404         (findNewestFileMatchingGlob): Added. Does what it says.
405         (htmlForResultsSection): Only link to files that exist.
406         (linksForErrorTest): Add a link to the crash log.
407         (deleteExpectedAndActualResults): Delete any old crash log for this test.
408         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
409         hardcoding it here.
410
411 2011-02-03  Adam Roben  <aroben@apple.com>
412
413         Tell the debugger the path to the WebKit source tree when saving a crash log
414
415         This allows the debugger to include the crashing line of code in the log.
416
417         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
418         of code
419
420         Reviewed by Sam Weinig.
421
422         * Scripts/old-run-webkit-tests:
423         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
424         file and returns the path to that file. The commands we pass came from
425         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
426         WebKit source code lives.
427         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
428         line using -c, save them to a file and specify the path to that file using -cf. This works
429         around what is presumably a bug in Windows's command line parsing, where having multiple
430         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
431         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
432         together to make them easier to modify in the future.
433
434 2011-02-02  Sam Weinig  <sam@webkit.org>
435
436         Reviewed by Anders Carlsson.
437
438         Add notification of the end of a rubber band.
439         <rdar://problem/8940648>
440
441         * MiniBrowser/mac/BrowserWindowController.m:
442         (-[BrowserWindowController awakeFromNib]):
443         * WebKitTestRunner/TestController.cpp:
444         (WTR::TestController::createOtherPage):
445         (WTR::TestController::initialize):
446         Stub out the new WKUIClient function.
447
448 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
449
450         Unreviewed.
451
452         Adding myself to committers.py.
453
454         * Scripts/webkitpy/common/config/committers.py:
455
456 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
457
458         Reviewed by Csaba Osztrogonác.
459
460         [Qt][WK2] MiniBrowser's window size should be 800x600
461         https://bugs.webkit.org/show_bug.cgi?id=53670
462
463         Make layout test failure debugging easier.
464         * MiniBrowser/qt/BrowserWindow.cpp:
465         (BrowserWindow::BrowserWindow):
466
467 2011-02-02  Andy Estes  <aestes@apple.com>
468
469         Reviewed by Mark Rowe.
470
471         'update-webkit' should handle OpenSource and Internal using different
472         VCSs.
473
474         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
475         Internal directory.
476
477 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
478
479         Reviewed by Mihai Parparita.
480
481         new-run-webkit-tests: hardcode the directories to scan for tests
482         for GPU bots instead of SKIPping them. See bug 53562 for some
483         context, but we will now hard-code the list of directories to
484         use by default instead of skipping over directories in the
485         expectations file. We do this so that we will be able to merge
486         the expectations files without getting conflicting SKIP
487         directives. Note that this change will reduce the # of tests
488         being run on the Mac GPU bots, because we're accidentally
489         including some today.
490
491         https://bugs.webkit.org/show_bug.cgi?id=53631
492
493         * Scripts/webkitpy/layout_tests/port/base.py:
494         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
495         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
496
497 2011-02-02  Sam Weinig  <sam@webkit.org>
498
499         Reviewed by Beth Dakin.
500
501         Add ChromeClient function to paint custom overhang areas.
502         https://bugs.webkit.org/show_bug.cgi?id=53639
503
504         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
505         (WTR::InjectedBundlePage::InjectedBundlePage):
506         Stub out new callback.
507
508 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
509
510         Reviewed by Tony Chang.
511
512         new-run-webkit-tests: support chromium code paths in mock_drt
513
514         https://bugs.webkit.org/show_bug.cgi?id=53471
515
516         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
517         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
518
519 2011-02-02  Adam Klein  <adamk@chromium.org>
520
521         Reviewed by Tony Chang.
522
523         Update new-run-webkit-tests --chromium to put output under Source/...
524         https://bugs.webkit.org/show_bug.cgi?id=53612
525
526         * BuildSlaveSupport/test-result-archive:
527         * Scripts/webkitpy/layout_tests/port/chromium.py:
528
529 2011-01-28  Tony Chang  <tony@chromium.org>
530
531         Reviewed by Eric Seidel.
532
533         [chromium] remove --use-test-shell from NRWT
534         https://bugs.webkit.org/show_bug.cgi?id=53346
535
536         I've already started removing some of the bindings like eventSender so
537         this already doesn't work isn't useful.  Also updated some comments to
538         refer to DRT instead of test_shell.
539
540         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
541         * Scripts/webkitpy/layout_tests/port/chromium.py:
542         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
543         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
544         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
545         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
546         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
547         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
548
549 2011-02-02  Steve Lacey  <sjl@chromium.org>
550
551         Reviewed by Eric Carlson.
552
553         Implement basic media statistics on media elements.
554         https://bugs.webkit.org/show_bug.cgi?id=53322
555
556         * Scripts/build-webkit:
557
558 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
559
560         [wx] Build fixes for wxWebKit.
561
562         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
563         (LayoutTestController::setSerializeHTTPLoads):
564         * wx/browser/wscript:
565         * wx/build/build_utils.py:
566         * wx/build/settings.py:
567
568 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
569
570         Reviewed by Mihai Parparita.
571
572         new-run-webkit-tests: stop skipping so many tests
573
574         r77163 introduced a regression where we weren't resetting test
575         expectations properly and were skipping too many tests as a
576         result. This patch fixes that and adds a test for it.
577
578         https://bugs.webkit.org/show_bug.cgi?id=53551
579
580         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
581         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
582
583 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
584
585         Reviewed by Tony Chang.
586
587         new-run-webkit-tests: add first stub of test_runner2. This
588         will add support for the 'inline', 'threads', and 'processes'
589         flags to --worker-model, but for now the implementatios just
590         fall back on the old ones.
591
592         https://bugs.webkit.org/show_bug.cgi?id=53157
593
594         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
595         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
596
597 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
598
599         Reviewed by James Robinson.
600
601         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
602         https://bugs.webkit.org/show_bug.cgi?id=53522
603
604         * Scripts/run-chromium-webkit-unit-tests:
605
606 2011-02-01  Adam Barth  <abarth@webkit.org>
607
608         Reviewed by Mihai Parparita.
609
610         Using Control-C to cancel webkit-patch or other python tools causes
611         unpleasant traceback console spew
612         https://bugs.webkit.org/show_bug.cgi?id=53462
613
614         Catch the exception and don't print the stack trace.
615
616         * Scripts/webkit-patch:
617
618 2011-02-01  Scott Cameron  <sccameron@rim.com>
619
620         Reviewed by Daniel Bates.
621
622         Use Windows format for MinGW HTTPD path.
623         https://bugs.webkit.org/show_bug.cgi?id=53503
624
625         * Scripts/webkitperl/httpd.pm:
626           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
627             so that we don't have to escape the space characters in the path. Also,
628             changed path to Windows-style path and removed FIXME comment.
629
630 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
631
632         Reviewed by Andreas Kling.
633
634         [Qt][WK2] Add a way to use shared process model in MiniBrowser
635         https://bugs.webkit.org/show_bug.cgi?id=53090
636
637         * MiniBrowser/qt/BrowserView.cpp:
638         (BrowserView::BrowserView): Removed the m_context member.
639         From now the context is guaranteed to be non-null and we
640         don't need to store that in the object.
641         * MiniBrowser/qt/BrowserView.h:
642         * MiniBrowser/qt/BrowserWindow.cpp:
643         Added static bool to determine that new windows need to be
644         created with their own context or not. Use the same context
645         and web process by default to be inilne with the other ports.
646         (BrowserWindow::BrowserWindow):
647         (BrowserWindow::newWindow):
648         * MiniBrowser/qt/BrowserWindow.h:
649         * MiniBrowser/qt/main.cpp:
650         (main): Added command line switch to be able to use the
651         non-shared process model. Simplify the handling of the command line
652         switches a little bit.
653
654 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
655
656         Reviewed by Andreas Kling.
657
658         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
659         https://bugs.webkit.org/show_bug.cgi?id=53491
660
661         * MiniBrowser/qt/BrowserWindow.cpp:
662         (BrowserWindow::BrowserWindow):
663         (BrowserWindow::toggleFullScreenMode):
664         * MiniBrowser/qt/BrowserWindow.h:
665
666 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
667
668         Reviewed by Andreas Kling.
669
670         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
671         https://bugs.webkit.org/show_bug.cgi?id=53489
672
673         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
674         to Settings menu.
675
676         * MiniBrowser/qt/BrowserWindow.cpp:
677         (BrowserWindow::BrowserWindow):
678         (BrowserWindow::toggleFrameFlattening):
679         (BrowserWindow::toggleDisableJavaScript):
680         (BrowserWindow::toggleAutoLoadImages):
681         * MiniBrowser/qt/BrowserWindow.h:
682
683 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
684
685         Reviewed by Tony Chang.
686
687         [Chromium] Switch chromium-mac to use ChromiumDriver
688         https://bugs.webkit.org/show_bug.cgi?id=53461
689         
690         For the sake of consistency with the other Chromium platforms (and so
691         that chromium-mac picks up special flags like --enable-hardware-gpu),
692         switch chromium-mac from the WebKitDriver to ChromiumDriver.
693
694         * Scripts/webkitpy/layout_tests/port/chromium.py:
695
696 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
697
698         Reviewed by Mihai Parparita.
699
700         The current modifier parsing code in test_expectations is
701         fragile and hard-coded, so it's not easy to understand the logic
702         or easily add new types of modifiers (like GPU vs. CPU testing
703         for graphics tests, or 32-bit vs. 64-bit differences).
704
705         This is the first of two patches that will add in more generic
706         support and then eliminate the GPU-specific test expectations
707         files for Chromium.
708
709         This patch adds two standalone objects for handling modifiers. The
710         rules for interpreting modifiers, precedence, and conflicts are
711         given in the docstring to the ModifierMatcher class, which
712         returns ModifierMatchResult objects.
713         
714         This patch also adds routines to the Port interface and a
715         default set of values in the base object, in order to obtain the
716         values needed on a given test run. These values are then passed
717         to the expectation parser. This also allows us to clean up the
718         logic used to lint all of the different configurations in a
719         single test_expectations.txt file.
720
721         The next patch will merge in the separate GPU expectations file.
722
723         https://bugs.webkit.org/show_bug.cgi?id=51222
724
725         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
726         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
727         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
728         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
729         * Scripts/webkitpy/layout_tests/port/base.py:
730         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
731         * Scripts/webkitpy/layout_tests/port/chromium.py:
732         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
733         * Scripts/webkitpy/layout_tests/port/test.py:
734         * Scripts/webkitpy/layout_tests/port/webkit.py:
735         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
736         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
738         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
739         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
740
741 2011-01-31  Scott Cameron  <sccameron@rim.com>
742
743         Reviewed by Daniel Bates.
744
745         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
746         https://bugs.webkit.org/show_bug.cgi?id=50036
747
748         This will add an Apache2.2 configuration file and modifies scripts to allow
749         running an httpd server in an MSYS environment.
750
751         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
752         in order to allow for simple installation/execution.  Simply install the latest
753         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
754         be able to execute run-webkit-httpd.
755         
756
757         * Scripts/run-webkit-httpd:
758         * Scripts/webkitperl/httpd.pm:
759
760 2011-01-31  Tony Chang  <tony@chromium.org>
761
762         Reviewed by Eric Seidel.
763
764         mac DRT should report RTL scroll offset relative to top right corner
765         https://bugs.webkit.org/show_bug.cgi?id=53324
766
767         * DumpRenderTree/mac/DumpRenderTree.mm:
768         (dumpFrameScrollPosition):
769
770 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
771
772         Reviewed by Andreas Kling.
773
774         [Qt] Add Take Screen Shot action to MiniBrowser
775         https://bugs.webkit.org/show_bug.cgi?id=53422
776
777         Add Take Screen Shot action to MiniBrowser's view menu.
778
779         * MiniBrowser/qt/BrowserWindow.cpp:
780         (BrowserWindow::BrowserWindow):
781         (BrowserWindow::screenshot):
782         * MiniBrowser/qt/BrowserWindow.h:
783
784 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
785
786         Reviewed by Xan Lopez.
787
788         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
789         https://bugs.webkit.org/show_bug.cgi?id=53379
790
791         Remove left over #ifdef's. I thought all of the conditional code
792         had been freed from the condition, but I forgot to check DRT.
793
794         * DumpRenderTree/gtk/DumpRenderTree.cpp:
795         (resetDefaultsToConsistentValues):
796         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
797         (LayoutTestController::setAlwaysAcceptCookies):
798
799 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
800
801         Unreviewed, build fix.
802
803         Fix regression introduced in r77093 - path.rsplit() doesn't
804         take keyword arguments.
805
806         https://bugs.webkit.org/show_bug.cgi?id=53326
807
808         * Scripts/webkitpy/common/system/filesystem_mock.py:
809
810 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
811
812         Reviewed by Mihai Parparita.
813
814         Add more unit tests for rebaseline-chromium-webkit-tests. This
815         change involves restructuring a bunch of r-c-w-t code to make it
816         more testable as well. We also add wrapper classes for handling
817         testing zip files and fetching URLs.
818
819         https://bugs.webkit.org/show_bug.cgi?id=53040
820
821         * Scripts/webkitpy/common/system/urlfetcher.py:
822         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
823         * Scripts/webkitpy/common/system/zipfileset_mock.py:
824         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
825         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
826         * Scripts/webkitpy/tool/mocktool.py:
827
828 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
829
830         Reviewed by Eric Seidel.
831
832         Clean up of the filesystem-related modules used in webkitpy.
833         I've added relpath() to the filesystem interface, modified
834         ospath.relpath() so that it could work with the filesystem
835         interface, and modified the fileset* routines to use the
836         filesystem interface consistently.
837
838         This patch also adds a close() routine to the fileset routines
839         to indicate that the caller is done with the fileset. This
840         allows zipfileset to clean up after itself when it creates
841         tempfiles to store downloads.
842
843         https://bugs.webkit.org/show_bug.cgi?id=53326
844
845         * Scripts/webkitpy/common/system/directoryfileset.py:
846         * Scripts/webkitpy/common/system/fileset.py:
847         * Scripts/webkitpy/common/system/filesystem.py:
848         * Scripts/webkitpy/common/system/filesystem_mock.py:
849         * Scripts/webkitpy/common/system/filesystem_unittest.py:
850         * Scripts/webkitpy/common/system/ospath.py:
851         * Scripts/webkitpy/common/system/zipfileset.py:
852         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
853
854 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
855
856         Reviewed by Csaba Osztrogonác.
857
858         [Qt][WK2]REGRESSION (r76991): Fix build errors
859         https://bugs.webkit.org/show_bug.cgi?id=53400
860
861         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
862         and remove WebKit2Prefix.h from the build.
863         * MiniBrowser/qt/MiniBrowser.pro:
864
865 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
866
867         Unreviewed.
868
869         [Qt][WK2] Buildfix.
870
871         * MiniBrowser/qt/MiniBrowser.pro:
872
873 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
874
875         Reviewed by Adam Roben.
876         
877         define NOMINMAX when building ImageDiff, as we do elsewhere.
878
879         Add various clampToInt() methods to MathExtras.h
880         https://bugs.webkit.org/show_bug.cgi?id=52910
881
882         * DumpRenderTree/win/ImageDiffCommon.vsprops:
883
884 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
885
886         Reviewed by Darin Adler.
887
888         WebKitTestRunner needs layoutTestController.setPOSIXLocale
889         https://bugs.webkit.org/show_bug.cgi?id=42682
890
891         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
892         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
893         (WTR::InjectedBundle::resetLocalSettings):
894         (WTR::InjectedBundle::didReceiveMessage):
895         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
896         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
897         (WTR::LayoutTestController::setPOSIXLocale):
898         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
899
900 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
901  
902          Reviewed by Mihai Parparita.
903  
904          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
905  
906          This patch re-enables this test and changes it to
907          handle all of the mac platform versions, not just the one
908          it is running on.
909  
910          https://bugs.webkit.org/show_bug.cgi?id=53356
911  
912          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
913  
914 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
915
916         Unreviewed, build fix.
917
918         Take two. The fix in 77023 didn't work, because we were
919         still calling path.abspath_to_uri, which calls _cygpath under
920         the covers, and it appears the cygpath on the bots does
921         something different than it does on my machine. This patch
922         removes the calls to path.abspath_to_uri, so it should be safe.
923         If it doesn't work, I'll roll it out along with r76982 and 77023.
924
925         https://bugs.webkit.org/show_bug.cgi?id=53126
926
927         * Scripts/webkitpy/layout_tests/port/test.py:
928
929 2011-01-28  David Kilzer  <ddkilzer@apple.com>
930
931         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
932         <http://webkit.org/b/53353>
933
934         Reviewed by Mark Rowe.
935
936         * Scripts/webkitdirs.pm:
937         (checkRequiredSystemConfig): Check the Xcode marketing version
938         in addition to the DevCoreTools build version before complaining
939         about an old version of Xcode.  Also make the Mac OS X version
940         check use Perl's built-in version string comparitor.
941
942 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
943
944         Unreviewed, build fix.
945
946         Work around breakage on Win 7 Release bot caused by r76982
947         and the fact that windows ports use "file:////" instead of
948         "file:///". Ideally the test code should be isolated from
949         this, but it isn't yet. Will fix properly in a bit.
950
951         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
952
953 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
954
955         Reviewed by Tony Chang.
956
957         new-run-webkit-tests: change worker model values to
958         "old-inline", "old-threads" in preparation for test_runner2 /
959         multiprocessing changes.
960
961         https://bugs.webkit.org/show_bug.cgi?id=53156
962
963         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
964         * Scripts/webkitpy/layout_tests/port/base.py:
965         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
966         * Scripts/webkitpy/layout_tests/port/mac.py:
967         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
968
969 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
970
971         Reviewed by Tony Chang.
972
973         committers.py - add an IRC nickname for dpranke
974         https://bugs.webkit.org/show_bug.cgi?id=53335
975
976         * Scripts/webkitpy/common/config/committers.py:
977
978 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
979
980         Reviewed by Tony Chang.
981
982         new-run-webkit-tests: add a "mock DRT" port implementation
983         and a separate class that emulates what we expect the
984         DumpRenderTree behavior to be.
985
986         This will eventually replace port/dryrun.py and allow us to get
987         better test coverage of the new-run-webkit-tests code as well as
988         a reference for what new-run-webkit-tests expects from DRT.
989
990         This is the first attempt at this, and it is pretty bare-boned. It
991         really only has been tested on the 'mac' port (and a little on
992         the 'chromium-mac' port.
993
994         https://bugs.webkit.org/show_bug.cgi?id=53126
995
996         * Scripts/webkitpy/common/system/filesystem_mock.py:
997         * Scripts/webkitpy/layout_tests/port/dryrun.py:
998         * Scripts/webkitpy/layout_tests/port/factory.py:
999         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1000         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1001         * Scripts/webkitpy/layout_tests/port/test.py:
1002
1003 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1004
1005         Unreviewed. Removing .swp file checked in by mistake.
1006
1007         * Scripts/.webkitdirs.pm.swp: Removed.
1008
1009 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1010
1011         Reviewed by David Kilzer.
1012
1013         Space not necessary for undefined feature
1014         https://bugs.webkit.org/show_bug.cgi?id=53317
1015
1016         * Scripts/build-webkit:
1017
1018 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1019
1020         Reviewed by Andreas Kling.
1021
1022         Reset NetworkAccessManager to clean up credentials from previous tests.
1023         This change causes no performance overhead either.
1024         https://bugs.webkit.org/show_bug.cgi?id=36688
1025
1026         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1027         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1028         (WebCore::DumpRenderTree::open):
1029         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1030
1031 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1032
1033         Reviewed by Andreas Kling.
1034
1035         [Qt] Add Zoom Text Only action to MiniBrowser
1036         https://bugs.webkit.org/show_bug.cgi?id=53297
1037
1038         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1039
1040         * MiniBrowser/qt/BrowserWindow.cpp:
1041         (BrowserWindow::BrowserWindow):
1042         (BrowserWindow::zoomIn):
1043         (BrowserWindow::zoomOut):
1044         (BrowserWindow::resetZoom):
1045         (BrowserWindow::toggleZoomTextOnly):
1046         (BrowserWindow::applyZoom):
1047         * MiniBrowser/qt/BrowserWindow.h:
1048
1049 2011-01-28  Adam Barth  <abarth@webkit.org>
1050
1051         Reviewed by Eric Seidel.
1052
1053         Add webkit-patch roll-chromium-deps
1054         https://bugs.webkit.org/show_bug.cgi?id=53288
1055
1056         This command updates the Source/WebKit/chromium/DEPS file with the
1057         last-known good revision of Chromium (or a revision specified on the
1058         command line).  I'd eventually like to turn this into a SheriffBot
1059         command, but this is the first step.
1060
1061         This patch somewhat sprawled because I needed to move a bunch of code
1062         out of ChangeLog that should never have been there in the first place.
1063         Also, I had to fix a bug in MockUser in order to test the new command.
1064
1065         * Scripts/webkitpy/common/checkout/api.py:
1066         * Scripts/webkitpy/common/checkout/changelog.py:
1067         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1068         * Scripts/webkitpy/common/checkout/deps.py: Added.
1069         * Scripts/webkitpy/common/config/urls.py:
1070         * Scripts/webkitpy/tool/commands/__init__.py:
1071         * Scripts/webkitpy/tool/commands/download_unittest.py:
1072         * Scripts/webkitpy/tool/commands/roll.py: Added.
1073         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1074         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1075         * Scripts/webkitpy/tool/mocktool.py:
1076         * Scripts/webkitpy/tool/steps/__init__.py:
1077         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1078         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1079         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1080         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1081         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1082         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1083
1084 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1085
1086         Reviewed by Laszlo Gombos.
1087
1088         Get rid of prefix header dependency for WebKit2 build system
1089         https://bugs.webkit.org/show_bug.cgi?id=50174
1090
1091         Change the style checker so that it enforces config.h include for
1092         WebKit2.
1093
1094         * Scripts/webkitpy/style/checker.py:
1095
1096 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1097
1098         Reviewed by Darin Adler.
1099
1100         execCommand("Paste") doesn't work in WebKitTestRunner
1101         https://bugs.webkit.org/show_bug.cgi?id=52785
1102
1103         Enable both of the settings needed to allow paste.
1104         
1105         * WebKitTestRunner/TestController.cpp:
1106         (WTR::TestController::resetStateToConsistentValues):
1107
1108 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1109
1110         Reviewed by Andreas Kling.
1111
1112         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1113         https://bugs.webkit.org/show_bug.cgi?id=48440
1114
1115         Preserve user input when toggling use of QGraphicsView
1116
1117         * QtTestBrowser/launcherwindow.cpp:
1118         (LauncherWindow::initializeView):
1119         (LauncherWindow::loadFinished):
1120         * QtTestBrowser/launcherwindow.h:
1121         * QtTestBrowser/mainwindow.cpp:
1122         (MainWindow::addressUrl):
1123         * QtTestBrowser/mainwindow.h:
1124
1125 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1126
1127         Reviewed by Mihai Parparita.
1128
1129         new-run-webkit-tests: turn off pixel tests correctly by default
1130         for webkit-based ports. r70013 (bug 47510) used
1131         port.set_option_default() to attempt to set default values, but
1132         that didn't work correctly. I have removed set_option_default
1133         for now since it was only being used in two places and in three
1134         useless unit tests. There is a separate bug open to fix the
1135         option parsing (48095), so this workaround is fine for now.
1136
1137         https://bugs.webkit.org/show_bug.cgi?id=53217
1138
1139         * Scripts/webkitpy/layout_tests/port/webkit.py:
1140         * Scripts/webkitpy/layout_tests/port/base.py:
1141         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1142
1143 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1144
1145         Rubber-stamped by Ariya Hidayat.
1146
1147         Trivial crash fix in WTR.
1148
1149         * WebKitTestRunner/TestController.cpp:
1150         (WTR::TestController::initialize): Increase the size
1151         of the vector by one to be able to store the null character.
1152
1153 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1154
1155         Reviewed by Csaba Osztrogonác.
1156
1157         [Qt][WK2] WTR should be initialized in the same way as DRT
1158         https://bugs.webkit.org/show_bug.cgi?id=53240
1159
1160         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1161         (WTR::activateFonts): Added missing initialization steps.
1162
1163 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1164
1165         Unreviewed. 
1166
1167         Adding myself to committers.py.
1168
1169         * Scripts/webkitpy/common/config/committers.py:
1170
1171 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1172
1173         Reviewed by Csaba Osztrogonác.
1174
1175         [Qt] [Symbian] Move project files into Source
1176         https://bugs.webkit.org/show_bug.cgi?id=52891
1177
1178         Fix the Symbian build after the project files
1179         are moved to Source directory. On Symbian qmake
1180         needs to run in the same directory where the main
1181         pro files (WebKit.pro, Tools.pro) are located.
1182
1183         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1184         is located before running qmake for Symbian. Qmake on Symbian
1185         does not properly honor the "-o" option, work it around by setting
1186         the name of the Makefile to bld.inf.
1187
1188 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1189
1190         Reviewed by Andreas Kling.
1191
1192         [Qt] Add simple zooming features to MiniBrowser
1193         https://bugs.webkit.org/show_bug.cgi?id=53231
1194
1195         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1196
1197         * MiniBrowser/qt/BrowserWindow.cpp:
1198         (BrowserWindow::BrowserWindow):
1199         (BrowserWindow::zoomIn):
1200         (BrowserWindow::zoomOut):
1201         (BrowserWindow::resetZoom):
1202         (BrowserWindow::updateUserAgentList):
1203         (BrowserWindow::applyZoom):
1204         * MiniBrowser/qt/BrowserWindow.h:
1205
1206 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1207
1208         Reviewed by Dan Bernstein.
1209
1210         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1211         https://bugs.webkit.org/show_bug.cgi?id=42319
1212         
1213         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1214
1215         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1216         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1217         (WTR::LayoutTestController::showWebInspector):
1218         (WTR::LayoutTestController::closeWebInspector):
1219         (WTR::LayoutTestController::evaluateInWebInspector):
1220         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1221         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1222         * WebKitTestRunner/TestInvocation.cpp:
1223         (WTR::shouldOpenWebInspector):
1224         (WTR::TestInvocation::invoke):
1225         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1226
1227 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1228
1229         Reviewed by Xan Lopez.
1230
1231         [GTK] Pixel dumps do not include scrollbars in output images
1232         https://bugs.webkit.org/show_bug.cgi?id=53216
1233
1234         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1235         that have scrollbars.
1236
1237         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1238         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1239         instead of the web view itself.
1240
1241 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1242
1243         Reviewed by Mihai Parparita.
1244
1245         Fix regression introduced in r76322 ... new-run-webkit-tests
1246         was attempting to save the image diff output as a UTF-8-encoded
1247         file.
1248
1249         https://bugs.webkit.org/show_bug.cgi?id=53210
1250
1251         * Scripts/webkitpy/layout_tests/port/webkit.py:
1252
1253 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1254
1255         Unreviewed, rolling out r76709.
1256         http://trac.webkit.org/changeset/76709
1257         https://bugs.webkit.org/show_bug.cgi?id=53194
1258
1259         "broke python tests on non-snowleopard platforms" (Requested
1260         by dpranke on #webkit).
1261
1262         * Scripts/webkitpy/layout_tests/port/factory.py:
1263         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1264         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1265
1266 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1267
1268         Reviewed by Tony Chang.
1269
1270         new-run-webkit-tests: add a "mock DRT" port implementation
1271         and a separate class that emulates what we expect the
1272         DumpRenderTree behavior to be.
1273
1274         This will eventually replace port/dryrun.py and allow us to get
1275         better test coverage of the new-run-webkit-tests code as well as
1276         a reference for what new-run-webkit-tests expects from DRT.
1277
1278         This is the first attempt at this, and it is pretty bare-boned. It
1279         really only has been tested on the 'mac' port (and a little on
1280         the 'chromium-mac' port.
1281
1282         https://bugs.webkit.org/show_bug.cgi?id=53126
1283
1284         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1285         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1286         * Scripts/webkitpy/layout_tests/port/factory.py:
1287
1288 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1289
1290         Reviewed by Tony Chang.
1291
1292         Add '--no-timeout' option to Chromium DRT to ease debugging.
1293         https://bugs.webkit.org/show_bug.cgi?id=52873
1294
1295         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1296         (main):
1297
1298 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1299
1300         Reviewed by Andreas Kling.
1301
1302         [Qt] Fix qt_minimal build
1303         https://bugs.webkit.org/show_bug.cgi?id=53172
1304
1305         * QtTestBrowser/locationedit.h:
1306
1307 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1308
1309         Reviewed by Antonio Gomes.
1310
1311         QtTestBrowser should have a UI Setting to disable plugins
1312         https://bugs.webkit.org/show_bug.cgi?id=52408
1313         
1314         Added a new action item named "Disable Plugins"
1315         under the "Settings" menu. 
1316
1317         * QtTestBrowser/launcherwindow.cpp:
1318         (LauncherWindow::createChrome):
1319         (LauncherWindow::togglePlugins):
1320         * QtTestBrowser/launcherwindow.h:
1321
1322 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1323
1324         Reviewed by Adam Barth.
1325
1326         Move main CMakeLists.txt into Source directory
1327         https://bugs.webkit.org/show_bug.cgi?id=52888
1328
1329         * Scripts/webkitdirs.pm:
1330
1331 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1332
1333         Reviewed by Eric Seidel.
1334
1335         Improve label text in submit-to-ews
1336         https://bugs.webkit.org/show_bug.cgi?id=53130
1337
1338         * QueueStatusServer/templates/submittoews.html:
1339
1340 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1341
1342         Reviewed by Antonio Gomes.
1343
1344         QtTestBrowser should have a UI Settings to prevent loading images
1345         https://bugs.webkit.org/show_bug.cgi?id=52409
1346         
1347         Added a new action item named "DisableAutoLoadImages"
1348         under the "Settings" menu 
1349
1350         * QtTestBrowser/launcherwindow.cpp:
1351         (LauncherWindow::createChrome):
1352         (LauncherWindow::toggleAutoLoadImages):
1353         * QtTestBrowser/launcherwindow.h:
1354
1355 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1356
1357         Reviewed by Tony Chang.
1358
1359         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1360         classes, test_expectations.py. This change adds "test-win" and
1361         "test-mac" variants to the test port so that we can better test
1362         rebaselining, and adds a MockUser() object for reuse in testing.
1363
1364         https://bugs.webkit.org/show_bug.cgi?id=53036
1365
1366         * Scripts/webkitpy/common/system/filesystem.py:
1367         * Scripts/webkitpy/common/system/filesystem_mock.py:
1368         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1369         * Scripts/webkitpy/layout_tests/port/factory.py:
1370         * Scripts/webkitpy/layout_tests/port/base.py:
1371         * Scripts/webkitpy/layout_tests/port/test.py:
1372         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1373         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1374         * Scripts/webkitpy/tool/mocktool.py:
1375
1376 2011-01-25  Tony Chang  <tony@chromium.org>
1377
1378         Reviewed by Dimitri Glazkov.
1379
1380         [chromium] remove unused layoutTestController callback
1381         https://bugs.webkit.org/show_bug.cgi?id=53103
1382
1383         This method is used by a test_shell_test, but not needed by DRT.
1384
1385         * DumpRenderTree/chromium/LayoutTestController.cpp:
1386         (LayoutTestController::LayoutTestController):
1387         * DumpRenderTree/chromium/LayoutTestController.h:
1388
1389 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1390
1391         Reviewed by Andreas Kling.
1392
1393         [GTK] Remove 64 bits release bot from the buildbot master
1394         https://bugs.webkit.org/show_bug.cgi?id=52899
1395
1396         Removes the 64 bits release slave from the buildbot configuration,
1397         so that we can use it as an EWS.
1398
1399         * BuildSlaveSupport/build.webkit.org-config/config.json:
1400
1401 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1402
1403         Reviewed by Dan Bernstein.
1404
1405         Implement database quota callback to fix storage tests on WebKit2 bot
1406         https://bugs.webkit.org/show_bug.cgi?id=53064
1407
1408         * WebKitTestRunner/TestController.cpp:
1409         (WTR::exceededDatabaseQuota):
1410         (WTR::TestController::createOtherPage):
1411         (WTR::TestController::initialize):
1412
1413 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1414
1415         Reviewed by Anders Carlsson.
1416
1417         Use designated temp directory for the database for WebKit2
1418         https://bugs.webkit.org/show_bug.cgi?id=53052
1419         
1420         Adopt the new WK2 API for this.
1421
1422         * WebKitTestRunner/TestController.cpp:
1423         (WTR::TestController::libraryPathForTesting):
1424         (WTR::TestController::initialize):
1425         * WebKitTestRunner/TestController.h:
1426         * WebKitTestRunner/mac/TestControllerMac.mm:
1427         (WTR::TestController::platformLibraryPathForTesting):
1428         * WebKitTestRunner/qt/TestControllerQt.cpp:
1429         (WTR::TestController::platformLibraryPathForTesting):
1430         * WebKitTestRunner/win/TestControllerWin.cpp:
1431         (WTR::TestController::platformLibraryPathForTesting):
1432
1433 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1434
1435         Reviewed by Stephanie Lewis.
1436
1437         Add a new Leopard test bot.
1438
1439         * BuildSlaveSupport/build.webkit.org-config/config.json:
1440
1441 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1442
1443         Reviewed by Adam Barth.
1444
1445         Add EFL Builder to core waterfall
1446         https://bugs.webkit.org/show_bug.cgi?id=52704
1447
1448         Add EFL Builder to the core waterfall again.
1449
1450         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1451         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1452
1453 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1454
1455         Reviewed by Tony Chang.
1456
1457         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1458         https://bugs.webkit.org/show_bug.cgi?id=52872
1459
1460         Force disabling proxy to resolve the problem.
1461
1462         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1463         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1464
1465 2011-01-24  Andreas Kling  <kling@webkit.org>
1466
1467         Reviewed by Darin Adler.
1468
1469         check-webkit-style: Update exemptions following Source/ move.
1470         https://bugs.webkit.org/show_bug.cgi?id=53017
1471
1472         * Scripts/webkitpy/style/checker.py:
1473         * Scripts/webkitpy/style/checker_unittest.py:
1474
1475 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1476
1477         Rubber-stamped by Csaba Osztrogonác.
1478
1479         [Qt] Move project files into Source
1480         https://bugs.webkit.org/show_bug.cgi?id=52891
1481
1482         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1483
1484 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1485
1486         Reviewed by Yury Semikhatsky.
1487
1488         Web Inspector: Find duplicate strings in localizedStrings.js
1489
1490         https://bugs.webkit.org/show_bug.cgi?id=53005
1491
1492         * Scripts/check-inspector-strings:
1493
1494 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1495
1496         Reviewed by Andreas Kling.
1497
1498         [Qt] Regroup MiniBrowser's menubar and add open file action
1499         https://bugs.webkit.org/show_bug.cgi?id=53000
1500
1501         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1502
1503         * MiniBrowser/qt/BrowserWindow.cpp:
1504         (BrowserWindow::BrowserWindow):
1505         (BrowserWindow::openFile):
1506         (BrowserWindow::~BrowserWindow):
1507         * MiniBrowser/qt/BrowserWindow.h:
1508
1509 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1510
1511         Unreviewed fix after r76496
1512
1513         [Qt] Move project files into Source
1514         https://bugs.webkit.org/show_bug.cgi?id=52891
1515
1516         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1517         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1518         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1519
1520 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1521
1522         Reviewed by Csaba Osztrogonác.
1523
1524         [Qt] Move project files into Source
1525         https://bugs.webkit.org/show_bug.cgi?id=52891
1526
1527         * DerivedSources.pro: Renamed from DerivedSources.pro.
1528         * DumpRenderTree/qt/DumpRenderTree.pro:
1529         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1530         * MiniBrowser/DerivedSources.pro:
1531         * MiniBrowser/qt/MiniBrowser.pro:
1532         * QtTestBrowser/QtTestBrowser.pro:
1533         * Scripts/webkitdirs.pm:
1534         * Tools.pro: Added.
1535         * WebKitTestRunner/DerivedSources.pro:
1536         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1537         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1538
1539 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1540
1541         Reviewed by Dan Bernstein.
1542
1543         Beefed up --threaded mode to catch even more kinds of errors.
1544         https://bugs.webkit.org/show_bug.cgi?id=52971
1545
1546         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1547         context group to force JSC to mark multiple threads. (This used to be
1548         the default, but it changed in SnowLeopard.)
1549         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1550         to give threading mistakes more chances to show themselves.
1551         (startJavaScriptThreads):
1552         (stopJavaScriptThreads):
1553
1554 2011-01-22  Robert Hogan  <robert@webkit.org>
1555
1556         Reviewed by Andreas Kling.
1557
1558         [Qt] Support layoutTestController.addURLToRedirect()
1559         https://bugs.webkit.org/show_bug.cgi?id=52956
1560
1561         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1562         (LayoutTestController::addURLToRedirect):
1563         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1564
1565 2011-01-22  Robert Hogan  <robert@webkit.org>
1566
1567         Reviewed by Kenneth Rohde Christiansen.
1568
1569         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1570         https://bugs.webkit.org/show_bug.cgi?id=49802
1571
1572         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1573         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1574         (WebCore::DumpRenderTree::open):
1575
1576 2011-01-21  Adam Barth  <abarth@webkit.org>
1577
1578         Reviewed by Maciej Stachowiak.
1579
1580         Disable mac_unittest.py that fails on some of the Mac bots
1581         https://bugs.webkit.org/show_bug.cgi?id=52947
1582
1583         As noted in the comment, this test does not appear to be correct
1584         because the function this test is testing returns different results
1585         depending on which flavor of Mac the test is run on.  This patch
1586         disable the test.  Hopefully we can re-enable the test once we've
1587         probably insulated the test from its environment.
1588
1589         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1590
1591 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1592
1593         Reviewed by Mihai Parparita.
1594
1595         Fix bug introduced in r76322 that caused NRWT to not actually
1596         read the Skipped files properly.
1597
1598         https://bugs.webkit.org/show_bug.cgi?id=52771
1599
1600         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1601         * Scripts/webkitpy/layout_tests/port/webkit.py:
1602         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1603
1604 2011-01-21  Sam Weinig  <sam@webkit.org>
1605
1606         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1607
1608         WebKitTestRunner needs the HOME environment variable to be set.
1609         <rdar://problem/8896573>
1610
1611         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1612         it exists.
1613
1614 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1615
1616         Reviewed by Eric Seidel.
1617
1618         Suppress a few remaining integration tests so that none of the
1619         layout_test unit tests ever read from the filesystem or launch
1620         subprocesses that aren't part of the unit tests.
1621
1622         Also fix a minor bug in the printing unit tests that was
1623         incorrectly relying on sys.argv.
1624
1625         https://bugs.webkit.org/show_bug.cgi?id=52863
1626
1627         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1628         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1629         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1630
1631 2011-01-21  Darin Adler  <darin@apple.com>
1632
1633        Fix Mac build.
1634
1635         * MiniBrowser/mac/BrowserWindowController.m:
1636         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1637
1638 2011-01-20  Darin Adler  <darin@apple.com>
1639
1640         Reviewed by Dan Bernstein.
1641
1642         WebKit2: Implement showModalDialog
1643         https://bugs.webkit.org/show_bug.cgi?id=52855
1644
1645         This fixes WebKitTestRunner to compile, but more work is probably
1646         needed to get it to pass the tests.
1647
1648         * WebKitTestRunner/TestController.cpp:
1649         (WTR::TestController::runModal): Added. Calls through to the
1650         platform-specific version of runModal.
1651         (WTR::TestController::createOtherPage): Changed to be a private
1652         static member function so it can refer to runModal, which is
1653         a private static member function.
1654         (WTR::TestController::initialize): Pass 0 for the runModal
1655         function since we don't need to run the main window modal.
1656         I suspect this is wrong and will need to change.
1657         * WebKitTestRunner/TestController.h: Added declarations for
1658         the functions added above.
1659         * WebKitTestRunner/mac/TestControllerMac.mm:
1660         (WTR::TestController::runModal): Added. Untested implementation.
1661         * WebKitTestRunner/qt/TestControllerQt.cpp:
1662         (WTR::TestController::runModal): Added.
1663         * WebKitTestRunner/win/TestControllerWin.cpp:
1664         (WTR::TestController::runModal): Added.
1665
1666 2011-01-21  Eric Seidel  <eric@webkit.org>
1667
1668         Reviewed by Adam Barth.
1669
1670         Split Host object off from WebKitPatch for easier re-use
1671         https://bugs.webkit.org/show_bug.cgi?id=52284
1672
1673         new-run-webkit-tests and other tools are eventually going to want one of these.
1674         Basically you need to inherit from this class if you want to pretend to be a
1675         self.tool object for Steps/Commands.
1676
1677         * Scripts/webkitpy/common/host.py: Added.
1678         * Scripts/webkitpy/tool/main.py:
1679
1680 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1681
1682         Reviewed by Adam Barth.
1683
1684         Disable the tests that start and stop the http server and web
1685         server, so that we don't have to worry about port collisions on
1686         the bots.
1687
1688         https://bugs.webkit.org/show_bug.cgi?id=52861
1689
1690         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1691
1692 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1693
1694         Reviewed by Eric Seidel.
1695
1696         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1697         
1698         https://bugs.webkit.org/show_bug.cgi?id=52772
1699         
1700         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1701
1702 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1703
1704         Reviewed by Eric Siedel.
1705
1706         nrwt: clean up almost all remaining port references, remove
1707         unnecessary import clauses. The only remaining references are
1708         in places where a mock filesystem makes no sense or can't be
1709         used, and in one routine in port/google_chrome_unittest that
1710         I'll rewrite in a separate patch.
1711
1712         https://bugs.webkit.org/show_bug.cgi?id=52771
1713
1714         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1715         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1716         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1717         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1718         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1719         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1720         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1721         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1722         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1723         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1724         * Scripts/webkitpy/layout_tests/port/gtk.py:
1725         * Scripts/webkitpy/layout_tests/port/mac.py:
1726         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1727         * Scripts/webkitpy/layout_tests/port/qt.py:
1728         * Scripts/webkitpy/layout_tests/port/webkit.py:
1729         * Scripts/webkitpy/layout_tests/port/win.py:
1730         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1731
1732 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1733
1734         Reviewed by Mihai Parparita.
1735
1736         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1737
1738         https://bugs.webkit.org/show_bug.cgi?id=52762
1739
1740         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1741         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1742
1743 2011-01-20  Tony Chang  <tony@chromium.org>
1744
1745         Reviewed by Ojan Vafai.
1746
1747         [chromium] fix the paths used for the rebaseline tool
1748         https://bugs.webkit.org/show_bug.cgi?id=52857
1749
1750         Some of the bots were renamed so the path to grab the results zip
1751         file has changed.
1752
1753         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1754
1755 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1756
1757         Reviewed by Tony Chang.
1758
1759         Fix bug introduced in r72688 / bug 52768 that broke the
1760         generation of the output filename links in the results.html
1761         output. Apparently none of the unit tests actually checked to
1762         make sure the generated links were correct :(
1763
1764         https://bugs.webkit.org/show_bug.cgi?id=52854
1765
1766         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1767         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1768
1769 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1770
1771         Reviewed by Darin Adler.
1772
1773         https://bugs.webkit.org/show_bug.cgi?id=52849
1774         Make window.print work with WebKit2
1775
1776         * MiniBrowser/mac/BrowserWindowController.m:
1777         (-[BrowserWindowController awakeFromNib]):
1778         * WebKitTestRunner/TestController.cpp:
1779         (WTR::createOtherPage):
1780         (WTR::TestController::initialize):
1781         Added zeroes to WKPageUIClient structures to avoid build failures.
1782
1783 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1784
1785         Reviewed by Eric Seidel.
1786
1787         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1788
1789         https://bugs.webkit.org/show_bug.cgi?id=52756
1790
1791         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1792         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1793         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1794         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1795         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1796         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1797
1798 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1799
1800         Reviewed by Antonio Gomes.
1801
1802         QtTestBrowser should have a seperate menu for Settings
1803         https://bugs.webkit.org/show_bug.cgi?id=52817
1804         
1805         Added a new menu item named "Settings"
1806         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1807
1808         * QtTestBrowser/launcherwindow.cpp:
1809         (LauncherWindow::createChrome):
1810
1811 2011-01-20  Sam Weinig  <sam@webkit.org>
1812
1813         Reviewed by John Sullivan.
1814
1815         Update update-webkit-localizable-strings with new path to WebKit.
1816
1817         * Scripts/update-webkit-localizable-strings:
1818
1819 2011-01-20  James Robinson  <jamesr@chromium.org>
1820
1821         Reviewed by Darin Fisher.
1822
1823         Implement mozilla's requestAnimationFrame API
1824         https://bugs.webkit.org/show_bug.cgi?id=51218
1825
1826         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1827
1828         * DumpRenderTree/chromium/WebViewHost.cpp:
1829         (invokeScheduleComposite):
1830         (WebViewHost::scheduleAnimation):
1831         (WebViewHost::paintInvalidatedRegion):
1832         * DumpRenderTree/chromium/WebViewHost.h:
1833
1834 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1835
1836         Reviewed by Adam Roben.
1837
1838         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1839         https://bugs.webkit.org/show_bug.cgi?id=42327
1840
1841         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1842         for methods that take their normal arguments but also a JSContextRef.
1843         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1844         for evaluateScriptInIsolatedWorld.
1845         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1846         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1847         this call is for an isolated world.
1848         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1849         (WTR::worldMap): Helper to create a world map.
1850         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1851         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1852         added LayoutTestController API.
1853         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1854
1855 2011-01-19  Adam Roben  <aroben@apple.com>
1856
1857         Convert paths in environment variables back to msys-style inside commit-log-editor
1858
1859         When this script gets run from inside git commit, msys-style paths in the environment will
1860         have been turned into Windows-style paths with forward slashes. This screws up functions
1861         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1862         the paths back to msys-style before doing anything else.
1863
1864         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1865         using msysgit's Perl and multiple ChangeLogs have been edited
1866
1867         Reviewed by David Kilzer.
1868
1869         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1870         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1871         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1872
1873 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1874
1875         [Win] Unreviewed build fix after r76248.
1876
1877         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1878
1879 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1880
1881         Reviewed by Csaba Osztrogonác.
1882
1883         Refactoring of the custom allocation framework
1884         https://bugs.webkit.org/show_bug.cgi?id=49897
1885
1886         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1887         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1888         equivalent macro implementation at the necessary places.
1889 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1890
1891         Unreviewed. 
1892
1893         Adding myself to committers.py.
1894
1895         * Scripts/webkitpy/common/config/committers.py:
1896
1897 2011-01-20  Adam Barth  <abarth@webkit.org>
1898
1899         Reviewed by Tony Chang.
1900
1901         Chromium builders don't delete unversioned directories when DEPS change
1902         https://bugs.webkit.org/show_bug.cgi?id=52745
1903
1904         If we pass this option to gclient sync, gclient will delete directories
1905         that are no longer part of DEPS instead of leaving them around to
1906         confuse us later.  Apparently, the downstream buildbots use this option
1907         already.
1908
1909         * Scripts/update-webkit-chromium:
1910
1911 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1912
1913         Unreviewed, build fix - I pulled this patch in to fix an issue
1914         revealed by r76195 running on some new bots). Also fix a couple
1915         of other issues revealed in testing.
1916
1917         nrwt: remove fs refs from layout_package/json*
1918
1919         https://bugs.webkit.org/show_bug.cgi?id=52754
1920
1921         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1922         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1923         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1924         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1925         * Scripts/webkitpy/layout_tests/port/base.py:
1926
1927 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1928
1929         Unreviewed, build fix.
1930
1931         Fix a couple of minor bugs discovered while bringing up new bots
1932         for testing.
1933
1934         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1935         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1936
1937 2011-01-19  James Robinson  <jamesr@chromium.org>
1938
1939         Unreviewed, rolling out r76194.
1940         http://trac.webkit.org/changeset/76194
1941         https://bugs.webkit.org/show_bug.cgi?id=51218
1942
1943         Caused mysterious compile failure on the chromium win
1944         build.webkit.org bots
1945
1946         * DumpRenderTree/chromium/WebViewHost.cpp:
1947         (WebViewHost::paintInvalidatedRegion):
1948         * DumpRenderTree/chromium/WebViewHost.h:
1949
1950 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1951
1952         Reviewed by Mihai Parparita.
1953
1954         remove fs refs from test_runner, dump_render_tree_thread
1955
1956         https://bugs.webkit.org/show_bug.cgi?id=52753
1957
1958         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1959         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1960         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1961         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1962
1963 2011-01-19  James Robinson  <jamesr@chromium.org>
1964
1965         Reviewed by Darin Fisher.
1966
1967         Implement mozilla's requestAnimationFrame API
1968         https://bugs.webkit.org/show_bug.cgi?id=51218
1969
1970         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1971
1972         * DumpRenderTree/chromium/WebViewHost.cpp:
1973         (invokeScheduleComposite):
1974         (WebViewHost::scheduleAnimation):
1975         (WebViewHost::paintInvalidatedRegion):
1976         * DumpRenderTree/chromium/WebViewHost.h:
1977
1978 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1979
1980         Unreviewed, build fix.
1981
1982         Fix a few incorrect "self._filesystem" references introduced in
1983         r76184.
1984
1985         * Scripts/webkitpy/layout_tests/port/chromium.py:
1986         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1987
1988 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1989
1990         Reviewed by Mihai Parparita.
1991
1992         add a .sep property, abspath(), isabs(), mtime(), and
1993         open_text_file_for_writing() to filesystem modules. Some of
1994         these properties are not needed in this patch but will be needed
1995         in subsequent patches (I'm doing this to avoid having to track
1996         multiple versions of a single file).
1997
1998         Also, change most of the port/* modules to use the filesystem
1999         objects instead of referencing the filesystem directly.
2000
2001         https://bugs.webkit.org/show_bug.cgi?id=52748
2002
2003         * Scripts/webkitpy/common/system/filesystem.py:
2004         * Scripts/webkitpy/common/system/filesystem_mock.py:
2005         * Scripts/webkitpy/layout_tests/port/__init__.py:
2006         * Scripts/webkitpy/layout_tests/port/base.py:
2007         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2008         * Scripts/webkitpy/layout_tests/port/chromium.py:
2009         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2010         * Scripts/webkitpy/layout_tests/port/config.py:
2011         * Scripts/webkitpy/layout_tests/port/test.py:
2012         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2013
2014 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2015
2016         Reviewed by Anders Carlsson.
2017
2018         If resetting between tests times out, treat it as a WebProcess crash
2019         https://bugs.webkit.org/show_bug.cgi?id=52757
2020
2021         * WebKitTestRunner/TestController.cpp:
2022         (WTR::TestController::runTest):
2023
2024 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2025
2026         Reviewed by Darin Adler.
2027
2028         https://bugs.webkit.org/show_bug.cgi?id=52739
2029         Make it possible for a WebKit2 client to print headers and footers
2030
2031         Added dummy implementations for new printing UIClient calls.
2032
2033         * MiniBrowser/mac/BrowserWindowController.m:
2034         (-[BrowserWindowController awakeFromNib]):
2035         * WebKitTestRunner/TestController.cpp:
2036         (WTR::createOtherPage):
2037         (WTR::TestController::initialize):
2038
2039 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2040
2041         Reviewed by Ojan Vafai.
2042
2043         Change webkitpy/layout_tests/port/test.py to use the
2044         in-memory filesystem for cleaner unit testing. This
2045         change allows us to kill a lot of code that was
2046         specific to the test port, at the cost of being a
2047         little less clear about how things would work if
2048         you didn't have a filesystem.
2049
2050         https://bugs.webkit.org/show_bug.cgi?id=52605
2051
2052         * Scripts/webkitpy/layout_tests/port/test.py:
2053
2054 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2055
2056         Unreviewed, build fix.
2057
2058         Fix test failure caused by committing attachment 79368 instead
2059         of attachment 79461 on bug 52604.
2060
2061         * Scripts/webkitpy/common/system/filesystem_mock.py:
2062
2063 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2064
2065         Reviewed by Mihai Parparita.
2066
2067         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2068         unit testing. os.walk() is too much of a hassle to implement on
2069         top of the in-memory mock filesystem and adding the necessary
2070         interface to files_under() gives clients a cleaner API anyway
2071         (for this particular usage model).
2072
2073         https://bugs.webkit.org/show_bug.cgi?id=52691
2074
2075         * Scripts/webkitpy/common/system/filesystem.py:
2076         * Scripts/webkitpy/common/system/filesystem_mock.py:
2077         * Scripts/webkitpy/layout_tests/port/test_files.py:
2078         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2079
2080 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2081
2082         Reviewed by Tony Chang.
2083
2084         Change more modules in the layout-tests code to use the
2085         filesystem wrapper for cleaner unit testing.
2086
2087         This patch also adds the glob() wrapper to the filesystem
2088         abstraction.
2089         
2090         https://bugs.webkit.org/show_bug.cgi?id=52604
2091
2092         * Scripts/webkitpy/layout_tests/port/test_files.py:
2093         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2094         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2095         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2096         * Scripts/webkitpy/common/system/filesystem.py:
2097         * Scripts/webkitpy/common/system/filesystem_mock.py:
2098
2099 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2100
2101         Unreviewed.
2102
2103         Updating my email addresses and irc nick.
2104
2105         * Scripts/webkitpy/common/config/committers.py:
2106
2107 2011-01-19  Tony Chang  <tony@chromium.org>
2108
2109         Reviewed by Mihai Parparita.
2110
2111         [chromium] [linux] if check-sys-deps fails, output the failure reason
2112         https://bugs.webkit.org/show_bug.cgi?id=52671
2113
2114         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2115             error handler functions.
2116         * Scripts/webkitpy/layout_tests/port/chromium.py:
2117             output the error text from --check-sys-deps
2118         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2119
2120 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2121
2122         Reviewed by Andreas Kling.
2123
2124         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2125         https://bugs.webkit.org/show_bug.cgi?id=52554
2126         
2127         QtNetworkAccessManager is created in a thread and set as
2128         member variable in QWebPage. When the thread is destroyed
2129         the object is still used. So fix will set the object to
2130         NULL once the thread is destroyed.
2131
2132         * QtTestBrowser/launcherwindow.cpp:
2133         (LauncherWindow::~LauncherWindow):
2134
2135 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2136
2137         Rubber stamped by Csaba Osztrogonac
2138
2139         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2140
2141 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2142
2143         Reviewed by Tony Chang.
2144
2145         new-run-webkit-tests: add a --build-directory command line argument
2146
2147         Official Google Chrome builds use a non-standard build directory
2148         location. This patch adds a --build-directory argument that
2149         allows that location to be specified on the command line. Only
2150         Chromium-based builds will use this flag for now, but anyone can
2151         in the future.
2152
2153         There are no unit tests for this since it's difficult to test
2154         until mock filesystems are fully supported in the code. This was
2155         tested by hand for now.
2156
2157         https://bugs.webkit.org/show_bug.cgi?id=52694
2158
2159         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2160         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2161         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2162         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2163
2164 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2165
2166         Not reviewed. Bot fix.
2167
2168         Remove an inadvertently committed debugging print.
2169
2170         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2171         (LayoutTestController::notifyDone):
2172
2173 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2174
2175         Reviewed by Sam Weinig.
2176
2177         WebKitTestRunner should track loading more like DumpRenderTree
2178         https://bugs.webkit.org/show_bug.cgi?id=52692
2179
2180         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2181         This makes some tests that call notifyDone multiple times pass.
2182         
2183         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2184         (WTR::InjectedBundle::InjectedBundle):
2185         (WTR::InjectedBundle::done):
2186         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2187         (WTR::InjectedBundle::topLoadingFrame):
2188         (WTR::InjectedBundle::setTopLoadingFrame):
2189         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2190         (WTR::InjectedBundlePage::InjectedBundlePage):
2191         (WTR::InjectedBundlePage::stopLoading):
2192         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2193         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2194         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2195         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2196         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2197         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2198         (WTR::LayoutTestController::notifyDone):
2199         * WebKitTestRunner/TestController.cpp:
2200         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2201
2202 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2203
2204         Reviewed by Kent Tamura.
2205
2206         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2207         https://bugs.webkit.org/show_bug.cgi?id=52678
2208         
2209         Update path now that WebKit is inside Source.
2210
2211         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2212
2213 2011-01-18  Robert Hogan  <robert@webkit.org>
2214
2215         Reviewed by Simon Hausmann.
2216
2217         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2218         https://bugs.webkit.org/show_bug.cgi?id=44282
2219
2220         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2221         (WebCore::DumpRenderTree::dump):
2222
2223 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2224
2225         Reviewed by Mihai Parparita.
2226
2227         Fix a small race condition that could cause the unit tests for
2228         new-run-webkit-tests to fail in a multithreaded environment.
2229         There was a small window in the code where one thread would
2230         check to see if a thread had raised an exception, do something,
2231         and then check to see if the thread was alive. If the other
2232         thread raised an exception and exited in between these two
2233         steps, the exception would be lost. Flipping the order of the
2234         two checks fixes the race, since we will now always check for an
2235         exception on the thread before exiting.
2236
2237         https://bugs.webkit.org/show_bug.cgi?id=51579
2238
2239         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2240
2241 2011-01-18  Eric Seidel  <eric@webkit.org>
2242
2243         Reviewed by Adam Barth.
2244
2245         commit-queue dies when test archiving fails
2246         https://bugs.webkit.org/show_bug.cgi?id=52617
2247
2248         I looked at the machine and it had 10 archives already
2249         thus find_unused_name was returning None.  I've upped
2250         the limit to 100 (per bug) and tested the case where
2251         find_unused_name returns None (making archive return None).
2252
2253         * Scripts/webkitpy/common/system/workspace.py:
2254         * Scripts/webkitpy/common/system/workspace_unittest.py:
2255         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2256         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2257         * Scripts/webkitpy/tool/commands/queues.py:
2258
2259 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2260
2261         Reviewed by Ojan Vafai.
2262
2263         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2264         filesystem. Also fix a couple of "with" statements missed by
2265         r76050.
2266
2267         https://bugs.webkit.org/show_bug.cgi?id=52487
2268
2269         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2270
2271 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2272
2273         Reviewed by Martin Robinson.
2274
2275         [Gtk] Build fixes for gtk3 build
2276         https://bugs.webkit.org/show_bug.cgi?id=52648
2277
2278         * DumpRenderTree/gtk/EventSender.cpp:
2279         (beginDragWithFilesCallback):
2280
2281 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2282
2283         Reviewed by Mihai Parparita.
2284
2285         Update rebaseline-chromium-webkit-tests to use filesystem objects
2286         instead of direct references to os.path, shutil, tempfile, etc.
2287
2288         This patch doesn't change anything, but will allow subsequent
2289         patches to change the unit tests to no longer use the real
2290         filesystem.
2291
2292         This patch adds a bunch more methods to the filesystem object as
2293         well.
2294
2295         https://bugs.webkit.org/show_bug.cgi?id=52482
2296
2297         * Scripts/webkitpy/common/system/filesystem.py:
2298         * Scripts/webkitpy/common/system/filesystem_mock.py:
2299         * Scripts/webkitpy/tool/commands/queues.py:
2300         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2301         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2302
2303 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2304
2305         Reviewed by Mihai Parparita.
2306
2307         new-run-webkit-tests shouldn't crash when you try to run a
2308         directory containing only skipped files.
2309
2310         https://bugs.webkit.org/show_bug.cgi?id=52478
2311         
2312         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2313         * Scripts/webkitpy/layout_tests/port/test.py:
2314         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2315
2316 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2317
2318         Reviewed by Gustavo Noronha Silva.
2319
2320         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2321         https://bugs.webkit.org/show_bug.cgi?id=40833
2322
2323         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2324         GTK+ event sender.
2325         (dragWithFilesDragDataGetCallback): Added.
2326         (dragWithFilesDragEndCallback): Added.
2327         (beginDragWithFilesCallback): Added.
2328
2329 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2330
2331         Reviewed by Adam Barth.
2332
2333         ews: Add additional watcher to efl ews
2334         https://bugs.webkit.org/show_bug.cgi?id=52613
2335
2336         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2337
2338         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2339
2340 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2341
2342         Reviewed by Alexey Proskuryakov.
2343
2344         Fix some headers with missing or misspelled #ifndef guards
2345         https://bugs.webkit.org/show_bug.cgi?id=52545
2346
2347         * DumpRenderTree/chromium/TestEventPrinter.h:
2348         * DumpRenderTree/chromium/WebPreferences.h:
2349
2350 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2351
2352         Reviewed by Anders Carlsson.
2353
2354         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2355         navigating back to an unreachable URL
2356         https://bugs.webkit.org/show_bug.cgi?id=52388
2357
2358         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2359
2360         * DumpRenderTree/LayoutTestController.cpp:
2361         (queueLoadHTMLStringCallback):
2362         (LayoutTestController::queueLoadHTMLString):
2363         (LayoutTestController::queueLoadAlternateHTMLString):
2364         * DumpRenderTree/LayoutTestController.h:
2365
2366         * DumpRenderTree/WorkQueueItem.h:
2367         (LoadHTMLStringItem::LoadHTMLStringItem):
2368
2369         * DumpRenderTree/chromium/LayoutTestController.cpp:
2370         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2371         (WorkItemLoadHTMLString::run):
2372         (LayoutTestController::queueLoadHTMLString):
2373
2374         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2375         (LoadHTMLStringItem::invoke):
2376         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2377         (LoadHTMLStringItem::invoke):
2378         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2379         (LoadHTMLStringItem::invoke):
2380
2381 2011-01-17  Dan Bernstein  <mitz@apple.com>
2382
2383         Rubber-stamped by Mark Rowe.
2384
2385         Update xcodeproj svn:ignore to include xcuserdata.
2386
2387         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2388         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2389         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2390         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2391         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2392
2393 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2394
2395         Unreviewed fix after r75908.
2396
2397         Move WebKit into Source
2398         https://bugs.webkit.org/show_bug.cgi?id=52530
2399
2400         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2401
2402 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2403
2404         Unreviewed.
2405
2406         Remove accidentally committed debug printing after r75908.
2407
2408         * Scripts/webkitdirs.pm:
2409
2410 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2411
2412         Unreviewed.
2413
2414         Add myself to committers list
2415         https://bugs.webkit.org/show_bug.cgi?id=52566
2416
2417         * Scripts/webkitpy/common/config/committers.py:
2418
2419 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2420
2421         Reviewed by Jeremy Orlow.
2422
2423         GeolocationController should call stopUpdating on destruction
2424         https://bugs.webkit.org/show_bug.cgi?id=52216
2425
2426         fast/dom/Geolocation/window-close-crash.html requires that a
2427         Geolocation watch be started in a secondary window. Consequently,
2428         we need to allow geolocation permission and provide a mock
2429         geolocation position for the secondary window's
2430         GeolocationClientMock.
2431
2432         * DumpRenderTree/chromium/LayoutTestController.cpp:
2433         (LayoutTestController::setGeolocationPermission):
2434         (LayoutTestController::setMockGeolocationPosition):
2435         (LayoutTestController::setMockGeolocationError):
2436         * DumpRenderTree/chromium/TestShell.h:
2437         (TestShell::windowList):
2438
2439 2011-01-16  Adam Barth  <abarth@webkit.org>
2440
2441         Update more include paths to reflect WebKit move.
2442
2443         * DumpRenderTree/chromium/EventSender.cpp:
2444         (EventSender::keyDown):
2445         (EventSender::needsShiftModifier):
2446         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2447         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2448
2449 2011-01-16  Kent Tamura  <tkent@chromium.org>
2450
2451         Unreviewed, Chromium build fix.
2452
2453         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2454
2455 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2456
2457         Build fix for GTK+ after source directory movement.
2458
2459         * GNUmakefile.am: Correct include paths.
2460
2461 2011-01-16  Adam Barth  <abarth@webkit.org>
2462
2463         Teach svn-apply about WebKit move.
2464
2465         * Scripts/VCSUtils.pm:
2466
2467 2011-01-16  Adam Barth  <abarth@webkit.org>
2468
2469         Rubber-stamped by Eric Seidel.
2470
2471         Move WebKit into Source
2472         https://bugs.webkit.org/show_bug.cgi?id=52530
2473
2474         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2475         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2476         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2477         * DumpRenderTree/qt/GCControllerQt.cpp:
2478         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2479         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2480         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2481         * DumpRenderTree/wscript:
2482         * QtTestBrowser/launcherwindow.h:
2483         * Scripts/build-webkit:
2484         * Scripts/webkitdirs.pm:
2485
2486 2011-01-15  Adam Barth  <abarth@webkit.org>
2487
2488         Teach svn-apply about WebKit2 move.
2489
2490         * Scripts/VCSUtils.pm:
2491
2492 2011-01-15  Adam Barth  <abarth@webkit.org>
2493
2494         Rubber-stamped by Eric Seidel.
2495
2496         Move WebKit2 into Source
2497         https://bugs.webkit.org/show_bug.cgi?id=52438
2498
2499         * MiniBrowser/qt/MiniBrowser.pro:
2500         * Scripts/build-webkit:
2501         * Scripts/do-file-rename:
2502         * Scripts/do-webcore-rename:
2503         * Scripts/test-webkitpy:
2504         * Scripts/webkitdirs.pm:
2505         * Scripts/webkitpy/style/checker.py:
2506         * WebKitTestRunner/DerivedSources.pro:
2507         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2508         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2509
2510 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2511
2512         Reviewed by David Levin.
2513
2514         [chromium] remove obsolete createView method
2515         https://bugs.webkit.org/show_bug.cgi?id=52437
2516
2517         * DumpRenderTree/chromium/WebViewHost.cpp:
2518         (WebViewHost::createView):
2519         * DumpRenderTree/chromium/WebViewHost.h:
2520
2521 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2522
2523         Reviewed by Geoff Garen.
2524
2525         ShouldLoadResourceForFrame should use strings, not URLs.
2526         https://bugs.webkit.org/show_bug.cgi?id=52476
2527
2528         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2529         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2530         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2531
2532 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2533
2534         Reviewed by David Levin.
2535
2536         Add Tony Gentilcore as a reviewer
2537         https://bugs.webkit.org/show_bug.cgi?id=52480
2538
2539         * Scripts/webkitpy/common/config/committers.py:
2540
2541 2011-01-14  David Levin  <levin@chromium.org>
2542
2543         Reviewed by Eric Seidel.
2544
2545         check-webkit-style: _FunctionState should keep track of where the function name starts.
2546         https://bugs.webkit.org/show_bug.cgi?id=52454
2547
2548         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2549         _FunctionState and logic for setting it correctly.
2550         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2551
2552 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2553
2554         Reviewed by David Levin.
2555
2556         Add support to DumpRenderTree to use the GPU rather than software renderer
2557         https://bugs.webkit.org/show_bug.cgi?id=52333
2558
2559         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2560         (main):
2561         * Scripts/webkitpy/layout_tests/port/chromium.py:
2562         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2563
2564 2011-01-14  Tony Chang  <tony@chromium.org>
2565
2566         Reviewed by Kent Tamura.
2567
2568         [chromium] update fonts.conf to fix 6 linux tests in drt
2569         https://bugs.webkit.org/show_bug.cgi?id=52411
2570
2571         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2572             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2573
2574 2011-01-14  Eric Seidel  <eric@webkit.org>
2575
2576         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2577
2578         Reviewed by Adam Barth.
2579
2580         Fix when running Tools/Scripts/check-webkit-style without arguments.
2581         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2582
2583         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2584         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2585
2586 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2587
2588         Reviewed by David Levin.
2589
2590         Store the tempdir object in a variable so it doesn't get deleted too early.
2591         https://bugs.webkit.org/show_bug.cgi?id=51875
2592
2593         * Scripts/update-webkit-auxiliary-libs:
2594         * Scripts/update-webkit-support-libs:
2595
2596 2011-01-14  Eric Seidel  <eric@webkit.org>
2597
2598         Unreviewed.  Make it work in python 2.5.
2599
2600         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2601         https://bugs.webkit.org/show_bug.cgi?id=49158
2602
2603         * Scripts/webkitpy/common/checkout/api_unittest.py:
2604
2605 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2606
2607         Unreviewed, rolling out r75774.
2608         http://trac.webkit.org/changeset/75774
2609         https://bugs.webkit.org/show_bug.cgi?id=52431
2610
2611         gtk builds were broken (Requested by loislo2 on #webkit).
2612
2613         * Scripts/webkitpy/common/checkout/scm.py:
2614
2615 2011-01-14  David Levin  <levin@chromium.org>
2616
2617         Reviewed by Shinichiro Hamaji.
2618
2619         check-webkit-style: _FunctionState should detect pure functions.
2620         https://bugs.webkit.org/show_bug.cgi?id=52428
2621
2622         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2623         is a pure virtual function.
2624         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2625         virtual functions are correctly detected.
2626
2627 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2628
2629         Reviewed by Yury Semikhatsky.
2630
2631         Just small fix for problem with check-webkit-style.
2632         It just didn't work for this patch.
2633         Old code can't concatenate a list of strings with None.
2634
2635         * Scripts/webkitpy/common/checkout/scm.py:
2636
2637 2011-01-13  David Levin  <levin@chromium.org>
2638
2639         Reviewed by Shinichiro Hamaji.
2640
2641         check-webkit-style: _FunctionState should use Position to know where items are.
2642         https://bugs.webkit.org/show_bug.cgi?id=52424
2643
2644         * Scripts/webkitpy/style/checkers/cpp.py:
2645         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2646         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2647         did some minor clean-up.
2648         (*): Other changes are simply about converting to use the Position's in_FunctionState
2649         instead of line numbers.
2650         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2651         to verify the positions stored in _FunctionState.
2652
2653 2011-01-13  Eric Seidel  <eric@webkit.org>
2654
2655         Reviewed by David Levin.
2656
2657         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2658         https://bugs.webkit.org/show_bug.cgi?id=49158
2659
2660         This is not the most elegant, but it is a very safe fix to this bug.
2661         One advantage of catching ScriptError like this instead of adding a
2662         new added_or_modified_files or fixing all changed_files callers
2663         to use a more specific change_files variant, is that we catch
2664         all kinds of ScriptErrors which might cause our (non-essential)
2665         suggest-reviewers code to fail out.  This should make passing
2666         --suggest-reviewers to webkit-patch upload much more robust
2667         and may even make it possible for us to make it default.
2668
2669         The root of the problem here is that SCM.changed_files includes
2670         deleted ChangeLog paths (from moves, etc) which then when we ask
2671         SVN/Git for the contents of the file at that revision, the command
2672         errors out and Executive.run_command raises a ScriptError.
2673
2674         In the future we might fix this differently by making all current
2675         callers of chagned_files use a more specific method for requesting
2676         what types of changes they're interested in (adds, modifies, deletes, etc.)
2677
2678         * Scripts/webkitpy/common/checkout/api.py:
2679         * Scripts/webkitpy/common/checkout/api_unittest.py:
2680
2681 2011-01-13  Dan Bernstein  <mitz@apple.com>
2682
2683         Reviewed by Alexey Proskuryakov.
2684
2685         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2686         https://bugs.webkit.org/show_bug.cgi?id=52419
2687
2688         Allow to further control the behavior of the willSendRequest delegate callback by making it
2689         set a different URL in the new request.
2690
2691         * DumpRenderTree/LayoutTestController.cpp:
2692         (addURLToRedirectCallback): Added.
2693         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2694         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2695         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2696         * DumpRenderTree/LayoutTestController.h:
2697         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2698         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2699         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2700         change the URL in the new request to the redirect destination.
2701
2702 2011-01-13  Eric Seidel  <eric@webkit.org>
2703
2704         Reviewed by Mihai Parparita.
2705
2706         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2707         https://bugs.webkit.org/show_bug.cgi?id=52416
2708
2709         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2710         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2711
2712         I also added FIXMEs about the changed_files returning deleted files problem
2713         which is causing the other most common exception for suggest-reviewers
2714         (and is probably breaking sheriff-bots blame detection).
2715
2716         * Scripts/webkitpy/common/checkout/api.py:
2717         * Scripts/webkitpy/common/checkout/api_unittest.py:
2718         * Scripts/webkitpy/common/checkout/scm.py:
2719
2720 2011-01-13  Eric Seidel  <eric@webkit.org>
2721
2722         Reviewed by Adam Barth.
2723
2724         results archives from commit-queue are too large to upload
2725         https://bugs.webkit.org/show_bug.cgi?id=52405
2726
2727         * Scripts/webkitpy/common/system/filesystem.py:
2728         * Scripts/webkitpy/common/system/filesystem_mock.py:
2729         * Scripts/webkitpy/tool/commands/queues.py:
2730
2731 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2732
2733         Reviewed by Martin Robinson.
2734
2735         [gtk] Zero-sized font does not yet work
2736         https://bugs.webkit.org/show_bug.cgi?id=49793
2737
2738         Set minimum-font-size to 0 for the DRT.
2739
2740         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2741         (resetDefaultsToConsistentValues):
2742
2743 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2744
2745         Reviewed by Darin Adler.
2746
2747         Make old-run-webkit-tests more robust on buildbots
2748         https://bugs.webkit.org/show_bug.cgi?id=52364
2749
2750         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2751
2752 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2753
2754         Reviewed by Darin Adler.
2755
2756         Make old-run-webkit-tests more robust on buildbots
2757         https://bugs.webkit.org/show_bug.cgi?id=52364
2758
2759         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2760
2761 2011-01-13  Tony Chang  <tony@chromium.org>
2762
2763         Reviewed by Kent Tamura.
2764
2765         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2766         https://bugs.webkit.org/show_bug.cgi?id=52332
2767
2768         Forked Info.plist is not longer needed.
2769
2770         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2771
2772 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2773
2774         Reviewed by Timothy Hatcher.
2775
2776         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2777         to be passed directly to WebInspector.UIString
2778
2779         https://bugs.webkit.org/show_bug.cgi?id=52365
2780
2781         * Scripts/check-inspector-strings:
2782
2783 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2784
2785         Unreviewed, rolling out r74881.
2786         http://trac.webkit.org/changeset/74881
2787         https://bugs.webkit.org/show_bug.cgi?id=52357
2788
2789         The EFL builder has been red for days (Requested by abarth on
2790         #webkit).
2791
2792         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2793         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2794
2795 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2796
2797         Reviewed by David Levin.
2798
2799         Add beforeunload support to WebKitTestRunner
2800         https://bugs.webkit.org/show_bug.cgi?id=52353
2801         
2802         This makes a number of currently failing tests pass.
2803
2804         * WebKitTestRunner/TestController.cpp:
2805         (WTR::runBeforeUnloadConfirmPanel):
2806         (WTR::createOtherPage):
2807         (WTR::TestController::initialize):
2808
2809 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2810
2811         Reviewed by Sam Weinig.
2812
2813         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2814         https://bugs.webkit.org/show_bug.cgi?id=52330
2815
2816         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2817         a web process crash.
2818         * WebKitTestRunner/TestController.cpp:
2819         (WTR::TestController::initialize): Set up a processDidCrash
2820         callback.
2821         (WTR::TestController::processDidCrash): Report that the Web process
2822         crashed.
2823         * WebKitTestRunner/TestController.h:
2824
2825 2011-01-12  David Levin  <levin@chromium.org>
2826
2827         Reviewed by Shinichiro Hamaji.
2828
2829         check-webkit-style -- close_expression function doesn't work correctly.
2830         https://bugs.webkit.org/show_bug.cgi?id=52272
2831
2832         * Scripts/webkitpy/style/checkers/cpp.py:
2833         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2834         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2835         generally useful (for upcoming code changes).
2836         (close_expression): Changed to use Position for input and output.
2837         Also, fixed many bugs such as only working correctly for parenthesis,
2838         not working correctly if given an offset in a line and not finding
2839         the real closing element if there were multiple closing elements in
2840         the same line.
2841         (detect_functions): Adjusted due to the change in arguments for
2842         close_expression.
2843         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2844         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2845         two positions are the same.
2846         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2847         (CppStyleTest.test_close_expression): Added tests to catch the issues
2848         that were fixed.
2849
2850 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2851
2852         Unreviewed, rolling out r75576.
2853         http://trac.webkit.org/changeset/75576
2854         https://bugs.webkit.org/show_bug.cgi?id=52304
2855
2856         broke rebaseline-chromium-webkit-test (Requested by thakis on
2857         #webkit).
2858
2859         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2860         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2861         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2862         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2863         * Scripts/webkitpy/layout_tests/port/base.py:
2864         * Scripts/webkitpy/layout_tests/port/chromium.py:
2865         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2866         * Scripts/webkitpy/layout_tests/port/test.py:
2867         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2868         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2869         * Scripts/webkitpy/style/checkers/test_expectations.py:
2870         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2871
2872 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2873
2874         Reviewed by Darin Adler.
2875
2876         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2877         https://bugs.webkit.org/show_bug.cgi?id=52307
2878
2879         * Scripts/old-run-webkit-tests:
2880
2881 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2882
2883         Reviewed by Martin Robinson.
2884
2885         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2886         https://bugs.webkit.org/show_bug.cgi?id=50867
2887
2888         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2889         TestNetscapePlugin.cpp 
2890
2891         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2892         * Scripts/webkitdirs.pm:
2893
2894 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2895
2896         Reviewed by Pavel Feldman.
2897
2898         Add check-inspector-strings script.
2899
2900         https://bugs.webkit.org/show_bug.cgi?id=52295
2901
2902         * Scripts/check-inspector-strings: Added.
2903
2904 2011-01-12  Adam Roben  <aroben@apple.com>
2905
2906         Advertise the .testnetscape file extension on Windows
2907
2908         Fixes <http://webkit.org/b/52298>
2909         plugins/no-mime-with-valid-extension.html fails on Windows
2910
2911         Reviewed by Dan Bernstein.
2912
2913         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2914         FileExtents field to map the .testnetscape file extension to the
2915         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2916
2917 2011-01-12  Adam Barth  <abarth@webkit.org>
2918
2919         Reviewed by Eric Seidel.
2920
2921         Make webkit-patch support subdirectories for SVN checkouts
2922         https://bugs.webkit.org/show_bug.cgi?id=52261
2923
2924         os.relpath does not exist on Python 2.5, so we need to call our version
2925         of the API.
2926
2927         * Scripts/webkitpy/common/checkout/scm.py:
2928
2929 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2930
2931         Reviewed by Eric Seidel.
2932
2933         Close additional pages opened during a test once the test completes.
2934         https://bugs.webkit.org/show_bug.cgi?id=52276
2935
2936         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2937         (WTR::InjectedBundle::done):
2938
2939 2011-01-11  David Levin  <levin@chromium.org>
2940
2941         Reviewed by Eric Seidel.
2942
2943         Errors should be separated from the command line in bot messages.
2944         https://bugs.webkit.org/show_bug.cgi?id=52275
2945
2946         * Scripts/webkitpy/common/system/executive.py:
2947         (ScriptError.message_with_output): Added a newline to separate the command
2948         line from the errors.
2949         * Scripts/webkitpy/common/system/executive_unittest.py:
2950         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2951         paths in message_with_output.
2952
2953 2011-01-11  Eric Seidel  <eric@webkit.org>
2954
2955         Unreviewed.
2956
2957         commit-queue should know how to upload archived results (for test flakes or general failures)
2958         https://bugs.webkit.org/show_bug.cgi?id=52048
2959
2960         The zips are mostly empty due to forgetting -r.
2961         Expected diffs were not being pulled from the archive due
2962         to the archive having longer paths than I realized.
2963
2964         * Scripts/webkitpy/common/system/workspace.py:
2965         * Scripts/webkitpy/common/system/workspace_unittest.py:
2966         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2967         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2968
2969 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2970
2971         Reviewed by Ojan Vafai.
2972
2973         The current modifier parsing code in test_expectations is
2974         fragile and hard-coded, so it's not easy to understand the logic
2975         or easily add new types of modifiers (like GPU vs. CPU testing
2976         for graphics tests, or 32-bit vs. 64-bit differences).
2977
2978         This is the first of two patches that will add in more generic
2979         support and then eliminate the GPU-specific test expectations
2980         files for Chromium.
2981
2982         This patch adds two standalone objects for handling modifiers. The
2983         rules for interpreting modifiers, precedence, and conflicts are
2984         given in the docstring to the ModifierMatcher class, which
2985         returns ModifierMatchResult objects.
2986         
2987         This patch also adds routines to the Port interface and a
2988         default set of values in the base object, in order to obtain the
2989         values needed on a given test run. These values are then passed
2990         to the expectation parser. This also allows us to clean up the
2991         logic used to lint all of the different configurations in a
2992         single test_expectations.txt file.
2993
2994         The next patch will merge in the separate GPU expectations file.
2995
2996         https://bugs.webkit.org/show_bug.cgi?id=51222
2997
2998         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2999         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3000         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3001         * Scripts/webkitpy/layout_tests/port/base.py:
3002         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3003         * Scripts/webkitpy/layout_tests/port/chromium.py:
3004         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3005         * Scripts/webkitpy/layout_tests/port/test.py:
3006         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3007         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3008
3009 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3010
3011         Reviewed by Adam Barth.
3012
3013         Make webkit-patch support subdirectories for SVN checkouts
3014         https://bugs.webkit.org/show_bug.cgi?id=52261
3015
3016         * Scripts/webkitpy/common/checkout/scm.py:
3017         * Scripts/webkitpy/style_references.py:
3018         * Scripts/webkitpy/tool/main.py:
3019         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3020
3021 2011-01-11  Eric Seidel  <eric@webkit.org>
3022
3023         Unreviewed.
3024
3025         commit-queue should know how to upload archived results (for test flakes or general failures)
3026         https://bugs.webkit.org/show_bug.cgi?id=52048
3027
3028         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3029         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3030
3031         * Scripts/webkitpy/common/system/workspace.py:
3032         * Scripts/webkitpy/common/system/workspace_unittest.py:
3033         * Scripts/webkitpy/tool/commands/queues.py:
3034
3035 2011-01-11  Sam Weinig  <sam@webkit.org>
3036
3037         Roll r75474 back in.
3038
3039 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3040
3041         Reviewed by Kenneth Rohde Christiansen.
3042
3043         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3044         https://bugs.webkit.org/show_bug.cgi?id=51204
3045
3046         * QtTestBrowser/webpage.h:
3047         (QtNAMThread::QtNAMThread):
3048         (QtNAMThread::networkAccessManager):
3049         (QtNAMThread::run):
3050
3051 2011-01-11  Peter Varga  <pvarga@webkit.org>
3052
3053         Unreviewed.
3054
3055         Add myself to committers' list.
3056
3057         * Scripts/webkitpy/common/config/committers.py:
3058
3059 2011-01-11  Eric Seidel  <eric@webkit.org>
3060
3061         Reviewed by Adam Barth.
3062
3063         commit-queue should know how to upload archived results (for test flakes or general failures)
3064         https://bugs.webkit.org/show_bug.cgi?id=52048
3065
3066         Now the queue will always upload results.  Either the entire zip, or just
3067         the diffs.txt in the case of text failures.
3068
3069         This should make understanding flakes much easier, and paves the way
3070         for having the EWS run layout tests (and upload failures).
3071
3072         In order to upload .zip files I had to teach bugzilla.py to autodetect
3073         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3074         for .patch files, I have it add one before calling guess_type.
3075
3076         We may find that always uploading the whole zip instead of just the -diffs.txt
3077         file is preferable, but for now I'm keeping the old behavior because it makes
3078         quickly understanding text failures easy.
3079
3080         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3081         * Scripts/webkitpy/common/system/workspace.py: Added.
3082         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3083         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3084         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3085         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3086         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3087         * Scripts/webkitpy/tool/commands/queues.py:
3088         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3089
3090 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3091
3092         Unreviewed, rolling out r75464.
3093         http://trac.webkit.org/changeset/75464
3094         https://bugs.webkit.org/show_bug.cgi?id=52193
3095
3096         Followup rollout for 75474 (Requested by Ossy on #webkit).
3097
3098         * MiniBrowser/mac/BrowserWindowController.m:
3099         (-[BrowserWindowController awakeFromNib]):
3100         * MiniBrowser/win/BrowserView.cpp:
3101         (BrowserView::create):
3102         * WebKitTestRunner/TestController.cpp:
3103         (WTR::createOtherPage):
3104         (WTR::TestController::initialize):
3105
3106 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3107
3108         Reviewed by Csaba Osztrogonác.
3109
3110         [Qt] Baseline qt_minimal configuration
3111         https://bugs.webkit.org/show_bug.cgi?id=51313
3112
3113         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3114         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3115         QT_NO_UNDOSTACK guard.
3116
3117         * QtTestBrowser/launcherwindow.cpp:
3118         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3119         guards.
3120         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3121         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3122         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3123         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3124
3125         * QtTestBrowser/launcherwindow.h:
3126         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3127         * QtTestBrowser/locationedit.h: Ditto.
3128
3129         * QtTestBrowser/mainwindow.cpp:
3130         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3131         QT_NO_UNDOSTACK guards.
3132         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3133         (MainWindow::changeLocation): Ditto.
3134         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3135         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3136
3137         * QtTestBrowser/webpage.cpp:
3138         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3139         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3140
3141         * QtTestBrowser/webview.cpp:
3142         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3143         (WebViewGraphicsBased::animatedYFlip): Ditto.
3144
3145 2011-01-10  Sam Weinig  <sam@webkit.org>
3146
3147         Fix build.
3148
3149         * MiniBrowser/mac/BrowserWindowController.m:
3150         (-[BrowserWindowController awakeFromNib]):
3151         * MiniBrowser/win/BrowserView.cpp:
3152         (BrowserView::create):
3153         * WebKitTestRunner/TestController.cpp:
3154         (WTR::createOtherPage):
3155         (WTR::TestController::initialize):
3156
3157 2011-01-10  Eric Seidel  <eric@webkit.org>
3158
3159         Reviewed by Ojan Vafai.
3160
3161         style-queue messages are way too long for big patches
3162         https://bugs.webkit.org/show_bug.cgi?id=52161
3163
3164         We definitely could build much fancier list-to-string-with-limit functions
3165         but this should be sufficient for our needs at the moment.
3166
3167         * Scripts/webkitpy/common/system/executive.py:
3168         * Scripts/webkitpy/common/system/executive_unittest.py:
3169
3170 2011-01-10  Tony Chang  <tony@chromium.org>
3171
3172         Unreviewed, rolling out r75398.
3173         http://trac.webkit.org/changeset/75398
3174         https://bugs.webkit.org/show_bug.cgi?id=52008
3175
3176         Some layout tests are crashing on Chromium Win.
3177
3178         * DumpRenderTree/chromium/WebViewHost.cpp:
3179         (WebViewHost::updatePaintRect):
3180         * DumpRenderTree/chromium/WebViewHost.h:
3181
3182 2011-01-10  Adam Roben  <aroben@apple.com>
3183
3184         Roll out r75392
3185
3186         It isn't needed now that r75289 has been rolled out.
3187
3188         * Scripts/run-javascriptcore-tests:
3189
3190 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3191
3192         Reviewed by Anders Carlsson.
3193
3194         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3195         https://bugs.webkit.org/show_bug.cgi?id=52160
3196
3197         * WebKitTestRunner/mac/TestControllerMac.mm:
3198         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3199         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3200         anyway.
3201
3202 2011-01-10  Tony Chang  <tony@chromium.org>
3203
3204         Reviewed by Mihai Parparita.
3205
3206         [chromium] fix for animated gif layout tests
3207         https://bugs.webkit.org/show_bug.cgi?id=52008
3208
3209         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3210             to trigger gif animations.
3211         (WebViewHostPaintTask::WebViewHostPaintTask):
3212         (WebViewHostPaintTask::runIfValid):
3213         (WebViewHost::updatePaintRect):
3214         * DumpRenderTree/chromium/WebViewHost.h:
3215         (WebViewHost::taskList):
3216
3217 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3218
3219         Reviewed by Xan Lopez.
3220
3221         [GTK] Fix gtk2 compilation for master
3222         https://bugs.webkit.org/show_bug.cgi?id=51885
3223
3224         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3225         (createBitmapContextFromWebView): Replaced the old
3226         gdk_drawable_get_size with gdk_pixmap_get_size.
3227
3228 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3229
3230         Reviewed by Laszlo Gombos.
3231
3232         [WINCE] Reenable NPAPI after r75203
3233         https://bugs.webkit.org/show_bug.cgi?id=52109
3234
3235         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3236         it with !isEfl(), because EFL port does not support NPAPI (yet).
3237
3238         * Scripts/build-webkit:
3239
3240 2011-01-10  Adam Roben  <aroben@apple.com>
3241
3242         Skip some asserting JS tests
3243
3244         See <http://webkit.org/b/52156>.
3245
3246         * Scripts/run-javascriptcore-tests:
3247
3248 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3249
3250         Reviewed by Xan Lopez.
3251
3252         [GTK] build-webkit disable Blob support via arguments passed to automake
3253         https://bugs.webkit.org/show_bug.cgi?id=52097
3254
3255         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3256         build-webkit.
3257
3258 2011-01-10  Adam Roben  <aroben@apple.com>
3259
3260         Use the same name and description for TestNetscapePlugin on Windows and
3261         Mac
3262
3263         Fixes <http://webkit.org/b/52151>
3264         fast/frames/iframe-reparenting-plugins.html fails on Windows
3265
3266         Reviewed by Steve Falkenburg.
3267
3268         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3269         the name and description from Mac's Info.plist.
3270
3271 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3272
3273         Reviewed by Laszlo Gombos.
3274
3275         [Qt][WK2] Guard gcc-specific syntax
3276
3277         Non-gcc based compliers choke on the "-include"
3278         syntax for preinclude, place guard around it.
3279
3280         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3281         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3282
3283 2011-01-10  Andreas Kling  <kling@webkit.org>
3284
3285         Reviewed by Simon Hausmann.
3286
3287         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3288         https://bugs.webkit.org/show_bug.cgi?id=52111
3289
3290         When getting a createNewPage() callback from QWKPage, create the
3291         new page with the same QWKContext as the page that is passed to
3292         the callback.
3293
3294         * MiniBrowser/qt/BrowserView.h:
3295         * MiniBrowser/qt/BrowserWindow.cpp:
3296         (newPageFunction):
3297         (BrowserWindow::BrowserWindow):
3298         * MiniBrowser/qt/BrowserWindow.h:
3299
3300 2011-01-10  Andreas Kling  <kling@webkit.org>
3301
3302         Reviewed by Kenneth Rohde Christiansen.
3303
3304         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3305
3306         BrowserView set its own useless createNewPage() callback on QWKPage.
3307         This was immediately overridden by BrowserWindow anyway, so remove
3308         the BrowserView one.
3309
3310         * MiniBrowser/qt/BrowserView.cpp:
3311         (BrowserView::BrowserView):
3312
3313 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3314
3315         Reviewed by Jeremy Orlow.
3316
3317         [Chromium] Remove non-client-based Geolocation code
3318         https://bugs.webkit.org/show_bug.cgi?id=50921
3319
3320         * DumpRenderTree/chromium/LayoutTestController.cpp:
3321         (LayoutTestController::setGeolocationPermission):
3322         (LayoutTestController::setMockGeolocationPosition):
3323         (LayoutTestController::setMockGeolocationError):
3324         * DumpRenderTree/chromium/WebViewHost.cpp:
3325         (WebViewHost::geolocationClientMock):
3326         (WebViewHost::reset):
3327         * DumpRenderTree/chromium/WebViewHost.h:
3328
3329 2011-01-10  Eric Seidel  <eric@webkit.org>
3330
3331         Reviewed by Adam Barth.
3332
3333         Commit bot tried to land r? cq+ patch
3334         https://bugs.webkit.org/show_bug.cgi?id=36638
3335
3336         It should now be possible to post a patch with r? and cq+ and the
3337         commit-queue will correctly wait for the r+ before attempting to land the patch.
3338         (This was a feature requested by several users.)
3339
3340         One caveat: We don't actually reject r-, cq+ patches from the queue
3341         (we just ignore them), but I think that's OK for now.
3342
3343         I also noticed that setting r- once a commit-queue node had grabbed
3344         a patch would not properly cancel the landing.  That's fixed and
3345         tested in this patch.
3346
3347         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3348         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3349         * Scripts/webkitpy/tool/bot/feeders.py:
3350         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3351
3352 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3353
3354         Reviewed by Kenneth Rohde Christiansen.
3355
3356         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3357         https://bugs.webkit.org/show_bug.cgi?id=51934
3358
3359         When accessing the network from the destructor of QWebPage, the network access manager
3360         was already deleted because the object WebPage was already destructed.
3361
3362         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3363         The object is now destructed in the destructor of QObject.
3364
3365         * QtTestBrowser/webpage.cpp:
3366         (WebPage::WebPage):
3367         (WebPage::setQnamThreaded):
3368         * QtTestBrowser/webpage.h:
3369         (QtNAMThread::QtNAMThread):
3370
3371 2011-01-08  Eric Seidel  <eric@webkit.org>
3372
3373         Reviewed by Ojan Vafai.
3374
3375         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3376         https://bugs.webkit.org/show_bug.cgi?id=52067
3377
3378         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3379         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3380
3381         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3382
3383 2011-01-08  Eric Seidel  <eric@webkit.org>
3384
3385         Reviewed by Mihai Parparita.
3386
3387         commit-queue hangs when the ChangeLog diff is bad
3388         https://bugs.webkit.org/show_bug.cgi?id=52072
3389
3390         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3391         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3392
3393 2011-01-08  Adam Barth  <abarth@webkit.org>
3394
3395         Teach svn-apply how to re-write WebCore to Source/WebCore.
3396
3397         * Scripts/VCSUtils.pm:
3398
3399 2011-01-07  Adam Barth  <abarth@webkit.org>
3400
3401         Rubber-stamped by Eric Seidel.
3402
3403         Move WebCore to Source
3404         https://bugs.webkit.org/show_bug.cgi?id=52050
3405
3406         Update the tools to understand WebCore's new location.
3407
3408         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3409         * DumpRenderTree/wscript:
3410         * GNUmakefile.am:
3411         * Scripts/build-webkit:
3412         * Scripts/do-file-rename:
3413         * Scripts/do-webcore-rename:
3414         * Scripts/generate-qt-inspector-resource:
3415         * Scripts/prepare-ChangeLog:
3416         * Scripts/run-bindings-tests:
3417         * Scripts/update-iexploder-cssproperties:
3418         * Scripts/update-sources-list.py:
3419         * Scripts/update-webkit-localizable-strings:
3420         * Scripts/webkitdirs.pm:
3421         * Scripts/webkitpy/common/config/build.py:
3422         * Scripts/webkitpy/common/config/build_unittest.py:
3423         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3424         * Scripts/webkitpy/style/checker.py:
3425         * Scripts/webkitpy/style/checker_unittest.py:
3426         * WebKitTestRunner/DerivedSources.pro:
3427         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3428         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3429         * wx/browser/wscript:
3430         * wx/build/settings.py:
3431
3432 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3433
3434         Reviewed by Sam Weinig.
3435
3436         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3437         https://bugs.webkit.org/show_bug.cgi?id=52086
3438
3439         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3440         (WTR::InjectedBundle::didReceiveMessage):
3441         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3442         (WTR::LayoutTestController::notifyDone):
3443         * WebKitTestRunner/TestController.cpp:
3444         (WTR::TestController::resetStateToConsistentValues):
3445         (WTR::TestController::run):
3446
3447 2011-01-07  James Robinson  <jamesr@chromium.org>
3448
3449         Revert "Implement mozilla's animationTime property"
3450         https://bugs.webkit.org/show_bug.cgi?id=51952
3451
3452         This approach isn't quite right.
3453
3454         * DumpRenderTree/chromium/WebViewHost.cpp:
3455         (WebViewHost::paintInvalidatedRegion):
3456
3457 2011-01-07  Adam Roben  <aroben@apple.com>
3458
3459         Build master fix
3460
3461         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3462         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3463
3464 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3465
3466         Reviewed by Csaba Osztrogonác.
3467
3468         run-qtwebkit-tests should be able to kill a testsuite.
3469
3470         Add new option in the script that can setup a timeout for a test.
3471         If the test execution takes more then specified time then the test
3472         would be terminated.
3473
3474         [Qt] run-qtwebkit-tests needs timeout
3475         https://bugs.webkit.org/show_bug.cgi?id=51894
3476
3477         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3478         * Scripts/run-qtwebkit-tests:
3479
3480 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3481
3482         Unreviewed fix after r75233.
3483
3484         Based on idea from Eric Seidel.
3485
3486         Add remote zip file handling to webkitpy.
3487         https://bugs.webkit.org/show_bug.cgi?id=50901
3488
3489         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3490
3491 2011-01-07  Shane Stephens  <shanestephens@google.com>
3492
3493         Reviewed by Eric Seidel.
3494
3495         svn-apply: should support git binary delta diffs
3496         https://bugs.webkit.org/show_bug.cgi?id=38864
3497
3498         * Scripts/VCSUtils.pm:
3499         * Scripts/svn-apply:
3500
3501 2011-01-06  Julie Parent  <jparent@chromium.org>
3502
3503         Reviewed by Eric Seidel.
3504
3505         Test Result Server not removing old results.
3506         https://bugs.webkit.org/show_bug.cgi?id=52012
3507
3508         * TestResultServer/model/jsonresults.py:
3509         Fix off-by-one: Truncate if >= num_runs, not just >.
3510         * TestResultServer/model/jsonresults_unittest.py:
3511         Add unit test to test that merging in a new result with the same value
3512         as the last result causes previous result to fall off.
3513
3514 2011-01-06  James Kozianski  <koz@chromium.org>
3515
3516         Reviewed by Mihai Parparita.
3517
3518         Add classes to provide a consistent interface to a set of files.
3519         https://bugs.webkit.org/show_bug.cgi?id=50901
3520
3521         These classes allow us to write code that is agnostic to whether a
3522         particular set of files resides in a local directory or in a zip file
3523         on a remote machine.
3524
3525         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3526         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3527         * Scripts/webkitpy/common/system/fileset.py: Added.
3528         * Scripts/webkitpy/common/system/filesystem.py:
3529         * Scripts/webkitpy/common/system/filesystem_mock.py:
3530         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3531         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3532
3533 2011-01-06  Eric Seidel  <eric@webkit.org>
3534
3535         Reviewed by Adam Barth.
3536
3537         NetworkTransaction should log the url it is retrying
3538         https://bugs.webkit.org/show_bug.cgi?id=52043
3539
3540         * Scripts/webkitpy/common/net/networktransaction.py:
3541         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3542
3543 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3544
3545         Windows build fix.
3546         Import os before using it.
3547
3548         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3549
3550 2011-01-06  Eric Seidel  <eric@webkit.org>
3551
3552         Reviewed by Adam Barth.
3553
3554         StyleQueue fails to report errors when patches have many files
3555         https://bugs.webkit.org/show_bug.cgi?id=52042
3556
3557         This is one of at least two errors preventing style error reporting at the moment.
3558         When we moved to passing the list of files to check explicitly,
3559         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3560         We could change the type of the QueueStatus.message type, or we could
3561         just teach statusserver.py how to clamp values (and warn when it does).
3562         I chose the latter path.
3563
3564         * Scripts/webkitpy/common/net/statusserver.py:
3565
3566 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3567
3568         Reviewed by Stephanie Lewis.
3569         
3570         Fix syntax error in script.
3571
3572         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3573         https://bugs.webkit.org/show_bug.cgi?id=51996
3574
3575         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3576
3577 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3578
3579         Unreviewed, fixing WinCE build after r75196.
3580
3581         WinCE port does not (yet) support NPAPI.
3582
3583         * Scripts/build-webkit:
3584
3585 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3586
3587         Reviewed by Darin Adler.
3588
3589         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3590         https://bugs.webkit.org/show_bug.cgi?id=52015
3591
3592         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3593         after the platform has been detected, otherwise the script will
3594         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3595         detection.
3596
3597 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3598
3599         Reviewed by Eric Seidel.
3600
3601         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3602         https://bugs.webkit.org/show_bug.cgi?id=51346
3603
3604         * Scripts/build-webkit:
3605
3606 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3607
3608         Reviewed by Adam Roben.
3609
3610         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3611         https://bugs.webkit.org/show_bug.cgi?id=51996
3612         
3613         After the configuration directory change, we were archiving the incorrect directory for
3614         build product, so we were running tests on the wrong binaries.
3615         
3616         This change archives the correct directory, and also unarchives it into a configuration-
3617         specific directory.
3618
3619         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3620         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3621
3622 2011-01-06  Eric Seidel  <eric@webkit.org>
3623
3624         Reviewed by Mihai Parparita.
3625
3626         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3627         https://bugs.webkit.org/show_bug.cgi?id=52002
3628
3629         See an example of this here:
3630         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3631
3632         It's due to the fact that we pass around TestFailure() instance
3633         objects and yet expect them to all compare to be the same.
3634
3635         This is bad.  We should either have shared instances of these values
3636         or we should just pass around the class names.  There are already hacks
3637         in place to make TestFailure objects pass equality tests, I just added
3638         a __hash__ implementation so they can be used in sets as expected.
3639
3640         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3641         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3642
3643 2011-01-06  Evan Martin  <evan@chromium.org>
3644
3645         Reviewed by Tony Chang.
3646
3647         [gdb] handle inaccessible memory and UChar*
3648         https://bugs.webkit.org/show_bug.cgi?id=52003
3649
3650         To pretty-print a UChar*, we just grope around in the memory
3651         looking for a terminating NUL.  We need to handle the exception
3652         that can occur when we poke into an invalid location.
3653
3654         Additionally, the logic for choosing which pretty-printer would
3655         early return before hitting the point where we'd use the UChar*
3656         printer.  (Did this ever work?  How did it regress?)
3657
3658         * gdb/webkit.py:
3659
3660 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3661
3662         Reviewed by Ada Chan.
3663
3664         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3665         https://bugs.webkit.org/show_bug.cgi?id=51969
3666         
3667         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3668
3669         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3670         (WTR::InjectedBundlePage::InjectedBundlePage):
3671         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3672         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3673
3674 2011-01-06  James Robinson  <jamesr@chromium.org>
3675
3676         Reviewed by Simon Fraser.
3677
3678         Implement mozilla's animationTime property
3679         https://bugs.webkit.org/show_bug.cgi?id=51952
3680
3681         Chromium DRT support for webkitAnimationTime.
3682
3683         * DumpRenderTree/chromium/WebViewHost.cpp:
3684         (WebViewHost::paintInvalidatedRegion):
3685
3686 2011-01-06  Julie Parent  <jparent@chromium.org>
3687
3688         Reviewed by Tony Chang.
3689
3690         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3691         https://bugs.webkit.org/show_bug.cgi?id=51217
3692
3693         * TestResultServer/model/jsonresults.py:
3694         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3695         Adds missing documentation.
3696         * TestResultServer/model/jsonresults_unittest.py:
3697         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3698         Update test_merge to take a number of builds to truncate at.
3699
3700 2011-01-06  Adam Barth  <abarth@webkit.org>
3701
3702         Reviewed by Eric Seidel.
3703
3704         The EWS should log outside of the working directory
3705         https://bugs.webkit.org/show_bug.cgi?id=51986
3706
3707         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3708         script, which will actually clean the working copy back to a pristine
3709         state instead of leaving untracked directories and ignored files.
3710
3711         * Scripts/webkitpy/tool/commands/queues.py:
3712         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3713
3714 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3715
3716         Windows build fix.
3717         Back out attempted change to built-product-archive.
3718
3719         * BuildSlaveSupport/built-product-archive:
3720
3721 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3722
3723         Windows build fix.
3724         Include configuration name when unpacking a build archive.
3725
3726         Needed, since we split Windows build results into configuration-specific directories
3727         under WebKitOutputDir.
3728
3729         * BuildSlaveSupport/built-product-archive:
3730
3731 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3732
3733         Reviewed by Darin Adler.
3734
3735         Debug and Release builds on Windows clobber each other
3736         https://bugs.webkit.org/show_bug.cgi?id=49185
3737
3738         Changes the structure of WebKitBuild build products directory so we
3739         completely separate each build configuration into independent directories.
3740         
3741         Although we previously had per-configuration directories for obj, this change adds
3742         per-configuration directories for bin, lib, obj, and include. Each configuration's
3743         build products are stored within a directory inside of WebKitBuild.
3744         
3745         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3746         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3747
3748         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3749         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3750         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3751         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3752         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3753         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3754         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3755         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3756         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3757         * FindSafari/FindSafari.vcproj:
3758         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3759         * MiniBrowser/MiniBrowserPostBuild.cmd:
3760         * MiniBrowser/MiniBrowserPreBuild.cmd:
3761         * Scripts/webkitdirs.pm:
3762         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3763         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3764         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3765         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3766         * TestWebKitAPI/win/copy-resources.cmd:
3767         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3768         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3769         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3770         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3771         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3772         * WebKitTestRunner/win/InjectedBundle.vcproj:
3773         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3774         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3775         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3776         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3777         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3778         * WinLauncher/WinLauncherCommon.vsprops:
3779         * WinLauncher/WinLauncherPostBuild.cmd:
3780         * WinLauncher/WinLauncherPreBuild.cmd:
3781
3782 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3783
3784         Reviewed by Ariya Hidayat.
3785
3786         [Qt] TestNetscapePlugin doesn't link on OS X
3787         https://bugs.webkit.org/show_bug.cgi?id=51948
3788
3789         Only add a dependency on libX11 on X11 systems
3790
3791         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3792
3793 2011-01-05  Jeff Miller  <jeffm@apple.com>
3794
3795         Reviewed by Adam Roben.
3796
3797         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3798         https://bugs.webkit.org/show_bug.cgi?id=51970
3799
3800         * Scripts/webkitpy/style/checker.py:
3801         Add -readability/naming for WebKit2 C API directories.
3802
3803 2011-01-05  Eric Seidel  <eric@webkit.org>
3804
3805         Unreviewed, just fixing one more log error from my previous python patch.
3806
3807         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3808         https://bugs.webkit.org/show_bug.cgi?id=51802
3809
3810         webkit-patch failure-reason was logging about parsing errors
3811         due to my misunderstanding of how BeautifulSoup.findAll worked.
3812
3813         Fixed, and added a unit test.
3814
3815         * Scripts/webkitpy/common/net/layouttestresults.py:
3816         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3817
3818 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3819
3820         Reviewed by Kenneth Rohde Christiansen.
3821
3822         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3823         https://bugs.webkit.org/show_bug.cgi?id=51951
3824
3825         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3826         to create new window from WebKit.
3827
3828         * MiniBrowser/qt/BrowserWindow.cpp:
3829         (newPageFunction):
3830         (BrowserWindow::BrowserWindow):
3831         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3832         (BrowserWindow::newWindow):
3833         (BrowserWindow::updateUserAgentList):
3834         (BrowserWindow::showUserAgentDialog):
3835         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3836         define the type of the backing store used for new windows.
3837         * MiniBrowser/qt/main.cpp:
3838         (main):
3839
3840 2011-01-05  Eric Seidel  <eric@webkit.org>
3841
3842         Reviewed by Ojan Vafai.
3843
3844         commit-queue should report failure type when reporting flaky tests
3845         https://bugs.webkit.org/show_bug.cgi?id=51900
3846
3847         This patch was a ridiculous amount of plumbing.  In the end I like
3848         the NRWT-style TestResult class even less.  But now we're passing
3849         a list of TestResult objects from the queue to the FlakyTestReporter.
3850         Thus the FlakyTestReporter can more easily report what type of failure
3851         occurred.
3852
3853         In the process, I found that I was not alone in finding TestResult
3854         cumbersome to use.  A bunch of code was trying to create a TestResult
3855         object with default values.  However since the constructor didn't make
3856         this easy, some places were getting it wrong (including the TestResult unit test)!
3857         I've fixed the TestResult constructor to have default values for non-essential
3858         arguments.
3859
3860         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3861         * Scripts/webkitpy/common/net/layouttestresults.py:
3862         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3863         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3864         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3865         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3866         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3867         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3868         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3869         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3870         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3871         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3872         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3873         * Scripts/webkitpy/tool/commands/queues.py:
3874         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3875
3876 2011-01-05  Eric Seidel  <eric@webkit.org>
3877
3878         Unreviewed.
3879
3880         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3881         https://bugs.webkit.org/show_bug.cgi?id=51802
3882
3883         Add another unit test to cover a previously missing import.
3884
3885         * Scripts/webkitpy/common/net/layouttestresults.py:
3886         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3887
3888 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3889
3890         Reviewed by David Levin.
3891
3892         Add mihaip@chromium.org as a reviewer
3893         https://bugs.webkit.org/show_bug.cgi?id=51966
3894         
3895         Add myself as a reviewer.
3896
3897         * Scripts/webkitpy/common/config/committers.py:
3898
3899 2011-01-05  James Simonsen  <simonjam@chromium.org>
3900
3901         Unreviewed. Adding myself to the list of committers.
3902
3903         * Scripts/webkitpy/common/config/committers.py:
3904
3905 2011-01-05  Eric Seidel  <eric@webkit.org>
3906
3907         Unreviewed.
3908
3909         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3910         https://bugs.webkit.org/show_bug.cgi?id=51802
3911
3912         Fix two exceptions seen on the bots after my original commit.
3913
3914         * Scripts/webkitpy/common/net/layouttestresults.py:
3915         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3916
3917 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3918
3919         Reviewed by Andreas Kling.
3920
3921         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3922         https://bugs.webkit.org/show_bug.cgi?id=51750
3923
3924         * QtTestBrowser/main.cpp:
3925         (LauncherApplication::handleUserOptions):
3926          Local storage settings can be enable form command line arguments for
3927          QtTestBrowser.
3928
3929 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3930
3931         Reviewed by Martin Robinson.
3932
3933         GTK: AX: DRT needs to use correct root object method.
3934         https://bugs.webkit.org/show_bug.cgi?id=51911
3935
3936         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3937         (AccessibilityController::rootElement):
3938
3939 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3940
3941         Rubber-stamped by Csaba Osztrogonác.
3942
3943         Based on idea from Péter Gál.
3944
3945         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3946
3947 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3948
3949         Reviewed by Adam Barth.
3950
3951         sheriff-bot should be able to do multi-revision rollouts
3952         https://bugs.webkit.org/show_bug.cgi?id=51176
3953
3954         * Scripts/webkitpy/tool/bot/irc_command.py:
3955         * Scripts/webkitpy/tool/bot/sheriff.py:
3956         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3957
3958 2011-01-05  Eric Seidel  <eric@webkit.org>
3959
3960         Reviewed by Adam Barth.
3961
3962         queues.webkit.org should have per-bot status pages
3963         https://bugs.webkit.org/show_bug.cgi?id=51906
3964
3965         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3966         statuses from a single queue.  Now that we have many bots servicing
3967         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3968         you care about scroll off the end of the 15-message limit on the main page.
3969
3970         Eventually we should probably rename /queue-status to /queue or /queues,
3971         but that's fodder for another patch.
3972
3973         * QueueStatusServer/handlers/queuestatus.py:
3974         * QueueStatusServer/index.yaml:
3975         * QueueStatusServer/main.py:
3976         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3977          - This probably should use a custom filter instead of hard-coding
3978            the URL scheme here, but I couldn't figure out how to easily
3979            create such a filter.  Most filters work with "strings" so we can't
3980            pass the status object.  We could add a method to the status
3981            object and call that, but that seemed a bit strange too.
3982         * QueueStatusServer/templates/queuestatus.html:
3983
3984 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3985
3986         Unreviewed. Adding myself to the list of committers.
3987
3988         * Scripts/webkitpy/common/config/committers.py:
3989
3990 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3991
3992         Reviewed by David Levin.
3993
3994         check-webkit-style treated some macros with parentheses after #elif as function calls
3995         https://bugs.webkit.org/show_bug.cgi?id=51695
3996
3997         Ingore function call space checking in any preprocessor directives
3998         (things starting with #). Change search() to match() because 
3999         preprocessor directives are supposed to be in the beginning of lines.
4000
4001         * Scripts/webkitpy/style/checkers/cpp.py:
4002         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
4003
4004 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
4005
4006         Reviewed by Tony Chang.
4007
4008         Change the --multi-load test option to --stress-opt
4009         https://bugs.webkit.org/show_bug.cgi?id=50751
4010
4011         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4012         (runTest):
4013         (main):
4014         * DumpRenderTree/chromium/TestShell.cpp:
4015         (TestShell::TestShell):
4016         * DumpRenderTree/chromium/TestShell.h:
4017         (TestShell::stressOpt):
4018         (TestShell::setStressOpt):
4019         (TestShell::stressDeopt):
4020         (TestShell::setStressDeopt):
4021         (TestShell::javaScriptFlags):
4022         (TestShell::setJavaScriptFlags):
4023         * Scripts/webkitpy/layout_tests/port/chromium.py:
4024         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4025
4026 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
4027
4028         Reviewed by Sam Weinig.
4029
4030         WK2: Support Accessibility
4031         https://bugs.webkit.org/show_bug.cgi?id=51859
4032
4033         Use rootObject() method to get top of accessibility tree.
4034
4035         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4036         (AccessibilityController::focusedElement):
4037         (AccessibilityController::rootElement):
4038
4039 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
4040
4041         Reviewed by Darin Adler.
4042
4043         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
4044         https://bugs.webkit.org/show_bug.cgi?id=51846
4045
4046         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
4047         back to GRefPtr.
4048
4049 2011-01-04  Zhe Su  <suzhe@chromium.org>
4050
4051         Reviewed by Kenneth Russell.
4052
4053         Fix insertText, setMarkedText and unmarkText methods of
4054         TextInputController to call corresponding methods of WebKit::WebView
4055         rather than WebKit::WebFrame. This change matches the behavior of
4056         chromium browser.
4057         insertText corresponds to WebView::confirmComposition(text)
4058         setMarkedText corresponds to WebView::setComposition(...)
4059         unmarkText corresponds to WebView::confirmComposition()
4060         https://bugs.webkit.org/show_bug.cgi?id=51693
4061
4062         * DumpRenderTree/chromium/TextInputController.cpp:
4063         (TextInputController::insertText):
4064         (TextInputController::setMarkedText):
4065         (TextInputController::unmarkText):
4066
4067 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
4068
4069         Reviewed by Laszlo Gombos.
4070
4071         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
4072
4073         On Symbian productDir points to the source directory. Removing all the
4074         empty files from the productDir directory corrupts the svn repository.
4075
4076         * Scripts/build-webkit:
4077
4078 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
4079
4080         Reviewed by Adam Barth.
4081
4082         [Qt] Add SelectAll option to the context menu for the editor
4083         https://bugs.webkit.org/show_bug.cgi?id=50049
4084
4085         Set shortcut for the SelectAll action.
4086
4087         * QtTestBrowser/mainwindow.cpp:
4088         (MainWindow::buildUI):
4089
4090 2011-01-03  David Levin  <levin@chromium.org>
4091
4092         Reviewed by Eric Seidel.
4093
4094         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
4095         https://bugs.webkit.org/show_bug.cgi?id=51842
4096
4097         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
4098         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
4099
4100 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4101
4102         Reviewed by David Kilzer.
4103
4104         [WINCE] Adds a build slave.
4105         https://bugs.webkit.org/show_bug.cgi?id=50523
4106
4107         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
4108         entry for a release build of the WinCE port.
4109         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
4110         flag to build the WinCE port.
4111
4112 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4113
4114         Reviewed by David Kilzer.
4115
4116         Add WinCE support to build-webkit
4117         https://bugs.webkit.org/show_bug.cgi?id=51642
4118
4119         * Scripts/build-webkit:
4120         * Scripts/webkitdirs.pm:
4121
4122 2011-01-03  Eric Seidel  <eric@webkit.org>
4123
4124         Reviewed by Adam Barth.
4125
4126         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4127         https://bugs.webkit.org/show_bug.cgi?id=51802
4128
4129         I'm not the biggest fan of the test_failures or test_results classes,
4130         but it's better to have one shared set of classes, than separate ones
4131         for new vs. old run-webkit-test result handling.
4132
4133         This moves the ORWT results class "LayoutTestResults" over to using
4134         TestResult and TestFailure classes, making it easy for us to
4135         make all our sheriff-bot and other webkitpy code NRWT ready.
4136
4137         This also makes it a trivial patch to generate results.json information
4138         from ORWT results.html files (for flaky test analysis, etc.) as well
4139         as making it a one-liner to report test failure types when the
4140         commit-queue sees flaky tests.
4141
4142         This patch tried not to add new functionality, but only to replace
4143         the guts of LayoutTestResults, while adding unit tests and hoping
4144         not to break anything.
4145
4146         I also moved callers which assumed User.prompt* were static/class methods
4147         to using them as instance methods (since we'll eventually want to make them such).
4148
4149         In the process of re-writing things, I broke the rebaseline command, so I wrote
4150         a unit test to catch my breakage were I do do so again in the future.
4151
4152         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4153         * Scripts/webkitpy/common/net/layouttestresults.py:
4154         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4155         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4156         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
4157         * Scripts/webkitpy/tool/commands/queries.py:
4158         * Scripts/webkitpy/tool/commands/rebaseline.py:
4159         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4160         * Scripts/webkitpy/tool/mocktool.py:
4161
4162 2011-01-03  Adam Barth  <abarth@webkit.org>
4163
4164         Reviewed by Simon Fraser.
4165
4166         webkit-patch shouldn't waste time cleaning a working directory that's already clean
4167         https://bugs.webkit.org/show_bug.cgi?id=51840
4168
4169         * Scripts/webkitpy/common/checkout/scm.py:
4170
4171 2011-01-03  Adam Barth  <abarth@webkit.org>
4172
4173         Reviewed by Simon Fraser.
4174
4175         webkit-patch should only hide update output if --quiet
4176         https://bugs.webkit.org/show_bug.cgi?id=51838
4177
4178         As requested by smfr.
4179
4180         * Scripts/webkitpy/tool/steps/update.py:
4181
4182 2011-01-03  Adam Barth  <abarth@webkit.org>
4183
4184         Reviewed by David Levin.
4185
4186         commit-queue shouldn't reject patches twice if two bots process the same patch
4187         https://bugs.webkit.org/show_bug.cgi?id=51805
4188
4189         Before raising an error, we first check whether the patch is still in
4190         the commit-queue.  This check is still racy, of course, but the time
4191         window is much smaller.
4192
4193         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4194
4195 2011-01-03  Sam Weinig  <sam@webkit.org>
4196
4197         Reviewed by Anders Carlsson.
4198
4199         Make run-api-tests less chatty.
4200         https://bugs.webkit.org/show_bug.cgi?id=51831
4201
4202         - Make script quiet by default and add --verbose option (replacing --quiet).
4203         - When not verbose, pipe stdout and stderr to devnull.
4204
4205         * Scripts/run-api-tests:
4206
4207 2011-01-03  Pratik Solanki  <psolanki@apple.com>
4208
4209         Unreviewed. Adding myself to committers.py.
4210
4211         * Scripts/webkitpy/common/config/committers.py:
4212
4213 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
4214
4215         Reviewed by Xan Lopez.
4216
4217         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
4218         https://bugs.webkit.org/show_bug.cgi?id=51806
4219
4220         Originally, the $libraryName is 'JavaScriptCore'. When building release 
4221         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
4222         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
4223         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
4224         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
4225         so make it 'WebKitBuild/Release/.libs'
4226
4227         * Scripts/webkitdirs.pm: 
4228
4229 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
4230
4231         Reviewed by Adam Barth.
4232
4233         Make EFL a core builder
4234         https://bugs.webkit.org/show_bug.cgi?id=51804
4235
4236         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4237         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4238
4239 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4240
4241         [Qt] Unreviewed fix after r74855 and r74875.
4242
4243         * BuildSlaveSupport/built-product-archive:
4244          - Create directories explicitly.
4245          - Pass shell=True to subprocess.call().
4246
4247 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4248
4249         [Qt] Unreviewed fix after r74855.
4250
4251         Move JavaScriptCore to Source
4252         https://bugs.webkit.org/show_bug.cgi?id=51604
4253
4254         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
4255
4256 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4257
4258         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
4259
4260         Move JavaScriptCore to Source
4261         https://bugs.webkit.org/show_bug.cgi?id=51604
4262
4263         * Scripts/webkitdirs.pm:
4264
4265 2011-01-02  Robert Hogan  <robert@webkit.org>
4266
4267         Unreviewed, build fix.
4268
4269         [Qt] Fix DRT build after 74855
4270
4271         * DumpRenderTree/qt/DumpRenderTree.pro:
4272
4273 2011-01-01  Adam Barth  <abarth@webkit.org>
4274
4275         Remove the assumption from the Qt and Gtk builds that every project is
4276         in the root directory.
4277
4278         * Scripts/build-webkit:
4279
4280 2011-01-01  Adam Barth  <abarth@webkit.org>
4281
4282         Reviewed by Eric Seidel.
4283
4284         Teach svn-apply how to apply patches even though JavaScriptCore has moved
4285         https://bugs.webkit.org/show_bug.cgi?id=51796
4286
4287         After this change, svn-apply will magically apply patches to
4288         JavaScriptCore/foo to Source/JavaScriptCore/foo.
4289
4290         * Scripts/VCSUtils.pm:
4291
4292 2011-01-01  Adam Barth  <abarth@webkit.org>
4293
4294         Reviewed by Eric Seidel.
4295
4296         Move JavaScriptCore to Source
4297         https://bugs.webkit.org/show_bug.cgi?id=51604
4298
4299         Update references to JavaScriptCore to point to the new location.
4300
4301         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4302         * DumpRenderTree/qt/DumpRenderTree.pro:
4303         * DumpRenderTree/qt/ImageDiff.pro:
4304         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4305         * DumpRenderTree/wscript:
4306         * Scripts/build-jsc:
4307         * Scripts/build-webkit:
4308         * Scripts/do-file-rename:
4309         * Scripts/do-webcore-rename:
4310         * Scripts/run-javascriptcore-tests:
4311         * Scripts/update-javascriptcore-test-results:
4312         * Scripts/webkitdirs.pm:
4313         * Scripts/webkitpy/common/config/build_unittest.py:
4314         * Scripts/webkitpy/style/checker.py:
4315         * Scripts/webkitpy/style/checker_unittest.py:
4316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4317         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4318         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4319         * wx/build/settings.py:
4320
4321 2011-01-01  Adam Barth  <abarth@webkit.org>
4322
4323         Reviewed by Eric Seidel.
4324
4325         Move Sources to Source
4326         https://bugs.webkit.org/show_bug.cgi?id=51794
4327
4328         Update scripts to point to the new location.
4329
4330         * Scripts/build-webkit:
4331         * Scripts/do-file-rename:
4332         * Scripts/do-webcore-rename:
4333         * Scripts/webkitpy/common/config/build.py:
4334         * Scripts/webkitpy/common/config/build_unittest.py:
4335
4336 2010-12-31  Kent Tamura  <tkent@chromium.org>
4337
4338         Reviewed by Eric Seidel.
4339
4340         [DRT/Chromium] Enable mock spell checker on non-OSX
4341         https://bugs.webkit.org/show_bug.cgi?id=51401
4342
4343         * DumpRenderTree/chromium/WebViewHost.cpp:
4344         (WebViewHost::spellCheck):
4345
4346 2010-12-31  Adam Barth  <abarth@webkit.org>
4347
4348         Reviewed by Ariya Hidayat.
4349
4350         Remove Tools/Scripts/wkstyle
4351         https://bugs.webkit.org/show_bug.cgi?id=51774
4352
4353         This script appears to not have been touched in a while and seems to
4354         have been replaced by check-webkit-style.
4355
4356         * Scripts/wkstyle: Removed.
4357
4358 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4359
4360         Unreviewed. Coding style fix.
4361
4362         * DumpRenderTree/chromium/TestShell.h:
4363
4364 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4365
4366         Reviewed by Pavel Feldman.
4367
4368         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
4369
4370         It was a problem with Chromium DRT. DevToolsAgent object instance was
4371         attached not only to the inspected page but to the DevTools window too.
4372         As result all the inspector files were interpreted as a content of inspected page
4373         and were transfered to the DevTools scripts panel for debugging etc.
4374
4375         https://bugs.webkit.org/show_bug.cgi?id=51735
4376
4377         * DumpRenderTree/chromium/TestShell.cpp:
4378         (TestShell::TestShell):
4379         (TestShell::bindJSObjectsToWindow):
4380         (TestShell::createNewWindow):
4381         * DumpRenderTree/chromium/TestShell.h:
4382
4383 2010-12-31  Adam Barth  <abarth@webkit.org>
4384
4385         Rubber-stamped by Eric Seidel.
4386
4387         Move PageLoadTests to PerformanceTests/PageLoad
4388         https://bugs.webkit.org/show_bug.cgi?id=51771
4389
4390         Update references to PageLoadTests to point to the new location.
4391
4392         * Scripts/run-pageloadtest:
4393         * Scripts/webkitpy/common/config/build.py:
4394
4395 2010-12-31  Adam Barth  <abarth@webkit.org>
4396
4397         Rubber-stamped by Eric Seidel.
4398
4399         Move SunSpider into PerformanceTests
4400         https://bugs.webkit.org/show_bug.cgi?id=51769
4401
4402         Update these scripts to point to the new location.
4403
4404         * Scripts/run-sunspider:
4405         * Scripts/sunspider-compare-results:
4406
4407 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
4408
4409         Reviewed by Kent Tamura.
4410
4411         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
4412         https://bugs.webkit.org/show_bug.cgi?id=51728
4413         
4414         Add implementation of the Mac WebThemeEngine that uses an NSScroller
4415         to render top-level scrollbars. This makes them match the Mac port's
4416         use of an NSScrollView, which means that we'll be able to share more
4417         pixel baselines.
4418         
4419         The new rendering code will not be activated until the 
4420         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
4421         ScrollbarThemeChromiumMac.
4422
4423         * DumpRenderTree/DumpRenderTree.gypi:
4424         * DumpRenderTree/chromium/TestShellMac.mm:
4425         (platformInit):
4426         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
4427         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
4428         (+[FakeActiveWindow alwaysActiveWindow]):
4429         (+[FakeActiveWindow alwaysInactiveWindow]):
4430         (-[FakeActiveWindow initWithActiveControls:]):
4431         (-[FakeActiveWindow _hasActiveControls]):
4432         (WebThemeEngineDRTMac::paintScrollbarThumb):
4433         (stateToHIEnableState):
4434         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
4435         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
4436
4437 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
4438
4439         Reviewed by David Kilzer.
4440
4441         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
4442         used
4443         https://bugs.webkit.org/show_bug.cgi?id=51672
4444
4445         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
4446         with USE_SYSTEM_MALLOC=1
4447         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
4448         with USE_SYSTEM_MALLOC=1
4449
4450 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4451
4452         Reviewed by David Kilzer.
4453
4454         [Qt] [Symbian] Fix build-webkit script for Symbian
4455         https://bugs.webkit.org/show_bug.cgi?id=51509
4456
4457         Set the OUTPUT_DIR for Symbian to be the same as the source
4458         directory.
4459
4460         * Scripts/webkitdirs.pm:
4461
4462 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
4463
4464         Reviewed by Darin Adler.
4465
4466         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
4467         https://bugs.webkit.org/show_bug.cgi?id=51758
4468
4469         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
4470
4471         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
4472         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
4473
4474 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
4475
4476         Unreviewed WinCE buildfix.
4477
4478         * WinCELauncher/main.cpp: Add missing include.
4479
4480 2010-12-29  Daniel Bates  <dbates@rim.com>
4481
4482         Reviewed by Darin Adler.
4483
4484         svn-apply updates date of wrong change log entry for a change log diff that
4485         contains two consecutive entries with the same author and date
4486         https://bugs.webkit.org/show_bug.cgi?id=46061
4487
4488         Fixes an issue where the date of the wrong change log entry may be modified.
4489         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
4490         in a ChangeLog file to the top of the file.
4491
4492         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
4493         diff when it detects that the diff inserts a change log entry earlier in a
4494         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
4495         change. With the advent of the commit-queue this functionality of bailing out
4496         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
4497         Instead, we should always move the change log entry to the top of the ChangeLog file.
4498
4499         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
4500         the date line of the correct change log entry in a ChangeLog diff.
4501
4502         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
4503
4504         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
4505           Updated the following unit tests now that we move entries inserted earlier to the top:
4506           - "fixChangeLogPatch: New entry inserted in middle."
4507             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
4508
4509           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
4510             (formerly named