2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
[WebKit.git] / Tools / ChangeLog
1 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Unreviewed Chromium build fix.
4
5         * DumpRenderTree/chromium/LayoutTestController.cpp:
6         (LayoutTestController::pathToLocalResource):
7
8 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
9
10         Reviewed by Darin Adler.
11
12         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
13         https://bugs.webkit.org/show_bug.cgi?id=52867
14
15         * DumpRenderTree/chromium/ImageDiff.cpp:
16         (Image::craeteFromStdin): Call adoptArrayPtr.
17
18 2011-02-06  James Kozianski  <koz@chromium.org>
19
20         Reviewed by Ojan Vafai.
21
22         Add classes for representing test outputs.
23         https://bugs.webkit.org/show_bug.cgi?id=52136
24
25         These classes will make it easier to write scripts that deal with test
26         outputs such as rebaselining and deduping scripts. The intent is that
27         eventually we will be have buildbot return TestOutputs for a
28         particular build which can be compared with TestOutputs derived from a
29         local LayoutTests directory.
30
31         * Scripts/webkitpy/common/net/testoutput.py: Added.
32         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
33         * Scripts/webkitpy/common/net/testoutputset.py: Added.
34         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
35         * Scripts/webkitpy/common/system/zip_mock.py: Added.
36
37 2011-02-06  Robert Hogan  <robert@webkit.org>
38
39         Reviewed by Andreas Kling.
40
41         [Qt] Clear page's groupName even when not in DRT
42         https://bugs.webkit.org/show_bug.cgi?id=53874
43
44         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
45         (WebCore::DumpRenderTree::windowCloseRequested):
46
47 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
48
49         Reviewed by Andreas Kling.
50
51         [CMake] Add dependencies for Visual Studio projects
52         https://bugs.webkit.org/show_bug.cgi?id=53773
53
54         Add a WebKit dependecy to WinCELauncher, so CMake can 
55         generate the correct build order for the solution.
56
57         * CMakeListsWinCE.txt:
58
59 2011-02-06  Andreas Kling  <kling@webkit.org>
60
61         Reviewed by Antonio Gomes.
62
63         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
64         https://bugs.webkit.org/show_bug.cgi?id=53869
65
66         * MiniBrowser/qt/BrowserView.cpp:
67         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
68         * MiniBrowser/qt/BrowserWindow.cpp:
69         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
70         * MiniBrowser/qt/BrowserWindow.h:
71
72 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
73
74         Reviewed by Dan Bernstein.
75
76         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
77         https://bugs.webkit.org/show_bug.cgi?id=42690
78         <rdar://problem/8213851>
79
80         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
81         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
82         (WTR::InjectedBundlePage::willSendRequestForFrame):
83         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
84         (WTR::LayoutTestController::LayoutTestController):
85         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
86         (WTR::LayoutTestController::willSendRequestReturnsNull):
87         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
88
89 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
90
91         Unreviewed, rolling out r77720.
92         http://trac.webkit.org/changeset/77720
93         https://bugs.webkit.org/show_bug.cgi?id=53854
94
95         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
96         #webkit).
97
98         * Scripts/webkitpy/common/system/executive.py:
99
100 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
101
102         Unreviewed, rolling out r77725.
103         http://trac.webkit.org/changeset/77725
104         https://bugs.webkit.org/show_bug.cgi?id=53844
105
106         It broke Qt minimal build (Requested by Ossy_ on #webkit).
107
108         * QtTestBrowser/launcherwindow.cpp:
109         (LauncherWindow::createChrome):
110         * QtTestBrowser/launcherwindow.h:
111         (WindowOptions::WindowOptions):
112         * QtTestBrowser/main.cpp:
113         (LauncherApplication::handleUserOptions):
114
115 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
116
117         Reviewed by Adam Barth.
118
119         [GTK] plugins/plugin-document-back-forward.html fails
120         https://bugs.webkit.org/show_bug.cgi?id=53833
121
122         Add the new "alert on load" functionality for the Unix version of the
123         test plugin. This functionality was originally introduced in r77706.
124
125         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
126         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
127
128 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
129
130         Reviewed by Andreas Kling.
131
132         Local Storage settings can be enable/disable from "Develop" menu
133         https://bugs.webkit.org/show_bug.cgi?id=52296
134
135         * QtTestBrowser/launcherwindow.cpp:
136         (LauncherWindow::createChrome):
137         (LauncherWindow::toggleLocalStorage):
138         (LauncherWindow::toggleOfflineStorageDatabase):
139         (LauncherWindow::toggleOfflineWebApplicationCache):
140         (LauncherWindow::setOfflineStorageDefaultQuota):
141         * QtTestBrowser/launcherwindow.h:
142         (WindowOptions::WindowOptions):
143         * QtTestBrowser/main.cpp:
144         (LauncherApplication::handleUserOptions):
145
146 2011-02-04  Tony Chang  <tony@chromium.org>
147
148         Reviewed by Eric Seidel.
149
150         get test-webkitpy running on win32 python
151         https://bugs.webkit.org/show_bug.cgi?id=53822
152
153         The test harness crashes with a WindowsError because it can't find
154         'svn' when using subprocess.Popen.  This gets us past the error
155         so we can see the failing tests on the Chromium Win Release Tests
156         bot.
157
158         * Scripts/webkitpy/common/system/executive.py:
159
160 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
161
162         Reviewed by Gustavo Noronha Silva.
163
164         [GTK] fast/events/pagehide-timeout.html fails
165         https://bugs.webkit.org/show_bug.cgi?id=53771
166
167         Add knowledge of the document browser cache model the DRT. When resetting
168         WebKit settings to consistent values between tests, default to the document
169         browser cache model.
170
171         * DumpRenderTree/gtk/DumpRenderTree.cpp:
172         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
173         cache model between tests.
174         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
175         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
176         document browser cache model.
177
178 2011-02-04  Adam Barth  <abarth@webkit.org>
179
180         Reviewed by Eric Seidel.
181
182         PluginDocuments don't create widgets for plugins on back/forward
183         https://bugs.webkit.org/show_bug.cgi?id=53474
184
185         Teach the test plugin how to call alert on load.
186
187         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
188         (NPP_New):
189
190 2011-02-04  Adam Roben  <aroben@apple.com>
191
192         Add a test case for encode/decode of FormData/FormDataElement
193
194         If the fix made in r77401 is broken, this new test will crash.
195
196         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
197
198         Reviewed by Sam Weinig.
199
200         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
201         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
202
203         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
204         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
205         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
206         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
207         form, an return the session state data.
208         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
209         and restore it into another WKPage.
210
211         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
212
213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
214         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
215         * TestWebKitAPI/win/copy-resources.cmd:
216         Added new files.
217
218 2011-02-04  Adam Roben  <aroben@apple.com>
219
220         Move code to run JavaScript tests into its own files
221
222         This will allow other tests to use this mechanism.
223
224         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
225         world
226
227         Reviewed by Sam Weinig.
228
229         * TestWebKitAPI/JavaScriptTest.cpp: Added.
230         * TestWebKitAPI/JavaScriptTest.h: Added.
231         Moved code here...
232
233         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
234
235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
236         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
237         Added the new files.
238
239 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
240
241         Reviewed by Mihai Parparita.
242
243         merge test expectations for chromium, chromium-gpu. The
244         chromium-gpu port will no longer maintain its own
245         test expectations file.
246
247         Also add in a graphics_type() call on the port object to
248         determine what graphics type to use in the test configuration,
249         and log the configuration as a config setting.
250
251         https://bugs.webkit.org/show_bug.cgi?id=53562
252
253         * Scripts/webkitpy/layout_tests/port/base.py:
254         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
255         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
256         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
257
258 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
259
260         Reviewed by Pavel Feldman.
261
262         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
263         https://bugs.webkit.org/show_bug.cgi?id=53781
264
265         * Scripts/check-inspector-strings:
266
267 2011-02-04  Adam Roben  <aroben@apple.com>
268
269         Include the crashing function in the link to a crash log on Mac
270
271         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
272         function that crashed on Mac
273
274         Reviewed by David Kilzer.
275
276         * Scripts/old-run-webkit-tests:
277         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
278         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
279         the crash log.
280
281 2011-02-04  Adam Roben  <aroben@apple.com>
282
283         Link to Mac crash logs from results.html
284
285         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
286         results.html
287
288         Reviewed by David Kilzer.
289
290         * Scripts/old-run-webkit-tests:
291         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
292         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
293
294 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
295
296         Reviewed by Dan Bernstein.
297
298         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
299         https://bugs.webkit.org/show_bug.cgi?id=52897
300         <rdar://problem/8898294>
301
302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
303         (WTR::InjectedBundlePage::InjectedBundlePage):
304         (WTR::InjectedBundlePage::willSendRequestForFrame):
305         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
306
307 2011-02-03  Ivan Krstić  <ike@apple.com>
308
309         Unreviewed.
310
311         Adding myself to committers.py.
312
313         * Scripts/webkitpy/common/config/committers.py:
314
315 2011-02-03  James Kozianski  <koz@chromium.org>
316
317         Reviewed by Dimitri Glazkov.
318
319         Add navigator.registerProtocolHandler behind a flag.
320         https://bugs.webkit.org/show_bug.cgi?id=52609
321
322         * Scripts/build-webkit:
323
324 2011-02-03  Hayato Ito  <hayato@chromium.org>
325
326         Reviewed by Eric Seidel.
327
328         [NRWT] Remove TestArgs class, which is wrongly used.
329
330         https://bugs.webkit.org/show_bug.cgi?id=53063
331
332         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
333         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
334         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
335         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
336         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
337         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
338
339 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
340
341         Reviewed by Kenneth Russell.
342
343         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
344         https://bugs.webkit.org/show_bug.cgi?id=53714
345
346         * Scripts/build-webkit: change --3d-canvas build option
347           to set ENABLE_WEBGL
348
349 2011-02-03  Hayato Ito  <hayato@chromium.org>
350
351         Reviewed by Tony Chang.
352
353         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
354         move _run_single_test() and _process_output() functions from
355         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
356
357         This is clean up and acts as a preparation for elimination of test_types/*
358         classes. These classes will move to the single_test_runner module introduced
359         in this patch.
360
361         https://bugs.webkit.org/show_bug.cgi?id=53004
362
363         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
364         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
365         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
366         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
367         * Scripts/webkitpy/layout_tests/port/base.py:
368         * Scripts/webkitpy/layout_tests/port/chromium.py:
369         * Scripts/webkitpy/layout_tests/port/dryrun.py:
370         * Scripts/webkitpy/layout_tests/port/test.py:
371         * Scripts/webkitpy/layout_tests/port/webkit.py:
372         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
373         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
374         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
375
376 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
377
378         Unreviewed, build fix.
379
380         Delete a line that was accidentally missed in r77586; without it
381         there is still a race between the two threads.
382
383         https://bugs.webkit.org/show_bug.cgi?id=51572
384
385         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
386
387 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
388
389         Reviewed by Tony Chang.
390
391         nrwt: handle "broken pipe" notifications from DRT more cleanly.
392
393         https://bugs.webkit.org/show_bug.cgi?id=52927
394
395         * Scripts/webkitpy/layout_tests/port/server_process.py:
396         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
397
398 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
399
400         Reviewed by Kenneth Russell.
401
402         Update, resubmit change to bug 51572. I think the race that was
403         fixed in r76703 caused the hang that caused us to roll this
404         patch out before, so I'd like to try again.
405
406         https://bugs.webkit.org/show_bug.cgi?id=51572
407
408         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
409         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
410
411 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
412
413         Unreviewed.
414
415         Adding myself to committers.py.
416
417         * Scripts/webkitpy/common/config/committers.py:
418
419 2011-02-03  Adam Roben  <aroben@apple.com>
420
421         Include the crashing function in the link to a crash log
422
423         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
424         function that crashed
425
426         Reviewed by David Kilzer.
427
428         * Scripts/old-run-webkit-tests:
429         (crashLocation): Added. Returns the location of the crash.
430         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
431         could be determined.
432
433 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
434
435         Unreviewed, build fix.
436
437         Actually make the changes suggested by Mihai in his review
438         of bug 53720 :(
439
440         https://bugs.webkit.org/show_bug.cgi?id=53720
441
442         * Scripts/webkitpy/layout_tests/port/test_files.py:
443         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
444
445 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
446
447         Reviewed by Mihai Parparita.
448
449         new-run-webkit-tests: Fix bug introduced in r77434 that was
450         causing us to run the canvas GPU tests on the Mac GPU port. This
451         bug revealed that we were not setting the port.name() field
452         properly in many cases, so I've cleaned up all of that code, and
453         removed a few comments about "version-specific" GPU ports that
454         don't exist and just confused things.
455
456         Testing also revealed that port.abspath_for_test() wasn't
457         normalizing paths on Windows properly, so I fixed that as well.
458
459         https://bugs.webkit.org/show_bug.cgi?id=53719
460
461         * Scripts/webkitpy/layout_tests/port/base.py:
462         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
463         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
464
465 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
466
467         Reviewed by Mihai Parparita.
468
469         new-run-webkit-tests: fix normalization of paths on windows when gathering files
470
471         r77434 introduced a bug that was causing the test expectations
472         for the GPU ports to not be treated properly. It turns out that
473         when we gathered the list of test files on Windows, we would
474         return paths of the form "c:\LayoutTests/fast/canvas", and the
475         mixture of backslashes and forward slashes was confusing things.
476
477         This patch normalizes all of the filenames returned from
478         test_files.find(), and adds better tests for this (fixing a
479         couple of other bugs found in the meantime).
480
481         https://bugs.webkit.org/show_bug.cgi?id=53720
482
483         * Scripts/webkitpy/layout_tests/port/test.py:
484         * Scripts/webkitpy/layout_tests/port/test_files.py:
485         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
486
487 2011-02-03  Adam Roben  <aroben@apple.com>
488
489         Add links to Windows crash logs in results.html
490
491         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
492         results.html
493
494         Reviewed by David Kilzer.
495
496         * Scripts/old-run-webkit-tests:
497         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
498         createDebuggerCommandFile).
499         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
500         tool has exited.
501         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
502         it into the test results directory tree. Only implemented for Cygwin currently.
503         (findNewestFileMatchingGlob): Added. Does what it says.
504         (htmlForResultsSection): Only link to files that exist.
505         (linksForErrorTest): Add a link to the crash log.
506         (deleteExpectedAndActualResults): Delete any old crash log for this test.
507         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
508         hardcoding it here.
509
510 2011-02-03  Adam Roben  <aroben@apple.com>
511
512         Tell the debugger the path to the WebKit source tree when saving a crash log
513
514         This allows the debugger to include the crashing line of code in the log.
515
516         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
517         of code
518
519         Reviewed by Sam Weinig.
520
521         * Scripts/old-run-webkit-tests:
522         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
523         file and returns the path to that file. The commands we pass came from
524         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
525         WebKit source code lives.
526         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
527         line using -c, save them to a file and specify the path to that file using -cf. This works
528         around what is presumably a bug in Windows's command line parsing, where having multiple
529         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
530         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
531         together to make them easier to modify in the future.
532
533 2011-02-02  Sam Weinig  <sam@webkit.org>
534
535         Reviewed by Anders Carlsson.
536
537         Add notification of the end of a rubber band.
538         <rdar://problem/8940648>
539
540         * MiniBrowser/mac/BrowserWindowController.m:
541         (-[BrowserWindowController awakeFromNib]):
542         * WebKitTestRunner/TestController.cpp:
543         (WTR::TestController::createOtherPage):
544         (WTR::TestController::initialize):
545         Stub out the new WKUIClient function.
546
547 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
548
549         Unreviewed.
550
551         Adding myself to committers.py.
552
553         * Scripts/webkitpy/common/config/committers.py:
554
555 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
556
557         Reviewed by Csaba Osztrogonác.
558
559         [Qt][WK2] MiniBrowser's window size should be 800x600
560         https://bugs.webkit.org/show_bug.cgi?id=53670
561
562         Make layout test failure debugging easier.
563         * MiniBrowser/qt/BrowserWindow.cpp:
564         (BrowserWindow::BrowserWindow):
565
566 2011-02-02  Andy Estes  <aestes@apple.com>
567
568         Reviewed by Mark Rowe.
569
570         'update-webkit' should handle OpenSource and Internal using different
571         VCSs.
572
573         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
574         Internal directory.
575
576 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
577
578         Reviewed by Mihai Parparita.
579
580         new-run-webkit-tests: hardcode the directories to scan for tests
581         for GPU bots instead of SKIPping them. See bug 53562 for some
582         context, but we will now hard-code the list of directories to
583         use by default instead of skipping over directories in the
584         expectations file. We do this so that we will be able to merge
585         the expectations files without getting conflicting SKIP
586         directives. Note that this change will reduce the # of tests
587         being run on the Mac GPU bots, because we're accidentally
588         including some today.
589
590         https://bugs.webkit.org/show_bug.cgi?id=53631
591
592         * Scripts/webkitpy/layout_tests/port/base.py:
593         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
594         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
595
596 2011-02-02  Sam Weinig  <sam@webkit.org>
597
598         Reviewed by Beth Dakin.
599
600         Add ChromeClient function to paint custom overhang areas.
601         https://bugs.webkit.org/show_bug.cgi?id=53639
602
603         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
604         (WTR::InjectedBundlePage::InjectedBundlePage):
605         Stub out new callback.
606
607 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
608
609         Reviewed by Tony Chang.
610
611         new-run-webkit-tests: support chromium code paths in mock_drt
612
613         https://bugs.webkit.org/show_bug.cgi?id=53471
614
615         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
616         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
617
618 2011-02-02  Adam Klein  <adamk@chromium.org>
619
620         Reviewed by Tony Chang.
621
622         Update new-run-webkit-tests --chromium to put output under Source/...
623         https://bugs.webkit.org/show_bug.cgi?id=53612
624
625         * BuildSlaveSupport/test-result-archive:
626         * Scripts/webkitpy/layout_tests/port/chromium.py:
627
628 2011-01-28  Tony Chang  <tony@chromium.org>
629
630         Reviewed by Eric Seidel.
631
632         [chromium] remove --use-test-shell from NRWT
633         https://bugs.webkit.org/show_bug.cgi?id=53346
634
635         I've already started removing some of the bindings like eventSender so
636         this already doesn't work isn't useful.  Also updated some comments to
637         refer to DRT instead of test_shell.
638
639         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
640         * Scripts/webkitpy/layout_tests/port/chromium.py:
641         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
642         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
643         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
644         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
645         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
646         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
647
648 2011-02-02  Steve Lacey  <sjl@chromium.org>
649
650         Reviewed by Eric Carlson.
651
652         Implement basic media statistics on media elements.
653         https://bugs.webkit.org/show_bug.cgi?id=53322
654
655         * Scripts/build-webkit:
656
657 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
658
659         [wx] Build fixes for wxWebKit.
660
661         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
662         (LayoutTestController::setSerializeHTTPLoads):
663         * wx/browser/wscript:
664         * wx/build/build_utils.py:
665         * wx/build/settings.py:
666
667 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
668
669         Reviewed by Mihai Parparita.
670
671         new-run-webkit-tests: stop skipping so many tests
672
673         r77163 introduced a regression where we weren't resetting test
674         expectations properly and were skipping too many tests as a
675         result. This patch fixes that and adds a test for it.
676
677         https://bugs.webkit.org/show_bug.cgi?id=53551
678
679         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
680         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
681
682 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
683
684         Reviewed by Tony Chang.
685
686         new-run-webkit-tests: add first stub of test_runner2. This
687         will add support for the 'inline', 'threads', and 'processes'
688         flags to --worker-model, but for now the implementatios just
689         fall back on the old ones.
690
691         https://bugs.webkit.org/show_bug.cgi?id=53157
692
693         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
694         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
695
696 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
697
698         Reviewed by James Robinson.
699
700         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
701         https://bugs.webkit.org/show_bug.cgi?id=53522
702
703         * Scripts/run-chromium-webkit-unit-tests:
704
705 2011-02-01  Adam Barth  <abarth@webkit.org>
706
707         Reviewed by Mihai Parparita.
708
709         Using Control-C to cancel webkit-patch or other python tools causes
710         unpleasant traceback console spew
711         https://bugs.webkit.org/show_bug.cgi?id=53462
712
713         Catch the exception and don't print the stack trace.
714
715         * Scripts/webkit-patch:
716
717 2011-02-01  Scott Cameron  <sccameron@rim.com>
718
719         Reviewed by Daniel Bates.
720
721         Use Windows format for MinGW HTTPD path.
722         https://bugs.webkit.org/show_bug.cgi?id=53503
723
724         * Scripts/webkitperl/httpd.pm:
725           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
726             so that we don't have to escape the space characters in the path. Also,
727             changed path to Windows-style path and removed FIXME comment.
728
729 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
730
731         Reviewed by Andreas Kling.
732
733         [Qt][WK2] Add a way to use shared process model in MiniBrowser
734         https://bugs.webkit.org/show_bug.cgi?id=53090
735
736         * MiniBrowser/qt/BrowserView.cpp:
737         (BrowserView::BrowserView): Removed the m_context member.
738         From now the context is guaranteed to be non-null and we
739         don't need to store that in the object.
740         * MiniBrowser/qt/BrowserView.h:
741         * MiniBrowser/qt/BrowserWindow.cpp:
742         Added static bool to determine that new windows need to be
743         created with their own context or not. Use the same context
744         and web process by default to be inilne with the other ports.
745         (BrowserWindow::BrowserWindow):
746         (BrowserWindow::newWindow):
747         * MiniBrowser/qt/BrowserWindow.h:
748         * MiniBrowser/qt/main.cpp:
749         (main): Added command line switch to be able to use the
750         non-shared process model. Simplify the handling of the command line
751         switches a little bit.
752
753 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
754
755         Reviewed by Andreas Kling.
756
757         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
758         https://bugs.webkit.org/show_bug.cgi?id=53491
759
760         * MiniBrowser/qt/BrowserWindow.cpp:
761         (BrowserWindow::BrowserWindow):
762         (BrowserWindow::toggleFullScreenMode):
763         * MiniBrowser/qt/BrowserWindow.h:
764
765 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
766
767         Reviewed by Andreas Kling.
768
769         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
770         https://bugs.webkit.org/show_bug.cgi?id=53489
771
772         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
773         to Settings menu.
774
775         * MiniBrowser/qt/BrowserWindow.cpp:
776         (BrowserWindow::BrowserWindow):
777         (BrowserWindow::toggleFrameFlattening):
778         (BrowserWindow::toggleDisableJavaScript):
779         (BrowserWindow::toggleAutoLoadImages):
780         * MiniBrowser/qt/BrowserWindow.h:
781
782 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
783
784         Reviewed by Tony Chang.
785
786         [Chromium] Switch chromium-mac to use ChromiumDriver
787         https://bugs.webkit.org/show_bug.cgi?id=53461
788         
789         For the sake of consistency with the other Chromium platforms (and so
790         that chromium-mac picks up special flags like --enable-hardware-gpu),
791         switch chromium-mac from the WebKitDriver to ChromiumDriver.
792
793         * Scripts/webkitpy/layout_tests/port/chromium.py:
794
795 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
796
797         Reviewed by Mihai Parparita.
798
799         The current modifier parsing code in test_expectations is
800         fragile and hard-coded, so it's not easy to understand the logic
801         or easily add new types of modifiers (like GPU vs. CPU testing
802         for graphics tests, or 32-bit vs. 64-bit differences).
803
804         This is the first of two patches that will add in more generic
805         support and then eliminate the GPU-specific test expectations
806         files for Chromium.
807
808         This patch adds two standalone objects for handling modifiers. The
809         rules for interpreting modifiers, precedence, and conflicts are
810         given in the docstring to the ModifierMatcher class, which
811         returns ModifierMatchResult objects.
812         
813         This patch also adds routines to the Port interface and a
814         default set of values in the base object, in order to obtain the
815         values needed on a given test run. These values are then passed
816         to the expectation parser. This also allows us to clean up the
817         logic used to lint all of the different configurations in a
818         single test_expectations.txt file.
819
820         The next patch will merge in the separate GPU expectations file.
821
822         https://bugs.webkit.org/show_bug.cgi?id=51222
823
824         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
825         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
826         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
827         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
828         * Scripts/webkitpy/layout_tests/port/base.py:
829         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
830         * Scripts/webkitpy/layout_tests/port/chromium.py:
831         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
832         * Scripts/webkitpy/layout_tests/port/test.py:
833         * Scripts/webkitpy/layout_tests/port/webkit.py:
834         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
835         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
836         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
837         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
838         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
839
840 2011-01-31  Scott Cameron  <sccameron@rim.com>
841
842         Reviewed by Daniel Bates.
843
844         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
845         https://bugs.webkit.org/show_bug.cgi?id=50036
846
847         This will add an Apache2.2 configuration file and modifies scripts to allow
848         running an httpd server in an MSYS environment.
849
850         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
851         in order to allow for simple installation/execution.  Simply install the latest
852         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
853         be able to execute run-webkit-httpd.
854         
855
856         * Scripts/run-webkit-httpd:
857         * Scripts/webkitperl/httpd.pm:
858
859 2011-01-31  Tony Chang  <tony@chromium.org>
860
861         Reviewed by Eric Seidel.
862
863         mac DRT should report RTL scroll offset relative to top right corner
864         https://bugs.webkit.org/show_bug.cgi?id=53324
865
866         * DumpRenderTree/mac/DumpRenderTree.mm:
867         (dumpFrameScrollPosition):
868
869 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
870
871         Reviewed by Andreas Kling.
872
873         [Qt] Add Take Screen Shot action to MiniBrowser
874         https://bugs.webkit.org/show_bug.cgi?id=53422
875
876         Add Take Screen Shot action to MiniBrowser's view menu.
877
878         * MiniBrowser/qt/BrowserWindow.cpp:
879         (BrowserWindow::BrowserWindow):
880         (BrowserWindow::screenshot):
881         * MiniBrowser/qt/BrowserWindow.h:
882
883 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
884
885         Reviewed by Xan Lopez.
886
887         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
888         https://bugs.webkit.org/show_bug.cgi?id=53379
889
890         Remove left over #ifdef's. I thought all of the conditional code
891         had been freed from the condition, but I forgot to check DRT.
892
893         * DumpRenderTree/gtk/DumpRenderTree.cpp:
894         (resetDefaultsToConsistentValues):
895         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
896         (LayoutTestController::setAlwaysAcceptCookies):
897
898 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
899
900         Unreviewed, build fix.
901
902         Fix regression introduced in r77093 - path.rsplit() doesn't
903         take keyword arguments.
904
905         https://bugs.webkit.org/show_bug.cgi?id=53326
906
907         * Scripts/webkitpy/common/system/filesystem_mock.py:
908
909 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
910
911         Reviewed by Mihai Parparita.
912
913         Add more unit tests for rebaseline-chromium-webkit-tests. This
914         change involves restructuring a bunch of r-c-w-t code to make it
915         more testable as well. We also add wrapper classes for handling
916         testing zip files and fetching URLs.
917
918         https://bugs.webkit.org/show_bug.cgi?id=53040
919
920         * Scripts/webkitpy/common/system/urlfetcher.py:
921         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
922         * Scripts/webkitpy/common/system/zipfileset_mock.py:
923         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
924         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
925         * Scripts/webkitpy/tool/mocktool.py:
926
927 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
928
929         Reviewed by Eric Seidel.
930
931         Clean up of the filesystem-related modules used in webkitpy.
932         I've added relpath() to the filesystem interface, modified
933         ospath.relpath() so that it could work with the filesystem
934         interface, and modified the fileset* routines to use the
935         filesystem interface consistently.
936
937         This patch also adds a close() routine to the fileset routines
938         to indicate that the caller is done with the fileset. This
939         allows zipfileset to clean up after itself when it creates
940         tempfiles to store downloads.
941
942         https://bugs.webkit.org/show_bug.cgi?id=53326
943
944         * Scripts/webkitpy/common/system/directoryfileset.py:
945         * Scripts/webkitpy/common/system/fileset.py:
946         * Scripts/webkitpy/common/system/filesystem.py:
947         * Scripts/webkitpy/common/system/filesystem_mock.py:
948         * Scripts/webkitpy/common/system/filesystem_unittest.py:
949         * Scripts/webkitpy/common/system/ospath.py:
950         * Scripts/webkitpy/common/system/zipfileset.py:
951         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
952
953 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
954
955         Reviewed by Csaba Osztrogonác.
956
957         [Qt][WK2]REGRESSION (r76991): Fix build errors
958         https://bugs.webkit.org/show_bug.cgi?id=53400
959
960         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
961         and remove WebKit2Prefix.h from the build.
962         * MiniBrowser/qt/MiniBrowser.pro:
963
964 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
965
966         Unreviewed.
967
968         [Qt][WK2] Buildfix.
969
970         * MiniBrowser/qt/MiniBrowser.pro:
971
972 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
973
974         Reviewed by Adam Roben.
975         
976         define NOMINMAX when building ImageDiff, as we do elsewhere.
977
978         Add various clampToInt() methods to MathExtras.h
979         https://bugs.webkit.org/show_bug.cgi?id=52910
980
981         * DumpRenderTree/win/ImageDiffCommon.vsprops:
982
983 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
984
985         Reviewed by Darin Adler.
986
987         WebKitTestRunner needs layoutTestController.setPOSIXLocale
988         https://bugs.webkit.org/show_bug.cgi?id=42682
989
990         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
991         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
992         (WTR::InjectedBundle::resetLocalSettings):
993         (WTR::InjectedBundle::didReceiveMessage):
994         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
995         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
996         (WTR::LayoutTestController::setPOSIXLocale):
997         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
998
999 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1000  
1001          Reviewed by Mihai Parparita.
1002  
1003          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1004  
1005          This patch re-enables this test and changes it to
1006          handle all of the mac platform versions, not just the one
1007          it is running on.
1008  
1009          https://bugs.webkit.org/show_bug.cgi?id=53356
1010  
1011          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1012  
1013 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1014
1015         Unreviewed, build fix.
1016
1017         Take two. The fix in 77023 didn't work, because we were
1018         still calling path.abspath_to_uri, which calls _cygpath under
1019         the covers, and it appears the cygpath on the bots does
1020         something different than it does on my machine. This patch
1021         removes the calls to path.abspath_to_uri, so it should be safe.
1022         If it doesn't work, I'll roll it out along with r76982 and 77023.
1023
1024         https://bugs.webkit.org/show_bug.cgi?id=53126
1025
1026         * Scripts/webkitpy/layout_tests/port/test.py:
1027
1028 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1029
1030         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1031         <http://webkit.org/b/53353>
1032
1033         Reviewed by Mark Rowe.
1034
1035         * Scripts/webkitdirs.pm:
1036         (checkRequiredSystemConfig): Check the Xcode marketing version
1037         in addition to the DevCoreTools build version before complaining
1038         about an old version of Xcode.  Also make the Mac OS X version
1039         check use Perl's built-in version string comparitor.
1040
1041 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1042
1043         Unreviewed, build fix.
1044
1045         Work around breakage on Win 7 Release bot caused by r76982
1046         and the fact that windows ports use "file:////" instead of
1047         "file:///". Ideally the test code should be isolated from
1048         this, but it isn't yet. Will fix properly in a bit.
1049
1050         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1051
1052 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1053
1054         Reviewed by Tony Chang.
1055
1056         new-run-webkit-tests: change worker model values to
1057         "old-inline", "old-threads" in preparation for test_runner2 /
1058         multiprocessing changes.
1059
1060         https://bugs.webkit.org/show_bug.cgi?id=53156
1061
1062         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1063         * Scripts/webkitpy/layout_tests/port/base.py:
1064         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1065         * Scripts/webkitpy/layout_tests/port/mac.py:
1066         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1067
1068 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1069
1070         Reviewed by Tony Chang.
1071
1072         committers.py - add an IRC nickname for dpranke
1073         https://bugs.webkit.org/show_bug.cgi?id=53335
1074
1075         * Scripts/webkitpy/common/config/committers.py:
1076
1077 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1078
1079         Reviewed by Tony Chang.
1080
1081         new-run-webkit-tests: add a "mock DRT" port implementation
1082         and a separate class that emulates what we expect the
1083         DumpRenderTree behavior to be.
1084
1085         This will eventually replace port/dryrun.py and allow us to get
1086         better test coverage of the new-run-webkit-tests code as well as
1087         a reference for what new-run-webkit-tests expects from DRT.
1088
1089         This is the first attempt at this, and it is pretty bare-boned. It
1090         really only has been tested on the 'mac' port (and a little on
1091         the 'chromium-mac' port.
1092
1093         https://bugs.webkit.org/show_bug.cgi?id=53126
1094
1095         * Scripts/webkitpy/common/system/filesystem_mock.py:
1096         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1097         * Scripts/webkitpy/layout_tests/port/factory.py:
1098         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1099         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1100         * Scripts/webkitpy/layout_tests/port/test.py:
1101
1102 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1103
1104         Unreviewed. Removing .swp file checked in by mistake.
1105
1106         * Scripts/.webkitdirs.pm.swp: Removed.
1107
1108 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1109
1110         Reviewed by David Kilzer.
1111
1112         Space not necessary for undefined feature
1113         https://bugs.webkit.org/show_bug.cgi?id=53317
1114
1115         * Scripts/build-webkit:
1116
1117 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1118
1119         Reviewed by Andreas Kling.
1120
1121         Reset NetworkAccessManager to clean up credentials from previous tests.
1122         This change causes no performance overhead either.
1123         https://bugs.webkit.org/show_bug.cgi?id=36688
1124
1125         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1126         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1127         (WebCore::DumpRenderTree::open):
1128         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1129
1130 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1131
1132         Reviewed by Andreas Kling.
1133
1134         [Qt] Add Zoom Text Only action to MiniBrowser
1135         https://bugs.webkit.org/show_bug.cgi?id=53297
1136
1137         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1138
1139         * MiniBrowser/qt/BrowserWindow.cpp:
1140         (BrowserWindow::BrowserWindow):
1141         (BrowserWindow::zoomIn):
1142         (BrowserWindow::zoomOut):
1143         (BrowserWindow::resetZoom):
1144         (BrowserWindow::toggleZoomTextOnly):
1145         (BrowserWindow::applyZoom):
1146         * MiniBrowser/qt/BrowserWindow.h:
1147
1148 2011-01-28  Adam Barth  <abarth@webkit.org>
1149
1150         Reviewed by Eric Seidel.
1151
1152         Add webkit-patch roll-chromium-deps
1153         https://bugs.webkit.org/show_bug.cgi?id=53288
1154
1155         This command updates the Source/WebKit/chromium/DEPS file with the
1156         last-known good revision of Chromium (or a revision specified on the
1157         command line).  I'd eventually like to turn this into a SheriffBot
1158         command, but this is the first step.
1159
1160         This patch somewhat sprawled because I needed to move a bunch of code
1161         out of ChangeLog that should never have been there in the first place.
1162         Also, I had to fix a bug in MockUser in order to test the new command.
1163
1164         * Scripts/webkitpy/common/checkout/api.py:
1165         * Scripts/webkitpy/common/checkout/changelog.py:
1166         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1167         * Scripts/webkitpy/common/checkout/deps.py: Added.
1168         * Scripts/webkitpy/common/config/urls.py:
1169         * Scripts/webkitpy/tool/commands/__init__.py:
1170         * Scripts/webkitpy/tool/commands/download_unittest.py:
1171         * Scripts/webkitpy/tool/commands/roll.py: Added.
1172         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1173         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1174         * Scripts/webkitpy/tool/mocktool.py:
1175         * Scripts/webkitpy/tool/steps/__init__.py:
1176         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1177         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1178         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1179         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1180         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1181         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1182
1183 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1184
1185         Reviewed by Laszlo Gombos.
1186
1187         Get rid of prefix header dependency for WebKit2 build system
1188         https://bugs.webkit.org/show_bug.cgi?id=50174
1189
1190         Change the style checker so that it enforces config.h include for
1191         WebKit2.
1192
1193         * Scripts/webkitpy/style/checker.py:
1194
1195 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1196
1197         Reviewed by Darin Adler.
1198
1199         execCommand("Paste") doesn't work in WebKitTestRunner
1200         https://bugs.webkit.org/show_bug.cgi?id=52785
1201
1202         Enable both of the settings needed to allow paste.
1203         
1204         * WebKitTestRunner/TestController.cpp:
1205         (WTR::TestController::resetStateToConsistentValues):
1206
1207 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1208
1209         Reviewed by Andreas Kling.
1210
1211         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1212         https://bugs.webkit.org/show_bug.cgi?id=48440
1213
1214         Preserve user input when toggling use of QGraphicsView
1215
1216         * QtTestBrowser/launcherwindow.cpp:
1217         (LauncherWindow::initializeView):
1218         (LauncherWindow::loadFinished):
1219         * QtTestBrowser/launcherwindow.h:
1220         * QtTestBrowser/mainwindow.cpp:
1221         (MainWindow::addressUrl):
1222         * QtTestBrowser/mainwindow.h:
1223
1224 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1225
1226         Reviewed by Mihai Parparita.
1227
1228         new-run-webkit-tests: turn off pixel tests correctly by default
1229         for webkit-based ports. r70013 (bug 47510) used
1230         port.set_option_default() to attempt to set default values, but
1231         that didn't work correctly. I have removed set_option_default
1232         for now since it was only being used in two places and in three
1233         useless unit tests. There is a separate bug open to fix the
1234         option parsing (48095), so this workaround is fine for now.
1235
1236         https://bugs.webkit.org/show_bug.cgi?id=53217
1237
1238         * Scripts/webkitpy/layout_tests/port/webkit.py:
1239         * Scripts/webkitpy/layout_tests/port/base.py:
1240         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1241
1242 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1243
1244         Rubber-stamped by Ariya Hidayat.
1245
1246         Trivial crash fix in WTR.
1247
1248         * WebKitTestRunner/TestController.cpp:
1249         (WTR::TestController::initialize): Increase the size
1250         of the vector by one to be able to store the null character.
1251
1252 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1253
1254         Reviewed by Csaba Osztrogonác.
1255
1256         [Qt][WK2] WTR should be initialized in the same way as DRT
1257         https://bugs.webkit.org/show_bug.cgi?id=53240
1258
1259         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1260         (WTR::activateFonts): Added missing initialization steps.
1261
1262 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1263
1264         Unreviewed. 
1265
1266         Adding myself to committers.py.
1267
1268         * Scripts/webkitpy/common/config/committers.py:
1269
1270 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1271
1272         Reviewed by Csaba Osztrogonác.
1273
1274         [Qt] [Symbian] Move project files into Source
1275         https://bugs.webkit.org/show_bug.cgi?id=52891
1276
1277         Fix the Symbian build after the project files
1278         are moved to Source directory. On Symbian qmake
1279         needs to run in the same directory where the main
1280         pro files (WebKit.pro, Tools.pro) are located.
1281
1282         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1283         is located before running qmake for Symbian. Qmake on Symbian
1284         does not properly honor the "-o" option, work it around by setting
1285         the name of the Makefile to bld.inf.
1286
1287 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1288
1289         Reviewed by Andreas Kling.
1290
1291         [Qt] Add simple zooming features to MiniBrowser
1292         https://bugs.webkit.org/show_bug.cgi?id=53231
1293
1294         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1295
1296         * MiniBrowser/qt/BrowserWindow.cpp:
1297         (BrowserWindow::BrowserWindow):
1298         (BrowserWindow::zoomIn):
1299         (BrowserWindow::zoomOut):
1300         (BrowserWindow::resetZoom):
1301         (BrowserWindow::updateUserAgentList):
1302         (BrowserWindow::applyZoom):
1303         * MiniBrowser/qt/BrowserWindow.h:
1304
1305 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1306
1307         Reviewed by Dan Bernstein.
1308
1309         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1310         https://bugs.webkit.org/show_bug.cgi?id=42319
1311         
1312         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1313
1314         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1315         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1316         (WTR::LayoutTestController::showWebInspector):
1317         (WTR::LayoutTestController::closeWebInspector):
1318         (WTR::LayoutTestController::evaluateInWebInspector):
1319         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1320         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1321         * WebKitTestRunner/TestInvocation.cpp:
1322         (WTR::shouldOpenWebInspector):
1323         (WTR::TestInvocation::invoke):
1324         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1325
1326 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1327
1328         Reviewed by Xan Lopez.
1329
1330         [GTK] Pixel dumps do not include scrollbars in output images
1331         https://bugs.webkit.org/show_bug.cgi?id=53216
1332
1333         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1334         that have scrollbars.
1335
1336         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1337         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1338         instead of the web view itself.
1339
1340 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1341
1342         Reviewed by Mihai Parparita.
1343
1344         Fix regression introduced in r76322 ... new-run-webkit-tests
1345         was attempting to save the image diff output as a UTF-8-encoded
1346         file.
1347
1348         https://bugs.webkit.org/show_bug.cgi?id=53210
1349
1350         * Scripts/webkitpy/layout_tests/port/webkit.py:
1351
1352 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1353
1354         Unreviewed, rolling out r76709.
1355         http://trac.webkit.org/changeset/76709
1356         https://bugs.webkit.org/show_bug.cgi?id=53194
1357
1358         "broke python tests on non-snowleopard platforms" (Requested
1359         by dpranke on #webkit).
1360
1361         * Scripts/webkitpy/layout_tests/port/factory.py:
1362         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1363         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1364
1365 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1366
1367         Reviewed by Tony Chang.
1368
1369         new-run-webkit-tests: add a "mock DRT" port implementation
1370         and a separate class that emulates what we expect the
1371         DumpRenderTree behavior to be.
1372
1373         This will eventually replace port/dryrun.py and allow us to get
1374         better test coverage of the new-run-webkit-tests code as well as
1375         a reference for what new-run-webkit-tests expects from DRT.
1376
1377         This is the first attempt at this, and it is pretty bare-boned. It
1378         really only has been tested on the 'mac' port (and a little on
1379         the 'chromium-mac' port.
1380
1381         https://bugs.webkit.org/show_bug.cgi?id=53126
1382
1383         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1384         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1385         * Scripts/webkitpy/layout_tests/port/factory.py:
1386
1387 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1388
1389         Reviewed by Tony Chang.
1390
1391         Add '--no-timeout' option to Chromium DRT to ease debugging.
1392         https://bugs.webkit.org/show_bug.cgi?id=52873
1393
1394         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1395         (main):
1396
1397 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1398
1399         Reviewed by Andreas Kling.
1400
1401         [Qt] Fix qt_minimal build
1402         https://bugs.webkit.org/show_bug.cgi?id=53172
1403
1404         * QtTestBrowser/locationedit.h:
1405
1406 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1407
1408         Reviewed by Antonio Gomes.
1409
1410         QtTestBrowser should have a UI Setting to disable plugins
1411         https://bugs.webkit.org/show_bug.cgi?id=52408
1412         
1413         Added a new action item named "Disable Plugins"
1414         under the "Settings" menu. 
1415
1416         * QtTestBrowser/launcherwindow.cpp:
1417         (LauncherWindow::createChrome):
1418         (LauncherWindow::togglePlugins):
1419         * QtTestBrowser/launcherwindow.h:
1420
1421 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1422
1423         Reviewed by Adam Barth.
1424
1425         Move main CMakeLists.txt into Source directory
1426         https://bugs.webkit.org/show_bug.cgi?id=52888
1427
1428         * Scripts/webkitdirs.pm:
1429
1430 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1431
1432         Reviewed by Eric Seidel.
1433
1434         Improve label text in submit-to-ews
1435         https://bugs.webkit.org/show_bug.cgi?id=53130
1436
1437         * QueueStatusServer/templates/submittoews.html:
1438
1439 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1440
1441         Reviewed by Antonio Gomes.
1442
1443         QtTestBrowser should have a UI Settings to prevent loading images
1444         https://bugs.webkit.org/show_bug.cgi?id=52409
1445         
1446         Added a new action item named "DisableAutoLoadImages"
1447         under the "Settings" menu 
1448
1449         * QtTestBrowser/launcherwindow.cpp:
1450         (LauncherWindow::createChrome):
1451         (LauncherWindow::toggleAutoLoadImages):
1452         * QtTestBrowser/launcherwindow.h:
1453
1454 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1455
1456         Reviewed by Tony Chang.
1457
1458         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1459         classes, test_expectations.py. This change adds "test-win" and
1460         "test-mac" variants to the test port so that we can better test
1461         rebaselining, and adds a MockUser() object for reuse in testing.
1462
1463         https://bugs.webkit.org/show_bug.cgi?id=53036
1464
1465         * Scripts/webkitpy/common/system/filesystem.py:
1466         * Scripts/webkitpy/common/system/filesystem_mock.py:
1467         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1468         * Scripts/webkitpy/layout_tests/port/factory.py:
1469         * Scripts/webkitpy/layout_tests/port/base.py:
1470         * Scripts/webkitpy/layout_tests/port/test.py:
1471         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1472         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1473         * Scripts/webkitpy/tool/mocktool.py:
1474
1475 2011-01-25  Tony Chang  <tony@chromium.org>
1476
1477         Reviewed by Dimitri Glazkov.
1478
1479         [chromium] remove unused layoutTestController callback
1480         https://bugs.webkit.org/show_bug.cgi?id=53103
1481
1482         This method is used by a test_shell_test, but not needed by DRT.
1483
1484         * DumpRenderTree/chromium/LayoutTestController.cpp:
1485         (LayoutTestController::LayoutTestController):
1486         * DumpRenderTree/chromium/LayoutTestController.h:
1487
1488 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1489
1490         Reviewed by Andreas Kling.
1491
1492         [GTK] Remove 64 bits release bot from the buildbot master
1493         https://bugs.webkit.org/show_bug.cgi?id=52899
1494
1495         Removes the 64 bits release slave from the buildbot configuration,
1496         so that we can use it as an EWS.
1497
1498         * BuildSlaveSupport/build.webkit.org-config/config.json:
1499
1500 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1501
1502         Reviewed by Dan Bernstein.
1503
1504         Implement database quota callback to fix storage tests on WebKit2 bot
1505         https://bugs.webkit.org/show_bug.cgi?id=53064
1506
1507         * WebKitTestRunner/TestController.cpp:
1508         (WTR::exceededDatabaseQuota):
1509         (WTR::TestController::createOtherPage):
1510         (WTR::TestController::initialize):
1511
1512 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1513
1514         Reviewed by Anders Carlsson.
1515
1516         Use designated temp directory for the database for WebKit2
1517         https://bugs.webkit.org/show_bug.cgi?id=53052
1518         
1519         Adopt the new WK2 API for this.
1520
1521         * WebKitTestRunner/TestController.cpp:
1522         (WTR::TestController::libraryPathForTesting):
1523         (WTR::TestController::initialize):
1524         * WebKitTestRunner/TestController.h:
1525         * WebKitTestRunner/mac/TestControllerMac.mm:
1526         (WTR::TestController::platformLibraryPathForTesting):
1527         * WebKitTestRunner/qt/TestControllerQt.cpp:
1528         (WTR::TestController::platformLibraryPathForTesting):
1529         * WebKitTestRunner/win/TestControllerWin.cpp:
1530         (WTR::TestController::platformLibraryPathForTesting):
1531
1532 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1533
1534         Reviewed by Stephanie Lewis.
1535
1536         Add a new Leopard test bot.
1537
1538         * BuildSlaveSupport/build.webkit.org-config/config.json:
1539
1540 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1541
1542         Reviewed by Adam Barth.
1543
1544         Add EFL Builder to core waterfall
1545         https://bugs.webkit.org/show_bug.cgi?id=52704
1546
1547         Add EFL Builder to the core waterfall again.
1548
1549         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1550         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1551
1552 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1553
1554         Reviewed by Tony Chang.
1555
1556         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1557         https://bugs.webkit.org/show_bug.cgi?id=52872
1558
1559         Force disabling proxy to resolve the problem.
1560
1561         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1562         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1563
1564 2011-01-24  Andreas Kling  <kling@webkit.org>
1565
1566         Reviewed by Darin Adler.
1567
1568         check-webkit-style: Update exemptions following Source/ move.
1569         https://bugs.webkit.org/show_bug.cgi?id=53017
1570
1571         * Scripts/webkitpy/style/checker.py:
1572         * Scripts/webkitpy/style/checker_unittest.py:
1573
1574 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1575
1576         Rubber-stamped by Csaba Osztrogonác.
1577
1578         [Qt] Move project files into Source
1579         https://bugs.webkit.org/show_bug.cgi?id=52891
1580
1581         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1582
1583 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1584
1585         Reviewed by Yury Semikhatsky.
1586
1587         Web Inspector: Find duplicate strings in localizedStrings.js
1588
1589         https://bugs.webkit.org/show_bug.cgi?id=53005
1590
1591         * Scripts/check-inspector-strings:
1592
1593 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1594
1595         Reviewed by Andreas Kling.
1596
1597         [Qt] Regroup MiniBrowser's menubar and add open file action
1598         https://bugs.webkit.org/show_bug.cgi?id=53000
1599
1600         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1601
1602         * MiniBrowser/qt/BrowserWindow.cpp:
1603         (BrowserWindow::BrowserWindow):
1604         (BrowserWindow::openFile):
1605         (BrowserWindow::~BrowserWindow):
1606         * MiniBrowser/qt/BrowserWindow.h:
1607
1608 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1609
1610         Unreviewed fix after r76496
1611
1612         [Qt] Move project files into Source
1613         https://bugs.webkit.org/show_bug.cgi?id=52891
1614
1615         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1616         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1617         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1618
1619 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1620
1621         Reviewed by Csaba Osztrogonác.
1622
1623         [Qt] Move project files into Source
1624         https://bugs.webkit.org/show_bug.cgi?id=52891
1625
1626         * DerivedSources.pro: Renamed from DerivedSources.pro.
1627         * DumpRenderTree/qt/DumpRenderTree.pro:
1628         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1629         * MiniBrowser/DerivedSources.pro:
1630         * MiniBrowser/qt/MiniBrowser.pro:
1631         * QtTestBrowser/QtTestBrowser.pro:
1632         * Scripts/webkitdirs.pm:
1633         * Tools.pro: Added.
1634         * WebKitTestRunner/DerivedSources.pro:
1635         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1636         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1637
1638 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1639
1640         Reviewed by Dan Bernstein.
1641
1642         Beefed up --threaded mode to catch even more kinds of errors.
1643         https://bugs.webkit.org/show_bug.cgi?id=52971
1644
1645         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1646         context group to force JSC to mark multiple threads. (This used to be
1647         the default, but it changed in SnowLeopard.)
1648         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1649         to give threading mistakes more chances to show themselves.
1650         (startJavaScriptThreads):
1651         (stopJavaScriptThreads):
1652
1653 2011-01-22  Robert Hogan  <robert@webkit.org>
1654
1655         Reviewed by Andreas Kling.
1656
1657         [Qt] Support layoutTestController.addURLToRedirect()
1658         https://bugs.webkit.org/show_bug.cgi?id=52956
1659
1660         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1661         (LayoutTestController::addURLToRedirect):
1662         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1663
1664 2011-01-22  Robert Hogan  <robert@webkit.org>
1665
1666         Reviewed by Kenneth Rohde Christiansen.
1667
1668         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1669         https://bugs.webkit.org/show_bug.cgi?id=49802
1670
1671         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1672         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1673         (WebCore::DumpRenderTree::open):
1674
1675 2011-01-21  Adam Barth  <abarth@webkit.org>
1676
1677         Reviewed by Maciej Stachowiak.
1678
1679         Disable mac_unittest.py that fails on some of the Mac bots
1680         https://bugs.webkit.org/show_bug.cgi?id=52947
1681
1682         As noted in the comment, this test does not appear to be correct
1683         because the function this test is testing returns different results
1684         depending on which flavor of Mac the test is run on.  This patch
1685         disable the test.  Hopefully we can re-enable the test once we've
1686         probably insulated the test from its environment.
1687
1688         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1689
1690 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1691
1692         Reviewed by Mihai Parparita.
1693
1694         Fix bug introduced in r76322 that caused NRWT to not actually
1695         read the Skipped files properly.
1696
1697         https://bugs.webkit.org/show_bug.cgi?id=52771
1698
1699         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1700         * Scripts/webkitpy/layout_tests/port/webkit.py:
1701         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1702
1703 2011-01-21  Sam Weinig  <sam@webkit.org>
1704
1705         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1706
1707         WebKitTestRunner needs the HOME environment variable to be set.
1708         <rdar://problem/8896573>
1709
1710         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1711         it exists.
1712
1713 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1714
1715         Reviewed by Eric Seidel.
1716
1717         Suppress a few remaining integration tests so that none of the
1718         layout_test unit tests ever read from the filesystem or launch
1719         subprocesses that aren't part of the unit tests.
1720
1721         Also fix a minor bug in the printing unit tests that was
1722         incorrectly relying on sys.argv.
1723
1724         https://bugs.webkit.org/show_bug.cgi?id=52863
1725
1726         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1727         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1728         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1729
1730 2011-01-21  Darin Adler  <darin@apple.com>
1731
1732        Fix Mac build.
1733
1734         * MiniBrowser/mac/BrowserWindowController.m:
1735         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1736
1737 2011-01-20  Darin Adler  <darin@apple.com>
1738
1739         Reviewed by Dan Bernstein.
1740
1741         WebKit2: Implement showModalDialog
1742         https://bugs.webkit.org/show_bug.cgi?id=52855
1743
1744         This fixes WebKitTestRunner to compile, but more work is probably
1745         needed to get it to pass the tests.
1746
1747         * WebKitTestRunner/TestController.cpp:
1748         (WTR::TestController::runModal): Added. Calls through to the
1749         platform-specific version of runModal.
1750         (WTR::TestController::createOtherPage): Changed to be a private
1751         static member function so it can refer to runModal, which is
1752         a private static member function.
1753         (WTR::TestController::initialize): Pass 0 for the runModal
1754         function since we don't need to run the main window modal.
1755         I suspect this is wrong and will need to change.
1756         * WebKitTestRunner/TestController.h: Added declarations for
1757         the functions added above.
1758         * WebKitTestRunner/mac/TestControllerMac.mm:
1759         (WTR::TestController::runModal): Added. Untested implementation.
1760         * WebKitTestRunner/qt/TestControllerQt.cpp:
1761         (WTR::TestController::runModal): Added.
1762         * WebKitTestRunner/win/TestControllerWin.cpp:
1763         (WTR::TestController::runModal): Added.
1764
1765 2011-01-21  Eric Seidel  <eric@webkit.org>
1766
1767         Reviewed by Adam Barth.
1768
1769         Split Host object off from WebKitPatch for easier re-use
1770         https://bugs.webkit.org/show_bug.cgi?id=52284
1771
1772         new-run-webkit-tests and other tools are eventually going to want one of these.
1773         Basically you need to inherit from this class if you want to pretend to be a
1774         self.tool object for Steps/Commands.
1775
1776         * Scripts/webkitpy/common/host.py: Added.
1777         * Scripts/webkitpy/tool/main.py:
1778
1779 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1780
1781         Reviewed by Adam Barth.
1782
1783         Disable the tests that start and stop the http server and web
1784         server, so that we don't have to worry about port collisions on
1785         the bots.
1786
1787         https://bugs.webkit.org/show_bug.cgi?id=52861
1788
1789         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1790
1791 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1792
1793         Reviewed by Eric Seidel.
1794
1795         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1796         
1797         https://bugs.webkit.org/show_bug.cgi?id=52772
1798         
1799         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1800
1801 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1802
1803         Reviewed by Eric Siedel.
1804
1805         nrwt: clean up almost all remaining port references, remove
1806         unnecessary import clauses. The only remaining references are
1807         in places where a mock filesystem makes no sense or can't be
1808         used, and in one routine in port/google_chrome_unittest that
1809         I'll rewrite in a separate patch.
1810
1811         https://bugs.webkit.org/show_bug.cgi?id=52771
1812
1813         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1814         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1815         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1816         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1817         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1818         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1819         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1820         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1821         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1822         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1823         * Scripts/webkitpy/layout_tests/port/gtk.py:
1824         * Scripts/webkitpy/layout_tests/port/mac.py:
1825         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1826         * Scripts/webkitpy/layout_tests/port/qt.py:
1827         * Scripts/webkitpy/layout_tests/port/webkit.py:
1828         * Scripts/webkitpy/layout_tests/port/win.py:
1829         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1830
1831 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1832
1833         Reviewed by Mihai Parparita.
1834
1835         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1836
1837         https://bugs.webkit.org/show_bug.cgi?id=52762
1838
1839         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1840         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1841
1842 2011-01-20  Tony Chang  <tony@chromium.org>
1843
1844         Reviewed by Ojan Vafai.
1845
1846         [chromium] fix the paths used for the rebaseline tool
1847         https://bugs.webkit.org/show_bug.cgi?id=52857
1848
1849         Some of the bots were renamed so the path to grab the results zip
1850         file has changed.
1851
1852         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1853
1854 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1855
1856         Reviewed by Tony Chang.
1857
1858         Fix bug introduced in r72688 / bug 52768 that broke the
1859         generation of the output filename links in the results.html
1860         output. Apparently none of the unit tests actually checked to
1861         make sure the generated links were correct :(
1862
1863         https://bugs.webkit.org/show_bug.cgi?id=52854
1864
1865         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1866         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1867
1868 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1869
1870         Reviewed by Darin Adler.
1871
1872         https://bugs.webkit.org/show_bug.cgi?id=52849
1873         Make window.print work with WebKit2
1874
1875         * MiniBrowser/mac/BrowserWindowController.m:
1876         (-[BrowserWindowController awakeFromNib]):
1877         * WebKitTestRunner/TestController.cpp:
1878         (WTR::createOtherPage):
1879         (WTR::TestController::initialize):
1880         Added zeroes to WKPageUIClient structures to avoid build failures.
1881
1882 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1883
1884         Reviewed by Eric Seidel.
1885
1886         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1887
1888         https://bugs.webkit.org/show_bug.cgi?id=52756
1889
1890         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1891         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1892         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1893         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1894         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1895         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1896
1897 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1898
1899         Reviewed by Antonio Gomes.
1900
1901         QtTestBrowser should have a seperate menu for Settings
1902         https://bugs.webkit.org/show_bug.cgi?id=52817
1903         
1904         Added a new menu item named "Settings"
1905         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1906
1907         * QtTestBrowser/launcherwindow.cpp:
1908         (LauncherWindow::createChrome):
1909
1910 2011-01-20  Sam Weinig  <sam@webkit.org>
1911
1912         Reviewed by John Sullivan.
1913
1914         Update update-webkit-localizable-strings with new path to WebKit.
1915
1916         * Scripts/update-webkit-localizable-strings:
1917
1918 2011-01-20  James Robinson  <jamesr@chromium.org>
1919
1920         Reviewed by Darin Fisher.
1921
1922         Implement mozilla's requestAnimationFrame API
1923         https://bugs.webkit.org/show_bug.cgi?id=51218
1924
1925         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1926
1927         * DumpRenderTree/chromium/WebViewHost.cpp:
1928         (invokeScheduleComposite):
1929         (WebViewHost::scheduleAnimation):
1930         (WebViewHost::paintInvalidatedRegion):
1931         * DumpRenderTree/chromium/WebViewHost.h:
1932
1933 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1934
1935         Reviewed by Adam Roben.
1936
1937         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1938         https://bugs.webkit.org/show_bug.cgi?id=42327
1939
1940         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1941         for methods that take their normal arguments but also a JSContextRef.
1942         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1943         for evaluateScriptInIsolatedWorld.
1944         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1945         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1946         this call is for an isolated world.
1947         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1948         (WTR::worldMap): Helper to create a world map.
1949         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1950         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1951         added LayoutTestController API.
1952         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1953
1954 2011-01-19  Adam Roben  <aroben@apple.com>
1955
1956         Convert paths in environment variables back to msys-style inside commit-log-editor
1957
1958         When this script gets run from inside git commit, msys-style paths in the environment will
1959         have been turned into Windows-style paths with forward slashes. This screws up functions
1960         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1961         the paths back to msys-style before doing anything else.
1962
1963         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1964         using msysgit's Perl and multiple ChangeLogs have been edited
1965
1966         Reviewed by David Kilzer.
1967
1968         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1969         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1970         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1971
1972 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1973
1974         [Win] Unreviewed build fix after r76248.
1975
1976         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1977
1978 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1979
1980         Reviewed by Csaba Osztrogonác.
1981
1982         Refactoring of the custom allocation framework
1983         https://bugs.webkit.org/show_bug.cgi?id=49897
1984
1985         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1986         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1987         equivalent macro implementation at the necessary places.
1988 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1989
1990         Unreviewed. 
1991
1992         Adding myself to committers.py.
1993
1994         * Scripts/webkitpy/common/config/committers.py:
1995
1996 2011-01-20  Adam Barth  <abarth@webkit.org>
1997
1998         Reviewed by Tony Chang.
1999
2000         Chromium builders don't delete unversioned directories when DEPS change
2001         https://bugs.webkit.org/show_bug.cgi?id=52745
2002
2003         If we pass this option to gclient sync, gclient will delete directories
2004         that are no longer part of DEPS instead of leaving them around to
2005         confuse us later.  Apparently, the downstream buildbots use this option
2006         already.
2007
2008         * Scripts/update-webkit-chromium:
2009
2010 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2011
2012         Unreviewed, build fix - I pulled this patch in to fix an issue
2013         revealed by r76195 running on some new bots). Also fix a couple
2014         of other issues revealed in testing.
2015
2016         nrwt: remove fs refs from layout_package/json*
2017
2018         https://bugs.webkit.org/show_bug.cgi?id=52754
2019
2020         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2021         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2022         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2023         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2024         * Scripts/webkitpy/layout_tests/port/base.py:
2025
2026 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2027
2028         Unreviewed, build fix.
2029
2030         Fix a couple of minor bugs discovered while bringing up new bots
2031         for testing.
2032
2033         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2034         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2035
2036 2011-01-19  James Robinson  <jamesr@chromium.org>
2037
2038         Unreviewed, rolling out r76194.
2039         http://trac.webkit.org/changeset/76194
2040         https://bugs.webkit.org/show_bug.cgi?id=51218
2041
2042         Caused mysterious compile failure on the chromium win
2043         build.webkit.org bots
2044
2045         * DumpRenderTree/chromium/WebViewHost.cpp:
2046         (WebViewHost::paintInvalidatedRegion):
2047         * DumpRenderTree/chromium/WebViewHost.h:
2048
2049 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2050
2051         Reviewed by Mihai Parparita.
2052
2053         remove fs refs from test_runner, dump_render_tree_thread
2054
2055         https://bugs.webkit.org/show_bug.cgi?id=52753
2056
2057         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2058         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2059         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2060         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2061
2062 2011-01-19  James Robinson  <jamesr@chromium.org>
2063
2064         Reviewed by Darin Fisher.
2065
2066         Implement mozilla's requestAnimationFrame API
2067         https://bugs.webkit.org/show_bug.cgi?id=51218
2068
2069         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2070
2071         * DumpRenderTree/chromium/WebViewHost.cpp:
2072         (invokeScheduleComposite):
2073         (WebViewHost::scheduleAnimation):
2074         (WebViewHost::paintInvalidatedRegion):
2075         * DumpRenderTree/chromium/WebViewHost.h:
2076
2077 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2078
2079         Unreviewed, build fix.
2080
2081         Fix a few incorrect "self._filesystem" references introduced in
2082         r76184.
2083
2084         * Scripts/webkitpy/layout_tests/port/chromium.py:
2085         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2086
2087 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2088
2089         Reviewed by Mihai Parparita.
2090
2091         add a .sep property, abspath(), isabs(), mtime(), and
2092         open_text_file_for_writing() to filesystem modules. Some of
2093         these properties are not needed in this patch but will be needed
2094         in subsequent patches (I'm doing this to avoid having to track
2095         multiple versions of a single file).
2096
2097         Also, change most of the port/* modules to use the filesystem
2098         objects instead of referencing the filesystem directly.
2099
2100         https://bugs.webkit.org/show_bug.cgi?id=52748
2101
2102         * Scripts/webkitpy/common/system/filesystem.py:
2103         * Scripts/webkitpy/common/system/filesystem_mock.py:
2104         * Scripts/webkitpy/layout_tests/port/__init__.py:
2105         * Scripts/webkitpy/layout_tests/port/base.py:
2106         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2107         * Scripts/webkitpy/layout_tests/port/chromium.py:
2108         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2109         * Scripts/webkitpy/layout_tests/port/config.py:
2110         * Scripts/webkitpy/layout_tests/port/test.py:
2111         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2112
2113 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2114
2115         Reviewed by Anders Carlsson.
2116
2117         If resetting between tests times out, treat it as a WebProcess crash
2118         https://bugs.webkit.org/show_bug.cgi?id=52757
2119
2120         * WebKitTestRunner/TestController.cpp:
2121         (WTR::TestController::runTest):
2122
2123 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2124
2125         Reviewed by Darin Adler.
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=52739
2128         Make it possible for a WebKit2 client to print headers and footers
2129
2130         Added dummy implementations for new printing UIClient calls.
2131
2132         * MiniBrowser/mac/BrowserWindowController.m:
2133         (-[BrowserWindowController awakeFromNib]):
2134         * WebKitTestRunner/TestController.cpp:
2135         (WTR::createOtherPage):
2136         (WTR::TestController::initialize):
2137
2138 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2139
2140         Reviewed by Ojan Vafai.
2141
2142         Change webkitpy/layout_tests/port/test.py to use the
2143         in-memory filesystem for cleaner unit testing. This
2144         change allows us to kill a lot of code that was
2145         specific to the test port, at the cost of being a
2146         little less clear about how things would work if
2147         you didn't have a filesystem.
2148
2149         https://bugs.webkit.org/show_bug.cgi?id=52605
2150
2151         * Scripts/webkitpy/layout_tests/port/test.py:
2152
2153 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2154
2155         Unreviewed, build fix.
2156
2157         Fix test failure caused by committing attachment 79368 instead
2158         of attachment 79461 on bug 52604.
2159
2160         * Scripts/webkitpy/common/system/filesystem_mock.py:
2161
2162 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2163
2164         Reviewed by Mihai Parparita.
2165
2166         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2167         unit testing. os.walk() is too much of a hassle to implement on
2168         top of the in-memory mock filesystem and adding the necessary
2169         interface to files_under() gives clients a cleaner API anyway
2170         (for this particular usage model).
2171
2172         https://bugs.webkit.org/show_bug.cgi?id=52691
2173
2174         * Scripts/webkitpy/common/system/filesystem.py:
2175         * Scripts/webkitpy/common/system/filesystem_mock.py:
2176         * Scripts/webkitpy/layout_tests/port/test_files.py:
2177         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2178
2179 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2180
2181         Reviewed by Tony Chang.
2182
2183         Change more modules in the layout-tests code to use the
2184         filesystem wrapper for cleaner unit testing.
2185
2186         This patch also adds the glob() wrapper to the filesystem
2187         abstraction.
2188         
2189         https://bugs.webkit.org/show_bug.cgi?id=52604
2190
2191         * Scripts/webkitpy/layout_tests/port/test_files.py:
2192         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2193         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2194         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2195         * Scripts/webkitpy/common/system/filesystem.py:
2196         * Scripts/webkitpy/common/system/filesystem_mock.py:
2197
2198 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2199
2200         Unreviewed.
2201
2202         Updating my email addresses and irc nick.
2203
2204         * Scripts/webkitpy/common/config/committers.py:
2205
2206 2011-01-19  Tony Chang  <tony@chromium.org>
2207
2208         Reviewed by Mihai Parparita.
2209
2210         [chromium] [linux] if check-sys-deps fails, output the failure reason
2211         https://bugs.webkit.org/show_bug.cgi?id=52671
2212
2213         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2214             error handler functions.
2215         * Scripts/webkitpy/layout_tests/port/chromium.py:
2216             output the error text from --check-sys-deps
2217         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2218
2219 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2220
2221         Reviewed by Andreas Kling.
2222
2223         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2224         https://bugs.webkit.org/show_bug.cgi?id=52554
2225         
2226         QtNetworkAccessManager is created in a thread and set as
2227         member variable in QWebPage. When the thread is destroyed
2228         the object is still used. So fix will set the object to
2229         NULL once the thread is destroyed.
2230
2231         * QtTestBrowser/launcherwindow.cpp:
2232         (LauncherWindow::~LauncherWindow):
2233
2234 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2235
2236         Rubber stamped by Csaba Osztrogonac
2237
2238         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2239
2240 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2241
2242         Reviewed by Tony Chang.
2243
2244         new-run-webkit-tests: add a --build-directory command line argument
2245
2246         Official Google Chrome builds use a non-standard build directory
2247         location. This patch adds a --build-directory argument that
2248         allows that location to be specified on the command line. Only
2249         Chromium-based builds will use this flag for now, but anyone can
2250         in the future.
2251
2252         There are no unit tests for this since it's difficult to test
2253         until mock filesystems are fully supported in the code. This was
2254         tested by hand for now.
2255
2256         https://bugs.webkit.org/show_bug.cgi?id=52694
2257
2258         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2259         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2260         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2261         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2262
2263 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2264
2265         Not reviewed. Bot fix.
2266
2267         Remove an inadvertently committed debugging print.
2268
2269         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2270         (LayoutTestController::notifyDone):
2271
2272 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2273
2274         Reviewed by Sam Weinig.
2275
2276         WebKitTestRunner should track loading more like DumpRenderTree
2277         https://bugs.webkit.org/show_bug.cgi?id=52692
2278
2279         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2280         This makes some tests that call notifyDone multiple times pass.
2281         
2282         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2283         (WTR::InjectedBundle::InjectedBundle):
2284         (WTR::InjectedBundle::done):
2285         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2286         (WTR::InjectedBundle::topLoadingFrame):
2287         (WTR::InjectedBundle::setTopLoadingFrame):
2288         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2289         (WTR::InjectedBundlePage::InjectedBundlePage):
2290         (WTR::InjectedBundlePage::stopLoading):
2291         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2292         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2293         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2294         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2295         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2296         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2297         (WTR::LayoutTestController::notifyDone):
2298         * WebKitTestRunner/TestController.cpp:
2299         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2300
2301 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2302
2303         Reviewed by Kent Tamura.
2304
2305         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2306         https://bugs.webkit.org/show_bug.cgi?id=52678
2307         
2308         Update path now that WebKit is inside Source.
2309
2310         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2311
2312 2011-01-18  Robert Hogan  <robert@webkit.org>
2313
2314         Reviewed by Simon Hausmann.
2315
2316         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2317         https://bugs.webkit.org/show_bug.cgi?id=44282
2318
2319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2320         (WebCore::DumpRenderTree::dump):
2321
2322 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2323
2324         Reviewed by Mihai Parparita.
2325
2326         Fix a small race condition that could cause the unit tests for
2327         new-run-webkit-tests to fail in a multithreaded environment.
2328         There was a small window in the code where one thread would
2329         check to see if a thread had raised an exception, do something,
2330         and then check to see if the thread was alive. If the other
2331         thread raised an exception and exited in between these two
2332         steps, the exception would be lost. Flipping the order of the
2333         two checks fixes the race, since we will now always check for an
2334         exception on the thread before exiting.
2335
2336         https://bugs.webkit.org/show_bug.cgi?id=51579
2337
2338         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2339
2340 2011-01-18  Eric Seidel  <eric@webkit.org>
2341
2342         Reviewed by Adam Barth.
2343
2344         commit-queue dies when test archiving fails
2345         https://bugs.webkit.org/show_bug.cgi?id=52617
2346
2347         I looked at the machine and it had 10 archives already
2348         thus find_unused_name was returning None.  I've upped
2349         the limit to 100 (per bug) and tested the case where
2350         find_unused_name returns None (making archive return None).
2351
2352         * Scripts/webkitpy/common/system/workspace.py:
2353         * Scripts/webkitpy/common/system/workspace_unittest.py:
2354         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2355         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2356         * Scripts/webkitpy/tool/commands/queues.py:
2357
2358 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2359
2360         Reviewed by Ojan Vafai.
2361
2362         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2363         filesystem. Also fix a couple of "with" statements missed by
2364         r76050.
2365
2366         https://bugs.webkit.org/show_bug.cgi?id=52487
2367
2368         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2369
2370 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2371
2372         Reviewed by Martin Robinson.
2373
2374         [Gtk] Build fixes for gtk3 build
2375         https://bugs.webkit.org/show_bug.cgi?id=52648
2376
2377         * DumpRenderTree/gtk/EventSender.cpp:
2378         (beginDragWithFilesCallback):
2379
2380 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2381
2382         Reviewed by Mihai Parparita.
2383
2384         Update rebaseline-chromium-webkit-tests to use filesystem objects
2385         instead of direct references to os.path, shutil, tempfile, etc.
2386
2387         This patch doesn't change anything, but will allow subsequent
2388         patches to change the unit tests to no longer use the real
2389         filesystem.
2390
2391         This patch adds a bunch more methods to the filesystem object as
2392         well.
2393
2394         https://bugs.webkit.org/show_bug.cgi?id=52482
2395
2396         * Scripts/webkitpy/common/system/filesystem.py:
2397         * Scripts/webkitpy/common/system/filesystem_mock.py:
2398         * Scripts/webkitpy/tool/commands/queues.py:
2399         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2400         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2401
2402 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2403
2404         Reviewed by Mihai Parparita.
2405
2406         new-run-webkit-tests shouldn't crash when you try to run a
2407         directory containing only skipped files.
2408
2409         https://bugs.webkit.org/show_bug.cgi?id=52478
2410         
2411         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2412         * Scripts/webkitpy/layout_tests/port/test.py:
2413         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2414
2415 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2416
2417         Reviewed by Gustavo Noronha Silva.
2418
2419         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2420         https://bugs.webkit.org/show_bug.cgi?id=40833
2421
2422         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2423         GTK+ event sender.
2424         (dragWithFilesDragDataGetCallback): Added.
2425         (dragWithFilesDragEndCallback): Added.
2426         (beginDragWithFilesCallback): Added.
2427
2428 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2429
2430         Reviewed by Adam Barth.
2431
2432         ews: Add additional watcher to efl ews
2433         https://bugs.webkit.org/show_bug.cgi?id=52613
2434
2435         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2436
2437         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2438
2439 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2440
2441         Reviewed by Alexey Proskuryakov.
2442
2443         Fix some headers with missing or misspelled #ifndef guards
2444         https://bugs.webkit.org/show_bug.cgi?id=52545
2445
2446         * DumpRenderTree/chromium/TestEventPrinter.h:
2447         * DumpRenderTree/chromium/WebPreferences.h:
2448
2449 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2450
2451         Reviewed by Anders Carlsson.
2452
2453         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2454         navigating back to an unreachable URL
2455         https://bugs.webkit.org/show_bug.cgi?id=52388
2456
2457         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2458
2459         * DumpRenderTree/LayoutTestController.cpp:
2460         (queueLoadHTMLStringCallback):
2461         (LayoutTestController::queueLoadHTMLString):
2462         (LayoutTestController::queueLoadAlternateHTMLString):
2463         * DumpRenderTree/LayoutTestController.h:
2464
2465         * DumpRenderTree/WorkQueueItem.h:
2466         (LoadHTMLStringItem::LoadHTMLStringItem):
2467
2468         * DumpRenderTree/chromium/LayoutTestController.cpp:
2469         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2470         (WorkItemLoadHTMLString::run):
2471         (LayoutTestController::queueLoadHTMLString):
2472
2473         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2474         (LoadHTMLStringItem::invoke):
2475         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2476         (LoadHTMLStringItem::invoke):
2477         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2478         (LoadHTMLStringItem::invoke):
2479
2480 2011-01-17  Dan Bernstein  <mitz@apple.com>
2481
2482         Rubber-stamped by Mark Rowe.
2483
2484         Update xcodeproj svn:ignore to include xcuserdata.
2485
2486         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2487         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2488         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2489         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2490         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2491
2492 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2493
2494         Unreviewed fix after r75908.
2495
2496         Move WebKit into Source
2497         https://bugs.webkit.org/show_bug.cgi?id=52530
2498
2499         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2500
2501 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2502
2503         Unreviewed.
2504
2505         Remove accidentally committed debug printing after r75908.
2506
2507         * Scripts/webkitdirs.pm:
2508
2509 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2510
2511         Unreviewed.
2512
2513         Add myself to committers list
2514         https://bugs.webkit.org/show_bug.cgi?id=52566
2515
2516         * Scripts/webkitpy/common/config/committers.py:
2517
2518 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2519
2520         Reviewed by Jeremy Orlow.
2521
2522         GeolocationController should call stopUpdating on destruction
2523         https://bugs.webkit.org/show_bug.cgi?id=52216
2524
2525         fast/dom/Geolocation/window-close-crash.html requires that a
2526         Geolocation watch be started in a secondary window. Consequently,
2527         we need to allow geolocation permission and provide a mock
2528         geolocation position for the secondary window's
2529         GeolocationClientMock.
2530
2531         * DumpRenderTree/chromium/LayoutTestController.cpp:
2532         (LayoutTestController::setGeolocationPermission):
2533         (LayoutTestController::setMockGeolocationPosition):
2534         (LayoutTestController::setMockGeolocationError):
2535         * DumpRenderTree/chromium/TestShell.h:
2536         (TestShell::windowList):
2537
2538 2011-01-16  Adam Barth  <abarth@webkit.org>
2539
2540         Update more include paths to reflect WebKit move.
2541
2542         * DumpRenderTree/chromium/EventSender.cpp:
2543         (EventSender::keyDown):
2544         (EventSender::needsShiftModifier):
2545         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2546         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2547
2548 2011-01-16  Kent Tamura  <tkent@chromium.org>
2549
2550         Unreviewed, Chromium build fix.
2551
2552         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2553
2554 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2555
2556         Build fix for GTK+ after source directory movement.
2557
2558         * GNUmakefile.am: Correct include paths.
2559
2560 2011-01-16  Adam Barth  <abarth@webkit.org>
2561
2562         Teach svn-apply about WebKit move.
2563
2564         * Scripts/VCSUtils.pm:
2565
2566 2011-01-16  Adam Barth  <abarth@webkit.org>
2567
2568         Rubber-stamped by Eric Seidel.
2569
2570         Move WebKit into Source
2571         https://bugs.webkit.org/show_bug.cgi?id=52530
2572
2573         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2574         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2575         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2576         * DumpRenderTree/qt/GCControllerQt.cpp:
2577         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2578         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2579         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2580         * DumpRenderTree/wscript:
2581         * QtTestBrowser/launcherwindow.h:
2582         * Scripts/build-webkit:
2583         * Scripts/webkitdirs.pm:
2584
2585 2011-01-15  Adam Barth  <abarth@webkit.org>
2586
2587         Teach svn-apply about WebKit2 move.
2588
2589         * Scripts/VCSUtils.pm:
2590
2591 2011-01-15  Adam Barth  <abarth@webkit.org>
2592
2593         Rubber-stamped by Eric Seidel.
2594
2595         Move WebKit2 into Source
2596         https://bugs.webkit.org/show_bug.cgi?id=52438
2597
2598         * MiniBrowser/qt/MiniBrowser.pro:
2599         * Scripts/build-webkit:
2600         * Scripts/do-file-rename:
2601         * Scripts/do-webcore-rename:
2602         * Scripts/test-webkitpy:
2603         * Scripts/webkitdirs.pm:
2604         * Scripts/webkitpy/style/checker.py:
2605         * WebKitTestRunner/DerivedSources.pro:
2606         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2607         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2608
2609 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2610
2611         Reviewed by David Levin.
2612
2613         [chromium] remove obsolete createView method
2614         https://bugs.webkit.org/show_bug.cgi?id=52437
2615
2616         * DumpRenderTree/chromium/WebViewHost.cpp:
2617         (WebViewHost::createView):
2618         * DumpRenderTree/chromium/WebViewHost.h:
2619
2620 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2621
2622         Reviewed by Geoff Garen.
2623
2624         ShouldLoadResourceForFrame should use strings, not URLs.
2625         https://bugs.webkit.org/show_bug.cgi?id=52476
2626
2627         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2628         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2629         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2630
2631 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2632
2633         Reviewed by David Levin.
2634
2635         Add Tony Gentilcore as a reviewer
2636         https://bugs.webkit.org/show_bug.cgi?id=52480
2637
2638         * Scripts/webkitpy/common/config/committers.py:
2639
2640 2011-01-14  David Levin  <levin@chromium.org>
2641
2642         Reviewed by Eric Seidel.
2643
2644         check-webkit-style: _FunctionState should keep track of where the function name starts.
2645         https://bugs.webkit.org/show_bug.cgi?id=52454
2646
2647         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2648         _FunctionState and logic for setting it correctly.
2649         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2650
2651 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2652
2653         Reviewed by David Levin.
2654
2655         Add support to DumpRenderTree to use the GPU rather than software renderer
2656         https://bugs.webkit.org/show_bug.cgi?id=52333
2657
2658         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2659         (main):
2660         * Scripts/webkitpy/layout_tests/port/chromium.py:
2661         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2662
2663 2011-01-14  Tony Chang  <tony@chromium.org>
2664
2665         Reviewed by Kent Tamura.
2666
2667         [chromium] update fonts.conf to fix 6 linux tests in drt
2668         https://bugs.webkit.org/show_bug.cgi?id=52411
2669
2670         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2671             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2672
2673 2011-01-14  Eric Seidel  <eric@webkit.org>
2674
2675         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2676
2677         Reviewed by Adam Barth.
2678
2679         Fix when running Tools/Scripts/check-webkit-style without arguments.
2680         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2681
2682         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2683         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2684
2685 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2686
2687         Reviewed by David Levin.
2688
2689         Store the tempdir object in a variable so it doesn't get deleted too early.
2690         https://bugs.webkit.org/show_bug.cgi?id=51875
2691
2692         * Scripts/update-webkit-auxiliary-libs:
2693         * Scripts/update-webkit-support-libs:
2694
2695 2011-01-14  Eric Seidel  <eric@webkit.org>
2696
2697         Unreviewed.  Make it work in python 2.5.
2698
2699         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2700         https://bugs.webkit.org/show_bug.cgi?id=49158
2701
2702         * Scripts/webkitpy/common/checkout/api_unittest.py:
2703
2704 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2705
2706         Unreviewed, rolling out r75774.
2707         http://trac.webkit.org/changeset/75774
2708         https://bugs.webkit.org/show_bug.cgi?id=52431
2709
2710         gtk builds were broken (Requested by loislo2 on #webkit).
2711
2712         * Scripts/webkitpy/common/checkout/scm.py:
2713
2714 2011-01-14  David Levin  <levin@chromium.org>
2715
2716         Reviewed by Shinichiro Hamaji.
2717
2718         check-webkit-style: _FunctionState should detect pure functions.
2719         https://bugs.webkit.org/show_bug.cgi?id=52428
2720
2721         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2722         is a pure virtual function.
2723         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2724         virtual functions are correctly detected.
2725
2726 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2727
2728         Reviewed by Yury Semikhatsky.
2729
2730         Just small fix for problem with check-webkit-style.
2731         It just didn't work for this patch.
2732         Old code can't concatenate a list of strings with None.
2733
2734         * Scripts/webkitpy/common/checkout/scm.py:
2735
2736 2011-01-13  David Levin  <levin@chromium.org>
2737
2738         Reviewed by Shinichiro Hamaji.
2739
2740         check-webkit-style: _FunctionState should use Position to know where items are.
2741         https://bugs.webkit.org/show_bug.cgi?id=52424
2742
2743         * Scripts/webkitpy/style/checkers/cpp.py:
2744         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2745         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2746         did some minor clean-up.
2747         (*): Other changes are simply about converting to use the Position's in_FunctionState
2748         instead of line numbers.
2749         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2750         to verify the positions stored in _FunctionState.
2751
2752 2011-01-13  Eric Seidel  <eric@webkit.org>
2753
2754         Reviewed by David Levin.
2755
2756         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2757         https://bugs.webkit.org/show_bug.cgi?id=49158
2758
2759         This is not the most elegant, but it is a very safe fix to this bug.
2760         One advantage of catching ScriptError like this instead of adding a
2761         new added_or_modified_files or fixing all changed_files callers
2762         to use a more specific change_files variant, is that we catch
2763         all kinds of ScriptErrors which might cause our (non-essential)
2764         suggest-reviewers code to fail out.  This should make passing
2765         --suggest-reviewers to webkit-patch upload much more robust
2766         and may even make it possible for us to make it default.
2767
2768         The root of the problem here is that SCM.changed_files includes
2769         deleted ChangeLog paths (from moves, etc) which then when we ask
2770         SVN/Git for the contents of the file at that revision, the command
2771         errors out and Executive.run_command raises a ScriptError.
2772
2773         In the future we might fix this differently by making all current
2774         callers of chagned_files use a more specific method for requesting
2775         what types of changes they're interested in (adds, modifies, deletes, etc.)
2776
2777         * Scripts/webkitpy/common/checkout/api.py:
2778         * Scripts/webkitpy/common/checkout/api_unittest.py:
2779
2780 2011-01-13  Dan Bernstein  <mitz@apple.com>
2781
2782         Reviewed by Alexey Proskuryakov.
2783
2784         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2785         https://bugs.webkit.org/show_bug.cgi?id=52419
2786
2787         Allow to further control the behavior of the willSendRequest delegate callback by making it
2788         set a different URL in the new request.
2789
2790         * DumpRenderTree/LayoutTestController.cpp:
2791         (addURLToRedirectCallback): Added.
2792         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2793         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2794         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2795         * DumpRenderTree/LayoutTestController.h:
2796         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2797         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2798         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2799         change the URL in the new request to the redirect destination.
2800
2801 2011-01-13  Eric Seidel  <eric@webkit.org>
2802
2803         Reviewed by Mihai Parparita.
2804
2805         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2806         https://bugs.webkit.org/show_bug.cgi?id=52416
2807
2808         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2809         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2810
2811         I also added FIXMEs about the changed_files returning deleted files problem
2812         which is causing the other most common exception for suggest-reviewers
2813         (and is probably breaking sheriff-bots blame detection).
2814
2815         * Scripts/webkitpy/common/checkout/api.py:
2816         * Scripts/webkitpy/common/checkout/api_unittest.py:
2817         * Scripts/webkitpy/common/checkout/scm.py:
2818
2819 2011-01-13  Eric Seidel  <eric@webkit.org>
2820
2821         Reviewed by Adam Barth.
2822
2823         results archives from commit-queue are too large to upload
2824         https://bugs.webkit.org/show_bug.cgi?id=52405
2825
2826         * Scripts/webkitpy/common/system/filesystem.py:
2827         * Scripts/webkitpy/common/system/filesystem_mock.py:
2828         * Scripts/webkitpy/tool/commands/queues.py:
2829
2830 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2831
2832         Reviewed by Martin Robinson.
2833
2834         [gtk] Zero-sized font does not yet work
2835         https://bugs.webkit.org/show_bug.cgi?id=49793
2836
2837         Set minimum-font-size to 0 for the DRT.
2838
2839         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2840         (resetDefaultsToConsistentValues):
2841
2842 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2843
2844         Reviewed by Darin Adler.
2845
2846         Make old-run-webkit-tests more robust on buildbots
2847         https://bugs.webkit.org/show_bug.cgi?id=52364
2848
2849         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2850
2851 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2852
2853         Reviewed by Darin Adler.
2854
2855         Make old-run-webkit-tests more robust on buildbots
2856         https://bugs.webkit.org/show_bug.cgi?id=52364
2857
2858         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2859
2860 2011-01-13  Tony Chang  <tony@chromium.org>
2861
2862         Reviewed by Kent Tamura.
2863
2864         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2865         https://bugs.webkit.org/show_bug.cgi?id=52332
2866
2867         Forked Info.plist is not longer needed.
2868
2869         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2870
2871 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2872
2873         Reviewed by Timothy Hatcher.
2874
2875         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2876         to be passed directly to WebInspector.UIString
2877
2878         https://bugs.webkit.org/show_bug.cgi?id=52365
2879
2880         * Scripts/check-inspector-strings:
2881
2882 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2883
2884         Unreviewed, rolling out r74881.
2885         http://trac.webkit.org/changeset/74881
2886         https://bugs.webkit.org/show_bug.cgi?id=52357
2887
2888         The EFL builder has been red for days (Requested by abarth on
2889         #webkit).
2890
2891         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2892         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2893
2894 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2895
2896         Reviewed by David Levin.
2897
2898         Add beforeunload support to WebKitTestRunner
2899         https://bugs.webkit.org/show_bug.cgi?id=52353
2900         
2901         This makes a number of currently failing tests pass.
2902
2903         * WebKitTestRunner/TestController.cpp:
2904         (WTR::runBeforeUnloadConfirmPanel):
2905         (WTR::createOtherPage):
2906         (WTR::TestController::initialize):
2907
2908 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2909
2910         Reviewed by Sam Weinig.
2911
2912         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2913         https://bugs.webkit.org/show_bug.cgi?id=52330
2914
2915         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2916         a web process crash.
2917         * WebKitTestRunner/TestController.cpp:
2918         (WTR::TestController::initialize): Set up a processDidCrash
2919         callback.
2920         (WTR::TestController::processDidCrash): Report that the Web process
2921         crashed.
2922         * WebKitTestRunner/TestController.h:
2923
2924 2011-01-12  David Levin  <levin@chromium.org>
2925
2926         Reviewed by Shinichiro Hamaji.
2927
2928         check-webkit-style -- close_expression function doesn't work correctly.
2929         https://bugs.webkit.org/show_bug.cgi?id=52272
2930
2931         * Scripts/webkitpy/style/checkers/cpp.py:
2932         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2933         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2934         generally useful (for upcoming code changes).
2935         (close_expression): Changed to use Position for input and output.
2936         Also, fixed many bugs such as only working correctly for parenthesis,
2937         not working correctly if given an offset in a line and not finding
2938         the real closing element if there were multiple closing elements in
2939         the same line.
2940         (detect_functions): Adjusted due to the change in arguments for
2941         close_expression.
2942         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2943         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2944         two positions are the same.
2945         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2946         (CppStyleTest.test_close_expression): Added tests to catch the issues
2947         that were fixed.
2948
2949 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2950
2951         Unreviewed, rolling out r75576.
2952         http://trac.webkit.org/changeset/75576
2953         https://bugs.webkit.org/show_bug.cgi?id=52304
2954
2955         broke rebaseline-chromium-webkit-test (Requested by thakis on
2956         #webkit).
2957
2958         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2959         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2960         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2961         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2962         * Scripts/webkitpy/layout_tests/port/base.py:
2963         * Scripts/webkitpy/layout_tests/port/chromium.py:
2964         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2965         * Scripts/webkitpy/layout_tests/port/test.py:
2966         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2967         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2968         * Scripts/webkitpy/style/checkers/test_expectations.py:
2969         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2970
2971 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2972
2973         Reviewed by Darin Adler.
2974
2975         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2976         https://bugs.webkit.org/show_bug.cgi?id=52307
2977
2978         * Scripts/old-run-webkit-tests:
2979
2980 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2981
2982         Reviewed by Martin Robinson.
2983
2984         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2985         https://bugs.webkit.org/show_bug.cgi?id=50867
2986
2987         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2988         TestNetscapePlugin.cpp 
2989
2990         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2991         * Scripts/webkitdirs.pm:
2992
2993 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2994
2995         Reviewed by Pavel Feldman.
2996
2997         Add check-inspector-strings script.
2998
2999         https://bugs.webkit.org/show_bug.cgi?id=52295
3000
3001         * Scripts/check-inspector-strings: Added.
3002
3003 2011-01-12  Adam Roben  <aroben@apple.com>
3004
3005         Advertise the .testnetscape file extension on Windows
3006
3007         Fixes <http://webkit.org/b/52298>
3008         plugins/no-mime-with-valid-extension.html fails on Windows
3009
3010         Reviewed by Dan Bernstein.
3011
3012         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3013         FileExtents field to map the .testnetscape file extension to the
3014         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3015
3016 2011-01-12  Adam Barth  <abarth@webkit.org>
3017
3018         Reviewed by Eric Seidel.
3019
3020         Make webkit-patch support subdirectories for SVN checkouts
3021         https://bugs.webkit.org/show_bug.cgi?id=52261
3022
3023         os.relpath does not exist on Python 2.5, so we need to call our version
3024         of the API.
3025
3026         * Scripts/webkitpy/common/checkout/scm.py:
3027
3028 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3029
3030         Reviewed by Eric Seidel.
3031
3032         Close additional pages opened during a test once the test completes.
3033         https://bugs.webkit.org/show_bug.cgi?id=52276
3034
3035         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3036         (WTR::InjectedBundle::done):
3037
3038 2011-01-11  David Levin  <levin@chromium.org>
3039
3040         Reviewed by Eric Seidel.
3041
3042         Errors should be separated from the command line in bot messages.
3043         https://bugs.webkit.org/show_bug.cgi?id=52275
3044
3045         * Scripts/webkitpy/common/system/executive.py:
3046         (ScriptError.message_with_output): Added a newline to separate the command
3047         line from the errors.
3048         * Scripts/webkitpy/common/system/executive_unittest.py:
3049         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3050         paths in message_with_output.
3051
3052 2011-01-11  Eric Seidel  <eric@webkit.org>
3053
3054         Unreviewed.
3055
3056         commit-queue should know how to upload archived results (for test flakes or general failures)
3057         https://bugs.webkit.org/show_bug.cgi?id=52048
3058
3059         The zips are mostly empty due to forgetting -r.
3060         Expected diffs were not being pulled from the archive due
3061         to the archive having longer paths than I realized.
3062
3063         * Scripts/webkitpy/common/system/workspace.py:
3064         * Scripts/webkitpy/common/system/workspace_unittest.py:
3065         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3066         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3067
3068 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3069
3070         Reviewed by Ojan Vafai.
3071
3072         The current modifier parsing code in test_expectations is
3073         fragile and hard-coded, so it's not easy to understand the logic
3074         or easily add new types of modifiers (like GPU vs. CPU testing
3075         for graphics tests, or 32-bit vs. 64-bit differences).
3076
3077         This is the first of two patches that will add in more generic
3078         support and then eliminate the GPU-specific test expectations
3079         files for Chromium.
3080
3081         This patch adds two standalone objects for handling modifiers. The
3082         rules for interpreting modifiers, precedence, and conflicts are
3083         given in the docstring to the ModifierMatcher class, which
3084         returns ModifierMatchResult objects.
3085         
3086         This patch also adds routines to the Port interface and a
3087         default set of values in the base object, in order to obtain the
3088         values needed on a given test run. These values are then passed
3089         to the expectation parser. This also allows us to clean up the
3090         logic used to lint all of the different configurations in a
3091         single test_expectations.txt file.
3092
3093         The next patch will merge in the separate GPU expectations file.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=51222
3096
3097         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3098         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3099         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3100         * Scripts/webkitpy/layout_tests/port/base.py:
3101         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3102         * Scripts/webkitpy/layout_tests/port/chromium.py:
3103         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3104         * Scripts/webkitpy/layout_tests/port/test.py:
3105         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3106         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3107
3108 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3109
3110         Reviewed by Adam Barth.
3111
3112         Make webkit-patch support subdirectories for SVN checkouts
3113         https://bugs.webkit.org/show_bug.cgi?id=52261
3114
3115         * Scripts/webkitpy/common/checkout/scm.py:
3116         * Scripts/webkitpy/style_references.py:
3117         * Scripts/webkitpy/tool/main.py:
3118         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3119
3120 2011-01-11  Eric Seidel  <eric@webkit.org>
3121
3122         Unreviewed.
3123
3124         commit-queue should know how to upload archived results (for test flakes or general failures)
3125         https://bugs.webkit.org/show_bug.cgi?id=52048
3126
3127         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3128         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3129
3130         * Scripts/webkitpy/common/system/workspace.py:
3131         * Scripts/webkitpy/common/system/workspace_unittest.py:
3132         * Scripts/webkitpy/tool/commands/queues.py:
3133
3134 2011-01-11  Sam Weinig  <sam@webkit.org>
3135
3136         Roll r75474 back in.
3137
3138 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3139
3140         Reviewed by Kenneth Rohde Christiansen.
3141
3142         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3143         https://bugs.webkit.org/show_bug.cgi?id=51204
3144
3145         * QtTestBrowser/webpage.h:
3146         (QtNAMThread::QtNAMThread):
3147         (QtNAMThread::networkAccessManager):
3148         (QtNAMThread::run):
3149
3150 2011-01-11  Peter Varga  <pvarga@webkit.org>
3151
3152         Unreviewed.
3153
3154         Add myself to committers' list.
3155
3156         * Scripts/webkitpy/common/config/committers.py:
3157
3158 2011-01-11  Eric Seidel  <eric@webkit.org>
3159
3160         Reviewed by Adam Barth.
3161
3162         commit-queue should know how to upload archived results (for test flakes or general failures)
3163         https://bugs.webkit.org/show_bug.cgi?id=52048
3164
3165         Now the queue will always upload results.  Either the entire zip, or just
3166         the diffs.txt in the case of text failures.
3167
3168         This should make understanding flakes much easier, and paves the way
3169         for having the EWS run layout tests (and upload failures).
3170
3171         In order to upload .zip files I had to teach bugzilla.py to autodetect
3172         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3173         for .patch files, I have it add one before calling guess_type.
3174
3175         We may find that always uploading the whole zip instead of just the -diffs.txt
3176         file is preferable, but for now I'm keeping the old behavior because it makes
3177         quickly understanding text failures easy.
3178
3179         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3180         * Scripts/webkitpy/common/system/workspace.py: Added.
3181         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3182         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3183         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3184         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3185         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3186         * Scripts/webkitpy/tool/commands/queues.py:
3187         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3188
3189 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3190
3191         Unreviewed, rolling out r75464.
3192         http://trac.webkit.org/changeset/75464
3193         https://bugs.webkit.org/show_bug.cgi?id=52193
3194
3195         Followup rollout for 75474 (Requested by Ossy on #webkit).
3196
3197         * MiniBrowser/mac/BrowserWindowController.m:
3198         (-[BrowserWindowController awakeFromNib]):
3199         * MiniBrowser/win/BrowserView.cpp:
3200         (BrowserView::create):
3201         * WebKitTestRunner/TestController.cpp:
3202         (WTR::createOtherPage):
3203         (WTR::TestController::initialize):
3204
3205 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3206
3207         Reviewed by Csaba Osztrogonác.
3208
3209         [Qt] Baseline qt_minimal configuration
3210         https://bugs.webkit.org/show_bug.cgi?id=51313
3211
3212         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3213         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3214         QT_NO_UNDOSTACK guard.
3215
3216         * QtTestBrowser/launcherwindow.cpp:
3217         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3218         guards.
3219         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3220         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3221         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3222         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3223
3224         * QtTestBrowser/launcherwindow.h:
3225         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3226         * QtTestBrowser/locationedit.h: Ditto.
3227
3228         * QtTestBrowser/mainwindow.cpp:
3229         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3230         QT_NO_UNDOSTACK guards.
3231         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3232         (MainWindow::changeLocation): Ditto.
3233         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3234         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3235
3236         * QtTestBrowser/webpage.cpp:
3237         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3238         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3239
3240         * QtTestBrowser/webview.cpp:
3241         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3242         (WebViewGraphicsBased::animatedYFlip): Ditto.
3243
3244 2011-01-10  Sam Weinig  <sam@webkit.org>
3245
3246         Fix build.
3247
3248         * MiniBrowser/mac/BrowserWindowController.m:
3249         (-[BrowserWindowController awakeFromNib]):
3250         * MiniBrowser/win/BrowserView.cpp:
3251         (BrowserView::create):
3252         * WebKitTestRunner/TestController.cpp:
3253         (WTR::createOtherPage):
3254         (WTR::TestController::initialize):
3255
3256 2011-01-10  Eric Seidel  <eric@webkit.org>
3257
3258         Reviewed by Ojan Vafai.
3259
3260         style-queue messages are way too long for big patches
3261         https://bugs.webkit.org/show_bug.cgi?id=52161
3262
3263         We definitely could build much fancier list-to-string-with-limit functions
3264         but this should be sufficient for our needs at the moment.
3265
3266         * Scripts/webkitpy/common/system/executive.py:
3267         * Scripts/webkitpy/common/system/executive_unittest.py:
3268
3269 2011-01-10  Tony Chang  <tony@chromium.org>
3270
3271         Unreviewed, rolling out r75398.
3272         http://trac.webkit.org/changeset/75398
3273         https://bugs.webkit.org/show_bug.cgi?id=52008
3274
3275         Some layout tests are crashing on Chromium Win.
3276
3277         * DumpRenderTree/chromium/WebViewHost.cpp:
3278         (WebViewHost::updatePaintRect):
3279         * DumpRenderTree/chromium/WebViewHost.h:
3280
3281 2011-01-10  Adam Roben  <aroben@apple.com>
3282
3283         Roll out r75392
3284
3285         It isn't needed now that r75289 has been rolled out.
3286
3287         * Scripts/run-javascriptcore-tests:
3288
3289 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3290
3291         Reviewed by Anders Carlsson.
3292
3293         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3294         https://bugs.webkit.org/show_bug.cgi?id=52160
3295
3296         * WebKitTestRunner/mac/TestControllerMac.mm:
3297         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3298         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3299         anyway.
3300
3301 2011-01-10  Tony Chang  <tony@chromium.org>
3302
3303         Reviewed by Mihai Parparita.
3304
3305         [chromium] fix for animated gif layout tests
3306         https://bugs.webkit.org/show_bug.cgi?id=52008
3307
3308         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3309             to trigger gif animations.
3310         (WebViewHostPaintTask::WebViewHostPaintTask):
3311         (WebViewHostPaintTask::runIfValid):
3312         (WebViewHost::updatePaintRect):
3313         * DumpRenderTree/chromium/WebViewHost.h:
3314         (WebViewHost::taskList):
3315
3316 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3317
3318         Reviewed by Xan Lopez.
3319
3320         [GTK] Fix gtk2 compilation for master
3321         https://bugs.webkit.org/show_bug.cgi?id=51885
3322
3323         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3324         (createBitmapContextFromWebView): Replaced the old
3325         gdk_drawable_get_size with gdk_pixmap_get_size.
3326
3327 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3328
3329         Reviewed by Laszlo Gombos.
3330
3331         [WINCE] Reenable NPAPI after r75203
3332         https://bugs.webkit.org/show_bug.cgi?id=52109
3333
3334         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3335         it with !isEfl(), because EFL port does not support NPAPI (yet).
3336
3337         * Scripts/build-webkit:
3338
3339 2011-01-10  Adam Roben  <aroben@apple.com>
3340
3341         Skip some asserting JS tests
3342
3343         See <http://webkit.org/b/52156>.
3344
3345         * Scripts/run-javascriptcore-tests:
3346
3347 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3348
3349         Reviewed by Xan Lopez.
3350
3351         [GTK] build-webkit disable Blob support via arguments passed to automake
3352         https://bugs.webkit.org/show_bug.cgi?id=52097
3353
3354         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3355         build-webkit.
3356
3357 2011-01-10  Adam Roben  <aroben@apple.com>
3358
3359         Use the same name and description for TestNetscapePlugin on Windows and
3360         Mac
3361
3362         Fixes <http://webkit.org/b/52151>
3363         fast/frames/iframe-reparenting-plugins.html fails on Windows
3364
3365         Reviewed by Steve Falkenburg.
3366
3367         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3368         the name and description from Mac's Info.plist.
3369
3370 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3371
3372         Reviewed by Laszlo Gombos.
3373
3374         [Qt][WK2] Guard gcc-specific syntax
3375
3376         Non-gcc based compliers choke on the "-include"
3377         syntax for preinclude, place guard around it.
3378
3379         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3380         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3381
3382 2011-01-10  Andreas Kling  <kling@webkit.org>
3383
3384         Reviewed by Simon Hausmann.
3385
3386         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3387         https://bugs.webkit.org/show_bug.cgi?id=52111
3388
3389         When getting a createNewPage() callback from QWKPage, create the
3390         new page with the same QWKContext as the page that is passed to
3391         the callback.
3392
3393         * MiniBrowser/qt/BrowserView.h:
3394         * MiniBrowser/qt/BrowserWindow.cpp:
3395         (newPageFunction):
3396         (BrowserWindow::BrowserWindow):
3397         * MiniBrowser/qt/BrowserWindow.h:
3398
3399 2011-01-10  Andreas Kling  <kling@webkit.org>
3400
3401         Reviewed by Kenneth Rohde Christiansen.
3402
3403         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3404
3405         BrowserView set its own useless createNewPage() callback on QWKPage.
3406         This was immediately overridden by BrowserWindow anyway, so remove
3407         the BrowserView one.
3408
3409         * MiniBrowser/qt/BrowserView.cpp:
3410         (BrowserView::BrowserView):
3411
3412 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3413
3414         Reviewed by Jeremy Orlow.
3415
3416         [Chromium] Remove non-client-based Geolocation code
3417         https://bugs.webkit.org/show_bug.cgi?id=50921
3418
3419         * DumpRenderTree/chromium/LayoutTestController.cpp:
3420         (LayoutTestController::setGeolocationPermission):
3421         (LayoutTestController::setMockGeolocationPosition):
3422         (LayoutTestController::setMockGeolocationError):
3423         * DumpRenderTree/chromium/WebViewHost.cpp:
3424         (WebViewHost::geolocationClientMock):
3425         (WebViewHost::reset):
3426         * DumpRenderTree/chromium/WebViewHost.h:
3427
3428 2011-01-10  Eric Seidel  <eric@webkit.org>
3429
3430         Reviewed by Adam Barth.
3431
3432         Commit bot tried to land r? cq+ patch
3433         https://bugs.webkit.org/show_bug.cgi?id=36638
3434
3435         It should now be possible to post a patch with r? and cq+ and the
3436         commit-queue will correctly wait for the r+ before attempting to land the patch.
3437         (This was a feature requested by several users.)
3438
3439         One caveat: We don't actually reject r-, cq+ patches from the queue
3440         (we just ignore them), but I think that's OK for now.
3441
3442         I also noticed that setting r- once a commit-queue node had grabbed
3443         a patch would not properly cancel the landing.  That's fixed and
3444         tested in this patch.
3445
3446         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3447         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3448         * Scripts/webkitpy/tool/bot/feeders.py:
3449         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3450
3451 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3452
3453         Reviewed by Kenneth Rohde Christiansen.
3454
3455         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3456         https://bugs.webkit.org/show_bug.cgi?id=51934
3457
3458         When accessing the network from the destructor of QWebPage, the network access manager
3459         was already deleted because the object WebPage was already destructed.
3460
3461         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3462         The object is now destructed in the destructor of QObject.
3463
3464         * QtTestBrowser/webpage.cpp:
3465         (WebPage::WebPage):
3466         (WebPage::setQnamThreaded):
3467         * QtTestBrowser/webpage.h:
3468         (QtNAMThread::QtNAMThread):
3469
3470 2011-01-08  Eric Seidel  <eric@webkit.org>
3471
3472         Reviewed by Ojan Vafai.
3473
3474         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3475         https://bugs.webkit.org/show_bug.cgi?id=52067
3476
3477         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3478         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3479
3480         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3481
3482 2011-01-08  Eric Seidel  <eric@webkit.org>
3483
3484         Reviewed by Mihai Parparita.
3485
3486         commit-queue hangs when the ChangeLog diff is bad
3487         https://bugs.webkit.org/show_bug.cgi?id=52072
3488
3489         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3490         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3491
3492 2011-01-08  Adam Barth  <abarth@webkit.org>
3493
3494         Teach svn-apply how to re-write WebCore to Source/WebCore.
3495
3496         * Scripts/VCSUtils.pm:
3497
3498 2011-01-07  Adam Barth  <abarth@webkit.org>
3499
3500         Rubber-stamped by Eric Seidel.
3501
3502         Move WebCore to Source
3503         https://bugs.webkit.org/show_bug.cgi?id=52050
3504
3505         Update the tools to understand WebCore's new location.
3506
3507         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3508         * DumpRenderTree/wscript:
3509         * GNUmakefile.am:
3510         * Scripts/build-webkit:
3511         * Scripts/do-file-rename:
3512         * Scripts/do-webcore-rename:
3513         * Scripts/generate-qt-inspector-resource:
3514         * Scripts/prepare-ChangeLog:
3515         * Scripts/run-bindings-tests:
3516         * Scripts/update-iexploder-cssproperties:
3517         * Scripts/update-sources-list.py:
3518         * Scripts/update-webkit-localizable-strings:
3519         * Scripts/webkitdirs.pm:
3520         * Scripts/webkitpy/common/config/build.py:
3521         * Scripts/webkitpy/common/config/build_unittest.py:
3522         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3523         * Scripts/webkitpy/style/checker.py:
3524         * Scripts/webkitpy/style/checker_unittest.py:
3525         * WebKitTestRunner/DerivedSources.pro:
3526         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3527         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3528         * wx/browser/wscript:
3529         * wx/build/settings.py:
3530
3531 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3532
3533         Reviewed by Sam Weinig.
3534
3535         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3536         https://bugs.webkit.org/show_bug.cgi?id=52086
3537
3538         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3539         (WTR::InjectedBundle::didReceiveMessage):
3540         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3541         (WTR::LayoutTestController::notifyDone):
3542         * WebKitTestRunner/TestController.cpp:
3543         (WTR::TestController::resetStateToConsistentValues):
3544         (WTR::TestController::run):
3545
3546 2011-01-07  James Robinson  <jamesr@chromium.org>
3547
3548         Revert "Implement mozilla's animationTime property"
3549         https://bugs.webkit.org/show_bug.cgi?id=51952
3550
3551         This approach isn't quite right.
3552
3553         * DumpRenderTree/chromium/WebViewHost.cpp:
3554         (WebViewHost::paintInvalidatedRegion):
3555
3556 2011-01-07  Adam Roben  <aroben@apple.com>
3557
3558         Build master fix
3559
3560         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3561         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3562
3563 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3564
3565         Reviewed by Csaba Osztrogonác.
3566
3567         run-qtwebkit-tests should be able to kill a testsuite.
3568
3569         Add new option in the script that can setup a timeout for a test.
3570         If the test execution takes more then specified time then the test
3571         would be terminated.
3572
3573         [Qt] run-qtwebkit-tests needs timeout
3574         https://bugs.webkit.org/show_bug.cgi?id=51894
3575
3576         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3577         * Scripts/run-qtwebkit-tests:
3578
3579 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3580
3581         Unreviewed fix after r75233.
3582
3583         Based on idea from Eric Seidel.
3584
3585         Add remote zip file handling to webkitpy.
3586         https://bugs.webkit.org/show_bug.cgi?id=50901
3587
3588         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3589
3590 2011-01-07  Shane Stephens  <shanestephens@google.com>
3591
3592         Reviewed by Eric Seidel.
3593
3594         svn-apply: should support git binary delta diffs
3595         https://bugs.webkit.org/show_bug.cgi?id=38864
3596
3597         * Scripts/VCSUtils.pm:
3598         * Scripts/svn-apply:
3599
3600 2011-01-06  Julie Parent  <jparent@chromium.org>
3601
3602         Reviewed by Eric Seidel.
3603
3604         Test Result Server not removing old results.
3605         https://bugs.webkit.org/show_bug.cgi?id=52012
3606
3607         * TestResultServer/model/jsonresults.py:
3608         Fix off-by-one: Truncate if >= num_runs, not just >.
3609         * TestResultServer/model/jsonresults_unittest.py:
3610         Add unit test to test that merging in a new result with the same value
3611         as the last result causes previous result to fall off.
3612
3613 2011-01-06  James Kozianski  <koz@chromium.org>
3614
3615         Reviewed by Mihai Parparita.
3616
3617         Add classes to provide a consistent interface to a set of files.
3618         https://bugs.webkit.org/show_bug.cgi?id=50901
3619
3620         These classes allow us to write code that is agnostic to whether a
3621         particular set of files resides in a local directory or in a zip file
3622         on a remote machine.
3623
3624         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3625         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3626         * Scripts/webkitpy/common/system/fileset.py: Added.
3627         * Scripts/webkitpy/common/system/filesystem.py:
3628         * Scripts/webkitpy/common/system/filesystem_mock.py:
3629         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3630         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3631
3632 2011-01-06  Eric Seidel  <eric@webkit.org>
3633
3634         Reviewed by Adam Barth.
3635
3636         NetworkTransaction should log the url it is retrying
3637         https://bugs.webkit.org/show_bug.cgi?id=52043
3638
3639         * Scripts/webkitpy/common/net/networktransaction.py:
3640         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3641
3642 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3643
3644         Windows build fix.
3645         Import os before using it.
3646
3647         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3648
3649 2011-01-06  Eric Seidel  <eric@webkit.org>
3650
3651         Reviewed by Adam Barth.
3652
3653         StyleQueue fails to report errors when patches have many files
3654         https://bugs.webkit.org/show_bug.cgi?id=52042
3655
3656         This is one of at least two errors preventing style error reporting at the moment.
3657         When we moved to passing the list of files to check explicitly,
3658         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3659         We could change the type of the QueueStatus.message type, or we could
3660         just teach statusserver.py how to clamp values (and warn when it does).
3661         I chose the latter path.
3662
3663         * Scripts/webkitpy/common/net/statusserver.py:
3664
3665 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3666
3667         Reviewed by Stephanie Lewis.
3668         
3669         Fix syntax error in script.
3670
3671         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3672         https://bugs.webkit.org/show_bug.cgi?id=51996
3673
3674         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3675
3676 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3677
3678         Unreviewed, fixing WinCE build after r75196.
3679
3680         WinCE port does not (yet) support NPAPI.
3681
3682         * Scripts/build-webkit:
3683
3684 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3685
3686         Reviewed by Darin Adler.
3687
3688         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3689         https://bugs.webkit.org/show_bug.cgi?id=52015
3690
3691         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3692         after the platform has been detected, otherwise the script will
3693         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3694         detection.
3695
3696 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3697
3698         Reviewed by Eric Seidel.
3699
3700         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3701         https://bugs.webkit.org/show_bug.cgi?id=51346
3702
3703         * Scripts/build-webkit:
3704
3705 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3706
3707         Reviewed by Adam Roben.
3708
3709         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3710         https://bugs.webkit.org/show_bug.cgi?id=51996
3711         
3712         After the configuration directory change, we were archiving the incorrect directory for
3713         build product, so we were running tests on the wrong binaries.
3714         
3715         This change archives the correct directory, and also unarchives it into a configuration-
3716         specific directory.
3717
3718         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3719         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3720
3721 2011-01-06  Eric Seidel  <eric@webkit.org>
3722
3723         Reviewed by Mihai Parparita.
3724
3725         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3726         https://bugs.webkit.org/show_bug.cgi?id=52002
3727
3728         See an example of this here:
3729         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3730
3731         It's due to the fact that we pass around TestFailure() instance
3732         objects and yet expect them to all compare to be the same.
3733
3734         This is bad.  We should either have shared instances of these values
3735         or we should just pass around the class names.  There are already hacks
3736         in place to make TestFailure objects pass equality tests, I just added
3737         a __hash__ implementation so they can be used in sets as expected.
3738
3739         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3740         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3741
3742 2011-01-06  Evan Martin  <evan@chromium.org>
3743
3744         Reviewed by Tony Chang.
3745
3746         [gdb] handle inaccessible memory and UChar*
3747         https://bugs.webkit.org/show_bug.cgi?id=52003
3748
3749         To pretty-print a UChar*, we just grope around in the memory
3750         looking for a terminating NUL.  We need to handle the exception
3751         that can occur when we poke into an invalid location.
3752
3753         Additionally, the logic for choosing which pretty-printer would
3754         early return before hitting the point where we'd use the UChar*
3755         printer.  (Did this ever work?  How did it regress?)
3756
3757         * gdb/webkit.py:
3758
3759 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3760
3761         Reviewed by Ada Chan.
3762
3763         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3764         https://bugs.webkit.org/show_bug.cgi?id=51969
3765         
3766         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3767
3768         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3769         (WTR::InjectedBundlePage::InjectedBundlePage):
3770         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3771         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3772
3773 2011-01-06  James Robinson  <jamesr@chromium.org>
3774
3775         Reviewed by Simon Fraser.
3776
3777         Implement mozilla's animationTime property
3778         https://bugs.webkit.org/show_bug.cgi?id=51952
3779
3780         Chromium DRT support for webkitAnimationTime.
3781
3782         * DumpRenderTree/chromium/WebViewHost.cpp:
3783         (WebViewHost::paintInvalidatedRegion):
3784
3785 2011-01-06  Julie Parent  <jparent@chromium.org>
3786
3787         Reviewed by Tony Chang.
3788
3789         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3790         https://bugs.webkit.org/show_bug.cgi?id=51217
3791
3792         * TestResultServer/model/jsonresults.py:
3793         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3794         Adds missing documentation.