e5c64db79e19e32a0091db4bbb4b9080c2c011fe
[WebKit.git] / Tools / ChangeLog
1 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Anders Carlsson.
4
5         Use designated temp directory for the database for WebKit2
6         https://bugs.webkit.org/show_bug.cgi?id=53052
7         
8         Adopt the new WK2 API for this.
9
10         * WebKitTestRunner/TestController.cpp:
11         (WTR::TestController::libraryPathForTesting):
12         (WTR::TestController::initialize):
13         * WebKitTestRunner/TestController.h:
14         * WebKitTestRunner/mac/TestControllerMac.mm:
15         (WTR::TestController::platformLibraryPathForTesting):
16         * WebKitTestRunner/qt/TestControllerQt.cpp:
17         (WTR::TestController::platformLibraryPathForTesting):
18         * WebKitTestRunner/win/TestControllerWin.cpp:
19         (WTR::TestController::platformLibraryPathForTesting):
20
21 2011-01-24  Lucas Forschler  <lforschler@apple.com>
22
23         Reviewed by Stephanie Lewis.
24
25         Add a new Leopard test bot.
26
27         * BuildSlaveSupport/build.webkit.org-config/config.json:
28
29 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
30
31         Reviewed by Adam Barth.
32
33         Add EFL Builder to core waterfall
34         https://bugs.webkit.org/show_bug.cgi?id=52704
35
36         Add EFL Builder to the core waterfall again.
37
38         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
39         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
40
41 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
42
43         Reviewed by Tony Chang.
44
45         new-run-webkit-tests fails to start HTTP server if there are proxy settings
46         https://bugs.webkit.org/show_bug.cgi?id=52872
47
48         Force disabling proxy to resolve the problem.
49
50         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
51         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
52
53 2011-01-24  Andreas Kling  <kling@webkit.org>
54
55         Reviewed by Darin Adler.
56
57         check-webkit-style: Update exemptions following Source/ move.
58         https://bugs.webkit.org/show_bug.cgi?id=53017
59
60         * Scripts/webkitpy/style/checker.py:
61         * Scripts/webkitpy/style/checker_unittest.py:
62
63 2011-01-24  Andras Becsi  <abecsi@webkit.org>
64
65         Rubber-stamped by Csaba Osztrogonác.
66
67         [Qt] Move project files into Source
68         https://bugs.webkit.org/show_bug.cgi?id=52891
69
70         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
71
72 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
73
74         Reviewed by Yury Semikhatsky.
75
76         Web Inspector: Find duplicate strings in localizedStrings.js
77
78         https://bugs.webkit.org/show_bug.cgi?id=53005
79
80         * Scripts/check-inspector-strings:
81
82 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
83
84         Reviewed by Andreas Kling.
85
86         [Qt] Regroup MiniBrowser's menubar and add open file action
87         https://bugs.webkit.org/show_bug.cgi?id=53000
88
89         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
90
91         * MiniBrowser/qt/BrowserWindow.cpp:
92         (BrowserWindow::BrowserWindow):
93         (BrowserWindow::openFile):
94         (BrowserWindow::~BrowserWindow):
95         * MiniBrowser/qt/BrowserWindow.h:
96
97 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
98
99         Unreviewed fix after r76496
100
101         [Qt] Move project files into Source
102         https://bugs.webkit.org/show_bug.cgi?id=52891
103
104         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
105         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
106         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
107
108 2011-01-24  Andras Becsi  <abecsi@webkit.org>
109
110         Reviewed by Csaba Osztrogonác.
111
112         [Qt] Move project files into Source
113         https://bugs.webkit.org/show_bug.cgi?id=52891
114
115         * DerivedSources.pro: Renamed from DerivedSources.pro.
116         * DumpRenderTree/qt/DumpRenderTree.pro:
117         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
118         * MiniBrowser/DerivedSources.pro:
119         * MiniBrowser/qt/MiniBrowser.pro:
120         * QtTestBrowser/QtTestBrowser.pro:
121         * Scripts/webkitdirs.pm:
122         * Tools.pro: Added.
123         * WebKitTestRunner/DerivedSources.pro:
124         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
125         * WebKitTestRunner/qt/WebKitTestRunner.pro:
126
127 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
128
129         Reviewed by Dan Bernstein.
130
131         Beefed up --threaded mode to catch even more kinds of errors.
132         https://bugs.webkit.org/show_bug.cgi?id=52971
133
134         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
135         context group to force JSC to mark multiple threads. (This used to be
136         the default, but it changed in SnowLeopard.)
137         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
138         to give threading mistakes more chances to show themselves.
139         (startJavaScriptThreads):
140         (stopJavaScriptThreads):
141
142 2011-01-22  Robert Hogan  <robert@webkit.org>
143
144         Reviewed by Andreas Kling.
145
146         [Qt] Support layoutTestController.addURLToRedirect()
147         https://bugs.webkit.org/show_bug.cgi?id=52956
148
149         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
150         (LayoutTestController::addURLToRedirect):
151         * DumpRenderTree/qt/LayoutTestControllerQt.h:
152
153 2011-01-22  Robert Hogan  <robert@webkit.org>
154
155         Reviewed by Kenneth Rohde Christiansen.
156
157         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
158         https://bugs.webkit.org/show_bug.cgi?id=49802
159
160         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
161         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
162         (WebCore::DumpRenderTree::open):
163
164 2011-01-21  Adam Barth  <abarth@webkit.org>
165
166         Reviewed by Maciej Stachowiak.
167
168         Disable mac_unittest.py that fails on some of the Mac bots
169         https://bugs.webkit.org/show_bug.cgi?id=52947
170
171         As noted in the comment, this test does not appear to be correct
172         because the function this test is testing returns different results
173         depending on which flavor of Mac the test is run on.  This patch
174         disable the test.  Hopefully we can re-enable the test once we've
175         probably insulated the test from its environment.
176
177         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
178
179 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
180
181         Reviewed by Mihai Parparita.
182
183         Fix bug introduced in r76322 that caused NRWT to not actually
184         read the Skipped files properly.
185
186         https://bugs.webkit.org/show_bug.cgi?id=52771
187
188         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
189         * Scripts/webkitpy/layout_tests/port/webkit.py:
190         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
191
192 2011-01-21  Sam Weinig  <sam@webkit.org>
193
194         Reviewed by Geoffrey Sean Garen and Mark Rowe.
195
196         WebKitTestRunner needs the HOME environment variable to be set.
197         <rdar://problem/8896573>
198
199         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
200         it exists.
201
202 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
203
204         Reviewed by Eric Seidel.
205
206         Suppress a few remaining integration tests so that none of the
207         layout_test unit tests ever read from the filesystem or launch
208         subprocesses that aren't part of the unit tests.
209
210         Also fix a minor bug in the printing unit tests that was
211         incorrectly relying on sys.argv.
212
213         https://bugs.webkit.org/show_bug.cgi?id=52863
214
215         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
216         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
217         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
218
219 2011-01-21  Darin Adler  <darin@apple.com>
220
221        Fix Mac build.
222
223         * MiniBrowser/mac/BrowserWindowController.m:
224         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
225
226 2011-01-20  Darin Adler  <darin@apple.com>
227
228         Reviewed by Dan Bernstein.
229
230         WebKit2: Implement showModalDialog
231         https://bugs.webkit.org/show_bug.cgi?id=52855
232
233         This fixes WebKitTestRunner to compile, but more work is probably
234         needed to get it to pass the tests.
235
236         * WebKitTestRunner/TestController.cpp:
237         (WTR::TestController::runModal): Added. Calls through to the
238         platform-specific version of runModal.
239         (WTR::TestController::createOtherPage): Changed to be a private
240         static member function so it can refer to runModal, which is
241         a private static member function.
242         (WTR::TestController::initialize): Pass 0 for the runModal
243         function since we don't need to run the main window modal.
244         I suspect this is wrong and will need to change.
245         * WebKitTestRunner/TestController.h: Added declarations for
246         the functions added above.
247         * WebKitTestRunner/mac/TestControllerMac.mm:
248         (WTR::TestController::runModal): Added. Untested implementation.
249         * WebKitTestRunner/qt/TestControllerQt.cpp:
250         (WTR::TestController::runModal): Added.
251         * WebKitTestRunner/win/TestControllerWin.cpp:
252         (WTR::TestController::runModal): Added.
253
254 2011-01-21  Eric Seidel  <eric@webkit.org>
255
256         Reviewed by Adam Barth.
257
258         Split Host object off from WebKitPatch for easier re-use
259         https://bugs.webkit.org/show_bug.cgi?id=52284
260
261         new-run-webkit-tests and other tools are eventually going to want one of these.
262         Basically you need to inherit from this class if you want to pretend to be a
263         self.tool object for Steps/Commands.
264
265         * Scripts/webkitpy/common/host.py: Added.
266         * Scripts/webkitpy/tool/main.py:
267
268 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
269
270         Reviewed by Adam Barth.
271
272         Disable the tests that start and stop the http server and web
273         server, so that we don't have to worry about port collisions on
274         the bots.
275
276         https://bugs.webkit.org/show_bug.cgi?id=52861
277
278         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
279
280 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
281
282         Reviewed by Eric Seidel.
283
284         nrwt: rewrite google_chrome_unittest to use mock filesystem.
285         
286         https://bugs.webkit.org/show_bug.cgi?id=52772
287         
288         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
289
290 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
291
292         Reviewed by Eric Siedel.
293
294         nrwt: clean up almost all remaining port references, remove
295         unnecessary import clauses. The only remaining references are
296         in places where a mock filesystem makes no sense or can't be
297         used, and in one routine in port/google_chrome_unittest that
298         I'll rewrite in a separate patch.
299
300         https://bugs.webkit.org/show_bug.cgi?id=52771
301
302         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
303         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
304         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
305         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
306         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
307         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
308         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
309         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
310         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
311         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
312         * Scripts/webkitpy/layout_tests/port/gtk.py:
313         * Scripts/webkitpy/layout_tests/port/mac.py:
314         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
315         * Scripts/webkitpy/layout_tests/port/qt.py:
316         * Scripts/webkitpy/layout_tests/port/webkit.py:
317         * Scripts/webkitpy/layout_tests/port/win.py:
318         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
319
320 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
321
322         Reviewed by Mihai Parparita.
323
324         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
325
326         https://bugs.webkit.org/show_bug.cgi?id=52762
327
328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
329         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
330
331 2011-01-20  Tony Chang  <tony@chromium.org>
332
333         Reviewed by Ojan Vafai.
334
335         [chromium] fix the paths used for the rebaseline tool
336         https://bugs.webkit.org/show_bug.cgi?id=52857
337
338         Some of the bots were renamed so the path to grab the results zip
339         file has changed.
340
341         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
342
343 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
344
345         Reviewed by Tony Chang.
346
347         Fix bug introduced in r72688 / bug 52768 that broke the
348         generation of the output filename links in the results.html
349         output. Apparently none of the unit tests actually checked to
350         make sure the generated links were correct :(
351
352         https://bugs.webkit.org/show_bug.cgi?id=52854
353
354         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
355         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
356
357 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
358
359         Reviewed by Darin Adler.
360
361         https://bugs.webkit.org/show_bug.cgi?id=52849
362         Make window.print work with WebKit2
363
364         * MiniBrowser/mac/BrowserWindowController.m:
365         (-[BrowserWindowController awakeFromNib]):
366         * WebKitTestRunner/TestController.cpp:
367         (WTR::createOtherPage):
368         (WTR::TestController::initialize):
369         Added zeroes to WKPageUIClient structures to avoid build failures.
370
371 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
372
373         Reviewed by Eric Seidel.
374
375         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
376
377         https://bugs.webkit.org/show_bug.cgi?id=52756
378
379         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
380         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
381         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
382         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
383         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
384         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
385
386 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
387
388         Reviewed by Antonio Gomes.
389
390         QtTestBrowser should have a seperate menu for Settings
391         https://bugs.webkit.org/show_bug.cgi?id=52817
392         
393         Added a new menu item named "Settings"
394         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
395
396         * QtTestBrowser/launcherwindow.cpp:
397         (LauncherWindow::createChrome):
398
399 2011-01-20  Sam Weinig  <sam@webkit.org>
400
401         Reviewed by John Sullivan.
402
403         Update update-webkit-localizable-strings with new path to WebKit.
404
405         * Scripts/update-webkit-localizable-strings:
406
407 2011-01-20  James Robinson  <jamesr@chromium.org>
408
409         Reviewed by Darin Fisher.
410
411         Implement mozilla's requestAnimationFrame API
412         https://bugs.webkit.org/show_bug.cgi?id=51218
413
414         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
415
416         * DumpRenderTree/chromium/WebViewHost.cpp:
417         (invokeScheduleComposite):
418         (WebViewHost::scheduleAnimation):
419         (WebViewHost::paintInvalidatedRegion):
420         * DumpRenderTree/chromium/WebViewHost.h:
421
422 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
423
424         Reviewed by Adam Roben.
425
426         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
427         https://bugs.webkit.org/show_bug.cgi?id=42327
428
429         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
430         for methods that take their normal arguments but also a JSContextRef.
431         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
432         for evaluateScriptInIsolatedWorld.
433         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
434         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
435         this call is for an isolated world.
436         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
437         (WTR::worldMap): Helper to create a world map.
438         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
439         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
440         added LayoutTestController API.
441         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
442
443 2011-01-19  Adam Roben  <aroben@apple.com>
444
445         Convert paths in environment variables back to msys-style inside commit-log-editor
446
447         When this script gets run from inside git commit, msys-style paths in the environment will
448         have been turned into Windows-style paths with forward slashes. This screws up functions
449         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
450         the paths back to msys-style before doing anything else.
451
452         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
453         using msysgit's Perl and multiple ChangeLogs have been edited
454
455         Reviewed by David Kilzer.
456
457         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
458         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
459         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
460
461 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
462
463         [Win] Unreviewed build fix after r76248.
464
465         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
466
467 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
468
469         Reviewed by Csaba Osztrogonác.
470
471         Refactoring of the custom allocation framework
472         https://bugs.webkit.org/show_bug.cgi?id=49897
473
474         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
475         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
476         equivalent macro implementation at the necessary places.
477 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
478
479         Unreviewed. 
480
481         Adding myself to committers.py.
482
483         * Scripts/webkitpy/common/config/committers.py:
484
485 2011-01-20  Adam Barth  <abarth@webkit.org>
486
487         Reviewed by Tony Chang.
488
489         Chromium builders don't delete unversioned directories when DEPS change
490         https://bugs.webkit.org/show_bug.cgi?id=52745
491
492         If we pass this option to gclient sync, gclient will delete directories
493         that are no longer part of DEPS instead of leaving them around to
494         confuse us later.  Apparently, the downstream buildbots use this option
495         already.
496
497         * Scripts/update-webkit-chromium:
498
499 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
500
501         Unreviewed, build fix - I pulled this patch in to fix an issue
502         revealed by r76195 running on some new bots). Also fix a couple
503         of other issues revealed in testing.
504
505         nrwt: remove fs refs from layout_package/json*
506
507         https://bugs.webkit.org/show_bug.cgi?id=52754
508
509         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
510         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
511         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
512         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
513         * Scripts/webkitpy/layout_tests/port/base.py:
514
515 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
516
517         Unreviewed, build fix.
518
519         Fix a couple of minor bugs discovered while bringing up new bots
520         for testing.
521
522         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
523         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
524
525 2011-01-19  James Robinson  <jamesr@chromium.org>
526
527         Unreviewed, rolling out r76194.
528         http://trac.webkit.org/changeset/76194
529         https://bugs.webkit.org/show_bug.cgi?id=51218
530
531         Caused mysterious compile failure on the chromium win
532         build.webkit.org bots
533
534         * DumpRenderTree/chromium/WebViewHost.cpp:
535         (WebViewHost::paintInvalidatedRegion):
536         * DumpRenderTree/chromium/WebViewHost.h:
537
538 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
539
540         Reviewed by Mihai Parparita.
541
542         remove fs refs from test_runner, dump_render_tree_thread
543
544         https://bugs.webkit.org/show_bug.cgi?id=52753
545
546         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
547         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
548         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
549         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
550
551 2011-01-19  James Robinson  <jamesr@chromium.org>
552
553         Reviewed by Darin Fisher.
554
555         Implement mozilla's requestAnimationFrame API
556         https://bugs.webkit.org/show_bug.cgi?id=51218
557
558         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
559
560         * DumpRenderTree/chromium/WebViewHost.cpp:
561         (invokeScheduleComposite):
562         (WebViewHost::scheduleAnimation):
563         (WebViewHost::paintInvalidatedRegion):
564         * DumpRenderTree/chromium/WebViewHost.h:
565
566 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
567
568         Unreviewed, build fix.
569
570         Fix a few incorrect "self._filesystem" references introduced in
571         r76184.
572
573         * Scripts/webkitpy/layout_tests/port/chromium.py:
574         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
575
576 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
577
578         Reviewed by Mihai Parparita.
579
580         add a .sep property, abspath(), isabs(), mtime(), and
581         open_text_file_for_writing() to filesystem modules. Some of
582         these properties are not needed in this patch but will be needed
583         in subsequent patches (I'm doing this to avoid having to track
584         multiple versions of a single file).
585
586         Also, change most of the port/* modules to use the filesystem
587         objects instead of referencing the filesystem directly.
588
589         https://bugs.webkit.org/show_bug.cgi?id=52748
590
591         * Scripts/webkitpy/common/system/filesystem.py:
592         * Scripts/webkitpy/common/system/filesystem_mock.py:
593         * Scripts/webkitpy/layout_tests/port/__init__.py:
594         * Scripts/webkitpy/layout_tests/port/base.py:
595         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
596         * Scripts/webkitpy/layout_tests/port/chromium.py:
597         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
598         * Scripts/webkitpy/layout_tests/port/config.py:
599         * Scripts/webkitpy/layout_tests/port/test.py:
600         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
601
602 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
603
604         Reviewed by Anders Carlsson.
605
606         If resetting between tests times out, treat it as a WebProcess crash
607         https://bugs.webkit.org/show_bug.cgi?id=52757
608
609         * WebKitTestRunner/TestController.cpp:
610         (WTR::TestController::runTest):
611
612 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
613
614         Reviewed by Darin Adler.
615
616         https://bugs.webkit.org/show_bug.cgi?id=52739
617         Make it possible for a WebKit2 client to print headers and footers
618
619         Added dummy implementations for new printing UIClient calls.
620
621         * MiniBrowser/mac/BrowserWindowController.m:
622         (-[BrowserWindowController awakeFromNib]):
623         * WebKitTestRunner/TestController.cpp:
624         (WTR::createOtherPage):
625         (WTR::TestController::initialize):
626
627 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
628
629         Reviewed by Ojan Vafai.
630
631         Change webkitpy/layout_tests/port/test.py to use the
632         in-memory filesystem for cleaner unit testing. This
633         change allows us to kill a lot of code that was
634         specific to the test port, at the cost of being a
635         little less clear about how things would work if
636         you didn't have a filesystem.
637
638         https://bugs.webkit.org/show_bug.cgi?id=52605
639
640         * Scripts/webkitpy/layout_tests/port/test.py:
641
642 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
643
644         Unreviewed, build fix.
645
646         Fix test failure caused by committing attachment 79368 instead
647         of attachment 79461 on bug 52604.
648
649         * Scripts/webkitpy/common/system/filesystem_mock.py:
650
651 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
652
653         Reviewed by Mihai Parparita.
654
655         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
656         unit testing. os.walk() is too much of a hassle to implement on
657         top of the in-memory mock filesystem and adding the necessary
658         interface to files_under() gives clients a cleaner API anyway
659         (for this particular usage model).
660
661         https://bugs.webkit.org/show_bug.cgi?id=52691
662
663         * Scripts/webkitpy/common/system/filesystem.py:
664         * Scripts/webkitpy/common/system/filesystem_mock.py:
665         * Scripts/webkitpy/layout_tests/port/test_files.py:
666         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
667
668 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
669
670         Reviewed by Tony Chang.
671
672         Change more modules in the layout-tests code to use the
673         filesystem wrapper for cleaner unit testing.
674
675         This patch also adds the glob() wrapper to the filesystem
676         abstraction.
677         
678         https://bugs.webkit.org/show_bug.cgi?id=52604
679
680         * Scripts/webkitpy/layout_tests/port/test_files.py:
681         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
682         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
683         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
684         * Scripts/webkitpy/common/system/filesystem.py:
685         * Scripts/webkitpy/common/system/filesystem_mock.py:
686
687 2011-01-19  Levi Weintraub  <leviw@chromium.org>
688
689         Unreviewed.
690
691         Updating my email addresses and irc nick.
692
693         * Scripts/webkitpy/common/config/committers.py:
694
695 2011-01-19  Tony Chang  <tony@chromium.org>
696
697         Reviewed by Mihai Parparita.
698
699         [chromium] [linux] if check-sys-deps fails, output the failure reason
700         https://bugs.webkit.org/show_bug.cgi?id=52671
701
702         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
703             error handler functions.
704         * Scripts/webkitpy/layout_tests/port/chromium.py:
705             output the error text from --check-sys-deps
706         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
707
708 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
709
710         Reviewed by Andreas Kling.
711
712         [Qt] QtTestBrowser crashes when closing if Facebook is opened
713         https://bugs.webkit.org/show_bug.cgi?id=52554
714         
715         QtNetworkAccessManager is created in a thread and set as
716         member variable in QWebPage. When the thread is destroyed
717         the object is still used. So fix will set the object to
718         NULL once the thread is destroyed.
719
720         * QtTestBrowser/launcherwindow.cpp:
721         (LauncherWindow::~LauncherWindow):
722
723 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
724
725         Rubber stamped by Csaba Osztrogonac
726
727         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
728
729 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
730
731         Reviewed by Tony Chang.
732
733         new-run-webkit-tests: add a --build-directory command line argument
734
735         Official Google Chrome builds use a non-standard build directory
736         location. This patch adds a --build-directory argument that
737         allows that location to be specified on the command line. Only
738         Chromium-based builds will use this flag for now, but anyone can
739         in the future.
740
741         There are no unit tests for this since it's difficult to test
742         until mock filesystems are fully supported in the code. This was
743         tested by hand for now.
744
745         https://bugs.webkit.org/show_bug.cgi?id=52694
746
747         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
748         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
749         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
751
752 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
753
754         Not reviewed. Bot fix.
755
756         Remove an inadvertently committed debugging print.
757
758         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
759         (LayoutTestController::notifyDone):
760
761 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
762
763         Reviewed by Sam Weinig.
764
765         WebKitTestRunner should track loading more like DumpRenderTree
766         https://bugs.webkit.org/show_bug.cgi?id=52692
767
768         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
769         This makes some tests that call notifyDone multiple times pass.
770         
771         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
772         (WTR::InjectedBundle::InjectedBundle):
773         (WTR::InjectedBundle::done):
774         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
775         (WTR::InjectedBundle::topLoadingFrame):
776         (WTR::InjectedBundle::setTopLoadingFrame):
777         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
778         (WTR::InjectedBundlePage::InjectedBundlePage):
779         (WTR::InjectedBundlePage::stopLoading):
780         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
781         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
782         (WTR::InjectedBundlePage::didFinishLoadForFrame):
783         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
784         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
785         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
786         (WTR::LayoutTestController::notifyDone):
787         * WebKitTestRunner/TestController.cpp:
788         (WTR::TestController::didReceiveMessageFromInjectedBundle):
789
790 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
791
792         Reviewed by Kent Tamura.
793
794         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
795         https://bugs.webkit.org/show_bug.cgi?id=52678
796         
797         Update path now that WebKit is inside Source.
798
799         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
800
801 2011-01-18  Robert Hogan  <robert@webkit.org>
802
803         Reviewed by Simon Hausmann.
804
805         [Qt] http/tests/incremental/slow-utf8-text.pl fails
806         https://bugs.webkit.org/show_bug.cgi?id=44282
807
808         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
809         (WebCore::DumpRenderTree::dump):
810
811 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
812
813         Reviewed by Mihai Parparita.
814
815         Fix a small race condition that could cause the unit tests for
816         new-run-webkit-tests to fail in a multithreaded environment.
817         There was a small window in the code where one thread would
818         check to see if a thread had raised an exception, do something,
819         and then check to see if the thread was alive. If the other
820         thread raised an exception and exited in between these two
821         steps, the exception would be lost. Flipping the order of the
822         two checks fixes the race, since we will now always check for an
823         exception on the thread before exiting.
824
825         https://bugs.webkit.org/show_bug.cgi?id=51579
826
827         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
828
829 2011-01-18  Eric Seidel  <eric@webkit.org>
830
831         Reviewed by Adam Barth.
832
833         commit-queue dies when test archiving fails
834         https://bugs.webkit.org/show_bug.cgi?id=52617
835
836         I looked at the machine and it had 10 archives already
837         thus find_unused_name was returning None.  I've upped
838         the limit to 100 (per bug) and tested the case where
839         find_unused_name returns None (making archive return None).
840
841         * Scripts/webkitpy/common/system/workspace.py:
842         * Scripts/webkitpy/common/system/workspace_unittest.py:
843         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
844         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
845         * Scripts/webkitpy/tool/commands/queues.py:
846
847 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
848
849         Reviewed by Ojan Vafai.
850
851         Update rebaseline-chromium-webkit-tests unit tests to use a mock
852         filesystem. Also fix a couple of "with" statements missed by
853         r76050.
854
855         https://bugs.webkit.org/show_bug.cgi?id=52487
856
857         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
858
859 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
860
861         Reviewed by Martin Robinson.
862
863         [Gtk] Build fixes for gtk3 build
864         https://bugs.webkit.org/show_bug.cgi?id=52648
865
866         * DumpRenderTree/gtk/EventSender.cpp:
867         (beginDragWithFilesCallback):
868
869 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
870
871         Reviewed by Mihai Parparita.
872
873         Update rebaseline-chromium-webkit-tests to use filesystem objects
874         instead of direct references to os.path, shutil, tempfile, etc.
875
876         This patch doesn't change anything, but will allow subsequent
877         patches to change the unit tests to no longer use the real
878         filesystem.
879
880         This patch adds a bunch more methods to the filesystem object as
881         well.
882
883         https://bugs.webkit.org/show_bug.cgi?id=52482
884
885         * Scripts/webkitpy/common/system/filesystem.py:
886         * Scripts/webkitpy/common/system/filesystem_mock.py:
887         * Scripts/webkitpy/tool/commands/queues.py:
888         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
889         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
890
891 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
892
893         Reviewed by Mihai Parparita.
894
895         new-run-webkit-tests shouldn't crash when you try to run a
896         directory containing only skipped files.
897
898         https://bugs.webkit.org/show_bug.cgi?id=52478
899         
900         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
901         * Scripts/webkitpy/layout_tests/port/test.py:
902         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
903
904 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
905
906         Reviewed by Gustavo Noronha Silva.
907
908         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
909         https://bugs.webkit.org/show_bug.cgi?id=40833
910
911         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
912         GTK+ event sender.
913         (dragWithFilesDragDataGetCallback): Added.
914         (dragWithFilesDragEndCallback): Added.
915         (beginDragWithFilesCallback): Added.
916
917 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
918
919         Reviewed by Adam Barth.
920
921         ews: Add additional watcher to efl ews
922         https://bugs.webkit.org/show_bug.cgi?id=52613
923
924         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
925
926         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
927
928 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
929
930         Reviewed by Alexey Proskuryakov.
931
932         Fix some headers with missing or misspelled #ifndef guards
933         https://bugs.webkit.org/show_bug.cgi?id=52545
934
935         * DumpRenderTree/chromium/TestEventPrinter.h:
936         * DumpRenderTree/chromium/WebPreferences.h:
937
938 2011-01-17  Jessie Berlin  <jberlin@apple.com>
939
940         Reviewed by Anders Carlsson.
941
942         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
943         navigating back to an unreachable URL
944         https://bugs.webkit.org/show_bug.cgi?id=52388
945
946         Add a third parameter (unreachableURL) to queueLoadHTMLString.
947
948         * DumpRenderTree/LayoutTestController.cpp:
949         (queueLoadHTMLStringCallback):
950         (LayoutTestController::queueLoadHTMLString):
951         (LayoutTestController::queueLoadAlternateHTMLString):
952         * DumpRenderTree/LayoutTestController.h:
953
954         * DumpRenderTree/WorkQueueItem.h:
955         (LoadHTMLStringItem::LoadHTMLStringItem):
956
957         * DumpRenderTree/chromium/LayoutTestController.cpp:
958         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
959         (WorkItemLoadHTMLString::run):
960         (LayoutTestController::queueLoadHTMLString):
961
962         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
963         (LoadHTMLStringItem::invoke):
964         * DumpRenderTree/mac/WorkQueueItemMac.mm:
965         (LoadHTMLStringItem::invoke):
966         * DumpRenderTree/win/WorkQueueItemWin.cpp:
967         (LoadHTMLStringItem::invoke):
968
969 2011-01-17  Dan Bernstein  <mitz@apple.com>
970
971         Rubber-stamped by Mark Rowe.
972
973         Update xcodeproj svn:ignore to include xcuserdata.
974
975         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
976         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
977         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
978         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
979         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
980
981 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
982
983         Unreviewed fix after r75908.
984
985         Move WebKit into Source
986         https://bugs.webkit.org/show_bug.cgi?id=52530
987
988         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
989
990 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
991
992         Unreviewed.
993
994         Remove accidentally committed debug printing after r75908.
995
996         * Scripts/webkitdirs.pm:
997
998 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
999
1000         Unreviewed.
1001
1002         Add myself to committers list
1003         https://bugs.webkit.org/show_bug.cgi?id=52566
1004
1005         * Scripts/webkitpy/common/config/committers.py:
1006
1007 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1008
1009         Reviewed by Jeremy Orlow.
1010
1011         GeolocationController should call stopUpdating on destruction
1012         https://bugs.webkit.org/show_bug.cgi?id=52216
1013
1014         fast/dom/Geolocation/window-close-crash.html requires that a
1015         Geolocation watch be started in a secondary window. Consequently,
1016         we need to allow geolocation permission and provide a mock
1017         geolocation position for the secondary window's
1018         GeolocationClientMock.
1019
1020         * DumpRenderTree/chromium/LayoutTestController.cpp:
1021         (LayoutTestController::setGeolocationPermission):
1022         (LayoutTestController::setMockGeolocationPosition):
1023         (LayoutTestController::setMockGeolocationError):
1024         * DumpRenderTree/chromium/TestShell.h:
1025         (TestShell::windowList):
1026
1027 2011-01-16  Adam Barth  <abarth@webkit.org>
1028
1029         Update more include paths to reflect WebKit move.
1030
1031         * DumpRenderTree/chromium/EventSender.cpp:
1032         (EventSender::keyDown):
1033         (EventSender::needsShiftModifier):
1034         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1035         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1036
1037 2011-01-16  Kent Tamura  <tkent@chromium.org>
1038
1039         Unreviewed, Chromium build fix.
1040
1041         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1042
1043 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1044
1045         Build fix for GTK+ after source directory movement.
1046
1047         * GNUmakefile.am: Correct include paths.
1048
1049 2011-01-16  Adam Barth  <abarth@webkit.org>
1050
1051         Teach svn-apply about WebKit move.
1052
1053         * Scripts/VCSUtils.pm:
1054
1055 2011-01-16  Adam Barth  <abarth@webkit.org>
1056
1057         Rubber-stamped by Eric Seidel.
1058
1059         Move WebKit into Source
1060         https://bugs.webkit.org/show_bug.cgi?id=52530
1061
1062         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1063         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1064         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1065         * DumpRenderTree/qt/GCControllerQt.cpp:
1066         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1067         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1068         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1069         * DumpRenderTree/wscript:
1070         * QtTestBrowser/launcherwindow.h:
1071         * Scripts/build-webkit:
1072         * Scripts/webkitdirs.pm:
1073
1074 2011-01-15  Adam Barth  <abarth@webkit.org>
1075
1076         Teach svn-apply about WebKit2 move.
1077
1078         * Scripts/VCSUtils.pm:
1079
1080 2011-01-15  Adam Barth  <abarth@webkit.org>
1081
1082         Rubber-stamped by Eric Seidel.
1083
1084         Move WebKit2 into Source
1085         https://bugs.webkit.org/show_bug.cgi?id=52438
1086
1087         * MiniBrowser/qt/MiniBrowser.pro:
1088         * Scripts/build-webkit:
1089         * Scripts/do-file-rename:
1090         * Scripts/do-webcore-rename:
1091         * Scripts/test-webkitpy:
1092         * Scripts/webkitdirs.pm:
1093         * Scripts/webkitpy/style/checker.py:
1094         * WebKitTestRunner/DerivedSources.pro:
1095         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1096         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1097
1098 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1099
1100         Reviewed by David Levin.
1101
1102         [chromium] remove obsolete createView method
1103         https://bugs.webkit.org/show_bug.cgi?id=52437
1104
1105         * DumpRenderTree/chromium/WebViewHost.cpp:
1106         (WebViewHost::createView):
1107         * DumpRenderTree/chromium/WebViewHost.h:
1108
1109 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1110
1111         Reviewed by Geoff Garen.
1112
1113         ShouldLoadResourceForFrame should use strings, not URLs.
1114         https://bugs.webkit.org/show_bug.cgi?id=52476
1115
1116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1117         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1118         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1119
1120 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1121
1122         Reviewed by David Levin.
1123
1124         Add Tony Gentilcore as a reviewer
1125         https://bugs.webkit.org/show_bug.cgi?id=52480
1126
1127         * Scripts/webkitpy/common/config/committers.py:
1128
1129 2011-01-14  David Levin  <levin@chromium.org>
1130
1131         Reviewed by Eric Seidel.
1132
1133         check-webkit-style: _FunctionState should keep track of where the function name starts.
1134         https://bugs.webkit.org/show_bug.cgi?id=52454
1135
1136         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1137         _FunctionState and logic for setting it correctly.
1138         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1139
1140 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1141
1142         Reviewed by David Levin.
1143
1144         Add support to DumpRenderTree to use the GPU rather than software renderer
1145         https://bugs.webkit.org/show_bug.cgi?id=52333
1146
1147         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1148         (main):
1149         * Scripts/webkitpy/layout_tests/port/chromium.py:
1150         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1151
1152 2011-01-14  Tony Chang  <tony@chromium.org>
1153
1154         Reviewed by Kent Tamura.
1155
1156         [chromium] update fonts.conf to fix 6 linux tests in drt
1157         https://bugs.webkit.org/show_bug.cgi?id=52411
1158
1159         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1160             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1161
1162 2011-01-14  Eric Seidel  <eric@webkit.org>
1163
1164         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1165
1166         Reviewed by Adam Barth.
1167
1168         Fix when running Tools/Scripts/check-webkit-style without arguments.
1169         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1170
1171         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1172         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1173
1174 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1175
1176         Reviewed by David Levin.
1177
1178         Store the tempdir object in a variable so it doesn't get deleted too early.
1179         https://bugs.webkit.org/show_bug.cgi?id=51875
1180
1181         * Scripts/update-webkit-auxiliary-libs:
1182         * Scripts/update-webkit-support-libs:
1183
1184 2011-01-14  Eric Seidel  <eric@webkit.org>
1185
1186         Unreviewed.  Make it work in python 2.5.
1187
1188         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1189         https://bugs.webkit.org/show_bug.cgi?id=49158
1190
1191         * Scripts/webkitpy/common/checkout/api_unittest.py:
1192
1193 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1194
1195         Unreviewed, rolling out r75774.
1196         http://trac.webkit.org/changeset/75774
1197         https://bugs.webkit.org/show_bug.cgi?id=52431
1198
1199         gtk builds were broken (Requested by loislo2 on #webkit).
1200
1201         * Scripts/webkitpy/common/checkout/scm.py:
1202
1203 2011-01-14  David Levin  <levin@chromium.org>
1204
1205         Reviewed by Shinichiro Hamaji.
1206
1207         check-webkit-style: _FunctionState should detect pure functions.
1208         https://bugs.webkit.org/show_bug.cgi?id=52428
1209
1210         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1211         is a pure virtual function.
1212         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1213         virtual functions are correctly detected.
1214
1215 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1216
1217         Reviewed by Yury Semikhatsky.
1218
1219         Just small fix for problem with check-webkit-style.
1220         It just didn't work for this patch.
1221         Old code can't concatenate a list of strings with None.
1222
1223         * Scripts/webkitpy/common/checkout/scm.py:
1224
1225 2011-01-13  David Levin  <levin@chromium.org>
1226
1227         Reviewed by Shinichiro Hamaji.
1228
1229         check-webkit-style: _FunctionState should use Position to know where items are.
1230         https://bugs.webkit.org/show_bug.cgi?id=52424
1231
1232         * Scripts/webkitpy/style/checkers/cpp.py:
1233         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1234         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1235         did some minor clean-up.
1236         (*): Other changes are simply about converting to use the Position's in_FunctionState
1237         instead of line numbers.
1238         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1239         to verify the positions stored in _FunctionState.
1240
1241 2011-01-13  Eric Seidel  <eric@webkit.org>
1242
1243         Reviewed by David Levin.
1244
1245         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1246         https://bugs.webkit.org/show_bug.cgi?id=49158
1247
1248         This is not the most elegant, but it is a very safe fix to this bug.
1249         One advantage of catching ScriptError like this instead of adding a
1250         new added_or_modified_files or fixing all changed_files callers
1251         to use a more specific change_files variant, is that we catch
1252         all kinds of ScriptErrors which might cause our (non-essential)
1253         suggest-reviewers code to fail out.  This should make passing
1254         --suggest-reviewers to webkit-patch upload much more robust
1255         and may even make it possible for us to make it default.
1256
1257         The root of the problem here is that SCM.changed_files includes
1258         deleted ChangeLog paths (from moves, etc) which then when we ask
1259         SVN/Git for the contents of the file at that revision, the command
1260         errors out and Executive.run_command raises a ScriptError.
1261
1262         In the future we might fix this differently by making all current
1263         callers of chagned_files use a more specific method for requesting
1264         what types of changes they're interested in (adds, modifies, deletes, etc.)
1265
1266         * Scripts/webkitpy/common/checkout/api.py:
1267         * Scripts/webkitpy/common/checkout/api_unittest.py:
1268
1269 2011-01-13  Dan Bernstein  <mitz@apple.com>
1270
1271         Reviewed by Alexey Proskuryakov.
1272
1273         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1274         https://bugs.webkit.org/show_bug.cgi?id=52419
1275
1276         Allow to further control the behavior of the willSendRequest delegate callback by making it
1277         set a different URL in the new request.
1278
1279         * DumpRenderTree/LayoutTestController.cpp:
1280         (addURLToRedirectCallback): Added.
1281         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1282         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1283         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1284         * DumpRenderTree/LayoutTestController.h:
1285         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1286         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1287         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1288         change the URL in the new request to the redirect destination.
1289
1290 2011-01-13  Eric Seidel  <eric@webkit.org>
1291
1292         Reviewed by Mihai Parparita.
1293
1294         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1295         https://bugs.webkit.org/show_bug.cgi?id=52416
1296
1297         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1298         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1299
1300         I also added FIXMEs about the changed_files returning deleted files problem
1301         which is causing the other most common exception for suggest-reviewers
1302         (and is probably breaking sheriff-bots blame detection).
1303
1304         * Scripts/webkitpy/common/checkout/api.py:
1305         * Scripts/webkitpy/common/checkout/api_unittest.py:
1306         * Scripts/webkitpy/common/checkout/scm.py:
1307
1308 2011-01-13  Eric Seidel  <eric@webkit.org>
1309
1310         Reviewed by Adam Barth.
1311
1312         results archives from commit-queue are too large to upload
1313         https://bugs.webkit.org/show_bug.cgi?id=52405
1314
1315         * Scripts/webkitpy/common/system/filesystem.py:
1316         * Scripts/webkitpy/common/system/filesystem_mock.py:
1317         * Scripts/webkitpy/tool/commands/queues.py:
1318
1319 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1320
1321         Reviewed by Martin Robinson.
1322
1323         [gtk] Zero-sized font does not yet work
1324         https://bugs.webkit.org/show_bug.cgi?id=49793
1325
1326         Set minimum-font-size to 0 for the DRT.
1327
1328         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1329         (resetDefaultsToConsistentValues):
1330
1331 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1332
1333         Reviewed by Darin Adler.
1334
1335         Make old-run-webkit-tests more robust on buildbots
1336         https://bugs.webkit.org/show_bug.cgi?id=52364
1337
1338         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1339
1340 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1341
1342         Reviewed by Darin Adler.
1343
1344         Make old-run-webkit-tests more robust on buildbots
1345         https://bugs.webkit.org/show_bug.cgi?id=52364
1346
1347         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1348
1349 2011-01-13  Tony Chang  <tony@chromium.org>
1350
1351         Reviewed by Kent Tamura.
1352
1353         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1354         https://bugs.webkit.org/show_bug.cgi?id=52332
1355
1356         Forked Info.plist is not longer needed.
1357
1358         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1359
1360 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1361
1362         Reviewed by Timothy Hatcher.
1363
1364         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1365         to be passed directly to WebInspector.UIString
1366
1367         https://bugs.webkit.org/show_bug.cgi?id=52365
1368
1369         * Scripts/check-inspector-strings:
1370
1371 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1372
1373         Unreviewed, rolling out r74881.
1374         http://trac.webkit.org/changeset/74881
1375         https://bugs.webkit.org/show_bug.cgi?id=52357
1376
1377         The EFL builder has been red for days (Requested by abarth on
1378         #webkit).
1379
1380         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1381         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1382
1383 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1384
1385         Reviewed by David Levin.
1386
1387         Add beforeunload support to WebKitTestRunner
1388         https://bugs.webkit.org/show_bug.cgi?id=52353
1389         
1390         This makes a number of currently failing tests pass.
1391
1392         * WebKitTestRunner/TestController.cpp:
1393         (WTR::runBeforeUnloadConfirmPanel):
1394         (WTR::createOtherPage):
1395         (WTR::TestController::initialize):
1396
1397 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1398
1399         Reviewed by Sam Weinig.
1400
1401         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1402         https://bugs.webkit.org/show_bug.cgi?id=52330
1403
1404         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1405         a web process crash.
1406         * WebKitTestRunner/TestController.cpp:
1407         (WTR::TestController::initialize): Set up a processDidCrash
1408         callback.
1409         (WTR::TestController::processDidCrash): Report that the Web process
1410         crashed.
1411         * WebKitTestRunner/TestController.h:
1412
1413 2011-01-12  David Levin  <levin@chromium.org>
1414
1415         Reviewed by Shinichiro Hamaji.
1416
1417         check-webkit-style -- close_expression function doesn't work correctly.
1418         https://bugs.webkit.org/show_bug.cgi?id=52272
1419
1420         * Scripts/webkitpy/style/checkers/cpp.py:
1421         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1422         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1423         generally useful (for upcoming code changes).
1424         (close_expression): Changed to use Position for input and output.
1425         Also, fixed many bugs such as only working correctly for parenthesis,
1426         not working correctly if given an offset in a line and not finding
1427         the real closing element if there were multiple closing elements in
1428         the same line.
1429         (detect_functions): Adjusted due to the change in arguments for
1430         close_expression.
1431         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1432         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1433         two positions are the same.
1434         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1435         (CppStyleTest.test_close_expression): Added tests to catch the issues
1436         that were fixed.
1437
1438 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1439
1440         Unreviewed, rolling out r75576.
1441         http://trac.webkit.org/changeset/75576
1442         https://bugs.webkit.org/show_bug.cgi?id=52304
1443
1444         broke rebaseline-chromium-webkit-test (Requested by thakis on
1445         #webkit).
1446
1447         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1448         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1449         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1450         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1451         * Scripts/webkitpy/layout_tests/port/base.py:
1452         * Scripts/webkitpy/layout_tests/port/chromium.py:
1453         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1454         * Scripts/webkitpy/layout_tests/port/test.py:
1455         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1456         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1457         * Scripts/webkitpy/style/checkers/test_expectations.py:
1458         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1459
1460 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1461
1462         Reviewed by Darin Adler.
1463
1464         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1465         https://bugs.webkit.org/show_bug.cgi?id=52307
1466
1467         * Scripts/old-run-webkit-tests:
1468
1469 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1470
1471         Reviewed by Martin Robinson.
1472
1473         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1474         https://bugs.webkit.org/show_bug.cgi?id=50867
1475
1476         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1477         TestNetscapePlugin.cpp 
1478
1479         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1480         * Scripts/webkitdirs.pm:
1481
1482 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1483
1484         Reviewed by Pavel Feldman.
1485
1486         Add check-inspector-strings script.
1487
1488         https://bugs.webkit.org/show_bug.cgi?id=52295
1489
1490         * Scripts/check-inspector-strings: Added.
1491
1492 2011-01-12  Adam Roben  <aroben@apple.com>
1493
1494         Advertise the .testnetscape file extension on Windows
1495
1496         Fixes <http://webkit.org/b/52298>
1497         plugins/no-mime-with-valid-extension.html fails on Windows
1498
1499         Reviewed by Dan Bernstein.
1500
1501         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1502         FileExtents field to map the .testnetscape file extension to the
1503         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1504
1505 2011-01-12  Adam Barth  <abarth@webkit.org>
1506
1507         Reviewed by Eric Seidel.
1508
1509         Make webkit-patch support subdirectories for SVN checkouts
1510         https://bugs.webkit.org/show_bug.cgi?id=52261
1511
1512         os.relpath does not exist on Python 2.5, so we need to call our version
1513         of the API.
1514
1515         * Scripts/webkitpy/common/checkout/scm.py:
1516
1517 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1518
1519         Reviewed by Eric Seidel.
1520
1521         Close additional pages opened during a test once the test completes.
1522         https://bugs.webkit.org/show_bug.cgi?id=52276
1523
1524         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1525         (WTR::InjectedBundle::done):
1526
1527 2011-01-11  David Levin  <levin@chromium.org>
1528
1529         Reviewed by Eric Seidel.
1530
1531         Errors should be separated from the command line in bot messages.
1532         https://bugs.webkit.org/show_bug.cgi?id=52275
1533
1534         * Scripts/webkitpy/common/system/executive.py:
1535         (ScriptError.message_with_output): Added a newline to separate the command
1536         line from the errors.
1537         * Scripts/webkitpy/common/system/executive_unittest.py:
1538         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1539         paths in message_with_output.
1540
1541 2011-01-11  Eric Seidel  <eric@webkit.org>
1542
1543         Unreviewed.
1544
1545         commit-queue should know how to upload archived results (for test flakes or general failures)
1546         https://bugs.webkit.org/show_bug.cgi?id=52048
1547
1548         The zips are mostly empty due to forgetting -r.
1549         Expected diffs were not being pulled from the archive due
1550         to the archive having longer paths than I realized.
1551
1552         * Scripts/webkitpy/common/system/workspace.py:
1553         * Scripts/webkitpy/common/system/workspace_unittest.py:
1554         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1555         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1556
1557 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1558
1559         Reviewed by Ojan Vafai.
1560
1561         The current modifier parsing code in test_expectations is
1562         fragile and hard-coded, so it's not easy to understand the logic
1563         or easily add new types of modifiers (like GPU vs. CPU testing
1564         for graphics tests, or 32-bit vs. 64-bit differences).
1565
1566         This is the first of two patches that will add in more generic
1567         support and then eliminate the GPU-specific test expectations
1568         files for Chromium.
1569
1570         This patch adds two standalone objects for handling modifiers. The
1571         rules for interpreting modifiers, precedence, and conflicts are
1572         given in the docstring to the ModifierMatcher class, which
1573         returns ModifierMatchResult objects.
1574         
1575         This patch also adds routines to the Port interface and a
1576         default set of values in the base object, in order to obtain the
1577         values needed on a given test run. These values are then passed
1578         to the expectation parser. This also allows us to clean up the
1579         logic used to lint all of the different configurations in a
1580         single test_expectations.txt file.
1581
1582         The next patch will merge in the separate GPU expectations file.
1583
1584         https://bugs.webkit.org/show_bug.cgi?id=51222
1585
1586         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1587         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1588         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1589         * Scripts/webkitpy/layout_tests/port/base.py:
1590         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1591         * Scripts/webkitpy/layout_tests/port/chromium.py:
1592         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1593         * Scripts/webkitpy/layout_tests/port/test.py:
1594         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1595         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1596
1597 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1598
1599         Reviewed by Adam Barth.
1600
1601         Make webkit-patch support subdirectories for SVN checkouts
1602         https://bugs.webkit.org/show_bug.cgi?id=52261
1603
1604         * Scripts/webkitpy/common/checkout/scm.py:
1605         * Scripts/webkitpy/style_references.py:
1606         * Scripts/webkitpy/tool/main.py:
1607         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1608
1609 2011-01-11  Eric Seidel  <eric@webkit.org>
1610
1611         Unreviewed.
1612
1613         commit-queue should know how to upload archived results (for test flakes or general failures)
1614         https://bugs.webkit.org/show_bug.cgi?id=52048
1615
1616         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1617         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1618
1619         * Scripts/webkitpy/common/system/workspace.py:
1620         * Scripts/webkitpy/common/system/workspace_unittest.py:
1621         * Scripts/webkitpy/tool/commands/queues.py:
1622
1623 2011-01-11  Sam Weinig  <sam@webkit.org>
1624
1625         Roll r75474 back in.
1626
1627 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1628
1629         Reviewed by Kenneth Rohde Christiansen.
1630
1631         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1632         https://bugs.webkit.org/show_bug.cgi?id=51204
1633
1634         * QtTestBrowser/webpage.h:
1635         (QtNAMThread::QtNAMThread):
1636         (QtNAMThread::networkAccessManager):
1637         (QtNAMThread::run):
1638
1639 2011-01-11  Peter Varga  <pvarga@webkit.org>
1640
1641         Unreviewed.
1642
1643         Add myself to committers' list.
1644
1645         * Scripts/webkitpy/common/config/committers.py:
1646
1647 2011-01-11  Eric Seidel  <eric@webkit.org>
1648
1649         Reviewed by Adam Barth.
1650
1651         commit-queue should know how to upload archived results (for test flakes or general failures)
1652         https://bugs.webkit.org/show_bug.cgi?id=52048
1653
1654         Now the queue will always upload results.  Either the entire zip, or just
1655         the diffs.txt in the case of text failures.
1656
1657         This should make understanding flakes much easier, and paves the way
1658         for having the EWS run layout tests (and upload failures).
1659
1660         In order to upload .zip files I had to teach bugzilla.py to autodetect
1661         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1662         for .patch files, I have it add one before calling guess_type.
1663
1664         We may find that always uploading the whole zip instead of just the -diffs.txt
1665         file is preferable, but for now I'm keeping the old behavior because it makes
1666         quickly understanding text failures easy.
1667
1668         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1669         * Scripts/webkitpy/common/system/workspace.py: Added.
1670         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1671         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1672         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1673         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1674         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1675         * Scripts/webkitpy/tool/commands/queues.py:
1676         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1677
1678 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1679
1680         Unreviewed, rolling out r75464.
1681         http://trac.webkit.org/changeset/75464
1682         https://bugs.webkit.org/show_bug.cgi?id=52193
1683
1684         Followup rollout for 75474 (Requested by Ossy on #webkit).
1685
1686         * MiniBrowser/mac/BrowserWindowController.m:
1687         (-[BrowserWindowController awakeFromNib]):
1688         * MiniBrowser/win/BrowserView.cpp:
1689         (BrowserView::create):
1690         * WebKitTestRunner/TestController.cpp:
1691         (WTR::createOtherPage):
1692         (WTR::TestController::initialize):
1693
1694 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1695
1696         Reviewed by Csaba Osztrogonác.
1697
1698         [Qt] Baseline qt_minimal configuration
1699         https://bugs.webkit.org/show_bug.cgi?id=51313
1700
1701         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1702         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1703         QT_NO_UNDOSTACK guard.
1704
1705         * QtTestBrowser/launcherwindow.cpp:
1706         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1707         guards.
1708         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1709         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1710         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1711         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1712
1713         * QtTestBrowser/launcherwindow.h:
1714         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1715         * QtTestBrowser/locationedit.h: Ditto.
1716
1717         * QtTestBrowser/mainwindow.cpp:
1718         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1719         QT_NO_UNDOSTACK guards.
1720         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1721         (MainWindow::changeLocation): Ditto.
1722         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1723         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1724
1725         * QtTestBrowser/webpage.cpp:
1726         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1727         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1728
1729         * QtTestBrowser/webview.cpp:
1730         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1731         (WebViewGraphicsBased::animatedYFlip): Ditto.
1732
1733 2011-01-10  Sam Weinig  <sam@webkit.org>
1734
1735         Fix build.
1736
1737         * MiniBrowser/mac/BrowserWindowController.m:
1738         (-[BrowserWindowController awakeFromNib]):
1739         * MiniBrowser/win/BrowserView.cpp:
1740         (BrowserView::create):
1741         * WebKitTestRunner/TestController.cpp:
1742         (WTR::createOtherPage):
1743         (WTR::TestController::initialize):
1744
1745 2011-01-10  Eric Seidel  <eric@webkit.org>
1746
1747         Reviewed by Ojan Vafai.
1748
1749         style-queue messages are way too long for big patches
1750         https://bugs.webkit.org/show_bug.cgi?id=52161
1751
1752         We definitely could build much fancier list-to-string-with-limit functions
1753         but this should be sufficient for our needs at the moment.
1754
1755         * Scripts/webkitpy/common/system/executive.py:
1756         * Scripts/webkitpy/common/system/executive_unittest.py:
1757
1758 2011-01-10  Tony Chang  <tony@chromium.org>
1759
1760         Unreviewed, rolling out r75398.
1761         http://trac.webkit.org/changeset/75398
1762         https://bugs.webkit.org/show_bug.cgi?id=52008
1763
1764         Some layout tests are crashing on Chromium Win.
1765
1766         * DumpRenderTree/chromium/WebViewHost.cpp:
1767         (WebViewHost::updatePaintRect):
1768         * DumpRenderTree/chromium/WebViewHost.h:
1769
1770 2011-01-10  Adam Roben  <aroben@apple.com>
1771
1772         Roll out r75392
1773
1774         It isn't needed now that r75289 has been rolled out.
1775
1776         * Scripts/run-javascriptcore-tests:
1777
1778 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1779
1780         Reviewed by Anders Carlsson.
1781
1782         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1783         https://bugs.webkit.org/show_bug.cgi?id=52160
1784
1785         * WebKitTestRunner/mac/TestControllerMac.mm:
1786         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1787         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1788         anyway.
1789
1790 2011-01-10  Tony Chang  <tony@chromium.org>
1791
1792         Reviewed by Mihai Parparita.
1793
1794         [chromium] fix for animated gif layout tests
1795         https://bugs.webkit.org/show_bug.cgi?id=52008
1796
1797         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1798             to trigger gif animations.
1799         (WebViewHostPaintTask::WebViewHostPaintTask):
1800         (WebViewHostPaintTask::runIfValid):
1801         (WebViewHost::updatePaintRect):
1802         * DumpRenderTree/chromium/WebViewHost.h:
1803         (WebViewHost::taskList):
1804
1805 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1806
1807         Reviewed by Xan Lopez.
1808
1809         [GTK] Fix gtk2 compilation for master
1810         https://bugs.webkit.org/show_bug.cgi?id=51885
1811
1812         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1813         (createBitmapContextFromWebView): Replaced the old
1814         gdk_drawable_get_size with gdk_pixmap_get_size.
1815
1816 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1817
1818         Reviewed by Laszlo Gombos.
1819
1820         [WINCE] Reenable NPAPI after r75203
1821         https://bugs.webkit.org/show_bug.cgi?id=52109
1822
1823         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1824         it with !isEfl(), because EFL port does not support NPAPI (yet).
1825
1826         * Scripts/build-webkit:
1827
1828 2011-01-10  Adam Roben  <aroben@apple.com>
1829
1830         Skip some asserting JS tests
1831
1832         See <http://webkit.org/b/52156>.
1833
1834         * Scripts/run-javascriptcore-tests:
1835
1836 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1837
1838         Reviewed by Xan Lopez.
1839
1840         [GTK] build-webkit disable Blob support via arguments passed to automake
1841         https://bugs.webkit.org/show_bug.cgi?id=52097
1842
1843         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1844         build-webkit.
1845
1846 2011-01-10  Adam Roben  <aroben@apple.com>
1847
1848         Use the same name and description for TestNetscapePlugin on Windows and
1849         Mac
1850
1851         Fixes <http://webkit.org/b/52151>
1852         fast/frames/iframe-reparenting-plugins.html fails on Windows
1853
1854         Reviewed by Steve Falkenburg.
1855
1856         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1857         the name and description from Mac's Info.plist.
1858
1859 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1860
1861         Reviewed by Laszlo Gombos.
1862
1863         [Qt][WK2] Guard gcc-specific syntax
1864
1865         Non-gcc based compliers choke on the "-include"
1866         syntax for preinclude, place guard around it.
1867
1868         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1869         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1870
1871 2011-01-10  Andreas Kling  <kling@webkit.org>
1872
1873         Reviewed by Simon Hausmann.
1874
1875         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1876         https://bugs.webkit.org/show_bug.cgi?id=52111
1877
1878         When getting a createNewPage() callback from QWKPage, create the
1879         new page with the same QWKContext as the page that is passed to
1880         the callback.
1881
1882         * MiniBrowser/qt/BrowserView.h:
1883         * MiniBrowser/qt/BrowserWindow.cpp:
1884         (newPageFunction):
1885         (BrowserWindow::BrowserWindow):
1886         * MiniBrowser/qt/BrowserWindow.h:
1887
1888 2011-01-10  Andreas Kling  <kling@webkit.org>
1889
1890         Reviewed by Kenneth Rohde Christiansen.
1891
1892         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1893
1894         BrowserView set its own useless createNewPage() callback on QWKPage.
1895         This was immediately overridden by BrowserWindow anyway, so remove
1896         the BrowserView one.
1897
1898         * MiniBrowser/qt/BrowserView.cpp:
1899         (BrowserView::BrowserView):
1900
1901 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1902
1903         Reviewed by Jeremy Orlow.
1904
1905         [Chromium] Remove non-client-based Geolocation code
1906         https://bugs.webkit.org/show_bug.cgi?id=50921
1907
1908         * DumpRenderTree/chromium/LayoutTestController.cpp:
1909         (LayoutTestController::setGeolocationPermission):
1910         (LayoutTestController::setMockGeolocationPosition):
1911         (LayoutTestController::setMockGeolocationError):
1912         * DumpRenderTree/chromium/WebViewHost.cpp:
1913         (WebViewHost::geolocationClientMock):
1914         (WebViewHost::reset):
1915         * DumpRenderTree/chromium/WebViewHost.h:
1916
1917 2011-01-10  Eric Seidel  <eric@webkit.org>
1918
1919         Reviewed by Adam Barth.
1920
1921         Commit bot tried to land r? cq+ patch
1922         https://bugs.webkit.org/show_bug.cgi?id=36638
1923
1924         It should now be possible to post a patch with r? and cq+ and the
1925         commit-queue will correctly wait for the r+ before attempting to land the patch.
1926         (This was a feature requested by several users.)
1927
1928         One caveat: We don't actually reject r-, cq+ patches from the queue
1929         (we just ignore them), but I think that's OK for now.
1930
1931         I also noticed that setting r- once a commit-queue node had grabbed
1932         a patch would not properly cancel the landing.  That's fixed and
1933         tested in this patch.
1934
1935         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1936         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1937         * Scripts/webkitpy/tool/bot/feeders.py:
1938         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1939
1940 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1941
1942         Reviewed by Kenneth Rohde Christiansen.
1943
1944         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1945         https://bugs.webkit.org/show_bug.cgi?id=51934
1946
1947         When accessing the network from the destructor of QWebPage, the network access manager
1948         was already deleted because the object WebPage was already destructed.
1949
1950         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1951         The object is now destructed in the destructor of QObject.
1952
1953         * QtTestBrowser/webpage.cpp:
1954         (WebPage::WebPage):
1955         (WebPage::setQnamThreaded):
1956         * QtTestBrowser/webpage.h:
1957         (QtNAMThread::QtNAMThread):
1958
1959 2011-01-08  Eric Seidel  <eric@webkit.org>
1960
1961         Reviewed by Ojan Vafai.
1962
1963         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1964         https://bugs.webkit.org/show_bug.cgi?id=52067
1965
1966         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1967         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1968
1969         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1970
1971 2011-01-08  Eric Seidel  <eric@webkit.org>
1972
1973         Reviewed by Mihai Parparita.
1974
1975         commit-queue hangs when the ChangeLog diff is bad
1976         https://bugs.webkit.org/show_bug.cgi?id=52072
1977
1978         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1979         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1980
1981 2011-01-08  Adam Barth  <abarth@webkit.org>
1982
1983         Teach svn-apply how to re-write WebCore to Source/WebCore.
1984
1985         * Scripts/VCSUtils.pm:
1986
1987 2011-01-07  Adam Barth  <abarth@webkit.org>
1988
1989         Rubber-stamped by Eric Seidel.
1990
1991         Move WebCore to Source
1992         https://bugs.webkit.org/show_bug.cgi?id=52050
1993
1994         Update the tools to understand WebCore's new location.
1995
1996         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1997         * DumpRenderTree/wscript:
1998         * GNUmakefile.am:
1999         * Scripts/build-webkit:
2000         * Scripts/do-file-rename:
2001         * Scripts/do-webcore-rename:
2002         * Scripts/generate-qt-inspector-resource:
2003         * Scripts/prepare-ChangeLog:
2004         * Scripts/run-bindings-tests:
2005         * Scripts/update-iexploder-cssproperties:
2006         * Scripts/update-sources-list.py:
2007         * Scripts/update-webkit-localizable-strings:
2008         * Scripts/webkitdirs.pm:
2009         * Scripts/webkitpy/common/config/build.py:
2010         * Scripts/webkitpy/common/config/build_unittest.py:
2011         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2012         * Scripts/webkitpy/style/checker.py:
2013         * Scripts/webkitpy/style/checker_unittest.py:
2014         * WebKitTestRunner/DerivedSources.pro:
2015         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2016         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2017         * wx/browser/wscript:
2018         * wx/build/settings.py:
2019
2020 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2021
2022         Reviewed by Sam Weinig.
2023
2024         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2025         https://bugs.webkit.org/show_bug.cgi?id=52086
2026
2027         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2028         (WTR::InjectedBundle::didReceiveMessage):
2029         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2030         (WTR::LayoutTestController::notifyDone):
2031         * WebKitTestRunner/TestController.cpp:
2032         (WTR::TestController::resetStateToConsistentValues):
2033         (WTR::TestController::run):
2034
2035 2011-01-07  James Robinson  <jamesr@chromium.org>
2036
2037         Revert "Implement mozilla's animationTime property"
2038         https://bugs.webkit.org/show_bug.cgi?id=51952
2039
2040         This approach isn't quite right.
2041
2042         * DumpRenderTree/chromium/WebViewHost.cpp:
2043         (WebViewHost::paintInvalidatedRegion):
2044
2045 2011-01-07  Adam Roben  <aroben@apple.com>
2046
2047         Build master fix
2048
2049         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2050         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2051
2052 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2053
2054         Reviewed by Csaba Osztrogonác.
2055
2056         run-qtwebkit-tests should be able to kill a testsuite.
2057
2058         Add new option in the script that can setup a timeout for a test.
2059         If the test execution takes more then specified time then the test
2060         would be terminated.
2061
2062         [Qt] run-qtwebkit-tests needs timeout
2063         https://bugs.webkit.org/show_bug.cgi?id=51894
2064
2065         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2066         * Scripts/run-qtwebkit-tests:
2067
2068 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2069
2070         Unreviewed fix after r75233.
2071
2072         Based on idea from Eric Seidel.
2073
2074         Add remote zip file handling to webkitpy.
2075         https://bugs.webkit.org/show_bug.cgi?id=50901
2076
2077         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2078
2079 2011-01-07  Shane Stephens  <shanestephens@google.com>
2080
2081         Reviewed by Eric Seidel.
2082
2083         svn-apply: should support git binary delta diffs
2084         https://bugs.webkit.org/show_bug.cgi?id=38864
2085
2086         * Scripts/VCSUtils.pm:
2087         * Scripts/svn-apply:
2088
2089 2011-01-06  Julie Parent  <jparent@chromium.org>
2090
2091         Reviewed by Eric Seidel.
2092
2093         Test Result Server not removing old results.
2094         https://bugs.webkit.org/show_bug.cgi?id=52012
2095
2096         * TestResultServer/model/jsonresults.py:
2097         Fix off-by-one: Truncate if >= num_runs, not just >.
2098         * TestResultServer/model/jsonresults_unittest.py:
2099         Add unit test to test that merging in a new result with the same value
2100         as the last result causes previous result to fall off.
2101
2102 2011-01-06  James Kozianski  <koz@chromium.org>
2103
2104         Reviewed by Mihai Parparita.
2105
2106         Add classes to provide a consistent interface to a set of files.
2107         https://bugs.webkit.org/show_bug.cgi?id=50901
2108
2109         These classes allow us to write code that is agnostic to whether a
2110         particular set of files resides in a local directory or in a zip file
2111         on a remote machine.
2112
2113         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2114         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2115         * Scripts/webkitpy/common/system/fileset.py: Added.
2116         * Scripts/webkitpy/common/system/filesystem.py:
2117         * Scripts/webkitpy/common/system/filesystem_mock.py:
2118         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2119         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2120
2121 2011-01-06  Eric Seidel  <eric@webkit.org>
2122
2123         Reviewed by Adam Barth.
2124
2125         NetworkTransaction should log the url it is retrying
2126         https://bugs.webkit.org/show_bug.cgi?id=52043
2127
2128         * Scripts/webkitpy/common/net/networktransaction.py:
2129         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2130
2131 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2132
2133         Windows build fix.
2134         Import os before using it.
2135
2136         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2137
2138 2011-01-06  Eric Seidel  <eric@webkit.org>
2139
2140         Reviewed by Adam Barth.
2141
2142         StyleQueue fails to report errors when patches have many files
2143         https://bugs.webkit.org/show_bug.cgi?id=52042
2144
2145         This is one of at least two errors preventing style error reporting at the moment.
2146         When we moved to passing the list of files to check explicitly,
2147         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2148         We could change the type of the QueueStatus.message type, or we could
2149         just teach statusserver.py how to clamp values (and warn when it does).
2150         I chose the latter path.
2151
2152         * Scripts/webkitpy/common/net/statusserver.py:
2153
2154 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2155
2156         Reviewed by Stephanie Lewis.
2157         
2158         Fix syntax error in script.
2159
2160         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2161         https://bugs.webkit.org/show_bug.cgi?id=51996
2162
2163         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2164
2165 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2166
2167         Unreviewed, fixing WinCE build after r75196.
2168
2169         WinCE port does not (yet) support NPAPI.
2170
2171         * Scripts/build-webkit:
2172
2173 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2174
2175         Reviewed by Darin Adler.
2176
2177         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2178         https://bugs.webkit.org/show_bug.cgi?id=52015
2179
2180         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2181         after the platform has been detected, otherwise the script will
2182         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2183         detection.
2184
2185 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2186
2187         Reviewed by Eric Seidel.
2188
2189         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2190         https://bugs.webkit.org/show_bug.cgi?id=51346
2191
2192         * Scripts/build-webkit:
2193
2194 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2195
2196         Reviewed by Adam Roben.
2197
2198         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2199         https://bugs.webkit.org/show_bug.cgi?id=51996
2200         
2201         After the configuration directory change, we were archiving the incorrect directory for
2202         build product, so we were running tests on the wrong binaries.
2203         
2204         This change archives the correct directory, and also unarchives it into a configuration-
2205         specific directory.
2206
2207         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2208         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2209
2210 2011-01-06  Eric Seidel  <eric@webkit.org>
2211
2212         Reviewed by Mihai Parparita.
2213
2214         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2215         https://bugs.webkit.org/show_bug.cgi?id=52002
2216
2217         See an example of this here:
2218         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2219
2220         It's due to the fact that we pass around TestFailure() instance
2221         objects and yet expect them to all compare to be the same.
2222
2223         This is bad.  We should either have shared instances of these values
2224         or we should just pass around the class names.  There are already hacks
2225         in place to make TestFailure objects pass equality tests, I just added
2226         a __hash__ implementation so they can be used in sets as expected.
2227
2228         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2229         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2230
2231 2011-01-06  Evan Martin  <evan@chromium.org>
2232
2233         Reviewed by Tony Chang.
2234
2235         [gdb] handle inaccessible memory and UChar*
2236         https://bugs.webkit.org/show_bug.cgi?id=52003
2237
2238         To pretty-print a UChar*, we just grope around in the memory
2239         looking for a terminating NUL.  We need to handle the exception
2240         that can occur when we poke into an invalid location.
2241
2242         Additionally, the logic for choosing which pretty-printer would
2243         early return before hitting the point where we'd use the UChar*
2244         printer.  (Did this ever work?  How did it regress?)
2245
2246         * gdb/webkit.py:
2247
2248 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2249
2250         Reviewed by Ada Chan.
2251
2252         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2253         https://bugs.webkit.org/show_bug.cgi?id=51969
2254         
2255         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2256
2257         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2258         (WTR::InjectedBundlePage::InjectedBundlePage):
2259         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2260         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2261
2262 2011-01-06  James Robinson  <jamesr@chromium.org>
2263
2264         Reviewed by Simon Fraser.
2265
2266         Implement mozilla's animationTime property
2267         https://bugs.webkit.org/show_bug.cgi?id=51952
2268
2269         Chromium DRT support for webkitAnimationTime.
2270
2271         * DumpRenderTree/chromium/WebViewHost.cpp:
2272         (WebViewHost::paintInvalidatedRegion):
2273
2274 2011-01-06  Julie Parent  <jparent@chromium.org>
2275
2276         Reviewed by Tony Chang.
2277
2278         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2279         https://bugs.webkit.org/show_bug.cgi?id=51217
2280
2281         * TestResultServer/model/jsonresults.py:
2282         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2283         Adds missing documentation.
2284         * TestResultServer/model/jsonresults_unittest.py:
2285         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2286         Update test_merge to take a number of builds to truncate at.
2287
2288 2011-01-06  Adam Barth  <abarth@webkit.org>
2289
2290         Reviewed by Eric Seidel.
2291
2292         The EWS should log outside of the working directory
2293         https://bugs.webkit.org/show_bug.cgi?id=51986
2294
2295         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2296         script, which will actually clean the working copy back to a pristine
2297         state instead of leaving untracked directories and ignored files.
2298
2299         * Scripts/webkitpy/tool/commands/queues.py:
2300         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2301
2302 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2303
2304         Windows build fix.
2305         Back out attempted change to built-product-archive.
2306
2307         * BuildSlaveSupport/built-product-archive:
2308
2309 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2310
2311         Windows build fix.
2312         Include configuration name when unpacking a build archive.
2313
2314         Needed, since we split Windows build results into configuration-specific directories
2315         under WebKitOutputDir.
2316
2317         * BuildSlaveSupport/built-product-archive:
2318
2319 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2320
2321         Reviewed by Darin Adler.
2322
2323         Debug and Release builds on Windows clobber each other
2324         https://bugs.webkit.org/show_bug.cgi?id=49185
2325
2326         Changes the structure of WebKitBuild build products directory so we
2327         completely separate each build configuration into independent directories.
2328         
2329         Although we previously had per-configuration directories for obj, this change adds
2330         per-configuration directories for bin, lib, obj, and include. Each configuration's
2331         build products are stored within a directory inside of WebKitBuild.
2332         
2333         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2334         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2335
2336         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2337         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2338         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2339         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2340         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2341         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2342         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2343         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2344         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2345         * FindSafari/FindSafari.vcproj:
2346         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2347         * MiniBrowser/MiniBrowserPostBuild.cmd:
2348         * MiniBrowser/MiniBrowserPreBuild.cmd:
2349         * Scripts/webkitdirs.pm:
2350         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2351         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2352         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2353         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2354         * TestWebKitAPI/win/copy-resources.cmd:
2355         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2356         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2357         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2358         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2359         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2360         * WebKitTestRunner/win/InjectedBundle.vcproj:
2361         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2362         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2363         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2364         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2365         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2366         * WinLauncher/WinLauncherCommon.vsprops:
2367         * WinLauncher/WinLauncherPostBuild.cmd:
2368         * WinLauncher/WinLauncherPreBuild.cmd:
2369
2370 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2371
2372         Reviewed by Ariya Hidayat.
2373
2374         [Qt] TestNetscapePlugin doesn't link on OS X
2375         https://bugs.webkit.org/show_bug.cgi?id=51948
2376
2377         Only add a dependency on libX11 on X11 systems
2378
2379         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2380
2381 2011-01-05  Jeff Miller  <jeffm@apple.com>
2382
2383         Reviewed by Adam Roben.
2384
2385         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2386         https://bugs.webkit.org/show_bug.cgi?id=51970
2387
2388         * Scripts/webkitpy/style/checker.py:
2389         Add -readability/naming for WebKit2 C API directories.
2390
2391 2011-01-05  Eric Seidel  <eric@webkit.org>
2392
2393         Unreviewed, just fixing one more log error from my previous python patch.
2394
2395         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2396         https://bugs.webkit.org/show_bug.cgi?id=51802
2397
2398         webkit-patch failure-reason was logging about parsing errors
2399         due to my misunderstanding of how BeautifulSoup.findAll worked.
2400
2401         Fixed, and added a unit test.
2402
2403         * Scripts/webkitpy/common/net/layouttestresults.py:
2404         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2405
2406 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2407
2408         Reviewed by Kenneth Rohde Christiansen.
2409
2410         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2411         https://bugs.webkit.org/show_bug.cgi?id=51951
2412
2413         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2414         to create new window from WebKit.
2415
2416         * MiniBrowser/qt/BrowserWindow.cpp:
2417         (newPageFunction):
2418         (BrowserWindow::BrowserWindow):
2419         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2420         (BrowserWindow::newWindow):
2421         (BrowserWindow::updateUserAgentList):
2422         (BrowserWindow::showUserAgentDialog):
2423         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2424         define the type of the backing store used for new windows.
2425         * MiniBrowser/qt/main.cpp:
2426         (main):
2427
2428 2011-01-05  Eric Seidel  <eric@webkit.org>
2429
2430         Reviewed by Ojan Vafai.
2431
2432         commit-queue should report failure type when reporting flaky tests
2433         https://bugs.webkit.org/show_bug.cgi?id=51900
2434
2435         This patch was a ridiculous amount of plumbing.  In the end I like
2436         the NRWT-style TestResult class even less.  But now we're passing
2437         a list of TestResult objects from the queue to the FlakyTestReporter.
2438         Thus the FlakyTestReporter can more easily report what type of failure
2439         occurred.
2440
2441         In the process, I found that I was not alone in finding TestResult
2442         cumbersome to use.  A bunch of code was trying to create a TestResult
2443         object with default values.  However since the constructor didn't make
2444         this easy, some places were getting it wrong (including the TestResult unit test)!
2445         I've fixed the TestResult constructor to have default values for non-essential
2446         arguments.
2447
2448         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2449         * Scripts/webkitpy/common/net/layouttestresults.py:
2450         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2451         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2452         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2453         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2454         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2455         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2456         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2457         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2458         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2459         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2460         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2461         * Scripts/webkitpy/tool/commands/queues.py:
2462         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2463
2464 2011-01-05  Eric Seidel  <eric@webkit.org>
2465
2466         Unreviewed.
2467
2468         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2469         https://bugs.webkit.org/show_bug.cgi?id=51802
2470
2471         Add another unit test to cover a previously missing import.
2472
2473         * Scripts/webkitpy/common/net/layouttestresults.py:
2474         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2475
2476 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2477
2478         Reviewed by David Levin.
2479
2480         Add mihaip@chromium.org as a reviewer
2481         https://bugs.webkit.org/show_bug.cgi?id=51966
2482         
2483         Add myself as a reviewer.
2484
2485         * Scripts/webkitpy/common/config/committers.py:
2486
2487 2011-01-05  James Simonsen  <simonjam@chromium.org>
2488
2489         Unreviewed. Adding myself to the list of committers.
2490
2491         * Scripts/webkitpy/common/config/committers.py:
2492
2493 2011-01-05  Eric Seidel  <eric@webkit.org>
2494
2495         Unreviewed.
2496
2497         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2498         https://bugs.webkit.org/show_bug.cgi?id=51802
2499
2500         Fix two exceptions seen on the bots after my original commit.
2501
2502         * Scripts/webkitpy/common/net/layouttestresults.py:
2503         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2504
2505 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2506
2507         Reviewed by Andreas Kling.
2508
2509         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2510         https://bugs.webkit.org/show_bug.cgi?id=51750
2511
2512         * QtTestBrowser/main.cpp:
2513         (LauncherApplication::handleUserOptions):
2514          Local storage settings can be enable form command line arguments for
2515          QtTestBrowser.
2516
2517 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2518
2519         Reviewed by Martin Robinson.
2520
2521         GTK: AX: DRT needs to use correct root object method.
2522         https://bugs.webkit.org/show_bug.cgi?id=51911
2523
2524         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2525         (AccessibilityController::rootElement):
2526
2527 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2528
2529         Rubber-stamped by Csaba Osztrogonác.
2530
2531         Based on idea from Péter Gál.
2532
2533         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2534
2535 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2536
2537         Reviewed by Adam Barth.
2538
2539         sheriff-bot should be able to do multi-revision rollouts
2540         https://bugs.webkit.org/show_bug.cgi?id=51176
2541
2542         * Scripts/webkitpy/tool/bot/irc_command.py:
2543         * Scripts/webkitpy/tool/bot/sheriff.py:
2544         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2545
2546 2011-01-05  Eric Seidel  <eric@webkit.org>
2547
2548         Reviewed by Adam Barth.
2549
2550         queues.webkit.org should have per-bot status pages
2551         https://bugs.webkit.org/show_bug.cgi?id=51906
2552
2553         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2554         statuses from a single queue.  Now that we have many bots servicing
2555         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2556         you care about scroll off the end of the 15-message limit on the main page.
2557
2558         Eventually we should probably rename /queue-status to /queue or /queues,
2559         but that's fodder for another patch.
2560
2561         * QueueStatusServer/handlers/queuestatus.py:
2562         * QueueStatusServer/index.yaml:
2563         * QueueStatusServer/main.py:
2564         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2565          - This probably should use a custom filter instead of hard-coding
2566            the URL scheme here, but I couldn't figure out how to easily
2567            create such a filter.  Most filters work with "strings" so we can't
2568            pass the status object.  We could add a method to the status
2569            object and call that, but that seemed a bit strange too.
2570         * QueueStatusServer/templates/queuestatus.html:
2571
2572 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2573
2574         Unreviewed. Adding myself to the list of committers.
2575
2576         * Scripts/webkitpy/common/config/committers.py:
2577
2578 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2579
2580         Reviewed by David Levin.
2581
2582         check-webkit-style treated some macros with parentheses after #elif as function calls
2583         https://bugs.webkit.org/show_bug.cgi?id=51695
2584
2585         Ingore function call space checking in any preprocessor directives
2586         (things starting with #). Change search() to match() because 
2587         preprocessor directives are supposed to be in the beginning of lines.
2588
2589         * Scripts/webkitpy/style/checkers/cpp.py:
2590         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2591
2592 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2593
2594         Reviewed by Tony Chang.
2595
2596         Change the --multi-load test option to --stress-opt
2597         https://bugs.webkit.org/show_bug.cgi?id=50751
2598
2599         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2600         (runTest):
2601         (main):
2602         * DumpRenderTree/chromium/TestShell.cpp:
2603         (TestShell::TestShell):
2604         * DumpRenderTree/chromium/TestShell.h:
2605         (TestShell::stressOpt):
2606         (TestShell::setStressOpt):
2607         (TestShell::stressDeopt):
2608         (TestShell::setStressDeopt):
2609         (TestShell::javaScriptFlags):
2610         (TestShell::setJavaScriptFlags):
2611         * Scripts/webkitpy/layout_tests/port/chromium.py:
2612         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2613
2614 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2615
2616         Reviewed by Sam Weinig.
2617
2618         WK2: Support Accessibility
2619         https://bugs.webkit.org/show_bug.cgi?id=51859
2620
2621         Use rootObject() method to get top of accessibility tree.
2622
2623         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2624         (AccessibilityController::focusedElement):
2625         (AccessibilityController::rootElement):
2626
2627 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2628
2629         Reviewed by Darin Adler.
2630
2631         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2632         https://bugs.webkit.org/show_bug.cgi?id=51846
2633
2634         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2635         back to GRefPtr.
2636
2637 2011-01-04  Zhe Su  <suzhe@chromium.org>
2638
2639         Reviewed by Kenneth Russell.
2640
2641         Fix insertText, setMarkedText and unmarkText methods of
2642         TextInputController to call corresponding methods of WebKit::WebView
2643         rather than WebKit::WebFrame. This change matches the behavior of
2644         chromium browser.
2645         insertText corresponds to WebView::confirmComposition(text)
2646         setMarkedText corresponds to WebView::setComposition(...)
2647         unmarkText corresponds to WebView::confirmComposition()
2648         https://bugs.webkit.org/show_bug.cgi?id=51693
2649
2650         * DumpRenderTree/chromium/TextInputController.cpp:
2651         (TextInputController::insertText):
2652         (TextInputController::setMarkedText):
2653         (TextInputController::unmarkText):
2654
2655 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2656
2657         Reviewed by Laszlo Gombos.
2658
2659         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2660
2661         On Symbian productDir points to the source directory. Removing all the
2662         empty files from the productDir directory corrupts the svn repository.
2663
2664         * Scripts/build-webkit:
2665
2666 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2667
2668         Reviewed by Adam Barth.
2669
2670         [Qt] Add SelectAll option to the context menu for the editor
2671         https://bugs.webkit.org/show_bug.cgi?id=50049
2672
2673         Set shortcut for the SelectAll action.
2674
2675         * QtTestBrowser/mainwindow.cpp:
2676         (MainWindow::buildUI):
2677
2678 2011-01-03  David Levin  <levin@chromium.org>
2679
2680         Reviewed by Eric Seidel.
2681
2682         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2683         https://bugs.webkit.org/show_bug.cgi?id=51842
2684
2685         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2686         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2687
2688 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2689
2690         Reviewed by David Kilzer.
2691
2692         [WINCE] Adds a build slave.
2693         https://bugs.webkit.org/show_bug.cgi?id=50523
2694
2695         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2696         entry for a release build of the WinCE port.
2697         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2698         flag to build the WinCE port.
2699
2700 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2701
2702         Reviewed by David Kilzer.
2703
2704         Add WinCE support to build-webkit
2705         https://bugs.webkit.org/show_bug.cgi?id=51642
2706
2707         * Scripts/build-webkit:
2708         * Scripts/webkitdirs.pm:
2709
2710 2011-01-03  Eric Seidel  <eric@webkit.org>
2711
2712         Reviewed by Adam Barth.
2713
2714         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2715         https://bugs.webkit.org/show_bug.cgi?id=51802
2716
2717         I'm not the biggest fan of the test_failures or test_results classes,
2718         but it's better to have one shared set of classes, than separate ones
2719         for new vs. old run-webkit-test result handling.
2720
2721         This moves the ORWT results class "LayoutTestResults" over to using
2722         TestResult and TestFailure classes, making it easy for us to
2723         make all our sheriff-bot and other webkitpy code NRWT ready.
2724
2725         This also makes it a trivial patch to generate results.json information
2726         from ORWT results.html files (for flaky test analysis, etc.) as well
2727         as making it a one-liner to report test failure types when the
2728         commit-queue sees flaky tests.
2729
2730         This patch tried not to add new functionality, but only to replace
2731         the guts of LayoutTestResults, while adding unit tests and hoping
2732         not to break anything.
2733
2734         I also moved callers which assumed User.prompt* were static/class methods
2735         to using them as instance methods (since we'll eventually want to make them such).
2736
2737         In the process of re-writing things, I broke the rebaseline command, so I wrote
2738         a unit test to catch my breakage were I do do so again in the future.
2739
2740         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2741         * Scripts/webkitpy/common/net/layouttestresults.py:
2742         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2743         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2744         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2745         * Scripts/webkitpy/tool/commands/queries.py:
2746         * Scripts/webkitpy/tool/commands/rebaseline.py:
2747         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2748         * Scripts/webkitpy/tool/mocktool.py:
2749
2750 2011-01-03  Adam Barth  <abarth@webkit.org>
2751
2752         Reviewed by Simon Fraser.
2753
2754         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2755         https://bugs.webkit.org/show_bug.cgi?id=51840
2756
2757         * Scripts/webkitpy/common/checkout/scm.py:
2758
2759 2011-01-03  Adam Barth  <abarth@webkit.org>
2760
2761         Reviewed by Simon Fraser.
2762
2763         webkit-patch should only hide update output if --quiet
2764         https://bugs.webkit.org/show_bug.cgi?id=51838
2765
2766         As requested by smfr.
2767
2768         * Scripts/webkitpy/tool/steps/update.py:
2769
2770 2011-01-03  Adam Barth  <abarth@webkit.org>
2771
2772         Reviewed by David Levin.
2773
2774         commit-queue shouldn't reject patches twice if two bots process the same patch
2775         https://bugs.webkit.org/show_bug.cgi?id=51805
2776
2777         Before raising an error, we first check whether the patch is still in
2778         the commit-queue.  This check is still racy, of course, but the time
2779         window is much smaller.
2780
2781         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2782
2783 2011-01-03  Sam Weinig  <sam@webkit.org>
2784
2785         Reviewed by Anders Carlsson.
2786
2787         Make run-api-tests less chatty.
2788         https://bugs.webkit.org/show_bug.cgi?id=51831
2789
2790         - Make script quiet by default and add --verbose option (replacing --quiet).
2791         - When not verbose, pipe stdout and stderr to devnull.
2792
2793         * Scripts/run-api-tests:
2794
2795 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2796
2797         Unreviewed. Adding myself to committers.py.
2798
2799         * Scripts/webkitpy/common/config/committers.py:
2800
2801 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2802
2803         Reviewed by Xan Lopez.
2804
2805         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2806         https://bugs.webkit.org/show_bug.cgi?id=51806
2807
2808         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2809         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2810         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2811         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2812         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2813         so make it 'WebKitBuild/Release/.libs'
2814
2815         * Scripts/webkitdirs.pm: 
2816
2817 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2818
2819         Reviewed by Adam Barth.
2820
2821         Make EFL a core builder
2822         https://bugs.webkit.org/show_bug.cgi?id=51804
2823
2824         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2825         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2826
2827 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2828
2829         [Qt] Unreviewed fix after r74855 and r74875.
2830
2831         * BuildSlaveSupport/built-product-archive:
2832          - Create directories explicitly.
2833          - Pass shell=True to subprocess.call().
2834
2835 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2836
2837         [Qt] Unreviewed fix after r74855.
2838
2839         Move JavaScriptCore to Source
2840         https://bugs.webkit.org/show_bug.cgi?id=51604
2841
2842         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2843
2844 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2845
2846         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2847
2848         Move JavaScriptCore to Source
2849         https://bugs.webkit.org/show_bug.cgi?id=51604
2850
2851         * Scripts/webkitdirs.pm:
2852
2853 2011-01-02  Robert Hogan  <robert@webkit.org>
2854
2855         Unreviewed, build fix.
2856
2857         [Qt] Fix DRT build after 74855
2858
2859         * DumpRenderTree/qt/DumpRenderTree.pro:
2860
2861 2011-01-01  Adam Barth  <abarth@webkit.org>
2862
2863         Remove the assumption from the Qt and Gtk builds that every project is
2864         in the root directory.
2865
2866         * Scripts/build-webkit:
2867
2868 2011-01-01  Adam Barth  <abarth@webkit.org>
2869
2870         Reviewed by Eric Seidel.
2871
2872         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2873         https://bugs.webkit.org/show_bug.cgi?id=51796
2874
2875         After this change, svn-apply will magically apply patches to
2876         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2877
2878         * Scripts/VCSUtils.pm:
2879
2880 2011-01-01  Adam Barth  <abarth@webkit.org>
2881
2882         Reviewed by Eric Seidel.
2883
2884         Move JavaScriptCore to Source
2885         https://bugs.webkit.org/show_bug.cgi?id=51604
2886
2887         Update references to JavaScriptCore to point to the new location.
2888
2889         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2890         * DumpRenderTree/qt/DumpRenderTree.pro:
2891         * DumpRenderTree/qt/ImageDiff.pro:
2892         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2893         * DumpRenderTree/wscript:
2894         * Scripts/build-jsc:
2895         * Scripts/build-webkit:
2896         * Scripts/do-file-rename:
2897         * Scripts/do-webcore-rename:
2898         * Scripts/run-javascriptcore-tests:
2899         * Scripts/update-javascriptcore-test-results:
2900         * Scripts/webkitdirs.pm:
2901         * Scripts/webkitpy/common/config/build_unittest.py:
2902         * Scripts/webkitpy/style/checker.py:
2903         * Scripts/webkitpy/style/checker_unittest.py:
2904         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2905         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2906         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2907         * wx/build/settings.py:
2908
2909 2011-01-01  Adam Barth  <abarth@webkit.org>
2910
2911         Reviewed by Eric Seidel.
2912
2913         Move Sources to Source
2914         https://bugs.webkit.org/show_bug.cgi?id=51794
2915
2916         Update scripts to point to the new location.
2917
2918         * Scripts/build-webkit:
2919         * Scripts/do-file-rename:
2920         * Scripts/do-webcore-rename:
2921         * Scripts/webkitpy/common/config/build.py:
2922         * Scripts/webkitpy/common/config/build_unittest.py:
2923
2924 2010-12-31  Kent Tamura  <tkent@chromium.org>
2925
2926         Reviewed by Eric Seidel.
2927
2928         [DRT/Chromium] Enable mock spell checker on non-OSX
2929         https://bugs.webkit.org/show_bug.cgi?id=51401
2930
2931         * DumpRenderTree/chromium/WebViewHost.cpp:
2932         (WebViewHost::spellCheck):
2933
2934 2010-12-31  Adam Barth  <abarth@webkit.org>
2935
2936         Reviewed by Ariya Hidayat.
2937
2938         Remove Tools/Scripts/wkstyle
2939         https://bugs.webkit.org/show_bug.cgi?id=51774
2940
2941         This script appears to not have been touched in a while and seems to
2942         have been replaced by check-webkit-style.
2943
2944         * Scripts/wkstyle: Removed.
2945
2946 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2947
2948         Unreviewed. Coding style fix.
2949
2950         * DumpRenderTree/chromium/TestShell.h:
2951
2952 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2953
2954         Reviewed by Pavel Feldman.
2955
2956         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2957
2958         It was a problem with Chromium DRT. DevToolsAgent object instance was
2959         attached not only to the inspected page but to the DevTools window too.
2960         As result all the inspector files were interpreted as a content of inspected page
2961         and were transfered to the DevTools scripts panel for debugging etc.
2962
2963         https://bugs.webkit.org/show_bug.cgi?id=51735
2964
2965         * DumpRenderTree/chromium/TestShell.cpp:
2966         (TestShell::TestShell):
2967         (TestShell::bindJSObjectsToWindow):
2968         (TestShell::createNewWindow):
2969         * DumpRenderTree/chromium/TestShell.h:
2970
2971 2010-12-31  Adam Barth  <abarth@webkit.org>
2972
2973         Rubber-stamped by Eric Seidel.
2974
2975         Move PageLoadTests to PerformanceTests/PageLoad
2976         https://bugs.webkit.org/show_bug.cgi?id=51771
2977
2978         Update references to PageLoadTests to point to the new location.
2979
2980         * Scripts/run-pageloadtest:
2981         * Scripts/webkitpy/common/config/build.py:
2982
2983 2010-12-31  Adam Barth  <abarth@webkit.org>
2984
2985         Rubber-stamped by Eric Seidel.
2986
2987         Move SunSpider into PerformanceTests
2988         https://bugs.webkit.org/show_bug.cgi?id=51769
2989
2990         Update these scripts to point to the new location.
2991
2992         * Scripts/run-sunspider:
2993         * Scripts/sunspider-compare-results:
2994
2995 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2996
2997         Reviewed by Kent Tamura.
2998
2999         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3000         https://bugs.webkit.org/show_bug.cgi?id=51728
3001         
3002         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3003         to render top-level scrollbars. This makes them match the Mac port's
3004         use of an NSScrollView, which means that we'll be able to share more
3005         pixel baselines.
3006         
3007         The new rendering code will not be activated until the 
3008         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3009         ScrollbarThemeChromiumMac.
3010
3011         * DumpRenderTree/DumpRenderTree.gypi:
3012         * DumpRenderTree/chromium/TestShellMac.mm:
3013         (platformInit):
3014         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3015         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3016         (+[FakeActiveWindow alwaysActiveWindow]):
3017         (+[FakeActiveWindow alwaysInactiveWindow]):
3018         (-[FakeActiveWindow initWithActiveControls:]):
3019         (-[FakeActiveWindow _hasActiveControls]):
3020         (WebThemeEngineDRTMac::paintScrollbarThumb):
3021         (stateToHIEnableState):
3022         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3023         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3024
3025 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3026
3027         Reviewed by David Kilzer.
3028
3029         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3030         used
3031         https://bugs.webkit.org/show_bug.cgi?id=51672
3032
3033         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3034         with USE_SYSTEM_MALLOC=1
3035         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3036         with USE_SYSTEM_MALLOC=1
3037
3038 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3039
3040         Reviewed by David Kilzer.
3041
3042         [Qt] [Symbian] Fix build-webkit script for Symbian
3043         https://bugs.webkit.org/show_bug.cgi?id=51509
3044
3045         Set the OUTPUT_DIR for Symbian to be the same as the source
3046         directory.
3047
3048         * Scripts/webkitdirs.pm:
3049
3050 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3051
3052         Reviewed by Darin Adler.
3053
3054         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3055         https://bugs.webkit.org/show_bug.cgi?id=51758
3056
3057         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3058
3059         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3060         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3061
3062 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3063
3064         Unreviewed WinCE buildfix.
3065
3066         * WinCELauncher/main.cpp: Add missing include.
3067
3068 2010-12-29  Daniel Bates  <dbates@rim.com>
3069
3070         Reviewed by Darin Adler.
3071
3072         svn-apply updates date of wrong change log entry for a change log diff that
3073         contains two consecutive entries with the same author and date
3074         https://bugs.webkit.org/show_bug.cgi?id=46061
3075
3076         Fixes an issue where the date of the wrong change log entry may be modified.
3077         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3078         in a ChangeLog file to the top of the file.
3079
3080         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3081         diff when it detects that the diff inserts a change log entry earlier in a
3082         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3083         change. With the advent of the commit-queue this functionality of bailing out
3084         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3085         Instead, we should always move the change log entry to the top of the ChangeLog file.
3086
3087         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3088         the date line of the correct change log entry in a ChangeLog diff.
3089
3090         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3091
3092         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3093           Updated the following unit tests now that we move entries inserted earlier to the top:
3094           - "fixChangeLogPatch: New entry inserted in middle."
3095             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3096
3097           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3098             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3099
3100         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3101
3102 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3103
3104         Reviewed by Eric Seidel.
3105
3106         [Qt] Fixed compatibility with gold linker on X11 platforms
3107         https://bugs.webkit.org/show_bug.cgi?id=51700
3108
3109         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3110         Linked TestNetscapePlugin with libX11 on Unix platforms
3111
3112 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3113
3114         Reviewed by Darin Adler.
3115
3116         Circular dependency in webkitpy.common.checkout.changelog module
3117         https://bugs.webkit.org/show_bug.cgi?id=50475
3118
3119         Remove automatic import of api.Checkout module when any checkout/
3120         submodule is imported (e.g.: when checkout.scm.Git is imported).
3121
3122         * Scripts/webkitpy/common/checkout/__init__.py:
3123
3124 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3125
3126         Reviewed by Ojan Vafai.
3127
3128         prepare-ChangeLog should support the -g option for specifying the git-commit
3129         https://bugs.webkit.org/show_bug.cgi?id=51708
3130
3131         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3132         webkit-patch, though the exact meaning of the two options remain different.
3133
3134         * Scripts/prepare-ChangeLog: Add -g.
3135
3136 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3137
3138         Reviewed by Simon Hausmann.
3139
3140         [Qt] Fix compilation with Qt in namespace
3141         https://bugs.webkit.org/show_bug.cgi?id=51701
3142
3143         * QtTestBrowser/webview.h:
3144
3145 2010-12-28  Daniel Bates  <dbates@rim.com>
3146
3147         Reviewed by Sam Weinig.
3148
3149         Substitute // MARK: for compiler-specific #pragma mark
3150         https://bugs.webkit.org/show_bug.cgi?id=51657
3151
3152         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3153         substituting  "// MARK:" for "#pragma mark", which provides
3154         analogous code-bookmarking functionality under Xcode.
3155
3156         Also, for consistency, we should substitute "// MARK:" for compiler-
3157         specific "#pragma mark" in the source files for the Mac port.
3158
3159         * DumpRenderTree/AccessibilityTextMarker.cpp:
3160         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3161         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3162         * DumpRenderTree/mac/ObjCController.m:
3163         * MiniBrowser/mac/AppDelegate.m:
3164         * MiniBrowser/mac/BrowserWindowController.m:
3165
3166 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3167
3168         Reviewed by Eric Seidel.
3169
3170         Add --no-build option to run-sunspider
3171         https://bugs.webkit.org/show_bug.cgi?id=51658
3172
3173         * Scripts/run-sunspider: add --no-build flag to skip building
3174         phase.
3175
3176 2010-12-27  Daniel Bates  <dbates@rim.com>
3177
3178         Rubber-stamped by Martin Robinson.
3179
3180         Append the directory Tools/DumpRenderTree to the list of directories that
3181         do-webcore-rename should search so that it can rename DRT files and
3182         source code.
3183
3184         * Scripts/do-webcore-rename:
3185
3186 2010-12-27  Eric Seidel  <eric@webkit.org>
3187
3188         Reviewed by Adam Barth.
3189
3190         build-webkit should detect missing Java SDK and explain how to install it
3191         https://bugs.webkit.org/show_bug.cgi?id=51651
3192
3193         * Scripts/build-webkit:
3194
3195 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3196
3197         Reviewed by Daniel Bates.
3198
3199         [GTK] Add support for build-jsc
3200         https://bugs.webkit.org/show_bug.cgi?id=51625
3201
3202         Add GTK+ support to build-jsc now that building the jsc executable as
3203         a standalone target is easy.
3204
3205         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3206         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3207         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3208         and pass it along to buildAutotoolsProject.
3209
3210 2010-12-27  David Levin  <levin@chromium.org>
3211
3212         Reviewed by Eric Seidel.
3213
3214         check-webkit-style check for meaningless variable names in function declarations.
3215         https://bugs.webkit.org/show_bug.cgi?id=51523
3216
3217         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3218         from the new check and whitespace/parens because the syntax is unusual and
3219         produced a fair number of positives for these checks.
3220         * Scripts/webkitpy/style/checkers/cpp.py:
3221         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3222         and parameter names when determining if the parameter name is useless.
3223         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3224         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3225         format.
3226         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3227         text or an acronym of it.
3228         (check_function_definition): Checks function definitions for meaningless variable names.
3229         (process_line): Added call to check_function_definition.
3230         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3231         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3232         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3233         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3234         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3235         because when only checking a snippet, there are a lot of bogus functions.
3236         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3237         that I put there previously and just noticed.
3238         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3239         check_function_definition and process_line.
3240
3241 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3242
3243         Reviewed by Martin Robinson.
3244
3245         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3246         https://bugs.webkit.org/show_bug.cgi?id=51591
3247
3248         Flash plugin uses gtk2 that is incompatible with gtk3 making
3249         webkit crash when it's built with gtk3.
3250
3251         * GtkLauncher/main.c:
3252         (main):
3253
3254 2010-12-25  Adam Barth  <abarth@webkit.org>
3255
3256         Reviewed by Eric Seidel.
3257
3258         Move ANGLE to Sources/ThirdParty
3259         https://bugs.webkit.org/show_bug.cgi?id=51605
3260
3261         * Scripts/build-webkit:
3262           - Point to the new ANGLE location.
3263
3264 2010-12-26  David Levin  <levin@chromium.org>
3265
3266         Reviewed by Eric Seidel.
3267
3268         check-webkit-style should be able to parse function declaration parameters.
3269         https://bugs.webkit.org/show_bug.cgi?id=51451
3270
3271         * Scripts/webkitpy/style/checkers/cpp.py:
3272         (Position.__init__): Holds simple position information (row, column).
3273         (Parameter.__init__): Holds information about a parameter.
3274         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3275         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3276         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3277         (find_parameter_name_index): Finds where the parameter name is.
3278         (parameter_list): Generates the list of parameters for a function.
3279         (_FunctionState.begin): Added information to allow determining the parameters
3280         on demand.
3281         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3282         (detect_functions): Improve function detection for operator functions and
3283         determine where the parameters end and pass that to _FunctionState.begin.
3284         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3285         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3286         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3287         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3288         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3289         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3290         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3291         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3292         the parameters found.
3293         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3294         detection test to verify that we catch the operator functions.
3295         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3296         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3297         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3298         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3299         test_function_length_check_definition_severity1_for_test.
3300
3301 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3302
3303         Unreviewed WinCE buildfix after r74334.
3304
3305         * CMakeListsWinCE.txt:
3306
3307 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3308
3309         Unreviewed, rolling out r74632.
3310         http://trac.webkit.org/changeset/74632
3311         https://bugs.webkit.org/show_bug.cgi?id=51600
3312
3313         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3314         on #webkit).
3315
3316         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3317         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3318
3319 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3320
3321         Reviewed by Kenneth Rohde Christiansen.
3322
3323         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3324         https://bugs.webkit.org/show_bug.cgi?id=43528
3325
3326         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3327         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3328         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3329         called.
3330
3331         * EWebLauncher/main.c:
3332         (browserCreate):
3333
3334 2010-12-24  Eric Seidel  <eric@webkit.org>
3335
3336         Reviewed by Adam Barth.
3337
3338         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3339         https://bugs.webkit.org/show_bug.cgi?id=28291
3340
3341         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3342         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3343         to strings with find in the diff.
3344         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3345
3346         * Scripts/webkitpy/common/checkout/api.py:
3347         * Scripts/webkitpy/common/checkout/diff_parser.py:
3348         * Scripts/webkitpy/tool/steps/abstractstep.py:
3349         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3350         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3351         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3352         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3353
3354 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3355
3356         Reviewed by Kenneth Russell.
3357
3358         Modify new-run-webkit-tests to shut up and exit when all the threads
3359         are wedged so that test runs complete faster and we don't end up
3360         w/ enormous log files.
3361
3362         https://bugs.webkit.org/show_bug.cgi?id=51572
3363
3364         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3365         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3366
3367 2010-12-24  Eric Seidel  <eric@webkit.org>
3368
3369         Reviewed by David Levin.
3370
3371         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3372         https://bugs.webkit.org/show_bug.cgi?id=51549
3373
3374         I've had multiple people ask me about the commit-queue's behavior
3375         regarding reporting flaky tests.  I figured it would be best to just
3376         have the queue explain itself in the bugs it files.
3377
3378         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3379         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3380
3381 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3382
3383         Reviewed by Eric Seidel.
3384
3385         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3386         https://bugs.webkit.org/show_bug.cgi?id=51467
3387
3388         * Scripts/webkitpy/style/checker.py:
3389         * Scripts/webkitpy/style/checker_unittest.py:
3390
3391 2010-12-23  Adam Barth  <abarth@webkit.org>
3392
3393         Rubber-stamped by Eric Seidel.
3394
3395         Move JavaScriptGlue into Sources
3396         https://bugs.webkit.org/show_bug.cgi?id=51583
3397
3398         These tools refer to JavaScriptGlue and need to be updated to its new
3399         location.
3400
3401         * Scripts/build-webkit:
3402         * Scripts/do-file-rename:
3403         * Scripts/do-webcore-rename:
3404         * Scripts/webkitpy/common/config/build.py:
3405         * Scripts/webkitpy/common/config/build_unittest.py:
3406
3407 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3408
3409         Reviewed by Eric Seidel.
3410
3411         Bug 51539 - update iexploder scripts to point to new location
3412
3413         * Scripts/run-iexploder-tests:
3414         * Scripts/update-iexploder-cssproperties:
3415
3416 2010-12-23  Evan Martin  <evan@chromium.org>
3417
3418         Reviewed by Ryosuke Niwa.
3419
3420         [chromium] LayoutTestController warning in float->int conversion
3421         https://bugs.webkit.org/show_bug.cgi?id=51553
3422
3423         Rather than reading an int, converting to a float, then getting a compiler
3424         warning on passing the float to something that expects an int, instead
3425         just pass around ints.
3426
3427         No tests, fixes a compiler warning.
3428
3429         * DumpRenderTree/chromium/LayoutTestController.cpp:
3430         (parsePageSizeParameters):
3431         (LayoutTestController::pageNumberForElementById):
3432         (LayoutTestController::numberOfPages):
3433
3434 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3435
3436         Reviewed by Darin Adler.
3437
3438         Bug 51537 - iexploder needs cleanup
3439         
3440         * iExploder/htdocs: Removed.
3441         * iExploder/htdocs/config.rb: Removed.
3442         * iExploder/htdocs/cssproperties.in: Removed.
3443         * iExploder/htdocs/cssvalues.in: Removed.
3444         * iExploder/htdocs/htmlattrs.in: Removed.
3445         * iExploder/htdocs/htmltags.in: Removed.
3446         * iExploder/htdocs/htmlvalues.in: Removed.
3447         * iExploder/htdocs/iexploder.cgi: Removed.
3448         * iExploder/htdocs/iexploder.rb: Removed.
3449         * iExploder/htdocs/index.html: Removed.
3450         * iExploder/htdocs/webserver.rb: Removed.
3451         * iExploder/iexploder-1.7.2/output: Removed.
3452         * iExploder/tools: Removed.
3453         * iExploder/tools/lasthit.rb: Removed.
3454         * iExploder/tools/osx_last_crash.rb: Removed.
3455         * iExploder/tools/showtest.rb: Removed.
3456
3457 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3458
3459         Reviewed by Kenneth Rohde Christiansen.
3460
3461         [EFL] Make 'single' the default backing store in EWebLauncher
3462         https://bugs.webkit.org/show_bug.cgi?id=51534
3463
3464         'single' is the simplest backing store and the one intended to be the
3465         default in the test browser. By mistake the tiled backing store was
3466         left as default in r72617.
3467
3468         * EWebLauncher/main.c:
3469         (browserCreate): ditto.
3470
3471 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3472
3473         Reviewed by Kenneth Rohde Christiansen.
3474
3475         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3476         https://bugs.webkit.org/show_bug.cgi?id=51533
3477
3478         There's no point in concatenating env("HOME") with "blah", so remove
3479         option from EWebLauncher.
3480
3481         * EWebLauncher/main.c:
3482         (main): ditto.
3483
3484 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3485
3486         Reviewed by Eric Seidel.
3487
3488         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3489
3490         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3491         I just discovered that we have two additional GC runs per each WebViewHost.
3492         Test_shell had no such calls.
3493         These gc runs eat 15% of cpu time.
3494
3495         https://bugs.webkit.org/show_bug.cgi?id=51479
3496
3497         * DumpRenderTree/chromium/WebViewHost.cpp:
3498         (WebViewHost::~WebViewHost):
3499
3500 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3501
3502         Reviewed by Ojan Vafai.
3503
3504         This change splits out the TestRunner class into its own file.
3505         When we fork the code for message passing, we will create a new
3506         TestRunner, and this change will allow that to be more modular.
3507
3508         While we're at it, split out TestInput and ResultSummary into
3509         their own files, to reduce the size of run_webkit_tests to
3510         something more managable.
3511
3512         https://bugs.webkit.org/show_bug.cgi?id=51092
3513
3514         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3515         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3516         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3517         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3518         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3520         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3521
3522  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3523
3524         Reviewed by Ojan Vafai.
3525
3526         nrwt multiprocessing - start over, prepare to fork the code
3527  
3528         This code cleans up the signatures and implementation of the
3529         TestRunner class so we can easily fork it to run either the
3530         stable implementation or the new, unstable message-passing
3531         implementation. The two variants will have different
3532         implementations of the run_tests() method. We will switch
3533         between the two based on the setting for the '--worker-model'
3534         switch. We rename the two currently valid values to 'old-inline'
3535         and 'old-threads'.
3536
3537         https://bugs.webkit.org/show_bug.cgi?id=51081
3538
3539         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3540         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3541
3542 2010-12-22  Victor Wang  <victorw@chromium.org>
3543
3544         Reviewed by Darin Fisher.
3545
3546         [Chromium] Update chromium archive test result url in rebaseline script.
3547
3548         https://bugs.webkit.org/show_bug.cgi?id=51503
3549
3550         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3551
3552 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3553
3554         Reviewed by Alice Liu.
3555
3556         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3557         Verified on Chrome, Safari, and IE.
3558         With this change, we will record memory from a parent browser window and all child processes.
3559
3560         * record-memory-win/main.cpp:
3561         (ProcessArgs):
3562         (PrintUsage):
3563         (getMemoryInfo):
3564         (printProcessInfo):
3565         (evalProcesses):
3566         (UseImage):
3567         (QueryContinuously):
3568         (ElapsedTime):
3569
3570 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3571
3572         Unreviewed rollout r74489, because it was missing changelog.
3573
3574         * record-memory-win/main.cpp:
3575         
3576 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3577
3578         Adding myself as a reviewer.
3579
3580         * Scripts/webkitpy/common/config/committers.py:
3581
3582 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3583
3584         Unreviewed.  Adding myself to committers.py.
3585
3586         * Scripts/webkitpy/common/config/committers.py:
3587
3588 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3589
3590         Reviewed by Kenneth Rohde Christiansen.
3591
3592         TestNetscapePlugIn should use #if defined
3593         https://bugs.webkit.org/show_bug.cgi?id=51471
3594
3595         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3596         (NP_Initialize):
3597         (NPP_New):
3598
3599 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3600
3601         Reviewed by Yury Semikhatsky.
3602
3603         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3604
3605         DevTools window should be closed explicitly because it has custom deinitialization code.
3606
3607         https://bugs.webkit.org/show_bug.cgi?id=50722
3608
3609         * DumpRenderTree/chromium/TestShell.cpp:
3610         (TestShell::closeRemainingWindows):
3611
3612 2010-12-22  David Levin  <levin@chromium.org>
3613
3614         Reviewed by Shinichiro Hamaji.
3615
3616         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3617         https://bugs.webkit.org/show_bug.cgi?id=51452
3618
3619         * Scripts/webkitpy/style/checkers/cpp.py:
3620         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3621         Using the file extension if possible but falling back to the file contents if we have a header file.
3622         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3623         (_FileState.is_c_or_objective_c):
3624         (check_using_std): Changed to using _FileState to determine the file type.
3625         (check_max_min_macros): Ditto.
3626         (check_for_null): Ditto.
3627         (check_style): Changed the parameters to various calls since they now need _FileState
3628         to determine the file type.
3629         (check_language): Added the file_state parameter so it could be passed
3630         to check_identifier_name_in_declaration.
3631         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3632         this is an Objective C file.
3633         (_process_lines): Added information for the _FileState constructor (and moved the
3634         call to a place that had the information).
3635         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3636         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3637         its functionality.
3638         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3639
3640 2010-12-21  Andy Estes  <aestes@apple.com>
3641
3642         Reviewed by Mark Rowe.
3643
3644         Do not build non-Intel architectures for WebKit2-related projects.
3645         https://bugs.webkit.org/show_bug.cgi?id=51440
3646
3647         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3648         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3649         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3650
3651 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3652
3653         Reviewed by Darin Fisher.
3654
3655         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3656         https://bugs.webkit.org/show_bug.cgi?id=51406 
3657         
3658         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3659         to WebThemeEngineDRTWin and update references everywhere.
3660
3661         * DumpRenderTree/DumpRenderTree.gypi:
3662         * DumpRenderTree/chromium/TestShellWin.cpp:
3663         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3664         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3665         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3666         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3667
3668 2010-12-21  Anders Carlsson  <andersca@apple.com>
3669
3670         Reviewed by John Sullivan.
3671
3672         Clicking missing plug-in text does not show a sheet
3673         https://bugs.webkit.org/show_bug.cgi?id=51403
3674
3675         Update for changes to the WebPageUIClient.
3676
3677         * MiniBrowser/mac/BrowserWindowController.m:
3678         (-[BrowserWindowController awakeFromNib]):
3679         * WebKitTestRunner/TestController.cpp:
3680         (WTR::createOtherPage):
3681         (WTR::TestController::initialize):
3682
3683 2010-12-21  Eric Seidel  <eric@webkit.org>
3684
3685         Reviewed by Adam Barth.
3686
3687         commit-queue will report constant failures as flaky if other tests flake
3688         https://bugs.webkit.org/show_bug.cgi?id=51272
3689
3690         This patch just removes functionality and adds testing.
3691         Previously we attempted to report flaky tests when we had
3692         two different tests fail in a row.  However, since we stop
3693         running the tests at the first failure, our code was wrong in
3694         trying to determine flakiness from the incomplete runs.
3695
3696         Originally I posted an alternate patch:
3697         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3698         which fixed our flaky logic in this case, however it was decided
3699         that that patch would be too difficult to maintain, so now
3700         I'm just removing the broken logic.
3701
3702         This will dramatically cut-down on our flaky-test false positives
3703         at the (small) cost of the queues being unable to report
3704         any flakiness if the tree is very flaky.  (With at least one test
3705         flaking on every run, we'll never report failures anymore.)  I think
3706         this is a tradeoff worth making.
3707
3708         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3709         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3710
3711 2010-12-20  Eric Seidel  <eric@webkit.org>
3712
3713         Reviewed by Adam Barth.
3714
3715         commit-queue wrongly rejects patches when it can't update itself
3716         https://bugs.webkit.org/show_bug.cgi?id=46636
3717
3718         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3719         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3720         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3721
3722 2010-12-20  Adam Barth  <abarth@webkit.org>
3723
3724         Move web sites to Websites directory
3725         https://bugs.webkit.org/show_bug.cgi?id=51323
3726
3727         Update references to BugsSite to point to the new location.
3728
3729         This patch was never officially reviewed (because it was too large to
3730         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3731         Rowe gave me the green light.
3732
3733         * Scripts/old-run-webkit-tests:
3734         * Scripts/webkitpy/common/config/build.py:
3735         * Scripts/webkitpy/common/config/build_unittest.py:
3736         * Scripts/webkitpy/common/prettypatch.py:
3737         * Scripts/webkitpy/layout_tests/port/base.py:
3738         * Scripts/webkitpy/style/main.py:
3739
3740 2010-12-20  Adrienne Walker  <enne@google.com>
3741
3742         Unreviewed. Adding myself to the list of committers.
3743
3744         * webkitpy/common/config/committers.py:
3745
3746 2010-12-20  Mark Rowe  <mrowe@apple.com>
3747
3748         Reviewed by Dan Bernstein.
3749
3750         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3751
3752         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3753         Resources directory.
3754
3755 2010-12-20  Eric Seidel  <eric@webkit.org>
3756
3757         Reviewed by Adam Barth.
3758
3759         commit-queue should include bot id when attaching failure diffs
3760         https://bugs.webkit.org/show_bug.cgi?id=51280
3761
3762         This is a tiny change to include the bot id in the name of the attachment.
3763         Most of this diff is just changing the unit test expectations
3764         now that I hid the comment printing when the comment is None.
3765
3766         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3767         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3768         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3769         * Scripts/webkitpy/tool/mocktool.py:
3770
3771 2010-12-20  Jeff Miller  <jeffm@apple.com>
3772
3773         Reviewed by Dan Bernstein.
3774
3775         Tools/vcbin/midl.exe needs to be rebuilt
3776         https://bugs.webkit.org/show_bug.cgi?id=51347
3777
3778         * vcbin/midl.exe: Rebuilt.
3779
3780 2010-12-20  David Levin  <levin@chromium.org>
3781
3782         Reviewed by Ariya Hidayat.
3783
3784         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3785         https://bugs.webkit.org/show_bug.cgi?id=51343
3786
3787         Follow up from the WebKitTools -> Tools rename.
3788
3789         * Scripts/webkit-tools-completion.sh:
3790
3791 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3792
3793         Reviewed by James Robinson.
3794
3795         new-run-webkit-tests ignores trailing EOL differences in text tests
3796         https://bugs.webkit.org/show_bug.cgi?id=36983
3797
3798         Changed the handling of new-line characters within new-run-webkit-tests
3799         to match old-run-webkit-tests.  Differences in leading and trailing empty
3800         lines in text expectation files are no longer ignored.
3801
3802         * Scripts/webkitpy/layout_tests/port/base.py:
3803         * Scripts/webkitpy/layout_tests/port/test.py:
3804         Added unit tests.  Removed old duplicate unit test entries.
3805         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3806
3807 2010-12-20  David Levin  <levin@chromium.org>
3808
3809         Reviewed by Shinichiro Hamaji.
3810
3811         check-webkit-style should detect function declarations (and trivial functions).
3812         https://bugs.webkit.org/show_bug.cgi?id=51303
3813
3814         * Scripts/webkitpy/style/checkers/cpp.py:
3815         (_FunctionState.begin): Add is_declaration and changed the line count
3816         start to begin at -1 (which will keep the results consistent, since
3817         the starting line number passed in is one less in this change).
3818         (detect_functions): changed function detection to now catch trivial
3819         functions and declarations.
3820         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3821         of the function as this may look at return values (when processing
3822         a declaration).
3823         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3824         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3825         of testing the function detection.
3826         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3827         function.
3828         (FunctionDetectionTest.test_function_declaration_detection): Test a
3829         declaration.
3830         (FunctionDetectionTest.test_non_functions): A test case for a case
3831         that caused the code to fail due to the { being in quotes.
3832         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3833         cases to help catch false alarms for return values.
3834         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3835         we don't get false alarms for member variables either.
3836
3837 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3838
3839         Reviewed by Antonio Gomes.
3840
3841         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3842         https://bugs.webkit.org/show_bug.cgi?id=51319
3843
3844         * CMakeListsEfl.txt:
3845
3846 2010-12-18  Adam Barth  <abarth@webkit.org>
3847
3848         Reviewed by Sam Weinig.
3849
3850         Move WebKitExamplePlugins to Examples
3851         https://bugs.webkit.org/show_bug.cgi?id=51291
3852
3853         * Scripts/webkitpy/common/config/build.py:
3854
3855 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3856
3857         Unreviewed Qt buildfix after r74301.
3858
3859         Rename WebKitTools to Tools
3860         https://bugs.webkit.org/show_bug.cgi?id=49861
3861
3862         * MiniBrowser/DerivedSources.pro:
3863         * MiniBrowser/qt/MiniBrowser.pro:
3864
3865 2010-12-17  Dan Bernstein  <mitz@apple.com>
3866
3867         Reviewed by Simon Fraser.
3868
3869         Rename WebKitTools to Tools
3870         https://bugs.webkit.org/show_bug.cgi?id=49861
3871
3872         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3873         * CodeCoverage/README:
3874         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3875         (WebCore::DumpRenderTree::initializeFonts):
3876         * EWSTools/start-commit-queue.sh:
3877         * EWSTools/start-queue.sh:
3878         * GNUmakefile.am:
3879         * MIDLWrapper/MIDLWrapper.cpp:
3880         (wmain):
3881         * MiniBrowser/qt/MiniBrowser.pro:
3882         * Scripts/build-api-tests:
3883         * Scripts/build-dumprendertree:
3884         * Scripts/build-webkit:
3885         * Scripts/build-webkittestrunner:
3886         * Scripts/generate-coverage-data:
3887         * Scripts/old-run-webkit-tests:
3888         * Scripts/run-api-tests:
3889         * Scripts/run-iexploder-tests:
3890         * Scripts/run-javascriptcore-tests:
3891         * Scripts/run-mangleme-tests:
3892         * Scripts/run-sunspider:
3893         * Scripts/run-webkit-websocketserver:
3894         * Scripts/sunspider-compare-results:
3895         * Scripts/test-webkitperl:
3896         * Scripts/test-webkitpy:
3897         * Scripts/update-iexploder-cssproperties:
3898         * Scripts/update-webkit:
3899         * Scripts/update-webkit-localizable-strings:
3900         * Scripts/webkitdirs.pm:
3901         * Scripts/webkitpy/common/checkout/scm.py:
3902         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3903         * Scripts/webkitpy/common/config/committervalidator.py:
3904         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3905         * Scripts/webkitpy/common/config/ports.py:
3906         * Scripts/webkitpy/common/config/ports_unittest.py:
3907         * Scripts/webkitpy/common/system/logutils_unittest.py:
3908         * Scripts/webkitpy/common/system/ospath_unittest.py:
3909         * Scripts/webkitpy/layout_tests/port/chromium.py:
3910         * Scripts/webkitpy/layout_tests/port/config.py:
3911         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3912         * Scripts/webkitpy/layout_tests/port/http_server.py:
3913         * Scripts/webkitpy/layout_tests/port/test.py:
3914         * Scripts/webkitpy/style/checker.py:
3915         * Scripts/webkitpy/style/checker_unittest.py:
3916         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3917         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3918         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3919         * WebKitTestRunner/DerivedSources.pro:
3920         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3921         (WTR::activateFonts):
3922         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3923         * wx/build/build_utils.py:
3924
3925 2010-12-16  Antonio Gomes  <agomes@rim.com>
3926
3927         Reviewed by Martin Robinson.
3928
3929         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3930         https://bugs.webkit.org/show_bug.cgi?id=51163
3931
3932         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3933         GTK+'s DRT should also reset to UNIX after each test execution.
3934
3935         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3936         (resetDefaultsToConsistentValues):
3937
3938 2010-12-17  David Levin  <levin@chromium.org>
3939
3940         Reviewed by Eric Seidel.
3941
3942         check-webkit-style should understand WTF #include guards
3943         https://bugs.webkit.org/show_bug.cgi?id=44911
3944
3945         * Scripts/webkitpy/style/checkers/cpp.py:
3946         (get_header_guard_cpp_variable): modify to suggest the WTF style
3947         of header guard when appropriate.
3948         (check_for_header_guard): handle multiple return values from
3949         get_header_guard_cpp_variable
3950         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3951         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3952         header style.
3953
3954 2010-12-16  David Levin  <levin@chromium.org>
3955
3956         Reviewed by Eric Seidel.
3957
3958         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3959         https://bugs.webkit.org/show_bug.cgi?id=51210
3960
3961         The error only shows up when using python 2.6 or later.
3962
3963         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3964         the decprecated field error,message with something equivalent.
3965
3966 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3967
3968         Reviewed by Eric Seidel.
3969
3970         Add --exit-after-n-failures/crashes to NRWT
3971         https://bugs.webkit.org/show_bug.cgi?id=51160
3972         
3973         Abort test run (in a similar way to how control-C is handled) when
3974         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3975         that number of unexpected failures/crashes/timeouts.
3976
3977         * Scripts/webkitpy/layout_tests/port/test.py:
3978         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3979         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3980
3981 2010-12-16  David Levin  <levin@chromium.org>
3982
3983         Reviewed by Shinichiro Hamaji.
3984
3985         check-webkit-style unit tests has some duplicate boilerplate code.
3986         https://bugs.webkit.org/show_bug.cgi?id=49519
3987
3988         * Scripts/webkitpy/style/checkers/cpp.py:
3989         (update_include_state): Replaced the "io" parameter with the global
3990         configuration _unit_test_config. This allowed not calling into
3991         functions at a low level and also not plumbing through the injection
3992         information through many levels of code.
3993         (check_for_include_what_you_use): Ditto.
3994         (process_file_data): Added the ability to set up the unit test config
3995         to allow for injection.
3996         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3997         (ErrorCollector.__init__): Added support for having a filter for errors.
3998         (ErrorCollector.__call__): Ditto.
3999         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
4000         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
4001         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
4002         functions in the cpp.py with generic processing and a filter that
4003         indicates what errors should be kept.
4004         (CppStyleTestBase.perform_multi_line_lint): Ditto.
4005         (CppStyleTestBase.perform_language_rules_check): Ditto.
4006         (CppStyleTestBase.perform_function_lengths_check): Ditto.
4007         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
4008         (CppStyleTestBase.perform_include_what_you_use): Ditto.
4009         (CppStyleTest.test_multi_line_comments): Added another
4010         error message which applies to the test case.
4011         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
4012         to not have config.h, since it is processed as a header file.
4013         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
4014         style and indentation in checked code.
4015         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
4016         Fixed line number.
4017         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
4018         Ditto.
4019
4020 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4021
4022         Unreviewed, rolling out r74136.
4023         http://trac.webkit.org/changeset/74136
4024         https://bugs.webkit.org/show_bug.cgi?id=51135
4025
4026         r74136 breaks chromium canary bots because some tests are not
4027         rebaselined correctly to resolve EOL differences (Requested by
4028         jianli on #webkit).
4029
4030         * Scripts/webkitpy/layout_tests/port/base.py:
4031         * Scripts/webkitpy/layout_tests/port/test.py:
4032         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4033
4034 2010-12-15  Adam Roben  <aroben@apple.com>
4035
4036         Teach check-webkit-style to check .vcproj and .vsprops files for XML
4037         syntax errors
4038
4039         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
4040         XML syntax errors in .vcproj/.vsprops files
4041
4042         Reviewed by Dave Levin.
4043
4044         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
4045         that should be treated as XML and that should be allowed to contain
4046         carriage returns. (These lists happen to be identical currently.)
4047         (FileType): Added a new XML type.
4048         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
4049         Just does a simple file extension check.
4050         (CheckerDispatcher._file_type): Added a case for XML files.
4051         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
4052         files (surprise!).
4053         (StyleProcessor.process): Ask the dispatcher whether we should pass the
4054         lines through the carriage checker.
4055
4056         * Scripts/webkitpy/style/checker_unittest.py:
4057         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
4058         Added. Checks a few file names to see if carriage returns are allowed
4059         or not.
4060         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
4061         other assert_checker_* functions.
4062         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
4063         test_*_paths functions.
4064         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
4065         test_*_paths functions.
4066         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
4067         file from this test case, as vcproj files now have a type.
4068         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
4069         Added. Similar to the other should_* functions.
4070         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
4071         Added. Checks that carriage returns aren't checked for or stripped for
4072         allowed files.
4073
4074         * Scripts/webkitpy/style/checkers/xml.py: Added.
4075         (XMLChecker.__init__): Simple init method.
4076         (XMLChecker.check): Pass each line through the expat parser, and record
4077         a style error for any errors thrown by the parser.
4078
4079         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
4080         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
4081         produce a style error.
4082         (XMLCheckerTest.assert_error): Checks that the given XML produces an
4083         error of the given category on the given line.
4084         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
4085         checking that the XMLChecker constructor works properly.
4086         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
4087         cause a style error (see, e.g., r73887).
4088         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
4089         cause a style error (see, e.g., r73773).
4090         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
4091         properly.
4092         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
4093         tags cause a style error (see, e.g., r72795).
4094         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
4095         style error.
4096
4097 2010-12-15  Lucas Forschler  <lforschler@apple.com>
4098
4099         Reviewed by Stephanie Lewis.
4100
4101         https://bugs.webkit.org/show_bug.cgi?id=51117
4102         Add a new leopard test bot
4103         really really commit to trunk this time.
4104
4105         * BuildSlaveSupport/build.webkit.org-config/config.json:
4106
4107 2010-12-15  Sam Weinig  <sam@webkit.org>
4108
4109         Reviewed by Anders Carlsson.
4110
4111         WebKit2: Can't add files to an <input type=file>
4112         https://bugs.webkit.org/show_bug.cgi?id=51087
4113
4114         * MiniBrowser/mac/BrowserWindowController.m:
4115         (runOpenPanel):
4116         (-[BrowserWindowController awakeFromNib]):
4117         Add simple implementation of runOpenPanel callback.
4118
4119         * MiniBrowser/win/BrowserView.cpp:
4120         (BrowserView::create):
4121         * WebKitTestRunner/TestController.cpp:
4122         (WTR::createOtherPage):
4123         (WTR::TestController::initialize):
4124         Stub out runOpenPanel callback. 
4125
4126 2010-12-14  Eric Seidel  <eric@webkit.org>
4127
4128         Reviewed by Adam Barth.
4129
4130         commit-queue should upload failure diffs when tests flake
4131         https://bugs.webkit.org/show_bug.cgi?id=51051
4132
4133         To make this testable I needed to pipe FileSystem down onto tool.
4134         We've wanted it there for a long time anyway.
4135
4136         This patch is kinda a big hack.  But we don't have a nice
4137         way to read results.html files.  I think this will need further
4138         revision before this code actually feels clean.
4139
4140         As part of testing this change, I had to make MockBugzilla.create_bug
4141         actually return an id (like it should) which required updating
4142         a few other unit test results (for the better).
4143
4144         The results_matching_keys change in layouttestresults/rebasline
4145         was an alternate path which I decided not to use in the end, but
4146         I left the change as it seemed an improvement.
4147
4148         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4149         * Scripts/webkitpy/common/net/layouttestresults.py:
4150         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4151         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4152         * Scripts/webkitpy/tool/commands/queues.py:
4153         * Scripts/webkitpy/tool/commands/rebaseline.py:
4154         * Scripts/webkitpy/tool/main.py:
4155         * Scripts/webkitpy/tool/mocktool.py:
4156
4157 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
4158
4159         Reviewed by James Robinson.
4160
4161         new-run-webkit-tests ignores trailing EOL differences in text tests
4162         https://bugs.webkit.org/show_bug.cgi?id=36983
4163
4164         Changed the handling of new-line characters within new-run-webkit-tests
4165         to match old-run-webkit-tests.  Differences in leading and trailing empty
4166         lines in text expectation files are no longer ignored.
4167
4168         * Scripts/webkitpy/layout_tests/port/base.py:
4169         * Scripts/webkitpy/layout_tests/port/test.py:
4170         Added unit tests.  Removed old duplicate unit test entries.
4171         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4172
4173 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4174
4175         Reviewed by Adam Barth.
4176
4177         make status-bubble white-space:nowrap so we can measure it's width without wrapping
4178         https://bugs.webkit.org/show_bug.cgi?id=51149
4179
4180         * QueueStatusServer/templates/statusbubble.html:
4181
4182 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4183
4184         Reviewed by Adam Barth.
4185
4186         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
4187         https://bugs.webkit.org/show_bug.cgi?id=51125
4188
4189         * QueueStatusServer/templates/statusbubble.html:
4190
4191 2010-12-15  Darin Adler  <darin@apple.com>
4192
4193         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
4194
4195 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4196
4197         Unreviewed, rolling out r74117.
4198         http://trac.webkit.org/changeset/74117
4199         https://bugs.webkit.org/show_bug.cgi?id=51113
4200
4201         This broke the GTK1 build. (Requested by mrobinson on
4202         #webkit).
4203
4204         * Scripts/webkitdirs.pm:
4205
4206 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
4207
4208         Reviewed by Martin Robinson.
4209
4210         Change generate-forwarding-headers.pl for GTK port usage 
4211         (https://bugs.webkit.org/show_bug.cgi?id=37369)
4212
4213         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
4214
4215 2010-12-14  Kent Tamura  <tkent@chromium.org>
4216
4217         Reviewed by Jian Li.
4218
4219         [DRT/Chromium] Remove another unnecessary error message
4220         https://bugs.webkit.org/show_bug.cgi?id=51083
4221
4222         * DumpRenderTree/chromium/WebViewHost.cpp:
4223         (WebViewHost::didInvalidateRect):
4224
4225 2010-12-14  Lucas Forschler  <lforschler@apple.com>
4226
4227         Reviewed by Stephanie Lewis.
4228
4229         Add a new Leopard Debug Test WK2 Bot
4230
4231         * BuildSlaveSupport/build.webkit.org-config/config.json:
4232
4233 2010-12-14  Ojan Vafai  <ojan@chromium.org>
4234
4235         Fix python unittests after http://trac.webkit.org/changeset/74070.
4236
4237         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4238
4239 2010-12-14  Kent Tamura  <tkent@chromium.org>
4240
4241         Reviewed by Jian Li.
4242
4243         [DRT/Chromium] Remove a unnecessary error message
4244         https://bugs.webkit.org/show_bug.cgi?id=51069
4245
4246         * DumpRenderTree/chromium/WebViewHost.cpp:
4247         (WebViewHost::paintInvalidatedRegion):
4248
4249 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
4250
4251         Reviewed by Ojan Vafai.
4252
4253         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
4254         https://bugs.webkit.org/show_bug.cgi?id=48926
4255
4256         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4257         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
4258
4259 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4260
4261         Reviewed by Eric Seidel.
4262
4263         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
4264         https://bugs.webkit.org/show_bug.cgi?id=50231
4265
4266         Guard CONFIG+=link_pkgconfig with !symbian.
4267
4268         * DumpRenderTree/qt/DumpRenderTree.pro:
4269         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4270         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4271
4272 2010-12-14  Philippe Normand  <pnormand@igalia.com>
4273
4274         Reviewed by Ojan Vafai.
4275
4276         [new-run-webkit-tests] expectations parsing is slow
4277         https://bugs.webkit.org/show_bug.cgi?id=50635
4278
4279         Avoid expensive iteration of all the tests when checking if a test
4280         file is to be skipped or not.
4281
4282         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4283         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
4284         * Scripts/webkitpy/layout_tests/port/test.py:
4285
4286 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
4287
4288         Reviewed by Xan Lopez.
4289
4290         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
4291         https://bugs.webkit.org/show_bug.cgi?id=27048
4292
4293         Add support in DRT for checking whether an accessibility UI
4294         element is focusable and/or focused. Implemented for GTK.
4295
4296         * DumpRenderTree/AccessibilityUIElement.cpp:
4297         (getIsFocusedCallback): New.
4298         (getIsFocusableCallback): New.
4299         (AccessibilityUIElement::getJSClass): Add the new available
4300         callbacks for isFocused and isFocusable.
4301         * DumpRenderTree/AccessibilityUIElement.h:
4302         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4303         (AccessibilityUIElement::isFocused): New, implemented by checking
4304         whether the related AtkState value is in the object's state set.
4305         (AccessibilityUIElement::isFocusable): Ditto.
4306         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4307         (AccessibilityUIElement::isFocused): New, dummy implementation.
4308         (AccessibilityUIElement::isFocusable): Ditto.
4309         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4310         (AccessibilityUIElement::isFocused): Ditto.
4311         (AccessibilityUIElement::isFocusable): Ditto.
4312
4313 2010-12-14  Eric Seidel  <eric@webkit.org>
4314
4315         Reviewed by Ojan Vafai.
4316
4317         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
4318         https://bugs.webkit.org/show_bug.cgi?id=50715
4319
4320         This patch makes webkit-patch print the following:
4321
4322         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
4323         Install a 64-bit git for better performance, see:
4324         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
4325
4326         I wrote this mostly because I have approximately 8 machines that I use
4327         and making sure each one is using a good Git install seemed folly.
4328         webkit-patch makes a lot of git calls, so using a fast git can shave
4329         several seconds in every invocation.  See the webkit-dev thread for more info.
4330
4331         This message will print twice during 'webkit-patch upload',
4332         once from webkit-patch and once from check-webkit-style.
4333
4334         Unfortunately there is no good way to test this due to how machine-dependent
4335         the code is.  I considered writing a test for the log message, but it seemed not worth it.
4336
4337         * Scripts/webkitpy/common/checkout/scm.py:
4338
4339 2010-12-13  Eric Seidel  <eric@webkit.org>
4340
4341         Reviewed by Adam Barth.
4342
4343         FlakyTestReporter doesn't understand bots running from multiple email addresses
4344         https://bugs.webkit.org/show_bug.cgi?id=50960
4345
4346         This explains at least one of the dupes of:
4347         https://bugs.webkit.org/show_bug.cgi?id=50863
4348         that we saw filed by the commit-queue this morning.
4349         I think the other one was explained by my previous fix to result counting code.
4350
4351         Since this is really hard to test with a unit test, instead I
4352         create a new (possibly useful in the future) command
4353         which given a layout test path will return you
4354         the one bug which our tools would assume it the flaky test bug.
4355         If some other script wants to use bug-for-test we'll
4356         need to extend it with some options like --create-if-missing or similar.
4357
4358         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4359         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4360         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4361         * Scripts/webkitpy/tool/commands/__init__.py:
4362         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
4363
4364 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
4365
4366         Reviewed by James Robinson.
4367
4368         Add option to build-webkit to not build WebKit2
4369         https://bugs.webkit.org/show_bug.cgi?id=50988
4370         
4371         Add support for a --no-webkit2 option to build-webkit. It seems to save
4372         ~1 minute from clean builds and ~10 seconds from no-op builds.
4373
4374         * Scripts/build-webkit:
4375
4376 2010-12-13  Lucas Forschler  <lforschler@apple.com>
4377
4378         Reviewed by Dave Kilzer.
4379
4380         Update iexploder from 1.3.2 to 1.7.2
4381         Move 1.3.2 into its own subdir
4382         Add 1.7.2 into its own subdir
4383         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
4384
4385         * Scripts/run-iexploder-tests:
4386         * Scripts/update-iexploder-cssproperties:
4387         * iExploder/CHANGELOG.txt: Removed.
4388         * iExploder/LICENSE.txt: Removed.
4389         * iExploder/README.txt: Removed.
4390         * iExploder/htdocs: Removed.
4391         * iExploder/iexploder-1.3.2: Added.
4392         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
4393         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
4394         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
4395         * iExploder/iexploder-1.3.2/htdocs: Added.
4396         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
4397         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
4398         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
4399         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
4400         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
4401         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
4402         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
4403         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
4404         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
4405         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
4406         * iExploder/iexploder-1.3.2/tools: Added.
4407         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
4408         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
4409         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
4410         * iExploder/iexploder-1.7.2: Added.
4411         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
4412         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
4413         * iExploder/iexploder-1.7.2/README.txt: Added.
4414         * iExploder/iexploder-1.7.2/output: Added.
4415         * iExploder/iexploder-1.7.2/src: Added.
4416         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
4417         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
4418         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
4419         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
4420         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
4421         * iExploder/iexploder-1.7.2/src/css-properties: Added.
4422         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
4423         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
4424         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
4425         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
4426         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
4427         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
4428         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
4429         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
4430         * iExploder/iexploder-1.7.2/src/css-values: Added.
4431         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
4432         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
4433         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
4434         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
4435         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
4436         * iExploder/iexploder-1.7.2/src/headers: Added.
4437         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
4438         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
4439         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
4440         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
4441         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
4442         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
4443         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
4444         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
4445         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
4446         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
4447         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
4448         * iExploder/iexploder-1.7.2/src/html-tags: Added.
4449         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
4450         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
4451         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
4452         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
4453         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
4454         * iExploder/iexploder-1.7.2/src/html-values: Added.
4455         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
4456         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
4457         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
4458         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
4459         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
4460         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
4461         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.