Tools/ChangeLog

   1 2011-02-03  Adam Roben  <aroben@apple.com>
   2
   3         Include the crashing function in the link to a crash log
   4
   5         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
   6         function that crashed
   7
   8         Reviewed by David Kilzer.
   9
  10         * Scripts/old-run-webkit-tests:
  11         (crashLocation): Added. Returns the location of the crash.
  12         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
  13         could be determined.
  14
  15 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
  16
  17         Unreviewed, build fix.
  18
  19         Actually make the changes suggested by Mihai in his review
  20         of bug 53720 :(
  21
  22         https://bugs.webkit.org/show_bug.cgi?id=53720
  23
  24         * Scripts/webkitpy/layout_tests/port/test_files.py:
  25         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
  26
  27 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
  28
  29         Reviewed by Mihai Parparita.
  30
  31         new-run-webkit-tests: Fix bug introduced in r77434 that was
  32         causing us to run the canvas GPU tests on the Mac GPU port. This
  33         bug revealed that we were not setting the port.name() field
  34         properly in many cases, so I've cleaned up all of that code, and
  35         removed a few comments about "version-specific" GPU ports that
  36         don't exist and just confused things.
  37
  38         Testing also revealed that port.abspath_for_test() wasn't
  39         normalizing paths on Windows properly, so I fixed that as well.
  40
  41         https://bugs.webkit.org/show_bug.cgi?id=53719
  42
  43         * Scripts/webkitpy/layout_tests/port/base.py:
  44         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  45         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  46
  47 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
  48
  49         Reviewed by Mihai Parparita.
  50
  51         new-run-webkit-tests: fix normalization of paths on windows when gathering files
  52
  53         r77434 introduced a bug that was causing the test expectations
  54         for the GPU ports to not be treated properly. It turns out that
  55         when we gathered the list of test files on Windows, we would
  56         return paths of the form "c:\LayoutTests/fast/canvas", and the
  57         mixture of backslashes and forward slashes was confusing things.
  58
  59         This patch normalizes all of the filenames returned from
  60         test_files.find(), and adds better tests for this (fixing a
  61         couple of other bugs found in the meantime).
  62
  63         https://bugs.webkit.org/show_bug.cgi?id=53720
  64
  65         * Scripts/webkitpy/layout_tests/port/test.py:
  66         * Scripts/webkitpy/layout_tests/port/test_files.py:
  67         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
  68
  69 2011-02-03  Adam Roben  <aroben@apple.com>
  70
  71         Add links to Windows crash logs in results.html
  72
  73         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
  74         results.html
  75
  76         Reviewed by David Kilzer.
  77
  78         * Scripts/old-run-webkit-tests:
  79         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
  80         createDebuggerCommandFile).
  81         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
  82         tool has exited.
  83         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
  84         it into the test results directory tree. Only implemented for Cygwin currently.
  85         (findNewestFileMatchingGlob): Added. Does what it says.
  86         (htmlForResultsSection): Only link to files that exist.
  87         (linksForErrorTest): Add a link to the crash log.
  88         (deleteExpectedAndActualResults): Delete any old crash log for this test.
  89         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
  90         hardcoding it here.
  91
  92 2011-02-03  Adam Roben  <aroben@apple.com>
  93
  94         Tell the debugger the path to the WebKit source tree when saving a crash log
  95
  96         This allows the debugger to include the crashing line of code in the log.
  97
  98         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
  99         of code
 100
 101         Reviewed by Sam Weinig.
 102
 103         * Scripts/old-run-webkit-tests:
 104         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
 105         file and returns the path to that file. The commands we pass came from
 106         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
 107         WebKit source code lives.
 108         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
 109         line using -c, save them to a file and specify the path to that file using -cf. This works
 110         around what is presumably a bug in Windows's command line parsing, where having multiple
 111         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
 112         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
 113         together to make them easier to modify in the future.
 114
 115 2011-02-02  Sam Weinig  <sam@webkit.org>
 116
 117         Reviewed by Anders Carlsson.
 118
 119         Add notification of the end of a rubber band.
 120         <rdar://problem/8940648>
 121
 122         * MiniBrowser/mac/BrowserWindowController.m:
 123         (-[BrowserWindowController awakeFromNib]):
 124         * WebKitTestRunner/TestController.cpp:
 125         (WTR::TestController::createOtherPage):
 126         (WTR::TestController::initialize):
 127         Stub out the new WKUIClient function.
 128
 129 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
 130
 131         Unreviewed.
 132
 133         Adding myself to committers.py.
 134
 135         * Scripts/webkitpy/common/config/committers.py:
 136
 137 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
 138
 139         Reviewed by Csaba Osztrogonác.
 140
 141         [Qt][WK2] MiniBrowser's window size should be 800x600
 142         https://bugs.webkit.org/show_bug.cgi?id=53670
 143
 144         Make layout test failure debugging easier.
 145         * MiniBrowser/qt/BrowserWindow.cpp:
 146         (BrowserWindow::BrowserWindow):
 147
 148 2011-02-02  Andy Estes  <aestes@apple.com>
 149
 150         Reviewed by Mark Rowe.
 151
 152         'update-webkit' should handle OpenSource and Internal using different
 153         VCSs.
 154
 155         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
 156         Internal directory.
 157
 158 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
 159
 160         Reviewed by Mihai Parparita.
 161
 162         new-run-webkit-tests: hardcode the directories to scan for tests
 163         for GPU bots instead of SKIPping them. See bug 53562 for some
 164         context, but we will now hard-code the list of directories to
 165         use by default instead of skipping over directories in the
 166         expectations file. We do this so that we will be able to merge
 167         the expectations files without getting conflicting SKIP
 168         directives. Note that this change will reduce the # of tests
 169         being run on the Mac GPU bots, because we're accidentally
 170         including some today.
 171
 172         https://bugs.webkit.org/show_bug.cgi?id=53631
 173
 174         * Scripts/webkitpy/layout_tests/port/base.py:
 175         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
 176         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
 177
 178 2011-02-02  Sam Weinig  <sam@webkit.org>
 179
 180         Reviewed by Beth Dakin.
 181
 182         Add ChromeClient function to paint custom overhang areas.
 183         https://bugs.webkit.org/show_bug.cgi?id=53639
 184
 185         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 186         (WTR::InjectedBundlePage::InjectedBundlePage):
 187         Stub out new callback.
 188
 189 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
 190
 191         Reviewed by Tony Chang.
 192
 193         new-run-webkit-tests: support chromium code paths in mock_drt
 194
 195         https://bugs.webkit.org/show_bug.cgi?id=53471
 196
 197         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
 198         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 199
 200 2011-02-02  Adam Klein  <adamk@chromium.org>
 201
 202         Reviewed by Tony Chang.
 203
 204         Update new-run-webkit-tests --chromium to put output under Source/...
 205         https://bugs.webkit.org/show_bug.cgi?id=53612
 206
 207         * BuildSlaveSupport/test-result-archive:
 208         * Scripts/webkitpy/layout_tests/port/chromium.py:
 209
 210 2011-01-28  Tony Chang  <tony@chromium.org>
 211
 212         Reviewed by Eric Seidel.
 213
 214         [chromium] remove --use-test-shell from NRWT
 215         https://bugs.webkit.org/show_bug.cgi?id=53346
 216
 217         I've already started removing some of the bindings like eventSender so
 218         this already doesn't work isn't useful.  Also updated some comments to
 219         refer to DRT instead of test_shell.
 220
 221         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 222         * Scripts/webkitpy/layout_tests/port/chromium.py:
 223         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 224         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 225         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 226         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 227         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 228         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
 229
 230 2011-02-02  Steve Lacey  <sjl@chromium.org>
 231
 232         Reviewed by Eric Carlson.
 233
 234         Implement basic media statistics on media elements.
 235         https://bugs.webkit.org/show_bug.cgi?id=53322
 236
 237         * Scripts/build-webkit:
 238
 239 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
 240
 241         [wx] Build fixes for wxWebKit.
 242
 243         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 244         (LayoutTestController::setSerializeHTTPLoads):
 245         * wx/browser/wscript:
 246         * wx/build/build_utils.py:
 247         * wx/build/settings.py:
 248
 249 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
 250
 251         Reviewed by Mihai Parparita.
 252
 253         new-run-webkit-tests: stop skipping so many tests
 254
 255         r77163 introduced a regression where we weren't resetting test
 256         expectations properly and were skipping too many tests as a
 257         result. This patch fixes that and adds a test for it.
 258
 259         https://bugs.webkit.org/show_bug.cgi?id=53551
 260
 261         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 262         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 263
 264 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
 265
 266         Reviewed by Tony Chang.
 267
 268         new-run-webkit-tests: add first stub of test_runner2. This
 269         will add support for the 'inline', 'threads', and 'processes'
 270         flags to --worker-model, but for now the implementatios just
 271         fall back on the old ones.
 272
 273         https://bugs.webkit.org/show_bug.cgi?id=53157
 274
 275         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
 276         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 277
 278 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
 279
 280         Reviewed by James Robinson.
 281
 282         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
 283         https://bugs.webkit.org/show_bug.cgi?id=53522
 284
 285         * Scripts/run-chromium-webkit-unit-tests:
 286
 287 2011-02-01  Adam Barth  <abarth@webkit.org>
 288
 289         Reviewed by Mihai Parparita.
 290
 291         Using Control-C to cancel webkit-patch or other python tools causes
 292         unpleasant traceback console spew
 293         https://bugs.webkit.org/show_bug.cgi?id=53462
 294
 295         Catch the exception and don't print the stack trace.
 296
 297         * Scripts/webkit-patch:
 298
 299 2011-02-01  Scott Cameron  <sccameron@rim.com>
 300
 301         Reviewed by Daniel Bates.
 302
 303         Use Windows format for MinGW HTTPD path.
 304         https://bugs.webkit.org/show_bug.cgi?id=53503
 305
 306         * Scripts/webkitperl/httpd.pm:
 307           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
 308             so that we don't have to escape the space characters in the path. Also,
 309             changed path to Windows-style path and removed FIXME comment.
 310
 311 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
 312
 313         Reviewed by Andreas Kling.
 314
 315         [Qt][WK2] Add a way to use shared process model in MiniBrowser
 316         https://bugs.webkit.org/show_bug.cgi?id=53090
 317
 318         * MiniBrowser/qt/BrowserView.cpp:
 319         (BrowserView::BrowserView): Removed the m_context member.
 320         From now the context is guaranteed to be non-null and we
 321         don't need to store that in the object.
 322         * MiniBrowser/qt/BrowserView.h:
 323         * MiniBrowser/qt/BrowserWindow.cpp:
 324         Added static bool to determine that new windows need to be
 325         created with their own context or not. Use the same context
 326         and web process by default to be inilne with the other ports.
 327         (BrowserWindow::BrowserWindow):
 328         (BrowserWindow::newWindow):
 329         * MiniBrowser/qt/BrowserWindow.h:
 330         * MiniBrowser/qt/main.cpp:
 331         (main): Added command line switch to be able to use the
 332         non-shared process model. Simplify the handling of the command line
 333         switches a little bit.
 334
 335 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
 336
 337         Reviewed by Andreas Kling.
 338
 339         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
 340         https://bugs.webkit.org/show_bug.cgi?id=53491
 341
 342         * MiniBrowser/qt/BrowserWindow.cpp:
 343         (BrowserWindow::BrowserWindow):
 344         (BrowserWindow::toggleFullScreenMode):
 345         * MiniBrowser/qt/BrowserWindow.h:
 346
 347 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
 348
 349         Reviewed by Andreas Kling.
 350
 351         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
 352         https://bugs.webkit.org/show_bug.cgi?id=53489
 353
 354         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
 355         to Settings menu.
 356
 357         * MiniBrowser/qt/BrowserWindow.cpp:
 358         (BrowserWindow::BrowserWindow):
 359         (BrowserWindow::toggleFrameFlattening):
 360         (BrowserWindow::toggleDisableJavaScript):
 361         (BrowserWindow::toggleAutoLoadImages):
 362         * MiniBrowser/qt/BrowserWindow.h:
 363
 364 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
 365
 366         Reviewed by Tony Chang.
 367
 368         [Chromium] Switch chromium-mac to use ChromiumDriver
 369         https://bugs.webkit.org/show_bug.cgi?id=53461
 370
 371         For the sake of consistency with the other Chromium platforms (and so
 372         that chromium-mac picks up special flags like --enable-hardware-gpu),
 373         switch chromium-mac from the WebKitDriver to ChromiumDriver.
 374
 375         * Scripts/webkitpy/layout_tests/port/chromium.py:
 376
 377 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
 378
 379         Reviewed by Mihai Parparita.
 380
 381         The current modifier parsing code in test_expectations is
 382         fragile and hard-coded, so it's not easy to understand the logic
 383         or easily add new types of modifiers (like GPU vs. CPU testing
 384         for graphics tests, or 32-bit vs. 64-bit differences).
 385
 386         This is the first of two patches that will add in more generic
 387         support and then eliminate the GPU-specific test expectations
 388         files for Chromium.
 389
 390         This patch adds two standalone objects for handling modifiers. The
 391         rules for interpreting modifiers, precedence, and conflicts are
 392         given in the docstring to the ModifierMatcher class, which
 393         returns ModifierMatchResult objects.
 394
 395         This patch also adds routines to the Port interface and a
 396         default set of values in the base object, in order to obtain the
 397         values needed on a given test run. These values are then passed
 398         to the expectation parser. This also allows us to clean up the
 399         logic used to lint all of the different configurations in a
 400         single test_expectations.txt file.
 401
 402         The next patch will merge in the separate GPU expectations file.
 403
 404         https://bugs.webkit.org/show_bug.cgi?id=51222
 405
 406         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 407         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 408         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 409         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 410         * Scripts/webkitpy/layout_tests/port/base.py:
 411         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 412         * Scripts/webkitpy/layout_tests/port/chromium.py:
 413         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 414         * Scripts/webkitpy/layout_tests/port/test.py:
 415         * Scripts/webkitpy/layout_tests/port/webkit.py:
 416         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 417         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 418         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 419         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
 420         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 421
 422 2011-01-31  Scott Cameron  <sccameron@rim.com>
 423
 424         Reviewed by Daniel Bates.
 425
 426         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
 427         https://bugs.webkit.org/show_bug.cgi?id=50036
 428
 429         This will add an Apache2.2 configuration file and modifies scripts to allow
 430         running an httpd server in an MSYS environment.
 431
 432         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
 433         in order to allow for simple installation/execution.  Simply install the latest
 434         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
 435         be able to execute run-webkit-httpd.
 436
 437
 438         * Scripts/run-webkit-httpd:
 439         * Scripts/webkitperl/httpd.pm:
 440
 441 2011-01-31  Tony Chang  <tony@chromium.org>
 442
 443         Reviewed by Eric Seidel.
 444
 445         mac DRT should report RTL scroll offset relative to top right corner
 446         https://bugs.webkit.org/show_bug.cgi?id=53324
 447
 448         * DumpRenderTree/mac/DumpRenderTree.mm:
 449         (dumpFrameScrollPosition):
 450
 451 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
 452
 453         Reviewed by Andreas Kling.
 454
 455         [Qt] Add Take Screen Shot action to MiniBrowser
 456         https://bugs.webkit.org/show_bug.cgi?id=53422
 457
 458         Add Take Screen Shot action to MiniBrowser's view menu.
 459
 460         * MiniBrowser/qt/BrowserWindow.cpp:
 461         (BrowserWindow::BrowserWindow):
 462         (BrowserWindow::screenshot):
 463         * MiniBrowser/qt/BrowserWindow.h:
 464
 465 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 466
 467         Reviewed by Xan Lopez.
 468
 469         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
 470         https://bugs.webkit.org/show_bug.cgi?id=53379
 471
 472         Remove left over #ifdef's. I thought all of the conditional code
 473         had been freed from the condition, but I forgot to check DRT.
 474
 475         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 476         (resetDefaultsToConsistentValues):
 477         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 478         (LayoutTestController::setAlwaysAcceptCookies):
 479
 480 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
 481
 482         Unreviewed, build fix.
 483
 484         Fix regression introduced in r77093 - path.rsplit() doesn't
 485         take keyword arguments.
 486
 487         https://bugs.webkit.org/show_bug.cgi?id=53326
 488
 489         * Scripts/webkitpy/common/system/filesystem_mock.py:
 490
 491 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
 492
 493         Reviewed by Mihai Parparita.
 494
 495         Add more unit tests for rebaseline-chromium-webkit-tests. This
 496         change involves restructuring a bunch of r-c-w-t code to make it
 497         more testable as well. We also add wrapper classes for handling
 498         testing zip files and fetching URLs.
 499
 500         https://bugs.webkit.org/show_bug.cgi?id=53040
 501
 502         * Scripts/webkitpy/common/system/urlfetcher.py:
 503         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
 504         * Scripts/webkitpy/common/system/zipfileset_mock.py:
 505         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 506         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 507         * Scripts/webkitpy/tool/mocktool.py:
 508
 509 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
 510
 511         Reviewed by Eric Seidel.
 512
 513         Clean up of the filesystem-related modules used in webkitpy.
 514         I've added relpath() to the filesystem interface, modified
 515         ospath.relpath() so that it could work with the filesystem
 516         interface, and modified the fileset* routines to use the
 517         filesystem interface consistently.
 518
 519         This patch also adds a close() routine to the fileset routines
 520         to indicate that the caller is done with the fileset. This
 521         allows zipfileset to clean up after itself when it creates
 522         tempfiles to store downloads.
 523
 524         https://bugs.webkit.org/show_bug.cgi?id=53326
 525
 526         * Scripts/webkitpy/common/system/directoryfileset.py:
 527         * Scripts/webkitpy/common/system/fileset.py:
 528         * Scripts/webkitpy/common/system/filesystem.py:
 529         * Scripts/webkitpy/common/system/filesystem_mock.py:
 530         * Scripts/webkitpy/common/system/filesystem_unittest.py:
 531         * Scripts/webkitpy/common/system/ospath.py:
 532         * Scripts/webkitpy/common/system/zipfileset.py:
 533         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
 534
 535 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
 536
 537         Reviewed by Csaba Osztrogonác.
 538
 539         [Qt][WK2]REGRESSION (r76991): Fix build errors
 540         https://bugs.webkit.org/show_bug.cgi?id=53400
 541
 542         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
 543         and remove WebKit2Prefix.h from the build.
 544         * MiniBrowser/qt/MiniBrowser.pro:
 545
 546 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
 547
 548         Unreviewed.
 549
 550         [Qt][WK2] Buildfix.
 551
 552         * MiniBrowser/qt/MiniBrowser.pro:
 553
 554 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
 555
 556         Reviewed by Adam Roben.
 557
 558         define NOMINMAX when building ImageDiff, as we do elsewhere.
 559
 560         Add various clampToInt() methods to MathExtras.h
 561         https://bugs.webkit.org/show_bug.cgi?id=52910
 562
 563         * DumpRenderTree/win/ImageDiffCommon.vsprops:
 564
 565 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
 566
 567         Reviewed by Darin Adler.
 568
 569         WebKitTestRunner needs layoutTestController.setPOSIXLocale
 570         https://bugs.webkit.org/show_bug.cgi?id=42682
 571
 572         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 573         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 574         (WTR::InjectedBundle::resetLocalSettings):
 575         (WTR::InjectedBundle::didReceiveMessage):
 576         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 577         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 578         (WTR::LayoutTestController::setPOSIXLocale):
 579         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 580
 581 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
 582
 583          Reviewed by Mihai Parparita.
 584
 585          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
 586
 587          This patch re-enables this test and changes it to
 588          handle all of the mac platform versions, not just the one
 589          it is running on.
 590
 591          https://bugs.webkit.org/show_bug.cgi?id=53356
 592
 593          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
 594
 595 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
 596
 597         Unreviewed, build fix.
 598
 599         Take two. The fix in 77023 didn't work, because we were
 600         still calling path.abspath_to_uri, which calls _cygpath under
 601         the covers, and it appears the cygpath on the bots does
 602         something different than it does on my machine. This patch
 603         removes the calls to path.abspath_to_uri, so it should be safe.
 604         If it doesn't work, I'll roll it out along with r76982 and 77023.
 605
 606         https://bugs.webkit.org/show_bug.cgi?id=53126
 607
 608         * Scripts/webkitpy/layout_tests/port/test.py:
 609
 610 2011-01-28  David Kilzer  <ddkilzer@apple.com>
 611
 612         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode
 613         <http://webkit.org/b/53353>
 614
 615         Reviewed by Mark Rowe.
 616
 617         * Scripts/webkitdirs.pm:
 618         (checkRequiredSystemConfig): Check the Xcode marketing version
 619         in addition to the DevCoreTools build version before complaining
 620         about an old version of Xcode.  Also make the Mac OS X version
 621         check use Perl's built-in version string comparitor.
 622
 623 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
 624
 625         Unreviewed, build fix.
 626
 627         Work around breakage on Win 7 Release bot caused by r76982
 628         and the fact that windows ports use "file:////" instead of
 629         "file:///". Ideally the test code should be isolated from
 630         this, but it isn't yet. Will fix properly in a bit.
 631
 632         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 633
 634 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
 635
 636         Reviewed by Tony Chang.
 637
 638         new-run-webkit-tests: change worker model values to
 639         "old-inline", "old-threads" in preparation for test_runner2 /
 640         multiprocessing changes.
 641
 642         https://bugs.webkit.org/show_bug.cgi?id=53156
 643
 644         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 645         * Scripts/webkitpy/layout_tests/port/base.py:
 646         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 647         * Scripts/webkitpy/layout_tests/port/mac.py:
 648         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 649
 650 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
 651
 652         Reviewed by Tony Chang.
 653
 654         committers.py - add an IRC nickname for dpranke
 655         https://bugs.webkit.org/show_bug.cgi?id=53335
 656
 657         * Scripts/webkitpy/common/config/committers.py:
 658
 659 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
 660
 661         Reviewed by Tony Chang.
 662
 663         new-run-webkit-tests: add a "mock DRT" port implementation
 664         and a separate class that emulates what we expect the
 665         DumpRenderTree behavior to be.
 666
 667         This will eventually replace port/dryrun.py and allow us to get
 668         better test coverage of the new-run-webkit-tests code as well as
 669         a reference for what new-run-webkit-tests expects from DRT.
 670
 671         This is the first attempt at this, and it is pretty bare-boned. It
 672         really only has been tested on the 'mac' port (and a little on
 673         the 'chromium-mac' port.
 674
 675         https://bugs.webkit.org/show_bug.cgi?id=53126
 676
 677         * Scripts/webkitpy/common/system/filesystem_mock.py:
 678         * Scripts/webkitpy/layout_tests/port/dryrun.py:
 679         * Scripts/webkitpy/layout_tests/port/factory.py:
 680         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
 681         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
 682         * Scripts/webkitpy/layout_tests/port/test.py:
 683
 684 2011-01-28  Pratik Solanki  <psolanki@apple.com>
 685
 686         Unreviewed. Removing .swp file checked in by mistake.
 687
 688         * Scripts/.webkitdirs.pm.swp: Removed.
 689
 690 2011-01-28  Pratik Solanki  <psolanki@apple.com>
 691
 692         Reviewed by David Kilzer.
 693
 694         Space not necessary for undefined feature
 695         https://bugs.webkit.org/show_bug.cgi?id=53317
 696
 697         * Scripts/build-webkit:
 698
 699 2011-01-28  Chang Shu  <chang.shu@nokia.com>
 700
 701         Reviewed by Andreas Kling.
 702
 703         Reset NetworkAccessManager to clean up credentials from previous tests.
 704         This change causes no performance overhead either.
 705         https://bugs.webkit.org/show_bug.cgi?id=36688
 706
 707         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 708         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 709         (WebCore::DumpRenderTree::open):
 710         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 711
 712 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
 713
 714         Reviewed by Andreas Kling.
 715
 716         [Qt] Add Zoom Text Only action to MiniBrowser
 717         https://bugs.webkit.org/show_bug.cgi?id=53297
 718
 719         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
 720
 721         * MiniBrowser/qt/BrowserWindow.cpp:
 722         (BrowserWindow::BrowserWindow):
 723         (BrowserWindow::zoomIn):
 724         (BrowserWindow::zoomOut):
 725         (BrowserWindow::resetZoom):
 726         (BrowserWindow::toggleZoomTextOnly):
 727         (BrowserWindow::applyZoom):
 728         * MiniBrowser/qt/BrowserWindow.h:
 729
 730 2011-01-28  Adam Barth  <abarth@webkit.org>
 731
 732         Reviewed by Eric Seidel.
 733
 734         Add webkit-patch roll-chromium-deps
 735         https://bugs.webkit.org/show_bug.cgi?id=53288
 736
 737         This command updates the Source/WebKit/chromium/DEPS file with the
 738         last-known good revision of Chromium (or a revision specified on the
 739         command line).  I'd eventually like to turn this into a SheriffBot
 740         command, but this is the first step.
 741
 742         This patch somewhat sprawled because I needed to move a bunch of code
 743         out of ChangeLog that should never have been there in the first place.
 744         Also, I had to fix a bug in MockUser in order to test the new command.
 745
 746         * Scripts/webkitpy/common/checkout/api.py:
 747         * Scripts/webkitpy/common/checkout/changelog.py:
 748         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 749         * Scripts/webkitpy/common/checkout/deps.py: Added.
 750         * Scripts/webkitpy/common/config/urls.py:
 751         * Scripts/webkitpy/tool/commands/__init__.py:
 752         * Scripts/webkitpy/tool/commands/download_unittest.py:
 753         * Scripts/webkitpy/tool/commands/roll.py: Added.
 754         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
 755         * Scripts/webkitpy/tool/commands/upload_unittest.py:
 756         * Scripts/webkitpy/tool/mocktool.py:
 757         * Scripts/webkitpy/tool/steps/__init__.py:
 758         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
 759         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
 760         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
 761         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
 762         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
 763         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
 764
 765 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
 766
 767         Reviewed by Laszlo Gombos.
 768
 769         Get rid of prefix header dependency for WebKit2 build system
 770         https://bugs.webkit.org/show_bug.cgi?id=50174
 771
 772         Change the style checker so that it enforces config.h include for
 773         WebKit2.
 774
 775         * Scripts/webkitpy/style/checker.py:
 776
 777 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
 778
 779         Reviewed by Darin Adler.
 780
 781         execCommand("Paste") doesn't work in WebKitTestRunner
 782         https://bugs.webkit.org/show_bug.cgi?id=52785
 783
 784         Enable both of the settings needed to allow paste.
 785
 786         * WebKitTestRunner/TestController.cpp:
 787         (WTR::TestController::resetStateToConsistentValues):
 788
 789 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
 790
 791         Reviewed by Andreas Kling.
 792
 793         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
 794         https://bugs.webkit.org/show_bug.cgi?id=48440
 795
 796         Preserve user input when toggling use of QGraphicsView
 797
 798         * QtTestBrowser/launcherwindow.cpp:
 799         (LauncherWindow::initializeView):
 800         (LauncherWindow::loadFinished):
 801         * QtTestBrowser/launcherwindow.h:
 802         * QtTestBrowser/mainwindow.cpp:
 803         (MainWindow::addressUrl):
 804         * QtTestBrowser/mainwindow.h:
 805
 806 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
 807
 808         Reviewed by Mihai Parparita.
 809
 810         new-run-webkit-tests: turn off pixel tests correctly by default
 811         for webkit-based ports. r70013 (bug 47510) used
 812         port.set_option_default() to attempt to set default values, but
 813         that didn't work correctly. I have removed set_option_default
 814         for now since it was only being used in two places and in three
 815         useless unit tests. There is a separate bug open to fix the
 816         option parsing (48095), so this workaround is fine for now.
 817
 818         https://bugs.webkit.org/show_bug.cgi?id=53217
 819
 820         * Scripts/webkitpy/layout_tests/port/webkit.py:
 821         * Scripts/webkitpy/layout_tests/port/base.py:
 822         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 823
 824 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
 825
 826         Rubber-stamped by Ariya Hidayat.
 827
 828         Trivial crash fix in WTR.
 829
 830         * WebKitTestRunner/TestController.cpp:
 831         (WTR::TestController::initialize): Increase the size
 832         of the vector by one to be able to store the null character.
 833
 834 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
 835
 836         Reviewed by Csaba Osztrogonác.
 837
 838         [Qt][WK2] WTR should be initialized in the same way as DRT
 839         https://bugs.webkit.org/show_bug.cgi?id=53240
 840
 841         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
 842         (WTR::activateFonts): Added missing initialization steps.
 843
 844 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
 845
 846         Unreviewed.
 847
 848         Adding myself to committers.py.
 849
 850         * Scripts/webkitpy/common/config/committers.py:
 851
 852 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 853
 854         Reviewed by Csaba Osztrogonác.
 855
 856         [Qt] [Symbian] Move project files into Source
 857         https://bugs.webkit.org/show_bug.cgi?id=52891
 858
 859         Fix the Symbian build after the project files
 860         are moved to Source directory. On Symbian qmake
 861         needs to run in the same directory where the main
 862         pro files (WebKit.pro, Tools.pro) are located.
 863
 864         * Scripts/webkitdirs.pm: Change to the directory where the pro file
 865         is located before running qmake for Symbian. Qmake on Symbian
 866         does not properly honor the "-o" option, work it around by setting
 867         the name of the Makefile to bld.inf.
 868
 869 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
 870
 871         Reviewed by Andreas Kling.
 872
 873         [Qt] Add simple zooming features to MiniBrowser
 874         https://bugs.webkit.org/show_bug.cgi?id=53231
 875
 876         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
 877
 878         * MiniBrowser/qt/BrowserWindow.cpp:
 879         (BrowserWindow::BrowserWindow):
 880         (BrowserWindow::zoomIn):
 881         (BrowserWindow::zoomOut):
 882         (BrowserWindow::resetZoom):
 883         (BrowserWindow::updateUserAgentList):
 884         (BrowserWindow::applyZoom):
 885         * MiniBrowser/qt/BrowserWindow.h:
 886
 887 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
 888
 889         Reviewed by Dan Bernstein.
 890
 891         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
 892         https://bugs.webkit.org/show_bug.cgi?id=42319
 893
 894         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
 895
 896         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 897         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 898         (WTR::LayoutTestController::showWebInspector):
 899         (WTR::LayoutTestController::closeWebInspector):
 900         (WTR::LayoutTestController::evaluateInWebInspector):
 901         (WTR::LayoutTestController::setTimelineProfilingEnabled):
 902         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 903         * WebKitTestRunner/TestInvocation.cpp:
 904         (WTR::shouldOpenWebInspector):
 905         (WTR::TestInvocation::invoke):
 906         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
 907
 908 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
 909
 910         Reviewed by Xan Lopez.
 911
 912         [GTK] Pixel dumps do not include scrollbars in output images
 913         https://bugs.webkit.org/show_bug.cgi?id=53216
 914
 915         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
 916         that have scrollbars.
 917
 918         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
 919         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
 920         instead of the web view itself.
 921
 922 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
 923
 924         Reviewed by Mihai Parparita.
 925
 926         Fix regression introduced in r76322 ... new-run-webkit-tests
 927         was attempting to save the image diff output as a UTF-8-encoded
 928         file.
 929
 930         https://bugs.webkit.org/show_bug.cgi?id=53210
 931
 932         * Scripts/webkitpy/layout_tests/port/webkit.py:
 933
 934 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 935
 936         Unreviewed, rolling out r76709.
 937         http://trac.webkit.org/changeset/76709
 938         https://bugs.webkit.org/show_bug.cgi?id=53194
 939
 940         "broke python tests on non-snowleopard platforms" (Requested
 941         by dpranke on #webkit).
 942
 943         * Scripts/webkitpy/layout_tests/port/factory.py:
 944         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
 945         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
 946
 947 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
 948
 949         Reviewed by Tony Chang.
 950
 951         new-run-webkit-tests: add a "mock DRT" port implementation
 952         and a separate class that emulates what we expect the
 953         DumpRenderTree behavior to be.
 954
 955         This will eventually replace port/dryrun.py and allow us to get
 956         better test coverage of the new-run-webkit-tests code as well as
 957         a reference for what new-run-webkit-tests expects from DRT.
 958
 959         This is the first attempt at this, and it is pretty bare-boned. It
 960         really only has been tested on the 'mac' port (and a little on
 961         the 'chromium-mac' port.
 962
 963         https://bugs.webkit.org/show_bug.cgi?id=53126
 964
 965         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
 966         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
 967         * Scripts/webkitpy/layout_tests/port/factory.py:
 968
 969 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
 970
 971         Reviewed by Tony Chang.
 972
 973         Add '--no-timeout' option to Chromium DRT to ease debugging.
 974         https://bugs.webkit.org/show_bug.cgi?id=52873
 975
 976         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 977         (main):
 978
 979 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
 980
 981         Reviewed by Andreas Kling.
 982
 983         [Qt] Fix qt_minimal build
 984         https://bugs.webkit.org/show_bug.cgi?id=53172
 985
 986         * QtTestBrowser/locationedit.h:
 987
 988 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
 989
 990         Reviewed by Antonio Gomes.
 991
 992         QtTestBrowser should have a UI Setting to disable plugins
 993         https://bugs.webkit.org/show_bug.cgi?id=52408
 994
 995         Added a new action item named "Disable Plugins"
 996         under the "Settings" menu.
 997
 998         * QtTestBrowser/launcherwindow.cpp:
 999         (LauncherWindow::createChrome):
1000         (LauncherWindow::togglePlugins):
1001         * QtTestBrowser/launcherwindow.h:
1002
1003 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1004
1005         Reviewed by Adam Barth.
1006
1007         Move main CMakeLists.txt into Source directory
1008         https://bugs.webkit.org/show_bug.cgi?id=52888
1009
1010         * Scripts/webkitdirs.pm:
1011
1012 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1013
1014         Reviewed by Eric Seidel.
1015
1016         Improve label text in submit-to-ews
1017         https://bugs.webkit.org/show_bug.cgi?id=53130
1018
1019         * QueueStatusServer/templates/submittoews.html:
1020
1021 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1022
1023         Reviewed by Antonio Gomes.
1024
1025         QtTestBrowser should have a UI Settings to prevent loading images
1026         https://bugs.webkit.org/show_bug.cgi?id=52409
1027
1028         Added a new action item named "DisableAutoLoadImages"
1029         under the "Settings" menu
1030
1031         * QtTestBrowser/launcherwindow.cpp:
1032         (LauncherWindow::createChrome):
1033         (LauncherWindow::toggleAutoLoadImages):
1034         * QtTestBrowser/launcherwindow.h:
1035
1036 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1037
1038         Reviewed by Tony Chang.
1039
1040         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1041         classes, test_expectations.py. This change adds "test-win" and
1042         "test-mac" variants to the test port so that we can better test
1043         rebaselining, and adds a MockUser() object for reuse in testing.
1044
1045         https://bugs.webkit.org/show_bug.cgi?id=53036
1046
1047         * Scripts/webkitpy/common/system/filesystem.py:
1048         * Scripts/webkitpy/common/system/filesystem_mock.py:
1049         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1050         * Scripts/webkitpy/layout_tests/port/factory.py:
1051         * Scripts/webkitpy/layout_tests/port/base.py:
1052         * Scripts/webkitpy/layout_tests/port/test.py:
1053         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1054         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1055         * Scripts/webkitpy/tool/mocktool.py:
1056
1057 2011-01-25  Tony Chang  <tony@chromium.org>
1058
1059         Reviewed by Dimitri Glazkov.
1060
1061         [chromium] remove unused layoutTestController callback
1062         https://bugs.webkit.org/show_bug.cgi?id=53103
1063
1064         This method is used by a test_shell_test, but not needed by DRT.
1065
1066         * DumpRenderTree/chromium/LayoutTestController.cpp:
1067         (LayoutTestController::LayoutTestController):
1068         * DumpRenderTree/chromium/LayoutTestController.h:
1069
1070 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1071
1072         Reviewed by Andreas Kling.
1073
1074         [GTK] Remove 64 bits release bot from the buildbot master
1075         https://bugs.webkit.org/show_bug.cgi?id=52899
1076
1077         Removes the 64 bits release slave from the buildbot configuration,
1078         so that we can use it as an EWS.
1079
1080         * BuildSlaveSupport/build.webkit.org-config/config.json:
1081
1082 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1083
1084         Reviewed by Dan Bernstein.
1085
1086         Implement database quota callback to fix storage tests on WebKit2 bot
1087         https://bugs.webkit.org/show_bug.cgi?id=53064
1088
1089         * WebKitTestRunner/TestController.cpp:
1090         (WTR::exceededDatabaseQuota):
1091         (WTR::TestController::createOtherPage):
1092         (WTR::TestController::initialize):
1093
1094 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1095
1096         Reviewed by Anders Carlsson.
1097
1098         Use designated temp directory for the database for WebKit2
1099         https://bugs.webkit.org/show_bug.cgi?id=53052
1100
1101         Adopt the new WK2 API for this.
1102
1103         * WebKitTestRunner/TestController.cpp:
1104         (WTR::TestController::libraryPathForTesting):
1105         (WTR::TestController::initialize):
1106         * WebKitTestRunner/TestController.h:
1107         * WebKitTestRunner/mac/TestControllerMac.mm:
1108         (WTR::TestController::platformLibraryPathForTesting):
1109         * WebKitTestRunner/qt/TestControllerQt.cpp:
1110         (WTR::TestController::platformLibraryPathForTesting):
1111         * WebKitTestRunner/win/TestControllerWin.cpp:
1112         (WTR::TestController::platformLibraryPathForTesting):
1113
1114 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1115
1116         Reviewed by Stephanie Lewis.
1117
1118         Add a new Leopard test bot.
1119
1120         * BuildSlaveSupport/build.webkit.org-config/config.json:
1121
1122 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1123
1124         Reviewed by Adam Barth.
1125
1126         Add EFL Builder to core waterfall
1127         https://bugs.webkit.org/show_bug.cgi?id=52704
1128
1129         Add EFL Builder to the core waterfall again.
1130
1131         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1132         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1133
1134 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1135
1136         Reviewed by Tony Chang.
1137
1138         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1139         https://bugs.webkit.org/show_bug.cgi?id=52872
1140
1141         Force disabling proxy to resolve the problem.
1142
1143         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1144         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1145
1146 2011-01-24  Andreas Kling  <kling@webkit.org>
1147
1148         Reviewed by Darin Adler.
1149
1150         check-webkit-style: Update exemptions following Source/ move.
1151         https://bugs.webkit.org/show_bug.cgi?id=53017
1152
1153         * Scripts/webkitpy/style/checker.py:
1154         * Scripts/webkitpy/style/checker_unittest.py:
1155
1156 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1157
1158         Rubber-stamped by Csaba Osztrogonác.
1159
1160         [Qt] Move project files into Source
1161         https://bugs.webkit.org/show_bug.cgi?id=52891
1162
1163         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1164
1165 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1166
1167         Reviewed by Yury Semikhatsky.
1168
1169         Web Inspector: Find duplicate strings in localizedStrings.js
1170
1171         https://bugs.webkit.org/show_bug.cgi?id=53005
1172
1173         * Scripts/check-inspector-strings:
1174
1175 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1176
1177         Reviewed by Andreas Kling.
1178
1179         [Qt] Regroup MiniBrowser's menubar and add open file action
1180         https://bugs.webkit.org/show_bug.cgi?id=53000
1181
1182         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1183
1184         * MiniBrowser/qt/BrowserWindow.cpp:
1185         (BrowserWindow::BrowserWindow):
1186         (BrowserWindow::openFile):
1187         (BrowserWindow::~BrowserWindow):
1188         * MiniBrowser/qt/BrowserWindow.h:
1189
1190 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1191
1192         Unreviewed fix after r76496
1193
1194         [Qt] Move project files into Source
1195         https://bugs.webkit.org/show_bug.cgi?id=52891
1196
1197         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1198         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1199         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1200
1201 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1202
1203         Reviewed by Csaba Osztrogonác.
1204
1205         [Qt] Move project files into Source
1206         https://bugs.webkit.org/show_bug.cgi?id=52891
1207
1208         * DerivedSources.pro: Renamed from DerivedSources.pro.
1209         * DumpRenderTree/qt/DumpRenderTree.pro:
1210         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1211         * MiniBrowser/DerivedSources.pro:
1212         * MiniBrowser/qt/MiniBrowser.pro:
1213         * QtTestBrowser/QtTestBrowser.pro:
1214         * Scripts/webkitdirs.pm:
1215         * Tools.pro: Added.
1216         * WebKitTestRunner/DerivedSources.pro:
1217         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1218         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1219
1220 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1221
1222         Reviewed by Dan Bernstein.
1223
1224         Beefed up --threaded mode to catch even more kinds of errors.
1225         https://bugs.webkit.org/show_bug.cgi?id=52971
1226
1227         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1228         context group to force JSC to mark multiple threads. (This used to be
1229         the default, but it changed in SnowLeopard.)
1230         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1231         to give threading mistakes more chances to show themselves.
1232         (startJavaScriptThreads):
1233         (stopJavaScriptThreads):
1234
1235 2011-01-22  Robert Hogan  <robert@webkit.org>
1236
1237         Reviewed by Andreas Kling.
1238
1239         [Qt] Support layoutTestController.addURLToRedirect()
1240         https://bugs.webkit.org/show_bug.cgi?id=52956
1241
1242         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1243         (LayoutTestController::addURLToRedirect):
1244         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1245
1246 2011-01-22  Robert Hogan  <robert@webkit.org>
1247
1248         Reviewed by Kenneth Rohde Christiansen.
1249
1250         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1251         https://bugs.webkit.org/show_bug.cgi?id=49802
1252
1253         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1254         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1255         (WebCore::DumpRenderTree::open):
1256
1257 2011-01-21  Adam Barth  <abarth@webkit.org>
1258
1259         Reviewed by Maciej Stachowiak.
1260
1261         Disable mac_unittest.py that fails on some of the Mac bots
1262         https://bugs.webkit.org/show_bug.cgi?id=52947
1263
1264         As noted in the comment, this test does not appear to be correct
1265         because the function this test is testing returns different results
1266         depending on which flavor of Mac the test is run on.  This patch
1267         disable the test.  Hopefully we can re-enable the test once we've
1268         probably insulated the test from its environment.
1269
1270         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1271
1272 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1273
1274         Reviewed by Mihai Parparita.
1275
1276         Fix bug introduced in r76322 that caused NRWT to not actually
1277         read the Skipped files properly.
1278
1279         https://bugs.webkit.org/show_bug.cgi?id=52771
1280
1281         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1282         * Scripts/webkitpy/layout_tests/port/webkit.py:
1283         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1284
1285 2011-01-21  Sam Weinig  <sam@webkit.org>
1286
1287         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1288
1289         WebKitTestRunner needs the HOME environment variable to be set.
1290         <rdar://problem/8896573>
1291
1292         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1293         it exists.
1294
1295 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1296
1297         Reviewed by Eric Seidel.
1298
1299         Suppress a few remaining integration tests so that none of the
1300         layout_test unit tests ever read from the filesystem or launch
1301         subprocesses that aren't part of the unit tests.
1302
1303         Also fix a minor bug in the printing unit tests that was
1304         incorrectly relying on sys.argv.
1305
1306         https://bugs.webkit.org/show_bug.cgi?id=52863
1307
1308         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1309         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1310         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1311
1312 2011-01-21  Darin Adler  <darin@apple.com>
1313
1314        Fix Mac build.
1315
1316         * MiniBrowser/mac/BrowserWindowController.m:
1317         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1318
1319 2011-01-20  Darin Adler  <darin@apple.com>
1320
1321         Reviewed by Dan Bernstein.
1322
1323         WebKit2: Implement showModalDialog
1324         https://bugs.webkit.org/show_bug.cgi?id=52855
1325
1326         This fixes WebKitTestRunner to compile, but more work is probably
1327         needed to get it to pass the tests.
1328
1329         * WebKitTestRunner/TestController.cpp:
1330         (WTR::TestController::runModal): Added. Calls through to the
1331         platform-specific version of runModal.
1332         (WTR::TestController::createOtherPage): Changed to be a private
1333         static member function so it can refer to runModal, which is
1334         a private static member function.
1335         (WTR::TestController::initialize): Pass 0 for the runModal
1336         function since we don't need to run the main window modal.
1337         I suspect this is wrong and will need to change.
1338         * WebKitTestRunner/TestController.h: Added declarations for
1339         the functions added above.
1340         * WebKitTestRunner/mac/TestControllerMac.mm:
1341         (WTR::TestController::runModal): Added. Untested implementation.
1342         * WebKitTestRunner/qt/TestControllerQt.cpp:
1343         (WTR::TestController::runModal): Added.
1344         * WebKitTestRunner/win/TestControllerWin.cpp:
1345         (WTR::TestController::runModal): Added.
1346
1347 2011-01-21  Eric Seidel  <eric@webkit.org>
1348
1349         Reviewed by Adam Barth.
1350
1351         Split Host object off from WebKitPatch for easier re-use
1352         https://bugs.webkit.org/show_bug.cgi?id=52284
1353
1354         new-run-webkit-tests and other tools are eventually going to want one of these.
1355         Basically you need to inherit from this class if you want to pretend to be a
1356         self.tool object for Steps/Commands.
1357
1358         * Scripts/webkitpy/common/host.py: Added.
1359         * Scripts/webkitpy/tool/main.py:
1360
1361 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1362
1363         Reviewed by Adam Barth.
1364
1365         Disable the tests that start and stop the http server and web
1366         server, so that we don't have to worry about port collisions on
1367         the bots.
1368
1369         https://bugs.webkit.org/show_bug.cgi?id=52861
1370
1371         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1372
1373 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1374
1375         Reviewed by Eric Seidel.
1376
1377         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1378
1379         https://bugs.webkit.org/show_bug.cgi?id=52772
1380
1381         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1382
1383 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1384
1385         Reviewed by Eric Siedel.
1386
1387         nrwt: clean up almost all remaining port references, remove
1388         unnecessary import clauses. The only remaining references are
1389         in places where a mock filesystem makes no sense or can't be
1390         used, and in one routine in port/google_chrome_unittest that
1391         I'll rewrite in a separate patch.
1392
1393         https://bugs.webkit.org/show_bug.cgi?id=52771
1394
1395         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1396         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1397         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1398         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1399         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1400         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1401         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1402         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1403         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1404         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1405         * Scripts/webkitpy/layout_tests/port/gtk.py:
1406         * Scripts/webkitpy/layout_tests/port/mac.py:
1407         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1408         * Scripts/webkitpy/layout_tests/port/qt.py:
1409         * Scripts/webkitpy/layout_tests/port/webkit.py:
1410         * Scripts/webkitpy/layout_tests/port/win.py:
1411         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1412
1413 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1414
1415         Reviewed by Mihai Parparita.
1416
1417         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1418
1419         https://bugs.webkit.org/show_bug.cgi?id=52762
1420
1421         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1422         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1423
1424 2011-01-20  Tony Chang  <tony@chromium.org>
1425
1426         Reviewed by Ojan Vafai.
1427
1428         [chromium] fix the paths used for the rebaseline tool
1429         https://bugs.webkit.org/show_bug.cgi?id=52857
1430
1431         Some of the bots were renamed so the path to grab the results zip
1432         file has changed.
1433
1434         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1435
1436 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1437
1438         Reviewed by Tony Chang.
1439
1440         Fix bug introduced in r72688 / bug 52768 that broke the
1441         generation of the output filename links in the results.html
1442         output. Apparently none of the unit tests actually checked to
1443         make sure the generated links were correct :(
1444
1445         https://bugs.webkit.org/show_bug.cgi?id=52854
1446
1447         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1448         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1449
1450 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1451
1452         Reviewed by Darin Adler.
1453
1454         https://bugs.webkit.org/show_bug.cgi?id=52849
1455         Make window.print work with WebKit2
1456
1457         * MiniBrowser/mac/BrowserWindowController.m:
1458         (-[BrowserWindowController awakeFromNib]):
1459         * WebKitTestRunner/TestController.cpp:
1460         (WTR::createOtherPage):
1461         (WTR::TestController::initialize):
1462         Added zeroes to WKPageUIClient structures to avoid build failures.
1463
1464 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1465
1466         Reviewed by Eric Seidel.
1467
1468         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1469
1470         https://bugs.webkit.org/show_bug.cgi?id=52756
1471
1472         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1473         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1474         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1475         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1476         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1477         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1478
1479 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1480
1481         Reviewed by Antonio Gomes.
1482
1483         QtTestBrowser should have a seperate menu for Settings
1484         https://bugs.webkit.org/show_bug.cgi?id=52817
1485
1486         Added a new menu item named "Settings"
1487         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu
1488
1489         * QtTestBrowser/launcherwindow.cpp:
1490         (LauncherWindow::createChrome):
1491
1492 2011-01-20  Sam Weinig  <sam@webkit.org>
1493
1494         Reviewed by John Sullivan.
1495
1496         Update update-webkit-localizable-strings with new path to WebKit.
1497
1498         * Scripts/update-webkit-localizable-strings:
1499
1500 2011-01-20  James Robinson  <jamesr@chromium.org>
1501
1502         Reviewed by Darin Fisher.
1503
1504         Implement mozilla's requestAnimationFrame API
1505         https://bugs.webkit.org/show_bug.cgi?id=51218
1506
1507         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1508
1509         * DumpRenderTree/chromium/WebViewHost.cpp:
1510         (invokeScheduleComposite):
1511         (WebViewHost::scheduleAnimation):
1512         (WebViewHost::paintInvalidatedRegion):
1513         * DumpRenderTree/chromium/WebViewHost.h:
1514
1515 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1516
1517         Reviewed by Adam Roben.
1518
1519         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1520         https://bugs.webkit.org/show_bug.cgi?id=42327
1521
1522         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1523         for methods that take their normal arguments but also a JSContextRef.
1524         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1525         for evaluateScriptInIsolatedWorld.
1526         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1527         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1528         this call is for an isolated world.
1529         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1530         (WTR::worldMap): Helper to create a world map.
1531         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1532         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1533         added LayoutTestController API.
1534         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1535
1536 2011-01-19  Adam Roben  <aroben@apple.com>
1537
1538         Convert paths in environment variables back to msys-style inside commit-log-editor
1539
1540         When this script gets run from inside git commit, msys-style paths in the environment will
1541         have been turned into Windows-style paths with forward slashes. This screws up functions
1542         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1543         the paths back to msys-style before doing anything else.
1544
1545         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1546         using msysgit's Perl and multiple ChangeLogs have been edited
1547
1548         Reviewed by David Kilzer.
1549
1550         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1551         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1552         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1553
1554 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1555
1556         [Win] Unreviewed build fix after r76248.
1557
1558         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1559
1560 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1561
1562         Reviewed by Csaba Osztrogonác.
1563
1564         Refactoring of the custom allocation framework
1565         https://bugs.webkit.org/show_bug.cgi?id=49897
1566
1567         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1568         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1569         equivalent macro implementation at the necessary places.
1570 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1571
1572         Unreviewed.
1573
1574         Adding myself to committers.py.
1575
1576         * Scripts/webkitpy/common/config/committers.py:
1577
1578 2011-01-20  Adam Barth  <abarth@webkit.org>
1579
1580         Reviewed by Tony Chang.
1581
1582         Chromium builders don't delete unversioned directories when DEPS change
1583         https://bugs.webkit.org/show_bug.cgi?id=52745
1584
1585         If we pass this option to gclient sync, gclient will delete directories
1586         that are no longer part of DEPS instead of leaving them around to
1587         confuse us later.  Apparently, the downstream buildbots use this option
1588         already.
1589
1590         * Scripts/update-webkit-chromium:
1591
1592 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1593
1594         Unreviewed, build fix - I pulled this patch in to fix an issue
1595         revealed by r76195 running on some new bots). Also fix a couple
1596         of other issues revealed in testing.
1597
1598         nrwt: remove fs refs from layout_package/json*
1599
1600         https://bugs.webkit.org/show_bug.cgi?id=52754
1601
1602         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1603         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1604         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1605         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1606         * Scripts/webkitpy/layout_tests/port/base.py:
1607
1608 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1609
1610         Unreviewed, build fix.
1611
1612         Fix a couple of minor bugs discovered while bringing up new bots
1613         for testing.
1614
1615         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1616         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1617
1618 2011-01-19  James Robinson  <jamesr@chromium.org>
1619
1620         Unreviewed, rolling out r76194.
1621         http://trac.webkit.org/changeset/76194
1622         https://bugs.webkit.org/show_bug.cgi?id=51218
1623
1624         Caused mysterious compile failure on the chromium win
1625         build.webkit.org bots
1626
1627         * DumpRenderTree/chromium/WebViewHost.cpp:
1628         (WebViewHost::paintInvalidatedRegion):
1629         * DumpRenderTree/chromium/WebViewHost.h:
1630
1631 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1632
1633         Reviewed by Mihai Parparita.
1634
1635         remove fs refs from test_runner, dump_render_tree_thread
1636
1637         https://bugs.webkit.org/show_bug.cgi?id=52753
1638
1639         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1640         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1641         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1642         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1643
1644 2011-01-19  James Robinson  <jamesr@chromium.org>
1645
1646         Reviewed by Darin Fisher.
1647
1648         Implement mozilla's requestAnimationFrame API
1649         https://bugs.webkit.org/show_bug.cgi?id=51218
1650
1651         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1652
1653         * DumpRenderTree/chromium/WebViewHost.cpp:
1654         (invokeScheduleComposite):
1655         (WebViewHost::scheduleAnimation):
1656         (WebViewHost::paintInvalidatedRegion):
1657         * DumpRenderTree/chromium/WebViewHost.h:
1658
1659 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1660
1661         Unreviewed, build fix.
1662
1663         Fix a few incorrect "self._filesystem" references introduced in
1664         r76184.
1665
1666         * Scripts/webkitpy/layout_tests/port/chromium.py:
1667         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1668
1669 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1670
1671         Reviewed by Mihai Parparita.
1672
1673         add a .sep property, abspath(), isabs(), mtime(), and
1674         open_text_file_for_writing() to filesystem modules. Some of
1675         these properties are not needed in this patch but will be needed
1676         in subsequent patches (I'm doing this to avoid having to track
1677         multiple versions of a single file).
1678
1679         Also, change most of the port/* modules to use the filesystem
1680         objects instead of referencing the filesystem directly.
1681
1682         https://bugs.webkit.org/show_bug.cgi?id=52748
1683
1684         * Scripts/webkitpy/common/system/filesystem.py:
1685         * Scripts/webkitpy/common/system/filesystem_mock.py:
1686         * Scripts/webkitpy/layout_tests/port/__init__.py:
1687         * Scripts/webkitpy/layout_tests/port/base.py:
1688         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1689         * Scripts/webkitpy/layout_tests/port/chromium.py:
1690         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1691         * Scripts/webkitpy/layout_tests/port/config.py:
1692         * Scripts/webkitpy/layout_tests/port/test.py:
1693         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1694
1695 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1696
1697         Reviewed by Anders Carlsson.
1698
1699         If resetting between tests times out, treat it as a WebProcess crash
1700         https://bugs.webkit.org/show_bug.cgi?id=52757
1701
1702         * WebKitTestRunner/TestController.cpp:
1703         (WTR::TestController::runTest):
1704
1705 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1706
1707         Reviewed by Darin Adler.
1708
1709         https://bugs.webkit.org/show_bug.cgi?id=52739
1710         Make it possible for a WebKit2 client to print headers and footers
1711
1712         Added dummy implementations for new printing UIClient calls.
1713
1714         * MiniBrowser/mac/BrowserWindowController.m:
1715         (-[BrowserWindowController awakeFromNib]):
1716         * WebKitTestRunner/TestController.cpp:
1717         (WTR::createOtherPage):
1718         (WTR::TestController::initialize):
1719
1720 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1721
1722         Reviewed by Ojan Vafai.
1723
1724         Change webkitpy/layout_tests/port/test.py to use the
1725         in-memory filesystem for cleaner unit testing. This
1726         change allows us to kill a lot of code that was
1727         specific to the test port, at the cost of being a
1728         little less clear about how things would work if
1729         you didn't have a filesystem.
1730
1731         https://bugs.webkit.org/show_bug.cgi?id=52605
1732
1733         * Scripts/webkitpy/layout_tests/port/test.py:
1734
1735 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1736
1737         Unreviewed, build fix.
1738
1739         Fix test failure caused by committing attachment 79368 instead
1740         of attachment 79461 on bug 52604.
1741
1742         * Scripts/webkitpy/common/system/filesystem_mock.py:
1743
1744 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1745
1746         Reviewed by Mihai Parparita.
1747
1748         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1749         unit testing. os.walk() is too much of a hassle to implement on
1750         top of the in-memory mock filesystem and adding the necessary
1751         interface to files_under() gives clients a cleaner API anyway
1752         (for this particular usage model).
1753
1754         https://bugs.webkit.org/show_bug.cgi?id=52691
1755
1756         * Scripts/webkitpy/common/system/filesystem.py:
1757         * Scripts/webkitpy/common/system/filesystem_mock.py:
1758         * Scripts/webkitpy/layout_tests/port/test_files.py:
1759         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1760
1761 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1762
1763         Reviewed by Tony Chang.
1764
1765         Change more modules in the layout-tests code to use the
1766         filesystem wrapper for cleaner unit testing.
1767
1768         This patch also adds the glob() wrapper to the filesystem
1769         abstraction.
1770
1771         https://bugs.webkit.org/show_bug.cgi?id=52604
1772
1773         * Scripts/webkitpy/layout_tests/port/test_files.py:
1774         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1775         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1776         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1777         * Scripts/webkitpy/common/system/filesystem.py:
1778         * Scripts/webkitpy/common/system/filesystem_mock.py:
1779
1780 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1781
1782         Unreviewed.
1783
1784         Updating my email addresses and irc nick.
1785
1786         * Scripts/webkitpy/common/config/committers.py:
1787
1788 2011-01-19  Tony Chang  <tony@chromium.org>
1789
1790         Reviewed by Mihai Parparita.
1791
1792         [chromium] [linux] if check-sys-deps fails, output the failure reason
1793         https://bugs.webkit.org/show_bug.cgi?id=52671
1794
1795         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1796             error handler functions.
1797         * Scripts/webkitpy/layout_tests/port/chromium.py:
1798             output the error text from --check-sys-deps
1799         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1800
1801 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1802
1803         Reviewed by Andreas Kling.
1804
1805         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1806         https://bugs.webkit.org/show_bug.cgi?id=52554
1807
1808         QtNetworkAccessManager is created in a thread and set as
1809         member variable in QWebPage. When the thread is destroyed
1810         the object is still used. So fix will set the object to
1811         NULL once the thread is destroyed.
1812
1813         * QtTestBrowser/launcherwindow.cpp:
1814         (LauncherWindow::~LauncherWindow):
1815
1816 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1817
1818         Rubber stamped by Csaba Osztrogonac
1819
1820         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1821
1822 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1823
1824         Reviewed by Tony Chang.
1825
1826         new-run-webkit-tests: add a --build-directory command line argument
1827
1828         Official Google Chrome builds use a non-standard build directory
1829         location. This patch adds a --build-directory argument that
1830         allows that location to be specified on the command line. Only
1831         Chromium-based builds will use this flag for now, but anyone can
1832         in the future.
1833
1834         There are no unit tests for this since it's difficult to test
1835         until mock filesystems are fully supported in the code. This was
1836         tested by hand for now.
1837
1838         https://bugs.webkit.org/show_bug.cgi?id=52694
1839
1840         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1841         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1842         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1843         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1844
1845 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1846
1847         Not reviewed. Bot fix.
1848
1849         Remove an inadvertently committed debugging print.
1850
1851         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1852         (LayoutTestController::notifyDone):
1853
1854 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1855
1856         Reviewed by Sam Weinig.
1857
1858         WebKitTestRunner should track loading more like DumpRenderTree
1859         https://bugs.webkit.org/show_bug.cgi?id=52692
1860
1861         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1862         This makes some tests that call notifyDone multiple times pass.
1863
1864         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1865         (WTR::InjectedBundle::InjectedBundle):
1866         (WTR::InjectedBundle::done):
1867         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1868         (WTR::InjectedBundle::topLoadingFrame):
1869         (WTR::InjectedBundle::setTopLoadingFrame):
1870         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1871         (WTR::InjectedBundlePage::InjectedBundlePage):
1872         (WTR::InjectedBundlePage::stopLoading):
1873         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1874         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1875         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1876         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1877         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1878         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1879         (WTR::LayoutTestController::notifyDone):
1880         * WebKitTestRunner/TestController.cpp:
1881         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1882
1883 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1884
1885         Reviewed by Kent Tamura.
1886
1887         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1888         https://bugs.webkit.org/show_bug.cgi?id=52678
1889
1890         Update path now that WebKit is inside Source.
1891
1892         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1893
1894 2011-01-18  Robert Hogan  <robert@webkit.org>
1895
1896         Reviewed by Simon Hausmann.
1897
1898         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1899         https://bugs.webkit.org/show_bug.cgi?id=44282
1900
1901         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1902         (WebCore::DumpRenderTree::dump):
1903
1904 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1905
1906         Reviewed by Mihai Parparita.
1907
1908         Fix a small race condition that could cause the unit tests for
1909         new-run-webkit-tests to fail in a multithreaded environment.
1910         There was a small window in the code where one thread would
1911         check to see if a thread had raised an exception, do something,
1912         and then check to see if the thread was alive. If the other
1913         thread raised an exception and exited in between these two
1914         steps, the exception would be lost. Flipping the order of the
1915         two checks fixes the race, since we will now always check for an
1916         exception on the thread before exiting.
1917
1918         https://bugs.webkit.org/show_bug.cgi?id=51579
1919
1920         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1921
1922 2011-01-18  Eric Seidel  <eric@webkit.org>
1923
1924         Reviewed by Adam Barth.
1925
1926         commit-queue dies when test archiving fails
1927         https://bugs.webkit.org/show_bug.cgi?id=52617
1928
1929         I looked at the machine and it had 10 archives already
1930         thus find_unused_name was returning None.  I've upped
1931         the limit to 100 (per bug) and tested the case where
1932         find_unused_name returns None (making archive return None).
1933
1934         * Scripts/webkitpy/common/system/workspace.py:
1935         * Scripts/webkitpy/common/system/workspace_unittest.py:
1936         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1937         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1938         * Scripts/webkitpy/tool/commands/queues.py:
1939
1940 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1941
1942         Reviewed by Ojan Vafai.
1943
1944         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1945         filesystem. Also fix a couple of "with" statements missed by
1946         r76050.
1947
1948         https://bugs.webkit.org/show_bug.cgi?id=52487
1949
1950         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1951
1952 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1953
1954         Reviewed by Martin Robinson.
1955
1956         [Gtk] Build fixes for gtk3 build
1957         https://bugs.webkit.org/show_bug.cgi?id=52648
1958
1959         * DumpRenderTree/gtk/EventSender.cpp:
1960         (beginDragWithFilesCallback):
1961
1962 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1963
1964         Reviewed by Mihai Parparita.
1965
1966         Update rebaseline-chromium-webkit-tests to use filesystem objects
1967         instead of direct references to os.path, shutil, tempfile, etc.
1968
1969         This patch doesn't change anything, but will allow subsequent
1970         patches to change the unit tests to no longer use the real
1971         filesystem.
1972
1973         This patch adds a bunch more methods to the filesystem object as
1974         well.
1975
1976         https://bugs.webkit.org/show_bug.cgi?id=52482
1977
1978         * Scripts/webkitpy/common/system/filesystem.py:
1979         * Scripts/webkitpy/common/system/filesystem_mock.py:
1980         * Scripts/webkitpy/tool/commands/queues.py:
1981         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1982         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1983
1984 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1985
1986         Reviewed by Mihai Parparita.
1987
1988         new-run-webkit-tests shouldn't crash when you try to run a
1989         directory containing only skipped files.
1990
1991         https://bugs.webkit.org/show_bug.cgi?id=52478
1992
1993         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1994         * Scripts/webkitpy/layout_tests/port/test.py:
1995         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1996
1997 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1998
1999         Reviewed by Gustavo Noronha Silva.
2000
2001         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2002         https://bugs.webkit.org/show_bug.cgi?id=40833
2003
2004         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2005         GTK+ event sender.
2006         (dragWithFilesDragDataGetCallback): Added.
2007         (dragWithFilesDragEndCallback): Added.
2008         (beginDragWithFilesCallback): Added.
2009
2010 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2011
2012         Reviewed by Adam Barth.
2013
2014         ews: Add additional watcher to efl ews
2015         https://bugs.webkit.org/show_bug.cgi?id=52613
2016
2017         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2018
2019         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2020
2021 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2022
2023         Reviewed by Alexey Proskuryakov.
2024
2025         Fix some headers with missing or misspelled #ifndef guards
2026         https://bugs.webkit.org/show_bug.cgi?id=52545
2027
2028         * DumpRenderTree/chromium/TestEventPrinter.h:
2029         * DumpRenderTree/chromium/WebPreferences.h:
2030
2031 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2032
2033         Reviewed by Anders Carlsson.
2034
2035         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2036         navigating back to an unreachable URL
2037         https://bugs.webkit.org/show_bug.cgi?id=52388
2038
2039         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2040
2041         * DumpRenderTree/LayoutTestController.cpp:
2042         (queueLoadHTMLStringCallback):
2043         (LayoutTestController::queueLoadHTMLString):
2044         (LayoutTestController::queueLoadAlternateHTMLString):
2045         * DumpRenderTree/LayoutTestController.h:
2046
2047         * DumpRenderTree/WorkQueueItem.h:
2048         (LoadHTMLStringItem::LoadHTMLStringItem):
2049
2050         * DumpRenderTree/chromium/LayoutTestController.cpp:
2051         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2052         (WorkItemLoadHTMLString::run):
2053         (LayoutTestController::queueLoadHTMLString):
2054
2055         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2056         (LoadHTMLStringItem::invoke):
2057         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2058         (LoadHTMLStringItem::invoke):
2059         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2060         (LoadHTMLStringItem::invoke):
2061
2062 2011-01-17  Dan Bernstein  <mitz@apple.com>
2063
2064         Rubber-stamped by Mark Rowe.
2065
2066         Update xcodeproj svn:ignore to include xcuserdata.
2067
2068         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2069         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2070         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2071         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2072         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2073
2074 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2075
2076         Unreviewed fix after r75908.
2077
2078         Move WebKit into Source
2079         https://bugs.webkit.org/show_bug.cgi?id=52530
2080
2081         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2082
2083 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2084
2085         Unreviewed.
2086
2087         Remove accidentally committed debug printing after r75908.
2088
2089         * Scripts/webkitdirs.pm:
2090
2091 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2092
2093         Unreviewed.
2094
2095         Add myself to committers list
2096         https://bugs.webkit.org/show_bug.cgi?id=52566
2097
2098         * Scripts/webkitpy/common/config/committers.py:
2099
2100 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2101
2102         Reviewed by Jeremy Orlow.
2103
2104         GeolocationController should call stopUpdating on destruction
2105         https://bugs.webkit.org/show_bug.cgi?id=52216
2106
2107         fast/dom/Geolocation/window-close-crash.html requires that a
2108         Geolocation watch be started in a secondary window. Consequently,
2109         we need to allow geolocation permission and provide a mock
2110         geolocation position for the secondary window's
2111         GeolocationClientMock.
2112
2113         * DumpRenderTree/chromium/LayoutTestController.cpp:
2114         (LayoutTestController::setGeolocationPermission):
2115         (LayoutTestController::setMockGeolocationPosition):
2116         (LayoutTestController::setMockGeolocationError):
2117         * DumpRenderTree/chromium/TestShell.h:
2118         (TestShell::windowList):
2119
2120 2011-01-16  Adam Barth  <abarth@webkit.org>
2121
2122         Update more include paths to reflect WebKit move.
2123
2124         * DumpRenderTree/chromium/EventSender.cpp:
2125         (EventSender::keyDown):
2126         (EventSender::needsShiftModifier):
2127         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2128         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2129
2130 2011-01-16  Kent Tamura  <tkent@chromium.org>
2131
2132         Unreviewed, Chromium build fix.
2133
2134         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2135
2136 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2137
2138         Build fix for GTK+ after source directory movement.
2139
2140         * GNUmakefile.am: Correct include paths.
2141
2142 2011-01-16  Adam Barth  <abarth@webkit.org>
2143
2144         Teach svn-apply about WebKit move.
2145
2146         * Scripts/VCSUtils.pm:
2147
2148 2011-01-16  Adam Barth  <abarth@webkit.org>
2149
2150         Rubber-stamped by Eric Seidel.
2151
2152         Move WebKit into Source
2153         https://bugs.webkit.org/show_bug.cgi?id=52530
2154
2155         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2156         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2157         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2158         * DumpRenderTree/qt/GCControllerQt.cpp:
2159         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2160         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2161         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2162         * DumpRenderTree/wscript:
2163         * QtTestBrowser/launcherwindow.h:
2164         * Scripts/build-webkit:
2165         * Scripts/webkitdirs.pm:
2166
2167 2011-01-15  Adam Barth  <abarth@webkit.org>
2168
2169         Teach svn-apply about WebKit2 move.
2170
2171         * Scripts/VCSUtils.pm:
2172
2173 2011-01-15  Adam Barth  <abarth@webkit.org>
2174
2175         Rubber-stamped by Eric Seidel.
2176
2177         Move WebKit2 into Source
2178         https://bugs.webkit.org/show_bug.cgi?id=52438
2179
2180         * MiniBrowser/qt/MiniBrowser.pro:
2181         * Scripts/build-webkit:
2182         * Scripts/do-file-rename:
2183         * Scripts/do-webcore-rename:
2184         * Scripts/test-webkitpy:
2185         * Scripts/webkitdirs.pm:
2186         * Scripts/webkitpy/style/checker.py:
2187         * WebKitTestRunner/DerivedSources.pro:
2188         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2189         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2190
2191 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2192
2193         Reviewed by David Levin.
2194
2195         [chromium] remove obsolete createView method
2196         https://bugs.webkit.org/show_bug.cgi?id=52437
2197
2198         * DumpRenderTree/chromium/WebViewHost.cpp:
2199         (WebViewHost::createView):
2200         * DumpRenderTree/chromium/WebViewHost.h:
2201
2202 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2203
2204         Reviewed by Geoff Garen.
2205
2206         ShouldLoadResourceForFrame should use strings, not URLs.
2207         https://bugs.webkit.org/show_bug.cgi?id=52476
2208
2209         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2210         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2211         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2212
2213 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2214
2215         Reviewed by David Levin.
2216
2217         Add Tony Gentilcore as a reviewer
2218         https://bugs.webkit.org/show_bug.cgi?id=52480
2219
2220         * Scripts/webkitpy/common/config/committers.py:
2221
2222 2011-01-14  David Levin  <levin@chromium.org>
2223
2224         Reviewed by Eric Seidel.
2225
2226         check-webkit-style: _FunctionState should keep track of where the function name starts.
2227         https://bugs.webkit.org/show_bug.cgi?id=52454
2228
2229         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2230         _FunctionState and logic for setting it correctly.
2231         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2232
2233 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2234
2235         Reviewed by David Levin.
2236
2237         Add support to DumpRenderTree to use the GPU rather than software renderer
2238         https://bugs.webkit.org/show_bug.cgi?id=52333
2239
2240         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2241         (main):
2242         * Scripts/webkitpy/layout_tests/port/chromium.py:
2243         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2244
2245 2011-01-14  Tony Chang  <tony@chromium.org>
2246
2247         Reviewed by Kent Tamura.
2248
2249         [chromium] update fonts.conf to fix 6 linux tests in drt
2250         https://bugs.webkit.org/show_bug.cgi?id=52411
2251
2252         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2253             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2254
2255 2011-01-14  Eric Seidel  <eric@webkit.org>
2256
2257         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2258
2259         Reviewed by Adam Barth.
2260
2261         Fix when running Tools/Scripts/check-webkit-style without arguments.
2262         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2263
2264         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2265         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2266
2267 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2268
2269         Reviewed by David Levin.
2270
2271         Store the tempdir object in a variable so it doesn't get deleted too early.
2272         https://bugs.webkit.org/show_bug.cgi?id=51875
2273
2274         * Scripts/update-webkit-auxiliary-libs:
2275         * Scripts/update-webkit-support-libs:
2276
2277 2011-01-14  Eric Seidel  <eric@webkit.org>
2278
2279         Unreviewed.  Make it work in python 2.5.
2280
2281         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2282         https://bugs.webkit.org/show_bug.cgi?id=49158
2283
2284         * Scripts/webkitpy/common/checkout/api_unittest.py:
2285
2286 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2287
2288         Unreviewed, rolling out r75774.
2289         http://trac.webkit.org/changeset/75774
2290         https://bugs.webkit.org/show_bug.cgi?id=52431
2291
2292         gtk builds were broken (Requested by loislo2 on #webkit).
2293
2294         * Scripts/webkitpy/common/checkout/scm.py:
2295
2296 2011-01-14  David Levin  <levin@chromium.org>
2297
2298         Reviewed by Shinichiro Hamaji.
2299
2300         check-webkit-style: _FunctionState should detect pure functions.
2301         https://bugs.webkit.org/show_bug.cgi?id=52428
2302
2303         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2304         is a pure virtual function.
2305         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2306         virtual functions are correctly detected.
2307
2308 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2309
2310         Reviewed by Yury Semikhatsky.
2311
2312         Just small fix for problem with check-webkit-style.
2313         It just didn't work for this patch.
2314         Old code can't concatenate a list of strings with None.
2315
2316         * Scripts/webkitpy/common/checkout/scm.py:
2317
2318 2011-01-13  David Levin  <levin@chromium.org>
2319
2320         Reviewed by Shinichiro Hamaji.
2321
2322         check-webkit-style: _FunctionState should use Position to know where items are.
2323         https://bugs.webkit.org/show_bug.cgi?id=52424
2324
2325         * Scripts/webkitpy/style/checkers/cpp.py:
2326         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2327         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2328         did some minor clean-up.
2329         (*): Other changes are simply about converting to use the Position's in_FunctionState
2330         instead of line numbers.
2331         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2332         to verify the positions stored in _FunctionState.
2333
2334 2011-01-13  Eric Seidel  <eric@webkit.org>
2335
2336         Reviewed by David Levin.
2337
2338         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2339         https://bugs.webkit.org/show_bug.cgi?id=49158
2340
2341         This is not the most elegant, but it is a very safe fix to this bug.
2342         One advantage of catching ScriptError like this instead of adding a
2343         new added_or_modified_files or fixing all changed_files callers
2344         to use a more specific change_files variant, is that we catch
2345         all kinds of ScriptErrors which might cause our (non-essential)
2346         suggest-reviewers code to fail out.  This should make passing
2347         --suggest-reviewers to webkit-patch upload much more robust
2348         and may even make it possible for us to make it default.
2349
2350         The root of the problem here is that SCM.changed_files includes
2351         deleted ChangeLog paths (from moves, etc) which then when we ask
2352         SVN/Git for the contents of the file at that revision, the command
2353         errors out and Executive.run_command raises a ScriptError.
2354
2355         In the future we might fix this differently by making all current
2356         callers of chagned_files use a more specific method for requesting
2357         what types of changes they're interested in (adds, modifies, deletes, etc.)
2358
2359         * Scripts/webkitpy/common/checkout/api.py:
2360         * Scripts/webkitpy/common/checkout/api_unittest.py:
2361
2362 2011-01-13  Dan Bernstein  <mitz@apple.com>
2363
2364         Reviewed by Alexey Proskuryakov.
2365
2366         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2367         https://bugs.webkit.org/show_bug.cgi?id=52419
2368
2369         Allow to further control the behavior of the willSendRequest delegate callback by making it
2370         set a different URL in the new request.
2371
2372         * DumpRenderTree/LayoutTestController.cpp:
2373         (addURLToRedirectCallback): Added.
2374         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2375         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2376         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2377         * DumpRenderTree/LayoutTestController.h:
2378         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2379         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2380         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2381         change the URL in the new request to the redirect destination.
2382
2383 2011-01-13  Eric Seidel  <eric@webkit.org>
2384
2385         Reviewed by Mihai Parparita.
2386
2387         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2388         https://bugs.webkit.org/show_bug.cgi?id=52416
2389
2390         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
2391         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2392
2393         I also added FIXMEs about the changed_files returning deleted files problem
2394         which is causing the other most common exception for suggest-reviewers
2395         (and is probably breaking sheriff-bots blame detection).
2396
2397         * Scripts/webkitpy/common/checkout/api.py:
2398         * Scripts/webkitpy/common/checkout/api_unittest.py:
2399         * Scripts/webkitpy/common/checkout/scm.py:
2400
2401 2011-01-13  Eric Seidel  <eric@webkit.org>
2402
2403         Reviewed by Adam Barth.
2404
2405         results archives from commit-queue are too large to upload
2406         https://bugs.webkit.org/show_bug.cgi?id=52405
2407
2408         * Scripts/webkitpy/common/system/filesystem.py:
2409         * Scripts/webkitpy/common/system/filesystem_mock.py:
2410         * Scripts/webkitpy/tool/commands/queues.py:
2411
2412 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2413
2414         Reviewed by Martin Robinson.
2415
2416         [gtk] Zero-sized font does not yet work
2417         https://bugs.webkit.org/show_bug.cgi?id=49793
2418
2419         Set minimum-font-size to 0 for the DRT.
2420
2421         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2422         (resetDefaultsToConsistentValues):
2423
2424 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2425
2426         Reviewed by Darin Adler.
2427
2428         Make old-run-webkit-tests more robust on buildbots
2429         https://bugs.webkit.org/show_bug.cgi?id=52364
2430
2431         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2432
2433 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2434
2435         Reviewed by Darin Adler.
2436
2437         Make old-run-webkit-tests more robust on buildbots
2438         https://bugs.webkit.org/show_bug.cgi?id=52364
2439
2440         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2441
2442 2011-01-13  Tony Chang  <tony@chromium.org>
2443
2444         Reviewed by Kent Tamura.
2445
2446         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2447         https://bugs.webkit.org/show_bug.cgi?id=52332
2448
2449         Forked Info.plist is not longer needed.
2450
2451         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2452
2453 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2454
2455         Reviewed by Timothy Hatcher.
2456
2457         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2458         to be passed directly to WebInspector.UIString
2459
2460         https://bugs.webkit.org/show_bug.cgi?id=52365
2461
2462         * Scripts/check-inspector-strings:
2463
2464 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2465
2466         Unreviewed, rolling out r74881.
2467         http://trac.webkit.org/changeset/74881
2468         https://bugs.webkit.org/show_bug.cgi?id=52357
2469
2470         The EFL builder has been red for days (Requested by abarth on
2471         #webkit).
2472
2473         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2474         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2475
2476 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2477
2478         Reviewed by David Levin.
2479
2480         Add beforeunload support to WebKitTestRunner
2481         https://bugs.webkit.org/show_bug.cgi?id=52353
2482
2483         This makes a number of currently failing tests pass.
2484
2485         * WebKitTestRunner/TestController.cpp:
2486         (WTR::runBeforeUnloadConfirmPanel):
2487         (WTR::createOtherPage):
2488         (WTR::TestController::initialize):
2489
2490 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2491
2492         Reviewed by Sam Weinig.
2493
2494         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2495         https://bugs.webkit.org/show_bug.cgi?id=52330
2496
2497         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2498         a web process crash.
2499         * WebKitTestRunner/TestController.cpp:
2500         (WTR::TestController::initialize): Set up a processDidCrash
2501         callback.
2502         (WTR::TestController::processDidCrash): Report that the Web process
2503         crashed.
2504         * WebKitTestRunner/TestController.h:
2505
2506 2011-01-12  David Levin  <levin@chromium.org>
2507
2508         Reviewed by Shinichiro Hamaji.
2509
2510         check-webkit-style -- close_expression function doesn't work correctly.
2511         https://bugs.webkit.org/show_bug.cgi?id=52272
2512
2513         * Scripts/webkitpy/style/checkers/cpp.py:
2514         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2515         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2516         generally useful (for upcoming code changes).
2517         (close_expression): Changed to use Position for input and output.
2518         Also, fixed many bugs such as only working correctly for parenthesis,
2519         not working correctly if given an offset in a line and not finding
2520         the real closing element if there were multiple closing elements in
2521         the same line.
2522         (detect_functions): Adjusted due to the change in arguments for
2523         close_expression.
2524         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2525         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2526         two positions are the same.
2527         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2528         (CppStyleTest.test_close_expression): Added tests to catch the issues
2529         that were fixed.
2530
2531 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2532
2533         Unreviewed, rolling out r75576.
2534         http://trac.webkit.org/changeset/75576
2535         https://bugs.webkit.org/show_bug.cgi?id=52304
2536
2537         broke rebaseline-chromium-webkit-test (Requested by thakis on
2538         #webkit).
2539
2540         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2541         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2542         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2543         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2544         * Scripts/webkitpy/layout_tests/port/base.py:
2545         * Scripts/webkitpy/layout_tests/port/chromium.py:
2546         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2547         * Scripts/webkitpy/layout_tests/port/test.py:
2548         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2549         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2550         * Scripts/webkitpy/style/checkers/test_expectations.py:
2551         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2552
2553 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2554
2555         Reviewed by Darin Adler.
2556
2557         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2558         https://bugs.webkit.org/show_bug.cgi?id=52307
2559
2560         * Scripts/old-run-webkit-tests:
2561
2562 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2563
2564         Reviewed by Martin Robinson.
2565
2566         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2567         https://bugs.webkit.org/show_bug.cgi?id=50867
2568
2569         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2570         TestNetscapePlugin.cpp
2571
2572         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2573         * Scripts/webkitdirs.pm:
2574
2575 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2576
2577         Reviewed by Pavel Feldman.
2578
2579         Add check-inspector-strings script.
2580
2581         https://bugs.webkit.org/show_bug.cgi?id=52295
2582
2583         * Scripts/check-inspector-strings: Added.
2584
2585 2011-01-12  Adam Roben  <aroben@apple.com>
2586
2587         Advertise the .testnetscape file extension on Windows
2588
2589         Fixes <http://webkit.org/b/52298>
2590         plugins/no-mime-with-valid-extension.html fails on Windows
2591
2592         Reviewed by Dan Bernstein.
2593
2594         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2595         FileExtents field to map the .testnetscape file extension to the
2596         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2597
2598 2011-01-12  Adam Barth  <abarth@webkit.org>
2599
2600         Reviewed by Eric Seidel.
2601
2602         Make webkit-patch support subdirectories for SVN checkouts
2603         https://bugs.webkit.org/show_bug.cgi?id=52261
2604
2605         os.relpath does not exist on Python 2.5, so we need to call our version
2606         of the API.
2607
2608         * Scripts/webkitpy/common/checkout/scm.py:
2609
2610 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2611
2612         Reviewed by Eric Seidel.
2613
2614         Close additional pages opened during a test once the test completes.
2615         https://bugs.webkit.org/show_bug.cgi?id=52276
2616
2617         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2618         (WTR::InjectedBundle::done):
2619
2620 2011-01-11  David Levin  <levin@chromium.org>
2621
2622         Reviewed by Eric Seidel.
2623
2624         Errors should be separated from the command line in bot messages.
2625         https://bugs.webkit.org/show_bug.cgi?id=52275
2626
2627         * Scripts/webkitpy/common/system/executive.py:
2628         (ScriptError.message_with_output): Added a newline to separate the command
2629         line from the errors.
2630         * Scripts/webkitpy/common/system/executive_unittest.py:
2631         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2632         paths in message_with_output.
2633
2634 2011-01-11  Eric Seidel  <eric@webkit.org>
2635
2636         Unreviewed.
2637
2638         commit-queue should know how to upload archived results (for test flakes or general failures)
2639         https://bugs.webkit.org/show_bug.cgi?id=52048
2640
2641         The zips are mostly empty due to forgetting -r.
2642         Expected diffs were not being pulled from the archive due
2643         to the archive having longer paths than I realized.
2644
2645         * Scripts/webkitpy/common/system/workspace.py:
2646         * Scripts/webkitpy/common/system/workspace_unittest.py:
2647         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2648         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2649
2650 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2651
2652         Reviewed by Ojan Vafai.
2653
2654         The current modifier parsing code in test_expectations is
2655         fragile and hard-coded, so it's not easy to understand the logic
2656         or easily add new types of modifiers (like GPU vs. CPU testing
2657         for graphics tests, or 32-bit vs. 64-bit differences).
2658
2659         This is the first of two patches that will add in more generic
2660         support and then eliminate the GPU-specific test expectations
2661         files for Chromium.
2662
2663         This patch adds two standalone objects for handling modifiers. The
2664         rules for interpreting modifiers, precedence, and conflicts are
2665         given in the docstring to the ModifierMatcher class, which
2666         returns ModifierMatchResult objects.
2667
2668         This patch also adds routines to the Port interface and a
2669         default set of values in the base object, in order to obtain the
2670         values needed on a given test run. These values are then passed
2671         to the expectation parser. This also allows us to clean up the
2672         logic used to lint all of the different configurations in a
2673         single test_expectations.txt file.
2674
2675         The next patch will merge in the separate GPU expectations file.
2676
2677         https://bugs.webkit.org/show_bug.cgi?id=51222
2678
2679         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2680         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2681         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2682         * Scripts/webkitpy/layout_tests/port/base.py:
2683         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2684         * Scripts/webkitpy/layout_tests/port/chromium.py:
2685         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2686         * Scripts/webkitpy/layout_tests/port/test.py:
2687         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2688         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2689
2690 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2691
2692         Reviewed by Adam Barth.
2693
2694         Make webkit-patch support subdirectories for SVN checkouts
2695         https://bugs.webkit.org/show_bug.cgi?id=52261
2696
2697         * Scripts/webkitpy/common/checkout/scm.py:
2698         * Scripts/webkitpy/style_references.py:
2699         * Scripts/webkitpy/tool/main.py:
2700         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2701
2702 2011-01-11  Eric Seidel  <eric@webkit.org>
2703
2704         Unreviewed.
2705
2706         commit-queue should know how to upload archived results (for test flakes or general failures)
2707         https://bugs.webkit.org/show_bug.cgi?id=52048
2708
2709         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2710         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2711
2712         * Scripts/webkitpy/common/system/workspace.py:
2713         * Scripts/webkitpy/common/system/workspace_unittest.py:
2714         * Scripts/webkitpy/tool/commands/queues.py:
2715
2716 2011-01-11  Sam Weinig  <sam@webkit.org>
2717
2718         Roll r75474 back in.
2719
2720 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2721
2722         Reviewed by Kenneth Rohde Christiansen.
2723
2724         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2725         https://bugs.webkit.org/show_bug.cgi?id=51204
2726
2727         * QtTestBrowser/webpage.h:
2728         (QtNAMThread::QtNAMThread):
2729         (QtNAMThread::networkAccessManager):
2730         (QtNAMThread::run):
2731
2732 2011-01-11  Peter Varga  <pvarga@webkit.org>
2733
2734         Unreviewed.
2735
2736         Add myself to committers' list.
2737
2738         * Scripts/webkitpy/common/config/committers.py:
2739
2740 2011-01-11  Eric Seidel  <eric@webkit.org>
2741
2742         Reviewed by Adam Barth.
2743
2744         commit-queue should know how to upload archived results (for test flakes or general failures)
2745         https://bugs.webkit.org/show_bug.cgi?id=52048
2746
2747         Now the queue will always upload results.  Either the entire zip, or just
2748         the diffs.txt in the case of text failures.
2749
2750         This should make understanding flakes much easier, and paves the way
2751         for having the EWS run layout tests (and upload failures).
2752
2753         In order to upload .zip files I had to teach bugzilla.py to autodetect
2754         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2755         for .patch files, I have it add one before calling guess_type.
2756
2757         We may find that always uploading the whole zip instead of just the -diffs.txt
2758         file is preferable, but for now I'm keeping the old behavior because it makes
2759         quickly understanding text failures easy.
2760
2761         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2762         * Scripts/webkitpy/common/system/workspace.py: Added.
2763         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2764         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2765         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2766         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2767         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2768         * Scripts/webkitpy/tool/commands/queues.py:
2769         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2770
2771 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2772
2773         Unreviewed, rolling out r75464.
2774         http://trac.webkit.org/changeset/75464
2775         https://bugs.webkit.org/show_bug.cgi?id=52193
2776
2777         Followup rollout for 75474 (Requested by Ossy on #webkit).
2778
2779         * MiniBrowser/mac/BrowserWindowController.m:
2780         (-[BrowserWindowController awakeFromNib]):
2781         * MiniBrowser/win/BrowserView.cpp:
2782         (BrowserView::create):
2783         * WebKitTestRunner/TestController.cpp:
2784         (WTR::createOtherPage):
2785         (WTR::TestController::initialize):
2786
2787 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2788
2789         Reviewed by Csaba Osztrogonác.
2790
2791         [Qt] Baseline qt_minimal configuration
2792         https://bugs.webkit.org/show_bug.cgi?id=51313
2793
2794         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2795         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2796         QT_NO_UNDOSTACK guard.
2797
2798         * QtTestBrowser/launcherwindow.cpp:
2799         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2800         guards.
2801         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2802         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2803         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2804         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2805
2806         * QtTestBrowser/launcherwindow.h:
2807         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2808         * QtTestBrowser/locationedit.h: Ditto.
2809
2810         * QtTestBrowser/mainwindow.cpp:
2811         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2812         QT_NO_UNDOSTACK guards.
2813         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2814         (MainWindow::changeLocation): Ditto.
2815         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2816         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2817
2818         * QtTestBrowser/webpage.cpp:
2819         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2820         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2821
2822         * QtTestBrowser/webview.cpp:
2823         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2824         (WebViewGraphicsBased::animatedYFlip): Ditto.
2825
2826 2011-01-10  Sam Weinig  <sam@webkit.org>
2827
2828         Fix build.
2829
2830         * MiniBrowser/mac/BrowserWindowController.m:
2831         (-[BrowserWindowController awakeFromNib]):
2832         * MiniBrowser/win/BrowserView.cpp:
2833         (BrowserView::create):
2834         * WebKitTestRunner/TestController.cpp:
2835         (WTR::createOtherPage):
2836         (WTR::TestController::initialize):
2837
2838 2011-01-10  Eric Seidel  <eric@webkit.org>
2839
2840         Reviewed by Ojan Vafai.
2841
2842         style-queue messages are way too long for big patches
2843         https://bugs.webkit.org/show_bug.cgi?id=52161
2844
2845         We definitely could build much fancier list-to-string-with-limit functions
2846         but this should be sufficient for our needs at the moment.
2847
2848         * Scripts/webkitpy/common/system/executive.py:
2849         * Scripts/webkitpy/common/system/executive_unittest.py:
2850
2851 2011-01-10  Tony Chang  <tony@chromium.org>
2852
2853         Unreviewed, rolling out r75398.
2854         http://trac.webkit.org/changeset/75398
2855         https://bugs.webkit.org/show_bug.cgi?id=52008
2856
2857         Some layout tests are crashing on Chromium Win.
2858
2859         * DumpRenderTree/chromium/WebViewHost.cpp:
2860         (WebViewHost::updatePaintRect):
2861         * DumpRenderTree/chromium/WebViewHost.h:
2862
2863 2011-01-10  Adam Roben  <aroben@apple.com>
2864
2865         Roll out r75392
2866
2867         It isn't needed now that r75289 has been rolled out.
2868
2869         * Scripts/run-javascriptcore-tests:
2870
2871 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2872
2873         Reviewed by Anders Carlsson.
2874
2875         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2876         https://bugs.webkit.org/show_bug.cgi?id=52160
2877
2878         * WebKitTestRunner/mac/TestControllerMac.mm:
2879         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2880         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2881         anyway.
2882
2883 2011-01-10  Tony Chang  <tony@chromium.org>
2884
2885         Reviewed by Mihai Parparita.
2886
2887         [chromium] fix for animated gif layout tests
2888         https://bugs.webkit.org/show_bug.cgi?id=52008
2889
2890         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2891             to trigger gif animations.
2892         (WebViewHostPaintTask::WebViewHostPaintTask):
2893         (WebViewHostPaintTask::runIfValid):
2894         (WebViewHost::updatePaintRect):
2895         * DumpRenderTree/chromium/WebViewHost.h:
2896         (WebViewHost::taskList):
2897
2898 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2899
2900         Reviewed by Xan Lopez.
2901
2902         [GTK] Fix gtk2 compilation for master
2903         https://bugs.webkit.org/show_bug.cgi?id=51885
2904
2905         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2906         (createBitmapContextFromWebView): Replaced the old
2907         gdk_drawable_get_size with gdk_pixmap_get_size.
2908
2909 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2910
2911         Reviewed by Laszlo Gombos.
2912
2913         [WINCE] Reenable NPAPI after r75203
2914         https://bugs.webkit.org/show_bug.cgi?id=52109
2915
2916         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2917         it with !isEfl(), because EFL port does not support NPAPI (yet).
2918
2919         * Scripts/build-webkit:
2920
2921 2011-01-10  Adam Roben  <aroben@apple.com>
2922
2923         Skip some asserting JS tests
2924
2925         See <http://webkit.org/b/52156>.
2926
2927         * Scripts/run-javascriptcore-tests:
2928
2929 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2930
2931         Reviewed by Xan Lopez.
2932
2933         [GTK] build-webkit disable Blob support via arguments passed to automake
2934         https://bugs.webkit.org/show_bug.cgi?id=52097
2935
2936         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2937         build-webkit.
2938
2939 2011-01-10  Adam Roben  <aroben@apple.com>
2940
2941         Use the same name and description for TestNetscapePlugin on Windows and
2942         Mac
2943
2944         Fixes <http://webkit.org/b/52151>
2945         fast/frames/iframe-reparenting-plugins.html fails on Windows
2946
2947         Reviewed by Steve Falkenburg.
2948
2949         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2950         the name and description from Mac's Info.plist.
2951
2952 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2953
2954         Reviewed by Laszlo Gombos.
2955
2956         [Qt][WK2] Guard gcc-specific syntax
2957
2958         Non-gcc based compliers choke on the "-include"
2959         syntax for preinclude, place guard around it.
2960
2961         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2962         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2963
2964 2011-01-10  Andreas Kling  <kling@webkit.org>
2965
2966         Reviewed by Simon Hausmann.
2967
2968         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2969         https://bugs.webkit.org/show_bug.cgi?id=52111
2970
2971         When getting a createNewPage() callback from QWKPage, create the
2972         new page with the same QWKContext as the page that is passed to
2973         the callback.
2974
2975         * MiniBrowser/qt/BrowserView.h:
2976         * MiniBrowser/qt/BrowserWindow.cpp:
2977         (newPageFunction):
2978         (BrowserWindow::BrowserWindow):
2979         * MiniBrowser/qt/BrowserWindow.h:
2980
2981 2011-01-10  Andreas Kling  <kling@webkit.org>
2982
2983         Reviewed by Kenneth Rohde Christiansen.
2984
2985         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2986
2987         BrowserView set its own useless createNewPage() callback on QWKPage.
2988         This was immediately overridden by BrowserWindow anyway, so remove
2989         the BrowserView one.
2990
2991         * MiniBrowser/qt/BrowserView.cpp:
2992         (BrowserView::BrowserView):
2993
2994 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2995
2996         Reviewed by Jeremy Orlow.
2997
2998         [Chromium] Remove non-client-based Geolocation code
2999         https://bugs.webkit.org/show_bug.cgi?id=50921
3000
3001         * DumpRenderTree/chromium/LayoutTestController.cpp:
3002         (LayoutTestController::setGeolocationPermission):
3003         (LayoutTestController::setMockGeolocationPosition):
3004         (LayoutTestController::setMockGeolocationError):
3005         * DumpRenderTree/chromium/WebViewHost.cpp:
3006         (WebViewHost::geolocationClientMock):
3007         (WebViewHost::reset):
3008         * DumpRenderTree/chromium/WebViewHost.h:
3009
3010 2011-01-10  Eric Seidel  <eric@webkit.org>
3011
3012         Reviewed by Adam Barth.
3013
3014         Commit bot tried to land r? cq+ patch
3015         https://bugs.webkit.org/show_bug.cgi?id=36638
3016
3017         It should now be possible to post a patch with r? and cq+ and the
3018         commit-queue will correctly wait for the r+ before attempting to land the patch.
3019         (This was a feature requested by several users.)
3020
3021         One caveat: We don't actually reject r-, cq+ patches from the queue
3022         (we just ignore them), but I think that's OK for now.
3023
3024         I also noticed that setting r- once a commit-queue node had grabbed
3025         a patch would not properly cancel the landing.  That's fixed and
3026         tested in this patch.
3027
3028         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3029         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3030         * Scripts/webkitpy/tool/bot/feeders.py:
3031         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3032
3033 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3034
3035         Reviewed by Kenneth Rohde Christiansen.
3036
3037         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3038         https://bugs.webkit.org/show_bug.cgi?id=51934
3039
3040         When accessing the network from the destructor of QWebPage, the network access manager
3041         was already deleted because the object WebPage was already destructed.
3042
3043         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3044         The object is now destructed in the destructor of QObject.
3045
3046         * QtTestBrowser/webpage.cpp:
3047         (WebPage::WebPage):
3048         (WebPage::setQnamThreaded):
3049         * QtTestBrowser/webpage.h:
3050         (QtNAMThread::QtNAMThread):
3051
3052 2011-01-08  Eric Seidel  <eric@webkit.org>
3053
3054         Reviewed by Ojan Vafai.
3055
3056         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3057         https://bugs.webkit.org/show_bug.cgi?id=52067
3058
3059         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3060         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3061
3062         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3063
3064 2011-01-08  Eric Seidel  <eric@webkit.org>
3065
3066         Reviewed by Mihai Parparita.
3067
3068         commit-queue hangs when the ChangeLog diff is bad
3069         https://bugs.webkit.org/show_bug.cgi?id=52072
3070
3071         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3072         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3073
3074 2011-01-08  Adam Barth  <abarth@webkit.org>
3075
3076         Teach svn-apply how to re-write WebCore to Source/WebCore.
3077
3078         * Scripts/VCSUtils.pm:
3079
3080 2011-01-07  Adam Barth  <abarth@webkit.org>
3081
3082         Rubber-stamped by Eric Seidel.
3083
3084         Move WebCore to Source
3085         https://bugs.webkit.org/show_bug.cgi?id=52050
3086
3087         Update the tools to understand WebCore's new location.
3088
3089         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3090         * DumpRenderTree/wscript:
3091         * GNUmakefile.am:
3092         * Scripts/build-webkit:
3093         * Scripts/do-file-rename:
3094         * Scripts/do-webcore-rename:
3095         * Scripts/generate-qt-inspector-resource:
3096         * Scripts/prepare-ChangeLog:
3097         * Scripts/run-bindings-tests:
3098         * Scripts/update-iexploder-cssproperties:
3099         * Scripts/update-sources-list.py:
3100         * Scripts/update-webkit-localizable-strings:
3101         * Scripts/webkitdirs.pm:
3102         * Scripts/webkitpy/common/config/build.py:
3103         * Scripts/webkitpy/common/config/build_unittest.py:
3104         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3105         * Scripts/webkitpy/style/checker.py:
3106         * Scripts/webkitpy/style/checker_unittest.py:
3107         * WebKitTestRunner/DerivedSources.pro:
3108         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3109         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3110         * wx/browser/wscript:
3111         * wx/build/settings.py:
3112
3113 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3114
3115         Reviewed by Sam Weinig.
3116
3117         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3118         https://bugs.webkit.org/show_bug.cgi?id=52086
3119
3120         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3121         (WTR::InjectedBundle::didReceiveMessage):
3122         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3123         (WTR::LayoutTestController::notifyDone):
3124         * WebKitTestRunner/TestController.cpp:
3125         (WTR::TestController::resetStateToConsistentValues):
3126         (WTR::TestController::run):
3127
3128 2011-01-07  James Robinson  <jamesr@chromium.org>
3129
3130         Revert "Implement mozilla's animationTime property"
3131         https://bugs.webkit.org/show_bug.cgi?id=51952
3132
3133         This approach isn't quite right.
3134
3135         * DumpRenderTree/chromium/WebViewHost.cpp:
3136         (WebViewHost::paintInvalidatedRegion):
3137
3138 2011-01-07  Adam Roben  <aroben@apple.com>
3139
3140         Build master fix
3141
3142         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3143         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3144
3145 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3146
3147         Reviewed by Csaba Osztrogonác.
3148
3149         run-qtwebkit-tests should be able to kill a testsuite.
3150
3151         Add new option in the script that can setup a timeout for a test.
3152         If the test execution takes more then specified time then the test
3153         would be terminated.
3154
3155         [Qt] run-qtwebkit-tests needs timeout
3156         https://bugs.webkit.org/show_bug.cgi?id=51894
3157
3158         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3159         * Scripts/run-qtwebkit-tests:
3160
3161 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3162
3163         Unreviewed fix after r75233.
3164
3165         Based on idea from Eric Seidel.
3166
3167         Add remote zip file handling to webkitpy.
3168         https://bugs.webkit.org/show_bug.cgi?id=50901
3169
3170         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3171
3172 2011-01-07  Shane Stephens  <shanestephens@google.com>
3173
3174         Reviewed by Eric Seidel.
3175
3176         svn-apply: should support git binary delta diffs
3177         https://bugs.webkit.org/show_bug.cgi?id=38864
3178
3179         * Scripts/VCSUtils.pm:
3180         * Scripts/svn-apply:
3181
3182 2011-01-06  Julie Parent  <jparent@chromium.org>
3183
3184         Reviewed by Eric Seidel.
3185
3186         Test Result Server not removing old results.
3187         https://bugs.webkit.org/show_bug.cgi?id=52012
3188
3189         * TestResultServer/model/jsonresults.py:
3190         Fix off-by-one: Truncate if >= num_runs, not just >.
3191         * TestResultServer/model/jsonresults_unittest.py:
3192         Add unit test to test that merging in a new result with the same value
3193         as the last result causes previous result to fall off.
3194
3195 2011-01-06  James Kozianski  <koz@chromium.org>
3196
3197         Reviewed by Mihai Parparita.
3198
3199         Add classes to provide a consistent interface to a set of files.
3200         https://bugs.webkit.org/show_bug.cgi?id=50901
3201
3202         These classes allow us to write code that is agnostic to whether a
3203         particular set of files resides in a local directory or in a zip file
3204         on a remote machine.
3205
3206         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3207         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3208         * Scripts/webkitpy/common/system/fileset.py: Added.
3209         * Scripts/webkitpy/common/system/filesystem.py:
3210         * Scripts/webkitpy/common/system/filesystem_mock.py:
3211         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3212         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3213
3214 2011-01-06  Eric Seidel  <eric@webkit.org>
3215
3216         Reviewed by Adam Barth.
3217
3218         NetworkTransaction should log the url it is retrying
3219         https://bugs.webkit.org/show_bug.cgi?id=52043
3220
3221         * Scripts/webkitpy/common/net/networktransaction.py:
3222         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3223
3224 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3225
3226         Windows build fix.
3227         Import os before using it.
3228
3229         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3230
3231 2011-01-06  Eric Seidel  <eric@webkit.org>
3232
3233         Reviewed by Adam Barth.
3234
3235         StyleQueue fails to report errors when patches have many files
3236         https://bugs.webkit.org/show_bug.cgi?id=52042
3237
3238         This is one of at least two errors preventing style error reporting at the moment.
3239         When we moved to passing the list of files to check explicitly,
3240         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3241         We could change the type of the QueueStatus.message type, or we could
3242         just teach statusserver.py how to clamp values (and warn when it does).
3243         I chose the latter path.
3244
3245         * Scripts/webkitpy/common/net/statusserver.py:
3246
3247 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3248
3249         Reviewed by Stephanie Lewis.
3250
3251         Fix syntax error in script.
3252
3253         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3254         https://bugs.webkit.org/show_bug.cgi?id=51996
3255
3256         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3257
3258 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3259
3260         Unreviewed, fixing WinCE build after r75196.
3261
3262         WinCE port does not (yet) support NPAPI.
3263
3264         * Scripts/build-webkit:
3265
3266 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3267
3268         Reviewed by Darin Adler.
3269
3270         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3271         https://bugs.webkit.org/show_bug.cgi?id=52015
3272
3273         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3274         after the platform has been detected, otherwise the script will
3275         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3276         detection.
3277
3278 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3279
3280         Reviewed by Eric Seidel.
3281
3282         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3283         https://bugs.webkit.org/show_bug.cgi?id=51346
3284
3285         * Scripts/build-webkit:
3286
3287 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3288
3289         Reviewed by Adam Roben.
3290
3291         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3292         https://bugs.webkit.org/show_bug.cgi?id=51996
3293
3294         After the configuration directory change, we were archiving the incorrect directory for
3295         build product, so we were running tests on the wrong binaries.
3296
3297         This change archives the correct directory, and also unarchives it into a configuration-
3298         specific directory.
3299
3300         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3301         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3302
3303 2011-01-06  Eric Seidel  <eric@webkit.org>
3304
3305         Reviewed by Mihai Parparita.
3306
3307         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3308         https://bugs.webkit.org/show_bug.cgi?id=52002
3309
3310         See an example of this here:
3311         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3312
3313         It's due to the fact that we pass around TestFailure() instance
3314         objects and yet expect them to all compare to be the same.
3315
3316         This is bad.  We should either have shared instances of these values
3317         or we should just pass around the class names.  There are already hacks
3318         in place to make TestFailure objects pass equality tests, I just added
3319         a __hash__ implementation so they can be used in sets as expected.
3320
3321         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3322         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3323
3324 2011-01-06  Evan Martin  <evan@chromium.org>
3325
3326         Reviewed by Tony Chang.
3327
3328         [gdb] handle inaccessible memory and UChar*
3329         https://bugs.webkit.org/show_bug.cgi?id=52003
3330
3331         To pretty-print a UChar*, we just grope around in the memory
3332         looking for a terminating NUL.  We need to handle the exception
3333         that can occur when we poke into an invalid location.
3334
3335         Additionally, the logic for choosing which pretty-printer would
3336         early return before hitting the point where we'd use the UChar*
3337         printer.  (Did this ever work?  How did it regress?)
3338
3339         * gdb/webkit.py:
3340
3341 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3342
3343         Reviewed by Ada Chan.
3344
3345         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3346         https://bugs.webkit.org/show_bug.cgi?id=51969
3347
3348         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3349
3350         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3351         (WTR::InjectedBundlePage::InjectedBundlePage):
3352         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3354
3355 2011-01-06  James Robinson  <jamesr@chromium.org>
3356
3357         Reviewed by Simon Fraser.
3358
3359         Implement mozilla's animationTime property
3360         https://bugs.webkit.org/show_bug.cgi?id=51952
3361
3362         Chromium DRT support for webkitAnimationTime.
3363
3364         * DumpRenderTree/chromium/WebViewHost.cpp:
3365         (WebViewHost::paintInvalidatedRegion):
3366
3367 2011-01-06  Julie Parent  <jparent@chromium.org>
3368
3369         Reviewed by Tony Chang.
3370
3371         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3372         https://bugs.webkit.org/show_bug.cgi?id=51217
3373
3374         * TestResultServer/model/jsonresults.py:
3375         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3376         Adds missing documentation.
3377         * TestResultServer/model/jsonresults_unittest.py:
3378         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3379         Update test_merge to take a number of builds to truncate at.
3380
3381 2011-01-06  Adam Barth  <abarth@webkit.org>
3382
3383         Reviewed by Eric Seidel.
3384
3385         The EWS should log outside of the working directory
3386         https://bugs.webkit.org/show_bug.cgi?id=51986
3387
3388         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3389         script, which will actually clean the working copy back to a pristine
3390         state instead of leaving untracked directories and ignored files.
3391
3392         * Scripts/webkitpy/tool/commands/queues.py:
3393         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3394
3395 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3396
3397         Windows build fix.
3398         Back out attempted change to built-product-archive.
3399
3400         * BuildSlaveSupport/built-product-archive:
3401
3402 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3403
3404         Windows build fix.
3405         Include configuration name when unpacking a build archive.
3406
3407         Needed, since we split Windows build results into configuration-specific directories
3408         under WebKitOutputDir.
3409
3410         * BuildSlaveSupport/built-product-archive:
3411
3412 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3413
3414         Reviewed by Darin Adler.
3415
3416         Debug and Release builds on Windows clobber each other
3417         https://bugs.webkit.org/show_bug.cgi?id=49185
3418
3419         Changes the structure of WebKitBuild build products directory so we
3420         completely separate each build configuration into independent directories.
3421
3422         Although we previously had per-configuration directories for obj, this change adds
3423         per-configuration directories for bin, lib, obj, and include. Each configuration's
3424         build products are stored within a directory inside of WebKitBuild.
3425
3426         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3427         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3428
3429         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3430         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3431         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3432         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3433         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3434         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3435         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3436         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3437         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3438         * FindSafari/FindSafari.vcproj:
3439         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3440         * MiniBrowser/MiniBrowserPostBuild.cmd:
3441         * MiniBrowser/MiniBrowserPreBuild.cmd:
3442         * Scripts/webkitdirs.pm:
3443         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3444         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3445         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3446         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3447         * TestWebKitAPI/win/copy-resources.cmd:
3448         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3449         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3450         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3451         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3452         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3453         * WebKitTestRunner/win/InjectedBundle.vcproj:
3454         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3455         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3456         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3457         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3458         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3459         * WinLauncher/WinLauncherCommon.vsprops:
3460         * WinLauncher/WinLauncherPostBuild.cmd:
3461         * WinLauncher/WinLauncherPreBuild.cmd:
3462
3463 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3464
3465         Reviewed by Ariya Hidayat.
3466
3467         [Qt] TestNetscapePlugin doesn't link on OS X
3468         https://bugs.webkit.org/show_bug.cgi?id=51948
3469
3470         Only add a dependency on libX11 on X11 systems
3471
3472         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3473
3474 2011-01-05  Jeff Miller  <jeffm@apple.com>
3475
3476         Reviewed by Adam Roben.
3477
3478         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3479         https://bugs.webkit.org/show_bug.cgi?id=51970
3480
3481         * Scripts/webkitpy/style/checker.py:
3482         Add -readability/naming for WebKit2 C API directories.
3483
3484 2011-01-05  Eric Seidel  <eric@webkit.org>
3485
3486         Unreviewed, just fixing one more log error from my previous python patch.
3487
3488         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3489         https://bugs.webkit.org/show_bug.cgi?id=51802
3490
3491         webkit-patch failure-reason was logging about parsing errors
3492         due to my misunderstanding of how BeautifulSoup.findAll worked.
3493
3494         Fixed, and added a unit test.
3495
3496         * Scripts/webkitpy/common/net/layouttestresults.py:
3497         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3498
3499 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3500
3501         Reviewed by Kenneth Rohde Christiansen.
3502
3503         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3504         https://bugs.webkit.org/show_bug.cgi?id=51951
3505
3506         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3507         to create new window from WebKit.
3508
3509         * MiniBrowser/qt/BrowserWindow.cpp:
3510         (newPageFunction):
3511         (BrowserWindow::BrowserWindow):
3512         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3513         (BrowserWindow::newWindow):
3514         (BrowserWindow::updateUserAgentList):
3515         (BrowserWindow::showUserAgentDialog):
3516         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3517         define the type of the backing store used for new windows.
3518         * MiniBrowser/qt/main.cpp:
3519         (main):
3520
3521 2011-01-05  Eric Seidel  <eric@webkit.org>
3522
3523         Reviewed by Ojan Vafai.
3524
3525         commit-queue should report failure type when reporting flaky tests
3526         https://bugs.webkit.org/show_bug.cgi?id=51900
3527
3528         This patch was a ridiculous amount of plumbing.  In the end I like
3529         the NRWT-style TestResult class even less.  But now we're passing
3530         a list of TestResult objects from the queue to the FlakyTestReporter.
3531         Thus the FlakyTestReporter can more easily report what type of failure
3532         occurred.
3533
3534         In the process, I found that I was not alone in finding TestResult
3535         cumbersome to use.  A bunch of code was trying to create a TestResult
3536         object with default values.  However since the constructor didn't make
3537         this easy, some places were getting it wrong (including the TestResult unit test)!
3538         I've fixed the TestResult constructor to have default values for non-essential
3539         arguments.
3540
3541         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3542         * Scripts/webkitpy/common/net/layouttestresults.py:
3543         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3544         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3545         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3546         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3547         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3548         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3549         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3550         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3551         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3552         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3553         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3554         * Scripts/webkitpy/tool/commands/queues.py:
3555         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3556
3557 2011-01-05  Eric Seidel  <eric@webkit.org>
3558
3559         Unreviewed.
3560
3561         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3562         https://bugs.webkit.org/show_bug.cgi?id=51802
3563
3564         Add another unit test to cover a previously missing import.
3565
3566         * Scripts/webkitpy/common/net/layouttestresults.py:
3567         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3568
3569 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3570
3571         Reviewed by David Levin.
3572
3573         Add mihaip@chromium.org as a reviewer
3574         https://bugs.webkit.org/show_bug.cgi?id=51966
3575
3576         Add myself as a reviewer.
3577
3578         * Scripts/webkitpy/common/config/committers.py:
3579
3580 2011-01-05  James Simonsen  <simonjam@chromium.org>
3581
3582         Unreviewed. Adding myself to the list of committers.
3583
3584         * Scripts/webkitpy/common/config/committers.py:
3585
3586 2011-01-05  Eric Seidel  <eric@webkit.org>
3587
3588         Unreviewed.
3589
3590         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3591         https://bugs.webkit.org/show_bug.cgi?id=51802
3592
3593         Fix two exceptions seen on the bots after my original commit.
3594
3595         * Scripts/webkitpy/common/net/layouttestresults.py:
3596         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3597
3598 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3599
3600         Reviewed by Andreas Kling.
3601
3602         [Qt]Add local storage settings to QtTestBrowser command line arguments
3603         https://bugs.webkit.org/show_bug.cgi?id=51750
3604
3605         * QtTestBrowser/main.cpp:
3606         (LauncherApplication::handleUserOptions):
3607          Local storage settings can be enable form command line arguments for
3608          QtTestBrowser.
3609
3610 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3611
3612         Reviewed by Martin Robinson.
3613
3614         GTK: AX: DRT needs to use correct root object method.
3615         https://bugs.webkit.org/show_bug.cgi?id=51911
3616
3617         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3618         (AccessibilityController::rootElement):
3619
3620 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3621
3622         Rubber-stamped by Csaba Osztrogonác.
3623
3624         Based on idea from Péter Gál.
3625
3626         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3627
3628 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3629
3630         Reviewed by Adam Barth.
3631
3632         sheriff-bot should be able to do multi-revision rollouts
3633         https://bugs.webkit.org/show_bug.cgi?id=51176
3634
3635         * Scripts/webkitpy/tool/bot/irc_command.py:
3636         * Scripts/webkitpy/tool/bot/sheriff.py:
3637         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3638
3639 2011-01-05  Eric Seidel  <eric@webkit.org>
3640
3641         Reviewed by Adam Barth.
3642
3643         queues.webkit.org should have per-bot status pages
3644         https://bugs.webkit.org/show_bug.cgi?id=51906
3645
3646         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3647         statuses from a single queue.  Now that we have many bots servicing
3648         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3649         you care about scroll off the end of the 15-message limit on the main page.
3650
3651         Eventually we should probably rename /queue-status to /queue or /queues,
3652         but that's fodder for another patch.
3653
3654         * QueueStatusServer/handlers/queuestatus.py:
3655         * QueueStatusServer/index.yaml:
3656         * QueueStatusServer/main.py:
3657         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3658          - This probably should use a custom filter instead of hard-coding
3659            the URL scheme here, but I couldn't figure out how to easily
3660            create such a filter.  Most filters work with "strings" so we can't
3661            pass the status object.  We could add a method to the status
3662            object and call that, but that seemed a bit strange too.
3663         * QueueStatusServer/templates/queuestatus.html:
3664
3665 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3666
3667         Unreviewed. Adding myself to the list of committers.
3668
3669         * Scripts/webkitpy/common/config/committers.py:
3670
3671 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3672
3673         Reviewed by David Levin.
3674
3675         check-webkit-style treated some macros with parentheses after #elif as function calls
3676         https://bugs.webkit.org/show_bug.cgi?id=51695
3677
3678         Ingore function call space checking in any preprocessor directives
3679         (things starting with #). Change search() to match() because
3680         preprocessor directives are supposed to be in the beginning of lines.
3681
3682         * Scripts/webkitpy/style/checkers/cpp.py:
3683         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3684
3685 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3686
3687         Reviewed by Tony Chang.
3688
3689         Change the --multi-load test option to --stress-opt
3690         https://bugs.webkit.org/show_bug.cgi?id=50751
3691
3692         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3693         (runTest):
3694         (main):
3695         * DumpRenderTree/chromium/TestShell.cpp:
3696         (TestShell::TestShell):
3697         * DumpRenderTree/chromium/TestShell.h:
3698         (TestShell::stressOpt):
3699         (TestShell::setStressOpt):
3700         (TestShell::stressDeopt):
3701         (TestShell::setStressDeopt):
3702         (TestShell::javaScriptFlags):
3703         (TestShell::setJavaScriptFlags):
3704         * Scripts/webkitpy/layout_tests/port/chromium.py:
3705         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3706
3707 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3708
3709         Reviewed by Sam Weinig.
3710
3711         WK2: Support Accessibility
3712         https://bugs.webkit.org/show_bug.cgi?id=51859
3713
3714         Use rootObject() method to get top of accessibility tree.
3715
3716         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3717         (AccessibilityController::focusedElement):
3718         (AccessibilityController::rootElement):
3719
3720 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3721
3722         Reviewed by Darin Adler.
3723
3724         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3725         https://bugs.webkit.org/show_bug.cgi?id=51846
3726
3727         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3728         back to GRefPtr.
3729
3730 2011-01-04  Zhe Su  <suzhe@chromium.org>
3731
3732         Reviewed by Kenneth Russell.
3733
3734         Fix insertText, setMarkedText and unmarkText methods of
3735         TextInputController to call corresponding methods of WebKit::WebView
3736         rather than WebKit::WebFrame. This change matches the behavior of
3737         chromium browser.
3738         insertText corresponds to WebView::confirmComposition(text)
3739         setMarkedText corresponds to WebView::setComposition(...)
3740         unmarkText corresponds to WebView::confirmComposition()
3741         https://bugs.webkit.org/show_bug.cgi?id=51693
3742
3743         * DumpRenderTree/chromium/TextInputController.cpp:
3744         (TextInputController::insertText):
3745         (TextInputController::setMarkedText):
3746         (TextInputController::unmarkText):
3747
3748 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3749
3750         Reviewed by Laszlo Gombos.
3751
3752         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3753
3754         On Symbian productDir points to the source directory. Removing all the
3755         empty files from the productDir directory corrupts the svn repository.
3756
3757         * Scripts/build-webkit:
3758
3759 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3760
3761         Reviewed by Adam Barth.
3762
3763         [Qt] Add SelectAll option to the context menu for the editor
3764         https://bugs.webkit.org/show_bug.cgi?id=50049
3765
3766         Set shortcut for the SelectAll action.
3767
3768         * QtTestBrowser/mainwindow.cpp:
3769         (MainWindow::buildUI):
3770
3771 2011-01-03  David Levin  <levin@chromium.org>
3772
3773         Reviewed by Eric Seidel.
3774
3775         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3776         https://bugs.webkit.org/show_bug.cgi?id=51842
3777
3778         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3779         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3780
3781 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3782
3783         Reviewed by David Kilzer.
3784
3785         [WINCE] Adds a build slave.