2011-01-19 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Anders Carlsson.
4
5         If resetting between tests times out, treat it as a WebProcess crash
6         https://bugs.webkit.org/show_bug.cgi?id=52757
7
8         * WebKitTestRunner/TestController.cpp:
9         (WTR::TestController::runTest):
10
11 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
12
13         Reviewed by Darin Adler.
14
15         https://bugs.webkit.org/show_bug.cgi?id=52739
16         Make it possible for a WebKit2 client to print headers and footers
17
18         Added dummy implementations for new printing UIClient calls.
19
20         * MiniBrowser/mac/BrowserWindowController.m:
21         (-[BrowserWindowController awakeFromNib]):
22         * WebKitTestRunner/TestController.cpp:
23         (WTR::createOtherPage):
24         (WTR::TestController::initialize):
25
26 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
27
28         Reviewed by Ojan Vafai.
29
30         Change webkitpy/layout_tests/port/test.py to use the
31         in-memory filesystem for cleaner unit testing. This
32         change allows us to kill a lot of code that was
33         specific to the test port, at the cost of being a
34         little less clear about how things would work if
35         you didn't have a filesystem.
36
37         https://bugs.webkit.org/show_bug.cgi?id=52605
38
39         * Scripts/webkitpy/layout_tests/port/test.py:
40
41 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
42
43         Unreviewed, build fix.
44
45         Fix test failure caused by committing attachment 79368 instead
46         of attachment 79461 on bug 52604.
47
48         * Scripts/webkitpy/common/system/filesystem_mock.py:
49
50 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
51
52         Reviewed by Mihai Parparita.
53
54         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
55         unit testing. os.walk() is too much of a hassle to implement on
56         top of the in-memory mock filesystem and adding the necessary
57         interface to files_under() gives clients a cleaner API anyway
58         (for this particular usage model).
59
60         https://bugs.webkit.org/show_bug.cgi?id=52691
61
62         * Scripts/webkitpy/common/system/filesystem.py:
63         * Scripts/webkitpy/common/system/filesystem_mock.py:
64         * Scripts/webkitpy/layout_tests/port/test_files.py:
65         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
66
67 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
68
69         Reviewed by Tony Chang.
70
71         Change more modules in the layout-tests code to use the
72         filesystem wrapper for cleaner unit testing.
73
74         This patch also adds the glob() wrapper to the filesystem
75         abstraction.
76         
77         https://bugs.webkit.org/show_bug.cgi?id=52604
78
79         * Scripts/webkitpy/layout_tests/port/test_files.py:
80         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
81         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
82         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
83         * Scripts/webkitpy/common/system/filesystem.py:
84         * Scripts/webkitpy/common/system/filesystem_mock.py:
85
86 2011-01-19  Levi Weintraub  <leviw@chromium.org>
87
88         Unreviewed.
89
90         Updating my email addresses and irc nick.
91
92         * Scripts/webkitpy/common/config/committers.py:
93
94 2011-01-19  Tony Chang  <tony@chromium.org>
95
96         Reviewed by Mihai Parparita.
97
98         [chromium] [linux] if check-sys-deps fails, output the failure reason
99         https://bugs.webkit.org/show_bug.cgi?id=52671
100
101         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
102             error handler functions.
103         * Scripts/webkitpy/layout_tests/port/chromium.py:
104             output the error text from --check-sys-deps
105         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
106
107 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
108
109         Reviewed by Andreas Kling.
110
111         [Qt] QtTestBrowser crashes when closing if Facebook is opened
112         https://bugs.webkit.org/show_bug.cgi?id=52554
113         
114         QtNetworkAccessManager is created in a thread and set as
115         member variable in QWebPage. When the thread is destroyed
116         the object is still used. So fix will set the object to
117         NULL once the thread is destroyed.
118
119         * QtTestBrowser/launcherwindow.cpp:
120         (LauncherWindow::~LauncherWindow):
121
122 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
123
124         Rubber stamped by Csaba Osztrogonac
125
126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
127
128 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
129
130         Reviewed by Tony Chang.
131
132         new-run-webkit-tests: add a --build-directory command line argument
133
134         Official Google Chrome builds use a non-standard build directory
135         location. This patch adds a --build-directory argument that
136         allows that location to be specified on the command line. Only
137         Chromium-based builds will use this flag for now, but anyone can
138         in the future.
139
140         There are no unit tests for this since it's difficult to test
141         until mock filesystems are fully supported in the code. This was
142         tested by hand for now.
143
144         https://bugs.webkit.org/show_bug.cgi?id=52694
145
146         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
147         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
148         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
150
151 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
152
153         Not reviewed. Bot fix.
154
155         Remove an inadvertently committed debugging print.
156
157         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
158         (LayoutTestController::notifyDone):
159
160 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
161
162         Reviewed by Sam Weinig.
163
164         WebKitTestRunner should track loading more like DumpRenderTree
165         https://bugs.webkit.org/show_bug.cgi?id=52692
166
167         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
168         This makes some tests that call notifyDone multiple times pass.
169         
170         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
171         (WTR::InjectedBundle::InjectedBundle):
172         (WTR::InjectedBundle::done):
173         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
174         (WTR::InjectedBundle::topLoadingFrame):
175         (WTR::InjectedBundle::setTopLoadingFrame):
176         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
177         (WTR::InjectedBundlePage::InjectedBundlePage):
178         (WTR::InjectedBundlePage::stopLoading):
179         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
180         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
181         (WTR::InjectedBundlePage::didFinishLoadForFrame):
182         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
183         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
184         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
185         (WTR::LayoutTestController::notifyDone):
186         * WebKitTestRunner/TestController.cpp:
187         (WTR::TestController::didReceiveMessageFromInjectedBundle):
188
189 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
190
191         Reviewed by Kent Tamura.
192
193         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
194         https://bugs.webkit.org/show_bug.cgi?id=52678
195         
196         Update path now that WebKit is inside Source.
197
198         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
199
200 2011-01-18  Robert Hogan  <robert@webkit.org>
201
202         Reviewed by Simon Hausmann.
203
204         [Qt] http/tests/incremental/slow-utf8-text.pl fails
205         https://bugs.webkit.org/show_bug.cgi?id=44282
206
207         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
208         (WebCore::DumpRenderTree::dump):
209
210 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
211
212         Reviewed by Mihai Parparita.
213
214         Fix a small race condition that could cause the unit tests for
215         new-run-webkit-tests to fail in a multithreaded environment.
216         There was a small window in the code where one thread would
217         check to see if a thread had raised an exception, do something,
218         and then check to see if the thread was alive. If the other
219         thread raised an exception and exited in between these two
220         steps, the exception would be lost. Flipping the order of the
221         two checks fixes the race, since we will now always check for an
222         exception on the thread before exiting.
223
224         https://bugs.webkit.org/show_bug.cgi?id=51579
225
226         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
227
228 2011-01-18  Eric Seidel  <eric@webkit.org>
229
230         Reviewed by Adam Barth.
231
232         commit-queue dies when test archiving fails
233         https://bugs.webkit.org/show_bug.cgi?id=52617
234
235         I looked at the machine and it had 10 archives already
236         thus find_unused_name was returning None.  I've upped
237         the limit to 100 (per bug) and tested the case where
238         find_unused_name returns None (making archive return None).
239
240         * Scripts/webkitpy/common/system/workspace.py:
241         * Scripts/webkitpy/common/system/workspace_unittest.py:
242         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
243         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
244         * Scripts/webkitpy/tool/commands/queues.py:
245
246 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
247
248         Reviewed by Ojan Vafai.
249
250         Update rebaseline-chromium-webkit-tests unit tests to use a mock
251         filesystem. Also fix a couple of "with" statements missed by
252         r76050.
253
254         https://bugs.webkit.org/show_bug.cgi?id=52487
255
256         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
257
258 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
259
260         Reviewed by Martin Robinson.
261
262         [Gtk] Build fixes for gtk3 build
263         https://bugs.webkit.org/show_bug.cgi?id=52648
264
265         * DumpRenderTree/gtk/EventSender.cpp:
266         (beginDragWithFilesCallback):
267
268 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
269
270         Reviewed by Mihai Parparita.
271
272         Update rebaseline-chromium-webkit-tests to use filesystem objects
273         instead of direct references to os.path, shutil, tempfile, etc.
274
275         This patch doesn't change anything, but will allow subsequent
276         patches to change the unit tests to no longer use the real
277         filesystem.
278
279         This patch adds a bunch more methods to the filesystem object as
280         well.
281
282         https://bugs.webkit.org/show_bug.cgi?id=52482
283
284         * Scripts/webkitpy/common/system/filesystem.py:
285         * Scripts/webkitpy/common/system/filesystem_mock.py:
286         * Scripts/webkitpy/tool/commands/queues.py:
287         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
288         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
289
290 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
291
292         Reviewed by Mihai Parparita.
293
294         new-run-webkit-tests shouldn't crash when you try to run a
295         directory containing only skipped files.
296
297         https://bugs.webkit.org/show_bug.cgi?id=52478
298         
299         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
300         * Scripts/webkitpy/layout_tests/port/test.py:
301         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
302
303 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
304
305         Reviewed by Gustavo Noronha Silva.
306
307         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
308         https://bugs.webkit.org/show_bug.cgi?id=40833
309
310         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
311         GTK+ event sender.
312         (dragWithFilesDragDataGetCallback): Added.
313         (dragWithFilesDragEndCallback): Added.
314         (beginDragWithFilesCallback): Added.
315
316 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
317
318         Reviewed by Adam Barth.
319
320         ews: Add additional watcher to efl ews
321         https://bugs.webkit.org/show_bug.cgi?id=52613
322
323         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
324
325         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
326
327 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
328
329         Reviewed by Alexey Proskuryakov.
330
331         Fix some headers with missing or misspelled #ifndef guards
332         https://bugs.webkit.org/show_bug.cgi?id=52545
333
334         * DumpRenderTree/chromium/TestEventPrinter.h:
335         * DumpRenderTree/chromium/WebPreferences.h:
336
337 2011-01-17  Jessie Berlin  <jberlin@apple.com>
338
339         Reviewed by Anders Carlsson.
340
341         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
342         navigating back to an unreachable URL
343         https://bugs.webkit.org/show_bug.cgi?id=52388
344
345         Add a third parameter (unreachableURL) to queueLoadHTMLString.
346
347         * DumpRenderTree/LayoutTestController.cpp:
348         (queueLoadHTMLStringCallback):
349         (LayoutTestController::queueLoadHTMLString):
350         (LayoutTestController::queueLoadAlternateHTMLString):
351         * DumpRenderTree/LayoutTestController.h:
352
353         * DumpRenderTree/WorkQueueItem.h:
354         (LoadHTMLStringItem::LoadHTMLStringItem):
355
356         * DumpRenderTree/chromium/LayoutTestController.cpp:
357         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
358         (WorkItemLoadHTMLString::run):
359         (LayoutTestController::queueLoadHTMLString):
360
361         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
362         (LoadHTMLStringItem::invoke):
363         * DumpRenderTree/mac/WorkQueueItemMac.mm:
364         (LoadHTMLStringItem::invoke):
365         * DumpRenderTree/win/WorkQueueItemWin.cpp:
366         (LoadHTMLStringItem::invoke):
367
368 2011-01-17  Dan Bernstein  <mitz@apple.com>
369
370         Rubber-stamped by Mark Rowe.
371
372         Update xcodeproj svn:ignore to include xcuserdata.
373
374         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
375         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
376         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
377         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
378         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
379
380 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
381
382         Unreviewed fix after r75908.
383
384         Move WebKit into Source
385         https://bugs.webkit.org/show_bug.cgi?id=52530
386
387         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
388
389 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
390
391         Unreviewed.
392
393         Remove accidentally committed debug printing after r75908.
394
395         * Scripts/webkitdirs.pm:
396
397 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
398
399         Unreviewed.
400
401         Add myself to committers list
402         https://bugs.webkit.org/show_bug.cgi?id=52566
403
404         * Scripts/webkitpy/common/config/committers.py:
405
406 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
407
408         Reviewed by Jeremy Orlow.
409
410         GeolocationController should call stopUpdating on destruction
411         https://bugs.webkit.org/show_bug.cgi?id=52216
412
413         fast/dom/Geolocation/window-close-crash.html requires that a
414         Geolocation watch be started in a secondary window. Consequently,
415         we need to allow geolocation permission and provide a mock
416         geolocation position for the secondary window's
417         GeolocationClientMock.
418
419         * DumpRenderTree/chromium/LayoutTestController.cpp:
420         (LayoutTestController::setGeolocationPermission):
421         (LayoutTestController::setMockGeolocationPosition):
422         (LayoutTestController::setMockGeolocationError):
423         * DumpRenderTree/chromium/TestShell.h:
424         (TestShell::windowList):
425
426 2011-01-16  Adam Barth  <abarth@webkit.org>
427
428         Update more include paths to reflect WebKit move.
429
430         * DumpRenderTree/chromium/EventSender.cpp:
431         (EventSender::keyDown):
432         (EventSender::needsShiftModifier):
433         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
434         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
435
436 2011-01-16  Kent Tamura  <tkent@chromium.org>
437
438         Unreviewed, Chromium build fix.
439
440         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
441
442 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
443
444         Build fix for GTK+ after source directory movement.
445
446         * GNUmakefile.am: Correct include paths.
447
448 2011-01-16  Adam Barth  <abarth@webkit.org>
449
450         Teach svn-apply about WebKit move.
451
452         * Scripts/VCSUtils.pm:
453
454 2011-01-16  Adam Barth  <abarth@webkit.org>
455
456         Rubber-stamped by Eric Seidel.
457
458         Move WebKit into Source
459         https://bugs.webkit.org/show_bug.cgi?id=52530
460
461         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
462         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
463         * DumpRenderTree/qt/DumpRenderTreeQt.h:
464         * DumpRenderTree/qt/GCControllerQt.cpp:
465         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
466         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
467         * DumpRenderTree/qt/TextInputControllerQt.cpp:
468         * DumpRenderTree/wscript:
469         * QtTestBrowser/launcherwindow.h:
470         * Scripts/build-webkit:
471         * Scripts/webkitdirs.pm:
472
473 2011-01-15  Adam Barth  <abarth@webkit.org>
474
475         Teach svn-apply about WebKit2 move.
476
477         * Scripts/VCSUtils.pm:
478
479 2011-01-15  Adam Barth  <abarth@webkit.org>
480
481         Rubber-stamped by Eric Seidel.
482
483         Move WebKit2 into Source
484         https://bugs.webkit.org/show_bug.cgi?id=52438
485
486         * MiniBrowser/qt/MiniBrowser.pro:
487         * Scripts/build-webkit:
488         * Scripts/do-file-rename:
489         * Scripts/do-webcore-rename:
490         * Scripts/test-webkitpy:
491         * Scripts/webkitdirs.pm:
492         * Scripts/webkitpy/style/checker.py:
493         * WebKitTestRunner/DerivedSources.pro:
494         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
495         * WebKitTestRunner/qt/WebKitTestRunner.pro:
496
497 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
498
499         Reviewed by David Levin.
500
501         [chromium] remove obsolete createView method
502         https://bugs.webkit.org/show_bug.cgi?id=52437
503
504         * DumpRenderTree/chromium/WebViewHost.cpp:
505         (WebViewHost::createView):
506         * DumpRenderTree/chromium/WebViewHost.h:
507
508 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
509
510         Reviewed by Geoff Garen.
511
512         ShouldLoadResourceForFrame should use strings, not URLs.
513         https://bugs.webkit.org/show_bug.cgi?id=52476
514
515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
516         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
517         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
518
519 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
520
521         Reviewed by David Levin.
522
523         Add Tony Gentilcore as a reviewer
524         https://bugs.webkit.org/show_bug.cgi?id=52480
525
526         * Scripts/webkitpy/common/config/committers.py:
527
528 2011-01-14  David Levin  <levin@chromium.org>
529
530         Reviewed by Eric Seidel.
531
532         check-webkit-style: _FunctionState should keep track of where the function name starts.
533         https://bugs.webkit.org/show_bug.cgi?id=52454
534
535         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
536         _FunctionState and logic for setting it correctly.
537         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
538
539 2011-01-14  Vincent Scheib  <scheib@chromium.org>
540
541         Reviewed by David Levin.
542
543         Add support to DumpRenderTree to use the GPU rather than software renderer
544         https://bugs.webkit.org/show_bug.cgi?id=52333
545
546         * DumpRenderTree/chromium/DumpRenderTree.cpp:
547         (main):
548         * Scripts/webkitpy/layout_tests/port/chromium.py:
549         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
550
551 2011-01-14  Tony Chang  <tony@chromium.org>
552
553         Reviewed by Kent Tamura.
554
555         [chromium] update fonts.conf to fix 6 linux tests in drt
556         https://bugs.webkit.org/show_bug.cgi?id=52411
557
558         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
559             chromium's src/webkit/tools/test_shell/resources/fonts.conf
560
561 2011-01-14  Eric Seidel  <eric@webkit.org>
562
563         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
564
565         Reviewed by Adam Barth.
566
567         Fix when running Tools/Scripts/check-webkit-style without arguments.
568         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
569
570         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
571         * Scripts/webkitpy/common/checkout/scm_unittest.py:
572
573 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
574
575         Reviewed by David Levin.
576
577         Store the tempdir object in a variable so it doesn't get deleted too early.
578         https://bugs.webkit.org/show_bug.cgi?id=51875
579
580         * Scripts/update-webkit-auxiliary-libs:
581         * Scripts/update-webkit-support-libs:
582
583 2011-01-14  Eric Seidel  <eric@webkit.org>
584
585         Unreviewed.  Make it work in python 2.5.
586
587         webkit-patch suggest-reviewers dies when ChangeLogs are missing
588         https://bugs.webkit.org/show_bug.cgi?id=49158
589
590         * Scripts/webkitpy/common/checkout/api_unittest.py:
591
592 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
593
594         Unreviewed, rolling out r75774.
595         http://trac.webkit.org/changeset/75774
596         https://bugs.webkit.org/show_bug.cgi?id=52431
597
598         gtk builds were broken (Requested by loislo2 on #webkit).
599
600         * Scripts/webkitpy/common/checkout/scm.py:
601
602 2011-01-14  David Levin  <levin@chromium.org>
603
604         Reviewed by Shinichiro Hamaji.
605
606         check-webkit-style: _FunctionState should detect pure functions.
607         https://bugs.webkit.org/show_bug.cgi?id=52428
608
609         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
610         is a pure virtual function.
611         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
612         virtual functions are correctly detected.
613
614 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
615
616         Reviewed by Yury Semikhatsky.
617
618         Just small fix for problem with check-webkit-style.
619         It just didn't work for this patch.
620         Old code can't concatenate a list of strings with None.
621
622         * Scripts/webkitpy/common/checkout/scm.py:
623
624 2011-01-13  David Levin  <levin@chromium.org>
625
626         Reviewed by Shinichiro Hamaji.
627
628         check-webkit-style: _FunctionState should use Position to know where items are.
629         https://bugs.webkit.org/show_bug.cgi?id=52424
630
631         * Scripts/webkitpy/style/checkers/cpp.py:
632         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
633         (detect_functions): Changed to pass Position's to _FunctionState.begin and
634         did some minor clean-up.
635         (*): Other changes are simply about converting to use the Position's in_FunctionState
636         instead of line numbers.
637         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
638         to verify the positions stored in _FunctionState.
639
640 2011-01-13  Eric Seidel  <eric@webkit.org>
641
642         Reviewed by David Levin.
643
644         webkit-patch suggest-reviewers dies when ChangeLogs are missing
645         https://bugs.webkit.org/show_bug.cgi?id=49158
646
647         This is not the most elegant, but it is a very safe fix to this bug.
648         One advantage of catching ScriptError like this instead of adding a
649         new added_or_modified_files or fixing all changed_files callers
650         to use a more specific change_files variant, is that we catch
651         all kinds of ScriptErrors which might cause our (non-essential)
652         suggest-reviewers code to fail out.  This should make passing
653         --suggest-reviewers to webkit-patch upload much more robust
654         and may even make it possible for us to make it default.
655
656         The root of the problem here is that SCM.changed_files includes
657         deleted ChangeLog paths (from moves, etc) which then when we ask
658         SVN/Git for the contents of the file at that revision, the command
659         errors out and Executive.run_command raises a ScriptError.
660
661         In the future we might fix this differently by making all current
662         callers of chagned_files use a more specific method for requesting
663         what types of changes they're interested in (adds, modifies, deletes, etc.)
664
665         * Scripts/webkitpy/common/checkout/api.py:
666         * Scripts/webkitpy/common/checkout/api_unittest.py:
667
668 2011-01-13  Dan Bernstein  <mitz@apple.com>
669
670         Reviewed by Alexey Proskuryakov.
671
672         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
673         https://bugs.webkit.org/show_bug.cgi?id=52419
674
675         Allow to further control the behavior of the willSendRequest delegate callback by making it
676         set a different URL in the new request.
677
678         * DumpRenderTree/LayoutTestController.cpp:
679         (addURLToRedirectCallback): Added.
680         (LayoutTestController::staticFunctions): Added addURLToRedirect.
681         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
682         (LayoutTestController::redirectionDestinationForURL): Added this getter.
683         * DumpRenderTree/LayoutTestController.h:
684         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
685         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
686         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
687         change the URL in the new request to the redirect destination.
688
689 2011-01-13  Eric Seidel  <eric@webkit.org>
690
691         Reviewed by Mihai Parparita.
692
693         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
694         https://bugs.webkit.org/show_bug.cgi?id=52416
695
696         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
697         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
698
699         I also added FIXMEs about the changed_files returning deleted files problem
700         which is causing the other most common exception for suggest-reviewers
701         (and is probably breaking sheriff-bots blame detection).
702
703         * Scripts/webkitpy/common/checkout/api.py:
704         * Scripts/webkitpy/common/checkout/api_unittest.py:
705         * Scripts/webkitpy/common/checkout/scm.py:
706
707 2011-01-13  Eric Seidel  <eric@webkit.org>
708
709         Reviewed by Adam Barth.
710
711         results archives from commit-queue are too large to upload
712         https://bugs.webkit.org/show_bug.cgi?id=52405
713
714         * Scripts/webkitpy/common/system/filesystem.py:
715         * Scripts/webkitpy/common/system/filesystem_mock.py:
716         * Scripts/webkitpy/tool/commands/queues.py:
717
718 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
719
720         Reviewed by Martin Robinson.
721
722         [gtk] Zero-sized font does not yet work
723         https://bugs.webkit.org/show_bug.cgi?id=49793
724
725         Set minimum-font-size to 0 for the DRT.
726
727         * DumpRenderTree/gtk/DumpRenderTree.cpp:
728         (resetDefaultsToConsistentValues):
729
730 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
731
732         Reviewed by Darin Adler.
733
734         Make old-run-webkit-tests more robust on buildbots
735         https://bugs.webkit.org/show_bug.cgi?id=52364
736
737         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
738
739 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
740
741         Reviewed by Darin Adler.
742
743         Make old-run-webkit-tests more robust on buildbots
744         https://bugs.webkit.org/show_bug.cgi?id=52364
745
746         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
747
748 2011-01-13  Tony Chang  <tony@chromium.org>
749
750         Reviewed by Kent Tamura.
751
752         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
753         https://bugs.webkit.org/show_bug.cgi?id=52332
754
755         Forked Info.plist is not longer needed.
756
757         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
758
759 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
760
761         Reviewed by Timothy Hatcher.
762
763         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
764         to be passed directly to WebInspector.UIString
765
766         https://bugs.webkit.org/show_bug.cgi?id=52365
767
768         * Scripts/check-inspector-strings:
769
770 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
771
772         Unreviewed, rolling out r74881.
773         http://trac.webkit.org/changeset/74881
774         https://bugs.webkit.org/show_bug.cgi?id=52357
775
776         The EFL builder has been red for days (Requested by abarth on
777         #webkit).
778
779         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
780         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
781
782 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
783
784         Reviewed by David Levin.
785
786         Add beforeunload support to WebKitTestRunner
787         https://bugs.webkit.org/show_bug.cgi?id=52353
788         
789         This makes a number of currently failing tests pass.
790
791         * WebKitTestRunner/TestController.cpp:
792         (WTR::runBeforeUnloadConfirmPanel):
793         (WTR::createOtherPage):
794         (WTR::TestController::initialize):
795
796 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
797
798         Reviewed by Sam Weinig.
799
800         Detect, identify and recover from WebProcess crashes in run-webkit-tests
801         https://bugs.webkit.org/show_bug.cgi?id=52330
802
803         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
804         a web process crash.
805         * WebKitTestRunner/TestController.cpp:
806         (WTR::TestController::initialize): Set up a processDidCrash
807         callback.
808         (WTR::TestController::processDidCrash): Report that the Web process
809         crashed.
810         * WebKitTestRunner/TestController.h:
811
812 2011-01-12  David Levin  <levin@chromium.org>
813
814         Reviewed by Shinichiro Hamaji.
815
816         check-webkit-style -- close_expression function doesn't work correctly.
817         https://bugs.webkit.org/show_bug.cgi?id=52272
818
819         * Scripts/webkitpy/style/checkers/cpp.py:
820         (Position.__str__): Added a way to convert it to a string which is useful in tests.
821         (Position.__cmp__): Added a way to compare Position which is useful in tests and
822         generally useful (for upcoming code changes).
823         (close_expression): Changed to use Position for input and output.
824         Also, fixed many bugs such as only working correctly for parenthesis,
825         not working correctly if given an offset in a line and not finding
826         the real closing element if there were multiple closing elements in
827         the same line.
828         (detect_functions): Adjusted due to the change in arguments for
829         close_expression.
830         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
831         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
832         two positions are the same.
833         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
834         (CppStyleTest.test_close_expression): Added tests to catch the issues
835         that were fixed.
836
837 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
838
839         Unreviewed, rolling out r75576.
840         http://trac.webkit.org/changeset/75576
841         https://bugs.webkit.org/show_bug.cgi?id=52304
842
843         broke rebaseline-chromium-webkit-test (Requested by thakis on
844         #webkit).
845
846         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
847         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
848         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
849         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
850         * Scripts/webkitpy/layout_tests/port/base.py:
851         * Scripts/webkitpy/layout_tests/port/chromium.py:
852         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
853         * Scripts/webkitpy/layout_tests/port/test.py:
854         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
855         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
856         * Scripts/webkitpy/style/checkers/test_expectations.py:
857         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
858
859 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
860
861         Reviewed by Darin Adler.
862
863         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
864         https://bugs.webkit.org/show_bug.cgi?id=52307
865
866         * Scripts/old-run-webkit-tests:
867
868 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
869
870         Reviewed by Martin Robinson.
871
872         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
873         https://bugs.webkit.org/show_bug.cgi?id=50867
874
875         Fixed library extention for Mac in webkitdirs.pm and type conflict in
876         TestNetscapePlugin.cpp 
877
878         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
879         * Scripts/webkitdirs.pm:
880
881 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
882
883         Reviewed by Pavel Feldman.
884
885         Add check-inspector-strings script.
886
887         https://bugs.webkit.org/show_bug.cgi?id=52295
888
889         * Scripts/check-inspector-strings: Added.
890
891 2011-01-12  Adam Roben  <aroben@apple.com>
892
893         Advertise the .testnetscape file extension on Windows
894
895         Fixes <http://webkit.org/b/52298>
896         plugins/no-mime-with-valid-extension.html fails on Windows
897
898         Reviewed by Dan Bernstein.
899
900         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
901         FileExtents field to map the .testnetscape file extension to the
902         application/x-webkit-test-netscape MIME type, just as we do on Mac.
903
904 2011-01-12  Adam Barth  <abarth@webkit.org>
905
906         Reviewed by Eric Seidel.
907
908         Make webkit-patch support subdirectories for SVN checkouts
909         https://bugs.webkit.org/show_bug.cgi?id=52261
910
911         os.relpath does not exist on Python 2.5, so we need to call our version
912         of the API.
913
914         * Scripts/webkitpy/common/checkout/scm.py:
915
916 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
917
918         Reviewed by Eric Seidel.
919
920         Close additional pages opened during a test once the test completes.
921         https://bugs.webkit.org/show_bug.cgi?id=52276
922
923         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
924         (WTR::InjectedBundle::done):
925
926 2011-01-11  David Levin  <levin@chromium.org>
927
928         Reviewed by Eric Seidel.
929
930         Errors should be separated from the command line in bot messages.
931         https://bugs.webkit.org/show_bug.cgi?id=52275
932
933         * Scripts/webkitpy/common/system/executive.py:
934         (ScriptError.message_with_output): Added a newline to separate the command
935         line from the errors.
936         * Scripts/webkitpy/common/system/executive_unittest.py:
937         (ScriptErrorTest.test_message_with_output): Added tests for the various code
938         paths in message_with_output.
939
940 2011-01-11  Eric Seidel  <eric@webkit.org>
941
942         Unreviewed.
943
944         commit-queue should know how to upload archived results (for test flakes or general failures)
945         https://bugs.webkit.org/show_bug.cgi?id=52048
946
947         The zips are mostly empty due to forgetting -r.
948         Expected diffs were not being pulled from the archive due
949         to the archive having longer paths than I realized.
950
951         * Scripts/webkitpy/common/system/workspace.py:
952         * Scripts/webkitpy/common/system/workspace_unittest.py:
953         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
954         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
955
956 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
957
958         Reviewed by Ojan Vafai.
959
960         The current modifier parsing code in test_expectations is
961         fragile and hard-coded, so it's not easy to understand the logic
962         or easily add new types of modifiers (like GPU vs. CPU testing
963         for graphics tests, or 32-bit vs. 64-bit differences).
964
965         This is the first of two patches that will add in more generic
966         support and then eliminate the GPU-specific test expectations
967         files for Chromium.
968
969         This patch adds two standalone objects for handling modifiers. The
970         rules for interpreting modifiers, precedence, and conflicts are
971         given in the docstring to the ModifierMatcher class, which
972         returns ModifierMatchResult objects.
973         
974         This patch also adds routines to the Port interface and a
975         default set of values in the base object, in order to obtain the
976         values needed on a given test run. These values are then passed
977         to the expectation parser. This also allows us to clean up the
978         logic used to lint all of the different configurations in a
979         single test_expectations.txt file.
980
981         The next patch will merge in the separate GPU expectations file.
982
983         https://bugs.webkit.org/show_bug.cgi?id=51222
984
985         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
986         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
987         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
988         * Scripts/webkitpy/layout_tests/port/base.py:
989         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
990         * Scripts/webkitpy/layout_tests/port/chromium.py:
991         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
992         * Scripts/webkitpy/layout_tests/port/test.py:
993         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
994         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
995
996 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
997
998         Reviewed by Adam Barth.
999
1000         Make webkit-patch support subdirectories for SVN checkouts
1001         https://bugs.webkit.org/show_bug.cgi?id=52261
1002
1003         * Scripts/webkitpy/common/checkout/scm.py:
1004         * Scripts/webkitpy/style_references.py:
1005         * Scripts/webkitpy/tool/main.py:
1006         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1007
1008 2011-01-11  Eric Seidel  <eric@webkit.org>
1009
1010         Unreviewed.
1011
1012         commit-queue should know how to upload archived results (for test flakes or general failures)
1013         https://bugs.webkit.org/show_bug.cgi?id=52048
1014
1015         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1016         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1017
1018         * Scripts/webkitpy/common/system/workspace.py:
1019         * Scripts/webkitpy/common/system/workspace_unittest.py:
1020         * Scripts/webkitpy/tool/commands/queues.py:
1021
1022 2011-01-11  Sam Weinig  <sam@webkit.org>
1023
1024         Roll r75474 back in.
1025
1026 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1027
1028         Reviewed by Kenneth Rohde Christiansen.
1029
1030         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1031         https://bugs.webkit.org/show_bug.cgi?id=51204
1032
1033         * QtTestBrowser/webpage.h:
1034         (QtNAMThread::QtNAMThread):
1035         (QtNAMThread::networkAccessManager):
1036         (QtNAMThread::run):
1037
1038 2011-01-11  Peter Varga  <pvarga@webkit.org>
1039
1040         Unreviewed.
1041
1042         Add myself to committers' list.
1043
1044         * Scripts/webkitpy/common/config/committers.py:
1045
1046 2011-01-11  Eric Seidel  <eric@webkit.org>
1047
1048         Reviewed by Adam Barth.
1049
1050         commit-queue should know how to upload archived results (for test flakes or general failures)
1051         https://bugs.webkit.org/show_bug.cgi?id=52048
1052
1053         Now the queue will always upload results.  Either the entire zip, or just
1054         the diffs.txt in the case of text failures.
1055
1056         This should make understanding flakes much easier, and paves the way
1057         for having the EWS run layout tests (and upload failures).
1058
1059         In order to upload .zip files I had to teach bugzilla.py to autodetect
1060         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1061         for .patch files, I have it add one before calling guess_type.
1062
1063         We may find that always uploading the whole zip instead of just the -diffs.txt
1064         file is preferable, but for now I'm keeping the old behavior because it makes
1065         quickly understanding text failures easy.
1066
1067         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1068         * Scripts/webkitpy/common/system/workspace.py: Added.
1069         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1070         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1071         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1072         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1073         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1074         * Scripts/webkitpy/tool/commands/queues.py:
1075         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1076
1077 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1078
1079         Unreviewed, rolling out r75464.
1080         http://trac.webkit.org/changeset/75464
1081         https://bugs.webkit.org/show_bug.cgi?id=52193
1082
1083         Followup rollout for 75474 (Requested by Ossy on #webkit).
1084
1085         * MiniBrowser/mac/BrowserWindowController.m:
1086         (-[BrowserWindowController awakeFromNib]):
1087         * MiniBrowser/win/BrowserView.cpp:
1088         (BrowserView::create):
1089         * WebKitTestRunner/TestController.cpp:
1090         (WTR::createOtherPage):
1091         (WTR::TestController::initialize):
1092
1093 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1094
1095         Reviewed by Csaba Osztrogonác.
1096
1097         [Qt] Baseline qt_minimal configuration
1098         https://bugs.webkit.org/show_bug.cgi?id=51313
1099
1100         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1101         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1102         QT_NO_UNDOSTACK guard.
1103
1104         * QtTestBrowser/launcherwindow.cpp:
1105         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1106         guards.
1107         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1108         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1109         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1110         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1111
1112         * QtTestBrowser/launcherwindow.h:
1113         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1114         * QtTestBrowser/locationedit.h: Ditto.
1115
1116         * QtTestBrowser/mainwindow.cpp:
1117         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1118         QT_NO_UNDOSTACK guards.
1119         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1120         (MainWindow::changeLocation): Ditto.
1121         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1122         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1123
1124         * QtTestBrowser/webpage.cpp:
1125         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1126         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1127
1128         * QtTestBrowser/webview.cpp:
1129         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1130         (WebViewGraphicsBased::animatedYFlip): Ditto.
1131
1132 2011-01-10  Sam Weinig  <sam@webkit.org>
1133
1134         Fix build.
1135
1136         * MiniBrowser/mac/BrowserWindowController.m:
1137         (-[BrowserWindowController awakeFromNib]):
1138         * MiniBrowser/win/BrowserView.cpp:
1139         (BrowserView::create):
1140         * WebKitTestRunner/TestController.cpp:
1141         (WTR::createOtherPage):
1142         (WTR::TestController::initialize):
1143
1144 2011-01-10  Eric Seidel  <eric@webkit.org>
1145
1146         Reviewed by Ojan Vafai.
1147
1148         style-queue messages are way too long for big patches
1149         https://bugs.webkit.org/show_bug.cgi?id=52161
1150
1151         We definitely could build much fancier list-to-string-with-limit functions
1152         but this should be sufficient for our needs at the moment.
1153
1154         * Scripts/webkitpy/common/system/executive.py:
1155         * Scripts/webkitpy/common/system/executive_unittest.py:
1156
1157 2011-01-10  Tony Chang  <tony@chromium.org>
1158
1159         Unreviewed, rolling out r75398.
1160         http://trac.webkit.org/changeset/75398
1161         https://bugs.webkit.org/show_bug.cgi?id=52008
1162
1163         Some layout tests are crashing on Chromium Win.
1164
1165         * DumpRenderTree/chromium/WebViewHost.cpp:
1166         (WebViewHost::updatePaintRect):
1167         * DumpRenderTree/chromium/WebViewHost.h:
1168
1169 2011-01-10  Adam Roben  <aroben@apple.com>
1170
1171         Roll out r75392
1172
1173         It isn't needed now that r75289 has been rolled out.
1174
1175         * Scripts/run-javascriptcore-tests:
1176
1177 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1178
1179         Reviewed by Anders Carlsson.
1180
1181         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1182         https://bugs.webkit.org/show_bug.cgi?id=52160
1183
1184         * WebKitTestRunner/mac/TestControllerMac.mm:
1185         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1186         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1187         anyway.
1188
1189 2011-01-10  Tony Chang  <tony@chromium.org>
1190
1191         Reviewed by Mihai Parparita.
1192
1193         [chromium] fix for animated gif layout tests
1194         https://bugs.webkit.org/show_bug.cgi?id=52008
1195
1196         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1197             to trigger gif animations.
1198         (WebViewHostPaintTask::WebViewHostPaintTask):
1199         (WebViewHostPaintTask::runIfValid):
1200         (WebViewHost::updatePaintRect):
1201         * DumpRenderTree/chromium/WebViewHost.h:
1202         (WebViewHost::taskList):
1203
1204 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1205
1206         Reviewed by Xan Lopez.
1207
1208         [GTK] Fix gtk2 compilation for master
1209         https://bugs.webkit.org/show_bug.cgi?id=51885
1210
1211         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1212         (createBitmapContextFromWebView): Replaced the old
1213         gdk_drawable_get_size with gdk_pixmap_get_size.
1214
1215 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1216
1217         Reviewed by Laszlo Gombos.
1218
1219         [WINCE] Reenable NPAPI after r75203
1220         https://bugs.webkit.org/show_bug.cgi?id=52109
1221
1222         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1223         it with !isEfl(), because EFL port does not support NPAPI (yet).
1224
1225         * Scripts/build-webkit:
1226
1227 2011-01-10  Adam Roben  <aroben@apple.com>
1228
1229         Skip some asserting JS tests
1230
1231         See <http://webkit.org/b/52156>.
1232
1233         * Scripts/run-javascriptcore-tests:
1234
1235 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1236
1237         Reviewed by Xan Lopez.
1238
1239         [GTK] build-webkit disable Blob support via arguments passed to automake
1240         https://bugs.webkit.org/show_bug.cgi?id=52097
1241
1242         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1243         build-webkit.
1244
1245 2011-01-10  Adam Roben  <aroben@apple.com>
1246
1247         Use the same name and description for TestNetscapePlugin on Windows and
1248         Mac
1249
1250         Fixes <http://webkit.org/b/52151>
1251         fast/frames/iframe-reparenting-plugins.html fails on Windows
1252
1253         Reviewed by Steve Falkenburg.
1254
1255         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1256         the name and description from Mac's Info.plist.
1257
1258 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1259
1260         Reviewed by Laszlo Gombos.
1261
1262         [Qt][WK2] Guard gcc-specific syntax
1263
1264         Non-gcc based compliers choke on the "-include"
1265         syntax for preinclude, place guard around it.
1266
1267         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1268         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1269
1270 2011-01-10  Andreas Kling  <kling@webkit.org>
1271
1272         Reviewed by Simon Hausmann.
1273
1274         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1275         https://bugs.webkit.org/show_bug.cgi?id=52111
1276
1277         When getting a createNewPage() callback from QWKPage, create the
1278         new page with the same QWKContext as the page that is passed to
1279         the callback.
1280
1281         * MiniBrowser/qt/BrowserView.h:
1282         * MiniBrowser/qt/BrowserWindow.cpp:
1283         (newPageFunction):
1284         (BrowserWindow::BrowserWindow):
1285         * MiniBrowser/qt/BrowserWindow.h:
1286
1287 2011-01-10  Andreas Kling  <kling@webkit.org>
1288
1289         Reviewed by Kenneth Rohde Christiansen.
1290
1291         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1292
1293         BrowserView set its own useless createNewPage() callback on QWKPage.
1294         This was immediately overridden by BrowserWindow anyway, so remove
1295         the BrowserView one.
1296
1297         * MiniBrowser/qt/BrowserView.cpp:
1298         (BrowserView::BrowserView):
1299
1300 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1301
1302         Reviewed by Jeremy Orlow.
1303
1304         [Chromium] Remove non-client-based Geolocation code
1305         https://bugs.webkit.org/show_bug.cgi?id=50921
1306
1307         * DumpRenderTree/chromium/LayoutTestController.cpp:
1308         (LayoutTestController::setGeolocationPermission):
1309         (LayoutTestController::setMockGeolocationPosition):
1310         (LayoutTestController::setMockGeolocationError):
1311         * DumpRenderTree/chromium/WebViewHost.cpp:
1312         (WebViewHost::geolocationClientMock):
1313         (WebViewHost::reset):
1314         * DumpRenderTree/chromium/WebViewHost.h:
1315
1316 2011-01-10  Eric Seidel  <eric@webkit.org>
1317
1318         Reviewed by Adam Barth.
1319
1320         Commit bot tried to land r? cq+ patch
1321         https://bugs.webkit.org/show_bug.cgi?id=36638
1322
1323         It should now be possible to post a patch with r? and cq+ and the
1324         commit-queue will correctly wait for the r+ before attempting to land the patch.
1325         (This was a feature requested by several users.)
1326
1327         One caveat: We don't actually reject r-, cq+ patches from the queue
1328         (we just ignore them), but I think that's OK for now.
1329
1330         I also noticed that setting r- once a commit-queue node had grabbed
1331         a patch would not properly cancel the landing.  That's fixed and
1332         tested in this patch.
1333
1334         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1335         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1336         * Scripts/webkitpy/tool/bot/feeders.py:
1337         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1338
1339 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1340
1341         Reviewed by Kenneth Rohde Christiansen.
1342
1343         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1344         https://bugs.webkit.org/show_bug.cgi?id=51934
1345
1346         When accessing the network from the destructor of QWebPage, the network access manager
1347         was already deleted because the object WebPage was already destructed.
1348
1349         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1350         The object is now destructed in the destructor of QObject.
1351
1352         * QtTestBrowser/webpage.cpp:
1353         (WebPage::WebPage):
1354         (WebPage::setQnamThreaded):
1355         * QtTestBrowser/webpage.h:
1356         (QtNAMThread::QtNAMThread):
1357
1358 2011-01-08  Eric Seidel  <eric@webkit.org>
1359
1360         Reviewed by Ojan Vafai.
1361
1362         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1363         https://bugs.webkit.org/show_bug.cgi?id=52067
1364
1365         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1366         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1367
1368         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1369
1370 2011-01-08  Eric Seidel  <eric@webkit.org>
1371
1372         Reviewed by Mihai Parparita.
1373
1374         commit-queue hangs when the ChangeLog diff is bad
1375         https://bugs.webkit.org/show_bug.cgi?id=52072
1376
1377         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1378         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1379
1380 2011-01-08  Adam Barth  <abarth@webkit.org>
1381
1382         Teach svn-apply how to re-write WebCore to Source/WebCore.
1383
1384         * Scripts/VCSUtils.pm:
1385
1386 2011-01-07  Adam Barth  <abarth@webkit.org>
1387
1388         Rubber-stamped by Eric Seidel.
1389
1390         Move WebCore to Source
1391         https://bugs.webkit.org/show_bug.cgi?id=52050
1392
1393         Update the tools to understand WebCore's new location.
1394
1395         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1396         * DumpRenderTree/wscript:
1397         * GNUmakefile.am:
1398         * Scripts/build-webkit:
1399         * Scripts/do-file-rename:
1400         * Scripts/do-webcore-rename:
1401         * Scripts/generate-qt-inspector-resource:
1402         * Scripts/prepare-ChangeLog:
1403         * Scripts/run-bindings-tests:
1404         * Scripts/update-iexploder-cssproperties:
1405         * Scripts/update-sources-list.py:
1406         * Scripts/update-webkit-localizable-strings:
1407         * Scripts/webkitdirs.pm:
1408         * Scripts/webkitpy/common/config/build.py:
1409         * Scripts/webkitpy/common/config/build_unittest.py:
1410         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1411         * Scripts/webkitpy/style/checker.py:
1412         * Scripts/webkitpy/style/checker_unittest.py:
1413         * WebKitTestRunner/DerivedSources.pro:
1414         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1415         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1416         * wx/browser/wscript:
1417         * wx/build/settings.py:
1418
1419 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1420
1421         Reviewed by Sam Weinig.
1422
1423         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1424         https://bugs.webkit.org/show_bug.cgi?id=52086
1425
1426         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1427         (WTR::InjectedBundle::didReceiveMessage):
1428         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1429         (WTR::LayoutTestController::notifyDone):
1430         * WebKitTestRunner/TestController.cpp:
1431         (WTR::TestController::resetStateToConsistentValues):
1432         (WTR::TestController::run):
1433
1434 2011-01-07  James Robinson  <jamesr@chromium.org>
1435
1436         Revert "Implement mozilla's animationTime property"
1437         https://bugs.webkit.org/show_bug.cgi?id=51952
1438
1439         This approach isn't quite right.
1440
1441         * DumpRenderTree/chromium/WebViewHost.cpp:
1442         (WebViewHost::paintInvalidatedRegion):
1443
1444 2011-01-07  Adam Roben  <aroben@apple.com>
1445
1446         Build master fix
1447
1448         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1449         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1450
1451 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1452
1453         Reviewed by Csaba Osztrogonác.
1454
1455         run-qtwebkit-tests should be able to kill a testsuite.
1456
1457         Add new option in the script that can setup a timeout for a test.
1458         If the test execution takes more then specified time then the test
1459         would be terminated.
1460
1461         [Qt] run-qtwebkit-tests needs timeout
1462         https://bugs.webkit.org/show_bug.cgi?id=51894
1463
1464         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1465         * Scripts/run-qtwebkit-tests:
1466
1467 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1468
1469         Unreviewed fix after r75233.
1470
1471         Based on idea from Eric Seidel.
1472
1473         Add remote zip file handling to webkitpy.
1474         https://bugs.webkit.org/show_bug.cgi?id=50901
1475
1476         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1477
1478 2011-01-07  Shane Stephens  <shanestephens@google.com>
1479
1480         Reviewed by Eric Seidel.
1481
1482         svn-apply: should support git binary delta diffs
1483         https://bugs.webkit.org/show_bug.cgi?id=38864
1484
1485         * Scripts/VCSUtils.pm:
1486         * Scripts/svn-apply:
1487
1488 2011-01-06  Julie Parent  <jparent@chromium.org>
1489
1490         Reviewed by Eric Seidel.
1491
1492         Test Result Server not removing old results.
1493         https://bugs.webkit.org/show_bug.cgi?id=52012
1494
1495         * TestResultServer/model/jsonresults.py:
1496         Fix off-by-one: Truncate if >= num_runs, not just >.
1497         * TestResultServer/model/jsonresults_unittest.py:
1498         Add unit test to test that merging in a new result with the same value
1499         as the last result causes previous result to fall off.
1500
1501 2011-01-06  James Kozianski  <koz@chromium.org>
1502
1503         Reviewed by Mihai Parparita.
1504
1505         Add classes to provide a consistent interface to a set of files.
1506         https://bugs.webkit.org/show_bug.cgi?id=50901
1507
1508         These classes allow us to write code that is agnostic to whether a
1509         particular set of files resides in a local directory or in a zip file
1510         on a remote machine.
1511
1512         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1513         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1514         * Scripts/webkitpy/common/system/fileset.py: Added.
1515         * Scripts/webkitpy/common/system/filesystem.py:
1516         * Scripts/webkitpy/common/system/filesystem_mock.py:
1517         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1518         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1519
1520 2011-01-06  Eric Seidel  <eric@webkit.org>
1521
1522         Reviewed by Adam Barth.
1523
1524         NetworkTransaction should log the url it is retrying
1525         https://bugs.webkit.org/show_bug.cgi?id=52043
1526
1527         * Scripts/webkitpy/common/net/networktransaction.py:
1528         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1529
1530 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1531
1532         Windows build fix.
1533         Import os before using it.
1534
1535         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1536
1537 2011-01-06  Eric Seidel  <eric@webkit.org>
1538
1539         Reviewed by Adam Barth.
1540
1541         StyleQueue fails to report errors when patches have many files
1542         https://bugs.webkit.org/show_bug.cgi?id=52042
1543
1544         This is one of at least two errors preventing style error reporting at the moment.
1545         When we moved to passing the list of files to check explicitly,
1546         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1547         We could change the type of the QueueStatus.message type, or we could
1548         just teach statusserver.py how to clamp values (and warn when it does).
1549         I chose the latter path.
1550
1551         * Scripts/webkitpy/common/net/statusserver.py:
1552
1553 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1554
1555         Reviewed by Stephanie Lewis.
1556         
1557         Fix syntax error in script.
1558
1559         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1560         https://bugs.webkit.org/show_bug.cgi?id=51996
1561
1562         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1563
1564 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1565
1566         Unreviewed, fixing WinCE build after r75196.
1567
1568         WinCE port does not (yet) support NPAPI.
1569
1570         * Scripts/build-webkit:
1571
1572 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1573
1574         Reviewed by Darin Adler.
1575
1576         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1577         https://bugs.webkit.org/show_bug.cgi?id=52015
1578
1579         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1580         after the platform has been detected, otherwise the script will
1581         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1582         detection.
1583
1584 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1585
1586         Reviewed by Eric Seidel.
1587
1588         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1589         https://bugs.webkit.org/show_bug.cgi?id=51346
1590
1591         * Scripts/build-webkit:
1592
1593 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1594
1595         Reviewed by Adam Roben.
1596
1597         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1598         https://bugs.webkit.org/show_bug.cgi?id=51996
1599         
1600         After the configuration directory change, we were archiving the incorrect directory for
1601         build product, so we were running tests on the wrong binaries.
1602         
1603         This change archives the correct directory, and also unarchives it into a configuration-
1604         specific directory.
1605
1606         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1607         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1608
1609 2011-01-06  Eric Seidel  <eric@webkit.org>
1610
1611         Reviewed by Mihai Parparita.
1612
1613         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1614         https://bugs.webkit.org/show_bug.cgi?id=52002
1615
1616         See an example of this here:
1617         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1618
1619         It's due to the fact that we pass around TestFailure() instance
1620         objects and yet expect them to all compare to be the same.
1621
1622         This is bad.  We should either have shared instances of these values
1623         or we should just pass around the class names.  There are already hacks
1624         in place to make TestFailure objects pass equality tests, I just added
1625         a __hash__ implementation so they can be used in sets as expected.
1626
1627         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1628         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1629
1630 2011-01-06  Evan Martin  <evan@chromium.org>
1631
1632         Reviewed by Tony Chang.
1633
1634         [gdb] handle inaccessible memory and UChar*
1635         https://bugs.webkit.org/show_bug.cgi?id=52003
1636
1637         To pretty-print a UChar*, we just grope around in the memory
1638         looking for a terminating NUL.  We need to handle the exception
1639         that can occur when we poke into an invalid location.
1640
1641         Additionally, the logic for choosing which pretty-printer would
1642         early return before hitting the point where we'd use the UChar*
1643         printer.  (Did this ever work?  How did it regress?)
1644
1645         * gdb/webkit.py:
1646
1647 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1648
1649         Reviewed by Ada Chan.
1650
1651         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1652         https://bugs.webkit.org/show_bug.cgi?id=51969
1653         
1654         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1655
1656         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1657         (WTR::InjectedBundlePage::InjectedBundlePage):
1658         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1659         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1660
1661 2011-01-06  James Robinson  <jamesr@chromium.org>
1662
1663         Reviewed by Simon Fraser.
1664
1665         Implement mozilla's animationTime property
1666         https://bugs.webkit.org/show_bug.cgi?id=51952
1667
1668         Chromium DRT support for webkitAnimationTime.
1669
1670         * DumpRenderTree/chromium/WebViewHost.cpp:
1671         (WebViewHost::paintInvalidatedRegion):
1672
1673 2011-01-06  Julie Parent  <jparent@chromium.org>
1674
1675         Reviewed by Tony Chang.
1676
1677         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1678         https://bugs.webkit.org/show_bug.cgi?id=51217
1679
1680         * TestResultServer/model/jsonresults.py:
1681         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1682         Adds missing documentation.
1683         * TestResultServer/model/jsonresults_unittest.py:
1684         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1685         Update test_merge to take a number of builds to truncate at.
1686
1687 2011-01-06  Adam Barth  <abarth@webkit.org>
1688
1689         Reviewed by Eric Seidel.
1690
1691         The EWS should log outside of the working directory
1692         https://bugs.webkit.org/show_bug.cgi?id=51986
1693
1694         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1695         script, which will actually clean the working copy back to a pristine
1696         state instead of leaving untracked directories and ignored files.
1697
1698         * Scripts/webkitpy/tool/commands/queues.py:
1699         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1700
1701 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1702
1703         Windows build fix.
1704         Back out attempted change to built-product-archive.
1705
1706         * BuildSlaveSupport/built-product-archive:
1707
1708 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1709
1710         Windows build fix.
1711         Include configuration name when unpacking a build archive.
1712
1713         Needed, since we split Windows build results into configuration-specific directories
1714         under WebKitOutputDir.
1715
1716         * BuildSlaveSupport/built-product-archive:
1717
1718 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1719
1720         Reviewed by Darin Adler.
1721
1722         Debug and Release builds on Windows clobber each other
1723         https://bugs.webkit.org/show_bug.cgi?id=49185
1724
1725         Changes the structure of WebKitBuild build products directory so we
1726         completely separate each build configuration into independent directories.
1727         
1728         Although we previously had per-configuration directories for obj, this change adds
1729         per-configuration directories for bin, lib, obj, and include. Each configuration's
1730         build products are stored within a directory inside of WebKitBuild.
1731         
1732         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1733         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1734
1735         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1736         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1737         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1738         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1739         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1740         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1741         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1742         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1743         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1744         * FindSafari/FindSafari.vcproj:
1745         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1746         * MiniBrowser/MiniBrowserPostBuild.cmd:
1747         * MiniBrowser/MiniBrowserPreBuild.cmd:
1748         * Scripts/webkitdirs.pm:
1749         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1750         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1751         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1752         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1753         * TestWebKitAPI/win/copy-resources.cmd:
1754         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1755         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1756         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1757         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1758         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1759         * WebKitTestRunner/win/InjectedBundle.vcproj:
1760         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1761         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1762         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1763         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1764         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1765         * WinLauncher/WinLauncherCommon.vsprops:
1766         * WinLauncher/WinLauncherPostBuild.cmd:
1767         * WinLauncher/WinLauncherPreBuild.cmd:
1768
1769 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1770
1771         Reviewed by Ariya Hidayat.
1772
1773         [Qt] TestNetscapePlugin doesn't link on OS X
1774         https://bugs.webkit.org/show_bug.cgi?id=51948
1775
1776         Only add a dependency on libX11 on X11 systems
1777
1778         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1779
1780 2011-01-05  Jeff Miller  <jeffm@apple.com>
1781
1782         Reviewed by Adam Roben.
1783
1784         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1785         https://bugs.webkit.org/show_bug.cgi?id=51970
1786
1787         * Scripts/webkitpy/style/checker.py:
1788         Add -readability/naming for WebKit2 C API directories.
1789
1790 2011-01-05  Eric Seidel  <eric@webkit.org>
1791
1792         Unreviewed, just fixing one more log error from my previous python patch.
1793
1794         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1795         https://bugs.webkit.org/show_bug.cgi?id=51802
1796
1797         webkit-patch failure-reason was logging about parsing errors
1798         due to my misunderstanding of how BeautifulSoup.findAll worked.
1799
1800         Fixed, and added a unit test.
1801
1802         * Scripts/webkitpy/common/net/layouttestresults.py:
1803         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1804
1805 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1806
1807         Reviewed by Kenneth Rohde Christiansen.
1808
1809         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1810         https://bugs.webkit.org/show_bug.cgi?id=51951
1811
1812         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1813         to create new window from WebKit.
1814
1815         * MiniBrowser/qt/BrowserWindow.cpp:
1816         (newPageFunction):
1817         (BrowserWindow::BrowserWindow):
1818         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1819         (BrowserWindow::newWindow):
1820         (BrowserWindow::updateUserAgentList):
1821         (BrowserWindow::showUserAgentDialog):
1822         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1823         define the type of the backing store used for new windows.
1824         * MiniBrowser/qt/main.cpp:
1825         (main):
1826
1827 2011-01-05  Eric Seidel  <eric@webkit.org>
1828
1829         Reviewed by Ojan Vafai.
1830
1831         commit-queue should report failure type when reporting flaky tests
1832         https://bugs.webkit.org/show_bug.cgi?id=51900
1833
1834         This patch was a ridiculous amount of plumbing.  In the end I like
1835         the NRWT-style TestResult class even less.  But now we're passing
1836         a list of TestResult objects from the queue to the FlakyTestReporter.
1837         Thus the FlakyTestReporter can more easily report what type of failure
1838         occurred.
1839
1840         In the process, I found that I was not alone in finding TestResult
1841         cumbersome to use.  A bunch of code was trying to create a TestResult
1842         object with default values.  However since the constructor didn't make
1843         this easy, some places were getting it wrong (including the TestResult unit test)!
1844         I've fixed the TestResult constructor to have default values for non-essential
1845         arguments.
1846
1847         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1848         * Scripts/webkitpy/common/net/layouttestresults.py:
1849         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1850         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1851         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1852         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1853         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1854         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1855         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1856         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1857         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1858         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1859         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1860         * Scripts/webkitpy/tool/commands/queues.py:
1861         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1862
1863 2011-01-05  Eric Seidel  <eric@webkit.org>
1864
1865         Unreviewed.
1866
1867         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1868         https://bugs.webkit.org/show_bug.cgi?id=51802
1869
1870         Add another unit test to cover a previously missing import.
1871
1872         * Scripts/webkitpy/common/net/layouttestresults.py:
1873         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1874
1875 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1876
1877         Reviewed by David Levin.
1878
1879         Add mihaip@chromium.org as a reviewer
1880         https://bugs.webkit.org/show_bug.cgi?id=51966
1881         
1882         Add myself as a reviewer.
1883
1884         * Scripts/webkitpy/common/config/committers.py:
1885
1886 2011-01-05  James Simonsen  <simonjam@chromium.org>
1887
1888         Unreviewed. Adding myself to the list of committers.
1889
1890         * Scripts/webkitpy/common/config/committers.py:
1891
1892 2011-01-05  Eric Seidel  <eric@webkit.org>
1893
1894         Unreviewed.
1895
1896         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1897         https://bugs.webkit.org/show_bug.cgi?id=51802
1898
1899         Fix two exceptions seen on the bots after my original commit.
1900
1901         * Scripts/webkitpy/common/net/layouttestresults.py:
1902         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1903
1904 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1905
1906         Reviewed by Andreas Kling.
1907
1908         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1909         https://bugs.webkit.org/show_bug.cgi?id=51750
1910
1911         * QtTestBrowser/main.cpp:
1912         (LauncherApplication::handleUserOptions):
1913          Local storage settings can be enable form command line arguments for
1914          QtTestBrowser.
1915
1916 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1917
1918         Reviewed by Martin Robinson.
1919
1920         GTK: AX: DRT needs to use correct root object method.
1921         https://bugs.webkit.org/show_bug.cgi?id=51911
1922
1923         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1924         (AccessibilityController::rootElement):
1925
1926 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1927
1928         Rubber-stamped by Csaba Osztrogonác.
1929
1930         Based on idea from Péter Gál.
1931
1932         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1933
1934 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1935
1936         Reviewed by Adam Barth.
1937
1938         sheriff-bot should be able to do multi-revision rollouts
1939         https://bugs.webkit.org/show_bug.cgi?id=51176
1940
1941         * Scripts/webkitpy/tool/bot/irc_command.py:
1942         * Scripts/webkitpy/tool/bot/sheriff.py:
1943         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1944
1945 2011-01-05  Eric Seidel  <eric@webkit.org>
1946
1947         Reviewed by Adam Barth.
1948
1949         queues.webkit.org should have per-bot status pages
1950         https://bugs.webkit.org/show_bug.cgi?id=51906
1951
1952         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1953         statuses from a single queue.  Now that we have many bots servicing
1954         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1955         you care about scroll off the end of the 15-message limit on the main page.
1956
1957         Eventually we should probably rename /queue-status to /queue or /queues,
1958         but that's fodder for another patch.
1959
1960         * QueueStatusServer/handlers/queuestatus.py:
1961         * QueueStatusServer/index.yaml:
1962         * QueueStatusServer/main.py:
1963         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1964          - This probably should use a custom filter instead of hard-coding
1965            the URL scheme here, but I couldn't figure out how to easily
1966            create such a filter.  Most filters work with "strings" so we can't
1967            pass the status object.  We could add a method to the status
1968            object and call that, but that seemed a bit strange too.
1969         * QueueStatusServer/templates/queuestatus.html:
1970
1971 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1972
1973         Unreviewed. Adding myself to the list of committers.
1974
1975         * Scripts/webkitpy/common/config/committers.py:
1976
1977 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1978
1979         Reviewed by David Levin.
1980
1981         check-webkit-style treated some macros with parentheses after #elif as function calls
1982         https://bugs.webkit.org/show_bug.cgi?id=51695
1983
1984         Ingore function call space checking in any preprocessor directives
1985         (things starting with #). Change search() to match() because 
1986         preprocessor directives are supposed to be in the beginning of lines.
1987
1988         * Scripts/webkitpy/style/checkers/cpp.py:
1989         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1990
1991 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1992
1993         Reviewed by Tony Chang.
1994
1995         Change the --multi-load test option to --stress-opt
1996         https://bugs.webkit.org/show_bug.cgi?id=50751
1997
1998         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1999         (runTest):
2000         (main):
2001         * DumpRenderTree/chromium/TestShell.cpp:
2002         (TestShell::TestShell):
2003         * DumpRenderTree/chromium/TestShell.h:
2004         (TestShell::stressOpt):
2005         (TestShell::setStressOpt):
2006         (TestShell::stressDeopt):
2007         (TestShell::setStressDeopt):
2008         (TestShell::javaScriptFlags):
2009         (TestShell::setJavaScriptFlags):
2010         * Scripts/webkitpy/layout_tests/port/chromium.py:
2011         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2012
2013 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2014
2015         Reviewed by Sam Weinig.
2016
2017         WK2: Support Accessibility
2018         https://bugs.webkit.org/show_bug.cgi?id=51859
2019
2020         Use rootObject() method to get top of accessibility tree.
2021
2022         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2023         (AccessibilityController::focusedElement):
2024         (AccessibilityController::rootElement):
2025
2026 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2027
2028         Reviewed by Darin Adler.
2029
2030         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2031         https://bugs.webkit.org/show_bug.cgi?id=51846
2032
2033         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2034         back to GRefPtr.
2035
2036 2011-01-04  Zhe Su  <suzhe@chromium.org>
2037
2038         Reviewed by Kenneth Russell.
2039
2040         Fix insertText, setMarkedText and unmarkText methods of
2041         TextInputController to call corresponding methods of WebKit::WebView
2042         rather than WebKit::WebFrame. This change matches the behavior of
2043         chromium browser.
2044         insertText corresponds to WebView::confirmComposition(text)
2045         setMarkedText corresponds to WebView::setComposition(...)
2046         unmarkText corresponds to WebView::confirmComposition()
2047         https://bugs.webkit.org/show_bug.cgi?id=51693
2048
2049         * DumpRenderTree/chromium/TextInputController.cpp:
2050         (TextInputController::insertText):
2051         (TextInputController::setMarkedText):
2052         (TextInputController::unmarkText):
2053
2054 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2055
2056         Reviewed by Laszlo Gombos.
2057
2058         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2059
2060         On Symbian productDir points to the source directory. Removing all the
2061         empty files from the productDir directory corrupts the svn repository.
2062
2063         * Scripts/build-webkit:
2064
2065 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2066
2067         Reviewed by Adam Barth.
2068
2069         [Qt] Add SelectAll option to the context menu for the editor
2070         https://bugs.webkit.org/show_bug.cgi?id=50049
2071
2072         Set shortcut for the SelectAll action.
2073
2074         * QtTestBrowser/mainwindow.cpp:
2075         (MainWindow::buildUI):
2076
2077 2011-01-03  David Levin  <levin@chromium.org>
2078
2079         Reviewed by Eric Seidel.
2080
2081         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2082         https://bugs.webkit.org/show_bug.cgi?id=51842
2083
2084         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2085         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2086
2087 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2088
2089         Reviewed by David Kilzer.
2090
2091         [WINCE] Adds a build slave.
2092         https://bugs.webkit.org/show_bug.cgi?id=50523
2093
2094         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2095         entry for a release build of the WinCE port.
2096         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2097         flag to build the WinCE port.
2098
2099 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2100
2101         Reviewed by David Kilzer.
2102
2103         Add WinCE support to build-webkit
2104         https://bugs.webkit.org/show_bug.cgi?id=51642
2105
2106         * Scripts/build-webkit:
2107         * Scripts/webkitdirs.pm:
2108
2109 2011-01-03  Eric Seidel  <eric@webkit.org>
2110
2111         Reviewed by Adam Barth.
2112
2113         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2114         https://bugs.webkit.org/show_bug.cgi?id=51802
2115
2116         I'm not the biggest fan of the test_failures or test_results classes,
2117         but it's better to have one shared set of classes, than separate ones
2118         for new vs. old run-webkit-test result handling.
2119
2120         This moves the ORWT results class "LayoutTestResults" over to using
2121         TestResult and TestFailure classes, making it easy for us to
2122         make all our sheriff-bot and other webkitpy code NRWT ready.
2123
2124         This also makes it a trivial patch to generate results.json information
2125         from ORWT results.html files (for flaky test analysis, etc.) as well
2126         as making it a one-liner to report test failure types when the
2127         commit-queue sees flaky tests.
2128
2129         This patch tried not to add new functionality, but only to replace
2130         the guts of LayoutTestResults, while adding unit tests and hoping
2131         not to break anything.
2132
2133         I also moved callers which assumed User.prompt* were static/class methods
2134         to using them as instance methods (since we'll eventually want to make them such).
2135
2136         In the process of re-writing things, I broke the rebaseline command, so I wrote
2137         a unit test to catch my breakage were I do do so again in the future.
2138
2139         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2140         * Scripts/webkitpy/common/net/layouttestresults.py:
2141         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2142         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2143         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2144         * Scripts/webkitpy/tool/commands/queries.py:
2145         * Scripts/webkitpy/tool/commands/rebaseline.py:
2146         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2147         * Scripts/webkitpy/tool/mocktool.py:
2148
2149 2011-01-03  Adam Barth  <abarth@webkit.org>
2150
2151         Reviewed by Simon Fraser.
2152
2153         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2154         https://bugs.webkit.org/show_bug.cgi?id=51840
2155
2156         * Scripts/webkitpy/common/checkout/scm.py:
2157
2158 2011-01-03  Adam Barth  <abarth@webkit.org>
2159
2160         Reviewed by Simon Fraser.
2161
2162         webkit-patch should only hide update output if --quiet
2163         https://bugs.webkit.org/show_bug.cgi?id=51838
2164
2165         As requested by smfr.
2166
2167         * Scripts/webkitpy/tool/steps/update.py:
2168
2169 2011-01-03  Adam Barth  <abarth@webkit.org>
2170
2171         Reviewed by David Levin.
2172
2173         commit-queue shouldn't reject patches twice if two bots process the same patch
2174         https://bugs.webkit.org/show_bug.cgi?id=51805
2175
2176         Before raising an error, we first check whether the patch is still in
2177         the commit-queue.  This check is still racy, of course, but the time
2178         window is much smaller.
2179
2180         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2181
2182 2011-01-03  Sam Weinig  <sam@webkit.org>
2183
2184         Reviewed by Anders Carlsson.
2185
2186         Make run-api-tests less chatty.
2187         https://bugs.webkit.org/show_bug.cgi?id=51831
2188
2189         - Make script quiet by default and add --verbose option (replacing --quiet).
2190         - When not verbose, pipe stdout and stderr to devnull.
2191
2192         * Scripts/run-api-tests:
2193
2194 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2195
2196         Unreviewed. Adding myself to committers.py.
2197
2198         * Scripts/webkitpy/common/config/committers.py:
2199
2200 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2201
2202         Reviewed by Xan Lopez.
2203
2204         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2205         https://bugs.webkit.org/show_bug.cgi?id=51806
2206
2207         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2208         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2209         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2210         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2211         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2212         so make it 'WebKitBuild/Release/.libs'
2213
2214         * Scripts/webkitdirs.pm: 
2215
2216 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2217
2218         Reviewed by Adam Barth.
2219
2220         Make EFL a core builder
2221         https://bugs.webkit.org/show_bug.cgi?id=51804
2222
2223         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2224         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2225
2226 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2227
2228         [Qt] Unreviewed fix after r74855 and r74875.
2229
2230         * BuildSlaveSupport/built-product-archive:
2231          - Create directories explicitly.
2232          - Pass shell=True to subprocess.call().
2233
2234 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2235
2236         [Qt] Unreviewed fix after r74855.
2237
2238         Move JavaScriptCore to Source
2239         https://bugs.webkit.org/show_bug.cgi?id=51604
2240
2241         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2242
2243 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2244
2245         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2246
2247         Move JavaScriptCore to Source
2248         https://bugs.webkit.org/show_bug.cgi?id=51604
2249
2250         * Scripts/webkitdirs.pm:
2251
2252 2011-01-02  Robert Hogan  <robert@webkit.org>
2253
2254         Unreviewed, build fix.
2255
2256         [Qt] Fix DRT build after 74855
2257
2258         * DumpRenderTree/qt/DumpRenderTree.pro:
2259
2260 2011-01-01  Adam Barth  <abarth@webkit.org>
2261
2262         Remove the assumption from the Qt and Gtk builds that every project is
2263         in the root directory.
2264
2265         * Scripts/build-webkit:
2266
2267 2011-01-01  Adam Barth  <abarth@webkit.org>
2268
2269         Reviewed by Eric Seidel.
2270
2271         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2272         https://bugs.webkit.org/show_bug.cgi?id=51796
2273
2274         After this change, svn-apply will magically apply patches to
2275         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2276
2277         * Scripts/VCSUtils.pm:
2278
2279 2011-01-01  Adam Barth  <abarth@webkit.org>
2280
2281         Reviewed by Eric Seidel.
2282
2283         Move JavaScriptCore to Source
2284         https://bugs.webkit.org/show_bug.cgi?id=51604
2285
2286         Update references to JavaScriptCore to point to the new location.
2287
2288         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2289         * DumpRenderTree/qt/DumpRenderTree.pro:
2290         * DumpRenderTree/qt/ImageDiff.pro:
2291         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2292         * DumpRenderTree/wscript:
2293         * Scripts/build-jsc:
2294         * Scripts/build-webkit:
2295         * Scripts/do-file-rename:
2296         * Scripts/do-webcore-rename:
2297         * Scripts/run-javascriptcore-tests:
2298         * Scripts/update-javascriptcore-test-results:
2299         * Scripts/webkitdirs.pm:
2300         * Scripts/webkitpy/common/config/build_unittest.py:
2301         * Scripts/webkitpy/style/checker.py:
2302         * Scripts/webkitpy/style/checker_unittest.py:
2303         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2304         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2305         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2306         * wx/build/settings.py:
2307
2308 2011-01-01  Adam Barth  <abarth@webkit.org>
2309
2310         Reviewed by Eric Seidel.
2311
2312         Move Sources to Source
2313         https://bugs.webkit.org/show_bug.cgi?id=51794
2314
2315         Update scripts to point to the new location.
2316
2317         * Scripts/build-webkit:
2318         * Scripts/do-file-rename:
2319         * Scripts/do-webcore-rename:
2320         * Scripts/webkitpy/common/config/build.py:
2321         * Scripts/webkitpy/common/config/build_unittest.py:
2322
2323 2010-12-31  Kent Tamura  <tkent@chromium.org>
2324
2325         Reviewed by Eric Seidel.
2326
2327         [DRT/Chromium] Enable mock spell checker on non-OSX
2328         https://bugs.webkit.org/show_bug.cgi?id=51401
2329
2330         * DumpRenderTree/chromium/WebViewHost.cpp:
2331         (WebViewHost::spellCheck):
2332
2333 2010-12-31  Adam Barth  <abarth@webkit.org>
2334
2335         Reviewed by Ariya Hidayat.
2336
2337         Remove Tools/Scripts/wkstyle
2338         https://bugs.webkit.org/show_bug.cgi?id=51774
2339
2340         This script appears to not have been touched in a while and seems to
2341         have been replaced by check-webkit-style.
2342
2343         * Scripts/wkstyle: Removed.
2344
2345 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2346
2347         Unreviewed. Coding style fix.
2348
2349         * DumpRenderTree/chromium/TestShell.h:
2350
2351 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2352
2353         Reviewed by Pavel Feldman.
2354
2355         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2356
2357         It was a problem with Chromium DRT. DevToolsAgent object instance was
2358         attached not only to the inspected page but to the DevTools window too.
2359         As result all the inspector files were interpreted as a content of inspected page
2360         and were transfered to the DevTools scripts panel for debugging etc.
2361
2362         https://bugs.webkit.org/show_bug.cgi?id=51735
2363
2364         * DumpRenderTree/chromium/TestShell.cpp:
2365         (TestShell::TestShell):
2366         (TestShell::bindJSObjectsToWindow):
2367         (TestShell::createNewWindow):
2368         * DumpRenderTree/chromium/TestShell.h:
2369
2370 2010-12-31  Adam Barth  <abarth@webkit.org>
2371
2372         Rubber-stamped by Eric Seidel.
2373
2374         Move PageLoadTests to PerformanceTests/PageLoad
2375         https://bugs.webkit.org/show_bug.cgi?id=51771
2376
2377         Update references to PageLoadTests to point to the new location.
2378
2379         * Scripts/run-pageloadtest:
2380         * Scripts/webkitpy/common/config/build.py:
2381
2382 2010-12-31  Adam Barth  <abarth@webkit.org>
2383
2384         Rubber-stamped by Eric Seidel.
2385
2386         Move SunSpider into PerformanceTests
2387         https://bugs.webkit.org/show_bug.cgi?id=51769
2388
2389         Update these scripts to point to the new location.
2390
2391         * Scripts/run-sunspider:
2392         * Scripts/sunspider-compare-results:
2393
2394 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2395
2396         Reviewed by Kent Tamura.
2397
2398         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2399         https://bugs.webkit.org/show_bug.cgi?id=51728
2400         
2401         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2402         to render top-level scrollbars. This makes them match the Mac port's
2403         use of an NSScrollView, which means that we'll be able to share more
2404         pixel baselines.
2405         
2406         The new rendering code will not be activated until the 
2407         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2408         ScrollbarThemeChromiumMac.
2409
2410         * DumpRenderTree/DumpRenderTree.gypi:
2411         * DumpRenderTree/chromium/TestShellMac.mm:
2412         (platformInit):
2413         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2414         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2415         (+[FakeActiveWindow alwaysActiveWindow]):
2416         (+[FakeActiveWindow alwaysInactiveWindow]):
2417         (-[FakeActiveWindow initWithActiveControls:]):
2418         (-[FakeActiveWindow _hasActiveControls]):
2419         (WebThemeEngineDRTMac::paintScrollbarThumb):
2420         (stateToHIEnableState):
2421         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2422         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2423
2424 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2425
2426         Reviewed by David Kilzer.
2427
2428         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2429         used
2430         https://bugs.webkit.org/show_bug.cgi?id=51672
2431
2432         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2433         with USE_SYSTEM_MALLOC=1
2434         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2435         with USE_SYSTEM_MALLOC=1
2436
2437 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2438
2439         Reviewed by David Kilzer.
2440
2441         [Qt] [Symbian] Fix build-webkit script for Symbian
2442         https://bugs.webkit.org/show_bug.cgi?id=51509
2443
2444         Set the OUTPUT_DIR for Symbian to be the same as the source
2445         directory.
2446
2447         * Scripts/webkitdirs.pm:
2448
2449 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2450
2451         Reviewed by Darin Adler.
2452
2453         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2454         https://bugs.webkit.org/show_bug.cgi?id=51758
2455
2456         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2457
2458         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2459         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2460
2461 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2462
2463         Unreviewed WinCE buildfix.
2464
2465         * WinCELauncher/main.cpp: Add missing include.
2466
2467 2010-12-29  Daniel Bates  <dbates@rim.com>
2468
2469         Reviewed by Darin Adler.
2470
2471         svn-apply updates date of wrong change log entry for a change log diff that
2472         contains two consecutive entries with the same author and date
2473         https://bugs.webkit.org/show_bug.cgi?id=46061
2474
2475         Fixes an issue where the date of the wrong change log entry may be modified.
2476         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2477         in a ChangeLog file to the top of the file.
2478
2479         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2480         diff when it detects that the diff inserts a change log entry earlier in a
2481         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2482         change. With the advent of the commit-queue this functionality of bailing out
2483         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2484         Instead, we should always move the change log entry to the top of the ChangeLog file.
2485
2486         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2487         the date line of the correct change log entry in a ChangeLog diff.
2488
2489         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2490
2491         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2492           Updated the following unit tests now that we move entries inserted earlier to the top:
2493           - "fixChangeLogPatch: New entry inserted in middle."
2494             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2495
2496           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2497             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2498
2499         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2500
2501 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2502
2503         Reviewed by Eric Seidel.
2504
2505         [Qt] Fixed compatibility with gold linker on X11 platforms
2506         https://bugs.webkit.org/show_bug.cgi?id=51700
2507
2508         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2509         Linked TestNetscapePlugin with libX11 on Unix platforms
2510
2511 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2512
2513         Reviewed by Darin Adler.
2514
2515         Circular dependency in webkitpy.common.checkout.changelog module
2516         https://bugs.webkit.org/show_bug.cgi?id=50475
2517
2518         Remove automatic import of api.Checkout module when any checkout/
2519         submodule is imported (e.g.: when checkout.scm.Git is imported).
2520
2521         * Scripts/webkitpy/common/checkout/__init__.py:
2522
2523 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2524
2525         Reviewed by Ojan Vafai.
2526
2527         prepare-ChangeLog should support the -g option for specifying the git-commit
2528         https://bugs.webkit.org/show_bug.cgi?id=51708
2529
2530         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2531         webkit-patch, though the exact meaning of the two options remain different.
2532
2533         * Scripts/prepare-ChangeLog: Add -g.
2534
2535 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2536
2537         Reviewed by Simon Hausmann.
2538
2539         [Qt] Fix compilation with Qt in namespace
2540         https://bugs.webkit.org/show_bug.cgi?id=51701
2541
2542         * QtTestBrowser/webview.h:
2543
2544 2010-12-28  Daniel Bates  <dbates@rim.com>
2545
2546         Reviewed by Sam Weinig.
2547
2548         Substitute // MARK: for compiler-specific #pragma mark
2549         https://bugs.webkit.org/show_bug.cgi?id=51657
2550
2551         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2552         substituting  "// MARK:" for "#pragma mark", which provides
2553         analogous code-bookmarking functionality under Xcode.
2554
2555         Also, for consistency, we should substitute "// MARK:" for compiler-
2556         specific "#pragma mark" in the source files for the Mac port.
2557
2558         * DumpRenderTree/AccessibilityTextMarker.cpp:
2559         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2560         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2561         * DumpRenderTree/mac/ObjCController.m:
2562         * MiniBrowser/mac/AppDelegate.m:
2563         * MiniBrowser/mac/BrowserWindowController.m:
2564
2565 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2566
2567         Reviewed by Eric Seidel.
2568
2569         Add --no-build option to run-sunspider
2570         https://bugs.webkit.org/show_bug.cgi?id=51658
2571
2572         * Scripts/run-sunspider: add --no-build flag to skip building
2573         phase.
2574
2575 2010-12-27  Daniel Bates  <dbates@rim.com>
2576
2577         Rubber-stamped by Martin Robinson.
2578
2579         Append the directory Tools/DumpRenderTree to the list of directories that
2580         do-webcore-rename should search so that it can rename DRT files and
2581         source code.
2582
2583         * Scripts/do-webcore-rename:
2584
2585 2010-12-27  Eric Seidel  <eric@webkit.org>
2586
2587         Reviewed by Adam Barth.
2588
2589         build-webkit should detect missing Java SDK and explain how to install it
2590         https://bugs.webkit.org/show_bug.cgi?id=51651
2591
2592         * Scripts/build-webkit:
2593
2594 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2595
2596         Reviewed by Daniel Bates.
2597
2598         [GTK] Add support for build-jsc
2599         https://bugs.webkit.org/show_bug.cgi?id=51625
2600
2601         Add GTK+ support to build-jsc now that building the jsc executable as
2602         a standalone target is easy.
2603
2604         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2605         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2606         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2607         and pass it along to buildAutotoolsProject.
2608
2609 2010-12-27  David Levin  <levin@chromium.org>
2610
2611         Reviewed by Eric Seidel.
2612
2613         check-webkit-style check for meaningless variable names in function declarations.
2614         https://bugs.webkit.org/show_bug.cgi?id=51523
2615
2616         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2617         from the new check and whitespace/parens because the syntax is unusual and
2618         produced a fair number of positives for these checks.
2619         * Scripts/webkitpy/style/checkers/cpp.py:
2620         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2621         and parameter names when determining if the parameter name is useless.
2622         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2623         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2624         format.
2625         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2626         text or an acronym of it.
2627         (check_function_definition): Checks function definitions for meaningless variable names.
2628         (process_line): Added call to check_function_definition.
2629         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2630         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2631         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2632         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2633         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2634         because when only checking a snippet, there are a lot of bogus functions.
2635         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2636         that I put there previously and just noticed.
2637         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2638         check_function_definition and process_line.
2639
2640 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2641
2642         Reviewed by Martin Robinson.
2643
2644         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2645         https://bugs.webkit.org/show_bug.cgi?id=51591
2646
2647         Flash plugin uses gtk2 that is incompatible with gtk3 making
2648         webkit crash when it's built with gtk3.
2649
2650         * GtkLauncher/main.c:
2651         (main):
2652
2653 2010-12-25  Adam Barth  <abarth@webkit.org>
2654
2655         Reviewed by Eric Seidel.
2656
2657         Move ANGLE to Sources/ThirdParty
2658         https://bugs.webkit.org/show_bug.cgi?id=51605
2659
2660         * Scripts/build-webkit:
2661           - Point to the new ANGLE location.
2662
2663 2010-12-26  David Levin  <levin@chromium.org>
2664
2665         Reviewed by Eric Seidel.
2666
2667         check-webkit-style should be able to parse function declaration parameters.
2668         https://bugs.webkit.org/show_bug.cgi?id=51451
2669
2670         * Scripts/webkitpy/style/checkers/cpp.py:
2671         (Position.__init__): Holds simple position information (row, column).
2672         (Parameter.__init__): Holds information about a parameter.
2673         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2674         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2675         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2676         (find_parameter_name_index): Finds where the parameter name is.
2677         (parameter_list): Generates the list of parameters for a function.
2678         (_FunctionState.begin): Added information to allow determining the parameters
2679         on demand.
2680         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2681         (detect_functions): Improve function detection for operator functions and
2682         determine where the parameters end and pass that to _FunctionState.begin.
2683         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2684         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2685         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2686         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2687         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2688         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2689         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2690         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2691         the parameters found.
2692         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2693         detection test to verify that we catch the operator functions.
2694         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2695         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2696         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2697         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2698         test_function_length_check_definition_severity1_for_test.
2699
2700 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2701
2702         Unreviewed WinCE buildfix after r74334.
2703
2704         * CMakeListsWinCE.txt:
2705
2706 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2707
2708         Unreviewed, rolling out r74632.
2709         http://trac.webkit.org/changeset/74632
2710         https://bugs.webkit.org/show_bug.cgi?id=51600
2711
2712         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2713         on #webkit).
2714
2715         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2716         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2717
2718 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2719
2720         Reviewed by Kenneth Rohde Christiansen.
2721
2722         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2723         https://bugs.webkit.org/show_bug.cgi?id=43528
2724
2725         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2726         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2727         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2728         called.
2729
2730         * EWebLauncher/main.c:
2731         (browserCreate):
2732
2733 2010-12-24  Eric Seidel  <eric@webkit.org>
2734
2735         Reviewed by Adam Barth.
2736
2737         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2738         https://bugs.webkit.org/show_bug.cgi?id=28291
2739
2740         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2741         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2742         to strings with find in the diff.
2743         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2744
2745         * Scripts/webkitpy/common/checkout/api.py:
2746         * Scripts/webkitpy/common/checkout/diff_parser.py:
2747         * Scripts/webkitpy/tool/steps/abstractstep.py:
2748         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2749         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2750         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2751         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2752
2753 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2754
2755         Reviewed by Kenneth Russell.
2756
2757         Modify new-run-webkit-tests to shut up and exit when all the threads
2758         are wedged so that test runs complete faster and we don't end up
2759         w/ enormous log files.
2760
2761         https://bugs.webkit.org/show_bug.cgi?id=51572
2762
2763         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2764         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2765
2766 2010-12-24  Eric Seidel  <eric@webkit.org>
2767
2768         Reviewed by David Levin.
2769
2770         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2771         https://bugs.webkit.org/show_bug.cgi?id=51549
2772
2773         I've had multiple people ask me about the commit-queue's behavior
2774         regarding reporting flaky tests.  I figured it would be best to just
2775         have the queue explain itself in the bugs it files.
2776
2777         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2778         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2779
2780 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2781
2782         Reviewed by Eric Seidel.
2783
2784         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2785         https://bugs.webkit.org/show_bug.cgi?id=51467
2786
2787         * Scripts/webkitpy/style/checker.py:
2788         * Scripts/webkitpy/style/checker_unittest.py:
2789
2790 2010-12-23  Adam Barth  <abarth@webkit.org>
2791
2792         Rubber-stamped by Eric Seidel.
2793
2794         Move JavaScriptGlue into Sources
2795         https://bugs.webkit.org/show_bug.cgi?id=51583
2796
2797         These tools refer to JavaScriptGlue and need to be updated to its new
2798         location.
2799
2800         * Scripts/build-webkit:
2801         * Scripts/do-file-rename:
2802         * Scripts/do-webcore-rename:
2803         * Scripts/webkitpy/common/config/build.py:
2804         * Scripts/webkitpy/common/config/build_unittest.py:
2805
2806 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2807
2808         Reviewed by Eric Seidel.
2809
2810         Bug 51539 - update iexploder scripts to point to new location
2811
2812         * Scripts/run-iexploder-tests:
2813         * Scripts/update-iexploder-cssproperties:
2814
2815 2010-12-23  Evan Martin  <evan@chromium.org>
2816
2817         Reviewed by Ryosuke Niwa.
2818
2819         [chromium] LayoutTestController warning in float->int conversion
2820         https://bugs.webkit.org/show_bug.cgi?id=51553
2821
2822         Rather than reading an int, converting to a float, then getting a compiler
2823         warning on passing the float to something that expects an int, instead
2824         just pass around ints.
2825
2826         No tests, fixes a compiler warning.
2827
2828         * DumpRenderTree/chromium/LayoutTestController.cpp:
2829         (parsePageSizeParameters):
2830         (LayoutTestController::pageNumberForElementById):
2831         (LayoutTestController::numberOfPages):
2832
2833 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2834
2835         Reviewed by Darin Adler.
2836
2837         Bug 51537 - iexploder needs cleanup
2838         
2839         * iExploder/htdocs: Removed.
2840         * iExploder/htdocs/config.rb: Removed.
2841         * iExploder/htdocs/cssproperties.in: Removed.
2842         * iExploder/htdocs/cssvalues.in: Removed.
2843         * iExploder/htdocs/htmlattrs.in: Removed.
2844         * iExploder/htdocs/htmltags.in: Removed.
2845         * iExploder/htdocs/htmlvalues.in: Removed.
2846         * iExploder/htdocs/iexploder.cgi: Removed.
2847         * iExploder/htdocs/iexploder.rb: Removed.
2848         * iExploder/htdocs/index.html: Removed.
2849         * iExploder/htdocs/webserver.rb: Removed.
2850         * iExploder/iexploder-1.7.2/output: Removed.
2851         * iExploder/tools: Removed.
2852         * iExploder/tools/lasthit.rb: Removed.
2853         * iExploder/tools/osx_last_crash.rb: Removed.
2854         * iExploder/tools/showtest.rb: Removed.
2855
2856 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2857
2858         Reviewed by Kenneth Rohde Christiansen.
2859
2860         [EFL] Make 'single' the default backing store in EWebLauncher
2861         https://bugs.webkit.org/show_bug.cgi?id=51534
2862
2863         'single' is the simplest backing store and the one intended to be the
2864         default in the test browser. By mistake the tiled backing store was
2865         left as default in r72617.
2866
2867         * EWebLauncher/main.c:
2868         (browserCreate): ditto.
2869
2870 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2871
2872         Reviewed by Kenneth Rohde Christiansen.
2873
2874         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2875         https://bugs.webkit.org/show_bug.cgi?id=51533
2876
2877         There's no point in concatenating env("HOME") with "blah", so remove
2878         option from EWebLauncher.
2879
2880         * EWebLauncher/main.c:
2881         (main): ditto.
2882
2883 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2884
2885         Reviewed by Eric Seidel.
2886
2887         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2888
2889         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2890         I just discovered that we have two additional GC runs per each WebViewHost.
2891         Test_shell had no such calls.
2892         These gc runs eat 15% of cpu time.
2893
2894         https://bugs.webkit.org/show_bug.cgi?id=51479
2895
2896         * DumpRenderTree/chromium/WebViewHost.cpp:
2897         (WebViewHost::~WebViewHost):
2898
2899 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2900
2901         Reviewed by Ojan Vafai.
2902
2903         This change splits out the TestRunner class into its own file.
2904         When we fork the code for message passing, we will create a new
2905         TestRunner, and this change will allow that to be more modular.
2906
2907         While we're at it, split out TestInput and ResultSummary into
2908         their own files, to reduce the size of run_webkit_tests to
2909         something more managable.
2910
2911         https://bugs.webkit.org/show_bug.cgi?id=51092
2912
2913         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2914         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2915         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2916         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2917         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2918         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2919         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2920
2921  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2922
2923         Reviewed by Ojan Vafai.
2924
2925         nrwt multiprocessing - start over, prepare to fork the code
2926  
2927         This code cleans up the signatures and implementation of the
2928         TestRunner class so we can easily fork it to run either the
2929         stable implementation or the new, unstable message-passing
2930         implementation. The two variants will have different
2931         implementations of the run_tests() method. We will switch
2932         between the two based on the setting for the '--worker-model'
2933         switch. We rename the two currently valid values to 'old-inline'
2934         and 'old-threads'.
2935
2936         https://bugs.webkit.org/show_bug.cgi?id=51081
2937
2938         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2939         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2940
2941 2010-12-22  Victor Wang  <victorw@chromium.org>
2942
2943         Reviewed by Darin Fisher.
2944
2945         [Chromium] Update chromium archive test result url in rebaseline script.
2946
2947         https://bugs.webkit.org/show_bug.cgi?id=51503
2948
2949         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2950
2951 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2952
2953         Reviewed by Alice Liu.
2954
2955         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2956         Verified on Chrome, Safari, and IE.
2957         With this change, we will record memory from a parent browser window and all child processes.
2958
2959         * record-memory-win/main.cpp:
2960         (ProcessArgs):
2961         (PrintUsage):
2962         (getMemoryInfo):
2963         (printProcessInfo):
2964         (evalProcesses):
2965         (UseImage):
2966         (QueryContinuously):
2967         (ElapsedTime):
2968
2969 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2970
2971         Unreviewed rollout r74489, because it was missing changelog.
2972
2973         * record-memory-win/main.cpp:
2974         
2975 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2976
2977         Adding myself as a reviewer.
2978
2979         * Scripts/webkitpy/common/config/committers.py:
2980
2981 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2982
2983         Unreviewed.  Adding myself to committers.py.
2984
2985         * Scripts/webkitpy/common/config/committers.py:
2986
2987 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2988
2989         Reviewed by Kenneth Rohde Christiansen.
2990
2991         TestNetscapePlugIn should use #if defined
2992         https://bugs.webkit.org/show_bug.cgi?id=51471
2993
2994         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2995         (NP_Initialize):
2996         (NPP_New):
2997
2998 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2999
3000         Reviewed by Yury Semikhatsky.
3001
3002         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3003
3004         DevTools window should be closed explicitly because it has custom deinitialization code.
3005
3006         https://bugs.webkit.org/show_bug.cgi?id=50722
3007
3008         * DumpRenderTree/chromium/TestShell.cpp:
3009         (TestShell::closeRemainingWindows):
3010
3011 2010-12-22  David Levin  <levin@chromium.org>
3012
3013         Reviewed by Shinichiro Hamaji.
3014
3015         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3016         https://bugs.webkit.org/show_bug.cgi?id=51452
3017
3018         * Scripts/webkitpy/style/checkers/cpp.py:
3019         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3020         Using the file extension if possible but falling back to the file contents if we have a header file.
3021         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3022         (_FileState.is_c_or_objective_c):
3023         (check_using_std): Changed to using _FileState to determine the file type.
3024         (check_max_min_macros): Ditto.
3025         (check_for_null): Ditto.
3026         (check_style): Changed the parameters to various calls since they now need _FileState
3027         to determine the file type.
3028         (check_language): Added the file_state parameter so it could be passed
3029         to check_identifier_name_in_declaration.
3030         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3031         this is an Objective C file.
3032         (_process_lines): Added information for the _FileState constructor (and moved the
3033         call to a place that had the information).
3034         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3035         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3036         its functionality.
3037         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3038
3039 2010-12-21  Andy Estes  <aestes@apple.com>
3040
3041         Reviewed by Mark Rowe.
3042
3043         Do not build non-Intel architectures for WebKit2-related projects.
3044         https://bugs.webkit.org/show_bug.cgi?id=51440
3045
3046         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3047         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3048         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3049
3050 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3051
3052         Reviewed by Darin Fisher.
3053
3054         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3055         https://bugs.webkit.org/show_bug.cgi?id=51406 
3056         
3057         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3058         to WebThemeEngineDRTWin and update references everywhere.
3059
3060         * DumpRenderTree/DumpRenderTree.gypi:
3061         * DumpRenderTree/chromium/TestShellWin.cpp:
3062         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3063         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3064         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3065         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3066
3067 2010-12-21  Anders Carlsson  <andersca@apple.com>
3068
3069         Reviewed by John Sullivan.
3070
3071         Clicking missing plug-in text does not show a sheet
3072         https://bugs.webkit.org/show_bug.cgi?id=51403
3073
3074         Update for changes to the WebPageUIClient.
3075
3076         * MiniBrowser/mac/BrowserWindowController.m:
3077         (-[BrowserWindowController awakeFromNib]):
3078         * WebKitTestRunner/TestController.cpp:
3079         (WTR::createOtherPage):
3080         (WTR::TestController::initialize):
3081
3082 2010-12-21  Eric Seidel  <eric@webkit.org>
3083
3084         Reviewed by Adam Barth.
3085
3086         commit-queue will report constant failures as flaky if other tests flake
3087         https://bugs.webkit.org/show_bug.cgi?id=51272
3088
3089         This patch just removes functionality and adds testing.
3090         Previously we attempted to report flaky tests when we had
3091         two different tests fail in a row.  However, since we stop
3092         running the tests at the first failure, our code was wrong in
3093         trying to determine flakiness from the incomplete runs.
3094
3095         Originally I posted an alternate patch:
3096         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3097         which fixed our flaky logic in this case, however it was decided
3098         that that patch would be too difficult to maintain, so now
3099         I'm just removing the broken logic.
3100
3101         This will dramatically cut-down on our flaky-test false positives
3102         at the (small) cost of the queues being unable to report
3103         any flakiness if the tree is very flaky.  (With at least one test
3104         flaking on every run, we'll never report failures anymore.)  I think
3105         this is a tradeoff worth making.
3106
3107         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3108         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3109
3110 2010-12-20  Eric Seidel  <eric@webkit.org>
3111
3112         Reviewed by Adam Barth.
3113
3114         commit-queue wrongly rejects patches when it can't update itself
3115         https://bugs.webkit.org/show_bug.cgi?id=46636
3116
3117         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3118         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3119         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3120
3121 2010-12-20  Adam Barth  <abarth@webkit.org>
3122
3123         Move web sites to Websites directory
3124         https://bugs.webkit.org/show_bug.cgi?id=51323
3125
3126         Update references to BugsSite to point to the new location.
3127
3128         This patch was never officially reviewed (because it was too large to
3129         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3130         Rowe gave me the green light.
3131
3132         * Scripts/old-run-webkit-tests:
3133         * Scripts/webkitpy/common/config/build.py:
3134         * Scripts/webkitpy/common/config/build_unittest.py:
3135         * Scripts/webkitpy/common/prettypatch.py:
3136         * Scripts/webkitpy/layout_tests/port/base.py:
3137         * Scripts/webkitpy/style/main.py:
3138
3139 2010-12-20  Adrienne Walker  <enne@google.com>
3140
3141         Unreviewed. Adding myself to the list of committers.
3142
3143         * webkitpy/common/config/committers.py:
3144
3145 2010-12-20  Mark Rowe  <mrowe@apple.com>
3146
3147         Reviewed by Dan Bernstein.
3148
3149         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3150
3151         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3152         Resources directory.
3153
3154 2010-12-20  Eric Seidel  <eric@webkit.org>
3155
3156         Reviewed by Adam Barth.
3157
3158         commit-queue should include bot id when attaching failure diffs
3159         https://bugs.webkit.org/show_bug.cgi?id=51280
3160
3161         This is a tiny change to include the bot id in the name of the attachment.
3162         Most of this diff is just changing the unit test expectations
3163         now that I hid the comment printing when the comment is None.
3164
3165         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3166         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3167         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3168         * Scripts/webkitpy/tool/mocktool.py:
3169
3170 2010-12-20  Jeff Miller  <jeffm@apple.com>
3171
3172         Reviewed by Dan Bernstein.
3173
3174         Tools/vcbin/midl.exe needs to be rebuilt
3175         https://bugs.webkit.org/show_bug.cgi?id=51347
3176
3177         * vcbin/midl.exe: Rebuilt.
3178
3179 2010-12-20  David Levin  <levin@chromium.org>
3180
3181         Reviewed by Ariya Hidayat.
3182
3183         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3184         https://bugs.webkit.org/show_bug.cgi?id=51343
3185
3186         Follow up from the WebKitTools -> Tools rename.
3187
3188         * Scripts/webkit-tools-completion.sh:
3189
3190 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3191
3192         Reviewed by James Robinson.
3193
3194         new-run-webkit-tests ignores trailing EOL differences in text tests
3195         https://bugs.webkit.org/show_bug.cgi?id=36983
3196
3197         Changed the handling of new-line characters within new-run-webkit-tests
3198         to match old-run-webkit-tests.  Differences in leading and trailing empty
3199         lines in text expectation files are no longer ignored.
3200
3201         * Scripts/webkitpy/layout_tests/port/base.py:
3202         * Scripts/webkitpy/layout_tests/port/test.py:
3203         Added unit tests.  Removed old duplicate unit test entries.
3204         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3205
3206 2010-12-20  David Levin  <levin@chromium.org>
3207
3208         Reviewed by Shinichiro Hamaji.
3209
3210         check-webkit-style should detect function declarations (and trivial functions).
3211         https://bugs.webkit.org/show_bug.cgi?id=51303
3212
3213         * Scripts/webkitpy/style/checkers/cpp.py:
3214         (_FunctionState.begin): Add is_declaration and changed the line count
3215         start to begin at -1 (which will keep the results consistent, since
3216         the starting line number passed in is one less in this change).
3217         (detect_functions): changed function detection to now catch trivial
3218         functions and declarations.
3219         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3220         of the function as this may look at return values (when processing
3221         a declaration).
3222         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3223         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3224         of testing the function detection.
3225         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3226         function.
3227         (FunctionDetectionTest.test_function_declaration_detection): Test a
3228         declaration.
3229         (FunctionDetectionTest.test_non_functions): A test case for a case
3230         that caused the code to fail due to the { being in quotes.
3231         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3232         cases to help catch false alarms for return values.
3233         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3234         we don't get false alarms for member variables either.
3235
3236 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3237
3238         Reviewed by Antonio Gomes.
3239
3240         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3241         https://bugs.webkit.org/show_bug.cgi?id=51319
3242
3243         * CMakeListsEfl.txt:
3244
3245 2010-12-18  Adam Barth  <abarth@webkit.org>
3246
3247         Reviewed by Sam Weinig.
3248
3249         Move WebKitExamplePlugins to Examples
3250         https://bugs.webkit.org/show_bug.cgi?id=51291
3251
3252         * Scripts/webkitpy/common/config/build.py:
3253
3254 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3255
3256         Unreviewed Qt buildfix after r74301.
3257
3258         Rename WebKitTools to Tools
3259         https://bugs.webkit.org/show_bug.cgi?id=49861
3260
3261         * MiniBrowser/DerivedSources.pro:
3262         * MiniBrowser/qt/MiniBrowser.pro:
3263
3264 2010-12-17  Dan Bernstein  <mitz@apple.com>
3265
3266         Reviewed by Simon Fraser.
3267
3268         Rename WebKitTools to Tools
3269         https://bugs.webkit.org/show_bug.cgi?id=49861
3270
3271         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3272         * CodeCoverage/README:
3273         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3274         (WebCore::DumpRenderTree::initializeFonts):
3275         * EWSTools/start-commit-queue.sh:
3276         * EWSTools/start-queue.sh:
3277         * GNUmakefile.am:
3278         * MIDLWrapper/MIDLWrapper.cpp:
3279         (wmain):
3280         * MiniBrowser/qt/MiniBrowser.pro:
3281         * Scripts/build-api-tests:
3282         * Scripts/build-dumprendertree:
3283         * Scripts/build-webkit:
3284         * Scripts/build-webkittestrunner:
3285         * Scripts/generate-coverage-data:
3286         * Scripts/old-run-webkit-tests:
3287         * Scripts/run-api-tests:
3288         * Scripts/run-iexploder-tests:
3289         * Scripts/run-javascriptcore-tests:
3290         * Scripts/run-mangleme-tests:
3291         * Scripts/run-sunspider:
3292         * Scripts/run-webkit-websocketserver:
3293         * Scripts/sunspider-compare-results:
3294         * Scripts/test-webkitperl:
3295         * Scripts/test-webkitpy:
3296         * Scripts/update-iexploder-cssproperties:
3297         * Scripts/update-webkit:
3298         * Scripts/update-webkit-localizable-strings:
3299         * Scripts/webkitdirs.pm:
3300         * Scripts/webkitpy/common/checkout/scm.py:
3301         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3302         * Scripts/webkitpy/common/config/committervalidator.py:
3303         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3304         * Scripts/webkitpy/common/config/ports.py:
3305         * Scripts/webkitpy/common/config/ports_unittest.py:
3306         * Scripts/webkitpy/common/system/logutils_unittest.py:
3307         * Scripts/webkitpy/common/system/ospath_unittest.py:
3308         * Scripts/webkitpy/layout_tests/port/chromium.py:
3309         * Scripts/webkitpy/layout_tests/port/config.py:
3310         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3311         * Scripts/webkitpy/layout_tests/port/http_server.py:
3312         * Scripts/webkitpy/layout_tests/port/test.py:
3313         * Scripts/webkitpy/style/checker.py:
3314         * Scripts/webkitpy/style/checker_unittest.py:
3315         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3316         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3317         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3318         * WebKitTestRunner/DerivedSources.pro:
3319         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3320         (WTR::activateFonts):
3321         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3322         * wx/build/build_utils.py:
3323
3324 2010-12-16  Antonio Gomes  <agomes@rim.com>
3325
3326         Reviewed by Martin Robinson.
3327
3328         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3329         https://bugs.webkit.org/show_bug.cgi?id=51163
3330
3331         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3332         GTK+'s DRT should also reset to UNIX after each test execution.
3333
3334         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3335         (resetDefaultsToConsistentValues):
3336
3337 2010-12-17  David Levin  <levin@chromium.org>
3338
3339         Reviewed by Eric Seidel.
3340
3341         check-webkit-style should understand WTF #include guards
3342         https://bugs.webkit.org/show_bug.cgi?id=44911
3343
3344         * Scripts/webkitpy/style/checkers/cpp.py:
3345         (get_header_guard_cpp_variable): modify to suggest the WTF style
3346         of header guard when appropriate.
3347         (check_for_header_guard): handle multiple return values from
3348         get_header_guard_cpp_variable
3349         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3350         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3351         header style.
3352
3353 2010-12-16  David Levin  <levin@chromium.org>
3354
3355         Reviewed by Eric Seidel.
3356
3357         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3358         https://bugs.webkit.org/show_bug.cgi?id=51210
3359
3360         The error only shows up when using python 2.6 or later.
3361
3362         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3363         the decprecated field error,message with something equivalent.
3364
3365 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3366
3367         Reviewed by Eric Seidel.
3368
3369         Add --exit-after-n-failures/crashes to NRWT
3370         https://bugs.webkit.org/show_bug.cgi?id=51160
3371         
3372         Abort test run (in a similar way to how control-C is handled) when
3373         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3374         that number of unexpected failures/crashes/timeouts.
3375
3376         * Scripts/webkitpy/layout_tests/port/test.py:
3377         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3378         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3379
3380 2010-12-16  David Levin  <levin@chromium.org>
3381
3382         Reviewed by Shinichiro Hamaji.
3383
3384         check-webkit-style unit tests has some duplicate boilerplate code.
3385         https://bugs.webkit.org/show_bug.cgi?id=49519
3386
3387         * Scripts/webkitpy/style/checkers/cpp.py:
3388         (update_include_state): Replaced the "io" parameter with the global
3389         configuration _unit_test_config. This allowed not calling into
3390         functions at a low level and also not plumbing through the injection
3391         information through many levels of code.
3392         (check_for_include_what_you_use): Ditto.
3393         (process_file_data): Added the ability to set up the unit test config
3394         to allow for injection.
3395         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3396         (ErrorCollector.__init__): Added support for having a filter for errors.
3397         (ErrorCollector.__call__): Ditto.
3398         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3399         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3400         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3401         functions in the cpp.py with generic processing and a filter that
3402         indicates what errors should be kept.
3403         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3404         (CppStyleTestBase.perform_language_rules_check): Ditto.
3405         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3406         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3407         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3408         (CppStyleTest.test_multi_line_comments): Added another
3409         error message which applies to the test case.
3410         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3411         to not have config.h, since it is processed as a header file.
3412         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3413         style and indentation in checked code.
3414         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3415         Fixed line number.
3416         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3417         Ditto.
3418
3419 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3420
3421         Unreviewed, rolling out r74136.
3422         http://trac.webkit.org/changeset/74136
3423         https://bugs.webkit.org/show_bug.cgi?id=51135
3424
3425         r74136 breaks chromium canary bots because some tests are not
3426         rebaselined correctly to resolve EOL differences (Requested by
3427         jianli on #webkit).
3428
3429         * Scripts/webkitpy/layout_tests/port/base.py:
3430         * Scripts/webkitpy/layout_tests/port/test.py:
3431         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3432
3433 2010-12-15  Adam Roben  <aroben@apple.com>
3434
3435         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3436         syntax errors
3437
3438         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3439         XML syntax errors in .vcproj/.vsprops files
3440
3441         Reviewed by Dave Levin.
3442
3443         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3444         that should be treated as XML and that should be allowed to contain
3445         carriage returns. (These lists happen to be identical currently.)
3446         (FileType): Added a new XML type.
3447         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3448         Just does a simple file extension check.
3449         (CheckerDispatcher._file_type): Added a case for XML files.
3450         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3451         files (surprise!).
3452         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3453         lines through the carriage checker.
3454
3455         * Scripts/webkitpy/style/checker_unittest.py:
3456         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3457         Added. Checks a few file names to see if carriage returns are allowed
3458         or not.
3459         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3460         other assert_checker_* functions.
3461         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3462         test_*_paths functions.
3463         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3464         test_*_paths functions.
3465         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3466         file from this test case, as vcproj files now have a type.
3467         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3468         Added. Similar to the other should_* functions.
3469         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3470         Added. Checks that carriage returns aren't checked for or stripped for
3471         allowed files.
3472
3473         * Scripts/webkitpy/style/checkers/xml.py: Added.
3474         (XMLChecker.__init__): Simple init method.
3475         (XMLChecker.check): Pass each line through the expat parser, and record
3476         a style error for any errors thrown by the parser.
3477
3478         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3479         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3480         produce a style error.
3481         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3482         error of the given category on the given line.
3483         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3484         checking that the XMLChecker constructor works properly.
3485         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3486         cause a style error (see, e.g., r73887).
3487         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3488         cause a style error (see, e.g., r73773).
3489         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3490         properly.
3491         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3492         tags cause a style error (see, e.g., r72795).
3493         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3494         style error.
3495
3496 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3497
3498         Reviewed by Stephanie Lewis.
3499
3500         https://bugs.webkit.org/show_bug.cgi?id=51117
3501         Add a new leopard test bot
3502         really really commit to trunk this time.
3503
3504         * BuildSlaveSupport/build.webkit.org-config/config.json:
3505
3506 2010-12-15  Sam Weinig  <sam@webkit.org>
3507
3508         Reviewed by Anders Carlsson.
3509
3510         WebKit2: Can't add files to an <input type=file>
3511         https://bugs.webkit.org/show_bug.cgi?id=51087
3512
3513         * MiniBrowser/mac/BrowserWindowController.m:
3514         (runOpenPanel):
3515         (-[BrowserWindowController awakeFromNib]):
3516         Add simple implementation of runOpenPanel callback.
3517
3518         * MiniBrowser/win/BrowserView.cpp:
3519         (BrowserView::create):
3520         * WebKitTestRunner/TestController.cpp:
3521         (WTR::createOtherPage):
3522         (WTR::TestController::initialize):
3523         Stub out runOpenPanel callback. 
3524
3525 2010-12-14  Eric Seidel  <eric@webkit.org>
3526
3527         Reviewed by Adam Barth.
3528
3529         commit-queue should upload failure diffs when tests flake
3530         https://bugs.webkit.org/show_bug.cgi?id=51051
3531
3532         To make this testable I needed to pipe FileSystem down onto tool.
3533         We've wanted it there for a long time anyway.
3534
3535         This patch is kinda a big hack.  But we don't have a nice
3536         way to read results.html files.  I think this will need further
3537         revision before this code actually feels clean.
3538
3539         As part of testing this change, I had to make MockBugzilla.create_bug
3540         actually return an id (like it should) which required updating
3541         a few other unit test results (for the better).
3542
3543         The results_matching_keys change in layouttestresults/rebasline
3544         was an alternate path which I decided not to use in the end, but
3545         I left the change as it seemed an improvement.
3546
3547         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3548         * Scripts/webkitpy/common/net/layouttestresults.py:
3549         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3550         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3551         * Scripts/webkitpy/tool/commands/queues.py:
3552         * Scripts/webkitpy/tool/commands/rebaseline.py:
3553         * Scripts/webkitpy/tool/main.py:
3554         * Scripts/webkitpy/tool/mocktool.py:
3555
3556 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3557
3558         Reviewed by James Robinson.
3559
3560         new-run-webkit-tests ignores trailing EOL differences in text tests
3561         https://bugs.webkit.org/show_bug.cgi?id=36983
3562
3563         Changed the handling of new-line characters within new-run-webkit-tests
3564         to match old-run-webkit-tests.  Differences in leading and trailing empty
3565         lines in text expectation files are no longer ignored.
3566
3567         * Scripts/webkitpy/layout_tests/port/base.py:
3568         * Scripts/webkitpy/layout_tests/port/test.py:
3569         Added unit tests.  Removed old duplicate unit test entries.
3570         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3571
3572 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3573
3574         Reviewed by Adam Barth.
3575
3576         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3577         https://bugs.webkit.org/show_bug.cgi?id=51149
3578
3579         * QueueStatusServer/templates/statusbubble.html:
3580
3581 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3582
3583         Reviewed by Adam Barth.
3584
3585         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3586         https://bugs.webkit.org/show_bug.cgi?id=51125
3587
3588         * QueueStatusServer/templates/statusbubble.html:
3589
3590 2010-12-15  Darin Adler  <darin@apple.com>
3591
3592         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3593
3594 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3595
3596         Unreviewed, rolling out r74117.
3597         http://trac.webkit.org/changeset/74117
3598         https://bugs.webkit.org/show_bug.cgi?id=51113
3599
3600         This broke the GTK1 build. (Requested by mrobinson on
3601         #webkit).
3602
3603         * Scripts/webkitdirs.pm:
3604
3605 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3606
3607         Reviewed by Martin Robinson.
3608
3609         Change generate-forwarding-headers.pl for GTK port usage 
3610         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3611
3612         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3613
3614 2010-12-14  Kent Tamura  <tkent@chromium.org>
3615
3616         Reviewed by Jian Li.
3617
3618         [DRT/Chromium] Remove another unnecessary error message
3619         https://bugs.webkit.org/show_bug.cgi?id=51083
3620
3621         * DumpRenderTree/chromium/WebViewHost.cpp:
3622         (WebViewHost::didInvalidateRect):
3623
3624 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3625
3626         Reviewed by Stephanie Lewis.
3627
3628         Add a new Leopard Debug Test WK2 Bot
3629
3630         * BuildSlaveSupport/build.webkit.org-config/config.json:
3631
3632 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3633
3634         Fix python unittests after http://trac.webkit.org/changeset/74070.
3635
3636         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3637
3638 2010-12-14  Kent Tamura  <tkent@chromium.org>
3639
3640         Reviewed by Jian Li.
3641
3642         [DRT/Chromium] Remove a unnecessary error message
3643         https://bugs.webkit.org/show_bug.cgi?id=51069
3644
3645         * DumpRenderTree/chromium/WebViewHost.cpp:
3646         (WebViewHost::paintInvalidatedRegion):
3647
3648 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3649
3650         Reviewed by Ojan Vafai.
3651
3652         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3653         https://bugs.webkit.org/show_bug.cgi?id=48926
3654
3655         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3656         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3657
3658 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3659
3660         Reviewed by Eric Seidel.
3661
3662         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3663         https://bugs.webkit.org/show_bug.cgi?id=50231
3664
3665         Guard CONFIG+=link_pkgconfig with !symbian.
3666
3667         * DumpRenderTree/qt/DumpRenderTree.pro:
3668         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3669         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3670
3671 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3672
3673         Reviewed by Ojan Vafai.
3674
3675         [new-run-webkit-tests] expectations parsing is slow
3676         https://bugs.webkit.org/show_bug.cgi?id=50635
3677
3678         Avoid expensive iteration of all the tests when checking if a test
3679         file is to be skipped or not.
3680
3681         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3682         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3683         * Scripts/webkitpy/layout_tests/port/test.py:
3684
3685 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3686
3687         Reviewed by Xan Lopez.
3688
3689         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3690         https://bugs.webkit.org/show_bug.cgi?id=27048
3691
3692         Add support in DRT for checking whether an accessibility UI
3693         element is focusable and/or focused. Implemented for GTK.
3694
3695         * DumpRenderTree/AccessibilityUIElement.cpp:
3696         (getIsFocusedCallback): New.
3697         (getIsFocusableCallback): New.
3698         (AccessibilityUIElement::getJSClass): Add the new available
3699         callbacks for isFocused and isFocusable.
3700         * DumpRenderTree/AccessibilityUIElement.h:
3701         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3702         (AccessibilityUIElement::isFocused): New, implemented by checking
3703         whether the related AtkState value is in the object's state set.
3704         (AccessibilityUIElement::isFocusable): Ditto.
3705         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3706         (AccessibilityUIElement::isFocused): New, dummy implementation.
3707         (AccessibilityUIElement::isFocusable): Ditto.
3708         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3709         (AccessibilityUIElement::isFocused): Ditto.
3710         (AccessibilityUIElement::isFocusable): Ditto.
3711
3712 2010-12-14  Eric Seidel  <eric@webkit.org>
3713
3714         Reviewed by Ojan Vafai.
3715
3716         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3717         https://bugs.webkit.org/show_bug.cgi?id=50715
3718
3719         This patch makes webkit-patch print the following:
3720
3721         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3722         Install a 64-bit git for better performance, see:
3723         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3724
3725         I wrote this mostly because I have approximately 8 machines that I use
3726         and making sure each one is using a good Git install seemed folly.
3727         webkit-patch makes a lot of git calls, so using a fast git can shave
3728         several seconds in every invocation.  See the webkit-dev thread for more info.
3729
3730         This message will print twice during 'webkit-patch upload',
3731         once from webkit-patch and once from check-webkit-style.
3732
3733         Unfortunately there is no good way to test this due to how machine-dependent
3734         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3735
3736         * Scripts/webkitpy/common/checkout/scm.py:
3737
3738 2010-12-13  Eric Seidel  <eric@webkit.org>
3739
3740         Reviewed by Adam Barth.
3741
3742         FlakyTestReporter doesn't understand bots running from multiple email addresses
3743         https://bugs.webkit.org/show_bug.cgi?id=50960
3744
3745         This explains at least one of the dupes of:
3746         https://bugs.webkit.org/show_bug.cgi?id=50863
3747         that we saw filed by the commit-queue this morning.
3748         I think the other one was explained by my previous fix to result counting code.
3749
3750         Since this is really hard to test with a unit test, instead I
3751         create a new (possibly useful in the future) command
3752         which given a layout test path will return you
3753         the one bug which our tools would assume it the flaky test bug.
3754         If some other script wants to use bug-for-test we'll
3755         need to extend it with some options like --create-if-missing or similar.
3756
3757         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3758         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: