Remove support for WebKitSystemInterface
[WebKit.git] / Tools / ChangeLog
1 2020-03-16  Keith Rollin  <krollin@apple.com>
2
3         Remove support for WebKitSystemInterface
4         https://bugs.webkit.org/show_bug.cgi?id=208894
5         <rdar://problem/60297590>
6
7         Reviewed by Brent Fulgham.
8
9         This project provided support for facilities that are now handled
10         elsewhere and is no longer needed.
11
12         * Scripts/copy-webkitlibraries-to-product-directory:
13
14 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
15
16         [macOS] Accessibility sandbox regressions
17         https://bugs.webkit.org/show_bug.cgi?id=209065
18
19         Reviewed by Brent Fulgham.
20
21         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
22         (TEST):
23         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
24         (TEST):
25
26 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
27
28         Unreviewed infrastructure fix.
29
30         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
31         while the hardware is out for repair.
32
33 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
34
35         [WebXR] IDLs, stubs and build configuration for WPE
36         https://bugs.webkit.org/show_bug.cgi?id=208702
37
38         Reviewed by Dean Jackson.
39
40         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
41         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
42
43 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
44
45         [Cocoa] Limit set of classes that can be decoded when a preference has changed
46         https://bugs.webkit.org/show_bug.cgi?id=208012
47
48         Reviewed by Brent Fulgham.
49
50         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
51         (TEST):
52
53 2020-03-16  youenn fablet  <youenn@apple.com>
54
55         Unique origins should not be Potentially Trustworthy
56         https://bugs.webkit.org/show_bug.cgi?id=209049
57
58         Reviewed by Darin Adler.
59
60         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
61         (TestWebKitAPI::TEST_F):
62
63 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
64
65         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
66         https://bugs.webkit.org/show_bug.cgi?id=207324
67
68         Reviewed by Darin Adler.
69
70         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
71         (TestWebKitAPI::generateRandomData): Added.
72         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
73
74 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
75
76         Should not use variable-length-array (VLA)
77         https://bugs.webkit.org/show_bug.cgi?id=209043
78
79         Reviewed by Mark Lam.
80
81         * ContentExtensionTester/Configurations/Base.xcconfig:
82         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
83
84 2020-03-13  Alex Christensen  <achristensen@webkit.org>
85
86         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
87         https://bugs.webkit.org/show_bug.cgi?id=209011
88         <rdar://problem/59370588>
89
90         Reviewed by Youenn Fablet.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
93         (TestWebKitAPI::TEST):
94
95 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
96
97         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
98         https://bugs.webkit.org/show_bug.cgi?id=209089
99
100         Reviewed by Tim Horton.
101
102         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
103         marketing name for the feature.
104
105         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
106         (runUntilReceivesAutoplayEvent):
107
108         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
109         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
110         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
111         be any compelling reason to compare against different types here (especially since we only set
112         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
113         these all to be `_WKAutoplayEvent`.
114
115         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
116         (-[AutoFillTestView _autofillInputView]):
117         (-[AutoFillTestView textInputHasAutoFillContext]):
118         (TestWebKitAPI::TEST):
119         (-[AutofillTestView initWithFrame:]): Deleted.
120         (-[AutofillTestView _autofillInputView]): Deleted.
121         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
122         * TestWebKitAPI/ios/UIKitSPI.h:
123
124 2020-03-13  Chris Dumez  <cdumez@apple.com>
125
126         Unreviewed, reverting r256232.
127
128         Caused ResizeObserver tests to become flaky
129
130         Reverted changeset:
131
132         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
133         override TestOptions"
134         https://bugs.webkit.org/show_bug.cgi?id=207481
135         https://trac.webkit.org/changeset/256232
136
137 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
138
139         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
140         https://bugs.webkit.org/show_bug.cgi?id=209016
141         <rdar://problem/60329530> 
142
143         Reviewed by Chris Dumez.
144
145         Re-initialize the app-bound domains when the correct
146         TestOptions parameter is set.
147
148         * WebKitTestRunner/TestController.cpp:
149         (WTR::TestController::createWebViewWithOptions):
150         (WTR::TestController::reinitializeAppBoundDomains):
151         * WebKitTestRunner/TestController.h:
152
153 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
154
155         Report all third party loads on a per-page basis
156         https://bugs.webkit.org/show_bug.cgi?id=209032
157         <rdar://problem/60397323>
158
159         Reviewed by Chris Dumez.
160
161         Mostly naming updates to reflect the change in use for this SPI call.
162         It now returns all loaded third party domains, not just prevalent ones.
163
164         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
165         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
166         (WTR::InjectedBundle::didReceiveMessageToPage):
167         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
168         (WTR::TestRunner::getLoadedThirdPartyDomains):
169         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
170         (WTR::TestRunner::getPrevalentDomains): Deleted.
171         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
172         * WebKitTestRunner/InjectedBundle/TestRunner.h:
173         * WebKitTestRunner/TestController.cpp:
174         (WTR::TestController::resetStateToConsistentValues):
175         (WTR::TestController::getLoadedThirdPartyDomains):
176         (WTR::TestController::clearLoadedThirdPartyDomains):
177         (WTR::TestController::getPrevalentDomains): Deleted.
178         (WTR::TestController::clearPrevalentDomains): Deleted.
179         * WebKitTestRunner/TestController.h:
180         * WebKitTestRunner/TestInvocation.cpp:
181         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
182         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
183         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
184         * WebKitTestRunner/TestInvocation.h:
185         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
186         (WTR::TestController::getLoadedThirdPartyDomains):
187         (WTR::TestController::clearLoadedThirdPartyDomains):
188         (WTR::TestController::getPrevalentDomains): Deleted.
189         (WTR::TestController::clearPrevalentDomains): Deleted.
190
191 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
192
193         [ews] run FindModifiedChangeLogs early in the build
194         https://bugs.webkit.org/show_bug.cgi?id=209060
195
196         Reviewed by Jonathan Bedard.
197
198         * BuildSlaveSupport/ews-build/factories.py:
199         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
200
201 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
202
203         [GTK] Add EWS testers to run GTK layout tests
204         https://bugs.webkit.org/show_bug.cgi?id=207648
205
206         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
207
208         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
209         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
210         tests (layout tests).
211
212         * BuildSlaveSupport/ews-build/config.json: Added new queue for
213         WK2 tests.
214         * BuildSlaveSupport/ews-build/factories.py:
215         (GTKTestsFactory):
216         * BuildSlaveSupport/ews-build/factories_unittest.py:
217         (TestCommitQueueFactory.test_commit_queue_factory):
218         (TestGTKFactory): Added unit-test.
219         (TestGTKFactory.test_gtk_factory):
220         * BuildSlaveSupport/ews-build/loadConfig.py:
221         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
222         (TagsForBuilderTest.test_getTagsForBuilder):
223
224 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
225
226         Add API endpoint in EWS django app to provide patch status in json format
227         https://bugs.webkit.org/show_bug.cgi?id=208940
228
229         Reviewed by Jonathan Bedard.
230
231         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
232         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
233
234 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
235
236         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
237         https://bugs.webkit.org/show_bug.cgi?id=209055
238         <rdar://problem/60272692>
239
240         Reviewed by Simon Fraser.
241
242         Now that WebKitTestRunner has a bundleID, its' user default values
243         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
244         to NO before running tests. It will be set to YES in PlatformWebView
245         if specified by the test.
246
247         * WebKitTestRunner/mac/main.mm:
248         (setDefaultsToConsistentValuesForTesting):
249
250 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
251
252         [CMake] Eleminate mismatches between Find* module names and variables they set
253         https://bugs.webkit.org/show_bug.cgi?id=208948
254
255         Reviewed by Michael Catanzaro.
256
257         * wpe/backends/CMakeLists.txt:
258
259 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
260
261         [ews-app] reduce logging
262         https://bugs.webkit.org/show_bug.cgi?id=209062
263
264         Reviewed by Jonathan Bedard.
265
266         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
267         (BugzillaBeautifulSoup.authenticate):
268         (BugzillaBeautifulSoup._load_query):
269
270 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
271
272         Crash in TextIterator::node via TextManipulationController::replace
273         https://bugs.webkit.org/show_bug.cgi?id=209048
274
275         Reviewed by Wenson Hsieh.
276
277         Added a regression test.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
280         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
281
282 2020-03-13  Saam Barati  <sbarati@apple.com>
283
284         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
285         https://bugs.webkit.org/show_bug.cgi?id=209038
286
287         Reviewed by Keith Miller.
288
289         This allows us to automatically pull in some tests that are in non open sourced Apple
290         checkouts.
291
292         * Scripts/run-javascriptcore-tests:
293         (runJSCStressTests):
294
295 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
296
297         Crash in TextManipulationController::replace
298         https://bugs.webkit.org/show_bug.cgi?id=209021
299
300         Reviewed by Wenson Hsieh.
301
302         Added a regression test.
303
304         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
305         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
306
307 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
308
309         [macOS] _AXSApplicationAccessibilityEnabled should not be called
310         https://bugs.webkit.org/show_bug.cgi?id=208953
311
312         Reviewed by Brent Fulgham.
313
314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
315
316 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
317
318         Resource load statistics data summary should return all third party data
319         https://bugs.webkit.org/show_bug.cgi?id=209000
320         <rdar://problem/60348306>
321
322         Reviewed by John Wilander.
323
324         Marked only 2 of 3 domains prevalent in data summary tests to ensure
325         the call returns all third parties, not just prevalent ones.
326         Added a more aggressive check for the size of the array at the
327         beginning of the test to ensure the array is still returning 3 values. 
328         Also removed the ASSERT statements as they seem to cause timeouts (not
329         clear crashes) when they are not true, which is hard to debug.
330         If these values are nil, the test will fail in the EXPECT_WK_STREQ
331         checks, we don't need ASSERT statements.
332
333         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
334         (TEST):
335
336 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
337
338         resultsdpy: Add script to run local instance
339         https://bugs.webkit.org/show_bug.cgi?id=208746
340
341         Rubber-stamped by Aakash Jain.
342
343         * resultsdbpy/resultsdbpy/example: Added.
344         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
345         * resultsdbpy/resultsdbpy/example/environment.py: Added.
346         (Environment): Organize environment variables used by results database.
347         (ModelFromEnvironment): Construct the database model from the environment.
348         (main): Create and drop tables, if required.
349         * resultsdbpy/resultsdbpy/example/main.py: Added.
350         (health): Web-server health check.
351         (handle_errors):
352         (main): Run results database web-server.
353         * resultsdbpy/resultsdbpy/example/worker.py: Added.
354         (main): Asynchronously process uploaded results.
355         * resultsdbpy/resultsdbpy/run: Added.
356
357 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
358
359         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
360         https://bugs.webkit.org/show_bug.cgi?id=209004
361
362         Reviewed by Tim Horton.
363
364         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
365         `use_gpu_process` is specified.
366
367         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
368         (parse_args):
369
370 2020-03-12  Matt Lewis  <jlewis3@apple.com>
371
372         Make flatpack import for run-webkit-tests only happen on linux systems
373         https://bugs.webkit.org/show_bug.cgi?id=208954
374
375         Reviewed by Philippe Normand.
376
377         * Scripts/run-webkit-tests: Added an if statement to find the system platform
378         to determine if we need the flatpackutils import. 
379
380 2020-03-12  Alex Christensen  <achristensen@webkit.org>
381
382         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
383         https://bugs.webkit.org/show_bug.cgi?id=207609
384
385         Reviewed by Ryosuke Niwa.
386
387         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
388         (TestWebKitAPI::TEST):
389
390 2020-03-12  Daniel Bates  <dabates@apple.com>
391
392         FocusController::setFocusedElement() should tell client of refocused element
393         https://bugs.webkit.org/show_bug.cgi?id=208880
394
395         Reviewed by Wenson Hsieh.
396
397         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
398         to start an input session. Currently, it does not even try.
399
400         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
401         (TEST):
402
403 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
404
405         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
406         https://bugs.webkit.org/show_bug.cgi?id=208970
407
408         Reviewed by Daniel Bates.
409
410         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
411         #!/usr/bin/env python.
412
413         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
414         probably has similar rules.
415
416         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
417         Everything else that does so is probably only used by webkit-build.
418
419         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
420
421         * gtkdoc/generate-gtkdoc:
422
423 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
424
425         [WebAuthn] Formalize the Keychain schema
426         https://bugs.webkit.org/show_bug.cgi?id=183533
427         <rdar://problem/43347926>
428
429         Reviewed by Brent Fulgham.
430
431         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
432         the original combination of RP ID and user handle.
433
434         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
435         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
436         (WTR::TestRunner::cleanUpKeychain):
437         (WTR::TestRunner::keyExistsInKeychain):
438         * WebKitTestRunner/InjectedBundle/TestRunner.h:
439         * WebKitTestRunner/TestController.h:
440         * WebKitTestRunner/TestInvocation.cpp:
441         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
442         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
443         (WTR::TestController::cleanUpKeychain):
444         (WTR::TestController::keyExistsInKeychain):
445
446 2020-03-11  Keith Miller  <keith_miller@apple.com>
447
448         Test262-runner should always consider crashes as new failures
449         https://bugs.webkit.org/show_bug.cgi?id=208943
450
451         Reviewed by Yusuke Suzuki.
452
453         Right now the runner will consider crashes with no output as passes, which is obviously bad.
454         Since we should never crash on a conformance test we should consider a crash as a new failure
455         100% of the time.
456
457         * Scripts/test262/Runner.pm:
458         (processFile):
459         (runTest):
460         (processResult):
461
462 2020-03-11  Chris Dumez  <cdumez@apple.com>
463
464         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
465         https://bugs.webkit.org/show_bug.cgi?id=208927
466         <rdar://problem/55448331>
467
468         Reviewed by Alex Christensen.
469
470         Add API test coverage.
471
472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
473
474 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
475
476         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
477         https://bugs.webkit.org/show_bug.cgi?id=208860
478
479         Reviewed by Carlos Alberto Lopez Perez.
480
481         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
482         (StatusBubble): Added 'api-gtk'.
483         * BuildSlaveSupport/ews-build/config.json:
484         * BuildSlaveSupport/ews-build/factories.py:
485         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
486         GTK.
487         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
488         GTK.
489         (GTKBuildFactory):
490         (GTKBuildFactory.__init__): Deleted.
491         (GTKBuildAndTestFactory): Deleted.
492         (GTKBuildAndTestFactory.__init__): Deleted.
493         (GTKAPIBuildAndTestFactory): Deleted.
494         * BuildSlaveSupport/ews-build/loadConfig.py:
495
496 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
497
498         [ews] Add unit test to prevent multiple schedulers for a builder.
499         https://bugs.webkit.org/show_bug.cgi?id=208917
500
501         Reviewed by Carlos Alberto Lopez Perez.
502
503         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
504         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
505         (TagsForBuilderTest): Fixed a typo.
506
507 2020-03-11 Philippe Normand  <pnormand@igalia.com>
508
509         [GTK] Failing API tests under the Flatpak SDK environment
510         https://bugs.webkit.org/show_bug.cgi?id=208871
511
512         Reviewed by Michael Catanzaro.
513
514         The load-failed signal callback should return a boolean result,
515         otherwise we enter in unknown territory depending on how the
516         toolchain compiles this, possibly triggering bad behavior (with
517         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
518         GCC toolchain on buildbots).
519
520         Patch suggested by Michael Catanzaro.
521
522         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
523         (loadFailedCallback):
524
525 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
526
527         Sync FeatureList.pm with CMake definitions
528         https://bugs.webkit.org/show_bug.cgi?id=208866
529
530         Reviewed by Michael Catanzaro.
531
532         * Scripts/webkitperl/FeatureList.pm:
533
534 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
535
536         [ews] Add unit tests for commit queue factory
537         https://bugs.webkit.org/show_bug.cgi?id=208862
538
539         Reviewed by Jonathan Bedard.
540
541         * BuildSlaveSupport/ews-build/factories_unittest.py:
542         (TestCommitQueueFactory):
543         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
544
545 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews-app] Status bubble should only display important messages in pop-over - part 3
548         https://bugs.webkit.org/show_bug.cgi?id=208865
549
550         Reviewed by Jonathan Bedard.
551
552         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
553         (StatusBubble): Added more strings to STEPS_TO_HIDE.
554
555 2020-03-10  Lauro Moura  <lmoura@igalia.com>
556
557         [WPE] MiniBrowser: Close child WebViews when exiting
558         https://bugs.webkit.org/show_bug.cgi?id=208689
559
560         Reviewed by Carlos Garcia Campos.
561
562         Store created views so we can release them before exiting.
563
564         * MiniBrowser/wpe/main.cpp:
565         (webViewClose):
566         (createWebView):
567         (main):
568
569 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
570
571         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
572         https://bugs.webkit.org/show_bug.cgi?id=208861
573
574         Reviewed by Jonathan Bedard.
575
576         * BuildSlaveSupport/ews-build/factories.py:
577         (Factory.__init__): Remove verifycqplus parameter.
578         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
579         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
580         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
581
582 2020-03-10  Philippe Normand  <pnormand@igalia.com>
583
584         [GTK] API favicon test flaky timeouts
585         https://bugs.webkit.org/show_bug.cgi?id=208189
586
587         Reviewed by Carlos Garcia Campos.
588
589         Sometimes the favicon changes already during the load. Keeping
590         track of it in the WebView favicon property notification handler
591         gets us rid of the race.
592
593         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
594         (testFaviconDatabaseGetFavicon):
595
596 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
597
598         Generate commit-queue status bubble from new EWS
599         https://bugs.webkit.org/show_bug.cgi?id=208811
600
601         Reviewed by Jonathan Bedard.
602
603         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
604         (StatusBubble._build_bubbles_for_patch):
605
606 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
607
608         Remove obsolete feature flags
609         https://bugs.webkit.org/show_bug.cgi?id=208830
610
611         Reviewed by Alex Christensen.
612
613         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
614         are no longer used.
615
616         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
617         when the compilation flag was removed in r258148.
618
619         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
620         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
621
622         * Scripts/webkitperl/FeatureList.pm:
623         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
624
625 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
626
627         WebKitTestRunner bundleID should not be cleared before every test
628         https://bugs.webkit.org/show_bug.cgi?id=208823
629         <rdar://problem/60204539>
630
631         Reviewed by Per Arne Vollan.
632
633         This is causing test failures for layout tests which rely on the Info.plist 
634         bundle identifier (not the one set via the override method).
635
636         * WebKitTestRunner/TestController.cpp:
637         (WTR::TestController::createWebViewWithOptions):
638         (WTR::TestController::ensureViewSupportsOptionsForTest):
639         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
640
641 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
642
643         [macOS] Notification observer is not removed
644         https://bugs.webkit.org/show_bug.cgi?id=208834
645
646         Reviewed by Tim Horton.
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
650         (TEST):
651
652 2020-03-06  Brian Burg  <bburg@apple.com>
653
654         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
655         https://bugs.webkit.org/show_bug.cgi?id=208729
656         <rdar://problem/60105447>
657
658         Reviewed by Jonathan Bedard.
659
660         Improve upload.py to look for the svn branch and revision for the 'webkit'
661         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
662
663         * Scripts/webkitpy/common/checkout/scm/git.py:
664         (Git):
665         (Git.git_svn_id_regexp):
666         (Git._field_from_git_svn_id):
667         (Git.svn_revision):
668         (Git.svn_branch):
669         (Git.svn_url):
670         (Git.native_branch):
671         Refactor svn revision, branch, url to use the same regexp and helper code.
672
673         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
674         (StubRepository.svn_branch):
675         Expose a stub since this is used unconditionally by Port.commits_for_upload.
676
677         * Scripts/webkitpy/common/checkout/scm/svn.py:
678         (SVN.svn_branch):
679         (SVN.native_revision):
680         (SVN):
681         (SVN.native_branch):
682         Refactor so the actual implementation is contained in svn_revision / svn_branch.
683         The native_* methods call out to the SVN equivalents since this is an SVN repository.
684
685         * Scripts/webkitpy/port/base.py:
686         (Port.commits_for_upload):
687         Add special git-svn handling for the WebKit repository so that SVN branch and revision
688         is preferred over the git equivalents.
689
690 2020-03-09  Antoine Quint  <graouts@apple.com>
691
692         TestWebKitAPI fails to build on watchOS
693         https://bugs.webkit.org/show_bug.cgi?id=208820
694
695         Reviewed by Tim Horton.
696
697         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
698
699 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
700
701         resultsdbpy: Add tool to manage resultsdbpy container
702         https://bugs.webkit.org/show_bug.cgi?id=208743
703
704         Rubber-stamped by Aakash Jain.
705
706         Add tool to start, stop and restart the resultsdbpy Docker container.
707
708         * resultsdbpy/resultsdbpy/container: Added.
709
710 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
711
712         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
713         https://bugs.webkit.org/show_bug.cgi?id=208706
714
715         Reviewed by Žan Doberšek.
716
717         Add test case to check surrounding text in multiline context.
718
719         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
720         (testWebKitInputMethodContextSurrounding):
721
722 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
723
724         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
725         https://bugs.webkit.org/show_bug.cgi?id=208783
726
727         Reviewed by Brent Fulgham.
728
729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
730
731 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
732
733         Replace the use of term "rollout" to "revert" in various tools
734         https://bugs.webkit.org/show_bug.cgi?id=208775
735
736         Reviewed by Ryosuke Niwa.
737
738         See this webkit-dev thread for the originating discussion:
739         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
740
741         'rollout' is a confusing term to anyone unacquainted with WebKit;
742         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
743
744         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
745         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
746
747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
755         * BuildSlaveSupport/ews-build/steps.py:
756         * BuildSlaveSupport/ews-build/steps_unittest.py:
757         * Scripts/webkit-tools-completion.sh:
758         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
759         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
760         * Scripts/webkitpy/common/checkout/scm/svn.py:
761         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
762         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
763         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
764         * Scripts/webkitpy/tool/bot/feeders.py:
765         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
766         * Scripts/webkitpy/tool/bot/irc_command.py:
767         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
768         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
769         * Scripts/webkitpy/tool/bot/sheriff.py:
770         * Scripts/webkitpy/tool/commands/download.py:
771         * Scripts/webkitpy/tool/commands/download_unittest.py:
772         * Scripts/webkitpy/tool/commands/newcommitbot.py:
773         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
774         * Scripts/webkitpy/tool/commands/queues_unittest.py:
775         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
776         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
777         * Scripts/webkitpy/tool/steps/__init__.py:
778         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
779         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
780         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
781         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
782
783 2020-03-07  David Quesada  <david_quesada@apple.com>
784
785         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
786         https://bugs.webkit.org/show_bug.cgi?id=208781
787         rdar://problem/60061016
788
789         Reviewed by Alex Christensen.
790
791         Add a test that recreates the conditions of this crash:
792         - Send a message from the injected bundle to the UI process that contains a reply block.
793         - Hold a reference to the reply block.
794         - Let the web view deallocate.
795         - Call the block, and expect not to crash.
796
797         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
798         (localObjectInterface):
799         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
800         (-[LocalObject doSomethingWithCompletionHandler:]):
801         (TEST):
802         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
803         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
804
805 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
806
807         TextManipulationController should work with ARIA labels
808         https://bugs.webkit.org/show_bug.cgi?id=208759
809
810         Reviewed by Wenson Hsieh.
811
812         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
813         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
814         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
815         the expected number of tokens for the first item as the very first image is correctly
816         detected per the code change. 
817         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
818
819 2020-03-07  Alex Christensen  <achristensen@webkit.org>
820
821         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
822         https://bugs.webkit.org/show_bug.cgi?id=208767
823
824         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
825         The frameID of the main frame before loading is only 0 on Mac right now.
826         The test is still good because it validates that execution works in the main frame before loading.
827
828 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
829
830         [ews] commit queue is not skipping layout tests for rollout patches
831         https://bugs.webkit.org/show_bug.cgi?id=208716
832
833         Unreviewed minor fix.
834
835         * BuildSlaveSupport/ews-build/steps.py:
836         (RunWebKitTests.doStepIf):
837         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
838         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
839
840 2020-03-05  Sam Weinig  <weinig@apple.com>
841
842         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
843         https://bugs.webkit.org/show_bug.cgi?id=207436
844         <rdar://problem/59296762>
845
846         Reviewed by Darin Adler.
847
848         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
849         Remove JSC related defines.
850
851 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
852
853         AX: Provide a way to run tests in isolated tree mode
854         https://bugs.webkit.org/show_bug.cgi?id=208629
855         <rdar://problem/60075583>
856
857         Reviewed by Ryosuke Niwa.
858
859         Provide the ability to run tests for accessibility in the isolated tree mode.
860         This sends a flag over to the injected bundle which calls the right HIServices override so that
861         the system thinks it is in isolated mode.
862
863         * Scripts/compare-webkit-configurations:
864         (flag_for_comparison):
865         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
866         (parse_args):
867         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
868         (parse_args):
869         * Scripts/webkitpy/port/driver.py:
870         (Driver.cmd_line):
871         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
872         (WTR::AccessibilityController::AccessibilityController):
873         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
874         (WTR::AccessibilityController::updateIsolatedTreeMode):
875         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
876         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
878         (WTR::InjectedBundle::didReceiveMessageToPage):
879         (WTR::InjectedBundle::beginTesting):
880         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
881         * WebKitTestRunner/Options.cpp:
882         (WTR::handleOptionAccessibilityIsolatedTreeMode):
883         (WTR::OptionsHandler::OptionsHandler):
884         * WebKitTestRunner/Options.h:
885         * WebKitTestRunner/TestController.cpp:
886         (WTR::TestController::initialize):
887         (WTR::TestController::resetPreferencesToConsistentValues):
888         (WTR::TestController::resetStateToConsistentValues):
889         * WebKitTestRunner/TestController.h:
890         (WTR::TestController::accessibilityIsolatedTreeMode const):
891
892 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
893
894         [Cocoa] Re-enable CFPrefs direct mode
895         https://bugs.webkit.org/show_bug.cgi?id=208690
896
897         Reviewed by Brent Fulgham.
898
899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
900         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
901         (TEST):
902         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
903         (TestWebKitAPI::TEST):
904
905 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
906
907         UIProcess needs mechanism to specify AppBound domains
908         https://bugs.webkit.org/show_bug.cgi?id=208528
909         <rdar://problem/59980340>
910
911         Reviewed by Brent Fulgham.
912
913         Added test app-bound domains to the plist and tested that the domains
914         are properly stored in the website data store after a navigation.
915
916         * TestWebKitAPI/Info.plist:
917         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
918         (TEST):
919
920 2020-03-06  Alex Christensen  <achristensen@webkit.org>
921
922         Add SPI to disable cross origin access control checks
923         https://bugs.webkit.org/show_bug.cgi?id=208748
924
925         Reviewed by Tim Hatcher.
926
927         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
928         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
929
930 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
931
932         [webkitpy] Fix executive on Windows to run wpt server correctly
933         https://bugs.webkit.org/show_bug.cgi?id=208693
934
935         Reviewed by Jonathan Bedard.
936
937         Bug fix for Windows environment a) fixing a typo. b) fixing path
938         c) fix how to kill subprocesses.
939
940         * Scripts/webkitpy/common/system/executive.py:
941         (Executive._windows_kill_command):
942         (Executive.interrupt):
943         (Executive.kill_all):
944         * Scripts/webkitpy/port/base.py:
945         (Port.web_platform_test_server_doc_root):
946
947 2020-03-06  Alex Christensen  <achristensen@webkit.org>
948
949         Evaluating JavaScript in main frame before loading should succeed
950         https://bugs.webkit.org/show_bug.cgi?id=208733
951
952         Reviewed by Tim Horton.
953
954         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
955
956 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
957
958         TextManipulationController should preserve images
959         https://bugs.webkit.org/show_bug.cgi?id=208692
960
961         Reviewed by Wenson Hsieh.
962
963         Added tests for preserving images and their ordering.
964
965         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
966         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
967         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
968         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
969
970 2020-03-06  David Quesada  <david_quesada@apple.com>
971
972         Add _WKResourceLoadInfo.resourceType SPI
973         https://bugs.webkit.org/show_bug.cgi?id=208723
974
975         Reviewed by Alex Christensen.
976
977         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
978         (TEST):
979
980 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
981
982         Stop reporting to webkit-test-results.webkit.org
983         https://bugs.webkit.org/show_bug.cgi?id=207218
984
985         Reviewed by Alexey Proskuryakov.
986
987         * BuildSlaveSupport/build.webkit.org-config/steps.py:
988         (RunWebKitTests):
989
990 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
991
992         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
993         https://bugs.webkit.org/show_bug.cgi?id=208365
994         <rdar://problem/59877296>
995
996         Reviewed by Geoffrey Garen.
997
998         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
999         (TEST):
1000
1001 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1002
1003         EWS should be able to fetch patch status for security bugs while processing them
1004         https://bugs.webkit.org/show_bug.cgi?id=206511
1005
1006         Reviewed by Alexey Proskuryakov.
1007
1008         * BuildSlaveSupport/ews-build/steps.py:
1009         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
1010         (BugzillaMixin.get_patch_json): 
1011         (BugzillaMixin.get_bug_json):
1012         (BugzillaMixin._is_bug_closed):
1013         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
1014         (TransferToS3.hideStepIf): Ditto.
1015
1016 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1017
1018         [ews] commit-queue should show the trac url for the commit on the build page
1019         https://bugs.webkit.org/show_bug.cgi?id=208715
1020
1021         Reviewed by Jonathan Bedard.
1022
1023         * BuildSlaveSupport/ews-build/steps.py:
1024         (PushCommitToWebKitRepo.evaluateCommand):
1025
1026 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1027
1028         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1029         https://bugs.webkit.org/show_bug.cgi?id=208550
1030
1031         * TestWebKitAPI/cocoa/HTTPServer.mm:
1032         (TestWebKitAPI::HTTPServer::respondToRequests):
1033         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1034         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1035
1036 2020-03-06  Lauro Moura <lmoura@igalia.com>
1037
1038         [WPE][WebDriver] MiniBrowser should react to close session commands
1039         https://bugs.webkit.org/show_bug.cgi?id=207529
1040
1041         Reviewed by Carlos Garcia Campos.
1042
1043         Do not call g_object_unref on the first created view if it has already
1044         been disposed in the "close" signal handler.
1045
1046         Based on original patch by Yury Semikhatsky.
1047
1048         * MiniBrowser/wpe/main.cpp:
1049         (main):
1050
1051 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1052
1053         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1054         https://bugs.webkit.org/show_bug.cgi?id=208647
1055
1056         Reviewed by Carlos Garcia Campos.
1057
1058         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1059         (TestWebKitAPI::TEST):
1060
1061 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1062
1063         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1064         https://bugs.webkit.org/show_bug.cgi?id=208670
1065
1066         Reviewed by Brady Eidson.
1067
1068         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1069         (-[FrameNavigationDelegate waitForNavigations:]):
1070         (-[FrameNavigationDelegate requests]):
1071         (-[FrameNavigationDelegate frames]):
1072         (-[FrameNavigationDelegate callbacks]):
1073         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1074         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1075         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1076         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1077         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1078         (TEST):
1079
1080 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1081
1082         Add WKFrameInfo._parentFrameHandle SPI
1083         https://bugs.webkit.org/show_bug.cgi?id=208674
1084
1085         Reviewed by Brady Eidson.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1088
1089 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1090
1091         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1092         https://bugs.webkit.org/show_bug.cgi?id=208626
1093         <rdar://problem/60074148>
1094
1095         Reviewed by Brent Fulgham.
1096
1097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1098         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1099         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1100         (TestWebKitAPI::TEST):
1101         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1102         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1103         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1104
1105 2020-03-05  Antoine Quint  <graouts@apple.com>
1106
1107         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1108         https://bugs.webkit.org/show_bug.cgi?id=208644
1109         <rdar://problem/60042429>
1110
1111         Reviewed by Brady Eidson.
1112
1113         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1114         
1115         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1116            empty document has been removed in favor of the document for the requested URL,
1117         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1118            correctly does not injected the style sheet.
1119
1120         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1121
1122 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1123
1124         [ews] Add build step to push commit to WebKit repository
1125         https://bugs.webkit.org/show_bug.cgi?id=208589
1126
1127         Reviewed by Jonathan Bedard.
1128
1129         * BuildSlaveSupport/ews-build/steps.py:
1130         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1131         (PushCommitToWebKitRepo.start): Initialize log observer.
1132         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1133         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1134         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1135         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1136         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1137         * BuildSlaveSupport/ews-build/factories.py:
1138
1139 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1140
1141         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1142         https://bugs.webkit.org/show_bug.cgi?id=208262
1143
1144         Reviewed by Jonathan Bedard.
1145
1146         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1147
1148 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1149
1150         commit-queue should run WK2 tests instead of WK1 tests
1151         https://bugs.webkit.org/show_bug.cgi?id=208544
1152
1153         Reviewed by Jonathan Bedard.
1154
1155         * BuildSlaveSupport/ews-build/factories.py:
1156
1157 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1158
1159         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
1160         https://bugs.webkit.org/show_bug.cgi?id=208645
1161
1162         Reviewed by Alexey Proskuryakov.
1163
1164         * BuildSlaveSupport/ews-build/steps.py:
1165         (ValidateCommiterAndReviewer.load_contributors):
1166         (ValidateCommiterAndReviewer.start):
1167
1168 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1169
1170         style-checker: Add UAF to the list of security words to warn about.
1171         https://bugs.webkit.org/show_bug.cgi?id=208643
1172
1173         Reviewed by Jonathan Bedard.
1174
1175         UAF is a common acronym used for use after free.
1176
1177         * Scripts/webkitpy/style/checkers/changelog.py:
1178         (ChangeLogChecker.check_for_unwanted_security_phrases):
1179
1180 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
1181
1182         [MSVC] Add .natvis support of WebKit types
1183         https://bugs.webkit.org/show_bug.cgi?id=193119
1184
1185         Reviewed by Don Olmstead.
1186
1187         To help the WebKit developer while debugging, this file defines how
1188         WebKit types are displayed in debugger of Visual Studio.
1189         Very limited set of WebKit types, but it changes the world.
1190
1191         * VisualStudio/WebKit.natvis: Added.
1192
1193 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1194
1195         Add system trace points around display list replay
1196         https://bugs.webkit.org/show_bug.cgi?id=208616
1197
1198         Reviewed by Simon Fraser.
1199
1200         Add a new "Display list replay" trace point.
1201
1202         * Tracing/SystemTracePoints.plist:
1203
1204 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1205
1206         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
1207         https://bugs.webkit.org/show_bug.cgi?id=208615
1208         <rdar://problem/59406743>
1209
1210         Reviewed by Alex Christensen.
1211
1212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1213         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
1214         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1215         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1216         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1217         (TEST):
1218         Also make a test written in bug 206310 actually run code.
1219
1220 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1221
1222         [build.webkit.org] Remove leaks queue
1223         https://bugs.webkit.org/show_bug.cgi?id=208580
1224
1225         Reviewed by Jonathan Bedard.
1226
1227         * BuildSlaveSupport/build.webkit.org-config/config.json:
1228         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1230
1231 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1232
1233         Add SPI to evaluate JavaScript in an iframe
1234         https://bugs.webkit.org/show_bug.cgi?id=208605
1235
1236         Reviewed by Brady Eidson.
1237
1238         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1239
1240 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
1241
1242         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
1243         https://bugs.webkit.org/show_bug.cgi?id=208533
1244         <rdar://problem/60010184>
1245
1246         Reviewed by Alex Christensen.
1247
1248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1249         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1250         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
1251         (TestWebKitAPI::TEST):
1252         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
1253         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
1254
1255 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1256
1257         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
1258         https://bugs.webkit.org/show_bug.cgi?id=208593
1259
1260         Reviewed by Brady Eidson.
1261
1262         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1263         (TestWebKitAPI::TEST):
1264
1265 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1266
1267         WKWebView's frames accessor should return a traversable type
1268         https://bugs.webkit.org/show_bug.cgi?id=208591
1269
1270         Reviewed by Brady Eidson.
1271
1272         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1273
1274 2020-03-04  Antoine Quint  <graouts@apple.com>
1275
1276         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
1277         https://bugs.webkit.org/show_bug.cgi?id=208575
1278         <rdar://problem/59773690>
1279
1280         Reviewed by Brady Eidson.
1281
1282         Add new tests for the new SPI which check:
1283         
1284         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
1285            specified WKWebView alone,
1286         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
1287         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
1288         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
1289         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
1290         6. and that the same test also works with PSON enabled.
1291
1292         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1293
1294 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
1295
1296         [macOS] test-lldb-webkit failing on debug bots
1297         https://bugs.webkit.org/show_bug.cgi?id=208545
1298
1299         Reviewed by Jonathan Bedard.
1300
1301         The lldb-webkit-test step must pass in the build configuration as an
1302         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
1303         binary that is downloaded with the rest of the build products. Without this
1304         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
1305         regardless of their actual build configuration.
1306
1307         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1308         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
1309         * Scripts/test-lldb-webkit:
1310         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
1311
1312 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1313
1314         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
1315         https://bugs.webkit.org/show_bug.cgi?id=208539
1316
1317         Unreviewed follow-up fix.
1318
1319         * BuildSlaveSupport/ews-build/steps.py:
1320
1321 2020-03-04  Daniel Bates  <dabates@apple.com>
1322
1323         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
1324         https://bugs.webkit.org/show_bug.cgi?id=208565
1325
1326         Reviewed by Wenson Hsieh.
1327
1328         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
1329         of its frame as a means to find all the editable elements in the visible content area
1330         of the web view.
1331
1332         Coincidentally this makes no difference to the test results right now because the web view
1333         happens to be located at the origin (0, 0) in the window. However if in the future the
1334         web view would be located at some other point then the tests may fail because the rectangle
1335         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
1336         rectangle for the visible content area.
1337
1338         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1339         (TEST):
1340
1341 2020-03-04  Daniel Bates  <dabates@apple.com>
1342
1343         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
1344         https://bugs.webkit.org/show_bug.cgi?id=208564
1345
1346         Reviewed by Alex Christensen.
1347
1348         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
1349         to make it easy to run just these tests.
1350
1351         Currently, the tests are organized under the test case name WebKit. This means you need to
1352         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
1353         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
1354         so that a person can run just these test using:
1355         
1356                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
1357
1358         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1359         (TEST):
1360
1361 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1362
1363         [ews] Add build step to create local git commit for commit-queue
1364         https://bugs.webkit.org/show_bug.cgi?id=208539
1365
1366         Reviewed by Jonathan Bedard.
1367
1368         * BuildSlaveSupport/ews-build/steps.py:
1369         (CreateLocalGITCommit): Build step to create local git commit.
1370         (CreateLocalGITCommit.start):
1371         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
1372         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
1373         * BuildSlaveSupport/ews-build/factories.py:
1374
1375 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
1376
1377         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
1378         https://bugs.webkit.org/show_bug.cgi?id=207948
1379
1380         Reviewed by Zalan Bujtas.
1381
1382         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
1383         so that it receives the wheel events.
1384
1385         * DumpRenderTree/mac/EventSendingController.mm:
1386         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1387         * DumpRenderTree/win/EventSender.cpp:
1388         (mouseScrollBy):
1389
1390 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
1391
1392         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
1393         https://bugs.webkit.org/show_bug.cgi?id=208520
1394         <rdar://problem/60000214>
1395
1396         Reviewed by Chris Fleizach.
1397
1398         Calling InjectedBundle::singleton().page()->page() in the constructor
1399         of the AccessibilityController is having this side effect on iOS.
1400         So #if to MAC where it's actually being used.
1401
1402         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1403         (WTR::AccessibilityController::AccessibilityController):
1404
1405 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1406
1407         Add SPI _WKResourceLoadInfo.loadedFromCache
1408         https://bugs.webkit.org/show_bug.cgi?id=208554
1409
1410         Reviewed by Wenson Hsieh.
1411
1412         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1413         (TEST):
1414
1415 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1416
1417         Batch observations and completions of text manipulations
1418         https://bugs.webkit.org/show_bug.cgi?id=208406
1419
1420         Reviewed by Wenson Hsieh.
1421
1422         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
1423         multiple paragraphs at once.
1424
1425         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1426         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
1427         (-[TextManipulationDelegate items]):
1428         (-[LegacyTextManipulationDelegate init]):
1429         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
1430         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
1431         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
1432         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
1433         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
1434         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
1435         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
1436
1437 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
1438
1439         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1440         https://bugs.webkit.org/show_bug.cgi?id=208415
1441
1442         Reviewed by Brent Fulgham.
1443
1444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1445         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1446         (TEST):
1447
1448 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1449
1450         Add response to _WKResourceLoadDelegate didCompleteWithError callback
1451         https://bugs.webkit.org/show_bug.cgi?id=208553
1452
1453         Reviewed by Simon Fraser.
1454
1455         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1456         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
1457         (TEST):
1458         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
1459
1460 2020-03-03  Brady Eidson  <beidson@apple.com>
1461
1462         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
1463         https://bugs.webkit.org/show_bug.cgi?id=198795
1464
1465         Reviewed by Chris Dumez.
1466
1467         This test appears to no longer be flaky.
1468         
1469         Let's re-enable it.
1470         
1471         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1472         (TestWebKitAPI::TEST):
1473
1474 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1475
1476         Requests sent to _WKResourceLoadDelegate should include HTTPBody
1477         https://bugs.webkit.org/show_bug.cgi?id=208550
1478
1479         Reviewed by Tim Hatcher.
1480
1481         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1482         (TEST):
1483         * TestWebKitAPI/cocoa/HTTPServer.mm:
1484         (TestWebKitAPI::HTTPServer::respondToRequests):
1485         HTTPServer now looks for Content-Length in its request.
1486         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
1487
1488 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1489
1490         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
1491         https://bugs.webkit.org/show_bug.cgi?id=208522
1492
1493         Reviewed by Brian Weinstein.
1494
1495         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1496         (TEST):
1497
1498 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1499
1500         commit-queue should update working directory and reapply patch just before commiting
1501         https://bugs.webkit.org/show_bug.cgi?id=208521
1502
1503         Reviewed by Jonathan Bedard.
1504
1505         * BuildSlaveSupport/ews-build/factories.py:
1506
1507 2020-03-03  Matt Lewis  <jlewis3@apple.com>
1508
1509         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
1510         https://bugs.webkit.org/show_bug.cgi?id=208485
1511
1512         Reviewed by Jonathan Bedard.
1513
1514         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1515         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
1516         that we don't have to recreate the variables that are already created.
1517         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
1518         from each module, rather than making extra imports that we don't need.
1519         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
1520         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
1521         and not part of the host.
1522         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
1523         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
1524         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
1525         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
1526         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
1527         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
1528         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
1529         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
1530         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
1531         if we were geting any value at all
1532         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
1533         sure we aren't gabking the wrong key:value pair
1534         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
1535         come with the MockHosts and MockHost inherits from MockSystemHost.
1536         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
1537         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
1538         to the various upload steps.
1539
1540 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1541
1542         [ews] Add build step to find list of modified changelogs
1543         https://bugs.webkit.org/show_bug.cgi?id=208514
1544
1545         Reviewed by Jonathan Bedard.
1546
1547         * BuildSlaveSupport/ews-build/factories.py:
1548         * BuildSlaveSupport/ews-build/steps.py:
1549         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
1550         (FindModifiedChangeLogs.start): Initialize log observer.
1551         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
1552         (FindModifiedChangeLogs.evaluateCommand):
1553         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
1554         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
1555         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
1556         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1557
1558 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
1559
1560         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
1561         https://bugs.webkit.org/show_bug.cgi?id=208451
1562
1563         Unreviewed test gardening.
1564
1565         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
1566
1567 2020-03-03  Jiten Mehta  <jmehta@apple.com>
1568
1569         Adopt HTTP Alternative Services Storage
1570         https://bugs.webkit.org/show_bug.cgi?id=208387
1571
1572         Reviewed by Alex Christensen.
1573
1574         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1575         (checkUntilEntryFound):
1576         (TEST):
1577
1578 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
1579
1580         Check for navigation to app-bound domain during script evaluation
1581         https://bugs.webkit.org/show_bug.cgi?id=208319
1582         <rdar://problem/57569321>
1583
1584         Reviewed by Brent Fulgham.
1585
1586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1587         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
1588         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1589         (TEST):
1590         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
1591         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
1592
1593 2020-03-03  Commit Queue  <commit-queue@webkit.org>
1594
1595         Unreviewed, rolling out r257754.
1596         https://bugs.webkit.org/show_bug.cgi?id=208513
1597
1598         Introduced API test failure (Requested by perarne on #webkit).
1599
1600         Reverted changeset:
1601
1602         "[Cocoa] Mapping from MIME type to UTI type should be done in
1603         the UI process"
1604         https://bugs.webkit.org/show_bug.cgi?id=208415
1605         https://trac.webkit.org/changeset/257754
1606
1607 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
1608
1609         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
1610         https://bugs.webkit.org/show_bug.cgi?id=208506
1611
1612         Reviewed by Carlos Garcia Campos.
1613
1614         * WebKitTestRunner/TestController.cpp:
1615         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
1616
1617 2020-03-02  Ben Nham  <nham@apple.com>
1618
1619         Add performance probes for HTML parsing
1620         https://bugs.webkit.org/show_bug.cgi?id=208271
1621
1622         Reviewed by Daniel Bates.
1623
1624         This adds probes that show which lines of HTML are have been parsed.
1625
1626         * Tracing/SystemTracePoints.plist:
1627
1628 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1629
1630         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1631         https://bugs.webkit.org/show_bug.cgi?id=208415
1632
1633         Reviewed by Brent Fulgham.
1634
1635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1636         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1637         (TEST):
1638
1639 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1640
1641         Unreviewed, rolling out r257725.
1642
1643         This commit caused 10 API tests to fail
1644
1645         Reverted changeset:
1646
1647         "[Cocoa] Mapping from MIME type to UTI type should be done in
1648         the UI process"
1649         https://bugs.webkit.org/show_bug.cgi?id=208415
1650         https://trac.webkit.org/changeset/257725
1651
1652 2020-03-02  Saam Barati  <sbarati@apple.com>
1653
1654         Don't skip tests unnecessarily on arm64
1655         https://bugs.webkit.org/show_bug.cgi?id=208470
1656         <rdar://problem/59968869>
1657
1658         Reviewed by Tadeu Zagallo.
1659
1660         * Scripts/run-jsc-stress-tests:
1661
1662 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
1663
1664         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
1665         https://bugs.webkit.org/show_bug.cgi?id=208434
1666
1667         Reviewed by Chris Fleizach.
1668
1669         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1670         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
1671         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
1672         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1673         (WTR::AccessibilityController::accessibleElementById): Same as above.
1674
1675 2020-03-02  John Wilander  <wilander@apple.com>
1676
1677         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
1678         https://bugs.webkit.org/show_bug.cgi?id=208399
1679         <rdar://problem/24731650>
1680
1681         Reviewed by Brent Fulgham.
1682
1683         The majority of the changes in WTR::TestController is (partially) fixing a bug
1684         where the TestRunner would statically use the default website datastore instead
1685         of the website data store configure for the page. This worked for persistent
1686         storage testing but not for ephemeral sessions which is what this patch is all
1687         about. The previous TestController::websiteDataStore() is now called
1688         TestController::defaultWebsiteDataStore() and the new
1689         TestController::websiteDataStore() returns the configured website data store.
1690         Most of the use of the default website data store should probably change but
1691         that's not really for this patch to deal with. I did however move all of
1692         resource load statistics' use to the new TestController::websiteDataStore().
1693
1694         A new TestRunner function was added: isStatisticsEphemeral()
1695         It allows test cases to query the ephemeral status of resource load statistics.
1696
1697         One problem that is mitigated in this patch but not fully fixed is that for
1698         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
1699         TestController::generatePageConfiguration() via C API 
1700         WKPageConfigurationSetWebsiteDataStore(), and then again in 
1701         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
1702         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
1703         I tried removing the latter since one session for all platforms should be
1704         Enough but got broken behavior as a result. So now both are still there
1705         and both enable resource load statistics.
1706
1707         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1708         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1709         (WTR::TestRunner::isStatisticsEphemeral):
1710         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1711         * WebKitTestRunner/TestController.cpp:
1712         (WTR::TestController::defaultWebsiteDataStore):
1713         (WTR::TestController::websiteDataStore):
1714         (WTR::TestController::generatePageConfiguration):
1715         (WTR::TestController::resetPreferencesToConsistentValues):
1716         (WTR::TestController::resetStateToConsistentValues):
1717         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1718         (WTR::TestController::decidePolicyForNavigationAction):
1719         (WTR::TestController::platformAdjustContext):
1720         (WTR::TestController::clearServiceWorkerRegistrations):
1721         (WTR::TestController::clearDOMCache):
1722         (WTR::TestController::clearDOMCaches):
1723         (WTR::TestController::clearIndexedDatabases):
1724         (WTR::TestController::clearLocalStorage):
1725         (WTR::TestController::hasDOMCache):
1726         (WTR::TestController::domCacheSize):
1727         (WTR::TestController::setStatisticsEnabled):
1728         (WTR::TestController::isStatisticsEphemeral):
1729         (WTR::TestController::setStatisticsDebugMode):
1730         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1731         (WTR::TestController::setStatisticsLastSeen):
1732         (WTR::TestController::setStatisticsMergeStatistic):
1733         (WTR::TestController::setStatisticsPrevalentResource):
1734         (WTR::TestController::setStatisticsVeryPrevalentResource):
1735         (WTR::TestController::dumpResourceLoadStatistics):
1736         (WTR::TestController::isStatisticsPrevalentResource):
1737         (WTR::TestController::isStatisticsVeryPrevalentResource):
1738         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1739         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1740         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1741         (WTR::TestController::setStatisticsHasHadUserInteraction):
1742         (WTR::TestController::isStatisticsHasHadUserInteraction):
1743         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
1744         (WTR::TestController::setStatisticsGrandfathered):
1745         (WTR::TestController::isStatisticsGrandfathered):
1746         (WTR::TestController::setUseITPDatabase):
1747         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1748         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1749         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1750         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1751         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1752         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1753         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1754         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1755         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1756         (WTR::TestController::statisticsUpdateCookieBlocking):
1757         (WTR::TestController::statisticsSubmitTelemetry):
1758         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1759         (WTR::TestController::setStatisticsIsRunningTest):
1760         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1761         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1762         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1763         (WTR::TestController::setStatisticsGrandfatheringTime):
1764         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1765         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1766         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1767         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1768         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1769         (WTR::TestController::statisticsDeleteCookiesForHost):
1770         (WTR::TestController::isStatisticsHasLocalStorage):
1771         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1772         (WTR::TestController::hasStatisticsIsolatedSession):
1773         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
1774         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
1775         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
1776         (WTR::TestController::statisticsResetToConsistentState):
1777         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1778         * WebKitTestRunner/TestController.h:
1779         * WebKitTestRunner/TestInvocation.cpp:
1780         (WTR::TestInvocation::invoke):
1781         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1782         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1783         (WTR::initializeWebViewConfiguration):
1784         (WTR::TestController::platformCreateWebView):
1785
1786 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1787
1788         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1789         https://bugs.webkit.org/show_bug.cgi?id=208415
1790
1791         Reviewed by Brent Fulgham.
1792
1793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1794         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1795         (TEST):
1796
1797 2020-03-02  Daniel Bates  <dabates@apple.com>
1798
1799         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
1800         https://bugs.webkit.org/show_bug.cgi?id=208352
1801         <rdar://problem/59867815>
1802
1803         Reviewed by Wenson Hsieh.
1804
1805         Update test results to reflect the new behavior. To do this I also need to fix up the test code
1806         to actually scroll the web content. This also means we now execute the same code on both Mac and
1807         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
1808         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
1809         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
1810
1811         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1812         (TEST):
1813
1814 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1815
1816         Unreviewed, rolling out r257687.
1817
1818         This commit caused debug tests to crash for macOS & iOS
1819
1820         Reverted changeset:
1821
1822         "[Cocoa] Mapping from MIME type to UTI type should be done in
1823         the UI process"
1824         https://bugs.webkit.org/show_bug.cgi?id=208415
1825         https://trac.webkit.org/changeset/257687
1826
1827 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1828
1829         Unreviewed, rolling out r257618.
1830
1831         This allegedly causes Safari to crash when closing a window
1832         (see rdar://problem/59922725).
1833
1834         Reverted changeset:
1835
1836         "UIProcess crash after using _prepareForMoveToWindow, then
1837         deallocating the WKWebView before moving to the window"
1838         https://bugs.webkit.org/show_bug.cgi?id=208365
1839         https://trac.webkit.org/changeset/257618
1840
1841 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
1842
1843         Remove std::lock_guard
1844         https://bugs.webkit.org/show_bug.cgi?id=206451
1845
1846         Reviewed by Anders Carlsson.
1847
1848         Add std::lock_guard lint rule to prevent from using it.
1849
1850         * Scripts/webkitpy/style/checkers/cpp.py:
1851         (check_lock_guard):
1852         (check_style):
1853         (CppChecker):
1854         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1855         (WebKitStyleTest.test_lock_guard):
1856         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1857         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1858         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1859         (assertHasObjects):
1860         (assertHasOnlyObjects):
1861         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1862         (WTR::AXThread::dispatch):
1863         (WTR::AXThread::dispatchFunctionsFromAXThread):
1864         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1865         (WTR::AXThread::initializeRunLoop):
1866
1867 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
1868
1869         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1870         https://bugs.webkit.org/show_bug.cgi?id=208415
1871
1872         Reviewed by Brent Fulgham.
1873
1874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1875         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1876         (TEST):
1877
1878 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1879
1880         Unreviewed, rolling out r257565.
1881
1882         It broke WinCairo MiniBrowser
1883
1884         Reverted changeset:
1885
1886         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
1887         https://bugs.webkit.org/show_bug.cgi?id=206894
1888         https://trac.webkit.org/changeset/257565
1889
1890 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1891
1892         EWS fails to retry build in case of kill-old-processes exception
1893         https://bugs.webkit.org/show_bug.cgi?id=208003
1894
1895         Reviewed by Jonathan Bedard.
1896
1897         * BuildSlaveSupport/ews-build/steps.py:
1898         (KillOldProcesses.evaluateCommand):
1899         (KillOldProcesses.getResultSummary):
1900
1901 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1902
1903         [ews] commit-queue should update the ChangeLog with Reviewer name
1904         https://bugs.webkit.org/show_bug.cgi?id=206535
1905
1906         Reviewed by Jonathan Bedard.
1907
1908         * BuildSlaveSupport/ews-build/steps.py:
1909         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
1910
1911 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
1912
1913         run-javascriptcore-tests: Make upload format valid
1914         https://bugs.webkit.org/show_bug.cgi?id=208341
1915
1916         Rubber-stamped by Aakash Jain.
1917
1918         * Scripts/run-javascriptcore-tests:
1919         (uploadResults): Remove. FIXME.
1920         * Scripts/webkitdirs.pm:
1921         (splitVersionString): Handle case where the subminor version number has a - in it.
1922         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
1923
1924 2020-02-28  youenn fablet  <youenn@apple.com>
1925
1926         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
1927         https://bugs.webkit.org/show_bug.cgi?id=208130
1928
1929         Reviewed by Eric Carlson.
1930
1931         * WebKitTestRunner/TestOptions.h:
1932         Use GPU process to capture by default.
1933         We will remove this option once done verifying that every test works smoothly.
1934
1935 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1936
1937         [ews] commit queue should skip building and testing for rollout patches
1938         https://bugs.webkit.org/show_bug.cgi?id=208329
1939
1940         Reviewed by Jonathan Bedard.
1941
1942         * BuildSlaveSupport/ews-build/steps.py:
1943         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
1944         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
1945         (RunWebKit1Tests.doStepIf): Ditto.
1946         * BuildSlaveSupport/ews-build/steps_unittest.py:
1947         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
1948         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
1949
1950 2020-02-28  Daniel Bates  <dabates@apple.com>
1951
1952         Update my watch list preferences and contributor's entry.
1953
1954         * Scripts/webkitpy/common/config/contributors.json:
1955         * Scripts/webkitpy/common/config/watchlist:
1956
1957 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1958
1959         Fix WebCore export macros for declspec
1960         https://bugs.webkit.org/show_bug.cgi?id=208363
1961
1962         Reviewed by Konstantin Tokarev.
1963
1964         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
1965         files. Removed precompiled headers that were empty.
1966
1967         * DumpRenderTree/DumpRenderTreePrefix.h:
1968         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
1969         * MiniBrowser/win/stdafx.h:
1970         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
1971         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
1972         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
1973         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
1974         * WebKitTestRunner/PlatformFTW.cmake:
1975         * WebKitTestRunner/PlatformWin.cmake:
1976         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1977
1978 2020-02-27  Tim Horton  <timothy_horton@apple.com>
1979
1980         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1981         https://bugs.webkit.org/show_bug.cgi?id=208365
1982
1983         Reviewed by Alex Christensen.
1984
1985         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1986         (TEST):
1987         Add a test! It was a 100% repro crash before this change.
1988
1989 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
1990
1991         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
1992         https://bugs.webkit.org/show_bug.cgi?id=208260
1993         <rdar://problem/59820107>
1994
1995         Reviewed by Tim Horton.
1996
1997         Followed instructions for adding an Info.plist for Single-File Tools
1998         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1999
2000         The default WebsiteDataStore file path will change with this test to
2001         reflect the new bundleID so we must change expectations for any api
2002         tests which rely on knowing the path.
2003
2004         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2006         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2007         (TEST):
2008         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2009         (TEST):
2010         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
2011         (TEST):
2012         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2013         (TEST):
2014         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2015         (TEST):
2016         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2017         (TEST):
2018         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2019         (TEST):
2020         (defaultWebsiteCacheDirectory):
2021         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
2022         (TEST):
2023         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2024         (TEST):
2025         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2026         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2027         (TEST):
2028         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2029         (TEST):
2030         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2031         (runWebsiteDataStoreCustomPaths):
2032         (TEST):
2033         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2034         (TestWebKitAPI::resetTestState):
2035         Now that we set a bundleID, we have to reset the cache model between
2036         tests, otherwise it gets stored between tests.
2037
2038         (TestWebKitAPI::TEST):
2039         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2040         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2041
2042 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2043
2044         TextManipulationController should not generate a new item for content in manipulated paragraphs
2045         https://bugs.webkit.org/show_bug.cgi?id=208286
2046
2047         Reviewed by Wenson Hsieh.
2048
2049         Added a regression test.
2050
2051         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2052         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2053
2054 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2055
2056         run-javascriptcore-tests: Make upload format valid
2057         https://bugs.webkit.org/show_bug.cgi?id=208341
2058
2059         Reviewed by Aakash Jain.
2060
2061         * Scripts/run-javascriptcore-tests:
2062         (uploadResults): Print json blob for upload after failure for debugging.
2063
2064 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2065
2066         [CMake] Add WebKit::PAL target
2067         https://bugs.webkit.org/show_bug.cgi?id=198493
2068
2069         Reviewed by Michael Catanzaro.
2070
2071         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2072
2073         * DumpRenderTree/PlatformWin.cmake:
2074
2075 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2076
2077         Add SPI to query WKFrameInfos in a WKWebView
2078         https://bugs.webkit.org/show_bug.cgi?id=208212
2079
2080         Reviewed by Brady Eidson.
2081
2082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2083         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2084         * WebKitTestRunner/TestController.cpp:
2085         (WTR::TestController::saltForOrigin):
2086
2087 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2088
2089         Unreviewed, rolling out r257530.
2090
2091         This commit seems to have broke the build internally for
2092         watchOS
2093
2094         Reverted changeset:
2095
2096         "Add SPI to query WKFrameInfos in a WKWebView"
2097         https://bugs.webkit.org/show_bug.cgi?id=208212
2098         https://trac.webkit.org/changeset/257530
2099
2100 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2101
2102         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2103         https://bugs.webkit.org/show_bug.cgi?id=206894
2104
2105         Reviewed by Adrian Perez de Castro.
2106
2107         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2108         MiniBrowsers.
2109
2110         * MiniBrowser/gtk/CMakeLists.txt:
2111         * MiniBrowser/win/CMakeLists.txt:
2112         * MiniBrowser/wpe/CMakeLists.txt:
2113
2114 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2115
2116         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2117         https://bugs.webkit.org/show_bug.cgi?id=206456
2118
2119         Reviewed by Brady Eidson.
2120
2121         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2122         (TEST):
2123
2124 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2125
2126         _WKUserContentWorld should be a wrapper around WKContentWorld
2127         https://bugs.webkit.org/show_bug.cgi?id=208274
2128
2129         Reviewed by Brady Eidson.
2130
2131         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2132         (TEST):
2133         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2134         (TEST):
2135
2136 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2137
2138         Unreviewed, rolling out r257522.
2139
2140         Caused 16 API test failures on the bots
2141
2142         Reverted changeset:
2143
2144         "TestWebKitAPI and WebKitTestRunner should have bundle
2145         identifiers"
2146         https://bugs.webkit.org/show_bug.cgi?id=208260
2147         https://trac.webkit.org/changeset/257522
2148
2149 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2150
2151         Add SPI to query WKFrameInfos in a WKWebView
2152         https://bugs.webkit.org/show_bug.cgi?id=208212
2153
2154         Reviewed by Brady Eidson.
2155
2156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2157         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2158         * WebKitTestRunner/TestController.cpp:
2159         (WTR::TestController::saltForOrigin):
2160
2161 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2162
2163         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2164         https://bugs.webkit.org/show_bug.cgi?id=208260
2165         <rdar://problem/59820107>
2166
2167         Reviewed by Tim Horton.
2168
2169         Followed instructions for adding an Info.plist for Single-File Tools
2170         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2171
2172         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2173         * TestWebKitAPI/Info.plist: Added.
2174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2175         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2176         * WebKitTestRunner/Info.plist: Added.
2177         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2178
2179 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2180
2181         Tests should each use a unique ResourceLoadStatistics file path for its database store
2182         https://bugs.webkit.org/show_bug.cgi?id=208206
2183         <rdar://problem/59690272>
2184
2185         Reviewed by Brady Eidson.
2186
2187         Initialize a default website data store before checking for the ITP
2188         store to ensure the directory exists after the file has been deleted.
2189
2190         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2191         (TEST):
2192
2193 2020-02-26  Christopher Reid  <chris.reid@sony.com>
2194
2195         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
2196         https://bugs.webkit.org/show_bug.cgi?id=197684
2197         <rdar://problem/59467397>
2198
2199         Reviewed by Yusuke Suzuki.
2200
2201         Add test for FileSystem::createFile
2202
2203         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2204
2205 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
2206
2207         [ews] commit-queue should verify patch committer and reviewer
2208         https://bugs.webkit.org/show_bug.cgi?id=206532
2209
2210         Reviewed by Jonathan Bedard.
2211
2212         * BuildSlaveSupport/ews-build/steps.py:
2213         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
2214         (ValidateCommiterAndReviewer._addToLog):
2215         (ValidateCommiterAndReviewer.getResultSummary):
2216         (ValidateCommiterAndReviewer.fail_build):
2217         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
2218         (ValidateCommiterAndReviewer.is_reviewer):
2219         (ValidateCommiterAndReviewer.is_committer):
2220         (ValidateCommiterAndReviewer.full_name_from_email):
2221         (ValidateCommiterAndReviewer.start):
2222
2223 2020-02-26  Daniel Bates  <dabates@apple.com>
2224
2225         [iOS] Send focus update immediately on becoming or resigning first responder
2226         https://bugs.webkit.org/show_bug.cgi?id=208082
2227         <rdar://problem/59688413>
2228
2229         Rubber-stamped by Jer Noble.
2230
2231         Add a test to ensure that selecting a position at a point after the web view
2232         becomes first responder is allowed. Such an operation is only allowed if the
2233         web view is focused.
2234
2235         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2236         (-[TestWKWebView selectPositionAtPoint:]):
2237         (TEST):
2238         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
2239
2240 2020-02-26  Chris Dumez  <cdumez@apple.com>
2241
2242         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
2243
2244         The test was added for macOS and times out on iOS.
2245
2246         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2247         (TEST):
2248
2249 2020-02-26  Youenn Fablet  <youenn@apple.com>
2250
2251         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
2252         https://bugs.webkit.org/show_bug.cgi?id=208238
2253
2254         Reviewed by Eric Carlson.
2255
2256         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2257         (TEST):
2258         Remove use of deleted parameter.
2259
2260 2020-02-25  Devin Rousso  <drousso@apple.com>
2261
2262         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
2263         https://bugs.webkit.org/show_bug.cgi?id=206911
2264         <rdar://problem/58026635>
2265
2266         Reviewed by Brian Burg.
2267
2268         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2269         (TestWebKitAPI::TEST):
2270         Add test for `WTF::HashSet::reserveInitialCapacity`.
2271
2272         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2273         (TestWebKitAPI::TEST):
2274         Actually check the value of `WTF::HashMap::capacity`.
2275
2276         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
2277         (-[InspectorDelegate _webView:didAttachInspector:])
2278         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
2279         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
2280         (TestWebKitAPI::TEST):
2281         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2282         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
2283         (TestWebKitAPI::TEST): Deleted.
2284
2285 2020-02-25  Matt Lewis  <jlewis3@apple.com>
2286
2287         Add checkout_root to stubrepository.py
2288         https://bugs.webkit.org/show_bug.cgi?id=208213
2289
2290         Reviewed by Jonathan Bedard.
2291
2292         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2293         (StubRepository.__init__):
2294
2295         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
2296         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
2297
2298 2020-02-25  Daniel Bates  <dabates@apple.com>
2299
2300         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
2301         https://bugs.webkit.org/show_bug.cgi?id=208214
2302
2303         Reviewed by Wenson Hsieh.
2304
2305         Wait until the copy operation completes before loading the second web view and testing paste
2306         to ensure that something was actually copied to the clipboard.
2307
2308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
2309         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2310         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
2311         so that we wait until the command completes.
2312
2313 2020-02-25  Chris Dumez  <cdumez@apple.com>
2314
2315         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
2316         https://bugs.webkit.org/show_bug.cgi?id=208199
2317         <rdar://problem/59746887>
2318
2319         Reviewed by Alex Christensen.
2320
2321         Add API test coverage.
2322
2323         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2324         (TEST):
2325
2326 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2327
2328         spinRunLoop should take a non-zero integer as parameter
2329         https://bugs.webkit.org/show_bug.cgi?id=208148
2330         <rdar://problem/59766682>
2331
2332         Unreviewed iOS build fix.
2333
2334         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2335         (TestWebKitAPI::Util::spinRunLoop):
2336
2337 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2338
2339         spinRunLoop should take a non-zero integer as parameter
2340         https://bugs.webkit.org/show_bug.cgi?id=208148
2341
2342         Reviewed by Darin Adler.
2343
2344         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2345         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2346         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2347         (TestWebKitAPI::Util::spinRunLoop):
2348
2349 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2350
2351         [WTF] Add tests for CompactRefPtrTuple
2352         https://bugs.webkit.org/show_bug.cgi?id=208172
2353
2354         Reviewed by Darin Adler.
2355
2356         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
2357         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
2358
2359         * TestWebKitAPI/CMakeLists.txt:
2360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2361         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
2362         (TestWebKitAPI::TEST):
2363
2364 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
2365
2366         [ews] commit-queue should check that patch have appropriate review flag
2367         https://bugs.webkit.org/show_bug.cgi?id=208138
2368
2369         Reviewed by Jonathan Bedard.
2370
2371         * BuildSlaveSupport/ews-build/steps.py:
2372         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
2373         (BugzillaMixin._is_patch_cq_plus):
2374         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
2375         (ValidatePatch.start):
2376
2377 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
2378
2379         [WebAuthn] Implement SPI for the platform authenticator
2380         https://bugs.webkit.org/show_bug.cgi?id=208087
2381         <rdar://problem/59369305>
2382
2383         Reviewed by Brent Fulgham.
2384
2385         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
2386
2387         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
2388         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2390         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2391         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2392         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
2393         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
2394         (TestWebKitAPI::TEST):
2395         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
2396         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
2397         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
2398         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
2399
2400 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2401
2402         Unreviewed, updating LLDB test for CompactPointerTuple.
2403         https://bugs.webkit.org/show_bug.cgi?id=207827
2404
2405         * lldb/lldb_webkit.py:
2406         (WTFCompactPointerTupleProvider):
2407         (WTFCompactPointerTupleProvider.update):
2408
2409 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
2410
2411         Provide alternate way to name Web Content process
2412         https://bugs.webkit.org/show_bug.cgi?id=205224
2413         rdar://57038084
2414
2415         Reviewed by Alex Christensen.
2416
2417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2418         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
2419         (TestWebKitAPI::TEST):
2420
2421 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
2422
2423         results.webkit.org: Link to result archives
2424         https://bugs.webkit.org/show_bug.cgi?id=207646
2425         <rdar://problem/59395807>
2426
2427         Rubber-stamped by Aakash Jain.
2428
2429         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
2430         (_ArchiveRouter): Retrieve json from archive-router endpoint.
2431         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
2432         return the most specific value.
2433         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
2434         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
2435         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
2436         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2437         (parametersForInstance): Extract from lambda function.
2438         (testRunLink): Use parametersForInstance instead of a lambda function.
2439         (archiveLink): Return an archive link for data. 
2440         (contentForData): Add archive link to view.
2441         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2442         (TimelineFromEndpoint): Accept both suite and test.
2443         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
2444         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
2445         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
2446         * resultsdbpy/resultsdbpy/view/view_routes.py:
2447         (ViewRoutes.__init__): Add archive_route dictionary.
2448
2449 2020-02-24  Alex Christensen  <achristensen@webkit.org>
2450
2451         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
2452         https://bugs.webkit.org/show_bug.cgi?id=208035
2453         <rdar://problem/58011337>
2454
2455         Reviewed by Tim Hatcher.
2456
2457         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2458
2459 2020-02-22  Darin Adler  <darin@apple.com>
2460
2461         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
2462         https://bugs.webkit.org/show_bug.cgi?id=208099
2463
2464         Reviewed by Antti Koivisto.
2465
2466         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2467         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
2468         so we can use the -[NSString createJSStringRef] method.
2469         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
2470         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
2471
2472 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2473
2474         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
2475         https://bugs.webkit.org/show_bug.cgi?id=208096
2476         <rdar://problem/59632008>
2477
2478         Reviewed by Alexey Proskuryakov.
2479
2480         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
2481         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
2482         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
2483
2484         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
2485         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
2486         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
2487         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
2488         in the credit card expiry field.
2489
2490         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
2491
2492         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2493         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2494         (WTR::UIScriptController::setDefaultCalendarType):
2495         * WebKitTestRunner/TestController.h:
2496
2497         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
2498         identifier and calendar locale identifier.
2499
2500         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2501         (WTR::swizzledCalendar):
2502         (WTR::TestController::overriddenCalendarIdentifier const):
2503         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
2504
2505         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
2506
2507         (WTR::TestController::setDefaultCalendarType):
2508
2509         Plumb the new calendar's locale identifier through this method.
2510
2511         (WTR::TestController::cocoaResetStateToConsistentValues):
2512         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
2513         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
2514         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
2515         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
2516
2517 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
2518
2519         App-bound domains should have separate Network Sessions
2520         https://bugs.webkit.org/show_bug.cgi?id=208026
2521         <rdar://problem/59434006>
2522
2523         Reviewed by Brent Fulgham.
2524
2525         This patch is mostly test infrastructure involving 3 functions.
2526         One sets in-app browser privacy as enabled in the network process
2527         manually for the test. One ensures that setting the WebView category
2528         works properly, and the last one checks for an app-bound session for
2529         an app-bound navigation.
2530
2531         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2532         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2533         (WTR::InjectedBundle::didReceiveMessageToPage):
2534         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2535         (WTR::TestRunner::getWebViewCategory):
2536         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
2537         (WTR::TestRunner::hasAppBoundSession):
2538         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
2539         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
2540         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2541         * WebKitTestRunner/TestController.cpp:
2542         (WTR::TestController::ensureViewSupportsOptionsForTest):
2543         Clearing the bundleID should happen right before setting a new one, 
2544         otherwise it clears the ID after it is set and returns a null ID.
2545
2546         (WTR::TestController::resetStateToConsistentValues):
2547         (WTR::TestController::getWebViewCategory):
2548         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
2549         (WTR::inAppBrowserPrivacyBooleanResultCallback):
2550         (WTR::inAppBrowserPrivacyVoidResultCallback):
2551         (WTR::TestController::hasAppBoundSession):
2552         (WTR::TestController::setInAppBrowserPrivacyEnabled):
2553         * WebKitTestRunner/TestController.h:
2554         * WebKitTestRunner/TestInvocation.cpp:
2555         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2556         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2557         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
2558         (WTR::TestInvocation::didReceivePrevalentDomains):
2559         (WTR::TestInvocation::didReceiveWebViewCategory):
2560         * WebKitTestRunner/TestInvocation.h:
2561         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2562         (WTR::TestController::getWebViewCategory):
2563
2564 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
2565
2566         Build DumpRenderTree and WebKitTestRunner for macCatalyst
2567         https://bugs.webkit.org/show_bug.cgi?id=208068
2568         <rdar://problem/59676596>
2569
2570         Reviewed by Tim Horton.
2571
2572         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
2573         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2574         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
2575         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
2576         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
2577         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
2578         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
2579         * DumpRenderTree/mac/EventSendingController.h: Ditto.
2580         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
2581         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
2582         * Makefile: Add DumpRenderTree and WebKitTestRunner.
2583         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2584         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
2585         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
2586
2587 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2588
2589         [ews] Add build step to Validate ChangeLog for commit-queue
2590         https://bugs.webkit.org/show_bug.cgi?id=208064
2591
2592         Reviewed by Jonathan Bedard.
2593
2594         * BuildSlaveSupport/ews-build/steps.py:
2595         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
2596         (ValidateChangeLogAndReviewer.start):
2597         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
2598         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
2599
2600 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2601
2602         [ews] Add build step to set cq- flag on bugzilla patch
2603         https://bugs.webkit.org/show_bug.cgi?id=208021
2604
2605         Reviewed by Jonathan Bedard.
2606
2607         * BuildSlaveSupport/ews-build/steps.py:
2608         (BugzillaMixin.set_cq_minus_flag_on_patch):
2609         (SetCommitQueueMinusFlagOnPatch):
2610         (SetCommitQueueMinusFlagOnPatch.start):
2611         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
2612
2613 2020-02-20  Matt Lewis  <jlewis3@apple.com>
2614
2615         Stub repositories fail to upload some results due to missing head svn revision
2616         https://bugs.webkit.org/show_bug.cgi?id=207684
2617
2618         Reviewed by Jonathan Bedard.
2619
2620         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
2621         (MockHost.__init__):
2622         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2623         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2624         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2625         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
2626         * Scripts/webkitpy/port/base.py:
2627         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
2628         from using mock SCMs and more
2629         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
2630
2631 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
2632
2633         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
2634         https://bugs.webkit.org/show_bug.cgi?id=208051
2635
2636         Reviewed by Carlos Alberto Lopez Perez.
2637
2638         Verbose flag prints out each test name executed. Without this flag
2639         stdout prints out one or two periods.
2640
2641         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2642         (RunJavaScriptCoreTests.start):
2643
2644 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2645
2646         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
2647         https://bugs.webkit.org/show_bug.cgi?id=207984
2648
2649         Reviewed by Daniel Bates.
2650
2651         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2652         (TestWebKitAPI::TEST):
2653
2654 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
2655
2656         [GTK] Improve user agent quirk for Google Docs and Google Drive
2657         https://bugs.webkit.org/show_bug.cgi?id=206506
2658
2659         Reviewed by Carlos Garcia Campos.
2660
2661         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2662         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2663         (TestWebKitAPI::TEST):
2664
2665 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2666
2667         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
2668         https://bugs.webkit.org/show_bug.cgi?id=207380
2669
2670         Reviewed by Jonathan Bedard.
2671
2672         Added a new rule 'build/export_macro'.
2673
2674         Removed a obsolete rule 'readability/webkit_export' which was used
2675         only by Chromium port (r148185).
2676
2677         * Scripts/webkitpy/style/checkers/cpp.py:
2678         (_FunctionState.export_macro):
2679         (check_function_definition):
2680         (_unix_path): Added.
2681         (is_generated_file): Use _unix_path.
2682         (check_has_config_header): Ditto.
2683         (CppChecker):
2684         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2685         (WebKitStyleTest.test_export_macro_check):
2686         (WebKitStyleTest.test_webkit_export_check): Deleted.
2687
2688 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2689
2690         [Win][MiniBrowser] Add prettier toolbar button icons
2691         https://bugs.webkit.org/show_bug.cgi?id=207999
2692
2693         Reviewed by Ross Kirsling.
2694
2695         Use a custom toolbar button icons instead of system stock icons.
2696
2697         Fixed a bug toolbar button dropdown arrows always looked being
2698         hovered. TBSTYLE_FLAT should be given.
2699
2700         Removed the window border line of Progress Indicator.
2701
2702         * MiniBrowser/win/MainWindow.cpp:
2703         (MainWindow::createToolbar):
2704         * MiniBrowser/win/MiniBrowserLib.rc:
2705         * MiniBrowser/win/MiniBrowserLibResource.h:
2706         * MiniBrowser/win/toolbar.bmp: Added.
2707
2708 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
2709
2710         Update run-webkit-tests help description for skip-failing-tests
2711         https://bugs.webkit.org/show_bug.cgi?id=208031
2712
2713         Reviewed by Alexey Proskuryakov.
2714
2715         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2716
2717 2020-02-20  Chris Dumez  <cdumez@apple.com>
2718
2719         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
2720         https://bugs.webkit.org/show_bug.cgi?id=208015
2721         <rdar://problem/59591630>
2722
2723         Reviewed by Geoffrey Garen.
2724
2725         Add API test coverage.
2726
2727         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2728         (TEST):
2729
2730 2020-02-20  Tim Horton  <timothy_horton@apple.com>
2731
2732         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
2733         https://bugs.webkit.org/show_bug.cgi?id=207998
2734         <rdar://problem/40942425>
2735
2736         Reviewed by Sam Weinig.
2737
2738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2739         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
2740         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2741         (TestWebKitAPI::TEST):
2742         Add some tests for top content insets.
2743
2744 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
2745
2746         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
2747         https://bugs.webkit.org/show_bug.cgi?id=207910
2748
2749         Unreviewed infrastructure fix.
2750
2751         * Scripts/run-javascriptcore-tests:
2752         (configurationForUpload): Use the major version instead of the sub-minor version
2753         for version name.
2754
2755 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
2756
2757         [CMake] Add WPE::libwpe target
2758         https://bugs.webkit.org/show_bug.cgi?id=207970
2759
2760         Reviewed by Adrian Perez de Castro.
2761
2762         Use the WPE::libwpe target.
2763
2764         * MiniBrowser/wpe/CMakeLists.txt:
2765         * TestWebKitAPI/PlatformWPE.cmake:
2766         * TestWebKitAPI/glib/PlatformWPE.cmake:
2767         * wpe/backends/CMakeLists.txt:
2768
2769 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2770
2771         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
2772         https://bugs.webkit.org/show_bug.cgi?id=207749
2773
2774         Reviewed by Ross Kirsling.
2775
2776         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
2777
2778         * MiniBrowser/win/MainWindow.cpp:
2779         (MainWindow::createToolbar):
2780         (MainWindow::WndProc):
2781         (MainWindow::setDefaultURLToCurrentURL):
2782         (MainWindow::goHome): Added.
2783         (MainWindow::onURLBarEnter):
2784         * MiniBrowser/win/MainWindow.h:
2785         * MiniBrowser/win/MiniBrowserLib.rc:
2786         * MiniBrowser/win/MiniBrowserLibResource.h:
2787         * MiniBrowser/win/MiniBrowserReplace.h:
2788         * MiniBrowser/win/WinMain.cpp:
2789         (wWinMain):
2790
2791 2020-02-19  Peng Liu  <peng.liu6@apple.com>
2792
2793         Fix check-webkit-style errors related to AVFoundationSPI.h
2794         https://bugs.webkit.org/show_bug.cgi?id=207834
2795
2796         Reviewed by Daniel Bates.
2797
2798         Revert the change in r256770 regarding the headers ordering.
2799         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
2800
2801         * Scripts/webkitpy/style/checkers/cpp.py:
2802         (check_include_line):
2803
2804 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
2805
2806         results.webkit.org: Correctly report JSC tests for windows
2807         https://bugs.webkit.org/show_bug.cgi?id=207910
2808
2809         Rubber-stamped by Aakash Jain.
2810
2811         * Scripts/run-javascriptcore-tests:
2812         (configurationForUpload): Give Windows a version name.
2813         * Scripts/webkitdirs.pm:
2814         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
2815         Version dictionary.
2816
2817 2020-02-19  Chris Dumez  <cdumez@apple.com>
2818
2819         Unreviewed, fix assertions in storage access API layout tests after r256882.
2820
2821         Drop dead testRunner code to toggle storage access API feature.
2822
2823         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2824         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2825         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
2826         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2827         * WebKitTestRunner/TestInvocation.cpp:
2828         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2829
2830 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
2831
2832         [WPE] Support 2D axis, smooth-motion events
2833         https://bugs.webkit.org/show_bug.cgi?id=207881
2834
2835         Reviewed by Carlos Garcia Campos.
2836
2837         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
2838
2839 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
2840
2841         Unreviewed, rolling out r256851.
2842
2843         Broke internal bots
2844
2845         Reverted changeset:
2846
2847         "Stub repositories fail to upload some results due to missing
2848         head svn revision"
2849         https://bugs.webkit.org/show_bug.cgi?id=207684
2850         https://trac.webkit.org/changeset/256851
2851
2852 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2853
2854         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
2855         https://bugs.webkit.org/show_bug.cgi?id=207883
2856
2857         Reviewed by Ross Kirsling.
2858
2859         Unlike other mouse buttons, 4th and 5th mouse buttons are
2860         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
2861         WM_XBUTTONUP events to the window under the mouse cursor.
2862         Unhandled WM_XBUTTONUP events are automatically converted to
2863         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
2864         parent window.
2865         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
2866
2867         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
2868         handled.
2869
2870         * MiniBrowser/win/BrowserWindow.h:
2871         * MiniBrowser/win/MainWindow.cpp:
2872         (MainWindow::WndProc):
2873         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2874         (WebKitBrowserWindow::navigateForwardOrBackward):
2875         * MiniBrowser/win/WebKitBrowserWindow.h:
2876         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2877         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
2878         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2879
2880 2020-02-18  Alex Christensen  <achristensen@webkit.org>
2881
2882         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
2883         https://bugs.webkit.org/show_bug.cgi?id=207912
2884         <rdar://problem/59556922>
2885
2886         Reviewed by Brian Weinstein.
2887
2888         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2889         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2890         (TEST):
2891         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2892         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
2893
2894 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2895
2896         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
2897         https://bugs.webkit.org/show_bug.cgi?id=207899
2898         <rdar://problem/55658207>
2899
2900         Reviewed by Tim Horton and Simon Fraser.
2901
2902         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
2903
2904         * WebKitTestRunner/TestController.cpp:
2905         (WTR::updateTestOptionsFromTestHeader):
2906         * WebKitTestRunner/TestOptions.h:
2907         (WTR::TestOptions::hasSameInitializationOptions const):
2908         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2909         (WTR::TestController::platformCreateWebView):
2910
2911 2020-02-18  Matt Lewis  <jlewis3@apple.com>
2912
2913         Stub repositories fail to upload some results due to missing head svn revision
2914         https://bugs.webkit.org/show_bug.cgi?id=207684
2915
2916         Reviewed by Jonathan Bedard.
2917
2918         * Scripts/webkitpy/api_tests/run_api_tests.py:
2919         (main): Added initializing the scm to the host object.
2920         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2921         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2922         it in line with modern code.
2923         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2924         (main): Added inializing the scm to the host object.
2925         * Scripts/webkitpy/port/base.py:
2926         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
2927         from using mock SCMs and more
2928         * Scripts/webkitpy/test/main.py:
2929         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
2930         and converted the webkit_root variable to the SCM checkout root.
2931         (Tester._run_tests):
2932
2933 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
2934
2935         Move [UIDevice currentDevice] calls to UI process
2936         https://bugs.webkit.org/show_bug.cgi?id=204320
2937
2938         Reviewed by Darin Adler.
2939
2940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2941         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
2942         (TEST):
2943
2944 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
2945
2946         Move from "layer flush" terminology to "rendering update"
2947         https://bugs.webkit.org/show_bug.cgi?id=207870
2948
2949         Reviewed by Tim Horton.
2950
2951         Rename various functions and member variables to move away from the legacy "layer flush"
2952         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
2953         that we have layers is an implementation detail.
2954         
2955         Change LayerFlushThrottlingState to be an OptionSet<>.
2956
2957         * Tracing/SystemTracePoints.plist:
2958
2959 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
2960
2961         [Webkit.css] Adding popover style element
2962         This help to prevent us reinventing the wheel ever again
2963         https://bugs.webkit.org/show_bug.cgi?id=207787
2964
2965         Reviewed by Dean Jackson.
2966
2967         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
2968         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2969         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2970         (.popover):
2971         (.popover>.content):
2972         (.popover.display):
2973         (.popover .arrow):
2974         (.popover .arrow.point-top):
2975         (.popover .arrow.point-bottom):
2976         (.popover .arrow.point-left):
2977         (.popover .arrow.point-right):
2978         (@media (prefers-color-scheme: dark) .popover>.content):
2979         (@media (prefers-color-scheme: dark) .popover.display):
2980         (@media (prefers-color-scheme: dark) .popover .arrow):
2981         (.popover>.content>.section): Deleted.
2982         (.popover:focus>.content, .popover:hover>.content): Deleted.
2983         (.popover.right>.content): Deleted.
2984         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
2985         (.popover.left>.content): Deleted.
2986         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
2987         (.popover.bottom>.content): Deleted.
2988         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
2989
2990 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
2991
2992         Update WebKit Tools to issue mach extensions as needed
2993         https://bugs.webkit.org/show_bug.cgi?id=207850
2994         <rdar://problem/59521019>
2995
2996         Reviewed by Per Arne Vollan.
2997
2998         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
2999         to its child processes (WebContent, GPU, Network, etc.) as needed.
3000
3001         * MiniBrowser/MiniBrowser.entitlements:
3002         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
3003         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3004         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3005         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
3006
3007 2020-02-17  Peng Liu  <peng.liu6@apple.com>
3008
3009         Fix check-webkit-style errors related to AVFoundationSPI.h
3010         https://bugs.webkit.org/show_bug.cgi?id=207834
3011
3012         Reviewed by Eric Carlson.
3013
3014         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
3015         Soft-link headers can be included as either "file.h" or <file.h>.
3016
3017         * Scripts/webkitpy/style/checkers/cpp.py:
3018         (_classify_include):
3019         (check_include_line):
3020
3021 2020-02-17  Keith Rollin  <krollin@apple.com>
3022
3023         Unreviewed build fix after r256715.
3024
3025         Fix tvOS and watchOS builds.
3026
3027         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3028
3029 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
3030
3031         Use CF prefs direct mode in the WebContent process
3032         https://bugs.webkit.org/show_bug.cgi?id=203420
3033
3034         Reviewed by Brent Fulgham.
3035
3036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3037         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
3038         (TEST):
3039
3040 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3041
3042         EWS should be able to file Bugzilla bugs
3043         https://bugs.webkit.org/show_bug.cgi?id=207845
3044
3045         Reviewed by Alexey Proskuryakov.
3046
3047         * BuildSlaveSupport/ews-build/steps.py:
3048         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
3049
3050 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3051
3052         EWS should be able to comment on Bugzilla
3053         https://bugs.webkit.org/show_bug.cgi?id=201927
3054
3055         Reviewed by Jonathan Bedard.
3056
3057         * BuildSlaveSupport/ews-build/steps.py:
3058         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
3059         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
3060         (BugzillaMixin.close_bug): Ditto.
3061         (CommentOnBug): Build step to comment on bugzilla bug.
3062
3063 2020-02-17  Antti Koivisto  <antti@apple.com>
3064
3065         [macOS] Add trace points for layer flush runloop observer
3066         https://bugs.webkit.org/show_bug.cgi?id=207837
3067
3068         Reviewed by Sam Weinig.
3069
3070         * Tracing/SystemTracePoints.plist:
3071
3072 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
3073
3074         [CMake] Use builtin targets
3075         https://bugs.webkit.org/show_bug.cgi?id=205166
3076
3077         Reviewed by Darin Adler.
3078
3079         * TestWebKitAPI/PlatformWin.cmake:
3080
3081 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3082
3083         [ews] add SetBuildSummary step for Windows EWS
3084         https://bugs.webkit.org/show_bug.cgi?id=207556
3085
3086         Reviewed by Jonathan Bedard.
3087
3088         * BuildSlaveSupport/ews-build/factories.py:
3089         (WindowsFactory.__init__):
3090         (GTKBuildAndTestFactory.__init__):
3091         * BuildSlaveSupport/ews-build/factories_unittest.py:
3092         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
3093
3094 2020-02-17  Alberto Garcia  <berto@igalia.com>
3095
3096         [WPE] Change the QML plugin install path
3097         https://bugs.webkit.org/show_bug.cgi?id=207761
3098
3099         Reviewed by Philippe Normand.
3100
3101         * Scripts/run-qt-wpe-minibrowser:
3102         * glib/api_test_runner.py:
3103         (TestRunner._run_test_qt):
3104
3105 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3106
3107         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
3108         https://bugs.webkit.org/show_bug.cgi?id=207746
3109
3110         Reviewed by Don Olmstead.
3111
3112         * MiniBrowser/win/stdafx.h:
3113
3114 2020-02-16  Brady Eidson  <beidson@apple.com>
3115
3116         Expose "allowsContentJavaScript" on WKWebpagePreferences
3117         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
3118
3119         Reviewed by Darin Adler.
3120
3121         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3122         (TEST):
3123         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3124         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3125         (TEST):
3126         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
3127         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3128         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3129         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3130         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
3131         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
3132         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3133         * TestWebKitAPI/cocoa/TestWKWebView.h:
3134         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3135         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
3136
3137 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
3138
3139         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
3140         https://bugs.webkit.org/show_bug.cgi?id=207747
3141
3142         Reviewed by Keith Miller.
3143
3144         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
3145         (TestWebKitAPI::TEST):
3146
3147 2020-02-14  Alex Christensen  <achristensen@webkit.org>
3148
3149         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
3150         https://bugs.webkit.org/show_bug.cgi?id=207360
3151         <rdar://problem/57825317>
3152
3153         Reviewed by Ryosuke Niwa.
3154
3155         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3156         (TestWebKitAPI::TEST):
3157
3158 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
3159
3160         [CMake] Add Fontconfig::Fontconfig target
3161         https://bugs.webkit.org/show_bug.cgi?id=207730
3162
3163         Reviewed by Adrian Perez de Castro.
3164
3165         Use the Fontconfig::Fontconfig target.
3166
3167         * WebKitTestRunner/PlatformGTK.cmake:
3168
3169 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
3170
3171          Expose prevalent domains on a per-page basis
3172          https://bugs.webkit.org/show_bug.cgi?id=207523
3173          <rdar://problem/59270758>
3174
3175         Reviewed by Chris Dumez.
3176
3177         Added WebKitTestRunner functions so this functionality can be tested.
3178         clearPrevalentDomains should be called between tests to reset the
3179         state.
3180
3181         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3182         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3183         (WTR::InjectedBundle::didReceiveMessageToPage):
3184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3185         (WTR::TestRunner::getPrevalentDomains):
3186         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
3187         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3188         * WebKitTestRunner/TestController.cpp:
3189         (WTR::TestController::resetStateToConsistentValues):
3190         (WTR::TestController::getPrevalentDomains):
3191         (WTR::TestController::clearPrevalentDomains):
3192         * WebKitTestRunner/TestController.h:
3193         * WebKitTestRunner/TestInvocation.cpp:
3194         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3195         (WTR::TestInvocation::didReceivePrevalentDomains):
3196         * WebKitTestRunner/TestInvocation.h:
3197         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3198         (WTR::TestController::getPrevalentDomains):
3199         (WTR::TestController::clearPrevalentDomains):
3200
3201 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3202
3203         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
3204         https://bugs.webkit.org/show_bug.cgi?id=207682
3205
3206         Reviewed by Ross Kirsling.
3207
3208         The toolbar placed button common controls as the toolbar buttons.
3209         However, because these buttons are focusable, shortcut keys don't
3210         work after clicking them.
3211
3212         Added Home button, Add to Bookmarks button, dropdown buttons of
3213         back and forward buttons, but they aren't implemented yet. Just
3214         placeholders at the moment.
3215
3216         * MiniBrowser/win/MainWindow.cpp:
3217         (MainWindow::createToolbar): Added.
3218         (MainWindow::resizeToolbar): Added.
3219         (MainWindow::rescaleToolbar): Added.
3220         (MainWindow::init):
3221         (MainWindow::resizeSubViews):
3222         (MainWindow::updateDeviceScaleFactor):
3223         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
3224
3225 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3226
3227         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
3228         https://bugs.webkit.org/show_bug.cgi?id=207676
3229
3230         Reviewed by Wenson Hsieh and Timothy Hatcher.
3231
3232         Added regression tests for pasting content with -apple-system-label and outdenting content.
3233
3234         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3235         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
3236         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
3237
3238 2020-02-13  Alex Christensen  <achristensen@webkit.org>
3239
3240         _WKResourceLoadInfo should conform to NSSecureCoding
3241         https://bugs.webkit.org/show_bug.cgi?id=207667
3242
3243         Reviewed by Brady Eidson.
3244
3245         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3246         (TEST):
3247
3248 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
3249
3250         [PlayStation] Add Buildbots for Debug/Release builds
3251         https://bugs.webkit.org/show_bug.cgi?id=199454
3252
3253         Reviewed by Aakash Jain.
3254
3255         * BuildSlaveSupport/build.webkit.org-config/config.json:
3256         Add PlayStation slaves, builders
3257         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3258         Use higher timeout for playstation as with win bot
3259         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3260         Set PlayStation category for playstation platform
3261         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3262         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
3263         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3264         Add PlayStation expectations
3265
3266 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
3267
3268         [iOS] Check if PIP is supported in the UI process
3269         https://bugs.webkit.org/show_bug.cgi?id=207406
3270
3271         Reviewed by Brent Fulgham.
3272
3273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3274         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
3275         (TEST):
3276
3277 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3278
3279         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
3280         https://bugs.webkit.org/show_bug.cgi?id=207397
3281         <rdar://problem/59268128>
3282
3283         Reviewed by Jer Noble.
3284
3285         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3286         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3287
3288 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3289
3290         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
3291         https://bugs.webkit.org/show_bug.cgi?id=207696
3292
3293         Reviewed by Tim Horton.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3296
3297 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3298
3299         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
3300         https://bugs.webkit.org/show_bug.cgi?id=207680
3301         <rdar://problem/59340940>
3302
3303         Reviewed by Tim Horton.
3304
3305         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
3306         the current selection works.
3307
3308         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3309         (-[TestWKWebView updateSelectionWithExtentPoint:]):
3310         * TestWebKitAPI/ios/UIKitSPI.h:
3311
3312 2020-02-13  Said Abou-Hallawa  <said@apple.com>
3313
3314         Unreviewed, rolling out r255158, 255405 and r255486
3315
3316         Caused test flakiness and PLT regression.
3317
3318         * DumpRenderTree/mac/DumpRenderTree.mm:
3319         (resetWebPreferencesToConsistentValues):
3320         * DumpRenderTree/win/DumpRenderTree.cpp:
3321         (enableExperimentalFeatures):
3322         * WebKitTestRunner/TestController.cpp:
3323         (WTR::TestController::resetPreferencesToConsistentValues):
3324
3325 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3326
3327         run-javascriptcore-tests: Allow insecure requests on upload
3328         https://bugs.webkit.org/show_bug.cgi?id=207662
3329
3330         Rubber-stamped by Aakash Jain.
3331
3332         * Scripts/run-javascriptcore-tests:
3333         (uploadResults): Allow insecure curl request when posting results.
3334
3335 2020-02-12  Truitt Savell  <tsavell@apple.com>
3336
3337         Unreviewed, rolling out r256463.
3338
3339         Caused major flakiness on Mac wk2
3340
3341         Reverted changeset:
3342
3343         "REGRESSION (r255158): http/tests/frame-throttling/raf-
3344         throttle-in-cross-origin-subframe.html is a flaky failure"
3345         https://bugs.webkit.org/show_bug.cgi?id=206839
3346         https://trac.webkit.org/changeset/256463
3347
3348 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3349
3350         results.webkit.org: Remove debug JS logging
3351         https://bugs.webkit.org/show_bug.cgi?id=207663
3352
3353         Reviewed by Aakash Jain.
3354
3355         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3356         (elapsed):
3357         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
3358         (_ToolTip.prototype.toString):
3359         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
3360         (prototype.addWithDelay):
3361         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
3362
3363 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
3364
3365         Remove CSS_DEVICE_ADAPTATION
3366         https://bugs.webkit.org/show_bug.cgi?id=203479
3367
3368         Reviewed by Tim Horton.
3369         
3370         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
3371         so remove the code.
3372
3373         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3374
3375 2020-02-12  Said Abou-Hallawa  <said@apple.com>
3376
3377         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
3378         https://bugs.webkit.org/show_bug.cgi?id=206839
3379
3380         Reviewed by Simon Fraser.
3381
3382         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
3383
3384         * DumpRenderTree/mac/DumpRenderTree.mm:
3385         (resetWebPreferencesToConsistentValues):
3386         * DumpRenderTree/win/DumpRenderTree.cpp:
3387         (enableExperimentalFeatures):
3388         * WebKitTestRunner/TestController.cpp:
3389         (WTR::TestController::resetPreferencesToConsistentValues):
3390
3391 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3392
3393         results.webkit.org: Cache archive content
3394         https://bugs.webkit.org/show_bug.cgi?id=207589
3395
3396         Reviewed by Aakash Jain.
3397
3398         * resultsdbpy/resultsdbpy/flask_support/util.py:
3399         (cache_for): Add decorator function which sets the cache values on the returned response.
3400         * resultsdbpy/resultsdbpy/view/archive_view.py:
3401         (ArchiveView): Cache archive content client-side for 12 hours.
3402         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
3403         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
3404
3405 2020-02-12  Youenn Fablet  <youenn@apple.com>
3406
3407         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3408         https://bugs.webkit.org/show_bug.cgi?id=207537
3409
3410         Reviewed by Chris Dumez.
3411
3412         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3413
3414 2020-02-11  Rob Buis  <rbuis@igalia.com>
3415
3416         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
3417         <https://webkit.org/b/207424>
3418         <rdar://problem/59250384>
3419
3420         Reviewed by Rob Buis.
3421
3422         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3423         (TestWebKitAPI::TEST): Add more tests.
3424
3425 2020-02-11  Commit Queue  <commit-queue@webkit.org>
3426
3427         Unreviewed, rolling out r256314.
3428         https://bugs.webkit.org/show_bug.cgi?id=207594
3429
3430         It is breaking an API test (Requested by youenn on #webkit).
3431
3432         Reverted changeset:
3433
3434         "WebSWServerConnection::registerServiceWorkerClient is not
3435         sending IPC message to UIProcess when it should"
3436         https://bugs.webkit.org/show_bug.cgi?id=207537
3437         https://trac.webkit.org/changeset/256314
3438
3439 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
3440
3441         results.webkit.org: Configuration documentation should include architecture
3442         https://bugs.webkit.org/show_bug.cgi?id=207584
3443
3444         Reviewed by Aakash Jain.
3445
3446         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
3447
3448 2020-02-11  Youenn Fablet  <youenn@apple.com>
3449
3450         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
3451         https://bugs.webkit.org/show_bug.cgi?id=207325
3452         <rdar://problem/59224810>
3453
3454         Reviewed by Eric Carlson.
3455
3456         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
3457         (TestWebKitAPI::TEST):
3458         Add a test validating that RTCRtpSender.getCapabilities does not return null.
3459         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3460
3461 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3462
3463         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
3464         https://bugs.webkit.org/show_bug.cgi?id=207557
3465
3466         Reviewed by Jonathan Bedard.
3467
3468         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
3469         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
3470         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
3471         around this by focusing an empty select element instead (for which we won't attempt to create and select any
3472         table view cells).
3473
3474         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3475
3476 2020-02-11  Alex Christensen  <achristensen@webkit.org>
3477
3478         Add WKHTTPCookieStore._getCookiesForURL SPI
3479         https://bugs.webkit.org/show_bug.cgi?id=207527
3480
3481         Reviewed by Brady Eidson.
3482
3483         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3484         (TEST):
3485
3486 2020-02-11  Youenn Fablet  <youenn@apple.com>
3487
3488         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3489         https://bugs.webkit.org/show_bug.cgi?id=207537
3490
3491         Reviewed by Chris Dumez.
3492
3493         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3494
3495 2020-02-11  Lauro Moura  <lmoura@igalia.com>
3496
3497         [WPE][WebDriver] MiniBrowser should react to close session commands
3498         https://bugs.webkit.org/show_bug.cgi?id=207529
3499
3500         Reviewed by Carlos Garcia Campos.
3501
3502         WebDriver delete session command asks to close the WebView associated to the
3503         current automation session. We must react to it to avoid lots of
3504         timeouts and errors.
3505
3506         * MiniBrowser/wpe/main.cpp:
3507         (main): Listen to "close" signal on the main WebView.
3508
3509 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3510
3511         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
3512         https://bugs.webkit.org/show_bug.cgi?id=207525
3513         <rdar://problem/59110543>
3514
3515         Reviewed by Tim Horton.
3516
3517         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
3518         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
3519         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
3520         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
3521         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
3522         causing us to crash upon trying to create the dictionary.
3523
3524         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
3525         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
3526         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
3527         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
3528         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
3529         beginning of each API test.
3530
3531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3532         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3533         (overrideBundleIdentifier):
3534
3535         Move this to the top of the file, so it can be shared.
3536
3537         (+[WKWebView initialize]):
3538
3539         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
3540         internal class method that calls into the internal helper function, with no other side effects.
3541
3542         * TestWebKitAPI/ios/UIKitSPI.h:
3543
3544 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3545
3546         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
3547         https://bugs.webkit.org/show_bug.cgi?id=207501
3548         <rdar://problem/59323414>
3549
3550         Reviewed by Alex Christensen.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
3553         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
3554         The same behavior.
3555
3556 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
3557
3558         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
3559         https://bugs.webkit.org/show_bug.cgi?id=207352
3560         <rdar://problem/59115798>
3561
3562         Reviewed by Alex Christensen.
3563
3564         Add a test to exercise the new SPI.
3565
3566         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
3567         a webpage that contains text in subframes.
3568
3569
3570 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3571
3572         [iOS] Crash when granting access to asset services
3573         https://bugs.webkit.org/show_bug.cgi?id=207520
3574
3575         Reviewed by Brent Fulgham.
3576
3577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3578         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
3579         (TEST):
3580
3581 2020-02-10  Chris Dumez  <cdumez@apple.com>
3582
3583         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
3584         https://bugs.webkit.org/show_bug.cgi?id=207481
3585
3586         Reviewed by Alexey Proskuryakov.
3587
3588         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
3589         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
3590         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
3591
3592         * DumpRenderTree/mac/DumpRenderTree.mm:
3593         (resetWebViewToConsistentStateBeforeTesting):
3594         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
3595         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
3596         over internal settings.
3597
3598 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3599
3600         [watchOS] Notification listener is never unregistered
3601         https://bugs.webkit.org/show_bug.cgi?id=207459
3602
3603         Reviewed by Maciej Stachowiak.
3604
3605         Add a test which tests that posting a backlight level change notification will not cause a crash.
3606
3607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3608         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
3609         (TEST):
3610
3611 2020-02-10  James Howard  <jameshoward@mac.com>
3612
3613         Standard gamepad mapping for GameControllerGamepads
3614         https://bugs.webkit.org/show_bug.cgi?id=206033
3615
3616         Reviewed by Dean Jackson.
3617
3618         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3619         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3620         (WTR::TestRunner::setMockGamepadDetails):
3621         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3622         * WebKitTestRunner/TestInvocation.cpp:
3623         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3624
3625 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3626
3627         [ews] Display flaky layout test names in build summary
3628         https://bugs.webkit.org/show_bug.cgi?id=207504
3629
3630         Reviewed by Jonathan Bedard.
3631
3632         * BuildSlaveSupport/ews-build/steps.py:
3633         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
3634         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
3635         (AnalyzeLayoutTestsResults.start):
3636
3637 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3638
3639         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
3640         https://bugs.webkit.org/show_bug.cgi?id=207492
3641
3642         Reviewed by Jonathan Bedard.
3643
3644         * BuildSlaveSupport/ews-build/steps.py:
3645         (RunWebKitTests.evaluateCommand):
3646         (ReRunWebKitTests.evaluateCommand):
3647         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3648         * BuildSlaveSupport/ews-build/factories.py:
3649         (TestFactory.__init__):
3650
3651 2020-02-10  Truitt Savell  <tsavell@apple.com>
3652
3653         Unreviewed, rolling out r256091.
3654
3655         Broke internal builds
3656
3657         Reverted changeset:
3658
3659         "Move trivial definitions from FeatureDefines.xcconfig to
3660         PlatformEnableCocoa.h"
3661         https://bugs.webkit.org/show_bug.cgi?id=207155
3662         https://trac.webkit.org/changeset/256091
3663
3664 2020-02-10  Truitt Savell  <tsavell@apple.com>
3665
3666         Unreviewed, rolling out r256103.
3667
3668         This patch is blocking the rollout of r256091
3669
3670         Reverted changeset:
3671
3672         "Move JavaScriptCore related feature defines from
3673         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
3674         https://bugs.webkit.org/show_bug.cgi?id=207436
3675         https://trac.webkit.org/changeset/256103
3676
3677 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3678
3679         results.webkit.org: Abstract archive storage solutions
3680         https://bugs.webkit.org/show_bug.cgi?id=207277
3681
3682         Rubber-stamped by Aakash Jain.
3683
3684         * resultsdbpy/resultsdbpy/model/archive_context.py:
3685         (ArchiveContext):
3686         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
3687         (ArchiveContext.__init__): Add archiver member.
3688         (ArchiveContext.__enter__): archiver is a context manager.
3689         (ArchiveContext.__exit__): Ditto.
3690         (ArchiveContext.register): The archiver member owns saving an archive.
3691         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
3692         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
3693         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
3694         (Archiver): Base class for all Archiving systems.
3695         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
3696         (Archiver.archive_size): Given a file-like archive, calculate it's size.
3697         (Archiver.save):
3698         (Archiver.retrieve):
3699         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
3700         (CassandraArchiver):
3701         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
3702         (CassandraArchiver.__init__):
3703         (CassandraArchiver.__enter__):
3704         (CassandraArchiver.__exit__):
3705         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
3706         from ArchiveContext.
3707         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
3708         from ArchiveContext.
3709
3710 2020-02-09  Lauro Moura  <lmoura@igalia.com>
3711
3712         [GTK][WPE] Expose allowTopNavigationToDataURL
3713         https://bugs.webkit.org/show_bug.cgi?id=207384
3714
3715         Reviewed by Adrian Perez de Castro.
3716
3717         Updates with new "allow-top-navigation-to-data-urls" property.
3718
3719         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3720         (testWebViewAllowModalDialogs): This test requires this property to be
3721         set.
3722         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3723         (testWebKitSettings): Added tests for getter/setter.
3724
3725 2020-02-08  Sam Weinig  <weinig@apple.com>
3726
3727         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3728         https://bugs.webkit.org/show_bug.cgi?id=207436
3729
3730         Reviewed by Tim Horton.
3731
3732         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3733         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
3734
3735 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
3736
3737         [WTF] Try using 75% load factor for HashTable
3738         https://bugs.webkit.org/show_bug.cgi?id=207183
3739
3740