dffb30afcee6dd8befa97a6eb1e8ffbab2e82c4a
[WebKit.git] / Tools / ChangeLog
1 2011-02-03  Adam Roben  <aroben@apple.com>
2
3         Add links to Windows crash logs in results.html
4
5         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
6         results.html
7
8         Reviewed by David Kilzer.
9
10         * Scripts/old-run-webkit-tests:
11         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
12         createDebuggerCommandFile).
13         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
14         tool has exited.
15         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
16         it into the test results directory tree. Only implemented for Cygwin currently.
17         (findNewestFileMatchingGlob): Added. Does what it says.
18         (htmlForResultsSection): Only link to files that exist.
19         (linksForErrorTest): Add a link to the crash log.
20         (deleteExpectedAndActualResults): Delete any old crash log for this test.
21         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
22         hardcoding it here.
23
24 2011-02-03  Adam Roben  <aroben@apple.com>
25
26         Tell the debugger the path to the WebKit source tree when saving a crash log
27
28         This allows the debugger to include the crashing line of code in the log.
29
30         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
31         of code
32
33         Reviewed by Sam Weinig.
34
35         * Scripts/old-run-webkit-tests:
36         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
37         file and returns the path to that file. The commands we pass came from
38         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
39         WebKit source code lives.
40         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
41         line using -c, save them to a file and specify the path to that file using -cf. This works
42         around what is presumably a bug in Windows's command line parsing, where having multiple
43         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
44         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
45         together to make them easier to modify in the future.
46
47 2011-02-02  Sam Weinig  <sam@webkit.org>
48
49         Reviewed by Anders Carlsson.
50
51         Add notification of the end of a rubber band.
52         <rdar://problem/8940648>
53
54         * MiniBrowser/mac/BrowserWindowController.m:
55         (-[BrowserWindowController awakeFromNib]):
56         * WebKitTestRunner/TestController.cpp:
57         (WTR::TestController::createOtherPage):
58         (WTR::TestController::initialize):
59         Stub out the new WKUIClient function.
60
61 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
62
63         Unreviewed.
64
65         Adding myself to committers.py.
66
67         * Scripts/webkitpy/common/config/committers.py:
68
69 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
70
71         Reviewed by Csaba Osztrogonác.
72
73         [Qt][WK2] MiniBrowser's window size should be 800x600
74         https://bugs.webkit.org/show_bug.cgi?id=53670
75
76         Make layout test failure debugging easier.
77         * MiniBrowser/qt/BrowserWindow.cpp:
78         (BrowserWindow::BrowserWindow):
79
80 2011-02-02  Andy Estes  <aestes@apple.com>
81
82         Reviewed by Mark Rowe.
83
84         'update-webkit' should handle OpenSource and Internal using different
85         VCSs.
86
87         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
88         Internal directory.
89
90 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
91
92         Reviewed by Mihai Parparita.
93
94         new-run-webkit-tests: hardcode the directories to scan for tests
95         for GPU bots instead of SKIPping them. See bug 53562 for some
96         context, but we will now hard-code the list of directories to
97         use by default instead of skipping over directories in the
98         expectations file. We do this so that we will be able to merge
99         the expectations files without getting conflicting SKIP
100         directives. Note that this change will reduce the # of tests
101         being run on the Mac GPU bots, because we're accidentally
102         including some today.
103
104         https://bugs.webkit.org/show_bug.cgi?id=53631
105
106         * Scripts/webkitpy/layout_tests/port/base.py:
107         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
108         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
109
110 2011-02-02  Sam Weinig  <sam@webkit.org>
111
112         Reviewed by Beth Dakin.
113
114         Add ChromeClient function to paint custom overhang areas.
115         https://bugs.webkit.org/show_bug.cgi?id=53639
116
117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
118         (WTR::InjectedBundlePage::InjectedBundlePage):
119         Stub out new callback.
120
121 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
122
123         Reviewed by Tony Chang.
124
125         new-run-webkit-tests: support chromium code paths in mock_drt
126
127         https://bugs.webkit.org/show_bug.cgi?id=53471
128
129         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
130         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
131
132 2011-02-02  Adam Klein  <adamk@chromium.org>
133
134         Reviewed by Tony Chang.
135
136         Update new-run-webkit-tests --chromium to put output under Source/...
137         https://bugs.webkit.org/show_bug.cgi?id=53612
138
139         * BuildSlaveSupport/test-result-archive:
140         * Scripts/webkitpy/layout_tests/port/chromium.py:
141
142 2011-01-28  Tony Chang  <tony@chromium.org>
143
144         Reviewed by Eric Seidel.
145
146         [chromium] remove --use-test-shell from NRWT
147         https://bugs.webkit.org/show_bug.cgi?id=53346
148
149         I've already started removing some of the bindings like eventSender so
150         this already doesn't work isn't useful.  Also updated some comments to
151         refer to DRT instead of test_shell.
152
153         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
154         * Scripts/webkitpy/layout_tests/port/chromium.py:
155         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
156         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
157         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
158         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
159         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
160         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
161
162 2011-02-02  Steve Lacey  <sjl@chromium.org>
163
164         Reviewed by Eric Carlson.
165
166         Implement basic media statistics on media elements.
167         https://bugs.webkit.org/show_bug.cgi?id=53322
168
169         * Scripts/build-webkit:
170
171 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
172
173         [wx] Build fixes for wxWebKit.
174
175         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
176         (LayoutTestController::setSerializeHTTPLoads):
177         * wx/browser/wscript:
178         * wx/build/build_utils.py:
179         * wx/build/settings.py:
180
181 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
182
183         Reviewed by Mihai Parparita.
184
185         new-run-webkit-tests: stop skipping so many tests
186
187         r77163 introduced a regression where we weren't resetting test
188         expectations properly and were skipping too many tests as a
189         result. This patch fixes that and adds a test for it.
190
191         https://bugs.webkit.org/show_bug.cgi?id=53551
192
193         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
194         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
195
196 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
197
198         Reviewed by Tony Chang.
199
200         new-run-webkit-tests: add first stub of test_runner2. This
201         will add support for the 'inline', 'threads', and 'processes'
202         flags to --worker-model, but for now the implementatios just
203         fall back on the old ones.
204
205         https://bugs.webkit.org/show_bug.cgi?id=53157
206
207         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
208         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
209
210 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
211
212         Reviewed by James Robinson.
213
214         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
215         https://bugs.webkit.org/show_bug.cgi?id=53522
216
217         * Scripts/run-chromium-webkit-unit-tests:
218
219 2011-02-01  Adam Barth  <abarth@webkit.org>
220
221         Reviewed by Mihai Parparita.
222
223         Using Control-C to cancel webkit-patch or other python tools causes
224         unpleasant traceback console spew
225         https://bugs.webkit.org/show_bug.cgi?id=53462
226
227         Catch the exception and don't print the stack trace.
228
229         * Scripts/webkit-patch:
230
231 2011-02-01  Scott Cameron  <sccameron@rim.com>
232
233         Reviewed by Daniel Bates.
234
235         Use Windows format for MinGW HTTPD path.
236         https://bugs.webkit.org/show_bug.cgi?id=53503
237
238         * Scripts/webkitperl/httpd.pm:
239           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
240             so that we don't have to escape the space characters in the path. Also,
241             changed path to Windows-style path and removed FIXME comment.
242
243 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
244
245         Reviewed by Andreas Kling.
246
247         [Qt][WK2] Add a way to use shared process model in MiniBrowser
248         https://bugs.webkit.org/show_bug.cgi?id=53090
249
250         * MiniBrowser/qt/BrowserView.cpp:
251         (BrowserView::BrowserView): Removed the m_context member.
252         From now the context is guaranteed to be non-null and we
253         don't need to store that in the object.
254         * MiniBrowser/qt/BrowserView.h:
255         * MiniBrowser/qt/BrowserWindow.cpp:
256         Added static bool to determine that new windows need to be
257         created with their own context or not. Use the same context
258         and web process by default to be inilne with the other ports.
259         (BrowserWindow::BrowserWindow):
260         (BrowserWindow::newWindow):
261         * MiniBrowser/qt/BrowserWindow.h:
262         * MiniBrowser/qt/main.cpp:
263         (main): Added command line switch to be able to use the
264         non-shared process model. Simplify the handling of the command line
265         switches a little bit.
266
267 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
268
269         Reviewed by Andreas Kling.
270
271         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
272         https://bugs.webkit.org/show_bug.cgi?id=53491
273
274         * MiniBrowser/qt/BrowserWindow.cpp:
275         (BrowserWindow::BrowserWindow):
276         (BrowserWindow::toggleFullScreenMode):
277         * MiniBrowser/qt/BrowserWindow.h:
278
279 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
280
281         Reviewed by Andreas Kling.
282
283         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
284         https://bugs.webkit.org/show_bug.cgi?id=53489
285
286         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
287         to Settings menu.
288
289         * MiniBrowser/qt/BrowserWindow.cpp:
290         (BrowserWindow::BrowserWindow):
291         (BrowserWindow::toggleFrameFlattening):
292         (BrowserWindow::toggleDisableJavaScript):
293         (BrowserWindow::toggleAutoLoadImages):
294         * MiniBrowser/qt/BrowserWindow.h:
295
296 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
297
298         Reviewed by Tony Chang.
299
300         [Chromium] Switch chromium-mac to use ChromiumDriver
301         https://bugs.webkit.org/show_bug.cgi?id=53461
302         
303         For the sake of consistency with the other Chromium platforms (and so
304         that chromium-mac picks up special flags like --enable-hardware-gpu),
305         switch chromium-mac from the WebKitDriver to ChromiumDriver.
306
307         * Scripts/webkitpy/layout_tests/port/chromium.py:
308
309 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
310
311         Reviewed by Mihai Parparita.
312
313         The current modifier parsing code in test_expectations is
314         fragile and hard-coded, so it's not easy to understand the logic
315         or easily add new types of modifiers (like GPU vs. CPU testing
316         for graphics tests, or 32-bit vs. 64-bit differences).
317
318         This is the first of two patches that will add in more generic
319         support and then eliminate the GPU-specific test expectations
320         files for Chromium.
321
322         This patch adds two standalone objects for handling modifiers. The
323         rules for interpreting modifiers, precedence, and conflicts are
324         given in the docstring to the ModifierMatcher class, which
325         returns ModifierMatchResult objects.
326         
327         This patch also adds routines to the Port interface and a
328         default set of values in the base object, in order to obtain the
329         values needed on a given test run. These values are then passed
330         to the expectation parser. This also allows us to clean up the
331         logic used to lint all of the different configurations in a
332         single test_expectations.txt file.
333
334         The next patch will merge in the separate GPU expectations file.
335
336         https://bugs.webkit.org/show_bug.cgi?id=51222
337
338         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
339         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
340         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
341         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
342         * Scripts/webkitpy/layout_tests/port/base.py:
343         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
344         * Scripts/webkitpy/layout_tests/port/chromium.py:
345         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
346         * Scripts/webkitpy/layout_tests/port/test.py:
347         * Scripts/webkitpy/layout_tests/port/webkit.py:
348         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
349         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
350         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
351         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
352         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
353
354 2011-01-31  Scott Cameron  <sccameron@rim.com>
355
356         Reviewed by Daniel Bates.
357
358         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
359         https://bugs.webkit.org/show_bug.cgi?id=50036
360
361         This will add an Apache2.2 configuration file and modifies scripts to allow
362         running an httpd server in an MSYS environment.
363
364         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
365         in order to allow for simple installation/execution.  Simply install the latest
366         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
367         be able to execute run-webkit-httpd.
368         
369
370         * Scripts/run-webkit-httpd:
371         * Scripts/webkitperl/httpd.pm:
372
373 2011-01-31  Tony Chang  <tony@chromium.org>
374
375         Reviewed by Eric Seidel.
376
377         mac DRT should report RTL scroll offset relative to top right corner
378         https://bugs.webkit.org/show_bug.cgi?id=53324
379
380         * DumpRenderTree/mac/DumpRenderTree.mm:
381         (dumpFrameScrollPosition):
382
383 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
384
385         Reviewed by Andreas Kling.
386
387         [Qt] Add Take Screen Shot action to MiniBrowser
388         https://bugs.webkit.org/show_bug.cgi?id=53422
389
390         Add Take Screen Shot action to MiniBrowser's view menu.
391
392         * MiniBrowser/qt/BrowserWindow.cpp:
393         (BrowserWindow::BrowserWindow):
394         (BrowserWindow::screenshot):
395         * MiniBrowser/qt/BrowserWindow.h:
396
397 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
398
399         Reviewed by Xan Lopez.
400
401         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
402         https://bugs.webkit.org/show_bug.cgi?id=53379
403
404         Remove left over #ifdef's. I thought all of the conditional code
405         had been freed from the condition, but I forgot to check DRT.
406
407         * DumpRenderTree/gtk/DumpRenderTree.cpp:
408         (resetDefaultsToConsistentValues):
409         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
410         (LayoutTestController::setAlwaysAcceptCookies):
411
412 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
413
414         Unreviewed, build fix.
415
416         Fix regression introduced in r77093 - path.rsplit() doesn't
417         take keyword arguments.
418
419         https://bugs.webkit.org/show_bug.cgi?id=53326
420
421         * Scripts/webkitpy/common/system/filesystem_mock.py:
422
423 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
424
425         Reviewed by Mihai Parparita.
426
427         Add more unit tests for rebaseline-chromium-webkit-tests. This
428         change involves restructuring a bunch of r-c-w-t code to make it
429         more testable as well. We also add wrapper classes for handling
430         testing zip files and fetching URLs.
431
432         https://bugs.webkit.org/show_bug.cgi?id=53040
433
434         * Scripts/webkitpy/common/system/urlfetcher.py:
435         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
436         * Scripts/webkitpy/common/system/zipfileset_mock.py:
437         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
438         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
439         * Scripts/webkitpy/tool/mocktool.py:
440
441 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
442
443         Reviewed by Eric Seidel.
444
445         Clean up of the filesystem-related modules used in webkitpy.
446         I've added relpath() to the filesystem interface, modified
447         ospath.relpath() so that it could work with the filesystem
448         interface, and modified the fileset* routines to use the
449         filesystem interface consistently.
450
451         This patch also adds a close() routine to the fileset routines
452         to indicate that the caller is done with the fileset. This
453         allows zipfileset to clean up after itself when it creates
454         tempfiles to store downloads.
455
456         https://bugs.webkit.org/show_bug.cgi?id=53326
457
458         * Scripts/webkitpy/common/system/directoryfileset.py:
459         * Scripts/webkitpy/common/system/fileset.py:
460         * Scripts/webkitpy/common/system/filesystem.py:
461         * Scripts/webkitpy/common/system/filesystem_mock.py:
462         * Scripts/webkitpy/common/system/filesystem_unittest.py:
463         * Scripts/webkitpy/common/system/ospath.py:
464         * Scripts/webkitpy/common/system/zipfileset.py:
465         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
466
467 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
468
469         Reviewed by Csaba Osztrogonác.
470
471         [Qt][WK2]REGRESSION (r76991): Fix build errors
472         https://bugs.webkit.org/show_bug.cgi?id=53400
473
474         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
475         and remove WebKit2Prefix.h from the build.
476         * MiniBrowser/qt/MiniBrowser.pro:
477
478 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
479
480         Unreviewed.
481
482         [Qt][WK2] Buildfix.
483
484         * MiniBrowser/qt/MiniBrowser.pro:
485
486 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
487
488         Reviewed by Adam Roben.
489         
490         define NOMINMAX when building ImageDiff, as we do elsewhere.
491
492         Add various clampToInt() methods to MathExtras.h
493         https://bugs.webkit.org/show_bug.cgi?id=52910
494
495         * DumpRenderTree/win/ImageDiffCommon.vsprops:
496
497 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
498
499         Reviewed by Darin Adler.
500
501         WebKitTestRunner needs layoutTestController.setPOSIXLocale
502         https://bugs.webkit.org/show_bug.cgi?id=42682
503
504         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
505         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
506         (WTR::InjectedBundle::resetLocalSettings):
507         (WTR::InjectedBundle::didReceiveMessage):
508         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
509         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
510         (WTR::LayoutTestController::setPOSIXLocale):
511         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
512
513 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
514  
515          Reviewed by Mihai Parparita.
516  
517          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
518  
519          This patch re-enables this test and changes it to
520          handle all of the mac platform versions, not just the one
521          it is running on.
522  
523          https://bugs.webkit.org/show_bug.cgi?id=53356
524  
525          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
526  
527 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
528
529         Unreviewed, build fix.
530
531         Take two. The fix in 77023 didn't work, because we were
532         still calling path.abspath_to_uri, which calls _cygpath under
533         the covers, and it appears the cygpath on the bots does
534         something different than it does on my machine. This patch
535         removes the calls to path.abspath_to_uri, so it should be safe.
536         If it doesn't work, I'll roll it out along with r76982 and 77023.
537
538         https://bugs.webkit.org/show_bug.cgi?id=53126
539
540         * Scripts/webkitpy/layout_tests/port/test.py:
541
542 2011-01-28  David Kilzer  <ddkilzer@apple.com>
543
544         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
545         <http://webkit.org/b/53353>
546
547         Reviewed by Mark Rowe.
548
549         * Scripts/webkitdirs.pm:
550         (checkRequiredSystemConfig): Check the Xcode marketing version
551         in addition to the DevCoreTools build version before complaining
552         about an old version of Xcode.  Also make the Mac OS X version
553         check use Perl's built-in version string comparitor.
554
555 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
556
557         Unreviewed, build fix.
558
559         Work around breakage on Win 7 Release bot caused by r76982
560         and the fact that windows ports use "file:////" instead of
561         "file:///". Ideally the test code should be isolated from
562         this, but it isn't yet. Will fix properly in a bit.
563
564         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
565
566 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
567
568         Reviewed by Tony Chang.
569
570         new-run-webkit-tests: change worker model values to
571         "old-inline", "old-threads" in preparation for test_runner2 /
572         multiprocessing changes.
573
574         https://bugs.webkit.org/show_bug.cgi?id=53156
575
576         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
577         * Scripts/webkitpy/layout_tests/port/base.py:
578         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
579         * Scripts/webkitpy/layout_tests/port/mac.py:
580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
581
582 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
583
584         Reviewed by Tony Chang.
585
586         committers.py - add an IRC nickname for dpranke
587         https://bugs.webkit.org/show_bug.cgi?id=53335
588
589         * Scripts/webkitpy/common/config/committers.py:
590
591 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
592
593         Reviewed by Tony Chang.
594
595         new-run-webkit-tests: add a "mock DRT" port implementation
596         and a separate class that emulates what we expect the
597         DumpRenderTree behavior to be.
598
599         This will eventually replace port/dryrun.py and allow us to get
600         better test coverage of the new-run-webkit-tests code as well as
601         a reference for what new-run-webkit-tests expects from DRT.
602
603         This is the first attempt at this, and it is pretty bare-boned. It
604         really only has been tested on the 'mac' port (and a little on
605         the 'chromium-mac' port.
606
607         https://bugs.webkit.org/show_bug.cgi?id=53126
608
609         * Scripts/webkitpy/common/system/filesystem_mock.py:
610         * Scripts/webkitpy/layout_tests/port/dryrun.py:
611         * Scripts/webkitpy/layout_tests/port/factory.py:
612         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
613         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
614         * Scripts/webkitpy/layout_tests/port/test.py:
615
616 2011-01-28  Pratik Solanki  <psolanki@apple.com>
617
618         Unreviewed. Removing .swp file checked in by mistake.
619
620         * Scripts/.webkitdirs.pm.swp: Removed.
621
622 2011-01-28  Pratik Solanki  <psolanki@apple.com>
623
624         Reviewed by David Kilzer.
625
626         Space not necessary for undefined feature
627         https://bugs.webkit.org/show_bug.cgi?id=53317
628
629         * Scripts/build-webkit:
630
631 2011-01-28  Chang Shu  <chang.shu@nokia.com>
632
633         Reviewed by Andreas Kling.
634
635         Reset NetworkAccessManager to clean up credentials from previous tests.
636         This change causes no performance overhead either.
637         https://bugs.webkit.org/show_bug.cgi?id=36688
638
639         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
640         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
641         (WebCore::DumpRenderTree::open):
642         * DumpRenderTree/qt/DumpRenderTreeQt.h:
643
644 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
645
646         Reviewed by Andreas Kling.
647
648         [Qt] Add Zoom Text Only action to MiniBrowser
649         https://bugs.webkit.org/show_bug.cgi?id=53297
650
651         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
652
653         * MiniBrowser/qt/BrowserWindow.cpp:
654         (BrowserWindow::BrowserWindow):
655         (BrowserWindow::zoomIn):
656         (BrowserWindow::zoomOut):
657         (BrowserWindow::resetZoom):
658         (BrowserWindow::toggleZoomTextOnly):
659         (BrowserWindow::applyZoom):
660         * MiniBrowser/qt/BrowserWindow.h:
661
662 2011-01-28  Adam Barth  <abarth@webkit.org>
663
664         Reviewed by Eric Seidel.
665
666         Add webkit-patch roll-chromium-deps
667         https://bugs.webkit.org/show_bug.cgi?id=53288
668
669         This command updates the Source/WebKit/chromium/DEPS file with the
670         last-known good revision of Chromium (or a revision specified on the
671         command line).  I'd eventually like to turn this into a SheriffBot
672         command, but this is the first step.
673
674         This patch somewhat sprawled because I needed to move a bunch of code
675         out of ChangeLog that should never have been there in the first place.
676         Also, I had to fix a bug in MockUser in order to test the new command.
677
678         * Scripts/webkitpy/common/checkout/api.py:
679         * Scripts/webkitpy/common/checkout/changelog.py:
680         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
681         * Scripts/webkitpy/common/checkout/deps.py: Added.
682         * Scripts/webkitpy/common/config/urls.py:
683         * Scripts/webkitpy/tool/commands/__init__.py:
684         * Scripts/webkitpy/tool/commands/download_unittest.py:
685         * Scripts/webkitpy/tool/commands/roll.py: Added.
686         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
687         * Scripts/webkitpy/tool/commands/upload_unittest.py:
688         * Scripts/webkitpy/tool/mocktool.py:
689         * Scripts/webkitpy/tool/steps/__init__.py:
690         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
691         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
692         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
693         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
694         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
695         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
696
697 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
698
699         Reviewed by Laszlo Gombos.
700
701         Get rid of prefix header dependency for WebKit2 build system
702         https://bugs.webkit.org/show_bug.cgi?id=50174
703
704         Change the style checker so that it enforces config.h include for
705         WebKit2.
706
707         * Scripts/webkitpy/style/checker.py:
708
709 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
710
711         Reviewed by Darin Adler.
712
713         execCommand("Paste") doesn't work in WebKitTestRunner
714         https://bugs.webkit.org/show_bug.cgi?id=52785
715
716         Enable both of the settings needed to allow paste.
717         
718         * WebKitTestRunner/TestController.cpp:
719         (WTR::TestController::resetStateToConsistentValues):
720
721 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
722
723         Reviewed by Andreas Kling.
724
725         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
726         https://bugs.webkit.org/show_bug.cgi?id=48440
727
728         Preserve user input when toggling use of QGraphicsView
729
730         * QtTestBrowser/launcherwindow.cpp:
731         (LauncherWindow::initializeView):
732         (LauncherWindow::loadFinished):
733         * QtTestBrowser/launcherwindow.h:
734         * QtTestBrowser/mainwindow.cpp:
735         (MainWindow::addressUrl):
736         * QtTestBrowser/mainwindow.h:
737
738 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
739
740         Reviewed by Mihai Parparita.
741
742         new-run-webkit-tests: turn off pixel tests correctly by default
743         for webkit-based ports. r70013 (bug 47510) used
744         port.set_option_default() to attempt to set default values, but
745         that didn't work correctly. I have removed set_option_default
746         for now since it was only being used in two places and in three
747         useless unit tests. There is a separate bug open to fix the
748         option parsing (48095), so this workaround is fine for now.
749
750         https://bugs.webkit.org/show_bug.cgi?id=53217
751
752         * Scripts/webkitpy/layout_tests/port/webkit.py:
753         * Scripts/webkitpy/layout_tests/port/base.py:
754         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
755
756 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
757
758         Rubber-stamped by Ariya Hidayat.
759
760         Trivial crash fix in WTR.
761
762         * WebKitTestRunner/TestController.cpp:
763         (WTR::TestController::initialize): Increase the size
764         of the vector by one to be able to store the null character.
765
766 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
767
768         Reviewed by Csaba Osztrogonác.
769
770         [Qt][WK2] WTR should be initialized in the same way as DRT
771         https://bugs.webkit.org/show_bug.cgi?id=53240
772
773         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
774         (WTR::activateFonts): Added missing initialization steps.
775
776 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
777
778         Unreviewed. 
779
780         Adding myself to committers.py.
781
782         * Scripts/webkitpy/common/config/committers.py:
783
784 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
785
786         Reviewed by Csaba Osztrogonác.
787
788         [Qt] [Symbian] Move project files into Source
789         https://bugs.webkit.org/show_bug.cgi?id=52891
790
791         Fix the Symbian build after the project files
792         are moved to Source directory. On Symbian qmake
793         needs to run in the same directory where the main
794         pro files (WebKit.pro, Tools.pro) are located.
795
796         * Scripts/webkitdirs.pm: Change to the directory where the pro file
797         is located before running qmake for Symbian. Qmake on Symbian
798         does not properly honor the "-o" option, work it around by setting
799         the name of the Makefile to bld.inf.
800
801 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
802
803         Reviewed by Andreas Kling.
804
805         [Qt] Add simple zooming features to MiniBrowser
806         https://bugs.webkit.org/show_bug.cgi?id=53231
807
808         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
809
810         * MiniBrowser/qt/BrowserWindow.cpp:
811         (BrowserWindow::BrowserWindow):
812         (BrowserWindow::zoomIn):
813         (BrowserWindow::zoomOut):
814         (BrowserWindow::resetZoom):
815         (BrowserWindow::updateUserAgentList):
816         (BrowserWindow::applyZoom):
817         * MiniBrowser/qt/BrowserWindow.h:
818
819 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
820
821         Reviewed by Dan Bernstein.
822
823         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
824         https://bugs.webkit.org/show_bug.cgi?id=42319
825         
826         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
827
828         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
829         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
830         (WTR::LayoutTestController::showWebInspector):
831         (WTR::LayoutTestController::closeWebInspector):
832         (WTR::LayoutTestController::evaluateInWebInspector):
833         (WTR::LayoutTestController::setTimelineProfilingEnabled):
834         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
835         * WebKitTestRunner/TestInvocation.cpp:
836         (WTR::shouldOpenWebInspector):
837         (WTR::TestInvocation::invoke):
838         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
839
840 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
841
842         Reviewed by Xan Lopez.
843
844         [GTK] Pixel dumps do not include scrollbars in output images
845         https://bugs.webkit.org/show_bug.cgi?id=53216
846
847         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
848         that have scrollbars.
849
850         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
851         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
852         instead of the web view itself.
853
854 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
855
856         Reviewed by Mihai Parparita.
857
858         Fix regression introduced in r76322 ... new-run-webkit-tests
859         was attempting to save the image diff output as a UTF-8-encoded
860         file.
861
862         https://bugs.webkit.org/show_bug.cgi?id=53210
863
864         * Scripts/webkitpy/layout_tests/port/webkit.py:
865
866 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
867
868         Unreviewed, rolling out r76709.
869         http://trac.webkit.org/changeset/76709
870         https://bugs.webkit.org/show_bug.cgi?id=53194
871
872         "broke python tests on non-snowleopard platforms" (Requested
873         by dpranke on #webkit).
874
875         * Scripts/webkitpy/layout_tests/port/factory.py:
876         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
877         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
878
879 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
880
881         Reviewed by Tony Chang.
882
883         new-run-webkit-tests: add a "mock DRT" port implementation
884         and a separate class that emulates what we expect the
885         DumpRenderTree behavior to be.
886
887         This will eventually replace port/dryrun.py and allow us to get
888         better test coverage of the new-run-webkit-tests code as well as
889         a reference for what new-run-webkit-tests expects from DRT.
890
891         This is the first attempt at this, and it is pretty bare-boned. It
892         really only has been tested on the 'mac' port (and a little on
893         the 'chromium-mac' port.
894
895         https://bugs.webkit.org/show_bug.cgi?id=53126
896
897         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
898         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
899         * Scripts/webkitpy/layout_tests/port/factory.py:
900
901 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
902
903         Reviewed by Tony Chang.
904
905         Add '--no-timeout' option to Chromium DRT to ease debugging.
906         https://bugs.webkit.org/show_bug.cgi?id=52873
907
908         * DumpRenderTree/chromium/DumpRenderTree.cpp:
909         (main):
910
911 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
912
913         Reviewed by Andreas Kling.
914
915         [Qt] Fix qt_minimal build
916         https://bugs.webkit.org/show_bug.cgi?id=53172
917
918         * QtTestBrowser/locationedit.h:
919
920 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
921
922         Reviewed by Antonio Gomes.
923
924         QtTestBrowser should have a UI Setting to disable plugins
925         https://bugs.webkit.org/show_bug.cgi?id=52408
926         
927         Added a new action item named "Disable Plugins"
928         under the "Settings" menu. 
929
930         * QtTestBrowser/launcherwindow.cpp:
931         (LauncherWindow::createChrome):
932         (LauncherWindow::togglePlugins):
933         * QtTestBrowser/launcherwindow.h:
934
935 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
936
937         Reviewed by Adam Barth.
938
939         Move main CMakeLists.txt into Source directory
940         https://bugs.webkit.org/show_bug.cgi?id=52888
941
942         * Scripts/webkitdirs.pm:
943
944 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
945
946         Reviewed by Eric Seidel.
947
948         Improve label text in submit-to-ews
949         https://bugs.webkit.org/show_bug.cgi?id=53130
950
951         * QueueStatusServer/templates/submittoews.html:
952
953 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
954
955         Reviewed by Antonio Gomes.
956
957         QtTestBrowser should have a UI Settings to prevent loading images
958         https://bugs.webkit.org/show_bug.cgi?id=52409
959         
960         Added a new action item named "DisableAutoLoadImages"
961         under the "Settings" menu 
962
963         * QtTestBrowser/launcherwindow.cpp:
964         (LauncherWindow::createChrome):
965         (LauncherWindow::toggleAutoLoadImages):
966         * QtTestBrowser/launcherwindow.h:
967
968 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
969
970         Reviewed by Tony Chang.
971
972         Minor bug fixes and cleanup for filesystem wrappers, port/* test
973         classes, test_expectations.py. This change adds "test-win" and
974         "test-mac" variants to the test port so that we can better test
975         rebaselining, and adds a MockUser() object for reuse in testing.
976
977         https://bugs.webkit.org/show_bug.cgi?id=53036
978
979         * Scripts/webkitpy/common/system/filesystem.py:
980         * Scripts/webkitpy/common/system/filesystem_mock.py:
981         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
982         * Scripts/webkitpy/layout_tests/port/factory.py:
983         * Scripts/webkitpy/layout_tests/port/base.py:
984         * Scripts/webkitpy/layout_tests/port/test.py:
985         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
986         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
987         * Scripts/webkitpy/tool/mocktool.py:
988
989 2011-01-25  Tony Chang  <tony@chromium.org>
990
991         Reviewed by Dimitri Glazkov.
992
993         [chromium] remove unused layoutTestController callback
994         https://bugs.webkit.org/show_bug.cgi?id=53103
995
996         This method is used by a test_shell_test, but not needed by DRT.
997
998         * DumpRenderTree/chromium/LayoutTestController.cpp:
999         (LayoutTestController::LayoutTestController):
1000         * DumpRenderTree/chromium/LayoutTestController.h:
1001
1002 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1003
1004         Reviewed by Andreas Kling.
1005
1006         [GTK] Remove 64 bits release bot from the buildbot master
1007         https://bugs.webkit.org/show_bug.cgi?id=52899
1008
1009         Removes the 64 bits release slave from the buildbot configuration,
1010         so that we can use it as an EWS.
1011
1012         * BuildSlaveSupport/build.webkit.org-config/config.json:
1013
1014 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1015
1016         Reviewed by Dan Bernstein.
1017
1018         Implement database quota callback to fix storage tests on WebKit2 bot
1019         https://bugs.webkit.org/show_bug.cgi?id=53064
1020
1021         * WebKitTestRunner/TestController.cpp:
1022         (WTR::exceededDatabaseQuota):
1023         (WTR::TestController::createOtherPage):
1024         (WTR::TestController::initialize):
1025
1026 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1027
1028         Reviewed by Anders Carlsson.
1029
1030         Use designated temp directory for the database for WebKit2
1031         https://bugs.webkit.org/show_bug.cgi?id=53052
1032         
1033         Adopt the new WK2 API for this.
1034
1035         * WebKitTestRunner/TestController.cpp:
1036         (WTR::TestController::libraryPathForTesting):
1037         (WTR::TestController::initialize):
1038         * WebKitTestRunner/TestController.h:
1039         * WebKitTestRunner/mac/TestControllerMac.mm:
1040         (WTR::TestController::platformLibraryPathForTesting):
1041         * WebKitTestRunner/qt/TestControllerQt.cpp:
1042         (WTR::TestController::platformLibraryPathForTesting):
1043         * WebKitTestRunner/win/TestControllerWin.cpp:
1044         (WTR::TestController::platformLibraryPathForTesting):
1045
1046 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1047
1048         Reviewed by Stephanie Lewis.
1049
1050         Add a new Leopard test bot.
1051
1052         * BuildSlaveSupport/build.webkit.org-config/config.json:
1053
1054 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1055
1056         Reviewed by Adam Barth.
1057
1058         Add EFL Builder to core waterfall
1059         https://bugs.webkit.org/show_bug.cgi?id=52704
1060
1061         Add EFL Builder to the core waterfall again.
1062
1063         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1064         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1065
1066 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1067
1068         Reviewed by Tony Chang.
1069
1070         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1071         https://bugs.webkit.org/show_bug.cgi?id=52872
1072
1073         Force disabling proxy to resolve the problem.
1074
1075         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1076         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1077
1078 2011-01-24  Andreas Kling  <kling@webkit.org>
1079
1080         Reviewed by Darin Adler.
1081
1082         check-webkit-style: Update exemptions following Source/ move.
1083         https://bugs.webkit.org/show_bug.cgi?id=53017
1084
1085         * Scripts/webkitpy/style/checker.py:
1086         * Scripts/webkitpy/style/checker_unittest.py:
1087
1088 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1089
1090         Rubber-stamped by Csaba Osztrogonác.
1091
1092         [Qt] Move project files into Source
1093         https://bugs.webkit.org/show_bug.cgi?id=52891
1094
1095         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1096
1097 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1098
1099         Reviewed by Yury Semikhatsky.
1100
1101         Web Inspector: Find duplicate strings in localizedStrings.js
1102
1103         https://bugs.webkit.org/show_bug.cgi?id=53005
1104
1105         * Scripts/check-inspector-strings:
1106
1107 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1108
1109         Reviewed by Andreas Kling.
1110
1111         [Qt] Regroup MiniBrowser's menubar and add open file action
1112         https://bugs.webkit.org/show_bug.cgi?id=53000
1113
1114         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1115
1116         * MiniBrowser/qt/BrowserWindow.cpp:
1117         (BrowserWindow::BrowserWindow):
1118         (BrowserWindow::openFile):
1119         (BrowserWindow::~BrowserWindow):
1120         * MiniBrowser/qt/BrowserWindow.h:
1121
1122 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1123
1124         Unreviewed fix after r76496
1125
1126         [Qt] Move project files into Source
1127         https://bugs.webkit.org/show_bug.cgi?id=52891
1128
1129         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1130         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1131         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1132
1133 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1134
1135         Reviewed by Csaba Osztrogonác.
1136
1137         [Qt] Move project files into Source
1138         https://bugs.webkit.org/show_bug.cgi?id=52891
1139
1140         * DerivedSources.pro: Renamed from DerivedSources.pro.
1141         * DumpRenderTree/qt/DumpRenderTree.pro:
1142         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1143         * MiniBrowser/DerivedSources.pro:
1144         * MiniBrowser/qt/MiniBrowser.pro:
1145         * QtTestBrowser/QtTestBrowser.pro:
1146         * Scripts/webkitdirs.pm:
1147         * Tools.pro: Added.
1148         * WebKitTestRunner/DerivedSources.pro:
1149         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1150         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1151
1152 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1153
1154         Reviewed by Dan Bernstein.
1155
1156         Beefed up --threaded mode to catch even more kinds of errors.
1157         https://bugs.webkit.org/show_bug.cgi?id=52971
1158
1159         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1160         context group to force JSC to mark multiple threads. (This used to be
1161         the default, but it changed in SnowLeopard.)
1162         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1163         to give threading mistakes more chances to show themselves.
1164         (startJavaScriptThreads):
1165         (stopJavaScriptThreads):
1166
1167 2011-01-22  Robert Hogan  <robert@webkit.org>
1168
1169         Reviewed by Andreas Kling.
1170
1171         [Qt] Support layoutTestController.addURLToRedirect()
1172         https://bugs.webkit.org/show_bug.cgi?id=52956
1173
1174         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1175         (LayoutTestController::addURLToRedirect):
1176         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1177
1178 2011-01-22  Robert Hogan  <robert@webkit.org>
1179
1180         Reviewed by Kenneth Rohde Christiansen.
1181
1182         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1183         https://bugs.webkit.org/show_bug.cgi?id=49802
1184
1185         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1186         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1187         (WebCore::DumpRenderTree::open):
1188
1189 2011-01-21  Adam Barth  <abarth@webkit.org>
1190
1191         Reviewed by Maciej Stachowiak.
1192
1193         Disable mac_unittest.py that fails on some of the Mac bots
1194         https://bugs.webkit.org/show_bug.cgi?id=52947
1195
1196         As noted in the comment, this test does not appear to be correct
1197         because the function this test is testing returns different results
1198         depending on which flavor of Mac the test is run on.  This patch
1199         disable the test.  Hopefully we can re-enable the test once we've
1200         probably insulated the test from its environment.
1201
1202         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1203
1204 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1205
1206         Reviewed by Mihai Parparita.
1207
1208         Fix bug introduced in r76322 that caused NRWT to not actually
1209         read the Skipped files properly.
1210
1211         https://bugs.webkit.org/show_bug.cgi?id=52771
1212
1213         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1214         * Scripts/webkitpy/layout_tests/port/webkit.py:
1215         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1216
1217 2011-01-21  Sam Weinig  <sam@webkit.org>
1218
1219         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1220
1221         WebKitTestRunner needs the HOME environment variable to be set.
1222         <rdar://problem/8896573>
1223
1224         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1225         it exists.
1226
1227 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1228
1229         Reviewed by Eric Seidel.
1230
1231         Suppress a few remaining integration tests so that none of the
1232         layout_test unit tests ever read from the filesystem or launch
1233         subprocesses that aren't part of the unit tests.
1234
1235         Also fix a minor bug in the printing unit tests that was
1236         incorrectly relying on sys.argv.
1237
1238         https://bugs.webkit.org/show_bug.cgi?id=52863
1239
1240         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1241         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1242         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1243
1244 2011-01-21  Darin Adler  <darin@apple.com>
1245
1246        Fix Mac build.
1247
1248         * MiniBrowser/mac/BrowserWindowController.m:
1249         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1250
1251 2011-01-20  Darin Adler  <darin@apple.com>
1252
1253         Reviewed by Dan Bernstein.
1254
1255         WebKit2: Implement showModalDialog
1256         https://bugs.webkit.org/show_bug.cgi?id=52855
1257
1258         This fixes WebKitTestRunner to compile, but more work is probably
1259         needed to get it to pass the tests.
1260
1261         * WebKitTestRunner/TestController.cpp:
1262         (WTR::TestController::runModal): Added. Calls through to the
1263         platform-specific version of runModal.
1264         (WTR::TestController::createOtherPage): Changed to be a private
1265         static member function so it can refer to runModal, which is
1266         a private static member function.
1267         (WTR::TestController::initialize): Pass 0 for the runModal
1268         function since we don't need to run the main window modal.
1269         I suspect this is wrong and will need to change.
1270         * WebKitTestRunner/TestController.h: Added declarations for
1271         the functions added above.
1272         * WebKitTestRunner/mac/TestControllerMac.mm:
1273         (WTR::TestController::runModal): Added. Untested implementation.
1274         * WebKitTestRunner/qt/TestControllerQt.cpp:
1275         (WTR::TestController::runModal): Added.
1276         * WebKitTestRunner/win/TestControllerWin.cpp:
1277         (WTR::TestController::runModal): Added.
1278
1279 2011-01-21  Eric Seidel  <eric@webkit.org>
1280
1281         Reviewed by Adam Barth.
1282
1283         Split Host object off from WebKitPatch for easier re-use
1284         https://bugs.webkit.org/show_bug.cgi?id=52284
1285
1286         new-run-webkit-tests and other tools are eventually going to want one of these.
1287         Basically you need to inherit from this class if you want to pretend to be a
1288         self.tool object for Steps/Commands.
1289
1290         * Scripts/webkitpy/common/host.py: Added.
1291         * Scripts/webkitpy/tool/main.py:
1292
1293 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1294
1295         Reviewed by Adam Barth.
1296
1297         Disable the tests that start and stop the http server and web
1298         server, so that we don't have to worry about port collisions on
1299         the bots.
1300
1301         https://bugs.webkit.org/show_bug.cgi?id=52861
1302
1303         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1304
1305 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1306
1307         Reviewed by Eric Seidel.
1308
1309         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1310         
1311         https://bugs.webkit.org/show_bug.cgi?id=52772
1312         
1313         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1314
1315 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1316
1317         Reviewed by Eric Siedel.
1318
1319         nrwt: clean up almost all remaining port references, remove
1320         unnecessary import clauses. The only remaining references are
1321         in places where a mock filesystem makes no sense or can't be
1322         used, and in one routine in port/google_chrome_unittest that
1323         I'll rewrite in a separate patch.
1324
1325         https://bugs.webkit.org/show_bug.cgi?id=52771
1326
1327         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1328         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1329         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1330         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1331         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1332         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1333         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1334         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1335         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1336         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1337         * Scripts/webkitpy/layout_tests/port/gtk.py:
1338         * Scripts/webkitpy/layout_tests/port/mac.py:
1339         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1340         * Scripts/webkitpy/layout_tests/port/qt.py:
1341         * Scripts/webkitpy/layout_tests/port/webkit.py:
1342         * Scripts/webkitpy/layout_tests/port/win.py:
1343         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1344
1345 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1346
1347         Reviewed by Mihai Parparita.
1348
1349         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1350
1351         https://bugs.webkit.org/show_bug.cgi?id=52762
1352
1353         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1354         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1355
1356 2011-01-20  Tony Chang  <tony@chromium.org>
1357
1358         Reviewed by Ojan Vafai.
1359
1360         [chromium] fix the paths used for the rebaseline tool
1361         https://bugs.webkit.org/show_bug.cgi?id=52857
1362
1363         Some of the bots were renamed so the path to grab the results zip
1364         file has changed.
1365
1366         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1367
1368 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1369
1370         Reviewed by Tony Chang.
1371
1372         Fix bug introduced in r72688 / bug 52768 that broke the
1373         generation of the output filename links in the results.html
1374         output. Apparently none of the unit tests actually checked to
1375         make sure the generated links were correct :(
1376
1377         https://bugs.webkit.org/show_bug.cgi?id=52854
1378
1379         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1380         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1381
1382 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1383
1384         Reviewed by Darin Adler.
1385
1386         https://bugs.webkit.org/show_bug.cgi?id=52849
1387         Make window.print work with WebKit2
1388
1389         * MiniBrowser/mac/BrowserWindowController.m:
1390         (-[BrowserWindowController awakeFromNib]):
1391         * WebKitTestRunner/TestController.cpp:
1392         (WTR::createOtherPage):
1393         (WTR::TestController::initialize):
1394         Added zeroes to WKPageUIClient structures to avoid build failures.
1395
1396 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1397
1398         Reviewed by Eric Seidel.
1399
1400         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1401
1402         https://bugs.webkit.org/show_bug.cgi?id=52756
1403
1404         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1405         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1406         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1407         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1408         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1409         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1410
1411 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1412
1413         Reviewed by Antonio Gomes.
1414
1415         QtTestBrowser should have a seperate menu for Settings
1416         https://bugs.webkit.org/show_bug.cgi?id=52817
1417         
1418         Added a new menu item named "Settings"
1419         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1420
1421         * QtTestBrowser/launcherwindow.cpp:
1422         (LauncherWindow::createChrome):
1423
1424 2011-01-20  Sam Weinig  <sam@webkit.org>
1425
1426         Reviewed by John Sullivan.
1427
1428         Update update-webkit-localizable-strings with new path to WebKit.
1429
1430         * Scripts/update-webkit-localizable-strings:
1431
1432 2011-01-20  James Robinson  <jamesr@chromium.org>
1433
1434         Reviewed by Darin Fisher.
1435
1436         Implement mozilla's requestAnimationFrame API
1437         https://bugs.webkit.org/show_bug.cgi?id=51218
1438
1439         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1440
1441         * DumpRenderTree/chromium/WebViewHost.cpp:
1442         (invokeScheduleComposite):
1443         (WebViewHost::scheduleAnimation):
1444         (WebViewHost::paintInvalidatedRegion):
1445         * DumpRenderTree/chromium/WebViewHost.h:
1446
1447 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1448
1449         Reviewed by Adam Roben.
1450
1451         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1452         https://bugs.webkit.org/show_bug.cgi?id=42327
1453
1454         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1455         for methods that take their normal arguments but also a JSContextRef.
1456         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1457         for evaluateScriptInIsolatedWorld.
1458         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1459         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1460         this call is for an isolated world.
1461         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1462         (WTR::worldMap): Helper to create a world map.
1463         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1464         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1465         added LayoutTestController API.
1466         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1467
1468 2011-01-19  Adam Roben  <aroben@apple.com>
1469
1470         Convert paths in environment variables back to msys-style inside commit-log-editor
1471
1472         When this script gets run from inside git commit, msys-style paths in the environment will
1473         have been turned into Windows-style paths with forward slashes. This screws up functions
1474         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1475         the paths back to msys-style before doing anything else.
1476
1477         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1478         using msysgit's Perl and multiple ChangeLogs have been edited
1479
1480         Reviewed by David Kilzer.
1481
1482         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1483         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1484         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1485
1486 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1487
1488         [Win] Unreviewed build fix after r76248.
1489
1490         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1491
1492 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1493
1494         Reviewed by Csaba Osztrogonác.
1495
1496         Refactoring of the custom allocation framework
1497         https://bugs.webkit.org/show_bug.cgi?id=49897
1498
1499         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1500         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1501         equivalent macro implementation at the necessary places.
1502 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1503
1504         Unreviewed. 
1505
1506         Adding myself to committers.py.
1507
1508         * Scripts/webkitpy/common/config/committers.py:
1509
1510 2011-01-20  Adam Barth  <abarth@webkit.org>
1511
1512         Reviewed by Tony Chang.
1513
1514         Chromium builders don't delete unversioned directories when DEPS change
1515         https://bugs.webkit.org/show_bug.cgi?id=52745
1516
1517         If we pass this option to gclient sync, gclient will delete directories
1518         that are no longer part of DEPS instead of leaving them around to
1519         confuse us later.  Apparently, the downstream buildbots use this option
1520         already.
1521
1522         * Scripts/update-webkit-chromium:
1523
1524 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1525
1526         Unreviewed, build fix - I pulled this patch in to fix an issue
1527         revealed by r76195 running on some new bots). Also fix a couple
1528         of other issues revealed in testing.
1529
1530         nrwt: remove fs refs from layout_package/json*
1531
1532         https://bugs.webkit.org/show_bug.cgi?id=52754
1533
1534         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1535         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1536         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1537         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1538         * Scripts/webkitpy/layout_tests/port/base.py:
1539
1540 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1541
1542         Unreviewed, build fix.
1543
1544         Fix a couple of minor bugs discovered while bringing up new bots
1545         for testing.
1546
1547         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1548         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1549
1550 2011-01-19  James Robinson  <jamesr@chromium.org>
1551
1552         Unreviewed, rolling out r76194.
1553         http://trac.webkit.org/changeset/76194
1554         https://bugs.webkit.org/show_bug.cgi?id=51218
1555
1556         Caused mysterious compile failure on the chromium win
1557         build.webkit.org bots
1558
1559         * DumpRenderTree/chromium/WebViewHost.cpp:
1560         (WebViewHost::paintInvalidatedRegion):
1561         * DumpRenderTree/chromium/WebViewHost.h:
1562
1563 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1564
1565         Reviewed by Mihai Parparita.
1566
1567         remove fs refs from test_runner, dump_render_tree_thread
1568
1569         https://bugs.webkit.org/show_bug.cgi?id=52753
1570
1571         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1572         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1573         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1574         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1575
1576 2011-01-19  James Robinson  <jamesr@chromium.org>
1577
1578         Reviewed by Darin Fisher.
1579
1580         Implement mozilla's requestAnimationFrame API
1581         https://bugs.webkit.org/show_bug.cgi?id=51218
1582
1583         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1584
1585         * DumpRenderTree/chromium/WebViewHost.cpp:
1586         (invokeScheduleComposite):
1587         (WebViewHost::scheduleAnimation):
1588         (WebViewHost::paintInvalidatedRegion):
1589         * DumpRenderTree/chromium/WebViewHost.h:
1590
1591 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1592
1593         Unreviewed, build fix.
1594
1595         Fix a few incorrect "self._filesystem" references introduced in
1596         r76184.
1597
1598         * Scripts/webkitpy/layout_tests/port/chromium.py:
1599         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1600
1601 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1602
1603         Reviewed by Mihai Parparita.
1604
1605         add a .sep property, abspath(), isabs(), mtime(), and
1606         open_text_file_for_writing() to filesystem modules. Some of
1607         these properties are not needed in this patch but will be needed
1608         in subsequent patches (I'm doing this to avoid having to track
1609         multiple versions of a single file).
1610
1611         Also, change most of the port/* modules to use the filesystem
1612         objects instead of referencing the filesystem directly.
1613
1614         https://bugs.webkit.org/show_bug.cgi?id=52748
1615
1616         * Scripts/webkitpy/common/system/filesystem.py:
1617         * Scripts/webkitpy/common/system/filesystem_mock.py:
1618         * Scripts/webkitpy/layout_tests/port/__init__.py:
1619         * Scripts/webkitpy/layout_tests/port/base.py:
1620         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1621         * Scripts/webkitpy/layout_tests/port/chromium.py:
1622         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1623         * Scripts/webkitpy/layout_tests/port/config.py:
1624         * Scripts/webkitpy/layout_tests/port/test.py:
1625         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1626
1627 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1628
1629         Reviewed by Anders Carlsson.
1630
1631         If resetting between tests times out, treat it as a WebProcess crash
1632         https://bugs.webkit.org/show_bug.cgi?id=52757
1633
1634         * WebKitTestRunner/TestController.cpp:
1635         (WTR::TestController::runTest):
1636
1637 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1638
1639         Reviewed by Darin Adler.
1640
1641         https://bugs.webkit.org/show_bug.cgi?id=52739
1642         Make it possible for a WebKit2 client to print headers and footers
1643
1644         Added dummy implementations for new printing UIClient calls.
1645
1646         * MiniBrowser/mac/BrowserWindowController.m:
1647         (-[BrowserWindowController awakeFromNib]):
1648         * WebKitTestRunner/TestController.cpp:
1649         (WTR::createOtherPage):
1650         (WTR::TestController::initialize):
1651
1652 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1653
1654         Reviewed by Ojan Vafai.
1655
1656         Change webkitpy/layout_tests/port/test.py to use the
1657         in-memory filesystem for cleaner unit testing. This
1658         change allows us to kill a lot of code that was
1659         specific to the test port, at the cost of being a
1660         little less clear about how things would work if
1661         you didn't have a filesystem.
1662
1663         https://bugs.webkit.org/show_bug.cgi?id=52605
1664
1665         * Scripts/webkitpy/layout_tests/port/test.py:
1666
1667 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1668
1669         Unreviewed, build fix.
1670
1671         Fix test failure caused by committing attachment 79368 instead
1672         of attachment 79461 on bug 52604.
1673
1674         * Scripts/webkitpy/common/system/filesystem_mock.py:
1675
1676 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1677
1678         Reviewed by Mihai Parparita.
1679
1680         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1681         unit testing. os.walk() is too much of a hassle to implement on
1682         top of the in-memory mock filesystem and adding the necessary
1683         interface to files_under() gives clients a cleaner API anyway
1684         (for this particular usage model).
1685
1686         https://bugs.webkit.org/show_bug.cgi?id=52691
1687
1688         * Scripts/webkitpy/common/system/filesystem.py:
1689         * Scripts/webkitpy/common/system/filesystem_mock.py:
1690         * Scripts/webkitpy/layout_tests/port/test_files.py:
1691         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1692
1693 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1694
1695         Reviewed by Tony Chang.
1696
1697         Change more modules in the layout-tests code to use the
1698         filesystem wrapper for cleaner unit testing.
1699
1700         This patch also adds the glob() wrapper to the filesystem
1701         abstraction.
1702         
1703         https://bugs.webkit.org/show_bug.cgi?id=52604
1704
1705         * Scripts/webkitpy/layout_tests/port/test_files.py:
1706         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1707         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1708         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1709         * Scripts/webkitpy/common/system/filesystem.py:
1710         * Scripts/webkitpy/common/system/filesystem_mock.py:
1711
1712 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1713
1714         Unreviewed.
1715
1716         Updating my email addresses and irc nick.
1717
1718         * Scripts/webkitpy/common/config/committers.py:
1719
1720 2011-01-19  Tony Chang  <tony@chromium.org>
1721
1722         Reviewed by Mihai Parparita.
1723
1724         [chromium] [linux] if check-sys-deps fails, output the failure reason
1725         https://bugs.webkit.org/show_bug.cgi?id=52671
1726
1727         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1728             error handler functions.
1729         * Scripts/webkitpy/layout_tests/port/chromium.py:
1730             output the error text from --check-sys-deps
1731         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1732
1733 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1734
1735         Reviewed by Andreas Kling.
1736
1737         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1738         https://bugs.webkit.org/show_bug.cgi?id=52554
1739         
1740         QtNetworkAccessManager is created in a thread and set as
1741         member variable in QWebPage. When the thread is destroyed
1742         the object is still used. So fix will set the object to
1743         NULL once the thread is destroyed.
1744
1745         * QtTestBrowser/launcherwindow.cpp:
1746         (LauncherWindow::~LauncherWindow):
1747
1748 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1749
1750         Rubber stamped by Csaba Osztrogonac
1751
1752         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1753
1754 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1755
1756         Reviewed by Tony Chang.
1757
1758         new-run-webkit-tests: add a --build-directory command line argument
1759
1760         Official Google Chrome builds use a non-standard build directory
1761         location. This patch adds a --build-directory argument that
1762         allows that location to be specified on the command line. Only
1763         Chromium-based builds will use this flag for now, but anyone can
1764         in the future.
1765
1766         There are no unit tests for this since it's difficult to test
1767         until mock filesystems are fully supported in the code. This was
1768         tested by hand for now.
1769
1770         https://bugs.webkit.org/show_bug.cgi?id=52694
1771
1772         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1773         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1774         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1775         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1776
1777 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1778
1779         Not reviewed. Bot fix.
1780
1781         Remove an inadvertently committed debugging print.
1782
1783         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1784         (LayoutTestController::notifyDone):
1785
1786 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1787
1788         Reviewed by Sam Weinig.
1789
1790         WebKitTestRunner should track loading more like DumpRenderTree
1791         https://bugs.webkit.org/show_bug.cgi?id=52692
1792
1793         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1794         This makes some tests that call notifyDone multiple times pass.
1795         
1796         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1797         (WTR::InjectedBundle::InjectedBundle):
1798         (WTR::InjectedBundle::done):
1799         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1800         (WTR::InjectedBundle::topLoadingFrame):
1801         (WTR::InjectedBundle::setTopLoadingFrame):
1802         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1803         (WTR::InjectedBundlePage::InjectedBundlePage):
1804         (WTR::InjectedBundlePage::stopLoading):
1805         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1806         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1807         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1808         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1809         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1810         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1811         (WTR::LayoutTestController::notifyDone):
1812         * WebKitTestRunner/TestController.cpp:
1813         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1814
1815 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1816
1817         Reviewed by Kent Tamura.
1818
1819         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1820         https://bugs.webkit.org/show_bug.cgi?id=52678
1821         
1822         Update path now that WebKit is inside Source.
1823
1824         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1825
1826 2011-01-18  Robert Hogan  <robert@webkit.org>
1827
1828         Reviewed by Simon Hausmann.
1829
1830         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1831         https://bugs.webkit.org/show_bug.cgi?id=44282
1832
1833         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1834         (WebCore::DumpRenderTree::dump):
1835
1836 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1837
1838         Reviewed by Mihai Parparita.
1839
1840         Fix a small race condition that could cause the unit tests for
1841         new-run-webkit-tests to fail in a multithreaded environment.
1842         There was a small window in the code where one thread would
1843         check to see if a thread had raised an exception, do something,
1844         and then check to see if the thread was alive. If the other
1845         thread raised an exception and exited in between these two
1846         steps, the exception would be lost. Flipping the order of the
1847         two checks fixes the race, since we will now always check for an
1848         exception on the thread before exiting.
1849
1850         https://bugs.webkit.org/show_bug.cgi?id=51579
1851
1852         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1853
1854 2011-01-18  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by Adam Barth.
1857
1858         commit-queue dies when test archiving fails
1859         https://bugs.webkit.org/show_bug.cgi?id=52617
1860
1861         I looked at the machine and it had 10 archives already
1862         thus find_unused_name was returning None.  I've upped
1863         the limit to 100 (per bug) and tested the case where
1864         find_unused_name returns None (making archive return None).
1865
1866         * Scripts/webkitpy/common/system/workspace.py:
1867         * Scripts/webkitpy/common/system/workspace_unittest.py:
1868         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1869         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1870         * Scripts/webkitpy/tool/commands/queues.py:
1871
1872 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1873
1874         Reviewed by Ojan Vafai.
1875
1876         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1877         filesystem. Also fix a couple of "with" statements missed by
1878         r76050.
1879
1880         https://bugs.webkit.org/show_bug.cgi?id=52487
1881
1882         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1883
1884 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1885
1886         Reviewed by Martin Robinson.
1887
1888         [Gtk] Build fixes for gtk3 build
1889         https://bugs.webkit.org/show_bug.cgi?id=52648
1890
1891         * DumpRenderTree/gtk/EventSender.cpp:
1892         (beginDragWithFilesCallback):
1893
1894 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1895
1896         Reviewed by Mihai Parparita.
1897
1898         Update rebaseline-chromium-webkit-tests to use filesystem objects
1899         instead of direct references to os.path, shutil, tempfile, etc.
1900
1901         This patch doesn't change anything, but will allow subsequent
1902         patches to change the unit tests to no longer use the real
1903         filesystem.
1904
1905         This patch adds a bunch more methods to the filesystem object as
1906         well.
1907
1908         https://bugs.webkit.org/show_bug.cgi?id=52482
1909
1910         * Scripts/webkitpy/common/system/filesystem.py:
1911         * Scripts/webkitpy/common/system/filesystem_mock.py:
1912         * Scripts/webkitpy/tool/commands/queues.py:
1913         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1914         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1915
1916 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1917
1918         Reviewed by Mihai Parparita.
1919
1920         new-run-webkit-tests shouldn't crash when you try to run a
1921         directory containing only skipped files.
1922
1923         https://bugs.webkit.org/show_bug.cgi?id=52478
1924         
1925         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1926         * Scripts/webkitpy/layout_tests/port/test.py:
1927         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1928
1929 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1930
1931         Reviewed by Gustavo Noronha Silva.
1932
1933         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1934         https://bugs.webkit.org/show_bug.cgi?id=40833
1935
1936         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1937         GTK+ event sender.
1938         (dragWithFilesDragDataGetCallback): Added.
1939         (dragWithFilesDragEndCallback): Added.
1940         (beginDragWithFilesCallback): Added.
1941
1942 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1943
1944         Reviewed by Adam Barth.
1945
1946         ews: Add additional watcher to efl ews
1947         https://bugs.webkit.org/show_bug.cgi?id=52613
1948
1949         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1950
1951         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1952
1953 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1954
1955         Reviewed by Alexey Proskuryakov.
1956
1957         Fix some headers with missing or misspelled #ifndef guards
1958         https://bugs.webkit.org/show_bug.cgi?id=52545
1959
1960         * DumpRenderTree/chromium/TestEventPrinter.h:
1961         * DumpRenderTree/chromium/WebPreferences.h:
1962
1963 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1964
1965         Reviewed by Anders Carlsson.
1966
1967         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1968         navigating back to an unreachable URL
1969         https://bugs.webkit.org/show_bug.cgi?id=52388
1970
1971         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1972
1973         * DumpRenderTree/LayoutTestController.cpp:
1974         (queueLoadHTMLStringCallback):
1975         (LayoutTestController::queueLoadHTMLString):
1976         (LayoutTestController::queueLoadAlternateHTMLString):
1977         * DumpRenderTree/LayoutTestController.h:
1978
1979         * DumpRenderTree/WorkQueueItem.h:
1980         (LoadHTMLStringItem::LoadHTMLStringItem):
1981
1982         * DumpRenderTree/chromium/LayoutTestController.cpp:
1983         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1984         (WorkItemLoadHTMLString::run):
1985         (LayoutTestController::queueLoadHTMLString):
1986
1987         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1988         (LoadHTMLStringItem::invoke):
1989         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1990         (LoadHTMLStringItem::invoke):
1991         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1992         (LoadHTMLStringItem::invoke):
1993
1994 2011-01-17  Dan Bernstein  <mitz@apple.com>
1995
1996         Rubber-stamped by Mark Rowe.
1997
1998         Update xcodeproj svn:ignore to include xcuserdata.
1999
2000         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2001         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2002         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2003         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2004         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2005
2006 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2007
2008         Unreviewed fix after r75908.
2009
2010         Move WebKit into Source
2011         https://bugs.webkit.org/show_bug.cgi?id=52530
2012
2013         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2014
2015 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2016
2017         Unreviewed.
2018
2019         Remove accidentally committed debug printing after r75908.
2020
2021         * Scripts/webkitdirs.pm:
2022
2023 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2024
2025         Unreviewed.
2026
2027         Add myself to committers list
2028         https://bugs.webkit.org/show_bug.cgi?id=52566
2029
2030         * Scripts/webkitpy/common/config/committers.py:
2031
2032 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2033
2034         Reviewed by Jeremy Orlow.
2035
2036         GeolocationController should call stopUpdating on destruction
2037         https://bugs.webkit.org/show_bug.cgi?id=52216
2038
2039         fast/dom/Geolocation/window-close-crash.html requires that a
2040         Geolocation watch be started in a secondary window. Consequently,
2041         we need to allow geolocation permission and provide a mock
2042         geolocation position for the secondary window's
2043         GeolocationClientMock.
2044
2045         * DumpRenderTree/chromium/LayoutTestController.cpp:
2046         (LayoutTestController::setGeolocationPermission):
2047         (LayoutTestController::setMockGeolocationPosition):
2048         (LayoutTestController::setMockGeolocationError):
2049         * DumpRenderTree/chromium/TestShell.h:
2050         (TestShell::windowList):
2051
2052 2011-01-16  Adam Barth  <abarth@webkit.org>
2053
2054         Update more include paths to reflect WebKit move.
2055
2056         * DumpRenderTree/chromium/EventSender.cpp:
2057         (EventSender::keyDown):
2058         (EventSender::needsShiftModifier):
2059         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2060         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2061
2062 2011-01-16  Kent Tamura  <tkent@chromium.org>
2063
2064         Unreviewed, Chromium build fix.
2065
2066         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2067
2068 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2069
2070         Build fix for GTK+ after source directory movement.
2071
2072         * GNUmakefile.am: Correct include paths.
2073
2074 2011-01-16  Adam Barth  <abarth@webkit.org>
2075
2076         Teach svn-apply about WebKit move.
2077
2078         * Scripts/VCSUtils.pm:
2079
2080 2011-01-16  Adam Barth  <abarth@webkit.org>
2081
2082         Rubber-stamped by Eric Seidel.
2083
2084         Move WebKit into Source
2085         https://bugs.webkit.org/show_bug.cgi?id=52530
2086
2087         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2088         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2089         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2090         * DumpRenderTree/qt/GCControllerQt.cpp:
2091         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2092         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2093         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2094         * DumpRenderTree/wscript:
2095         * QtTestBrowser/launcherwindow.h:
2096         * Scripts/build-webkit:
2097         * Scripts/webkitdirs.pm:
2098
2099 2011-01-15  Adam Barth  <abarth@webkit.org>
2100
2101         Teach svn-apply about WebKit2 move.
2102
2103         * Scripts/VCSUtils.pm:
2104
2105 2011-01-15  Adam Barth  <abarth@webkit.org>
2106
2107         Rubber-stamped by Eric Seidel.
2108
2109         Move WebKit2 into Source
2110         https://bugs.webkit.org/show_bug.cgi?id=52438
2111
2112         * MiniBrowser/qt/MiniBrowser.pro:
2113         * Scripts/build-webkit:
2114         * Scripts/do-file-rename:
2115         * Scripts/do-webcore-rename:
2116         * Scripts/test-webkitpy:
2117         * Scripts/webkitdirs.pm:
2118         * Scripts/webkitpy/style/checker.py:
2119         * WebKitTestRunner/DerivedSources.pro:
2120         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2121         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2122
2123 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2124
2125         Reviewed by David Levin.
2126
2127         [chromium] remove obsolete createView method
2128         https://bugs.webkit.org/show_bug.cgi?id=52437
2129
2130         * DumpRenderTree/chromium/WebViewHost.cpp:
2131         (WebViewHost::createView):
2132         * DumpRenderTree/chromium/WebViewHost.h:
2133
2134 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2135
2136         Reviewed by Geoff Garen.
2137
2138         ShouldLoadResourceForFrame should use strings, not URLs.
2139         https://bugs.webkit.org/show_bug.cgi?id=52476
2140
2141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2142         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2144
2145 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2146
2147         Reviewed by David Levin.
2148
2149         Add Tony Gentilcore as a reviewer
2150         https://bugs.webkit.org/show_bug.cgi?id=52480
2151
2152         * Scripts/webkitpy/common/config/committers.py:
2153
2154 2011-01-14  David Levin  <levin@chromium.org>
2155
2156         Reviewed by Eric Seidel.
2157
2158         check-webkit-style: _FunctionState should keep track of where the function name starts.
2159         https://bugs.webkit.org/show_bug.cgi?id=52454
2160
2161         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2162         _FunctionState and logic for setting it correctly.
2163         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2164
2165 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2166
2167         Reviewed by David Levin.
2168
2169         Add support to DumpRenderTree to use the GPU rather than software renderer
2170         https://bugs.webkit.org/show_bug.cgi?id=52333
2171
2172         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2173         (main):
2174         * Scripts/webkitpy/layout_tests/port/chromium.py:
2175         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2176
2177 2011-01-14  Tony Chang  <tony@chromium.org>
2178
2179         Reviewed by Kent Tamura.
2180
2181         [chromium] update fonts.conf to fix 6 linux tests in drt
2182         https://bugs.webkit.org/show_bug.cgi?id=52411
2183
2184         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2185             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2186
2187 2011-01-14  Eric Seidel  <eric@webkit.org>
2188
2189         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2190
2191         Reviewed by Adam Barth.
2192
2193         Fix when running Tools/Scripts/check-webkit-style without arguments.
2194         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2195
2196         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2197         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2198
2199 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2200
2201         Reviewed by David Levin.
2202
2203         Store the tempdir object in a variable so it doesn't get deleted too early.
2204         https://bugs.webkit.org/show_bug.cgi?id=51875
2205
2206         * Scripts/update-webkit-auxiliary-libs:
2207         * Scripts/update-webkit-support-libs:
2208
2209 2011-01-14  Eric Seidel  <eric@webkit.org>
2210
2211         Unreviewed.  Make it work in python 2.5.
2212
2213         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2214         https://bugs.webkit.org/show_bug.cgi?id=49158
2215
2216         * Scripts/webkitpy/common/checkout/api_unittest.py:
2217
2218 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2219
2220         Unreviewed, rolling out r75774.
2221         http://trac.webkit.org/changeset/75774
2222         https://bugs.webkit.org/show_bug.cgi?id=52431
2223
2224         gtk builds were broken (Requested by loislo2 on #webkit).
2225
2226         * Scripts/webkitpy/common/checkout/scm.py:
2227
2228 2011-01-14  David Levin  <levin@chromium.org>
2229
2230         Reviewed by Shinichiro Hamaji.
2231
2232         check-webkit-style: _FunctionState should detect pure functions.
2233         https://bugs.webkit.org/show_bug.cgi?id=52428
2234
2235         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2236         is a pure virtual function.
2237         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2238         virtual functions are correctly detected.
2239
2240 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2241
2242         Reviewed by Yury Semikhatsky.
2243
2244         Just small fix for problem with check-webkit-style.
2245         It just didn't work for this patch.
2246         Old code can't concatenate a list of strings with None.
2247
2248         * Scripts/webkitpy/common/checkout/scm.py:
2249
2250 2011-01-13  David Levin  <levin@chromium.org>
2251
2252         Reviewed by Shinichiro Hamaji.
2253
2254         check-webkit-style: _FunctionState should use Position to know where items are.
2255         https://bugs.webkit.org/show_bug.cgi?id=52424
2256
2257         * Scripts/webkitpy/style/checkers/cpp.py:
2258         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2259         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2260         did some minor clean-up.
2261         (*): Other changes are simply about converting to use the Position's in_FunctionState
2262         instead of line numbers.
2263         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2264         to verify the positions stored in _FunctionState.
2265
2266 2011-01-13  Eric Seidel  <eric@webkit.org>
2267
2268         Reviewed by David Levin.
2269
2270         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2271         https://bugs.webkit.org/show_bug.cgi?id=49158
2272
2273         This is not the most elegant, but it is a very safe fix to this bug.
2274         One advantage of catching ScriptError like this instead of adding a
2275         new added_or_modified_files or fixing all changed_files callers
2276         to use a more specific change_files variant, is that we catch
2277         all kinds of ScriptErrors which might cause our (non-essential)
2278         suggest-reviewers code to fail out.  This should make passing
2279         --suggest-reviewers to webkit-patch upload much more robust
2280         and may even make it possible for us to make it default.
2281
2282         The root of the problem here is that SCM.changed_files includes
2283         deleted ChangeLog paths (from moves, etc) which then when we ask
2284         SVN/Git for the contents of the file at that revision, the command
2285         errors out and Executive.run_command raises a ScriptError.
2286
2287         In the future we might fix this differently by making all current
2288         callers of chagned_files use a more specific method for requesting
2289         what types of changes they're interested in (adds, modifies, deletes, etc.)
2290
2291         * Scripts/webkitpy/common/checkout/api.py:
2292         * Scripts/webkitpy/common/checkout/api_unittest.py:
2293
2294 2011-01-13  Dan Bernstein  <mitz@apple.com>
2295
2296         Reviewed by Alexey Proskuryakov.
2297
2298         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2299         https://bugs.webkit.org/show_bug.cgi?id=52419
2300
2301         Allow to further control the behavior of the willSendRequest delegate callback by making it
2302         set a different URL in the new request.
2303
2304         * DumpRenderTree/LayoutTestController.cpp:
2305         (addURLToRedirectCallback): Added.
2306         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2307         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2308         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2309         * DumpRenderTree/LayoutTestController.h:
2310         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2311         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2312         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2313         change the URL in the new request to the redirect destination.
2314
2315 2011-01-13  Eric Seidel  <eric@webkit.org>
2316
2317         Reviewed by Mihai Parparita.
2318
2319         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2320         https://bugs.webkit.org/show_bug.cgi?id=52416
2321
2322         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2323         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2324
2325         I also added FIXMEs about the changed_files returning deleted files problem
2326         which is causing the other most common exception for suggest-reviewers
2327         (and is probably breaking sheriff-bots blame detection).
2328
2329         * Scripts/webkitpy/common/checkout/api.py:
2330         * Scripts/webkitpy/common/checkout/api_unittest.py:
2331         * Scripts/webkitpy/common/checkout/scm.py:
2332
2333 2011-01-13  Eric Seidel  <eric@webkit.org>
2334
2335         Reviewed by Adam Barth.
2336
2337         results archives from commit-queue are too large to upload
2338         https://bugs.webkit.org/show_bug.cgi?id=52405
2339
2340         * Scripts/webkitpy/common/system/filesystem.py:
2341         * Scripts/webkitpy/common/system/filesystem_mock.py:
2342         * Scripts/webkitpy/tool/commands/queues.py:
2343
2344 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2345
2346         Reviewed by Martin Robinson.
2347
2348         [gtk] Zero-sized font does not yet work
2349         https://bugs.webkit.org/show_bug.cgi?id=49793
2350
2351         Set minimum-font-size to 0 for the DRT.
2352
2353         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2354         (resetDefaultsToConsistentValues):
2355
2356 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2357
2358         Reviewed by Darin Adler.
2359
2360         Make old-run-webkit-tests more robust on buildbots
2361         https://bugs.webkit.org/show_bug.cgi?id=52364
2362
2363         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2364
2365 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2366
2367         Reviewed by Darin Adler.
2368
2369         Make old-run-webkit-tests more robust on buildbots
2370         https://bugs.webkit.org/show_bug.cgi?id=52364
2371
2372         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2373
2374 2011-01-13  Tony Chang  <tony@chromium.org>
2375
2376         Reviewed by Kent Tamura.
2377
2378         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2379         https://bugs.webkit.org/show_bug.cgi?id=52332
2380
2381         Forked Info.plist is not longer needed.
2382
2383         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2384
2385 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2386
2387         Reviewed by Timothy Hatcher.
2388
2389         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2390         to be passed directly to WebInspector.UIString
2391
2392         https://bugs.webkit.org/show_bug.cgi?id=52365
2393
2394         * Scripts/check-inspector-strings:
2395
2396 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2397
2398         Unreviewed, rolling out r74881.
2399         http://trac.webkit.org/changeset/74881
2400         https://bugs.webkit.org/show_bug.cgi?id=52357
2401
2402         The EFL builder has been red for days (Requested by abarth on
2403         #webkit).
2404
2405         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2406         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2407
2408 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2409
2410         Reviewed by David Levin.
2411
2412         Add beforeunload support to WebKitTestRunner
2413         https://bugs.webkit.org/show_bug.cgi?id=52353
2414         
2415         This makes a number of currently failing tests pass.
2416
2417         * WebKitTestRunner/TestController.cpp:
2418         (WTR::runBeforeUnloadConfirmPanel):
2419         (WTR::createOtherPage):
2420         (WTR::TestController::initialize):
2421
2422 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2423
2424         Reviewed by Sam Weinig.
2425
2426         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2427         https://bugs.webkit.org/show_bug.cgi?id=52330
2428
2429         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2430         a web process crash.
2431         * WebKitTestRunner/TestController.cpp:
2432         (WTR::TestController::initialize): Set up a processDidCrash
2433         callback.
2434         (WTR::TestController::processDidCrash): Report that the Web process
2435         crashed.
2436         * WebKitTestRunner/TestController.h:
2437
2438 2011-01-12  David Levin  <levin@chromium.org>
2439
2440         Reviewed by Shinichiro Hamaji.
2441
2442         check-webkit-style -- close_expression function doesn't work correctly.
2443         https://bugs.webkit.org/show_bug.cgi?id=52272
2444
2445         * Scripts/webkitpy/style/checkers/cpp.py:
2446         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2447         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2448         generally useful (for upcoming code changes).
2449         (close_expression): Changed to use Position for input and output.
2450         Also, fixed many bugs such as only working correctly for parenthesis,
2451         not working correctly if given an offset in a line and not finding
2452         the real closing element if there were multiple closing elements in
2453         the same line.
2454         (detect_functions): Adjusted due to the change in arguments for
2455         close_expression.
2456         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2457         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2458         two positions are the same.
2459         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2460         (CppStyleTest.test_close_expression): Added tests to catch the issues
2461         that were fixed.
2462
2463 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2464
2465         Unreviewed, rolling out r75576.
2466         http://trac.webkit.org/changeset/75576
2467         https://bugs.webkit.org/show_bug.cgi?id=52304
2468
2469         broke rebaseline-chromium-webkit-test (Requested by thakis on
2470         #webkit).
2471
2472         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2473         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2474         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2475         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2476         * Scripts/webkitpy/layout_tests/port/base.py:
2477         * Scripts/webkitpy/layout_tests/port/chromium.py:
2478         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2479         * Scripts/webkitpy/layout_tests/port/test.py:
2480         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2481         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2482         * Scripts/webkitpy/style/checkers/test_expectations.py:
2483         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2484
2485 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2486
2487         Reviewed by Darin Adler.
2488
2489         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2490         https://bugs.webkit.org/show_bug.cgi?id=52307
2491
2492         * Scripts/old-run-webkit-tests:
2493
2494 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2495
2496         Reviewed by Martin Robinson.
2497
2498         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2499         https://bugs.webkit.org/show_bug.cgi?id=50867
2500
2501         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2502         TestNetscapePlugin.cpp 
2503
2504         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2505         * Scripts/webkitdirs.pm:
2506
2507 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2508
2509         Reviewed by Pavel Feldman.
2510
2511         Add check-inspector-strings script.
2512
2513         https://bugs.webkit.org/show_bug.cgi?id=52295
2514
2515         * Scripts/check-inspector-strings: Added.
2516
2517 2011-01-12  Adam Roben  <aroben@apple.com>
2518
2519         Advertise the .testnetscape file extension on Windows
2520
2521         Fixes <http://webkit.org/b/52298>
2522         plugins/no-mime-with-valid-extension.html fails on Windows
2523
2524         Reviewed by Dan Bernstein.
2525
2526         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2527         FileExtents field to map the .testnetscape file extension to the
2528         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2529
2530 2011-01-12  Adam Barth  <abarth@webkit.org>
2531
2532         Reviewed by Eric Seidel.
2533
2534         Make webkit-patch support subdirectories for SVN checkouts
2535         https://bugs.webkit.org/show_bug.cgi?id=52261
2536
2537         os.relpath does not exist on Python 2.5, so we need to call our version
2538         of the API.
2539
2540         * Scripts/webkitpy/common/checkout/scm.py:
2541
2542 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2543
2544         Reviewed by Eric Seidel.
2545
2546         Close additional pages opened during a test once the test completes.
2547         https://bugs.webkit.org/show_bug.cgi?id=52276
2548
2549         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2550         (WTR::InjectedBundle::done):
2551
2552 2011-01-11  David Levin  <levin@chromium.org>
2553
2554         Reviewed by Eric Seidel.
2555
2556         Errors should be separated from the command line in bot messages.
2557         https://bugs.webkit.org/show_bug.cgi?id=52275
2558
2559         * Scripts/webkitpy/common/system/executive.py:
2560         (ScriptError.message_with_output): Added a newline to separate the command
2561         line from the errors.
2562         * Scripts/webkitpy/common/system/executive_unittest.py:
2563         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2564         paths in message_with_output.
2565
2566 2011-01-11  Eric Seidel  <eric@webkit.org>
2567
2568         Unreviewed.
2569
2570         commit-queue should know how to upload archived results (for test flakes or general failures)
2571         https://bugs.webkit.org/show_bug.cgi?id=52048
2572
2573         The zips are mostly empty due to forgetting -r.
2574         Expected diffs were not being pulled from the archive due
2575         to the archive having longer paths than I realized.
2576
2577         * Scripts/webkitpy/common/system/workspace.py:
2578         * Scripts/webkitpy/common/system/workspace_unittest.py:
2579         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2580         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2581
2582 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2583
2584         Reviewed by Ojan Vafai.
2585
2586         The current modifier parsing code in test_expectations is
2587         fragile and hard-coded, so it's not easy to understand the logic
2588         or easily add new types of modifiers (like GPU vs. CPU testing
2589         for graphics tests, or 32-bit vs. 64-bit differences).
2590
2591         This is the first of two patches that will add in more generic
2592         support and then eliminate the GPU-specific test expectations
2593         files for Chromium.
2594
2595         This patch adds two standalone objects for handling modifiers. The
2596         rules for interpreting modifiers, precedence, and conflicts are
2597         given in the docstring to the ModifierMatcher class, which
2598         returns ModifierMatchResult objects.
2599         
2600         This patch also adds routines to the Port interface and a
2601         default set of values in the base object, in order to obtain the
2602         values needed on a given test run. These values are then passed
2603         to the expectation parser. This also allows us to clean up the
2604         logic used to lint all of the different configurations in a
2605         single test_expectations.txt file.
2606
2607         The next patch will merge in the separate GPU expectations file.
2608
2609         https://bugs.webkit.org/show_bug.cgi?id=51222
2610
2611         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2612         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2613         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2614         * Scripts/webkitpy/layout_tests/port/base.py:
2615         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2616         * Scripts/webkitpy/layout_tests/port/chromium.py:
2617         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2618         * Scripts/webkitpy/layout_tests/port/test.py:
2619         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2620         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2621
2622 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2623
2624         Reviewed by Adam Barth.
2625
2626         Make webkit-patch support subdirectories for SVN checkouts
2627         https://bugs.webkit.org/show_bug.cgi?id=52261
2628
2629         * Scripts/webkitpy/common/checkout/scm.py:
2630         * Scripts/webkitpy/style_references.py:
2631         * Scripts/webkitpy/tool/main.py:
2632         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2633
2634 2011-01-11  Eric Seidel  <eric@webkit.org>
2635
2636         Unreviewed.
2637
2638         commit-queue should know how to upload archived results (for test flakes or general failures)
2639         https://bugs.webkit.org/show_bug.cgi?id=52048
2640
2641         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2642         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2643
2644         * Scripts/webkitpy/common/system/workspace.py:
2645         * Scripts/webkitpy/common/system/workspace_unittest.py:
2646         * Scripts/webkitpy/tool/commands/queues.py:
2647
2648 2011-01-11  Sam Weinig  <sam@webkit.org>
2649
2650         Roll r75474 back in.
2651
2652 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2653
2654         Reviewed by Kenneth Rohde Christiansen.
2655
2656         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2657         https://bugs.webkit.org/show_bug.cgi?id=51204
2658
2659         * QtTestBrowser/webpage.h:
2660         (QtNAMThread::QtNAMThread):
2661         (QtNAMThread::networkAccessManager):
2662         (QtNAMThread::run):
2663
2664 2011-01-11  Peter Varga  <pvarga@webkit.org>
2665
2666         Unreviewed.
2667
2668         Add myself to committers' list.
2669
2670         * Scripts/webkitpy/common/config/committers.py:
2671
2672 2011-01-11  Eric Seidel  <eric@webkit.org>
2673
2674         Reviewed by Adam Barth.
2675
2676         commit-queue should know how to upload archived results (for test flakes or general failures)
2677         https://bugs.webkit.org/show_bug.cgi?id=52048
2678
2679         Now the queue will always upload results.  Either the entire zip, or just
2680         the diffs.txt in the case of text failures.
2681
2682         This should make understanding flakes much easier, and paves the way
2683         for having the EWS run layout tests (and upload failures).
2684
2685         In order to upload .zip files I had to teach bugzilla.py to autodetect
2686         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2687         for .patch files, I have it add one before calling guess_type.
2688
2689         We may find that always uploading the whole zip instead of just the -diffs.txt
2690         file is preferable, but for now I'm keeping the old behavior because it makes
2691         quickly understanding text failures easy.
2692
2693         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2694         * Scripts/webkitpy/common/system/workspace.py: Added.
2695         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2696         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2697         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2698         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2699         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2700         * Scripts/webkitpy/tool/commands/queues.py:
2701         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2702
2703 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2704
2705         Unreviewed, rolling out r75464.
2706         http://trac.webkit.org/changeset/75464
2707         https://bugs.webkit.org/show_bug.cgi?id=52193
2708
2709         Followup rollout for 75474 (Requested by Ossy on #webkit).
2710
2711         * MiniBrowser/mac/BrowserWindowController.m:
2712         (-[BrowserWindowController awakeFromNib]):
2713         * MiniBrowser/win/BrowserView.cpp:
2714         (BrowserView::create):
2715         * WebKitTestRunner/TestController.cpp:
2716         (WTR::createOtherPage):
2717         (WTR::TestController::initialize):
2718
2719 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2720
2721         Reviewed by Csaba Osztrogonác.
2722
2723         [Qt] Baseline qt_minimal configuration
2724         https://bugs.webkit.org/show_bug.cgi?id=51313
2725
2726         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2727         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2728         QT_NO_UNDOSTACK guard.
2729
2730         * QtTestBrowser/launcherwindow.cpp:
2731         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2732         guards.
2733         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2734         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2735         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2736         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2737
2738         * QtTestBrowser/launcherwindow.h:
2739         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2740         * QtTestBrowser/locationedit.h: Ditto.
2741
2742         * QtTestBrowser/mainwindow.cpp:
2743         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2744         QT_NO_UNDOSTACK guards.
2745         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2746         (MainWindow::changeLocation): Ditto.
2747         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2748         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2749
2750         * QtTestBrowser/webpage.cpp:
2751         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2752         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2753
2754         * QtTestBrowser/webview.cpp:
2755         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2756         (WebViewGraphicsBased::animatedYFlip): Ditto.
2757
2758 2011-01-10  Sam Weinig  <sam@webkit.org>
2759
2760         Fix build.
2761
2762         * MiniBrowser/mac/BrowserWindowController.m:
2763         (-[BrowserWindowController awakeFromNib]):
2764         * MiniBrowser/win/BrowserView.cpp:
2765         (BrowserView::create):
2766         * WebKitTestRunner/TestController.cpp:
2767         (WTR::createOtherPage):
2768         (WTR::TestController::initialize):
2769
2770 2011-01-10  Eric Seidel  <eric@webkit.org>
2771
2772         Reviewed by Ojan Vafai.
2773
2774         style-queue messages are way too long for big patches
2775         https://bugs.webkit.org/show_bug.cgi?id=52161
2776
2777         We definitely could build much fancier list-to-string-with-limit functions
2778         but this should be sufficient for our needs at the moment.
2779
2780         * Scripts/webkitpy/common/system/executive.py:
2781         * Scripts/webkitpy/common/system/executive_unittest.py:
2782
2783 2011-01-10  Tony Chang  <tony@chromium.org>
2784
2785         Unreviewed, rolling out r75398.
2786         http://trac.webkit.org/changeset/75398
2787         https://bugs.webkit.org/show_bug.cgi?id=52008
2788
2789         Some layout tests are crashing on Chromium Win.
2790
2791         * DumpRenderTree/chromium/WebViewHost.cpp:
2792         (WebViewHost::updatePaintRect):
2793         * DumpRenderTree/chromium/WebViewHost.h:
2794
2795 2011-01-10  Adam Roben  <aroben@apple.com>
2796
2797         Roll out r75392
2798
2799         It isn't needed now that r75289 has been rolled out.
2800
2801         * Scripts/run-javascriptcore-tests:
2802
2803 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2804
2805         Reviewed by Anders Carlsson.
2806
2807         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2808         https://bugs.webkit.org/show_bug.cgi?id=52160
2809
2810         * WebKitTestRunner/mac/TestControllerMac.mm:
2811         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2812         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2813         anyway.
2814
2815 2011-01-10  Tony Chang  <tony@chromium.org>
2816
2817         Reviewed by Mihai Parparita.
2818
2819         [chromium] fix for animated gif layout tests
2820         https://bugs.webkit.org/show_bug.cgi?id=52008
2821
2822         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2823             to trigger gif animations.
2824         (WebViewHostPaintTask::WebViewHostPaintTask):
2825         (WebViewHostPaintTask::runIfValid):
2826         (WebViewHost::updatePaintRect):
2827         * DumpRenderTree/chromium/WebViewHost.h:
2828         (WebViewHost::taskList):
2829
2830 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2831
2832         Reviewed by Xan Lopez.
2833
2834         [GTK] Fix gtk2 compilation for master
2835         https://bugs.webkit.org/show_bug.cgi?id=51885
2836
2837         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2838         (createBitmapContextFromWebView): Replaced the old
2839         gdk_drawable_get_size with gdk_pixmap_get_size.
2840
2841 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2842
2843         Reviewed by Laszlo Gombos.
2844
2845         [WINCE] Reenable NPAPI after r75203
2846         https://bugs.webkit.org/show_bug.cgi?id=52109
2847
2848         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2849         it with !isEfl(), because EFL port does not support NPAPI (yet).
2850
2851         * Scripts/build-webkit:
2852
2853 2011-01-10  Adam Roben  <aroben@apple.com>
2854
2855         Skip some asserting JS tests
2856
2857         See <http://webkit.org/b/52156>.
2858
2859         * Scripts/run-javascriptcore-tests:
2860
2861 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2862
2863         Reviewed by Xan Lopez.
2864
2865         [GTK] build-webkit disable Blob support via arguments passed to automake
2866         https://bugs.webkit.org/show_bug.cgi?id=52097
2867
2868         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2869         build-webkit.
2870
2871 2011-01-10  Adam Roben  <aroben@apple.com>
2872
2873         Use the same name and description for TestNetscapePlugin on Windows and
2874         Mac
2875
2876         Fixes <http://webkit.org/b/52151>
2877         fast/frames/iframe-reparenting-plugins.html fails on Windows
2878
2879         Reviewed by Steve Falkenburg.
2880
2881         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2882         the name and description from Mac's Info.plist.
2883
2884 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2885
2886         Reviewed by Laszlo Gombos.
2887
2888         [Qt][WK2] Guard gcc-specific syntax
2889
2890         Non-gcc based compliers choke on the "-include"
2891         syntax for preinclude, place guard around it.
2892
2893         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2894         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2895
2896 2011-01-10  Andreas Kling  <kling@webkit.org>
2897
2898         Reviewed by Simon Hausmann.
2899
2900         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2901         https://bugs.webkit.org/show_bug.cgi?id=52111
2902
2903         When getting a createNewPage() callback from QWKPage, create the
2904         new page with the same QWKContext as the page that is passed to
2905         the callback.
2906
2907         * MiniBrowser/qt/BrowserView.h:
2908         * MiniBrowser/qt/BrowserWindow.cpp:
2909         (newPageFunction):
2910         (BrowserWindow::BrowserWindow):
2911         * MiniBrowser/qt/BrowserWindow.h:
2912
2913 2011-01-10  Andreas Kling  <kling@webkit.org>
2914
2915         Reviewed by Kenneth Rohde Christiansen.
2916
2917         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2918
2919         BrowserView set its own useless createNewPage() callback on QWKPage.
2920         This was immediately overridden by BrowserWindow anyway, so remove
2921         the BrowserView one.
2922
2923         * MiniBrowser/qt/BrowserView.cpp:
2924         (BrowserView::BrowserView):
2925
2926 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2927
2928         Reviewed by Jeremy Orlow.
2929
2930         [Chromium] Remove non-client-based Geolocation code
2931         https://bugs.webkit.org/show_bug.cgi?id=50921
2932
2933         * DumpRenderTree/chromium/LayoutTestController.cpp:
2934         (LayoutTestController::setGeolocationPermission):
2935         (LayoutTestController::setMockGeolocationPosition):
2936         (LayoutTestController::setMockGeolocationError):
2937         * DumpRenderTree/chromium/WebViewHost.cpp:
2938         (WebViewHost::geolocationClientMock):
2939         (WebViewHost::reset):
2940         * DumpRenderTree/chromium/WebViewHost.h:
2941
2942 2011-01-10  Eric Seidel  <eric@webkit.org>
2943
2944         Reviewed by Adam Barth.
2945
2946         Commit bot tried to land r? cq+ patch
2947         https://bugs.webkit.org/show_bug.cgi?id=36638
2948
2949         It should now be possible to post a patch with r? and cq+ and the
2950         commit-queue will correctly wait for the r+ before attempting to land the patch.
2951         (This was a feature requested by several users.)
2952
2953         One caveat: We don't actually reject r-, cq+ patches from the queue
2954         (we just ignore them), but I think that's OK for now.
2955
2956         I also noticed that setting r- once a commit-queue node had grabbed
2957         a patch would not properly cancel the landing.  That's fixed and
2958         tested in this patch.
2959
2960         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2961         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2962         * Scripts/webkitpy/tool/bot/feeders.py:
2963         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2964
2965 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2966
2967         Reviewed by Kenneth Rohde Christiansen.
2968
2969         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2970         https://bugs.webkit.org/show_bug.cgi?id=51934
2971
2972         When accessing the network from the destructor of QWebPage, the network access manager
2973         was already deleted because the object WebPage was already destructed.
2974
2975         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2976         The object is now destructed in the destructor of QObject.
2977
2978         * QtTestBrowser/webpage.cpp:
2979         (WebPage::WebPage):
2980         (WebPage::setQnamThreaded):
2981         * QtTestBrowser/webpage.h:
2982         (QtNAMThread::QtNAMThread):
2983
2984 2011-01-08  Eric Seidel  <eric@webkit.org>
2985
2986         Reviewed by Ojan Vafai.
2987
2988         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2989         https://bugs.webkit.org/show_bug.cgi?id=52067
2990
2991         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2992         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2993
2994         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2995
2996 2011-01-08  Eric Seidel  <eric@webkit.org>
2997
2998         Reviewed by Mihai Parparita.
2999
3000         commit-queue hangs when the ChangeLog diff is bad
3001         https://bugs.webkit.org/show_bug.cgi?id=52072
3002
3003         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3004         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3005
3006 2011-01-08  Adam Barth  <abarth@webkit.org>
3007
3008         Teach svn-apply how to re-write WebCore to Source/WebCore.
3009
3010         * Scripts/VCSUtils.pm:
3011
3012 2011-01-07  Adam Barth  <abarth@webkit.org>
3013
3014         Rubber-stamped by Eric Seidel.
3015
3016         Move WebCore to Source
3017         https://bugs.webkit.org/show_bug.cgi?id=52050
3018
3019         Update the tools to understand WebCore's new location.
3020
3021         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3022         * DumpRenderTree/wscript:
3023         * GNUmakefile.am:
3024         * Scripts/build-webkit:
3025         * Scripts/do-file-rename:
3026         * Scripts/do-webcore-rename:
3027         * Scripts/generate-qt-inspector-resource:
3028         * Scripts/prepare-ChangeLog:
3029         * Scripts/run-bindings-tests:
3030         * Scripts/update-iexploder-cssproperties:
3031         * Scripts/update-sources-list.py:
3032         * Scripts/update-webkit-localizable-strings:
3033         * Scripts/webkitdirs.pm:
3034         * Scripts/webkitpy/common/config/build.py:
3035         * Scripts/webkitpy/common/config/build_unittest.py:
3036         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3037         * Scripts/webkitpy/style/checker.py:
3038         * Scripts/webkitpy/style/checker_unittest.py:
3039         * WebKitTestRunner/DerivedSources.pro:
3040         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3041         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3042         * wx/browser/wscript:
3043         * wx/build/settings.py:
3044
3045 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3046
3047         Reviewed by Sam Weinig.
3048
3049         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3050         https://bugs.webkit.org/show_bug.cgi?id=52086
3051
3052         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3053         (WTR::InjectedBundle::didReceiveMessage):
3054         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3055         (WTR::LayoutTestController::notifyDone):
3056         * WebKitTestRunner/TestController.cpp:
3057         (WTR::TestController::resetStateToConsistentValues):
3058         (WTR::TestController::run):
3059
3060 2011-01-07  James Robinson  <jamesr@chromium.org>
3061
3062         Revert "Implement mozilla's animationTime property"
3063         https://bugs.webkit.org/show_bug.cgi?id=51952
3064
3065         This approach isn't quite right.
3066
3067         * DumpRenderTree/chromium/WebViewHost.cpp:
3068         (WebViewHost::paintInvalidatedRegion):
3069
3070 2011-01-07  Adam Roben  <aroben@apple.com>
3071
3072         Build master fix
3073
3074         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3075         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3076
3077 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3078
3079         Reviewed by Csaba Osztrogonác.
3080
3081         run-qtwebkit-tests should be able to kill a testsuite.
3082
3083         Add new option in the script that can setup a timeout for a test.
3084         If the test execution takes more then specified time then the test
3085         would be terminated.
3086
3087         [Qt] run-qtwebkit-tests needs timeout
3088         https://bugs.webkit.org/show_bug.cgi?id=51894
3089
3090         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3091         * Scripts/run-qtwebkit-tests:
3092
3093 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3094
3095         Unreviewed fix after r75233.
3096
3097         Based on idea from Eric Seidel.
3098
3099         Add remote zip file handling to webkitpy.
3100         https://bugs.webkit.org/show_bug.cgi?id=50901
3101
3102         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3103
3104 2011-01-07  Shane Stephens  <shanestephens@google.com>
3105
3106         Reviewed by Eric Seidel.
3107
3108         svn-apply: should support git binary delta diffs
3109         https://bugs.webkit.org/show_bug.cgi?id=38864
3110
3111         * Scripts/VCSUtils.pm:
3112         * Scripts/svn-apply:
3113
3114 2011-01-06  Julie Parent  <jparent@chromium.org>
3115
3116         Reviewed by Eric Seidel.
3117
3118         Test Result Server not removing old results.
3119         https://bugs.webkit.org/show_bug.cgi?id=52012
3120
3121         * TestResultServer/model/jsonresults.py:
3122         Fix off-by-one: Truncate if >= num_runs, not just >.
3123         * TestResultServer/model/jsonresults_unittest.py:
3124         Add unit test to test that merging in a new result with the same value
3125         as the last result causes previous result to fall off.
3126
3127 2011-01-06  James Kozianski  <koz@chromium.org>
3128
3129         Reviewed by Mihai Parparita.
3130
3131         Add classes to provide a consistent interface to a set of files.
3132         https://bugs.webkit.org/show_bug.cgi?id=50901
3133
3134         These classes allow us to write code that is agnostic to whether a
3135         particular set of files resides in a local directory or in a zip file
3136         on a remote machine.
3137
3138         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3139         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3140         * Scripts/webkitpy/common/system/fileset.py: Added.
3141         * Scripts/webkitpy/common/system/filesystem.py:
3142         * Scripts/webkitpy/common/system/filesystem_mock.py:
3143         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3144         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3145
3146 2011-01-06  Eric Seidel  <eric@webkit.org>
3147
3148         Reviewed by Adam Barth.
3149
3150         NetworkTransaction should log the url it is retrying
3151         https://bugs.webkit.org/show_bug.cgi?id=52043
3152
3153         * Scripts/webkitpy/common/net/networktransaction.py:
3154         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3155
3156 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3157
3158         Windows build fix.
3159         Import os before using it.
3160
3161         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3162
3163 2011-01-06  Eric Seidel  <eric@webkit.org>
3164
3165         Reviewed by Adam Barth.
3166
3167         StyleQueue fails to report errors when patches have many files
3168         https://bugs.webkit.org/show_bug.cgi?id=52042
3169
3170         This is one of at least two errors preventing style error reporting at the moment.
3171         When we moved to passing the list of files to check explicitly,
3172         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3173         We could change the type of the QueueStatus.message type, or we could
3174         just teach statusserver.py how to clamp values (and warn when it does).
3175         I chose the latter path.
3176
3177         * Scripts/webkitpy/common/net/statusserver.py:
3178
3179 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3180
3181         Reviewed by Stephanie Lewis.
3182         
3183         Fix syntax error in script.
3184
3185         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3186         https://bugs.webkit.org/show_bug.cgi?id=51996
3187
3188         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3189
3190 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3191
3192         Unreviewed, fixing WinCE build after r75196.
3193
3194         WinCE port does not (yet) support NPAPI.
3195
3196         * Scripts/build-webkit:
3197
3198 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3199
3200         Reviewed by Darin Adler.
3201
3202         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3203         https://bugs.webkit.org/show_bug.cgi?id=52015
3204
3205         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3206         after the platform has been detected, otherwise the script will
3207         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3208         detection.
3209
3210 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3211
3212         Reviewed by Eric Seidel.
3213
3214         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3215         https://bugs.webkit.org/show_bug.cgi?id=51346
3216
3217         * Scripts/build-webkit:
3218
3219 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3220
3221         Reviewed by Adam Roben.
3222
3223         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3224         https://bugs.webkit.org/show_bug.cgi?id=51996
3225         
3226         After the configuration directory change, we were archiving the incorrect directory for
3227         build product, so we were running tests on the wrong binaries.
3228         
3229         This change archives the correct directory, and also unarchives it into a configuration-
3230         specific directory.
3231
3232         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3233         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3234
3235 2011-01-06  Eric Seidel  <eric@webkit.org>
3236
3237         Reviewed by Mihai Parparita.
3238
3239         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3240         https://bugs.webkit.org/show_bug.cgi?id=52002
3241
3242         See an example of this here:
3243         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3244
3245         It's due to the fact that we pass around TestFailure() instance
3246         objects and yet expect them to all compare to be the same.
3247
3248         This is bad.  We should either have shared instances of these values
3249         or we should just pass around the class names.  There are already hacks
3250         in place to make TestFailure objects pass equality tests, I just added
3251         a __hash__ implementation so they can be used in sets as expected.
3252
3253         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3254         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3255
3256 2011-01-06  Evan Martin  <evan@chromium.org>
3257
3258         Reviewed by Tony Chang.
3259
3260         [gdb] handle inaccessible memory and UChar*
3261         https://bugs.webkit.org/show_bug.cgi?id=52003
3262
3263         To pretty-print a UChar*, we just grope around in the memory
3264         looking for a terminating NUL.  We need to handle the exception
3265         that can occur when we poke into an invalid location.
3266
3267         Additionally, the logic for choosing which pretty-printer would
3268         early return before hitting the point where we'd use the UChar*
3269         printer.  (Did this ever work?  How did it regress?)
3270
3271         * gdb/webkit.py:
3272
3273 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3274
3275         Reviewed by Ada Chan.
3276
3277         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3278         https://bugs.webkit.org/show_bug.cgi?id=51969
3279         
3280         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3281
3282         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3283         (WTR::InjectedBundlePage::InjectedBundlePage):
3284         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3285         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3286
3287 2011-01-06  James Robinson  <jamesr@chromium.org>
3288
3289         Reviewed by Simon Fraser.
3290
3291         Implement mozilla's animationTime property
3292         https://bugs.webkit.org/show_bug.cgi?id=51952
3293
3294         Chromium DRT support for webkitAnimationTime.
3295
3296         * DumpRenderTree/chromium/WebViewHost.cpp:
3297         (WebViewHost::paintInvalidatedRegion):
3298
3299 2011-01-06  Julie Parent  <jparent@chromium.org>
3300
3301         Reviewed by Tony Chang.
3302
3303         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3304         https://bugs.webkit.org/show_bug.cgi?id=51217
3305
3306         * TestResultServer/model/jsonresults.py:
3307         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3308         Adds missing documentation.
3309         * TestResultServer/model/jsonresults_unittest.py:
3310         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3311         Update test_merge to take a number of builds to truncate at.
3312
3313 2011-01-06  Adam Barth  <abarth@webkit.org>
3314
3315         Reviewed by Eric Seidel.
3316
3317         The EWS should log outside of the working directory
3318         https://bugs.webkit.org/show_bug.cgi?id=51986
3319
3320         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3321         script, which will actually clean the working copy back to a pristine
3322         state instead of leaving untracked directories and ignored files.
3323
3324         * Scripts/webkitpy/tool/commands/queues.py:
3325         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3326
3327 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3328
3329         Windows build fix.
3330         Back out attempted change to built-product-archive.
3331
3332         * BuildSlaveSupport/built-product-archive:
3333
3334 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3335
3336         Windows build fix.
3337         Include configuration name when unpacking a build archive.
3338
3339         Needed, since we split Windows build results into configuration-specific directories
3340         under WebKitOutputDir.
3341
3342         * BuildSlaveSupport/built-product-archive:
3343
3344 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3345
3346         Reviewed by Darin Adler.
3347
3348         Debug and Release builds on Windows clobber each other
3349         https://bugs.webkit.org/show_bug.cgi?id=49185
3350
3351         Changes the structure of WebKitBuild build products directory so we
3352         completely separate each build configuration into independent directories.
3353         
3354         Although we previously had per-configuration directories for obj, this change adds
3355         per-configuration directories for bin, lib, obj, and include. Each configuration's
3356         build products are stored within a directory inside of WebKitBuild.
3357         
3358         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3359         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3360
3361         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3362         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3363         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3364         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3365         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3366         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3367         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3368         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3369         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3370         * FindSafari/FindSafari.vcproj:
3371         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3372         * MiniBrowser/MiniBrowserPostBuild.cmd:
3373         * MiniBrowser/MiniBrowserPreBuild.cmd:
3374         * Scripts/webkitdirs.pm:
3375         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3376         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3377         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3378         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3379         * TestWebKitAPI/win/copy-resources.cmd:
3380         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3381         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3382         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3383         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3384         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3385         * WebKitTestRunner/win/InjectedBundle.vcproj:
3386         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3387         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3388         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3389         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3390         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3391         * WinLauncher/WinLauncherCommon.vsprops:
3392         * WinLauncher/WinLauncherPostBuild.cmd:
3393         * WinLauncher/WinLauncherPreBuild.cmd:
3394
3395 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3396
3397         Reviewed by Ariya Hidayat.
3398
3399         [Qt] TestNetscapePlugin doesn't link on OS X
3400         https://bugs.webkit.org/show_bug.cgi?id=51948
3401
3402         Only add a dependency on libX11 on X11 systems
3403
3404         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3405
3406 2011-01-05  Jeff Miller  <jeffm@apple.com>
3407
3408         Reviewed by Adam Roben.
3409
3410         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3411         https://bugs.webkit.org/show_bug.cgi?id=51970
3412
3413         * Scripts/webkitpy/style/checker.py:
3414         Add -readability/naming for WebKit2 C API directories.
3415
3416 2011-01-05  Eric Seidel  <eric@webkit.org>
3417
3418         Unreviewed, just fixing one more log error from my previous python patch.
3419
3420         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3421         https://bugs.webkit.org/show_bug.cgi?id=51802
3422
3423         webkit-patch failure-reason was logging about parsing errors
3424         due to my misunderstanding of how BeautifulSoup.findAll worked.
3425
3426         Fixed, and added a unit test.
3427
3428         * Scripts/webkitpy/common/net/layouttestresults.py:
3429         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3430
3431 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3432
3433         Reviewed by Kenneth Rohde Christiansen.
3434
3435         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3436         https://bugs.webkit.org/show_bug.cgi?id=51951
3437
3438         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3439         to create new window from WebKit.
3440
3441         * MiniBrowser/qt/BrowserWindow.cpp:
3442         (newPageFunction):
3443         (BrowserWindow::BrowserWindow):
3444         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3445         (BrowserWindow::newWindow):
3446         (BrowserWindow::updateUserAgentList):
3447         (BrowserWindow::showUserAgentDialog):
3448         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3449         define the type of the backing store used for new windows.
3450         * MiniBrowser/qt/main.cpp:
3451         (main):
3452
3453 2011-01-05  Eric Seidel  <eric@webkit.org>
3454
3455         Reviewed by Ojan Vafai.
3456
3457         commit-queue should report failure type when reporting flaky tests
3458         https://bugs.webkit.org/show_bug.cgi?id=51900
3459
3460         This patch was a ridiculous amount of plumbing.  In the end I like
3461         the NRWT-style TestResult class even less.  But now we're passing
3462         a list of TestResult objects from the queue to the FlakyTestReporter.
3463         Thus the FlakyTestReporter can more easily report what type of failure
3464         occurred.
3465
3466         In the process, I found that I was not alone in finding TestResult
3467         cumbersome to use.  A bunch of code was trying to create a TestResult
3468         object with default values.  However since the constructor didn't make
3469         this easy, some places were getting it wrong (including the TestResult unit test)!
3470         I've fixed the TestResult constructor to have default values for non-essential
3471         arguments.
3472
3473         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3474         * Scripts/webkitpy/common/net/layouttestresults.py:
3475         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3476         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3477         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3478         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3479         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3480         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3481         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3482         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3483         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3484         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3485         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3486         * Scripts/webkitpy/tool/commands/queues.py:
3487         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3488
3489 2011-01-05  Eric Seidel  <eric@webkit.org>
3490
3491         Unreviewed.
3492
3493         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3494         https://bugs.webkit.org/show_bug.cgi?id=51802
3495
3496         Add another unit test to cover a previously missing import.
3497
3498         * Scripts/webkitpy/common/net/layouttestresults.py:
3499         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3500
3501 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3502
3503         Reviewed by David Levin.
3504
3505         Add mihaip@chromium.org as a reviewer
3506         https://bugs.webkit.org/show_bug.cgi?id=51966
3507         
3508         Add myself as a reviewer.
3509
3510         * Scripts/webkitpy/common/config/committers.py:
3511
3512 2011-01-05  James Simonsen  <simonjam@chromium.org>
3513
3514         Unreviewed. Adding myself to the list of committers.
3515
3516         * Scripts/webkitpy/common/config/committers.py:
3517
3518 2011-01-05  Eric Seidel  <eric@webkit.org>
3519
3520         Unreviewed.
3521
3522         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3523         https://bugs.webkit.org/show_bug.cgi?id=51802
3524
3525         Fix two exceptions seen on the bots after my original commit.
3526
3527         * Scripts/webkitpy/common/net/layouttestresults.py:
3528         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3529
3530 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3531
3532         Reviewed by Andreas Kling.
3533
3534         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3535         https://bugs.webkit.org/show_bug.cgi?id=51750
3536
3537         * QtTestBrowser/main.cpp:
3538         (LauncherApplication::handleUserOptions):
3539          Local storage settings can be enable form command line arguments for
3540          QtTestBrowser.
3541
3542 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3543
3544         Reviewed by Martin Robinson.
3545
3546         GTK: AX: DRT needs to use correct root object method.
3547         https://bugs.webkit.org/show_bug.cgi?id=51911
3548
3549         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3550         (AccessibilityController::rootElement):
3551
3552 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3553
3554         Rubber-stamped by Csaba Osztrogonác.
3555
3556         Based on idea from Péter Gál.
3557
3558         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3559
3560 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3561
3562         Reviewed by Adam Barth.
3563
3564         sheriff-bot should be able to do multi-revision rollouts
3565         https://bugs.webkit.org/show_bug.cgi?id=51176
3566
3567         * Scripts/webkitpy/tool/bot/irc_command.py:
3568         * Scripts/webkitpy/tool/bot/sheriff.py:
3569         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3570
3571 2011-01-05  Eric Seidel  <eric@webkit.org>
3572
3573         Reviewed by Adam Barth.
3574
3575         queues.webkit.org should have per-bot status pages
3576         https://bugs.webkit.org/show_bug.cgi?id=51906
3577
3578         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3579         statuses from a single queue.  Now that we have many bots servicing
3580         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3581         you care about scroll off the end of the 15-message limit on the main page.
3582
3583         Eventually we should probably rename /queue-status to /queue or /queues,
3584         but that's fodder for another patch.
3585
3586         * QueueStatusServer/handlers/queuestatus.py:
3587         * QueueStatusServer/index.yaml:
3588         * QueueStatusServer/main.py:
3589         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3590          - This probably should use a custom filter instead of hard-coding
3591            the URL scheme here, but I couldn't figure out how to easily
3592            create such a filter.  Most filters work with "strings" so we can't
3593            pass the status object.  We could add a method to the status
3594            object and call that, but that seemed a bit strange too.
3595         * QueueStatusServer/templates/queuestatus.html:
3596
3597 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3598
3599         Unreviewed. Adding myself to the list of committers.
3600
3601         * Scripts/webkitpy/common/config/committers.py:
3602
3603 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3604
3605         Reviewed by David Levin.
3606
3607         check-webkit-style treated some macros with parentheses after #elif as function calls
3608         https://bugs.webkit.org/show_bug.cgi?id=51695
3609
3610         Ingore function call space checking in any preprocessor directives
3611         (things starting with #). Change search() to match() because 
3612         preprocessor directives are supposed to be in the beginning of lines.
3613
3614         * Scripts/webkitpy/style/checkers/cpp.py:
3615         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3616
3617 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3618
3619         Reviewed by Tony Chang.
3620
3621         Change the --multi-load test option to --stress-opt
3622         https://bugs.webkit.org/show_bug.cgi?id=50751
3623
3624         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3625         (runTest):
3626         (main):
3627         * DumpRenderTree/chromium/TestShell.cpp:
3628         (TestShell::TestShell):
3629         * DumpRenderTree/chromium/TestShell.h:
3630         (TestShell::stressOpt):
3631         (TestShell::setStressOpt):
3632         (TestShell::stressDeopt):
3633         (TestShell::setStressDeopt):
3634         (TestShell::javaScriptFlags):
3635         (TestShell::setJavaScriptFlags):
3636         * Scripts/webkitpy/layout_tests/port/chromium.py:
3637         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3638
3639 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3640
3641         Reviewed by Sam Weinig.
3642
3643         WK2: Support Accessibility
3644         https://bugs.webkit.org/show_bug.cgi?id=51859
3645
3646         Use rootObject() method to get top of accessibility tree.
3647
3648         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3649         (AccessibilityController::focusedElement):
3650         (AccessibilityController::rootElement):
3651
3652 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3653
3654         Reviewed by Darin Adler.
3655
3656         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3657         https://bugs.webkit.org/show_bug.cgi?id=51846
3658
3659         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3660         back to GRefPtr.
3661
3662 2011-01-04  Zhe Su  <suzhe@chromium.org>
3663
3664         Reviewed by Kenneth Russell.
3665
3666         Fix insertText, setMarkedText and unmarkText methods of
3667         TextInputController to call corresponding methods of WebKit::WebView
3668         rather than WebKit::WebFrame. This change matches the behavior of
3669         chromium browser.
3670         insertText corresponds to WebView::confirmComposition(text)
3671         setMarkedText corresponds to WebView::setComposition(...)
3672         unmarkText corresponds to WebView::confirmComposition()
3673         https://bugs.webkit.org/show_bug.cgi?id=51693
3674
3675         * DumpRenderTree/chromium/TextInputController.cpp:
3676         (TextInputController::insertText):
3677         (TextInputController::setMarkedText):
3678         (TextInputController::unmarkText):
3679
3680 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3681
3682         Reviewed by Laszlo Gombos.
3683
3684         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3685
3686         On Symbian productDir points to the source directory. Removing all the
3687         empty files from the productDir directory corrupts the svn repository.
3688
3689         * Scripts/build-webkit:
3690
3691 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3692
3693         Reviewed by Adam Barth.
3694
3695         [Qt] Add SelectAll option to the context menu for the editor
3696         https://bugs.webkit.org/show_bug.cgi?id=50049
3697
3698         Set shortcut for the SelectAll action.
3699
3700         * QtTestBrowser/mainwindow.cpp:
3701         (MainWindow::buildUI):
3702
3703 2011-01-03  David Levin  <levin@chromium.org>
3704
3705         Reviewed by Eric Seidel.
3706
3707         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3708         https://bugs.webkit.org/show_bug.cgi?id=51842
3709
3710         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3711         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3712
3713 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3714
3715         Reviewed by David Kilzer.
3716
3717         [WINCE] Adds a build slave.
3718         https://bugs.webkit.org/show_bug.cgi?id=50523
3719
3720         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3721         entry for a release build of the WinCE port.
3722         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3723         flag to build the WinCE port.
3724
3725 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3726
3727         Reviewed by David Kilzer.
3728
3729         Add WinCE support to build-webkit
3730         https://bugs.webkit.org/show_bug.cgi?id=51642
3731
3732         * Scripts/build-webkit:
3733         * Scripts/webkitdirs.pm:
3734
3735 2011-01-03  Eric Seidel  <eric@webkit.org>
3736
3737         Reviewed by Adam Barth.
3738
3739         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3740         https://bugs.webkit.org/show_bug.cgi?id=51802
3741
3742         I'm not the biggest fan of the test_failures or test_results classes,
3743         but it's better to have one shared set of classes, than separate ones
3744         for new vs. old run-webkit-test result handling.
3745
3746         This moves the ORWT results class "LayoutTestResults" over to using
3747         TestResult and TestFailure classes, making it easy for us to
3748         make all our sheriff-bot and other webkitpy code NRWT ready.
3749
3750         This also makes it a trivial patch to generate results.json information
3751         from ORWT results.html files (for flaky test analysis, etc.) as well
3752         as making it a one-liner to report test failure types when the
3753         commit-queue sees flaky tests.
3754
3755         This patch tried not to add new functionality, but only to replace
3756         the guts of LayoutTestResults, while adding unit tests and hoping
3757         not to break anything.
3758
3759         I also moved callers which assumed User.prompt* were static/class methods
3760         to using them as instance methods (since we'll eventually want to make them such).
3761
3762         In the process of re-writing things, I broke the rebaseline command, so I wrote
3763         a unit test to catch my breakage were I do do so again in the future.
3764
3765         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3766         * Scripts/webkitpy/common/net/layouttestresults.py:
3767         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3768         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3769         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3770         * Scripts/webkitpy/tool/commands/queries.py:
3771         * Scripts/webkitpy/tool/commands/rebaseline.py:
3772         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3773         * Scripts/webkitpy/tool/mocktool.py:
3774
3775 2011-01-03  Adam Barth  <abarth@webkit.org>
3776
3777         Reviewed by Simon Fraser.
3778
3779         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3780         https://bugs.webkit.org/show_bug.cgi?id=51840
3781
3782         * Scripts/webkitpy/common/checkout/scm.py:
3783
3784 2011-01-03  Adam Barth  <abarth@webkit.org>
3785
3786         Reviewed by Simon Fraser.
3787
3788         webkit