Stop python icon bouncing in the dock while running browser benchmarks.
[WebKit.git] / Tools / ChangeLog
1 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
2
3         Stop python icon bouncing in the dock while running browser benchmarks.
4         https://bugs.webkit.org/show_bug.cgi?id=161066
5
6         Reviewed by Ryosuke Niwa.
7
8         Bouncing python icon may impact browser benchmark results.
9         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
10         (OSXBrowserDriver.prepare_env):
11         (OSXBrowserDriver.restore_env):
12
13 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
14
15         <select> menu on iPad causes shifting of hit-testing areas
16         https://bugs.webkit.org/show_bug.cgi?id=150079
17
18         Reviewed by Tim Horton.
19
20         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
21         so when it changes we have to update visible rects. We were doing this on focus, but failing
22         to do it on blur.
23
24         Added the ability to test by:
25         1. Making it possible to initiate an animated scroll in the UI process
26         2. Adding callbacks for starting and ending interaction with a form control. Sadly
27         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
28         have no way currently to know when the dimming view behind the popover animates out,
29         so for now the test keeps trying to tap a button.
30
31         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
32         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
33         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
34         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
35         (WTR::UIScriptController::didStartFormControlInteractionCallback):
36         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
37         (WTR::UIScriptController::didEndFormControlInteractionCallback):
38         (WTR::UIScriptController::scrollToOffset):
39         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
40         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
41         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
42         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
43         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
44         (-[TestRunnerWKWebView dealloc]):
45         (-[TestRunnerWKWebView didStartFormControlInteraction]):
46         (-[TestRunnerWKWebView didEndFormControlInteraction]):
47         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
48         (WTR::contentOffsetBoundedInValidRange):
49         (WTR::UIScriptController::scrollToOffset):
50         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
51         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
52
53 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
54
55         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
56         https://bugs.webkit.org/show_bug.cgi?id=160927
57
58         Reviewed by Daniel Bates.
59
60         * Scripts/process-linux-coredump: Removed.
61         * Scripts/webkitpy/port/efl.py:
62         (EflPort._get_crash_log):
63         * Scripts/webkitpy/port/gtk.py:
64         (GtkPort._get_crash_log):
65         * Scripts/webkitpy/port/linux_get_crash_log.py:
66         (GDBCrashLogGenerator.__init__):
67         (GDBCrashLogGenerator.generate_crash_log):
68         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
69         (GDBCrashLogGeneratorTest.test_generate_crash_log):
70
71 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
72
73         check-webkit-style does not work with Lambda functions in C++
74         https://bugs.webkit.org/show_bug.cgi?id=160910
75
76         Reviewed by Darin Adler.
77
78         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
79
80         * Scripts/webkitpy/style/checkers/cpp.py:
81         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
82         (check_for_non_standard_constructs): Added lambda function check.
83         (check_spacing_for_function_call): Added lambda function check.
84         (check_braces): Added lambda function check.
85         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
86         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
87
88 2016-08-21  Alex Christensen  <achristensen@webkit.org>
89
90         URLParser should parse IPv4 addresses
91         https://bugs.webkit.org/show_bug.cgi?id=161023
92
93         Reviewed by Darin Adler.
94
95         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
96         (TestWebKitAPI::TEST_F):
97         (TestWebKitAPI::checkURLDifferences):
98         We are already getting differences between the old URL::parse and the new URLParser.
99         (TestWebKitAPI::shouldFail):
100
101 2016-08-21  Daniel Bates  <dabates@apple.com>
102
103         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
104         https://bugs.webkit.org/show_bug.cgi?id=148437
105
106         Reviewed by Dan Bernstein.
107
108         * Scripts/prepare-ChangeLog:
109         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
110         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
111         assumes that its line ranges were from a unified diff without any context lines.
112         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
113         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
114         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
115         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
116         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
117         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
118         to /dev/null for the duration of the function call.
119
120 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
121
122         [EFL] Remove unnecessary a patch to mute ecore warnings
123         https://bugs.webkit.org/show_bug.cgi?id=160997
124
125         Reviewed by Darin Adler.
126
127         There is no warning messages during the layout test and perf test
128         after bumping efl version from 1.17 to 1.18. Remove it.
129
130         * efl/patches/ecore_remove_warnings.patch: Removed.
131
132 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
133
134         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
135         https://bugs.webkit.org/show_bug.cgi?id=160985
136
137         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
138         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
139         with that.
140
141         * Scripts/webkitpy/layout_tests/views/printing.py:
142         (Printer.print_config):
143         * Scripts/webkitpy/port/base.py:
144         (Port.driver_cmd_line_for_logging):
145         (Port.driver_cmd_line): Deleted.
146         * Scripts/webkitpy/port/driver.py:
147         (IOSSimulatorDriver.cmd_line):
148         * Scripts/webkitpy/port/ios.py:
149         (IOSSimulatorPort.__init__):
150         (IOSSimulatorPort.driver_cmd_line_for_logging):
151         (IOSSimulatorPort._create_simulators):
152         (IOSSimulatorPort.setup_test_run):
153         (IOSSimulatorPort._quit_ios_simulator):
154         (IOSSimulatorPort.clean_up_test_run):
155         (IOSSimulatorPort._create_device):
156         (IOSSimulatorPort):
157         (IOSSimulatorPort._remove_device):
158         (IOSSimulatorPort._testing_device):
159         (IOSSimulatorPort.device_id_for_worker_number):
160         (IOSSimulatorPort._set_device_class): Deleted.
161         (IOSSimulatorPort.testing_device): Deleted.
162         * Scripts/webkitpy/port/port_testcase.py:
163         (PortTestCase.test_driver_cmd_line):
164         * Scripts/webkitpy/xcode/simulator.py:
165         (Device.shutdown):
166         (Device):
167         (Device.delete):
168         (Device.reset):
169         (Simulator):
170         (Simulator.create_device):
171         (Simulator.remove_device):
172         (Simulator.device_number):
173         (Simulator.device_state_description):
174         (Simulator.wait_until_device_is_in_state):
175
176 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
177
178         Unreviewed, rolling out r204659.
179
180         This change appears to have caused ios-simulator LayoutTests
181         to fail when shutting down the simulator
182
183         Reverted changeset:
184
185         "REGRESSION (r204477): Running LayoutTests on ios-simulator
186         became ~15 minutes slower"
187         https://bugs.webkit.org/show_bug.cgi?id=160985
188         http://trac.webkit.org/changeset/204659
189
190 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
191
192         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
193         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
194
195 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
196
197         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
198         https://bugs.webkit.org/show_bug.cgi?id=160985
199
200         Reviewed by Alexey Proskuryakov.
201         
202         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
203         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
204         must not be @memoized, because their return value depends on the value of simulator_device_type().
205         
206         Fix by adding some global state in simulator.py that tracks the created devices 
207         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
208         and delete them in clean_up_test_run().
209         
210         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
211         that killing the Simulator apps isn't enough.
212         
213         Simulator tracks the devices in a global dictionary, since state needs to persist
214         across different instances of IOSSimulatorPort.
215         
216         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
217         any setup. Rather than implicitly creating a device here (which the old code did),
218         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
219         and set flag to say that device_id_for_worker_number() doesn't need to return a real
220         device id.
221
222         * Scripts/webkitpy/layout_tests/views/printing.py:
223         (print_options):
224         (Printer.print_config):
225         * Scripts/webkitpy/port/base.py:
226         (Port.driver_cmd_line_for_logging):
227         (Port.driver_cmd_line): Deleted.
228         * Scripts/webkitpy/port/driver.py:
229         (IOSSimulatorDriver.cmd_line):
230         * Scripts/webkitpy/port/ios.py:
231         (IOSSimulatorPort.__init__):
232         (IOSSimulatorPort.driver_cmd_line_for_logging):
233         (IOSSimulatorPort._create_simulators):
234         (IOSSimulatorPort.setup_test_run):
235         (IOSSimulatorPort.clean_up_test_run):
236         (IOSSimulatorPort._create_device):
237         (IOSSimulatorPort):
238         (IOSSimulatorPort._remove_device):
239         (IOSSimulatorPort._testing_device):
240         (IOSSimulatorPort.device_id_for_worker_number):
241         (IOSSimulatorPort._set_device_class): Deleted.
242         (IOSSimulatorPort.testing_device): Deleted.
243         * Scripts/webkitpy/port/port_testcase.py:
244         (PortTestCase.test_driver_cmd_line):
245         * Scripts/webkitpy/xcode/simulator.py:
246         (Device.shutdown):
247         (Device.delete):
248         (Device.reset):
249         (Simulator.create_device):
250         (Simulator.remove_device):
251         (Simulator.device_number):
252         (Simulator.device_state_description):
253         (Simulator.wait_until_device_is_in_state):
254
255 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
256
257         Adopt SimServiceContext in LayoutTestRelay
258         https://bugs.webkit.org/show_bug.cgi?id=161000
259         <rdar://problem/25765594>
260
261         Reviewed by Daniel Bates.
262
263         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
264         * LayoutTestRelay/LayoutTestRelay/main.m:
265
266 2016-08-19  Lucas Forschler  <lforschler@apple.com>
267
268         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
269
270         Reviewed by Kocsen Chung.
271
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
273         (WebKitBuildbot):
274
275 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
276
277         Partial revert of r203811 - this key is not needed.
278
279         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
280
281 2016-08-19  Daniel Bates  <dabates@apple.com>
282
283         Another attempt to fix the iOS 9.3 build
284
285         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
286
287         * DumpRenderTree/mac/Configurations/Base.xcconfig:
288         * WebKitTestRunner/Configurations/Base.xcconfig:
289
290 2016-08-19  Lucas Forschler  <lforschler@apple.com>
291
292         Remove Yosemite Leaks bot from config.json
293         
294         Reviewed by Alexey Proskuryakov.
295
296         * BuildSlaveSupport/build.webkit.org-config/config.json:
297
298 2016-08-18  Dan Bernstein  <mitz@apple.com>
299
300         [Cocoa] API::Number needs to be wrapped by an NSNumber
301         https://bugs.webkit.org/show_bug.cgi?id=160977
302         <rdar://problem/27877735>
303
304         Reviewed by Anders Carlsson.
305
306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
307         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
308         (TestWebKitAPI::TEST):
309
310 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
311
312         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
313         https://bugs.webkit.org/show_bug.cgi?id=160895
314
315         Reviewed by Dean Jackson.
316
317         Link to the existing CoreText framework.
318
319         * DumpRenderTree/PlatformWin.cmake:
320         * TestWebKitAPI/PlatformWin.cmake:
321
322 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
323
324         [Win] Remove old libraries from build inputs
325         https://bugs.webkit.org/show_bug.cgi?id=160949
326
327         Reviewed by Dean Jackson.
328
329         Modify the download script to remove the old 'icuuc.lib' and
330         'icuin.lib' files for Windows builds.
331
332         * Scripts/update-webkit-auxiliary-libs:
333
334 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
335
336         Extra logging for crash reason
337         https://bugs.webkit.org/show_bug.cgi?id=160943
338
339         Reviewed by Alexey Proskuryakov.
340
341         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
342
343         * Scripts/webkitpy/port/server_process.py:
344         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
345         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
346         (ServerProcess.has_crashed): Ditto.
347
348 2016-08-17  Dan Bernstein  <mitz@apple.com>
349
350         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
351         https://bugs.webkit.org/show_bug.cgi?id=160938
352         <rdar://problem/27876652>
353
354         Reviewed by Anders Carlsson.
355
356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
357         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
358         (TestWebKitAPI::TEST):
359
360 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
361
362         AX: Support abbreviations in iOS
363         https://bugs.webkit.org/show_bug.cgi?id=160907
364
365         Reviewed by Joanmarie Diggs.
366
367         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
368         (AccessibilityUIElement::stringAttributeValue):
369         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
370         (WTR::AccessibilityUIElement::stringAttributeValue):
371
372 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
373
374         [EFL] Bump efl version from 1.17 to 1.18
375         https://bugs.webkit.org/show_bug.cgi?id=160899
376
377         Reviewed by Antonio Gomes.
378
379         To use efl-1.18, EFL port needs to update install dependencies as well.
380
381         * efl/install-dependencies:
382         * efl/jhbuild.modules:
383
384 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
385
386         [Win] Add tests for linked fonts.
387         https://bugs.webkit.org/show_bug.cgi?id=160898
388
389         Reviewed by Brent Fulgham.
390
391         Add tests for https://trac.webkit.org/changeset/204502.
392
393         * TestWebKitAPI/PlatformWin.cmake:
394         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
395         (TestWebKitAPI::TEST):
396
397 2016-08-16  Daniel Bates  <dabates@apple.com>
398
399         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
400         https://bugs.webkit.org/show_bug.cgi?id=160924
401
402         Reviewed by Stephanie Lewis.
403
404         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
405         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
406         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
407         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
408         object that mocks out the file system and SCM operations.
409
410         * Scripts/VCSUtils.pm:
411         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
412         * Scripts/prepare-ChangeLog:
413         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
414         abstracting the logic to query the file system and SCM into functions on a delegate object that
415         we pass to it.
416         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
417         (diffHeaderFormat): Deleted.
418
419 2016-08-16  Alex Christensen  <achristensen@webkit.org>
420
421         URLParser should parse URLs without credentials
422         https://bugs.webkit.org/show_bug.cgi?id=160913
423
424         Reviewed by Brady Eidson.
425
426         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
427         (TestWebKitAPI::s):
428         (TestWebKitAPI::checkURL):
429         (TestWebKitAPI::TEST_F):
430
431 2016-08-16  Anders Carlsson  <andersca@apple.com>
432
433         Add WTF::ScopeExit
434         https://bugs.webkit.org/show_bug.cgi?id=160908
435
436         Reviewed by Geoffrey Garen.
437
438         * TestWebKitAPI/CMakeLists.txt:
439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
440         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
441         (TestWebKitAPI::TEST):
442
443 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
444
445         EWS logs file are rotated too quickly
446         https://bugs.webkit.org/show_bug.cgi?id=160724
447
448         Reviewed by Daniel Bates.
449
450         Currently we are rotating the log file after 10 iterations of queue. If the queue
451         doesn't have any pending patches, these iterations result in very small amount of 
452         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
453         This results in a lot of log files in a day. This patch ensures that we rotate the
454         log file when its file size is greater than or equal to 100 KB.
455
456         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
457
458 2016-08-16  Daniel Bates  <dabates@apple.com>
459
460         WKSI static library should be named by major iOS revision, not individual updates
461         https://bugs.webkit.org/show_bug.cgi?id=160727
462         <rdar://problem/22274848>
463
464         Reviewed by Alexey Proskuryakov.
465
466         * DumpRenderTree/mac/Configurations/Base.xcconfig:
467         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
468         * Scripts/copy-webkitlibraries-to-product-directory:
469         * WebKitTestRunner/Configurations/Base.xcconfig:
470         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
471
472 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
473
474         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
475         https://bugs.webkit.org/show_bug.cgi?id=160909
476
477         Reviewed by Enrica Casucci.
478         
479         Add functions to UIScriptController to dismiss the form accessory view for iOS,
480         and to programmatically pick a row from a <select> picker.
481
482         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
483         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
484         (WTR::UIScriptController::dismissFormAccessoryView):
485         (WTR::UIScriptController::selectFormAccessoryPickerRow):
486         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
487         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
488         (WTR::UIScriptController::dismissFormAccessoryView):
489         (WTR::UIScriptController::selectFormAccessoryPickerRow):
490
491 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
492
493         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
494         https://bugs.webkit.org/show_bug.cgi?id=160878
495
496         Reviewed by Tim Horton.
497         
498         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
499         now that we have the ability to run tests in the iPad simulator.
500
501         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
502         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
503         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
504         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
505         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
506         * WebKitTestRunner/ios/TestControllerIOS.mm:
507         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
508         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
509         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
510         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
511
512 2016-08-15  Anders Carlsson  <andersca@apple.com>
513
514         Add an address-of operator to RetainPtr
515         https://bugs.webkit.org/show_bug.cgi?id=160879
516
517         Reviewed by Tim Horton.
518
519         Test HashMap and HashSet with an object whose operator& is deleted.
520
521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
522         Sort the Xcode project.
523
524         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
525         (DeletedAddressOfOperator::DeletedAddressOfOperator):
526         (DeletedAddressOfOperator::value):
527         (DeletedAddressOfOperator::operator==):
528         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
529         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
530         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
531         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
532         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
533         (TestWebKitAPI::TEST):
534         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
535         (TestWebKitAPI::TEST):
536
537 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
538
539         False crashes in fast/text/emoji-gender-* tests
540         https://bugs.webkit.org/show_bug.cgi?id=160779
541
542         Reviewed by Alexey Proskuryakov.
543
544         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
545
546         * Scripts/webkitpy/port/driver.py:
547         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
548         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
549         * Scripts/webkitpy/port/server_process.py:
550         (ServerProcess.write): Allow caller to disable crash flag on exception.
551
552 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
553
554         webkitpy error in TestRunResults.merge()
555         https://bugs.webkit.org/show_bug.cgi?id=160882
556
557         Reviewed by Daniel Bates.
558         
559         The argument to TestRunResults.merge() can be None if there are no device-specifc
560         initial results or retry results in Manager.run(), so just return early in that case.
561
562         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
563         (TestRunResults.merge):
564
565 2016-08-15  Sam Weinig  <sam@webkit.org>
566
567         Speed up compile times by not including wtf/Variant.h so much
568         https://bugs.webkit.org/show_bug.cgi?id=160847
569
570         Reviewed by Alex Christensen and Saam Barati.
571
572         * TestWebKitAPI/Tests/WTF/Variant.cpp:
573         (TestWebKitAPI::TEST):
574         Explicitly use std::experimental::variant.
575
576 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
577
578         Allow a port to run tests with a custom device setup
579         https://bugs.webkit.org/show_bug.cgi?id=160833
580
581         Reviewed by Daniel Bates.
582
583         These changes allow the IOSSimulator port to run tests in iPad mode.
584
585         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
586         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
587         a custom device will be collected into a set, and run in that device's environment after
588         the other tests have run.
589
590         * Scripts/webkitpy/layout_tests/controllers/manager.py:
591         (Manager._custom_device_for_test): If the test contains a directory matching a
592         custom device suffix, return that custom device.
593         (Manager._set_up_run): Push the custom device class, if any, into options so
594         that the Worker can get to it.
595         (Manager.run): Go through the list of tests, and break it down into device-generic
596         tests, and tests for each device class. _run_test_subset is then called for
597         each collection of tests, and the results merged.
598         (Manager._run_test_subset): Some lines unwrapped.
599         (Manager._end_test_run):
600         (Manager._run_tests):
601         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
602         (SingleTestRunner.__init__): Unwrapped a line.
603         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
604         (TestRunResults.merge): Add this function to merge TestRunResults
605         * Scripts/webkitpy/layout_tests/views/printing.py:
606         (Printer.print_workers_and_shards): Print the custom device, if any.
607         * Scripts/webkitpy/port/base.py:
608         (Port): Base port has empty array of custom devices.
609         (Port.setup_test_run): Add device_class argument.
610         * Scripts/webkitpy/port/driver.py:
611         (DriverInput.__repr__):
612         (Driver.check_driver.implementation):
613         * Scripts/webkitpy/port/efl.py:
614         (EflPort.setup_test_run):
615         * Scripts/webkitpy/port/gtk.py:
616         (GtkPort.setup_test_run):
617         * Scripts/webkitpy/port/ios.py:
618         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
619         (IOSSimulatorPort.__init__):
620         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
621         based on the custom device class.
622         (IOSSimulatorPort._set_device_class):
623         (IOSSimulatorPort._create_simulators): Factor some code into this function.
624         (IOSSimulatorPort.setup_test_run):
625         (IOSSimulatorPort.testing_device):
626         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
627         seemed wrong for this function. That was moved to setup_test_run().
628         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
629         but this happened too early, before we knew which kind of devices to create. Devices
630         are now created in setup_test_run().
631         * Scripts/webkitpy/port/win.py:
632         (WinPort.setup_test_run):
633
634 2016-08-15  Daniel Bates  <dabates@apple.com>
635
636         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
637         private frameworks and libraries
638         https://bugs.webkit.org/show_bug.cgi?id=155931
639         <rdar://problem/25807989>
640
641         Reviewed by Dan Bernstein.
642
643         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
644         where X is the major version of the active iOS SDK.
645
646         * DumpRenderTree/mac/Configurations/Base.xcconfig:
647         * WebKitTestRunner/Configurations/Base.xcconfig:
648
649 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
650
651         Add a setting and preferences to enable visual viewport mode
652         https://bugs.webkit.org/show_bug.cgi?id=160843
653
654         Reviewed by Sam Weinig.
655         
656         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
657
658         * MiniBrowser/mac/SettingsController.h:
659         * MiniBrowser/mac/SettingsController.m:
660         (-[SettingsController _populateMenu]):
661         (-[SettingsController validateMenuItem:]):
662         (-[SettingsController visualViewportEnabled]):
663         (-[SettingsController toggleVisualViewportEnabled:]):
664         * MiniBrowser/mac/WK1BrowserWindowController.m:
665         (-[WK1BrowserWindowController didChangeSettings]):
666         * MiniBrowser/mac/WK2BrowserWindowController.m:
667         (-[WK2BrowserWindowController didChangeSettings]):
668
669 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
670
671         Allow using make-dist with non-GTK ports
672         https://bugs.webkit.org/show_bug.cgi?id=160842
673
674         Reviewed by Michael Catanzaro.
675
676         This patch adds support for setting base name of tarball and argument
677         passed to cmake's -DPORT= via command line arguments.
678
679         * gtk/make-dist.py:
680         (Distcheck.configure):
681         (Distcheck.check):
682         (get_tarball_root_and_output_filename_from_arguments):
683
684 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
685
686         [GTK] Install script lacks gstreamer related dependencies
687         https://bugs.webkit.org/show_bug.cgi?id=160814
688
689         Reviewed by Carlos Garcia Campos.
690
691         * gtk/install-dependencies: Fedora case had already listed this dependencies,
692         but both Arch and Debian/Ubuntu were missing them.
693
694 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
695
696         make-dist.py should not allow unknown rules in manifest
697         https://bugs.webkit.org/show_bug.cgi?id=160841
698
699         Reviewed by Carlos Garcia Campos.
700
701         * gtk/make-dist.py:
702         (Manifest.process_line):
703
704 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
705
706         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
707         https://bugs.webkit.org/show_bug.cgi?id=160809
708
709         Reviewed by Carlos Garcia Campos.
710
711         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
712         case, and use it also for the new package names of libpng and libgeoclue.
713         * gtk/install-dependencies: Ditto.
714
715 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
716
717         Skip to check directories existence in build-webkit
718         https://bugs.webkit.org/show_bug.cgi?id=160691
719
720         Reviewed by Alex Christensen.
721
722         CMake checks if directories are there itself. So CMake ports
723         don't need to check it in the build-webkit script.
724
725         * Scripts/build-webkit:
726         * Scripts/webkitdirs.pm:
727         (determineSourceDir):
728         (isCMakeBuild):
729
730 2016-08-12  Alex Christensen  <achristensen@webkit.org>
731
732         Make URLParser work with URLs missing URL parts
733         https://bugs.webkit.org/show_bug.cgi?id=160824
734
735         Reviewed by Brady Eidson.
736
737         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
738         (TestWebKitAPI::s):
739         (TestWebKitAPI::checkURL):
740         (TestWebKitAPI::TEST_F):
741         (TestWebKitAPI::eq): Deleted.
742
743 2016-08-12  John Wilander  <wilander@apple.com>
744
745         Add HashCountedSet API tests to TestWTFLibrary target
746         https://bugs.webkit.org/show_bug.cgi?id=160815
747
748         Reviewed by Alex Christensen.
749
750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
751             Added HashCountedSet.cpp and sorted the file reference section
752             according to UNIX sort.
753
754 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
755
756         run-benchmark should run JetStream 1.1 instead of 1.0.1
757         https://bugs.webkit.org/show_bug.cgi?id=160816
758
759         Reviewed by Filip Pizlo.
760
761         Use the latest JetStream 1.1 in run-benchmark.
762
763         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
764         (BenchmarkBuilder.__exit__):
765         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
766         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
767         change to JetStream directory.
768
769 2016-08-12  Alex Christensen  <achristensen@webkit.org>
770
771         Initial URLParser implementation
772         https://bugs.webkit.org/show_bug.cgi?id=160811
773
774         Reviewed by Brady Eidson.
775
776         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
777         (TestWebKitAPI::eq):
778         (TestWebKitAPI::checkURL):
779         (TestWebKitAPI::TEST_F):
780
781 2016-08-12  Brady Eidson  <beidson@apple.com>
782
783         Fix the 32-bit Mac build after:
784         Add WK2 ExperimentalFeature support to MiniBrowser
785         https://bugs.webkit.org/show_bug.cgi?id=160788
786
787         Unreviewed.
788
789         Sprinkle "#if WK_API_ENABLED"s liberally.
790         
791         * MiniBrowser/mac/AppDelegate.m:
792         (defaultConfiguration):
793         * MiniBrowser/mac/SettingsController.m:
794         (-[SettingsController _populateMenu]):
795         (-[SettingsController validateMenuItem:]):
796
797 2016-08-12  Philippe Normand  <pnormand@igalia.com>
798
799         [GStreamer][OWR] Video rendering fixes
800         https://bugs.webkit.org/show_bug.cgi?id=160764
801
802         Reviewed by Xabier Rodriguez-Calvar.
803
804         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
805
806 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
807
808         Add missing return statement in convertFast function added in r204376.
809
810         Unreviewed.
811
812         * Scripts/webkitpy/common/system/path.py:
813         (_CygPath.convertFast):
814
815 2016-08-11  Brady Eidson  <beidson@apple.com>
816
817         Add WK2 ExperimentalFeature support to MiniBrowser.
818         https://bugs.webkit.org/show_bug.cgi?id=160788
819
820         Reviewed by Alex Christensen.
821
822         * MiniBrowser/mac/AppDelegate.h:
823         * MiniBrowser/mac/AppDelegate.m:
824         (defaultConfiguration):
825         (defaultPreferences):
826         
827         * MiniBrowser/mac/SettingsController.m:
828         (-[SettingsController _populateMenu]):
829         (-[SettingsController validateMenuItem:]):
830         (-[SettingsController toggleExperimentalFeature:]):
831
832 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
833
834         Keep EWS logs for longer
835         https://bugs.webkit.org/show_bug.cgi?id=160776
836
837         Reviewed by Daniel Bates.
838
839         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
840
841 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
842
843         iOS DRT/WTR project cleanup
844         https://bugs.webkit.org/show_bug.cgi?id=160778
845
846         Reviewed by Tim Horton.
847
848         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
849
850         Remove AppDelegate.* which were unused.
851
852         Exclude ios/Launch.storyboard on more platforms.
853
854         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
855         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
856         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
857         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
858         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
859         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
860         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
861
862 2016-08-11  Alex Christensen  <achristensen@webkit.org>
863
864         Fix Yosemite bots' cookie accept policies after r204365.
865         https://bugs.webkit.org/show_bug.cgi?id=160758
866
867         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
868         (TEST):
869         This makes the test fully clean up after itself.
870
871 2016-08-11  Alex Christensen  <achristensen@webkit.org>
872
873         Fix Yosemite bots' cookie accept policies after r204365.
874         https://bugs.webkit.org/show_bug.cgi?id=160758
875
876         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
877         (TEST):
878         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
879         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
880         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
881         causing any problems because there are no other API tests that do anything with cookies.
882         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
883         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
884         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
885
886 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
887
888         EWS should check if the patch is still valid before executing every major step
889         https://bugs.webkit.org/show_bug.cgi?id=160739
890         rdar://problem/27768813
891
892         Reviewed by Alexey Proskuryakov.
893
894         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
895         (CommitQueueTask.run): validate method is now executed in base class.
896         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
897         (EarlyWarningSystemTask.run): validate method is now executed in base class.
898         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
899         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
900         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
901         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
902         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
903         * Scripts/webkitpy/tool/commands/perfalizer.py:
904         (PerfalizerTask.validate): Added.
905         * Scripts/webkitpy/tool/commands/queues_unittest.py:
906         (test_manual_reject_during_processing): Updated test case.
907
908 2016-08-11  Alex Christensen  <achristensen@webkit.org>
909
910         Add URLParser stub
911         https://bugs.webkit.org/show_bug.cgi?id=160770
912
913         Reviewed by Sam Weinig.
914
915         * TestWebKitAPI/PlatformGTK.cmake:
916         * TestWebKitAPI/PlatformWin.cmake:
917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
918         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
919         (TestWebKitAPI::TEST_F):
920
921 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
922
923         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
924         https://bugs.webkit.org/show_bug.cgi?id=160761
925
926         Reviewed by Tim Horton.
927
928         Give iOS DRT a Launch storyboard.
929
930         Have it use a UIViewController so future forms testing works correctly.
931
932         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
933         can run in iPad mode.
934
935         Remove empty InfoPlist.strings files.
936
937         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
938         * DumpRenderTree/ios/Info.plist:
939         * DumpRenderTree/ios/Launch.storyboard: Added.
940         * DumpRenderTree/mac/DumpRenderTree.mm:
941         (createWebViewAndOffscreenWindow):
942         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
943         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
944         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
945         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
946
947 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
948
949         [Win] Unable to reliably run tests in parallel
950         https://bugs.webkit.org/show_bug.cgi?id=140914
951
952         Reviewed by Brent Fulgham.
953
954         The cygpath utility function can fail badly when running with multiple DumpRenderTree
955         processes. We can use string replacement to convert the Cygwin path to a Windows path
956         instead.
957
958         * Scripts/webkitpy/common/system/path.py:
959         (cygpathFast):
960         * Scripts/webkitpy/port/driver.py:
961         (Driver._command_from_driver_input):
962
963 2016-08-10  Alex Christensen  <achristensen@webkit.org>
964
965         Fix crash when changing cookie accept policy after r204327
966         https://bugs.webkit.org/show_bug.cgi?id=160758
967
968         Reviewed by Simon Fraser.
969
970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
971         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
972         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
973         (TEST):
974         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
975
976 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
977
978         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
979         https://bugs.webkit.org/show_bug.cgi?id=160757
980
981         Reviewed by Tim Horton.
982
983         When programmatically creating the test UIWindow, make a root UIViewController and parent
984         the WKWebView in its view. This makes the app more like a normal UIKit application.
985         
986         Move the WKWebView down 20px to avoid the status bar.
987         
988         Give the UIWindow a gray background so it's obvious where the window and view positioned.
989
990         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
991         
992         Remove duplicate references to Launch.storyboard.
993
994         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
995         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
996         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
997         (-[AppDelegate applicationWillResignActive:]): Deleted.
998         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
999         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1000         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1001         (-[AppDelegate applicationWillTerminate:]): Deleted.
1002         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1003         (WTR::viewRectForWindowRect):
1004         (WTR::PlatformWebView::PlatformWebView):
1005         (WTR::PlatformWebView::setWindowFrame):
1006
1007 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1008
1009         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1010         https://bugs.webkit.org/show_bug.cgi?id=160748
1011
1012         Reviewed by Tim Horton.
1013         
1014         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1015         opens the door for tests using other device sizes.
1016
1017         * WebKitTestRunner/ios/TestControllerIOS.mm:
1018         (WTR::TestController::platformConfigureViewForTest):
1019
1020 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1021
1022         Sort the feature flags in the FEATURE_DEFINES lines
1023         https://bugs.webkit.org/show_bug.cgi?id=160742
1024
1025         Reviewed by Anders Carlsson.
1026         
1027         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1028
1029 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1030
1031         Logging and other minor improvements to iOS webkitpy
1032         https://bugs.webkit.org/show_bug.cgi?id=160722
1033
1034         Reviewed by Dan Bates.
1035
1036         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1037         to make it easier to debug launching issues.
1038
1039         Have reset_preferences() reset the device, rather than just nuking the data
1040         directory (which broke some versions of the simulator).
1041
1042         Make the Simulator.app launch in the background with open -g.
1043
1044         Wait for the simulator device to be in a known state in some more places.
1045
1046         * Scripts/webkitpy/port/ios.py:
1047         (IOSSimulatorPort.setup_test_run):
1048         (IOSSimulatorPort._quit_ios_simulator):
1049         (IOSSimulatorPort.clean_up_test_run):
1050         (IOSSimulatorPort.setup_environ_for_server):
1051         (IOSSimulatorPort.reset_preferences):
1052         * Scripts/webkitpy/xcode/simulator.py:
1053         (Device.create):
1054         (Device.delete):
1055         (Device):
1056         (Device.reset):
1057         (Simulator.wait_until_device_is_booted):
1058         (Simulator.wait_until_device_is_in_state):
1059         (Simulator):
1060         (Simulator.delete_device):
1061         (Simulator.reset_device):
1062         (Simulator.lookup_or_create_device):
1063
1064 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1065
1066         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1067         https://bugs.webkit.org/show_bug.cgi?id=160697
1068
1069         Reviewed by Antonio Gomes.
1070
1071         * Scripts/webkitpy/port/base.py:
1072         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1073         list of environment variables to copy.
1074
1075 2016-08-09  George Ruan  <gruan@apple.com>
1076
1077         Implement functionality of media capture on iOS
1078         https://bugs.webkit.org/show_bug.cgi?id=158945
1079         <rdar://problem/26893343>
1080
1081         Reviewed by Tim Horton.
1082
1083         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1084         Capture feature on iOS.
1085
1086 2016-08-09  Saam Barati  <sbarati@apple.com>
1087
1088         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1089         https://bugs.webkit.org/show_bug.cgi?id=160671
1090         <rdar://problem/27756112>
1091
1092         Reviewed by Mark Lam.
1093
1094         * Scripts/run-jsc-stress-tests:
1095
1096 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1097
1098         Make directory reading code in iOSSimulatorDevices() more strict
1099         https://bugs.webkit.org/show_bug.cgi?id=160702
1100
1101         Reviewed by Tim Horton.
1102
1103         * Scripts/webkitdirs.pm:
1104         (iOSSimulatorDevices):
1105
1106 2016-08-06  Sam Weinig  <sam@webkit.org>
1107
1108         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1109         https://bugs.webkit.org/show_bug.cgi?id=160638
1110
1111         Reviewed by Anders Carlsson.
1112
1113         * TestWebKitAPI/CMakeLists.txt:
1114         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1115         Add additional tests for the initial state of std::variant and using
1116         makeVisitor for visiting.
1117
1118 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1119
1120         EWS logging should ensure the logging to file is stopped on queue termination
1121         https://bugs.webkit.org/show_bug.cgi?id=160698
1122         rdar://problem/24464570
1123
1124         Reviewed by Daniel Bates.
1125
1126         * Scripts/webkitpy/tool/bot/queueengine.py:
1127         (QueueEngine._stopping): Stop logging to file on queue termination.
1128         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1129         * Scripts/webkitpy/common/system/logutils.py:
1130         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1131         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1132         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1133         * Scripts/webkitpy/tool/commands/queues.py:
1134         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1135         (AbstractQueue.queue_log_path): Same.
1136         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1137         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1138         which moved to QueueEngine now.
1139         (PatchProcessingQueue.__init__): Same.
1140         (CommitQueue.__init__): Same.
1141         (AbstractReviewQueue.__init__): Same.
1142         (StyleQueue.__init__): Same.
1143         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1144         (TestCommitQueue): Removed host parameter.
1145         (TestCommitQueue.__init__): Same.
1146         (AbstractPatchQueueTest.test_next_patch): Same.
1147         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1148         (test_commit_queue_failure): Same.
1149         (mock_run_webkit_patch):
1150         (MockCommitQueueTask.results_from_patch_test_run): Same.
1151         (test_rollout_lands): Same.
1152         (test_non_valid_patch): Same.
1153         (test_auto_retry): Same.
1154         (test_style_queue_with_watch_list_exception): Same.
1155         (TestQueue.__init__): Deleted.
1156         (TestReviewQueue.__init__): Deleted.
1157         (TestFeederQueue.__init__): Deleted.
1158
1159 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1160
1161         webkit-gtk tarball fails to build due to missing files
1162         https://bugs.webkit.org/show_bug.cgi?id=160684
1163
1164         Reviewed by Alex Christensen.
1165
1166         * gtk/manifest.txt.in: Added back spi directories.
1167
1168 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1169
1170         [GTK] Build the jhbuild with -O2 optimization level by default
1171         https://bugs.webkit.org/show_bug.cgi?id=160544
1172
1173         Reviewed by Michael Catanzaro.
1174
1175         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1176         which don't increases the required disk space significatively and
1177         provides better debug information than no passing it.
1178
1179 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1180
1181         Allow more --cmakeargs option in build-jsc and build-webkit
1182         https://bugs.webkit.org/show_bug.cgi?id=160340
1183
1184         Reviewed by Michael Catanzaro.
1185
1186         * Scripts/build-jsc:
1187         * Scripts/build-webkit:
1188
1189 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1190
1191         Do not check if WebKitLibraries folder exists on EFL and GTK
1192         https://bugs.webkit.org/show_bug.cgi?id=160659
1193
1194         Reviewed by Csaba Osztrogonác.
1195
1196         Though WebKitLibraries is only needed by mac and win ports,
1197         EFL and GTK ports have checked whether it exists.
1198
1199         * Scripts/build-webkit:
1200
1201 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1202
1203         Some EWS console logs doesn't go to log file
1204         https://bugs.webkit.org/show_bug.cgi?id=160585
1205         rdar://problem/24464570
1206
1207         Reviewed by Daniel Bates.
1208
1209         * Scripts/webkitpy/common/system/logutils.py:
1210         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1211         any possible overwriting.
1212         * Scripts/webkitpy/common/system/filesystem.py:
1213         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1214         * Scripts/webkitpy/common/system/filesystem_mock.py:
1215         (MockFileSystem.open_text_file_for_writing): Same.
1216         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1217         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1218         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1219         * Scripts/webkitpy/tool/commands/queues.py:
1220         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1221         This will ensure that all the sub-modules inside webkitpy will log to file.
1222
1223 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1224
1225         Have the iOS platform interit from the Apple platform in webkitpy
1226         https://bugs.webkit.org/show_bug.cgi?id=160672
1227
1228         Reviewed by Dan Bates.
1229         
1230         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1231         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1232         ApplePort.
1233         
1234         Since WinPort also inherits from ApplePort, it needs to stub out some things
1235         that are unavailable on Windows (leaks, sampling).
1236         
1237         Some SnowLeopard-related code and the associated test were removed.
1238
1239         * Scripts/webkitpy/port/apple.py:
1240         (ApplePort.__init__):
1241         (ApplePort):
1242         (ApplePort._make_leak_detector):
1243         (ApplePort.default_timeout_ms):
1244         (ApplePort.supports_per_test_timeout):
1245         (ApplePort.should_retry_crashes):
1246         (ApplePort._generate_all_test_configurations):
1247         (ApplePort.check_for_leaks):
1248         (ApplePort.print_leaks_summary):
1249         (ApplePort._path_to_webcore_library):
1250         (ApplePort.show_results_html_file):
1251         (ApplePort._merge_crash_logs):
1252         (ApplePort._look_for_all_crash_logs_in_log_dir):
1253         (ApplePort._get_crash_log):
1254         (ApplePort.look_for_new_crash_logs):
1255         (ApplePort.sample_process):
1256         (ApplePort.sample_file_path):
1257         (ApplePort.look_for_new_samples):
1258         (ApplePort._path_to_helper):
1259         (ApplePort.determine_full_port_name): Deleted.
1260         * Scripts/webkitpy/port/ios.py:
1261         (IOSSimulatorPort):
1262         (IOSSimulatorPort.__init__):
1263         (IOSSimulatorPort.default_timeout_ms): Deleted.
1264         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1265         (IOSSimulatorPort.should_retry_crashes): Deleted.
1266         (IOSSimulatorPort.check_for_leaks): Deleted.
1267         (IOSSimulatorPort.print_leaks_summary): Deleted.
1268         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1269         (IOSSimulatorPort.show_results_html_file): Deleted.
1270         (IOSSimulatorPort.sample_file_path): Deleted.
1271         (IOSSimulatorPort._merge_crash_logs): Deleted.
1272         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1273         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1274         (IOSSimulatorPort.look_for_new_samples): Deleted.
1275         (IOSSimulatorPort.sample_process): Deleted.
1276         (IOSSimulatorPort._path_to_helper): Deleted.
1277         (IOSSimulatorPort.make_command): Deleted.
1278         * Scripts/webkitpy/port/mac.py:
1279         (MacPort.__init__):
1280         (MacPort.make_command):
1281         (MacPort._build_java_test_support):
1282         (MacPort): Deleted.
1283         (MacPort.default_timeout_ms): Deleted.
1284         (MacPort.supports_per_test_timeout): Deleted.
1285         (MacPort.should_retry_crashes): Deleted.
1286         (MacPort.default_child_processes): Deleted.
1287         (MacPort.check_for_leaks): Deleted.
1288         (MacPort.print_leaks_summary): Deleted.
1289         (MacPort._path_to_webcore_library): Deleted.
1290         (MacPort.show_results_html_file): Deleted.
1291         (MacPort.sample_file_path): Deleted.
1292         (MacPort._merge_crash_logs): Deleted.
1293         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1294         (MacPort.look_for_new_crash_logs): Deleted.
1295         (MacPort.look_for_new_samples): Deleted.
1296         (MacPort.sample_process): Deleted.
1297         (MacPort._path_to_helper): Deleted.
1298         * Scripts/webkitpy/port/mac_unittest.py:
1299         (MacTest.test_default_child_processes): Deleted.
1300         * Scripts/webkitpy/port/win.py:
1301         (WinPort.look_for_new_samples):
1302         (WinPort):
1303         (WinPort.sample_process):
1304         (WinPort._make_leak_detector):
1305         (WinPort.check_for_leaks):
1306         (WinPort.print_leaks_summary):
1307         (WinPort._path_to_webcore_library):
1308
1309 2016-08-08  Matt Baker  <mattbaker@apple.com>
1310
1311         Unreviewed: moved myself to the reviewers list.
1312
1313         * Scripts/webkitpy/common/config/contributors.json:
1314
1315 2016-08-08  Chris Dumez  <cdumez@apple.com>
1316
1317         Update API tests in mac/SetDocumentURI.mm after r204247
1318         https://bugs.webkit.org/show_bug.cgi?id=160660
1319
1320         Reviewed by Alex Christensen.
1321
1322         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1323         (TestWebKitAPI::TEST):
1324
1325 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1326
1327         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1328         https://bugs.webkit.org/show_bug.cgi?id=159827
1329
1330         Reviewed by Daniel Bates.
1331
1332         This change was spurred by a process hang which occurred between tests and did
1333         not produce a meaningful crashlog.
1334
1335         * Scripts/webkitpy/port/driver.py:
1336         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1337
1338          * Scripts/webkitpy/port/ios.py:
1339         (IOSSimulatorPort):
1340         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1341         * Scripts/webkitpy/port/mac.py:
1342         (MacPort):
1343         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1344
1345         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1346         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1347
1348         * WebKitTestRunner/TestController.h:
1349         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1350         * WebKitTestRunner/TestInvocation.cpp:
1351         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1352
1353 2016-08-07  Dan Bernstein  <mitz@apple.com>
1354
1355         [Cocoa] Reply block leaks if the remote object doesn’t call it
1356         https://bugs.webkit.org/show_bug.cgi?id=160642
1357
1358         Reviewed by Sam Weinig.
1359
1360         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1361         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1362         (TEST): Added a test case that checks that the reply block is released even when it’s not
1363           called.
1364         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1365         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1366           calling the completion handler.
1367
1368 2016-08-07  Chris Dumez  <cdumez@apple.com>
1369
1370         Write API test to cover crash fix in r204135
1371         https://bugs.webkit.org/show_bug.cgi?id=160587
1372
1373         Reviewed by Darin Adler.
1374
1375         Add API test to cover crash fix in r204135. This reproduces the crash
1376         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1377         callback.
1378
1379         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1380         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1381         (TEST):
1382
1383 2016-08-06  Chris Dumez  <cdumez@apple.com>
1384
1385         Unreviewed, rolling out r204226.
1386
1387         Broke some API tests
1388
1389         Reverted changeset:
1390
1391         "Write API test to cover crash fix in r204135"
1392         https://bugs.webkit.org/show_bug.cgi?id=160587
1393         http://trac.webkit.org/changeset/204226
1394
1395 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1396
1397         EWS Style Queue fails to process patches which fails validation
1398         https://bugs.webkit.org/show_bug.cgi?id=160632
1399
1400         Reviewed by Alexey Proskuryakov.
1401
1402         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1403         (StyleQueueTask.validate): Add more information about validation failure.
1404         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1405         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1406         (test_non_valid_patch): Add a unit test to test the above code path.
1407
1408 2016-08-06  Sam Weinig  <sam@webkit.org>
1409
1410         WTF needs a variant implementation
1411         https://bugs.webkit.org/show_bug.cgi?id=160618
1412
1413         Reviewed by Darin Adler.
1414
1415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1416         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1417         Add tests for the variant implementation.
1418
1419 2016-08-06  Chris Dumez  <cdumez@apple.com>
1420
1421         Write API test to cover crash fix in r204135
1422         https://bugs.webkit.org/show_bug.cgi?id=160587
1423
1424         Reviewed by Darin Adler.
1425
1426         Add API test to cover crash fix in r204135. This reproduces the crash
1427         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1428         callback.
1429
1430         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1431         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1432         (TEST):
1433
1434 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1435
1436         run-api-tests should use a headed simulator
1437         https://bugs.webkit.org/show_bug.cgi?id=160611
1438
1439         Reviewed by Sam Weinig.
1440
1441         CADisplayLink doesn't work in a headless simulator, but is
1442         vital for the proper functioning of WebKit2 painting on iOS.
1443         So, we should not use a headless simulator.
1444
1445         * Scripts/run-api-tests:
1446         Launch a simulator app, don't just boot the simulator.
1447
1448         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1449         Re-enable a test that works now.
1450
1451 2016-08-05  Dan Bernstein  <mitz@apple.com>
1452
1453         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1454         https://bugs.webkit.org/show_bug.cgi?id=160589
1455
1456         Reviewed by Tim Horton.
1457
1458         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1459         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1460           blocks, which wasn’t caught because the test wasn’t run correctly.
1461         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1462         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1463           added a test that sends over an NSRange.
1464         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1465         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1466           handler with the range‘s location and length.
1467
1468 2016-08-05  Enrica Casucci  <enrica@apple.com>
1469
1470         Fixing tests failing after r204175.
1471
1472         Unreviewed.
1473
1474         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1475
1476 2016-08-05  Enrica Casucci  <enrica@apple.com>
1477
1478         Build fix after 204053.
1479
1480         Unreviewed.
1481
1482         * TestWebKitAPI/Configurations/Base.xcconfig:
1483         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1484         (-[MockContentFilterEnabler initWithCoder:]):
1485         (-[MockContentFilterEnabler dealloc]):
1486
1487 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1488
1489         Print test name in "Last character read from DRT..." error message.
1490         https://bugs.webkit.org/show_bug.cgi?id=160559
1491
1492         Reviewed by Michael Catanzaro.
1493
1494         * Scripts/webkitpy/port/driver.py:
1495         (Driver.run_test):
1496         (Driver._read_first_block):
1497         (Driver._read_optional_image_block):
1498         (Driver._read_block):
1499         * Scripts/webkitpy/port/driver_unittest.py:
1500         (DriverTest.test_read_block):
1501         (DriverTest.test_read_binary_block):
1502         (DriverTest.test_read_base64_block):
1503
1504 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1505
1506         Unreviewed, rolling out r204123.
1507         https://bugs.webkit.org/show_bug.cgi?id=160597
1508
1509         Caused layout test timeouts on Windows. (Requested by perarne
1510         on #webkit).
1511
1512         Reverted changeset:
1513
1514         "[Win] Unable to reliably run tests in parallel"
1515         https://bugs.webkit.org/show_bug.cgi?id=140914
1516         http://trac.webkit.org/changeset/204123
1517
1518 2016-08-04  Saam Barati  <sbarati@apple.com>
1519
1520         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1521         https://bugs.webkit.org/show_bug.cgi?id=151241
1522
1523         Reviewed by Benjamin Poulain.
1524
1525         * Scripts/run-jsc-stress-tests:
1526
1527 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1528
1529         UI improvements to Flakiness Dashboard.
1530         https://bugs.webkit.org/show_bug.cgi?id=153295
1531
1532         Reviewed by Alexey Proskuryakov.
1533
1534         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1535         (td.options-container): Center text in most fields.
1536         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1537         (createBugHTML): Text/Grammar updates.
1538         (tableHeaders): Ditto.
1539         (htmlForSingleTestRow): Ditto.
1540         (headerForTestTableHtml): Ditto.
1541         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1542         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1543
1544 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1545
1546         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1547         https://bugs.webkit.org/show_bug.cgi?id=160518
1548
1549         Reviewed by Michael Catanzaro.
1550
1551         * Scripts/webkitpy/thirdparty/__init__.py:
1552         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1553         * gtk/install-dependencies:
1554
1555 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1556
1557         Optimize bot watcher's dashboard a little
1558         https://bugs.webkit.org/show_bug.cgi?id=160515
1559         rdar://problem/26096900
1560
1561         Reviewed by Lucas Forschler.
1562
1563         Made re-sorting after loading an iteration more efficient.
1564
1565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1566         (BuildbotIteration.prototype._updateWithData):
1567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1568         (BuildbotQueue.prototype.updateIterationPosition):
1569
1570 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1571
1572         [Win] Unable to reliably run tests in parallel
1573         https://bugs.webkit.org/show_bug.cgi?id=140914
1574
1575         Reviewed by Brent Fulgham.
1576
1577         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1578         processes. We can use string replacement to convert the Cygwin path to a Windows path
1579         instead.
1580  
1581         * Scripts/webkitpy/common/system/path.py:
1582         (cygpathFast):
1583         * Scripts/webkitpy/port/driver.py:
1584         (Driver._command_from_driver_input):
1585
1586 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1587
1588         Document instructions for increasing process and file limits
1589         https://bugs.webkit.org/show_bug.cgi?id=160528
1590         rdar://problem/24777576
1591
1592         Reviewed by Alexey Proskuryakov.
1593
1594         * Scripts/webkitpy/port/ios.py:
1595         (IOSSimulatorPort.default_child_processes):
1596
1597 2016-08-03  Anders Carlsson  <andersca@apple.com>
1598
1599         Remove the Objective-C bindings generator
1600         https://bugs.webkit.org/show_bug.cgi?id=160526
1601
1602         Reviewed by Sam Weinig.
1603
1604         * Scripts/run-bindings-tests:
1605         Update test.
1606
1607 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1608
1609         Revise a TestWebKitAPI comment to mention the actual underlying problem
1610
1611         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1612         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1613
1614 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1615
1616         Benchmark test content-animation timeouts always
1617         https://bugs.webkit.org/show_bug.cgi?id=160057
1618
1619         Reviewed by Simon Fraser.
1620
1621         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1622         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1623         (start):
1624
1625 2016-08-02  Nan Wang  <n_wang@apple.com>
1626
1627         AX: Simulated touch events are not working on iOS
1628         https://bugs.webkit.org/show_bug.cgi?id=160395
1629         <rdar://problem/27633597>
1630
1631         Reviewed by Chris Fleizach.
1632
1633         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1634         (WTR::AccessibilityUIElement::press):
1635         (WTR::AccessibilityUIElement::setSelectedChild):
1636
1637 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1638
1639         run-javascriptcore-tests should accept multiple --extra-tests
1640         https://bugs.webkit.org/show_bug.cgi?id=160486
1641
1642         Reviewed by Saam Barati.
1643         
1644         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1645         test suites. This does it by using GetOpt::Long's array support.
1646
1647         * Scripts/run-javascriptcore-tests:
1648         (runJSCStressTests):
1649
1650 2016-08-02  Enrica Casucci  <enrica@apple.com>
1651
1652         Allow building with content filtering disabled.
1653         https://bugs.webkit.org/show_bug.cgi?id=160454
1654
1655         Reviewed by Simon Fraser.
1656
1657         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1658
1659 2016-08-02  Brady Eidson  <beidson@apple.com>
1660
1661         Removing IndexedDB WebsiteData can fail for some users.
1662         https://bugs.webkit.org/show_bug.cgi?id=160463
1663
1664         Reviewed by Alex Christensen.
1665
1666         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1667
1668 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1669
1670         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1671         https://bugs.webkit.org/show_bug.cgi?id=160437
1672         <rdar://problem/27578272>
1673
1674         Reviewed by Brady Eidson.
1675
1676         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1677         (-[DownloadDelegate _download:didReceiveResponse:]):
1678         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1679         (runTest):
1680         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1681
1682 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1683
1684         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1685         https://bugs.webkit.org/show_bug.cgi?id=160414
1686
1687         Reviewed by Michael Catanzaro.
1688
1689         * Scripts/webkitpy/port/linux_get_crash_log.py:
1690         (GDBCrashLogGenerator._wait_for_corefile):
1691
1692 2016-08-01  Youenn Fablet  <youenn@apple.com>
1693
1694         Make wpt server generate its certificates in layout test results folder
1695         https://bugs.webkit.org/show_bug.cgi?id=160422
1696
1697         Reviewed by Chris Dumez.
1698
1699         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1700         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1701
1702 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1703
1704         Function Call on NULL Object
1705         https://bugs.webkit.org/show_bug.cgi?id=160325
1706
1707         Reviewed by Darin Adler.
1708
1709         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1710         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1711         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1712
1713 2016-08-01  Keith Miller  <keith_miller@apple.com>
1714
1715         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1716         https://bugs.webkit.org/show_bug.cgi?id=160372
1717
1718         Rubber stamped by Geoffrey Garen.
1719
1720         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1721         a new top level directory, JSTests. Having the tests in the Source directory
1722         was both confusing an inconvenient for people that just want to checkout the
1723         source code of WebKit. Since there is no other obvious place to put all the
1724         JavaScript tests a new top level directory seemed the most sensible.
1725
1726         * Scripts/import-test262-tests:
1727         * Scripts/run-javascriptcore-tests:
1728         * Scripts/update-javascriptcore-test-res:
1729
1730 2016-07-31  Nan Wang  <n_wang@apple.com>
1731
1732         AX: Add a check for touch event listener on iOS accessibility object
1733         https://bugs.webkit.org/show_bug.cgi?id=160388
1734
1735         Reviewed by Chris Fleizach.
1736
1737         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1738         (AccessibilityUIElement::boolAttributeValue):
1739         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1740         (WTR::AccessibilityUIElement::boolAttributeValue):
1741
1742 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1743
1744         Unreviewed: add myself to the reviewers list.
1745
1746         * Scripts/webkitpy/common/config/contributors.json:
1747
1748 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1749
1750         Undo r203939, and copy over a rule that clips the logos.
1751
1752         Sierra wasn't the only logo without transparency.
1753
1754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1757
1758 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1759
1760         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1761         https://bugs.webkit.org/show_bug.cgi?id=160377
1762
1763         Reviewed by Brian Weinstein.
1764
1765         Update assets to remove the white background and use a transparent background instead.
1766
1767         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1769
1770 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1771
1772         Ignore most check-webkit-style checks for ANGLE project
1773         <https://webkit.org/b/160333>
1774
1775         Reviewed by Daniel Bates.
1776
1777         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1778         - No tabs.
1779         - No spaces at the end of lines.
1780         - No carriage returns (DOS line endings).
1781
1782 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1783
1784         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1785         https://bugs.webkit.org/show_bug.cgi?id=160360
1786         <rdar://problem/27179484>
1787
1788         Reviewed by Myles C. Maxfield.
1789
1790         Adds two tests verifying that videos may be considered main content as long as they
1791         are large enough and cover a majority of the mainframe's viewport.
1792
1793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1794         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1795         (TestWebKitAPI::TEST):
1796         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1797         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1798
1799 2016-07-29  Mark Lam  <mark.lam@apple.com>
1800
1801         Gardening: removed unused variable.
1802
1803         Not reviewed.
1804
1805         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1806         (TestWebKitAPI::TEST):
1807
1808 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1809
1810         Add TestWebKitAPI support for interacting with media controls
1811         https://bugs.webkit.org/show_bug.cgi?id=160342
1812         <rdar://problem/27610246>
1813
1814         Reviewed by Beth Dakin.
1815
1816         Adds support for testing interaction with some media controls, as well as a basic test
1817         verifying that media control teardown after interaction does not result in a crash.
1818
1819         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1820         (-[WKWebView mouseDownAtPoint:]):
1821         (-[WKWebView performAfterLoading:]):
1822         (TestWebKitAPI::TEST):
1823
1824 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1825
1826         Crash Log Clobbering on Unbound Crashes
1827         https://bugs.webkit.org/show_bug.cgi?id=160198
1828         <rdar://problem/27472618>
1829
1830         Reviewed by Alexey Proskuryakov.
1831
1832         * Scripts/webkitpy/common/system/crashlogs.py:
1833         (CrashLogs): Fix header order.
1834         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1835         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1836
1837 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1838
1839         Update for contributors.json
1840         https://bugs.webkit.org/show_bug.cgi?id=160294
1841
1842         * Scripts/webkitpy/common/config/contributors.json:
1843
1844 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1845
1846         Remove deprecated SPI for video inline / fullscreen controls
1847         https://bugs.webkit.org/show_bug.cgi?id=160318
1848
1849         Reviewed by Tim Horton.
1850
1851         * DumpRenderTree/mac/DumpRenderTree.mm:
1852         (setDefaultsToConsistentValuesForTesting): Deleted.
1853         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1854         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1855         * WebKitTestRunner/TestController.cpp:
1856         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1857         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1858         (WTR::initializeWebViewConfiguration): Deleted.
1859
1860 2016-07-28  Daniel Bates  <dabates@apple.com>
1861
1862         [iOS] TestWebKitAPI bundle targets are not code signed
1863         https://bugs.webkit.org/show_bug.cgi?id=160328
1864         <rdar://problem/27409246>
1865
1866         Reviewed by Andy Estes.
1867
1868         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1869         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1870         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1871
1872         * TestWebKitAPI/Configurations/Base.xcconfig:
1873
1874 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1875
1876         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1877
1878         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1879         (animatedResizeWebView):
1880         (TEST):
1881         This test times out only when run in the WebKit Testing simulator environment,
1882         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1883
1884 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1885
1886         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1887         https://bugs.webkit.org/show_bug.cgi?id=160289
1888         <rdar://problem/27553464>
1889
1890         Reviewed by Simon Fraser.
1891
1892         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1894         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1895         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1896         (-[AnimatedResizeWebView _endAnimatedResize]):
1897         (animatedResizeWebView):
1898         (TEST):
1899         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1900         Add two tests that ensure that hidden-content and animated resizes
1901         don't cause unnecessary synchronous waits. Only the hidden-content
1902         one fails before my patch, but it seemed reasonable to add both anyway.
1903
1904 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1905
1906         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1907         <https://webkit.org/b/83342>
1908
1909         Reviewed by Ryosuke Niwa.
1910
1911         * Scripts/webkitpy/common/checkout/scm/git.py:
1912         (Git.revisions_changing_file): Remove code to raise an exception
1913         when the file doesn't exist.  If a file was moved or renamed,
1914         then this caused the script to terminate, which was very
1915         frustrating when you wanted a list of reviewers.
1916         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1917         (SCMTest._shared_test_revisions_changing_file): Update test
1918         expectation to return an empty list of revisions.
1919         (test_create_patch_is_full_patch): Drive-by fix when running all
1920         webkitpy tests (including scm tests).
1921         * Scripts/webkitpy/common/checkout/scm/svn.py:
1922         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1923         return an empty array of revisions if this occurs.
1924
1925 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1926
1927         EWS error message "Error: * did not process patch" should include explanation
1928         https://bugs.webkit.org/show_bug.cgi?id=159903
1929         <rdar://problem/27410788>
1930
1931         Reviewed by Alexey Proskuryakov.
1932
1933         * QueueStatusServer/handlers/statusbubble.py:
1934         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1935         is not processed.
1936         * QueueStatusServer/handlers/processingtimesjson.py:
1937         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1938         of the code.
1939         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1940         (CommitQueueTask.validate): Add more information about validation failure.
1941         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1942         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1943         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1944         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1945         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1946         (PatchIsNotValid.__init__): Add the failure_message argument.
1947         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1948         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1949         failure details.
1950         * Scripts/webkitpy/tool/commands/queues.py:
1951         (CommitQueue.process_work_item): Same.
1952         (StyleQueue.review_patch): Same.
1953         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1954         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1955
1956 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1957
1958         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1959         https://bugs.webkit.org/show_bug.cgi?id=160262
1960
1961         Reviewed by Daniel Bates.
1962
1963         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1964         (-[LTRelayController installApp]):
1965
1966 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1967
1968         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1969         https://bugs.webkit.org/show_bug.cgi?id=160225
1970
1971         Reviewed by Alexey Proskuryakov.
1972
1973         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1974
1975 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1976
1977         [GTK] Fix some video/canvas tests that should be passing
1978         https://bugs.webkit.org/show_bug.cgi?id=160023
1979
1980         Reviewed by Carlos Garcia Campos.
1981
1982         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1983         EFL or GTK platforms.
1984
1985         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1986         (WTR::TestController::platformConfigureViewForTest):
1987         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1988         (WTR::TestController::platformConfigureViewForTest):
1989
1990 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1991
1992         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1993         https://bugs.webkit.org/show_bug.cgi?id=160247
1994
1995         Reviewed by Michael Catanzaro.
1996
1997         * BuildSlaveSupport/built-product-archive:
1998         (createZip):
1999         (dirContainsdwo):
2000         (archiveBuiltProduct):
2001
2002 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2003
2004         Fix tests after r203743.
2005         https://bugs.webkit.org/show_bug.cgi?id=156947
2006
2007         * WebKitTestRunner/TestController.cpp:
2008         (WTR::TestController::resetStateToConsistentValues):
2009         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2010
2011 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2012
2013         [iPhone] Playing a video on tudou.com plays only sound, no video
2014         https://bugs.webkit.org/show_bug.cgi?id=160178
2015         <rdar://problem/27535468>
2016
2017         Reviewed by Dan Bernstein.
2018
2019         * DumpRenderTree/mac/DumpRenderTree.mm:
2020         (setDefaultsToConsistentValuesForTesting):
2021         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2022         (RequiresUserActionForPlaybackTest::SetUp):
2023         * WebKitTestRunner/TestController.cpp:
2024         (WTR::TestController::resetPreferencesToConsistentValues):
2025         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2026         (WTR::initializeWebViewConfiguration):
2027
2028 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2029
2030         Allow LOG macros to be used outside the namespace, and other logging cleanup
2031         https://bugs.webkit.org/show_bug.cgi?id=160216
2032
2033         Reviewed by Anders Carlsson.
2034         
2035         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2036
2037         * DumpRenderTree/TestRunner.cpp:
2038         * DumpRenderTree/mac/DumpRenderTree.mm:
2039         (resetWebViewToConsistentStateBeforeTesting):
2040
2041 2016-07-26  David Kilzer <ddkilzer@apple.com>
2042
2043         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2044         https://bugs.webkit.org/show_bug.cgi?id=156947
2045         <rdar://problem/23325160>
2046
2047         Reviewed by Alex Christensen.
2048
2049         * DumpRenderTree/TestRunner.cpp:
2050         (TestRunner::TestRunner):
2051         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2052         * DumpRenderTree/TestRunner.h:
2053         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2054         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2055         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2056         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2057         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2058         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2059         (WTR::TestRunner::queueNonLoadingScript):
2060         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2061         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2062         * WebKitTestRunner/TestController.cpp:
2063         (WTR::TestController::didReceiveAuthenticationChallenge):
2064         * WebKitTestRunner/TestController.h:
2065         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2066         * WebKitTestRunner/TestInvocation.cpp:
2067         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2068         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2069
2070 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2071
2072         check-for-exit-time-destructors should be usable outside Xcode
2073         <https://webkit.org/b/160195>
2074
2075         Reviewed by Darin Adler.
2076
2077         * Scripts/check-for-exit-time-destructors: Update to parse
2078         -h|--help switch, or to take one argument to a binary to check
2079         for exit time destructors on the command-line.  The clang
2080         compiler will find these at compile-time with the
2081         -Wexit-time-destructors switch, but this script will check for
2082         them after-the-fact.
2083
2084 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2085
2086         Test svn.webkit.org functionality after maintenance.
2087
2088 2016-07-25  Brady Eidson  <beidson@apple.com>
2089
2090         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2091         https://bugs.webkit.org/show_bug.cgi?id=153783
2092
2093         Reviewed by Alex Christensen.
2094
2095         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2096         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2097         
2098         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2099         
2100         Change the relevant API tests to make sure this continues to be no longer required.
2101
2102         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2103         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2104         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2105         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2106         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2107         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2108
2109 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2110
2111         Media controls should not be displayed for a video until it starts playing
2112         https://bugs.webkit.org/show_bug.cgi?id=160092
2113         <rdar://problem/26986673>
2114
2115         Reviewed by Beth Dakin.
2116
2117         Verify that multiple videos do or don't show the media controller depending on whether videos
2118         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2119         passing because we were always showing media controls for large videos with audio, even if they
2120         had not played back yet. This change ensures that large videos with audio show media controls
2121         only after they begin to play back, and not by virtue of being large enough for main content.
2122
2123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2124         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2125         (TestWebKitAPI::TEST):
2126         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2127         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2128         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2129
2130 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2131
2132         Media controls on apple.com don't disappear when movie finishes playing
2133         https://bugs.webkit.org/show_bug.cgi?id=160068
2134         <rdar://problem/26668526>
2135
2136         Reviewed by Darin Adler.
2137
2138         Adds new API tests. Please see WebCore ChangeLog for more details.
2139
2140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2141         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2142         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2143         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2144         (TestWebKitAPI::TEST):
2145         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2146         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2147         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2148         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2149         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2150
2151 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2152
2153         Unreviewed, fix test-webkitpy after r203674.
2154
2155         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2156         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2157
2158 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2159
2160         Unreviewed, forgot to commit this file in r203674.
2161
2162         * Scripts/process-linux-coredump: Added.
2163         (main):
2164
2165 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2166
2167         Improve GDB backtrace generation for GTK/EFL
2168         https://bugs.webkit.org/show_bug.cgi?id=128928
2169
2170         Reviewed by Carlos Garcia Campos.
2171
2172         The PID of the crashed process is now correctly supplied to the
2173         crash log reporter. The kernel core_pattern needs to be updated
2174         after this change to something like:
2175
2176         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2177
2178         * Scripts/process-linux-coredump: Added.
2179         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2180         * Scripts/webkitpy/port/efl.py:
2181         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2182         * Scripts/webkitpy/port/gtk.py:
2183         (GtkPort._get_crash_log): Ditto.
2184         * Scripts/webkitpy/port/linux_get_crash_log.py:
2185         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2186         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2187         (GDBCrashLogGenerator): Deleted.
2188         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2189         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2190         * WebKitTestRunner/TestController.cpp:
2191         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2192         (WTR::TestController::databaseProcessDidCrash): Ditto.
2193         (WTR::TestController::processDidCrash): Ditto.
2194
2195 2016-07-23  Youenn Fablet  <youenn@apple.com>
2196
2197         WPT stash server should be kept running when launching wpt server
2198         https://bugs.webkit.org/show_bug.cgi?id=160052
2199
2200         Reviewed by Sam Weinig.
2201
2202         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2203         (main): waiting to read stdin while stash server is started.
2204
2205 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2206
2207         Media controls should be displayed for media in media documents
2208         https://bugs.webkit.org/show_bug.cgi?id=160104
2209         <rdar://problem/27438936>
2210
2211         Reviewed by Myles C. Maxfield.
2212
2213         Verifies that even a small video with audio in a media document gets media controls.
2214
2215         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2216         (TestWebKitAPI::TEST):
2217
2218 2016-07-22  Michael Saboff  <msaboff@apple.com>
2219
2220         REGRESSION(203616): no FTL testing was inadvertently removed
2221         https://bugs.webkit.org/show_bug.cgi?id=160100
2222
2223         Rubber-stamped by Filip Pizlo.
2224
2225         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2226         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2227         logic for the runLayout and runNoisy variants to match the run test logic,
2228         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2229         enabled platforms.
2230
2231         * Scripts/run-jsc-stress-tests:
2232
2233 2016-07-22  Brady Eidson  <beidson@apple.com>
2234
2235         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2236         https://bugs.webkit.org/show_bug.cgi?id=160089
2237
2238         Reviewed by Darin Adler.
2239
2240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2241         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2242         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2243
2244 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2245
2246         [GTK] Improved exclusion patterns in make-dist.py manifest.
2247         https://bugs.webkit.org/show_bug.cgi?id=160094
2248
2249         Reviewed by Michael Catanzaro.
2250
2251         * gtk/manifest.txt.in:
2252         Exclude Platform*.cmake files for more ports.
2253         Removed obsolete .gyp and .pro.user patterns.
2254         Exclude 'Configurations' and 'spi' directories.
2255         Exclude CMakeLists.txt.user (Qt Creator IDE).
2256
2257 2016-07-22  Michael Saboff  <msaboff@apple.com>
2258
2259         Don't run FTL related JSC stress tests on non-FTL platforms
2260         https://bugs.webkit.org/show_bug.cgi?id=160033
2261
2262         Reviewed by Mark Lam.
2263
2264         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2265         Refactored several of the runXXX test methods to always runXXXDefault and made those
2266         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2267         doesn't cause a problem.
2268
2269         * Scripts/run-jsc-stress-tests:
2270
2271 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2272
2273         IWebView::mainFrame crashes if called after IWebView::close
2274         https://bugs.webkit.org/show_bug.cgi?id=32868
2275
2276         Reviewed by Brent Fulgham.
2277
2278         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2279         (TestWebKitAPI::TEST_F): Added test.
2280
2281 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2282
2283         [GTK] Enable threaded compositor by default
2284         https://bugs.webkit.org/show_bug.cgi?id=160079
2285
2286         Reviewed by Žan Doberšek.
2287
2288         * Scripts/webkitperl/FeatureList.pm:
2289
2290 2016-07-22  Youenn Fablet  <youenn@apple.com>
2291
2292         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2293         https://bugs.webkit.org/show_bug.cgi?id=159921
2294
2295         Reviewed by Brian Burg.
2296
2297         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2298
2299         * Scripts/webkitpy/codegen/main.py:
2300         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2301         (BuiltinsGeneratorTests):
2302         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2303         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2304         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2305         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2306
2307 2016-07-21  Dan Bernstein  <mitz@apple.com>
2308
2309         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2310         https://bugs.webkit.org/show_bug.cgi?id=160072
2311
2312         Reviewed by Andy Estes.
2313
2314         * Scripts/webkitdirs.pm:
2315         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2316           for old Xcode versions.
2317         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2318           to readXcodeUserDefault.
2319         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2320           debugger.
2321         (determineDebugger): Ditto.
2322         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2323           7.0.
2324         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2325           switches.
2326         (execMacWebKitAppForDebugging): Removed support for GDB.
2327
2328 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2329
2330         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2331         https://bugs.webkit.org/show_bug.cgi?id=160066
2332
2333         Reviewed by Dean Jackson.
2334
2335         * DumpRenderTree/mac/DumpRenderTree.mm:
2336         (setDefaultsToConsistentValuesForTesting): Deleted.
2337         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2338         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2339         * WebKitTestRunner/TestController.cpp:
2340         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2341         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2342         (WTR::initializeWebViewConfiguration): Deleted.
2343
2344 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2345
2346         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2347         https://bugs.webkit.org/show_bug.cgi?id=159980
2348         rdar://problem/27450825
2349
2350         Reviewed by Dan Bernstein.
2351
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2354         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2355         when our delegate has hit -dealloc.
2356         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2357         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2358         will not be messaged.
2359
2360 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2361
2362         Follow-up patch to r203520
2363         https://bugs.webkit.org/show_bug.cgi?id=159967
2364         <rdar://problem/26964090>
2365
2366         Unreviewed.
2367
2368         * DumpRenderTree/mac/DumpRenderTree.mm:
2369         (setDefaultsToConsistentValuesForTesting):
2370         * WebKitTestRunner/TestController.cpp:
2371         (WTR::TestController::resetPreferencesToConsistentValues):
2372
2373 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2374
2375         [iPhone] Playing a video on tudou.com plays only sound, no video
2376         https://bugs.webkit.org/show_bug.cgi?id=159967
2377         <rdar://problem/26964090>
2378
2379         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2380
2381         Migrate tests to use new SPI.
2382
2383         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2384         (RequiresUserActionForPlaybackTest::SetUp):
2385         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2386         (WTR::initializeWebViewConfiguration):
2387
2388 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2389
2390         Clarify testing mode names in run-jsc-stress-tests
2391         https://bugs.webkit.org/show_bug.cgi?id=160021
2392
2393         Reviewed by Mark Lam.
2394
2395         Default should mean really default, not default with disabled FTL, renamed
2396         - runMozillaTestDefault to runMozillaTestNoFTL
2397         - runMozillaTestDefaultFTL to runMozillaTestDefault
2398         - runDefault to runNoFTL
2399         - runDefaultFTL to runDefault
2400         - runLayoutTestDefault to runLayoutTestNoFTL
2401         - runLayoutTestDefaultFTL to runLayoutTestDefault
2402         - runNoisyTestDefault to runNoisyTestNoFTL
2403         - runNoisyTestDefaultFTL to runNoisyTestDefault
2404
2405         * Scripts/run-jsc-stress-tests:
2406
2407 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2408
2409         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2410         https://bugs.webkit.org/show_bug.cgi?id=159986
2411
2412         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2413         to 0.
2414
2415         Reviewed by Dan Bernstein.
2416
2417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2418         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2419         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2420         (TEST):
2421
2422 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2423
2424         [GTK] Web view background colors don't work in accelerated compositing mode
2425         https://bugs.webkit.org/show_bug.cgi?id=159455
2426
2427         Reviewed by Michael Catanzaro.
2428
2429         Set always RGBA visual to the view widget when setting a background color.
2430
2431         * MiniBrowser/gtk/BrowserWindow.c:
2432         (browser_window_set_background_color):
2433
2434 2016-07-20  Youenn Fablet  <youenn@apple.com>
2435
2436         Bots should run built-ins generator tests
2437         https://bugs.webkit.org/show_bug.cgi?id=159971
2438
2439         Reviewed by Alexey Proskuryakov.
2440
2441         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2442         (RunBuiltinsTests): New step to run built-in generator tests.
2443         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2444         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2446
2447 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2448
2449         Revert temporary fix r203417
2450         https://bugs.webkit.org/show_bug.cgi?id=160001
2451
2452         Reviewed by Alexey Proskuryakov.
2453
2454         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2455
2456 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2457
2458         REGRESSION(r148588): ews classes might get garbage collected
2459         https://bugs.webkit.org/show_bug.cgi?id=159990
2460
2461         Reviewed by Ryosuke Niwa.
2462
2463         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2464         in a variable so that they do not get garbage collected.
2465
2466 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2467
2468         Add API test for layout constraints after exit fullscreen
2469         https://bugs.webkit.org/show_bug.cgi?id=159900
2470
2471         Reviewed by Jon Lee.
2472
2473         Added Fullscreen.LaytoutConstraints API test. 
2474         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2475
2476         This test compares layout constraints on the web view before and after fullscreen to make sure 
2477         they are preserved.
2478
2479         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2480         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2481         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2482         (TestWebKitAPI::TEST):
2483
2484 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2485
2486         Disable two failing API tests.
2487
2488         Unreviewed test gardening.
2489
2490         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2491         (TestWebKitAPI::TEST):
2492
2493 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2494
2495         Unreviewed iOS build fix.
2496
2497         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2498
2499 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2500
2501         Media controls don't appear when pausing a small autoplaying video
2502         https://bugs.webkit.org/show_bug.cgi?id=159972
2503         <rdar://problem/27180657>
2504
2505         Reviewed by Beth Dakin.
2506
2507         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2508         for simulating basic user interaction in VideoControlsManager.
2509
2510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2511         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2512         (-[WKWebView mouseDownAtPoint:]):
2513         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2514         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2515         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2516         (TestWebKitAPI::TEST):
2517         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2518
2519 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2520
2521         [Win] MathML fonts are not found.
2522         https://bugs.webkit.org/show_bug.cgi?id=159920
2523
2524         Reviewed by Alex Christensen.
2525
2526         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2527         for a specific registry key value.
2528
2529         * Scripts/webkitdirs.pm:
2530         (fontExists):
2531
2532 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2533
2534         Improve prepare-ChangeLog for @media blocks
2535         https://bugs.webkit.org/show_bug.cgi?id=159907
2536
2537         Reviewed by Timothy Hatcher.
2538
2539         * Scripts/prepare-ChangeLog:
2540         (get_selector_line_ranges_for_css):
2541         Get a range for @media blocks just like a selector.
2542             Start Line = line with '{'
2543             End line = line with '}'
2544             Name = "@media ..."
2545
2546         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2547         Improved error messages for unbalanced portions.
2548
2549         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2550         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2551         (.media-query::before):
2552         (@media only screen and (max-width: 980px)):
2553         (.media-query a):
2554         (@media (-webkit-min-device-pixel-ratio: 2)):
2555         (.both a):
2556         (.both b):
2557         (.media-query b):
2558         (.media-query::after):
2559
2560 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2561
2562         Fix expectedFailErrorHandler in run-jsc-stress-tests
2563         https://bugs.webkit.org/show_bug.cgi?id=159811
2564
2565         Reviewed by Yusuke Suzuki.
2566
2567         * Scripts/run-jsc-stress-tests:
2568
2569 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2570
2571         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2572
2573         * TestWebKitAPI/PlatformMac.cmake:
2574
2575 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2576
2577         The default testing mode should not involve disabling the FTL JIT
2578         https://bugs.webkit.org/show_bug.cgi?id=159929
2579
2580         Rubber stamped by Mark Lam and Saam Barati.
2581         
2582         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2583         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2584         FTL was not the default. You had to enable it with an option.
2585         
2586         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2587         all of the major ports. This has become a serious pain. For example, it's useful to be able
2588         to say that a test should only run in the default config that is representative of what a
2589         normal user would see if they ran JSC. Clearly, this would be a config that does not
2590         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2591         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2592         
2593         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2594         try to fix it, because:
2595         
2596         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2597           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2598           doesn't do anything. The code is not really structured to allow this.
2599         
2600         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2601           disabled in testing. On the other hand there are already build bots that do FTL tests
2602           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2603           preserving this broken feature, we should create something that (a) acknowledges the fact
2604           that the FTL is the default on those platforms that support it and (b) avoids running
2605           no-ftl tests on precisely those platforms that don't have FTL.
2606         
2607         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2608           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2609           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2610           pretending that the FTL JIT is not the default just because some bots used that as an
2611           optimization.
2612         
2613         This change allows me to speed up some debug tests and paint some bots green.
2614
2615         * Scripts/run-javascriptcore-tests:
2616         (runJSCStressTests):
2617         * Scripts/run-jsc-stress-tests:
2618
2619 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2620
2621         Fix API test after r203426.
2622         https://bugs.webkit.org/show_bug.cgi?id=159949
2623
2624         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2625         (TEST):
2626         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2627         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2628
2629 2016-07-19  Andy Estes  <aestes@apple.com>
2630
2631         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2632         https://bugs.webkit.org/show_bug.cgi?id=159956
2633
2634         Reviewed by Dan Bernstein.
2635
2636         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2637         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2638         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2639         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2640
2641 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2642
2643         Add regression test for r203392
2644         https://bugs.webkit.org/show_bug.cgi?id=159949
2645
2646         Reviewed by Brady Eidson.
2647
2648         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2649         (fileSize):
2650         (swizzledBundleIdentifierWebBookmarksD):
2651         (defaultApplicationCacheDirectory):
2652         (TEST):
2653         (swizzledBundleIdentifierMobileSafari): Deleted.
2654         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2655         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2656         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2657
2658 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2659
2660         Add regression test for r203392
2661         https://bugs.webkit.org/show_bug.cgi?id=159949
2662
2663         Reviewed by Brady Eidson.
2664
2665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2666         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2667         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2668         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2669         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2670         (TEST):
2671         (fileSize):
2672         (swizzledBundleIdentifierMobileSafari):
2673         (swizzledBundleIdentifierWebBookmarksD):
2674         (defaultApplicationCacheDirectory):
2675         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2676         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2677         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2678         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2679
2680 2016-07-19  Keith Miller  <keith_miller@apple.com>
2681
2682         Test262 should have a file with the revision and url
2683         https://bugs.webkit.org/show_bug.cgi?id=159937
2684
2685         Reviewed by Mark Lam.
2686
2687         The import script should update the information from
2688         the path to the test262 repository it gets.
2689
2690         * Scripts/import-test262-tests:
2691
2692 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2693
2694         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2695         To be deleted once the root cause is found and addressed.
2696
2697         * EWSTools/start-queue-mac.sh:
2698
2699 2016-07-19  Frederic Wang  <fwang@igalia.com>
2700
2701         [win] Fixup the register name for STIX Math and Latin Modern Math
2702
2703         Unreviewed follow-up of r203406
2704
2705         * Scripts/webkitdirs.pm:
2706         (checkInstalledTools):
2707
2708 2016-07-19  Frederic Wang  <fwang@igalia.com>
2709
2710         [win] Update the list of MathML fonts
2711         https://bugs.webkit.org/show_bug.cgi?id=156838
2712
2713         The set of recommended math fonts is now described at
2714         https://trac.webkit.org/wiki/MathML/Fonts
2715         We update the Perl script to use the latest list of fonts.
2716
2717         Reviewed by Brent Fulgham.
2718
2719         * Scripts/webkitdirs.pm:
2720         (checkInstalledTools):
2721
2722 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2723
2724         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2725         https://bugs.webkit.org/show_bug.cgi?id=159342
2726
2727         Reviewed by Darin Adler.
2728
2729         Implement required functions in event sender.
2730
2731         * DumpRenderTree/PlatformWin.cmake:
2732         * DumpRenderTree/win/EventSender.cpp:
2733         (monitorWheelEvents): Added.
2734         (callAfterScrollingCompletes): Added.
2735
2736 2016-07-19  Youenn Fablet  <youenn@apple.com>
2737
2738         Add new aliases to http test server
2739         https://bugs.webkit.org/show_bug.cgi?id=159878
2740
2741         Reviewed by Darin Adler.
2742
2743         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2744         Adding explicitly these links to perl script.
2745         Extracting default alias in an aliases.json file.
2746         Reading that file from python scripts to initialize aliases from that file.
2747
2748         Python script changes covered by unit tests and changed layout test.
2749
2750         * Scripts/webkitperl/httpd.pm:
2751         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2752         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2753         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2754         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2755         Adding -c directives for each alias.
2756         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2757         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2758         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2759         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2760         Adding alias directive for each alias.
2761         (Lighttpd._prepare_config):
2762         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2763         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2764         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2765         layout tests directory.
2766         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2767         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2768         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2769
2770 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2771
2772         EWS console logs doesn't go to log file
2773         https://bugs.webkit.org/show_bug.cgi?id=159539
2774         <rdar://problem/24464570>
2775
2776         Reviewed by David Kilzer.
2777
2778         * Scripts/webkitpy/common/system/logutils.py:
2779         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2780         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2781         to filesystem. It also supports passing MockFilesystem.
2782         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2783         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2784         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2785         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2786         (_test_ews): Same.
2787         * Scripts/webkitpy/tool/commands/queues.py:
2788         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2789         (AbstractQueue._log_directory): Using filesystem object instead of os.
2790         (AbstractQueue.queue_log_path): Same.
2791         (AbstractQueue.__init__): Passed host parameter.
2792         (PatchProcessingQueue.__init__): Same.
2793         (CommitQueue.__init__): Same.
2794         (AbstractReviewQueue.__init__): Same.
2795         (StyleQueue.__init__): Same.
2796         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2797         (TestCommitQueue): Passed MockHost() as host.
2798         (TestCommitQueue.__init__): Same.
2799         (TestQueue.__init__): Same.
2800         (TestReviewQueue.__init__): Same.
2801         (TestFeederQueue.__init__): Same.
2802         (AbstractPatchQueueTest.test_next_patch): Same.
2803         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2804         (test_commit_queue_failure): Same.
2805         (MockCommitQueueTask.results_from_patch_test_run): Same.
2806         (test_rollout_lands): Same.
2807         (test_non_valid_patch): Same.
2808         (test_auto_retry): Same.
2809         (test_style_queue_with_watch_list_exception): Same.
2810
2811 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2812
2813         WTF::Lock should be fair eventually
2814         https://bugs.webkit.org/show_bug.cgi?id=159384
2815
2816         Reviewed by Geoffrey Garen.
2817
2818         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2819
2820 2016-07-17  Sam Weinig  <sam@webkit.org>
2821
2822         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2823         <rdar://problem/26554137>
2824         https://bugs.webkit.org/show_bug.cgi?id=159856
2825
2826         Reviewed by Dan Bernstein.
2827
2828         * MiniBrowser/mac/WK2BrowserWindowController.m:
2829         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2830         Add basic window.open implementation.
2831
2832         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2833         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2834         to open a single non-web URL, all others are dropped.
2835
2836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2837         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2838         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2839         Add API for the new SPI.
2840
2841 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2842
2843         [JSC] Enable test262 module tests
2844         https://bugs.webkit.org/show_bug.cgi?id=159854
2845
2846         Reviewed by Saam Barati.
2847
2848         Use --module-file instead.
2849
2850         * Scripts/run-jsc-stress-tests:
2851
2852 2016-07-16  Chris Dumez  <cdumez@apple.com>
2853
2854         Unreviewed, rolling out r203318.
2855
2856         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2857         SunSpider)
2858
2859         Reverted changeset:
2860
2861         "[JSC] Change some parameters based on a random search"
2862         https://bugs.webkit.org/show_bug.cgi?id=158514
2863         http://trac.webkit.org/changeset/203318
2864
2865 2016-07-16  Chris Dumez  <cdumez@apple.com>
2866
2867         Add move constructor / assignment operator to ListHashSet
2868         https://bugs.webkit.org/show_bug.cgi?id=159837
2869
2870         Reviewed by Darin Adler.
2871
2872         Add API tests.
2873
2874         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2875         (TestWebKitAPI::TEST):
2876
2877 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2878
2879         [JSC] Change some parameters based on a random search
2880         https://bugs.webkit.org/show_bug.cgi?id=158514
2881
2882         Reviewed by Saam Barati.
2883
2884         * Scripts/run-jsc-stress-tests:
2885
2886 2016-07-15  Jon Davis  <jond@apple.com>
2887
2888         Changed the start page URL for WebKit Nightly builds.
2889         https://bugs.webkit.org/show_bug.cgi?id=159816
2890
2891         Reviewed by Timothy Hatcher.
2892
2893         * WebKitLauncher/start.html:
2894
2895 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2896
2897         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2898         https://bugs.webkit.org/show_bug.cgi?id=159414
2899
2900         Reviewed by Brent Fulgham.
2901
2902         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2903         when the HDC parameter is invalid.
2904
2905         * TestWebKitAPI/PlatformWin.cmake:
2906         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2907         (TestWebKitAPI::TEST):
2908
2909 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2910
2911         [GTK] Add basic tabs support to MiniBrowser
2912         https://bugs.webkit.org/show_bug.cgi?id=159803
2913
2914         Reviewed by Sergio Villar Senin.
2915
2916         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2917         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2918
2919         * MiniBrowser/gtk/BrowserTab.c: Added.
2920         (titleChanged):
2921         (isLoadingChanged):
2922         (decidePolicy):
2923         (removeChildIfInfoBar):
2924         (loadChanged):
2925         (createInfoBarQuestionMessage):
2926         (tlsErrorsDialogResponse):
2927         (loadFailedWithTLSerrors):
2928         (permissionRequestDialogResponse):
2929         (decidePermissionRequest):
2930         (colorChooserRGBAChanged):
2931         (popoverColorClosed):
2932         (colorChooserRequestFinished):
2933         (runColorChooserCallback):
2934         (inspectorOpenedInWindow):
2935         (inspectorClosed):
2936         (browserTabSetProperty):
2937         (browserTabFinalize):
2938         (browser_tab_init):
2939         (browserTabConstructed):
2940         (browser_tab_class_init):
2941         (getInternalURI):
2942         (browser_tab_new):
2943         (browser_tab_get_web_view):
2944         (browser_tab_load_uri):
2945         (browser_tab_get_title_widget):
2946         (browser_tab_set_status_text):
2947         (browser_tab_toggle_inspector):
2948         (browser_tab_start_search):
2949         (browser_tab_stop_search):
2950         (browser_tab_add_accelerators):
2951         (fullScreenMessageTimeoutCallback):
2952         (browser_tab_enter_fullscreen):
2953         (browser_tab_leave_fullscreen):
2954         * MiniBrowser/gtk/BrowserTab.h: Added.
2955         * MiniBrowser/gtk/BrowserWindow.c:
2956         (getExternalURI):
2957         (browserWindowSetStatusText):
2958         (reloadOrStopCallback):
2959         (goBackCallback):
2960         (goForwardCallback):
2961         (settingsCallback):
2962         (webViewURIChanged):
2963         (browserWindowHistoryItemActivated):
2964         (browserWindowUpdateNavigationActions):
2965         (webViewCreate):
2966         (webViewEnterFullScreen):
2967         (webViewLeaveFullScreen):
2968         (webViewDecidePolicy):
2969         (browserWindowCanZoomIn):
2970         (browserWindowCanZoomOut):
2971         (browserWindowZoomIn):
2972         (browserWindowZoomOut):
2973         (scrollEventCallback):
2974         (faviconChanged):
2975         (webViewIsLoadingChanged):
2976         (defaultZoomCallback):
2977         (searchCallback):
2978         (newTabCallback):
2979         (toggleWebInspector):
2980         (reloadPage):
2981         (reloadPageIgnoringCache):
2982         (stopPageLoad):
2983         (loadHomePage):
2984         (editingCommandCallback):
2985         (insertImageCommandCallback):
2986         (insertLinkCommandCallback):
2987         (browserWindowSetupEditorToolbar):
2988         (browserWindowSwitchTab):
2989         (browserWindowTabAddedOrRemoved):
2990         (browser_window_init):
2991         (browserWindowConstructed):
2992         (browserWindowSaveSession):
2993         (browserWindowDeleteEvent):
2994         (browser_window_new):
2995         (browser_window_append_view):
2996         (browser_window_load_uri):
2997         (browser_window_load_session):
2998         (browser_window_set_background_color):
2999         (resetStatusText): Deleted.
3000         (activateUriEntryCallback): Deleted.
3001         (webViewTitleChanged): Deleted.
3002         (resetEntryProgress): Deleted.
3003         (browserWindowCreateBackForwardMenu): Deleted.
3004         (webViewReadyToShow): Deleted.
3005         (webViewLoadFailed): Deleted.
3006         (webViewMouseTargetChanged): Deleted.
3007         (browserWindowUpdateZoomActions): Deleted.
3008         (webViewZoomLevelChanged): Deleted.
3009         (updateUriEntryIcon): Deleted.
3010         (zoomInCallback): Deleted.
3011         (zoomOutCallback): Deleted.
3012         (toggleFullScreen): Deleted.
3013         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3014         (browserWindowFinalize): Deleted.
3015         (browser_window_class_init): Deleted.
3016         * MiniBrowser/gtk/BrowserWindow.h:
3017         * MiniBrowser/gtk/CMakeLists.txt:
3018         * MiniBrowser/gtk/main.c:
3019         (createBrowserTab):
3020         (aboutURISchemeRequestCallback):
3021         (main):
3022         (parseBackgroundColor): Deleted.
3023
3024 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3025
3026         Allow RefPtrs of const RefCounted types
3027         https://bugs.webkit.org/show_bug.cgi?id=158269
3028
3029         Reviewed by Anders Carlsson.
3030
3031         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3032         (TestWebKitAPI::TEST):
3033         (TestWebKitAPI::ConstRefCounted::create):
3034         (TestWebKitAPI::returnConstRefCountedRef):
3035         (TestWebKitAPI::returnRefCountedRef):
3036
3037 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3038
3039         Test WTF.StringViewIterators is crashing since r203119
3040         https://bugs.webkit.org/show_bug.cgi?id=159710
3041
3042         Reviewed by Darin Adler.
3043
3044         There are two problems in the test case added in r203119. First is that it's testing
3045         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3046         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
3047         const reference to the string view member of the deleted CodePoints object.
3048
3049         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3050         (TestWebKitAPI::TEST):
3051
3052 2016-07-13  Daniel Bates  <dabates@apple.com>
3053
3054         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
3055         https://bugs.webkit.org/show_bug.cgi?id=159738
3056         <rdar://problem/27304649>
3057
3058         Reviewed by Dan Bernstein.
3059
3060         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
3061         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
3062         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
3063         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
3064
3065         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3066         * WebKitTestRunner/ios/TestControllerIOS.mm:
3067         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
3068         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
3069
3070 2016-07-13  Beth Dakin  <bdakin@apple.com>
3071
3072         Attempted build fix.
3073
3074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3075
3076 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
3077
3078         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
3079         https://bugs.webkit.org/show_bug.cgi?id=159686
3080
3081         Reviewed by Chris Dumez.
3082
3083         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
3084
3085         * WebKitTestRunner/TestController.cpp:
3086         (WTR::runOpenPanel):
3087         (WTR::TestController::createOtherPage):
3088         (WTR::TestController::createWebViewWithOptions):
3089
3090 2016-07-13  Beth Dakin  <bdakin@apple.com>
3091
3092         Add more candidate tests
3093         https://bugs.webkit.org/show_bug.cgi?id=159730
3094
3095         Reviewed by Tim Horton.
3096
3097         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
3098         two new tests to that file.
3099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3100         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
3101         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
3102         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
3103         (TestWebKitAPI::TEST):
3104         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
3105
3106 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
3107
3108         AX: [ATK] spinbutton-crash.html fails
3109         https://bugs.webkit.org/show_bug.cgi?id=159723
3110
3111         Reviewed by Chris Fleizach.
3112
3113         Implement support for AXDecrementButton and AXIncrementButton in
3114         ATK's AccessibilityUIElement::uiElementAttributeValue().
3115
3116         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3117         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3118
3119 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3120
3121         [EFL] [GTK] Enable back crypto subtle on development builds.
3122         https://bugs.webkit.org/show_bug.cgi?id=159260
3123
3124         Reviewed by Carlos Garcia Campos.
3125
3126         * Scripts/webkitperl/FeatureList.pm:
3127
3128 2016-07-12  Mark Lam  <mark.lam@apple.com>
3129
3130         We should use different stack limits for stack checks from JS and host code.
3131         https://bugs.webkit.org/show_bug.cgi?id=159442
3132         <rdar://problem/26889188>
3133
3134         Reviewed by Geoffrey Garen.
3135
3136         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3137         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
3138         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
3139         order to keep the js/regress-139548.html test happy with this patch.
3140
3141         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3142         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
3143
3144         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3145         (-[LTRelayController _environmentVariables]):
3146         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3147         (main):
3148
3149 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
3150
3151         platformUserPreferredLanguages on Mac should not try to put the region into the language
3152         https://bugs.webkit.org/show_bug.cgi?id=159693
3153
3154         Rubber stamped by Alexey Proskuryakov.
3155         
3156         Revert the test change in r200105.
3157
3158         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3159         (TestWebKitAPI::languageForSystemLanguage):
3160
3161 2016-07-12  Chris Dumez  <cdumez@apple.com>
3162
3163         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3164         https://bugs.webkit.org/show_bug.cgi?id=159663
3165         <rdar://problem/18995873>
3166
3167         Reviewed by Benjamin Poulain.
3168
3169         Add API test coverage.
3170
3171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3172         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3173         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3174         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3175         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3176         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3177         (TEST):
3178
3179 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
3180
3181         Relax ordering requirements on StringView::CodePoints iterator
3182         https://bugs.webkit.org/show_bug.cgi?id=159609
3183
3184         Reviewed by Darin Adler.
3185
3186         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3187         (TestWebKitAPI::TEST):
3188
3189 2016-07-12  Youenn Fablet  <youenn@apple.com>
3190
3191         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3192         https://bugs.webkit.org/show_bug.cgi?id=159564
3193
3194         Reviewed by Brian Burg.
3195
3196         * Scripts/webkitpy/codegen/main.py:
3197         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3198
3199 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3200
3201         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3202         https://bugs.webkit.org/show_bug.cgi?id=159671
3203
3204         Reviewed by Csaba Osztrogonác.
3205
3206         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3207         https://bugs.webkit.org/show_bug.cgi?id=89235
3208
3209         So this guard can be removed in build scripts.
3210
3211         * Scripts/webkitperl/FeatureList.pm:
3212         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3213
3214 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3215
3216         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3217         https://bugs.webkit.org/show_bug.cgi?id=159652
3218
3219         Reviewed by Daniel Bates.
3220
3221         * Scripts/webkitpy/common/checkout/scm/svn.py:
3222         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3223
3224 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3225
3226         Implement grapheme cluster iterator on StringView
3227         https://bugs.webkit.org/show_bug.cgi?id=159598
3228
3229         Reviewed by Anders Carlsson.
3230
3231         This is in preparation for honoring the second argument to FontFaceSet.load().
3232
3233         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3234         (TestWebKitAPI::compareLoopIterations):
3235         (TestWebKitAPI::TEST):
3236
3237 2016-07-11  Nan Wang  <n_wang@apple.com>
3238
3239         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3240         https://bugs.webkit.org/show_bug.cgi?id=158364
3241
3242         Reviewed by Anders Carlsson.
3243
3244         Added a function in TestRunner so that we can toggle the ignoring viewport
3245         scale limits setting. Also added a test option for that in order to change the 
3246         configuration of the webview in test.
3247
3248         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3249         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3250         (WTR::TestRunner::setNavigationGesturesEnabled):
3251         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3252         (WTR::nextUIScriptCallbackID):
3253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3254         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3255         * WebKitTestRunner/TestController.cpp:
3256         (WTR::TestController::resetStateToConsistentValues):
3257         (WTR::updateTestOptionsFromTestHeader):
3258         (WTR::TestController::setNavigationGesturesEnabled):
3259         (WTR::TestController::setIgnoresViewportScaleLimits):
3260         (WTR::TestController::platformWillRunTest):
3261         * WebKitTestRunner/TestController.h:
3262         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3263         * WebKitTestRunner/TestInvocation.cpp:
3264         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3265         * WebKitTestRunner/TestOptions.h:
3266         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3267         (WTR::TestController::platformCreateWebView):
3268
3269 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3270
3271         [GTK] install-dependencies should not install packages built by jhbuild.
3272         https://bugs.webkit.org/show_bug.cgi?id=159628
3273
3274         Reviewed by Michael Catanzaro.
3275
3276         * gtk/install-dependencies:
3277         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3278
3279 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3280
3281         System proxy settings not used when building deps with jhbuild
3282         https://bugs.webkit.org/show_bug.cgi?id=159567
3283
3284         Reviewed by Michael Catanzaro.
3285
3286         This adds the gsettings-desktop-schemas-devel build dep to enable
3287         the libgiognomeproxy.so gio module in glib-networking, which uses
3288         GSettings on org.gnome.system.proxy.
3289         This is needed to query system proxy settings for Gnome desktops.
3290
3291         dconf can be manually added to jhbuild to build the
3292         libdconfsettings.so gio module for GSettings, so that
3293         libgiognomeproxy.so can access system settings.
3294           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3295
3296         As an alternative to dconf settings, this commit also adds the
3297         libproxy-devel build dep to enable the libgiolibproxy.so module in
3298         glib-networking (suggested by Fujii Hironori).
3299
3300         It is useful to read proxy settings from environment variables.
3301         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3302         environment variable to force using the envvar module in libproxy.
3303
3304         * gtk/install-dependencies:
3305
3306 2016-07-11  Mark Lam  <mark.lam@apple.com>
3307
3308         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3309         https://bugs.webkit.org/show_bug.cgi?id=159524
3310
3311         Reviewed by Michael Saboff.
3312
3313         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3314         Also fixed up some tests to behave better to work with this new limit.  This
3315         should make stack overflow tests complete sooner.
3316
3317         * Scripts/run-jsc-stress-tests:
3318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3319         (main):
3320
3321 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3322
3323         [GTK] Whitespace fixes in install-dependencies script
3324
3325         Unreviewed.
3326
3327         * gtk/install-dependencies:
3328
3329 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3330
3331         [GTK] Install missing Fedora dependencies
3332
3333         Unreviewed.
3334
3335         * gtk/install-dependencies:
3336
3337 2016-07-09  Dan Bernstein  <mitz@apple.com>
3338
3339         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3340         https://bugs.webkit.org/show_bug.cgi?id=159600
3341
3342         Reviewed by Daniel Bates.
3343
3344         * Scripts/git-add-reviewer:
3345         Added the -s|--rubber-stamp option.
3346         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3347           new option.
3348
3349 2016-07-08  Andy Estes  <aestes@apple.com>
3350
3351         [Content Filtering] Load blocked pages more like other error pages are loaded
3352         https://bugs.webkit.org/show_bug.cgi?id=159485
3353         <rdar://problem/26014076>
3354
3355         Reviewed by Brady Eidson.
3356
3357         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3358         to a content filtering provisional navigation failure is ignored in preference of
3359         ContentFilter's own error page.
3360
3361         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3363         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3364         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3365         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3366         (loadAlternateTest):
3367         (TEST):
3368         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3369         (-[MockContentFilterEnabler initWithCoder:]):
3370         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3371         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3372         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3373         (TestWebKitAPI::loadAlternateTest):
3374         (TestWebKitAPI::TEST):
3375
3376 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3377
3378         Unreviewed, rolling out r202944.
3379         https://bugs.webkit.org/show_bug.cgi?id=159570
3380
3381         caused some tests to crash under GuardMalloc (Requested by
3382         estes on #webkit).
3383
3384         Reverted changeset:
3385
3386         "[Content Filtering] Load blocked pages more like other error
3387         pages are loaded"
3388         https://bugs.webkit.org/show_bug.cgi?id=159485
3389         http://trac.webkit.org/changeset/202944
3390
3391 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3392
3393         Remove mrobinson from the MathML watchlist
3394         https://bugs.webkit.org/show_bug.cgi?id=159559
3395
3396         Reviewed by Philippe Normand.
3397
3398         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3399
3400 2016-07-08  Brady Eidson  <beidson@apple.com>
3401
3402         Clearing LocalStorage doesn't also delete -wal and -shm files.
3403         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3404
3405         Reviewed by Brent Fulgham.
3406         Also helpfully picked over by Andy "Never Forgets" Estes.
3407
3408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3409         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3410         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3411
3412 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3413
3414         Removed Qt leftovers from Tools.
3415         https://bugs.webkit.org/show_bug.cgi?id=159557
3416
3417         Reviewed by Csaba Osztrogonác.
3418
3419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3420         Removed 'qt' platform config.
3421         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3422         Deleted non-functional e-mail address.
3423
3424 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3425
3426         Unreviewed, rolling out r202967.
3427         https://bugs.webkit.org/show_bug.cgi?id=159556
3428
3429         This patch caused crashes in https tests on Windows (Requested
3430         by perarne on #webkit).
3431
3432         Reverted changeset:
3433
3434         "[Win] The test http/tests/security/contentSecurityPolicy
3435         /upgrade-insecure-requests/basic-upgrade.https.html is
3436         failing."
3437         https://bugs.webkit.org/show_bug.cgi?id=159510
3438         http://trac.webkit.org/changeset/202967
3439
3440 2016-07-08  Youenn Fablet  <youenn@apple.com>
3441
3442         Generate WebCore builtin wrapper files
3443         https://bugs.webkit.org/show_bug.cgi?id=159461
3444
3445         Reviewed by Brian Burg.
3446
3447         * Scripts/webkitpy/codegen/main.py:
3448         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3449         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3450
3451 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3452
3453         [EFL] Fix build when media-stream is enabled.
3454         https://bugs.webkit.org/show_bug.cgi?id=159206
3455
3456         Bump up the openwebrtc to find the correct package.
3457
3458         Reviewed by Gyuyoung Kim.
3459
3460         * efl/jhbuild.modules:
3461         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3462
3463 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3464
3465         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3466         https://bugs.webkit.org/show_bug.cgi?id=159510
3467
3468         Reviewed by Brent Fulgham.
3469
3470         Allow any https certificate when running tests.
3471
3472         * DumpRenderTree/win/DumpRenderTree.cpp:
3473         (runTest):
3474
3475 2016-07-07  Beth Dakin  <bdakin@apple.com>
3476
3477         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3478         https://bugs.webkit.org/show_bug.cgi?id=159532
3479         -and corresponding-
3480         rdar://problem/27177179
3481
3482         Reviewed by Tim Horton.
3483
3484         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3485         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3486
3487 2016-07-07  Andy Estes  <aestes@apple.com>
3488
3489         [Content Filtering] Load blocked pages more like other error pages are loaded
3490         https://bugs.webkit.org/show_bug.cgi?id=159485
3491         <rdar://problem/26014076>
3492
3493         Reviewed by Brady Eidson.
3494
3495         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3496         to a content filtering provisional navigation failure is ignored in preference of
3497         ContentFilter's own error page.
3498
3499         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3501         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3502         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3503         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3504         (loadAlternateTest):
3505         (TEST):
3506         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3507         (-[MockContentFilterEnabler initWithCoder:]):
3508         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3509         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3510         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3511         (TestWebKitAPI::loadAlternateTest):
3512         (TestWebKitAPI::TEST):
3513
3514 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3515
3516         Unreviewed: add myself to the reviewers list.
3517
3518         * Scripts/webkitpy/common/config/contributors.json:
3519
3520 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3521
3522         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3523         https://bugs.webkit.org/show_bug.cgi?id=159509
3524
3525         Reviewed by Alex Christensen.
3526
3527         We should always insert the url in the url map when identifierForInitialRequest
3528         is called. Otherwise we can end up with identifiers not having an entry in the
3529         url map when urls are written to the test output file. 
3530
3531         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3532         (ResourceLoadDelegate::identifierForInitialRequest):
3533
3534 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3535
3536         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3537         https://bugs.webkit.org/show_bug.cgi?id=159498
3538         <rdar://problem/26719903>
3539
3540         Reviewed by Sam Weinig.
3541
3542         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3543         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3544         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3545         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3546         (expectLinkCount):
3547         (TEST):
3548         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3549         when deciding what to linkify.
3550
3551 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3552
3553         Build fix - work around rdar://problem/27196668.
3554
3555         * LayoutTestRelay/Configurations/Base.xcconfig:
3556
3557 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3558
3559         Enhance Windows DRT implementation to support platform scroll wheel events.
3560         https://bugs.webkit.org/show_bug.cgi?id=36002
3561
3562         Reviewed by Brent Fulgham.
3563
3564         Implement function continuousMouseScrollBy in Windows event sender.
3565
3566         * DumpRenderTree/win/EventSender.cpp:
3567         (mouseScrollBy):
3568         (continuousMouseScrollBy):
3569
3570 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3571
3572         [Sierra] Rebaseline tests to use un-mocked system font metrics
3573         https://bugs.webkit.org/show_bug.cgi?id=159311
3574         <rdar://problem/24138411>
3575
3576         Reviewed in person by Alexey Proskuryakov.
3577
3578         Stop mocking the system font on Sierra.
3579
3580         * DumpRenderTree/mac/DumpRenderTree.mm:
3581         (setDefaultsToConsistentValuesForTesting):
3582         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3583         (WTR::InjectedBundle::platformInitialize):
3584
3585 2016-07-05  Brady Eidson  <beidson@apple.com>
3586
3587         Database process crashes deleting a corrupt SQLite database file (null deref).
3588         https://bugs.webkit.org/show_bug.cgi?id=155506.
3589
3590         Reviewed by Alex Christensen.
3591
3592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3593         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3594         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3595         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3596         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3597         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3598
3599 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3600
3601         run-webkit-tests should print more complete baseline search paths
3602         https://bugs.webkit.org/show_bug.cgi?id=159354
3603
3604         Reviewed by Daniel Bates.
3605
3606         run-webkit-tests used to only print directory names in baseline search paths.
3607         This was ok in basic usage, but quickly got confusing when using
3608         --additional-platform-directory flags.
3609
3610         * Scripts/webkitpy/layout_tests/views/printing.py:
3611         (Printer.print_config):
3612         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3613         (Testprinter.test_print_config):
3614         (Testprinter.test_print_one_line_summary):
3615
3616 2016-07-04  Brady Eidson  <beidson@apple.com>
3617
3618         WebProcesses don't handle DatabaseProcess going away uncleanly..
3619         https://bugs.webkit.org/show_bug.cgi?id=159371
3620
3621         Reviewed by Alex Christensen.
3622
3623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3624         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3625         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3626         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3627         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3628
3629 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3630
3631         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3632         https://bugs.webkit.org/show_bug.cgi?id=158141
3633
3634         Rubber-stamped by Michael Catanzaro.
3635
3636         Instead of checking for an specific Ubuntu version, query the apt
3637         database to see which version of PHP is available.
3638
3639         * efl/install-dependencies:
3640         * gtk/install-dependencies:
3641
3642 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3643
3644         webkit-patch failure-reason always raises TypeError
3645         https://bugs.webkit.org/show_bug.cgi?id=159394
3646
3647         Reviewed by Benjamin Poulain.
3648
3649         In r170637 (Bug 133067), the first and second arguments of
3650         pluralize were swapped.
3651
3652         * Scripts/webkitpy/tool/commands/queries.py:
3653         (FailureReason._builder_to_explain): Swap the first and second
3654         arguments of pluralize.
3655
3656 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3657
3658         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3659         https://bugs.webkit.org/show_bug.cgi?id=152486
3660
3661         Reviewed by Daniel Bates.
3662
3663         Add launch of web-platform-tests server by run-webkit-httpd.
3664         Add two options to disable starting httpd and web-platform-tests servers.
3665
3666         * Scripts/run-webkit-httpd:
3667         (parse_args):
3668         (main):
3669
3670 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3671
3672         REGRESSION(r189668): Notification tests are flakey
3673         https://bugs.webkit.org/show_bug.cgi?id=159375
3674         <rdar://problem/22760990>
3675
3676         Reviewed by Alexey Proskuryakov.
3677
3678         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3679         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3680         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3681         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3682
3683         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3684         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3685         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3686         global notification ID mapping, causing the wrong notification to be investigated.
3687
3688         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3689         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3690         notification is created or destroyed. However, because this object is implemented outside WebKit,
3691         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3692         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3693         WebNotificationProvider can properly map between the different IDs.
3694
3695         * WebKitTestRunner/TestController.cpp:
3696         (WTR::TestController::runTestingServerLoop):
3697         (WTR::TestController::simulateWebNotificationClick):
3698         * WebKitTestRunner/WebNotificationProvider.cpp:
3699         (WTR::WebNotificationProvider::showWebNotification):
3700         (WTR::removeGlobalIDFromIDMap):
3701         (WTR::WebNotificationProvider::closeWebNotification):
3702         (WTR::WebNotificationProvider::removeNotificationManager):
3703         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3704         (WTR::WebNotificationProvider::reset):
3705         * WebKitTestRunner/WebNotificationProvider.h:
3706
3707 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3708
3709         Simplify LayoutTestRelay
3710         https://bugs.webkit.org/show_bug.cgi?id=159353
3711
3712         Reviewed by Daniel Bates.
3713
3714         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3715         by name and runtime makes no sense.
3716         2. Removed code to create devices, webkitpy always does this in advance.