d5e1f6b8ceef03b6ac7f079c5bba6ffdd9a69427
[WebKit.git] / Tools / ChangeLog
1 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
2
3         Reviewed by James Robinson.
4
5         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
6         https://bugs.webkit.org/show_bug.cgi?id=53522
7
8         * Scripts/run-chromium-webkit-unit-tests:
9
10 2011-02-01  Adam Barth  <abarth@webkit.org>
11
12         Reviewed by Mihai Parparita.
13
14         Using Control-C to cancel webkit-patch or other python tools causes
15         unpleasant traceback console spew
16         https://bugs.webkit.org/show_bug.cgi?id=53462
17
18         Catch the exception and don't print the stack trace.
19
20         * Scripts/webkit-patch:
21
22 2011-02-01  Scott Cameron  <sccameron@rim.com>
23
24         Reviewed by Daniel Bates.
25
26         Use Windows format for MinGW HTTPD path.
27         https://bugs.webkit.org/show_bug.cgi?id=53503
28
29         * Scripts/webkitperl/httpd.pm:
30           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
31             so that we don't have to escape the space characters in the path. Also,
32             changed path to Windows-style path and removed FIXME comment.
33
34 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
35
36         Reviewed by Andreas Kling.
37
38         [Qt][WK2] Add a way to use shared process model in MiniBrowser
39         https://bugs.webkit.org/show_bug.cgi?id=53090
40
41         * MiniBrowser/qt/BrowserView.cpp:
42         (BrowserView::BrowserView): Removed the m_context member.
43         From now the context is guaranteed to be non-null and we
44         don't need to store that in the object.
45         * MiniBrowser/qt/BrowserView.h:
46         * MiniBrowser/qt/BrowserWindow.cpp:
47         Added static bool to determine that new windows need to be
48         created with their own context or not. Use the same context
49         and web process by default to be inilne with the other ports.
50         (BrowserWindow::BrowserWindow):
51         (BrowserWindow::newWindow):
52         * MiniBrowser/qt/BrowserWindow.h:
53         * MiniBrowser/qt/main.cpp:
54         (main): Added command line switch to be able to use the
55         non-shared process model. Simplify the handling of the command line
56         switches a little bit.
57
58 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
59
60         Reviewed by Andreas Kling.
61
62         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
63         https://bugs.webkit.org/show_bug.cgi?id=53491
64
65         * MiniBrowser/qt/BrowserWindow.cpp:
66         (BrowserWindow::BrowserWindow):
67         (BrowserWindow::toggleFullScreenMode):
68         * MiniBrowser/qt/BrowserWindow.h:
69
70 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
71
72         Reviewed by Andreas Kling.
73
74         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
75         https://bugs.webkit.org/show_bug.cgi?id=53489
76
77         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
78         to Settings menu.
79
80         * MiniBrowser/qt/BrowserWindow.cpp:
81         (BrowserWindow::BrowserWindow):
82         (BrowserWindow::toggleFrameFlattening):
83         (BrowserWindow::toggleDisableJavaScript):
84         (BrowserWindow::toggleAutoLoadImages):
85         * MiniBrowser/qt/BrowserWindow.h:
86
87 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
88
89         Reviewed by Tony Chang.
90
91         [Chromium] Switch chromium-mac to use ChromiumDriver
92         https://bugs.webkit.org/show_bug.cgi?id=53461
93         
94         For the sake of consistency with the other Chromium platforms (and so
95         that chromium-mac picks up special flags like --enable-hardware-gpu),
96         switch chromium-mac from the WebKitDriver to ChromiumDriver.
97
98         * Scripts/webkitpy/layout_tests/port/chromium.py:
99
100 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
101
102         Reviewed by Mihai Parparita.
103
104         The current modifier parsing code in test_expectations is
105         fragile and hard-coded, so it's not easy to understand the logic
106         or easily add new types of modifiers (like GPU vs. CPU testing
107         for graphics tests, or 32-bit vs. 64-bit differences).
108
109         This is the first of two patches that will add in more generic
110         support and then eliminate the GPU-specific test expectations
111         files for Chromium.
112
113         This patch adds two standalone objects for handling modifiers. The
114         rules for interpreting modifiers, precedence, and conflicts are
115         given in the docstring to the ModifierMatcher class, which
116         returns ModifierMatchResult objects.
117         
118         This patch also adds routines to the Port interface and a
119         default set of values in the base object, in order to obtain the
120         values needed on a given test run. These values are then passed
121         to the expectation parser. This also allows us to clean up the
122         logic used to lint all of the different configurations in a
123         single test_expectations.txt file.
124
125         The next patch will merge in the separate GPU expectations file.
126
127         https://bugs.webkit.org/show_bug.cgi?id=51222
128
129         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
130         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
131         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
132         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
133         * Scripts/webkitpy/layout_tests/port/base.py:
134         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
135         * Scripts/webkitpy/layout_tests/port/chromium.py:
136         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
137         * Scripts/webkitpy/layout_tests/port/test.py:
138         * Scripts/webkitpy/layout_tests/port/webkit.py:
139         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
140         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
141         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
142         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
143         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
144
145 2011-01-31  Scott Cameron  <sccameron@rim.com>
146
147         Reviewed by Daniel Bates.
148
149         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
150         https://bugs.webkit.org/show_bug.cgi?id=50036
151
152         This will add an Apache2.2 configuration file and modifies scripts to allow
153         running an httpd server in an MSYS environment.
154
155         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
156         in order to allow for simple installation/execution.  Simply install the latest
157         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
158         be able to execute run-webkit-httpd.
159         
160
161         * Scripts/run-webkit-httpd:
162         * Scripts/webkitperl/httpd.pm:
163
164 2011-01-31  Tony Chang  <tony@chromium.org>
165
166         Reviewed by Eric Seidel.
167
168         mac DRT should report RTL scroll offset relative to top right corner
169         https://bugs.webkit.org/show_bug.cgi?id=53324
170
171         * DumpRenderTree/mac/DumpRenderTree.mm:
172         (dumpFrameScrollPosition):
173
174 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
175
176         Reviewed by Andreas Kling.
177
178         [Qt] Add Take Screen Shot action to MiniBrowser
179         https://bugs.webkit.org/show_bug.cgi?id=53422
180
181         Add Take Screen Shot action to MiniBrowser's view menu.
182
183         * MiniBrowser/qt/BrowserWindow.cpp:
184         (BrowserWindow::BrowserWindow):
185         (BrowserWindow::screenshot):
186         * MiniBrowser/qt/BrowserWindow.h:
187
188 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
189
190         Reviewed by Xan Lopez.
191
192         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
193         https://bugs.webkit.org/show_bug.cgi?id=53379
194
195         Remove left over #ifdef's. I thought all of the conditional code
196         had been freed from the condition, but I forgot to check DRT.
197
198         * DumpRenderTree/gtk/DumpRenderTree.cpp:
199         (resetDefaultsToConsistentValues):
200         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
201         (LayoutTestController::setAlwaysAcceptCookies):
202
203 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
204
205         Unreviewed, build fix.
206
207         Fix regression introduced in r77093 - path.rsplit() doesn't
208         take keyword arguments.
209
210         https://bugs.webkit.org/show_bug.cgi?id=53326
211
212         * Scripts/webkitpy/common/system/filesystem_mock.py:
213
214 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
215
216         Reviewed by Mihai Parparita.
217
218         Add more unit tests for rebaseline-chromium-webkit-tests. This
219         change involves restructuring a bunch of r-c-w-t code to make it
220         more testable as well. We also add wrapper classes for handling
221         testing zip files and fetching URLs.
222
223         https://bugs.webkit.org/show_bug.cgi?id=53040
224
225         * Scripts/webkitpy/common/system/urlfetcher.py:
226         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
227         * Scripts/webkitpy/common/system/zipfileset_mock.py:
228         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
229         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
230         * Scripts/webkitpy/tool/mocktool.py:
231
232 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
233
234         Reviewed by Eric Seidel.
235
236         Clean up of the filesystem-related modules used in webkitpy.
237         I've added relpath() to the filesystem interface, modified
238         ospath.relpath() so that it could work with the filesystem
239         interface, and modified the fileset* routines to use the
240         filesystem interface consistently.
241
242         This patch also adds a close() routine to the fileset routines
243         to indicate that the caller is done with the fileset. This
244         allows zipfileset to clean up after itself when it creates
245         tempfiles to store downloads.
246
247         https://bugs.webkit.org/show_bug.cgi?id=53326
248
249         * Scripts/webkitpy/common/system/directoryfileset.py:
250         * Scripts/webkitpy/common/system/fileset.py:
251         * Scripts/webkitpy/common/system/filesystem.py:
252         * Scripts/webkitpy/common/system/filesystem_mock.py:
253         * Scripts/webkitpy/common/system/filesystem_unittest.py:
254         * Scripts/webkitpy/common/system/ospath.py:
255         * Scripts/webkitpy/common/system/zipfileset.py:
256         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
257
258 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
259
260         Reviewed by Csaba Osztrogonác.
261
262         [Qt][WK2]REGRESSION (r76991): Fix build errors
263         https://bugs.webkit.org/show_bug.cgi?id=53400
264
265         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
266         and remove WebKit2Prefix.h from the build.
267         * MiniBrowser/qt/MiniBrowser.pro:
268
269 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
270
271         Unreviewed.
272
273         [Qt][WK2] Buildfix.
274
275         * MiniBrowser/qt/MiniBrowser.pro:
276
277 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
278
279         Reviewed by Adam Roben.
280         
281         define NOMINMAX when building ImageDiff, as we do elsewhere.
282
283         Add various clampToInt() methods to MathExtras.h
284         https://bugs.webkit.org/show_bug.cgi?id=52910
285
286         * DumpRenderTree/win/ImageDiffCommon.vsprops:
287
288 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
289
290         Reviewed by Darin Adler.
291
292         WebKitTestRunner needs layoutTestController.setPOSIXLocale
293         https://bugs.webkit.org/show_bug.cgi?id=42682
294
295         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
296         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
297         (WTR::InjectedBundle::resetLocalSettings):
298         (WTR::InjectedBundle::didReceiveMessage):
299         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
300         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
301         (WTR::LayoutTestController::setPOSIXLocale):
302         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
303
304 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
305  
306          Reviewed by Mihai Parparita.
307  
308          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
309  
310          This patch re-enables this test and changes it to
311          handle all of the mac platform versions, not just the one
312          it is running on.
313  
314          https://bugs.webkit.org/show_bug.cgi?id=53356
315  
316          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
317  
318 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
319
320         Unreviewed, build fix.
321
322         Take two. The fix in 77023 didn't work, because we were
323         still calling path.abspath_to_uri, which calls _cygpath under
324         the covers, and it appears the cygpath on the bots does
325         something different than it does on my machine. This patch
326         removes the calls to path.abspath_to_uri, so it should be safe.
327         If it doesn't work, I'll roll it out along with r76982 and 77023.
328
329         https://bugs.webkit.org/show_bug.cgi?id=53126
330
331         * Scripts/webkitpy/layout_tests/port/test.py:
332
333 2011-01-28  David Kilzer  <ddkilzer@apple.com>
334
335         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
336         <http://webkit.org/b/53353>
337
338         Reviewed by Mark Rowe.
339
340         * Scripts/webkitdirs.pm:
341         (checkRequiredSystemConfig): Check the Xcode marketing version
342         in addition to the DevCoreTools build version before complaining
343         about an old version of Xcode.  Also make the Mac OS X version
344         check use Perl's built-in version string comparitor.
345
346 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
347
348         Unreviewed, build fix.
349
350         Work around breakage on Win 7 Release bot caused by r76982
351         and the fact that windows ports use "file:////" instead of
352         "file:///". Ideally the test code should be isolated from
353         this, but it isn't yet. Will fix properly in a bit.
354
355         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
356
357 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
358
359         Reviewed by Tony Chang.
360
361         new-run-webkit-tests: change worker model values to
362         "old-inline", "old-threads" in preparation for test_runner2 /
363         multiprocessing changes.
364
365         https://bugs.webkit.org/show_bug.cgi?id=53156
366
367         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
368         * Scripts/webkitpy/layout_tests/port/base.py:
369         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
370         * Scripts/webkitpy/layout_tests/port/mac.py:
371         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
372
373 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
374
375         Reviewed by Tony Chang.
376
377         committers.py - add an IRC nickname for dpranke
378         https://bugs.webkit.org/show_bug.cgi?id=53335
379
380         * Scripts/webkitpy/common/config/committers.py:
381
382 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
383
384         Reviewed by Tony Chang.
385
386         new-run-webkit-tests: add a "mock DRT" port implementation
387         and a separate class that emulates what we expect the
388         DumpRenderTree behavior to be.
389
390         This will eventually replace port/dryrun.py and allow us to get
391         better test coverage of the new-run-webkit-tests code as well as
392         a reference for what new-run-webkit-tests expects from DRT.
393
394         This is the first attempt at this, and it is pretty bare-boned. It
395         really only has been tested on the 'mac' port (and a little on
396         the 'chromium-mac' port.
397
398         https://bugs.webkit.org/show_bug.cgi?id=53126
399
400         * Scripts/webkitpy/common/system/filesystem_mock.py:
401         * Scripts/webkitpy/layout_tests/port/dryrun.py:
402         * Scripts/webkitpy/layout_tests/port/factory.py:
403         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
404         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
405         * Scripts/webkitpy/layout_tests/port/test.py:
406
407 2011-01-28  Pratik Solanki  <psolanki@apple.com>
408
409         Unreviewed. Removing .swp file checked in by mistake.
410
411         * Scripts/.webkitdirs.pm.swp: Removed.
412
413 2011-01-28  Pratik Solanki  <psolanki@apple.com>
414
415         Reviewed by David Kilzer.
416
417         Space not necessary for undefined feature
418         https://bugs.webkit.org/show_bug.cgi?id=53317
419
420         * Scripts/build-webkit:
421
422 2011-01-28  Chang Shu  <chang.shu@nokia.com>
423
424         Reviewed by Andreas Kling.
425
426         Reset NetworkAccessManager to clean up credentials from previous tests.
427         This change causes no performance overhead either.
428         https://bugs.webkit.org/show_bug.cgi?id=36688
429
430         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
431         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
432         (WebCore::DumpRenderTree::open):
433         * DumpRenderTree/qt/DumpRenderTreeQt.h:
434
435 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
436
437         Reviewed by Andreas Kling.
438
439         [Qt] Add Zoom Text Only action to MiniBrowser
440         https://bugs.webkit.org/show_bug.cgi?id=53297
441
442         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
443
444         * MiniBrowser/qt/BrowserWindow.cpp:
445         (BrowserWindow::BrowserWindow):
446         (BrowserWindow::zoomIn):
447         (BrowserWindow::zoomOut):
448         (BrowserWindow::resetZoom):
449         (BrowserWindow::toggleZoomTextOnly):
450         (BrowserWindow::applyZoom):
451         * MiniBrowser/qt/BrowserWindow.h:
452
453 2011-01-28  Adam Barth  <abarth@webkit.org>
454
455         Reviewed by Eric Seidel.
456
457         Add webkit-patch roll-chromium-deps
458         https://bugs.webkit.org/show_bug.cgi?id=53288
459
460         This command updates the Source/WebKit/chromium/DEPS file with the
461         last-known good revision of Chromium (or a revision specified on the
462         command line).  I'd eventually like to turn this into a SheriffBot
463         command, but this is the first step.
464
465         This patch somewhat sprawled because I needed to move a bunch of code
466         out of ChangeLog that should never have been there in the first place.
467         Also, I had to fix a bug in MockUser in order to test the new command.
468
469         * Scripts/webkitpy/common/checkout/api.py:
470         * Scripts/webkitpy/common/checkout/changelog.py:
471         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
472         * Scripts/webkitpy/common/checkout/deps.py: Added.
473         * Scripts/webkitpy/common/config/urls.py:
474         * Scripts/webkitpy/tool/commands/__init__.py:
475         * Scripts/webkitpy/tool/commands/download_unittest.py:
476         * Scripts/webkitpy/tool/commands/roll.py: Added.
477         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
478         * Scripts/webkitpy/tool/commands/upload_unittest.py:
479         * Scripts/webkitpy/tool/mocktool.py:
480         * Scripts/webkitpy/tool/steps/__init__.py:
481         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
482         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
483         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
484         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
485         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
486         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
487
488 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
489
490         Reviewed by Laszlo Gombos.
491
492         Get rid of prefix header dependency for WebKit2 build system
493         https://bugs.webkit.org/show_bug.cgi?id=50174
494
495         Change the style checker so that it enforces config.h include for
496         WebKit2.
497
498         * Scripts/webkitpy/style/checker.py:
499
500 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
501
502         Reviewed by Darin Adler.
503
504         execCommand("Paste") doesn't work in WebKitTestRunner
505         https://bugs.webkit.org/show_bug.cgi?id=52785
506
507         Enable both of the settings needed to allow paste.
508         
509         * WebKitTestRunner/TestController.cpp:
510         (WTR::TestController::resetStateToConsistentValues):
511
512 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
513
514         Reviewed by Andreas Kling.
515
516         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
517         https://bugs.webkit.org/show_bug.cgi?id=48440
518
519         Preserve user input when toggling use of QGraphicsView
520
521         * QtTestBrowser/launcherwindow.cpp:
522         (LauncherWindow::initializeView):
523         (LauncherWindow::loadFinished):
524         * QtTestBrowser/launcherwindow.h:
525         * QtTestBrowser/mainwindow.cpp:
526         (MainWindow::addressUrl):
527         * QtTestBrowser/mainwindow.h:
528
529 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
530
531         Reviewed by Mihai Parparita.
532
533         new-run-webkit-tests: turn off pixel tests correctly by default
534         for webkit-based ports. r70013 (bug 47510) used
535         port.set_option_default() to attempt to set default values, but
536         that didn't work correctly. I have removed set_option_default
537         for now since it was only being used in two places and in three
538         useless unit tests. There is a separate bug open to fix the
539         option parsing (48095), so this workaround is fine for now.
540
541         https://bugs.webkit.org/show_bug.cgi?id=53217
542
543         * Scripts/webkitpy/layout_tests/port/webkit.py:
544         * Scripts/webkitpy/layout_tests/port/base.py:
545         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
546
547 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
548
549         Rubber-stamped by Ariya Hidayat.
550
551         Trivial crash fix in WTR.
552
553         * WebKitTestRunner/TestController.cpp:
554         (WTR::TestController::initialize): Increase the size
555         of the vector by one to be able to store the null character.
556
557 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
558
559         Reviewed by Csaba Osztrogonác.
560
561         [Qt][WK2] WTR should be initialized in the same way as DRT
562         https://bugs.webkit.org/show_bug.cgi?id=53240
563
564         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
565         (WTR::activateFonts): Added missing initialization steps.
566
567 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
568
569         Unreviewed. 
570
571         Adding myself to committers.py.
572
573         * Scripts/webkitpy/common/config/committers.py:
574
575 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
576
577         Reviewed by Csaba Osztrogonác.
578
579         [Qt] [Symbian] Move project files into Source
580         https://bugs.webkit.org/show_bug.cgi?id=52891
581
582         Fix the Symbian build after the project files
583         are moved to Source directory. On Symbian qmake
584         needs to run in the same directory where the main
585         pro files (WebKit.pro, Tools.pro) are located.
586
587         * Scripts/webkitdirs.pm: Change to the directory where the pro file
588         is located before running qmake for Symbian. Qmake on Symbian
589         does not properly honor the "-o" option, work it around by setting
590         the name of the Makefile to bld.inf.
591
592 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
593
594         Reviewed by Andreas Kling.
595
596         [Qt] Add simple zooming features to MiniBrowser
597         https://bugs.webkit.org/show_bug.cgi?id=53231
598
599         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
600
601         * MiniBrowser/qt/BrowserWindow.cpp:
602         (BrowserWindow::BrowserWindow):
603         (BrowserWindow::zoomIn):
604         (BrowserWindow::zoomOut):
605         (BrowserWindow::resetZoom):
606         (BrowserWindow::updateUserAgentList):
607         (BrowserWindow::applyZoom):
608         * MiniBrowser/qt/BrowserWindow.h:
609
610 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
611
612         Reviewed by Dan Bernstein.
613
614         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
615         https://bugs.webkit.org/show_bug.cgi?id=42319
616         
617         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
618
619         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
620         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
621         (WTR::LayoutTestController::showWebInspector):
622         (WTR::LayoutTestController::closeWebInspector):
623         (WTR::LayoutTestController::evaluateInWebInspector):
624         (WTR::LayoutTestController::setTimelineProfilingEnabled):
625         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
626         * WebKitTestRunner/TestInvocation.cpp:
627         (WTR::shouldOpenWebInspector):
628         (WTR::TestInvocation::invoke):
629         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
630
631 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
632
633         Reviewed by Xan Lopez.
634
635         [GTK] Pixel dumps do not include scrollbars in output images
636         https://bugs.webkit.org/show_bug.cgi?id=53216
637
638         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
639         that have scrollbars.
640
641         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
642         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
643         instead of the web view itself.
644
645 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
646
647         Reviewed by Mihai Parparita.
648
649         Fix regression introduced in r76322 ... new-run-webkit-tests
650         was attempting to save the image diff output as a UTF-8-encoded
651         file.
652
653         https://bugs.webkit.org/show_bug.cgi?id=53210
654
655         * Scripts/webkitpy/layout_tests/port/webkit.py:
656
657 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
658
659         Unreviewed, rolling out r76709.
660         http://trac.webkit.org/changeset/76709
661         https://bugs.webkit.org/show_bug.cgi?id=53194
662
663         "broke python tests on non-snowleopard platforms" (Requested
664         by dpranke on #webkit).
665
666         * Scripts/webkitpy/layout_tests/port/factory.py:
667         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
668         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
669
670 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
671
672         Reviewed by Tony Chang.
673
674         new-run-webkit-tests: add a "mock DRT" port implementation
675         and a separate class that emulates what we expect the
676         DumpRenderTree behavior to be.
677
678         This will eventually replace port/dryrun.py and allow us to get
679         better test coverage of the new-run-webkit-tests code as well as
680         a reference for what new-run-webkit-tests expects from DRT.
681
682         This is the first attempt at this, and it is pretty bare-boned. It
683         really only has been tested on the 'mac' port (and a little on
684         the 'chromium-mac' port.
685
686         https://bugs.webkit.org/show_bug.cgi?id=53126
687
688         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
689         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
690         * Scripts/webkitpy/layout_tests/port/factory.py:
691
692 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
693
694         Reviewed by Tony Chang.
695
696         Add '--no-timeout' option to Chromium DRT to ease debugging.
697         https://bugs.webkit.org/show_bug.cgi?id=52873
698
699         * DumpRenderTree/chromium/DumpRenderTree.cpp:
700         (main):
701
702 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
703
704         Reviewed by Andreas Kling.
705
706         [Qt] Fix qt_minimal build
707         https://bugs.webkit.org/show_bug.cgi?id=53172
708
709         * QtTestBrowser/locationedit.h:
710
711 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
712
713         Reviewed by Antonio Gomes.
714
715         QtTestBrowser should have a UI Setting to disable plugins
716         https://bugs.webkit.org/show_bug.cgi?id=52408
717         
718         Added a new action item named "Disable Plugins"
719         under the "Settings" menu. 
720
721         * QtTestBrowser/launcherwindow.cpp:
722         (LauncherWindow::createChrome):
723         (LauncherWindow::togglePlugins):
724         * QtTestBrowser/launcherwindow.h:
725
726 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
727
728         Reviewed by Adam Barth.
729
730         Move main CMakeLists.txt into Source directory
731         https://bugs.webkit.org/show_bug.cgi?id=52888
732
733         * Scripts/webkitdirs.pm:
734
735 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
736
737         Reviewed by Eric Seidel.
738
739         Improve label text in submit-to-ews
740         https://bugs.webkit.org/show_bug.cgi?id=53130
741
742         * QueueStatusServer/templates/submittoews.html:
743
744 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
745
746         Reviewed by Antonio Gomes.
747
748         QtTestBrowser should have a UI Settings to prevent loading images
749         https://bugs.webkit.org/show_bug.cgi?id=52409
750         
751         Added a new action item named "DisableAutoLoadImages"
752         under the "Settings" menu 
753
754         * QtTestBrowser/launcherwindow.cpp:
755         (LauncherWindow::createChrome):
756         (LauncherWindow::toggleAutoLoadImages):
757         * QtTestBrowser/launcherwindow.h:
758
759 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
760
761         Reviewed by Tony Chang.
762
763         Minor bug fixes and cleanup for filesystem wrappers, port/* test
764         classes, test_expectations.py. This change adds "test-win" and
765         "test-mac" variants to the test port so that we can better test
766         rebaselining, and adds a MockUser() object for reuse in testing.
767
768         https://bugs.webkit.org/show_bug.cgi?id=53036
769
770         * Scripts/webkitpy/common/system/filesystem.py:
771         * Scripts/webkitpy/common/system/filesystem_mock.py:
772         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
773         * Scripts/webkitpy/layout_tests/port/factory.py:
774         * Scripts/webkitpy/layout_tests/port/base.py:
775         * Scripts/webkitpy/layout_tests/port/test.py:
776         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
777         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
778         * Scripts/webkitpy/tool/mocktool.py:
779
780 2011-01-25  Tony Chang  <tony@chromium.org>
781
782         Reviewed by Dimitri Glazkov.
783
784         [chromium] remove unused layoutTestController callback
785         https://bugs.webkit.org/show_bug.cgi?id=53103
786
787         This method is used by a test_shell_test, but not needed by DRT.
788
789         * DumpRenderTree/chromium/LayoutTestController.cpp:
790         (LayoutTestController::LayoutTestController):
791         * DumpRenderTree/chromium/LayoutTestController.h:
792
793 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
794
795         Reviewed by Andreas Kling.
796
797         [GTK] Remove 64 bits release bot from the buildbot master
798         https://bugs.webkit.org/show_bug.cgi?id=52899
799
800         Removes the 64 bits release slave from the buildbot configuration,
801         so that we can use it as an EWS.
802
803         * BuildSlaveSupport/build.webkit.org-config/config.json:
804
805 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
806
807         Reviewed by Dan Bernstein.
808
809         Implement database quota callback to fix storage tests on WebKit2 bot
810         https://bugs.webkit.org/show_bug.cgi?id=53064
811
812         * WebKitTestRunner/TestController.cpp:
813         (WTR::exceededDatabaseQuota):
814         (WTR::TestController::createOtherPage):
815         (WTR::TestController::initialize):
816
817 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
818
819         Reviewed by Anders Carlsson.
820
821         Use designated temp directory for the database for WebKit2
822         https://bugs.webkit.org/show_bug.cgi?id=53052
823         
824         Adopt the new WK2 API for this.
825
826         * WebKitTestRunner/TestController.cpp:
827         (WTR::TestController::libraryPathForTesting):
828         (WTR::TestController::initialize):
829         * WebKitTestRunner/TestController.h:
830         * WebKitTestRunner/mac/TestControllerMac.mm:
831         (WTR::TestController::platformLibraryPathForTesting):
832         * WebKitTestRunner/qt/TestControllerQt.cpp:
833         (WTR::TestController::platformLibraryPathForTesting):
834         * WebKitTestRunner/win/TestControllerWin.cpp:
835         (WTR::TestController::platformLibraryPathForTesting):
836
837 2011-01-24  Lucas Forschler  <lforschler@apple.com>
838
839         Reviewed by Stephanie Lewis.
840
841         Add a new Leopard test bot.
842
843         * BuildSlaveSupport/build.webkit.org-config/config.json:
844
845 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
846
847         Reviewed by Adam Barth.
848
849         Add EFL Builder to core waterfall
850         https://bugs.webkit.org/show_bug.cgi?id=52704
851
852         Add EFL Builder to the core waterfall again.
853
854         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
855         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
856
857 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
858
859         Reviewed by Tony Chang.
860
861         new-run-webkit-tests fails to start HTTP server if there are proxy settings
862         https://bugs.webkit.org/show_bug.cgi?id=52872
863
864         Force disabling proxy to resolve the problem.
865
866         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
867         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
868
869 2011-01-24  Andreas Kling  <kling@webkit.org>
870
871         Reviewed by Darin Adler.
872
873         check-webkit-style: Update exemptions following Source/ move.
874         https://bugs.webkit.org/show_bug.cgi?id=53017
875
876         * Scripts/webkitpy/style/checker.py:
877         * Scripts/webkitpy/style/checker_unittest.py:
878
879 2011-01-24  Andras Becsi  <abecsi@webkit.org>
880
881         Rubber-stamped by Csaba Osztrogonác.
882
883         [Qt] Move project files into Source
884         https://bugs.webkit.org/show_bug.cgi?id=52891
885
886         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
887
888 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
889
890         Reviewed by Yury Semikhatsky.
891
892         Web Inspector: Find duplicate strings in localizedStrings.js
893
894         https://bugs.webkit.org/show_bug.cgi?id=53005
895
896         * Scripts/check-inspector-strings:
897
898 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
899
900         Reviewed by Andreas Kling.
901
902         [Qt] Regroup MiniBrowser's menubar and add open file action
903         https://bugs.webkit.org/show_bug.cgi?id=53000
904
905         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
906
907         * MiniBrowser/qt/BrowserWindow.cpp:
908         (BrowserWindow::BrowserWindow):
909         (BrowserWindow::openFile):
910         (BrowserWindow::~BrowserWindow):
911         * MiniBrowser/qt/BrowserWindow.h:
912
913 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
914
915         Unreviewed fix after r76496
916
917         [Qt] Move project files into Source
918         https://bugs.webkit.org/show_bug.cgi?id=52891
919
920         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
921         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
922         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
923
924 2011-01-24  Andras Becsi  <abecsi@webkit.org>
925
926         Reviewed by Csaba Osztrogonác.
927
928         [Qt] Move project files into Source
929         https://bugs.webkit.org/show_bug.cgi?id=52891
930
931         * DerivedSources.pro: Renamed from DerivedSources.pro.
932         * DumpRenderTree/qt/DumpRenderTree.pro:
933         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
934         * MiniBrowser/DerivedSources.pro:
935         * MiniBrowser/qt/MiniBrowser.pro:
936         * QtTestBrowser/QtTestBrowser.pro:
937         * Scripts/webkitdirs.pm:
938         * Tools.pro: Added.
939         * WebKitTestRunner/DerivedSources.pro:
940         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
941         * WebKitTestRunner/qt/WebKitTestRunner.pro:
942
943 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
944
945         Reviewed by Dan Bernstein.
946
947         Beefed up --threaded mode to catch even more kinds of errors.
948         https://bugs.webkit.org/show_bug.cgi?id=52971
949
950         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
951         context group to force JSC to mark multiple threads. (This used to be
952         the default, but it changed in SnowLeopard.)
953         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
954         to give threading mistakes more chances to show themselves.
955         (startJavaScriptThreads):
956         (stopJavaScriptThreads):
957
958 2011-01-22  Robert Hogan  <robert@webkit.org>
959
960         Reviewed by Andreas Kling.
961
962         [Qt] Support layoutTestController.addURLToRedirect()
963         https://bugs.webkit.org/show_bug.cgi?id=52956
964
965         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
966         (LayoutTestController::addURLToRedirect):
967         * DumpRenderTree/qt/LayoutTestControllerQt.h:
968
969 2011-01-22  Robert Hogan  <robert@webkit.org>
970
971         Reviewed by Kenneth Rohde Christiansen.
972
973         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
974         https://bugs.webkit.org/show_bug.cgi?id=49802
975
976         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
977         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
978         (WebCore::DumpRenderTree::open):
979
980 2011-01-21  Adam Barth  <abarth@webkit.org>
981
982         Reviewed by Maciej Stachowiak.
983
984         Disable mac_unittest.py that fails on some of the Mac bots
985         https://bugs.webkit.org/show_bug.cgi?id=52947
986
987         As noted in the comment, this test does not appear to be correct
988         because the function this test is testing returns different results
989         depending on which flavor of Mac the test is run on.  This patch
990         disable the test.  Hopefully we can re-enable the test once we've
991         probably insulated the test from its environment.
992
993         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
994
995 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
996
997         Reviewed by Mihai Parparita.
998
999         Fix bug introduced in r76322 that caused NRWT to not actually
1000         read the Skipped files properly.
1001
1002         https://bugs.webkit.org/show_bug.cgi?id=52771
1003
1004         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1005         * Scripts/webkitpy/layout_tests/port/webkit.py:
1006         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1007
1008 2011-01-21  Sam Weinig  <sam@webkit.org>
1009
1010         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1011
1012         WebKitTestRunner needs the HOME environment variable to be set.
1013         <rdar://problem/8896573>
1014
1015         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1016         it exists.
1017
1018 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1019
1020         Reviewed by Eric Seidel.
1021
1022         Suppress a few remaining integration tests so that none of the
1023         layout_test unit tests ever read from the filesystem or launch
1024         subprocesses that aren't part of the unit tests.
1025
1026         Also fix a minor bug in the printing unit tests that was
1027         incorrectly relying on sys.argv.
1028
1029         https://bugs.webkit.org/show_bug.cgi?id=52863
1030
1031         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1032         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1033         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1034
1035 2011-01-21  Darin Adler  <darin@apple.com>
1036
1037        Fix Mac build.
1038
1039         * MiniBrowser/mac/BrowserWindowController.m:
1040         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1041
1042 2011-01-20  Darin Adler  <darin@apple.com>
1043
1044         Reviewed by Dan Bernstein.
1045
1046         WebKit2: Implement showModalDialog
1047         https://bugs.webkit.org/show_bug.cgi?id=52855
1048
1049         This fixes WebKitTestRunner to compile, but more work is probably
1050         needed to get it to pass the tests.
1051
1052         * WebKitTestRunner/TestController.cpp:
1053         (WTR::TestController::runModal): Added. Calls through to the
1054         platform-specific version of runModal.
1055         (WTR::TestController::createOtherPage): Changed to be a private
1056         static member function so it can refer to runModal, which is
1057         a private static member function.
1058         (WTR::TestController::initialize): Pass 0 for the runModal
1059         function since we don't need to run the main window modal.
1060         I suspect this is wrong and will need to change.
1061         * WebKitTestRunner/TestController.h: Added declarations for
1062         the functions added above.
1063         * WebKitTestRunner/mac/TestControllerMac.mm:
1064         (WTR::TestController::runModal): Added. Untested implementation.
1065         * WebKitTestRunner/qt/TestControllerQt.cpp:
1066         (WTR::TestController::runModal): Added.
1067         * WebKitTestRunner/win/TestControllerWin.cpp:
1068         (WTR::TestController::runModal): Added.
1069
1070 2011-01-21  Eric Seidel  <eric@webkit.org>
1071
1072         Reviewed by Adam Barth.
1073
1074         Split Host object off from WebKitPatch for easier re-use
1075         https://bugs.webkit.org/show_bug.cgi?id=52284
1076
1077         new-run-webkit-tests and other tools are eventually going to want one of these.
1078         Basically you need to inherit from this class if you want to pretend to be a
1079         self.tool object for Steps/Commands.
1080
1081         * Scripts/webkitpy/common/host.py: Added.
1082         * Scripts/webkitpy/tool/main.py:
1083
1084 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1085
1086         Reviewed by Adam Barth.
1087
1088         Disable the tests that start and stop the http server and web
1089         server, so that we don't have to worry about port collisions on
1090         the bots.
1091
1092         https://bugs.webkit.org/show_bug.cgi?id=52861
1093
1094         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1095
1096 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1097
1098         Reviewed by Eric Seidel.
1099
1100         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1101         
1102         https://bugs.webkit.org/show_bug.cgi?id=52772
1103         
1104         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1105
1106 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1107
1108         Reviewed by Eric Siedel.
1109
1110         nrwt: clean up almost all remaining port references, remove
1111         unnecessary import clauses. The only remaining references are
1112         in places where a mock filesystem makes no sense or can't be
1113         used, and in one routine in port/google_chrome_unittest that
1114         I'll rewrite in a separate patch.
1115
1116         https://bugs.webkit.org/show_bug.cgi?id=52771
1117
1118         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1119         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1120         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1121         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1122         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1123         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1124         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1125         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1126         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1127         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1128         * Scripts/webkitpy/layout_tests/port/gtk.py:
1129         * Scripts/webkitpy/layout_tests/port/mac.py:
1130         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1131         * Scripts/webkitpy/layout_tests/port/qt.py:
1132         * Scripts/webkitpy/layout_tests/port/webkit.py:
1133         * Scripts/webkitpy/layout_tests/port/win.py:
1134         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1135
1136 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1137
1138         Reviewed by Mihai Parparita.
1139
1140         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1141
1142         https://bugs.webkit.org/show_bug.cgi?id=52762
1143
1144         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1145         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1146
1147 2011-01-20  Tony Chang  <tony@chromium.org>
1148
1149         Reviewed by Ojan Vafai.
1150
1151         [chromium] fix the paths used for the rebaseline tool
1152         https://bugs.webkit.org/show_bug.cgi?id=52857
1153
1154         Some of the bots were renamed so the path to grab the results zip
1155         file has changed.
1156
1157         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1158
1159 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1160
1161         Reviewed by Tony Chang.
1162
1163         Fix bug introduced in r72688 / bug 52768 that broke the
1164         generation of the output filename links in the results.html
1165         output. Apparently none of the unit tests actually checked to
1166         make sure the generated links were correct :(
1167
1168         https://bugs.webkit.org/show_bug.cgi?id=52854
1169
1170         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1171         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1172
1173 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1174
1175         Reviewed by Darin Adler.
1176
1177         https://bugs.webkit.org/show_bug.cgi?id=52849
1178         Make window.print work with WebKit2
1179
1180         * MiniBrowser/mac/BrowserWindowController.m:
1181         (-[BrowserWindowController awakeFromNib]):
1182         * WebKitTestRunner/TestController.cpp:
1183         (WTR::createOtherPage):
1184         (WTR::TestController::initialize):
1185         Added zeroes to WKPageUIClient structures to avoid build failures.
1186
1187 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1188
1189         Reviewed by Eric Seidel.
1190
1191         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1192
1193         https://bugs.webkit.org/show_bug.cgi?id=52756
1194
1195         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1196         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1197         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1198         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1199         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1200         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1201
1202 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1203
1204         Reviewed by Antonio Gomes.
1205
1206         QtTestBrowser should have a seperate menu for Settings
1207         https://bugs.webkit.org/show_bug.cgi?id=52817
1208         
1209         Added a new menu item named "Settings"
1210         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1211
1212         * QtTestBrowser/launcherwindow.cpp:
1213         (LauncherWindow::createChrome):
1214
1215 2011-01-20  Sam Weinig  <sam@webkit.org>
1216
1217         Reviewed by John Sullivan.
1218
1219         Update update-webkit-localizable-strings with new path to WebKit.
1220
1221         * Scripts/update-webkit-localizable-strings:
1222
1223 2011-01-20  James Robinson  <jamesr@chromium.org>
1224
1225         Reviewed by Darin Fisher.
1226
1227         Implement mozilla's requestAnimationFrame API
1228         https://bugs.webkit.org/show_bug.cgi?id=51218
1229
1230         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1231
1232         * DumpRenderTree/chromium/WebViewHost.cpp:
1233         (invokeScheduleComposite):
1234         (WebViewHost::scheduleAnimation):
1235         (WebViewHost::paintInvalidatedRegion):
1236         * DumpRenderTree/chromium/WebViewHost.h:
1237
1238 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1239
1240         Reviewed by Adam Roben.
1241
1242         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1243         https://bugs.webkit.org/show_bug.cgi?id=42327
1244
1245         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1246         for methods that take their normal arguments but also a JSContextRef.
1247         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1248         for evaluateScriptInIsolatedWorld.
1249         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1250         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1251         this call is for an isolated world.
1252         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1253         (WTR::worldMap): Helper to create a world map.
1254         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1255         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1256         added LayoutTestController API.
1257         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1258
1259 2011-01-19  Adam Roben  <aroben@apple.com>
1260
1261         Convert paths in environment variables back to msys-style inside commit-log-editor
1262
1263         When this script gets run from inside git commit, msys-style paths in the environment will
1264         have been turned into Windows-style paths with forward slashes. This screws up functions
1265         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1266         the paths back to msys-style before doing anything else.
1267
1268         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1269         using msysgit's Perl and multiple ChangeLogs have been edited
1270
1271         Reviewed by David Kilzer.
1272
1273         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1274         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1275         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1276
1277 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1278
1279         [Win] Unreviewed build fix after r76248.
1280
1281         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1282
1283 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1284
1285         Reviewed by Csaba Osztrogonác.
1286
1287         Refactoring of the custom allocation framework
1288         https://bugs.webkit.org/show_bug.cgi?id=49897
1289
1290         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1291         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1292         equivalent macro implementation at the necessary places.
1293 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1294
1295         Unreviewed. 
1296
1297         Adding myself to committers.py.
1298
1299         * Scripts/webkitpy/common/config/committers.py:
1300
1301 2011-01-20  Adam Barth  <abarth@webkit.org>
1302
1303         Reviewed by Tony Chang.
1304
1305         Chromium builders don't delete unversioned directories when DEPS change
1306         https://bugs.webkit.org/show_bug.cgi?id=52745
1307
1308         If we pass this option to gclient sync, gclient will delete directories
1309         that are no longer part of DEPS instead of leaving them around to
1310         confuse us later.  Apparently, the downstream buildbots use this option
1311         already.
1312
1313         * Scripts/update-webkit-chromium:
1314
1315 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1316
1317         Unreviewed, build fix - I pulled this patch in to fix an issue
1318         revealed by r76195 running on some new bots). Also fix a couple
1319         of other issues revealed in testing.
1320
1321         nrwt: remove fs refs from layout_package/json*
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=52754
1324
1325         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1326         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1327         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1328         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1329         * Scripts/webkitpy/layout_tests/port/base.py:
1330
1331 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1332
1333         Unreviewed, build fix.
1334
1335         Fix a couple of minor bugs discovered while bringing up new bots
1336         for testing.
1337
1338         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1339         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1340
1341 2011-01-19  James Robinson  <jamesr@chromium.org>
1342
1343         Unreviewed, rolling out r76194.
1344         http://trac.webkit.org/changeset/76194
1345         https://bugs.webkit.org/show_bug.cgi?id=51218
1346
1347         Caused mysterious compile failure on the chromium win
1348         build.webkit.org bots
1349
1350         * DumpRenderTree/chromium/WebViewHost.cpp:
1351         (WebViewHost::paintInvalidatedRegion):
1352         * DumpRenderTree/chromium/WebViewHost.h:
1353
1354 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1355
1356         Reviewed by Mihai Parparita.
1357
1358         remove fs refs from test_runner, dump_render_tree_thread
1359
1360         https://bugs.webkit.org/show_bug.cgi?id=52753
1361
1362         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1363         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1364         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1365         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1366
1367 2011-01-19  James Robinson  <jamesr@chromium.org>
1368
1369         Reviewed by Darin Fisher.
1370
1371         Implement mozilla's requestAnimationFrame API
1372         https://bugs.webkit.org/show_bug.cgi?id=51218
1373
1374         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1375
1376         * DumpRenderTree/chromium/WebViewHost.cpp:
1377         (invokeScheduleComposite):
1378         (WebViewHost::scheduleAnimation):
1379         (WebViewHost::paintInvalidatedRegion):
1380         * DumpRenderTree/chromium/WebViewHost.h:
1381
1382 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1383
1384         Unreviewed, build fix.
1385
1386         Fix a few incorrect "self._filesystem" references introduced in
1387         r76184.
1388
1389         * Scripts/webkitpy/layout_tests/port/chromium.py:
1390         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1391
1392 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1393
1394         Reviewed by Mihai Parparita.
1395
1396         add a .sep property, abspath(), isabs(), mtime(), and
1397         open_text_file_for_writing() to filesystem modules. Some of
1398         these properties are not needed in this patch but will be needed
1399         in subsequent patches (I'm doing this to avoid having to track
1400         multiple versions of a single file).
1401
1402         Also, change most of the port/* modules to use the filesystem
1403         objects instead of referencing the filesystem directly.
1404
1405         https://bugs.webkit.org/show_bug.cgi?id=52748
1406
1407         * Scripts/webkitpy/common/system/filesystem.py:
1408         * Scripts/webkitpy/common/system/filesystem_mock.py:
1409         * Scripts/webkitpy/layout_tests/port/__init__.py:
1410         * Scripts/webkitpy/layout_tests/port/base.py:
1411         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1412         * Scripts/webkitpy/layout_tests/port/chromium.py:
1413         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1414         * Scripts/webkitpy/layout_tests/port/config.py:
1415         * Scripts/webkitpy/layout_tests/port/test.py:
1416         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1417
1418 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1419
1420         Reviewed by Anders Carlsson.
1421
1422         If resetting between tests times out, treat it as a WebProcess crash
1423         https://bugs.webkit.org/show_bug.cgi?id=52757
1424
1425         * WebKitTestRunner/TestController.cpp:
1426         (WTR::TestController::runTest):
1427
1428 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1429
1430         Reviewed by Darin Adler.
1431
1432         https://bugs.webkit.org/show_bug.cgi?id=52739
1433         Make it possible for a WebKit2 client to print headers and footers
1434
1435         Added dummy implementations for new printing UIClient calls.
1436
1437         * MiniBrowser/mac/BrowserWindowController.m:
1438         (-[BrowserWindowController awakeFromNib]):
1439         * WebKitTestRunner/TestController.cpp:
1440         (WTR::createOtherPage):
1441         (WTR::TestController::initialize):
1442
1443 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1444
1445         Reviewed by Ojan Vafai.
1446
1447         Change webkitpy/layout_tests/port/test.py to use the
1448         in-memory filesystem for cleaner unit testing. This
1449         change allows us to kill a lot of code that was
1450         specific to the test port, at the cost of being a
1451         little less clear about how things would work if
1452         you didn't have a filesystem.
1453
1454         https://bugs.webkit.org/show_bug.cgi?id=52605
1455
1456         * Scripts/webkitpy/layout_tests/port/test.py:
1457
1458 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1459
1460         Unreviewed, build fix.
1461
1462         Fix test failure caused by committing attachment 79368 instead
1463         of attachment 79461 on bug 52604.
1464
1465         * Scripts/webkitpy/common/system/filesystem_mock.py:
1466
1467 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1468
1469         Reviewed by Mihai Parparita.
1470
1471         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1472         unit testing. os.walk() is too much of a hassle to implement on
1473         top of the in-memory mock filesystem and adding the necessary
1474         interface to files_under() gives clients a cleaner API anyway
1475         (for this particular usage model).
1476
1477         https://bugs.webkit.org/show_bug.cgi?id=52691
1478
1479         * Scripts/webkitpy/common/system/filesystem.py:
1480         * Scripts/webkitpy/common/system/filesystem_mock.py:
1481         * Scripts/webkitpy/layout_tests/port/test_files.py:
1482         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1483
1484 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1485
1486         Reviewed by Tony Chang.
1487
1488         Change more modules in the layout-tests code to use the
1489         filesystem wrapper for cleaner unit testing.
1490
1491         This patch also adds the glob() wrapper to the filesystem
1492         abstraction.
1493         
1494         https://bugs.webkit.org/show_bug.cgi?id=52604
1495
1496         * Scripts/webkitpy/layout_tests/port/test_files.py:
1497         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1498         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1499         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1500         * Scripts/webkitpy/common/system/filesystem.py:
1501         * Scripts/webkitpy/common/system/filesystem_mock.py:
1502
1503 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1504
1505         Unreviewed.
1506
1507         Updating my email addresses and irc nick.
1508
1509         * Scripts/webkitpy/common/config/committers.py:
1510
1511 2011-01-19  Tony Chang  <tony@chromium.org>
1512
1513         Reviewed by Mihai Parparita.
1514
1515         [chromium] [linux] if check-sys-deps fails, output the failure reason
1516         https://bugs.webkit.org/show_bug.cgi?id=52671
1517
1518         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1519             error handler functions.
1520         * Scripts/webkitpy/layout_tests/port/chromium.py:
1521             output the error text from --check-sys-deps
1522         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1523
1524 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1525
1526         Reviewed by Andreas Kling.
1527
1528         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1529         https://bugs.webkit.org/show_bug.cgi?id=52554
1530         
1531         QtNetworkAccessManager is created in a thread and set as
1532         member variable in QWebPage. When the thread is destroyed
1533         the object is still used. So fix will set the object to
1534         NULL once the thread is destroyed.
1535
1536         * QtTestBrowser/launcherwindow.cpp:
1537         (LauncherWindow::~LauncherWindow):
1538
1539 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1540
1541         Rubber stamped by Csaba Osztrogonac
1542
1543         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1544
1545 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1546
1547         Reviewed by Tony Chang.
1548
1549         new-run-webkit-tests: add a --build-directory command line argument
1550
1551         Official Google Chrome builds use a non-standard build directory
1552         location. This patch adds a --build-directory argument that
1553         allows that location to be specified on the command line. Only
1554         Chromium-based builds will use this flag for now, but anyone can
1555         in the future.
1556
1557         There are no unit tests for this since it's difficult to test
1558         until mock filesystems are fully supported in the code. This was
1559         tested by hand for now.
1560
1561         https://bugs.webkit.org/show_bug.cgi?id=52694
1562
1563         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1564         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1565         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1566         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1567
1568 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1569
1570         Not reviewed. Bot fix.
1571
1572         Remove an inadvertently committed debugging print.
1573
1574         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1575         (LayoutTestController::notifyDone):
1576
1577 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1578
1579         Reviewed by Sam Weinig.
1580
1581         WebKitTestRunner should track loading more like DumpRenderTree
1582         https://bugs.webkit.org/show_bug.cgi?id=52692
1583
1584         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1585         This makes some tests that call notifyDone multiple times pass.
1586         
1587         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1588         (WTR::InjectedBundle::InjectedBundle):
1589         (WTR::InjectedBundle::done):
1590         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1591         (WTR::InjectedBundle::topLoadingFrame):
1592         (WTR::InjectedBundle::setTopLoadingFrame):
1593         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1594         (WTR::InjectedBundlePage::InjectedBundlePage):
1595         (WTR::InjectedBundlePage::stopLoading):
1596         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1597         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1598         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1599         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1600         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1601         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1602         (WTR::LayoutTestController::notifyDone):
1603         * WebKitTestRunner/TestController.cpp:
1604         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1605
1606 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1607
1608         Reviewed by Kent Tamura.
1609
1610         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1611         https://bugs.webkit.org/show_bug.cgi?id=52678
1612         
1613         Update path now that WebKit is inside Source.
1614
1615         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1616
1617 2011-01-18  Robert Hogan  <robert@webkit.org>
1618
1619         Reviewed by Simon Hausmann.
1620
1621         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1622         https://bugs.webkit.org/show_bug.cgi?id=44282
1623
1624         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1625         (WebCore::DumpRenderTree::dump):
1626
1627 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1628
1629         Reviewed by Mihai Parparita.
1630
1631         Fix a small race condition that could cause the unit tests for
1632         new-run-webkit-tests to fail in a multithreaded environment.
1633         There was a small window in the code where one thread would
1634         check to see if a thread had raised an exception, do something,
1635         and then check to see if the thread was alive. If the other
1636         thread raised an exception and exited in between these two
1637         steps, the exception would be lost. Flipping the order of the
1638         two checks fixes the race, since we will now always check for an
1639         exception on the thread before exiting.
1640
1641         https://bugs.webkit.org/show_bug.cgi?id=51579
1642
1643         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1644
1645 2011-01-18  Eric Seidel  <eric@webkit.org>
1646
1647         Reviewed by Adam Barth.
1648
1649         commit-queue dies when test archiving fails
1650         https://bugs.webkit.org/show_bug.cgi?id=52617
1651
1652         I looked at the machine and it had 10 archives already
1653         thus find_unused_name was returning None.  I've upped
1654         the limit to 100 (per bug) and tested the case where
1655         find_unused_name returns None (making archive return None).
1656
1657         * Scripts/webkitpy/common/system/workspace.py:
1658         * Scripts/webkitpy/common/system/workspace_unittest.py:
1659         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1660         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1661         * Scripts/webkitpy/tool/commands/queues.py:
1662
1663 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1664
1665         Reviewed by Ojan Vafai.
1666
1667         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1668         filesystem. Also fix a couple of "with" statements missed by
1669         r76050.
1670
1671         https://bugs.webkit.org/show_bug.cgi?id=52487
1672
1673         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1674
1675 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1676
1677         Reviewed by Martin Robinson.
1678
1679         [Gtk] Build fixes for gtk3 build
1680         https://bugs.webkit.org/show_bug.cgi?id=52648
1681
1682         * DumpRenderTree/gtk/EventSender.cpp:
1683         (beginDragWithFilesCallback):
1684
1685 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1686
1687         Reviewed by Mihai Parparita.
1688
1689         Update rebaseline-chromium-webkit-tests to use filesystem objects
1690         instead of direct references to os.path, shutil, tempfile, etc.
1691
1692         This patch doesn't change anything, but will allow subsequent
1693         patches to change the unit tests to no longer use the real
1694         filesystem.
1695
1696         This patch adds a bunch more methods to the filesystem object as
1697         well.
1698
1699         https://bugs.webkit.org/show_bug.cgi?id=52482
1700
1701         * Scripts/webkitpy/common/system/filesystem.py:
1702         * Scripts/webkitpy/common/system/filesystem_mock.py:
1703         * Scripts/webkitpy/tool/commands/queues.py:
1704         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1705         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1706
1707 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1708
1709         Reviewed by Mihai Parparita.
1710
1711         new-run-webkit-tests shouldn't crash when you try to run a
1712         directory containing only skipped files.
1713
1714         https://bugs.webkit.org/show_bug.cgi?id=52478
1715         
1716         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1717         * Scripts/webkitpy/layout_tests/port/test.py:
1718         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1719
1720 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1721
1722         Reviewed by Gustavo Noronha Silva.
1723
1724         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1725         https://bugs.webkit.org/show_bug.cgi?id=40833
1726
1727         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1728         GTK+ event sender.
1729         (dragWithFilesDragDataGetCallback): Added.
1730         (dragWithFilesDragEndCallback): Added.
1731         (beginDragWithFilesCallback): Added.
1732
1733 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1734
1735         Reviewed by Adam Barth.
1736
1737         ews: Add additional watcher to efl ews
1738         https://bugs.webkit.org/show_bug.cgi?id=52613
1739
1740         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1741
1742         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1743
1744 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1745
1746         Reviewed by Alexey Proskuryakov.
1747
1748         Fix some headers with missing or misspelled #ifndef guards
1749         https://bugs.webkit.org/show_bug.cgi?id=52545
1750
1751         * DumpRenderTree/chromium/TestEventPrinter.h:
1752         * DumpRenderTree/chromium/WebPreferences.h:
1753
1754 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1755
1756         Reviewed by Anders Carlsson.
1757
1758         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1759         navigating back to an unreachable URL
1760         https://bugs.webkit.org/show_bug.cgi?id=52388
1761
1762         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1763
1764         * DumpRenderTree/LayoutTestController.cpp:
1765         (queueLoadHTMLStringCallback):
1766         (LayoutTestController::queueLoadHTMLString):
1767         (LayoutTestController::queueLoadAlternateHTMLString):
1768         * DumpRenderTree/LayoutTestController.h:
1769
1770         * DumpRenderTree/WorkQueueItem.h:
1771         (LoadHTMLStringItem::LoadHTMLStringItem):
1772
1773         * DumpRenderTree/chromium/LayoutTestController.cpp:
1774         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1775         (WorkItemLoadHTMLString::run):
1776         (LayoutTestController::queueLoadHTMLString):
1777
1778         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1779         (LoadHTMLStringItem::invoke):
1780         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1781         (LoadHTMLStringItem::invoke):
1782         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1783         (LoadHTMLStringItem::invoke):
1784
1785 2011-01-17  Dan Bernstein  <mitz@apple.com>
1786
1787         Rubber-stamped by Mark Rowe.
1788
1789         Update xcodeproj svn:ignore to include xcuserdata.
1790
1791         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1792         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1793         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1794         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1795         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1796
1797 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1798
1799         Unreviewed fix after r75908.
1800
1801         Move WebKit into Source
1802         https://bugs.webkit.org/show_bug.cgi?id=52530
1803
1804         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1805
1806 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1807
1808         Unreviewed.
1809
1810         Remove accidentally committed debug printing after r75908.
1811
1812         * Scripts/webkitdirs.pm:
1813
1814 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1815
1816         Unreviewed.
1817
1818         Add myself to committers list
1819         https://bugs.webkit.org/show_bug.cgi?id=52566
1820
1821         * Scripts/webkitpy/common/config/committers.py:
1822
1823 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1824
1825         Reviewed by Jeremy Orlow.
1826
1827         GeolocationController should call stopUpdating on destruction
1828         https://bugs.webkit.org/show_bug.cgi?id=52216
1829
1830         fast/dom/Geolocation/window-close-crash.html requires that a
1831         Geolocation watch be started in a secondary window. Consequently,
1832         we need to allow geolocation permission and provide a mock
1833         geolocation position for the secondary window's
1834         GeolocationClientMock.
1835
1836         * DumpRenderTree/chromium/LayoutTestController.cpp:
1837         (LayoutTestController::setGeolocationPermission):
1838         (LayoutTestController::setMockGeolocationPosition):
1839         (LayoutTestController::setMockGeolocationError):
1840         * DumpRenderTree/chromium/TestShell.h:
1841         (TestShell::windowList):
1842
1843 2011-01-16  Adam Barth  <abarth@webkit.org>
1844
1845         Update more include paths to reflect WebKit move.
1846
1847         * DumpRenderTree/chromium/EventSender.cpp:
1848         (EventSender::keyDown):
1849         (EventSender::needsShiftModifier):
1850         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1851         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1852
1853 2011-01-16  Kent Tamura  <tkent@chromium.org>
1854
1855         Unreviewed, Chromium build fix.
1856
1857         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1858
1859 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1860
1861         Build fix for GTK+ after source directory movement.
1862
1863         * GNUmakefile.am: Correct include paths.
1864
1865 2011-01-16  Adam Barth  <abarth@webkit.org>
1866
1867         Teach svn-apply about WebKit move.
1868
1869         * Scripts/VCSUtils.pm:
1870
1871 2011-01-16  Adam Barth  <abarth@webkit.org>
1872
1873         Rubber-stamped by Eric Seidel.
1874
1875         Move WebKit into Source
1876         https://bugs.webkit.org/show_bug.cgi?id=52530
1877
1878         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1879         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1880         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1881         * DumpRenderTree/qt/GCControllerQt.cpp:
1882         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1883         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1884         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1885         * DumpRenderTree/wscript:
1886         * QtTestBrowser/launcherwindow.h:
1887         * Scripts/build-webkit:
1888         * Scripts/webkitdirs.pm:
1889
1890 2011-01-15  Adam Barth  <abarth@webkit.org>
1891
1892         Teach svn-apply about WebKit2 move.
1893
1894         * Scripts/VCSUtils.pm:
1895
1896 2011-01-15  Adam Barth  <abarth@webkit.org>
1897
1898         Rubber-stamped by Eric Seidel.
1899
1900         Move WebKit2 into Source
1901         https://bugs.webkit.org/show_bug.cgi?id=52438
1902
1903         * MiniBrowser/qt/MiniBrowser.pro:
1904         * Scripts/build-webkit:
1905         * Scripts/do-file-rename:
1906         * Scripts/do-webcore-rename:
1907         * Scripts/test-webkitpy:
1908         * Scripts/webkitdirs.pm:
1909         * Scripts/webkitpy/style/checker.py:
1910         * WebKitTestRunner/DerivedSources.pro:
1911         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1912         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1913
1914 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1915
1916         Reviewed by David Levin.
1917
1918         [chromium] remove obsolete createView method
1919         https://bugs.webkit.org/show_bug.cgi?id=52437
1920
1921         * DumpRenderTree/chromium/WebViewHost.cpp:
1922         (WebViewHost::createView):
1923         * DumpRenderTree/chromium/WebViewHost.h:
1924
1925 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1926
1927         Reviewed by Geoff Garen.
1928
1929         ShouldLoadResourceForFrame should use strings, not URLs.
1930         https://bugs.webkit.org/show_bug.cgi?id=52476
1931
1932         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1933         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1934         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1935
1936 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1937
1938         Reviewed by David Levin.
1939
1940         Add Tony Gentilcore as a reviewer
1941         https://bugs.webkit.org/show_bug.cgi?id=52480
1942
1943         * Scripts/webkitpy/common/config/committers.py:
1944
1945 2011-01-14  David Levin  <levin@chromium.org>
1946
1947         Reviewed by Eric Seidel.
1948
1949         check-webkit-style: _FunctionState should keep track of where the function name starts.
1950         https://bugs.webkit.org/show_bug.cgi?id=52454
1951
1952         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1953         _FunctionState and logic for setting it correctly.
1954         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1955
1956 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1957
1958         Reviewed by David Levin.
1959
1960         Add support to DumpRenderTree to use the GPU rather than software renderer
1961         https://bugs.webkit.org/show_bug.cgi?id=52333
1962
1963         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1964         (main):
1965         * Scripts/webkitpy/layout_tests/port/chromium.py:
1966         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1967
1968 2011-01-14  Tony Chang  <tony@chromium.org>
1969
1970         Reviewed by Kent Tamura.
1971
1972         [chromium] update fonts.conf to fix 6 linux tests in drt
1973         https://bugs.webkit.org/show_bug.cgi?id=52411
1974
1975         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1976             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1977
1978 2011-01-14  Eric Seidel  <eric@webkit.org>
1979
1980         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1981
1982         Reviewed by Adam Barth.
1983
1984         Fix when running Tools/Scripts/check-webkit-style without arguments.
1985         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1986
1987         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1988         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1989
1990 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1991
1992         Reviewed by David Levin.
1993
1994         Store the tempdir object in a variable so it doesn't get deleted too early.
1995         https://bugs.webkit.org/show_bug.cgi?id=51875
1996
1997         * Scripts/update-webkit-auxiliary-libs:
1998         * Scripts/update-webkit-support-libs:
1999
2000 2011-01-14  Eric Seidel  <eric@webkit.org>
2001
2002         Unreviewed.  Make it work in python 2.5.
2003
2004         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2005         https://bugs.webkit.org/show_bug.cgi?id=49158
2006
2007         * Scripts/webkitpy/common/checkout/api_unittest.py:
2008
2009 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2010
2011         Unreviewed, rolling out r75774.
2012         http://trac.webkit.org/changeset/75774
2013         https://bugs.webkit.org/show_bug.cgi?id=52431
2014
2015         gtk builds were broken (Requested by loislo2 on #webkit).
2016
2017         * Scripts/webkitpy/common/checkout/scm.py:
2018
2019 2011-01-14  David Levin  <levin@chromium.org>
2020
2021         Reviewed by Shinichiro Hamaji.
2022
2023         check-webkit-style: _FunctionState should detect pure functions.
2024         https://bugs.webkit.org/show_bug.cgi?id=52428
2025
2026         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2027         is a pure virtual function.
2028         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2029         virtual functions are correctly detected.
2030
2031 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2032
2033         Reviewed by Yury Semikhatsky.
2034
2035         Just small fix for problem with check-webkit-style.
2036         It just didn't work for this patch.
2037         Old code can't concatenate a list of strings with None.
2038
2039         * Scripts/webkitpy/common/checkout/scm.py:
2040
2041 2011-01-13  David Levin  <levin@chromium.org>
2042
2043         Reviewed by Shinichiro Hamaji.
2044
2045         check-webkit-style: _FunctionState should use Position to know where items are.
2046         https://bugs.webkit.org/show_bug.cgi?id=52424
2047
2048         * Scripts/webkitpy/style/checkers/cpp.py:
2049         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2050         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2051         did some minor clean-up.
2052         (*): Other changes are simply about converting to use the Position's in_FunctionState
2053         instead of line numbers.
2054         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2055         to verify the positions stored in _FunctionState.
2056
2057 2011-01-13  Eric Seidel  <eric@webkit.org>
2058
2059         Reviewed by David Levin.
2060
2061         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2062         https://bugs.webkit.org/show_bug.cgi?id=49158
2063
2064         This is not the most elegant, but it is a very safe fix to this bug.
2065         One advantage of catching ScriptError like this instead of adding a
2066         new added_or_modified_files or fixing all changed_files callers
2067         to use a more specific change_files variant, is that we catch
2068         all kinds of ScriptErrors which might cause our (non-essential)
2069         suggest-reviewers code to fail out.  This should make passing
2070         --suggest-reviewers to webkit-patch upload much more robust
2071         and may even make it possible for us to make it default.
2072
2073         The root of the problem here is that SCM.changed_files includes
2074         deleted ChangeLog paths (from moves, etc) which then when we ask
2075         SVN/Git for the contents of the file at that revision, the command
2076         errors out and Executive.run_command raises a ScriptError.
2077
2078         In the future we might fix this differently by making all current
2079         callers of chagned_files use a more specific method for requesting
2080         what types of changes they're interested in (adds, modifies, deletes, etc.)
2081
2082         * Scripts/webkitpy/common/checkout/api.py:
2083         * Scripts/webkitpy/common/checkout/api_unittest.py:
2084
2085 2011-01-13  Dan Bernstein  <mitz@apple.com>
2086
2087         Reviewed by Alexey Proskuryakov.
2088
2089         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2090         https://bugs.webkit.org/show_bug.cgi?id=52419
2091
2092         Allow to further control the behavior of the willSendRequest delegate callback by making it
2093         set a different URL in the new request.
2094
2095         * DumpRenderTree/LayoutTestController.cpp:
2096         (addURLToRedirectCallback): Added.
2097         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2098         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2099         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2100         * DumpRenderTree/LayoutTestController.h:
2101         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2102         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2103         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2104         change the URL in the new request to the redirect destination.
2105
2106 2011-01-13  Eric Seidel  <eric@webkit.org>
2107
2108         Reviewed by Mihai Parparita.
2109
2110         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2111         https://bugs.webkit.org/show_bug.cgi?id=52416
2112
2113         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2114         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2115
2116         I also added FIXMEs about the changed_files returning deleted files problem
2117         which is causing the other most common exception for suggest-reviewers
2118         (and is probably breaking sheriff-bots blame detection).
2119
2120         * Scripts/webkitpy/common/checkout/api.py:
2121         * Scripts/webkitpy/common/checkout/api_unittest.py:
2122         * Scripts/webkitpy/common/checkout/scm.py:
2123
2124 2011-01-13  Eric Seidel  <eric@webkit.org>
2125
2126         Reviewed by Adam Barth.
2127
2128         results archives from commit-queue are too large to upload
2129         https://bugs.webkit.org/show_bug.cgi?id=52405
2130
2131         * Scripts/webkitpy/common/system/filesystem.py:
2132         * Scripts/webkitpy/common/system/filesystem_mock.py:
2133         * Scripts/webkitpy/tool/commands/queues.py:
2134
2135 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2136
2137         Reviewed by Martin Robinson.
2138
2139         [gtk] Zero-sized font does not yet work
2140         https://bugs.webkit.org/show_bug.cgi?id=49793
2141
2142         Set minimum-font-size to 0 for the DRT.
2143
2144         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2145         (resetDefaultsToConsistentValues):
2146
2147 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2148
2149         Reviewed by Darin Adler.
2150
2151         Make old-run-webkit-tests more robust on buildbots
2152         https://bugs.webkit.org/show_bug.cgi?id=52364
2153
2154         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2155
2156 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2157
2158         Reviewed by Darin Adler.
2159
2160         Make old-run-webkit-tests more robust on buildbots
2161         https://bugs.webkit.org/show_bug.cgi?id=52364
2162
2163         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2164
2165 2011-01-13  Tony Chang  <tony@chromium.org>
2166
2167         Reviewed by Kent Tamura.
2168
2169         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2170         https://bugs.webkit.org/show_bug.cgi?id=52332
2171
2172         Forked Info.plist is not longer needed.
2173
2174         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2175
2176 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2177
2178         Reviewed by Timothy Hatcher.
2179
2180         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2181         to be passed directly to WebInspector.UIString
2182
2183         https://bugs.webkit.org/show_bug.cgi?id=52365
2184
2185         * Scripts/check-inspector-strings:
2186
2187 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2188
2189         Unreviewed, rolling out r74881.
2190         http://trac.webkit.org/changeset/74881
2191         https://bugs.webkit.org/show_bug.cgi?id=52357
2192
2193         The EFL builder has been red for days (Requested by abarth on
2194         #webkit).
2195
2196         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2197         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2198
2199 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2200
2201         Reviewed by David Levin.
2202
2203         Add beforeunload support to WebKitTestRunner
2204         https://bugs.webkit.org/show_bug.cgi?id=52353
2205         
2206         This makes a number of currently failing tests pass.
2207
2208         * WebKitTestRunner/TestController.cpp:
2209         (WTR::runBeforeUnloadConfirmPanel):
2210         (WTR::createOtherPage):
2211         (WTR::TestController::initialize):
2212
2213 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2214
2215         Reviewed by Sam Weinig.
2216
2217         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2218         https://bugs.webkit.org/show_bug.cgi?id=52330
2219
2220         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2221         a web process crash.
2222         * WebKitTestRunner/TestController.cpp:
2223         (WTR::TestController::initialize): Set up a processDidCrash
2224         callback.
2225         (WTR::TestController::processDidCrash): Report that the Web process
2226         crashed.
2227         * WebKitTestRunner/TestController.h:
2228
2229 2011-01-12  David Levin  <levin@chromium.org>
2230
2231         Reviewed by Shinichiro Hamaji.
2232
2233         check-webkit-style -- close_expression function doesn't work correctly.
2234         https://bugs.webkit.org/show_bug.cgi?id=52272
2235
2236         * Scripts/webkitpy/style/checkers/cpp.py:
2237         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2238         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2239         generally useful (for upcoming code changes).
2240         (close_expression): Changed to use Position for input and output.
2241         Also, fixed many bugs such as only working correctly for parenthesis,
2242         not working correctly if given an offset in a line and not finding
2243         the real closing element if there were multiple closing elements in
2244         the same line.
2245         (detect_functions): Adjusted due to the change in arguments for
2246         close_expression.
2247         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2248         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2249         two positions are the same.
2250         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2251         (CppStyleTest.test_close_expression): Added tests to catch the issues
2252         that were fixed.
2253
2254 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2255
2256         Unreviewed, rolling out r75576.
2257         http://trac.webkit.org/changeset/75576
2258         https://bugs.webkit.org/show_bug.cgi?id=52304
2259
2260         broke rebaseline-chromium-webkit-test (Requested by thakis on
2261         #webkit).
2262
2263         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2264         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2265         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2266         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2267         * Scripts/webkitpy/layout_tests/port/base.py:
2268         * Scripts/webkitpy/layout_tests/port/chromium.py:
2269         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2270         * Scripts/webkitpy/layout_tests/port/test.py:
2271         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2272         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2273         * Scripts/webkitpy/style/checkers/test_expectations.py:
2274         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2275
2276 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2277
2278         Reviewed by Darin Adler.
2279
2280         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2281         https://bugs.webkit.org/show_bug.cgi?id=52307
2282
2283         * Scripts/old-run-webkit-tests:
2284
2285 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2286
2287         Reviewed by Martin Robinson.
2288
2289         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2290         https://bugs.webkit.org/show_bug.cgi?id=50867
2291
2292         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2293         TestNetscapePlugin.cpp 
2294
2295         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2296         * Scripts/webkitdirs.pm:
2297
2298 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2299
2300         Reviewed by Pavel Feldman.
2301
2302         Add check-inspector-strings script.
2303
2304         https://bugs.webkit.org/show_bug.cgi?id=52295
2305
2306         * Scripts/check-inspector-strings: Added.
2307
2308 2011-01-12  Adam Roben  <aroben@apple.com>
2309
2310         Advertise the .testnetscape file extension on Windows
2311
2312         Fixes <http://webkit.org/b/52298>
2313         plugins/no-mime-with-valid-extension.html fails on Windows
2314
2315         Reviewed by Dan Bernstein.
2316
2317         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2318         FileExtents field to map the .testnetscape file extension to the
2319         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2320
2321 2011-01-12  Adam Barth  <abarth@webkit.org>
2322
2323         Reviewed by Eric Seidel.
2324
2325         Make webkit-patch support subdirectories for SVN checkouts
2326         https://bugs.webkit.org/show_bug.cgi?id=52261
2327
2328         os.relpath does not exist on Python 2.5, so we need to call our version
2329         of the API.
2330
2331         * Scripts/webkitpy/common/checkout/scm.py:
2332
2333 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2334
2335         Reviewed by Eric Seidel.
2336
2337         Close additional pages opened during a test once the test completes.
2338         https://bugs.webkit.org/show_bug.cgi?id=52276
2339
2340         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2341         (WTR::InjectedBundle::done):
2342
2343 2011-01-11  David Levin  <levin@chromium.org>
2344
2345         Reviewed by Eric Seidel.
2346
2347         Errors should be separated from the command line in bot messages.
2348         https://bugs.webkit.org/show_bug.cgi?id=52275
2349
2350         * Scripts/webkitpy/common/system/executive.py:
2351         (ScriptError.message_with_output): Added a newline to separate the command
2352         line from the errors.
2353         * Scripts/webkitpy/common/system/executive_unittest.py:
2354         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2355         paths in message_with_output.
2356
2357 2011-01-11  Eric Seidel  <eric@webkit.org>
2358
2359         Unreviewed.
2360
2361         commit-queue should know how to upload archived results (for test flakes or general failures)
2362         https://bugs.webkit.org/show_bug.cgi?id=52048
2363
2364         The zips are mostly empty due to forgetting -r.
2365         Expected diffs were not being pulled from the archive due
2366         to the archive having longer paths than I realized.
2367
2368         * Scripts/webkitpy/common/system/workspace.py:
2369         * Scripts/webkitpy/common/system/workspace_unittest.py:
2370         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2371         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2372
2373 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2374
2375         Reviewed by Ojan Vafai.
2376
2377         The current modifier parsing code in test_expectations is
2378         fragile and hard-coded, so it's not easy to understand the logic
2379         or easily add new types of modifiers (like GPU vs. CPU testing
2380         for graphics tests, or 32-bit vs. 64-bit differences).
2381
2382         This is the first of two patches that will add in more generic
2383         support and then eliminate the GPU-specific test expectations
2384         files for Chromium.
2385
2386         This patch adds two standalone objects for handling modifiers. The
2387         rules for interpreting modifiers, precedence, and conflicts are
2388         given in the docstring to the ModifierMatcher class, which
2389         returns ModifierMatchResult objects.
2390         
2391         This patch also adds routines to the Port interface and a
2392         default set of values in the base object, in order to obtain the
2393         values needed on a given test run. These values are then passed
2394         to the expectation parser. This also allows us to clean up the
2395         logic used to lint all of the different configurations in a
2396         single test_expectations.txt file.
2397
2398         The next patch will merge in the separate GPU expectations file.
2399
2400         https://bugs.webkit.org/show_bug.cgi?id=51222
2401
2402         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2403         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2404         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2405         * Scripts/webkitpy/layout_tests/port/base.py:
2406         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2407         * Scripts/webkitpy/layout_tests/port/chromium.py:
2408         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2409         * Scripts/webkitpy/layout_tests/port/test.py:
2410         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2411         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2412
2413 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2414
2415         Reviewed by Adam Barth.
2416
2417         Make webkit-patch support subdirectories for SVN checkouts
2418         https://bugs.webkit.org/show_bug.cgi?id=52261
2419
2420         * Scripts/webkitpy/common/checkout/scm.py:
2421         * Scripts/webkitpy/style_references.py:
2422         * Scripts/webkitpy/tool/main.py:
2423         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2424
2425 2011-01-11  Eric Seidel  <eric@webkit.org>
2426
2427         Unreviewed.
2428
2429         commit-queue should know how to upload archived results (for test flakes or general failures)
2430         https://bugs.webkit.org/show_bug.cgi?id=52048
2431
2432         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2433         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2434
2435         * Scripts/webkitpy/common/system/workspace.py:
2436         * Scripts/webkitpy/common/system/workspace_unittest.py:
2437         * Scripts/webkitpy/tool/commands/queues.py:
2438
2439 2011-01-11  Sam Weinig  <sam@webkit.org>
2440
2441         Roll r75474 back in.
2442
2443 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2444
2445         Reviewed by Kenneth Rohde Christiansen.
2446
2447         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2448         https://bugs.webkit.org/show_bug.cgi?id=51204
2449
2450         * QtTestBrowser/webpage.h:
2451         (QtNAMThread::QtNAMThread):
2452         (QtNAMThread::networkAccessManager):
2453         (QtNAMThread::run):
2454
2455 2011-01-11  Peter Varga  <pvarga@webkit.org>
2456
2457         Unreviewed.
2458
2459         Add myself to committers' list.
2460
2461         * Scripts/webkitpy/common/config/committers.py:
2462
2463 2011-01-11  Eric Seidel  <eric@webkit.org>
2464
2465         Reviewed by Adam Barth.
2466
2467         commit-queue should know how to upload archived results (for test flakes or general failures)
2468         https://bugs.webkit.org/show_bug.cgi?id=52048
2469
2470         Now the queue will always upload results.  Either the entire zip, or just
2471         the diffs.txt in the case of text failures.
2472
2473         This should make understanding flakes much easier, and paves the way
2474         for having the EWS run layout tests (and upload failures).
2475
2476         In order to upload .zip files I had to teach bugzilla.py to autodetect
2477         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2478         for .patch files, I have it add one before calling guess_type.
2479
2480         We may find that always uploading the whole zip instead of just the -diffs.txt
2481         file is preferable, but for now I'm keeping the old behavior because it makes
2482         quickly understanding text failures easy.
2483
2484         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2485         * Scripts/webkitpy/common/system/workspace.py: Added.
2486         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2487         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2488         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2489         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2490         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2491         * Scripts/webkitpy/tool/commands/queues.py:
2492         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2493
2494 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2495
2496         Unreviewed, rolling out r75464.
2497         http://trac.webkit.org/changeset/75464
2498         https://bugs.webkit.org/show_bug.cgi?id=52193
2499
2500         Followup rollout for 75474 (Requested by Ossy on #webkit).
2501
2502         * MiniBrowser/mac/BrowserWindowController.m:
2503         (-[BrowserWindowController awakeFromNib]):
2504         * MiniBrowser/win/BrowserView.cpp:
2505         (BrowserView::create):
2506         * WebKitTestRunner/TestController.cpp:
2507         (WTR::createOtherPage):
2508         (WTR::TestController::initialize):
2509
2510 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2511
2512         Reviewed by Csaba Osztrogonác.
2513
2514         [Qt] Baseline qt_minimal configuration
2515         https://bugs.webkit.org/show_bug.cgi?id=51313
2516
2517         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2518         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2519         QT_NO_UNDOSTACK guard.
2520
2521         * QtTestBrowser/launcherwindow.cpp:
2522         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2523         guards.
2524         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2525         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2526         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2527         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2528
2529         * QtTestBrowser/launcherwindow.h:
2530         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2531         * QtTestBrowser/locationedit.h: Ditto.
2532
2533         * QtTestBrowser/mainwindow.cpp:
2534         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2535         QT_NO_UNDOSTACK guards.
2536         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2537         (MainWindow::changeLocation): Ditto.
2538         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2539         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2540
2541         * QtTestBrowser/webpage.cpp:
2542         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2543         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2544
2545         * QtTestBrowser/webview.cpp:
2546         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2547         (WebViewGraphicsBased::animatedYFlip): Ditto.
2548
2549 2011-01-10  Sam Weinig  <sam@webkit.org>
2550
2551         Fix build.
2552
2553         * MiniBrowser/mac/BrowserWindowController.m:
2554         (-[BrowserWindowController awakeFromNib]):
2555         * MiniBrowser/win/BrowserView.cpp:
2556         (BrowserView::create):
2557         * WebKitTestRunner/TestController.cpp:
2558         (WTR::createOtherPage):
2559         (WTR::TestController::initialize):
2560
2561 2011-01-10  Eric Seidel  <eric@webkit.org>
2562
2563         Reviewed by Ojan Vafai.
2564
2565         style-queue messages are way too long for big patches
2566         https://bugs.webkit.org/show_bug.cgi?id=52161
2567
2568         We definitely could build much fancier list-to-string-with-limit functions
2569         but this should be sufficient for our needs at the moment.
2570
2571         * Scripts/webkitpy/common/system/executive.py:
2572         * Scripts/webkitpy/common/system/executive_unittest.py:
2573
2574 2011-01-10  Tony Chang  <tony@chromium.org>
2575
2576         Unreviewed, rolling out r75398.
2577         http://trac.webkit.org/changeset/75398
2578         https://bugs.webkit.org/show_bug.cgi?id=52008
2579
2580         Some layout tests are crashing on Chromium Win.
2581
2582         * DumpRenderTree/chromium/WebViewHost.cpp:
2583         (WebViewHost::updatePaintRect):
2584         * DumpRenderTree/chromium/WebViewHost.h:
2585
2586 2011-01-10  Adam Roben  <aroben@apple.com>
2587
2588         Roll out r75392
2589
2590         It isn't needed now that r75289 has been rolled out.
2591
2592         * Scripts/run-javascriptcore-tests:
2593
2594 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2595
2596         Reviewed by Anders Carlsson.
2597
2598         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2599         https://bugs.webkit.org/show_bug.cgi?id=52160
2600
2601         * WebKitTestRunner/mac/TestControllerMac.mm:
2602         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2603         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2604         anyway.
2605
2606 2011-01-10  Tony Chang  <tony@chromium.org>
2607
2608         Reviewed by Mihai Parparita.
2609
2610         [chromium] fix for animated gif layout tests
2611         https://bugs.webkit.org/show_bug.cgi?id=52008
2612
2613         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2614             to trigger gif animations.
2615         (WebViewHostPaintTask::WebViewHostPaintTask):
2616         (WebViewHostPaintTask::runIfValid):
2617         (WebViewHost::updatePaintRect):
2618         * DumpRenderTree/chromium/WebViewHost.h:
2619         (WebViewHost::taskList):
2620
2621 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2622
2623         Reviewed by Xan Lopez.
2624
2625         [GTK] Fix gtk2 compilation for master
2626         https://bugs.webkit.org/show_bug.cgi?id=51885
2627
2628         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2629         (createBitmapContextFromWebView): Replaced the old
2630         gdk_drawable_get_size with gdk_pixmap_get_size.
2631
2632 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2633
2634         Reviewed by Laszlo Gombos.
2635
2636         [WINCE] Reenable NPAPI after r75203
2637         https://bugs.webkit.org/show_bug.cgi?id=52109
2638
2639         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2640         it with !isEfl(), because EFL port does not support NPAPI (yet).
2641
2642         * Scripts/build-webkit:
2643
2644 2011-01-10  Adam Roben  <aroben@apple.com>
2645
2646         Skip some asserting JS tests
2647
2648         See <http://webkit.org/b/52156>.
2649
2650         * Scripts/run-javascriptcore-tests:
2651
2652 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2653
2654         Reviewed by Xan Lopez.
2655
2656         [GTK] build-webkit disable Blob support via arguments passed to automake
2657         https://bugs.webkit.org/show_bug.cgi?id=52097
2658
2659         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2660         build-webkit.
2661
2662 2011-01-10  Adam Roben  <aroben@apple.com>
2663
2664         Use the same name and description for TestNetscapePlugin on Windows and
2665         Mac
2666
2667         Fixes <http://webkit.org/b/52151>
2668         fast/frames/iframe-reparenting-plugins.html fails on Windows
2669
2670         Reviewed by Steve Falkenburg.
2671
2672         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2673         the name and description from Mac's Info.plist.
2674
2675 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2676
2677         Reviewed by Laszlo Gombos.
2678
2679         [Qt][WK2] Guard gcc-specific syntax
2680
2681         Non-gcc based compliers choke on the "-include"
2682         syntax for preinclude, place guard around it.
2683
2684         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2685         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2686
2687 2011-01-10  Andreas Kling  <kling@webkit.org>
2688
2689         Reviewed by Simon Hausmann.
2690
2691         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2692         https://bugs.webkit.org/show_bug.cgi?id=52111
2693
2694         When getting a createNewPage() callback from QWKPage, create the
2695         new page with the same QWKContext as the page that is passed to
2696         the callback.
2697
2698         * MiniBrowser/qt/BrowserView.h:
2699         * MiniBrowser/qt/BrowserWindow.cpp:
2700         (newPageFunction):
2701         (BrowserWindow::BrowserWindow):
2702         * MiniBrowser/qt/BrowserWindow.h:
2703
2704 2011-01-10  Andreas Kling  <kling@webkit.org>
2705
2706         Reviewed by Kenneth Rohde Christiansen.
2707
2708         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2709
2710         BrowserView set its own useless createNewPage() callback on QWKPage.
2711         This was immediately overridden by BrowserWindow anyway, so remove
2712         the BrowserView one.
2713
2714         * MiniBrowser/qt/BrowserView.cpp:
2715         (BrowserView::BrowserView):
2716
2717 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2718
2719         Reviewed by Jeremy Orlow.
2720
2721         [Chromium] Remove non-client-based Geolocation code
2722         https://bugs.webkit.org/show_bug.cgi?id=50921
2723
2724         * DumpRenderTree/chromium/LayoutTestController.cpp:
2725         (LayoutTestController::setGeolocationPermission):
2726         (LayoutTestController::setMockGeolocationPosition):
2727         (LayoutTestController::setMockGeolocationError):
2728         * DumpRenderTree/chromium/WebViewHost.cpp:
2729         (WebViewHost::geolocationClientMock):
2730         (WebViewHost::reset):
2731         * DumpRenderTree/chromium/WebViewHost.h:
2732
2733 2011-01-10  Eric Seidel  <eric@webkit.org>
2734
2735         Reviewed by Adam Barth.
2736
2737         Commit bot tried to land r? cq+ patch
2738         https://bugs.webkit.org/show_bug.cgi?id=36638
2739
2740         It should now be possible to post a patch with r? and cq+ and the
2741         commit-queue will correctly wait for the r+ before attempting to land the patch.
2742         (This was a feature requested by several users.)
2743
2744         One caveat: We don't actually reject r-, cq+ patches from the queue
2745         (we just ignore them), but I think that's OK for now.
2746
2747         I also noticed that setting r- once a commit-queue node had grabbed
2748         a patch would not properly cancel the landing.  That's fixed and
2749         tested in this patch.
2750
2751         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2752         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2753         * Scripts/webkitpy/tool/bot/feeders.py:
2754         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2755
2756 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2757
2758         Reviewed by Kenneth Rohde Christiansen.
2759
2760         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2761         https://bugs.webkit.org/show_bug.cgi?id=51934
2762
2763         When accessing the network from the destructor of QWebPage, the network access manager
2764         was already deleted because the object WebPage was already destructed.
2765
2766         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2767         The object is now destructed in the destructor of QObject.
2768
2769         * QtTestBrowser/webpage.cpp:
2770         (WebPage::WebPage):
2771         (WebPage::setQnamThreaded):
2772         * QtTestBrowser/webpage.h:
2773         (QtNAMThread::QtNAMThread):
2774
2775 2011-01-08  Eric Seidel  <eric@webkit.org>
2776
2777         Reviewed by Ojan Vafai.
2778
2779         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2780         https://bugs.webkit.org/show_bug.cgi?id=52067
2781
2782         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2783         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2784
2785         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2786
2787 2011-01-08  Eric Seidel  <eric@webkit.org>
2788
2789         Reviewed by Mihai Parparita.
2790
2791         commit-queue hangs when the ChangeLog diff is bad
2792         https://bugs.webkit.org/show_bug.cgi?id=52072
2793
2794         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2795         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2796
2797 2011-01-08  Adam Barth  <abarth@webkit.org>
2798
2799         Teach svn-apply how to re-write WebCore to Source/WebCore.
2800
2801         * Scripts/VCSUtils.pm:
2802
2803 2011-01-07  Adam Barth  <abarth@webkit.org>
2804
2805         Rubber-stamped by Eric Seidel.
2806
2807         Move WebCore to Source
2808         https://bugs.webkit.org/show_bug.cgi?id=52050
2809
2810         Update the tools to understand WebCore's new location.
2811
2812         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2813         * DumpRenderTree/wscript:
2814         * GNUmakefile.am:
2815         * Scripts/build-webkit:
2816         * Scripts/do-file-rename:
2817         * Scripts/do-webcore-rename:
2818         * Scripts/generate-qt-inspector-resource:
2819         * Scripts/prepare-ChangeLog:
2820         * Scripts/run-bindings-tests:
2821         * Scripts/update-iexploder-cssproperties:
2822         * Scripts/update-sources-list.py:
2823         * Scripts/update-webkit-localizable-strings:
2824         * Scripts/webkitdirs.pm:
2825         * Scripts/webkitpy/common/config/build.py:
2826         * Scripts/webkitpy/common/config/build_unittest.py:
2827         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2828         * Scripts/webkitpy/style/checker.py:
2829         * Scripts/webkitpy/style/checker_unittest.py:
2830         * WebKitTestRunner/DerivedSources.pro:
2831         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2832         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2833         * wx/browser/wscript:
2834         * wx/build/settings.py:
2835
2836 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2837
2838         Reviewed by Sam Weinig.
2839
2840         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2841         https://bugs.webkit.org/show_bug.cgi?id=52086
2842
2843         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2844         (WTR::InjectedBundle::didReceiveMessage):
2845         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2846         (WTR::LayoutTestController::notifyDone):
2847         * WebKitTestRunner/TestController.cpp:
2848         (WTR::TestController::resetStateToConsistentValues):
2849         (WTR::TestController::run):
2850
2851 2011-01-07  James Robinson  <jamesr@chromium.org>
2852
2853         Revert "Implement mozilla's animationTime property"
2854         https://bugs.webkit.org/show_bug.cgi?id=51952
2855
2856         This approach isn't quite right.
2857
2858         * DumpRenderTree/chromium/WebViewHost.cpp:
2859         (WebViewHost::paintInvalidatedRegion):
2860
2861 2011-01-07  Adam Roben  <aroben@apple.com>
2862
2863         Build master fix
2864
2865         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2866         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2867
2868 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2869
2870         Reviewed by Csaba Osztrogonác.
2871
2872         run-qtwebkit-tests should be able to kill a testsuite.
2873
2874         Add new option in the script that can setup a timeout for a test.
2875         If the test execution takes more then specified time then the test
2876         would be terminated.
2877
2878         [Qt] run-qtwebkit-tests needs timeout
2879         https://bugs.webkit.org/show_bug.cgi?id=51894
2880
2881         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2882         * Scripts/run-qtwebkit-tests:
2883
2884 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2885
2886         Unreviewed fix after r75233.
2887
2888         Based on idea from Eric Seidel.
2889
2890         Add remote zip file handling to webkitpy.
2891         https://bugs.webkit.org/show_bug.cgi?id=50901
2892
2893         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2894
2895 2011-01-07  Shane Stephens  <shanestephens@google.com>
2896
2897         Reviewed by Eric Seidel.
2898
2899         svn-apply: should support git binary delta diffs
2900         https://bugs.webkit.org/show_bug.cgi?id=38864
2901
2902         * Scripts/VCSUtils.pm:
2903         * Scripts/svn-apply:
2904
2905 2011-01-06  Julie Parent  <jparent@chromium.org>
2906
2907         Reviewed by Eric Seidel.
2908
2909         Test Result Server not removing old results.
2910         https://bugs.webkit.org/show_bug.cgi?id=52012
2911
2912         * TestResultServer/model/jsonresults.py:
2913         Fix off-by-one: Truncate if >= num_runs, not just >.
2914         * TestResultServer/model/jsonresults_unittest.py:
2915         Add unit test to test that merging in a new result with the same value
2916         as the last result causes previous result to fall off.
2917
2918 2011-01-06  James Kozianski  <koz@chromium.org>
2919
2920         Reviewed by Mihai Parparita.
2921
2922         Add classes to provide a consistent interface to a set of files.
2923         https://bugs.webkit.org/show_bug.cgi?id=50901
2924
2925         These classes allow us to write code that is agnostic to whether a
2926         particular set of files resides in a local directory or in a zip file
2927         on a remote machine.
2928
2929         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2930         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2931         * Scripts/webkitpy/common/system/fileset.py: Added.
2932         * Scripts/webkitpy/common/system/filesystem.py:
2933         * Scripts/webkitpy/common/system/filesystem_mock.py:
2934         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2935         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2936
2937 2011-01-06  Eric Seidel  <eric@webkit.org>
2938
2939         Reviewed by Adam Barth.
2940
2941         NetworkTransaction should log the url it is retrying
2942         https://bugs.webkit.org/show_bug.cgi?id=52043
2943
2944         * Scripts/webkitpy/common/net/networktransaction.py:
2945         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2946
2947 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2948
2949         Windows build fix.
2950         Import os before using it.
2951
2952         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2953
2954 2011-01-06  Eric Seidel  <eric@webkit.org>
2955
2956         Reviewed by Adam Barth.
2957
2958         StyleQueue fails to report errors when patches have many files
2959         https://bugs.webkit.org/show_bug.cgi?id=52042
2960
2961         This is one of at least two errors preventing style error reporting at the moment.
2962         When we moved to passing the list of files to check explicitly,
2963         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2964         We could change the type of the QueueStatus.message type, or we could
2965         just teach statusserver.py how to clamp values (and warn when it does).
2966         I chose the latter path.
2967
2968         * Scripts/webkitpy/common/net/statusserver.py:
2969
2970 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2971
2972         Reviewed by Stephanie Lewis.
2973         
2974         Fix syntax error in script.
2975
2976         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2977         https://bugs.webkit.org/show_bug.cgi?id=51996
2978
2979         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2980
2981 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2982
2983         Unreviewed, fixing WinCE build after r75196.
2984
2985         WinCE port does not (yet) support NPAPI.
2986
2987         * Scripts/build-webkit:
2988
2989 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2990
2991         Reviewed by Darin Adler.
2992
2993         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2994         https://bugs.webkit.org/show_bug.cgi?id=52015
2995
2996         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2997         after the platform has been detected, otherwise the script will
2998         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2999         detection.
3000
3001 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3002
3003         Reviewed by Eric Seidel.
3004
3005         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3006         https://bugs.webkit.org/show_bug.cgi?id=51346
3007
3008         * Scripts/build-webkit:
3009
3010 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3011
3012         Reviewed by Adam Roben.
3013
3014         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3015         https://bugs.webkit.org/show_bug.cgi?id=51996
3016         
3017         After the configuration directory change, we were archiving the incorrect directory for
3018         build product, so we were running tests on the wrong binaries.
3019         
3020         This change archives the correct directory, and also unarchives it into a configuration-
3021         specific directory.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3024         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3025
3026 2011-01-06  Eric Seidel  <eric@webkit.org>
3027
3028         Reviewed by Mihai Parparita.
3029
3030         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3031         https://bugs.webkit.org/show_bug.cgi?id=52002
3032
3033         See an example of this here:
3034         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3035
3036         It's due to the fact that we pass around TestFailure() instance
3037         objects and yet expect them to all compare to be the same.
3038
3039         This is bad.  We should either have shared instances of these values
3040         or we should just pass around the class names.  There are already hacks
3041         in place to make TestFailure objects pass equality tests, I just added
3042         a __hash__ implementation so they can be used in sets as expected.
3043
3044         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3045         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3046
3047 2011-01-06  Evan Martin  <evan@chromium.org>
3048
3049         Reviewed by Tony Chang.
3050
3051         [gdb] handle inaccessible memory and UChar*
3052         https://bugs.webkit.org/show_bug.cgi?id=52003
3053
3054         To pretty-print a UChar*, we just grope around in the memory
3055         looking for a terminating NUL.  We need to handle the exception
3056         that can occur when we poke into an invalid location.
3057
3058         Additionally, the logic for choosing which pretty-printer would
3059         early return before hitting the point where we'd use the UChar*
3060         printer.  (Did this ever work?  How did it regress?)
3061
3062         * gdb/webkit.py:
3063
3064 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3065
3066         Reviewed by Ada Chan.
3067
3068         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3069         https://bugs.webkit.org/show_bug.cgi?id=51969
3070         
3071         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3072
3073         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3074         (WTR::InjectedBundlePage::InjectedBundlePage):
3075         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3076         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3077
3078 2011-01-06  James Robinson  <jamesr@chromium.org>
3079
3080         Reviewed by Simon Fraser.
3081
3082         Implement mozilla's animationTime property
3083         https://bugs.webkit.org/show_bug.cgi?id=51952
3084
3085         Chromium DRT support for webkitAnimationTime.
3086
3087         * DumpRenderTree/chromium/WebViewHost.cpp:
3088         (WebViewHost::paintInvalidatedRegion):
3089
3090 2011-01-06  Julie Parent  <jparent@chromium.org>
3091
3092         Reviewed by Tony Chang.
3093
3094         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3095         https://bugs.webkit.org/show_bug.cgi?id=51217
3096
3097         * TestResultServer/model/jsonresults.py:
3098         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3099         Adds missing documentation.
3100         * TestResultServer/model/jsonresults_unittest.py:
3101         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3102         Update test_merge to take a number of builds to truncate at.
3103
3104 2011-01-06  Adam Barth  <abarth@webkit.org>
3105
3106         Reviewed by Eric Seidel.
3107
3108         The EWS should log outside of the working directory
3109         https://bugs.webkit.org/show_bug.cgi?id=51986
3110
3111         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3112         script, which will actually clean the working copy back to a pristine
3113         state instead of leaving untracked directories and ignored files.
3114
3115         * Scripts/webkitpy/tool/commands/queues.py:
3116         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3117
3118 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3119
3120         Windows build fix.
3121         Back out attempted change to built-product-archive.
3122
3123         * BuildSlaveSupport/built-product-archive:
3124
3125 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3126
3127         Windows build fix.
3128         Include configuration name when unpacking a build archive.
3129
3130         Needed, since we split Windows build results into configuration-specific directories
3131         under WebKitOutputDir.
3132
3133         * BuildSlaveSupport/built-product-archive:
3134
3135 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3136
3137         Reviewed by Darin Adler.
3138
3139         Debug and Release builds on Windows clobber each other
3140         https://bugs.webkit.org/show_bug.cgi?id=49185
3141
3142         Changes the structure of WebKitBuild build products directory so we
3143         completely separate each build configuration into independent directories.
3144         
3145         Although we previously had per-configuration directories for obj, this change adds
3146         per-configuration directories for bin, lib, obj, and include. Each configuration's
3147         build products are stored within a directory inside of WebKitBuild.
3148         
3149         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3150         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3151
3152         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3153         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3154         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3155         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3156         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3157         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3158         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3159         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3160         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3161         * FindSafari/FindSafari.vcproj:
3162         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3163         * MiniBrowser/MiniBrowserPostBuild.cmd:
3164         * MiniBrowser/MiniBrowserPreBuild.cmd:
3165         * Scripts/webkitdirs.pm:
3166         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3167         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3168         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3169         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3170         * TestWebKitAPI/win/copy-resources.cmd:
3171         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3172         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3173         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3174         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3175         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3176         * WebKitTestRunner/win/InjectedBundle.vcproj:
3177         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3178         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3179         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3180         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3181         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3182         * WinLauncher/WinLauncherCommon.vsprops:
3183         * WinLauncher/WinLauncherPostBuild.cmd:
3184         * WinLauncher/WinLauncherPreBuild.cmd:
3185
3186 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3187
3188         Reviewed by Ariya Hidayat.
3189
3190         [Qt] TestNetscapePlugin doesn't link on OS X
3191         https://bugs.webkit.org/show_bug.cgi?id=51948
3192
3193         Only add a dependency on libX11 on X11 systems
3194
3195         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3196
3197 2011-01-05  Jeff Miller  <jeffm@apple.com>
3198
3199         Reviewed by Adam Roben.
3200
3201         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3202         https://bugs.webkit.org/show_bug.cgi?id=51970
3203
3204         * Scripts/webkitpy/style/checker.py:
3205         Add -readability/naming for WebKit2 C API directories.
3206
3207 2011-01-05  Eric Seidel  <eric@webkit.org>
3208
3209         Unreviewed, just fixing one more log error from my previous python patch.
3210
3211         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3212         https://bugs.webkit.org/show_bug.cgi?id=51802
3213
3214         webkit-patch failure-reason was logging about parsing errors
3215         due to my misunderstanding of how BeautifulSoup.findAll worked.
3216
3217         Fixed, and added a unit test.
3218
3219         * Scripts/webkitpy/common/net/layouttestresults.py:
3220         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3221
3222 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3223
3224         Reviewed by Kenneth Rohde Christiansen.
3225
3226         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3227         https://bugs.webkit.org/show_bug.cgi?id=51951
3228
3229         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3230         to create new window from WebKit.
3231
3232         * MiniBrowser/qt/BrowserWindow.cpp:
3233         (newPageFunction):
3234         (BrowserWindow::BrowserWindow):
3235         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3236         (BrowserWindow::newWindow):
3237         (BrowserWindow::updateUserAgentList):
3238         (BrowserWindow::showUserAgentDialog):
3239         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3240         define the type of the backing store used for new windows.
3241         * MiniBrowser/qt/main.cpp:
3242         (main):
3243
3244 2011-01-05  Eric Seidel  <eric@webkit.org>
3245
3246         Reviewed by Ojan Vafai.
3247
3248         commit-queue should report failure type when reporting flaky tests
3249         https://bugs.webkit.org/show_bug.cgi?id=51900
3250
3251         This patch was a ridiculous amount of plumbing.  In the end I like
3252         the NRWT-style TestResult class even less.  But now we're passing
3253         a list of TestResult objects from the queue to the FlakyTestReporter.
3254         Thus the FlakyTestReporter can more easily report what type of failure
3255         occurred.
3256
3257         In the process, I found that I was not alone in finding TestResult
3258         cumbersome to use.  A bunch of code was trying to create a TestResult
3259         object with default values.  However since the constructor didn't make
3260         this easy, some places were getting it wrong (including the TestResult unit test)!
3261         I've fixed the TestResult constructor to have default values for non-essential
3262         arguments.
3263
3264         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3265         * Scripts/webkitpy/common/net/layouttestresults.py:
3266         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3267         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3268         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3269         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3270         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3271         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3272         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3273         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3274         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3275         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3276         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3277         * Scripts/webkitpy/tool/commands/queues.py:
3278         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3279
3280 2011-01-05  Eric Seidel  <eric@webkit.org>
3281
3282         Unreviewed.
3283
3284         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3285         https://bugs.webkit.org/show_bug.cgi?id=51802
3286
3287         Add another unit test to cover a previously missing import.
3288
3289         * Scripts/webkitpy/common/net/layouttestresults.py:
3290         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3291
3292 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3293
3294         Reviewed by David Levin.
3295
3296         Add mihaip@chromium.org as a reviewer
3297         https://bugs.webkit.org/show_bug.cgi?id=51966
3298         
3299         Add myself as a reviewer.
3300
3301         * Scripts/webkitpy/common/config/committers.py:
3302
3303 2011-01-05  James Simonsen  <simonjam@chromium.org>
3304
3305         Unreviewed. Adding myself to the list of committers.
3306
3307         * Scripts/webkitpy/common/config/committers.py:
3308
3309 2011-01-05  Eric Seidel  <eric@webkit.org>
3310
3311         Unreviewed.
3312
3313         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3314         https://bugs.webkit.org/show_bug.cgi?id=51802
3315
3316         Fix two exceptions seen on the bots after my original commit.
3317
3318         * Scripts/webkitpy/common/net/layouttestresults.py:
3319         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3320
3321 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3322
3323         Reviewed by Andreas Kling.
3324
3325         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3326         https://bugs.webkit.org/show_bug.cgi?id=51750
3327
3328         * QtTestBrowser/main.cpp:
3329         (LauncherApplication::handleUserOptions):
3330          Local storage settings can be enable form command line arguments for
3331          QtTestBrowser.
3332
3333 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3334
3335         Reviewed by Martin Robinson.
3336
3337         GTK: AX: DRT needs to use correct root object method.
3338         https://bugs.webkit.org/show_bug.cgi?id=51911
3339
3340         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3341         (AccessibilityController::rootElement):
3342
3343 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3344
3345         Rubber-stamped by Csaba Osztrogonác.
3346
3347         Based on idea from Péter Gál.
3348
3349         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3350
3351 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3352
3353         Reviewed by Adam Barth.
3354
3355         sheriff-bot should be able to do multi-revision rollouts
3356         https://bugs.webkit.org/show_bug.cgi?id=51176
3357
3358         * Scripts/webkitpy/tool/bot/irc_command.py:
3359         * Scripts/webkitpy/tool/bot/sheriff.py:
3360         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3361
3362 2011-01-05  Eric Seidel  <eric@webkit.org>
3363
3364         Reviewed by Adam Barth.
3365
3366         queues.webkit.org should have per-bot status pages
3367         https://bugs.webkit.org/show_bug.cgi?id=51906
3368
3369         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3370         statuses from a single queue.  Now that we have many bots servicing
3371         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3372         you care about scroll off the end of the 15-message limit on the main page.
3373
3374         Eventually we should probably rename /queue-status to /queue or /queues,
3375         but that's fodder for another patch.
3376
3377         * QueueStatusServer/handlers/queuestatus.py:
3378         * QueueStatusServer/index.yaml:
3379         * QueueStatusServer/main.py:
3380         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3381          - This probably should use a custom filter instead of hard-coding
3382            the URL scheme here, but I couldn't figure out how to easily
3383            create such a filter.  Most filters work with "strings" so we can't
3384            pass the status object.  We could add a method to the status
3385            object and call that, but that seemed a bit strange too.
3386         * QueueStatusServer/templates/queuestatus.html:
3387
3388 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3389
3390         Unreviewed. Adding myself to the list of committers.
3391
3392         * Scripts/webkitpy/common/config/committers.py:
3393
3394 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3395
3396         Reviewed by David Levin.
3397
3398         check-webkit-style treated some macros with parentheses after #elif as function calls
3399         https://bugs.webkit.org/show_bug.cgi?id=51695
3400
3401         Ingore function call space checking in any preprocessor directives
3402         (things starting with #). Change search() to match() because 
3403         preprocessor directives are supposed to be in the beginning of lines.
3404
3405         * Scripts/webkitpy/style/checkers/cpp.py:
3406         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3407
3408 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3409
3410         Reviewed by Tony Chang.
3411
3412         Change the --multi-load test option to --stress-opt
3413         https://bugs.webkit.org/show_bug.cgi?id=50751
3414
3415         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3416         (runTest):
3417         (main):
3418         * DumpRenderTree/chromium/TestShell.cpp:
3419         (TestShell::TestShell):
3420         * DumpRenderTree/chromium/TestShell.h:
3421         (TestShell::stressOpt):
3422         (TestShell::setStressOpt):
3423         (TestShell::stressDeopt):
3424         (TestShell::setStressDeopt):
3425         (TestShell::javaScriptFlags):
3426         (TestShell::setJavaScriptFlags):
3427         * Scripts/webkitpy/layout_tests/port/chromium.py:
3428         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3429
3430 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3431
3432         Reviewed by Sam Weinig.
3433
3434         WK2: Support Accessibility
3435         https://bugs.webkit.org/show_bug.cgi?id=51859
3436
3437         Use rootObject() method to get top of accessibility tree.
3438
3439         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3440         (AccessibilityController::focusedElement):
3441         (AccessibilityController::rootElement):
3442
3443 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3444
3445         Reviewed by Darin Adler.
3446
3447         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3448         https://bugs.webkit.org/show_bug.cgi?id=51846
3449
3450         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3451         back to GRefPtr.
3452
3453 2011-01-04  Zhe Su  <suzhe@chromium.org>
3454
3455         Reviewed by Kenneth Russell.
3456
3457         Fix insertText, setMarkedText and unmarkText methods of
3458         TextInputController to call corresponding methods of WebKit::WebView
3459         rather than WebKit::WebFrame. This change matches the behavior of
3460         chromium browser.
3461         insertText corresponds to WebView::confirmComposition(text)
3462         setMarkedText corresponds to WebView::setComposition(...)
3463         unmarkText corresponds to WebView::confirmComposition()
3464         https://bugs.webkit.org/show_bug.cgi?id=51693
3465
3466         * DumpRenderTree/chromium/TextInputController.cpp:
3467         (TextInputController::insertText):
3468         (TextInputController::setMarkedText):
3469         (TextInputController::unmarkText):
3470
3471 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3472
3473         Reviewed by Laszlo Gombos.
3474
3475         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3476
3477         On Symbian productDir points to the source directory. Removing all the
3478         empty files from the productDir directory corrupts the svn repository.
3479
3480         * Scripts/build-webkit:
3481
3482 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3483
3484         Reviewed by Adam Barth.
3485
3486         [Qt] Add SelectAll option to the context menu for the editor
3487         https://bugs.webkit.org/show_bug.cgi?id=50049
3488
3489         Set shortcut for the SelectAll action.
3490
3491         * QtTestBrowser/mainwindow.cpp:
3492         (MainWindow::buildUI):
3493
3494 2011-01-03  David Levin  <levin@chromium.org>
3495
3496         Reviewed by Eric Seidel.
3497
3498         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3499         https://bugs.webkit.org/show_bug.cgi?id=51842
3500
3501         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3502         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3503
3504 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3505
3506         Reviewed by David Kilzer.
3507
3508         [WINCE] Adds a build slave.
3509         https://bugs.webkit.org/show_bug.cgi?id=50523
3510
3511         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3512         entry for a release build of the WinCE port.
3513         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3514         flag to build the WinCE port.
3515
3516 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3517
3518         Reviewed by David Kilzer.
3519
3520         Add WinCE support to build-webkit
3521         https://bugs.webkit.org/show_bug.cgi?id=51642
3522
3523         * Scripts/build-webkit:
3524         * Scripts/webkitdirs.pm:
3525
3526 2011-01-03  Eric Seidel  <eric@webkit.org>
3527
3528         Reviewed by Adam Barth.
3529
3530         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3531         https://bugs.webkit.org/show_bug.cgi?id=51802
3532
3533         I'm not the biggest fan of the test_failures or test_results classes,
3534         but it's better to have one shared set of classes, than separate ones
3535         for new vs. old run-webkit-test result handling.
3536
3537         This moves the ORWT results class "LayoutTestResults" over to using
3538         TestResult and TestFailure classes, making it easy for us to
3539         make all our sheriff-bot and other webkitpy code NRWT ready.
3540
3541         This also makes it a trivial patch to generate results.json information
3542         from ORWT results.html files (for flaky test analysis, etc.) as well
3543         as making it a one-liner to report test failure types when the
3544         commit-queue sees flaky tests.
3545
3546         This patch tried not to add new functionality, but only to replace
3547         the guts of LayoutTestResults, while adding unit tests and hoping
3548         not to break anything.
3549
3550         I also moved callers which assumed User.prompt* were static/class methods
3551         to using them as instance methods (since we'll eventually want to make them such).
3552
3553         In the process of re-writing things, I broke the rebaseline command, so I wrote
3554         a unit test to catch my breakage were I do do so again in the future.
3555
3556         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3557         * Scripts/webkitpy/common/net/layouttestresults.py:
3558         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3559         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3560         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3561         * Scripts/webkitpy/tool/commands/queries.py:
3562         * Scripts/webkitpy/tool/commands/rebaseline.py:
3563         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3564         * Scripts/webkitpy/tool/mocktool.py:
3565
3566 2011-01-03  Adam Barth  <abarth@webkit.org>
3567
3568         Reviewed by Simon Fraser.
3569
3570         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3571         https://bugs.webkit.org/show_bug.cgi?id=51840
3572
3573         * Scripts/webkitpy/common/checkout/scm.py:
3574
3575 2011-01-03  Adam Barth  <abarth@webkit.org>
3576
3577         Reviewed by Simon Fraser.
3578
3579         webkit-patch should only hide update output if --quiet
3580         https://bugs.webkit.org/show_bug.cgi?id=51838
3581
3582         As requested by smfr.
3583
3584         * Scripts/webkitpy/tool/steps/update.py:
3585
3586 2011-01-03  Adam Barth  <abarth@webkit.org>
3587
3588         Reviewed by David Levin.
3589
3590         commit-queue shouldn't reject patches twice if two bots process the same patch
3591         https://bugs.webkit.org/show_bug.cgi?id=51805
3592
3593         Before raising an error, we first check whether the patch is still in
3594         the commit-queue.  This check is still racy, of course, but the time
3595         window is much smaller.
3596
3597         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3598
3599 2011-01-03  Sam Weinig  <sam@webkit.org>
3600
3601         Reviewed by Anders Carlsson.
3602
3603         Make run-api-tests less chatty.
3604         https://bugs.webkit.org/show_bug.cgi?id=51831
3605
3606         - Make script quiet by default and add --verbose option (replacing --quiet).
3607         - When not verbose, pipe stdout and stderr to devnull.
3608
3609         * Scripts/run-api-tests:
3610
3611 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3612
3613         Unreviewed. Adding myself to committers.py.
3614
3615         * Scripts/webkitpy/common/config/committers.py:
3616
3617 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3618
3619         Reviewed by Xan Lopez.
3620
3621         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3622         https://bugs.webkit.org/show_bug.cgi?id=51806
3623
3624         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3625         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3626         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3627         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3628         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3629         so make it 'WebKitBuild/Release/.libs'
3630
3631         * Scripts/webkitdirs.pm: 
3632
3633 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3634
3635         Reviewed by Adam Barth.
3636
3637         Make EFL a core builder
3638         https://bugs.webkit.org/show_bug.cgi?id=51804
3639
3640         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3641         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3642
3643 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3644
3645         [Qt] Unreviewed fix after r74855 and r74875.
3646
3647         * BuildSlaveSupport/built-product-archive:
3648          - Create directories explicitly.
3649          - Pass shell=True to subprocess.call().
3650
3651 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3652
3653         [Qt] Unreviewed fix after r74855.
3654
3655         Move JavaScriptCore to Source
3656         https://bugs.webkit.org/show_bug.cgi?id=51604
3657
3658         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3659
3660 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3661
3662         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3663
3664         Move JavaScriptCore to Source
3665         https://bugs.webkit.org/show_bug.cgi?id=51604
3666
3667         * Scripts/webkitdirs.pm:
3668
3669 2011-01-02  Robert Hogan  <robert@webkit.org>
3670
3671         Unreviewed, build fix.
3672
3673         [Qt] Fix DRT build after 74855
3674
3675         * DumpRenderTree/qt/DumpRenderTree.pro:
3676
3677 2011-01-01  Adam Barth  <abarth@webkit.org>
3678
3679         Remove the assumption from the Qt and Gtk builds that every project is
3680         in the root directory.
3681
3682         * Scripts/build-webkit:
3683
3684 2011-01-01  Adam Barth  <abarth@webkit.org>
3685
3686         Reviewed by Eric Seidel.
3687
3688         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3689         https://bugs.webkit.org/show_bug.cgi?id=51796
3690
3691         After this change, svn-apply will magically apply patches to
3692         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3693
3694         * Scripts/VCSUtils.pm:
3695
3696 2011-01-01  Adam Barth  <abarth@webkit.org>
3697
3698         Reviewed by Eric Seidel.
3699
3700         Move JavaScriptCore to Source
3701         https://bugs.webkit.org/show_bug.cgi?id=51604
3702
3703         Update references to JavaScriptCore to point to the new location.
3704
3705         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3706         * DumpRenderTree/qt/DumpRenderTree.pro:
3707         * DumpRenderTree/qt/ImageDiff.pro:
3708         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3709         * DumpRenderTree/wscript:
3710         * Scripts/build-jsc:
3711         * Scripts/build-webkit:
3712         * Scripts/do-file-rename:
3713         * Scripts/do-webcore-rename:
3714         * Scripts/run-javascriptcore-tests:
3715         * Scripts/update-javascriptcore-test-results:
3716         * Scripts/webkitdirs.pm:
3717         * Scripts/webkitpy/common/config/build_unittest.py:
3718         * Scripts/webkitpy/style/checker.py:
3719         * Scripts/webkitpy/style/checker_unittest.py:
3720         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3721         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3722         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3723         * wx/build/settings.py:
3724
3725 2011-01-01  Adam Barth  <abarth@webkit.org>
3726
3727         Reviewed by Eric Seidel.
3728
3729         Move Sources to Source
3730         https://bugs.webkit.org/show_bug.cgi?id=51794
3731
3732         Update scripts to point to the new location.
3733
3734         * Scripts/build-webkit:
3735         * Scripts/do-file-rename:
3736         * Scripts/do-webcore-rename:
3737         * Scripts/webkitpy/common/config/build.py:
3738         * Scripts/webkitpy/common/config/build_unittest.py:
3739
3740 2010-12-31  Kent Tamura  <tkent@chromium.org>
3741
3742         Reviewed by Eric Seidel.
3743
3744         [DRT/Chromium] Enable mock spell checker on non-OSX
3745         https://bugs.webkit.org/show_bug.cgi?id=51401
3746
3747         * DumpRenderTree/chromium/WebViewHost.cpp:
3748         (WebViewHost::spellCheck):
3749
3750 2010-12-31  Adam Barth  <abarth@webkit.org>
3751
3752         Reviewed by Ariya Hidayat.
3753
3754         Remove Tools/Scripts/wkstyle
3755         https://bugs.webkit.org/show_bug.cgi?id=51774
3756
3757         This script appears to not have been touched in a while and seems to
3758         have been replaced by check-webkit-style.
3759
3760         * Scripts/wkstyle: Removed.
3761
3762 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3763
3764         Unreviewed. Coding style fix.
3765
3766         * DumpRenderTree/chromium/TestShell.h:
3767
3768 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3769
3770         Reviewed by Pavel Feldman.
3771
3772         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3773
3774         It was a problem with Chromium DRT. DevToolsAgent object instance was
3775         attached not only to the inspected page but to the DevTools window too.
3776         As result all the inspector files were interpreted as a content of inspected page
3777         and were transfered to the DevTools scripts panel for debugging etc.
3778
3779         https://bugs.webkit.org/show_bug.cgi?id=51735
3780
3781         * DumpRenderTree/chromium/TestShell.cpp:
3782         (TestShell::TestShell):
3783         (TestShell::bindJSObjectsToWindow):
3784         (TestShell::createNewWindow):
3785         * DumpRenderTree/chromium/TestShell.h:
3786
3787 2010-12-31  Adam Barth  <abarth@webkit.org>
3788
3789         Rubber-stamped by Eric Seidel.
3790
3791         Move PageLoadTests to PerformanceTests/PageLoad
3792         https://bugs.webkit.org/show_bug.cgi?id=51771
3793
3794         Update references to PageLoadTests to point to the new location.
3795
3796         * Scripts/run-pageloadtest:
3797         * Scripts/webkitpy/common/config/build.py:
3798
3799 2010-12-31  Adam Barth  <abarth@webkit.org>
3800
3801         Rubber-stamped by Eric Seidel.
3802
3803         Move SunSpider into PerformanceTests
3804         https://bugs.webkit.org/show_bug.cgi?id=51769
3805
3806         Update these scripts to point to the new location.
3807
3808         * Scripts/run-sunspider:
3809         * Scripts/sunspider-compare-results:
3810
3811 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3812
3813         Reviewed by Kent Tamura.
3814
3815         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3816         https://bugs.webkit.org/show_bug.cgi?id=51728
3817         
3818         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3819         to render top-level scrollbars. This makes them match the Mac port's
3820         use of an NSScrollView, which means that we'll be able to share more
3821         pixel baselines.
3822         
3823         The new rendering code will not be activated until the 
3824         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3825         ScrollbarThemeChromiumMac.
3826
3827         * DumpRenderTree/DumpRenderTree.gypi:
3828         * DumpRenderTree/chromium/TestShellMac.mm:
3829         (platformInit):
3830         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3831         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3832         (+[FakeActiveWindow alwaysActiveWindow]):
3833         (+[FakeActiveWindow alwaysInactiveWindow]):
3834         (-[FakeActiveWindow initWithActiveControls:]):
3835         (-[FakeActiveWindow _hasActiveControls]):
3836         (WebThemeEngineDRTMac::paintScrollbarThumb):
3837         (stateToHIEnableState):
3838         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3839         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3840
3841 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3842
3843         Reviewed by David Kilzer.
3844
3845         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3846         used
3847         https://bugs.webkit.org/show_bug.cgi?id=51672
3848
3849         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3850         with USE_SYSTEM_MALLOC=1
3851         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3852         with USE_SYSTEM_MALLOC=1
3853
3854 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3855
3856         Reviewed by David Kilzer.
3857
3858         [Qt] [Symbian] Fix build-webkit script for Symbian
3859         https://bugs.webkit.org/show_bug.cgi?id=51509
3860
3861         Set the OUTPUT_DIR for Symbian to be the same as the source
3862         directory.
3863
3864         * Scripts/webkitdirs.pm:
3865
3866 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3867
3868         Reviewed by Darin Adler.
3869
3870         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3871         https://bugs.webkit.org/show_bug.cgi?id=51758
3872
3873         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3874
3875         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3876         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3877
3878 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3879
3880         Unreviewed WinCE buildfix.
3881
3882         * WinCELauncher/main.cpp: Add missing include.
3883
3884 2010-12-29  Daniel Bates  <dbates@rim.com>
3885
3886         Reviewed by Darin Adler.
3887
3888         svn-apply updates date of wrong change log entry for a change log diff that
3889         contains two consecutive entries with the same author and date
3890         https://bugs.webkit.org/show_bug.cgi?id=46061
3891
3892         Fixes an issue where the date of the wrong change log entry may be modified.
3893         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3894         in a ChangeLog file to the top of the file.
3895
3896         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3897         diff when it detects that the diff inserts a change log entry earlier in a
3898         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3899         change. With the advent of the commit-queue this functionality of bailing out
3900         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3901         Instead, we should always move the change log entry to the top of the ChangeLog file.
3902
3903         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3904         the date line of the correct change log entry in a ChangeLog diff.
3905
3906         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3907
3908         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3909           Updated the following unit tests now that we move entries inserted earlier to the top:
3910           - "fixChangeLogPatch: New entry inserted in middle."
3911             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3912
3913           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3914             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3915
3916         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3917
3918 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3919
3920         Reviewed by Eric Seidel.
3921
3922         [Qt] Fixed compatibility with gold linker on X11 platforms
3923         https://bugs.webkit.org/show_bug.cgi?id=51700
3924
3925         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3926         Linked TestNetscapePlugin with libX11 on Unix platforms
3927
3928 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3929
3930         Reviewed by Darin Adler.
3931
3932         Circular dependency in webkitpy.common.checkout.changelog module
3933         https://bugs.webkit.org/show_bug.cgi?id=50475
3934
3935         Remove automatic import of api.Checkout module when any checkout/
3936         submodule is imported (e.g.: when checkout.scm.Git is imported).
3937
3938         * Scripts/webkitpy/common/checkout/__init__.py:
3939
3940 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3941
3942         Reviewed by Ojan Vafai.
3943
3944         prepare-ChangeLog should support the -g option for specifying the git-commit
3945         https://bugs.webkit.org/show_bug.cgi?id=51708
3946
3947         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3948         webkit-patch, though the exact meaning of the two options remain different.
3949
3950         * Scripts/prepare-ChangeLog: Add -g.
3951
3952 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3953
3954         Reviewed by Simon Hausmann.
3955
3956         [Qt] Fix compilation with Qt in namespace
3957         https://bugs.webkit.org/show_bug.cgi?id=51701
3958
3959         * QtTestBrowser/webview.h:
3960
3961 2010-12-28  Daniel Bates  <dbates@rim.com>
3962
3963         Reviewed by Sam Weinig.
3964
3965         Substitute // MARK: for compiler-specific #pragma mark
3966         https://bugs.webkit.org/show_bug.cgi?id=51657
3967
3968         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3969         substituting  "// MARK:" for "#pragma mark", which provides
3970         analogous code-bookmarking functionality under Xcode.
3971
3972         Also, for consistency, we should substitute "// MARK:" for compiler-
3973         specific "#pragma mark" in the source files for the Mac port.
3974
3975         * DumpRenderTree/AccessibilityTextMarker.cpp:
3976         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3977         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3978         * DumpRenderTree/mac/ObjCController.m:
3979         * MiniBrowser/mac/AppDelegate.m:
3980         * MiniBrowser/mac/BrowserWindowController.m:
3981
3982 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3983
3984         Reviewed by Eric Seidel.
3985
3986         Add --no-build option to run-sunspider
3987         https://bugs.webkit.org/show_bug.cgi?id=51658
3988
3989         * Scripts/run-sunspider: add --no-build flag to skip building
3990         phase.
3991
3992 2010-12-27  Daniel Bates  <dbates@rim.com>
3993
3994         Rubber-stamped by Martin Robinson.
3995
3996         Append the directory Tools/DumpRenderTree to the list of directories that
3997         do-webcore-rename should search so that it can rename DRT files and
3998         source code.
3999
4000         * Scripts/do-webcore-rename:
4001
4002 2010-12-27  Eric Seidel  <eric@webkit.org>
4003
4004         Reviewed by Adam Barth.
4005
4006         build-webkit should detect missing Java SDK and explain how to install it
4007         https://bugs.webkit.org/show_bug.cgi?id=51651
4008
4009         * Scripts/build-webkit:
4010
4011 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
4012
4013         Reviewed by Daniel Bates.
4014
4015         [GTK] Add support for build-jsc
4016         https://bugs.webkit.org/show_bug.cgi?id=51625
4017
4018         Add GTK+ support to build-jsc now that building the jsc executable as
4019         a standalone target is easy.
4020
4021         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
4022         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
4023         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
4024         and pass it along to buildAutotoolsProject.
4025
4026 2010-12-27  David Levin  <levin@chromium.org>
4027
4028         Reviewed by Eric Seidel.
4029
4030         check-webkit-style check for meaningless variable names in function declarations.
4031         https://bugs.webkit.org/show_bug.cgi?id=51523
4032
4033         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
4034         from the new check and whitespace/parens because the syntax is unusual and
4035         produced a fair number of positives for these checks.
4036         * Scripts/webkitpy/style/checkers/cpp.py:
4037         (_convert_to_lower_with_underscores): Used as a canonical form for type names
4038         and parameter names when determining if the parameter name is useless.
4039         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
4040         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
4041         format.
4042         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
4043         text or an acronym of it.
4044         (check_function_definition): Checks function definitions for meaningless variable names.
4045         (process_line): Added call to check_function_definition.
4046         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4047         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
4048         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
4049         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
4050         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
4051         because when only checking a snippet, there are a lot of bogus functions.
4052         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
4053         that I put there previously and just noticed.
4054         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
4055         check_function_definition and process_line.
4056
4057 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4058
4059         Reviewed by Martin Robinson.
4060
4061         [GTK] Disable flash plugin in GtkLauncher when using gtk3
4062         https://bugs.webkit.org/show_bug.cgi?id=51591
4063
4064         Flash plugin uses gtk2 that is incompatible with gtk3 making
4065         webkit crash when it's built with gtk3.
4066
4067         * GtkLauncher/main.c:
4068         (main):
4069
4070 2010-12-25  Adam Barth  <abarth@webkit.org>
4071
4072         Reviewed by Eric Seidel.
4073
4074         Move ANGLE to Sources/ThirdParty
4075         https://bugs.webkit.org/show_bug.cgi?id=51605
4076
4077         * Scripts/build-webkit:
4078           - Point to the new ANGLE location.
4079
4080 2010-12-26  David Levin  <levin@chromium.org>
4081
4082         Reviewed by Eric Seidel.
4083
4084         check-webkit-style should be able to parse function declaration parameters.
4085         https://bugs.webkit.org/show_bug.cgi?id=51451
4086
4087         * Scripts/webkitpy/style/checkers/cpp.py:
4088         (Position.__init__): Holds simple position information (row, column).
4089         (Parameter.__init__): Holds information about a parameter.
4090         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
4091         (SingleLineView.convert_column_to_row): Returns the original row given a column.
4092         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
4093         (find_parameter_name_index): Finds where the parameter name is.
4094         (parameter_list): Generates the list of parameters for a function.
4095         (_FunctionState.begin): Added information to allow determining the parameters
4096         on demand.
4097         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
4098         (detect_functions): Improve function detection for operator functions and
4099         determine where the parameters end and pass that to _FunctionState.begin.
4100         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4101         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
4102         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
4103         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
4104         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
4105         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
4106         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
4107         (FunctionDetectionTest.perform_function_detection): Added support for verifying
4108         the parameters found.
4109         (FunctionDetectionTest.test_function_declaration_detection): Added more function
4110         detection test to verify that we catch the operator functions.
4111         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
4112         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
4113         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
4114         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
4115         test_function_length_check_definition_severity1_for_test.
4116
4117 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
4118
4119         Unreviewed WinCE buildfix after r74334.
4120
4121         * CMakeListsWinCE.txt:
4122
4123 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
4124
4125         Unreviewed, rolling out r74632.
4126         http://trac.webkit.org/changeset/74632
4127         https://bugs.webkit.org/show_bug.cgi?id=51600
4128
4129         makes test-webkitpy hang forever on GTK (Requested by philn-tp
4130         on #webkit).
4131
4132         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4133         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4134
4135 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
4136
4137         Reviewed by Kenneth Rohde Christiansen.
4138
4139         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
4140         https://bugs.webkit.org/show_bug.cgi?id=43528
4141
4142         Remove on_resize because ewk_view_fixed_layout_size_set should not be
4143         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
4144         FrameView, rendering was ignored when _ewk_view_smart_calculate was
4145         called.
4146
4147         * EWebLauncher/main.c:
4148         (browserCreate):
4149
4150 2010-12-24  Eric Seidel  <eric@webkit.org>
4151
4152         Reviewed by Adam Barth.
4153
4154         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
4155         https://bugs.webkit.org/show_bug.cgi?id=28291
4156
4157         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
4158         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
4159         to strings with find in the diff.
4160         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
4161
4162         * Scripts/webkitpy/common/checkout/api.py:
4163         * Scripts/webkitpy/common/checkout/diff_parser.py:
4164         * Scripts/webkitpy/tool/steps/abstractstep.py:
4165         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4166         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
4167         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4168         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4169
4170 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
4171
4172         Reviewed by Kenneth Russell.
4173
4174         Modify new-run-webkit-tests to shut up and exit when all the threads
4175         are wedged so that test runs complete faster and we don't end up
4176         w/ enormous log files.
4177
4178         https://bugs.webkit.org/show_bug.cgi?id=51572
4179
4180         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4181         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4182
4183 2010-12-24  Eric Seidel  <eric@webkit.org>
4184
4185         Reviewed by David Levin.
4186
4187         commit-queue should better explain how it will re-open bugs and follow duplicate chains
4188         https://bugs.webkit.org/show_bug.cgi?id=51549
4189
4190         I've had multiple people ask me about the commit-queue's behavior
4191         regarding reporting flaky tests.  I figured it would be best to just
4192         have the queue explain itself in the bugs it files.
4193
4194         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4195         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4196
4197 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
4198
4199         Reviewed by Eric Seidel.
4200
4201         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
4202         https://bugs.webkit.org/show_bug.cgi?id=51467
4203
4204         * Scripts/webkitpy/style/checker.py:
4205         * Scripts/webkitpy/style/checker_unittest.py:
4206
4207 2010-12-23  Adam Barth  <abarth@webkit.org>
4208
4209         Rubber-stamped by Eric Seidel.
4210
4211         Move JavaScriptGlue into Sources
4212         https://bugs.webkit.org/show_bug.cgi?id=51583
4213
4214         These tools refer to JavaScriptGlue and need to be updated to its new
4215         location.
4216
4217         * Scripts/build-webkit:
4218         * Scripts/do-file-rename:
4219         * Scripts/do-webcore-rename:
4220         * Scripts/webkitpy/common/config/build.py:
4221         * Scripts/webkitpy/common/config/build_unittest.py:
4222
4223 2010-12-23  Lucas Forschler  <lforschler@apple.com>
4224
4225         Reviewed by Eric Seidel.
4226
4227         Bug 51539 - update iexploder scripts to point to new location
4228
4229         * Scripts/run-iexploder-tests:
4230         * Scripts/update-iexploder-cssproperties:
4231
4232 2010-12-23  Evan Martin  <evan@chromium.org>
4233
4234         Reviewed by Ryosuke Niwa.
4235
4236         [chromium] LayoutTestController warning in float->int conversion
4237         https://bugs.webkit.org/show_bug.cgi?id=51553
4238
4239         Rather than reading an int, converting to a float, then getting a compiler
4240         warning on passing the float to something that expects an int, instead
4241         just pass around ints.
4242
4243         No tests, fixes a compiler warning.
4244
4245         * DumpRenderTree/chromium/LayoutTestController.cpp:
4246         (parsePageSizeParameters):
4247         (LayoutTestController::pageNumberForElementById):
4248         (LayoutTestController::numberOfPages):
4249
4250 2010-12-23  Lucas Forschler  <lforschler@apple.com>
4251
4252         Reviewed by Darin Adler.
4253
4254         Bug 51537 - iexploder needs cleanup
4255         
4256         * iExploder/htdocs: Removed.
4257         * iExploder/htdocs/config.rb: Removed.
4258         * iExploder/htdocs/cssproperties.in: Removed.
4259         * iExploder/htdocs/cssvalues.in: Removed.
4260         * iExploder/htdocs/htmlattrs.in: Removed.
4261         * iExploder/htdocs/htmltags.in: Removed.
4262         * iExploder/htdocs/htmlvalues.in: Removed.
4263         * iExploder/htdocs/iexploder.cgi: Removed.
4264         * iExploder/htdocs/iexploder.rb: Removed.
4265         * iExploder/htdocs/index.html: Removed.
4266         * iExploder/htdocs/webserver.rb: Removed.
4267         * iExploder/iexploder-1.7.2/output: Removed.
4268         * iExploder/tools: Removed.
4269         * iExploder/tools/lasthit.rb: Removed.
4270         * iExploder/tools/osx_last_crash.rb: Removed.
4271         * iExploder/tools/showtest.rb: Removed.
4272
4273 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
4274
4275         Reviewed by Kenneth Rohde Christiansen.
4276
4277         [EFL] Make 'single' the default backing store in EWebLauncher
4278         https://bugs.webkit.org/show_bug.cgi?id=51534
4279
4280         'single' is the simplest backing store and the one intended to be the
4281         default in the test browser. By mistake the tiled backing store was
4282         left as default in r72617.
4283
4284         * EWebLauncher/main.c:
4285         (browserCreate): ditto.
4286
4287 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
4288
4289         Reviewed by Kenneth Rohde Christiansen.
4290
4291         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
4292         https://bugs.webkit.org/show_bug.cgi?id=51533
4293
4294         There's no point in concatenating env("HOME") with "blah", so remove
4295         option from EWebLauncher.
4296
4297         * EWebLauncher/main.c:
4298         (main): ditto.
4299
4300 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
4301
4302         Reviewed by Eric Seidel.
4303
4304         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
4305
4306         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
4307         I just discovered that we have two additional GC runs per each WebViewHost.
4308         Test_shell had no such calls.
4309         These gc runs eat 15% of cpu time.
4310
4311         https://bugs.webkit.org/show_bug.cgi?id=51479
4312
4313         * DumpRenderTree/chromium/WebViewHost.cpp:
4314         (WebViewHost::~WebViewHost):
4315
4316 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
4317
4318         Reviewed by Ojan Vafai.
4319
4320         This change splits out the TestRunner class into its own file.
4321         When we fork the code for message passing, we will create a new
4322         TestRunner, and this change will allow that to be more modular.
4323
4324         While we're at it, split out TestInput and ResultSummary into
4325         their own files, to reduce the size of run_webkit_tests to
4326         something more managable.
4327
4328         https://bugs.webkit.org/show_bug.cgi?id=51092
4329
4330         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4331         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
4332         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4333         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
4334         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
4335         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4336         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4337
4338  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
4339
4340         Reviewed by Ojan Vafai.
4341
4342         nrwt multiprocessing - start over, prepare to fork the code
4343  
4344         This code cleans up the signatures and implementation of the
4345         TestRunner class so we can easily fork it to run either the
4346         stable implementation or the new, unstable message-passing
4347         implementation. The two variants will have different
4348         implementations of the run_tests() method. We will switch
4349         between the two based on the setting for the '--worker-model'
4350         switch. We rename the two currently valid values to 'old-inline'
4351         and 'old-threads'.
4352
4353         https://bugs.webkit.org/show_bug.cgi?id=51081
4354
4355         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4356         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4357
4358 2010-12-22  Victor Wang  <victorw@chromium.org>
4359
4360         Reviewed by Darin Fisher.
4361
4362         [Chromium] Update chromium archive test result url in rebaseline script.
4363
4364         https://bugs.webkit.org/show_bug.cgi?id=51503
4365
4366         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4367
4368 2010-12-22  Lucas Forschler  <lforschler@apple.com>
4369
4370         Reviewed by Alice Liu.
4371
4372         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
4373         Verified on Chrome, Safari, and IE.
4374         With this change, we will record memory from a parent browser window and all child processes.
4375
4376         * record-memory-win/main.cpp:
4377         (ProcessArgs):
4378         (PrintUsage):
4379         (getMemoryInfo):
4380         (printProcessInfo):
4381         (evalProcesses):
4382         (UseImage):
4383         (QueryContinuously):
4384         (ElapsedTime):
4385
4386 2010-12-22  Lucas Forschler  <lforschler@apple.com>
4387
4388         Unreviewed rollout r74489, because it was missing changelog.
4389
4390         * record-memory-win/main.cpp:
4391         
4392 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
4393
4394         Adding myself as a reviewer.
4395
4396         * Scripts/webkitpy/common/config/committers.py:
4397
4398 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
4399
4400         Unreviewed.  Adding myself to committers.py.
4401
4402         * Scripts/webkitpy/common/config/committers.py:
4403
4404 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
4405
4406         Reviewed by Kenneth Rohde Christiansen.
4407
4408         TestNetscapePlugIn should use #if defined
4409         https://bugs.webkit.org/show_bug.cgi?id=51471
4410
4411         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4412         (NP_Initialize):
4413         (NPP_New):
4414
4415 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
4416
4417         Reviewed by Yury Semikhatsky.
4418
4419         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
4420
4421         DevTools window should be closed explicitly because it has custom deinitialization code.
4422
4423         https://bugs.webkit.org/show_bug.cgi?id=50722
4424
4425         * DumpRenderTree/chromium/TestShell.cpp:
4426         (TestShell::closeRemainingWindows):
4427
4428 2010-12-22  David Levin  <levin@chromium.org>
4429
4430         Reviewed by Shinichiro Hamaji.
4431
4432         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
4433         https://bugs.webkit.org/show_bug.cgi?id=51452
4434
4435         * Scripts/webkitpy/style/checkers/cpp.py:
4436         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
4437         Using the file extension if possible but falling back to the file contents if we have a header file.
4438         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
4439         (_FileState.is_c_or_objective_c):
4440         (check_using_std): Changed to using _FileState to determine the file type.
4441         (check_max_min_macros): Ditto.
4442         (check_for_null): Ditto.
4443         (check_style): Changed the parameters to various calls since they now need _FileState
4444         to determine the file type.
4445         (check_language): Added the file_state parameter so it could be passed
4446         to check_identifier_name_in_declaration.
4447         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
4448         this is an Objective C file.
4449         (_process_lines): Added information for the _FileState constructor (and moved the
4450         call to a place that had the information).
4451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4452         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
4453         its functionality.
4454         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
4455
4456 2010-12-21  Andy Estes  <aestes@apple.com>
4457
4458         Reviewed by Mark Rowe.
4459
4460         Do not build non-Intel architectures for WebKit2-related projects.
4461         https://bugs.webkit.org/show_bug.cgi?id=51440
4462
4463         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
4464         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
4465         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
4466
4467 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
4468
4469         Reviewed by Darin Fisher.
4470
4471         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
4472         https://bugs.webkit.org/show_bug.cgi?id=51406 
4473         
4474         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
4475         to WebThemeEngineDRTWin and update references everywhere.
4476
4477         * DumpRenderTree/DumpRenderTree.gypi:
4478         * DumpRenderTree/chromium/TestShellWin.cpp:
4479         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
4480         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
4481         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
4482         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
4483
4484 2010-12-21  Anders Carlsson  <andersca@apple.com>
4485
4486         Reviewed by John Sullivan.
4487
4488         Clicking missing plug-in text does not show a sheet
4489         https://bugs.webkit.org/show_bug.cgi?id=51403
4490
4491         Update for changes to the WebPageUIClient.
4492
4493         * MiniBrowser/mac/BrowserWindowController.m:
4494         (-[BrowserWindowController awakeFromNib]):
4495         * WebKitTestRunner/TestController.cpp:
4496         (WTR::createOtherPage):
4497         (WTR::TestController::initia