d5a0e76f54bf6447bbadb2ecb0327564526693d6
[WebKit.git] / Tools / ChangeLog
1 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2
3         Reviewed by Darin Adler.
4
5         https://bugs.webkit.org/show_bug.cgi?id=52739
6         Make it possible for a WebKit2 client to print headers and footers
7
8         Added dummy implementations for new printing UIClient calls.
9
10         * MiniBrowser/mac/BrowserWindowController.m:
11         (-[BrowserWindowController awakeFromNib]):
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::createOtherPage):
14         (WTR::TestController::initialize):
15
16 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
17
18         Reviewed by Ojan Vafai.
19
20         Change webkitpy/layout_tests/port/test.py to use the
21         in-memory filesystem for cleaner unit testing. This
22         change allows us to kill a lot of code that was
23         specific to the test port, at the cost of being a
24         little less clear about how things would work if
25         you didn't have a filesystem.
26
27         https://bugs.webkit.org/show_bug.cgi?id=52605
28
29         * Scripts/webkitpy/layout_tests/port/test.py:
30
31 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
32
33         Unreviewed, build fix.
34
35         Fix test failure caused by committing attachment 79368 instead
36         of attachment 79461 on bug 52604.
37
38         * Scripts/webkitpy/common/system/filesystem_mock.py:
39
40 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
41
42         Reviewed by Mihai Parparita.
43
44         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
45         unit testing. os.walk() is too much of a hassle to implement on
46         top of the in-memory mock filesystem and adding the necessary
47         interface to files_under() gives clients a cleaner API anyway
48         (for this particular usage model).
49
50         https://bugs.webkit.org/show_bug.cgi?id=52691
51
52         * Scripts/webkitpy/common/system/filesystem.py:
53         * Scripts/webkitpy/common/system/filesystem_mock.py:
54         * Scripts/webkitpy/layout_tests/port/test_files.py:
55         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
56
57 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
58
59         Reviewed by Tony Chang.
60
61         Change more modules in the layout-tests code to use the
62         filesystem wrapper for cleaner unit testing.
63
64         This patch also adds the glob() wrapper to the filesystem
65         abstraction.
66         
67         https://bugs.webkit.org/show_bug.cgi?id=52604
68
69         * Scripts/webkitpy/layout_tests/port/test_files.py:
70         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
71         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
72         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
73         * Scripts/webkitpy/common/system/filesystem.py:
74         * Scripts/webkitpy/common/system/filesystem_mock.py:
75
76 2011-01-19  Levi Weintraub  <leviw@chromium.org>
77
78         Unreviewed.
79
80         Updating my email addresses and irc nick.
81
82         * Scripts/webkitpy/common/config/committers.py:
83
84 2011-01-19  Tony Chang  <tony@chromium.org>
85
86         Reviewed by Mihai Parparita.
87
88         [chromium] [linux] if check-sys-deps fails, output the failure reason
89         https://bugs.webkit.org/show_bug.cgi?id=52671
90
91         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
92             error handler functions.
93         * Scripts/webkitpy/layout_tests/port/chromium.py:
94             output the error text from --check-sys-deps
95         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
96
97 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
98
99         Reviewed by Andreas Kling.
100
101         [Qt] QtTestBrowser crashes when closing if Facebook is opened
102         https://bugs.webkit.org/show_bug.cgi?id=52554
103         
104         QtNetworkAccessManager is created in a thread and set as
105         member variable in QWebPage. When the thread is destroyed
106         the object is still used. So fix will set the object to
107         NULL once the thread is destroyed.
108
109         * QtTestBrowser/launcherwindow.cpp:
110         (LauncherWindow::~LauncherWindow):
111
112 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
113
114         Rubber stamped by Csaba Osztrogonac
115
116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
117
118 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
119
120         Reviewed by Tony Chang.
121
122         new-run-webkit-tests: add a --build-directory command line argument
123
124         Official Google Chrome builds use a non-standard build directory
125         location. This patch adds a --build-directory argument that
126         allows that location to be specified on the command line. Only
127         Chromium-based builds will use this flag for now, but anyone can
128         in the future.
129
130         There are no unit tests for this since it's difficult to test
131         until mock filesystems are fully supported in the code. This was
132         tested by hand for now.
133
134         https://bugs.webkit.org/show_bug.cgi?id=52694
135
136         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
137         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
138         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
139         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
140
141 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
142
143         Not reviewed. Bot fix.
144
145         Remove an inadvertently committed debugging print.
146
147         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
148         (LayoutTestController::notifyDone):
149
150 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
151
152         Reviewed by Sam Weinig.
153
154         WebKitTestRunner should track loading more like DumpRenderTree
155         https://bugs.webkit.org/show_bug.cgi?id=52692
156
157         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
158         This makes some tests that call notifyDone multiple times pass.
159         
160         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
161         (WTR::InjectedBundle::InjectedBundle):
162         (WTR::InjectedBundle::done):
163         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
164         (WTR::InjectedBundle::topLoadingFrame):
165         (WTR::InjectedBundle::setTopLoadingFrame):
166         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
167         (WTR::InjectedBundlePage::InjectedBundlePage):
168         (WTR::InjectedBundlePage::stopLoading):
169         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
170         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
171         (WTR::InjectedBundlePage::didFinishLoadForFrame):
172         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
173         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
174         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
175         (WTR::LayoutTestController::notifyDone):
176         * WebKitTestRunner/TestController.cpp:
177         (WTR::TestController::didReceiveMessageFromInjectedBundle):
178
179 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
180
181         Reviewed by Kent Tamura.
182
183         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
184         https://bugs.webkit.org/show_bug.cgi?id=52678
185         
186         Update path now that WebKit is inside Source.
187
188         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
189
190 2011-01-18  Robert Hogan  <robert@webkit.org>
191
192         Reviewed by Simon Hausmann.
193
194         [Qt] http/tests/incremental/slow-utf8-text.pl fails
195         https://bugs.webkit.org/show_bug.cgi?id=44282
196
197         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
198         (WebCore::DumpRenderTree::dump):
199
200 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
201
202         Reviewed by Mihai Parparita.
203
204         Fix a small race condition that could cause the unit tests for
205         new-run-webkit-tests to fail in a multithreaded environment.
206         There was a small window in the code where one thread would
207         check to see if a thread had raised an exception, do something,
208         and then check to see if the thread was alive. If the other
209         thread raised an exception and exited in between these two
210         steps, the exception would be lost. Flipping the order of the
211         two checks fixes the race, since we will now always check for an
212         exception on the thread before exiting.
213
214         https://bugs.webkit.org/show_bug.cgi?id=51579
215
216         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
217
218 2011-01-18  Eric Seidel  <eric@webkit.org>
219
220         Reviewed by Adam Barth.
221
222         commit-queue dies when test archiving fails
223         https://bugs.webkit.org/show_bug.cgi?id=52617
224
225         I looked at the machine and it had 10 archives already
226         thus find_unused_name was returning None.  I've upped
227         the limit to 100 (per bug) and tested the case where
228         find_unused_name returns None (making archive return None).
229
230         * Scripts/webkitpy/common/system/workspace.py:
231         * Scripts/webkitpy/common/system/workspace_unittest.py:
232         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
233         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
234         * Scripts/webkitpy/tool/commands/queues.py:
235
236 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
237
238         Reviewed by Ojan Vafai.
239
240         Update rebaseline-chromium-webkit-tests unit tests to use a mock
241         filesystem. Also fix a couple of "with" statements missed by
242         r76050.
243
244         https://bugs.webkit.org/show_bug.cgi?id=52487
245
246         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
247
248 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
249
250         Reviewed by Martin Robinson.
251
252         [Gtk] Build fixes for gtk3 build
253         https://bugs.webkit.org/show_bug.cgi?id=52648
254
255         * DumpRenderTree/gtk/EventSender.cpp:
256         (beginDragWithFilesCallback):
257
258 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
259
260         Reviewed by Mihai Parparita.
261
262         Update rebaseline-chromium-webkit-tests to use filesystem objects
263         instead of direct references to os.path, shutil, tempfile, etc.
264
265         This patch doesn't change anything, but will allow subsequent
266         patches to change the unit tests to no longer use the real
267         filesystem.
268
269         This patch adds a bunch more methods to the filesystem object as
270         well.
271
272         https://bugs.webkit.org/show_bug.cgi?id=52482
273
274         * Scripts/webkitpy/common/system/filesystem.py:
275         * Scripts/webkitpy/common/system/filesystem_mock.py:
276         * Scripts/webkitpy/tool/commands/queues.py:
277         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
278         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
279
280 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
281
282         Reviewed by Mihai Parparita.
283
284         new-run-webkit-tests shouldn't crash when you try to run a
285         directory containing only skipped files.
286
287         https://bugs.webkit.org/show_bug.cgi?id=52478
288         
289         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
290         * Scripts/webkitpy/layout_tests/port/test.py:
291         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
292
293 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
294
295         Reviewed by Gustavo Noronha Silva.
296
297         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
298         https://bugs.webkit.org/show_bug.cgi?id=40833
299
300         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
301         GTK+ event sender.
302         (dragWithFilesDragDataGetCallback): Added.
303         (dragWithFilesDragEndCallback): Added.
304         (beginDragWithFilesCallback): Added.
305
306 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
307
308         Reviewed by Adam Barth.
309
310         ews: Add additional watcher to efl ews
311         https://bugs.webkit.org/show_bug.cgi?id=52613
312
313         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
314
315         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
316
317 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
318
319         Reviewed by Alexey Proskuryakov.
320
321         Fix some headers with missing or misspelled #ifndef guards
322         https://bugs.webkit.org/show_bug.cgi?id=52545
323
324         * DumpRenderTree/chromium/TestEventPrinter.h:
325         * DumpRenderTree/chromium/WebPreferences.h:
326
327 2011-01-17  Jessie Berlin  <jberlin@apple.com>
328
329         Reviewed by Anders Carlsson.
330
331         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
332         navigating back to an unreachable URL
333         https://bugs.webkit.org/show_bug.cgi?id=52388
334
335         Add a third parameter (unreachableURL) to queueLoadHTMLString.
336
337         * DumpRenderTree/LayoutTestController.cpp:
338         (queueLoadHTMLStringCallback):
339         (LayoutTestController::queueLoadHTMLString):
340         (LayoutTestController::queueLoadAlternateHTMLString):
341         * DumpRenderTree/LayoutTestController.h:
342
343         * DumpRenderTree/WorkQueueItem.h:
344         (LoadHTMLStringItem::LoadHTMLStringItem):
345
346         * DumpRenderTree/chromium/LayoutTestController.cpp:
347         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
348         (WorkItemLoadHTMLString::run):
349         (LayoutTestController::queueLoadHTMLString):
350
351         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
352         (LoadHTMLStringItem::invoke):
353         * DumpRenderTree/mac/WorkQueueItemMac.mm:
354         (LoadHTMLStringItem::invoke):
355         * DumpRenderTree/win/WorkQueueItemWin.cpp:
356         (LoadHTMLStringItem::invoke):
357
358 2011-01-17  Dan Bernstein  <mitz@apple.com>
359
360         Rubber-stamped by Mark Rowe.
361
362         Update xcodeproj svn:ignore to include xcuserdata.
363
364         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
365         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
366         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
367         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
368         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
369
370 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
371
372         Unreviewed fix after r75908.
373
374         Move WebKit into Source
375         https://bugs.webkit.org/show_bug.cgi?id=52530
376
377         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
378
379 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
380
381         Unreviewed.
382
383         Remove accidentally committed debug printing after r75908.
384
385         * Scripts/webkitdirs.pm:
386
387 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
388
389         Unreviewed.
390
391         Add myself to committers list
392         https://bugs.webkit.org/show_bug.cgi?id=52566
393
394         * Scripts/webkitpy/common/config/committers.py:
395
396 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
397
398         Reviewed by Jeremy Orlow.
399
400         GeolocationController should call stopUpdating on destruction
401         https://bugs.webkit.org/show_bug.cgi?id=52216
402
403         fast/dom/Geolocation/window-close-crash.html requires that a
404         Geolocation watch be started in a secondary window. Consequently,
405         we need to allow geolocation permission and provide a mock
406         geolocation position for the secondary window's
407         GeolocationClientMock.
408
409         * DumpRenderTree/chromium/LayoutTestController.cpp:
410         (LayoutTestController::setGeolocationPermission):
411         (LayoutTestController::setMockGeolocationPosition):
412         (LayoutTestController::setMockGeolocationError):
413         * DumpRenderTree/chromium/TestShell.h:
414         (TestShell::windowList):
415
416 2011-01-16  Adam Barth  <abarth@webkit.org>
417
418         Update more include paths to reflect WebKit move.
419
420         * DumpRenderTree/chromium/EventSender.cpp:
421         (EventSender::keyDown):
422         (EventSender::needsShiftModifier):
423         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
424         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
425
426 2011-01-16  Kent Tamura  <tkent@chromium.org>
427
428         Unreviewed, Chromium build fix.
429
430         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
431
432 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
433
434         Build fix for GTK+ after source directory movement.
435
436         * GNUmakefile.am: Correct include paths.
437
438 2011-01-16  Adam Barth  <abarth@webkit.org>
439
440         Teach svn-apply about WebKit move.
441
442         * Scripts/VCSUtils.pm:
443
444 2011-01-16  Adam Barth  <abarth@webkit.org>
445
446         Rubber-stamped by Eric Seidel.
447
448         Move WebKit into Source
449         https://bugs.webkit.org/show_bug.cgi?id=52530
450
451         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
452         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
453         * DumpRenderTree/qt/DumpRenderTreeQt.h:
454         * DumpRenderTree/qt/GCControllerQt.cpp:
455         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
456         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
457         * DumpRenderTree/qt/TextInputControllerQt.cpp:
458         * DumpRenderTree/wscript:
459         * QtTestBrowser/launcherwindow.h:
460         * Scripts/build-webkit:
461         * Scripts/webkitdirs.pm:
462
463 2011-01-15  Adam Barth  <abarth@webkit.org>
464
465         Teach svn-apply about WebKit2 move.
466
467         * Scripts/VCSUtils.pm:
468
469 2011-01-15  Adam Barth  <abarth@webkit.org>
470
471         Rubber-stamped by Eric Seidel.
472
473         Move WebKit2 into Source
474         https://bugs.webkit.org/show_bug.cgi?id=52438
475
476         * MiniBrowser/qt/MiniBrowser.pro:
477         * Scripts/build-webkit:
478         * Scripts/do-file-rename:
479         * Scripts/do-webcore-rename:
480         * Scripts/test-webkitpy:
481         * Scripts/webkitdirs.pm:
482         * Scripts/webkitpy/style/checker.py:
483         * WebKitTestRunner/DerivedSources.pro:
484         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
485         * WebKitTestRunner/qt/WebKitTestRunner.pro:
486
487 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
488
489         Reviewed by David Levin.
490
491         [chromium] remove obsolete createView method
492         https://bugs.webkit.org/show_bug.cgi?id=52437
493
494         * DumpRenderTree/chromium/WebViewHost.cpp:
495         (WebViewHost::createView):
496         * DumpRenderTree/chromium/WebViewHost.h:
497
498 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
499
500         Reviewed by Geoff Garen.
501
502         ShouldLoadResourceForFrame should use strings, not URLs.
503         https://bugs.webkit.org/show_bug.cgi?id=52476
504
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
506         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
507         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
508
509 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
510
511         Reviewed by David Levin.
512
513         Add Tony Gentilcore as a reviewer
514         https://bugs.webkit.org/show_bug.cgi?id=52480
515
516         * Scripts/webkitpy/common/config/committers.py:
517
518 2011-01-14  David Levin  <levin@chromium.org>
519
520         Reviewed by Eric Seidel.
521
522         check-webkit-style: _FunctionState should keep track of where the function name starts.
523         https://bugs.webkit.org/show_bug.cgi?id=52454
524
525         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
526         _FunctionState and logic for setting it correctly.
527         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
528
529 2011-01-14  Vincent Scheib  <scheib@chromium.org>
530
531         Reviewed by David Levin.
532
533         Add support to DumpRenderTree to use the GPU rather than software renderer
534         https://bugs.webkit.org/show_bug.cgi?id=52333
535
536         * DumpRenderTree/chromium/DumpRenderTree.cpp:
537         (main):
538         * Scripts/webkitpy/layout_tests/port/chromium.py:
539         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
540
541 2011-01-14  Tony Chang  <tony@chromium.org>
542
543         Reviewed by Kent Tamura.
544
545         [chromium] update fonts.conf to fix 6 linux tests in drt
546         https://bugs.webkit.org/show_bug.cgi?id=52411
547
548         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
549             chromium's src/webkit/tools/test_shell/resources/fonts.conf
550
551 2011-01-14  Eric Seidel  <eric@webkit.org>
552
553         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
554
555         Reviewed by Adam Barth.
556
557         Fix when running Tools/Scripts/check-webkit-style without arguments.
558         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
559
560         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
561         * Scripts/webkitpy/common/checkout/scm_unittest.py:
562
563 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
564
565         Reviewed by David Levin.
566
567         Store the tempdir object in a variable so it doesn't get deleted too early.
568         https://bugs.webkit.org/show_bug.cgi?id=51875
569
570         * Scripts/update-webkit-auxiliary-libs:
571         * Scripts/update-webkit-support-libs:
572
573 2011-01-14  Eric Seidel  <eric@webkit.org>
574
575         Unreviewed.  Make it work in python 2.5.
576
577         webkit-patch suggest-reviewers dies when ChangeLogs are missing
578         https://bugs.webkit.org/show_bug.cgi?id=49158
579
580         * Scripts/webkitpy/common/checkout/api_unittest.py:
581
582 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
583
584         Unreviewed, rolling out r75774.
585         http://trac.webkit.org/changeset/75774
586         https://bugs.webkit.org/show_bug.cgi?id=52431
587
588         gtk builds were broken (Requested by loislo2 on #webkit).
589
590         * Scripts/webkitpy/common/checkout/scm.py:
591
592 2011-01-14  David Levin  <levin@chromium.org>
593
594         Reviewed by Shinichiro Hamaji.
595
596         check-webkit-style: _FunctionState should detect pure functions.
597         https://bugs.webkit.org/show_bug.cgi?id=52428
598
599         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
600         is a pure virtual function.
601         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
602         virtual functions are correctly detected.
603
604 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
605
606         Reviewed by Yury Semikhatsky.
607
608         Just small fix for problem with check-webkit-style.
609         It just didn't work for this patch.
610         Old code can't concatenate a list of strings with None.
611
612         * Scripts/webkitpy/common/checkout/scm.py:
613
614 2011-01-13  David Levin  <levin@chromium.org>
615
616         Reviewed by Shinichiro Hamaji.
617
618         check-webkit-style: _FunctionState should use Position to know where items are.
619         https://bugs.webkit.org/show_bug.cgi?id=52424
620
621         * Scripts/webkitpy/style/checkers/cpp.py:
622         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
623         (detect_functions): Changed to pass Position's to _FunctionState.begin and
624         did some minor clean-up.
625         (*): Other changes are simply about converting to use the Position's in_FunctionState
626         instead of line numbers.
627         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
628         to verify the positions stored in _FunctionState.
629
630 2011-01-13  Eric Seidel  <eric@webkit.org>
631
632         Reviewed by David Levin.
633
634         webkit-patch suggest-reviewers dies when ChangeLogs are missing
635         https://bugs.webkit.org/show_bug.cgi?id=49158
636
637         This is not the most elegant, but it is a very safe fix to this bug.
638         One advantage of catching ScriptError like this instead of adding a
639         new added_or_modified_files or fixing all changed_files callers
640         to use a more specific change_files variant, is that we catch
641         all kinds of ScriptErrors which might cause our (non-essential)
642         suggest-reviewers code to fail out.  This should make passing
643         --suggest-reviewers to webkit-patch upload much more robust
644         and may even make it possible for us to make it default.
645
646         The root of the problem here is that SCM.changed_files includes
647         deleted ChangeLog paths (from moves, etc) which then when we ask
648         SVN/Git for the contents of the file at that revision, the command
649         errors out and Executive.run_command raises a ScriptError.
650
651         In the future we might fix this differently by making all current
652         callers of chagned_files use a more specific method for requesting
653         what types of changes they're interested in (adds, modifies, deletes, etc.)
654
655         * Scripts/webkitpy/common/checkout/api.py:
656         * Scripts/webkitpy/common/checkout/api_unittest.py:
657
658 2011-01-13  Dan Bernstein  <mitz@apple.com>
659
660         Reviewed by Alexey Proskuryakov.
661
662         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
663         https://bugs.webkit.org/show_bug.cgi?id=52419
664
665         Allow to further control the behavior of the willSendRequest delegate callback by making it
666         set a different URL in the new request.
667
668         * DumpRenderTree/LayoutTestController.cpp:
669         (addURLToRedirectCallback): Added.
670         (LayoutTestController::staticFunctions): Added addURLToRedirect.
671         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
672         (LayoutTestController::redirectionDestinationForURL): Added this getter.
673         * DumpRenderTree/LayoutTestController.h:
674         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
675         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
676         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
677         change the URL in the new request to the redirect destination.
678
679 2011-01-13  Eric Seidel  <eric@webkit.org>
680
681         Reviewed by Mihai Parparita.
682
683         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
684         https://bugs.webkit.org/show_bug.cgi?id=52416
685
686         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
687         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
688
689         I also added FIXMEs about the changed_files returning deleted files problem
690         which is causing the other most common exception for suggest-reviewers
691         (and is probably breaking sheriff-bots blame detection).
692
693         * Scripts/webkitpy/common/checkout/api.py:
694         * Scripts/webkitpy/common/checkout/api_unittest.py:
695         * Scripts/webkitpy/common/checkout/scm.py:
696
697 2011-01-13  Eric Seidel  <eric@webkit.org>
698
699         Reviewed by Adam Barth.
700
701         results archives from commit-queue are too large to upload
702         https://bugs.webkit.org/show_bug.cgi?id=52405
703
704         * Scripts/webkitpy/common/system/filesystem.py:
705         * Scripts/webkitpy/common/system/filesystem_mock.py:
706         * Scripts/webkitpy/tool/commands/queues.py:
707
708 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
709
710         Reviewed by Martin Robinson.
711
712         [gtk] Zero-sized font does not yet work
713         https://bugs.webkit.org/show_bug.cgi?id=49793
714
715         Set minimum-font-size to 0 for the DRT.
716
717         * DumpRenderTree/gtk/DumpRenderTree.cpp:
718         (resetDefaultsToConsistentValues):
719
720 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
721
722         Reviewed by Darin Adler.
723
724         Make old-run-webkit-tests more robust on buildbots
725         https://bugs.webkit.org/show_bug.cgi?id=52364
726
727         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
728
729 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
730
731         Reviewed by Darin Adler.
732
733         Make old-run-webkit-tests more robust on buildbots
734         https://bugs.webkit.org/show_bug.cgi?id=52364
735
736         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
737
738 2011-01-13  Tony Chang  <tony@chromium.org>
739
740         Reviewed by Kent Tamura.
741
742         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
743         https://bugs.webkit.org/show_bug.cgi?id=52332
744
745         Forked Info.plist is not longer needed.
746
747         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
748
749 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
750
751         Reviewed by Timothy Hatcher.
752
753         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
754         to be passed directly to WebInspector.UIString
755
756         https://bugs.webkit.org/show_bug.cgi?id=52365
757
758         * Scripts/check-inspector-strings:
759
760 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
761
762         Unreviewed, rolling out r74881.
763         http://trac.webkit.org/changeset/74881
764         https://bugs.webkit.org/show_bug.cgi?id=52357
765
766         The EFL builder has been red for days (Requested by abarth on
767         #webkit).
768
769         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
770         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
771
772 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
773
774         Reviewed by David Levin.
775
776         Add beforeunload support to WebKitTestRunner
777         https://bugs.webkit.org/show_bug.cgi?id=52353
778         
779         This makes a number of currently failing tests pass.
780
781         * WebKitTestRunner/TestController.cpp:
782         (WTR::runBeforeUnloadConfirmPanel):
783         (WTR::createOtherPage):
784         (WTR::TestController::initialize):
785
786 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
787
788         Reviewed by Sam Weinig.
789
790         Detect, identify and recover from WebProcess crashes in run-webkit-tests
791         https://bugs.webkit.org/show_bug.cgi?id=52330
792
793         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
794         a web process crash.
795         * WebKitTestRunner/TestController.cpp:
796         (WTR::TestController::initialize): Set up a processDidCrash
797         callback.
798         (WTR::TestController::processDidCrash): Report that the Web process
799         crashed.
800         * WebKitTestRunner/TestController.h:
801
802 2011-01-12  David Levin  <levin@chromium.org>
803
804         Reviewed by Shinichiro Hamaji.
805
806         check-webkit-style -- close_expression function doesn't work correctly.
807         https://bugs.webkit.org/show_bug.cgi?id=52272
808
809         * Scripts/webkitpy/style/checkers/cpp.py:
810         (Position.__str__): Added a way to convert it to a string which is useful in tests.
811         (Position.__cmp__): Added a way to compare Position which is useful in tests and
812         generally useful (for upcoming code changes).
813         (close_expression): Changed to use Position for input and output.
814         Also, fixed many bugs such as only working correctly for parenthesis,
815         not working correctly if given an offset in a line and not finding
816         the real closing element if there were multiple closing elements in
817         the same line.
818         (detect_functions): Adjusted due to the change in arguments for
819         close_expression.
820         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
821         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
822         two positions are the same.
823         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
824         (CppStyleTest.test_close_expression): Added tests to catch the issues
825         that were fixed.
826
827 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
828
829         Unreviewed, rolling out r75576.
830         http://trac.webkit.org/changeset/75576
831         https://bugs.webkit.org/show_bug.cgi?id=52304
832
833         broke rebaseline-chromium-webkit-test (Requested by thakis on
834         #webkit).
835
836         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
837         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
838         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
839         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
840         * Scripts/webkitpy/layout_tests/port/base.py:
841         * Scripts/webkitpy/layout_tests/port/chromium.py:
842         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
843         * Scripts/webkitpy/layout_tests/port/test.py:
844         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
845         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
846         * Scripts/webkitpy/style/checkers/test_expectations.py:
847         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
848
849 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
850
851         Reviewed by Darin Adler.
852
853         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
854         https://bugs.webkit.org/show_bug.cgi?id=52307
855
856         * Scripts/old-run-webkit-tests:
857
858 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
859
860         Reviewed by Martin Robinson.
861
862         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
863         https://bugs.webkit.org/show_bug.cgi?id=50867
864
865         Fixed library extention for Mac in webkitdirs.pm and type conflict in
866         TestNetscapePlugin.cpp 
867
868         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
869         * Scripts/webkitdirs.pm:
870
871 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
872
873         Reviewed by Pavel Feldman.
874
875         Add check-inspector-strings script.
876
877         https://bugs.webkit.org/show_bug.cgi?id=52295
878
879         * Scripts/check-inspector-strings: Added.
880
881 2011-01-12  Adam Roben  <aroben@apple.com>
882
883         Advertise the .testnetscape file extension on Windows
884
885         Fixes <http://webkit.org/b/52298>
886         plugins/no-mime-with-valid-extension.html fails on Windows
887
888         Reviewed by Dan Bernstein.
889
890         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
891         FileExtents field to map the .testnetscape file extension to the
892         application/x-webkit-test-netscape MIME type, just as we do on Mac.
893
894 2011-01-12  Adam Barth  <abarth@webkit.org>
895
896         Reviewed by Eric Seidel.
897
898         Make webkit-patch support subdirectories for SVN checkouts
899         https://bugs.webkit.org/show_bug.cgi?id=52261
900
901         os.relpath does not exist on Python 2.5, so we need to call our version
902         of the API.
903
904         * Scripts/webkitpy/common/checkout/scm.py:
905
906 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
907
908         Reviewed by Eric Seidel.
909
910         Close additional pages opened during a test once the test completes.
911         https://bugs.webkit.org/show_bug.cgi?id=52276
912
913         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
914         (WTR::InjectedBundle::done):
915
916 2011-01-11  David Levin  <levin@chromium.org>
917
918         Reviewed by Eric Seidel.
919
920         Errors should be separated from the command line in bot messages.
921         https://bugs.webkit.org/show_bug.cgi?id=52275
922
923         * Scripts/webkitpy/common/system/executive.py:
924         (ScriptError.message_with_output): Added a newline to separate the command
925         line from the errors.
926         * Scripts/webkitpy/common/system/executive_unittest.py:
927         (ScriptErrorTest.test_message_with_output): Added tests for the various code
928         paths in message_with_output.
929
930 2011-01-11  Eric Seidel  <eric@webkit.org>
931
932         Unreviewed.
933
934         commit-queue should know how to upload archived results (for test flakes or general failures)
935         https://bugs.webkit.org/show_bug.cgi?id=52048
936
937         The zips are mostly empty due to forgetting -r.
938         Expected diffs were not being pulled from the archive due
939         to the archive having longer paths than I realized.
940
941         * Scripts/webkitpy/common/system/workspace.py:
942         * Scripts/webkitpy/common/system/workspace_unittest.py:
943         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
944         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
945
946 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
947
948         Reviewed by Ojan Vafai.
949
950         The current modifier parsing code in test_expectations is
951         fragile and hard-coded, so it's not easy to understand the logic
952         or easily add new types of modifiers (like GPU vs. CPU testing
953         for graphics tests, or 32-bit vs. 64-bit differences).
954
955         This is the first of two patches that will add in more generic
956         support and then eliminate the GPU-specific test expectations
957         files for Chromium.
958
959         This patch adds two standalone objects for handling modifiers. The
960         rules for interpreting modifiers, precedence, and conflicts are
961         given in the docstring to the ModifierMatcher class, which
962         returns ModifierMatchResult objects.
963         
964         This patch also adds routines to the Port interface and a
965         default set of values in the base object, in order to obtain the
966         values needed on a given test run. These values are then passed
967         to the expectation parser. This also allows us to clean up the
968         logic used to lint all of the different configurations in a
969         single test_expectations.txt file.
970
971         The next patch will merge in the separate GPU expectations file.
972
973         https://bugs.webkit.org/show_bug.cgi?id=51222
974
975         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
976         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
977         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
978         * Scripts/webkitpy/layout_tests/port/base.py:
979         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
980         * Scripts/webkitpy/layout_tests/port/chromium.py:
981         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
982         * Scripts/webkitpy/layout_tests/port/test.py:
983         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
984         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
985
986 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
987
988         Reviewed by Adam Barth.
989
990         Make webkit-patch support subdirectories for SVN checkouts
991         https://bugs.webkit.org/show_bug.cgi?id=52261
992
993         * Scripts/webkitpy/common/checkout/scm.py:
994         * Scripts/webkitpy/style_references.py:
995         * Scripts/webkitpy/tool/main.py:
996         * Scripts/webkitpy/tool/steps/preparechangelog.py:
997
998 2011-01-11  Eric Seidel  <eric@webkit.org>
999
1000         Unreviewed.
1001
1002         commit-queue should know how to upload archived results (for test flakes or general failures)
1003         https://bugs.webkit.org/show_bug.cgi?id=52048
1004
1005         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1006         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1007
1008         * Scripts/webkitpy/common/system/workspace.py:
1009         * Scripts/webkitpy/common/system/workspace_unittest.py:
1010         * Scripts/webkitpy/tool/commands/queues.py:
1011
1012 2011-01-11  Sam Weinig  <sam@webkit.org>
1013
1014         Roll r75474 back in.
1015
1016 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1017
1018         Reviewed by Kenneth Rohde Christiansen.
1019
1020         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1021         https://bugs.webkit.org/show_bug.cgi?id=51204
1022
1023         * QtTestBrowser/webpage.h:
1024         (QtNAMThread::QtNAMThread):
1025         (QtNAMThread::networkAccessManager):
1026         (QtNAMThread::run):
1027
1028 2011-01-11  Peter Varga  <pvarga@webkit.org>
1029
1030         Unreviewed.
1031
1032         Add myself to committers' list.
1033
1034         * Scripts/webkitpy/common/config/committers.py:
1035
1036 2011-01-11  Eric Seidel  <eric@webkit.org>
1037
1038         Reviewed by Adam Barth.
1039
1040         commit-queue should know how to upload archived results (for test flakes or general failures)
1041         https://bugs.webkit.org/show_bug.cgi?id=52048
1042
1043         Now the queue will always upload results.  Either the entire zip, or just
1044         the diffs.txt in the case of text failures.
1045
1046         This should make understanding flakes much easier, and paves the way
1047         for having the EWS run layout tests (and upload failures).
1048
1049         In order to upload .zip files I had to teach bugzilla.py to autodetect
1050         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1051         for .patch files, I have it add one before calling guess_type.
1052
1053         We may find that always uploading the whole zip instead of just the -diffs.txt
1054         file is preferable, but for now I'm keeping the old behavior because it makes
1055         quickly understanding text failures easy.
1056
1057         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1058         * Scripts/webkitpy/common/system/workspace.py: Added.
1059         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1060         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1061         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1062         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1063         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1064         * Scripts/webkitpy/tool/commands/queues.py:
1065         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1066
1067 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1068
1069         Unreviewed, rolling out r75464.
1070         http://trac.webkit.org/changeset/75464
1071         https://bugs.webkit.org/show_bug.cgi?id=52193
1072
1073         Followup rollout for 75474 (Requested by Ossy on #webkit).
1074
1075         * MiniBrowser/mac/BrowserWindowController.m:
1076         (-[BrowserWindowController awakeFromNib]):
1077         * MiniBrowser/win/BrowserView.cpp:
1078         (BrowserView::create):
1079         * WebKitTestRunner/TestController.cpp:
1080         (WTR::createOtherPage):
1081         (WTR::TestController::initialize):
1082
1083 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1084
1085         Reviewed by Csaba Osztrogonác.
1086
1087         [Qt] Baseline qt_minimal configuration
1088         https://bugs.webkit.org/show_bug.cgi?id=51313
1089
1090         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1091         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1092         QT_NO_UNDOSTACK guard.
1093
1094         * QtTestBrowser/launcherwindow.cpp:
1095         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1096         guards.
1097         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1098         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1099         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1100         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1101
1102         * QtTestBrowser/launcherwindow.h:
1103         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1104         * QtTestBrowser/locationedit.h: Ditto.
1105
1106         * QtTestBrowser/mainwindow.cpp:
1107         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1108         QT_NO_UNDOSTACK guards.
1109         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1110         (MainWindow::changeLocation): Ditto.
1111         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1112         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1113
1114         * QtTestBrowser/webpage.cpp:
1115         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1116         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1117
1118         * QtTestBrowser/webview.cpp:
1119         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1120         (WebViewGraphicsBased::animatedYFlip): Ditto.
1121
1122 2011-01-10  Sam Weinig  <sam@webkit.org>
1123
1124         Fix build.
1125
1126         * MiniBrowser/mac/BrowserWindowController.m:
1127         (-[BrowserWindowController awakeFromNib]):
1128         * MiniBrowser/win/BrowserView.cpp:
1129         (BrowserView::create):
1130         * WebKitTestRunner/TestController.cpp:
1131         (WTR::createOtherPage):
1132         (WTR::TestController::initialize):
1133
1134 2011-01-10  Eric Seidel  <eric@webkit.org>
1135
1136         Reviewed by Ojan Vafai.
1137
1138         style-queue messages are way too long for big patches
1139         https://bugs.webkit.org/show_bug.cgi?id=52161
1140
1141         We definitely could build much fancier list-to-string-with-limit functions
1142         but this should be sufficient for our needs at the moment.
1143
1144         * Scripts/webkitpy/common/system/executive.py:
1145         * Scripts/webkitpy/common/system/executive_unittest.py:
1146
1147 2011-01-10  Tony Chang  <tony@chromium.org>
1148
1149         Unreviewed, rolling out r75398.
1150         http://trac.webkit.org/changeset/75398
1151         https://bugs.webkit.org/show_bug.cgi?id=52008
1152
1153         Some layout tests are crashing on Chromium Win.
1154
1155         * DumpRenderTree/chromium/WebViewHost.cpp:
1156         (WebViewHost::updatePaintRect):
1157         * DumpRenderTree/chromium/WebViewHost.h:
1158
1159 2011-01-10  Adam Roben  <aroben@apple.com>
1160
1161         Roll out r75392
1162
1163         It isn't needed now that r75289 has been rolled out.
1164
1165         * Scripts/run-javascriptcore-tests:
1166
1167 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1168
1169         Reviewed by Anders Carlsson.
1170
1171         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1172         https://bugs.webkit.org/show_bug.cgi?id=52160
1173
1174         * WebKitTestRunner/mac/TestControllerMac.mm:
1175         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1176         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1177         anyway.
1178
1179 2011-01-10  Tony Chang  <tony@chromium.org>
1180
1181         Reviewed by Mihai Parparita.
1182
1183         [chromium] fix for animated gif layout tests
1184         https://bugs.webkit.org/show_bug.cgi?id=52008
1185
1186         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1187             to trigger gif animations.
1188         (WebViewHostPaintTask::WebViewHostPaintTask):
1189         (WebViewHostPaintTask::runIfValid):
1190         (WebViewHost::updatePaintRect):
1191         * DumpRenderTree/chromium/WebViewHost.h:
1192         (WebViewHost::taskList):
1193
1194 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1195
1196         Reviewed by Xan Lopez.
1197
1198         [GTK] Fix gtk2 compilation for master
1199         https://bugs.webkit.org/show_bug.cgi?id=51885
1200
1201         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1202         (createBitmapContextFromWebView): Replaced the old
1203         gdk_drawable_get_size with gdk_pixmap_get_size.
1204
1205 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1206
1207         Reviewed by Laszlo Gombos.
1208
1209         [WINCE] Reenable NPAPI after r75203
1210         https://bugs.webkit.org/show_bug.cgi?id=52109
1211
1212         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1213         it with !isEfl(), because EFL port does not support NPAPI (yet).
1214
1215         * Scripts/build-webkit:
1216
1217 2011-01-10  Adam Roben  <aroben@apple.com>
1218
1219         Skip some asserting JS tests
1220
1221         See <http://webkit.org/b/52156>.
1222
1223         * Scripts/run-javascriptcore-tests:
1224
1225 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1226
1227         Reviewed by Xan Lopez.
1228
1229         [GTK] build-webkit disable Blob support via arguments passed to automake
1230         https://bugs.webkit.org/show_bug.cgi?id=52097
1231
1232         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1233         build-webkit.
1234
1235 2011-01-10  Adam Roben  <aroben@apple.com>
1236
1237         Use the same name and description for TestNetscapePlugin on Windows and
1238         Mac
1239
1240         Fixes <http://webkit.org/b/52151>
1241         fast/frames/iframe-reparenting-plugins.html fails on Windows
1242
1243         Reviewed by Steve Falkenburg.
1244
1245         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1246         the name and description from Mac's Info.plist.
1247
1248 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1249
1250         Reviewed by Laszlo Gombos.
1251
1252         [Qt][WK2] Guard gcc-specific syntax
1253
1254         Non-gcc based compliers choke on the "-include"
1255         syntax for preinclude, place guard around it.
1256
1257         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1258         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1259
1260 2011-01-10  Andreas Kling  <kling@webkit.org>
1261
1262         Reviewed by Simon Hausmann.
1263
1264         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1265         https://bugs.webkit.org/show_bug.cgi?id=52111
1266
1267         When getting a createNewPage() callback from QWKPage, create the
1268         new page with the same QWKContext as the page that is passed to
1269         the callback.
1270
1271         * MiniBrowser/qt/BrowserView.h:
1272         * MiniBrowser/qt/BrowserWindow.cpp:
1273         (newPageFunction):
1274         (BrowserWindow::BrowserWindow):
1275         * MiniBrowser/qt/BrowserWindow.h:
1276
1277 2011-01-10  Andreas Kling  <kling@webkit.org>
1278
1279         Reviewed by Kenneth Rohde Christiansen.
1280
1281         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1282
1283         BrowserView set its own useless createNewPage() callback on QWKPage.
1284         This was immediately overridden by BrowserWindow anyway, so remove
1285         the BrowserView one.
1286
1287         * MiniBrowser/qt/BrowserView.cpp:
1288         (BrowserView::BrowserView):
1289
1290 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1291
1292         Reviewed by Jeremy Orlow.
1293
1294         [Chromium] Remove non-client-based Geolocation code
1295         https://bugs.webkit.org/show_bug.cgi?id=50921
1296
1297         * DumpRenderTree/chromium/LayoutTestController.cpp:
1298         (LayoutTestController::setGeolocationPermission):
1299         (LayoutTestController::setMockGeolocationPosition):
1300         (LayoutTestController::setMockGeolocationError):
1301         * DumpRenderTree/chromium/WebViewHost.cpp:
1302         (WebViewHost::geolocationClientMock):
1303         (WebViewHost::reset):
1304         * DumpRenderTree/chromium/WebViewHost.h:
1305
1306 2011-01-10  Eric Seidel  <eric@webkit.org>
1307
1308         Reviewed by Adam Barth.
1309
1310         Commit bot tried to land r? cq+ patch
1311         https://bugs.webkit.org/show_bug.cgi?id=36638
1312
1313         It should now be possible to post a patch with r? and cq+ and the
1314         commit-queue will correctly wait for the r+ before attempting to land the patch.
1315         (This was a feature requested by several users.)
1316
1317         One caveat: We don't actually reject r-, cq+ patches from the queue
1318         (we just ignore them), but I think that's OK for now.
1319
1320         I also noticed that setting r- once a commit-queue node had grabbed
1321         a patch would not properly cancel the landing.  That's fixed and
1322         tested in this patch.
1323
1324         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1325         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1326         * Scripts/webkitpy/tool/bot/feeders.py:
1327         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1328
1329 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1330
1331         Reviewed by Kenneth Rohde Christiansen.
1332
1333         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1334         https://bugs.webkit.org/show_bug.cgi?id=51934
1335
1336         When accessing the network from the destructor of QWebPage, the network access manager
1337         was already deleted because the object WebPage was already destructed.
1338
1339         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1340         The object is now destructed in the destructor of QObject.
1341
1342         * QtTestBrowser/webpage.cpp:
1343         (WebPage::WebPage):
1344         (WebPage::setQnamThreaded):
1345         * QtTestBrowser/webpage.h:
1346         (QtNAMThread::QtNAMThread):
1347
1348 2011-01-08  Eric Seidel  <eric@webkit.org>
1349
1350         Reviewed by Ojan Vafai.
1351
1352         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1353         https://bugs.webkit.org/show_bug.cgi?id=52067
1354
1355         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1356         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1357
1358         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1359
1360 2011-01-08  Eric Seidel  <eric@webkit.org>
1361
1362         Reviewed by Mihai Parparita.
1363
1364         commit-queue hangs when the ChangeLog diff is bad
1365         https://bugs.webkit.org/show_bug.cgi?id=52072
1366
1367         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1368         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1369
1370 2011-01-08  Adam Barth  <abarth@webkit.org>
1371
1372         Teach svn-apply how to re-write WebCore to Source/WebCore.
1373
1374         * Scripts/VCSUtils.pm:
1375
1376 2011-01-07  Adam Barth  <abarth@webkit.org>
1377
1378         Rubber-stamped by Eric Seidel.
1379
1380         Move WebCore to Source
1381         https://bugs.webkit.org/show_bug.cgi?id=52050
1382
1383         Update the tools to understand WebCore's new location.
1384
1385         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1386         * DumpRenderTree/wscript:
1387         * GNUmakefile.am:
1388         * Scripts/build-webkit:
1389         * Scripts/do-file-rename:
1390         * Scripts/do-webcore-rename:
1391         * Scripts/generate-qt-inspector-resource:
1392         * Scripts/prepare-ChangeLog:
1393         * Scripts/run-bindings-tests:
1394         * Scripts/update-iexploder-cssproperties:
1395         * Scripts/update-sources-list.py:
1396         * Scripts/update-webkit-localizable-strings:
1397         * Scripts/webkitdirs.pm:
1398         * Scripts/webkitpy/common/config/build.py:
1399         * Scripts/webkitpy/common/config/build_unittest.py:
1400         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1401         * Scripts/webkitpy/style/checker.py:
1402         * Scripts/webkitpy/style/checker_unittest.py:
1403         * WebKitTestRunner/DerivedSources.pro:
1404         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1405         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1406         * wx/browser/wscript:
1407         * wx/build/settings.py:
1408
1409 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1410
1411         Reviewed by Sam Weinig.
1412
1413         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1414         https://bugs.webkit.org/show_bug.cgi?id=52086
1415
1416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1417         (WTR::InjectedBundle::didReceiveMessage):
1418         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1419         (WTR::LayoutTestController::notifyDone):
1420         * WebKitTestRunner/TestController.cpp:
1421         (WTR::TestController::resetStateToConsistentValues):
1422         (WTR::TestController::run):
1423
1424 2011-01-07  James Robinson  <jamesr@chromium.org>
1425
1426         Revert "Implement mozilla's animationTime property"
1427         https://bugs.webkit.org/show_bug.cgi?id=51952
1428
1429         This approach isn't quite right.
1430
1431         * DumpRenderTree/chromium/WebViewHost.cpp:
1432         (WebViewHost::paintInvalidatedRegion):
1433
1434 2011-01-07  Adam Roben  <aroben@apple.com>
1435
1436         Build master fix
1437
1438         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1439         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1440
1441 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1442
1443         Reviewed by Csaba Osztrogonác.
1444
1445         run-qtwebkit-tests should be able to kill a testsuite.
1446
1447         Add new option in the script that can setup a timeout for a test.
1448         If the test execution takes more then specified time then the test
1449         would be terminated.
1450
1451         [Qt] run-qtwebkit-tests needs timeout
1452         https://bugs.webkit.org/show_bug.cgi?id=51894
1453
1454         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1455         * Scripts/run-qtwebkit-tests:
1456
1457 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1458
1459         Unreviewed fix after r75233.
1460
1461         Based on idea from Eric Seidel.
1462
1463         Add remote zip file handling to webkitpy.
1464         https://bugs.webkit.org/show_bug.cgi?id=50901
1465
1466         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1467
1468 2011-01-07  Shane Stephens  <shanestephens@google.com>
1469
1470         Reviewed by Eric Seidel.
1471
1472         svn-apply: should support git binary delta diffs
1473         https://bugs.webkit.org/show_bug.cgi?id=38864
1474
1475         * Scripts/VCSUtils.pm:
1476         * Scripts/svn-apply:
1477
1478 2011-01-06  Julie Parent  <jparent@chromium.org>
1479
1480         Reviewed by Eric Seidel.
1481
1482         Test Result Server not removing old results.
1483         https://bugs.webkit.org/show_bug.cgi?id=52012
1484
1485         * TestResultServer/model/jsonresults.py:
1486         Fix off-by-one: Truncate if >= num_runs, not just >.
1487         * TestResultServer/model/jsonresults_unittest.py:
1488         Add unit test to test that merging in a new result with the same value
1489         as the last result causes previous result to fall off.
1490
1491 2011-01-06  James Kozianski  <koz@chromium.org>
1492
1493         Reviewed by Mihai Parparita.
1494
1495         Add classes to provide a consistent interface to a set of files.
1496         https://bugs.webkit.org/show_bug.cgi?id=50901
1497
1498         These classes allow us to write code that is agnostic to whether a
1499         particular set of files resides in a local directory or in a zip file
1500         on a remote machine.
1501
1502         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1503         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1504         * Scripts/webkitpy/common/system/fileset.py: Added.
1505         * Scripts/webkitpy/common/system/filesystem.py:
1506         * Scripts/webkitpy/common/system/filesystem_mock.py:
1507         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1508         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1509
1510 2011-01-06  Eric Seidel  <eric@webkit.org>
1511
1512         Reviewed by Adam Barth.
1513
1514         NetworkTransaction should log the url it is retrying
1515         https://bugs.webkit.org/show_bug.cgi?id=52043
1516
1517         * Scripts/webkitpy/common/net/networktransaction.py:
1518         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1519
1520 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1521
1522         Windows build fix.
1523         Import os before using it.
1524
1525         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1526
1527 2011-01-06  Eric Seidel  <eric@webkit.org>
1528
1529         Reviewed by Adam Barth.
1530
1531         StyleQueue fails to report errors when patches have many files
1532         https://bugs.webkit.org/show_bug.cgi?id=52042
1533
1534         This is one of at least two errors preventing style error reporting at the moment.
1535         When we moved to passing the list of files to check explicitly,
1536         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1537         We could change the type of the QueueStatus.message type, or we could
1538         just teach statusserver.py how to clamp values (and warn when it does).
1539         I chose the latter path.
1540
1541         * Scripts/webkitpy/common/net/statusserver.py:
1542
1543 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1544
1545         Reviewed by Stephanie Lewis.
1546         
1547         Fix syntax error in script.
1548
1549         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1550         https://bugs.webkit.org/show_bug.cgi?id=51996
1551
1552         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1553
1554 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1555
1556         Unreviewed, fixing WinCE build after r75196.
1557
1558         WinCE port does not (yet) support NPAPI.
1559
1560         * Scripts/build-webkit:
1561
1562 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1563
1564         Reviewed by Darin Adler.
1565
1566         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1567         https://bugs.webkit.org/show_bug.cgi?id=52015
1568
1569         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1570         after the platform has been detected, otherwise the script will
1571         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1572         detection.
1573
1574 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1575
1576         Reviewed by Eric Seidel.
1577
1578         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1579         https://bugs.webkit.org/show_bug.cgi?id=51346
1580
1581         * Scripts/build-webkit:
1582
1583 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1584
1585         Reviewed by Adam Roben.
1586
1587         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1588         https://bugs.webkit.org/show_bug.cgi?id=51996
1589         
1590         After the configuration directory change, we were archiving the incorrect directory for
1591         build product, so we were running tests on the wrong binaries.
1592         
1593         This change archives the correct directory, and also unarchives it into a configuration-
1594         specific directory.
1595
1596         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1597         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1598
1599 2011-01-06  Eric Seidel  <eric@webkit.org>
1600
1601         Reviewed by Mihai Parparita.
1602
1603         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1604         https://bugs.webkit.org/show_bug.cgi?id=52002
1605
1606         See an example of this here:
1607         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1608
1609         It's due to the fact that we pass around TestFailure() instance
1610         objects and yet expect them to all compare to be the same.
1611
1612         This is bad.  We should either have shared instances of these values
1613         or we should just pass around the class names.  There are already hacks
1614         in place to make TestFailure objects pass equality tests, I just added
1615         a __hash__ implementation so they can be used in sets as expected.
1616
1617         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1618         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1619
1620 2011-01-06  Evan Martin  <evan@chromium.org>
1621
1622         Reviewed by Tony Chang.
1623
1624         [gdb] handle inaccessible memory and UChar*
1625         https://bugs.webkit.org/show_bug.cgi?id=52003
1626
1627         To pretty-print a UChar*, we just grope around in the memory
1628         looking for a terminating NUL.  We need to handle the exception
1629         that can occur when we poke into an invalid location.
1630
1631         Additionally, the logic for choosing which pretty-printer would
1632         early return before hitting the point where we'd use the UChar*
1633         printer.  (Did this ever work?  How did it regress?)
1634
1635         * gdb/webkit.py:
1636
1637 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1638
1639         Reviewed by Ada Chan.
1640
1641         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1642         https://bugs.webkit.org/show_bug.cgi?id=51969
1643         
1644         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1645
1646         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1647         (WTR::InjectedBundlePage::InjectedBundlePage):
1648         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1649         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1650
1651 2011-01-06  James Robinson  <jamesr@chromium.org>
1652
1653         Reviewed by Simon Fraser.
1654
1655         Implement mozilla's animationTime property
1656         https://bugs.webkit.org/show_bug.cgi?id=51952
1657
1658         Chromium DRT support for webkitAnimationTime.
1659
1660         * DumpRenderTree/chromium/WebViewHost.cpp:
1661         (WebViewHost::paintInvalidatedRegion):
1662
1663 2011-01-06  Julie Parent  <jparent@chromium.org>
1664
1665         Reviewed by Tony Chang.
1666
1667         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1668         https://bugs.webkit.org/show_bug.cgi?id=51217
1669
1670         * TestResultServer/model/jsonresults.py:
1671         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1672         Adds missing documentation.
1673         * TestResultServer/model/jsonresults_unittest.py:
1674         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1675         Update test_merge to take a number of builds to truncate at.
1676
1677 2011-01-06  Adam Barth  <abarth@webkit.org>
1678
1679         Reviewed by Eric Seidel.
1680
1681         The EWS should log outside of the working directory
1682         https://bugs.webkit.org/show_bug.cgi?id=51986
1683
1684         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1685         script, which will actually clean the working copy back to a pristine
1686         state instead of leaving untracked directories and ignored files.
1687
1688         * Scripts/webkitpy/tool/commands/queues.py:
1689         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1690
1691 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1692
1693         Windows build fix.
1694         Back out attempted change to built-product-archive.
1695
1696         * BuildSlaveSupport/built-product-archive:
1697
1698 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1699
1700         Windows build fix.
1701         Include configuration name when unpacking a build archive.
1702
1703         Needed, since we split Windows build results into configuration-specific directories
1704         under WebKitOutputDir.
1705
1706         * BuildSlaveSupport/built-product-archive:
1707
1708 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1709
1710         Reviewed by Darin Adler.
1711
1712         Debug and Release builds on Windows clobber each other
1713         https://bugs.webkit.org/show_bug.cgi?id=49185
1714
1715         Changes the structure of WebKitBuild build products directory so we
1716         completely separate each build configuration into independent directories.
1717         
1718         Although we previously had per-configuration directories for obj, this change adds
1719         per-configuration directories for bin, lib, obj, and include. Each configuration's
1720         build products are stored within a directory inside of WebKitBuild.
1721         
1722         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1723         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1724
1725         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1726         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1727         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1728         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1729         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1730         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1731         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1732         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1733         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1734         * FindSafari/FindSafari.vcproj:
1735         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1736         * MiniBrowser/MiniBrowserPostBuild.cmd:
1737         * MiniBrowser/MiniBrowserPreBuild.cmd:
1738         * Scripts/webkitdirs.pm:
1739         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1740         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1741         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1742         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1743         * TestWebKitAPI/win/copy-resources.cmd:
1744         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1745         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1746         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1747         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1748         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1749         * WebKitTestRunner/win/InjectedBundle.vcproj:
1750         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1751         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1752         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1753         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1754         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1755         * WinLauncher/WinLauncherCommon.vsprops:
1756         * WinLauncher/WinLauncherPostBuild.cmd:
1757         * WinLauncher/WinLauncherPreBuild.cmd:
1758
1759 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1760
1761         Reviewed by Ariya Hidayat.
1762
1763         [Qt] TestNetscapePlugin doesn't link on OS X
1764         https://bugs.webkit.org/show_bug.cgi?id=51948
1765
1766         Only add a dependency on libX11 on X11 systems
1767
1768         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1769
1770 2011-01-05  Jeff Miller  <jeffm@apple.com>
1771
1772         Reviewed by Adam Roben.
1773
1774         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1775         https://bugs.webkit.org/show_bug.cgi?id=51970
1776
1777         * Scripts/webkitpy/style/checker.py:
1778         Add -readability/naming for WebKit2 C API directories.
1779
1780 2011-01-05  Eric Seidel  <eric@webkit.org>
1781
1782         Unreviewed, just fixing one more log error from my previous python patch.
1783
1784         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1785         https://bugs.webkit.org/show_bug.cgi?id=51802
1786
1787         webkit-patch failure-reason was logging about parsing errors
1788         due to my misunderstanding of how BeautifulSoup.findAll worked.
1789
1790         Fixed, and added a unit test.
1791
1792         * Scripts/webkitpy/common/net/layouttestresults.py:
1793         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1794
1795 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1796
1797         Reviewed by Kenneth Rohde Christiansen.
1798
1799         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1800         https://bugs.webkit.org/show_bug.cgi?id=51951
1801
1802         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1803         to create new window from WebKit.
1804
1805         * MiniBrowser/qt/BrowserWindow.cpp:
1806         (newPageFunction):
1807         (BrowserWindow::BrowserWindow):
1808         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1809         (BrowserWindow::newWindow):
1810         (BrowserWindow::updateUserAgentList):
1811         (BrowserWindow::showUserAgentDialog):
1812         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1813         define the type of the backing store used for new windows.
1814         * MiniBrowser/qt/main.cpp:
1815         (main):
1816
1817 2011-01-05  Eric Seidel  <eric@webkit.org>
1818
1819         Reviewed by Ojan Vafai.
1820
1821         commit-queue should report failure type when reporting flaky tests
1822         https://bugs.webkit.org/show_bug.cgi?id=51900
1823
1824         This patch was a ridiculous amount of plumbing.  In the end I like
1825         the NRWT-style TestResult class even less.  But now we're passing
1826         a list of TestResult objects from the queue to the FlakyTestReporter.
1827         Thus the FlakyTestReporter can more easily report what type of failure
1828         occurred.
1829
1830         In the process, I found that I was not alone in finding TestResult
1831         cumbersome to use.  A bunch of code was trying to create a TestResult
1832         object with default values.  However since the constructor didn't make
1833         this easy, some places were getting it wrong (including the TestResult unit test)!
1834         I've fixed the TestResult constructor to have default values for non-essential
1835         arguments.
1836
1837         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1838         * Scripts/webkitpy/common/net/layouttestresults.py:
1839         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1840         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1841         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1842         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1843         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1844         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1845         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1846         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1847         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1848         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1849         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1850         * Scripts/webkitpy/tool/commands/queues.py:
1851         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1852
1853 2011-01-05  Eric Seidel  <eric@webkit.org>
1854
1855         Unreviewed.
1856
1857         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1858         https://bugs.webkit.org/show_bug.cgi?id=51802
1859
1860         Add another unit test to cover a previously missing import.
1861
1862         * Scripts/webkitpy/common/net/layouttestresults.py:
1863         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1864
1865 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1866
1867         Reviewed by David Levin.
1868
1869         Add mihaip@chromium.org as a reviewer
1870         https://bugs.webkit.org/show_bug.cgi?id=51966
1871         
1872         Add myself as a reviewer.
1873
1874         * Scripts/webkitpy/common/config/committers.py:
1875
1876 2011-01-05  James Simonsen  <simonjam@chromium.org>
1877
1878         Unreviewed. Adding myself to the list of committers.
1879
1880         * Scripts/webkitpy/common/config/committers.py:
1881
1882 2011-01-05  Eric Seidel  <eric@webkit.org>
1883
1884         Unreviewed.
1885
1886         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1887         https://bugs.webkit.org/show_bug.cgi?id=51802
1888
1889         Fix two exceptions seen on the bots after my original commit.
1890
1891         * Scripts/webkitpy/common/net/layouttestresults.py:
1892         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1893
1894 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1895
1896         Reviewed by Andreas Kling.
1897
1898         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1899         https://bugs.webkit.org/show_bug.cgi?id=51750
1900
1901         * QtTestBrowser/main.cpp:
1902         (LauncherApplication::handleUserOptions):
1903          Local storage settings can be enable form command line arguments for
1904          QtTestBrowser.
1905
1906 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1907
1908         Reviewed by Martin Robinson.
1909
1910         GTK: AX: DRT needs to use correct root object method.
1911         https://bugs.webkit.org/show_bug.cgi?id=51911
1912
1913         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1914         (AccessibilityController::rootElement):
1915
1916 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1917
1918         Rubber-stamped by Csaba Osztrogonác.
1919
1920         Based on idea from Péter Gál.
1921
1922         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1923
1924 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1925
1926         Reviewed by Adam Barth.
1927
1928         sheriff-bot should be able to do multi-revision rollouts
1929         https://bugs.webkit.org/show_bug.cgi?id=51176
1930
1931         * Scripts/webkitpy/tool/bot/irc_command.py:
1932         * Scripts/webkitpy/tool/bot/sheriff.py:
1933         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1934
1935 2011-01-05  Eric Seidel  <eric@webkit.org>
1936
1937         Reviewed by Adam Barth.
1938
1939         queues.webkit.org should have per-bot status pages
1940         https://bugs.webkit.org/show_bug.cgi?id=51906
1941
1942         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1943         statuses from a single queue.  Now that we have many bots servicing
1944         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1945         you care about scroll off the end of the 15-message limit on the main page.
1946
1947         Eventually we should probably rename /queue-status to /queue or /queues,
1948         but that's fodder for another patch.
1949
1950         * QueueStatusServer/handlers/queuestatus.py:
1951         * QueueStatusServer/index.yaml:
1952         * QueueStatusServer/main.py:
1953         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1954          - This probably should use a custom filter instead of hard-coding
1955            the URL scheme here, but I couldn't figure out how to easily
1956            create such a filter.  Most filters work with "strings" so we can't
1957            pass the status object.  We could add a method to the status
1958            object and call that, but that seemed a bit strange too.
1959         * QueueStatusServer/templates/queuestatus.html:
1960
1961 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1962
1963         Unreviewed. Adding myself to the list of committers.
1964
1965         * Scripts/webkitpy/common/config/committers.py:
1966
1967 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1968
1969         Reviewed by David Levin.
1970
1971         check-webkit-style treated some macros with parentheses after #elif as function calls
1972         https://bugs.webkit.org/show_bug.cgi?id=51695
1973
1974         Ingore function call space checking in any preprocessor directives
1975         (things starting with #). Change search() to match() because 
1976         preprocessor directives are supposed to be in the beginning of lines.
1977
1978         * Scripts/webkitpy/style/checkers/cpp.py:
1979         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1980
1981 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1982
1983         Reviewed by Tony Chang.
1984
1985         Change the --multi-load test option to --stress-opt
1986         https://bugs.webkit.org/show_bug.cgi?id=50751
1987
1988         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1989         (runTest):
1990         (main):
1991         * DumpRenderTree/chromium/TestShell.cpp:
1992         (TestShell::TestShell):
1993         * DumpRenderTree/chromium/TestShell.h:
1994         (TestShell::stressOpt):
1995         (TestShell::setStressOpt):
1996         (TestShell::stressDeopt):
1997         (TestShell::setStressDeopt):
1998         (TestShell::javaScriptFlags):
1999         (TestShell::setJavaScriptFlags):
2000         * Scripts/webkitpy/layout_tests/port/chromium.py:
2001         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2002
2003 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2004
2005         Reviewed by Sam Weinig.
2006
2007         WK2: Support Accessibility
2008         https://bugs.webkit.org/show_bug.cgi?id=51859
2009
2010         Use rootObject() method to get top of accessibility tree.
2011
2012         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2013         (AccessibilityController::focusedElement):
2014         (AccessibilityController::rootElement):
2015
2016 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2017
2018         Reviewed by Darin Adler.
2019
2020         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2021         https://bugs.webkit.org/show_bug.cgi?id=51846
2022
2023         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2024         back to GRefPtr.
2025
2026 2011-01-04  Zhe Su  <suzhe@chromium.org>
2027
2028         Reviewed by Kenneth Russell.
2029
2030         Fix insertText, setMarkedText and unmarkText methods of
2031         TextInputController to call corresponding methods of WebKit::WebView
2032         rather than WebKit::WebFrame. This change matches the behavior of
2033         chromium browser.
2034         insertText corresponds to WebView::confirmComposition(text)
2035         setMarkedText corresponds to WebView::setComposition(...)
2036         unmarkText corresponds to WebView::confirmComposition()
2037         https://bugs.webkit.org/show_bug.cgi?id=51693
2038
2039         * DumpRenderTree/chromium/TextInputController.cpp:
2040         (TextInputController::insertText):
2041         (TextInputController::setMarkedText):
2042         (TextInputController::unmarkText):
2043
2044 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2045
2046         Reviewed by Laszlo Gombos.
2047
2048         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2049
2050         On Symbian productDir points to the source directory. Removing all the
2051         empty files from the productDir directory corrupts the svn repository.
2052
2053         * Scripts/build-webkit:
2054
2055 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2056
2057         Reviewed by Adam Barth.
2058
2059         [Qt] Add SelectAll option to the context menu for the editor
2060         https://bugs.webkit.org/show_bug.cgi?id=50049
2061
2062         Set shortcut for the SelectAll action.
2063
2064         * QtTestBrowser/mainwindow.cpp:
2065         (MainWindow::buildUI):
2066
2067 2011-01-03  David Levin  <levin@chromium.org>
2068
2069         Reviewed by Eric Seidel.
2070
2071         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2072         https://bugs.webkit.org/show_bug.cgi?id=51842
2073
2074         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2075         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2076
2077 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2078
2079         Reviewed by David Kilzer.
2080
2081         [WINCE] Adds a build slave.
2082         https://bugs.webkit.org/show_bug.cgi?id=50523
2083
2084         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2085         entry for a release build of the WinCE port.
2086         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2087         flag to build the WinCE port.
2088
2089 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2090
2091         Reviewed by David Kilzer.
2092
2093         Add WinCE support to build-webkit
2094         https://bugs.webkit.org/show_bug.cgi?id=51642
2095
2096         * Scripts/build-webkit:
2097         * Scripts/webkitdirs.pm:
2098
2099 2011-01-03  Eric Seidel  <eric@webkit.org>
2100
2101         Reviewed by Adam Barth.
2102
2103         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2104         https://bugs.webkit.org/show_bug.cgi?id=51802
2105
2106         I'm not the biggest fan of the test_failures or test_results classes,
2107         but it's better to have one shared set of classes, than separate ones
2108         for new vs. old run-webkit-test result handling.
2109
2110         This moves the ORWT results class "LayoutTestResults" over to using
2111         TestResult and TestFailure classes, making it easy for us to
2112         make all our sheriff-bot and other webkitpy code NRWT ready.
2113
2114         This also makes it a trivial patch to generate results.json information
2115         from ORWT results.html files (for flaky test analysis, etc.) as well
2116         as making it a one-liner to report test failure types when the
2117         commit-queue sees flaky tests.
2118
2119         This patch tried not to add new functionality, but only to replace
2120         the guts of LayoutTestResults, while adding unit tests and hoping
2121         not to break anything.
2122
2123         I also moved callers which assumed User.prompt* were static/class methods
2124         to using them as instance methods (since we'll eventually want to make them such).
2125
2126         In the process of re-writing things, I broke the rebaseline command, so I wrote
2127         a unit test to catch my breakage were I do do so again in the future.
2128
2129         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2130         * Scripts/webkitpy/common/net/layouttestresults.py:
2131         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2132         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2133         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2134         * Scripts/webkitpy/tool/commands/queries.py:
2135         * Scripts/webkitpy/tool/commands/rebaseline.py:
2136         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2137         * Scripts/webkitpy/tool/mocktool.py:
2138
2139 2011-01-03  Adam Barth  <abarth@webkit.org>
2140
2141         Reviewed by Simon Fraser.
2142
2143         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2144         https://bugs.webkit.org/show_bug.cgi?id=51840
2145
2146         * Scripts/webkitpy/common/checkout/scm.py:
2147
2148 2011-01-03  Adam Barth  <abarth@webkit.org>
2149
2150         Reviewed by Simon Fraser.
2151
2152         webkit-patch should only hide update output if --quiet
2153         https://bugs.webkit.org/show_bug.cgi?id=51838
2154
2155         As requested by smfr.
2156
2157         * Scripts/webkitpy/tool/steps/update.py:
2158
2159 2011-01-03  Adam Barth  <abarth@webkit.org>
2160
2161         Reviewed by David Levin.
2162
2163         commit-queue shouldn't reject patches twice if two bots process the same patch
2164         https://bugs.webkit.org/show_bug.cgi?id=51805
2165
2166         Before raising an error, we first check whether the patch is still in
2167         the commit-queue.  This check is still racy, of course, but the time
2168         window is much smaller.
2169
2170         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2171
2172 2011-01-03  Sam Weinig  <sam@webkit.org>
2173
2174         Reviewed by Anders Carlsson.
2175
2176         Make run-api-tests less chatty.
2177         https://bugs.webkit.org/show_bug.cgi?id=51831
2178
2179         - Make script quiet by default and add --verbose option (replacing --quiet).
2180         - When not verbose, pipe stdout and stderr to devnull.
2181
2182         * Scripts/run-api-tests:
2183
2184 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2185
2186         Unreviewed. Adding myself to committers.py.
2187
2188         * Scripts/webkitpy/common/config/committers.py:
2189
2190 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2191
2192         Reviewed by Xan Lopez.
2193
2194         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2195         https://bugs.webkit.org/show_bug.cgi?id=51806
2196
2197         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2198         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2199         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2200         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2201         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2202         so make it 'WebKitBuild/Release/.libs'
2203
2204         * Scripts/webkitdirs.pm: 
2205
2206 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2207
2208         Reviewed by Adam Barth.
2209
2210         Make EFL a core builder
2211         https://bugs.webkit.org/show_bug.cgi?id=51804
2212
2213         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2214         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2215
2216 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2217
2218         [Qt] Unreviewed fix after r74855 and r74875.
2219
2220         * BuildSlaveSupport/built-product-archive:
2221          - Create directories explicitly.
2222          - Pass shell=True to subprocess.call().
2223
2224 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2225
2226         [Qt] Unreviewed fix after r74855.
2227
2228         Move JavaScriptCore to Source
2229         https://bugs.webkit.org/show_bug.cgi?id=51604
2230
2231         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2232
2233 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2234
2235         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2236
2237         Move JavaScriptCore to Source
2238         https://bugs.webkit.org/show_bug.cgi?id=51604
2239
2240         * Scripts/webkitdirs.pm:
2241
2242 2011-01-02  Robert Hogan  <robert@webkit.org>
2243
2244         Unreviewed, build fix.
2245
2246         [Qt] Fix DRT build after 74855
2247
2248         * DumpRenderTree/qt/DumpRenderTree.pro:
2249
2250 2011-01-01  Adam Barth  <abarth@webkit.org>
2251
2252         Remove the assumption from the Qt and Gtk builds that every project is
2253         in the root directory.
2254
2255         * Scripts/build-webkit:
2256
2257 2011-01-01  Adam Barth  <abarth@webkit.org>
2258
2259         Reviewed by Eric Seidel.
2260
2261         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2262         https://bugs.webkit.org/show_bug.cgi?id=51796
2263
2264         After this change, svn-apply will magically apply patches to
2265         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2266
2267         * Scripts/VCSUtils.pm:
2268
2269 2011-01-01  Adam Barth  <abarth@webkit.org>
2270
2271         Reviewed by Eric Seidel.
2272
2273         Move JavaScriptCore to Source
2274         https://bugs.webkit.org/show_bug.cgi?id=51604
2275
2276         Update references to JavaScriptCore to point to the new location.
2277
2278         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2279         * DumpRenderTree/qt/DumpRenderTree.pro:
2280         * DumpRenderTree/qt/ImageDiff.pro:
2281         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2282         * DumpRenderTree/wscript:
2283         * Scripts/build-jsc:
2284         * Scripts/build-webkit:
2285         * Scripts/do-file-rename:
2286         * Scripts/do-webcore-rename:
2287         * Scripts/run-javascriptcore-tests:
2288         * Scripts/update-javascriptcore-test-results:
2289         * Scripts/webkitdirs.pm:
2290         * Scripts/webkitpy/common/config/build_unittest.py:
2291         * Scripts/webkitpy/style/checker.py:
2292         * Scripts/webkitpy/style/checker_unittest.py:
2293         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2294         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2295         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2296         * wx/build/settings.py:
2297
2298 2011-01-01  Adam Barth  <abarth@webkit.org>
2299
2300         Reviewed by Eric Seidel.
2301
2302         Move Sources to Source
2303         https://bugs.webkit.org/show_bug.cgi?id=51794
2304
2305         Update scripts to point to the new location.
2306
2307         * Scripts/build-webkit:
2308         * Scripts/do-file-rename:
2309         * Scripts/do-webcore-rename:
2310         * Scripts/webkitpy/common/config/build.py:
2311         * Scripts/webkitpy/common/config/build_unittest.py:
2312
2313 2010-12-31  Kent Tamura  <tkent@chromium.org>
2314
2315         Reviewed by Eric Seidel.
2316
2317         [DRT/Chromium] Enable mock spell checker on non-OSX
2318         https://bugs.webkit.org/show_bug.cgi?id=51401
2319
2320         * DumpRenderTree/chromium/WebViewHost.cpp:
2321         (WebViewHost::spellCheck):
2322
2323 2010-12-31  Adam Barth  <abarth@webkit.org>
2324
2325         Reviewed by Ariya Hidayat.
2326
2327         Remove Tools/Scripts/wkstyle
2328         https://bugs.webkit.org/show_bug.cgi?id=51774
2329
2330         This script appears to not have been touched in a while and seems to
2331         have been replaced by check-webkit-style.
2332
2333         * Scripts/wkstyle: Removed.
2334
2335 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2336
2337         Unreviewed. Coding style fix.
2338
2339         * DumpRenderTree/chromium/TestShell.h:
2340
2341 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2342
2343         Reviewed by Pavel Feldman.
2344
2345         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2346
2347         It was a problem with Chromium DRT. DevToolsAgent object instance was
2348         attached not only to the inspected page but to the DevTools window too.
2349         As result all the inspector files were interpreted as a content of inspected page
2350         and were transfered to the DevTools scripts panel for debugging etc.
2351
2352         https://bugs.webkit.org/show_bug.cgi?id=51735
2353
2354         * DumpRenderTree/chromium/TestShell.cpp:
2355         (TestShell::TestShell):
2356         (TestShell::bindJSObjectsToWindow):
2357         (TestShell::createNewWindow):
2358         * DumpRenderTree/chromium/TestShell.h:
2359
2360 2010-12-31  Adam Barth  <abarth@webkit.org>
2361
2362         Rubber-stamped by Eric Seidel.
2363
2364         Move PageLoadTests to PerformanceTests/PageLoad
2365         https://bugs.webkit.org/show_bug.cgi?id=51771
2366
2367         Update references to PageLoadTests to point to the new location.
2368
2369         * Scripts/run-pageloadtest:
2370         * Scripts/webkitpy/common/config/build.py:
2371
2372 2010-12-31  Adam Barth  <abarth@webkit.org>
2373
2374         Rubber-stamped by Eric Seidel.
2375
2376         Move SunSpider into PerformanceTests
2377         https://bugs.webkit.org/show_bug.cgi?id=51769
2378
2379         Update these scripts to point to the new location.
2380
2381         * Scripts/run-sunspider:
2382         * Scripts/sunspider-compare-results:
2383
2384 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2385
2386         Reviewed by Kent Tamura.
2387
2388         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2389         https://bugs.webkit.org/show_bug.cgi?id=51728
2390         
2391         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2392         to render top-level scrollbars. This makes them match the Mac port's
2393         use of an NSScrollView, which means that we'll be able to share more
2394         pixel baselines.
2395         
2396         The new rendering code will not be activated until the 
2397         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2398         ScrollbarThemeChromiumMac.
2399
2400         * DumpRenderTree/DumpRenderTree.gypi:
2401         * DumpRenderTree/chromium/TestShellMac.mm:
2402         (platformInit):
2403         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2404         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2405         (+[FakeActiveWindow alwaysActiveWindow]):
2406         (+[FakeActiveWindow alwaysInactiveWindow]):
2407         (-[FakeActiveWindow initWithActiveControls:]):
2408         (-[FakeActiveWindow _hasActiveControls]):
2409         (WebThemeEngineDRTMac::paintScrollbarThumb):
2410         (stateToHIEnableState):
2411         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2412         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2413
2414 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2415
2416         Reviewed by David Kilzer.
2417
2418         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2419         used
2420         https://bugs.webkit.org/show_bug.cgi?id=51672
2421
2422         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2423         with USE_SYSTEM_MALLOC=1
2424         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2425         with USE_SYSTEM_MALLOC=1
2426
2427 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2428
2429         Reviewed by David Kilzer.
2430
2431         [Qt] [Symbian] Fix build-webkit script for Symbian
2432         https://bugs.webkit.org/show_bug.cgi?id=51509
2433
2434         Set the OUTPUT_DIR for Symbian to be the same as the source
2435         directory.
2436
2437         * Scripts/webkitdirs.pm:
2438
2439 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2440
2441         Reviewed by Darin Adler.
2442
2443         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2444         https://bugs.webkit.org/show_bug.cgi?id=51758
2445
2446         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2447
2448         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2449         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2450
2451 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2452
2453         Unreviewed WinCE buildfix.
2454
2455         * WinCELauncher/main.cpp: Add missing include.
2456
2457 2010-12-29  Daniel Bates  <dbates@rim.com>
2458
2459         Reviewed by Darin Adler.
2460
2461         svn-apply updates date of wrong change log entry for a change log diff that
2462         contains two consecutive entries with the same author and date
2463         https://bugs.webkit.org/show_bug.cgi?id=46061
2464
2465         Fixes an issue where the date of the wrong change log entry may be modified.
2466         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2467         in a ChangeLog file to the top of the file.
2468
2469         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2470         diff when it detects that the diff inserts a change log entry earlier in a
2471         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2472         change. With the advent of the commit-queue this functionality of bailing out
2473         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2474         Instead, we should always move the change log entry to the top of the ChangeLog file.
2475
2476         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2477         the date line of the correct change log entry in a ChangeLog diff.
2478
2479         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2480
2481         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2482           Updated the following unit tests now that we move entries inserted earlier to the top:
2483           - "fixChangeLogPatch: New entry inserted in middle."
2484             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2485
2486           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2487             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2488
2489         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2490
2491 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2492
2493         Reviewed by Eric Seidel.
2494
2495         [Qt] Fixed compatibility with gold linker on X11 platforms
2496         https://bugs.webkit.org/show_bug.cgi?id=51700
2497
2498         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2499         Linked TestNetscapePlugin with libX11 on Unix platforms
2500
2501 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2502
2503         Reviewed by Darin Adler.
2504
2505         Circular dependency in webkitpy.common.checkout.changelog module
2506         https://bugs.webkit.org/show_bug.cgi?id=50475
2507
2508         Remove automatic import of api.Checkout module when any checkout/
2509         submodule is imported (e.g.: when checkout.scm.Git is imported).
2510
2511         * Scripts/webkitpy/common/checkout/__init__.py:
2512
2513 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2514
2515         Reviewed by Ojan Vafai.
2516
2517         prepare-ChangeLog should support the -g option for specifying the git-commit
2518         https://bugs.webkit.org/show_bug.cgi?id=51708
2519
2520         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2521         webkit-patch, though the exact meaning of the two options remain different.
2522
2523         * Scripts/prepare-ChangeLog: Add -g.
2524
2525 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2526
2527         Reviewed by Simon Hausmann.
2528
2529         [Qt] Fix compilation with Qt in namespace
2530         https://bugs.webkit.org/show_bug.cgi?id=51701
2531
2532         * QtTestBrowser/webview.h:
2533
2534 2010-12-28  Daniel Bates  <dbates@rim.com>
2535
2536         Reviewed by Sam Weinig.
2537
2538         Substitute // MARK: for compiler-specific #pragma mark
2539         https://bugs.webkit.org/show_bug.cgi?id=51657
2540
2541         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2542         substituting  "// MARK:" for "#pragma mark", which provides
2543         analogous code-bookmarking functionality under Xcode.
2544
2545         Also, for consistency, we should substitute "// MARK:" for compiler-
2546         specific "#pragma mark" in the source files for the Mac port.
2547
2548         * DumpRenderTree/AccessibilityTextMarker.cpp:
2549         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2550         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2551         * DumpRenderTree/mac/ObjCController.m:
2552         * MiniBrowser/mac/AppDelegate.m:
2553         * MiniBrowser/mac/BrowserWindowController.m:
2554
2555 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2556
2557         Reviewed by Eric Seidel.
2558
2559         Add --no-build option to run-sunspider
2560         https://bugs.webkit.org/show_bug.cgi?id=51658
2561
2562         * Scripts/run-sunspider: add --no-build flag to skip building
2563         phase.
2564
2565 2010-12-27  Daniel Bates  <dbates@rim.com>
2566
2567         Rubber-stamped by Martin Robinson.
2568
2569         Append the directory Tools/DumpRenderTree to the list of directories that
2570         do-webcore-rename should search so that it can rename DRT files and
2571         source code.
2572
2573         * Scripts/do-webcore-rename:
2574
2575 2010-12-27  Eric Seidel  <eric@webkit.org>
2576
2577         Reviewed by Adam Barth.
2578
2579         build-webkit should detect missing Java SDK and explain how to install it
2580         https://bugs.webkit.org/show_bug.cgi?id=51651
2581
2582         * Scripts/build-webkit:
2583
2584 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2585
2586         Reviewed by Daniel Bates.
2587
2588         [GTK] Add support for build-jsc
2589         https://bugs.webkit.org/show_bug.cgi?id=51625
2590
2591         Add GTK+ support to build-jsc now that building the jsc executable as
2592         a standalone target is easy.
2593
2594         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2595         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2596         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2597         and pass it along to buildAutotoolsProject.
2598
2599 2010-12-27  David Levin  <levin@chromium.org>
2600
2601         Reviewed by Eric Seidel.
2602
2603         check-webkit-style check for meaningless variable names in function declarations.
2604         https://bugs.webkit.org/show_bug.cgi?id=51523
2605
2606         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2607         from the new check and whitespace/parens because the syntax is unusual and
2608         produced a fair number of positives for these checks.
2609         * Scripts/webkitpy/style/checkers/cpp.py:
2610         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2611         and parameter names when determining if the parameter name is useless.
2612         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2613         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2614         format.
2615         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2616         text or an acronym of it.
2617         (check_function_definition): Checks function definitions for meaningless variable names.
2618         (process_line): Added call to check_function_definition.
2619         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2620         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2621         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2622         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2623         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2624         because when only checking a snippet, there are a lot of bogus functions.
2625         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2626         that I put there previously and just noticed.
2627         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2628         check_function_definition and process_line.
2629
2630 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2631
2632         Reviewed by Martin Robinson.
2633
2634         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2635         https://bugs.webkit.org/show_bug.cgi?id=51591
2636
2637         Flash plugin uses gtk2 that is incompatible with gtk3 making
2638         webkit crash when it's built with gtk3.
2639
2640         * GtkLauncher/main.c:
2641         (main):
2642
2643 2010-12-25  Adam Barth  <abarth@webkit.org>
2644
2645         Reviewed by Eric Seidel.
2646
2647         Move ANGLE to Sources/ThirdParty
2648         https://bugs.webkit.org/show_bug.cgi?id=51605
2649
2650         * Scripts/build-webkit:
2651           - Point to the new ANGLE location.
2652
2653 2010-12-26  David Levin  <levin@chromium.org>
2654
2655         Reviewed by Eric Seidel.
2656
2657         check-webkit-style should be able to parse function declaration parameters.
2658         https://bugs.webkit.org/show_bug.cgi?id=51451
2659
2660         * Scripts/webkitpy/style/checkers/cpp.py:
2661         (Position.__init__): Holds simple position information (row, column).
2662         (Parameter.__init__): Holds information about a parameter.
2663         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2664         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2665         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2666         (find_parameter_name_index): Finds where the parameter name is.
2667         (parameter_list): Generates the list of parameters for a function.
2668         (_FunctionState.begin): Added information to allow determining the parameters
2669         on demand.
2670         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2671         (detect_functions): Improve function detection for operator functions and
2672         determine where the parameters end and pass that to _FunctionState.begin.
2673         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2674         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2675         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2676         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2677         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2678         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2679         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2680         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2681         the parameters found.
2682         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2683         detection test to verify that we catch the operator functions.
2684         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2685         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2686         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2687         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2688         test_function_length_check_definition_severity1_for_test.
2689
2690 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2691
2692         Unreviewed WinCE buildfix after r74334.
2693
2694         * CMakeListsWinCE.txt:
2695
2696 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2697
2698         Unreviewed, rolling out r74632.
2699         http://trac.webkit.org/changeset/74632
2700         https://bugs.webkit.org/show_bug.cgi?id=51600
2701
2702         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2703         on #webkit).
2704
2705         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2706         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2707
2708 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2709
2710         Reviewed by Kenneth Rohde Christiansen.
2711
2712         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2713         https://bugs.webkit.org/show_bug.cgi?id=43528
2714
2715         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2716         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2717         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2718         called.
2719
2720         * EWebLauncher/main.c:
2721         (browserCreate):
2722
2723 2010-12-24  Eric Seidel  <eric@webkit.org>
2724
2725         Reviewed by Adam Barth.
2726
2727         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2728         https://bugs.webkit.org/show_bug.cgi?id=28291
2729
2730         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2731         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2732         to strings with find in the diff.
2733         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2734
2735         * Scripts/webkitpy/common/checkout/api.py:
2736         * Scripts/webkitpy/common/checkout/diff_parser.py:
2737         * Scripts/webkitpy/tool/steps/abstractstep.py:
2738         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2739         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2740         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2741         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2742
2743 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2744
2745         Reviewed by Kenneth Russell.
2746
2747         Modify new-run-webkit-tests to shut up and exit when all the threads
2748         are wedged so that test runs complete faster and we don't end up
2749         w/ enormous log files.
2750
2751         https://bugs.webkit.org/show_bug.cgi?id=51572
2752
2753         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2754         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2755
2756 2010-12-24  Eric Seidel  <eric@webkit.org>
2757
2758         Reviewed by David Levin.
2759
2760         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2761         https://bugs.webkit.org/show_bug.cgi?id=51549
2762
2763         I've had multiple people ask me about the commit-queue's behavior
2764         regarding reporting flaky tests.  I figured it would be best to just
2765         have the queue explain itself in the bugs it files.
2766
2767         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2768         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2769
2770 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2771
2772         Reviewed by Eric Seidel.
2773
2774         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2775         https://bugs.webkit.org/show_bug.cgi?id=51467
2776
2777         * Scripts/webkitpy/style/checker.py:
2778         * Scripts/webkitpy/style/checker_unittest.py:
2779
2780 2010-12-23  Adam Barth  <abarth@webkit.org>
2781
2782         Rubber-stamped by Eric Seidel.
2783
2784         Move JavaScriptGlue into Sources
2785         https://bugs.webkit.org/show_bug.cgi?id=51583
2786
2787         These tools refer to JavaScriptGlue and need to be updated to its new
2788         location.
2789
2790         * Scripts/build-webkit:
2791         * Scripts/do-file-rename:
2792         * Scripts/do-webcore-rename:
2793         * Scripts/webkitpy/common/config/build.py:
2794         * Scripts/webkitpy/common/config/build_unittest.py:
2795
2796 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2797
2798         Reviewed by Eric Seidel.
2799
2800         Bug 51539 - update iexploder scripts to point to new location
2801
2802         * Scripts/run-iexploder-tests:
2803         * Scripts/update-iexploder-cssproperties:
2804
2805 2010-12-23  Evan Martin  <evan@chromium.org>
2806
2807         Reviewed by Ryosuke Niwa.
2808
2809         [chromium] LayoutTestController warning in float->int conversion
2810         https://bugs.webkit.org/show_bug.cgi?id=51553
2811
2812         Rather than reading an int, converting to a float, then getting a compiler
2813         warning on passing the float to something that expects an int, instead
2814         just pass around ints.
2815
2816         No tests, fixes a compiler warning.
2817
2818         * DumpRenderTree/chromium/LayoutTestController.cpp:
2819         (parsePageSizeParameters):
2820         (LayoutTestController::pageNumberForElementById):
2821         (LayoutTestController::numberOfPages):
2822
2823 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2824
2825         Reviewed by Darin Adler.
2826
2827         Bug 51537 - iexploder needs cleanup
2828         
2829         * iExploder/htdocs: Removed.
2830         * iExploder/htdocs/config.rb: Removed.
2831         * iExploder/htdocs/cssproperties.in: Removed.
2832         * iExploder/htdocs/cssvalues.in: Removed.
2833         * iExploder/htdocs/htmlattrs.in: Removed.
2834         * iExploder/htdocs/htmltags.in: Removed.
2835         * iExploder/htdocs/htmlvalues.in: Removed.
2836         * iExploder/htdocs/iexploder.cgi: Removed.
2837         * iExploder/htdocs/iexploder.rb: Removed.
2838         * iExploder/htdocs/index.html: Removed.
2839         * iExploder/htdocs/webserver.rb: Removed.
2840         * iExploder/iexploder-1.7.2/output: Removed.
2841         * iExploder/tools: Removed.
2842         * iExploder/tools/lasthit.rb: Removed.
2843         * iExploder/tools/osx_last_crash.rb: Removed.
2844         * iExploder/tools/showtest.rb: Removed.
2845
2846 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2847
2848         Reviewed by Kenneth Rohde Christiansen.
2849
2850         [EFL] Make 'single' the default backing store in EWebLauncher
2851         https://bugs.webkit.org/show_bug.cgi?id=51534
2852
2853         'single' is the simplest backing store and the one intended to be the
2854         default in the test browser. By mistake the tiled backing store was
2855         left as default in r72617.
2856
2857         * EWebLauncher/main.c:
2858         (browserCreate): ditto.
2859
2860 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2861
2862         Reviewed by Kenneth Rohde Christiansen.
2863
2864         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2865         https://bugs.webkit.org/show_bug.cgi?id=51533
2866
2867         There's no point in concatenating env("HOME") with "blah", so remove
2868         option from EWebLauncher.
2869
2870         * EWebLauncher/main.c:
2871         (main): ditto.
2872
2873 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2874
2875         Reviewed by Eric Seidel.
2876
2877         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2878
2879         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2880         I just discovered that we have two additional GC runs per each WebViewHost.
2881         Test_shell had no such calls.
2882         These gc runs eat 15% of cpu time.
2883
2884         https://bugs.webkit.org/show_bug.cgi?id=51479
2885
2886         * DumpRenderTree/chromium/WebViewHost.cpp:
2887         (WebViewHost::~WebViewHost):
2888
2889 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2890
2891         Reviewed by Ojan Vafai.
2892
2893         This change splits out the TestRunner class into its own file.
2894         When we fork the code for message passing, we will create a new
2895         TestRunner, and this change will allow that to be more modular.
2896
2897         While we're at it, split out TestInput and ResultSummary into
2898         their own files, to reduce the size of run_webkit_tests to
2899         something more managable.
2900
2901         https://bugs.webkit.org/show_bug.cgi?id=51092
2902
2903         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2904         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2905         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2906         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2907         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2908         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2909         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2910
2911  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2912
2913         Reviewed by Ojan Vafai.
2914
2915         nrwt multiprocessing - start over, prepare to fork the code
2916  
2917         This code cleans up the signatures and implementation of the
2918         TestRunner class so we can easily fork it to run either the
2919         stable implementation or the new, unstable message-passing
2920         implementation. The two variants will have different
2921         implementations of the run_tests() method. We will switch
2922         between the two based on the setting for the '--worker-model'
2923         switch. We rename the two currently valid values to 'old-inline'
2924         and 'old-threads'.
2925
2926         https://bugs.webkit.org/show_bug.cgi?id=51081
2927
2928         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2929         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2930
2931 2010-12-22  Victor Wang  <victorw@chromium.org>
2932
2933         Reviewed by Darin Fisher.
2934
2935         [Chromium] Update chromium archive test result url in rebaseline script.
2936
2937         https://bugs.webkit.org/show_bug.cgi?id=51503
2938
2939         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2940
2941 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2942
2943         Reviewed by Alice Liu.
2944
2945         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2946         Verified on Chrome, Safari, and IE.
2947         With this change, we will record memory from a parent browser window and all child processes.
2948
2949         * record-memory-win/main.cpp:
2950         (ProcessArgs):
2951         (PrintUsage):
2952         (getMemoryInfo):
2953         (printProcessInfo):
2954         (evalProcesses):
2955         (UseImage):
2956         (QueryContinuously):
2957         (ElapsedTime):
2958
2959 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2960
2961         Unreviewed rollout r74489, because it was missing changelog.
2962
2963         * record-memory-win/main.cpp:
2964         
2965 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2966
2967         Adding myself as a reviewer.
2968
2969         * Scripts/webkitpy/common/config/committers.py:
2970
2971 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2972
2973         Unreviewed.  Adding myself to committers.py.
2974
2975         * Scripts/webkitpy/common/config/committers.py:
2976
2977 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2978
2979         Reviewed by Kenneth Rohde Christiansen.
2980
2981         TestNetscapePlugIn should use #if defined
2982         https://bugs.webkit.org/show_bug.cgi?id=51471
2983
2984         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2985         (NP_Initialize):
2986         (NPP_New):
2987
2988 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2989
2990         Reviewed by Yury Semikhatsky.
2991
2992         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2993
2994         DevTools window should be closed explicitly because it has custom deinitialization code.
2995
2996         https://bugs.webkit.org/show_bug.cgi?id=50722
2997
2998         * DumpRenderTree/chromium/TestShell.cpp:
2999         (TestShell::closeRemainingWindows):
3000
3001 2010-12-22  David Levin  <levin@chromium.org>
3002
3003         Reviewed by Shinichiro Hamaji.
3004
3005         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3006         https://bugs.webkit.org/show_bug.cgi?id=51452
3007
3008         * Scripts/webkitpy/style/checkers/cpp.py:
3009         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3010         Using the file extension if possible but falling back to the file contents if we have a header file.
3011         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3012         (_FileState.is_c_or_objective_c):
3013         (check_using_std): Changed to using _FileState to determine the file type.
3014         (check_max_min_macros): Ditto.
3015         (check_for_null): Ditto.
3016         (check_style): Changed the parameters to various calls since they now need _FileState
3017         to determine the file type.
3018         (check_language): Added the file_state parameter so it could be passed
3019         to check_identifier_name_in_declaration.
3020         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3021         this is an Objective C file.
3022         (_process_lines): Added information for the _FileState constructor (and moved the
3023         call to a place that had the information).
3024         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3025         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3026         its functionality.
3027         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3028
3029 2010-12-21  Andy Estes  <aestes@apple.com>
3030
3031         Reviewed by Mark Rowe.
3032
3033         Do not build non-Intel architectures for WebKit2-related projects.
3034         https://bugs.webkit.org/show_bug.cgi?id=51440
3035
3036         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3037         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3038         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3039
3040 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3041
3042         Reviewed by Darin Fisher.
3043
3044         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3045         https://bugs.webkit.org/show_bug.cgi?id=51406 
3046         
3047         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3048         to WebThemeEngineDRTWin and update references everywhere.
3049
3050         * DumpRenderTree/DumpRenderTree.gypi:
3051         * DumpRenderTree/chromium/TestShellWin.cpp:
3052         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3053         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3054         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3055         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3056
3057 2010-12-21  Anders Carlsson  <andersca@apple.com>
3058
3059         Reviewed by John Sullivan.
3060
3061         Clicking missing plug-in text does not show a sheet
3062         https://bugs.webkit.org/show_bug.cgi?id=51403
3063
3064         Update for changes to the WebPageUIClient.
3065
3066         * MiniBrowser/mac/BrowserWindowController.m:
3067         (-[BrowserWindowController awakeFromNib]):
3068         * WebKitTestRunner/TestController.cpp:
3069         (WTR::createOtherPage):
3070         (WTR::TestController::initialize):
3071
3072 2010-12-21  Eric Seidel  <eric@webkit.org>
3073
3074         Reviewed by Adam Barth.
3075
3076         commit-queue will report constant failures as flaky if other tests flake
3077         https://bugs.webkit.org/show_bug.cgi?id=51272
3078
3079         This patch just removes functionality and adds testing.
3080         Previously we attempted to report flaky tests when we had
3081         two different tests fail in a row.  However, since we stop
3082         running the tests at the first failure, our code was wrong in
3083         trying to determine flakiness from the incomplete runs.
3084
3085         Originally I posted an alternate patch:
3086         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3087         which fixed our flaky logic in this case, however it was decided
3088         that that patch would be too difficult to maintain, so now
3089         I'm just removing the broken logic.
3090
3091         This will dramatically cut-down on our flaky-test false positives
3092         at the (small) cost of the queues being unable to report
3093         any flakiness if the tree is very flaky.  (With at least one test
3094         flaking on every run, we'll never report failures anymore.)  I think
3095         this is a tradeoff worth making.
3096
3097         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3098         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3099
3100 2010-12-20  Eric Seidel  <eric@webkit.org>
3101
3102         Reviewed by Adam Barth.
3103
3104         commit-queue wrongly rejects patches when it can't update itself
3105         https://bugs.webkit.org/show_bug.cgi?id=46636
3106
3107         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3108         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3109         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3110
3111 2010-12-20  Adam Barth  <abarth@webkit.org>
3112
3113         Move web sites to Websites directory
3114         https://bugs.webkit.org/show_bug.cgi?id=51323
3115
3116         Update references to BugsSite to point to the new location.
3117
3118         This patch was never officially reviewed (because it was too large to
3119         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3120         Rowe gave me the green light.
3121
3122         * Scripts/old-run-webkit-tests:
3123         * Scripts/webkitpy/common/config/build.py:
3124         * Scripts/webkitpy/common/config/build_unittest.py:
3125         * Scripts/webkitpy/common/prettypatch.py:
3126         * Scripts/webkitpy/layout_tests/port/base.py:
3127         * Scripts/webkitpy/style/main.py:
3128
3129 2010-12-20  Adrienne Walker  <enne@google.com>
3130
3131         Unreviewed. Adding myself to the list of committers.
3132
3133         * webkitpy/common/config/committers.py:
3134
3135 2010-12-20  Mark Rowe  <mrowe@apple.com>
3136
3137         Reviewed by Dan Bernstein.
3138
3139         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3140
3141         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3142         Resources directory.
3143
3144 2010-12-20  Eric Seidel  <eric@webkit.org>
3145
3146         Reviewed by Adam Barth.
3147
3148         commit-queue should include bot id when attaching failure diffs
3149         https://bugs.webkit.org/show_bug.cgi?id=51280
3150
3151         This is a tiny change to include the bot id in the name of the attachment.
3152         Most of this diff is just changing the unit test expectations
3153         now that I hid the comment printing when the comment is None.
3154
3155         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3156         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3157         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3158         * Scripts/webkitpy/tool/mocktool.py:
3159
3160 2010-12-20  Jeff Miller  <jeffm@apple.com>
3161
3162         Reviewed by Dan Bernstein.
3163
3164         Tools/vcbin/midl.exe needs to be rebuilt
3165         https://bugs.webkit.org/show_bug.cgi?id=51347
3166
3167         * vcbin/midl.exe: Rebuilt.
3168
3169 2010-12-20  David Levin  <levin@chromium.org>
3170
3171         Reviewed by Ariya Hidayat.
3172
3173         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3174         https://bugs.webkit.org/show_bug.cgi?id=51343
3175
3176         Follow up from the WebKitTools -> Tools rename.
3177
3178         * Scripts/webkit-tools-completion.sh:
3179
3180 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3181
3182         Reviewed by James Robinson.
3183
3184         new-run-webkit-tests ignores trailing EOL differences in text tests
3185         https://bugs.webkit.org/show_bug.cgi?id=36983
3186
3187         Changed the handling of new-line characters within new-run-webkit-tests
3188         to match old-run-webkit-tests.  Differences in leading and trailing empty
3189         lines in text expectation files are no longer ignored.
3190
3191         * Scripts/webkitpy/layout_tests/port/base.py:
3192         * Scripts/webkitpy/layout_tests/port/test.py:
3193         Added unit tests.  Removed old duplicate unit test entries.
3194         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3195
3196 2010-12-20  David Levin  <levin@chromium.org>
3197
3198         Reviewed by Shinichiro Hamaji.
3199
3200         check-webkit-style should detect function declarations (and trivial functions).
3201         https://bugs.webkit.org/show_bug.cgi?id=51303
3202
3203         * Scripts/webkitpy/style/checkers/cpp.py:
3204         (_FunctionState.begin): Add is_declaration and changed the line count
3205         start to begin at -1 (which will keep the results consistent, since
3206         the starting line number passed in is one less in this change).
3207         (detect_functions): changed function detection to now catch trivial
3208         functions and declarations.
3209         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3210         of the function as this may look at return values (when processing
3211         a declaration).
3212         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3213         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3214         of testing the function detection.
3215         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3216         function.
3217         (FunctionDetectionTest.test_function_declaration_detection): Test a
3218         declaration.
3219         (FunctionDetectionTest.test_non_functions): A test case for a case
3220         that caused the code to fail due to the { being in quotes.
3221         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3222         cases to help catch false alarms for return values.
3223         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3224         we don't get false alarms for member variables either.
3225
3226 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3227
3228         Reviewed by Antonio Gomes.
3229
3230         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3231         https://bugs.webkit.org/show_bug.cgi?id=51319
3232
3233         * CMakeListsEfl.txt:
3234
3235 2010-12-18  Adam Barth  <abarth@webkit.org>
3236
3237         Reviewed by Sam Weinig.
3238
3239         Move WebKitExamplePlugins to Examples
3240         https://bugs.webkit.org/show_bug.cgi?id=51291
3241
3242         * Scripts/webkitpy/common/config/build.py:
3243
3244 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3245
3246         Unreviewed Qt buildfix after r74301.
3247
3248         Rename WebKitTools to Tools
3249         https://bugs.webkit.org/show_bug.cgi?id=49861
3250
3251         * MiniBrowser/DerivedSources.pro:
3252         * MiniBrowser/qt/MiniBrowser.pro:
3253
3254 2010-12-17  Dan Bernstein  <mitz@apple.com>
3255
3256         Reviewed by Simon Fraser.
3257
3258         Rename WebKitTools to Tools
3259         https://bugs.webkit.org/show_bug.cgi?id=49861
3260
3261         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3262         * CodeCoverage/README:
3263         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3264         (WebCore::DumpRenderTree::initializeFonts):
3265         * EWSTools/start-commit-queue.sh:
3266         * EWSTools/start-queue.sh:
3267         * GNUmakefile.am:
3268         * MIDLWrapper/MIDLWrapper.cpp:
3269         (wmain):
3270         * MiniBrowser/qt/MiniBrowser.pro:
3271         * Scripts/build-api-tests:
3272         * Scripts/build-dumprendertree:
3273         * Scripts/build-webkit:
3274         * Scripts/build-webkittestrunner:
3275         * Scripts/generate-coverage-data:
3276         * Scripts/old-run-webkit-tests:
3277         * Scripts/run-api-tests:
3278         * Scripts/run-iexploder-tests:
3279         * Scripts/run-javascriptcore-tests:
3280         * Scripts/run-mangleme-tests:
3281         * Scripts/run-sunspider:
3282         * Scripts/run-webkit-websocketserver:
3283         * Scripts/sunspider-compare-results:
3284         * Scripts/test-webkitperl:
3285         * Scripts/test-webkitpy:
3286         * Scripts/update-iexploder-cssproperties:
3287         * Scripts/update-webkit:
3288         * Scripts/update-webkit-localizable-strings:
3289         * Scripts/webkitdirs.pm:
3290         * Scripts/webkitpy/common/checkout/scm.py:
3291         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3292         * Scripts/webkitpy/common/config/committervalidator.py:
3293         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3294         * Scripts/webkitpy/common/config/ports.py:
3295         * Scripts/webkitpy/common/config/ports_unittest.py:
3296         * Scripts/webkitpy/common/system/logutils_unittest.py:
3297         * Scripts/webkitpy/common/system/ospath_unittest.py:
3298         * Scripts/webkitpy/layout_tests/port/chromium.py:
3299         * Scripts/webkitpy/layout_tests/port/config.py:
3300         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3301         * Scripts/webkitpy/layout_tests/port/http_server.py:
3302         * Scripts/webkitpy/layout_tests/port/test.py:
3303         * Scripts/webkitpy/style/checker.py:
3304         * Scripts/webkitpy/style/checker_unittest.py:
3305         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3306         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3307         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3308         * WebKitTestRunner/DerivedSources.pro:
3309         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3310         (WTR::activateFonts):
3311         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3312         * wx/build/build_utils.py:
3313
3314 2010-12-16  Antonio Gomes  <agomes@rim.com>
3315
3316         Reviewed by Martin Robinson.
3317
3318         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3319         https://bugs.webkit.org/show_bug.cgi?id=51163
3320
3321         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3322         GTK+'s DRT should also reset to UNIX after each test execution.
3323
3324         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3325         (resetDefaultsToConsistentValues):
3326
3327 2010-12-17  David Levin  <levin@chromium.org>
3328
3329         Reviewed by Eric Seidel.
3330
3331         check-webkit-style should understand WTF #include guards
3332         https://bugs.webkit.org/show_bug.cgi?id=44911
3333
3334         * Scripts/webkitpy/style/checkers/cpp.py:
3335         (get_header_guard_cpp_variable): modify to suggest the WTF style
3336         of header guard when appropriate.
3337         (check_for_header_guard): handle multiple return values from
3338         get_header_guard_cpp_variable
3339         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3340         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3341         header style.
3342
3343 2010-12-16  David Levin  <levin@chromium.org>
3344
3345         Reviewed by Eric Seidel.
3346
3347         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3348         https://bugs.webkit.org/show_bug.cgi?id=51210
3349
3350         The error only shows up when using python 2.6 or later.
3351
3352         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3353         the decprecated field error,message with something equivalent.
3354
3355 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3356
3357         Reviewed by Eric Seidel.
3358
3359         Add --exit-after-n-failures/crashes to NRWT
3360         https://bugs.webkit.org/show_bug.cgi?id=51160
3361         
3362         Abort test run (in a similar way to how control-C is handled) when
3363         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3364         that number of unexpected failures/crashes/timeouts.
3365
3366         * Scripts/webkitpy/layout_tests/port/test.py:
3367         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3368         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3369
3370 2010-12-16  David Levin  <levin@chromium.org>
3371
3372         Reviewed by Shinichiro Hamaji.
3373
3374         check-webkit-style unit tests has some duplicate boilerplate code.
3375         https://bugs.webkit.org/show_bug.cgi?id=49519
3376
3377         * Scripts/webkitpy/style/checkers/cpp.py:
3378         (update_include_state): Replaced the "io" parameter with the global
3379         configuration _unit_test_config. This allowed not calling into
3380         functions at a low level and also not plumbing through the injection
3381         information through many levels of code.
3382         (check_for_include_what_you_use): Ditto.
3383         (process_file_data): Added the ability to set up the unit test config
3384         to allow for injection.
3385         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3386         (ErrorCollector.__init__): Added support for having a filter for errors.
3387         (ErrorCollector.__call__): Ditto.
3388         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3389         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3390         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3391         functions in the cpp.py with generic processing and a filter that
3392         indicates what errors should be kept.
3393         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3394         (CppStyleTestBase.perform_language_rules_check): Ditto.
3395         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3396         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3397         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3398         (CppStyleTest.test_multi_line_comments): Added another
3399         error message which applies to the test case.
3400         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3401         to not have config.h, since it is processed as a header file.
3402         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3403         style and indentation in checked code.
3404         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3405         Fixed line number.
3406         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3407         Ditto.
3408
3409 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3410
3411         Unreviewed, rolling out r74136.
3412         http://trac.webkit.org/changeset/74136
3413         https://bugs.webkit.org/show_bug.cgi?id=51135
3414
3415         r74136 breaks chromium canary bots because some tests are not
3416         rebaselined correctly to resolve EOL differences (Requested by
3417         jianli on #webkit).
3418
3419         * Scripts/webkitpy/layout_tests/port/base.py:
3420         * Scripts/webkitpy/layout_tests/port/test.py:
3421         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3422
3423 2010-12-15  Adam Roben  <aroben@apple.com>
3424
3425         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3426         syntax errors
3427
3428         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3429         XML syntax errors in .vcproj/.vsprops files
3430
3431         Reviewed by Dave Levin.
3432
3433         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3434         that should be treated as XML and that should be allowed to contain
3435         carriage returns. (These lists happen to be identical currently.)
3436         (FileType): Added a new XML type.
3437         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3438         Just does a simple file extension check.
3439         (CheckerDispatcher._file_type): Added a case for XML files.
3440         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3441         files (surprise!).
3442         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3443         lines through the carriage checker.
3444
3445         * Scripts/webkitpy/style/checker_unittest.py:
3446         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3447         Added. Checks a few file names to see if carriage returns are allowed
3448         or not.
3449         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3450         other assert_checker_* functions.
3451         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3452         test_*_paths functions.
3453         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3454         test_*_paths functions.
3455         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3456         file from this test case, as vcproj files now have a type.
3457         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3458         Added. Similar to the other should_* functions.
3459         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3460         Added. Checks that carriage returns aren't checked for or stripped for
3461         allowed files.
3462
3463         * Scripts/webkitpy/style/checkers/xml.py: Added.
3464         (XMLChecker.__init__): Simple init method.
3465         (XMLChecker.check): Pass each line through the expat parser, and record
3466         a style error for any errors thrown by the parser.
3467
3468         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3469         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3470         produce a style error.
3471         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3472         error of the given category on the given line.
3473         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3474         checking that the XMLChecker constructor works properly.
3475         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3476         cause a style error (see, e.g., r73887).
3477         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3478         cause a style error (see, e.g., r73773).
3479         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3480         properly.
3481         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3482         tags cause a style error (see, e.g., r72795).
3483         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3484         style error.
3485
3486 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3487
3488         Reviewed by Stephanie Lewis.
3489
3490         https://bugs.webkit.org/show_bug.cgi?id=51117
3491         Add a new leopard test bot
3492         really really commit to trunk this time.
3493
3494         * BuildSlaveSupport/build.webkit.org-config/config.json:
3495
3496 2010-12-15  Sam Weinig  <sam@webkit.org>
3497
3498         Reviewed by Anders Carlsson.
3499
3500         WebKit2: Can't add files to an <input type=file>
3501         https://bugs.webkit.org/show_bug.cgi?id=51087
3502
3503         * MiniBrowser/mac/BrowserWindowController.m:
3504         (runOpenPanel):
3505         (-[BrowserWindowController awakeFromNib]):
3506         Add simple implementation of runOpenPanel callback.
3507
3508         * MiniBrowser/win/BrowserView.cpp:
3509         (BrowserView::create):
3510         * WebKitTestRunner/TestController.cpp:
3511         (WTR::createOtherPage):
3512         (WTR::TestController::initialize):
3513         Stub out runOpenPanel callback. 
3514
3515 2010-12-14  Eric Seidel  <eric@webkit.org>
3516
3517         Reviewed by Adam Barth.
3518
3519         commit-queue should upload failure diffs when tests flake
3520         https://bugs.webkit.org/show_bug.cgi?id=51051
3521
3522         To make this testable I needed to pipe FileSystem down onto tool.
3523         We've wanted it there for a long time anyway.
3524
3525         This patch is kinda a big hack.  But we don't have a nice
3526         way to read results.html files.  I think this will need further
3527         revision before this code actually feels clean.
3528
3529         As part of testing this change, I had to make MockBugzilla.create_bug
3530         actually return an id (like it should) which required updating
3531         a few other unit test results (for the better).
3532
3533         The results_matching_keys change in layouttestresults/rebasline
3534         was an alternate path which I decided not to use in the end, but
3535         I left the change as it seemed an improvement.
3536
3537         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3538         * Scripts/webkitpy/common/net/layouttestresults.py:
3539         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3540         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3541         * Scripts/webkitpy/tool/commands/queues.py:
3542         * Scripts/webkitpy/tool/commands/rebaseline.py:
3543         * Scripts/webkitpy/tool/main.py:
3544         * Scripts/webkitpy/tool/mocktool.py:
3545
3546 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3547
3548         Reviewed by James Robinson.
3549
3550         new-run-webkit-tests ignores trailing EOL differences in text tests
3551         https://bugs.webkit.org/show_bug.cgi?id=36983
3552
3553         Changed the handling of new-line characters within new-run-webkit-tests
3554         to match old-run-webkit-tests.  Differences in leading and trailing empty
3555         lines in text expectation files are no longer ignored.
3556
3557         * Scripts/webkitpy/layout_tests/port/base.py:
3558         * Scripts/webkitpy/layout_tests/port/test.py:
3559         Added unit tests.  Removed old duplicate unit test entries.
3560         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3561
3562 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3563
3564         Reviewed by Adam Barth.
3565
3566         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3567         https://bugs.webkit.org/show_bug.cgi?id=51149
3568
3569         * QueueStatusServer/templates/statusbubble.html:
3570
3571 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3572
3573         Reviewed by Adam Barth.
3574
3575         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3576         https://bugs.webkit.org/show_bug.cgi?id=51125
3577
3578         * QueueStatusServer/templates/statusbubble.html:
3579
3580 2010-12-15  Darin Adler  <darin@apple.com>
3581
3582         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3583
3584 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3585
3586         Unreviewed, rolling out r74117.
3587         http://trac.webkit.org/changeset/74117
3588         https://bugs.webkit.org/show_bug.cgi?id=51113
3589
3590         This broke the GTK1 build. (Requested by mrobinson on
3591         #webkit).
3592
3593         * Scripts/webkitdirs.pm:
3594
3595 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3596
3597         Reviewed by Martin Robinson.
3598
3599         Change generate-forwarding-headers.pl for GTK port usage 
3600         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3601
3602         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3603
3604 2010-12-14  Kent Tamura  <tkent@chromium.org>
3605
3606         Reviewed by Jian Li.
3607
3608         [DRT/Chromium] Remove another unnecessary error message
3609         https://bugs.webkit.org/show_bug.cgi?id=51083
3610
3611         * DumpRenderTree/chromium/WebViewHost.cpp:
3612         (WebViewHost::didInvalidateRect):
3613
3614 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3615
3616         Reviewed by Stephanie Lewis.
3617
3618         Add a new Leopard Debug Test WK2 Bot
3619
3620         * BuildSlaveSupport/build.webkit.org-config/config.json:
3621
3622 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3623
3624         Fix python unittests after http://trac.webkit.org/changeset/74070.
3625
3626         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3627
3628 2010-12-14  Kent Tamura  <tkent@chromium.org>
3629
3630         Reviewed by Jian Li.
3631
3632         [DRT/Chromium] Remove a unnecessary error message
3633         https://bugs.webkit.org/show_bug.cgi?id=51069
3634
3635         * DumpRenderTree/chromium/WebViewHost.cpp:
3636         (WebViewHost::paintInvalidatedRegion):
3637
3638 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3639
3640         Reviewed by Ojan Vafai.
3641
3642         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3643         https://bugs.webkit.org/show_bug.cgi?id=48926
3644
3645         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3646         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3647
3648 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3649
3650         Reviewed by Eric Seidel.
3651
3652         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3653         https://bugs.webkit.org/show_bug.cgi?id=50231
3654
3655         Guard CONFIG+=link_pkgconfig with !symbian.
3656
3657         * DumpRenderTree/qt/DumpRenderTree.pro:
3658         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3659         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3660
3661 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3662
3663         Reviewed by Ojan Vafai.
3664
3665         [new-run-webkit-tests] expectations parsing is slow
3666         https://bugs.webkit.org/show_bug.cgi?id=50635
3667
3668         Avoid expensive iteration of all the tests when checking if a test
3669         file is to be skipped or not.
3670
3671         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3672         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3673         * Scripts/webkitpy/layout_tests/port/test.py:
3674
3675 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3676
3677         Reviewed by Xan Lopez.
3678
3679         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3680         https://bugs.webkit.org/show_bug.cgi?id=27048
3681
3682         Add support in DRT for checking whether an accessibility UI
3683         element is focusable and/or focused. Implemented for GTK.
3684
3685         * DumpRenderTree/AccessibilityUIElement.cpp:
3686         (getIsFocusedCallback): New.
3687         (getIsFocusableCallback): New.
3688         (AccessibilityUIElement::getJSClass): Add the new available
3689         callbacks for isFocused and isFocusable.
3690         * DumpRenderTree/AccessibilityUIElement.h:
3691         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3692         (AccessibilityUIElement::isFocused): New, implemented by checking
3693         whether the related AtkState value is in the object's state set.
3694         (AccessibilityUIElement::isFocusable): Ditto.
3695         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3696         (AccessibilityUIElement::isFocused): New, dummy implementation.
3697         (AccessibilityUIElement::isFocusable): Ditto.
3698         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3699         (AccessibilityUIElement::isFocused): Ditto.
3700         (AccessibilityUIElement::isFocusable): Ditto.
3701
3702 2010-12-14  Eric Seidel  <eric@webkit.org>
3703
3704         Reviewed by Ojan Vafai.
3705
3706         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3707         https://bugs.webkit.org/show_bug.cgi?id=50715
3708
3709         This patch makes webkit-patch print the following:
3710
3711         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3712         Install a 64-bit git for better performance, see:
3713         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3714
3715         I wrote this mostly because I have approximately 8 machines that I use
3716         and making sure each one is using a good Git install seemed folly.
3717         webkit-patch makes a lot of git calls, so using a fast git can shave
3718         several seconds in every invocation.  See the webkit-dev thread for more info.
3719
3720         This message will print twice during 'webkit-patch upload',
3721         once from webkit-patch and once from check-webkit-style.
3722
3723         Unfortunately there is no good way to test this due to how machine-dependent
3724         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3725
3726         * Scripts/webkitpy/common/checkout/scm.py:
3727
3728 2010-12-13  Eric Seidel  <eric@webkit.org>
3729
3730         Reviewed by Adam Barth.
3731
3732         FlakyTestReporter doesn't understand bots running from multiple email addresses
3733         https://bugs.webkit.org/show_bug.cgi?id=50960
3734
3735         This explains at least one of the dupes of:
3736         https://bugs.webkit.org/show_bug.cgi?id=50863
3737         that we saw filed by the commit-queue this morning.
3738         I think the other one was explained by my previous fix to result counting code.
3739
3740         Since this is really hard to test with a unit test, instead I
3741         create a new (possibly useful in the future) command
3742         which given a layout test path will return you
3743         the one bug which our tools would assume it the flaky test bug.
3744         If some other script wants to use bug-for-test we'll
3745         need to extend it with some options like --create-if-missing or similar.
3746
3747         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3748         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3749         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3750         * Scripts/webkitpy/tool/commands/__init__.py:
3751         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3752
3753 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3754
3755         Reviewed by James Robinson.
3756
3757         Add option to build-webkit to not build WebKit2
3758         https://bugs.webkit.org/show_bug.cgi?id=50988
3759         
3760         Add support for a --no-webkit2 option to build-webkit. It seems to save
3761         ~1 minute from clean builds and ~10 seconds from no-op builds.
3762
3763         * Scripts/build-webkit:
3764
3765 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3766
3767         Reviewed by Dave Kilzer.
3768
3769         Update iexploder from 1.3.2 to 1.7.2
3770         Move 1.3.2 into its own subdir
3771         Add 1.7.2 into its own subdir
3772         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3773
3774         * Scripts/run-iexploder-tests:
3775         * Scripts/update-iexploder-cssproperties:
3776         * iExploder/CHANGELOG.txt: Removed.
3777         * iExploder/LICENSE.txt: Removed.
3778         * iExploder/README.txt: Removed.
3779         * iExploder/htdocs: Removed.
3780         * iExploder/iexploder-1.3.2: Added.
3781         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3782         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3783         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3784         * iExploder/iexploder-1.3.2/htdocs: Added.
3785         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3786         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3787         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3788         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3789         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3790         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3791         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3792         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3793         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3794         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3795         * iExploder/iexploder-1.3.2/tools: Added.
3796         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3797         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3798         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3799         * iExploder/iexploder-1.7.2: Added.
3800         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3801         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3802         * iExploder/iexploder-1.7.2/README.txt: Added.
3803         * iExploder/iexploder-1.7.2/output: Added.
3804         * iExploder/iexploder-1.7.2/src: Added.
3805         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3806         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3807         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3808         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3809         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3810         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3811         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3812         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3813         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3814         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3815         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3816         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3817         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3818         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3819         * iExploder/iexploder-1.7.2/src/css-values: Added.
3820         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3821         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3822         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3823         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3824         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3825         * iExploder/iexploder-1.7.2/src/headers: Added.
3826         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3827         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3828         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3829         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3830         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3831         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3832         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3833         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3834         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3835         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3836         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3837         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3838         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3839         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3840         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3841         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3842         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3843         * iExploder/iexploder-1.7.2/src/html-values: Added.
3844         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3845         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3846         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3847         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3848         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3849         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3850         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3851         * iExploder/iexploder-1.7.2/src/index.html: Added.
3852         * iExploder/iexploder-1.7.2/src/media: Added.
3853         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3854         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3855         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3856         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3857         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3858         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3859         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3860         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3861         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3862         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3863         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3864         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3865         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3866         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3867         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3868         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3869         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3870         * iExploder/iexploder-1.7.2/src/protocols: Added.
3871         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3872         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3873         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3874         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3875         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3876         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3877         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3878         * iExploder/iexploder-1.7.2/testcases: Added.
3879         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3880         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3881         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3882         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3883         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3884         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3885         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3886         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3887         * iExploder/iexploder-1.7.2/tools: Added.
3888         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3889         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3890         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3891         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3892         * iExploder/tools: Removed.
3893
3894 2010-12-13  Sam Weinig  <sam@webkit.org>
3895
3896         Reviewed by Anders Carlsson.
3897
3898         Remove associated page concept from WKView constructor
3899         https://bugs.webkit.org/show_bug.cgi?id=50983
3900
3901         Step 1: Remove associate page constructors from WKView and make
3902         all views use the shared namespace for the context.
3903
3904         * TestWebKitAPI/PlatformWebView.h:
3905         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3906         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3907         * WebKitTestRunner/PlatformWebView.h:
3908         * WebKitTestRunner/TestController.cpp:
3909         (WTR::createOtherPage):
3910         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3911         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3912         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3913
3914 2010-12-13  Sam Weinig  <sam@webkit.org>
3915
3916         Reviewed by Anders Carlsson.
3917
3918         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3919         https://bugs.webkit.org/show_bug.cgi?id=50898
3920
3921         * MiniBrowser/mac/AppDelegate.h:
3922         * MiniBrowser/mac/AppDelegate.m:
3923         * MiniBrowser/mac/BrowserWindowController.h:
3924         * MiniBrowser/mac/BrowserWindowController.m:
3925         * MiniBrowser/win/BrowserView.cpp:
3926         Convert MiniBrowser to not use PageNamespaces.
3927
3928         * TestWebKitAPI/PlatformWebView.h:
3929         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3930         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3931         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3932         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3933         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3934         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3935         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3936         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3937         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3938         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3939         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3940         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3941         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3942         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3943         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3944         Convert TestWebKitAPI to not use PageNamespaces.
3945
3946         * WebKitTestRunner/PlatformWebView.h:
3947         * WebKitTestRunner/TestController.cpp:
3948         * WebKitTestRunner/TestController.h:
3949         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3950         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3951         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3952         Convert WebKitTestRunner to not use PageNamespaces.
3953
3954 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3955
3956         Reviewed by Eric Seidel.
3957
3958         webkit-patch rollout should be able to do multi-revision rollouts
3959         https://bugs.webkit.org/show_bug.cgi?id=33336
3960
3961         Make it possible to pass more than one revision to webkit-patch.
3962
3963         * Scripts/webkitpy/common/checkout/api.py:
3964         * Scripts/webkitpy/common/checkout/changelog.py:
3965         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3966         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3967         * Scripts/webkitpy/tool/commands/download.py:
3968         * Scripts/webkitpy/tool/commands/download_unittest.py:
3969         * Scripts/webkitpy/tool/mocktool.py:
3970         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3971         * Scripts/webkitpy/tool/steps/revertrevision.py:
3972
3973 2010-12-13  Eric Seidel  <eric@webkit.org>
3974
3975         Unreviewed.
3976
3977         Teach webkit-patch how to search bugzilla
3978         https://bugs.webkit.org/show_bug.cgi?id=50500
3979
3980         webkit-patch bug-search fails when there is only one result.
3981         Turns out we needed a bit more logic in our result count parsing code.
3982
3983         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3984         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3985
3986 2010-12-13  Antti Koivisto  <antti@apple.com>
3987
3988         Reviewed by Alexey Proskuryakov.
3989
3990         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3991         https://bugs.webkit.org/show_bug.cgi?id=50758
3992
3993         * DumpRenderTree/LayoutTestController.cpp:
3994         (setSerializeHTTPLoadsCallback):
3995         (LayoutTestController::staticFunctions):
3996         * DumpRenderTree/LayoutTestController.h:
3997         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3998         (LayoutTestController::setSerializeHTTPLoads):
3999         * DumpRenderTree/mac/DumpRenderTree.mm:
4000         (resetDefaultsToConsistentValues):
4001         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4002         (LayoutTestController::setSerializeHTTPLoads):
4003         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4004         (LayoutTestController::setSerializeHTTPLoads):
4005
4006 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
4007
4008         Reviewed by Ojan Vafai.
4009
4010         Remove "use-drt" option from test step command line, since the option was removed in r73748.
4011         https://bugs.webkit.org/show_bug.cgi?id=50936
4012
4013         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
4014
4015 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
4016
4017         Reviewed by Csaba Osztrogonác.
4018
4019         Add revlink to BuildBot status
4020         https://bugs.webkit.org/show_bug.cgi?id=50914
4021
4022         This adds a hyperlink to trac changeset on the revision numbers. 
4023
4024         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4025
4026 2010-12-13  Andras Becsi  <abecsi@webkit.org>
4027
4028         Reviewed by Csaba Osztrogonác.
4029
4030         [Qt][WK2] Fix build if WebKitTools are not available
4031         https://bugs.webkit.org/show_bug.cgi?id=50242
4032
4033         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
4034         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
4035         * MiniBrowser/DerivedSources.pro: Added.
4036
4037 2010-12-13  Eric Seidel  <eric@webkit.org>
4038
4039         Reviewed by Adam Barth.
4040
4041         EWS Queues should remove orpahned pyc files before starting
4042         https://bugs.webkit.org/show_bug.cgi?id=50904
4043
4044         A previous check added a platform.py which caused
4045         EWS bots on some platforms to hit an import exception.
4046         The platform.py file was removed in a subsequent commit, but
4047         the EWS bots in question stayed stuck.  This change will
4048         fix those bots once restarted (and prevent this in the future).
4049
4050         I also went ahead and unified start-queue and start-commit-queue
4051         since they were nearly identical.  I also added bot_id support
4052         to both force all EWSes to have bot ids as well as get rid of the one
4053         remaining reason why I had my own copies of these scripts.
4054         Hopefully this will be enough to get all the other bot admins
4055         (ahem, Adam, ahem) to move to using these checked in copies as well.
4056
4057         * EWSTools/start-commit-queue.sh: Removed.
4058         * EWSTools/start-queue.sh:
4059
4060 2010-10-28  MORITA Hajime  <morrita@google.com>
4061
4062         Reviewed by Ojan Vafai.
4063
4064         spellcheck does not check pasted text
4065         https://bugs.webkit.org/show_bug.cgi?id=40092
4066
4067         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
4068         to control the setting.
4069
4070         * DumpRenderTree/LayoutTestController.cpp:
4071         (setAsynchronousSpellCheckingEnabledCallback):
4072         (LayoutTestController::staticFunctions):
4073         * DumpRenderTree/LayoutTestController.h:
4074         * DumpRenderTree/chromium/LayoutTestController.h:
4075         * DumpRenderTree/chromium/LayoutTestController.cpp:
4076         (LayoutTestController::LayoutTestController):
4077         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4078         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4079         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4080         * DumpRenderTree/mac/DumpRenderTree.mm:
4081         (resetDefaultsToConsistentValues):
4082         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4083         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4084         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4085         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4086         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4087         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4088         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4089         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4090         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4091
4092 2010-12-12  Sam Weinig  <sam@webkit.org>
4093
4094         Reviewed by Anders Carlsson.
4095
4096         Fix failing API test. It turns out that a pop-state event
4097         is sent before every fragment navigation, so we have to test
4098         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
4099
4100         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4101         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4102
4103 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
4104
4105         Reviewed by Eric Seidel.
4106
4107         [GTK] Add new-run-webkit-tests support to gtk
4108         https://bugs.webkit.org/show_bug.cgi?id=50681
4109
4110         Adding the basic support to run the new-run-webkit-tests.
4111
4112         * Scripts/webkitpy/layout_tests/port/gtk.py:
4113
4114 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
4115
4116         Reviewed by Kenneth Rohde Christiansen.
4117
4118         [Qt] Mock DeviceOrientation client for DRT
4119         https://bugs.webkit.org/show_bug.cgi?id=47490
4120
4121         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4122         (WebCore::DumpRenderTree::DumpRenderTree):
4123         (WebCore::DumpRenderTree::~DumpRenderTree):
4124         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4125         (LayoutTestController::setMockDeviceOrientation):
4126
4127 2010-12-11  Philippe Normand  <pnormand@igalia.com>
4128
4129         Reviewed by Gustavo Noronha Silva.
4130
4131         [GTK] launcher: disable the Mozilla-style fullscreen API
4132         https://bugs.webkit.org/show_bug.cgi?id=50874
4133
4134         Disabling the fullscreen API until its implementation for GTK is
4135         mature enough. The webview setting for it is already FALSE by
4136         default.
4137
4138         * GtkLauncher/main.c:
4139         (createWindow):
4140
4141 2010-12-10  Eric Seidel  <eric@webkit.org>
4142
4143         Reviewed by Adam Barth.
4144
4145         commit-queue flaky test messages show cryptic version information for mac os x
4146         https://bugs.webkit.org/show_bug.cgi?id=50864
4147
4148         Turns out platform.platform() returns kernel version information
4149         which isn't helpful, and just plain confusing on Mac
4150         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
4151
4152         So I've updated PlatformInfo.display_name() to special case
4153         mac.  I also found a bad use of sys.platform in the process
4154         and fixed that.  (sys.platform always returns 'darwin' on mac).
4155
4156         * Scripts/webkitpy/common/system/platforminfo.py:
4157         * Scripts/webkitpy/common/system/user.py:
4158         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4159         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4160         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4161
4162 2010-12-10  Eric Seidel  <eric@webkit.org>
4163
4164         Unreviewed.
4165
4166         Exception seen while reporting flaky test with commit-queue.
4167         Just a missing include.
4168
4169         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4170         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4171
4172 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
4173
4174         Reviewed by Eric Seidel.
4175
4176         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
4177         https://bugs.webkit.org/show_bug.cgi?id=50796
4178
4179         Also updating the test code to use JSONResultsGeneratorBase and
4180         to improve test coverage for incremental cases.
4181
4182         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4183         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4184
4185 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
4186
4187         Reviewed by Darin Adler.
4188
4189         prepare-ChangeLog --help doesn't mention --bug shorthand -b
4190         https://bugs.webkit.org/show_bug.cgi?id=50835
4191
4192         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
4193
4194 2010-12-10  Eric Seidel  <eric@webkit.org>
4195
4196         Reviewed by Adam Barth.
4197
4198         Bugs created by the commit-queue should all block on a master bug
4199         https://bugs.webkit.org/show_bug.cgi?id=50857
4200
4201         This makes all bugs created by the commit-queue block on:
4202         https://bugs.webkit.org/show_bug.cgi?id=50856
4203
4204         In the process of testing this, I found that the existing
4205         create_bug code was wrong.  I also found that existing
4206         unit tests for create-rollout used invalid values
4207         for options.blocks.  I fixed both issues and tested.
4208
4209         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4210         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4211         * Scripts/webkitpy/tool/commands/commandtest.py:
4212         * Scripts/webkitpy/tool/commands/download_unittest.py:
4213         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4214         * Scripts/webkitpy/tool/mocktool.py:
4215         * Scripts/webkitpy/tool/steps/options.py:
4216
4217 2010-12-10  Eric Seidel  <eric@webkit.org>
4218
4219         Reviewed by Adam Barth.
4220
4221         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
4222         https://bugs.webkit.org/show_bug.cgi?id=50853
4223
4224         I also discovered when doing this that the code was posting
4225         the comment on the wrong bug, but that's fixed here too.
4226
4227         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4228         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4229         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4230         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4231         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4232         * Scripts/webkitpy/tool/mocktool.py:
4233
4234 2010-12-10  Anders Carlsson  <andersca@apple.com>
4235
4236         Reviewed by John Sullivan.
4237
4238         Make WKContextGetStatistics gather global statistics
4239         https://bugs.webkit.org/show_bug.cgi?id=50850
4240
4241         Remove the code that gets the statistics and fills in the per context
4242         statistics information for now.
4243
4244         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
4245         (-[BrowserStatisticsWindowController refreshStatistics:]):
4246
4247 2010-12-10  Eric Seidel  <eric@webkit.org>
4248
4249         Unreviewed.
4250
4251         commit-queue should report port/platform information when commenting on flaky test bugs
4252         https://bugs.webkit.org/show_bug.cgi?id=50839
4253
4254         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
4255         which was only used by new run webkit tests (and clearly not unit tested).
4256
4257         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
4258         * Scripts/webkitpy/tool/main.py:
4259         * Scripts/webkitpy/tool/mocktool.py:
4260
4261 2010-12-10  Eric Seidel  <eric@webkit.org>
4262
4263         Reviewed by Tony Chang.
4264
4265         commit-queue should report port/platform information when commenting on flaky test bugs
4266         https://bugs.webkit.org/show_bug.cgi?id=50839
4267
4268         This was a suggestion from Tony Chang this morning.
4269         I added a platform.py class so I could easily mock the platform call,
4270         but that may not be the final solution for this mocking.
4271         We'll try it and see.
4272
4273         * Scripts/webkitpy/common/system/platform.py: Added.
4274         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4275         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4276         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4277         * Scripts/webkitpy/tool/main.py:
4278         * Scripts/webkitpy/tool/mocktool.py:
4279
4280 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
4281
4282         Reviewed by Joseph Pecoraro.
4283
4284         Bug 43455 - [Qt]: Implement Application Cache Quotas
4285         https://bugs.webkit.org/show_bug.cgi?id=43455
4286
4287         Introduce functions to allow new appcache layout test origin-quota.html
4288         to work correctly under Qt.
4289
4290         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4291         (WebCore::DumpRenderTree::DumpRenderTree):
4292         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
4293         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4294
4295         Introduce functions to allow new appcache layout test origin-quota.html
4296         to be successful under qt. Changes required because LayoutTestControllerQt
4297         does not inherit from LayoutController.
4298
4299         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4300         (LayoutTestController::reset):
4301         (LayoutTestController::clearAllApplicationCaches):
4302         (LayoutTestController::setApplicationCacheOriginQuota):
4303         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4304         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
4305         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
4306
4307 2010-12-10  Eric Seidel  <eric@webkit.org>
4308
4309         Reviewed by Adam Barth.
4310
4311         Move buildbot.py into its own module so we can split it out into one-file-per-class
4312         https://bugs.webkit.org/show_bug.cgi?id=50806
4313
4314         We're adding more buildbot logic these days, so it makes sense
4315         to give buildbot its own module.
4316
4317         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
4318         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
4319         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
4320         * Scripts/webkitpy/common/net/failuremap.py:
4321         * Scripts/webkitpy/common/net/regressionwindow.py:
4322         * Scripts/webkitpy/tool/commands/rebaseline.py:
4323
4324 2010-12-10  Tony Chang  <tony@chromium.org>
4325
4326         Reviewed by Eric Seidel.
4327
4328         Use FileSystem::remove when cleaning up http lock files
4329         https://bugs.webkit.org/show_bug.cgi?id=50830
4330
4331         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4332
4333 2010-12-10  Joone Hur  <joone@kldp.org>
4334
4335         Reviewed by Martin Robinson.
4336
4337         [GTK] DRT needs layoutTestController.setCacheModel
4338         https://bugs.webkit.org/show_bug.cgi?id=50705
4339         
4340         webkit_set_cache_mode() is called to set the cache model.
4341         
4342         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4343         (LayoutTestController::setCacheModel): Set the cache model. 
4344
4345 2010-12-10  Tony Chang  <tony@chromium.org>
4346
4347         Reviewed by Ojan Vafai.
4348
4349         [chromium] remove --use-drt and add --use-test-shell
4350         https://bugs.webkit.org/show_bug.cgi?id=50701
4351
4352         * Scripts/webkitpy/common/config/ports.py:
4353         * Scripts/webkitpy/common/config/ports_unittest.py:
4354         * Scripts/webkitpy/layout_tests/port/chromium.py:
4355         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4356         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4357         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4358         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4359         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4360         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4361         * Scripts/webkitpy/layout_tests/port/webkit.py:
4362         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4363         * Scripts/webkitpy/style/checkers/test_expectations.py:
4364         * Scripts/webkitpy/tool/commands/queries.py:
4365
4366 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
4367
4368         Reviewed by Steve Block.
4369
4370         [Chromium] Implement mocks for client-based geolocation
4371         https://bugs.webkit.org/show_bug.cgi?id=46895
4372
4373         * DumpRenderTree/chromium/LayoutTestController.cpp:
4374         (LayoutTestController::setGeolocationPermission):
4375         (LayoutTestController::setMockGeolocationPosition):
4376         (LayoutTestController::setMockGeolocationError):
4377         * DumpRenderTree/chromium/LayoutTestController.h:
4378         * DumpRenderTree/chromium/WebViewHost.cpp:
4379         (WebViewHost::geolocationClient):
4380         (WebViewHost::geolocationClientMock):
4381         (WebViewHost::reset):
4382         * DumpRenderTree/chromium/WebViewHost.h:
4383
4384 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
4385
4386         Reviewed by Martin Robinson.
4387
4388         [GTK] Add hasSpellingMarker support to the DRT
4389         https://bugs.webkit.org/show_bug.cgi?id=50739
4390
4391         Implemented the hasSpellingMarker to support spelling tests.
4392
4393         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4394         (LayoutTestController::hasSpellingMarker):
4395
4396 2010-12-10  Eric Seidel  <eric@webkit.org>
4397
4398         Reviewed by Ojan Vafai.
4399
4400         webkit-patch: not possible to use build-and-test with local commits
4401         https://bugs.webkit.org/show_bug.cgi?id=33378
4402
4403         Make --no-clean not even check if we have local commits.
4404         It's unclear to me why the code was originally written this way.
4405         I was unable to dig up a reason from svn history.
4406
4407         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4408         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4409
4410 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
4411
4412         Reviewed by Martin Robinson.
4413
4414         [GTK] AX: implement isEnabled in DRT
4415         https://bugs.webkit.org/show_bug.cgi?id=50814
4416
4417         Implement AccessibilityUIElement::isEnabled() for GTK.
4418
4419         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4420         (checkElementState): New function to refactor common code.
4421         (AccessibilityUIElement::isEnabled): Implement this by checking
4422         the current state of the AtkObject.
4423         (AccessibilityUIElement::isSelected): Use the new
4424         checkElementState function.
4425
4426 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4427
4428         Reviewed by Kenneth Rohde Christiansen.
4429
4430         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
4431         https://bugs.webkit.org/show_bug.cgi?id=50750
4432
4433         * MiniBrowser/qt/BrowserView.cpp:
4434         (BrowserView::BrowserView):
4435         * MiniBrowser/qt/BrowserView.h:
4436         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4437         (WTR::WebView::WebView):
4438
4439 2010-12-10  Joone Hur  <joone@kldp.org>
4440
4441         Reviewed by Xan Lopez.
4442
4443         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet