[GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
[WebKit.git] / Tools / ChangeLog
1 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2
3         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
4         https://bugs.webkit.org/show_bug.cgi?id=208970
5
6         Reviewed by Konstantin Tokarev.
7
8         We are allowed to use /usr/bin/env in this script because it's not installed (so not
9         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
10         case.
11
12         * gtkdoc/generate-gtkdoc:
13
14 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
15
16         run-webkit-tests: Report MacCatalyst as a unique platform
17         https://bugs.webkit.org/show_bug.cgi?id=209361
18
19         Rubber-stamped by Aakash Jain.
20
21         * Scripts/webkitpy/port/mac.py:
22         (MacCatalystPort):
23         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
24
25 2020-03-20  Alex Christensen  <achristensen@webkit.org>
26
27         CORS-disabling SPI introduced in r253978 should make responses non-opaque
28         https://bugs.webkit.org/show_bug.cgi?id=209351
29         <rdar://problem/60024850>
30
31         Reviewed by Chris Dumez.
32
33         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
34
35 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
36
37         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
38         https://bugs.webkit.org/show_bug.cgi?id=208938
39
40         Reviewed by Jonathan Bedard.
41
42         * BuildSlaveSupport/ews-build/steps.py:
43         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
44         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
45         (CheckPatchStatusOnEWSQueues.get_patch_status):
46         (CheckPatchStatusOnEWSQueues.start):
47         * BuildSlaveSupport/ews-build/steps_unittest.py:
48         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
49         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
50         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
51         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
52
53 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
54
55         [ews] Better organize patch status api data
56         https://bugs.webkit.org/show_bug.cgi?id=209342
57
58         Reviewed by Jonathan Bedard.
59
60         * BuildSlaveSupport/ews-app/ews/views/status.py:
61         (Status._build_status):
62         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
63         (Status.get): Remove safe=false now that we are returning a dictionary.
64
65 2020-03-20  Tim Horton  <timothy_horton@apple.com>
66
67         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
68         https://bugs.webkit.org/show_bug.cgi?id=209307
69
70         Reviewed by Andy Estes.
71
72         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
73
74 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
75
76         Unreviewed, reverting r258748.
77
78         This commit broke the Catalina build
79
80         Reverted changeset:
81
82         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
83         https://bugs.webkit.org/show_bug.cgi?id=209307
84         https://trac.webkit.org/changeset/258748
85
86 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
87
88         [ews] commit-queue should comment on bug if patch fails to apply
89         https://bugs.webkit.org/show_bug.cgi?id=209334
90
91         Reviewed by Jonathan Bedard.
92
93         * BuildSlaveSupport/ews-build/steps.py:
94         (ApplyPatch):
95         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
96         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
97         (TestApplyPatch):
98         (TestApplyPatch.setUp):
99         (TestApplyPatch.setUp.mock_start):
100         (TestApplyPatch.tearDown):
101         (TestApplyPatch.test_success):
102         (TestApplyPatch.test_failure):
103         (TestApplyPatch.test_failure_on_commit_queue):
104
105 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
106
107         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
108         https://bugs.webkit.org/show_bug.cgi?id=209122
109
110         Reviewed by Jonathan Bedard.
111
112         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
113         (StatusBubble._build_bubble):
114
115 2020-03-19  Tim Horton  <timothy_horton@apple.com>
116
117         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
118         https://bugs.webkit.org/show_bug.cgi?id=209307
119
120         Reviewed by Andy Estes.
121
122         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
123
124 2020-03-19  Alex Christensen  <achristensen@webkit.org>
125
126         Remove test failing after r258734
127         https://bugs.webkit.org/show_bug.cgi?id=209303
128
129         We removed the functionality it was testing because it did nothing useful except call the callback.
130         I'm about to remove the only user of WKContextGetStatistics.
131
132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
133         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
134
135 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
136
137         commit-queue status-bubble shows incorrect position in queue
138         https://bugs.webkit.org/show_bug.cgi?id=209313
139
140         Reviewed by Jonathan Bedard.
141
142         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
143         (StatusBubble._queue_position):
144
145 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
146
147         [Curl] Add an API returns description of verification errors.
148         https://bugs.webkit.org/show_bug.cgi?id=208913
149
150         Reviewed by Fujii Hironori.
151
152         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
153         Browser can display more precise error information with this API.
154
155         API Test: Curl.CertificateAPI
156
157         * MiniBrowser/win/Common.cpp:
158         (askServerTrustEvaluation):
159         * MiniBrowser/win/Common.h:
160         * MiniBrowser/win/WebKitBrowserWindow.cpp:
161         (createPEMString):
162         (WebKitBrowserWindow::canTrustServerCertificate):
163         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
164         (TestWebKitAPI::Curl::TEST):
165
166 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
167
168         Update build.webkit.org link for EWS
169         https://bugs.webkit.org/show_bug.cgi?id=209280
170
171         Reviewed by Alexey Proskuryakov.
172
173         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
174
175 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
176
177         [WinCairo] extract-built-product fails after r258612
178         https://bugs.webkit.org/show_bug.cgi?id=209285
179
180         extractBuiltProduct also references the old name for the
181         requirements on wincairo.
182
183         Reviewed by Ross Kirsling.
184
185         * BuildSlaveSupport/built-product-archive:
186
187 2020-03-19  Philippe Normand  <pnormand@igalia.com>
188
189         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
190         https://bugs.webkit.org/show_bug.cgi?id=209223
191
192         Reviewed by Carlos Alberto Lopez Perez.
193
194         flatpak build doesn't expose a --socket option for white-listing
195         the systemd journal socket. So white-list everything in /run. 🤷
196
197         * flatpak/flatpakutils.py:
198         (WebkitFlatpak.run_in_sandbox):
199
200 2020-03-19  Charlie Turner  <cturner@igalia.com>
201
202         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
203         https://bugs.webkit.org/show_bug.cgi?id=209146
204
205         Reviewed by Darin Adler.
206
207         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
208         (TestWebKitAPI::TEST):
209         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
210         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
211         (testDownloadMIMEType):
212         (testContextMenuDownloadActions):
213         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
214
215 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
216
217         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
218         https://bugs.webkit.org/show_bug.cgi?id=209278
219
220         Reviewed by Philippe Normand.
221
222         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
223         means flatpak.
224
225         * Scripts/webkitdirs.pm:
226         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
227
228 2020-03-19  Philippe Normand  <pnormand@igalia.com>
229
230         [CMake] cache not cleared when build-webkit options change
231         https://bugs.webkit.org/show_bug.cgi?id=209277
232
233         Reviewed by Adrian Perez de Castro.
234
235         * Scripts/webkitdirs.pm:
236         (shouldRemoveCMakeCache): The expected function signature never
237         included the cache file path. Remove it.
238
239 2020-03-18  Philippe Normand  <pnormand@igalia.com>
240
241         REGRESSION(r258626): webkit-dirs warning
242         https://bugs.webkit.org/show_bug.cgi?id=209221
243
244         Reviewed by Adrian Perez de Castro.
245
246         * Scripts/webkitdirs.pm:
247         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
248
249 2020-03-19  Chris Lord  <clord@igalia.com>
250
251         Add Chris Lord (clord@igalia.com) to the list of contributors
252         https://bugs.webkit.org/show_bug.cgi?id=209274
253
254         Unreviewed
255
256         * Scripts/webkitpy/common/config/contributors.json:
257
258 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
259
260         Remove commit queue bubble from bot watchers dashboard
261         https://bugs.webkit.org/show_bug.cgi?id=209271
262
263         Reviewed by Alexey Proskuryakov.
264
265         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
266
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
268         (BubbleQueueServer): 
269
270 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
271
272         eventSender.monitorWheelEvents() is very fragile
273         https://bugs.webkit.org/show_bug.cgi?id=197819
274         <rdar://problem/51319456>
275
276         Reviewed by Tim Horton.
277
278         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
279         adding back changes from r257844 that were reverted in r258558.
280         
281         First, have EventSendingController keep track of whether it's seen then "end" event
282         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
283         now waits until it sees these, which prevents premature triggering which was a common cause of
284         failure before.
285         
286         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
287         for completion in a callout from the end of Page::updateRendering(), which makes it test
288         and fire at a more consistent time.
289         
290         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
291         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
292         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
293         also resulting in a premature trigger.
294
295         * DumpRenderTree/mac/EventSendingController.h:
296         * DumpRenderTree/mac/EventSendingController.mm:
297         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
298         (-[EventSendingController monitorWheelEvents]):
299         (-[EventSendingController callAfterScrollingCompletes:]):
300         * DumpRenderTree/win/EventSender.cpp:
301         (mouseScrollBy):
302         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
303         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
304         (WTR::EventSendingController::monitorWheelEvents):
305         (WTR::EventSendingController::callAfterScrollingCompletes):
306         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
307
308 2020-03-18  John Wilander  <wilander@apple.com>
309
310         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
311         https://bugs.webkit.org/show_bug.cgi?id=209245
312         <rdar://problem/60511121>
313
314         Reviewed by Chris Dumez.
315
316         These changes to the TestRunner makes sure that
317         - statisticsClearInMemoryAndPersistentStore()
318         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
319         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
320         and adds the infrastructure for that.
321
322         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
323         (WTR::InjectedBundle::didReceiveMessageToPage):
324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
325         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
326         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
327         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
328         * WebKitTestRunner/InjectedBundle/TestRunner.h:
329         * WebKitTestRunner/TestController.cpp:
330         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
331         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
332         * WebKitTestRunner/TestInvocation.cpp:
333         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
334         * WebKitTestRunner/TestInvocation.h:
335
336 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
337
338         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
339         https://bugs.webkit.org/show_bug.cgi?id=209218
340         <rdar://problem/60560831>
341
342         Reviewed by Tim Horton.
343
344         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
345         those views must be parented (i.e. they must be connected to a UIWindow).
346
347         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
348         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
349         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
350         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
351
352 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
353
354         [ews] commit-queue should comment on bug in case of test failures
355         https://bugs.webkit.org/show_bug.cgi?id=209226
356
357         Reviewed by Jonathan Bedard.
358
359         * BuildSlaveSupport/ews-build/steps.py:
360         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
361         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
362         (SetBuildSummary): Ditto.
363         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
364
365 2020-03-18  Philippe Normand  <pnormand@igalia.com>
366
367         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
368         https://bugs.webkit.org/show_bug.cgi?id=209238
369
370         Reviewed by Jonathan Bedard.
371
372         * Scripts/test262-runner: Perform the flatpak check on Linux only.
373
374 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
375
376         [WinCairo] archive-built-product fails after r258612
377         https://bugs.webkit.org/show_bug.cgi?id=209237
378
379         Reviewed by Alex Christensen.
380
381         * BuildSlaveSupport/built-product-archive:
382         Update name of version file for requirements version
383         file for wincairo.
384
385 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
386
387         commit-queue should allow patches which are reviewed by patch author
388         https://bugs.webkit.org/show_bug.cgi?id=209231
389
390         Reviewed by Jonathan Bedard.
391
392         * BuildSlaveSupport/ews-build/steps.py:
393         (BugzillaMixin._does_patch_have_acceptable_review_flag):
394
395 2020-03-18  Philippe Normand  <pnormand@igalia.com>
396
397         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
398         https://bugs.webkit.org/show_bug.cgi?id=209222
399
400         Reviewed by Carlos Alberto Lopez Perez.
401
402         * Scripts/webkitdirs.pm:
403         (runInFlatpakIfAvailable): If a command wrapper is required it
404         means Flatpak shouldn't be used.
405
406 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
407
408         [ews] commit-queue should comment on bug in case patch fails to build
409         https://bugs.webkit.org/show_bug.cgi?id=209227
410
411         Reviewed by Jonathan Bedard.
412
413         * BuildSlaveSupport/ews-build/steps.py:
414         (AnalyzeCompileWebKitResults.start):
415         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
416
417 2020-03-18  Philippe Normand  <pnormand@igalia.com>
418
419         [GTK][WPE] Migrate to Flatpak-based dev SDK
420         https://bugs.webkit.org/show_bug.cgi?id=205658
421
422         Reviewed by Carlos Alberto Lopez Perez.
423
424         JHBuild will now be used only if the WEBKIT_JHBUILD environment
425         variable is set to 1, which is the case for the time being on the
426         GTK and WPE EWS/build bots.
427
428         By default the build dependencies are now locally installed from a
429         Flatpak repository hosted at https://software.igalia.com. The
430         repository can be regenerated with the scripts from the
431         webkit-flatpak-sdk Github project
432         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
433         transparently with the update-webkit{gtk,wpe}-libs scripts. As
434         there is no need to rebuild the dependencies from scratch, the
435         developer user-experience should now be much more friendly and
436         overall build times reduced.
437
438         As an additional commodity, the new environment supports the
439         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
440         environment variable to your gst-build path. This feature was
441         contributed by Thibault Saunier.
442
443         The JHBuild infrastructure will be removed once all the bots have
444         been switched over to Flatpak.
445
446         * BuildSlaveSupport/ews-build/steps.py:
447         (InstallGtkDependencies):
448         (InstallWpeDependencies):
449         (CompileWebKit.start):
450         * BuildSlaveSupport/gtk/buildbot/run:
451         * Scripts/build-webkit:
452         * Scripts/run-bindings-tests:
453         * Scripts/run-builtins-generator-tests:
454         * Scripts/run-gtk-tests:
455         * Scripts/run-javascriptcore-tests:
456         * Scripts/run-minibrowser:
457         * Scripts/run-qt-wpe-minibrowser:
458         * Scripts/run-webdriver-tests:
459         * Scripts/run-wpe-tests:
460         * Scripts/test-webkitperl:
461         * Scripts/test-webkitpy:
462         * Scripts/test262-runner:
463         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
464         * Scripts/update-webkitgtk-libs:
465         * Scripts/update-webkitwpe-flatpak: Removed.
466         * Scripts/update-webkitwpe-libs:
467         * Scripts/webkitdirs.pm:
468         (getUserFlatpakPath):
469         (inFlatpakSandbox):
470         (runInFlatpakIfAvailable):
471         (wrapperPrefixIfNeeded):
472         (shouldUseJhbuild):
473         (shouldUseFlatpak):
474         (shouldRemoveCMakeCache):
475         * Scripts/webkitpy/common/system/executive.py:
476         (Executive.kill_all):
477         * Scripts/webkitpy/port/base.py:
478         (Port._path_to_apache):
479         (Port._should_run_as_pixel_test):
480         (Port._in_flatpak_sandbox):
481         * Scripts/webkitpy/port/gtk.py:
482         (GtkPort.setup_environ_for_server):
483         (GtkPort._get_crash_log):
484         * Scripts/webkitpy/port/linux_get_crash_log.py:
485         (GDBCrashLogGenerator):
486         (GDBCrashLogGenerator.__init__):
487         (GDBCrashLogGenerator.generate_crash_log):
488         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
489         (GDBCrashLogGeneratorTest.test_generate_crash_log):
490         * Scripts/webkitpy/port/wpe.py:
491         (WPEPort.setup_environ_for_server):
492         (WPEPort._get_crash_log):
493         * Scripts/webkitpy/port/xvfbdriver.py:
494         (XvfbDriver._setup_environ_for_test):
495         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
496         (WTR::getFontsPath):
497         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
498         (WTR::getFontsPath):
499         * flatpak/files/default.xkm: Removed.
500         * flatpak/files/httpd-autogen.sh: Removed.
501         * flatpak/flatpakutils.py:
502         (check_flatpak):
503         (FlatpakRepos.update):
504         (FlatpakPackage.__repr__):
505         (FlatpakPackage.__str__):
506         (WebkitFlatpak.load_from_args):
507         (WebkitFlatpak.__init__):
508         (WebkitFlatpak.clean_args):
509         (WebkitFlatpak.setup_builddir):
510         (WebkitFlatpak):
511         (WebkitFlatpak.setup_gstbuild):
512         (WebkitFlatpak.run_in_sandbox):
513         (WebkitFlatpak.run):
514         (WebkitFlatpak.has_environment):
515         (WebkitFlatpak.save_config):
516         (WebkitFlatpak.setup_dev_env):
517         (WebkitFlatpak.install_all):
518         (WebkitFlatpak.run_gdb):
519         * flatpak/org.webkit.CommonModules.yaml: Removed.
520         * flatpak/org.webkit.GTK.yaml: Removed.
521         * flatpak/org.webkit.WPE.yaml: Removed.
522         * flatpak/org.webkit.WPEModules.yaml: Removed.
523         * flatpak/org.webkit.WPEQT.yaml: Removed.
524         * flatpak/org.webkit.WebKit.yaml: Removed.
525         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
526         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
527         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
528
529 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
530
531         Expand In-App-Browser-Privacy testing
532         https://bugs.webkit.org/show_bug.cgi?id=209142
533         <rdar://problem/60496618>
534
535         Reviewed by Darin Adler.
536
537         Expanded test coverage by adding new tests and creating a custom url
538         scheme handler to get around the fact that local file loads are
539         always classified as app-bound.
540
541         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
542         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
543         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
544         If the path indicates testing user scripts on load, notify the script message
545         handler that the navigation has finished. If the path indicates
546         testing user-agent scripts, set the window.wkUserScriptInjected
547         variable to true. A user agent script will attempt to read this
548         variable and should fail.
549
550         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
551         (initializeInAppBrowserPrivacyTestSettings):
552         Basic test setup. Initialize the main run loop and make sure we are
553         starting with a clean state.
554
555         (TEST):
556         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
557         except for blob files which must be generated within the web content.
558
559         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
560         Basic html document to test local file loads are classified as
561         app-bound.
562
563         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
564         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
565         These files are no longer needed as their content is directly copied
566         into the URL scheme handler.
567
568 2020-03-17  Chris Dumez  <cdumez@apple.com>
569
570         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
571         https://bugs.webkit.org/show_bug.cgi?id=207307
572         <rdar://problem/59206964>
573
574         Reviewed by Alex Christensen.
575
576         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
577         notifications from the map but not tell WebCore that the notification were discarded. As a result,
578         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
579         notification would no longer be in the map, causing us to hit an assertion in debug.
580
581         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
582         to let WebCore know the notification was discarded. This is similar to what is already done for
583         WebKit2 in WebNotificationManager::clearNotifications().
584
585         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
586         (-[MockWebNotificationProvider reset]):
587
588 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
589
590         [WinCairo][FTW] Update path to requirements download
591         https://bugs.webkit.org/show_bug.cgi?id=209202
592
593         Reviewed by Ross Kirsling.
594
595         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
596         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
597         WebKitRequirementsWin64.zip.
598
599         * Scripts/update-webkit-wincairo-libs.py:
600
601 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
602
603         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
604         https://bugs.webkit.org/show_bug.cgi?id=208920
605
606         Reviewed by Jonathan Bedard.
607
608         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
609         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
610         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
611         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
612         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
613         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
614         * BuildSlaveSupport/ews-app/ews/fetcher.py:
615         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
616         for commit-queue which isn't expected to change.
617         (BugzillaPatchFetcher.fetch_commit_queue_patches):
618         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
619         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
620         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
621         setting cq+ flag on bugzilla.
622
623 2020-03-17  Chris Dumez  <cdumez@apple.com>
624
625         [WKTR] testRunner API that takes in a completion handler should use async IPC
626         https://bugs.webkit.org/show_bug.cgi?id=209187
627
628         Reviewed by John Wilander.
629
630         testRunner API that takes in a completion handler should use async IPC. This hangs
631         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
632         to IPC the WebProcess as a result of this testRunner call.
633
634         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
635         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
636         (WTR::TestRunner::statisticsUpdateCookieBlocking):
637         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
638         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
639         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
640         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
641         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
642         (WTR::TestRunner::statisticsResetToConsistentState):
643         (WTR::TestRunner::getAllStorageAccessEntries):
644         (WTR::TestRunner::removeAllSessionCredentials):
645         (WTR::TestRunner::getApplicationManifestThen):
646         * WebKitTestRunner/TestInvocation.cpp:
647         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
648         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
649
650 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
651
652         [ews-app] Timestamp shown in status-bubble hover-over message is in future
653         https://bugs.webkit.org/show_bug.cgi?id=196628
654
655         Reviewed by Jonathan Bedard.
656
657         * BuildSlaveSupport/ews-build/events.py:
658         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
659         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
660         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
661         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
662
663 2020-03-17  Alex Christensen  <achristensen@webkit.org>
664
665         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
666         https://bugs.webkit.org/show_bug.cgi?id=209192
667         <rdar://problem/51313336>
668
669         Reviewed by Geoff Garen.
670
671         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
672         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
673         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
674         (TEST):
675
676 2020-03-17  Chris Dumez  <cdumez@apple.com>
677
678         Use less sync IPC for ITP testRunner methods
679         https://bugs.webkit.org/show_bug.cgi?id=209184
680
681         Reviewed by Alex Christensen.
682
683         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
684         (WTR::TestRunner::setStatisticsDebugMode):
685         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
686         (WTR::TestRunner::setStatisticsLastSeen):
687         (WTR::TestRunner::setStatisticsMergeStatistic):
688         (WTR::TestRunner::setStatisticsPrevalentResource):
689         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
690         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
691         * WebKitTestRunner/TestInvocation.cpp:
692         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
693         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
694
695 2020-03-17  Chris Dumez  <cdumez@apple.com>
696
697         [WKTR] Crash when trying to open a new window in an ephemeral session test
698         https://bugs.webkit.org/show_bug.cgi?id=209181
699
700         Reviewed by Geoffrey Garen.
701
702         Make sure that the new WKWebView is using the same data store as its related WKWebView.
703
704         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
705         (WTR::TestController::platformCreateOtherPage):
706
707 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
708
709         Unreviewed, reverting r257844.
710
711         this revision caused a test to start timing out
712
713         Reverted changeset:
714
715         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
716         zero.html is a flaky failure"
717         https://bugs.webkit.org/show_bug.cgi?id=207948
718         https://trac.webkit.org/changeset/257844
719
720 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
721
722         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
723         https://bugs.webkit.org/show_bug.cgi?id=209151
724
725         Reviewed by Yusuke Suzuki.
726
727         * Scripts/webkitpy/common/config/contributors.json:
728
729 2020-03-16  Chris Dumez  <cdumez@apple.com>
730
731         Crash under WebCookieCache::clearForHost()
732         https://bugs.webkit.org/show_bug.cgi?id=209149
733         <rdar://problem/60453086>
734
735         Reviewed by Alex Christensen.
736
737         Add API test coverage.
738
739         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
740         (TEST):
741
742 2020-03-16  Keith Rollin  <krollin@apple.com>
743
744         Remove support for WebKitSystemInterface
745         https://bugs.webkit.org/show_bug.cgi?id=208894
746         <rdar://problem/60297590>
747
748         Reviewed by Brent Fulgham.
749
750         This project provided support for facilities that are now handled
751         elsewhere and is no longer needed.
752
753         * Scripts/copy-webkitlibraries-to-product-directory:
754
755 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
756
757         [macOS] Accessibility sandbox regressions
758         https://bugs.webkit.org/show_bug.cgi?id=209065
759
760         Reviewed by Brent Fulgham.
761
762         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
763         (TEST):
764         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
765         (TEST):
766
767 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
768
769         Unreviewed infrastructure fix.
770
771         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
772         while the hardware is out for repair.
773
774 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
775
776         [WebXR] IDLs, stubs and build configuration for WPE
777         https://bugs.webkit.org/show_bug.cgi?id=208702
778
779         Reviewed by Dean Jackson.
780
781         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
782         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
783
784 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
785
786         [Cocoa] Limit set of classes that can be decoded when a preference has changed
787         https://bugs.webkit.org/show_bug.cgi?id=208012
788
789         Reviewed by Brent Fulgham.
790
791         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
792         (TEST):
793
794 2020-03-16  youenn fablet  <youenn@apple.com>
795
796         Unique origins should not be Potentially Trustworthy
797         https://bugs.webkit.org/show_bug.cgi?id=209049
798
799         Reviewed by Darin Adler.
800
801         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
802         (TestWebKitAPI::TEST_F):
803
804 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
805
806         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
807         https://bugs.webkit.org/show_bug.cgi?id=207324
808
809         Reviewed by Darin Adler.
810
811         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
812         (TestWebKitAPI::generateRandomData): Added.
813         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
814
815 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
816
817         Should not use variable-length-array (VLA)
818         https://bugs.webkit.org/show_bug.cgi?id=209043
819
820         Reviewed by Mark Lam.
821
822         * ContentExtensionTester/Configurations/Base.xcconfig:
823         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
824
825 2020-03-13  Alex Christensen  <achristensen@webkit.org>
826
827         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
828         https://bugs.webkit.org/show_bug.cgi?id=209011
829         <rdar://problem/59370588>
830
831         Reviewed by Youenn Fablet.
832
833         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
834         (TestWebKitAPI::TEST):
835
836 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
837
838         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
839         https://bugs.webkit.org/show_bug.cgi?id=209089
840
841         Reviewed by Tim Horton.
842
843         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
844         marketing name for the feature.
845
846         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
847         (runUntilReceivesAutoplayEvent):
848
849         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
850         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
851         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
852         be any compelling reason to compare against different types here (especially since we only set
853         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
854         these all to be `_WKAutoplayEvent`.
855
856         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
857         (-[AutoFillTestView _autofillInputView]):
858         (-[AutoFillTestView textInputHasAutoFillContext]):
859         (TestWebKitAPI::TEST):
860         (-[AutofillTestView initWithFrame:]): Deleted.
861         (-[AutofillTestView _autofillInputView]): Deleted.
862         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
863         * TestWebKitAPI/ios/UIKitSPI.h:
864
865 2020-03-13  Chris Dumez  <cdumez@apple.com>
866
867         Unreviewed, reverting r256232.
868
869         Caused ResizeObserver tests to become flaky
870
871         Reverted changeset:
872
873         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
874         override TestOptions"
875         https://bugs.webkit.org/show_bug.cgi?id=207481
876         https://trac.webkit.org/changeset/256232
877
878 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
879
880         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
881         https://bugs.webkit.org/show_bug.cgi?id=209016
882         <rdar://problem/60329530> 
883
884         Reviewed by Chris Dumez.
885
886         Re-initialize the app-bound domains when the correct
887         TestOptions parameter is set.
888
889         * WebKitTestRunner/TestController.cpp:
890         (WTR::TestController::createWebViewWithOptions):
891         (WTR::TestController::reinitializeAppBoundDomains):
892         * WebKitTestRunner/TestController.h:
893
894 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
895
896         Report all third party loads on a per-page basis
897         https://bugs.webkit.org/show_bug.cgi?id=209032
898         <rdar://problem/60397323>
899
900         Reviewed by Chris Dumez.
901
902         Mostly naming updates to reflect the change in use for this SPI call.
903         It now returns all loaded third party domains, not just prevalent ones.
904
905         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
906         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
907         (WTR::InjectedBundle::didReceiveMessageToPage):
908         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
909         (WTR::TestRunner::getLoadedThirdPartyDomains):
910         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
911         (WTR::TestRunner::getPrevalentDomains): Deleted.
912         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
913         * WebKitTestRunner/InjectedBundle/TestRunner.h:
914         * WebKitTestRunner/TestController.cpp:
915         (WTR::TestController::resetStateToConsistentValues):
916         (WTR::TestController::getLoadedThirdPartyDomains):
917         (WTR::TestController::clearLoadedThirdPartyDomains):
918         (WTR::TestController::getPrevalentDomains): Deleted.
919         (WTR::TestController::clearPrevalentDomains): Deleted.
920         * WebKitTestRunner/TestController.h:
921         * WebKitTestRunner/TestInvocation.cpp:
922         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
923         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
924         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
925         * WebKitTestRunner/TestInvocation.h:
926         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
927         (WTR::TestController::getLoadedThirdPartyDomains):
928         (WTR::TestController::clearLoadedThirdPartyDomains):
929         (WTR::TestController::getPrevalentDomains): Deleted.
930         (WTR::TestController::clearPrevalentDomains): Deleted.
931
932 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
933
934         [ews] run FindModifiedChangeLogs early in the build
935         https://bugs.webkit.org/show_bug.cgi?id=209060
936
937         Reviewed by Jonathan Bedard.
938
939         * BuildSlaveSupport/ews-build/factories.py:
940         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
941
942 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
943
944         [GTK] Add EWS testers to run GTK layout tests
945         https://bugs.webkit.org/show_bug.cgi?id=207648
946
947         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
948
949         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
950         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
951         tests (layout tests).
952
953         * BuildSlaveSupport/ews-build/config.json: Added new queue for
954         WK2 tests.
955         * BuildSlaveSupport/ews-build/factories.py:
956         (GTKTestsFactory):
957         * BuildSlaveSupport/ews-build/factories_unittest.py:
958         (TestCommitQueueFactory.test_commit_queue_factory):
959         (TestGTKFactory): Added unit-test.
960         (TestGTKFactory.test_gtk_factory):
961         * BuildSlaveSupport/ews-build/loadConfig.py:
962         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
963         (TagsForBuilderTest.test_getTagsForBuilder):
964
965 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
966
967         Add API endpoint in EWS django app to provide patch status in json format
968         https://bugs.webkit.org/show_bug.cgi?id=208940
969
970         Reviewed by Jonathan Bedard.
971
972         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
973         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
974
975 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
976
977         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
978         https://bugs.webkit.org/show_bug.cgi?id=209055
979         <rdar://problem/60272692>
980
981         Reviewed by Simon Fraser.
982
983         Now that WebKitTestRunner has a bundleID, its' user default values
984         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
985         to NO before running tests. It will be set to YES in PlatformWebView
986         if specified by the test.
987
988         * WebKitTestRunner/mac/main.mm:
989         (setDefaultsToConsistentValuesForTesting):
990
991 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
992
993         [CMake] Eleminate mismatches between Find* module names and variables they set
994         https://bugs.webkit.org/show_bug.cgi?id=208948
995
996         Reviewed by Michael Catanzaro.
997
998         * wpe/backends/CMakeLists.txt:
999
1000 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1001
1002         [ews-app] reduce logging
1003         https://bugs.webkit.org/show_bug.cgi?id=209062
1004
1005         Reviewed by Jonathan Bedard.
1006
1007         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1008         (BugzillaBeautifulSoup.authenticate):
1009         (BugzillaBeautifulSoup._load_query):
1010
1011 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
1012
1013         Crash in TextIterator::node via TextManipulationController::replace
1014         https://bugs.webkit.org/show_bug.cgi?id=209048
1015
1016         Reviewed by Wenson Hsieh.
1017
1018         Added a regression test.
1019
1020         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1021         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
1022
1023 2020-03-13  Saam Barati  <sbarati@apple.com>
1024
1025         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1026         https://bugs.webkit.org/show_bug.cgi?id=209038
1027
1028         Reviewed by Keith Miller.
1029
1030         This allows us to automatically pull in some tests that are in non open sourced Apple
1031         checkouts.
1032
1033         * Scripts/run-javascriptcore-tests:
1034         (runJSCStressTests):
1035
1036 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1037
1038         Crash in TextManipulationController::replace
1039         https://bugs.webkit.org/show_bug.cgi?id=209021
1040
1041         Reviewed by Wenson Hsieh.
1042
1043         Added a regression test.
1044
1045         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1046         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1047
1048 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1049
1050         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1051         https://bugs.webkit.org/show_bug.cgi?id=208953
1052
1053         Reviewed by Brent Fulgham.
1054
1055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1056
1057 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1058
1059         Resource load statistics data summary should return all third party data
1060         https://bugs.webkit.org/show_bug.cgi?id=209000
1061         <rdar://problem/60348306>
1062
1063         Reviewed by John Wilander.
1064
1065         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1066         the call returns all third parties, not just prevalent ones.
1067         Added a more aggressive check for the size of the array at the
1068         beginning of the test to ensure the array is still returning 3 values. 
1069         Also removed the ASSERT statements as they seem to cause timeouts (not
1070         clear crashes) when they are not true, which is hard to debug.
1071         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1072         checks, we don't need ASSERT statements.
1073
1074         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1075         (TEST):
1076
1077 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1078
1079         resultsdpy: Add script to run local instance
1080         https://bugs.webkit.org/show_bug.cgi?id=208746
1081
1082         Rubber-stamped by Aakash Jain.
1083
1084         * resultsdbpy/resultsdbpy/example: Added.
1085         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1086         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1087         (Environment): Organize environment variables used by results database.
1088         (ModelFromEnvironment): Construct the database model from the environment.
1089         (main): Create and drop tables, if required.
1090         * resultsdbpy/resultsdbpy/example/main.py: Added.
1091         (health): Web-server health check.
1092         (handle_errors):
1093         (main): Run results database web-server.
1094         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1095         (main): Asynchronously process uploaded results.
1096         * resultsdbpy/resultsdbpy/run: Added.
1097
1098 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1099
1100         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1101         https://bugs.webkit.org/show_bug.cgi?id=209004
1102
1103         Reviewed by Tim Horton.
1104
1105         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1106         `use_gpu_process` is specified.
1107
1108         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1109         (parse_args):
1110
1111 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1112
1113         Make flatpack import for run-webkit-tests only happen on linux systems
1114         https://bugs.webkit.org/show_bug.cgi?id=208954
1115
1116         Reviewed by Philippe Normand.
1117
1118         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1119         to determine if we need the flatpackutils import. 
1120
1121 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1122
1123         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1124         https://bugs.webkit.org/show_bug.cgi?id=207609
1125
1126         Reviewed by Ryosuke Niwa.
1127
1128         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1129         (TestWebKitAPI::TEST):
1130
1131 2020-03-12  Daniel Bates  <dabates@apple.com>
1132
1133         FocusController::setFocusedElement() should tell client of refocused element
1134         https://bugs.webkit.org/show_bug.cgi?id=208880
1135
1136         Reviewed by Wenson Hsieh.
1137
1138         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1139         to start an input session. Currently, it does not even try.
1140
1141         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1142         (TEST):
1143
1144 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1145
1146         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1147         https://bugs.webkit.org/show_bug.cgi?id=208970
1148
1149         Reviewed by Daniel Bates.
1150
1151         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1152         #!/usr/bin/env python.
1153
1154         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1155         probably has similar rules.
1156
1157         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1158         Everything else that does so is probably only used by webkit-build.
1159
1160         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1161
1162         * gtkdoc/generate-gtkdoc:
1163
1164 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1165
1166         [WebAuthn] Formalize the Keychain schema
1167         https://bugs.webkit.org/show_bug.cgi?id=183533
1168         <rdar://problem/43347926>
1169
1170         Reviewed by Brent Fulgham.
1171
1172         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1173         the original combination of RP ID and user handle.
1174
1175         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1177         (WTR::TestRunner::cleanUpKeychain):
1178         (WTR::TestRunner::keyExistsInKeychain):
1179         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1180         * WebKitTestRunner/TestController.h:
1181         * WebKitTestRunner/TestInvocation.cpp:
1182         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1183         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1184         (WTR::TestController::cleanUpKeychain):
1185         (WTR::TestController::keyExistsInKeychain):
1186
1187 2020-03-11  Keith Miller  <keith_miller@apple.com>
1188
1189         Test262-runner should always consider crashes as new failures
1190         https://bugs.webkit.org/show_bug.cgi?id=208943
1191
1192         Reviewed by Yusuke Suzuki.
1193
1194         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1195         Since we should never crash on a conformance test we should consider a crash as a new failure
1196         100% of the time.
1197
1198         * Scripts/test262/Runner.pm:
1199         (processFile):
1200         (runTest):
1201         (processResult):
1202
1203 2020-03-11  Chris Dumez  <cdumez@apple.com>
1204
1205         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1206         https://bugs.webkit.org/show_bug.cgi?id=208927
1207         <rdar://problem/55448331>
1208
1209         Reviewed by Alex Christensen.
1210
1211         Add API test coverage.
1212
1213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1214
1215 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1216
1217         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1218         https://bugs.webkit.org/show_bug.cgi?id=208860
1219
1220         Reviewed by Carlos Alberto Lopez Perez.
1221
1222         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1223         (StatusBubble): Added 'api-gtk'.
1224         * BuildSlaveSupport/ews-build/config.json:
1225         * BuildSlaveSupport/ews-build/factories.py:
1226         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1227         GTK.
1228         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1229         GTK.
1230         (GTKBuildFactory):
1231         (GTKBuildFactory.__init__): Deleted.
1232         (GTKBuildAndTestFactory): Deleted.
1233         (GTKBuildAndTestFactory.__init__): Deleted.
1234         (GTKAPIBuildAndTestFactory): Deleted.
1235         * BuildSlaveSupport/ews-build/loadConfig.py:
1236
1237 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [ews] Add unit test to prevent multiple schedulers for a builder.
1240         https://bugs.webkit.org/show_bug.cgi?id=208917
1241
1242         Reviewed by Carlos Alberto Lopez Perez.
1243
1244         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1245         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1246         (TagsForBuilderTest): Fixed a typo.
1247
1248 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1249
1250         [GTK] Failing API tests under the Flatpak SDK environment
1251         https://bugs.webkit.org/show_bug.cgi?id=208871
1252
1253         Reviewed by Michael Catanzaro.
1254
1255         The load-failed signal callback should return a boolean result,
1256         otherwise we enter in unknown territory depending on how the
1257         toolchain compiles this, possibly triggering bad behavior (with
1258         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1259         GCC toolchain on buildbots).
1260
1261         Patch suggested by Michael Catanzaro.
1262
1263         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1264         (loadFailedCallback):
1265
1266 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1267
1268         Sync FeatureList.pm with CMake definitions
1269         https://bugs.webkit.org/show_bug.cgi?id=208866
1270
1271         Reviewed by Michael Catanzaro.
1272
1273         * Scripts/webkitperl/FeatureList.pm:
1274
1275 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1276
1277         [ews] Add unit tests for commit queue factory
1278         https://bugs.webkit.org/show_bug.cgi?id=208862
1279
1280         Reviewed by Jonathan Bedard.
1281
1282         * BuildSlaveSupport/ews-build/factories_unittest.py:
1283         (TestCommitQueueFactory):
1284         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1285
1286 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1287
1288         [ews-app] Status bubble should only display important messages in pop-over - part 3
1289         https://bugs.webkit.org/show_bug.cgi?id=208865
1290
1291         Reviewed by Jonathan Bedard.
1292
1293         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1294         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1295
1296 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1297
1298         [WPE] MiniBrowser: Close child WebViews when exiting
1299         https://bugs.webkit.org/show_bug.cgi?id=208689
1300
1301         Reviewed by Carlos Garcia Campos.
1302
1303         Store created views so we can release them before exiting.
1304
1305         * MiniBrowser/wpe/main.cpp:
1306         (webViewClose):
1307         (createWebView):
1308         (main):
1309
1310 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1311
1312         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1313         https://bugs.webkit.org/show_bug.cgi?id=208861
1314
1315         Reviewed by Jonathan Bedard.
1316
1317         * BuildSlaveSupport/ews-build/factories.py:
1318         (Factory.__init__): Remove verifycqplus parameter.
1319         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1320         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1321         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1322
1323 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1324
1325         [GTK] API favicon test flaky timeouts
1326         https://bugs.webkit.org/show_bug.cgi?id=208189
1327
1328         Reviewed by Carlos Garcia Campos.
1329
1330         Sometimes the favicon changes already during the load. Keeping
1331         track of it in the WebView favicon property notification handler
1332         gets us rid of the race.
1333
1334         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1335         (testFaviconDatabaseGetFavicon):
1336
1337 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1338
1339         Generate commit-queue status bubble from new EWS
1340         https://bugs.webkit.org/show_bug.cgi?id=208811
1341
1342         Reviewed by Jonathan Bedard.
1343
1344         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1345         (StatusBubble._build_bubbles_for_patch):
1346
1347 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1348
1349         Remove obsolete feature flags
1350         https://bugs.webkit.org/show_bug.cgi?id=208830
1351
1352         Reviewed by Alex Christensen.
1353
1354         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1355         are no longer used.
1356
1357         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1358         when the compilation flag was removed in r258148.
1359
1360         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1361         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1362
1363         * Scripts/webkitperl/FeatureList.pm:
1364         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1365
1366 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1367
1368         WebKitTestRunner bundleID should not be cleared before every test
1369         https://bugs.webkit.org/show_bug.cgi?id=208823
1370         <rdar://problem/60204539>
1371
1372         Reviewed by Per Arne Vollan.
1373
1374         This is causing test failures for layout tests which rely on the Info.plist 
1375         bundle identifier (not the one set via the override method).
1376
1377         * WebKitTestRunner/TestController.cpp:
1378         (WTR::TestController::createWebViewWithOptions):
1379         (WTR::TestController::ensureViewSupportsOptionsForTest):
1380         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1381
1382 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1383
1384         [macOS] Notification observer is not removed
1385         https://bugs.webkit.org/show_bug.cgi?id=208834
1386
1387         Reviewed by Tim Horton.
1388
1389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1390         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1391         (TEST):
1392
1393 2020-03-06  Brian Burg  <bburg@apple.com>
1394
1395         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1396         https://bugs.webkit.org/show_bug.cgi?id=208729
1397         <rdar://problem/60105447>
1398
1399         Reviewed by Jonathan Bedard.
1400
1401         Improve upload.py to look for the svn branch and revision for the 'webkit'
1402         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1403
1404         * Scripts/webkitpy/common/checkout/scm/git.py:
1405         (Git):
1406         (Git.git_svn_id_regexp):
1407         (Git._field_from_git_svn_id):
1408         (Git.svn_revision):
1409         (Git.svn_branch):
1410         (Git.svn_url):
1411         (Git.native_branch):
1412         Refactor svn revision, branch, url to use the same regexp and helper code.
1413
1414         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1415         (StubRepository.svn_branch):
1416         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1417
1418         * Scripts/webkitpy/common/checkout/scm/svn.py:
1419         (SVN.svn_branch):
1420         (SVN.native_revision):
1421         (SVN):
1422         (SVN.native_branch):
1423         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1424         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1425
1426         * Scripts/webkitpy/port/base.py:
1427         (Port.commits_for_upload):
1428         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1429         is preferred over the git equivalents.
1430
1431 2020-03-09  Antoine Quint  <graouts@apple.com>
1432
1433         TestWebKitAPI fails to build on watchOS
1434         https://bugs.webkit.org/show_bug.cgi?id=208820
1435
1436         Reviewed by Tim Horton.
1437
1438         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1439
1440 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
1441
1442         resultsdbpy: Add tool to manage resultsdbpy container
1443         https://bugs.webkit.org/show_bug.cgi?id=208743
1444
1445         Rubber-stamped by Aakash Jain.
1446
1447         Add tool to start, stop and restart the resultsdbpy Docker container.
1448
1449         * resultsdbpy/resultsdbpy/container: Added.
1450
1451 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1452
1453         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
1454         https://bugs.webkit.org/show_bug.cgi?id=208706
1455
1456         Reviewed by Žan Doberšek.
1457
1458         Add test case to check surrounding text in multiline context.
1459
1460         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1461         (testWebKitInputMethodContextSurrounding):
1462
1463 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
1464
1465         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
1466         https://bugs.webkit.org/show_bug.cgi?id=208783
1467
1468         Reviewed by Brent Fulgham.
1469
1470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1471
1472 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
1473
1474         Replace the use of term "rollout" to "revert" in various tools
1475         https://bugs.webkit.org/show_bug.cgi?id=208775
1476
1477         Reviewed by Ryosuke Niwa.
1478
1479         See this webkit-dev thread for the originating discussion:
1480         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
1481
1482         'rollout' is a confusing term to anyone unacquainted with WebKit;
1483         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
1484
1485         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
1486         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
1487
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1496         * BuildSlaveSupport/ews-build/steps.py:
1497         * BuildSlaveSupport/ews-build/steps_unittest.py:
1498         * Scripts/webkit-tools-completion.sh:
1499         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1500         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1501         * Scripts/webkitpy/common/checkout/scm/svn.py:
1502         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1503         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1504         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1505         * Scripts/webkitpy/tool/bot/feeders.py:
1506         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1507         * Scripts/webkitpy/tool/bot/irc_command.py:
1508         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1509         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1510         * Scripts/webkitpy/tool/bot/sheriff.py:
1511         * Scripts/webkitpy/tool/commands/download.py:
1512         * Scripts/webkitpy/tool/commands/download_unittest.py:
1513         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1514         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1515         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1516         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1517         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1518         * Scripts/webkitpy/tool/steps/__init__.py:
1519         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1520         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1521         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1522         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
1523
1524 2020-03-07  David Quesada  <david_quesada@apple.com>
1525
1526         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
1527         https://bugs.webkit.org/show_bug.cgi?id=208781
1528         rdar://problem/60061016
1529
1530         Reviewed by Alex Christensen.
1531
1532         Add a test that recreates the conditions of this crash:
1533         - Send a message from the injected bundle to the UI process that contains a reply block.
1534         - Hold a reference to the reply block.
1535         - Let the web view deallocate.
1536         - Call the block, and expect not to crash.
1537
1538         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1539         (localObjectInterface):
1540         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1541         (-[LocalObject doSomethingWithCompletionHandler:]):
1542         (TEST):
1543         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1544         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
1545
1546 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1547
1548         TextManipulationController should work with ARIA labels
1549         https://bugs.webkit.org/show_bug.cgi?id=208759
1550
1551         Reviewed by Wenson Hsieh.
1552
1553         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1554         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
1555         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
1556         the expected number of tokens for the first item as the very first image is correctly
1557         detected per the code change. 
1558         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
1559
1560 2020-03-07  Alex Christensen  <achristensen@webkit.org>
1561
1562         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
1563         https://bugs.webkit.org/show_bug.cgi?id=208767
1564
1565         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1566         The frameID of the main frame before loading is only 0 on Mac right now.
1567         The test is still good because it validates that execution works in the main frame before loading.
1568
1569 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1570
1571         [ews] commit queue is not skipping layout tests for rollout patches
1572         https://bugs.webkit.org/show_bug.cgi?id=208716
1573
1574         Unreviewed minor fix.
1575
1576         * BuildSlaveSupport/ews-build/steps.py:
1577         (RunWebKitTests.doStepIf):
1578         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
1579         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1580
1581 2020-03-05  Sam Weinig  <weinig@apple.com>
1582
1583         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
1584         https://bugs.webkit.org/show_bug.cgi?id=207436
1585         <rdar://problem/59296762>
1586
1587         Reviewed by Darin Adler.
1588
1589         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1590         Remove JSC related defines.
1591
1592 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
1593
1594         AX: Provide a way to run tests in isolated tree mode
1595         https://bugs.webkit.org/show_bug.cgi?id=208629
1596         <rdar://problem/60075583>
1597
1598         Reviewed by Ryosuke Niwa.
1599
1600         Provide the ability to run tests for accessibility in the isolated tree mode.
1601         This sends a flag over to the injected bundle which calls the right HIServices override so that
1602         the system thinks it is in isolated mode.
1603
1604         * Scripts/compare-webkit-configurations:
1605         (flag_for_comparison):
1606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1607         (parse_args):
1608         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1609         (parse_args):
1610         * Scripts/webkitpy/port/driver.py:
1611         (Driver.cmd_line):
1612         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1613         (WTR::AccessibilityController::AccessibilityController):
1614         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
1615         (WTR::AccessibilityController::updateIsolatedTreeMode):
1616         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
1617         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1618         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1619         (WTR::InjectedBundle::didReceiveMessageToPage):
1620         (WTR::InjectedBundle::beginTesting):
1621         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1622         * WebKitTestRunner/Options.cpp:
1623         (WTR::handleOptionAccessibilityIsolatedTreeMode):
1624         (WTR::OptionsHandler::OptionsHandler):
1625         * WebKitTestRunner/Options.h:
1626         * WebKitTestRunner/TestController.cpp:
1627         (WTR::TestController::initialize):
1628         (WTR::TestController::resetPreferencesToConsistentValues):
1629         (WTR::TestController::resetStateToConsistentValues):
1630         * WebKitTestRunner/TestController.h:
1631         (WTR::TestController::accessibilityIsolatedTreeMode const):
1632
1633 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
1634
1635         [Cocoa] Re-enable CFPrefs direct mode
1636         https://bugs.webkit.org/show_bug.cgi?id=208690
1637
1638         Reviewed by Brent Fulgham.
1639
1640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1641         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
1642         (TEST):
1643         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1644         (TestWebKitAPI::TEST):
1645
1646 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
1647
1648         UIProcess needs mechanism to specify AppBound domains
1649         https://bugs.webkit.org/show_bug.cgi?id=208528
1650         <rdar://problem/59980340>
1651
1652         Reviewed by Brent Fulgham.
1653
1654         Added test app-bound domains to the plist and tested that the domains
1655         are properly stored in the website data store after a navigation.
1656
1657         * TestWebKitAPI/Info.plist:
1658         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1659         (TEST):
1660
1661 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1662
1663         Add SPI to disable cross origin access control checks
1664         https://bugs.webkit.org/show_bug.cgi?id=208748
1665
1666         Reviewed by Tim Hatcher.
1667
1668         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1669         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
1670
1671 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
1672
1673         [webkitpy] Fix executive on Windows to run wpt server correctly
1674         https://bugs.webkit.org/show_bug.cgi?id=208693
1675
1676         Reviewed by Jonathan Bedard.
1677
1678         Bug fix for Windows environment a) fixing a typo. b) fixing path
1679         c) fix how to kill subprocesses.
1680
1681         * Scripts/webkitpy/common/system/executive.py:
1682         (Executive._windows_kill_command):
1683         (Executive.interrupt):
1684         (Executive.kill_all):
1685         * Scripts/webkitpy/port/base.py:
1686         (Port.web_platform_test_server_doc_root):
1687
1688 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1689
1690         Evaluating JavaScript in main frame before loading should succeed
1691         https://bugs.webkit.org/show_bug.cgi?id=208733
1692
1693         Reviewed by Tim Horton.
1694
1695         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1696
1697 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
1698
1699         TextManipulationController should preserve images
1700         https://bugs.webkit.org/show_bug.cgi?id=208692
1701
1702         Reviewed by Wenson Hsieh.
1703
1704         Added tests for preserving images and their ordering.
1705
1706         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1707         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
1708         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
1709         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
1710
1711 2020-03-06  David Quesada  <david_quesada@apple.com>
1712
1713         Add _WKResourceLoadInfo.resourceType SPI
1714         https://bugs.webkit.org/show_bug.cgi?id=208723
1715
1716         Reviewed by Alex Christensen.
1717
1718         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1719         (TEST):
1720
1721 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
1722
1723         Stop reporting to webkit-test-results.webkit.org
1724         https://bugs.webkit.org/show_bug.cgi?id=207218
1725
1726         Reviewed by Alexey Proskuryakov.
1727
1728         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1729         (RunWebKitTests):
1730
1731 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
1732
1733         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1734         https://bugs.webkit.org/show_bug.cgi?id=208365
1735         <rdar://problem/59877296>
1736
1737         Reviewed by Geoffrey Garen.
1738
1739         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1740         (TEST):
1741
1742 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1743
1744         EWS should be able to fetch patch status for security bugs while processing them
1745         https://bugs.webkit.org/show_bug.cgi?id=206511
1746
1747         Reviewed by Alexey Proskuryakov.
1748
1749         * BuildSlaveSupport/ews-build/steps.py:
1750         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
1751         (BugzillaMixin.get_patch_json): 
1752         (BugzillaMixin.get_bug_json):
1753         (BugzillaMixin._is_bug_closed):
1754         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
1755         (TransferToS3.hideStepIf): Ditto.
1756
1757 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1758
1759         [ews] commit-queue should show the trac url for the commit on the build page
1760         https://bugs.webkit.org/show_bug.cgi?id=208715
1761
1762         Reviewed by Jonathan Bedard.
1763
1764         * BuildSlaveSupport/ews-build/steps.py:
1765         (PushCommitToWebKitRepo.evaluateCommand):
1766
1767 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1768
1769         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1770         https://bugs.webkit.org/show_bug.cgi?id=208550
1771
1772         * TestWebKitAPI/cocoa/HTTPServer.mm:
1773         (TestWebKitAPI::HTTPServer::respondToRequests):
1774         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1775         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1776
1777 2020-03-06  Lauro Moura <lmoura@igalia.com>
1778
1779         [WPE][WebDriver] MiniBrowser should react to close session commands
1780         https://bugs.webkit.org/show_bug.cgi?id=207529
1781
1782         Reviewed by Carlos Garcia Campos.
1783
1784         Do not call g_object_unref on the first created view if it has already
1785         been disposed in the "close" signal handler.
1786
1787         Based on original patch by Yury Semikhatsky.
1788
1789         * MiniBrowser/wpe/main.cpp:
1790         (main):
1791
1792 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1793
1794         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1795         https://bugs.webkit.org/show_bug.cgi?id=208647
1796
1797         Reviewed by Carlos Garcia Campos.
1798
1799         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1800         (TestWebKitAPI::TEST):
1801
1802 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1803
1804         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1805         https://bugs.webkit.org/show_bug.cgi?id=208670
1806
1807         Reviewed by Brady Eidson.
1808
1809         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1810         (-[FrameNavigationDelegate waitForNavigations:]):
1811         (-[FrameNavigationDelegate requests]):
1812         (-[FrameNavigationDelegate frames]):
1813         (-[FrameNavigationDelegate callbacks]):
1814         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1815         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1816         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1817         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1818         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1819         (TEST):
1820
1821 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1822
1823         Add WKFrameInfo._parentFrameHandle SPI
1824         https://bugs.webkit.org/show_bug.cgi?id=208674
1825
1826         Reviewed by Brady Eidson.
1827
1828         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1829
1830 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1831
1832         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1833         https://bugs.webkit.org/show_bug.cgi?id=208626
1834         <rdar://problem/60074148>
1835
1836         Reviewed by Brent Fulgham.
1837
1838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1839         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1840         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1841         (TestWebKitAPI::TEST):
1842         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1843         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1844         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1845
1846 2020-03-05  Antoine Quint  <graouts@apple.com>
1847
1848         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1849         https://bugs.webkit.org/show_bug.cgi?id=208644
1850         <rdar://problem/60042429>
1851
1852         Reviewed by Brady Eidson.
1853
1854         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1855         
1856         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1857            empty document has been removed in favor of the document for the requested URL,
1858         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1859            correctly does not injected the style sheet.
1860
1861         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1862
1863 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1864
1865         [ews] Add build step to push commit to WebKit repository
1866         https://bugs.webkit.org/show_bug.cgi?id=208589
1867
1868         Reviewed by Jonathan Bedard.
1869
1870         * BuildSlaveSupport/ews-build/steps.py:
1871         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1872         (PushCommitToWebKitRepo.start): Initialize log observer.
1873         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1874         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1875         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1876         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1877         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1878         * BuildSlaveSupport/ews-build/factories.py:
1879
1880 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1881
1882         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1883         https://bugs.webkit.org/show_bug.cgi?id=208262
1884
1885         Reviewed by Jonathan Bedard.
1886
1887         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1888
1889 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1890
1891         commit-queue should run WK2 tests instead of WK1 tests
1892         https://bugs.webkit.org/show_bug.cgi?id=208544
1893
1894         Reviewed by Jonathan Bedard.
1895
1896         * BuildSlaveSupport/ews-build/factories.py:
1897
1898 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1899
1900         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
1901         https://bugs.webkit.org/show_bug.cgi?id=208645
1902
1903         Reviewed by Alexey Proskuryakov.
1904
1905         * BuildSlaveSupport/ews-build/steps.py:
1906         (ValidateCommiterAndReviewer.load_contributors):
1907         (ValidateCommiterAndReviewer.start):
1908
1909 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1910
1911         style-checker: Add UAF to the list of security words to warn about.
1912         https://bugs.webkit.org/show_bug.cgi?id=208643
1913
1914         Reviewed by Jonathan Bedard.
1915
1916         UAF is a common acronym used for use after free.
1917
1918         * Scripts/webkitpy/style/checkers/changelog.py:
1919         (ChangeLogChecker.check_for_unwanted_security_phrases):
1920
1921 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
1922
1923         [MSVC] Add .natvis support of WebKit types
1924         https://bugs.webkit.org/show_bug.cgi?id=193119
1925
1926         Reviewed by Don Olmstead.
1927
1928         To help the WebKit developer while debugging, this file defines how
1929         WebKit types are displayed in debugger of Visual Studio.
1930         Very limited set of WebKit types, but it changes the world.
1931
1932         * VisualStudio/WebKit.natvis: Added.
1933
1934 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1935
1936         Add system trace points around display list replay
1937         https://bugs.webkit.org/show_bug.cgi?id=208616
1938
1939         Reviewed by Simon Fraser.
1940
1941         Add a new "Display list replay" trace point.
1942
1943         * Tracing/SystemTracePoints.plist:
1944
1945 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1946
1947         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
1948         https://bugs.webkit.org/show_bug.cgi?id=208615
1949         <rdar://problem/59406743>
1950
1951         Reviewed by Alex Christensen.
1952
1953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1954         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
1955         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1956         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1957         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1958         (TEST):
1959         Also make a test written in bug 206310 actually run code.
1960
1961 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1962
1963         [build.webkit.org] Remove leaks queue
1964         https://bugs.webkit.org/show_bug.cgi?id=208580
1965
1966         Reviewed by Jonathan Bedard.
1967
1968         * BuildSlaveSupport/build.webkit.org-config/config.json:
1969         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1971
1972 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1973
1974         Add SPI to evaluate JavaScript in an iframe
1975         https://bugs.webkit.org/show_bug.cgi?id=208605
1976
1977         Reviewed by Brady Eidson.
1978
1979         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1980
1981 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
1982
1983         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
1984         https://bugs.webkit.org/show_bug.cgi?id=208533
1985         <rdar://problem/60010184>
1986
1987         Reviewed by Alex Christensen.
1988
1989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1990         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1991         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
1992         (TestWebKitAPI::TEST):
1993         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
1994         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
1995
1996 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1997
1998         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
1999         https://bugs.webkit.org/show_bug.cgi?id=208593
2000
2001         Reviewed by Brady Eidson.
2002
2003         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2004         (TestWebKitAPI::TEST):
2005
2006 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2007
2008         WKWebView's frames accessor should return a traversable type
2009         https://bugs.webkit.org/show_bug.cgi?id=208591
2010
2011         Reviewed by Brady Eidson.
2012
2013         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2014
2015 2020-03-04  Antoine Quint  <graouts@apple.com>
2016
2017         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
2018         https://bugs.webkit.org/show_bug.cgi?id=208575
2019         <rdar://problem/59773690>
2020
2021         Reviewed by Brady Eidson.
2022
2023         Add new tests for the new SPI which check:
2024         
2025         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2026            specified WKWebView alone,
2027         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2028         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2029         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2030         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2031         6. and that the same test also works with PSON enabled.
2032
2033         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2034
2035 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2036
2037         [macOS] test-lldb-webkit failing on debug bots
2038         https://bugs.webkit.org/show_bug.cgi?id=208545
2039
2040         Reviewed by Jonathan Bedard.
2041
2042         The lldb-webkit-test step must pass in the build configuration as an
2043         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2044         binary that is downloaded with the rest of the build products. Without this
2045         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2046         regardless of their actual build configuration.
2047
2048         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2049         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2050         * Scripts/test-lldb-webkit:
2051         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2052
2053 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2054
2055         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2056         https://bugs.webkit.org/show_bug.cgi?id=208539
2057
2058         Unreviewed follow-up fix.
2059
2060         * BuildSlaveSupport/ews-build/steps.py:
2061
2062 2020-03-04  Daniel Bates  <dabates@apple.com>
2063
2064         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2065         https://bugs.webkit.org/show_bug.cgi?id=208565
2066
2067         Reviewed by Wenson Hsieh.
2068
2069         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2070         of its frame as a means to find all the editable elements in the visible content area
2071         of the web view.
2072
2073         Coincidentally this makes no difference to the test results right now because the web view
2074         happens to be located at the origin (0, 0) in the window. However if in the future the
2075         web view would be located at some other point then the tests may fail because the rectangle
2076         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2077         rectangle for the visible content area.
2078
2079         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2080         (TEST):
2081
2082 2020-03-04  Daniel Bates  <dabates@apple.com>
2083
2084         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2085         https://bugs.webkit.org/show_bug.cgi?id=208564
2086
2087         Reviewed by Alex Christensen.
2088
2089         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2090         to make it easy to run just these tests.
2091
2092         Currently, the tests are organized under the test case name WebKit. This means you need to
2093         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2094         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2095         so that a person can run just these test using:
2096         
2097                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2098
2099         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2100         (TEST):
2101
2102 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2103
2104         [ews] Add build step to create local git commit for commit-queue
2105         https://bugs.webkit.org/show_bug.cgi?id=208539
2106
2107         Reviewed by Jonathan Bedard.
2108
2109         * BuildSlaveSupport/ews-build/steps.py:
2110         (CreateLocalGITCommit): Build step to create local git commit.
2111         (CreateLocalGITCommit.start):
2112         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2113         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2114         * BuildSlaveSupport/ews-build/factories.py:
2115
2116 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2117
2118         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2119         https://bugs.webkit.org/show_bug.cgi?id=207948
2120
2121         Reviewed by Zalan Bujtas.
2122
2123         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2124         so that it receives the wheel events.
2125
2126         * DumpRenderTree/mac/EventSendingController.mm:
2127         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2128         * DumpRenderTree/win/EventSender.cpp:
2129         (mouseScrollBy):
2130
2131 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2132
2133         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2134         https://bugs.webkit.org/show_bug.cgi?id=208520
2135         <rdar://problem/60000214>
2136
2137         Reviewed by Chris Fleizach.
2138
2139         Calling InjectedBundle::singleton().page()->page() in the constructor
2140         of the AccessibilityController is having this side effect on iOS.
2141         So #if to MAC where it's actually being used.
2142
2143         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2144         (WTR::AccessibilityController::AccessibilityController):
2145
2146 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2147
2148         Add SPI _WKResourceLoadInfo.loadedFromCache
2149         https://bugs.webkit.org/show_bug.cgi?id=208554
2150
2151         Reviewed by Wenson Hsieh.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2154         (TEST):
2155
2156 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2157
2158         Batch observations and completions of text manipulations
2159         https://bugs.webkit.org/show_bug.cgi?id=208406
2160
2161         Reviewed by Wenson Hsieh.
2162
2163         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2164         multiple paragraphs at once.
2165
2166         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2167         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2168         (-[TextManipulationDelegate items]):
2169         (-[LegacyTextManipulationDelegate init]):
2170         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2171         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2172         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2173         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2174         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2175         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2176         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2177
2178 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2179
2180         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2181         https://bugs.webkit.org/show_bug.cgi?id=208415
2182
2183         Reviewed by Brent Fulgham.
2184
2185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2186         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2187         (TEST):
2188
2189 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2190
2191         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2192         https://bugs.webkit.org/show_bug.cgi?id=208553
2193
2194         Reviewed by Simon Fraser.
2195
2196         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2197         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2198         (TEST):
2199         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2200
2201 2020-03-03  Brady Eidson  <beidson@apple.com>
2202
2203         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2204         https://bugs.webkit.org/show_bug.cgi?id=198795
2205
2206         Reviewed by Chris Dumez.
2207
2208         This test appears to no longer be flaky.
2209         
2210         Let's re-enable it.
2211         
2212         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2213         (TestWebKitAPI::TEST):
2214
2215 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2216
2217         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2218         https://bugs.webkit.org/show_bug.cgi?id=208550
2219
2220         Reviewed by Tim Hatcher.
2221
2222         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2223         (TEST):
2224         * TestWebKitAPI/cocoa/HTTPServer.mm:
2225         (TestWebKitAPI::HTTPServer::respondToRequests):
2226         HTTPServer now looks for Content-Length in its request.
2227         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2228
2229 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2230
2231         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2232         https://bugs.webkit.org/show_bug.cgi?id=208522
2233
2234         Reviewed by Brian Weinstein.
2235
2236         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2237         (TEST):
2238
2239 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2240
2241         commit-queue should update working directory and reapply patch just before commiting
2242         https://bugs.webkit.org/show_bug.cgi?id=208521
2243
2244         Reviewed by Jonathan Bedard.
2245
2246         * BuildSlaveSupport/ews-build/factories.py:
2247
2248 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2249
2250         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2251         https://bugs.webkit.org/show_bug.cgi?id=208485
2252
2253         Reviewed by Jonathan Bedard.
2254
2255         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2256         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2257         that we don't have to recreate the variables that are already created.
2258         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2259         from each module, rather than making extra imports that we don't need.
2260         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2261         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2262         and not part of the host.
2263         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2264         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2265         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2266         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2267         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2268         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2269         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2270         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2271         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2272         if we were geting any value at all
2273         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2274         sure we aren't gabking the wrong key:value pair
2275         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2276         come with the MockHosts and MockHost inherits from MockSystemHost.
2277         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2278         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2279         to the various upload steps.
2280
2281 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2282
2283         [ews] Add build step to find list of modified changelogs
2284         https://bugs.webkit.org/show_bug.cgi?id=208514
2285
2286         Reviewed by Jonathan Bedard.
2287
2288         * BuildSlaveSupport/ews-build/factories.py:
2289         * BuildSlaveSupport/ews-build/steps.py:
2290         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2291         (FindModifiedChangeLogs.start): Initialize log observer.
2292         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2293         (FindModifiedChangeLogs.evaluateCommand):
2294         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2295         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2296         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2297         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2298
2299 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2300
2301         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2302         https://bugs.webkit.org/show_bug.cgi?id=208451
2303
2304         Unreviewed test gardening.
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2307
2308 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2309
2310         Adopt HTTP Alternative Services Storage
2311         https://bugs.webkit.org/show_bug.cgi?id=208387
2312
2313         Reviewed by Alex Christensen.
2314
2315         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2316         (checkUntilEntryFound):
2317         (TEST):
2318
2319 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2320
2321         Check for navigation to app-bound domain during script evaluation
2322         https://bugs.webkit.org/show_bug.cgi?id=208319
2323         <rdar://problem/57569321>
2324
2325         Reviewed by Brent Fulgham.
2326
2327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2328         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2329         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2330         (TEST):
2331         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2332         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2333
2334 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2335
2336         Unreviewed, rolling out r257754.
2337         https://bugs.webkit.org/show_bug.cgi?id=208513
2338
2339         Introduced API test failure (Requested by perarne on #webkit).
2340
2341         Reverted changeset:
2342
2343         "[Cocoa] Mapping from MIME type to UTI type should be done in
2344         the UI process"
2345         https://bugs.webkit.org/show_bug.cgi?id=208415
2346         https://trac.webkit.org/changeset/257754
2347
2348 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2349
2350         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2351         https://bugs.webkit.org/show_bug.cgi?id=208506
2352
2353         Reviewed by Carlos Garcia Campos.
2354
2355         * WebKitTestRunner/TestController.cpp:
2356         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2357
2358 2020-03-02  Ben Nham  <nham@apple.com>
2359
2360         Add performance probes for HTML parsing
2361         https://bugs.webkit.org/show_bug.cgi?id=208271
2362
2363         Reviewed by Daniel Bates.
2364
2365         This adds probes that show which lines of HTML are have been parsed.
2366
2367         * Tracing/SystemTracePoints.plist:
2368
2369 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2370
2371         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2372         https://bugs.webkit.org/show_bug.cgi?id=208415
2373
2374         Reviewed by Brent Fulgham.
2375
2376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2377         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2378         (TEST):
2379
2380 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2381
2382         Unreviewed, rolling out r257725.
2383
2384         This commit caused 10 API tests to fail
2385
2386         Reverted changeset:
2387
2388         "[Cocoa] Mapping from MIME type to UTI type should be done in
2389         the UI process"
2390         https://bugs.webkit.org/show_bug.cgi?id=208415
2391         https://trac.webkit.org/changeset/257725
2392
2393 2020-03-02  Saam Barati  <sbarati@apple.com>
2394
2395         Don't skip tests unnecessarily on arm64
2396         https://bugs.webkit.org/show_bug.cgi?id=208470
2397         <rdar://problem/59968869>
2398
2399         Reviewed by Tadeu Zagallo.
2400
2401         * Scripts/run-jsc-stress-tests:
2402
2403 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2404
2405         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2406         https://bugs.webkit.org/show_bug.cgi?id=208434
2407
2408         Reviewed by Chris Fleizach.
2409
2410         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2411         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2412         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2413         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2414         (WTR::AccessibilityController::accessibleElementById): Same as above.
2415
2416 2020-03-02  John Wilander  <wilander@apple.com>
2417
2418         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2419         https://bugs.webkit.org/show_bug.cgi?id=208399
2420         <rdar://problem/24731650>
2421
2422         Reviewed by Brent Fulgham.
2423
2424         The majority of the changes in WTR::TestController is (partially) fixing a bug
2425         where the TestRunner would statically use the default website datastore instead
2426         of the website data store configure for the page. This worked for persistent
2427         storage testing but not for ephemeral sessions which is what this patch is all
2428         about. The previous TestController::websiteDataStore() is now called
2429         TestController::defaultWebsiteDataStore() and the new
2430         TestController::websiteDataStore() returns the configured website data store.
2431         Most of the use of the default website data store should probably change but
2432         that's not really for this patch to deal with. I did however move all of
2433         resource load statistics' use to the new TestController::websiteDataStore().
2434
2435         A new TestRunner function was added: isStatisticsEphemeral()
2436         It allows test cases to query the ephemeral status of resource load statistics.
2437
2438         One problem that is mitigated in this patch but not fully fixed is that for
2439         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
2440         TestController::generatePageConfiguration() via C API 
2441         WKPageConfigurationSetWebsiteDataStore(), and then again in 
2442         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
2443         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
2444         I tried removing the latter since one session for all platforms should be
2445         Enough but got broken behavior as a result. So now both are still there
2446         and both enable resource load statistics.
2447
2448         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2449         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2450         (WTR::TestRunner::isStatisticsEphemeral):
2451         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2452         * WebKitTestRunner/TestController.cpp:
2453         (WTR::TestController::defaultWebsiteDataStore):
2454         (WTR::TestController::websiteDataStore):
2455         (WTR::TestController::generatePageConfiguration):
2456         (WTR::TestController::resetPreferencesToConsistentValues):
2457         (WTR::TestController::resetStateToConsistentValues):
2458         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2459         (WTR::TestController::decidePolicyForNavigationAction):
2460         (WTR::TestController::platformAdjustContext):
2461         (WTR::TestController::clearServiceWorkerRegistrations):
2462         (WTR::TestController::clearDOMCache):
2463         (WTR::TestController::clearDOMCaches):
2464         (WTR::TestController::clearIndexedDatabases):
2465         (WTR::TestController::clearLocalStorage):
2466         (WTR::TestController::hasDOMCache):
2467         (WTR::TestController::domCacheSize):
2468         (WTR::TestController::setStatisticsEnabled):
2469         (WTR::TestController::isStatisticsEphemeral):
2470         (WTR::TestController::setStatisticsDebugMode):
2471         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2472         (WTR::TestController::setStatisticsLastSeen):
2473         (WTR::TestController::setStatisticsMergeStatistic):
2474         (WTR::TestController::setStatisticsPrevalentResource):
2475         (WTR::TestController::setStatisticsVeryPrevalentResource):
2476         (WTR::TestController::dumpResourceLoadStatistics):
2477         (WTR::TestController::isStatisticsPrevalentResource):
2478         (WTR::TestController::isStatisticsVeryPrevalentResource):
2479         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2480         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2481         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2482         (WTR::TestController::setStatisticsHasHadUserInteraction):
2483         (WTR::TestController::isStatisticsHasHadUserInteraction):
2484         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
2485         (WTR::TestController::setStatisticsGrandfathered):
2486         (WTR::TestController::isStatisticsGrandfathered):
2487         (WTR::TestController::setUseITPDatabase):
2488         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2489         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2490         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2491         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2492         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2493         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2494         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2495         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2496         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2497         (WTR::TestController::statisticsUpdateCookieBlocking):
2498         (WTR::TestController::statisticsSubmitTelemetry):
2499         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2500         (WTR::TestController::setStatisticsIsRunningTest):
2501         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2502         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2503         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2504         (WTR::TestController::setStatisticsGrandfatheringTime):
2505         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2506         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2507         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2508         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2509         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2510         (WTR::TestController::statisticsDeleteCookiesForHost):
2511         (WTR::TestController::isStatisticsHasLocalStorage):
2512         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2513         (WTR::TestController::hasStatisticsIsolatedSession):
2514         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
2515         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
2516         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
2517         (WTR::TestController::statisticsResetToConsistentState):
2518         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2519         * WebKitTestRunner/TestController.h:
2520         * WebKitTestRunner/TestInvocation.cpp:
2521         (WTR::TestInvocation::invoke):
2522         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2523         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2524         (WTR::initializeWebViewConfiguration):
2525         (WTR::TestController::platformCreateWebView):
2526
2527 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2528
2529         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2530         https://bugs.webkit.org/show_bug.cgi?id=208415
2531
2532         Reviewed by Brent Fulgham.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2536         (TEST):
2537
2538 2020-03-02  Daniel Bates  <dabates@apple.com>
2539
2540         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
2541         https://bugs.webkit.org/show_bug.cgi?id=208352
2542         <rdar://problem/59867815>
2543
2544         Reviewed by Wenson Hsieh.
2545
2546         Update test results to reflect the new behavior. To do this I also need to fix up the test code
2547         to actually scroll the web content. This also means we now execute the same code on both Mac and
2548         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
2549         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
2550         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
2551
2552         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2553         (TEST):
2554
2555 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2556
2557         Unreviewed, rolling out r257687.
2558
2559         This commit caused debug tests to crash for macOS & iOS
2560
2561         Reverted changeset:
2562
2563         "[Cocoa] Mapping from MIME type to UTI type should be done in
2564         the UI process"
2565         https://bugs.webkit.org/show_bug.cgi?id=208415
2566         https://trac.webkit.org/changeset/257687
2567
2568 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2569
2570         Unreviewed, rolling out r257618.
2571
2572         This allegedly causes Safari to crash when closing a window
2573         (see rdar://problem/59922725).
2574
2575         Reverted changeset:
2576
2577         "UIProcess crash after using _prepareForMoveToWindow, then
2578         deallocating the WKWebView before moving to the window"
2579         https://bugs.webkit.org/show_bug.cgi?id=208365
2580         https://trac.webkit.org/changeset/257618
2581
2582 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
2583
2584         Remove std::lock_guard
2585         https://bugs.webkit.org/show_bug.cgi?id=206451
2586
2587         Reviewed by Anders Carlsson.
2588
2589         Add std::lock_guard lint rule to prevent from using it.
2590
2591         * Scripts/webkitpy/style/checkers/cpp.py:
2592         (check_lock_guard):
2593         (check_style):
2594         (CppChecker):
2595         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2596         (WebKitStyleTest.test_lock_guard):
2597         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2598         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2599         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2600         (assertHasObjects):
2601         (assertHasOnlyObjects):
2602         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2603         (WTR::AXThread::dispatch):
2604         (WTR::AXThread::dispatchFunctionsFromAXThread):
2605         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2606         (WTR::AXThread::initializeRunLoop):
2607
2608 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
2609
2610         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2611         https://bugs.webkit.org/show_bug.cgi?id=208415
2612
2613         Reviewed by Brent Fulgham.
2614
2615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2616         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2617         (TEST):
2618
2619 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2620
2621         Unreviewed, rolling out r257565.
2622
2623         It broke WinCairo MiniBrowser
2624
2625         Reverted changeset:
2626
2627         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
2628         https://bugs.webkit.org/show_bug.cgi?id=206894
2629         https://trac.webkit.org/changeset/257565
2630
2631 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2632
2633         EWS fails to retry build in case of kill-old-processes exception
2634         https://bugs.webkit.org/show_bug.cgi?id=208003
2635
2636         Reviewed by Jonathan Bedard.
2637
2638         * BuildSlaveSupport/ews-build/steps.py:
2639         (KillOldProcesses.evaluateCommand):
2640         (KillOldProcesses.getResultSummary):
2641
2642 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2643
2644         [ews] commit-queue should update the ChangeLog with Reviewer name
2645         https://bugs.webkit.org/show_bug.cgi?id=206535
2646
2647         Reviewed by Jonathan Bedard.
2648
2649         * BuildSlaveSupport/ews-build/steps.py:
2650         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
2651
2652 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
2653
2654         run-javascriptcore-tests: Make upload format valid
2655         https://bugs.webkit.org/show_bug.cgi?id=208341
2656
2657         Rubber-stamped by Aakash Jain.
2658
2659         * Scripts/run-javascriptcore-tests:
2660         (uploadResults): Remove. FIXME.
2661         * Scripts/webkitdirs.pm:
2662         (splitVersionString): Handle case where the subminor version number has a - in it.
2663         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
2664
2665 2020-02-28  youenn fablet  <youenn@apple.com>
2666
2667         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
2668         https://bugs.webkit.org/show_bug.cgi?id=208130
2669
2670         Reviewed by Eric Carlson.
2671
2672         * WebKitTestRunner/TestOptions.h:
2673         Use GPU process to capture by default.
2674         We will remove this option once done verifying that every test works smoothly.
2675
2676 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2677
2678         [ews] commit queue should skip building and testing for rollout patches
2679         https://bugs.webkit.org/show_bug.cgi?id=208329
2680
2681         Reviewed by Jonathan Bedard.
2682
2683         * BuildSlaveSupport/ews-build/steps.py:
2684         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
2685         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
2686         (RunWebKit1Tests.doStepIf): Ditto.
2687         * BuildSlaveSupport/ews-build/steps_unittest.py:
2688         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
2689         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
2690
2691 2020-02-28  Daniel Bates  <dabates@apple.com>
2692
2693         Update my watch list preferences and contributor's entry.
2694
2695         * Scripts/webkitpy/common/config/contributors.json:
2696         * Scripts/webkitpy/common/config/watchlist:
2697
2698 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2699
2700         Fix WebCore export macros for declspec
2701         https://bugs.webkit.org/show_bug.cgi?id=208363
2702
2703         Reviewed by Konstantin Tokarev.
2704
2705         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
2706         files. Removed precompiled headers that were empty.
2707
2708         * DumpRenderTree/DumpRenderTreePrefix.h:
2709         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
2710         * MiniBrowser/win/stdafx.h:
2711         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
2712         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
2713         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
2714         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
2715         * WebKitTestRunner/PlatformFTW.cmake:
2716         * WebKitTestRunner/PlatformWin.cmake:
2717         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2718
2719 2020-02-27  Tim Horton  <timothy_horton@apple.com>
2720
2721         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2722         https://bugs.webkit.org/show_bug.cgi?id=208365
2723
2724         Reviewed by Alex Christensen.
2725
2726         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2727         (TEST):
2728         Add a test! It was a 100% repro crash before this change.
2729
2730 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
2731
2732         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2733         https://bugs.webkit.org/show_bug.cgi?id=208260
2734         <rdar://problem/59820107>
2735
2736         Reviewed by Tim Horton.
2737
2738         Followed instructions for adding an Info.plist for Single-File Tools
2739         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2740
2741         The default WebsiteDataStore file path will change with this test to
2742         reflect the new bundleID so we must change expectations for any api
2743         tests which rely on knowing the path.
2744
2745         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2747         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2748         (TEST):
2749         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2750         (TEST):
2751         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
2752         (TEST):
2753         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2754         (TEST):
2755         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2756         (TEST):
2757         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2758         (TEST):
2759         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2760         (TEST):
2761         (defaultWebsiteCacheDirectory):
2762         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
2763         (TEST):
2764         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2765         (TEST):
2766         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2767         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2768         (TEST):
2769         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2770         (TEST):
2771         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2772         (runWebsiteDataStoreCustomPaths):
2773         (TEST):
2774         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2775         (TestWebKitAPI::resetTestState):
2776         Now that we set a bundleID, we have to reset the cache model between
2777         tests, otherwise it gets stored between tests.
2778
2779         (TestWebKitAPI::TEST):
2780         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2781         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2782
2783 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2784
2785         TextManipulationController should not generate a new item for content in manipulated paragraphs
2786         https://bugs.webkit.org/show_bug.cgi?id=208286
2787
2788         Reviewed by Wenson Hsieh.
2789
2790         Added a regression test.
2791
2792         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2793         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2794
2795 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2796
2797         run-javascriptcore-tests: Make upload format valid
2798         https://bugs.webkit.org/show_bug.cgi?id=208341
2799
2800         Reviewed by Aakash Jain.
2801
2802         * Scripts/run-javascriptcore-tests:
2803         (uploadResults): Print json blob for upload after failure for debugging.
2804
2805 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2806
2807         [CMake] Add WebKit::PAL target
2808         https://bugs.webkit.org/show_bug.cgi?id=198493
2809
2810         Reviewed by Michael Catanzaro.
2811
2812         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2813
2814         * DumpRenderTree/PlatformWin.cmake:
2815
2816 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2817
2818         Add SPI to query WKFrameInfos in a WKWebView
2819         https://bugs.webkit.org/show_bug.cgi?id=208212
2820
2821         Reviewed by Brady Eidson.
2822
2823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2824         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2825         * WebKitTestRunner/TestController.cpp:
2826         (WTR::TestController::saltForOrigin):
2827
2828 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2829
2830         Unreviewed, rolling out r257530.
2831
2832         This commit seems to have broke the build internally for
2833         watchOS
2834
2835         Reverted changeset:
2836
2837         "Add SPI to query WKFrameInfos in a WKWebView"
2838         https://bugs.webkit.org/show_bug.cgi?id=208212
2839         https://trac.webkit.org/changeset/257530
2840
2841 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2842
2843         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2844         https://bugs.webkit.org/show_bug.cgi?id=206894
2845
2846         Reviewed by Adrian Perez de Castro.
2847
2848         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2849         MiniBrowsers.
2850
2851         * MiniBrowser/gtk/CMakeLists.txt:
2852         * MiniBrowser/win/CMakeLists.txt:
2853         * MiniBrowser/wpe/CMakeLists.txt:
2854
2855 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2856
2857         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2858         https://bugs.webkit.org/show_bug.cgi?id=206456
2859
2860         Reviewed by Brady Eidson.
2861
2862         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2863         (TEST):
2864
2865 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2866
2867         _WKUserContentWorld should be a wrapper around WKContentWorld
2868         https://bugs.webkit.org/show_bug.cgi?id=208274
2869
2870         Reviewed by Brady Eidson.
2871
2872         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2873         (TEST):
2874         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2875         (TEST):
2876
2877 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2878
2879         Unreviewed, rolling out r257522.
2880
2881         Caused 16 API test failures on the bots
2882
2883         Reverted changeset:
2884
2885         "TestWebKitAPI and WebKitTestRunner should have bundle
2886         identifiers"
2887         https://bugs.webkit.org/show_bug.cgi?id=208260
2888         https://trac.webkit.org/changeset/257522
2889
2890 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2891
2892         Add SPI to query WKFrameInfos in a WKWebView
2893         https://bugs.webkit.org/show_bug.cgi?id=208212
2894
2895         Reviewed by Brady Eidson.
2896
2897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2898         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2899         * WebKitTestRunner/TestController.cpp:
2900         (WTR::TestController::saltForOrigin):
2901
2902 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2903
2904         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2905         https://bugs.webkit.org/show_bug.cgi?id=208260
2906         <rdar://problem/59820107>
2907
2908         Reviewed by Tim Horton.
2909
2910         Followed instructions for adding an Info.plist for Single-File Tools
2911         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2912
2913         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2914         * TestWebKitAPI/Info.plist: Added.
2915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2916         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2917         * WebKitTestRunner/Info.plist: Added.
2918         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2919
2920 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2921
2922         Tests should each use a unique ResourceLoadStatistics file path for its database store
2923         https://bugs.webkit.org/show_bug.cgi?id=208206
2924         <rdar://problem/59690272>
2925
2926         Reviewed by Brady Eidson.
2927
2928         Initialize a default website data store before checking for the ITP
2929         store to ensure the directory exists after the file has been deleted.
2930
2931         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2932         (TEST):
2933
2934 2020-02-26  Christopher Reid  <chris.reid@sony.com>
2935
2936         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
2937         https://bugs.webkit.org/show_bug.cgi?id=197684
2938         <rdar://problem/59467397>
2939
2940         Reviewed by Yusuke Suzuki.
2941
2942         Add test for FileSystem::createFile
2943
2944         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2945
2946 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
2947
2948         [ews] commit-queue should verify patch committer and reviewer
2949         https://bugs.webkit.org/show_bug.cgi?id=206532
2950
2951         Reviewed by Jonathan Bedard.
2952
2953         * BuildSlaveSupport/ews-build/steps.py:
2954         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
2955         (ValidateCommiterAndReviewer._addToLog):
2956         (ValidateCommiterAndReviewer.getResultSummary):
2957         (ValidateCommiterAndReviewer.fail_build):
2958         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
2959         (ValidateCommiterAndReviewer.is_reviewer):
2960         (ValidateCommiterAndReviewer.is_committer):
2961         (ValidateCommiterAndReviewer.full_name_from_email):
2962         (ValidateCommiterAndReviewer.start):
2963
2964 2020-02-26  Daniel Bates  <dabates@apple.com>
2965
2966         [iOS] Send focus update immediately on becoming or resigning first responder
2967         https://bugs.webkit.org/show_bug.cgi?id=208082
2968         <rdar://problem/59688413>
2969
2970         Rubber-stamped by Jer Noble.
2971
2972         Add a test to ensure that selecting a position at a point after the web view
2973         becomes first responder is allowed. Such an operation is only allowed if the
2974         web view is focused.
2975
2976         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2977         (-[TestWKWebView selectPositionAtPoint:]):
2978         (TEST):
2979         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
2980
2981 2020-02-26  Chris Dumez  <cdumez@apple.com>
2982
2983         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
2984
2985         The test was added for macOS and times out on iOS.
2986
2987         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2988         (TEST):
2989
2990 2020-02-26  Youenn Fablet  <youenn@apple.com>
2991
2992         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
2993         https://bugs.webkit.org/show_bug.cgi?id=208238
2994
2995         Reviewed by Eric Carlson.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2998         (TEST):
2999         Remove use of deleted parameter.
3000
3001 2020-02-25  Devin Rousso  <drousso@apple.com>
3002
3003         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
3004         https://bugs.webkit.org/show_bug.cgi?id=206911
3005         <rdar://problem/58026635>
3006
3007         Reviewed by Brian Burg.
3008
3009         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3010         (TestWebKitAPI::TEST):
3011         Add test for `WTF::HashSet::reserveInitialCapacity`.
3012
3013         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3014         (TestWebKitAPI::TEST):
3015         Actually check the value of `WTF::HashMap::capacity`.
3016
3017         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
3018         (-[InspectorDelegate _webView:didAttachInspector:])
3019         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
3020         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
3021         (TestWebKitAPI::TEST):
3022         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3023         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3024         (TestWebKitAPI::TEST): Deleted.
3025
3026 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3027
3028         Add checkout_root to stubrepository.py
3029         https://bugs.webkit.org/show_bug.cgi?id=208213
3030
3031         Reviewed by Jonathan Bedard.
3032
3033         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3034         (StubRepository.__init__):
3035
3036         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3037         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3038
3039 2020-02-25  Daniel Bates  <dabates@apple.com>
3040
3041         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3042         https://bugs.webkit.org/show_bug.cgi?id=208214
3043
3044         Reviewed by Wenson Hsieh.
3045
3046         Wait until the copy operation completes before loading the second web view and testing paste
3047         to ensure that something was actually copied to the clipboard.
3048
3049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3050         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3051         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3052         so that we wait until the command completes.
3053
3054 2020-02-25  Chris Dumez  <cdumez@apple.com>
3055
3056         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3057         https://bugs.webkit.org/show_bug.cgi?id=208199
3058         <rdar://problem/59746887>
3059
3060         Reviewed by Alex Christensen.
3061
3062         Add API test coverage.
3063
3064         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3065         (TEST):
3066
3067 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3068
3069         spinRunLoop should take a non-zero integer as parameter
3070         https://bugs.webkit.org/show_bug.cgi?id=208148
3071         <rdar://problem/59766682>
3072
3073         Unreviewed iOS build fix.
3074
3075         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3076         (TestWebKitAPI::Util::spinRunLoop):
3077
3078 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3079
3080         spinRunLoop should take a non-zero integer as parameter
3081         https://bugs.webkit.org/show_bug.cgi?id=208148
3082
3083         Reviewed by Darin Adler.
3084
3085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3086         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3087         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3088         (TestWebKitAPI::Util::spinRunLoop):
3089
3090 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3091
3092         [WTF] Add tests for CompactRefPtrTuple
3093         https://bugs.webkit.org/show_bug.cgi?id=208172
3094
3095         Reviewed by Darin Adler.
3096
3097         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3098         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3099
3100         * TestWebKitAPI/CMakeLists.txt:
3101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3102         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3103         (TestWebKitAPI::TEST):
3104
3105 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3106
3107         [ews] commit-queue should check that patch have appropriate review flag
3108         https://bugs.webkit.org/show_bug.cgi?id=208138
3109
3110         Reviewed by Jonathan Bedard.
3111
3112         * BuildSlaveSupport/ews-build/steps.py:
3113         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
3114         (BugzillaMixin._is_patch_cq_plus):
3115         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
3116         (ValidatePatch.start):
3117
3118 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
3119
3120         [WebAuthn] Implement SPI for the platform authenticator
3121         https://bugs.webkit.org/show_bug.cgi?id=208087
3122         <rdar://problem/59369305>
3123
3124         Reviewed by Brent Fulgham.
3125
3126         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
3127
3128         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
3129         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3131         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3132         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3133         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
3134         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
3135         (TestWebKitAPI::TEST):
3136         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
3137         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
3138         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
3139         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
3140
3141 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3142
3143         Unreviewed, updating LLDB test for CompactPointerTuple.
3144         https://bugs.webkit.org/show_bug.cgi?id=207827
3145
3146         * lldb/lldb_webkit.py:
3147         (WTFCompactPointerTupleProvider):
3148         (WTFCompactPointerTupleProvider.update):
3149
3150 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
3151
3152         Provide alternate way to name Web Content process
3153         https://bugs.webkit.org/show_bug.cgi?id=205224
3154         rdar://57038084
3155
3156         Reviewed by Alex Christensen.
3157
3158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3159         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
3160         (TestWebKitAPI::TEST):
3161
3162 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
3163
3164         results.webkit.org: Link to result archives
3165         https://bugs.webkit.org/show_bug.cgi?id=207646
3166         <rdar://problem/59395807>
3167
3168         Rubber-stamped by Aakash Jain.
3169
3170         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
3171         (_ArchiveRouter): Retrieve json from archive-router endpoint.
3172         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
3173         return the most specific value.
3174         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
3175         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
3176         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
3177         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3178         (parametersForInstance): Extract from lambda function.
3179         (testRunLink): Use parametersForInstance instead of a lambda function.
3180         (archiveLink): Return an archive link for data. 
3181         (contentForData): Add archive link to view.
3182         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3183         (TimelineFromEndpoint): Accept both suite and test.
3184         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
3185         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
3186         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
3187         * resultsdbpy/resultsdbpy/view/view_routes.py:
3188         (ViewRoutes.__init__): Add archive_route dictionary.
3189
3190 2020-02-24  Alex Christensen  <achristensen@webkit.org>
3191
3192         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
3193         https://bugs.webkit.org/show_bug.cgi?id=208035
3194         <rdar://problem/58011337>
3195
3196         Reviewed by Tim Hatcher.
3197
3198         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3199
3200 2020-02-22  Darin Adler  <darin@apple.com>
3201
3202         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
3203         https://bugs.webkit.org/show_bug.cgi?id=208099
3204
3205         Reviewed by Antti Koivisto.
3206
3207         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3208         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
3209         so we can use the -[NSString createJSStringRef] method.
3210         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
3211         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
3212
3213 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3214
3215         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
3216         https://bugs.webkit.org/show_bug.cgi?id=208096
3217         <rdar://problem/59632008>
3218
3219         Reviewed by Alexey Proskuryakov.
3220
3221         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
3222         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
3223         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
3224
3225         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
3226         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
3227         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
3228         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
3229         in the credit card expiry field.
3230
3231         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
3232
3233         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3234         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3235         (WTR::UIScriptController::setDefaultCalendarType):
3236         * WebKitTestRunner/TestController.h:
3237
3238         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
3239         identifier and calendar locale identifier.
3240
3241         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3242         (WTR::swizzledCalendar):
3243         (WTR::TestController::overriddenCalendarIdentifier const):
3244         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
3245
3246         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
3247
3248         (WTR::TestController::setDefaultCalendarType):
3249
3250         Plumb the new calendar's locale identifier through this method.
3251
3252         (WTR::TestController::cocoaResetStateToConsistentValues):
3253         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
3254         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3255         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3256         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
3257
3258 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
3259
3260         App-bound domains should have separate Network Sessions
3261         https://bugs.webkit.org/show_bug.cgi?id=208026
3262         <rdar://problem/59434006>
3263
3264         Reviewed by Brent Fulgham.
3265
3266         This patch is mostly test infrastructure involving 3 functions.
3267         One sets in-app browser privacy as enabled in the network process
3268         manually for the test. One ensures that setting the WebView category
3269         works properly, and the last one checks for an app-bound session for
3270         an app-bound navigation.
3271
3272         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3273         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3274         (WTR::InjectedBundle::didReceiveMessageToPage):
3275         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3276         (WTR::TestRunner::getWebViewCategory):
3277         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
3278         (WTR::TestRunner::hasAppBoundSession):
3279         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
3280         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
3281         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3282         * WebKitTestRunner/TestController.cpp:
3283         (WTR::TestController::ensureViewSupportsOptionsForTest):
3284         Clearing the bundleID should happen right before setting a new one, 
3285         otherwise it clears the ID after it is set and returns a null ID.
3286
3287         (WTR::TestController::resetStateToConsistentValues):
3288         (WTR::TestController::getWebViewCategory):
3289         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
3290         (WTR::inAppBrowserPrivacyBooleanResultCallback):
3291         (WTR::inAppBrowserPrivacyVoidResultCallback):
3292         (WTR::TestController::hasAppBoundSession):
3293         (WTR::TestController::setInAppBrowserPrivacyEnabled):
3294         * WebKitTestRunner/TestController.h:
3295         * WebKitTestRunner/TestInvocation.cpp:
3296         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3297         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3298         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
3299         (WTR::TestInvocation::didReceivePrevalentDomains):
3300         (WTR::TestInvocation::didReceiveWebViewCategory):
3301         * WebKitTestRunner/TestInvocation.h:
3302         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3303         (WTR::TestController::getWebViewCategory):
3304
3305 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
3306
3307         Build DumpRenderTree and WebKitTestRunner for macCatalyst
3308         https://bugs.webkit.org/show_bug.cgi?id=208068
3309         <rdar://problem/59676596>
3310
3311         Reviewed by Tim Horton.
3312
3313         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
3314         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3315         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
3316         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
3317         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
3318         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
3319         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
3320         * DumpRenderTree/mac/EventSendingController.h: Ditto.
3321         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
3322         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
3323         * Makefile: Add DumpRenderTree and WebKitTestRunner.
3324         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3325         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
3326         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
3327
3328 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3329
3330         [ews] Add build step to Validate ChangeLog for commit-queue
3331         https://bugs.webkit.org/show_bug.cgi?id=208064
3332
3333         Reviewed by Jonathan Bedard.
3334
3335         * BuildSlaveSupport/ews-build/steps.py:
3336         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
3337         (ValidateChangeLogAndReviewer.start):
3338         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
3339         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
3340
3341 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3342
3343         [ews] Add build step to set cq- flag on bugzilla patch
3344         https://bugs.webkit.org/show_bug.cgi?id=208021
3345
3346         Reviewed by Jonathan Bedard.
3347
3348         * BuildSlaveSupport/ews-build/steps.py:
3349         (BugzillaMixin.set_cq_minus_flag_on_patch):
3350         (SetCommitQueueMinusFlagOnPatch):
3351         (SetCommitQueueMinusFlagOnPatch.start):
3352         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
3353
3354 2020-02-20  Matt Lewis  <jlewis3@apple.com>
3355
3356         Stub repositories fail to upload some results due to missing head svn revision
3357         https://bugs.webkit.org/show_bug.cgi?id=207684
3358
3359         Reviewed by Jonathan Bedard.
3360
3361         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
3362         (MockHost.__init__):
3363         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3364         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3365         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3366         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
3367         * Scripts/webkitpy/port/base.py:
3368         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
3369         from using mock SCMs and more
3370         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
3371
3372 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
3373
3374         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
3375         https://bugs.webkit.org/show_bug.cgi?id=208051
3376
3377         Reviewed by Carlos Alberto Lopez Perez.
3378
3379         Verbose flag prints out each test name executed. Without this flag
3380         stdout prints out one or two periods.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3383         (RunJavaScriptCoreTests.start):
3384
3385 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
3386
3387         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
3388         https://bugs.webkit.org/show_bug.cgi?id=207984
3389
3390         Reviewed by Daniel Bates.
3391
3392         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3393         (TestWebKitAPI::TEST):
3394
3395 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
3396
3397         [GTK] Improve user agent quirk for Google Docs and Google Drive
3398         https://bugs.webkit.org/show_bug.cgi?id=206506
3399
3400         Reviewed by Carlos Garcia Campos.
3401
3402         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3403         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3404         (TestWebKitAPI::TEST):
3405
3406 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3407
3408         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
3409         https://bugs.webkit.org/show_bug.cgi?id=207380
3410
3411         Reviewed by Jonathan Bedard.
3412
3413         Added a new rule 'build/export_macro'.
3414
3415         Removed a obsolete rule 'readability/webkit_export' which was used
3416         only by Chromium port (r148185).
3417
3418         * Scripts/webkitpy/style/checkers/cpp.py:
3419         (_FunctionState.export_macro):
3420         (check_function_definition):
3421         (_unix_path): Added.
3422         (is_generated_file): Use _unix_path.
3423         (check_has_config_header): Ditto.
3424         (CppChecker):
3425         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3426         (WebKitStyleTest.test_export_macro_check):
3427         (WebKitStyleTest.test_webkit_export_check): Deleted.
3428
3429 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3430
3431         [Win][MiniBrowser] Add prettier toolbar button icons
3432         https://bugs.webkit.org/show_bug.cgi?id=207999
3433
3434         Reviewed by Ross Kirsling.
3435
3436         Use a custom toolbar button icons instead of system stock icons.
3437
3438         Fixed a bug toolbar button dropdown arrows always looked being
3439         hovered. TBSTYLE_FLAT should be given.
3440
3441         Removed the window border line of Progress Indicator.
3442
3443         * MiniBrowser/win/MainWindow.cpp:
3444         (MainWindow::createToolbar):
3445         * MiniBrowser/win/MiniBrowserLib.rc:
3446         * MiniBrowser/win/MiniBrowserLibResource.h:
3447         * MiniBrowser/win/toolbar.bmp: Added.
3448
3449 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
3450
3451         Update run-webkit-tests help description for skip-failing-tests
3452         https://bugs.webkit.org/show_bug.cgi?id=208031
3453
3454         Reviewed by Alexey Proskuryakov.
3455
3456         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3457
3458 2020-02-20  Chris Dumez  <cdumez@apple.com>
3459
3460         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
3461         https://bugs.webkit.org/show_bug.cgi?id=208015
3462         <rdar://problem/59591630>
3463
3464         Reviewed by Geoffrey Garen.
3465
3466         Add API test coverage.
3467
3468         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3469         (TEST):
3470
3471 2020-02-20  Tim Horton  <timothy_horton@apple.com>
3472
3473         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
3474         https://bugs.webkit.org/show_bug.cgi?id=207998
3475         <rdar://problem/40942425>
3476
3477         Reviewed by Sam Weinig.
3478
3479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3480         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
3481         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3482         (TestWebKitAPI::TEST):
3483         Add some tests for top content insets.
3484
3485 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
3486
3487         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
3488         https://bugs.webkit.org/show_bug.cgi?id=207910
3489
3490         Unreviewed infrastructure fix.
3491
3492         * Scripts/run-javascriptcore-tests:
3493         (configurationForUpload): Use the major version instead of the sub-minor version
3494         for version name.
3495
3496 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
3497
3498         [CMake] Add WPE::libwpe target
3499         https://bugs.webkit.org/show_bug.cgi?id=207970
3500
3501         Reviewed by Adrian Perez de Castro.
3502
3503         Use the WPE::libwpe target.
3504
3505         * MiniBrowser/wpe/CMakeLists.txt:
3506         * TestWebKitAPI/PlatformWPE.cmake:
3507         * TestWebKitAPI/glib/PlatformWPE.cmake:
3508         * wpe/backends/CMakeLists.txt:
3509
3510 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3511
3512         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
3513         https://bugs.webkit.org/show_bug.cgi?id=207749
3514
3515         Reviewed by Ross Kirsling.
3516
3517         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
3518
3519         * MiniBrowser/win/MainWindow.cpp:
3520         (MainWindow::createToolbar):
3521         (MainWindow::WndProc):
3522         (MainWindow::setDefaultURLToCurrentURL):
3523         (MainWindow::goHome): Added.
3524         (MainWindow::onURLBarEnter):
3525         * MiniBrowser/win/MainWindow.h:
3526         * MiniBrowser/win/MiniBrowserLib.rc:
3527         * MiniBrowser/win/MiniBrowserLibResource.h:
3528         * MiniBrowser/win/MiniBrowserReplace.h:
3529         * MiniBrowser/win/WinMain.cpp:
3530         (wWinMain):
3531
3532 2020-02-19  Peng Liu  <peng.liu6@apple.com>
3533
3534         Fix check-webkit-style errors related to AVFoundationSPI.h
3535         https://bugs.webkit.org/show_bug.cgi?id=207834
3536
3537         Reviewed by Daniel Bates.
3538
3539         Revert the change in r256770 regarding the headers ordering.
3540         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
3541
3542         * Scripts/webkitpy/style/checkers/cpp.py:
3543         (check_include_line):
3544
3545 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
3546
3547         results.webkit.org: Correctly report JSC tests for windows
3548         https://bugs.webkit.org/show_bug.cgi?id=207910
3549
3550         Rubber-stamped by Aakash Jain.
3551
3552         * Scripts/run-javascriptcore-tests:
3553         (configurationForUpload): Give Windows a version name.
3554         * Scripts/webkitdirs.pm:
3555         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
3556         Version dictionary.
3557
3558 2020-02-19  Chris Dumez  <cdumez@apple.com>
3559
3560         Unreviewed, fix assertions in storage access API layout tests after r256882.
3561
3562         Drop dead testRunner code to toggle storage access API feature.
3563
3564         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3565         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3566         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
3567         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3568         * WebKitTestRunner/TestInvocation.cpp:
3569         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3570
3571 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
3572
3573         [WPE] Support 2D axis, smooth-motion events
3574         https://bugs.webkit.org/show_bug.cgi?id=207881
3575
3576         Reviewed by Carlos Garcia Campos.
3577
3578         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
3579
3580 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
3581
3582         Unreviewed, rolling out r256851.
3583
3584         Broke internal bots
3585
3586         Reverted changeset:
3587
3588         "Stub repositories fail to upload some results due to missing
3589         head svn revision"
3590         https://bugs.webkit.org/show_bug.cgi?id=207684
3591         https://trac.webkit.org/changeset/256851
3592
3593 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
3594
3595         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
3596         https://bugs.webkit.org/show_bug.cgi?id=207883
3597
3598         Reviewed by Ross Kirsling.
3599
3600         Unlike other mouse buttons, 4th and 5th mouse buttons are
3601         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
3602         WM_XBUTTONUP events to the window under the mouse cursor.
3603         Unhandled WM_XBUTTONUP events are automatically converted to
3604         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
3605         parent window.
3606         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
3607
3608         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
3609         handled.
3610
3611         * MiniBrowser/win/BrowserWindow.h:
3612         * MiniBrowser/win/MainWindow.cpp:
3613         (MainWindow::WndProc):
3614         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3615         (WebKitBrowserWindow::navigateForwardOrBackward):
3616         * MiniBrowser/win/WebKitBrowserWindow.h:
3617         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3618         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
3619         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3620
3621 2020-02-18  Alex Christensen  <achristensen@webkit.org>
3622
3623         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
3624         https://bugs.webkit.org/show_bug.cgi?id=207912
3625         <rdar://problem/59556922>
3626
3627         Reviewed by Brian Weinstein.
3628
3629         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3630         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3631         (TEST):
3632         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3633         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
3634
3635 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3636
3637         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
3638         https://bugs.webkit.org/show_bug.cgi?id=207899
3639         <rdar://problem/55658207>
3640
3641         Reviewed by Tim Horton and Simon Fraser.
3642
3643         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
3644
3645         * WebKitTestRunner/TestController.cpp:
3646         (WTR::updateTestOptionsFromTestHeader):
3647         * WebKitTestRunner/TestOptions.h:
3648         (WTR::TestOptions::hasSameInitializationOptions const):
3649         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3650         (WTR::TestController::platformCreateWebView):
3651
3652 2020-02-18  Matt Lewis  <jlewis3@apple.com>
3653
3654         Stub repositories fail to upload some results due to missing head svn revision
3655         https://bugs.webkit.org/show_bug.cgi?id=207684
3656
3657         Reviewed by Jonathan Bedard.
3658
3659         * Scripts/webkitpy/api_tests/run_api_tests.py:
3660         (main): Added initializing the scm to the host object.
3661         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3662         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3663         it in line with modern code.
3664         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3665         (main): Added inializing the scm to the host object.
3666         * Scripts/webkitpy/port/base.py:
3667         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
3668         from using mock SCMs and more
3669         * Scripts/webkitpy/test/main.py:
3670         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
3671         and converted the webkit_root variable to the SCM checkout root.
3672         (Tester._run_tests):
3673
3674 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
3675
3676         Move [UIDevice currentDevice] calls to UI process
3677         https://bugs.webkit.org/show_bug.cgi?id=204320
3678
3679         Reviewed by Darin Adler.
3680
3681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3682         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
3683         (TEST):
3684
3685 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
3686
3687         Move from "layer flush" terminology to "rendering update"
3688         https://bugs.webkit.org/show_bug.cgi?id=207870
3689
3690         Reviewed by Tim Horton.
3691
3692         Rename various functions and member variables to move away from the legacy "layer flush"
3693         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
3694         that we have layers is an implementation detail.
3695         
3696         Change LayerFlushThrottlingState to be an OptionSet<>.
3697
3698         * Tracing/SystemTracePoints.plist:
3699
3700 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
3701
3702         [Webkit.css] Adding popover style element
3703         This help to prevent us reinventing the wheel ever again
3704         https://bugs.webkit.org/show_bug.cgi?id=207787
3705
3706         Reviewed by Dean Jackson.
3707
3708         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
3709         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
3710         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3711         (.popover):
3712         (.popover>.content):
3713         (.popover.display):
3714         (.popover .arrow):
3715         (.popover .arrow.point-top):
3716         (.popover .arrow.point-bottom):
3717         (.popover .arrow.point-left):
3718         (.popover .arrow.point-right):
3719         (@media (prefers-color-scheme: dark) .popover>.content):
3720         (@media (prefers-color-scheme: dark) .popover.display):
3721         (@media (prefers-color-scheme: dark) .popover .arrow):
3722         (.popover>.content>.section): Deleted.