d06344984b6e5acdd785c1685b6be80705309386
[WebKit.git] / Tools / ChangeLog
1 2011-02-04  Tony Chang  <tony@chromium.org>
2
3         Reviewed by Eric Seidel.
4
5         get test-webkitpy running on win32 python
6         https://bugs.webkit.org/show_bug.cgi?id=53822
7
8         The test harness crashes with a WindowsError because it can't find
9         'svn' when using subprocess.Popen.  This gets us past the error
10         so we can see the failing tests on the Chromium Win Release Tests
11         bot.
12
13         * Scripts/webkitpy/common/system/executive.py:
14
15 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
16
17         Reviewed by Gustavo Noronha Silva.
18
19         [GTK] fast/events/pagehide-timeout.html fails
20         https://bugs.webkit.org/show_bug.cgi?id=53771
21
22         Add knowledge of the document browser cache model the DRT. When resetting
23         WebKit settings to consistent values between tests, default to the document
24         browser cache model.
25
26         * DumpRenderTree/gtk/DumpRenderTree.cpp:
27         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
28         cache model between tests.
29         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
30         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
31         document browser cache model.
32
33 2011-02-04  Adam Barth  <abarth@webkit.org>
34
35         Reviewed by Eric Seidel.
36
37         PluginDocuments don't create widgets for plugins on back/forward
38         https://bugs.webkit.org/show_bug.cgi?id=53474
39
40         Teach the test plugin how to call alert on load.
41
42         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
43         (NPP_New):
44
45 2011-02-04  Adam Roben  <aroben@apple.com>
46
47         Add a test case for encode/decode of FormData/FormDataElement
48
49         If the fix made in r77401 is broken, this new test will crash.
50
51         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
52
53         Reviewed by Sam Weinig.
54
55         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
56         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
57
58         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
59         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
60         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
61         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
62         form, an return the session state data.
63         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
64         and restore it into another WKPage.
65
66         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
67
68         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
70         * TestWebKitAPI/win/copy-resources.cmd:
71         Added new files.
72
73 2011-02-04  Adam Roben  <aroben@apple.com>
74
75         Move code to run JavaScript tests into its own files
76
77         This will allow other tests to use this mechanism.
78
79         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
80         world
81
82         Reviewed by Sam Weinig.
83
84         * TestWebKitAPI/JavaScriptTest.cpp: Added.
85         * TestWebKitAPI/JavaScriptTest.h: Added.
86         Moved code here...
87
88         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
89
90         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
91         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
92         Added the new files.
93
94 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
95
96         Reviewed by Mihai Parparita.
97
98         merge test expectations for chromium, chromium-gpu. The
99         chromium-gpu port will no longer maintain its own
100         test expectations file.
101
102         Also add in a graphics_type() call on the port object to
103         determine what graphics type to use in the test configuration,
104         and log the configuration as a config setting.
105
106         https://bugs.webkit.org/show_bug.cgi?id=53562
107
108         * Scripts/webkitpy/layout_tests/port/base.py:
109         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
110         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
111         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
112
113 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
114
115         Reviewed by Pavel Feldman.
116
117         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
118         https://bugs.webkit.org/show_bug.cgi?id=53781
119
120         * Scripts/check-inspector-strings:
121
122 2011-02-04  Adam Roben  <aroben@apple.com>
123
124         Include the crashing function in the link to a crash log on Mac
125
126         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
127         function that crashed on Mac
128
129         Reviewed by David Kilzer.
130
131         * Scripts/old-run-webkit-tests:
132         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
133         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
134         the crash log.
135
136 2011-02-04  Adam Roben  <aroben@apple.com>
137
138         Link to Mac crash logs from results.html
139
140         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
141         results.html
142
143         Reviewed by David Kilzer.
144
145         * Scripts/old-run-webkit-tests:
146         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
147         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
148
149 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
150
151         Reviewed by Dan Bernstein.
152
153         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
154         https://bugs.webkit.org/show_bug.cgi?id=52897
155         <rdar://problem/8898294>
156
157         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
158         (WTR::InjectedBundlePage::InjectedBundlePage):
159         (WTR::InjectedBundlePage::willSendRequestForFrame):
160         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
161
162 2011-02-03  Ivan Krstić  <ike@apple.com>
163
164         Unreviewed.
165
166         Adding myself to committers.py.
167
168         * Scripts/webkitpy/common/config/committers.py:
169
170 2011-02-03  James Kozianski  <koz@chromium.org>
171
172         Reviewed by Dimitri Glazkov.
173
174         Add navigator.registerProtocolHandler behind a flag.
175         https://bugs.webkit.org/show_bug.cgi?id=52609
176
177         * Scripts/build-webkit:
178
179 2011-02-03  Hayato Ito  <hayato@chromium.org>
180
181         Reviewed by Eric Seidel.
182
183         [NRWT] Remove TestArgs class, which is wrongly used.
184
185         https://bugs.webkit.org/show_bug.cgi?id=53063
186
187         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
188         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
189         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
190         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
191         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
192         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
193
194 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
195
196         Reviewed by Kenneth Russell.
197
198         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
199         https://bugs.webkit.org/show_bug.cgi?id=53714
200
201         * Scripts/build-webkit: change --3d-canvas build option
202           to set ENABLE_WEBGL
203
204 2011-02-03  Hayato Ito  <hayato@chromium.org>
205
206         Reviewed by Tony Chang.
207
208         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
209         move _run_single_test() and _process_output() functions from
210         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
211
212         This is clean up and acts as a preparation for elimination of test_types/*
213         classes. These classes will move to the single_test_runner module introduced
214         in this patch.
215
216         https://bugs.webkit.org/show_bug.cgi?id=53004
217
218         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
219         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
220         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
221         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
222         * Scripts/webkitpy/layout_tests/port/base.py:
223         * Scripts/webkitpy/layout_tests/port/chromium.py:
224         * Scripts/webkitpy/layout_tests/port/dryrun.py:
225         * Scripts/webkitpy/layout_tests/port/test.py:
226         * Scripts/webkitpy/layout_tests/port/webkit.py:
227         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
228         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
229         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
230
231 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
232
233         Unreviewed, build fix.
234
235         Delete a line that was accidentally missed in r77586; without it
236         there is still a race between the two threads.
237
238         https://bugs.webkit.org/show_bug.cgi?id=51572
239
240         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
241
242 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
243
244         Reviewed by Tony Chang.
245
246         nrwt: handle "broken pipe" notifications from DRT more cleanly.
247
248         https://bugs.webkit.org/show_bug.cgi?id=52927
249
250         * Scripts/webkitpy/layout_tests/port/server_process.py:
251         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
252
253 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
254
255         Reviewed by Kenneth Russell.
256
257         Update, resubmit change to bug 51572. I think the race that was
258         fixed in r76703 caused the hang that caused us to roll this
259         patch out before, so I'd like to try again.
260
261         https://bugs.webkit.org/show_bug.cgi?id=51572
262
263         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
264         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
265
266 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
267
268         Unreviewed.
269
270         Adding myself to committers.py.
271
272         * Scripts/webkitpy/common/config/committers.py:
273
274 2011-02-03  Adam Roben  <aroben@apple.com>
275
276         Include the crashing function in the link to a crash log
277
278         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
279         function that crashed
280
281         Reviewed by David Kilzer.
282
283         * Scripts/old-run-webkit-tests:
284         (crashLocation): Added. Returns the location of the crash.
285         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
286         could be determined.
287
288 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
289
290         Unreviewed, build fix.
291
292         Actually make the changes suggested by Mihai in his review
293         of bug 53720 :(
294
295         https://bugs.webkit.org/show_bug.cgi?id=53720
296
297         * Scripts/webkitpy/layout_tests/port/test_files.py:
298         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
299
300 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
301
302         Reviewed by Mihai Parparita.
303
304         new-run-webkit-tests: Fix bug introduced in r77434 that was
305         causing us to run the canvas GPU tests on the Mac GPU port. This
306         bug revealed that we were not setting the port.name() field
307         properly in many cases, so I've cleaned up all of that code, and
308         removed a few comments about "version-specific" GPU ports that
309         don't exist and just confused things.
310
311         Testing also revealed that port.abspath_for_test() wasn't
312         normalizing paths on Windows properly, so I fixed that as well.
313
314         https://bugs.webkit.org/show_bug.cgi?id=53719
315
316         * Scripts/webkitpy/layout_tests/port/base.py:
317         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
318         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
319
320 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
321
322         Reviewed by Mihai Parparita.
323
324         new-run-webkit-tests: fix normalization of paths on windows when gathering files
325
326         r77434 introduced a bug that was causing the test expectations
327         for the GPU ports to not be treated properly. It turns out that
328         when we gathered the list of test files on Windows, we would
329         return paths of the form "c:\LayoutTests/fast/canvas", and the
330         mixture of backslashes and forward slashes was confusing things.
331
332         This patch normalizes all of the filenames returned from
333         test_files.find(), and adds better tests for this (fixing a
334         couple of other bugs found in the meantime).
335
336         https://bugs.webkit.org/show_bug.cgi?id=53720
337
338         * Scripts/webkitpy/layout_tests/port/test.py:
339         * Scripts/webkitpy/layout_tests/port/test_files.py:
340         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
341
342 2011-02-03  Adam Roben  <aroben@apple.com>
343
344         Add links to Windows crash logs in results.html
345
346         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
347         results.html
348
349         Reviewed by David Kilzer.
350
351         * Scripts/old-run-webkit-tests:
352         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
353         createDebuggerCommandFile).
354         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
355         tool has exited.
356         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
357         it into the test results directory tree. Only implemented for Cygwin currently.
358         (findNewestFileMatchingGlob): Added. Does what it says.
359         (htmlForResultsSection): Only link to files that exist.
360         (linksForErrorTest): Add a link to the crash log.
361         (deleteExpectedAndActualResults): Delete any old crash log for this test.
362         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
363         hardcoding it here.
364
365 2011-02-03  Adam Roben  <aroben@apple.com>
366
367         Tell the debugger the path to the WebKit source tree when saving a crash log
368
369         This allows the debugger to include the crashing line of code in the log.
370
371         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
372         of code
373
374         Reviewed by Sam Weinig.
375
376         * Scripts/old-run-webkit-tests:
377         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
378         file and returns the path to that file. The commands we pass came from
379         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
380         WebKit source code lives.
381         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
382         line using -c, save them to a file and specify the path to that file using -cf. This works
383         around what is presumably a bug in Windows's command line parsing, where having multiple
384         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
385         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
386         together to make them easier to modify in the future.
387
388 2011-02-02  Sam Weinig  <sam@webkit.org>
389
390         Reviewed by Anders Carlsson.
391
392         Add notification of the end of a rubber band.
393         <rdar://problem/8940648>
394
395         * MiniBrowser/mac/BrowserWindowController.m:
396         (-[BrowserWindowController awakeFromNib]):
397         * WebKitTestRunner/TestController.cpp:
398         (WTR::TestController::createOtherPage):
399         (WTR::TestController::initialize):
400         Stub out the new WKUIClient function.
401
402 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
403
404         Unreviewed.
405
406         Adding myself to committers.py.
407
408         * Scripts/webkitpy/common/config/committers.py:
409
410 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
411
412         Reviewed by Csaba Osztrogonác.
413
414         [Qt][WK2] MiniBrowser's window size should be 800x600
415         https://bugs.webkit.org/show_bug.cgi?id=53670
416
417         Make layout test failure debugging easier.
418         * MiniBrowser/qt/BrowserWindow.cpp:
419         (BrowserWindow::BrowserWindow):
420
421 2011-02-02  Andy Estes  <aestes@apple.com>
422
423         Reviewed by Mark Rowe.
424
425         'update-webkit' should handle OpenSource and Internal using different
426         VCSs.
427
428         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
429         Internal directory.
430
431 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
432
433         Reviewed by Mihai Parparita.
434
435         new-run-webkit-tests: hardcode the directories to scan for tests
436         for GPU bots instead of SKIPping them. See bug 53562 for some
437         context, but we will now hard-code the list of directories to
438         use by default instead of skipping over directories in the
439         expectations file. We do this so that we will be able to merge
440         the expectations files without getting conflicting SKIP
441         directives. Note that this change will reduce the # of tests
442         being run on the Mac GPU bots, because we're accidentally
443         including some today.
444
445         https://bugs.webkit.org/show_bug.cgi?id=53631
446
447         * Scripts/webkitpy/layout_tests/port/base.py:
448         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
449         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
450
451 2011-02-02  Sam Weinig  <sam@webkit.org>
452
453         Reviewed by Beth Dakin.
454
455         Add ChromeClient function to paint custom overhang areas.
456         https://bugs.webkit.org/show_bug.cgi?id=53639
457
458         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
459         (WTR::InjectedBundlePage::InjectedBundlePage):
460         Stub out new callback.
461
462 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
463
464         Reviewed by Tony Chang.
465
466         new-run-webkit-tests: support chromium code paths in mock_drt
467
468         https://bugs.webkit.org/show_bug.cgi?id=53471
469
470         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
471         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
472
473 2011-02-02  Adam Klein  <adamk@chromium.org>
474
475         Reviewed by Tony Chang.
476
477         Update new-run-webkit-tests --chromium to put output under Source/...
478         https://bugs.webkit.org/show_bug.cgi?id=53612
479
480         * BuildSlaveSupport/test-result-archive:
481         * Scripts/webkitpy/layout_tests/port/chromium.py:
482
483 2011-01-28  Tony Chang  <tony@chromium.org>
484
485         Reviewed by Eric Seidel.
486
487         [chromium] remove --use-test-shell from NRWT
488         https://bugs.webkit.org/show_bug.cgi?id=53346
489
490         I've already started removing some of the bindings like eventSender so
491         this already doesn't work isn't useful.  Also updated some comments to
492         refer to DRT instead of test_shell.
493
494         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
495         * Scripts/webkitpy/layout_tests/port/chromium.py:
496         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
497         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
498         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
499         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
500         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
501         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
502
503 2011-02-02  Steve Lacey  <sjl@chromium.org>
504
505         Reviewed by Eric Carlson.
506
507         Implement basic media statistics on media elements.
508         https://bugs.webkit.org/show_bug.cgi?id=53322
509
510         * Scripts/build-webkit:
511
512 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
513
514         [wx] Build fixes for wxWebKit.
515
516         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
517         (LayoutTestController::setSerializeHTTPLoads):
518         * wx/browser/wscript:
519         * wx/build/build_utils.py:
520         * wx/build/settings.py:
521
522 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
523
524         Reviewed by Mihai Parparita.
525
526         new-run-webkit-tests: stop skipping so many tests
527
528         r77163 introduced a regression where we weren't resetting test
529         expectations properly and were skipping too many tests as a
530         result. This patch fixes that and adds a test for it.
531
532         https://bugs.webkit.org/show_bug.cgi?id=53551
533
534         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
535         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
536
537 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
538
539         Reviewed by Tony Chang.
540
541         new-run-webkit-tests: add first stub of test_runner2. This
542         will add support for the 'inline', 'threads', and 'processes'
543         flags to --worker-model, but for now the implementatios just
544         fall back on the old ones.
545
546         https://bugs.webkit.org/show_bug.cgi?id=53157
547
548         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
549         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
550
551 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
552
553         Reviewed by James Robinson.
554
555         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
556         https://bugs.webkit.org/show_bug.cgi?id=53522
557
558         * Scripts/run-chromium-webkit-unit-tests:
559
560 2011-02-01  Adam Barth  <abarth@webkit.org>
561
562         Reviewed by Mihai Parparita.
563
564         Using Control-C to cancel webkit-patch or other python tools causes
565         unpleasant traceback console spew
566         https://bugs.webkit.org/show_bug.cgi?id=53462
567
568         Catch the exception and don't print the stack trace.
569
570         * Scripts/webkit-patch:
571
572 2011-02-01  Scott Cameron  <sccameron@rim.com>
573
574         Reviewed by Daniel Bates.
575
576         Use Windows format for MinGW HTTPD path.
577         https://bugs.webkit.org/show_bug.cgi?id=53503
578
579         * Scripts/webkitperl/httpd.pm:
580           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
581             so that we don't have to escape the space characters in the path. Also,
582             changed path to Windows-style path and removed FIXME comment.
583
584 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
585
586         Reviewed by Andreas Kling.
587
588         [Qt][WK2] Add a way to use shared process model in MiniBrowser
589         https://bugs.webkit.org/show_bug.cgi?id=53090
590
591         * MiniBrowser/qt/BrowserView.cpp:
592         (BrowserView::BrowserView): Removed the m_context member.
593         From now the context is guaranteed to be non-null and we
594         don't need to store that in the object.
595         * MiniBrowser/qt/BrowserView.h:
596         * MiniBrowser/qt/BrowserWindow.cpp:
597         Added static bool to determine that new windows need to be
598         created with their own context or not. Use the same context
599         and web process by default to be inilne with the other ports.
600         (BrowserWindow::BrowserWindow):
601         (BrowserWindow::newWindow):
602         * MiniBrowser/qt/BrowserWindow.h:
603         * MiniBrowser/qt/main.cpp:
604         (main): Added command line switch to be able to use the
605         non-shared process model. Simplify the handling of the command line
606         switches a little bit.
607
608 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
609
610         Reviewed by Andreas Kling.
611
612         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
613         https://bugs.webkit.org/show_bug.cgi?id=53491
614
615         * MiniBrowser/qt/BrowserWindow.cpp:
616         (BrowserWindow::BrowserWindow):
617         (BrowserWindow::toggleFullScreenMode):
618         * MiniBrowser/qt/BrowserWindow.h:
619
620 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
621
622         Reviewed by Andreas Kling.
623
624         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
625         https://bugs.webkit.org/show_bug.cgi?id=53489
626
627         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
628         to Settings menu.
629
630         * MiniBrowser/qt/BrowserWindow.cpp:
631         (BrowserWindow::BrowserWindow):
632         (BrowserWindow::toggleFrameFlattening):
633         (BrowserWindow::toggleDisableJavaScript):
634         (BrowserWindow::toggleAutoLoadImages):
635         * MiniBrowser/qt/BrowserWindow.h:
636
637 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
638
639         Reviewed by Tony Chang.
640
641         [Chromium] Switch chromium-mac to use ChromiumDriver
642         https://bugs.webkit.org/show_bug.cgi?id=53461
643         
644         For the sake of consistency with the other Chromium platforms (and so
645         that chromium-mac picks up special flags like --enable-hardware-gpu),
646         switch chromium-mac from the WebKitDriver to ChromiumDriver.
647
648         * Scripts/webkitpy/layout_tests/port/chromium.py:
649
650 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
651
652         Reviewed by Mihai Parparita.
653
654         The current modifier parsing code in test_expectations is
655         fragile and hard-coded, so it's not easy to understand the logic
656         or easily add new types of modifiers (like GPU vs. CPU testing
657         for graphics tests, or 32-bit vs. 64-bit differences).
658
659         This is the first of two patches that will add in more generic
660         support and then eliminate the GPU-specific test expectations
661         files for Chromium.
662
663         This patch adds two standalone objects for handling modifiers. The
664         rules for interpreting modifiers, precedence, and conflicts are
665         given in the docstring to the ModifierMatcher class, which
666         returns ModifierMatchResult objects.
667         
668         This patch also adds routines to the Port interface and a
669         default set of values in the base object, in order to obtain the
670         values needed on a given test run. These values are then passed
671         to the expectation parser. This also allows us to clean up the
672         logic used to lint all of the different configurations in a
673         single test_expectations.txt file.
674
675         The next patch will merge in the separate GPU expectations file.
676
677         https://bugs.webkit.org/show_bug.cgi?id=51222
678
679         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
680         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
681         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
682         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
683         * Scripts/webkitpy/layout_tests/port/base.py:
684         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
685         * Scripts/webkitpy/layout_tests/port/chromium.py:
686         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
687         * Scripts/webkitpy/layout_tests/port/test.py:
688         * Scripts/webkitpy/layout_tests/port/webkit.py:
689         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
690         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
691         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
692         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
693         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
694
695 2011-01-31  Scott Cameron  <sccameron@rim.com>
696
697         Reviewed by Daniel Bates.
698
699         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
700         https://bugs.webkit.org/show_bug.cgi?id=50036
701
702         This will add an Apache2.2 configuration file and modifies scripts to allow
703         running an httpd server in an MSYS environment.
704
705         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
706         in order to allow for simple installation/execution.  Simply install the latest
707         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
708         be able to execute run-webkit-httpd.
709         
710
711         * Scripts/run-webkit-httpd:
712         * Scripts/webkitperl/httpd.pm:
713
714 2011-01-31  Tony Chang  <tony@chromium.org>
715
716         Reviewed by Eric Seidel.
717
718         mac DRT should report RTL scroll offset relative to top right corner
719         https://bugs.webkit.org/show_bug.cgi?id=53324
720
721         * DumpRenderTree/mac/DumpRenderTree.mm:
722         (dumpFrameScrollPosition):
723
724 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
725
726         Reviewed by Andreas Kling.
727
728         [Qt] Add Take Screen Shot action to MiniBrowser
729         https://bugs.webkit.org/show_bug.cgi?id=53422
730
731         Add Take Screen Shot action to MiniBrowser's view menu.
732
733         * MiniBrowser/qt/BrowserWindow.cpp:
734         (BrowserWindow::BrowserWindow):
735         (BrowserWindow::screenshot):
736         * MiniBrowser/qt/BrowserWindow.h:
737
738 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
739
740         Reviewed by Xan Lopez.
741
742         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
743         https://bugs.webkit.org/show_bug.cgi?id=53379
744
745         Remove left over #ifdef's. I thought all of the conditional code
746         had been freed from the condition, but I forgot to check DRT.
747
748         * DumpRenderTree/gtk/DumpRenderTree.cpp:
749         (resetDefaultsToConsistentValues):
750         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
751         (LayoutTestController::setAlwaysAcceptCookies):
752
753 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
754
755         Unreviewed, build fix.
756
757         Fix regression introduced in r77093 - path.rsplit() doesn't
758         take keyword arguments.
759
760         https://bugs.webkit.org/show_bug.cgi?id=53326
761
762         * Scripts/webkitpy/common/system/filesystem_mock.py:
763
764 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
765
766         Reviewed by Mihai Parparita.
767
768         Add more unit tests for rebaseline-chromium-webkit-tests. This
769         change involves restructuring a bunch of r-c-w-t code to make it
770         more testable as well. We also add wrapper classes for handling
771         testing zip files and fetching URLs.
772
773         https://bugs.webkit.org/show_bug.cgi?id=53040
774
775         * Scripts/webkitpy/common/system/urlfetcher.py:
776         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
777         * Scripts/webkitpy/common/system/zipfileset_mock.py:
778         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
779         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
780         * Scripts/webkitpy/tool/mocktool.py:
781
782 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
783
784         Reviewed by Eric Seidel.
785
786         Clean up of the filesystem-related modules used in webkitpy.
787         I've added relpath() to the filesystem interface, modified
788         ospath.relpath() so that it could work with the filesystem
789         interface, and modified the fileset* routines to use the
790         filesystem interface consistently.
791
792         This patch also adds a close() routine to the fileset routines
793         to indicate that the caller is done with the fileset. This
794         allows zipfileset to clean up after itself when it creates
795         tempfiles to store downloads.
796
797         https://bugs.webkit.org/show_bug.cgi?id=53326
798
799         * Scripts/webkitpy/common/system/directoryfileset.py:
800         * Scripts/webkitpy/common/system/fileset.py:
801         * Scripts/webkitpy/common/system/filesystem.py:
802         * Scripts/webkitpy/common/system/filesystem_mock.py:
803         * Scripts/webkitpy/common/system/filesystem_unittest.py:
804         * Scripts/webkitpy/common/system/ospath.py:
805         * Scripts/webkitpy/common/system/zipfileset.py:
806         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
807
808 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
809
810         Reviewed by Csaba Osztrogonác.
811
812         [Qt][WK2]REGRESSION (r76991): Fix build errors
813         https://bugs.webkit.org/show_bug.cgi?id=53400
814
815         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
816         and remove WebKit2Prefix.h from the build.
817         * MiniBrowser/qt/MiniBrowser.pro:
818
819 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
820
821         Unreviewed.
822
823         [Qt][WK2] Buildfix.
824
825         * MiniBrowser/qt/MiniBrowser.pro:
826
827 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
828
829         Reviewed by Adam Roben.
830         
831         define NOMINMAX when building ImageDiff, as we do elsewhere.
832
833         Add various clampToInt() methods to MathExtras.h
834         https://bugs.webkit.org/show_bug.cgi?id=52910
835
836         * DumpRenderTree/win/ImageDiffCommon.vsprops:
837
838 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
839
840         Reviewed by Darin Adler.
841
842         WebKitTestRunner needs layoutTestController.setPOSIXLocale
843         https://bugs.webkit.org/show_bug.cgi?id=42682
844
845         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
846         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
847         (WTR::InjectedBundle::resetLocalSettings):
848         (WTR::InjectedBundle::didReceiveMessage):
849         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
850         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
851         (WTR::LayoutTestController::setPOSIXLocale):
852         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
853
854 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
855  
856          Reviewed by Mihai Parparita.
857  
858          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
859  
860          This patch re-enables this test and changes it to
861          handle all of the mac platform versions, not just the one
862          it is running on.
863  
864          https://bugs.webkit.org/show_bug.cgi?id=53356
865  
866          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
867  
868 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
869
870         Unreviewed, build fix.
871
872         Take two. The fix in 77023 didn't work, because we were
873         still calling path.abspath_to_uri, which calls _cygpath under
874         the covers, and it appears the cygpath on the bots does
875         something different than it does on my machine. This patch
876         removes the calls to path.abspath_to_uri, so it should be safe.
877         If it doesn't work, I'll roll it out along with r76982 and 77023.
878
879         https://bugs.webkit.org/show_bug.cgi?id=53126
880
881         * Scripts/webkitpy/layout_tests/port/test.py:
882
883 2011-01-28  David Kilzer  <ddkilzer@apple.com>
884
885         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
886         <http://webkit.org/b/53353>
887
888         Reviewed by Mark Rowe.
889
890         * Scripts/webkitdirs.pm:
891         (checkRequiredSystemConfig): Check the Xcode marketing version
892         in addition to the DevCoreTools build version before complaining
893         about an old version of Xcode.  Also make the Mac OS X version
894         check use Perl's built-in version string comparitor.
895
896 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
897
898         Unreviewed, build fix.
899
900         Work around breakage on Win 7 Release bot caused by r76982
901         and the fact that windows ports use "file:////" instead of
902         "file:///". Ideally the test code should be isolated from
903         this, but it isn't yet. Will fix properly in a bit.
904
905         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
906
907 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
908
909         Reviewed by Tony Chang.
910
911         new-run-webkit-tests: change worker model values to
912         "old-inline", "old-threads" in preparation for test_runner2 /
913         multiprocessing changes.
914
915         https://bugs.webkit.org/show_bug.cgi?id=53156
916
917         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
918         * Scripts/webkitpy/layout_tests/port/base.py:
919         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
920         * Scripts/webkitpy/layout_tests/port/mac.py:
921         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
922
923 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
924
925         Reviewed by Tony Chang.
926
927         committers.py - add an IRC nickname for dpranke
928         https://bugs.webkit.org/show_bug.cgi?id=53335
929
930         * Scripts/webkitpy/common/config/committers.py:
931
932 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
933
934         Reviewed by Tony Chang.
935
936         new-run-webkit-tests: add a "mock DRT" port implementation
937         and a separate class that emulates what we expect the
938         DumpRenderTree behavior to be.
939
940         This will eventually replace port/dryrun.py and allow us to get
941         better test coverage of the new-run-webkit-tests code as well as
942         a reference for what new-run-webkit-tests expects from DRT.
943
944         This is the first attempt at this, and it is pretty bare-boned. It
945         really only has been tested on the 'mac' port (and a little on
946         the 'chromium-mac' port.
947
948         https://bugs.webkit.org/show_bug.cgi?id=53126
949
950         * Scripts/webkitpy/common/system/filesystem_mock.py:
951         * Scripts/webkitpy/layout_tests/port/dryrun.py:
952         * Scripts/webkitpy/layout_tests/port/factory.py:
953         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
954         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
955         * Scripts/webkitpy/layout_tests/port/test.py:
956
957 2011-01-28  Pratik Solanki  <psolanki@apple.com>
958
959         Unreviewed. Removing .swp file checked in by mistake.
960
961         * Scripts/.webkitdirs.pm.swp: Removed.
962
963 2011-01-28  Pratik Solanki  <psolanki@apple.com>
964
965         Reviewed by David Kilzer.
966
967         Space not necessary for undefined feature
968         https://bugs.webkit.org/show_bug.cgi?id=53317
969
970         * Scripts/build-webkit:
971
972 2011-01-28  Chang Shu  <chang.shu@nokia.com>
973
974         Reviewed by Andreas Kling.
975
976         Reset NetworkAccessManager to clean up credentials from previous tests.
977         This change causes no performance overhead either.
978         https://bugs.webkit.org/show_bug.cgi?id=36688
979
980         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
981         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
982         (WebCore::DumpRenderTree::open):
983         * DumpRenderTree/qt/DumpRenderTreeQt.h:
984
985 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
986
987         Reviewed by Andreas Kling.
988
989         [Qt] Add Zoom Text Only action to MiniBrowser
990         https://bugs.webkit.org/show_bug.cgi?id=53297
991
992         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
993
994         * MiniBrowser/qt/BrowserWindow.cpp:
995         (BrowserWindow::BrowserWindow):
996         (BrowserWindow::zoomIn):
997         (BrowserWindow::zoomOut):
998         (BrowserWindow::resetZoom):
999         (BrowserWindow::toggleZoomTextOnly):
1000         (BrowserWindow::applyZoom):
1001         * MiniBrowser/qt/BrowserWindow.h:
1002
1003 2011-01-28  Adam Barth  <abarth@webkit.org>
1004
1005         Reviewed by Eric Seidel.
1006
1007         Add webkit-patch roll-chromium-deps
1008         https://bugs.webkit.org/show_bug.cgi?id=53288
1009
1010         This command updates the Source/WebKit/chromium/DEPS file with the
1011         last-known good revision of Chromium (or a revision specified on the
1012         command line).  I'd eventually like to turn this into a SheriffBot
1013         command, but this is the first step.
1014
1015         This patch somewhat sprawled because I needed to move a bunch of code
1016         out of ChangeLog that should never have been there in the first place.
1017         Also, I had to fix a bug in MockUser in order to test the new command.
1018
1019         * Scripts/webkitpy/common/checkout/api.py:
1020         * Scripts/webkitpy/common/checkout/changelog.py:
1021         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1022         * Scripts/webkitpy/common/checkout/deps.py: Added.
1023         * Scripts/webkitpy/common/config/urls.py:
1024         * Scripts/webkitpy/tool/commands/__init__.py:
1025         * Scripts/webkitpy/tool/commands/download_unittest.py:
1026         * Scripts/webkitpy/tool/commands/roll.py: Added.
1027         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1028         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1029         * Scripts/webkitpy/tool/mocktool.py:
1030         * Scripts/webkitpy/tool/steps/__init__.py:
1031         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1032         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1033         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1034         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1035         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1036         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1037
1038 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1039
1040         Reviewed by Laszlo Gombos.
1041
1042         Get rid of prefix header dependency for WebKit2 build system
1043         https://bugs.webkit.org/show_bug.cgi?id=50174
1044
1045         Change the style checker so that it enforces config.h include for
1046         WebKit2.
1047
1048         * Scripts/webkitpy/style/checker.py:
1049
1050 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1051
1052         Reviewed by Darin Adler.
1053
1054         execCommand("Paste") doesn't work in WebKitTestRunner
1055         https://bugs.webkit.org/show_bug.cgi?id=52785
1056
1057         Enable both of the settings needed to allow paste.
1058         
1059         * WebKitTestRunner/TestController.cpp:
1060         (WTR::TestController::resetStateToConsistentValues):
1061
1062 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1063
1064         Reviewed by Andreas Kling.
1065
1066         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1067         https://bugs.webkit.org/show_bug.cgi?id=48440
1068
1069         Preserve user input when toggling use of QGraphicsView
1070
1071         * QtTestBrowser/launcherwindow.cpp:
1072         (LauncherWindow::initializeView):
1073         (LauncherWindow::loadFinished):
1074         * QtTestBrowser/launcherwindow.h:
1075         * QtTestBrowser/mainwindow.cpp:
1076         (MainWindow::addressUrl):
1077         * QtTestBrowser/mainwindow.h:
1078
1079 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1080
1081         Reviewed by Mihai Parparita.
1082
1083         new-run-webkit-tests: turn off pixel tests correctly by default
1084         for webkit-based ports. r70013 (bug 47510) used
1085         port.set_option_default() to attempt to set default values, but
1086         that didn't work correctly. I have removed set_option_default
1087         for now since it was only being used in two places and in three
1088         useless unit tests. There is a separate bug open to fix the
1089         option parsing (48095), so this workaround is fine for now.
1090
1091         https://bugs.webkit.org/show_bug.cgi?id=53217
1092
1093         * Scripts/webkitpy/layout_tests/port/webkit.py:
1094         * Scripts/webkitpy/layout_tests/port/base.py:
1095         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1096
1097 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1098
1099         Rubber-stamped by Ariya Hidayat.
1100
1101         Trivial crash fix in WTR.
1102
1103         * WebKitTestRunner/TestController.cpp:
1104         (WTR::TestController::initialize): Increase the size
1105         of the vector by one to be able to store the null character.
1106
1107 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1108
1109         Reviewed by Csaba Osztrogonác.
1110
1111         [Qt][WK2] WTR should be initialized in the same way as DRT
1112         https://bugs.webkit.org/show_bug.cgi?id=53240
1113
1114         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1115         (WTR::activateFonts): Added missing initialization steps.
1116
1117 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1118
1119         Unreviewed. 
1120
1121         Adding myself to committers.py.
1122
1123         * Scripts/webkitpy/common/config/committers.py:
1124
1125 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1126
1127         Reviewed by Csaba Osztrogonác.
1128
1129         [Qt] [Symbian] Move project files into Source
1130         https://bugs.webkit.org/show_bug.cgi?id=52891
1131
1132         Fix the Symbian build after the project files
1133         are moved to Source directory. On Symbian qmake
1134         needs to run in the same directory where the main
1135         pro files (WebKit.pro, Tools.pro) are located.
1136
1137         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1138         is located before running qmake for Symbian. Qmake on Symbian
1139         does not properly honor the "-o" option, work it around by setting
1140         the name of the Makefile to bld.inf.
1141
1142 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1143
1144         Reviewed by Andreas Kling.
1145
1146         [Qt] Add simple zooming features to MiniBrowser
1147         https://bugs.webkit.org/show_bug.cgi?id=53231
1148
1149         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1150
1151         * MiniBrowser/qt/BrowserWindow.cpp:
1152         (BrowserWindow::BrowserWindow):
1153         (BrowserWindow::zoomIn):
1154         (BrowserWindow::zoomOut):
1155         (BrowserWindow::resetZoom):
1156         (BrowserWindow::updateUserAgentList):
1157         (BrowserWindow::applyZoom):
1158         * MiniBrowser/qt/BrowserWindow.h:
1159
1160 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1161
1162         Reviewed by Dan Bernstein.
1163
1164         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1165         https://bugs.webkit.org/show_bug.cgi?id=42319
1166         
1167         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1168
1169         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1170         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1171         (WTR::LayoutTestController::showWebInspector):
1172         (WTR::LayoutTestController::closeWebInspector):
1173         (WTR::LayoutTestController::evaluateInWebInspector):
1174         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1175         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1176         * WebKitTestRunner/TestInvocation.cpp:
1177         (WTR::shouldOpenWebInspector):
1178         (WTR::TestInvocation::invoke):
1179         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1180
1181 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1182
1183         Reviewed by Xan Lopez.
1184
1185         [GTK] Pixel dumps do not include scrollbars in output images
1186         https://bugs.webkit.org/show_bug.cgi?id=53216
1187
1188         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1189         that have scrollbars.
1190
1191         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1192         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1193         instead of the web view itself.
1194
1195 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1196
1197         Reviewed by Mihai Parparita.
1198
1199         Fix regression introduced in r76322 ... new-run-webkit-tests
1200         was attempting to save the image diff output as a UTF-8-encoded
1201         file.
1202
1203         https://bugs.webkit.org/show_bug.cgi?id=53210
1204
1205         * Scripts/webkitpy/layout_tests/port/webkit.py:
1206
1207 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1208
1209         Unreviewed, rolling out r76709.
1210         http://trac.webkit.org/changeset/76709
1211         https://bugs.webkit.org/show_bug.cgi?id=53194
1212
1213         "broke python tests on non-snowleopard platforms" (Requested
1214         by dpranke on #webkit).
1215
1216         * Scripts/webkitpy/layout_tests/port/factory.py:
1217         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1218         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1219
1220 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1221
1222         Reviewed by Tony Chang.
1223
1224         new-run-webkit-tests: add a "mock DRT" port implementation
1225         and a separate class that emulates what we expect the
1226         DumpRenderTree behavior to be.
1227
1228         This will eventually replace port/dryrun.py and allow us to get
1229         better test coverage of the new-run-webkit-tests code as well as
1230         a reference for what new-run-webkit-tests expects from DRT.
1231
1232         This is the first attempt at this, and it is pretty bare-boned. It
1233         really only has been tested on the 'mac' port (and a little on
1234         the 'chromium-mac' port.
1235
1236         https://bugs.webkit.org/show_bug.cgi?id=53126
1237
1238         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1239         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1240         * Scripts/webkitpy/layout_tests/port/factory.py:
1241
1242 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1243
1244         Reviewed by Tony Chang.
1245
1246         Add '--no-timeout' option to Chromium DRT to ease debugging.
1247         https://bugs.webkit.org/show_bug.cgi?id=52873
1248
1249         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1250         (main):
1251
1252 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1253
1254         Reviewed by Andreas Kling.
1255
1256         [Qt] Fix qt_minimal build
1257         https://bugs.webkit.org/show_bug.cgi?id=53172
1258
1259         * QtTestBrowser/locationedit.h:
1260
1261 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1262
1263         Reviewed by Antonio Gomes.
1264
1265         QtTestBrowser should have a UI Setting to disable plugins
1266         https://bugs.webkit.org/show_bug.cgi?id=52408
1267         
1268         Added a new action item named "Disable Plugins"
1269         under the "Settings" menu. 
1270
1271         * QtTestBrowser/launcherwindow.cpp:
1272         (LauncherWindow::createChrome):
1273         (LauncherWindow::togglePlugins):
1274         * QtTestBrowser/launcherwindow.h:
1275
1276 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1277
1278         Reviewed by Adam Barth.
1279
1280         Move main CMakeLists.txt into Source directory
1281         https://bugs.webkit.org/show_bug.cgi?id=52888
1282
1283         * Scripts/webkitdirs.pm:
1284
1285 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1286
1287         Reviewed by Eric Seidel.
1288
1289         Improve label text in submit-to-ews
1290         https://bugs.webkit.org/show_bug.cgi?id=53130
1291
1292         * QueueStatusServer/templates/submittoews.html:
1293
1294 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1295
1296         Reviewed by Antonio Gomes.
1297
1298         QtTestBrowser should have a UI Settings to prevent loading images
1299         https://bugs.webkit.org/show_bug.cgi?id=52409
1300         
1301         Added a new action item named "DisableAutoLoadImages"
1302         under the "Settings" menu 
1303
1304         * QtTestBrowser/launcherwindow.cpp:
1305         (LauncherWindow::createChrome):
1306         (LauncherWindow::toggleAutoLoadImages):
1307         * QtTestBrowser/launcherwindow.h:
1308
1309 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1310
1311         Reviewed by Tony Chang.
1312
1313         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1314         classes, test_expectations.py. This change adds "test-win" and
1315         "test-mac" variants to the test port so that we can better test
1316         rebaselining, and adds a MockUser() object for reuse in testing.
1317
1318         https://bugs.webkit.org/show_bug.cgi?id=53036
1319
1320         * Scripts/webkitpy/common/system/filesystem.py:
1321         * Scripts/webkitpy/common/system/filesystem_mock.py:
1322         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1323         * Scripts/webkitpy/layout_tests/port/factory.py:
1324         * Scripts/webkitpy/layout_tests/port/base.py:
1325         * Scripts/webkitpy/layout_tests/port/test.py:
1326         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1327         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1328         * Scripts/webkitpy/tool/mocktool.py:
1329
1330 2011-01-25  Tony Chang  <tony@chromium.org>
1331
1332         Reviewed by Dimitri Glazkov.
1333
1334         [chromium] remove unused layoutTestController callback
1335         https://bugs.webkit.org/show_bug.cgi?id=53103
1336
1337         This method is used by a test_shell_test, but not needed by DRT.
1338
1339         * DumpRenderTree/chromium/LayoutTestController.cpp:
1340         (LayoutTestController::LayoutTestController):
1341         * DumpRenderTree/chromium/LayoutTestController.h:
1342
1343 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1344
1345         Reviewed by Andreas Kling.
1346
1347         [GTK] Remove 64 bits release bot from the buildbot master
1348         https://bugs.webkit.org/show_bug.cgi?id=52899
1349
1350         Removes the 64 bits release slave from the buildbot configuration,
1351         so that we can use it as an EWS.
1352
1353         * BuildSlaveSupport/build.webkit.org-config/config.json:
1354
1355 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1356
1357         Reviewed by Dan Bernstein.
1358
1359         Implement database quota callback to fix storage tests on WebKit2 bot
1360         https://bugs.webkit.org/show_bug.cgi?id=53064
1361
1362         * WebKitTestRunner/TestController.cpp:
1363         (WTR::exceededDatabaseQuota):
1364         (WTR::TestController::createOtherPage):
1365         (WTR::TestController::initialize):
1366
1367 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1368
1369         Reviewed by Anders Carlsson.
1370
1371         Use designated temp directory for the database for WebKit2
1372         https://bugs.webkit.org/show_bug.cgi?id=53052
1373         
1374         Adopt the new WK2 API for this.
1375
1376         * WebKitTestRunner/TestController.cpp:
1377         (WTR::TestController::libraryPathForTesting):
1378         (WTR::TestController::initialize):
1379         * WebKitTestRunner/TestController.h:
1380         * WebKitTestRunner/mac/TestControllerMac.mm:
1381         (WTR::TestController::platformLibraryPathForTesting):
1382         * WebKitTestRunner/qt/TestControllerQt.cpp:
1383         (WTR::TestController::platformLibraryPathForTesting):
1384         * WebKitTestRunner/win/TestControllerWin.cpp:
1385         (WTR::TestController::platformLibraryPathForTesting):
1386
1387 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1388
1389         Reviewed by Stephanie Lewis.
1390
1391         Add a new Leopard test bot.
1392
1393         * BuildSlaveSupport/build.webkit.org-config/config.json:
1394
1395 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1396
1397         Reviewed by Adam Barth.
1398
1399         Add EFL Builder to core waterfall
1400         https://bugs.webkit.org/show_bug.cgi?id=52704
1401
1402         Add EFL Builder to the core waterfall again.
1403
1404         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1405         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1406
1407 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1408
1409         Reviewed by Tony Chang.
1410
1411         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1412         https://bugs.webkit.org/show_bug.cgi?id=52872
1413
1414         Force disabling proxy to resolve the problem.
1415
1416         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1417         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1418
1419 2011-01-24  Andreas Kling  <kling@webkit.org>
1420
1421         Reviewed by Darin Adler.
1422
1423         check-webkit-style: Update exemptions following Source/ move.
1424         https://bugs.webkit.org/show_bug.cgi?id=53017
1425
1426         * Scripts/webkitpy/style/checker.py:
1427         * Scripts/webkitpy/style/checker_unittest.py:
1428
1429 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1430
1431         Rubber-stamped by Csaba Osztrogonác.
1432
1433         [Qt] Move project files into Source
1434         https://bugs.webkit.org/show_bug.cgi?id=52891
1435
1436         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1437
1438 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1439
1440         Reviewed by Yury Semikhatsky.
1441
1442         Web Inspector: Find duplicate strings in localizedStrings.js
1443
1444         https://bugs.webkit.org/show_bug.cgi?id=53005
1445
1446         * Scripts/check-inspector-strings:
1447
1448 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1449
1450         Reviewed by Andreas Kling.
1451
1452         [Qt] Regroup MiniBrowser's menubar and add open file action
1453         https://bugs.webkit.org/show_bug.cgi?id=53000
1454
1455         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1456
1457         * MiniBrowser/qt/BrowserWindow.cpp:
1458         (BrowserWindow::BrowserWindow):
1459         (BrowserWindow::openFile):
1460         (BrowserWindow::~BrowserWindow):
1461         * MiniBrowser/qt/BrowserWindow.h:
1462
1463 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1464
1465         Unreviewed fix after r76496
1466
1467         [Qt] Move project files into Source
1468         https://bugs.webkit.org/show_bug.cgi?id=52891
1469
1470         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1471         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1472         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1473
1474 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1475
1476         Reviewed by Csaba Osztrogonác.
1477
1478         [Qt] Move project files into Source
1479         https://bugs.webkit.org/show_bug.cgi?id=52891
1480
1481         * DerivedSources.pro: Renamed from DerivedSources.pro.
1482         * DumpRenderTree/qt/DumpRenderTree.pro:
1483         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1484         * MiniBrowser/DerivedSources.pro:
1485         * MiniBrowser/qt/MiniBrowser.pro:
1486         * QtTestBrowser/QtTestBrowser.pro:
1487         * Scripts/webkitdirs.pm:
1488         * Tools.pro: Added.
1489         * WebKitTestRunner/DerivedSources.pro:
1490         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1491         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1492
1493 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1494
1495         Reviewed by Dan Bernstein.
1496
1497         Beefed up --threaded mode to catch even more kinds of errors.
1498         https://bugs.webkit.org/show_bug.cgi?id=52971
1499
1500         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1501         context group to force JSC to mark multiple threads. (This used to be
1502         the default, but it changed in SnowLeopard.)
1503         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1504         to give threading mistakes more chances to show themselves.
1505         (startJavaScriptThreads):
1506         (stopJavaScriptThreads):
1507
1508 2011-01-22  Robert Hogan  <robert@webkit.org>
1509
1510         Reviewed by Andreas Kling.
1511
1512         [Qt] Support layoutTestController.addURLToRedirect()
1513         https://bugs.webkit.org/show_bug.cgi?id=52956
1514
1515         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1516         (LayoutTestController::addURLToRedirect):
1517         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1518
1519 2011-01-22  Robert Hogan  <robert@webkit.org>
1520
1521         Reviewed by Kenneth Rohde Christiansen.
1522
1523         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1524         https://bugs.webkit.org/show_bug.cgi?id=49802
1525
1526         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1527         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1528         (WebCore::DumpRenderTree::open):
1529
1530 2011-01-21  Adam Barth  <abarth@webkit.org>
1531
1532         Reviewed by Maciej Stachowiak.
1533
1534         Disable mac_unittest.py that fails on some of the Mac bots
1535         https://bugs.webkit.org/show_bug.cgi?id=52947
1536
1537         As noted in the comment, this test does not appear to be correct
1538         because the function this test is testing returns different results
1539         depending on which flavor of Mac the test is run on.  This patch
1540         disable the test.  Hopefully we can re-enable the test once we've
1541         probably insulated the test from its environment.
1542
1543         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1544
1545 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1546
1547         Reviewed by Mihai Parparita.
1548
1549         Fix bug introduced in r76322 that caused NRWT to not actually
1550         read the Skipped files properly.
1551
1552         https://bugs.webkit.org/show_bug.cgi?id=52771
1553
1554         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1555         * Scripts/webkitpy/layout_tests/port/webkit.py:
1556         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1557
1558 2011-01-21  Sam Weinig  <sam@webkit.org>
1559
1560         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1561
1562         WebKitTestRunner needs the HOME environment variable to be set.
1563         <rdar://problem/8896573>
1564
1565         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1566         it exists.
1567
1568 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1569
1570         Reviewed by Eric Seidel.
1571
1572         Suppress a few remaining integration tests so that none of the
1573         layout_test unit tests ever read from the filesystem or launch
1574         subprocesses that aren't part of the unit tests.
1575
1576         Also fix a minor bug in the printing unit tests that was
1577         incorrectly relying on sys.argv.
1578
1579         https://bugs.webkit.org/show_bug.cgi?id=52863
1580
1581         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1582         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1583         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1584
1585 2011-01-21  Darin Adler  <darin@apple.com>
1586
1587        Fix Mac build.
1588
1589         * MiniBrowser/mac/BrowserWindowController.m:
1590         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1591
1592 2011-01-20  Darin Adler  <darin@apple.com>
1593
1594         Reviewed by Dan Bernstein.
1595
1596         WebKit2: Implement showModalDialog
1597         https://bugs.webkit.org/show_bug.cgi?id=52855
1598
1599         This fixes WebKitTestRunner to compile, but more work is probably
1600         needed to get it to pass the tests.
1601
1602         * WebKitTestRunner/TestController.cpp:
1603         (WTR::TestController::runModal): Added. Calls through to the
1604         platform-specific version of runModal.
1605         (WTR::TestController::createOtherPage): Changed to be a private
1606         static member function so it can refer to runModal, which is
1607         a private static member function.
1608         (WTR::TestController::initialize): Pass 0 for the runModal
1609         function since we don't need to run the main window modal.
1610         I suspect this is wrong and will need to change.
1611         * WebKitTestRunner/TestController.h: Added declarations for
1612         the functions added above.
1613         * WebKitTestRunner/mac/TestControllerMac.mm:
1614         (WTR::TestController::runModal): Added. Untested implementation.
1615         * WebKitTestRunner/qt/TestControllerQt.cpp:
1616         (WTR::TestController::runModal): Added.
1617         * WebKitTestRunner/win/TestControllerWin.cpp:
1618         (WTR::TestController::runModal): Added.
1619
1620 2011-01-21  Eric Seidel  <eric@webkit.org>
1621
1622         Reviewed by Adam Barth.
1623
1624         Split Host object off from WebKitPatch for easier re-use
1625         https://bugs.webkit.org/show_bug.cgi?id=52284
1626
1627         new-run-webkit-tests and other tools are eventually going to want one of these.
1628         Basically you need to inherit from this class if you want to pretend to be a
1629         self.tool object for Steps/Commands.
1630
1631         * Scripts/webkitpy/common/host.py: Added.
1632         * Scripts/webkitpy/tool/main.py:
1633
1634 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1635
1636         Reviewed by Adam Barth.
1637
1638         Disable the tests that start and stop the http server and web
1639         server, so that we don't have to worry about port collisions on
1640         the bots.
1641
1642         https://bugs.webkit.org/show_bug.cgi?id=52861
1643
1644         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1645
1646 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1647
1648         Reviewed by Eric Seidel.
1649
1650         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1651         
1652         https://bugs.webkit.org/show_bug.cgi?id=52772
1653         
1654         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1655
1656 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1657
1658         Reviewed by Eric Siedel.
1659
1660         nrwt: clean up almost all remaining port references, remove
1661         unnecessary import clauses. The only remaining references are
1662         in places where a mock filesystem makes no sense or can't be
1663         used, and in one routine in port/google_chrome_unittest that
1664         I'll rewrite in a separate patch.
1665
1666         https://bugs.webkit.org/show_bug.cgi?id=52771
1667
1668         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1669         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1670         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1671         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1672         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1673         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1674         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1675         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1676         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1677         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1678         * Scripts/webkitpy/layout_tests/port/gtk.py:
1679         * Scripts/webkitpy/layout_tests/port/mac.py:
1680         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1681         * Scripts/webkitpy/layout_tests/port/qt.py:
1682         * Scripts/webkitpy/layout_tests/port/webkit.py:
1683         * Scripts/webkitpy/layout_tests/port/win.py:
1684         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1685
1686 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1687
1688         Reviewed by Mihai Parparita.
1689
1690         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1691
1692         https://bugs.webkit.org/show_bug.cgi?id=52762
1693
1694         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1695         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1696
1697 2011-01-20  Tony Chang  <tony@chromium.org>
1698
1699         Reviewed by Ojan Vafai.
1700
1701         [chromium] fix the paths used for the rebaseline tool
1702         https://bugs.webkit.org/show_bug.cgi?id=52857
1703
1704         Some of the bots were renamed so the path to grab the results zip
1705         file has changed.
1706
1707         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1708
1709 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1710
1711         Reviewed by Tony Chang.
1712
1713         Fix bug introduced in r72688 / bug 52768 that broke the
1714         generation of the output filename links in the results.html
1715         output. Apparently none of the unit tests actually checked to
1716         make sure the generated links were correct :(
1717
1718         https://bugs.webkit.org/show_bug.cgi?id=52854
1719
1720         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1721         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1722
1723 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1724
1725         Reviewed by Darin Adler.
1726
1727         https://bugs.webkit.org/show_bug.cgi?id=52849
1728         Make window.print work with WebKit2
1729
1730         * MiniBrowser/mac/BrowserWindowController.m:
1731         (-[BrowserWindowController awakeFromNib]):
1732         * WebKitTestRunner/TestController.cpp:
1733         (WTR::createOtherPage):
1734         (WTR::TestController::initialize):
1735         Added zeroes to WKPageUIClient structures to avoid build failures.
1736
1737 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1738
1739         Reviewed by Eric Seidel.
1740
1741         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1742
1743         https://bugs.webkit.org/show_bug.cgi?id=52756
1744
1745         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1746         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1747         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1748         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1749         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1750         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1751
1752 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1753
1754         Reviewed by Antonio Gomes.
1755
1756         QtTestBrowser should have a seperate menu for Settings
1757         https://bugs.webkit.org/show_bug.cgi?id=52817
1758         
1759         Added a new menu item named "Settings"
1760         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1761
1762         * QtTestBrowser/launcherwindow.cpp:
1763         (LauncherWindow::createChrome):
1764
1765 2011-01-20  Sam Weinig  <sam@webkit.org>
1766
1767         Reviewed by John Sullivan.
1768
1769         Update update-webkit-localizable-strings with new path to WebKit.
1770
1771         * Scripts/update-webkit-localizable-strings:
1772
1773 2011-01-20  James Robinson  <jamesr@chromium.org>
1774
1775         Reviewed by Darin Fisher.
1776
1777         Implement mozilla's requestAnimationFrame API
1778         https://bugs.webkit.org/show_bug.cgi?id=51218
1779
1780         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1781
1782         * DumpRenderTree/chromium/WebViewHost.cpp:
1783         (invokeScheduleComposite):
1784         (WebViewHost::scheduleAnimation):
1785         (WebViewHost::paintInvalidatedRegion):
1786         * DumpRenderTree/chromium/WebViewHost.h:
1787
1788 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1789
1790         Reviewed by Adam Roben.
1791
1792         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1793         https://bugs.webkit.org/show_bug.cgi?id=42327
1794
1795         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1796         for methods that take their normal arguments but also a JSContextRef.
1797         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1798         for evaluateScriptInIsolatedWorld.
1799         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1800         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1801         this call is for an isolated world.
1802         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1803         (WTR::worldMap): Helper to create a world map.
1804         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1805         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1806         added LayoutTestController API.
1807         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1808
1809 2011-01-19  Adam Roben  <aroben@apple.com>
1810
1811         Convert paths in environment variables back to msys-style inside commit-log-editor
1812
1813         When this script gets run from inside git commit, msys-style paths in the environment will
1814         have been turned into Windows-style paths with forward slashes. This screws up functions
1815         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1816         the paths back to msys-style before doing anything else.
1817
1818         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1819         using msysgit's Perl and multiple ChangeLogs have been edited
1820
1821         Reviewed by David Kilzer.
1822
1823         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1824         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1825         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1826
1827 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1828
1829         [Win] Unreviewed build fix after r76248.
1830
1831         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1832
1833 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1834
1835         Reviewed by Csaba Osztrogonác.
1836
1837         Refactoring of the custom allocation framework
1838         https://bugs.webkit.org/show_bug.cgi?id=49897
1839
1840         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1841         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1842         equivalent macro implementation at the necessary places.
1843 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1844
1845         Unreviewed. 
1846
1847         Adding myself to committers.py.
1848
1849         * Scripts/webkitpy/common/config/committers.py:
1850
1851 2011-01-20  Adam Barth  <abarth@webkit.org>
1852
1853         Reviewed by Tony Chang.
1854
1855         Chromium builders don't delete unversioned directories when DEPS change
1856         https://bugs.webkit.org/show_bug.cgi?id=52745
1857
1858         If we pass this option to gclient sync, gclient will delete directories
1859         that are no longer part of DEPS instead of leaving them around to
1860         confuse us later.  Apparently, the downstream buildbots use this option
1861         already.
1862
1863         * Scripts/update-webkit-chromium:
1864
1865 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1866
1867         Unreviewed, build fix - I pulled this patch in to fix an issue
1868         revealed by r76195 running on some new bots). Also fix a couple
1869         of other issues revealed in testing.
1870
1871         nrwt: remove fs refs from layout_package/json*
1872
1873         https://bugs.webkit.org/show_bug.cgi?id=52754
1874
1875         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1876         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1877         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1878         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1879         * Scripts/webkitpy/layout_tests/port/base.py:
1880
1881 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1882
1883         Unreviewed, build fix.
1884
1885         Fix a couple of minor bugs discovered while bringing up new bots
1886         for testing.
1887
1888         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1889         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1890
1891 2011-01-19  James Robinson  <jamesr@chromium.org>
1892
1893         Unreviewed, rolling out r76194.
1894         http://trac.webkit.org/changeset/76194
1895         https://bugs.webkit.org/show_bug.cgi?id=51218
1896
1897         Caused mysterious compile failure on the chromium win
1898         build.webkit.org bots
1899
1900         * DumpRenderTree/chromium/WebViewHost.cpp:
1901         (WebViewHost::paintInvalidatedRegion):
1902         * DumpRenderTree/chromium/WebViewHost.h:
1903
1904 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1905
1906         Reviewed by Mihai Parparita.
1907
1908         remove fs refs from test_runner, dump_render_tree_thread
1909
1910         https://bugs.webkit.org/show_bug.cgi?id=52753
1911
1912         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1913         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1914         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1915         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1916
1917 2011-01-19  James Robinson  <jamesr@chromium.org>
1918
1919         Reviewed by Darin Fisher.
1920
1921         Implement mozilla's requestAnimationFrame API
1922         https://bugs.webkit.org/show_bug.cgi?id=51218
1923
1924         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1925
1926         * DumpRenderTree/chromium/WebViewHost.cpp:
1927         (invokeScheduleComposite):
1928         (WebViewHost::scheduleAnimation):
1929         (WebViewHost::paintInvalidatedRegion):
1930         * DumpRenderTree/chromium/WebViewHost.h:
1931
1932 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1933
1934         Unreviewed, build fix.
1935
1936         Fix a few incorrect "self._filesystem" references introduced in
1937         r76184.
1938
1939         * Scripts/webkitpy/layout_tests/port/chromium.py:
1940         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1941
1942 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1943
1944         Reviewed by Mihai Parparita.
1945
1946         add a .sep property, abspath(), isabs(), mtime(), and
1947         open_text_file_for_writing() to filesystem modules. Some of
1948         these properties are not needed in this patch but will be needed
1949         in subsequent patches (I'm doing this to avoid having to track
1950         multiple versions of a single file).
1951
1952         Also, change most of the port/* modules to use the filesystem
1953         objects instead of referencing the filesystem directly.
1954
1955         https://bugs.webkit.org/show_bug.cgi?id=52748
1956
1957         * Scripts/webkitpy/common/system/filesystem.py:
1958         * Scripts/webkitpy/common/system/filesystem_mock.py:
1959         * Scripts/webkitpy/layout_tests/port/__init__.py:
1960         * Scripts/webkitpy/layout_tests/port/base.py:
1961         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1962         * Scripts/webkitpy/layout_tests/port/chromium.py:
1963         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1964         * Scripts/webkitpy/layout_tests/port/config.py:
1965         * Scripts/webkitpy/layout_tests/port/test.py:
1966         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1967
1968 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1969
1970         Reviewed by Anders Carlsson.
1971
1972         If resetting between tests times out, treat it as a WebProcess crash
1973         https://bugs.webkit.org/show_bug.cgi?id=52757
1974
1975         * WebKitTestRunner/TestController.cpp:
1976         (WTR::TestController::runTest):
1977
1978 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1979
1980         Reviewed by Darin Adler.
1981
1982         https://bugs.webkit.org/show_bug.cgi?id=52739
1983         Make it possible for a WebKit2 client to print headers and footers
1984
1985         Added dummy implementations for new printing UIClient calls.
1986
1987         * MiniBrowser/mac/BrowserWindowController.m:
1988         (-[BrowserWindowController awakeFromNib]):
1989         * WebKitTestRunner/TestController.cpp:
1990         (WTR::createOtherPage):
1991         (WTR::TestController::initialize):
1992
1993 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1994
1995         Reviewed by Ojan Vafai.
1996
1997         Change webkitpy/layout_tests/port/test.py to use the
1998         in-memory filesystem for cleaner unit testing. This
1999         change allows us to kill a lot of code that was
2000         specific to the test port, at the cost of being a
2001         little less clear about how things would work if
2002         you didn't have a filesystem.
2003
2004         https://bugs.webkit.org/show_bug.cgi?id=52605
2005
2006         * Scripts/webkitpy/layout_tests/port/test.py:
2007
2008 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2009
2010         Unreviewed, build fix.
2011
2012         Fix test failure caused by committing attachment 79368 instead
2013         of attachment 79461 on bug 52604.
2014
2015         * Scripts/webkitpy/common/system/filesystem_mock.py:
2016
2017 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2018
2019         Reviewed by Mihai Parparita.
2020
2021         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2022         unit testing. os.walk() is too much of a hassle to implement on
2023         top of the in-memory mock filesystem and adding the necessary
2024         interface to files_under() gives clients a cleaner API anyway
2025         (for this particular usage model).
2026
2027         https://bugs.webkit.org/show_bug.cgi?id=52691
2028
2029         * Scripts/webkitpy/common/system/filesystem.py:
2030         * Scripts/webkitpy/common/system/filesystem_mock.py:
2031         * Scripts/webkitpy/layout_tests/port/test_files.py:
2032         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2033
2034 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2035
2036         Reviewed by Tony Chang.
2037
2038         Change more modules in the layout-tests code to use the
2039         filesystem wrapper for cleaner unit testing.
2040
2041         This patch also adds the glob() wrapper to the filesystem
2042         abstraction.
2043         
2044         https://bugs.webkit.org/show_bug.cgi?id=52604
2045
2046         * Scripts/webkitpy/layout_tests/port/test_files.py:
2047         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2048         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2049         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2050         * Scripts/webkitpy/common/system/filesystem.py:
2051         * Scripts/webkitpy/common/system/filesystem_mock.py:
2052
2053 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2054
2055         Unreviewed.
2056
2057         Updating my email addresses and irc nick.
2058
2059         * Scripts/webkitpy/common/config/committers.py:
2060
2061 2011-01-19  Tony Chang  <tony@chromium.org>
2062
2063         Reviewed by Mihai Parparita.
2064
2065         [chromium] [linux] if check-sys-deps fails, output the failure reason
2066         https://bugs.webkit.org/show_bug.cgi?id=52671
2067
2068         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2069             error handler functions.
2070         * Scripts/webkitpy/layout_tests/port/chromium.py:
2071             output the error text from --check-sys-deps
2072         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2073
2074 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2075
2076         Reviewed by Andreas Kling.
2077
2078         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2079         https://bugs.webkit.org/show_bug.cgi?id=52554
2080         
2081         QtNetworkAccessManager is created in a thread and set as
2082         member variable in QWebPage. When the thread is destroyed
2083         the object is still used. So fix will set the object to
2084         NULL once the thread is destroyed.
2085
2086         * QtTestBrowser/launcherwindow.cpp:
2087         (LauncherWindow::~LauncherWindow):
2088
2089 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2090
2091         Rubber stamped by Csaba Osztrogonac
2092
2093         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2094
2095 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2096
2097         Reviewed by Tony Chang.
2098
2099         new-run-webkit-tests: add a --build-directory command line argument
2100
2101         Official Google Chrome builds use a non-standard build directory
2102         location. This patch adds a --build-directory argument that
2103         allows that location to be specified on the command line. Only
2104         Chromium-based builds will use this flag for now, but anyone can
2105         in the future.
2106
2107         There are no unit tests for this since it's difficult to test
2108         until mock filesystems are fully supported in the code. This was
2109         tested by hand for now.
2110
2111         https://bugs.webkit.org/show_bug.cgi?id=52694
2112
2113         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2114         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2115         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2116         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2117
2118 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2119
2120         Not reviewed. Bot fix.
2121
2122         Remove an inadvertently committed debugging print.
2123
2124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2125         (LayoutTestController::notifyDone):
2126
2127 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2128
2129         Reviewed by Sam Weinig.
2130
2131         WebKitTestRunner should track loading more like DumpRenderTree
2132         https://bugs.webkit.org/show_bug.cgi?id=52692
2133
2134         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2135         This makes some tests that call notifyDone multiple times pass.
2136         
2137         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2138         (WTR::InjectedBundle::InjectedBundle):
2139         (WTR::InjectedBundle::done):
2140         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2141         (WTR::InjectedBundle::topLoadingFrame):
2142         (WTR::InjectedBundle::setTopLoadingFrame):
2143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2144         (WTR::InjectedBundlePage::InjectedBundlePage):
2145         (WTR::InjectedBundlePage::stopLoading):
2146         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2147         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2148         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2149         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2151         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2152         (WTR::LayoutTestController::notifyDone):
2153         * WebKitTestRunner/TestController.cpp:
2154         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2155
2156 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2157
2158         Reviewed by Kent Tamura.
2159
2160         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2161         https://bugs.webkit.org/show_bug.cgi?id=52678
2162         
2163         Update path now that WebKit is inside Source.
2164
2165         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2166
2167 2011-01-18  Robert Hogan  <robert@webkit.org>
2168
2169         Reviewed by Simon Hausmann.
2170
2171         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2172         https://bugs.webkit.org/show_bug.cgi?id=44282
2173
2174         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2175         (WebCore::DumpRenderTree::dump):
2176
2177 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2178
2179         Reviewed by Mihai Parparita.
2180
2181         Fix a small race condition that could cause the unit tests for
2182         new-run-webkit-tests to fail in a multithreaded environment.
2183         There was a small window in the code where one thread would
2184         check to see if a thread had raised an exception, do something,
2185         and then check to see if the thread was alive. If the other
2186         thread raised an exception and exited in between these two
2187         steps, the exception would be lost. Flipping the order of the
2188         two checks fixes the race, since we will now always check for an
2189         exception on the thread before exiting.
2190
2191         https://bugs.webkit.org/show_bug.cgi?id=51579
2192
2193         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2194
2195 2011-01-18  Eric Seidel  <eric@webkit.org>
2196
2197         Reviewed by Adam Barth.
2198
2199         commit-queue dies when test archiving fails
2200         https://bugs.webkit.org/show_bug.cgi?id=52617
2201
2202         I looked at the machine and it had 10 archives already
2203         thus find_unused_name was returning None.  I've upped
2204         the limit to 100 (per bug) and tested the case where
2205         find_unused_name returns None (making archive return None).
2206
2207         * Scripts/webkitpy/common/system/workspace.py:
2208         * Scripts/webkitpy/common/system/workspace_unittest.py:
2209         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2210         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2211         * Scripts/webkitpy/tool/commands/queues.py:
2212
2213 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2214
2215         Reviewed by Ojan Vafai.
2216
2217         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2218         filesystem. Also fix a couple of "with" statements missed by
2219         r76050.
2220
2221         https://bugs.webkit.org/show_bug.cgi?id=52487
2222
2223         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2224
2225 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2226
2227         Reviewed by Martin Robinson.
2228
2229         [Gtk] Build fixes for gtk3 build
2230         https://bugs.webkit.org/show_bug.cgi?id=52648
2231
2232         * DumpRenderTree/gtk/EventSender.cpp:
2233         (beginDragWithFilesCallback):
2234
2235 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2236
2237         Reviewed by Mihai Parparita.
2238
2239         Update rebaseline-chromium-webkit-tests to use filesystem objects
2240         instead of direct references to os.path, shutil, tempfile, etc.
2241
2242         This patch doesn't change anything, but will allow subsequent
2243         patches to change the unit tests to no longer use the real
2244         filesystem.
2245
2246         This patch adds a bunch more methods to the filesystem object as
2247         well.
2248
2249         https://bugs.webkit.org/show_bug.cgi?id=52482
2250
2251         * Scripts/webkitpy/common/system/filesystem.py:
2252         * Scripts/webkitpy/common/system/filesystem_mock.py:
2253         * Scripts/webkitpy/tool/commands/queues.py:
2254         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2255         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2256
2257 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2258
2259         Reviewed by Mihai Parparita.
2260
2261         new-run-webkit-tests shouldn't crash when you try to run a
2262         directory containing only skipped files.
2263
2264         https://bugs.webkit.org/show_bug.cgi?id=52478
2265         
2266         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2267         * Scripts/webkitpy/layout_tests/port/test.py:
2268         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2269
2270 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2271
2272         Reviewed by Gustavo Noronha Silva.
2273
2274         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2275         https://bugs.webkit.org/show_bug.cgi?id=40833
2276
2277         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2278         GTK+ event sender.
2279         (dragWithFilesDragDataGetCallback): Added.
2280         (dragWithFilesDragEndCallback): Added.
2281         (beginDragWithFilesCallback): Added.
2282
2283 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2284
2285         Reviewed by Adam Barth.
2286
2287         ews: Add additional watcher to efl ews
2288         https://bugs.webkit.org/show_bug.cgi?id=52613
2289
2290         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2291
2292         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2293
2294 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2295
2296         Reviewed by Alexey Proskuryakov.
2297
2298         Fix some headers with missing or misspelled #ifndef guards
2299         https://bugs.webkit.org/show_bug.cgi?id=52545
2300
2301         * DumpRenderTree/chromium/TestEventPrinter.h:
2302         * DumpRenderTree/chromium/WebPreferences.h:
2303
2304 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2305
2306         Reviewed by Anders Carlsson.
2307
2308         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2309         navigating back to an unreachable URL
2310         https://bugs.webkit.org/show_bug.cgi?id=52388
2311
2312         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2313
2314         * DumpRenderTree/LayoutTestController.cpp:
2315         (queueLoadHTMLStringCallback):
2316         (LayoutTestController::queueLoadHTMLString):
2317         (LayoutTestController::queueLoadAlternateHTMLString):
2318         * DumpRenderTree/LayoutTestController.h:
2319
2320         * DumpRenderTree/WorkQueueItem.h:
2321         (LoadHTMLStringItem::LoadHTMLStringItem):
2322
2323         * DumpRenderTree/chromium/LayoutTestController.cpp:
2324         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2325         (WorkItemLoadHTMLString::run):
2326         (LayoutTestController::queueLoadHTMLString):
2327
2328         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2329         (LoadHTMLStringItem::invoke):
2330         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2331         (LoadHTMLStringItem::invoke):
2332         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2333         (LoadHTMLStringItem::invoke):
2334
2335 2011-01-17  Dan Bernstein  <mitz@apple.com>
2336
2337         Rubber-stamped by Mark Rowe.
2338
2339         Update xcodeproj svn:ignore to include xcuserdata.
2340
2341         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2342         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2343         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2344         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2345         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2346
2347 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2348
2349         Unreviewed fix after r75908.
2350
2351         Move WebKit into Source
2352         https://bugs.webkit.org/show_bug.cgi?id=52530
2353
2354         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2355
2356 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2357
2358         Unreviewed.
2359
2360         Remove accidentally committed debug printing after r75908.
2361
2362         * Scripts/webkitdirs.pm:
2363
2364 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2365
2366         Unreviewed.
2367
2368         Add myself to committers list
2369         https://bugs.webkit.org/show_bug.cgi?id=52566
2370
2371         * Scripts/webkitpy/common/config/committers.py:
2372
2373 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2374
2375         Reviewed by Jeremy Orlow.
2376
2377         GeolocationController should call stopUpdating on destruction
2378         https://bugs.webkit.org/show_bug.cgi?id=52216
2379
2380         fast/dom/Geolocation/window-close-crash.html requires that a
2381         Geolocation watch be started in a secondary window. Consequently,
2382         we need to allow geolocation permission and provide a mock
2383         geolocation position for the secondary window's
2384         GeolocationClientMock.
2385
2386         * DumpRenderTree/chromium/LayoutTestController.cpp:
2387         (LayoutTestController::setGeolocationPermission):
2388         (LayoutTestController::setMockGeolocationPosition):
2389         (LayoutTestController::setMockGeolocationError):
2390         * DumpRenderTree/chromium/TestShell.h:
2391         (TestShell::windowList):
2392
2393 2011-01-16  Adam Barth  <abarth@webkit.org>
2394
2395         Update more include paths to reflect WebKit move.
2396
2397         * DumpRenderTree/chromium/EventSender.cpp:
2398         (EventSender::keyDown):
2399         (EventSender::needsShiftModifier):
2400         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2401         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2402
2403 2011-01-16  Kent Tamura  <tkent@chromium.org>
2404
2405         Unreviewed, Chromium build fix.
2406
2407         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2408
2409 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2410
2411         Build fix for GTK+ after source directory movement.
2412
2413         * GNUmakefile.am: Correct include paths.
2414
2415 2011-01-16  Adam Barth  <abarth@webkit.org>
2416
2417         Teach svn-apply about WebKit move.
2418
2419         * Scripts/VCSUtils.pm:
2420
2421 2011-01-16  Adam Barth  <abarth@webkit.org>
2422
2423         Rubber-stamped by Eric Seidel.
2424
2425         Move WebKit into Source
2426         https://bugs.webkit.org/show_bug.cgi?id=52530
2427
2428         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2429         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2430         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2431         * DumpRenderTree/qt/GCControllerQt.cpp:
2432         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2433         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2434         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2435         * DumpRenderTree/wscript:
2436         * QtTestBrowser/launcherwindow.h:
2437         * Scripts/build-webkit:
2438         * Scripts/webkitdirs.pm:
2439
2440 2011-01-15  Adam Barth  <abarth@webkit.org>
2441
2442         Teach svn-apply about WebKit2 move.
2443
2444         * Scripts/VCSUtils.pm:
2445
2446 2011-01-15  Adam Barth  <abarth@webkit.org>
2447
2448         Rubber-stamped by Eric Seidel.
2449
2450         Move WebKit2 into Source
2451         https://bugs.webkit.org/show_bug.cgi?id=52438
2452
2453         * MiniBrowser/qt/MiniBrowser.pro:
2454         * Scripts/build-webkit:
2455         * Scripts/do-file-rename:
2456         * Scripts/do-webcore-rename:
2457         * Scripts/test-webkitpy:
2458         * Scripts/webkitdirs.pm:
2459         * Scripts/webkitpy/style/checker.py:
2460         * WebKitTestRunner/DerivedSources.pro:
2461         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2462         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2463
2464 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2465
2466         Reviewed by David Levin.
2467
2468         [chromium] remove obsolete createView method
2469         https://bugs.webkit.org/show_bug.cgi?id=52437
2470
2471         * DumpRenderTree/chromium/WebViewHost.cpp:
2472         (WebViewHost::createView):
2473         * DumpRenderTree/chromium/WebViewHost.h:
2474
2475 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2476
2477         Reviewed by Geoff Garen.
2478
2479         ShouldLoadResourceForFrame should use strings, not URLs.
2480         https://bugs.webkit.org/show_bug.cgi?id=52476
2481
2482         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2483         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2484         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2485
2486 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2487
2488         Reviewed by David Levin.
2489
2490         Add Tony Gentilcore as a reviewer
2491         https://bugs.webkit.org/show_bug.cgi?id=52480
2492
2493         * Scripts/webkitpy/common/config/committers.py:
2494
2495 2011-01-14  David Levin  <levin@chromium.org>
2496
2497         Reviewed by Eric Seidel.
2498
2499         check-webkit-style: _FunctionState should keep track of where the function name starts.
2500         https://bugs.webkit.org/show_bug.cgi?id=52454
2501
2502         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2503         _FunctionState and logic for setting it correctly.
2504         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2505
2506 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2507
2508         Reviewed by David Levin.
2509
2510         Add support to DumpRenderTree to use the GPU rather than software renderer
2511         https://bugs.webkit.org/show_bug.cgi?id=52333
2512
2513         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2514         (main):
2515         * Scripts/webkitpy/layout_tests/port/chromium.py:
2516         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2517
2518 2011-01-14  Tony Chang  <tony@chromium.org>
2519
2520         Reviewed by Kent Tamura.
2521
2522         [chromium] update fonts.conf to fix 6 linux tests in drt
2523         https://bugs.webkit.org/show_bug.cgi?id=52411
2524
2525         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2526             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2527
2528 2011-01-14  Eric Seidel  <eric@webkit.org>
2529
2530         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2531
2532         Reviewed by Adam Barth.
2533
2534         Fix when running Tools/Scripts/check-webkit-style without arguments.
2535         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2536
2537         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2538         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2539
2540 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2541
2542         Reviewed by David Levin.
2543
2544         Store the tempdir object in a variable so it doesn't get deleted too early.
2545         https://bugs.webkit.org/show_bug.cgi?id=51875
2546
2547         * Scripts/update-webkit-auxiliary-libs:
2548         * Scripts/update-webkit-support-libs:
2549
2550 2011-01-14  Eric Seidel  <eric@webkit.org>
2551
2552         Unreviewed.  Make it work in python 2.5.
2553
2554         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2555         https://bugs.webkit.org/show_bug.cgi?id=49158
2556
2557         * Scripts/webkitpy/common/checkout/api_unittest.py:
2558
2559 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2560
2561         Unreviewed, rolling out r75774.
2562         http://trac.webkit.org/changeset/75774
2563         https://bugs.webkit.org/show_bug.cgi?id=52431
2564
2565         gtk builds were broken (Requested by loislo2 on #webkit).
2566
2567         * Scripts/webkitpy/common/checkout/scm.py:
2568
2569 2011-01-14  David Levin  <levin@chromium.org>
2570
2571         Reviewed by Shinichiro Hamaji.
2572
2573         check-webkit-style: _FunctionState should detect pure functions.
2574         https://bugs.webkit.org/show_bug.cgi?id=52428
2575
2576         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2577         is a pure virtual function.
2578         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2579         virtual functions are correctly detected.
2580
2581 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2582
2583         Reviewed by Yury Semikhatsky.
2584
2585         Just small fix for problem with check-webkit-style.
2586         It just didn't work for this patch.
2587         Old code can't concatenate a list of strings with None.
2588
2589         * Scripts/webkitpy/common/checkout/scm.py:
2590
2591 2011-01-13  David Levin  <levin@chromium.org>
2592
2593         Reviewed by Shinichiro Hamaji.
2594
2595         check-webkit-style: _FunctionState should use Position to know where items are.
2596         https://bugs.webkit.org/show_bug.cgi?id=52424
2597
2598         * Scripts/webkitpy/style/checkers/cpp.py:
2599         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2600         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2601         did some minor clean-up.
2602         (*): Other changes are simply about converting to use the Position's in_FunctionState
2603         instead of line numbers.
2604         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2605         to verify the positions stored in _FunctionState.
2606
2607 2011-01-13  Eric Seidel  <eric@webkit.org>
2608
2609         Reviewed by David Levin.
2610
2611         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2612         https://bugs.webkit.org/show_bug.cgi?id=49158
2613
2614         This is not the most elegant, but it is a very safe fix to this bug.
2615         One advantage of catching ScriptError like this instead of adding a
2616         new added_or_modified_files or fixing all changed_files callers
2617         to use a more specific change_files variant, is that we catch
2618         all kinds of ScriptErrors which might cause our (non-essential)
2619         suggest-reviewers code to fail out.  This should make passing
2620         --suggest-reviewers to webkit-patch upload much more robust
2621         and may even make it possible for us to make it default.
2622
2623         The root of the problem here is that SCM.changed_files includes
2624         deleted ChangeLog paths (from moves, etc) which then when we ask
2625         SVN/Git for the contents of the file at that revision, the command
2626         errors out and Executive.run_command raises a ScriptError.
2627
2628         In the future we might fix this differently by making all current
2629         callers of chagned_files use a more specific method for requesting
2630         what types of changes they're interested in (adds, modifies, deletes, etc.)
2631
2632         * Scripts/webkitpy/common/checkout/api.py:
2633         * Scripts/webkitpy/common/checkout/api_unittest.py:
2634
2635 2011-01-13  Dan Bernstein  <mitz@apple.com>
2636
2637         Reviewed by Alexey Proskuryakov.
2638
2639         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2640         https://bugs.webkit.org/show_bug.cgi?id=52419
2641
2642         Allow to further control the behavior of the willSendRequest delegate callback by making it
2643         set a different URL in the new request.
2644
2645         * DumpRenderTree/LayoutTestController.cpp:
2646         (addURLToRedirectCallback): Added.
2647         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2648         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2649         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2650         * DumpRenderTree/LayoutTestController.h:
2651         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2652         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2653         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2654         change the URL in the new request to the redirect destination.
2655
2656 2011-01-13  Eric Seidel  <eric@webkit.org>
2657
2658         Reviewed by Mihai Parparita.
2659
2660         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2661         https://bugs.webkit.org/show_bug.cgi?id=52416
2662
2663         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2664         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2665
2666         I also added FIXMEs about the changed_files returning deleted files problem
2667         which is causing the other most common exception for suggest-reviewers
2668         (and is probably breaking sheriff-bots blame detection).
2669
2670         * Scripts/webkitpy/common/checkout/api.py:
2671         * Scripts/webkitpy/common/checkout/api_unittest.py:
2672         * Scripts/webkitpy/common/checkout/scm.py:
2673
2674 2011-01-13  Eric Seidel  <eric@webkit.org>
2675
2676         Reviewed by Adam Barth.
2677
2678         results archives from commit-queue are too large to upload
2679         https://bugs.webkit.org/show_bug.cgi?id=52405
2680
2681         * Scripts/webkitpy/common/system/filesystem.py:
2682         * Scripts/webkitpy/common/system/filesystem_mock.py:
2683         * Scripts/webkitpy/tool/commands/queues.py:
2684
2685 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2686
2687         Reviewed by Martin Robinson.
2688
2689         [gtk] Zero-sized font does not yet work
2690         https://bugs.webkit.org/show_bug.cgi?id=49793
2691
2692         Set minimum-font-size to 0 for the DRT.
2693
2694         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2695         (resetDefaultsToConsistentValues):
2696
2697 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2698
2699         Reviewed by Darin Adler.
2700
2701         Make old-run-webkit-tests more robust on buildbots
2702         https://bugs.webkit.org/show_bug.cgi?id=52364
2703
2704         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2705
2706 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2707
2708         Reviewed by Darin Adler.
2709
2710         Make old-run-webkit-tests more robust on buildbots
2711         https://bugs.webkit.org/show_bug.cgi?id=52364
2712
2713         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2714
2715 2011-01-13  Tony Chang  <tony@chromium.org>
2716
2717         Reviewed by Kent Tamura.
2718
2719         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2720         https://bugs.webkit.org/show_bug.cgi?id=52332
2721
2722         Forked Info.plist is not longer needed.
2723
2724         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2725
2726 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2727
2728         Reviewed by Timothy Hatcher.
2729
2730         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2731         to be passed directly to WebInspector.UIString
2732
2733         https://bugs.webkit.org/show_bug.cgi?id=52365
2734
2735         * Scripts/check-inspector-strings:
2736
2737 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2738
2739         Unreviewed, rolling out r74881.
2740         http://trac.webkit.org/changeset/74881
2741         https://bugs.webkit.org/show_bug.cgi?id=52357
2742
2743         The EFL builder has been red for days (Requested by abarth on
2744         #webkit).
2745
2746         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2747         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2748
2749 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2750
2751         Reviewed by David Levin.
2752
2753         Add beforeunload support to WebKitTestRunner
2754         https://bugs.webkit.org/show_bug.cgi?id=52353
2755         
2756         This makes a number of currently failing tests pass.
2757
2758         * WebKitTestRunner/TestController.cpp:
2759         (WTR::runBeforeUnloadConfirmPanel):
2760         (WTR::createOtherPage):
2761         (WTR::TestController::initialize):
2762
2763 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2764
2765         Reviewed by Sam Weinig.
2766
2767         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2768         https://bugs.webkit.org/show_bug.cgi?id=52330
2769
2770         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2771         a web process crash.
2772         * WebKitTestRunner/TestController.cpp:
2773         (WTR::TestController::initialize): Set up a processDidCrash
2774         callback.
2775         (WTR::TestController::processDidCrash): Report that the Web process
2776         crashed.
2777         * WebKitTestRunner/TestController.h:
2778
2779 2011-01-12  David Levin  <levin@chromium.org>
2780
2781         Reviewed by Shinichiro Hamaji.
2782
2783         check-webkit-style -- close_expression function doesn't work correctly.
2784         https://bugs.webkit.org/show_bug.cgi?id=52272
2785
2786         * Scripts/webkitpy/style/checkers/cpp.py:
2787         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2788         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2789         generally useful (for upcoming code changes).
2790         (close_expression): Changed to use Position for input and output.
2791         Also, fixed many bugs such as only working correctly for parenthesis,
2792         not working correctly if given an offset in a line and not finding
2793         the real closing element if there were multiple closing elements in
2794         the same line.
2795         (detect_functions): Adjusted due to the change in arguments for
2796         close_expression.
2797         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2798         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2799         two positions are the same.
2800         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2801         (CppStyleTest.test_close_expression): Added tests to catch the issues
2802         that were fixed.
2803
2804 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2805
2806         Unreviewed, rolling out r75576.
2807         http://trac.webkit.org/changeset/75576
2808         https://bugs.webkit.org/show_bug.cgi?id=52304
2809
2810         broke rebaseline-chromium-webkit-test (Requested by thakis on
2811         #webkit).
2812
2813         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2814         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2815         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2816         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2817         * Scripts/webkitpy/layout_tests/port/base.py:
2818         * Scripts/webkitpy/layout_tests/port/chromium.py:
2819         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2820         * Scripts/webkitpy/layout_tests/port/test.py:
2821         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2822         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2823         * Scripts/webkitpy/style/checkers/test_expectations.py:
2824         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2825
2826 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2827
2828         Reviewed by Darin Adler.
2829
2830         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2831         https://bugs.webkit.org/show_bug.cgi?id=52307
2832
2833         * Scripts/old-run-webkit-tests:
2834
2835 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2836
2837         Reviewed by Martin Robinson.
2838
2839         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2840         https://bugs.webkit.org/show_bug.cgi?id=50867
2841
2842         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2843         TestNetscapePlugin.cpp 
2844
2845         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2846         * Scripts/webkitdirs.pm:
2847
2848 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2849
2850         Reviewed by Pavel Feldman.
2851
2852         Add check-inspector-strings script.
2853
2854         https://bugs.webkit.org/show_bug.cgi?id=52295
2855
2856         * Scripts/check-inspector-strings: Added.
2857
2858 2011-01-12  Adam Roben  <aroben@apple.com>
2859
2860         Advertise the .testnetscape file extension on Windows
2861
2862         Fixes <http://webkit.org/b/52298>
2863         plugins/no-mime-with-valid-extension.html fails on Windows
2864
2865         Reviewed by Dan Bernstein.
2866
2867         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2868         FileExtents field to map the .testnetscape file extension to the
2869         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2870
2871 2011-01-12  Adam Barth  <abarth@webkit.org>
2872
2873         Reviewed by Eric Seidel.
2874
2875         Make webkit-patch support subdirectories for SVN checkouts
2876         https://bugs.webkit.org/show_bug.cgi?id=52261
2877
2878         os.relpath does not exist on Python 2.5, so we need to call our version
2879         of the API.
2880
2881         * Scripts/webkitpy/common/checkout/scm.py:
2882
2883 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2884
2885         Reviewed by Eric Seidel.
2886
2887         Close additional pages opened during a test once the test completes.
2888         https://bugs.webkit.org/show_bug.cgi?id=52276
2889
2890         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2891         (WTR::InjectedBundle::done):
2892
2893 2011-01-11  David Levin  <levin@chromium.org>
2894
2895         Reviewed by Eric Seidel.
2896
2897         Errors should be separated from the command line in bot messages.
2898         https://bugs.webkit.org/show_bug.cgi?id=52275
2899
2900         * Scripts/webkitpy/common/system/executive.py:
2901         (ScriptError.message_with_output): Added a newline to separate the command
2902         line from the errors.
2903         * Scripts/webkitpy/common/system/executive_unittest.py:
2904         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2905         paths in message_with_output.
2906
2907 2011-01-11  Eric Seidel  <eric@webkit.org>
2908
2909         Unreviewed.
2910
2911         commit-queue should know how to upload archived results (for test flakes or general failures)
2912         https://bugs.webkit.org/show_bug.cgi?id=52048
2913
2914         The zips are mostly empty due to forgetting -r.
2915         Expected diffs were not being pulled from the archive due
2916         to the archive having longer paths than I realized.
2917
2918         * Scripts/webkitpy/common/system/workspace.py:
2919         * Scripts/webkitpy/common/system/workspace_unittest.py:
2920         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2921         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2922
2923 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2924
2925         Reviewed by Ojan Vafai.
2926
2927         The current modifier parsing code in test_expectations is
2928         fragile and hard-coded, so it's not easy to understand the logic
2929         or easily add new types of modifiers (like GPU vs. CPU testing
2930         for graphics tests, or 32-bit vs. 64-bit differences).
2931
2932         This is the first of two patches that will add in more generic
2933         support and then eliminate the GPU-specific test expectations
2934         files for Chromium.
2935
2936         This patch adds two standalone objects for handling modifiers. The
2937         rules for interpreting modifiers, precedence, and conflicts are
2938         given in the docstring to the ModifierMatcher class, which
2939         returns ModifierMatchResult objects.
2940         
2941         This patch also adds routines to the Port interface and a
2942         default set of values in the base object, in order to obtain the
2943         values needed on a given test run. These values are then passed
2944         to the expectation parser. This also allows us to clean up the
2945         logic used to lint all of the different configurations in a
2946         single test_expectations.txt file.
2947
2948         The next patch will merge in the separate GPU expectations file.
2949
2950         https://bugs.webkit.org/show_bug.cgi?id=51222
2951
2952         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2953         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2954         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2955         * Scripts/webkitpy/layout_tests/port/base.py:
2956         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2957         * Scripts/webkitpy/layout_tests/port/chromium.py:
2958         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2959         * Scripts/webkitpy/layout_tests/port/test.py:
2960         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2961         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2962
2963 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2964
2965         Reviewed by Adam Barth.
2966
2967         Make webkit-patch support subdirectories for SVN checkouts
2968         https://bugs.webkit.org/show_bug.cgi?id=52261
2969
2970         * Scripts/webkitpy/common/checkout/scm.py:
2971         * Scripts/webkitpy/style_references.py:
2972         * Scripts/webkitpy/tool/main.py:
2973         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2974
2975 2011-01-11  Eric Seidel  <eric@webkit.org>
2976
2977         Unreviewed.
2978
2979         commit-queue should know how to upload archived results (for test flakes or general failures)
2980         https://bugs.webkit.org/show_bug.cgi?id=52048
2981
2982         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2983         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2984
2985         * Scripts/webkitpy/common/system/workspace.py:
2986         * Scripts/webkitpy/common/system/workspace_unittest.py:
2987         * Scripts/webkitpy/tool/commands/queues.py:
2988
2989 2011-01-11  Sam Weinig  <sam@webkit.org>
2990
2991         Roll r75474 back in.
2992
2993 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2994
2995         Reviewed by Kenneth Rohde Christiansen.
2996
2997         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2998         https://bugs.webkit.org/show_bug.cgi?id=51204
2999
3000         * QtTestBrowser/webpage.h:
3001         (QtNAMThread::QtNAMThread):
3002         (QtNAMThread::networkAccessManager):
3003         (QtNAMThread::run):
3004
3005 2011-01-11  Peter Varga  <pvarga@webkit.org>
3006
3007         Unreviewed.
3008
3009         Add myself to committers' list.
3010
3011         * Scripts/webkitpy/common/config/committers.py:
3012
3013 2011-01-11  Eric Seidel  <eric@webkit.org>
3014
3015         Reviewed by Adam Barth.
3016
3017         commit-queue should know how to upload archived results (for test flakes or general failures)
3018         https://bugs.webkit.org/show_bug.cgi?id=52048
3019
3020         Now the queue will always upload results.  Either the entire zip, or just
3021         the diffs.txt in the case of text failures.
3022
3023         This should make understanding flakes much easier, and paves the way
3024         for having the EWS run layout tests (and upload failures).
3025
3026         In order to upload .zip files I had to teach bugzilla.py to autodetect
3027         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3028         for .patch files, I have it add one before calling guess_type.
3029
3030         We may find that always uploading the whole zip instead of just the -diffs.txt
3031         file is preferable, but for now I'm keeping the old behavior because it makes
3032         quickly understanding text failures easy.
3033
3034         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3035         * Scripts/webkitpy/common/system/workspace.py: Added.
3036         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3037         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3038         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3039         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3040         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3041         * Scripts/webkitpy/tool/commands/queues.py:
3042         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3043
3044 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3045
3046         Unreviewed, rolling out r75464.
3047         http://trac.webkit.org/changeset/75464
3048         https://bugs.webkit.org/show_bug.cgi?id=52193
3049
3050         Followup rollout for 75474 (Requested by Ossy on #webkit).
3051
3052         * MiniBrowser/mac/BrowserWindowController.m:
3053         (-[BrowserWindowController awakeFromNib]):
3054         * MiniBrowser/win/BrowserView.cpp:
3055         (BrowserView::create):
3056         * WebKitTestRunner/TestController.cpp:
3057         (WTR::createOtherPage):
3058         (WTR::TestController::initialize):
3059
3060 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3061
3062         Reviewed by Csaba Osztrogonác.
3063
3064         [Qt] Baseline qt_minimal configuration
3065         https://bugs.webkit.org/show_bug.cgi?id=51313
3066
3067         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3068         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3069         QT_NO_UNDOSTACK guard.
3070
3071         * QtTestBrowser/launcherwindow.cpp:
3072         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3073         guards.
3074         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3075         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3076         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3077         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3078
3079         * QtTestBrowser/launcherwindow.h:
3080         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3081         * QtTestBrowser/locationedit.h: Ditto.
3082
3083         * QtTestBrowser/mainwindow.cpp:
3084         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3085         QT_NO_UNDOSTACK guards.
3086         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3087         (MainWindow::changeLocation): Ditto.
3088         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3089         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3090
3091         * QtTestBrowser/webpage.cpp:
3092         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3093         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3094
3095         * QtTestBrowser/webview.cpp:
3096         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3097         (WebViewGraphicsBased::animatedYFlip): Ditto.
3098
3099 2011-01-10  Sam Weinig  <sam@webkit.org>
3100
3101         Fix build.
3102
3103         * MiniBrowser/mac/BrowserWindowController.m:
3104         (-[BrowserWindowController awakeFromNib]):
3105         * MiniBrowser/win/BrowserView.cpp:
3106         (BrowserView::create):
3107         * WebKitTestRunner/TestController.cpp:
3108         (WTR::createOtherPage):
3109         (WTR::TestController::initialize):
3110
3111 2011-01-10  Eric Seidel  <eric@webkit.org>
3112
3113         Reviewed by Ojan Vafai.
3114
3115         style-queue messages are way too long for big patches
3116         https://bugs.webkit.org/show_bug.cgi?id=52161
3117
3118         We definitely could build much fancier list-to-string-with-limit functions
3119         but this should be sufficient for our needs at the moment.
3120
3121         * Scripts/webkitpy/common/system/executive.py:
3122         * Scripts/webkitpy/common/system/executive_unittest.py:
3123
3124 2011-01-10  Tony Chang  <tony@chromium.org>
3125
3126         Unreviewed, rolling out r75398.
3127         http://trac.webkit.org/changeset/75398
3128         https://bugs.webkit.org/show_bug.cgi?id=52008
3129
3130         Some layout tests are crashing on Chromium Win.
3131
3132         * DumpRenderTree/chromium/WebViewHost.cpp:
3133         (WebViewHost::updatePaintRect):
3134         * DumpRenderTree/chromium/WebViewHost.h:
3135
3136 2011-01-10  Adam Roben  <aroben@apple.com>
3137
3138         Roll out r75392
3139
3140         It isn't needed now that r75289 has been rolled out.
3141
3142         * Scripts/run-javascriptcore-tests:
3143
3144 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3145
3146         Reviewed by Anders Carlsson.
3147
3148         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3149         https://bugs.webkit.org/show_bug.cgi?id=52160
3150
3151         * WebKitTestRunner/mac/TestControllerMac.mm:
3152         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3153         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3154         anyway.
3155
3156 2011-01-10  Tony Chang  <tony@chromium.org>
3157
3158         Reviewed by Mihai Parparita.
3159
3160         [chromium] fix for animated gif layout tests
3161         https://bugs.webkit.org/show_bug.cgi?id=52008
3162
3163         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3164             to trigger gif animations.
3165         (WebViewHostPaintTask::WebViewHostPaintTask):
3166         (WebViewHostPaintTask::runIfValid):
3167         (WebViewHost::updatePaintRect):
3168         * DumpRenderTree/chromium/WebViewHost.h:
3169         (WebViewHost::taskList):
3170
3171 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3172
3173         Reviewed by Xan Lopez.
3174
3175         [GTK] Fix gtk2 compilation for master
3176         https://bugs.webkit.org/show_bug.cgi?id=51885
3177
3178         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3179         (createBitmapContextFromWebView): Replaced the old
3180         gdk_drawable_get_size with gdk_pixmap_get_size.
3181
3182 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3183
3184         Reviewed by Laszlo Gombos.
3185
3186         [WINCE] Reenable NPAPI after r75203
3187         https://bugs.webkit.org/show_bug.cgi?id=52109
3188
3189         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3190         it with !isEfl(), because EFL port does not support NPAPI (yet).
3191
3192         * Scripts/build-webkit:
3193
3194 2011-01-10  Adam Roben  <aroben@apple.com>
3195
3196         Skip some asserting JS tests
3197
3198         See <http://webkit.org/b/52156>.
3199
3200         * Scripts/run-javascriptcore-tests:
3201
3202 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3203
3204         Reviewed by Xan Lopez.
3205
3206         [GTK] build-webkit disable Blob support via arguments passed to automake
3207         https://bugs.webkit.org/show_bug.cgi?id=52097
3208
3209         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3210         build-webkit.
3211
3212 2011-01-10  Adam Roben  <aroben@apple.com>
3213
3214         Use the same name and description for TestNetscapePlugin on Windows and
3215         Mac
3216
3217         Fixes <http://webkit.org/b/52151>
3218         fast/frames/iframe-reparenting-plugins.html fails on Windows
3219
3220         Reviewed by Steve Falkenburg.
3221
3222         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3223         the name and description from Mac's Info.plist.
3224
3225 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3226
3227         Reviewed by Laszlo Gombos.
3228
3229         [Qt][WK2] Guard gcc-specific syntax
3230
3231         Non-gcc based compliers choke on the "-include"
3232         syntax for preinclude, place guard around it.
3233
3234         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3235         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3236
3237 2011-01-10  Andreas Kling  <kling@webkit.org>
3238
3239         Reviewed by Simon Hausmann.
3240
3241         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3242         https://bugs.webkit.org/show_bug.cgi?id=52111
3243
3244         When getting a createNewPage() callback from QWKPage, create the
3245         new page with the same QWKContext as the page that is passed to
3246         the callback.
3247
3248         * MiniBrowser/qt/BrowserView.h:
3249         * MiniBrowser/qt/BrowserWindow.cpp:
3250         (newPageFunction):
3251         (BrowserWindow::BrowserWindow):
3252         * MiniBrowser/qt/BrowserWindow.h:
3253
3254 2011-01-10  Andreas Kling  <kling@webkit.org>
3255
3256         Reviewed by Kenneth Rohde Christiansen.
3257
3258         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3259
3260         BrowserView set its own useless createNewPage() callback on QWKPage.
3261         This was immediately overridden by BrowserWindow anyway, so remove
3262         the BrowserView one.
3263
3264         * MiniBrowser/qt/BrowserView.cpp:
3265         (BrowserView::BrowserView):
3266
3267 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3268
3269         Reviewed by Jeremy Orlow.
3270
3271         [Chromium] Remove non-client-based Geolocation code
3272         https://bugs.webkit.org/show_bug.cgi?id=50921
3273
3274         * DumpRenderTree/chromium/LayoutTestController.cpp:
3275         (LayoutTestController::setGeolocationPermission):
3276         (LayoutTestController::setMockGeolocationPosition):
3277         (LayoutTestController::setMockGeolocationError):
3278         * DumpRenderTree/chromium/WebViewHost.cpp:
3279         (WebViewHost::geolocationClientMock):
3280         (WebViewHost::reset):
3281         * DumpRenderTree/chromium/WebViewHost.h:
3282
3283 2011-01-10  Eric Seidel  <eric@webkit.org>
3284
3285         Reviewed by Adam Barth.
3286
3287         Commit bot tried to land r? cq+ patch
3288         https://bugs.webkit.org/show_bug.cgi?id=36638
3289
3290         It should now be possible to post a patch with r? and cq+ and the
3291         commit-queue will correctly wait for the r+ before attempting to land the patch.
3292         (This was a feature requested by several users.)
3293
3294         One caveat: We don't actually reject r-, cq+ patches from the queue
3295         (we just ignore them), but I think that's OK for now.
3296
3297         I also noticed that setting r- once a commit-queue node had grabbed
3298         a patch would not properly cancel the landing.  That's fixed and
3299         tested in this patch.
3300
3301         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3302         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3303         * Scripts/webkitpy/tool/bot/feeders.py:
3304         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3305
3306 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3307
3308         Reviewed by Kenneth Rohde Christiansen.
3309
3310         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3311         https://bugs.webkit.org/show_bug.cgi?id=51934
3312
3313         When accessing the network from the destructor of QWebPage, the network access manager
3314         was already deleted because the object WebPage was already destructed.
3315
3316         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3317         The object is now destructed in the destructor of QObject.
3318
3319         * QtTestBrowser/webpage.cpp:
3320         (WebPage::WebPage):
3321         (WebPage::setQnamThreaded):
3322         * QtTestBrowser/webpage.h:
3323         (QtNAMThread::QtNAMThread):
3324
3325 2011-01-08  Eric Seidel  <eric@webkit.org>
3326
3327         Reviewed by Ojan Vafai.
3328
3329         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3330         https://bugs.webkit.org/show_bug.cgi?id=52067
3331
3332         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3333         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3334
3335         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3336
3337 2011-01-08  Eric Seidel  <eric@webkit.org>
3338
3339         Reviewed by Mihai Parparita.
3340
3341         commit-queue hangs when the ChangeLog diff is bad
3342         https://bugs.webkit.org/show_bug.cgi?id=52072
3343
3344         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3345         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3346
3347 2011-01-08  Adam Barth  <abarth@webkit.org>
3348
3349         Teach svn-apply how to re-write WebCore to Source/WebCore.
3350
3351         * Scripts/VCSUtils.pm:
3352
3353 2011-01-07  Adam Barth  <abarth@webkit.org>
3354
3355         Rubber-stamped by Eric Seidel.
3356
3357         Move WebCore to Source
3358         https://bugs.webkit.org/show_bug.cgi?id=52050
3359
3360         Update the tools to understand WebCore's new location.
3361
3362         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3363         * DumpRenderTree/wscript:
3364         * GNUmakefile.am:
3365         * Scripts/build-webkit:
3366         * Scripts/do-file-rename:
3367         * Scripts/do-webcore-rename:
3368         * Scripts/generate-qt-inspector-resource:
3369         * Scripts/prepare-ChangeLog:
3370         * Scripts/run-bindings-tests:
3371         * Scripts/update-iexploder-cssproperties:
3372         * Scripts/update-sources-list.py:
3373         * Scripts/update-webkit-localizable-strings:
3374         * Scripts/webkitdirs.pm:
3375         * Scripts/webkitpy/common/config/build.py:
3376         * Scripts/webkitpy/common/config/build_unittest.py:
3377         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3378         * Scripts/webkitpy/style/checker.py:
3379         * Scripts/webkitpy/style/checker_unittest.py:
3380         * WebKitTestRunner/DerivedSources.pro:
3381         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3382         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3383         * wx/browser/wscript:
3384         * wx/build/settings.py:
3385
3386 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3387
3388         Reviewed by Sam Weinig.
3389
3390         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3391         https://bugs.webkit.org/show_bug.cgi?id=52086
3392
3393         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3394         (WTR::InjectedBundle::didReceiveMessage):
3395         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3396         (WTR::LayoutTestController::notifyDone):
3397         * WebKitTestRunner/TestController.cpp:
3398         (WTR::TestController::resetStateToConsistentValues):
3399         (WTR::TestController::run):
3400
3401 2011-01-07  James Robinson  <jamesr@chromium.org>
3402
3403         Revert "Implement mozilla's animationTime property"
3404         https://bugs.webkit.org/show_bug.cgi?id=51952
3405
3406         This approach isn't quite right.
3407
3408         * DumpRenderTree/chromium/WebViewHost.cpp:
3409         (WebViewHost::paintInvalidatedRegion):
3410
3411 2011-01-07  Adam Roben  <aroben@apple.com>
3412
3413         Build master fix
3414
3415         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3416         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3417
3418 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3419
3420         Reviewed by Csaba Osztrogonác.
3421
3422         run-qtwebkit-tests should be able to kill a testsuite.
3423
3424         Add new option in the script that can setup a timeout for a test.
3425         If the test execution takes more then specified time then the test
3426         would be terminated.
3427
3428         [Qt] run-qtwebkit-tests needs timeout
3429         https://bugs.webkit.org/show_bug.cgi?id=51894
3430
3431         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3432         * Scripts/run-qtwebkit-tests:
3433
3434 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3435
3436         Unreviewed fix after r75233.
3437
3438         Based on idea from Eric Seidel.
3439
3440         Add remote zip file handling to webkitpy.
3441         https://bugs.webkit.org/show_bug.cgi?id=50901
3442
3443         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3444
3445 2011-01-07  Shane Stephens  <shanestephens@google.com>
3446
3447         Reviewed by Eric Seidel.
3448
3449         svn-apply: should support git binary delta diffs
3450         https://bugs.webkit.org/show_bug.cgi?id=38864
3451
3452         * Scripts/VCSUtils.pm:
3453         * Scripts/svn-apply:
3454
3455 2011-01-06  Julie Parent  <jparent@chromium.org>
3456
3457         Reviewed by Eric Seidel.
3458
3459         Test Result Server not removing old results.
3460         https://bugs.webkit.org/show_bug.cgi?id=52012
3461
3462         * TestResultServer/model/jsonresults.py:
3463         Fix off-by-one: Truncate if >= num_runs, not just >.
3464         * TestResultServer/model/jsonresults_unittest.py:
3465         Add unit test to test that merging in a new result with the same value
3466         as the last result causes previous result to fall off.
3467
3468 2011-01-06  James Kozianski  <koz@chromium.org>
3469
3470         Reviewed by Mihai Parparita.
3471
3472         Add classes to provide a consistent interface to a set of files.
3473         https://bugs.webkit.org/show_bug.cgi?id=50901
3474
3475         These classes allow us to write code that is agnostic to whether a
3476         particular set of files resides in a local directory or in a zip file
3477         on a remote machine.
3478
3479         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3480         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3481         * Scripts/webkitpy/common/system/fileset.py: Added.
3482         * Scripts/webkitpy/common/system/filesystem.py:
3483         * Scripts/webkitpy/common/system/filesystem_mock.py:
3484         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3485         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3486
3487 2011-01-06  Eric Seidel  <eric@webkit.org>
3488
3489         Reviewed by Adam Barth.
3490
3491         NetworkTransaction should log the url it is retrying
3492         https://bugs.webkit.org/show_bug.cgi?id=52043
3493
3494         * Scripts/webkitpy/common/net/networktransaction.py:
3495         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3496
3497 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3498
3499         Windows build fix.
3500         Import os before using it.
3501
3502         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3503
3504 2011-01-06  Eric Seidel  <eric@webkit.org>
3505
3506         Reviewed by Adam Barth.
3507
3508         StyleQueue fails to report errors when patches have many files
3509         https://bugs.webkit.org/show_bug.cgi?id=52042
3510
3511         This is one of at least two errors preventing style error reporting at the moment.
3512         When we moved to passing the list of files to check explicitly,
3513         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3514         We could change the type of the QueueStatus.message type, or we could
3515         just teach statusserver.py how to clamp values (and warn when it does).
3516         I chose the latter path.
3517
3518         * Scripts/webkitpy/common/net/statusserver.py:
3519
3520 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3521
3522         Reviewed by Stephanie Lewis.
3523         
3524         Fix syntax error in script.
3525
3526         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3527         https://bugs.webkit.org/show_bug.cgi?id=51996
3528
3529         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3530
3531 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3532
3533         Unreviewed, fixing WinCE build after r75196.
3534
3535         WinCE port does not (yet) support NPAPI.
3536
3537         * Scripts/build-webkit:
3538
3539 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3540
3541         Reviewed by Darin Adler.
3542
3543         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3544         https://bugs.webkit.org/show_bug.cgi?id=52015
3545
3546         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3547         after the platform has been detected, otherwise the script will
3548         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3549         detection.
3550
3551 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3552
3553         Reviewed by Eric Seidel.
3554
3555         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3556         https://bugs.webkit.org/show_bug.cgi?id=51346
3557
3558         * Scripts/build-webkit:
3559
3560 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3561
3562         Reviewed by Adam Roben.
3563
3564         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3565         https://bugs.webkit.org/show_bug.cgi?id=51996
3566         
3567         After the configuration directory change, we were archiving the incorrect directory for
3568         build product, so we were running tests on the wrong binaries.
3569         
3570         This change archives the correct directory, and also unarchives it into a configuration-
3571         specific directory.
3572
3573         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3574         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3575
3576 2011-01-06  Eric Seidel  <eric@webkit.org>
3577
3578         Reviewed by Mihai Parparita.
3579
3580         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3581         https://bugs.webkit.org/show_bug.cgi?id=52002
3582
3583         See an example of this here:
3584         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3585
3586         It's due to the fact that we pass around TestFailure() instance
3587         objects and yet expect them to all compare to be the same.
3588
3589         This is bad.  We should either have shared instances of these values
3590         or we should just pass around the class names.  There are already hacks
3591         in place to make TestFailure objects pass equality tests, I just added
3592         a __hash__ implementation so they can be used in sets as expected.
3593
3594         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3595         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3596
3597 2011-01-06  Evan Martin  <evan@chromium.org>
3598
3599         Reviewed by Tony Chang.
3600
3601         [gdb] handle inaccessible memory and UChar*
3602         https://bugs.webkit.org/show_bug.cgi?id=52003
3603
3604         To pretty-print a UChar*, we just grope around in the memory
3605         looking for a terminating NUL.  We need to handle the exception
3606         that can occur when we poke into an invalid location.
3607
3608         Additionally, the logic for choosing which pretty-printer would
3609         early return before hitting the point where we'd use the UChar*
3610         printer.  (Did this ever work?  How did it regress?)
3611
3612         * gdb/webkit.py:
3613
3614 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3615
3616         Reviewed by Ada Chan.
3617
3618         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3619         https://bugs.webkit.org/show_bug.cgi?id=51969
3620         
3621         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3622
3623         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3624         (WTR::InjectedBundlePage::InjectedBundlePage):
3625         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3626         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3627
3628 2011-01-06  James Robinson  <jamesr@chromium.org>
3629
3630         Reviewed by Simon Fraser.
3631
3632         Implement mozilla's animationTime property
3633         https://bugs.webkit.org/show_bug.cgi?id=51952
3634
3635         Chromium DRT support for webkitAnimationTime.
3636
3637         * DumpRenderTree/chromium/WebViewHost.cpp:
3638         (WebViewHost::paintInvalidatedRegion):
3639
3640 2011-01-06  Julie Parent  <jparent@chromium.org>
3641
3642         Reviewed by Tony Chang.
3643
3644         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3645         https://bugs.webkit.org/show_bug.cgi?id=51217
3646
3647         * TestResultServer/model/jsonresults.py:
3648         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3649         Adds missing documentation.
3650         * TestResultServer/model/jsonresults_unittest.py:
3651         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3652         Update test_merge to take a number of builds to truncate at.
3653
3654 2011-01-06  Adam Barth  <abarth@webkit.org>
3655
3656         Reviewed by Eric Seidel.
3657
3658         The EWS should log outside of the working directory
3659         https://bugs.webkit.org/show_bug.cgi?id=51986
3660
3661         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3662         script, which will actually clean the working copy back to a pristine
3663         state instead of leaving untracked directories and ignored files.
3664
3665         * Scripts/webkitpy/tool/commands/queues.py:
3666         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3667
3668 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3669
3670         Windows build fix.
3671         Back out attempted change to built-product-archive.
3672
3673         * BuildSlaveSupport/built-product-archive:
3674
3675 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3676
3677         Windows build fix.
3678         Include configuration name when unpacking a build archive.
3679
3680         Needed, since we split Windows build results into configuration-specific directories
3681         under WebKitOutputDir.
3682
3683         * BuildSlaveSupport/built-product-archive:
3684
3685 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3686
3687         Reviewed by Darin Adler.
3688
3689         Debug and Release builds on Windows clobber each other
3690         https://bugs.webkit.org/show_bug.cgi?id=49185
3691
3692         Changes the structure of WebKitBuild build products directory so we
3693         completely separate each build configuration into independent directories.
3694         
3695         Although we previously had per-configuration directories for obj, this change adds
3696         per-configuration directories for bin, lib, obj, and include. Each configuration's
3697         build products are stored within a directory inside of WebKitBuild.
3698         
3699         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3700         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3701
3702         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3703         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3704         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3705         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3706         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3707         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3708         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3709         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3710         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3711         * FindSafari/FindSafari.vcproj:
3712         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3713         * MiniBrowser/MiniBrowserPostBuild.cmd:
3714         * MiniBrowser/MiniBrowserPreBuild.cmd:
3715         * Scripts/webkitdirs.pm:
3716         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3717         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3718         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3719         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3720         * TestWebKitAPI/win/copy-resources.cmd:
3721         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3722         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3723         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3724         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3725         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3726         * WebKitTestRunner/win/InjectedBundle.vcproj:
3727         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3728         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3729         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3730         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3731         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3732         * WinLauncher/WinLauncherCommon.vsprops:
3733         * WinLauncher/WinLauncherPostBuild.cmd:
3734         * WinLauncher/WinLauncherPreBuild.cmd:
3735
3736 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3737
3738         Reviewed by Ariya Hidayat.
3739
3740         [Qt] TestNetscapePlugin doesn't link on OS X
3741         https://bugs.webkit.org/show_bug.cgi?id=51948
3742
3743         Only add a dependency on libX11 on X11 systems
3744
3745         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3746
3747 2011-01-05  Jeff Miller  <jeffm@apple.com>
3748
3749         Reviewed by Adam Roben.
3750
3751         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3752         https://bugs.webkit.org/show_bug.cgi?id=51970
3753
3754         * Scripts/webkitpy/style/checker.py:
3755         Add -readability/naming for WebKit2 C API directories.
3756
3757 2011-01-05  Eric Seidel  <eric@webkit.org>
3758
3759         Unreviewed, just fixing one more log error from my previous python patch.
3760
3761         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3762         https://bugs.webkit.org/show_bug.cgi?id=51802
3763
3764         webkit-patch failure-reason was logging about parsing errors
3765         due to my misunderstanding of how BeautifulSoup.findAll worked.
3766
3767         Fixed, and added a unit test.
3768
3769         * Scripts/webkitpy/common/net/layouttestresults.py:
3770         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3771
3772 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3773
3774         Reviewed by Kenneth Rohde Christiansen.
3775
3776         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3777         https://bugs.webkit.org/show_bug.cgi?id=51951
3778
3779         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3780         to create new window from WebKit.
3781
3782         * MiniBrowser/qt/BrowserWindow.cpp:
3783         (newPageFunction):
3784         (BrowserWindow::BrowserWindow):
3785         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3786         (BrowserWindow::newWindow):
3787         (BrowserWindow::updateUserAgentList):
3788         (BrowserWindow::showUserAgentDialog):
3789         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3790         define the type of the backing store used for new windows.